Remove WML
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-29  David Kilzer  <ddkilzer@apple.com>
2
3         Remove WML
4         https://bugs.webkit.org/show_bug.cgi?id=59678
5
6         * DerivedSources.make: Removed $(WebCore)/wml path in VPATH.
7
8 2011-04-29  James Robinson  <jamesr@chromium.org>
9
10         Unreviewed, rolling out r85330.
11         http://trac.webkit.org/changeset/85330
12         https://bugs.webkit.org/show_bug.cgi?id=41311
13
14         Caused unexpected border rendering change on 500 tests on chromium linux.
15
16         * platform/graphics/skia/GraphicsContextSkia.cpp:
17         (WebCore::GraphicsContext::drawConvexPolygon):
18         (WebCore::GraphicsContext::clipConvexPolygon):
19
20 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
21
22         [Qt] Unreviewed buildfix after r85343.
23
24         Enable strict OwnPtr for Qt
25         https://bugs.webkit.org/show_bug.cgi?id=59667
26
27         * plugins/win/PluginViewWin.cpp:
28         (WebCore::PluginView::wndProc):
29         (WebCore::PluginView::snapshot):
30
31 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
32
33         Reviewed by Adam Barth.
34
35         Enable strict OwnPtr for Qt
36         https://bugs.webkit.org/show_bug.cgi?id=59667
37
38         * platform/graphics/qt/ImageBufferQt.cpp:
39         (WebCore::ImageBufferData::ImageBufferData):
40         (WebCore::ImageBuffer::ImageBuffer):
41         * platform/graphics/qt/ImageDecoderQt.cpp:
42         (WebCore::ImageDecoderQt::setData):
43         * platform/graphics/qt/ImageDecoderQt.h:
44         * platform/network/qt/QNetworkReplyHandler.cpp:
45         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
46         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
47
48 2011-04-29  Dean Jackson  <dino@apple.com>
49
50         Reviewed by Simon Fraser.
51
52         Add ENABLE macro for WebKitAnimation
53         https://bugs.webkit.org/show_bug.cgi?id=59729
54
55         Add new feature to toggle WebKit Animation API.
56
57         * Configurations/FeatureDefines.xcconfig:
58         * GNUmakefile.am:
59         * dom/Element.idl:
60         * features.pri:
61         * page/DOMWindow.idl:
62
63 2011-04-29  Dean Jackson  <dino@apple.com>
64
65         Reviewed by Simon Fraser.
66
67         https://bugs.webkit.org/show_bug.cgi?id=59149
68         (Regression) Existing animations are not replaced when filling.
69
70         Hardware animations that fill forwards were not being correctly
71         replaced when the animation was removed. The actual animation
72         logic was working correctly, but it wasn't deleting the
73         CoreAnimation animation from the PlatformLayer. The fix was
74         to explicitly call endAnimation when disconnecting the animation
75         from its RenderObject.
76
77         Test: animations/3d/replace-filling-transform.html
78
79         * page/animation/AnimationBase.h:
80         (WebCore::AnimationBase::clear): call endAnimation as the animation is cleared
81
82 2011-04-29  Abhishek Arya  <inferno@chromium.org>
83
84         Reviewed by Nikolas Zimmermann.
85
86         When svg inline text is getting destroyed, make sure to mark
87         its svg text ancestor as needing a positioning values update.
88         This helps to recalculate layout attributes and makes sure
89         that svg inline text is not used again.
90         https://bugs.webkit.org/show_bug.cgi?id=59161
91
92         Test: svg/text/inline-text-destroy-attributes-crash.xhtml
93
94         * rendering/svg/RenderSVGInlineText.cpp:
95         (WebCore::RenderSVGInlineText::destroy):
96         * rendering/svg/RenderSVGInlineText.h:
97
98 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
99
100         [wx] Unreviewed build fix. Fix wxMSW trunk builds by adding include.
101
102         * platform/graphics/wx/GraphicsContextWx.cpp:
103
104 2011-04-29  Mike Reed  <reed@google.com>
105
106         Reviewed by Ojan Vafai.
107
108         Skia: Need to implement GraphicsContext::clipConvexPolygon()
109         https://bugs.webkit.org/show_bug.cgi?id=41311
110
111         This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
112         as that shows other issues/question unrelated to clipping.
113         https://bugs.webkit.org/show_bug.cgi?id=41311
114
115         No new tests. covered by existing layout tests
116
117         * platform/graphics/skia/GraphicsContextSkia.cpp:
118         (WebCore::setPathFromConvexPoints):
119         (WebCore::GraphicsContext::drawConvexPolygon):
120         (WebCore::GraphicsContext::clipConvexPolygon):
121
122 2011-04-29  Mike Lawther  <mikelawther@chromium.org>
123
124         Reviewed by Ojan Vafai.
125
126         Fix IR->SR typo in enum value (and resulting style fails)
127         https://bugs.webkit.org/show_bug.cgi?id=59779
128
129         No functionality change, so no new tests
130
131         * css/CSSPrimitiveValueMappings.h:
132         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
133         (WebCore::CSSPrimitiveValue::operator EShapeRendering):
134
135 2011-04-29  Pavel Feldman  <pfeldman@google.com>
136
137         Reviewed by Yury Semikhatsky.
138
139         Web Inspector: CSS editing breaks when entering "color: rgb(1"
140         https://bugs.webkit.org/show_bug.cgi?id=59789
141
142         Tests: inspector/styles/styles-add-invalid-property.html
143                inspector/styles/styles-cancel-editing.html
144                inspector/styles/styles-commit-editing.html
145
146         * inspector/front-end/CSSStyleModel.js:
147         (WebInspector.CSSProperty.prototype.setText.callback):
148         (WebInspector.CSSProperty.prototype.setText):
149         * inspector/front-end/StylesSidebarPane.js:
150         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
151         (WebInspector.StylePropertyTreeElement.prototype):
152         (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
153         * inspector/front-end/inspector.js:
154         (WebInspector.startEditing.defaultFinishHandler):
155         (WebInspector.startEditing.keyDownEventListener):
156         (WebInspector.startEditing):
157
158 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
159
160         Reviewed by Simon Hausmann.
161
162         ENABLE(QT_BEARER) -> USE(QT_BEARER)
163
164         * WebCore.pri:
165         * WebCore.pro:
166         * features.pri:
167         * platform/network/NetworkStateNotifier.h:
168         * platform/network/qt/NetworkStateNotifierQt.cpp:
169
170 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
171
172         Reviewed by Simon Hausmann.
173
174         ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
175
176         * WebCore.pri:
177         * features.pri:
178
179 2011-04-29  Pavel Podivilov  <podivilov@chromium.org>
180
181         Reviewed by Pavel Feldman.
182
183         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
184         https://bugs.webkit.org/show_bug.cgi?id=59476
185
186         * inspector/front-end/DebuggerPresentationModel.js:
187         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
188         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
189         (WebInspector.PresentationBreakpoint.prototype.serialize):
190         * inspector/front-end/ScriptsPanel.js:
191         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
192         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
193         (WebInspector.ScriptsPanel.prototype.reset):
194
195 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
196
197         Reviewed by Yury Semikhatsky.
198
199         Web Inspector: include script end line:column in scriptParsed parameters.
200         https://bugs.webkit.org/show_bug.cgi?id=59717
201
202         * bindings/js/ScriptDebugServer.cpp:
203         (WebCore::ScriptDebugServer::dispatchDidParseSource):
204         * bindings/v8/DebuggerScript.js:
205         ():
206         * bindings/v8/ScriptDebugServer.cpp:
207         (WebCore::ScriptDebugServer::dispatchDidParseSource):
208         * inspector/Inspector.json:
209         * inspector/InspectorDebuggerAgent.cpp:
210         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
211         (WebCore::InspectorDebuggerAgent::didParseSource):
212         * inspector/InspectorDebuggerAgent.h:
213         (WebCore::InspectorDebuggerAgent::Script::Script):
214         * inspector/ScriptDebugListener.h:
215         * inspector/front-end/DebuggerModel.js:
216         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
217         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
218         (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
219         * inspector/front-end/Script.js:
220         (WebInspector.Script):
221
222 2011-04-28  Yury Semikhatsky  <yurys@chromium.org>
223
224         Reviewed by Pavel Feldman.
225
226         Web Inspector: [protocol] Evaluate should expose thrown exception value
227         https://bugs.webkit.org/show_bug.cgi?id=59000
228
229         Each evaluation command may have either thrown or returned result. This is indicated
230         by wasThrown property in the protocol.
231
232         * inspector/InjectedScript.cpp:
233         (WebCore::InjectedScript::evaluate):
234         (WebCore::InjectedScript::evaluateOn):
235         (WebCore::InjectedScript::evaluateOnCallFrame):
236         (WebCore::InjectedScript::getProperties):
237         (WebCore::InjectedScript::makeEvalCall):
238         * inspector/InjectedScript.h:
239         * inspector/InjectedScriptSource.js:
240         * inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to
241         the evaluation results.
242         * inspector/InspectorDebuggerAgent.cpp:
243         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
244         * inspector/InspectorDebuggerAgent.h:
245         * inspector/InspectorRuntimeAgent.cpp:
246         (WebCore::InspectorRuntimeAgent::evaluate):
247         (WebCore::InspectorRuntimeAgent::evaluateOn):
248         (WebCore::InspectorRuntimeAgent::getProperties):
249         * inspector/InspectorRuntimeAgent.h:
250         * inspector/front-end/ConsoleView.js:
251         (WebInspector.ConsoleView.prototype.completions.evaluated):
252         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
253         (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
254         (WebInspector.ConsoleView.prototype._enterKeyPressed):
255         (WebInspector.ConsoleCommandResult):
256         * inspector/front-end/DebuggerPresentationModel.js:
257         (WebInspector.PresenationCallFrame.prototype.evaluate):
258         * inspector/front-end/ElementsTreeOutline.js:
259         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
260         * inspector/front-end/ExtensionPanel.js:
261         (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
262         * inspector/front-end/ExtensionServer.js:
263         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
264         * inspector/front-end/ObjectPropertiesSection.js:
265         (WebInspector.ObjectPropertyTreeElement.prototype.update):
266         * inspector/front-end/PropertiesSidebarPane.js:
267         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
268         * inspector/front-end/SourceFrame.js:
269         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
270         (WebInspector.SourceFrame.prototype._showPopup):
271
272 2011-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
273
274         Unreviewed, rolling out r85315.
275         http://trac.webkit.org/changeset/85315
276         https://bugs.webkit.org/show_bug.cgi?id=59792
277
278         Broke script-formatter.html test (Requested by podivilov on
279         #webkit).
280
281         * inspector/front-end/DebuggerPresentationModel.js:
282         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
283         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint):
284         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
285         (WebInspector.PresentationBreakpoint.prototype.serialize):
286         * inspector/front-end/ScriptsPanel.js:
287         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
288         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
289         (WebInspector.ScriptsPanel.prototype.reset):
290
291 2011-04-29  Vsevolod Vlasov  <vsevik@chromium.org>
292
293         Reviewed by Pavel Feldman.
294
295         Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
296         https://bugs.webkit.org/show_bug.cgi?id=58794
297
298         Added ping requests to network panel.
299
300         Test: http/tests/inspector/network/ping.html
301
302         * English.lproj/localizedStrings.js:
303         * inspector/InspectorInstrumentation.cpp:
304         (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
305         * inspector/InspectorInstrumentation.h:
306         (WebCore::InspectorInstrumentation::continueAfterPingLoader):
307         * inspector/front-end/NetworkPanel.js:
308         (WebInspector.NetworkDataGridNode.prototype.refreshResource):
309         (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
310         (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
311         * inspector/front-end/Resource.js:
312         (WebInspector.Resource.prototype.get formParameters):
313         (WebInspector.Resource.prototype.requestContentType):
314         (WebInspector.Resource.prototype.isPingRequest):
315         * loader/PingLoader.cpp:
316         (WebCore::PingLoader::PingLoader):
317         * loader/PingLoader.h:
318
319 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
320
321         Reviewed by Pavel Feldman.
322
323         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
324         https://bugs.webkit.org/show_bug.cgi?id=59476
325
326         * inspector/front-end/DebuggerPresentationModel.js:
327         (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
328         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
329         (WebInspector.PresentationBreakpoint.prototype.serialize):
330         * inspector/front-end/ScriptsPanel.js:
331         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
332         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
333         (WebInspector.ScriptsPanel.prototype.reset):
334
335 2011-04-29  Pavel Feldman  <pfeldman@google.com>
336
337         Reviewed by Yury Semikhatsky.
338
339         Web Inspector: add "open link in new tab" action into the network and resources panels.
340         https://bugs.webkit.org/show_bug.cgi?id=59788
341
342         This change also distinguishes context menu items case between platforms.
343
344         * English.lproj/localizedStrings.js:
345         * inspector/front-end/ConsoleView.js:
346         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
347         * inspector/front-end/DOMBreakpointsSidebarPane.js:
348         (WebInspector.DOMBreakpointsSidebarPane):
349         * inspector/front-end/ElementsPanel.js:
350         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
351         (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
352         * inspector/front-end/ElementsTreeOutline.js:
353         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
354         (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
355         * inspector/front-end/NetworkPanel.js:
356         (WebInspector.NetworkPanel.prototype._contextMenu):
357         * inspector/front-end/ResourcesPanel.js:
358         (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
359         (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
360         (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
361         * inspector/front-end/Settings.js:
362         * inspector/front-end/SourceFrame.js:
363         (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
364         * inspector/front-end/TextViewer.js:
365         (WebInspector.TextViewer.prototype._contextMenu):
366         * inspector/front-end/inspector.js:
367         (WebInspector.openLinkExternallyLabel):
368         (WebInspector.openResource):
369         (WebInspector.useLowerCaseMenuTitles):
370
371 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
372
373         Reviewed by Dan Bernstein.
374
375         Mask placement on composited layer is incorrect sometimes
376         https://bugs.webkit.org/show_bug.cgi?id=59775
377         
378         The mask layer always has the same size as its owning GraphicsLayer,
379         so it needs to share the same offsetFromRenderer as well. This fixes
380         the offset at which the mask layer contents are painted in cases where
381         that offset is non-zero, for example when outline style bloats all of
382         the layer sizes.
383
384         Test: compositing/masks/layer-mask-placement.html
385
386         * rendering/RenderLayerBacking.cpp:
387         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
388
389 2011-04-28  Dan Bernstein  <mitz@apple.com>
390
391         Rubber-stamped by Mark Rowe.
392
393         Reverted r81319.
394
395         Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu
396
397         * page/NavigatorBase.cpp:
398
399 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
400
401         Reviewed by Dirk Schulze.
402
403         1px box-shadow looks ugly
404         https://bugs.webkit.org/show_bug.cgi?id=58100
405         and
406         ShadowBlur incorrectly handles zero-sized blur radius in one axis
407         https://bugs.webkit.org/show_bug.cgi?id=59710
408         
409         blurLayerImage() has issues at the edges if the blur radius
410         is one, so in that case bump the buffer size out by a pixel.
411         This results in a correct, symmetrical blur.
412         
413         Also fix an issue noticed during testing where a zero
414         height or width radius would still blur on that axis,
415         because we clamp the kernel size to a minimum of two.
416
417         Test: fast/box-shadow/single-pixel-shadow.html
418
419         * platform/graphics/ShadowBlur.h:
420         * platform/graphics/ShadowBlur.cpp:
421         (WebCore::ShadowBlur::blurLayerImage):
422         Skip horizontal or vertial passes if the radius on that axis is zero.
423         Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
424         clause to the end of the loop, since it only needs to execute once
425         after the first pass.        
426         (WebCore::ShadowBlur::blurredEdgeSize):
427         New method to compute the width of the blurred edge (radius + extra
428         pixel when necessary).
429         (WebCore::ShadowBlur::calculateLayerBoundingRect):
430         (WebCore::ShadowBlur::templateSize):
431         (WebCore::ShadowBlur::drawRectShadow):
432         (WebCore::ShadowBlur::drawInsetShadow):
433         (WebCore::ShadowBlur::drawInsetShadowWithTiling):
434         (WebCore::ShadowBlur::drawRectShadowWithTiling):
435         (WebCore::ShadowBlur::drawLayerPieces):
436         Use the result of blurredEdgeSize() rather than recomputing.
437
438 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
439
440         Reviewed by Beth Dakin.
441
442         CSS sibling selector (~) does not work with :target pseudo class
443         https://bugs.webkit.org/show_bug.cgi?id=26539
444
445         Allow style recalculation of forward siblings of elements with
446         forward positional rules.
447
448         Tests: fast/css/pseudo-target-indirect-sibling-001.html
449                fast/css/pseudo-target-indirect-sibling-002.html
450
451         * dom/Element.cpp:
452         (WebCore::Element::recalcStyle):
453
454 2011-04-28  Nat Duca  <nduca@chromium.org>
455
456         Reviewed by Kenneth Russell.
457
458         [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
459         https://bugs.webkit.org/show_bug.cgi?id=59626
460
461         * platform/graphics/chromium/Extensions3DChromium.h:
462         (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
463
464 2011-04-28  Steve Lacey  <sjl@chromium.org>
465
466         Reviewed by Eric Carlson.
467
468         Change chromium media controls to use absolute positioning until bug 59644 is fixed.
469         https://bugs.webkit.org/show_bug.cgi?id=59732
470
471         * css/mediaControlsChromium.css:
472         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
473         (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
474
475 2011-04-28  Luke Macpherson   <macpherson@chromium.org>
476
477         Reviewed by Eric Seidel.
478
479         Implement CSS border width and related properties in CSSStyleApplyProperty.
480         https://bugs.webkit.org/show_bug.cgi?id=59414
481
482         No new tests as no functionality added.
483
484         * css/CSSStyleApplyProperty.cpp:
485         Separated ApplyPropertyDefault into parent and child so that other classes could inherit
486         the applyInheritValue and applyInitialValue methods only.
487         This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().
488         
489         Added ApplyPropertyWidth class for handling width based CSS properties.
490         * css/CSSStyleSelector.cpp:
491         Removed no-longer-required code for handling width based CSS properties.
492         * css/CSSStyleSelector.h:
493         Added a getter for m_rootElementStyle.
494
495 2011-04-28  Kent Tamura  <tkent@chromium.org>
496
497         Run sort-Xcode-project-file.
498
499         * WebCore.xcodeproj/project.pbxproj:
500
501 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
502
503         Reviewed by Dirk Schulze.
504
505         [Cairo] Text underline is not shadowed when text-shadow is enabled
506         https://bugs.webkit.org/show_bug.cgi?id=48074
507
508         Use ContextShadow to enable shadows for text underlines. Also remove quite a bit
509         of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
510         originally copied from the CG GraphicsContext.
511
512         * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
513           can call it from a static helper function.
514         * platform/graphics/cairo/GraphicsContextCairo.cpp:
515         (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
516         (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
517         call it multiple times when shadowing text underlines.
518         (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
519         (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
520         (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
521
522 2011-04-28  Sam Weinig  <sam@webkit.org>
523
524         Rubber-stamped by Mark Rowe.
525
526         Cleanup WebCore.xcodeproj a bit.
527
528         * WebCore.xcodeproj/project.pbxproj:
529         Added CompilerVersion.xcconfig and moved some JS bindings files into the
530         correct sub groups.
531
532 2011-04-28  David Levin  <levin@chromium.org>
533
534         Reviewed by Adam Barth.
535
536         Remove IMAGE_RESIZER related code.
537         https://bugs.webkit.org/show_bug.cgi?id=59735
538
539         * CMakeLists.txt:
540         * Configurations/FeatureDefines.xcconfig:
541         * GNUmakefile.am:
542         * GNUmakefile.list.am:
543         * WebCore.gypi:
544         * WebCore.pro:
545         * WebCore.vcproj/WebCore.vcproj:
546         * WebCore.xcodeproj/project.pbxproj:
547         * features.pri:
548         * html/AsyncImageResizer.cpp: Removed.
549         * html/AsyncImageResizer.h: Removed.
550         * html/ImageResizerThread.cpp: Removed.
551         * html/ImageResizerThread.h: Removed.
552
553 2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
554
555         Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
556
557         * inspector/front-end/Settings.js:
558         (WebInspector.Settings):
559
560 2011-04-28  Beth Dakin  <bdakin@apple.com>
561
562         Rubber-stamped by Sam Weinig.
563
564         Rolling out revision 85258! I want to fix that bug a different way.
565         * platform/mac/ScrollbarThemeMac.mm:
566         (WebCore::ScrollbarThemeMac::paint):
567
568 2011-04-28  Chang Shu  <cshu@webkit.org>
569
570         Reviewed by Eric Seidel.
571
572         isContentEditable is not working properly with document.designMode
573         https://bugs.webkit.org/show_bug.cgi?id=53031
574
575         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
576         indicates that the element.isContentEditable relies on document.designMode if its
577         and its ancestors' contenteditable attributes are set to inherit.
578
579         1. Sync document render style after document.designMode is changed.
580         2. Removed the code that does unnecessary and incorrect handling for contenteditable
581         attribute with "inherit" value.
582         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
583
584         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
585                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
586                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
587                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
588
589         * css/CSSStyleSelector.cpp:
590         (WebCore::CSSStyleSelector::styleForDocument):
591         * dom/Document.cpp:
592         (WebCore::Document::setDesignMode):
593         * dom/Node.cpp:
594         (WebCore::Node::rendererIsEditable):
595         * editing/ApplyStyleCommand.cpp:
596         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
597         * html/HTMLElement.cpp:
598         (WebCore::HTMLElement::setContentEditable):
599
600 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
601
602         Unreviewed, rolling out r85101.
603         http://trac.webkit.org/changeset/85101
604         https://bugs.webkit.org/show_bug.cgi?id=59757
605
606          it'd be better to rollout the patch and do another one with
607         another property name. Current one will bring us to a problem
608         at first run after upgrade because it's type was changed from
609         int to string. (Requested by loislo on #webkit).
610
611         * inspector/front-end/ScriptsPanel.js:
612         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
613         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
614         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
615
616 2011-04-28  Mike Reed  <reed@google.com>
617
618         Reviewed by Eric Seidel.
619
620         fix shadw behavior for both CSS and Canvas -- skia only
621         https://bugs.webkit.org/show_bug.cgi?id=59700
622
623         Test:
624         canvas/philip/tests/2d.shadow.alpha.3.html
625         canvas/philip/tests/2d.shadow.alpha.4.html
626         canvas/philip/tests/2d.shadow.alpha.5.html
627         fast/canvas/canvas-fillPath-alpha-shadow.html
628         fast/canvas/canvas-strokePath-alpha-shadow.html
629         fast/canvas/canvas-strokeRect-alpha-shadow.html
630         fast/css/text-input-with-webkit-border-radius.html
631         fast/repaint/shadow-multiple-horizontal.html
632         fast/repaint/shadow-multiple-strict-horizontal.html
633         fast/repaint/shadow-multiple-strict-vertical.html
634         fast/repaint/shadow-multiple-vertical.html
635         fast/canvas/canvas-getImageData.html
636
637         * platform/graphics/chromium/FontChromiumWin.cpp:
638         (WebCore::Font::drawGlyphs):
639         * platform/graphics/skia/GraphicsContextSkia.cpp:
640         (WebCore::GraphicsContext::setPlatformShadow):
641
642 2011-04-28  David Kilzer  <ddkilzer@apple.com>
643
644         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
645
646         Reviewed by Chris Fleizach.
647
648         Previously, AXObjectCache::attachWrapper over-retained each
649         AccessibilityObjectWrapper it created, which is why
650         AXObjectCache::detachWrapper() contained an extra -release.
651
652         * accessibility/mac/AXObjectCacheMac.mm:
653         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
654         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
655         assigns to a RetainPtr<> instance variable, it doesn't need a +1
656         retained object passed in.  Fix the leak by using a RetainPtr<>
657         for the AccessibilityObjectWrapper.
658
659 2011-04-28  Nat Duca  <nduca@chromium.org>
660
661         Reviewed by Darin Fisher.
662
663         [chromium] Compute compositor fps value and history using the frameBegin timestamp
664         https://bugs.webkit.org/show_bug.cgi?id=59668
665
666         This change switches the compositor FPS meter to use the timestamp
667         of the beginning of the frame rather than the time we call
668         swapBuffers. When scheduling is correctly tied to vsync, we can
669         have highly variable times when we finish vsync and still have
670         stable frame rates.
671
672         * platform/graphics/chromium/LayerRendererChromium.cpp:
673         (WebCore::LayerRendererChromium::updateAndDrawLayers):
674         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
675         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
676         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
677         (WebCore::CCHeadsUpDisplay::onFrameBegin):
678         (WebCore::CCHeadsUpDisplay::onPresent):
679         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
680
681 2011-04-28  Beth Dakin  <bdakin@apple.com>
682
683         Reviewed by Darin Adler.
684
685         https://bugs.webkit.org/show_bug.cgi?id=59759
686         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
687         track when there is nothing to scroll to
688         <rdar://problem/9282066>
689
690         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
691         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
692         is not right. Set the proportion to 0 in this case instead.
693         * platform/mac/ScrollbarThemeMac.mm:
694         (WebCore::ScrollbarThemeMac::paint):
695
696 2011-04-28  Dan Bernstein  <mitz@apple.com>
697
698         Reviewed by Simon Fraser.
699
700         <rdar://problem/9291132> Add support for -epub-prefixed properties
701
702         Test: fast/css/epub-properties.html
703
704         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
705         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
706         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
707         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
708         text-transform, text-transform, word-break, and -webkit-writing-mode.
709
710 2011-04-28  Adam Barth  <abarth@webkit.org>
711
712         Reviewed by Eric Seidel.
713
714         Remove WML
715         https://bugs.webkit.org/show_bug.cgi?id=59678
716
717         This patch removes WML from WebCore.  After removing WML, there's a
718         bunch of twisted code that could be untwisted, but this patch contains
719         only the purely mechanical part of removing the feature.
720
721         There's been a lot of discussion on webkit-dev about whether we should
722         remove WML.  In addition to those threads, we've had an informal poll
723         of the reviewers as well as an in-person discussion at the WebKit
724         contributor's meeting.  Removing any feature is likely to make some
725         folks unhappy, but, on balance, removing WML appears to be the right
726         thing for the project to do at this time.
727
728         * CMakeLists.txt:
729         * CodeGenerators.pri:
730         * Configurations/FeatureDefines.xcconfig:
731         * DerivedSources.cpp:
732         * DerivedSources.make:
733         * GNUmakefile.am:
734         * GNUmakefile.list.am:
735         * WebCore.gyp/WebCore.gyp:
736         * WebCore.gypi:
737         * WebCore.pro:
738         * WebCore.vcproj/WebCore.vcproj:
739         * WebCore.xcodeproj/project.pbxproj:
740         * css/CSSStyleSelector.cpp:
741         (WebCore::linkAttribute):
742         (WebCore::CSSStyleSelector::styleForElement):
743         (WebCore::CSSStyleSelector::adjustRenderStyle):
744         * css/wml.css: Removed.
745         * dom/DOMImplementation.cpp:
746         (WebCore::DOMImplementation::createDocument):
747         * dom/Document.cpp:
748         (WebCore::Document::Document):
749         (WebCore::Document::createElement):
750         * dom/Document.h:
751         (WebCore::Document::isMediaDocument):
752         * dom/Document.idl:
753         * dom/InputElement.h:
754         * dom/Node.cpp:
755         (WebCore::Node::toInputElement):
756         * dom/Node.h:
757         * dom/OptionElement.cpp:
758         (WebCore::toOptionElement):
759         (WebCore::isOptionElement):
760         * dom/OptionElement.h:
761         * dom/OptionGroupElement.cpp:
762         (WebCore::toOptionGroupElement):
763         (WebCore::isOptionGroupElement):
764         * dom/SelectElement.cpp:
765         (WebCore::toSelectElement):
766         * dom/SelectElement.h:
767         * dom/Text.cpp:
768         (WebCore::Text::attach):
769         * dom/XMLDocumentParser.cpp:
770         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
771         * dom/XMLDocumentParser.h:
772         * dom/XMLDocumentParserLibxml2.cpp:
773         (WebCore::XMLDocumentParser::internalSubset):
774         (WebCore::getEntityHandler):
775         * dom/XMLDocumentParserQt.cpp:
776         (WebCore::XMLDocumentParser::parse):
777         (WebCore::XMLDocumentParser::parseDtd):
778         * editing/htmlediting.cpp:
779         (WebCore::canHaveChildrenForEditing):
780         * features.pri:
781         * history/BackForwardList.h:
782         * history/BackForwardListImpl.cpp:
783         * history/BackForwardListImpl.h:
784         * history/PageCache.cpp:
785         (WebCore::PageCache::canCachePageContainingThisFrame):
786         * html/HTMLAnchorElement.h:
787         * inspector/ConsoleMessage.cpp:
788         (WebCore::messageSourceValue):
789         * inspector/front-end/ConsoleView.js:
790         (WebInspector.ConsoleMessage.prototype.toString):
791         * loader/FrameLoader.cpp:
792         (WebCore::isBackForwardLoadType):
793         (WebCore::FrameLoader::transitionToCommitted):
794         (WebCore::FrameLoader::shouldReload):
795         (WebCore::FrameLoader::loadDifferentDocumentItem):
796         (WebCore::FrameLoader::loadItem):
797         * loader/FrameLoaderTypes.h:
798         * loader/HistoryController.cpp:
799         (WebCore::HistoryController::restoreDocumentState):
800         * manual-tests/wml: Removed.
801         * manual-tests/wml/StartTests.wml: Removed.
802         * manual-tests/wml/a-br-element.wml: Removed.
803         * manual-tests/wml/a-element.wml: Removed.
804         * manual-tests/wml/a-img-element.wml: Removed.
805         * manual-tests/wml/access-target.wml: Removed.
806         * manual-tests/wml/anchor-br-element.wml: Removed.
807         * manual-tests/wml/anchor-element.wml: Removed.
808         * manual-tests/wml/anchor-img-element.wml: Removed.
809         * manual-tests/wml/card-newcontext-attr.wml: Removed.
810         * manual-tests/wml/card-onenterbackward.wml: Removed.
811         * manual-tests/wml/card-onenterforward.wml: Removed.
812         * manual-tests/wml/card-ontimer.wml: Removed.
813         * manual-tests/wml/deck-access-control.wml: Removed.
814         * manual-tests/wml/input-format.wml: Removed.
815         * manual-tests/wml/onevent-go.wml: Removed.
816         * manual-tests/wml/onevent-noop.wml: Removed.
817         * manual-tests/wml/onevent-prev.wml: Removed.
818         * manual-tests/wml/onevent-refresh.wml: Removed.
819         * manual-tests/wml/onevent-shadow.wml: Removed.
820         * manual-tests/wml/resources: Removed.
821         * manual-tests/wml/resources/smiley.png: Removed.
822         * manual-tests/wml/select-element.wml: Removed.
823         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
824         * manual-tests/wml/select-onpick-event.wml: Removed.
825         * manual-tests/wml/setvar-element.wml: Removed.
826         * manual-tests/wml/targetdeck.wml: Removed.
827         * manual-tests/wml/task-go-in-anchor.wml: Removed.
828         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
829         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
830         * manual-tests/wml/template-go.wml: Removed.
831         * manual-tests/wml/template-ontimer.wml: Removed.
832         * manual-tests/wml/timer.wml: Removed.
833         * manual-tests/wml/variable-substitution.wml: Removed.
834         * page/Console.cpp:
835         (WebCore::printMessageSourceAndLevelPrefix):
836         * page/Console.h:
837         * page/Frame.cpp:
838         (WebCore::Frame::Frame):
839         * page/Page.cpp:
840         * page/Page.h:
841         * platform/MIMETypeRegistry.cpp:
842         (WebCore::initializeSupportedNonImageMimeTypes):
843         * platform/network/FormDataBuilder.h:
844         * platform/network/mac/ResourceHandleMac.mm:
845         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
846         * platform/wince/MIMETypeRegistryWinCE.cpp:
847         (WebCore::initMIMETypeEntensionMap):
848         * rendering/HitTestResult.cpp:
849         (WebCore::HitTestResult::altDisplayString):
850         (WebCore::HitTestResult::absoluteImageURL):
851         (WebCore::HitTestResult::absoluteLinkURL):
852         (WebCore::HitTestResult::isLiveLink):
853         * rendering/RenderBox.cpp:
854         * rendering/RenderButton.cpp:
855         (WebCore::RenderButton::updateFromElement):
856         * rendering/RenderFieldset.cpp:
857         (WebCore::RenderFieldset::findLegend):
858         * rendering/RenderImage.cpp:
859         (WebCore::RenderImage::updateAltText):
860         * rendering/RenderObject.cpp:
861         (WebCore::RenderObject::isLegend):
862         (WebCore::RenderObject::offsetParent):
863         * wml: Removed.
864         * wml/WMLAElement.cpp: Removed.
865         * wml/WMLAElement.h: Removed.
866         * wml/WMLAccessElement.cpp: Removed.
867         * wml/WMLAccessElement.h: Removed.
868         * wml/WMLAnchorElement.cpp: Removed.
869         * wml/WMLAnchorElement.h: Removed.
870         * wml/WMLAttributeNames.in: Removed.
871         * wml/WMLBRElement.cpp: Removed.
872         * wml/WMLBRElement.h: Removed.
873         * wml/WMLCardElement.cpp: Removed.
874         * wml/WMLCardElement.h: Removed.
875         * wml/WMLDoElement.cpp: Removed.
876         * wml/WMLDoElement.h: Removed.
877         * wml/WMLDocument.cpp: Removed.
878         * wml/WMLDocument.h: Removed.
879         * wml/WMLElement.cpp: Removed.
880         * wml/WMLElement.h: Removed.
881         * wml/WMLErrorHandling.cpp: Removed.
882         * wml/WMLErrorHandling.h: Removed.
883         * wml/WMLEventHandlingElement.cpp: Removed.
884         * wml/WMLEventHandlingElement.h: Removed.
885         * wml/WMLFieldSetElement.cpp: Removed.
886         * wml/WMLFieldSetElement.h: Removed.
887         * wml/WMLFormControlElement.cpp: Removed.
888         * wml/WMLFormControlElement.h: Removed.
889         * wml/WMLGoElement.cpp: Removed.
890         * wml/WMLGoElement.h: Removed.
891         * wml/WMLImageElement.cpp: Removed.
892         * wml/WMLImageElement.h: Removed.
893         * wml/WMLImageLoader.cpp: Removed.
894         * wml/WMLImageLoader.h: Removed.
895         * wml/WMLInputElement.cpp: Removed.
896         * wml/WMLInputElement.h: Removed.
897         * wml/WMLInsertedLegendElement.cpp: Removed.
898         * wml/WMLInsertedLegendElement.h: Removed.
899         * wml/WMLIntrinsicEvent.cpp: Removed.
900         * wml/WMLIntrinsicEvent.h: Removed.
901         * wml/WMLIntrinsicEventHandler.cpp: Removed.
902         * wml/WMLIntrinsicEventHandler.h: Removed.
903         * wml/WMLMetaElement.cpp: Removed.
904         * wml/WMLMetaElement.h: Removed.
905         * wml/WMLNoopElement.cpp: Removed.
906         * wml/WMLNoopElement.h: Removed.
907         * wml/WMLOnEventElement.cpp: Removed.
908         * wml/WMLOnEventElement.h: Removed.
909         * wml/WMLOptGroupElement.cpp: Removed.
910         * wml/WMLOptGroupElement.h: Removed.
911         * wml/WMLOptionElement.cpp: Removed.
912         * wml/WMLOptionElement.h: Removed.
913         * wml/WMLPElement.cpp: Removed.
914         * wml/WMLPElement.h: Removed.
915         * wml/WMLPageState.cpp: Removed.
916         * wml/WMLPageState.h: Removed.
917         * wml/WMLPostfieldElement.cpp: Removed.
918         * wml/WMLPostfieldElement.h: Removed.
919         * wml/WMLPrevElement.cpp: Removed.
920         * wml/WMLPrevElement.h: Removed.
921         * wml/WMLRefreshElement.cpp: Removed.
922         * wml/WMLRefreshElement.h: Removed.
923         * wml/WMLSelectElement.cpp: Removed.
924         * wml/WMLSelectElement.h: Removed.
925         * wml/WMLSetvarElement.cpp: Removed.
926         * wml/WMLSetvarElement.h: Removed.
927         * wml/WMLTableElement.cpp: Removed.
928         * wml/WMLTableElement.h: Removed.
929         * wml/WMLTagNames.in: Removed.
930         * wml/WMLTaskElement.cpp: Removed.
931         * wml/WMLTaskElement.h: Removed.
932         * wml/WMLTemplateElement.cpp: Removed.
933         * wml/WMLTemplateElement.h: Removed.
934         * wml/WMLTimerElement.cpp: Removed.
935         * wml/WMLTimerElement.h: Removed.
936         * wml/WMLVariables.cpp: Removed.
937         * wml/WMLVariables.h: Removed.
938
939 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
940
941         Unreviewed, rolling out r85233 and r85235.
942         http://trac.webkit.org/changeset/85233
943         http://trac.webkit.org/changeset/85235
944         https://bugs.webkit.org/show_bug.cgi?id=59754
945
946         Causes issues with jsc. (Requested by dave_levin on #webkit).
947
948         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
949         * loader/icon/IconDatabase.cpp:
950         (WebCore::IconDatabase::defaultIcon):
951         (WebCore::IconDatabase::setIconDataForIconURL):
952         (WebCore::IconDatabase::getOrCreateIconRecord):
953         (WebCore::IconDatabase::readFromDatabase):
954
955 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
956
957         Reviewed by Adam Barth.
958
959         Introducing a new class that allows serialization of a page back
960         to HTML/XML with all its sub-frames and also retrieves the page's
961         resources.
962         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
963         https://bugs.webkit.org/show_bug.cgi?id=58947
964
965         * Android.mk:
966         * CMakeLists.txt:
967         * GNUmakefile.list.am:
968         * WebCore.gypi:
969         * WebCore.pro:
970         * WebCore.vcproj/WebCore.vcproj:
971         * dom/Document.cpp:
972         (WebCore::Document::suggestedMIMEType):
973         * dom/Document.h:
974         * editing/MarkupAccumulator.cpp:
975         (WebCore::MarkupAccumulator::appendCustomAttributes):
976         (WebCore::MarkupAccumulator::appendElement):
977         * editing/MarkupAccumulator.h:
978         * html/parser/HTMLMetaCharsetParser.cpp:
979         (WebCore::HTMLMetaCharsetParser::processMeta):
980         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
981         * html/parser/HTMLMetaCharsetParser.h:
982         * page/PageSerializer.cpp: Added.
983         * page/PageSerializer.h: Added.
984
985 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
986
987         Reviewed by Tony Chang.
988
989         IndexedDB createIndex should fail if name arg is null
990         https://bugs.webkit.org/show_bug.cgi?id=58365
991
992         Test: storage/indexeddb/mozilla/create-index-null-name.html
993
994         * storage/IDBObjectStore.idl:
995         * storage/IDBObjectStoreBackendImpl.cpp:
996         (WebCore::IDBObjectStoreBackendImpl::createIndex):
997
998 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
999
1000         Reviewed by Tony Chang.
1001
1002         IndexedDB put() should fail if second (key) parameter is null
1003         https://bugs.webkit.org/show_bug.cgi?id=58613
1004
1005         If key arg is not specified, prpKey ends up as a null pointer in ::put().
1006         However, if the key arg is specified but is null, prpKey ends up as a
1007         valid IDBKey which has a null key type. As it happens, we need to be able
1008         to detect the difference between these cases (the key arg is optional but
1009         if specified must not be null).
1010
1011         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
1012
1013         * storage/IDBObjectStoreBackendImpl.cpp:
1014         (WebCore::IDBObjectStoreBackendImpl::put):
1015
1016 2011-04-07  David Levin  <levin@chromium.org>
1017
1018         Reviewed by Darin Adler.
1019
1020         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
1021         https://bugs.webkit.org/show_bug.cgi?id=31639
1022
1023         No new functionality exposed so no new tests. (The change is basically adding
1024         more testing.)
1025
1026         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
1027         * loader/icon/IconDatabase.cpp:
1028         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
1029         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
1030         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
1031         (WebCore::IconDatabase::readFromDatabase): Ditto.
1032
1033 2011-04-28  Kenneth Russell  <kbr@google.com>
1034
1035         Unreviewed build fix for Web Audio with strict OwnPtr.
1036
1037         * platform/audio/HRTFDatabaseLoader.cpp:
1038         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
1039
1040 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
1041
1042         Reviewed by Geoffrey Garen.
1043
1044         Walk shadow hosts as well as parent nodes when finding opaque roots.
1045         https://bugs.webkit.org/show_bug.cgi?id=59571
1046
1047         Test: fast/dom/shadow/gc-shadow.html
1048
1049         * bindings/js/JSDOMBinding.h:
1050         (WebCore::root):
1051
1052 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
1053
1054         Reviewed by Xan Lopez.
1055
1056         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
1057         https://bugs.webkit.org/show_bug.cgi?id=59715
1058
1059         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
1060         into WebCore so that WebKit1 and WebKit2 can share the code.
1061
1062         No new tests. This is covered by fast/events/click-count.html.
1063
1064         * GNUmakefile.list.am: Added new files.
1065         * platform/gtk/GtkClickCounter.cpp: Added.
1066         (WebCore::GtkClickCounter::GtkClickCounter): Added.
1067         (WebCore::GtkClickCounter::reset): Added.
1068         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
1069         (WebCore::getEventTime): Added.
1070         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
1071         * platform/gtk/GtkClickCounter.h: Added.
1072
1073 2011-04-28  Dan Bernstein  <mitz@apple.com>
1074
1075         Build fix.
1076
1077         * css/CSSParser.cpp:
1078         (WebCore::cssPropertyID):
1079
1080 2011-04-28  Dan Bernstein  <mitz@apple.com>
1081
1082         Reviewed by Simon Fraser.
1083
1084         Allow specifying CSS property aliases in CSSPropertyNames.in files
1085         https://bugs.webkit.org/show_bug.cgi?id=59712
1086
1087         * css/CSSParser.cpp:
1088         (WebCore::cssPropertyID): Removed code to handle some aliases
1089         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
1090         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
1091         defining an alias, and add an appropriate entry to the gperf file.
1092
1093 2011-04-28  Arno Renevier  <arno@renevier.net>
1094
1095         Reviewed by Gustavo Noronha Silva.
1096
1097         [Soup] does not load css stylesheets without content-type
1098         https://bugs.webkit.org/show_bug.cgi?id=59697
1099
1100         When sniffing content type, do not replace http Content-Type header in
1101         soup message anymore, but keep sniffed content type in a separate
1102         variable.
1103
1104         * platform/network/soup/ResourceHandleSoup.cpp:
1105         (WebCore::contentSniffedCallback):
1106         * platform/network/soup/ResourceResponse.h:
1107         (WebCore::ResourceResponse::sniffedContentType):
1108         (WebCore::ResourceResponse::setSniffedContentType):
1109         * platform/network/soup/ResourceResponseSoup.cpp:
1110         (WebCore::ResourceResponse::updateFromSoupMessage):
1111
1112 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
1113
1114         Reviewed by Andreas Kling.
1115
1116         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
1117         https://bugs.webkit.org/show_bug.cgi?id=59704
1118
1119         No new tests, just code cleanup.
1120
1121         * WebCore.pri:
1122
1123 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
1124
1125         Reviewed by Pavel Feldman.
1126
1127         Web Inspector: remove "Pretty print" source frame context menu item.
1128         https://bugs.webkit.org/show_bug.cgi?id=59709
1129
1130         * inspector/front-end/DebuggerPresentationModel.js:
1131         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
1132         * inspector/front-end/ScriptsPanel.js:
1133         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1134         * inspector/front-end/SourceFrame.js:
1135         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
1136
1137 2011-04-28  Satish Sampath  <satish@chromium.org>
1138
1139         Reviewed by Tony Gentilcore.
1140
1141         Speech input button layout issues with padding and border.
1142         https://bugs.webkit.org/show_bug.cgi?id=59613
1143
1144         * rendering/RenderTextControlSingleLine.cpp:
1145         (WebCore::RenderTextControlSingleLine::layout):
1146         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1147         (WebCore::RenderTextControlSingleLine::forwardEvent):
1148
1149 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1150
1151         Reviewed by Martin Robinson.
1152
1153         [GTK] Check whether to use native scrollbars at run time
1154         https://bugs.webkit.org/show_bug.cgi?id=59694
1155
1156         It's currently decided at build time depending on whether webkit2
1157         build is enabled or not. That makes imposible to build both
1158         webkit1 and webkit2 using the same libWebCore.
1159
1160         * GNUmakefile.am:
1161         * platform/ScrollView.cpp:
1162         (WebCore::ScrollView::wheelEvent):
1163         * platform/gtk/ScrollViewGtk.cpp:
1164         (WebCore::ScrollView::createScrollbar):
1165
1166 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1167
1168         Reviewed by Yury Semikhatsky.
1169
1170         Web Inspector: add status bar button for pretty print.
1171         https://bugs.webkit.org/show_bug.cgi?id=59467
1172
1173         * WebCore.gypi:
1174         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
1175         * inspector/front-end/ScriptsPanel.js:
1176         (WebInspector.ScriptsPanel):
1177         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
1178         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1179         * inspector/front-end/WebKit.qrc:
1180         * inspector/front-end/inspector.css:
1181         (.scripts-toggle-pretty-print-status-bar-item .glyph):
1182         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
1183
1184 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1185
1186         Reviewed by Yury Semikhatsky.
1187
1188         Web Inspector: add ResourceTreeModel tests.
1189         https://bugs.webkit.org/show_bug.cgi?id=59616
1190
1191         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
1192                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
1193                http/tests/inspector/resource-tree/resource-tree-reload.html
1194
1195         * inspector/front-end/ResourceTreeModel.js:
1196         (WebInspector.ResourceTreeModel.prototype.frontendReused):
1197         (WebInspector.ResourceTreeModel.prototype._addFrame):
1198         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1199         (WebInspector.ResourceTreeModel.prototype._frameDetached):
1200         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
1201         (WebInspector.ResourceTreeModel.prototype.forAllResources):
1202         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
1203         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
1204         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
1205         * inspector/front-end/ResourcesPanel.js:
1206         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1207         (WebInspector.ResourcesPanel.prototype._frameAdded):
1208         (WebInspector.ResourcesPanel.prototype._frameDetached):
1209         (WebInspector.ResourcesPanel.prototype._frameNavigated):
1210         (WebInspector.FrameTreeElement):
1211         (WebInspector.FrameTreeElement.prototype.frameNavigated):
1212
1213 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1214
1215         Reviewed by Yury Semikhatsky.
1216
1217         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
1218         https://bugs.webkit.org/show_bug.cgi?id=59592
1219
1220         * inspector/front-end/DetailedHeapshotGridNodes.js:
1221         (WebInspector.HeapSnapshotGridNode.prototype._populate):
1222         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
1223         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
1224         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
1225         * inspector/front-end/DetailedHeapshotView.js:
1226         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
1227         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
1228         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
1229         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
1230         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
1231         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
1232         (WebInspector.DetailedHeapshotView.prototype.changeView):
1233         * inspector/front-end/HeapSnapshot.js:
1234         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
1235         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
1236         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
1237         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
1238         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
1239         * inspector/front-end/heapProfiler.css:
1240         (div.retaining-paths-view td.path-column div:hover):
1241
1242 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1243
1244         Reviewed by Yury Semikhatsky.
1245
1246         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
1247         https://bugs.webkit.org/show_bug.cgi?id=59454
1248
1249         Test: inspector/profiler/heap-snapshot-loader.html
1250
1251         * inspector/front-end/HeapSnapshot.js:
1252         (WebInspector.HeapSnapshotLoader):
1253         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
1254         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
1255         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
1256         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
1257         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
1258         * inspector/front-end/HeapSnapshotProxy.js:
1259         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
1260
1261 2011-04-28  ojab  <ojab@ojab.ru>
1262
1263         Reviewed by David Levin.
1264
1265         Fix build with libpng-1.5.1
1266         https://bugs.webkit.org/show_bug.cgi?id=59607
1267
1268         * platform/image-decoders/png/PNGImageDecoder.cpp:
1269         (WebCore::readColorProfile):
1270
1271 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
1272
1273         Reviewed by Nikolas Zimmermann.
1274
1275         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
1276         https://bugs.webkit.org/show_bug.cgi?id=59447
1277
1278         This patch contains two sub-routines, one for speeding up
1279         alpha channel only gaussian blur (by 2.5 times) and one
1280         for speeding up all channel blur (by 4 times).
1281
1282         The common code is also redesigned to better fit for platform
1283         specific code. This means large chunks of code was moved to
1284         different files, and all platform specific files are added to
1285         all build systems.
1286
1287         * CMakeLists.txt:
1288         * GNUmakefile.am:
1289         * GNUmakefile.list.am:
1290         * WebCore.gypi:
1291         * WebCore.pro:
1292         * WebCore.vcproj/WebCore.vcproj:
1293         * WebCore.vcproj/WebCoreCommon.vsprops:
1294         * WebCore.xcodeproj/project.pbxproj:
1295         * platform/graphics/filters/FEGaussianBlur.cpp:
1296         (WebCore::FEGaussianBlur::platformApplyGeneric):
1297         (WebCore::FEGaussianBlur::apply):
1298         * platform/graphics/filters/FEGaussianBlur.h:
1299         (WebCore::FEGaussianBlur::kernelPosition):
1300         (WebCore::FEGaussianBlur::platformApply):
1301         * platform/graphics/filters/FELighting.cpp:
1302         (WebCore::FELighting::platformApplyGeneric):
1303         (WebCore::FELighting::drawLighting):
1304         * platform/graphics/filters/FELighting.h:
1305         (WebCore::FELighting::platformApply):
1306         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
1307         (WebCore::WTF_ALIGNED):
1308         (WebCore::feGaussianBlurConstantsForNeon):
1309         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
1310         (WebCore::FEGaussianBlur::platformApplyNeon):
1311         * platform/graphics/filters/arm/FELightingNEON.cpp:
1312         (WebCore::WTF_ALIGNED):
1313         (WebCore::FELighting::getPowerCoefficients):
1314         * platform/graphics/filters/arm/FELightingNEON.h:
1315         (WebCore::FELighting::platformApplyNeon):
1316
1317 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
1318
1319         Reviewed by Yury Semikhatsky.
1320
1321         Web Inspector: provide a hotkey for script pause
1322         https://bugs.webkit.org/show_bug.cgi?id=59593
1323
1324         In fact, F8 works as a hotkey, but this fact was not reflected
1325         in the shortcut help popup.
1326
1327         * English.lproj/localizedStrings.js:
1328         * inspector/front-end/ScriptsPanel.js:
1329         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
1330
1331 2011-04-28  Adam Barth  <abarth@webkit.org>
1332
1333         Reviewed by Eric Seidel.
1334
1335         PluginStream should play nice with strict OwnPtr
1336         https://bugs.webkit.org/show_bug.cgi?id=59675
1337
1338         These failures appear when enabling strict OwnPtr on Qt.
1339
1340         * plugins/PluginStream.cpp:
1341         (WebCore::PluginStream::PluginStream):
1342         (WebCore::PluginStream::didReceiveData):
1343
1344 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
1345
1346         Reviewed by Pavel Feldman.
1347
1348         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
1349         https://bugs.webkit.org/show_bug.cgi?id=59326
1350
1351         Concrete CachedResource successors for stylesheets and scripts
1352         can decode their content better than the generic approach we use.
1353
1354         * inspector/InspectorPageAgent.cpp:
1355         (WebCore::decodeSharedBuffer):
1356         (WebCore::prepareCachedResourceBuffer):
1357         (WebCore::cachedResourceDecoded):
1358         (WebCore::InspectorPageAgent::resourceContent):
1359         (WebCore::InspectorPageAgent::resourceData):
1360         * inspector/InspectorStyleSheet.cpp:
1361         (WebCore::InspectorStyleSheet::originalStyleSheetText):
1362
1363 2011-04-28  Jon Lee  <jonlee@apple.com>
1364
1365         Reviewed by Simon Fraser.
1366
1367         REGRESSION: white overlay scrollbars on apple.com/startpage
1368         https://bugs.webkit.org/show_bug.cgi?id=59540
1369         <rdar://problem/9338653>
1370
1371         Now we look at the document background in addition to the <body> element,
1372         and blend those colors in with the base background of the frame view to
1373         arrive at our aggregate color. This provides a better result to determine
1374         overlay scrollbar style.
1375
1376         * page/Frame.cpp:
1377         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
1378         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
1379
1380 2011-04-27  Adam Barth  <abarth@webkit.org>
1381
1382         Reviewed by Maciej Stachowiak.
1383
1384         Fix OwnPtr issues in IndexedDB
1385         https://bugs.webkit.org/show_bug.cgi?id=59656
1386
1387         This patch is an attempt to fix the clang build.  Clang can't seem to
1388         cope with OwnPtrs to classes declared in an anonymous namespace because
1389         OwnPtr's copy constructor isn't defined (but would need to be defined
1390         in this translation unit).
1391
1392         * platform/leveldb/LevelDBDatabase.cpp:
1393
1394 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
1395
1396         Reviewed by Antonio Gomes.
1397
1398         [EFL] Change cursor to LAZY_NATIVE_CURSOR
1399         https://bugs.webkit.org/show_bug.cgi?id=59411
1400
1401         Enable LAZY_NATIVE_CURSOR on EFL build.
1402
1403         No test added because functionality is unchanged.
1404
1405         * CMakeListsEfl.txt: Add Cursor.cpp
1406         * platform/Cursor.h:
1407         (WebCore::Cursor::Cursor):
1408         * platform/efl/CursorEfl.cpp:
1409         (WebCore::Cursor::Cursor):
1410         (WebCore::Cursor::~Cursor):
1411         (WebCore::getCursorString):
1412         (WebCore::Cursor::ensurePlatformCursor):
1413         * platform/efl/WidgetEfl.cpp:
1414         (WebCore::Widget::setCursor):
1415
1416 2011-04-27  Adam Barth  <abarth@webkit.org>
1417
1418         Build fix from the future.  Another trival strict OwnPtr fixes.  This
1419         is the last futuristic build fix I can detect with my time traveling
1420         abilities.
1421
1422         * platform/graphics/chromium/TransparencyWin.cpp:
1423         (WebCore::TransparencyWin::initializeNewContext):
1424
1425 2011-04-27  Dmitry Lomov  <dslomov@google.com>
1426
1427         Reviewed by David Levin.
1428
1429         CrossThreadCopier should not have a default specialization for raw pointers
1430         https://bugs.webkit.org/show_bug.cgi?id=59234
1431         Removed the ablity to pass raw pointers cross-thread
1432         Added and applied annotations for doing that
1433
1434         * fileapi/FileReader.cpp:
1435         (WebCore::FileReader::readInternal):
1436         (WebCore::FileReader::abort):
1437         * fileapi/FileStreamProxy.cpp:
1438         (WebCore::FileStreamProxy::startOnFileThread):
1439         (WebCore::FileStreamProxy::stopOnFileThread):
1440         (WebCore::FileStreamProxy::getSize):
1441         (WebCore::FileStreamProxy::getSizeOnFileThread):
1442         (WebCore::FileStreamProxy::openForRead):
1443         (WebCore::FileStreamProxy::openForReadOnFileThread):
1444         (WebCore::FileStreamProxy::openForWrite):
1445         (WebCore::FileStreamProxy::openForWriteOnFileThread):
1446         (WebCore::FileStreamProxy::close):
1447         (WebCore::FileStreamProxy::read):
1448         (WebCore::FileStreamProxy::readOnFileThread):
1449         (WebCore::FileStreamProxy::write):
1450         (WebCore::FileStreamProxy::writeOnFileThread):
1451         (WebCore::FileStreamProxy::truncate):
1452         (WebCore::FileStreamProxy::truncateOnFileThread):
1453         * loader/WorkerThreadableLoader.cpp:
1454         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
1455         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
1456         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
1457         * page/GeolocationPositionCache.cpp:
1458         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
1459         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
1460         * platform/CrossThreadCopier.h:
1461         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
1462         (WebCore::AllowCrossThreadAccessWrapper::value):
1463         (WebCore::AllowCrossThreadAccess):
1464         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
1465         (WebCore::AllowExtendedLifetimeWrapper::value):
1466         (WebCore::AllowExtendedLifetime):
1467         * platform/graphics/chromium/cc/CCCompletionEvent.h:
1468         * storage/IDBObjectStoreBackendImpl.cpp:
1469         (WebCore::IDBObjectStoreBackendImpl::get):
1470         (WebCore::IDBObjectStoreBackendImpl::put):
1471         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1472         (WebCore::IDBObjectStoreBackendImpl::clear):
1473         (WebCore::IDBObjectStoreBackendImpl::createIndex):
1474         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
1475         (WebCore::IDBObjectStoreBackendImpl::openCursor):
1476         * storage/SQLCallbackWrapper.h:
1477         (WebCore::SQLCallbackWrapper::clear):
1478         * websockets/WorkerThreadableWebSocketChannel.cpp:
1479         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
1480         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
1481         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
1482         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
1483         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
1484         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
1485         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
1486         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
1487         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
1488         * workers/WorkerMessagingProxy.cpp:
1489         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
1490
1491 2011-04-27  Adam Barth  <abarth@webkit.org>
1492
1493         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
1494
1495         * page/Frame.cpp:
1496         (WebCore::Frame::setTiledBackingStoreEnabled):
1497         * platform/audio/ReverbConvolver.cpp:
1498         (WebCore::ReverbConvolver::ReverbConvolver):
1499
1500 2011-04-27  Adam Barth  <abarth@webkit.org>
1501
1502         Reviewed by David Levin.
1503
1504         Fix five strict PassOwnPtr violations in WebCore
1505         https://bugs.webkit.org/show_bug.cgi?id=59640
1506
1507         * css/MediaList.cpp:
1508         (WebCore::MediaList::deleteMedium):
1509         (WebCore::MediaList::setMediaText):
1510         (WebCore::MediaList::appendMedium):
1511         * css/MediaQuery.h:
1512         * dom/MessagePort.cpp:
1513         (WebCore::MessagePort::disentanglePorts):
1514         (WebCore::MessagePort::entanglePorts):
1515         * inspector/InspectorStyleSheet.cpp:
1516         (ParsedStyleSheet::setText):
1517         * rendering/RenderTheme.cpp:
1518         (WebCore::RenderTheme::adjustStyle):
1519         (WebCore::RenderTheme::adjustMeterStyle):
1520         * rendering/RenderThemeMac.mm:
1521         (WebCore::RenderThemeMac::adjustMenuListStyle):
1522         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
1523         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
1524         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
1525         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
1526         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
1527         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
1528         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
1529
1530 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
1531
1532         Reviewed by Beth Dakin.
1533
1534         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
1535         https://bugs.webkit.org/show_bug.cgi?id=59648
1536
1537         Test: accessibility/aria-fallback-roles.html
1538
1539         * accessibility/AccessibilityObject.cpp:
1540         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
1541
1542 2011-04-27  Beth Dakin  <bdakin@apple.com>
1543
1544         Reviewed by Dan Bernstein.
1545
1546         https://bugs.webkit.org/show_bug.cgi?id=59671
1547         Race condition with scrollbar animations and closing a page can cause a crash in 
1548         WebCore::FrameView::setVisibleScrollerThumbRect + 15
1549         -and corresponding-
1550         <rdar://problem/9329253>
1551
1552         It is definitely possible for Page to be null here. So we should null-check it! 
1553         And we should not ASSERT.
1554         * page/FrameView.cpp:
1555         (WebCore::FrameView::didCompleteRubberBand):
1556         (WebCore::FrameView::scrollbarStyleChanged):
1557         (WebCore::FrameView::setVisibleScrollerThumbRect):
1558
1559 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1560
1561         WinCE build fix after r85143.
1562
1563         * platform/graphics/wince/FontWinCE.cpp:
1564         (WebCore::TextRunComponent::TextRunComponent):
1565
1566 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
1567
1568         Reviewed by Tony Chang.
1569
1570         IndexedDB object store delete should fail if key is null
1571         https://bugs.webkit.org/show_bug.cgi?id=58614
1572
1573         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
1574
1575         * storage/IDBObjectStoreBackendImpl.cpp:
1576         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1577
1578 2011-04-27  Eric Seidel  <eric@webkit.org>
1579
1580         Reviewed by Ryosuke Niwa.
1581
1582         Should have an easy way to construct starting BidiStatus for a paragraph root
1583         https://bugs.webkit.org/show_bug.cgi?id=59226
1584
1585         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
1586         I've made this a constructor for BidiStatus instead.
1587
1588         As part of this effort I added a direction() accessor for TextRun and got
1589         rid of the old m_rtl bool.  This is part of the generic effort in the
1590         Bidi code to replace old bool usage with the superior TextDirection enum
1591         (this generally makes the code cleaner).
1592
1593         As part of this replacement effort I found several places which were
1594         assuming LTR (by passing rtl=false) when they probably want to use
1595         the current text direction.  I suspect that LTR vs. RTL may affect
1596         string width in the case of ligatures.  It's unclear.
1597
1598         This is almost entirely a mechanical change.
1599
1600         * html/canvas/CanvasRenderingContext2D.cpp:
1601         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1602         * platform/graphics/GraphicsContext.cpp:
1603         (WebCore::GraphicsContext::drawBidiText):
1604         * platform/graphics/TextRun.h:
1605         (WebCore::TextRun::TextRun):
1606         (WebCore::TextRun::direction):
1607         (WebCore::TextRun::rtl):
1608         (WebCore::TextRun::ltr):
1609         (WebCore::TextRun::setDirection):
1610         * platform/text/BidiResolver.h:
1611         (WebCore::BidiStatus::BidiStatus):
1612         * rendering/EllipsisBox.cpp:
1613         (WebCore::EllipsisBox::paint):
1614         (WebCore::EllipsisBox::selectionRect):
1615         (WebCore::EllipsisBox::paintSelection):
1616         * rendering/InlineTextBox.cpp:
1617         (WebCore::InlineTextBox::selectionRect):
1618         (WebCore::InlineTextBox::paint):
1619         (WebCore::InlineTextBox::paintSelection):
1620         (WebCore::InlineTextBox::paintCompositionBackground):
1621         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1622         (WebCore::InlineTextBox::paintTextMatchMarker):
1623         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1624         (WebCore::InlineTextBox::offsetForPosition):
1625         (WebCore::InlineTextBox::positionForOffset):
1626         * rendering/RenderBlockLineLayout.cpp:
1627         (WebCore::RenderBlock::determineStartPosition):
1628         * rendering/RenderFileUploadControl.cpp:
1629         (WebCore::RenderFileUploadControl::paintObject):
1630         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1631         * rendering/RenderListBox.cpp:
1632         (WebCore::RenderListBox::updateFromElement):
1633         (WebCore::RenderListBox::paintItemForeground):
1634         * rendering/RenderTextControl.cpp:
1635         (WebCore::RenderTextControl::getAvgCharWidth):
1636         (WebCore::RenderTextControl::paintPlaceholder):
1637         * rendering/svg/SVGInlineTextBox.cpp:
1638         (WebCore::SVGInlineTextBox::constructTextRun):
1639         * rendering/svg/SVGTextMetrics.cpp:
1640         (WebCore::constructTextRun):
1641
1642 2011-04-27  Robert Hogan  <robert@webkit.org>
1643
1644         Reviewed by Adam Barth.
1645
1646         Allow shadowing of history object
1647         https://bugs.webkit.org/show_bug.cgi?id=55965
1648
1649         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1650                http/tests/history/cross-origin-replace-history-object.html
1651
1652         * page/DOMWindow.idl:
1653
1654 2011-04-27  James Robinson  <jamesr@chromium.org>
1655
1656         Reviewed by Kenneth Russell.
1657
1658         [chromium] Ensure compositing layers are up to date before entering doComposite
1659         https://bugs.webkit.org/show_bug.cgi?id=59159
1660
1661         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1662         GraphicsLayerClient::paintContents() implementations).
1663
1664         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1665         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1666         * platform/graphics/chromium/LayerChromium.cpp:
1667         (WebCore::LayerChromium::LayerChromium):
1668         (WebCore::LayerChromium::~LayerChromium):
1669         * platform/graphics/chromium/LayerRendererChromium.cpp:
1670         (WebCore::LayerRendererChromium::updateLayers):
1671         * platform/graphics/chromium/LayerRendererChromium.h:
1672           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1673
1674 2011-04-27  James Robinson  <jamesr@chromium.org>
1675
1676         Reviewed by Adam Barth.
1677
1678         Fix OwnPtr strict issues in chromium linux build
1679         https://bugs.webkit.org/show_bug.cgi?id=59664
1680
1681         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1682         (WebCore::ComplexTextController::getNormalizedTextRun):
1683         * platform/graphics/skia/ImageBufferSkia.cpp:
1684         (WebCore::ImageBuffer::ImageBuffer):
1685         * platform/graphics/skia/PlatformContextSkia.cpp:
1686         (WebCore::PlatformContextSkia::PlatformContextSkia):
1687
1688 2011-04-27  Chris Rogers  <crogers@google.com>
1689
1690         Reviewed by Kenneth Russell.
1691
1692         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1693         https://bugs.webkit.org/show_bug.cgi?id=59641
1694
1695         No new tests since audio API is not yet implemented.
1696
1697         * platform/audio/AudioBus.cpp:
1698         (WebCore::AudioBus::createBySampleRateConverting):
1699         (WebCore::AudioBus::createByMixingToMono):
1700
1701 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1702
1703         Motivated by Alexey Proskuryakov.
1704
1705         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1706         informative, since it confused Alexey and me.
1707
1708 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1709
1710         Reviewed by Sam Weinig.
1711
1712         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1713         https://bugs.webkit.org/show_bug.cgi?id=59646
1714
1715         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1716         a world, we need to clear all entries in the map for that world, since
1717         the finalizers that would otherwise clear those entries don't run. The
1718         simplest way to do this is just to make the world own the map.
1719         
1720         * bindings/js/DOMWrapperWorld.h:
1721         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1722         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1723         * bindings/js/JSCSSValueCustom.cpp:
1724         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1725         (WebCore::JSCSSValueOwner::finalize):
1726         * bindings/js/JSDOMBinding.h:
1727
1728 2011-04-27  Adam Barth  <abarth@webkit.org>
1729
1730         Reviewed by David Levin.
1731
1732         Fix OwnPtr issues in IndexedDB
1733         https://bugs.webkit.org/show_bug.cgi?id=59656
1734
1735         I didn't do an exhaustive review of this code, but I fixed the problems
1736         caught by turning on strict OwnPtr and all their antecedents.  This
1737         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1738         behavior change.
1739
1740         * platform/leveldb/LevelDBDatabase.cpp:
1741         (WebCore::LevelDBDatabase::LevelDBDatabase):
1742         (WebCore::LevelDBDatabase::open):
1743         (WebCore::LevelDBDatabase::createIterator):
1744         * platform/leveldb/LevelDBDatabase.h:
1745         * platform/leveldb/LevelDBIterator.cpp:
1746         (WebCore::LevelDBIterator::LevelDBIterator):
1747         * platform/leveldb/LevelDBIterator.h:
1748         * storage/IDBLevelDBBackingStore.cpp:
1749         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1750         (WebCore::IDBLevelDBBackingStore::open):
1751         (WebCore::getNewDatabaseId):
1752         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1753         (WebCore::getNewObjectStoreId):
1754         (WebCore::deleteRange):
1755         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1756         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1757         (WebCore::IDBLevelDBBackingStore::getIndexes):
1758         (WebCore::getNewIndexId):
1759         (WebCore::findGreatestKeyLessThan):
1760         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1761         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1762         (WebCore::findLastIndexKeyEqualTo):
1763         * storage/IDBLevelDBBackingStore.h:
1764
1765 2011-04-19  MORITA Hajime  <morrita@google.com>
1766
1767         Reviewed by Tony Chang.
1768
1769         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1770         https://bugs.webkit.org/show_bug.cgi?id=58113
1771
1772         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1773         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1774         * Now MarkerMapVectorPair is no longer used.
1775         
1776         No new tests, No behavior change.
1777
1778         * GNUmakefile.list.am:
1779         * WebCore.gypi:
1780         * WebCore.pro:
1781         * WebCore.vcproj/WebCore.vcproj:
1782         * WebCore.xcodeproj/project.pbxproj:
1783         * dom/DocumentMarker.h:
1784         * dom/DocumentMarkerController.cpp:
1785         (WebCore::DocumentMarkerController::addMarker):
1786         (WebCore::DocumentMarkerController::copyMarkers):
1787         (WebCore::DocumentMarkerController::removeMarkers):
1788         (WebCore::DocumentMarkerController::markerContainingPoint):
1789         (WebCore::DocumentMarkerController::markersForNode):
1790         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1791         (WebCore::DocumentMarkerController::removeMarkersFromList):
1792         (WebCore::DocumentMarkerController::repaintMarkers):
1793         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1794         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1795         (WebCore::DocumentMarkerController::shiftMarkers):
1796         (WebCore::DocumentMarkerController::setMarkersActive):
1797         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1798         (WebCore::DocumentMarkerController::showMarkers):
1799         * dom/DocumentMarkerController.h:
1800         * dom/RenderedDocumentMarker.h: Added.
1801         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1802         (WebCore::RenderedDocumentMarker::isRendered):
1803         (WebCore::RenderedDocumentMarker::contains):
1804         (WebCore::RenderedDocumentMarker::setRenderedRect):
1805         (WebCore::RenderedDocumentMarker::renderedRect):
1806         (WebCore::RenderedDocumentMarker::invalidate):
1807         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1808
1809 2011-04-27  James Robinson  <jamesr@chromium.org>
1810
1811         Unreviewed, rolling out r85112.
1812         http://trac.webkit.org/changeset/85112
1813         https://bugs.webkit.org/show_bug.cgi?id=59159
1814
1815         Broke mac compile
1816
1817         * page/FrameView.cpp:
1818         (WebCore::FrameView::updateCompositingLayers):
1819         * page/FrameView.h:
1820         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1821         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1822         * platform/graphics/chromium/LayerChromium.cpp:
1823         (WebCore::LayerChromium::LayerChromium):
1824         (WebCore::LayerChromium::~LayerChromium):
1825         * platform/graphics/chromium/LayerRendererChromium.cpp:
1826         (WebCore::LayerRendererChromium::updateLayers):
1827         * platform/graphics/chromium/LayerRendererChromium.h:
1828
1829 2011-04-27  Mark Rowe  <mrowe@apple.com>
1830
1831         Build fix.
1832
1833         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1834
1835 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1836
1837         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1838
1839         * platform/network/ResourceHandleClient.h:
1840
1841 2011-04-27  James Robinson  <jamesr@chromium.org>
1842
1843         Reviewed by Kenneth Russell.
1844
1845         [chromium] Ensure compositing layers are up to date before entering doComposite
1846         https://bugs.webkit.org/show_bug.cgi?id=59159
1847
1848         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1849         GraphicsLayerClient::paintContents() implementations).
1850
1851         * page/FrameView.cpp:
1852         (WebCore::FrameView::updateCompositingLayers):
1853             Add an optional CompositingUpdateType parameter.
1854         * page/FrameView.h:
1855         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1856         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1857         * platform/graphics/chromium/LayerChromium.cpp:
1858         (WebCore::LayerChromium::LayerChromium):
1859         (WebCore::LayerChromium::~LayerChromium):
1860         * platform/graphics/chromium/LayerRendererChromium.cpp:
1861         (WebCore::LayerRendererChromium::updateLayers):
1862         * platform/graphics/chromium/LayerRendererChromium.h:
1863           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1864         * rendering/RenderLayer.cpp:
1865         (WebCore::RenderLayer::dirtyZOrderLists):
1866         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1867         * rendering/RenderLayerCompositor.cpp:
1868         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1869         * rendering/RenderLayerCompositor.h:
1870           Fix a typo in CompositingUpdateType Pait->Paint
1871
1872 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1873
1874         Reviewed by Antti Koivisto.
1875
1876         Part of WebCore should use CFNetwork-based loader on Mac
1877         https://bugs.webkit.org/show_bug.cgi?id=51836
1878
1879         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1880         willCacheResponse/shouldCacheResponse.
1881
1882         * loader/EmptyClients.h:
1883         * loader/FrameLoaderClient.h:
1884         * loader/ResourceLoader.h:
1885         * loader/cf/ResourceLoaderCFNet.cpp:
1886         * loader/mac/ResourceLoaderMac.mm:
1887         (WebCore::ResourceLoader::willCacheResponse):
1888         * platform/network/ResourceHandleClient.h:
1889         (WebCore::ResourceHandleClient::willCacheResponse):
1890         (WebCore::ResourceHandleClient::shouldCacheResponse):
1891         * platform/network/cf/ResourceHandleCFNet.cpp:
1892         (WebCore::willCacheResponse):
1893
1894 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
1895
1896         Reviewed by Brian Weinstein.
1897
1898         Web Inspector: Stop on Exception state does not persist.
1899
1900         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
1901         https://bugs.webkit.org/show_bug.cgi?id=59630
1902
1903         * inspector/front-end/ScriptsPanel.js:
1904         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1905         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1906         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1907
1908 2011-04-27  Adrienne Walker  <enne@google.com>
1909
1910         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
1911         https://bugs.webkit.org/show_bug.cgi?id=59020
1912
1913         * platform/graphics/chromium/LayerRendererChromium.cpp:
1914         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1915
1916 2011-04-27  Darin Adler  <darin@apple.com>
1917
1918         Reviewed by David Levin.
1919
1920         Fix strict OwnPtr issues seen in about 30 more files
1921         https://bugs.webkit.org/show_bug.cgi?id=59615
1922
1923         * bindings/js/JSCallbackData.h:
1924         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
1925         * bindings/js/JSMessageEventCustom.cpp:
1926         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
1927         * css/CSSParser.cpp:
1928         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
1929         adoptPtr, and release.
1930         * dom/MessageEvent.cpp:
1931         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
1932         and release.
1933         * dom/MessagePortChannel.cpp:
1934         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
1935         * dom/ScriptExecutionContext.cpp:
1936         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
1937         * dom/XMLDocumentParserLibxml2.cpp:
1938         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
1939         * dom/default/PlatformMessagePortChannel.cpp:
1940         (WebCore::MessagePortChannel::create): Use adoptPtr.
1941         * html/HTMLFormControlElement.cpp:
1942         (WebCore::HTMLFormControlElement::detach): Use nullptr.
1943         * inspector/InspectorAgent.cpp:
1944         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
1945         * inspector/InspectorConsoleAgent.cpp:
1946         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
1947         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
1948         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
1949         * inspector/InspectorController.cpp:
1950         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
1951         * inspector/InspectorDOMAgent.cpp:
1952         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
1953         * inspector/InspectorResourceAgent.cpp:
1954         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1955         * page/FrameActionScheduler.cpp:
1956         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1957         * platform/graphics/ShadowBlur.cpp:
1958         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1959         * platform/graphics/ca/GraphicsLayerCA.cpp:
1960         (WebCore::GraphicsLayer::create): Use adoptPtr.
1961         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1962         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1963         * rendering/RenderBlock.cpp:
1964         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1965         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1966         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
1967         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
1968         * rendering/RenderLayerBacking.cpp:
1969         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
1970         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
1971         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
1972         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
1973         * rendering/RenderLayerCompositor.cpp:
1974         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
1975         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
1976         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
1977         * rendering/style/StyleRareNonInheritedData.cpp:
1978         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
1979         explicit initializations of OwnPtr members to 0. Use adoptPtr.
1980         * workers/SharedWorkerContext.cpp:
1981         (WebCore::createConnectEvent): Use adoptPtr.
1982         * workers/Worker.cpp:
1983         (WebCore::Worker::notifyFinished): Use nullptr.
1984
1985 2011-04-27  Enrica Casucci  <enrica@apple.com>
1986
1987         Reviewed by Darin Adler.
1988
1989         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
1990         https://bugs.webkit.org/show_bug.cgi?id=59251
1991         <rdar://problem/9327044>
1992
1993         When we are looking for wrapping elements that are presentational, we should
1994         include elements that have a non transparent background color only if they
1995         are not blocks.
1996
1997         Test: editing/pasteboard/do-not-copy-body-color.html
1998
1999         * editing/markup.cpp:
2000         (WebCore::isElementPresentational):
2001
2002 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
2003
2004         Reviewed by Antti Koivisto.
2005
2006         Teach sub-selector chains about shadow descendants
2007         https://bugs.webkit.org/show_bug.cgi?id=58342
2008
2009         The primary change is to the logic of parsing specifiers:
2010         1) The shadow descendant selectors (those specifiers that are unknown
2011         pseudo element selectors) are always kept at the top of the chain.
2012         2) The sub-selectors after shadow descendant selectors are stashed right
2013         behind the sub-selector, but not at the end of the chain.
2014         3) Other sub-selectors are appended at the end of the chain.
2015
2016         * css/CSSGrammar.y: Changed specifier_list collection to use new
2017             CSSParser::updateSpecifier helper.
2018         * css/CSSParser.cpp:
2019         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
2020             look for the last ShadowDescendant relation in the chain of selectors,
2021             because the next selector after it is the one that should get the
2022             element name.
2023         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
2024             CSSGrammar.y. The new logic adjusts the selector chain to allow
2025             shadow descendant selectors have sub-selectors (and have multiple shadow
2026             descendants in the chain).
2027         * css/CSSParser.h: Added decl.
2028         * css/CSSParserValues.cpp:
2029         (WebCore::CSSParserSelector::insertTagHistory): Added.
2030         (WebCore::CSSParserSelector::appendTagHistory): Aded.
2031         * css/CSSParserValues.h: Added decls.
2032         * css/CSSStyleSelector.cpp:
2033         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
2034             shadow descendant selector match check, since now there could be many
2035             of them in the selector chain.
2036
2037 2011-04-20  Adrienne Walker  <enne@google.com>
2038
2039         Reviewed by Kenneth Russell.
2040
2041         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
2042         https://bugs.webkit.org/show_bug.cgi?id=59020
2043
2044         mapRect is the incorrect transform here.  The parent scissor rect
2045         needs to be projected into layer space instead.
2046
2047         Test: compositing/flat-with-transformed-child.html
2048
2049         * platform/graphics/chromium/LayerRendererChromium.cpp:
2050         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2051
2052 2011-04-27  Pratik Solanki  <psolanki@apple.com>
2053
2054         Reviewed by Antti Koivisto.
2055
2056         Part of WebCore should use CFNetwork-based loader on Mac
2057         https://bugs.webkit.org/show_bug.cgi?id=51836
2058
2059         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
2060         * platform/mac/SoftLinking.h:
2061         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
2062
2063 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
2064
2065         Reviewed by Antti Koivisto.
2066
2067         Cleanup CSSStyleApplyProperty.cpp
2068         https://bugs.webkit.org/show_bug.cgi?id=59623
2069
2070         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
2071         Use typedefs instead of repating the function pointer declarations in a few places.
2072
2073         * css/CSSStyleApplyProperty.cpp:
2074         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
2075         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
2076         (WebCore::ApplyPropertyColor::applyInheritValue):
2077         (WebCore::ApplyPropertyColor::applyInitialValue):
2078         (WebCore::ApplyPropertyColor::applyValue):
2079         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2080
2081 2011-04-27  Dan Bernstein  <mitz@apple.com>
2082
2083         Reviewed by Anders Carlsson.
2084
2085         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
2086         https://bugs.webkit.org/show_bug.cgi?id=59622
2087
2088         Test: fast/borders/border-image-trumps-radius.html
2089
2090         * rendering/RenderBox.cpp:
2091         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
2092         image, then border radius is ignored, so no bleed avoidance is needed.
2093         * rendering/RenderObject.cpp:
2094         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
2095         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
2096         * rendering/RenderObject.h:
2097
2098 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2099
2100         Reviewed by Xan Lopez.
2101
2102         [GTK] editing/pasteboard/copy-standalone-image.html fails
2103         https://bugs.webkit.org/show_bug.cgi?id=53645
2104
2105         When writing an image to the clipboard, also write the URL and title
2106         into the markup and URL portion. This change also abstracts a helper
2107         imageToMarkup into markup.{cpp/h} from several different locations
2108         throughout the platform layer.
2109
2110         * editing/markup.h: Added new function definition.
2111         * editing/markup.cpp:
2112         (WebCore::imageToMarkup): Add this function which turns an image URL 
2113         and element into some markup representing that image, while preserving
2114         non-src attributes.
2115         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
2116         to markup.cpp.
2117         * platform/gtk/PasteboardGtk.cpp:
2118         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
2119         image URL for a variety of image tag types.
2120         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
2121         markup and URL portions of the clipboard. This will ensure that images
2122         paste properly back into WebKit.
2123         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
2124         one from markup.h
2125
2126 2011-04-27  Steve Block  <steveblock@google.com>
2127
2128         Reviewed by David Levin.
2129
2130         Remove Android build system
2131         https://bugs.webkit.org/show_bug.cgi?id=48111
2132
2133         This is to avoid the maintenance burden until the Android port is
2134         fully upstreamed.
2135
2136         No new tests, build change only.
2137
2138         * Android.derived.jscbindings.mk: Removed.
2139         * Android.derived.mk: Removed.
2140         * Android.derived.v8bindings.mk: Removed.
2141         * Android.jscbindings.mk: Removed.
2142         * Android.mk: Removed.
2143         * Android.v8bindings.mk: Removed.
2144
2145 2011-04-27  Darin Adler  <darin@apple.com>
2146
2147         Reviewed by Sam Weinig.
2148
2149         Somehow about:blank gets into the icon database
2150         https://bugs.webkit.org/show_bug.cgi?id=58067
2151         rdar://problem/6751446
2152
2153         Implemented the policy Brady suggested, where only http and https URLs can
2154         be associated with and icon, guarding both on the way in to the database,
2155         and on the way out.
2156
2157         * loader/icon/IconDatabase.cpp:
2158         (WebCore::pageCanHaveIcon): Added.
2159         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
2160         instead of just checking for an empty URL.
2161         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
2162         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
2163         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
2164         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
2165         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
2166         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
2167         two separate assertions and added a third.
2168         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
2169
2170         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
2171         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
2172         overloaded it to work on both UChar and char, and added an assertion to it.
2173         Also moved this to the top of the file and made the UChar version usable
2174         in the shared code used even by Google.
2175         (WebCore::KURL::invalidate): Updated for name change.
2176         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
2177         toASCIILower since it's faster.
2178         (WebCore::KURL::parse): Updated for name changes.
2179         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
2180         since it's faster.
2181         (WebCore::protocolIsInHTTPFamily): Added.
2182
2183         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
2184         to protocolIsInHTTPFamily and added a version that works on a string.
2185         Kept the old name as an inline function so we don't have to rename
2186         all the cal sites now.
2187
2188         * platform/KURLGoogle.cpp: Renamed as above.
2189         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
2190         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
2191         (WebCore::KURLGooglePrivate::setAscii): Ditto.
2192         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
2193         (WebCore::KURLGooglePrivate::copyTo): Ditto.
2194         (WebCore::KURL::KURL): Ditto.
2195         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
2196         (WebCore::KURL::invalidate): Ditto.
2197         * platform/KURLGooglePrivate.h: Ditto.
2198
2199         * WebCore.exp.in: Updated for above changes.
2200
2201 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2202
2203         Reviewed by Pavel Feldman.
2204
2205         Web Inspector: browser crash on evaluation of 'throw undefined'
2206         https://bugs.webkit.org/show_bug.cgi?id=59611
2207
2208         Test: inspector/console/console-eval-throw-undefined.html
2209
2210         * inspector/InjectedScriptSource.js: use try/catch to protect from
2211         exception during conversion of another exception to string.
2212
2213 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2214
2215         Reviewed by Yury Semikhatsky.
2216
2217         Web Inspector: clicking bookmarklet multiplies resources panel entries.
2218         https://bugs.webkit.org/show_bug.cgi?id=59590
2219
2220         * inspector/front-end/ResourceTreeModel.js:
2221         (WebInspector.ResourceTreeModel):
2222         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2223         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2224         * inspector/front-end/ResourcesPanel.js:
2225         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
2226         (WebInspector.FrameTreeElement):
2227         (WebInspector.FrameTreeElement.prototype.appendResource):
2228         * inspector/front-end/inspector.js:
2229         (WebInspector.frontendReused):
2230
2231 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2232
2233         Reviewed by Yury Semikhatsky.
2234
2235         Web Inspector: opening bookmarklet disconnects DOM agent.
2236         https://bugs.webkit.org/show_bug.cgi?id=59588
2237
2238         * inspector/InspectorDOMAgent.cpp:
2239         (WebCore::InspectorDOMAgent::setDocument):
2240
2241 2011-04-27  Hans Wennborg  <hans@chromium.org>
2242
2243         Reviewed by Tony Gentilcore.
2244
2245         IndexedDB: Fix compiler warnings about uninitialized variables
2246         https://bugs.webkit.org/show_bug.cgi?id=59599
2247
2248         Build fix. No new tests.
2249
2250         * storage/IDBLevelDBBackingStore.cpp:
2251         (WebCore::getNewObjectStoreId):
2252         (WebCore::getNewIndexId):
2253
2254 2011-04-26  Hans Wennborg  <hans@chromium.org>
2255
2256         Reviewed by Tony Gentilcore.
2257
2258         IndexedDB: Move LevelDB key coding routines to separate file
2259         https://bugs.webkit.org/show_bug.cgi?id=59452
2260
2261         Move all routines concerned with encoding, decoding and comparison of
2262         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
2263         IDBLevelDBCoding.cpp.
2264
2265         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
2266         allow for unit testing of the coding routines.
2267
2268         No new functionality, no new tests.
2269
2270         * WebCore.gypi:
2271         * storage/IDBLevelDBBackingStore.cpp:
2272         (WebCore::getInt):
2273         (WebCore::putInt):
2274         (WebCore::getString):
2275         (WebCore::putString):
2276         (WebCore::compareKeys):
2277         (WebCore::compareIndexKeys):
2278         (WebCore::Comparator::compare):
2279         (WebCore::setUpMetadata):
2280         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
2281         (WebCore::getNewDatabaseId):
2282         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
2283         (WebCore::IDBLevelDBBackingStore::getObjectStores):
2284         (WebCore::getNewObjectStoreId):
2285         (WebCore::IDBLevelDBBackingStore::createObjectStore):
2286         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
2287         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
2288         (WebCore::getNewVersionNumber):
2289         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
2290         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
2291         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
2292         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
2293         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
2294         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
2295         (WebCore::IDBLevelDBBackingStore::getIndexes):
2296         (WebCore::getNewIndexId):
2297         (WebCore::IDBLevelDBBackingStore::createIndex):
2298         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
2299         (WebCore::versionExists):
2300         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
2301         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
2302         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
2303         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
2304         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
2305         * storage/IDBLevelDBCoding.cpp: Added.
2306         (WebCore::IDBLevelDBCoding::encodeByte):
2307         (WebCore::IDBLevelDBCoding::maxIDBKey):
2308         (WebCore::IDBLevelDBCoding::minIDBKey):
2309         (WebCore::IDBLevelDBCoding::encodeInt):
2310         (WebCore::IDBLevelDBCoding::decodeInt):
2311         (WebCore::IDBLevelDBCoding::encodeVarInt):
2312         (WebCore::IDBLevelDBCoding::decodeVarInt):
2313         (WebCore::IDBLevelDBCoding::encodeString):
2314         (WebCore::IDBLevelDBCoding::decodeString):
2315         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
2316         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
2317         (WebCore::IDBLevelDBCoding::encodeDouble):
2318         (WebCore::IDBLevelDBCoding::decodeDouble):
2319         (WebCore::IDBLevelDBCoding::encodeIDBKey):
2320         (WebCore::IDBLevelDBCoding::decodeIDBKey):
2321         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
2322         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
2323         (WebCore::IDBLevelDBCoding::compare):
2324         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
2325         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
2326         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
2327         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
2328         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
2329         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
2330         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
2331         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
2332         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
2333         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
2334         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
2335         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
2336         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
2337         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
2338         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
2339         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
2340         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
2341         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
2342         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
2343         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
2344         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
2345         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
2346         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
2347         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
2348         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
2349         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
2350         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
2351         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
2352         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
2353         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
2354         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
2355         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
2356         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
2357         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
2358         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
2359         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
2360         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
2361         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
2362         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
2363         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
2364         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
2365         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
2366         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
2367         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
2368         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
2369         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
2370         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
2371         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
2372         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
2373         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
2374         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
2375         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
2376         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
2377         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
2378         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
2379         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
2380         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
2381         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
2382         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
2383         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
2384         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
2385         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
2386         * storage/IDBLevelDBCoding.h: Added.
2387         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
2388         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
2389         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
2390         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
2391         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
2392
2393 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2394
2395         Reviewed by Pavel Feldman.
2396
2397         Web Inspector: expose exception details when script is paused on exception
2398         https://bugs.webkit.org/show_bug.cgi?id=59591
2399
2400         When script is paused on an exception, the exception value is added as <exception>
2401         property in the local scope and the breakpoint details message says
2402         "Paused on excepion: '<exception to strin value>'."
2403
2404         * English.lproj/localizedStrings.js:
2405         * inspector/front-end/ScopeChainSidebarPane.js:
2406         (WebInspector.ScopeChainSidebarPane.prototype.update):
2407         * inspector/front-end/ScriptsPanel.js:
2408         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
2409         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
2410
2411 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
2412
2413         Reviewed by Pavel Feldman.
2414
2415         Web Inspector: [protocol] Paused event should expose exception value that caused it
2416         https://bugs.webkit.org/show_bug.cgi?id=58996
2417
2418         Debug.pause event now contains an optional reference to the exception
2419         object in case script execution is paused on a JavaScript exception.
2420
2421         Also JavaScript call frames are passed directly into the injected script when
2422         we need to wrap them for passing to the front-end. This change breaks cyclic
2423         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
2424
2425         * bindings/js/JSInjectedScriptHostCustom.cpp:
2426         * bindings/js/ScriptDebugServer.cpp:
2427         (WebCore::ScriptDebugServer::dispatchDidPause):
2428         * bindings/js/ScriptDebugServer.h:
2429         * bindings/v8/ScriptDebugServer.cpp:
2430         (WebCore::ScriptDebugServer::breakProgram):
2431         (WebCore::ScriptDebugServer::editScriptSource):
2432         (WebCore::ScriptDebugServer::breakProgramCallback):
2433         (WebCore::ScriptDebugServer::handleV8DebugEvent):
2434         * bindings/v8/ScriptDebugServer.h:
2435         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2436         * inspector/InjectedScript.cpp:
2437         (WebCore::InjectedScript::evaluateOnCallFrame):
2438         (WebCore::InjectedScript::wrapCallFrames):
2439         * inspector/InjectedScript.h:
2440         * inspector/InjectedScriptHost.cpp:
2441         * inspector/InjectedScriptHost.h:
2442         (WebCore::InjectedScriptHost::init):
2443         * inspector/InjectedScriptHost.idl:
2444         * inspector/InjectedScriptSource.js:
2445         (.):
2446         * inspector/Inspector.json:
2447         * inspector/InspectorAgent.cpp:
2448         (WebCore::InspectorAgent::InspectorAgent):
2449         * inspector/InspectorDebuggerAgent.cpp:
2450         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
2451         (WebCore::InspectorDebuggerAgent::currentCallFrames):
2452         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
2453         (WebCore::InspectorDebuggerAgent::didPause):
2454         (WebCore::InspectorDebuggerAgent::didContinue):
2455         (WebCore::InspectorDebuggerAgent::clear):
2456         * inspector/InspectorDebuggerAgent.h:
2457         * inspector/ScriptDebugListener.h:
2458         * inspector/WorkerInspectorController.cpp:
2459         (WebCore::WorkerInspectorController::WorkerInspectorController):
2460
2461 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2462
2463         Reviewed by Yury Semikhatsky.
2464
2465         Web Inspector: implement incremental CSS editing in the structure view.
2466         https://bugs.webkit.org/show_bug.cgi?id=59455
2467
2468         * inspector/front-end/StylesSidebarPane.js:
2469         (WebInspector.StylePropertyTreeElement.prototype):
2470
2471 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
2472
2473         Reviewed by Eric Seidel.
2474
2475         Frame.h shouldn't include Document.h
2476         https://bugs.webkit.org/show_bug.cgi?id=59560
2477
2478         Frame can use a forward-declared Document if we move
2479         Frame::displayStringModifiedByEncoding's implementation out of the
2480         header.
2481                                 Size  #includes  Size * #includes
2482         Before: page/Frame.h:   0.746       653           487.138
2483                 dom/Document.h: 0.220      1306           287.320
2484         
2485         After:  page/Frame.h:   0.646       653           421.838
2486                 dom/Document.h: 0.220      1189           261.580
2487
2488         * WebCore.exp.in:
2489         * bindings/ScriptControllerBase.cpp:
2490         * bindings/generic/BindingSecurityBase.cpp:
2491         * bindings/v8/V8Proxy.cpp:
2492         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
2493         * dom/CharacterData.cpp:
2494         * dom/UserTypingGestureIndicator.cpp:
2495         * editing/chromium/SelectionControllerChromium.cpp:
2496         * inspector/InspectorDOMStorageResource.cpp:
2497         * inspector/InspectorInstrumentation.h:
2498         * loader/PingLoader.cpp:
2499         * loader/SubresourceLoader.cpp:
2500         * loader/appcache/DOMApplicationCache.cpp:
2501         * loader/cache/CachedResourceRequest.cpp:
2502         * page/Frame.cpp:
2503         (WebCore::Frame::displayStringModifiedByEncoding):
2504         * page/Frame.h:
2505         * page/Geolocation.cpp:
2506         * page/Location.cpp:
2507         * page/Navigator.cpp:
2508         * page/PageGroupLoadDeferrer.cpp:
2509         * page/PerformanceTiming.cpp:
2510         * xml/XSLTProcessorLibxslt.cpp:
2511
2512 2011-04-27  James Robinson  <jamesr@chromium.org>
2513
2514         Reviewed by Eric Seidel.
2515
2516         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2517         https://bugs.webkit.org/show_bug.cgi?id=59377
2518
2519         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
2520         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
2521
2522         * css/CSSStyleSelector.cpp:
2523         (WebCore::CSSStyleSelector::applyProperty):
2524         * page/animation/AnimationBase.cpp:
2525         (WebCore::blendFunc):
2526         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2527         (WebCore::PropertyWrapperShadow::blend):
2528         * rendering/style/RenderStyle.cpp:
2529         (WebCore::RenderStyle::setTextShadow):
2530         (WebCore::RenderStyle::setBoxShadow):
2531         * rendering/style/RenderStyle.h:
2532         (WebCore::InheritedFlags::textShadow):
2533         * rendering/style/ShadowData.cpp:
2534         (WebCore::ShadowData::ShadowData):
2535         * rendering/style/ShadowData.h:
2536         (WebCore::ShadowData::ShadowData):
2537         (WebCore::ShadowData::next):
2538         (WebCore::ShadowData::setNext):
2539         * rendering/style/StyleRareInheritedData.cpp:
2540         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2541         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2542         * rendering/style/StyleRareInheritedData.h:
2543         * rendering/style/StyleRareNonInheritedData.cpp:
2544         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2545
2546 2011-04-26  David Levin  <levin@chromium.org>
2547
2548         Reviewed by Eric Seidel.
2549
2550         Fix some strict PassOwnPtr issues in WebCore.
2551         https://bugs.webkit.org/show_bug.cgi?id=59563
2552
2553         * css/SVGCSSStyleSelector.cpp:
2554         (WebCore::CSSStyleSelector::applySVGProperty):
2555         * html/canvas/WebGLRenderingContext.cpp:
2556         (WebCore::WebGLRenderingContext::create):
2557         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
2558         * platform/text/TextCodecLatin1.cpp:
2559         (WebCore::newStreamingTextDecoderWindowsLatin1):
2560         * platform/text/TextCodecUTF16.cpp:
2561         (WebCore::newStreamingTextDecoderUTF16LE):
2562         (WebCore::newStreamingTextDecoderUTF16BE):
2563         * platform/text/TextCodecUserDefined.cpp:
2564         (WebCore::newStreamingTextDecoderUserDefined):
2565         * platform/text/mac/TextCodecMac.cpp:
2566         (WebCore::newTextCodecMac):
2567         * workers/Worker.cpp:
2568         (WebCore::Worker::notifyFinished):
2569
2570 2011-04-26  Justin Novosad  <junov@chromium.org>
2571
2572         Reviewed by Kenneth Russell.
2573
2574         [Chromium] Expose skia gpu canvas rendering as a runtime flag
2575         https://bugs.webkit.org/show_bug.cgi?id=58683
2576         Replace the SKIA_GPU compile flag by the pre-existing
2577         acceleratedDrawingEnabled flag. Most code changes are trivial:
2578         compile-time conditionals on SKIA_GPU were either replaced with
2579         a run-time check, or a compile time check on USE(SKIA) 
2580
2581         No new tests. Covered by existing tests.
2582
2583         * html/canvas/CanvasRenderingContext2D.cpp:
2584         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2585         * page/Page.cpp:
2586         (WebCore::Page::sharedGraphicsContext3D):
2587         Added check for the acceleratedDrawing flag.
2588         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2589         (WebCore::DrawingBuffer::DrawingBuffer):
2590         (WebCore::DrawingBuffer::publishToPlatformLayer):
2591         * platform/graphics/gpu/DrawingBuffer.h:
2592         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2593         (WebCore::SharedGraphicsContext3D::create):
2594         On Skia builds, this methos now receives a bool arg to turn on
2595         GPU-accelerated skia rendering
2596         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
2597         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2598         (WebCore::SharedGraphicsContext3D::grContext):
2599         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2600         * platform/graphics/skia/ImageSkia.cpp:
2601         (WebCore::computeResamplingMode):
2602         (WebCore::paintSkBitmap):
2603         (WebCore::Image::drawPattern):
2604         * platform/graphics/skia/PlatformContextSkia.cpp:
2605         (WebCore::PlatformContextSkia::PlatformContextSkia):
2606         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2607         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2608         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2609         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2610         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2611         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2612         (WebCore::PlatformContextSkia::markDirtyRect):
2613         * platform/graphics/skia/PlatformContextSkia.h:
2614         (WebCore::PlatformContextSkia::accelerationMode):
2615         (WebCore::PlatformContextSkia::useGPU):
2616         (WebCore::PlatformContextSkia::useSkiaGPU):
2617
2618 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2619
2620         Not reviewed: restore inspector test disabled in r84913.
2621
2622         Test: http/tests/inspector-enabled/dom-storage-open.html
2623
2624         * inspector/InspectorDOMStorageAgent.cpp:
2625         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2626
2627 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2628
2629         Reviewed by Tony Chang.
2630
2631         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2632         https://bugs.webkit.org/show_bug.cgi?id=59182
2633
2634         Use vertical offsets of the shaping results.
2635
2636         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2637
2638         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2639         (WebCore::ComplexTextController::ComplexTextController):
2640         Added initialization of m_startingY.
2641         (WebCore::ComplexTextController::nextScriptRun):
2642         Followed the change in handling positions.
2643         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2644         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2645         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2646         (WebCore::ComplexTextController::setGlyphPositions):
2647         Changed to use vertical offsets as same as horizontal offsets.
2648         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2649         Removed m_xPositions and Added m_positions and m_startingY.
2650         (WebCore::ComplexTextController::positions): Added.
2651         * platform/graphics/chromium/FontLinux.cpp:
2652         Followed the change in ComplexTextController.
2653         (WebCore::Font::drawComplexText): Ditto.
2654         (WebCore::Font::floatWidthForComplexText): Ditto.
2655         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2656         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2657         (WebCore::Font::selectionRectForComplexText): Ditto.
2658
2659 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2660
2661         Reviewed by Eric Seidel.
2662
2663         Root element should establish a new block formatting context
2664         https://bugs.webkit.org/show_bug.cgi?id=54573
2665
2666         Always expanding the root renderer to include overhanging floats.
2667
2668         Test: fast/block/float/float-overhangs-root.html
2669
2670         * rendering/RenderBlock.cpp:
2671         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2672
2673 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2674
2675         Reviewed by Andreas Kling.
2676
2677         [Qt] Improper rendering of <button> tag when it contains a <br>
2678         https://bugs.webkit.org/show_bug.cgi?id=50521
2679
2680         Test: platform/qt/fast/forms/button-line-break.html
2681
2682         * platform/qt/RenderThemeQt.cpp:
2683         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2684         (WebCore::RenderThemeQt::setButtonPadding):
2685
2686 2011-04-26  James Robinson  <jamesr@chromium.org>
2687
2688         Reviewed by Kenneth Russell.
2689
2690         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2691         https://bugs.webkit.org/show_bug.cgi?id=59572
2692
2693         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2694         when LayerRendererChromium was set.  We set this pointer every frame
2695         and should only reset the tiles if the new LayerRendererChromium is
2696         different from the old one (indicating a context loss), not just reset
2697         on every frame.
2698
2699         * platform/graphics/chromium/LayerTilerChromium.cpp:
2700         (WebCore::LayerTilerChromium::setLayerRenderer):
2701         * platform/graphics/chromium/LayerTilerChromium.h:
2702
2703 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2704
2705         Reviewed by Eric Seidel.
2706
2707         beginElement broken by setAttribute
2708         https://bugs.webkit.org/show_bug.cgi?id=26019
2709
2710         Test: svg/animations/animate-beginElementAt.svg
2711
2712         * svg/SVGAnimationElement.cpp:
2713         (WebCore::SVGAnimationElement::attributeChanged):
2714         Reset the animation state here as the rest of the code reads it and would still
2715         think we are animating when we are not.
2716
2717         * svg/animation/SVGSMILElement.h:
2718         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2719
2720 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2721
2722         Unreviewed, rolling out r84989.
2723         http://trac.webkit.org/changeset/84989
2724         https://bugs.webkit.org/show_bug.cgi?id=59566
2725
2726         REGRESSION (r84989): Lots of vertical text tests failing on
2727         windows (Requested by weinig on #webkit).
2728
2729         * platform/graphics/FontPlatformData.h:
2730         * platform/graphics/win/FontCacheWin.cpp:
2731         (WebCore::FontCache::getFontDataForCharacters):
2732         (WebCore::FontCache::createFontPlatformData):
2733         * platform/graphics/win/FontCustomPlatformData.cpp:
2734         (WebCore::FontCustomPlatformData::fontPlatformData):
2735         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2736         (WebCore::FontPlatformData::FontPlatformData):
2737         * platform/graphics/win/FontPlatformDataWin.cpp:
2738         (WebCore::FontPlatformData::FontPlatformData):
2739
2740 2011-04-26  Sam Weinig  <sam@webkit.org>
2741
2742         Reviewed by Eric Seidel.
2743
2744         Try again:
2745             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2746             https://bugs.webkit.org/show_bug.cgi?id=59310
2747
2748         * bindings/js/JSDOMBinding.h:
2749         (WebCore::DOMConstructorObject::DOMConstructorObject):
2750         * bindings/js/JSDOMWrapper.h:
2751         (WebCore::JSDOMWrapper::globalObject):
2752         (WebCore::JSDOMWrapper::scriptExecutionContext):
2753         (WebCore::JSDOMWrapper::createStructure):
2754         (WebCore::JSDOMWrapper::JSDOMWrapper):
2755         * bindings/scripts/CodeGeneratorJS.pm:
2756
2757 2011-04-26  Sam Weinig  <sam@webkit.org>
2758
2759         Reviewed by David Hyatt.
2760
2761         Remove Datagrid from the tree
2762         https://bugs.webkit.org/show_bug.cgi?id=59543
2763
2764         * Android.derived.jscbindings.mk:
2765         * Android.derived.v8bindings.mk:
2766         * Android.jscbindings.mk:
2767         * Android.v8bindings.mk:
2768         * CMakeLists.txt:
2769         * CodeGenerators.pri:
2770         * Configurations/FeatureDefines.xcconfig:
2771         * DerivedSources.cpp:
2772         * DerivedSources.make:
2773         * GNUmakefile.am:
2774         * GNUmakefile.list.am:
2775         * UseJSC.cmake:
2776         * WebCore.gypi:
2777         * WebCore.pro:
2778         * WebCore.vcproj/WebCore.vcproj:
2779         * WebCore.xcodeproj/project.pbxproj:
2780         * bindings/js/JSBindingsAllInOne.cpp:
2781         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2782         * bindings/js/JSDataGridDataSource.cpp: Removed.
2783         * bindings/js/JSDataGridDataSource.h: Removed.
2784         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2785         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2786         * bindings/v8/V8DataGridDataSource.h: Removed.
2787         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2788         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2789         * css/CSSStyleSelector.cpp:
2790         * css/CSSStyleSelector.h:
2791         * css/html.css:
2792         (input, textarea, keygen, select, button, isindex):
2793         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2794         * editing/htmlediting.cpp:
2795         (WebCore::canHaveChildrenForEditing):
2796         * features.pri:
2797         * html/DOMDataGridDataSource.cpp: Removed.
2798         * html/DOMDataGridDataSource.h: Removed.
2799         * html/DataGridColumn.cpp: Removed.
2800         * html/DataGridColumn.h: Removed.
2801         * html/DataGridColumn.idl: Removed.
2802         * html/DataGridColumnList.cpp: Removed.
2803         * html/DataGridColumnList.h: Removed.
2804         * html/DataGridColumnList.idl: Removed.
2805         * html/DataGridDataSource.h: Removed.
2806         * html/HTMLDataGridCellElement.cpp: Removed.
2807         * html/HTMLDataGridCellElement.h: Removed.
2808         * html/HTMLDataGridCellElement.idl: Removed.
2809         * html/HTMLDataGridColElement.cpp: Removed.
2810         * html/HTMLDataGridColElement.h: Removed.
2811         * html/HTMLDataGridColElement.idl: Removed.
2812         * html/HTMLDataGridElement.cpp: Removed.
2813         * html/HTMLDataGridElement.h: Removed.
2814         * html/HTMLDataGridElement.idl: Removed.
2815         * html/HTMLDataGridRowElement.cpp: Removed.
2816         * html/HTMLDataGridRowElement.h: Removed.
2817         * html/HTMLDataGridRowElement.idl: Removed.
2818         * html/HTMLElement.cpp:
2819         (WebCore::HTMLElement::ieForbidsInsertHTML):
2820         * html/HTMLElementsAllInOne.cpp:
2821         * html/HTMLTagNames.in:
2822         * page/DOMWindow.idl:
2823         * rendering/RenderBox.cpp:
2824         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2825         * rendering/RenderDataGrid.cpp: Removed.
2826         * rendering/RenderDataGrid.h: Removed.
2827         * rendering/RenderingAllInOne.cpp:
2828
2829 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2830
2831         Reviewed by Adele Peterson.
2832
2833         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2834         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2835
2836         This platform dependent patch makes WebKit (Windows) show the
2837         vertical writing text correctly.  Job was done by adding a prefix '@'
2838         in front of the font family name (Windows Only). No new tests added.
2839         Some layout tests images:
2840         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2841
2842         * platform/graphics/FontPlatformData.h:
2843         * platform/graphics/win/FontCacheWin.cpp:
2844         (WebCore::FontCache::getFontDataForCharacters):
2845         (WebCore::FontCache::createFontPlatformData):
2846         * platform/graphics/win/FontCustomPlatformData.cpp:
2847         (WebCore::FontCustomPlatformData::fontPlatformData):
2848         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2849         (WebCore::FontPlatformData::FontPlatformData):
2850         * platform/graphics/win/FontPlatformDataWin.cpp:
2851         (WebCore::FontPlatformData::FontPlatformData):
2852
2853 2011-04-26  Jer Noble  <jer.noble@apple.com>
2854
2855         Reviewed by Brady Eidson.
2856
2857         HTML5 video fullscreen transition causes an audio stutter
2858         https://bugs.webkit.org/show_bug.cgi?id=59544
2859
2860         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2861         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2862         layer to render it invisible, instead just set the layer as hidden.
2863
2864         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2865         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2866         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2867         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2868         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2869         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2870
2871 2011-04-26  Christian Dywan  <christian@lanedo.com>
2872
2873         Reviewed by Eric Seidel.
2874
2875         Extra separator after Select All in context menu
2876         https://bugs.webkit.org/show_bug.cgi?id=54092
2877
2878         * page/ContextMenuController.cpp: Move separator to non-GTK+
2879             port guards since it is for the spelling options menu
2880             which the GTK+ port doesn't use.
2881
2882 2011-04-26  James Robinson  <jamesr@chromium.org>
2883
2884         Reviewed by Kenneth Russell.
2885
2886         [chromium] Clear out LayerTilerChromium's tiles on lost context
2887         https://bugs.webkit.org/show_bug.cgi?id=59233
2888
2889         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
2890         no longer valid since they exist in the previous LayerRendererChromium.
2891
2892         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
2893
2894         * platform/graphics/chromium/LayerTilerChromium.h:
2895         (WebCore::LayerTilerChromium::setLayerRenderer):
2896
2897 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2898
2899         Reviewed by Dirk Schulze.
2900
2901         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
2902         https://bugs.webkit.org/show_bug.cgi?id=57644
2903
2904         Manual test: plugins/windowed-in-iframe-2.html
2905
2906         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
2907         * platform/gtk/WidgetGtk.cpp:
2908         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
2909         * plugins/PluginView.h: Added helper method to set the allocation and clip.
2910         * plugins/gtk/PluginViewGtk.cpp:
2911         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
2912         the allocation immediately. Bring this method into sync with the implementation in
2913         the Qt port.
2914         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
2915         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
2916
2917 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2918
2919         Reviewed by Eric Seidel.
2920
2921         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
2922         https://bugs.webkit.org/show_bug.cgi?id=58818
2923
2924         Prevent allocating scratch buffers larger than the target GdkDrawable
2925         when creating a WidgetRenderingContext. This prevents incredibly large
2926         widgets from crashing the X Server. This change also allowed greatly
2927         simplifying the way that the painting offset is calculated.
2928
2929         * platform/gtk/WidgetRenderingContext.cpp:
2930         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
2931         larger than the target GdkDrawable.
2932         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
2933         blit by looking at the location of the target rect itself, rather than delaying the
2934         calculation up to this point.
2935         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
2936         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
2937         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
2938         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
2939         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
2940         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
2941         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
2942         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
2943         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
2944         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
2945         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
2946         a member to store the IntSize mapping from the coordinates of the target to the coordinates
2947         of the scratch buffer.
2948
2949 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
2950
2951         Reviewed by Adam Barth.
2952
2953         Respect charset in handleDataURL
2954         https://bugs.webkit.org/show_bug.cgi?id=47746
2955
2956         Original patch by Kwang Yul Seo <skyul@company100.net>
2957
2958         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2959         returns an empty string because encoding name is not specified.
2960
2961         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2962
2963         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2964
2965         * platform/network/DataURL.cpp:
2966         (WebCore::handleDataURL):
2967
2968 2011-04-26  Anders Carlsson  <andersca@apple.com>
2969
2970         Fix clang++ build.
2971
2972         You can never have too many casts!
2973
2974         * accessibility/mac/AccessibilityObjectWrapper.mm:
2975         (-[AccessibilityObjectWrapper position]):
2976         * editing/mac/SelectionControllerMac.mm:
2977         (WebCore::accessibilityConvertScreenRect):
2978
2979 2011-04-26  Chris Rogers  <crogers@google.com>
2980
2981         Reviewed by Kenneth Russell.
2982
2983         Fix web audio build on mac port
2984         https://bugs.webkit.org/show_bug.cgi?id=59355
2985
2986         No new tests since audio API is not yet implemented.
2987
2988         * WebCore.xcodeproj/project.pbxproj:
2989         * bindings/js/JSAudioContextCustom.cpp:
2990         (WebCore::JSAudioContext::visitChildren):
2991         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
2992         (WebCore::JSJavaScriptAudioNode::visitChildren):
2993         * webaudio/AudioContext.idl:
2994
2995 2011-04-26  Chris Rogers  <crogers@google.com>
2996
2997         Reviewed by Kenneth Russell.
2998
2999         Add FFTFrame implementation for FFmpeg
3000         https://bugs.webkit.org/show_bug.cgi?id=59408
3001
3002         No new tests since audio API is not yet implemented.
3003
3004         * WebCore.gyp/WebCore.gyp:
3005         * WebCore.gypi:
3006         * platform/audio/FFTFrame.h:
3007         * platform/audio/FFTFrameStub.cpp:
3008         * platform/audio/ffmpeg: Added.
3009         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
3010         (WebCore::FFTFrame::FFTFrame):
3011         (WebCore::FFTFrame::initialize):
3012         (WebCore::FFTFrame::cleanup):
3013         (WebCore::FFTFrame::~FFTFrame):
3014         (WebCore::FFTFrame::multiply):
3015         (WebCore::FFTFrame::doFFT):
3016         (WebCore::FFTFrame::doInverseFFT):
3017         (WebCore::FFTFrame::realData):
3018         (WebCore::FFTFrame::imagData):
3019         (WebCore::FFTFrame::getUpToDateComplexData):
3020         (WebCore::FFTFrame::contextForSize):
3021         * platform/audio/mac/FFTFrameMac.cpp:
3022         * webaudio/ConvolverNode.cpp:
3023
3024 2011-04-26  Jeff Miller  <jeffm@apple.com>
3025
3026         Add a newline at the end of SVGFEDropShadowElement.idl.
3027
3028         * svg/SVGFEDropShadowElement.idl:
3029
3030 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
3031
3032         Reviewed by Eric Seidel.
3033
3034         InlineBox.h shouldn't include RenderBR.h
3035         https://bugs.webkit.org/show_bug.cgi?id=59480
3036
3037         Per bug 59348 RenderBR.h is a "top header" by include * size, because
3038         InlineBox.h includes it. There's no reason why it has to.
3039
3040         * rendering/InlineBox.h:
3041         * rendering/InlineTextBox.cpp:
3042         * rendering/RenderBlock.h:
3043
3044 2011-04-26  Sam Weinig  <sam@webkit.org>
3045
3046         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
3047         I should do.
3048
3049         * bindings/js/JSDOMBinding.h:
3050         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3051         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3052         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3053         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3054         (WebCore::DOMConstructorObject::DOMConstructorObject):
3055         * bindings/js/JSDOMWrapper.h:
3056         (WebCore::JSDOMWrapper::JSDOMWrapper):
3057         * bindings/scripts/CodeGeneratorJS.pm:
3058
3059 2011-04-26  Sam Weinig  <sam@webkit.org>
3060
3061         Fix build.
3062
3063         * bindings/js/JSDOMWrapper.h:
3064         (WebCore::JSDOMWrapper::globalObject):
3065
3066 2011-04-26  Sam Weinig  <sam@webkit.org>
3067
3068         Roll r84945 back in with infinite recursion removed.
3069
3070         * bindings/js/JSDOMBinding.h:
3071         (WebCore::DOMConstructorObject::DOMConstructorObject):
3072         * bindings/js/JSDOMWrapper.h:
3073         (WebCore::JSDOMWrapper::globalObject):
3074         (WebCore::JSDOMWrapper::scriptExecutionContext):
3075         (WebCore::JSDOMWrapper::createStructure):
3076         (WebCore::JSDOMWrapper::JSDOMWrapper):
3077         * bindings/scripts/CodeGeneratorJS.pm:
3078
3079 2011-04-26  Sam Weinig  <sam@webkit.org>
3080
3081         Rollout previous patch. It broke stuff.
3082
3083         * bindings/js/JSDOMBinding.h:
3084         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3085         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3086         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3087         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3088         (WebCore::DOMConstructorObject::DOMConstructorObject):
3089         * bindings/js/JSDOMWrapper.h:
3090         (WebCore::JSDOMWrapper::JSDOMWrapper):
3091         * bindings/scripts/CodeGeneratorJS.pm:
3092
3093 2011-04-26  Sam Weinig  <sam@webkit.org>
3094
3095         Reviewed by Maciej Stachowiak.
3096
3097         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
3098         https://bugs.webkit.org/show_bug.cgi?id=59310
3099
3100         * bindings/js/JSDOMBinding.h:
3101         (WebCore::DOMConstructorObject::DOMConstructorObject):
3102         * bindings/js/JSDOMWrapper.h:
3103         (WebCore::JSDOMWrapper::globalObject):
3104         (WebCore::JSDOMWrapper::scriptExecutionContext):
3105         (WebCore::JSDOMWrapper::createStructure):
3106         (WebCore::JSDOMWrapper::JSDOMWrapper):
3107         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
3108
3109         * bindings/scripts/CodeGeneratorJS.pm:
3110         Make JSDOMWrapper the base class.
3111
3112 2011-04-26  Dan Bernstein  <mitz@apple.com>
3113
3114         Reviewed by Mark Rowe.
3115
3116         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
3117
3118         * Configurations/Base.xcconfig:
3119         * Configurations/CompilerVersion.xcconfig: Added.
3120
3121 2011-04-26  Adrienne Walker  <enne@google.com>
3122
3123         Reviewed by Geoffrey Garen.
3124
3125         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
3126         https://bugs.webkit.org/show_bug.cgi?id=59469
3127
3128         * platform/chromium/TraceEvent.h:
3129         (WebCore::internal::ScopeTracer::ScopeTracer):
3130
3131 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3132
3133         Reviewed by Oliver Hunt.
3134
3135         Nixed special finalizer handling for WebCore strings
3136         https://bugs.webkit.org/show_bug.cgi?id=59425
3137
3138         Not needed anymore, since weak handles have finalizers.
3139
3140         * WebCore.exp.in: Exports!
3141
3142         * bindings/js/DOMWrapperWorld.cpp:
3143         (WebCore::JSStringOwner::finalize):
3144         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
3145         so we don't need special treatment anymore.
3146
3147         * bindings/js/DOMWrapperWorld.h:
3148         (WebCore::JSStringOwner::JSStringOwner):
3149         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
3150         instead of a WeakGCMap, so we can specify a custom finalizer.
3151
3152         * bindings/js/JSDOMBinding.cpp:
3153         (WebCore::jsStringSlowCase):
3154         * bindings/js/JSDOMBinding.h:
3155         (WebCore::jsString): Updated for string map change.
3156
3157 2011-04-26  David Kilzer  <ddkilzer@apple.com>
3158
3159         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
3160
3161         Reviewed by Antti Koivisto.
3162
3163         To enable HTTP pipelining post-SnowLeopard, use this command:
3164
3165             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
3166
3167         * platform/network/cf/ResourceRequestCFNet.cpp:
3168         (WebCore::readBooleanPreference): Re-added.  Originally added in
3169         r76756 and removed in r84120.
3170         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
3171         HTTP pipelining if use default is set to true.  Added macro
3172         guards to match those in ResourceRequestMac.mm.
3173
3174 2011-04-26  Antti Koivisto  <antti@apple.com>
3175
3176         Reviewed by Adele Peterson.
3177
3178         Don't strip fragments from file: urls in memory cache
3179         https://bugs.webkit.org/show_bug.cgi?id=59463
3180         <rdar://problem/9231130>
3181
3182         Some clients expect file: resources to be unique based on fragment identifier. 
3183         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
3184
3185         Test: fast/loader/file-protocol-fragment.html
3186
3187         * loader/cache/MemoryCache.cpp:
3188         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
3189
3190 2011-04-26  David Levin  <levin@chromium.org>
3191
3192         Reviewed by Darin Adler.
3193
3194         Fix more strict OwnPtr in WebCore (round N).
3195         https://bugs.webkit.org/show_bug.cgi?id=59464
3196
3197         * dom/Document.cpp:
3198         (WebCore::Document::Document):
3199         (WebCore::Document::attach):
3200         * fileapi/FileReader.cpp:
3201         (WebCore::FileReader::terminate):
3202         * loader/DocumentThreadableLoader.cpp:
3203         (WebCore::DocumentThreadableLoader::preflightFailure):
3204         * workers/DefaultSharedWorkerRepository.cpp:
3205         (WebCore::SharedWorkerConnectTask::create):
3206         (WebCore::SharedWorkerScriptLoader::load):
3207
3208 2011-04-26  Ruben  <chromium@hybridsource.org>
3209
3210         Reviewed by Tony Chang.
3211
3212         Change linux ifdefs for Chromium to Unix instead, allowing
3213         new Unix ports to be enabled by default
3214         https://bugs.webkit.org/show_bug.cgi?id=59297
3215
3216         No new tests, just changing preprocessor defines.
3217
3218         * bindings/js/JSInspectorFrontendHostCustom.cpp:
3219         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
3220         * dom/SelectElement.cpp:
3221         * loader/cache/CachedFont.cpp:
3222         * page/EventHandler.cpp:
3223         * page/chromium/EventHandlerChromium.cpp:
3224         * platform/Scrollbar.cpp:
3225         * platform/chromium/PlatformBridge.h:
3226         * platform/graphics/chromium/FontPlatformData.h:
3227         * platform/graphics/skia/FontCustomPlatformData.cpp:
3228         * platform/graphics/skia/FontCustomPlatformData.h:
3229
3230 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3231
3232         Reviewed by Dan Bernstein.
3233
3234         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
3235         https://bugs.webkit.org/show_bug.cgi?id=49111
3236
3237         Even when the offset corresponds to a position visually left of the box
3238         and there aren't any inline boxes on the left, the previous/next position
3239         may still correspond to some position in the same line.
3240
3241         The bug was caused by our ignoring such cases. Fixed the bug by comparing
3242         previous/next position's inline box to the current box. If they match,
3243         then we stay on the same position because moving to the left visually at
3244         the left edge should not result in a position on the same line.
3245
3246         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
3247         the left edge or to the right edge, and a bug that WebKit could not move to
3248         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
3249
3250         Test cases are added to editing/selection/move-left-right.html
3251
3252         * editing/VisiblePosition.cpp:
3253         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
3254         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
3255
3256 2011-04-26  Gabor Loki  <loki@webkit.org>
3257
3258         Reviewed by Csaba Osztrogonác.
3259
3260         Speeding up SVG filters with multicore (SMP) support
3261         https://bugs.webkit.org/show_bug.cgi?id=43903
3262
3263         Some SVG filters execute a huge number of pixel manipulations, which
3264         cannot be sped up by graphics accelerators, since their algorithm is
3265         too complex. Using the power of Symmetric Multi Processing (SMP) we
3266         can split up a task to smaller (data independent) tasks, which can be
3267         executed independently.
3268
3269         The ParallelJobs framework provides a simple way for distributed
3270         programming. The framework is based on WebKit's threading infrastructure,
3271         Open Multi-Processing's (OpenMP) API, and libdispatch API.
3272
3273         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
3274         * platform/graphics/filters/FETurbulence.cpp:
3275         (WebCore::FETurbulence::PaintingData::PaintingData):
3276         (WebCore::FETurbulence::noise2D):
3277         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
3278         (WebCore::FETurbulence::fillRegion):
3279         (WebCore::FETurbulence::fillRegionWorker):
3280         (WebCore::FETurbulence::apply):
3281         * platform/graphics/filters/FETurbulence.h:
3282
3283 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3284
3285         Reviewed by Yury Semikhatsky.
3286
3287         Web Inspector: close button is off in docked mode on a mac.
3288         https://bugs.webkit.org/show_bug.cgi?id=59453
3289
3290         * inspector/front-end/inspector.css:
3291         (.toolbar-item.close-left):
3292
3293 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3294
3295         Reviewed by Yury Semikhatsky.
3296
3297         Web Inspector: New Style is not working (UI glitch)
3298         https://bugs.webkit.org/show_bug.cgi?id=59451
3299
3300         * inspector/InspectorDOMStorageAgent.cpp:
3301         (WebCore::InspectorDOMStorageAgent::setFrontend):
3302         * inspector/front-end/AuditRules.js:
3303         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
3304         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
3305         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
3306         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
3307         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
3308         * inspector/front-end/CSSStyleModel.js:
3309         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
3310         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
3311         (WebInspector.CSSStyleModel.prototype.addRule):
3312         (WebInspector.CSSStyleModel.prototype.addRule.callback):
3313         (WebInspector.CSSStyleModel.prototype._documentElementId):
3314         * inspector/front-end/DOMAgent.js:
3315         (WebInspector.DOMNode.prototype._addAttribute):
3316         (WebInspector.DOMNode.prototype.documentElement):
3317         * inspector/front-end/ResourceTreeModel.js:
3318         (WebInspector.PageDispatcher.prototype.frameDetached):
3319         * inspector/front-end/StylesSidebarPane.js:
3320         (WebInspector.StylesSidebarPane.prototype._createNewRule):
3321
3322 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3323
3324         Reviewed by Yury Semikhatsky.
3325
3326         Web Inspector: introduce DOMStorage::enable and disable.
3327         https://bugs.webkit.org/show_bug.cgi?id=59445
3328
3329         * inspector/Inspector.json:
3330         * inspector/InspectorAgent.cpp:
3331         (WebCore::InspectorAgent::InspectorAgent):
3332         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3333         * inspector/InspectorDOMStorageAgent.cpp:
3334         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
3335         (WebCore::InspectorDOMStorageAgent::restore):
3336         (WebCore::InspectorDOMStorageAgent::enable):
3337         (WebCore::InspectorDOMStorageAgent::disable):
3338         * inspector/InspectorDOMStorageAgent.h:
3339         (WebCore::InspectorDOMStorageAgent::create):
3340         * inspector/front-end/DOMStorage.js:
3341         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3342         * inspector/front-end/ResourcesPanel.js:
3343         (WebInspector.ResourcesPanel.prototype._reset):
3344         * inspector/front-end/inspector.js:
3345
3346 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3347
3348         Reviewed by Yury Semikhatsky.
3349
3350         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
3351         https://bugs.webkit.org/show_bug.cgi?id=59440
3352
3353         * inspector/Inspector.json:
3354         * inspector/InspectorAgent.cpp:
3355         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3356         * inspector/InspectorPageAgent.cpp:
3357         (WebCore::InspectorPageAgent::setFrontend):
3358         (WebCore::InspectorPageAgent::frameNavigated):
3359         * inspector/InspectorPageAgent.h:
3360         * inspector/front-end/AuditsPanel.js:
3361         (WebInspector.AuditsPanel):
3362         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
3363         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
3364         * inspector/front-end/CSSStyleModel.js:
3365         (WebInspector.CSSStyleModelResourceBinding):
3366         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
3367         * inspector/front-end/DOMBreakpointsSidebarPane.js:
3368         (WebInspector.DOMBreakpointsSidebarPane):
3369         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
3370         * inspector/front-end/DOMStorage.js:
3371         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3372         * inspector/front-end/ExtensionServer.js:
3373         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
3374         (WebInspector.ExtensionServer.prototype.initExtensions):
3375         * inspector/front-end/NetworkPanel.js:
3376         (WebInspector.NetworkPanel):
3377         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
3378         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
3379         (WebInspector.NetworkPanel.prototype._frameNavigated):
3380         * inspector/front-end/ResourceTreeModel.js:
3381         (WebInspector.ResourceTreeModel):
3382         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
3383         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
3384         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
3385         (WebInspector.ResourceTreeModel.prototype._frameDetached):
3386         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
3387         (WebInspector.PageDispatcher):
3388         (WebInspector.PageDispatcher.prototype.domContentEventFired):
3389         (WebInspector.PageDispatcher.prototype.loadEventFired):
3390         (WebInspector.PageDispatcher.prototype.frameNavigated):
3391         (WebInspector.PageDispatcher.prototype.frameDetached):
3392         * inspector/front-end/ResourcesPanel.js:
3393         (WebInspector.ResourcesPanel):
3394         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
3395         (WebInspector.ResourcesPanel.prototype._frameNavigated):
3396         * inspector/front-end/inspector.js:
3397
3398 2011-04-26  Csaba Osztrogonác  <ossy@webkit.org>
3399
3400         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
3401         because it broke transitions/multiple-text-shadow-transition.html
3402
3403         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3404         https://bugs.webkit.org/show_bug.cgi?id=59377
3405
3406         * css/CSSStyleSelector.cpp:
3407         (WebCore::CSSStyleSelector::applyProperty):
3408         * page/animation/AnimationBase.cpp:
3409         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3410         (WebCore::PropertyWrapperShadow::blend):
3411         * rendering/style/RenderStyle.cpp:
3412         (WebCore::RenderStyle::setTextShadow):
3413         (WebCore::RenderStyle::setBoxShadow):
3414         * rendering/style/RenderStyle.h:
3415         (WebCore::InheritedFlags::textShadow):
3416         * rendering/style/StyleRareInheritedData.cpp:
3417         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3418         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3419         * rendering/style/StyleRareInheritedData.h:
3420         * rendering/style/StyleRareNonInheritedData.cpp:
3421         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3422
3423 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
3424
3425         Reviewed by Adam Barth.
3426
3427         Turn off make built-in implicit rules for derived sources makefile
3428         https://bugs.webkit.org/show_bug.cgi?id=59418
3429
3430         We don't use any of make's built-in implicit rules, turning them off
3431         speeds up parsing of the makefile.
3432
3433         * WebCore.xcodeproj/project.pbxproj:
3434         * gyp/generate-derived-sources.sh:
3435
3436 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
3437
3438         Reviewed by Nikolas Zimmermann.
3439
3440         ASSERT failure in SVGUseElement
3441         https://bugs.webkit.org/show_bug.cgi?id=59313
3442
3443         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3444         was wrong because the document may not be well-formed.
3445
3446         This patch asserts the element is not pending on resource or the
3447         document is not well-formed.
3448
3449         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3450
3451         * svg/SVGUseElement.cpp:
3452         (WebCore::isWellFormedDocument):
3453         (WebCore::SVGUseElement::insertedIntoDocument):
3454
3455 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
3456
3457         Reviewed by Pavel Feldman.
3458
3459         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
3460         https://bugs.webkit.org/show_bug.cgi?id=59438
3461
3462         * inspector/front-end/DetailedHeapshotView.js:
3463         (WebInspector.DetailedHeapshotView.prototype._changeView):
3464
3465 2011-04-26  David Levin  <levin@chromium.org>
3466
3467         Reviewed by Adam Barth.
3468
3469         Fix a few OwnPtr strict errors in WebCore headers.
3470         https://bugs.webkit.org/show_bug.cgi?id=59431
3471
3472         * bindings/js/ScheduledAction.cpp:
3473         (WebCore::ScheduledAction::create):
3474         * css/MediaQueryMatcher.cpp:
3475         (WebCore::MediaQueryMatcher::prepareEvaluator):
3476         * dom/NodeRareData.h:
3477         (WebCore::NodeListsNodeData::create):
3478         * dom/ScriptRunner.h:
3479         (WebCore::ScriptRunner::create):
3480         * inspector/WorkerInspectorController.cpp:
3481         (WebCore::WorkerInspectorController::connectFrontend):
3482         * loader/icon/IconDatabase.h:
3483         (WebCore::IconDatabase::create):
3484         * platform/graphics/SimpleFontData.cpp:
3485         (WebCore::SimpleFontData::verticalRightOrientationFontData):
3486         (WebCore::SimpleFontData::uprightOrientationFontData):
3487         (WebCore::SimpleFontData::brokenIdeographFontData):
3488         * rendering/style/StyleRareInheritedData.cpp:
3489         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3490         * rendering/svg/SVGResources.h:
3491         (WebCore::SVGResources::ClipperFilterMaskerData::create):
3492         (WebCore::SVGResources::MarkerData::create):
3493         (WebCore::SVGResources::FillStrokeData::create):
3494         * storage/StorageSyncManager.cpp:
3495         (WebCore::StorageSyncManager::close):
3496         * workers/WorkerContext.cpp:
3497         (WebCore::CloseWorkerContextTask::create):
3498         * workers/WorkerMessagingProxy.cpp:
3499         (WebCore::MessageWorkerContextTask::create):
3500         (WebCore::MessageWorkerTask::create):
3501         (WebCore::WorkerExceptionTask::create):
3502         (WebCore::WorkerContextDestroyedTask::create):
3503         (WebCore::WorkerTerminateTask::create):
3504         (WebCore::WorkerThreadActivityReportTask::create):
3505         * workers/WorkerRunLoop.cpp:
3506         (WebCore::WorkerRunLoop::Task::create):
3507         * workers/WorkerThread.cpp:
3508         (WebCore::WorkerThreadStartupData::create):
3509         (WebCore::WorkerThreadShutdownFinishTask::create):
3510         (WebCore::WorkerThreadShutdownStartTask::create):
3511
3512 2011-04-26  Adam Klein  <adamk@chromium.org>
3513
3514         Reviewed by Adam Barth.
3515
3516         Fix last strict OwnPtr violation under svg/...
3517         https://bugs.webkit.org/show_bug.cgi?id=59429
3518
3519         * svg/SVGDocumentExtensions.cpp:
3520         (WebCore::SVGDocumentExtensions::removePendingResource):
3521
3522 2011-04-26  Adam Barth  <abarth@webkit.org>
3523
3524         Reviewed by David Levin.
3525
3526         Fix more strict OwnPtr violations in WebCore
3527         https://bugs.webkit.org/show_bug.cgi?id=59433
3528
3529         These manifest in the Chromium build.
3530
3531         * bindings/v8/ScriptController.cpp:
3532         (WebCore::ScriptController::ScriptController):
3533         * bindings/v8/ScriptDebugServer.cpp:
3534         (WebCore::ScriptDebugServer::editScriptSource):
3535         * bindings/v8/V8DOMMap.cpp:
3536         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
3537         * bindings/v8/V8Proxy.cpp:
3538         (WebCore::V8Proxy::precompileScript):
3539         * bindings/v8/WorkerScriptController.cpp:
3540         (WebCore::WorkerScriptController::WorkerScriptController):
3541         * page/Page.cpp:
3542         (WebCore::Page::Page):
3543         (WebCore::Page::speechInput):
3544         * platform/PlatformGestureRecognizer.cpp:
3545         (WebCore::PlatformGestureRecognizer::create):
3546         * platform/PlatformGestureRecognizer.h:
3547         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3548         (WebCore::DrawingBuffer::DrawingBuffer):
3549         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3550         (WebCore::CCLayerImpl::CCLayerImpl):
3551         * platform/graphics/gpu/Texture.cpp:
3552         (WebCore::Texture::create):
3553         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
3554         (WebCore::BMPImageDecoder::decodeHelper):
3555         * platform/image-decoders/gif/GIFImageDecoder.cpp:
3556         (WebCore::GIFImageDecoder::decode):
3557         * platform/image-decoders/ico/ICOImageDecoder.cpp:
3558         (WebCore::ICOImageDecoder::decodeAtIndex):
3559         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3560         (WebCore::JPEGImageDecoder::decode):
3561         * platform/image-decoders/png/PNGImageDecoder.cpp:
3562         (WebCore::PNGImageDecoder::decode):
3563         * storage/chromium/DatabaseTrackerChromium.cpp:
3564         (WebCore::DatabaseTracker::addOpenDatabase):
3565
3566 2011-04-25  David Levin  <levin@chromium.org>
3567
3568         Reviewed by Adam Barth.
3569
3570         Fix OwnPtr strict errors in CrossThreadTask.h
3571         https://bugs.webkit.org/show_bug.cgi?id=59427
3572
3573         * dom/CrossThreadTask.h:
3574         (WebCore::CrossThreadTask1::create):
3575         (WebCore::CrossThreadTask2::create):
3576         (WebCore::CrossThreadTask3::create):
3577         (WebCore::CrossThreadTask4::create):
3578         (WebCore::CrossThreadTask5::create):
3579         (WebCore::CrossThreadTask6::create):
3580         (WebCore::CrossThreadTask7::create):
3581         (WebCore::CrossThreadTask8::create):
3582
3583 2011-04-25  Mark Rowe  <mrowe@apple.com>
3584
3585         Reviewed by Dan Bernstein.
3586
3587         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
3588
3589         * css/CSSStyleApplyProperty.cpp:
3590         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
3591         * css/CSSStyleApplyProperty.h:
3592         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
3593
3594 2011-04-25  Levi Weintraub  <leviw@chromium.org>
3595
3596         Reviewed by Ryosuke Niwa.
3597
3598         REGRESSION: a character appears after tab span when typing immediately before the tab span
3599         https://bugs.webkit.org/show_bug.cgi?id=58132
3600
3601         Correcting the order of operations we use to avoid inserting into invalid positions in
3602         ReplaceSelectionCommand to avoid inserting into tab-spans.
3603
3604         Test: editing/pasteboard/paste-before-tab-span.html
3605
3606         * editing/ReplaceSelectionCommand.cpp:
3607         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
3608         positionAvoidingPrecedingNodes, since that function could once again put our position
3609         inside a tab span.
3610
3611 2011-04-25  David Levin  <levin@chromium.org>
3612
3613         Reviewed by Adam Barth.
3614
3615         Fix OwnPtr strict error in ImageBuffer.h
3616         https://bugs.webkit.org/show_bug.cgi?id=59422
3617
3618         * platform/graphics/ImageBuffer.h:
3619         (WebCore::ImageBuffer::create):
3620
3621 2011-04-25  Adam Barth  <abarth@webkit.org>
3622
3623         Reviewed by David Levin.
3624
3625         Fix strict OwnPtr violations and whitelist known-tricky files
3626         https://bugs.webkit.org/show_bug.cgi?id=59421
3627
3628         With this patch, WebCore builds cleanly with strict OwnPtrs.
3629
3630         * dom/MessagePort.cpp:
3631         (WebCore::MessagePort::MessagePort):
3632         * dom/XMLDocumentParserLibxml2.cpp:
3633         * page/ContextMenuController.cpp:
3634         (WebCore::ContextMenuController::ContextMenuController):
3635         (WebCore::ContextMenuController::clearContextMenu):
3636         * page/PluginHalter.cpp:
3637         * platform/graphics/MediaPlayer.cpp:
3638         * platform/network/ResourceRequestBase.cpp:
3639         (WebCore::ResourceRequestBase::adopt):
3640         (WebCore::ResourceRequestBase::copyData):
3641         * svg/SVGDocumentExtensions.cpp:
3642
3643 2011-04-25  David Levin  <levin@chromium.org>
3644
3645         Reviewed by Adam Barth.
3646
3647         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
3648         https://bugs.webkit.org/show_bug.cgi?id=59419
3649
3650         * dom/DatasetDOMStringMap.h:
3651         (WebCore::DatasetDOMStringMap::create):
3652
3653 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3654
3655         Reviewed by Eric Seidel.
3656
3657         KeyboardEvent.cpp should work with strict OwnPtrs.
3658         https://bugs.webkit.org/show_bug.cgi?id=59403
3659
3660         * dom/KeyboardEvent.cpp:
3661         (WebCore::KeyboardEvent::KeyboardEvent):
3662
3663 2011-04-25  James Robinson  <jamesr@chromium.org>
3664
3665         Reviewed by Eric Seidel.
3666
3667         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3668         https://bugs.webkit.org/show_bug.cgi?id=59377
3669
3670         * css/CSSStyleSelector.cpp:
3671         (WebCore::CSSStyleSelector::applyProperty):
3672         * page/animation/AnimationBase.cpp:
3673         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3674         (WebCore::PropertyWrapperShadow::blend):
3675         * rendering/style/RenderStyle.cpp:
3676         (WebCore::RenderStyle::setTextShadow):
3677         (WebCore::RenderStyle::setBoxShadow):
3678         * rendering/style/RenderStyle.h:
3679         (WebCore::InheritedFlags::textShadow):
3680         * rendering/style/StyleRareInheritedData.cpp:
3681         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3682         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3683         * rendering/style/StyleRareInheritedData.h:
3684         * rendering/style/StyleRareNonInheritedData.cpp:
3685         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3686
3687 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3688
3689         Unreviewed, rolling out r84864.
3690         http://trac.webkit.org/changeset/84864
3691         https://bugs.webkit.org/show_bug.cgi?id=59413
3692
3693         Expect result of use-crash-in-non-wellformed-document.svg is
3694         platform dependent (Requested by leoyang on #webkit).
3695
3696         * svg/SVGUseElement.cpp:
3697         (WebCore::SVGUseElement::insertedIntoDocument):
3698
3699 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
3700
3701         Reviewed by Nikolas Zimmermann.
3702
3703         ASSERT failure in SVGUseElement
3704         https://bugs.webkit.org/show_bug.cgi?id=59313
3705
3706         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3707         was wrong because the document may not be well-formed.
3708
3709         This patch asserts the element is not pending on resource or the
3710         document is not well-formed.
3711
3712         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3713
3714         * svg/SVGUseElement.cpp:
3715         (WebCore::isWellFormedDocument):
3716         (WebCore::SVGUseElement::insertedIntoDocument):
3717
3718 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3719
3720         Reviewed by Tony Chang.
3721
3722         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3723         https://bugs.webkit.org/show_bug.cgi?id=59028
3724
3725         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3726         Moving the code for base class we can reduce the efforts to support DataTransferItems
3727         element in different platforms.
3728
3729         * Android.mk:
3730         * CMakeLists.txt:
3731         * GNUmakefile.list.am:
3732         * WebCore.gypi:
3733         * WebCore.pro:
3734         * WebCore.vcproj/WebCore.vcproj:
3735         * WebCore.xcodeproj/project.pbxproj:
3736         * dom/DataTransferItem.cpp:
3737         (WebCore::DataTransferItem::DataTransferItem):
3738         (WebCore::DataTransferItem::owner):
3739         (WebCore::DataTransferItem::kind):
3740         (WebCore::DataTransferItem::type):
3741         * dom/DataTransferItem.h:
3742         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3743         (WebCore::DataTransferItems::DataTransferItems):
3744         (WebCore::DataTransferItems::length):
3745         (WebCore::DataTransferItems::item):
3746         (WebCore::DataTransferItems::deleteItem):
3747         (WebCore::DataTransferItems::clear):
3748         (WebCore::DataTransferItems::add):
3749         * dom/DataTransferItems.h:
3750         * platform/chromium/DataTransferItemChromium.cpp:
3751         (WebCore::DataTransferItem::create):
3752         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3753         (WebCore::DataTransferItemChromium::getAsString):
3754         (WebCore::DataTransferItemChromium::getAsFile):
3755         * platform/chromium/DataTransferItemChromium.h:
3756         * platform/chromium/DataTransferItemsChromium.cpp:
3757         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3758         * platform/chromium/DataTransferItemsChromium.h:
3759
3760 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3761
3762         Reviewed by Simon Fraser.
3763
3764         REGRESSION(75137): directly composited images are double-drawn sometimes
3765         https://bugs.webkit.org/show_bug.cgi?id=58632
3766
3767         Depending on the order of operations (layout, creating compositing 
3768         layers and creating simple image layers) a layer can have both image
3769         content and have m_drawsContent=true. In this case 2 copies of the image
3770         are drawn in the layer. If the image has alpha, it looks wrong.
3771
3772         I added an updateDrawsContent() call after setting the image contents
3773         to make sure it's correct.
3774
3775         I couldn't create a test case that shows the problem because layerTreeAsText()
3776         doesn't emit enough info to show this level of detail. I've opened
3777         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3778
3779         * rendering/RenderLayerBacking.cpp:
3780         (WebCore::RenderLayerBacking::updateImageContents):
3781
3782 2011-04-25  Kenneth Russell  <kbr@google.com>
3783
3784         Reviewed by David Levin.
3785
3786         Fix OwnPtr strict errors in InlineFlowBox.cpp
3787         https://bugs.webkit.org/show_bug.cgi?id=59392
3788
3789         * rendering/InlineFlowBox.cpp:
3790         (WebCore::InlineFlowBox::setLayoutOverflow):
3791         (WebCore::InlineFlowBox::setVisualOverflow):
3792
3793 2011-04-25  Kenneth Russell  <kbr@google.com>
3794
3795         Reviewed by David Levin.
3796
3797         Fix OwnPtr strict errors in TransformState.cpp
3798         https://bugs.webkit.org/show_bug.cgi?id=59380
3799
3800         * rendering/TransformState.cpp:
3801         (WebCore::TransformState::applyTransform):
3802
3803 2011-04-25  Adam Barth  <abarth@webkit.org>
3804
3805         Reviewed by James Robinson.
3806
3807         DOMWindow.cpp should work with strict OwnPtrs
3808         https://bugs.webkit.org/show_bug.cgi?id=59356
3809
3810         * page/DOMWindow.cpp:
3811         (WebCore::PostMessageTimer::fired):
3812         (WebCore::DOMWindow::postMessageTimerFired):
3813         * page/DOMWindow.h:
3814
3815 2011-04-25  Adam Klein  <adamk@chromium.org>
3816
3817         Reviewed by James Robinson.
3818
3819         Fix OwnPtr strict errors in some SVG classes.
3820         https://bugs.webkit.org/show_bug.cgi?id=59395
3821
3822         * rendering/style/SVGRenderStyleDefs.cpp:
3823         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3824         * svg/SVGSVGElement.cpp:
3825         (WebCore::SVGSVGElement::SVGSVGElement):
3826         * svg/SVGStyledTransformableElement.cpp:
3827         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3828         * svg/SVGTextElement.cpp:
3829         (WebCore::SVGTextElement::supplementalTransform):
3830         * svg/graphics/SVGImage.cpp:
3831         (WebCore::SVGImage::dataChanged):
3832
3833 2011-04-25  Adam Barth  <abarth@webkit.org>
3834
3835         Re-land changes to ValidationMessage.
3836
3837         * html/ValidationMessage.cpp:
3838         (WebCore::ValidationMessage::setMessage):
3839         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3840         (WebCore::ValidationMessage::requestToHideMessage):
3841
3842 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3843
3844         Reviewed by James Robinson.
3845
3846         fix OwnPtr strict error in FrameView.cpp
3847         https://bugs.webkit.org/show_bug.cgi?id=59402
3848
3849         * page/FrameView.cpp:
3850         (WebCore::FrameView::FrameView):
3851         (WebCore::FrameView::addWidgetToUpdate):
3852
3853 2011-04-25  Adam Klein  <adamk@chromium.org>
3854
3855         Unreviewed, rolling out r84844.
3856         http://trac.webkit.org/changeset/84844
3857         https://bugs.webkit.org/show_bug.cgi?id=59395
3858
3859         Checked in too much.
3860
3861         * rendering/style/SVGRenderStyleDefs.cpp:
3862         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3863         * svg/SVGDocumentExtensions.cpp:
3864         (WebCore::SVGDocumentExtensions::removePendingResource):
3865         * svg/SVGSVGElement.cpp:
3866         (WebCore::SVGSVGElement::SVGSVGElement):
3867         * svg/SVGStyledTransformableElement.cpp:
3868         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3869         * svg/SVGTextElement.cpp:
3870         (WebCore::SVGTextElement::supplementalTransform):
3871         * svg/graphics/SVGImage.cpp:
3872         (WebCore::SVGImage::dataChanged):
3873
3874 2011-04-25  Adrienne Walker  <enne@google.com>
3875
3876         Reviewed by David Levin.
3877
3878         Make ActiveDOMCallback play nice with OwnPtr strict mode
3879         https://bugs.webkit.org/show_bug.cgi?id=59398
3880
3881         * bindings/generic/ActiveDOMCallback.cpp:
3882         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
3883
3884 2011-04-25  Adam Klein  <adamk@chromium.org>
3885
3886         Reviewed by James Robinson.
3887
3888         Fix OwnPtr strict errors in some SVG classes.
3889         https://bugs.webkit.org/show_bug.cgi?id=59395
3890
3891         * rendering/style/SVGRenderStyleDefs.cpp:
3892         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3893         * svg/SVGSVGElement.cpp:
3894         (WebCore::SVGSVGElement::SVGSVGElement):
3895         * svg/SVGStyledTransformableElement.cpp:
3896         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3897         * svg/SVGTextElement.cpp:
3898         (WebCore::SVGTextElement::supplementalTransform):
3899         * svg/graphics/SVGImage.cpp:
3900         (WebCore::SVGImage::dataChanged):
3901
3902 2011-04-25  James Robinson  <jamesr@chromium.org>
3903
3904         Unreviewed, rolling out r84835.
3905         http://trac.webkit.org/changeset/84835
3906         https://bugs.webkit.org/show_bug.cgi?id=59394
3907
3908         Breaks compile because Deque<OwnPtr> doesn't work
3909
3910         * dom/XMLDocumentParserLibxml2.cpp:
3911         (WebCore::PendingCallbacks::~PendingCallbacks):
3912         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3913         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3914         (WebCore::PendingCallbacks::appendCharactersCallback):
3915         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3916         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3917         (WebCore::PendingCallbacks::appendCommentCallback):
3918         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3919         (WebCore::PendingCallbacks::appendErrorCallback):
3920         (WebCore::XMLDocumentParser::XMLDocumentParser):
3921         * html/ValidationMessage.cpp:
3922         (WebCore::ValidationMessage::setMessage):
3923         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3924         (WebCore::ValidationMessage::requestToHideMessage):
3925
3926 2011-04-25  James Robinson  <jamesr@chromium.org>
3927
3928         Reviewed by Sam Weinig.
3929
3930         Fix OwnPtr strict mode violation in ImageBufferCG
3931         https://bugs.webkit.org/show_bug.cgi?id=59396
3932
3933         * platform/graphics/cg/ImageBufferCG.cpp:
3934         (WebCore::ImageBuffer::ImageBuffer):
3935
3936 2011-04-25  Huang Dongsung  <luxtella@company100.net>
3937
3938         Reviewed by Dirk Schulze.
3939
3940         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
3941         https://bugs.webkit.org/show_bug.cgi?id=59308
3942
3943         An unused local variable is created and even allocates heap memory.
3944
3945         * platform/graphics/skia/PlatformContextSkia.cpp:
3946         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
3947
3948 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3949
3950         Qt build fix: Updated files not used by other ports for rename.
3951
3952         * bindings/js/JSTouchCustom.cpp:
3953         (WebCore::toJSNewlyCreated):
3954         * bindings/js/JSTouchListCustom.cpp:
3955         (WebCore::toJSNewlyCreated):
3956
3957 2011-04-25  Adrienne Walker  <enne@google.com>
3958
3959         Reviewed by David Levin.
3960
3961         WebCore/css/CSS* files should play nice with strict OwnPtrs
3962         https://bugs.webkit.org/show_bug.cgi?id=59382
3963
3964         * css/CSSFontFaceSource.cpp:
3965         (WebCore::CSSFontFaceSource::getFontData):
3966         * css/CSSParser.cpp:
3967         (WebCore::CSSParser::addProperty):
3968         (WebCore::CSSParser::parseValue):
3969
3970 2011-04-25  Adam Barth  <abarth@webkit.org>
3971
3972         Reviewed by James Robinson.
3973
3974         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
3975         https://bugs.webkit.org/show_bug.cgi?id=59394
3976
3977         * dom/XMLDocumentParserLibxml2.cpp:
3978         (WebCore::PendingCallbacks::PendingCallbacks):
3979         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3980         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3981         (WebCore::PendingCallbacks::appendCharactersCallback):
3982         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3983         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3984         (WebCore::PendingCallbacks::appendCommentCallback):
3985         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3986         (WebCore::PendingCallbacks::appendErrorCallback):
3987         (WebCore::XMLDocumentParser::XMLDocumentParser):
3988         * html/ValidationMessage.cpp:
3989         (WebCore::ValidationMessage::setMessage):
3990         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3991         (WebCore::ValidationMessage::requestToHideMessage):
3992
3993 2011-04-25  James Robinson  <jamesr@chromium.org>
3994
3995         Reviewed by Adam Barth.
3996
3997         Fix OwnPtr strictness issues in WebCore/inspector/
3998         https://bugs.webkit.org/show_bug.cgi?id=59387
3999
4000         * inspector/InspectorAgent.cpp:
4001         (WebCore::InspectorAgent::InspectorAgent):
4002         * inspector/InspectorController.cpp:
4003         (WebCore::InspectorController::InspectorController):
4004         * inspector/InspectorStyleSheet.cpp:
4005         (WebCore::InspectorStyleSheet::ensureSourceData):
4006
4007 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4008
4009         Reviewed by Beth Dakin.
4010
4011         Removed XPathNamespace because it was unused
4012         https://bugs.webkit.org/show_bug.cgi?id=59381
4013         
4014         This allows us to make Node::ownerDocument() non-virtual, though it has
4015         the unhappy side-effect of rebuilding the world.
4016
4017         * CMakeLists.txt:
4018         * GNUmakefile.list.am:
4019         * WebCore.gypi:
4020         * WebCore.pro:
4021         * WebCore.vcproj/WebCore.vcproj:
4022         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
4023
4024         * dom/Node.h: Hello fast code!
4025
4026         * xml/XPathNamespace.cpp: Removed.
4027         * xml/XPathNamespace.h: Removed.
4028
4029 2011-04-25  Adam Barth  <abarth@webkit.org>
4030
4031         Reviewed by Darin Adler.
4032
4033         HistoryItemMac should play nice with OwnPtrs
4034         https://bugs.webkit.org/show_bug.cgi?id=59388
4035
4036         * history/mac/HistoryItemMac.mm:
4037         (WebCore::HistoryItem::setTransientProperty):
4038
4039 2011-04-25  David Levin  <levin@chromium.org>
4040
4041         Reviewed by Kenneth Russell.
4042
4043         Fix strict OwnPtrs in ContextMenuController.cpp
4044         https://bugs.webkit.org/show_bug.cgi?id=59375
4045
4046         * page/ContextMenuController.cpp:
4047         (WebCore::ContextMenuController::createContextMenu):
4048         (WebCore::separatorItem):
4049
4050 2011-04-25  Adam Barth  <abarth@webkit.org>
4051
4052         Reviewed by Darin Adler.
4053
4054         CheckedRadioButton should play nice with strict OwnPtr
4055         https://bugs.webkit.org/show_bug.cgi?id=59386
4056
4057         * dom/CheckedRadioButtons.cpp:
4058         (WebCore::CheckedRadioButtons::addButton):
4059
4060 2011-04-25  Adam Barth  <abarth@webkit.org>
4061
4062         Reviewed by David Levin.
4063
4064         Resource*.cpp should play nice with strict OwnPtrs
4065         https://bugs.webkit.org/show_bug.cgi?id=59383
4066
4067         * bridge/runtime_method.cpp:
4068         (JSC::RuntimeMethod::RuntimeMethod):
4069         * platform/network/ResourceHandle.cpp:
4070         (WebCore::ResourceHandle::ResourceHandle):
4071         * platform/network/ResourceResponseBase.cpp:
4072         (WebCore::ResourceResponseBase::adopt):
4073         (WebCore::ResourceResponseBase::copyData):
4074
4075 2011-04-25  Adam Barth  <abarth@webkit.org>
4076
4077         Reviewed by David Levin.
4078
4079         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
4080         https://bugs.webkit.org/show_bug.cgi?id=59374
4081
4082         * bridge/objc/objc_runtime.mm:
4083         (JSC::Bindings::callObjCFallbackObject):
4084         * page/Page.cpp:
4085         (WebCore::Page::Page):
4086         (WebCore::Page::initGroup):
4087         * page/PageGroup.cpp:
4088         (WebCore::PageGroup::addUserScriptToWorld):
4089         (WebCore::PageGroup::addUserStyleSheetToWorld):
4090         * page/mac/PageMac.cpp:
4091         (WebCore::Page::addSchedulePair):
4092
4093 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4094
4095         Build fix: This time for sure!
4096         
4097         * dom/make_names.pl:
4098
4099 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4100
4101         Build fix: Let's edit the script instead of the autogenrated file. That
4102         way, our change will stand the test of time.
4103
4104         * dom/make_names.pl:
4105
4106 2011-04-25  Adam Barth  <abarth@webkit.org>
4107
4108         Reviewed by David Levin.
4109
4110         Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
4111         https://bugs.webkit.org/show_bug.cgi?id=59368