2011-04-29 Dean Jackson <dino@apple.com>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-29  Dean Jackson  <dino@apple.com>
2
3         Reviewed by Simon Fraser.
4
5         Add ENABLE macro for WebKitAnimation
6         https://bugs.webkit.org/show_bug.cgi?id=59729
7
8         Add new feature to toggle WebKit Animation API.
9
10         * Configurations/FeatureDefines.xcconfig:
11         * GNUmakefile.am:
12         * dom/Element.idl:
13         * features.pri:
14         * page/DOMWindow.idl:
15
16 2011-04-29  Dean Jackson  <dino@apple.com>
17
18         Reviewed by Simon Fraser.
19
20         https://bugs.webkit.org/show_bug.cgi?id=59149
21         (Regression) Existing animations are not replaced when filling.
22
23         Hardware animations that fill forwards were not being correctly
24         replaced when the animation was removed. The actual animation
25         logic was working correctly, but it wasn't deleting the
26         CoreAnimation animation from the PlatformLayer. The fix was
27         to explicitly call endAnimation when disconnecting the animation
28         from its RenderObject.
29
30         Test: animations/3d/replace-filling-transform.html
31
32         * page/animation/AnimationBase.h:
33         (WebCore::AnimationBase::clear): call endAnimation as the animation is cleared
34
35 2011-04-29  Abhishek Arya  <inferno@chromium.org>
36
37         Reviewed by Nikolas Zimmermann.
38
39         When svg inline text is getting destroyed, make sure to mark
40         its svg text ancestor as needing a positioning values update.
41         This helps to recalculate layout attributes and makes sure
42         that svg inline text is not used again.
43         https://bugs.webkit.org/show_bug.cgi?id=59161
44
45         Test: svg/text/inline-text-destroy-attributes-crash.xhtml
46
47         * rendering/svg/RenderSVGInlineText.cpp:
48         (WebCore::RenderSVGInlineText::destroy):
49         * rendering/svg/RenderSVGInlineText.h:
50
51 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
52
53         [wx] Unreviewed build fix. Fix wxMSW trunk builds by adding include.
54
55         * platform/graphics/wx/GraphicsContextWx.cpp:
56
57 2011-04-29  Mike Reed  <reed@google.com>
58
59         Reviewed by Ojan Vafai.
60
61         Skia: Need to implement GraphicsContext::clipConvexPolygon()
62         https://bugs.webkit.org/show_bug.cgi?id=41311
63
64         This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
65         as that shows other issues/question unrelated to clipping.
66         https://bugs.webkit.org/show_bug.cgi?id=41311
67
68         No new tests. covered by existing layout tests
69
70         * platform/graphics/skia/GraphicsContextSkia.cpp:
71         (WebCore::setPathFromConvexPoints):
72         (WebCore::GraphicsContext::drawConvexPolygon):
73         (WebCore::GraphicsContext::clipConvexPolygon):
74
75 2011-04-29  Mike Lawther  <mikelawther@chromium.org>
76
77         Reviewed by Ojan Vafai.
78
79         Fix IR->SR typo in enum value (and resulting style fails)
80         https://bugs.webkit.org/show_bug.cgi?id=59779
81
82         No functionality change, so no new tests
83
84         * css/CSSPrimitiveValueMappings.h:
85         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
86         (WebCore::CSSPrimitiveValue::operator EShapeRendering):
87
88 2011-04-29  Pavel Feldman  <pfeldman@google.com>
89
90         Reviewed by Yury Semikhatsky.
91
92         Web Inspector: CSS editing breaks when entering "color: rgb(1"
93         https://bugs.webkit.org/show_bug.cgi?id=59789
94
95         Tests: inspector/styles/styles-add-invalid-property.html
96                inspector/styles/styles-cancel-editing.html
97                inspector/styles/styles-commit-editing.html
98
99         * inspector/front-end/CSSStyleModel.js:
100         (WebInspector.CSSProperty.prototype.setText.callback):
101         (WebInspector.CSSProperty.prototype.setText):
102         * inspector/front-end/StylesSidebarPane.js:
103         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
104         (WebInspector.StylePropertyTreeElement.prototype):
105         (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
106         * inspector/front-end/inspector.js:
107         (WebInspector.startEditing.defaultFinishHandler):
108         (WebInspector.startEditing.keyDownEventListener):
109         (WebInspector.startEditing):
110
111 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
112
113         Reviewed by Simon Hausmann.
114
115         ENABLE(QT_BEARER) -> USE(QT_BEARER)
116
117         * WebCore.pri:
118         * WebCore.pro:
119         * features.pri:
120         * platform/network/NetworkStateNotifier.h:
121         * platform/network/qt/NetworkStateNotifierQt.cpp:
122
123 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
124
125         Reviewed by Simon Hausmann.
126
127         ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
128
129         * WebCore.pri:
130         * features.pri:
131
132 2011-04-29  Pavel Podivilov  <podivilov@chromium.org>
133
134         Reviewed by Pavel Feldman.
135
136         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
137         https://bugs.webkit.org/show_bug.cgi?id=59476
138
139         * inspector/front-end/DebuggerPresentationModel.js:
140         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
141         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
142         (WebInspector.PresentationBreakpoint.prototype.serialize):
143         * inspector/front-end/ScriptsPanel.js:
144         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
145         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
146         (WebInspector.ScriptsPanel.prototype.reset):
147
148 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
149
150         Reviewed by Yury Semikhatsky.
151
152         Web Inspector: include script end line:column in scriptParsed parameters.
153         https://bugs.webkit.org/show_bug.cgi?id=59717
154
155         * bindings/js/ScriptDebugServer.cpp:
156         (WebCore::ScriptDebugServer::dispatchDidParseSource):
157         * bindings/v8/DebuggerScript.js:
158         ():
159         * bindings/v8/ScriptDebugServer.cpp:
160         (WebCore::ScriptDebugServer::dispatchDidParseSource):
161         * inspector/Inspector.json:
162         * inspector/InspectorDebuggerAgent.cpp:
163         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
164         (WebCore::InspectorDebuggerAgent::didParseSource):
165         * inspector/InspectorDebuggerAgent.h:
166         (WebCore::InspectorDebuggerAgent::Script::Script):
167         * inspector/ScriptDebugListener.h:
168         * inspector/front-end/DebuggerModel.js:
169         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
170         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
171         (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
172         * inspector/front-end/Script.js:
173         (WebInspector.Script):
174
175 2011-04-28  Yury Semikhatsky  <yurys@chromium.org>
176
177         Reviewed by Pavel Feldman.
178
179         Web Inspector: [protocol] Evaluate should expose thrown exception value
180         https://bugs.webkit.org/show_bug.cgi?id=59000
181
182         Each evaluation command may have either thrown or returned result. This is indicated
183         by wasThrown property in the protocol.
184
185         * inspector/InjectedScript.cpp:
186         (WebCore::InjectedScript::evaluate):
187         (WebCore::InjectedScript::evaluateOn):
188         (WebCore::InjectedScript::evaluateOnCallFrame):
189         (WebCore::InjectedScript::getProperties):
190         (WebCore::InjectedScript::makeEvalCall):
191         * inspector/InjectedScript.h:
192         * inspector/InjectedScriptSource.js:
193         * inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to
194         the evaluation results.
195         * inspector/InspectorDebuggerAgent.cpp:
196         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
197         * inspector/InspectorDebuggerAgent.h:
198         * inspector/InspectorRuntimeAgent.cpp:
199         (WebCore::InspectorRuntimeAgent::evaluate):
200         (WebCore::InspectorRuntimeAgent::evaluateOn):
201         (WebCore::InspectorRuntimeAgent::getProperties):
202         * inspector/InspectorRuntimeAgent.h:
203         * inspector/front-end/ConsoleView.js:
204         (WebInspector.ConsoleView.prototype.completions.evaluated):
205         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
206         (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
207         (WebInspector.ConsoleView.prototype._enterKeyPressed):
208         (WebInspector.ConsoleCommandResult):
209         * inspector/front-end/DebuggerPresentationModel.js:
210         (WebInspector.PresenationCallFrame.prototype.evaluate):
211         * inspector/front-end/ElementsTreeOutline.js:
212         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
213         * inspector/front-end/ExtensionPanel.js:
214         (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
215         * inspector/front-end/ExtensionServer.js:
216         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
217         * inspector/front-end/ObjectPropertiesSection.js:
218         (WebInspector.ObjectPropertyTreeElement.prototype.update):
219         * inspector/front-end/PropertiesSidebarPane.js:
220         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
221         * inspector/front-end/SourceFrame.js:
222         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
223         (WebInspector.SourceFrame.prototype._showPopup):
224
225 2011-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
226
227         Unreviewed, rolling out r85315.
228         http://trac.webkit.org/changeset/85315
229         https://bugs.webkit.org/show_bug.cgi?id=59792
230
231         Broke script-formatter.html test (Requested by podivilov on
232         #webkit).
233
234         * inspector/front-end/DebuggerPresentationModel.js:
235         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
236         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint):
237         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
238         (WebInspector.PresentationBreakpoint.prototype.serialize):
239         * inspector/front-end/ScriptsPanel.js:
240         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
241         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
242         (WebInspector.ScriptsPanel.prototype.reset):
243
244 2011-04-29  Vsevolod Vlasov  <vsevik@chromium.org>
245
246         Reviewed by Pavel Feldman.
247
248         Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
249         https://bugs.webkit.org/show_bug.cgi?id=58794
250
251         Added ping requests to network panel.
252
253         Test: http/tests/inspector/network/ping.html
254
255         * English.lproj/localizedStrings.js:
256         * inspector/InspectorInstrumentation.cpp:
257         (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
258         * inspector/InspectorInstrumentation.h:
259         (WebCore::InspectorInstrumentation::continueAfterPingLoader):
260         * inspector/front-end/NetworkPanel.js:
261         (WebInspector.NetworkDataGridNode.prototype.refreshResource):
262         (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
263         (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
264         * inspector/front-end/Resource.js:
265         (WebInspector.Resource.prototype.get formParameters):
266         (WebInspector.Resource.prototype.requestContentType):
267         (WebInspector.Resource.prototype.isPingRequest):
268         * loader/PingLoader.cpp:
269         (WebCore::PingLoader::PingLoader):
270         * loader/PingLoader.h:
271
272 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
273
274         Reviewed by Pavel Feldman.
275
276         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
277         https://bugs.webkit.org/show_bug.cgi?id=59476
278
279         * inspector/front-end/DebuggerPresentationModel.js:
280         (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
281         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
282         (WebInspector.PresentationBreakpoint.prototype.serialize):
283         * inspector/front-end/ScriptsPanel.js:
284         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
285         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
286         (WebInspector.ScriptsPanel.prototype.reset):
287
288 2011-04-29  Pavel Feldman  <pfeldman@google.com>
289
290         Reviewed by Yury Semikhatsky.
291
292         Web Inspector: add "open link in new tab" action into the network and resources panels.
293         https://bugs.webkit.org/show_bug.cgi?id=59788
294
295         This change also distinguishes context menu items case between platforms.
296
297         * English.lproj/localizedStrings.js:
298         * inspector/front-end/ConsoleView.js:
299         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
300         * inspector/front-end/DOMBreakpointsSidebarPane.js:
301         (WebInspector.DOMBreakpointsSidebarPane):
302         * inspector/front-end/ElementsPanel.js:
303         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
304         (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
305         * inspector/front-end/ElementsTreeOutline.js:
306         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
307         (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
308         * inspector/front-end/NetworkPanel.js:
309         (WebInspector.NetworkPanel.prototype._contextMenu):
310         * inspector/front-end/ResourcesPanel.js:
311         (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
312         (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
313         (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
314         * inspector/front-end/Settings.js:
315         * inspector/front-end/SourceFrame.js:
316         (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
317         * inspector/front-end/TextViewer.js:
318         (WebInspector.TextViewer.prototype._contextMenu):
319         * inspector/front-end/inspector.js:
320         (WebInspector.openLinkExternallyLabel):
321         (WebInspector.openResource):
322         (WebInspector.useLowerCaseMenuTitles):
323
324 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
325
326         Reviewed by Dan Bernstein.
327
328         Mask placement on composited layer is incorrect sometimes
329         https://bugs.webkit.org/show_bug.cgi?id=59775
330         
331         The mask layer always has the same size as its owning GraphicsLayer,
332         so it needs to share the same offsetFromRenderer as well. This fixes
333         the offset at which the mask layer contents are painted in cases where
334         that offset is non-zero, for example when outline style bloats all of
335         the layer sizes.
336
337         Test: compositing/masks/layer-mask-placement.html
338
339         * rendering/RenderLayerBacking.cpp:
340         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
341
342 2011-04-28  Dan Bernstein  <mitz@apple.com>
343
344         Rubber-stamped by Mark Rowe.
345
346         Reverted r81319.
347
348         Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu
349
350         * page/NavigatorBase.cpp:
351
352 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
353
354         Reviewed by Dirk Schulze.
355
356         1px box-shadow looks ugly
357         https://bugs.webkit.org/show_bug.cgi?id=58100
358         and
359         ShadowBlur incorrectly handles zero-sized blur radius in one axis
360         https://bugs.webkit.org/show_bug.cgi?id=59710
361         
362         blurLayerImage() has issues at the edges if the blur radius
363         is one, so in that case bump the buffer size out by a pixel.
364         This results in a correct, symmetrical blur.
365         
366         Also fix an issue noticed during testing where a zero
367         height or width radius would still blur on that axis,
368         because we clamp the kernel size to a minimum of two.
369
370         Test: fast/box-shadow/single-pixel-shadow.html
371
372         * platform/graphics/ShadowBlur.h:
373         * platform/graphics/ShadowBlur.cpp:
374         (WebCore::ShadowBlur::blurLayerImage):
375         Skip horizontal or vertial passes if the radius on that axis is zero.
376         Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
377         clause to the end of the loop, since it only needs to execute once
378         after the first pass.        
379         (WebCore::ShadowBlur::blurredEdgeSize):
380         New method to compute the width of the blurred edge (radius + extra
381         pixel when necessary).
382         (WebCore::ShadowBlur::calculateLayerBoundingRect):
383         (WebCore::ShadowBlur::templateSize):
384         (WebCore::ShadowBlur::drawRectShadow):
385         (WebCore::ShadowBlur::drawInsetShadow):
386         (WebCore::ShadowBlur::drawInsetShadowWithTiling):
387         (WebCore::ShadowBlur::drawRectShadowWithTiling):
388         (WebCore::ShadowBlur::drawLayerPieces):
389         Use the result of blurredEdgeSize() rather than recomputing.
390
391 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
392
393         Reviewed by Beth Dakin.
394
395         CSS sibling selector (~) does not work with :target pseudo class
396         https://bugs.webkit.org/show_bug.cgi?id=26539
397
398         Allow style recalculation of forward siblings of elements with
399         forward positional rules.
400
401         Tests: fast/css/pseudo-target-indirect-sibling-001.html
402                fast/css/pseudo-target-indirect-sibling-002.html
403
404         * dom/Element.cpp:
405         (WebCore::Element::recalcStyle):
406
407 2011-04-28  Nat Duca  <nduca@chromium.org>
408
409         Reviewed by Kenneth Russell.
410
411         [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
412         https://bugs.webkit.org/show_bug.cgi?id=59626
413
414         * platform/graphics/chromium/Extensions3DChromium.h:
415         (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
416
417 2011-04-28  Steve Lacey  <sjl@chromium.org>
418
419         Reviewed by Eric Carlson.
420
421         Change chromium media controls to use absolute positioning until bug 59644 is fixed.
422         https://bugs.webkit.org/show_bug.cgi?id=59732
423
424         * css/mediaControlsChromium.css:
425         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
426         (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
427
428 2011-04-28  Luke Macpherson   <macpherson@chromium.org>
429
430         Reviewed by Eric Seidel.
431
432         Implement CSS border width and related properties in CSSStyleApplyProperty.
433         https://bugs.webkit.org/show_bug.cgi?id=59414
434
435         No new tests as no functionality added.
436
437         * css/CSSStyleApplyProperty.cpp:
438         Separated ApplyPropertyDefault into parent and child so that other classes could inherit
439         the applyInheritValue and applyInitialValue methods only.
440         This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().
441         
442         Added ApplyPropertyWidth class for handling width based CSS properties.
443         * css/CSSStyleSelector.cpp:
444         Removed no-longer-required code for handling width based CSS properties.
445         * css/CSSStyleSelector.h:
446         Added a getter for m_rootElementStyle.
447
448 2011-04-28  Kent Tamura  <tkent@chromium.org>
449
450         Run sort-Xcode-project-file.
451
452         * WebCore.xcodeproj/project.pbxproj:
453
454 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
455
456         Reviewed by Dirk Schulze.
457
458         [Cairo] Text underline is not shadowed when text-shadow is enabled
459         https://bugs.webkit.org/show_bug.cgi?id=48074
460
461         Use ContextShadow to enable shadows for text underlines. Also remove quite a bit
462         of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
463         originally copied from the CG GraphicsContext.
464
465         * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
466           can call it from a static helper function.
467         * platform/graphics/cairo/GraphicsContextCairo.cpp:
468         (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
469         (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
470         call it multiple times when shadowing text underlines.
471         (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
472         (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
473         (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
474
475 2011-04-28  Sam Weinig  <sam@webkit.org>
476
477         Rubber-stamped by Mark Rowe.
478
479         Cleanup WebCore.xcodeproj a bit.
480
481         * WebCore.xcodeproj/project.pbxproj:
482         Added CompilerVersion.xcconfig and moved some JS bindings files into the
483         correct sub groups.
484
485 2011-04-28  David Levin  <levin@chromium.org>
486
487         Reviewed by Adam Barth.
488
489         Remove IMAGE_RESIZER related code.
490         https://bugs.webkit.org/show_bug.cgi?id=59735
491
492         * CMakeLists.txt:
493         * Configurations/FeatureDefines.xcconfig:
494         * GNUmakefile.am:
495         * GNUmakefile.list.am:
496         * WebCore.gypi:
497         * WebCore.pro:
498         * WebCore.vcproj/WebCore.vcproj:
499         * WebCore.xcodeproj/project.pbxproj:
500         * features.pri:
501         * html/AsyncImageResizer.cpp: Removed.
502         * html/AsyncImageResizer.h: Removed.
503         * html/ImageResizerThread.cpp: Removed.
504         * html/ImageResizerThread.h: Removed.
505
506 2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
507
508         Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
509
510         * inspector/front-end/Settings.js:
511         (WebInspector.Settings):
512
513 2011-04-28  Beth Dakin  <bdakin@apple.com>
514
515         Rubber-stamped by Sam Weinig.
516
517         Rolling out revision 85258! I want to fix that bug a different way.
518         * platform/mac/ScrollbarThemeMac.mm:
519         (WebCore::ScrollbarThemeMac::paint):
520
521 2011-04-28  Chang Shu  <cshu@webkit.org>
522
523         Reviewed by Eric Seidel.
524
525         isContentEditable is not working properly with document.designMode
526         https://bugs.webkit.org/show_bug.cgi?id=53031
527
528         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
529         indicates that the element.isContentEditable relies on document.designMode if its
530         and its ancestors' contenteditable attributes are set to inherit.
531
532         1. Sync document render style after document.designMode is changed.
533         2. Removed the code that does unnecessary and incorrect handling for contenteditable
534         attribute with "inherit" value.
535         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
536
537         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
538                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
539                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
540                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
541
542         * css/CSSStyleSelector.cpp:
543         (WebCore::CSSStyleSelector::styleForDocument):
544         * dom/Document.cpp:
545         (WebCore::Document::setDesignMode):
546         * dom/Node.cpp:
547         (WebCore::Node::rendererIsEditable):
548         * editing/ApplyStyleCommand.cpp:
549         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
550         * html/HTMLElement.cpp:
551         (WebCore::HTMLElement::setContentEditable):
552
553 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
554
555         Unreviewed, rolling out r85101.
556         http://trac.webkit.org/changeset/85101
557         https://bugs.webkit.org/show_bug.cgi?id=59757
558
559          it'd be better to rollout the patch and do another one with
560         another property name. Current one will bring us to a problem
561         at first run after upgrade because it's type was changed from
562         int to string. (Requested by loislo on #webkit).
563
564         * inspector/front-end/ScriptsPanel.js:
565         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
566         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
567         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
568
569 2011-04-28  Mike Reed  <reed@google.com>
570
571         Reviewed by Eric Seidel.
572
573         fix shadw behavior for both CSS and Canvas -- skia only
574         https://bugs.webkit.org/show_bug.cgi?id=59700
575
576         Test:
577         canvas/philip/tests/2d.shadow.alpha.3.html
578         canvas/philip/tests/2d.shadow.alpha.4.html
579         canvas/philip/tests/2d.shadow.alpha.5.html
580         fast/canvas/canvas-fillPath-alpha-shadow.html
581         fast/canvas/canvas-strokePath-alpha-shadow.html
582         fast/canvas/canvas-strokeRect-alpha-shadow.html
583         fast/css/text-input-with-webkit-border-radius.html
584         fast/repaint/shadow-multiple-horizontal.html
585         fast/repaint/shadow-multiple-strict-horizontal.html
586         fast/repaint/shadow-multiple-strict-vertical.html
587         fast/repaint/shadow-multiple-vertical.html
588         fast/canvas/canvas-getImageData.html
589
590         * platform/graphics/chromium/FontChromiumWin.cpp:
591         (WebCore::Font::drawGlyphs):
592         * platform/graphics/skia/GraphicsContextSkia.cpp:
593         (WebCore::GraphicsContext::setPlatformShadow):
594
595 2011-04-28  David Kilzer  <ddkilzer@apple.com>
596
597         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
598
599         Reviewed by Chris Fleizach.
600
601         Previously, AXObjectCache::attachWrapper over-retained each
602         AccessibilityObjectWrapper it created, which is why
603         AXObjectCache::detachWrapper() contained an extra -release.
604
605         * accessibility/mac/AXObjectCacheMac.mm:
606         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
607         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
608         assigns to a RetainPtr<> instance variable, it doesn't need a +1
609         retained object passed in.  Fix the leak by using a RetainPtr<>
610         for the AccessibilityObjectWrapper.
611
612 2011-04-28  Nat Duca  <nduca@chromium.org>
613
614         Reviewed by Darin Fisher.
615
616         [chromium] Compute compositor fps value and history using the frameBegin timestamp
617         https://bugs.webkit.org/show_bug.cgi?id=59668
618
619         This change switches the compositor FPS meter to use the timestamp
620         of the beginning of the frame rather than the time we call
621         swapBuffers. When scheduling is correctly tied to vsync, we can
622         have highly variable times when we finish vsync and still have
623         stable frame rates.
624
625         * platform/graphics/chromium/LayerRendererChromium.cpp:
626         (WebCore::LayerRendererChromium::updateAndDrawLayers):
627         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
628         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
629         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
630         (WebCore::CCHeadsUpDisplay::onFrameBegin):
631         (WebCore::CCHeadsUpDisplay::onPresent):
632         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
633
634 2011-04-28  Beth Dakin  <bdakin@apple.com>
635
636         Reviewed by Darin Adler.
637
638         https://bugs.webkit.org/show_bug.cgi?id=59759
639         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
640         track when there is nothing to scroll to
641         <rdar://problem/9282066>
642
643         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
644         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
645         is not right. Set the proportion to 0 in this case instead.
646         * platform/mac/ScrollbarThemeMac.mm:
647         (WebCore::ScrollbarThemeMac::paint):
648
649 2011-04-28  Dan Bernstein  <mitz@apple.com>
650
651         Reviewed by Simon Fraser.
652
653         <rdar://problem/9291132> Add support for -epub-prefixed properties
654
655         Test: fast/css/epub-properties.html
656
657         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
658         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
659         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
660         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
661         text-transform, text-transform, word-break, and -webkit-writing-mode.
662
663 2011-04-28  Adam Barth  <abarth@webkit.org>
664
665         Reviewed by Eric Seidel.
666
667         Remove WML
668         https://bugs.webkit.org/show_bug.cgi?id=59678
669
670         This patch removes WML from WebCore.  After removing WML, there's a
671         bunch of twisted code that could be untwisted, but this patch contains
672         only the purely mechanical part of removing the feature.
673
674         There's been a lot of discussion on webkit-dev about whether we should
675         remove WML.  In addition to those threads, we've had an informal poll
676         of the reviewers as well as an in-person discussion at the WebKit
677         contributor's meeting.  Removing any feature is likely to make some
678         folks unhappy, but, on balance, removing WML appears to be the right
679         thing for the project to do at this time.
680
681         * CMakeLists.txt:
682         * CodeGenerators.pri:
683         * Configurations/FeatureDefines.xcconfig:
684         * DerivedSources.cpp:
685         * DerivedSources.make:
686         * GNUmakefile.am:
687         * GNUmakefile.list.am:
688         * WebCore.gyp/WebCore.gyp:
689         * WebCore.gypi:
690         * WebCore.pro:
691         * WebCore.vcproj/WebCore.vcproj:
692         * WebCore.xcodeproj/project.pbxproj:
693         * css/CSSStyleSelector.cpp:
694         (WebCore::linkAttribute):
695         (WebCore::CSSStyleSelector::styleForElement):
696         (WebCore::CSSStyleSelector::adjustRenderStyle):
697         * css/wml.css: Removed.
698         * dom/DOMImplementation.cpp:
699         (WebCore::DOMImplementation::createDocument):
700         * dom/Document.cpp:
701         (WebCore::Document::Document):
702         (WebCore::Document::createElement):
703         * dom/Document.h:
704         (WebCore::Document::isMediaDocument):
705         * dom/Document.idl:
706         * dom/InputElement.h:
707         * dom/Node.cpp:
708         (WebCore::Node::toInputElement):
709         * dom/Node.h:
710         * dom/OptionElement.cpp:
711         (WebCore::toOptionElement):
712         (WebCore::isOptionElement):
713         * dom/OptionElement.h:
714         * dom/OptionGroupElement.cpp:
715         (WebCore::toOptionGroupElement):
716         (WebCore::isOptionGroupElement):
717         * dom/SelectElement.cpp:
718         (WebCore::toSelectElement):
719         * dom/SelectElement.h:
720         * dom/Text.cpp:
721         (WebCore::Text::attach):
722         * dom/XMLDocumentParser.cpp:
723         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
724         * dom/XMLDocumentParser.h:
725         * dom/XMLDocumentParserLibxml2.cpp:
726         (WebCore::XMLDocumentParser::internalSubset):
727         (WebCore::getEntityHandler):
728         * dom/XMLDocumentParserQt.cpp:
729         (WebCore::XMLDocumentParser::parse):
730         (WebCore::XMLDocumentParser::parseDtd):
731         * editing/htmlediting.cpp:
732         (WebCore::canHaveChildrenForEditing):
733         * features.pri:
734         * history/BackForwardList.h:
735         * history/BackForwardListImpl.cpp:
736         * history/BackForwardListImpl.h:
737         * history/PageCache.cpp:
738         (WebCore::PageCache::canCachePageContainingThisFrame):
739         * html/HTMLAnchorElement.h:
740         * inspector/ConsoleMessage.cpp:
741         (WebCore::messageSourceValue):
742         * inspector/front-end/ConsoleView.js:
743         (WebInspector.ConsoleMessage.prototype.toString):
744         * loader/FrameLoader.cpp:
745         (WebCore::isBackForwardLoadType):
746         (WebCore::FrameLoader::transitionToCommitted):
747         (WebCore::FrameLoader::shouldReload):
748         (WebCore::FrameLoader::loadDifferentDocumentItem):
749         (WebCore::FrameLoader::loadItem):
750         * loader/FrameLoaderTypes.h:
751         * loader/HistoryController.cpp:
752         (WebCore::HistoryController::restoreDocumentState):
753         * manual-tests/wml: Removed.
754         * manual-tests/wml/StartTests.wml: Removed.
755         * manual-tests/wml/a-br-element.wml: Removed.
756         * manual-tests/wml/a-element.wml: Removed.
757         * manual-tests/wml/a-img-element.wml: Removed.
758         * manual-tests/wml/access-target.wml: Removed.
759         * manual-tests/wml/anchor-br-element.wml: Removed.
760         * manual-tests/wml/anchor-element.wml: Removed.
761         * manual-tests/wml/anchor-img-element.wml: Removed.
762         * manual-tests/wml/card-newcontext-attr.wml: Removed.
763         * manual-tests/wml/card-onenterbackward.wml: Removed.
764         * manual-tests/wml/card-onenterforward.wml: Removed.
765         * manual-tests/wml/card-ontimer.wml: Removed.
766         * manual-tests/wml/deck-access-control.wml: Removed.
767         * manual-tests/wml/input-format.wml: Removed.
768         * manual-tests/wml/onevent-go.wml: Removed.
769         * manual-tests/wml/onevent-noop.wml: Removed.
770         * manual-tests/wml/onevent-prev.wml: Removed.
771         * manual-tests/wml/onevent-refresh.wml: Removed.
772         * manual-tests/wml/onevent-shadow.wml: Removed.
773         * manual-tests/wml/resources: Removed.
774         * manual-tests/wml/resources/smiley.png: Removed.
775         * manual-tests/wml/select-element.wml: Removed.
776         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
777         * manual-tests/wml/select-onpick-event.wml: Removed.
778         * manual-tests/wml/setvar-element.wml: Removed.
779         * manual-tests/wml/targetdeck.wml: Removed.
780         * manual-tests/wml/task-go-in-anchor.wml: Removed.
781         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
782         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
783         * manual-tests/wml/template-go.wml: Removed.
784         * manual-tests/wml/template-ontimer.wml: Removed.
785         * manual-tests/wml/timer.wml: Removed.
786         * manual-tests/wml/variable-substitution.wml: Removed.
787         * page/Console.cpp:
788         (WebCore::printMessageSourceAndLevelPrefix):
789         * page/Console.h:
790         * page/Frame.cpp:
791         (WebCore::Frame::Frame):
792         * page/Page.cpp:
793         * page/Page.h:
794         * platform/MIMETypeRegistry.cpp:
795         (WebCore::initializeSupportedNonImageMimeTypes):
796         * platform/network/FormDataBuilder.h:
797         * platform/network/mac/ResourceHandleMac.mm:
798         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
799         * platform/wince/MIMETypeRegistryWinCE.cpp:
800         (WebCore::initMIMETypeEntensionMap):
801         * rendering/HitTestResult.cpp:
802         (WebCore::HitTestResult::altDisplayString):
803         (WebCore::HitTestResult::absoluteImageURL):
804         (WebCore::HitTestResult::absoluteLinkURL):
805         (WebCore::HitTestResult::isLiveLink):
806         * rendering/RenderBox.cpp:
807         * rendering/RenderButton.cpp:
808         (WebCore::RenderButton::updateFromElement):
809         * rendering/RenderFieldset.cpp:
810         (WebCore::RenderFieldset::findLegend):
811         * rendering/RenderImage.cpp:
812         (WebCore::RenderImage::updateAltText):
813         * rendering/RenderObject.cpp:
814         (WebCore::RenderObject::isLegend):
815         (WebCore::RenderObject::offsetParent):
816         * wml: Removed.
817         * wml/WMLAElement.cpp: Removed.
818         * wml/WMLAElement.h: Removed.
819         * wml/WMLAccessElement.cpp: Removed.
820         * wml/WMLAccessElement.h: Removed.
821         * wml/WMLAnchorElement.cpp: Removed.
822         * wml/WMLAnchorElement.h: Removed.
823         * wml/WMLAttributeNames.in: Removed.
824         * wml/WMLBRElement.cpp: Removed.
825         * wml/WMLBRElement.h: Removed.
826         * wml/WMLCardElement.cpp: Removed.
827         * wml/WMLCardElement.h: Removed.
828         * wml/WMLDoElement.cpp: Removed.
829         * wml/WMLDoElement.h: Removed.
830         * wml/WMLDocument.cpp: Removed.
831         * wml/WMLDocument.h: Removed.
832         * wml/WMLElement.cpp: Removed.
833         * wml/WMLElement.h: Removed.
834         * wml/WMLErrorHandling.cpp: Removed.
835         * wml/WMLErrorHandling.h: Removed.
836         * wml/WMLEventHandlingElement.cpp: Removed.
837         * wml/WMLEventHandlingElement.h: Removed.
838         * wml/WMLFieldSetElement.cpp: Removed.
839         * wml/WMLFieldSetElement.h: Removed.
840         * wml/WMLFormControlElement.cpp: Removed.
841         * wml/WMLFormControlElement.h: Removed.
842         * wml/WMLGoElement.cpp: Removed.
843         * wml/WMLGoElement.h: Removed.
844         * wml/WMLImageElement.cpp: Removed.
845         * wml/WMLImageElement.h: Removed.
846         * wml/WMLImageLoader.cpp: Removed.
847         * wml/WMLImageLoader.h: Removed.
848         * wml/WMLInputElement.cpp: Removed.
849         * wml/WMLInputElement.h: Removed.
850         * wml/WMLInsertedLegendElement.cpp: Removed.
851         * wml/WMLInsertedLegendElement.h: Removed.
852         * wml/WMLIntrinsicEvent.cpp: Removed.
853         * wml/WMLIntrinsicEvent.h: Removed.
854         * wml/WMLIntrinsicEventHandler.cpp: Removed.
855         * wml/WMLIntrinsicEventHandler.h: Removed.
856         * wml/WMLMetaElement.cpp: Removed.
857         * wml/WMLMetaElement.h: Removed.
858         * wml/WMLNoopElement.cpp: Removed.
859         * wml/WMLNoopElement.h: Removed.
860         * wml/WMLOnEventElement.cpp: Removed.
861         * wml/WMLOnEventElement.h: Removed.
862         * wml/WMLOptGroupElement.cpp: Removed.
863         * wml/WMLOptGroupElement.h: Removed.
864         * wml/WMLOptionElement.cpp: Removed.
865         * wml/WMLOptionElement.h: Removed.
866         * wml/WMLPElement.cpp: Removed.
867         * wml/WMLPElement.h: Removed.
868         * wml/WMLPageState.cpp: Removed.
869         * wml/WMLPageState.h: Removed.
870         * wml/WMLPostfieldElement.cpp: Removed.
871         * wml/WMLPostfieldElement.h: Removed.
872         * wml/WMLPrevElement.cpp: Removed.
873         * wml/WMLPrevElement.h: Removed.
874         * wml/WMLRefreshElement.cpp: Removed.
875         * wml/WMLRefreshElement.h: Removed.
876         * wml/WMLSelectElement.cpp: Removed.
877         * wml/WMLSelectElement.h: Removed.
878         * wml/WMLSetvarElement.cpp: Removed.
879         * wml/WMLSetvarElement.h: Removed.
880         * wml/WMLTableElement.cpp: Removed.
881         * wml/WMLTableElement.h: Removed.
882         * wml/WMLTagNames.in: Removed.
883         * wml/WMLTaskElement.cpp: Removed.
884         * wml/WMLTaskElement.h: Removed.
885         * wml/WMLTemplateElement.cpp: Removed.
886         * wml/WMLTemplateElement.h: Removed.
887         * wml/WMLTimerElement.cpp: Removed.
888         * wml/WMLTimerElement.h: Removed.
889         * wml/WMLVariables.cpp: Removed.
890         * wml/WMLVariables.h: Removed.
891
892 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
893
894         Unreviewed, rolling out r85233 and r85235.
895         http://trac.webkit.org/changeset/85233
896         http://trac.webkit.org/changeset/85235
897         https://bugs.webkit.org/show_bug.cgi?id=59754
898
899         Causes issues with jsc. (Requested by dave_levin on #webkit).
900
901         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
902         * loader/icon/IconDatabase.cpp:
903         (WebCore::IconDatabase::defaultIcon):
904         (WebCore::IconDatabase::setIconDataForIconURL):
905         (WebCore::IconDatabase::getOrCreateIconRecord):
906         (WebCore::IconDatabase::readFromDatabase):
907
908 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
909
910         Reviewed by Adam Barth.
911
912         Introducing a new class that allows serialization of a page back
913         to HTML/XML with all its sub-frames and also retrieves the page's
914         resources.
915         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
916         https://bugs.webkit.org/show_bug.cgi?id=58947
917
918         * Android.mk:
919         * CMakeLists.txt:
920         * GNUmakefile.list.am:
921         * WebCore.gypi:
922         * WebCore.pro:
923         * WebCore.vcproj/WebCore.vcproj:
924         * dom/Document.cpp:
925         (WebCore::Document::suggestedMIMEType):
926         * dom/Document.h:
927         * editing/MarkupAccumulator.cpp:
928         (WebCore::MarkupAccumulator::appendCustomAttributes):
929         (WebCore::MarkupAccumulator::appendElement):
930         * editing/MarkupAccumulator.h:
931         * html/parser/HTMLMetaCharsetParser.cpp:
932         (WebCore::HTMLMetaCharsetParser::processMeta):
933         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
934         * html/parser/HTMLMetaCharsetParser.h:
935         * page/PageSerializer.cpp: Added.
936         * page/PageSerializer.h: Added.
937
938 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
939
940         Reviewed by Tony Chang.
941
942         IndexedDB createIndex should fail if name arg is null
943         https://bugs.webkit.org/show_bug.cgi?id=58365
944
945         Test: storage/indexeddb/mozilla/create-index-null-name.html
946
947         * storage/IDBObjectStore.idl:
948         * storage/IDBObjectStoreBackendImpl.cpp:
949         (WebCore::IDBObjectStoreBackendImpl::createIndex):
950
951 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
952
953         Reviewed by Tony Chang.
954
955         IndexedDB put() should fail if second (key) parameter is null
956         https://bugs.webkit.org/show_bug.cgi?id=58613
957
958         If key arg is not specified, prpKey ends up as a null pointer in ::put().
959         However, if the key arg is specified but is null, prpKey ends up as a
960         valid IDBKey which has a null key type. As it happens, we need to be able
961         to detect the difference between these cases (the key arg is optional but
962         if specified must not be null).
963
964         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
965
966         * storage/IDBObjectStoreBackendImpl.cpp:
967         (WebCore::IDBObjectStoreBackendImpl::put):
968
969 2011-04-07  David Levin  <levin@chromium.org>
970
971         Reviewed by Darin Adler.
972
973         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
974         https://bugs.webkit.org/show_bug.cgi?id=31639
975
976         No new functionality exposed so no new tests. (The change is basically adding
977         more testing.)
978
979         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
980         * loader/icon/IconDatabase.cpp:
981         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
982         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
983         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
984         (WebCore::IconDatabase::readFromDatabase): Ditto.
985
986 2011-04-28  Kenneth Russell  <kbr@google.com>
987
988         Unreviewed build fix for Web Audio with strict OwnPtr.
989
990         * platform/audio/HRTFDatabaseLoader.cpp:
991         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
992
993 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
994
995         Reviewed by Geoffrey Garen.
996
997         Walk shadow hosts as well as parent nodes when finding opaque roots.
998         https://bugs.webkit.org/show_bug.cgi?id=59571
999
1000         Test: fast/dom/shadow/gc-shadow.html
1001
1002         * bindings/js/JSDOMBinding.h:
1003         (WebCore::root):
1004
1005 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
1006
1007         Reviewed by Xan Lopez.
1008
1009         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
1010         https://bugs.webkit.org/show_bug.cgi?id=59715
1011
1012         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
1013         into WebCore so that WebKit1 and WebKit2 can share the code.
1014
1015         No new tests. This is covered by fast/events/click-count.html.
1016
1017         * GNUmakefile.list.am: Added new files.
1018         * platform/gtk/GtkClickCounter.cpp: Added.
1019         (WebCore::GtkClickCounter::GtkClickCounter): Added.
1020         (WebCore::GtkClickCounter::reset): Added.
1021         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
1022         (WebCore::getEventTime): Added.
1023         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
1024         * platform/gtk/GtkClickCounter.h: Added.
1025
1026 2011-04-28  Dan Bernstein  <mitz@apple.com>
1027
1028         Build fix.
1029
1030         * css/CSSParser.cpp:
1031         (WebCore::cssPropertyID):
1032
1033 2011-04-28  Dan Bernstein  <mitz@apple.com>
1034
1035         Reviewed by Simon Fraser.
1036
1037         Allow specifying CSS property aliases in CSSPropertyNames.in files
1038         https://bugs.webkit.org/show_bug.cgi?id=59712
1039
1040         * css/CSSParser.cpp:
1041         (WebCore::cssPropertyID): Removed code to handle some aliases
1042         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
1043         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
1044         defining an alias, and add an appropriate entry to the gperf file.
1045
1046 2011-04-28  Arno Renevier  <arno@renevier.net>
1047
1048         Reviewed by Gustavo Noronha Silva.
1049
1050         [Soup] does not load css stylesheets without content-type
1051         https://bugs.webkit.org/show_bug.cgi?id=59697
1052
1053         When sniffing content type, do not replace http Content-Type header in
1054         soup message anymore, but keep sniffed content type in a separate
1055         variable.
1056
1057         * platform/network/soup/ResourceHandleSoup.cpp:
1058         (WebCore::contentSniffedCallback):
1059         * platform/network/soup/ResourceResponse.h:
1060         (WebCore::ResourceResponse::sniffedContentType):
1061         (WebCore::ResourceResponse::setSniffedContentType):
1062         * platform/network/soup/ResourceResponseSoup.cpp:
1063         (WebCore::ResourceResponse::updateFromSoupMessage):
1064
1065 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
1066
1067         Reviewed by Andreas Kling.
1068
1069         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
1070         https://bugs.webkit.org/show_bug.cgi?id=59704
1071
1072         No new tests, just code cleanup.
1073
1074         * WebCore.pri:
1075
1076 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
1077
1078         Reviewed by Pavel Feldman.
1079
1080         Web Inspector: remove "Pretty print" source frame context menu item.
1081         https://bugs.webkit.org/show_bug.cgi?id=59709
1082
1083         * inspector/front-end/DebuggerPresentationModel.js:
1084         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
1085         * inspector/front-end/ScriptsPanel.js:
1086         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1087         * inspector/front-end/SourceFrame.js:
1088         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
1089
1090 2011-04-28  Satish Sampath  <satish@chromium.org>
1091
1092         Reviewed by Tony Gentilcore.
1093
1094         Speech input button layout issues with padding and border.
1095         https://bugs.webkit.org/show_bug.cgi?id=59613
1096
1097         * rendering/RenderTextControlSingleLine.cpp:
1098         (WebCore::RenderTextControlSingleLine::layout):
1099         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1100         (WebCore::RenderTextControlSingleLine::forwardEvent):
1101
1102 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1103
1104         Reviewed by Martin Robinson.
1105
1106         [GTK] Check whether to use native scrollbars at run time
1107         https://bugs.webkit.org/show_bug.cgi?id=59694
1108
1109         It's currently decided at build time depending on whether webkit2
1110         build is enabled or not. That makes imposible to build both
1111         webkit1 and webkit2 using the same libWebCore.
1112
1113         * GNUmakefile.am:
1114         * platform/ScrollView.cpp:
1115         (WebCore::ScrollView::wheelEvent):
1116         * platform/gtk/ScrollViewGtk.cpp:
1117         (WebCore::ScrollView::createScrollbar):
1118
1119 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1120
1121         Reviewed by Yury Semikhatsky.
1122
1123         Web Inspector: add status bar button for pretty print.
1124         https://bugs.webkit.org/show_bug.cgi?id=59467
1125
1126         * WebCore.gypi:
1127         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
1128         * inspector/front-end/ScriptsPanel.js:
1129         (WebInspector.ScriptsPanel):
1130         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
1131         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1132         * inspector/front-end/WebKit.qrc:
1133         * inspector/front-end/inspector.css:
1134         (.scripts-toggle-pretty-print-status-bar-item .glyph):
1135         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
1136
1137 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1138
1139         Reviewed by Yury Semikhatsky.
1140
1141         Web Inspector: add ResourceTreeModel tests.
1142         https://bugs.webkit.org/show_bug.cgi?id=59616
1143
1144         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
1145                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
1146                http/tests/inspector/resource-tree/resource-tree-reload.html
1147
1148         * inspector/front-end/ResourceTreeModel.js:
1149         (WebInspector.ResourceTreeModel.prototype.frontendReused):
1150         (WebInspector.ResourceTreeModel.prototype._addFrame):
1151         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1152         (WebInspector.ResourceTreeModel.prototype._frameDetached):
1153         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
1154         (WebInspector.ResourceTreeModel.prototype.forAllResources):
1155         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
1156         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
1157         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
1158         * inspector/front-end/ResourcesPanel.js:
1159         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1160         (WebInspector.ResourcesPanel.prototype._frameAdded):
1161         (WebInspector.ResourcesPanel.prototype._frameDetached):
1162         (WebInspector.ResourcesPanel.prototype._frameNavigated):
1163         (WebInspector.FrameTreeElement):
1164         (WebInspector.FrameTreeElement.prototype.frameNavigated):
1165
1166 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1167
1168         Reviewed by Yury Semikhatsky.
1169
1170         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
1171         https://bugs.webkit.org/show_bug.cgi?id=59592
1172
1173         * inspector/front-end/DetailedHeapshotGridNodes.js:
1174         (WebInspector.HeapSnapshotGridNode.prototype._populate):
1175         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
1176         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
1177         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
1178         * inspector/front-end/DetailedHeapshotView.js:
1179         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
1180         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
1181         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
1182         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
1183         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
1184         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
1185         (WebInspector.DetailedHeapshotView.prototype.changeView):
1186         * inspector/front-end/HeapSnapshot.js:
1187         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
1188         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
1189         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
1190         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
1191         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
1192         * inspector/front-end/heapProfiler.css:
1193         (div.retaining-paths-view td.path-column div:hover):
1194
1195 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1196
1197         Reviewed by Yury Semikhatsky.
1198
1199         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
1200         https://bugs.webkit.org/show_bug.cgi?id=59454
1201
1202         Test: inspector/profiler/heap-snapshot-loader.html
1203
1204         * inspector/front-end/HeapSnapshot.js:
1205         (WebInspector.HeapSnapshotLoader):
1206         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
1207         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
1208         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
1209         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
1210         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
1211         * inspector/front-end/HeapSnapshotProxy.js:
1212         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
1213
1214 2011-04-28  ojab  <ojab@ojab.ru>
1215
1216         Reviewed by David Levin.
1217
1218         Fix build with libpng-1.5.1
1219         https://bugs.webkit.org/show_bug.cgi?id=59607
1220
1221         * platform/image-decoders/png/PNGImageDecoder.cpp:
1222         (WebCore::readColorProfile):
1223
1224 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
1225
1226         Reviewed by Nikolas Zimmermann.
1227
1228         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
1229         https://bugs.webkit.org/show_bug.cgi?id=59447
1230
1231         This patch contains two sub-routines, one for speeding up
1232         alpha channel only gaussian blur (by 2.5 times) and one
1233         for speeding up all channel blur (by 4 times).
1234
1235         The common code is also redesigned to better fit for platform
1236         specific code. This means large chunks of code was moved to
1237         different files, and all platform specific files are added to
1238         all build systems.
1239
1240         * CMakeLists.txt:
1241         * GNUmakefile.am:
1242         * GNUmakefile.list.am:
1243         * WebCore.gypi:
1244         * WebCore.pro:
1245         * WebCore.vcproj/WebCore.vcproj:
1246         * WebCore.vcproj/WebCoreCommon.vsprops:
1247         * WebCore.xcodeproj/project.pbxproj:
1248         * platform/graphics/filters/FEGaussianBlur.cpp:
1249         (WebCore::FEGaussianBlur::platformApplyGeneric):
1250         (WebCore::FEGaussianBlur::apply):
1251         * platform/graphics/filters/FEGaussianBlur.h:
1252         (WebCore::FEGaussianBlur::kernelPosition):
1253         (WebCore::FEGaussianBlur::platformApply):
1254         * platform/graphics/filters/FELighting.cpp:
1255         (WebCore::FELighting::platformApplyGeneric):
1256         (WebCore::FELighting::drawLighting):
1257         * platform/graphics/filters/FELighting.h:
1258         (WebCore::FELighting::platformApply):
1259         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
1260         (WebCore::WTF_ALIGNED):
1261         (WebCore::feGaussianBlurConstantsForNeon):
1262         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
1263         (WebCore::FEGaussianBlur::platformApplyNeon):
1264         * platform/graphics/filters/arm/FELightingNEON.cpp:
1265         (WebCore::WTF_ALIGNED):
1266         (WebCore::FELighting::getPowerCoefficients):
1267         * platform/graphics/filters/arm/FELightingNEON.h:
1268         (WebCore::FELighting::platformApplyNeon):
1269
1270 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
1271
1272         Reviewed by Yury Semikhatsky.
1273
1274         Web Inspector: provide a hotkey for script pause
1275         https://bugs.webkit.org/show_bug.cgi?id=59593
1276
1277         In fact, F8 works as a hotkey, but this fact was not reflected
1278         in the shortcut help popup.
1279
1280         * English.lproj/localizedStrings.js:
1281         * inspector/front-end/ScriptsPanel.js:
1282         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
1283
1284 2011-04-28  Adam Barth  <abarth@webkit.org>
1285
1286         Reviewed by Eric Seidel.
1287
1288         PluginStream should play nice with strict OwnPtr
1289         https://bugs.webkit.org/show_bug.cgi?id=59675
1290
1291         These failures appear when enabling strict OwnPtr on Qt.
1292
1293         * plugins/PluginStream.cpp:
1294         (WebCore::PluginStream::PluginStream):
1295         (WebCore::PluginStream::didReceiveData):
1296
1297 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
1298
1299         Reviewed by Pavel Feldman.
1300
1301         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
1302         https://bugs.webkit.org/show_bug.cgi?id=59326
1303
1304         Concrete CachedResource successors for stylesheets and scripts
1305         can decode their content better than the generic approach we use.
1306
1307         * inspector/InspectorPageAgent.cpp:
1308         (WebCore::decodeSharedBuffer):
1309         (WebCore::prepareCachedResourceBuffer):
1310         (WebCore::cachedResourceDecoded):
1311         (WebCore::InspectorPageAgent::resourceContent):
1312         (WebCore::InspectorPageAgent::resourceData):
1313         * inspector/InspectorStyleSheet.cpp:
1314         (WebCore::InspectorStyleSheet::originalStyleSheetText):
1315
1316 2011-04-28  Jon Lee  <jonlee@apple.com>
1317
1318         Reviewed by Simon Fraser.
1319
1320         REGRESSION: white overlay scrollbars on apple.com/startpage
1321         https://bugs.webkit.org/show_bug.cgi?id=59540
1322         <rdar://problem/9338653>
1323
1324         Now we look at the document background in addition to the <body> element,
1325         and blend those colors in with the base background of the frame view to
1326         arrive at our aggregate color. This provides a better result to determine
1327         overlay scrollbar style.
1328
1329         * page/Frame.cpp:
1330         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
1331         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
1332
1333 2011-04-27  Adam Barth  <abarth@webkit.org>
1334
1335         Reviewed by Maciej Stachowiak.
1336
1337         Fix OwnPtr issues in IndexedDB
1338         https://bugs.webkit.org/show_bug.cgi?id=59656
1339
1340         This patch is an attempt to fix the clang build.  Clang can't seem to
1341         cope with OwnPtrs to classes declared in an anonymous namespace because
1342         OwnPtr's copy constructor isn't defined (but would need to be defined
1343         in this translation unit).
1344
1345         * platform/leveldb/LevelDBDatabase.cpp:
1346
1347 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
1348
1349         Reviewed by Antonio Gomes.
1350
1351         [EFL] Change cursor to LAZY_NATIVE_CURSOR
1352         https://bugs.webkit.org/show_bug.cgi?id=59411
1353
1354         Enable LAZY_NATIVE_CURSOR on EFL build.
1355
1356         No test added because functionality is unchanged.
1357
1358         * CMakeListsEfl.txt: Add Cursor.cpp
1359         * platform/Cursor.h:
1360         (WebCore::Cursor::Cursor):
1361         * platform/efl/CursorEfl.cpp:
1362         (WebCore::Cursor::Cursor):
1363         (WebCore::Cursor::~Cursor):
1364         (WebCore::getCursorString):
1365         (WebCore::Cursor::ensurePlatformCursor):
1366         * platform/efl/WidgetEfl.cpp:
1367         (WebCore::Widget::setCursor):
1368
1369 2011-04-27  Adam Barth  <abarth@webkit.org>
1370
1371         Build fix from the future.  Another trival strict OwnPtr fixes.  This
1372         is the last futuristic build fix I can detect with my time traveling
1373         abilities.
1374
1375         * platform/graphics/chromium/TransparencyWin.cpp:
1376         (WebCore::TransparencyWin::initializeNewContext):
1377
1378 2011-04-27  Dmitry Lomov  <dslomov@google.com>
1379
1380         Reviewed by David Levin.
1381
1382         CrossThreadCopier should not have a default specialization for raw pointers
1383         https://bugs.webkit.org/show_bug.cgi?id=59234
1384         Removed the ablity to pass raw pointers cross-thread
1385         Added and applied annotations for doing that
1386
1387         * fileapi/FileReader.cpp:
1388         (WebCore::FileReader::readInternal):
1389         (WebCore::FileReader::abort):
1390         * fileapi/FileStreamProxy.cpp:
1391         (WebCore::FileStreamProxy::startOnFileThread):
1392         (WebCore::FileStreamProxy::stopOnFileThread):
1393         (WebCore::FileStreamProxy::getSize):
1394         (WebCore::FileStreamProxy::getSizeOnFileThread):
1395         (WebCore::FileStreamProxy::openForRead):
1396         (WebCore::FileStreamProxy::openForReadOnFileThread):
1397         (WebCore::FileStreamProxy::openForWrite):
1398         (WebCore::FileStreamProxy::openForWriteOnFileThread):
1399         (WebCore::FileStreamProxy::close):
1400         (WebCore::FileStreamProxy::read):
1401         (WebCore::FileStreamProxy::readOnFileThread):
1402         (WebCore::FileStreamProxy::write):
1403         (WebCore::FileStreamProxy::writeOnFileThread):
1404         (WebCore::FileStreamProxy::truncate):
1405         (WebCore::FileStreamProxy::truncateOnFileThread):
1406         * loader/WorkerThreadableLoader.cpp:
1407         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
1408         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
1409         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
1410         * page/GeolocationPositionCache.cpp:
1411         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
1412         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
1413         * platform/CrossThreadCopier.h:
1414         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
1415         (WebCore::AllowCrossThreadAccessWrapper::value):
1416         (WebCore::AllowCrossThreadAccess):
1417         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
1418         (WebCore::AllowExtendedLifetimeWrapper::value):
1419         (WebCore::AllowExtendedLifetime):
1420         * platform/graphics/chromium/cc/CCCompletionEvent.h:
1421         * storage/IDBObjectStoreBackendImpl.cpp:
1422         (WebCore::IDBObjectStoreBackendImpl::get):
1423         (WebCore::IDBObjectStoreBackendImpl::put):
1424         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1425         (WebCore::IDBObjectStoreBackendImpl::clear):
1426         (WebCore::IDBObjectStoreBackendImpl::createIndex):
1427         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
1428         (WebCore::IDBObjectStoreBackendImpl::openCursor):
1429         * storage/SQLCallbackWrapper.h:
1430         (WebCore::SQLCallbackWrapper::clear):
1431         * websockets/WorkerThreadableWebSocketChannel.cpp:
1432         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
1433         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
1434         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
1435         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
1436         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
1437         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
1438         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
1439         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
1440         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
1441         * workers/WorkerMessagingProxy.cpp:
1442         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
1443
1444 2011-04-27  Adam Barth  <abarth@webkit.org>
1445
1446         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
1447
1448         * page/Frame.cpp:
1449         (WebCore::Frame::setTiledBackingStoreEnabled):
1450         * platform/audio/ReverbConvolver.cpp:
1451         (WebCore::ReverbConvolver::ReverbConvolver):
1452
1453 2011-04-27  Adam Barth  <abarth@webkit.org>
1454
1455         Reviewed by David Levin.
1456
1457         Fix five strict PassOwnPtr violations in WebCore
1458         https://bugs.webkit.org/show_bug.cgi?id=59640
1459
1460         * css/MediaList.cpp:
1461         (WebCore::MediaList::deleteMedium):
1462         (WebCore::MediaList::setMediaText):
1463         (WebCore::MediaList::appendMedium):
1464         * css/MediaQuery.h:
1465         * dom/MessagePort.cpp:
1466         (WebCore::MessagePort::disentanglePorts):
1467         (WebCore::MessagePort::entanglePorts):
1468         * inspector/InspectorStyleSheet.cpp:
1469         (ParsedStyleSheet::setText):
1470         * rendering/RenderTheme.cpp:
1471         (WebCore::RenderTheme::adjustStyle):
1472         (WebCore::RenderTheme::adjustMeterStyle):
1473         * rendering/RenderThemeMac.mm:
1474         (WebCore::RenderThemeMac::adjustMenuListStyle):
1475         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
1476         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
1477         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
1478         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
1479         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
1480         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
1481         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
1482
1483 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
1484
1485         Reviewed by Beth Dakin.
1486
1487         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
1488         https://bugs.webkit.org/show_bug.cgi?id=59648
1489
1490         Test: accessibility/aria-fallback-roles.html
1491
1492         * accessibility/AccessibilityObject.cpp:
1493         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
1494
1495 2011-04-27  Beth Dakin  <bdakin@apple.com>
1496
1497         Reviewed by Dan Bernstein.
1498
1499         https://bugs.webkit.org/show_bug.cgi?id=59671
1500         Race condition with scrollbar animations and closing a page can cause a crash in 
1501         WebCore::FrameView::setVisibleScrollerThumbRect + 15
1502         -and corresponding-
1503         <rdar://problem/9329253>
1504
1505         It is definitely possible for Page to be null here. So we should null-check it! 
1506         And we should not ASSERT.
1507         * page/FrameView.cpp:
1508         (WebCore::FrameView::didCompleteRubberBand):
1509         (WebCore::FrameView::scrollbarStyleChanged):
1510         (WebCore::FrameView::setVisibleScrollerThumbRect):
1511
1512 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1513
1514         WinCE build fix after r85143.
1515
1516         * platform/graphics/wince/FontWinCE.cpp:
1517         (WebCore::TextRunComponent::TextRunComponent):
1518
1519 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
1520
1521         Reviewed by Tony Chang.
1522
1523         IndexedDB object store delete should fail if key is null
1524         https://bugs.webkit.org/show_bug.cgi?id=58614
1525
1526         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
1527
1528         * storage/IDBObjectStoreBackendImpl.cpp:
1529         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1530
1531 2011-04-27  Eric Seidel  <eric@webkit.org>
1532
1533         Reviewed by Ryosuke Niwa.
1534
1535         Should have an easy way to construct starting BidiStatus for a paragraph root
1536         https://bugs.webkit.org/show_bug.cgi?id=59226
1537
1538         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
1539         I've made this a constructor for BidiStatus instead.
1540
1541         As part of this effort I added a direction() accessor for TextRun and got
1542         rid of the old m_rtl bool.  This is part of the generic effort in the
1543         Bidi code to replace old bool usage with the superior TextDirection enum
1544         (this generally makes the code cleaner).
1545
1546         As part of this replacement effort I found several places which were
1547         assuming LTR (by passing rtl=false) when they probably want to use
1548         the current text direction.  I suspect that LTR vs. RTL may affect
1549         string width in the case of ligatures.  It's unclear.
1550
1551         This is almost entirely a mechanical change.
1552
1553         * html/canvas/CanvasRenderingContext2D.cpp:
1554         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1555         * platform/graphics/GraphicsContext.cpp:
1556         (WebCore::GraphicsContext::drawBidiText):
1557         * platform/graphics/TextRun.h:
1558         (WebCore::TextRun::TextRun):
1559         (WebCore::TextRun::direction):
1560         (WebCore::TextRun::rtl):
1561         (WebCore::TextRun::ltr):
1562         (WebCore::TextRun::setDirection):
1563         * platform/text/BidiResolver.h:
1564         (WebCore::BidiStatus::BidiStatus):
1565         * rendering/EllipsisBox.cpp:
1566         (WebCore::EllipsisBox::paint):
1567         (WebCore::EllipsisBox::selectionRect):
1568         (WebCore::EllipsisBox::paintSelection):
1569         * rendering/InlineTextBox.cpp:
1570         (WebCore::InlineTextBox::selectionRect):
1571         (WebCore::InlineTextBox::paint):
1572         (WebCore::InlineTextBox::paintSelection):
1573         (WebCore::InlineTextBox::paintCompositionBackground):
1574         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1575         (WebCore::InlineTextBox::paintTextMatchMarker):
1576         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1577         (WebCore::InlineTextBox::offsetForPosition):
1578         (WebCore::InlineTextBox::positionForOffset):
1579         * rendering/RenderBlockLineLayout.cpp:
1580         (WebCore::RenderBlock::determineStartPosition):
1581         * rendering/RenderFileUploadControl.cpp:
1582         (WebCore::RenderFileUploadControl::paintObject):
1583         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1584         * rendering/RenderListBox.cpp:
1585         (WebCore::RenderListBox::updateFromElement):
1586         (WebCore::RenderListBox::paintItemForeground):
1587         * rendering/RenderTextControl.cpp:
1588         (WebCore::RenderTextControl::getAvgCharWidth):
1589         (WebCore::RenderTextControl::paintPlaceholder):
1590         * rendering/svg/SVGInlineTextBox.cpp:
1591         (WebCore::SVGInlineTextBox::constructTextRun):
1592         * rendering/svg/SVGTextMetrics.cpp:
1593         (WebCore::constructTextRun):
1594
1595 2011-04-27  Robert Hogan  <robert@webkit.org>
1596
1597         Reviewed by Adam Barth.
1598
1599         Allow shadowing of history object
1600         https://bugs.webkit.org/show_bug.cgi?id=55965
1601
1602         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1603                http/tests/history/cross-origin-replace-history-object.html
1604
1605         * page/DOMWindow.idl:
1606
1607 2011-04-27  James Robinson  <jamesr@chromium.org>
1608
1609         Reviewed by Kenneth Russell.
1610
1611         [chromium] Ensure compositing layers are up to date before entering doComposite
1612         https://bugs.webkit.org/show_bug.cgi?id=59159
1613
1614         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1615         GraphicsLayerClient::paintContents() implementations).
1616
1617         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1618         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1619         * platform/graphics/chromium/LayerChromium.cpp:
1620         (WebCore::LayerChromium::LayerChromium):
1621         (WebCore::LayerChromium::~LayerChromium):
1622         * platform/graphics/chromium/LayerRendererChromium.cpp:
1623         (WebCore::LayerRendererChromium::updateLayers):
1624         * platform/graphics/chromium/LayerRendererChromium.h:
1625           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1626
1627 2011-04-27  James Robinson  <jamesr@chromium.org>
1628
1629         Reviewed by Adam Barth.
1630
1631         Fix OwnPtr strict issues in chromium linux build
1632         https://bugs.webkit.org/show_bug.cgi?id=59664
1633
1634         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1635         (WebCore::ComplexTextController::getNormalizedTextRun):
1636         * platform/graphics/skia/ImageBufferSkia.cpp:
1637         (WebCore::ImageBuffer::ImageBuffer):
1638         * platform/graphics/skia/PlatformContextSkia.cpp:
1639         (WebCore::PlatformContextSkia::PlatformContextSkia):
1640
1641 2011-04-27  Chris Rogers  <crogers@google.com>
1642
1643         Reviewed by Kenneth Russell.
1644
1645         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1646         https://bugs.webkit.org/show_bug.cgi?id=59641
1647
1648         No new tests since audio API is not yet implemented.
1649
1650         * platform/audio/AudioBus.cpp:
1651         (WebCore::AudioBus::createBySampleRateConverting):
1652         (WebCore::AudioBus::createByMixingToMono):
1653
1654 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1655
1656         Motivated by Alexey Proskuryakov.
1657
1658         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1659         informative, since it confused Alexey and me.
1660
1661 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1662
1663         Reviewed by Sam Weinig.
1664
1665         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1666         https://bugs.webkit.org/show_bug.cgi?id=59646
1667
1668         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1669         a world, we need to clear all entries in the map for that world, since
1670         the finalizers that would otherwise clear those entries don't run. The
1671         simplest way to do this is just to make the world own the map.
1672         
1673         * bindings/js/DOMWrapperWorld.h:
1674         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1675         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1676         * bindings/js/JSCSSValueCustom.cpp:
1677         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1678         (WebCore::JSCSSValueOwner::finalize):
1679         * bindings/js/JSDOMBinding.h:
1680
1681 2011-04-27  Adam Barth  <abarth@webkit.org>
1682
1683         Reviewed by David Levin.
1684
1685         Fix OwnPtr issues in IndexedDB
1686         https://bugs.webkit.org/show_bug.cgi?id=59656
1687
1688         I didn't do an exhaustive review of this code, but I fixed the problems
1689         caught by turning on strict OwnPtr and all their antecedents.  This
1690         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1691         behavior change.
1692
1693         * platform/leveldb/LevelDBDatabase.cpp:
1694         (WebCore::LevelDBDatabase::LevelDBDatabase):
1695         (WebCore::LevelDBDatabase::open):
1696         (WebCore::LevelDBDatabase::createIterator):
1697         * platform/leveldb/LevelDBDatabase.h:
1698         * platform/leveldb/LevelDBIterator.cpp:
1699         (WebCore::LevelDBIterator::LevelDBIterator):
1700         * platform/leveldb/LevelDBIterator.h:
1701         * storage/IDBLevelDBBackingStore.cpp:
1702         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1703         (WebCore::IDBLevelDBBackingStore::open):
1704         (WebCore::getNewDatabaseId):
1705         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1706         (WebCore::getNewObjectStoreId):
1707         (WebCore::deleteRange):
1708         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1709         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1710         (WebCore::IDBLevelDBBackingStore::getIndexes):
1711         (WebCore::getNewIndexId):
1712         (WebCore::findGreatestKeyLessThan):
1713         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1714         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1715         (WebCore::findLastIndexKeyEqualTo):
1716         * storage/IDBLevelDBBackingStore.h:
1717
1718 2011-04-19  MORITA Hajime  <morrita@google.com>
1719
1720         Reviewed by Tony Chang.
1721
1722         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1723         https://bugs.webkit.org/show_bug.cgi?id=58113
1724
1725         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1726         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1727         * Now MarkerMapVectorPair is no longer used.
1728         
1729         No new tests, No behavior change.
1730
1731         * GNUmakefile.list.am:
1732         * WebCore.gypi:
1733         * WebCore.pro:
1734         * WebCore.vcproj/WebCore.vcproj:
1735         * WebCore.xcodeproj/project.pbxproj:
1736         * dom/DocumentMarker.h:
1737         * dom/DocumentMarkerController.cpp:
1738         (WebCore::DocumentMarkerController::addMarker):
1739         (WebCore::DocumentMarkerController::copyMarkers):
1740         (WebCore::DocumentMarkerController::removeMarkers):
1741         (WebCore::DocumentMarkerController::markerContainingPoint):
1742         (WebCore::DocumentMarkerController::markersForNode):
1743         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1744         (WebCore::DocumentMarkerController::removeMarkersFromList):
1745         (WebCore::DocumentMarkerController::repaintMarkers):
1746         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1747         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1748         (WebCore::DocumentMarkerController::shiftMarkers):
1749         (WebCore::DocumentMarkerController::setMarkersActive):
1750         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1751         (WebCore::DocumentMarkerController::showMarkers):
1752         * dom/DocumentMarkerController.h:
1753         * dom/RenderedDocumentMarker.h: Added.
1754         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1755         (WebCore::RenderedDocumentMarker::isRendered):
1756         (WebCore::RenderedDocumentMarker::contains):
1757         (WebCore::RenderedDocumentMarker::setRenderedRect):
1758         (WebCore::RenderedDocumentMarker::renderedRect):
1759         (WebCore::RenderedDocumentMarker::invalidate):
1760         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1761
1762 2011-04-27  James Robinson  <jamesr@chromium.org>
1763
1764         Unreviewed, rolling out r85112.
1765         http://trac.webkit.org/changeset/85112
1766         https://bugs.webkit.org/show_bug.cgi?id=59159
1767
1768         Broke mac compile
1769
1770         * page/FrameView.cpp:
1771         (WebCore::FrameView::updateCompositingLayers):
1772         * page/FrameView.h:
1773         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1774         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1775         * platform/graphics/chromium/LayerChromium.cpp:
1776         (WebCore::LayerChromium::LayerChromium):
1777         (WebCore::LayerChromium::~LayerChromium):
1778         * platform/graphics/chromium/LayerRendererChromium.cpp:
1779         (WebCore::LayerRendererChromium::updateLayers):
1780         * platform/graphics/chromium/LayerRendererChromium.h:
1781
1782 2011-04-27  Mark Rowe  <mrowe@apple.com>
1783
1784         Build fix.
1785
1786         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1787
1788 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1789
1790         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1791
1792         * platform/network/ResourceHandleClient.h:
1793
1794 2011-04-27  James Robinson  <jamesr@chromium.org>
1795
1796         Reviewed by Kenneth Russell.
1797
1798         [chromium] Ensure compositing layers are up to date before entering doComposite
1799         https://bugs.webkit.org/show_bug.cgi?id=59159
1800
1801         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1802         GraphicsLayerClient::paintContents() implementations).
1803
1804         * page/FrameView.cpp:
1805         (WebCore::FrameView::updateCompositingLayers):
1806             Add an optional CompositingUpdateType parameter.
1807         * page/FrameView.h:
1808         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1809         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1810         * platform/graphics/chromium/LayerChromium.cpp:
1811         (WebCore::LayerChromium::LayerChromium):
1812         (WebCore::LayerChromium::~LayerChromium):
1813         * platform/graphics/chromium/LayerRendererChromium.cpp:
1814         (WebCore::LayerRendererChromium::updateLayers):
1815         * platform/graphics/chromium/LayerRendererChromium.h:
1816           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1817         * rendering/RenderLayer.cpp:
1818         (WebCore::RenderLayer::dirtyZOrderLists):
1819         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1820         * rendering/RenderLayerCompositor.cpp:
1821         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1822         * rendering/RenderLayerCompositor.h:
1823           Fix a typo in CompositingUpdateType Pait->Paint
1824
1825 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1826
1827         Reviewed by Antti Koivisto.
1828
1829         Part of WebCore should use CFNetwork-based loader on Mac
1830         https://bugs.webkit.org/show_bug.cgi?id=51836
1831
1832         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1833         willCacheResponse/shouldCacheResponse.
1834
1835         * loader/EmptyClients.h:
1836         * loader/FrameLoaderClient.h:
1837         * loader/ResourceLoader.h:
1838         * loader/cf/ResourceLoaderCFNet.cpp:
1839         * loader/mac/ResourceLoaderMac.mm:
1840         (WebCore::ResourceLoader::willCacheResponse):
1841         * platform/network/ResourceHandleClient.h:
1842         (WebCore::ResourceHandleClient::willCacheResponse):
1843         (WebCore::ResourceHandleClient::shouldCacheResponse):
1844         * platform/network/cf/ResourceHandleCFNet.cpp:
1845         (WebCore::willCacheResponse):
1846
1847 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
1848
1849         Reviewed by Brian Weinstein.
1850
1851         Web Inspector: Stop on Exception state does not persist.
1852
1853         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
1854         https://bugs.webkit.org/show_bug.cgi?id=59630
1855
1856         * inspector/front-end/ScriptsPanel.js:
1857         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1858         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1859         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1860
1861 2011-04-27  Adrienne Walker  <enne@google.com>
1862
1863         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
1864         https://bugs.webkit.org/show_bug.cgi?id=59020
1865
1866         * platform/graphics/chromium/LayerRendererChromium.cpp:
1867         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1868
1869 2011-04-27  Darin Adler  <darin@apple.com>
1870
1871         Reviewed by David Levin.
1872
1873         Fix strict OwnPtr issues seen in about 30 more files
1874         https://bugs.webkit.org/show_bug.cgi?id=59615
1875
1876         * bindings/js/JSCallbackData.h:
1877         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
1878         * bindings/js/JSMessageEventCustom.cpp:
1879         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
1880         * css/CSSParser.cpp:
1881         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
1882         adoptPtr, and release.
1883         * dom/MessageEvent.cpp:
1884         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
1885         and release.
1886         * dom/MessagePortChannel.cpp:
1887         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
1888         * dom/ScriptExecutionContext.cpp:
1889         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
1890         * dom/XMLDocumentParserLibxml2.cpp:
1891         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
1892         * dom/default/PlatformMessagePortChannel.cpp:
1893         (WebCore::MessagePortChannel::create): Use adoptPtr.
1894         * html/HTMLFormControlElement.cpp:
1895         (WebCore::HTMLFormControlElement::detach): Use nullptr.
1896         * inspector/InspectorAgent.cpp:
1897         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
1898         * inspector/InspectorConsoleAgent.cpp:
1899         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
1900         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
1901         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
1902         * inspector/InspectorController.cpp:
1903         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
1904         * inspector/InspectorDOMAgent.cpp:
1905         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
1906         * inspector/InspectorResourceAgent.cpp:
1907         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1908         * page/FrameActionScheduler.cpp:
1909         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1910         * platform/graphics/ShadowBlur.cpp:
1911         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1912         * platform/graphics/ca/GraphicsLayerCA.cpp:
1913         (WebCore::GraphicsLayer::create): Use adoptPtr.
1914         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1915         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1916         * rendering/RenderBlock.cpp:
1917         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1918         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1919         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
1920         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
1921         * rendering/RenderLayerBacking.cpp:
1922         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
1923         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
1924         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
1925         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
1926         * rendering/RenderLayerCompositor.cpp:
1927         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
1928         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
1929         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
1930         * rendering/style/StyleRareNonInheritedData.cpp:
1931         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
1932         explicit initializations of OwnPtr members to 0. Use adoptPtr.
1933         * workers/SharedWorkerContext.cpp:
1934         (WebCore::createConnectEvent): Use adoptPtr.
1935         * workers/Worker.cpp:
1936         (WebCore::Worker::notifyFinished): Use nullptr.
1937
1938 2011-04-27  Enrica Casucci  <enrica@apple.com>
1939
1940         Reviewed by Darin Adler.
1941
1942         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
1943         https://bugs.webkit.org/show_bug.cgi?id=59251
1944         <rdar://problem/9327044>
1945
1946         When we are looking for wrapping elements that are presentational, we should
1947         include elements that have a non transparent background color only if they
1948         are not blocks.
1949
1950         Test: editing/pasteboard/do-not-copy-body-color.html
1951
1952         * editing/markup.cpp:
1953         (WebCore::isElementPresentational):
1954
1955 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
1956
1957         Reviewed by Antti Koivisto.
1958
1959         Teach sub-selector chains about shadow descendants
1960         https://bugs.webkit.org/show_bug.cgi?id=58342
1961
1962         The primary change is to the logic of parsing specifiers:
1963         1) The shadow descendant selectors (those specifiers that are unknown
1964         pseudo element selectors) are always kept at the top of the chain.
1965         2) The sub-selectors after shadow descendant selectors are stashed right
1966         behind the sub-selector, but not at the end of the chain.
1967         3) Other sub-selectors are appended at the end of the chain.
1968
1969         * css/CSSGrammar.y: Changed specifier_list collection to use new
1970             CSSParser::updateSpecifier helper.
1971         * css/CSSParser.cpp:
1972         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
1973             look for the last ShadowDescendant relation in the chain of selectors,
1974             because the next selector after it is the one that should get the
1975             element name.
1976         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
1977             CSSGrammar.y. The new logic adjusts the selector chain to allow
1978             shadow descendant selectors have sub-selectors (and have multiple shadow
1979             descendants in the chain).
1980         * css/CSSParser.h: Added decl.
1981         * css/CSSParserValues.cpp:
1982         (WebCore::CSSParserSelector::insertTagHistory): Added.
1983         (WebCore::CSSParserSelector::appendTagHistory): Aded.
1984         * css/CSSParserValues.h: Added decls.
1985         * css/CSSStyleSelector.cpp:
1986         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
1987             shadow descendant selector match check, since now there could be many
1988             of them in the selector chain.
1989
1990 2011-04-20  Adrienne Walker  <enne@google.com>
1991
1992         Reviewed by Kenneth Russell.
1993
1994         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
1995         https://bugs.webkit.org/show_bug.cgi?id=59020
1996
1997         mapRect is the incorrect transform here.  The parent scissor rect
1998         needs to be projected into layer space instead.
1999
2000         Test: compositing/flat-with-transformed-child.html
2001
2002         * platform/graphics/chromium/LayerRendererChromium.cpp:
2003         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2004
2005 2011-04-27  Pratik Solanki  <psolanki@apple.com>
2006
2007         Reviewed by Antti Koivisto.
2008
2009         Part of WebCore should use CFNetwork-based loader on Mac
2010         https://bugs.webkit.org/show_bug.cgi?id=51836
2011
2012         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
2013         * platform/mac/SoftLinking.h:
2014         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
2015
2016 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
2017
2018         Reviewed by Antti Koivisto.
2019
2020         Cleanup CSSStyleApplyProperty.cpp
2021         https://bugs.webkit.org/show_bug.cgi?id=59623
2022
2023         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
2024         Use typedefs instead of repating the function pointer declarations in a few places.
2025
2026         * css/CSSStyleApplyProperty.cpp:
2027         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
2028         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
2029         (WebCore::ApplyPropertyColor::applyInheritValue):
2030         (WebCore::ApplyPropertyColor::applyInitialValue):
2031         (WebCore::ApplyPropertyColor::applyValue):
2032         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2033
2034 2011-04-27  Dan Bernstein  <mitz@apple.com>
2035
2036         Reviewed by Anders Carlsson.
2037
2038         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
2039         https://bugs.webkit.org/show_bug.cgi?id=59622
2040
2041         Test: fast/borders/border-image-trumps-radius.html
2042
2043         * rendering/RenderBox.cpp:
2044         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
2045         image, then border radius is ignored, so no bleed avoidance is needed.
2046         * rendering/RenderObject.cpp:
2047         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
2048         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
2049         * rendering/RenderObject.h:
2050
2051 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2052
2053         Reviewed by Xan Lopez.
2054
2055         [GTK] editing/pasteboard/copy-standalone-image.html fails
2056         https://bugs.webkit.org/show_bug.cgi?id=53645
2057
2058         When writing an image to the clipboard, also write the URL and title
2059         into the markup and URL portion. This change also abstracts a helper
2060         imageToMarkup into markup.{cpp/h} from several different locations
2061         throughout the platform layer.
2062
2063         * editing/markup.h: Added new function definition.
2064         * editing/markup.cpp:
2065         (WebCore::imageToMarkup): Add this function which turns an image URL 
2066         and element into some markup representing that image, while preserving
2067         non-src attributes.
2068         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
2069         to markup.cpp.
2070         * platform/gtk/PasteboardGtk.cpp:
2071         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
2072         image URL for a variety of image tag types.
2073         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
2074         markup and URL portions of the clipboard. This will ensure that images
2075         paste properly back into WebKit.
2076         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
2077         one from markup.h
2078
2079 2011-04-27  Steve Block  <steveblock@google.com>
2080
2081         Reviewed by David Levin.
2082
2083         Remove Android build system
2084         https://bugs.webkit.org/show_bug.cgi?id=48111
2085
2086         This is to avoid the maintenance burden until the Android port is
2087         fully upstreamed.
2088
2089         No new tests, build change only.
2090
2091         * Android.derived.jscbindings.mk: Removed.
2092         * Android.derived.mk: Removed.
2093         * Android.derived.v8bindings.mk: Removed.
2094         * Android.jscbindings.mk: Removed.
2095         * Android.mk: Removed.
2096         * Android.v8bindings.mk: Removed.
2097
2098 2011-04-27  Darin Adler  <darin@apple.com>
2099
2100         Reviewed by Sam Weinig.
2101
2102         Somehow about:blank gets into the icon database
2103         https://bugs.webkit.org/show_bug.cgi?id=58067
2104         rdar://problem/6751446
2105
2106         Implemented the policy Brady suggested, where only http and https URLs can
2107         be associated with and icon, guarding both on the way in to the database,
2108         and on the way out.
2109
2110         * loader/icon/IconDatabase.cpp:
2111         (WebCore::pageCanHaveIcon): Added.
2112         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
2113         instead of just checking for an empty URL.
2114         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
2115         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
2116         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
2117         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
2118         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
2119         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
2120         two separate assertions and added a third.
2121         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
2122
2123         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
2124         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
2125         overloaded it to work on both UChar and char, and added an assertion to it.
2126         Also moved this to the top of the file and made the UChar version usable
2127         in the shared code used even by Google.
2128         (WebCore::KURL::invalidate): Updated for name change.
2129         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
2130         toASCIILower since it's faster.
2131         (WebCore::KURL::parse): Updated for name changes.
2132         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
2133         since it's faster.
2134         (WebCore::protocolIsInHTTPFamily): Added.
2135
2136         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
2137         to protocolIsInHTTPFamily and added a version that works on a string.
2138         Kept the old name as an inline function so we don't have to rename
2139         all the cal sites now.
2140
2141         * platform/KURLGoogle.cpp: Renamed as above.
2142         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
2143         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
2144         (WebCore::KURLGooglePrivate::setAscii): Ditto.
2145         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
2146         (WebCore::KURLGooglePrivate::copyTo): Ditto.
2147         (WebCore::KURL::KURL): Ditto.
2148         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
2149         (WebCore::KURL::invalidate): Ditto.
2150         * platform/KURLGooglePrivate.h: Ditto.
2151
2152         * WebCore.exp.in: Updated for above changes.
2153
2154 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2155
2156         Reviewed by Pavel Feldman.
2157
2158         Web Inspector: browser crash on evaluation of 'throw undefined'
2159         https://bugs.webkit.org/show_bug.cgi?id=59611
2160
2161         Test: inspector/console/console-eval-throw-undefined.html
2162
2163         * inspector/InjectedScriptSource.js: use try/catch to protect from
2164         exception during conversion of another exception to string.
2165
2166 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2167
2168         Reviewed by Yury Semikhatsky.
2169
2170         Web Inspector: clicking bookmarklet multiplies resources panel entries.
2171         https://bugs.webkit.org/show_bug.cgi?id=59590
2172
2173         * inspector/front-end/ResourceTreeModel.js:
2174         (WebInspector.ResourceTreeModel):
2175         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2176         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2177         * inspector/front-end/ResourcesPanel.js:
2178         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
2179         (WebInspector.FrameTreeElement):
2180         (WebInspector.FrameTreeElement.prototype.appendResource):
2181         * inspector/front-end/inspector.js:
2182         (WebInspector.frontendReused):
2183
2184 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2185
2186         Reviewed by Yury Semikhatsky.
2187
2188         Web Inspector: opening bookmarklet disconnects DOM agent.
2189         https://bugs.webkit.org/show_bug.cgi?id=59588
2190
2191         * inspector/InspectorDOMAgent.cpp:
2192         (WebCore::InspectorDOMAgent::setDocument):
2193
2194 2011-04-27  Hans Wennborg  <hans@chromium.org>
2195
2196         Reviewed by Tony Gentilcore.
2197
2198         IndexedDB: Fix compiler warnings about uninitialized variables
2199         https://bugs.webkit.org/show_bug.cgi?id=59599
2200
2201         Build fix. No new tests.
2202
2203         * storage/IDBLevelDBBackingStore.cpp:
2204         (WebCore::getNewObjectStoreId):
2205         (WebCore::getNewIndexId):
2206
2207 2011-04-26  Hans Wennborg  <hans@chromium.org>
2208
2209         Reviewed by Tony Gentilcore.
2210
2211         IndexedDB: Move LevelDB key coding routines to separate file
2212         https://bugs.webkit.org/show_bug.cgi?id=59452
2213
2214         Move all routines concerned with encoding, decoding and comparison of
2215         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
2216         IDBLevelDBCoding.cpp.
2217
2218         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
2219         allow for unit testing of the coding routines.
2220
2221         No new functionality, no new tests.
2222
2223         * WebCore.gypi:
2224         * storage/IDBLevelDBBackingStore.cpp:
2225         (WebCore::getInt):
2226         (WebCore::putInt):
2227         (WebCore::getString):
2228         (WebCore::putString):
2229         (WebCore::compareKeys):
2230         (WebCore::compareIndexKeys):
2231         (WebCore::Comparator::compare):
2232         (WebCore::setUpMetadata):
2233         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
2234         (WebCore::getNewDatabaseId):
2235         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
2236         (WebCore::IDBLevelDBBackingStore::getObjectStores):
2237         (WebCore::getNewObjectStoreId):
2238         (WebCore::IDBLevelDBBackingStore::createObjectStore):
2239         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
2240         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
2241         (WebCore::getNewVersionNumber):
2242         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
2243         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
2244         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
2245         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
2246         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
2247         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
2248         (WebCore::IDBLevelDBBackingStore::getIndexes):
2249         (WebCore::getNewIndexId):
2250         (WebCore::IDBLevelDBBackingStore::createIndex):
2251         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
2252         (WebCore::versionExists):
2253         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
2254         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
2255         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
2256         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
2257         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
2258         * storage/IDBLevelDBCoding.cpp: Added.
2259         (WebCore::IDBLevelDBCoding::encodeByte):
2260         (WebCore::IDBLevelDBCoding::maxIDBKey):
2261         (WebCore::IDBLevelDBCoding::minIDBKey):
2262         (WebCore::IDBLevelDBCoding::encodeInt):
2263         (WebCore::IDBLevelDBCoding::decodeInt):
2264         (WebCore::IDBLevelDBCoding::encodeVarInt):
2265         (WebCore::IDBLevelDBCoding::decodeVarInt):
2266         (WebCore::IDBLevelDBCoding::encodeString):
2267         (WebCore::IDBLevelDBCoding::decodeString):
2268         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
2269         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
2270         (WebCore::IDBLevelDBCoding::encodeDouble):
2271         (WebCore::IDBLevelDBCoding::decodeDouble):
2272         (WebCore::IDBLevelDBCoding::encodeIDBKey):
2273         (WebCore::IDBLevelDBCoding::decodeIDBKey):
2274         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
2275         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
2276         (WebCore::IDBLevelDBCoding::compare):
2277         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
2278         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
2279         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
2280         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
2281         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
2282         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
2283         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
2284         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
2285         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
2286         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
2287         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
2288         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
2289         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
2290         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
2291         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
2292         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
2293         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
2294         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
2295         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
2296         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
2297         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
2298         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
2299         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
2300         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
2301         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
2302         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
2303         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
2304         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
2305         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
2306         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
2307         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
2308         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
2309         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
2310         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
2311         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
2312         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
2313         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
2314         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
2315         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
2316         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
2317         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
2318         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
2319         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
2320         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
2321         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
2322         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
2323         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
2324         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
2325         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
2326         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
2327         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
2328         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
2329         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
2330         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
2331         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
2332         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
2333         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
2334         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
2335         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
2336         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
2337         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
2338         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
2339         * storage/IDBLevelDBCoding.h: Added.
2340         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
2341         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
2342         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
2343         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
2344         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
2345
2346 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2347
2348         Reviewed by Pavel Feldman.
2349
2350         Web Inspector: expose exception details when script is paused on exception
2351         https://bugs.webkit.org/show_bug.cgi?id=59591
2352
2353         When script is paused on an exception, the exception value is added as <exception>
2354         property in the local scope and the breakpoint details message says
2355         "Paused on excepion: '<exception to strin value>'."
2356
2357         * English.lproj/localizedStrings.js:
2358         * inspector/front-end/ScopeChainSidebarPane.js:
2359         (WebInspector.ScopeChainSidebarPane.prototype.update):
2360         * inspector/front-end/ScriptsPanel.js:
2361         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
2362         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
2363
2364 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
2365
2366         Reviewed by Pavel Feldman.
2367
2368         Web Inspector: [protocol] Paused event should expose exception value that caused it
2369         https://bugs.webkit.org/show_bug.cgi?id=58996
2370
2371         Debug.pause event now contains an optional reference to the exception
2372         object in case script execution is paused on a JavaScript exception.
2373
2374         Also JavaScript call frames are passed directly into the injected script when
2375         we need to wrap them for passing to the front-end. This change breaks cyclic
2376         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
2377
2378         * bindings/js/JSInjectedScriptHostCustom.cpp:
2379         * bindings/js/ScriptDebugServer.cpp:
2380         (WebCore::ScriptDebugServer::dispatchDidPause):
2381         * bindings/js/ScriptDebugServer.h:
2382         * bindings/v8/ScriptDebugServer.cpp:
2383         (WebCore::ScriptDebugServer::breakProgram):
2384         (WebCore::ScriptDebugServer::editScriptSource):
2385         (WebCore::ScriptDebugServer::breakProgramCallback):
2386         (WebCore::ScriptDebugServer::handleV8DebugEvent):
2387         * bindings/v8/ScriptDebugServer.h:
2388         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2389         * inspector/InjectedScript.cpp:
2390         (WebCore::InjectedScript::evaluateOnCallFrame):
2391         (WebCore::InjectedScript::wrapCallFrames):
2392         * inspector/InjectedScript.h:
2393         * inspector/InjectedScriptHost.cpp:
2394         * inspector/InjectedScriptHost.h:
2395         (WebCore::InjectedScriptHost::init):
2396         * inspector/InjectedScriptHost.idl:
2397         * inspector/InjectedScriptSource.js:
2398         (.):
2399         * inspector/Inspector.json:
2400         * inspector/InspectorAgent.cpp:
2401         (WebCore::InspectorAgent::InspectorAgent):
2402         * inspector/InspectorDebuggerAgent.cpp:
2403         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
2404         (WebCore::InspectorDebuggerAgent::currentCallFrames):
2405         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
2406         (WebCore::InspectorDebuggerAgent::didPause):
2407         (WebCore::InspectorDebuggerAgent::didContinue):
2408         (WebCore::InspectorDebuggerAgent::clear):
2409         * inspector/InspectorDebuggerAgent.h:
2410         * inspector/ScriptDebugListener.h:
2411         * inspector/WorkerInspectorController.cpp:
2412         (WebCore::WorkerInspectorController::WorkerInspectorController):
2413
2414 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2415
2416         Reviewed by Yury Semikhatsky.
2417
2418         Web Inspector: implement incremental CSS editing in the structure view.
2419         https://bugs.webkit.org/show_bug.cgi?id=59455
2420
2421         * inspector/front-end/StylesSidebarPane.js:
2422         (WebInspector.StylePropertyTreeElement.prototype):
2423
2424 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
2425
2426         Reviewed by Eric Seidel.
2427
2428         Frame.h shouldn't include Document.h
2429         https://bugs.webkit.org/show_bug.cgi?id=59560
2430
2431         Frame can use a forward-declared Document if we move
2432         Frame::displayStringModifiedByEncoding's implementation out of the
2433         header.
2434                                 Size  #includes  Size * #includes
2435         Before: page/Frame.h:   0.746       653           487.138
2436                 dom/Document.h: 0.220      1306           287.320
2437         
2438         After:  page/Frame.h:   0.646       653           421.838
2439                 dom/Document.h: 0.220      1189           261.580
2440
2441         * WebCore.exp.in:
2442         * bindings/ScriptControllerBase.cpp:
2443         * bindings/generic/BindingSecurityBase.cpp:
2444         * bindings/v8/V8Proxy.cpp:
2445         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
2446         * dom/CharacterData.cpp:
2447         * dom/UserTypingGestureIndicator.cpp:
2448         * editing/chromium/SelectionControllerChromium.cpp:
2449         * inspector/InspectorDOMStorageResource.cpp:
2450         * inspector/InspectorInstrumentation.h:
2451         * loader/PingLoader.cpp:
2452         * loader/SubresourceLoader.cpp:
2453         * loader/appcache/DOMApplicationCache.cpp:
2454         * loader/cache/CachedResourceRequest.cpp:
2455         * page/Frame.cpp:
2456         (WebCore::Frame::displayStringModifiedByEncoding):
2457         * page/Frame.h:
2458         * page/Geolocation.cpp:
2459         * page/Location.cpp:
2460         * page/Navigator.cpp:
2461         * page/PageGroupLoadDeferrer.cpp:
2462         * page/PerformanceTiming.cpp:
2463         * xml/XSLTProcessorLibxslt.cpp:
2464
2465 2011-04-27  James Robinson  <jamesr@chromium.org>
2466
2467         Reviewed by Eric Seidel.
2468
2469         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2470         https://bugs.webkit.org/show_bug.cgi?id=59377
2471
2472         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
2473         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
2474
2475         * css/CSSStyleSelector.cpp:
2476         (WebCore::CSSStyleSelector::applyProperty):
2477         * page/animation/AnimationBase.cpp:
2478         (WebCore::blendFunc):
2479         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2480         (WebCore::PropertyWrapperShadow::blend):
2481         * rendering/style/RenderStyle.cpp:
2482         (WebCore::RenderStyle::setTextShadow):
2483         (WebCore::RenderStyle::setBoxShadow):
2484         * rendering/style/RenderStyle.h:
2485         (WebCore::InheritedFlags::textShadow):
2486         * rendering/style/ShadowData.cpp:
2487         (WebCore::ShadowData::ShadowData):
2488         * rendering/style/ShadowData.h:
2489         (WebCore::ShadowData::ShadowData):
2490         (WebCore::ShadowData::next):
2491         (WebCore::ShadowData::setNext):
2492         * rendering/style/StyleRareInheritedData.cpp:
2493         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2494         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2495         * rendering/style/StyleRareInheritedData.h:
2496         * rendering/style/StyleRareNonInheritedData.cpp:
2497         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2498
2499 2011-04-26  David Levin  <levin@chromium.org>
2500
2501         Reviewed by Eric Seidel.
2502
2503         Fix some strict PassOwnPtr issues in WebCore.
2504         https://bugs.webkit.org/show_bug.cgi?id=59563
2505
2506         * css/SVGCSSStyleSelector.cpp:
2507         (WebCore::CSSStyleSelector::applySVGProperty):
2508         * html/canvas/WebGLRenderingContext.cpp:
2509         (WebCore::WebGLRenderingContext::create):
2510         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
2511         * platform/text/TextCodecLatin1.cpp:
2512         (WebCore::newStreamingTextDecoderWindowsLatin1):
2513         * platform/text/TextCodecUTF16.cpp:
2514         (WebCore::newStreamingTextDecoderUTF16LE):
2515         (WebCore::newStreamingTextDecoderUTF16BE):
2516         * platform/text/TextCodecUserDefined.cpp:
2517         (WebCore::newStreamingTextDecoderUserDefined):
2518         * platform/text/mac/TextCodecMac.cpp:
2519         (WebCore::newTextCodecMac):
2520         * workers/Worker.cpp:
2521         (WebCore::Worker::notifyFinished):
2522
2523 2011-04-26  Justin Novosad  <junov@chromium.org>
2524
2525         Reviewed by Kenneth Russell.
2526
2527         [Chromium] Expose skia gpu canvas rendering as a runtime flag
2528         https://bugs.webkit.org/show_bug.cgi?id=58683
2529         Replace the SKIA_GPU compile flag by the pre-existing
2530         acceleratedDrawingEnabled flag. Most code changes are trivial:
2531         compile-time conditionals on SKIA_GPU were either replaced with
2532         a run-time check, or a compile time check on USE(SKIA) 
2533
2534         No new tests. Covered by existing tests.
2535
2536         * html/canvas/CanvasRenderingContext2D.cpp:
2537         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2538         * page/Page.cpp:
2539         (WebCore::Page::sharedGraphicsContext3D):
2540         Added check for the acceleratedDrawing flag.
2541         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2542         (WebCore::DrawingBuffer::DrawingBuffer):
2543         (WebCore::DrawingBuffer::publishToPlatformLayer):
2544         * platform/graphics/gpu/DrawingBuffer.h:
2545         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2546         (WebCore::SharedGraphicsContext3D::create):
2547         On Skia builds, this methos now receives a bool arg to turn on
2548         GPU-accelerated skia rendering
2549         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
2550         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2551         (WebCore::SharedGraphicsContext3D::grContext):
2552         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2553         * platform/graphics/skia/ImageSkia.cpp:
2554         (WebCore::computeResamplingMode):
2555         (WebCore::paintSkBitmap):
2556         (WebCore::Image::drawPattern):
2557         * platform/graphics/skia/PlatformContextSkia.cpp:
2558         (WebCore::PlatformContextSkia::PlatformContextSkia):
2559         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2560         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2561         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2562         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2563         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2564         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2565         (WebCore::PlatformContextSkia::markDirtyRect):
2566         * platform/graphics/skia/PlatformContextSkia.h:
2567         (WebCore::PlatformContextSkia::accelerationMode):
2568         (WebCore::PlatformContextSkia::useGPU):
2569         (WebCore::PlatformContextSkia::useSkiaGPU):
2570
2571 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2572
2573         Not reviewed: restore inspector test disabled in r84913.
2574
2575         Test: http/tests/inspector-enabled/dom-storage-open.html
2576
2577         * inspector/InspectorDOMStorageAgent.cpp:
2578         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2579
2580 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2581
2582         Reviewed by Tony Chang.
2583
2584         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2585         https://bugs.webkit.org/show_bug.cgi?id=59182
2586
2587         Use vertical offsets of the shaping results.
2588
2589         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2590
2591         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2592         (WebCore::ComplexTextController::ComplexTextController):
2593         Added initialization of m_startingY.
2594         (WebCore::ComplexTextController::nextScriptRun):
2595         Followed the change in handling positions.
2596         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2597         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2598         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2599         (WebCore::ComplexTextController::setGlyphPositions):
2600         Changed to use vertical offsets as same as horizontal offsets.
2601         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2602         Removed m_xPositions and Added m_positions and m_startingY.
2603         (WebCore::ComplexTextController::positions): Added.
2604         * platform/graphics/chromium/FontLinux.cpp:
2605         Followed the change in ComplexTextController.
2606         (WebCore::Font::drawComplexText): Ditto.
2607         (WebCore::Font::floatWidthForComplexText): Ditto.
2608         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2609         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2610         (WebCore::Font::selectionRectForComplexText): Ditto.
2611
2612 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2613
2614         Reviewed by Eric Seidel.
2615
2616         Root element should establish a new block formatting context
2617         https://bugs.webkit.org/show_bug.cgi?id=54573
2618
2619         Always expanding the root renderer to include overhanging floats.
2620
2621         Test: fast/block/float/float-overhangs-root.html
2622
2623         * rendering/RenderBlock.cpp:
2624         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2625
2626 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2627
2628         Reviewed by Andreas Kling.
2629
2630         [Qt] Improper rendering of <button> tag when it contains a <br>
2631         https://bugs.webkit.org/show_bug.cgi?id=50521
2632
2633         Test: platform/qt/fast/forms/button-line-break.html
2634
2635         * platform/qt/RenderThemeQt.cpp:
2636         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2637         (WebCore::RenderThemeQt::setButtonPadding):
2638
2639 2011-04-26  James Robinson  <jamesr@chromium.org>
2640
2641         Reviewed by Kenneth Russell.
2642
2643         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2644         https://bugs.webkit.org/show_bug.cgi?id=59572
2645
2646         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2647         when LayerRendererChromium was set.  We set this pointer every frame
2648         and should only reset the tiles if the new LayerRendererChromium is
2649         different from the old one (indicating a context loss), not just reset
2650         on every frame.
2651
2652         * platform/graphics/chromium/LayerTilerChromium.cpp:
2653         (WebCore::LayerTilerChromium::setLayerRenderer):
2654         * platform/graphics/chromium/LayerTilerChromium.h:
2655
2656 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2657
2658         Reviewed by Eric Seidel.
2659
2660         beginElement broken by setAttribute
2661         https://bugs.webkit.org/show_bug.cgi?id=26019
2662
2663         Test: svg/animations/animate-beginElementAt.svg
2664
2665         * svg/SVGAnimationElement.cpp:
2666         (WebCore::SVGAnimationElement::attributeChanged):
2667         Reset the animation state here as the rest of the code reads it and would still
2668         think we are animating when we are not.
2669
2670         * svg/animation/SVGSMILElement.h:
2671         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2672
2673 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2674
2675         Unreviewed, rolling out r84989.
2676         http://trac.webkit.org/changeset/84989
2677         https://bugs.webkit.org/show_bug.cgi?id=59566
2678
2679         REGRESSION (r84989): Lots of vertical text tests failing on
2680         windows (Requested by weinig on #webkit).
2681
2682         * platform/graphics/FontPlatformData.h:
2683         * platform/graphics/win/FontCacheWin.cpp:
2684         (WebCore::FontCache::getFontDataForCharacters):
2685         (WebCore::FontCache::createFontPlatformData):
2686         * platform/graphics/win/FontCustomPlatformData.cpp:
2687         (WebCore::FontCustomPlatformData::fontPlatformData):
2688         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2689         (WebCore::FontPlatformData::FontPlatformData):
2690         * platform/graphics/win/FontPlatformDataWin.cpp:
2691         (WebCore::FontPlatformData::FontPlatformData):
2692
2693 2011-04-26  Sam Weinig  <sam@webkit.org>
2694
2695         Reviewed by Eric Seidel.
2696
2697         Try again:
2698             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2699             https://bugs.webkit.org/show_bug.cgi?id=59310
2700
2701         * bindings/js/JSDOMBinding.h:
2702         (WebCore::DOMConstructorObject::DOMConstructorObject):
2703         * bindings/js/JSDOMWrapper.h:
2704         (WebCore::JSDOMWrapper::globalObject):
2705         (WebCore::JSDOMWrapper::scriptExecutionContext):
2706         (WebCore::JSDOMWrapper::createStructure):
2707         (WebCore::JSDOMWrapper::JSDOMWrapper):
2708         * bindings/scripts/CodeGeneratorJS.pm:
2709
2710 2011-04-26  Sam Weinig  <sam@webkit.org>
2711
2712         Reviewed by David Hyatt.
2713
2714         Remove Datagrid from the tree
2715         https://bugs.webkit.org/show_bug.cgi?id=59543
2716
2717         * Android.derived.jscbindings.mk:
2718         * Android.derived.v8bindings.mk:
2719         * Android.jscbindings.mk:
2720         * Android.v8bindings.mk:
2721         * CMakeLists.txt:
2722         * CodeGenerators.pri:
2723         * Configurations/FeatureDefines.xcconfig:
2724         * DerivedSources.cpp:
2725         * DerivedSources.make:
2726         * GNUmakefile.am:
2727         * GNUmakefile.list.am:
2728         * UseJSC.cmake:
2729         * WebCore.gypi:
2730         * WebCore.pro:
2731         * WebCore.vcproj/WebCore.vcproj:
2732         * WebCore.xcodeproj/project.pbxproj:
2733         * bindings/js/JSBindingsAllInOne.cpp:
2734         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2735         * bindings/js/JSDataGridDataSource.cpp: Removed.
2736         * bindings/js/JSDataGridDataSource.h: Removed.
2737         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2738         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2739         * bindings/v8/V8DataGridDataSource.h: Removed.
2740         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2741         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2742         * css/CSSStyleSelector.cpp:
2743         * css/CSSStyleSelector.h:
2744         * css/html.css:
2745         (input, textarea, keygen, select, button, isindex):
2746         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2747         * editing/htmlediting.cpp:
2748         (WebCore::canHaveChildrenForEditing):
2749         * features.pri:
2750         * html/DOMDataGridDataSource.cpp: Removed.
2751         * html/DOMDataGridDataSource.h: Removed.
2752         * html/DataGridColumn.cpp: Removed.
2753         * html/DataGridColumn.h: Removed.
2754         * html/DataGridColumn.idl: Removed.
2755         * html/DataGridColumnList.cpp: Removed.
2756         * html/DataGridColumnList.h: Removed.
2757         * html/DataGridColumnList.idl: Removed.
2758         * html/DataGridDataSource.h: Removed.
2759         * html/HTMLDataGridCellElement.cpp: Removed.
2760         * html/HTMLDataGridCellElement.h: Removed.
2761         * html/HTMLDataGridCellElement.idl: Removed.
2762         * html/HTMLDataGridColElement.cpp: Removed.
2763         * html/HTMLDataGridColElement.h: Removed.
2764         * html/HTMLDataGridColElement.idl: Removed.
2765         * html/HTMLDataGridElement.cpp: Removed.
2766         * html/HTMLDataGridElement.h: Removed.
2767         * html/HTMLDataGridElement.idl: Removed.
2768         * html/HTMLDataGridRowElement.cpp: Removed.
2769         * html/HTMLDataGridRowElement.h: Removed.
2770         * html/HTMLDataGridRowElement.idl: Removed.
2771         * html/HTMLElement.cpp:
2772         (WebCore::HTMLElement::ieForbidsInsertHTML):
2773         * html/HTMLElementsAllInOne.cpp:
2774         * html/HTMLTagNames.in:
2775         * page/DOMWindow.idl:
2776         * rendering/RenderBox.cpp:
2777         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2778         * rendering/RenderDataGrid.cpp: Removed.
2779         * rendering/RenderDataGrid.h: Removed.
2780         * rendering/RenderingAllInOne.cpp:
2781
2782 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2783
2784         Reviewed by Adele Peterson.
2785
2786         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2787         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2788
2789         This platform dependent patch makes WebKit (Windows) show the
2790         vertical writing text correctly.  Job was done by adding a prefix '@'
2791         in front of the font family name (Windows Only). No new tests added.
2792         Some layout tests images:
2793         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2794
2795         * platform/graphics/FontPlatformData.h:
2796         * platform/graphics/win/FontCacheWin.cpp:
2797         (WebCore::FontCache::getFontDataForCharacters):
2798         (WebCore::FontCache::createFontPlatformData):
2799         * platform/graphics/win/FontCustomPlatformData.cpp:
2800         (WebCore::FontCustomPlatformData::fontPlatformData):
2801         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2802         (WebCore::FontPlatformData::FontPlatformData):
2803         * platform/graphics/win/FontPlatformDataWin.cpp:
2804         (WebCore::FontPlatformData::FontPlatformData):
2805
2806 2011-04-26  Jer Noble  <jer.noble@apple.com>
2807
2808         Reviewed by Brady Eidson.
2809
2810         HTML5 video fullscreen transition causes an audio stutter
2811         https://bugs.webkit.org/show_bug.cgi?id=59544
2812
2813         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2814         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2815         layer to render it invisible, instead just set the layer as hidden.
2816
2817         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2818         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2819         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2820         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2821         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2822         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2823
2824 2011-04-26  Christian Dywan  <christian@lanedo.com>
2825
2826         Reviewed by Eric Seidel.
2827
2828         Extra separator after Select All in context menu
2829         https://bugs.webkit.org/show_bug.cgi?id=54092
2830
2831         * page/ContextMenuController.cpp: Move separator to non-GTK+
2832             port guards since it is for the spelling options menu
2833             which the GTK+ port doesn't use.
2834
2835 2011-04-26  James Robinson  <jamesr@chromium.org>
2836
2837         Reviewed by Kenneth Russell.
2838
2839         [chromium] Clear out LayerTilerChromium's tiles on lost context
2840         https://bugs.webkit.org/show_bug.cgi?id=59233
2841
2842         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
2843         no longer valid since they exist in the previous LayerRendererChromium.
2844
2845         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
2846
2847         * platform/graphics/chromium/LayerTilerChromium.h:
2848         (WebCore::LayerTilerChromium::setLayerRenderer):
2849
2850 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2851
2852         Reviewed by Dirk Schulze.
2853
2854         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
2855         https://bugs.webkit.org/show_bug.cgi?id=57644
2856
2857         Manual test: plugins/windowed-in-iframe-2.html
2858
2859         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
2860         * platform/gtk/WidgetGtk.cpp:
2861         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
2862         * plugins/PluginView.h: Added helper method to set the allocation and clip.
2863         * plugins/gtk/PluginViewGtk.cpp:
2864         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
2865         the allocation immediately. Bring this method into sync with the implementation in
2866         the Qt port.
2867         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
2868         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
2869
2870 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2871
2872         Reviewed by Eric Seidel.
2873
2874         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
2875         https://bugs.webkit.org/show_bug.cgi?id=58818
2876
2877         Prevent allocating scratch buffers larger than the target GdkDrawable
2878         when creating a WidgetRenderingContext. This prevents incredibly large
2879         widgets from crashing the X Server. This change also allowed greatly
2880         simplifying the way that the painting offset is calculated.
2881
2882         * platform/gtk/WidgetRenderingContext.cpp:
2883         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
2884         larger than the target GdkDrawable.
2885         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
2886         blit by looking at the location of the target rect itself, rather than delaying the
2887         calculation up to this point.
2888         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
2889         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
2890         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
2891         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
2892         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
2893         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
2894         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
2895         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
2896         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
2897         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
2898         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
2899         a member to store the IntSize mapping from the coordinates of the target to the coordinates
2900         of the scratch buffer.
2901
2902 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
2903
2904         Reviewed by Adam Barth.
2905
2906         Respect charset in handleDataURL
2907         https://bugs.webkit.org/show_bug.cgi?id=47746
2908
2909         Original patch by Kwang Yul Seo <skyul@company100.net>
2910
2911         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2912         returns an empty string because encoding name is not specified.
2913
2914         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2915
2916         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2917
2918         * platform/network/DataURL.cpp:
2919         (WebCore::handleDataURL):
2920
2921 2011-04-26  Anders Carlsson  <andersca@apple.com>
2922
2923         Fix clang++ build.
2924
2925         You can never have too many casts!
2926
2927         * accessibility/mac/AccessibilityObjectWrapper.mm:
2928         (-[AccessibilityObjectWrapper position]):
2929         * editing/mac/SelectionControllerMac.mm:
2930         (WebCore::accessibilityConvertScreenRect):
2931
2932 2011-04-26  Chris Rogers  <crogers@google.com>
2933
2934         Reviewed by Kenneth Russell.
2935
2936         Fix web audio build on mac port
2937         https://bugs.webkit.org/show_bug.cgi?id=59355
2938
2939         No new tests since audio API is not yet implemented.
2940
2941         * WebCore.xcodeproj/project.pbxproj:
2942         * bindings/js/JSAudioContextCustom.cpp:
2943         (WebCore::JSAudioContext::visitChildren):
2944         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
2945         (WebCore::JSJavaScriptAudioNode::visitChildren):
2946         * webaudio/AudioContext.idl:
2947
2948 2011-04-26  Chris Rogers  <crogers@google.com>
2949
2950         Reviewed by Kenneth Russell.
2951
2952         Add FFTFrame implementation for FFmpeg
2953         https://bugs.webkit.org/show_bug.cgi?id=59408
2954
2955         No new tests since audio API is not yet implemented.
2956
2957         * WebCore.gyp/WebCore.gyp:
2958         * WebCore.gypi:
2959         * platform/audio/FFTFrame.h:
2960         * platform/audio/FFTFrameStub.cpp:
2961         * platform/audio/ffmpeg: Added.
2962         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
2963         (WebCore::FFTFrame::FFTFrame):
2964         (WebCore::FFTFrame::initialize):
2965         (WebCore::FFTFrame::cleanup):
2966         (WebCore::FFTFrame::~FFTFrame):
2967         (WebCore::FFTFrame::multiply):
2968         (WebCore::FFTFrame::doFFT):
2969         (WebCore::FFTFrame::doInverseFFT):
2970         (WebCore::FFTFrame::realData):
2971         (WebCore::FFTFrame::imagData):
2972         (WebCore::FFTFrame::getUpToDateComplexData):
2973         (WebCore::FFTFrame::contextForSize):
2974         * platform/audio/mac/FFTFrameMac.cpp:
2975         * webaudio/ConvolverNode.cpp:
2976
2977 2011-04-26  Jeff Miller  <jeffm@apple.com>
2978
2979         Add a newline at the end of SVGFEDropShadowElement.idl.
2980
2981         * svg/SVGFEDropShadowElement.idl:
2982
2983 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2984
2985         Reviewed by Eric Seidel.
2986
2987         InlineBox.h shouldn't include RenderBR.h
2988         https://bugs.webkit.org/show_bug.cgi?id=59480
2989
2990         Per bug 59348 RenderBR.h is a "top header" by include * size, because
2991         InlineBox.h includes it. There's no reason why it has to.
2992
2993         * rendering/InlineBox.h:
2994         * rendering/InlineTextBox.cpp:
2995         * rendering/RenderBlock.h:
2996
2997 2011-04-26  Sam Weinig  <sam@webkit.org>
2998
2999         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
3000         I should do.
3001
3002         * bindings/js/JSDOMBinding.h:
3003         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3004         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3005         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3006         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3007         (WebCore::DOMConstructorObject::DOMConstructorObject):
3008         * bindings/js/JSDOMWrapper.h:
3009         (WebCore::JSDOMWrapper::JSDOMWrapper):
3010         * bindings/scripts/CodeGeneratorJS.pm:
3011
3012 2011-04-26  Sam Weinig  <sam@webkit.org>
3013
3014         Fix build.
3015
3016         * bindings/js/JSDOMWrapper.h:
3017         (WebCore::JSDOMWrapper::globalObject):
3018
3019 2011-04-26  Sam Weinig  <sam@webkit.org>
3020
3021         Roll r84945 back in with infinite recursion removed.
3022
3023         * bindings/js/JSDOMBinding.h:
3024         (WebCore::DOMConstructorObject::DOMConstructorObject):
3025         * bindings/js/JSDOMWrapper.h:
3026         (WebCore::JSDOMWrapper::globalObject):
3027         (WebCore::JSDOMWrapper::scriptExecutionContext):
3028         (WebCore::JSDOMWrapper::createStructure):
3029         (WebCore::JSDOMWrapper::JSDOMWrapper):
3030         * bindings/scripts/CodeGeneratorJS.pm:
3031
3032 2011-04-26  Sam Weinig  <sam@webkit.org>
3033
3034         Rollout previous patch. It broke stuff.
3035
3036         * bindings/js/JSDOMBinding.h:
3037         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3038         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3039         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3040         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3041         (WebCore::DOMConstructorObject::DOMConstructorObject):
3042         * bindings/js/JSDOMWrapper.h:
3043         (WebCore::JSDOMWrapper::JSDOMWrapper):
3044         * bindings/scripts/CodeGeneratorJS.pm:
3045
3046 2011-04-26  Sam Weinig  <sam@webkit.org>
3047
3048         Reviewed by Maciej Stachowiak.
3049
3050         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
3051         https://bugs.webkit.org/show_bug.cgi?id=59310
3052
3053         * bindings/js/JSDOMBinding.h:
3054         (WebCore::DOMConstructorObject::DOMConstructorObject):
3055         * bindings/js/JSDOMWrapper.h:
3056         (WebCore::JSDOMWrapper::globalObject):
3057         (WebCore::JSDOMWrapper::scriptExecutionContext):
3058         (WebCore::JSDOMWrapper::createStructure):
3059         (WebCore::JSDOMWrapper::JSDOMWrapper):
3060         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
3061
3062         * bindings/scripts/CodeGeneratorJS.pm:
3063         Make JSDOMWrapper the base class.
3064
3065 2011-04-26  Dan Bernstein  <mitz@apple.com>
3066
3067         Reviewed by Mark Rowe.
3068
3069         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
3070
3071         * Configurations/Base.xcconfig:
3072         * Configurations/CompilerVersion.xcconfig: Added.
3073
3074 2011-04-26  Adrienne Walker  <enne@google.com>
3075
3076         Reviewed by Geoffrey Garen.
3077
3078         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
3079         https://bugs.webkit.org/show_bug.cgi?id=59469
3080
3081         * platform/chromium/TraceEvent.h:
3082         (WebCore::internal::ScopeTracer::ScopeTracer):
3083
3084 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3085
3086         Reviewed by Oliver Hunt.
3087
3088         Nixed special finalizer handling for WebCore strings
3089         https://bugs.webkit.org/show_bug.cgi?id=59425
3090
3091         Not needed anymore, since weak handles have finalizers.
3092
3093         * WebCore.exp.in: Exports!
3094
3095         * bindings/js/DOMWrapperWorld.cpp:
3096         (WebCore::JSStringOwner::finalize):
3097         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
3098         so we don't need special treatment anymore.
3099
3100         * bindings/js/DOMWrapperWorld.h:
3101         (WebCore::JSStringOwner::JSStringOwner):
3102         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
3103         instead of a WeakGCMap, so we can specify a custom finalizer.
3104
3105         * bindings/js/JSDOMBinding.cpp:
3106         (WebCore::jsStringSlowCase):
3107         * bindings/js/JSDOMBinding.h:
3108         (WebCore::jsString): Updated for string map change.
3109
3110 2011-04-26  David Kilzer  <ddkilzer@apple.com>
3111
3112         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
3113
3114         Reviewed by Antti Koivisto.
3115
3116         To enable HTTP pipelining post-SnowLeopard, use this command:
3117
3118             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
3119
3120         * platform/network/cf/ResourceRequestCFNet.cpp:
3121         (WebCore::readBooleanPreference): Re-added.  Originally added in
3122         r76756 and removed in r84120.
3123         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
3124         HTTP pipelining if use default is set to true.  Added macro
3125         guards to match those in ResourceRequestMac.mm.
3126
3127 2011-04-26  Antti Koivisto  <antti@apple.com>
3128
3129         Reviewed by Adele Peterson.
3130
3131         Don't strip fragments from file: urls in memory cache
3132         https://bugs.webkit.org/show_bug.cgi?id=59463
3133         <rdar://problem/9231130>
3134
3135         Some clients expect file: resources to be unique based on fragment identifier. 
3136         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
3137
3138         Test: fast/loader/file-protocol-fragment.html
3139
3140         * loader/cache/MemoryCache.cpp:
3141         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
3142
3143 2011-04-26  David Levin  <levin@chromium.org>
3144
3145         Reviewed by Darin Adler.
3146
3147         Fix more strict OwnPtr in WebCore (round N).
3148         https://bugs.webkit.org/show_bug.cgi?id=59464
3149
3150         * dom/Document.cpp:
3151         (WebCore::Document::Document):
3152         (WebCore::Document::attach):
3153         * fileapi/FileReader.cpp:
3154         (WebCore::FileReader::terminate):
3155         * loader/DocumentThreadableLoader.cpp:
3156         (WebCore::DocumentThreadableLoader::preflightFailure):
3157         * workers/DefaultSharedWorkerRepository.cpp:
3158         (WebCore::SharedWorkerConnectTask::create):
3159         (WebCore::SharedWorkerScriptLoader::load):
3160
3161 2011-04-26  Ruben  <chromium@hybridsource.org>
3162
3163         Reviewed by Tony Chang.
3164
3165         Change linux ifdefs for Chromium to Unix instead, allowing
3166         new Unix ports to be enabled by default
3167         https://bugs.webkit.org/show_bug.cgi?id=59297
3168
3169         No new tests, just changing preprocessor defines.
3170
3171         * bindings/js/JSInspectorFrontendHostCustom.cpp:
3172         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
3173         * dom/SelectElement.cpp:
3174         * loader/cache/CachedFont.cpp:
3175         * page/EventHandler.cpp:
3176         * page/chromium/EventHandlerChromium.cpp:
3177         * platform/Scrollbar.cpp:
3178         * platform/chromium/PlatformBridge.h:
3179         * platform/graphics/chromium/FontPlatformData.h:
3180         * platform/graphics/skia/FontCustomPlatformData.cpp:
3181         * platform/graphics/skia/FontCustomPlatformData.h:
3182
3183 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3184
3185         Reviewed by Dan Bernstein.
3186
3187         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
3188         https://bugs.webkit.org/show_bug.cgi?id=49111
3189
3190         Even when the offset corresponds to a position visually left of the box
3191         and there aren't any inline boxes on the left, the previous/next position
3192         may still correspond to some position in the same line.
3193
3194         The bug was caused by our ignoring such cases. Fixed the bug by comparing
3195         previous/next position's inline box to the current box. If they match,
3196         then we stay on the same position because moving to the left visually at
3197         the left edge should not result in a position on the same line.
3198
3199         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
3200         the left edge or to the right edge, and a bug that WebKit could not move to
3201         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
3202
3203         Test cases are added to editing/selection/move-left-right.html
3204
3205         * editing/VisiblePosition.cpp:
3206         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
3207         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
3208
3209 2011-04-26  Gabor Loki  <loki@webkit.org>
3210
3211         Reviewed by Csaba Osztrogonác.
3212
3213         Speeding up SVG filters with multicore (SMP) support
3214         https://bugs.webkit.org/show_bug.cgi?id=43903
3215
3216         Some SVG filters execute a huge number of pixel manipulations, which
3217         cannot be sped up by graphics accelerators, since their algorithm is
3218         too complex. Using the power of Symmetric Multi Processing (SMP) we
3219         can split up a task to smaller (data independent) tasks, which can be
3220         executed independently.
3221
3222         The ParallelJobs framework provides a simple way for distributed
3223         programming. The framework is based on WebKit's threading infrastructure,
3224         Open Multi-Processing's (OpenMP) API, and libdispatch API.
3225
3226         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
3227         * platform/graphics/filters/FETurbulence.cpp:
3228         (WebCore::FETurbulence::PaintingData::PaintingData):
3229         (WebCore::FETurbulence::noise2D):
3230         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
3231         (WebCore::FETurbulence::fillRegion):
3232         (WebCore::FETurbulence::fillRegionWorker):
3233         (WebCore::FETurbulence::apply):
3234         * platform/graphics/filters/FETurbulence.h:
3235
3236 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3237
3238         Reviewed by Yury Semikhatsky.
3239
3240         Web Inspector: close button is off in docked mode on a mac.
3241         https://bugs.webkit.org/show_bug.cgi?id=59453
3242
3243         * inspector/front-end/inspector.css:
3244         (.toolbar-item.close-left):
3245
3246 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3247
3248         Reviewed by Yury Semikhatsky.
3249
3250         Web Inspector: New Style is not working (UI glitch)
3251         https://bugs.webkit.org/show_bug.cgi?id=59451
3252
3253         * inspector/InspectorDOMStorageAgent.cpp:
3254         (WebCore::InspectorDOMStorageAgent::setFrontend):
3255         * inspector/front-end/AuditRules.js:
3256         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
3257         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
3258         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
3259         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
3260         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
3261         * inspector/front-end/CSSStyleModel.js:
3262         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
3263         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
3264         (WebInspector.CSSStyleModel.prototype.addRule):
3265         (WebInspector.CSSStyleModel.prototype.addRule.callback):
3266         (WebInspector.CSSStyleModel.prototype._documentElementId):
3267         * inspector/front-end/DOMAgent.js:
3268         (WebInspector.DOMNode.prototype._addAttribute):
3269         (WebInspector.DOMNode.prototype.documentElement):
3270         * inspector/front-end/ResourceTreeModel.js:
3271         (WebInspector.PageDispatcher.prototype.frameDetached):
3272         * inspector/front-end/StylesSidebarPane.js:
3273         (WebInspector.StylesSidebarPane.prototype._createNewRule):
3274
3275 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3276
3277         Reviewed by Yury Semikhatsky.
3278
3279         Web Inspector: introduce DOMStorage::enable and disable.
3280         https://bugs.webkit.org/show_bug.cgi?id=59445
3281
3282         * inspector/Inspector.json:
3283         * inspector/InspectorAgent.cpp:
3284         (WebCore::InspectorAgent::InspectorAgent):
3285         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3286         * inspector/InspectorDOMStorageAgent.cpp:
3287         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
3288         (WebCore::InspectorDOMStorageAgent::restore):
3289         (WebCore::InspectorDOMStorageAgent::enable):
3290         (WebCore::InspectorDOMStorageAgent::disable):
3291         * inspector/InspectorDOMStorageAgent.h:
3292         (WebCore::InspectorDOMStorageAgent::create):
3293         * inspector/front-end/DOMStorage.js:
3294         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3295         * inspector/front-end/ResourcesPanel.js:
3296         (WebInspector.ResourcesPanel.prototype._reset):
3297         * inspector/front-end/inspector.js:
3298
3299 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3300
3301         Reviewed by Yury Semikhatsky.
3302
3303         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
3304         https://bugs.webkit.org/show_bug.cgi?id=59440
3305
3306         * inspector/Inspector.json:
3307         * inspector/InspectorAgent.cpp:
3308         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3309         * inspector/InspectorPageAgent.cpp:
3310         (WebCore::InspectorPageAgent::setFrontend):
3311         (WebCore::InspectorPageAgent::frameNavigated):
3312         * inspector/InspectorPageAgent.h:
3313         * inspector/front-end/AuditsPanel.js:
3314         (WebInspector.AuditsPanel):
3315         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
3316         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
3317         * inspector/front-end/CSSStyleModel.js:
3318         (WebInspector.CSSStyleModelResourceBinding):
3319         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
3320         * inspector/front-end/DOMBreakpointsSidebarPane.js:
3321         (WebInspector.DOMBreakpointsSidebarPane):
3322         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
3323         * inspector/front-end/DOMStorage.js:
3324         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3325         * inspector/front-end/ExtensionServer.js:
3326         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
3327         (WebInspector.ExtensionServer.prototype.initExtensions):
3328         * inspector/front-end/NetworkPanel.js:
3329         (WebInspector.NetworkPanel):
3330         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
3331         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
3332         (WebInspector.NetworkPanel.prototype._frameNavigated):
3333         * inspector/front-end/ResourceTreeModel.js:
3334         (WebInspector.ResourceTreeModel):
3335         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
3336         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
3337         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
3338         (WebInspector.ResourceTreeModel.prototype._frameDetached):
3339         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
3340         (WebInspector.PageDispatcher):
3341         (WebInspector.PageDispatcher.prototype.domContentEventFired):
3342         (WebInspector.PageDispatcher.prototype.loadEventFired):
3343         (WebInspector.PageDispatcher.prototype.frameNavigated):
3344         (WebInspector.PageDispatcher.prototype.frameDetached):
3345         * inspector/front-end/ResourcesPanel.js:
3346         (WebInspector.ResourcesPanel):
3347         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
3348         (WebInspector.ResourcesPanel.prototype._frameNavigated):
3349         * inspector/front-end/inspector.js:
3350
3351 2011-04-26  Csaba Osztrogonác  <ossy@webkit.org>
3352
3353         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
3354         because it broke transitions/multiple-text-shadow-transition.html
3355
3356         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3357         https://bugs.webkit.org/show_bug.cgi?id=59377
3358
3359         * css/CSSStyleSelector.cpp:
3360         (WebCore::CSSStyleSelector::applyProperty):
3361         * page/animation/AnimationBase.cpp:
3362         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3363         (WebCore::PropertyWrapperShadow::blend):
3364         * rendering/style/RenderStyle.cpp:
3365         (WebCore::RenderStyle::setTextShadow):
3366         (WebCore::RenderStyle::setBoxShadow):
3367         * rendering/style/RenderStyle.h:
3368         (WebCore::InheritedFlags::textShadow):
3369         * rendering/style/StyleRareInheritedData.cpp:
3370         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3371         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3372         * rendering/style/StyleRareInheritedData.h:
3373         * rendering/style/StyleRareNonInheritedData.cpp:
3374         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3375
3376 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
3377
3378         Reviewed by Adam Barth.
3379
3380         Turn off make built-in implicit rules for derived sources makefile
3381         https://bugs.webkit.org/show_bug.cgi?id=59418
3382
3383         We don't use any of make's built-in implicit rules, turning them off
3384         speeds up parsing of the makefile.
3385
3386         * WebCore.xcodeproj/project.pbxproj:
3387         * gyp/generate-derived-sources.sh:
3388
3389 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
3390
3391         Reviewed by Nikolas Zimmermann.
3392
3393         ASSERT failure in SVGUseElement
3394         https://bugs.webkit.org/show_bug.cgi?id=59313
3395
3396         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3397         was wrong because the document may not be well-formed.
3398
3399         This patch asserts the element is not pending on resource or the
3400         document is not well-formed.
3401
3402         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3403
3404         * svg/SVGUseElement.cpp:
3405         (WebCore::isWellFormedDocument):
3406         (WebCore::SVGUseElement::insertedIntoDocument):
3407
3408 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
3409
3410         Reviewed by Pavel Feldman.
3411
3412         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
3413         https://bugs.webkit.org/show_bug.cgi?id=59438
3414
3415         * inspector/front-end/DetailedHeapshotView.js:
3416         (WebInspector.DetailedHeapshotView.prototype._changeView):
3417
3418 2011-04-26  David Levin  <levin@chromium.org>
3419
3420         Reviewed by Adam Barth.
3421
3422         Fix a few OwnPtr strict errors in WebCore headers.
3423         https://bugs.webkit.org/show_bug.cgi?id=59431
3424
3425         * bindings/js/ScheduledAction.cpp:
3426         (WebCore::ScheduledAction::create):
3427         * css/MediaQueryMatcher.cpp:
3428         (WebCore::MediaQueryMatcher::prepareEvaluator):
3429         * dom/NodeRareData.h:
3430         (WebCore::NodeListsNodeData::create):
3431         * dom/ScriptRunner.h:
3432         (WebCore::ScriptRunner::create):
3433         * inspector/WorkerInspectorController.cpp:
3434         (WebCore::WorkerInspectorController::connectFrontend):
3435         * loader/icon/IconDatabase.h:
3436         (WebCore::IconDatabase::create):
3437         * platform/graphics/SimpleFontData.cpp:
3438         (WebCore::SimpleFontData::verticalRightOrientationFontData):
3439         (WebCore::SimpleFontData::uprightOrientationFontData):
3440         (WebCore::SimpleFontData::brokenIdeographFontData):
3441         * rendering/style/StyleRareInheritedData.cpp:
3442         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3443         * rendering/svg/SVGResources.h:
3444         (WebCore::SVGResources::ClipperFilterMaskerData::create):
3445         (WebCore::SVGResources::MarkerData::create):
3446         (WebCore::SVGResources::FillStrokeData::create):
3447         * storage/StorageSyncManager.cpp:
3448         (WebCore::StorageSyncManager::close):
3449         * workers/WorkerContext.cpp:
3450         (WebCore::CloseWorkerContextTask::create):
3451         * workers/WorkerMessagingProxy.cpp:
3452         (WebCore::MessageWorkerContextTask::create):
3453         (WebCore::MessageWorkerTask::create):
3454         (WebCore::WorkerExceptionTask::create):
3455         (WebCore::WorkerContextDestroyedTask::create):
3456         (WebCore::WorkerTerminateTask::create):
3457         (WebCore::WorkerThreadActivityReportTask::create):
3458         * workers/WorkerRunLoop.cpp:
3459         (WebCore::WorkerRunLoop::Task::create):
3460         * workers/WorkerThread.cpp:
3461         (WebCore::WorkerThreadStartupData::create):
3462         (WebCore::WorkerThreadShutdownFinishTask::create):
3463         (WebCore::WorkerThreadShutdownStartTask::create):
3464
3465 2011-04-26  Adam Klein  <adamk@chromium.org>
3466
3467         Reviewed by Adam Barth.
3468
3469         Fix last strict OwnPtr violation under svg/...
3470         https://bugs.webkit.org/show_bug.cgi?id=59429
3471
3472         * svg/SVGDocumentExtensions.cpp:
3473         (WebCore::SVGDocumentExtensions::removePendingResource):
3474
3475 2011-04-26  Adam Barth  <abarth@webkit.org>
3476
3477         Reviewed by David Levin.
3478
3479         Fix more strict OwnPtr violations in WebCore
3480         https://bugs.webkit.org/show_bug.cgi?id=59433
3481
3482         These manifest in the Chromium build.
3483
3484         * bindings/v8/ScriptController.cpp:
3485         (WebCore::ScriptController::ScriptController):
3486         * bindings/v8/ScriptDebugServer.cpp:
3487         (WebCore::ScriptDebugServer::editScriptSource):
3488         * bindings/v8/V8DOMMap.cpp:
3489         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
3490         * bindings/v8/V8Proxy.cpp:
3491         (WebCore::V8Proxy::precompileScript):
3492         * bindings/v8/WorkerScriptController.cpp:
3493         (WebCore::WorkerScriptController::WorkerScriptController):
3494         * page/Page.cpp:
3495         (WebCore::Page::Page):
3496         (WebCore::Page::speechInput):
3497         * platform/PlatformGestureRecognizer.cpp:
3498         (WebCore::PlatformGestureRecognizer::create):
3499         * platform/PlatformGestureRecognizer.h:
3500         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3501         (WebCore::DrawingBuffer::DrawingBuffer):
3502         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3503         (WebCore::CCLayerImpl::CCLayerImpl):
3504         * platform/graphics/gpu/Texture.cpp:
3505         (WebCore::Texture::create):
3506         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
3507         (WebCore::BMPImageDecoder::decodeHelper):
3508         * platform/image-decoders/gif/GIFImageDecoder.cpp:
3509         (WebCore::GIFImageDecoder::decode):
3510         * platform/image-decoders/ico/ICOImageDecoder.cpp:
3511         (WebCore::ICOImageDecoder::decodeAtIndex):
3512         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3513         (WebCore::JPEGImageDecoder::decode):
3514         * platform/image-decoders/png/PNGImageDecoder.cpp:
3515         (WebCore::PNGImageDecoder::decode):
3516         * storage/chromium/DatabaseTrackerChromium.cpp:
3517         (WebCore::DatabaseTracker::addOpenDatabase):
3518
3519 2011-04-25  David Levin  <levin@chromium.org>
3520
3521         Reviewed by Adam Barth.
3522
3523         Fix OwnPtr strict errors in CrossThreadTask.h
3524         https://bugs.webkit.org/show_bug.cgi?id=59427
3525
3526         * dom/CrossThreadTask.h:
3527         (WebCore::CrossThreadTask1::create):
3528         (WebCore::CrossThreadTask2::create):
3529         (WebCore::CrossThreadTask3::create):
3530         (WebCore::CrossThreadTask4::create):
3531         (WebCore::CrossThreadTask5::create):
3532         (WebCore::CrossThreadTask6::create):
3533         (WebCore::CrossThreadTask7::create):
3534         (WebCore::CrossThreadTask8::create):
3535
3536 2011-04-25  Mark Rowe  <mrowe@apple.com>
3537
3538         Reviewed by Dan Bernstein.
3539
3540         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
3541
3542         * css/CSSStyleApplyProperty.cpp:
3543         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
3544         * css/CSSStyleApplyProperty.h:
3545         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
3546
3547 2011-04-25  Levi Weintraub  <leviw@chromium.org>
3548
3549         Reviewed by Ryosuke Niwa.
3550
3551         REGRESSION: a character appears after tab span when typing immediately before the tab span
3552         https://bugs.webkit.org/show_bug.cgi?id=58132
3553
3554         Correcting the order of operations we use to avoid inserting into invalid positions in
3555         ReplaceSelectionCommand to avoid inserting into tab-spans.
3556
3557         Test: editing/pasteboard/paste-before-tab-span.html
3558
3559         * editing/ReplaceSelectionCommand.cpp:
3560         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
3561         positionAvoidingPrecedingNodes, since that function could once again put our position
3562         inside a tab span.
3563
3564 2011-04-25  David Levin  <levin@chromium.org>
3565
3566         Reviewed by Adam Barth.
3567
3568         Fix OwnPtr strict error in ImageBuffer.h
3569         https://bugs.webkit.org/show_bug.cgi?id=59422
3570
3571         * platform/graphics/ImageBuffer.h:
3572         (WebCore::ImageBuffer::create):
3573
3574 2011-04-25  Adam Barth  <abarth@webkit.org>
3575
3576         Reviewed by David Levin.
3577
3578         Fix strict OwnPtr violations and whitelist known-tricky files
3579         https://bugs.webkit.org/show_bug.cgi?id=59421
3580
3581         With this patch, WebCore builds cleanly with strict OwnPtrs.
3582
3583         * dom/MessagePort.cpp:
3584         (WebCore::MessagePort::MessagePort):
3585         * dom/XMLDocumentParserLibxml2.cpp:
3586         * page/ContextMenuController.cpp:
3587         (WebCore::ContextMenuController::ContextMenuController):
3588         (WebCore::ContextMenuController::clearContextMenu):
3589         * page/PluginHalter.cpp:
3590         * platform/graphics/MediaPlayer.cpp:
3591         * platform/network/ResourceRequestBase.cpp:
3592         (WebCore::ResourceRequestBase::adopt):
3593         (WebCore::ResourceRequestBase::copyData):
3594         * svg/SVGDocumentExtensions.cpp:
3595
3596 2011-04-25  David Levin  <levin@chromium.org>
3597
3598         Reviewed by Adam Barth.
3599
3600         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
3601         https://bugs.webkit.org/show_bug.cgi?id=59419
3602
3603         * dom/DatasetDOMStringMap.h:
3604         (WebCore::DatasetDOMStringMap::create):
3605
3606 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3607
3608         Reviewed by Eric Seidel.
3609
3610         KeyboardEvent.cpp should work with strict OwnPtrs.
3611         https://bugs.webkit.org/show_bug.cgi?id=59403
3612
3613         * dom/KeyboardEvent.cpp:
3614         (WebCore::KeyboardEvent::KeyboardEvent):
3615
3616 2011-04-25  James Robinson  <jamesr@chromium.org>
3617
3618         Reviewed by Eric Seidel.
3619
3620         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3621         https://bugs.webkit.org/show_bug.cgi?id=59377
3622
3623         * css/CSSStyleSelector.cpp:
3624         (WebCore::CSSStyleSelector::applyProperty):
3625         * page/animation/AnimationBase.cpp:
3626         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3627         (WebCore::PropertyWrapperShadow::blend):
3628         * rendering/style/RenderStyle.cpp:
3629         (WebCore::RenderStyle::setTextShadow):
3630         (WebCore::RenderStyle::setBoxShadow):
3631         * rendering/style/RenderStyle.h:
3632         (WebCore::InheritedFlags::textShadow):
3633         * rendering/style/StyleRareInheritedData.cpp:
3634         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3635         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3636         * rendering/style/StyleRareInheritedData.h:
3637         * rendering/style/StyleRareNonInheritedData.cpp:
3638         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3639
3640 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3641
3642         Unreviewed, rolling out r84864.
3643         http://trac.webkit.org/changeset/84864
3644         https://bugs.webkit.org/show_bug.cgi?id=59413
3645
3646         Expect result of use-crash-in-non-wellformed-document.svg is
3647         platform dependent (Requested by leoyang on #webkit).
3648
3649         * svg/SVGUseElement.cpp:
3650         (WebCore::SVGUseElement::insertedIntoDocument):
3651
3652 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
3653
3654         Reviewed by Nikolas Zimmermann.
3655
3656         ASSERT failure in SVGUseElement
3657         https://bugs.webkit.org/show_bug.cgi?id=59313
3658
3659         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3660         was wrong because the document may not be well-formed.
3661
3662         This patch asserts the element is not pending on resource or the
3663         document is not well-formed.
3664
3665         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3666
3667         * svg/SVGUseElement.cpp:
3668         (WebCore::isWellFormedDocument):
3669         (WebCore::SVGUseElement::insertedIntoDocument):
3670
3671 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3672
3673         Reviewed by Tony Chang.
3674
3675         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3676         https://bugs.webkit.org/show_bug.cgi?id=59028
3677
3678         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3679         Moving the code for base class we can reduce the efforts to support DataTransferItems
3680         element in different platforms.
3681
3682         * Android.mk:
3683         * CMakeLists.txt:
3684         * GNUmakefile.list.am:
3685         * WebCore.gypi:
3686         * WebCore.pro:
3687         * WebCore.vcproj/WebCore.vcproj:
3688         * WebCore.xcodeproj/project.pbxproj:
3689         * dom/DataTransferItem.cpp:
3690         (WebCore::DataTransferItem::DataTransferItem):
3691         (WebCore::DataTransferItem::owner):
3692         (WebCore::DataTransferItem::kind):
3693         (WebCore::DataTransferItem::type):
3694         * dom/DataTransferItem.h:
3695         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3696         (WebCore::DataTransferItems::DataTransferItems):
3697         (WebCore::DataTransferItems::length):
3698         (WebCore::DataTransferItems::item):
3699         (WebCore::DataTransferItems::deleteItem):
3700         (WebCore::DataTransferItems::clear):
3701         (WebCore::DataTransferItems::add):
3702         * dom/DataTransferItems.h:
3703         * platform/chromium/DataTransferItemChromium.cpp:
3704         (WebCore::DataTransferItem::create):
3705         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3706         (WebCore::DataTransferItemChromium::getAsString):
3707         (WebCore::DataTransferItemChromium::getAsFile):
3708         * platform/chromium/DataTransferItemChromium.h:
3709         * platform/chromium/DataTransferItemsChromium.cpp:
3710         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3711         * platform/chromium/DataTransferItemsChromium.h:
3712
3713 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3714
3715         Reviewed by Simon Fraser.
3716
3717         REGRESSION(75137): directly composited images are double-drawn sometimes
3718         https://bugs.webkit.org/show_bug.cgi?id=58632
3719
3720         Depending on the order of operations (layout, creating compositing 
3721         layers and creating simple image layers) a layer can have both image
3722         content and have m_drawsContent=true. In this case 2 copies of the image
3723         are drawn in the layer. If the image has alpha, it looks wrong.
3724
3725         I added an updateDrawsContent() call after setting the image contents
3726         to make sure it's correct.
3727
3728         I couldn't create a test case that shows the problem because layerTreeAsText()
3729         doesn't emit enough info to show this level of detail. I've opened
3730         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3731
3732         * rendering/RenderLayerBacking.cpp:
3733         (WebCore::RenderLayerBacking::updateImageContents):
3734
3735 2011-04-25  Kenneth Russell  <kbr@google.com>
3736
3737         Reviewed by David Levin.
3738
3739         Fix OwnPtr strict errors in InlineFlowBox.cpp
3740         https://bugs.webkit.org/show_bug.cgi?id=59392
3741
3742         * rendering/InlineFlowBox.cpp:
3743         (WebCore::InlineFlowBox::setLayoutOverflow):
3744         (WebCore::InlineFlowBox::setVisualOverflow):
3745
3746 2011-04-25  Kenneth Russell  <kbr@google.com>
3747
3748         Reviewed by David Levin.
3749
3750         Fix OwnPtr strict errors in TransformState.cpp
3751         https://bugs.webkit.org/show_bug.cgi?id=59380
3752
3753         * rendering/TransformState.cpp:
3754         (WebCore::TransformState::applyTransform):
3755
3756 2011-04-25  Adam Barth  <abarth@webkit.org>
3757
3758         Reviewed by James Robinson.
3759
3760         DOMWindow.cpp should work with strict OwnPtrs
3761         https://bugs.webkit.org/show_bug.cgi?id=59356
3762
3763         * page/DOMWindow.cpp:
3764         (WebCore::PostMessageTimer::fired):
3765         (WebCore::DOMWindow::postMessageTimerFired):
3766         * page/DOMWindow.h:
3767
3768 2011-04-25  Adam Klein  <adamk@chromium.org>
3769
3770         Reviewed by James Robinson.
3771
3772         Fix OwnPtr strict errors in some SVG classes.
3773         https://bugs.webkit.org/show_bug.cgi?id=59395
3774
3775         * rendering/style/SVGRenderStyleDefs.cpp:
3776         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3777         * svg/SVGSVGElement.cpp:
3778         (WebCore::SVGSVGElement::SVGSVGElement):
3779         * svg/SVGStyledTransformableElement.cpp:
3780         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3781         * svg/SVGTextElement.cpp:
3782         (WebCore::SVGTextElement::supplementalTransform):
3783         * svg/graphics/SVGImage.cpp:
3784         (WebCore::SVGImage::dataChanged):
3785
3786 2011-04-25  Adam Barth  <abarth@webkit.org>
3787
3788         Re-land changes to ValidationMessage.
3789
3790         * html/ValidationMessage.cpp:
3791         (WebCore::ValidationMessage::setMessage):
3792         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3793         (WebCore::ValidationMessage::requestToHideMessage):
3794
3795 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3796
3797         Reviewed by James Robinson.
3798
3799         fix OwnPtr strict error in FrameView.cpp
3800         https://bugs.webkit.org/show_bug.cgi?id=59402
3801
3802         * page/FrameView.cpp:
3803         (WebCore::FrameView::FrameView):
3804         (WebCore::FrameView::addWidgetToUpdate):
3805
3806 2011-04-25  Adam Klein  <adamk@chromium.org>
3807
3808         Unreviewed, rolling out r84844.
3809         http://trac.webkit.org/changeset/84844
3810         https://bugs.webkit.org/show_bug.cgi?id=59395
3811
3812         Checked in too much.
3813
3814         * rendering/style/SVGRenderStyleDefs.cpp:
3815         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3816         * svg/SVGDocumentExtensions.cpp:
3817         (WebCore::SVGDocumentExtensions::removePendingResource):
3818         * svg/SVGSVGElement.cpp:
3819         (WebCore::SVGSVGElement::SVGSVGElement):
3820         * svg/SVGStyledTransformableElement.cpp:
3821         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3822         * svg/SVGTextElement.cpp:
3823         (WebCore::SVGTextElement::supplementalTransform):
3824         * svg/graphics/SVGImage.cpp:
3825         (WebCore::SVGImage::dataChanged):
3826
3827 2011-04-25  Adrienne Walker  <enne@google.com>
3828
3829         Reviewed by David Levin.
3830
3831         Make ActiveDOMCallback play nice with OwnPtr strict mode
3832         https://bugs.webkit.org/show_bug.cgi?id=59398
3833
3834         * bindings/generic/ActiveDOMCallback.cpp:
3835         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
3836
3837 2011-04-25  Adam Klein  <adamk@chromium.org>
3838
3839         Reviewed by James Robinson.
3840
3841         Fix OwnPtr strict errors in some SVG classes.
3842         https://bugs.webkit.org/show_bug.cgi?id=59395
3843
3844         * rendering/style/SVGRenderStyleDefs.cpp:
3845         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3846         * svg/SVGSVGElement.cpp:
3847         (WebCore::SVGSVGElement::SVGSVGElement):
3848         * svg/SVGStyledTransformableElement.cpp:
3849         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3850         * svg/SVGTextElement.cpp:
3851         (WebCore::SVGTextElement::supplementalTransform):
3852         * svg/graphics/SVGImage.cpp:
3853         (WebCore::SVGImage::dataChanged):
3854
3855 2011-04-25  James Robinson  <jamesr@chromium.org>
3856
3857         Unreviewed, rolling out r84835.
3858         http://trac.webkit.org/changeset/84835
3859         https://bugs.webkit.org/show_bug.cgi?id=59394
3860
3861         Breaks compile because Deque<OwnPtr> doesn't work
3862
3863         * dom/XMLDocumentParserLibxml2.cpp:
3864         (WebCore::PendingCallbacks::~PendingCallbacks):
3865         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3866         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3867         (WebCore::PendingCallbacks::appendCharactersCallback):
3868         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3869         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3870         (WebCore::PendingCallbacks::appendCommentCallback):
3871         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3872         (WebCore::PendingCallbacks::appendErrorCallback):
3873         (WebCore::XMLDocumentParser::XMLDocumentParser):
3874         * html/ValidationMessage.cpp:
3875         (WebCore::ValidationMessage::setMessage):
3876         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3877         (WebCore::ValidationMessage::requestToHideMessage):
3878
3879 2011-04-25  James Robinson  <jamesr@chromium.org>
3880
3881         Reviewed by Sam Weinig.
3882
3883         Fix OwnPtr strict mode violation in ImageBufferCG
3884         https://bugs.webkit.org/show_bug.cgi?id=59396
3885
3886         * platform/graphics/cg/ImageBufferCG.cpp:
3887         (WebCore::ImageBuffer::ImageBuffer):
3888
3889 2011-04-25  Huang Dongsung  <luxtella@company100.net>
3890
3891         Reviewed by Dirk Schulze.
3892
3893         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
3894         https://bugs.webkit.org/show_bug.cgi?id=59308
3895
3896         An unused local variable is created and even allocates heap memory.
3897
3898         * platform/graphics/skia/PlatformContextSkia.cpp:
3899         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
3900
3901 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3902
3903         Qt build fix: Updated files not used by other ports for rename.
3904
3905         * bindings/js/JSTouchCustom.cpp:
3906         (WebCore::toJSNewlyCreated):
3907         * bindings/js/JSTouchListCustom.cpp:
3908         (WebCore::toJSNewlyCreated):
3909
3910 2011-04-25  Adrienne Walker  <enne@google.com>
3911
3912         Reviewed by David Levin.
3913
3914         WebCore/css/CSS* files should play nice with strict OwnPtrs
3915         https://bugs.webkit.org/show_bug.cgi?id=59382
3916
3917         * css/CSSFontFaceSource.cpp:
3918         (WebCore::CSSFontFaceSource::getFontData):
3919         * css/CSSParser.cpp:
3920         (WebCore::CSSParser::addProperty):
3921         (WebCore::CSSParser::parseValue):
3922
3923 2011-04-25  Adam Barth  <abarth@webkit.org>
3924
3925         Reviewed by James Robinson.
3926
3927         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
3928         https://bugs.webkit.org/show_bug.cgi?id=59394
3929
3930         * dom/XMLDocumentParserLibxml2.cpp:
3931         (WebCore::PendingCallbacks::PendingCallbacks):
3932         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3933         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3934         (WebCore::PendingCallbacks::appendCharactersCallback):
3935         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3936         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3937         (WebCore::PendingCallbacks::appendCommentCallback):
3938         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3939         (WebCore::PendingCallbacks::appendErrorCallback):
3940         (WebCore::XMLDocumentParser::XMLDocumentParser):
3941         * html/ValidationMessage.cpp:
3942         (WebCore::ValidationMessage::setMessage):
3943         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3944         (WebCore::ValidationMessage::requestToHideMessage):
3945
3946 2011-04-25  James Robinson  <jamesr@chromium.org>
3947
3948         Reviewed by Adam Barth.
3949
3950         Fix OwnPtr strictness issues in WebCore/inspector/
3951         https://bugs.webkit.org/show_bug.cgi?id=59387
3952
3953         * inspector/InspectorAgent.cpp:
3954         (WebCore::InspectorAgent::InspectorAgent):
3955         * inspector/InspectorController.cpp:
3956         (WebCore::InspectorController::InspectorController):
3957         * inspector/InspectorStyleSheet.cpp:
3958         (WebCore::InspectorStyleSheet::ensureSourceData):
3959
3960 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3961
3962         Reviewed by Beth Dakin.
3963
3964         Removed XPathNamespace because it was unused
3965         https://bugs.webkit.org/show_bug.cgi?id=59381
3966         
3967         This allows us to make Node::ownerDocument() non-virtual, though it has
3968         the unhappy side-effect of rebuilding the world.
3969
3970         * CMakeLists.txt:
3971         * GNUmakefile.list.am:
3972         * WebCore.gypi:
3973         * WebCore.pro:
3974         * WebCore.vcproj/WebCore.vcproj:
3975         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
3976
3977         * dom/Node.h: Hello fast code!
3978
3979         * xml/XPathNamespace.cpp: Removed.
3980         * xml/XPathNamespace.h: Removed.
3981
3982 2011-04-25  Adam Barth  <abarth@webkit.org>
3983
3984         Reviewed by Darin Adler.
3985
3986         HistoryItemMac should play nice with OwnPtrs
3987         https://bugs.webkit.org/show_bug.cgi?id=59388
3988
3989         * history/mac/HistoryItemMac.mm:
3990         (WebCore::HistoryItem::setTransientProperty):
3991
3992 2011-04-25  David Levin  <levin@chromium.org>
3993
3994         Reviewed by Kenneth Russell.
3995
3996         Fix strict OwnPtrs in ContextMenuController.cpp
3997         https://bugs.webkit.org/show_bug.cgi?id=59375
3998
3999         * page/ContextMenuController.cpp:
4000         (WebCore::ContextMenuController::createContextMenu):
4001         (WebCore::separatorItem):
4002
4003 2011-04-25  Adam Barth  <abarth@webkit.org>
4004
4005         Reviewed by Darin Adler.
4006
4007         CheckedRadioButton should play nice with strict OwnPtr
4008         https://bugs.webkit.org/show_bug.cgi?id=59386
4009
4010         * dom/CheckedRadioButtons.cpp:
4011         (WebCore::CheckedRadioButtons::addButton):
4012
4013 2011-04-25  Adam Barth  <abarth@webkit.org>
4014
4015         Reviewed by David Levin.
4016
4017         Resource*.cpp should play nice with strict OwnPtrs
4018         https://bugs.webkit.org/show_bug.cgi?id=59383
4019
4020         * bridge/runtime_method.cpp:
4021         (JSC::RuntimeMethod::RuntimeMethod):
4022         * platform/network/ResourceHandle.cpp:
4023         (WebCore::ResourceHandle::ResourceHandle):
4024         * platform/network/ResourceResponseBase.cpp:
4025         (WebCore::ResourceResponseBase::adopt):
4026         (WebCore::ResourceResponseBase::copyData):
4027
4028 2011-04-25  Adam Barth  <abarth@webkit.org>
4029
4030         Reviewed by David Levin.
4031
4032         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
4033         https://bugs.webkit.org/show_bug.cgi?id=59374
4034
4035         * bridge/objc/objc_runtime.mm:
4036         (JSC::Bindings::callObjCFallbackObject):
4037         * page/Page.cpp:
4038         (WebCore::Page::Page):
4039         (WebCore::Page::initGroup):
4040         * page/PageGroup.cpp:
4041         (WebCore::PageGroup::addUserScriptToWorld):
4042         (WebCore::PageGroup::addUserStyleSheetToWorld):
4043         * page/mac/PageMac.cpp:
4044         (WebCore::Page::addSchedulePair):
4045
4046 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4047
4048         Build fix: This time for sure!
4049         
4050         * dom/make_names.pl:
4051
4052 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4053
4054         Build fix: Let's edit the script instead of the autogenrated file. That
4055         way, our change will stand the test of time.
4056
4057         * dom/make_names.pl:
4058
4059 2011-04-25  Adam Barth  <abarth@webkit.org>
4060
4061         Reviewed by David Levin.
4062
4063         Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
4064         https://bugs.webkit.org/show_bug.cgi?id=59368
4065
4066         * html/HTMLMediaElement.cpp:
4067         (WebCore::HTMLMediaElement::HTMLMediaElement):
4068         * platform/network/HTTPHeaderMap.cpp:
4069         (WebCore::HTTPHeaderMap::copyData):
4070
4071 2011-04-25  James Robinson  <jamesr@chromium.org>
4072
4073         Reviewed by Adam Barth.
4074
4075         Fix strict OwnPtr violations in Render*.cpp
4076         https://bugs.webkit.org/show_bug.cgi?id=59361
4077
4078         * rendering/RenderBlock.cpp:
4079         (WebCore::RenderBlock::RenderBlock):
4080         (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
4081         * rendering/RenderBox.cpp:
4082         (WebCore::RenderBox::addLayoutOverflow):
4083         (WebCore::RenderBox::addVisualOverflow):
4084         * rendering/RenderButton.cpp:
4085         (WebCore::RenderButton::styleDidChange):
4086         * rendering/RenderLayer.cpp:
4087         (WebCore::RenderLayer::updateTransform):
4088         (WebCore::RenderLayer::paintChildLayerIntoColumns):
4089         (WebCore::RenderLayer::hitTestChildLayerColumns):
4090         (WebCore::RenderLayer::ensureBacking):
4091         * rendering/RenderTable.cpp:
4092         (WebCore::RenderTable::styleDidChange):
4093         * rendering/RenderView.cpp:
4094         (WebCore::RenderView::compositor):
4095         * rendering/style/RenderStyle.cpp:
4096         (WebCore::RenderStyle::addCachedPseudoStyle):
4097         (WebCore::RenderStyle::accessCounterDirectives):
4098         (WebCore::RenderStyle::accessAnimations):
4099         (WebCore::RenderStyle::accessTransitions):
4100         * rendering/svg/RenderSVGResourceFilter.cpp:
4101         (WebCore::RenderSVGResourceFilter::applyResource):
4102         * rendering/svg/SVGResources.cpp:
4103         (WebCore::SVGResources::SVGResources):
4104
4105 2011-04-25  Adam Barth  <abarth@webkit.org>
4106
4107         Attempt to fix the compile.
4108
4109         * platform/graphics/MediaPlayer.cpp:
4110