2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r85101.
4         http://trac.webkit.org/changeset/85101
5         https://bugs.webkit.org/show_bug.cgi?id=59757
6
7          it'd be better to rollout the patch and do another one with
8         another property name. Current one will bring us to a problem
9         at first run after upgrade because it's type was changed from
10         int to string. (Requested by loislo on #webkit).
11
12         * inspector/front-end/ScriptsPanel.js:
13         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
14         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
15         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
16
17 2011-04-28  Mike Reed  <reed@google.com>
18
19         Reviewed by Eric Seidel.
20
21         fix shadw behavior for both CSS and Canvas -- skia only
22         https://bugs.webkit.org/show_bug.cgi?id=59700
23
24         Test:
25         canvas/philip/tests/2d.shadow.alpha.3.html
26         canvas/philip/tests/2d.shadow.alpha.4.html
27         canvas/philip/tests/2d.shadow.alpha.5.html
28         fast/canvas/canvas-fillPath-alpha-shadow.html
29         fast/canvas/canvas-strokePath-alpha-shadow.html
30         fast/canvas/canvas-strokeRect-alpha-shadow.html
31         fast/css/text-input-with-webkit-border-radius.html
32         fast/repaint/shadow-multiple-horizontal.html
33         fast/repaint/shadow-multiple-strict-horizontal.html
34         fast/repaint/shadow-multiple-strict-vertical.html
35         fast/repaint/shadow-multiple-vertical.html
36         fast/canvas/canvas-getImageData.html
37
38         * platform/graphics/chromium/FontChromiumWin.cpp:
39         (WebCore::Font::drawGlyphs):
40         * platform/graphics/skia/GraphicsContextSkia.cpp:
41         (WebCore::GraphicsContext::setPlatformShadow):
42
43 2011-04-28  David Kilzer  <ddkilzer@apple.com>
44
45         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
46
47         Reviewed by Chris Fleizach.
48
49         Previously, AXObjectCache::attachWrapper over-retained each
50         AccessibilityObjectWrapper it created, which is why
51         AXObjectCache::detachWrapper() contained an extra -release.
52
53         * accessibility/mac/AXObjectCacheMac.mm:
54         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
55         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
56         assigns to a RetainPtr<> instance variable, it doesn't need a +1
57         retained object passed in.  Fix the leak by using a RetainPtr<>
58         for the AccessibilityObjectWrapper.
59
60 2011-04-28  Nat Duca  <nduca@chromium.org>
61
62         Reviewed by Darin Fisher.
63
64         [chromium] Compute compositor fps value and history using the frameBegin timestamp
65         https://bugs.webkit.org/show_bug.cgi?id=59668
66
67         This change switches the compositor FPS meter to use the timestamp
68         of the beginning of the frame rather than the time we call
69         swapBuffers. When scheduling is correctly tied to vsync, we can
70         have highly variable times when we finish vsync and still have
71         stable frame rates.
72
73         * platform/graphics/chromium/LayerRendererChromium.cpp:
74         (WebCore::LayerRendererChromium::updateAndDrawLayers):
75         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
76         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
77         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
78         (WebCore::CCHeadsUpDisplay::onFrameBegin):
79         (WebCore::CCHeadsUpDisplay::onPresent):
80         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
81
82 2011-04-28  Beth Dakin  <bdakin@apple.com>
83
84         Reviewed by Darin Adler.
85
86         https://bugs.webkit.org/show_bug.cgi?id=59759
87         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
88         track when there is nothing to scroll to
89         <rdar://problem/9282066>
90
91         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
92         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
93         is not right. Set the proportion to 0 in this case instead.
94         * platform/mac/ScrollbarThemeMac.mm:
95         (WebCore::ScrollbarThemeMac::paint):
96
97 2011-04-28  Dan Bernstein  <mitz@apple.com>
98
99         Reviewed by Simon Fraser.
100
101         <rdar://problem/9291132> Add support for -epub-prefixed properties
102
103         Test: fast/css/epub-properties.html
104
105         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
106         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
107         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
108         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
109         text-transform, text-transform, word-break, and -webkit-writing-mode.
110
111 2011-04-28  Adam Barth  <abarth@webkit.org>
112
113         Reviewed by Eric Seidel.
114
115         Remove WML
116         https://bugs.webkit.org/show_bug.cgi?id=59678
117
118         This patch removes WML from WebCore.  After removing WML, there's a
119         bunch of twisted code that could be untwisted, but this patch contains
120         only the purely mechanical part of removing the feature.
121
122         There's been a lot of discussion on webkit-dev about whether we should
123         remove WML.  In addition to those threads, we've had an informal poll
124         of the reviewers as well as an in-person discussion at the WebKit
125         contributor's meeting.  Removing any feature is likely to make some
126         folks unhappy, but, on balance, removing WML appears to be the right
127         thing for the project to do at this time.
128
129         * CMakeLists.txt:
130         * CodeGenerators.pri:
131         * Configurations/FeatureDefines.xcconfig:
132         * DerivedSources.cpp:
133         * DerivedSources.make:
134         * GNUmakefile.am:
135         * GNUmakefile.list.am:
136         * WebCore.gyp/WebCore.gyp:
137         * WebCore.gypi:
138         * WebCore.pro:
139         * WebCore.vcproj/WebCore.vcproj:
140         * WebCore.xcodeproj/project.pbxproj:
141         * css/CSSStyleSelector.cpp:
142         (WebCore::linkAttribute):
143         (WebCore::CSSStyleSelector::styleForElement):
144         (WebCore::CSSStyleSelector::adjustRenderStyle):
145         * css/wml.css: Removed.
146         * dom/DOMImplementation.cpp:
147         (WebCore::DOMImplementation::createDocument):
148         * dom/Document.cpp:
149         (WebCore::Document::Document):
150         (WebCore::Document::createElement):
151         * dom/Document.h:
152         (WebCore::Document::isMediaDocument):
153         * dom/Document.idl:
154         * dom/InputElement.h:
155         * dom/Node.cpp:
156         (WebCore::Node::toInputElement):
157         * dom/Node.h:
158         * dom/OptionElement.cpp:
159         (WebCore::toOptionElement):
160         (WebCore::isOptionElement):
161         * dom/OptionElement.h:
162         * dom/OptionGroupElement.cpp:
163         (WebCore::toOptionGroupElement):
164         (WebCore::isOptionGroupElement):
165         * dom/SelectElement.cpp:
166         (WebCore::toSelectElement):
167         * dom/SelectElement.h:
168         * dom/Text.cpp:
169         (WebCore::Text::attach):
170         * dom/XMLDocumentParser.cpp:
171         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
172         * dom/XMLDocumentParser.h:
173         * dom/XMLDocumentParserLibxml2.cpp:
174         (WebCore::XMLDocumentParser::internalSubset):
175         (WebCore::getEntityHandler):
176         * dom/XMLDocumentParserQt.cpp:
177         (WebCore::XMLDocumentParser::parse):
178         (WebCore::XMLDocumentParser::parseDtd):
179         * editing/htmlediting.cpp:
180         (WebCore::canHaveChildrenForEditing):
181         * features.pri:
182         * history/BackForwardList.h:
183         * history/BackForwardListImpl.cpp:
184         * history/BackForwardListImpl.h:
185         * history/PageCache.cpp:
186         (WebCore::PageCache::canCachePageContainingThisFrame):
187         * html/HTMLAnchorElement.h:
188         * inspector/ConsoleMessage.cpp:
189         (WebCore::messageSourceValue):
190         * inspector/front-end/ConsoleView.js:
191         (WebInspector.ConsoleMessage.prototype.toString):
192         * loader/FrameLoader.cpp:
193         (WebCore::isBackForwardLoadType):
194         (WebCore::FrameLoader::transitionToCommitted):
195         (WebCore::FrameLoader::shouldReload):
196         (WebCore::FrameLoader::loadDifferentDocumentItem):
197         (WebCore::FrameLoader::loadItem):
198         * loader/FrameLoaderTypes.h:
199         * loader/HistoryController.cpp:
200         (WebCore::HistoryController::restoreDocumentState):
201         * manual-tests/wml: Removed.
202         * manual-tests/wml/StartTests.wml: Removed.
203         * manual-tests/wml/a-br-element.wml: Removed.
204         * manual-tests/wml/a-element.wml: Removed.
205         * manual-tests/wml/a-img-element.wml: Removed.
206         * manual-tests/wml/access-target.wml: Removed.
207         * manual-tests/wml/anchor-br-element.wml: Removed.
208         * manual-tests/wml/anchor-element.wml: Removed.
209         * manual-tests/wml/anchor-img-element.wml: Removed.
210         * manual-tests/wml/card-newcontext-attr.wml: Removed.
211         * manual-tests/wml/card-onenterbackward.wml: Removed.
212         * manual-tests/wml/card-onenterforward.wml: Removed.
213         * manual-tests/wml/card-ontimer.wml: Removed.
214         * manual-tests/wml/deck-access-control.wml: Removed.
215         * manual-tests/wml/input-format.wml: Removed.
216         * manual-tests/wml/onevent-go.wml: Removed.
217         * manual-tests/wml/onevent-noop.wml: Removed.
218         * manual-tests/wml/onevent-prev.wml: Removed.
219         * manual-tests/wml/onevent-refresh.wml: Removed.
220         * manual-tests/wml/onevent-shadow.wml: Removed.
221         * manual-tests/wml/resources: Removed.
222         * manual-tests/wml/resources/smiley.png: Removed.
223         * manual-tests/wml/select-element.wml: Removed.
224         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
225         * manual-tests/wml/select-onpick-event.wml: Removed.
226         * manual-tests/wml/setvar-element.wml: Removed.
227         * manual-tests/wml/targetdeck.wml: Removed.
228         * manual-tests/wml/task-go-in-anchor.wml: Removed.
229         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
230         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
231         * manual-tests/wml/template-go.wml: Removed.
232         * manual-tests/wml/template-ontimer.wml: Removed.
233         * manual-tests/wml/timer.wml: Removed.
234         * manual-tests/wml/variable-substitution.wml: Removed.
235         * page/Console.cpp:
236         (WebCore::printMessageSourceAndLevelPrefix):
237         * page/Console.h:
238         * page/Frame.cpp:
239         (WebCore::Frame::Frame):
240         * page/Page.cpp:
241         * page/Page.h:
242         * platform/MIMETypeRegistry.cpp:
243         (WebCore::initializeSupportedNonImageMimeTypes):
244         * platform/network/FormDataBuilder.h:
245         * platform/network/mac/ResourceHandleMac.mm:
246         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
247         * platform/wince/MIMETypeRegistryWinCE.cpp:
248         (WebCore::initMIMETypeEntensionMap):
249         * rendering/HitTestResult.cpp:
250         (WebCore::HitTestResult::altDisplayString):
251         (WebCore::HitTestResult::absoluteImageURL):
252         (WebCore::HitTestResult::absoluteLinkURL):
253         (WebCore::HitTestResult::isLiveLink):
254         * rendering/RenderBox.cpp:
255         * rendering/RenderButton.cpp:
256         (WebCore::RenderButton::updateFromElement):
257         * rendering/RenderFieldset.cpp:
258         (WebCore::RenderFieldset::findLegend):
259         * rendering/RenderImage.cpp:
260         (WebCore::RenderImage::updateAltText):
261         * rendering/RenderObject.cpp:
262         (WebCore::RenderObject::isLegend):
263         (WebCore::RenderObject::offsetParent):
264         * wml: Removed.
265         * wml/WMLAElement.cpp: Removed.
266         * wml/WMLAElement.h: Removed.
267         * wml/WMLAccessElement.cpp: Removed.
268         * wml/WMLAccessElement.h: Removed.
269         * wml/WMLAnchorElement.cpp: Removed.
270         * wml/WMLAnchorElement.h: Removed.
271         * wml/WMLAttributeNames.in: Removed.
272         * wml/WMLBRElement.cpp: Removed.
273         * wml/WMLBRElement.h: Removed.
274         * wml/WMLCardElement.cpp: Removed.
275         * wml/WMLCardElement.h: Removed.
276         * wml/WMLDoElement.cpp: Removed.
277         * wml/WMLDoElement.h: Removed.
278         * wml/WMLDocument.cpp: Removed.
279         * wml/WMLDocument.h: Removed.
280         * wml/WMLElement.cpp: Removed.
281         * wml/WMLElement.h: Removed.
282         * wml/WMLErrorHandling.cpp: Removed.
283         * wml/WMLErrorHandling.h: Removed.
284         * wml/WMLEventHandlingElement.cpp: Removed.
285         * wml/WMLEventHandlingElement.h: Removed.
286         * wml/WMLFieldSetElement.cpp: Removed.
287         * wml/WMLFieldSetElement.h: Removed.
288         * wml/WMLFormControlElement.cpp: Removed.
289         * wml/WMLFormControlElement.h: Removed.
290         * wml/WMLGoElement.cpp: Removed.
291         * wml/WMLGoElement.h: Removed.
292         * wml/WMLImageElement.cpp: Removed.
293         * wml/WMLImageElement.h: Removed.
294         * wml/WMLImageLoader.cpp: Removed.
295         * wml/WMLImageLoader.h: Removed.
296         * wml/WMLInputElement.cpp: Removed.
297         * wml/WMLInputElement.h: Removed.
298         * wml/WMLInsertedLegendElement.cpp: Removed.
299         * wml/WMLInsertedLegendElement.h: Removed.
300         * wml/WMLIntrinsicEvent.cpp: Removed.
301         * wml/WMLIntrinsicEvent.h: Removed.
302         * wml/WMLIntrinsicEventHandler.cpp: Removed.
303         * wml/WMLIntrinsicEventHandler.h: Removed.
304         * wml/WMLMetaElement.cpp: Removed.
305         * wml/WMLMetaElement.h: Removed.
306         * wml/WMLNoopElement.cpp: Removed.
307         * wml/WMLNoopElement.h: Removed.
308         * wml/WMLOnEventElement.cpp: Removed.
309         * wml/WMLOnEventElement.h: Removed.
310         * wml/WMLOptGroupElement.cpp: Removed.
311         * wml/WMLOptGroupElement.h: Removed.
312         * wml/WMLOptionElement.cpp: Removed.
313         * wml/WMLOptionElement.h: Removed.
314         * wml/WMLPElement.cpp: Removed.
315         * wml/WMLPElement.h: Removed.
316         * wml/WMLPageState.cpp: Removed.
317         * wml/WMLPageState.h: Removed.
318         * wml/WMLPostfieldElement.cpp: Removed.
319         * wml/WMLPostfieldElement.h: Removed.
320         * wml/WMLPrevElement.cpp: Removed.
321         * wml/WMLPrevElement.h: Removed.
322         * wml/WMLRefreshElement.cpp: Removed.
323         * wml/WMLRefreshElement.h: Removed.
324         * wml/WMLSelectElement.cpp: Removed.
325         * wml/WMLSelectElement.h: Removed.
326         * wml/WMLSetvarElement.cpp: Removed.
327         * wml/WMLSetvarElement.h: Removed.
328         * wml/WMLTableElement.cpp: Removed.
329         * wml/WMLTableElement.h: Removed.
330         * wml/WMLTagNames.in: Removed.
331         * wml/WMLTaskElement.cpp: Removed.
332         * wml/WMLTaskElement.h: Removed.
333         * wml/WMLTemplateElement.cpp: Removed.
334         * wml/WMLTemplateElement.h: Removed.
335         * wml/WMLTimerElement.cpp: Removed.
336         * wml/WMLTimerElement.h: Removed.
337         * wml/WMLVariables.cpp: Removed.
338         * wml/WMLVariables.h: Removed.
339
340 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
341
342         Unreviewed, rolling out r85233 and r85235.
343         http://trac.webkit.org/changeset/85233
344         http://trac.webkit.org/changeset/85235
345         https://bugs.webkit.org/show_bug.cgi?id=59754
346
347         Causes issues with jsc. (Requested by dave_levin on #webkit).
348
349         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
350         * loader/icon/IconDatabase.cpp:
351         (WebCore::IconDatabase::defaultIcon):
352         (WebCore::IconDatabase::setIconDataForIconURL):
353         (WebCore::IconDatabase::getOrCreateIconRecord):
354         (WebCore::IconDatabase::readFromDatabase):
355
356 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
357
358         Reviewed by Adam Barth.
359
360         Introducing a new class that allows serialization of a page back
361         to HTML/XML with all its sub-frames and also retrieves the page's
362         resources.
363         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
364         https://bugs.webkit.org/show_bug.cgi?id=58947
365
366         * Android.mk:
367         * CMakeLists.txt:
368         * GNUmakefile.list.am:
369         * WebCore.gypi:
370         * WebCore.pro:
371         * WebCore.vcproj/WebCore.vcproj:
372         * dom/Document.cpp:
373         (WebCore::Document::suggestedMIMEType):
374         * dom/Document.h:
375         * editing/MarkupAccumulator.cpp:
376         (WebCore::MarkupAccumulator::appendCustomAttributes):
377         (WebCore::MarkupAccumulator::appendElement):
378         * editing/MarkupAccumulator.h:
379         * html/parser/HTMLMetaCharsetParser.cpp:
380         (WebCore::HTMLMetaCharsetParser::processMeta):
381         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
382         * html/parser/HTMLMetaCharsetParser.h:
383         * page/PageSerializer.cpp: Added.
384         * page/PageSerializer.h: Added.
385
386 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
387
388         Reviewed by Tony Chang.
389
390         IndexedDB createIndex should fail if name arg is null
391         https://bugs.webkit.org/show_bug.cgi?id=58365
392
393         Test: storage/indexeddb/mozilla/create-index-null-name.html
394
395         * storage/IDBObjectStore.idl:
396         * storage/IDBObjectStoreBackendImpl.cpp:
397         (WebCore::IDBObjectStoreBackendImpl::createIndex):
398
399 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
400
401         Reviewed by Tony Chang.
402
403         IndexedDB put() should fail if second (key) parameter is null
404         https://bugs.webkit.org/show_bug.cgi?id=58613
405
406         If key arg is not specified, prpKey ends up as a null pointer in ::put().
407         However, if the key arg is specified but is null, prpKey ends up as a
408         valid IDBKey which has a null key type. As it happens, we need to be able
409         to detect the difference between these cases (the key arg is optional but
410         if specified must not be null).
411
412         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
413
414         * storage/IDBObjectStoreBackendImpl.cpp:
415         (WebCore::IDBObjectStoreBackendImpl::put):
416
417 2011-04-07  David Levin  <levin@chromium.org>
418
419         Reviewed by Darin Adler.
420
421         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
422         https://bugs.webkit.org/show_bug.cgi?id=31639
423
424         No new functionality exposed so no new tests. (The change is basically adding
425         more testing.)
426
427         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
428         * loader/icon/IconDatabase.cpp:
429         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
430         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
431         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
432         (WebCore::IconDatabase::readFromDatabase): Ditto.
433
434 2011-04-28  Kenneth Russell  <kbr@google.com>
435
436         Unreviewed build fix for Web Audio with strict OwnPtr.
437
438         * platform/audio/HRTFDatabaseLoader.cpp:
439         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
440
441 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
442
443         Reviewed by Geoffrey Garen.
444
445         Walk shadow hosts as well as parent nodes when finding opaque roots.
446         https://bugs.webkit.org/show_bug.cgi?id=59571
447
448         Test: fast/dom/shadow/gc-shadow.html
449
450         * bindings/js/JSDOMBinding.h:
451         (WebCore::root):
452
453 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
454
455         Reviewed by Xan Lopez.
456
457         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
458         https://bugs.webkit.org/show_bug.cgi?id=59715
459
460         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
461         into WebCore so that WebKit1 and WebKit2 can share the code.
462
463         No new tests. This is covered by fast/events/click-count.html.
464
465         * GNUmakefile.list.am: Added new files.
466         * platform/gtk/GtkClickCounter.cpp: Added.
467         (WebCore::GtkClickCounter::GtkClickCounter): Added.
468         (WebCore::GtkClickCounter::reset): Added.
469         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
470         (WebCore::getEventTime): Added.
471         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
472         * platform/gtk/GtkClickCounter.h: Added.
473
474 2011-04-28  Dan Bernstein  <mitz@apple.com>
475
476         Build fix.
477
478         * css/CSSParser.cpp:
479         (WebCore::cssPropertyID):
480
481 2011-04-28  Dan Bernstein  <mitz@apple.com>
482
483         Reviewed by Simon Fraser.
484
485         Allow specifying CSS property aliases in CSSPropertyNames.in files
486         https://bugs.webkit.org/show_bug.cgi?id=59712
487
488         * css/CSSParser.cpp:
489         (WebCore::cssPropertyID): Removed code to handle some aliases
490         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
491         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
492         defining an alias, and add an appropriate entry to the gperf file.
493
494 2011-04-28  Arno Renevier  <arno@renevier.net>
495
496         Reviewed by Gustavo Noronha Silva.
497
498         [Soup] does not load css stylesheets without content-type
499         https://bugs.webkit.org/show_bug.cgi?id=59697
500
501         When sniffing content type, do not replace http Content-Type header in
502         soup message anymore, but keep sniffed content type in a separate
503         variable.
504
505         * platform/network/soup/ResourceHandleSoup.cpp:
506         (WebCore::contentSniffedCallback):
507         * platform/network/soup/ResourceResponse.h:
508         (WebCore::ResourceResponse::sniffedContentType):
509         (WebCore::ResourceResponse::setSniffedContentType):
510         * platform/network/soup/ResourceResponseSoup.cpp:
511         (WebCore::ResourceResponse::updateFromSoupMessage):
512
513 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
514
515         Reviewed by Andreas Kling.
516
517         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
518         https://bugs.webkit.org/show_bug.cgi?id=59704
519
520         No new tests, just code cleanup.
521
522         * WebCore.pri:
523
524 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
525
526         Reviewed by Pavel Feldman.
527
528         Web Inspector: remove "Pretty print" source frame context menu item.
529         https://bugs.webkit.org/show_bug.cgi?id=59709
530
531         * inspector/front-end/DebuggerPresentationModel.js:
532         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
533         * inspector/front-end/ScriptsPanel.js:
534         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
535         * inspector/front-end/SourceFrame.js:
536         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
537
538 2011-04-28  Satish Sampath  <satish@chromium.org>
539
540         Reviewed by Tony Gentilcore.
541
542         Speech input button layout issues with padding and border.
543         https://bugs.webkit.org/show_bug.cgi?id=59613
544
545         * rendering/RenderTextControlSingleLine.cpp:
546         (WebCore::RenderTextControlSingleLine::layout):
547         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
548         (WebCore::RenderTextControlSingleLine::forwardEvent):
549
550 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
551
552         Reviewed by Martin Robinson.
553
554         [GTK] Check whether to use native scrollbars at run time
555         https://bugs.webkit.org/show_bug.cgi?id=59694
556
557         It's currently decided at build time depending on whether webkit2
558         build is enabled or not. That makes imposible to build both
559         webkit1 and webkit2 using the same libWebCore.
560
561         * GNUmakefile.am:
562         * platform/ScrollView.cpp:
563         (WebCore::ScrollView::wheelEvent):
564         * platform/gtk/ScrollViewGtk.cpp:
565         (WebCore::ScrollView::createScrollbar):
566
567 2011-04-28  Pavel Feldman  <pfeldman@google.com>
568
569         Reviewed by Yury Semikhatsky.
570
571         Web Inspector: add status bar button for pretty print.
572         https://bugs.webkit.org/show_bug.cgi?id=59467
573
574         * WebCore.gypi:
575         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
576         * inspector/front-end/ScriptsPanel.js:
577         (WebInspector.ScriptsPanel):
578         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
579         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
580         * inspector/front-end/WebKit.qrc:
581         * inspector/front-end/inspector.css:
582         (.scripts-toggle-pretty-print-status-bar-item .glyph):
583         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
584
585 2011-04-28  Pavel Feldman  <pfeldman@google.com>
586
587         Reviewed by Yury Semikhatsky.
588
589         Web Inspector: add ResourceTreeModel tests.
590         https://bugs.webkit.org/show_bug.cgi?id=59616
591
592         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
593                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
594                http/tests/inspector/resource-tree/resource-tree-reload.html
595
596         * inspector/front-end/ResourceTreeModel.js:
597         (WebInspector.ResourceTreeModel.prototype.frontendReused):
598         (WebInspector.ResourceTreeModel.prototype._addFrame):
599         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
600         (WebInspector.ResourceTreeModel.prototype._frameDetached):
601         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
602         (WebInspector.ResourceTreeModel.prototype.forAllResources):
603         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
604         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
605         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
606         * inspector/front-end/ResourcesPanel.js:
607         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
608         (WebInspector.ResourcesPanel.prototype._frameAdded):
609         (WebInspector.ResourcesPanel.prototype._frameDetached):
610         (WebInspector.ResourcesPanel.prototype._frameNavigated):
611         (WebInspector.FrameTreeElement):
612         (WebInspector.FrameTreeElement.prototype.frameNavigated):
613
614 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
615
616         Reviewed by Yury Semikhatsky.
617
618         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
619         https://bugs.webkit.org/show_bug.cgi?id=59592
620
621         * inspector/front-end/DetailedHeapshotGridNodes.js:
622         (WebInspector.HeapSnapshotGridNode.prototype._populate):
623         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
624         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
625         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
626         * inspector/front-end/DetailedHeapshotView.js:
627         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
628         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
629         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
630         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
631         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
632         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
633         (WebInspector.DetailedHeapshotView.prototype.changeView):
634         * inspector/front-end/HeapSnapshot.js:
635         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
636         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
637         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
638         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
639         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
640         * inspector/front-end/heapProfiler.css:
641         (div.retaining-paths-view td.path-column div:hover):
642
643 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
644
645         Reviewed by Yury Semikhatsky.
646
647         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
648         https://bugs.webkit.org/show_bug.cgi?id=59454
649
650         Test: inspector/profiler/heap-snapshot-loader.html
651
652         * inspector/front-end/HeapSnapshot.js:
653         (WebInspector.HeapSnapshotLoader):
654         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
655         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
656         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
657         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
658         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
659         * inspector/front-end/HeapSnapshotProxy.js:
660         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
661
662 2011-04-28  ojab  <ojab@ojab.ru>
663
664         Reviewed by David Levin.
665
666         Fix build with libpng-1.5.1
667         https://bugs.webkit.org/show_bug.cgi?id=59607
668
669         * platform/image-decoders/png/PNGImageDecoder.cpp:
670         (WebCore::readColorProfile):
671
672 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
673
674         Reviewed by Nikolas Zimmermann.
675
676         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
677         https://bugs.webkit.org/show_bug.cgi?id=59447
678
679         This patch contains two sub-routines, one for speeding up
680         alpha channel only gaussian blur (by 2.5 times) and one
681         for speeding up all channel blur (by 4 times).
682
683         The common code is also redesigned to better fit for platform
684         specific code. This means large chunks of code was moved to
685         different files, and all platform specific files are added to
686         all build systems.
687
688         * CMakeLists.txt:
689         * GNUmakefile.am:
690         * GNUmakefile.list.am:
691         * WebCore.gypi:
692         * WebCore.pro:
693         * WebCore.vcproj/WebCore.vcproj:
694         * WebCore.vcproj/WebCoreCommon.vsprops:
695         * WebCore.xcodeproj/project.pbxproj:
696         * platform/graphics/filters/FEGaussianBlur.cpp:
697         (WebCore::FEGaussianBlur::platformApplyGeneric):
698         (WebCore::FEGaussianBlur::apply):
699         * platform/graphics/filters/FEGaussianBlur.h:
700         (WebCore::FEGaussianBlur::kernelPosition):
701         (WebCore::FEGaussianBlur::platformApply):
702         * platform/graphics/filters/FELighting.cpp:
703         (WebCore::FELighting::platformApplyGeneric):
704         (WebCore::FELighting::drawLighting):
705         * platform/graphics/filters/FELighting.h:
706         (WebCore::FELighting::platformApply):
707         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
708         (WebCore::WTF_ALIGNED):
709         (WebCore::feGaussianBlurConstantsForNeon):
710         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
711         (WebCore::FEGaussianBlur::platformApplyNeon):
712         * platform/graphics/filters/arm/FELightingNEON.cpp:
713         (WebCore::WTF_ALIGNED):
714         (WebCore::FELighting::getPowerCoefficients):
715         * platform/graphics/filters/arm/FELightingNEON.h:
716         (WebCore::FELighting::platformApplyNeon):
717
718 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
719
720         Reviewed by Yury Semikhatsky.
721
722         Web Inspector: provide a hotkey for script pause
723         https://bugs.webkit.org/show_bug.cgi?id=59593
724
725         In fact, F8 works as a hotkey, but this fact was not reflected
726         in the shortcut help popup.
727
728         * English.lproj/localizedStrings.js:
729         * inspector/front-end/ScriptsPanel.js:
730         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
731
732 2011-04-28  Adam Barth  <abarth@webkit.org>
733
734         Reviewed by Eric Seidel.
735
736         PluginStream should play nice with strict OwnPtr
737         https://bugs.webkit.org/show_bug.cgi?id=59675
738
739         These failures appear when enabling strict OwnPtr on Qt.
740
741         * plugins/PluginStream.cpp:
742         (WebCore::PluginStream::PluginStream):
743         (WebCore::PluginStream::didReceiveData):
744
745 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
746
747         Reviewed by Pavel Feldman.
748
749         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
750         https://bugs.webkit.org/show_bug.cgi?id=59326
751
752         Concrete CachedResource successors for stylesheets and scripts
753         can decode their content better than the generic approach we use.
754
755         * inspector/InspectorPageAgent.cpp:
756         (WebCore::decodeSharedBuffer):
757         (WebCore::prepareCachedResourceBuffer):
758         (WebCore::cachedResourceDecoded):
759         (WebCore::InspectorPageAgent::resourceContent):
760         (WebCore::InspectorPageAgent::resourceData):
761         * inspector/InspectorStyleSheet.cpp:
762         (WebCore::InspectorStyleSheet::originalStyleSheetText):
763
764 2011-04-28  Jon Lee  <jonlee@apple.com>
765
766         Reviewed by Simon Fraser.
767
768         REGRESSION: white overlay scrollbars on apple.com/startpage
769         https://bugs.webkit.org/show_bug.cgi?id=59540
770         <rdar://problem/9338653>
771
772         Now we look at the document background in addition to the <body> element,
773         and blend those colors in with the base background of the frame view to
774         arrive at our aggregate color. This provides a better result to determine
775         overlay scrollbar style.
776
777         * page/Frame.cpp:
778         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
779         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
780
781 2011-04-27  Adam Barth  <abarth@webkit.org>
782
783         Reviewed by Maciej Stachowiak.
784
785         Fix OwnPtr issues in IndexedDB
786         https://bugs.webkit.org/show_bug.cgi?id=59656
787
788         This patch is an attempt to fix the clang build.  Clang can't seem to
789         cope with OwnPtrs to classes declared in an anonymous namespace because
790         OwnPtr's copy constructor isn't defined (but would need to be defined
791         in this translation unit).
792
793         * platform/leveldb/LevelDBDatabase.cpp:
794
795 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
796
797         Reviewed by Antonio Gomes.
798
799         [EFL] Change cursor to LAZY_NATIVE_CURSOR
800         https://bugs.webkit.org/show_bug.cgi?id=59411
801
802         Enable LAZY_NATIVE_CURSOR on EFL build.
803
804         No test added because functionality is unchanged.
805
806         * CMakeListsEfl.txt: Add Cursor.cpp
807         * platform/Cursor.h:
808         (WebCore::Cursor::Cursor):
809         * platform/efl/CursorEfl.cpp:
810         (WebCore::Cursor::Cursor):
811         (WebCore::Cursor::~Cursor):
812         (WebCore::getCursorString):
813         (WebCore::Cursor::ensurePlatformCursor):
814         * platform/efl/WidgetEfl.cpp:
815         (WebCore::Widget::setCursor):
816
817 2011-04-27  Adam Barth  <abarth@webkit.org>
818
819         Build fix from the future.  Another trival strict OwnPtr fixes.  This
820         is the last futuristic build fix I can detect with my time traveling
821         abilities.
822
823         * platform/graphics/chromium/TransparencyWin.cpp:
824         (WebCore::TransparencyWin::initializeNewContext):
825
826 2011-04-27  Dmitry Lomov  <dslomov@google.com>
827
828         Reviewed by David Levin.
829
830         CrossThreadCopier should not have a default specialization for raw pointers
831         https://bugs.webkit.org/show_bug.cgi?id=59234
832         Removed the ablity to pass raw pointers cross-thread
833         Added and applied annotations for doing that
834
835         * fileapi/FileReader.cpp:
836         (WebCore::FileReader::readInternal):
837         (WebCore::FileReader::abort):
838         * fileapi/FileStreamProxy.cpp:
839         (WebCore::FileStreamProxy::startOnFileThread):
840         (WebCore::FileStreamProxy::stopOnFileThread):
841         (WebCore::FileStreamProxy::getSize):
842         (WebCore::FileStreamProxy::getSizeOnFileThread):
843         (WebCore::FileStreamProxy::openForRead):
844         (WebCore::FileStreamProxy::openForReadOnFileThread):
845         (WebCore::FileStreamProxy::openForWrite):
846         (WebCore::FileStreamProxy::openForWriteOnFileThread):
847         (WebCore::FileStreamProxy::close):
848         (WebCore::FileStreamProxy::read):
849         (WebCore::FileStreamProxy::readOnFileThread):
850         (WebCore::FileStreamProxy::write):
851         (WebCore::FileStreamProxy::writeOnFileThread):
852         (WebCore::FileStreamProxy::truncate):
853         (WebCore::FileStreamProxy::truncateOnFileThread):
854         * loader/WorkerThreadableLoader.cpp:
855         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
856         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
857         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
858         * page/GeolocationPositionCache.cpp:
859         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
860         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
861         * platform/CrossThreadCopier.h:
862         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
863         (WebCore::AllowCrossThreadAccessWrapper::value):
864         (WebCore::AllowCrossThreadAccess):
865         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
866         (WebCore::AllowExtendedLifetimeWrapper::value):
867         (WebCore::AllowExtendedLifetime):
868         * platform/graphics/chromium/cc/CCCompletionEvent.h:
869         * storage/IDBObjectStoreBackendImpl.cpp:
870         (WebCore::IDBObjectStoreBackendImpl::get):
871         (WebCore::IDBObjectStoreBackendImpl::put):
872         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
873         (WebCore::IDBObjectStoreBackendImpl::clear):
874         (WebCore::IDBObjectStoreBackendImpl::createIndex):
875         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
876         (WebCore::IDBObjectStoreBackendImpl::openCursor):
877         * storage/SQLCallbackWrapper.h:
878         (WebCore::SQLCallbackWrapper::clear):
879         * websockets/WorkerThreadableWebSocketChannel.cpp:
880         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
881         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
882         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
883         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
884         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
885         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
886         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
887         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
888         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
889         * workers/WorkerMessagingProxy.cpp:
890         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
891
892 2011-04-27  Adam Barth  <abarth@webkit.org>
893
894         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
895
896         * page/Frame.cpp:
897         (WebCore::Frame::setTiledBackingStoreEnabled):
898         * platform/audio/ReverbConvolver.cpp:
899         (WebCore::ReverbConvolver::ReverbConvolver):
900
901 2011-04-27  Adam Barth  <abarth@webkit.org>
902
903         Reviewed by David Levin.
904
905         Fix five strict PassOwnPtr violations in WebCore
906         https://bugs.webkit.org/show_bug.cgi?id=59640
907
908         * css/MediaList.cpp:
909         (WebCore::MediaList::deleteMedium):
910         (WebCore::MediaList::setMediaText):
911         (WebCore::MediaList::appendMedium):
912         * css/MediaQuery.h:
913         * dom/MessagePort.cpp:
914         (WebCore::MessagePort::disentanglePorts):
915         (WebCore::MessagePort::entanglePorts):
916         * inspector/InspectorStyleSheet.cpp:
917         (ParsedStyleSheet::setText):
918         * rendering/RenderTheme.cpp:
919         (WebCore::RenderTheme::adjustStyle):
920         (WebCore::RenderTheme::adjustMeterStyle):
921         * rendering/RenderThemeMac.mm:
922         (WebCore::RenderThemeMac::adjustMenuListStyle):
923         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
924         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
925         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
926         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
927         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
928         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
929         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
930
931 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
932
933         Reviewed by Beth Dakin.
934
935         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
936         https://bugs.webkit.org/show_bug.cgi?id=59648
937
938         Test: accessibility/aria-fallback-roles.html
939
940         * accessibility/AccessibilityObject.cpp:
941         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
942
943 2011-04-27  Beth Dakin  <bdakin@apple.com>
944
945         Reviewed by Dan Bernstein.
946
947         https://bugs.webkit.org/show_bug.cgi?id=59671
948         Race condition with scrollbar animations and closing a page can cause a crash in 
949         WebCore::FrameView::setVisibleScrollerThumbRect + 15
950         -and corresponding-
951         <rdar://problem/9329253>
952
953         It is definitely possible for Page to be null here. So we should null-check it! 
954         And we should not ASSERT.
955         * page/FrameView.cpp:
956         (WebCore::FrameView::didCompleteRubberBand):
957         (WebCore::FrameView::scrollbarStyleChanged):
958         (WebCore::FrameView::setVisibleScrollerThumbRect):
959
960 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
961
962         WinCE build fix after r85143.
963
964         * platform/graphics/wince/FontWinCE.cpp:
965         (WebCore::TextRunComponent::TextRunComponent):
966
967 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
968
969         Reviewed by Tony Chang.
970
971         IndexedDB object store delete should fail if key is null
972         https://bugs.webkit.org/show_bug.cgi?id=58614
973
974         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
975
976         * storage/IDBObjectStoreBackendImpl.cpp:
977         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
978
979 2011-04-27  Eric Seidel  <eric@webkit.org>
980
981         Reviewed by Ryosuke Niwa.
982
983         Should have an easy way to construct starting BidiStatus for a paragraph root
984         https://bugs.webkit.org/show_bug.cgi?id=59226
985
986         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
987         I've made this a constructor for BidiStatus instead.
988
989         As part of this effort I added a direction() accessor for TextRun and got
990         rid of the old m_rtl bool.  This is part of the generic effort in the
991         Bidi code to replace old bool usage with the superior TextDirection enum
992         (this generally makes the code cleaner).
993
994         As part of this replacement effort I found several places which were
995         assuming LTR (by passing rtl=false) when they probably want to use
996         the current text direction.  I suspect that LTR vs. RTL may affect
997         string width in the case of ligatures.  It's unclear.
998
999         This is almost entirely a mechanical change.
1000
1001         * html/canvas/CanvasRenderingContext2D.cpp:
1002         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1003         * platform/graphics/GraphicsContext.cpp:
1004         (WebCore::GraphicsContext::drawBidiText):
1005         * platform/graphics/TextRun.h:
1006         (WebCore::TextRun::TextRun):
1007         (WebCore::TextRun::direction):
1008         (WebCore::TextRun::rtl):
1009         (WebCore::TextRun::ltr):
1010         (WebCore::TextRun::setDirection):
1011         * platform/text/BidiResolver.h:
1012         (WebCore::BidiStatus::BidiStatus):
1013         * rendering/EllipsisBox.cpp:
1014         (WebCore::EllipsisBox::paint):
1015         (WebCore::EllipsisBox::selectionRect):
1016         (WebCore::EllipsisBox::paintSelection):
1017         * rendering/InlineTextBox.cpp:
1018         (WebCore::InlineTextBox::selectionRect):
1019         (WebCore::InlineTextBox::paint):
1020         (WebCore::InlineTextBox::paintSelection):
1021         (WebCore::InlineTextBox::paintCompositionBackground):
1022         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1023         (WebCore::InlineTextBox::paintTextMatchMarker):
1024         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1025         (WebCore::InlineTextBox::offsetForPosition):
1026         (WebCore::InlineTextBox::positionForOffset):
1027         * rendering/RenderBlockLineLayout.cpp:
1028         (WebCore::RenderBlock::determineStartPosition):
1029         * rendering/RenderFileUploadControl.cpp:
1030         (WebCore::RenderFileUploadControl::paintObject):
1031         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1032         * rendering/RenderListBox.cpp:
1033         (WebCore::RenderListBox::updateFromElement):
1034         (WebCore::RenderListBox::paintItemForeground):
1035         * rendering/RenderTextControl.cpp:
1036         (WebCore::RenderTextControl::getAvgCharWidth):
1037         (WebCore::RenderTextControl::paintPlaceholder):
1038         * rendering/svg/SVGInlineTextBox.cpp:
1039         (WebCore::SVGInlineTextBox::constructTextRun):
1040         * rendering/svg/SVGTextMetrics.cpp:
1041         (WebCore::constructTextRun):
1042
1043 2011-04-27  Robert Hogan  <robert@webkit.org>
1044
1045         Reviewed by Adam Barth.
1046
1047         Allow shadowing of history object
1048         https://bugs.webkit.org/show_bug.cgi?id=55965
1049
1050         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1051                http/tests/history/cross-origin-replace-history-object.html
1052
1053         * page/DOMWindow.idl:
1054
1055 2011-04-27  James Robinson  <jamesr@chromium.org>
1056
1057         Reviewed by Kenneth Russell.
1058
1059         [chromium] Ensure compositing layers are up to date before entering doComposite
1060         https://bugs.webkit.org/show_bug.cgi?id=59159
1061
1062         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1063         GraphicsLayerClient::paintContents() implementations).
1064
1065         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1066         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1067         * platform/graphics/chromium/LayerChromium.cpp:
1068         (WebCore::LayerChromium::LayerChromium):
1069         (WebCore::LayerChromium::~LayerChromium):
1070         * platform/graphics/chromium/LayerRendererChromium.cpp:
1071         (WebCore::LayerRendererChromium::updateLayers):
1072         * platform/graphics/chromium/LayerRendererChromium.h:
1073           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1074
1075 2011-04-27  James Robinson  <jamesr@chromium.org>
1076
1077         Reviewed by Adam Barth.
1078
1079         Fix OwnPtr strict issues in chromium linux build
1080         https://bugs.webkit.org/show_bug.cgi?id=59664
1081
1082         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1083         (WebCore::ComplexTextController::getNormalizedTextRun):
1084         * platform/graphics/skia/ImageBufferSkia.cpp:
1085         (WebCore::ImageBuffer::ImageBuffer):
1086         * platform/graphics/skia/PlatformContextSkia.cpp:
1087         (WebCore::PlatformContextSkia::PlatformContextSkia):
1088
1089 2011-04-27  Chris Rogers  <crogers@google.com>
1090
1091         Reviewed by Kenneth Russell.
1092
1093         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1094         https://bugs.webkit.org/show_bug.cgi?id=59641
1095
1096         No new tests since audio API is not yet implemented.
1097
1098         * platform/audio/AudioBus.cpp:
1099         (WebCore::AudioBus::createBySampleRateConverting):
1100         (WebCore::AudioBus::createByMixingToMono):
1101
1102 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1103
1104         Motivated by Alexey Proskuryakov.
1105
1106         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1107         informative, since it confused Alexey and me.
1108
1109 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1110
1111         Reviewed by Sam Weinig.
1112
1113         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1114         https://bugs.webkit.org/show_bug.cgi?id=59646
1115
1116         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1117         a world, we need to clear all entries in the map for that world, since
1118         the finalizers that would otherwise clear those entries don't run. The
1119         simplest way to do this is just to make the world own the map.
1120         
1121         * bindings/js/DOMWrapperWorld.h:
1122         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1123         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1124         * bindings/js/JSCSSValueCustom.cpp:
1125         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1126         (WebCore::JSCSSValueOwner::finalize):
1127         * bindings/js/JSDOMBinding.h:
1128
1129 2011-04-27  Adam Barth  <abarth@webkit.org>
1130
1131         Reviewed by David Levin.
1132
1133         Fix OwnPtr issues in IndexedDB
1134         https://bugs.webkit.org/show_bug.cgi?id=59656
1135
1136         I didn't do an exhaustive review of this code, but I fixed the problems
1137         caught by turning on strict OwnPtr and all their antecedents.  This
1138         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1139         behavior change.
1140
1141         * platform/leveldb/LevelDBDatabase.cpp:
1142         (WebCore::LevelDBDatabase::LevelDBDatabase):
1143         (WebCore::LevelDBDatabase::open):
1144         (WebCore::LevelDBDatabase::createIterator):
1145         * platform/leveldb/LevelDBDatabase.h:
1146         * platform/leveldb/LevelDBIterator.cpp:
1147         (WebCore::LevelDBIterator::LevelDBIterator):
1148         * platform/leveldb/LevelDBIterator.h:
1149         * storage/IDBLevelDBBackingStore.cpp:
1150         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1151         (WebCore::IDBLevelDBBackingStore::open):
1152         (WebCore::getNewDatabaseId):
1153         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1154         (WebCore::getNewObjectStoreId):
1155         (WebCore::deleteRange):
1156         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1157         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1158         (WebCore::IDBLevelDBBackingStore::getIndexes):
1159         (WebCore::getNewIndexId):
1160         (WebCore::findGreatestKeyLessThan):
1161         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1162         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1163         (WebCore::findLastIndexKeyEqualTo):
1164         * storage/IDBLevelDBBackingStore.h:
1165
1166 2011-04-19  MORITA Hajime  <morrita@google.com>
1167
1168         Reviewed by Tony Chang.
1169
1170         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1171         https://bugs.webkit.org/show_bug.cgi?id=58113
1172
1173         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1174         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1175         * Now MarkerMapVectorPair is no longer used.
1176         
1177         No new tests, No behavior change.
1178
1179         * GNUmakefile.list.am:
1180         * WebCore.gypi:
1181         * WebCore.pro:
1182         * WebCore.vcproj/WebCore.vcproj:
1183         * WebCore.xcodeproj/project.pbxproj:
1184         * dom/DocumentMarker.h:
1185         * dom/DocumentMarkerController.cpp:
1186         (WebCore::DocumentMarkerController::addMarker):
1187         (WebCore::DocumentMarkerController::copyMarkers):
1188         (WebCore::DocumentMarkerController::removeMarkers):
1189         (WebCore::DocumentMarkerController::markerContainingPoint):
1190         (WebCore::DocumentMarkerController::markersForNode):
1191         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1192         (WebCore::DocumentMarkerController::removeMarkersFromList):
1193         (WebCore::DocumentMarkerController::repaintMarkers):
1194         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1195         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1196         (WebCore::DocumentMarkerController::shiftMarkers):
1197         (WebCore::DocumentMarkerController::setMarkersActive):
1198         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1199         (WebCore::DocumentMarkerController::showMarkers):
1200         * dom/DocumentMarkerController.h:
1201         * dom/RenderedDocumentMarker.h: Added.
1202         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1203         (WebCore::RenderedDocumentMarker::isRendered):
1204         (WebCore::RenderedDocumentMarker::contains):
1205         (WebCore::RenderedDocumentMarker::setRenderedRect):
1206         (WebCore::RenderedDocumentMarker::renderedRect):
1207         (WebCore::RenderedDocumentMarker::invalidate):
1208         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1209
1210 2011-04-27  James Robinson  <jamesr@chromium.org>
1211
1212         Unreviewed, rolling out r85112.
1213         http://trac.webkit.org/changeset/85112
1214         https://bugs.webkit.org/show_bug.cgi?id=59159
1215
1216         Broke mac compile
1217
1218         * page/FrameView.cpp:
1219         (WebCore::FrameView::updateCompositingLayers):
1220         * page/FrameView.h:
1221         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1222         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1223         * platform/graphics/chromium/LayerChromium.cpp:
1224         (WebCore::LayerChromium::LayerChromium):
1225         (WebCore::LayerChromium::~LayerChromium):
1226         * platform/graphics/chromium/LayerRendererChromium.cpp:
1227         (WebCore::LayerRendererChromium::updateLayers):
1228         * platform/graphics/chromium/LayerRendererChromium.h:
1229
1230 2011-04-27  Mark Rowe  <mrowe@apple.com>
1231
1232         Build fix.
1233
1234         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1235
1236 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1237
1238         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1239
1240         * platform/network/ResourceHandleClient.h:
1241
1242 2011-04-27  James Robinson  <jamesr@chromium.org>
1243
1244         Reviewed by Kenneth Russell.
1245
1246         [chromium] Ensure compositing layers are up to date before entering doComposite
1247         https://bugs.webkit.org/show_bug.cgi?id=59159
1248
1249         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1250         GraphicsLayerClient::paintContents() implementations).
1251
1252         * page/FrameView.cpp:
1253         (WebCore::FrameView::updateCompositingLayers):
1254             Add an optional CompositingUpdateType parameter.
1255         * page/FrameView.h:
1256         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1257         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1258         * platform/graphics/chromium/LayerChromium.cpp:
1259         (WebCore::LayerChromium::LayerChromium):
1260         (WebCore::LayerChromium::~LayerChromium):
1261         * platform/graphics/chromium/LayerRendererChromium.cpp:
1262         (WebCore::LayerRendererChromium::updateLayers):
1263         * platform/graphics/chromium/LayerRendererChromium.h:
1264           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1265         * rendering/RenderLayer.cpp:
1266         (WebCore::RenderLayer::dirtyZOrderLists):
1267         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1268         * rendering/RenderLayerCompositor.cpp:
1269         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1270         * rendering/RenderLayerCompositor.h:
1271           Fix a typo in CompositingUpdateType Pait->Paint
1272
1273 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1274
1275         Reviewed by Antti Koivisto.
1276
1277         Part of WebCore should use CFNetwork-based loader on Mac
1278         https://bugs.webkit.org/show_bug.cgi?id=51836
1279
1280         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1281         willCacheResponse/shouldCacheResponse.
1282
1283         * loader/EmptyClients.h:
1284         * loader/FrameLoaderClient.h:
1285         * loader/ResourceLoader.h:
1286         * loader/cf/ResourceLoaderCFNet.cpp:
1287         * loader/mac/ResourceLoaderMac.mm:
1288         (WebCore::ResourceLoader::willCacheResponse):
1289         * platform/network/ResourceHandleClient.h:
1290         (WebCore::ResourceHandleClient::willCacheResponse):
1291         (WebCore::ResourceHandleClient::shouldCacheResponse):
1292         * platform/network/cf/ResourceHandleCFNet.cpp:
1293         (WebCore::willCacheResponse):
1294
1295 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
1296
1297         Reviewed by Brian Weinstein.
1298
1299         Web Inspector: Stop on Exception state does not persist.
1300
1301         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
1302         https://bugs.webkit.org/show_bug.cgi?id=59630
1303
1304         * inspector/front-end/ScriptsPanel.js:
1305         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1306         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1307         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1308
1309 2011-04-27  Adrienne Walker  <enne@google.com>
1310
1311         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
1312         https://bugs.webkit.org/show_bug.cgi?id=59020
1313
1314         * platform/graphics/chromium/LayerRendererChromium.cpp:
1315         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1316
1317 2011-04-27  Darin Adler  <darin@apple.com>
1318
1319         Reviewed by David Levin.
1320
1321         Fix strict OwnPtr issues seen in about 30 more files
1322         https://bugs.webkit.org/show_bug.cgi?id=59615
1323
1324         * bindings/js/JSCallbackData.h:
1325         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
1326         * bindings/js/JSMessageEventCustom.cpp:
1327         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
1328         * css/CSSParser.cpp:
1329         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
1330         adoptPtr, and release.
1331         * dom/MessageEvent.cpp:
1332         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
1333         and release.
1334         * dom/MessagePortChannel.cpp:
1335         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
1336         * dom/ScriptExecutionContext.cpp:
1337         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
1338         * dom/XMLDocumentParserLibxml2.cpp:
1339         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
1340         * dom/default/PlatformMessagePortChannel.cpp:
1341         (WebCore::MessagePortChannel::create): Use adoptPtr.
1342         * html/HTMLFormControlElement.cpp:
1343         (WebCore::HTMLFormControlElement::detach): Use nullptr.
1344         * inspector/InspectorAgent.cpp:
1345         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
1346         * inspector/InspectorConsoleAgent.cpp:
1347         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
1348         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
1349         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
1350         * inspector/InspectorController.cpp:
1351         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
1352         * inspector/InspectorDOMAgent.cpp:
1353         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
1354         * inspector/InspectorResourceAgent.cpp:
1355         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1356         * page/FrameActionScheduler.cpp:
1357         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1358         * platform/graphics/ShadowBlur.cpp:
1359         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1360         * platform/graphics/ca/GraphicsLayerCA.cpp:
1361         (WebCore::GraphicsLayer::create): Use adoptPtr.
1362         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1363         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1364         * rendering/RenderBlock.cpp:
1365         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1366         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1367         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
1368         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
1369         * rendering/RenderLayerBacking.cpp:
1370         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
1371         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
1372         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
1373         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
1374         * rendering/RenderLayerCompositor.cpp:
1375         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
1376         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
1377         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
1378         * rendering/style/StyleRareNonInheritedData.cpp:
1379         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
1380         explicit initializations of OwnPtr members to 0. Use adoptPtr.
1381         * workers/SharedWorkerContext.cpp:
1382         (WebCore::createConnectEvent): Use adoptPtr.
1383         * workers/Worker.cpp:
1384         (WebCore::Worker::notifyFinished): Use nullptr.
1385
1386 2011-04-27  Enrica Casucci  <enrica@apple.com>
1387
1388         Reviewed by Darin Adler.
1389
1390         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
1391         https://bugs.webkit.org/show_bug.cgi?id=59251
1392         <rdar://problem/9327044>
1393
1394         When we are looking for wrapping elements that are presentational, we should
1395         include elements that have a non transparent background color only if they
1396         are not blocks.
1397
1398         Test: editing/pasteboard/do-not-copy-body-color.html
1399
1400         * editing/markup.cpp:
1401         (WebCore::isElementPresentational):
1402
1403 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
1404
1405         Reviewed by Antti Koivisto.
1406
1407         Teach sub-selector chains about shadow descendants
1408         https://bugs.webkit.org/show_bug.cgi?id=58342
1409
1410         The primary change is to the logic of parsing specifiers:
1411         1) The shadow descendant selectors (those specifiers that are unknown
1412         pseudo element selectors) are always kept at the top of the chain.
1413         2) The sub-selectors after shadow descendant selectors are stashed right
1414         behind the sub-selector, but not at the end of the chain.
1415         3) Other sub-selectors are appended at the end of the chain.
1416
1417         * css/CSSGrammar.y: Changed specifier_list collection to use new
1418             CSSParser::updateSpecifier helper.
1419         * css/CSSParser.cpp:
1420         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
1421             look for the last ShadowDescendant relation in the chain of selectors,
1422             because the next selector after it is the one that should get the
1423             element name.
1424         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
1425             CSSGrammar.y. The new logic adjusts the selector chain to allow
1426             shadow descendant selectors have sub-selectors (and have multiple shadow
1427             descendants in the chain).
1428         * css/CSSParser.h: Added decl.
1429         * css/CSSParserValues.cpp:
1430         (WebCore::CSSParserSelector::insertTagHistory): Added.
1431         (WebCore::CSSParserSelector::appendTagHistory): Aded.
1432         * css/CSSParserValues.h: Added decls.
1433         * css/CSSStyleSelector.cpp:
1434         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
1435             shadow descendant selector match check, since now there could be many
1436             of them in the selector chain.
1437
1438 2011-04-20  Adrienne Walker  <enne@google.com>
1439
1440         Reviewed by Kenneth Russell.
1441
1442         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
1443         https://bugs.webkit.org/show_bug.cgi?id=59020
1444
1445         mapRect is the incorrect transform here.  The parent scissor rect
1446         needs to be projected into layer space instead.
1447
1448         Test: compositing/flat-with-transformed-child.html
1449
1450         * platform/graphics/chromium/LayerRendererChromium.cpp:
1451         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1452
1453 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1454
1455         Reviewed by Antti Koivisto.
1456
1457         Part of WebCore should use CFNetwork-based loader on Mac
1458         https://bugs.webkit.org/show_bug.cgi?id=51836
1459
1460         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
1461         * platform/mac/SoftLinking.h:
1462         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
1463
1464 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
1465
1466         Reviewed by Antti Koivisto.
1467
1468         Cleanup CSSStyleApplyProperty.cpp
1469         https://bugs.webkit.org/show_bug.cgi?id=59623
1470
1471         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
1472         Use typedefs instead of repating the function pointer declarations in a few places.
1473
1474         * css/CSSStyleApplyProperty.cpp:
1475         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
1476         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
1477         (WebCore::ApplyPropertyColor::applyInheritValue):
1478         (WebCore::ApplyPropertyColor::applyInitialValue):
1479         (WebCore::ApplyPropertyColor::applyValue):
1480         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
1481
1482 2011-04-27  Dan Bernstein  <mitz@apple.com>
1483
1484         Reviewed by Anders Carlsson.
1485
1486         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
1487         https://bugs.webkit.org/show_bug.cgi?id=59622
1488
1489         Test: fast/borders/border-image-trumps-radius.html
1490
1491         * rendering/RenderBox.cpp:
1492         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
1493         image, then border radius is ignored, so no bleed avoidance is needed.
1494         * rendering/RenderObject.cpp:
1495         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
1496         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
1497         * rendering/RenderObject.h:
1498
1499 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1500
1501         Reviewed by Xan Lopez.
1502
1503         [GTK] editing/pasteboard/copy-standalone-image.html fails
1504         https://bugs.webkit.org/show_bug.cgi?id=53645
1505
1506         When writing an image to the clipboard, also write the URL and title
1507         into the markup and URL portion. This change also abstracts a helper
1508         imageToMarkup into markup.{cpp/h} from several different locations
1509         throughout the platform layer.
1510
1511         * editing/markup.h: Added new function definition.
1512         * editing/markup.cpp:
1513         (WebCore::imageToMarkup): Add this function which turns an image URL 
1514         and element into some markup representing that image, while preserving
1515         non-src attributes.
1516         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
1517         to markup.cpp.
1518         * platform/gtk/PasteboardGtk.cpp:
1519         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
1520         image URL for a variety of image tag types.
1521         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
1522         markup and URL portions of the clipboard. This will ensure that images
1523         paste properly back into WebKit.
1524         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
1525         one from markup.h
1526
1527 2011-04-27  Steve Block  <steveblock@google.com>
1528
1529         Reviewed by David Levin.
1530
1531         Remove Android build system
1532         https://bugs.webkit.org/show_bug.cgi?id=48111
1533
1534         This is to avoid the maintenance burden until the Android port is
1535         fully upstreamed.
1536
1537         No new tests, build change only.
1538
1539         * Android.derived.jscbindings.mk: Removed.
1540         * Android.derived.mk: Removed.
1541         * Android.derived.v8bindings.mk: Removed.
1542         * Android.jscbindings.mk: Removed.
1543         * Android.mk: Removed.
1544         * Android.v8bindings.mk: Removed.
1545
1546 2011-04-27  Darin Adler  <darin@apple.com>
1547
1548         Reviewed by Sam Weinig.
1549
1550         Somehow about:blank gets into the icon database
1551         https://bugs.webkit.org/show_bug.cgi?id=58067
1552         rdar://problem/6751446
1553
1554         Implemented the policy Brady suggested, where only http and https URLs can
1555         be associated with and icon, guarding both on the way in to the database,
1556         and on the way out.
1557
1558         * loader/icon/IconDatabase.cpp:
1559         (WebCore::pageCanHaveIcon): Added.
1560         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
1561         instead of just checking for an empty URL.
1562         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
1563         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
1564         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
1565         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
1566         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
1567         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
1568         two separate assertions and added a third.
1569         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
1570
1571         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
1572         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
1573         overloaded it to work on both UChar and char, and added an assertion to it.
1574         Also moved this to the top of the file and made the UChar version usable
1575         in the shared code used even by Google.
1576         (WebCore::KURL::invalidate): Updated for name change.
1577         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
1578         toASCIILower since it's faster.
1579         (WebCore::KURL::parse): Updated for name changes.
1580         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
1581         since it's faster.
1582         (WebCore::protocolIsInHTTPFamily): Added.
1583
1584         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
1585         to protocolIsInHTTPFamily and added a version that works on a string.
1586         Kept the old name as an inline function so we don't have to rename
1587         all the cal sites now.
1588
1589         * platform/KURLGoogle.cpp: Renamed as above.
1590         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
1591         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
1592         (WebCore::KURLGooglePrivate::setAscii): Ditto.
1593         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
1594         (WebCore::KURLGooglePrivate::copyTo): Ditto.
1595         (WebCore::KURL::KURL): Ditto.
1596         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
1597         (WebCore::KURL::invalidate): Ditto.
1598         * platform/KURLGooglePrivate.h: Ditto.
1599
1600         * WebCore.exp.in: Updated for above changes.
1601
1602 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1603
1604         Reviewed by Pavel Feldman.
1605
1606         Web Inspector: browser crash on evaluation of 'throw undefined'
1607         https://bugs.webkit.org/show_bug.cgi?id=59611
1608
1609         Test: inspector/console/console-eval-throw-undefined.html
1610
1611         * inspector/InjectedScriptSource.js: use try/catch to protect from
1612         exception during conversion of another exception to string.
1613
1614 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1615
1616         Reviewed by Yury Semikhatsky.
1617
1618         Web Inspector: clicking bookmarklet multiplies resources panel entries.
1619         https://bugs.webkit.org/show_bug.cgi?id=59590
1620
1621         * inspector/front-end/ResourceTreeModel.js:
1622         (WebInspector.ResourceTreeModel):
1623         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
1624         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1625         * inspector/front-end/ResourcesPanel.js:
1626         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1627         (WebInspector.FrameTreeElement):
1628         (WebInspector.FrameTreeElement.prototype.appendResource):
1629         * inspector/front-end/inspector.js:
1630         (WebInspector.frontendReused):
1631
1632 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1633
1634         Reviewed by Yury Semikhatsky.
1635
1636         Web Inspector: opening bookmarklet disconnects DOM agent.
1637         https://bugs.webkit.org/show_bug.cgi?id=59588
1638
1639         * inspector/InspectorDOMAgent.cpp:
1640         (WebCore::InspectorDOMAgent::setDocument):
1641
1642 2011-04-27  Hans Wennborg  <hans@chromium.org>
1643
1644         Reviewed by Tony Gentilcore.
1645
1646         IndexedDB: Fix compiler warnings about uninitialized variables
1647         https://bugs.webkit.org/show_bug.cgi?id=59599
1648
1649         Build fix. No new tests.
1650
1651         * storage/IDBLevelDBBackingStore.cpp:
1652         (WebCore::getNewObjectStoreId):
1653         (WebCore::getNewIndexId):
1654
1655 2011-04-26  Hans Wennborg  <hans@chromium.org>
1656
1657         Reviewed by Tony Gentilcore.
1658
1659         IndexedDB: Move LevelDB key coding routines to separate file
1660         https://bugs.webkit.org/show_bug.cgi?id=59452
1661
1662         Move all routines concerned with encoding, decoding and comparison of
1663         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
1664         IDBLevelDBCoding.cpp.
1665
1666         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
1667         allow for unit testing of the coding routines.
1668
1669         No new functionality, no new tests.
1670
1671         * WebCore.gypi:
1672         * storage/IDBLevelDBBackingStore.cpp:
1673         (WebCore::getInt):
1674         (WebCore::putInt):
1675         (WebCore::getString):
1676         (WebCore::putString):
1677         (WebCore::compareKeys):
1678         (WebCore::compareIndexKeys):
1679         (WebCore::Comparator::compare):
1680         (WebCore::setUpMetadata):
1681         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
1682         (WebCore::getNewDatabaseId):
1683         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
1684         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1685         (WebCore::getNewObjectStoreId):
1686         (WebCore::IDBLevelDBBackingStore::createObjectStore):
1687         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
1688         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
1689         (WebCore::getNewVersionNumber):
1690         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
1691         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
1692         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
1693         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1694         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
1695         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1696         (WebCore::IDBLevelDBBackingStore::getIndexes):
1697         (WebCore::getNewIndexId):
1698         (WebCore::IDBLevelDBBackingStore::createIndex):
1699         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
1700         (WebCore::versionExists):
1701         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1702         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1703         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
1704         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
1705         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
1706         * storage/IDBLevelDBCoding.cpp: Added.
1707         (WebCore::IDBLevelDBCoding::encodeByte):
1708         (WebCore::IDBLevelDBCoding::maxIDBKey):
1709         (WebCore::IDBLevelDBCoding::minIDBKey):
1710         (WebCore::IDBLevelDBCoding::encodeInt):
1711         (WebCore::IDBLevelDBCoding::decodeInt):
1712         (WebCore::IDBLevelDBCoding::encodeVarInt):
1713         (WebCore::IDBLevelDBCoding::decodeVarInt):
1714         (WebCore::IDBLevelDBCoding::encodeString):
1715         (WebCore::IDBLevelDBCoding::decodeString):
1716         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
1717         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
1718         (WebCore::IDBLevelDBCoding::encodeDouble):
1719         (WebCore::IDBLevelDBCoding::decodeDouble):
1720         (WebCore::IDBLevelDBCoding::encodeIDBKey):
1721         (WebCore::IDBLevelDBCoding::decodeIDBKey):
1722         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
1723         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
1724         (WebCore::IDBLevelDBCoding::compare):
1725         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
1726         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
1727         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
1728         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
1729         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
1730         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
1731         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
1732         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
1733         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
1734         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
1735         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
1736         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
1737         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
1738         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
1739         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
1740         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
1741         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
1742         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
1743         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
1744         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
1745         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
1746         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
1747         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
1748         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
1749         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
1750         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
1751         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
1752         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
1753         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
1754         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
1755         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
1756         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
1757         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
1758         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
1759         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
1760         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
1761         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
1762         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
1763         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
1764         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
1765         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
1766         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
1767         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
1768         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
1769         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
1770         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
1771         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
1772         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
1773         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
1774         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
1775         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
1776         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
1777         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
1778         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
1779         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
1780         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
1781         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
1782         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
1783         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
1784         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
1785         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
1786         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
1787         * storage/IDBLevelDBCoding.h: Added.
1788         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
1789         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
1790         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
1791         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
1792         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
1793
1794 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1795
1796         Reviewed by Pavel Feldman.
1797
1798         Web Inspector: expose exception details when script is paused on exception
1799         https://bugs.webkit.org/show_bug.cgi?id=59591
1800
1801         When script is paused on an exception, the exception value is added as <exception>
1802         property in the local scope and the breakpoint details message says
1803         "Paused on excepion: '<exception to strin value>'."
1804
1805         * English.lproj/localizedStrings.js:
1806         * inspector/front-end/ScopeChainSidebarPane.js:
1807         (WebInspector.ScopeChainSidebarPane.prototype.update):
1808         * inspector/front-end/ScriptsPanel.js:
1809         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
1810         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
1811
1812 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
1813
1814         Reviewed by Pavel Feldman.
1815
1816         Web Inspector: [protocol] Paused event should expose exception value that caused it
1817         https://bugs.webkit.org/show_bug.cgi?id=58996
1818
1819         Debug.pause event now contains an optional reference to the exception
1820         object in case script execution is paused on a JavaScript exception.
1821
1822         Also JavaScript call frames are passed directly into the injected script when
1823         we need to wrap them for passing to the front-end. This change breaks cyclic
1824         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
1825
1826         * bindings/js/JSInjectedScriptHostCustom.cpp:
1827         * bindings/js/ScriptDebugServer.cpp:
1828         (WebCore::ScriptDebugServer::dispatchDidPause):
1829         * bindings/js/ScriptDebugServer.h:
1830         * bindings/v8/ScriptDebugServer.cpp:
1831         (WebCore::ScriptDebugServer::breakProgram):
1832         (WebCore::ScriptDebugServer::editScriptSource):
1833         (WebCore::ScriptDebugServer::breakProgramCallback):
1834         (WebCore::ScriptDebugServer::handleV8DebugEvent):
1835         * bindings/v8/ScriptDebugServer.h:
1836         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
1837         * inspector/InjectedScript.cpp:
1838         (WebCore::InjectedScript::evaluateOnCallFrame):
1839         (WebCore::InjectedScript::wrapCallFrames):
1840         * inspector/InjectedScript.h:
1841         * inspector/InjectedScriptHost.cpp:
1842         * inspector/InjectedScriptHost.h:
1843         (WebCore::InjectedScriptHost::init):
1844         * inspector/InjectedScriptHost.idl:
1845         * inspector/InjectedScriptSource.js:
1846         (.):
1847         * inspector/Inspector.json:
1848         * inspector/InspectorAgent.cpp:
1849         (WebCore::InspectorAgent::InspectorAgent):
1850         * inspector/InspectorDebuggerAgent.cpp:
1851         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
1852         (WebCore::InspectorDebuggerAgent::currentCallFrames):
1853         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
1854         (WebCore::InspectorDebuggerAgent::didPause):
1855         (WebCore::InspectorDebuggerAgent::didContinue):
1856         (WebCore::InspectorDebuggerAgent::clear):
1857         * inspector/InspectorDebuggerAgent.h:
1858         * inspector/ScriptDebugListener.h:
1859         * inspector/WorkerInspectorController.cpp:
1860         (WebCore::WorkerInspectorController::WorkerInspectorController):
1861
1862 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1863
1864         Reviewed by Yury Semikhatsky.
1865
1866         Web Inspector: implement incremental CSS editing in the structure view.
1867         https://bugs.webkit.org/show_bug.cgi?id=59455
1868
1869         * inspector/front-end/StylesSidebarPane.js:
1870         (WebInspector.StylePropertyTreeElement.prototype):
1871
1872 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
1873
1874         Reviewed by Eric Seidel.
1875
1876         Frame.h shouldn't include Document.h
1877         https://bugs.webkit.org/show_bug.cgi?id=59560
1878
1879         Frame can use a forward-declared Document if we move
1880         Frame::displayStringModifiedByEncoding's implementation out of the
1881         header.
1882                                 Size  #includes  Size * #includes
1883         Before: page/Frame.h:   0.746       653           487.138
1884                 dom/Document.h: 0.220      1306           287.320
1885         
1886         After:  page/Frame.h:   0.646       653           421.838
1887                 dom/Document.h: 0.220      1189           261.580
1888
1889         * WebCore.exp.in:
1890         * bindings/ScriptControllerBase.cpp:
1891         * bindings/generic/BindingSecurityBase.cpp:
1892         * bindings/v8/V8Proxy.cpp:
1893         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
1894         * dom/CharacterData.cpp:
1895         * dom/UserTypingGestureIndicator.cpp:
1896         * editing/chromium/SelectionControllerChromium.cpp:
1897         * inspector/InspectorDOMStorageResource.cpp:
1898         * inspector/InspectorInstrumentation.h:
1899         * loader/PingLoader.cpp:
1900         * loader/SubresourceLoader.cpp:
1901         * loader/appcache/DOMApplicationCache.cpp:
1902         * loader/cache/CachedResourceRequest.cpp:
1903         * page/Frame.cpp:
1904         (WebCore::Frame::displayStringModifiedByEncoding):
1905         * page/Frame.h:
1906         * page/Geolocation.cpp:
1907         * page/Location.cpp:
1908         * page/Navigator.cpp:
1909         * page/PageGroupLoadDeferrer.cpp:
1910         * page/PerformanceTiming.cpp:
1911         * xml/XSLTProcessorLibxslt.cpp:
1912
1913 2011-04-27  James Robinson  <jamesr@chromium.org>
1914
1915         Reviewed by Eric Seidel.
1916
1917         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
1918         https://bugs.webkit.org/show_bug.cgi?id=59377
1919
1920         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
1921         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
1922
1923         * css/CSSStyleSelector.cpp:
1924         (WebCore::CSSStyleSelector::applyProperty):
1925         * page/animation/AnimationBase.cpp:
1926         (WebCore::blendFunc):
1927         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
1928         (WebCore::PropertyWrapperShadow::blend):
1929         * rendering/style/RenderStyle.cpp:
1930         (WebCore::RenderStyle::setTextShadow):
1931         (WebCore::RenderStyle::setBoxShadow):
1932         * rendering/style/RenderStyle.h:
1933         (WebCore::InheritedFlags::textShadow):
1934         * rendering/style/ShadowData.cpp:
1935         (WebCore::ShadowData::ShadowData):
1936         * rendering/style/ShadowData.h:
1937         (WebCore::ShadowData::ShadowData):
1938         (WebCore::ShadowData::next):
1939         (WebCore::ShadowData::setNext):
1940         * rendering/style/StyleRareInheritedData.cpp:
1941         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1942         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
1943         * rendering/style/StyleRareInheritedData.h:
1944         * rendering/style/StyleRareNonInheritedData.cpp:
1945         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
1946
1947 2011-04-26  David Levin  <levin@chromium.org>
1948
1949         Reviewed by Eric Seidel.
1950
1951         Fix some strict PassOwnPtr issues in WebCore.
1952         https://bugs.webkit.org/show_bug.cgi?id=59563
1953
1954         * css/SVGCSSStyleSelector.cpp:
1955         (WebCore::CSSStyleSelector::applySVGProperty):
1956         * html/canvas/WebGLRenderingContext.cpp:
1957         (WebCore::WebGLRenderingContext::create):
1958         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
1959         * platform/text/TextCodecLatin1.cpp:
1960         (WebCore::newStreamingTextDecoderWindowsLatin1):
1961         * platform/text/TextCodecUTF16.cpp:
1962         (WebCore::newStreamingTextDecoderUTF16LE):
1963         (WebCore::newStreamingTextDecoderUTF16BE):
1964         * platform/text/TextCodecUserDefined.cpp:
1965         (WebCore::newStreamingTextDecoderUserDefined):
1966         * platform/text/mac/TextCodecMac.cpp:
1967         (WebCore::newTextCodecMac):
1968         * workers/Worker.cpp:
1969         (WebCore::Worker::notifyFinished):
1970
1971 2011-04-26  Justin Novosad  <junov@chromium.org>
1972
1973         Reviewed by Kenneth Russell.
1974
1975         [Chromium] Expose skia gpu canvas rendering as a runtime flag
1976         https://bugs.webkit.org/show_bug.cgi?id=58683
1977         Replace the SKIA_GPU compile flag by the pre-existing
1978         acceleratedDrawingEnabled flag. Most code changes are trivial:
1979         compile-time conditionals on SKIA_GPU were either replaced with
1980         a run-time check, or a compile time check on USE(SKIA) 
1981
1982         No new tests. Covered by existing tests.
1983
1984         * html/canvas/CanvasRenderingContext2D.cpp:
1985         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
1986         * page/Page.cpp:
1987         (WebCore::Page::sharedGraphicsContext3D):
1988         Added check for the acceleratedDrawing flag.
1989         * platform/graphics/chromium/DrawingBufferChromium.cpp:
1990         (WebCore::DrawingBuffer::DrawingBuffer):
1991         (WebCore::DrawingBuffer::publishToPlatformLayer):
1992         * platform/graphics/gpu/DrawingBuffer.h:
1993         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
1994         (WebCore::SharedGraphicsContext3D::create):
1995         On Skia builds, this methos now receives a bool arg to turn on
1996         GPU-accelerated skia rendering
1997         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
1998         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
1999         (WebCore::SharedGraphicsContext3D::grContext):
2000         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2001         * platform/graphics/skia/ImageSkia.cpp:
2002         (WebCore::computeResamplingMode):
2003         (WebCore::paintSkBitmap):
2004         (WebCore::Image::drawPattern):
2005         * platform/graphics/skia/PlatformContextSkia.cpp:
2006         (WebCore::PlatformContextSkia::PlatformContextSkia):
2007         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2008         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2009         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2010         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2011         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2012         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2013         (WebCore::PlatformContextSkia::markDirtyRect):
2014         * platform/graphics/skia/PlatformContextSkia.h:
2015         (WebCore::PlatformContextSkia::accelerationMode):
2016         (WebCore::PlatformContextSkia::useGPU):
2017         (WebCore::PlatformContextSkia::useSkiaGPU):
2018
2019 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2020
2021         Not reviewed: restore inspector test disabled in r84913.
2022
2023         Test: http/tests/inspector-enabled/dom-storage-open.html
2024
2025         * inspector/InspectorDOMStorageAgent.cpp:
2026         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2027
2028 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2029
2030         Reviewed by Tony Chang.
2031
2032         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2033         https://bugs.webkit.org/show_bug.cgi?id=59182
2034
2035         Use vertical offsets of the shaping results.
2036
2037         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2038
2039         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2040         (WebCore::ComplexTextController::ComplexTextController):
2041         Added initialization of m_startingY.
2042         (WebCore::ComplexTextController::nextScriptRun):
2043         Followed the change in handling positions.
2044         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2045         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2046         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2047         (WebCore::ComplexTextController::setGlyphPositions):
2048         Changed to use vertical offsets as same as horizontal offsets.
2049         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2050         Removed m_xPositions and Added m_positions and m_startingY.
2051         (WebCore::ComplexTextController::positions): Added.
2052         * platform/graphics/chromium/FontLinux.cpp:
2053         Followed the change in ComplexTextController.
2054         (WebCore::Font::drawComplexText): Ditto.
2055         (WebCore::Font::floatWidthForComplexText): Ditto.
2056         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2057         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2058         (WebCore::Font::selectionRectForComplexText): Ditto.
2059
2060 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2061
2062         Reviewed by Eric Seidel.
2063
2064         Root element should establish a new block formatting context
2065         https://bugs.webkit.org/show_bug.cgi?id=54573
2066
2067         Always expanding the root renderer to include overhanging floats.
2068
2069         Test: fast/block/float/float-overhangs-root.html
2070
2071         * rendering/RenderBlock.cpp:
2072         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2073
2074 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2075
2076         Reviewed by Andreas Kling.
2077
2078         [Qt] Improper rendering of <button> tag when it contains a <br>
2079         https://bugs.webkit.org/show_bug.cgi?id=50521
2080
2081         Test: platform/qt/fast/forms/button-line-break.html
2082
2083         * platform/qt/RenderThemeQt.cpp:
2084         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2085         (WebCore::RenderThemeQt::setButtonPadding):
2086
2087 2011-04-26  James Robinson  <jamesr@chromium.org>
2088
2089         Reviewed by Kenneth Russell.
2090
2091         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2092         https://bugs.webkit.org/show_bug.cgi?id=59572
2093
2094         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2095         when LayerRendererChromium was set.  We set this pointer every frame
2096         and should only reset the tiles if the new LayerRendererChromium is
2097         different from the old one (indicating a context loss), not just reset
2098         on every frame.
2099
2100         * platform/graphics/chromium/LayerTilerChromium.cpp:
2101         (WebCore::LayerTilerChromium::setLayerRenderer):
2102         * platform/graphics/chromium/LayerTilerChromium.h:
2103
2104 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2105
2106         Reviewed by Eric Seidel.
2107
2108         beginElement broken by setAttribute
2109         https://bugs.webkit.org/show_bug.cgi?id=26019
2110
2111         Test: svg/animations/animate-beginElementAt.svg
2112
2113         * svg/SVGAnimationElement.cpp:
2114         (WebCore::SVGAnimationElement::attributeChanged):
2115         Reset the animation state here as the rest of the code reads it and would still
2116         think we are animating when we are not.
2117
2118         * svg/animation/SVGSMILElement.h:
2119         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2120
2121 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2122
2123         Unreviewed, rolling out r84989.
2124         http://trac.webkit.org/changeset/84989
2125         https://bugs.webkit.org/show_bug.cgi?id=59566
2126
2127         REGRESSION (r84989): Lots of vertical text tests failing on
2128         windows (Requested by weinig on #webkit).
2129
2130         * platform/graphics/FontPlatformData.h:
2131         * platform/graphics/win/FontCacheWin.cpp:
2132         (WebCore::FontCache::getFontDataForCharacters):
2133         (WebCore::FontCache::createFontPlatformData):
2134         * platform/graphics/win/FontCustomPlatformData.cpp:
2135         (WebCore::FontCustomPlatformData::fontPlatformData):
2136         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2137         (WebCore::FontPlatformData::FontPlatformData):
2138         * platform/graphics/win/FontPlatformDataWin.cpp:
2139         (WebCore::FontPlatformData::FontPlatformData):
2140
2141 2011-04-26  Sam Weinig  <sam@webkit.org>
2142
2143         Reviewed by Eric Seidel.
2144
2145         Try again:
2146             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2147             https://bugs.webkit.org/show_bug.cgi?id=59310
2148
2149         * bindings/js/JSDOMBinding.h:
2150         (WebCore::DOMConstructorObject::DOMConstructorObject):
2151         * bindings/js/JSDOMWrapper.h:
2152         (WebCore::JSDOMWrapper::globalObject):
2153         (WebCore::JSDOMWrapper::scriptExecutionContext):
2154         (WebCore::JSDOMWrapper::createStructure):
2155         (WebCore::JSDOMWrapper::JSDOMWrapper):
2156         * bindings/scripts/CodeGeneratorJS.pm:
2157
2158 2011-04-26  Sam Weinig  <sam@webkit.org>
2159
2160         Reviewed by David Hyatt.
2161
2162         Remove Datagrid from the tree
2163         https://bugs.webkit.org/show_bug.cgi?id=59543
2164
2165         * Android.derived.jscbindings.mk:
2166         * Android.derived.v8bindings.mk:
2167         * Android.jscbindings.mk:
2168         * Android.v8bindings.mk:
2169         * CMakeLists.txt:
2170         * CodeGenerators.pri:
2171         * Configurations/FeatureDefines.xcconfig:
2172         * DerivedSources.cpp:
2173         * DerivedSources.make:
2174         * GNUmakefile.am:
2175         * GNUmakefile.list.am:
2176         * UseJSC.cmake:
2177         * WebCore.gypi:
2178         * WebCore.pro:
2179         * WebCore.vcproj/WebCore.vcproj:
2180         * WebCore.xcodeproj/project.pbxproj:
2181         * bindings/js/JSBindingsAllInOne.cpp:
2182         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2183         * bindings/js/JSDataGridDataSource.cpp: Removed.
2184         * bindings/js/JSDataGridDataSource.h: Removed.
2185         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2186         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2187         * bindings/v8/V8DataGridDataSource.h: Removed.
2188         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2189         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2190         * css/CSSStyleSelector.cpp:
2191         * css/CSSStyleSelector.h:
2192         * css/html.css:
2193         (input, textarea, keygen, select, button, isindex):
2194         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2195         * editing/htmlediting.cpp:
2196         (WebCore::canHaveChildrenForEditing):
2197         * features.pri:
2198         * html/DOMDataGridDataSource.cpp: Removed.
2199         * html/DOMDataGridDataSource.h: Removed.
2200         * html/DataGridColumn.cpp: Removed.
2201         * html/DataGridColumn.h: Removed.
2202         * html/DataGridColumn.idl: Removed.
2203         * html/DataGridColumnList.cpp: Removed.
2204         * html/DataGridColumnList.h: Removed.
2205         * html/DataGridColumnList.idl: Removed.
2206         * html/DataGridDataSource.h: Removed.
2207         * html/HTMLDataGridCellElement.cpp: Removed.
2208         * html/HTMLDataGridCellElement.h: Removed.
2209         * html/HTMLDataGridCellElement.idl: Removed.
2210         * html/HTMLDataGridColElement.cpp: Removed.
2211         * html/HTMLDataGridColElement.h: Removed.
2212         * html/HTMLDataGridColElement.idl: Removed.
2213         * html/HTMLDataGridElement.cpp: Removed.
2214         * html/HTMLDataGridElement.h: Removed.
2215         * html/HTMLDataGridElement.idl: Removed.
2216         * html/HTMLDataGridRowElement.cpp: Removed.
2217         * html/HTMLDataGridRowElement.h: Removed.
2218         * html/HTMLDataGridRowElement.idl: Removed.
2219         * html/HTMLElement.cpp:
2220         (WebCore::HTMLElement::ieForbidsInsertHTML):
2221         * html/HTMLElementsAllInOne.cpp:
2222         * html/HTMLTagNames.in:
2223         * page/DOMWindow.idl:
2224         * rendering/RenderBox.cpp:
2225         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2226         * rendering/RenderDataGrid.cpp: Removed.
2227         * rendering/RenderDataGrid.h: Removed.
2228         * rendering/RenderingAllInOne.cpp:
2229
2230 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2231
2232         Reviewed by Adele Peterson.
2233
2234         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2235         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2236
2237         This platform dependent patch makes WebKit (Windows) show the
2238         vertical writing text correctly.  Job was done by adding a prefix '@'
2239         in front of the font family name (Windows Only). No new tests added.
2240         Some layout tests images:
2241         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2242
2243         * platform/graphics/FontPlatformData.h:
2244         * platform/graphics/win/FontCacheWin.cpp:
2245         (WebCore::FontCache::getFontDataForCharacters):
2246         (WebCore::FontCache::createFontPlatformData):
2247         * platform/graphics/win/FontCustomPlatformData.cpp:
2248         (WebCore::FontCustomPlatformData::fontPlatformData):
2249         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2250         (WebCore::FontPlatformData::FontPlatformData):
2251         * platform/graphics/win/FontPlatformDataWin.cpp:
2252         (WebCore::FontPlatformData::FontPlatformData):
2253
2254 2011-04-26  Jer Noble  <jer.noble@apple.com>
2255
2256         Reviewed by Brady Eidson.
2257
2258         HTML5 video fullscreen transition causes an audio stutter
2259         https://bugs.webkit.org/show_bug.cgi?id=59544
2260
2261         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2262         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2263         layer to render it invisible, instead just set the layer as hidden.
2264
2265         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2266         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2267         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2268         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2269         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2270         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2271
2272 2011-04-26  Christian Dywan  <christian@lanedo.com>
2273
2274         Reviewed by Eric Seidel.
2275
2276         Extra separator after Select All in context menu
2277         https://bugs.webkit.org/show_bug.cgi?id=54092
2278
2279         * page/ContextMenuController.cpp: Move separator to non-GTK+
2280             port guards since it is for the spelling options menu
2281             which the GTK+ port doesn't use.
2282
2283 2011-04-26  James Robinson  <jamesr@chromium.org>
2284
2285         Reviewed by Kenneth Russell.
2286
2287         [chromium] Clear out LayerTilerChromium's tiles on lost context
2288         https://bugs.webkit.org/show_bug.cgi?id=59233
2289
2290         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
2291         no longer valid since they exist in the previous LayerRendererChromium.
2292
2293         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
2294
2295         * platform/graphics/chromium/LayerTilerChromium.h:
2296         (WebCore::LayerTilerChromium::setLayerRenderer):
2297
2298 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2299
2300         Reviewed by Dirk Schulze.
2301
2302         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
2303         https://bugs.webkit.org/show_bug.cgi?id=57644
2304
2305         Manual test: plugins/windowed-in-iframe-2.html
2306
2307         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
2308         * platform/gtk/WidgetGtk.cpp:
2309         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
2310         * plugins/PluginView.h: Added helper method to set the allocation and clip.
2311         * plugins/gtk/PluginViewGtk.cpp:
2312         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
2313         the allocation immediately. Bring this method into sync with the implementation in
2314         the Qt port.
2315         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
2316         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
2317
2318 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2319
2320         Reviewed by Eric Seidel.
2321
2322         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
2323         https://bugs.webkit.org/show_bug.cgi?id=58818
2324
2325         Prevent allocating scratch buffers larger than the target GdkDrawable
2326         when creating a WidgetRenderingContext. This prevents incredibly large
2327         widgets from crashing the X Server. This change also allowed greatly
2328         simplifying the way that the painting offset is calculated.
2329
2330         * platform/gtk/WidgetRenderingContext.cpp:
2331         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
2332         larger than the target GdkDrawable.
2333         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
2334         blit by looking at the location of the target rect itself, rather than delaying the
2335         calculation up to this point.
2336         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
2337         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
2338         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
2339         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
2340         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
2341         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
2342         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
2343         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
2344         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
2345         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
2346         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
2347         a member to store the IntSize mapping from the coordinates of the target to the coordinates
2348         of the scratch buffer.
2349
2350 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
2351
2352         Reviewed by Adam Barth.
2353
2354         Respect charset in handleDataURL
2355         https://bugs.webkit.org/show_bug.cgi?id=47746
2356
2357         Original patch by Kwang Yul Seo <skyul@company100.net>
2358
2359         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2360         returns an empty string because encoding name is not specified.
2361
2362         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2363
2364         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2365
2366         * platform/network/DataURL.cpp:
2367         (WebCore::handleDataURL):
2368
2369 2011-04-26  Anders Carlsson  <andersca@apple.com>
2370
2371         Fix clang++ build.
2372
2373         You can never have too many casts!
2374
2375         * accessibility/mac/AccessibilityObjectWrapper.mm:
2376         (-[AccessibilityObjectWrapper position]):
2377         * editing/mac/SelectionControllerMac.mm:
2378         (WebCore::accessibilityConvertScreenRect):
2379
2380 2011-04-26  Chris Rogers  <crogers@google.com>
2381
2382         Reviewed by Kenneth Russell.
2383
2384         Fix web audio build on mac port
2385         https://bugs.webkit.org/show_bug.cgi?id=59355
2386
2387         No new tests since audio API is not yet implemented.
2388
2389         * WebCore.xcodeproj/project.pbxproj:
2390         * bindings/js/JSAudioContextCustom.cpp:
2391         (WebCore::JSAudioContext::visitChildren):
2392         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
2393         (WebCore::JSJavaScriptAudioNode::visitChildren):
2394         * webaudio/AudioContext.idl:
2395
2396 2011-04-26  Chris Rogers  <crogers@google.com>
2397
2398         Reviewed by Kenneth Russell.
2399
2400         Add FFTFrame implementation for FFmpeg
2401         https://bugs.webkit.org/show_bug.cgi?id=59408
2402
2403         No new tests since audio API is not yet implemented.
2404
2405         * WebCore.gyp/WebCore.gyp:
2406         * WebCore.gypi:
2407         * platform/audio/FFTFrame.h:
2408         * platform/audio/FFTFrameStub.cpp:
2409         * platform/audio/ffmpeg: Added.
2410         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
2411         (WebCore::FFTFrame::FFTFrame):
2412         (WebCore::FFTFrame::initialize):
2413         (WebCore::FFTFrame::cleanup):
2414         (WebCore::FFTFrame::~FFTFrame):
2415         (WebCore::FFTFrame::multiply):
2416         (WebCore::FFTFrame::doFFT):
2417         (WebCore::FFTFrame::doInverseFFT):
2418         (WebCore::FFTFrame::realData):
2419         (WebCore::FFTFrame::imagData):
2420         (WebCore::FFTFrame::getUpToDateComplexData):
2421         (WebCore::FFTFrame::contextForSize):
2422         * platform/audio/mac/FFTFrameMac.cpp:
2423         * webaudio/ConvolverNode.cpp:
2424
2425 2011-04-26  Jeff Miller  <jeffm@apple.com>
2426
2427         Add a newline at the end of SVGFEDropShadowElement.idl.
2428
2429         * svg/SVGFEDropShadowElement.idl:
2430
2431 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2432
2433         Reviewed by Eric Seidel.
2434
2435         InlineBox.h shouldn't include RenderBR.h
2436         https://bugs.webkit.org/show_bug.cgi?id=59480
2437
2438         Per bug 59348 RenderBR.h is a "top header" by include * size, because
2439         InlineBox.h includes it. There's no reason why it has to.
2440
2441         * rendering/InlineBox.h:
2442         * rendering/InlineTextBox.cpp:
2443         * rendering/RenderBlock.h:
2444
2445 2011-04-26  Sam Weinig  <sam@webkit.org>
2446
2447         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
2448         I should do.
2449
2450         * bindings/js/JSDOMBinding.h:
2451         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2452         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2453         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2454         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2455         (WebCore::DOMConstructorObject::DOMConstructorObject):
2456         * bindings/js/JSDOMWrapper.h:
2457         (WebCore::JSDOMWrapper::JSDOMWrapper):
2458         * bindings/scripts/CodeGeneratorJS.pm:
2459
2460 2011-04-26  Sam Weinig  <sam@webkit.org>
2461
2462         Fix build.
2463
2464         * bindings/js/JSDOMWrapper.h:
2465         (WebCore::JSDOMWrapper::globalObject):
2466
2467 2011-04-26  Sam Weinig  <sam@webkit.org>
2468
2469         Roll r84945 back in with infinite recursion removed.
2470
2471         * bindings/js/JSDOMBinding.h:
2472         (WebCore::DOMConstructorObject::DOMConstructorObject):
2473         * bindings/js/JSDOMWrapper.h:
2474         (WebCore::JSDOMWrapper::globalObject):
2475         (WebCore::JSDOMWrapper::scriptExecutionContext):
2476         (WebCore::JSDOMWrapper::createStructure):
2477         (WebCore::JSDOMWrapper::JSDOMWrapper):
2478         * bindings/scripts/CodeGeneratorJS.pm:
2479
2480 2011-04-26  Sam Weinig  <sam@webkit.org>
2481
2482         Rollout previous patch. It broke stuff.
2483
2484         * bindings/js/JSDOMBinding.h:
2485         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2486         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2487         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2488         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2489         (WebCore::DOMConstructorObject::DOMConstructorObject):
2490         * bindings/js/JSDOMWrapper.h:
2491         (WebCore::JSDOMWrapper::JSDOMWrapper):
2492         * bindings/scripts/CodeGeneratorJS.pm:
2493
2494 2011-04-26  Sam Weinig  <sam@webkit.org>
2495
2496         Reviewed by Maciej Stachowiak.
2497
2498         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2499         https://bugs.webkit.org/show_bug.cgi?id=59310
2500
2501         * bindings/js/JSDOMBinding.h:
2502         (WebCore::DOMConstructorObject::DOMConstructorObject):
2503         * bindings/js/JSDOMWrapper.h:
2504         (WebCore::JSDOMWrapper::globalObject):
2505         (WebCore::JSDOMWrapper::scriptExecutionContext):
2506         (WebCore::JSDOMWrapper::createStructure):
2507         (WebCore::JSDOMWrapper::JSDOMWrapper):
2508         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
2509
2510         * bindings/scripts/CodeGeneratorJS.pm:
2511         Make JSDOMWrapper the base class.
2512
2513 2011-04-26  Dan Bernstein  <mitz@apple.com>
2514
2515         Reviewed by Mark Rowe.
2516
2517         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
2518
2519         * Configurations/Base.xcconfig:
2520         * Configurations/CompilerVersion.xcconfig: Added.
2521
2522 2011-04-26  Adrienne Walker  <enne@google.com>
2523
2524         Reviewed by Geoffrey Garen.
2525
2526         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
2527         https://bugs.webkit.org/show_bug.cgi?id=59469
2528
2529         * platform/chromium/TraceEvent.h:
2530         (WebCore::internal::ScopeTracer::ScopeTracer):
2531
2532 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2533
2534         Reviewed by Oliver Hunt.
2535
2536         Nixed special finalizer handling for WebCore strings
2537         https://bugs.webkit.org/show_bug.cgi?id=59425
2538
2539         Not needed anymore, since weak handles have finalizers.
2540
2541         * WebCore.exp.in: Exports!
2542
2543         * bindings/js/DOMWrapperWorld.cpp:
2544         (WebCore::JSStringOwner::finalize):
2545         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
2546         so we don't need special treatment anymore.
2547
2548         * bindings/js/DOMWrapperWorld.h:
2549         (WebCore::JSStringOwner::JSStringOwner):
2550         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
2551         instead of a WeakGCMap, so we can specify a custom finalizer.
2552
2553         * bindings/js/JSDOMBinding.cpp:
2554         (WebCore::jsStringSlowCase):
2555         * bindings/js/JSDOMBinding.h:
2556         (WebCore::jsString): Updated for string map change.
2557
2558 2011-04-26  David Kilzer  <ddkilzer@apple.com>
2559
2560         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
2561
2562         Reviewed by Antti Koivisto.
2563
2564         To enable HTTP pipelining post-SnowLeopard, use this command:
2565
2566             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
2567
2568         * platform/network/cf/ResourceRequestCFNet.cpp:
2569         (WebCore::readBooleanPreference): Re-added.  Originally added in
2570         r76756 and removed in r84120.
2571         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
2572         HTTP pipelining if use default is set to true.  Added macro
2573         guards to match those in ResourceRequestMac.mm.
2574
2575 2011-04-26  Antti Koivisto  <antti@apple.com>
2576
2577         Reviewed by Adele Peterson.
2578
2579         Don't strip fragments from file: urls in memory cache
2580         https://bugs.webkit.org/show_bug.cgi?id=59463
2581         <rdar://problem/9231130>
2582
2583         Some clients expect file: resources to be unique based on fragment identifier. 
2584         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
2585
2586         Test: fast/loader/file-protocol-fragment.html
2587
2588         * loader/cache/MemoryCache.cpp:
2589         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
2590
2591 2011-04-26  David Levin  <levin@chromium.org>
2592
2593         Reviewed by Darin Adler.
2594
2595         Fix more strict OwnPtr in WebCore (round N).
2596         https://bugs.webkit.org/show_bug.cgi?id=59464
2597
2598         * dom/Document.cpp:
2599         (WebCore::Document::Document):
2600         (WebCore::Document::attach):
2601         * fileapi/FileReader.cpp:
2602         (WebCore::FileReader::terminate):
2603         * loader/DocumentThreadableLoader.cpp:
2604         (WebCore::DocumentThreadableLoader::preflightFailure):
2605         * workers/DefaultSharedWorkerRepository.cpp:
2606         (WebCore::SharedWorkerConnectTask::create):
2607         (WebCore::SharedWorkerScriptLoader::load):
2608
2609 2011-04-26  Ruben  <chromium@hybridsource.org>
2610
2611         Reviewed by Tony Chang.
2612
2613         Change linux ifdefs for Chromium to Unix instead, allowing
2614         new Unix ports to be enabled by default
2615         https://bugs.webkit.org/show_bug.cgi?id=59297
2616
2617         No new tests, just changing preprocessor defines.
2618
2619         * bindings/js/JSInspectorFrontendHostCustom.cpp:
2620         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
2621         * dom/SelectElement.cpp:
2622         * loader/cache/CachedFont.cpp:
2623         * page/EventHandler.cpp:
2624         * page/chromium/EventHandlerChromium.cpp:
2625         * platform/Scrollbar.cpp:
2626         * platform/chromium/PlatformBridge.h:
2627         * platform/graphics/chromium/FontPlatformData.h:
2628         * platform/graphics/skia/FontCustomPlatformData.cpp:
2629         * platform/graphics/skia/FontCustomPlatformData.h:
2630
2631 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2632
2633         Reviewed by Dan Bernstein.
2634
2635         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
2636         https://bugs.webkit.org/show_bug.cgi?id=49111
2637
2638         Even when the offset corresponds to a position visually left of the box
2639         and there aren't any inline boxes on the left, the previous/next position
2640         may still correspond to some position in the same line.
2641
2642         The bug was caused by our ignoring such cases. Fixed the bug by comparing
2643         previous/next position's inline box to the current box. If they match,
2644         then we stay on the same position because moving to the left visually at
2645         the left edge should not result in a position on the same line.
2646
2647         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
2648         the left edge or to the right edge, and a bug that WebKit could not move to
2649         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
2650
2651         Test cases are added to editing/selection/move-left-right.html
2652
2653         * editing/VisiblePosition.cpp:
2654         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
2655         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
2656
2657 2011-04-26  Gabor Loki  <loki@webkit.org>
2658
2659         Reviewed by Csaba Osztrogon√°c.
2660
2661         Speeding up SVG filters with multicore (SMP) support
2662         https://bugs.webkit.org/show_bug.cgi?id=43903
2663
2664         Some SVG filters execute a huge number of pixel manipulations, which
2665         cannot be sped up by graphics accelerators, since their algorithm is
2666         too complex. Using the power of Symmetric Multi Processing (SMP) we
2667         can split up a task to smaller (data independent) tasks, which can be
2668         executed independently.
2669
2670         The ParallelJobs framework provides a simple way for distributed
2671         programming. The framework is based on WebKit's threading infrastructure,
2672         Open Multi-Processing's (OpenMP) API, and libdispatch API.
2673
2674         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
2675         * platform/graphics/filters/FETurbulence.cpp:
2676         (WebCore::FETurbulence::PaintingData::PaintingData):
2677         (WebCore::FETurbulence::noise2D):
2678         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
2679         (WebCore::FETurbulence::fillRegion):
2680         (WebCore::FETurbulence::fillRegionWorker):
2681         (WebCore::FETurbulence::apply):
2682         * platform/graphics/filters/FETurbulence.h:
2683
2684 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2685
2686         Reviewed by Yury Semikhatsky.
2687
2688         Web Inspector: close button is off in docked mode on a mac.
2689         https://bugs.webkit.org/show_bug.cgi?id=59453
2690
2691         * inspector/front-end/inspector.css:
2692         (.toolbar-item.close-left):
2693
2694 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2695
2696         Reviewed by Yury Semikhatsky.
2697
2698         Web Inspector: New Style is not working (UI glitch)
2699         https://bugs.webkit.org/show_bug.cgi?id=59451
2700
2701         * inspector/InspectorDOMStorageAgent.cpp:
2702         (WebCore::InspectorDOMStorageAgent::setFrontend):
2703         * inspector/front-end/AuditRules.js:
2704         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
2705         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
2706         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
2707         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
2708         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
2709         * inspector/front-end/CSSStyleModel.js:
2710         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
2711         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
2712         (WebInspector.CSSStyleModel.prototype.addRule):
2713         (WebInspector.CSSStyleModel.prototype.addRule.callback):
2714         (WebInspector.CSSStyleModel.prototype._documentElementId):
2715         * inspector/front-end/DOMAgent.js:
2716         (WebInspector.DOMNode.prototype._addAttribute):
2717         (WebInspector.DOMNode.prototype.documentElement):
2718         * inspector/front-end/ResourceTreeModel.js:
2719         (WebInspector.PageDispatcher.prototype.frameDetached):
2720         * inspector/front-end/StylesSidebarPane.js:
2721         (WebInspector.StylesSidebarPane.prototype._createNewRule):
2722
2723 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2724
2725         Reviewed by Yury Semikhatsky.
2726
2727         Web Inspector: introduce DOMStorage::enable and disable.
2728         https://bugs.webkit.org/show_bug.cgi?id=59445
2729
2730         * inspector/Inspector.json:
2731         * inspector/InspectorAgent.cpp:
2732         (WebCore::InspectorAgent::InspectorAgent):
2733         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2734         * inspector/InspectorDOMStorageAgent.cpp:
2735         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2736         (WebCore::InspectorDOMStorageAgent::restore):
2737         (WebCore::InspectorDOMStorageAgent::enable):
2738         (WebCore::InspectorDOMStorageAgent::disable):
2739         * inspector/InspectorDOMStorageAgent.h:
2740         (WebCore::InspectorDOMStorageAgent::create):
2741         * inspector/front-end/DOMStorage.js:
2742         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2743         * inspector/front-end/ResourcesPanel.js:
2744         (WebInspector.ResourcesPanel.prototype._reset):
2745         * inspector/front-end/inspector.js:
2746
2747 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2748
2749         Reviewed by Yury Semikhatsky.
2750
2751         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
2752         https://bugs.webkit.org/show_bug.cgi?id=59440
2753
2754         * inspector/Inspector.json:
2755         * inspector/InspectorAgent.cpp:
2756         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2757         * inspector/InspectorPageAgent.cpp:
2758         (WebCore::InspectorPageAgent::setFrontend):
2759         (WebCore::InspectorPageAgent::frameNavigated):
2760         * inspector/InspectorPageAgent.h:
2761         * inspector/front-end/AuditsPanel.js:
2762         (WebInspector.AuditsPanel):
2763         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
2764         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
2765         * inspector/front-end/CSSStyleModel.js:
2766         (WebInspector.CSSStyleModelResourceBinding):
2767         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
2768         * inspector/front-end/DOMBreakpointsSidebarPane.js:
2769         (WebInspector.DOMBreakpointsSidebarPane):
2770         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
2771         * inspector/front-end/DOMStorage.js:
2772         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2773         * inspector/front-end/ExtensionServer.js:
2774         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
2775         (WebInspector.ExtensionServer.prototype.initExtensions):
2776         * inspector/front-end/NetworkPanel.js:
2777         (WebInspector.NetworkPanel):
2778         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
2779         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
2780         (WebInspector.NetworkPanel.prototype._frameNavigated):
2781         * inspector/front-end/ResourceTreeModel.js:
2782         (WebInspector.ResourceTreeModel):
2783         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2784         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
2785         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2786         (WebInspector.ResourceTreeModel.prototype._frameDetached):
2787         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
2788         (WebInspector.PageDispatcher):
2789         (WebInspector.PageDispatcher.prototype.domContentEventFired):
2790         (WebInspector.PageDispatcher.prototype.loadEventFired):
2791         (WebInspector.PageDispatcher.prototype.frameNavigated):
2792         (WebInspector.PageDispatcher.prototype.frameDetached):
2793         * inspector/front-end/ResourcesPanel.js:
2794         (WebInspector.ResourcesPanel):
2795         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
2796         (WebInspector.ResourcesPanel.prototype._frameNavigated):
2797         * inspector/front-end/inspector.js:
2798
2799 2011-04-26  Csaba Osztrogon√°c  <ossy@webkit.org>
2800
2801         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
2802         because it broke transitions/multiple-text-shadow-transition.html
2803
2804         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2805         https://bugs.webkit.org/show_bug.cgi?id=59377
2806
2807         * css/CSSStyleSelector.cpp:
2808         (WebCore::CSSStyleSelector::applyProperty):
2809         * page/animation/AnimationBase.cpp:
2810         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2811         (WebCore::PropertyWrapperShadow::blend):
2812         * rendering/style/RenderStyle.cpp:
2813         (WebCore::RenderStyle::setTextShadow):
2814         (WebCore::RenderStyle::setBoxShadow):
2815         * rendering/style/RenderStyle.h:
2816         (WebCore::InheritedFlags::textShadow):
2817         * rendering/style/StyleRareInheritedData.cpp:
2818         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2819         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2820         * rendering/style/StyleRareInheritedData.h:
2821         * rendering/style/StyleRareNonInheritedData.cpp:
2822         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2823
2824 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2825
2826         Reviewed by Adam Barth.
2827
2828         Turn off make built-in implicit rules for derived sources makefile
2829         https://bugs.webkit.org/show_bug.cgi?id=59418
2830
2831         We don't use any of make's built-in implicit rules, turning them off
2832         speeds up parsing of the makefile.
2833
2834         * WebCore.xcodeproj/project.pbxproj:
2835         * gyp/generate-derived-sources.sh:
2836
2837 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
2838
2839         Reviewed by Nikolas Zimmermann.
2840
2841         ASSERT failure in SVGUseElement
2842         https://bugs.webkit.org/show_bug.cgi?id=59313
2843
2844         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
2845         was wrong because the document may not be well-formed.
2846
2847         This patch asserts the element is not pending on resource or the
2848         document is not well-formed.
2849
2850         Test: svg/custom/use-crash-in-non-wellformed-document.svg
2851
2852         * svg/SVGUseElement.cpp:
2853         (WebCore::isWellFormedDocument):
2854         (WebCore::SVGUseElement::insertedIntoDocument):
2855
2856 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
2857
2858         Reviewed by Pavel Feldman.
2859
2860         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
2861         https://bugs.webkit.org/show_bug.cgi?id=59438
2862
2863         * inspector/front-end/DetailedHeapshotView.js:
2864         (WebInspector.DetailedHeapshotView.prototype._changeView):
2865
2866 2011-04-26  David Levin  <levin@chromium.org>
2867
2868         Reviewed by Adam Barth.
2869
2870         Fix a few OwnPtr strict errors in WebCore headers.
2871         https://bugs.webkit.org/show_bug.cgi?id=59431
2872
2873         * bindings/js/ScheduledAction.cpp:
2874         (WebCore::ScheduledAction::create):
2875         * css/MediaQueryMatcher.cpp:
2876         (WebCore::MediaQueryMatcher::prepareEvaluator):
2877         * dom/NodeRareData.h:
2878         (WebCore::NodeListsNodeData::create):
2879         * dom/ScriptRunner.h:
2880         (WebCore::ScriptRunner::create):
2881         * inspector/WorkerInspectorController.cpp:
2882         (WebCore::WorkerInspectorController::connectFrontend):
2883         * loader/icon/IconDatabase.h:
2884         (WebCore::IconDatabase::create):
2885         * platform/graphics/SimpleFontData.cpp:
2886         (WebCore::SimpleFontData::verticalRightOrientationFontData):
2887         (WebCore::SimpleFontData::uprightOrientationFontData):
2888         (WebCore::SimpleFontData::brokenIdeographFontData):
2889         * rendering/style/StyleRareInheritedData.cpp:
2890         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2891         * rendering/svg/SVGResources.h:
2892         (WebCore::SVGResources::ClipperFilterMaskerData::create):
2893         (WebCore::SVGResources::MarkerData::create):
2894         (WebCore::SVGResources::FillStrokeData::create):
2895         * storage/StorageSyncManager.cpp:
2896         (WebCore::StorageSyncManager::close):
2897         * workers/WorkerContext.cpp:
2898         (WebCore::CloseWorkerContextTask::create):
2899         * workers/WorkerMessagingProxy.cpp:
2900         (WebCore::MessageWorkerContextTask::create):
2901         (WebCore::MessageWorkerTask::create):
2902         (WebCore::WorkerExceptionTask::create):
2903         (WebCore::WorkerContextDestroyedTask::create):
2904         (WebCore::WorkerTerminateTask::create):
2905         (WebCore::WorkerThreadActivityReportTask::create):
2906         * workers/WorkerRunLoop.cpp:
2907         (WebCore::WorkerRunLoop::Task::create):
2908         * workers/WorkerThread.cpp:
2909         (WebCore::WorkerThreadStartupData::create):
2910         (WebCore::WorkerThreadShutdownFinishTask::create):
2911         (WebCore::WorkerThreadShutdownStartTask::create):
2912
2913 2011-04-26  Adam Klein  <adamk@chromium.org>
2914
2915         Reviewed by Adam Barth.
2916
2917         Fix last strict OwnPtr violation under svg/...
2918         https://bugs.webkit.org/show_bug.cgi?id=59429
2919
2920         * svg/SVGDocumentExtensions.cpp:
2921         (WebCore::SVGDocumentExtensions::removePendingResource):
2922
2923 2011-04-26  Adam Barth  <abarth@webkit.org>
2924
2925         Reviewed by David Levin.
2926
2927         Fix more strict OwnPtr violations in WebCore
2928         https://bugs.webkit.org/show_bug.cgi?id=59433
2929
2930         These manifest in the Chromium build.
2931
2932         * bindings/v8/ScriptController.cpp:
2933         (WebCore::ScriptController::ScriptController):
2934         * bindings/v8/ScriptDebugServer.cpp:
2935         (WebCore::ScriptDebugServer::editScriptSource):
2936         * bindings/v8/V8DOMMap.cpp:
2937         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
2938         * bindings/v8/V8Proxy.cpp:
2939         (WebCore::V8Proxy::precompileScript):
2940         * bindings/v8/WorkerScriptController.cpp:
2941         (WebCore::WorkerScriptController::WorkerScriptController):
2942         * page/Page.cpp:
2943         (WebCore::Page::Page):
2944         (WebCore::Page::speechInput):
2945         * platform/PlatformGestureRecognizer.cpp:
2946         (WebCore::PlatformGestureRecognizer::create):
2947         * platform/PlatformGestureRecognizer.h:
2948         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2949         (WebCore::DrawingBuffer::DrawingBuffer):
2950         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2951         (WebCore::CCLayerImpl::CCLayerImpl):
2952         * platform/graphics/gpu/Texture.cpp:
2953         (WebCore::Texture::create):
2954         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
2955         (WebCore::BMPImageDecoder::decodeHelper):
2956         * platform/image-decoders/gif/GIFImageDecoder.cpp:
2957         (WebCore::GIFImageDecoder::decode):
2958         * platform/image-decoders/ico/ICOImageDecoder.cpp:
2959         (WebCore::ICOImageDecoder::decodeAtIndex):
2960         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
2961         (WebCore::JPEGImageDecoder::decode):
2962         * platform/image-decoders/png/PNGImageDecoder.cpp:
2963         (WebCore::PNGImageDecoder::decode):
2964         * storage/chromium/DatabaseTrackerChromium.cpp:
2965         (WebCore::DatabaseTracker::addOpenDatabase):
2966
2967 2011-04-25  David Levin  <levin@chromium.org>
2968
2969         Reviewed by Adam Barth.
2970
2971         Fix OwnPtr strict errors in CrossThreadTask.h
2972         https://bugs.webkit.org/show_bug.cgi?id=59427
2973
2974         * dom/CrossThreadTask.h:
2975         (WebCore::CrossThreadTask1::create):
2976         (WebCore::CrossThreadTask2::create):
2977         (WebCore::CrossThreadTask3::create):
2978         (WebCore::CrossThreadTask4::create):
2979         (WebCore::CrossThreadTask5::create):
2980         (WebCore::CrossThreadTask6::create):
2981         (WebCore::CrossThreadTask7::create):
2982         (WebCore::CrossThreadTask8::create):
2983
2984 2011-04-25  Mark Rowe  <mrowe@apple.com>
2985
2986         Reviewed by Dan Bernstein.
2987
2988         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
2989
2990         * css/CSSStyleApplyProperty.cpp:
2991         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
2992         * css/CSSStyleApplyProperty.h:
2993         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
2994
2995 2011-04-25  Levi Weintraub  <leviw@chromium.org>
2996
2997         Reviewed by Ryosuke Niwa.
2998
2999         REGRESSION: a character appears after tab span when typing immediately before the tab span
3000         https://bugs.webkit.org/show_bug.cgi?id=58132
3001
3002         Correcting the order of operations we use to avoid inserting into invalid positions in
3003         ReplaceSelectionCommand to avoid inserting into tab-spans.
3004
3005         Test: editing/pasteboard/paste-before-tab-span.html
3006
3007         * editing/ReplaceSelectionCommand.cpp:
3008         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
3009         positionAvoidingPrecedingNodes, since that function could once again put our position
3010         inside a tab span.
3011
3012 2011-04-25  David Levin  <levin@chromium.org>
3013
3014         Reviewed by Adam Barth.
3015
3016         Fix OwnPtr strict error in ImageBuffer.h
3017         https://bugs.webkit.org/show_bug.cgi?id=59422
3018
3019         * platform/graphics/ImageBuffer.h:
3020         (WebCore::ImageBuffer::create):
3021
3022 2011-04-25  Adam Barth  <abarth@webkit.org>
3023
3024         Reviewed by David Levin.
3025
3026         Fix strict OwnPtr violations and whitelist known-tricky files
3027         https://bugs.webkit.org/show_bug.cgi?id=59421
3028
3029         With this patch, WebCore builds cleanly with strict OwnPtrs.
3030
3031         * dom/MessagePort.cpp:
3032         (WebCore::MessagePort::MessagePort):
3033         * dom/XMLDocumentParserLibxml2.cpp:
3034         * page/ContextMenuController.cpp:
3035         (WebCore::ContextMenuController::ContextMenuController):
3036         (WebCore::ContextMenuController::clearContextMenu):
3037         * page/PluginHalter.cpp:
3038         * platform/graphics/MediaPlayer.cpp:
3039         * platform/network/ResourceRequestBase.cpp:
3040         (WebCore::ResourceRequestBase::adopt):
3041         (WebCore::ResourceRequestBase::copyData):
3042         * svg/SVGDocumentExtensions.cpp:
3043
3044 2011-04-25  David Levin  <levin@chromium.org>
3045
3046         Reviewed by Adam Barth.
3047
3048         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
3049         https://bugs.webkit.org/show_bug.cgi?id=59419
3050
3051         * dom/DatasetDOMStringMap.h:
3052         (WebCore::DatasetDOMStringMap::create):
3053
3054 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3055
3056         Reviewed by Eric Seidel.
3057
3058         KeyboardEvent.cpp should work with strict OwnPtrs.
3059         https://bugs.webkit.org/show_bug.cgi?id=59403
3060
3061         * dom/KeyboardEvent.cpp:
3062         (WebCore::KeyboardEvent::KeyboardEvent):
3063
3064 2011-04-25  James Robinson  <jamesr@chromium.org>
3065
3066         Reviewed by Eric Seidel.
3067
3068         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3069         https://bugs.webkit.org/show_bug.cgi?id=59377
3070
3071         * css/CSSStyleSelector.cpp:
3072         (WebCore::CSSStyleSelector::applyProperty):
3073         * page/animation/AnimationBase.cpp:
3074         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3075         (WebCore::PropertyWrapperShadow::blend):
3076         * rendering/style/RenderStyle.cpp:
3077         (WebCore::RenderStyle::setTextShadow):
3078         (WebCore::RenderStyle::setBoxShadow):
3079         * rendering/style/RenderStyle.h:
3080         (WebCore::InheritedFlags::textShadow):
3081         * rendering/style/StyleRareInheritedData.cpp:
3082         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3083         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3084         * rendering/style/StyleRareInheritedData.h:
3085         * rendering/style/StyleRareNonInheritedData.cpp:
3086         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3087
3088 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3089
3090         Unreviewed, rolling out r84864.
3091         http://trac.webkit.org/changeset/84864
3092         https://bugs.webkit.org/show_bug.cgi?id=59413
3093
3094         Expect result of use-crash-in-non-wellformed-document.svg is
3095         platform dependent (Requested by leoyang on #webkit).
3096
3097         * svg/SVGUseElement.cpp:
3098         (WebCore::SVGUseElement::insertedIntoDocument):
3099
3100 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
3101
3102         Reviewed by Nikolas Zimmermann.
3103
3104         ASSERT failure in SVGUseElement
3105         https://bugs.webkit.org/show_bug.cgi?id=59313
3106
3107         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3108         was wrong because the document may not be well-formed.
3109
3110         This patch asserts the element is not pending on resource or the
3111         document is not well-formed.
3112
3113         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3114
3115         * svg/SVGUseElement.cpp:
3116         (WebCore::isWellFormedDocument):
3117         (WebCore::SVGUseElement::insertedIntoDocument):
3118
3119 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3120
3121         Reviewed by Tony Chang.
3122
3123         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3124         https://bugs.webkit.org/show_bug.cgi?id=59028
3125
3126         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3127         Moving the code for base class we can reduce the efforts to support DataTransferItems
3128         element in different platforms.
3129
3130         * Android.mk:
3131         * CMakeLists.txt:
3132         * GNUmakefile.list.am:
3133         * WebCore.gypi:
3134         * WebCore.pro:
3135         * WebCore.vcproj/WebCore.vcproj:
3136         * WebCore.xcodeproj/project.pbxproj:
3137         * dom/DataTransferItem.cpp:
3138         (WebCore::DataTransferItem::DataTransferItem):
3139         (WebCore::DataTransferItem::owner):
3140         (WebCore::DataTransferItem::kind):
3141         (WebCore::DataTransferItem::type):
3142         * dom/DataTransferItem.h:
3143         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3144         (WebCore::DataTransferItems::DataTransferItems):
3145         (WebCore::DataTransferItems::length):
3146         (WebCore::DataTransferItems::item):
3147         (WebCore::DataTransferItems::deleteItem):
3148         (WebCore::DataTransferItems::clear):
3149         (WebCore::DataTransferItems::add):
3150         * dom/DataTransferItems.h:
3151         * platform/chromium/DataTransferItemChromium.cpp:
3152         (WebCore::DataTransferItem::create):
3153         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3154         (WebCore::DataTransferItemChromium::getAsString):
3155         (WebCore::DataTransferItemChromium::getAsFile):
3156         * platform/chromium/DataTransferItemChromium.h:
3157         * platform/chromium/DataTransferItemsChromium.cpp:
3158         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3159         * platform/chromium/DataTransferItemsChromium.h:
3160
3161 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3162
3163         Reviewed by Simon Fraser.
3164
3165         REGRESSION(75137): directly composited images are double-drawn sometimes
3166         https://bugs.webkit.org/show_bug.cgi?id=58632
3167
3168         Depending on the order of operations (layout, creating compositing 
3169         layers and creating simple image layers) a layer can have both image
3170         content and have m_drawsContent=true. In this case 2 copies of the image
3171         are drawn in the layer. If the image has alpha, it looks wrong.
3172
3173         I added an updateDrawsContent() call after setting the image contents
3174         to make sure it's correct.
3175
3176         I couldn't create a test case that shows the problem because layerTreeAsText()
3177         doesn't emit enough info to show this level of detail. I've opened
3178         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3179
3180         * rendering/RenderLayerBacking.cpp:
3181         (WebCore::RenderLayerBacking::updateImageContents):
3182
3183 2011-04-25  Kenneth Russell  <kbr@google.com>
3184
3185         Reviewed by David Levin.
3186
3187         Fix OwnPtr strict errors in InlineFlowBox.cpp
3188         https://bugs.webkit.org/show_bug.cgi?id=59392
3189
3190         * rendering/InlineFlowBox.cpp:
3191         (WebCore::InlineFlowBox::setLayoutOverflow):
3192         (WebCore::InlineFlowBox::setVisualOverflow):
3193
3194 2011-04-25  Kenneth Russell  <kbr@google.com>
3195
3196         Reviewed by David Levin.
3197
3198         Fix OwnPtr strict errors in TransformState.cpp
3199         https://bugs.webkit.org/show_bug.cgi?id=59380
3200
3201         * rendering/TransformState.cpp:
3202         (WebCore::TransformState::applyTransform):
3203
3204 2011-04-25  Adam Barth  <abarth@webkit.org>
3205
3206         Reviewed by James Robinson.
3207
3208         DOMWindow.cpp should work with strict OwnPtrs
3209         https://bugs.webkit.org/show_bug.cgi?id=59356
3210
3211         * page/DOMWindow.cpp:
3212         (WebCore::PostMessageTimer::fired):
3213         (WebCore::DOMWindow::postMessageTimerFired):
3214         * page/DOMWindow.h:
3215
3216 2011-04-25  Adam Klein  <adamk@chromium.org>
3217
3218         Reviewed by James Robinson.
3219
3220         Fix OwnPtr strict errors in some SVG classes.
3221         https://bugs.webkit.org/show_bug.cgi?id=59395
3222
3223         * rendering/style/SVGRenderStyleDefs.cpp:
3224         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3225         * svg/SVGSVGElement.cpp:
3226         (WebCore::SVGSVGElement::SVGSVGElement):
3227         * svg/SVGStyledTransformableElement.cpp:
3228         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3229         * svg/SVGTextElement.cpp:
3230         (WebCore::SVGTextElement::supplementalTransform):
3231         * svg/graphics/SVGImage.cpp:
3232         (WebCore::SVGImage::dataChanged):
3233
3234 2011-04-25  Adam Barth  <abarth@webkit.org>
3235
3236         Re-land changes to ValidationMessage.
3237
3238         * html/ValidationMessage.cpp:
3239         (WebCore::ValidationMessage::setMessage):
3240         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3241         (WebCore::ValidationMessage::requestToHideMessage):
3242
3243 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3244
3245         Reviewed by James Robinson.
3246
3247         fix OwnPtr strict error in FrameView.cpp
3248         https://bugs.webkit.org/show_bug.cgi?id=59402
3249
3250         * page/FrameView.cpp:
3251         (WebCore::FrameView::FrameView):
3252         (WebCore::FrameView::addWidgetToUpdate):
3253
3254 2011-04-25  Adam Klein  <adamk@chromium.org>
3255
3256         Unreviewed, rolling out r84844.
3257         http://trac.webkit.org/changeset/84844
3258         https://bugs.webkit.org/show_bug.cgi?id=59395
3259
3260         Checked in too much.
3261
3262         * rendering/style/SVGRenderStyleDefs.cpp:
3263         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3264         * svg/SVGDocumentExtensions.cpp:
3265         (WebCore::SVGDocumentExtensions::removePendingResource):
3266         * svg/SVGSVGElement.cpp:
3267         (WebCore::SVGSVGElement::SVGSVGElement):
3268         * svg/SVGStyledTransformableElement.cpp:
3269         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3270         * svg/SVGTextElement.cpp:
3271         (WebCore::SVGTextElement::supplementalTransform):
3272         * svg/graphics/SVGImage.cpp:
3273         (WebCore::SVGImage::dataChanged):
3274
3275 2011-04-25  Adrienne Walker  <enne@google.com>
3276
3277         Reviewed by David Levin.
3278
3279         Make ActiveDOMCallback play nice with OwnPtr strict mode
3280         https://bugs.webkit.org/show_bug.cgi?id=59398
3281
3282         * bindings/generic/ActiveDOMCallback.cpp:
3283         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
3284
3285 2011-04-25  Adam Klein  <adamk@chromium.org>
3286
3287         Reviewed by James Robinson.
3288
3289         Fix OwnPtr strict errors in some SVG classes.
3290         https://bugs.webkit.org/show_bug.cgi?id=59395
3291
3292         * rendering/style/SVGRenderStyleDefs.cpp:
3293         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3294         * svg/SVGSVGElement.cpp:
3295         (WebCore::SVGSVGElement::SVGSVGElement):
3296         * svg/SVGStyledTransformableElement.cpp:
3297         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3298         * svg/SVGTextElement.cpp:
3299         (WebCore::SVGTextElement::supplementalTransform):
3300         * svg/graphics/SVGImage.cpp:
3301         (WebCore::SVGImage::dataChanged):
3302
3303 2011-04-25  James Robinson  <jamesr@chromium.org>
3304
3305         Unreviewed, rolling out r84835.
3306         http://trac.webkit.org/changeset/84835
3307         https://bugs.webkit.org/show_bug.cgi?id=59394
3308
3309         Breaks compile because Deque<OwnPtr> doesn't work
3310
3311         * dom/XMLDocumentParserLibxml2.cpp:
3312         (WebCore::PendingCallbacks::~PendingCallbacks):
3313         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3314         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3315         (WebCore::PendingCallbacks::appendCharactersCallback):
3316         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3317         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3318         (WebCore::PendingCallbacks::appendCommentCallback):
3319         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3320         (WebCore::PendingCallbacks::appendErrorCallback):
3321         (WebCore::XMLDocumentParser::XMLDocumentParser):
3322         * html/ValidationMessage.cpp:
3323         (WebCore::ValidationMessage::setMessage):
3324         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3325         (WebCore::ValidationMessage::requestToHideMessage):
3326
3327 2011-04-25  James Robinson  <jamesr@chromium.org>
3328
3329         Reviewed by Sam Weinig.
3330
3331         Fix OwnPtr strict mode violation in ImageBufferCG
3332         https://bugs.webkit.org/show_bug.cgi?id=59396
3333
3334         * platform/graphics/cg/ImageBufferCG.cpp:
3335         (WebCore::ImageBuffer::ImageBuffer):
3336
3337 2011-04-25  Huang Dongsung  <luxtella@company100.net>
3338
3339         Reviewed by Dirk Schulze.
3340
3341         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
3342         https://bugs.webkit.org/show_bug.cgi?id=59308
3343
3344         An unused local variable is created and even allocates heap memory.
3345
3346         * platform/graphics/skia/PlatformContextSkia.cpp:
3347         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
3348
3349 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3350
3351         Qt build fix: Updated files not used by other ports for rename.
3352
3353         * bindings/js/JSTouchCustom.cpp:
3354         (WebCore::toJSNewlyCreated):
3355         * bindings/js/JSTouchListCustom.cpp:
3356         (WebCore::toJSNewlyCreated):
3357
3358 2011-04-25  Adrienne Walker  <enne@google.com>
3359
3360         Reviewed by David Levin.
3361
3362         WebCore/css/CSS* files should play nice with strict OwnPtrs
3363         https://bugs.webkit.org/show_bug.cgi?id=59382
3364
3365         * css/CSSFontFaceSource.cpp:
3366         (WebCore::CSSFontFaceSource::getFontData):
3367         * css/CSSParser.cpp:
3368         (WebCore::CSSParser::addProperty):
3369         (WebCore::CSSParser::parseValue):
3370
3371 2011-04-25  Adam Barth  <abarth@webkit.org>
3372
3373         Reviewed by James Robinson.
3374
3375         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
3376         https://bugs.webkit.org/show_bug.cgi?id=59394
3377
3378         * dom/XMLDocumentParserLibxml2.cpp:
3379         (WebCore::PendingCallbacks::PendingCallbacks):
3380         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3381         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3382         (WebCore::PendingCallbacks::appendCharactersCallback):
3383         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3384         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3385         (WebCore::PendingCallbacks::appendCommentCallback):
3386         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3387         (WebCore::PendingCallbacks::appendErrorCallback):
3388         (WebCore::XMLDocumentParser::XMLDocumentParser):
3389         * html/ValidationMessage.cpp:
3390         (WebCore::ValidationMessage::setMessage):
3391         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3392         (WebCore::ValidationMessage::requestToHideMessage):
3393
3394 2011-04-25  James Robinson  <jamesr@chromium.org>
3395
3396         Reviewed by Adam Barth.
3397
3398         Fix OwnPtr strictness issues in WebCore/inspector/
3399         https://bugs.webkit.org/show_bug.cgi?id=59387
3400
3401         * inspector/InspectorAgent.cpp:
3402         (WebCore::InspectorAgent::InspectorAgent):
3403         * inspector/InspectorController.cpp:
3404         (WebCore::InspectorController::InspectorController):
3405         * inspector/InspectorStyleSheet.cpp:
3406         (WebCore::InspectorStyleSheet::ensureSourceData):
3407
3408 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3409
3410         Reviewed by Beth Dakin.
3411
3412         Removed XPathNamespace because it was unused
3413         https://bugs.webkit.org/show_bug.cgi?id=59381
3414         
3415         This allows us to make Node::ownerDocument() non-virtual, though it has
3416         the unhappy side-effect of rebuilding the world.
3417
3418         * CMakeLists.txt:
3419         * GNUmakefile.list.am:
3420         * WebCore.gypi:
3421         * WebCore.pro:
3422         * WebCore.vcproj/WebCore.vcproj:
3423         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
3424
3425         * dom/Node.h: Hello fast code!
3426
3427         * xml/XPathNamespace.cpp: Removed.
3428         * xml/XPathNamespace.h: Removed.
3429
3430 2011-04-25  Adam Barth  <abarth@webkit.org>
3431
3432         Reviewed by Darin Adler.
3433
3434         HistoryItemMac should play nice with OwnPtrs
3435         https://bugs.webkit.org/show_bug.cgi?id=59388
3436
3437         * history/mac/HistoryItemMac.mm:
3438         (WebCore::HistoryItem::setTransientProperty):
3439
3440 2011-04-25  David Levin  <levin@chromium.org>
3441
3442         Reviewed by Kenneth Russell.
3443
3444         Fix strict OwnPtrs in ContextMenuController.cpp
3445         https://bugs.webkit.org/show_bug.cgi?id=59375
3446
3447         * page/ContextMenuController.cpp:
3448         (WebCore::ContextMenuController::createContextMenu):
3449         (WebCore::separatorItem):
3450
3451 2011-04-25  Adam Barth  <abarth@webkit.org>
3452
3453         Reviewed by Darin Adler.
3454
3455         CheckedRadioButton should play nice with strict OwnPtr
3456         https://bugs.webkit.org/show_bug.cgi?id=59386
3457
3458         * dom/CheckedRadioButtons.cpp:
3459         (WebCore::CheckedRadioButtons::addButton):
3460
3461 2011-04-25  Adam Barth  <abarth@webkit.org>
3462
3463         Reviewed by David Levin.
3464
3465         Resource*.cpp should play nice with strict OwnPtrs
3466         https://bugs.webkit.org/show_bug.cgi?id=59383
3467
3468         * bridge/runtime_method.cpp:
3469         (JSC::RuntimeMethod::RuntimeMethod):
3470         * platform/network/ResourceHandle.cpp:
3471         (WebCore::ResourceHandle::ResourceHandle):
3472         * platform/network/ResourceResponseBase.cpp:
3473         (WebCore::ResourceResponseBase::adopt):
3474         (WebCore::ResourceResponseBase::copyData):
3475
3476 2011-04-25  Adam Barth  <abarth@webkit.org>
3477
3478         Reviewed by David Levin.
3479
3480         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
3481         https://bugs.webkit.org/show_bug.cgi?id=59374
3482
3483         * bridge/objc/objc_runtime.mm:
3484         (JSC::Bindings::callObjCFallbackObject):
3485         * page/Page.cpp:
3486         (WebCore::Page::Page):
3487         (WebCore::Page::initGroup):
3488         * page/PageGroup.cpp:
3489         (WebCore::PageGroup::addUserScriptToWorld):
3490         (WebCore::PageGroup::addUserStyleSheetToWorld):
3491         * page/mac/PageMac.cpp:
3492         (WebCore::Page::addSchedulePair):
3493
3494 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3495
3496         Build fix: This time for sure!
3497         
3498         * dom/make_names.pl:
3499
3500 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3501
3502         Build fix: Let's edit the script instead of the autogenrated file. That
3503         way, our change will stand the test of time.
3504
3505         * dom/make_names.pl:
3506
3507 2011-04-25  Adam Barth  <abarth@webkit.org>
3508
3509         Reviewed by David Levin.
3510
3511         Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
3512         https://bugs.webkit.org/show_bug.cgi?id=59368
3513
3514         * html/HTMLMediaElement.cpp:
3515         (WebCore::HTMLMediaElement::HTMLMediaElement):
3516         * platform/network/HTTPHeaderMap.cpp:
3517         (WebCore::HTTPHeaderMap::copyData):
3518
3519 2011-04-25  James Robinson  <jamesr@chromium.org>
3520
3521         Reviewed by Adam Barth.
3522
3523         Fix strict OwnPtr violations in Render*.cpp
3524         https://bugs.webkit.org/show_bug.cgi?id=59361
3525
3526         * rendering/RenderBlock.cpp:
3527         (WebCore::RenderBlock::RenderBlock):
3528         (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
3529         * rendering/RenderBox.cpp:
3530         (WebCore::RenderBox::addLayoutOverflow):
3531         (WebCore::RenderBox::addVisualOverflow):
3532         * rendering/RenderButton.cpp:
3533         (WebCore::RenderButton::styleDidChange):
3534         * rendering/RenderLayer.cpp:
3535         (WebCore::RenderLayer::updateTransform):
3536         (WebCore::RenderLayer::paintChildLayerIntoColumns):
3537         (WebCore::RenderLayer::hitTestChildLayerColumns):
3538         (WebCore::RenderLayer::ensureBacking):
3539         * rendering/RenderTable.cpp:
3540         (WebCore::RenderTable::styleDidChange):
3541         * rendering/RenderView.cpp:
3542         (WebCore::RenderView::compositor):
3543         * rendering/style/RenderStyle.cpp:
3544         (WebCore::RenderStyle::addCachedPseudoStyle):
3545         (WebCore::RenderStyle::accessCounterDirectives):
3546         (WebCore::RenderStyle::accessAnimations):
3547         (WebCore::RenderStyle::accessTransitions):
3548         * rendering/svg/RenderSVGResourceFilter.cpp:
3549         (WebCore::RenderSVGResourceFilter::applyResource):
3550         * rendering/svg/SVGResources.cpp:
3551         (WebCore::SVGResources::SVGResources):
3552
3553 2011-04-25  Adam Barth  <abarth@webkit.org>
3554
3555         Attempt to fix the compile.
3556
3557         * platform/graphics/MediaPlayer.cpp:
3558         (WebCore::MediaPlayer::loadWithNextMediaEngine):
3559
3560 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3561
3562         Rubber-stamped by Beth Dakin.
3563
3564         Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into 
3565         CREATE_DOM_WRAPPER because there's no meaningful difference between
3566         them anymore.
3567
3568         * bindings/js/JSCDATASectionCustom.cpp:
3569         (WebCore::toJSNewlyCreated):
3570         * bindings/js/JSCSSRuleCustom.cpp:
3571         (WebCore::toJS):
3572         * bindings/js/JSCSSValueCustom.cpp:
3573         (WebCore::toJS):
3574         * bindings/js/JSDOMBinding.h:
3575         * bindings/js/JSDocumentCustom.cpp:
3576         (WebCore::toJS):
3577         * bindings/js/JSElementCustom.cpp:
3578         (WebCore::toJSNewlyCreated):
3579         * bindings/js/JSEventCustom.cpp:
3580         (WebCore::toJS):
3581         * bindings/js/JSHTMLCollectionCustom.cpp:
3582         (WebCore::toJS):
3583         * bindings/js/JSImageDataCustom.cpp:
3584         (WebCore::toJS):
3585         * bindings/js/JSNodeCustom.cpp:
3586         (WebCore::createWrapperInline):
3587         * bindings/js/JSSVGPathSegCustom.cpp:
3588         (WebCore::toJS):
3589         * bindings/js/JSStyleSheetCustom.cpp:
3590         (WebCore::toJS):
3591         * bindings/js/JSTextCustom.cpp:
3592         (WebCore::toJSNewlyCreated):
3593         * bindings/js/JSWebKitCSSMatrixCustom.cpp:
3594         (WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
3595         * bindings/js/JSWebSocketCustom.cpp:
3596         (WebCore::JSWebSocketConstructor::constructJSWebSocket):
3597         * bindings/js/JSXMLHttpRequestCustom.cpp:
3598         (WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
3599         * bindings/js/JSXSLTProcessorCustom.cpp:
3600         (WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
3601
3602 2011-04-25  Adam Barth  <abarth@webkit.org>
3603
3604         Reviewed by James Robinson.
3605
3606         HTMLDocumentParser should play nice with OwnPtrs
3607         https://bugs.webkit.org/show_bug.cgi?id=59363
3608
3609         * html/parser/HTMLDocumentParser.cpp:
3610         (WebCore::HTMLDocumentParser::pumpTokenizer):
3611
3612 2011-04-25  Adam Barth  <abarth@webkit.org>
3613
3614         Reviewed by James Robinson.
3615
3616         Frame.cpp should work with strict OwnPtrs
3617         https://bugs.webkit.org/show_bug.cgi?id=59360
3618
3619         * page/Frame.cpp:
3620         (WebCore::createRegExpForLabels):
3621
3622 2011-04-25  Adam Barth  <abarth@webkit.org>
3623
3624         Reviewed by David Levin.
3625
3626         Fix strict OwnPtr in Element.cpp
3627         https://bugs.webkit.org/show_bug.cgi?id=59357
3628
3629         * dom/NodeRareData.h:
3630         (WebCore::NodeRareData::ensureEventTargetData):
3631
3632 2011-04-25  Adam Barth  <abarth@webkit.org>
3633
3634         Reviewed by David Levin.
3635
3636         Fix strict OwnPtr issues in Media*.cpp
3637         https://bugs.webkit.org/show_bug.cgi?id=59354
3638
3639         There's still a tricky case in MediaPlayer.cpp, but we'll worry about
3640         that later.
3641
3642         * css/MediaQueryMatcher.cpp:
3643         (WebCore::MediaQueryMatcher::addListener):
3644         * dom/Document.cpp:
3645         * platform/graphics/MediaPlayer.cpp:
3646         (WebCore::createNullMediaPlayer):
3647
3648 2011-04-25  James Robinson  <jamesr@chromium.org>
3649
3650         Reviewed by David Levin.
3651
3652         Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
3653         https://bugs.webkit.org/show_bug.cgi?id=59353
3654
3655         * rendering/RenderLayerCompositor.cpp:
3656         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
3657
3658 2011-04-25  Adam Barth  <abarth@webkit.org>
3659
3660         Reviewed by James Robinson.
3661
3662         Worker*.cpp should work with strict OwnPtrs
3663         https://bugs.webkit.org/show_bug.cgi?id=59346
3664
3665         * inspector/WorkerInspectorController.cpp:
3666         (WebCore::WorkerInspectorController::WorkerInspectorController):
3667         * workers/WorkerContext.cpp:
3668         (WebCore::WorkerContext::WorkerContext):
3669         * workers/WorkerRunLoop.cpp:
3670         (WebCore::WorkerRunLoop::WorkerRunLoop):
3671         * workers/WorkerScriptLoader.cpp:
3672         (WebCore::WorkerScriptLoader::createResourceRequest):
3673
3674 2011-04-25  James Robinson  <jamesr@chromium.org>
3675
3676         Reviewed by Adam Barth.
3677
3678         Remove bad use of OwnPtr::set() in IconDatabase.cpp
3679         https://bugs.webkit.org/show_bug.cgi?id=59344
3680
3681         Needed for strict OwnPtr compliance.
3682
3683         * loader/icon/IconDatabase.cpp:
3684         (WebCore::readySQLiteStatement):
3685
3686 2011-04-25  Adam Barth  <abarth@webkit.org>
3687
3688         Reviewed by Maciej Stachowiak.
3689
3690         ImageBuffer.h should work with strict OwnPtrs
3691         https://bugs.webkit.org/show_bug.cgi?id=59341
3692
3693         This patch is to prepare for the strict OwnPtr hack-a-thon.
3694
3695         * platform/graphics/ImageBuffer.h:
3696         (WebCore::ImageBuffer::create):
3697
3698 2011-04-25  Steve Falkenburg  <sfalken@apple.com>
3699
3700         Reviewed by Brian Weinstein.
3701
3702         WebCore build on Windows should include windows.h in its precompiled header to speed builds
3703         https://bugs.webkit.org/show_bug.cgi?id=59339
3704
3705         windows.h is included by several of the underlying wtf headers, including Atomics.h and
3706         ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
3707         
3708         On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
3709         (a 12% speedup).
3710
3711         * WebCorePrefix.h: Include windows.h
3712
3713 2011-04-25  Martin Robinson  <mrobinson@igalia.com>
3714
3715         Reviewed by Xan Lopez.
3716
3717         [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
3718         https://bugs.webkit.org/show_bug.cgi?id=59311
3719
3720         * platform/gtk/MainFrameScrollbarGtk.cpp:
3721         (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar
3722         disconnect any lingering signal handlers. This prevents an adjustment from controlling the
3723         active ScrollView and some zombie ScrollView.
3724
3725 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3726
3727         Another shot at fixing the EFL build.
3728
3729         * UseJSC.cmake:
3730         * bindings/js/JSDOMBinding.cpp:
3731
3732 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3733
3734         Try to fix EFL build.
3735
3736         * UseJSC.cmake: Added a missing file.
3737
3738 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3739
3740         Reviewed by Oliver Hunt.
3741
3742         Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
3743         https://bugs.webkit.org/show_bug.cgi?id=59333
3744
3745         * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
3746
3747         * bindings/js/JSDOMBinding.cpp:
3748         * bindings/js/JSDOMBinding.h:
3749         * bindings/js/JSDocumentCustom.cpp:
3750         * bindings/js/JSWorkerContextCustom.cpp:
3751         (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
3752
3753         * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
3754         lifetime management.
3755
3756         * dom/Document.idl: No need for a custom mark function anymore, since
3757         ActiveDOMObjets now manage their own lifetimes.
3758
3759         * dom/MessagePort.cpp:
3760         (WebCore::MessagePort::hasPendingActivity): Correctly report that we
3761         have pending activity when we're remotely entangled, instead of relying
3762         on our clients to know this about us and do the check for us.
3763
3764         * dom/MessagePort.h: FIXME!
3765
3766         * dom/MessagePort.idl:
3767         * fileapi/DOMFileSystem.idl:
3768         * fileapi/FileReader.idl:
3769         * fileapi/FileWriter.idl:
3770         * notifications/Notification.idl:
3771         * notifications/NotificationCenter.idl:
3772         * page/EventSource.idl:
3773         * storage/IDBDatabase.idl:
3774         * storage/IDBRequest.idl:
3775         * storage/IDBTransaction.idl:
3776         * webaudio/AudioContext.idl:
3777         * websockets/WebSocket.idl:
3778         * workers/AbstractWorker.idl:
3779         * workers/SharedWorker.idl:
3780         * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
3781
3782         * workers/WorkerContext.cpp:
3783         (WebCore::WorkerContext::hasPendingActivity): No need to make up for
3784         MessagePort::hasPendingActivity being wrong anymore, since it's now right.
3785
3786         * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
3787
3788 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3789
3790         Reviewed by Pavel Feldman.
3791
3792         Web Inspector: worker messages should be routed to corresponding worker front-end
3793         https://bugs.webkit.org/show_bug.cgi?id=59323
3794
3795         Added WorkerManager which is responsible for routing messages between
3796         Page inspector front-end and Worker inspector front-ends.
3797
3798         * WebCore.gypi:
3799         * inspector/front-end/WebKit.qrc:
3800         * inspector/front-end/WorkerManager.js: Added.
3801         (WebInspector.WorkerManager):
3802         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend):
3803         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded):
3804         (WebInspector.WorkerManager.loaded):
3805         (WebInspector.WorkerFrontendStub):
3806         (WebInspector.WorkerFrontendStub.prototype._receiveMessage):
3807         (WebInspector.WorkerDispatcher):
3808         (WebInspector.WorkerDispatcher.prototype._receiveMessage):
3809         (WebInspector.WorkerDispatcher.prototype.workerCreated):
3810         (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
3811         * inspector/front-end/inspector.html:
3812         * inspector/front-end/inspector.js:
3813         (WebInspector.loaded):
3814
3815 2011-04-25  Annie Sullivan  <sullivan@chromium.org>
3816
3817         Reviewed by Pavel Feldman.
3818
3819         Web Inspector: [Resources panel] Should be easy to copy data.
3820         https://bugs.webkit.org/show_bug.cgi?id=45662
3821
3822         Adds context menu items to copy resource location, resource request headers, and resource response headers.
3823
3824         * inspector/front-end/NetworkPanel.js:
3825         (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
3826         (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
3827         (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
3828         (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
3829         * inspector/front-end/Resource.js:
3830         (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
3831         (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
3832
3833 2011-04-25  Alexander Pavlov  <apavlov@chromium.org>
3834
3835         Reviewed by Yury Semikhatsky.
3836
3837         Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
3838         https://bugs.webkit.org/show_bug.cgi?id=59322
3839
3840         Use TextResourceDecoder to determine external stylesheet charsets correctly.
3841
3842         Test: inspector/styles/parse-utf8-bom.html
3843
3844         * inspector/InspectorStyleSheet.cpp:
3845         (WebCore::InspectorStyleSheet::originalStyleSheetText):
3846
3847 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3848
3849         Not reviewed: Inspector.json cleanup.
3850
3851         * inspector/Inspector.json:
3852
3853 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3854
3855         Reviewed by Pavel Feldman.
3856
3857         Web Inspector: introduce InspectorWorkerAgent
3858         https://bugs.webkit.org/show_bug.cgi?id=59320
3859
3860         InspectorWorkerAgent is responsible for routing inspector messages
3861         between worker context inspector agents and corresponding worker
3862         inspector front-end.
3863
3864         * CMakeLists.txt:
3865         * GNUmakefile.list.am:
3866         * WebCore.gypi:
3867         * WebCore.pro:
3868         * WebCore.vcproj/WebCore.vcproj:
3869         * WebCore.xcodeproj/project.pbxproj:
3870         * inspector/CodeGeneratorInspector.pm:
3871         * inspector/Inspector.json:
3872         * inspector/InspectorAgent.cpp:
3873         (WebCore::InspectorAgent::InspectorAgent):
3874         (WebCore::InspectorAgent::setFrontend):
3875         (WebCore::InspectorAgent::disconnectFrontend):
3876         * inspector/InspectorAgent.h:
3877         (WebCore::InspectorAgent::workerAgent):
3878         * inspector/InspectorController.cpp:
3879         (WebCore::InspectorController::connectFrontend):
3880         (WebCore::InspectorController::disconnectFrontend):
3881         * inspector/InspectorInstrumentation.cpp:
3882         (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
3883         * inspector/InspectorInstrumentation.h:
3884         (WebCore::InspectorInstrumentation::willStartWorkerContext):
3885         (WebCore::InspectorInstrumentation::didStartWorkerContext):
3886         * inspector/InspectorWorkerAgent.cpp: Added.
3887         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
3888         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
3889         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
3890         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
3891         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
3892         (WebCore::InspectorWorkerAgent::create):
3893         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
3894         (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
3895         (WebCore::InspectorWorkerAgent::setFrontend):
3896         (WebCore::InspectorWorkerAgent::clearFrontend):
3897         (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
3898         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
3899         * inspector/InspectorWorkerAgent.h: Added.
3900         * inspector/InstrumentingAgents.h:
3901         (WebCore::InstrumentingAgents::InstrumentingAgents):
3902         (WebCore::InstrumentingAgents::inspectorWorkerAgent):
3903         (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
3904         * inspector/WorkerInspectorController.cpp:
3905         (WebCore::WorkerInspectorController::connectFrontend):
3906         * inspector/generate-inspector-idl:
3907         * workers/Worker.cpp:
3908         (WebCore::Worker::notifyFinished):
3909         * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
3910         messages sent from the inspected page worker agent to the worker context inspector agents.
3911         (WebCore::WorkerContextInspectorProxy::connectFrontend):
3912         (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
3913         (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
3914         (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
3915         * workers/WorkerContextProxy.h:
3916         (WebCore::WorkerContextProxy::inspectorProxy):
3917
3918 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3919
3920         Reviewed by Yury Semikhatsky.
3921
3922         Web Inspector: move Frame and Resource Tree management into the Page agent.
3923         https://bugs.webkit.org/show_bug.cgi?id=59321
3924
3925         Network agent should only handle network-related activities.
3926         Frame structure should be managed by the Page agent instead.
3927
3928         * inspector/Inspector.json:
3929         * inspector/InspectorAgent.cpp:
3930         (WebCore::InspectorAgent::InspectorAgent):
3931         * inspector/InspectorDOMAgent.cpp:
3932         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
3933         (WebCore::InspectorDOMAgent::setFrontend):
3934         (WebCore::InspectorDOMAgent::restore):
3935         (WebCore::InspectorDOMAgent::highlightFrame):
3936         * inspector/InspectorDOMAgent.h:
3937         (WebCore::InspectorDOMAgent::create):
3938         * inspector/InspectorInstrumentation.cpp:
3939         (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
3940         (WebCore::InspectorInstrumentation::loadEventFiredImpl):
3941         (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
3942         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
3943         * inspector/InspectorPageAgent.cpp:
3944         (WebCore::InspectorPageAgent::create):
3945         (WebCore::InspectorPageAgent::resourceContent):
3946         (WebCore::InspectorPageAgent::resourceContentBase64):
3947         (WebCore::InspectorPageAgent::resourceData):
3948         (WebCore::InspectorPageAgent::cachedResource):
3949         (WebCore::InspectorPageAgent::resourceTypeString):
3950         (WebCore::InspectorPageAgent::cachedResourceType):
3951         (WebCore::InspectorPageAgent::cachedResourceTypeString):
3952         (WebCore::InspectorPageAgent::InspectorPageAgent):
3953         (WebCore::InspectorPageAgent::setFrontend):
3954         (WebCore::InspectorPageAgent::reload):
3955         (WebCore::InspectorPageAgent::open):
3956         (WebCore::InspectorPageAgent::getCookies):
3957         (WebCore::InspectorPageAgent::deleteCookie):
3958         (WebCore::InspectorPageAgent::getResourceTree):
3959         (WebCore::InspectorPageAgent::getResourceContent):
3960         (WebCore::InspectorPageAgent::restore):
3961         (WebCore::InspectorPageAgent::domContentEventFired):
3962         (WebCore::InspectorPageAgent::loadEventFired):
3963         (WebCore::InspectorPageAgent::frameNavigated):
3964         (WebCore::InspectorPageAgent::frameDetached):
3965         (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
3966         (WebCore::InspectorPageAgent::mainFrame):
3967         (WebCore::pointerAsId):
3968         (WebCore::InspectorPageAgent::frameForId):
3969         (WebCore::InspectorPageAgent::frameId):
3970         (WebCore::InspectorPageAgent::loaderId):
3971         (WebCore::InspectorPageAgent::buildObjectForFrame):
3972         (WebCore::InspectorPageAgent::buildObjectForFrameTree):
3973         * inspector/InspectorPageAgent.h:
3974         * inspector/InspectorResourceAgent.cpp:
3975         (WebCore::buildObjectForCachedResource):
3976         (WebCore::InspectorResourceAgent::willSendRequest):
3977         (WebCore::InspectorResourceAgent::didReceiveResponse):
3978         (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
3979         (WebCore::InspectorResourceAgent::setInitialScriptContent):
3980         (WebCore::InspectorResourceAgent::setInitialXHRContent):
3981         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
3982         * inspector/InspectorResourceAgent.h:
3983         (WebCore::InspectorResourceAgent::create):
3984         * inspector/InspectorStyleSheet.cpp:
3985         (WebCore::InspectorStyleSheet::resourceStyleSheetText):
3986         * inspector/front-end/NetworkManager.js:
3987         (WebInspector.NetworkManager.prototype.requestContent):
3988         * inspector/front-end/NetworkPanel.js:
3989         (WebInspector.NetworkPanel):
3990         (WebInspector.NetworkPanel.prototype.frameNavigated):
3991         * inspector/front-end/ResourceTreeModel.js:
3992         (WebInspector.ResourceTreeModel):
3993         (WebInspector.ResourceTreeModel.prototype.frontendReused):
3994         (WebInspector.ResourceTreeModel.prototype.frameNavigated):
3995         (WebInspector.ResourceTreeModel.prototype.frameDetached):
3996         * inspector/front-end/inspector.js:
3997         (WebInspector.domContentEventFired):
3998         (WebInspector.loadEventFired):
3999         (WebInspector.frameNavigated):
4000         (WebInspector.frameDetached):
4001
4002 2011-04-25  Pavel Feldman  <pfeldman@google.com>
4003
4004         Reviewed by Yury Semikhatsky.
4005
4006         Web Inspector: few protocol improvements.
4007         https://bugs.webkit.org/show_bug.cgi?id=59319
4008
4009         - Page domain is documented
4010         - setUserAgentOverride is moved to the Network agent
4011         - setSearchingForNode -> setInspectModeEnabled
4012         - highlightDOMNode -> highlightNode
4013         - reloadPage -> reload
4014         - openInNewWindow -> open with optional parameter
4015
4016         * inspector/Inspector.json:
4017         * inspector/InspectorDOMAgent.cpp:
4018         (WebCore::InspectorDOMAgent::setInspectModeEnabled):
4019         (WebCore::InspectorDOMAgent::highlightNode):
4020         * inspector/InspectorDOMAgent.h:
4021         (WebCore::InspectorDOMAgent::hideNodeHighlight):
4022         * inspector/InspectorInstrumentation.cpp:
4023         (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
4024         * inspector/InspectorPageAgent.cpp:
4025         (WebCore::InspectorPageAgent::clearFrontend):
4026         (WebCore::InspectorPageAgent::reload):
4027         (WebCore::InspectorPageAgent::open):
4028         * inspector/InspectorPageAgent.h:
4029         * inspector/InspectorResourceAgent.cpp:
4030         (WebCore::InspectorResourceAgent::clearFrontend):
4031         (WebCore::InspectorResourceAgent::applyUserAgentOverride):
4032         (WebCore::InspectorResourceAgent::setUserAgentOverride):
4033         * inspector/InspectorResourceAgent.h:
4034         * inspector/front-end/AuditsPanel.js:
4035         (WebInspector.AuditsPanel.prototype._reloadResources):
4036         * inspector/front-end/ElementsPanel.js:
4037         (WebInspector.ElementsPanel.prototype.setSearchingForNode):
4038         * inspector/front-end/ExtensionServer.js:
4039         (WebInspector.ExtensionServer.prototype._onReload):
4040         * inspector/front-end/NetworkPanel.js:
4041         (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
4042         * inspector/front-end/ResourcesPanel.js:
4043         (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
4044         * inspector/front-end/inspector.js:
4045         (WebInspector.highlightDOMNode):
4046         (WebInspector.openResource):
4047         (WebInspector.documentKeyDown):
4048
4049 2011-04-25  Jon Lee  <jonlee@apple.com>
4050
4051         Reviewed by Maciej Stachowiak.
4052
4053         Overlay scroller hard to see on pages with dark background (59183)
4054         https://bugs.webkit.org/show_bug.cgi?id=59183
4055         <rdar://problem/8975367>
4056
4057         Switch the scrollbar's overlay style depending on its frame's background color.
4058         This refactors the getDocumentBackgroundColor method needed for gestures. The style
4059         is determined and set on every paint() call to the Mac scrollbar theme.
4060
4061         * WebCore.exp.in: adding method to allow changing style
4062         * page/Frame.cpp:
4063         (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
4064         * page/Frame.h:
4065         * page/FrameView.cpp:
4066         (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
4067         * page/FrameView.h:
4068         * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
4069         * platform/ScrollableArea.h:
4070         (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
4071         * platform/mac/ScrollbarThemeMac.mm:
4072         (WebCore::ScrollbarThemeMac::paint):
4073         * platform/mac/WebCoreSystemInterface.h:
4074         * platform/mac/WebCoreSystemInterface.mm:
4075
4076 2011-04-25  Dan Bernstein  <mitz@apple.com>
4077
4078         Reviewed by Maciej Stachowiak.
4079
4080         <rdar://problem/9113516> REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
4081         https://bugs.webkit.org/show_bug.cgi?id=59315
4082
4083         * platform/Scrollbar.cpp:
4084         (WebCore::Scrollbar::Scrollbar): Initialize new member variables.
4085         (WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
4086         is scrolled a distance equal to the change in the mouse position.
4087         (WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
4088         the document rather than the thumb, and pass the result to moveThumb.
4089         (WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
4090         * platform/Scrollbar.h:
4091         * platform/ScrollbarTheme.h:
4092         (WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
4093         returns false.
4094         * platform/mac/ScrollbarThemeMac.h:
4095         * platform/mac/ScrollbarThemeMac.mm:
4096         (WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
4097         Option key is down.
4098
4099 2011-04-24  Geoffrey Garen  <ggaren@apple.com>
4100
4101         Reviewed by Sam Weinig.
4102
4103         Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
4104         https://bugs.webkit.org/show_bug.cgi?id=59307
4105
4106         * WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.