2011-04-28 Jay Civelli <jcivelli@chromium.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         Introducing a new class that allows serialization of a page back
6         to HTML/XML with all its sub-frames and also retrieves the page's
7         resources.
8         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
9         https://bugs.webkit.org/show_bug.cgi?id=58947
10
11         * Android.mk:
12         * CMakeLists.txt:
13         * GNUmakefile.list.am:
14         * WebCore.gypi:
15         * WebCore.pro:
16         * WebCore.vcproj/WebCore.vcproj:
17         * dom/Document.cpp:
18         (WebCore::Document::suggestedMIMEType):
19         * dom/Document.h:
20         * editing/MarkupAccumulator.cpp:
21         (WebCore::MarkupAccumulator::appendCustomAttributes):
22         (WebCore::MarkupAccumulator::appendElement):
23         * editing/MarkupAccumulator.h:
24         * html/parser/HTMLMetaCharsetParser.cpp:
25         (WebCore::HTMLMetaCharsetParser::processMeta):
26         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
27         * html/parser/HTMLMetaCharsetParser.h:
28         * page/PageSerializer.cpp: Added.
29         * page/PageSerializer.h: Added.
30
31 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
32
33         Reviewed by Tony Chang.
34
35         IndexedDB createIndex should fail if name arg is null
36         https://bugs.webkit.org/show_bug.cgi?id=58365
37
38         Test: storage/indexeddb/mozilla/create-index-null-name.html
39
40         * storage/IDBObjectStore.idl:
41         * storage/IDBObjectStoreBackendImpl.cpp:
42         (WebCore::IDBObjectStoreBackendImpl::createIndex):
43
44 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
45
46         Reviewed by Tony Chang.
47
48         IndexedDB put() should fail if second (key) parameter is null
49         https://bugs.webkit.org/show_bug.cgi?id=58613
50
51         If key arg is not specified, prpKey ends up as a null pointer in ::put().
52         However, if the key arg is specified but is null, prpKey ends up as a
53         valid IDBKey which has a null key type. As it happens, we need to be able
54         to detect the difference between these cases (the key arg is optional but
55         if specified must not be null).
56
57         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
58
59         * storage/IDBObjectStoreBackendImpl.cpp:
60         (WebCore::IDBObjectStoreBackendImpl::put):
61
62 2011-04-07  David Levin  <levin@chromium.org>
63
64         Reviewed by Darin Adler.
65
66         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
67         https://bugs.webkit.org/show_bug.cgi?id=31639
68
69         No new functionality exposed so no new tests. (The change is basically adding
70         more testing.)
71
72         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
73         * loader/icon/IconDatabase.cpp:
74         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
75         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
76         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
77         (WebCore::IconDatabase::readFromDatabase): Ditto.
78
79 2011-04-28  Kenneth Russell  <kbr@google.com>
80
81         Unreviewed build fix for Web Audio with strict OwnPtr.
82
83         * platform/audio/HRTFDatabaseLoader.cpp:
84         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
85
86 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
87
88         Reviewed by Geoffrey Garen.
89
90         Walk shadow hosts as well as parent nodes when finding opaque roots.
91         https://bugs.webkit.org/show_bug.cgi?id=59571
92
93         Test: fast/dom/shadow/gc-shadow.html
94
95         * bindings/js/JSDOMBinding.h:
96         (WebCore::root):
97
98 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
99
100         Reviewed by Xan Lopez.
101
102         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
103         https://bugs.webkit.org/show_bug.cgi?id=59715
104
105         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
106         into WebCore so that WebKit1 and WebKit2 can share the code.
107
108         No new tests. This is covered by fast/events/click-count.html.
109
110         * GNUmakefile.list.am: Added new files.
111         * platform/gtk/GtkClickCounter.cpp: Added.
112         (WebCore::GtkClickCounter::GtkClickCounter): Added.
113         (WebCore::GtkClickCounter::reset): Added.
114         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
115         (WebCore::getEventTime): Added.
116         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
117         * platform/gtk/GtkClickCounter.h: Added.
118
119 2011-04-28  Dan Bernstein  <mitz@apple.com>
120
121         Build fix.
122
123         * css/CSSParser.cpp:
124         (WebCore::cssPropertyID):
125
126 2011-04-28  Dan Bernstein  <mitz@apple.com>
127
128         Reviewed by Simon Fraser.
129
130         Allow specifying CSS property aliases in CSSPropertyNames.in files
131         https://bugs.webkit.org/show_bug.cgi?id=59712
132
133         * css/CSSParser.cpp:
134         (WebCore::cssPropertyID): Removed code to handle some aliases
135         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
136         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
137         defining an alias, and add an appropriate entry to the gperf file.
138
139 2011-04-28  Arno Renevier  <arno@renevier.net>
140
141         Reviewed by Gustavo Noronha Silva.
142
143         [Soup] does not load css stylesheets without content-type
144         https://bugs.webkit.org/show_bug.cgi?id=59697
145
146         When sniffing content type, do not replace http Content-Type header in
147         soup message anymore, but keep sniffed content type in a separate
148         variable.
149
150         * platform/network/soup/ResourceHandleSoup.cpp:
151         (WebCore::contentSniffedCallback):
152         * platform/network/soup/ResourceResponse.h:
153         (WebCore::ResourceResponse::sniffedContentType):
154         (WebCore::ResourceResponse::setSniffedContentType):
155         * platform/network/soup/ResourceResponseSoup.cpp:
156         (WebCore::ResourceResponse::updateFromSoupMessage):
157
158 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
159
160         Reviewed by Andreas Kling.
161
162         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
163         https://bugs.webkit.org/show_bug.cgi?id=59704
164
165         No new tests, just code cleanup.
166
167         * WebCore.pri:
168
169 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
170
171         Reviewed by Pavel Feldman.
172
173         Web Inspector: remove "Pretty print" source frame context menu item.
174         https://bugs.webkit.org/show_bug.cgi?id=59709
175
176         * inspector/front-end/DebuggerPresentationModel.js:
177         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
178         * inspector/front-end/ScriptsPanel.js:
179         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
180         * inspector/front-end/SourceFrame.js:
181         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
182
183 2011-04-28  Satish Sampath  <satish@chromium.org>
184
185         Reviewed by Tony Gentilcore.
186
187         Speech input button layout issues with padding and border.
188         https://bugs.webkit.org/show_bug.cgi?id=59613
189
190         * rendering/RenderTextControlSingleLine.cpp:
191         (WebCore::RenderTextControlSingleLine::layout):
192         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
193         (WebCore::RenderTextControlSingleLine::forwardEvent):
194
195 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
196
197         Reviewed by Martin Robinson.
198
199         [GTK] Check whether to use native scrollbars at run time
200         https://bugs.webkit.org/show_bug.cgi?id=59694
201
202         It's currently decided at build time depending on whether webkit2
203         build is enabled or not. That makes imposible to build both
204         webkit1 and webkit2 using the same libWebCore.
205
206         * GNUmakefile.am:
207         * platform/ScrollView.cpp:
208         (WebCore::ScrollView::wheelEvent):
209         * platform/gtk/ScrollViewGtk.cpp:
210         (WebCore::ScrollView::createScrollbar):
211
212 2011-04-28  Pavel Feldman  <pfeldman@google.com>
213
214         Reviewed by Yury Semikhatsky.
215
216         Web Inspector: add status bar button for pretty print.
217         https://bugs.webkit.org/show_bug.cgi?id=59467
218
219         * WebCore.gypi:
220         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
221         * inspector/front-end/ScriptsPanel.js:
222         (WebInspector.ScriptsPanel):
223         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
224         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
225         * inspector/front-end/WebKit.qrc:
226         * inspector/front-end/inspector.css:
227         (.scripts-toggle-pretty-print-status-bar-item .glyph):
228         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
229
230 2011-04-28  Pavel Feldman  <pfeldman@google.com>
231
232         Reviewed by Yury Semikhatsky.
233
234         Web Inspector: add ResourceTreeModel tests.
235         https://bugs.webkit.org/show_bug.cgi?id=59616
236
237         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
238                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
239                http/tests/inspector/resource-tree/resource-tree-reload.html
240
241         * inspector/front-end/ResourceTreeModel.js:
242         (WebInspector.ResourceTreeModel.prototype.frontendReused):
243         (WebInspector.ResourceTreeModel.prototype._addFrame):
244         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
245         (WebInspector.ResourceTreeModel.prototype._frameDetached):
246         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
247         (WebInspector.ResourceTreeModel.prototype.forAllResources):
248         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
249         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
250         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
251         * inspector/front-end/ResourcesPanel.js:
252         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
253         (WebInspector.ResourcesPanel.prototype._frameAdded):
254         (WebInspector.ResourcesPanel.prototype._frameDetached):
255         (WebInspector.ResourcesPanel.prototype._frameNavigated):
256         (WebInspector.FrameTreeElement):
257         (WebInspector.FrameTreeElement.prototype.frameNavigated):
258
259 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
260
261         Reviewed by Yury Semikhatsky.
262
263         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
264         https://bugs.webkit.org/show_bug.cgi?id=59592
265
266         * inspector/front-end/DetailedHeapshotGridNodes.js:
267         (WebInspector.HeapSnapshotGridNode.prototype._populate):
268         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
269         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
270         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
271         * inspector/front-end/DetailedHeapshotView.js:
272         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
273         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
274         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
275         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
276         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
277         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
278         (WebInspector.DetailedHeapshotView.prototype.changeView):
279         * inspector/front-end/HeapSnapshot.js:
280         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
281         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
282         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
283         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
284         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
285         * inspector/front-end/heapProfiler.css:
286         (div.retaining-paths-view td.path-column div:hover):
287
288 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
289
290         Reviewed by Yury Semikhatsky.
291
292         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
293         https://bugs.webkit.org/show_bug.cgi?id=59454
294
295         Test: inspector/profiler/heap-snapshot-loader.html
296
297         * inspector/front-end/HeapSnapshot.js:
298         (WebInspector.HeapSnapshotLoader):
299         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
300         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
301         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
302         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
303         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
304         * inspector/front-end/HeapSnapshotProxy.js:
305         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
306
307 2011-04-28  ojab  <ojab@ojab.ru>
308
309         Reviewed by David Levin.
310
311         Fix build with libpng-1.5.1
312         https://bugs.webkit.org/show_bug.cgi?id=59607
313
314         * platform/image-decoders/png/PNGImageDecoder.cpp:
315         (WebCore::readColorProfile):
316
317 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
318
319         Reviewed by Nikolas Zimmermann.
320
321         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
322         https://bugs.webkit.org/show_bug.cgi?id=59447
323
324         This patch contains two sub-routines, one for speeding up
325         alpha channel only gaussian blur (by 2.5 times) and one
326         for speeding up all channel blur (by 4 times).
327
328         The common code is also redesigned to better fit for platform
329         specific code. This means large chunks of code was moved to
330         different files, and all platform specific files are added to
331         all build systems.
332
333         * CMakeLists.txt:
334         * GNUmakefile.am:
335         * GNUmakefile.list.am:
336         * WebCore.gypi:
337         * WebCore.pro:
338         * WebCore.vcproj/WebCore.vcproj:
339         * WebCore.vcproj/WebCoreCommon.vsprops:
340         * WebCore.xcodeproj/project.pbxproj:
341         * platform/graphics/filters/FEGaussianBlur.cpp:
342         (WebCore::FEGaussianBlur::platformApplyGeneric):
343         (WebCore::FEGaussianBlur::apply):
344         * platform/graphics/filters/FEGaussianBlur.h:
345         (WebCore::FEGaussianBlur::kernelPosition):
346         (WebCore::FEGaussianBlur::platformApply):
347         * platform/graphics/filters/FELighting.cpp:
348         (WebCore::FELighting::platformApplyGeneric):
349         (WebCore::FELighting::drawLighting):
350         * platform/graphics/filters/FELighting.h:
351         (WebCore::FELighting::platformApply):
352         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
353         (WebCore::WTF_ALIGNED):
354         (WebCore::feGaussianBlurConstantsForNeon):
355         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
356         (WebCore::FEGaussianBlur::platformApplyNeon):
357         * platform/graphics/filters/arm/FELightingNEON.cpp:
358         (WebCore::WTF_ALIGNED):
359         (WebCore::FELighting::getPowerCoefficients):
360         * platform/graphics/filters/arm/FELightingNEON.h:
361         (WebCore::FELighting::platformApplyNeon):
362
363 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
364
365         Reviewed by Yury Semikhatsky.
366
367         Web Inspector: provide a hotkey for script pause
368         https://bugs.webkit.org/show_bug.cgi?id=59593
369
370         In fact, F8 works as a hotkey, but this fact was not reflected
371         in the shortcut help popup.
372
373         * English.lproj/localizedStrings.js:
374         * inspector/front-end/ScriptsPanel.js:
375         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
376
377 2011-04-28  Adam Barth  <abarth@webkit.org>
378
379         Reviewed by Eric Seidel.
380
381         PluginStream should play nice with strict OwnPtr
382         https://bugs.webkit.org/show_bug.cgi?id=59675
383
384         These failures appear when enabling strict OwnPtr on Qt.
385
386         * plugins/PluginStream.cpp:
387         (WebCore::PluginStream::PluginStream):
388         (WebCore::PluginStream::didReceiveData):
389
390 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
391
392         Reviewed by Pavel Feldman.
393
394         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
395         https://bugs.webkit.org/show_bug.cgi?id=59326
396
397         Concrete CachedResource successors for stylesheets and scripts
398         can decode their content better than the generic approach we use.
399
400         * inspector/InspectorPageAgent.cpp:
401         (WebCore::decodeSharedBuffer):
402         (WebCore::prepareCachedResourceBuffer):
403         (WebCore::cachedResourceDecoded):
404         (WebCore::InspectorPageAgent::resourceContent):
405         (WebCore::InspectorPageAgent::resourceData):
406         * inspector/InspectorStyleSheet.cpp:
407         (WebCore::InspectorStyleSheet::originalStyleSheetText):
408
409 2011-04-28  Jon Lee  <jonlee@apple.com>
410
411         Reviewed by Simon Fraser.
412
413         REGRESSION: white overlay scrollbars on apple.com/startpage
414         https://bugs.webkit.org/show_bug.cgi?id=59540
415         <rdar://problem/9338653>
416
417         Now we look at the document background in addition to the <body> element,
418         and blend those colors in with the base background of the frame view to
419         arrive at our aggregate color. This provides a better result to determine
420         overlay scrollbar style.
421
422         * page/Frame.cpp:
423         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
424         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
425
426 2011-04-27  Adam Barth  <abarth@webkit.org>
427
428         Reviewed by Maciej Stachowiak.
429
430         Fix OwnPtr issues in IndexedDB
431         https://bugs.webkit.org/show_bug.cgi?id=59656
432
433         This patch is an attempt to fix the clang build.  Clang can't seem to
434         cope with OwnPtrs to classes declared in an anonymous namespace because
435         OwnPtr's copy constructor isn't defined (but would need to be defined
436         in this translation unit).
437
438         * platform/leveldb/LevelDBDatabase.cpp:
439
440 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
441
442         Reviewed by Antonio Gomes.
443
444         [EFL] Change cursor to LAZY_NATIVE_CURSOR
445         https://bugs.webkit.org/show_bug.cgi?id=59411
446
447         Enable LAZY_NATIVE_CURSOR on EFL build.
448
449         No test added because functionality is unchanged.
450
451         * CMakeListsEfl.txt: Add Cursor.cpp
452         * platform/Cursor.h:
453         (WebCore::Cursor::Cursor):
454         * platform/efl/CursorEfl.cpp:
455         (WebCore::Cursor::Cursor):
456         (WebCore::Cursor::~Cursor):
457         (WebCore::getCursorString):
458         (WebCore::Cursor::ensurePlatformCursor):
459         * platform/efl/WidgetEfl.cpp:
460         (WebCore::Widget::setCursor):
461
462 2011-04-27  Adam Barth  <abarth@webkit.org>
463
464         Build fix from the future.  Another trival strict OwnPtr fixes.  This
465         is the last futuristic build fix I can detect with my time traveling
466         abilities.
467
468         * platform/graphics/chromium/TransparencyWin.cpp:
469         (WebCore::TransparencyWin::initializeNewContext):
470
471 2011-04-27  Dmitry Lomov  <dslomov@google.com>
472
473         Reviewed by David Levin.
474
475         CrossThreadCopier should not have a default specialization for raw pointers
476         https://bugs.webkit.org/show_bug.cgi?id=59234
477         Removed the ablity to pass raw pointers cross-thread
478         Added and applied annotations for doing that
479
480         * fileapi/FileReader.cpp:
481         (WebCore::FileReader::readInternal):
482         (WebCore::FileReader::abort):
483         * fileapi/FileStreamProxy.cpp:
484         (WebCore::FileStreamProxy::startOnFileThread):
485         (WebCore::FileStreamProxy::stopOnFileThread):
486         (WebCore::FileStreamProxy::getSize):
487         (WebCore::FileStreamProxy::getSizeOnFileThread):
488         (WebCore::FileStreamProxy::openForRead):
489         (WebCore::FileStreamProxy::openForReadOnFileThread):
490         (WebCore::FileStreamProxy::openForWrite):
491         (WebCore::FileStreamProxy::openForWriteOnFileThread):
492         (WebCore::FileStreamProxy::close):
493         (WebCore::FileStreamProxy::read):
494         (WebCore::FileStreamProxy::readOnFileThread):
495         (WebCore::FileStreamProxy::write):
496         (WebCore::FileStreamProxy::writeOnFileThread):
497         (WebCore::FileStreamProxy::truncate):
498         (WebCore::FileStreamProxy::truncateOnFileThread):
499         * loader/WorkerThreadableLoader.cpp:
500         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
501         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
502         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
503         * page/GeolocationPositionCache.cpp:
504         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
505         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
506         * platform/CrossThreadCopier.h:
507         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
508         (WebCore::AllowCrossThreadAccessWrapper::value):
509         (WebCore::AllowCrossThreadAccess):
510         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
511         (WebCore::AllowExtendedLifetimeWrapper::value):
512         (WebCore::AllowExtendedLifetime):
513         * platform/graphics/chromium/cc/CCCompletionEvent.h:
514         * storage/IDBObjectStoreBackendImpl.cpp:
515         (WebCore::IDBObjectStoreBackendImpl::get):
516         (WebCore::IDBObjectStoreBackendImpl::put):
517         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
518         (WebCore::IDBObjectStoreBackendImpl::clear):
519         (WebCore::IDBObjectStoreBackendImpl::createIndex):
520         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
521         (WebCore::IDBObjectStoreBackendImpl::openCursor):
522         * storage/SQLCallbackWrapper.h:
523         (WebCore::SQLCallbackWrapper::clear):
524         * websockets/WorkerThreadableWebSocketChannel.cpp:
525         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
526         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
527         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
528         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
529         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
530         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
531         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
532         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
533         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
534         * workers/WorkerMessagingProxy.cpp:
535         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
536
537 2011-04-27  Adam Barth  <abarth@webkit.org>
538
539         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
540
541         * page/Frame.cpp:
542         (WebCore::Frame::setTiledBackingStoreEnabled):
543         * platform/audio/ReverbConvolver.cpp:
544         (WebCore::ReverbConvolver::ReverbConvolver):
545
546 2011-04-27  Adam Barth  <abarth@webkit.org>
547
548         Reviewed by David Levin.
549
550         Fix five strict PassOwnPtr violations in WebCore
551         https://bugs.webkit.org/show_bug.cgi?id=59640
552
553         * css/MediaList.cpp:
554         (WebCore::MediaList::deleteMedium):
555         (WebCore::MediaList::setMediaText):
556         (WebCore::MediaList::appendMedium):
557         * css/MediaQuery.h:
558         * dom/MessagePort.cpp:
559         (WebCore::MessagePort::disentanglePorts):
560         (WebCore::MessagePort::entanglePorts):
561         * inspector/InspectorStyleSheet.cpp:
562         (ParsedStyleSheet::setText):
563         * rendering/RenderTheme.cpp:
564         (WebCore::RenderTheme::adjustStyle):
565         (WebCore::RenderTheme::adjustMeterStyle):
566         * rendering/RenderThemeMac.mm:
567         (WebCore::RenderThemeMac::adjustMenuListStyle):
568         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
569         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
570         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
571         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
572         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
573         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
574         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
575
576 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
577
578         Reviewed by Beth Dakin.
579
580         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
581         https://bugs.webkit.org/show_bug.cgi?id=59648
582
583         Test: accessibility/aria-fallback-roles.html
584
585         * accessibility/AccessibilityObject.cpp:
586         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
587
588 2011-04-27  Beth Dakin  <bdakin@apple.com>
589
590         Reviewed by Dan Bernstein.
591
592         https://bugs.webkit.org/show_bug.cgi?id=59671
593         Race condition with scrollbar animations and closing a page can cause a crash in 
594         WebCore::FrameView::setVisibleScrollerThumbRect + 15
595         -and corresponding-
596         <rdar://problem/9329253>
597
598         It is definitely possible for Page to be null here. So we should null-check it! 
599         And we should not ASSERT.
600         * page/FrameView.cpp:
601         (WebCore::FrameView::didCompleteRubberBand):
602         (WebCore::FrameView::scrollbarStyleChanged):
603         (WebCore::FrameView::setVisibleScrollerThumbRect):
604
605 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
606
607         WinCE build fix after r85143.
608
609         * platform/graphics/wince/FontWinCE.cpp:
610         (WebCore::TextRunComponent::TextRunComponent):
611
612 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
613
614         Reviewed by Tony Chang.
615
616         IndexedDB object store delete should fail if key is null
617         https://bugs.webkit.org/show_bug.cgi?id=58614
618
619         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
620
621         * storage/IDBObjectStoreBackendImpl.cpp:
622         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
623
624 2011-04-27  Eric Seidel  <eric@webkit.org>
625
626         Reviewed by Ryosuke Niwa.
627
628         Should have an easy way to construct starting BidiStatus for a paragraph root
629         https://bugs.webkit.org/show_bug.cgi?id=59226
630
631         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
632         I've made this a constructor for BidiStatus instead.
633
634         As part of this effort I added a direction() accessor for TextRun and got
635         rid of the old m_rtl bool.  This is part of the generic effort in the
636         Bidi code to replace old bool usage with the superior TextDirection enum
637         (this generally makes the code cleaner).
638
639         As part of this replacement effort I found several places which were
640         assuming LTR (by passing rtl=false) when they probably want to use
641         the current text direction.  I suspect that LTR vs. RTL may affect
642         string width in the case of ligatures.  It's unclear.
643
644         This is almost entirely a mechanical change.
645
646         * html/canvas/CanvasRenderingContext2D.cpp:
647         (WebCore::CanvasRenderingContext2D::drawTextInternal):
648         * platform/graphics/GraphicsContext.cpp:
649         (WebCore::GraphicsContext::drawBidiText):
650         * platform/graphics/TextRun.h:
651         (WebCore::TextRun::TextRun):
652         (WebCore::TextRun::direction):
653         (WebCore::TextRun::rtl):
654         (WebCore::TextRun::ltr):
655         (WebCore::TextRun::setDirection):
656         * platform/text/BidiResolver.h:
657         (WebCore::BidiStatus::BidiStatus):
658         * rendering/EllipsisBox.cpp:
659         (WebCore::EllipsisBox::paint):
660         (WebCore::EllipsisBox::selectionRect):
661         (WebCore::EllipsisBox::paintSelection):
662         * rendering/InlineTextBox.cpp:
663         (WebCore::InlineTextBox::selectionRect):
664         (WebCore::InlineTextBox::paint):
665         (WebCore::InlineTextBox::paintSelection):
666         (WebCore::InlineTextBox::paintCompositionBackground):
667         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
668         (WebCore::InlineTextBox::paintTextMatchMarker):
669         (WebCore::InlineTextBox::computeRectForReplacementMarker):
670         (WebCore::InlineTextBox::offsetForPosition):
671         (WebCore::InlineTextBox::positionForOffset):
672         * rendering/RenderBlockLineLayout.cpp:
673         (WebCore::RenderBlock::determineStartPosition):
674         * rendering/RenderFileUploadControl.cpp:
675         (WebCore::RenderFileUploadControl::paintObject):
676         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
677         * rendering/RenderListBox.cpp:
678         (WebCore::RenderListBox::updateFromElement):
679         (WebCore::RenderListBox::paintItemForeground):
680         * rendering/RenderTextControl.cpp:
681         (WebCore::RenderTextControl::getAvgCharWidth):
682         (WebCore::RenderTextControl::paintPlaceholder):
683         * rendering/svg/SVGInlineTextBox.cpp:
684         (WebCore::SVGInlineTextBox::constructTextRun):
685         * rendering/svg/SVGTextMetrics.cpp:
686         (WebCore::constructTextRun):
687
688 2011-04-27  Robert Hogan  <robert@webkit.org>
689
690         Reviewed by Adam Barth.
691
692         Allow shadowing of history object
693         https://bugs.webkit.org/show_bug.cgi?id=55965
694
695         Tests: http/tests/history/cross-origin-replace-history-object-child.html
696                http/tests/history/cross-origin-replace-history-object.html
697
698         * page/DOMWindow.idl:
699
700 2011-04-27  James Robinson  <jamesr@chromium.org>
701
702         Reviewed by Kenneth Russell.
703
704         [chromium] Ensure compositing layers are up to date before entering doComposite
705         https://bugs.webkit.org/show_bug.cgi?id=59159
706
707         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
708         GraphicsLayerClient::paintContents() implementations).
709
710         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
711         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
712         * platform/graphics/chromium/LayerChromium.cpp:
713         (WebCore::LayerChromium::LayerChromium):
714         (WebCore::LayerChromium::~LayerChromium):
715         * platform/graphics/chromium/LayerRendererChromium.cpp:
716         (WebCore::LayerRendererChromium::updateLayers):
717         * platform/graphics/chromium/LayerRendererChromium.h:
718           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
719
720 2011-04-27  James Robinson  <jamesr@chromium.org>
721
722         Reviewed by Adam Barth.
723
724         Fix OwnPtr strict issues in chromium linux build
725         https://bugs.webkit.org/show_bug.cgi?id=59664
726
727         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
728         (WebCore::ComplexTextController::getNormalizedTextRun):
729         * platform/graphics/skia/ImageBufferSkia.cpp:
730         (WebCore::ImageBuffer::ImageBuffer):
731         * platform/graphics/skia/PlatformContextSkia.cpp:
732         (WebCore::PlatformContextSkia::PlatformContextSkia):
733
734 2011-04-27  Chris Rogers  <crogers@google.com>
735
736         Reviewed by Kenneth Russell.
737
738         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
739         https://bugs.webkit.org/show_bug.cgi?id=59641
740
741         No new tests since audio API is not yet implemented.
742
743         * platform/audio/AudioBus.cpp:
744         (WebCore::AudioBus::createBySampleRateConverting):
745         (WebCore::AudioBus::createByMixingToMono):
746
747 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
748
749         Motivated by Alexey Proskuryakov.
750
751         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
752         informative, since it confused Alexey and me.
753
754 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
755
756         Reviewed by Sam Weinig.
757
758         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
759         https://bugs.webkit.org/show_bug.cgi?id=59646
760
761         Made the cssValueRoots map per-world, instead of a global. When we deallocate
762         a world, we need to clear all entries in the map for that world, since
763         the finalizers that would otherwise clear those entries don't run. The
764         simplest way to do this is just to make the world own the map.
765         
766         * bindings/js/DOMWrapperWorld.h:
767         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
768         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
769         * bindings/js/JSCSSValueCustom.cpp:
770         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
771         (WebCore::JSCSSValueOwner::finalize):
772         * bindings/js/JSDOMBinding.h:
773
774 2011-04-27  Adam Barth  <abarth@webkit.org>
775
776         Reviewed by David Levin.
777
778         Fix OwnPtr issues in IndexedDB
779         https://bugs.webkit.org/show_bug.cgi?id=59656
780
781         I didn't do an exhaustive review of this code, but I fixed the problems
782         caught by turning on strict OwnPtr and all their antecedents.  This
783         patch is entirely tighter bookkeeping.  There shouldn't be any actual
784         behavior change.
785
786         * platform/leveldb/LevelDBDatabase.cpp:
787         (WebCore::LevelDBDatabase::LevelDBDatabase):
788         (WebCore::LevelDBDatabase::open):
789         (WebCore::LevelDBDatabase::createIterator):
790         * platform/leveldb/LevelDBDatabase.h:
791         * platform/leveldb/LevelDBIterator.cpp:
792         (WebCore::LevelDBIterator::LevelDBIterator):
793         * platform/leveldb/LevelDBIterator.h:
794         * storage/IDBLevelDBBackingStore.cpp:
795         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
796         (WebCore::IDBLevelDBBackingStore::open):
797         (WebCore::getNewDatabaseId):
798         (WebCore::IDBLevelDBBackingStore::getObjectStores):
799         (WebCore::getNewObjectStoreId):
800         (WebCore::deleteRange):
801         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
802         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
803         (WebCore::IDBLevelDBBackingStore::getIndexes):
804         (WebCore::getNewIndexId):
805         (WebCore::findGreatestKeyLessThan):
806         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
807         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
808         (WebCore::findLastIndexKeyEqualTo):
809         * storage/IDBLevelDBBackingStore.h:
810
811 2011-04-19  MORITA Hajime  <morrita@google.com>
812
813         Reviewed by Tony Chang.
814
815         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
816         https://bugs.webkit.org/show_bug.cgi?id=58113
817
818         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
819         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
820         * Now MarkerMapVectorPair is no longer used.
821         
822         No new tests, No behavior change.
823
824         * GNUmakefile.list.am:
825         * WebCore.gypi:
826         * WebCore.pro:
827         * WebCore.vcproj/WebCore.vcproj:
828         * WebCore.xcodeproj/project.pbxproj:
829         * dom/DocumentMarker.h:
830         * dom/DocumentMarkerController.cpp:
831         (WebCore::DocumentMarkerController::addMarker):
832         (WebCore::DocumentMarkerController::copyMarkers):
833         (WebCore::DocumentMarkerController::removeMarkers):
834         (WebCore::DocumentMarkerController::markerContainingPoint):
835         (WebCore::DocumentMarkerController::markersForNode):
836         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
837         (WebCore::DocumentMarkerController::removeMarkersFromList):
838         (WebCore::DocumentMarkerController::repaintMarkers):
839         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
840         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
841         (WebCore::DocumentMarkerController::shiftMarkers):
842         (WebCore::DocumentMarkerController::setMarkersActive):
843         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
844         (WebCore::DocumentMarkerController::showMarkers):
845         * dom/DocumentMarkerController.h:
846         * dom/RenderedDocumentMarker.h: Added.
847         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
848         (WebCore::RenderedDocumentMarker::isRendered):
849         (WebCore::RenderedDocumentMarker::contains):
850         (WebCore::RenderedDocumentMarker::setRenderedRect):
851         (WebCore::RenderedDocumentMarker::renderedRect):
852         (WebCore::RenderedDocumentMarker::invalidate):
853         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
854
855 2011-04-27  James Robinson  <jamesr@chromium.org>
856
857         Unreviewed, rolling out r85112.
858         http://trac.webkit.org/changeset/85112
859         https://bugs.webkit.org/show_bug.cgi?id=59159
860
861         Broke mac compile
862
863         * page/FrameView.cpp:
864         (WebCore::FrameView::updateCompositingLayers):
865         * page/FrameView.h:
866         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
867         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
868         * platform/graphics/chromium/LayerChromium.cpp:
869         (WebCore::LayerChromium::LayerChromium):
870         (WebCore::LayerChromium::~LayerChromium):
871         * platform/graphics/chromium/LayerRendererChromium.cpp:
872         (WebCore::LayerRendererChromium::updateLayers):
873         * platform/graphics/chromium/LayerRendererChromium.h:
874
875 2011-04-27  Mark Rowe  <mrowe@apple.com>
876
877         Build fix.
878
879         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
880
881 2011-04-27  Pratik Solanki  <psolanki@apple.com>
882
883         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
884
885         * platform/network/ResourceHandleClient.h:
886
887 2011-04-27  James Robinson  <jamesr@chromium.org>
888
889         Reviewed by Kenneth Russell.
890
891         [chromium] Ensure compositing layers are up to date before entering doComposite
892         https://bugs.webkit.org/show_bug.cgi?id=59159
893
894         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
895         GraphicsLayerClient::paintContents() implementations).
896
897         * page/FrameView.cpp:
898         (WebCore::FrameView::updateCompositingLayers):
899             Add an optional CompositingUpdateType parameter.
900         * page/FrameView.h:
901         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
902         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
903         * platform/graphics/chromium/LayerChromium.cpp:
904         (WebCore::LayerChromium::LayerChromium):
905         (WebCore::LayerChromium::~LayerChromium):
906         * platform/graphics/chromium/LayerRendererChromium.cpp:
907         (WebCore::LayerRendererChromium::updateLayers):
908         * platform/graphics/chromium/LayerRendererChromium.h:
909           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
910         * rendering/RenderLayer.cpp:
911         (WebCore::RenderLayer::dirtyZOrderLists):
912         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
913         * rendering/RenderLayerCompositor.cpp:
914         (WebCore::RenderLayerCompositor::updateCompositingLayers):
915         * rendering/RenderLayerCompositor.h:
916           Fix a typo in CompositingUpdateType Pait->Paint
917
918 2011-04-27  Pratik Solanki  <psolanki@apple.com>
919
920         Reviewed by Antti Koivisto.
921
922         Part of WebCore should use CFNetwork-based loader on Mac
923         https://bugs.webkit.org/show_bug.cgi?id=51836
924
925         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
926         willCacheResponse/shouldCacheResponse.
927
928         * loader/EmptyClients.h:
929         * loader/FrameLoaderClient.h:
930         * loader/ResourceLoader.h:
931         * loader/cf/ResourceLoaderCFNet.cpp:
932         * loader/mac/ResourceLoaderMac.mm:
933         (WebCore::ResourceLoader::willCacheResponse):
934         * platform/network/ResourceHandleClient.h:
935         (WebCore::ResourceHandleClient::willCacheResponse):
936         (WebCore::ResourceHandleClient::shouldCacheResponse):
937         * platform/network/cf/ResourceHandleCFNet.cpp:
938         (WebCore::willCacheResponse):
939
940 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
941
942         Reviewed by Brian Weinstein.
943
944         Web Inspector: Stop on Exception state does not persist.
945
946         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
947         https://bugs.webkit.org/show_bug.cgi?id=59630
948
949         * inspector/front-end/ScriptsPanel.js:
950         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
951         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
952         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
953
954 2011-04-27  Adrienne Walker  <enne@google.com>
955
956         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
957         https://bugs.webkit.org/show_bug.cgi?id=59020
958
959         * platform/graphics/chromium/LayerRendererChromium.cpp:
960         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
961
962 2011-04-27  Darin Adler  <darin@apple.com>
963
964         Reviewed by David Levin.
965
966         Fix strict OwnPtr issues seen in about 30 more files
967         https://bugs.webkit.org/show_bug.cgi?id=59615
968
969         * bindings/js/JSCallbackData.h:
970         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
971         * bindings/js/JSMessageEventCustom.cpp:
972         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
973         * css/CSSParser.cpp:
974         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
975         adoptPtr, and release.
976         * dom/MessageEvent.cpp:
977         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
978         and release.
979         * dom/MessagePortChannel.cpp:
980         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
981         * dom/ScriptExecutionContext.cpp:
982         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
983         * dom/XMLDocumentParserLibxml2.cpp:
984         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
985         * dom/default/PlatformMessagePortChannel.cpp:
986         (WebCore::MessagePortChannel::create): Use adoptPtr.
987         * html/HTMLFormControlElement.cpp:
988         (WebCore::HTMLFormControlElement::detach): Use nullptr.
989         * inspector/InspectorAgent.cpp:
990         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
991         * inspector/InspectorConsoleAgent.cpp:
992         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
993         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
994         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
995         * inspector/InspectorController.cpp:
996         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
997         * inspector/InspectorDOMAgent.cpp:
998         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
999         * inspector/InspectorResourceAgent.cpp:
1000         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1001         * page/FrameActionScheduler.cpp:
1002         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1003         * platform/graphics/ShadowBlur.cpp:
1004         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1005         * platform/graphics/ca/GraphicsLayerCA.cpp:
1006         (WebCore::GraphicsLayer::create): Use adoptPtr.
1007         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1008         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1009         * rendering/RenderBlock.cpp:
1010         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1011         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1012         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
1013         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
1014         * rendering/RenderLayerBacking.cpp:
1015         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
1016         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
1017         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
1018         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
1019         * rendering/RenderLayerCompositor.cpp:
1020         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
1021         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
1022         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
1023         * rendering/style/StyleRareNonInheritedData.cpp:
1024         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
1025         explicit initializations of OwnPtr members to 0. Use adoptPtr.
1026         * workers/SharedWorkerContext.cpp:
1027         (WebCore::createConnectEvent): Use adoptPtr.
1028         * workers/Worker.cpp:
1029         (WebCore::Worker::notifyFinished): Use nullptr.
1030
1031 2011-04-27  Enrica Casucci  <enrica@apple.com>
1032
1033         Reviewed by Darin Adler.
1034
1035         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
1036         https://bugs.webkit.org/show_bug.cgi?id=59251
1037         <rdar://problem/9327044>
1038
1039         When we are looking for wrapping elements that are presentational, we should
1040         include elements that have a non transparent background color only if they
1041         are not blocks.
1042
1043         Test: editing/pasteboard/do-not-copy-body-color.html
1044
1045         * editing/markup.cpp:
1046         (WebCore::isElementPresentational):
1047
1048 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
1049
1050         Reviewed by Antti Koivisto.
1051
1052         Teach sub-selector chains about shadow descendants
1053         https://bugs.webkit.org/show_bug.cgi?id=58342
1054
1055         The primary change is to the logic of parsing specifiers:
1056         1) The shadow descendant selectors (those specifiers that are unknown
1057         pseudo element selectors) are always kept at the top of the chain.
1058         2) The sub-selectors after shadow descendant selectors are stashed right
1059         behind the sub-selector, but not at the end of the chain.
1060         3) Other sub-selectors are appended at the end of the chain.
1061
1062         * css/CSSGrammar.y: Changed specifier_list collection to use new
1063             CSSParser::updateSpecifier helper.
1064         * css/CSSParser.cpp:
1065         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
1066             look for the last ShadowDescendant relation in the chain of selectors,
1067             because the next selector after it is the one that should get the
1068             element name.
1069         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
1070             CSSGrammar.y. The new logic adjusts the selector chain to allow
1071             shadow descendant selectors have sub-selectors (and have multiple shadow
1072             descendants in the chain).
1073         * css/CSSParser.h: Added decl.
1074         * css/CSSParserValues.cpp:
1075         (WebCore::CSSParserSelector::insertTagHistory): Added.
1076         (WebCore::CSSParserSelector::appendTagHistory): Aded.
1077         * css/CSSParserValues.h: Added decls.
1078         * css/CSSStyleSelector.cpp:
1079         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
1080             shadow descendant selector match check, since now there could be many
1081             of them in the selector chain.
1082
1083 2011-04-20  Adrienne Walker  <enne@google.com>
1084
1085         Reviewed by Kenneth Russell.
1086
1087         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
1088         https://bugs.webkit.org/show_bug.cgi?id=59020
1089
1090         mapRect is the incorrect transform here.  The parent scissor rect
1091         needs to be projected into layer space instead.
1092
1093         Test: compositing/flat-with-transformed-child.html
1094
1095         * platform/graphics/chromium/LayerRendererChromium.cpp:
1096         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1097
1098 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1099
1100         Reviewed by Antti Koivisto.
1101
1102         Part of WebCore should use CFNetwork-based loader on Mac
1103         https://bugs.webkit.org/show_bug.cgi?id=51836
1104
1105         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
1106         * platform/mac/SoftLinking.h:
1107         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
1108
1109 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
1110
1111         Reviewed by Antti Koivisto.
1112
1113         Cleanup CSSStyleApplyProperty.cpp
1114         https://bugs.webkit.org/show_bug.cgi?id=59623
1115
1116         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
1117         Use typedefs instead of repating the function pointer declarations in a few places.
1118
1119         * css/CSSStyleApplyProperty.cpp:
1120         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
1121         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
1122         (WebCore::ApplyPropertyColor::applyInheritValue):
1123         (WebCore::ApplyPropertyColor::applyInitialValue):
1124         (WebCore::ApplyPropertyColor::applyValue):
1125         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
1126
1127 2011-04-27  Dan Bernstein  <mitz@apple.com>
1128
1129         Reviewed by Anders Carlsson.
1130
1131         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
1132         https://bugs.webkit.org/show_bug.cgi?id=59622
1133
1134         Test: fast/borders/border-image-trumps-radius.html
1135
1136         * rendering/RenderBox.cpp:
1137         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
1138         image, then border radius is ignored, so no bleed avoidance is needed.
1139         * rendering/RenderObject.cpp:
1140         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
1141         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
1142         * rendering/RenderObject.h:
1143
1144 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1145
1146         Reviewed by Xan Lopez.
1147
1148         [GTK] editing/pasteboard/copy-standalone-image.html fails
1149         https://bugs.webkit.org/show_bug.cgi?id=53645
1150
1151         When writing an image to the clipboard, also write the URL and title
1152         into the markup and URL portion. This change also abstracts a helper
1153         imageToMarkup into markup.{cpp/h} from several different locations
1154         throughout the platform layer.
1155
1156         * editing/markup.h: Added new function definition.
1157         * editing/markup.cpp:
1158         (WebCore::imageToMarkup): Add this function which turns an image URL 
1159         and element into some markup representing that image, while preserving
1160         non-src attributes.
1161         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
1162         to markup.cpp.
1163         * platform/gtk/PasteboardGtk.cpp:
1164         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
1165         image URL for a variety of image tag types.
1166         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
1167         markup and URL portions of the clipboard. This will ensure that images
1168         paste properly back into WebKit.
1169         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
1170         one from markup.h
1171
1172 2011-04-27  Steve Block  <steveblock@google.com>
1173
1174         Reviewed by David Levin.
1175
1176         Remove Android build system
1177         https://bugs.webkit.org/show_bug.cgi?id=48111
1178
1179         This is to avoid the maintenance burden until the Android port is
1180         fully upstreamed.
1181
1182         No new tests, build change only.
1183
1184         * Android.derived.jscbindings.mk: Removed.
1185         * Android.derived.mk: Removed.
1186         * Android.derived.v8bindings.mk: Removed.
1187         * Android.jscbindings.mk: Removed.
1188         * Android.mk: Removed.
1189         * Android.v8bindings.mk: Removed.
1190
1191 2011-04-27  Darin Adler  <darin@apple.com>
1192
1193         Reviewed by Sam Weinig.
1194
1195         Somehow about:blank gets into the icon database
1196         https://bugs.webkit.org/show_bug.cgi?id=58067
1197         rdar://problem/6751446
1198
1199         Implemented the policy Brady suggested, where only http and https URLs can
1200         be associated with and icon, guarding both on the way in to the database,
1201         and on the way out.
1202
1203         * loader/icon/IconDatabase.cpp:
1204         (WebCore::pageCanHaveIcon): Added.
1205         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
1206         instead of just checking for an empty URL.
1207         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
1208         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
1209         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
1210         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
1211         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
1212         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
1213         two separate assertions and added a third.
1214         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
1215
1216         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
1217         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
1218         overloaded it to work on both UChar and char, and added an assertion to it.
1219         Also moved this to the top of the file and made the UChar version usable
1220         in the shared code used even by Google.
1221         (WebCore::KURL::invalidate): Updated for name change.
1222         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
1223         toASCIILower since it's faster.
1224         (WebCore::KURL::parse): Updated for name changes.
1225         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
1226         since it's faster.
1227         (WebCore::protocolIsInHTTPFamily): Added.
1228
1229         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
1230         to protocolIsInHTTPFamily and added a version that works on a string.
1231         Kept the old name as an inline function so we don't have to rename
1232         all the cal sites now.
1233
1234         * platform/KURLGoogle.cpp: Renamed as above.
1235         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
1236         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
1237         (WebCore::KURLGooglePrivate::setAscii): Ditto.
1238         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
1239         (WebCore::KURLGooglePrivate::copyTo): Ditto.
1240         (WebCore::KURL::KURL): Ditto.
1241         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
1242         (WebCore::KURL::invalidate): Ditto.
1243         * platform/KURLGooglePrivate.h: Ditto.
1244
1245         * WebCore.exp.in: Updated for above changes.
1246
1247 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1248
1249         Reviewed by Pavel Feldman.
1250
1251         Web Inspector: browser crash on evaluation of 'throw undefined'
1252         https://bugs.webkit.org/show_bug.cgi?id=59611
1253
1254         Test: inspector/console/console-eval-throw-undefined.html
1255
1256         * inspector/InjectedScriptSource.js: use try/catch to protect from
1257         exception during conversion of another exception to string.
1258
1259 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1260
1261         Reviewed by Yury Semikhatsky.
1262
1263         Web Inspector: clicking bookmarklet multiplies resources panel entries.
1264         https://bugs.webkit.org/show_bug.cgi?id=59590
1265
1266         * inspector/front-end/ResourceTreeModel.js:
1267         (WebInspector.ResourceTreeModel):
1268         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
1269         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1270         * inspector/front-end/ResourcesPanel.js:
1271         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1272         (WebInspector.FrameTreeElement):
1273         (WebInspector.FrameTreeElement.prototype.appendResource):
1274         * inspector/front-end/inspector.js:
1275         (WebInspector.frontendReused):
1276
1277 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1278
1279         Reviewed by Yury Semikhatsky.
1280
1281         Web Inspector: opening bookmarklet disconnects DOM agent.
1282         https://bugs.webkit.org/show_bug.cgi?id=59588
1283
1284         * inspector/InspectorDOMAgent.cpp:
1285         (WebCore::InspectorDOMAgent::setDocument):
1286
1287 2011-04-27  Hans Wennborg  <hans@chromium.org>
1288
1289         Reviewed by Tony Gentilcore.
1290
1291         IndexedDB: Fix compiler warnings about uninitialized variables
1292         https://bugs.webkit.org/show_bug.cgi?id=59599
1293
1294         Build fix. No new tests.
1295
1296         * storage/IDBLevelDBBackingStore.cpp:
1297         (WebCore::getNewObjectStoreId):
1298         (WebCore::getNewIndexId):
1299
1300 2011-04-26  Hans Wennborg  <hans@chromium.org>
1301
1302         Reviewed by Tony Gentilcore.
1303
1304         IndexedDB: Move LevelDB key coding routines to separate file
1305         https://bugs.webkit.org/show_bug.cgi?id=59452
1306
1307         Move all routines concerned with encoding, decoding and comparison of
1308         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
1309         IDBLevelDBCoding.cpp.
1310
1311         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
1312         allow for unit testing of the coding routines.
1313
1314         No new functionality, no new tests.
1315
1316         * WebCore.gypi:
1317         * storage/IDBLevelDBBackingStore.cpp:
1318         (WebCore::getInt):
1319         (WebCore::putInt):
1320         (WebCore::getString):
1321         (WebCore::putString):
1322         (WebCore::compareKeys):
1323         (WebCore::compareIndexKeys):
1324         (WebCore::Comparator::compare):
1325         (WebCore::setUpMetadata):
1326         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
1327         (WebCore::getNewDatabaseId):
1328         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
1329         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1330         (WebCore::getNewObjectStoreId):
1331         (WebCore::IDBLevelDBBackingStore::createObjectStore):
1332         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
1333         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
1334         (WebCore::getNewVersionNumber):
1335         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
1336         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
1337         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
1338         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1339         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
1340         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1341         (WebCore::IDBLevelDBBackingStore::getIndexes):
1342         (WebCore::getNewIndexId):
1343         (WebCore::IDBLevelDBBackingStore::createIndex):
1344         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
1345         (WebCore::versionExists):
1346         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1347         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1348         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
1349         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
1350         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
1351         * storage/IDBLevelDBCoding.cpp: Added.
1352         (WebCore::IDBLevelDBCoding::encodeByte):
1353         (WebCore::IDBLevelDBCoding::maxIDBKey):
1354         (WebCore::IDBLevelDBCoding::minIDBKey):
1355         (WebCore::IDBLevelDBCoding::encodeInt):
1356         (WebCore::IDBLevelDBCoding::decodeInt):
1357         (WebCore::IDBLevelDBCoding::encodeVarInt):
1358         (WebCore::IDBLevelDBCoding::decodeVarInt):
1359         (WebCore::IDBLevelDBCoding::encodeString):
1360         (WebCore::IDBLevelDBCoding::decodeString):
1361         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
1362         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
1363         (WebCore::IDBLevelDBCoding::encodeDouble):
1364         (WebCore::IDBLevelDBCoding::decodeDouble):
1365         (WebCore::IDBLevelDBCoding::encodeIDBKey):
1366         (WebCore::IDBLevelDBCoding::decodeIDBKey):
1367         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
1368         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
1369         (WebCore::IDBLevelDBCoding::compare):
1370         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
1371         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
1372         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
1373         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
1374         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
1375         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
1376         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
1377         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
1378         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
1379         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
1380         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
1381         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
1382         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
1383         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
1384         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
1385         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
1386         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
1387         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
1388         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
1389         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
1390         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
1391         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
1392         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
1393         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
1394         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
1395         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
1396         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
1397         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
1398         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
1399         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
1400         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
1401         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
1402         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
1403         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
1404         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
1405         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
1406         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
1407         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
1408         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
1409         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
1410         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
1411         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
1412         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
1413         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
1414         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
1415         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
1416         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
1417         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
1418         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
1419         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
1420         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
1421         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
1422         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
1423         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
1424         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
1425         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
1426         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
1427         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
1428         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
1429         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
1430         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
1431         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
1432         * storage/IDBLevelDBCoding.h: Added.
1433         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
1434         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
1435         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
1436         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
1437         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
1438
1439 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1440
1441         Reviewed by Pavel Feldman.
1442
1443         Web Inspector: expose exception details when script is paused on exception
1444         https://bugs.webkit.org/show_bug.cgi?id=59591
1445
1446         When script is paused on an exception, the exception value is added as <exception>
1447         property in the local scope and the breakpoint details message says
1448         "Paused on excepion: '<exception to strin value>'."
1449
1450         * English.lproj/localizedStrings.js:
1451         * inspector/front-end/ScopeChainSidebarPane.js:
1452         (WebInspector.ScopeChainSidebarPane.prototype.update):
1453         * inspector/front-end/ScriptsPanel.js:
1454         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
1455         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
1456
1457 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
1458
1459         Reviewed by Pavel Feldman.
1460
1461         Web Inspector: [protocol] Paused event should expose exception value that caused it
1462         https://bugs.webkit.org/show_bug.cgi?id=58996
1463
1464         Debug.pause event now contains an optional reference to the exception
1465         object in case script execution is paused on a JavaScript exception.
1466
1467         Also JavaScript call frames are passed directly into the injected script when
1468         we need to wrap them for passing to the front-end. This change breaks cyclic
1469         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
1470
1471         * bindings/js/JSInjectedScriptHostCustom.cpp:
1472         * bindings/js/ScriptDebugServer.cpp:
1473         (WebCore::ScriptDebugServer::dispatchDidPause):
1474         * bindings/js/ScriptDebugServer.h:
1475         * bindings/v8/ScriptDebugServer.cpp:
1476         (WebCore::ScriptDebugServer::breakProgram):
1477         (WebCore::ScriptDebugServer::editScriptSource):
1478         (WebCore::ScriptDebugServer::breakProgramCallback):
1479         (WebCore::ScriptDebugServer::handleV8DebugEvent):
1480         * bindings/v8/ScriptDebugServer.h:
1481         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
1482         * inspector/InjectedScript.cpp:
1483         (WebCore::InjectedScript::evaluateOnCallFrame):
1484         (WebCore::InjectedScript::wrapCallFrames):
1485         * inspector/InjectedScript.h:
1486         * inspector/InjectedScriptHost.cpp:
1487         * inspector/InjectedScriptHost.h:
1488         (WebCore::InjectedScriptHost::init):
1489         * inspector/InjectedScriptHost.idl:
1490         * inspector/InjectedScriptSource.js:
1491         (.):
1492         * inspector/Inspector.json:
1493         * inspector/InspectorAgent.cpp:
1494         (WebCore::InspectorAgent::InspectorAgent):
1495         * inspector/InspectorDebuggerAgent.cpp:
1496         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
1497         (WebCore::InspectorDebuggerAgent::currentCallFrames):
1498         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
1499         (WebCore::InspectorDebuggerAgent::didPause):
1500         (WebCore::InspectorDebuggerAgent::didContinue):
1501         (WebCore::InspectorDebuggerAgent::clear):
1502         * inspector/InspectorDebuggerAgent.h:
1503         * inspector/ScriptDebugListener.h:
1504         * inspector/WorkerInspectorController.cpp:
1505         (WebCore::WorkerInspectorController::WorkerInspectorController):
1506
1507 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1508
1509         Reviewed by Yury Semikhatsky.
1510
1511         Web Inspector: implement incremental CSS editing in the structure view.
1512         https://bugs.webkit.org/show_bug.cgi?id=59455
1513
1514         * inspector/front-end/StylesSidebarPane.js:
1515         (WebInspector.StylePropertyTreeElement.prototype):
1516
1517 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
1518
1519         Reviewed by Eric Seidel.
1520
1521         Frame.h shouldn't include Document.h
1522         https://bugs.webkit.org/show_bug.cgi?id=59560
1523
1524         Frame can use a forward-declared Document if we move
1525         Frame::displayStringModifiedByEncoding's implementation out of the
1526         header.
1527                                 Size  #includes  Size * #includes
1528         Before: page/Frame.h:   0.746       653           487.138
1529                 dom/Document.h: 0.220      1306           287.320
1530         
1531         After:  page/Frame.h:   0.646       653           421.838
1532                 dom/Document.h: 0.220      1189           261.580
1533
1534         * WebCore.exp.in:
1535         * bindings/ScriptControllerBase.cpp:
1536         * bindings/generic/BindingSecurityBase.cpp:
1537         * bindings/v8/V8Proxy.cpp:
1538         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
1539         * dom/CharacterData.cpp:
1540         * dom/UserTypingGestureIndicator.cpp:
1541         * editing/chromium/SelectionControllerChromium.cpp:
1542         * inspector/InspectorDOMStorageResource.cpp:
1543         * inspector/InspectorInstrumentation.h:
1544         * loader/PingLoader.cpp:
1545         * loader/SubresourceLoader.cpp:
1546         * loader/appcache/DOMApplicationCache.cpp:
1547         * loader/cache/CachedResourceRequest.cpp:
1548         * page/Frame.cpp:
1549         (WebCore::Frame::displayStringModifiedByEncoding):
1550         * page/Frame.h:
1551         * page/Geolocation.cpp:
1552         * page/Location.cpp:
1553         * page/Navigator.cpp:
1554         * page/PageGroupLoadDeferrer.cpp:
1555         * page/PerformanceTiming.cpp:
1556         * xml/XSLTProcessorLibxslt.cpp:
1557
1558 2011-04-27  James Robinson  <jamesr@chromium.org>
1559
1560         Reviewed by Eric Seidel.
1561
1562         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
1563         https://bugs.webkit.org/show_bug.cgi?id=59377
1564
1565         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
1566         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
1567
1568         * css/CSSStyleSelector.cpp:
1569         (WebCore::CSSStyleSelector::applyProperty):
1570         * page/animation/AnimationBase.cpp:
1571         (WebCore::blendFunc):
1572         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
1573         (WebCore::PropertyWrapperShadow::blend):
1574         * rendering/style/RenderStyle.cpp:
1575         (WebCore::RenderStyle::setTextShadow):
1576         (WebCore::RenderStyle::setBoxShadow):
1577         * rendering/style/RenderStyle.h:
1578         (WebCore::InheritedFlags::textShadow):
1579         * rendering/style/ShadowData.cpp:
1580         (WebCore::ShadowData::ShadowData):
1581         * rendering/style/ShadowData.h:
1582         (WebCore::ShadowData::ShadowData):
1583         (WebCore::ShadowData::next):
1584         (WebCore::ShadowData::setNext):
1585         * rendering/style/StyleRareInheritedData.cpp:
1586         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1587         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
1588         * rendering/style/StyleRareInheritedData.h:
1589         * rendering/style/StyleRareNonInheritedData.cpp:
1590         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
1591
1592 2011-04-26  David Levin  <levin@chromium.org>
1593
1594         Reviewed by Eric Seidel.
1595
1596         Fix some strict PassOwnPtr issues in WebCore.
1597         https://bugs.webkit.org/show_bug.cgi?id=59563
1598
1599         * css/SVGCSSStyleSelector.cpp:
1600         (WebCore::CSSStyleSelector::applySVGProperty):
1601         * html/canvas/WebGLRenderingContext.cpp:
1602         (WebCore::WebGLRenderingContext::create):
1603         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
1604         * platform/text/TextCodecLatin1.cpp:
1605         (WebCore::newStreamingTextDecoderWindowsLatin1):
1606         * platform/text/TextCodecUTF16.cpp:
1607         (WebCore::newStreamingTextDecoderUTF16LE):
1608         (WebCore::newStreamingTextDecoderUTF16BE):
1609         * platform/text/TextCodecUserDefined.cpp:
1610         (WebCore::newStreamingTextDecoderUserDefined):
1611         * platform/text/mac/TextCodecMac.cpp:
1612         (WebCore::newTextCodecMac):
1613         * workers/Worker.cpp:
1614         (WebCore::Worker::notifyFinished):
1615
1616 2011-04-26  Justin Novosad  <junov@chromium.org>
1617
1618         Reviewed by Kenneth Russell.
1619
1620         [Chromium] Expose skia gpu canvas rendering as a runtime flag
1621         https://bugs.webkit.org/show_bug.cgi?id=58683
1622         Replace the SKIA_GPU compile flag by the pre-existing
1623         acceleratedDrawingEnabled flag. Most code changes are trivial:
1624         compile-time conditionals on SKIA_GPU were either replaced with
1625         a run-time check, or a compile time check on USE(SKIA) 
1626
1627         No new tests. Covered by existing tests.
1628
1629         * html/canvas/CanvasRenderingContext2D.cpp:
1630         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
1631         * page/Page.cpp:
1632         (WebCore::Page::sharedGraphicsContext3D):
1633         Added check for the acceleratedDrawing flag.
1634         * platform/graphics/chromium/DrawingBufferChromium.cpp:
1635         (WebCore::DrawingBuffer::DrawingBuffer):
1636         (WebCore::DrawingBuffer::publishToPlatformLayer):
1637         * platform/graphics/gpu/DrawingBuffer.h:
1638         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
1639         (WebCore::SharedGraphicsContext3D::create):
1640         On Skia builds, this methos now receives a bool arg to turn on
1641         GPU-accelerated skia rendering
1642         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
1643         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
1644         (WebCore::SharedGraphicsContext3D::grContext):
1645         * platform/graphics/gpu/SharedGraphicsContext3D.h:
1646         * platform/graphics/skia/ImageSkia.cpp:
1647         (WebCore::computeResamplingMode):
1648         (WebCore::paintSkBitmap):
1649         (WebCore::Image::drawPattern):
1650         * platform/graphics/skia/PlatformContextSkia.cpp:
1651         (WebCore::PlatformContextSkia::PlatformContextSkia):
1652         (WebCore::PlatformContextSkia::~PlatformContextSkia):
1653         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
1654         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
1655         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
1656         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
1657         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
1658         (WebCore::PlatformContextSkia::markDirtyRect):
1659         * platform/graphics/skia/PlatformContextSkia.h:
1660         (WebCore::PlatformContextSkia::accelerationMode):
1661         (WebCore::PlatformContextSkia::useGPU):
1662         (WebCore::PlatformContextSkia::useSkiaGPU):
1663
1664 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
1665
1666         Not reviewed: restore inspector test disabled in r84913.
1667
1668         Test: http/tests/inspector-enabled/dom-storage-open.html
1669
1670         * inspector/InspectorDOMStorageAgent.cpp:
1671         (WebCore::InspectorDOMStorageAgent::clearFrontend):
1672
1673 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
1674
1675         Reviewed by Tony Chang.
1676
1677         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
1678         https://bugs.webkit.org/show_bug.cgi?id=59182
1679
1680         Use vertical offsets of the shaping results.
1681
1682         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
1683
1684         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1685         (WebCore::ComplexTextController::ComplexTextController):
1686         Added initialization of m_startingY.
1687         (WebCore::ComplexTextController::nextScriptRun):
1688         Followed the change in handling positions.
1689         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
1690         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
1691         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
1692         (WebCore::ComplexTextController::setGlyphPositions):
1693         Changed to use vertical offsets as same as horizontal offsets.
1694         * platform/graphics/chromium/ComplexTextControllerLinux.h:
1695         Removed m_xPositions and Added m_positions and m_startingY.
1696         (WebCore::ComplexTextController::positions): Added.
1697         * platform/graphics/chromium/FontLinux.cpp:
1698         Followed the change in ComplexTextController.
1699         (WebCore::Font::drawComplexText): Ditto.
1700         (WebCore::Font::floatWidthForComplexText): Ditto.
1701         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
1702         (WebCore::Font::offsetForPositionForComplexText): Ditto.
1703         (WebCore::Font::selectionRectForComplexText): Ditto.
1704
1705 2011-04-26  Levi Weintraub  <leviw@chromium.org>
1706
1707         Reviewed by Eric Seidel.
1708
1709         Root element should establish a new block formatting context
1710         https://bugs.webkit.org/show_bug.cgi?id=54573
1711
1712         Always expanding the root renderer to include overhanging floats.
1713
1714         Test: fast/block/float/float-overhangs-root.html
1715
1716         * rendering/RenderBlock.cpp:
1717         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
1718
1719 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
1720
1721         Reviewed by Andreas Kling.
1722
1723         [Qt] Improper rendering of <button> tag when it contains a <br>
1724         https://bugs.webkit.org/show_bug.cgi?id=50521
1725
1726         Test: platform/qt/fast/forms/button-line-break.html
1727
1728         * platform/qt/RenderThemeQt.cpp:
1729         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
1730         (WebCore::RenderThemeQt::setButtonPadding):
1731
1732 2011-04-26  James Robinson  <jamesr@chromium.org>
1733
1734         Reviewed by Kenneth Russell.
1735
1736         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
1737         https://bugs.webkit.org/show_bug.cgi?id=59572
1738
1739         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
1740         when LayerRendererChromium was set.  We set this pointer every frame
1741         and should only reset the tiles if the new LayerRendererChromium is
1742         different from the old one (indicating a context loss), not just reset
1743         on every frame.
1744
1745         * platform/graphics/chromium/LayerTilerChromium.cpp:
1746         (WebCore::LayerTilerChromium::setLayerRenderer):
1747         * platform/graphics/chromium/LayerTilerChromium.h:
1748
1749 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
1750
1751         Reviewed by Eric Seidel.
1752
1753         beginElement broken by setAttribute
1754         https://bugs.webkit.org/show_bug.cgi?id=26019
1755
1756         Test: svg/animations/animate-beginElementAt.svg
1757
1758         * svg/SVGAnimationElement.cpp:
1759         (WebCore::SVGAnimationElement::attributeChanged):
1760         Reset the animation state here as the rest of the code reads it and would still
1761         think we are animating when we are not.
1762
1763         * svg/animation/SVGSMILElement.h:
1764         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
1765
1766 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1767
1768         Unreviewed, rolling out r84989.
1769         http://trac.webkit.org/changeset/84989
1770         https://bugs.webkit.org/show_bug.cgi?id=59566
1771
1772         REGRESSION (r84989): Lots of vertical text tests failing on
1773         windows (Requested by weinig on #webkit).
1774
1775         * platform/graphics/FontPlatformData.h:
1776         * platform/graphics/win/FontCacheWin.cpp:
1777         (WebCore::FontCache::getFontDataForCharacters):
1778         (WebCore::FontCache::createFontPlatformData):
1779         * platform/graphics/win/FontCustomPlatformData.cpp:
1780         (WebCore::FontCustomPlatformData::fontPlatformData):
1781         * platform/graphics/win/FontPlatformDataCGWin.cpp:
1782         (WebCore::FontPlatformData::FontPlatformData):
1783         * platform/graphics/win/FontPlatformDataWin.cpp:
1784         (WebCore::FontPlatformData::FontPlatformData):
1785
1786 2011-04-26  Sam Weinig  <sam@webkit.org>
1787
1788         Reviewed by Eric Seidel.
1789
1790         Try again:
1791             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
1792             https://bugs.webkit.org/show_bug.cgi?id=59310
1793
1794         * bindings/js/JSDOMBinding.h:
1795         (WebCore::DOMConstructorObject::DOMConstructorObject):
1796         * bindings/js/JSDOMWrapper.h:
1797         (WebCore::JSDOMWrapper::globalObject):
1798         (WebCore::JSDOMWrapper::scriptExecutionContext):
1799         (WebCore::JSDOMWrapper::createStructure):
1800         (WebCore::JSDOMWrapper::JSDOMWrapper):
1801         * bindings/scripts/CodeGeneratorJS.pm:
1802
1803 2011-04-26  Sam Weinig  <sam@webkit.org>
1804
1805         Reviewed by David Hyatt.
1806
1807         Remove Datagrid from the tree
1808         https://bugs.webkit.org/show_bug.cgi?id=59543
1809
1810         * Android.derived.jscbindings.mk:
1811         * Android.derived.v8bindings.mk:
1812         * Android.jscbindings.mk:
1813         * Android.v8bindings.mk:
1814         * CMakeLists.txt:
1815         * CodeGenerators.pri:
1816         * Configurations/FeatureDefines.xcconfig:
1817         * DerivedSources.cpp:
1818         * DerivedSources.make:
1819         * GNUmakefile.am:
1820         * GNUmakefile.list.am:
1821         * UseJSC.cmake:
1822         * WebCore.gypi:
1823         * WebCore.pro:
1824         * WebCore.vcproj/WebCore.vcproj:
1825         * WebCore.xcodeproj/project.pbxproj:
1826         * bindings/js/JSBindingsAllInOne.cpp:
1827         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
1828         * bindings/js/JSDataGridDataSource.cpp: Removed.
1829         * bindings/js/JSDataGridDataSource.h: Removed.
1830         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
1831         * bindings/v8/V8DataGridDataSource.cpp: Removed.
1832         * bindings/v8/V8DataGridDataSource.h: Removed.
1833         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
1834         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
1835         * css/CSSStyleSelector.cpp:
1836         * css/CSSStyleSelector.h:
1837         * css/html.css:
1838         (input, textarea, keygen, select, button, isindex):
1839         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
1840         * editing/htmlediting.cpp:
1841         (WebCore::canHaveChildrenForEditing):
1842         * features.pri:
1843         * html/DOMDataGridDataSource.cpp: Removed.
1844         * html/DOMDataGridDataSource.h: Removed.
1845         * html/DataGridColumn.cpp: Removed.
1846         * html/DataGridColumn.h: Removed.
1847         * html/DataGridColumn.idl: Removed.
1848         * html/DataGridColumnList.cpp: Removed.
1849         * html/DataGridColumnList.h: Removed.
1850         * html/DataGridColumnList.idl: Removed.
1851         * html/DataGridDataSource.h: Removed.
1852         * html/HTMLDataGridCellElement.cpp: Removed.
1853         * html/HTMLDataGridCellElement.h: Removed.
1854         * html/HTMLDataGridCellElement.idl: Removed.
1855         * html/HTMLDataGridColElement.cpp: Removed.
1856         * html/HTMLDataGridColElement.h: Removed.
1857         * html/HTMLDataGridColElement.idl: Removed.
1858         * html/HTMLDataGridElement.cpp: Removed.
1859         * html/HTMLDataGridElement.h: Removed.
1860         * html/HTMLDataGridElement.idl: Removed.
1861         * html/HTMLDataGridRowElement.cpp: Removed.
1862         * html/HTMLDataGridRowElement.h: Removed.
1863         * html/HTMLDataGridRowElement.idl: Removed.
1864         * html/HTMLElement.cpp:
1865         (WebCore::HTMLElement::ieForbidsInsertHTML):
1866         * html/HTMLElementsAllInOne.cpp:
1867         * html/HTMLTagNames.in:
1868         * page/DOMWindow.idl:
1869         * rendering/RenderBox.cpp:
1870         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
1871         * rendering/RenderDataGrid.cpp: Removed.
1872         * rendering/RenderDataGrid.h: Removed.
1873         * rendering/RenderingAllInOne.cpp:
1874
1875 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
1876
1877         Reviewed by Adele Peterson.
1878
1879         On WebKit (Windows), glyphs in vertical text tests are rotated 90
1880         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
1881
1882         This platform dependent patch makes WebKit (Windows) show the
1883         vertical writing text correctly.  Job was done by adding a prefix '@'
1884         in front of the font family name (Windows Only). No new tests added.
1885         Some layout tests images:
1886         http://www.flickr.com/photos/burorly/sets/72157625585506341/
1887
1888         * platform/graphics/FontPlatformData.h:
1889         * platform/graphics/win/FontCacheWin.cpp:
1890         (WebCore::FontCache::getFontDataForCharacters):
1891         (WebCore::FontCache::createFontPlatformData):
1892         * platform/graphics/win/FontCustomPlatformData.cpp:
1893         (WebCore::FontCustomPlatformData::fontPlatformData):
1894         * platform/graphics/win/FontPlatformDataCGWin.cpp:
1895         (WebCore::FontPlatformData::FontPlatformData):
1896         * platform/graphics/win/FontPlatformDataWin.cpp:
1897         (WebCore::FontPlatformData::FontPlatformData):
1898
1899 2011-04-26  Jer Noble  <jer.noble@apple.com>
1900
1901         Reviewed by Brady Eidson.
1902
1903         HTML5 video fullscreen transition causes an audio stutter
1904         https://bugs.webkit.org/show_bug.cgi?id=59544
1905
1906         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
1907         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
1908         layer to render it invisible, instead just set the layer as hidden.
1909
1910         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1911         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
1912         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
1913         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
1914         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
1915         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
1916
1917 2011-04-26  Christian Dywan  <christian@lanedo.com>
1918
1919         Reviewed by Eric Seidel.
1920
1921         Extra separator after Select All in context menu
1922         https://bugs.webkit.org/show_bug.cgi?id=54092
1923
1924         * page/ContextMenuController.cpp: Move separator to non-GTK+
1925             port guards since it is for the spelling options menu
1926             which the GTK+ port doesn't use.
1927
1928 2011-04-26  James Robinson  <jamesr@chromium.org>
1929
1930         Reviewed by Kenneth Russell.
1931
1932         [chromium] Clear out LayerTilerChromium's tiles on lost context
1933         https://bugs.webkit.org/show_bug.cgi?id=59233
1934
1935         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
1936         no longer valid since they exist in the previous LayerRendererChromium.
1937
1938         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
1939
1940         * platform/graphics/chromium/LayerTilerChromium.h:
1941         (WebCore::LayerTilerChromium::setLayerRenderer):
1942
1943 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
1944
1945         Reviewed by Dirk Schulze.
1946
1947         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
1948         https://bugs.webkit.org/show_bug.cgi?id=57644
1949
1950         Manual test: plugins/windowed-in-iframe-2.html
1951
1952         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
1953         * platform/gtk/WidgetGtk.cpp:
1954         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
1955         * plugins/PluginView.h: Added helper method to set the allocation and clip.
1956         * plugins/gtk/PluginViewGtk.cpp:
1957         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
1958         the allocation immediately. Bring this method into sync with the implementation in
1959         the Qt port.
1960         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
1961         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
1962
1963 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
1964
1965         Reviewed by Eric Seidel.
1966
1967         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
1968         https://bugs.webkit.org/show_bug.cgi?id=58818
1969
1970         Prevent allocating scratch buffers larger than the target GdkDrawable
1971         when creating a WidgetRenderingContext. This prevents incredibly large
1972         widgets from crashing the X Server. This change also allowed greatly
1973         simplifying the way that the painting offset is calculated.
1974
1975         * platform/gtk/WidgetRenderingContext.cpp:
1976         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
1977         larger than the target GdkDrawable.
1978         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
1979         blit by looking at the location of the target rect itself, rather than delaying the
1980         calculation up to this point.
1981         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
1982         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
1983         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
1984         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
1985         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
1986         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
1987         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
1988         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
1989         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
1990         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
1991         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
1992         a member to store the IntSize mapping from the coordinates of the target to the coordinates
1993         of the scratch buffer.
1994
1995 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
1996
1997         Reviewed by Adam Barth.
1998
1999         Respect charset in handleDataURL
2000         https://bugs.webkit.org/show_bug.cgi?id=47746
2001
2002         Original patch by Kwang Yul Seo <skyul@company100.net>
2003
2004         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2005         returns an empty string because encoding name is not specified.
2006
2007         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2008
2009         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2010
2011         * platform/network/DataURL.cpp:
2012         (WebCore::handleDataURL):
2013
2014 2011-04-26  Anders Carlsson  <andersca@apple.com>
2015
2016         Fix clang++ build.
2017
2018         You can never have too many casts!
2019
2020         * accessibility/mac/AccessibilityObjectWrapper.mm:
2021         (-[AccessibilityObjectWrapper position]):
2022         * editing/mac/SelectionControllerMac.mm:
2023         (WebCore::accessibilityConvertScreenRect):
2024
2025 2011-04-26  Chris Rogers  <crogers@google.com>
2026
2027         Reviewed by Kenneth Russell.
2028
2029         Fix web audio build on mac port
2030         https://bugs.webkit.org/show_bug.cgi?id=59355
2031
2032         No new tests since audio API is not yet implemented.
2033
2034         * WebCore.xcodeproj/project.pbxproj:
2035         * bindings/js/JSAudioContextCustom.cpp:
2036         (WebCore::JSAudioContext::visitChildren):
2037         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
2038         (WebCore::JSJavaScriptAudioNode::visitChildren):
2039         * webaudio/AudioContext.idl:
2040
2041 2011-04-26  Chris Rogers  <crogers@google.com>
2042
2043         Reviewed by Kenneth Russell.
2044
2045         Add FFTFrame implementation for FFmpeg
2046         https://bugs.webkit.org/show_bug.cgi?id=59408
2047
2048         No new tests since audio API is not yet implemented.
2049
2050         * WebCore.gyp/WebCore.gyp:
2051         * WebCore.gypi:
2052         * platform/audio/FFTFrame.h:
2053         * platform/audio/FFTFrameStub.cpp:
2054         * platform/audio/ffmpeg: Added.
2055         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
2056         (WebCore::FFTFrame::FFTFrame):
2057         (WebCore::FFTFrame::initialize):
2058         (WebCore::FFTFrame::cleanup):
2059         (WebCore::FFTFrame::~FFTFrame):
2060         (WebCore::FFTFrame::multiply):
2061         (WebCore::FFTFrame::doFFT):
2062         (WebCore::FFTFrame::doInverseFFT):
2063         (WebCore::FFTFrame::realData):
2064         (WebCore::FFTFrame::imagData):
2065         (WebCore::FFTFrame::getUpToDateComplexData):
2066         (WebCore::FFTFrame::contextForSize):
2067         * platform/audio/mac/FFTFrameMac.cpp:
2068         * webaudio/ConvolverNode.cpp:
2069
2070 2011-04-26  Jeff Miller  <jeffm@apple.com>
2071
2072         Add a newline at the end of SVGFEDropShadowElement.idl.
2073
2074         * svg/SVGFEDropShadowElement.idl:
2075
2076 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2077
2078         Reviewed by Eric Seidel.
2079
2080         InlineBox.h shouldn't include RenderBR.h
2081         https://bugs.webkit.org/show_bug.cgi?id=59480
2082
2083         Per bug 59348 RenderBR.h is a "top header" by include * size, because
2084         InlineBox.h includes it. There's no reason why it has to.
2085
2086         * rendering/InlineBox.h:
2087         * rendering/InlineTextBox.cpp:
2088         * rendering/RenderBlock.h:
2089
2090 2011-04-26  Sam Weinig  <sam@webkit.org>
2091
2092         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
2093         I should do.
2094
2095         * bindings/js/JSDOMBinding.h:
2096         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2097         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2098         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2099         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2100         (WebCore::DOMConstructorObject::DOMConstructorObject):
2101         * bindings/js/JSDOMWrapper.h:
2102         (WebCore::JSDOMWrapper::JSDOMWrapper):
2103         * bindings/scripts/CodeGeneratorJS.pm:
2104
2105 2011-04-26  Sam Weinig  <sam@webkit.org>
2106
2107         Fix build.
2108
2109         * bindings/js/JSDOMWrapper.h:
2110         (WebCore::JSDOMWrapper::globalObject):
2111
2112 2011-04-26  Sam Weinig  <sam@webkit.org>
2113
2114         Roll r84945 back in with infinite recursion removed.
2115
2116         * bindings/js/JSDOMBinding.h:
2117         (WebCore::DOMConstructorObject::DOMConstructorObject):
2118         * bindings/js/JSDOMWrapper.h:
2119         (WebCore::JSDOMWrapper::globalObject):
2120         (WebCore::JSDOMWrapper::scriptExecutionContext):
2121         (WebCore::JSDOMWrapper::createStructure):
2122         (WebCore::JSDOMWrapper::JSDOMWrapper):
2123         * bindings/scripts/CodeGeneratorJS.pm:
2124
2125 2011-04-26  Sam Weinig  <sam@webkit.org>
2126
2127         Rollout previous patch. It broke stuff.
2128
2129         * bindings/js/JSDOMBinding.h:
2130         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2131         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2132         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2133         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2134         (WebCore::DOMConstructorObject::DOMConstructorObject):
2135         * bindings/js/JSDOMWrapper.h:
2136         (WebCore::JSDOMWrapper::JSDOMWrapper):
2137         * bindings/scripts/CodeGeneratorJS.pm:
2138
2139 2011-04-26  Sam Weinig  <sam@webkit.org>
2140
2141         Reviewed by Maciej Stachowiak.
2142
2143         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2144         https://bugs.webkit.org/show_bug.cgi?id=59310
2145
2146         * bindings/js/JSDOMBinding.h:
2147         (WebCore::DOMConstructorObject::DOMConstructorObject):
2148         * bindings/js/JSDOMWrapper.h:
2149         (WebCore::JSDOMWrapper::globalObject):
2150         (WebCore::JSDOMWrapper::scriptExecutionContext):
2151         (WebCore::JSDOMWrapper::createStructure):
2152         (WebCore::JSDOMWrapper::JSDOMWrapper):
2153         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
2154
2155         * bindings/scripts/CodeGeneratorJS.pm:
2156         Make JSDOMWrapper the base class.
2157
2158 2011-04-26  Dan Bernstein  <mitz@apple.com>
2159
2160         Reviewed by Mark Rowe.
2161
2162         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
2163
2164         * Configurations/Base.xcconfig:
2165         * Configurations/CompilerVersion.xcconfig: Added.
2166
2167 2011-04-26  Adrienne Walker  <enne@google.com>
2168
2169         Reviewed by Geoffrey Garen.
2170
2171         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
2172         https://bugs.webkit.org/show_bug.cgi?id=59469
2173
2174         * platform/chromium/TraceEvent.h:
2175         (WebCore::internal::ScopeTracer::ScopeTracer):
2176
2177 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2178
2179         Reviewed by Oliver Hunt.
2180
2181         Nixed special finalizer handling for WebCore strings
2182         https://bugs.webkit.org/show_bug.cgi?id=59425
2183
2184         Not needed anymore, since weak handles have finalizers.
2185
2186         * WebCore.exp.in: Exports!
2187
2188         * bindings/js/DOMWrapperWorld.cpp:
2189         (WebCore::JSStringOwner::finalize):
2190         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
2191         so we don't need special treatment anymore.
2192
2193         * bindings/js/DOMWrapperWorld.h:
2194         (WebCore::JSStringOwner::JSStringOwner):
2195         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
2196         instead of a WeakGCMap, so we can specify a custom finalizer.
2197
2198         * bindings/js/JSDOMBinding.cpp:
2199         (WebCore::jsStringSlowCase):
2200         * bindings/js/JSDOMBinding.h:
2201         (WebCore::jsString): Updated for string map change.
2202
2203 2011-04-26  David Kilzer  <ddkilzer@apple.com>
2204
2205         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
2206
2207         Reviewed by Antti Koivisto.
2208
2209         To enable HTTP pipelining post-SnowLeopard, use this command:
2210
2211             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
2212
2213         * platform/network/cf/ResourceRequestCFNet.cpp:
2214         (WebCore::readBooleanPreference): Re-added.  Originally added in
2215         r76756 and removed in r84120.
2216         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
2217         HTTP pipelining if use default is set to true.  Added macro
2218         guards to match those in ResourceRequestMac.mm.
2219
2220 2011-04-26  Antti Koivisto  <antti@apple.com>
2221
2222         Reviewed by Adele Peterson.
2223
2224         Don't strip fragments from file: urls in memory cache
2225         https://bugs.webkit.org/show_bug.cgi?id=59463
2226         <rdar://problem/9231130>
2227
2228         Some clients expect file: resources to be unique based on fragment identifier. 
2229         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
2230
2231         Test: fast/loader/file-protocol-fragment.html
2232
2233         * loader/cache/MemoryCache.cpp:
2234         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
2235
2236 2011-04-26  David Levin  <levin@chromium.org>
2237
2238         Reviewed by Darin Adler.
2239
2240         Fix more strict OwnPtr in WebCore (round N).
2241         https://bugs.webkit.org/show_bug.cgi?id=59464
2242
2243         * dom/Document.cpp:
2244         (WebCore::Document::Document):
2245         (WebCore::Document::attach):
2246         * fileapi/FileReader.cpp:
2247         (WebCore::FileReader::terminate):
2248         * loader/DocumentThreadableLoader.cpp:
2249         (WebCore::DocumentThreadableLoader::preflightFailure):
2250         * workers/DefaultSharedWorkerRepository.cpp:
2251         (WebCore::SharedWorkerConnectTask::create):
2252         (WebCore::SharedWorkerScriptLoader::load):
2253
2254 2011-04-26  Ruben  <chromium@hybridsource.org>
2255
2256         Reviewed by Tony Chang.
2257
2258         Change linux ifdefs for Chromium to Unix instead, allowing
2259         new Unix ports to be enabled by default
2260         https://bugs.webkit.org/show_bug.cgi?id=59297
2261
2262         No new tests, just changing preprocessor defines.
2263
2264         * bindings/js/JSInspectorFrontendHostCustom.cpp:
2265         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
2266         * dom/SelectElement.cpp:
2267         * loader/cache/CachedFont.cpp:
2268         * page/EventHandler.cpp:
2269         * page/chromium/EventHandlerChromium.cpp:
2270         * platform/Scrollbar.cpp:
2271         * platform/chromium/PlatformBridge.h:
2272         * platform/graphics/chromium/FontPlatformData.h:
2273         * platform/graphics/skia/FontCustomPlatformData.cpp:
2274         * platform/graphics/skia/FontCustomPlatformData.h:
2275
2276 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2277
2278         Reviewed by Dan Bernstein.
2279
2280         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
2281         https://bugs.webkit.org/show_bug.cgi?id=49111
2282
2283         Even when the offset corresponds to a position visually left of the box
2284         and there aren't any inline boxes on the left, the previous/next position
2285         may still correspond to some position in the same line.
2286
2287         The bug was caused by our ignoring such cases. Fixed the bug by comparing
2288         previous/next position's inline box to the current box. If they match,
2289         then we stay on the same position because moving to the left visually at
2290         the left edge should not result in a position on the same line.
2291
2292         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
2293         the left edge or to the right edge, and a bug that WebKit could not move to
2294         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
2295
2296         Test cases are added to editing/selection/move-left-right.html
2297
2298         * editing/VisiblePosition.cpp:
2299         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
2300         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
2301
2302 2011-04-26  Gabor Loki  <loki@webkit.org>
2303
2304         Reviewed by Csaba Osztrogon√°c.
2305
2306         Speeding up SVG filters with multicore (SMP) support
2307         https://bugs.webkit.org/show_bug.cgi?id=43903
2308
2309         Some SVG filters execute a huge number of pixel manipulations, which
2310         cannot be sped up by graphics accelerators, since their algorithm is
2311         too complex. Using the power of Symmetric Multi Processing (SMP) we
2312         can split up a task to smaller (data independent) tasks, which can be
2313         executed independently.
2314
2315         The ParallelJobs framework provides a simple way for distributed
2316         programming. The framework is based on WebKit's threading infrastructure,
2317         Open Multi-Processing's (OpenMP) API, and libdispatch API.
2318
2319         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
2320         * platform/graphics/filters/FETurbulence.cpp:
2321         (WebCore::FETurbulence::PaintingData::PaintingData):
2322         (WebCore::FETurbulence::noise2D):
2323         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
2324         (WebCore::FETurbulence::fillRegion):
2325         (WebCore::FETurbulence::fillRegionWorker):
2326         (WebCore::FETurbulence::apply):
2327         * platform/graphics/filters/FETurbulence.h:
2328
2329 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2330
2331         Reviewed by Yury Semikhatsky.
2332
2333         Web Inspector: close button is off in docked mode on a mac.
2334         https://bugs.webkit.org/show_bug.cgi?id=59453
2335
2336         * inspector/front-end/inspector.css:
2337         (.toolbar-item.close-left):
2338
2339 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2340
2341         Reviewed by Yury Semikhatsky.
2342
2343         Web Inspector: New Style is not working (UI glitch)
2344         https://bugs.webkit.org/show_bug.cgi?id=59451
2345
2346         * inspector/InspectorDOMStorageAgent.cpp:
2347         (WebCore::InspectorDOMStorageAgent::setFrontend):
2348         * inspector/front-end/AuditRules.js:
2349         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
2350         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
2351         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
2352         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
2353         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
2354         * inspector/front-end/CSSStyleModel.js:
2355         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
2356         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
2357         (WebInspector.CSSStyleModel.prototype.addRule):
2358         (WebInspector.CSSStyleModel.prototype.addRule.callback):
2359         (WebInspector.CSSStyleModel.prototype._documentElementId):
2360         * inspector/front-end/DOMAgent.js:
2361         (WebInspector.DOMNode.prototype._addAttribute):
2362         (WebInspector.DOMNode.prototype.documentElement):
2363         * inspector/front-end/ResourceTreeModel.js:
2364         (WebInspector.PageDispatcher.prototype.frameDetached):
2365         * inspector/front-end/StylesSidebarPane.js:
2366         (WebInspector.StylesSidebarPane.prototype._createNewRule):
2367
2368 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2369
2370         Reviewed by Yury Semikhatsky.
2371
2372         Web Inspector: introduce DOMStorage::enable and disable.
2373         https://bugs.webkit.org/show_bug.cgi?id=59445
2374
2375         * inspector/Inspector.json:
2376         * inspector/InspectorAgent.cpp:
2377         (WebCore::InspectorAgent::InspectorAgent):
2378         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2379         * inspector/InspectorDOMStorageAgent.cpp:
2380         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2381         (WebCore::InspectorDOMStorageAgent::restore):
2382         (WebCore::InspectorDOMStorageAgent::enable):
2383         (WebCore::InspectorDOMStorageAgent::disable):
2384         * inspector/InspectorDOMStorageAgent.h:
2385         (WebCore::InspectorDOMStorageAgent::create):
2386         * inspector/front-end/DOMStorage.js:
2387         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2388         * inspector/front-end/ResourcesPanel.js:
2389         (WebInspector.ResourcesPanel.prototype._reset):
2390         * inspector/front-end/inspector.js:
2391
2392 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2393
2394         Reviewed by Yury Semikhatsky.
2395
2396         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
2397         https://bugs.webkit.org/show_bug.cgi?id=59440
2398
2399         * inspector/Inspector.json:
2400         * inspector/InspectorAgent.cpp:
2401         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2402         * inspector/InspectorPageAgent.cpp:
2403         (WebCore::InspectorPageAgent::setFrontend):
2404         (WebCore::InspectorPageAgent::frameNavigated):
2405         * inspector/InspectorPageAgent.h:
2406         * inspector/front-end/AuditsPanel.js:
2407         (WebInspector.AuditsPanel):
2408         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
2409         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
2410         * inspector/front-end/CSSStyleModel.js:
2411         (WebInspector.CSSStyleModelResourceBinding):
2412         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
2413         * inspector/front-end/DOMBreakpointsSidebarPane.js:
2414         (WebInspector.DOMBreakpointsSidebarPane):
2415         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
2416         * inspector/front-end/DOMStorage.js:
2417         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2418         * inspector/front-end/ExtensionServer.js:
2419         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
2420         (WebInspector.ExtensionServer.prototype.initExtensions):
2421         * inspector/front-end/NetworkPanel.js:
2422         (WebInspector.NetworkPanel):
2423         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
2424         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
2425         (WebInspector.NetworkPanel.prototype._frameNavigated):
2426         * inspector/front-end/ResourceTreeModel.js:
2427         (WebInspector.ResourceTreeModel):
2428         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2429         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
2430         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2431         (WebInspector.ResourceTreeModel.prototype._frameDetached):
2432         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
2433         (WebInspector.PageDispatcher):
2434         (WebInspector.PageDispatcher.prototype.domContentEventFired):
2435         (WebInspector.PageDispatcher.prototype.loadEventFired):
2436         (WebInspector.PageDispatcher.prototype.frameNavigated):
2437         (WebInspector.PageDispatcher.prototype.frameDetached):
2438         * inspector/front-end/ResourcesPanel.js:
2439         (WebInspector.ResourcesPanel):
2440         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
2441         (WebInspector.ResourcesPanel.prototype._frameNavigated):
2442         * inspector/front-end/inspector.js:
2443
2444 2011-04-26  Csaba Osztrogon√°c  <ossy@webkit.org>
2445
2446         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
2447         because it broke transitions/multiple-text-shadow-transition.html
2448
2449         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2450         https://bugs.webkit.org/show_bug.cgi?id=59377
2451
2452         * css/CSSStyleSelector.cpp:
2453         (WebCore::CSSStyleSelector::applyProperty):
2454         * page/animation/AnimationBase.cpp:
2455         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2456         (WebCore::PropertyWrapperShadow::blend):
2457         * rendering/style/RenderStyle.cpp:
2458         (WebCore::RenderStyle::setTextShadow):
2459         (WebCore::RenderStyle::setBoxShadow):
2460         * rendering/style/RenderStyle.h:
2461         (WebCore::InheritedFlags::textShadow):
2462         * rendering/style/StyleRareInheritedData.cpp:
2463         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2464         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2465         * rendering/style/StyleRareInheritedData.h:
2466         * rendering/style/StyleRareNonInheritedData.cpp:
2467         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2468
2469 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2470
2471         Reviewed by Adam Barth.
2472
2473         Turn off make built-in implicit rules for derived sources makefile
2474         https://bugs.webkit.org/show_bug.cgi?id=59418
2475
2476         We don't use any of make's built-in implicit rules, turning them off
2477         speeds up parsing of the makefile.
2478
2479         * WebCore.xcodeproj/project.pbxproj:
2480         * gyp/generate-derived-sources.sh:
2481
2482 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
2483
2484         Reviewed by Nikolas Zimmermann.
2485
2486         ASSERT failure in SVGUseElement
2487         https://bugs.webkit.org/show_bug.cgi?id=59313
2488
2489         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
2490         was wrong because the document may not be well-formed.
2491
2492         This patch asserts the element is not pending on resource or the
2493         document is not well-formed.
2494
2495         Test: svg/custom/use-crash-in-non-wellformed-document.svg
2496
2497         * svg/SVGUseElement.cpp:
2498         (WebCore::isWellFormedDocument):
2499         (WebCore::SVGUseElement::insertedIntoDocument):
2500
2501 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
2502
2503         Reviewed by Pavel Feldman.
2504
2505         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
2506         https://bugs.webkit.org/show_bug.cgi?id=59438
2507
2508         * inspector/front-end/DetailedHeapshotView.js:
2509         (WebInspector.DetailedHeapshotView.prototype._changeView):
2510
2511 2011-04-26  David Levin  <levin@chromium.org>
2512
2513         Reviewed by Adam Barth.
2514
2515         Fix a few OwnPtr strict errors in WebCore headers.
2516         https://bugs.webkit.org/show_bug.cgi?id=59431
2517
2518         * bindings/js/ScheduledAction.cpp:
2519         (WebCore::ScheduledAction::create):
2520         * css/MediaQueryMatcher.cpp:
2521         (WebCore::MediaQueryMatcher::prepareEvaluator):
2522         * dom/NodeRareData.h:
2523         (WebCore::NodeListsNodeData::create):
2524         * dom/ScriptRunner.h:
2525         (WebCore::ScriptRunner::create):
2526         * inspector/WorkerInspectorController.cpp:
2527         (WebCore::WorkerInspectorController::connectFrontend):
2528         * loader/icon/IconDatabase.h:
2529         (WebCore::IconDatabase::create):
2530         * platform/graphics/SimpleFontData.cpp:
2531         (WebCore::SimpleFontData::verticalRightOrientationFontData):
2532         (WebCore::SimpleFontData::uprightOrientationFontData):
2533         (WebCore::SimpleFontData::brokenIdeographFontData):
2534         * rendering/style/StyleRareInheritedData.cpp:
2535         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2536         * rendering/svg/SVGResources.h:
2537         (WebCore::SVGResources::ClipperFilterMaskerData::create):
2538         (WebCore::SVGResources::MarkerData::create):
2539         (WebCore::SVGResources::FillStrokeData::create):
2540         * storage/StorageSyncManager.cpp:
2541         (WebCore::StorageSyncManager::close):
2542         * workers/WorkerContext.cpp:
2543         (WebCore::CloseWorkerContextTask::create):
2544         * workers/WorkerMessagingProxy.cpp:
2545         (WebCore::MessageWorkerContextTask::create):
2546         (WebCore::MessageWorkerTask::create):
2547         (WebCore::WorkerExceptionTask::create):
2548         (WebCore::WorkerContextDestroyedTask::create):
2549         (WebCore::WorkerTerminateTask::create):
2550         (WebCore::WorkerThreadActivityReportTask::create):
2551         * workers/WorkerRunLoop.cpp:
2552         (WebCore::WorkerRunLoop::Task::create):
2553         * workers/WorkerThread.cpp:
2554         (WebCore::WorkerThreadStartupData::create):
2555         (WebCore::WorkerThreadShutdownFinishTask::create):
2556         (WebCore::WorkerThreadShutdownStartTask::create):
2557
2558 2011-04-26  Adam Klein  <adamk@chromium.org>
2559
2560         Reviewed by Adam Barth.
2561
2562         Fix last strict OwnPtr violation under svg/...
2563         https://bugs.webkit.org/show_bug.cgi?id=59429
2564
2565         * svg/SVGDocumentExtensions.cpp:
2566         (WebCore::SVGDocumentExtensions::removePendingResource):
2567
2568 2011-04-26  Adam Barth  <abarth@webkit.org>
2569
2570         Reviewed by David Levin.
2571
2572         Fix more strict OwnPtr violations in WebCore
2573         https://bugs.webkit.org/show_bug.cgi?id=59433
2574
2575         These manifest in the Chromium build.
2576
2577         * bindings/v8/ScriptController.cpp:
2578         (WebCore::ScriptController::ScriptController):
2579         * bindings/v8/ScriptDebugServer.cpp:
2580         (WebCore::ScriptDebugServer::editScriptSource):
2581         * bindings/v8/V8DOMMap.cpp:
2582         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
2583         * bindings/v8/V8Proxy.cpp:
2584         (WebCore::V8Proxy::precompileScript):
2585         * bindings/v8/WorkerScriptController.cpp:
2586         (WebCore::WorkerScriptController::WorkerScriptController):
2587         * page/Page.cpp:
2588         (WebCore::Page::Page):
2589         (WebCore::Page::speechInput):
2590         * platform/PlatformGestureRecognizer.cpp:
2591         (WebCore::PlatformGestureRecognizer::create):
2592         * platform/PlatformGestureRecognizer.h:
2593         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2594         (WebCore::DrawingBuffer::DrawingBuffer):
2595         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2596         (WebCore::CCLayerImpl::CCLayerImpl):
2597         * platform/graphics/gpu/Texture.cpp:
2598         (WebCore::Texture::create):
2599         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
2600         (WebCore::BMPImageDecoder::decodeHelper):
2601         * platform/image-decoders/gif/GIFImageDecoder.cpp:
2602         (WebCore::GIFImageDecoder::decode):
2603         * platform/image-decoders/ico/ICOImageDecoder.cpp:
2604         (WebCore::ICOImageDecoder::decodeAtIndex):
2605         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
2606         (WebCore::JPEGImageDecoder::decode):
2607         * platform/image-decoders/png/PNGImageDecoder.cpp:
2608         (WebCore::PNGImageDecoder::decode):
2609         * storage/chromium/DatabaseTrackerChromium.cpp:
2610         (WebCore::DatabaseTracker::addOpenDatabase):
2611
2612 2011-04-25  David Levin  <levin@chromium.org>
2613
2614         Reviewed by Adam Barth.
2615
2616         Fix OwnPtr strict errors in CrossThreadTask.h
2617         https://bugs.webkit.org/show_bug.cgi?id=59427
2618
2619         * dom/CrossThreadTask.h:
2620         (WebCore::CrossThreadTask1::create):
2621         (WebCore::CrossThreadTask2::create):
2622         (WebCore::CrossThreadTask3::create):
2623         (WebCore::CrossThreadTask4::create):
2624         (WebCore::CrossThreadTask5::create):
2625         (WebCore::CrossThreadTask6::create):
2626         (WebCore::CrossThreadTask7::create):
2627         (WebCore::CrossThreadTask8::create):
2628
2629 2011-04-25  Mark Rowe  <mrowe@apple.com>
2630
2631         Reviewed by Dan Bernstein.
2632
2633         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
2634
2635         * css/CSSStyleApplyProperty.cpp:
2636         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
2637         * css/CSSStyleApplyProperty.h:
2638         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
2639
2640 2011-04-25  Levi Weintraub  <leviw@chromium.org>
2641
2642         Reviewed by Ryosuke Niwa.
2643
2644         REGRESSION: a character appears after tab span when typing immediately before the tab span
2645         https://bugs.webkit.org/show_bug.cgi?id=58132
2646
2647         Correcting the order of operations we use to avoid inserting into invalid positions in
2648         ReplaceSelectionCommand to avoid inserting into tab-spans.
2649
2650         Test: editing/pasteboard/paste-before-tab-span.html
2651
2652         * editing/ReplaceSelectionCommand.cpp:
2653         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
2654         positionAvoidingPrecedingNodes, since that function could once again put our position
2655         inside a tab span.
2656
2657 2011-04-25  David Levin  <levin@chromium.org>
2658
2659         Reviewed by Adam Barth.
2660
2661         Fix OwnPtr strict error in ImageBuffer.h
2662         https://bugs.webkit.org/show_bug.cgi?id=59422
2663
2664         * platform/graphics/ImageBuffer.h:
2665         (WebCore::ImageBuffer::create):
2666
2667 2011-04-25  Adam Barth  <abarth@webkit.org>
2668
2669         Reviewed by David Levin.
2670
2671         Fix strict OwnPtr violations and whitelist known-tricky files
2672         https://bugs.webkit.org/show_bug.cgi?id=59421
2673
2674         With this patch, WebCore builds cleanly with strict OwnPtrs.
2675
2676         * dom/MessagePort.cpp:
2677         (WebCore::MessagePort::MessagePort):
2678         * dom/XMLDocumentParserLibxml2.cpp:
2679         * page/ContextMenuController.cpp:
2680         (WebCore::ContextMenuController::ContextMenuController):
2681         (WebCore::ContextMenuController::clearContextMenu):
2682         * page/PluginHalter.cpp:
2683         * platform/graphics/MediaPlayer.cpp:
2684         * platform/network/ResourceRequestBase.cpp:
2685         (WebCore::ResourceRequestBase::adopt):
2686         (WebCore::ResourceRequestBase::copyData):
2687         * svg/SVGDocumentExtensions.cpp:
2688
2689 2011-04-25  David Levin  <levin@chromium.org>
2690
2691         Reviewed by Adam Barth.
2692
2693         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
2694         https://bugs.webkit.org/show_bug.cgi?id=59419
2695
2696         * dom/DatasetDOMStringMap.h:
2697         (WebCore::DatasetDOMStringMap::create):
2698
2699 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2700
2701         Reviewed by Eric Seidel.
2702
2703         KeyboardEvent.cpp should work with strict OwnPtrs.
2704         https://bugs.webkit.org/show_bug.cgi?id=59403
2705
2706         * dom/KeyboardEvent.cpp:
2707         (WebCore::KeyboardEvent::KeyboardEvent):
2708
2709 2011-04-25  James Robinson  <jamesr@chromium.org>
2710
2711         Reviewed by Eric Seidel.
2712
2713         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2714         https://bugs.webkit.org/show_bug.cgi?id=59377
2715
2716         * css/CSSStyleSelector.cpp:
2717         (WebCore::CSSStyleSelector::applyProperty):
2718         * page/animation/AnimationBase.cpp:
2719         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2720         (WebCore::PropertyWrapperShadow::blend):
2721         * rendering/style/RenderStyle.cpp:
2722         (WebCore::RenderStyle::setTextShadow):
2723         (WebCore::RenderStyle::setBoxShadow):
2724         * rendering/style/RenderStyle.h:
2725         (WebCore::InheritedFlags::textShadow):
2726         * rendering/style/StyleRareInheritedData.cpp:
2727         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2728         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2729         * rendering/style/StyleRareInheritedData.h:
2730         * rendering/style/StyleRareNonInheritedData.cpp:
2731         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2732
2733 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2734
2735         Unreviewed, rolling out r84864.
2736         http://trac.webkit.org/changeset/84864
2737         https://bugs.webkit.org/show_bug.cgi?id=59413
2738
2739         Expect result of use-crash-in-non-wellformed-document.svg is
2740         platform dependent (Requested by leoyang on #webkit).
2741
2742         * svg/SVGUseElement.cpp:
2743         (WebCore::SVGUseElement::insertedIntoDocument):
2744
2745 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
2746
2747         Reviewed by Nikolas Zimmermann.
2748
2749         ASSERT failure in SVGUseElement
2750         https://bugs.webkit.org/show_bug.cgi?id=59313
2751
2752         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
2753         was wrong because the document may not be well-formed.
2754
2755         This patch asserts the element is not pending on resource or the
2756         document is not well-formed.
2757
2758         Test: svg/custom/use-crash-in-non-wellformed-document.svg
2759
2760         * svg/SVGUseElement.cpp:
2761         (WebCore::isWellFormedDocument):
2762         (WebCore::SVGUseElement::insertedIntoDocument):
2763
2764 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
2765
2766         Reviewed by Tony Chang.
2767
2768         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
2769         https://bugs.webkit.org/show_bug.cgi?id=59028
2770
2771         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
2772         Moving the code for base class we can reduce the efforts to support DataTransferItems
2773         element in different platforms.
2774
2775         * Android.mk:
2776         * CMakeLists.txt:
2777         * GNUmakefile.list.am:
2778         * WebCore.gypi:
2779         * WebCore.pro:
2780         * WebCore.vcproj/WebCore.vcproj:
2781         * WebCore.xcodeproj/project.pbxproj:
2782         * dom/DataTransferItem.cpp:
2783         (WebCore::DataTransferItem::DataTransferItem):
2784         (WebCore::DataTransferItem::owner):
2785         (WebCore::DataTransferItem::kind):
2786         (WebCore::DataTransferItem::type):
2787         * dom/DataTransferItem.h:
2788         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
2789         (WebCore::DataTransferItems::DataTransferItems):
2790         (WebCore::DataTransferItems::length):
2791         (WebCore::DataTransferItems::item):
2792         (WebCore::DataTransferItems::deleteItem):
2793         (WebCore::DataTransferItems::clear):
2794         (WebCore::DataTransferItems::add):
2795         * dom/DataTransferItems.h:
2796         * platform/chromium/DataTransferItemChromium.cpp:
2797         (WebCore::DataTransferItem::create):
2798         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
2799         (WebCore::DataTransferItemChromium::getAsString):
2800         (WebCore::DataTransferItemChromium::getAsFile):
2801         * platform/chromium/DataTransferItemChromium.h:
2802         * platform/chromium/DataTransferItemsChromium.cpp:
2803         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
2804         * platform/chromium/DataTransferItemsChromium.h:
2805
2806 2011-04-25  Chris Marrin  <cmarrin@apple.com>
2807
2808         Reviewed by Simon Fraser.
2809
2810         REGRESSION(75137): directly composited images are double-drawn sometimes
2811         https://bugs.webkit.org/show_bug.cgi?id=58632
2812
2813         Depending on the order of operations (layout, creating compositing 
2814         layers and creating simple image layers) a layer can have both image
2815         content and have m_drawsContent=true. In this case 2 copies of the image
2816         are drawn in the layer. If the image has alpha, it looks wrong.
2817
2818         I added an updateDrawsContent() call after setting the image contents
2819         to make sure it's correct.
2820
2821         I couldn't create a test case that shows the problem because layerTreeAsText()
2822         doesn't emit enough info to show this level of detail. I've opened
2823         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
2824
2825         * rendering/RenderLayerBacking.cpp:
2826         (WebCore::RenderLayerBacking::updateImageContents):
2827
2828 2011-04-25  Kenneth Russell  <kbr@google.com>
2829
2830         Reviewed by David Levin.
2831
2832         Fix OwnPtr strict errors in InlineFlowBox.cpp
2833         https://bugs.webkit.org/show_bug.cgi?id=59392
2834
2835         * rendering/InlineFlowBox.cpp:
2836         (WebCore::InlineFlowBox::setLayoutOverflow):
2837         (WebCore::InlineFlowBox::setVisualOverflow):
2838
2839 2011-04-25  Kenneth Russell  <kbr@google.com>
2840
2841         Reviewed by David Levin.
2842
2843         Fix OwnPtr strict errors in TransformState.cpp
2844         https://bugs.webkit.org/show_bug.cgi?id=59380
2845
2846         * rendering/TransformState.cpp:
2847         (WebCore::TransformState::applyTransform):
2848
2849 2011-04-25  Adam Barth  <abarth@webkit.org>
2850
2851         Reviewed by James Robinson.
2852
2853         DOMWindow.cpp should work with strict OwnPtrs
2854         https://bugs.webkit.org/show_bug.cgi?id=59356
2855
2856         * page/DOMWindow.cpp:
2857         (WebCore::PostMessageTimer::fired):
2858         (WebCore::DOMWindow::postMessageTimerFired):
2859         * page/DOMWindow.h:
2860
2861 2011-04-25  Adam Klein  <adamk@chromium.org>
2862
2863         Reviewed by James Robinson.
2864
2865         Fix OwnPtr strict errors in some SVG classes.
2866         https://bugs.webkit.org/show_bug.cgi?id=59395
2867
2868         * rendering/style/SVGRenderStyleDefs.cpp:
2869         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
2870         * svg/SVGSVGElement.cpp:
2871         (WebCore::SVGSVGElement::SVGSVGElement):
2872         * svg/SVGStyledTransformableElement.cpp:
2873         (WebCore::SVGStyledTransformableElement::supplementalTransform):
2874         * svg/SVGTextElement.cpp:
2875         (WebCore::SVGTextElement::supplementalTransform):
2876         * svg/graphics/SVGImage.cpp:
2877         (WebCore::SVGImage::dataChanged):
2878
2879 2011-04-25  Adam Barth  <abarth@webkit.org>
2880
2881         Re-land changes to ValidationMessage.
2882
2883         * html/ValidationMessage.cpp:
2884         (WebCore::ValidationMessage::setMessage):
2885         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
2886         (WebCore::ValidationMessage::requestToHideMessage):
2887
2888 2011-04-25  Ojan Vafai  <ojan@chromium.org>
2889
2890         Reviewed by James Robinson.
2891
2892         fix OwnPtr strict error in FrameView.cpp
2893         https://bugs.webkit.org/show_bug.cgi?id=59402
2894
2895         * page/FrameView.cpp:
2896         (WebCore::FrameView::FrameView):
2897         (WebCore::FrameView::addWidgetToUpdate):
2898
2899 2011-04-25  Adam Klein  <adamk@chromium.org>
2900
2901         Unreviewed, rolling out r84844.
2902         http://trac.webkit.org/changeset/84844
2903         https://bugs.webkit.org/show_bug.cgi?id=59395
2904
2905         Checked in too much.
2906
2907         * rendering/style/SVGRenderStyleDefs.cpp:
2908         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
2909         * svg/SVGDocumentExtensions.cpp:
2910         (WebCore::SVGDocumentExtensions::removePendingResource):
2911         * svg/SVGSVGElement.cpp:
2912         (WebCore::SVGSVGElement::SVGSVGElement):
2913         * svg/SVGStyledTransformableElement.cpp:
2914         (WebCore::SVGStyledTransformableElement::supplementalTransform):
2915         * svg/SVGTextElement.cpp:
2916         (WebCore::SVGTextElement::supplementalTransform):
2917         * svg/graphics/SVGImage.cpp:
2918         (WebCore::SVGImage::dataChanged):
2919
2920 2011-04-25  Adrienne Walker  <enne@google.com>
2921
2922         Reviewed by David Levin.
2923
2924         Make ActiveDOMCallback play nice with OwnPtr strict mode
2925         https://bugs.webkit.org/show_bug.cgi?id=59398
2926
2927         * bindings/generic/ActiveDOMCallback.cpp:
2928         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
2929
2930 2011-04-25  Adam Klein  <adamk@chromium.org>
2931
2932         Reviewed by James Robinson.
2933
2934         Fix OwnPtr strict errors in some SVG classes.
2935         https://bugs.webkit.org/show_bug.cgi?id=59395
2936
2937         * rendering/style/SVGRenderStyleDefs.cpp:
2938         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
2939         * svg/SVGSVGElement.cpp:
2940         (WebCore::SVGSVGElement::SVGSVGElement):
2941         * svg/SVGStyledTransformableElement.cpp:
2942         (WebCore::SVGStyledTransformableElement::supplementalTransform):
2943         * svg/SVGTextElement.cpp:
2944         (WebCore::SVGTextElement::supplementalTransform):
2945         * svg/graphics/SVGImage.cpp:
2946         (WebCore::SVGImage::dataChanged):
2947
2948 2011-04-25  James Robinson  <jamesr@chromium.org>
2949
2950         Unreviewed, rolling out r84835.
2951         http://trac.webkit.org/changeset/84835
2952         https://bugs.webkit.org/show_bug.cgi?id=59394
2953
2954         Breaks compile because Deque<OwnPtr> doesn't work
2955
2956         * dom/XMLDocumentParserLibxml2.cpp:
2957         (WebCore::PendingCallbacks::~PendingCallbacks):
2958         (WebCore::PendingCallbacks::appendStartElementNSCallback):
2959         (WebCore::PendingCallbacks::appendEndElementNSCallback):
2960         (WebCore::PendingCallbacks::appendCharactersCallback):
2961         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
2962         (WebCore::PendingCallbacks::appendCDATABlockCallback):
2963         (WebCore::PendingCallbacks::appendCommentCallback):
2964         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
2965         (WebCore::PendingCallbacks::appendErrorCallback):
2966         (WebCore::XMLDocumentParser::XMLDocumentParser):
2967         * html/ValidationMessage.cpp:
2968         (WebCore::ValidationMessage::setMessage):
2969         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
2970         (WebCore::ValidationMessage::requestToHideMessage):
2971
2972 2011-04-25  James Robinson  <jamesr@chromium.org>
2973
2974         Reviewed by Sam Weinig.
2975
2976         Fix OwnPtr strict mode violation in ImageBufferCG
2977         https://bugs.webkit.org/show_bug.cgi?id=59396
2978
2979         * platform/graphics/cg/ImageBufferCG.cpp:
2980         (WebCore::ImageBuffer::ImageBuffer):
2981
2982 2011-04-25  Huang Dongsung  <luxtella@company100.net>
2983
2984         Reviewed by Dirk Schulze.
2985
2986         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
2987         https://bugs.webkit.org/show_bug.cgi?id=59308
2988
2989         An unused local variable is created and even allocates heap memory.
2990
2991         * platform/graphics/skia/PlatformContextSkia.cpp:
2992         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
2993
2994 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2995
2996         Qt build fix: Updated files not used by other ports for rename.
2997
2998         * bindings/js/JSTouchCustom.cpp:
2999         (WebCore::toJSNewlyCreated):
3000         * bindings/js/JSTouchListCustom.cpp:
3001         (WebCore::toJSNewlyCreated):
3002
3003 2011-04-25  Adrienne Walker  <enne@google.com>
3004
3005         Reviewed by David Levin.
3006
3007         WebCore/css/CSS* files should play nice with strict OwnPtrs
3008         https://bugs.webkit.org/show_bug.cgi?id=59382
3009
3010         * css/CSSFontFaceSource.cpp:
3011         (WebCore::CSSFontFaceSource::getFontData):
3012         * css/CSSParser.cpp:
3013         (WebCore::CSSParser::addProperty):
3014         (WebCore::CSSParser::parseValue):
3015
3016 2011-04-25  Adam Barth  <abarth@webkit.org>
3017
3018         Reviewed by James Robinson.
3019
3020         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
3021         https://bugs.webkit.org/show_bug.cgi?id=59394
3022
3023         * dom/XMLDocumentParserLibxml2.cpp:
3024         (WebCore::PendingCallbacks::PendingCallbacks):
3025         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3026         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3027         (WebCore::PendingCallbacks::appendCharactersCallback):
3028         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3029         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3030         (WebCore::PendingCallbacks::appendCommentCallback):
3031         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3032         (WebCore::PendingCallbacks::appendErrorCallback):
3033         (WebCore::XMLDocumentParser::XMLDocumentParser):
3034         * html/ValidationMessage.cpp:
3035         (WebCore::ValidationMessage::setMessage):
3036         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3037         (WebCore::ValidationMessage::requestToHideMessage):
3038
3039 2011-04-25  James Robinson  <jamesr@chromium.org>
3040
3041         Reviewed by Adam Barth.
3042
3043         Fix OwnPtr strictness issues in WebCore/inspector/
3044         https://bugs.webkit.org/show_bug.cgi?id=59387
3045
3046         * inspector/InspectorAgent.cpp:
3047         (WebCore::InspectorAgent::InspectorAgent):
3048         * inspector/InspectorController.cpp:
3049         (WebCore::InspectorController::InspectorController):
3050         * inspector/InspectorStyleSheet.cpp:
3051         (WebCore::InspectorStyleSheet::ensureSourceData):
3052
3053 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3054
3055         Reviewed by Beth Dakin.
3056
3057         Removed XPathNamespace because it was unused
3058         https://bugs.webkit.org/show_bug.cgi?id=59381
3059         
3060         This allows us to make Node::ownerDocument() non-virtual, though it has
3061         the unhappy side-effect of rebuilding the world.
3062
3063         * CMakeLists.txt:
3064         * GNUmakefile.list.am:
3065         * WebCore.gypi:
3066         * WebCore.pro:
3067         * WebCore.vcproj/WebCore.vcproj:
3068         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
3069
3070         * dom/Node.h: Hello fast code!
3071
3072         * xml/XPathNamespace.cpp: Removed.
3073         * xml/XPathNamespace.h: Removed.
3074
3075 2011-04-25  Adam Barth  <abarth@webkit.org>
3076
3077         Reviewed by Darin Adler.
3078
3079         HistoryItemMac should play nice with OwnPtrs
3080         https://bugs.webkit.org/show_bug.cgi?id=59388
3081
3082         * history/mac/HistoryItemMac.mm:
3083         (WebCore::HistoryItem::setTransientProperty):
3084
3085 2011-04-25  David Levin  <levin@chromium.org>
3086
3087         Reviewed by Kenneth Russell.
3088
3089         Fix strict OwnPtrs in ContextMenuController.cpp
3090         https://bugs.webkit.org/show_bug.cgi?id=59375
3091
3092         * page/ContextMenuController.cpp:
3093         (WebCore::ContextMenuController::createContextMenu):
3094         (WebCore::separatorItem):
3095
3096 2011-04-25  Adam Barth  <abarth@webkit.org>
3097
3098         Reviewed by Darin Adler.
3099
3100         CheckedRadioButton should play nice with strict OwnPtr
3101         https://bugs.webkit.org/show_bug.cgi?id=59386
3102
3103         * dom/CheckedRadioButtons.cpp:
3104         (WebCore::CheckedRadioButtons::addButton):
3105
3106 2011-04-25  Adam Barth  <abarth@webkit.org>
3107
3108         Reviewed by David Levin.
3109
3110         Resource*.cpp should play nice with strict OwnPtrs
3111         https://bugs.webkit.org/show_bug.cgi?id=59383
3112
3113         * bridge/runtime_method.cpp:
3114         (JSC::RuntimeMethod::RuntimeMethod):
3115         * platform/network/ResourceHandle.cpp:
3116         (WebCore::ResourceHandle::ResourceHandle):
3117         * platform/network/ResourceResponseBase.cpp:
3118         (WebCore::ResourceResponseBase::adopt):
3119         (WebCore::ResourceResponseBase::copyData):
3120
3121 2011-04-25  Adam Barth  <abarth@webkit.org>
3122
3123         Reviewed by David Levin.
3124
3125         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
3126         https://bugs.webkit.org/show_bug.cgi?id=59374
3127
3128         * bridge/objc/objc_runtime.mm:
3129         (JSC::Bindings::callObjCFallbackObject):
3130         * page/Page.cpp:
3131         (WebCore::Page::Page):
3132         (WebCore::Page::initGroup):
3133         * page/PageGroup.cpp:
3134         (WebCore::PageGroup::addUserScriptToWorld):
3135         (WebCore::PageGroup::addUserStyleSheetToWorld):
3136         * page/mac/PageMac.cpp:
3137         (WebCore::Page::addSchedulePair):
3138
3139 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3140
3141         Build fix: This time for sure!
3142         
3143         * dom/make_names.pl:
3144
3145 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3146
3147         Build fix: Let's edit the script instead of the autogenrated file. That
3148         way, our change will stand the test of time.
3149
3150         * dom/make_names.pl:
3151
3152 2011-04-25  Adam Barth  <abarth@webkit.org>
3153
3154         Reviewed by David Levin.
3155
3156         Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
3157         https://bugs.webkit.org/show_bug.cgi?id=59368
3158
3159         * html/HTMLMediaElement.cpp:
3160         (WebCore::HTMLMediaElement::HTMLMediaElement):
3161         * platform/network/HTTPHeaderMap.cpp:
3162         (WebCore::HTTPHeaderMap::copyData):
3163
3164 2011-04-25  James Robinson  <jamesr@chromium.org>
3165
3166         Reviewed by Adam Barth.
3167
3168         Fix strict OwnPtr violations in Render*.cpp
3169         https://bugs.webkit.org/show_bug.cgi?id=59361
3170
3171         * rendering/RenderBlock.cpp:
3172         (WebCore::RenderBlock::RenderBlock):
3173         (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
3174         * rendering/RenderBox.cpp:
3175         (WebCore::RenderBox::addLayoutOverflow):
3176         (WebCore::RenderBox::addVisualOverflow):
3177         * rendering/RenderButton.cpp:
3178         (WebCore::RenderButton::styleDidChange):
3179         * rendering/RenderLayer.cpp:
3180         (WebCore::RenderLayer::updateTransform):
3181         (WebCore::RenderLayer::paintChildLayerIntoColumns):
3182         (WebCore::RenderLayer::hitTestChildLayerColumns):
3183         (WebCore::RenderLayer::ensureBacking):
3184         * rendering/RenderTable.cpp:
3185         (WebCore::RenderTable::styleDidChange):
3186         * rendering/RenderView.cpp:
3187         (WebCore::RenderView::compositor):
3188         * rendering/style/RenderStyle.cpp:
3189         (WebCore::RenderStyle::addCachedPseudoStyle):
3190         (WebCore::RenderStyle::accessCounterDirectives):
3191         (WebCore::RenderStyle::accessAnimations):
3192         (WebCore::RenderStyle::accessTransitions):
3193         * rendering/svg/RenderSVGResourceFilter.cpp:
3194         (WebCore::RenderSVGResourceFilter::applyResource):
3195         * rendering/svg/SVGResources.cpp:
3196         (WebCore::SVGResources::SVGResources):
3197
3198 2011-04-25  Adam Barth  <abarth@webkit.org>
3199
3200         Attempt to fix the compile.
3201
3202         * platform/graphics/MediaPlayer.cpp:
3203         (WebCore::MediaPlayer::loadWithNextMediaEngine):
3204
3205 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3206
3207         Rubber-stamped by Beth Dakin.
3208
3209         Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into 
3210         CREATE_DOM_WRAPPER because there's no meaningful difference between
3211         them anymore.
3212
3213         * bindings/js/JSCDATASectionCustom.cpp:
3214         (WebCore::toJSNewlyCreated):
3215         * bindings/js/JSCSSRuleCustom.cpp:
3216         (WebCore::toJS):
3217         * bindings/js/JSCSSValueCustom.cpp:
3218         (WebCore::toJS):
3219         * bindings/js/JSDOMBinding.h:
3220         * bindings/js/JSDocumentCustom.cpp:
3221         (WebCore::toJS):
3222         * bindings/js/JSElementCustom.cpp:
3223         (WebCore::toJSNewlyCreated):
3224         * bindings/js/JSEventCustom.cpp:
3225         (WebCore::toJS):
3226         * bindings/js/JSHTMLCollectionCustom.cpp:
3227         (WebCore::toJS):
3228         * bindings/js/JSImageDataCustom.cpp:
3229         (WebCore::toJS):
3230         * bindings/js/JSNodeCustom.cpp:
3231         (WebCore::createWrapperInline):
3232         * bindings/js/JSSVGPathSegCustom.cpp:
3233         (WebCore::toJS):
3234         * bindings/js/JSStyleSheetCustom.cpp:
3235         (WebCore::toJS):
3236         * bindings/js/JSTextCustom.cpp:
3237         (WebCore::toJSNewlyCreated):
3238         * bindings/js/JSWebKitCSSMatrixCustom.cpp:
3239         (WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
3240         * bindings/js/JSWebSocketCustom.cpp:
3241         (WebCore::JSWebSocketConstructor::constructJSWebSocket):
3242         * bindings/js/JSXMLHttpRequestCustom.cpp:
3243         (WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
3244         * bindings/js/JSXSLTProcessorCustom.cpp:
3245         (WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
3246
3247 2011-04-25  Adam Barth  <abarth@webkit.org>
3248
3249         Reviewed by James Robinson.
3250
3251         HTMLDocumentParser should play nice with OwnPtrs
3252         https://bugs.webkit.org/show_bug.cgi?id=59363
3253
3254         * html/parser/HTMLDocumentParser.cpp:
3255         (WebCore::HTMLDocumentParser::pumpTokenizer):
3256
3257 2011-04-25  Adam Barth  <abarth@webkit.org>
3258
3259         Reviewed by James Robinson.
3260
3261         Frame.cpp should work with strict OwnPtrs
3262         https://bugs.webkit.org/show_bug.cgi?id=59360
3263
3264         * page/Frame.cpp:
3265         (WebCore::createRegExpForLabels):
3266
3267 2011-04-25  Adam Barth  <abarth@webkit.org>
3268
3269         Reviewed by David Levin.
3270
3271         Fix strict OwnPtr in Element.cpp
3272         https://bugs.webkit.org/show_bug.cgi?id=59357
3273
3274         * dom/NodeRareData.h:
3275         (WebCore::NodeRareData::ensureEventTargetData):
3276
3277 2011-04-25  Adam Barth  <abarth@webkit.org>
3278
3279         Reviewed by David Levin.
3280
3281         Fix strict OwnPtr issues in Media*.cpp
3282         https://bugs.webkit.org/show_bug.cgi?id=59354
3283
3284         There's still a tricky case in MediaPlayer.cpp, but we'll worry about
3285         that later.
3286
3287         * css/MediaQueryMatcher.cpp:
3288         (WebCore::MediaQueryMatcher::addListener):
3289         * dom/Document.cpp:
3290         * platform/graphics/MediaPlayer.cpp:
3291         (WebCore::createNullMediaPlayer):
3292
3293 2011-04-25  James Robinson  <jamesr@chromium.org>
3294
3295         Reviewed by David Levin.
3296
3297         Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
3298         https://bugs.webkit.org/show_bug.cgi?id=59353
3299
3300         * rendering/RenderLayerCompositor.cpp:
3301         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
3302
3303 2011-04-25  Adam Barth  <abarth@webkit.org>
3304
3305         Reviewed by James Robinson.
3306
3307         Worker*.cpp should work with strict OwnPtrs
3308         https://bugs.webkit.org/show_bug.cgi?id=59346
3309
3310         * inspector/WorkerInspectorController.cpp:
3311         (WebCore::WorkerInspectorController::WorkerInspectorController):
3312         * workers/WorkerContext.cpp:
3313         (WebCore::WorkerContext::WorkerContext):
3314         * workers/WorkerRunLoop.cpp:
3315         (WebCore::WorkerRunLoop::WorkerRunLoop):
3316         * workers/WorkerScriptLoader.cpp:
3317         (WebCore::WorkerScriptLoader::createResourceRequest):
3318
3319 2011-04-25  James Robinson  <jamesr@chromium.org>
3320
3321         Reviewed by Adam Barth.
3322
3323         Remove bad use of OwnPtr::set() in IconDatabase.cpp
3324         https://bugs.webkit.org/show_bug.cgi?id=59344
3325
3326         Needed for strict OwnPtr compliance.
3327
3328         * loader/icon/IconDatabase.cpp:
3329         (WebCore::readySQLiteStatement):
3330
3331 2011-04-25  Adam Barth  <abarth@webkit.org>
3332
3333         Reviewed by Maciej Stachowiak.
3334
3335         ImageBuffer.h should work with strict OwnPtrs
3336         https://bugs.webkit.org/show_bug.cgi?id=59341
3337
3338         This patch is to prepare for the strict OwnPtr hack-a-thon.
3339
3340         * platform/graphics/ImageBuffer.h:
3341         (WebCore::ImageBuffer::create):
3342
3343 2011-04-25  Steve Falkenburg  <sfalken@apple.com>
3344
3345         Reviewed by Brian Weinstein.
3346
3347         WebCore build on Windows should include windows.h in its precompiled header to speed builds
3348         https://bugs.webkit.org/show_bug.cgi?id=59339
3349
3350         windows.h is included by several of the underlying wtf headers, including Atomics.h and
3351         ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
3352         
3353         On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
3354         (a 12% speedup).
3355
3356         * WebCorePrefix.h: Include windows.h
3357
3358 2011-04-25  Martin Robinson  <mrobinson@igalia.com>
3359
3360         Reviewed by Xan Lopez.
3361
3362         [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
3363         https://bugs.webkit.org/show_bug.cgi?id=59311
3364
3365         * platform/gtk/MainFrameScrollbarGtk.cpp:
3366         (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar
3367         disconnect any lingering signal handlers. This prevents an adjustment from controlling the
3368         active ScrollView and some zombie ScrollView.
3369
3370 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3371
3372         Another shot at fixing the EFL build.
3373
3374         * UseJSC.cmake:
3375         * bindings/js/JSDOMBinding.cpp:
3376
3377 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3378
3379         Try to fix EFL build.
3380
3381         * UseJSC.cmake: Added a missing file.
3382
3383 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3384
3385         Reviewed by Oliver Hunt.
3386
3387         Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
3388         https://bugs.webkit.org/show_bug.cgi?id=59333
3389
3390         * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
3391
3392         * bindings/js/JSDOMBinding.cpp:
3393         * bindings/js/JSDOMBinding.h:
3394         * bindings/js/JSDocumentCustom.cpp:
3395         * bindings/js/JSWorkerContextCustom.cpp:
3396         (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
3397
3398         * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
3399         lifetime management.
3400
3401         * dom/Document.idl: No need for a custom mark function anymore, since
3402         ActiveDOMObjets now manage their own lifetimes.
3403
3404         * dom/MessagePort.cpp:
3405         (WebCore::MessagePort::hasPendingActivity): Correctly report that we
3406         have pending activity when we're remotely entangled, instead of relying
3407         on our clients to know this about us and do the check for us.
3408
3409         * dom/MessagePort.h: FIXME!
3410
3411         * dom/MessagePort.idl:
3412         * fileapi/DOMFileSystem.idl:
3413         * fileapi/FileReader.idl:
3414         * fileapi/FileWriter.idl:
3415         * notifications/Notification.idl:
3416         * notifications/NotificationCenter.idl:
3417         * page/EventSource.idl:
3418         * storage/IDBDatabase.idl:
3419         * storage/IDBRequest.idl:
3420         * storage/IDBTransaction.idl:
3421         * webaudio/AudioContext.idl:
3422         * websockets/WebSocket.idl:
3423         * workers/AbstractWorker.idl:
3424         * workers/SharedWorker.idl:
3425         * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
3426
3427         * workers/WorkerContext.cpp:
3428         (WebCore::WorkerContext::hasPendingActivity): No need to make up for
3429         MessagePort::hasPendingActivity being wrong anymore, since it's now right.
3430
3431         * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
3432
3433 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3434
3435         Reviewed by Pavel Feldman.
3436
3437         Web Inspector: worker messages should be routed to corresponding worker front-end
3438         https://bugs.webkit.org/show_bug.cgi?id=59323
3439
3440         Added WorkerManager which is responsible for routing messages between
3441         Page inspector front-end and Worker inspector front-ends.
3442
3443         * WebCore.gypi:
3444         * inspector/front-end/WebKit.qrc:
3445         * inspector/front-end/WorkerManager.js: Added.
3446         (WebInspector.WorkerManager):
3447         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend):
3448         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded):
3449         (WebInspector.WorkerManager.loaded):
3450         (WebInspector.WorkerFrontendStub):
3451         (WebInspector.WorkerFrontendStub.prototype._receiveMessage):
3452         (WebInspector.WorkerDispatcher):
3453         (WebInspector.WorkerDispatcher.prototype._receiveMessage):
3454         (WebInspector.WorkerDispatcher.prototype.workerCreated):
3455         (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
3456         * inspector/front-end/inspector.html:
3457         * inspector/front-end/inspector.js:
3458         (WebInspector.loaded):
3459
3460 2011-04-25  Annie Sullivan  <sullivan@chromium.org>
3461
3462         Reviewed by Pavel Feldman.
3463
3464         Web Inspector: [Resources panel] Should be easy to copy data.
3465         https://bugs.webkit.org/show_bug.cgi?id=45662
3466
3467         Adds context menu items to copy resource location, resource request headers, and resource response headers.
3468
3469         * inspector/front-end/NetworkPanel.js:
3470         (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
3471         (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
3472         (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
3473         (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
3474         * inspector/front-end/Resource.js:
3475         (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
3476         (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
3477
3478 2011-04-25  Alexander Pavlov  <apavlov@chromium.org>
3479
3480         Reviewed by Yury Semikhatsky.
3481
3482         Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
3483         https://bugs.webkit.org/show_bug.cgi?id=59322
3484
3485         Use TextResourceDecoder to determine external stylesheet charsets correctly.
3486
3487         Test: inspector/styles/parse-utf8-bom.html
3488
3489         * inspector/InspectorStyleSheet.cpp:
3490         (WebCore::InspectorStyleSheet::originalStyleSheetText):
3491
3492 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3493
3494         Not reviewed: Inspector.json cleanup.
3495
3496         * inspector/Inspector.json:
3497
3498 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3499
3500         Reviewed by Pavel Feldman.
3501
3502         Web Inspector: introduce InspectorWorkerAgent
3503         https://bugs.webkit.org/show_bug.cgi?id=59320
3504
3505         InspectorWorkerAgent is responsible for routing inspector messages
3506         between worker context inspector agents and corresponding worker
3507         inspector front-end.
3508
3509         * CMakeLists.txt:
3510         * GNUmakefile.list.am:
3511         * WebCore.gypi:
3512         * WebCore.pro:
3513         * WebCore.vcproj/WebCore.vcproj:
3514         * WebCore.xcodeproj/project.pbxproj:
3515         * inspector/CodeGeneratorInspector.pm:
3516         * inspector/Inspector.json:
3517         * inspector/InspectorAgent.cpp:
3518         (WebCore::InspectorAgent::InspectorAgent):
3519         (WebCore::InspectorAgent::setFrontend):
3520         (WebCore::InspectorAgent::disconnectFrontend):
3521         * inspector/InspectorAgent.h:
3522         (WebCore::InspectorAgent::workerAgent):
3523         * inspector/InspectorController.cpp:
3524         (WebCore::InspectorController::connectFrontend):
3525         (WebCore::InspectorController::disconnectFrontend):
3526         * inspector/InspectorInstrumentation.cpp:
3527         (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
3528         * inspector/InspectorInstrumentation.h:
3529         (WebCore::InspectorInstrumentation::willStartWorkerContext):
3530         (WebCore::InspectorInstrumentation::didStartWorkerContext):
3531         * inspector/InspectorWorkerAgent.cpp: Added.
3532         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
3533         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
3534         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
3535         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
3536         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
3537         (WebCore::InspectorWorkerAgent::create):
3538         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
3539         (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
3540         (WebCore::InspectorWorkerAgent::setFrontend):
3541         (WebCore::InspectorWorkerAgent::clearFrontend):
3542         (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
3543         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
3544         * inspector/InspectorWorkerAgent.h: Added.
3545         * inspector/InstrumentingAgents.h:
3546         (WebCore::InstrumentingAgents::InstrumentingAgents):
3547         (WebCore::InstrumentingAgents::inspectorWorkerAgent):
3548         (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
3549         * inspector/WorkerInspectorController.cpp:
3550         (WebCore::WorkerInspectorController::connectFrontend):
3551         * inspector/generate-inspector-idl:
3552         * workers/Worker.cpp:
3553         (WebCore::Worker::notifyFinished):
3554         * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
3555         messages sent from the inspected page worker agent to the worker context inspector agents.
3556         (WebCore::WorkerContextInspectorProxy::connectFrontend):
3557         (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
3558         (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
3559         (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
3560         * workers/WorkerContextProxy.h:
3561         (WebCore::WorkerContextProxy::inspectorProxy):
3562
3563 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3564
3565         Reviewed by Yury Semikhatsky.
3566
3567         Web Inspector: move Frame and Resource Tree management into the Page agent.
3568         https://bugs.webkit.org/show_bug.cgi?id=59321
3569
3570         Network agent should only handle network-related activities.
3571         Frame structure should be managed by the Page agent instead.
3572
3573         * inspector/Inspector.json:
3574         * inspector/InspectorAgent.cpp:
3575         (WebCore::InspectorAgent::InspectorAgent):
3576         * inspector/InspectorDOMAgent.cpp:
3577         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
3578         (WebCore::InspectorDOMAgent::setFrontend):
3579         (WebCore::InspectorDOMAgent::restore):
3580         (WebCore::InspectorDOMAgent::highlightFrame):
3581         * inspector/InspectorDOMAgent.h:
3582         (WebCore::InspectorDOMAgent::create):
3583         * inspector/InspectorInstrumentation.cpp:
3584         (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
3585         (WebCore::InspectorInstrumentation::loadEventFiredImpl):
3586         (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
3587         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
3588         * inspector/InspectorPageAgent.cpp:
3589         (WebCore::InspectorPageAgent::create):
3590         (WebCore::InspectorPageAgent::resourceContent):
3591         (WebCore::InspectorPageAgent::resourceContentBase64):
3592         (WebCore::InspectorPageAgent::resourceData):
3593         (WebCore::InspectorPageAgent::cachedResource):
3594         (WebCore::InspectorPageAgent::resourceTypeString):
3595         (WebCore::InspectorPageAgent::cachedResourceType):
3596         (WebCore::InspectorPageAgent::cachedResourceTypeString):
3597         (WebCore::InspectorPageAgent::InspectorPageAgent):
3598         (WebCore::InspectorPageAgent::setFrontend):
3599         (WebCore::InspectorPageAgent::reload):
3600         (WebCore::InspectorPageAgent::open):
3601         (WebCore::InspectorPageAgent::getCookies):
3602         (WebCore::InspectorPageAgent::deleteCookie):
3603         (WebCore::InspectorPageAgent::getResourceTree):
3604         (WebCore::InspectorPageAgent::getResourceContent):
3605         (WebCore::InspectorPageAgent::restore):
3606         (WebCore::InspectorPageAgent::domContentEventFired):
3607         (WebCore::InspectorPageAgent::loadEventFired):
3608         (WebCore::InspectorPageAgent::frameNavigated):
3609         (WebCore::InspectorPageAgent::frameDetached):
3610         (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
3611         (WebCore::InspectorPageAgent::mainFrame):
3612         (WebCore::pointerAsId):
3613         (WebCore::InspectorPageAgent::frameForId):
3614         (WebCore::InspectorPageAgent::frameId):
3615         (WebCore::InspectorPageAgent::loaderId):
3616         (WebCore::InspectorPageAgent::buildObjectForFrame):
3617         (WebCore::InspectorPageAgent::buildObjectForFrameTree):
3618         * inspector/InspectorPageAgent.h:
3619         * inspector/InspectorResourceAgent.cpp:
3620         (WebCore::buildObjectForCachedResource):
3621         (WebCore::InspectorResourceAgent::willSendRequest):
3622         (WebCore::InspectorResourceAgent::didReceiveResponse):
3623         (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
3624         (WebCore::InspectorResourceAgent::setInitialScriptContent):
3625         (WebCore::InspectorResourceAgent::setInitialXHRContent):
3626         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
3627         * inspector/InspectorResourceAgent.h:
3628         (WebCore::InspectorResourceAgent::create):
3629         * inspector/InspectorStyleSheet.cpp:
3630         (WebCore::InspectorStyleSheet::resourceStyleSheetText):
3631         * inspector/front-end/NetworkManager.js:
3632         (WebInspector.NetworkManager.prototype.requestContent):
3633         * inspector/front-end/NetworkPanel.js:
3634         (WebInspector.NetworkPanel):
3635         (WebInspector.NetworkPanel.prototype.frameNavigated):
3636         * inspector/front-end/ResourceTreeModel.js:
3637         (WebInspector.ResourceTreeModel):
3638         (WebInspector.ResourceTreeModel.prototype.frontendReused):
3639         (WebInspector.ResourceTreeModel.prototype.frameNavigated):
3640         (WebInspector.ResourceTreeModel.prototype.frameDetached):
3641         * inspector/front-end/inspector.js:
3642         (WebInspector.domContentEventFired):
3643         (WebInspector.loadEventFired):
3644         (WebInspector.frameNavigated):
3645         (WebInspector.frameDetached):
3646
3647 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3648
3649         Reviewed by Yury Semikhatsky.
3650
3651         Web Inspector: few protocol improvements.
3652         https://bugs.webkit.org/show_bug.cgi?id=59319
3653
3654         - Page domain is documented
3655         - setUserAgentOverride is moved to the Network agent
3656         - setSearchingForNode -> setInspectModeEnabled
3657         - highlightDOMNode -> highlightNode
3658         - reloadPage -> reload
3659         - openInNewWindow -> open with optional parameter
3660
3661         * inspector/Inspector.json:
3662         * inspector/InspectorDOMAgent.cpp:
3663         (WebCore::InspectorDOMAgent::setInspectModeEnabled):
3664         (WebCore::InspectorDOMAgent::highlightNode):
3665         * inspector/InspectorDOMAgent.h:
3666         (WebCore::InspectorDOMAgent::hideNodeHighlight):
3667         * inspector/InspectorInstrumentation.cpp:
3668         (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
3669         * inspector/InspectorPageAgent.cpp:
3670         (WebCore::InspectorPageAgent::clearFrontend):
3671         (WebCore::InspectorPageAgent::reload):
3672         (WebCore::InspectorPageAgent::open):
3673         * inspector/InspectorPageAgent.h:
3674         * inspector/InspectorResourceAgent.cpp:
3675         (WebCore::InspectorResourceAgent::clearFrontend):
3676         (WebCore::InspectorResourceAgent::applyUserAgentOverride):
3677         (WebCore::InspectorResourceAgent::setUserAgentOverride):
3678         * inspector/InspectorResourceAgent.h:
3679         * inspector/front-end/AuditsPanel.js:
3680         (WebInspector.AuditsPanel.prototype._reloadResources):
3681         * inspector/front-end/ElementsPanel.js:
3682         (WebInspector.ElementsPanel.prototype.setSearchingForNode):
3683         * inspector/front-end/ExtensionServer.js:
3684         (WebInspector.ExtensionServer.prototype._onReload):
3685         * inspector/front-end/NetworkPanel.js:
3686         (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
3687         * inspector/front-end/ResourcesPanel.js:
3688         (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
3689         * inspector/front-end/inspector.js:
3690         (WebInspector.highlightDOMNode):
3691         (WebInspector.openResource):
3692         (WebInspector.documentKeyDown):
3693
3694 2011-04-25  Jon Lee  <jonlee@apple.com>
3695
3696         Reviewed by Maciej Stachowiak.
3697
3698         Overlay scroller hard to see on pages with dark background (59183)
3699         https://bugs.webkit.org/show_bug.cgi?id=59183
3700         <rdar://problem/8975367>
3701
3702         Switch the scrollbar's overlay style depending on its frame's background color.
3703         This refactors the getDocumentBackgroundColor method needed for gestures. The style
3704         is determined and set on every paint() call to the Mac scrollbar theme.
3705
3706         * WebCore.exp.in: adding method to allow changing style
3707         * page/Frame.cpp:
3708         (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
3709         * page/Frame.h:
3710         * page/FrameView.cpp:
3711         (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
3712         * page/FrameView.h:
3713         * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
3714         * platform/ScrollableArea.h:
3715         (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
3716         * platform/mac/ScrollbarThemeMac.mm:
3717         (WebCore::ScrollbarThemeMac::paint):
3718         * platform/mac/WebCoreSystemInterface.h:
3719         * platform/mac/WebCoreSystemInterface.mm:
3720
3721 2011-04-25  Dan Bernstein  <mitz@apple.com>
3722
3723         Reviewed by Maciej Stachowiak.
3724
3725         <rdar://problem/9113516> REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
3726         https://bugs.webkit.org/show_bug.cgi?id=59315
3727
3728         * platform/Scrollbar.cpp:
3729         (WebCore::Scrollbar::Scrollbar): Initialize new member variables.
3730         (WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
3731         is scrolled a distance equal to the change in the mouse position.
3732         (WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
3733         the document rather than the thumb, and pass the result to moveThumb.
3734         (WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
3735         * platform/Scrollbar.h:
3736         * platform/ScrollbarTheme.h:
3737         (WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
3738         returns false.
3739         * platform/mac/ScrollbarThemeMac.h:
3740         * platform/mac/ScrollbarThemeMac.mm:
3741         (WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
3742         Option key is down.
3743
3744 2011-04-24  Geoffrey Garen  <ggaren@apple.com>
3745
3746         Reviewed by Sam Weinig.
3747
3748         Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
3749         https://bugs.webkit.org/show_bug.cgi?id=59307
3750
3751         * WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.
3752
3753         * bindings/js/JSCSSRuleCustom.cpp:
3754         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
3755         * bindings/js/JSCanvasRenderingContextCustom.cpp:
3756         * bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead
3757         of hand-coding them.
3758
3759         * bindings/js/JSDOMBinding.h:
3760         (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because
3761         they're reasonably generic.
3762
3763         * bindings/js/JSDOMImplementationCustom.cpp:
3764         * bindings/js/JSDOMStringMapCustom.cpp:
3765         * bindings/js/JSDOMTokenListCustom.cpp:
3766         * bindings/js/JSHTMLCollectionCustom.cpp:
3767         * bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of
3768         hand-coding them.
3769
3770         * bindings/js/JSMessageChannelCustom.cpp:
3771         (WebCore::JSMessageChannel::visitChildren):
3772         * bindings/js/JSMessagePortCustom.cpp:
3773         (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of
3774         markDOMObjectWrapper. This is one of the few cases where a DOM object is
3775         considered a stand-alone root. It's not as efficient as the shared root
3776         case, but workers and message ports are very rare objects, so it's no
3777         big deal.
3778
3779         * bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate!
3780
3781         * bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h.
3782
3783         * bindings/js/JSSharedWorkerCustom.cpp:
3784         (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of
3785         markDOMObjectWrapper, as above. Once again, a stand-alone root.
3786
3787         * bindings/js/JSStyleSheetCustom.cpp:
3788         * bindings/js/JSStyleSheetListCustom.cpp: Autogenerate!
3789
3790         * bindings/js/JSWebGLRenderingContextCustom.cpp:
3791         (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots
3792         system for marking WebGL contexts and their associated satellite objects.
3793
3794         * bindings/js/JSWorkerContextCustom.cpp:
3795         (WebCore::JSWorkerContext::visitChildren):
3796         * bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of
3797         markDOMObjectWrapper, as above. Once again, stand-alone roots.
3798
3799         (WebCore::JSXMLHttpRequest::visitChildren):
3800         * bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner
3801         XHR because it is not reachable from us.
3802
3803         * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a
3804         bunch of repetitive cases of isReachableFromOpaqueRoots callbacks.
3805
3806         * css/CSSRule.idl:
3807         * css/CSSStyleDeclaration.idl:
3808         * css/MediaList.idl:
3809         * css/StyleMedia.idl:
3810         * css/StyleSheet.idl:
3811         * css/StyleSheetList.idl:
3812         * dom/DOMImplementation.idl:
3813         * dom/DOMStringMap.idl:
3814         * dom/MessagePort.idl:
3815         * dom/NamedNodeMap.idl:
3816         * fileapi/Blob.idl:
3817         * html/DOMTokenList.idl: Opt in to autogeneration.
3818
3819         * html/HTMLCanvasElement.cpp:
3820         (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr
3821         usage, to reduce human error and make ownership rules more obvious.
3822
3823         * html/HTMLCollection.idl:
3824         * html/canvas/ArrayBuffer.idl: Opt in to autogeneration.
3825
3826         * html/canvas/CanvasRenderingContext.cpp:
3827         * html/canvas/CanvasRenderingContext.h:
3828         (WebCore::CanvasRenderingContext::ref):
3829         (WebCore::CanvasRenderingContext::deref):
3830         * html/canvas/CanvasRenderingContext2D.h:
3831         (WebCore::CanvasRenderingContext2D::create):
3832         (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr
3833         usage, to reduce human error and make ownership rules more obvious.
3834         
3835         Inlined some functions to match our standard idiom and to make the code
3836         in the header document itself.
3837
3838         * html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration.
3839
3840         * html/canvas/OESStandardDerivatives.cpp:
3841         (WebCore::OESStandardDerivatives::OESStandardDerivatives):
3842         (WebCore::OESStandardDerivatives::create):
3843         * html/canvas/OESStandardDerivatives.h:
3844         * html/canvas/OESStandardDerivatives.idl:
3845         * html/canvas/OESTextureFloat.cpp:
3846         (WebCore::OESTextureFloat::OESTextureFloat):
3847         (WebCore::OESTextureFloat::create):
3848         * html/canvas/OESTextureFloat.h:
3849         * html/canvas/OESTextureFloat.idl:
3850         * html/canvas/OESVertexArrayObject.cpp:
3851         (WebCore::OESVertexArrayObject::OESVertexArrayObject):
3852         (WebCore::OESVertexArrayObject::create):
3853         * html/canvas/OESVertexArrayObject.h:
3854         * html/canvas/OESVertexArrayObject.idl:
3855         * html/canvas/WebGLExtension.cpp:
3856         (WebCore::WebGLExtension::WebGLExtension):
3857         * html/canvas/WebGLExtension.h:
3858         (WebCore::WebGLExtension::ref):
3859         (WebCore::WebGLExtension::deref):
3860         (WebCore::WebGLExtension::context):
3861         * html/canvas/WebGLRenderingContext.cpp:
3862         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
3863         (WebCore::WebGLRenderingContext::getExtension):
3864         * html/canvas/WebGLRenderingContext.h:
3865         * html/canvas/WebKitLoseContext.cpp:
3866         (WebCore::WebKitLoseContext::WebKitLoseContext):
3867         (WebCore::WebKitLoseContext::create):
3868         (WebCore::WebKitLoseContext::loseContext):
3869         * html/canvas/WebKitLoseContext.h:
3870         * html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL
3871         canavs rendering contexts to match the model for 2D canvas rendering
3872         contexts. This makes garbage collection a lot more straightforward, but
3873         it also makes the behavior of these objects more reliable. (Previously,
3874         satellite objects would magically stop working when the last reference
3875         to their owner object was dropped. Now, satellite objects keep their owner
3876         alive through reference counting.)
3877
3878         * loader/appcache/DOMApplicationCache.idl:
3879         * page/BarInfo.idl:
3880         * page/Console.idl:
3881         * page/DOMSelection.idl:
3882         * page/Geolocation.idl:
3883         * page/History.idl:
3884         * page/Location.idl:
3885         * page/Navigator.idl:
3886         * page/Screen.idl:
3887         * page/WorkerNavigator.idl:
3888         * plugins/DOMMimeTypeArray.h:
3889         (WebCore::DOMMimeTypeArray::frame):
3890         * plugins/DOMMimeTypeArray.idl:
3891         * plugins/DOMPluginArray.h:
3892         (WebCore::DOMPluginArray::frame):
3893         * plugins/DOMPluginArray.idl:
3894         * storage/Storage.idl:
3895         * workers/WorkerLocation.idl: Opt in to autogeneration.
3896
3897         * xml/XMLHttpRequest.cpp:
3898         (WebCore::XMLHttpRequest::~XMLHttpRequest):
3899         * xml/XMLHttpRequest.h:
3900         * xml/XMLHttpRequestUpload.cpp:
3901         (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
3902         * xml/XMLHttpRequestUpload.h:
3903         (WebCore::XMLHttpRequestUpload::create):
3904         (WebCore::XMLHttpRequestUpload::ref):
3905         (WebCore::XMLHttpRequestUpload::deref):
3906         (WebCore::XMLHttpRequestUpload::xmlHttpRequest):
3907         (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
3908         * xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and
3909         its associated upload object to match the model for canvas. This makes
3910         garbage collection a lot more straightforward, but it also makes the
3911         behavior of these objects more reliable.
3912
3913 2011-04-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3914
3915         Unreviewed, rolling out r84759.
3916         http://trac.webkit.org/changeset/84759
3917         https://bugs.webkit.org/show_bug.cgi?id=59306
3918
3919         Caused gc-shadow.html to start crashing in V8. (Requested by
3920         dglazkov|away on #webkit).
3921
3922         * dom/Node.cpp:
3923         (WebCore::NodeRendererFactory::createRendererAndStyle):
3924         (WebCore::Node::styleForRenderer):
3925
3926 2011-04-24  Maciej Stachowiak  <mjs@apple.com>
3927
3928         Reviewed by George Staikos.
3929
3930         Handling of URLs like http:/example.com/ is incorrect
3931         https://bugs.webkit.org/show_bug.cgi?id=59300
3932         <rdar://problem/9231956>
3933
3934         URLs like http:/example.com/ or http:example.com/ are now correctly
3935         canonicalized as http://example.com/
3936         
3937         The code still doesn't quite match other browsers - at least some
3938         other browsers seem to base parsing behavior on whether they
3939         recongize a scheme from a fixed list, and ignore whether // is
3940         present in the URL or not.
3941         
3942         * platform/KURL.cpp:
3943         (WebCore::isNonFileHierarchicalScheme): New helper function.
3944         (WebCore::KURL::parse): For a particular list of whitelisted schemes,
3945         assume they are hierarchical and need an authority even if there is no //
3946         after the :/
3947
3948 2011-04-24  Dan Bernstein  <mitz@apple.com>
3949
3950         LLVM Compiler build fix.
3951
3952         * page/ContentSecurityPolicy.cpp: Removed an unused function.
3953
3954 2011-04-24  Dominic Cooney  <dominicc@chromium.org>
3955
3956         Reviewed by Dimitri Glazkov.
3957
3958         Crash when adding a text node to a shadow root
3959         https://bugs.webkit.org/show_bug.cgi?id=59304
3960
3961         Text nodes need to consult their host element for style.
3962
3963         Test: fast/dom/shadow/append-child-text.html
3964
3965         * dom/Node.cpp:
3966         (WebCore::NodeRendererFactory::styleForRenderer):
3967         (WebCore::NodeRendererFactory::createRendererAndStyle):
3968         (WebCore::Node::styleForRenderer): forward to NodeRendererFactory
3969
3970 2011-04-24  Adam Barth  <abarth@webkit.org>
3971
3972         Reviewed by Eric Seidel.
3973
3974         Update Content-Security-Policy syntax to match new version of spec
3975         https://bugs.webkit.org/show_bug.cgi?id=59291
3976
3977         Brandon removed disable-xss-protection in favor of unsafe-inline and
3978         allow-eval in favor of unsafe-eval.  This change in syntax also means
3979         the options directive no longer exists.
3980
3981         * page/ContentSecurityPolicy.cpp:
3982         (WebCore::CSPSourceList::allowInline):
3983         (WebCore::CSPSourceList::allowEval):
3984         (WebCore::CSPSourceList::CSPSourceList):
3985         (WebCore::CSPSourceList::parseSource):
3986         (WebCore::CSPSourceList::addSourceUnsafeInline):
3987         (WebCore::CSPSourceList::addSourceUnsafeEval):
3988         (WebCore::CSPDirective::allowInline):
3989         (WebCore::CSPDirective::allowEval):
3990         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
3991         (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
3992         (WebCore::ContentSecurityPolicy::allowInlineScript):
3993         (WebCore::ContentSecurityPolicy::allowEval):
3994         (WebCore::ContentSecurityPolicy::addDirective):
3995         * page/ContentSecurityPolicy.h:
3996
3997 2011-04-24  Dan Bernstein  <mitz@apple.com>
3998
3999         Reviewed by Maciej Stachowiak.
4000
4001         Manual test for <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
4002         https://bugs.webkit.org/show_bug.cgi?id=59299
4003
4004         * manual-tests/back-from-document-with-scrollbar.html: Added.
4005
4006 2011-04-24  Rik Cabanier  <cabanier@adobe.com>
4007
4008         Reviewed by Simon Fraser.
4009
4010         Tables are not rendered correctly
4011         https://bugs.webkit.org/show_bug.cgi?id=59138
4012
4013         Test: fast/table/auto-100-percent-width.html
4014
4015         * rendering/AutoTableLayout.cpp:
4016         (WebCore::AutoTableLayout::computePreferredLogicalWidths):
4017
4018 2011-04-23  Simon Fraser  <simon.fraser@apple.com>
4019
4020         Fix Windows build, which complains about unreachable code.
4021
4022         * platform/ScrollableArea.cpp:
4023         (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
4024         (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
4025         (WebCore::ScrollableArea::hasLayerForScrollCorner):
4026
4027 2011-04-23  Simon Fraser  <simon.fraser@apple.com>
4028
4029         Reviewed by Dan Bernstein.
4030
4031         Area under composited scrollbars not repainted in WebKit2 on scrolling
4032         https://bugs.webkit.org/show_bug.cgi?id=59294
4033         <rdar://problem/9299062>
4034         
4035         When computing the rect that can be copied on scrolling, we normally
4036         exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars;
4037         the assumption is that other code will repaint these areas. However, when
4038         scrollbars are in their own compositing layers, we can, and should
4039         copy the entire area.
4040
4041         Not testable in DRT because it does not allow tests to use overlay scrollbars.
4042
4043         * platform/ScrollView.h:
4044         * platform/ScrollView.cpp:
4045         (WebCore::ScrollView::rectToCopyOnScroll):
4046         New method, with code moved from scrollContents and fixed to look
4047         for scrollbars in layers.
4048         (WebCore::ScrollView::scrollContents):
4049         Call rectToCopyOnScroll().
4050         
4051         * platform/ScrollableArea.h:
4052         * platform/ScrollableArea.cpp:
4053         (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
4054         (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
4055         (WebCore::ScrollableArea::hasLayerForScrollCorner):
4056         Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef.
4057
4058 2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>
4059
4060         Unreviewed, rolling out r84740.
4061         http://trac.webkit.org/changeset/84740
4062         https://bugs.webkit.org/show_bug.cgi?id=59290
4063
4064         change breaks apple internal builds and is incorrect
4065         (Requested by smfr on #webkit).
4066
4067         * WebCore.exp.in:
4068         * page/FrameView.cpp:
4069         * page/FrameView.h:
4070         * platform/ScrollTypes.h:
4071         * platform/ScrollableArea.h:
4072         * platform/mac/ScrollbarThemeMac.mm:
4073         (WebCore::ScrollbarThemeMac::paint):
4074         * platform/mac/WebCoreSystemInterface.h:
4075         * platform/mac/WebCoreSystemInterface.mm:
4076
4077 2011-04-23  Dan Bernstein  <mitz@apple.com>
4078
4079         Reviewed by Simon Fraser.
4080
4081         <rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
4082         https://bugs.webkit.org/show_bug.cgi?id=59288
4083
4084         * platform/text/mac/TextBoundaries.mm:
4085         (WebCore::wordStringTokenizer): Added this helper function.
4086         (WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord,
4087         whose behavior is not locale-dependent.
4088
4089 2011-04-23  Dominic Cooney  <dominicc@chromium.org>
4090
4091         Reviewed by Dimitri Glazkov.
4092
4093         [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
4094         https://bugs.webkit.org/show_bug.cgi?id=59284
4095
4096         Test: fast/dom/shadow/gc-shadow.html
4097
4098         * bindings/v8/V8GCController.cpp:
4099         (WebCore::calculateGroupId): group shadow nodes with their hosts
4100
4101 2011-04-23  MORITA Hajime <morrita@google.com>
4102
4103         Reviewed by Dimitri Glazkov.
4104
4105         [Refactoring] NodeRenderParentDetector should be NodeRenderFactory
4106         https://bugs.webkit.org/show_bug.cgi?id=59280
4107         
4108         - Rename NodeRenderParentDetector to NodeRendererFactory
4109         - move createRendererAndStyle() and createRendererIfNeeded to
4110           NodeRendererFactory
4111
4112         No new test, no behavioral change.
4113         
4114         * dom/Node.cpp:
4115   &nb