Remove redundant deviceScaleFactor() functions and make callers use Document::deviceS...
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2014-02-20  Zalan Bujtas  <zalan@apple.com>
2
3         Remove redundant deviceScaleFactor() functions and make callers use Document::deviceScaleFactor() when accessible.
4         https://bugs.webkit.org/show_bug.cgi?id=129137
5
6         Reviewed by Simon Fraser.
7
8         No change in behavior.
9
10         * editing/DeleteButtonController.cpp:
11         (WebCore::DeleteButtonController::createDeletionUI):
12         * page/Page.cpp:
13         * page/Page.h:
14         * platform/graphics/GraphicsContext.cpp:
15         (WebCore::GraphicsContext::GraphicsContext):
16         * platform/graphics/GraphicsContext.h:
17         * platform/graphics/cg/GraphicsContextCG.cpp:
18         (WebCore::GraphicsContext::platformInit):
19         * rendering/RenderBoxModelObject.cpp:
20         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
21         (WebCore::RenderBoxModelObject::drawBoxSideFromPath):
22         * rendering/RenderImage.cpp:
23         (WebCore::RenderImage::imageSizeForError):
24         (WebCore::RenderImage::paintReplaced):
25         * rendering/RenderLayer.cpp:
26         (WebCore::RenderLayer::drawPlatformResizerImage):
27         * rendering/RenderObject.cpp:
28         (WebCore::RenderObject::drawLineForBoxSide):
29         * rendering/RenderThemeMac.mm:
30         (WebCore::RenderThemeMac::paintProgressBar):
31         * rendering/svg/SVGRenderingContext.cpp:
32         (WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem):
33
34 2014-02-20  David Kilzer  <ddkilzer@apple.com>
35
36         Stop generating Objective-C bindings for the SVG DOM
37         <http://webkit.org/b/129107>
38
39         Reviewed by Timothy Hatcher.
40
41         Bug 114076 stopped compiling the Objective-C bindings for the
42         SVG DOM, but we continued to generate the header and source
43         files after that landed in r147822.  This patch also stops
44         generating the unused header and source files.
45
46         * DerivedSources.make:
47         - Split BINDING_IDLS into NON_SVG_BINDING_IDLS and
48           SVG_BINDING_IDLS so that they may operated on separately.
49         - Define BINDING_IDLS again as the full list of IDL files.
50         - Rename DOM_CLASSES to JS_DOM_CLASSES so that JavaScript
51           bindings are still generated for all IDL files.
52         - Add OBJC_DOM_CLASSES so that Objective-C bindings are only
53           generated for non-SVG IDL files.
54
55         * bindings/scripts/CodeGeneratorObjC.pm:
56         (GetBaseClass):
57         (GetPropertyAttributes):
58         (AddIncludesForType):
59         (GenerateHeader):
60         (GenerateImplementation):
61         - Remove support for SVG classes.
62
63 2014-02-20  Simon Fraser  <simon.fraser@apple.com>
64
65         RenderBox::updateShapeOutsideInfoAfterStyleChange shows up on profiles
66         https://bugs.webkit.org/show_bug.cgi?id=129075
67
68         Reviewed by Dean Jackson.
69
70         updateShapeOutsideInfoAfterStyleChange() showed up on profiles in content
71         with no shapes. Avoid calling this if no style has shapeOutside().
72
73         * rendering/RenderBox.cpp:
74         (WebCore::RenderBox::styleDidChange):
75
76 2014-02-20  ChangSeok Oh  <changseok.oh@collabora.com>
77
78         Remove unused chromium stuff in Extensions3D
79         https://bugs.webkit.org/show_bug.cgi?id=129086
80
81         Reviewed by Anders Carlsson.
82
83         Remove GL_CHROMIUM_copy_texture and GL_CHROMIUM_flipy interfaces since they are used nowhere.
84
85         No new tests since no functionality changed.
86
87         * platform/graphics/Extensions3D.h:
88         * platform/graphics/opengl/Extensions3DOpenGL.cpp:
89         * platform/graphics/opengl/Extensions3DOpenGL.h:
90         * platform/graphics/opengl/Extensions3DOpenGLES.cpp:
91         * platform/graphics/opengl/Extensions3DOpenGLES.h:
92
93 2014-02-20  Joseph Pecoraro  <pecoraro@apple.com>
94
95         [iOS] Assert / crash trying to draw empty checked input
96         https://bugs.webkit.org/show_bug.cgi?id=129138
97
98         Reviewed by Simon Fraser.
99
100         Test: fast/forms/checkbox-empty-size.html
101
102         * rendering/RenderThemeIOS.mm:
103         (WebCore::shortened):
104         Avoid a divide by 0, but checking for the condition upfront.
105
106 2014-02-20  Benjamin Poulain  <bpoulain@apple.com>
107
108         Start fixing the view states driven by the WKScrollView
109         https://bugs.webkit.org/show_bug.cgi?id=129140
110
111         Reviewed by Tim Horton and Simon Fraser.
112
113         * platform/graphics/ca/mac/TileController.mm:
114         (WebCore::TileController::scaledExposedRect):
115         That comment was more confusing than helping. FrameView-relative coordinates should not need
116         scaling.
117
118 2014-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
119
120         Start to use std::unique_ptr for DragImageLoader
121         https://bugs.webkit.org/show_bug.cgi?id=129078
122
123         Reviewed by Ryosuke Niwa.
124
125         As a step to use std::unique_ptr, this patch replace uses of OwnPtr and PassOwnPtr
126         in the DragImageLoader class with std::unique_ptr. Besides DragImageLoader is set to
127         non-copyable class.
128
129         * dom/Clipboard.cpp:
130         (WebCore::Clipboard::setDragImage):
131         * dom/Clipboard.h:
132
133 2014-02-20  Brady Eidson  <beidson@apple.com>
134
135         Move the image controls setting to Settings.in
136         https://bugs.webkit.org/show_bug.cgi?id=129126
137
138         Reviewed by Tim Horton.
139
140         * page/Settings.cpp:
141         (WebCore::Settings::Settings):
142         * page/Settings.h:
143         * page/Settings.in:
144
145 2014-02-20  Brady Eidson  <beidson@apple.com>
146
147         Add very basic image control rendering
148         https://bugs.webkit.org/show_bug.cgi?id=129080
149
150         Reviewed by Tim Horton.
151
152         Test: fast/images/image-controls-basic.html
153
154         This patch is groundwork that adds a very basic image control that can render on top of images.
155
156         * dom/Node.h:
157         (WebCore::Node:: isImageControlsRootElement): Returns false, unless you are an ImageControls object.
158         * html/HTMLAttributeNames.in:
159
160         Teach HTMLImageElement how to understand an experimental attribute to install controls,
161         how to actually build the DOM to attach to the shadow root, how to tear that DOM down,
162         and how to make sure that Renderers are created for that DOM:
163         * html/HTMLImageElement.cpp:
164         (WebCore::HTMLImageElement::HTMLImageElement):
165         (WebCore::HTMLImageElement::parseAttribute):
166         (WebCore::HTMLImageElement::didAttachRenderers):
167         (WebCore::HTMLImageElement::updateImageControls):
168         (WebCore::HTMLImageElement::createImageControls):
169         (WebCore::HTMLImageElement::destroyImageControls):
170         (WebCore::HTMLImageElement::hasImageControls):
171         (WebCore::HTMLImageElement::childShouldCreateRenderer):
172         * html/HTMLImageElement.h:
173         (WebCore::HTMLImageElement::hasShadowControls): For RenderImage to query when it is constructed. 
174
175         Add a generic, platform independent ImageControls root element that does nothing:
176         * html/shadow/ImageControlsRootElement.cpp: Added.
177         (WebCore::ImageControlsRootElement::maybeCreate):
178         (WebCore::ImageControlsRootElement::ImageControlsRootElement):
179         (WebCore::ImageControlsRootElement::~ImageControlsRootElement):
180         * html/shadow/ImageControlsRootElement.h: Added.
181
182         Add a Mac-specific ImageControls root element that renders a 20x20 red box (for now):
183         * html/shadow/mac/ImageControlsRootElementMac.cpp: Added.
184         (WebCore::ImageControlsRootElementMac::ImageControlsRootElementMac):
185         (WebCore::ImageControlsRootElementMac::~ImageControlsRootElementMac):
186         (WebCore::ImageControlsRootElement::maybeCreate):
187         (WebCore::ImageControlsRootElementMac::maybeCreate):
188         * html/shadow/mac/ImageControlsRootElementMac.h: Added.
189
190         Since much of the RenderMedia::layout() method is now required for RenderImage as well,
191         move the logic to RenderImage. The extra work is controlled by a bool flag that will always
192         be set for RenderMedias but will only be set for certain RenderImages:
193         * rendering/RenderImage.cpp:
194         (WebCore::RenderImage::RenderImage):
195         (WebCore::RenderImage::canHaveChildren):
196         (WebCore::RenderImage::layout):
197         (WebCore::RenderImage::layoutShadowControls):
198         * rendering/RenderImage.h:
199         (WebCore::RenderImage::setHasShadowControls):
200         (WebCore::RenderImage::shadowControlsNeedCustomLayoutMetrics):
201
202         * rendering/RenderMedia.cpp:
203         (WebCore::RenderMedia::RenderMedia):
204         * rendering/RenderMedia.h:
205         (WebCore::RenderMedia::shadowControlsNeedCustomLayoutMetrics):
206
207         * WebCore.xcodeproj/project.pbxproj:
208
209 == Rolled over to ChangeLog-2014-02-20 ==