Remove IMAGE_RESIZER related code.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-28  David Levin  <levin@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         Remove IMAGE_RESIZER related code.
6         https://bugs.webkit.org/show_bug.cgi?id=59735
7
8         * CMakeLists.txt:
9         * Configurations/FeatureDefines.xcconfig:
10         * GNUmakefile.am:
11         * GNUmakefile.list.am:
12         * WebCore.gypi:
13         * WebCore.pro:
14         * WebCore.vcproj/WebCore.vcproj:
15         * WebCore.xcodeproj/project.pbxproj:
16         * features.pri:
17         * html/AsyncImageResizer.cpp: Removed.
18         * html/AsyncImageResizer.h: Removed.
19         * html/ImageResizerThread.cpp: Removed.
20         * html/ImageResizerThread.h: Removed.
21
22 2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
23
24         Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
25
26         * inspector/front-end/Settings.js:
27         (WebInspector.Settings):
28
29 2011-04-28  Beth Dakin  <bdakin@apple.com>
30
31         Rubber-stamped by Sam Weinig.
32
33         Rolling out revision 85258! I want to fix that bug a different way.
34         * platform/mac/ScrollbarThemeMac.mm:
35         (WebCore::ScrollbarThemeMac::paint):
36
37 2011-04-28  Chang Shu  <cshu@webkit.org>
38
39         Reviewed by Eric Seidel.
40
41         isContentEditable is not working properly with document.designMode
42         https://bugs.webkit.org/show_bug.cgi?id=53031
43
44         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
45         indicates that the element.isContentEditable relies on document.designMode if its
46         and its ancestors' contenteditable attributes are set to inherit.
47
48         1. Sync document render style after document.designMode is changed.
49         2. Removed the code that does unnecessary and incorrect handling for contenteditable
50         attribute with "inherit" value.
51         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
52
53         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
54                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
55                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
56                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
57
58         * css/CSSStyleSelector.cpp:
59         (WebCore::CSSStyleSelector::styleForDocument):
60         * dom/Document.cpp:
61         (WebCore::Document::setDesignMode):
62         * dom/Node.cpp:
63         (WebCore::Node::rendererIsEditable):
64         * editing/ApplyStyleCommand.cpp:
65         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
66         * html/HTMLElement.cpp:
67         (WebCore::HTMLElement::setContentEditable):
68
69 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
70
71         Unreviewed, rolling out r85101.
72         http://trac.webkit.org/changeset/85101
73         https://bugs.webkit.org/show_bug.cgi?id=59757
74
75          it'd be better to rollout the patch and do another one with
76         another property name. Current one will bring us to a problem
77         at first run after upgrade because it's type was changed from
78         int to string. (Requested by loislo on #webkit).
79
80         * inspector/front-end/ScriptsPanel.js:
81         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
82         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
83         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
84
85 2011-04-28  Mike Reed  <reed@google.com>
86
87         Reviewed by Eric Seidel.
88
89         fix shadw behavior for both CSS and Canvas -- skia only
90         https://bugs.webkit.org/show_bug.cgi?id=59700
91
92         Test:
93         canvas/philip/tests/2d.shadow.alpha.3.html
94         canvas/philip/tests/2d.shadow.alpha.4.html
95         canvas/philip/tests/2d.shadow.alpha.5.html
96         fast/canvas/canvas-fillPath-alpha-shadow.html
97         fast/canvas/canvas-strokePath-alpha-shadow.html
98         fast/canvas/canvas-strokeRect-alpha-shadow.html
99         fast/css/text-input-with-webkit-border-radius.html
100         fast/repaint/shadow-multiple-horizontal.html
101         fast/repaint/shadow-multiple-strict-horizontal.html
102         fast/repaint/shadow-multiple-strict-vertical.html
103         fast/repaint/shadow-multiple-vertical.html
104         fast/canvas/canvas-getImageData.html
105
106         * platform/graphics/chromium/FontChromiumWin.cpp:
107         (WebCore::Font::drawGlyphs):
108         * platform/graphics/skia/GraphicsContextSkia.cpp:
109         (WebCore::GraphicsContext::setPlatformShadow):
110
111 2011-04-28  David Kilzer  <ddkilzer@apple.com>
112
113         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
114
115         Reviewed by Chris Fleizach.
116
117         Previously, AXObjectCache::attachWrapper over-retained each
118         AccessibilityObjectWrapper it created, which is why
119         AXObjectCache::detachWrapper() contained an extra -release.
120
121         * accessibility/mac/AXObjectCacheMac.mm:
122         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
123         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
124         assigns to a RetainPtr<> instance variable, it doesn't need a +1
125         retained object passed in.  Fix the leak by using a RetainPtr<>
126         for the AccessibilityObjectWrapper.
127
128 2011-04-28  Nat Duca  <nduca@chromium.org>
129
130         Reviewed by Darin Fisher.
131
132         [chromium] Compute compositor fps value and history using the frameBegin timestamp
133         https://bugs.webkit.org/show_bug.cgi?id=59668
134
135         This change switches the compositor FPS meter to use the timestamp
136         of the beginning of the frame rather than the time we call
137         swapBuffers. When scheduling is correctly tied to vsync, we can
138         have highly variable times when we finish vsync and still have
139         stable frame rates.
140
141         * platform/graphics/chromium/LayerRendererChromium.cpp:
142         (WebCore::LayerRendererChromium::updateAndDrawLayers):
143         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
144         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
145         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
146         (WebCore::CCHeadsUpDisplay::onFrameBegin):
147         (WebCore::CCHeadsUpDisplay::onPresent):
148         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
149
150 2011-04-28  Beth Dakin  <bdakin@apple.com>
151
152         Reviewed by Darin Adler.
153
154         https://bugs.webkit.org/show_bug.cgi?id=59759
155         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
156         track when there is nothing to scroll to
157         <rdar://problem/9282066>
158
159         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
160         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
161         is not right. Set the proportion to 0 in this case instead.
162         * platform/mac/ScrollbarThemeMac.mm:
163         (WebCore::ScrollbarThemeMac::paint):
164
165 2011-04-28  Dan Bernstein  <mitz@apple.com>
166
167         Reviewed by Simon Fraser.
168
169         <rdar://problem/9291132> Add support for -epub-prefixed properties
170
171         Test: fast/css/epub-properties.html
172
173         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
174         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
175         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
176         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
177         text-transform, text-transform, word-break, and -webkit-writing-mode.
178
179 2011-04-28  Adam Barth  <abarth@webkit.org>
180
181         Reviewed by Eric Seidel.
182
183         Remove WML
184         https://bugs.webkit.org/show_bug.cgi?id=59678
185
186         This patch removes WML from WebCore.  After removing WML, there's a
187         bunch of twisted code that could be untwisted, but this patch contains
188         only the purely mechanical part of removing the feature.
189
190         There's been a lot of discussion on webkit-dev about whether we should
191         remove WML.  In addition to those threads, we've had an informal poll
192         of the reviewers as well as an in-person discussion at the WebKit
193         contributor's meeting.  Removing any feature is likely to make some
194         folks unhappy, but, on balance, removing WML appears to be the right
195         thing for the project to do at this time.
196
197         * CMakeLists.txt:
198         * CodeGenerators.pri:
199         * Configurations/FeatureDefines.xcconfig:
200         * DerivedSources.cpp:
201         * DerivedSources.make:
202         * GNUmakefile.am:
203         * GNUmakefile.list.am:
204         * WebCore.gyp/WebCore.gyp:
205         * WebCore.gypi:
206         * WebCore.pro:
207         * WebCore.vcproj/WebCore.vcproj:
208         * WebCore.xcodeproj/project.pbxproj:
209         * css/CSSStyleSelector.cpp:
210         (WebCore::linkAttribute):
211         (WebCore::CSSStyleSelector::styleForElement):
212         (WebCore::CSSStyleSelector::adjustRenderStyle):
213         * css/wml.css: Removed.
214         * dom/DOMImplementation.cpp:
215         (WebCore::DOMImplementation::createDocument):
216         * dom/Document.cpp:
217         (WebCore::Document::Document):
218         (WebCore::Document::createElement):
219         * dom/Document.h:
220         (WebCore::Document::isMediaDocument):
221         * dom/Document.idl:
222         * dom/InputElement.h:
223         * dom/Node.cpp:
224         (WebCore::Node::toInputElement):
225         * dom/Node.h:
226         * dom/OptionElement.cpp:
227         (WebCore::toOptionElement):
228         (WebCore::isOptionElement):
229         * dom/OptionElement.h:
230         * dom/OptionGroupElement.cpp:
231         (WebCore::toOptionGroupElement):
232         (WebCore::isOptionGroupElement):
233         * dom/SelectElement.cpp:
234         (WebCore::toSelectElement):
235         * dom/SelectElement.h:
236         * dom/Text.cpp:
237         (WebCore::Text::attach):
238         * dom/XMLDocumentParser.cpp:
239         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
240         * dom/XMLDocumentParser.h:
241         * dom/XMLDocumentParserLibxml2.cpp:
242         (WebCore::XMLDocumentParser::internalSubset):
243         (WebCore::getEntityHandler):
244         * dom/XMLDocumentParserQt.cpp:
245         (WebCore::XMLDocumentParser::parse):
246         (WebCore::XMLDocumentParser::parseDtd):
247         * editing/htmlediting.cpp:
248         (WebCore::canHaveChildrenForEditing):
249         * features.pri:
250         * history/BackForwardList.h:
251         * history/BackForwardListImpl.cpp:
252         * history/BackForwardListImpl.h:
253         * history/PageCache.cpp:
254         (WebCore::PageCache::canCachePageContainingThisFrame):
255         * html/HTMLAnchorElement.h:
256         * inspector/ConsoleMessage.cpp:
257         (WebCore::messageSourceValue):
258         * inspector/front-end/ConsoleView.js:
259         (WebInspector.ConsoleMessage.prototype.toString):
260         * loader/FrameLoader.cpp:
261         (WebCore::isBackForwardLoadType):
262         (WebCore::FrameLoader::transitionToCommitted):
263         (WebCore::FrameLoader::shouldReload):
264         (WebCore::FrameLoader::loadDifferentDocumentItem):
265         (WebCore::FrameLoader::loadItem):
266         * loader/FrameLoaderTypes.h:
267         * loader/HistoryController.cpp:
268         (WebCore::HistoryController::restoreDocumentState):
269         * manual-tests/wml: Removed.
270         * manual-tests/wml/StartTests.wml: Removed.
271         * manual-tests/wml/a-br-element.wml: Removed.
272         * manual-tests/wml/a-element.wml: Removed.
273         * manual-tests/wml/a-img-element.wml: Removed.
274         * manual-tests/wml/access-target.wml: Removed.
275         * manual-tests/wml/anchor-br-element.wml: Removed.
276         * manual-tests/wml/anchor-element.wml: Removed.
277         * manual-tests/wml/anchor-img-element.wml: Removed.
278         * manual-tests/wml/card-newcontext-attr.wml: Removed.
279         * manual-tests/wml/card-onenterbackward.wml: Removed.
280         * manual-tests/wml/card-onenterforward.wml: Removed.
281         * manual-tests/wml/card-ontimer.wml: Removed.
282         * manual-tests/wml/deck-access-control.wml: Removed.
283         * manual-tests/wml/input-format.wml: Removed.
284         * manual-tests/wml/onevent-go.wml: Removed.
285         * manual-tests/wml/onevent-noop.wml: Removed.
286         * manual-tests/wml/onevent-prev.wml: Removed.
287         * manual-tests/wml/onevent-refresh.wml: Removed.
288         * manual-tests/wml/onevent-shadow.wml: Removed.
289         * manual-tests/wml/resources: Removed.
290         * manual-tests/wml/resources/smiley.png: Removed.
291         * manual-tests/wml/select-element.wml: Removed.
292         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
293         * manual-tests/wml/select-onpick-event.wml: Removed.
294         * manual-tests/wml/setvar-element.wml: Removed.
295         * manual-tests/wml/targetdeck.wml: Removed.
296         * manual-tests/wml/task-go-in-anchor.wml: Removed.
297         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
298         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
299         * manual-tests/wml/template-go.wml: Removed.
300         * manual-tests/wml/template-ontimer.wml: Removed.
301         * manual-tests/wml/timer.wml: Removed.
302         * manual-tests/wml/variable-substitution.wml: Removed.
303         * page/Console.cpp:
304         (WebCore::printMessageSourceAndLevelPrefix):
305         * page/Console.h:
306         * page/Frame.cpp:
307         (WebCore::Frame::Frame):
308         * page/Page.cpp:
309         * page/Page.h:
310         * platform/MIMETypeRegistry.cpp:
311         (WebCore::initializeSupportedNonImageMimeTypes):
312         * platform/network/FormDataBuilder.h:
313         * platform/network/mac/ResourceHandleMac.mm:
314         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
315         * platform/wince/MIMETypeRegistryWinCE.cpp:
316         (WebCore::initMIMETypeEntensionMap):
317         * rendering/HitTestResult.cpp:
318         (WebCore::HitTestResult::altDisplayString):
319         (WebCore::HitTestResult::absoluteImageURL):
320         (WebCore::HitTestResult::absoluteLinkURL):
321         (WebCore::HitTestResult::isLiveLink):
322         * rendering/RenderBox.cpp:
323         * rendering/RenderButton.cpp:
324         (WebCore::RenderButton::updateFromElement):
325         * rendering/RenderFieldset.cpp:
326         (WebCore::RenderFieldset::findLegend):
327         * rendering/RenderImage.cpp:
328         (WebCore::RenderImage::updateAltText):
329         * rendering/RenderObject.cpp:
330         (WebCore::RenderObject::isLegend):
331         (WebCore::RenderObject::offsetParent):
332         * wml: Removed.
333         * wml/WMLAElement.cpp: Removed.
334         * wml/WMLAElement.h: Removed.
335         * wml/WMLAccessElement.cpp: Removed.
336         * wml/WMLAccessElement.h: Removed.
337         * wml/WMLAnchorElement.cpp: Removed.
338         * wml/WMLAnchorElement.h: Removed.
339         * wml/WMLAttributeNames.in: Removed.
340         * wml/WMLBRElement.cpp: Removed.
341         * wml/WMLBRElement.h: Removed.
342         * wml/WMLCardElement.cpp: Removed.
343         * wml/WMLCardElement.h: Removed.
344         * wml/WMLDoElement.cpp: Removed.
345         * wml/WMLDoElement.h: Removed.
346         * wml/WMLDocument.cpp: Removed.
347         * wml/WMLDocument.h: Removed.
348         * wml/WMLElement.cpp: Removed.
349         * wml/WMLElement.h: Removed.
350         * wml/WMLErrorHandling.cpp: Removed.
351         * wml/WMLErrorHandling.h: Removed.
352         * wml/WMLEventHandlingElement.cpp: Removed.
353         * wml/WMLEventHandlingElement.h: Removed.
354         * wml/WMLFieldSetElement.cpp: Removed.
355         * wml/WMLFieldSetElement.h: Removed.
356         * wml/WMLFormControlElement.cpp: Removed.
357         * wml/WMLFormControlElement.h: Removed.
358         * wml/WMLGoElement.cpp: Removed.
359         * wml/WMLGoElement.h: Removed.
360         * wml/WMLImageElement.cpp: Removed.
361         * wml/WMLImageElement.h: Removed.
362         * wml/WMLImageLoader.cpp: Removed.
363         * wml/WMLImageLoader.h: Removed.
364         * wml/WMLInputElement.cpp: Removed.
365         * wml/WMLInputElement.h: Removed.
366         * wml/WMLInsertedLegendElement.cpp: Removed.
367         * wml/WMLInsertedLegendElement.h: Removed.
368         * wml/WMLIntrinsicEvent.cpp: Removed.
369         * wml/WMLIntrinsicEvent.h: Removed.
370         * wml/WMLIntrinsicEventHandler.cpp: Removed.
371         * wml/WMLIntrinsicEventHandler.h: Removed.
372         * wml/WMLMetaElement.cpp: Removed.
373         * wml/WMLMetaElement.h: Removed.
374         * wml/WMLNoopElement.cpp: Removed.
375         * wml/WMLNoopElement.h: Removed.
376         * wml/WMLOnEventElement.cpp: Removed.
377         * wml/WMLOnEventElement.h: Removed.
378         * wml/WMLOptGroupElement.cpp: Removed.
379         * wml/WMLOptGroupElement.h: Removed.
380         * wml/WMLOptionElement.cpp: Removed.
381         * wml/WMLOptionElement.h: Removed.
382         * wml/WMLPElement.cpp: Removed.
383         * wml/WMLPElement.h: Removed.
384         * wml/WMLPageState.cpp: Removed.
385         * wml/WMLPageState.h: Removed.
386         * wml/WMLPostfieldElement.cpp: Removed.
387         * wml/WMLPostfieldElement.h: Removed.
388         * wml/WMLPrevElement.cpp: Removed.
389         * wml/WMLPrevElement.h: Removed.
390         * wml/WMLRefreshElement.cpp: Removed.
391         * wml/WMLRefreshElement.h: Removed.
392         * wml/WMLSelectElement.cpp: Removed.
393         * wml/WMLSelectElement.h: Removed.
394         * wml/WMLSetvarElement.cpp: Removed.
395         * wml/WMLSetvarElement.h: Removed.
396         * wml/WMLTableElement.cpp: Removed.
397         * wml/WMLTableElement.h: Removed.
398         * wml/WMLTagNames.in: Removed.
399         * wml/WMLTaskElement.cpp: Removed.
400         * wml/WMLTaskElement.h: Removed.
401         * wml/WMLTemplateElement.cpp: Removed.
402         * wml/WMLTemplateElement.h: Removed.
403         * wml/WMLTimerElement.cpp: Removed.
404         * wml/WMLTimerElement.h: Removed.
405         * wml/WMLVariables.cpp: Removed.
406         * wml/WMLVariables.h: Removed.
407
408 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
409
410         Unreviewed, rolling out r85233 and r85235.
411         http://trac.webkit.org/changeset/85233
412         http://trac.webkit.org/changeset/85235
413         https://bugs.webkit.org/show_bug.cgi?id=59754
414
415         Causes issues with jsc. (Requested by dave_levin on #webkit).
416
417         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
418         * loader/icon/IconDatabase.cpp:
419         (WebCore::IconDatabase::defaultIcon):
420         (WebCore::IconDatabase::setIconDataForIconURL):
421         (WebCore::IconDatabase::getOrCreateIconRecord):
422         (WebCore::IconDatabase::readFromDatabase):
423
424 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
425
426         Reviewed by Adam Barth.
427
428         Introducing a new class that allows serialization of a page back
429         to HTML/XML with all its sub-frames and also retrieves the page's
430         resources.
431         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
432         https://bugs.webkit.org/show_bug.cgi?id=58947
433
434         * Android.mk:
435         * CMakeLists.txt:
436         * GNUmakefile.list.am:
437         * WebCore.gypi:
438         * WebCore.pro:
439         * WebCore.vcproj/WebCore.vcproj:
440         * dom/Document.cpp:
441         (WebCore::Document::suggestedMIMEType):
442         * dom/Document.h:
443         * editing/MarkupAccumulator.cpp:
444         (WebCore::MarkupAccumulator::appendCustomAttributes):
445         (WebCore::MarkupAccumulator::appendElement):
446         * editing/MarkupAccumulator.h:
447         * html/parser/HTMLMetaCharsetParser.cpp:
448         (WebCore::HTMLMetaCharsetParser::processMeta):
449         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
450         * html/parser/HTMLMetaCharsetParser.h:
451         * page/PageSerializer.cpp: Added.
452         * page/PageSerializer.h: Added.
453
454 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
455
456         Reviewed by Tony Chang.
457
458         IndexedDB createIndex should fail if name arg is null
459         https://bugs.webkit.org/show_bug.cgi?id=58365
460
461         Test: storage/indexeddb/mozilla/create-index-null-name.html
462
463         * storage/IDBObjectStore.idl:
464         * storage/IDBObjectStoreBackendImpl.cpp:
465         (WebCore::IDBObjectStoreBackendImpl::createIndex):
466
467 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
468
469         Reviewed by Tony Chang.
470
471         IndexedDB put() should fail if second (key) parameter is null
472         https://bugs.webkit.org/show_bug.cgi?id=58613
473
474         If key arg is not specified, prpKey ends up as a null pointer in ::put().
475         However, if the key arg is specified but is null, prpKey ends up as a
476         valid IDBKey which has a null key type. As it happens, we need to be able
477         to detect the difference between these cases (the key arg is optional but
478         if specified must not be null).
479
480         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
481
482         * storage/IDBObjectStoreBackendImpl.cpp:
483         (WebCore::IDBObjectStoreBackendImpl::put):
484
485 2011-04-07  David Levin  <levin@chromium.org>
486
487         Reviewed by Darin Adler.
488
489         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
490         https://bugs.webkit.org/show_bug.cgi?id=31639
491
492         No new functionality exposed so no new tests. (The change is basically adding
493         more testing.)
494
495         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
496         * loader/icon/IconDatabase.cpp:
497         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
498         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
499         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
500         (WebCore::IconDatabase::readFromDatabase): Ditto.
501
502 2011-04-28  Kenneth Russell  <kbr@google.com>
503
504         Unreviewed build fix for Web Audio with strict OwnPtr.
505
506         * platform/audio/HRTFDatabaseLoader.cpp:
507         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
508
509 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
510
511         Reviewed by Geoffrey Garen.
512
513         Walk shadow hosts as well as parent nodes when finding opaque roots.
514         https://bugs.webkit.org/show_bug.cgi?id=59571
515
516         Test: fast/dom/shadow/gc-shadow.html
517
518         * bindings/js/JSDOMBinding.h:
519         (WebCore::root):
520
521 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
522
523         Reviewed by Xan Lopez.
524
525         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
526         https://bugs.webkit.org/show_bug.cgi?id=59715
527
528         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
529         into WebCore so that WebKit1 and WebKit2 can share the code.
530
531         No new tests. This is covered by fast/events/click-count.html.
532
533         * GNUmakefile.list.am: Added new files.
534         * platform/gtk/GtkClickCounter.cpp: Added.
535         (WebCore::GtkClickCounter::GtkClickCounter): Added.
536         (WebCore::GtkClickCounter::reset): Added.
537         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
538         (WebCore::getEventTime): Added.
539         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
540         * platform/gtk/GtkClickCounter.h: Added.
541
542 2011-04-28  Dan Bernstein  <mitz@apple.com>
543
544         Build fix.
545
546         * css/CSSParser.cpp:
547         (WebCore::cssPropertyID):
548
549 2011-04-28  Dan Bernstein  <mitz@apple.com>
550
551         Reviewed by Simon Fraser.
552
553         Allow specifying CSS property aliases in CSSPropertyNames.in files
554         https://bugs.webkit.org/show_bug.cgi?id=59712
555
556         * css/CSSParser.cpp:
557         (WebCore::cssPropertyID): Removed code to handle some aliases
558         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
559         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
560         defining an alias, and add an appropriate entry to the gperf file.
561
562 2011-04-28  Arno Renevier  <arno@renevier.net>
563
564         Reviewed by Gustavo Noronha Silva.
565
566         [Soup] does not load css stylesheets without content-type
567         https://bugs.webkit.org/show_bug.cgi?id=59697
568
569         When sniffing content type, do not replace http Content-Type header in
570         soup message anymore, but keep sniffed content type in a separate
571         variable.
572
573         * platform/network/soup/ResourceHandleSoup.cpp:
574         (WebCore::contentSniffedCallback):
575         * platform/network/soup/ResourceResponse.h:
576         (WebCore::ResourceResponse::sniffedContentType):
577         (WebCore::ResourceResponse::setSniffedContentType):
578         * platform/network/soup/ResourceResponseSoup.cpp:
579         (WebCore::ResourceResponse::updateFromSoupMessage):
580
581 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
582
583         Reviewed by Andreas Kling.
584
585         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
586         https://bugs.webkit.org/show_bug.cgi?id=59704
587
588         No new tests, just code cleanup.
589
590         * WebCore.pri:
591
592 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
593
594         Reviewed by Pavel Feldman.
595
596         Web Inspector: remove "Pretty print" source frame context menu item.
597         https://bugs.webkit.org/show_bug.cgi?id=59709
598
599         * inspector/front-end/DebuggerPresentationModel.js:
600         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
601         * inspector/front-end/ScriptsPanel.js:
602         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
603         * inspector/front-end/SourceFrame.js:
604         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
605
606 2011-04-28  Satish Sampath  <satish@chromium.org>
607
608         Reviewed by Tony Gentilcore.
609
610         Speech input button layout issues with padding and border.
611         https://bugs.webkit.org/show_bug.cgi?id=59613
612
613         * rendering/RenderTextControlSingleLine.cpp:
614         (WebCore::RenderTextControlSingleLine::layout):
615         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
616         (WebCore::RenderTextControlSingleLine::forwardEvent):
617
618 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
619
620         Reviewed by Martin Robinson.
621
622         [GTK] Check whether to use native scrollbars at run time
623         https://bugs.webkit.org/show_bug.cgi?id=59694
624
625         It's currently decided at build time depending on whether webkit2
626         build is enabled or not. That makes imposible to build both
627         webkit1 and webkit2 using the same libWebCore.
628
629         * GNUmakefile.am:
630         * platform/ScrollView.cpp:
631         (WebCore::ScrollView::wheelEvent):
632         * platform/gtk/ScrollViewGtk.cpp:
633         (WebCore::ScrollView::createScrollbar):
634
635 2011-04-28  Pavel Feldman  <pfeldman@google.com>
636
637         Reviewed by Yury Semikhatsky.
638
639         Web Inspector: add status bar button for pretty print.
640         https://bugs.webkit.org/show_bug.cgi?id=59467
641
642         * WebCore.gypi:
643         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
644         * inspector/front-end/ScriptsPanel.js:
645         (WebInspector.ScriptsPanel):
646         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
647         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
648         * inspector/front-end/WebKit.qrc:
649         * inspector/front-end/inspector.css:
650         (.scripts-toggle-pretty-print-status-bar-item .glyph):
651         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
652
653 2011-04-28  Pavel Feldman  <pfeldman@google.com>
654
655         Reviewed by Yury Semikhatsky.
656
657         Web Inspector: add ResourceTreeModel tests.
658         https://bugs.webkit.org/show_bug.cgi?id=59616
659
660         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
661                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
662                http/tests/inspector/resource-tree/resource-tree-reload.html
663
664         * inspector/front-end/ResourceTreeModel.js:
665         (WebInspector.ResourceTreeModel.prototype.frontendReused):
666         (WebInspector.ResourceTreeModel.prototype._addFrame):
667         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
668         (WebInspector.ResourceTreeModel.prototype._frameDetached):
669         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
670         (WebInspector.ResourceTreeModel.prototype.forAllResources):
671         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
672         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
673         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
674         * inspector/front-end/ResourcesPanel.js:
675         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
676         (WebInspector.ResourcesPanel.prototype._frameAdded):
677         (WebInspector.ResourcesPanel.prototype._frameDetached):
678         (WebInspector.ResourcesPanel.prototype._frameNavigated):
679         (WebInspector.FrameTreeElement):
680         (WebInspector.FrameTreeElement.prototype.frameNavigated):
681
682 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
683
684         Reviewed by Yury Semikhatsky.
685
686         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
687         https://bugs.webkit.org/show_bug.cgi?id=59592
688
689         * inspector/front-end/DetailedHeapshotGridNodes.js:
690         (WebInspector.HeapSnapshotGridNode.prototype._populate):
691         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
692         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
693         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
694         * inspector/front-end/DetailedHeapshotView.js:
695         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
696         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
697         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
698         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
699         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
700         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
701         (WebInspector.DetailedHeapshotView.prototype.changeView):
702         * inspector/front-end/HeapSnapshot.js:
703         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
704         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
705         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
706         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
707         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
708         * inspector/front-end/heapProfiler.css:
709         (div.retaining-paths-view td.path-column div:hover):
710
711 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
712
713         Reviewed by Yury Semikhatsky.
714
715         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
716         https://bugs.webkit.org/show_bug.cgi?id=59454
717
718         Test: inspector/profiler/heap-snapshot-loader.html
719
720         * inspector/front-end/HeapSnapshot.js:
721         (WebInspector.HeapSnapshotLoader):
722         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
723         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
724         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
725         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
726         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
727         * inspector/front-end/HeapSnapshotProxy.js:
728         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
729
730 2011-04-28  ojab  <ojab@ojab.ru>
731
732         Reviewed by David Levin.
733
734         Fix build with libpng-1.5.1
735         https://bugs.webkit.org/show_bug.cgi?id=59607
736
737         * platform/image-decoders/png/PNGImageDecoder.cpp:
738         (WebCore::readColorProfile):
739
740 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
741
742         Reviewed by Nikolas Zimmermann.
743
744         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
745         https://bugs.webkit.org/show_bug.cgi?id=59447
746
747         This patch contains two sub-routines, one for speeding up
748         alpha channel only gaussian blur (by 2.5 times) and one
749         for speeding up all channel blur (by 4 times).
750
751         The common code is also redesigned to better fit for platform
752         specific code. This means large chunks of code was moved to
753         different files, and all platform specific files are added to
754         all build systems.
755
756         * CMakeLists.txt:
757         * GNUmakefile.am:
758         * GNUmakefile.list.am:
759         * WebCore.gypi:
760         * WebCore.pro:
761         * WebCore.vcproj/WebCore.vcproj:
762         * WebCore.vcproj/WebCoreCommon.vsprops:
763         * WebCore.xcodeproj/project.pbxproj:
764         * platform/graphics/filters/FEGaussianBlur.cpp:
765         (WebCore::FEGaussianBlur::platformApplyGeneric):
766         (WebCore::FEGaussianBlur::apply):
767         * platform/graphics/filters/FEGaussianBlur.h:
768         (WebCore::FEGaussianBlur::kernelPosition):
769         (WebCore::FEGaussianBlur::platformApply):
770         * platform/graphics/filters/FELighting.cpp:
771         (WebCore::FELighting::platformApplyGeneric):
772         (WebCore::FELighting::drawLighting):
773         * platform/graphics/filters/FELighting.h:
774         (WebCore::FELighting::platformApply):
775         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
776         (WebCore::WTF_ALIGNED):
777         (WebCore::feGaussianBlurConstantsForNeon):
778         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
779         (WebCore::FEGaussianBlur::platformApplyNeon):
780         * platform/graphics/filters/arm/FELightingNEON.cpp:
781         (WebCore::WTF_ALIGNED):
782         (WebCore::FELighting::getPowerCoefficients):
783         * platform/graphics/filters/arm/FELightingNEON.h:
784         (WebCore::FELighting::platformApplyNeon):
785
786 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
787
788         Reviewed by Yury Semikhatsky.
789
790         Web Inspector: provide a hotkey for script pause
791         https://bugs.webkit.org/show_bug.cgi?id=59593
792
793         In fact, F8 works as a hotkey, but this fact was not reflected
794         in the shortcut help popup.
795
796         * English.lproj/localizedStrings.js:
797         * inspector/front-end/ScriptsPanel.js:
798         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
799
800 2011-04-28  Adam Barth  <abarth@webkit.org>
801
802         Reviewed by Eric Seidel.
803
804         PluginStream should play nice with strict OwnPtr
805         https://bugs.webkit.org/show_bug.cgi?id=59675
806
807         These failures appear when enabling strict OwnPtr on Qt.
808
809         * plugins/PluginStream.cpp:
810         (WebCore::PluginStream::PluginStream):
811         (WebCore::PluginStream::didReceiveData):
812
813 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
814
815         Reviewed by Pavel Feldman.
816
817         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
818         https://bugs.webkit.org/show_bug.cgi?id=59326
819
820         Concrete CachedResource successors for stylesheets and scripts
821         can decode their content better than the generic approach we use.
822
823         * inspector/InspectorPageAgent.cpp:
824         (WebCore::decodeSharedBuffer):
825         (WebCore::prepareCachedResourceBuffer):
826         (WebCore::cachedResourceDecoded):
827         (WebCore::InspectorPageAgent::resourceContent):
828         (WebCore::InspectorPageAgent::resourceData):
829         * inspector/InspectorStyleSheet.cpp:
830         (WebCore::InspectorStyleSheet::originalStyleSheetText):
831
832 2011-04-28  Jon Lee  <jonlee@apple.com>
833
834         Reviewed by Simon Fraser.
835
836         REGRESSION: white overlay scrollbars on apple.com/startpage
837         https://bugs.webkit.org/show_bug.cgi?id=59540
838         <rdar://problem/9338653>
839
840         Now we look at the document background in addition to the <body> element,
841         and blend those colors in with the base background of the frame view to
842         arrive at our aggregate color. This provides a better result to determine
843         overlay scrollbar style.
844
845         * page/Frame.cpp:
846         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
847         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
848
849 2011-04-27  Adam Barth  <abarth@webkit.org>
850
851         Reviewed by Maciej Stachowiak.
852
853         Fix OwnPtr issues in IndexedDB
854         https://bugs.webkit.org/show_bug.cgi?id=59656
855
856         This patch is an attempt to fix the clang build.  Clang can't seem to
857         cope with OwnPtrs to classes declared in an anonymous namespace because
858         OwnPtr's copy constructor isn't defined (but would need to be defined
859         in this translation unit).
860
861         * platform/leveldb/LevelDBDatabase.cpp:
862
863 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
864
865         Reviewed by Antonio Gomes.
866
867         [EFL] Change cursor to LAZY_NATIVE_CURSOR
868         https://bugs.webkit.org/show_bug.cgi?id=59411
869
870         Enable LAZY_NATIVE_CURSOR on EFL build.
871
872         No test added because functionality is unchanged.
873
874         * CMakeListsEfl.txt: Add Cursor.cpp
875         * platform/Cursor.h:
876         (WebCore::Cursor::Cursor):
877         * platform/efl/CursorEfl.cpp:
878         (WebCore::Cursor::Cursor):
879         (WebCore::Cursor::~Cursor):
880         (WebCore::getCursorString):
881         (WebCore::Cursor::ensurePlatformCursor):
882         * platform/efl/WidgetEfl.cpp:
883         (WebCore::Widget::setCursor):
884
885 2011-04-27  Adam Barth  <abarth@webkit.org>
886
887         Build fix from the future.  Another trival strict OwnPtr fixes.  This
888         is the last futuristic build fix I can detect with my time traveling
889         abilities.
890
891         * platform/graphics/chromium/TransparencyWin.cpp:
892         (WebCore::TransparencyWin::initializeNewContext):
893
894 2011-04-27  Dmitry Lomov  <dslomov@google.com>
895
896         Reviewed by David Levin.
897
898         CrossThreadCopier should not have a default specialization for raw pointers
899         https://bugs.webkit.org/show_bug.cgi?id=59234
900         Removed the ablity to pass raw pointers cross-thread
901         Added and applied annotations for doing that
902
903         * fileapi/FileReader.cpp:
904         (WebCore::FileReader::readInternal):
905         (WebCore::FileReader::abort):
906         * fileapi/FileStreamProxy.cpp:
907         (WebCore::FileStreamProxy::startOnFileThread):
908         (WebCore::FileStreamProxy::stopOnFileThread):
909         (WebCore::FileStreamProxy::getSize):
910         (WebCore::FileStreamProxy::getSizeOnFileThread):
911         (WebCore::FileStreamProxy::openForRead):
912         (WebCore::FileStreamProxy::openForReadOnFileThread):
913         (WebCore::FileStreamProxy::openForWrite):
914         (WebCore::FileStreamProxy::openForWriteOnFileThread):
915         (WebCore::FileStreamProxy::close):
916         (WebCore::FileStreamProxy::read):
917         (WebCore::FileStreamProxy::readOnFileThread):
918         (WebCore::FileStreamProxy::write):
919         (WebCore::FileStreamProxy::writeOnFileThread):
920         (WebCore::FileStreamProxy::truncate):
921         (WebCore::FileStreamProxy::truncateOnFileThread):
922         * loader/WorkerThreadableLoader.cpp:
923         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
924         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
925         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
926         * page/GeolocationPositionCache.cpp:
927         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
928         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
929         * platform/CrossThreadCopier.h:
930         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
931         (WebCore::AllowCrossThreadAccessWrapper::value):
932         (WebCore::AllowCrossThreadAccess):
933         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
934         (WebCore::AllowExtendedLifetimeWrapper::value):
935         (WebCore::AllowExtendedLifetime):
936         * platform/graphics/chromium/cc/CCCompletionEvent.h:
937         * storage/IDBObjectStoreBackendImpl.cpp:
938         (WebCore::IDBObjectStoreBackendImpl::get):
939         (WebCore::IDBObjectStoreBackendImpl::put):
940         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
941         (WebCore::IDBObjectStoreBackendImpl::clear):
942         (WebCore::IDBObjectStoreBackendImpl::createIndex):
943         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
944         (WebCore::IDBObjectStoreBackendImpl::openCursor):
945         * storage/SQLCallbackWrapper.h:
946         (WebCore::SQLCallbackWrapper::clear):
947         * websockets/WorkerThreadableWebSocketChannel.cpp:
948         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
949         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
950         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
951         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
952         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
953         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
954         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
955         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
956         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
957         * workers/WorkerMessagingProxy.cpp:
958         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
959
960 2011-04-27  Adam Barth  <abarth@webkit.org>
961
962         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
963
964         * page/Frame.cpp:
965         (WebCore::Frame::setTiledBackingStoreEnabled):
966         * platform/audio/ReverbConvolver.cpp:
967         (WebCore::ReverbConvolver::ReverbConvolver):
968
969 2011-04-27  Adam Barth  <abarth@webkit.org>
970
971         Reviewed by David Levin.
972
973         Fix five strict PassOwnPtr violations in WebCore
974         https://bugs.webkit.org/show_bug.cgi?id=59640
975
976         * css/MediaList.cpp:
977         (WebCore::MediaList::deleteMedium):
978         (WebCore::MediaList::setMediaText):
979         (WebCore::MediaList::appendMedium):
980         * css/MediaQuery.h:
981         * dom/MessagePort.cpp:
982         (WebCore::MessagePort::disentanglePorts):
983         (WebCore::MessagePort::entanglePorts):
984         * inspector/InspectorStyleSheet.cpp:
985         (ParsedStyleSheet::setText):
986         * rendering/RenderTheme.cpp:
987         (WebCore::RenderTheme::adjustStyle):
988         (WebCore::RenderTheme::adjustMeterStyle):
989         * rendering/RenderThemeMac.mm:
990         (WebCore::RenderThemeMac::adjustMenuListStyle):
991         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
992         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
993         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
994         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
995         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
996         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
997         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
998
999 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
1000
1001         Reviewed by Beth Dakin.
1002
1003         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
1004         https://bugs.webkit.org/show_bug.cgi?id=59648
1005
1006         Test: accessibility/aria-fallback-roles.html
1007
1008         * accessibility/AccessibilityObject.cpp:
1009         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
1010
1011 2011-04-27  Beth Dakin  <bdakin@apple.com>
1012
1013         Reviewed by Dan Bernstein.
1014
1015         https://bugs.webkit.org/show_bug.cgi?id=59671
1016         Race condition with scrollbar animations and closing a page can cause a crash in 
1017         WebCore::FrameView::setVisibleScrollerThumbRect + 15
1018         -and corresponding-
1019         <rdar://problem/9329253>
1020
1021         It is definitely possible for Page to be null here. So we should null-check it! 
1022         And we should not ASSERT.
1023         * page/FrameView.cpp:
1024         (WebCore::FrameView::didCompleteRubberBand):
1025         (WebCore::FrameView::scrollbarStyleChanged):
1026         (WebCore::FrameView::setVisibleScrollerThumbRect):
1027
1028 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1029
1030         WinCE build fix after r85143.
1031
1032         * platform/graphics/wince/FontWinCE.cpp:
1033         (WebCore::TextRunComponent::TextRunComponent):
1034
1035 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
1036
1037         Reviewed by Tony Chang.
1038
1039         IndexedDB object store delete should fail if key is null
1040         https://bugs.webkit.org/show_bug.cgi?id=58614
1041
1042         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
1043
1044         * storage/IDBObjectStoreBackendImpl.cpp:
1045         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1046
1047 2011-04-27  Eric Seidel  <eric@webkit.org>
1048
1049         Reviewed by Ryosuke Niwa.
1050
1051         Should have an easy way to construct starting BidiStatus for a paragraph root
1052         https://bugs.webkit.org/show_bug.cgi?id=59226
1053
1054         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
1055         I've made this a constructor for BidiStatus instead.
1056
1057         As part of this effort I added a direction() accessor for TextRun and got
1058         rid of the old m_rtl bool.  This is part of the generic effort in the
1059         Bidi code to replace old bool usage with the superior TextDirection enum
1060         (this generally makes the code cleaner).
1061
1062         As part of this replacement effort I found several places which were
1063         assuming LTR (by passing rtl=false) when they probably want to use
1064         the current text direction.  I suspect that LTR vs. RTL may affect
1065         string width in the case of ligatures.  It's unclear.
1066
1067         This is almost entirely a mechanical change.
1068
1069         * html/canvas/CanvasRenderingContext2D.cpp:
1070         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1071         * platform/graphics/GraphicsContext.cpp:
1072         (WebCore::GraphicsContext::drawBidiText):
1073         * platform/graphics/TextRun.h:
1074         (WebCore::TextRun::TextRun):
1075         (WebCore::TextRun::direction):
1076         (WebCore::TextRun::rtl):
1077         (WebCore::TextRun::ltr):
1078         (WebCore::TextRun::setDirection):
1079         * platform/text/BidiResolver.h:
1080         (WebCore::BidiStatus::BidiStatus):
1081         * rendering/EllipsisBox.cpp:
1082         (WebCore::EllipsisBox::paint):
1083         (WebCore::EllipsisBox::selectionRect):
1084         (WebCore::EllipsisBox::paintSelection):
1085         * rendering/InlineTextBox.cpp:
1086         (WebCore::InlineTextBox::selectionRect):
1087         (WebCore::InlineTextBox::paint):
1088         (WebCore::InlineTextBox::paintSelection):
1089         (WebCore::InlineTextBox::paintCompositionBackground):
1090         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1091         (WebCore::InlineTextBox::paintTextMatchMarker):
1092         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1093         (WebCore::InlineTextBox::offsetForPosition):
1094         (WebCore::InlineTextBox::positionForOffset):
1095         * rendering/RenderBlockLineLayout.cpp:
1096         (WebCore::RenderBlock::determineStartPosition):
1097         * rendering/RenderFileUploadControl.cpp:
1098         (WebCore::RenderFileUploadControl::paintObject):
1099         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1100         * rendering/RenderListBox.cpp:
1101         (WebCore::RenderListBox::updateFromElement):
1102         (WebCore::RenderListBox::paintItemForeground):
1103         * rendering/RenderTextControl.cpp:
1104         (WebCore::RenderTextControl::getAvgCharWidth):
1105         (WebCore::RenderTextControl::paintPlaceholder):
1106         * rendering/svg/SVGInlineTextBox.cpp:
1107         (WebCore::SVGInlineTextBox::constructTextRun):
1108         * rendering/svg/SVGTextMetrics.cpp:
1109         (WebCore::constructTextRun):
1110
1111 2011-04-27  Robert Hogan  <robert@webkit.org>
1112
1113         Reviewed by Adam Barth.
1114
1115         Allow shadowing of history object
1116         https://bugs.webkit.org/show_bug.cgi?id=55965
1117
1118         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1119                http/tests/history/cross-origin-replace-history-object.html
1120
1121         * page/DOMWindow.idl:
1122
1123 2011-04-27  James Robinson  <jamesr@chromium.org>
1124
1125         Reviewed by Kenneth Russell.
1126
1127         [chromium] Ensure compositing layers are up to date before entering doComposite
1128         https://bugs.webkit.org/show_bug.cgi?id=59159
1129
1130         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1131         GraphicsLayerClient::paintContents() implementations).
1132
1133         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1134         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1135         * platform/graphics/chromium/LayerChromium.cpp:
1136         (WebCore::LayerChromium::LayerChromium):
1137         (WebCore::LayerChromium::~LayerChromium):
1138         * platform/graphics/chromium/LayerRendererChromium.cpp:
1139         (WebCore::LayerRendererChromium::updateLayers):
1140         * platform/graphics/chromium/LayerRendererChromium.h:
1141           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1142
1143 2011-04-27  James Robinson  <jamesr@chromium.org>
1144
1145         Reviewed by Adam Barth.
1146
1147         Fix OwnPtr strict issues in chromium linux build
1148         https://bugs.webkit.org/show_bug.cgi?id=59664
1149
1150         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1151         (WebCore::ComplexTextController::getNormalizedTextRun):
1152         * platform/graphics/skia/ImageBufferSkia.cpp:
1153         (WebCore::ImageBuffer::ImageBuffer):
1154         * platform/graphics/skia/PlatformContextSkia.cpp:
1155         (WebCore::PlatformContextSkia::PlatformContextSkia):
1156
1157 2011-04-27  Chris Rogers  <crogers@google.com>
1158
1159         Reviewed by Kenneth Russell.
1160
1161         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1162         https://bugs.webkit.org/show_bug.cgi?id=59641
1163
1164         No new tests since audio API is not yet implemented.
1165
1166         * platform/audio/AudioBus.cpp:
1167         (WebCore::AudioBus::createBySampleRateConverting):
1168         (WebCore::AudioBus::createByMixingToMono):
1169
1170 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1171
1172         Motivated by Alexey Proskuryakov.
1173
1174         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1175         informative, since it confused Alexey and me.
1176
1177 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1178
1179         Reviewed by Sam Weinig.
1180
1181         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1182         https://bugs.webkit.org/show_bug.cgi?id=59646
1183
1184         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1185         a world, we need to clear all entries in the map for that world, since
1186         the finalizers that would otherwise clear those entries don't run. The
1187         simplest way to do this is just to make the world own the map.
1188         
1189         * bindings/js/DOMWrapperWorld.h:
1190         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1191         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1192         * bindings/js/JSCSSValueCustom.cpp:
1193         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1194         (WebCore::JSCSSValueOwner::finalize):
1195         * bindings/js/JSDOMBinding.h:
1196
1197 2011-04-27  Adam Barth  <abarth@webkit.org>
1198
1199         Reviewed by David Levin.
1200
1201         Fix OwnPtr issues in IndexedDB
1202         https://bugs.webkit.org/show_bug.cgi?id=59656
1203
1204         I didn't do an exhaustive review of this code, but I fixed the problems
1205         caught by turning on strict OwnPtr and all their antecedents.  This
1206         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1207         behavior change.
1208
1209         * platform/leveldb/LevelDBDatabase.cpp:
1210         (WebCore::LevelDBDatabase::LevelDBDatabase):
1211         (WebCore::LevelDBDatabase::open):
1212         (WebCore::LevelDBDatabase::createIterator):
1213         * platform/leveldb/LevelDBDatabase.h:
1214         * platform/leveldb/LevelDBIterator.cpp:
1215         (WebCore::LevelDBIterator::LevelDBIterator):
1216         * platform/leveldb/LevelDBIterator.h:
1217         * storage/IDBLevelDBBackingStore.cpp:
1218         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1219         (WebCore::IDBLevelDBBackingStore::open):
1220         (WebCore::getNewDatabaseId):
1221         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1222         (WebCore::getNewObjectStoreId):
1223         (WebCore::deleteRange):
1224         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1225         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1226         (WebCore::IDBLevelDBBackingStore::getIndexes):
1227         (WebCore::getNewIndexId):
1228         (WebCore::findGreatestKeyLessThan):
1229         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1230         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1231         (WebCore::findLastIndexKeyEqualTo):
1232         * storage/IDBLevelDBBackingStore.h:
1233
1234 2011-04-19  MORITA Hajime  <morrita@google.com>
1235
1236         Reviewed by Tony Chang.
1237
1238         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1239         https://bugs.webkit.org/show_bug.cgi?id=58113
1240
1241         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1242         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1243         * Now MarkerMapVectorPair is no longer used.
1244         
1245         No new tests, No behavior change.
1246
1247         * GNUmakefile.list.am:
1248         * WebCore.gypi:
1249         * WebCore.pro:
1250         * WebCore.vcproj/WebCore.vcproj:
1251         * WebCore.xcodeproj/project.pbxproj:
1252         * dom/DocumentMarker.h:
1253         * dom/DocumentMarkerController.cpp:
1254         (WebCore::DocumentMarkerController::addMarker):
1255         (WebCore::DocumentMarkerController::copyMarkers):
1256         (WebCore::DocumentMarkerController::removeMarkers):
1257         (WebCore::DocumentMarkerController::markerContainingPoint):
1258         (WebCore::DocumentMarkerController::markersForNode):
1259         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1260         (WebCore::DocumentMarkerController::removeMarkersFromList):
1261         (WebCore::DocumentMarkerController::repaintMarkers):
1262         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1263         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1264         (WebCore::DocumentMarkerController::shiftMarkers):
1265         (WebCore::DocumentMarkerController::setMarkersActive):
1266         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1267         (WebCore::DocumentMarkerController::showMarkers):
1268         * dom/DocumentMarkerController.h:
1269         * dom/RenderedDocumentMarker.h: Added.
1270         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1271         (WebCore::RenderedDocumentMarker::isRendered):
1272         (WebCore::RenderedDocumentMarker::contains):
1273         (WebCore::RenderedDocumentMarker::setRenderedRect):
1274         (WebCore::RenderedDocumentMarker::renderedRect):
1275         (WebCore::RenderedDocumentMarker::invalidate):
1276         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1277
1278 2011-04-27  James Robinson  <jamesr@chromium.org>
1279
1280         Unreviewed, rolling out r85112.
1281         http://trac.webkit.org/changeset/85112
1282         https://bugs.webkit.org/show_bug.cgi?id=59159
1283
1284         Broke mac compile
1285
1286         * page/FrameView.cpp:
1287         (WebCore::FrameView::updateCompositingLayers):
1288         * page/FrameView.h:
1289         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1290         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1291         * platform/graphics/chromium/LayerChromium.cpp:
1292         (WebCore::LayerChromium::LayerChromium):
1293         (WebCore::LayerChromium::~LayerChromium):
1294         * platform/graphics/chromium/LayerRendererChromium.cpp:
1295         (WebCore::LayerRendererChromium::updateLayers):
1296         * platform/graphics/chromium/LayerRendererChromium.h:
1297
1298 2011-04-27  Mark Rowe  <mrowe@apple.com>
1299
1300         Build fix.
1301
1302         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1303
1304 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1305
1306         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1307
1308         * platform/network/ResourceHandleClient.h:
1309
1310 2011-04-27  James Robinson  <jamesr@chromium.org>
1311
1312         Reviewed by Kenneth Russell.
1313
1314         [chromium] Ensure compositing layers are up to date before entering doComposite
1315         https://bugs.webkit.org/show_bug.cgi?id=59159
1316
1317         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1318         GraphicsLayerClient::paintContents() implementations).
1319
1320         * page/FrameView.cpp:
1321         (WebCore::FrameView::updateCompositingLayers):
1322             Add an optional CompositingUpdateType parameter.
1323         * page/FrameView.h:
1324         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1325         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1326         * platform/graphics/chromium/LayerChromium.cpp:
1327         (WebCore::LayerChromium::LayerChromium):
1328         (WebCore::LayerChromium::~LayerChromium):
1329         * platform/graphics/chromium/LayerRendererChromium.cpp:
1330         (WebCore::LayerRendererChromium::updateLayers):
1331         * platform/graphics/chromium/LayerRendererChromium.h:
1332           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1333         * rendering/RenderLayer.cpp:
1334         (WebCore::RenderLayer::dirtyZOrderLists):
1335         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1336         * rendering/RenderLayerCompositor.cpp:
1337         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1338         * rendering/RenderLayerCompositor.h:
1339           Fix a typo in CompositingUpdateType Pait->Paint
1340
1341 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1342
1343         Reviewed by Antti Koivisto.
1344
1345         Part of WebCore should use CFNetwork-based loader on Mac
1346         https://bugs.webkit.org/show_bug.cgi?id=51836
1347
1348         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1349         willCacheResponse/shouldCacheResponse.
1350
1351         * loader/EmptyClients.h:
1352         * loader/FrameLoaderClient.h:
1353         * loader/ResourceLoader.h:
1354         * loader/cf/ResourceLoaderCFNet.cpp:
1355         * loader/mac/ResourceLoaderMac.mm:
1356         (WebCore::ResourceLoader::willCacheResponse):
1357         * platform/network/ResourceHandleClient.h:
1358         (WebCore::ResourceHandleClient::willCacheResponse):
1359         (WebCore::ResourceHandleClient::shouldCacheResponse):
1360         * platform/network/cf/ResourceHandleCFNet.cpp:
1361         (WebCore::willCacheResponse):
1362
1363 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
1364
1365         Reviewed by Brian Weinstein.
1366
1367         Web Inspector: Stop on Exception state does not persist.
1368
1369         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
1370         https://bugs.webkit.org/show_bug.cgi?id=59630
1371
1372         * inspector/front-end/ScriptsPanel.js:
1373         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1374         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1375         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1376
1377 2011-04-27  Adrienne Walker  <enne@google.com>
1378
1379         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
1380         https://bugs.webkit.org/show_bug.cgi?id=59020
1381
1382         * platform/graphics/chromium/LayerRendererChromium.cpp:
1383         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1384
1385 2011-04-27  Darin Adler  <darin@apple.com>
1386
1387         Reviewed by David Levin.
1388
1389         Fix strict OwnPtr issues seen in about 30 more files
1390         https://bugs.webkit.org/show_bug.cgi?id=59615
1391
1392         * bindings/js/JSCallbackData.h:
1393         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
1394         * bindings/js/JSMessageEventCustom.cpp:
1395         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
1396         * css/CSSParser.cpp:
1397         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
1398         adoptPtr, and release.
1399         * dom/MessageEvent.cpp:
1400         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
1401         and release.
1402         * dom/MessagePortChannel.cpp:
1403         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
1404         * dom/ScriptExecutionContext.cpp:
1405         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
1406         * dom/XMLDocumentParserLibxml2.cpp:
1407         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
1408         * dom/default/PlatformMessagePortChannel.cpp:
1409         (WebCore::MessagePortChannel::create): Use adoptPtr.
1410         * html/HTMLFormControlElement.cpp:
1411         (WebCore::HTMLFormControlElement::detach): Use nullptr.
1412         * inspector/InspectorAgent.cpp:
1413         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
1414         * inspector/InspectorConsoleAgent.cpp:
1415         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
1416         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
1417         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
1418         * inspector/InspectorController.cpp:
1419         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
1420         * inspector/InspectorDOMAgent.cpp:
1421         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
1422         * inspector/InspectorResourceAgent.cpp:
1423         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1424         * page/FrameActionScheduler.cpp:
1425         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1426         * platform/graphics/ShadowBlur.cpp:
1427         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1428         * platform/graphics/ca/GraphicsLayerCA.cpp:
1429         (WebCore::GraphicsLayer::create): Use adoptPtr.
1430         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1431         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1432         * rendering/RenderBlock.cpp:
1433         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1434         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1435         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
1436         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
1437         * rendering/RenderLayerBacking.cpp:
1438         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
1439         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
1440         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
1441         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
1442         * rendering/RenderLayerCompositor.cpp:
1443         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
1444         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
1445         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
1446         * rendering/style/StyleRareNonInheritedData.cpp:
1447         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
1448         explicit initializations of OwnPtr members to 0. Use adoptPtr.
1449         * workers/SharedWorkerContext.cpp:
1450         (WebCore::createConnectEvent): Use adoptPtr.
1451         * workers/Worker.cpp:
1452         (WebCore::Worker::notifyFinished): Use nullptr.
1453
1454 2011-04-27  Enrica Casucci  <enrica@apple.com>
1455
1456         Reviewed by Darin Adler.
1457
1458         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
1459         https://bugs.webkit.org/show_bug.cgi?id=59251
1460         <rdar://problem/9327044>
1461
1462         When we are looking for wrapping elements that are presentational, we should
1463         include elements that have a non transparent background color only if they
1464         are not blocks.
1465
1466         Test: editing/pasteboard/do-not-copy-body-color.html
1467
1468         * editing/markup.cpp:
1469         (WebCore::isElementPresentational):
1470
1471 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
1472
1473         Reviewed by Antti Koivisto.
1474
1475         Teach sub-selector chains about shadow descendants
1476         https://bugs.webkit.org/show_bug.cgi?id=58342
1477
1478         The primary change is to the logic of parsing specifiers:
1479         1) The shadow descendant selectors (those specifiers that are unknown
1480         pseudo element selectors) are always kept at the top of the chain.
1481         2) The sub-selectors after shadow descendant selectors are stashed right
1482         behind the sub-selector, but not at the end of the chain.
1483         3) Other sub-selectors are appended at the end of the chain.
1484
1485         * css/CSSGrammar.y: Changed specifier_list collection to use new
1486             CSSParser::updateSpecifier helper.
1487         * css/CSSParser.cpp:
1488         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
1489             look for the last ShadowDescendant relation in the chain of selectors,
1490             because the next selector after it is the one that should get the
1491             element name.
1492         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
1493             CSSGrammar.y. The new logic adjusts the selector chain to allow
1494             shadow descendant selectors have sub-selectors (and have multiple shadow
1495             descendants in the chain).
1496         * css/CSSParser.h: Added decl.
1497         * css/CSSParserValues.cpp:
1498         (WebCore::CSSParserSelector::insertTagHistory): Added.
1499         (WebCore::CSSParserSelector::appendTagHistory): Aded.
1500         * css/CSSParserValues.h: Added decls.
1501         * css/CSSStyleSelector.cpp:
1502         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
1503             shadow descendant selector match check, since now there could be many
1504             of them in the selector chain.
1505
1506 2011-04-20  Adrienne Walker  <enne@google.com>
1507
1508         Reviewed by Kenneth Russell.
1509
1510         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
1511         https://bugs.webkit.org/show_bug.cgi?id=59020
1512
1513         mapRect is the incorrect transform here.  The parent scissor rect
1514         needs to be projected into layer space instead.
1515
1516         Test: compositing/flat-with-transformed-child.html
1517
1518         * platform/graphics/chromium/LayerRendererChromium.cpp:
1519         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1520
1521 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1522
1523         Reviewed by Antti Koivisto.
1524
1525         Part of WebCore should use CFNetwork-based loader on Mac
1526         https://bugs.webkit.org/show_bug.cgi?id=51836
1527
1528         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
1529         * platform/mac/SoftLinking.h:
1530         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
1531
1532 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
1533
1534         Reviewed by Antti Koivisto.
1535
1536         Cleanup CSSStyleApplyProperty.cpp
1537         https://bugs.webkit.org/show_bug.cgi?id=59623
1538
1539         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
1540         Use typedefs instead of repating the function pointer declarations in a few places.
1541
1542         * css/CSSStyleApplyProperty.cpp:
1543         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
1544         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
1545         (WebCore::ApplyPropertyColor::applyInheritValue):
1546         (WebCore::ApplyPropertyColor::applyInitialValue):
1547         (WebCore::ApplyPropertyColor::applyValue):
1548         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
1549
1550 2011-04-27  Dan Bernstein  <mitz@apple.com>
1551
1552         Reviewed by Anders Carlsson.
1553
1554         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
1555         https://bugs.webkit.org/show_bug.cgi?id=59622
1556
1557         Test: fast/borders/border-image-trumps-radius.html
1558
1559         * rendering/RenderBox.cpp:
1560         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
1561         image, then border radius is ignored, so no bleed avoidance is needed.
1562         * rendering/RenderObject.cpp:
1563         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
1564         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
1565         * rendering/RenderObject.h:
1566
1567 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1568
1569         Reviewed by Xan Lopez.
1570
1571         [GTK] editing/pasteboard/copy-standalone-image.html fails
1572         https://bugs.webkit.org/show_bug.cgi?id=53645
1573
1574         When writing an image to the clipboard, also write the URL and title
1575         into the markup and URL portion. This change also abstracts a helper
1576         imageToMarkup into markup.{cpp/h} from several different locations
1577         throughout the platform layer.
1578
1579         * editing/markup.h: Added new function definition.
1580         * editing/markup.cpp:
1581         (WebCore::imageToMarkup): Add this function which turns an image URL 
1582         and element into some markup representing that image, while preserving
1583         non-src attributes.
1584         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
1585         to markup.cpp.
1586         * platform/gtk/PasteboardGtk.cpp:
1587         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
1588         image URL for a variety of image tag types.
1589         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
1590         markup and URL portions of the clipboard. This will ensure that images
1591         paste properly back into WebKit.
1592         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
1593         one from markup.h
1594
1595 2011-04-27  Steve Block  <steveblock@google.com>
1596
1597         Reviewed by David Levin.
1598
1599         Remove Android build system
1600         https://bugs.webkit.org/show_bug.cgi?id=48111
1601
1602         This is to avoid the maintenance burden until the Android port is
1603         fully upstreamed.
1604
1605         No new tests, build change only.
1606
1607         * Android.derived.jscbindings.mk: Removed.
1608         * Android.derived.mk: Removed.
1609         * Android.derived.v8bindings.mk: Removed.
1610         * Android.jscbindings.mk: Removed.
1611         * Android.mk: Removed.
1612         * Android.v8bindings.mk: Removed.
1613
1614 2011-04-27  Darin Adler  <darin@apple.com>
1615
1616         Reviewed by Sam Weinig.
1617
1618         Somehow about:blank gets into the icon database
1619         https://bugs.webkit.org/show_bug.cgi?id=58067
1620         rdar://problem/6751446
1621
1622         Implemented the policy Brady suggested, where only http and https URLs can
1623         be associated with and icon, guarding both on the way in to the database,
1624         and on the way out.
1625
1626         * loader/icon/IconDatabase.cpp:
1627         (WebCore::pageCanHaveIcon): Added.
1628         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
1629         instead of just checking for an empty URL.
1630         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
1631         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
1632         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
1633         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
1634         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
1635         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
1636         two separate assertions and added a third.
1637         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
1638
1639         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
1640         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
1641         overloaded it to work on both UChar and char, and added an assertion to it.
1642         Also moved this to the top of the file and made the UChar version usable
1643         in the shared code used even by Google.
1644         (WebCore::KURL::invalidate): Updated for name change.
1645         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
1646         toASCIILower since it's faster.
1647         (WebCore::KURL::parse): Updated for name changes.
1648         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
1649         since it's faster.
1650         (WebCore::protocolIsInHTTPFamily): Added.
1651
1652         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
1653         to protocolIsInHTTPFamily and added a version that works on a string.
1654         Kept the old name as an inline function so we don't have to rename
1655         all the cal sites now.
1656
1657         * platform/KURLGoogle.cpp: Renamed as above.
1658         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
1659         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
1660         (WebCore::KURLGooglePrivate::setAscii): Ditto.
1661         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
1662         (WebCore::KURLGooglePrivate::copyTo): Ditto.
1663         (WebCore::KURL::KURL): Ditto.
1664         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
1665         (WebCore::KURL::invalidate): Ditto.
1666         * platform/KURLGooglePrivate.h: Ditto.
1667
1668         * WebCore.exp.in: Updated for above changes.
1669
1670 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1671
1672         Reviewed by Pavel Feldman.
1673
1674         Web Inspector: browser crash on evaluation of 'throw undefined'
1675         https://bugs.webkit.org/show_bug.cgi?id=59611
1676
1677         Test: inspector/console/console-eval-throw-undefined.html
1678
1679         * inspector/InjectedScriptSource.js: use try/catch to protect from
1680         exception during conversion of another exception to string.
1681
1682 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1683
1684         Reviewed by Yury Semikhatsky.
1685
1686         Web Inspector: clicking bookmarklet multiplies resources panel entries.
1687         https://bugs.webkit.org/show_bug.cgi?id=59590
1688
1689         * inspector/front-end/ResourceTreeModel.js:
1690         (WebInspector.ResourceTreeModel):
1691         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
1692         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1693         * inspector/front-end/ResourcesPanel.js:
1694         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1695         (WebInspector.FrameTreeElement):
1696         (WebInspector.FrameTreeElement.prototype.appendResource):
1697         * inspector/front-end/inspector.js:
1698         (WebInspector.frontendReused):
1699
1700 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1701
1702         Reviewed by Yury Semikhatsky.
1703
1704         Web Inspector: opening bookmarklet disconnects DOM agent.
1705         https://bugs.webkit.org/show_bug.cgi?id=59588
1706
1707         * inspector/InspectorDOMAgent.cpp:
1708         (WebCore::InspectorDOMAgent::setDocument):
1709
1710 2011-04-27  Hans Wennborg  <hans@chromium.org>
1711
1712         Reviewed by Tony Gentilcore.
1713
1714         IndexedDB: Fix compiler warnings about uninitialized variables
1715         https://bugs.webkit.org/show_bug.cgi?id=59599
1716
1717         Build fix. No new tests.
1718
1719         * storage/IDBLevelDBBackingStore.cpp:
1720         (WebCore::getNewObjectStoreId):
1721         (WebCore::getNewIndexId):
1722
1723 2011-04-26  Hans Wennborg  <hans@chromium.org>
1724
1725         Reviewed by Tony Gentilcore.
1726
1727         IndexedDB: Move LevelDB key coding routines to separate file
1728         https://bugs.webkit.org/show_bug.cgi?id=59452
1729
1730         Move all routines concerned with encoding, decoding and comparison of
1731         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
1732         IDBLevelDBCoding.cpp.
1733
1734         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
1735         allow for unit testing of the coding routines.
1736
1737         No new functionality, no new tests.
1738
1739         * WebCore.gypi:
1740         * storage/IDBLevelDBBackingStore.cpp:
1741         (WebCore::getInt):
1742         (WebCore::putInt):
1743         (WebCore::getString):
1744         (WebCore::putString):
1745         (WebCore::compareKeys):
1746         (WebCore::compareIndexKeys):
1747         (WebCore::Comparator::compare):
1748         (WebCore::setUpMetadata):
1749         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
1750         (WebCore::getNewDatabaseId):
1751         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
1752         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1753         (WebCore::getNewObjectStoreId):
1754         (WebCore::IDBLevelDBBackingStore::createObjectStore):
1755         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
1756         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
1757         (WebCore::getNewVersionNumber):
1758         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
1759         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
1760         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
1761         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1762         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
1763         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1764         (WebCore::IDBLevelDBBackingStore::getIndexes):
1765         (WebCore::getNewIndexId):
1766         (WebCore::IDBLevelDBBackingStore::createIndex):
1767         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
1768         (WebCore::versionExists):
1769         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1770         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1771         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
1772         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
1773         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
1774         * storage/IDBLevelDBCoding.cpp: Added.
1775         (WebCore::IDBLevelDBCoding::encodeByte):
1776         (WebCore::IDBLevelDBCoding::maxIDBKey):
1777         (WebCore::IDBLevelDBCoding::minIDBKey):
1778         (WebCore::IDBLevelDBCoding::encodeInt):
1779         (WebCore::IDBLevelDBCoding::decodeInt):
1780         (WebCore::IDBLevelDBCoding::encodeVarInt):
1781         (WebCore::IDBLevelDBCoding::decodeVarInt):
1782         (WebCore::IDBLevelDBCoding::encodeString):
1783         (WebCore::IDBLevelDBCoding::decodeString):
1784         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
1785         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
1786         (WebCore::IDBLevelDBCoding::encodeDouble):
1787         (WebCore::IDBLevelDBCoding::decodeDouble):
1788         (WebCore::IDBLevelDBCoding::encodeIDBKey):
1789         (WebCore::IDBLevelDBCoding::decodeIDBKey):
1790         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
1791         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
1792         (WebCore::IDBLevelDBCoding::compare):
1793         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
1794         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
1795         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
1796         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
1797         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
1798         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
1799         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
1800         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
1801         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
1802         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
1803         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
1804         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
1805         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
1806         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
1807         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
1808         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
1809         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
1810         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
1811         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
1812         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
1813         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
1814         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
1815         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
1816         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
1817         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
1818         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
1819         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
1820         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
1821         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
1822         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
1823         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
1824         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
1825         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
1826         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
1827         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
1828         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
1829         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
1830         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
1831         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
1832         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
1833         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
1834         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
1835         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
1836         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
1837         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
1838         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
1839         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
1840         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
1841         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
1842         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
1843         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
1844         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
1845         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
1846         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
1847         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
1848         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
1849         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
1850         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
1851         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
1852         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
1853         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
1854         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
1855         * storage/IDBLevelDBCoding.h: Added.
1856         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
1857         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
1858         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
1859         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
1860         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
1861
1862 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1863
1864         Reviewed by Pavel Feldman.
1865
1866         Web Inspector: expose exception details when script is paused on exception
1867         https://bugs.webkit.org/show_bug.cgi?id=59591
1868
1869         When script is paused on an exception, the exception value is added as <exception>
1870         property in the local scope and the breakpoint details message says
1871         "Paused on excepion: '<exception to strin value>'."
1872
1873         * English.lproj/localizedStrings.js:
1874         * inspector/front-end/ScopeChainSidebarPane.js:
1875         (WebInspector.ScopeChainSidebarPane.prototype.update):
1876         * inspector/front-end/ScriptsPanel.js:
1877         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
1878         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
1879
1880 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
1881
1882         Reviewed by Pavel Feldman.
1883
1884         Web Inspector: [protocol] Paused event should expose exception value that caused it
1885         https://bugs.webkit.org/show_bug.cgi?id=58996
1886
1887         Debug.pause event now contains an optional reference to the exception
1888         object in case script execution is paused on a JavaScript exception.
1889
1890         Also JavaScript call frames are passed directly into the injected script when
1891         we need to wrap them for passing to the front-end. This change breaks cyclic
1892         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
1893
1894         * bindings/js/JSInjectedScriptHostCustom.cpp:
1895         * bindings/js/ScriptDebugServer.cpp:
1896         (WebCore::ScriptDebugServer::dispatchDidPause):
1897         * bindings/js/ScriptDebugServer.h:
1898         * bindings/v8/ScriptDebugServer.cpp:
1899         (WebCore::ScriptDebugServer::breakProgram):
1900         (WebCore::ScriptDebugServer::editScriptSource):
1901         (WebCore::ScriptDebugServer::breakProgramCallback):
1902         (WebCore::ScriptDebugServer::handleV8DebugEvent):
1903         * bindings/v8/ScriptDebugServer.h:
1904         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
1905         * inspector/InjectedScript.cpp:
1906         (WebCore::InjectedScript::evaluateOnCallFrame):
1907         (WebCore::InjectedScript::wrapCallFrames):
1908         * inspector/InjectedScript.h:
1909         * inspector/InjectedScriptHost.cpp:
1910         * inspector/InjectedScriptHost.h:
1911         (WebCore::InjectedScriptHost::init):
1912         * inspector/InjectedScriptHost.idl:
1913         * inspector/InjectedScriptSource.js:
1914         (.):
1915         * inspector/Inspector.json:
1916         * inspector/InspectorAgent.cpp:
1917         (WebCore::InspectorAgent::InspectorAgent):
1918         * inspector/InspectorDebuggerAgent.cpp:
1919         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
1920         (WebCore::InspectorDebuggerAgent::currentCallFrames):
1921         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
1922         (WebCore::InspectorDebuggerAgent::didPause):
1923         (WebCore::InspectorDebuggerAgent::didContinue):
1924         (WebCore::InspectorDebuggerAgent::clear):
1925         * inspector/InspectorDebuggerAgent.h:
1926         * inspector/ScriptDebugListener.h:
1927         * inspector/WorkerInspectorController.cpp:
1928         (WebCore::WorkerInspectorController::WorkerInspectorController):
1929
1930 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1931
1932         Reviewed by Yury Semikhatsky.
1933
1934         Web Inspector: implement incremental CSS editing in the structure view.
1935         https://bugs.webkit.org/show_bug.cgi?id=59455
1936
1937         * inspector/front-end/StylesSidebarPane.js:
1938         (WebInspector.StylePropertyTreeElement.prototype):
1939
1940 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
1941
1942         Reviewed by Eric Seidel.
1943
1944         Frame.h shouldn't include Document.h
1945         https://bugs.webkit.org/show_bug.cgi?id=59560
1946
1947         Frame can use a forward-declared Document if we move
1948         Frame::displayStringModifiedByEncoding's implementation out of the
1949         header.
1950                                 Size  #includes  Size * #includes
1951         Before: page/Frame.h:   0.746       653           487.138
1952                 dom/Document.h: 0.220      1306           287.320
1953         
1954         After:  page/Frame.h:   0.646       653           421.838
1955                 dom/Document.h: 0.220      1189           261.580
1956
1957         * WebCore.exp.in:
1958         * bindings/ScriptControllerBase.cpp:
1959         * bindings/generic/BindingSecurityBase.cpp:
1960         * bindings/v8/V8Proxy.cpp:
1961         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
1962         * dom/CharacterData.cpp:
1963         * dom/UserTypingGestureIndicator.cpp:
1964         * editing/chromium/SelectionControllerChromium.cpp:
1965         * inspector/InspectorDOMStorageResource.cpp:
1966         * inspector/InspectorInstrumentation.h:
1967         * loader/PingLoader.cpp:
1968         * loader/SubresourceLoader.cpp:
1969         * loader/appcache/DOMApplicationCache.cpp:
1970         * loader/cache/CachedResourceRequest.cpp:
1971         * page/Frame.cpp:
1972         (WebCore::Frame::displayStringModifiedByEncoding):
1973         * page/Frame.h:
1974         * page/Geolocation.cpp:
1975         * page/Location.cpp:
1976         * page/Navigator.cpp:
1977         * page/PageGroupLoadDeferrer.cpp:
1978         * page/PerformanceTiming.cpp:
1979         * xml/XSLTProcessorLibxslt.cpp:
1980
1981 2011-04-27  James Robinson  <jamesr@chromium.org>
1982
1983         Reviewed by Eric Seidel.
1984
1985         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
1986         https://bugs.webkit.org/show_bug.cgi?id=59377
1987
1988         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
1989         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
1990
1991         * css/CSSStyleSelector.cpp:
1992         (WebCore::CSSStyleSelector::applyProperty):
1993         * page/animation/AnimationBase.cpp:
1994         (WebCore::blendFunc):
1995         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
1996         (WebCore::PropertyWrapperShadow::blend):
1997         * rendering/style/RenderStyle.cpp:
1998         (WebCore::RenderStyle::setTextShadow):
1999         (WebCore::RenderStyle::setBoxShadow):
2000         * rendering/style/RenderStyle.h:
2001         (WebCore::InheritedFlags::textShadow):
2002         * rendering/style/ShadowData.cpp:
2003         (WebCore::ShadowData::ShadowData):
2004         * rendering/style/ShadowData.h:
2005         (WebCore::ShadowData::ShadowData):
2006         (WebCore::ShadowData::next):
2007         (WebCore::ShadowData::setNext):
2008         * rendering/style/StyleRareInheritedData.cpp:
2009         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2010         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2011         * rendering/style/StyleRareInheritedData.h:
2012         * rendering/style/StyleRareNonInheritedData.cpp:
2013         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2014
2015 2011-04-26  David Levin  <levin@chromium.org>
2016
2017         Reviewed by Eric Seidel.
2018
2019         Fix some strict PassOwnPtr issues in WebCore.
2020         https://bugs.webkit.org/show_bug.cgi?id=59563
2021
2022         * css/SVGCSSStyleSelector.cpp:
2023         (WebCore::CSSStyleSelector::applySVGProperty):
2024         * html/canvas/WebGLRenderingContext.cpp:
2025         (WebCore::WebGLRenderingContext::create):
2026         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
2027         * platform/text/TextCodecLatin1.cpp:
2028         (WebCore::newStreamingTextDecoderWindowsLatin1):
2029         * platform/text/TextCodecUTF16.cpp:
2030         (WebCore::newStreamingTextDecoderUTF16LE):
2031         (WebCore::newStreamingTextDecoderUTF16BE):
2032         * platform/text/TextCodecUserDefined.cpp:
2033         (WebCore::newStreamingTextDecoderUserDefined):
2034         * platform/text/mac/TextCodecMac.cpp:
2035         (WebCore::newTextCodecMac):
2036         * workers/Worker.cpp:
2037         (WebCore::Worker::notifyFinished):
2038
2039 2011-04-26  Justin Novosad  <junov@chromium.org>
2040
2041         Reviewed by Kenneth Russell.
2042
2043         [Chromium] Expose skia gpu canvas rendering as a runtime flag
2044         https://bugs.webkit.org/show_bug.cgi?id=58683
2045         Replace the SKIA_GPU compile flag by the pre-existing
2046         acceleratedDrawingEnabled flag. Most code changes are trivial:
2047         compile-time conditionals on SKIA_GPU were either replaced with
2048         a run-time check, or a compile time check on USE(SKIA) 
2049
2050         No new tests. Covered by existing tests.
2051
2052         * html/canvas/CanvasRenderingContext2D.cpp:
2053         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2054         * page/Page.cpp:
2055         (WebCore::Page::sharedGraphicsContext3D):
2056         Added check for the acceleratedDrawing flag.
2057         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2058         (WebCore::DrawingBuffer::DrawingBuffer):
2059         (WebCore::DrawingBuffer::publishToPlatformLayer):
2060         * platform/graphics/gpu/DrawingBuffer.h:
2061         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2062         (WebCore::SharedGraphicsContext3D::create):
2063         On Skia builds, this methos now receives a bool arg to turn on
2064         GPU-accelerated skia rendering
2065         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
2066         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2067         (WebCore::SharedGraphicsContext3D::grContext):
2068         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2069         * platform/graphics/skia/ImageSkia.cpp:
2070         (WebCore::computeResamplingMode):
2071         (WebCore::paintSkBitmap):
2072         (WebCore::Image::drawPattern):
2073         * platform/graphics/skia/PlatformContextSkia.cpp:
2074         (WebCore::PlatformContextSkia::PlatformContextSkia):
2075         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2076         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2077         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2078         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2079         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2080         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2081         (WebCore::PlatformContextSkia::markDirtyRect):
2082         * platform/graphics/skia/PlatformContextSkia.h:
2083         (WebCore::PlatformContextSkia::accelerationMode):
2084         (WebCore::PlatformContextSkia::useGPU):
2085         (WebCore::PlatformContextSkia::useSkiaGPU):
2086
2087 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2088
2089         Not reviewed: restore inspector test disabled in r84913.
2090
2091         Test: http/tests/inspector-enabled/dom-storage-open.html
2092
2093         * inspector/InspectorDOMStorageAgent.cpp:
2094         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2095
2096 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2097
2098         Reviewed by Tony Chang.
2099
2100         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2101         https://bugs.webkit.org/show_bug.cgi?id=59182
2102
2103         Use vertical offsets of the shaping results.
2104
2105         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2106
2107         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2108         (WebCore::ComplexTextController::ComplexTextController):
2109         Added initialization of m_startingY.
2110         (WebCore::ComplexTextController::nextScriptRun):
2111         Followed the change in handling positions.
2112         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2113         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2114         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2115         (WebCore::ComplexTextController::setGlyphPositions):
2116         Changed to use vertical offsets as same as horizontal offsets.
2117         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2118         Removed m_xPositions and Added m_positions and m_startingY.
2119         (WebCore::ComplexTextController::positions): Added.
2120         * platform/graphics/chromium/FontLinux.cpp:
2121         Followed the change in ComplexTextController.
2122         (WebCore::Font::drawComplexText): Ditto.
2123         (WebCore::Font::floatWidthForComplexText): Ditto.
2124         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2125         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2126         (WebCore::Font::selectionRectForComplexText): Ditto.
2127
2128 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2129
2130         Reviewed by Eric Seidel.
2131
2132         Root element should establish a new block formatting context
2133         https://bugs.webkit.org/show_bug.cgi?id=54573
2134
2135         Always expanding the root renderer to include overhanging floats.
2136
2137         Test: fast/block/float/float-overhangs-root.html
2138
2139         * rendering/RenderBlock.cpp:
2140         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2141
2142 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2143
2144         Reviewed by Andreas Kling.
2145
2146         [Qt] Improper rendering of <button> tag when it contains a <br>
2147         https://bugs.webkit.org/show_bug.cgi?id=50521
2148
2149         Test: platform/qt/fast/forms/button-line-break.html
2150
2151         * platform/qt/RenderThemeQt.cpp:
2152         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2153         (WebCore::RenderThemeQt::setButtonPadding):
2154
2155 2011-04-26  James Robinson  <jamesr@chromium.org>
2156
2157         Reviewed by Kenneth Russell.
2158
2159         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2160         https://bugs.webkit.org/show_bug.cgi?id=59572
2161
2162         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2163         when LayerRendererChromium was set.  We set this pointer every frame
2164         and should only reset the tiles if the new LayerRendererChromium is
2165         different from the old one (indicating a context loss), not just reset
2166         on every frame.
2167
2168         * platform/graphics/chromium/LayerTilerChromium.cpp:
2169         (WebCore::LayerTilerChromium::setLayerRenderer):
2170         * platform/graphics/chromium/LayerTilerChromium.h:
2171
2172 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2173
2174         Reviewed by Eric Seidel.
2175
2176         beginElement broken by setAttribute
2177         https://bugs.webkit.org/show_bug.cgi?id=26019
2178
2179         Test: svg/animations/animate-beginElementAt.svg
2180
2181         * svg/SVGAnimationElement.cpp:
2182         (WebCore::SVGAnimationElement::attributeChanged):
2183         Reset the animation state here as the rest of the code reads it and would still
2184         think we are animating when we are not.
2185
2186         * svg/animation/SVGSMILElement.h:
2187         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2188
2189 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2190
2191         Unreviewed, rolling out r84989.
2192         http://trac.webkit.org/changeset/84989
2193         https://bugs.webkit.org/show_bug.cgi?id=59566
2194
2195         REGRESSION (r84989): Lots of vertical text tests failing on
2196         windows (Requested by weinig on #webkit).
2197
2198         * platform/graphics/FontPlatformData.h:
2199         * platform/graphics/win/FontCacheWin.cpp:
2200         (WebCore::FontCache::getFontDataForCharacters):
2201         (WebCore::FontCache::createFontPlatformData):
2202         * platform/graphics/win/FontCustomPlatformData.cpp:
2203         (WebCore::FontCustomPlatformData::fontPlatformData):
2204         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2205         (WebCore::FontPlatformData::FontPlatformData):
2206         * platform/graphics/win/FontPlatformDataWin.cpp:
2207         (WebCore::FontPlatformData::FontPlatformData):
2208
2209 2011-04-26  Sam Weinig  <sam@webkit.org>
2210
2211         Reviewed by Eric Seidel.
2212
2213         Try again:
2214             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2215             https://bugs.webkit.org/show_bug.cgi?id=59310
2216
2217         * bindings/js/JSDOMBinding.h:
2218         (WebCore::DOMConstructorObject::DOMConstructorObject):
2219         * bindings/js/JSDOMWrapper.h:
2220         (WebCore::JSDOMWrapper::globalObject):
2221         (WebCore::JSDOMWrapper::scriptExecutionContext):
2222         (WebCore::JSDOMWrapper::createStructure):
2223         (WebCore::JSDOMWrapper::JSDOMWrapper):
2224         * bindings/scripts/CodeGeneratorJS.pm:
2225
2226 2011-04-26  Sam Weinig  <sam@webkit.org>
2227
2228         Reviewed by David Hyatt.
2229
2230         Remove Datagrid from the tree
2231         https://bugs.webkit.org/show_bug.cgi?id=59543
2232
2233         * Android.derived.jscbindings.mk:
2234         * Android.derived.v8bindings.mk:
2235         * Android.jscbindings.mk:
2236         * Android.v8bindings.mk:
2237         * CMakeLists.txt:
2238         * CodeGenerators.pri:
2239         * Configurations/FeatureDefines.xcconfig:
2240         * DerivedSources.cpp:
2241         * DerivedSources.make:
2242         * GNUmakefile.am:
2243         * GNUmakefile.list.am:
2244         * UseJSC.cmake:
2245         * WebCore.gypi:
2246         * WebCore.pro:
2247         * WebCore.vcproj/WebCore.vcproj:
2248         * WebCore.xcodeproj/project.pbxproj:
2249         * bindings/js/JSBindingsAllInOne.cpp:
2250         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2251         * bindings/js/JSDataGridDataSource.cpp: Removed.
2252         * bindings/js/JSDataGridDataSource.h: Removed.
2253         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2254         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2255         * bindings/v8/V8DataGridDataSource.h: Removed.
2256         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2257         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2258         * css/CSSStyleSelector.cpp:
2259         * css/CSSStyleSelector.h:
2260         * css/html.css:
2261         (input, textarea, keygen, select, button, isindex):
2262         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2263         * editing/htmlediting.cpp:
2264         (WebCore::canHaveChildrenForEditing):
2265         * features.pri:
2266         * html/DOMDataGridDataSource.cpp: Removed.
2267         * html/DOMDataGridDataSource.h: Removed.
2268         * html/DataGridColumn.cpp: Removed.
2269         * html/DataGridColumn.h: Removed.
2270         * html/DataGridColumn.idl: Removed.
2271         * html/DataGridColumnList.cpp: Removed.
2272         * html/DataGridColumnList.h: Removed.
2273         * html/DataGridColumnList.idl: Removed.
2274         * html/DataGridDataSource.h: Removed.
2275         * html/HTMLDataGridCellElement.cpp: Removed.
2276         * html/HTMLDataGridCellElement.h: Removed.
2277         * html/HTMLDataGridCellElement.idl: Removed.
2278         * html/HTMLDataGridColElement.cpp: Removed.
2279         * html/HTMLDataGridColElement.h: Removed.
2280         * html/HTMLDataGridColElement.idl: Removed.
2281         * html/HTMLDataGridElement.cpp: Removed.
2282         * html/HTMLDataGridElement.h: Removed.
2283         * html/HTMLDataGridElement.idl: Removed.
2284         * html/HTMLDataGridRowElement.cpp: Removed.
2285         * html/HTMLDataGridRowElement.h: Removed.
2286         * html/HTMLDataGridRowElement.idl: Removed.
2287         * html/HTMLElement.cpp:
2288         (WebCore::HTMLElement::ieForbidsInsertHTML):
2289         * html/HTMLElementsAllInOne.cpp:
2290         * html/HTMLTagNames.in:
2291         * page/DOMWindow.idl:
2292         * rendering/RenderBox.cpp:
2293         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2294         * rendering/RenderDataGrid.cpp: Removed.
2295         * rendering/RenderDataGrid.h: Removed.
2296         * rendering/RenderingAllInOne.cpp:
2297
2298 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2299
2300         Reviewed by Adele Peterson.
2301
2302         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2303         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2304
2305         This platform dependent patch makes WebKit (Windows) show the
2306         vertical writing text correctly.  Job was done by adding a prefix '@'
2307         in front of the font family name (Windows Only). No new tests added.
2308         Some layout tests images:
2309         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2310
2311         * platform/graphics/FontPlatformData.h:
2312         * platform/graphics/win/FontCacheWin.cpp:
2313         (WebCore::FontCache::getFontDataForCharacters):
2314         (WebCore::FontCache::createFontPlatformData):
2315         * platform/graphics/win/FontCustomPlatformData.cpp:
2316         (WebCore::FontCustomPlatformData::fontPlatformData):
2317         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2318         (WebCore::FontPlatformData::FontPlatformData):
2319         * platform/graphics/win/FontPlatformDataWin.cpp:
2320         (WebCore::FontPlatformData::FontPlatformData):
2321
2322 2011-04-26  Jer Noble  <jer.noble@apple.com>
2323
2324         Reviewed by Brady Eidson.
2325
2326         HTML5 video fullscreen transition causes an audio stutter
2327         https://bugs.webkit.org/show_bug.cgi?id=59544
2328
2329         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2330         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2331         layer to render it invisible, instead just set the layer as hidden.
2332
2333         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2334         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2335         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2336         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2337         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2338         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2339
2340 2011-04-26  Christian Dywan  <christian@lanedo.com>
2341
2342         Reviewed by Eric Seidel.
2343
2344         Extra separator after Select All in context menu
2345         https://bugs.webkit.org/show_bug.cgi?id=54092
2346
2347         * page/ContextMenuController.cpp: Move separator to non-GTK+
2348             port guards since it is for the spelling options menu
2349             which the GTK+ port doesn't use.
2350
2351 2011-04-26  James Robinson  <jamesr@chromium.org>
2352
2353         Reviewed by Kenneth Russell.
2354
2355         [chromium] Clear out LayerTilerChromium's tiles on lost context
2356         https://bugs.webkit.org/show_bug.cgi?id=59233
2357
2358         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
2359         no longer valid since they exist in the previous LayerRendererChromium.
2360
2361         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
2362
2363         * platform/graphics/chromium/LayerTilerChromium.h:
2364         (WebCore::LayerTilerChromium::setLayerRenderer):
2365
2366 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2367
2368         Reviewed by Dirk Schulze.
2369
2370         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
2371         https://bugs.webkit.org/show_bug.cgi?id=57644
2372
2373         Manual test: plugins/windowed-in-iframe-2.html
2374
2375         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
2376         * platform/gtk/WidgetGtk.cpp:
2377         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
2378         * plugins/PluginView.h: Added helper method to set the allocation and clip.
2379         * plugins/gtk/PluginViewGtk.cpp:
2380         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
2381         the allocation immediately. Bring this method into sync with the implementation in
2382         the Qt port.
2383         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
2384         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
2385
2386 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2387
2388         Reviewed by Eric Seidel.
2389
2390         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
2391         https://bugs.webkit.org/show_bug.cgi?id=58818
2392
2393         Prevent allocating scratch buffers larger than the target GdkDrawable
2394         when creating a WidgetRenderingContext. This prevents incredibly large
2395         widgets from crashing the X Server. This change also allowed greatly
2396         simplifying the way that the painting offset is calculated.
2397
2398         * platform/gtk/WidgetRenderingContext.cpp:
2399         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
2400         larger than the target GdkDrawable.
2401         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
2402         blit by looking at the location of the target rect itself, rather than delaying the
2403         calculation up to this point.
2404         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
2405         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
2406         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
2407         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
2408         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
2409         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
2410         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
2411         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
2412         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
2413         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
2414         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
2415         a member to store the IntSize mapping from the coordinates of the target to the coordinates
2416         of the scratch buffer.
2417
2418 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
2419
2420         Reviewed by Adam Barth.
2421
2422         Respect charset in handleDataURL
2423         https://bugs.webkit.org/show_bug.cgi?id=47746
2424
2425         Original patch by Kwang Yul Seo <skyul@company100.net>
2426
2427         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2428         returns an empty string because encoding name is not specified.
2429
2430         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2431
2432         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2433
2434         * platform/network/DataURL.cpp:
2435         (WebCore::handleDataURL):
2436
2437 2011-04-26  Anders Carlsson  <andersca@apple.com>
2438
2439         Fix clang++ build.
2440
2441         You can never have too many casts!
2442
2443         * accessibility/mac/AccessibilityObjectWrapper.mm:
2444         (-[AccessibilityObjectWrapper position]):
2445         * editing/mac/SelectionControllerMac.mm:
2446         (WebCore::accessibilityConvertScreenRect):
2447
2448 2011-04-26  Chris Rogers  <crogers@google.com>
2449
2450         Reviewed by Kenneth Russell.
2451
2452         Fix web audio build on mac port
2453         https://bugs.webkit.org/show_bug.cgi?id=59355
2454
2455         No new tests since audio API is not yet implemented.
2456
2457         * WebCore.xcodeproj/project.pbxproj:
2458         * bindings/js/JSAudioContextCustom.cpp:
2459         (WebCore::JSAudioContext::visitChildren):
2460         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
2461         (WebCore::JSJavaScriptAudioNode::visitChildren):
2462         * webaudio/AudioContext.idl:
2463
2464 2011-04-26  Chris Rogers  <crogers@google.com>
2465
2466         Reviewed by Kenneth Russell.
2467
2468         Add FFTFrame implementation for FFmpeg
2469         https://bugs.webkit.org/show_bug.cgi?id=59408
2470
2471         No new tests since audio API is not yet implemented.
2472
2473         * WebCore.gyp/WebCore.gyp:
2474         * WebCore.gypi:
2475         * platform/audio/FFTFrame.h:
2476         * platform/audio/FFTFrameStub.cpp:
2477         * platform/audio/ffmpeg: Added.
2478         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
2479         (WebCore::FFTFrame::FFTFrame):
2480         (WebCore::FFTFrame::initialize):
2481         (WebCore::FFTFrame::cleanup):
2482         (WebCore::FFTFrame::~FFTFrame):
2483         (WebCore::FFTFrame::multiply):
2484         (WebCore::FFTFrame::doFFT):
2485         (WebCore::FFTFrame::doInverseFFT):
2486         (WebCore::FFTFrame::realData):
2487         (WebCore::FFTFrame::imagData):
2488         (WebCore::FFTFrame::getUpToDateComplexData):
2489         (WebCore::FFTFrame::contextForSize):
2490         * platform/audio/mac/FFTFrameMac.cpp:
2491         * webaudio/ConvolverNode.cpp:
2492
2493 2011-04-26  Jeff Miller  <jeffm@apple.com>
2494
2495         Add a newline at the end of SVGFEDropShadowElement.idl.
2496
2497         * svg/SVGFEDropShadowElement.idl:
2498
2499 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2500
2501         Reviewed by Eric Seidel.
2502
2503         InlineBox.h shouldn't include RenderBR.h
2504         https://bugs.webkit.org/show_bug.cgi?id=59480
2505
2506         Per bug 59348 RenderBR.h is a "top header" by include * size, because
2507         InlineBox.h includes it. There's no reason why it has to.
2508
2509         * rendering/InlineBox.h:
2510         * rendering/InlineTextBox.cpp:
2511         * rendering/RenderBlock.h:
2512
2513 2011-04-26  Sam Weinig  <sam@webkit.org>
2514
2515         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
2516         I should do.
2517
2518         * bindings/js/JSDOMBinding.h:
2519         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2520         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2521         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2522         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2523         (WebCore::DOMConstructorObject::DOMConstructorObject):
2524         * bindings/js/JSDOMWrapper.h:
2525         (WebCore::JSDOMWrapper::JSDOMWrapper):
2526         * bindings/scripts/CodeGeneratorJS.pm:
2527
2528 2011-04-26  Sam Weinig  <sam@webkit.org>
2529
2530         Fix build.
2531
2532         * bindings/js/JSDOMWrapper.h:
2533         (WebCore::JSDOMWrapper::globalObject):
2534
2535 2011-04-26  Sam Weinig  <sam@webkit.org>
2536
2537         Roll r84945 back in with infinite recursion removed.
2538
2539         * bindings/js/JSDOMBinding.h:
2540         (WebCore::DOMConstructorObject::DOMConstructorObject):
2541         * bindings/js/JSDOMWrapper.h:
2542         (WebCore::JSDOMWrapper::globalObject):
2543         (WebCore::JSDOMWrapper::scriptExecutionContext):
2544         (WebCore::JSDOMWrapper::createStructure):
2545         (WebCore::JSDOMWrapper::JSDOMWrapper):
2546         * bindings/scripts/CodeGeneratorJS.pm:
2547
2548 2011-04-26  Sam Weinig  <sam@webkit.org>
2549
2550         Rollout previous patch. It broke stuff.
2551
2552         * bindings/js/JSDOMBinding.h:
2553         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2554         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2555         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2556         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2557         (WebCore::DOMConstructorObject::DOMConstructorObject):
2558         * bindings/js/JSDOMWrapper.h:
2559         (WebCore::JSDOMWrapper::JSDOMWrapper):
2560         * bindings/scripts/CodeGeneratorJS.pm:
2561
2562 2011-04-26  Sam Weinig  <sam@webkit.org>
2563
2564         Reviewed by Maciej Stachowiak.
2565
2566         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2567         https://bugs.webkit.org/show_bug.cgi?id=59310
2568
2569         * bindings/js/JSDOMBinding.h:
2570         (WebCore::DOMConstructorObject::DOMConstructorObject):
2571         * bindings/js/JSDOMWrapper.h:
2572         (WebCore::JSDOMWrapper::globalObject):
2573         (WebCore::JSDOMWrapper::scriptExecutionContext):
2574         (WebCore::JSDOMWrapper::createStructure):
2575         (WebCore::JSDOMWrapper::JSDOMWrapper):
2576         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
2577
2578         * bindings/scripts/CodeGeneratorJS.pm:
2579         Make JSDOMWrapper the base class.
2580
2581 2011-04-26  Dan Bernstein  <mitz@apple.com>
2582
2583         Reviewed by Mark Rowe.
2584
2585         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
2586
2587         * Configurations/Base.xcconfig:
2588         * Configurations/CompilerVersion.xcconfig: Added.
2589
2590 2011-04-26  Adrienne Walker  <enne@google.com>
2591
2592         Reviewed by Geoffrey Garen.
2593
2594         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
2595         https://bugs.webkit.org/show_bug.cgi?id=59469
2596
2597         * platform/chromium/TraceEvent.h:
2598         (WebCore::internal::ScopeTracer::ScopeTracer):
2599
2600 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2601
2602         Reviewed by Oliver Hunt.
2603
2604         Nixed special finalizer handling for WebCore strings
2605         https://bugs.webkit.org/show_bug.cgi?id=59425
2606
2607         Not needed anymore, since weak handles have finalizers.
2608
2609         * WebCore.exp.in: Exports!
2610
2611         * bindings/js/DOMWrapperWorld.cpp:
2612         (WebCore::JSStringOwner::finalize):
2613         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
2614         so we don't need special treatment anymore.
2615
2616         * bindings/js/DOMWrapperWorld.h:
2617         (WebCore::JSStringOwner::JSStringOwner):
2618         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
2619         instead of a WeakGCMap, so we can specify a custom finalizer.
2620
2621         * bindings/js/JSDOMBinding.cpp:
2622         (WebCore::jsStringSlowCase):
2623         * bindings/js/JSDOMBinding.h:
2624         (WebCore::jsString): Updated for string map change.
2625
2626 2011-04-26  David Kilzer  <ddkilzer@apple.com>
2627
2628         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
2629
2630         Reviewed by Antti Koivisto.
2631
2632         To enable HTTP pipelining post-SnowLeopard, use this command:
2633
2634             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
2635
2636         * platform/network/cf/ResourceRequestCFNet.cpp:
2637         (WebCore::readBooleanPreference): Re-added.  Originally added in
2638         r76756 and removed in r84120.
2639         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
2640         HTTP pipelining if use default is set to true.  Added macro
2641         guards to match those in ResourceRequestMac.mm.
2642
2643 2011-04-26  Antti Koivisto  <antti@apple.com>
2644
2645         Reviewed by Adele Peterson.
2646
2647         Don't strip fragments from file: urls in memory cache
2648         https://bugs.webkit.org/show_bug.cgi?id=59463
2649         <rdar://problem/9231130>
2650
2651         Some clients expect file: resources to be unique based on fragment identifier. 
2652         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
2653
2654         Test: fast/loader/file-protocol-fragment.html
2655
2656         * loader/cache/MemoryCache.cpp:
2657         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
2658
2659 2011-04-26  David Levin  <levin@chromium.org>
2660
2661         Reviewed by Darin Adler.
2662
2663         Fix more strict OwnPtr in WebCore (round N).
2664         https://bugs.webkit.org/show_bug.cgi?id=59464
2665
2666         * dom/Document.cpp:
2667         (WebCore::Document::Document):
2668         (WebCore::Document::attach):
2669         * fileapi/FileReader.cpp:
2670         (WebCore::FileReader::terminate):
2671         * loader/DocumentThreadableLoader.cpp:
2672         (WebCore::DocumentThreadableLoader::preflightFailure):
2673         * workers/DefaultSharedWorkerRepository.cpp:
2674         (WebCore::SharedWorkerConnectTask::create):
2675         (WebCore::SharedWorkerScriptLoader::load):
2676
2677 2011-04-26  Ruben  <chromium@hybridsource.org>
2678
2679         Reviewed by Tony Chang.
2680
2681         Change linux ifdefs for Chromium to Unix instead, allowing
2682         new Unix ports to be enabled by default
2683         https://bugs.webkit.org/show_bug.cgi?id=59297
2684
2685         No new tests, just changing preprocessor defines.
2686
2687         * bindings/js/JSInspectorFrontendHostCustom.cpp:
2688         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
2689         * dom/SelectElement.cpp:
2690         * loader/cache/CachedFont.cpp:
2691         * page/EventHandler.cpp:
2692         * page/chromium/EventHandlerChromium.cpp:
2693         * platform/Scrollbar.cpp:
2694         * platform/chromium/PlatformBridge.h:
2695         * platform/graphics/chromium/FontPlatformData.h:
2696         * platform/graphics/skia/FontCustomPlatformData.cpp:
2697         * platform/graphics/skia/FontCustomPlatformData.h:
2698
2699 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2700
2701         Reviewed by Dan Bernstein.
2702
2703         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
2704         https://bugs.webkit.org/show_bug.cgi?id=49111
2705
2706         Even when the offset corresponds to a position visually left of the box
2707         and there aren't any inline boxes on the left, the previous/next position
2708         may still correspond to some position in the same line.
2709
2710         The bug was caused by our ignoring such cases. Fixed the bug by comparing
2711         previous/next position's inline box to the current box. If they match,
2712         then we stay on the same position because moving to the left visually at
2713         the left edge should not result in a position on the same line.
2714
2715         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
2716         the left edge or to the right edge, and a bug that WebKit could not move to
2717         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
2718
2719         Test cases are added to editing/selection/move-left-right.html
2720
2721         * editing/VisiblePosition.cpp:
2722         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
2723         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
2724
2725 2011-04-26  Gabor Loki  <loki@webkit.org>
2726
2727         Reviewed by Csaba Osztrogon√°c.
2728
2729         Speeding up SVG filters with multicore (SMP) support
2730         https://bugs.webkit.org/show_bug.cgi?id=43903
2731
2732         Some SVG filters execute a huge number of pixel manipulations, which
2733         cannot be sped up by graphics accelerators, since their algorithm is
2734         too complex. Using the power of Symmetric Multi Processing (SMP) we
2735         can split up a task to smaller (data independent) tasks, which can be
2736         executed independently.
2737
2738         The ParallelJobs framework provides a simple way for distributed
2739         programming. The framework is based on WebKit's threading infrastructure,
2740         Open Multi-Processing's (OpenMP) API, and libdispatch API.
2741
2742         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
2743         * platform/graphics/filters/FETurbulence.cpp:
2744         (WebCore::FETurbulence::PaintingData::PaintingData):
2745         (WebCore::FETurbulence::noise2D):
2746         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
2747         (WebCore::FETurbulence::fillRegion):
2748         (WebCore::FETurbulence::fillRegionWorker):
2749         (WebCore::FETurbulence::apply):
2750         * platform/graphics/filters/FETurbulence.h:
2751
2752 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2753
2754         Reviewed by Yury Semikhatsky.
2755
2756         Web Inspector: close button is off in docked mode on a mac.
2757         https://bugs.webkit.org/show_bug.cgi?id=59453
2758
2759         * inspector/front-end/inspector.css:
2760         (.toolbar-item.close-left):
2761
2762 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2763
2764         Reviewed by Yury Semikhatsky.
2765
2766         Web Inspector: New Style is not working (UI glitch)
2767         https://bugs.webkit.org/show_bug.cgi?id=59451
2768
2769         * inspector/InspectorDOMStorageAgent.cpp:
2770         (WebCore::InspectorDOMStorageAgent::setFrontend):
2771         * inspector/front-end/AuditRules.js:
2772         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
2773         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
2774         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
2775         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
2776         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
2777         * inspector/front-end/CSSStyleModel.js:
2778         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
2779         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
2780         (WebInspector.CSSStyleModel.prototype.addRule):
2781         (WebInspector.CSSStyleModel.prototype.addRule.callback):
2782         (WebInspector.CSSStyleModel.prototype._documentElementId):
2783         * inspector/front-end/DOMAgent.js:
2784         (WebInspector.DOMNode.prototype._addAttribute):
2785         (WebInspector.DOMNode.prototype.documentElement):
2786         * inspector/front-end/ResourceTreeModel.js:
2787         (WebInspector.PageDispatcher.prototype.frameDetached):
2788         * inspector/front-end/StylesSidebarPane.js:
2789         (WebInspector.StylesSidebarPane.prototype._createNewRule):
2790
2791 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2792
2793         Reviewed by Yury Semikhatsky.
2794
2795         Web Inspector: introduce DOMStorage::enable and disable.
2796         https://bugs.webkit.org/show_bug.cgi?id=59445
2797
2798         * inspector/Inspector.json:
2799         * inspector/InspectorAgent.cpp:
2800         (WebCore::InspectorAgent::InspectorAgent):
2801         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2802         * inspector/InspectorDOMStorageAgent.cpp:
2803         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2804         (WebCore::InspectorDOMStorageAgent::restore):
2805         (WebCore::InspectorDOMStorageAgent::enable):
2806         (WebCore::InspectorDOMStorageAgent::disable):
2807         * inspector/InspectorDOMStorageAgent.h:
2808         (WebCore::InspectorDOMStorageAgent::create):
2809         * inspector/front-end/DOMStorage.js:
2810         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2811         * inspector/front-end/ResourcesPanel.js:
2812         (WebInspector.ResourcesPanel.prototype._reset):
2813         * inspector/front-end/inspector.js:
2814
2815 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2816
2817         Reviewed by Yury Semikhatsky.
2818
2819         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
2820         https://bugs.webkit.org/show_bug.cgi?id=59440
2821
2822         * inspector/Inspector.json:
2823         * inspector/InspectorAgent.cpp:
2824         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2825         * inspector/InspectorPageAgent.cpp:
2826         (WebCore::InspectorPageAgent::setFrontend):
2827         (WebCore::InspectorPageAgent::frameNavigated):
2828         * inspector/InspectorPageAgent.h:
2829         * inspector/front-end/AuditsPanel.js:
2830         (WebInspector.AuditsPanel):
2831         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
2832         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
2833         * inspector/front-end/CSSStyleModel.js:
2834         (WebInspector.CSSStyleModelResourceBinding):
2835         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
2836         * inspector/front-end/DOMBreakpointsSidebarPane.js:
2837         (WebInspector.DOMBreakpointsSidebarPane):
2838         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
2839         * inspector/front-end/DOMStorage.js:
2840         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2841         * inspector/front-end/ExtensionServer.js:
2842         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
2843         (WebInspector.ExtensionServer.prototype.initExtensions):
2844         * inspector/front-end/NetworkPanel.js:
2845         (WebInspector.NetworkPanel):
2846         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
2847         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
2848         (WebInspector.NetworkPanel.prototype._frameNavigated):
2849         * inspector/front-end/ResourceTreeModel.js:
2850         (WebInspector.ResourceTreeModel):
2851         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2852         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
2853         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2854         (WebInspector.ResourceTreeModel.prototype._frameDetached):
2855         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
2856         (WebInspector.PageDispatcher):
2857         (WebInspector.PageDispatcher.prototype.domContentEventFired):
2858         (WebInspector.PageDispatcher.prototype.loadEventFired):
2859         (WebInspector.PageDispatcher.prototype.frameNavigated):
2860         (WebInspector.PageDispatcher.prototype.frameDetached):
2861         * inspector/front-end/ResourcesPanel.js:
2862         (WebInspector.ResourcesPanel):
2863         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
2864         (WebInspector.ResourcesPanel.prototype._frameNavigated):
2865         * inspector/front-end/inspector.js:
2866
2867 2011-04-26  Csaba Osztrogon√°c  <ossy@webkit.org>
2868
2869         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
2870         because it broke transitions/multiple-text-shadow-transition.html
2871
2872         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2873         https://bugs.webkit.org/show_bug.cgi?id=59377
2874
2875         * css/CSSStyleSelector.cpp:
2876         (WebCore::CSSStyleSelector::applyProperty):
2877         * page/animation/AnimationBase.cpp:
2878         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2879         (WebCore::PropertyWrapperShadow::blend):
2880         * rendering/style/RenderStyle.cpp:
2881         (WebCore::RenderStyle::setTextShadow):
2882         (WebCore::RenderStyle::setBoxShadow):
2883         * rendering/style/RenderStyle.h:
2884         (WebCore::InheritedFlags::textShadow):
2885         * rendering/style/StyleRareInheritedData.cpp:
2886         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2887         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2888         * rendering/style/StyleRareInheritedData.h:
2889         * rendering/style/StyleRareNonInheritedData.cpp:
2890         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2891
2892 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2893
2894         Reviewed by Adam Barth.
2895
2896         Turn off make built-in implicit rules for derived sources makefile
2897         https://bugs.webkit.org/show_bug.cgi?id=59418
2898
2899         We don't use any of make's built-in implicit rules, turning them off
2900         speeds up parsing of the makefile.
2901
2902         * WebCore.xcodeproj/project.pbxproj:
2903         * gyp/generate-derived-sources.sh:
2904
2905 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
2906
2907         Reviewed by Nikolas Zimmermann.
2908
2909         ASSERT failure in SVGUseElement
2910         https://bugs.webkit.org/show_bug.cgi?id=59313
2911
2912         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
2913         was wrong because the document may not be well-formed.
2914
2915         This patch asserts the element is not pending on resource or the
2916         document is not well-formed.
2917
2918         Test: svg/custom/use-crash-in-non-wellformed-document.svg
2919
2920         * svg/SVGUseElement.cpp:
2921         (WebCore::isWellFormedDocument):
2922         (WebCore::SVGUseElement::insertedIntoDocument):
2923
2924 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
2925
2926         Reviewed by Pavel Feldman.
2927
2928         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
2929         https://bugs.webkit.org/show_bug.cgi?id=59438
2930
2931         * inspector/front-end/DetailedHeapshotView.js:
2932         (WebInspector.DetailedHeapshotView.prototype._changeView):
2933
2934 2011-04-26  David Levin  <levin@chromium.org>
2935
2936         Reviewed by Adam Barth.
2937
2938         Fix a few OwnPtr strict errors in WebCore headers.
2939         https://bugs.webkit.org/show_bug.cgi?id=59431
2940
2941         * bindings/js/ScheduledAction.cpp:
2942         (WebCore::ScheduledAction::create):
2943         * css/MediaQueryMatcher.cpp:
2944         (WebCore::MediaQueryMatcher::prepareEvaluator):
2945         * dom/NodeRareData.h:
2946         (WebCore::NodeListsNodeData::create):
2947         * dom/ScriptRunner.h:
2948         (WebCore::ScriptRunner::create):
2949         * inspector/WorkerInspectorController.cpp:
2950         (WebCore::WorkerInspectorController::connectFrontend):
2951         * loader/icon/IconDatabase.h:
2952         (WebCore::IconDatabase::create):
2953         * platform/graphics/SimpleFontData.cpp:
2954         (WebCore::SimpleFontData::verticalRightOrientationFontData):
2955         (WebCore::SimpleFontData::uprightOrientationFontData):
2956         (WebCore::SimpleFontData::brokenIdeographFontData):
2957         * rendering/style/StyleRareInheritedData.cpp:
2958         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2959         * rendering/svg/SVGResources.h:
2960         (WebCore::SVGResources::ClipperFilterMaskerData::create):
2961         (WebCore::SVGResources::MarkerData::create):
2962         (WebCore::SVGResources::FillStrokeData::create):
2963         * storage/StorageSyncManager.cpp:
2964         (WebCore::StorageSyncManager::close):
2965         * workers/WorkerContext.cpp:
2966         (WebCore::CloseWorkerContextTask::create):
2967         * workers/WorkerMessagingProxy.cpp:
2968         (WebCore::MessageWorkerContextTask::create):
2969         (WebCore::MessageWorkerTask::create):
2970         (WebCore::WorkerExceptionTask::create):
2971         (WebCore::WorkerContextDestroyedTask::create):
2972         (WebCore::WorkerTerminateTask::create):
2973         (WebCore::WorkerThreadActivityReportTask::create):
2974         * workers/WorkerRunLoop.cpp:
2975         (WebCore::WorkerRunLoop::Task::create):
2976         * workers/WorkerThread.cpp:
2977         (WebCore::WorkerThreadStartupData::create):
2978         (WebCore::WorkerThreadShutdownFinishTask::create):
2979         (WebCore::WorkerThreadShutdownStartTask::create):
2980
2981 2011-04-26  Adam Klein  <adamk@chromium.org>
2982
2983         Reviewed by Adam Barth.
2984
2985         Fix last strict OwnPtr violation under svg/...
2986         https://bugs.webkit.org/show_bug.cgi?id=59429
2987
2988         * svg/SVGDocumentExtensions.cpp:
2989         (WebCore::SVGDocumentExtensions::removePendingResource):
2990
2991 2011-04-26  Adam Barth  <abarth@webkit.org>
2992
2993         Reviewed by David Levin.
2994
2995         Fix more strict OwnPtr violations in WebCore
2996         https://bugs.webkit.org/show_bug.cgi?id=59433
2997
2998         These manifest in the Chromium build.
2999
3000         * bindings/v8/ScriptController.cpp:
3001         (WebCore::ScriptController::ScriptController):
3002         * bindings/v8/ScriptDebugServer.cpp:
3003         (WebCore::ScriptDebugServer::editScriptSource):
3004         * bindings/v8/V8DOMMap.cpp:
3005         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
3006         * bindings/v8/V8Proxy.cpp:
3007         (WebCore::V8Proxy::precompileScript):
3008         * bindings/v8/WorkerScriptController.cpp:
3009         (WebCore::WorkerScriptController::WorkerScriptController):
3010         * page/Page.cpp:
3011         (WebCore::Page::Page):
3012         (WebCore::Page::speechInput):
3013         * platform/PlatformGestureRecognizer.cpp:
3014         (WebCore::PlatformGestureRecognizer::create):
3015         * platform/PlatformGestureRecognizer.h:
3016         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3017         (WebCore::DrawingBuffer::DrawingBuffer):
3018         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3019         (WebCore::CCLayerImpl::CCLayerImpl):
3020         * platform/graphics/gpu/Texture.cpp:
3021         (WebCore::Texture::create):
3022         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
3023         (WebCore::BMPImageDecoder::decodeHelper):
3024         * platform/image-decoders/gif/GIFImageDecoder.cpp:
3025         (WebCore::GIFImageDecoder::decode):
3026         * platform/image-decoders/ico/ICOImageDecoder.cpp:
3027         (WebCore::ICOImageDecoder::decodeAtIndex):
3028         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3029         (WebCore::JPEGImageDecoder::decode):
3030         * platform/image-decoders/png/PNGImageDecoder.cpp:
3031         (WebCore::PNGImageDecoder::decode):
3032         * storage/chromium/DatabaseTrackerChromium.cpp:
3033         (WebCore::DatabaseTracker::addOpenDatabase):
3034
3035 2011-04-25  David Levin  <levin@chromium.org>
3036
3037         Reviewed by Adam Barth.
3038
3039         Fix OwnPtr strict errors in CrossThreadTask.h
3040         https://bugs.webkit.org/show_bug.cgi?id=59427
3041
3042         * dom/CrossThreadTask.h:
3043         (WebCore::CrossThreadTask1::create):
3044         (WebCore::CrossThreadTask2::create):
3045         (WebCore::CrossThreadTask3::create):
3046         (WebCore::CrossThreadTask4::create):
3047         (WebCore::CrossThreadTask5::create):
3048         (WebCore::CrossThreadTask6::create):
3049         (WebCore::CrossThreadTask7::create):
3050         (WebCore::CrossThreadTask8::create):
3051
3052 2011-04-25  Mark Rowe  <mrowe@apple.com>
3053
3054         Reviewed by Dan Bernstein.
3055
3056         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
3057
3058         * css/CSSStyleApplyProperty.cpp:
3059         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
3060         * css/CSSStyleApplyProperty.h:
3061         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
3062
3063 2011-04-25  Levi Weintraub  <leviw@chromium.org>
3064
3065         Reviewed by Ryosuke Niwa.
3066
3067         REGRESSION: a character appears after tab span when typing immediately before the tab span
3068         https://bugs.webkit.org/show_bug.cgi?id=58132
3069
3070         Correcting the order of operations we use to avoid inserting into invalid positions in
3071         ReplaceSelectionCommand to avoid inserting into tab-spans.
3072
3073         Test: editing/pasteboard/paste-before-tab-span.html
3074
3075         * editing/ReplaceSelectionCommand.cpp:
3076         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
3077         positionAvoidingPrecedingNodes, since that function could once again put our position
3078         inside a tab span.
3079
3080 2011-04-25  David Levin  <levin@chromium.org>
3081
3082         Reviewed by Adam Barth.
3083
3084         Fix OwnPtr strict error in ImageBuffer.h
3085         https://bugs.webkit.org/show_bug.cgi?id=59422
3086
3087         * platform/graphics/ImageBuffer.h:
3088         (WebCore::ImageBuffer::create):
3089
3090 2011-04-25  Adam Barth  <abarth@webkit.org>
3091
3092         Reviewed by David Levin.
3093
3094         Fix strict OwnPtr violations and whitelist known-tricky files
3095         https://bugs.webkit.org/show_bug.cgi?id=59421
3096
3097         With this patch, WebCore builds cleanly with strict OwnPtrs.
3098
3099         * dom/MessagePort.cpp:
3100         (WebCore::MessagePort::MessagePort):
3101         * dom/XMLDocumentParserLibxml2.cpp:
3102         * page/ContextMenuController.cpp:
3103         (WebCore::ContextMenuController::ContextMenuController):
3104         (WebCore::ContextMenuController::clearContextMenu):
3105         * page/PluginHalter.cpp:
3106         * platform/graphics/MediaPlayer.cpp:
3107         * platform/network/ResourceRequestBase.cpp:
3108         (WebCore::ResourceRequestBase::adopt):
3109         (WebCore::ResourceRequestBase::copyData):
3110         * svg/SVGDocumentExtensions.cpp:
3111
3112 2011-04-25  David Levin  <levin@chromium.org>
3113
3114         Reviewed by Adam Barth.
3115
3116         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
3117         https://bugs.webkit.org/show_bug.cgi?id=59419
3118
3119         * dom/DatasetDOMStringMap.h:
3120         (WebCore::DatasetDOMStringMap::create):
3121
3122 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3123
3124         Reviewed by Eric Seidel.
3125
3126         KeyboardEvent.cpp should work with strict OwnPtrs.
3127         https://bugs.webkit.org/show_bug.cgi?id=59403
3128
3129         * dom/KeyboardEvent.cpp:
3130         (WebCore::KeyboardEvent::KeyboardEvent):
3131
3132 2011-04-25  James Robinson  <jamesr@chromium.org>
3133
3134         Reviewed by Eric Seidel.
3135
3136         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3137         https://bugs.webkit.org/show_bug.cgi?id=59377
3138
3139         * css/CSSStyleSelector.cpp:
3140         (WebCore::CSSStyleSelector::applyProperty):
3141         * page/animation/AnimationBase.cpp:
3142         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3143         (WebCore::PropertyWrapperShadow::blend):
3144         * rendering/style/RenderStyle.cpp:
3145         (WebCore::RenderStyle::setTextShadow):
3146         (WebCore::RenderStyle::setBoxShadow):
3147         * rendering/style/RenderStyle.h:
3148         (WebCore::InheritedFlags::textShadow):
3149         * rendering/style/StyleRareInheritedData.cpp:
3150         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3151         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3152         * rendering/style/StyleRareInheritedData.h:
3153         * rendering/style/StyleRareNonInheritedData.cpp:
3154         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3155
3156 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3157
3158         Unreviewed, rolling out r84864.
3159         http://trac.webkit.org/changeset/84864
3160         https://bugs.webkit.org/show_bug.cgi?id=59413
3161
3162         Expect result of use-crash-in-non-wellformed-document.svg is
3163         platform dependent (Requested by leoyang on #webkit).
3164
3165         * svg/SVGUseElement.cpp:
3166         (WebCore::SVGUseElement::insertedIntoDocument):
3167
3168 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
3169
3170         Reviewed by Nikolas Zimmermann.
3171
3172         ASSERT failure in SVGUseElement
3173         https://bugs.webkit.org/show_bug.cgi?id=59313
3174
3175         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3176         was wrong because the document may not be well-formed.
3177
3178         This patch asserts the element is not pending on resource or the
3179         document is not well-formed.
3180
3181         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3182
3183         * svg/SVGUseElement.cpp:
3184         (WebCore::isWellFormedDocument):
3185         (WebCore::SVGUseElement::insertedIntoDocument):
3186
3187 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3188
3189         Reviewed by Tony Chang.
3190
3191         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3192         https://bugs.webkit.org/show_bug.cgi?id=59028
3193
3194         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3195         Moving the code for base class we can reduce the efforts to support DataTransferItems
3196         element in different platforms.
3197
3198         * Android.mk:
3199         * CMakeLists.txt:
3200         * GNUmakefile.list.am:
3201         * WebCore.gypi:
3202         * WebCore.pro:
3203         * WebCore.vcproj/WebCore.vcproj:
3204         * WebCore.xcodeproj/project.pbxproj:
3205         * dom/DataTransferItem.cpp:
3206         (WebCore::DataTransferItem::DataTransferItem):
3207         (WebCore::DataTransferItem::owner):
3208         (WebCore::DataTransferItem::kind):
3209         (WebCore::DataTransferItem::type):
3210         * dom/DataTransferItem.h:
3211         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3212         (WebCore::DataTransferItems::DataTransferItems):
3213         (WebCore::DataTransferItems::length):
3214         (WebCore::DataTransferItems::item):
3215         (WebCore::DataTransferItems::deleteItem):
3216         (WebCore::DataTransferItems::clear):
3217         (WebCore::DataTransferItems::add):
3218         * dom/DataTransferItems.h:
3219         * platform/chromium/DataTransferItemChromium.cpp:
3220         (WebCore::DataTransferItem::create):
3221         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3222         (WebCore::DataTransferItemChromium::getAsString):
3223         (WebCore::DataTransferItemChromium::getAsFile):
3224         * platform/chromium/DataTransferItemChromium.h:
3225         * platform/chromium/DataTransferItemsChromium.cpp:
3226         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3227         * platform/chromium/DataTransferItemsChromium.h:
3228
3229 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3230
3231         Reviewed by Simon Fraser.
3232
3233         REGRESSION(75137): directly composited images are double-drawn sometimes
3234         https://bugs.webkit.org/show_bug.cgi?id=58632
3235
3236         Depending on the order of operations (layout, creating compositing 
3237         layers and creating simple image layers) a layer can have both image
3238         content and have m_drawsContent=true. In this case 2 copies of the image
3239         are drawn in the layer. If the image has alpha, it looks wrong.
3240
3241         I added an updateDrawsContent() call after setting the image contents
3242         to make sure it's correct.
3243
3244         I couldn't create a test case that shows the problem because layerTreeAsText()
3245         doesn't emit enough info to show this level of detail. I've opened
3246         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3247
3248         * rendering/RenderLayerBacking.cpp:
3249         (WebCore::RenderLayerBacking::updateImageContents):
3250
3251 2011-04-25  Kenneth Russell  <kbr@google.com>
3252
3253         Reviewed by David Levin.
3254
3255         Fix OwnPtr strict errors in InlineFlowBox.cpp
3256         https://bugs.webkit.org/show_bug.cgi?id=59392
3257
3258         * rendering/InlineFlowBox.cpp:
3259         (WebCore::InlineFlowBox::setLayoutOverflow):
3260         (WebCore::InlineFlowBox::setVisualOverflow):
3261
3262 2011-04-25  Kenneth Russell  <kbr@google.com>
3263
3264         Reviewed by David Levin.
3265
3266         Fix OwnPtr strict errors in TransformState.cpp
3267         https://bugs.webkit.org/show_bug.cgi?id=59380
3268
3269         * rendering/TransformState.cpp:
3270         (WebCore::TransformState::applyTransform):
3271
3272 2011-04-25  Adam Barth  <abarth@webkit.org>
3273
3274         Reviewed by James Robinson.
3275
3276         DOMWindow.cpp should work with strict OwnPtrs
3277         https://bugs.webkit.org/show_bug.cgi?id=59356
3278
3279         * page/DOMWindow.cpp:
3280         (WebCore::PostMessageTimer::fired):
3281         (WebCore::DOMWindow::postMessageTimerFired):
3282         * page/DOMWindow.h:
3283
3284 2011-04-25  Adam Klein  <adamk@chromium.org>
3285
3286         Reviewed by James Robinson.
3287
3288         Fix OwnPtr strict errors in some SVG classes.
3289         https://bugs.webkit.org/show_bug.cgi?id=59395
3290
3291         * rendering/style/SVGRenderStyleDefs.cpp:
3292         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3293         * svg/SVGSVGElement.cpp:
3294         (WebCore::SVGSVGElement::SVGSVGElement):
3295         * svg/SVGStyledTransformableElement.cpp:
3296         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3297         * svg/SVGTextElement.cpp:
3298         (WebCore::SVGTextElement::supplementalTransform):
3299         * svg/graphics/SVGImage.cpp:
3300         (WebCore::SVGImage::dataChanged):
3301
3302 2011-04-25  Adam Barth  <abarth@webkit.org>
3303
3304         Re-land changes to ValidationMessage.
3305
3306         * html/ValidationMessage.cpp:
3307         (WebCore::ValidationMessage::setMessage):
3308         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3309         (WebCore::ValidationMessage::requestToHideMessage):
3310
3311 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3312
3313         Reviewed by James Robinson.
3314
3315         fix OwnPtr strict error in FrameView.cpp
3316         https://bugs.webkit.org/show_bug.cgi?id=59402
3317
3318         * page/FrameView.cpp:
3319         (WebCore::FrameView::FrameView):
3320         (WebCore::FrameView::addWidgetToUpdate):
3321
3322 2011-04-25  Adam Klein  <adamk@chromium.org>
3323
3324         Unreviewed, rolling out r84844.
3325         http://trac.webkit.org/changeset/84844
3326         https://bugs.webkit.org/show_bug.cgi?id=59395
3327
3328         Checked in too much.
3329
3330         * rendering/style/SVGRenderStyleDefs.cpp:
3331         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3332         * svg/SVGDocumentExtensions.cpp:
3333         (WebCore::SVGDocumentExtensions::removePendingResource):
3334         * svg/SVGSVGElement.cpp:
3335         (WebCore::SVGSVGElement::SVGSVGElement):
3336         * svg/SVGStyledTransformableElement.cpp:
3337         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3338         * svg/SVGTextElement.cpp:
3339         (WebCore::SVGTextElement::supplementalTransform):
3340         * svg/graphics/SVGImage.cpp:
3341         (WebCore::SVGImage::dataChanged):
3342
3343 2011-04-25  Adrienne Walker  <enne@google.com>
3344
3345         Reviewed by David Levin.
3346
3347         Make ActiveDOMCallback play nice with OwnPtr strict mode
3348         https://bugs.webkit.org/show_bug.cgi?id=59398
3349
3350         * bindings/generic/ActiveDOMCallback.cpp:
3351         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
3352
3353 2011-04-25  Adam Klein  <adamk@chromium.org>
3354
3355         Reviewed by James Robinson.
3356
3357         Fix OwnPtr strict errors in some SVG classes.
3358         https://bugs.webkit.org/show_bug.cgi?id=59395
3359
3360         * rendering/style/SVGRenderStyleDefs.cpp:
3361         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3362         * svg/SVGSVGElement.cpp:
3363         (WebCore::SVGSVGElement::SVGSVGElement):
3364         * svg/SVGStyledTransformableElement.cpp:
3365         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3366         * svg/SVGTextElement.cpp:
3367         (WebCore::SVGTextElement::supplementalTransform):
3368         * svg/graphics/SVGImage.cpp:
3369         (WebCore::SVGImage::dataChanged):
3370
3371 2011-04-25  James Robinson  <jamesr@chromium.org>
3372
3373         Unreviewed, rolling out r84835.
3374         http://trac.webkit.org/changeset/84835
3375         https://bugs.webkit.org/show_bug.cgi?id=59394
3376
3377         Breaks compile because Deque<OwnPtr> doesn't work
3378
3379         * dom/XMLDocumentParserLibxml2.cpp:
3380         (WebCore::PendingCallbacks::~PendingCallbacks):
3381         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3382         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3383         (WebCore::PendingCallbacks::appendCharactersCallback):
3384         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3385         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3386         (WebCore::PendingCallbacks::appendCommentCallback):
3387         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3388         (WebCore::PendingCallbacks::appendErrorCallback):
3389         (WebCore::XMLDocumentParser::XMLDocumentParser):
3390         * html/ValidationMessage.cpp:
3391         (WebCore::ValidationMessage::setMessage):
3392         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3393         (WebCore::ValidationMessage::requestToHideMessage):
3394
3395 2011-04-25  James Robinson  <jamesr@chromium.org>
3396
3397         Reviewed by Sam Weinig.
3398
3399         Fix OwnPtr strict mode violation in ImageBufferCG
3400         https://bugs.webkit.org/show_bug.cgi?id=59396
3401
3402         * platform/graphics/cg/ImageBufferCG.cpp:
3403         (WebCore::ImageBuffer::ImageBuffer):
3404
3405 2011-04-25  Huang Dongsung  <luxtella@company100.net>
3406
3407         Reviewed by Dirk Schulze.
3408
3409         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
3410         https://bugs.webkit.org/show_bug.cgi?id=59308
3411
3412         An unused local variable is created and even allocates heap memory.
3413
3414         * platform/graphics/skia/PlatformContextSkia.cpp:
3415         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
3416
3417 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3418
3419         Qt build fix: Updated files not used by other ports for rename.
3420
3421         * bindings/js/JSTouchCustom.cpp:
3422         (WebCore::toJSNewlyCreated):
3423         * bindings/js/JSTouchListCustom.cpp:
3424         (WebCore::toJSNewlyCreated):
3425
3426 2011-04-25  Adrienne Walker  <enne@google.com>
3427
3428         Reviewed by David Levin.
3429
3430         WebCore/css/CSS* files should play nice with strict OwnPtrs
3431         https://bugs.webkit.org/show_bug.cgi?id=59382
3432
3433         * css/CSSFontFaceSource.cpp:
3434         (WebCore::CSSFontFaceSource::getFontData):
3435         * css/CSSParser.cpp:
3436         (WebCore::CSSParser::addProperty):
3437         (WebCore::CSSParser::parseValue):
3438
3439 2011-04-25  Adam Barth  <abarth@webkit.org>
3440
3441         Reviewed by James Robinson.
3442
3443         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
3444         https://bugs.webkit.org/show_bug.cgi?id=59394
3445
3446         * dom/XMLDocumentParserLibxml2.cpp:
3447         (WebCore::PendingCallbacks::PendingCallbacks):
3448         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3449         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3450         (WebCore::PendingCallbacks::appendCharactersCallback):
3451         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3452         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3453         (WebCore::PendingCallbacks::appendCommentCallback):
3454         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3455         (WebCore::PendingCallbacks::appendErrorCallback):
3456         (WebCore::XMLDocumentParser::XMLDocumentParser):
3457         * html/ValidationMessage.cpp:
3458         (WebCore::ValidationMessage::setMessage):
3459         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3460         (WebCore::ValidationMessage::requestToHideMessage):
3461
3462 2011-04-25  James Robinson  <jamesr@chromium.org>
3463
3464         Reviewed by Adam Barth.
3465
3466         Fix OwnPtr strictness issues in WebCore/inspector/
3467         https://bugs.webkit.org/show_bug.cgi?id=59387
3468
3469         * inspector/InspectorAgent.cpp:
3470         (WebCore::InspectorAgent::InspectorAgent):
3471         * inspector/InspectorController.cpp:
3472         (WebCore::InspectorController::InspectorController):
3473         * inspector/InspectorStyleSheet.cpp:
3474         (WebCore::InspectorStyleSheet::ensureSourceData):
3475
3476 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3477
3478         Reviewed by Beth Dakin.
3479
3480         Removed XPathNamespace because it was unused
3481         https://bugs.webkit.org/show_bug.cgi?id=59381
3482         
3483         This allows us to make Node::ownerDocument() non-virtual, though it has
3484         the unhappy side-effect of rebuilding the world.
3485
3486         * CMakeLists.txt:
3487         * GNUmakefile.list.am:
3488         * WebCore.gypi:
3489         * WebCore.pro:
3490         * WebCore.vcproj/WebCore.vcproj:
3491         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
3492
3493         * dom/Node.h: Hello fast code!
3494
3495         * xml/XPathNamespace.cpp: Removed.
3496         * xml/XPathNamespace.h: Removed.
3497
3498 2011-04-25  Adam Barth  <abarth@webkit.org>
3499
3500         Reviewed by Darin Adler.
3501
3502         HistoryItemMac should play nice with OwnPtrs
3503         https://bugs.webkit.org/show_bug.cgi?id=59388
3504
3505         * history/mac/HistoryItemMac.mm:
3506         (WebCore::HistoryItem::setTransientProperty):
3507
3508 2011-04-25  David Levin  <levin@chromium.org>
3509
3510         Reviewed by Kenneth Russell.
3511
3512         Fix strict OwnPtrs in ContextMenuController.cpp
3513         https://bugs.webkit.org/show_bug.cgi?id=59375
3514
3515         * page/ContextMenuController.cpp:
3516         (WebCore::ContextMenuController::createContextMenu):
3517         (WebCore::separatorItem):
3518
3519 2011-04-25  Adam Barth  <abarth@webkit.org>
3520
3521         Reviewed by Darin Adler.
3522
3523         CheckedRadioButton should play nice with strict OwnPtr
3524         https://bugs.webkit.org/show_bug.cgi?id=59386
3525
3526         * dom/CheckedRadioButtons.cpp:
3527         (WebCore::CheckedRadioButtons::addButton):
3528
3529 2011-04-25  Adam Barth  <abarth@webkit.org>
3530
3531         Reviewed by David Levin.
3532
3533         Resource*.cpp should play nice with strict OwnPtrs
3534         https://bugs.webkit.org/show_bug.cgi?id=59383
3535
3536         * bridge/runtime_method.cpp:
3537         (JSC::RuntimeMethod::RuntimeMethod):
3538         * platform/network/ResourceHandle.cpp:
3539         (WebCore::ResourceHandle::ResourceHandle):
3540         * platform/network/ResourceResponseBase.cpp:
3541         (WebCore::ResourceResponseBase::adopt):
3542         (WebCore::ResourceResponseBase::copyData):
3543
3544 2011-04-25  Adam Barth  <abarth@webkit.org>
3545
3546         Reviewed by David Levin.
3547
3548         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
3549         https://bugs.webkit.org/show_bug.cgi?id=59374
3550
3551         * bridge/objc/objc_runtime.mm:
3552         (JSC::Bindings::callObjCFallbackObject):
3553         * page/Page.cpp:
3554         (WebCore::Page::Page):
3555         (WebCore::Page::initGroup):
3556         * page/PageGroup.cpp:
3557         (WebCore::PageGroup::addUserScriptToWorld):
3558         (WebCore::PageGroup::addUserStyleSheetToWorld):
3559         * page/mac/PageMac.cpp:
3560         (WebCore::Page::addSchedulePair):
3561
3562 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3563
3564         Build fix: This time for sure!
3565         
3566         * dom/make_names.pl:
3567
3568 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3569
3570         Build fix: Let's edit the script instead of the autogenrated file. That
3571         way, our change will stand the test of time.
3572
3573         * dom/make_names.pl:
3574
3575 2011-04-25  Adam Barth  <abarth@webkit.org>
3576
3577         Reviewed by David Levin.
3578
3579         Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
3580         https://bugs.webkit.org/show_bug.cgi?id=59368
3581
3582         * html/HTMLMediaElement.cpp:
3583         (WebCore::HTMLMediaElement::HTMLMediaElement):
3584         * platform/network/HTTPHeaderMap.cpp:
3585         (WebCore::HTTPHeaderMap::copyData):
3586
3587 2011-04-25  James Robinson  <jamesr@chromium.org>
3588
3589         Reviewed by Adam Barth.
3590
3591         Fix strict OwnPtr violations in Render*.cpp
3592         https://bugs.webkit.org/show_bug.cgi?id=59361
3593
3594         * rendering/RenderBlock.cpp:
3595         (WebCore::RenderBlock::RenderBlock):
3596         (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
3597         * rendering/RenderBox.cpp:
3598         (WebCore::RenderBox::addLayoutOverflow):
3599         (WebCore::RenderBox::addVisualOverflow):
3600         * rendering/RenderButton.cpp:
3601         (WebCore::RenderButton::styleDidChange):
3602         * rendering/RenderLayer.cpp:
3603         (WebCore::RenderLayer::updateTransform):
3604         (WebCore::RenderLayer::paintChildLayerIntoColumns):
3605         (WebCore::RenderLayer::hitTestChildLayerColumns):
3606         (WebCore::RenderLayer::ensureBacking):
3607         * rendering/RenderTable.cpp:
3608         (WebCore::RenderTable::styleDidChange):
3609         * rendering/RenderView.cpp:
3610         (WebCore::RenderView::compositor):
3611         * rendering/style/RenderStyle.cpp:
3612         (WebCore::RenderStyle::addCachedPseudoStyle):
3613         (WebCore::RenderStyle::accessCounterDirectives):
3614         (WebCore::RenderStyle::accessAnimations):
3615         (WebCore::RenderStyle::accessTransitions):
3616         * rendering/svg/RenderSVGResourceFilter.cpp:
3617         (WebCore::RenderSVGResourceFilter::applyResource):
3618         * rendering/svg/SVGResources.cpp:
3619         (WebCore::SVGResources::SVGResources):
3620
3621 2011-04-25  Adam Barth  <abarth@webkit.org>
3622
3623         Attempt to fix the compile.
3624
3625         * platform/graphics/MediaPlayer.cpp:
3626         (WebCore::MediaPlayer::loadWithNextMediaEngine):
3627
3628 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3629
3630         Rubber-stamped by Beth Dakin.
3631
3632         Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into 
3633         CREATE_DOM_WRAPPER because there's no meaningful difference between
3634         them anymore.
3635
3636         * bindings/js/JSCDATASectionCustom.cpp:
3637         (WebCore::toJSNewlyCreated):
3638         * bindings/js/JSCSSRuleCustom.cpp:
3639         (WebCore::toJS):
3640         * bindings/js/JSCSSValueCustom.cpp:
3641         (WebCore::toJS):
3642         * bindings/js/JSDOMBinding.h:
3643         * bindings/js/JSDocumentCustom.cpp:
3644         (WebCore::toJS):
3645         * bindings/js/JSElementCustom.cpp:
3646         (WebCore::toJSNewlyCreated):
3647         * bindings/js/JSEventCustom.cpp:
3648         (WebCore::toJS):
3649         * bindings/js/JSHTMLCollectionCustom.cpp:
3650         (WebCore::toJS):
3651         * bindings/js/JSImageDataCustom.cpp:
3652         (WebCore::toJS):
3653         * bindings/js/JSNodeCustom.cpp:
3654         (WebCore::createWrapperInline):
3655         * bindings/js/JSSVGPathSegCustom.cpp:
3656         (WebCore::toJS):
3657         * bindings/js/JSStyleSheetCustom.cpp:
3658         (WebCore::toJS):
3659         * bindings/js/JSTextCustom.cpp:
3660         (WebCore::toJSNewlyCreated):
3661         * bindings/js/JSWebKitCSSMatrixCustom.cpp:
3662         (WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
3663         * bindings/js/JSWebSocketCustom.cpp:
3664         (WebCore::JSWebSocketConstructor::constructJSWebSocket):
3665         * bindings/js/JSXMLHttpRequestCustom.cpp:
3666         (WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
3667         * bindings/js/JSXSLTProcessorCustom.cpp:
3668         (WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
3669
3670 2011-04-25  Adam Barth  <abarth@webkit.org>
3671
3672         Reviewed by James Robinson.
3673
3674         HTMLDocumentParser should play nice with OwnPtrs
3675         https://bugs.webkit.org/show_bug.cgi?id=59363
3676
3677         * html/parser/HTMLDocumentParser.cpp:
3678         (WebCore::HTMLDocumentParser::pumpTokenizer):
3679
3680 2011-04-25  Adam Barth  <abarth@webkit.org>
3681
3682         Reviewed by James Robinson.
3683
3684         Frame.cpp should work with strict OwnPtrs
3685         https://bugs.webkit.org/show_bug.cgi?id=59360
3686
3687         * page/Frame.cpp:
3688         (WebCore::createRegExpForLabels):
3689
3690 2011-04-25  Adam Barth  <abarth@webkit.org>
3691
3692         Reviewed by David Levin.
3693
3694         Fix strict OwnPtr in Element.cpp
3695         https://bugs.webkit.org/show_bug.cgi?id=59357
3696
3697         * dom/NodeRareData.h:
3698         (WebCore::NodeRareData::ensureEventTargetData):
3699
3700 2011-04-25  Adam Barth  <abarth@webkit.org>
3701
3702         Reviewed by David Levin.
3703
3704         Fix strict OwnPtr issues in Media*.cpp
3705         https://bugs.webkit.org/show_bug.cgi?id=59354
3706
3707         There's still a tricky case in MediaPlayer.cpp, but we'll worry about
3708         that later.
3709
3710         * css/MediaQueryMatcher.cpp:
3711         (WebCore::MediaQueryMatcher::addListener):
3712         * dom/Document.cpp:
3713         * platform/graphics/MediaPlayer.cpp:
3714         (WebCore::createNullMediaPlayer):
3715
3716 2011-04-25  James Robinson  <jamesr@chromium.org>
3717
3718         Reviewed by David Levin.
3719
3720         Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
3721         https://bugs.webkit.org/show_bug.cgi?id=59353
3722
3723         * rendering/RenderLayerCompositor.cpp:
3724         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
3725
3726 2011-04-25  Adam Barth  <abarth@webkit.org>
3727
3728         Reviewed by James Robinson.
3729
3730         Worker*.cpp should work with strict OwnPtrs
3731         https://bugs.webkit.org/show_bug.cgi?id=59346
3732
3733         * inspector/WorkerInspectorController.cpp:
3734         (WebCore::WorkerInspectorController::WorkerInspectorController):
3735         * workers/WorkerContext.cpp:
3736         (WebCore::WorkerContext::WorkerContext):
3737         * workers/WorkerRunLoop.cpp:
3738         (WebCore::WorkerRunLoop::WorkerRunLoop):
3739         * workers/WorkerScriptLoader.cpp:
3740         (WebCore::WorkerScriptLoader::createResourceRequest):
3741
3742 2011-04-25  James Robinson  <jamesr@chromium.org>
3743
3744         Reviewed by Adam Barth.
3745
3746         Remove bad use of OwnPtr::set() in IconDatabase.cpp
3747         https://bugs.webkit.org/show_bug.cgi?id=59344
3748
3749         Needed for strict OwnPtr compliance.
3750
3751         * loader/icon/IconDatabase.cpp:
3752         (WebCore::readySQLiteStatement):
3753
3754 2011-04-25  Adam Barth  <abarth@webkit.org>
3755
3756         Reviewed by Maciej Stachowiak.
3757
3758         ImageBuffer.h should work with strict OwnPtrs
3759         https://bugs.webkit.org/show_bug.cgi?id=59341
3760
3761         This patch is to prepare for the strict OwnPtr hack-a-thon.
3762
3763         * platform/graphics/ImageBuffer.h:
3764         (WebCore::ImageBuffer::create):
3765
3766 2011-04-25  Steve Falkenburg  <sfalken@apple.com>
3767
3768         Reviewed by Brian Weinstein.
3769
3770         WebCore build on Windows should include windows.h in its precompiled header to speed builds
3771         https://bugs.webkit.org/show_bug.cgi?id=59339
3772
3773         windows.h is included by several of the underlying wtf headers, including Atomics.h and
3774         ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
3775         
3776         On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
3777         (a 12% speedup).
3778
3779         * WebCorePrefix.h: Include windows.h
3780
3781 2011-04-25  Martin Robinson  <mrobinson@igalia.com>
3782
3783         Reviewed by Xan Lopez.
3784
3785         [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
3786         https://bugs.webkit.org/show_bug.cgi?id=59311
3787
3788         * platform/gtk/MainFrameScrollbarGtk.cpp:
3789         (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar
3790         disconnect any lingering signal handlers. This prevents an adjustment from controlling the
3791         active ScrollView and some zombie ScrollView.
3792
3793 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3794
3795         Another shot at fixing the EFL build.
3796
3797         * UseJSC.cmake:
3798         * bindings/js/JSDOMBinding.cpp:
3799
3800 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3801
3802         Try to fix EFL build.
3803
3804         * UseJSC.cmake: Added a missing file.
3805
3806 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3807
3808         Reviewed by Oliver Hunt.
3809
3810         Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
3811         https://bugs.webkit.org/show_bug.cgi?id=59333
3812
3813         * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
3814
3815         * bindings/js/JSDOMBinding.cpp:
3816         * bindings/js/JSDOMBinding.h:
3817         * bindings/js/JSDocumentCustom.cpp:
3818         * bindings/js/JSWorkerContextCustom.cpp:
3819         (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
3820
3821         * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
3822         lifetime management.
3823
3824         * dom/Document.idl: No need for a custom mark function anymore, since
3825         ActiveDOMObjets now manage their own lifetimes.
3826
3827         * dom/MessagePort.cpp:
3828         (WebCore::MessagePort::hasPendingActivity): Correctly report that we
3829         have pending activity when we're remotely entangled, instead of relying
3830         on our clients to know this about us and do the check for us.
3831
3832         * dom/MessagePort.h: FIXME!
3833
3834         * dom/MessagePort.idl:
3835         * fileapi/DOMFileSystem.idl:
3836         * fileapi/FileReader.idl:
3837         * fileapi/FileWriter.idl:
3838         * notifications/Notification.idl:
3839         * notifications/NotificationCenter.idl:
3840         * page/EventSource.idl:
3841         * storage/IDBDatabase.idl:
3842         * storage/IDBRequest.idl:
3843         * storage/IDBTransaction.idl:
3844         * webaudio/AudioContext.idl:
3845         * websockets/WebSocket.idl:
3846         * workers/AbstractWorker.idl:
3847         * workers/SharedWorker.idl:
3848         * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
3849
3850         * workers/WorkerContext.cpp:
3851         (WebCore::WorkerContext::hasPendingActivity): No need to make up for
3852         MessagePort::hasPendingActivity being wrong anymore, since it's now right.
3853
3854         * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
3855
3856 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3857
3858         Reviewed by Pavel Feldman.
3859
3860         Web Inspector: worker messages should be routed to corresponding worker front-end
3861         https://bugs.webkit.org/show_bug.cgi?id=59323
3862
3863         Added WorkerManager which is responsible for routing messages between
3864         Page inspector front-end and Worker inspector front-ends.
3865
3866         * WebCore.gypi:
3867         * inspector/front-end/WebKit.qrc:
3868         * inspector/front-end/WorkerManager.js: Added.
3869         (WebInspector.WorkerManager):
3870         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend):
3871         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded):
3872         (WebInspector.WorkerManager.loaded):
3873         (WebInspector.WorkerFrontendStub):
3874         (WebInspector.WorkerFrontendStub.prototype._receiveMessage):
3875         (WebInspector.WorkerDispatcher):
3876         (WebInspector.WorkerDispatcher.prototype._receiveMessage):
3877         (WebInspector.WorkerDispatcher.prototype.workerCreated):
3878         (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
3879         * inspector/front-end/inspector.html:
3880         * inspector/front-end/inspector.js:
3881         (WebInspector.loaded):
3882
3883 2011-04-25  Annie Sullivan  <sullivan@chromium.org>
3884
3885         Reviewed by Pavel Feldman.
3886
3887         Web Inspector: [Resources panel] Should be easy to copy data.
3888         https://bugs.webkit.org/show_bug.cgi?id=45662
3889
3890         Adds context menu items to copy resource location, resource request headers, and resource response headers.
3891
3892         * inspector/front-end/NetworkPanel.js:
3893         (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
3894         (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
3895         (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
3896         (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
3897         * inspector/front-end/Resource.js:
3898         (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
3899         (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
3900
3901 2011-04-25  Alexander Pavlov  <apavlov@chromium.org>
3902
3903         Reviewed by Yury Semikhatsky.
3904
3905         Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
3906         https://bugs.webkit.org/show_bug.cgi?id=59322
3907
3908         Use TextResourceDecoder to determine external stylesheet charsets correctly.
3909
3910         Test: inspector/styles/parse-utf8-bom.html
3911
3912         * inspector/InspectorStyleSheet.cpp:
3913         (WebCore::InspectorStyleSheet::originalStyleSheetText):
3914
3915 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3916
3917         Not reviewed: Inspector.json cleanup.
3918
3919         * inspector/Inspector.json:
3920
3921 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3922
3923         Reviewed by Pavel Feldman.
3924
3925         Web Inspector: introduce InspectorWorkerAgent
3926         https://bugs.webkit.org/show_bug.cgi?id=59320
3927
3928         InspectorWorkerAgent is responsible for routing inspector messages
3929         between worker context inspector agents and corresponding worker
3930         inspector front-end.
3931
3932         * CMakeLists.txt:
3933         * GNUmakefile.list.am:
3934         * WebCore.gypi:
3935         * WebCore.pro:
3936         * WebCore.vcproj/WebCore.vcproj:
3937         * WebCore.xcodeproj/project.pbxproj:
3938         * inspector/CodeGeneratorInspector.pm:
3939         * inspector/Inspector.json:
3940         * inspector/InspectorAgent.cpp:
3941         (WebCore::InspectorAgent::InspectorAgent):
3942         (WebCore::InspectorAgent::setFrontend):
3943         (WebCore::InspectorAgent::disconnectFrontend):
3944         * inspector/InspectorAgent.h:
3945         (WebCore::InspectorAgent::workerAgent):
3946         * inspector/InspectorController.cpp:
3947         (WebCore::InspectorController::connectFrontend):
3948         (WebCore::InspectorController::disconnectFrontend):
3949         * inspector/InspectorInstrumentation.cpp:
3950         (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
3951         * inspector/InspectorInstrumentation.h:
3952         (WebCore::InspectorInstrumentation::willStartWorkerContext):
3953         (WebCore::InspectorInstrumentation::didStartWorkerContext):
3954         * inspector/InspectorWorkerAgent.cpp: Added.
3955         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
3956         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
3957         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
3958         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
3959         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
3960         (WebCore::InspectorWorkerAgent::create):
3961         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
3962         (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
3963         (WebCore::InspectorWorkerAgent::setFrontend):
3964         (WebCore::InspectorWorkerAgent::clearFrontend):
3965         (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
3966         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
3967         * inspector/InspectorWorkerAgent.h: Added.
3968         * inspector/InstrumentingAgents.h:
3969         (WebCore::InstrumentingAgents::InstrumentingAgents):
3970         (WebCore::InstrumentingAgents::inspectorWorkerAgent):
3971         (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
3972         * inspector/WorkerInspectorController.cpp:
3973         (WebCore::WorkerInspectorController::connectFrontend):
3974         * inspector/generate-inspector-idl:
3975         * workers/Worker.cpp:
3976         (WebCore::Worker::notifyFinished):
3977         * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
3978         messages sent from the inspected page worker agent to the worker context inspector agents.
3979         (WebCore::WorkerContextInspectorProxy::connectFrontend):
3980         (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
3981         (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
3982         (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
3983         * workers/WorkerContextProxy.h:
3984         (WebCore::WorkerContextProxy::inspectorProxy):
3985
3986 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3987
3988         Reviewed by Yury Semikhatsky.
3989
3990         Web Inspector: move Frame and Resource Tree management into the Page agent.
3991         https://bugs.webkit.org/show_bug.cgi?id=59321
3992
3993         Network agent should only handle network-related activities.
3994         Frame structure should be managed by the Page agent instead.
3995
3996         * inspector/Inspector.json:
3997         * inspector/InspectorAgent.cpp:
3998         (WebCore::InspectorAgent::InspectorAgent):
3999         * inspector/InspectorDOMAgent.cpp:
4000         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
4001         (WebCore::InspectorDOMAgent::setFrontend):
4002         (WebCore::InspectorDOMAgent::restore):
4003         (WebCore::InspectorDOMAgent::highlightFrame):
4004         * inspector/InspectorDOMAgent.h:
4005         (WebCore::InspectorDOMAgent::create):
4006         * inspector/InspectorInstrumentation.cpp:
4007         (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
4008         (WebCore::InspectorInstrumentation::loadEventFiredImpl):
4009         (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
4010         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
4011         * inspector/InspectorPageAgent.cpp:
4012         (WebCore::InspectorPageAgent::create):
4013         (WebCore::InspectorPageAgent::resourceContent):
4014         (WebCore::InspectorPageAgent::resourceContentBase64):
4015         (WebCore::InspectorPageAgent::resourceData):
4016         (WebCore::InspectorPageAgent::cachedResource):
4017         (WebCore::InspectorPageAgent::resourceTypeString):
4018         (WebCore::InspectorPageAgent::cachedResourceType):
4019         (WebCore::InspectorPageAgent::cachedResourceTypeString):
4020         (WebCore::InspectorPageAgent::InspectorPageAgent):
4021         (WebCore::InspectorPageAgent::setFrontend):
4022         (WebCore::InspectorPageAgent::reload):
4023         (WebCore::InspectorPageAgent::open):
4024         (WebCore::InspectorPageAgent::getCookies):
4025         (WebCore::InspectorPageAgent::deleteCookie):
4026         (WebCore::InspectorPageAgent::getResourceTree):
4027         (WebCore::InspectorPageAgent::getResourceContent):
4028         (WebCore::InspectorPageAgent::restore):
4029         (WebCore::InspectorPageAgent::domContentEventFired):
4030         (WebCore::InspectorPageAgent::loadEventFired):
4031         (WebCore::InspectorPageAgent::frameNavigated):
4032         (WebCore::InspectorPageAgent::frameDetached):
4033         (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
4034         (WebCore::InspectorPageAgent::mainFrame):
4035         (WebCore::pointerAsId):
4036         (WebCore::InspectorPageAgent::frameForId):
4037         (WebCore::InspectorPageAgent::frameId):
4038         (WebCore::InspectorPageAgent::loaderId):
4039         (WebCore::InspectorPageAgent::buildObjectForFrame):
4040         (WebCore::InspectorPageAgent::buildObjectForFrameTree):
4041         * inspector/InspectorPageAgent.h:
4042         * inspector/InspectorResourceAgent.cpp:
4043         (WebCore::buildObjectForCachedResource):
4044         (WebCore::InspectorResourceAgent::willSendRequest):
4045         (WebCore::InspectorResourceAgent::didReceiveResponse):
4046         (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
4047         (WebCore::InspectorResourceAgent::setInitialScriptContent):
4048         (WebCore::InspectorResourceAgent::setInitialXHRContent):
4049         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
4050         * inspector/InspectorResourceAgent.h:
4051         (WebCore::InspectorResourceAgent::create):
4052         * inspector/InspectorStyleSheet.cpp:
4053         (WebCore::InspectorStyleSheet::resourceStyleSheetText):
4054         * inspector/front-end/NetworkManager.js:
4055         (WebInspector.NetworkManager.prototype.requestContent):
4056         * inspector/front-end/NetworkPanel.js:
4057         (WebInspector.NetworkPanel):
4058         (WebInspector.NetworkPanel.prototype.frameNavigated):
4059         * inspector/front-end/ResourceTreeModel.js:
4060         (WebInspector.ResourceTreeModel):
4061         (WebInspector.ResourceTreeModel.prototype.frontendReused):
4062         (WebInspector.ResourceTreeModel.prototype.frameNavigated):
4063         (WebInspector.ResourceTreeModel.prototype.frameDetached):
4064         * inspector/front-end/inspector.js:
4065         (WebInspector.domContentEventFired):
4066         (WebInspector.loadEventFired):
4067         (WebInspector.frameNavigated):
4068         (WebInspector.frameDetached):
4069
4070 2011-04-25  Pavel Feldman  <pfeldman@google.com>
4071
4072         Reviewed by Yury Semikhatsky.
4073
4074         Web Inspector: few protocol improvements.
4075         https://bugs.webkit.org/show_bug.cgi?id=59319
4076
4077         - Page domain is documented
4078         - setUserAgentOverride is moved to the Network agent
4079         - setSearchingForNode -> setInspectModeEnabled
4080         - highlightDOMNode -> highlightNode
4081         - reloadPage -> reload
4082         - openInNewWindow -> open with optional parameter
4083
4084         * inspector/Inspector.json:
4085         * inspector/InspectorDOMAgent.cpp:
4086         (WebCore::InspectorDOMAgent::setInspectModeEnabled):
4087         (WebCore::InspectorDOMAgent::highlightNode):
4088         * inspector/InspectorDOMAgent.h:
4089         (WebCore::InspectorDOMAgent::hideNodeHighlight):
4090         * inspector/InspectorInstrumentation.cpp:
4091         (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
4092         * inspector/InspectorPageAgent.cpp:
4093         (WebCore::InspectorPageAgent::clearFrontend):
4094         (WebCore::InspectorPageAgent::reload):
4095         (WebCore::InspectorPageAgent::open):
4096         * inspector/InspectorPageAgent.h:
4097         * inspector/InspectorResourceAgent.cpp:
4098         (WebCore::InspectorResourceAgent::clearFrontend):
4099         (WebCore::InspectorResourceAgent::applyUserAgentOverride):
4100         (WebCore::InspectorResourceAgent::setUserAgentOverride):
4101         * inspector/InspectorResourceAgent.h:
4102         * inspector/front-end/AuditsPanel.js:
4103         (WebInspector.AuditsPanel.prototype._reloadResources):
4104         * inspector/front-end/ElementsPanel.js:
4105         (WebInspector.ElementsPanel.prototype.setSearchingForNode):
4106         * inspector/front-end/ExtensionServer.js:
4107         (WebInspector.ExtensionServer.prototype._onReload):
4108         * inspector/front-end/NetworkPanel.js:
4109         (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
4110         * inspector/front-end/ResourcesPanel.js:
4111         (WebInspector.FrameResourceTreeElement.prototype.ondblclick):