2011-04-28 Abhishek Arya <inferno@chromium.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-29  Abhishek Arya  <inferno@chromium.org>
2
3         Reviewed by Nikolas Zimmermann.
4
5         When svg inline text is getting destroyed, make sure to mark
6         its svg text ancestor as needing a positioning values update.
7         This helps to recalculate layout attributes and makes sure
8         that svg inline text is not used again.
9         https://bugs.webkit.org/show_bug.cgi?id=59161
10
11         Test: svg/text/inline-text-destroy-attributes-crash.xhtml
12
13         * rendering/svg/RenderSVGInlineText.cpp:
14         (WebCore::RenderSVGInlineText::destroy):
15         * rendering/svg/RenderSVGInlineText.h:
16
17 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
18
19         [wx] Unreviewed build fix. Fix wxMSW trunk builds by adding include.
20
21         * platform/graphics/wx/GraphicsContextWx.cpp:
22
23 2011-04-29  Mike Reed  <reed@google.com>
24
25         Reviewed by Ojan Vafai.
26
27         Skia: Need to implement GraphicsContext::clipConvexPolygon()
28         https://bugs.webkit.org/show_bug.cgi?id=41311
29
30         This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
31         as that shows other issues/question unrelated to clipping.
32         https://bugs.webkit.org/show_bug.cgi?id=41311
33
34         No new tests. covered by existing layout tests
35
36         * platform/graphics/skia/GraphicsContextSkia.cpp:
37         (WebCore::setPathFromConvexPoints):
38         (WebCore::GraphicsContext::drawConvexPolygon):
39         (WebCore::GraphicsContext::clipConvexPolygon):
40
41 2011-04-29  Mike Lawther  <mikelawther@chromium.org>
42
43         Reviewed by Ojan Vafai.
44
45         Fix IR->SR typo in enum value (and resulting style fails)
46         https://bugs.webkit.org/show_bug.cgi?id=59779
47
48         No functionality change, so no new tests
49
50         * css/CSSPrimitiveValueMappings.h:
51         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
52         (WebCore::CSSPrimitiveValue::operator EShapeRendering):
53
54 2011-04-29  Pavel Feldman  <pfeldman@google.com>
55
56         Reviewed by Yury Semikhatsky.
57
58         Web Inspector: CSS editing breaks when entering "color: rgb(1"
59         https://bugs.webkit.org/show_bug.cgi?id=59789
60
61         Tests: inspector/styles/styles-add-invalid-property.html
62                inspector/styles/styles-cancel-editing.html
63                inspector/styles/styles-commit-editing.html
64
65         * inspector/front-end/CSSStyleModel.js:
66         (WebInspector.CSSProperty.prototype.setText.callback):
67         (WebInspector.CSSProperty.prototype.setText):
68         * inspector/front-end/StylesSidebarPane.js:
69         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
70         (WebInspector.StylePropertyTreeElement.prototype):
71         (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
72         * inspector/front-end/inspector.js:
73         (WebInspector.startEditing.defaultFinishHandler):
74         (WebInspector.startEditing.keyDownEventListener):
75         (WebInspector.startEditing):
76
77 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
78
79         Reviewed by Simon Hausmann.
80
81         ENABLE(QT_BEARER) -> USE(QT_BEARER)
82
83         * WebCore.pri:
84         * WebCore.pro:
85         * features.pri:
86         * platform/network/NetworkStateNotifier.h:
87         * platform/network/qt/NetworkStateNotifierQt.cpp:
88
89 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
90
91         Reviewed by Simon Hausmann.
92
93         ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
94
95         * WebCore.pri:
96         * features.pri:
97
98 2011-04-29  Pavel Podivilov  <podivilov@chromium.org>
99
100         Reviewed by Pavel Feldman.
101
102         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
103         https://bugs.webkit.org/show_bug.cgi?id=59476
104
105         * inspector/front-end/DebuggerPresentationModel.js:
106         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
107         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
108         (WebInspector.PresentationBreakpoint.prototype.serialize):
109         * inspector/front-end/ScriptsPanel.js:
110         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
111         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
112         (WebInspector.ScriptsPanel.prototype.reset):
113
114 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
115
116         Reviewed by Yury Semikhatsky.
117
118         Web Inspector: include script end line:column in scriptParsed parameters.
119         https://bugs.webkit.org/show_bug.cgi?id=59717
120
121         * bindings/js/ScriptDebugServer.cpp:
122         (WebCore::ScriptDebugServer::dispatchDidParseSource):
123         * bindings/v8/DebuggerScript.js:
124         ():
125         * bindings/v8/ScriptDebugServer.cpp:
126         (WebCore::ScriptDebugServer::dispatchDidParseSource):
127         * inspector/Inspector.json:
128         * inspector/InspectorDebuggerAgent.cpp:
129         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
130         (WebCore::InspectorDebuggerAgent::didParseSource):
131         * inspector/InspectorDebuggerAgent.h:
132         (WebCore::InspectorDebuggerAgent::Script::Script):
133         * inspector/ScriptDebugListener.h:
134         * inspector/front-end/DebuggerModel.js:
135         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
136         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
137         (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
138         * inspector/front-end/Script.js:
139         (WebInspector.Script):
140
141 2011-04-28  Yury Semikhatsky  <yurys@chromium.org>
142
143         Reviewed by Pavel Feldman.
144
145         Web Inspector: [protocol] Evaluate should expose thrown exception value
146         https://bugs.webkit.org/show_bug.cgi?id=59000
147
148         Each evaluation command may have either thrown or returned result. This is indicated
149         by wasThrown property in the protocol.
150
151         * inspector/InjectedScript.cpp:
152         (WebCore::InjectedScript::evaluate):
153         (WebCore::InjectedScript::evaluateOn):
154         (WebCore::InjectedScript::evaluateOnCallFrame):
155         (WebCore::InjectedScript::getProperties):
156         (WebCore::InjectedScript::makeEvalCall):
157         * inspector/InjectedScript.h:
158         * inspector/InjectedScriptSource.js:
159         * inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to
160         the evaluation results.
161         * inspector/InspectorDebuggerAgent.cpp:
162         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
163         * inspector/InspectorDebuggerAgent.h:
164         * inspector/InspectorRuntimeAgent.cpp:
165         (WebCore::InspectorRuntimeAgent::evaluate):
166         (WebCore::InspectorRuntimeAgent::evaluateOn):
167         (WebCore::InspectorRuntimeAgent::getProperties):
168         * inspector/InspectorRuntimeAgent.h:
169         * inspector/front-end/ConsoleView.js:
170         (WebInspector.ConsoleView.prototype.completions.evaluated):
171         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
172         (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
173         (WebInspector.ConsoleView.prototype._enterKeyPressed):
174         (WebInspector.ConsoleCommandResult):
175         * inspector/front-end/DebuggerPresentationModel.js:
176         (WebInspector.PresenationCallFrame.prototype.evaluate):
177         * inspector/front-end/ElementsTreeOutline.js:
178         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
179         * inspector/front-end/ExtensionPanel.js:
180         (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
181         * inspector/front-end/ExtensionServer.js:
182         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
183         * inspector/front-end/ObjectPropertiesSection.js:
184         (WebInspector.ObjectPropertyTreeElement.prototype.update):
185         * inspector/front-end/PropertiesSidebarPane.js:
186         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
187         * inspector/front-end/SourceFrame.js:
188         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
189         (WebInspector.SourceFrame.prototype._showPopup):
190
191 2011-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
192
193         Unreviewed, rolling out r85315.
194         http://trac.webkit.org/changeset/85315
195         https://bugs.webkit.org/show_bug.cgi?id=59792
196
197         Broke script-formatter.html test (Requested by podivilov on
198         #webkit).
199
200         * inspector/front-end/DebuggerPresentationModel.js:
201         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
202         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint):
203         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
204         (WebInspector.PresentationBreakpoint.prototype.serialize):
205         * inspector/front-end/ScriptsPanel.js:
206         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
207         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
208         (WebInspector.ScriptsPanel.prototype.reset):
209
210 2011-04-29  Vsevolod Vlasov  <vsevik@chromium.org>
211
212         Reviewed by Pavel Feldman.
213
214         Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
215         https://bugs.webkit.org/show_bug.cgi?id=58794
216
217         Added ping requests to network panel.
218
219         Test: http/tests/inspector/network/ping.html
220
221         * English.lproj/localizedStrings.js:
222         * inspector/InspectorInstrumentation.cpp:
223         (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
224         * inspector/InspectorInstrumentation.h:
225         (WebCore::InspectorInstrumentation::continueAfterPingLoader):
226         * inspector/front-end/NetworkPanel.js:
227         (WebInspector.NetworkDataGridNode.prototype.refreshResource):
228         (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
229         (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
230         * inspector/front-end/Resource.js:
231         (WebInspector.Resource.prototype.get formParameters):
232         (WebInspector.Resource.prototype.requestContentType):
233         (WebInspector.Resource.prototype.isPingRequest):
234         * loader/PingLoader.cpp:
235         (WebCore::PingLoader::PingLoader):
236         * loader/PingLoader.h:
237
238 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
239
240         Reviewed by Pavel Feldman.
241
242         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
243         https://bugs.webkit.org/show_bug.cgi?id=59476
244
245         * inspector/front-end/DebuggerPresentationModel.js:
246         (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
247         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
248         (WebInspector.PresentationBreakpoint.prototype.serialize):
249         * inspector/front-end/ScriptsPanel.js:
250         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
251         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
252         (WebInspector.ScriptsPanel.prototype.reset):
253
254 2011-04-29  Pavel Feldman  <pfeldman@google.com>
255
256         Reviewed by Yury Semikhatsky.
257
258         Web Inspector: add "open link in new tab" action into the network and resources panels.
259         https://bugs.webkit.org/show_bug.cgi?id=59788
260
261         This change also distinguishes context menu items case between platforms.
262
263         * English.lproj/localizedStrings.js:
264         * inspector/front-end/ConsoleView.js:
265         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
266         * inspector/front-end/DOMBreakpointsSidebarPane.js:
267         (WebInspector.DOMBreakpointsSidebarPane):
268         * inspector/front-end/ElementsPanel.js:
269         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
270         (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
271         * inspector/front-end/ElementsTreeOutline.js:
272         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
273         (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
274         * inspector/front-end/NetworkPanel.js:
275         (WebInspector.NetworkPanel.prototype._contextMenu):
276         * inspector/front-end/ResourcesPanel.js:
277         (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
278         (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
279         (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
280         * inspector/front-end/Settings.js:
281         * inspector/front-end/SourceFrame.js:
282         (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
283         * inspector/front-end/TextViewer.js:
284         (WebInspector.TextViewer.prototype._contextMenu):
285         * inspector/front-end/inspector.js:
286         (WebInspector.openLinkExternallyLabel):
287         (WebInspector.openResource):
288         (WebInspector.useLowerCaseMenuTitles):
289
290 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
291
292         Reviewed by Dan Bernstein.
293
294         Mask placement on composited layer is incorrect sometimes
295         https://bugs.webkit.org/show_bug.cgi?id=59775
296         
297         The mask layer always has the same size as its owning GraphicsLayer,
298         so it needs to share the same offsetFromRenderer as well. This fixes
299         the offset at which the mask layer contents are painted in cases where
300         that offset is non-zero, for example when outline style bloats all of
301         the layer sizes.
302
303         Test: compositing/masks/layer-mask-placement.html
304
305         * rendering/RenderLayerBacking.cpp:
306         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
307
308 2011-04-28  Dan Bernstein  <mitz@apple.com>
309
310         Rubber-stamped by Mark Rowe.
311
312         Reverted r81319.
313
314         Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu
315
316         * page/NavigatorBase.cpp:
317
318 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
319
320         Reviewed by Dirk Schulze.
321
322         1px box-shadow looks ugly
323         https://bugs.webkit.org/show_bug.cgi?id=58100
324         and
325         ShadowBlur incorrectly handles zero-sized blur radius in one axis
326         https://bugs.webkit.org/show_bug.cgi?id=59710
327         
328         blurLayerImage() has issues at the edges if the blur radius
329         is one, so in that case bump the buffer size out by a pixel.
330         This results in a correct, symmetrical blur.
331         
332         Also fix an issue noticed during testing where a zero
333         height or width radius would still blur on that axis,
334         because we clamp the kernel size to a minimum of two.
335
336         Test: fast/box-shadow/single-pixel-shadow.html
337
338         * platform/graphics/ShadowBlur.h:
339         * platform/graphics/ShadowBlur.cpp:
340         (WebCore::ShadowBlur::blurLayerImage):
341         Skip horizontal or vertial passes if the radius on that axis is zero.
342         Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
343         clause to the end of the loop, since it only needs to execute once
344         after the first pass.        
345         (WebCore::ShadowBlur::blurredEdgeSize):
346         New method to compute the width of the blurred edge (radius + extra
347         pixel when necessary).
348         (WebCore::ShadowBlur::calculateLayerBoundingRect):
349         (WebCore::ShadowBlur::templateSize):
350         (WebCore::ShadowBlur::drawRectShadow):
351         (WebCore::ShadowBlur::drawInsetShadow):
352         (WebCore::ShadowBlur::drawInsetShadowWithTiling):
353         (WebCore::ShadowBlur::drawRectShadowWithTiling):
354         (WebCore::ShadowBlur::drawLayerPieces):
355         Use the result of blurredEdgeSize() rather than recomputing.
356
357 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
358
359         Reviewed by Beth Dakin.
360
361         CSS sibling selector (~) does not work with :target pseudo class
362         https://bugs.webkit.org/show_bug.cgi?id=26539
363
364         Allow style recalculation of forward siblings of elements with
365         forward positional rules.
366
367         Tests: fast/css/pseudo-target-indirect-sibling-001.html
368                fast/css/pseudo-target-indirect-sibling-002.html
369
370         * dom/Element.cpp:
371         (WebCore::Element::recalcStyle):
372
373 2011-04-28  Nat Duca  <nduca@chromium.org>
374
375         Reviewed by Kenneth Russell.
376
377         [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
378         https://bugs.webkit.org/show_bug.cgi?id=59626
379
380         * platform/graphics/chromium/Extensions3DChromium.h:
381         (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
382
383 2011-04-28  Steve Lacey  <sjl@chromium.org>
384
385         Reviewed by Eric Carlson.
386
387         Change chromium media controls to use absolute positioning until bug 59644 is fixed.
388         https://bugs.webkit.org/show_bug.cgi?id=59732
389
390         * css/mediaControlsChromium.css:
391         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
392         (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
393
394 2011-04-28  Luke Macpherson   <macpherson@chromium.org>
395
396         Reviewed by Eric Seidel.
397
398         Implement CSS border width and related properties in CSSStyleApplyProperty.
399         https://bugs.webkit.org/show_bug.cgi?id=59414
400
401         No new tests as no functionality added.
402
403         * css/CSSStyleApplyProperty.cpp:
404         Separated ApplyPropertyDefault into parent and child so that other classes could inherit
405         the applyInheritValue and applyInitialValue methods only.
406         This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().
407         
408         Added ApplyPropertyWidth class for handling width based CSS properties.
409         * css/CSSStyleSelector.cpp:
410         Removed no-longer-required code for handling width based CSS properties.
411         * css/CSSStyleSelector.h:
412         Added a getter for m_rootElementStyle.
413
414 2011-04-28  Kent Tamura  <tkent@chromium.org>
415
416         Run sort-Xcode-project-file.
417
418         * WebCore.xcodeproj/project.pbxproj:
419
420 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
421
422         Reviewed by Dirk Schulze.
423
424         [Cairo] Text underline is not shadowed when text-shadow is enabled
425         https://bugs.webkit.org/show_bug.cgi?id=48074
426
427         Use ContextShadow to enable shadows for text underlines. Also remove quite a bit
428         of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
429         originally copied from the CG GraphicsContext.
430
431         * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
432           can call it from a static helper function.
433         * platform/graphics/cairo/GraphicsContextCairo.cpp:
434         (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
435         (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
436         call it multiple times when shadowing text underlines.
437         (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
438         (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
439         (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
440
441 2011-04-28  Sam Weinig  <sam@webkit.org>
442
443         Rubber-stamped by Mark Rowe.
444
445         Cleanup WebCore.xcodeproj a bit.
446
447         * WebCore.xcodeproj/project.pbxproj:
448         Added CompilerVersion.xcconfig and moved some JS bindings files into the
449         correct sub groups.
450
451 2011-04-28  David Levin  <levin@chromium.org>
452
453         Reviewed by Adam Barth.
454
455         Remove IMAGE_RESIZER related code.
456         https://bugs.webkit.org/show_bug.cgi?id=59735
457
458         * CMakeLists.txt:
459         * Configurations/FeatureDefines.xcconfig:
460         * GNUmakefile.am:
461         * GNUmakefile.list.am:
462         * WebCore.gypi:
463         * WebCore.pro:
464         * WebCore.vcproj/WebCore.vcproj:
465         * WebCore.xcodeproj/project.pbxproj:
466         * features.pri:
467         * html/AsyncImageResizer.cpp: Removed.
468         * html/AsyncImageResizer.h: Removed.
469         * html/ImageResizerThread.cpp: Removed.
470         * html/ImageResizerThread.h: Removed.
471
472 2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
473
474         Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
475
476         * inspector/front-end/Settings.js:
477         (WebInspector.Settings):
478
479 2011-04-28  Beth Dakin  <bdakin@apple.com>
480
481         Rubber-stamped by Sam Weinig.
482
483         Rolling out revision 85258! I want to fix that bug a different way.
484         * platform/mac/ScrollbarThemeMac.mm:
485         (WebCore::ScrollbarThemeMac::paint):
486
487 2011-04-28  Chang Shu  <cshu@webkit.org>
488
489         Reviewed by Eric Seidel.
490
491         isContentEditable is not working properly with document.designMode
492         https://bugs.webkit.org/show_bug.cgi?id=53031
493
494         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
495         indicates that the element.isContentEditable relies on document.designMode if its
496         and its ancestors' contenteditable attributes are set to inherit.
497
498         1. Sync document render style after document.designMode is changed.
499         2. Removed the code that does unnecessary and incorrect handling for contenteditable
500         attribute with "inherit" value.
501         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
502
503         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
504                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
505                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
506                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
507
508         * css/CSSStyleSelector.cpp:
509         (WebCore::CSSStyleSelector::styleForDocument):
510         * dom/Document.cpp:
511         (WebCore::Document::setDesignMode):
512         * dom/Node.cpp:
513         (WebCore::Node::rendererIsEditable):
514         * editing/ApplyStyleCommand.cpp:
515         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
516         * html/HTMLElement.cpp:
517         (WebCore::HTMLElement::setContentEditable):
518
519 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
520
521         Unreviewed, rolling out r85101.
522         http://trac.webkit.org/changeset/85101
523         https://bugs.webkit.org/show_bug.cgi?id=59757
524
525          it'd be better to rollout the patch and do another one with
526         another property name. Current one will bring us to a problem
527         at first run after upgrade because it's type was changed from
528         int to string. (Requested by loislo on #webkit).
529
530         * inspector/front-end/ScriptsPanel.js:
531         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
532         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
533         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
534
535 2011-04-28  Mike Reed  <reed@google.com>
536
537         Reviewed by Eric Seidel.
538
539         fix shadw behavior for both CSS and Canvas -- skia only
540         https://bugs.webkit.org/show_bug.cgi?id=59700
541
542         Test:
543         canvas/philip/tests/2d.shadow.alpha.3.html
544         canvas/philip/tests/2d.shadow.alpha.4.html
545         canvas/philip/tests/2d.shadow.alpha.5.html
546         fast/canvas/canvas-fillPath-alpha-shadow.html
547         fast/canvas/canvas-strokePath-alpha-shadow.html
548         fast/canvas/canvas-strokeRect-alpha-shadow.html
549         fast/css/text-input-with-webkit-border-radius.html
550         fast/repaint/shadow-multiple-horizontal.html
551         fast/repaint/shadow-multiple-strict-horizontal.html
552         fast/repaint/shadow-multiple-strict-vertical.html
553         fast/repaint/shadow-multiple-vertical.html
554         fast/canvas/canvas-getImageData.html
555
556         * platform/graphics/chromium/FontChromiumWin.cpp:
557         (WebCore::Font::drawGlyphs):
558         * platform/graphics/skia/GraphicsContextSkia.cpp:
559         (WebCore::GraphicsContext::setPlatformShadow):
560
561 2011-04-28  David Kilzer  <ddkilzer@apple.com>
562
563         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
564
565         Reviewed by Chris Fleizach.
566
567         Previously, AXObjectCache::attachWrapper over-retained each
568         AccessibilityObjectWrapper it created, which is why
569         AXObjectCache::detachWrapper() contained an extra -release.
570
571         * accessibility/mac/AXObjectCacheMac.mm:
572         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
573         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
574         assigns to a RetainPtr<> instance variable, it doesn't need a +1
575         retained object passed in.  Fix the leak by using a RetainPtr<>
576         for the AccessibilityObjectWrapper.
577
578 2011-04-28  Nat Duca  <nduca@chromium.org>
579
580         Reviewed by Darin Fisher.
581
582         [chromium] Compute compositor fps value and history using the frameBegin timestamp
583         https://bugs.webkit.org/show_bug.cgi?id=59668
584
585         This change switches the compositor FPS meter to use the timestamp
586         of the beginning of the frame rather than the time we call
587         swapBuffers. When scheduling is correctly tied to vsync, we can
588         have highly variable times when we finish vsync and still have
589         stable frame rates.
590
591         * platform/graphics/chromium/LayerRendererChromium.cpp:
592         (WebCore::LayerRendererChromium::updateAndDrawLayers):
593         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
594         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
595         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
596         (WebCore::CCHeadsUpDisplay::onFrameBegin):
597         (WebCore::CCHeadsUpDisplay::onPresent):
598         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
599
600 2011-04-28  Beth Dakin  <bdakin@apple.com>
601
602         Reviewed by Darin Adler.
603
604         https://bugs.webkit.org/show_bug.cgi?id=59759
605         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
606         track when there is nothing to scroll to
607         <rdar://problem/9282066>
608
609         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
610         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
611         is not right. Set the proportion to 0 in this case instead.
612         * platform/mac/ScrollbarThemeMac.mm:
613         (WebCore::ScrollbarThemeMac::paint):
614
615 2011-04-28  Dan Bernstein  <mitz@apple.com>
616
617         Reviewed by Simon Fraser.
618
619         <rdar://problem/9291132> Add support for -epub-prefixed properties
620
621         Test: fast/css/epub-properties.html
622
623         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
624         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
625         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
626         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
627         text-transform, text-transform, word-break, and -webkit-writing-mode.
628
629 2011-04-28  Adam Barth  <abarth@webkit.org>
630
631         Reviewed by Eric Seidel.
632
633         Remove WML
634         https://bugs.webkit.org/show_bug.cgi?id=59678
635
636         This patch removes WML from WebCore.  After removing WML, there's a
637         bunch of twisted code that could be untwisted, but this patch contains
638         only the purely mechanical part of removing the feature.
639
640         There's been a lot of discussion on webkit-dev about whether we should
641         remove WML.  In addition to those threads, we've had an informal poll
642         of the reviewers as well as an in-person discussion at the WebKit
643         contributor's meeting.  Removing any feature is likely to make some
644         folks unhappy, but, on balance, removing WML appears to be the right
645         thing for the project to do at this time.
646
647         * CMakeLists.txt:
648         * CodeGenerators.pri:
649         * Configurations/FeatureDefines.xcconfig:
650         * DerivedSources.cpp:
651         * DerivedSources.make:
652         * GNUmakefile.am:
653         * GNUmakefile.list.am:
654         * WebCore.gyp/WebCore.gyp:
655         * WebCore.gypi:
656         * WebCore.pro:
657         * WebCore.vcproj/WebCore.vcproj:
658         * WebCore.xcodeproj/project.pbxproj:
659         * css/CSSStyleSelector.cpp:
660         (WebCore::linkAttribute):
661         (WebCore::CSSStyleSelector::styleForElement):
662         (WebCore::CSSStyleSelector::adjustRenderStyle):
663         * css/wml.css: Removed.
664         * dom/DOMImplementation.cpp:
665         (WebCore::DOMImplementation::createDocument):
666         * dom/Document.cpp:
667         (WebCore::Document::Document):
668         (WebCore::Document::createElement):
669         * dom/Document.h:
670         (WebCore::Document::isMediaDocument):
671         * dom/Document.idl:
672         * dom/InputElement.h:
673         * dom/Node.cpp:
674         (WebCore::Node::toInputElement):
675         * dom/Node.h:
676         * dom/OptionElement.cpp:
677         (WebCore::toOptionElement):
678         (WebCore::isOptionElement):
679         * dom/OptionElement.h:
680         * dom/OptionGroupElement.cpp:
681         (WebCore::toOptionGroupElement):
682         (WebCore::isOptionGroupElement):
683         * dom/SelectElement.cpp:
684         (WebCore::toSelectElement):
685         * dom/SelectElement.h:
686         * dom/Text.cpp:
687         (WebCore::Text::attach):
688         * dom/XMLDocumentParser.cpp:
689         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
690         * dom/XMLDocumentParser.h:
691         * dom/XMLDocumentParserLibxml2.cpp:
692         (WebCore::XMLDocumentParser::internalSubset):
693         (WebCore::getEntityHandler):
694         * dom/XMLDocumentParserQt.cpp:
695         (WebCore::XMLDocumentParser::parse):
696         (WebCore::XMLDocumentParser::parseDtd):
697         * editing/htmlediting.cpp:
698         (WebCore::canHaveChildrenForEditing):
699         * features.pri:
700         * history/BackForwardList.h:
701         * history/BackForwardListImpl.cpp:
702         * history/BackForwardListImpl.h:
703         * history/PageCache.cpp:
704         (WebCore::PageCache::canCachePageContainingThisFrame):
705         * html/HTMLAnchorElement.h:
706         * inspector/ConsoleMessage.cpp:
707         (WebCore::messageSourceValue):
708         * inspector/front-end/ConsoleView.js:
709         (WebInspector.ConsoleMessage.prototype.toString):
710         * loader/FrameLoader.cpp:
711         (WebCore::isBackForwardLoadType):
712         (WebCore::FrameLoader::transitionToCommitted):
713         (WebCore::FrameLoader::shouldReload):
714         (WebCore::FrameLoader::loadDifferentDocumentItem):
715         (WebCore::FrameLoader::loadItem):
716         * loader/FrameLoaderTypes.h:
717         * loader/HistoryController.cpp:
718         (WebCore::HistoryController::restoreDocumentState):
719         * manual-tests/wml: Removed.
720         * manual-tests/wml/StartTests.wml: Removed.
721         * manual-tests/wml/a-br-element.wml: Removed.
722         * manual-tests/wml/a-element.wml: Removed.
723         * manual-tests/wml/a-img-element.wml: Removed.
724         * manual-tests/wml/access-target.wml: Removed.
725         * manual-tests/wml/anchor-br-element.wml: Removed.
726         * manual-tests/wml/anchor-element.wml: Removed.
727         * manual-tests/wml/anchor-img-element.wml: Removed.
728         * manual-tests/wml/card-newcontext-attr.wml: Removed.
729         * manual-tests/wml/card-onenterbackward.wml: Removed.
730         * manual-tests/wml/card-onenterforward.wml: Removed.
731         * manual-tests/wml/card-ontimer.wml: Removed.
732         * manual-tests/wml/deck-access-control.wml: Removed.
733         * manual-tests/wml/input-format.wml: Removed.
734         * manual-tests/wml/onevent-go.wml: Removed.
735         * manual-tests/wml/onevent-noop.wml: Removed.
736         * manual-tests/wml/onevent-prev.wml: Removed.
737         * manual-tests/wml/onevent-refresh.wml: Removed.
738         * manual-tests/wml/onevent-shadow.wml: Removed.
739         * manual-tests/wml/resources: Removed.
740         * manual-tests/wml/resources/smiley.png: Removed.
741         * manual-tests/wml/select-element.wml: Removed.
742         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
743         * manual-tests/wml/select-onpick-event.wml: Removed.
744         * manual-tests/wml/setvar-element.wml: Removed.
745         * manual-tests/wml/targetdeck.wml: Removed.
746         * manual-tests/wml/task-go-in-anchor.wml: Removed.
747         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
748         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
749         * manual-tests/wml/template-go.wml: Removed.
750         * manual-tests/wml/template-ontimer.wml: Removed.
751         * manual-tests/wml/timer.wml: Removed.
752         * manual-tests/wml/variable-substitution.wml: Removed.
753         * page/Console.cpp:
754         (WebCore::printMessageSourceAndLevelPrefix):
755         * page/Console.h:
756         * page/Frame.cpp:
757         (WebCore::Frame::Frame):
758         * page/Page.cpp:
759         * page/Page.h:
760         * platform/MIMETypeRegistry.cpp:
761         (WebCore::initializeSupportedNonImageMimeTypes):
762         * platform/network/FormDataBuilder.h:
763         * platform/network/mac/ResourceHandleMac.mm:
764         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
765         * platform/wince/MIMETypeRegistryWinCE.cpp:
766         (WebCore::initMIMETypeEntensionMap):
767         * rendering/HitTestResult.cpp:
768         (WebCore::HitTestResult::altDisplayString):
769         (WebCore::HitTestResult::absoluteImageURL):
770         (WebCore::HitTestResult::absoluteLinkURL):
771         (WebCore::HitTestResult::isLiveLink):
772         * rendering/RenderBox.cpp:
773         * rendering/RenderButton.cpp:
774         (WebCore::RenderButton::updateFromElement):
775         * rendering/RenderFieldset.cpp:
776         (WebCore::RenderFieldset::findLegend):
777         * rendering/RenderImage.cpp:
778         (WebCore::RenderImage::updateAltText):
779         * rendering/RenderObject.cpp:
780         (WebCore::RenderObject::isLegend):
781         (WebCore::RenderObject::offsetParent):
782         * wml: Removed.
783         * wml/WMLAElement.cpp: Removed.
784         * wml/WMLAElement.h: Removed.
785         * wml/WMLAccessElement.cpp: Removed.
786         * wml/WMLAccessElement.h: Removed.
787         * wml/WMLAnchorElement.cpp: Removed.
788         * wml/WMLAnchorElement.h: Removed.
789         * wml/WMLAttributeNames.in: Removed.
790         * wml/WMLBRElement.cpp: Removed.
791         * wml/WMLBRElement.h: Removed.
792         * wml/WMLCardElement.cpp: Removed.
793         * wml/WMLCardElement.h: Removed.
794         * wml/WMLDoElement.cpp: Removed.
795         * wml/WMLDoElement.h: Removed.
796         * wml/WMLDocument.cpp: Removed.
797         * wml/WMLDocument.h: Removed.
798         * wml/WMLElement.cpp: Removed.
799         * wml/WMLElement.h: Removed.
800         * wml/WMLErrorHandling.cpp: Removed.
801         * wml/WMLErrorHandling.h: Removed.
802         * wml/WMLEventHandlingElement.cpp: Removed.
803         * wml/WMLEventHandlingElement.h: Removed.
804         * wml/WMLFieldSetElement.cpp: Removed.
805         * wml/WMLFieldSetElement.h: Removed.
806         * wml/WMLFormControlElement.cpp: Removed.
807         * wml/WMLFormControlElement.h: Removed.
808         * wml/WMLGoElement.cpp: Removed.
809         * wml/WMLGoElement.h: Removed.
810         * wml/WMLImageElement.cpp: Removed.
811         * wml/WMLImageElement.h: Removed.
812         * wml/WMLImageLoader.cpp: Removed.
813         * wml/WMLImageLoader.h: Removed.
814         * wml/WMLInputElement.cpp: Removed.
815         * wml/WMLInputElement.h: Removed.
816         * wml/WMLInsertedLegendElement.cpp: Removed.
817         * wml/WMLInsertedLegendElement.h: Removed.
818         * wml/WMLIntrinsicEvent.cpp: Removed.
819         * wml/WMLIntrinsicEvent.h: Removed.
820         * wml/WMLIntrinsicEventHandler.cpp: Removed.
821         * wml/WMLIntrinsicEventHandler.h: Removed.
822         * wml/WMLMetaElement.cpp: Removed.
823         * wml/WMLMetaElement.h: Removed.
824         * wml/WMLNoopElement.cpp: Removed.
825         * wml/WMLNoopElement.h: Removed.
826         * wml/WMLOnEventElement.cpp: Removed.
827         * wml/WMLOnEventElement.h: Removed.
828         * wml/WMLOptGroupElement.cpp: Removed.
829         * wml/WMLOptGroupElement.h: Removed.
830         * wml/WMLOptionElement.cpp: Removed.
831         * wml/WMLOptionElement.h: Removed.
832         * wml/WMLPElement.cpp: Removed.
833         * wml/WMLPElement.h: Removed.
834         * wml/WMLPageState.cpp: Removed.
835         * wml/WMLPageState.h: Removed.
836         * wml/WMLPostfieldElement.cpp: Removed.
837         * wml/WMLPostfieldElement.h: Removed.
838         * wml/WMLPrevElement.cpp: Removed.
839         * wml/WMLPrevElement.h: Removed.
840         * wml/WMLRefreshElement.cpp: Removed.
841         * wml/WMLRefreshElement.h: Removed.
842         * wml/WMLSelectElement.cpp: Removed.
843         * wml/WMLSelectElement.h: Removed.
844         * wml/WMLSetvarElement.cpp: Removed.
845         * wml/WMLSetvarElement.h: Removed.
846         * wml/WMLTableElement.cpp: Removed.
847         * wml/WMLTableElement.h: Removed.
848         * wml/WMLTagNames.in: Removed.
849         * wml/WMLTaskElement.cpp: Removed.
850         * wml/WMLTaskElement.h: Removed.
851         * wml/WMLTemplateElement.cpp: Removed.
852         * wml/WMLTemplateElement.h: Removed.
853         * wml/WMLTimerElement.cpp: Removed.
854         * wml/WMLTimerElement.h: Removed.
855         * wml/WMLVariables.cpp: Removed.
856         * wml/WMLVariables.h: Removed.
857
858 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
859
860         Unreviewed, rolling out r85233 and r85235.
861         http://trac.webkit.org/changeset/85233
862         http://trac.webkit.org/changeset/85235
863         https://bugs.webkit.org/show_bug.cgi?id=59754
864
865         Causes issues with jsc. (Requested by dave_levin on #webkit).
866
867         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
868         * loader/icon/IconDatabase.cpp:
869         (WebCore::IconDatabase::defaultIcon):
870         (WebCore::IconDatabase::setIconDataForIconURL):
871         (WebCore::IconDatabase::getOrCreateIconRecord):
872         (WebCore::IconDatabase::readFromDatabase):
873
874 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
875
876         Reviewed by Adam Barth.
877
878         Introducing a new class that allows serialization of a page back
879         to HTML/XML with all its sub-frames and also retrieves the page's
880         resources.
881         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
882         https://bugs.webkit.org/show_bug.cgi?id=58947
883
884         * Android.mk:
885         * CMakeLists.txt:
886         * GNUmakefile.list.am:
887         * WebCore.gypi:
888         * WebCore.pro:
889         * WebCore.vcproj/WebCore.vcproj:
890         * dom/Document.cpp:
891         (WebCore::Document::suggestedMIMEType):
892         * dom/Document.h:
893         * editing/MarkupAccumulator.cpp:
894         (WebCore::MarkupAccumulator::appendCustomAttributes):
895         (WebCore::MarkupAccumulator::appendElement):
896         * editing/MarkupAccumulator.h:
897         * html/parser/HTMLMetaCharsetParser.cpp:
898         (WebCore::HTMLMetaCharsetParser::processMeta):
899         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
900         * html/parser/HTMLMetaCharsetParser.h:
901         * page/PageSerializer.cpp: Added.
902         * page/PageSerializer.h: Added.
903
904 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
905
906         Reviewed by Tony Chang.
907
908         IndexedDB createIndex should fail if name arg is null
909         https://bugs.webkit.org/show_bug.cgi?id=58365
910
911         Test: storage/indexeddb/mozilla/create-index-null-name.html
912
913         * storage/IDBObjectStore.idl:
914         * storage/IDBObjectStoreBackendImpl.cpp:
915         (WebCore::IDBObjectStoreBackendImpl::createIndex):
916
917 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
918
919         Reviewed by Tony Chang.
920
921         IndexedDB put() should fail if second (key) parameter is null
922         https://bugs.webkit.org/show_bug.cgi?id=58613
923
924         If key arg is not specified, prpKey ends up as a null pointer in ::put().
925         However, if the key arg is specified but is null, prpKey ends up as a
926         valid IDBKey which has a null key type. As it happens, we need to be able
927         to detect the difference between these cases (the key arg is optional but
928         if specified must not be null).
929
930         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
931
932         * storage/IDBObjectStoreBackendImpl.cpp:
933         (WebCore::IDBObjectStoreBackendImpl::put):
934
935 2011-04-07  David Levin  <levin@chromium.org>
936
937         Reviewed by Darin Adler.
938
939         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
940         https://bugs.webkit.org/show_bug.cgi?id=31639
941
942         No new functionality exposed so no new tests. (The change is basically adding
943         more testing.)
944
945         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
946         * loader/icon/IconDatabase.cpp:
947         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
948         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
949         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
950         (WebCore::IconDatabase::readFromDatabase): Ditto.
951
952 2011-04-28  Kenneth Russell  <kbr@google.com>
953
954         Unreviewed build fix for Web Audio with strict OwnPtr.
955
956         * platform/audio/HRTFDatabaseLoader.cpp:
957         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
958
959 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
960
961         Reviewed by Geoffrey Garen.
962
963         Walk shadow hosts as well as parent nodes when finding opaque roots.
964         https://bugs.webkit.org/show_bug.cgi?id=59571
965
966         Test: fast/dom/shadow/gc-shadow.html
967
968         * bindings/js/JSDOMBinding.h:
969         (WebCore::root):
970
971 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
972
973         Reviewed by Xan Lopez.
974
975         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
976         https://bugs.webkit.org/show_bug.cgi?id=59715
977
978         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
979         into WebCore so that WebKit1 and WebKit2 can share the code.
980
981         No new tests. This is covered by fast/events/click-count.html.
982
983         * GNUmakefile.list.am: Added new files.
984         * platform/gtk/GtkClickCounter.cpp: Added.
985         (WebCore::GtkClickCounter::GtkClickCounter): Added.
986         (WebCore::GtkClickCounter::reset): Added.
987         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
988         (WebCore::getEventTime): Added.
989         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
990         * platform/gtk/GtkClickCounter.h: Added.
991
992 2011-04-28  Dan Bernstein  <mitz@apple.com>
993
994         Build fix.
995
996         * css/CSSParser.cpp:
997         (WebCore::cssPropertyID):
998
999 2011-04-28  Dan Bernstein  <mitz@apple.com>
1000
1001         Reviewed by Simon Fraser.
1002
1003         Allow specifying CSS property aliases in CSSPropertyNames.in files
1004         https://bugs.webkit.org/show_bug.cgi?id=59712
1005
1006         * css/CSSParser.cpp:
1007         (WebCore::cssPropertyID): Removed code to handle some aliases
1008         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
1009         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
1010         defining an alias, and add an appropriate entry to the gperf file.
1011
1012 2011-04-28  Arno Renevier  <arno@renevier.net>
1013
1014         Reviewed by Gustavo Noronha Silva.
1015
1016         [Soup] does not load css stylesheets without content-type
1017         https://bugs.webkit.org/show_bug.cgi?id=59697
1018
1019         When sniffing content type, do not replace http Content-Type header in
1020         soup message anymore, but keep sniffed content type in a separate
1021         variable.
1022
1023         * platform/network/soup/ResourceHandleSoup.cpp:
1024         (WebCore::contentSniffedCallback):
1025         * platform/network/soup/ResourceResponse.h:
1026         (WebCore::ResourceResponse::sniffedContentType):
1027         (WebCore::ResourceResponse::setSniffedContentType):
1028         * platform/network/soup/ResourceResponseSoup.cpp:
1029         (WebCore::ResourceResponse::updateFromSoupMessage):
1030
1031 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
1032
1033         Reviewed by Andreas Kling.
1034
1035         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
1036         https://bugs.webkit.org/show_bug.cgi?id=59704
1037
1038         No new tests, just code cleanup.
1039
1040         * WebCore.pri:
1041
1042 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
1043
1044         Reviewed by Pavel Feldman.
1045
1046         Web Inspector: remove "Pretty print" source frame context menu item.
1047         https://bugs.webkit.org/show_bug.cgi?id=59709
1048
1049         * inspector/front-end/DebuggerPresentationModel.js:
1050         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
1051         * inspector/front-end/ScriptsPanel.js:
1052         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1053         * inspector/front-end/SourceFrame.js:
1054         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
1055
1056 2011-04-28  Satish Sampath  <satish@chromium.org>
1057
1058         Reviewed by Tony Gentilcore.
1059
1060         Speech input button layout issues with padding and border.
1061         https://bugs.webkit.org/show_bug.cgi?id=59613
1062
1063         * rendering/RenderTextControlSingleLine.cpp:
1064         (WebCore::RenderTextControlSingleLine::layout):
1065         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1066         (WebCore::RenderTextControlSingleLine::forwardEvent):
1067
1068 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1069
1070         Reviewed by Martin Robinson.
1071
1072         [GTK] Check whether to use native scrollbars at run time
1073         https://bugs.webkit.org/show_bug.cgi?id=59694
1074
1075         It's currently decided at build time depending on whether webkit2
1076         build is enabled or not. That makes imposible to build both
1077         webkit1 and webkit2 using the same libWebCore.
1078
1079         * GNUmakefile.am:
1080         * platform/ScrollView.cpp:
1081         (WebCore::ScrollView::wheelEvent):
1082         * platform/gtk/ScrollViewGtk.cpp:
1083         (WebCore::ScrollView::createScrollbar):
1084
1085 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1086
1087         Reviewed by Yury Semikhatsky.
1088
1089         Web Inspector: add status bar button for pretty print.
1090         https://bugs.webkit.org/show_bug.cgi?id=59467
1091
1092         * WebCore.gypi:
1093         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
1094         * inspector/front-end/ScriptsPanel.js:
1095         (WebInspector.ScriptsPanel):
1096         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
1097         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1098         * inspector/front-end/WebKit.qrc:
1099         * inspector/front-end/inspector.css:
1100         (.scripts-toggle-pretty-print-status-bar-item .glyph):
1101         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
1102
1103 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1104
1105         Reviewed by Yury Semikhatsky.
1106
1107         Web Inspector: add ResourceTreeModel tests.
1108         https://bugs.webkit.org/show_bug.cgi?id=59616
1109
1110         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
1111                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
1112                http/tests/inspector/resource-tree/resource-tree-reload.html
1113
1114         * inspector/front-end/ResourceTreeModel.js:
1115         (WebInspector.ResourceTreeModel.prototype.frontendReused):
1116         (WebInspector.ResourceTreeModel.prototype._addFrame):
1117         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1118         (WebInspector.ResourceTreeModel.prototype._frameDetached):
1119         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
1120         (WebInspector.ResourceTreeModel.prototype.forAllResources):
1121         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
1122         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
1123         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
1124         * inspector/front-end/ResourcesPanel.js:
1125         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1126         (WebInspector.ResourcesPanel.prototype._frameAdded):
1127         (WebInspector.ResourcesPanel.prototype._frameDetached):
1128         (WebInspector.ResourcesPanel.prototype._frameNavigated):
1129         (WebInspector.FrameTreeElement):
1130         (WebInspector.FrameTreeElement.prototype.frameNavigated):
1131
1132 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1133
1134         Reviewed by Yury Semikhatsky.
1135
1136         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
1137         https://bugs.webkit.org/show_bug.cgi?id=59592
1138
1139         * inspector/front-end/DetailedHeapshotGridNodes.js:
1140         (WebInspector.HeapSnapshotGridNode.prototype._populate):
1141         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
1142         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
1143         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
1144         * inspector/front-end/DetailedHeapshotView.js:
1145         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
1146         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
1147         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
1148         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
1149         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
1150         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
1151         (WebInspector.DetailedHeapshotView.prototype.changeView):
1152         * inspector/front-end/HeapSnapshot.js:
1153         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
1154         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
1155         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
1156         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
1157         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
1158         * inspector/front-end/heapProfiler.css:
1159         (div.retaining-paths-view td.path-column div:hover):
1160
1161 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1162
1163         Reviewed by Yury Semikhatsky.
1164
1165         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
1166         https://bugs.webkit.org/show_bug.cgi?id=59454
1167
1168         Test: inspector/profiler/heap-snapshot-loader.html
1169
1170         * inspector/front-end/HeapSnapshot.js:
1171         (WebInspector.HeapSnapshotLoader):
1172         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
1173         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
1174         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
1175         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
1176         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
1177         * inspector/front-end/HeapSnapshotProxy.js:
1178         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
1179
1180 2011-04-28  ojab  <ojab@ojab.ru>
1181
1182         Reviewed by David Levin.
1183
1184         Fix build with libpng-1.5.1
1185         https://bugs.webkit.org/show_bug.cgi?id=59607
1186
1187         * platform/image-decoders/png/PNGImageDecoder.cpp:
1188         (WebCore::readColorProfile):
1189
1190 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
1191
1192         Reviewed by Nikolas Zimmermann.
1193
1194         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
1195         https://bugs.webkit.org/show_bug.cgi?id=59447
1196
1197         This patch contains two sub-routines, one for speeding up
1198         alpha channel only gaussian blur (by 2.5 times) and one
1199         for speeding up all channel blur (by 4 times).
1200
1201         The common code is also redesigned to better fit for platform
1202         specific code. This means large chunks of code was moved to
1203         different files, and all platform specific files are added to
1204         all build systems.
1205
1206         * CMakeLists.txt:
1207         * GNUmakefile.am:
1208         * GNUmakefile.list.am:
1209         * WebCore.gypi:
1210         * WebCore.pro:
1211         * WebCore.vcproj/WebCore.vcproj:
1212         * WebCore.vcproj/WebCoreCommon.vsprops:
1213         * WebCore.xcodeproj/project.pbxproj:
1214         * platform/graphics/filters/FEGaussianBlur.cpp:
1215         (WebCore::FEGaussianBlur::platformApplyGeneric):
1216         (WebCore::FEGaussianBlur::apply):
1217         * platform/graphics/filters/FEGaussianBlur.h:
1218         (WebCore::FEGaussianBlur::kernelPosition):
1219         (WebCore::FEGaussianBlur::platformApply):
1220         * platform/graphics/filters/FELighting.cpp:
1221         (WebCore::FELighting::platformApplyGeneric):
1222         (WebCore::FELighting::drawLighting):
1223         * platform/graphics/filters/FELighting.h:
1224         (WebCore::FELighting::platformApply):
1225         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
1226         (WebCore::WTF_ALIGNED):
1227         (WebCore::feGaussianBlurConstantsForNeon):
1228         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
1229         (WebCore::FEGaussianBlur::platformApplyNeon):
1230         * platform/graphics/filters/arm/FELightingNEON.cpp:
1231         (WebCore::WTF_ALIGNED):
1232         (WebCore::FELighting::getPowerCoefficients):
1233         * platform/graphics/filters/arm/FELightingNEON.h:
1234         (WebCore::FELighting::platformApplyNeon):
1235
1236 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
1237
1238         Reviewed by Yury Semikhatsky.
1239
1240         Web Inspector: provide a hotkey for script pause
1241         https://bugs.webkit.org/show_bug.cgi?id=59593
1242
1243         In fact, F8 works as a hotkey, but this fact was not reflected
1244         in the shortcut help popup.
1245
1246         * English.lproj/localizedStrings.js:
1247         * inspector/front-end/ScriptsPanel.js:
1248         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
1249
1250 2011-04-28  Adam Barth  <abarth@webkit.org>
1251
1252         Reviewed by Eric Seidel.
1253
1254         PluginStream should play nice with strict OwnPtr
1255         https://bugs.webkit.org/show_bug.cgi?id=59675
1256
1257         These failures appear when enabling strict OwnPtr on Qt.
1258
1259         * plugins/PluginStream.cpp:
1260         (WebCore::PluginStream::PluginStream):
1261         (WebCore::PluginStream::didReceiveData):
1262
1263 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
1264
1265         Reviewed by Pavel Feldman.
1266
1267         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
1268         https://bugs.webkit.org/show_bug.cgi?id=59326
1269
1270         Concrete CachedResource successors for stylesheets and scripts
1271         can decode their content better than the generic approach we use.
1272
1273         * inspector/InspectorPageAgent.cpp:
1274         (WebCore::decodeSharedBuffer):
1275         (WebCore::prepareCachedResourceBuffer):
1276         (WebCore::cachedResourceDecoded):
1277         (WebCore::InspectorPageAgent::resourceContent):
1278         (WebCore::InspectorPageAgent::resourceData):
1279         * inspector/InspectorStyleSheet.cpp:
1280         (WebCore::InspectorStyleSheet::originalStyleSheetText):
1281
1282 2011-04-28  Jon Lee  <jonlee@apple.com>
1283
1284         Reviewed by Simon Fraser.
1285
1286         REGRESSION: white overlay scrollbars on apple.com/startpage
1287         https://bugs.webkit.org/show_bug.cgi?id=59540
1288         <rdar://problem/9338653>
1289
1290         Now we look at the document background in addition to the <body> element,
1291         and blend those colors in with the base background of the frame view to
1292         arrive at our aggregate color. This provides a better result to determine
1293         overlay scrollbar style.
1294
1295         * page/Frame.cpp:
1296         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
1297         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
1298
1299 2011-04-27  Adam Barth  <abarth@webkit.org>
1300
1301         Reviewed by Maciej Stachowiak.
1302
1303         Fix OwnPtr issues in IndexedDB
1304         https://bugs.webkit.org/show_bug.cgi?id=59656
1305
1306         This patch is an attempt to fix the clang build.  Clang can't seem to
1307         cope with OwnPtrs to classes declared in an anonymous namespace because
1308         OwnPtr's copy constructor isn't defined (but would need to be defined
1309         in this translation unit).
1310
1311         * platform/leveldb/LevelDBDatabase.cpp:
1312
1313 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
1314
1315         Reviewed by Antonio Gomes.
1316
1317         [EFL] Change cursor to LAZY_NATIVE_CURSOR
1318         https://bugs.webkit.org/show_bug.cgi?id=59411
1319
1320         Enable LAZY_NATIVE_CURSOR on EFL build.
1321
1322         No test added because functionality is unchanged.
1323
1324         * CMakeListsEfl.txt: Add Cursor.cpp
1325         * platform/Cursor.h:
1326         (WebCore::Cursor::Cursor):
1327         * platform/efl/CursorEfl.cpp:
1328         (WebCore::Cursor::Cursor):
1329         (WebCore::Cursor::~Cursor):
1330         (WebCore::getCursorString):
1331         (WebCore::Cursor::ensurePlatformCursor):
1332         * platform/efl/WidgetEfl.cpp:
1333         (WebCore::Widget::setCursor):
1334
1335 2011-04-27  Adam Barth  <abarth@webkit.org>
1336
1337         Build fix from the future.  Another trival strict OwnPtr fixes.  This
1338         is the last futuristic build fix I can detect with my time traveling
1339         abilities.
1340
1341         * platform/graphics/chromium/TransparencyWin.cpp:
1342         (WebCore::TransparencyWin::initializeNewContext):
1343
1344 2011-04-27  Dmitry Lomov  <dslomov@google.com>
1345
1346         Reviewed by David Levin.
1347
1348         CrossThreadCopier should not have a default specialization for raw pointers
1349         https://bugs.webkit.org/show_bug.cgi?id=59234
1350         Removed the ablity to pass raw pointers cross-thread
1351         Added and applied annotations for doing that
1352
1353         * fileapi/FileReader.cpp:
1354         (WebCore::FileReader::readInternal):
1355         (WebCore::FileReader::abort):
1356         * fileapi/FileStreamProxy.cpp:
1357         (WebCore::FileStreamProxy::startOnFileThread):
1358         (WebCore::FileStreamProxy::stopOnFileThread):
1359         (WebCore::FileStreamProxy::getSize):
1360         (WebCore::FileStreamProxy::getSizeOnFileThread):
1361         (WebCore::FileStreamProxy::openForRead):
1362         (WebCore::FileStreamProxy::openForReadOnFileThread):
1363         (WebCore::FileStreamProxy::openForWrite):
1364         (WebCore::FileStreamProxy::openForWriteOnFileThread):
1365         (WebCore::FileStreamProxy::close):
1366         (WebCore::FileStreamProxy::read):
1367         (WebCore::FileStreamProxy::readOnFileThread):
1368         (WebCore::FileStreamProxy::write):
1369         (WebCore::FileStreamProxy::writeOnFileThread):
1370         (WebCore::FileStreamProxy::truncate):
1371         (WebCore::FileStreamProxy::truncateOnFileThread):
1372         * loader/WorkerThreadableLoader.cpp:
1373         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
1374         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
1375         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
1376         * page/GeolocationPositionCache.cpp:
1377         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
1378         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
1379         * platform/CrossThreadCopier.h:
1380         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
1381         (WebCore::AllowCrossThreadAccessWrapper::value):
1382         (WebCore::AllowCrossThreadAccess):
1383         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
1384         (WebCore::AllowExtendedLifetimeWrapper::value):
1385         (WebCore::AllowExtendedLifetime):
1386         * platform/graphics/chromium/cc/CCCompletionEvent.h:
1387         * storage/IDBObjectStoreBackendImpl.cpp:
1388         (WebCore::IDBObjectStoreBackendImpl::get):
1389         (WebCore::IDBObjectStoreBackendImpl::put):
1390         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1391         (WebCore::IDBObjectStoreBackendImpl::clear):
1392         (WebCore::IDBObjectStoreBackendImpl::createIndex):
1393         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
1394         (WebCore::IDBObjectStoreBackendImpl::openCursor):
1395         * storage/SQLCallbackWrapper.h:
1396         (WebCore::SQLCallbackWrapper::clear):
1397         * websockets/WorkerThreadableWebSocketChannel.cpp:
1398         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
1399         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
1400         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
1401         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
1402         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
1403         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
1404         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
1405         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
1406         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
1407         * workers/WorkerMessagingProxy.cpp:
1408         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
1409
1410 2011-04-27  Adam Barth  <abarth@webkit.org>
1411
1412         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
1413
1414         * page/Frame.cpp:
1415         (WebCore::Frame::setTiledBackingStoreEnabled):
1416         * platform/audio/ReverbConvolver.cpp:
1417         (WebCore::ReverbConvolver::ReverbConvolver):
1418
1419 2011-04-27  Adam Barth  <abarth@webkit.org>
1420
1421         Reviewed by David Levin.
1422
1423         Fix five strict PassOwnPtr violations in WebCore
1424         https://bugs.webkit.org/show_bug.cgi?id=59640
1425
1426         * css/MediaList.cpp:
1427         (WebCore::MediaList::deleteMedium):
1428         (WebCore::MediaList::setMediaText):
1429         (WebCore::MediaList::appendMedium):
1430         * css/MediaQuery.h:
1431         * dom/MessagePort.cpp:
1432         (WebCore::MessagePort::disentanglePorts):
1433         (WebCore::MessagePort::entanglePorts):
1434         * inspector/InspectorStyleSheet.cpp:
1435         (ParsedStyleSheet::setText):
1436         * rendering/RenderTheme.cpp:
1437         (WebCore::RenderTheme::adjustStyle):
1438         (WebCore::RenderTheme::adjustMeterStyle):
1439         * rendering/RenderThemeMac.mm:
1440         (WebCore::RenderThemeMac::adjustMenuListStyle):
1441         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
1442         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
1443         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
1444         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
1445         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
1446         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
1447         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
1448
1449 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
1450
1451         Reviewed by Beth Dakin.
1452
1453         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
1454         https://bugs.webkit.org/show_bug.cgi?id=59648
1455
1456         Test: accessibility/aria-fallback-roles.html
1457
1458         * accessibility/AccessibilityObject.cpp:
1459         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
1460
1461 2011-04-27  Beth Dakin  <bdakin@apple.com>
1462
1463         Reviewed by Dan Bernstein.
1464
1465         https://bugs.webkit.org/show_bug.cgi?id=59671
1466         Race condition with scrollbar animations and closing a page can cause a crash in 
1467         WebCore::FrameView::setVisibleScrollerThumbRect + 15
1468         -and corresponding-
1469         <rdar://problem/9329253>
1470
1471         It is definitely possible for Page to be null here. So we should null-check it! 
1472         And we should not ASSERT.
1473         * page/FrameView.cpp:
1474         (WebCore::FrameView::didCompleteRubberBand):
1475         (WebCore::FrameView::scrollbarStyleChanged):
1476         (WebCore::FrameView::setVisibleScrollerThumbRect):
1477
1478 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1479
1480         WinCE build fix after r85143.
1481
1482         * platform/graphics/wince/FontWinCE.cpp:
1483         (WebCore::TextRunComponent::TextRunComponent):
1484
1485 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
1486
1487         Reviewed by Tony Chang.
1488
1489         IndexedDB object store delete should fail if key is null
1490         https://bugs.webkit.org/show_bug.cgi?id=58614
1491
1492         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
1493
1494         * storage/IDBObjectStoreBackendImpl.cpp:
1495         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1496
1497 2011-04-27  Eric Seidel  <eric@webkit.org>
1498
1499         Reviewed by Ryosuke Niwa.
1500
1501         Should have an easy way to construct starting BidiStatus for a paragraph root
1502         https://bugs.webkit.org/show_bug.cgi?id=59226
1503
1504         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
1505         I've made this a constructor for BidiStatus instead.
1506
1507         As part of this effort I added a direction() accessor for TextRun and got
1508         rid of the old m_rtl bool.  This is part of the generic effort in the
1509         Bidi code to replace old bool usage with the superior TextDirection enum
1510         (this generally makes the code cleaner).
1511
1512         As part of this replacement effort I found several places which were
1513         assuming LTR (by passing rtl=false) when they probably want to use
1514         the current text direction.  I suspect that LTR vs. RTL may affect
1515         string width in the case of ligatures.  It's unclear.
1516
1517         This is almost entirely a mechanical change.
1518
1519         * html/canvas/CanvasRenderingContext2D.cpp:
1520         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1521         * platform/graphics/GraphicsContext.cpp:
1522         (WebCore::GraphicsContext::drawBidiText):
1523         * platform/graphics/TextRun.h:
1524         (WebCore::TextRun::TextRun):
1525         (WebCore::TextRun::direction):
1526         (WebCore::TextRun::rtl):
1527         (WebCore::TextRun::ltr):
1528         (WebCore::TextRun::setDirection):
1529         * platform/text/BidiResolver.h:
1530         (WebCore::BidiStatus::BidiStatus):
1531         * rendering/EllipsisBox.cpp:
1532         (WebCore::EllipsisBox::paint):
1533         (WebCore::EllipsisBox::selectionRect):
1534         (WebCore::EllipsisBox::paintSelection):
1535         * rendering/InlineTextBox.cpp:
1536         (WebCore::InlineTextBox::selectionRect):
1537         (WebCore::InlineTextBox::paint):
1538         (WebCore::InlineTextBox::paintSelection):
1539         (WebCore::InlineTextBox::paintCompositionBackground):
1540         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1541         (WebCore::InlineTextBox::paintTextMatchMarker):
1542         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1543         (WebCore::InlineTextBox::offsetForPosition):
1544         (WebCore::InlineTextBox::positionForOffset):
1545         * rendering/RenderBlockLineLayout.cpp:
1546         (WebCore::RenderBlock::determineStartPosition):
1547         * rendering/RenderFileUploadControl.cpp:
1548         (WebCore::RenderFileUploadControl::paintObject):
1549         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1550         * rendering/RenderListBox.cpp:
1551         (WebCore::RenderListBox::updateFromElement):
1552         (WebCore::RenderListBox::paintItemForeground):
1553         * rendering/RenderTextControl.cpp:
1554         (WebCore::RenderTextControl::getAvgCharWidth):
1555         (WebCore::RenderTextControl::paintPlaceholder):
1556         * rendering/svg/SVGInlineTextBox.cpp:
1557         (WebCore::SVGInlineTextBox::constructTextRun):
1558         * rendering/svg/SVGTextMetrics.cpp:
1559         (WebCore::constructTextRun):
1560
1561 2011-04-27  Robert Hogan  <robert@webkit.org>
1562
1563         Reviewed by Adam Barth.
1564
1565         Allow shadowing of history object
1566         https://bugs.webkit.org/show_bug.cgi?id=55965
1567
1568         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1569                http/tests/history/cross-origin-replace-history-object.html
1570
1571         * page/DOMWindow.idl:
1572
1573 2011-04-27  James Robinson  <jamesr@chromium.org>
1574
1575         Reviewed by Kenneth Russell.
1576
1577         [chromium] Ensure compositing layers are up to date before entering doComposite
1578         https://bugs.webkit.org/show_bug.cgi?id=59159
1579
1580         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1581         GraphicsLayerClient::paintContents() implementations).
1582
1583         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1584         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1585         * platform/graphics/chromium/LayerChromium.cpp:
1586         (WebCore::LayerChromium::LayerChromium):
1587         (WebCore::LayerChromium::~LayerChromium):
1588         * platform/graphics/chromium/LayerRendererChromium.cpp:
1589         (WebCore::LayerRendererChromium::updateLayers):
1590         * platform/graphics/chromium/LayerRendererChromium.h:
1591           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1592
1593 2011-04-27  James Robinson  <jamesr@chromium.org>
1594
1595         Reviewed by Adam Barth.
1596
1597         Fix OwnPtr strict issues in chromium linux build
1598         https://bugs.webkit.org/show_bug.cgi?id=59664
1599
1600         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1601         (WebCore::ComplexTextController::getNormalizedTextRun):
1602         * platform/graphics/skia/ImageBufferSkia.cpp:
1603         (WebCore::ImageBuffer::ImageBuffer):
1604         * platform/graphics/skia/PlatformContextSkia.cpp:
1605         (WebCore::PlatformContextSkia::PlatformContextSkia):
1606
1607 2011-04-27  Chris Rogers  <crogers@google.com>
1608
1609         Reviewed by Kenneth Russell.
1610
1611         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1612         https://bugs.webkit.org/show_bug.cgi?id=59641
1613
1614         No new tests since audio API is not yet implemented.
1615
1616         * platform/audio/AudioBus.cpp:
1617         (WebCore::AudioBus::createBySampleRateConverting):
1618         (WebCore::AudioBus::createByMixingToMono):
1619
1620 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1621
1622         Motivated by Alexey Proskuryakov.
1623
1624         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1625         informative, since it confused Alexey and me.
1626
1627 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1628
1629         Reviewed by Sam Weinig.
1630
1631         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1632         https://bugs.webkit.org/show_bug.cgi?id=59646
1633
1634         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1635         a world, we need to clear all entries in the map for that world, since
1636         the finalizers that would otherwise clear those entries don't run. The
1637         simplest way to do this is just to make the world own the map.
1638         
1639         * bindings/js/DOMWrapperWorld.h:
1640         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1641         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1642         * bindings/js/JSCSSValueCustom.cpp:
1643         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1644         (WebCore::JSCSSValueOwner::finalize):
1645         * bindings/js/JSDOMBinding.h:
1646
1647 2011-04-27  Adam Barth  <abarth@webkit.org>
1648
1649         Reviewed by David Levin.
1650
1651         Fix OwnPtr issues in IndexedDB
1652         https://bugs.webkit.org/show_bug.cgi?id=59656
1653
1654         I didn't do an exhaustive review of this code, but I fixed the problems
1655         caught by turning on strict OwnPtr and all their antecedents.  This
1656         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1657         behavior change.
1658
1659         * platform/leveldb/LevelDBDatabase.cpp:
1660         (WebCore::LevelDBDatabase::LevelDBDatabase):
1661         (WebCore::LevelDBDatabase::open):
1662         (WebCore::LevelDBDatabase::createIterator):
1663         * platform/leveldb/LevelDBDatabase.h:
1664         * platform/leveldb/LevelDBIterator.cpp:
1665         (WebCore::LevelDBIterator::LevelDBIterator):
1666         * platform/leveldb/LevelDBIterator.h:
1667         * storage/IDBLevelDBBackingStore.cpp:
1668         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1669         (WebCore::IDBLevelDBBackingStore::open):
1670         (WebCore::getNewDatabaseId):
1671         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1672         (WebCore::getNewObjectStoreId):
1673         (WebCore::deleteRange):
1674         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1675         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1676         (WebCore::IDBLevelDBBackingStore::getIndexes):
1677         (WebCore::getNewIndexId):
1678         (WebCore::findGreatestKeyLessThan):
1679         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1680         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1681         (WebCore::findLastIndexKeyEqualTo):
1682         * storage/IDBLevelDBBackingStore.h:
1683
1684 2011-04-19  MORITA Hajime  <morrita@google.com>
1685
1686         Reviewed by Tony Chang.
1687
1688         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1689         https://bugs.webkit.org/show_bug.cgi?id=58113
1690
1691         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1692         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1693         * Now MarkerMapVectorPair is no longer used.
1694         
1695         No new tests, No behavior change.
1696
1697         * GNUmakefile.list.am:
1698         * WebCore.gypi:
1699         * WebCore.pro:
1700         * WebCore.vcproj/WebCore.vcproj:
1701         * WebCore.xcodeproj/project.pbxproj:
1702         * dom/DocumentMarker.h:
1703         * dom/DocumentMarkerController.cpp:
1704         (WebCore::DocumentMarkerController::addMarker):
1705         (WebCore::DocumentMarkerController::copyMarkers):
1706         (WebCore::DocumentMarkerController::removeMarkers):
1707         (WebCore::DocumentMarkerController::markerContainingPoint):
1708         (WebCore::DocumentMarkerController::markersForNode):
1709         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1710         (WebCore::DocumentMarkerController::removeMarkersFromList):
1711         (WebCore::DocumentMarkerController::repaintMarkers):
1712         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1713         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1714         (WebCore::DocumentMarkerController::shiftMarkers):
1715         (WebCore::DocumentMarkerController::setMarkersActive):
1716         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1717         (WebCore::DocumentMarkerController::showMarkers):
1718         * dom/DocumentMarkerController.h:
1719         * dom/RenderedDocumentMarker.h: Added.
1720         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1721         (WebCore::RenderedDocumentMarker::isRendered):
1722         (WebCore::RenderedDocumentMarker::contains):
1723         (WebCore::RenderedDocumentMarker::setRenderedRect):
1724         (WebCore::RenderedDocumentMarker::renderedRect):
1725         (WebCore::RenderedDocumentMarker::invalidate):
1726         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1727
1728 2011-04-27  James Robinson  <jamesr@chromium.org>
1729
1730         Unreviewed, rolling out r85112.
1731         http://trac.webkit.org/changeset/85112
1732         https://bugs.webkit.org/show_bug.cgi?id=59159
1733
1734         Broke mac compile
1735
1736         * page/FrameView.cpp:
1737         (WebCore::FrameView::updateCompositingLayers):
1738         * page/FrameView.h:
1739         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1740         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1741         * platform/graphics/chromium/LayerChromium.cpp:
1742         (WebCore::LayerChromium::LayerChromium):
1743         (WebCore::LayerChromium::~LayerChromium):
1744         * platform/graphics/chromium/LayerRendererChromium.cpp:
1745         (WebCore::LayerRendererChromium::updateLayers):
1746         * platform/graphics/chromium/LayerRendererChromium.h:
1747
1748 2011-04-27  Mark Rowe  <mrowe@apple.com>
1749
1750         Build fix.
1751
1752         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1753
1754 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1755
1756         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1757
1758         * platform/network/ResourceHandleClient.h:
1759
1760 2011-04-27  James Robinson  <jamesr@chromium.org>
1761
1762         Reviewed by Kenneth Russell.
1763
1764         [chromium] Ensure compositing layers are up to date before entering doComposite
1765         https://bugs.webkit.org/show_bug.cgi?id=59159
1766
1767         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1768         GraphicsLayerClient::paintContents() implementations).
1769
1770         * page/FrameView.cpp:
1771         (WebCore::FrameView::updateCompositingLayers):
1772             Add an optional CompositingUpdateType parameter.
1773         * page/FrameView.h:
1774         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1775         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1776         * platform/graphics/chromium/LayerChromium.cpp:
1777         (WebCore::LayerChromium::LayerChromium):
1778         (WebCore::LayerChromium::~LayerChromium):
1779         * platform/graphics/chromium/LayerRendererChromium.cpp:
1780         (WebCore::LayerRendererChromium::updateLayers):
1781         * platform/graphics/chromium/LayerRendererChromium.h:
1782           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1783         * rendering/RenderLayer.cpp:
1784         (WebCore::RenderLayer::dirtyZOrderLists):
1785         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1786         * rendering/RenderLayerCompositor.cpp:
1787         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1788         * rendering/RenderLayerCompositor.h:
1789           Fix a typo in CompositingUpdateType Pait->Paint
1790
1791 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1792
1793         Reviewed by Antti Koivisto.
1794
1795         Part of WebCore should use CFNetwork-based loader on Mac
1796         https://bugs.webkit.org/show_bug.cgi?id=51836
1797
1798         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1799         willCacheResponse/shouldCacheResponse.
1800
1801         * loader/EmptyClients.h:
1802         * loader/FrameLoaderClient.h:
1803         * loader/ResourceLoader.h:
1804         * loader/cf/ResourceLoaderCFNet.cpp:
1805         * loader/mac/ResourceLoaderMac.mm:
1806         (WebCore::ResourceLoader::willCacheResponse):
1807         * platform/network/ResourceHandleClient.h:
1808         (WebCore::ResourceHandleClient::willCacheResponse):
1809         (WebCore::ResourceHandleClient::shouldCacheResponse):
1810         * platform/network/cf/ResourceHandleCFNet.cpp:
1811         (WebCore::willCacheResponse):
1812
1813 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
1814
1815         Reviewed by Brian Weinstein.
1816
1817         Web Inspector: Stop on Exception state does not persist.
1818
1819         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
1820         https://bugs.webkit.org/show_bug.cgi?id=59630
1821
1822         * inspector/front-end/ScriptsPanel.js:
1823         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1824         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1825         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1826
1827 2011-04-27  Adrienne Walker  <enne@google.com>
1828
1829         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
1830         https://bugs.webkit.org/show_bug.cgi?id=59020
1831
1832         * platform/graphics/chromium/LayerRendererChromium.cpp:
1833         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1834
1835 2011-04-27  Darin Adler  <darin@apple.com>
1836
1837         Reviewed by David Levin.
1838
1839         Fix strict OwnPtr issues seen in about 30 more files
1840         https://bugs.webkit.org/show_bug.cgi?id=59615
1841
1842         * bindings/js/JSCallbackData.h:
1843         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
1844         * bindings/js/JSMessageEventCustom.cpp:
1845         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
1846         * css/CSSParser.cpp:
1847         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
1848         adoptPtr, and release.
1849         * dom/MessageEvent.cpp:
1850         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
1851         and release.
1852         * dom/MessagePortChannel.cpp:
1853         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
1854         * dom/ScriptExecutionContext.cpp:
1855         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
1856         * dom/XMLDocumentParserLibxml2.cpp:
1857         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
1858         * dom/default/PlatformMessagePortChannel.cpp:
1859         (WebCore::MessagePortChannel::create): Use adoptPtr.
1860         * html/HTMLFormControlElement.cpp:
1861         (WebCore::HTMLFormControlElement::detach): Use nullptr.
1862         * inspector/InspectorAgent.cpp:
1863         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
1864         * inspector/InspectorConsoleAgent.cpp:
1865         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
1866         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
1867         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
1868         * inspector/InspectorController.cpp:
1869         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
1870         * inspector/InspectorDOMAgent.cpp:
1871         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
1872         * inspector/InspectorResourceAgent.cpp:
1873         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1874         * page/FrameActionScheduler.cpp:
1875         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1876         * platform/graphics/ShadowBlur.cpp:
1877         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1878         * platform/graphics/ca/GraphicsLayerCA.cpp:
1879         (WebCore::GraphicsLayer::create): Use adoptPtr.
1880         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1881         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1882         * rendering/RenderBlock.cpp:
1883         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1884         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1885         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
1886         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
1887         * rendering/RenderLayerBacking.cpp:
1888         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
1889         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
1890         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
1891         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
1892         * rendering/RenderLayerCompositor.cpp:
1893         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
1894         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
1895         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
1896         * rendering/style/StyleRareNonInheritedData.cpp:
1897         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
1898         explicit initializations of OwnPtr members to 0. Use adoptPtr.
1899         * workers/SharedWorkerContext.cpp:
1900         (WebCore::createConnectEvent): Use adoptPtr.
1901         * workers/Worker.cpp:
1902         (WebCore::Worker::notifyFinished): Use nullptr.
1903
1904 2011-04-27  Enrica Casucci  <enrica@apple.com>
1905
1906         Reviewed by Darin Adler.
1907
1908         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
1909         https://bugs.webkit.org/show_bug.cgi?id=59251
1910         <rdar://problem/9327044>
1911
1912         When we are looking for wrapping elements that are presentational, we should
1913         include elements that have a non transparent background color only if they
1914         are not blocks.
1915
1916         Test: editing/pasteboard/do-not-copy-body-color.html
1917
1918         * editing/markup.cpp:
1919         (WebCore::isElementPresentational):
1920
1921 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
1922
1923         Reviewed by Antti Koivisto.
1924
1925         Teach sub-selector chains about shadow descendants
1926         https://bugs.webkit.org/show_bug.cgi?id=58342
1927
1928         The primary change is to the logic of parsing specifiers:
1929         1) The shadow descendant selectors (those specifiers that are unknown
1930         pseudo element selectors) are always kept at the top of the chain.
1931         2) The sub-selectors after shadow descendant selectors are stashed right
1932         behind the sub-selector, but not at the end of the chain.
1933         3) Other sub-selectors are appended at the end of the chain.
1934
1935         * css/CSSGrammar.y: Changed specifier_list collection to use new
1936             CSSParser::updateSpecifier helper.
1937         * css/CSSParser.cpp:
1938         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
1939             look for the last ShadowDescendant relation in the chain of selectors,
1940             because the next selector after it is the one that should get the
1941             element name.
1942         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
1943             CSSGrammar.y. The new logic adjusts the selector chain to allow
1944             shadow descendant selectors have sub-selectors (and have multiple shadow
1945             descendants in the chain).
1946         * css/CSSParser.h: Added decl.
1947         * css/CSSParserValues.cpp:
1948         (WebCore::CSSParserSelector::insertTagHistory): Added.
1949         (WebCore::CSSParserSelector::appendTagHistory): Aded.
1950         * css/CSSParserValues.h: Added decls.
1951         * css/CSSStyleSelector.cpp:
1952         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
1953             shadow descendant selector match check, since now there could be many
1954             of them in the selector chain.
1955
1956 2011-04-20  Adrienne Walker  <enne@google.com>
1957
1958         Reviewed by Kenneth Russell.
1959
1960         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
1961         https://bugs.webkit.org/show_bug.cgi?id=59020
1962
1963         mapRect is the incorrect transform here.  The parent scissor rect
1964         needs to be projected into layer space instead.
1965
1966         Test: compositing/flat-with-transformed-child.html
1967
1968         * platform/graphics/chromium/LayerRendererChromium.cpp:
1969         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1970
1971 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1972
1973         Reviewed by Antti Koivisto.
1974
1975         Part of WebCore should use CFNetwork-based loader on Mac
1976         https://bugs.webkit.org/show_bug.cgi?id=51836
1977
1978         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
1979         * platform/mac/SoftLinking.h:
1980         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
1981
1982 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
1983
1984         Reviewed by Antti Koivisto.
1985
1986         Cleanup CSSStyleApplyProperty.cpp
1987         https://bugs.webkit.org/show_bug.cgi?id=59623
1988
1989         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
1990         Use typedefs instead of repating the function pointer declarations in a few places.
1991
1992         * css/CSSStyleApplyProperty.cpp:
1993         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
1994         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
1995         (WebCore::ApplyPropertyColor::applyInheritValue):
1996         (WebCore::ApplyPropertyColor::applyInitialValue):
1997         (WebCore::ApplyPropertyColor::applyValue):
1998         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
1999
2000 2011-04-27  Dan Bernstein  <mitz@apple.com>
2001
2002         Reviewed by Anders Carlsson.
2003
2004         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
2005         https://bugs.webkit.org/show_bug.cgi?id=59622
2006
2007         Test: fast/borders/border-image-trumps-radius.html
2008
2009         * rendering/RenderBox.cpp:
2010         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
2011         image, then border radius is ignored, so no bleed avoidance is needed.
2012         * rendering/RenderObject.cpp:
2013         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
2014         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
2015         * rendering/RenderObject.h:
2016
2017 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2018
2019         Reviewed by Xan Lopez.
2020
2021         [GTK] editing/pasteboard/copy-standalone-image.html fails
2022         https://bugs.webkit.org/show_bug.cgi?id=53645
2023
2024         When writing an image to the clipboard, also write the URL and title
2025         into the markup and URL portion. This change also abstracts a helper
2026         imageToMarkup into markup.{cpp/h} from several different locations
2027         throughout the platform layer.
2028
2029         * editing/markup.h: Added new function definition.
2030         * editing/markup.cpp:
2031         (WebCore::imageToMarkup): Add this function which turns an image URL 
2032         and element into some markup representing that image, while preserving
2033         non-src attributes.
2034         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
2035         to markup.cpp.
2036         * platform/gtk/PasteboardGtk.cpp:
2037         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
2038         image URL for a variety of image tag types.
2039         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
2040         markup and URL portions of the clipboard. This will ensure that images
2041         paste properly back into WebKit.
2042         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
2043         one from markup.h
2044
2045 2011-04-27  Steve Block  <steveblock@google.com>
2046
2047         Reviewed by David Levin.
2048
2049         Remove Android build system
2050         https://bugs.webkit.org/show_bug.cgi?id=48111
2051
2052         This is to avoid the maintenance burden until the Android port is
2053         fully upstreamed.
2054
2055         No new tests, build change only.
2056
2057         * Android.derived.jscbindings.mk: Removed.
2058         * Android.derived.mk: Removed.
2059         * Android.derived.v8bindings.mk: Removed.
2060         * Android.jscbindings.mk: Removed.
2061         * Android.mk: Removed.
2062         * Android.v8bindings.mk: Removed.
2063
2064 2011-04-27  Darin Adler  <darin@apple.com>
2065
2066         Reviewed by Sam Weinig.
2067
2068         Somehow about:blank gets into the icon database
2069         https://bugs.webkit.org/show_bug.cgi?id=58067
2070         rdar://problem/6751446
2071
2072         Implemented the policy Brady suggested, where only http and https URLs can
2073         be associated with and icon, guarding both on the way in to the database,
2074         and on the way out.
2075
2076         * loader/icon/IconDatabase.cpp:
2077         (WebCore::pageCanHaveIcon): Added.
2078         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
2079         instead of just checking for an empty URL.
2080         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
2081         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
2082         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
2083         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
2084         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
2085         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
2086         two separate assertions and added a third.
2087         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
2088
2089         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
2090         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
2091         overloaded it to work on both UChar and char, and added an assertion to it.
2092         Also moved this to the top of the file and made the UChar version usable
2093         in the shared code used even by Google.
2094         (WebCore::KURL::invalidate): Updated for name change.
2095         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
2096         toASCIILower since it's faster.
2097         (WebCore::KURL::parse): Updated for name changes.
2098         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
2099         since it's faster.
2100         (WebCore::protocolIsInHTTPFamily): Added.
2101
2102         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
2103         to protocolIsInHTTPFamily and added a version that works on a string.
2104         Kept the old name as an inline function so we don't have to rename
2105         all the cal sites now.
2106
2107         * platform/KURLGoogle.cpp: Renamed as above.
2108         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
2109         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
2110         (WebCore::KURLGooglePrivate::setAscii): Ditto.
2111         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
2112         (WebCore::KURLGooglePrivate::copyTo): Ditto.
2113         (WebCore::KURL::KURL): Ditto.
2114         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
2115         (WebCore::KURL::invalidate): Ditto.
2116         * platform/KURLGooglePrivate.h: Ditto.
2117
2118         * WebCore.exp.in: Updated for above changes.
2119
2120 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2121
2122         Reviewed by Pavel Feldman.
2123
2124         Web Inspector: browser crash on evaluation of 'throw undefined'
2125         https://bugs.webkit.org/show_bug.cgi?id=59611
2126
2127         Test: inspector/console/console-eval-throw-undefined.html
2128
2129         * inspector/InjectedScriptSource.js: use try/catch to protect from
2130         exception during conversion of another exception to string.
2131
2132 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2133
2134         Reviewed by Yury Semikhatsky.
2135
2136         Web Inspector: clicking bookmarklet multiplies resources panel entries.
2137         https://bugs.webkit.org/show_bug.cgi?id=59590
2138
2139         * inspector/front-end/ResourceTreeModel.js:
2140         (WebInspector.ResourceTreeModel):
2141         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2142         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2143         * inspector/front-end/ResourcesPanel.js:
2144         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
2145         (WebInspector.FrameTreeElement):
2146         (WebInspector.FrameTreeElement.prototype.appendResource):
2147         * inspector/front-end/inspector.js:
2148         (WebInspector.frontendReused):
2149
2150 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2151
2152         Reviewed by Yury Semikhatsky.
2153
2154         Web Inspector: opening bookmarklet disconnects DOM agent.
2155         https://bugs.webkit.org/show_bug.cgi?id=59588
2156
2157         * inspector/InspectorDOMAgent.cpp:
2158         (WebCore::InspectorDOMAgent::setDocument):
2159
2160 2011-04-27  Hans Wennborg  <hans@chromium.org>
2161
2162         Reviewed by Tony Gentilcore.
2163
2164         IndexedDB: Fix compiler warnings about uninitialized variables
2165         https://bugs.webkit.org/show_bug.cgi?id=59599
2166
2167         Build fix. No new tests.
2168
2169         * storage/IDBLevelDBBackingStore.cpp:
2170         (WebCore::getNewObjectStoreId):
2171         (WebCore::getNewIndexId):
2172
2173 2011-04-26  Hans Wennborg  <hans@chromium.org>
2174
2175         Reviewed by Tony Gentilcore.
2176
2177         IndexedDB: Move LevelDB key coding routines to separate file
2178         https://bugs.webkit.org/show_bug.cgi?id=59452
2179
2180         Move all routines concerned with encoding, decoding and comparison of
2181         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
2182         IDBLevelDBCoding.cpp.
2183
2184         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
2185         allow for unit testing of the coding routines.
2186
2187         No new functionality, no new tests.
2188
2189         * WebCore.gypi:
2190         * storage/IDBLevelDBBackingStore.cpp:
2191         (WebCore::getInt):
2192         (WebCore::putInt):
2193         (WebCore::getString):
2194         (WebCore::putString):
2195         (WebCore::compareKeys):
2196         (WebCore::compareIndexKeys):
2197         (WebCore::Comparator::compare):
2198         (WebCore::setUpMetadata):
2199         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
2200         (WebCore::getNewDatabaseId):
2201         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
2202         (WebCore::IDBLevelDBBackingStore::getObjectStores):
2203         (WebCore::getNewObjectStoreId):
2204         (WebCore::IDBLevelDBBackingStore::createObjectStore):
2205         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
2206         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
2207         (WebCore::getNewVersionNumber):
2208         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
2209         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
2210         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
2211         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
2212         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
2213         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
2214         (WebCore::IDBLevelDBBackingStore::getIndexes):
2215         (WebCore::getNewIndexId):
2216         (WebCore::IDBLevelDBBackingStore::createIndex):
2217         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
2218         (WebCore::versionExists):
2219         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
2220         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
2221         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
2222         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
2223         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
2224         * storage/IDBLevelDBCoding.cpp: Added.
2225         (WebCore::IDBLevelDBCoding::encodeByte):
2226         (WebCore::IDBLevelDBCoding::maxIDBKey):
2227         (WebCore::IDBLevelDBCoding::minIDBKey):
2228         (WebCore::IDBLevelDBCoding::encodeInt):
2229         (WebCore::IDBLevelDBCoding::decodeInt):
2230         (WebCore::IDBLevelDBCoding::encodeVarInt):
2231         (WebCore::IDBLevelDBCoding::decodeVarInt):
2232         (WebCore::IDBLevelDBCoding::encodeString):
2233         (WebCore::IDBLevelDBCoding::decodeString):
2234         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
2235         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
2236         (WebCore::IDBLevelDBCoding::encodeDouble):
2237         (WebCore::IDBLevelDBCoding::decodeDouble):
2238         (WebCore::IDBLevelDBCoding::encodeIDBKey):
2239         (WebCore::IDBLevelDBCoding::decodeIDBKey):
2240         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
2241         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
2242         (WebCore::IDBLevelDBCoding::compare):
2243         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
2244         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
2245         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
2246         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
2247         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
2248         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
2249         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
2250         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
2251         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
2252         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
2253         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
2254         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
2255         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
2256         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
2257         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
2258         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
2259         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
2260         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
2261         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
2262         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
2263         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
2264         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
2265         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
2266         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
2267         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
2268         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
2269         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
2270         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
2271         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
2272         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
2273         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
2274         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
2275         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
2276         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
2277         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
2278         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
2279         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
2280         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
2281         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
2282         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
2283         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
2284         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
2285         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
2286         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
2287         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
2288         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
2289         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
2290         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
2291         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
2292         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
2293         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
2294         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
2295         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
2296         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
2297         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
2298         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
2299         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
2300         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
2301         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
2302         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
2303         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
2304         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
2305         * storage/IDBLevelDBCoding.h: Added.
2306         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
2307         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
2308         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
2309         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
2310         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
2311
2312 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2313
2314         Reviewed by Pavel Feldman.
2315
2316         Web Inspector: expose exception details when script is paused on exception
2317         https://bugs.webkit.org/show_bug.cgi?id=59591
2318
2319         When script is paused on an exception, the exception value is added as <exception>
2320         property in the local scope and the breakpoint details message says
2321         "Paused on excepion: '<exception to strin value>'."
2322
2323         * English.lproj/localizedStrings.js:
2324         * inspector/front-end/ScopeChainSidebarPane.js:
2325         (WebInspector.ScopeChainSidebarPane.prototype.update):
2326         * inspector/front-end/ScriptsPanel.js:
2327         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
2328         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
2329
2330 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
2331
2332         Reviewed by Pavel Feldman.
2333
2334         Web Inspector: [protocol] Paused event should expose exception value that caused it
2335         https://bugs.webkit.org/show_bug.cgi?id=58996
2336
2337         Debug.pause event now contains an optional reference to the exception
2338         object in case script execution is paused on a JavaScript exception.
2339
2340         Also JavaScript call frames are passed directly into the injected script when
2341         we need to wrap them for passing to the front-end. This change breaks cyclic
2342         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
2343
2344         * bindings/js/JSInjectedScriptHostCustom.cpp:
2345         * bindings/js/ScriptDebugServer.cpp:
2346         (WebCore::ScriptDebugServer::dispatchDidPause):
2347         * bindings/js/ScriptDebugServer.h:
2348         * bindings/v8/ScriptDebugServer.cpp:
2349         (WebCore::ScriptDebugServer::breakProgram):
2350         (WebCore::ScriptDebugServer::editScriptSource):
2351         (WebCore::ScriptDebugServer::breakProgramCallback):
2352         (WebCore::ScriptDebugServer::handleV8DebugEvent):
2353         * bindings/v8/ScriptDebugServer.h:
2354         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2355         * inspector/InjectedScript.cpp:
2356         (WebCore::InjectedScript::evaluateOnCallFrame):
2357         (WebCore::InjectedScript::wrapCallFrames):
2358         * inspector/InjectedScript.h:
2359         * inspector/InjectedScriptHost.cpp:
2360         * inspector/InjectedScriptHost.h:
2361         (WebCore::InjectedScriptHost::init):
2362         * inspector/InjectedScriptHost.idl:
2363         * inspector/InjectedScriptSource.js:
2364         (.):
2365         * inspector/Inspector.json:
2366         * inspector/InspectorAgent.cpp:
2367         (WebCore::InspectorAgent::InspectorAgent):
2368         * inspector/InspectorDebuggerAgent.cpp:
2369         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
2370         (WebCore::InspectorDebuggerAgent::currentCallFrames):
2371         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
2372         (WebCore::InspectorDebuggerAgent::didPause):
2373         (WebCore::InspectorDebuggerAgent::didContinue):
2374         (WebCore::InspectorDebuggerAgent::clear):
2375         * inspector/InspectorDebuggerAgent.h:
2376         * inspector/ScriptDebugListener.h:
2377         * inspector/WorkerInspectorController.cpp:
2378         (WebCore::WorkerInspectorController::WorkerInspectorController):
2379
2380 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2381
2382         Reviewed by Yury Semikhatsky.
2383
2384         Web Inspector: implement incremental CSS editing in the structure view.
2385         https://bugs.webkit.org/show_bug.cgi?id=59455
2386
2387         * inspector/front-end/StylesSidebarPane.js:
2388         (WebInspector.StylePropertyTreeElement.prototype):
2389
2390 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
2391
2392         Reviewed by Eric Seidel.
2393
2394         Frame.h shouldn't include Document.h
2395         https://bugs.webkit.org/show_bug.cgi?id=59560
2396
2397         Frame can use a forward-declared Document if we move
2398         Frame::displayStringModifiedByEncoding's implementation out of the
2399         header.
2400                                 Size  #includes  Size * #includes
2401         Before: page/Frame.h:   0.746       653           487.138
2402                 dom/Document.h: 0.220      1306           287.320
2403         
2404         After:  page/Frame.h:   0.646       653           421.838
2405                 dom/Document.h: 0.220      1189           261.580
2406
2407         * WebCore.exp.in:
2408         * bindings/ScriptControllerBase.cpp:
2409         * bindings/generic/BindingSecurityBase.cpp:
2410         * bindings/v8/V8Proxy.cpp:
2411         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
2412         * dom/CharacterData.cpp:
2413         * dom/UserTypingGestureIndicator.cpp:
2414         * editing/chromium/SelectionControllerChromium.cpp:
2415         * inspector/InspectorDOMStorageResource.cpp:
2416         * inspector/InspectorInstrumentation.h:
2417         * loader/PingLoader.cpp:
2418         * loader/SubresourceLoader.cpp:
2419         * loader/appcache/DOMApplicationCache.cpp:
2420         * loader/cache/CachedResourceRequest.cpp:
2421         * page/Frame.cpp:
2422         (WebCore::Frame::displayStringModifiedByEncoding):
2423         * page/Frame.h:
2424         * page/Geolocation.cpp:
2425         * page/Location.cpp:
2426         * page/Navigator.cpp:
2427         * page/PageGroupLoadDeferrer.cpp:
2428         * page/PerformanceTiming.cpp:
2429         * xml/XSLTProcessorLibxslt.cpp:
2430
2431 2011-04-27  James Robinson  <jamesr@chromium.org>
2432
2433         Reviewed by Eric Seidel.
2434
2435         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2436         https://bugs.webkit.org/show_bug.cgi?id=59377
2437
2438         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
2439         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
2440
2441         * css/CSSStyleSelector.cpp:
2442         (WebCore::CSSStyleSelector::applyProperty):
2443         * page/animation/AnimationBase.cpp:
2444         (WebCore::blendFunc):
2445         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2446         (WebCore::PropertyWrapperShadow::blend):
2447         * rendering/style/RenderStyle.cpp:
2448         (WebCore::RenderStyle::setTextShadow):
2449         (WebCore::RenderStyle::setBoxShadow):
2450         * rendering/style/RenderStyle.h:
2451         (WebCore::InheritedFlags::textShadow):
2452         * rendering/style/ShadowData.cpp:
2453         (WebCore::ShadowData::ShadowData):
2454         * rendering/style/ShadowData.h:
2455         (WebCore::ShadowData::ShadowData):
2456         (WebCore::ShadowData::next):
2457         (WebCore::ShadowData::setNext):
2458         * rendering/style/StyleRareInheritedData.cpp:
2459         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2460         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2461         * rendering/style/StyleRareInheritedData.h:
2462         * rendering/style/StyleRareNonInheritedData.cpp:
2463         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2464
2465 2011-04-26  David Levin  <levin@chromium.org>
2466
2467         Reviewed by Eric Seidel.
2468
2469         Fix some strict PassOwnPtr issues in WebCore.
2470         https://bugs.webkit.org/show_bug.cgi?id=59563
2471
2472         * css/SVGCSSStyleSelector.cpp:
2473         (WebCore::CSSStyleSelector::applySVGProperty):
2474         * html/canvas/WebGLRenderingContext.cpp:
2475         (WebCore::WebGLRenderingContext::create):
2476         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
2477         * platform/text/TextCodecLatin1.cpp:
2478         (WebCore::newStreamingTextDecoderWindowsLatin1):
2479         * platform/text/TextCodecUTF16.cpp:
2480         (WebCore::newStreamingTextDecoderUTF16LE):
2481         (WebCore::newStreamingTextDecoderUTF16BE):
2482         * platform/text/TextCodecUserDefined.cpp:
2483         (WebCore::newStreamingTextDecoderUserDefined):
2484         * platform/text/mac/TextCodecMac.cpp:
2485         (WebCore::newTextCodecMac):
2486         * workers/Worker.cpp:
2487         (WebCore::Worker::notifyFinished):
2488
2489 2011-04-26  Justin Novosad  <junov@chromium.org>
2490
2491         Reviewed by Kenneth Russell.
2492
2493         [Chromium] Expose skia gpu canvas rendering as a runtime flag
2494         https://bugs.webkit.org/show_bug.cgi?id=58683
2495         Replace the SKIA_GPU compile flag by the pre-existing
2496         acceleratedDrawingEnabled flag. Most code changes are trivial:
2497         compile-time conditionals on SKIA_GPU were either replaced with
2498         a run-time check, or a compile time check on USE(SKIA) 
2499
2500         No new tests. Covered by existing tests.
2501
2502         * html/canvas/CanvasRenderingContext2D.cpp:
2503         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2504         * page/Page.cpp:
2505         (WebCore::Page::sharedGraphicsContext3D):
2506         Added check for the acceleratedDrawing flag.
2507         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2508         (WebCore::DrawingBuffer::DrawingBuffer):
2509         (WebCore::DrawingBuffer::publishToPlatformLayer):
2510         * platform/graphics/gpu/DrawingBuffer.h:
2511         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2512         (WebCore::SharedGraphicsContext3D::create):
2513         On Skia builds, this methos now receives a bool arg to turn on
2514         GPU-accelerated skia rendering
2515         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
2516         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2517         (WebCore::SharedGraphicsContext3D::grContext):
2518         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2519         * platform/graphics/skia/ImageSkia.cpp:
2520         (WebCore::computeResamplingMode):
2521         (WebCore::paintSkBitmap):
2522         (WebCore::Image::drawPattern):
2523         * platform/graphics/skia/PlatformContextSkia.cpp:
2524         (WebCore::PlatformContextSkia::PlatformContextSkia):
2525         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2526         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2527         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2528         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2529         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2530         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2531         (WebCore::PlatformContextSkia::markDirtyRect):
2532         * platform/graphics/skia/PlatformContextSkia.h:
2533         (WebCore::PlatformContextSkia::accelerationMode):
2534         (WebCore::PlatformContextSkia::useGPU):
2535         (WebCore::PlatformContextSkia::useSkiaGPU):
2536
2537 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2538
2539         Not reviewed: restore inspector test disabled in r84913.
2540
2541         Test: http/tests/inspector-enabled/dom-storage-open.html
2542
2543         * inspector/InspectorDOMStorageAgent.cpp:
2544         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2545
2546 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2547
2548         Reviewed by Tony Chang.
2549
2550         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2551         https://bugs.webkit.org/show_bug.cgi?id=59182
2552
2553         Use vertical offsets of the shaping results.
2554
2555         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2556
2557         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2558         (WebCore::ComplexTextController::ComplexTextController):
2559         Added initialization of m_startingY.
2560         (WebCore::ComplexTextController::nextScriptRun):
2561         Followed the change in handling positions.
2562         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2563         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2564         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2565         (WebCore::ComplexTextController::setGlyphPositions):
2566         Changed to use vertical offsets as same as horizontal offsets.
2567         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2568         Removed m_xPositions and Added m_positions and m_startingY.
2569         (WebCore::ComplexTextController::positions): Added.
2570         * platform/graphics/chromium/FontLinux.cpp:
2571         Followed the change in ComplexTextController.
2572         (WebCore::Font::drawComplexText): Ditto.
2573         (WebCore::Font::floatWidthForComplexText): Ditto.
2574         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2575         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2576         (WebCore::Font::selectionRectForComplexText): Ditto.
2577
2578 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2579
2580         Reviewed by Eric Seidel.
2581
2582         Root element should establish a new block formatting context
2583         https://bugs.webkit.org/show_bug.cgi?id=54573
2584
2585         Always expanding the root renderer to include overhanging floats.
2586
2587         Test: fast/block/float/float-overhangs-root.html
2588
2589         * rendering/RenderBlock.cpp:
2590         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2591
2592 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2593
2594         Reviewed by Andreas Kling.
2595
2596         [Qt] Improper rendering of <button> tag when it contains a <br>
2597         https://bugs.webkit.org/show_bug.cgi?id=50521
2598
2599         Test: platform/qt/fast/forms/button-line-break.html
2600
2601         * platform/qt/RenderThemeQt.cpp:
2602         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2603         (WebCore::RenderThemeQt::setButtonPadding):
2604
2605 2011-04-26  James Robinson  <jamesr@chromium.org>
2606
2607         Reviewed by Kenneth Russell.
2608
2609         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2610         https://bugs.webkit.org/show_bug.cgi?id=59572
2611
2612         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2613         when LayerRendererChromium was set.  We set this pointer every frame
2614         and should only reset the tiles if the new LayerRendererChromium is
2615         different from the old one (indicating a context loss), not just reset
2616         on every frame.
2617
2618         * platform/graphics/chromium/LayerTilerChromium.cpp:
2619         (WebCore::LayerTilerChromium::setLayerRenderer):
2620         * platform/graphics/chromium/LayerTilerChromium.h:
2621
2622 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2623
2624         Reviewed by Eric Seidel.
2625
2626         beginElement broken by setAttribute
2627         https://bugs.webkit.org/show_bug.cgi?id=26019
2628
2629         Test: svg/animations/animate-beginElementAt.svg
2630
2631         * svg/SVGAnimationElement.cpp:
2632         (WebCore::SVGAnimationElement::attributeChanged):
2633         Reset the animation state here as the rest of the code reads it and would still
2634         think we are animating when we are not.
2635
2636         * svg/animation/SVGSMILElement.h:
2637         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2638
2639 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2640
2641         Unreviewed, rolling out r84989.
2642         http://trac.webkit.org/changeset/84989
2643         https://bugs.webkit.org/show_bug.cgi?id=59566
2644
2645         REGRESSION (r84989): Lots of vertical text tests failing on
2646         windows (Requested by weinig on #webkit).
2647
2648         * platform/graphics/FontPlatformData.h:
2649         * platform/graphics/win/FontCacheWin.cpp:
2650         (WebCore::FontCache::getFontDataForCharacters):
2651         (WebCore::FontCache::createFontPlatformData):
2652         * platform/graphics/win/FontCustomPlatformData.cpp:
2653         (WebCore::FontCustomPlatformData::fontPlatformData):
2654         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2655         (WebCore::FontPlatformData::FontPlatformData):
2656         * platform/graphics/win/FontPlatformDataWin.cpp:
2657         (WebCore::FontPlatformData::FontPlatformData):
2658
2659 2011-04-26  Sam Weinig  <sam@webkit.org>
2660
2661         Reviewed by Eric Seidel.
2662
2663         Try again:
2664             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2665             https://bugs.webkit.org/show_bug.cgi?id=59310
2666
2667         * bindings/js/JSDOMBinding.h:
2668         (WebCore::DOMConstructorObject::DOMConstructorObject):
2669         * bindings/js/JSDOMWrapper.h:
2670         (WebCore::JSDOMWrapper::globalObject):
2671         (WebCore::JSDOMWrapper::scriptExecutionContext):
2672         (WebCore::JSDOMWrapper::createStructure):
2673         (WebCore::JSDOMWrapper::JSDOMWrapper):
2674         * bindings/scripts/CodeGeneratorJS.pm:
2675
2676 2011-04-26  Sam Weinig  <sam@webkit.org>
2677
2678         Reviewed by David Hyatt.
2679
2680         Remove Datagrid from the tree
2681         https://bugs.webkit.org/show_bug.cgi?id=59543
2682
2683         * Android.derived.jscbindings.mk:
2684         * Android.derived.v8bindings.mk:
2685         * Android.jscbindings.mk:
2686         * Android.v8bindings.mk:
2687         * CMakeLists.txt:
2688         * CodeGenerators.pri:
2689         * Configurations/FeatureDefines.xcconfig:
2690         * DerivedSources.cpp:
2691         * DerivedSources.make:
2692         * GNUmakefile.am:
2693         * GNUmakefile.list.am:
2694         * UseJSC.cmake:
2695         * WebCore.gypi:
2696         * WebCore.pro:
2697         * WebCore.vcproj/WebCore.vcproj:
2698         * WebCore.xcodeproj/project.pbxproj:
2699         * bindings/js/JSBindingsAllInOne.cpp:
2700         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2701         * bindings/js/JSDataGridDataSource.cpp: Removed.
2702         * bindings/js/JSDataGridDataSource.h: Removed.
2703         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2704         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2705         * bindings/v8/V8DataGridDataSource.h: Removed.
2706         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2707         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2708         * css/CSSStyleSelector.cpp:
2709         * css/CSSStyleSelector.h:
2710         * css/html.css:
2711         (input, textarea, keygen, select, button, isindex):
2712         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2713         * editing/htmlediting.cpp:
2714         (WebCore::canHaveChildrenForEditing):
2715         * features.pri:
2716         * html/DOMDataGridDataSource.cpp: Removed.
2717         * html/DOMDataGridDataSource.h: Removed.
2718         * html/DataGridColumn.cpp: Removed.
2719         * html/DataGridColumn.h: Removed.
2720         * html/DataGridColumn.idl: Removed.
2721         * html/DataGridColumnList.cpp: Removed.
2722         * html/DataGridColumnList.h: Removed.
2723         * html/DataGridColumnList.idl: Removed.
2724         * html/DataGridDataSource.h: Removed.
2725         * html/HTMLDataGridCellElement.cpp: Removed.
2726         * html/HTMLDataGridCellElement.h: Removed.
2727         * html/HTMLDataGridCellElement.idl: Removed.
2728         * html/HTMLDataGridColElement.cpp: Removed.
2729         * html/HTMLDataGridColElement.h: Removed.
2730         * html/HTMLDataGridColElement.idl: Removed.
2731         * html/HTMLDataGridElement.cpp: Removed.
2732         * html/HTMLDataGridElement.h: Removed.
2733         * html/HTMLDataGridElement.idl: Removed.
2734         * html/HTMLDataGridRowElement.cpp: Removed.
2735         * html/HTMLDataGridRowElement.h: Removed.
2736         * html/HTMLDataGridRowElement.idl: Removed.
2737         * html/HTMLElement.cpp:
2738         (WebCore::HTMLElement::ieForbidsInsertHTML):
2739         * html/HTMLElementsAllInOne.cpp:
2740         * html/HTMLTagNames.in:
2741         * page/DOMWindow.idl:
2742         * rendering/RenderBox.cpp:
2743         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2744         * rendering/RenderDataGrid.cpp: Removed.
2745         * rendering/RenderDataGrid.h: Removed.
2746         * rendering/RenderingAllInOne.cpp:
2747
2748 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2749
2750         Reviewed by Adele Peterson.
2751
2752         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2753         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2754
2755         This platform dependent patch makes WebKit (Windows) show the
2756         vertical writing text correctly.  Job was done by adding a prefix '@'
2757         in front of the font family name (Windows Only). No new tests added.
2758         Some layout tests images:
2759         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2760
2761         * platform/graphics/FontPlatformData.h:
2762         * platform/graphics/win/FontCacheWin.cpp:
2763         (WebCore::FontCache::getFontDataForCharacters):
2764         (WebCore::FontCache::createFontPlatformData):
2765         * platform/graphics/win/FontCustomPlatformData.cpp:
2766         (WebCore::FontCustomPlatformData::fontPlatformData):
2767         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2768         (WebCore::FontPlatformData::FontPlatformData):
2769         * platform/graphics/win/FontPlatformDataWin.cpp:
2770         (WebCore::FontPlatformData::FontPlatformData):
2771
2772 2011-04-26  Jer Noble  <jer.noble@apple.com>
2773
2774         Reviewed by Brady Eidson.
2775
2776         HTML5 video fullscreen transition causes an audio stutter
2777         https://bugs.webkit.org/show_bug.cgi?id=59544
2778
2779         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2780         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2781         layer to render it invisible, instead just set the layer as hidden.
2782
2783         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2784         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2785         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2786         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2787         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2788         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2789
2790 2011-04-26  Christian Dywan  <christian@lanedo.com>
2791
2792         Reviewed by Eric Seidel.
2793
2794         Extra separator after Select All in context menu
2795         https://bugs.webkit.org/show_bug.cgi?id=54092
2796
2797         * page/ContextMenuController.cpp: Move separator to non-GTK+
2798             port guards since it is for the spelling options menu
2799             which the GTK+ port doesn't use.
2800
2801 2011-04-26  James Robinson  <jamesr@chromium.org>
2802
2803         Reviewed by Kenneth Russell.
2804
2805         [chromium] Clear out LayerTilerChromium's tiles on lost context
2806         https://bugs.webkit.org/show_bug.cgi?id=59233
2807
2808         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
2809         no longer valid since they exist in the previous LayerRendererChromium.
2810
2811         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
2812
2813         * platform/graphics/chromium/LayerTilerChromium.h:
2814         (WebCore::LayerTilerChromium::setLayerRenderer):
2815
2816 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2817
2818         Reviewed by Dirk Schulze.
2819
2820         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
2821         https://bugs.webkit.org/show_bug.cgi?id=57644
2822
2823         Manual test: plugins/windowed-in-iframe-2.html
2824
2825         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
2826         * platform/gtk/WidgetGtk.cpp:
2827         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
2828         * plugins/PluginView.h: Added helper method to set the allocation and clip.
2829         * plugins/gtk/PluginViewGtk.cpp:
2830         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
2831         the allocation immediately. Bring this method into sync with the implementation in
2832         the Qt port.
2833         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
2834         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
2835
2836 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2837
2838         Reviewed by Eric Seidel.
2839
2840         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
2841         https://bugs.webkit.org/show_bug.cgi?id=58818
2842
2843         Prevent allocating scratch buffers larger than the target GdkDrawable
2844         when creating a WidgetRenderingContext. This prevents incredibly large
2845         widgets from crashing the X Server. This change also allowed greatly
2846         simplifying the way that the painting offset is calculated.
2847
2848         * platform/gtk/WidgetRenderingContext.cpp:
2849         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
2850         larger than the target GdkDrawable.
2851         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
2852         blit by looking at the location of the target rect itself, rather than delaying the
2853         calculation up to this point.
2854         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
2855         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
2856         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
2857         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
2858         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
2859         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
2860         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
2861         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
2862         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
2863         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
2864         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
2865         a member to store the IntSize mapping from the coordinates of the target to the coordinates
2866         of the scratch buffer.
2867
2868 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
2869
2870         Reviewed by Adam Barth.
2871
2872         Respect charset in handleDataURL
2873         https://bugs.webkit.org/show_bug.cgi?id=47746
2874
2875         Original patch by Kwang Yul Seo <skyul@company100.net>
2876
2877         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2878         returns an empty string because encoding name is not specified.
2879
2880         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2881
2882         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2883
2884         * platform/network/DataURL.cpp:
2885         (WebCore::handleDataURL):
2886
2887 2011-04-26  Anders Carlsson  <andersca@apple.com>
2888
2889         Fix clang++ build.
2890
2891         You can never have too many casts!
2892
2893         * accessibility/mac/AccessibilityObjectWrapper.mm:
2894         (-[AccessibilityObjectWrapper position]):
2895         * editing/mac/SelectionControllerMac.mm:
2896         (WebCore::accessibilityConvertScreenRect):
2897
2898 2011-04-26  Chris Rogers  <crogers@google.com>
2899
2900         Reviewed by Kenneth Russell.
2901
2902         Fix web audio build on mac port
2903         https://bugs.webkit.org/show_bug.cgi?id=59355
2904
2905         No new tests since audio API is not yet implemented.
2906
2907         * WebCore.xcodeproj/project.pbxproj:
2908         * bindings/js/JSAudioContextCustom.cpp:
2909         (WebCore::JSAudioContext::visitChildren):
2910         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
2911         (WebCore::JSJavaScriptAudioNode::visitChildren):
2912         * webaudio/AudioContext.idl:
2913
2914 2011-04-26  Chris Rogers  <crogers@google.com>
2915
2916         Reviewed by Kenneth Russell.
2917
2918         Add FFTFrame implementation for FFmpeg
2919         https://bugs.webkit.org/show_bug.cgi?id=59408
2920
2921         No new tests since audio API is not yet implemented.
2922
2923         * WebCore.gyp/WebCore.gyp:
2924         * WebCore.gypi:
2925         * platform/audio/FFTFrame.h:
2926         * platform/audio/FFTFrameStub.cpp:
2927         * platform/audio/ffmpeg: Added.
2928         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
2929         (WebCore::FFTFrame::FFTFrame):
2930         (WebCore::FFTFrame::initialize):
2931         (WebCore::FFTFrame::cleanup):
2932         (WebCore::FFTFrame::~FFTFrame):
2933         (WebCore::FFTFrame::multiply):
2934         (WebCore::FFTFrame::doFFT):
2935         (WebCore::FFTFrame::doInverseFFT):
2936         (WebCore::FFTFrame::realData):
2937         (WebCore::FFTFrame::imagData):
2938         (WebCore::FFTFrame::getUpToDateComplexData):
2939         (WebCore::FFTFrame::contextForSize):
2940         * platform/audio/mac/FFTFrameMac.cpp:
2941         * webaudio/ConvolverNode.cpp:
2942
2943 2011-04-26  Jeff Miller  <jeffm@apple.com>
2944
2945         Add a newline at the end of SVGFEDropShadowElement.idl.
2946
2947         * svg/SVGFEDropShadowElement.idl:
2948
2949 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2950
2951         Reviewed by Eric Seidel.
2952
2953         InlineBox.h shouldn't include RenderBR.h
2954         https://bugs.webkit.org/show_bug.cgi?id=59480
2955
2956         Per bug 59348 RenderBR.h is a "top header" by include * size, because
2957         InlineBox.h includes it. There's no reason why it has to.
2958
2959         * rendering/InlineBox.h:
2960         * rendering/InlineTextBox.cpp:
2961         * rendering/RenderBlock.h:
2962
2963 2011-04-26  Sam Weinig  <sam@webkit.org>
2964
2965         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
2966         I should do.
2967
2968         * bindings/js/JSDOMBinding.h:
2969         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2970         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2971         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2972         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2973         (WebCore::DOMConstructorObject::DOMConstructorObject):
2974         * bindings/js/JSDOMWrapper.h:
2975         (WebCore::JSDOMWrapper::JSDOMWrapper):
2976         * bindings/scripts/CodeGeneratorJS.pm:
2977
2978 2011-04-26  Sam Weinig  <sam@webkit.org>
2979
2980         Fix build.
2981
2982         * bindings/js/JSDOMWrapper.h:
2983         (WebCore::JSDOMWrapper::globalObject):
2984
2985 2011-04-26  Sam Weinig  <sam@webkit.org>
2986
2987         Roll r84945 back in with infinite recursion removed.
2988
2989         * bindings/js/JSDOMBinding.h:
2990         (WebCore::DOMConstructorObject::DOMConstructorObject):
2991         * bindings/js/JSDOMWrapper.h:
2992         (WebCore::JSDOMWrapper::globalObject):
2993         (WebCore::JSDOMWrapper::scriptExecutionContext):
2994         (WebCore::JSDOMWrapper::createStructure):
2995         (WebCore::JSDOMWrapper::JSDOMWrapper):
2996         * bindings/scripts/CodeGeneratorJS.pm:
2997
2998 2011-04-26  Sam Weinig  <sam@webkit.org>
2999
3000         Rollout previous patch. It broke stuff.
3001
3002         * bindings/js/JSDOMBinding.h:
3003         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3004         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3005         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3006         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3007         (WebCore::DOMConstructorObject::DOMConstructorObject):
3008         * bindings/js/JSDOMWrapper.h:
3009         (WebCore::JSDOMWrapper::JSDOMWrapper):
3010         * bindings/scripts/CodeGeneratorJS.pm:
3011
3012 2011-04-26  Sam Weinig  <sam@webkit.org>
3013
3014         Reviewed by Maciej Stachowiak.
3015
3016         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
3017         https://bugs.webkit.org/show_bug.cgi?id=59310
3018
3019         * bindings/js/JSDOMBinding.h:
3020         (WebCore::DOMConstructorObject::DOMConstructorObject):
3021         * bindings/js/JSDOMWrapper.h:
3022         (WebCore::JSDOMWrapper::globalObject):
3023         (WebCore::JSDOMWrapper::scriptExecutionContext):
3024         (WebCore::JSDOMWrapper::createStructure):
3025         (WebCore::JSDOMWrapper::JSDOMWrapper):
3026         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
3027
3028         * bindings/scripts/CodeGeneratorJS.pm:
3029         Make JSDOMWrapper the base class.
3030
3031 2011-04-26  Dan Bernstein  <mitz@apple.com>
3032
3033         Reviewed by Mark Rowe.
3034
3035         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
3036
3037         * Configurations/Base.xcconfig:
3038         * Configurations/CompilerVersion.xcconfig: Added.
3039
3040 2011-04-26  Adrienne Walker  <enne@google.com>
3041
3042         Reviewed by Geoffrey Garen.
3043
3044         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
3045         https://bugs.webkit.org/show_bug.cgi?id=59469
3046
3047         * platform/chromium/TraceEvent.h:
3048         (WebCore::internal::ScopeTracer::ScopeTracer):
3049
3050 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3051
3052         Reviewed by Oliver Hunt.
3053
3054         Nixed special finalizer handling for WebCore strings
3055         https://bugs.webkit.org/show_bug.cgi?id=59425
3056
3057         Not needed anymore, since weak handles have finalizers.
3058
3059         * WebCore.exp.in: Exports!
3060
3061         * bindings/js/DOMWrapperWorld.cpp:
3062         (WebCore::JSStringOwner::finalize):
3063         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
3064         so we don't need special treatment anymore.
3065
3066         * bindings/js/DOMWrapperWorld.h:
3067         (WebCore::JSStringOwner::JSStringOwner):
3068         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
3069         instead of a WeakGCMap, so we can specify a custom finalizer.
3070
3071         * bindings/js/JSDOMBinding.cpp:
3072         (WebCore::jsStringSlowCase):
3073         * bindings/js/JSDOMBinding.h:
3074         (WebCore::jsString): Updated for string map change.
3075
3076 2011-04-26  David Kilzer  <ddkilzer@apple.com>
3077
3078         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
3079
3080         Reviewed by Antti Koivisto.
3081
3082         To enable HTTP pipelining post-SnowLeopard, use this command:
3083
3084             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
3085
3086         * platform/network/cf/ResourceRequestCFNet.cpp:
3087         (WebCore::readBooleanPreference): Re-added.  Originally added in
3088         r76756 and removed in r84120.
3089         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
3090         HTTP pipelining if use default is set to true.  Added macro
3091         guards to match those in ResourceRequestMac.mm.
3092
3093 2011-04-26  Antti Koivisto  <antti@apple.com>
3094
3095         Reviewed by Adele Peterson.
3096
3097         Don't strip fragments from file: urls in memory cache
3098         https://bugs.webkit.org/show_bug.cgi?id=59463
3099         <rdar://problem/9231130>
3100
3101         Some clients expect file: resources to be unique based on fragment identifier. 
3102         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
3103
3104         Test: fast/loader/file-protocol-fragment.html
3105
3106         * loader/cache/MemoryCache.cpp:
3107         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
3108
3109 2011-04-26  David Levin  <levin@chromium.org>
3110
3111         Reviewed by Darin Adler.
3112
3113         Fix more strict OwnPtr in WebCore (round N).
3114         https://bugs.webkit.org/show_bug.cgi?id=59464
3115
3116         * dom/Document.cpp:
3117         (WebCore::Document::Document):
3118         (WebCore::Document::attach):
3119         * fileapi/FileReader.cpp:
3120         (WebCore::FileReader::terminate):
3121         * loader/DocumentThreadableLoader.cpp:
3122         (WebCore::DocumentThreadableLoader::preflightFailure):
3123         * workers/DefaultSharedWorkerRepository.cpp:
3124         (WebCore::SharedWorkerConnectTask::create):
3125         (WebCore::SharedWorkerScriptLoader::load):
3126
3127 2011-04-26  Ruben  <chromium@hybridsource.org>
3128
3129         Reviewed by Tony Chang.
3130
3131         Change linux ifdefs for Chromium to Unix instead, allowing
3132         new Unix ports to be enabled by default
3133         https://bugs.webkit.org/show_bug.cgi?id=59297
3134
3135         No new tests, just changing preprocessor defines.
3136
3137         * bindings/js/JSInspectorFrontendHostCustom.cpp:
3138         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
3139         * dom/SelectElement.cpp:
3140         * loader/cache/CachedFont.cpp:
3141         * page/EventHandler.cpp:
3142         * page/chromium/EventHandlerChromium.cpp:
3143         * platform/Scrollbar.cpp:
3144         * platform/chromium/PlatformBridge.h:
3145         * platform/graphics/chromium/FontPlatformData.h:
3146         * platform/graphics/skia/FontCustomPlatformData.cpp:
3147         * platform/graphics/skia/FontCustomPlatformData.h:
3148
3149 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3150
3151         Reviewed by Dan Bernstein.
3152
3153         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
3154         https://bugs.webkit.org/show_bug.cgi?id=49111
3155
3156         Even when the offset corresponds to a position visually left of the box
3157         and there aren't any inline boxes on the left, the previous/next position
3158         may still correspond to some position in the same line.
3159
3160         The bug was caused by our ignoring such cases. Fixed the bug by comparing
3161         previous/next position's inline box to the current box. If they match,
3162         then we stay on the same position because moving to the left visually at
3163         the left edge should not result in a position on the same line.
3164
3165         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
3166         the left edge or to the right edge, and a bug that WebKit could not move to
3167         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
3168
3169         Test cases are added to editing/selection/move-left-right.html
3170
3171         * editing/VisiblePosition.cpp:
3172         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
3173         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
3174
3175 2011-04-26  Gabor Loki  <loki@webkit.org>
3176
3177         Reviewed by Csaba Osztrogonác.
3178
3179         Speeding up SVG filters with multicore (SMP) support
3180         https://bugs.webkit.org/show_bug.cgi?id=43903
3181
3182         Some SVG filters execute a huge number of pixel manipulations, which
3183         cannot be sped up by graphics accelerators, since their algorithm is
3184         too complex. Using the power of Symmetric Multi Processing (SMP) we
3185         can split up a task to smaller (data independent) tasks, which can be
3186         executed independently.
3187
3188         The ParallelJobs framework provides a simple way for distributed
3189         programming. The framework is based on WebKit's threading infrastructure,
3190         Open Multi-Processing's (OpenMP) API, and libdispatch API.
3191
3192         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
3193         * platform/graphics/filters/FETurbulence.cpp:
3194         (WebCore::FETurbulence::PaintingData::PaintingData):
3195         (WebCore::FETurbulence::noise2D):
3196         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
3197         (WebCore::FETurbulence::fillRegion):
3198         (WebCore::FETurbulence::fillRegionWorker):
3199         (WebCore::FETurbulence::apply):
3200         * platform/graphics/filters/FETurbulence.h:
3201
3202 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3203
3204         Reviewed by Yury Semikhatsky.
3205
3206         Web Inspector: close button is off in docked mode on a mac.
3207         https://bugs.webkit.org/show_bug.cgi?id=59453
3208
3209         * inspector/front-end/inspector.css:
3210         (.toolbar-item.close-left):
3211
3212 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3213
3214         Reviewed by Yury Semikhatsky.
3215
3216         Web Inspector: New Style is not working (UI glitch)
3217         https://bugs.webkit.org/show_bug.cgi?id=59451
3218
3219         * inspector/InspectorDOMStorageAgent.cpp:
3220         (WebCore::InspectorDOMStorageAgent::setFrontend):
3221         * inspector/front-end/AuditRules.js:
3222         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
3223         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
3224         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
3225         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
3226         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
3227         * inspector/front-end/CSSStyleModel.js:
3228         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
3229         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
3230         (WebInspector.CSSStyleModel.prototype.addRule):
3231         (WebInspector.CSSStyleModel.prototype.addRule.callback):
3232         (WebInspector.CSSStyleModel.prototype._documentElementId):
3233         * inspector/front-end/DOMAgent.js:
3234         (WebInspector.DOMNode.prototype._addAttribute):
3235         (WebInspector.DOMNode.prototype.documentElement):
3236         * inspector/front-end/ResourceTreeModel.js:
3237         (WebInspector.PageDispatcher.prototype.frameDetached):
3238         * inspector/front-end/StylesSidebarPane.js:
3239         (WebInspector.StylesSidebarPane.prototype._createNewRule):
3240
3241 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3242
3243         Reviewed by Yury Semikhatsky.
3244
3245         Web Inspector: introduce DOMStorage::enable and disable.
3246         https://bugs.webkit.org/show_bug.cgi?id=59445
3247
3248         * inspector/Inspector.json:
3249         * inspector/InspectorAgent.cpp:
3250         (WebCore::InspectorAgent::InspectorAgent):
3251         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3252         * inspector/InspectorDOMStorageAgent.cpp:
3253         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
3254         (WebCore::InspectorDOMStorageAgent::restore):
3255         (WebCore::InspectorDOMStorageAgent::enable):
3256         (WebCore::InspectorDOMStorageAgent::disable):
3257         * inspector/InspectorDOMStorageAgent.h:
3258         (WebCore::InspectorDOMStorageAgent::create):
3259         * inspector/front-end/DOMStorage.js:
3260         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3261         * inspector/front-end/ResourcesPanel.js:
3262         (WebInspector.ResourcesPanel.prototype._reset):
3263         * inspector/front-end/inspector.js:
3264
3265 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3266
3267         Reviewed by Yury Semikhatsky.
3268
3269         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
3270         https://bugs.webkit.org/show_bug.cgi?id=59440
3271
3272         * inspector/Inspector.json:
3273         * inspector/InspectorAgent.cpp:
3274         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3275         * inspector/InspectorPageAgent.cpp:
3276         (WebCore::InspectorPageAgent::setFrontend):
3277         (WebCore::InspectorPageAgent::frameNavigated):
3278         * inspector/InspectorPageAgent.h:
3279         * inspector/front-end/AuditsPanel.js:
3280         (WebInspector.AuditsPanel):
3281         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
3282         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
3283         * inspector/front-end/CSSStyleModel.js:
3284         (WebInspector.CSSStyleModelResourceBinding):
3285         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
3286         * inspector/front-end/DOMBreakpointsSidebarPane.js:
3287         (WebInspector.DOMBreakpointsSidebarPane):
3288         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
3289         * inspector/front-end/DOMStorage.js:
3290         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3291         * inspector/front-end/ExtensionServer.js:
3292         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
3293         (WebInspector.ExtensionServer.prototype.initExtensions):
3294         * inspector/front-end/NetworkPanel.js:
3295         (WebInspector.NetworkPanel):
3296         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
3297         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
3298         (WebInspector.NetworkPanel.prototype._frameNavigated):
3299         * inspector/front-end/ResourceTreeModel.js:
3300         (WebInspector.ResourceTreeModel):
3301         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
3302         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
3303         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
3304         (WebInspector.ResourceTreeModel.prototype._frameDetached):
3305         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
3306         (WebInspector.PageDispatcher):
3307         (WebInspector.PageDispatcher.prototype.domContentEventFired):
3308         (WebInspector.PageDispatcher.prototype.loadEventFired):
3309         (WebInspector.PageDispatcher.prototype.frameNavigated):
3310         (WebInspector.PageDispatcher.prototype.frameDetached):
3311         * inspector/front-end/ResourcesPanel.js:
3312         (WebInspector.ResourcesPanel):
3313         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
3314         (WebInspector.ResourcesPanel.prototype._frameNavigated):
3315         * inspector/front-end/inspector.js:
3316
3317 2011-04-26  Csaba Osztrogonác  <ossy@webkit.org>
3318
3319         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
3320         because it broke transitions/multiple-text-shadow-transition.html
3321
3322         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3323         https://bugs.webkit.org/show_bug.cgi?id=59377
3324
3325         * css/CSSStyleSelector.cpp:
3326         (WebCore::CSSStyleSelector::applyProperty):
3327         * page/animation/AnimationBase.cpp:
3328         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3329         (WebCore::PropertyWrapperShadow::blend):
3330         * rendering/style/RenderStyle.cpp:
3331         (WebCore::RenderStyle::setTextShadow):
3332         (WebCore::RenderStyle::setBoxShadow):
3333         * rendering/style/RenderStyle.h:
3334         (WebCore::InheritedFlags::textShadow):
3335         * rendering/style/StyleRareInheritedData.cpp:
3336         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3337         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3338         * rendering/style/StyleRareInheritedData.h:
3339         * rendering/style/StyleRareNonInheritedData.cpp:
3340         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3341
3342 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
3343
3344         Reviewed by Adam Barth.
3345
3346         Turn off make built-in implicit rules for derived sources makefile
3347         https://bugs.webkit.org/show_bug.cgi?id=59418
3348
3349         We don't use any of make's built-in implicit rules, turning them off
3350         speeds up parsing of the makefile.
3351
3352         * WebCore.xcodeproj/project.pbxproj:
3353         * gyp/generate-derived-sources.sh:
3354
3355 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
3356
3357         Reviewed by Nikolas Zimmermann.
3358
3359         ASSERT failure in SVGUseElement
3360         https://bugs.webkit.org/show_bug.cgi?id=59313
3361
3362         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3363         was wrong because the document may not be well-formed.
3364
3365         This patch asserts the element is not pending on resource or the
3366         document is not well-formed.
3367
3368         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3369
3370         * svg/SVGUseElement.cpp:
3371         (WebCore::isWellFormedDocument):
3372         (WebCore::SVGUseElement::insertedIntoDocument):
3373
3374 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
3375
3376         Reviewed by Pavel Feldman.
3377
3378         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
3379         https://bugs.webkit.org/show_bug.cgi?id=59438
3380
3381         * inspector/front-end/DetailedHeapshotView.js:
3382         (WebInspector.DetailedHeapshotView.prototype._changeView):
3383
3384 2011-04-26  David Levin  <levin@chromium.org>
3385
3386         Reviewed by Adam Barth.
3387
3388         Fix a few OwnPtr strict errors in WebCore headers.
3389         https://bugs.webkit.org/show_bug.cgi?id=59431
3390
3391         * bindings/js/ScheduledAction.cpp:
3392         (WebCore::ScheduledAction::create):
3393         * css/MediaQueryMatcher.cpp:
3394         (WebCore::MediaQueryMatcher::prepareEvaluator):
3395         * dom/NodeRareData.h:
3396         (WebCore::NodeListsNodeData::create):
3397         * dom/ScriptRunner.h:
3398         (WebCore::ScriptRunner::create):
3399         * inspector/WorkerInspectorController.cpp:
3400         (WebCore::WorkerInspectorController::connectFrontend):
3401         * loader/icon/IconDatabase.h:
3402         (WebCore::IconDatabase::create):
3403         * platform/graphics/SimpleFontData.cpp:
3404         (WebCore::SimpleFontData::verticalRightOrientationFontData):
3405         (WebCore::SimpleFontData::uprightOrientationFontData):
3406         (WebCore::SimpleFontData::brokenIdeographFontData):
3407         * rendering/style/StyleRareInheritedData.cpp:
3408         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3409         * rendering/svg/SVGResources.h:
3410         (WebCore::SVGResources::ClipperFilterMaskerData::create):
3411         (WebCore::SVGResources::MarkerData::create):
3412         (WebCore::SVGResources::FillStrokeData::create):
3413         * storage/StorageSyncManager.cpp:
3414         (WebCore::StorageSyncManager::close):
3415         * workers/WorkerContext.cpp:
3416         (WebCore::CloseWorkerContextTask::create):
3417         * workers/WorkerMessagingProxy.cpp:
3418         (WebCore::MessageWorkerContextTask::create):
3419         (WebCore::MessageWorkerTask::create):
3420         (WebCore::WorkerExceptionTask::create):
3421         (WebCore::WorkerContextDestroyedTask::create):
3422         (WebCore::WorkerTerminateTask::create):
3423         (WebCore::WorkerThreadActivityReportTask::create):
3424         * workers/WorkerRunLoop.cpp:
3425         (WebCore::WorkerRunLoop::Task::create):
3426         * workers/WorkerThread.cpp:
3427         (WebCore::WorkerThreadStartupData::create):
3428         (WebCore::WorkerThreadShutdownFinishTask::create):
3429         (WebCore::WorkerThreadShutdownStartTask::create):
3430
3431 2011-04-26  Adam Klein  <adamk@chromium.org>
3432
3433         Reviewed by Adam Barth.
3434
3435         Fix last strict OwnPtr violation under svg/...
3436         https://bugs.webkit.org/show_bug.cgi?id=59429
3437
3438         * svg/SVGDocumentExtensions.cpp:
3439         (WebCore::SVGDocumentExtensions::removePendingResource):
3440
3441 2011-04-26  Adam Barth  <abarth@webkit.org>
3442
3443         Reviewed by David Levin.
3444
3445         Fix more strict OwnPtr violations in WebCore
3446         https://bugs.webkit.org/show_bug.cgi?id=59433
3447
3448         These manifest in the Chromium build.
3449
3450         * bindings/v8/ScriptController.cpp:
3451         (WebCore::ScriptController::ScriptController):
3452         * bindings/v8/ScriptDebugServer.cpp:
3453         (WebCore::ScriptDebugServer::editScriptSource):
3454         * bindings/v8/V8DOMMap.cpp:
3455         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
3456         * bindings/v8/V8Proxy.cpp:
3457         (WebCore::V8Proxy::precompileScript):
3458         * bindings/v8/WorkerScriptController.cpp:
3459         (WebCore::WorkerScriptController::WorkerScriptController):
3460         * page/Page.cpp:
3461         (WebCore::Page::Page):
3462         (WebCore::Page::speechInput):
3463         * platform/PlatformGestureRecognizer.cpp:
3464         (WebCore::PlatformGestureRecognizer::create):
3465         * platform/PlatformGestureRecognizer.h:
3466         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3467         (WebCore::DrawingBuffer::DrawingBuffer):
3468         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3469         (WebCore::CCLayerImpl::CCLayerImpl):
3470         * platform/graphics/gpu/Texture.cpp:
3471         (WebCore::Texture::create):
3472         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
3473         (WebCore::BMPImageDecoder::decodeHelper):
3474         * platform/image-decoders/gif/GIFImageDecoder.cpp:
3475         (WebCore::GIFImageDecoder::decode):
3476         * platform/image-decoders/ico/ICOImageDecoder.cpp:
3477         (WebCore::ICOImageDecoder::decodeAtIndex):
3478         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3479         (WebCore::JPEGImageDecoder::decode):
3480         * platform/image-decoders/png/PNGImageDecoder.cpp:
3481         (WebCore::PNGImageDecoder::decode):
3482         * storage/chromium/DatabaseTrackerChromium.cpp:
3483         (WebCore::DatabaseTracker::addOpenDatabase):
3484
3485 2011-04-25  David Levin  <levin@chromium.org>
3486
3487         Reviewed by Adam Barth.
3488
3489         Fix OwnPtr strict errors in CrossThreadTask.h
3490         https://bugs.webkit.org/show_bug.cgi?id=59427
3491
3492         * dom/CrossThreadTask.h:
3493         (WebCore::CrossThreadTask1::create):
3494         (WebCore::CrossThreadTask2::create):
3495         (WebCore::CrossThreadTask3::create):
3496         (WebCore::CrossThreadTask4::create):
3497         (WebCore::CrossThreadTask5::create):
3498         (WebCore::CrossThreadTask6::create):
3499         (WebCore::CrossThreadTask7::create):
3500         (WebCore::CrossThreadTask8::create):
3501
3502 2011-04-25  Mark Rowe  <mrowe@apple.com>
3503
3504         Reviewed by Dan Bernstein.
3505
3506         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
3507
3508         * css/CSSStyleApplyProperty.cpp:
3509         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
3510         * css/CSSStyleApplyProperty.h:
3511         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
3512
3513 2011-04-25  Levi Weintraub  <leviw@chromium.org>
3514
3515         Reviewed by Ryosuke Niwa.
3516
3517         REGRESSION: a character appears after tab span when typing immediately before the tab span
3518         https://bugs.webkit.org/show_bug.cgi?id=58132
3519
3520         Correcting the order of operations we use to avoid inserting into invalid positions in
3521         ReplaceSelectionCommand to avoid inserting into tab-spans.
3522
3523         Test: editing/pasteboard/paste-before-tab-span.html
3524
3525         * editing/ReplaceSelectionCommand.cpp:
3526         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
3527         positionAvoidingPrecedingNodes, since that function could once again put our position
3528         inside a tab span.
3529
3530 2011-04-25  David Levin  <levin@chromium.org>
3531
3532         Reviewed by Adam Barth.
3533
3534         Fix OwnPtr strict error in ImageBuffer.h
3535         https://bugs.webkit.org/show_bug.cgi?id=59422
3536
3537         * platform/graphics/ImageBuffer.h:
3538         (WebCore::ImageBuffer::create):
3539
3540 2011-04-25  Adam Barth  <abarth@webkit.org>
3541
3542         Reviewed by David Levin.
3543
3544         Fix strict OwnPtr violations and whitelist known-tricky files
3545         https://bugs.webkit.org/show_bug.cgi?id=59421
3546
3547         With this patch, WebCore builds cleanly with strict OwnPtrs.
3548
3549         * dom/MessagePort.cpp:
3550         (WebCore::MessagePort::MessagePort):
3551         * dom/XMLDocumentParserLibxml2.cpp:
3552         * page/ContextMenuController.cpp:
3553         (WebCore::ContextMenuController::ContextMenuController):
3554         (WebCore::ContextMenuController::clearContextMenu):
3555         * page/PluginHalter.cpp:
3556         * platform/graphics/MediaPlayer.cpp:
3557         * platform/network/ResourceRequestBase.cpp:
3558         (WebCore::ResourceRequestBase::adopt):
3559         (WebCore::ResourceRequestBase::copyData):
3560         * svg/SVGDocumentExtensions.cpp:
3561
3562 2011-04-25  David Levin  <levin@chromium.org>
3563
3564         Reviewed by Adam Barth.
3565
3566         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
3567         https://bugs.webkit.org/show_bug.cgi?id=59419
3568
3569         * dom/DatasetDOMStringMap.h:
3570         (WebCore::DatasetDOMStringMap::create):
3571
3572 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3573
3574         Reviewed by Eric Seidel.
3575
3576         KeyboardEvent.cpp should work with strict OwnPtrs.
3577         https://bugs.webkit.org/show_bug.cgi?id=59403
3578
3579         * dom/KeyboardEvent.cpp:
3580         (WebCore::KeyboardEvent::KeyboardEvent):
3581
3582 2011-04-25  James Robinson  <jamesr@chromium.org>
3583
3584         Reviewed by Eric Seidel.
3585
3586         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3587         https://bugs.webkit.org/show_bug.cgi?id=59377
3588
3589         * css/CSSStyleSelector.cpp:
3590         (WebCore::CSSStyleSelector::applyProperty):
3591         * page/animation/AnimationBase.cpp:
3592         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3593         (WebCore::PropertyWrapperShadow::blend):
3594         * rendering/style/RenderStyle.cpp:
3595         (WebCore::RenderStyle::setTextShadow):
3596         (WebCore::RenderStyle::setBoxShadow):
3597         * rendering/style/RenderStyle.h:
3598         (WebCore::InheritedFlags::textShadow):
3599         * rendering/style/StyleRareInheritedData.cpp:
3600         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3601         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3602         * rendering/style/StyleRareInheritedData.h:
3603         * rendering/style/StyleRareNonInheritedData.cpp:
3604         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3605
3606 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3607
3608         Unreviewed, rolling out r84864.
3609         http://trac.webkit.org/changeset/84864
3610         https://bugs.webkit.org/show_bug.cgi?id=59413
3611
3612         Expect result of use-crash-in-non-wellformed-document.svg is
3613         platform dependent (Requested by leoyang on #webkit).
3614
3615         * svg/SVGUseElement.cpp:
3616         (WebCore::SVGUseElement::insertedIntoDocument):
3617
3618 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
3619
3620         Reviewed by Nikolas Zimmermann.
3621
3622         ASSERT failure in SVGUseElement
3623         https://bugs.webkit.org/show_bug.cgi?id=59313
3624
3625         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3626         was wrong because the document may not be well-formed.
3627
3628         This patch asserts the element is not pending on resource or the
3629         document is not well-formed.
3630
3631         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3632
3633         * svg/SVGUseElement.cpp:
3634         (WebCore::isWellFormedDocument):
3635         (WebCore::SVGUseElement::insertedIntoDocument):
3636
3637 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3638
3639         Reviewed by Tony Chang.
3640
3641         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3642         https://bugs.webkit.org/show_bug.cgi?id=59028
3643
3644         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3645         Moving the code for base class we can reduce the efforts to support DataTransferItems
3646         element in different platforms.
3647
3648         * Android.mk:
3649         * CMakeLists.txt:
3650         * GNUmakefile.list.am:
3651         * WebCore.gypi:
3652         * WebCore.pro:
3653         * WebCore.vcproj/WebCore.vcproj:
3654         * WebCore.xcodeproj/project.pbxproj:
3655         * dom/DataTransferItem.cpp:
3656         (WebCore::DataTransferItem::DataTransferItem):
3657         (WebCore::DataTransferItem::owner):
3658         (WebCore::DataTransferItem::kind):
3659         (WebCore::DataTransferItem::type):
3660         * dom/DataTransferItem.h:
3661         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3662         (WebCore::DataTransferItems::DataTransferItems):
3663         (WebCore::DataTransferItems::length):
3664         (WebCore::DataTransferItems::item):
3665         (WebCore::DataTransferItems::deleteItem):
3666         (WebCore::DataTransferItems::clear):
3667         (WebCore::DataTransferItems::add):
3668         * dom/DataTransferItems.h:
3669         * platform/chromium/DataTransferItemChromium.cpp:
3670         (WebCore::DataTransferItem::create):
3671         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3672         (WebCore::DataTransferItemChromium::getAsString):
3673         (WebCore::DataTransferItemChromium::getAsFile):
3674         * platform/chromium/DataTransferItemChromium.h:
3675         * platform/chromium/DataTransferItemsChromium.cpp:
3676         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3677         * platform/chromium/DataTransferItemsChromium.h:
3678
3679 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3680
3681         Reviewed by Simon Fraser.
3682
3683         REGRESSION(75137): directly composited images are double-drawn sometimes
3684         https://bugs.webkit.org/show_bug.cgi?id=58632
3685
3686         Depending on the order of operations (layout, creating compositing 
3687         layers and creating simple image layers) a layer can have both image
3688         content and have m_drawsContent=true. In this case 2 copies of the image
3689         are drawn in the layer. If the image has alpha, it looks wrong.
3690
3691         I added an updateDrawsContent() call after setting the image contents
3692         to make sure it's correct.
3693
3694         I couldn't create a test case that shows the problem because layerTreeAsText()
3695         doesn't emit enough info to show this level of detail. I've opened
3696         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3697
3698         * rendering/RenderLayerBacking.cpp:
3699         (WebCore::RenderLayerBacking::updateImageContents):
3700
3701 2011-04-25  Kenneth Russell  <kbr@google.com>
3702
3703         Reviewed by David Levin.
3704
3705         Fix OwnPtr strict errors in InlineFlowBox.cpp
3706         https://bugs.webkit.org/show_bug.cgi?id=59392
3707
3708         * rendering/InlineFlowBox.cpp:
3709         (WebCore::InlineFlowBox::setLayoutOverflow):
3710         (WebCore::InlineFlowBox::setVisualOverflow):
3711
3712 2011-04-25  Kenneth Russell  <kbr@google.com>
3713
3714         Reviewed by David Levin.
3715
3716         Fix OwnPtr strict errors in TransformState.cpp
3717         https://bugs.webkit.org/show_bug.cgi?id=59380
3718
3719         * rendering/TransformState.cpp:
3720         (WebCore::TransformState::applyTransform):
3721
3722 2011-04-25  Adam Barth  <abarth@webkit.org>
3723
3724         Reviewed by James Robinson.
3725
3726         DOMWindow.cpp should work with strict OwnPtrs
3727         https://bugs.webkit.org/show_bug.cgi?id=59356
3728
3729         * page/DOMWindow.cpp:
3730         (WebCore::PostMessageTimer::fired):
3731         (WebCore::DOMWindow::postMessageTimerFired):
3732         * page/DOMWindow.h:
3733
3734 2011-04-25  Adam Klein  <adamk@chromium.org>
3735
3736         Reviewed by James Robinson.
3737
3738         Fix OwnPtr strict errors in some SVG classes.
3739         https://bugs.webkit.org/show_bug.cgi?id=59395
3740
3741         * rendering/style/SVGRenderStyleDefs.cpp:
3742         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3743         * svg/SVGSVGElement.cpp:
3744         (WebCore::SVGSVGElement::SVGSVGElement):
3745         * svg/SVGStyledTransformableElement.cpp:
3746         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3747         * svg/SVGTextElement.cpp:
3748         (WebCore::SVGTextElement::supplementalTransform):
3749         * svg/graphics/SVGImage.cpp:
3750         (WebCore::SVGImage::dataChanged):
3751
3752 2011-04-25  Adam Barth  <abarth@webkit.org>
3753
3754         Re-land changes to ValidationMessage.
3755
3756         * html/ValidationMessage.cpp:
3757         (WebCore::ValidationMessage::setMessage):
3758         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3759         (WebCore::ValidationMessage::requestToHideMessage):
3760
3761 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3762
3763         Reviewed by James Robinson.
3764
3765         fix OwnPtr strict error in FrameView.cpp
3766         https://bugs.webkit.org/show_bug.cgi?id=59402
3767
3768         * page/FrameView.cpp:
3769         (WebCore::FrameView::FrameView):
3770         (WebCore::FrameView::addWidgetToUpdate):
3771
3772 2011-04-25  Adam Klein  <adamk@chromium.org>
3773
3774         Unreviewed, rolling out r84844.
3775         http://trac.webkit.org/changeset/84844
3776         https://bugs.webkit.org/show_bug.cgi?id=59395
3777
3778         Checked in too much.
3779
3780         * rendering/style/SVGRenderStyleDefs.cpp:
3781         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3782         * svg/SVGDocumentExtensions.cpp:
3783         (WebCore::SVGDocumentExtensions::removePendingResource):
3784         * svg/SVGSVGElement.cpp:
3785         (WebCore::SVGSVGElement::SVGSVGElement):
3786         * svg/SVGStyledTransformableElement.cpp:
3787         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3788         * svg/SVGTextElement.cpp:
3789         (WebCore::SVGTextElement::supplementalTransform):
3790         * svg/graphics/SVGImage.cpp:
3791         (WebCore::SVGImage::dataChanged):
3792
3793 2011-04-25  Adrienne Walker  <enne@google.com>
3794
3795         Reviewed by David Levin.
3796
3797         Make ActiveDOMCallback play nice with OwnPtr strict mode
3798         https://bugs.webkit.org/show_bug.cgi?id=59398
3799
3800         * bindings/generic/ActiveDOMCallback.cpp:
3801         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
3802
3803 2011-04-25  Adam Klein  <adamk@chromium.org>
3804
3805         Reviewed by James Robinson.
3806
3807         Fix OwnPtr strict errors in some SVG classes.
3808         https://bugs.webkit.org/show_bug.cgi?id=59395
3809
3810         * rendering/style/SVGRenderStyleDefs.cpp:
3811         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3812         * svg/SVGSVGElement.cpp:
3813         (WebCore::SVGSVGElement::SVGSVGElement):
3814         * svg/SVGStyledTransformableElement.cpp:
3815         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3816         * svg/SVGTextElement.cpp:
3817         (WebCore::SVGTextElement::supplementalTransform):
3818         * svg/graphics/SVGImage.cpp:
3819         (WebCore::SVGImage::dataChanged):
3820
3821 2011-04-25  James Robinson  <jamesr@chromium.org>
3822
3823         Unreviewed, rolling out r84835.
3824         http://trac.webkit.org/changeset/84835
3825         https://bugs.webkit.org/show_bug.cgi?id=59394
3826
3827         Breaks compile because Deque<OwnPtr> doesn't work
3828
3829         * dom/XMLDocumentParserLibxml2.cpp:
3830         (WebCore::PendingCallbacks::~PendingCallbacks):
3831         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3832         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3833         (WebCore::PendingCallbacks::appendCharactersCallback):
3834         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3835         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3836         (WebCore::PendingCallbacks::appendCommentCallback):
3837         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3838         (WebCore::PendingCallbacks::appendErrorCallback):
3839         (WebCore::XMLDocumentParser::XMLDocumentParser):
3840         * html/ValidationMessage.cpp:
3841         (WebCore::ValidationMessage::setMessage):
3842         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3843         (WebCore::ValidationMessage::requestToHideMessage):
3844
3845 2011-04-25  James Robinson  <jamesr@chromium.org>
3846
3847         Reviewed by Sam Weinig.
3848
3849         Fix OwnPtr strict mode violation in ImageBufferCG
3850         https://bugs.webkit.org/show_bug.cgi?id=59396
3851
3852         * platform/graphics/cg/ImageBufferCG.cpp:
3853         (WebCore::ImageBuffer::ImageBuffer):
3854
3855 2011-04-25  Huang Dongsung  <luxtella@company100.net>
3856
3857         Reviewed by Dirk Schulze.
3858
3859         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
3860         https://bugs.webkit.org/show_bug.cgi?id=59308
3861
3862         An unused local variable is created and even allocates heap memory.
3863
3864         * platform/graphics/skia/PlatformContextSkia.cpp:
3865         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
3866
3867 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3868
3869         Qt build fix: Updated files not used by other ports for rename.
3870
3871         * bindings/js/JSTouchCustom.cpp:
3872         (WebCore::toJSNewlyCreated):
3873         * bindings/js/JSTouchListCustom.cpp:
3874         (WebCore::toJSNewlyCreated):
3875
3876 2011-04-25  Adrienne Walker  <enne@google.com>
3877
3878         Reviewed by David Levin.
3879
3880         WebCore/css/CSS* files should play nice with strict OwnPtrs
3881         https://bugs.webkit.org/show_bug.cgi?id=59382
3882
3883         * css/CSSFontFaceSource.cpp:
3884         (WebCore::CSSFontFaceSource::getFontData):
3885         * css/CSSParser.cpp:
3886         (WebCore::CSSParser::addProperty):
3887         (WebCore::CSSParser::parseValue):
3888
3889 2011-04-25  Adam Barth  <abarth@webkit.org>
3890
3891         Reviewed by James Robinson.
3892
3893         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
3894         https://bugs.webkit.org/show_bug.cgi?id=59394
3895
3896         * dom/XMLDocumentParserLibxml2.cpp:
3897         (WebCore::PendingCallbacks::PendingCallbacks):
3898         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3899         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3900         (WebCore::PendingCallbacks::appendCharactersCallback):
3901         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3902         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3903         (WebCore::PendingCallbacks::appendCommentCallback):
3904         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3905         (WebCore::PendingCallbacks::appendErrorCallback):
3906         (WebCore::XMLDocumentParser::XMLDocumentParser):
3907         * html/ValidationMessage.cpp:
3908         (WebCore::ValidationMessage::setMessage):
3909         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3910         (WebCore::ValidationMessage::requestToHideMessage):
3911
3912 2011-04-25  James Robinson  <jamesr@chromium.org>
3913
3914         Reviewed by Adam Barth.
3915
3916         Fix OwnPtr strictness issues in WebCore/inspector/
3917         https://bugs.webkit.org/show_bug.cgi?id=59387
3918
3919         * inspector/InspectorAgent.cpp:
3920         (WebCore::InspectorAgent::InspectorAgent):
3921         * inspector/InspectorController.cpp:
3922         (WebCore::InspectorController::InspectorController):
3923         * inspector/InspectorStyleSheet.cpp:
3924         (WebCore::InspectorStyleSheet::ensureSourceData):
3925
3926 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3927
3928         Reviewed by Beth Dakin.
3929
3930         Removed XPathNamespace because it was unused
3931         https://bugs.webkit.org/show_bug.cgi?id=59381
3932         
3933         This allows us to make Node::ownerDocument() non-virtual, though it has
3934         the unhappy side-effect of rebuilding the world.
3935
3936         * CMakeLists.txt:
3937         * GNUmakefile.list.am:
3938         * WebCore.gypi:
3939         * WebCore.pro:
3940         * WebCore.vcproj/WebCore.vcproj:
3941         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
3942
3943         * dom/Node.h: Hello fast code!
3944
3945         * xml/XPathNamespace.cpp: Removed.
3946         * xml/XPathNamespace.h: Removed.
3947
3948 2011-04-25  Adam Barth  <abarth@webkit.org>
3949
3950         Reviewed by Darin Adler.
3951
3952         HistoryItemMac should play nice with OwnPtrs
3953         https://bugs.webkit.org/show_bug.cgi?id=59388
3954
3955         * history/mac/HistoryItemMac.mm:
3956         (WebCore::HistoryItem::setTransientProperty):
3957
3958 2011-04-25  David Levin  <levin@chromium.org>
3959
3960         Reviewed by Kenneth Russell.
3961
3962         Fix strict OwnPtrs in ContextMenuController.cpp
3963         https://bugs.webkit.org/show_bug.cgi?id=59375
3964
3965         * page/ContextMenuController.cpp:
3966         (WebCore::ContextMenuController::createContextMenu):
3967         (WebCore::separatorItem):
3968
3969 2011-04-25  Adam Barth  <abarth@webkit.org>
3970
3971         Reviewed by Darin Adler.
3972
3973         CheckedRadioButton should play nice with strict OwnPtr
3974         https://bugs.webkit.org/show_bug.cgi?id=59386
3975
3976         * dom/CheckedRadioButtons.cpp:
3977         (WebCore::CheckedRadioButtons::addButton):
3978
3979 2011-04-25  Adam Barth  <abarth@webkit.org>
3980
3981         Reviewed by David Levin.
3982
3983         Resource*.cpp should play nice with strict OwnPtrs
3984         https://bugs.webkit.org/show_bug.cgi?id=59383
3985
3986         * bridge/runtime_method.cpp:
3987         (JSC::RuntimeMethod::RuntimeMethod):
3988         * platform/network/ResourceHandle.cpp:
3989         (WebCore::ResourceHandle::ResourceHandle):
3990         * platform/network/ResourceResponseBase.cpp:
3991         (WebCore::ResourceResponseBase::adopt):
3992         (WebCore::ResourceResponseBase::copyData):
3993
3994 2011-04-25  Adam Barth  <abarth@webkit.org>
3995
3996         Reviewed by David Levin.
3997
3998         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
3999         https://bugs.webkit.org/show_bug.cgi?id=59374
4000
4001         * bridge/objc/objc_runtime.mm:
4002         (JSC::Bindings::callObjCFallbackObject):
4003         * page/Page.cpp:
4004         (WebCore::Page::Page):
4005         (WebCore::Page::initGroup):
4006         * page/PageGroup.cpp:
4007         (WebCore::PageGroup::addUserScriptToWorld):
4008         (WebCore::PageGroup::addUserStyleSheetToWorld):
4009         * page/mac/PageMac.cpp:
4010         (WebCore::Page::addSchedulePair):
4011
4012 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4013
4014         Build fix: This time for sure!
4015         
4016         * dom/make_names.pl:
4017
4018 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4019
4020         Build fix: Let's edit the script instead of the autogenrated file. That
4021         way, our change will stand the test of time.
4022
4023         * dom/make_names.pl:
4024
4025 2011-04-25  Adam Barth  <abarth@webkit.org>
4026
4027         Reviewed by David Levin.
4028
4029         Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
4030         https://bugs.webkit.org/show_bug.cgi?id=59368
4031
4032         * html/HTMLMediaElement.cpp:
4033         (WebCore::HTMLMediaElement::HTMLMediaElement):
4034         * platform/network/HTTPHeaderMap.cpp:
4035         (WebCore::HTTPHeaderMap::copyData):
4036
4037 2011-04-25  James Robinson  <jamesr@chromium.org>
4038
4039         Reviewed by Adam Barth.
4040
4041         Fix strict OwnPtr violations in Render*.cpp
4042         https://bugs.webkit.org/show_bug.cgi?id=59361
4043
4044         * rendering/RenderBlock.cpp:
4045         (WebCore::RenderBlock::RenderBlock):
4046         (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
4047         * rendering/RenderBox.cpp:
4048         (WebCore::RenderBox::addLayoutOverflow):
4049         (WebCore::RenderBox::addVisualOverflow):
4050         * rendering/RenderButton.cpp:
4051         (WebCore::RenderButton::styleDidChange):
4052         * rendering/RenderLayer.cpp:
4053         (WebCore::RenderLayer::updateTransform):
4054         (WebCore::RenderLayer::paintChildLayerIntoColumns):
4055         (WebCore::RenderLayer::hitTestChildLayerColumns):
4056         (WebCore::RenderLayer::ensureBacking):
4057         * rendering/RenderTable.cpp:
4058         (WebCore::RenderTable::styleDidChange):
4059         * rendering/RenderView.cpp:
4060         (WebCore::RenderView::compositor):
4061         * rendering/style/RenderStyle.cpp:
4062         (WebCore::RenderStyle::addCachedPseudoStyle):
4063         (WebCore::RenderStyle::accessCounterDirectives):
4064         (WebCore::RenderStyle::accessAnimations):
4065         (WebCore::RenderStyle::accessTransitions):
4066         * rendering/svg/RenderSVGResourceFilter.cpp:
4067         (WebCore::RenderSVGResourceFilter::applyResource):
4068         * rendering/svg/SVGResources.cpp:
4069         (WebCore::SVGResources::SVGResources):
4070
4071 2011-04-25  Adam Barth  <abarth@webkit.org>
4072
4073         Attempt to fix the compile.
4074
4075         * platform/graphics/MediaPlayer.cpp:
4076         (WebCore::MediaPlayer::loadWithNextMediaEngine):
4077
4078 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4079
4080         Rubber-stamped by Beth Dakin.
4081
4082         Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into 
4083         CREATE_DOM_WRAPPER because there's no meaningful difference between
4084         them anymore.
4085
4086         * bindings/js/JSCDATASectionCustom.cpp:
4087         (WebCore::toJSNewlyCreated):
4088         * bindings/js/JSCSSRuleCustom.cpp:
4089         (WebCore::toJS):
4090         * bindings/js/JSCSSValueCustom.cpp:
4091         (WebCore::toJS):
4092         * bindings/js/JSDOMBinding.h:
4093         * bindings/js/JSDocumentCustom.cpp:
4094         (WebCore::toJS):
4095         * bindings/js/JSElementCustom.cpp:
4096         (WebCore::toJSNewlyCreated):
4097         * bindings/js/JSEventCustom.cpp:
4098         (WebCore::toJS):
4099         * bindings/js/JSHTMLCollectionCustom.cpp:
4100         (WebCore::toJS):
4101         * bindings/js/JSImageDataCustom.cpp:
4102         (WebCore::toJS):
4103         * bindings/js/JSNodeCustom.cpp:
4104         (WebCore::createWrapperInline):
4105         * bindings/js/JSSVGPathSegCustom.cpp:
4106         (WebCore::toJS):
4107         * bindings/js/JSStyleSheetCustom.cpp:
4108         (WebCore::toJS):
4109         * bindings/js/JSTextCustom.cpp: