2011-04-28 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-28  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Remove WML
6         https://bugs.webkit.org/show_bug.cgi?id=59678
7
8         This patch removes WML from WebCore.  After removing WML, there's a
9         bunch of twisted code that could be untwisted, but this patch contains
10         only the purely mechanical part of removing the feature.
11
12         There's been a lot of discussion on webkit-dev about whether we should
13         remove WML.  In addition to those threads, we've had an informal poll
14         of the reviewers as well as an in-person discussion at the WebKit
15         contributor's meeting.  Removing any feature is likely to make some
16         folks unhappy, but, on balance, removing WML appears to be the right
17         thing for the project to do at this time.
18
19         * CMakeLists.txt:
20         * CodeGenerators.pri:
21         * Configurations/FeatureDefines.xcconfig:
22         * DerivedSources.cpp:
23         * DerivedSources.make:
24         * GNUmakefile.am:
25         * GNUmakefile.list.am:
26         * WebCore.gyp/WebCore.gyp:
27         * WebCore.gypi:
28         * WebCore.pro:
29         * WebCore.vcproj/WebCore.vcproj:
30         * WebCore.xcodeproj/project.pbxproj:
31         * css/CSSStyleSelector.cpp:
32         (WebCore::linkAttribute):
33         (WebCore::CSSStyleSelector::styleForElement):
34         (WebCore::CSSStyleSelector::adjustRenderStyle):
35         * css/wml.css: Removed.
36         * dom/DOMImplementation.cpp:
37         (WebCore::DOMImplementation::createDocument):
38         * dom/Document.cpp:
39         (WebCore::Document::Document):
40         (WebCore::Document::createElement):
41         * dom/Document.h:
42         (WebCore::Document::isMediaDocument):
43         * dom/Document.idl:
44         * dom/InputElement.h:
45         * dom/Node.cpp:
46         (WebCore::Node::toInputElement):
47         * dom/Node.h:
48         * dom/OptionElement.cpp:
49         (WebCore::toOptionElement):
50         (WebCore::isOptionElement):
51         * dom/OptionElement.h:
52         * dom/OptionGroupElement.cpp:
53         (WebCore::toOptionGroupElement):
54         (WebCore::isOptionGroupElement):
55         * dom/SelectElement.cpp:
56         (WebCore::toSelectElement):
57         * dom/SelectElement.h:
58         * dom/Text.cpp:
59         (WebCore::Text::attach):
60         * dom/XMLDocumentParser.cpp:
61         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
62         * dom/XMLDocumentParser.h:
63         * dom/XMLDocumentParserLibxml2.cpp:
64         (WebCore::XMLDocumentParser::internalSubset):
65         (WebCore::getEntityHandler):
66         * dom/XMLDocumentParserQt.cpp:
67         (WebCore::XMLDocumentParser::parse):
68         (WebCore::XMLDocumentParser::parseDtd):
69         * editing/htmlediting.cpp:
70         (WebCore::canHaveChildrenForEditing):
71         * features.pri:
72         * history/BackForwardList.h:
73         * history/BackForwardListImpl.cpp:
74         * history/BackForwardListImpl.h:
75         * history/PageCache.cpp:
76         (WebCore::PageCache::canCachePageContainingThisFrame):
77         * html/HTMLAnchorElement.h:
78         * inspector/ConsoleMessage.cpp:
79         (WebCore::messageSourceValue):
80         * inspector/front-end/ConsoleView.js:
81         (WebInspector.ConsoleMessage.prototype.toString):
82         * loader/FrameLoader.cpp:
83         (WebCore::isBackForwardLoadType):
84         (WebCore::FrameLoader::transitionToCommitted):
85         (WebCore::FrameLoader::shouldReload):
86         (WebCore::FrameLoader::loadDifferentDocumentItem):
87         (WebCore::FrameLoader::loadItem):
88         * loader/FrameLoaderTypes.h:
89         * loader/HistoryController.cpp:
90         (WebCore::HistoryController::restoreDocumentState):
91         * manual-tests/wml: Removed.
92         * manual-tests/wml/StartTests.wml: Removed.
93         * manual-tests/wml/a-br-element.wml: Removed.
94         * manual-tests/wml/a-element.wml: Removed.
95         * manual-tests/wml/a-img-element.wml: Removed.
96         * manual-tests/wml/access-target.wml: Removed.
97         * manual-tests/wml/anchor-br-element.wml: Removed.
98         * manual-tests/wml/anchor-element.wml: Removed.
99         * manual-tests/wml/anchor-img-element.wml: Removed.
100         * manual-tests/wml/card-newcontext-attr.wml: Removed.
101         * manual-tests/wml/card-onenterbackward.wml: Removed.
102         * manual-tests/wml/card-onenterforward.wml: Removed.
103         * manual-tests/wml/card-ontimer.wml: Removed.
104         * manual-tests/wml/deck-access-control.wml: Removed.
105         * manual-tests/wml/input-format.wml: Removed.
106         * manual-tests/wml/onevent-go.wml: Removed.
107         * manual-tests/wml/onevent-noop.wml: Removed.
108         * manual-tests/wml/onevent-prev.wml: Removed.
109         * manual-tests/wml/onevent-refresh.wml: Removed.
110         * manual-tests/wml/onevent-shadow.wml: Removed.
111         * manual-tests/wml/resources: Removed.
112         * manual-tests/wml/resources/smiley.png: Removed.
113         * manual-tests/wml/select-element.wml: Removed.
114         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
115         * manual-tests/wml/select-onpick-event.wml: Removed.
116         * manual-tests/wml/setvar-element.wml: Removed.
117         * manual-tests/wml/targetdeck.wml: Removed.
118         * manual-tests/wml/task-go-in-anchor.wml: Removed.
119         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
120         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
121         * manual-tests/wml/template-go.wml: Removed.
122         * manual-tests/wml/template-ontimer.wml: Removed.
123         * manual-tests/wml/timer.wml: Removed.
124         * manual-tests/wml/variable-substitution.wml: Removed.
125         * page/Console.cpp:
126         (WebCore::printMessageSourceAndLevelPrefix):
127         * page/Console.h:
128         * page/Frame.cpp:
129         (WebCore::Frame::Frame):
130         * page/Page.cpp:
131         * page/Page.h:
132         * platform/MIMETypeRegistry.cpp:
133         (WebCore::initializeSupportedNonImageMimeTypes):
134         * platform/network/FormDataBuilder.h:
135         * platform/network/mac/ResourceHandleMac.mm:
136         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
137         * platform/wince/MIMETypeRegistryWinCE.cpp:
138         (WebCore::initMIMETypeEntensionMap):
139         * rendering/HitTestResult.cpp:
140         (WebCore::HitTestResult::altDisplayString):
141         (WebCore::HitTestResult::absoluteImageURL):
142         (WebCore::HitTestResult::absoluteLinkURL):
143         (WebCore::HitTestResult::isLiveLink):
144         * rendering/RenderBox.cpp:
145         * rendering/RenderButton.cpp:
146         (WebCore::RenderButton::updateFromElement):
147         * rendering/RenderFieldset.cpp:
148         (WebCore::RenderFieldset::findLegend):
149         * rendering/RenderImage.cpp:
150         (WebCore::RenderImage::updateAltText):
151         * rendering/RenderObject.cpp:
152         (WebCore::RenderObject::isLegend):
153         (WebCore::RenderObject::offsetParent):
154         * wml: Removed.
155         * wml/WMLAElement.cpp: Removed.
156         * wml/WMLAElement.h: Removed.
157         * wml/WMLAccessElement.cpp: Removed.
158         * wml/WMLAccessElement.h: Removed.
159         * wml/WMLAnchorElement.cpp: Removed.
160         * wml/WMLAnchorElement.h: Removed.
161         * wml/WMLAttributeNames.in: Removed.
162         * wml/WMLBRElement.cpp: Removed.
163         * wml/WMLBRElement.h: Removed.
164         * wml/WMLCardElement.cpp: Removed.
165         * wml/WMLCardElement.h: Removed.
166         * wml/WMLDoElement.cpp: Removed.
167         * wml/WMLDoElement.h: Removed.
168         * wml/WMLDocument.cpp: Removed.
169         * wml/WMLDocument.h: Removed.
170         * wml/WMLElement.cpp: Removed.
171         * wml/WMLElement.h: Removed.
172         * wml/WMLErrorHandling.cpp: Removed.
173         * wml/WMLErrorHandling.h: Removed.
174         * wml/WMLEventHandlingElement.cpp: Removed.
175         * wml/WMLEventHandlingElement.h: Removed.
176         * wml/WMLFieldSetElement.cpp: Removed.
177         * wml/WMLFieldSetElement.h: Removed.
178         * wml/WMLFormControlElement.cpp: Removed.
179         * wml/WMLFormControlElement.h: Removed.
180         * wml/WMLGoElement.cpp: Removed.
181         * wml/WMLGoElement.h: Removed.
182         * wml/WMLImageElement.cpp: Removed.
183         * wml/WMLImageElement.h: Removed.
184         * wml/WMLImageLoader.cpp: Removed.
185         * wml/WMLImageLoader.h: Removed.
186         * wml/WMLInputElement.cpp: Removed.
187         * wml/WMLInputElement.h: Removed.
188         * wml/WMLInsertedLegendElement.cpp: Removed.
189         * wml/WMLInsertedLegendElement.h: Removed.
190         * wml/WMLIntrinsicEvent.cpp: Removed.
191         * wml/WMLIntrinsicEvent.h: Removed.
192         * wml/WMLIntrinsicEventHandler.cpp: Removed.
193         * wml/WMLIntrinsicEventHandler.h: Removed.
194         * wml/WMLMetaElement.cpp: Removed.
195         * wml/WMLMetaElement.h: Removed.
196         * wml/WMLNoopElement.cpp: Removed.
197         * wml/WMLNoopElement.h: Removed.
198         * wml/WMLOnEventElement.cpp: Removed.
199         * wml/WMLOnEventElement.h: Removed.
200         * wml/WMLOptGroupElement.cpp: Removed.
201         * wml/WMLOptGroupElement.h: Removed.
202         * wml/WMLOptionElement.cpp: Removed.
203         * wml/WMLOptionElement.h: Removed.
204         * wml/WMLPElement.cpp: Removed.
205         * wml/WMLPElement.h: Removed.
206         * wml/WMLPageState.cpp: Removed.
207         * wml/WMLPageState.h: Removed.
208         * wml/WMLPostfieldElement.cpp: Removed.
209         * wml/WMLPostfieldElement.h: Removed.
210         * wml/WMLPrevElement.cpp: Removed.
211         * wml/WMLPrevElement.h: Removed.
212         * wml/WMLRefreshElement.cpp: Removed.
213         * wml/WMLRefreshElement.h: Removed.
214         * wml/WMLSelectElement.cpp: Removed.
215         * wml/WMLSelectElement.h: Removed.
216         * wml/WMLSetvarElement.cpp: Removed.
217         * wml/WMLSetvarElement.h: Removed.
218         * wml/WMLTableElement.cpp: Removed.
219         * wml/WMLTableElement.h: Removed.
220         * wml/WMLTagNames.in: Removed.
221         * wml/WMLTaskElement.cpp: Removed.
222         * wml/WMLTaskElement.h: Removed.
223         * wml/WMLTemplateElement.cpp: Removed.
224         * wml/WMLTemplateElement.h: Removed.
225         * wml/WMLTimerElement.cpp: Removed.
226         * wml/WMLTimerElement.h: Removed.
227         * wml/WMLVariables.cpp: Removed.
228         * wml/WMLVariables.h: Removed.
229
230 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
231
232         Unreviewed, rolling out r85233 and r85235.
233         http://trac.webkit.org/changeset/85233
234         http://trac.webkit.org/changeset/85235
235         https://bugs.webkit.org/show_bug.cgi?id=59754
236
237         Causes issues with jsc. (Requested by dave_levin on #webkit).
238
239         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
240         * loader/icon/IconDatabase.cpp:
241         (WebCore::IconDatabase::defaultIcon):
242         (WebCore::IconDatabase::setIconDataForIconURL):
243         (WebCore::IconDatabase::getOrCreateIconRecord):
244         (WebCore::IconDatabase::readFromDatabase):
245
246 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
247
248         Reviewed by Adam Barth.
249
250         Introducing a new class that allows serialization of a page back
251         to HTML/XML with all its sub-frames and also retrieves the page's
252         resources.
253         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
254         https://bugs.webkit.org/show_bug.cgi?id=58947
255
256         * Android.mk:
257         * CMakeLists.txt:
258         * GNUmakefile.list.am:
259         * WebCore.gypi:
260         * WebCore.pro:
261         * WebCore.vcproj/WebCore.vcproj:
262         * dom/Document.cpp:
263         (WebCore::Document::suggestedMIMEType):
264         * dom/Document.h:
265         * editing/MarkupAccumulator.cpp:
266         (WebCore::MarkupAccumulator::appendCustomAttributes):
267         (WebCore::MarkupAccumulator::appendElement):
268         * editing/MarkupAccumulator.h:
269         * html/parser/HTMLMetaCharsetParser.cpp:
270         (WebCore::HTMLMetaCharsetParser::processMeta):
271         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
272         * html/parser/HTMLMetaCharsetParser.h:
273         * page/PageSerializer.cpp: Added.
274         * page/PageSerializer.h: Added.
275
276 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
277
278         Reviewed by Tony Chang.
279
280         IndexedDB createIndex should fail if name arg is null
281         https://bugs.webkit.org/show_bug.cgi?id=58365
282
283         Test: storage/indexeddb/mozilla/create-index-null-name.html
284
285         * storage/IDBObjectStore.idl:
286         * storage/IDBObjectStoreBackendImpl.cpp:
287         (WebCore::IDBObjectStoreBackendImpl::createIndex):
288
289 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
290
291         Reviewed by Tony Chang.
292
293         IndexedDB put() should fail if second (key) parameter is null
294         https://bugs.webkit.org/show_bug.cgi?id=58613
295
296         If key arg is not specified, prpKey ends up as a null pointer in ::put().
297         However, if the key arg is specified but is null, prpKey ends up as a
298         valid IDBKey which has a null key type. As it happens, we need to be able
299         to detect the difference between these cases (the key arg is optional but
300         if specified must not be null).
301
302         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
303
304         * storage/IDBObjectStoreBackendImpl.cpp:
305         (WebCore::IDBObjectStoreBackendImpl::put):
306
307 2011-04-07  David Levin  <levin@chromium.org>
308
309         Reviewed by Darin Adler.
310
311         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
312         https://bugs.webkit.org/show_bug.cgi?id=31639
313
314         No new functionality exposed so no new tests. (The change is basically adding
315         more testing.)
316
317         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
318         * loader/icon/IconDatabase.cpp:
319         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
320         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
321         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
322         (WebCore::IconDatabase::readFromDatabase): Ditto.
323
324 2011-04-28  Kenneth Russell  <kbr@google.com>
325
326         Unreviewed build fix for Web Audio with strict OwnPtr.
327
328         * platform/audio/HRTFDatabaseLoader.cpp:
329         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
330
331 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
332
333         Reviewed by Geoffrey Garen.
334
335         Walk shadow hosts as well as parent nodes when finding opaque roots.
336         https://bugs.webkit.org/show_bug.cgi?id=59571
337
338         Test: fast/dom/shadow/gc-shadow.html
339
340         * bindings/js/JSDOMBinding.h:
341         (WebCore::root):
342
343 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
344
345         Reviewed by Xan Lopez.
346
347         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
348         https://bugs.webkit.org/show_bug.cgi?id=59715
349
350         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
351         into WebCore so that WebKit1 and WebKit2 can share the code.
352
353         No new tests. This is covered by fast/events/click-count.html.
354
355         * GNUmakefile.list.am: Added new files.
356         * platform/gtk/GtkClickCounter.cpp: Added.
357         (WebCore::GtkClickCounter::GtkClickCounter): Added.
358         (WebCore::GtkClickCounter::reset): Added.
359         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
360         (WebCore::getEventTime): Added.
361         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
362         * platform/gtk/GtkClickCounter.h: Added.
363
364 2011-04-28  Dan Bernstein  <mitz@apple.com>
365
366         Build fix.
367
368         * css/CSSParser.cpp:
369         (WebCore::cssPropertyID):
370
371 2011-04-28  Dan Bernstein  <mitz@apple.com>
372
373         Reviewed by Simon Fraser.
374
375         Allow specifying CSS property aliases in CSSPropertyNames.in files
376         https://bugs.webkit.org/show_bug.cgi?id=59712
377
378         * css/CSSParser.cpp:
379         (WebCore::cssPropertyID): Removed code to handle some aliases
380         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
381         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
382         defining an alias, and add an appropriate entry to the gperf file.
383
384 2011-04-28  Arno Renevier  <arno@renevier.net>
385
386         Reviewed by Gustavo Noronha Silva.
387
388         [Soup] does not load css stylesheets without content-type
389         https://bugs.webkit.org/show_bug.cgi?id=59697
390
391         When sniffing content type, do not replace http Content-Type header in
392         soup message anymore, but keep sniffed content type in a separate
393         variable.
394
395         * platform/network/soup/ResourceHandleSoup.cpp:
396         (WebCore::contentSniffedCallback):
397         * platform/network/soup/ResourceResponse.h:
398         (WebCore::ResourceResponse::sniffedContentType):
399         (WebCore::ResourceResponse::setSniffedContentType):
400         * platform/network/soup/ResourceResponseSoup.cpp:
401         (WebCore::ResourceResponse::updateFromSoupMessage):
402
403 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
404
405         Reviewed by Andreas Kling.
406
407         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
408         https://bugs.webkit.org/show_bug.cgi?id=59704
409
410         No new tests, just code cleanup.
411
412         * WebCore.pri:
413
414 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
415
416         Reviewed by Pavel Feldman.
417
418         Web Inspector: remove "Pretty print" source frame context menu item.
419         https://bugs.webkit.org/show_bug.cgi?id=59709
420
421         * inspector/front-end/DebuggerPresentationModel.js:
422         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
423         * inspector/front-end/ScriptsPanel.js:
424         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
425         * inspector/front-end/SourceFrame.js:
426         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
427
428 2011-04-28  Satish Sampath  <satish@chromium.org>
429
430         Reviewed by Tony Gentilcore.
431
432         Speech input button layout issues with padding and border.
433         https://bugs.webkit.org/show_bug.cgi?id=59613
434
435         * rendering/RenderTextControlSingleLine.cpp:
436         (WebCore::RenderTextControlSingleLine::layout):
437         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
438         (WebCore::RenderTextControlSingleLine::forwardEvent):
439
440 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
441
442         Reviewed by Martin Robinson.
443
444         [GTK] Check whether to use native scrollbars at run time
445         https://bugs.webkit.org/show_bug.cgi?id=59694
446
447         It's currently decided at build time depending on whether webkit2
448         build is enabled or not. That makes imposible to build both
449         webkit1 and webkit2 using the same libWebCore.
450
451         * GNUmakefile.am:
452         * platform/ScrollView.cpp:
453         (WebCore::ScrollView::wheelEvent):
454         * platform/gtk/ScrollViewGtk.cpp:
455         (WebCore::ScrollView::createScrollbar):
456
457 2011-04-28  Pavel Feldman  <pfeldman@google.com>
458
459         Reviewed by Yury Semikhatsky.
460
461         Web Inspector: add status bar button for pretty print.
462         https://bugs.webkit.org/show_bug.cgi?id=59467
463
464         * WebCore.gypi:
465         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
466         * inspector/front-end/ScriptsPanel.js:
467         (WebInspector.ScriptsPanel):
468         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
469         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
470         * inspector/front-end/WebKit.qrc:
471         * inspector/front-end/inspector.css:
472         (.scripts-toggle-pretty-print-status-bar-item .glyph):
473         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
474
475 2011-04-28  Pavel Feldman  <pfeldman@google.com>
476
477         Reviewed by Yury Semikhatsky.
478
479         Web Inspector: add ResourceTreeModel tests.
480         https://bugs.webkit.org/show_bug.cgi?id=59616
481
482         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
483                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
484                http/tests/inspector/resource-tree/resource-tree-reload.html
485
486         * inspector/front-end/ResourceTreeModel.js:
487         (WebInspector.ResourceTreeModel.prototype.frontendReused):
488         (WebInspector.ResourceTreeModel.prototype._addFrame):
489         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
490         (WebInspector.ResourceTreeModel.prototype._frameDetached):
491         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
492         (WebInspector.ResourceTreeModel.prototype.forAllResources):
493         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
494         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
495         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
496         * inspector/front-end/ResourcesPanel.js:
497         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
498         (WebInspector.ResourcesPanel.prototype._frameAdded):
499         (WebInspector.ResourcesPanel.prototype._frameDetached):
500         (WebInspector.ResourcesPanel.prototype._frameNavigated):
501         (WebInspector.FrameTreeElement):
502         (WebInspector.FrameTreeElement.prototype.frameNavigated):
503
504 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
505
506         Reviewed by Yury Semikhatsky.
507
508         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
509         https://bugs.webkit.org/show_bug.cgi?id=59592
510
511         * inspector/front-end/DetailedHeapshotGridNodes.js:
512         (WebInspector.HeapSnapshotGridNode.prototype._populate):
513         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
514         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
515         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
516         * inspector/front-end/DetailedHeapshotView.js:
517         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
518         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
519         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
520         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
521         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
522         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
523         (WebInspector.DetailedHeapshotView.prototype.changeView):
524         * inspector/front-end/HeapSnapshot.js:
525         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
526         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
527         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
528         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
529         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
530         * inspector/front-end/heapProfiler.css:
531         (div.retaining-paths-view td.path-column div:hover):
532
533 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
534
535         Reviewed by Yury Semikhatsky.
536
537         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
538         https://bugs.webkit.org/show_bug.cgi?id=59454
539
540         Test: inspector/profiler/heap-snapshot-loader.html
541
542         * inspector/front-end/HeapSnapshot.js:
543         (WebInspector.HeapSnapshotLoader):
544         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
545         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
546         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
547         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
548         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
549         * inspector/front-end/HeapSnapshotProxy.js:
550         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
551
552 2011-04-28  ojab  <ojab@ojab.ru>
553
554         Reviewed by David Levin.
555
556         Fix build with libpng-1.5.1
557         https://bugs.webkit.org/show_bug.cgi?id=59607
558
559         * platform/image-decoders/png/PNGImageDecoder.cpp:
560         (WebCore::readColorProfile):
561
562 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
563
564         Reviewed by Nikolas Zimmermann.
565
566         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
567         https://bugs.webkit.org/show_bug.cgi?id=59447
568
569         This patch contains two sub-routines, one for speeding up
570         alpha channel only gaussian blur (by 2.5 times) and one
571         for speeding up all channel blur (by 4 times).
572
573         The common code is also redesigned to better fit for platform
574         specific code. This means large chunks of code was moved to
575         different files, and all platform specific files are added to
576         all build systems.
577
578         * CMakeLists.txt:
579         * GNUmakefile.am:
580         * GNUmakefile.list.am:
581         * WebCore.gypi:
582         * WebCore.pro:
583         * WebCore.vcproj/WebCore.vcproj:
584         * WebCore.vcproj/WebCoreCommon.vsprops:
585         * WebCore.xcodeproj/project.pbxproj:
586         * platform/graphics/filters/FEGaussianBlur.cpp:
587         (WebCore::FEGaussianBlur::platformApplyGeneric):
588         (WebCore::FEGaussianBlur::apply):
589         * platform/graphics/filters/FEGaussianBlur.h:
590         (WebCore::FEGaussianBlur::kernelPosition):
591         (WebCore::FEGaussianBlur::platformApply):
592         * platform/graphics/filters/FELighting.cpp:
593         (WebCore::FELighting::platformApplyGeneric):
594         (WebCore::FELighting::drawLighting):
595         * platform/graphics/filters/FELighting.h:
596         (WebCore::FELighting::platformApply):
597         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
598         (WebCore::WTF_ALIGNED):
599         (WebCore::feGaussianBlurConstantsForNeon):
600         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
601         (WebCore::FEGaussianBlur::platformApplyNeon):
602         * platform/graphics/filters/arm/FELightingNEON.cpp:
603         (WebCore::WTF_ALIGNED):
604         (WebCore::FELighting::getPowerCoefficients):
605         * platform/graphics/filters/arm/FELightingNEON.h:
606         (WebCore::FELighting::platformApplyNeon):
607
608 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
609
610         Reviewed by Yury Semikhatsky.
611
612         Web Inspector: provide a hotkey for script pause
613         https://bugs.webkit.org/show_bug.cgi?id=59593
614
615         In fact, F8 works as a hotkey, but this fact was not reflected
616         in the shortcut help popup.
617
618         * English.lproj/localizedStrings.js:
619         * inspector/front-end/ScriptsPanel.js:
620         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
621
622 2011-04-28  Adam Barth  <abarth@webkit.org>
623
624         Reviewed by Eric Seidel.
625
626         PluginStream should play nice with strict OwnPtr
627         https://bugs.webkit.org/show_bug.cgi?id=59675
628
629         These failures appear when enabling strict OwnPtr on Qt.
630
631         * plugins/PluginStream.cpp:
632         (WebCore::PluginStream::PluginStream):
633         (WebCore::PluginStream::didReceiveData):
634
635 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
636
637         Reviewed by Pavel Feldman.
638
639         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
640         https://bugs.webkit.org/show_bug.cgi?id=59326
641
642         Concrete CachedResource successors for stylesheets and scripts
643         can decode their content better than the generic approach we use.
644
645         * inspector/InspectorPageAgent.cpp:
646         (WebCore::decodeSharedBuffer):
647         (WebCore::prepareCachedResourceBuffer):
648         (WebCore::cachedResourceDecoded):
649         (WebCore::InspectorPageAgent::resourceContent):
650         (WebCore::InspectorPageAgent::resourceData):
651         * inspector/InspectorStyleSheet.cpp:
652         (WebCore::InspectorStyleSheet::originalStyleSheetText):
653
654 2011-04-28  Jon Lee  <jonlee@apple.com>
655
656         Reviewed by Simon Fraser.
657
658         REGRESSION: white overlay scrollbars on apple.com/startpage
659         https://bugs.webkit.org/show_bug.cgi?id=59540
660         <rdar://problem/9338653>
661
662         Now we look at the document background in addition to the <body> element,
663         and blend those colors in with the base background of the frame view to
664         arrive at our aggregate color. This provides a better result to determine
665         overlay scrollbar style.
666
667         * page/Frame.cpp:
668         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
669         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
670
671 2011-04-27  Adam Barth  <abarth@webkit.org>
672
673         Reviewed by Maciej Stachowiak.
674
675         Fix OwnPtr issues in IndexedDB
676         https://bugs.webkit.org/show_bug.cgi?id=59656
677
678         This patch is an attempt to fix the clang build.  Clang can't seem to
679         cope with OwnPtrs to classes declared in an anonymous namespace because
680         OwnPtr's copy constructor isn't defined (but would need to be defined
681         in this translation unit).
682
683         * platform/leveldb/LevelDBDatabase.cpp:
684
685 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
686
687         Reviewed by Antonio Gomes.
688
689         [EFL] Change cursor to LAZY_NATIVE_CURSOR
690         https://bugs.webkit.org/show_bug.cgi?id=59411
691
692         Enable LAZY_NATIVE_CURSOR on EFL build.
693
694         No test added because functionality is unchanged.
695
696         * CMakeListsEfl.txt: Add Cursor.cpp
697         * platform/Cursor.h:
698         (WebCore::Cursor::Cursor):
699         * platform/efl/CursorEfl.cpp:
700         (WebCore::Cursor::Cursor):
701         (WebCore::Cursor::~Cursor):
702         (WebCore::getCursorString):
703         (WebCore::Cursor::ensurePlatformCursor):
704         * platform/efl/WidgetEfl.cpp:
705         (WebCore::Widget::setCursor):
706
707 2011-04-27  Adam Barth  <abarth@webkit.org>
708
709         Build fix from the future.  Another trival strict OwnPtr fixes.  This
710         is the last futuristic build fix I can detect with my time traveling
711         abilities.
712
713         * platform/graphics/chromium/TransparencyWin.cpp:
714         (WebCore::TransparencyWin::initializeNewContext):
715
716 2011-04-27  Dmitry Lomov  <dslomov@google.com>
717
718         Reviewed by David Levin.
719
720         CrossThreadCopier should not have a default specialization for raw pointers
721         https://bugs.webkit.org/show_bug.cgi?id=59234
722         Removed the ablity to pass raw pointers cross-thread
723         Added and applied annotations for doing that
724
725         * fileapi/FileReader.cpp:
726         (WebCore::FileReader::readInternal):
727         (WebCore::FileReader::abort):
728         * fileapi/FileStreamProxy.cpp:
729         (WebCore::FileStreamProxy::startOnFileThread):
730         (WebCore::FileStreamProxy::stopOnFileThread):
731         (WebCore::FileStreamProxy::getSize):
732         (WebCore::FileStreamProxy::getSizeOnFileThread):
733         (WebCore::FileStreamProxy::openForRead):
734         (WebCore::FileStreamProxy::openForReadOnFileThread):
735         (WebCore::FileStreamProxy::openForWrite):
736         (WebCore::FileStreamProxy::openForWriteOnFileThread):
737         (WebCore::FileStreamProxy::close):
738         (WebCore::FileStreamProxy::read):
739         (WebCore::FileStreamProxy::readOnFileThread):
740         (WebCore::FileStreamProxy::write):
741         (WebCore::FileStreamProxy::writeOnFileThread):
742         (WebCore::FileStreamProxy::truncate):
743         (WebCore::FileStreamProxy::truncateOnFileThread):
744         * loader/WorkerThreadableLoader.cpp:
745         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
746         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
747         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
748         * page/GeolocationPositionCache.cpp:
749         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
750         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
751         * platform/CrossThreadCopier.h:
752         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
753         (WebCore::AllowCrossThreadAccessWrapper::value):
754         (WebCore::AllowCrossThreadAccess):
755         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
756         (WebCore::AllowExtendedLifetimeWrapper::value):
757         (WebCore::AllowExtendedLifetime):
758         * platform/graphics/chromium/cc/CCCompletionEvent.h:
759         * storage/IDBObjectStoreBackendImpl.cpp:
760         (WebCore::IDBObjectStoreBackendImpl::get):
761         (WebCore::IDBObjectStoreBackendImpl::put):
762         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
763         (WebCore::IDBObjectStoreBackendImpl::clear):
764         (WebCore::IDBObjectStoreBackendImpl::createIndex):
765         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
766         (WebCore::IDBObjectStoreBackendImpl::openCursor):
767         * storage/SQLCallbackWrapper.h:
768         (WebCore::SQLCallbackWrapper::clear):
769         * websockets/WorkerThreadableWebSocketChannel.cpp:
770         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
771         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
772         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
773         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
774         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
775         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
776         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
777         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
778         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
779         * workers/WorkerMessagingProxy.cpp:
780         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
781
782 2011-04-27  Adam Barth  <abarth@webkit.org>
783
784         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
785
786         * page/Frame.cpp:
787         (WebCore::Frame::setTiledBackingStoreEnabled):
788         * platform/audio/ReverbConvolver.cpp:
789         (WebCore::ReverbConvolver::ReverbConvolver):
790
791 2011-04-27  Adam Barth  <abarth@webkit.org>
792
793         Reviewed by David Levin.
794
795         Fix five strict PassOwnPtr violations in WebCore
796         https://bugs.webkit.org/show_bug.cgi?id=59640
797
798         * css/MediaList.cpp:
799         (WebCore::MediaList::deleteMedium):
800         (WebCore::MediaList::setMediaText):
801         (WebCore::MediaList::appendMedium):
802         * css/MediaQuery.h:
803         * dom/MessagePort.cpp:
804         (WebCore::MessagePort::disentanglePorts):
805         (WebCore::MessagePort::entanglePorts):
806         * inspector/InspectorStyleSheet.cpp:
807         (ParsedStyleSheet::setText):
808         * rendering/RenderTheme.cpp:
809         (WebCore::RenderTheme::adjustStyle):
810         (WebCore::RenderTheme::adjustMeterStyle):
811         * rendering/RenderThemeMac.mm:
812         (WebCore::RenderThemeMac::adjustMenuListStyle):
813         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
814         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
815         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
816         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
817         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
818         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
819         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
820
821 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
822
823         Reviewed by Beth Dakin.
824
825         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
826         https://bugs.webkit.org/show_bug.cgi?id=59648
827
828         Test: accessibility/aria-fallback-roles.html
829
830         * accessibility/AccessibilityObject.cpp:
831         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
832
833 2011-04-27  Beth Dakin  <bdakin@apple.com>
834
835         Reviewed by Dan Bernstein.
836
837         https://bugs.webkit.org/show_bug.cgi?id=59671
838         Race condition with scrollbar animations and closing a page can cause a crash in 
839         WebCore::FrameView::setVisibleScrollerThumbRect + 15
840         -and corresponding-
841         <rdar://problem/9329253>
842
843         It is definitely possible for Page to be null here. So we should null-check it! 
844         And we should not ASSERT.
845         * page/FrameView.cpp:
846         (WebCore::FrameView::didCompleteRubberBand):
847         (WebCore::FrameView::scrollbarStyleChanged):
848         (WebCore::FrameView::setVisibleScrollerThumbRect):
849
850 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
851
852         WinCE build fix after r85143.
853
854         * platform/graphics/wince/FontWinCE.cpp:
855         (WebCore::TextRunComponent::TextRunComponent):
856
857 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
858
859         Reviewed by Tony Chang.
860
861         IndexedDB object store delete should fail if key is null
862         https://bugs.webkit.org/show_bug.cgi?id=58614
863
864         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
865
866         * storage/IDBObjectStoreBackendImpl.cpp:
867         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
868
869 2011-04-27  Eric Seidel  <eric@webkit.org>
870
871         Reviewed by Ryosuke Niwa.
872
873         Should have an easy way to construct starting BidiStatus for a paragraph root
874         https://bugs.webkit.org/show_bug.cgi?id=59226
875
876         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
877         I've made this a constructor for BidiStatus instead.
878
879         As part of this effort I added a direction() accessor for TextRun and got
880         rid of the old m_rtl bool.  This is part of the generic effort in the
881         Bidi code to replace old bool usage with the superior TextDirection enum
882         (this generally makes the code cleaner).
883
884         As part of this replacement effort I found several places which were
885         assuming LTR (by passing rtl=false) when they probably want to use
886         the current text direction.  I suspect that LTR vs. RTL may affect
887         string width in the case of ligatures.  It's unclear.
888
889         This is almost entirely a mechanical change.
890
891         * html/canvas/CanvasRenderingContext2D.cpp:
892         (WebCore::CanvasRenderingContext2D::drawTextInternal):
893         * platform/graphics/GraphicsContext.cpp:
894         (WebCore::GraphicsContext::drawBidiText):
895         * platform/graphics/TextRun.h:
896         (WebCore::TextRun::TextRun):
897         (WebCore::TextRun::direction):
898         (WebCore::TextRun::rtl):
899         (WebCore::TextRun::ltr):
900         (WebCore::TextRun::setDirection):
901         * platform/text/BidiResolver.h:
902         (WebCore::BidiStatus::BidiStatus):
903         * rendering/EllipsisBox.cpp:
904         (WebCore::EllipsisBox::paint):
905         (WebCore::EllipsisBox::selectionRect):
906         (WebCore::EllipsisBox::paintSelection):
907         * rendering/InlineTextBox.cpp:
908         (WebCore::InlineTextBox::selectionRect):
909         (WebCore::InlineTextBox::paint):
910         (WebCore::InlineTextBox::paintSelection):
911         (WebCore::InlineTextBox::paintCompositionBackground):
912         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
913         (WebCore::InlineTextBox::paintTextMatchMarker):
914         (WebCore::InlineTextBox::computeRectForReplacementMarker):
915         (WebCore::InlineTextBox::offsetForPosition):
916         (WebCore::InlineTextBox::positionForOffset):
917         * rendering/RenderBlockLineLayout.cpp:
918         (WebCore::RenderBlock::determineStartPosition):
919         * rendering/RenderFileUploadControl.cpp:
920         (WebCore::RenderFileUploadControl::paintObject):
921         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
922         * rendering/RenderListBox.cpp:
923         (WebCore::RenderListBox::updateFromElement):
924         (WebCore::RenderListBox::paintItemForeground):
925         * rendering/RenderTextControl.cpp:
926         (WebCore::RenderTextControl::getAvgCharWidth):
927         (WebCore::RenderTextControl::paintPlaceholder):
928         * rendering/svg/SVGInlineTextBox.cpp:
929         (WebCore::SVGInlineTextBox::constructTextRun):
930         * rendering/svg/SVGTextMetrics.cpp:
931         (WebCore::constructTextRun):
932
933 2011-04-27  Robert Hogan  <robert@webkit.org>
934
935         Reviewed by Adam Barth.
936
937         Allow shadowing of history object
938         https://bugs.webkit.org/show_bug.cgi?id=55965
939
940         Tests: http/tests/history/cross-origin-replace-history-object-child.html
941                http/tests/history/cross-origin-replace-history-object.html
942
943         * page/DOMWindow.idl:
944
945 2011-04-27  James Robinson  <jamesr@chromium.org>
946
947         Reviewed by Kenneth Russell.
948
949         [chromium] Ensure compositing layers are up to date before entering doComposite
950         https://bugs.webkit.org/show_bug.cgi?id=59159
951
952         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
953         GraphicsLayerClient::paintContents() implementations).
954
955         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
956         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
957         * platform/graphics/chromium/LayerChromium.cpp:
958         (WebCore::LayerChromium::LayerChromium):
959         (WebCore::LayerChromium::~LayerChromium):
960         * platform/graphics/chromium/LayerRendererChromium.cpp:
961         (WebCore::LayerRendererChromium::updateLayers):
962         * platform/graphics/chromium/LayerRendererChromium.h:
963           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
964
965 2011-04-27  James Robinson  <jamesr@chromium.org>
966
967         Reviewed by Adam Barth.
968
969         Fix OwnPtr strict issues in chromium linux build
970         https://bugs.webkit.org/show_bug.cgi?id=59664
971
972         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
973         (WebCore::ComplexTextController::getNormalizedTextRun):
974         * platform/graphics/skia/ImageBufferSkia.cpp:
975         (WebCore::ImageBuffer::ImageBuffer):
976         * platform/graphics/skia/PlatformContextSkia.cpp:
977         (WebCore::PlatformContextSkia::PlatformContextSkia):
978
979 2011-04-27  Chris Rogers  <crogers@google.com>
980
981         Reviewed by Kenneth Russell.
982
983         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
984         https://bugs.webkit.org/show_bug.cgi?id=59641
985
986         No new tests since audio API is not yet implemented.
987
988         * platform/audio/AudioBus.cpp:
989         (WebCore::AudioBus::createBySampleRateConverting):
990         (WebCore::AudioBus::createByMixingToMono):
991
992 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
993
994         Motivated by Alexey Proskuryakov.
995
996         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
997         informative, since it confused Alexey and me.
998
999 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1000
1001         Reviewed by Sam Weinig.
1002
1003         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1004         https://bugs.webkit.org/show_bug.cgi?id=59646
1005
1006         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1007         a world, we need to clear all entries in the map for that world, since
1008         the finalizers that would otherwise clear those entries don't run. The
1009         simplest way to do this is just to make the world own the map.
1010         
1011         * bindings/js/DOMWrapperWorld.h:
1012         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1013         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1014         * bindings/js/JSCSSValueCustom.cpp:
1015         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1016         (WebCore::JSCSSValueOwner::finalize):
1017         * bindings/js/JSDOMBinding.h:
1018
1019 2011-04-27  Adam Barth  <abarth@webkit.org>
1020
1021         Reviewed by David Levin.
1022
1023         Fix OwnPtr issues in IndexedDB
1024         https://bugs.webkit.org/show_bug.cgi?id=59656
1025
1026         I didn't do an exhaustive review of this code, but I fixed the problems
1027         caught by turning on strict OwnPtr and all their antecedents.  This
1028         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1029         behavior change.
1030
1031         * platform/leveldb/LevelDBDatabase.cpp:
1032         (WebCore::LevelDBDatabase::LevelDBDatabase):
1033         (WebCore::LevelDBDatabase::open):
1034         (WebCore::LevelDBDatabase::createIterator):
1035         * platform/leveldb/LevelDBDatabase.h:
1036         * platform/leveldb/LevelDBIterator.cpp:
1037         (WebCore::LevelDBIterator::LevelDBIterator):
1038         * platform/leveldb/LevelDBIterator.h:
1039         * storage/IDBLevelDBBackingStore.cpp:
1040         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1041         (WebCore::IDBLevelDBBackingStore::open):
1042         (WebCore::getNewDatabaseId):
1043         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1044         (WebCore::getNewObjectStoreId):
1045         (WebCore::deleteRange):
1046         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1047         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1048         (WebCore::IDBLevelDBBackingStore::getIndexes):
1049         (WebCore::getNewIndexId):
1050         (WebCore::findGreatestKeyLessThan):
1051         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1052         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1053         (WebCore::findLastIndexKeyEqualTo):
1054         * storage/IDBLevelDBBackingStore.h:
1055
1056 2011-04-19  MORITA Hajime  <morrita@google.com>
1057
1058         Reviewed by Tony Chang.
1059
1060         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1061         https://bugs.webkit.org/show_bug.cgi?id=58113
1062
1063         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1064         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1065         * Now MarkerMapVectorPair is no longer used.
1066         
1067         No new tests, No behavior change.
1068
1069         * GNUmakefile.list.am:
1070         * WebCore.gypi:
1071         * WebCore.pro:
1072         * WebCore.vcproj/WebCore.vcproj:
1073         * WebCore.xcodeproj/project.pbxproj:
1074         * dom/DocumentMarker.h:
1075         * dom/DocumentMarkerController.cpp:
1076         (WebCore::DocumentMarkerController::addMarker):
1077         (WebCore::DocumentMarkerController::copyMarkers):
1078         (WebCore::DocumentMarkerController::removeMarkers):
1079         (WebCore::DocumentMarkerController::markerContainingPoint):
1080         (WebCore::DocumentMarkerController::markersForNode):
1081         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1082         (WebCore::DocumentMarkerController::removeMarkersFromList):
1083         (WebCore::DocumentMarkerController::repaintMarkers):
1084         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1085         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1086         (WebCore::DocumentMarkerController::shiftMarkers):
1087         (WebCore::DocumentMarkerController::setMarkersActive):
1088         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1089         (WebCore::DocumentMarkerController::showMarkers):
1090         * dom/DocumentMarkerController.h:
1091         * dom/RenderedDocumentMarker.h: Added.
1092         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1093         (WebCore::RenderedDocumentMarker::isRendered):
1094         (WebCore::RenderedDocumentMarker::contains):
1095         (WebCore::RenderedDocumentMarker::setRenderedRect):
1096         (WebCore::RenderedDocumentMarker::renderedRect):
1097         (WebCore::RenderedDocumentMarker::invalidate):
1098         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1099
1100 2011-04-27  James Robinson  <jamesr@chromium.org>
1101
1102         Unreviewed, rolling out r85112.
1103         http://trac.webkit.org/changeset/85112
1104         https://bugs.webkit.org/show_bug.cgi?id=59159
1105
1106         Broke mac compile
1107
1108         * page/FrameView.cpp:
1109         (WebCore::FrameView::updateCompositingLayers):
1110         * page/FrameView.h:
1111         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1112         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1113         * platform/graphics/chromium/LayerChromium.cpp:
1114         (WebCore::LayerChromium::LayerChromium):
1115         (WebCore::LayerChromium::~LayerChromium):
1116         * platform/graphics/chromium/LayerRendererChromium.cpp:
1117         (WebCore::LayerRendererChromium::updateLayers):
1118         * platform/graphics/chromium/LayerRendererChromium.h:
1119
1120 2011-04-27  Mark Rowe  <mrowe@apple.com>
1121
1122         Build fix.
1123
1124         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1125
1126 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1127
1128         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1129
1130         * platform/network/ResourceHandleClient.h:
1131
1132 2011-04-27  James Robinson  <jamesr@chromium.org>
1133
1134         Reviewed by Kenneth Russell.
1135
1136         [chromium] Ensure compositing layers are up to date before entering doComposite
1137         https://bugs.webkit.org/show_bug.cgi?id=59159
1138
1139         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1140         GraphicsLayerClient::paintContents() implementations).
1141
1142         * page/FrameView.cpp:
1143         (WebCore::FrameView::updateCompositingLayers):
1144             Add an optional CompositingUpdateType parameter.
1145         * page/FrameView.h:
1146         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1147         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1148         * platform/graphics/chromium/LayerChromium.cpp:
1149         (WebCore::LayerChromium::LayerChromium):
1150         (WebCore::LayerChromium::~LayerChromium):
1151         * platform/graphics/chromium/LayerRendererChromium.cpp:
1152         (WebCore::LayerRendererChromium::updateLayers):
1153         * platform/graphics/chromium/LayerRendererChromium.h:
1154           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1155         * rendering/RenderLayer.cpp:
1156         (WebCore::RenderLayer::dirtyZOrderLists):
1157         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1158         * rendering/RenderLayerCompositor.cpp:
1159         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1160         * rendering/RenderLayerCompositor.h:
1161           Fix a typo in CompositingUpdateType Pait->Paint
1162
1163 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1164
1165         Reviewed by Antti Koivisto.
1166
1167         Part of WebCore should use CFNetwork-based loader on Mac
1168         https://bugs.webkit.org/show_bug.cgi?id=51836
1169
1170         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1171         willCacheResponse/shouldCacheResponse.
1172
1173         * loader/EmptyClients.h:
1174         * loader/FrameLoaderClient.h:
1175         * loader/ResourceLoader.h:
1176         * loader/cf/ResourceLoaderCFNet.cpp:
1177         * loader/mac/ResourceLoaderMac.mm:
1178         (WebCore::ResourceLoader::willCacheResponse):
1179         * platform/network/ResourceHandleClient.h:
1180         (WebCore::ResourceHandleClient::willCacheResponse):
1181         (WebCore::ResourceHandleClient::shouldCacheResponse):
1182         * platform/network/cf/ResourceHandleCFNet.cpp:
1183         (WebCore::willCacheResponse):
1184
1185 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
1186
1187         Reviewed by Brian Weinstein.
1188
1189         Web Inspector: Stop on Exception state does not persist.
1190
1191         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
1192         https://bugs.webkit.org/show_bug.cgi?id=59630
1193
1194         * inspector/front-end/ScriptsPanel.js:
1195         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1196         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1197         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1198
1199 2011-04-27  Adrienne Walker  <enne@google.com>
1200
1201         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
1202         https://bugs.webkit.org/show_bug.cgi?id=59020
1203
1204         * platform/graphics/chromium/LayerRendererChromium.cpp:
1205         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1206
1207 2011-04-27  Darin Adler  <darin@apple.com>
1208
1209         Reviewed by David Levin.
1210
1211         Fix strict OwnPtr issues seen in about 30 more files
1212         https://bugs.webkit.org/show_bug.cgi?id=59615
1213
1214         * bindings/js/JSCallbackData.h:
1215         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
1216         * bindings/js/JSMessageEventCustom.cpp:
1217         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
1218         * css/CSSParser.cpp:
1219         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
1220         adoptPtr, and release.
1221         * dom/MessageEvent.cpp:
1222         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
1223         and release.
1224         * dom/MessagePortChannel.cpp:
1225         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
1226         * dom/ScriptExecutionContext.cpp:
1227         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
1228         * dom/XMLDocumentParserLibxml2.cpp:
1229         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
1230         * dom/default/PlatformMessagePortChannel.cpp:
1231         (WebCore::MessagePortChannel::create): Use adoptPtr.
1232         * html/HTMLFormControlElement.cpp:
1233         (WebCore::HTMLFormControlElement::detach): Use nullptr.
1234         * inspector/InspectorAgent.cpp:
1235         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
1236         * inspector/InspectorConsoleAgent.cpp:
1237         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
1238         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
1239         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
1240         * inspector/InspectorController.cpp:
1241         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
1242         * inspector/InspectorDOMAgent.cpp:
1243         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
1244         * inspector/InspectorResourceAgent.cpp:
1245         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1246         * page/FrameActionScheduler.cpp:
1247         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1248         * platform/graphics/ShadowBlur.cpp:
1249         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1250         * platform/graphics/ca/GraphicsLayerCA.cpp:
1251         (WebCore::GraphicsLayer::create): Use adoptPtr.
1252         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1253         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1254         * rendering/RenderBlock.cpp:
1255         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1256         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1257         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
1258         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
1259         * rendering/RenderLayerBacking.cpp:
1260         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
1261         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
1262         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
1263         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
1264         * rendering/RenderLayerCompositor.cpp:
1265         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
1266         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
1267         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
1268         * rendering/style/StyleRareNonInheritedData.cpp:
1269         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
1270         explicit initializations of OwnPtr members to 0. Use adoptPtr.
1271         * workers/SharedWorkerContext.cpp:
1272         (WebCore::createConnectEvent): Use adoptPtr.
1273         * workers/Worker.cpp:
1274         (WebCore::Worker::notifyFinished): Use nullptr.
1275
1276 2011-04-27  Enrica Casucci  <enrica@apple.com>
1277
1278         Reviewed by Darin Adler.
1279
1280         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
1281         https://bugs.webkit.org/show_bug.cgi?id=59251
1282         <rdar://problem/9327044>
1283
1284         When we are looking for wrapping elements that are presentational, we should
1285         include elements that have a non transparent background color only if they
1286         are not blocks.
1287
1288         Test: editing/pasteboard/do-not-copy-body-color.html
1289
1290         * editing/markup.cpp:
1291         (WebCore::isElementPresentational):
1292
1293 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
1294
1295         Reviewed by Antti Koivisto.
1296
1297         Teach sub-selector chains about shadow descendants
1298         https://bugs.webkit.org/show_bug.cgi?id=58342
1299
1300         The primary change is to the logic of parsing specifiers:
1301         1) The shadow descendant selectors (those specifiers that are unknown
1302         pseudo element selectors) are always kept at the top of the chain.
1303         2) The sub-selectors after shadow descendant selectors are stashed right
1304         behind the sub-selector, but not at the end of the chain.
1305         3) Other sub-selectors are appended at the end of the chain.
1306
1307         * css/CSSGrammar.y: Changed specifier_list collection to use new
1308             CSSParser::updateSpecifier helper.
1309         * css/CSSParser.cpp:
1310         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
1311             look for the last ShadowDescendant relation in the chain of selectors,
1312             because the next selector after it is the one that should get the
1313             element name.
1314         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
1315             CSSGrammar.y. The new logic adjusts the selector chain to allow
1316             shadow descendant selectors have sub-selectors (and have multiple shadow
1317             descendants in the chain).
1318         * css/CSSParser.h: Added decl.
1319         * css/CSSParserValues.cpp:
1320         (WebCore::CSSParserSelector::insertTagHistory): Added.
1321         (WebCore::CSSParserSelector::appendTagHistory): Aded.
1322         * css/CSSParserValues.h: Added decls.
1323         * css/CSSStyleSelector.cpp:
1324         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
1325             shadow descendant selector match check, since now there could be many
1326             of them in the selector chain.
1327
1328 2011-04-20  Adrienne Walker  <enne@google.com>
1329
1330         Reviewed by Kenneth Russell.
1331
1332         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
1333         https://bugs.webkit.org/show_bug.cgi?id=59020
1334
1335         mapRect is the incorrect transform here.  The parent scissor rect
1336         needs to be projected into layer space instead.
1337
1338         Test: compositing/flat-with-transformed-child.html
1339
1340         * platform/graphics/chromium/LayerRendererChromium.cpp:
1341         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1342
1343 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1344
1345         Reviewed by Antti Koivisto.
1346
1347         Part of WebCore should use CFNetwork-based loader on Mac
1348         https://bugs.webkit.org/show_bug.cgi?id=51836
1349
1350         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
1351         * platform/mac/SoftLinking.h:
1352         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
1353
1354 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
1355
1356         Reviewed by Antti Koivisto.
1357
1358         Cleanup CSSStyleApplyProperty.cpp
1359         https://bugs.webkit.org/show_bug.cgi?id=59623
1360
1361         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
1362         Use typedefs instead of repating the function pointer declarations in a few places.
1363
1364         * css/CSSStyleApplyProperty.cpp:
1365         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
1366         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
1367         (WebCore::ApplyPropertyColor::applyInheritValue):
1368         (WebCore::ApplyPropertyColor::applyInitialValue):
1369         (WebCore::ApplyPropertyColor::applyValue):
1370         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
1371
1372 2011-04-27  Dan Bernstein  <mitz@apple.com>
1373
1374         Reviewed by Anders Carlsson.
1375
1376         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
1377         https://bugs.webkit.org/show_bug.cgi?id=59622
1378
1379         Test: fast/borders/border-image-trumps-radius.html
1380
1381         * rendering/RenderBox.cpp:
1382         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
1383         image, then border radius is ignored, so no bleed avoidance is needed.
1384         * rendering/RenderObject.cpp:
1385         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
1386         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
1387         * rendering/RenderObject.h:
1388
1389 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1390
1391         Reviewed by Xan Lopez.
1392
1393         [GTK] editing/pasteboard/copy-standalone-image.html fails
1394         https://bugs.webkit.org/show_bug.cgi?id=53645
1395
1396         When writing an image to the clipboard, also write the URL and title
1397         into the markup and URL portion. This change also abstracts a helper
1398         imageToMarkup into markup.{cpp/h} from several different locations
1399         throughout the platform layer.
1400
1401         * editing/markup.h: Added new function definition.
1402         * editing/markup.cpp:
1403         (WebCore::imageToMarkup): Add this function which turns an image URL 
1404         and element into some markup representing that image, while preserving
1405         non-src attributes.
1406         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
1407         to markup.cpp.
1408         * platform/gtk/PasteboardGtk.cpp:
1409         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
1410         image URL for a variety of image tag types.
1411         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
1412         markup and URL portions of the clipboard. This will ensure that images
1413         paste properly back into WebKit.
1414         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
1415         one from markup.h
1416
1417 2011-04-27  Steve Block  <steveblock@google.com>
1418
1419         Reviewed by David Levin.
1420
1421         Remove Android build system
1422         https://bugs.webkit.org/show_bug.cgi?id=48111
1423
1424         This is to avoid the maintenance burden until the Android port is
1425         fully upstreamed.
1426
1427         No new tests, build change only.
1428
1429         * Android.derived.jscbindings.mk: Removed.
1430         * Android.derived.mk: Removed.
1431         * Android.derived.v8bindings.mk: Removed.
1432         * Android.jscbindings.mk: Removed.
1433         * Android.mk: Removed.
1434         * Android.v8bindings.mk: Removed.
1435
1436 2011-04-27  Darin Adler  <darin@apple.com>
1437
1438         Reviewed by Sam Weinig.
1439
1440         Somehow about:blank gets into the icon database
1441         https://bugs.webkit.org/show_bug.cgi?id=58067
1442         rdar://problem/6751446
1443
1444         Implemented the policy Brady suggested, where only http and https URLs can
1445         be associated with and icon, guarding both on the way in to the database,
1446         and on the way out.
1447
1448         * loader/icon/IconDatabase.cpp:
1449         (WebCore::pageCanHaveIcon): Added.
1450         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
1451         instead of just checking for an empty URL.
1452         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
1453         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
1454         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
1455         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
1456         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
1457         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
1458         two separate assertions and added a third.
1459         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
1460
1461         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
1462         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
1463         overloaded it to work on both UChar and char, and added an assertion to it.
1464         Also moved this to the top of the file and made the UChar version usable
1465         in the shared code used even by Google.
1466         (WebCore::KURL::invalidate): Updated for name change.
1467         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
1468         toASCIILower since it's faster.
1469         (WebCore::KURL::parse): Updated for name changes.
1470         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
1471         since it's faster.
1472         (WebCore::protocolIsInHTTPFamily): Added.
1473
1474         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
1475         to protocolIsInHTTPFamily and added a version that works on a string.
1476         Kept the old name as an inline function so we don't have to rename
1477         all the cal sites now.
1478
1479         * platform/KURLGoogle.cpp: Renamed as above.
1480         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
1481         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
1482         (WebCore::KURLGooglePrivate::setAscii): Ditto.
1483         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
1484         (WebCore::KURLGooglePrivate::copyTo): Ditto.
1485         (WebCore::KURL::KURL): Ditto.
1486         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
1487         (WebCore::KURL::invalidate): Ditto.
1488         * platform/KURLGooglePrivate.h: Ditto.
1489
1490         * WebCore.exp.in: Updated for above changes.
1491
1492 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1493
1494         Reviewed by Pavel Feldman.
1495
1496         Web Inspector: browser crash on evaluation of 'throw undefined'
1497         https://bugs.webkit.org/show_bug.cgi?id=59611
1498
1499         Test: inspector/console/console-eval-throw-undefined.html
1500
1501         * inspector/InjectedScriptSource.js: use try/catch to protect from
1502         exception during conversion of another exception to string.
1503
1504 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1505
1506         Reviewed by Yury Semikhatsky.
1507
1508         Web Inspector: clicking bookmarklet multiplies resources panel entries.
1509         https://bugs.webkit.org/show_bug.cgi?id=59590
1510
1511         * inspector/front-end/ResourceTreeModel.js:
1512         (WebInspector.ResourceTreeModel):
1513         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
1514         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1515         * inspector/front-end/ResourcesPanel.js:
1516         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1517         (WebInspector.FrameTreeElement):
1518         (WebInspector.FrameTreeElement.prototype.appendResource):
1519         * inspector/front-end/inspector.js:
1520         (WebInspector.frontendReused):
1521
1522 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1523
1524         Reviewed by Yury Semikhatsky.
1525
1526         Web Inspector: opening bookmarklet disconnects DOM agent.
1527         https://bugs.webkit.org/show_bug.cgi?id=59588
1528
1529         * inspector/InspectorDOMAgent.cpp:
1530         (WebCore::InspectorDOMAgent::setDocument):
1531
1532 2011-04-27  Hans Wennborg  <hans@chromium.org>
1533
1534         Reviewed by Tony Gentilcore.
1535
1536         IndexedDB: Fix compiler warnings about uninitialized variables
1537         https://bugs.webkit.org/show_bug.cgi?id=59599
1538
1539         Build fix. No new tests.
1540
1541         * storage/IDBLevelDBBackingStore.cpp:
1542         (WebCore::getNewObjectStoreId):
1543         (WebCore::getNewIndexId):
1544
1545 2011-04-26  Hans Wennborg  <hans@chromium.org>
1546
1547         Reviewed by Tony Gentilcore.
1548
1549         IndexedDB: Move LevelDB key coding routines to separate file
1550         https://bugs.webkit.org/show_bug.cgi?id=59452
1551
1552         Move all routines concerned with encoding, decoding and comparison of
1553         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
1554         IDBLevelDBCoding.cpp.
1555
1556         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
1557         allow for unit testing of the coding routines.
1558
1559         No new functionality, no new tests.
1560
1561         * WebCore.gypi:
1562         * storage/IDBLevelDBBackingStore.cpp:
1563         (WebCore::getInt):
1564         (WebCore::putInt):
1565         (WebCore::getString):
1566         (WebCore::putString):
1567         (WebCore::compareKeys):
1568         (WebCore::compareIndexKeys):
1569         (WebCore::Comparator::compare):
1570         (WebCore::setUpMetadata):
1571         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
1572         (WebCore::getNewDatabaseId):
1573         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
1574         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1575         (WebCore::getNewObjectStoreId):
1576         (WebCore::IDBLevelDBBackingStore::createObjectStore):
1577         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
1578         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
1579         (WebCore::getNewVersionNumber):
1580         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
1581         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
1582         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
1583         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1584         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
1585         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1586         (WebCore::IDBLevelDBBackingStore::getIndexes):
1587         (WebCore::getNewIndexId):
1588         (WebCore::IDBLevelDBBackingStore::createIndex):
1589         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
1590         (WebCore::versionExists):
1591         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1592         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1593         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
1594         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
1595         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
1596         * storage/IDBLevelDBCoding.cpp: Added.
1597         (WebCore::IDBLevelDBCoding::encodeByte):
1598         (WebCore::IDBLevelDBCoding::maxIDBKey):
1599         (WebCore::IDBLevelDBCoding::minIDBKey):
1600         (WebCore::IDBLevelDBCoding::encodeInt):
1601         (WebCore::IDBLevelDBCoding::decodeInt):
1602         (WebCore::IDBLevelDBCoding::encodeVarInt):
1603         (WebCore::IDBLevelDBCoding::decodeVarInt):
1604         (WebCore::IDBLevelDBCoding::encodeString):
1605         (WebCore::IDBLevelDBCoding::decodeString):
1606         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
1607         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
1608         (WebCore::IDBLevelDBCoding::encodeDouble):
1609         (WebCore::IDBLevelDBCoding::decodeDouble):
1610         (WebCore::IDBLevelDBCoding::encodeIDBKey):
1611         (WebCore::IDBLevelDBCoding::decodeIDBKey):
1612         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
1613         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
1614         (WebCore::IDBLevelDBCoding::compare):
1615         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
1616         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
1617         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
1618         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
1619         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
1620         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
1621         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
1622         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
1623         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
1624         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
1625         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
1626         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
1627         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
1628         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
1629         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
1630         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
1631         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
1632         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
1633         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
1634         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
1635         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
1636         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
1637         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
1638         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
1639         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
1640         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
1641         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
1642         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
1643         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
1644         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
1645         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
1646         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
1647         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
1648         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
1649         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
1650         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
1651         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
1652         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
1653         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
1654         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
1655         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
1656         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
1657         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
1658         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
1659         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
1660         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
1661         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
1662         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
1663         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
1664         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
1665         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
1666         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
1667         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
1668         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
1669         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
1670         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
1671         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
1672         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
1673         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
1674         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
1675         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
1676         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
1677         * storage/IDBLevelDBCoding.h: Added.
1678         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
1679         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
1680         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
1681         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
1682         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
1683
1684 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1685
1686         Reviewed by Pavel Feldman.
1687
1688         Web Inspector: expose exception details when script is paused on exception
1689         https://bugs.webkit.org/show_bug.cgi?id=59591
1690
1691         When script is paused on an exception, the exception value is added as <exception>
1692         property in the local scope and the breakpoint details message says
1693         "Paused on excepion: '<exception to strin value>'."
1694
1695         * English.lproj/localizedStrings.js:
1696         * inspector/front-end/ScopeChainSidebarPane.js:
1697         (WebInspector.ScopeChainSidebarPane.prototype.update):
1698         * inspector/front-end/ScriptsPanel.js:
1699         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
1700         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
1701
1702 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
1703
1704         Reviewed by Pavel Feldman.
1705
1706         Web Inspector: [protocol] Paused event should expose exception value that caused it
1707         https://bugs.webkit.org/show_bug.cgi?id=58996
1708
1709         Debug.pause event now contains an optional reference to the exception
1710         object in case script execution is paused on a JavaScript exception.
1711
1712         Also JavaScript call frames are passed directly into the injected script when
1713         we need to wrap them for passing to the front-end. This change breaks cyclic
1714         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
1715
1716         * bindings/js/JSInjectedScriptHostCustom.cpp:
1717         * bindings/js/ScriptDebugServer.cpp:
1718         (WebCore::ScriptDebugServer::dispatchDidPause):
1719         * bindings/js/ScriptDebugServer.h:
1720         * bindings/v8/ScriptDebugServer.cpp:
1721         (WebCore::ScriptDebugServer::breakProgram):
1722         (WebCore::ScriptDebugServer::editScriptSource):
1723         (WebCore::ScriptDebugServer::breakProgramCallback):
1724         (WebCore::ScriptDebugServer::handleV8DebugEvent):
1725         * bindings/v8/ScriptDebugServer.h:
1726         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
1727         * inspector/InjectedScript.cpp:
1728         (WebCore::InjectedScript::evaluateOnCallFrame):
1729         (WebCore::InjectedScript::wrapCallFrames):
1730         * inspector/InjectedScript.h:
1731         * inspector/InjectedScriptHost.cpp:
1732         * inspector/InjectedScriptHost.h:
1733         (WebCore::InjectedScriptHost::init):
1734         * inspector/InjectedScriptHost.idl:
1735         * inspector/InjectedScriptSource.js:
1736         (.):
1737         * inspector/Inspector.json:
1738         * inspector/InspectorAgent.cpp:
1739         (WebCore::InspectorAgent::InspectorAgent):
1740         * inspector/InspectorDebuggerAgent.cpp:
1741         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
1742         (WebCore::InspectorDebuggerAgent::currentCallFrames):
1743         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
1744         (WebCore::InspectorDebuggerAgent::didPause):
1745         (WebCore::InspectorDebuggerAgent::didContinue):
1746         (WebCore::InspectorDebuggerAgent::clear):
1747         * inspector/InspectorDebuggerAgent.h:
1748         * inspector/ScriptDebugListener.h:
1749         * inspector/WorkerInspectorController.cpp:
1750         (WebCore::WorkerInspectorController::WorkerInspectorController):
1751
1752 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1753
1754         Reviewed by Yury Semikhatsky.
1755
1756         Web Inspector: implement incremental CSS editing in the structure view.
1757         https://bugs.webkit.org/show_bug.cgi?id=59455
1758
1759         * inspector/front-end/StylesSidebarPane.js:
1760         (WebInspector.StylePropertyTreeElement.prototype):
1761
1762 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
1763
1764         Reviewed by Eric Seidel.
1765
1766         Frame.h shouldn't include Document.h
1767         https://bugs.webkit.org/show_bug.cgi?id=59560
1768
1769         Frame can use a forward-declared Document if we move
1770         Frame::displayStringModifiedByEncoding's implementation out of the
1771         header.
1772                                 Size  #includes  Size * #includes
1773         Before: page/Frame.h:   0.746       653           487.138
1774                 dom/Document.h: 0.220      1306           287.320
1775         
1776         After:  page/Frame.h:   0.646       653           421.838
1777                 dom/Document.h: 0.220      1189           261.580
1778
1779         * WebCore.exp.in:
1780         * bindings/ScriptControllerBase.cpp:
1781         * bindings/generic/BindingSecurityBase.cpp:
1782         * bindings/v8/V8Proxy.cpp:
1783         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
1784         * dom/CharacterData.cpp:
1785         * dom/UserTypingGestureIndicator.cpp:
1786         * editing/chromium/SelectionControllerChromium.cpp:
1787         * inspector/InspectorDOMStorageResource.cpp:
1788         * inspector/InspectorInstrumentation.h:
1789         * loader/PingLoader.cpp:
1790         * loader/SubresourceLoader.cpp:
1791         * loader/appcache/DOMApplicationCache.cpp:
1792         * loader/cache/CachedResourceRequest.cpp:
1793         * page/Frame.cpp:
1794         (WebCore::Frame::displayStringModifiedByEncoding):
1795         * page/Frame.h:
1796         * page/Geolocation.cpp:
1797         * page/Location.cpp:
1798         * page/Navigator.cpp:
1799         * page/PageGroupLoadDeferrer.cpp:
1800         * page/PerformanceTiming.cpp:
1801         * xml/XSLTProcessorLibxslt.cpp:
1802
1803 2011-04-27  James Robinson  <jamesr@chromium.org>
1804
1805         Reviewed by Eric Seidel.
1806
1807         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
1808         https://bugs.webkit.org/show_bug.cgi?id=59377
1809
1810         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
1811         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
1812
1813         * css/CSSStyleSelector.cpp:
1814         (WebCore::CSSStyleSelector::applyProperty):
1815         * page/animation/AnimationBase.cpp:
1816         (WebCore::blendFunc):
1817         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
1818         (WebCore::PropertyWrapperShadow::blend):
1819         * rendering/style/RenderStyle.cpp:
1820         (WebCore::RenderStyle::setTextShadow):
1821         (WebCore::RenderStyle::setBoxShadow):
1822         * rendering/style/RenderStyle.h:
1823         (WebCore::InheritedFlags::textShadow):
1824         * rendering/style/ShadowData.cpp:
1825         (WebCore::ShadowData::ShadowData):
1826         * rendering/style/ShadowData.h:
1827         (WebCore::ShadowData::ShadowData):
1828         (WebCore::ShadowData::next):
1829         (WebCore::ShadowData::setNext):
1830         * rendering/style/StyleRareInheritedData.cpp:
1831         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1832         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
1833         * rendering/style/StyleRareInheritedData.h:
1834         * rendering/style/StyleRareNonInheritedData.cpp:
1835         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
1836
1837 2011-04-26  David Levin  <levin@chromium.org>
1838
1839         Reviewed by Eric Seidel.
1840
1841         Fix some strict PassOwnPtr issues in WebCore.
1842         https://bugs.webkit.org/show_bug.cgi?id=59563
1843
1844         * css/SVGCSSStyleSelector.cpp:
1845         (WebCore::CSSStyleSelector::applySVGProperty):
1846         * html/canvas/WebGLRenderingContext.cpp:
1847         (WebCore::WebGLRenderingContext::create):
1848         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
1849         * platform/text/TextCodecLatin1.cpp:
1850         (WebCore::newStreamingTextDecoderWindowsLatin1):
1851         * platform/text/TextCodecUTF16.cpp:
1852         (WebCore::newStreamingTextDecoderUTF16LE):
1853         (WebCore::newStreamingTextDecoderUTF16BE):
1854         * platform/text/TextCodecUserDefined.cpp:
1855         (WebCore::newStreamingTextDecoderUserDefined):
1856         * platform/text/mac/TextCodecMac.cpp:
1857         (WebCore::newTextCodecMac):
1858         * workers/Worker.cpp:
1859         (WebCore::Worker::notifyFinished):
1860
1861 2011-04-26  Justin Novosad  <junov@chromium.org>
1862
1863         Reviewed by Kenneth Russell.
1864
1865         [Chromium] Expose skia gpu canvas rendering as a runtime flag
1866         https://bugs.webkit.org/show_bug.cgi?id=58683
1867         Replace the SKIA_GPU compile flag by the pre-existing
1868         acceleratedDrawingEnabled flag. Most code changes are trivial:
1869         compile-time conditionals on SKIA_GPU were either replaced with
1870         a run-time check, or a compile time check on USE(SKIA) 
1871
1872         No new tests. Covered by existing tests.
1873
1874         * html/canvas/CanvasRenderingContext2D.cpp:
1875         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
1876         * page/Page.cpp:
1877         (WebCore::Page::sharedGraphicsContext3D):
1878         Added check for the acceleratedDrawing flag.
1879         * platform/graphics/chromium/DrawingBufferChromium.cpp:
1880         (WebCore::DrawingBuffer::DrawingBuffer):
1881         (WebCore::DrawingBuffer::publishToPlatformLayer):
1882         * platform/graphics/gpu/DrawingBuffer.h:
1883         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
1884         (WebCore::SharedGraphicsContext3D::create):
1885         On Skia builds, this methos now receives a bool arg to turn on
1886         GPU-accelerated skia rendering
1887         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
1888         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
1889         (WebCore::SharedGraphicsContext3D::grContext):
1890         * platform/graphics/gpu/SharedGraphicsContext3D.h:
1891         * platform/graphics/skia/ImageSkia.cpp:
1892         (WebCore::computeResamplingMode):
1893         (WebCore::paintSkBitmap):
1894         (WebCore::Image::drawPattern):
1895         * platform/graphics/skia/PlatformContextSkia.cpp:
1896         (WebCore::PlatformContextSkia::PlatformContextSkia):
1897         (WebCore::PlatformContextSkia::~PlatformContextSkia):
1898         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
1899         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
1900         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
1901         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
1902         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
1903         (WebCore::PlatformContextSkia::markDirtyRect):
1904         * platform/graphics/skia/PlatformContextSkia.h:
1905         (WebCore::PlatformContextSkia::accelerationMode):
1906         (WebCore::PlatformContextSkia::useGPU):
1907         (WebCore::PlatformContextSkia::useSkiaGPU):
1908
1909 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
1910
1911         Not reviewed: restore inspector test disabled in r84913.
1912
1913         Test: http/tests/inspector-enabled/dom-storage-open.html
1914
1915         * inspector/InspectorDOMStorageAgent.cpp:
1916         (WebCore::InspectorDOMStorageAgent::clearFrontend):
1917
1918 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
1919
1920         Reviewed by Tony Chang.
1921
1922         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
1923         https://bugs.webkit.org/show_bug.cgi?id=59182
1924
1925         Use vertical offsets of the shaping results.
1926
1927         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
1928
1929         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1930         (WebCore::ComplexTextController::ComplexTextController):
1931         Added initialization of m_startingY.
1932         (WebCore::ComplexTextController::nextScriptRun):
1933         Followed the change in handling positions.
1934         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
1935         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
1936         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
1937         (WebCore::ComplexTextController::setGlyphPositions):
1938         Changed to use vertical offsets as same as horizontal offsets.
1939         * platform/graphics/chromium/ComplexTextControllerLinux.h:
1940         Removed m_xPositions and Added m_positions and m_startingY.
1941         (WebCore::ComplexTextController::positions): Added.
1942         * platform/graphics/chromium/FontLinux.cpp:
1943         Followed the change in ComplexTextController.
1944         (WebCore::Font::drawComplexText): Ditto.
1945         (WebCore::Font::floatWidthForComplexText): Ditto.
1946         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
1947         (WebCore::Font::offsetForPositionForComplexText): Ditto.
1948         (WebCore::Font::selectionRectForComplexText): Ditto.
1949
1950 2011-04-26  Levi Weintraub  <leviw@chromium.org>
1951
1952         Reviewed by Eric Seidel.
1953
1954         Root element should establish a new block formatting context
1955         https://bugs.webkit.org/show_bug.cgi?id=54573
1956
1957         Always expanding the root renderer to include overhanging floats.
1958
1959         Test: fast/block/float/float-overhangs-root.html
1960
1961         * rendering/RenderBlock.cpp:
1962         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
1963
1964 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
1965
1966         Reviewed by Andreas Kling.
1967
1968         [Qt] Improper rendering of <button> tag when it contains a <br>
1969         https://bugs.webkit.org/show_bug.cgi?id=50521
1970
1971         Test: platform/qt/fast/forms/button-line-break.html
1972
1973         * platform/qt/RenderThemeQt.cpp:
1974         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
1975         (WebCore::RenderThemeQt::setButtonPadding):
1976
1977 2011-04-26  James Robinson  <jamesr@chromium.org>
1978
1979         Reviewed by Kenneth Russell.
1980
1981         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
1982         https://bugs.webkit.org/show_bug.cgi?id=59572
1983
1984         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
1985         when LayerRendererChromium was set.  We set this pointer every frame
1986         and should only reset the tiles if the new LayerRendererChromium is
1987         different from the old one (indicating a context loss), not just reset
1988         on every frame.
1989
1990         * platform/graphics/chromium/LayerTilerChromium.cpp:
1991         (WebCore::LayerTilerChromium::setLayerRenderer):
1992         * platform/graphics/chromium/LayerTilerChromium.h:
1993
1994 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
1995
1996         Reviewed by Eric Seidel.
1997
1998         beginElement broken by setAttribute
1999         https://bugs.webkit.org/show_bug.cgi?id=26019
2000
2001         Test: svg/animations/animate-beginElementAt.svg
2002
2003         * svg/SVGAnimationElement.cpp:
2004         (WebCore::SVGAnimationElement::attributeChanged):
2005         Reset the animation state here as the rest of the code reads it and would still
2006         think we are animating when we are not.
2007
2008         * svg/animation/SVGSMILElement.h:
2009         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2010
2011 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2012
2013         Unreviewed, rolling out r84989.
2014         http://trac.webkit.org/changeset/84989
2015         https://bugs.webkit.org/show_bug.cgi?id=59566
2016
2017         REGRESSION (r84989): Lots of vertical text tests failing on
2018         windows (Requested by weinig on #webkit).
2019
2020         * platform/graphics/FontPlatformData.h:
2021         * platform/graphics/win/FontCacheWin.cpp:
2022         (WebCore::FontCache::getFontDataForCharacters):
2023         (WebCore::FontCache::createFontPlatformData):
2024         * platform/graphics/win/FontCustomPlatformData.cpp:
2025         (WebCore::FontCustomPlatformData::fontPlatformData):
2026         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2027         (WebCore::FontPlatformData::FontPlatformData):
2028         * platform/graphics/win/FontPlatformDataWin.cpp:
2029         (WebCore::FontPlatformData::FontPlatformData):
2030
2031 2011-04-26  Sam Weinig  <sam@webkit.org>
2032
2033         Reviewed by Eric Seidel.
2034
2035         Try again:
2036             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2037             https://bugs.webkit.org/show_bug.cgi?id=59310
2038
2039         * bindings/js/JSDOMBinding.h:
2040         (WebCore::DOMConstructorObject::DOMConstructorObject):
2041         * bindings/js/JSDOMWrapper.h:
2042         (WebCore::JSDOMWrapper::globalObject):
2043         (WebCore::JSDOMWrapper::scriptExecutionContext):
2044         (WebCore::JSDOMWrapper::createStructure):
2045         (WebCore::JSDOMWrapper::JSDOMWrapper):
2046         * bindings/scripts/CodeGeneratorJS.pm:
2047
2048 2011-04-26  Sam Weinig  <sam@webkit.org>
2049
2050         Reviewed by David Hyatt.
2051
2052         Remove Datagrid from the tree
2053         https://bugs.webkit.org/show_bug.cgi?id=59543
2054
2055         * Android.derived.jscbindings.mk:
2056         * Android.derived.v8bindings.mk:
2057         * Android.jscbindings.mk:
2058         * Android.v8bindings.mk:
2059         * CMakeLists.txt:
2060         * CodeGenerators.pri:
2061         * Configurations/FeatureDefines.xcconfig:
2062         * DerivedSources.cpp:
2063         * DerivedSources.make:
2064         * GNUmakefile.am:
2065         * GNUmakefile.list.am:
2066         * UseJSC.cmake:
2067         * WebCore.gypi:
2068         * WebCore.pro:
2069         * WebCore.vcproj/WebCore.vcproj:
2070         * WebCore.xcodeproj/project.pbxproj:
2071         * bindings/js/JSBindingsAllInOne.cpp:
2072         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2073         * bindings/js/JSDataGridDataSource.cpp: Removed.
2074         * bindings/js/JSDataGridDataSource.h: Removed.
2075         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2076         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2077         * bindings/v8/V8DataGridDataSource.h: Removed.
2078         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2079         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2080         * css/CSSStyleSelector.cpp:
2081         * css/CSSStyleSelector.h:
2082         * css/html.css:
2083         (input, textarea, keygen, select, button, isindex):
2084         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2085         * editing/htmlediting.cpp:
2086         (WebCore::canHaveChildrenForEditing):
2087         * features.pri:
2088         * html/DOMDataGridDataSource.cpp: Removed.
2089         * html/DOMDataGridDataSource.h: Removed.
2090         * html/DataGridColumn.cpp: Removed.
2091         * html/DataGridColumn.h: Removed.
2092         * html/DataGridColumn.idl: Removed.
2093         * html/DataGridColumnList.cpp: Removed.
2094         * html/DataGridColumnList.h: Removed.
2095         * html/DataGridColumnList.idl: Removed.
2096         * html/DataGridDataSource.h: Removed.
2097         * html/HTMLDataGridCellElement.cpp: Removed.
2098         * html/HTMLDataGridCellElement.h: Removed.
2099         * html/HTMLDataGridCellElement.idl: Removed.
2100         * html/HTMLDataGridColElement.cpp: Removed.
2101         * html/HTMLDataGridColElement.h: Removed.
2102         * html/HTMLDataGridColElement.idl: Removed.
2103         * html/HTMLDataGridElement.cpp: Removed.
2104         * html/HTMLDataGridElement.h: Removed.
2105         * html/HTMLDataGridElement.idl: Removed.
2106         * html/HTMLDataGridRowElement.cpp: Removed.
2107         * html/HTMLDataGridRowElement.h: Removed.
2108         * html/HTMLDataGridRowElement.idl: Removed.
2109         * html/HTMLElement.cpp:
2110         (WebCore::HTMLElement::ieForbidsInsertHTML):
2111         * html/HTMLElementsAllInOne.cpp:
2112         * html/HTMLTagNames.in:
2113         * page/DOMWindow.idl:
2114         * rendering/RenderBox.cpp:
2115         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2116         * rendering/RenderDataGrid.cpp: Removed.
2117         * rendering/RenderDataGrid.h: Removed.
2118         * rendering/RenderingAllInOne.cpp:
2119
2120 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2121
2122         Reviewed by Adele Peterson.
2123
2124         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2125         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2126
2127         This platform dependent patch makes WebKit (Windows) show the
2128         vertical writing text correctly.  Job was done by adding a prefix '@'
2129         in front of the font family name (Windows Only). No new tests added.
2130         Some layout tests images:
2131         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2132
2133         * platform/graphics/FontPlatformData.h:
2134         * platform/graphics/win/FontCacheWin.cpp:
2135         (WebCore::FontCache::getFontDataForCharacters):
2136         (WebCore::FontCache::createFontPlatformData):
2137         * platform/graphics/win/FontCustomPlatformData.cpp:
2138         (WebCore::FontCustomPlatformData::fontPlatformData):
2139         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2140         (WebCore::FontPlatformData::FontPlatformData):
2141         * platform/graphics/win/FontPlatformDataWin.cpp:
2142         (WebCore::FontPlatformData::FontPlatformData):
2143
2144 2011-04-26  Jer Noble  <jer.noble@apple.com>
2145
2146         Reviewed by Brady Eidson.
2147
2148         HTML5 video fullscreen transition causes an audio stutter
2149         https://bugs.webkit.org/show_bug.cgi?id=59544
2150
2151         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2152         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2153         layer to render it invisible, instead just set the layer as hidden.
2154
2155         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2156         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2157         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2158         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2159         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2160         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2161
2162 2011-04-26  Christian Dywan  <christian@lanedo.com>
2163
2164         Reviewed by Eric Seidel.
2165
2166         Extra separator after Select All in context menu
2167         https://bugs.webkit.org/show_bug.cgi?id=54092
2168
2169         * page/ContextMenuController.cpp: Move separator to non-GTK+
2170             port guards since it is for the spelling options menu
2171             which the GTK+ port doesn't use.
2172
2173 2011-04-26  James Robinson  <jamesr@chromium.org>
2174
2175         Reviewed by Kenneth Russell.
2176
2177         [chromium] Clear out LayerTilerChromium's tiles on lost context
2178         https://bugs.webkit.org/show_bug.cgi?id=59233
2179
2180         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
2181         no longer valid since they exist in the previous LayerRendererChromium.
2182
2183         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
2184
2185         * platform/graphics/chromium/LayerTilerChromium.h:
2186         (WebCore::LayerTilerChromium::setLayerRenderer):
2187
2188 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2189
2190         Reviewed by Dirk Schulze.
2191
2192         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
2193         https://bugs.webkit.org/show_bug.cgi?id=57644
2194
2195         Manual test: plugins/windowed-in-iframe-2.html
2196
2197         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
2198         * platform/gtk/WidgetGtk.cpp:
2199         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
2200         * plugins/PluginView.h: Added helper method to set the allocation and clip.
2201         * plugins/gtk/PluginViewGtk.cpp:
2202         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
2203         the allocation immediately. Bring this method into sync with the implementation in
2204         the Qt port.
2205         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
2206         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
2207
2208 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2209
2210         Reviewed by Eric Seidel.
2211
2212         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
2213         https://bugs.webkit.org/show_bug.cgi?id=58818
2214
2215         Prevent allocating scratch buffers larger than the target GdkDrawable
2216         when creating a WidgetRenderingContext. This prevents incredibly large
2217         widgets from crashing the X Server. This change also allowed greatly
2218         simplifying the way that the painting offset is calculated.
2219
2220         * platform/gtk/WidgetRenderingContext.cpp:
2221         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
2222         larger than the target GdkDrawable.
2223         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
2224         blit by looking at the location of the target rect itself, rather than delaying the
2225         calculation up to this point.
2226         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
2227         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
2228         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
2229         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
2230         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
2231         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
2232         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
2233         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
2234         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
2235         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
2236         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
2237         a member to store the IntSize mapping from the coordinates of the target to the coordinates
2238         of the scratch buffer.
2239
2240 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
2241
2242         Reviewed by Adam Barth.
2243
2244         Respect charset in handleDataURL
2245         https://bugs.webkit.org/show_bug.cgi?id=47746
2246
2247         Original patch by Kwang Yul Seo <skyul@company100.net>
2248
2249         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2250         returns an empty string because encoding name is not specified.
2251
2252         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2253
2254         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2255
2256         * platform/network/DataURL.cpp:
2257         (WebCore::handleDataURL):
2258
2259 2011-04-26  Anders Carlsson  <andersca@apple.com>
2260
2261         Fix clang++ build.
2262
2263         You can never have too many casts!
2264
2265         * accessibility/mac/AccessibilityObjectWrapper.mm:
2266         (-[AccessibilityObjectWrapper position]):
2267         * editing/mac/SelectionControllerMac.mm:
2268         (WebCore::accessibilityConvertScreenRect):
2269
2270 2011-04-26  Chris Rogers  <crogers@google.com>
2271
2272         Reviewed by Kenneth Russell.
2273
2274         Fix web audio build on mac port
2275         https://bugs.webkit.org/show_bug.cgi?id=59355
2276
2277         No new tests since audio API is not yet implemented.
2278
2279         * WebCore.xcodeproj/project.pbxproj:
2280         * bindings/js/JSAudioContextCustom.cpp:
2281         (WebCore::JSAudioContext::visitChildren):
2282         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
2283         (WebCore::JSJavaScriptAudioNode::visitChildren):
2284         * webaudio/AudioContext.idl:
2285
2286 2011-04-26  Chris Rogers  <crogers@google.com>
2287
2288         Reviewed by Kenneth Russell.
2289
2290         Add FFTFrame implementation for FFmpeg
2291         https://bugs.webkit.org/show_bug.cgi?id=59408
2292
2293         No new tests since audio API is not yet implemented.
2294
2295         * WebCore.gyp/WebCore.gyp:
2296         * WebCore.gypi:
2297         * platform/audio/FFTFrame.h:
2298         * platform/audio/FFTFrameStub.cpp:
2299         * platform/audio/ffmpeg: Added.
2300         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
2301         (WebCore::FFTFrame::FFTFrame):
2302         (WebCore::FFTFrame::initialize):
2303         (WebCore::FFTFrame::cleanup):
2304         (WebCore::FFTFrame::~FFTFrame):
2305         (WebCore::FFTFrame::multiply):
2306         (WebCore::FFTFrame::doFFT):
2307         (WebCore::FFTFrame::doInverseFFT):
2308         (WebCore::FFTFrame::realData):
2309         (WebCore::FFTFrame::imagData):
2310         (WebCore::FFTFrame::getUpToDateComplexData):
2311         (WebCore::FFTFrame::contextForSize):
2312         * platform/audio/mac/FFTFrameMac.cpp:
2313         * webaudio/ConvolverNode.cpp:
2314
2315 2011-04-26  Jeff Miller  <jeffm@apple.com>
2316
2317         Add a newline at the end of SVGFEDropShadowElement.idl.
2318
2319         * svg/SVGFEDropShadowElement.idl:
2320
2321 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2322
2323         Reviewed by Eric Seidel.
2324
2325         InlineBox.h shouldn't include RenderBR.h
2326         https://bugs.webkit.org/show_bug.cgi?id=59480
2327
2328         Per bug 59348 RenderBR.h is a "top header" by include * size, because
2329         InlineBox.h includes it. There's no reason why it has to.
2330
2331         * rendering/InlineBox.h:
2332         * rendering/InlineTextBox.cpp:
2333         * rendering/RenderBlock.h:
2334
2335 2011-04-26  Sam Weinig  <sam@webkit.org>
2336
2337         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
2338         I should do.
2339
2340         * bindings/js/JSDOMBinding.h:
2341         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2342         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2343         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2344         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2345         (WebCore::DOMConstructorObject::DOMConstructorObject):
2346         * bindings/js/JSDOMWrapper.h:
2347         (WebCore::JSDOMWrapper::JSDOMWrapper):
2348         * bindings/scripts/CodeGeneratorJS.pm:
2349
2350 2011-04-26  Sam Weinig  <sam@webkit.org>
2351
2352         Fix build.
2353
2354         * bindings/js/JSDOMWrapper.h:
2355         (WebCore::JSDOMWrapper::globalObject):
2356
2357 2011-04-26  Sam Weinig  <sam@webkit.org>
2358
2359         Roll r84945 back in with infinite recursion removed.
2360
2361         * bindings/js/JSDOMBinding.h:
2362         (WebCore::DOMConstructorObject::DOMConstructorObject):
2363         * bindings/js/JSDOMWrapper.h:
2364         (WebCore::JSDOMWrapper::globalObject):
2365         (WebCore::JSDOMWrapper::scriptExecutionContext):
2366         (WebCore::JSDOMWrapper::createStructure):
2367         (WebCore::JSDOMWrapper::JSDOMWrapper):
2368         * bindings/scripts/CodeGeneratorJS.pm:
2369
2370 2011-04-26  Sam Weinig  <sam@webkit.org>
2371
2372         Rollout previous patch. It broke stuff.
2373
2374         * bindings/js/JSDOMBinding.h:
2375         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2376         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2377         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2378         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2379         (WebCore::DOMConstructorObject::DOMConstructorObject):
2380         * bindings/js/JSDOMWrapper.h:
2381         (WebCore::JSDOMWrapper::JSDOMWrapper):
2382         * bindings/scripts/CodeGeneratorJS.pm:
2383
2384 2011-04-26  Sam Weinig  <sam@webkit.org>
2385
2386         Reviewed by Maciej Stachowiak.
2387
2388         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2389         https://bugs.webkit.org/show_bug.cgi?id=59310
2390
2391         * bindings/js/JSDOMBinding.h:
2392         (WebCore::DOMConstructorObject::DOMConstructorObject):
2393         * bindings/js/JSDOMWrapper.h:
2394         (WebCore::JSDOMWrapper::globalObject):
2395         (WebCore::JSDOMWrapper::scriptExecutionContext):
2396         (WebCore::JSDOMWrapper::createStructure):
2397         (WebCore::JSDOMWrapper::JSDOMWrapper):
2398         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
2399
2400         * bindings/scripts/CodeGeneratorJS.pm:
2401         Make JSDOMWrapper the base class.
2402
2403 2011-04-26  Dan Bernstein  <mitz@apple.com>
2404
2405         Reviewed by Mark Rowe.
2406
2407         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
2408
2409         * Configurations/Base.xcconfig:
2410         * Configurations/CompilerVersion.xcconfig: Added.
2411
2412 2011-04-26  Adrienne Walker  <enne@google.com>
2413
2414         Reviewed by Geoffrey Garen.
2415
2416         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
2417         https://bugs.webkit.org/show_bug.cgi?id=59469
2418
2419         * platform/chromium/TraceEvent.h:
2420         (WebCore::internal::ScopeTracer::ScopeTracer):
2421
2422 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2423
2424         Reviewed by Oliver Hunt.
2425
2426         Nixed special finalizer handling for WebCore strings
2427         https://bugs.webkit.org/show_bug.cgi?id=59425
2428
2429         Not needed anymore, since weak handles have finalizers.
2430
2431         * WebCore.exp.in: Exports!
2432
2433         * bindings/js/DOMWrapperWorld.cpp:
2434         (WebCore::JSStringOwner::finalize):
2435         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
2436         so we don't need special treatment anymore.
2437
2438         * bindings/js/DOMWrapperWorld.h:
2439         (WebCore::JSStringOwner::JSStringOwner):
2440         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
2441         instead of a WeakGCMap, so we can specify a custom finalizer.
2442
2443         * bindings/js/JSDOMBinding.cpp:
2444         (WebCore::jsStringSlowCase):
2445         * bindings/js/JSDOMBinding.h:
2446         (WebCore::jsString): Updated for string map change.
2447
2448 2011-04-26  David Kilzer  <ddkilzer@apple.com>
2449
2450         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
2451
2452         Reviewed by Antti Koivisto.
2453
2454         To enable HTTP pipelining post-SnowLeopard, use this command:
2455
2456             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
2457
2458         * platform/network/cf/ResourceRequestCFNet.cpp:
2459         (WebCore::readBooleanPreference): Re-added.  Originally added in
2460         r76756 and removed in r84120.
2461         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
2462         HTTP pipelining if use default is set to true.  Added macro
2463         guards to match those in ResourceRequestMac.mm.
2464
2465 2011-04-26  Antti Koivisto  <antti@apple.com>
2466
2467         Reviewed by Adele Peterson.
2468
2469         Don't strip fragments from file: urls in memory cache
2470         https://bugs.webkit.org/show_bug.cgi?id=59463
2471         <rdar://problem/9231130>
2472
2473         Some clients expect file: resources to be unique based on fragment identifier. 
2474         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
2475
2476         Test: fast/loader/file-protocol-fragment.html
2477
2478         * loader/cache/MemoryCache.cpp:
2479         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
2480
2481 2011-04-26  David Levin  <levin@chromium.org>
2482
2483         Reviewed by Darin Adler.
2484
2485         Fix more strict OwnPtr in WebCore (round N).
2486         https://bugs.webkit.org/show_bug.cgi?id=59464
2487
2488         * dom/Document.cpp:
2489         (WebCore::Document::Document):
2490         (WebCore::Document::attach):
2491         * fileapi/FileReader.cpp:
2492         (WebCore::FileReader::terminate):
2493         * loader/DocumentThreadableLoader.cpp:
2494         (WebCore::DocumentThreadableLoader::preflightFailure):
2495         * workers/DefaultSharedWorkerRepository.cpp:
2496         (WebCore::SharedWorkerConnectTask::create):
2497         (WebCore::SharedWorkerScriptLoader::load):
2498
2499 2011-04-26  Ruben  <chromium@hybridsource.org>
2500
2501         Reviewed by Tony Chang.
2502
2503         Change linux ifdefs for Chromium to Unix instead, allowing
2504         new Unix ports to be enabled by default
2505         https://bugs.webkit.org/show_bug.cgi?id=59297
2506
2507         No new tests, just changing preprocessor defines.
2508
2509         * bindings/js/JSInspectorFrontendHostCustom.cpp:
2510         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
2511         * dom/SelectElement.cpp:
2512         * loader/cache/CachedFont.cpp:
2513         * page/EventHandler.cpp:
2514         * page/chromium/EventHandlerChromium.cpp:
2515         * platform/Scrollbar.cpp:
2516         * platform/chromium/PlatformBridge.h:
2517         * platform/graphics/chromium/FontPlatformData.h:
2518         * platform/graphics/skia/FontCustomPlatformData.cpp:
2519         * platform/graphics/skia/FontCustomPlatformData.h:
2520
2521 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2522
2523         Reviewed by Dan Bernstein.
2524
2525         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
2526         https://bugs.webkit.org/show_bug.cgi?id=49111
2527
2528         Even when the offset corresponds to a position visually left of the box
2529         and there aren't any inline boxes on the left, the previous/next position
2530         may still correspond to some position in the same line.
2531
2532         The bug was caused by our ignoring such cases. Fixed the bug by comparing
2533         previous/next position's inline box to the current box. If they match,
2534         then we stay on the same position because moving to the left visually at
2535         the left edge should not result in a position on the same line.
2536
2537         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
2538         the left edge or to the right edge, and a bug that WebKit could not move to
2539         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
2540
2541         Test cases are added to editing/selection/move-left-right.html
2542
2543         * editing/VisiblePosition.cpp:
2544         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
2545         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
2546
2547 2011-04-26  Gabor Loki  <loki@webkit.org>
2548
2549         Reviewed by Csaba Osztrogon√°c.
2550
2551         Speeding up SVG filters with multicore (SMP) support
2552         https://bugs.webkit.org/show_bug.cgi?id=43903
2553
2554         Some SVG filters execute a huge number of pixel manipulations, which
2555         cannot be sped up by graphics accelerators, since their algorithm is
2556         too complex. Using the power of Symmetric Multi Processing (SMP) we
2557         can split up a task to smaller (data independent) tasks, which can be
2558         executed independently.
2559
2560         The ParallelJobs framework provides a simple way for distributed
2561         programming. The framework is based on WebKit's threading infrastructure,
2562         Open Multi-Processing's (OpenMP) API, and libdispatch API.
2563
2564         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
2565         * platform/graphics/filters/FETurbulence.cpp:
2566         (WebCore::FETurbulence::PaintingData::PaintingData):
2567         (WebCore::FETurbulence::noise2D):
2568         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
2569         (WebCore::FETurbulence::fillRegion):
2570         (WebCore::FETurbulence::fillRegionWorker):
2571         (WebCore::FETurbulence::apply):
2572         * platform/graphics/filters/FETurbulence.h:
2573
2574 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2575
2576         Reviewed by Yury Semikhatsky.
2577
2578         Web Inspector: close button is off in docked mode on a mac.
2579         https://bugs.webkit.org/show_bug.cgi?id=59453
2580
2581         * inspector/front-end/inspector.css:
2582         (.toolbar-item.close-left):
2583
2584 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2585
2586         Reviewed by Yury Semikhatsky.
2587
2588         Web Inspector: New Style is not working (UI glitch)
2589         https://bugs.webkit.org/show_bug.cgi?id=59451
2590
2591         * inspector/InspectorDOMStorageAgent.cpp:
2592         (WebCore::InspectorDOMStorageAgent::setFrontend):
2593         * inspector/front-end/AuditRules.js:
2594         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
2595         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
2596         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
2597         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
2598         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
2599         * inspector/front-end/CSSStyleModel.js:
2600         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
2601         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
2602         (WebInspector.CSSStyleModel.prototype.addRule):
2603         (WebInspector.CSSStyleModel.prototype.addRule.callback):
2604         (WebInspector.CSSStyleModel.prototype._documentElementId):
2605         * inspector/front-end/DOMAgent.js:
2606         (WebInspector.DOMNode.prototype._addAttribute):
2607         (WebInspector.DOMNode.prototype.documentElement):
2608         * inspector/front-end/ResourceTreeModel.js:
2609         (WebInspector.PageDispatcher.prototype.frameDetached):
2610         * inspector/front-end/StylesSidebarPane.js:
2611         (WebInspector.StylesSidebarPane.prototype._createNewRule):
2612
2613 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2614
2615         Reviewed by Yury Semikhatsky.
2616
2617         Web Inspector: introduce DOMStorage::enable and disable.
2618         https://bugs.webkit.org/show_bug.cgi?id=59445
2619
2620         * inspector/Inspector.json:
2621         * inspector/InspectorAgent.cpp:
2622         (WebCore::InspectorAgent::InspectorAgent):
2623         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2624         * inspector/InspectorDOMStorageAgent.cpp:
2625         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2626         (WebCore::InspectorDOMStorageAgent::restore):
2627         (WebCore::InspectorDOMStorageAgent::enable):
2628         (WebCore::InspectorDOMStorageAgent::disable):
2629         * inspector/InspectorDOMStorageAgent.h:
2630         (WebCore::InspectorDOMStorageAgent::create):
2631         * inspector/front-end/DOMStorage.js:
2632         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2633         * inspector/front-end/ResourcesPanel.js:
2634         (WebInspector.ResourcesPanel.prototype._reset):
2635         * inspector/front-end/inspector.js:
2636
2637 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2638
2639         Reviewed by Yury Semikhatsky.
2640
2641         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
2642         https://bugs.webkit.org/show_bug.cgi?id=59440
2643
2644         * inspector/Inspector.json:
2645         * inspector/InspectorAgent.cpp:
2646         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2647         * inspector/InspectorPageAgent.cpp:
2648         (WebCore::InspectorPageAgent::setFrontend):
2649         (WebCore::InspectorPageAgent::frameNavigated):
2650         * inspector/InspectorPageAgent.h:
2651         * inspector/front-end/AuditsPanel.js:
2652         (WebInspector.AuditsPanel):
2653         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
2654         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
2655         * inspector/front-end/CSSStyleModel.js:
2656         (WebInspector.CSSStyleModelResourceBinding):
2657         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
2658         * inspector/front-end/DOMBreakpointsSidebarPane.js:
2659         (WebInspector.DOMBreakpointsSidebarPane):
2660         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
2661         * inspector/front-end/DOMStorage.js:
2662         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2663         * inspector/front-end/ExtensionServer.js:
2664         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
2665         (WebInspector.ExtensionServer.prototype.initExtensions):
2666         * inspector/front-end/NetworkPanel.js:
2667         (WebInspector.NetworkPanel):
2668         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
2669         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
2670         (WebInspector.NetworkPanel.prototype._frameNavigated):
2671         * inspector/front-end/ResourceTreeModel.js:
2672         (WebInspector.ResourceTreeModel):
2673         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2674         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
2675         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2676         (WebInspector.ResourceTreeModel.prototype._frameDetached):
2677         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
2678         (WebInspector.PageDispatcher):
2679         (WebInspector.PageDispatcher.prototype.domContentEventFired):
2680         (WebInspector.PageDispatcher.prototype.loadEventFired):
2681         (WebInspector.PageDispatcher.prototype.frameNavigated):
2682         (WebInspector.PageDispatcher.prototype.frameDetached):
2683         * inspector/front-end/ResourcesPanel.js:
2684         (WebInspector.ResourcesPanel):
2685         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
2686         (WebInspector.ResourcesPanel.prototype._frameNavigated):
2687         * inspector/front-end/inspector.js:
2688
2689 2011-04-26  Csaba Osztrogon√°c  <ossy@webkit.org>
2690
2691         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
2692         because it broke transitions/multiple-text-shadow-transition.html
2693
2694         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2695         https://bugs.webkit.org/show_bug.cgi?id=59377
2696
2697         * css/CSSStyleSelector.cpp:
2698         (WebCore::CSSStyleSelector::applyProperty):
2699         * page/animation/AnimationBase.cpp:
2700         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2701         (WebCore::PropertyWrapperShadow::blend):
2702         * rendering/style/RenderStyle.cpp:
2703         (WebCore::RenderStyle::setTextShadow):
2704         (WebCore::RenderStyle::setBoxShadow):
2705         * rendering/style/RenderStyle.h:
2706         (WebCore::InheritedFlags::textShadow):
2707         * rendering/style/StyleRareInheritedData.cpp:
2708         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2709         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2710         * rendering/style/StyleRareInheritedData.h:
2711         * rendering/style/StyleRareNonInheritedData.cpp:
2712         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2713
2714 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2715
2716         Reviewed by Adam Barth.
2717
2718         Turn off make built-in implicit rules for derived sources makefile
2719         https://bugs.webkit.org/show_bug.cgi?id=59418
2720
2721         We don't use any of make's built-in implicit rules, turning them off
2722         speeds up parsing of the makefile.
2723
2724         * WebCore.xcodeproj/project.pbxproj:
2725         * gyp/generate-derived-sources.sh:
2726
2727 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
2728
2729         Reviewed by Nikolas Zimmermann.
2730
2731         ASSERT failure in SVGUseElement
2732         https://bugs.webkit.org/show_bug.cgi?id=59313
2733
2734         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
2735         was wrong because the document may not be well-formed.
2736
2737         This patch asserts the element is not pending on resource or the
2738         document is not well-formed.
2739
2740         Test: svg/custom/use-crash-in-non-wellformed-document.svg
2741
2742         * svg/SVGUseElement.cpp:
2743         (WebCore::isWellFormedDocument):
2744         (WebCore::SVGUseElement::insertedIntoDocument):
2745
2746 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
2747
2748         Reviewed by Pavel Feldman.
2749
2750         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
2751         https://bugs.webkit.org/show_bug.cgi?id=59438
2752
2753         * inspector/front-end/DetailedHeapshotView.js:
2754         (WebInspector.DetailedHeapshotView.prototype._changeView):
2755
2756 2011-04-26  David Levin  <levin@chromium.org>
2757
2758         Reviewed by Adam Barth.
2759
2760         Fix a few OwnPtr strict errors in WebCore headers.
2761         https://bugs.webkit.org/show_bug.cgi?id=59431
2762
2763         * bindings/js/ScheduledAction.cpp:
2764         (WebCore::ScheduledAction::create):
2765         * css/MediaQueryMatcher.cpp:
2766         (WebCore::MediaQueryMatcher::prepareEvaluator):
2767         * dom/NodeRareData.h:
2768         (WebCore::NodeListsNodeData::create):
2769         * dom/ScriptRunner.h:
2770         (WebCore::ScriptRunner::create):
2771         * inspector/WorkerInspectorController.cpp:
2772         (WebCore::WorkerInspectorController::connectFrontend):
2773         * loader/icon/IconDatabase.h:
2774         (WebCore::IconDatabase::create):
2775         * platform/graphics/SimpleFontData.cpp:
2776         (WebCore::SimpleFontData::verticalRightOrientationFontData):
2777         (WebCore::SimpleFontData::uprightOrientationFontData):
2778         (WebCore::SimpleFontData::brokenIdeographFontData):
2779         * rendering/style/StyleRareInheritedData.cpp:
2780         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2781         * rendering/svg/SVGResources.h:
2782         (WebCore::SVGResources::ClipperFilterMaskerData::create):
2783         (WebCore::SVGResources::MarkerData::create):
2784         (WebCore::SVGResources::FillStrokeData::create):
2785         * storage/StorageSyncManager.cpp:
2786         (WebCore::StorageSyncManager::close):
2787         * workers/WorkerContext.cpp:
2788         (WebCore::CloseWorkerContextTask::create):
2789         * workers/WorkerMessagingProxy.cpp:
2790         (WebCore::MessageWorkerContextTask::create):
2791         (WebCore::MessageWorkerTask::create):
2792         (WebCore::WorkerExceptionTask::create):
2793         (WebCore::WorkerContextDestroyedTask::create):
2794         (WebCore::WorkerTerminateTask::create):
2795         (WebCore::WorkerThreadActivityReportTask::create):
2796         * workers/WorkerRunLoop.cpp:
2797         (WebCore::WorkerRunLoop::Task::create):
2798         * workers/WorkerThread.cpp:
2799         (WebCore::WorkerThreadStartupData::create):
2800         (WebCore::WorkerThreadShutdownFinishTask::create):
2801         (WebCore::WorkerThreadShutdownStartTask::create):
2802
2803 2011-04-26  Adam Klein  <adamk@chromium.org>
2804
2805         Reviewed by Adam Barth.
2806
2807         Fix last strict OwnPtr violation under svg/...
2808         https://bugs.webkit.org/show_bug.cgi?id=59429
2809
2810         * svg/SVGDocumentExtensions.cpp:
2811         (WebCore::SVGDocumentExtensions::removePendingResource):
2812
2813 2011-04-26  Adam Barth  <abarth@webkit.org>
2814
2815         Reviewed by David Levin.
2816
2817         Fix more strict OwnPtr violations in WebCore
2818         https://bugs.webkit.org/show_bug.cgi?id=59433
2819
2820         These manifest in the Chromium build.
2821
2822         * bindings/v8/ScriptController.cpp:
2823         (WebCore::ScriptController::ScriptController):
2824         * bindings/v8/ScriptDebugServer.cpp:
2825         (WebCore::ScriptDebugServer::editScriptSource):
2826         * bindings/v8/V8DOMMap.cpp:
2827         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
2828         * bindings/v8/V8Proxy.cpp:
2829         (WebCore::V8Proxy::precompileScript):
2830         * bindings/v8/WorkerScriptController.cpp:
2831         (WebCore::WorkerScriptController::WorkerScriptController):
2832         * page/Page.cpp:
2833         (WebCore::Page::Page):
2834         (WebCore::Page::speechInput):
2835         * platform/PlatformGestureRecognizer.cpp:
2836         (WebCore::PlatformGestureRecognizer::create):
2837         * platform/PlatformGestureRecognizer.h:
2838         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2839         (WebCore::DrawingBuffer::DrawingBuffer):
2840         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2841         (WebCore::CCLayerImpl::CCLayerImpl):
2842         * platform/graphics/gpu/Texture.cpp:
2843         (WebCore::Texture::create):
2844         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
2845         (WebCore::BMPImageDecoder::decodeHelper):
2846         * platform/image-decoders/gif/GIFImageDecoder.cpp:
2847         (WebCore::GIFImageDecoder::decode):
2848         * platform/image-decoders/ico/ICOImageDecoder.cpp:
2849         (WebCore::ICOImageDecoder::decodeAtIndex):
2850         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
2851         (WebCore::JPEGImageDecoder::decode):
2852         * platform/image-decoders/png/PNGImageDecoder.cpp:
2853         (WebCore::PNGImageDecoder::decode):
2854         * storage/chromium/DatabaseTrackerChromium.cpp:
2855         (WebCore::DatabaseTracker::addOpenDatabase):
2856
2857 2011-04-25  David Levin  <levin@chromium.org>
2858
2859         Reviewed by Adam Barth.
2860
2861         Fix OwnPtr strict errors in CrossThreadTask.h
2862         https://bugs.webkit.org/show_bug.cgi?id=59427
2863
2864         * dom/CrossThreadTask.h:
2865         (WebCore::CrossThreadTask1::create):
2866         (WebCore::CrossThreadTask2::create):
2867         (WebCore::CrossThreadTask3::create):
2868         (WebCore::CrossThreadTask4::create):
2869         (WebCore::CrossThreadTask5::create):
2870         (WebCore::CrossThreadTask6::create):
2871         (WebCore::CrossThreadTask7::create):
2872         (WebCore::CrossThreadTask8::create):
2873
2874 2011-04-25  Mark Rowe  <mrowe@apple.com>
2875
2876         Reviewed by Dan Bernstein.
2877
2878         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
2879
2880         * css/CSSStyleApplyProperty.cpp:
2881         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
2882         * css/CSSStyleApplyProperty.h:
2883         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
2884
2885 2011-04-25  Levi Weintraub  <leviw@chromium.org>
2886
2887         Reviewed by Ryosuke Niwa.
2888
2889         REGRESSION: a character appears after tab span when typing immediately before the tab span
2890         https://bugs.webkit.org/show_bug.cgi?id=58132
2891
2892         Correcting the order of operations we use to avoid inserting into invalid positions in
2893         ReplaceSelectionCommand to avoid inserting into tab-spans.
2894
2895         Test: editing/pasteboard/paste-before-tab-span.html
2896
2897         * editing/ReplaceSelectionCommand.cpp:
2898         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
2899         positionAvoidingPrecedingNodes, since that function could once again put our position
2900         inside a tab span.
2901
2902 2011-04-25  David Levin  <levin@chromium.org>
2903
2904         Reviewed by Adam Barth.
2905
2906         Fix OwnPtr strict error in ImageBuffer.h
2907         https://bugs.webkit.org/show_bug.cgi?id=59422
2908
2909         * platform/graphics/ImageBuffer.h:
2910         (WebCore::ImageBuffer::create):
2911
2912 2011-04-25  Adam Barth  <abarth@webkit.org>
2913
2914         Reviewed by David Levin.
2915
2916         Fix strict OwnPtr violations and whitelist known-tricky files
2917         https://bugs.webkit.org/show_bug.cgi?id=59421
2918
2919         With this patch, WebCore builds cleanly with strict OwnPtrs.
2920
2921         * dom/MessagePort.cpp:
2922         (WebCore::MessagePort::MessagePort):
2923         * dom/XMLDocumentParserLibxml2.cpp:
2924         * page/ContextMenuController.cpp:
2925         (WebCore::ContextMenuController::ContextMenuController):
2926         (WebCore::ContextMenuController::clearContextMenu):
2927         * page/PluginHalter.cpp:
2928         * platform/graphics/MediaPlayer.cpp:
2929         * platform/network/ResourceRequestBase.cpp:
2930         (WebCore::ResourceRequestBase::adopt):
2931         (WebCore::ResourceRequestBase::copyData):
2932         * svg/SVGDocumentExtensions.cpp:
2933
2934 2011-04-25  David Levin  <levin@chromium.org>
2935
2936         Reviewed by Adam Barth.
2937
2938         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
2939         https://bugs.webkit.org/show_bug.cgi?id=59419
2940
2941         * dom/DatasetDOMStringMap.h:
2942         (WebCore::DatasetDOMStringMap::create):
2943
2944 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2945
2946         Reviewed by Eric Seidel.
2947
2948         KeyboardEvent.cpp should work with strict OwnPtrs.
2949         https://bugs.webkit.org/show_bug.cgi?id=59403
2950
2951         * dom/KeyboardEvent.cpp:
2952         (WebCore::KeyboardEvent::KeyboardEvent):
2953
2954 2011-04-25  James Robinson  <jamesr@chromium.org>
2955
2956         Reviewed by Eric Seidel.
2957
2958         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2959         https://bugs.webkit.org/show_bug.cgi?id=59377
2960
2961         * css/CSSStyleSelector.cpp:
2962         (WebCore::CSSStyleSelector::applyProperty):
2963         * page/animation/AnimationBase.cpp:
2964         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2965         (WebCore::PropertyWrapperShadow::blend):
2966         * rendering/style/RenderStyle.cpp:
2967         (WebCore::RenderStyle::setTextShadow):
2968         (WebCore::RenderStyle::setBoxShadow):
2969         * rendering/style/RenderStyle.h:
2970         (WebCore::InheritedFlags::textShadow):
2971         * rendering/style/StyleRareInheritedData.cpp:
2972         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2973         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2974         * rendering/style/StyleRareInheritedData.h:
2975         * rendering/style/StyleRareNonInheritedData.cpp:
2976         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2977
2978 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2979
2980         Unreviewed, rolling out r84864.
2981         http://trac.webkit.org/changeset/84864
2982         https://bugs.webkit.org/show_bug.cgi?id=59413
2983
2984         Expect result of use-crash-in-non-wellformed-document.svg is
2985         platform dependent (Requested by leoyang on #webkit).
2986
2987         * svg/SVGUseElement.cpp:
2988         (WebCore::SVGUseElement::insertedIntoDocument):
2989
2990 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
2991
2992         Reviewed by Nikolas Zimmermann.
2993
2994         ASSERT failure in SVGUseElement
2995         https://bugs.webkit.org/show_bug.cgi?id=59313
2996
2997         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
2998         was wrong because the document may not be well-formed.
2999
3000         This patch asserts the element is not pending on resource or the
3001         document is not well-formed.
3002
3003         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3004
3005         * svg/SVGUseElement.cpp:
3006         (WebCore::isWellFormedDocument):
3007         (WebCore::SVGUseElement::insertedIntoDocument):
3008
3009 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3010
3011         Reviewed by Tony Chang.
3012
3013         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3014         https://bugs.webkit.org/show_bug.cgi?id=59028
3015
3016         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3017         Moving the code for base class we can reduce the efforts to support DataTransferItems
3018         element in different platforms.
3019
3020         * Android.mk:
3021         * CMakeLists.txt:
3022         * GNUmakefile.list.am:
3023         * WebCore.gypi:
3024         * WebCore.pro:
3025         * WebCore.vcproj/WebCore.vcproj:
3026         * WebCore.xcodeproj/project.pbxproj:
3027         * dom/DataTransferItem.cpp:
3028         (WebCore::DataTransferItem::DataTransferItem):
3029         (WebCore::DataTransferItem::owner):
3030         (WebCore::DataTransferItem::kind):
3031         (WebCore::DataTransferItem::type):
3032         * dom/DataTransferItem.h:
3033         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3034         (WebCore::DataTransferItems::DataTransferItems):
3035         (WebCore::DataTransferItems::length):
3036         (WebCore::DataTransferItems::item):
3037         (WebCore::DataTransferItems::deleteItem):
3038         (WebCore::DataTransferItems::clear):
3039         (WebCore::DataTransferItems::add):
3040         * dom/DataTransferItems.h:
3041         * platform/chromium/DataTransferItemChromium.cpp:
3042         (WebCore::DataTransferItem::create):
3043         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3044         (WebCore::DataTransferItemChromium::getAsString):
3045         (WebCore::DataTransferItemChromium::getAsFile):
3046         * platform/chromium/DataTransferItemChromium.h:
3047         * platform/chromium/DataTransferItemsChromium.cpp:
3048         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3049         * platform/chromium/DataTransferItemsChromium.h:
3050
3051 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3052
3053         Reviewed by Simon Fraser.
3054
3055         REGRESSION(75137): directly composited images are double-drawn sometimes
3056         https://bugs.webkit.org/show_bug.cgi?id=58632
3057
3058         Depending on the order of operations (layout, creating compositing 
3059         layers and creating simple image layers) a layer can have both image
3060         content and have m_drawsContent=true. In this case 2 copies of the image
3061         are drawn in the layer. If the image has alpha, it looks wrong.
3062
3063         I added an updateDrawsContent() call after setting the image contents
3064         to make sure it's correct.
3065
3066         I couldn't create a test case that shows the problem because layerTreeAsText()
3067         doesn't emit enough info to show this level of detail. I've opened
3068         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3069
3070         * rendering/RenderLayerBacking.cpp:
3071         (WebCore::RenderLayerBacking::updateImageContents):
3072
3073 2011-04-25  Kenneth Russell  <kbr@google.com>
3074
3075         Reviewed by David Levin.
3076
3077         Fix OwnPtr strict errors in InlineFlowBox.cpp
3078         https://bugs.webkit.org/show_bug.cgi?id=59392
3079
3080         * rendering/InlineFlowBox.cpp:
3081         (WebCore::InlineFlowBox::setLayoutOverflow):
3082         (WebCore::InlineFlowBox::setVisualOverflow):
3083
3084 2011-04-25  Kenneth Russell  <kbr@google.com>
3085
3086         Reviewed by David Levin.
3087
3088         Fix OwnPtr strict errors in TransformState.cpp
3089         https://bugs.webkit.org/show_bug.cgi?id=59380
3090
3091         * rendering/TransformState.cpp:
3092         (WebCore::TransformState::applyTransform):
3093
3094 2011-04-25  Adam Barth  <abarth@webkit.org>
3095
3096         Reviewed by James Robinson.
3097
3098         DOMWindow.cpp should work with strict OwnPtrs
3099         https://bugs.webkit.org/show_bug.cgi?id=59356
3100
3101         * page/DOMWindow.cpp:
3102         (WebCore::PostMessageTimer::fired):
3103         (WebCore::DOMWindow::postMessageTimerFired):
3104         * page/DOMWindow.h:
3105
3106 2011-04-25  Adam Klein  <adamk@chromium.org>
3107
3108         Reviewed by James Robinson.
3109
3110         Fix OwnPtr strict errors in some SVG classes.
3111         https://bugs.webkit.org/show_bug.cgi?id=59395
3112
3113         * rendering/style/SVGRenderStyleDefs.cpp:
3114         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3115         * svg/SVGSVGElement.cpp:
3116         (WebCore::SVGSVGElement::SVGSVGElement):
3117         * svg/SVGStyledTransformableElement.cpp:
3118         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3119         * svg/SVGTextElement.cpp:
3120         (WebCore::SVGTextElement::supplementalTransform):
3121         * svg/graphics/SVGImage.cpp:
3122         (WebCore::SVGImage::dataChanged):
3123
3124 2011-04-25  Adam Barth  <abarth@webkit.org>
3125
3126         Re-land changes to ValidationMessage.
3127
3128         * html/ValidationMessage.cpp:
3129         (WebCore::ValidationMessage::setMessage):
3130         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3131         (WebCore::ValidationMessage::requestToHideMessage):
3132
3133 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3134
3135         Reviewed by James Robinson.
3136
3137         fix OwnPtr strict error in FrameView.cpp
3138         https://bugs.webkit.org/show_bug.cgi?id=59402
3139
3140         * page/FrameView.cpp:
3141         (WebCore::FrameView::FrameView):
3142         (WebCore::FrameView::addWidgetToUpdate):
3143
3144 2011-04-25  Adam Klein  <adamk@chromium.org>
3145
3146         Unreviewed, rolling out r84844.
3147         http://trac.webkit.org/changeset/84844
3148         https://bugs.webkit.org/show_bug.cgi?id=59395
3149
3150         Checked in too much.
3151
3152         * rendering/style/SVGRenderStyleDefs.cpp:
3153         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3154         * svg/SVGDocumentExtensions.cpp:
3155         (WebCore::SVGDocumentExtensions::removePendingResource):
3156         * svg/SVGSVGElement.cpp:
3157         (WebCore::SVGSVGElement::SVGSVGElement):
3158         * svg/SVGStyledTransformableElement.cpp:
3159         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3160         * svg/SVGTextElement.cpp:
3161         (WebCore::SVGTextElement::supplementalTransform):
3162         * svg/graphics/SVGImage.cpp:
3163         (WebCore::SVGImage::dataChanged):
3164
3165 2011-04-25  Adrienne Walker  <enne@google.com>
3166
3167         Reviewed by David Levin.
3168
3169         Make ActiveDOMCallback play nice with OwnPtr strict mode
3170         https://bugs.webkit.org/show_bug.cgi?id=59398
3171
3172         * bindings/generic/ActiveDOMCallback.cpp:
3173         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
3174
3175 2011-04-25  Adam Klein  <adamk@chromium.org>
3176
3177         Reviewed by James Robinson.
3178
3179         Fix OwnPtr strict errors in some SVG classes.
3180         https://bugs.webkit.org/show_bug.cgi?id=59395
3181
3182         * rendering/style/SVGRenderStyleDefs.cpp:
3183         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3184         * svg/SVGSVGElement.cpp:
3185         (WebCore::SVGSVGElement::SVGSVGElement):
3186         * svg/SVGStyledTransformableElement.cpp:
3187         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3188         * svg/SVGTextElement.cpp:
3189         (WebCore::SVGTextElement::supplementalTransform):
3190         * svg/graphics/SVGImage.cpp:
3191         (WebCore::SVGImage::dataChanged):
3192
3193 2011-04-25  James Robinson  <jamesr@chromium.org>
3194
3195         Unreviewed, rolling out r84835.
3196         http://trac.webkit.org/changeset/84835
3197         https://bugs.webkit.org/show_bug.cgi?id=59394
3198
3199         Breaks compile because Deque<OwnPtr> doesn't work
3200
3201         * dom/XMLDocumentParserLibxml2.cpp:
3202         (WebCore::PendingCallbacks::~PendingCallbacks):
3203         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3204         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3205         (WebCore::PendingCallbacks::appendCharactersCallback):
3206         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3207         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3208         (WebCore::PendingCallbacks::appendCommentCallback):
3209         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3210         (WebCore::PendingCallbacks::appendErrorCallback):
3211         (WebCore::XMLDocumentParser::XMLDocumentParser):
3212         * html/ValidationMessage.cpp:
3213         (WebCore::ValidationMessage::setMessage):
3214         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3215         (WebCore::ValidationMessage::requestToHideMessage):
3216
3217 2011-04-25  James Robinson  <jamesr@chromium.org>
3218
3219         Reviewed by Sam Weinig.
3220
3221         Fix OwnPtr strict mode violation in ImageBufferCG
3222         https://bugs.webkit.org/show_bug.cgi?id=59396
3223
3224         * platform/graphics/cg/ImageBufferCG.cpp:
3225         (WebCore::ImageBuffer::ImageBuffer):
3226
3227 2011-04-25  Huang Dongsung  <luxtella@company100.net>
3228
3229         Reviewed by Dirk Schulze.
3230
3231         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
3232         https://bugs.webkit.org/show_bug.cgi?id=59308
3233
3234         An unused local variable is created and even allocates heap memory.
3235
3236         * platform/graphics/skia/PlatformContextSkia.cpp:
3237         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
3238
3239 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3240
3241         Qt build fix: Updated files not used by other ports for rename.
3242
3243         * bindings/js/JSTouchCustom.cpp:
3244         (WebCore::toJSNewlyCreated):
3245         * bindings/js/JSTouchListCustom.cpp:
3246         (WebCore::toJSNewlyCreated):
3247
3248 2011-04-25  Adrienne Walker  <enne@google.com>
3249
3250         Reviewed by David Levin.
3251
3252         WebCore/css/CSS* files should play nice with strict OwnPtrs
3253         https://bugs.webkit.org/show_bug.cgi?id=59382
3254
3255         * css/CSSFontFaceSource.cpp:
3256         (WebCore::CSSFontFaceSource::getFontData):
3257         * css/CSSParser.cpp:
3258         (WebCore::CSSParser::addProperty):
3259         (WebCore::CSSParser::parseValue):
3260
3261 2011-04-25  Adam Barth  <abarth@webkit.org>
3262
3263         Reviewed by James Robinson.
3264
3265         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
3266         https://bugs.webkit.org/show_bug.cgi?id=59394
3267
3268         * dom/XMLDocumentParserLibxml2.cpp:
3269         (WebCore::PendingCallbacks::PendingCallbacks):
3270         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3271         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3272         (WebCore::PendingCallbacks::appendCharactersCallback):
3273         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3274         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3275         (WebCore::PendingCallbacks::appendCommentCallback):
3276         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3277         (WebCore::PendingCallbacks::appendErrorCallback):
3278         (WebCore::XMLDocumentParser::XMLDocumentParser):
3279         * html/ValidationMessage.cpp:
3280         (WebCore::ValidationMessage::setMessage):
3281         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3282         (WebCore::ValidationMessage::requestToHideMessage):
3283
3284 2011-04-25  James Robinson  <jamesr@chromium.org>
3285
3286         Reviewed by Adam Barth.
3287
3288         Fix OwnPtr strictness issues in WebCore/inspector/
3289         https://bugs.webkit.org/show_bug.cgi?id=59387
3290
3291         * inspector/InspectorAgent.cpp:
3292         (WebCore::InspectorAgent::InspectorAgent):
3293         * inspector/InspectorController.cpp:
3294         (WebCore::InspectorController::InspectorController):
3295         * inspector/InspectorStyleSheet.cpp:
3296         (WebCore::InspectorStyleSheet::ensureSourceData):
3297
3298 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3299
3300         Reviewed by Beth Dakin.
3301
3302         Removed XPathNamespace because it was unused
3303         https://bugs.webkit.org/show_bug.cgi?id=59381
3304         
3305         This allows us to make Node::ownerDocument() non-virtual, though it has
3306         the unhappy side-effect of rebuilding the world.
3307
3308         * CMakeLists.txt:
3309         * GNUmakefile.list.am:
3310         * WebCore.gypi:
3311         * WebCore.pro:
3312         * WebCore.vcproj/WebCore.vcproj:
3313         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
3314
3315         * dom/Node.h: Hello fast code!
3316
3317         * xml/XPathNamespace.cpp: Removed.
3318         * xml/XPathNamespace.h: Removed.
3319
3320 2011-04-25  Adam Barth  <abarth@webkit.org>
3321
3322         Reviewed by Darin Adler.
3323
3324         HistoryItemMac should play nice with OwnPtrs
3325         https://bugs.webkit.org/show_bug.cgi?id=59388
3326
3327         * history/mac/HistoryItemMac.mm:
3328         (WebCore::HistoryItem::setTransientProperty):
3329
3330 2011-04-25  David Levin  <levin@chromium.org>
3331
3332         Reviewed by Kenneth Russell.
3333
3334         Fix strict OwnPtrs in ContextMenuController.cpp
3335         https://bugs.webkit.org/show_bug.cgi?id=59375
3336
3337         * page/ContextMenuController.cpp:
3338         (WebCore::ContextMenuController::createContextMenu):
3339         (WebCore::separatorItem):
3340
3341 2011-04-25  Adam Barth  <abarth@webkit.org>
3342
3343         Reviewed by Darin Adler.
3344
3345         CheckedRadioButton should play nice with strict OwnPtr
3346         https://bugs.webkit.org/show_bug.cgi?id=59386
3347
3348         * dom/CheckedRadioButtons.cpp:
3349         (WebCore::CheckedRadioButtons::addButton):
3350
3351 2011-04-25  Adam Barth  <abarth@webkit.org>
3352
3353         Reviewed by David Levin.
3354
3355         Resource*.cpp should play nice with strict OwnPtrs
3356         https://bugs.webkit.org/show_bug.cgi?id=59383
3357
3358         * bridge/runtime_method.cpp:
3359         (JSC::RuntimeMethod::RuntimeMethod):
3360         * platform/network/ResourceHandle.cpp:
3361         (WebCore::ResourceHandle::ResourceHandle):
3362         * platform/network/ResourceResponseBase.cpp:
3363         (WebCore::ResourceResponseBase::adopt):
3364         (WebCore::ResourceResponseBase::copyData):
3365
3366 2011-04-25  Adam Barth  <abarth@webkit.org>
3367
3368         Reviewed by David Levin.
3369
3370         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
3371         https://bugs.webkit.org/show_bug.cgi?id=59374
3372
3373         * bridge/objc/objc_runtime.mm:
3374         (JSC::Bindings::callObjCFallbackObject):
3375         * page/Page.cpp:
3376         (WebCore::Page::Page):
3377         (WebCore::Page::initGroup):
3378         * page/PageGroup.cpp:
3379         (WebCore::PageGroup::addUserScriptToWorld):
3380         (WebCore::PageGroup::addUserStyleSheetToWorld):
3381         * page/mac/PageMac.cpp:
3382         (WebCore::Page::addSchedulePair):
3383
3384 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3385
3386         Build fix: This time for sure!
3387         
3388         * dom/make_names.pl:
3389
3390 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3391
3392         Build fix: Let's edit the script instead of the autogenrated file. That
3393         way, our change will stand the test of time.
3394
3395         * dom/make_names.pl:
3396
3397 2011-04-25  Adam Barth  <abarth@webkit.org>
3398
3399         Reviewed by David Levin.
3400
3401         Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
3402         https://bugs.webkit.org/show_bug.cgi?id=59368
3403
3404         * html/HTMLMediaElement.cpp:
3405         (WebCore::HTMLMediaElement::HTMLMediaElement):
3406         * platform/network/HTTPHeaderMap.cpp:
3407         (WebCore::HTTPHeaderMap::copyData):
3408
3409 2011-04-25  James Robinson  <jamesr@chromium.org>
3410
3411         Reviewed by Adam Barth.
3412
3413         Fix strict OwnPtr violations in Render*.cpp
3414         https://bugs.webkit.org/show_bug.cgi?id=59361
3415
3416         * rendering/RenderBlock.cpp:
3417         (WebCore::RenderBlock::RenderBlock):
3418         (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
3419         * rendering/RenderBox.cpp:
3420         (WebCore::RenderBox::addLayoutOverflow):
3421         (WebCore::RenderBox::addVisualOverflow):
3422         * rendering/RenderButton.cpp:
3423         (WebCore::RenderButton::styleDidChange):
3424         * rendering/RenderLayer.cpp:
3425         (WebCore::RenderLayer::updateTransform):
3426         (WebCore::RenderLayer::paintChildLayerIntoColumns):
3427         (WebCore::RenderLayer::hitTestChildLayerColumns):
3428         (WebCore::RenderLayer::ensureBacking):
3429         * rendering/RenderTable.cpp:
3430         (WebCore::RenderTable::styleDidChange):
3431         * rendering/RenderView.cpp:
3432         (WebCore::RenderView::compositor):
3433         * rendering/style/RenderStyle.cpp:
3434         (WebCore::RenderStyle::addCachedPseudoStyle):
3435         (WebCore::RenderStyle::accessCounterDirectives):
3436         (WebCore::RenderStyle::accessAnimations):
3437         (WebCore::RenderStyle::accessTransitions):
3438         * rendering/svg/RenderSVGResourceFilter.cpp:
3439         (WebCore::RenderSVGResourceFilter::applyResource):
3440         * rendering/svg/SVGResources.cpp:
3441         (WebCore::SVGResources::SVGResources):
3442
3443 2011-04-25  Adam Barth  <abarth@webkit.org>
3444
3445         Attempt to fix the compile.
3446
3447         * platform/graphics/MediaPlayer.cpp:
3448         (WebCore::MediaPlayer::loadWithNextMediaEngine):
3449
3450 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3451
3452         Rubber-stamped by Beth Dakin.
3453
3454         Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into 
3455         CREATE_DOM_WRAPPER because there's no meaningful difference between
3456         them anymore.
3457
3458         * bindings/js/JSCDATASectionCustom.cpp:
3459         (WebCore::toJSNewlyCreated):
3460         * bindings/js/JSCSSRuleCustom.cpp:
3461         (WebCore::toJS):
3462         * bindings/js/JSCSSValueCustom.cpp:
3463         (WebCore::toJS):
3464         * bindings/js/JSDOMBinding.h:
3465         * bindings/js/JSDocumentCustom.cpp:
3466         (WebCore::toJS):
3467         * bindings/js/JSElementCustom.cpp:
3468         (WebCore::toJSNewlyCreated):
3469         * bindings/js/JSEventCustom.cpp:
3470         (WebCore::toJS):
3471         * bindings/js/JSHTMLCollectionCustom.cpp:
3472         (WebCore::toJS):
3473         * bindings/js/JSImageDataCustom.cpp:
3474         (WebCore::toJS):
3475         * bindings/js/JSNodeCustom.cpp:
3476         (WebCore::createWrapperInline):
3477         * bindings/js/JSSVGPathSegCustom.cpp:
3478         (WebCore::toJS):
3479         * bindings/js/JSStyleSheetCustom.cpp:
3480         (WebCore::toJS):
3481         * bindings/js/JSTextCustom.cpp:
3482         (WebCore::toJSNewlyCreated):
3483         * bindings/js/JSWebKitCSSMatrixCustom.cpp:
3484         (WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
3485         * bindings/js/JSWebSocketCustom.cpp:
3486         (WebCore::JSWebSocketConstructor::constructJSWebSocket):
3487         * bindings/js/JSXMLHttpRequestCustom.cpp:
3488         (WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
3489         * bindings/js/JSXSLTProcessorCustom.cpp:
3490         (WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
3491
3492 2011-04-25  Adam Barth  <abarth@webkit.org>
3493
3494         Reviewed by James Robinson.
3495
3496         HTMLDocumentParser should play nice with OwnPtrs
3497         https://bugs.webkit.org/show_bug.cgi?id=59363
3498
3499         * html/parser/HTMLDocumentParser.cpp:
3500         (WebCore::HTMLDocumentParser::pumpTokenizer):
3501
3502 2011-04-25  Adam Barth  <abarth@webkit.org>
3503
3504         Reviewed by James Robinson.
3505
3506         Frame.cpp should work with strict OwnPtrs
3507         https://bugs.webkit.org/show_bug.cgi?id=59360
3508
3509         * page/Frame.cpp:
3510         (WebCore::createRegExpForLabels):
3511
3512 2011-04-25  Adam Barth  <abarth@webkit.org>
3513
3514         Reviewed by David Levin.
3515
3516         Fix strict OwnPtr in Element.cpp
3517         https://bugs.webkit.org/show_bug.cgi?id=59357
3518
3519         * dom/NodeRareData.h:
3520         (WebCore::NodeRareData::ensureEventTargetData):
3521
3522 2011-04-25  Adam Barth  <abarth@webkit.org>
3523
3524         Reviewed by David Levin.
3525
3526         Fix strict OwnPtr issues in Media*.cpp
3527         https://bugs.webkit.org/show_bug.cgi?id=59354
3528
3529         There's still a tricky case in MediaPlayer.cpp, but we'll worry about
3530         that later.
3531
3532         * css/MediaQueryMatcher.cpp:
3533         (WebCore::MediaQueryMatcher::addListener):
3534         * dom/Document.cpp:
3535         * platform/graphics/MediaPlayer.cpp:
3536         (WebCore::createNullMediaPlayer):
3537
3538 2011-04-25  James Robinson  <jamesr@chromium.org>
3539
3540         Reviewed by David Levin.
3541
3542         Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
3543         https://bugs.webkit.org/show_bug.cgi?id=59353
3544
3545         * rendering/RenderLayerCompositor.cpp:
3546         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
3547
3548 2011-04-25  Adam Barth  <abarth@webkit.org>
3549
3550         Reviewed by James Robinson.
3551
3552         Worker*.cpp should work with strict OwnPtrs
3553         https://bugs.webkit.org/show_bug.cgi?id=59346
3554
3555         * inspector/WorkerInspectorController.cpp:
3556         (WebCore::WorkerInspectorController::WorkerInspectorController):
3557         * workers/WorkerContext.cpp:
3558         (WebCore::WorkerContext::WorkerContext):
3559         * workers/WorkerRunLoop.cpp:
3560         (WebCore::WorkerRunLoop::WorkerRunLoop):
3561         * workers/WorkerScriptLoader.cpp:
3562         (WebCore::WorkerScriptLoader::createResourceRequest):
3563
3564 2011-04-25  James Robinson  <jamesr@chromium.org>
3565
3566         Reviewed by Adam Barth.
3567
3568         Remove bad use of OwnPtr::set() in IconDatabase.cpp
3569         https://bugs.webkit.org/show_bug.cgi?id=59344
3570
3571         Needed for strict OwnPtr compliance.
3572
3573         * loader/icon/IconDatabase.cpp:
3574         (WebCore::readySQLiteStatement):
3575
3576 2011-04-25  Adam Barth  <abarth@webkit.org>
3577
3578         Reviewed by Maciej Stachowiak.
3579
3580         ImageBuffer.h should work with strict OwnPtrs
3581         https://bugs.webkit.org/show_bug.cgi?id=59341
3582
3583         This patch is to prepare for the strict OwnPtr hack-a-thon.
3584
3585         * platform/graphics/ImageBuffer.h:
3586         (WebCore::ImageBuffer::create):
3587
3588 2011-04-25  Steve Falkenburg  <sfalken@apple.com>
3589
3590         Reviewed by Brian Weinstein.
3591
3592         WebCore build on Windows should include windows.h in its precompiled header to speed builds
3593         https://bugs.webkit.org/show_bug.cgi?id=59339
3594
3595         windows.h is included by several of the underlying wtf headers, including Atomics.h and
3596         ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
3597         
3598         On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
3599         (a 12% speedup).
3600
3601         * WebCorePrefix.h: Include windows.h
3602
3603 2011-04-25  Martin Robinson  <mrobinson@igalia.com>
3604
3605         Reviewed by Xan Lopez.
3606
3607         [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
3608         https://bugs.webkit.org/show_bug.cgi?id=59311
3609
3610         * platform/gtk/MainFrameScrollbarGtk.cpp:
3611         (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar
3612         disconnect any lingering signal handlers. This prevents an adjustment from controlling the
3613         active ScrollView and some zombie ScrollView.
3614
3615 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3616
3617         Another shot at fixing the EFL build.
3618
3619         * UseJSC.cmake:
3620         * bindings/js/JSDOMBinding.cpp:
3621
3622 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3623
3624         Try to fix EFL build.
3625
3626         * UseJSC.cmake: Added a missing file.
3627
3628 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3629
3630         Reviewed by Oliver Hunt.
3631
3632         Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
3633         https://bugs.webkit.org/show_bug.cgi?id=59333
3634
3635         * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
3636
3637         * bindings/js/JSDOMBinding.cpp:
3638         * bindings/js/JSDOMBinding.h:
3639         * bindings/js/JSDocumentCustom.cpp:
3640         * bindings/js/JSWorkerContextCustom.cpp:
3641         (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
3642
3643         * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
3644         lifetime management.
3645
3646         * dom/Document.idl: No need for a custom mark function anymore, since
3647         ActiveDOMObjets now manage their own lifetimes.
3648
3649         * dom/MessagePort.cpp:
3650         (WebCore::MessagePort::hasPendingActivity): Correctly report that we
3651         have pending activity when we're remotely entangled, instead of relying
3652         on our clients to know this about us and do the check for us.
3653
3654         * dom/MessagePort.h: FIXME!
3655
3656         * dom/MessagePort.idl:
3657         * fileapi/DOMFileSystem.idl:
3658         * fileapi/FileReader.idl:
3659         * fileapi/FileWriter.idl:
3660         * notifications/Notification.idl:
3661         * notifications/NotificationCenter.idl:
3662         * page/EventSource.idl:
3663         * storage/IDBDatabase.idl:
3664         * storage/IDBRequest.idl:
3665         * storage/IDBTransaction.idl:
3666         * webaudio/AudioContext.idl:
3667         * websockets/WebSocket.idl:
3668         * workers/AbstractWorker.idl:
3669         * workers/SharedWorker.idl:
3670         * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
3671
3672         * workers/WorkerContext.cpp:
3673         (WebCore::WorkerContext::hasPendingActivity): No need to make up for
3674         MessagePort::hasPendingActivity being wrong anymore, since it's now right.
3675
3676         * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
3677
3678 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3679
3680         Reviewed by Pavel Feldman.
3681
3682         Web Inspector: worker messages should be routed to corresponding worker front-end
3683         https://bugs.webkit.org/show_bug.cgi?id=59323
3684
3685         Added WorkerManager which is responsible for routing messages between
3686         Page inspector front-end and Worker inspector front-ends.
3687
3688         * WebCore.gypi:
3689         * inspector/front-end/WebKit.qrc:
3690         * inspector/front-end/WorkerManager.js: Added.
3691         (WebInspector.WorkerManager):
3692         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend):
3693         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded):
3694         (WebInspector.WorkerManager.loaded):
3695         (WebInspector.WorkerFrontendStub):
3696         (WebInspector.WorkerFrontendStub.prototype._receiveMessage):
3697         (WebInspector.WorkerDispatcher):
3698         (WebInspector.WorkerDispatcher.prototype._receiveMessage):
3699         (WebInspector.WorkerDispatcher.prototype.workerCreated):
3700         (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
3701         * inspector/front-end/inspector.html:
3702         * inspector/front-end/inspector.js:
3703         (WebInspector.loaded):
3704
3705 2011-04-25  Annie Sullivan  <sullivan@chromium.org>
3706
3707         Reviewed by Pavel Feldman.
3708
3709         Web Inspector: [Resources panel] Should be easy to copy data.
3710         https://bugs.webkit.org/show_bug.cgi?id=45662
3711
3712         Adds context menu items to copy resource location, resource request headers, and resource response headers.
3713
3714         * inspector/front-end/NetworkPanel.js:
3715         (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
3716         (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
3717         (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
3718         (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
3719         * inspector/front-end/Resource.js:
3720         (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
3721         (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
3722
3723 2011-04-25  Alexander Pavlov  <apavlov@chromium.org>
3724
3725         Reviewed by Yury Semikhatsky.
3726
3727         Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
3728         https://bugs.webkit.org/show_bug.cgi?id=59322
3729
3730         Use TextResourceDecoder to determine external stylesheet charsets correctly.
3731
3732         Test: inspector/styles/parse-utf8-bom.html
3733
3734         * inspector/InspectorStyleSheet.cpp:
3735         (WebCore::InspectorStyleSheet::originalStyleSheetText):
3736
3737 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3738
3739         Not reviewed: Inspector.json cleanup.
3740
3741         * inspector/Inspector.json:
3742
3743 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3744
3745         Reviewed by Pavel Feldman.
3746
3747         Web Inspector: introduce InspectorWorkerAgent
3748         https://bugs.webkit.org/show_bug.cgi?id=59320
3749
3750         InspectorWorkerAgent is responsible for routing inspector messages
3751         between worker context inspector agents and corresponding worker
3752         inspector front-end.
3753
3754         * CMakeLists.txt:
3755         * GNUmakefile.list.am:
3756         * WebCore.gypi:
3757         * WebCore.pro:
3758         * WebCore.vcproj/WebCore.vcproj:
3759         * WebCore.xcodeproj/project.pbxproj:
3760         * inspector/CodeGeneratorInspector.pm:
3761         * inspector/Inspector.json:
3762         * inspector/InspectorAgent.cpp:
3763         (WebCore::InspectorAgent::InspectorAgent):
3764         (WebCore::InspectorAgent::setFrontend):
3765         (WebCore::InspectorAgent::disconnectFrontend):
3766         * inspector/InspectorAgent.h:
3767         (WebCore::InspectorAgent::workerAgent):
3768         * inspector/InspectorController.cpp:
3769         (WebCore::InspectorController::connectFrontend):
3770         (WebCore::InspectorController::disconnectFrontend):
3771         * inspector/InspectorInstrumentation.cpp:
3772         (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
3773         * inspector/InspectorInstrumentation.h:
3774         (WebCore::InspectorInstrumentation::willStartWorkerContext):
3775         (WebCore::InspectorInstrumentation::didStartWorkerContext):
3776         * inspector/InspectorWorkerAgent.cpp: Added.
3777         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
3778         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
3779         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
3780         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
3781         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
3782         (WebCore::InspectorWorkerAgent::create):
3783         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
3784         (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
3785         (WebCore::InspectorWorkerAgent::setFrontend):
3786         (WebCore::InspectorWorkerAgent::clearFrontend):
3787         (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
3788         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
3789         * inspector/InspectorWorkerAgent.h: Added.
3790         * inspector/InstrumentingAgents.h:
3791         (WebCore::InstrumentingAgents::InstrumentingAgents):
3792         (WebCore::InstrumentingAgents::inspectorWorkerAgent):
3793         (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
3794         * inspector/WorkerInspectorController.cpp:
3795         (WebCore::WorkerInspectorController::connectFrontend):
3796         * inspector/generate-inspector-idl:
3797         * workers/Worker.cpp:
3798         (WebCore::Worker::notifyFinished):
3799         * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
3800         messages sent from the inspected page worker agent to the worker context inspector agents.
3801         (WebCore::WorkerContextInspectorProxy::connectFrontend):
3802         (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
3803         (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
3804         (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
3805         * workers/WorkerContextProxy.h:
3806         (WebCore::WorkerContextProxy::inspectorProxy):
3807
3808 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3809
3810         Reviewed by Yury Semikhatsky.
3811
3812         Web Inspector: move Frame and Resource Tree management into the Page agent.
3813         https://bugs.webkit.org/show_bug.cgi?id=59321
3814
3815         Network agent should only handle network-related activities.
3816         Frame structure should be managed by the Page agent instead.
3817
3818         * inspector/Inspector.json:
3819         * inspector/InspectorAgent.cpp:
3820         (WebCore::InspectorAgent::InspectorAgent):
3821         * inspector/InspectorDOMAgent.cpp:
3822         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
3823         (WebCore::InspectorDOMAgent::setFrontend):
3824         (WebCore::InspectorDOMAgent::restore):
3825         (WebCore::InspectorDOMAgent::highlightFrame):
3826         * inspector/InspectorDOMAgent.h:
3827         (WebCore::InspectorDOMAgent::create):
3828         * inspector/InspectorInstrumentation.cpp:
3829         (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
3830         (WebCore::InspectorInstrumentation::loadEventFiredImpl):
3831         (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
3832         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
3833         * inspector/InspectorPageAgent.cpp:
3834         (WebCore::InspectorPageAgent::create):
3835         (WebCore::InspectorPageAgent::resourceContent):
3836         (WebCore::InspectorPageAgent::resourceContentBase64):
3837         (WebCore::InspectorPageAgent::resourceData):
3838         (WebCore::InspectorPageAgent::cachedResource):
3839         (WebCore::InspectorPageAgent::resourceTypeString):
3840         (WebCore::InspectorPageAgent::cachedResourceType):
3841         (WebCore::InspectorPageAgent::cachedResourceTypeString):
3842         (WebCore::InspectorPageAgent::InspectorPageAgent):
3843         (WebCore::InspectorPageAgent::setFrontend):
3844         (WebCore::InspectorPageAgent::reload):
3845         (WebCore::InspectorPageAgent::open):
3846         (WebCore::InspectorPageAgent::getCookies):
3847         (WebCore::InspectorPageAgent::deleteCookie):
3848         (WebCore::InspectorPageAgent::getResourceTree):
3849         (WebCore::InspectorPageAgent::getResourceContent):
3850         (WebCore::InspectorPageAgent::restore):
3851         (WebCore::InspectorPageAgent::domContentEventFired):
3852         (WebCore::InspectorPageAgent::loadEventFired):
3853         (WebCore::InspectorPageAgent::frameNavigated):
3854         (WebCore::InspectorPageAgent::frameDetached):
3855         (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
3856         (WebCore::InspectorPageAgent::mainFrame):
3857         (WebCore::pointerAsId):
3858         (WebCore::InspectorPageAgent::frameForId):
3859         (WebCore::InspectorPageAgent::frameId):
3860         (WebCore::InspectorPageAgent::loaderId):
3861         (WebCore::InspectorPageAgent::buildObjectForFrame):
3862         (WebCore::InspectorPageAgent::buildObjectForFrameTree):
3863         * inspector/InspectorPageAgent.h:
3864         * inspector/InspectorResourceAgent.cpp:
3865         (WebCore::buildObjectForCachedResource):
3866         (WebCore::InspectorResourceAgent::willSendRequest):
3867         (WebCore::InspectorResourceAgent::didReceiveResponse):
3868         (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
3869         (WebCore::InspectorResourceAgent::setInitialScriptContent):
3870         (WebCore::InspectorResourceAgent::setInitialXHRContent):
3871         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
3872         * inspector/InspectorResourceAgent.h:
3873         (WebCore::InspectorResourceAgent::create):
3874         * inspector/InspectorStyleSheet.cpp:
3875         (WebCore::InspectorStyleSheet::resourceStyleSheetText):
3876         * inspector/front-end/NetworkManager.js:
3877         (WebInspector.NetworkManager.prototype.requestContent):
3878         * inspector/front-end/NetworkPanel.js:
3879         (WebInspector.NetworkPanel):
3880         (WebInspector.NetworkPanel.prototype.frameNavigated):
3881         * inspector/front-end/ResourceTreeModel.js:
3882         (WebInspector.ResourceTreeModel):
3883         (WebInspector.ResourceTreeModel.prototype.frontendReused):
3884         (WebInspector.ResourceTreeModel.prototype.frameNavigated):
3885         (WebInspector.ResourceTreeModel.prototype.frameDetached):
3886         * inspector/front-end/inspector.js:
3887         (WebInspector.domContentEventFired):
3888         (WebInspector.loadEventFired):
3889         (WebInspector.frameNavigated):
3890         (WebInspector.frameDetached):
3891
3892 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3893
3894         Reviewed by Yury Semikhatsky.
3895
3896         Web Inspector: few protocol improvements.
3897         https://bugs.webkit.org/show_bug.cgi?id=59319
3898
3899         - Page domain is documented
3900         - setUserAgentOverride is moved to the Network agent
3901         - setSearchingForNode -> setInspectModeEnabled
3902         - highlightDOMNode -> highlightNode
3903         - reloadPage -> reload
3904         - openInNewWindow -> open with optional parameter
3905
3906         * inspector/Inspector.json:
3907         * inspector/InspectorDOMAgent.cpp:
3908         (WebCore::InspectorDOMAgent::setInspectModeEnabled):
3909         (WebCore::InspectorDOMAgent::highlightNode):
3910         * inspector/InspectorDOMAgent.h:
3911         (WebCore::InspectorDOMAgent::hideNodeHighlight):
3912         * inspector/InspectorInstrumentation.cpp:
3913         (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
3914         * inspector/InspectorPageAgent.cpp:
3915         (WebCore::InspectorPageAgent::clearFrontend):
3916         (WebCore::InspectorPageAgent::reload):
3917         (WebCore::InspectorPageAgent::open):
3918         * inspector/InspectorPageAgent.h:
3919         * inspector/InspectorResourceAgent.cpp:
3920         (WebCore::InspectorResourceAgent::clearFrontend):
3921         (WebCore::InspectorResourceAgent::applyUserAgentOverride):
3922         (WebCore::InspectorResourceAgent::setUserAgentOverride):
3923         * inspector/InspectorResourceAgent.h:
3924         * inspector/front-end/AuditsPanel.js:
3925         (WebInspector.AuditsPanel.prototype._reloadResources):
3926         * inspector/front-end/ElementsPanel.js:
3927         (WebInspector.ElementsPanel.prototype.setSearchingForNode):
3928         * inspector/front-end/ExtensionServer.js:
3929         (WebInspector.ExtensionServer.prototype._onReload):
3930         * inspector/front-end/NetworkPanel.js:
3931         (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
3932         * inspector/front-end/ResourcesPanel.js:
3933         (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
3934         * inspector/front-end/inspector.js:
3935         (WebInspector.highlightDOMNode):
3936         (WebInspector.openResource):
3937         (WebInspector.documentKeyDown):
3938
3939 2011-04-25  Jon Lee  <jonlee@apple.com>
3940
3941         Reviewed by Maciej Stachowiak.
3942
3943         Overlay scroller hard to see on pages with dark background (59183)
3944         https://bugs.webkit.org/show_bug.cgi?id=59183
3945         <rdar://problem/8975367>
3946
3947         Switch the scrollbar's overlay style depending on its frame's background color.
3948         This refactors the getDocumentBackgroundColor method needed for gestures. The style
3949         is determined and set on every paint() call to the Mac scrollbar theme.
3950
3951         * WebCore.exp.in: adding method to allow changing style
3952         * page/Frame.cpp:
3953         (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
3954         * page/Frame.h:
3955         * page/FrameView.cpp:
3956         (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
3957         * page/FrameView.h:
3958         * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
3959         * platform/ScrollableArea.h:
3960         (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
3961         * platform/mac/ScrollbarThemeMac.mm:
3962         (WebCore::ScrollbarThemeMac::paint):
3963         * platform/mac/WebCoreSystemInterface.h:
3964         * platform/mac/WebCoreSystemInterface.mm:
3965
3966 2011-04-25  Dan Bernstein  <mitz@apple.com>
3967
3968         Reviewed by Maciej Stachowiak.
3969
3970         <rdar://problem/9113516> REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
3971         https://bugs.webkit.org/show_bug.cgi?id=59315
3972
3973         * platform/Scrollbar.cpp:
3974         (WebCore::Scrollbar::Scrollbar): Initialize new member variables.
3975         (WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
3976         is scrolled a distance equal to the change in the mouse position.
3977         (WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
3978         the document rather than the thumb, and pass the result to moveThumb.
3979         (WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
3980         * platform/Scrollbar.h:
3981         * platform/ScrollbarTheme.h:
3982         (WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
3983         returns false.
3984         * platform/mac/ScrollbarThemeMac.h:
3985         * platform/mac/ScrollbarThemeMac.mm:
3986         (WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
3987         Option key is down.
3988
3989 2011-04-24  Geoffrey Garen  <ggaren@apple.com>
3990
3991         Reviewed by Sam Weinig.
3992
3993         Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
3994         https://bugs.webkit.org/show_bug.cgi?id=59307
3995
3996         * WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.
3997
3998         * bindings/js/JSCSSRuleCustom.cpp:
3999         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
4000         * bindings/js/JSCanvasRenderingContextCustom.cpp:
4001         * bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead
4002         of hand-coding them.
4003
4004         * bindings/js/JSDOMBinding.h:
4005         (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because
4006         they're reasonably generic.
4007
4008         * bindings/js/JSDOMImplementationCustom.cpp:
4009         * bindings/js/JSDOMStringMapCustom.cpp:
4010         * bindings/js/JSDOMTokenListCustom.cpp:
4011         * bindings/js/JSHTMLCollectionCustom.cpp:
4012         * bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of
4013         hand-coding them.
4014
4015         * bindings/js/JSMessageChannelCustom.cpp:
4016         (WebCore::JSMessageChannel::visitChildren):
4017         * bindings/js/JSMessagePortCustom.cpp:
4018         (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of
4019         markDOMObjectWrapper. This is one of the few cases where a DOM object is
4020         considered a stand-alone root. It's not as efficient as the shared root
4021         case, but workers and message ports are very rare objects, so it's no
4022         big deal.
4023
4024         * bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate!
4025
4026         * bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h.
4027
4028         * bindings/js/JSSharedWorkerCustom.cpp:
4029         (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of
4030         markDOMObjectWrapper, as above. Once again, a stand-alone root.
4031
4032         * bindings/js/JSStyleSheetCustom.cpp:
4033         * bindings/js/JSStyleSheetListCustom.cpp: Autogenerate!
4034
4035         * bindings/js/JSWebGLRenderingContextCustom.cpp:
4036         (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots
4037         system for marking WebGL contexts and their associated satellite objects.
4038
4039         * bindings/js/JSWorkerContextCustom.cpp:
4040         (WebCore::JSWorkerContext::visitChildren):
4041         * bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of
4042         markDOMObjectWrapper, as above. Once again, stand-alone roots.
4043
4044         (WebCore::JSXMLHttpRequest::visitChildren):
4045         * bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner
4046         XHR because it is not reachable from us.
4047
4048         * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a
4049         bunch of repetitive cases of isReachableFromOpaqueRoots callbacks.
4050
4051         * css/CSSRule.idl:
4052         * css/CSSStyleDeclaration.idl:
4053         * css/MediaList.idl:
4054         * css/StyleMedia.idl:
4055         * css/StyleSheet.idl:
4056         * css/StyleSheetList.idl:
4057         * dom/DOMImplementation.idl:
4058         * dom/DOMStringMap.idl:
4059         * dom/MessagePort.idl:
4060         * dom/NamedNodeMap.idl:
4061         * fileapi/Blob.idl:
4062         * html/DOMTokenList.idl: Opt in to autogeneration.
4063
4064         * html/HTMLCanvasElement.cpp:
4065         (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr
4066         usage, to reduce human error and make ownership rules more obvious.
4067
4068         * html/HTMLCollection.idl:
4069         * html/canvas/ArrayBuffer.idl: Opt in to autogeneration.
4070
4071         * html/canvas/CanvasRenderingContext.cpp:
4072         * html/canvas/CanvasRenderingContext.h:
4073         (WebCore::CanvasRenderingContext::ref):
4074         (WebCore::CanvasRenderingContext::deref):
4075         * html/canvas/CanvasRenderingContext2D.h:
4076         (WebCore::CanvasRenderingContext2D::create):
4077         (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr
4078         usage, to reduce human error and make ownership rules more obvious.
4079         
4080         Inlined some functions to match our standard idiom and to make the code
4081         in the header document itself.
4082
4083         * html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration.
4084
4085         * html/canvas/OESStandardDerivatives.cpp:
4086         (WebCore::OESStandardDerivatives::OESStandardDerivatives):
4087         (WebCore::OESStandardDerivatives::create):
4088         * html/canvas/OESStandardDerivatives.h:
4089         * html/canvas/OESStandardDerivatives.idl:
4090         * html/canvas/OESTextureFloat.cpp:
4091         (WebCore::OESTextureFloat::OESTextureFloat):
4092         (WebCore::OESTextureFloat::create):
4093         * html/canvas/OESTextureFloat.h:
4094         * html/canvas/OESTextureFloat.idl:
4095         * html/canvas/OESVertexArrayObject.cpp:
4096         (WebCore::OESVertexArrayObject::OESVertexArrayObject):
4097         (WebCore::OESVertexArrayObject::create):
4098         * html/canvas/OESVertexArrayObject.h:
4099         * html/canvas/OESVertexArrayObject.idl:
4100         * html/canvas/WebGLExtension.cpp:
4101         (WebCore::WebGLExtension::WebGLExtension):
4102         * html/canvas/WebGLExtension.h:
4103         (WebCore::WebGLExtension::ref):
4104         (WebCore::WebGLExtension::deref):
4105         (WebCore::WebGLExtension::context):