2011-04-28 Ilya Tikhonovsky <loislo@chromium.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
2
3         Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
4
5         * inspector/front-end/Settings.js:
6         (WebInspector.Settings):
7
8 2011-04-28  Beth Dakin  <bdakin@apple.com>
9
10         Rubber-stamped by Sam Weinig.
11
12         Rolling out revision 85258! I want to fix that bug a different way.
13         * platform/mac/ScrollbarThemeMac.mm:
14         (WebCore::ScrollbarThemeMac::paint):
15
16 2011-04-28  Chang Shu  <cshu@webkit.org>
17
18         Reviewed by Eric Seidel.
19
20         isContentEditable is not working properly with document.designMode
21         https://bugs.webkit.org/show_bug.cgi?id=53031
22
23         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
24         indicates that the element.isContentEditable relies on document.designMode if its
25         and its ancestors' contenteditable attributes are set to inherit.
26
27         1. Sync document render style after document.designMode is changed.
28         2. Removed the code that does unnecessary and incorrect handling for contenteditable
29         attribute with "inherit" value.
30         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
31
32         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
33                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
34                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
35                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
36
37         * css/CSSStyleSelector.cpp:
38         (WebCore::CSSStyleSelector::styleForDocument):
39         * dom/Document.cpp:
40         (WebCore::Document::setDesignMode):
41         * dom/Node.cpp:
42         (WebCore::Node::rendererIsEditable):
43         * editing/ApplyStyleCommand.cpp:
44         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
45         * html/HTMLElement.cpp:
46         (WebCore::HTMLElement::setContentEditable):
47
48 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
49
50         Unreviewed, rolling out r85101.
51         http://trac.webkit.org/changeset/85101
52         https://bugs.webkit.org/show_bug.cgi?id=59757
53
54          it'd be better to rollout the patch and do another one with
55         another property name. Current one will bring us to a problem
56         at first run after upgrade because it's type was changed from
57         int to string. (Requested by loislo on #webkit).
58
59         * inspector/front-end/ScriptsPanel.js:
60         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
61         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
62         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
63
64 2011-04-28  Mike Reed  <reed@google.com>
65
66         Reviewed by Eric Seidel.
67
68         fix shadw behavior for both CSS and Canvas -- skia only
69         https://bugs.webkit.org/show_bug.cgi?id=59700
70
71         Test:
72         canvas/philip/tests/2d.shadow.alpha.3.html
73         canvas/philip/tests/2d.shadow.alpha.4.html
74         canvas/philip/tests/2d.shadow.alpha.5.html
75         fast/canvas/canvas-fillPath-alpha-shadow.html
76         fast/canvas/canvas-strokePath-alpha-shadow.html
77         fast/canvas/canvas-strokeRect-alpha-shadow.html
78         fast/css/text-input-with-webkit-border-radius.html
79         fast/repaint/shadow-multiple-horizontal.html
80         fast/repaint/shadow-multiple-strict-horizontal.html
81         fast/repaint/shadow-multiple-strict-vertical.html
82         fast/repaint/shadow-multiple-vertical.html
83         fast/canvas/canvas-getImageData.html
84
85         * platform/graphics/chromium/FontChromiumWin.cpp:
86         (WebCore::Font::drawGlyphs):
87         * platform/graphics/skia/GraphicsContextSkia.cpp:
88         (WebCore::GraphicsContext::setPlatformShadow):
89
90 2011-04-28  David Kilzer  <ddkilzer@apple.com>
91
92         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
93
94         Reviewed by Chris Fleizach.
95
96         Previously, AXObjectCache::attachWrapper over-retained each
97         AccessibilityObjectWrapper it created, which is why
98         AXObjectCache::detachWrapper() contained an extra -release.
99
100         * accessibility/mac/AXObjectCacheMac.mm:
101         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
102         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
103         assigns to a RetainPtr<> instance variable, it doesn't need a +1
104         retained object passed in.  Fix the leak by using a RetainPtr<>
105         for the AccessibilityObjectWrapper.
106
107 2011-04-28  Nat Duca  <nduca@chromium.org>
108
109         Reviewed by Darin Fisher.
110
111         [chromium] Compute compositor fps value and history using the frameBegin timestamp
112         https://bugs.webkit.org/show_bug.cgi?id=59668
113
114         This change switches the compositor FPS meter to use the timestamp
115         of the beginning of the frame rather than the time we call
116         swapBuffers. When scheduling is correctly tied to vsync, we can
117         have highly variable times when we finish vsync and still have
118         stable frame rates.
119
120         * platform/graphics/chromium/LayerRendererChromium.cpp:
121         (WebCore::LayerRendererChromium::updateAndDrawLayers):
122         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
123         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
124         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
125         (WebCore::CCHeadsUpDisplay::onFrameBegin):
126         (WebCore::CCHeadsUpDisplay::onPresent):
127         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
128
129 2011-04-28  Beth Dakin  <bdakin@apple.com>
130
131         Reviewed by Darin Adler.
132
133         https://bugs.webkit.org/show_bug.cgi?id=59759
134         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
135         track when there is nothing to scroll to
136         <rdar://problem/9282066>
137
138         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
139         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
140         is not right. Set the proportion to 0 in this case instead.
141         * platform/mac/ScrollbarThemeMac.mm:
142         (WebCore::ScrollbarThemeMac::paint):
143
144 2011-04-28  Dan Bernstein  <mitz@apple.com>
145
146         Reviewed by Simon Fraser.
147
148         <rdar://problem/9291132> Add support for -epub-prefixed properties
149
150         Test: fast/css/epub-properties.html
151
152         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
153         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
154         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
155         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
156         text-transform, text-transform, word-break, and -webkit-writing-mode.
157
158 2011-04-28  Adam Barth  <abarth@webkit.org>
159
160         Reviewed by Eric Seidel.
161
162         Remove WML
163         https://bugs.webkit.org/show_bug.cgi?id=59678
164
165         This patch removes WML from WebCore.  After removing WML, there's a
166         bunch of twisted code that could be untwisted, but this patch contains
167         only the purely mechanical part of removing the feature.
168
169         There's been a lot of discussion on webkit-dev about whether we should
170         remove WML.  In addition to those threads, we've had an informal poll
171         of the reviewers as well as an in-person discussion at the WebKit
172         contributor's meeting.  Removing any feature is likely to make some
173         folks unhappy, but, on balance, removing WML appears to be the right
174         thing for the project to do at this time.
175
176         * CMakeLists.txt:
177         * CodeGenerators.pri:
178         * Configurations/FeatureDefines.xcconfig:
179         * DerivedSources.cpp:
180         * DerivedSources.make:
181         * GNUmakefile.am:
182         * GNUmakefile.list.am:
183         * WebCore.gyp/WebCore.gyp:
184         * WebCore.gypi:
185         * WebCore.pro:
186         * WebCore.vcproj/WebCore.vcproj:
187         * WebCore.xcodeproj/project.pbxproj:
188         * css/CSSStyleSelector.cpp:
189         (WebCore::linkAttribute):
190         (WebCore::CSSStyleSelector::styleForElement):
191         (WebCore::CSSStyleSelector::adjustRenderStyle):
192         * css/wml.css: Removed.
193         * dom/DOMImplementation.cpp:
194         (WebCore::DOMImplementation::createDocument):
195         * dom/Document.cpp:
196         (WebCore::Document::Document):
197         (WebCore::Document::createElement):
198         * dom/Document.h:
199         (WebCore::Document::isMediaDocument):
200         * dom/Document.idl:
201         * dom/InputElement.h:
202         * dom/Node.cpp:
203         (WebCore::Node::toInputElement):
204         * dom/Node.h:
205         * dom/OptionElement.cpp:
206         (WebCore::toOptionElement):
207         (WebCore::isOptionElement):
208         * dom/OptionElement.h:
209         * dom/OptionGroupElement.cpp:
210         (WebCore::toOptionGroupElement):
211         (WebCore::isOptionGroupElement):
212         * dom/SelectElement.cpp:
213         (WebCore::toSelectElement):
214         * dom/SelectElement.h:
215         * dom/Text.cpp:
216         (WebCore::Text::attach):
217         * dom/XMLDocumentParser.cpp:
218         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
219         * dom/XMLDocumentParser.h:
220         * dom/XMLDocumentParserLibxml2.cpp:
221         (WebCore::XMLDocumentParser::internalSubset):
222         (WebCore::getEntityHandler):
223         * dom/XMLDocumentParserQt.cpp:
224         (WebCore::XMLDocumentParser::parse):
225         (WebCore::XMLDocumentParser::parseDtd):
226         * editing/htmlediting.cpp:
227         (WebCore::canHaveChildrenForEditing):
228         * features.pri:
229         * history/BackForwardList.h:
230         * history/BackForwardListImpl.cpp:
231         * history/BackForwardListImpl.h:
232         * history/PageCache.cpp:
233         (WebCore::PageCache::canCachePageContainingThisFrame):
234         * html/HTMLAnchorElement.h:
235         * inspector/ConsoleMessage.cpp:
236         (WebCore::messageSourceValue):
237         * inspector/front-end/ConsoleView.js:
238         (WebInspector.ConsoleMessage.prototype.toString):
239         * loader/FrameLoader.cpp:
240         (WebCore::isBackForwardLoadType):
241         (WebCore::FrameLoader::transitionToCommitted):
242         (WebCore::FrameLoader::shouldReload):
243         (WebCore::FrameLoader::loadDifferentDocumentItem):
244         (WebCore::FrameLoader::loadItem):
245         * loader/FrameLoaderTypes.h:
246         * loader/HistoryController.cpp:
247         (WebCore::HistoryController::restoreDocumentState):
248         * manual-tests/wml: Removed.
249         * manual-tests/wml/StartTests.wml: Removed.
250         * manual-tests/wml/a-br-element.wml: Removed.
251         * manual-tests/wml/a-element.wml: Removed.
252         * manual-tests/wml/a-img-element.wml: Removed.
253         * manual-tests/wml/access-target.wml: Removed.
254         * manual-tests/wml/anchor-br-element.wml: Removed.
255         * manual-tests/wml/anchor-element.wml: Removed.
256         * manual-tests/wml/anchor-img-element.wml: Removed.
257         * manual-tests/wml/card-newcontext-attr.wml: Removed.
258         * manual-tests/wml/card-onenterbackward.wml: Removed.
259         * manual-tests/wml/card-onenterforward.wml: Removed.
260         * manual-tests/wml/card-ontimer.wml: Removed.
261         * manual-tests/wml/deck-access-control.wml: Removed.
262         * manual-tests/wml/input-format.wml: Removed.
263         * manual-tests/wml/onevent-go.wml: Removed.
264         * manual-tests/wml/onevent-noop.wml: Removed.
265         * manual-tests/wml/onevent-prev.wml: Removed.
266         * manual-tests/wml/onevent-refresh.wml: Removed.
267         * manual-tests/wml/onevent-shadow.wml: Removed.
268         * manual-tests/wml/resources: Removed.
269         * manual-tests/wml/resources/smiley.png: Removed.
270         * manual-tests/wml/select-element.wml: Removed.
271         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
272         * manual-tests/wml/select-onpick-event.wml: Removed.
273         * manual-tests/wml/setvar-element.wml: Removed.
274         * manual-tests/wml/targetdeck.wml: Removed.
275         * manual-tests/wml/task-go-in-anchor.wml: Removed.
276         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
277         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
278         * manual-tests/wml/template-go.wml: Removed.
279         * manual-tests/wml/template-ontimer.wml: Removed.
280         * manual-tests/wml/timer.wml: Removed.
281         * manual-tests/wml/variable-substitution.wml: Removed.
282         * page/Console.cpp:
283         (WebCore::printMessageSourceAndLevelPrefix):
284         * page/Console.h:
285         * page/Frame.cpp:
286         (WebCore::Frame::Frame):
287         * page/Page.cpp:
288         * page/Page.h:
289         * platform/MIMETypeRegistry.cpp:
290         (WebCore::initializeSupportedNonImageMimeTypes):
291         * platform/network/FormDataBuilder.h:
292         * platform/network/mac/ResourceHandleMac.mm:
293         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
294         * platform/wince/MIMETypeRegistryWinCE.cpp:
295         (WebCore::initMIMETypeEntensionMap):
296         * rendering/HitTestResult.cpp:
297         (WebCore::HitTestResult::altDisplayString):
298         (WebCore::HitTestResult::absoluteImageURL):
299         (WebCore::HitTestResult::absoluteLinkURL):
300         (WebCore::HitTestResult::isLiveLink):
301         * rendering/RenderBox.cpp:
302         * rendering/RenderButton.cpp:
303         (WebCore::RenderButton::updateFromElement):
304         * rendering/RenderFieldset.cpp:
305         (WebCore::RenderFieldset::findLegend):
306         * rendering/RenderImage.cpp:
307         (WebCore::RenderImage::updateAltText):
308         * rendering/RenderObject.cpp:
309         (WebCore::RenderObject::isLegend):
310         (WebCore::RenderObject::offsetParent):
311         * wml: Removed.
312         * wml/WMLAElement.cpp: Removed.
313         * wml/WMLAElement.h: Removed.
314         * wml/WMLAccessElement.cpp: Removed.
315         * wml/WMLAccessElement.h: Removed.
316         * wml/WMLAnchorElement.cpp: Removed.
317         * wml/WMLAnchorElement.h: Removed.
318         * wml/WMLAttributeNames.in: Removed.
319         * wml/WMLBRElement.cpp: Removed.
320         * wml/WMLBRElement.h: Removed.
321         * wml/WMLCardElement.cpp: Removed.
322         * wml/WMLCardElement.h: Removed.
323         * wml/WMLDoElement.cpp: Removed.
324         * wml/WMLDoElement.h: Removed.
325         * wml/WMLDocument.cpp: Removed.
326         * wml/WMLDocument.h: Removed.
327         * wml/WMLElement.cpp: Removed.
328         * wml/WMLElement.h: Removed.
329         * wml/WMLErrorHandling.cpp: Removed.
330         * wml/WMLErrorHandling.h: Removed.
331         * wml/WMLEventHandlingElement.cpp: Removed.
332         * wml/WMLEventHandlingElement.h: Removed.
333         * wml/WMLFieldSetElement.cpp: Removed.
334         * wml/WMLFieldSetElement.h: Removed.
335         * wml/WMLFormControlElement.cpp: Removed.
336         * wml/WMLFormControlElement.h: Removed.
337         * wml/WMLGoElement.cpp: Removed.
338         * wml/WMLGoElement.h: Removed.
339         * wml/WMLImageElement.cpp: Removed.
340         * wml/WMLImageElement.h: Removed.
341         * wml/WMLImageLoader.cpp: Removed.
342         * wml/WMLImageLoader.h: Removed.
343         * wml/WMLInputElement.cpp: Removed.
344         * wml/WMLInputElement.h: Removed.
345         * wml/WMLInsertedLegendElement.cpp: Removed.
346         * wml/WMLInsertedLegendElement.h: Removed.
347         * wml/WMLIntrinsicEvent.cpp: Removed.
348         * wml/WMLIntrinsicEvent.h: Removed.
349         * wml/WMLIntrinsicEventHandler.cpp: Removed.
350         * wml/WMLIntrinsicEventHandler.h: Removed.
351         * wml/WMLMetaElement.cpp: Removed.
352         * wml/WMLMetaElement.h: Removed.
353         * wml/WMLNoopElement.cpp: Removed.
354         * wml/WMLNoopElement.h: Removed.
355         * wml/WMLOnEventElement.cpp: Removed.
356         * wml/WMLOnEventElement.h: Removed.
357         * wml/WMLOptGroupElement.cpp: Removed.
358         * wml/WMLOptGroupElement.h: Removed.
359         * wml/WMLOptionElement.cpp: Removed.
360         * wml/WMLOptionElement.h: Removed.
361         * wml/WMLPElement.cpp: Removed.
362         * wml/WMLPElement.h: Removed.
363         * wml/WMLPageState.cpp: Removed.
364         * wml/WMLPageState.h: Removed.
365         * wml/WMLPostfieldElement.cpp: Removed.
366         * wml/WMLPostfieldElement.h: Removed.
367         * wml/WMLPrevElement.cpp: Removed.
368         * wml/WMLPrevElement.h: Removed.
369         * wml/WMLRefreshElement.cpp: Removed.
370         * wml/WMLRefreshElement.h: Removed.
371         * wml/WMLSelectElement.cpp: Removed.
372         * wml/WMLSelectElement.h: Removed.
373         * wml/WMLSetvarElement.cpp: Removed.
374         * wml/WMLSetvarElement.h: Removed.
375         * wml/WMLTableElement.cpp: Removed.
376         * wml/WMLTableElement.h: Removed.
377         * wml/WMLTagNames.in: Removed.
378         * wml/WMLTaskElement.cpp: Removed.
379         * wml/WMLTaskElement.h: Removed.
380         * wml/WMLTemplateElement.cpp: Removed.
381         * wml/WMLTemplateElement.h: Removed.
382         * wml/WMLTimerElement.cpp: Removed.
383         * wml/WMLTimerElement.h: Removed.
384         * wml/WMLVariables.cpp: Removed.
385         * wml/WMLVariables.h: Removed.
386
387 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
388
389         Unreviewed, rolling out r85233 and r85235.
390         http://trac.webkit.org/changeset/85233
391         http://trac.webkit.org/changeset/85235
392         https://bugs.webkit.org/show_bug.cgi?id=59754
393
394         Causes issues with jsc. (Requested by dave_levin on #webkit).
395
396         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
397         * loader/icon/IconDatabase.cpp:
398         (WebCore::IconDatabase::defaultIcon):
399         (WebCore::IconDatabase::setIconDataForIconURL):
400         (WebCore::IconDatabase::getOrCreateIconRecord):
401         (WebCore::IconDatabase::readFromDatabase):
402
403 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
404
405         Reviewed by Adam Barth.
406
407         Introducing a new class that allows serialization of a page back
408         to HTML/XML with all its sub-frames and also retrieves the page's
409         resources.
410         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
411         https://bugs.webkit.org/show_bug.cgi?id=58947
412
413         * Android.mk:
414         * CMakeLists.txt:
415         * GNUmakefile.list.am:
416         * WebCore.gypi:
417         * WebCore.pro:
418         * WebCore.vcproj/WebCore.vcproj:
419         * dom/Document.cpp:
420         (WebCore::Document::suggestedMIMEType):
421         * dom/Document.h:
422         * editing/MarkupAccumulator.cpp:
423         (WebCore::MarkupAccumulator::appendCustomAttributes):
424         (WebCore::MarkupAccumulator::appendElement):
425         * editing/MarkupAccumulator.h:
426         * html/parser/HTMLMetaCharsetParser.cpp:
427         (WebCore::HTMLMetaCharsetParser::processMeta):
428         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
429         * html/parser/HTMLMetaCharsetParser.h:
430         * page/PageSerializer.cpp: Added.
431         * page/PageSerializer.h: Added.
432
433 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
434
435         Reviewed by Tony Chang.
436
437         IndexedDB createIndex should fail if name arg is null
438         https://bugs.webkit.org/show_bug.cgi?id=58365
439
440         Test: storage/indexeddb/mozilla/create-index-null-name.html
441
442         * storage/IDBObjectStore.idl:
443         * storage/IDBObjectStoreBackendImpl.cpp:
444         (WebCore::IDBObjectStoreBackendImpl::createIndex):
445
446 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
447
448         Reviewed by Tony Chang.
449
450         IndexedDB put() should fail if second (key) parameter is null
451         https://bugs.webkit.org/show_bug.cgi?id=58613
452
453         If key arg is not specified, prpKey ends up as a null pointer in ::put().
454         However, if the key arg is specified but is null, prpKey ends up as a
455         valid IDBKey which has a null key type. As it happens, we need to be able
456         to detect the difference between these cases (the key arg is optional but
457         if specified must not be null).
458
459         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
460
461         * storage/IDBObjectStoreBackendImpl.cpp:
462         (WebCore::IDBObjectStoreBackendImpl::put):
463
464 2011-04-07  David Levin  <levin@chromium.org>
465
466         Reviewed by Darin Adler.
467
468         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
469         https://bugs.webkit.org/show_bug.cgi?id=31639
470
471         No new functionality exposed so no new tests. (The change is basically adding
472         more testing.)
473
474         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
475         * loader/icon/IconDatabase.cpp:
476         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
477         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
478         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
479         (WebCore::IconDatabase::readFromDatabase): Ditto.
480
481 2011-04-28  Kenneth Russell  <kbr@google.com>
482
483         Unreviewed build fix for Web Audio with strict OwnPtr.
484
485         * platform/audio/HRTFDatabaseLoader.cpp:
486         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
487
488 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
489
490         Reviewed by Geoffrey Garen.
491
492         Walk shadow hosts as well as parent nodes when finding opaque roots.
493         https://bugs.webkit.org/show_bug.cgi?id=59571
494
495         Test: fast/dom/shadow/gc-shadow.html
496
497         * bindings/js/JSDOMBinding.h:
498         (WebCore::root):
499
500 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
501
502         Reviewed by Xan Lopez.
503
504         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
505         https://bugs.webkit.org/show_bug.cgi?id=59715
506
507         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
508         into WebCore so that WebKit1 and WebKit2 can share the code.
509
510         No new tests. This is covered by fast/events/click-count.html.
511
512         * GNUmakefile.list.am: Added new files.
513         * platform/gtk/GtkClickCounter.cpp: Added.
514         (WebCore::GtkClickCounter::GtkClickCounter): Added.
515         (WebCore::GtkClickCounter::reset): Added.
516         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
517         (WebCore::getEventTime): Added.
518         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
519         * platform/gtk/GtkClickCounter.h: Added.
520
521 2011-04-28  Dan Bernstein  <mitz@apple.com>
522
523         Build fix.
524
525         * css/CSSParser.cpp:
526         (WebCore::cssPropertyID):
527
528 2011-04-28  Dan Bernstein  <mitz@apple.com>
529
530         Reviewed by Simon Fraser.
531
532         Allow specifying CSS property aliases in CSSPropertyNames.in files
533         https://bugs.webkit.org/show_bug.cgi?id=59712
534
535         * css/CSSParser.cpp:
536         (WebCore::cssPropertyID): Removed code to handle some aliases
537         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
538         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
539         defining an alias, and add an appropriate entry to the gperf file.
540
541 2011-04-28  Arno Renevier  <arno@renevier.net>
542
543         Reviewed by Gustavo Noronha Silva.
544
545         [Soup] does not load css stylesheets without content-type
546         https://bugs.webkit.org/show_bug.cgi?id=59697
547
548         When sniffing content type, do not replace http Content-Type header in
549         soup message anymore, but keep sniffed content type in a separate
550         variable.
551
552         * platform/network/soup/ResourceHandleSoup.cpp:
553         (WebCore::contentSniffedCallback):
554         * platform/network/soup/ResourceResponse.h:
555         (WebCore::ResourceResponse::sniffedContentType):
556         (WebCore::ResourceResponse::setSniffedContentType):
557         * platform/network/soup/ResourceResponseSoup.cpp:
558         (WebCore::ResourceResponse::updateFromSoupMessage):
559
560 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
561
562         Reviewed by Andreas Kling.
563
564         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
565         https://bugs.webkit.org/show_bug.cgi?id=59704
566
567         No new tests, just code cleanup.
568
569         * WebCore.pri:
570
571 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
572
573         Reviewed by Pavel Feldman.
574
575         Web Inspector: remove "Pretty print" source frame context menu item.
576         https://bugs.webkit.org/show_bug.cgi?id=59709
577
578         * inspector/front-end/DebuggerPresentationModel.js:
579         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
580         * inspector/front-end/ScriptsPanel.js:
581         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
582         * inspector/front-end/SourceFrame.js:
583         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
584
585 2011-04-28  Satish Sampath  <satish@chromium.org>
586
587         Reviewed by Tony Gentilcore.
588
589         Speech input button layout issues with padding and border.
590         https://bugs.webkit.org/show_bug.cgi?id=59613
591
592         * rendering/RenderTextControlSingleLine.cpp:
593         (WebCore::RenderTextControlSingleLine::layout):
594         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
595         (WebCore::RenderTextControlSingleLine::forwardEvent):
596
597 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
598
599         Reviewed by Martin Robinson.
600
601         [GTK] Check whether to use native scrollbars at run time
602         https://bugs.webkit.org/show_bug.cgi?id=59694
603
604         It's currently decided at build time depending on whether webkit2
605         build is enabled or not. That makes imposible to build both
606         webkit1 and webkit2 using the same libWebCore.
607
608         * GNUmakefile.am:
609         * platform/ScrollView.cpp:
610         (WebCore::ScrollView::wheelEvent):
611         * platform/gtk/ScrollViewGtk.cpp:
612         (WebCore::ScrollView::createScrollbar):
613
614 2011-04-28  Pavel Feldman  <pfeldman@google.com>
615
616         Reviewed by Yury Semikhatsky.
617
618         Web Inspector: add status bar button for pretty print.
619         https://bugs.webkit.org/show_bug.cgi?id=59467
620
621         * WebCore.gypi:
622         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
623         * inspector/front-end/ScriptsPanel.js:
624         (WebInspector.ScriptsPanel):
625         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
626         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
627         * inspector/front-end/WebKit.qrc:
628         * inspector/front-end/inspector.css:
629         (.scripts-toggle-pretty-print-status-bar-item .glyph):
630         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
631
632 2011-04-28  Pavel Feldman  <pfeldman@google.com>
633
634         Reviewed by Yury Semikhatsky.
635
636         Web Inspector: add ResourceTreeModel tests.
637         https://bugs.webkit.org/show_bug.cgi?id=59616
638
639         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
640                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
641                http/tests/inspector/resource-tree/resource-tree-reload.html
642
643         * inspector/front-end/ResourceTreeModel.js:
644         (WebInspector.ResourceTreeModel.prototype.frontendReused):
645         (WebInspector.ResourceTreeModel.prototype._addFrame):
646         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
647         (WebInspector.ResourceTreeModel.prototype._frameDetached):
648         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
649         (WebInspector.ResourceTreeModel.prototype.forAllResources):
650         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
651         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
652         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
653         * inspector/front-end/ResourcesPanel.js:
654         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
655         (WebInspector.ResourcesPanel.prototype._frameAdded):
656         (WebInspector.ResourcesPanel.prototype._frameDetached):
657         (WebInspector.ResourcesPanel.prototype._frameNavigated):
658         (WebInspector.FrameTreeElement):
659         (WebInspector.FrameTreeElement.prototype.frameNavigated):
660
661 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
662
663         Reviewed by Yury Semikhatsky.
664
665         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
666         https://bugs.webkit.org/show_bug.cgi?id=59592
667
668         * inspector/front-end/DetailedHeapshotGridNodes.js:
669         (WebInspector.HeapSnapshotGridNode.prototype._populate):
670         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
671         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
672         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
673         * inspector/front-end/DetailedHeapshotView.js:
674         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
675         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
676         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
677         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
678         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
679         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
680         (WebInspector.DetailedHeapshotView.prototype.changeView):
681         * inspector/front-end/HeapSnapshot.js:
682         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
683         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
684         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
685         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
686         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
687         * inspector/front-end/heapProfiler.css:
688         (div.retaining-paths-view td.path-column div:hover):
689
690 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
691
692         Reviewed by Yury Semikhatsky.
693
694         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
695         https://bugs.webkit.org/show_bug.cgi?id=59454
696
697         Test: inspector/profiler/heap-snapshot-loader.html
698
699         * inspector/front-end/HeapSnapshot.js:
700         (WebInspector.HeapSnapshotLoader):
701         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
702         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
703         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
704         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
705         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
706         * inspector/front-end/HeapSnapshotProxy.js:
707         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
708
709 2011-04-28  ojab  <ojab@ojab.ru>
710
711         Reviewed by David Levin.
712
713         Fix build with libpng-1.5.1
714         https://bugs.webkit.org/show_bug.cgi?id=59607
715
716         * platform/image-decoders/png/PNGImageDecoder.cpp:
717         (WebCore::readColorProfile):
718
719 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
720
721         Reviewed by Nikolas Zimmermann.
722
723         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
724         https://bugs.webkit.org/show_bug.cgi?id=59447
725
726         This patch contains two sub-routines, one for speeding up
727         alpha channel only gaussian blur (by 2.5 times) and one
728         for speeding up all channel blur (by 4 times).
729
730         The common code is also redesigned to better fit for platform
731         specific code. This means large chunks of code was moved to
732         different files, and all platform specific files are added to
733         all build systems.
734
735         * CMakeLists.txt:
736         * GNUmakefile.am:
737         * GNUmakefile.list.am:
738         * WebCore.gypi:
739         * WebCore.pro:
740         * WebCore.vcproj/WebCore.vcproj:
741         * WebCore.vcproj/WebCoreCommon.vsprops:
742         * WebCore.xcodeproj/project.pbxproj:
743         * platform/graphics/filters/FEGaussianBlur.cpp:
744         (WebCore::FEGaussianBlur::platformApplyGeneric):
745         (WebCore::FEGaussianBlur::apply):
746         * platform/graphics/filters/FEGaussianBlur.h:
747         (WebCore::FEGaussianBlur::kernelPosition):
748         (WebCore::FEGaussianBlur::platformApply):
749         * platform/graphics/filters/FELighting.cpp:
750         (WebCore::FELighting::platformApplyGeneric):
751         (WebCore::FELighting::drawLighting):
752         * platform/graphics/filters/FELighting.h:
753         (WebCore::FELighting::platformApply):
754         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
755         (WebCore::WTF_ALIGNED):
756         (WebCore::feGaussianBlurConstantsForNeon):
757         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
758         (WebCore::FEGaussianBlur::platformApplyNeon):
759         * platform/graphics/filters/arm/FELightingNEON.cpp:
760         (WebCore::WTF_ALIGNED):
761         (WebCore::FELighting::getPowerCoefficients):
762         * platform/graphics/filters/arm/FELightingNEON.h:
763         (WebCore::FELighting::platformApplyNeon):
764
765 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
766
767         Reviewed by Yury Semikhatsky.
768
769         Web Inspector: provide a hotkey for script pause
770         https://bugs.webkit.org/show_bug.cgi?id=59593
771
772         In fact, F8 works as a hotkey, but this fact was not reflected
773         in the shortcut help popup.
774
775         * English.lproj/localizedStrings.js:
776         * inspector/front-end/ScriptsPanel.js:
777         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
778
779 2011-04-28  Adam Barth  <abarth@webkit.org>
780
781         Reviewed by Eric Seidel.
782
783         PluginStream should play nice with strict OwnPtr
784         https://bugs.webkit.org/show_bug.cgi?id=59675
785
786         These failures appear when enabling strict OwnPtr on Qt.
787
788         * plugins/PluginStream.cpp:
789         (WebCore::PluginStream::PluginStream):
790         (WebCore::PluginStream::didReceiveData):
791
792 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
793
794         Reviewed by Pavel Feldman.
795
796         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
797         https://bugs.webkit.org/show_bug.cgi?id=59326
798
799         Concrete CachedResource successors for stylesheets and scripts
800         can decode their content better than the generic approach we use.
801
802         * inspector/InspectorPageAgent.cpp:
803         (WebCore::decodeSharedBuffer):
804         (WebCore::prepareCachedResourceBuffer):
805         (WebCore::cachedResourceDecoded):
806         (WebCore::InspectorPageAgent::resourceContent):
807         (WebCore::InspectorPageAgent::resourceData):
808         * inspector/InspectorStyleSheet.cpp:
809         (WebCore::InspectorStyleSheet::originalStyleSheetText):
810
811 2011-04-28  Jon Lee  <jonlee@apple.com>
812
813         Reviewed by Simon Fraser.
814
815         REGRESSION: white overlay scrollbars on apple.com/startpage
816         https://bugs.webkit.org/show_bug.cgi?id=59540
817         <rdar://problem/9338653>
818
819         Now we look at the document background in addition to the <body> element,
820         and blend those colors in with the base background of the frame view to
821         arrive at our aggregate color. This provides a better result to determine
822         overlay scrollbar style.
823
824         * page/Frame.cpp:
825         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
826         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
827
828 2011-04-27  Adam Barth  <abarth@webkit.org>
829
830         Reviewed by Maciej Stachowiak.
831
832         Fix OwnPtr issues in IndexedDB
833         https://bugs.webkit.org/show_bug.cgi?id=59656
834
835         This patch is an attempt to fix the clang build.  Clang can't seem to
836         cope with OwnPtrs to classes declared in an anonymous namespace because
837         OwnPtr's copy constructor isn't defined (but would need to be defined
838         in this translation unit).
839
840         * platform/leveldb/LevelDBDatabase.cpp:
841
842 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
843
844         Reviewed by Antonio Gomes.
845
846         [EFL] Change cursor to LAZY_NATIVE_CURSOR
847         https://bugs.webkit.org/show_bug.cgi?id=59411
848
849         Enable LAZY_NATIVE_CURSOR on EFL build.
850
851         No test added because functionality is unchanged.
852
853         * CMakeListsEfl.txt: Add Cursor.cpp
854         * platform/Cursor.h:
855         (WebCore::Cursor::Cursor):
856         * platform/efl/CursorEfl.cpp:
857         (WebCore::Cursor::Cursor):
858         (WebCore::Cursor::~Cursor):
859         (WebCore::getCursorString):
860         (WebCore::Cursor::ensurePlatformCursor):
861         * platform/efl/WidgetEfl.cpp:
862         (WebCore::Widget::setCursor):
863
864 2011-04-27  Adam Barth  <abarth@webkit.org>
865
866         Build fix from the future.  Another trival strict OwnPtr fixes.  This
867         is the last futuristic build fix I can detect with my time traveling
868         abilities.
869
870         * platform/graphics/chromium/TransparencyWin.cpp:
871         (WebCore::TransparencyWin::initializeNewContext):
872
873 2011-04-27  Dmitry Lomov  <dslomov@google.com>
874
875         Reviewed by David Levin.
876
877         CrossThreadCopier should not have a default specialization for raw pointers
878         https://bugs.webkit.org/show_bug.cgi?id=59234
879         Removed the ablity to pass raw pointers cross-thread
880         Added and applied annotations for doing that
881
882         * fileapi/FileReader.cpp:
883         (WebCore::FileReader::readInternal):
884         (WebCore::FileReader::abort):
885         * fileapi/FileStreamProxy.cpp:
886         (WebCore::FileStreamProxy::startOnFileThread):
887         (WebCore::FileStreamProxy::stopOnFileThread):
888         (WebCore::FileStreamProxy::getSize):
889         (WebCore::FileStreamProxy::getSizeOnFileThread):
890         (WebCore::FileStreamProxy::openForRead):
891         (WebCore::FileStreamProxy::openForReadOnFileThread):
892         (WebCore::FileStreamProxy::openForWrite):
893         (WebCore::FileStreamProxy::openForWriteOnFileThread):
894         (WebCore::FileStreamProxy::close):
895         (WebCore::FileStreamProxy::read):
896         (WebCore::FileStreamProxy::readOnFileThread):
897         (WebCore::FileStreamProxy::write):
898         (WebCore::FileStreamProxy::writeOnFileThread):
899         (WebCore::FileStreamProxy::truncate):
900         (WebCore::FileStreamProxy::truncateOnFileThread):
901         * loader/WorkerThreadableLoader.cpp:
902         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
903         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
904         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
905         * page/GeolocationPositionCache.cpp:
906         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
907         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
908         * platform/CrossThreadCopier.h:
909         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
910         (WebCore::AllowCrossThreadAccessWrapper::value):
911         (WebCore::AllowCrossThreadAccess):
912         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
913         (WebCore::AllowExtendedLifetimeWrapper::value):
914         (WebCore::AllowExtendedLifetime):
915         * platform/graphics/chromium/cc/CCCompletionEvent.h:
916         * storage/IDBObjectStoreBackendImpl.cpp:
917         (WebCore::IDBObjectStoreBackendImpl::get):
918         (WebCore::IDBObjectStoreBackendImpl::put):
919         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
920         (WebCore::IDBObjectStoreBackendImpl::clear):
921         (WebCore::IDBObjectStoreBackendImpl::createIndex):
922         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
923         (WebCore::IDBObjectStoreBackendImpl::openCursor):
924         * storage/SQLCallbackWrapper.h:
925         (WebCore::SQLCallbackWrapper::clear):
926         * websockets/WorkerThreadableWebSocketChannel.cpp:
927         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
928         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
929         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
930         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
931         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
932         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
933         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
934         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
935         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
936         * workers/WorkerMessagingProxy.cpp:
937         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
938
939 2011-04-27  Adam Barth  <abarth@webkit.org>
940
941         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
942
943         * page/Frame.cpp:
944         (WebCore::Frame::setTiledBackingStoreEnabled):
945         * platform/audio/ReverbConvolver.cpp:
946         (WebCore::ReverbConvolver::ReverbConvolver):
947
948 2011-04-27  Adam Barth  <abarth@webkit.org>
949
950         Reviewed by David Levin.
951
952         Fix five strict PassOwnPtr violations in WebCore
953         https://bugs.webkit.org/show_bug.cgi?id=59640
954
955         * css/MediaList.cpp:
956         (WebCore::MediaList::deleteMedium):
957         (WebCore::MediaList::setMediaText):
958         (WebCore::MediaList::appendMedium):
959         * css/MediaQuery.h:
960         * dom/MessagePort.cpp:
961         (WebCore::MessagePort::disentanglePorts):
962         (WebCore::MessagePort::entanglePorts):
963         * inspector/InspectorStyleSheet.cpp:
964         (ParsedStyleSheet::setText):
965         * rendering/RenderTheme.cpp:
966         (WebCore::RenderTheme::adjustStyle):
967         (WebCore::RenderTheme::adjustMeterStyle):
968         * rendering/RenderThemeMac.mm:
969         (WebCore::RenderThemeMac::adjustMenuListStyle):
970         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
971         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
972         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
973         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
974         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
975         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
976         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
977
978 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
979
980         Reviewed by Beth Dakin.
981
982         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
983         https://bugs.webkit.org/show_bug.cgi?id=59648
984
985         Test: accessibility/aria-fallback-roles.html
986
987         * accessibility/AccessibilityObject.cpp:
988         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
989
990 2011-04-27  Beth Dakin  <bdakin@apple.com>
991
992         Reviewed by Dan Bernstein.
993
994         https://bugs.webkit.org/show_bug.cgi?id=59671
995         Race condition with scrollbar animations and closing a page can cause a crash in 
996         WebCore::FrameView::setVisibleScrollerThumbRect + 15
997         -and corresponding-
998         <rdar://problem/9329253>
999
1000         It is definitely possible for Page to be null here. So we should null-check it! 
1001         And we should not ASSERT.
1002         * page/FrameView.cpp:
1003         (WebCore::FrameView::didCompleteRubberBand):
1004         (WebCore::FrameView::scrollbarStyleChanged):
1005         (WebCore::FrameView::setVisibleScrollerThumbRect):
1006
1007 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1008
1009         WinCE build fix after r85143.
1010
1011         * platform/graphics/wince/FontWinCE.cpp:
1012         (WebCore::TextRunComponent::TextRunComponent):
1013
1014 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
1015
1016         Reviewed by Tony Chang.
1017
1018         IndexedDB object store delete should fail if key is null
1019         https://bugs.webkit.org/show_bug.cgi?id=58614
1020
1021         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
1022
1023         * storage/IDBObjectStoreBackendImpl.cpp:
1024         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1025
1026 2011-04-27  Eric Seidel  <eric@webkit.org>
1027
1028         Reviewed by Ryosuke Niwa.
1029
1030         Should have an easy way to construct starting BidiStatus for a paragraph root
1031         https://bugs.webkit.org/show_bug.cgi?id=59226
1032
1033         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
1034         I've made this a constructor for BidiStatus instead.
1035
1036         As part of this effort I added a direction() accessor for TextRun and got
1037         rid of the old m_rtl bool.  This is part of the generic effort in the
1038         Bidi code to replace old bool usage with the superior TextDirection enum
1039         (this generally makes the code cleaner).
1040
1041         As part of this replacement effort I found several places which were
1042         assuming LTR (by passing rtl=false) when they probably want to use
1043         the current text direction.  I suspect that LTR vs. RTL may affect
1044         string width in the case of ligatures.  It's unclear.
1045
1046         This is almost entirely a mechanical change.
1047
1048         * html/canvas/CanvasRenderingContext2D.cpp:
1049         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1050         * platform/graphics/GraphicsContext.cpp:
1051         (WebCore::GraphicsContext::drawBidiText):
1052         * platform/graphics/TextRun.h:
1053         (WebCore::TextRun::TextRun):
1054         (WebCore::TextRun::direction):
1055         (WebCore::TextRun::rtl):
1056         (WebCore::TextRun::ltr):
1057         (WebCore::TextRun::setDirection):
1058         * platform/text/BidiResolver.h:
1059         (WebCore::BidiStatus::BidiStatus):
1060         * rendering/EllipsisBox.cpp:
1061         (WebCore::EllipsisBox::paint):
1062         (WebCore::EllipsisBox::selectionRect):
1063         (WebCore::EllipsisBox::paintSelection):
1064         * rendering/InlineTextBox.cpp:
1065         (WebCore::InlineTextBox::selectionRect):
1066         (WebCore::InlineTextBox::paint):
1067         (WebCore::InlineTextBox::paintSelection):
1068         (WebCore::InlineTextBox::paintCompositionBackground):
1069         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1070         (WebCore::InlineTextBox::paintTextMatchMarker):
1071         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1072         (WebCore::InlineTextBox::offsetForPosition):
1073         (WebCore::InlineTextBox::positionForOffset):
1074         * rendering/RenderBlockLineLayout.cpp:
1075         (WebCore::RenderBlock::determineStartPosition):
1076         * rendering/RenderFileUploadControl.cpp:
1077         (WebCore::RenderFileUploadControl::paintObject):
1078         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1079         * rendering/RenderListBox.cpp:
1080         (WebCore::RenderListBox::updateFromElement):
1081         (WebCore::RenderListBox::paintItemForeground):
1082         * rendering/RenderTextControl.cpp:
1083         (WebCore::RenderTextControl::getAvgCharWidth):
1084         (WebCore::RenderTextControl::paintPlaceholder):
1085         * rendering/svg/SVGInlineTextBox.cpp:
1086         (WebCore::SVGInlineTextBox::constructTextRun):
1087         * rendering/svg/SVGTextMetrics.cpp:
1088         (WebCore::constructTextRun):
1089
1090 2011-04-27  Robert Hogan  <robert@webkit.org>
1091
1092         Reviewed by Adam Barth.
1093
1094         Allow shadowing of history object
1095         https://bugs.webkit.org/show_bug.cgi?id=55965
1096
1097         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1098                http/tests/history/cross-origin-replace-history-object.html
1099
1100         * page/DOMWindow.idl:
1101
1102 2011-04-27  James Robinson  <jamesr@chromium.org>
1103
1104         Reviewed by Kenneth Russell.
1105
1106         [chromium] Ensure compositing layers are up to date before entering doComposite
1107         https://bugs.webkit.org/show_bug.cgi?id=59159
1108
1109         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1110         GraphicsLayerClient::paintContents() implementations).
1111
1112         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1113         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1114         * platform/graphics/chromium/LayerChromium.cpp:
1115         (WebCore::LayerChromium::LayerChromium):
1116         (WebCore::LayerChromium::~LayerChromium):
1117         * platform/graphics/chromium/LayerRendererChromium.cpp:
1118         (WebCore::LayerRendererChromium::updateLayers):
1119         * platform/graphics/chromium/LayerRendererChromium.h:
1120           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1121
1122 2011-04-27  James Robinson  <jamesr@chromium.org>
1123
1124         Reviewed by Adam Barth.
1125
1126         Fix OwnPtr strict issues in chromium linux build
1127         https://bugs.webkit.org/show_bug.cgi?id=59664
1128
1129         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1130         (WebCore::ComplexTextController::getNormalizedTextRun):
1131         * platform/graphics/skia/ImageBufferSkia.cpp:
1132         (WebCore::ImageBuffer::ImageBuffer):
1133         * platform/graphics/skia/PlatformContextSkia.cpp:
1134         (WebCore::PlatformContextSkia::PlatformContextSkia):
1135
1136 2011-04-27  Chris Rogers  <crogers@google.com>
1137
1138         Reviewed by Kenneth Russell.
1139
1140         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1141         https://bugs.webkit.org/show_bug.cgi?id=59641
1142
1143         No new tests since audio API is not yet implemented.
1144
1145         * platform/audio/AudioBus.cpp:
1146         (WebCore::AudioBus::createBySampleRateConverting):
1147         (WebCore::AudioBus::createByMixingToMono):
1148
1149 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1150
1151         Motivated by Alexey Proskuryakov.
1152
1153         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1154         informative, since it confused Alexey and me.
1155
1156 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1157
1158         Reviewed by Sam Weinig.
1159
1160         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1161         https://bugs.webkit.org/show_bug.cgi?id=59646
1162
1163         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1164         a world, we need to clear all entries in the map for that world, since
1165         the finalizers that would otherwise clear those entries don't run. The
1166         simplest way to do this is just to make the world own the map.
1167         
1168         * bindings/js/DOMWrapperWorld.h:
1169         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1170         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1171         * bindings/js/JSCSSValueCustom.cpp:
1172         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1173         (WebCore::JSCSSValueOwner::finalize):
1174         * bindings/js/JSDOMBinding.h:
1175
1176 2011-04-27  Adam Barth  <abarth@webkit.org>
1177
1178         Reviewed by David Levin.
1179
1180         Fix OwnPtr issues in IndexedDB
1181         https://bugs.webkit.org/show_bug.cgi?id=59656
1182
1183         I didn't do an exhaustive review of this code, but I fixed the problems
1184         caught by turning on strict OwnPtr and all their antecedents.  This
1185         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1186         behavior change.
1187
1188         * platform/leveldb/LevelDBDatabase.cpp:
1189         (WebCore::LevelDBDatabase::LevelDBDatabase):
1190         (WebCore::LevelDBDatabase::open):
1191         (WebCore::LevelDBDatabase::createIterator):
1192         * platform/leveldb/LevelDBDatabase.h:
1193         * platform/leveldb/LevelDBIterator.cpp:
1194         (WebCore::LevelDBIterator::LevelDBIterator):
1195         * platform/leveldb/LevelDBIterator.h:
1196         * storage/IDBLevelDBBackingStore.cpp:
1197         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1198         (WebCore::IDBLevelDBBackingStore::open):
1199         (WebCore::getNewDatabaseId):
1200         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1201         (WebCore::getNewObjectStoreId):
1202         (WebCore::deleteRange):
1203         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1204         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1205         (WebCore::IDBLevelDBBackingStore::getIndexes):
1206         (WebCore::getNewIndexId):
1207         (WebCore::findGreatestKeyLessThan):
1208         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1209         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1210         (WebCore::findLastIndexKeyEqualTo):
1211         * storage/IDBLevelDBBackingStore.h:
1212
1213 2011-04-19  MORITA Hajime  <morrita@google.com>
1214
1215         Reviewed by Tony Chang.
1216
1217         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1218         https://bugs.webkit.org/show_bug.cgi?id=58113
1219
1220         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1221         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1222         * Now MarkerMapVectorPair is no longer used.
1223         
1224         No new tests, No behavior change.
1225
1226         * GNUmakefile.list.am:
1227         * WebCore.gypi:
1228         * WebCore.pro:
1229         * WebCore.vcproj/WebCore.vcproj:
1230         * WebCore.xcodeproj/project.pbxproj:
1231         * dom/DocumentMarker.h:
1232         * dom/DocumentMarkerController.cpp:
1233         (WebCore::DocumentMarkerController::addMarker):
1234         (WebCore::DocumentMarkerController::copyMarkers):
1235         (WebCore::DocumentMarkerController::removeMarkers):
1236         (WebCore::DocumentMarkerController::markerContainingPoint):
1237         (WebCore::DocumentMarkerController::markersForNode):
1238         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1239         (WebCore::DocumentMarkerController::removeMarkersFromList):
1240         (WebCore::DocumentMarkerController::repaintMarkers):
1241         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1242         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1243         (WebCore::DocumentMarkerController::shiftMarkers):
1244         (WebCore::DocumentMarkerController::setMarkersActive):
1245         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1246         (WebCore::DocumentMarkerController::showMarkers):
1247         * dom/DocumentMarkerController.h:
1248         * dom/RenderedDocumentMarker.h: Added.
1249         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1250         (WebCore::RenderedDocumentMarker::isRendered):
1251         (WebCore::RenderedDocumentMarker::contains):
1252         (WebCore::RenderedDocumentMarker::setRenderedRect):
1253         (WebCore::RenderedDocumentMarker::renderedRect):
1254         (WebCore::RenderedDocumentMarker::invalidate):
1255         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1256
1257 2011-04-27  James Robinson  <jamesr@chromium.org>
1258
1259         Unreviewed, rolling out r85112.
1260         http://trac.webkit.org/changeset/85112
1261         https://bugs.webkit.org/show_bug.cgi?id=59159
1262
1263         Broke mac compile
1264
1265         * page/FrameView.cpp:
1266         (WebCore::FrameView::updateCompositingLayers):
1267         * page/FrameView.h:
1268         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1269         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1270         * platform/graphics/chromium/LayerChromium.cpp:
1271         (WebCore::LayerChromium::LayerChromium):
1272         (WebCore::LayerChromium::~LayerChromium):
1273         * platform/graphics/chromium/LayerRendererChromium.cpp:
1274         (WebCore::LayerRendererChromium::updateLayers):
1275         * platform/graphics/chromium/LayerRendererChromium.h:
1276
1277 2011-04-27  Mark Rowe  <mrowe@apple.com>
1278
1279         Build fix.
1280
1281         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1282
1283 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1284
1285         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1286
1287         * platform/network/ResourceHandleClient.h:
1288
1289 2011-04-27  James Robinson  <jamesr@chromium.org>
1290
1291         Reviewed by Kenneth Russell.
1292
1293         [chromium] Ensure compositing layers are up to date before entering doComposite
1294         https://bugs.webkit.org/show_bug.cgi?id=59159
1295
1296         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1297         GraphicsLayerClient::paintContents() implementations).
1298
1299         * page/FrameView.cpp:
1300         (WebCore::FrameView::updateCompositingLayers):
1301             Add an optional CompositingUpdateType parameter.
1302         * page/FrameView.h:
1303         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1304         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1305         * platform/graphics/chromium/LayerChromium.cpp:
1306         (WebCore::LayerChromium::LayerChromium):
1307         (WebCore::LayerChromium::~LayerChromium):
1308         * platform/graphics/chromium/LayerRendererChromium.cpp:
1309         (WebCore::LayerRendererChromium::updateLayers):
1310         * platform/graphics/chromium/LayerRendererChromium.h:
1311           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1312         * rendering/RenderLayer.cpp:
1313         (WebCore::RenderLayer::dirtyZOrderLists):
1314         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1315         * rendering/RenderLayerCompositor.cpp:
1316         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1317         * rendering/RenderLayerCompositor.h:
1318           Fix a typo in CompositingUpdateType Pait->Paint
1319
1320 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1321
1322         Reviewed by Antti Koivisto.
1323
1324         Part of WebCore should use CFNetwork-based loader on Mac
1325         https://bugs.webkit.org/show_bug.cgi?id=51836
1326
1327         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1328         willCacheResponse/shouldCacheResponse.
1329
1330         * loader/EmptyClients.h:
1331         * loader/FrameLoaderClient.h:
1332         * loader/ResourceLoader.h:
1333         * loader/cf/ResourceLoaderCFNet.cpp:
1334         * loader/mac/ResourceLoaderMac.mm:
1335         (WebCore::ResourceLoader::willCacheResponse):
1336         * platform/network/ResourceHandleClient.h:
1337         (WebCore::ResourceHandleClient::willCacheResponse):
1338         (WebCore::ResourceHandleClient::shouldCacheResponse):
1339         * platform/network/cf/ResourceHandleCFNet.cpp:
1340         (WebCore::willCacheResponse):
1341
1342 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
1343
1344         Reviewed by Brian Weinstein.
1345
1346         Web Inspector: Stop on Exception state does not persist.
1347
1348         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
1349         https://bugs.webkit.org/show_bug.cgi?id=59630
1350
1351         * inspector/front-end/ScriptsPanel.js:
1352         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1353         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1354         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1355
1356 2011-04-27  Adrienne Walker  <enne@google.com>
1357
1358         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
1359         https://bugs.webkit.org/show_bug.cgi?id=59020
1360
1361         * platform/graphics/chromium/LayerRendererChromium.cpp:
1362         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1363
1364 2011-04-27  Darin Adler  <darin@apple.com>
1365
1366         Reviewed by David Levin.
1367
1368         Fix strict OwnPtr issues seen in about 30 more files
1369         https://bugs.webkit.org/show_bug.cgi?id=59615
1370
1371         * bindings/js/JSCallbackData.h:
1372         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
1373         * bindings/js/JSMessageEventCustom.cpp:
1374         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
1375         * css/CSSParser.cpp:
1376         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
1377         adoptPtr, and release.
1378         * dom/MessageEvent.cpp:
1379         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
1380         and release.
1381         * dom/MessagePortChannel.cpp:
1382         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
1383         * dom/ScriptExecutionContext.cpp:
1384         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
1385         * dom/XMLDocumentParserLibxml2.cpp:
1386         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
1387         * dom/default/PlatformMessagePortChannel.cpp:
1388         (WebCore::MessagePortChannel::create): Use adoptPtr.
1389         * html/HTMLFormControlElement.cpp:
1390         (WebCore::HTMLFormControlElement::detach): Use nullptr.
1391         * inspector/InspectorAgent.cpp:
1392         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
1393         * inspector/InspectorConsoleAgent.cpp:
1394         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
1395         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
1396         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
1397         * inspector/InspectorController.cpp:
1398         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
1399         * inspector/InspectorDOMAgent.cpp:
1400         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
1401         * inspector/InspectorResourceAgent.cpp:
1402         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1403         * page/FrameActionScheduler.cpp:
1404         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1405         * platform/graphics/ShadowBlur.cpp:
1406         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1407         * platform/graphics/ca/GraphicsLayerCA.cpp:
1408         (WebCore::GraphicsLayer::create): Use adoptPtr.
1409         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1410         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1411         * rendering/RenderBlock.cpp:
1412         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1413         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1414         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
1415         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
1416         * rendering/RenderLayerBacking.cpp:
1417         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
1418         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
1419         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
1420         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
1421         * rendering/RenderLayerCompositor.cpp:
1422         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
1423         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
1424         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
1425         * rendering/style/StyleRareNonInheritedData.cpp:
1426         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
1427         explicit initializations of OwnPtr members to 0. Use adoptPtr.
1428         * workers/SharedWorkerContext.cpp:
1429         (WebCore::createConnectEvent): Use adoptPtr.
1430         * workers/Worker.cpp:
1431         (WebCore::Worker::notifyFinished): Use nullptr.
1432
1433 2011-04-27  Enrica Casucci  <enrica@apple.com>
1434
1435         Reviewed by Darin Adler.
1436
1437         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
1438         https://bugs.webkit.org/show_bug.cgi?id=59251
1439         <rdar://problem/9327044>
1440
1441         When we are looking for wrapping elements that are presentational, we should
1442         include elements that have a non transparent background color only if they
1443         are not blocks.
1444
1445         Test: editing/pasteboard/do-not-copy-body-color.html
1446
1447         * editing/markup.cpp:
1448         (WebCore::isElementPresentational):
1449
1450 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
1451
1452         Reviewed by Antti Koivisto.
1453
1454         Teach sub-selector chains about shadow descendants
1455         https://bugs.webkit.org/show_bug.cgi?id=58342
1456
1457         The primary change is to the logic of parsing specifiers:
1458         1) The shadow descendant selectors (those specifiers that are unknown
1459         pseudo element selectors) are always kept at the top of the chain.
1460         2) The sub-selectors after shadow descendant selectors are stashed right
1461         behind the sub-selector, but not at the end of the chain.
1462         3) Other sub-selectors are appended at the end of the chain.
1463
1464         * css/CSSGrammar.y: Changed specifier_list collection to use new
1465             CSSParser::updateSpecifier helper.
1466         * css/CSSParser.cpp:
1467         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
1468             look for the last ShadowDescendant relation in the chain of selectors,
1469             because the next selector after it is the one that should get the
1470             element name.
1471         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
1472             CSSGrammar.y. The new logic adjusts the selector chain to allow
1473             shadow descendant selectors have sub-selectors (and have multiple shadow
1474             descendants in the chain).
1475         * css/CSSParser.h: Added decl.
1476         * css/CSSParserValues.cpp:
1477         (WebCore::CSSParserSelector::insertTagHistory): Added.
1478         (WebCore::CSSParserSelector::appendTagHistory): Aded.
1479         * css/CSSParserValues.h: Added decls.
1480         * css/CSSStyleSelector.cpp:
1481         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
1482             shadow descendant selector match check, since now there could be many
1483             of them in the selector chain.
1484
1485 2011-04-20  Adrienne Walker  <enne@google.com>
1486
1487         Reviewed by Kenneth Russell.
1488
1489         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
1490         https://bugs.webkit.org/show_bug.cgi?id=59020
1491
1492         mapRect is the incorrect transform here.  The parent scissor rect
1493         needs to be projected into layer space instead.
1494
1495         Test: compositing/flat-with-transformed-child.html
1496
1497         * platform/graphics/chromium/LayerRendererChromium.cpp:
1498         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1499
1500 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1501
1502         Reviewed by Antti Koivisto.
1503
1504         Part of WebCore should use CFNetwork-based loader on Mac
1505         https://bugs.webkit.org/show_bug.cgi?id=51836
1506
1507         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
1508         * platform/mac/SoftLinking.h:
1509         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
1510
1511 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
1512
1513         Reviewed by Antti Koivisto.
1514
1515         Cleanup CSSStyleApplyProperty.cpp
1516         https://bugs.webkit.org/show_bug.cgi?id=59623
1517
1518         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
1519         Use typedefs instead of repating the function pointer declarations in a few places.
1520
1521         * css/CSSStyleApplyProperty.cpp:
1522         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
1523         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
1524         (WebCore::ApplyPropertyColor::applyInheritValue):
1525         (WebCore::ApplyPropertyColor::applyInitialValue):
1526         (WebCore::ApplyPropertyColor::applyValue):
1527         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
1528
1529 2011-04-27  Dan Bernstein  <mitz@apple.com>
1530
1531         Reviewed by Anders Carlsson.
1532
1533         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
1534         https://bugs.webkit.org/show_bug.cgi?id=59622
1535
1536         Test: fast/borders/border-image-trumps-radius.html
1537
1538         * rendering/RenderBox.cpp:
1539         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
1540         image, then border radius is ignored, so no bleed avoidance is needed.
1541         * rendering/RenderObject.cpp:
1542         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
1543         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
1544         * rendering/RenderObject.h:
1545
1546 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1547
1548         Reviewed by Xan Lopez.
1549
1550         [GTK] editing/pasteboard/copy-standalone-image.html fails
1551         https://bugs.webkit.org/show_bug.cgi?id=53645
1552
1553         When writing an image to the clipboard, also write the URL and title
1554         into the markup and URL portion. This change also abstracts a helper
1555         imageToMarkup into markup.{cpp/h} from several different locations
1556         throughout the platform layer.
1557
1558         * editing/markup.h: Added new function definition.
1559         * editing/markup.cpp:
1560         (WebCore::imageToMarkup): Add this function which turns an image URL 
1561         and element into some markup representing that image, while preserving
1562         non-src attributes.
1563         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
1564         to markup.cpp.
1565         * platform/gtk/PasteboardGtk.cpp:
1566         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
1567         image URL for a variety of image tag types.
1568         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
1569         markup and URL portions of the clipboard. This will ensure that images
1570         paste properly back into WebKit.
1571         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
1572         one from markup.h
1573
1574 2011-04-27  Steve Block  <steveblock@google.com>
1575
1576         Reviewed by David Levin.
1577
1578         Remove Android build system
1579         https://bugs.webkit.org/show_bug.cgi?id=48111
1580
1581         This is to avoid the maintenance burden until the Android port is
1582         fully upstreamed.
1583
1584         No new tests, build change only.
1585
1586         * Android.derived.jscbindings.mk: Removed.
1587         * Android.derived.mk: Removed.
1588         * Android.derived.v8bindings.mk: Removed.
1589         * Android.jscbindings.mk: Removed.
1590         * Android.mk: Removed.
1591         * Android.v8bindings.mk: Removed.
1592
1593 2011-04-27  Darin Adler  <darin@apple.com>
1594
1595         Reviewed by Sam Weinig.
1596
1597         Somehow about:blank gets into the icon database
1598         https://bugs.webkit.org/show_bug.cgi?id=58067
1599         rdar://problem/6751446
1600
1601         Implemented the policy Brady suggested, where only http and https URLs can
1602         be associated with and icon, guarding both on the way in to the database,
1603         and on the way out.
1604
1605         * loader/icon/IconDatabase.cpp:
1606         (WebCore::pageCanHaveIcon): Added.
1607         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
1608         instead of just checking for an empty URL.
1609         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
1610         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
1611         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
1612         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
1613         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
1614         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
1615         two separate assertions and added a third.
1616         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
1617
1618         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
1619         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
1620         overloaded it to work on both UChar and char, and added an assertion to it.
1621         Also moved this to the top of the file and made the UChar version usable
1622         in the shared code used even by Google.
1623         (WebCore::KURL::invalidate): Updated for name change.
1624         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
1625         toASCIILower since it's faster.
1626         (WebCore::KURL::parse): Updated for name changes.
1627         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
1628         since it's faster.
1629         (WebCore::protocolIsInHTTPFamily): Added.
1630
1631         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
1632         to protocolIsInHTTPFamily and added a version that works on a string.
1633         Kept the old name as an inline function so we don't have to rename
1634         all the cal sites now.
1635
1636         * platform/KURLGoogle.cpp: Renamed as above.
1637         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
1638         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
1639         (WebCore::KURLGooglePrivate::setAscii): Ditto.
1640         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
1641         (WebCore::KURLGooglePrivate::copyTo): Ditto.
1642         (WebCore::KURL::KURL): Ditto.
1643         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
1644         (WebCore::KURL::invalidate): Ditto.
1645         * platform/KURLGooglePrivate.h: Ditto.
1646
1647         * WebCore.exp.in: Updated for above changes.
1648
1649 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1650
1651         Reviewed by Pavel Feldman.
1652
1653         Web Inspector: browser crash on evaluation of 'throw undefined'
1654         https://bugs.webkit.org/show_bug.cgi?id=59611
1655
1656         Test: inspector/console/console-eval-throw-undefined.html
1657
1658         * inspector/InjectedScriptSource.js: use try/catch to protect from
1659         exception during conversion of another exception to string.
1660
1661 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1662
1663         Reviewed by Yury Semikhatsky.
1664
1665         Web Inspector: clicking bookmarklet multiplies resources panel entries.
1666         https://bugs.webkit.org/show_bug.cgi?id=59590
1667
1668         * inspector/front-end/ResourceTreeModel.js:
1669         (WebInspector.ResourceTreeModel):
1670         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
1671         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1672         * inspector/front-end/ResourcesPanel.js:
1673         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1674         (WebInspector.FrameTreeElement):
1675         (WebInspector.FrameTreeElement.prototype.appendResource):
1676         * inspector/front-end/inspector.js:
1677         (WebInspector.frontendReused):
1678
1679 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1680
1681         Reviewed by Yury Semikhatsky.
1682
1683         Web Inspector: opening bookmarklet disconnects DOM agent.
1684         https://bugs.webkit.org/show_bug.cgi?id=59588
1685
1686         * inspector/InspectorDOMAgent.cpp:
1687         (WebCore::InspectorDOMAgent::setDocument):
1688
1689 2011-04-27  Hans Wennborg  <hans@chromium.org>
1690
1691         Reviewed by Tony Gentilcore.
1692
1693         IndexedDB: Fix compiler warnings about uninitialized variables
1694         https://bugs.webkit.org/show_bug.cgi?id=59599
1695
1696         Build fix. No new tests.
1697
1698         * storage/IDBLevelDBBackingStore.cpp:
1699         (WebCore::getNewObjectStoreId):
1700         (WebCore::getNewIndexId):
1701
1702 2011-04-26  Hans Wennborg  <hans@chromium.org>
1703
1704         Reviewed by Tony Gentilcore.
1705
1706         IndexedDB: Move LevelDB key coding routines to separate file
1707         https://bugs.webkit.org/show_bug.cgi?id=59452
1708
1709         Move all routines concerned with encoding, decoding and comparison of
1710         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
1711         IDBLevelDBCoding.cpp.
1712
1713         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
1714         allow for unit testing of the coding routines.
1715
1716         No new functionality, no new tests.
1717
1718         * WebCore.gypi:
1719         * storage/IDBLevelDBBackingStore.cpp:
1720         (WebCore::getInt):
1721         (WebCore::putInt):
1722         (WebCore::getString):
1723         (WebCore::putString):
1724         (WebCore::compareKeys):
1725         (WebCore::compareIndexKeys):
1726         (WebCore::Comparator::compare):
1727         (WebCore::setUpMetadata):
1728         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
1729         (WebCore::getNewDatabaseId):
1730         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
1731         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1732         (WebCore::getNewObjectStoreId):
1733         (WebCore::IDBLevelDBBackingStore::createObjectStore):
1734         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
1735         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
1736         (WebCore::getNewVersionNumber):
1737         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
1738         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
1739         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
1740         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1741         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
1742         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1743         (WebCore::IDBLevelDBBackingStore::getIndexes):
1744         (WebCore::getNewIndexId):
1745         (WebCore::IDBLevelDBBackingStore::createIndex):
1746         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
1747         (WebCore::versionExists):
1748         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1749         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1750         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
1751         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
1752         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
1753         * storage/IDBLevelDBCoding.cpp: Added.
1754         (WebCore::IDBLevelDBCoding::encodeByte):
1755         (WebCore::IDBLevelDBCoding::maxIDBKey):
1756         (WebCore::IDBLevelDBCoding::minIDBKey):
1757         (WebCore::IDBLevelDBCoding::encodeInt):
1758         (WebCore::IDBLevelDBCoding::decodeInt):
1759         (WebCore::IDBLevelDBCoding::encodeVarInt):
1760         (WebCore::IDBLevelDBCoding::decodeVarInt):
1761         (WebCore::IDBLevelDBCoding::encodeString):
1762         (WebCore::IDBLevelDBCoding::decodeString):
1763         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
1764         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
1765         (WebCore::IDBLevelDBCoding::encodeDouble):
1766         (WebCore::IDBLevelDBCoding::decodeDouble):
1767         (WebCore::IDBLevelDBCoding::encodeIDBKey):
1768         (WebCore::IDBLevelDBCoding::decodeIDBKey):
1769         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
1770         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
1771         (WebCore::IDBLevelDBCoding::compare):
1772         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
1773         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
1774         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
1775         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
1776         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
1777         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
1778         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
1779         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
1780         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
1781         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
1782         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
1783         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
1784         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
1785         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
1786         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
1787         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
1788         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
1789         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
1790         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
1791         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
1792         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
1793         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
1794         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
1795         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
1796         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
1797         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
1798         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
1799         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
1800         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
1801         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
1802         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
1803         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
1804         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
1805         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
1806         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
1807         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
1808         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
1809         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
1810         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
1811         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
1812         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
1813         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
1814         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
1815         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
1816         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
1817         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
1818         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
1819         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
1820         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
1821         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
1822         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
1823         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
1824         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
1825         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
1826         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
1827         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
1828         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
1829         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
1830         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
1831         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
1832         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
1833         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
1834         * storage/IDBLevelDBCoding.h: Added.
1835         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
1836         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
1837         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
1838         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
1839         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
1840
1841 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1842
1843         Reviewed by Pavel Feldman.
1844
1845         Web Inspector: expose exception details when script is paused on exception
1846         https://bugs.webkit.org/show_bug.cgi?id=59591
1847
1848         When script is paused on an exception, the exception value is added as <exception>
1849         property in the local scope and the breakpoint details message says
1850         "Paused on excepion: '<exception to strin value>'."
1851
1852         * English.lproj/localizedStrings.js:
1853         * inspector/front-end/ScopeChainSidebarPane.js:
1854         (WebInspector.ScopeChainSidebarPane.prototype.update):
1855         * inspector/front-end/ScriptsPanel.js:
1856         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
1857         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
1858
1859 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
1860
1861         Reviewed by Pavel Feldman.
1862
1863         Web Inspector: [protocol] Paused event should expose exception value that caused it
1864         https://bugs.webkit.org/show_bug.cgi?id=58996
1865
1866         Debug.pause event now contains an optional reference to the exception
1867         object in case script execution is paused on a JavaScript exception.
1868
1869         Also JavaScript call frames are passed directly into the injected script when
1870         we need to wrap them for passing to the front-end. This change breaks cyclic
1871         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
1872
1873         * bindings/js/JSInjectedScriptHostCustom.cpp:
1874         * bindings/js/ScriptDebugServer.cpp:
1875         (WebCore::ScriptDebugServer::dispatchDidPause):
1876         * bindings/js/ScriptDebugServer.h:
1877         * bindings/v8/ScriptDebugServer.cpp:
1878         (WebCore::ScriptDebugServer::breakProgram):
1879         (WebCore::ScriptDebugServer::editScriptSource):
1880         (WebCore::ScriptDebugServer::breakProgramCallback):
1881         (WebCore::ScriptDebugServer::handleV8DebugEvent):
1882         * bindings/v8/ScriptDebugServer.h:
1883         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
1884         * inspector/InjectedScript.cpp:
1885         (WebCore::InjectedScript::evaluateOnCallFrame):
1886         (WebCore::InjectedScript::wrapCallFrames):
1887         * inspector/InjectedScript.h:
1888         * inspector/InjectedScriptHost.cpp:
1889         * inspector/InjectedScriptHost.h:
1890         (WebCore::InjectedScriptHost::init):
1891         * inspector/InjectedScriptHost.idl:
1892         * inspector/InjectedScriptSource.js:
1893         (.):
1894         * inspector/Inspector.json:
1895         * inspector/InspectorAgent.cpp:
1896         (WebCore::InspectorAgent::InspectorAgent):
1897         * inspector/InspectorDebuggerAgent.cpp:
1898         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
1899         (WebCore::InspectorDebuggerAgent::currentCallFrames):
1900         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
1901         (WebCore::InspectorDebuggerAgent::didPause):
1902         (WebCore::InspectorDebuggerAgent::didContinue):
1903         (WebCore::InspectorDebuggerAgent::clear):
1904         * inspector/InspectorDebuggerAgent.h:
1905         * inspector/ScriptDebugListener.h:
1906         * inspector/WorkerInspectorController.cpp:
1907         (WebCore::WorkerInspectorController::WorkerInspectorController):
1908
1909 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1910
1911         Reviewed by Yury Semikhatsky.
1912
1913         Web Inspector: implement incremental CSS editing in the structure view.
1914         https://bugs.webkit.org/show_bug.cgi?id=59455
1915
1916         * inspector/front-end/StylesSidebarPane.js:
1917         (WebInspector.StylePropertyTreeElement.prototype):
1918
1919 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
1920
1921         Reviewed by Eric Seidel.
1922
1923         Frame.h shouldn't include Document.h
1924         https://bugs.webkit.org/show_bug.cgi?id=59560
1925
1926         Frame can use a forward-declared Document if we move
1927         Frame::displayStringModifiedByEncoding's implementation out of the
1928         header.
1929                                 Size  #includes  Size * #includes
1930         Before: page/Frame.h:   0.746       653           487.138
1931                 dom/Document.h: 0.220      1306           287.320
1932         
1933         After:  page/Frame.h:   0.646       653           421.838
1934                 dom/Document.h: 0.220      1189           261.580
1935
1936         * WebCore.exp.in:
1937         * bindings/ScriptControllerBase.cpp:
1938         * bindings/generic/BindingSecurityBase.cpp:
1939         * bindings/v8/V8Proxy.cpp:
1940         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
1941         * dom/CharacterData.cpp:
1942         * dom/UserTypingGestureIndicator.cpp:
1943         * editing/chromium/SelectionControllerChromium.cpp:
1944         * inspector/InspectorDOMStorageResource.cpp:
1945         * inspector/InspectorInstrumentation.h:
1946         * loader/PingLoader.cpp:
1947         * loader/SubresourceLoader.cpp:
1948         * loader/appcache/DOMApplicationCache.cpp:
1949         * loader/cache/CachedResourceRequest.cpp:
1950         * page/Frame.cpp:
1951         (WebCore::Frame::displayStringModifiedByEncoding):
1952         * page/Frame.h:
1953         * page/Geolocation.cpp:
1954         * page/Location.cpp:
1955         * page/Navigator.cpp:
1956         * page/PageGroupLoadDeferrer.cpp:
1957         * page/PerformanceTiming.cpp:
1958         * xml/XSLTProcessorLibxslt.cpp:
1959
1960 2011-04-27  James Robinson  <jamesr@chromium.org>
1961
1962         Reviewed by Eric Seidel.
1963
1964         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
1965         https://bugs.webkit.org/show_bug.cgi?id=59377
1966
1967         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
1968         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
1969
1970         * css/CSSStyleSelector.cpp:
1971         (WebCore::CSSStyleSelector::applyProperty):
1972         * page/animation/AnimationBase.cpp:
1973         (WebCore::blendFunc):
1974         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
1975         (WebCore::PropertyWrapperShadow::blend):
1976         * rendering/style/RenderStyle.cpp:
1977         (WebCore::RenderStyle::setTextShadow):
1978         (WebCore::RenderStyle::setBoxShadow):
1979         * rendering/style/RenderStyle.h:
1980         (WebCore::InheritedFlags::textShadow):
1981         * rendering/style/ShadowData.cpp:
1982         (WebCore::ShadowData::ShadowData):
1983         * rendering/style/ShadowData.h:
1984         (WebCore::ShadowData::ShadowData):
1985         (WebCore::ShadowData::next):
1986         (WebCore::ShadowData::setNext):
1987         * rendering/style/StyleRareInheritedData.cpp:
1988         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1989         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
1990         * rendering/style/StyleRareInheritedData.h:
1991         * rendering/style/StyleRareNonInheritedData.cpp:
1992         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
1993
1994 2011-04-26  David Levin  <levin@chromium.org>
1995
1996         Reviewed by Eric Seidel.
1997
1998         Fix some strict PassOwnPtr issues in WebCore.
1999         https://bugs.webkit.org/show_bug.cgi?id=59563
2000
2001         * css/SVGCSSStyleSelector.cpp:
2002         (WebCore::CSSStyleSelector::applySVGProperty):
2003         * html/canvas/WebGLRenderingContext.cpp:
2004         (WebCore::WebGLRenderingContext::create):
2005         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
2006         * platform/text/TextCodecLatin1.cpp:
2007         (WebCore::newStreamingTextDecoderWindowsLatin1):
2008         * platform/text/TextCodecUTF16.cpp:
2009         (WebCore::newStreamingTextDecoderUTF16LE):
2010         (WebCore::newStreamingTextDecoderUTF16BE):
2011         * platform/text/TextCodecUserDefined.cpp:
2012         (WebCore::newStreamingTextDecoderUserDefined):
2013         * platform/text/mac/TextCodecMac.cpp:
2014         (WebCore::newTextCodecMac):
2015         * workers/Worker.cpp:
2016         (WebCore::Worker::notifyFinished):
2017
2018 2011-04-26  Justin Novosad  <junov@chromium.org>
2019
2020         Reviewed by Kenneth Russell.
2021
2022         [Chromium] Expose skia gpu canvas rendering as a runtime flag
2023         https://bugs.webkit.org/show_bug.cgi?id=58683
2024         Replace the SKIA_GPU compile flag by the pre-existing
2025         acceleratedDrawingEnabled flag. Most code changes are trivial:
2026         compile-time conditionals on SKIA_GPU were either replaced with
2027         a run-time check, or a compile time check on USE(SKIA) 
2028
2029         No new tests. Covered by existing tests.
2030
2031         * html/canvas/CanvasRenderingContext2D.cpp:
2032         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2033         * page/Page.cpp:
2034         (WebCore::Page::sharedGraphicsContext3D):
2035         Added check for the acceleratedDrawing flag.
2036         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2037         (WebCore::DrawingBuffer::DrawingBuffer):
2038         (WebCore::DrawingBuffer::publishToPlatformLayer):
2039         * platform/graphics/gpu/DrawingBuffer.h:
2040         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2041         (WebCore::SharedGraphicsContext3D::create):
2042         On Skia builds, this methos now receives a bool arg to turn on
2043         GPU-accelerated skia rendering
2044         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
2045         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2046         (WebCore::SharedGraphicsContext3D::grContext):
2047         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2048         * platform/graphics/skia/ImageSkia.cpp:
2049         (WebCore::computeResamplingMode):
2050         (WebCore::paintSkBitmap):
2051         (WebCore::Image::drawPattern):
2052         * platform/graphics/skia/PlatformContextSkia.cpp:
2053         (WebCore::PlatformContextSkia::PlatformContextSkia):
2054         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2055         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2056         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2057         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2058         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2059         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2060         (WebCore::PlatformContextSkia::markDirtyRect):
2061         * platform/graphics/skia/PlatformContextSkia.h:
2062         (WebCore::PlatformContextSkia::accelerationMode):
2063         (WebCore::PlatformContextSkia::useGPU):
2064         (WebCore::PlatformContextSkia::useSkiaGPU):
2065
2066 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2067
2068         Not reviewed: restore inspector test disabled in r84913.
2069
2070         Test: http/tests/inspector-enabled/dom-storage-open.html
2071
2072         * inspector/InspectorDOMStorageAgent.cpp:
2073         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2074
2075 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2076
2077         Reviewed by Tony Chang.
2078
2079         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2080         https://bugs.webkit.org/show_bug.cgi?id=59182
2081
2082         Use vertical offsets of the shaping results.
2083
2084         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2085
2086         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2087         (WebCore::ComplexTextController::ComplexTextController):
2088         Added initialization of m_startingY.
2089         (WebCore::ComplexTextController::nextScriptRun):
2090         Followed the change in handling positions.
2091         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2092         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2093         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2094         (WebCore::ComplexTextController::setGlyphPositions):
2095         Changed to use vertical offsets as same as horizontal offsets.
2096         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2097         Removed m_xPositions and Added m_positions and m_startingY.
2098         (WebCore::ComplexTextController::positions): Added.
2099         * platform/graphics/chromium/FontLinux.cpp:
2100         Followed the change in ComplexTextController.
2101         (WebCore::Font::drawComplexText): Ditto.
2102         (WebCore::Font::floatWidthForComplexText): Ditto.
2103         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2104         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2105         (WebCore::Font::selectionRectForComplexText): Ditto.
2106
2107 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2108
2109         Reviewed by Eric Seidel.
2110
2111         Root element should establish a new block formatting context
2112         https://bugs.webkit.org/show_bug.cgi?id=54573
2113
2114         Always expanding the root renderer to include overhanging floats.
2115
2116         Test: fast/block/float/float-overhangs-root.html
2117
2118         * rendering/RenderBlock.cpp:
2119         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2120
2121 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2122
2123         Reviewed by Andreas Kling.
2124
2125         [Qt] Improper rendering of <button> tag when it contains a <br>
2126         https://bugs.webkit.org/show_bug.cgi?id=50521
2127
2128         Test: platform/qt/fast/forms/button-line-break.html
2129
2130         * platform/qt/RenderThemeQt.cpp:
2131         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2132         (WebCore::RenderThemeQt::setButtonPadding):
2133
2134 2011-04-26  James Robinson  <jamesr@chromium.org>
2135
2136         Reviewed by Kenneth Russell.
2137
2138         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2139         https://bugs.webkit.org/show_bug.cgi?id=59572
2140
2141         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2142         when LayerRendererChromium was set.  We set this pointer every frame
2143         and should only reset the tiles if the new LayerRendererChromium is
2144         different from the old one (indicating a context loss), not just reset
2145         on every frame.
2146
2147         * platform/graphics/chromium/LayerTilerChromium.cpp:
2148         (WebCore::LayerTilerChromium::setLayerRenderer):
2149         * platform/graphics/chromium/LayerTilerChromium.h:
2150
2151 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2152
2153         Reviewed by Eric Seidel.
2154
2155         beginElement broken by setAttribute
2156         https://bugs.webkit.org/show_bug.cgi?id=26019
2157
2158         Test: svg/animations/animate-beginElementAt.svg
2159
2160         * svg/SVGAnimationElement.cpp:
2161         (WebCore::SVGAnimationElement::attributeChanged):
2162         Reset the animation state here as the rest of the code reads it and would still
2163         think we are animating when we are not.
2164
2165         * svg/animation/SVGSMILElement.h:
2166         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2167
2168 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2169
2170         Unreviewed, rolling out r84989.
2171         http://trac.webkit.org/changeset/84989
2172         https://bugs.webkit.org/show_bug.cgi?id=59566
2173
2174         REGRESSION (r84989): Lots of vertical text tests failing on
2175         windows (Requested by weinig on #webkit).
2176
2177         * platform/graphics/FontPlatformData.h:
2178         * platform/graphics/win/FontCacheWin.cpp:
2179         (WebCore::FontCache::getFontDataForCharacters):
2180         (WebCore::FontCache::createFontPlatformData):
2181         * platform/graphics/win/FontCustomPlatformData.cpp:
2182         (WebCore::FontCustomPlatformData::fontPlatformData):
2183         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2184         (WebCore::FontPlatformData::FontPlatformData):
2185         * platform/graphics/win/FontPlatformDataWin.cpp:
2186         (WebCore::FontPlatformData::FontPlatformData):
2187
2188 2011-04-26  Sam Weinig  <sam@webkit.org>
2189
2190         Reviewed by Eric Seidel.
2191
2192         Try again:
2193             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2194             https://bugs.webkit.org/show_bug.cgi?id=59310
2195
2196         * bindings/js/JSDOMBinding.h:
2197         (WebCore::DOMConstructorObject::DOMConstructorObject):
2198         * bindings/js/JSDOMWrapper.h:
2199         (WebCore::JSDOMWrapper::globalObject):
2200         (WebCore::JSDOMWrapper::scriptExecutionContext):
2201         (WebCore::JSDOMWrapper::createStructure):
2202         (WebCore::JSDOMWrapper::JSDOMWrapper):
2203         * bindings/scripts/CodeGeneratorJS.pm:
2204
2205 2011-04-26  Sam Weinig  <sam@webkit.org>
2206
2207         Reviewed by David Hyatt.
2208
2209         Remove Datagrid from the tree
2210         https://bugs.webkit.org/show_bug.cgi?id=59543
2211
2212         * Android.derived.jscbindings.mk:
2213         * Android.derived.v8bindings.mk:
2214         * Android.jscbindings.mk:
2215         * Android.v8bindings.mk:
2216         * CMakeLists.txt:
2217         * CodeGenerators.pri:
2218         * Configurations/FeatureDefines.xcconfig:
2219         * DerivedSources.cpp:
2220         * DerivedSources.make:
2221         * GNUmakefile.am:
2222         * GNUmakefile.list.am:
2223         * UseJSC.cmake:
2224         * WebCore.gypi:
2225         * WebCore.pro:
2226         * WebCore.vcproj/WebCore.vcproj:
2227         * WebCore.xcodeproj/project.pbxproj:
2228         * bindings/js/JSBindingsAllInOne.cpp:
2229         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2230         * bindings/js/JSDataGridDataSource.cpp: Removed.
2231         * bindings/js/JSDataGridDataSource.h: Removed.
2232         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2233         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2234         * bindings/v8/V8DataGridDataSource.h: Removed.
2235         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2236         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2237         * css/CSSStyleSelector.cpp:
2238         * css/CSSStyleSelector.h:
2239         * css/html.css:
2240         (input, textarea, keygen, select, button, isindex):
2241         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2242         * editing/htmlediting.cpp:
2243         (WebCore::canHaveChildrenForEditing):
2244         * features.pri:
2245         * html/DOMDataGridDataSource.cpp: Removed.
2246         * html/DOMDataGridDataSource.h: Removed.
2247         * html/DataGridColumn.cpp: Removed.
2248         * html/DataGridColumn.h: Removed.
2249         * html/DataGridColumn.idl: Removed.
2250         * html/DataGridColumnList.cpp: Removed.
2251         * html/DataGridColumnList.h: Removed.
2252         * html/DataGridColumnList.idl: Removed.
2253         * html/DataGridDataSource.h: Removed.
2254         * html/HTMLDataGridCellElement.cpp: Removed.
2255         * html/HTMLDataGridCellElement.h: Removed.
2256         * html/HTMLDataGridCellElement.idl: Removed.
2257         * html/HTMLDataGridColElement.cpp: Removed.
2258         * html/HTMLDataGridColElement.h: Removed.
2259         * html/HTMLDataGridColElement.idl: Removed.
2260         * html/HTMLDataGridElement.cpp: Removed.
2261         * html/HTMLDataGridElement.h: Removed.
2262         * html/HTMLDataGridElement.idl: Removed.
2263         * html/HTMLDataGridRowElement.cpp: Removed.
2264         * html/HTMLDataGridRowElement.h: Removed.
2265         * html/HTMLDataGridRowElement.idl: Removed.
2266         * html/HTMLElement.cpp:
2267         (WebCore::HTMLElement::ieForbidsInsertHTML):
2268         * html/HTMLElementsAllInOne.cpp:
2269         * html/HTMLTagNames.in:
2270         * page/DOMWindow.idl:
2271         * rendering/RenderBox.cpp:
2272         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2273         * rendering/RenderDataGrid.cpp: Removed.
2274         * rendering/RenderDataGrid.h: Removed.
2275         * rendering/RenderingAllInOne.cpp:
2276
2277 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2278
2279         Reviewed by Adele Peterson.
2280
2281         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2282         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2283
2284         This platform dependent patch makes WebKit (Windows) show the
2285         vertical writing text correctly.  Job was done by adding a prefix '@'
2286         in front of the font family name (Windows Only). No new tests added.
2287         Some layout tests images:
2288         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2289
2290         * platform/graphics/FontPlatformData.h:
2291         * platform/graphics/win/FontCacheWin.cpp:
2292         (WebCore::FontCache::getFontDataForCharacters):
2293         (WebCore::FontCache::createFontPlatformData):
2294         * platform/graphics/win/FontCustomPlatformData.cpp:
2295         (WebCore::FontCustomPlatformData::fontPlatformData):
2296         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2297         (WebCore::FontPlatformData::FontPlatformData):
2298         * platform/graphics/win/FontPlatformDataWin.cpp:
2299         (WebCore::FontPlatformData::FontPlatformData):
2300
2301 2011-04-26  Jer Noble  <jer.noble@apple.com>
2302
2303         Reviewed by Brady Eidson.
2304
2305         HTML5 video fullscreen transition causes an audio stutter
2306         https://bugs.webkit.org/show_bug.cgi?id=59544
2307
2308         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2309         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2310         layer to render it invisible, instead just set the layer as hidden.
2311
2312         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2313         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2314         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2315         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2316         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2317         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2318
2319 2011-04-26  Christian Dywan  <christian@lanedo.com>
2320
2321         Reviewed by Eric Seidel.
2322
2323         Extra separator after Select All in context menu
2324         https://bugs.webkit.org/show_bug.cgi?id=54092
2325
2326         * page/ContextMenuController.cpp: Move separator to non-GTK+
2327             port guards since it is for the spelling options menu
2328             which the GTK+ port doesn't use.
2329
2330 2011-04-26  James Robinson  <jamesr@chromium.org>
2331
2332         Reviewed by Kenneth Russell.
2333
2334         [chromium] Clear out LayerTilerChromium's tiles on lost context
2335         https://bugs.webkit.org/show_bug.cgi?id=59233
2336
2337         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
2338         no longer valid since they exist in the previous LayerRendererChromium.
2339
2340         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
2341
2342         * platform/graphics/chromium/LayerTilerChromium.h:
2343         (WebCore::LayerTilerChromium::setLayerRenderer):
2344
2345 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2346
2347         Reviewed by Dirk Schulze.
2348
2349         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
2350         https://bugs.webkit.org/show_bug.cgi?id=57644
2351
2352         Manual test: plugins/windowed-in-iframe-2.html
2353
2354         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
2355         * platform/gtk/WidgetGtk.cpp:
2356         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
2357         * plugins/PluginView.h: Added helper method to set the allocation and clip.
2358         * plugins/gtk/PluginViewGtk.cpp:
2359         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
2360         the allocation immediately. Bring this method into sync with the implementation in
2361         the Qt port.
2362         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
2363         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
2364
2365 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2366
2367         Reviewed by Eric Seidel.
2368
2369         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
2370         https://bugs.webkit.org/show_bug.cgi?id=58818
2371
2372         Prevent allocating scratch buffers larger than the target GdkDrawable
2373         when creating a WidgetRenderingContext. This prevents incredibly large
2374         widgets from crashing the X Server. This change also allowed greatly
2375         simplifying the way that the painting offset is calculated.
2376
2377         * platform/gtk/WidgetRenderingContext.cpp:
2378         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
2379         larger than the target GdkDrawable.
2380         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
2381         blit by looking at the location of the target rect itself, rather than delaying the
2382         calculation up to this point.
2383         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
2384         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
2385         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
2386         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
2387         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
2388         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
2389         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
2390         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
2391         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
2392         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
2393         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
2394         a member to store the IntSize mapping from the coordinates of the target to the coordinates
2395         of the scratch buffer.
2396
2397 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
2398
2399         Reviewed by Adam Barth.
2400
2401         Respect charset in handleDataURL
2402         https://bugs.webkit.org/show_bug.cgi?id=47746
2403
2404         Original patch by Kwang Yul Seo <skyul@company100.net>
2405
2406         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2407         returns an empty string because encoding name is not specified.
2408
2409         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2410
2411         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2412
2413         * platform/network/DataURL.cpp:
2414         (WebCore::handleDataURL):
2415
2416 2011-04-26  Anders Carlsson  <andersca@apple.com>
2417
2418         Fix clang++ build.
2419
2420         You can never have too many casts!
2421
2422         * accessibility/mac/AccessibilityObjectWrapper.mm:
2423         (-[AccessibilityObjectWrapper position]):
2424         * editing/mac/SelectionControllerMac.mm:
2425         (WebCore::accessibilityConvertScreenRect):
2426
2427 2011-04-26  Chris Rogers  <crogers@google.com>
2428
2429         Reviewed by Kenneth Russell.
2430
2431         Fix web audio build on mac port
2432         https://bugs.webkit.org/show_bug.cgi?id=59355
2433
2434         No new tests since audio API is not yet implemented.
2435
2436         * WebCore.xcodeproj/project.pbxproj:
2437         * bindings/js/JSAudioContextCustom.cpp:
2438         (WebCore::JSAudioContext::visitChildren):
2439         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
2440         (WebCore::JSJavaScriptAudioNode::visitChildren):
2441         * webaudio/AudioContext.idl:
2442
2443 2011-04-26  Chris Rogers  <crogers@google.com>
2444
2445         Reviewed by Kenneth Russell.
2446
2447         Add FFTFrame implementation for FFmpeg
2448         https://bugs.webkit.org/show_bug.cgi?id=59408
2449
2450         No new tests since audio API is not yet implemented.
2451
2452         * WebCore.gyp/WebCore.gyp:
2453         * WebCore.gypi:
2454         * platform/audio/FFTFrame.h:
2455         * platform/audio/FFTFrameStub.cpp:
2456         * platform/audio/ffmpeg: Added.
2457         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
2458         (WebCore::FFTFrame::FFTFrame):
2459         (WebCore::FFTFrame::initialize):
2460         (WebCore::FFTFrame::cleanup):
2461         (WebCore::FFTFrame::~FFTFrame):
2462         (WebCore::FFTFrame::multiply):
2463         (WebCore::FFTFrame::doFFT):
2464         (WebCore::FFTFrame::doInverseFFT):
2465         (WebCore::FFTFrame::realData):
2466         (WebCore::FFTFrame::imagData):
2467         (WebCore::FFTFrame::getUpToDateComplexData):
2468         (WebCore::FFTFrame::contextForSize):
2469         * platform/audio/mac/FFTFrameMac.cpp:
2470         * webaudio/ConvolverNode.cpp:
2471
2472 2011-04-26  Jeff Miller  <jeffm@apple.com>
2473
2474         Add a newline at the end of SVGFEDropShadowElement.idl.
2475
2476         * svg/SVGFEDropShadowElement.idl:
2477
2478 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2479
2480         Reviewed by Eric Seidel.
2481
2482         InlineBox.h shouldn't include RenderBR.h
2483         https://bugs.webkit.org/show_bug.cgi?id=59480
2484
2485         Per bug 59348 RenderBR.h is a "top header" by include * size, because
2486         InlineBox.h includes it. There's no reason why it has to.
2487
2488         * rendering/InlineBox.h:
2489         * rendering/InlineTextBox.cpp:
2490         * rendering/RenderBlock.h:
2491
2492 2011-04-26  Sam Weinig  <sam@webkit.org>
2493
2494         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
2495         I should do.
2496
2497         * bindings/js/JSDOMBinding.h:
2498         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2499         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2500         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2501         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2502         (WebCore::DOMConstructorObject::DOMConstructorObject):
2503         * bindings/js/JSDOMWrapper.h:
2504         (WebCore::JSDOMWrapper::JSDOMWrapper):
2505         * bindings/scripts/CodeGeneratorJS.pm:
2506
2507 2011-04-26  Sam Weinig  <sam@webkit.org>
2508
2509         Fix build.
2510
2511         * bindings/js/JSDOMWrapper.h:
2512         (WebCore::JSDOMWrapper::globalObject):
2513
2514 2011-04-26  Sam Weinig  <sam@webkit.org>
2515
2516         Roll r84945 back in with infinite recursion removed.
2517
2518         * bindings/js/JSDOMBinding.h:
2519         (WebCore::DOMConstructorObject::DOMConstructorObject):
2520         * bindings/js/JSDOMWrapper.h:
2521         (WebCore::JSDOMWrapper::globalObject):
2522         (WebCore::JSDOMWrapper::scriptExecutionContext):
2523         (WebCore::JSDOMWrapper::createStructure):
2524         (WebCore::JSDOMWrapper::JSDOMWrapper):
2525         * bindings/scripts/CodeGeneratorJS.pm:
2526
2527 2011-04-26  Sam Weinig  <sam@webkit.org>
2528
2529         Rollout previous patch. It broke stuff.
2530
2531         * bindings/js/JSDOMBinding.h:
2532         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2533         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2534         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2535         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2536         (WebCore::DOMConstructorObject::DOMConstructorObject):
2537         * bindings/js/JSDOMWrapper.h:
2538         (WebCore::JSDOMWrapper::JSDOMWrapper):
2539         * bindings/scripts/CodeGeneratorJS.pm:
2540
2541 2011-04-26  Sam Weinig  <sam@webkit.org>
2542
2543         Reviewed by Maciej Stachowiak.
2544
2545         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2546         https://bugs.webkit.org/show_bug.cgi?id=59310
2547
2548         * bindings/js/JSDOMBinding.h:
2549         (WebCore::DOMConstructorObject::DOMConstructorObject):
2550         * bindings/js/JSDOMWrapper.h:
2551         (WebCore::JSDOMWrapper::globalObject):
2552         (WebCore::JSDOMWrapper::scriptExecutionContext):
2553         (WebCore::JSDOMWrapper::createStructure):
2554         (WebCore::JSDOMWrapper::JSDOMWrapper):
2555         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
2556
2557         * bindings/scripts/CodeGeneratorJS.pm:
2558         Make JSDOMWrapper the base class.
2559
2560 2011-04-26  Dan Bernstein  <mitz@apple.com>
2561
2562         Reviewed by Mark Rowe.
2563
2564         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
2565
2566         * Configurations/Base.xcconfig:
2567         * Configurations/CompilerVersion.xcconfig: Added.
2568
2569 2011-04-26  Adrienne Walker  <enne@google.com>
2570
2571         Reviewed by Geoffrey Garen.
2572
2573         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
2574         https://bugs.webkit.org/show_bug.cgi?id=59469
2575
2576         * platform/chromium/TraceEvent.h:
2577         (WebCore::internal::ScopeTracer::ScopeTracer):
2578
2579 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2580
2581         Reviewed by Oliver Hunt.
2582
2583         Nixed special finalizer handling for WebCore strings
2584         https://bugs.webkit.org/show_bug.cgi?id=59425
2585
2586         Not needed anymore, since weak handles have finalizers.
2587
2588         * WebCore.exp.in: Exports!
2589
2590         * bindings/js/DOMWrapperWorld.cpp:
2591         (WebCore::JSStringOwner::finalize):
2592         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
2593         so we don't need special treatment anymore.
2594
2595         * bindings/js/DOMWrapperWorld.h:
2596         (WebCore::JSStringOwner::JSStringOwner):
2597         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
2598         instead of a WeakGCMap, so we can specify a custom finalizer.
2599
2600         * bindings/js/JSDOMBinding.cpp:
2601         (WebCore::jsStringSlowCase):
2602         * bindings/js/JSDOMBinding.h:
2603         (WebCore::jsString): Updated for string map change.
2604
2605 2011-04-26  David Kilzer  <ddkilzer@apple.com>
2606
2607         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
2608
2609         Reviewed by Antti Koivisto.
2610
2611         To enable HTTP pipelining post-SnowLeopard, use this command:
2612
2613             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
2614
2615         * platform/network/cf/ResourceRequestCFNet.cpp:
2616         (WebCore::readBooleanPreference): Re-added.  Originally added in
2617         r76756 and removed in r84120.
2618         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
2619         HTTP pipelining if use default is set to true.  Added macro
2620         guards to match those in ResourceRequestMac.mm.
2621
2622 2011-04-26  Antti Koivisto  <antti@apple.com>
2623
2624         Reviewed by Adele Peterson.
2625
2626         Don't strip fragments from file: urls in memory cache
2627         https://bugs.webkit.org/show_bug.cgi?id=59463
2628         <rdar://problem/9231130>
2629
2630         Some clients expect file: resources to be unique based on fragment identifier. 
2631         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
2632
2633         Test: fast/loader/file-protocol-fragment.html
2634
2635         * loader/cache/MemoryCache.cpp:
2636         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
2637
2638 2011-04-26  David Levin  <levin@chromium.org>
2639
2640         Reviewed by Darin Adler.
2641
2642         Fix more strict OwnPtr in WebCore (round N).
2643         https://bugs.webkit.org/show_bug.cgi?id=59464
2644
2645         * dom/Document.cpp:
2646         (WebCore::Document::Document):
2647         (WebCore::Document::attach):
2648         * fileapi/FileReader.cpp:
2649         (WebCore::FileReader::terminate):
2650         * loader/DocumentThreadableLoader.cpp:
2651         (WebCore::DocumentThreadableLoader::preflightFailure):
2652         * workers/DefaultSharedWorkerRepository.cpp:
2653         (WebCore::SharedWorkerConnectTask::create):
2654         (WebCore::SharedWorkerScriptLoader::load):
2655
2656 2011-04-26  Ruben  <chromium@hybridsource.org>
2657
2658         Reviewed by Tony Chang.
2659
2660         Change linux ifdefs for Chromium to Unix instead, allowing
2661         new Unix ports to be enabled by default
2662         https://bugs.webkit.org/show_bug.cgi?id=59297
2663
2664         No new tests, just changing preprocessor defines.
2665
2666         * bindings/js/JSInspectorFrontendHostCustom.cpp:
2667         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
2668         * dom/SelectElement.cpp:
2669         * loader/cache/CachedFont.cpp:
2670         * page/EventHandler.cpp:
2671         * page/chromium/EventHandlerChromium.cpp:
2672         * platform/Scrollbar.cpp:
2673         * platform/chromium/PlatformBridge.h:
2674         * platform/graphics/chromium/FontPlatformData.h:
2675         * platform/graphics/skia/FontCustomPlatformData.cpp:
2676         * platform/graphics/skia/FontCustomPlatformData.h:
2677
2678 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2679
2680         Reviewed by Dan Bernstein.
2681
2682         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
2683         https://bugs.webkit.org/show_bug.cgi?id=49111
2684
2685         Even when the offset corresponds to a position visually left of the box
2686         and there aren't any inline boxes on the left, the previous/next position
2687         may still correspond to some position in the same line.
2688
2689         The bug was caused by our ignoring such cases. Fixed the bug by comparing
2690         previous/next position's inline box to the current box. If they match,
2691         then we stay on the same position because moving to the left visually at
2692         the left edge should not result in a position on the same line.
2693
2694         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
2695         the left edge or to the right edge, and a bug that WebKit could not move to
2696         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
2697
2698         Test cases are added to editing/selection/move-left-right.html
2699
2700         * editing/VisiblePosition.cpp:
2701         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
2702         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
2703
2704 2011-04-26  Gabor Loki  <loki@webkit.org>
2705
2706         Reviewed by Csaba Osztrogon√°c.
2707
2708         Speeding up SVG filters with multicore (SMP) support
2709         https://bugs.webkit.org/show_bug.cgi?id=43903
2710
2711         Some SVG filters execute a huge number of pixel manipulations, which
2712         cannot be sped up by graphics accelerators, since their algorithm is
2713         too complex. Using the power of Symmetric Multi Processing (SMP) we
2714         can split up a task to smaller (data independent) tasks, which can be
2715         executed independently.
2716
2717         The ParallelJobs framework provides a simple way for distributed
2718         programming. The framework is based on WebKit's threading infrastructure,
2719         Open Multi-Processing's (OpenMP) API, and libdispatch API.
2720
2721         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
2722         * platform/graphics/filters/FETurbulence.cpp:
2723         (WebCore::FETurbulence::PaintingData::PaintingData):
2724         (WebCore::FETurbulence::noise2D):
2725         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
2726         (WebCore::FETurbulence::fillRegion):
2727         (WebCore::FETurbulence::fillRegionWorker):
2728         (WebCore::FETurbulence::apply):
2729         * platform/graphics/filters/FETurbulence.h:
2730
2731 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2732
2733         Reviewed by Yury Semikhatsky.
2734
2735         Web Inspector: close button is off in docked mode on a mac.
2736         https://bugs.webkit.org/show_bug.cgi?id=59453
2737
2738         * inspector/front-end/inspector.css:
2739         (.toolbar-item.close-left):
2740
2741 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2742
2743         Reviewed by Yury Semikhatsky.
2744
2745         Web Inspector: New Style is not working (UI glitch)
2746         https://bugs.webkit.org/show_bug.cgi?id=59451
2747
2748         * inspector/InspectorDOMStorageAgent.cpp:
2749         (WebCore::InspectorDOMStorageAgent::setFrontend):
2750         * inspector/front-end/AuditRules.js:
2751         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
2752         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
2753         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
2754         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
2755         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
2756         * inspector/front-end/CSSStyleModel.js:
2757         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
2758         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
2759         (WebInspector.CSSStyleModel.prototype.addRule):
2760         (WebInspector.CSSStyleModel.prototype.addRule.callback):
2761         (WebInspector.CSSStyleModel.prototype._documentElementId):
2762         * inspector/front-end/DOMAgent.js:
2763         (WebInspector.DOMNode.prototype._addAttribute):
2764         (WebInspector.DOMNode.prototype.documentElement):
2765         * inspector/front-end/ResourceTreeModel.js:
2766         (WebInspector.PageDispatcher.prototype.frameDetached):
2767         * inspector/front-end/StylesSidebarPane.js:
2768         (WebInspector.StylesSidebarPane.prototype._createNewRule):
2769
2770 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2771
2772         Reviewed by Yury Semikhatsky.
2773
2774         Web Inspector: introduce DOMStorage::enable and disable.
2775         https://bugs.webkit.org/show_bug.cgi?id=59445
2776
2777         * inspector/Inspector.json:
2778         * inspector/InspectorAgent.cpp:
2779         (WebCore::InspectorAgent::InspectorAgent):
2780         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2781         * inspector/InspectorDOMStorageAgent.cpp:
2782         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2783         (WebCore::InspectorDOMStorageAgent::restore):
2784         (WebCore::InspectorDOMStorageAgent::enable):
2785         (WebCore::InspectorDOMStorageAgent::disable):
2786         * inspector/InspectorDOMStorageAgent.h:
2787         (WebCore::InspectorDOMStorageAgent::create):
2788         * inspector/front-end/DOMStorage.js:
2789         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2790         * inspector/front-end/ResourcesPanel.js:
2791         (WebInspector.ResourcesPanel.prototype._reset):
2792         * inspector/front-end/inspector.js:
2793
2794 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2795
2796         Reviewed by Yury Semikhatsky.
2797
2798         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
2799         https://bugs.webkit.org/show_bug.cgi?id=59440
2800
2801         * inspector/Inspector.json:
2802         * inspector/InspectorAgent.cpp:
2803         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2804         * inspector/InspectorPageAgent.cpp:
2805         (WebCore::InspectorPageAgent::setFrontend):
2806         (WebCore::InspectorPageAgent::frameNavigated):
2807         * inspector/InspectorPageAgent.h:
2808         * inspector/front-end/AuditsPanel.js:
2809         (WebInspector.AuditsPanel):
2810         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
2811         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
2812         * inspector/front-end/CSSStyleModel.js:
2813         (WebInspector.CSSStyleModelResourceBinding):
2814         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
2815         * inspector/front-end/DOMBreakpointsSidebarPane.js:
2816         (WebInspector.DOMBreakpointsSidebarPane):
2817         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
2818         * inspector/front-end/DOMStorage.js:
2819         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2820         * inspector/front-end/ExtensionServer.js:
2821         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
2822         (WebInspector.ExtensionServer.prototype.initExtensions):
2823         * inspector/front-end/NetworkPanel.js:
2824         (WebInspector.NetworkPanel):
2825         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
2826         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
2827         (WebInspector.NetworkPanel.prototype._frameNavigated):
2828         * inspector/front-end/ResourceTreeModel.js:
2829         (WebInspector.ResourceTreeModel):
2830         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2831         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
2832         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2833         (WebInspector.ResourceTreeModel.prototype._frameDetached):
2834         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
2835         (WebInspector.PageDispatcher):
2836         (WebInspector.PageDispatcher.prototype.domContentEventFired):
2837         (WebInspector.PageDispatcher.prototype.loadEventFired):
2838         (WebInspector.PageDispatcher.prototype.frameNavigated):
2839         (WebInspector.PageDispatcher.prototype.frameDetached):
2840         * inspector/front-end/ResourcesPanel.js:
2841         (WebInspector.ResourcesPanel):
2842         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
2843         (WebInspector.ResourcesPanel.prototype._frameNavigated):
2844         * inspector/front-end/inspector.js:
2845
2846 2011-04-26  Csaba Osztrogon√°c  <ossy@webkit.org>
2847
2848         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
2849         because it broke transitions/multiple-text-shadow-transition.html
2850
2851         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2852         https://bugs.webkit.org/show_bug.cgi?id=59377
2853
2854         * css/CSSStyleSelector.cpp:
2855         (WebCore::CSSStyleSelector::applyProperty):
2856         * page/animation/AnimationBase.cpp:
2857         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2858         (WebCore::PropertyWrapperShadow::blend):
2859         * rendering/style/RenderStyle.cpp:
2860         (WebCore::RenderStyle::setTextShadow):
2861         (WebCore::RenderStyle::setBoxShadow):
2862         * rendering/style/RenderStyle.h:
2863         (WebCore::InheritedFlags::textShadow):
2864         * rendering/style/StyleRareInheritedData.cpp:
2865         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2866         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2867         * rendering/style/StyleRareInheritedData.h:
2868         * rendering/style/StyleRareNonInheritedData.cpp:
2869         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2870
2871 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2872
2873         Reviewed by Adam Barth.
2874
2875         Turn off make built-in implicit rules for derived sources makefile
2876         https://bugs.webkit.org/show_bug.cgi?id=59418
2877
2878         We don't use any of make's built-in implicit rules, turning them off
2879         speeds up parsing of the makefile.
2880
2881         * WebCore.xcodeproj/project.pbxproj:
2882         * gyp/generate-derived-sources.sh:
2883
2884 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
2885
2886         Reviewed by Nikolas Zimmermann.
2887
2888         ASSERT failure in SVGUseElement
2889         https://bugs.webkit.org/show_bug.cgi?id=59313
2890
2891         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
2892         was wrong because the document may not be well-formed.
2893
2894         This patch asserts the element is not pending on resource or the
2895         document is not well-formed.
2896
2897         Test: svg/custom/use-crash-in-non-wellformed-document.svg
2898
2899         * svg/SVGUseElement.cpp:
2900         (WebCore::isWellFormedDocument):
2901         (WebCore::SVGUseElement::insertedIntoDocument):
2902
2903 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
2904
2905         Reviewed by Pavel Feldman.
2906
2907         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
2908         https://bugs.webkit.org/show_bug.cgi?id=59438
2909
2910         * inspector/front-end/DetailedHeapshotView.js:
2911         (WebInspector.DetailedHeapshotView.prototype._changeView):
2912
2913 2011-04-26  David Levin  <levin@chromium.org>
2914
2915         Reviewed by Adam Barth.
2916
2917         Fix a few OwnPtr strict errors in WebCore headers.
2918         https://bugs.webkit.org/show_bug.cgi?id=59431
2919
2920         * bindings/js/ScheduledAction.cpp:
2921         (WebCore::ScheduledAction::create):
2922         * css/MediaQueryMatcher.cpp:
2923         (WebCore::MediaQueryMatcher::prepareEvaluator):
2924         * dom/NodeRareData.h:
2925         (WebCore::NodeListsNodeData::create):
2926         * dom/ScriptRunner.h:
2927         (WebCore::ScriptRunner::create):
2928         * inspector/WorkerInspectorController.cpp:
2929         (WebCore::WorkerInspectorController::connectFrontend):
2930         * loader/icon/IconDatabase.h:
2931         (WebCore::IconDatabase::create):
2932         * platform/graphics/SimpleFontData.cpp:
2933         (WebCore::SimpleFontData::verticalRightOrientationFontData):
2934         (WebCore::SimpleFontData::uprightOrientationFontData):
2935         (WebCore::SimpleFontData::brokenIdeographFontData):
2936         * rendering/style/StyleRareInheritedData.cpp:
2937         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2938         * rendering/svg/SVGResources.h:
2939         (WebCore::SVGResources::ClipperFilterMaskerData::create):
2940         (WebCore::SVGResources::MarkerData::create):
2941         (WebCore::SVGResources::FillStrokeData::create):
2942         * storage/StorageSyncManager.cpp:
2943         (WebCore::StorageSyncManager::close):
2944         * workers/WorkerContext.cpp:
2945         (WebCore::CloseWorkerContextTask::create):
2946         * workers/WorkerMessagingProxy.cpp:
2947         (WebCore::MessageWorkerContextTask::create):
2948         (WebCore::MessageWorkerTask::create):
2949         (WebCore::WorkerExceptionTask::create):
2950         (WebCore::WorkerContextDestroyedTask::create):
2951         (WebCore::WorkerTerminateTask::create):
2952         (WebCore::WorkerThreadActivityReportTask::create):
2953         * workers/WorkerRunLoop.cpp:
2954         (WebCore::WorkerRunLoop::Task::create):
2955         * workers/WorkerThread.cpp:
2956         (WebCore::WorkerThreadStartupData::create):
2957         (WebCore::WorkerThreadShutdownFinishTask::create):
2958         (WebCore::WorkerThreadShutdownStartTask::create):
2959
2960 2011-04-26  Adam Klein  <adamk@chromium.org>
2961
2962         Reviewed by Adam Barth.
2963
2964         Fix last strict OwnPtr violation under svg/...
2965         https://bugs.webkit.org/show_bug.cgi?id=59429
2966
2967         * svg/SVGDocumentExtensions.cpp:
2968         (WebCore::SVGDocumentExtensions::removePendingResource):
2969
2970 2011-04-26  Adam Barth  <abarth@webkit.org>
2971
2972         Reviewed by David Levin.
2973
2974         Fix more strict OwnPtr violations in WebCore
2975         https://bugs.webkit.org/show_bug.cgi?id=59433
2976
2977         These manifest in the Chromium build.
2978
2979         * bindings/v8/ScriptController.cpp:
2980         (WebCore::ScriptController::ScriptController):
2981         * bindings/v8/ScriptDebugServer.cpp:
2982         (WebCore::ScriptDebugServer::editScriptSource):
2983         * bindings/v8/V8DOMMap.cpp:
2984         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
2985         * bindings/v8/V8Proxy.cpp:
2986         (WebCore::V8Proxy::precompileScript):
2987         * bindings/v8/WorkerScriptController.cpp:
2988         (WebCore::WorkerScriptController::WorkerScriptController):
2989         * page/Page.cpp:
2990         (WebCore::Page::Page):
2991         (WebCore::Page::speechInput):
2992         * platform/PlatformGestureRecognizer.cpp:
2993         (WebCore::PlatformGestureRecognizer::create):
2994         * platform/PlatformGestureRecognizer.h:
2995         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2996         (WebCore::DrawingBuffer::DrawingBuffer):
2997         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2998         (WebCore::CCLayerImpl::CCLayerImpl):
2999         * platform/graphics/gpu/Texture.cpp:
3000         (WebCore::Texture::create):
3001         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
3002         (WebCore::BMPImageDecoder::decodeHelper):
3003         * platform/image-decoders/gif/GIFImageDecoder.cpp:
3004         (WebCore::GIFImageDecoder::decode):
3005         * platform/image-decoders/ico/ICOImageDecoder.cpp:
3006         (WebCore::ICOImageDecoder::decodeAtIndex):
3007         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3008         (WebCore::JPEGImageDecoder::decode):
3009         * platform/image-decoders/png/PNGImageDecoder.cpp:
3010         (WebCore::PNGImageDecoder::decode):
3011         * storage/chromium/DatabaseTrackerChromium.cpp:
3012         (WebCore::DatabaseTracker::addOpenDatabase):
3013
3014 2011-04-25  David Levin  <levin@chromium.org>
3015
3016         Reviewed by Adam Barth.
3017
3018         Fix OwnPtr strict errors in CrossThreadTask.h
3019         https://bugs.webkit.org/show_bug.cgi?id=59427
3020
3021         * dom/CrossThreadTask.h:
3022         (WebCore::CrossThreadTask1::create):
3023         (WebCore::CrossThreadTask2::create):
3024         (WebCore::CrossThreadTask3::create):
3025         (WebCore::CrossThreadTask4::create):
3026         (WebCore::CrossThreadTask5::create):
3027         (WebCore::CrossThreadTask6::create):
3028         (WebCore::CrossThreadTask7::create):
3029         (WebCore::CrossThreadTask8::create):
3030
3031 2011-04-25  Mark Rowe  <mrowe@apple.com>
3032
3033         Reviewed by Dan Bernstein.
3034
3035         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
3036
3037         * css/CSSStyleApplyProperty.cpp:
3038         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
3039         * css/CSSStyleApplyProperty.h:
3040         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
3041
3042 2011-04-25  Levi Weintraub  <leviw@chromium.org>
3043
3044         Reviewed by Ryosuke Niwa.
3045
3046         REGRESSION: a character appears after tab span when typing immediately before the tab span
3047         https://bugs.webkit.org/show_bug.cgi?id=58132
3048
3049         Correcting the order of operations we use to avoid inserting into invalid positions in
3050         ReplaceSelectionCommand to avoid inserting into tab-spans.
3051
3052         Test: editing/pasteboard/paste-before-tab-span.html
3053
3054         * editing/ReplaceSelectionCommand.cpp:
3055         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
3056         positionAvoidingPrecedingNodes, since that function could once again put our position
3057         inside a tab span.
3058
3059 2011-04-25  David Levin  <levin@chromium.org>
3060
3061         Reviewed by Adam Barth.
3062
3063         Fix OwnPtr strict error in ImageBuffer.h
3064         https://bugs.webkit.org/show_bug.cgi?id=59422
3065
3066         * platform/graphics/ImageBuffer.h:
3067         (WebCore::ImageBuffer::create):
3068
3069 2011-04-25  Adam Barth  <abarth@webkit.org>
3070
3071         Reviewed by David Levin.
3072
3073         Fix strict OwnPtr violations and whitelist known-tricky files
3074         https://bugs.webkit.org/show_bug.cgi?id=59421
3075
3076         With this patch, WebCore builds cleanly with strict OwnPtrs.
3077
3078         * dom/MessagePort.cpp:
3079         (WebCore::MessagePort::MessagePort):
3080         * dom/XMLDocumentParserLibxml2.cpp:
3081         * page/ContextMenuController.cpp:
3082         (WebCore::ContextMenuController::ContextMenuController):
3083         (WebCore::ContextMenuController::clearContextMenu):
3084         * page/PluginHalter.cpp:
3085         * platform/graphics/MediaPlayer.cpp:
3086         * platform/network/ResourceRequestBase.cpp:
3087         (WebCore::ResourceRequestBase::adopt):
3088         (WebCore::ResourceRequestBase::copyData):
3089         * svg/SVGDocumentExtensions.cpp:
3090
3091 2011-04-25  David Levin  <levin@chromium.org>
3092
3093         Reviewed by Adam Barth.
3094
3095         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
3096         https://bugs.webkit.org/show_bug.cgi?id=59419
3097
3098         * dom/DatasetDOMStringMap.h:
3099         (WebCore::DatasetDOMStringMap::create):
3100
3101 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3102
3103         Reviewed by Eric Seidel.
3104
3105         KeyboardEvent.cpp should work with strict OwnPtrs.
3106         https://bugs.webkit.org/show_bug.cgi?id=59403
3107
3108         * dom/KeyboardEvent.cpp:
3109         (WebCore::KeyboardEvent::KeyboardEvent):
3110
3111 2011-04-25  James Robinson  <jamesr@chromium.org>
3112
3113         Reviewed by Eric Seidel.
3114
3115         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3116         https://bugs.webkit.org/show_bug.cgi?id=59377
3117
3118         * css/CSSStyleSelector.cpp:
3119         (WebCore::CSSStyleSelector::applyProperty):
3120         * page/animation/AnimationBase.cpp:
3121         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3122         (WebCore::PropertyWrapperShadow::blend):
3123         * rendering/style/RenderStyle.cpp:
3124         (WebCore::RenderStyle::setTextShadow):
3125         (WebCore::RenderStyle::setBoxShadow):
3126         * rendering/style/RenderStyle.h:
3127         (WebCore::InheritedFlags::textShadow):
3128         * rendering/style/StyleRareInheritedData.cpp:
3129         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3130         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3131         * rendering/style/StyleRareInheritedData.h:
3132         * rendering/style/StyleRareNonInheritedData.cpp:
3133         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3134
3135 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3136
3137         Unreviewed, rolling out r84864.
3138         http://trac.webkit.org/changeset/84864
3139         https://bugs.webkit.org/show_bug.cgi?id=59413
3140
3141         Expect result of use-crash-in-non-wellformed-document.svg is
3142         platform dependent (Requested by leoyang on #webkit).
3143
3144         * svg/SVGUseElement.cpp:
3145         (WebCore::SVGUseElement::insertedIntoDocument):
3146
3147 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
3148
3149         Reviewed by Nikolas Zimmermann.
3150
3151         ASSERT failure in SVGUseElement
3152         https://bugs.webkit.org/show_bug.cgi?id=59313
3153
3154         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3155         was wrong because the document may not be well-formed.
3156
3157         This patch asserts the element is not pending on resource or the
3158         document is not well-formed.
3159
3160         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3161
3162         * svg/SVGUseElement.cpp:
3163         (WebCore::isWellFormedDocument):
3164         (WebCore::SVGUseElement::insertedIntoDocument):
3165
3166 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3167
3168         Reviewed by Tony Chang.
3169
3170         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3171         https://bugs.webkit.org/show_bug.cgi?id=59028
3172
3173         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3174         Moving the code for base class we can reduce the efforts to support DataTransferItems
3175         element in different platforms.
3176
3177         * Android.mk:
3178         * CMakeLists.txt:
3179         * GNUmakefile.list.am:
3180         * WebCore.gypi:
3181         * WebCore.pro:
3182         * WebCore.vcproj/WebCore.vcproj:
3183         * WebCore.xcodeproj/project.pbxproj:
3184         * dom/DataTransferItem.cpp:
3185         (WebCore::DataTransferItem::DataTransferItem):
3186         (WebCore::DataTransferItem::owner):
3187         (WebCore::DataTransferItem::kind):
3188         (WebCore::DataTransferItem::type):
3189         * dom/DataTransferItem.h:
3190         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3191         (WebCore::DataTransferItems::DataTransferItems):
3192         (WebCore::DataTransferItems::length):
3193         (WebCore::DataTransferItems::item):
3194         (WebCore::DataTransferItems::deleteItem):
3195         (WebCore::DataTransferItems::clear):
3196         (WebCore::DataTransferItems::add):
3197         * dom/DataTransferItems.h:
3198         * platform/chromium/DataTransferItemChromium.cpp:
3199         (WebCore::DataTransferItem::create):
3200         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3201         (WebCore::DataTransferItemChromium::getAsString):
3202         (WebCore::DataTransferItemChromium::getAsFile):
3203         * platform/chromium/DataTransferItemChromium.h:
3204         * platform/chromium/DataTransferItemsChromium.cpp:
3205         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3206         * platform/chromium/DataTransferItemsChromium.h:
3207
3208 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3209
3210         Reviewed by Simon Fraser.
3211
3212         REGRESSION(75137): directly composited images are double-drawn sometimes
3213         https://bugs.webkit.org/show_bug.cgi?id=58632
3214
3215         Depending on the order of operations (layout, creating compositing 
3216         layers and creating simple image layers) a layer can have both image
3217         content and have m_drawsContent=true. In this case 2 copies of the image
3218         are drawn in the layer. If the image has alpha, it looks wrong.
3219
3220         I added an updateDrawsContent() call after setting the image contents
3221         to make sure it's correct.
3222
3223         I couldn't create a test case that shows the problem because layerTreeAsText()
3224         doesn't emit enough info to show this level of detail. I've opened
3225         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3226
3227         * rendering/RenderLayerBacking.cpp:
3228         (WebCore::RenderLayerBacking::updateImageContents):
3229
3230 2011-04-25  Kenneth Russell  <kbr@google.com>
3231
3232         Reviewed by David Levin.
3233
3234         Fix OwnPtr strict errors in InlineFlowBox.cpp
3235         https://bugs.webkit.org/show_bug.cgi?id=59392
3236
3237         * rendering/InlineFlowBox.cpp:
3238         (WebCore::InlineFlowBox::setLayoutOverflow):
3239         (WebCore::InlineFlowBox::setVisualOverflow):
3240
3241 2011-04-25  Kenneth Russell  <kbr@google.com>
3242
3243         Reviewed by David Levin.
3244
3245         Fix OwnPtr strict errors in TransformState.cpp
3246         https://bugs.webkit.org/show_bug.cgi?id=59380
3247
3248         * rendering/TransformState.cpp:
3249         (WebCore::TransformState::applyTransform):
3250
3251 2011-04-25  Adam Barth  <abarth@webkit.org>
3252
3253         Reviewed by James Robinson.
3254
3255         DOMWindow.cpp should work with strict OwnPtrs
3256         https://bugs.webkit.org/show_bug.cgi?id=59356
3257
3258         * page/DOMWindow.cpp:
3259         (WebCore::PostMessageTimer::fired):
3260         (WebCore::DOMWindow::postMessageTimerFired):
3261         * page/DOMWindow.h:
3262
3263 2011-04-25  Adam Klein  <adamk@chromium.org>
3264
3265         Reviewed by James Robinson.
3266
3267         Fix OwnPtr strict errors in some SVG classes.
3268         https://bugs.webkit.org/show_bug.cgi?id=59395
3269
3270         * rendering/style/SVGRenderStyleDefs.cpp:
3271         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3272         * svg/SVGSVGElement.cpp:
3273         (WebCore::SVGSVGElement::SVGSVGElement):
3274         * svg/SVGStyledTransformableElement.cpp:
3275         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3276         * svg/SVGTextElement.cpp:
3277         (WebCore::SVGTextElement::supplementalTransform):
3278         * svg/graphics/SVGImage.cpp:
3279         (WebCore::SVGImage::dataChanged):
3280
3281 2011-04-25  Adam Barth  <abarth@webkit.org>
3282
3283         Re-land changes to ValidationMessage.
3284
3285         * html/ValidationMessage.cpp:
3286         (WebCore::ValidationMessage::setMessage):
3287         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3288         (WebCore::ValidationMessage::requestToHideMessage):
3289
3290 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3291
3292         Reviewed by James Robinson.
3293
3294         fix OwnPtr strict error in FrameView.cpp
3295         https://bugs.webkit.org/show_bug.cgi?id=59402
3296
3297         * page/FrameView.cpp:
3298         (WebCore::FrameView::FrameView):
3299         (WebCore::FrameView::addWidgetToUpdate):
3300
3301 2011-04-25  Adam Klein  <adamk@chromium.org>
3302
3303         Unreviewed, rolling out r84844.
3304         http://trac.webkit.org/changeset/84844
3305         https://bugs.webkit.org/show_bug.cgi?id=59395
3306
3307         Checked in too much.
3308
3309         * rendering/style/SVGRenderStyleDefs.cpp:
3310         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3311         * svg/SVGDocumentExtensions.cpp:
3312         (WebCore::SVGDocumentExtensions::removePendingResource):
3313         * svg/SVGSVGElement.cpp:
3314         (WebCore::SVGSVGElement::SVGSVGElement):
3315         * svg/SVGStyledTransformableElement.cpp:
3316         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3317         * svg/SVGTextElement.cpp:
3318         (WebCore::SVGTextElement::supplementalTransform):
3319         * svg/graphics/SVGImage.cpp:
3320         (WebCore::SVGImage::dataChanged):
3321
3322 2011-04-25  Adrienne Walker  <enne@google.com>
3323
3324         Reviewed by David Levin.
3325
3326         Make ActiveDOMCallback play nice with OwnPtr strict mode
3327         https://bugs.webkit.org/show_bug.cgi?id=59398
3328
3329         * bindings/generic/ActiveDOMCallback.cpp:
3330         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
3331
3332 2011-04-25  Adam Klein  <adamk@chromium.org>
3333
3334         Reviewed by James Robinson.
3335
3336         Fix OwnPtr strict errors in some SVG classes.
3337         https://bugs.webkit.org/show_bug.cgi?id=59395
3338
3339         * rendering/style/SVGRenderStyleDefs.cpp:
3340         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3341         * svg/SVGSVGElement.cpp:
3342         (WebCore::SVGSVGElement::SVGSVGElement):
3343         * svg/SVGStyledTransformableElement.cpp:
3344         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3345         * svg/SVGTextElement.cpp:
3346         (WebCore::SVGTextElement::supplementalTransform):
3347         * svg/graphics/SVGImage.cpp:
3348         (WebCore::SVGImage::dataChanged):
3349
3350 2011-04-25  James Robinson  <jamesr@chromium.org>
3351
3352         Unreviewed, rolling out r84835.
3353         http://trac.webkit.org/changeset/84835
3354         https://bugs.webkit.org/show_bug.cgi?id=59394
3355
3356         Breaks compile because Deque<OwnPtr> doesn't work
3357
3358         * dom/XMLDocumentParserLibxml2.cpp:
3359         (WebCore::PendingCallbacks::~PendingCallbacks):
3360         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3361         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3362         (WebCore::PendingCallbacks::appendCharactersCallback):
3363         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3364         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3365         (WebCore::PendingCallbacks::appendCommentCallback):
3366         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3367         (WebCore::PendingCallbacks::appendErrorCallback):
3368         (WebCore::XMLDocumentParser::XMLDocumentParser):
3369         * html/ValidationMessage.cpp:
3370         (WebCore::ValidationMessage::setMessage):
3371         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3372         (WebCore::ValidationMessage::requestToHideMessage):
3373
3374 2011-04-25  James Robinson  <jamesr@chromium.org>
3375
3376         Reviewed by Sam Weinig.
3377
3378         Fix OwnPtr strict mode violation in ImageBufferCG
3379         https://bugs.webkit.org/show_bug.cgi?id=59396
3380
3381         * platform/graphics/cg/ImageBufferCG.cpp:
3382         (WebCore::ImageBuffer::ImageBuffer):
3383
3384 2011-04-25  Huang Dongsung  <luxtella@company100.net>
3385
3386         Reviewed by Dirk Schulze.
3387
3388         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
3389         https://bugs.webkit.org/show_bug.cgi?id=59308
3390
3391         An unused local variable is created and even allocates heap memory.
3392
3393         * platform/graphics/skia/PlatformContextSkia.cpp:
3394         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
3395
3396 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3397
3398         Qt build fix: Updated files not used by other ports for rename.
3399
3400         * bindings/js/JSTouchCustom.cpp:
3401         (WebCore::toJSNewlyCreated):
3402         * bindings/js/JSTouchListCustom.cpp:
3403         (WebCore::toJSNewlyCreated):
3404
3405 2011-04-25  Adrienne Walker  <enne@google.com>
3406
3407         Reviewed by David Levin.
3408
3409         WebCore/css/CSS* files should play nice with strict OwnPtrs
3410         https://bugs.webkit.org/show_bug.cgi?id=59382
3411
3412         * css/CSSFontFaceSource.cpp:
3413         (WebCore::CSSFontFaceSource::getFontData):
3414         * css/CSSParser.cpp:
3415         (WebCore::CSSParser::addProperty):
3416         (WebCore::CSSParser::parseValue):
3417
3418 2011-04-25  Adam Barth  <abarth@webkit.org>
3419
3420         Reviewed by James Robinson.
3421
3422         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
3423         https://bugs.webkit.org/show_bug.cgi?id=59394
3424
3425         * dom/XMLDocumentParserLibxml2.cpp:
3426         (WebCore::PendingCallbacks::PendingCallbacks):
3427         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3428         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3429         (WebCore::PendingCallbacks::appendCharactersCallback):
3430         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3431         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3432         (WebCore::PendingCallbacks::appendCommentCallback):
3433         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3434         (WebCore::PendingCallbacks::appendErrorCallback):
3435         (WebCore::XMLDocumentParser::XMLDocumentParser):
3436         * html/ValidationMessage.cpp:
3437         (WebCore::ValidationMessage::setMessage):
3438         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3439         (WebCore::ValidationMessage::requestToHideMessage):
3440
3441 2011-04-25  James Robinson  <jamesr@chromium.org>
3442
3443         Reviewed by Adam Barth.
3444
3445         Fix OwnPtr strictness issues in WebCore/inspector/
3446         https://bugs.webkit.org/show_bug.cgi?id=59387
3447
3448         * inspector/InspectorAgent.cpp:
3449         (WebCore::InspectorAgent::InspectorAgent):
3450         * inspector/InspectorController.cpp:
3451         (WebCore::InspectorController::InspectorController):
3452         * inspector/InspectorStyleSheet.cpp:
3453         (WebCore::InspectorStyleSheet::ensureSourceData):
3454
3455 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3456
3457         Reviewed by Beth Dakin.
3458
3459         Removed XPathNamespace because it was unused
3460         https://bugs.webkit.org/show_bug.cgi?id=59381
3461         
3462         This allows us to make Node::ownerDocument() non-virtual, though it has
3463         the unhappy side-effect of rebuilding the world.
3464
3465         * CMakeLists.txt:
3466         * GNUmakefile.list.am:
3467         * WebCore.gypi:
3468         * WebCore.pro:
3469         * WebCore.vcproj/WebCore.vcproj:
3470         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
3471
3472         * dom/Node.h: Hello fast code!
3473
3474         * xml/XPathNamespace.cpp: Removed.
3475         * xml/XPathNamespace.h: Removed.
3476
3477 2011-04-25  Adam Barth  <abarth@webkit.org>
3478
3479         Reviewed by Darin Adler.
3480
3481         HistoryItemMac should play nice with OwnPtrs
3482         https://bugs.webkit.org/show_bug.cgi?id=59388
3483
3484         * history/mac/HistoryItemMac.mm:
3485         (WebCore::HistoryItem::setTransientProperty):
3486
3487 2011-04-25  David Levin  <levin@chromium.org>
3488
3489         Reviewed by Kenneth Russell.
3490
3491         Fix strict OwnPtrs in ContextMenuController.cpp
3492         https://bugs.webkit.org/show_bug.cgi?id=59375
3493
3494         * page/ContextMenuController.cpp:
3495         (WebCore::ContextMenuController::createContextMenu):
3496         (WebCore::separatorItem):
3497
3498 2011-04-25  Adam Barth  <abarth@webkit.org>
3499
3500         Reviewed by Darin Adler.
3501
3502         CheckedRadioButton should play nice with strict OwnPtr
3503         https://bugs.webkit.org/show_bug.cgi?id=59386
3504
3505         * dom/CheckedRadioButtons.cpp:
3506         (WebCore::CheckedRadioButtons::addButton):
3507
3508 2011-04-25  Adam Barth  <abarth@webkit.org>
3509
3510         Reviewed by David Levin.
3511
3512         Resource*.cpp should play nice with strict OwnPtrs
3513         https://bugs.webkit.org/show_bug.cgi?id=59383
3514
3515         * bridge/runtime_method.cpp:
3516         (JSC::RuntimeMethod::RuntimeMethod):
3517         * platform/network/ResourceHandle.cpp:
3518         (WebCore::ResourceHandle::ResourceHandle):
3519         * platform/network/ResourceResponseBase.cpp:
3520         (WebCore::ResourceResponseBase::adopt):
3521         (WebCore::ResourceResponseBase::copyData):
3522
3523 2011-04-25  Adam Barth  <abarth@webkit.org>
3524
3525         Reviewed by David Levin.
3526
3527         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
3528         https://bugs.webkit.org/show_bug.cgi?id=59374
3529
3530         * bridge/objc/objc_runtime.mm:
3531         (JSC::Bindings::callObjCFallbackObject):
3532         * page/Page.cpp:
3533         (WebCore::Page::Page):
3534         (WebCore::Page::initGroup):
3535         * page/PageGroup.cpp:
3536         (WebCore::PageGroup::addUserScriptToWorld):
3537         (WebCore::PageGroup::addUserStyleSheetToWorld):
3538         * page/mac/PageMac.cpp:
3539         (WebCore::Page::addSchedulePair):
3540
3541 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3542
3543         Build fix: This time for sure!
3544         
3545         * dom/make_names.pl:
3546
3547 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3548
3549         Build fix: Let's edit the script instead of the autogenrated file. That
3550         way, our change will stand the test of time.
3551
3552         * dom/make_names.pl:
3553
3554 2011-04-25  Adam Barth  <abarth@webkit.org>
3555
3556         Reviewed by David Levin.
3557
3558         Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
3559         https://bugs.webkit.org/show_bug.cgi?id=59368
3560
3561         * html/HTMLMediaElement.cpp:
3562         (WebCore::HTMLMediaElement::HTMLMediaElement):
3563         * platform/network/HTTPHeaderMap.cpp:
3564         (WebCore::HTTPHeaderMap::copyData):
3565
3566 2011-04-25  James Robinson  <jamesr@chromium.org>
3567
3568         Reviewed by Adam Barth.
3569
3570         Fix strict OwnPtr violations in Render*.cpp
3571         https://bugs.webkit.org/show_bug.cgi?id=59361
3572
3573         * rendering/RenderBlock.cpp:
3574         (WebCore::RenderBlock::RenderBlock):
3575         (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
3576         * rendering/RenderBox.cpp:
3577         (WebCore::RenderBox::addLayoutOverflow):
3578         (WebCore::RenderBox::addVisualOverflow):
3579         * rendering/RenderButton.cpp:
3580         (WebCore::RenderButton::styleDidChange):
3581         * rendering/RenderLayer.cpp:
3582         (WebCore::RenderLayer::updateTransform):
3583         (WebCore::RenderLayer::paintChildLayerIntoColumns):
3584         (WebCore::RenderLayer::hitTestChildLayerColumns):
3585         (WebCore::RenderLayer::ensureBacking):
3586         * rendering/RenderTable.cpp:
3587         (WebCore::RenderTable::styleDidChange):
3588         * rendering/RenderView.cpp:
3589         (WebCore::RenderView::compositor):
3590         * rendering/style/RenderStyle.cpp:
3591         (WebCore::RenderStyle::addCachedPseudoStyle):
3592         (WebCore::RenderStyle::accessCounterDirectives):
3593         (WebCore::RenderStyle::accessAnimations):
3594         (WebCore::RenderStyle::accessTransitions):
3595         * rendering/svg/RenderSVGResourceFilter.cpp:
3596         (WebCore::RenderSVGResourceFilter::applyResource):
3597         * rendering/svg/SVGResources.cpp:
3598         (WebCore::SVGResources::SVGResources):
3599
3600 2011-04-25  Adam Barth  <abarth@webkit.org>
3601
3602         Attempt to fix the compile.
3603
3604         * platform/graphics/MediaPlayer.cpp:
3605         (WebCore::MediaPlayer::loadWithNextMediaEngine):
3606
3607 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3608
3609         Rubber-stamped by Beth Dakin.
3610
3611         Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into 
3612         CREATE_DOM_WRAPPER because there's no meaningful difference between
3613         them anymore.
3614
3615         * bindings/js/JSCDATASectionCustom.cpp:
3616         (WebCore::toJSNewlyCreated):
3617         * bindings/js/JSCSSRuleCustom.cpp:
3618         (WebCore::toJS):
3619         * bindings/js/JSCSSValueCustom.cpp:
3620         (WebCore::toJS):
3621         * bindings/js/JSDOMBinding.h:
3622         * bindings/js/JSDocumentCustom.cpp:
3623         (WebCore::toJS):
3624         * bindings/js/JSElementCustom.cpp:
3625         (WebCore::toJSNewlyCreated):
3626         * bindings/js/JSEventCustom.cpp:
3627         (WebCore::toJS):
3628         * bindings/js/JSHTMLCollectionCustom.cpp:
3629         (WebCore::toJS):
3630         * bindings/js/JSImageDataCustom.cpp:
3631         (WebCore::toJS):
3632         * bindings/js/JSNodeCustom.cpp:
3633         (WebCore::createWrapperInline):
3634         * bindings/js/JSSVGPathSegCustom.cpp:
3635         (WebCore::toJS):
3636         * bindings/js/JSStyleSheetCustom.cpp:
3637         (WebCore::toJS):
3638         * bindings/js/JSTextCustom.cpp:
3639         (WebCore::toJSNewlyCreated):
3640         * bindings/js/JSWebKitCSSMatrixCustom.cpp:
3641         (WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
3642         * bindings/js/JSWebSocketCustom.cpp:
3643         (WebCore::JSWebSocketConstructor::constructJSWebSocket):
3644         * bindings/js/JSXMLHttpRequestCustom.cpp:
3645         (WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
3646         * bindings/js/JSXSLTProcessorCustom.cpp:
3647         (WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
3648
3649 2011-04-25  Adam Barth  <abarth@webkit.org>
3650
3651         Reviewed by James Robinson.
3652
3653         HTMLDocumentParser should play nice with OwnPtrs
3654         https://bugs.webkit.org/show_bug.cgi?id=59363
3655
3656         * html/parser/HTMLDocumentParser.cpp:
3657         (WebCore::HTMLDocumentParser::pumpTokenizer):
3658
3659 2011-04-25  Adam Barth  <abarth@webkit.org>
3660
3661         Reviewed by James Robinson.
3662
3663         Frame.cpp should work with strict OwnPtrs
3664         https://bugs.webkit.org/show_bug.cgi?id=59360
3665
3666         * page/Frame.cpp:
3667         (WebCore::createRegExpForLabels):
3668
3669 2011-04-25  Adam Barth  <abarth@webkit.org>
3670
3671         Reviewed by David Levin.
3672
3673         Fix strict OwnPtr in Element.cpp
3674         https://bugs.webkit.org/show_bug.cgi?id=59357
3675
3676         * dom/NodeRareData.h:
3677         (WebCore::NodeRareData::ensureEventTargetData):
3678
3679 2011-04-25  Adam Barth  <abarth@webkit.org>
3680
3681         Reviewed by David Levin.
3682
3683         Fix strict OwnPtr issues in Media*.cpp
3684         https://bugs.webkit.org/show_bug.cgi?id=59354
3685
3686         There's still a tricky case in MediaPlayer.cpp, but we'll worry about
3687         that later.
3688
3689         * css/MediaQueryMatcher.cpp:
3690         (WebCore::MediaQueryMatcher::addListener):
3691         * dom/Document.cpp:
3692         * platform/graphics/MediaPlayer.cpp:
3693         (WebCore::createNullMediaPlayer):
3694
3695 2011-04-25  James Robinson  <jamesr@chromium.org>
3696
3697         Reviewed by David Levin.
3698
3699         Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
3700         https://bugs.webkit.org/show_bug.cgi?id=59353
3701
3702         * rendering/RenderLayerCompositor.cpp:
3703         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
3704
3705 2011-04-25  Adam Barth  <abarth@webkit.org>
3706
3707         Reviewed by James Robinson.
3708
3709         Worker*.cpp should work with strict OwnPtrs
3710         https://bugs.webkit.org/show_bug.cgi?id=59346
3711
3712         * inspector/WorkerInspectorController.cpp:
3713         (WebCore::WorkerInspectorController::WorkerInspectorController):
3714         * workers/WorkerContext.cpp:
3715         (WebCore::WorkerContext::WorkerContext):
3716         * workers/WorkerRunLoop.cpp:
3717         (WebCore::WorkerRunLoop::WorkerRunLoop):
3718         * workers/WorkerScriptLoader.cpp:
3719         (WebCore::WorkerScriptLoader::createResourceRequest):
3720
3721 2011-04-25  James Robinson  <jamesr@chromium.org>
3722
3723         Reviewed by Adam Barth.
3724
3725         Remove bad use of OwnPtr::set() in IconDatabase.cpp
3726         https://bugs.webkit.org/show_bug.cgi?id=59344
3727
3728         Needed for strict OwnPtr compliance.
3729
3730         * loader/icon/IconDatabase.cpp:
3731         (WebCore::readySQLiteStatement):
3732
3733 2011-04-25  Adam Barth  <abarth@webkit.org>
3734
3735         Reviewed by Maciej Stachowiak.
3736
3737         ImageBuffer.h should work with strict OwnPtrs
3738         https://bugs.webkit.org/show_bug.cgi?id=59341
3739
3740         This patch is to prepare for the strict OwnPtr hack-a-thon.
3741
3742         * platform/graphics/ImageBuffer.h:
3743         (WebCore::ImageBuffer::create):
3744
3745 2011-04-25  Steve Falkenburg  <sfalken@apple.com>
3746
3747         Reviewed by Brian Weinstein.
3748
3749         WebCore build on Windows should include windows.h in its precompiled header to speed builds
3750         https://bugs.webkit.org/show_bug.cgi?id=59339
3751
3752         windows.h is included by several of the underlying wtf headers, including Atomics.h and
3753         ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
3754         
3755         On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
3756         (a 12% speedup).
3757
3758         * WebCorePrefix.h: Include windows.h
3759
3760 2011-04-25  Martin Robinson  <mrobinson@igalia.com>
3761
3762         Reviewed by Xan Lopez.
3763
3764         [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
3765         https://bugs.webkit.org/show_bug.cgi?id=59311
3766
3767         * platform/gtk/MainFrameScrollbarGtk.cpp:
3768         (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar
3769         disconnect any lingering signal handlers. This prevents an adjustment from controlling the
3770         active ScrollView and some zombie ScrollView.
3771
3772 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3773
3774         Another shot at fixing the EFL build.
3775
3776         * UseJSC.cmake:
3777         * bindings/js/JSDOMBinding.cpp:
3778
3779 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3780
3781         Try to fix EFL build.
3782
3783         * UseJSC.cmake: Added a missing file.
3784
3785 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3786
3787         Reviewed by Oliver Hunt.
3788
3789         Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
3790         https://bugs.webkit.org/show_bug.cgi?id=59333
3791
3792         * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
3793
3794         * bindings/js/JSDOMBinding.cpp:
3795         * bindings/js/JSDOMBinding.h:
3796         * bindings/js/JSDocumentCustom.cpp:
3797         * bindings/js/JSWorkerContextCustom.cpp:
3798         (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
3799
3800         * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
3801         lifetime management.
3802
3803         * dom/Document.idl: No need for a custom mark function anymore, since
3804         ActiveDOMObjets now manage their own lifetimes.
3805
3806         * dom/MessagePort.cpp:
3807         (WebCore::MessagePort::hasPendingActivity): Correctly report that we
3808         have pending activity when we're remotely entangled, instead of relying
3809         on our clients to know this about us and do the check for us.
3810
3811         * dom/MessagePort.h: FIXME!
3812
3813         * dom/MessagePort.idl:
3814         * fileapi/DOMFileSystem.idl:
3815         * fileapi/FileReader.idl:
3816         * fileapi/FileWriter.idl:
3817         * notifications/Notification.idl:
3818         * notifications/NotificationCenter.idl:
3819         * page/EventSource.idl:
3820         * storage/IDBDatabase.idl:
3821         * storage/IDBRequest.idl:
3822         * storage/IDBTransaction.idl:
3823         * webaudio/AudioContext.idl:
3824         * websockets/WebSocket.idl:
3825         * workers/AbstractWorker.idl:
3826         * workers/SharedWorker.idl:
3827         * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
3828
3829         * workers/WorkerContext.cpp:
3830         (WebCore::WorkerContext::hasPendingActivity): No need to make up for
3831         MessagePort::hasPendingActivity being wrong anymore, since it's now right.
3832
3833         * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
3834
3835 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3836
3837         Reviewed by Pavel Feldman.
3838
3839         Web Inspector: worker messages should be routed to corresponding worker front-end
3840         https://bugs.webkit.org/show_bug.cgi?id=59323
3841
3842         Added WorkerManager which is responsible for routing messages between
3843         Page inspector front-end and Worker inspector front-ends.
3844
3845         * WebCore.gypi:
3846         * inspector/front-end/WebKit.qrc:
3847         * inspector/front-end/WorkerManager.js: Added.
3848         (WebInspector.WorkerManager):
3849         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend):
3850         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded):
3851         (WebInspector.WorkerManager.loaded):
3852         (WebInspector.WorkerFrontendStub):
3853         (WebInspector.WorkerFrontendStub.prototype._receiveMessage):
3854         (WebInspector.WorkerDispatcher):
3855         (WebInspector.WorkerDispatcher.prototype._receiveMessage):
3856         (WebInspector.WorkerDispatcher.prototype.workerCreated):
3857         (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
3858         * inspector/front-end/inspector.html:
3859         * inspector/front-end/inspector.js:
3860         (WebInspector.loaded):
3861
3862 2011-04-25  Annie Sullivan  <sullivan@chromium.org>
3863
3864         Reviewed by Pavel Feldman.
3865
3866         Web Inspector: [Resources panel] Should be easy to copy data.
3867         https://bugs.webkit.org/show_bug.cgi?id=45662
3868
3869         Adds context menu items to copy resource location, resource request headers, and resource response headers.
3870
3871         * inspector/front-end/NetworkPanel.js:
3872         (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
3873         (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
3874         (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
3875         (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
3876         * inspector/front-end/Resource.js:
3877         (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
3878         (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
3879
3880 2011-04-25  Alexander Pavlov  <apavlov@chromium.org>
3881
3882         Reviewed by Yury Semikhatsky.
3883
3884         Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
3885         https://bugs.webkit.org/show_bug.cgi?id=59322
3886
3887         Use TextResourceDecoder to determine external stylesheet charsets correctly.
3888
3889         Test: inspector/styles/parse-utf8-bom.html
3890
3891         * inspector/InspectorStyleSheet.cpp:
3892         (WebCore::InspectorStyleSheet::originalStyleSheetText):
3893
3894 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3895
3896         Not reviewed: Inspector.json cleanup.
3897
3898         * inspector/Inspector.json:
3899
3900 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
3901
3902         Reviewed by Pavel Feldman.
3903
3904         Web Inspector: introduce InspectorWorkerAgent
3905         https://bugs.webkit.org/show_bug.cgi?id=59320
3906
3907         InspectorWorkerAgent is responsible for routing inspector messages
3908         between worker context inspector agents and corresponding worker
3909         inspector front-end.
3910
3911         * CMakeLists.txt:
3912         * GNUmakefile.list.am:
3913         * WebCore.gypi:
3914         * WebCore.pro:
3915         * WebCore.vcproj/WebCore.vcproj:
3916         * WebCore.xcodeproj/project.pbxproj:
3917         * inspector/CodeGeneratorInspector.pm:
3918         * inspector/Inspector.json:
3919         * inspector/InspectorAgent.cpp:
3920         (WebCore::InspectorAgent::InspectorAgent):
3921         (WebCore::InspectorAgent::setFrontend):
3922         (WebCore::InspectorAgent::disconnectFrontend):
3923         * inspector/InspectorAgent.h:
3924         (WebCore::InspectorAgent::workerAgent):
3925         * inspector/InspectorController.cpp:
3926         (WebCore::InspectorController::connectFrontend):
3927         (WebCore::InspectorController::disconnectFrontend):
3928         * inspector/InspectorInstrumentation.cpp:
3929         (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
3930         * inspector/InspectorInstrumentation.h:
3931         (WebCore::InspectorInstrumentation::willStartWorkerContext):
3932         (WebCore::InspectorInstrumentation::didStartWorkerContext):
3933         * inspector/InspectorWorkerAgent.cpp: Added.
3934         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
3935         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
3936         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
3937         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
3938         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
3939         (WebCore::InspectorWorkerAgent::create):
3940         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
3941         (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
3942         (WebCore::InspectorWorkerAgent::setFrontend):
3943         (WebCore::InspectorWorkerAgent::clearFrontend):
3944         (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
3945         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
3946         * inspector/InspectorWorkerAgent.h: Added.
3947         * inspector/InstrumentingAgents.h:
3948         (WebCore::InstrumentingAgents::InstrumentingAgents):
3949         (WebCore::InstrumentingAgents::inspectorWorkerAgent):
3950         (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
3951         * inspector/WorkerInspectorController.cpp:
3952         (WebCore::WorkerInspectorController::connectFrontend):
3953         * inspector/generate-inspector-idl:
3954         * workers/Worker.cpp:
3955         (WebCore::Worker::notifyFinished):
3956         * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
3957         messages sent from the inspected page worker agent to the worker context inspector agents.
3958         (WebCore::WorkerContextInspectorProxy::connectFrontend):
3959         (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
3960         (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
3961         (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
3962         * workers/WorkerContextProxy.h:
3963         (WebCore::WorkerContextProxy::inspectorProxy):
3964
3965 2011-04-25  Pavel Feldman  <pfeldman@google.com>
3966
3967         Reviewed by Yury Semikhatsky.
3968
3969         Web Inspector: move Frame and Resource Tree management into the Page agent.
3970         https://bugs.webkit.org/show_bug.cgi?id=59321
3971
3972         Network agent should only handle network-related activities.
3973         Frame structure should be managed by the Page agent instead.
3974
3975         * inspector/Inspector.json:
3976         * inspector/InspectorAgent.cpp:
3977         (WebCore::InspectorAgent::InspectorAgent):
3978         * inspector/InspectorDOMAgent.cpp:
3979         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
3980         (WebCore::InspectorDOMAgent::setFrontend):
3981         (WebCore::InspectorDOMAgent::restore):
3982         (WebCore::InspectorDOMAgent::highlightFrame):
3983         * inspector/InspectorDOMAgent.h:
3984         (WebCore::InspectorDOMAgent::create):
3985         * inspector/InspectorInstrumentation.cpp:
3986         (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
3987         (WebCore::InspectorInstrumentation::loadEventFiredImpl):
3988         (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
3989         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
3990         * inspector/InspectorPageAgent.cpp:
3991         (WebCore::InspectorPageAgent::create):
3992         (WebCore::InspectorPageAgent::resourceContent):
3993         (WebCore::InspectorPageAgent::resourceContentBase64):
3994         (WebCore::InspectorPageAgent::resourceData):
3995         (WebCore::InspectorPageAgent::cachedResource):
3996         (WebCore::InspectorPageAgent::resourceTypeString):
3997         (WebCore::InspectorPageAgent::cachedResourceType):
3998         (WebCore::InspectorPageAgent::cachedResourceTypeString):
3999         (WebCore::InspectorPageAgent::InspectorPageAgent):
4000         (WebCore::InspectorPageAgent::setFrontend):
4001         (WebCore::InspectorPageAgent::reload):
4002         (WebCore::InspectorPageAgent::open):
4003         (WebCore::InspectorPageAgent::getCookies):
4004         (WebCore::InspectorPageAgent::deleteCookie):
4005         (WebCore::InspectorPageAgent::getResourceTree):
4006         (WebCore::InspectorPageAgent::getResourceContent):
4007         (WebCore::InspectorPageAgent::restore):
4008         (WebCore::InspectorPageAgent::domContentEventFired):
4009         (WebCore::InspectorPageAgent::loadEventFired):
4010         (WebCore::InspectorPageAgent::frameNavigated):
4011         (WebCore::InspectorPageAgent::frameDetached):
4012         (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
4013         (WebCore::InspectorPageAgent::mainFrame):
4014         (WebCore::pointerAsId):
4015         (WebCore::InspectorPageAgent::frameForId):
4016         (WebCore::InspectorPageAgent::frameId):
4017         (WebCore::InspectorPageAgent::loaderId):
4018         (WebCore::InspectorPageAgent::buildObjectForFrame):
4019         (WebCore::InspectorPageAgent::buildObjectForFrameTree):
4020         * inspector/InspectorPageAgent.h:
4021         * inspector/InspectorResourceAgent.cpp:
4022         (WebCore::buildObjectForCachedResource):
4023         (WebCore::InspectorResourceAgent::willSendRequest):
4024         (WebCore::InspectorResourceAgent::didReceiveResponse):
4025         (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
4026         (WebCore::InspectorResourceAgent::setInitialScriptContent):
4027         (WebCore::InspectorResourceAgent::setInitialXHRContent):
4028         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
4029         * inspector/InspectorResourceAgent.h:
4030         (WebCore::InspectorResourceAgent::create):
4031         * inspector/InspectorStyleSheet.cpp:
4032         (WebCore::InspectorStyleSheet::resourceStyleSheetText):
4033         * inspector/front-end/NetworkManager.js:
4034         (WebInspector.NetworkManager.prototype.requestContent):
4035         * inspector/front-end/NetworkPanel.js:
4036         (WebInspector.NetworkPanel):
4037         (WebInspector.NetworkPanel.prototype.frameNavigated):
4038         * inspector/front-end/ResourceTreeModel.js:
4039         (WebInspector.ResourceTreeModel):
4040         (WebInspector.ResourceTreeModel.prototype.frontendReused):
4041         (WebInspector.ResourceTreeModel.prototype.frameNavigated):
4042         (WebInspector.ResourceTreeModel.prototype.frameDetached):
4043         * inspector/front-end/inspector.js:
4044         (WebInspector.domContentEventFired):
4045         (WebInspector.loadEventFired):
4046         (WebInspector.frameNavigated):
4047         (WebInspector.frameDetached):
4048
4049 2011-04-25  Pavel Feldman  <pfeldman@google.com>
4050
4051         Reviewed by Yury Semikhatsky.
4052
4053         Web Inspector: few protocol improvements.
4054         https://bugs.webkit.org/show_bug.cgi?id=59319
4055
4056         - Page domain is documented
4057         - setUserAgentOverride is moved to the Network agent
4058         - setSearchingForNode -> setInspectModeEnabled
4059         - highlightDOMNode -> highlightNode
4060         - reloadPage -> reload
4061         - openInNewWindow -> open with optional parameter
4062
4063         * inspector/Inspector.json:
4064         * inspector/InspectorDOMAgent.cpp:
4065         (WebCore::InspectorDOMAgent::setInspectModeEnabled):
4066         (WebCore::InspectorDOMAgent::highlightNode):
4067         * inspector/InspectorDOMAgent.h:
4068         (WebCore::InspectorDOMAgent::hideNodeHighlight):
4069         * inspector/InspectorInstrumentation.cpp:
4070         (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
4071         * inspector/InspectorPageAgent.cpp:
4072         (WebCore::InspectorPageAgent::clearFrontend):
4073         (WebCore::InspectorPageAgent::reload):
4074         (WebCore::InspectorPageAgent::open):
4075         * inspector/InspectorPageAgent.h:
4076         * inspector/InspectorResourceAgent.cpp:
4077         (WebCore::InspectorResourceAgent::clearFrontend):
4078         (WebCore::InspectorResourceAgent::applyUserAgentOverride):
4079         (WebCore::InspectorResourceAgent::setUserAgentOverride):
4080         * inspector/InspectorResourceAgent.h:
4081         * inspector/front-end/AuditsPanel.js:
4082         (WebInspector.AuditsPanel.prototype._reloadResources):
4083         * inspector/front-end/ElementsPanel.js:
4084         (WebInspector.ElementsPanel.prototype.setSearchingForNode):
4085         * inspector/front-end/ExtensionServer.js:
4086         (WebInspector.ExtensionServer.prototype._onReload):
4087         * inspector/front-end/NetworkPanel.js:
4088         (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
4089         * inspector/front-end/ResourcesPanel.js:
4090         (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
4091         * inspector/front-end/inspector.js:
4092         (WebInspector.highlightDOMNode):
4093         (WebInspector.openResource):
4094         (WebInspector.documentKeyDown):
4095
4096 2011-04-25  Jon Lee  <jonlee@apple.com>
4097
4098         Reviewed by Maciej Stachowiak.
4099
4100         Overlay scroller hard to see on pages with dark background (59183)
4101         https://bugs.webkit.org/show_bug.cgi?id=59183
4102         <rdar://problem/8975367>
4103
4104         Switch the scrollbar's overlay style depending on its frame's background color.
4105         This refactors the getDocumentBackgroundColor method needed for gestures. The style
4106         is determined and set on every paint() call to the Mac scrollbar theme.
4107
4108         * WebCore.exp.in: adding method to allow changing style
4109         * page/Frame.cpp:
4110        &nb