2011-01-17 Pavel Feldman <pfeldman@chromium.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
2
3         Reviewed by Yury Semikhatsky.
4
5         Web Inspector: simplify debugger enabling routine.
6         https://bugs.webkit.org/show_bug.cgi?id=52472
7
8         * inspector/Inspector.idl:
9         * inspector/InspectorController.cpp:
10         (WebCore::InspectorController::restoreDebugger):
11         (WebCore::InspectorController::showAndEnableDebugger):
12         (WebCore::InspectorController::enableDebugger):
13         * inspector/InspectorController.h:
14         * inspector/front-end/DebuggerModel.js:
15         * inspector/front-end/ScriptsPanel.js:
16         (WebInspector.ScriptsPanel.prototype.show):
17         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
18
19 2011-01-17  Pavel Podivilov  <podivilov@chromium.org>
20
21         Reviewed by Pavel Feldman.
22
23         Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
24         https://bugs.webkit.org/show_bug.cgi?id=51738
25
26         Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
27         Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.
28
29         * inspector/front-end/ScriptView.js:
30         (WebInspector.ScriptView):
31         (WebInspector.SourceFrameContentProviderForScript):
32         (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource):
33         (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
34         (WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
35         * inspector/front-end/ScriptsPanel.js:
36         (WebInspector.ScriptsPanel.prototype._addScript):
37         (WebInspector.ScriptsPanel.prototype.sourceFrameForScript):
38         (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
39         * inspector/front-end/SourceFrame.js:
40         (WebInspector.SourceFrame):
41         (WebInspector.SourceFrame.prototype.set visible):
42         (WebInspector.SourceFrame.prototype._createTextViewer):
43         (WebInspector.SourceFrame.prototype._breakpointAdded):
44         (WebInspector.SourceFrame.prototype._breakpoints):
45         (WebInspector.SourceFrame.prototype._sourceIDForLine):
46         (WebInspector.SourceFrame.prototype._sourceIDSet):
47         (WebInspector.SourceFrameContentProvider):
48         (WebInspector.SourceFrameContentProvider.prototype.requestContent):
49         (WebInspector.SourceFrameContentProvider.prototype.scripts):
50         * inspector/front-end/SourceView.js:
51         (WebInspector.SourceView):
52         (WebInspector.SourceView.prototype.show):
53         (WebInspector.SourceView.prototype.resize):
54         (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches):
55         (WebInspector.SourceView.prototype.performSearch):
56         (WebInspector.SourceView.prototype.revealLine):
57         (WebInspector.SourceView.prototype.highlightLine):
58         (WebInspector.SourceView.prototype._jumpToSearchResult):
59         (WebInspector.SourceFrameContentProviderForResource):
60         (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
61         (WebInspector.SourceFrameContentProviderForResource.prototype.scripts):
62
63 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
64
65         Reviewed by Jeremy Orlow.
66
67         GeolocationController should call stopUpdating on destruction
68         https://bugs.webkit.org/show_bug.cgi?id=52216
69
70         Test: fast/dom/Geolocation/window-close-crash.html
71
72         * page/GeolocationController.cpp:
73         (WebCore::GeolocationController::~GeolocationController):
74
75 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
76
77         Not reviewed: Qt build fix.
78
79         * inspector/InspectorInstrumentation.h:
80
81 2011-01-16  Pavel Feldman  <pfeldman@chromium.org>
82
83         Reviewed by Yury Semikhatsky.
84
85         Web Inspector: make WebCore use InspectorInstrumentation
86         for instrumentation calls.
87         https://bugs.webkit.org/show_bug.cgi?id=52532
88
89         This change makes WebCore classes issue instrumentation signals
90         by means of InspectorInstrumentation interface. It covered migration
91         for Document, FrameLoader, Database, DOMStorage, etc. It fixed
92         instrumentation handling for Console as well. This all is a part
93         of story described in the bug 52510.
94
95         * dom/Document.cpp:
96         (WebCore::Document::finishedParsing):
97         * dom/Document.h:
98         * dom/ScriptExecutionContext.h:
99         * inspector/InspectorBrowserDebuggerAgent.cpp:
100         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
101         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
102         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
103         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
104         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
105         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
106         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
107         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
108         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
109         * inspector/InspectorBrowserDebuggerAgent.h:
110         (WebCore::InspectorBrowserDebuggerAgent::create):
111         * inspector/InspectorConsoleAgent.cpp:
112         (WebCore::InspectorConsoleAgent::stopTiming):
113         (WebCore::InspectorConsoleAgent::count):
114         * inspector/InspectorConsoleAgent.h:
115         * inspector/InspectorController.cpp:
116         (WebCore::InspectorController::InspectorController):
117         (WebCore::InspectorController::~InspectorController):
118         (WebCore::InspectorController::handleMousePress):
119         (WebCore::InspectorController::didClearWindowObjectInWorld):
120         (WebCore::PostWorkerNotificationToFrontendTask::performTask):
121         * inspector/InspectorController.h:
122         * inspector/InspectorDOMAgent.h:
123         * inspector/InspectorDOMStorageAgent.h:
124         * inspector/InspectorDatabaseAgent.cpp:
125         * inspector/InspectorDatabaseAgent.h:
126         * inspector/InspectorFrontendHost.cpp:
127         * inspector/InspectorFrontendHost.h:
128         * inspector/InspectorInstrumentation.cpp:
129         (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
130         (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl):
131         (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
132         (WebCore::InspectorInstrumentation::handleMousePressImpl):
133         (WebCore::InspectorInstrumentation::mainResourceFiredLoadEventImpl):
134         (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEventImpl):
135         (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
136         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
137         (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
138         (WebCore::InspectorInstrumentation::consoleCountImpl):
139         (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
140         (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
141         (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
142         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
143         (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
144         (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
145         (WebCore::InspectorInstrumentation::didCreateWorkerImpl):
146         (WebCore::InspectorInstrumentation::didDestroyWorkerImpl):
147         (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
148         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
149         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
150         (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
151         (WebCore::InspectorInstrumentation::networkStateChangedImpl):
152         (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
153         * inspector/InspectorInstrumentation.h:
154         (WebCore::InspectorInstrumentation::inspectorControllerCreated):
155         (WebCore::InspectorInstrumentation::inspectorControllerDeleted):
156         (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
157         (WebCore::InspectorInstrumentation::inspectedPageDestroyed):
158         (WebCore::InspectorInstrumentation::willInsertDOMNode):
159         (WebCore::InspectorInstrumentation::didInsertDOMNode):
160         (WebCore::InspectorInstrumentation::willRemoveDOMNode):
161         (WebCore::InspectorInstrumentation::willModifyDOMAttr):
162         (WebCore::InspectorInstrumentation::didModifyDOMAttr):
163         (WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
164         (WebCore::InspectorInstrumentation::handleMousePress):
165         (WebCore::InspectorInstrumentation::characterDataModified):
166         (WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
167         (WebCore::InspectorInstrumentation::didScheduleResourceRequest):
168         (WebCore::InspectorInstrumentation::didInstallTimer):
169         (WebCore::InspectorInstrumentation::didRemoveTimer):
170         (WebCore::InspectorInstrumentation::willCallFunction):
171         (WebCore::InspectorInstrumentation::willChangeXHRReadyState):
172         (WebCore::InspectorInstrumentation::willDispatchEvent):
173         (WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
174         (WebCore::InspectorInstrumentation::willEvaluateScript):
175         (WebCore::InspectorInstrumentation::willFireTimer):
176         (WebCore::InspectorInstrumentation::willLayout):
177         (WebCore::InspectorInstrumentation::willLoadXHR):
178         (WebCore::InspectorInstrumentation::willPaint):
179         (WebCore::InspectorInstrumentation::willRecalculateStyle):
180         (WebCore::InspectorInstrumentation::identifierForInitialRequest):
181         (WebCore::InspectorInstrumentation::willSendRequest):
182         (WebCore::InspectorInstrumentation::markResourceAsCached):
183         (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
184         (WebCore::InspectorInstrumentation::willReceiveResourceData):
185         (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
186         (WebCore::InspectorInstrumentation::didReceiveContentLength):
187         (WebCore::InspectorInstrumentation::didFinishLoading):
188         (WebCore::InspectorInstrumentation::didFailLoading):
189         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
190         (WebCore::InspectorInstrumentation::scriptImported):
191         (WebCore::InspectorInstrumentation::mainResourceFiredLoadEvent):
192         (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEvent):
193         (WebCore::InspectorInstrumentation::frameDetachedFromParent):
194         (WebCore::InspectorInstrumentation::didCommitLoad):
195         (WebCore::InspectorInstrumentation::willWriteHTML):
196         (WebCore::InspectorInstrumentation::didOpenDatabase):
197         (WebCore::InspectorInstrumentation::didUseDOMStorage):
198         (WebCore::InspectorInstrumentation::didCreateWorker):
199         (WebCore::InspectorInstrumentation::didDestroyWorker):
200         (WebCore::InspectorInstrumentation::didCreateWebSocket):
201         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
202         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
203         (WebCore::InspectorInstrumentation::didCloseWebSocket):
204         (WebCore::InspectorInstrumentation::networkStateChanged):
205         (WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
206         (WebCore::InspectorInstrumentation::addMessageToConsole):
207         (WebCore::InspectorInstrumentation::consoleCount):
208         (WebCore::InspectorInstrumentation::startConsoleTiming):
209         (WebCore::InspectorInstrumentation::stopConsoleTiming):
210         (WebCore::InspectorInstrumentation::consoleMarkTimeline):
211         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
212         (WebCore::InspectorInstrumentation::inspectorControllerForContext):
213         (WebCore::InspectorInstrumentation::inspectorControllerForFrame):
214         (WebCore::InspectorInstrumentation::inspectorControllerForPage):
215         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForContext):
216         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForDocument):
217         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForFrame):
218         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
219         * inspector/InspectorState.cpp:
220         * loader/FrameLoader.cpp:
221         (WebCore::FrameLoader::detachFromParent):
222         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
223         (WebCore::FrameLoader::dispatchDidCommitLoad):
224         * page/Chrome.cpp:
225         (WebCore::Chrome::mouseDidMoveOverElement):
226         * page/Console.cpp:
227         (WebCore::Console::addMessage):
228         (WebCore::Console::count):
229         (WebCore::Console::markTimeline):
230         (WebCore::Console::profile):
231         (WebCore::Console::time):
232         (WebCore::Console::timeEnd):
233         (WebCore::Console::group):
234         (WebCore::Console::groupCollapsed):
235         (WebCore::Console::groupEnd):
236         * page/DOMWindow.cpp:
237         (WebCore::DOMWindow::sessionStorage):
238         (WebCore::DOMWindow::localStorage):
239         (WebCore::DOMWindow::dispatchLoadEvent):
240         * page/EventHandler.cpp:
241         (WebCore::EventHandler::handleMousePressEvent):
242         * page/Page.cpp:
243         (WebCore::Page::~Page):
244         * storage/Database.cpp:
245         (WebCore::Database::openDatabase):
246         * workers/AbstractWorker.cpp:
247         (WebCore::AbstractWorker::onDestroyWorker):
248         * workers/SharedWorker.cpp:
249         (WebCore::SharedWorker::create):
250         * workers/Worker.cpp:
251         (WebCore::Worker::create):
252         * workers/WorkerMessagingProxy.cpp:
253
254 2011-01-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
255
256         Unreviewed, rolling out r75923.
257
258         GTK guy rolls out the r75914.
259
260         * platform/efl/ScrollViewEfl.cpp:
261         (WebCore::ScrollView::platformInit):
262
263 2011-01-17  Helder Correia  <helder@sencha.com>
264
265         Reviewed by Kenneth Rohde Christiansen.
266
267         [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
268         https://bugs.webkit.org/show_bug.cgi?id=52556
269
270         The shadow color opacity needs to be set on the shadow painter.
271         Additionally, the gradient brush should be transformed.
272
273         * platform/graphics/qt/GraphicsContextQt.cpp:
274         (WebCore::GraphicsContext::fillPath):
275
276 2011-01-17  No'am Rosenthal  <noam.rosenthal@nokia.com>
277
278         Reviewed by Kenneth Rohde Christiansen.
279
280         [Qt] Background image rendering is slow
281         https://bugs.webkit.org/show_bug.cgi?id=50527
282
283         When tiling a scaled pixmap in Image::drawPattern, scale the tile
284         first and only then draw it to the target. Do so only when drawing
285         more than one tile.
286
287         Tests in fast/backgrounds/size cover this.
288
289         * platform/graphics/qt/ImageQt.cpp:
290         (WebCore::Image::drawPattern):
291
292 2011-01-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
293
294         Reviewed by Simon Hausmann.
295
296         [Qt] [Symbian] Fix building NPAPI support
297         https://bugs.webkit.org/show_bug.cgi?id=51981
298
299         Make sure that npapi.h is always included outside of the extern "C"
300         linkage declaration block.
301
302         No new tests as there is no new functionality.
303
304         * bridge/npruntime.h:
305
306 2011-01-17  Philippe Normand  <pnormand@igalia.com>
307
308         Unreviewed, rolling out r75914.
309         http://trac.webkit.org/changeset/75914
310         https://bugs.webkit.org/show_bug.cgi?id=49177
311
312         multiple crashes on GTK
313
314         * platform/ScrollView.cpp:
315         (WebCore::ScrollView::removeChild):
316         (WebCore::ScrollView::wheelEvent):
317         * platform/gtk/MainFrameScrollbarGtk.cpp:
318         (MainFrameScrollbarGtk::attachAdjustment):
319         (MainFrameScrollbarGtk::gtkValueChanged):
320         * platform/gtk/ScrollViewGtk.cpp:
321         (WebCore::ScrollView::platformInit):
322         (WebCore::ScrollView::platformAddChild):
323         (WebCore::ScrollView::platformRemoveChild):
324
325 2011-01-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
326
327         Unreviewed build fix.
328
329         Bug 49177's patch enabled platformInit() in super class(ScrollView).
330         But, it didn't removed the function in ScrollViewEfl.cpp.
331
332         * platform/efl/ScrollViewEfl.cpp:
333
334 2011-01-16  Dan Bernstein  <mitz@apple.com>
335
336         Reviewed by Sam Weinig.
337
338         <rdar://problem/8871903> REGRESSION (r75897): Crash with 0-by-0 iframe in scaled WebView
339
340         Avoid use of FloatRect::enclosingBoundingBox(), which can stretch an empty
341         quad to a non-empty rect.
342
343         * rendering/RenderWidget.cpp:
344         (WebCore::RenderWidget::setWidget):
345         (WebCore::RenderWidget::updateWidgetPosition):
346
347 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
348
349         Reviewed by Xan Lopez.
350
351         [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
352         https://bugs.webkit.org/show_bug.cgi?id=49177
353
354         * platform/ScrollView.cpp: Move the platform guards around a little. GTK+
355         now shares the implementation of platformAddChild and platformRemoveChild,
356         but has its own implementation of removeChild, which knows how to inform
357         main frame scrollbars that they no longer control the WebCore scrollbar.
358         * platform/gtk/MainFrameScrollbarGtk.cpp:
359         (MainFrameScrollbarGtk::attachAdjustment): If we are attaching the same adjustment
360         that we already have, bail out early. Apply the value changed signal handler
361         after configuring the adjustment. We don't want our reset of the adjustment to
362         stomp on WebCore values.
363         (MainFrameScrollbarGtk::gtkValueChanged): Do not adjust the value if the WebCore
364         state already matches ours. This prevents some unnecessary recursion
365         * platform/gtk/ScrollViewGtk.cpp:
366         (WebCore::ScrollView::removeChild): Added, special cases main frame scrollbars
367         which need their adjustments detached.
368
369 2011-01-13  Yuzo Fujishima  <yuzo@google.com>
370
371         Reviewed by Antti Koivisto.
372
373         Fix for Bug 52427 - Inconsistent use of m_cache in CachedResourceLoader
374         https://bugs.webkit.org/show_bug.cgi?id=52427
375
376         In constructor/destructor of CachedResourceLoader, m_cache has been
377         used to call MemoryCache::addCachedResourceLoader/removeCachedResourceLoader
378         while cache() is used everywhere else.
379
380         Actually addCachedResourceLoader/removeCachedResourceLoader need not be called at all.
381         Remove the call sites and make MemoryCache non-friend of CachedResourceLoader.
382
383         No new tests because the behavior remains the same.
384
385         * loader/cache/CachedResourceLoader.cpp:
386         (WebCore::CachedResourceLoader::CachedResourceLoader):
387         (WebCore::CachedResourceLoader::~CachedResourceLoader):
388         * loader/cache/CachedResourceLoader.h:
389         * loader/cache/MemoryCache.cpp:
390         * loader/cache/MemoryCache.h:
391
392 2011-01-16  Adam Barth  <abarth@webkit.org>
393
394         Rubber-stamped by Eric Seidel.
395
396         Move WebKit into Source
397         https://bugs.webkit.org/show_bug.cgi?id=52530
398
399         * WebCore.gyp/WebCore.gyp:
400         * WebCore.pri:
401         * WebCore.pro:
402
403 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
404
405         Reviewed by Dan Bernstein.
406
407         frame-removed-during-resize.html test crashes (shows up as image-map-2.html crash)
408         https://bugs.webkit.org/show_bug.cgi?id=52549
409
410         Fix regression from r75900; m_widget->setFrameRect() can run script that
411         clears m_widget, so null-check it before calling setBoundsSize().
412         
413         Tested by fast/replaced/frame-removed-during-resize.html
414
415         * rendering/RenderWidget.cpp:
416         (WebCore::RenderWidget::setWidgetGeometry):
417
418 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
419
420         Keep Leopard build happy.
421
422         * platform/mac/WidgetMac.mm:
423         (WebCore::Widget::setBoundsSize):
424
425 2011-01-16  Robert Hogan  <robert@webkit.org>
426
427         Reviewed by Andreas Kling.
428
429         [Qt] plugins/keyboard-events.html fails after r72717
430         https://bugs.webkit.org/show_bug.cgi?id=50050
431
432         * plugins/qt/PluginViewQt.cpp:
433         (WebCore::setXKeyEventSpecificFields): map event text to keycode
434
435 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
436
437         Reviewed by Dan Bernstein.
438
439         Issues with iframes and plugins when the WebView is scaled.
440         <rdar://problem/6213380>
441         
442         When _scaleWebView has been called on a WebView, iframes
443         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
444         This is caused by AppKit NSViews not playing nicely with the scale
445         applied through style.
446         
447         Work around most of these issues by adjusting the bounds size
448         of widgets to allow iframe contents to paint with the correct scale,
449         and fix various places in the code where we relied on coordinate
450         transforms via NSViews (which ignore CSS transforms).
451
452         * WebCore.exp.in:
453         * platform/Widget.cpp:
454         (WebCore::Widget::setBoundsSize):
455         * platform/Widget.h:
456         * platform/mac/WidgetMac.mm:
457         (WebCore::Widget::setBoundsSize):
458         (WebCore::Widget::paint):
459         * rendering/RenderLayerCompositor.cpp:
460         (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
461         * rendering/RenderWidget.cpp:
462         (WebCore::RenderWidget::setWidgetGeometry):
463         (WebCore::RenderWidget::setWidget):
464         (WebCore::RenderWidget::updateWidgetPosition):
465         * rendering/RenderWidget.h:
466
467 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
468
469         Reviewed by Dan Bernstein.
470
471         RenderView needs to take transforms on its layer into account
472         https://bugs.webkit.org/show_bug.cgi?id=52536
473         
474         The RenderView's coordinate mapping methods failed to
475         take into account a transform on the RenderView's layer.
476
477         No tests because it's not possible to get a transform
478         on the RenderView's layer through content.
479
480         * rendering/RenderView.cpp:
481         (WebCore::RenderView::mapLocalToContainer):
482         (WebCore::RenderView::mapAbsoluteToLocalPoint):
483
484 2011-01-15  Sheriff Bot  <webkit.review.bot@gmail.com>
485
486         Unreviewed, rolling out r75708.
487         http://trac.webkit.org/changeset/75708
488         https://bugs.webkit.org/show_bug.cgi?id=52521
489
490         Breaks Qt build if mobility is not installed. (Requested by
491         benjaminp on #webkit).
492
493         * WebCore.pro:
494         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
495         (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
496         * platform/graphics/qt/MediaPlayerPrivateQt.h:
497         (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
498
499 2011-01-15  David Kilzer  <ddkilzer@apple.com>
500
501         <http://webkit.org/b/52512> REGRESSION(r73818): range.cloneContents() ignores end offset
502
503         Reviewed by Adele Peterson.
504
505         The fix for Bug 50710 in r73799 introduced an off-by-one error
506         when copying nodes to a local NodeVector for processing.  A fix
507         was attempted for Bug 50854 in r73818, but instead of stopping
508         at the end offset, it iterates through all the sibling nodes
509         because the loop variable (i) is never incremented.  To clean
510         this up, revert back to the code in r73799 and fix the
511         off-by-one error.
512
513         Test: fast/dom/Range/range-clone-contents.html
514
515         * dom/Range.cpp:
516         (WebCore::Range::processContents): Fix the loop that copies
517         nodes to a local NodeVector by restoring the code from r73799
518         and fixing the off-by-one error.
519
520 2011-01-15  Adam Barth  <abarth@webkit.org>
521
522         Rubber-stamped by Eric Seidel.
523
524         Move WebKit2 into Source
525         https://bugs.webkit.org/show_bug.cgi?id=52438
526
527         * WebCore.pro:
528
529 2011-01-15  Joone Hur  <joone.hur@collabora.co.uk>
530
531         Reviewed by Martin Robinson.
532
533         [GTK] Linux build with FileSystem API enabled fails
534         https://bugs.webkit.org/show_bug.cgi?id=43878
535
536         This patch allows WebKitGtk+ to build with FileSystem API option.
537
538         No new tests because no new functionality.
539
540         * GNUmakefile.am: Included AsyncFileSystem.h,cpp and Excluded duplicated JSFileException.h,cpp.
541         * bindings/js/JSDirectoryEntryCustom.cpp: Included ExceptionCode.h.
542
543 2011-01-14  Sam Magnuson  <smagnuso@gmail.com>
544
545         Reviewed by Kenneth Rohde Christiansen.
546
547         [Qt] Compile with QT_NO_GRAPHICSVIEW
548         https://bugs.webkit.org/show_bug.cgi?id=49750
549
550         * platform/graphics/qt/GraphicsLayerQt.cpp:
551         * platform/graphics/qt/GraphicsLayerQt.h:
552         * platform/qt/PlatformMouseEventQt.cpp:
553
554 2011-01-14  Tony Chang  <tony@chromium.org>
555
556         Reviewed by Alexey Proskuryakov.
557
558         Strip NUL character when copying text on Windows
559         https://bugs.webkit.org/show_bug.cgi?id=52236
560
561         Test: editing/pasteboard/copy-null-characters.html
562
563         * editing/Editor.cpp:
564         (WebCore::Editor::selectedText):
565         * platform/mac/PasteboardMac.mm:
566         (WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
567
568 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
569
570         Reviewed by Antti Koivisto.
571
572         Rename cache() to memoryCache()
573         https://bugs.webkit.org/show_bug.cgi?id=52433
574
575         No new tests because the behavior remains the same.
576
577         * WebCore.exp.in:
578         * WebCore.order:
579         * history/PageCache.cpp:
580         (WebCore::PageCache::releaseAutoreleasedPagesNow):
581         * inspector/InspectorResourceAgent.cpp:
582         (WebCore::InspectorResourceAgent::cachedResource):
583         * loader/FrameLoader.cpp:
584         (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
585         * loader/archive/cf/LegacyWebArchive.cpp:
586         (WebCore::LegacyWebArchive::create):
587         * loader/cache/CachedImage.cpp:
588         (WebCore::CachedImage::allClientsRemoved):
589         (WebCore::CachedImage::data):
590         * loader/cache/CachedResource.cpp:
591         (WebCore::CachedResource::~CachedResource):
592         (WebCore::CachedResource::addClientToSet):
593         (WebCore::CachedResource::removeClient):
594         (WebCore::CachedResource::setDecodedSize):
595         (WebCore::CachedResource::setEncodedSize):
596         (WebCore::CachedResource::didAccessDecodedData):
597         * loader/cache/CachedResourceLoader.cpp:
598         (WebCore::CachedResourceLoader::CachedResourceLoader):
599         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
600         (WebCore::CachedResourceLoader::requestResource):
601         (WebCore::CachedResourceLoader::revalidateResource):
602         (WebCore::CachedResourceLoader::loadResource):
603         (WebCore::CachedResourceLoader::clearPreloads):
604         (WebCore::CachedResourceLoader::printPreloadStats):
605         * loader/cache/CachedResourceRequest.cpp:
606         (WebCore::CachedResourceRequest::load):
607         (WebCore::CachedResourceRequest::didFail):
608         (WebCore::CachedResourceRequest::didReceiveResponse):
609         * loader/cache/MemoryCache.cpp:
610         (WebCore::memoryCache):
611         * loader/cache/MemoryCache.h:
612
613 2011-01-14  Dan Bernstein  <mitz@apple.com>
614
615         Reviewed by Simon Fraser.
616
617         WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
618
619         * WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and
620         RenderWidget::resumeWidgetHierarchyUpdates().
621         * manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
622         * rendering/RenderWidget.cpp:
623         (WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
624         are disabled. When this assertion was added, this condition was a subset of the “calling out to
625         plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
626         change now suspends widget hierarchy updates even at times where plug-in code is expected to be
627         called, which invalidates the assertion.
628
629 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
630
631         Unreviewed build fix.
632
633         Fix Qt build after r75837
634         https://bugs.webkit.org/show_bug.cgi?id=52494
635
636         * rendering/style/StyleRareInheritedData.cpp:
637         * rendering/style/StyleRareNonInheritedData.cpp:
638
639 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
640
641         Unreviewed build fix.
642
643         Fix Qt build after r75837
644         https://bugs.webkit.org/show_bug.cgi?id=52494
645
646         * rendering/style/RenderStyle.cpp:
647
648 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
649
650         Unreviewed build fix.
651
652         Fix Qt build after r75837
653         https://bugs.webkit.org/show_bug.cgi?id=52494
654
655         * editing/EditorCommand.cpp:
656
657 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
658
659         Unreviewed build fix.
660
661         Fix Qt build after r75837
662         https://bugs.webkit.org/show_bug.cgi?id=52494
663
664         * editing/ApplyStyleCommand.cpp:
665
666 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
667
668         Unreviewed build fix.
669
670         Fix Qt build after r75837
671         https://bugs.webkit.org/show_bug.cgi?id=52494
672
673         * css/CSSStyleSelector.cpp:
674
675 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
676
677         Unreviewed build fix.
678
679         Fix Qt build after r75837
680         https://bugs.webkit.org/show_bug.cgi?id=52494
681
682         * rendering/InlineFlowBox.h:
683         * rendering/RenderBoxModelObject.h:
684
685 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
686
687         Reviewed by David Levin.
688
689         Do some forward declaration in RenderStyle.h
690         https://bugs.webkit.org/show_bug.cgi?id=52453
691
692         No new tests because no new functionality.
693
694         * css/CSSComputedStyleDeclaration.cpp:
695         * css/CSSStyleSelector.cpp:
696         * editing/Editor.cpp:
697         * page/EventHandler.cpp:
698         * rendering/EllipsisBox.cpp:
699         * rendering/InlineBox.cpp:
700         * rendering/InlineTextBox.cpp:
701         * rendering/RenderBlock.cpp:
702         * rendering/RenderBlock.h:
703         * rendering/RenderBox.cpp:
704         * rendering/RenderBox.h:
705         * rendering/RenderEmbeddedObject.cpp:
706         * rendering/RenderFieldset.cpp:
707         * rendering/RenderFileUploadControl.cpp:
708         * rendering/RenderFrameSet.cpp:
709         * rendering/RenderHTMLCanvas.cpp:
710         * rendering/RenderImageResource.cpp:
711         * rendering/RenderInputSpeech.cpp:
712         * rendering/RenderLayer.h:
713         * rendering/RenderLineBoxList.cpp:
714         * rendering/RenderListBox.cpp:
715         * rendering/RenderMediaControlsChromium.cpp:
716         * rendering/RenderObject.cpp:
717         * rendering/RenderObject.h:
718         * rendering/RenderObjectChildList.cpp:
719         * rendering/RenderProgress.cpp:
720         * rendering/RenderScrollbarPart.cpp:
721         * rendering/RenderTable.cpp:
722         * rendering/RenderTable.h:
723         * rendering/RenderTableCell.cpp:
724         * rendering/RenderTableRow.cpp:
725         * rendering/RenderTableSection.cpp:
726         * rendering/RenderTheme.cpp:
727         * rendering/RenderThemeChromiumSkia.cpp:
728         * rendering/RenderThemeChromiumWin.cpp:
729         * rendering/RootInlineBox.cpp:
730         * rendering/style/RenderStyle.cpp:
731         * rendering/style/RenderStyle.h:
732         * rendering/style/StyleRareInheritedData.cpp:
733
734 2011-01-14  Ryosuke Niwa  <rniwa@webkit.org>
735
736         Reviewed by Eric Seidel.
737
738         Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
739         BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
740         https://bugs.webkit.org/show_bug.cgi?id=52481
741
742         Removed instantiation of legacy editing positions.
743         Calls to Position::Position are replaced by calls to Position's convenience functions.
744         
745         Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
746         they instantiate right positions for text nodes.
747
748         * accessibility/AccessibilityRenderObject.cpp:
749         (WebCore::AccessibilityRenderObject::setSelectedTextRange):
750         * dom/Element.cpp:
751         (WebCore::Element::updateFocusAppearance):
752         * editing/BreakBlockquoteCommand.cpp:
753         (WebCore::BreakBlockquoteCommand::doApply):
754         * editing/CompositeEditCommand.cpp:
755         (WebCore::CompositeEditCommand::inputText):
756         (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
757         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
758         (WebCore::CompositeEditCommand::moveParagraphs):
759         (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
760         (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
761         (WebCore::CompositeEditCommand::splitTreeToNode):
762         * editing/DeleteButtonController.cpp:
763         (WebCore::enclosingDeletableElement):
764         * editing/htmlediting.h:
765         (WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of
766         positionBeforeNode for a text node.
767         (WebCore::lastPositionInOrAfterNode): Ditto.
768
769 2011-01-14  Helder Correia  <helder@sencha.com>
770
771         Reviewed by Simon Fraser.
772
773         Shadow is not drawn when filling a path with a gradient
774         https://bugs.webkit.org/show_bug.cgi?id=51982
775
776         This happens in CG and is related to bug 51869, this time to be fixed
777         in GraphicsContext::fillPath(const Path& path). We need to draw the
778         gradient clipped to the path on a CGLayer first, and then draw the
779         layer on the GraphicsContext.
780
781         Test: fast/canvas/canvas-fillPath-gradient-shadow.html
782
783         * platform/graphics/cg/GraphicsContextCG.cpp:
784         (WebCore::GraphicsContext::fillPath):
785
786 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
787
788         Reviewed by Adam Roben.
789
790         Layer syncing should go through the compositor
791         https://bugs.webkit.org/show_bug.cgi?id=52486
792
793         Rather than have FrameView go directly to GraphicsLayer to
794         sync pending changes, route the call through RenderLayerCompositor.
795         
796         Add a FIXME about an existing issue with flushing and subframes.
797         
798         No behavior change, so no tests.
799
800         * page/FrameView.cpp:
801         (WebCore::FrameView::syncCompositingStateForThisFrame):
802         * rendering/RenderLayerBacking.cpp:
803         (WebCore::RenderLayerBacking::notifySyncRequired):
804         * rendering/RenderLayerCompositor.cpp:
805         (WebCore::RenderLayerCompositor::scheduleLayerFlush):
806         (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
807         * rendering/RenderLayerCompositor.h:
808         (WebCore::RenderLayerCompositor::notifySyncRequired):
809
810 2011-01-14  Abhishek Arya  <inferno@chromium.org>
811
812         Reviewed by David Hyatt.
813
814         Fix parent block calculation when trying to find top most node
815         containing "this" float.
816         https://bugs.webkit.org/show_bug.cgi?id=51711
817
818         Replace use of containingBlock and traverse the parents directly
819         to check for float existence. containingBlock can skip parents and
820         jump to the RenderView directly which will cause floats to not get
821         cleared from intermediate parents.
822
823         Test: fast/block/float/floats-not-cleared-crash.html
824
825         * rendering/RenderBox.cpp:
826         (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
827
828 2011-01-14  Adam Klein  <adamk@chromium.org>
829
830         Reviewed by Darin Fisher.
831
832         [Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
833         https://bugs.webkit.org/show_bug.cgi?id=42237
834
835         Remove Chromium-specific implementation from WebCore.
836
837         No tests added; this refactor should be covered by existing history-exercising tests.
838
839         * WebCore.gyp/WebCore.gyp:
840         * WebCore.gypi:
841         * history/BackForwardListChromium.cpp: Removed.
842         * history/BackForwardListImpl.h:
843
844 2011-01-12  Satish Sampath  <satish@chromium.org>
845
846         Reviewed by Dimitri Glazkov.
847
848         Fix a crash when accessing speech input from script.
849         https://bugs.webkit.org/show_bug.cgi?id=52325
850
851         Test: fast/speech/speech-input-scripting.html
852
853         * html/HTMLInputElement.cpp:
854         (WebCore::HTMLInputElement::parseMappedAttribute): Recreate renderer when speech input is enabled/disabled.
855         * rendering/RenderTextControlSingleLine.cpp: Remove unused code.
856         * rendering/RenderTextControlSingleLine.h:
857         * rendering/TextControlInnerElements.cpp: Take self references before firing events and check for renderer validity after.
858         (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
859         (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
860         (WebCore::InputFieldSpeechButtonElement::detach):
861
862 2011-01-14  Abhishek Arya  <inferno@chromium.org>
863
864         Reviewed by David Hyatt.
865
866         Prevent merging of anonymous blocks if one of them is already getting
867         destroyed.
868         https://bugs.webkit.org/show_bug.cgi?id=52402
869
870         Test: fast/block/merge-anonymous-block-remove-child-crash2.html
871
872         * rendering/RenderBlock.cpp:
873         (WebCore::RenderBlock::RenderBlock): initialize m_beingDestroyed to false.
874         (WebCore::RenderBlock::destroy): set m_beingDestroyed to true.
875         (WebCore::canMergeContiguousAnonymousBlocks): do not merge if any or prev or next is being destroyed.
876         (WebCore::RenderBlock::removeChild): remove the hack previously done for preventing oldChild merging with nextBlock's next sibling.
877         * rendering/RenderBlock.h:
878         (WebCore::RenderBlock::beingDestroyed): public function for m_beingDestroyed.
879
880 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
881
882         Not reviewed. Follow up to r75791: fix missing dispatch.
883         https://bugs.webkit.org/show_bug.cgi?id=52442
884
885         * inspector/front-end/DebuggerModel.js:
886         (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
887
888 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
889
890         Reviewed by Adam Roben.
891
892         Issues with contentsScale in GraphicsLayerCA
893         https://bugs.webkit.org/show_bug.cgi?id=52463
894
895         Fix various issues with the recent contentsScale changes:
896
897         * platform/graphics/ca/GraphicsLayerCA.cpp:
898         (WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1.
899         (WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay()
900         if the layer draws content, otherwise we'll create backing store for empty layers.
901         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale
902         on the new (tiled or untiled) layer.
903         (WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.
904
905 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
906
907         Let Xcode have it's way with the project file.
908
909         * WebCore.xcodeproj/project.pbxproj:
910
911 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
912
913         Reviewed by Anders Carlsson.
914
915         Refactor some FrameView::syncCompositingState code
916         https://bugs.webkit.org/show_bug.cgi?id=52459
917
918         Refactor some code in FrameView related to synchronizing
919         compositing layer state.
920         
921         * page/FrameView.cpp:
922         (WebCore::FrameView::syncCompositingStateForThisFrame):
923         (WebCore::FrameView::syncCompositingStateRecursive):
924         (WebCore::FrameView::paintContents):
925         * page/FrameView.h:
926
927 2011-01-14  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
928
929         Reviewed by Eric Seidel.
930
931         [Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
932         https://bugs.webkit.org/show_bug.cgi?id=30179
933
934         * plugins/symbian/PluginViewSymbian.cpp:
935
936 2011-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
937
938         Reviewed by Martin Robinson.
939
940         [GTK] Add volume slider to media player
941         https://bugs.webkit.org/show_bug.cgi?id=51532
942
943         * css/mediaControlsGtk.css:
944         (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
945         (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
946         (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
947         * platform/gtk/RenderThemeGtk.cpp:
948         (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
949         (WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
950         (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
951         (WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
952         * platform/gtk/RenderThemeGtk.h:
953         * platform/gtk/RenderThemeGtk2.cpp:
954         (WebCore::RenderThemeGtk::paintSliderTrack):
955         (WebCore::RenderThemeGtk::paintSliderThumb):
956         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
957         * platform/gtk/RenderThemeGtk3.cpp:
958         (WebCore::RenderThemeGtk::paintSliderTrack):
959         (WebCore::RenderThemeGtk::paintSliderThumb):
960         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
961
962 2011-01-14  Joone Hur  <joone.hur@collabora.co.uk>
963
964         Reviewed by David Levin.
965
966         [GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
967         https://bugs.webkit.org/show_bug.cgi?id=52434
968
969         No new tests. This code will be tested when an implementation 
970         of beginDragWithFiles is complete. 
971
972         * platform/gtk/FileSystemGtk.cpp:
973         (WebCore::filenameToString): Use GOwnPtr instead of gchar pointer.
974         (WebCore::fileSystemRepresentation): Ditto.
975         (WebCore::filenameForDisplay): Ditto.
976         (WebCore::pathGetFileName): Ditto.
977
978 2011-01-14  Pavel Podivilov  <podivilov@chromium.org>
979
980         Reviewed by Yury Semikhatsky.
981
982         Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload.
983         https://bugs.webkit.org/show_bug.cgi?id=52215
984
985         * inspector/front-end/Breakpoint.js:
986         (WebInspector.Breakpoint):
987         (WebInspector.Breakpoint.prototype.populateLabelElement):
988         * inspector/front-end/Script.js:
989         (WebInspector.Script.prototype.get linesCount):
990         (WebInspector.Script.prototype.sourceLine):
991         (WebInspector.Script.prototype.sourceLine.didRequestSource):
992         (WebInspector.Script.prototype.set source):
993         (WebInspector.Script.prototype.requestSource.didGetScriptSource):
994         (WebInspector.Script.prototype.requestSource):
995         * inspector/front-end/ScriptView.js:
996         (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded.didRequestSource):
997         (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
998         * inspector/front-end/SourceFrame.js:
999         (WebInspector.SourceFrame.prototype._addBreakpoint):
1000         * inspector/front-end/utilities.js:
1001         (String.prototype.findAll):
1002
1003 2011-01-14  Pavel Podivilov  <podivilov@chromium.org>
1004
1005         Reviewed by Yury Semikhatsky.
1006
1007         Web Inspector: provide script column offset to frontend.
1008         https://bugs.webkit.org/show_bug.cgi?id=52377
1009
1010         * bindings/js/ScriptDebugServer.cpp:
1011         (WebCore::ScriptDebugServer::dispatchDidParseSource):
1012         * bindings/js/ScriptSourceCode.h:
1013         (WebCore::ScriptSourceCode::ScriptSourceCode):
1014         * bindings/v8/DebuggerScript.js:
1015         ():
1016         * bindings/v8/ScriptDebugServer.cpp:
1017         (WebCore::ScriptDebugServer::dispatchDidParseSource):
1018         * inspector/Inspector.idl:
1019         * inspector/InspectorDebuggerAgent.cpp:
1020         (WebCore::InspectorDebuggerAgent::didParseSource):
1021         * inspector/InspectorDebuggerAgent.h:
1022         * inspector/ScriptDebugListener.h:
1023         * inspector/front-end/DebuggerModel.js:
1024         (WebInspector.DebuggerModel.prototype.parsedScriptSource):
1025         * inspector/front-end/Script.js:
1026         (WebInspector.Script):
1027
1028 2011-01-14  Ilya Tikhonovsky  <loislo@chromium.org>
1029
1030         Unreviewed one line fix for console-xhr-logging test.
1031
1032         The problem was introduced at r75788.
1033
1034         * inspector/InspectorBrowserDebuggerAgent.cpp:
1035         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
1036
1037 2011-01-13  Yury Semikhatsky  <yurys@chromium.org>
1038
1039         Reviewed by Pavel Feldman.
1040
1041         Web Inspector: extract console related functionality into InspectorConsoleAgent
1042         https://bugs.webkit.org/show_bug.cgi?id=52282
1043
1044         * CMakeLists.txt:
1045         * GNUmakefile.am:
1046         * WebCore.gypi:
1047         * WebCore.pro:
1048         * inspector/CodeGeneratorInspector.pm:
1049         * inspector/ConsoleMessage.cpp:
1050         (WebCore::ConsoleMessage::~ConsoleMessage):
1051         * inspector/ConsoleMessage.h:
1052         * inspector/Inspector.idl:
1053         * inspector/InspectorConsoleAgent.cpp: Added.
1054         (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
1055         (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
1056         (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
1057         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
1058         (WebCore::InspectorConsoleAgent::reset):
1059         (WebCore::InspectorConsoleAgent::setFrontend):
1060         (WebCore::InspectorConsoleAgent::addMessageToConsole):
1061         (WebCore::InspectorConsoleAgent::startTiming):
1062         (WebCore::InspectorConsoleAgent::stopTiming):
1063         (WebCore::InspectorConsoleAgent::count):
1064         (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
1065         (WebCore::InspectorConsoleAgent::didReceiveResponse):
1066         (WebCore::InspectorConsoleAgent::didFailLoading):
1067         (WebCore::InspectorConsoleAgent::addConsoleMessage):
1068         * inspector/InspectorConsoleAgent.h: Added.
1069         * inspector/InspectorController.cpp:
1070         (WebCore::InspectorController::InspectorController):
1071         (WebCore::InspectorController::clearConsoleMessages):
1072         (WebCore::InspectorController::connectFrontend):
1073         (WebCore::InspectorController::disconnectFrontend):
1074         (WebCore::InspectorController::didCommitLoad):
1075         * inspector/InspectorController.h:
1076         (WebCore::InspectorController::consoleAgent):
1077         * inspector/InspectorInstrumentation.cpp:
1078         (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
1079         (WebCore::InspectorInstrumentation::didFailLoadingImpl):
1080         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
1081         (WebCore::InspectorInstrumentation::addMessageToConsole):
1082         (WebCore::InspectorInstrumentation::count):
1083         (WebCore::InspectorInstrumentation::startTiming):
1084         (WebCore::InspectorInstrumentation::stopTiming):
1085         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
1086         * inspector/InspectorInstrumentation.h:
1087         * inspector/InspectorProfilerAgent.cpp:
1088         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
1089         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
1090         * inspector/front-end/ConsoleView.js:
1091         (WebInspector.ConsoleView):
1092         (WebInspector.ConsoleView.prototype.addConsoleMessage):
1093         (WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount):
1094         (WebInspector.ConsoleView.prototype.consoleMessagesCleared):
1095         * inspector/front-end/inspector.js:
1096         * page/Console.cpp:
1097         (WebCore::Console::addMessage):
1098         (WebCore::Console::count):
1099         (WebCore::Console::profile):
1100         (WebCore::Console::time):
1101         (WebCore::Console::timeEnd):
1102         (WebCore::Console::group):
1103         (WebCore::Console::groupCollapsed):
1104         (WebCore::Console::groupEnd):
1105         * page/Console.h:
1106         * page/Console.idl:
1107
1108 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
1109
1110         Reviewed by Yury Semikhatsky.
1111
1112         Web Inspector: do not use this as protocol message
1113         dispatcher in models / agents.
1114         https://bugs.webkit.org/show_bug.cgi?id=52442
1115
1116         Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
1117         There should be a clear way to tell whether method is being called
1118         from within front-end or by the backend.
1119
1120         * inspector/front-end/DOMAgent.js:
1121         (WebInspector.DOMAgent):
1122         (WebInspector.DOMAgent.prototype.nodeForId):
1123         (WebInspector.DOMAgent.prototype._bindNodes):
1124         (WebInspector.DOMAgent.prototype._removeBreakpoints):
1125         (WebInspector.DOMDispatcher):
1126         (WebInspector.DOMDispatcher.prototype.setDocument):
1127         (WebInspector.DOMDispatcher.prototype.attributesUpdated):
1128         (WebInspector.DOMDispatcher.prototype.characterDataModified):
1129         (WebInspector.DOMDispatcher.prototype.setChildNodes):
1130         (WebInspector.DOMDispatcher.prototype.setDetachedRoot):
1131         (WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
1132         (WebInspector.DOMDispatcher.prototype.childNodeInserted):
1133         (WebInspector.DOMDispatcher.prototype.childNodeRemoved):
1134         (WebInspector.DOMDispatcher.prototype.didCommitLoad):
1135         (WebInspector.ApplicationCacheDispatcher):
1136         (WebInspector.ApplicationCacheDispatcher.prototype.getApplicationCachesAsync):
1137         (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
1138         (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
1139         * inspector/front-end/DOMStorage.js:
1140         (WebInspector.DOMStorageDispatcher):
1141         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
1142         (WebInspector.DOMStorageDispatcher.prototype.selectDOMStorage):
1143         (WebInspector.DOMStorageDispatcher.prototype.updateDOMStorage):
1144         * inspector/front-end/Database.js:
1145         (WebInspector.Database.prototype.executeSql):
1146         (WebInspector.DatabaseDispatcher):
1147         (WebInspector.DatabaseDispatcher.prototype.addDatabase):
1148         (WebInspector.DatabaseDispatcher.prototype.selectDatabase):
1149         (WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
1150         (WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
1151         * inspector/front-end/DebuggerModel.js:
1152         (WebInspector.DebuggerModel):
1153         (WebInspector.DebuggerModel.prototype._pausedScript):
1154         (WebInspector.DebuggerModel.prototype._resumedScript):
1155         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
1156         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
1157         (WebInspector.DebuggerDispatcher):
1158         (WebInspector.DebuggerDispatcher.prototype.pausedScript):
1159         (WebInspector.DebuggerDispatcher.prototype.resumedScript):
1160         (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
1161         (WebInspector.DebuggerDispatcher.prototype.failedToParseScriptSource):
1162         * inspector/front-end/FileSystemView.js:
1163         (WebInspector.FileSystemDispatcher):
1164         (WebInspector.FileSystemDispatcher.prototype.getFileSystemPathsAsync):
1165         (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemPath):
1166         (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemError):
1167         (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemDisabled):
1168         * inspector/front-end/ProfilesPanel.js:
1169         (WebInspector.ProfilesPanel):
1170         (WebInspector.ProfilesPanel.prototype._addProfileHeader):
1171         (WebInspector.ProfilesPanel.prototype._removeProfileHeader):
1172         (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
1173         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
1174         (WebInspector.ProfilesPanel.prototype._setRecordingProfile):
1175         (WebInspector.ProfilerDispatcher):
1176         (WebInspector.ProfilerDispatcher.prototype.profilerWasEnabled):
1177         (WebInspector.ProfilerDispatcher.prototype.profilerWasDisabled):
1178         (WebInspector.ProfilerDispatcher.prototype.resetProfiles):
1179         (WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
1180         (WebInspector.ProfilerDispatcher.prototype.addHeapSnapshotChunk):
1181         (WebInspector.ProfilerDispatcher.prototype.finishHeapSnapshot):
1182         (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
1183         (WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
1184         * inspector/front-end/ResourceTreeModel.js:
1185         (WebInspector.ResourceTreeModel):
1186         * inspector/front-end/TimelinePanel.js:
1187         (WebInspector.TimelinePanel):
1188         (WebInspector.TimelinePanel.prototype._timelineProfilerWasStarted):
1189         (WebInspector.TimelinePanel.prototype._timelineProfilerWasStopped):
1190         (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
1191         (WebInspector.TimelineDispatcher):
1192         (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStarted):
1193         (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStopped):
1194         (WebInspector.TimelineDispatcher.prototype.addRecordToTimeline):
1195
1196 2011-01-14  Csaba Osztrogonác  <ossy@webkit.org>
1197
1198         [Qt][V8] Unreviewed buildfix after r75788.
1199
1200         * inspector/InspectorBrowserDebuggerAgent.cpp:
1201
1202 2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>
1203
1204         Reviewed by Yury Semikhatsky.
1205
1206         Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
1207         We have some methods of Debugger which are related to DOM.
1208         Lets extract these methods to BrowserDebugger agent.
1209
1210         http://bugs.webkit.org/show_bug.cgi?id=52294
1211
1212         * CMakeLists.txt:
1213         * WebCore.gypi:
1214         * WebCore.pro:
1215         * WebCore.vcproj/WebCore.vcproj:
1216         * WebCore.xcodeproj/project.pbxproj:
1217         * inspector/CodeGeneratorInspector.pm:
1218         * inspector/Inspector.idl:
1219         * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
1220         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
1221         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
1222         (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
1223         (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
1224         (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
1225         (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
1226         (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
1227         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
1228         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
1229         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
1230         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
1231         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
1232         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
1233         (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
1234         (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
1235         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
1236         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
1237         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
1238         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
1239         (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
1240         * inspector/InspectorBrowserDebuggerAgent.h: Added.
1241         (WebCore::InspectorBrowserDebuggerAgent::create):
1242         * inspector/InspectorController.cpp:
1243         (WebCore::InspectorController::InspectorController):
1244         (WebCore::InspectorController::inspectedPageDestroyed):
1245         (WebCore::InspectorController::didCommitLoad):
1246         (WebCore::InspectorController::enableDebuggerFromFrontend):
1247         (WebCore::InspectorController::disableDebugger):
1248         (WebCore::InspectorController::restoreStickyBreakpoints):
1249         (WebCore::InspectorController::restoreStickyBreakpoint):
1250         * inspector/InspectorController.h:
1251         * inspector/InspectorDOMAgent.cpp:
1252         (WebCore::InspectorDOMAgent::discardBindings):
1253         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1254         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1255         * inspector/InspectorDOMAgent.h:
1256         * inspector/InspectorInstrumentation.cpp:
1257         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1258         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1259         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1260         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1261         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1262         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1263         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1264
1265 2011-01-14  Andrey Kosyakov  <caseq@chromium.org>
1266
1267         Reviewed by Pavel Feldman.
1268
1269         Web Inspector: redirected resources not handled properly in Network panel
1270         https://bugs.webkit.org/show_bug.cgi?id=52292
1271
1272         * inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
1273         * inspector/InspectorInstrumentation.cpp: Ditto.
1274         (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
1275         * inspector/InspectorResourceAgent.cpp: Ditto.
1276         (WebCore::InspectorResourceAgent::identifierForInitialRequest):
1277         * inspector/InspectorResourceAgent.h: Ditto.
1278         * inspector/InspectorInstrumentation.cpp: Ditto.
1279         (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
1280         * inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
1281         * inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource
1282         (WebInspector.ConsoleMessage.prototype._formatMessage):
1283         * inspector/front-end/ExtensionServer.js: Ditto.
1284         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
1285         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
1286         * inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map
1287         (WebInspector.HARLog.prototype.build):
1288         (WebInspector.HARLog.prototype._convertResource):
1289         * inspector/front-end/NetworkManager.js:
1290         (WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource.
1291         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
1292         (WebInspector.NetworkManager.prototype.willSendRequest):
1293         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
1294         (WebInspector.NetworkManager.prototype.setInitialContent):
1295         (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
1296         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
1297         (WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel
1298         (WebInspector.NetworkManager.prototype._appendRedirect):
1299         * inspector/front-end/NetworkPanel.js:
1300         (WebInspector.NetworkPanel):
1301         (WebInspector.NetworkPanel.prototype.get resources):
1302         (WebInspector.NetworkPanel.prototype.resourceById):
1303         (WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added.
1304         (WebInspector.NetworkPanel.prototype.refreshResource): ditto.
1305         (WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
1306         * inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation.
1307         (WebInspector.ResourceTreeModel.prototype._clearResources):
1308         (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
1309         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
1310         (WebInspector.ResourceTreeModel.prototype.createResource):
1311         * inspector/front-end/inspector.js:
1312         (WebInspector.resourceById):
1313
1314 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1315
1316         Unreviewed, rolling out r75783.
1317         http://trac.webkit.org/changeset/75783
1318         https://bugs.webkit.org/show_bug.cgi?id=52439
1319
1320         a bit strange but the same patch have broken mac builds at
1321         linking stage. (Requested by loislo2 on #webkit).
1322
1323         * CMakeLists.txt:
1324         * GNUmakefile.am:
1325         * WebCore.gypi:
1326         * WebCore.pro:
1327         * WebCore.vcproj/WebCore.vcproj:
1328         * WebCore.xcodeproj/project.pbxproj:
1329         * inspector/CodeGeneratorInspector.pm:
1330         * inspector/Inspector.idl:
1331         * inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
1332         * inspector/InspectorBrowserDebuggerAgent.h: Removed.
1333         * inspector/InspectorController.cpp:
1334         (WebCore::InspectorController::InspectorController):
1335         (WebCore::InspectorController::inspectedPageDestroyed):
1336         (WebCore::InspectorController::didCommitLoad):
1337         (WebCore::InspectorController::enableDebuggerFromFrontend):
1338         (WebCore::InspectorController::disableDebugger):
1339         (WebCore::InspectorController::restoreStickyBreakpoints):
1340         (WebCore::InspectorController::restoreStickyBreakpoint):
1341         (WebCore::InspectorController::setEventListenerBreakpoint):
1342         (WebCore::InspectorController::removeEventListenerBreakpoint):
1343         (WebCore::InspectorController::hasEventListenerBreakpoint):
1344         (WebCore::InspectorController::setXHRBreakpoint):
1345         (WebCore::InspectorController::removeXHRBreakpoint):
1346         (WebCore::InspectorController::hasXHRBreakpoint):
1347         * inspector/InspectorController.h:
1348         * inspector/InspectorDOMAgent.cpp:
1349         (WebCore::InspectorDOMAgent::discardBindings):
1350         (WebCore::InspectorDOMAgent::setDOMBreakpoint):
1351         (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
1352         (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
1353         (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
1354         (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
1355         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
1356         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1357         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1358         (WebCore::InspectorDOMAgent::hasBreakpoint):
1359         (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
1360         * inspector/InspectorDOMAgent.h:
1361         * inspector/InspectorInstrumentation.cpp:
1362         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1363         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1364         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1365         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1366         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1367         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1368         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1369
1370 2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>
1371
1372         Reviewed by Yury Semikhatsky.
1373
1374         Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
1375         We have some methods of Debugger which are related to DOM.
1376         Lets extract these methods to BrowserDebugger agent.
1377
1378         http://bugs.webkit.org/show_bug.cgi?id=52294
1379
1380         * CMakeLists.txt:
1381         * WebCore.gypi:
1382         * WebCore.pro:
1383         * WebCore.vcproj/WebCore.vcproj:
1384         * WebCore.xcodeproj/project.pbxproj:
1385         * inspector/CodeGeneratorInspector.pm:
1386         * inspector/Inspector.idl:
1387         * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
1388         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
1389         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
1390         (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
1391         (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
1392         (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
1393         (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
1394         (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
1395         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
1396         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
1397         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
1398         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
1399         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
1400         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
1401         (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
1402         (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
1403         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
1404         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
1405         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
1406         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
1407         (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
1408         * inspector/InspectorBrowserDebuggerAgent.h: Added.
1409         (WebCore::InspectorBrowserDebuggerAgent::create):
1410         * inspector/InspectorController.cpp:
1411         (WebCore::InspectorController::InspectorController):
1412         (WebCore::InspectorController::inspectedPageDestroyed):
1413         (WebCore::InspectorController::didCommitLoad):
1414         (WebCore::InspectorController::enableDebuggerFromFrontend):
1415         (WebCore::InspectorController::disableDebugger):
1416         (WebCore::InspectorController::restoreStickyBreakpoints):
1417         (WebCore::InspectorController::restoreStickyBreakpoint):
1418         * inspector/InspectorController.h:
1419         * inspector/InspectorDOMAgent.cpp:
1420         (WebCore::InspectorDOMAgent::discardBindings):
1421         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1422         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1423         * inspector/InspectorDOMAgent.h:
1424         * inspector/InspectorInstrumentation.cpp:
1425         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1426         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1427         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1428         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1429         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1430         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1431         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1432
1433 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
1434
1435         Not reviewed: build fix.
1436
1437         * WebCore.vcproj/WebCore.vcproj:
1438
1439 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
1440
1441         Reviewed by Yury Semikhatsky.
1442
1443         Web Inspector: extract InspectorSettings from InspectorState,
1444         simplify it.
1445         https://bugs.webkit.org/show_bug.cgi?id=52429
1446
1447         * CMakeLists.txt:
1448         * GNUmakefile.am:
1449         * WebCore.gypi:
1450         * WebCore.pro:
1451         * WebCore.xcodeproj/project.pbxproj:
1452         * inspector/InspectorClient.h:
1453         * inspector/InspectorController.cpp:
1454         (WebCore::InspectorController::InspectorController):
1455         (WebCore::InspectorController::inspectorStartsAttached):
1456         (WebCore::InspectorController::setInspectorStartsAttached):
1457         (WebCore::InspectorController::setInspectorAttachedHeight):
1458         (WebCore::InspectorController::inspectorAttachedHeight):
1459         (WebCore::InspectorController::setMonitoringXHREnabled):
1460         (WebCore::InspectorController::restoreDebugger):
1461         (WebCore::InspectorController::restoreProfiler):
1462         (WebCore::InspectorController::ensureSettingsLoaded):
1463         (WebCore::InspectorController::enableProfiler):
1464         (WebCore::InspectorController::disableProfiler):
1465         (WebCore::InspectorController::enableDebuggerFromFrontend):
1466         (WebCore::InspectorController::disableDebugger):
1467         * inspector/InspectorController.h:
1468         * inspector/InspectorSettings.cpp: Added.
1469         (WebCore::InspectorSettings::InspectorSettings):
1470         (WebCore::InspectorSettings::getBoolean):
1471         (WebCore::InspectorSettings::setBoolean):
1472         (WebCore::InspectorSettings::getLong):
1473         (WebCore::InspectorSettings::setLong):
1474         (WebCore::InspectorSettings::registerBoolean):
1475         (WebCore::InspectorSettings::registerLong):
1476         * inspector/InspectorSettings.h: Added.
1477         * inspector/InspectorState.cpp:
1478         (WebCore::InspectorState::InspectorState):
1479         (WebCore::InspectorState::setValue):
1480         (WebCore::InspectorState::setObject):
1481         (WebCore::InspectorState::registerBoolean):
1482         (WebCore::InspectorState::registerString):
1483         (WebCore::InspectorState::registerLong):
1484         (WebCore::InspectorState::registerObject):
1485         (WebCore::InspectorState::Property::create):
1486         * inspector/InspectorState.h:
1487         (WebCore::InspectorState::setBoolean):
1488         (WebCore::InspectorState::setString):
1489         (WebCore::InspectorState::setLong):
1490
1491 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1492
1493         Unreviewed, rolling out r75774.
1494         http://trac.webkit.org/changeset/75774
1495         https://bugs.webkit.org/show_bug.cgi?id=52431
1496
1497         gtk builds were broken (Requested by loislo2 on #webkit).
1498
1499         * CMakeLists.txt:
1500         * WebCore.gypi:
1501         * WebCore.pro:
1502         * WebCore.vcproj/WebCore.vcproj:
1503         * WebCore.xcodeproj/project.pbxproj:
1504         * inspector/CodeGeneratorInspector.pm:
1505         * inspector/Inspector.idl:
1506         * inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
1507         * inspector/InspectorBrowserDebuggerAgent.h: Removed.
1508         * inspector/InspectorController.cpp:
1509         (WebCore::InspectorController::InspectorController):
1510         (WebCore::InspectorController::inspectedPageDestroyed):
1511         (WebCore::InspectorController::didCommitLoad):
1512         (WebCore::InspectorController::enableDebuggerFromFrontend):
1513         (WebCore::InspectorController::disableDebugger):
1514         (WebCore::InspectorController::restoreStickyBreakpoints):
1515         (WebCore::InspectorController::restoreStickyBreakpoint):
1516         (WebCore::InspectorController::setEventListenerBreakpoint):
1517         (WebCore::InspectorController::removeEventListenerBreakpoint):
1518         (WebCore::InspectorController::hasEventListenerBreakpoint):
1519         (WebCore::InspectorController::setXHRBreakpoint):
1520         (WebCore::InspectorController::removeXHRBreakpoint):
1521         (WebCore::InspectorController::hasXHRBreakpoint):
1522         * inspector/InspectorController.h:
1523         * inspector/InspectorDOMAgent.cpp:
1524         (WebCore::InspectorDOMAgent::discardBindings):
1525         (WebCore::InspectorDOMAgent::setDOMBreakpoint):
1526         (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
1527         (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
1528         (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
1529         (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
1530         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
1531         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1532         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1533         (WebCore::InspectorDOMAgent::hasBreakpoint):
1534         (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
1535         * inspector/InspectorDOMAgent.h:
1536         * inspector/InspectorInstrumentation.cpp:
1537         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1538         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1539         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1540         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1541         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1542         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1543         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1544
1545 2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>
1546
1547         Reviewed by Yury Semikhatsky.
1548
1549         Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
1550         We have some methods of Debugger which are related to DOM.
1551         Lets extract these methods to BrowserDebugger agent.
1552
1553         http://bugs.webkit.org/show_bug.cgi?id=52294
1554
1555         * CMakeLists.txt:
1556         * WebCore.gypi:
1557         * WebCore.pro:
1558         * WebCore.vcproj/WebCore.vcproj:
1559         * WebCore.xcodeproj/project.pbxproj:
1560         * inspector/CodeGeneratorInspector.pm:
1561         * inspector/Inspector.idl:
1562         * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
1563         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
1564         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
1565         (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
1566         (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
1567         (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
1568         (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
1569         (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
1570         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
1571         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
1572         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
1573         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
1574         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
1575         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
1576         (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
1577         (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
1578         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
1579         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
1580         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
1581         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
1582         (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
1583         * inspector/InspectorBrowserDebuggerAgent.h: Added.
1584         (WebCore::InspectorBrowserDebuggerAgent::create):
1585         * inspector/InspectorController.cpp:
1586         (WebCore::InspectorController::InspectorController):
1587         (WebCore::InspectorController::inspectedPageDestroyed):
1588         (WebCore::InspectorController::didCommitLoad):
1589         (WebCore::InspectorController::enableDebuggerFromFrontend):
1590         (WebCore::InspectorController::disableDebugger):
1591         (WebCore::InspectorController::restoreStickyBreakpoints):
1592         (WebCore::InspectorController::restoreStickyBreakpoint):
1593         * inspector/InspectorController.h:
1594         * inspector/InspectorDOMAgent.cpp:
1595         (WebCore::InspectorDOMAgent::discardBindings):
1596         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1597         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1598         * inspector/InspectorDOMAgent.h:
1599         * inspector/InspectorInstrumentation.cpp:
1600         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1601         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1602         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1603         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1604         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1605         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1606         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1607
1608 2011-01-13  Kent Tamura  <tkent@chromium.org>
1609
1610         Reviewed by Dimitri Glazkov.
1611
1612         Implement form validation message UI
1613         https://bugs.webkit.org/show_bug.cgi?id=48980
1614
1615         * Add four internal pseudo selectors:
1616           - -webkit-validation-bubble
1617           - -webkit-validation-bubble-message
1618           - -webkit-validation-bubble-top-outer-arrow
1619           - -webkit-validation-bubble-top-inner-arrow
1620
1621         * Implement ValidationMessage functions
1622           Show the message for <the number of characters> / 20.0 seconds.
1623
1624         No new tests because the feature is disabled by default for now and the
1625         new behavior is strongly timing-dependent.
1626
1627         * css/CSSStyleSelector.cpp:
1628         (WebCore::CSSStyleSelector::canShareStyleWithElement):
1629           Do not share a style with elements with different shadowPseudoId().
1630         * css/html.css: Define appearance for the internal selectors.
1631         (::-webkit-validation-bubble):
1632         (::-webkit-validation-bubble-message):
1633         (::-webkit-validation-bubble-top-outer-arrow):
1634         (::-webkit-validation-bubble-top-inner-arrow):
1635         * dom/Node.cpp:
1636         (WebCore::Node::createRendererIfNeeded):
1637           Allow to add shadow renderers even if canHaveChildren() returns false.
1638         * html/HTMLFormControlElement.cpp:
1639         (WebCore::HTMLFormControlElement::detach):
1640           Remove m_validationMessage immediately because we can't use
1641           hideVisibleValidationMessage(), which calls a ValidationMessage function later.
1642         (WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
1643           - Don't create ValidationMessage if the message is empty.
1644           - Remove the check for message equality.
1645         (WebCore::HTMLFormControlElement::hideVisibleValidationMessage):
1646           Don't remove m_validationMessage immediately. We shouldn't make the
1647           element needsLayout() state in this context.
1648         * html/ValidationMessage.cpp:
1649         (WebCore::ValidationMessage::~ValidationMessage):
1650           hideMessage() -> deleteBubbleTree() renaming.
1651         (WebCore::ValidationMessage::setMessage): Implemented.
1652         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
1653           Added. This updates the validation message and starts the timer to hide it.
1654         (WebCore::ElementWithPseudoId):
1655           Added to help implementations of styled shadow nodes.
1656         (WebCore::ValidationMessage::buildBubbleTree): Added.
1657         (WebCore::ValidationMessage::requestToHideMessage): Added.
1658         (WebCore::ValidationMessage::deleteBubbleTree):
1659           Renamed from hideMessage(), and implemented.
1660         * html/ValidationMessage.h: Add declarations.
1661
1662 2011-01-13  Dan Bernstein  <mitz@apple.com>
1663
1664         Reviewed by Alexey Proskuryakov.
1665
1666         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1667         https://bugs.webkit.org/show_bug.cgi?id=52419
1668
1669         Test: http/tests/loading/cross-origin-XHR-willLoadRequest.html
1670
1671         * loader/ResourceLoader.cpp:
1672         (WebCore::ResourceLoader::init): Complete r74453 by ensuring that m_request is only set after
1673         willSendRequest(). Otherwise, willSendRequest() ends up calling into
1674         ThreadableDocumentRequest::willSendRequest(), which cancels the request.
1675
1676 2011-01-13  Dan Bernstein  <mitz@apple.com>
1677
1678         Reviewed by Mark Rowe.
1679
1680         Don’t try to compile InjectedScriptSource.js into WebCore.
1681
1682         * WebCore.xcodeproj/project.pbxproj:
1683
1684 2011-01-13  Mike Thole  <mthole@apple.com>
1685
1686         Reviewed by Darin Adler and Brady Eidson.
1687
1688         The pageScaleFactor() should be saved/restored along with the scroll position
1689         https://bugs.webkit.org/show_bug.cgi?id=52406
1690         <rdar://problem/8714412>
1691
1692         * history/HistoryItem.cpp:
1693         (WebCore::HistoryItem::HistoryItem): Initialize m_pageScaleFactor.
1694         (WebCore::HistoryItem::pageScaleFactor): Added getter.
1695         (WebCore::HistoryItem::setPageScaleFactor): Added setter.
1696         (WebCore::HistoryItem::encodeBackForwardTreeNode): Encode m_pageScaleFactor.
1697         (WebCore::HistoryItem::decodeBackForwardTree): Decode m_pageScaleFactor.
1698         * history/HistoryItem.h:
1699         * loader/HistoryController.cpp:
1700         (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): Save the page scale factor...
1701         (WebCore::HistoryController::restoreScrollPositionAndViewState): ...and restore it here.
1702
1703 2011-01-13  Evan Martin  <evan@chromium.org>
1704
1705         Reviewed by Tony Chang.
1706
1707         [chromium] drop backwards iteration in Linux complex text code
1708         https://bugs.webkit.org/show_bug.cgi?id=52403
1709
1710         ComplexTextController previously supported iterating through the text in
1711         both directions, but this resulted in duplicate code for each path.
1712         Instead, by being more careful about flipping signs where appropriate,
1713         we can refactor the code into one code path.
1714
1715         No tests, just a refactoring; should be covered by existing tests.
1716
1717         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1718         (WebCore::ComplexTextController::ComplexTextController):
1719         (WebCore::ComplexTextController::reset):
1720         (WebCore::ComplexTextController::nextScriptRun):
1721         * platform/graphics/chromium/ComplexTextControllerLinux.h:
1722         * platform/graphics/chromium/FontLinux.cpp:
1723         (WebCore::glyphIndexForXPositionInScriptRun):
1724         (WebCore::Font::selectionRectForComplexText):
1725
1726 2011-01-13  Dimitri Glazkov  <dglazkov@chromium.org>
1727
1728         Reviewed by Darin Adler.
1729
1730         Flip input[type=range] to use the new shadow DOM model.
1731         https://bugs.webkit.org/show_bug.cgi?id=52317
1732
1733         This is a straight-up flip, minimal change to the logic, which will be
1734         refactored in a follow-up patch.
1735
1736         Covered by existing tests.
1737
1738         * css/CSSStyleSelector.cpp:
1739         (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
1740             host or parent node to find parent.
1741         * html/HTMLInputElement.cpp:
1742         (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
1743             shadow DOM subtree.
1744         * html/InputType.cpp:
1745         (WebCore::InputType::createShadowSubtree): Added empty decl.
1746         (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
1747             shadow subtree.
1748         * html/InputType.h: Added defs.
1749         * html/RangeInputType.cpp:
1750         (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
1751             slider thumb.
1752         * html/RangeInputType.h: Adde def.
1753         * html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
1754             to handle cascading appearance.
1755         (WebCore::RenderSliderThumb::RenderSliderThumb): Added.
1756         (WebCore::RenderSliderThumb::layout): Moved here the logic from
1757             RenderSlider::createThumbStyle.
1758         (WebCore::SliderThumbElement::createRenderer): Added virtual method to
1759             create RenderSliderThumb instance.
1760         (WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
1761             as base class.
1762         (WebCore::SliderThumbElement::detach): Ditto.
1763         * html/shadow/SliderThumbElement.h:
1764         (WebCore::SliderThumbElement::SliderThumbElement): Ditto.
1765         (WebCore::SliderThumbElement::create): Ditto.
1766         (WebCore::toSliderThumbElement): Added a casting helper.
1767         * rendering/MediaControlElements.cpp:
1768         (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
1769             since the whole method is hand-rolled.
1770         (WebCore::MediaControlInputElement::updateStyle): Ditto.
1771         * rendering/RenderSlider.cpp:
1772         (WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
1773         (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
1774         (WebCore::RenderSlider::layout): Ditto.
1775         (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
1776             SliderThumbElement.
1777         (WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
1778         (WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
1779         (WebCore::RenderSlider::setValueForPosition): Ditto.
1780         (WebCore::RenderSlider::positionForOffset): Ditto.
1781         (WebCore::RenderSlider::currentPosition): Ditto.
1782         (WebCore::RenderSlider::trackSize): Ditto.
1783         (WebCore::RenderSlider::forwardEvent): Ditto.
1784         (WebCore::RenderSlider::inDragMode): Ditto.
1785         * rendering/RenderSlider.h: Added def.
1786
1787 2011-01-13  Adam Barth  <abarth@webkit.org>
1788
1789         Reviewed by Eric Seidel.
1790
1791         Rename RGBA32Buffer to ImageFrame
1792         https://bugs.webkit.org/show_bug.cgi?id=52363
1793
1794         RGBA32Buffer is a terrible misnomer.  ImageFrame is vastly
1795         more accurate.  More cleanup to come.
1796
1797         * WebCore.pro:
1798         * platform/graphics/ImageSource.cpp:
1799         (WebCore::ImageSource::createFrameAtIndex):
1800         (WebCore::ImageSource::frameDurationAtIndex):
1801         (WebCore::ImageSource::frameIsCompleteAtIndex):
1802         * platform/graphics/qt/ImageDecoderQt.cpp:
1803         (WebCore::ImageDecoderQt::frameBufferAtIndex):
1804         (WebCore::ImageDecoderQt::internalReadImage):
1805         (WebCore::ImageDecoderQt::internalHandleCurrentImage):
1806         * platform/graphics/qt/ImageDecoderQt.h:
1807         * platform/graphics/wince/ImageWinCE.cpp:
1808         (WebCore::ImageFrame::asNewNativeImage):
1809         * platform/image-decoders/ImageDecoder.cpp:
1810         (WebCore::ImageFrame::ImageFrame):
1811         (WebCore::ImageFrame::operator=):
1812         (WebCore::ImageFrame::clear):
1813         (WebCore::ImageFrame::zeroFill):
1814         (WebCore::ImageFrame::copyReferenceToBitmapData):
1815         (WebCore::ImageFrame::copyBitmapData):
1816         (WebCore::ImageFrame::setSize):
1817         (WebCore::ImageFrame::hasAlpha):
1818         (WebCore::ImageFrame::setHasAlpha):
1819         (WebCore::ImageFrame::setColorProfile):
1820         (WebCore::ImageFrame::setStatus):
1821         (WebCore::ImageFrame::width):
1822         (WebCore::ImageFrame::height):
1823         * platform/image-decoders/ImageDecoder.h:
1824         (WebCore::ImageFrame::ImageFrame):
1825         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
1826         (WebCore::BMPImageDecoder::frameBufferAtIndex):
1827         (WebCore::BMPImageDecoder::decode):
1828         * platform/image-decoders/bmp/BMPImageDecoder.h:
1829         * platform/image-decoders/bmp/BMPImageReader.cpp:
1830         (WebCore::BMPImageReader::decodeBMP):
1831         * platform/image-decoders/bmp/BMPImageReader.h:
1832         (WebCore::BMPImageReader::setBuffer):
1833         * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
1834         (WebCore::ImageFrame::asNewNativeImage):
1835         * platform/image-decoders/cg/ImageDecoderCG.cpp:
1836         (WebCore::getPtrAsPixelData):
1837         (WebCore::ImageFrame::copyReferenceToBitmapData):
1838         (WebCore::ImageFrame::copyBitmapData):
1839         (WebCore::ImageFrame::setSize):
1840         (WebCore::ImageFrame::asNewNativeImage):
1841         * platform/image-decoders/gif/GIFImageDecoder.cpp:
1842         (WebCore::GIFImageDecoder::frameBufferAtIndex):
1843         (WebCore::GIFImageDecoder::clearFrameBufferCache):
1844         (WebCore::GIFImageDecoder::haveDecodedRow):
1845         (WebCore::GIFImageDecoder::frameComplete):
1846         (WebCore::GIFImageDecoder::initFrameBuffer):
1847         * platform/image-decoders/gif/GIFImageDecoder.h:
1848         * platform/image-decoders/gif/GIFImageReader.cpp:
1849         (GIFImageReader::read):
1850         * platform/image-decoders/gif/GIFImageReader.h:
1851         (GIFFrameReader::GIFFrameReader):
1852         * platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
1853         (WebCore::ImageFrame::asNewNativeImage):
1854         * platform/image-decoders/ico/ICOImageDecoder.cpp:
1855         (WebCore::ICOImageDecoder::frameBufferAtIndex):
1856         (WebCore::ICOImageDecoder::decode):
1857         * platform/image-decoders/ico/ICOImageDecoder.h:
1858         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
1859         (WebCore::JPEGImageDecoder::frameBufferAtIndex):
1860         (WebCore::JPEGImageDecoder::outputScanlines):
1861         (WebCore::JPEGImageDecoder::jpegComplete):
1862         (WebCore::JPEGImageDecoder::decode):
1863         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
1864         * platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
1865         (WebCore::ImageFrame::asNewNativeImage):
1866         * platform/image-decoders/png/PNGImageDecoder.cpp:
1867         (WebCore::PNGImageDecoder::frameBufferAtIndex):
1868         (WebCore::PNGImageDecoder::rowAvailable):
1869         (WebCore::PNGImageDecoder::pngComplete):
1870         * platform/image-decoders/png/PNGImageDecoder.h:
1871         (WebCore::PNGImageDecoder::isComplete):
1872         * platform/image-decoders/qt/ImageFrameQt.cpp: Copied from Source/WebCore/platform/image-decoders/qt/RGBA32BufferQt.cpp.
1873         (WebCore::ImageFrame::ImageFrame):
1874         (WebCore::ImageFrame::operator=):
1875         (WebCore::ImageFrame::clear):
1876         (WebCore::ImageFrame::zeroFill):
1877         (WebCore::ImageFrame::copyBitmapData):
1878         (WebCore::ImageFrame::setSize):
1879         (WebCore::ImageFrame::asNewNativeImage):
1880         (WebCore::ImageFrame::hasAlpha):
1881         (WebCore::ImageFrame::setHasAlpha):
1882         (WebCore::ImageFrame::setColorProfile):
1883         (WebCore::ImageFrame::setStatus):
1884         (WebCore::ImageFrame::setPixmap):
1885         (WebCore::ImageFrame::width):
1886         (WebCore::ImageFrame::height):
1887         * platform/image-decoders/qt/RGBA32BufferQt.cpp: Removed.
1888         * platform/image-decoders/skia/ImageDecoderSkia.cpp:
1889         (WebCore::ImageFrame::ImageFrame):
1890         (WebCore::ImageFrame::operator=):
1891         (WebCore::ImageFrame::clear):
1892         (WebCore::ImageFrame::zeroFill):
1893         (WebCore::ImageFrame::copyBitmapData):
1894         (WebCore::ImageFrame::setSize):
1895         (WebCore::ImageFrame::asNewNativeImage):
1896         (WebCore::ImageFrame::hasAlpha):
1897         (WebCore::ImageFrame::setHasAlpha):
1898         (WebCore::ImageFrame::setColorProfile):
1899         (WebCore::ImageFrame::setStatus):
1900         (WebCore::ImageFrame::width):
1901         (WebCore::ImageFrame::height):
1902         * platform/image-decoders/webp/WEBPImageDecoder.cpp:
1903         (WebCore::WEBPImageDecoder::frameBufferAtIndex):
1904         (WebCore::WEBPImageDecoder::decode):
1905         * platform/image-decoders/webp/WEBPImageDecoder.h:
1906         * platform/image-decoders/wx/ImageDecoderWx.cpp:
1907         (WebCore::ImageFrame::asNewNativeImage):
1908
1909 2011-01-13  Dimitri Glazkov  <dglazkov@chromium.org>
1910
1911         Reviewed by Darin Adler.
1912
1913         Transferring nodes between documents should be aware of the shadow DOM.
1914         https://bugs.webkit.org/show_bug.cgi?id=52399
1915
1916         No visible change in behavior at the moment.
1917
1918         Once https://bugs.webkit.org/show_bug.cgi?id=52317 lands, the following
1919         tests should no longer crash:
1920         * fast/css/pseudo-in-range-invalid-value.html
1921         * fast/css/pseudo-in-range.html
1922         * fast/forms/form-collection-elements.html
1923         * fast/forms/range-keyoperation.html
1924
1925         * dom/Document.cpp:
1926         (WebCore::Document::adoptNode): Changed to use Node::setDocumentRecursively.
1927         * dom/Node.cpp:
1928         (WebCore::Node::setDocumentRecursively): Added new method, taking existing
1929             logic and adding shadow DOM traversal.
1930         (WebCore::Node::traverseNextNode): Style fix.
1931         (WebCore::Node::traverseNextSibling): Ditto.
1932         (WebCore::Node::traversePreviousNode): Ditto.
1933         (WebCore::Node::traversePreviousNodePostOrder): Ditto.
1934         (WebCore::Node::checkReplaceChild): Changed to use setDocumentRecursively.
1935         (WebCore::Node::checkAddChild): Ditto.
1936         * dom/Node.h: Added def.
1937
1938 2011-01-12  Enrica Casucci  <enrica@apple.com>
1939
1940         Reviewed by Darin Adler.
1941
1942         WebKit2: Add support for drag and drop
1943         https://bugs.webkit.org/show_bug.cgi?id=52343
1944         <rdar://problem/7660558>
1945                
1946         This patch contains the changes required to support dropping content
1947         in WebKit on the Mac. The DragData class has been extended to provide
1948         additional context from the application (keyboard state, modal windows, etc.)
1949         as well as information of the drag pasteboard being used.
1950         The support for WebKit as drag source will be added with a separate patch.
1951
1952         * WebCore.exp.in:
1953         * page/DragController.cpp:
1954         (WebCore::DragController::dragIsMove): Added DragData parameter.
1955         (WebCore::DragController::tryDocumentDrag): Modified call to dragIsMove.
1956         (WebCore::DragController::concludeEditDrag): Same as above.
1957         * page/DragController.h: Added parameter to isCopyKeyDown.
1958         * page/mac/DragControllerMac.mm:
1959         The following methods have been modified to use the information stored
1960         in the DragData class.
1961         (WebCore::DragController::isCopyKeyDown):
1962         (WebCore::DragController::dragOperation):
1963         * platform/DragData.h:
1964         (WebCore::DragData::flags):
1965         * platform/DragData.cpp: Added default flags parameter to the constructor.
1966         * platform/mac/DragDataMac.mm:
1967         (WebCore::DragData::DragData): Added constructor that receives the name of the pasteboard to use.
1968         (WebCore::DragData::canSmartReplace):
1969         (WebCore::DragData::containsColor):
1970         (WebCore::DragData::containsFiles):
1971         (WebCore::DragData::asFilenames):
1972         (WebCore::DragData::containsPlainText):
1973         (WebCore::DragData::asPlainText):
1974         (WebCore::DragData::containsCompatibleContent):
1975         (WebCore::DragData::asURL):
1976         (WebCore::DragData::asFragment):
1977         All the following files have been modified to add the DragData
1978         parameter to isCopyKeyDown. I plan to improve this in the future
1979         and make isCopyKeyDown not platform specific.
1980         * page/android/DragControllerAndroid.cpp:
1981         (WebCore::DragController::isCopyKeyDown):
1982         * page/brew/DragControllerBrew.cpp:
1983         (WebCore::DragController::isCopyKeyDown):
1984         * page/chromium/DragControllerChromium.cpp:
1985         (WebCore::DragController::isCopyKeyDown):
1986         * page/efl/DragControllerEfl.cpp:
1987         (WebCore::DragController::isCopyKeyDown):
1988         * page/gtk/DragControllerGtk.cpp:
1989         (WebCore::DragController::isCopyKeyDown):
1990         * page/haiku/DragControllerHaiku.cpp:
1991         (WebCore::DragController::isCopyKeyDown):
1992         * page/mac/DragControllerMac.mm:
1993         (WebCore::DragController::isCopyKeyDown):
1994         (WebCore::DragController::dragOperation):
1995         * page/qt/DragControllerQt.cpp:
1996         (WebCore::DragController::isCopyKeyDown):
1997         * page/win/DragControllerWin.cpp:
1998         (WebCore::DragController::isCopyKeyDown):
1999         * page/wx/DragControllerWx.cpp:
2000         (WebCore::DragController::isCopyKeyDown):
2001
2002 2011-01-13  David Kilzer  <ddkilzer@apple.com>
2003
2004         Add missing MathMLElementFactory.h and MathMLNames.h to Xcode project
2005
2006         Not reviewed.
2007
2008         * WebCore.xcodeproj/project.pbxproj: Add missing headers.  Note
2009         that the corresponding source files were originally added to the
2010         project in r48559.
2011
2012 2011-01-12  Zhenyao Mo  <zmo@google.com>
2013
2014         Reviewed by Kenneth Russell.
2015
2016         Use GC3D types in WebGLRenderingContext and related WebGL classes
2017         https://bugs.webkit.org/show_bug.cgi?id=51908
2018
2019         * html/canvas/WebGLActiveInfo.h:
2020         (WebCore::WebGLActiveInfo::create):
2021         (WebCore::WebGLActiveInfo::type):
2022         (WebCore::WebGLActiveInfo::size):
2023         (WebCore::WebGLActiveInfo::WebGLActiveInfo):
2024         * html/canvas/WebGLBuffer.cpp:
2025         (WebCore::WebGLBuffer::associateBufferDataImpl):
2026         (WebCore::WebGLBuffer::associateBufferData):
2027         (WebCore::WebGLBuffer::associateBufferSubDataImpl):
2028         (WebCore::WebGLBuffer::associateBufferSubData):
2029         (WebCore::WebGLBuffer::byteLength):
2030         (WebCore::WebGLBuffer::getCachedMaxIndex):
2031         (WebCore::WebGLBuffer::setCachedMaxIndex):
2032         (WebCore::WebGLBuffer::setTarget):
2033         * html/canvas/WebGLBuffer.h:
2034         (WebCore::WebGLBuffer::getTarget):
2035         * html/canvas/WebGLFramebuffer.cpp:
2036         (WebCore::WebGLFramebuffer::setAttachment):
2037         (WebCore::WebGLFramebuffer::getAttachment):
2038         (WebCore::WebGLFramebuffer::getWidth):
2039         (WebCore::WebGLFramebuffer::getHeight):
2040         (WebCore::WebGLFramebuffer::getColorBufferFormat):
2041         (WebCore::WebGLFramebuffer::initializeRenderbuffers):
2042         * html/canvas/WebGLFramebuffer.h:
2043         * html/canvas/WebGLProgram.cpp:
2044         (WebCore::WebGLProgram::cacheActiveAttribLocations):
2045         (WebCore::WebGLProgram::numActiveAttribLocations):
2046         (WebCore::WebGLProgram::getActiveAttribLocation):
2047         (WebCore::WebGLProgram::isUsingVertexAttrib0):
2048         * html/canvas/WebGLProgram.h:
2049         (WebCore::WebGLProgram::getLinkCount):
2050         * html/canvas/WebGLRenderbuffer.h:
2051         (WebCore::WebGLRenderbuffer::setInternalFormat):
2052         (WebCore::WebGLRenderbuffer::getInternalFormat):
2053         (WebCore::WebGLRenderbuffer::setSize):
2054         (WebCore::WebGLRenderbuffer::getWidth):
2055         (WebCore::WebGLRenderbuffer::getHeight):
2056         * html/canvas/WebGLRenderingContext.cpp:
2057         (WebCore::WebGLRenderingContext::initializeNewContext):
2058         (WebCore::WebGLRenderingContext::sizeInBytes):
2059         (WebCore::WebGLRenderingContext::activeTexture):
2060         (WebCore::WebGLRenderingContext::bindAttribLocation):
2061         (WebCore::WebGLRenderingContext::bindBuffer):
2062         (WebCore::WebGLRenderingContext::bindFramebuffer):
2063         (WebCore::WebGLRenderingContext::bindRenderbuffer):
2064         (WebCore::WebGLRenderingContext::bindTexture):
2065         (WebCore::WebGLRenderingContext::blendColor):
2066         (WebCore::WebGLRenderingContext::blendEquation):
2067         (WebCore::WebGLRenderingContext::blendEquationSeparate):
2068         (WebCore::WebGLRenderingContext::blendFunc):
2069         (WebCore::WebGLRenderingContext::blendFuncSeparate):
2070         (WebCore::WebGLRenderingContext::bufferData):
2071         (WebCore::WebGLRenderingContext::bufferSubData):
2072         (WebCore::WebGLRenderingContext::checkFramebufferStatus):
2073         (WebCore::WebGLRenderingContext::clear):
2074         (WebCore::WebGLRenderingContext::clearColor):
2075         (WebCore::WebGLRenderingContext::clearDepth):
2076         (WebCore::WebGLRenderingContext::clearStencil):
2077         (WebCore::WebGLRenderingContext::colorMask):
2078         (WebCore::WebGLRenderingContext::copyTexImage2D):
2079         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
2080         (WebCore::WebGLRenderingContext::createShader):
2081         (WebCore::WebGLRenderingContext::cullFace):
2082         (WebCore::WebGLRenderingContext::deleteBuffer):
2083         (WebCore::WebGLRenderingContext::depthFunc):
2084         (WebCore::WebGLRenderingContext::depthMask):
2085         (WebCore::WebGLRenderingContext::depthRange):
2086         (WebCore::WebGLRenderingContext::disable):
2087         (WebCore::WebGLRenderingContext::disableVertexAttribArray):
2088         (WebCore::WebGLRenderingContext::validateElementArraySize):
2089         (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
2090         (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
2091         (WebCore::WebGLRenderingContext::validateRenderingState):
2092         (WebCore::WebGLRenderingContext::drawArrays):
2093         (WebCore::WebGLRenderingContext::drawElements):
2094         (WebCore::WebGLRenderingContext::enable):
2095         (WebCore::WebGLRenderingContext::enableVertexAttribArray):
2096         (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
2097         (WebCore::WebGLRenderingContext::framebufferTexture2D):
2098         (WebCore::WebGLRenderingContext::frontFace):
2099         (WebCore::WebGLRenderingContext::generateMipmap):
2100         (WebCore::WebGLRenderingContext::getActiveAttrib):
2101         (WebCore::WebGLRenderingContext::getActiveUniform):
2102         (WebCore::WebGLRenderingContext::getAttachedShaders):
2103         (WebCore::WebGLRenderingContext::getAttribLocation):
2104         (WebCore::WebGLRenderingContext::getBufferParameter):
2105         (WebCore::WebGLRenderingContext::getError):
2106         (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
2107         (WebCore::WebGLRenderingContext::getParameter):
2108         (WebCore::WebGLRenderingContext::getProgramParameter):
2109         (WebCore::WebGLRenderingContext::getRenderbufferParameter):
2110         (WebCore::WebGLRenderingContext::getShaderParameter):
2111         (WebCore::WebGLRenderingContext::getTexParameter):
2112         (WebCore::WebGLRenderingContext::getUniform):
2113         (WebCore::WebGLRenderingContext::getUniformLocation):
2114         (WebCore::WebGLRenderingContext::getVertexAttrib):
2115         (WebCore::WebGLRenderingContext::getVertexAttribOffset):
2116         (WebCore::WebGLRenderingContext::hint):
2117         (WebCore::WebGLRenderingContext::isBuffer):
2118         (WebCore::WebGLRenderingContext::isEnabled):
2119         (WebCore::WebGLRenderingContext::isFramebuffer):
2120         (WebCore::WebGLRenderingContext::isProgram):
2121         (WebCore::WebGLRenderingContext::isRenderbuffer):
2122         (WebCore::WebGLRenderingContext::isShader):
2123         (WebCore::WebGLRenderingContext::isTexture):
2124         (WebCore::WebGLRenderingContext::lineWidth):
2125         (WebCore::WebGLRenderingContext::linkProgram):
2126         (WebCore::WebGLRenderingContext::pixelStorei):
2127         (WebCore::WebGLRenderingContext::polygonOffset):
2128         (WebCore::WebGLRenderingContext::readPixels):
2129         (WebCore::WebGLRenderingContext::renderbufferStorage):
2130         (WebCore::WebGLRenderingContext::sampleCoverage):
2131         (WebCore::WebGLRenderingContext::scissor):
2132         (WebCore::WebGLRenderingContext::stencilFunc):
2133         (WebCore::WebGLRenderingContext::stencilFuncSeparate):
2134         (WebCore::WebGLRenderingContext::stencilMask):
2135         (WebCore::WebGLRenderingContext::stencilMaskSeparate):
2136         (WebCore::WebGLRenderingContext::stencilOp):
2137         (WebCore::WebGLRenderingContext::stencilOpSeparate):
2138         (WebCore::WebGLRenderingContext::texImage2DBase):
2139         (WebCore::WebGLRenderingContext::texImage2DImpl):
2140         (WebCore::WebGLRenderingContext::texImage2D):
2141         (WebCore::WebGLRenderingContext::texParameter):
2142         (WebCore::WebGLRenderingContext::texParameterf):
2143         (WebCore::WebGLRenderingContext::texParameteri):
2144         (WebCore::WebGLRenderingContext::texSubImage2DBase):
2145         (WebCore::WebGLRenderingContext::texSubImage2DImpl):
2146         (WebCore::WebGLRenderingContext::texSubImage2D):
2147         (WebCore::WebGLRenderingContext::uniform1f):
2148         (WebCore::WebGLRenderingContext::uniform1fv):
2149         (WebCore::WebGLRenderingContext::uniform1i):
2150         (WebCore::WebGLRenderingContext::uniform1iv):
2151         (WebCore::WebGLRenderingContext::uniform2f):
2152         (WebCore::WebGLRenderingContext::uniform2fv):
2153         (WebCore::WebGLRenderingContext::uniform2i):
2154         (WebCore::WebGLRenderingContext::uniform2iv):
2155         (WebCore::WebGLRenderingContext::uniform3f):
2156         (WebCore::WebGLRenderingContext::uniform3fv):
2157         (WebCore::WebGLRenderingContext::uniform3i):
2158         (WebCore::WebGLRenderingContext::uniform3iv):
2159         (WebCore::WebGLRenderingContext::uniform4f):
2160         (WebCore::WebGLRenderingContext::uniform4fv):
2161         (WebCore::WebGLRenderingContext::uniform4i):
2162         (WebCore::WebGLRenderingContext::uniform4iv):
2163         (WebCore::WebGLRenderingContext::uniformMatrix2fv):
2164         (WebCore::WebGLRenderingContext::uniformMatrix3fv):
2165         (WebCore::WebGLRenderingContext::uniformMatrix4fv):
2166         (WebCore::WebGLRenderingContext::vertexAttrib1f):
2167         (WebCore::WebGLRenderingContext::vertexAttrib1fv):
2168         (WebCore::WebGLRenderingContext::vertexAttrib2f):
2169         (WebCore::WebGLRenderingContext::vertexAttrib2fv):
2170         (WebCore::WebGLRenderingContext::vertexAttrib3f):
2171         (WebCore::WebGLRenderingContext::vertexAttrib3fv):
2172         (WebCore::WebGLRenderingContext::vertexAttrib4f):
2173         (WebCore::WebGLRenderingContext::vertexAttrib4fv):
2174         (WebCore::WebGLRenderingContext::vertexAttribPointer):
2175         (WebCore::WebGLRenderingContext::viewport):
2176         (WebCore::WebGLRenderingContext::getBooleanParameter):
2177         (WebCore::WebGLRenderingContext::getBooleanArrayParameter):
2178         (WebCore::WebGLRenderingContext::getFloatParameter):
2179         (WebCore::WebGLRenderingContext::getIntParameter):
2180         (WebCore::WebGLRenderingContext::getLongParameter):
2181         (WebCore::WebGLRenderingContext::getUnsignedLongParameter):
2182         (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
2183         (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter):
2184         (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
2185         (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat):
2186         (WebCore::WebGLRenderingContext::validateTextureBinding):
2187         (WebCore::WebGLRenderingContext::validateSize):
2188         (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
2189         (WebCore::WebGLRenderingContext::validateTexFuncLevel):
2190         (WebCore::WebGLRenderingContext::validateTexFuncParameters):
2191         (WebCore::WebGLRenderingContext::validateTexFuncData):
2192         (WebCore::WebGLRenderingContext::validateDrawMode):
2193         (WebCore::WebGLRenderingContext::validateStencilFunc):
2194         (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
2195         (WebCore::WebGLRenderingContext::validateBlendEquation):
2196         (WebCore::WebGLRenderingContext::validateBlendFuncFactors):
2197         (WebCore::WebGLRenderingContext::validateCapability):
2198         (WebCore::WebGLRenderingContext::validateUniformParameters):
2199         (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
2200         (WebCore::WebGLRenderingContext::validateBufferDataParameters):
2201         (WebCore::WebGLRenderingContext::vertexAttribfImpl):
2202         (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
2203         (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
2204         * html/canvas/WebGLRenderingContext.h:
2205         (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
2206         * html/canvas/WebGLShader.cpp:
2207         (WebCore::WebGLShader::create):
2208         (WebCore::WebGLShader::WebGLShader):
2209         * html/canvas/WebGLShader.h:
2210         (WebCore::WebGLShader::getType):
2211         * html/canvas/WebGLTexture.cpp:
2212         (WebCore::WebGLTexture::setTarget):
2213         (WebCore::WebGLTexture::setParameteri):
2214         (WebCore::WebGLTexture::setParameterf):
2215         (WebCore::WebGLTexture::setLevelInfo):
2216         (WebCore::WebGLTexture::generateMipmapLevelInfo):
2217         (WebCore::WebGLTexture::getInternalFormat):
2218         (WebCore::WebGLTexture::getType):
2219         (WebCore::WebGLTexture::getWidth):
2220         (WebCore::WebGLTexture::getHeight):
2221         (WebCore::WebGLTexture::isNPOT):
2222         (WebCore::WebGLTexture::mapTargetToIndex):
2223         (WebCore::WebGLTexture::computeLevelCount):
2224         (WebCore::WebGLTexture::update):
2225         (WebCore::WebGLTexture::getLevelInfo):
2226         * html/canvas/WebGLTexture.h:
2227         (WebCore::WebGLTexture::LevelInfo::setInfo):
2228         * html/canvas/WebGLUniformLocation.cpp:
2229         (WebCore::WebGLUniformLocation::create):
2230         (WebCore::WebGLUniformLocation::WebGLUniformLocation):
2231         (WebCore::WebGLUniformLocation::location):
2232         * html/canvas/WebGLUniformLocation.h:
2233         * platform/graphics/GraphicsContext3D.h: Map GC3Dboolean to bool instead of unsigned char.
2234
2235 2011-01-13  Jian Li  <jianli@chromium.org>
2236
2237         Reviewed by Darin Fisher.
2238
2239         Change createObjectURL and revokeObjectURL to put under webkitURL.
2240         https://bugs.webkit.org/show_bug.cgi?id=52257
2241
2242         Note that we add "webkit" vendor prefix to URL that is introduced in
2243         the latest File API spec.
2244
2245         For the time being, we implement webkitURL as a readonly attribute
2246         instead of a constructor so that we will not expose prototype property,
2247         as required by the spec.
2248
2249         * Android.derived.jscbindings.mk:
2250         * Android.derived.v8bindings.mk:
2251         * Android.mk:
2252         * CMakeLists.txt:
2253         * DerivedSources.cpp:
2254         * DerivedSources.make:
2255         * GNUmakefile.am:
2256         * WebCore.gypi:
2257         * WebCore.pri:
2258         * WebCore.pro:
2259         * WebCore.vcproj/WebCore.vcproj:
2260         * WebCore.xcodeproj/project.pbxproj:
2261         * html/DOMURL.cpp: Added.
2262         * html/DOMURL.h: Added.
2263         * html/DOMURL.idl: Added.
2264         * inspector/front-end/NetworkPanel.js:
2265         * inspector/front-end/utilities.js:
2266         * page/DOMWindow.cpp:
2267         (WebCore::DOMWindow::webkitURL):
2268         * page/DOMWindow.h:
2269         * page/DOMWindow.idl:
2270         * workers/WorkerContext.cpp:
2271         (WebCore::WorkerContext::webkitURL):
2272         * workers/WorkerContext.h:
2273         * workers/WorkerContext.idl:
2274
2275 2011-01-13  Emil Eklund  <eae@chromium.org>
2276
2277         Reviewed by Dimitri Glazkov.
2278
2279         Setting outerText should convert CR/LF to <br>
2280         https://bugs.webkit.org/show_bug.cgi?id=52268
2281
2282         Make set outerText support line breaks (sharing the text to fragment code
2283         with setInnerText) and handle empty text nodes the same way IE does.
2284
2285         Test: fast/dom/set-outer-text.html
2286
2287         * html/HTMLElement.cpp:
2288         (WebCore::HTMLElement::textToFragment): Shared between setInnerText and setOuterText
2289         (WebCore::HTMLElement::setInnerText): Split out text parsing code.
2290         (WebCore::mergeWithNextTextNode): Split out text node merging code.
2291         (WebCore::HTMLElement::setOuterText): Added support for line breaks.
2292         * html/HTMLElement.h:
2293
2294 2011-01-13  Zhenyao Mo  <zmo@google.com>
2295
2296         Reviewed by Kenneth Russell.
2297
2298         Relax the ESSL valid charset a little bit to include " ' `
2299         https://bugs.webkit.org/show_bug.cgi?id=52396
2300
2301         * html/canvas/WebGLRenderingContext.cpp:
2302
2303 >>>>>>> .r75740
2304 2011-01-13  Adrienne Walker  <enne@google.com>
2305
2306         Reviewed by Kenneth Russell.
2307
2308         [chromium] Attempt to fix crash in tiled compositor memcpy
2309         https://bugs.webkit.org/show_bug.cgi?id=52379
2310
2311         * platform/graphics/chromium/LayerTilerChromium.cpp:
2312         (WebCore::LayerTilerChromium::update):
2313
2314 2011-01-13  Dimitri Glazkov  <dglazkov@chromium.org>
2315
2316         Unreviewed, rolling out r75725.
2317         http://trac.webkit.org/changeset/75725
2318         https://bugs.webkit.org/show_bug.cgi?id=52317
2319
2320         Caused crashes in layout tests.
2321
2322         * css/CSSStyleSelector.cpp:
2323         (WebCore::CSSStyleSelector::initForStyleResolve):
2324         * html/HTMLInputElement.cpp:
2325         (WebCore::HTMLInputElement::updateType):
2326         * html/InputType.cpp:
2327         * html/InputType.h:
2328         * html/RangeInputType.cpp:
2329         * html/RangeInputType.h:
2330         * html/shadow/SliderThumbElement.cpp:
2331         (WebCore::SliderThumbElement::defaultEventHandler):
2332         (WebCore::SliderThumbElement::detach):
2333         * html/shadow/SliderThumbElement.h:
2334         (WebCore::SliderThumbElement::SliderThumbElement):
2335         (WebCore::SliderThumbElement::create):
2336         * rendering/MediaControlElements.cpp:
2337         (WebCore::MediaControlInputElement::attach):
2338         (WebCore::MediaControlInputElement::updateStyle):
2339         * rendering/RenderSlider.cpp:
2340         (WebCore::RenderSlider::~RenderSlider):
2341         (WebCore::RenderSlider::styleDidChange):
2342         (WebCore::RenderSlider::createThumbStyle):
2343         (WebCore::RenderSlider::thumbRect):
2344         (WebCore::RenderSlider::layout):
2345         (WebCore::RenderSlider::updateFromElement):
2346         (WebCore::RenderSlider::mouseEventIsInThumb):
2347         (WebCore::RenderSlider::mouseEventOffsetToThumb):
2348         (WebCore::RenderSlider::setValueForPosition):
2349         (WebCore::RenderSlider::positionForOffset):
2350         (WebCore::RenderSlider::currentPosition):
2351         (WebCore::RenderSlider::trackSize):
2352         (WebCore::RenderSlider::forwardEvent):
2353         (WebCore::RenderSlider::inDragMode):
2354         * rendering/RenderSlider.h:
2355
2356 2011-01-12  Dimitri Glazkov  <dglazkov@chromium.org>
2357
2358         Reviewed by Darin Adler.
2359
2360         Flip input[type=range] to use the new shadow DOM model.
2361         https://bugs.webkit.org/show_bug.cgi?id=52317
2362
2363         This is a straight-up flip, minimal change to the logic, which will be
2364         refactored in a follow-up patch.
2365
2366         Covered by existing tests.
2367
2368         * css/CSSStyleSelector.cpp:
2369         (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
2370             host or parent node to find parent.
2371         * html/HTMLInputElement.cpp:
2372         (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
2373             shadow DOM subtree.
2374         * html/InputType.cpp:
2375         (WebCore::InputType::createShadowSubtree): Added empty decl.
2376         (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
2377             shadow subtree.
2378         * html/InputType.h: Added defs.
2379         * html/RangeInputType.cpp:
2380         (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
2381             slider thumb.
2382         * html/RangeInputType.h: Adde def.
2383         * html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
2384             to handle cascading appearance.
2385         (WebCore::RenderSliderThumb::RenderSliderThumb): Added.
2386         (WebCore::RenderSliderThumb::layout): Moved here the logic from
2387             RenderSlider::createThumbStyle.
2388         (WebCore::SliderThumbElement::createRenderer): Added virtual method to
2389             create RenderSliderThumb instance.
2390         (WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
2391             as base class.
2392         (WebCore::SliderThumbElement::detach): Ditto.
2393         * html/shadow/SliderThumbElement.h:
2394         (WebCore::SliderThumbElement::SliderThumbElement): Ditto.
2395         (WebCore::SliderThumbElement::create): Ditto.
2396         (WebCore::toSliderThumbElement): Added a casting helper.
2397         * rendering/MediaControlElements.cpp:
2398         (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
2399             since the whole method is hand-rolled.
2400         (WebCore::MediaControlInputElement::updateStyle): Ditto.
2401         * rendering/RenderSlider.cpp:
2402         (WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
2403         (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
2404         (WebCore::RenderSlider::layout): Ditto.
2405         (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
2406             SliderThumbElement.
2407         (WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
2408         (WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
2409         (WebCore::RenderSlider::setValueForPosition): Ditto.
2410         (WebCore::RenderSlider::positionForOffset): Ditto.
2411         (WebCore::RenderSlider::currentPosition): Ditto.
2412         (WebCore::RenderSlider::trackSize): Ditto.
2413         (WebCore::RenderSlider::forwardEvent): Ditto.
2414         (WebCore::RenderSlider::inDragMode): Ditto.
2415         * rendering/RenderSlider.h: Added def.
2416
2417 2011-01-13  Dan Bernstein  <mitz@apple.com>
2418
2419         Reviewed by Simon Fraser.
2420
2421         <rdar://problem/8098442> Crash in Widget::setFrameRect()
2422         https://bugs.webkit.org/show_bug.cgi?id=52375
2423
2424         Test: plugins/destroy-on-setwindow.html
2425
2426         * platform/mac/WidgetMac.mm:
2427         (WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
2428         out to the view.
2429         (WebCore::Widget::getOuterView): Coding style fix.
2430         (WebCore::Widget::paint): Protect the Widget from being deleted as a result of calling out to
2431         the views. This is precautionary, since this function does not applear to access member variables
2432         after such calls.
2433         * platform/wx/WidgetWx.cpp:
2434         (WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
2435         out to the platform widget.
2436
2437 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2438
2439         Unreviewed buildfix after r75715.
2440
2441         * WebCore.pri:
2442         * WebCore.pro:
2443
2444 2011-01-13  Pavel Feldman  <pfeldman@chromium.org>
2445
2446         Not reviewed: Qt build fix.
2447
2448         * WebCore.pri:
2449
2450 2011-01-12  Pavel Feldman  <pfeldman@chromium.org>
2451
2452         Reviewed by Yury Semikhatsky.
2453
2454         Web Inspector: embed injected script into the backend.
2455         https://bugs.webkit.org/show_bug.cgi?id=52312
2456
2457         InjectedScript belongs to the backend of the system and
2458         should be exposed by means of protocol, not InjectedScriptAccess.
2459         This patch makes injected script a part of the backend.
2460         It introduces single manual generation step (xxd -i) that should be
2461         automated by the build scripts for all the platforms.
2462
2463         * CMakeLists.txt:
2464         * DerivedSources.make:
2465         * GNUmakefile.am:
2466         * WebCore.gyp/WebCore.gyp:
2467         * WebCore.gypi:
2468         * WebCore.pro:
2469         * WebCore.vcproj/WebCore.vcproj:
2470         * WebCore.xcodeproj/project.pbxproj:
2471         * bindings/js/JSInjectedScriptHostCustom.cpp:
2472         (WebCore::InjectedScriptHost::injectedScriptFor):
2473         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2474         (WebCore::InjectedScriptHost::injectedScriptFor):
2475         * inspector/InjectedScriptHost.cpp:
2476         (WebCore::InjectedScriptHost::injectedScriptSource):
2477         * inspector/InjectedScriptHost.h:
2478         * inspector/Inspector.idl:
2479         * inspector/InspectorController.cpp:
2480         (WebCore::InspectorController::restoreInspectorStateFromCookie):
2481         * inspector/InspectorState.cpp:
2482         (WebCore::InspectorState::InspectorState):
2483         * inspector/InspectorState.h:
2484         * inspector/front-end/InjectedScript.js: Removed.
2485         * inspector/front-end/WebKit.qrc:
2486         * inspector/front-end/inspector.html:
2487         * inspector/front-end/inspector.js:
2488         (WebInspector.doLoadedDone.propertyNamesCallback):
2489         (WebInspector.doLoadedDone):
2490         * inspector/xxd.pl: Added.
2491
2492 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2493
2494         Reviewed by Timothy Hatcher.
2495
2496         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2497         to be passed directly to WebInspector.UIString
2498
2499         https://bugs.webkit.org/show_bug.cgi?id=52365
2500
2501         * English.lproj/localizedStrings.js:
2502         * inspector/front-end/ApplicationCacheItemsView.js:
2503         (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
2504         (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
2505         * inspector/front-end/AuditRules.js:
2506         (WebInspector.AuditRules.GzipRule.prototype.doRun):
2507         (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
2508         (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
2509         * inspector/front-end/BreakpointsSidebarPane.js:
2510         (WebInspector.EventListenerBreakpointsSidebarPane):
2511         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
2512         * inspector/front-end/CookieItemsView.js:
2513         (WebInspector.CookieItemsView.prototype._updateWithCookies):
2514         * inspector/front-end/ImageView.js:
2515         (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
2516         (WebInspector.ImageView.prototype._createContentIfNeeded):
2517         * inspector/front-end/NetworkPanel.js:
2518         (WebInspector.NetworkTimeCalculator.prototype.formatValue):
2519         (WebInspector.NetworkTransferTimeCalculator.prototype.formatValue):
2520         (WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
2521         * inspector/front-end/ProfileDataGridTree.js:
2522         (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
2523         (WebInspector.ProfileDataGridNode.prototype.get data):
2524         * inspector/front-end/Resource.js:
2525         (WebInspector.Resource.Type.toUIString):
2526         (WebInspector.Resource.Type.toString):
2527         * inspector/front-end/TimelineOverviewPane.js:
2528         (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
2529         * inspector/front-end/TimelinePanel.js:
2530         (WebInspector.TimelinePanel):
2531         (WebInspector.TimelineCalculator.prototype.formatValue):
2532         (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
2533         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
2534         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2535         * inspector/front-end/utilities.js:
2536         ():
2537
2538 2011-01-13  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2539
2540         Reviewed by Simon Hausmann.
2541
2542         [Qt] Need a way to inform the application when a Netscape plugin is created.
2543         https://bugs.webkit.org/show_bug.cgi?id=30179
2544
2545         Added "c" style static method for the application to hook up for
2546         receiving notifications when a plugin is created.
2547
2548         * plugins/symbian/PluginViewSymbian.cpp:
2549         (qtwebkit_setPluginCreatedCallback):
2550         (WebCore::PluginView::platformStart):
2551
2552 2011-01-13  Yi Shen  <yi.4.shen@nokia.com>
2553
2554         Reviewed by Eric Seidel.
2555
2556         [Qt] Use a black background color for the video element on Qt Mobile
2557         https://bugs.webkit.org/show_bug.cgi?id=52252
2558
2559         Use black as the background color for the video element on Qt Mobile.
2560
2561         * css/themeQtMobile.css:
2562         (video):
2563
2564 2011-01-13  Yi Shen  <yi.4.shen@nokia.com>
2565
2566         Reviewed by Eric Seidel.
2567
2568         [Qt] Use a big central media play control button for video element 
2569         https://bugs.webkit.org/show_bug.cgi?id=52315
2570
2571         When ChromeClient::requiresFullscreenForVideoPlayback() returns true,
2572         all other control buttons for the video element are hidden, except 
2573         a big centralized play button.
2574
2575         No new tests because no client implements requiresFullscreenForVideoPlayback yet.
2576
2577         * WebCore.pri:
2578         * css/mediaControlsQtFullscreen.css: Added.
2579         (audio):
2580         (audio::-webkit-media-controls-panel):
2581         (video::-webkit-media-controls-panel):
2582         (video:-webkit-full-page-media::-webkit-media-controls-panel):
2583         (audio::-webkit-media-controls-mute-button):
2584         (video::-webkit-media-controls-mute-button):
2585         (audio::-webkit-media-controls-play-button):
2586         (video::-webkit-media-controls-play-button):
2587         (audio::-webkit-media-controls-timeline-container):
2588         (video::-webkit-media-controls-timeline-container):
2589         (audio::-webkit-media-controls-current-time-display):
2590         (video::-webkit-media-controls-current-time-display):
2591         (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
2592         (audio::-webkit-media-controls-timeline):
2593         (video::-webkit-media-controls-timeline):
2594         (audio::-webkit-media-controls-volume-slider-container):
2595         (video::-webkit-media-controls-volume-slider-container):
2596         (audio::-webkit-media-controls-volume-slider):
2597         (video::-webkit-media-controls-volume-slider):
2598         (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
2599         (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
2600         (audio::-webkit-media-controls-fullscreen-button):
2601         (video::-webkit-media-controls-fullscreen-button):
2602         (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
2603         (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
2604         (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
2605         * platform/qt/RenderThemeQt.cpp:
2606         (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
2607
2608 2011-01-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2609
2610         Reviewed by Xan Lopez.
2611
2612         [GTK] Paint toggle buttons inconsistent when the object state is indeterminate
2613         https://bugs.webkit.org/show_bug.cgi?id=52361
2614
2615         Check whether the object state is indeterminate to set the flag
2616         GTK_STATE_FLAG_INCONSISTENT before rendering check and radio
2617         buttons.
2618
2619         * platform/gtk/RenderThemeGtk3.cpp:
2620         (WebCore::paintToggle):
2621
2622 2011-01-13  Yi Shen  <yi.4.shen@nokia.com>
2623
2624         Reviewed by Simon Hausmann.
2625
2626         [Qt] Extend the Platform Plugin to support full screen video handler
2627         https://bugs.webkit.org/show_bug.cgi?id=51249
2628
2629         Make MediaPlayerPrivateQt support a fullscreen player.
2630
2631         No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
2632         However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
2633         So, still skip it for Qt.
2634
2635         * WebCore.pro:
2636         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
2637         (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
2638         (WebCore::MediaPlayerPrivateQt::removeVideoItem):
2639         (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
2640         * platform/graphics/qt/MediaPlayerPrivateQt.h:
2641         (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
2642         (WebCore::MediaPlayerPrivateQt::mediaPlayer):
2643
2644 2011-01-13  Dan Bernstein  <mitz@apple.com>
2645
2646         Reviewed by Dave Hyatt.
2647
2648         <rdar://problem/8858548> Disable inheritance of text emphasis marks to ruby text
2649         https://bugs.webkit.org/show_bug.cgi?id=52359
2650
2651         Test: fast/ruby/text-emphasis.html
2652
2653         * css/html.css:
2654         (rt):
2655
2656 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2657
2658         Rubber-stamped by David Levin.
2659
2660         Trivial fix after r75682.
2661
2662         * loader/FrameLoader.cpp: Remove accidentally committed debug code.
2663         (WebCore::FrameLoader::shouldClose):
2664
2665 2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>
2666
2667         Reviewed by Eric Seidel.
2668
2669         REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
2670         https://bugs.webkit.org/show_bug.cgi?id=52241
2671
2672         The bug was caused by RenderTextControl::selection's creating a Range with m_insertText
2673         which is a shadow DOM div as both start and end containers. Fixed the bug by traversing
2674         through the descendents of m_innerText and using the right start and end containers to
2675         create a Range.
2676
2677         Test: fast/forms/focus-change-on-keypress.html
2678
2679         * rendering/RenderTextControl.cpp:
2680         (WebCore::setContainerAndOffsetForRange): Added; a helper function.
2681         (WebCore::RenderTextControl::selection): See above.
2682
2683 2011-01-12  Kenichi Ishibashi  <bashi@google.com>
2684
2685         Reviewed by Kent Tamura.
2686
2687         M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
2688         https://bugs.webkit.org/show_bug.cgi?id=51905
2689
2690         Calls unregisterFormElementWithFormAttribute() when 'form' attribute
2691         is removed.
2692
2693         Tests: fast/forms/form-associated-element-crash.html
2694                fast/forms/form-associated-element-crash2.html
2695
2696         * html/FormAssociatedElement.cpp:
2697         (WebCore::FormAssociatedElement::formAttributeChanged):
2698
2699 2011-01-12  Kenichi Ishibashi  <bashi@google.com>
2700
2701         Reviewed by Kent Tamura.
2702
2703         M_formElementsWithFormAttribute not cleared when Node is moved to another document.
2704         https://bugs.webkit.org/show_bug.cgi?id=51418
2705
2706         Calls unregisterFormElementWithFormAttribute() when form associated elements
2707         are moved to another document.
2708
2709         Test: fast/forms/change-form-element-document-crash.html
2710
2711         * html/FormAssociatedElement.cpp:
2712         (WebCore::FormAssociatedElement::willMoveToNewOwnerDocument): Added.
2713         * html/FormAssociatedElement.h: Added willMoveToNewOwnerDocument().
2714         * html/HTMLFormControlElement.cpp:
2715         (WebCore::HTMLFormControlElement::willMoveToNewOwnerDocument): Added.
2716         * html/HTMLFormControlElement.h: Added willMoveToNewOwnerDocument().
2717         * html/HTMLObjectElement.cpp:
2718         (WebCore::HTMLObjectElement::willMoveToNewOwnerDocument): Added.
2719         * html/HTMLObjectElement.h: Added willMoveToNewOwnerDocument().
2720         * html/HTMLPlugInImageElement.h: Moves willMoveToNewOwnerDocument() to protected.
2721
2722 2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>
2723
2724         Reviewed by Eric Seidel.
2725
2726         Stop instantiating legacy editing positions in ApplyBlockElementCommand and ApplyStyleCommand
2727         https://bugs.webkit.org/show_bug.cgi?id=52250
2728
2729         Removed instantiation of legacy editing positions.
2730         Calls to Position::Position are replaced by calls to Position's convenience functions.
2731
2732         Also added firstPositionInOrBeforeNode and lastPositionInOrAfterNode,
2733         which are functions that return firstPositionInNode and lastPositionInNode respectively
2734         when the specified node can have children for editing purpose and return positionBeforeNode
2735         and positionAfterNode respectively otherwise. They can be used to guarantee that we never
2736         create a bogus position like [img, 0] or [br, 0].
2737
2738         No tests are added since this is a cleanup.
2739
2740         * editing/ApplyBlockElementCommand.cpp:
2741         (WebCore::ApplyBlockElementCommand::formatSelection):
2742         * editing/ApplyStyleCommand.cpp:
2743         (WebCore::ApplyStyleCommand::applyBlockStyle):
2744         (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
2745         (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
2746         (WebCore::ApplyStyleCommand::removeInlineStyle):
2747         (WebCore::ApplyStyleCommand::nodeFullySelected):
2748         (WebCore::ApplyStyleCommand::nodeFullyUnselected):
2749         (WebCore::ApplyStyleCommand::splitTextAtStart):
2750         (WebCore::ApplyStyleCommand::splitTextAtEnd):
2751         (WebCore::ApplyStyleCommand::splitTextElementAtStart):
2752         (WebCore::ApplyStyleCommand::splitTextElementAtEnd):
2753         (WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode):
2754         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
2755         (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
2756         (WebCore::ApplyStyleCommand::computedFontSize):
2757         (WebCore::ApplyStyleCommand::joinChildTextNodes):
2758         * editing/ApplyStyleCommand.h:
2759         * editing/htmlediting.h:
2760         (WebCore::firstPositionInOrBeforeNode): Added.
2761         (WebCore::lastPositionInOrAfterNode): Added.
2762
2763 2011-01-12  Sam Weinig  <sam@webkit.org>
2764
2765         Another build fix.
2766
2767         * platform/mac/WheelEventMac.mm:
2768         (WebCore::phaseForEvent):
2769
2770 2011-01-12  Sam Weinig  <sam@webkit.org>
2771
2772         Fix build.
2773
2774         * platform/mac/WheelEventMac.mm:
2775         (WebCore::phaseForEvent):
2776
2777 2011-01-12  Adam Barth  <abarth@webkit.org>
2778
2779         Reviewed by Darin Adler.
2780
2781         Remove premature optimization from SchemeRegistry
2782         https://bugs.webkit.org/show_bug.cgi?id=52283
2783
2784         As far as I can tell, this optimization isn't necessary.  I'm slightly
2785         unsure which benchmarks to run to demonstrate this numerically, but
2786         none of the benchmarks Chromium tracks were affected by adding a
2787         similar check for "display-isolated" schemes.
2788
2789         * platform/SchemeRegistry.cpp:
2790         (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
2791
2792 2011-01-12  Beth Dakin  <bdakin@apple.com>
2793
2794         Reviewed by Anders Carlsson.
2795
2796         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
2797         Expose fixed layout through WebKit SPI
2798         -and corresponding-
2799         <rdar://problem/8844464>
2800
2801         And now with getters!
2802         * WebCore.exp.in:
2803
2804 2011-01-12  Sam Weinig  <sam@webkit.org>
2805
2806         Reviewed by Anders Carlsson.
2807
2808         https://bugs.webkit.org/show_bug.cgi?id=52337
2809         PlatformWheelEvent should know about the scroll phase on the Mac
2810
2811         Add a phase parameter on Mac PlatformWheelEvents.
2812
2813         * platform/PlatformWheelEvent.h:
2814         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2815         (WebCore::PlatformWheelEvent::phase):
2816         * platform/mac/WheelEventMac.mm:
2817         (WebCore::phaseForEvent):
2818         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2819
2820 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2821
2822         Unreviewed.
2823
2824         A couple of lines of the patch for https://bugs.webkit.org/show_bug.cgi?id=52321
2825         were omitted. 
2826
2827         * platform/graphics/ca/GraphicsLayerCA.cpp:
2828         (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
2829
2830 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2831
2832         Unreviewed.
2833
2834         Getting rid of an assert that was causing build failures that turns out not to be needed.
2835
2836         * rendering/RenderLayer.cpp:
2837         (WebCore::RenderLayer::paintsWithTransform):
2838
2839 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2840
2841         Unreviewed.
2842
2843         Another fix for Gtk
2844
2845         * rendering/RenderLayer.cpp:
2846         (WebCore::RenderLayer::paintsWithTransform):
2847
2848 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2849
2850         Unreviewed.
2851
2852         Fix for Gtk and Windows builds
2853
2854         * page/Frame.cpp:
2855         (WebCore::Frame::scalePage):
2856         * page/Frame.h:
2857         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
2858         (PlatformCALayer::contentsScale):
2859         (PlatformCALayer::setContentsScale):
2860
2861 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2862
2863         UNreviewed.
2864
2865         Fix for the Windows build
2866
2867         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
2868         (contentsScale):
2869         (setContentsScale):
2870
2871 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2872
2873         Unreviewed.
2874
2875         Another build fix
2876
2877         * platform/graphics/ca/GraphicsLayerCA.cpp:
2878         (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
2879         * platform/graphics/ca/mac/PlatformCALayerMac.mm:
2880         (PlatformCALayer::setContentsScale):
2881
2882 2011-01-11  Matthew Delaney  <mdelaney@apple.com>
2883
2884         Reviewed by Simon Fraser.
2885
2886         Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
2887         https://bugs.webkit.org/show_bug.cgi?id=52172
2888
2889         Tests: fast/canvas/canvas-large-dimensions.html
2890
2891         * platform/graphics/cg/ImageBufferCG.cpp:
2892         (WebCore::ImageBuffer::ImageBuffer):
2893
2894 2011-01-12  Daniel Bates  <dbates@rim.com>
2895             And Benjamin C Meyer  <bmeyer@rim.com>
2896
2897         Build fix when building with Inspector disabled
2898         https://bugs.webkit.org/show_bug.cgi?id=52313
2899
2900         After changeset 75604 <http://trac.webkit.org/changeset/75604> it's not
2901         possible to build when the Inspector is disabled.
2902
2903         * inspector/InspectorInstrumentation.h:
2904         (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): Fix build breakage when building
2905         with Inspector disabled and Offline Web Applications enabled by moving macro guard condition
2906         ENABLE(INSPECTOR) && ENABLE(OFFLINE_WEB_APPLICATIONS) into function body. This makes us also
2907         consistent with the form we use for InspectorInstrumentation::networkStateChanged() and other
2908         InspectorInstrumentation functions.
2909         * loader/appcache/ApplicationCacheGroup.cpp:
2910         (WebCore::ApplicationCacheGroup::didReceiveData): Fix build breakage when building with Inspector
2911         disabled by adding ENABLE(INSPECTOR) guard around code that references the instance variable
2912         ApplicationCacheGroup::m_currentResourceIdentifier as this variable only exists when building
2913         with the Inspector.
2914         (WebCore::ApplicationCacheGroup::didFinishLoading): Ditto.
2915         (WebCore::ApplicationCacheGroup::didFail): Ditto.
2916
2917 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2918
2919         Unreviewed.
2920
2921         Fix a build issue from http://trac.webkit.org/changeset/75639.
2922
2923         * platform/graphics/GraphicsLayer.h:
2924         (WebCore::GraphicsLayer::contentsScale):
2925         (WebCore::GraphicsLayer::setContentsScale):
2926
2927 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2928
2929         Reviewed by Kevin Decker.
2930
2931         Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
2932         rdar://problem/8824974
2933
2934         This prevents the rootLayer (with the WebKit rendered content) from going becoming
2935         a tiled layer when zoomed, and when there is other layered content on the page.
2936         This speeds up zooming a lot and avoids some buggy behavior in CA with a very large
2937         number of layers.
2938         
2939         * rendering/RenderLayer.cpp:
2940         (WebCore::RenderLayer::paintsWithTransform):
2941         * rendering/RenderLayer.h:
2942         * rendering/RenderLayerBacking.cpp:
2943         (WebCore::RenderLayerBacking::paintingGoesToWindow):
2944
2945 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2946
2947         Reviewed by Simon Fraser.
2948         
2949         Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
2950         rdar://problem/8824974
2951
2952         When scaled, WebKit renders the page content at the scaled up size, so there are no
2953         scaling artifacts. But content drawn into a layer's backing store does not scale up.
2954         This is made worse by the fact that the root page contents become layered when there
2955         are other accelerated compositing layers present (video, plugins, etc.).
2956         
2957         Plumb scaling factor from Frame::scalePage() down into all layers with content. It
2958         eventually calls CALayer::setContentsScale which renders to a backing store whose dimensions
2959         are scaled, causing them to render larger and appear pixel perfect at the scaled
2960         page size.
2961  
2962          * page/Frame.cpp:
2963          (WebCore::Frame::updateContentsScale):
2964          (WebCore::Frame::scalePage):
2965          * page/Frame.h:
2966          * platform/graphics/GraphicsLayer.h:
2967          * platform/graphics/ca/GraphicsLayerCA.cpp:
2968          (WebCore::GraphicsLayerCA::setContentsScale):
2969          (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
2970          * platform/graphics/ca/GraphicsLayerCA.h:
2971          (WebCore::GraphicsLayerCA::contentsScale):
2972          * platform/graphics/ca/PlatformCALayer.h:
2973          * platform/graphics/ca/mac/PlatformCALayerMac.mm:
2974          (PlatformCALayer::contentsScale):
2975          (PlatformCALayer::setContentsScale):
2976          * rendering/RenderLayer.cpp:
2977          (WebCore::RenderLayer::updateContentsScale):
2978          * rendering/RenderLayer.h:
2979          * rendering/RenderLayerBacking.cpp:
2980          (WebCore::RenderLayerBacking::createGraphicsLayer):
2981          (WebCore::RenderLayerBacking::updateForegroundLayer):
2982          (WebCore::RenderLayerBacking::updateMaskLayer):
2983          (WebCore::RenderLayerBacking::updateContentsScale):
2984          * rendering/RenderLayerBacking.h:
2985          * rendering/RenderLayerCompositor.cpp:
2986          (WebCore::RenderLayerCompositor::updateContentsScale):
2987          * rendering/RenderLayerCompositor.h:
2988  
2989 2011-01-12  Stephen White  <senorblanco@chromium.org>
2990
2991         Reviewed by James Robinson.
2992
2993         Fix DrawingBuffer issues for depth/stencil, extensions, etc.
2994         https://bugs.webkit.org/show_bug.cgi?id=52310
2995
2996         1)  GL_TEXTURE is not a valid argument to glFramebufferTexture2D()
2997         (should be GL_TEXTURE_2D).
2998         2)  Support for the multisampling extension was being checked after
2999         the DrawingBuffer constructor was called, which calls multisample()
3000         to check for the extension.
3001         3)  If depth or stencil is set, the corresponding framebuffers must
3002         be created in the DrawingBuffer constructor.
3003         4)  GL_DEPTH_STENCIL is not a valid framebuffer internal type in
3004         GLES2.  Must use GL_OES_DEPTH24_STENCIL8, and check for the
3005         OES_packed_depth_stencil extension.
3006
3007         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3008         (WebCore::DrawingBuffer::DrawingBuffer):
3009         Record the extension support in the constructor.  Create all the
3010         secondary drawing buffers (for multisampling, depth/stencil).
3011         * platform/graphics/gpu/DrawingBuffer.cpp:
3012         (WebCore::DrawingBuffer::create):
3013         Check for the extensions before calling the DrawingBuffer constructor.
3014         (WebCore::DrawingBuffer::createSecondaryBuffers):
3015         Refactor creation of the secondary buffers from DrawingBufferMac.mm to
3016         here.
3017         (WebCore::DrawingBuffer::reset):
3018         Use DEPTH24_STENCIL8 format, not DEPTH_STENCIL.  Use
3019         DEPTH_COMPONENT16, not DEPTH_COMPONENT.
3020         Use GL_TEXTURE_2D, not GL_TEXTURE (for glFramebufferTexture2D).
3021         * platform/graphics/gpu/DrawingBuffer.h:
3022         Refactor createSecondaryBuffers().  Add extension support arguments to
3023         constructor.  Add support for packed_depth_stencil extension.
3024         * platform/graphics/gpu/mac/DrawingBufferMac.mm:
3025         (WebCore::DrawingBuffer::DrawingBuffer):
3026         Record extension support in constructor.  Refactor out creation of
3027         secondary buffers.
3028
3029 2011-01-12  Beth Dakin  <bdakin@apple.com>
3030
3031         Reviewed by Anders Carlsson.
3032
3033         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
3034         fixed layout through WebKit SPI
3035         -and corresponding-
3036         <rdar://problem/8844464>
3037
3038         Export symbols for ScrollView::setUseFixedLayout() and 
3039         ScrollView::setFixedLayoutSize()
3040         * WebCore.exp.in:
3041
3042 2011-01-12  Robert Hogan  <robert@webkit.org>
3043
3044         Reviewed by Kenneth Rohde Christiansen.
3045
3046         [Qt] Search input field doesn't have cancel button
3047
3048         Add a cancel button to the search field and make it customizable
3049         by the client. For now, use the close dialog button associated
3050         with the application's style as the default.
3051
3052         Unskip a bunch of search field related tests that pass now:
3053
3054         fast/forms/search-cancel-button-mouseup.html
3055         fast/forms/search-rtl.html
3056         fast/forms/search-abs-pos-cancel-button.html
3057         fast/forms/search-styled.html
3058         fast/forms/search-transformed.html
3059         fast/forms/search-zoomed.html
3060         fast/forms/search-cancel-button-style-sharing.html
3061         fast/forms/search-display-none-cancel-button.html
3062         fast/forms/search-placeholder-value-changed.html
3063         fast/repaint/search-field-cancel.html
3064         fast/forms/search-cancel-button-events.html
3065
3066         https://bugs.webkit.org/show_bug.cgi?id=42887
3067
3068         * platform/graphics/qt/ImageQt.cpp:
3069         (loadResourcePixmap):
3070         * platform/qt/RenderThemeQt.cpp:
3071         (WebCore::RenderThemeQt::isControlStyled):
3072         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
3073         (WebCore::RenderThemeQt::paintSearchField):
3074         (WebCore::RenderThemeQt::adjustSearchFieldStyle):
3075         (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
3076         (WebCore::RenderThemeQt::convertToPaintingRect):
3077         (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
3078         * platform/qt/RenderThemeQt.h:
3079
3080 2011-01-12  Andrey Kosyakov  <caseq@chromium.org>
3081
3082         Reviewed by Pavel Feldman.
3083
3084         Web Inspector: cookie table is multiplied after repeated switching to cookies tab in network item view
3085         Only create cookiesTable is it hasn't been done yet.
3086         https://bugs.webkit.org/show_bug.cgi?id=52303
3087
3088         * inspector/front-end/ResourceCookiesView.js:
3089         (WebInspector.ResourceCookiesView.prototype.show):
3090
3091 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3092
3093         Reviewed by Martin Robinson.
3094
3095         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3096         https://bugs.webkit.org/show_bug.cgi?id=50867
3097
3098         * config.h: Don't disallow ctype for (OS(DARWIN) && PLATFORM(GTK))
3099         Many GTK+ related files include <libintl.h> or <glib/gi18n-lib.h>.
3100         On Mac, <libintl.h> includes <xlocale.h>. <xclocale.h> includes 
3101         <xlocale/_ctype.h>, which uses isacii().
3102         * platform/UUID.cpp:
3103         (WebCore::createCanonicalUUIDString): For OS(DARWIN) && !PLATFORM(CF)
3104         use the Chromium Linux UUID generation.
3105
3106 2011-01-12  Simon Fraser  <simon.fraser@apple.com>
3107
3108         Reviewed by Eric Seidel.
3109
3110         [CSS Gradients] One color stop should not paint anything for linear-gradient
3111         https://bugs.webkit.org/show_bug.cgi?id=52259
3112         
3113         Share color stop parsing code between linear and radial gradients.
3114         Consider the gradient invalid if it has less than two color stops.
3115
3116         * css/CSSParser.cpp:
3117         (WebCore::CSSParser::parseLinearGradient):
3118         (WebCore::CSSParser::parseRadialGradient):
3119         (WebCore::CSSParser::parseGradientColorStops):
3120         * css/CSSParser.h:
3121
3122 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3123
3124         Reviewed by Pavel Feldman.
3125
3126         Fix inconsistencies in Inspector strings found by the new check-inspector-strings script.
3127
3128         https://bugs.webkit.org/show_bug.cgi?id=52295
3129
3130         * English.lproj/localizedStrings.js:
3131         * inspector/front-end/BreakpointsSidebarPane.js:
3132         (WebInspector.EventListenerBreakpointsSidebarPane):
3133         * inspector/front-end/ProfilesPanel.js:
3134         (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
3135         * inspector/front-end/Resource.js:
3136         (WebInspector.Resource.Type.toString):
3137         * inspector/front-end/ResourcesPanel.js:
3138         (WebInspector.ResourceRevisionTreeElement):
3139         * inspector/front-end/utilities.js:
3140         ():
3141
3142 2011-01-12  Yury Semikhatsky  <yurys@chromium.org>
3143
3144         Unreviewed. Fix WML compilation on Mac.
3145
3146         * wml/WMLInputElement.cpp:
3147         (WebCore::WMLInputElement::setValue):
3148         (WebCore::WMLInputElement::setValueForUser):
3149         (WebCore::WMLInputElement::initialize):
3150         (WebCore::WMLInputElement::validateInputMask):
3151         * wml/WMLSelectElement.cpp:
3152         (WebCore::WMLSelectElement::listBoxSelectItem):
3153
3154 2011-01-12  Justin Schuh  <jschuh@chromium.org>
3155
3156         Unreviewed build fix for debug strict compiles.
3157
3158         Use fprintf for debug statements instead of fwrite, which caused compile failures
3159         in debug strict mode because of failure to check the fwrite return value.
3160
3161         No behavior changed.
3162
3163         * rendering/CounterNode.cpp:
3164         (WebCore::showTreeAndMark):
3165
3166 2010-12-29  Yury Semikhatsky  <yurys@chromium.org>
3167
3168         Reviewed by Pavel Feldman.
3169
3170         inspector/timeline-network-resource.html fails when run twice
3171         https://bugs.webkit.org/show_bug.cgi?id=37394
3172
3173         Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
3174         instead of ResourceLoader::didReceiveResponse to cover the cases when resources
3175         are loaded from memory cache.
3176
3177         Network notifications are now sent to InspectorInstrumentation which dispatches
3178         them to interested agents and InspectorController.
3179
3180         * inspector/Inspector.idl:
3181         * inspector/InspectorApplicationCacheAgent.cpp:
3182         (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
3183         * inspector/InspectorController.cpp:
3184         (WebCore::InspectorController::InspectorController):
3185         (WebCore::InspectorController::didCommitLoad):
3186         (WebCore::InspectorController::willSendRequest):
3187         (WebCore::InspectorController::didReceiveResponse):
3188         (WebCore::InspectorController::didFailLoading):
3189         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
3190         * inspector/InspectorController.h:
3191         * inspector/InspectorInstrumentation.cpp:
3192         (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
3193         (WebCore::InspectorInstrumentation::willSendRequestImpl):
3194         (WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
3195         (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
3196         (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
3197         (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
3198         (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
3199         (WebCore::InspectorInstrumentation::didFailLoadingImpl):
3200         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
3201         (WebCore::InspectorInstrumentation::scriptImportedImpl):
3202         (WebCore::InspectorInstrumentation::retrieveResourceAgent):
3203         * inspector/InspectorInstrumentation.h:
3204         (WebCore::InspectorInstrumentation::identifierForInitialRequest):
3205         (WebCore::InspectorInstrumentation::willSendRequest):
3206         (WebCore::InspectorInstrumentation::markResourceAsCached):
3207         (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
3208         (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
3209         (WebCore::InspectorInstrumentation::didReceiveContentLength):
3210         (WebCore::InspectorInstrumentation::didFinishLoading):
3211         (WebCore::InspectorInstrumentation::didFailLoading):
3212         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
3213         (WebCore::InspectorInstrumentation::scriptImported):
3214         * inspector/InspectorResourceAgent.cpp:
3215         (WebCore::InspectorResourceAgent::identifierForInitialRequest):
3216         * inspector/InspectorResourceAgent.h:
3217         * inspector/InspectorTimelineAgent.cpp:
3218         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3219         * inspector/InspectorTimelineAgent.h:
3220         * inspector/TimelineRecordFactory.cpp:
3221         (WebCore::TimelineRecordFactory::createResourceSendRequestData):
3222         * inspector/TimelineRecordFactory.h:
3223         * inspector/front-end/NetworkManager.js:
3224         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
3225         * inspector/front-end/TimelinePanel.js:
3226         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
3227         * loader/FrameLoader.cpp:
3228         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
3229         * loader/ResourceLoadNotifier.cpp:
3230         (WebCore::ResourceLoadNotifier::didReceiveResponse):
3231         (WebCore::ResourceLoadNotifier::didFailToLoad):
3232         (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
3233         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
3234         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
3235         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
3236         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
3237         (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
3238         * loader/ResourceLoader.cpp:
3239         (WebCore::ResourceLoader::didReceiveResponse):
3240         * loader/appcache/ApplicationCacheGroup.cpp:
3241         (WebCore::ApplicationCacheGroup::createResourceHandle):
3242         (WebCore::ApplicationCacheGroup::didReceiveResponse):
3243         (WebCore::ApplicationCacheGroup::didReceiveData):
3244         (WebCore::ApplicationCacheGroup::didFinishLoading):
3245         (WebCore::ApplicationCacheGroup::didFail):
3246         * loader/appcache/ApplicationCacheGroup.h:
3247         * workers/DefaultSharedWorkerRepository.cpp:
3248         (WebCore::SharedWorkerScriptLoader::notifyFinished):
3249         * workers/Worker.cpp:
3250         (WebCore::Worker::notifyFinished):
3251         * workers/WorkerContext.cpp:
3252         (WebCore::WorkerContext::importScripts):
3253         * xml/XMLHttpRequest.cpp:
3254         (WebCore::XMLHttpRequest::didFinishLoading):
3255
3256 2011-01-12  Pavel Podivilov  <podivilov@chromium.org>
3257
3258         Reviewed by Pavel Feldman.
3259
3260         Web Inspector: do not replace all tabs with spaces when editing script source
3261         https://bugs.webkit.org/show_bug.cgi?id=52291
3262
3263         * inspector/front-end/SourceFrame.js:
3264         (WebInspector.SourceFrame.prototype.setContent):
3265         (WebInspector.SourceFrame.prototype._editLine):
3266
3267 2011-01-11  Jeremy Orlow  <jorlow@chromium.org>
3268
3269         Reviewed by Nate Chapin.
3270
3271         Enforce READ_ONLY transactions in IndexedDB
3272         https://bugs.webkit.org/show_bug.cgi?id=52229
3273
3274         Add READ_ONLY_ERR and return it whenever delete or put
3275         are called.  Note that IDBCursor's delete and update
3276         are simply aliases for delete/put, which is why no
3277         extra code is required to handle those cases.
3278
3279         Test: storage/indexeddb/transaction-read-only.html
3280
3281         * dom/ExceptionCode.cpp:
3282         * storage/IDBCursorBackendImpl.cpp:
3283         (WebCore::IDBCursorBackendImpl::deleteFunction):
3284         * storage/IDBDatabase.idl:
3285         * storage/IDBDatabaseException.h:
3286         * storage/IDBDatabaseException.idl:
3287         * storage/IDBObjectStoreBackendImpl.cpp:
3288         (WebCore::IDBObjectStoreBackendImpl::put):
3289         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
3290         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
3291
3292 2011-01-11  Philippe Normand  <pnormand@igalia.com>
3293
3294         Reviewed by Eric Seidel.
3295
3296         [GTK] minimal build breaks in RenderThemeGtk3
3297         https://bugs.webkit.org/show_bug.cgi?id=52202
3298
3299         * platform/gtk/RenderThemeGtk3.cpp: Added VIDEO guards around
3300         initMediaColors().
3301
3302 2011-01-11  Philippe Normand  <pnormand@igalia.com>
3303
3304         Reviewed by Eric Carlson.
3305
3306         [GStreamer] PlatformVideoWindowMac implementation
3307         https://bugs.webkit.org/show_bug.cgi?id=50770
3308
3309         This new implementation will be used on Mac OS to display the
3310         fullscreen video window with the GStreamer-based media player.
3311
3312         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
3313         (WebCore::gstGWorldSyncMessageCallback):
3314         * platform/graphics/gstreamer/PlatformVideoWindow.h:
3315         (WebCore::PlatformVideoWindow::window):
3316         * platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
3317         (PlatformVideoWindow::PlatformVideoWindow):
3318         (PlatformVideoWindow::~PlatformVideoWindow):
3319         (PlatformVideoWindow::prepareForOverlay):
3320
3321 2011-01-11  Simon Fraser  <simon.fraser@apple.com>
3322
3323         Reviewed by Dan Bernstein.
3324
3325         Webkit crashes when a gradient is applied using the first-line pseudo element
3326         https://bugs.webkit.org/show_bug.cgi?id=52225
3327         
3328         When a pseudostyle references images, we fail to register/unregister
3329         the relevant RenderObjects as clients of the image in the style.
3330         For gradients, this caused a crash.
3331         
3332         This patch fixes the crash by returning a null gradient image in this
3333         situation.
3334
3335         Test: fast/gradients/gradient-on-pseudoelement-crash.html
3336
3337         * css/CSSGradientValue.cpp:
3338         (WebCore::CSSGradientValue::image):
3339
3340 2011-01-11  Andy Estes  <aestes@apple.com>
3341
3342         Reviewed by Darin Adler.
3343
3344         REGRESSION (r71562): servePendingRequests() no longer called when
3345         resources are done loading.
3346         https://bugs.webkit.org/show_bug.cgi?id=52264
3347         <rdar://problem/8767429>
3348         
3349         In r71562, servePendingRequests() is no longer called in Loader's
3350         didFinishLoading(), didFail() and didReceiveResponse() methods. Since
3351         r71562 was intended only as a refactoring, these calls should be
3352         restored. At least one WebKit-based Mac OS X application relies on this
3353         for correct behavior.
3354
3355         * loader/cache/CachedResourceLoader.cpp:
3356         (WebCore::CachedResourceLoader::loadDone): Call
3357         resourceLoadScheduler()->servePendingRequests().
3358
3359 2011-01-11  Patrick Gansterer  <paroga@webkit.org>
3360
3361         Reviewed by Eric Seidel.
3362
3363         Add Document::setContent()
3364         https://bugs.webkit.org/show_bug.cgi?id=52085
3365
3366         Add a method to Document to set the whole content at once.
3367         This removes the hack of the insert method in the xml parser
3368         and is a predecessor to feed the xml parser with raw data.
3369
3370         * dom/Document.cpp:
3371         (WebCore::Document::setContent):
3372         * dom/Document.h:
3373         * dom/XMLDocumentParser.cpp:
3374         (WebCore::XMLDocumentParser::insert): Added ASSERT_NOT_REACHED().
3375         * loader/cache/CachedFont.cpp:
3376         (WebCore::CachedFont::ensureSVGFontData): Use setContent.
3377         * xml/DOMParser.cpp:
3378         (WebCore::DOMParser::parseFromString): Ditto.
3379         * xml/XMLHttpRequest.cpp:
3380         (WebCore::XMLHttpRequest::responseXML): Ditto.
3381         * xml/XSLTProcessor.cpp:
3382         (WebCore::XSLTProcessor::createDocumentFromSource): Ditto.
3383
3384 2011-01-11  Brent Fulgham  <bfulgham@webkit.org>
3385
3386         Unreviewed build fix.
3387
3388         * platform/graphics/cairo/PathCairo.cpp:
3389         (WebCore::Path::addArc): Switch to MathExtra's piFloat define,
3390         rather than M_PI which is not always available.
3391
3392 2011-01-11  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3393
3394         Reviewed by Adam Barth.
3395
3396         Use plug-in DB for extensions to MIME type convertion
3397
3398         Plugins extension to MIME type conversion was not used in the
3399         frameLoader. This was causing some fallback to be use which as the side
3400         effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
3401         This patch ensure that we try to convert the extension to MIME type
3402         using the plugin database beofre using this fallback.
3403
3404         Attribute lost with Flash plugin without mime type set
3405         https://bugs.webkit.org/show_bug.cgi?id=50657
3406
3407         Test: plugins/no-mime-with-valid-extension.html
3408
3409         * loader/FrameLoader.cpp:
3410         (WebCore::FrameLoader::defaultObjectContentType): Use PluginDatabase for MIME
3411
3412 2011-01-11  James Simonsen  <simonjam@chromium.org>
3413
3414         Reviewed by Eric Seidel.
3415
3416         [Web Timing] Rename sslHandshakeStart to secureConnectionStart
3417         https://bugs.webkit.org/show_bug.cgi?id=52239
3418
3419         * page/PerformanceTiming.cpp:
3420         (WebCore::PerformanceTiming::secureConnectionStart):
3421         * page/PerformanceTiming.h:
3422         * page/PerformanceTiming.idl:
3423
3424 2011-01-11  Adam Barth  <abarth@webkit.org>
3425
3426         Reviewed by Eric Seidel.
3427
3428         Introduce the notion of a "display-isolated" URL scheme for use by
3429         Chrome-internal URLs
3430         https://bugs.webkit.org/show_bug.cgi?id=50182
3431
3432         This patch actually makes the display-isolated schemes display
3433         isolated.  The behavior should be the same as the previous iteration of
3434         this patch, but re-organized a bit because reading the access white
3435         list is expensive.
3436
3437         * page/SecurityOrigin.cpp:
3438         (WebCore::SecurityOrigin::isAccessToURLWhiteListed):
3439         (WebCore::SecurityOrigin::canDisplay):
3440         * page/SecurityOrigin.h:
3441         * platform/SchemeRegistry.cpp:
3442         * platform/SchemeRegistry.h:
3443
3444 2011-01-11  Mihai Parparita  <mihaip@chromium.org>
3445
3446         Reviewed by Darin Fisher.
3447
3448         Scroll event should be fired asynchronously
3449         https://bugs.webkit.org/show_bug.cgi?id=45631
3450
3451         Tests: fast/events/fire-scroll-event.html
3452                fast/events/fire-scroll-event-element.html
3453                fast/events/scroll-event-phase.html
3454
3455         Makes scroll events fire asynchronously to be in compliance with the
3456         CSSOM View Module and consistent with Gecko, Opera and (to some degree)
3457         IE.
3458         
3459         Implemented via the EventQueue class added by r74062 (EventQueue now
3460         has a convenience enqueueScrollEvent method).
3461
3462         * dom/EventQueue.cpp:
3463         (WebCore::EventQueue::enqueueScrollEvent):
3464         (WebCore::EventQueue::pendingEventTimerFired):
3465         * dom/EventQueue.h:
3466         * page/EventHandler.cpp:
3467         (WebCore::EventHandler::sendScrollEvent):
3468         * rendering/RenderLayer.cpp:
3469         (WebCore::RenderLayer::scrollToOffset):
3470         * rendering/RenderListB