1 2011-03-02 Daniel Cheng <dcheng@chromium.org>
3 Reviewed by David Levin.
5 Add feature define for data transfer items
6 https://bugs.webkit.org/show_bug.cgi?id=55510
8 * Configurations/FeatureDefines.xcconfig:
12 2011-03-02 Dimitri Glazkov <dglazkov@chromium.org>
14 Update location of media-file.js, which was moved in r79630.
16 * manual-tests/media-controls.html: Updated location.
18 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
20 Unreviewed, rolling out r80156.
21 http://trac.webkit.org/changeset/80156
22 https://bugs.webkit.org/show_bug.cgi?id=55604
24 "Broke SL compile" (Requested by tonyg-cr on #webkit).
26 * bridge/jni/JNIBridge.h:
27 (JSC::Bindings::JavaString::operator UString):
28 * bridge/jni/jni_jsobject.mm:
31 (JavaJSObject::getMember):
32 (JavaJSObject::setMember):
33 (JavaJSObject::removeMember):
34 * bridge/jni/jsc/JavaClassJSC.cpp:
35 (JavaClass::JavaClass):
36 * bridge/jni/jsc/JavaStringJSC.h:
37 (JSC::Bindings::JavaStringImpl::uString):
38 * bridge/jni/v8/JavaStringV8.h:
40 2011-03-02 Steve Block <steveblock@google.com>
42 Reviewed by Jeremy Orlow.
44 JavaString API should be implementable by both JSC and V8
45 https://bugs.webkit.org/show_bug.cgi?id=55567
47 Remove JavaString's UString operator and replace it with a
48 script-engine-independent impl() method, which returns a
49 StringImpl and can be implemented with both JSC and V8.
51 No new tests, refactoring only.
53 * bridge/jni/JNIBridge.h:
54 (JSC::Bindings::JavaString::impl):
55 * bridge/jni/jni_jsobject.mm:
58 (JavaJSObject::getMember):
59 (JavaJSObject::setMember):
60 (JavaJSObject::removeMember):
61 * bridge/jni/jsc/JavaClassJSC.cpp:
62 (JavaClass::JavaClass):
63 * bridge/jni/jsc/JavaStringJSC.h:
64 (JSC::Bindings::JavaStringImpl::impl):
65 * bridge/jni/v8/JavaStringV8.h:
66 (JSC::Bindings::JavaStringImpl::impl):
68 2011-03-02 Mihai Parparita <mihaip@chromium.org>
70 Reviewed by Dimitri Glazkov.
72 Add CRASH() for CSSSelector double frees
73 https://bugs.webkit.org/show_bug.cgi?id=55596
75 To help track down bug 53045, add a CRASH call when the CSSSelector
76 destructor is invoked more than once.
78 Just a check, no new tests necessary.
81 (WebCore::CSSSelector::CSSSelector):
82 (WebCore::CSSSelector::~CSSSelector):
84 2011-03-02 Carol Szabo <carol.szabo@nokia.com>
86 Reviewed by David Hyatt <hyatt@apple.com>
88 content property doesn't support quotes
89 https://bugs.webkit.org/show_bug.cgi?id=6503
91 Added full support for quotes as defined by CSS 2.1.
93 Tests: fast/css/content/content-quotes-01.html
94 fast/css/content/content-quotes-02.html
95 fast/css/content/content-quotes-03.html
96 fast/css/content/content-quotes-04.html
97 fast/css/content/content-quotes-05.html
98 fast/css/content/content-quotes-06.html
105 * WebCore.vcproj/WebCore.vcproj:
106 * WebCore.xcodeproj/project.pbxproj:
107 Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
109 (WebCore::CSSParser::parseValue):
110 (WebCore::CSSParser::parseQuotes):
112 Added needed stylesheet parsing support for quotes,
113 (no-)open-quote and (no-)close-quote
114 * css/CSSStyleSelector.cpp:
115 (WebCore::CSSStyleSelector::applyProperty):
116 Handled setting of the new quotes RenderStyle property and added
117 handling of quotes for the content property.
121 replaced the '"' workaround with open/close-quote
122 * rendering/RenderBlockLineLayout.cpp:
123 (WebCore::dirtyLineBoxesForRenderer):
124 Made RenderQuote behave like RenderCounter.
125 Needed to ensure that the Quote text is calculated before layout,
126 just as it is for RenderCounter.
127 * rendering/RenderObject.h:
128 (WebCore::RenderObject::isQuote):
129 * rendering/RenderObjectChildList.cpp:
130 (WebCore::RenderObjectChildList::removeChildNode):
131 (WebCore::RenderObjectChildList::appendChildNode):
132 (WebCore::RenderObjectChildList::insertChildNode):
133 Handled updating of quote depth when renderers are added and removed
135 (WebCore::RenderObjectChildList::updateBeforeAfterContent):
136 Added support for Quote content.
137 * rendering/RenderQuote.cpp: Added.
138 (WebCore::adjustDepth):
139 (WebCore::RenderQuote::RenderQuote):
140 (WebCore::RenderQuote::~RenderQuote):
141 (WebCore::RenderQuote::renderName):
142 (WebCore::RenderQuote::placeQuote):
143 (WebCore::LanguageData::operator<):
144 (WebCore::defaultLanguageQuotes):
145 (WebCore::quotesMap):
146 (WebCore::quotesForLanguage):
147 (WebCore::defaultQuotes):
148 (WebCore::RenderQuote::originalText):
149 (WebCore::RenderQuote::computePreferredLogicalWidths):
150 (WebCore::RenderQuote::rendererSubtreeAttached):
151 (WebCore::RenderQuote::rendererRemovedFromTree):
152 (WebCore::RenderQuote::styleDidChange):
153 * rendering/RenderQuote.h: Added.
154 (WebCore::RenderQuote::isQuote):
155 (WebCore::toRenderQuote):
156 * rendering/RenderingAllInOne.cpp:
157 Included RenderQuote.cpp
158 * rendering/style/StyleAllInOne.cpp:
159 Included QuotesData.cpp
160 * rendering/style/ContentData.cpp:
161 (WebCore::ContentData::dataEquivalent):
162 Checked for quotetype identity.
163 (WebCore::ContentData::deleteContent):
164 Accounted for the new QUOTE_TYPE.
165 * rendering/style/ContentData.h:
166 (WebCore::ContentData::isQuote):
167 (WebCore::ContentData::quote):
168 (WebCore::ContentData::setQuote):
169 * rendering/style/QuotesData.cpp: Added.
170 (WebCore::QuotesData::create):
171 (WebCore::QuotesData::operator==):
172 (WebCore::QuotesData::~QuotesData):
173 * rendering/style/QuotesData.h: Added.
174 (WebCore::QuotesData::data):
175 (WebCore::QuotesData::operator delete):
176 (WebCore::QuotesData::QuotesData):
177 * rendering/style/RenderStyle.cpp:
178 (WebCore::RenderStyle::setContent):
179 (WebCore::RenderStyle::setQuotes):
180 * rendering/style/RenderStyle.h:
181 (WebCore::InheritedFlags::quotes):
182 (WebCore::InheritedFlags::setQuotes):
183 * rendering/style/RenderStyleConstants.h:
184 * rendering/style/StyleAllInOne.cpp:
185 Added QuotesData.cpp to the included files list.
186 * rendering/style/StyleRareInheritedData.cpp:
187 (WebCore::StyleRareInheritedData::operator==):
188 Included quotes in equality check.
189 * rendering/style/StyleRareInheritedData.h:
192 2011-03-02 Antti Koivisto <antti@apple.com>
194 Reviewed by Dave Hyatt.
196 Selector usage flags should not be set by the CSS parser
197 https://bugs.webkit.org/show_bug.cgi?id=55573
199 Currently flags like Document::usesSiblingRules() are set directly by the CSS parser. This is wrong as
200 we may parse stylesheets that are not actually used for document rendering. This is especially bad when
201 the page uses querySelectorAll(). As a result we may end up in various performance penalty boxes
202 triggered by complex selectors for no good reason.
204 - Use the selector traversal in style selector constructor to figure out which flags
205 are actually needed for the currently active style sheets.
206 - Remove the selector flag related code from the CSS parser/grammar.
207 - Remove the usesDescendantRules flag completely. We have descendant rules in the default
208 style sheet, every document uses them.
212 (WebCore::CSSParser::updateSpecifiersWithElementName):
213 * css/CSSStyleSelector.cpp:
214 (WebCore::collectSiblingRulesInDefaultStyle):
215 (WebCore::CSSStyleSelector::CSSStyleSelector):
216 (WebCore::CSSStyleSelector::Features::Features):
217 (WebCore::CSSStyleSelector::Features::~Features):
218 (WebCore::CSSStyleSelector::locateCousinList):
219 (WebCore::CSSStyleSelector::matchesSiblingRules):
220 (WebCore::CSSStyleSelector::canShareStyleWithElement):
221 (WebCore::CSSStyleSelector::locateSharedStyle):
222 (WebCore::collectFeaturesFromSelector):
223 (WebCore::collectFeaturesFromList):
224 (WebCore::RuleSet::collectFeatures):
225 * css/CSSStyleSelector.h:
226 (WebCore::CSSStyleSelector::usesSiblingRules):
227 (WebCore::CSSStyleSelector::usesFirstLineRules):
228 (WebCore::CSSStyleSelector::usesBeforeAfterRules):
229 (WebCore::CSSStyleSelector::usesLinkRules):
231 (WebCore::Document::Document):
232 (WebCore::Document::recalcStyle):
233 (WebCore::Document::createStyleSelector):
235 (WebCore::Document::usesSiblingRules):
236 (WebCore::Document::setUsesSiblingRules):
237 (WebCore::Document::usesFirstLineRules):
238 (WebCore::Document::usesBeforeAfterRules):
239 (WebCore::Document::setUsesBeforeAfterRules):
241 (WebCore::Element::recalcStyle):
243 2011-03-02 Brian Weinstein <bweinstein@apple.com>
245 Fix fallout from a last minute renaming.
247 * platform/network/cf/CookieStorageCFNet.cpp:
248 (WebCore::startObservingCookieChanges):
249 (WebCore::stopObservingCookieChanges):
251 2011-03-01 Brian Weinstein <bweinstein@apple.com>
253 Reviewed by Adam Roben.
255 Part of WebKit2: Need a way to send notifications to client when cookies change
256 https://bugs.webkit.org/show_bug.cgi?id=55427
257 <rdar://problem/9056027>
259 Add functions on CookieStorage that allow listening for changes in cookies. When
260 the cookies are changed, they call through to CookiesStrategy::notifyCookiesChanged.
262 No change in behavior requiring tests.
264 * platform/CookiesStrategy.h: Added.
265 (WebCore::CookiesStrategy::~CookiesStrategy):
267 * platform/PlatformStrategies.h:
268 (WebCore::PlatformStrategies::cookiesStrategy):
269 (WebCore::PlatformStrategies::PlatformStrategies):
271 * platform/network/CookieStorage.h: Add new function declarations.
273 * platform/network/cf/CookieStorageCFNet.cpp:
274 (WebCore::notifyCookiesChangedOnMainThread): Call through to CookiesStrategy::notifyCookiesChanged.
275 (WebCore::notifyCookiesChanged): Call notifyCookiesChangedOnMainThread on the main thread.
276 (WebCore::beginObservingCookieChanges): Set up cookie observers on the loader run loop.
277 (WebCore::finishObservingCookieChanges): Remove our cookie observers from the loader run loop.
279 * platform/network/mac/CookieStorageMac.mm:
280 (-[CookieStorageObjCAdapter notifyCookiesChangedOnMainThread]): Call through to CookiesStrategy::notifyCookiesChanged.
281 (-[CookieStorageObjCAdapter cookiesChangedNotificationHandler:]): Call notifyCookiesChangedOnMainThread on
283 (-[CookieStorageObjCAdapter registerForCookieChangeNotifications]): Set up the observer for cookie change notifications.
284 (-[CookieStorageObjCAdapter unregisterForCookieChangeNotifications]): Remove the observer for cookie change notifications.
285 (WebCore::beginObservingCookieChanges): Create our CookieStorageObjCAdapter, and call registerForCookieChangeNotifications.
286 (WebCore::finishObservingCookieChanges): Call unregisterForCookieChangeNotifications.
289 * WebCore.vcproj/WebCore.vcproj:
290 * WebCore.xcodeproj/project.pbxproj: Set role on files we need to include in WebKit to private.
292 2011-03-02 Sergey Glazunov <serg.glazunov@gmail.com>
294 Reviewed by Dimitri Glazkov.
296 A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
297 https://bugs.webkit.org/show_bug.cgi?id=55488
299 Test: fast/css/css-keyframe-parent.html
301 * css/WebKitCSSKeyframesRule.cpp:
302 (WebCore::WebKitCSSKeyframesRule::append):
304 2011-03-02 Sergio Villar Senin <svillar@igalia.com>
306 Reviewed by Martin Robinson.
308 [GTK] Add support for external protocol handlers
309 https://bugs.webkit.org/show_bug.cgi?id=55473
311 Do not unconditionally create and replace the SoupRequester of the
312 SoupSession if there is already one. No new tests needed as we
313 just allow clients to create their our SoupRequesters.
315 * platform/network/soup/ResourceHandleSoup.cpp:
316 (WebCore::ensureSessionIsInitialized):
318 2011-03-02 John Knottenbelt <jknotten@chromium.org>
320 Reviewed by jknotten@chromium.org.
322 Fix build-breakage when GEOLOCATION not enabled.
323 https://bugs.webkit.org/show_bug.cgi?id=55586
325 Geolocation::reset needs to be defined if ENABLE(GEOLOCATION)
328 * page/Geolocation.cpp:
329 (WebCore::Geolocation::reset):
331 2011-03-02 Pavel Feldman <pfeldman@chromium.org>
333 Reviewed by Yury Semikhatsky.
335 Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
336 https://bugs.webkit.org/show_bug.cgi?id=55575
338 * bindings/js/JSInjectedScriptHostCustom.cpp:
339 (WebCore::JSInjectedScriptHost::inspectedNode):
340 * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
341 (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
342 * inspector/ConsoleMessage.cpp:
343 (WebCore::ConsoleMessage::addToFrontend):
344 * inspector/InjectedScript.cpp:
345 (WebCore::InjectedScript::evaluateOn):
346 (WebCore::InjectedScript::wrapObject):
347 (WebCore::InjectedScript::wrapNode):
348 (WebCore::InjectedScript::inspectNode):
349 (WebCore::InjectedScript::nodeAsScriptValue):
350 * inspector/InjectedScript.h:
351 * inspector/InjectedScriptHost.cpp:
352 (WebCore::InjectedScriptHost::addInspectedNode):
353 (WebCore::InjectedScriptHost::clearInspectedNodes):
354 (WebCore::InjectedScriptHost::copyText):
355 (WebCore::InjectedScriptHost::inspectedNode):
356 * inspector/InjectedScriptHost.h:
357 * inspector/InjectedScriptHost.idl:
358 * inspector/InjectedScriptSource.js:
359 * inspector/Inspector.idl:
360 * inspector/InspectorDOMAgent.cpp:
361 (WebCore::InspectorDOMAgent::discardBindings):
362 (WebCore::InspectorDOMAgent::addInspectedNode):
363 (WebCore::InspectorDOMAgent::resolveNode):
364 (WebCore::InspectorDOMAgent::injectedScriptForNode):
365 * inspector/InspectorDOMAgent.h:
366 * inspector/InspectorRuntimeAgent.cpp:
367 (WebCore::InspectorRuntimeAgent::evaluateOn):
368 * inspector/InspectorRuntimeAgent.h:
369 * inspector/front-end/ElementsTreeOutline.js:
370 (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
371 (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
372 (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
373 * inspector/front-end/PropertiesSidebarPane.js:
374 (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
375 (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
376 (WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
377 (WebInspector.PropertiesSidebarPane.prototype.update):
378 * inspector/front-end/RemoteObject.js:
379 (WebInspector.RemoteObject.resolveNode):
380 (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
381 (WebInspector.RemoteObject.prototype.evaluate):
383 2011-01-21 John Knottenbelt <jknotten@chromium.org>
385 Reviewed by Dmitry Titov.
387 Detach Geolocation from Frame when Page destroyed.
388 https://bugs.webkit.org/show_bug.cgi?id=52877
390 On Page destruction, any outstanding Geolocation permission
391 requests should be cancelled, because the Geolocation can only
392 access the client indirectly via m_frame->page().
394 Additionally, if the Frame is reparented to another page, the
395 Geolocation should cancel watches, single-shots and requests on
398 Page destruction is signalled by a call to the
399 Frame::pageDestroyed() method. This calls Frame::detachFromPage,
400 where we extend the call chain to Geolocation::detachFromPage()
401 where we call Geolocation::reset() which detaches from the
402 GeolocationController, cancels requests, watches and single shots,
403 and sets the permission state back to Unknown.
405 We also now call detachFromPage when the frame reparented in
406 Frame::transferChildFrameToNewDocument.
408 Frame::pageDestroyed() is also called by FrameLoader even though
409 the page is not destroyed. We should still cancel permission
410 requests, because the GeolocationClient will become inaccessible
411 to the Geolocation object after this call.
413 Since GeolocationController is owned by Page, and all Geolocation
414 objects will now unsubscribe from the GeolocationController on
415 pageDetached(), we no longer need to call stopUpdating() from the
416 GeolocationController's destructor. Instead we can simply assert
417 that there should be no no observers. See related bug
418 https://bugs.webkit.org/show_bug.cgi?id=52216 .
420 Introduced new method 'numberOfPendingPermissionRequests' on
421 GeolocationClientMock to count the number of outstanding pending
422 permission requests. This provides a reusable implementation for
423 client-based implementations of the LayoutTestController's
424 numberOfPendingGeolocationPermissionRequests method.
426 Tests: fast/dom/Geolocation/iframe-reparent.html
427 fast/dom/Geolocation/page-reload-cancel-permission-requests.html
429 * page/DOMWindow.cpp:
430 (WebCore::DOMWindow::resetGeolocationPermissions):
433 (WebCore::Frame::detachFromPage):
434 (WebCore::Frame::pageDestroyed):
435 (WebCore::Frame::transferChildFrameToNewDocument):
437 * page/Geolocation.cpp:
438 (WebCore::Geolocation::~Geolocation):
439 (WebCore::Geolocation::page):
440 (WebCore::Geolocation::reset):
441 (WebCore::Geolocation::disconnectFrame):
442 (WebCore::Geolocation::lastPosition):
443 (WebCore::Geolocation::requestPermission):
444 (WebCore::Geolocation::startUpdating):
445 (WebCore::Geolocation::stopUpdating):
446 * page/Geolocation.h:
447 * page/GeolocationController.cpp:
448 (WebCore::GeolocationController::~GeolocationController):
449 * page/Navigator.cpp:
450 (WebCore::Navigator::resetGeolocationPermissions):
452 * platform/mock/GeolocationClientMock.cpp:
453 (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
454 * platform/mock/GeolocationClientMock.h:
456 2011-03-02 Mikhail Naganov <mnaganov@chromium.org>
458 Reviewed by Pavel Feldman.
460 Web Inspector: [Chromium] Landing detailed heap snapshots, part 4.
461 https://bugs.webkit.org/show_bug.cgi?id=55563
463 This part adds implementations for data grids used to display
464 different heap snapshots projections. We are almost done.
466 * English.lproj/localizedStrings.js:
468 * bindings/v8/ScriptHeapSnapshot.cpp:
469 (WebCore::ScriptHeapSnapshot::getExactRetainedSize):
470 * bindings/v8/ScriptHeapSnapshot.h:
471 * inspector/Inspector.idl:
472 * inspector/InspectorProfilerAgent.cpp:
473 (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
474 * inspector/InspectorProfilerAgent.h:
475 * inspector/front-end/DetailedHeapshotGridNodes.js:
476 (WebInspector.HeapSnapshotObjectNode):
477 (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
478 (WebInspector.HeapSnapshotInstanceNode):
479 (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
480 (WebInspector.HeapSnapshotDominatorObjectNode):
481 (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
482 (MixInSnapshotNodeFunctions):
483 * inspector/front-end/DetailedHeapshotView.js:
484 (WebInspector.HeapSnapshotContainmentDataGrid):
485 (WebInspector.HeapSnapshotSortableDataGrid):
486 (WebInspector.HeapSnapshotConstructorsDataGrid):
487 (WebInspector.HeapSnapshotDiffDataGrid):
488 (WebInspector.HeapSnapshotDominatorsDataGrid):
489 (WebInspector.HeapSnapshotRetainingPathsList):
490 (WebInspector.DetailedHeapshotView.profileCallback):
491 (WebInspector.DetailedHeapshotView):
492 * inspector/front-end/HeapSnapshot.js:
493 (WebInspector.HeapSnapshotEdge.prototype.get isInvisible):
494 (WebInspector.HeapSnapshotEdge.prototype.toString):
495 (WebInspector.HeapSnapshot.prototype._init):
496 (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
497 (WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
498 (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
499 * inspector/front-end/Images/helpButtonGlyph.png: Added.
500 * inspector/front-end/Panel.js:
501 (WebInspector.Panel.prototype.reset):
502 * inspector/front-end/Popover.js:
503 (WebInspector.Popover):
504 (WebInspector.Popover.prototype.show):
505 (WebInspector.Popover.prototype.hide):
506 (WebInspector.Popover.prototype.get visible):
507 * inspector/front-end/ProfilesPanel.js:
508 (WebInspector.ProfilesPanel.prototype._reset):
509 (WebInspector.ProfilesPanel.prototype.getProfile):
510 * inspector/front-end/heapProfiler.css:
511 * inspector/front-end/inspector.js:
512 (WebInspector.resetFocusElement):
514 2011-03-02 David Kilzer <ddkilzer@apple.com>
516 <http://webkit.org/b/55534> Clean up macros in Extensions3DOpenGL.cpp
518 Reviewed by Darin Adler.
520 Change "#if GL_APPLE_vertex_array_object" macros to check that
521 GL_APPLE_vertex_array_object is both defined and non-zero.
523 * platform/graphics/opengl/Extensions3DOpenGL.cpp:
524 (WebCore::Extensions3DOpenGL::createVertexArrayOES):
525 (WebCore::Extensions3DOpenGL::deleteVertexArrayOES): Remove
527 (WebCore::Extensions3DOpenGL::isVertexArrayOES):
528 (WebCore::Extensions3DOpenGL::bindVertexArrayOES): Add early
529 return check. Remove #else clause that would never have
530 compiled (since array is not a WTF::String).
532 2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
534 Reviewed by Darin Adler.
536 Assertion failure after removing a selection in keydown handler
537 https://bugs.webkit.org/show_bug.cgi?id=51389
539 The bug was caused by textWillBeReplaced's not always updating selection, and
540 shouldRemovePositionAfterAdoptingTextReplacement's not moving the end offset when it's
541 at the end of replaced data.
543 Fixed the bug by always updating selection in textWillBeReplaced and fixing the condition
544 to move the offset in shouldRemovePositionAfterAdoptingTextReplacement. Also added a call
545 to setSelection instead of directly modifying m_selection to notify all the clients.
546 Namely, the call to EditorClient::respondToChangedSelection is required for
547 setting-input-value-cancel-ime-composition.html.
549 Note that we must update layout before calling setSelection because setSelection calls
550 setFocusedNodeIfNeeded and it requires layout to be up-to-date. Without this call, tests
551 such as fast/forms/input-appearance-maxlength.html hits an assertion in Node::isFocusable.
553 Test: editing/input/setting-input-value-cancel-ime-composition.html
555 * editing/SelectionController.cpp:
556 (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): When replacing text, the offset
557 of the selection end must be updated even if it was at the end of the replaced text.
558 e.g. removing "world" from "hello world] WebKit" should result in "hello ] WebKit" not
559 "hello WebK[it". Note we don't move the offset if no text is removed because appending
560 "world" to "hello ]" should result in "hello ]world" not "hello world]".
561 (WebCore::SelectionController::textWillBeReplaced): Calls setSelection to update
562 the selection instead of modifying m_selection directly.
564 2011-03-02 Andrey Adaikin <aandrey@google.com>
566 Reviewed by Pavel Feldman.
568 Web Inspector: highlighted line does not span horizonally in scripts panel while debugging.
569 https://bugs.webkit.org/show_bug.cgi?id=54675
571 * inspector/front-end/TextViewer.js:
572 (WebInspector.TextViewer.prototype._syncScroll):
573 (WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
574 (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
575 (WebInspector.TextEditorGutterPanel):
576 (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
577 (WebInspector.TextEditorGutterPanel.prototype.textChanged):
578 (WebInspector.TextEditorMainPanel):
579 (WebInspector.TextEditorMainPanel.prototype.set readOnly):
580 (WebInspector.TextEditorMainPanel.prototype._getSelection):
581 (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
582 (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
583 (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
584 (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
585 * inspector/front-end/textViewer.css:
588 2011-03-02 Oleg Romashin <romaxa@gmail.com>
590 Reviewed by Andreas Kling.
592 Fixing inspector compilation with JAVASCRIPT_DEBUGGER disabled
593 https://bugs.webkit.org/show_bug.cgi?id=55477
595 * inspector/InspectorAgent.cpp:
596 (WebCore::InspectorAgent::populateScriptObjects):
598 2011-03-02 Kent Tamura <tkent@chromium.org>
600 Unreviewed, a trivial fix for r80096.
602 REGRESSION (r80096): [Chromium] fast/forms/input-number-unacceptable-style.html failure
603 https://bugs.webkit.org/show_bug.cgi?id=55562
605 * platform/text/LocalizedNumberICU.cpp:
606 (WebCore::parseLocalizedNumber): Check the ParsePosition after NumberFormat::parse()
607 to reject strings with a valid number + extra letters.
609 2011-03-02 Steve Block <steveblock@google.com>
611 Reviewed by Jeremy Orlow.
613 JObjectWrapper should be moved to its own file
614 https://bugs.webkit.org/show_bug.cgi?id=55384
616 No new tests, refactoring only.
618 * Android.v8bindings.mk:
620 * bridge/jni/v8/JNIBridgeV8.cpp:
621 (JavaField::JavaField):
622 * bridge/jni/v8/JNIBridgeV8.h:
623 * bridge/jni/v8/JavaInstanceV8.cpp:
624 (JavaInstance::JavaInstance):
625 * bridge/jni/v8/JavaInstanceV8.h:
626 * bridge/jni/v8/JobjectWrapper.cpp: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
627 (JobjectWrapper::JobjectWrapper):
628 (JobjectWrapper::~JobjectWrapper):
629 * bridge/jni/v8/JobjectWrapper.h: Copied from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
630 (JSC::Bindings::JobjectWrapper::instance):
631 (JSC::Bindings::JobjectWrapper::setInstance):
632 (JSC::Bindings::JobjectWrapper::ref):
633 (JSC::Bindings::JobjectWrapper::deref):
635 2011-02-25 Andrey Kosyakov <caseq@chromium.org>
637 Reviewed by Pavel Feldman.
639 Web Inspector: factor search logic out of inspector.js
640 https://bugs.webkit.org/show_bug.cgi?id=54965
643 * WebCore.vcproj/WebCore.vcproj:
644 * inspector/front-end/ElementsPanel.js:
645 (WebInspector.ElementsPanel.prototype.searchCanceled):
646 (WebInspector.ElementsPanel.prototype.switchToAndFocus):
647 (WebInspector.ElementsPanel.prototype._updateMatchesCount):
648 * inspector/front-end/Panel.js:
649 (WebInspector.Panel.prototype.searchCanceled):
650 (WebInspector.Panel.prototype.performSearch.updateMatchesCount):
651 * inspector/front-end/ScriptsPanel.js:
652 (WebInspector.ScriptsPanel.prototype.searchCanceled):
653 (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
654 (WebInspector.ScriptsPanel.prototype.performSearch):
655 * inspector/front-end/SearchController.js: Added.
656 (WebInspector.SearchController):
657 (WebInspector.SearchController.prototype.updateSearchMatchesCount):
658 (WebInspector.SearchController.prototype.updateSearchLabel):
659 (WebInspector.SearchController.prototype.cancelSearch):
660 (WebInspector.SearchController.prototype.handleShortcut):
661 (WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
662 (WebInspector.SearchController.prototype.activePanelChanged):
663 (WebInspector.SearchController.prototype._updateSearchMatchesCount):
664 (WebInspector.SearchController.prototype._focusSearchField):
665 (WebInspector.SearchController.prototype._onSearchFieldManualFocus):
666 (WebInspector.SearchController.prototype._onKeyDown):
667 (WebInspector.SearchController.prototype._onSearch):
668 (WebInspector.SearchController.prototype._performSearch):
669 * inspector/front-end/WebKit.qrc:
670 * inspector/front-end/inspector.html:
671 * inspector/front-end/inspector.js:
672 (WebInspector.set currentPanel):
673 (WebInspector.set attached):
674 (WebInspector.doLoadedDone):
675 (WebInspector.documentKeyDown):
677 2011-03-02 Renata Hodovan <reni@webkit.org>
679 Reviewed by Andreas Kling.
681 FEMorphologyElement changes doesn't require relayout
682 https://bugs.webkit.org/show_bug.cgi?id=55462
684 When the FEMorphologyElement receives an update message but the given value remains the same we don't need
685 to relayout the filter.
687 No new tests are needed because this modification is covered by the dynamic update tests of FEMorphology.
689 * platform/graphics/filters/FEMorphology.cpp:
690 (WebCore::FEMorphology::setMorphologyOperator):
691 (WebCore::FEMorphology::setRadiusX):
692 (WebCore::FEMorphology::setRadiusY):
693 * platform/graphics/filters/FEMorphology.h:
694 * svg/SVGFEMorphologyElement.cpp:
695 (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
696 (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
697 * svg/SVGFEMorphologyElement.h:
699 2011-03-01 Kent Tamura <tkent@chromium.org>
701 Reviewed by Dimitri Glazkov.
703 Assertion fails when a form validation bubble appears
704 https://bugs.webkit.org/show_bug.cgi?id=55550
706 Test: fast/forms/interactive-validation-attach-assertion.html
708 * html/ValidationMessage.cpp:
709 (WebCore::ValidationMessage::buildBubbleTree):
710 Just remove unnecessary attach().
712 2011-03-01 Kent Tamura <tkent@chromium.org>
714 Reviewed by Dimitri Glazkov.
716 Support localized numbers in <input type=number>
717 https://bugs.webkit.org/show_bug.cgi?id=42484
719 This change adds support of localized numbers in <input type=number>.
720 This affects only the UI, and not HTMLInputElement::value.
722 - Remove the keyboard input restriction feature because it is hard to
723 retrieve characters usable for localized numbers in ICU.
725 - Separate convertFromVisibleValue() from sanitizeValue().
726 sanitizeValue() is used for not only converting a renderer value to a
729 - Implement LocalizedNumber functions for ICU and NSNumberFormatter.
730 It is used only in Chromium for now.
732 Test: manual-tests/input-number-localization.html
734 * WebCore.gypi: Use LocalizedNumberICU.cpp.
735 * WebCore.xcodeproj/project.pbxproj:
736 Add LocalizedNumberMac.mm and remove LocalizedNumberNone.cpp.
737 * dom/InputElement.h: Introduce convertFromVisibleValue().
738 * html/HTMLInputElement.cpp:
739 (WebCore::HTMLInputElement::convertFromVisibleValue):
740 * html/HTMLInputElement.h:
741 * html/InputType.cpp:
742 (WebCore::InputType::convertFromVisibleValue):
744 * html/NumberInputType.cpp: Remove isHTMLNumberCharacter(),
745 isNumberCharacter(), and handleBeforeTextInsertedEvent() because we
746 remove the keyboard input restriction feature for type=number.
747 (WebCore::NumberInputType::convertFromVisibleValue):
748 (WebCore::NumberInputType::sanitizeValue):
749 * html/NumberInputType.h:
750 * manual-tests/input-number-localization.html: Add a manual test because
751 the behavior depends on the current locale.
752 * platform/text/LocalizedNumber.h: Remove isLocalizedNumberCharacter().
753 * platform/text/LocalizedNumberICU.cpp:
754 Implement LocalizedNumber functions with ICU NumberFormat.
755 (WebCore::createFormatterForCurrentLocale):
756 (WebCore::parseLocalizedNumber):
757 (WebCore::formatLocalizedNumber):
758 * platform/text/LocalizedNumberNone.cpp: Remove isLocalizedNumberCharacter().
759 * platform/text/mac/LocalizedNumberMac.mm:
760 Implement LocalizedNumber functions with NSNumberFormatter.
761 (WebCore::parseLocalizedNumber):
762 (WebCore::formatLocalizedNumber):
763 * rendering/RenderTextControlSingleLine.cpp:
764 (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
765 * wml/WMLInputElement.h:
766 (WebCore::WMLInputElement::convertFromVisibleValue):
767 Implemented as a function doing nothing.
769 2011-03-01 Yuta Kitamura <yutak@chromium.org>
771 Reviewed by Darin Adler.
773 REGRESSION(r78383): Failure to connect on websocketstest.com
774 https://bugs.webkit.org/show_bug.cgi?id=54811
776 After r78383, KURL::setPort() no longer appends ":port" part
777 if that port is the default port for URL scheme. This broke
778 SocketStreamHandleCFNet, whose code was based on an assumption
779 that KURL::setPort() always inserts ":port" part.
781 To fix this, KURL::port() call is removed from SocketStreamHandle
782 and the port number is calculated on-the-fly.
784 Unfortunately it is impossible to write a test; this bug only
785 affects WebSockets connecting to the default port (port 80
786 for ws, port 443 for wss), while we use different ports to test
787 WebSockets in LayoutTests.
789 * platform/network/cf/SocketStreamHandle.h:
790 * platform/network/cf/SocketStreamHandleCFNet.cpp:
791 (WebCore::SocketStreamHandle::SocketStreamHandle):
792 (WebCore::SocketStreamHandle::createStreams):
793 (WebCore::SocketStreamHandle::port):
795 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
797 Unreviewed, rolling out r80079.
798 http://trac.webkit.org/changeset/80079
799 https://bugs.webkit.org/show_bug.cgi?id=55547
801 "Broke the Win debug build?" (Requested by dcheng on #webkit).
803 * Configurations/FeatureDefines.xcconfig:
807 2011-02-25 Adrienne Walker <enne@google.com>
809 Reviewed by James Robinson.
811 [chromium] Abstract "pixels with a graphics context" into its own class
812 https://bugs.webkit.org/show_bug.cgi?id=55259
814 This creates new PlatformCanvas/PlatformImage classes which wrap
815 all of the #ifdef Skia/Cg warts from the compositor. All classes
816 (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
817 modified to use these abstractions.
819 Tests: LayoutTests/compositing
822 * platform/graphics/chromium/ContentLayerChromium.cpp:
823 (WebCore::ContentLayerChromium::updateContentsIfDirty):
824 (WebCore::ContentLayerChromium::resizeUploadBuffer):
825 (WebCore::ContentLayerChromium::updateTextureIfNeeded):
826 (WebCore::ContentLayerChromium::updateTexture):
827 (WebCore::ContentLayerChromium::draw):
828 * platform/graphics/chromium/ContentLayerChromium.h:
829 * platform/graphics/chromium/ImageLayerChromium.cpp:
830 (WebCore::ImageLayerChromium::updateContentsIfDirty):
831 (WebCore::ImageLayerChromium::updateTextureIfNeeded):
832 * platform/graphics/chromium/ImageLayerChromium.h:
833 * platform/graphics/chromium/LayerTilerChromium.cpp:
834 (WebCore::LayerTilerChromium::contentRectToTileIndices):
835 (WebCore::LayerTilerChromium::update):
836 (WebCore::LayerTilerChromium::updateFromPixels):
837 * platform/graphics/chromium/LayerTilerChromium.h:
838 * platform/graphics/chromium/PlatformCanvas.cpp: Added.
839 (WebCore::PlatformCanvas::PlatformCanvas):
840 (WebCore::PlatformCanvas::~PlatformCanvas):
841 (WebCore::PlatformCanvas::resize):
842 (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
843 (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
844 (WebCore::PlatformCanvas::Painter::Painter):
845 (WebCore::PlatformCanvas::Painter::~Painter):
846 * platform/graphics/chromium/PlatformCanvas.h: Added.
847 (WebCore::PlatformCanvas::AutoLocker::pixels):
848 (WebCore::PlatformCanvas::Painter::context):
849 (WebCore::PlatformCanvas::size):
850 * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
851 (WebCore::PlatformImage::PlatformImage):
852 (WebCore::PlatformImage::updateFromImage):
853 * platform/graphics/chromium/PlatformImage.h: Added.
854 (WebCore::PlatformImage::pixels):
855 (WebCore::PlatformImage::size):
857 2011-03-01 Daniel Cheng <dcheng@chromium.org>
859 Reviewed by David Levin.
861 Add feature define for data transfer items
862 https://bugs.webkit.org/show_bug.cgi?id=55510
864 * Configurations/FeatureDefines.xcconfig:
868 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
870 Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
872 * dom/ViewportArguments.cpp:
873 (WebCore::computeViewportAttributes):
874 (WebCore::numericPrefix):
875 (WebCore::findSizeValue):
876 (WebCore::setViewportFeature):
877 (WebCore::viewportErrorMessageTemplate):
878 (WebCore::viewportErrorMessageLevel):
879 * dom/ViewportArguments.h:
881 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
883 Reviewed by James Robinson.
885 IDBKeyRange.bound() should not use the optional options object
886 https://bugs.webkit.org/show_bug.cgi?id=55419
888 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept
890 Added some code to existing tests to cover these cases.
892 * storage/IDBKeyRange.cpp:
893 (WebCore::IDBKeyRange::bound):
894 * storage/IDBKeyRange.h:
895 * storage/IDBKeyRange.idl:
897 2011-03-01 Dan Bernstein <mitz@apple.com>
901 * dom/DocumentMarkerController.cpp:
902 (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
904 2011-03-01 Kent Tamura <tkent@chromium.org>
906 Unreviewed. Apply sort-Xcode-project-file.
908 * WebCore.xcodeproj/project.pbxproj:
910 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
912 Reviewed by James Robinson.
914 V8 code generator doesn't properly support a single SerializedScriptValue attribute
915 https://bugs.webkit.org/show_bug.cgi?id=55530
917 This is tested by the bindings tests changes.
919 * bindings/scripts/CodeGeneratorV8.pm:
920 * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: Added.
921 (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterfacePrivate::WebDOMTestSerializedScriptValueInterfacePrivate):
922 (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterface):
923 (WebDOMTestSerializedScriptValueInterface::operator=):
924 (WebDOMTestSerializedScriptValueInterface::impl):
925 (WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptValueInterface):
926 (WebDOMTestSerializedScriptValueInterface::value):
929 * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Added.
930 * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Added.
932 (webkit_dom_test_serialized_script_value_interface_get_value):
934 (webkit_dom_test_serialized_script_value_interface_finalize):
935 (webkit_dom_test_serialized_script_value_interface_set_property):
936 (webkit_dom_test_serialized_script_value_interface_get_property):
937 (webkit_dom_test_serialized_script_value_interface_constructed):
938 (webkit_dom_test_serialized_script_value_interface_class_init):
939 (webkit_dom_test_serialized_script_value_interface_init):
940 (WebKit::wrapTestSerializedScriptValueInterface):
941 * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: Added.
942 * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: Added.
943 * bindings/scripts/test/JS/JSTestInterface.cpp:
944 (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
945 (WebCore::JSTestInterface::JSTestInterface):
946 * bindings/scripts/test/JS/JSTestInterface.h:
947 * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
948 (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
949 (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
950 (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
951 * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
952 * bindings/scripts/test/JS/JSTestObj.cpp:
953 (WebCore::JSTestObjConstructor::JSTestObjConstructor):
954 (WebCore::JSTestObj::JSTestObj):
955 (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
956 (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
957 (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
958 (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
959 (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
960 (WebCore::jsTestObjPrototypeFunctionSerializedValue):
961 (WebCore::jsTestObjPrototypeFunctionIdbKey):
962 (WebCore::jsTestObjPrototypeFunctionOptionsObject):
963 (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
964 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
965 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
966 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
967 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
968 (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
969 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
970 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
971 (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
972 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
973 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
974 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
975 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
976 (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
977 * bindings/scripts/test/JS/JSTestObj.h:
978 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Added.
979 (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
980 (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
981 (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
982 (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
983 (WebCore::JSTestSerializedScriptValueInterfacePrototype::self):
984 (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
985 (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
986 (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
987 (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
988 (WebCore::jsTestSerializedScriptValueInterfaceValue):
989 (WebCore::jsTestSerializedScriptValueInterfaceConstructor):
990 (WebCore::JSTestSerializedScriptValueInterface::getConstructor):
992 (WebCore::toTestSerializedScriptValueInterface):
993 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h.
994 (WebCore::JSTestSerializedScriptValueInterface::createStructure):
995 (WebCore::JSTestSerializedScriptValueInterface::impl):
996 (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
997 (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
998 * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Added.
999 * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Added.
1000 (-[DOMTestSerializedScriptValueInterface dealloc]):
1001 (-[DOMTestSerializedScriptValueInterface finalize]):
1002 (-[DOMTestSerializedScriptValueInterface value]):
1005 * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Added.
1006 * bindings/scripts/test/TestSerializedScriptValueInterface.idl: Added.
1007 * bindings/scripts/test/V8/V8TestInterface.cpp:
1008 (WebCore::ConfigureV8TestInterfaceTemplate):
1009 * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Copied from Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp.
1010 (WebCore::TestSerializedScriptValueInterfaceInternal::V8_USE):
1011 (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
1012 (WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
1013 (WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
1014 (WebCore::V8TestSerializedScriptValueInterface::HasInstance):
1015 (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
1016 (WebCore::V8TestSerializedScriptValueInterface::derefObject):
1017 * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Added.
1018 (WebCore::V8TestSerializedScriptValueInterface::toNative):
1019 (WebCore::V8TestSerializedScriptValueInterface::wrap):
1022 2011-03-01 Oliver Hunt <oliver@apple.com>
1024 Reviewed by Joseph Pecoraro.
1026 Misaligned memory access in CloneDeserializer on all ARM arch.
1027 https://bugs.webkit.org/show_bug.cgi?id=48742
1029 Push platforms that need aligned memory access down the
1030 endian independent serialization and deserialization
1033 * bindings/js/SerializedScriptValue.cpp:
1035 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
1037 Reviewed by Kenneth Rohde Christiansen.
1039 Viewport Warning/Error Messages Are Now Inaccurate
1040 https://bugs.webkit.org/show_bug.cgi?id=53707
1042 Correct and improve the error messages for viewport
1043 parsing. Clarify the difference between incorrect
1044 keys, values, and when to use the device-width or
1045 device-height constants.
1047 * dom/ViewportArguments.cpp:
1048 (WebCore::computeViewportAttributes): suggest using keywords if fixed input matches device width or height.
1049 (WebCore::numericPrefix):
1050 (WebCore::findSizeValue): remove incorrect warnings about fixed numbers because we don't know the device width or height.
1051 (WebCore::setViewportFeature): report a warning for an unrecognized key.
1052 (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
1053 (WebCore::viewportErrorMessageLevel):
1054 * dom/ViewportArguments.h:
1056 2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
1058 Reviewed by Darin Adler.
1060 WebKit does not merge text decorations in the typing style and the selected element properly
1061 https://bugs.webkit.org/show_bug.cgi?id=55349
1063 The bug was caused by EditingStyle::mergeTypingStyle's not properly merging text decoration property.
1064 Fixed the bug by extracting a function from ApplyStyleCommand::pushDownInlineStyleAroundNode and
1065 calling it in pushDownInlineStyleAroundNode and in mergeTypingStyle.
1067 Test: editing/execCommand/merge-text-decoration-with-typing-style.html
1069 * editing/ApplyStyleCommand.cpp:
1070 (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Takes EditingStyle*;
1071 calls mergeInlineStyleOfElement.
1072 (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls applyInlineStyleToPushDown.
1073 (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
1074 * editing/ApplyStyleCommand.h:
1075 * editing/EditingStyle.cpp:
1076 (WebCore::EditingStyle::mergeTypingStyle): Added; calls mergeStyle.
1077 (WebCore::EditingStyle::mergeInlineStyleOfElement): Ditto.
1078 (WebCore::EditingStyle::mergeStyle): Extracted from applyInlineStyleToPushDown.
1079 * editing/EditingStyle.h:
1081 2011-03-01 Levi Weintraub <leviw@chromium.org>
1083 Reviewed by Ryosuke Niwa.
1085 Stop instantiating legacy editing Positions in VisiblePosition
1086 https://bugs.webkit.org/show_bug.cgi?id=52919
1088 Changing VisiblePosition completely away from legacy positions.
1090 No new tests since this is functionaly equivalent.
1092 * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
1093 adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
1094 outside of WebCore, they should be parent anchored.
1095 * accessibility/AXObjectCache.cpp:
1096 (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
1097 * accessibility/AccessibilityObject.cpp:
1098 (WebCore::startOfStyleRange):
1099 (WebCore::endOfStyleRange):
1100 * accessibility/AccessibilityRenderObject.cpp:
1101 (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
1102 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1103 (objectAndOffsetUnignored):
1105 (WebCore::Position::document): Added this inline function to avoid the necessity
1106 of calling anchorNode to assure a document from a Position.
1107 (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
1108 (WebCore::Position::downstream): ditto
1110 (WebCore::Range::editingStartPosition):
1111 * editing/Editor.cpp:
1112 (WebCore::Editor::canDeleteRange):
1113 * editing/ReplaceSelectionCommand.cpp:
1114 (WebCore::ReplaceSelectionCommand::doApply):
1115 * editing/SelectionController.cpp:
1116 (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
1117 (WebCore::SelectionController::setSelectedRange):
1118 * editing/TextIterator.cpp:
1119 (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
1120 * editing/TypingCommand.cpp:
1121 (WebCore::TypingCommand::deleteKeyPressed):
1122 * editing/VisiblePosition.cpp:
1123 (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
1124 (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
1125 (WebCore::VisiblePosition::canonicalPosition):
1126 (WebCore::VisiblePosition::characterAfter):
1127 (WebCore::VisiblePosition::localCaretRect):
1128 (WebCore::makeRange):
1129 (WebCore::startVisiblePosition):
1130 (WebCore::endVisiblePosition):
1131 (WebCore::setStart):
1133 (WebCore::isFirstVisiblePositionInNode):
1134 (WebCore::isLastVisiblePositionInNode):
1135 * editing/VisiblePosition.h:
1136 (WebCore::VisiblePosition::VisiblePosition):
1137 * editing/htmlediting.cpp:
1138 (WebCore::firstInSpecialElement):
1139 (WebCore::lastInSpecialElement):
1140 (WebCore::visiblePositionBeforeNode):
1141 (WebCore::visiblePositionAfterNode):
1142 * editing/visible_units.cpp:
1143 (WebCore::startPositionForLine):
1144 (WebCore::endPositionForLine):
1145 (WebCore::previousLinePosition):
1146 (WebCore::nextLinePosition):
1147 (WebCore::startOfParagraph):
1148 (WebCore::endOfParagraph):
1149 (WebCore::endOfBlock):
1150 (WebCore::startOfDocument):
1151 (WebCore::endOfDocument):
1152 (WebCore::logicalStartPositionForLine):
1153 (WebCore::logicalEndPositionForLine):
1154 * page/DOMSelection.cpp:
1155 (WebCore::DOMSelection::collapse):
1156 (WebCore::DOMSelection::setBaseAndExtent):
1157 (WebCore::DOMSelection::setPosition):
1158 (WebCore::DOMSelection::extend):
1159 * page/EventHandler.cpp:
1160 (WebCore::EventHandler::handleMousePressEventSingleClick):
1161 * rendering/RenderObject.cpp:
1162 (WebCore::RenderObject::createVisiblePosition):
1163 * rendering/RenderTextControl.cpp:
1164 (WebCore::RenderTextControl::visiblePositionForIndex):
1165 * svg/SVGTextContentElement.cpp:
1166 (WebCore::SVGTextContentElement::selectSubString):
1168 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
1170 Reviewed by Steve Block.
1172 When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
1173 https://bugs.webkit.org/show_bug.cgi?id=54785
1175 This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
1176 the right thing and continue to do the right thing. It also modifies EventQueue
1177 so that we can cancel an event. To do this efficiently, the vector is now a
1180 Cancelling the event is harder/messier, but the most deterministic thing to do.
1181 To the user, the work isn't done until we fire the onsuccess/onerror handler.
1182 So the event (which does fire that) needs to be cancelable.
1184 transaction-abort.html tests this.
1186 * dom/EventQueue.cpp:
1187 (WebCore::EventQueue::enqueueEvent):
1188 (WebCore::EventQueue::cancelEvent):
1189 (WebCore::EventQueue::pendingEventTimerFired):
1190 (WebCore::EventQueue::dispatchEvent):
1192 * dom/ExceptionCode.cpp:
1193 * storage/IDBCursor.cpp:
1194 (WebCore::IDBCursor::update):
1195 (WebCore::IDBCursor::deleteFunction):
1196 * storage/IDBDatabaseBackendImpl.cpp:
1197 (WebCore::IDBDatabaseBackendImpl::close):
1198 * storage/IDBDatabaseException.h:
1199 * storage/IDBIndex.cpp:
1200 (WebCore::IDBIndex::openCursor):
1201 (WebCore::IDBIndex::openKeyCursor):
1202 (WebCore::IDBIndex::get):
1203 (WebCore::IDBIndex::getKey):
1204 * storage/IDBObjectStore.cpp:
1205 (WebCore::IDBObjectStore::get):
1206 (WebCore::IDBObjectStore::add):
1207 (WebCore::IDBObjectStore::put):
1208 (WebCore::IDBObjectStore::deleteFunction):
1209 (WebCore::IDBObjectStore::clear):
1210 (WebCore::IDBObjectStore::openCursor):
1211 * storage/IDBRequest.cpp:
1212 (WebCore::IDBRequest::IDBRequest):
1213 (WebCore::IDBRequest::~IDBRequest):
1214 (WebCore::IDBRequest::readyState):
1215 (WebCore::IDBRequest::markEarlyDeath):
1216 (WebCore::IDBRequest::source):
1217 (WebCore::IDBRequest::abort):
1218 (WebCore::IDBRequest::onSuccess):
1219 (WebCore::IDBRequest::dispatchEvent):
1220 (WebCore::IDBRequest::enqueueEvent):
1221 * storage/IDBRequest.h:
1222 * storage/IDBTransaction.cpp:
1223 (WebCore::IDBTransaction::registerRequest):
1224 (WebCore::IDBTransaction::unregisterRequest):
1225 (WebCore::IDBTransaction::onAbort):
1226 * storage/IDBTransaction.h:
1228 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
1230 Reviewed by Mihai Parparita.
1232 EventQueue needs to be ref counted
1233 https://bugs.webkit.org/show_bug.cgi?id=55512
1235 EventQueue needs to be ref counted because it's possible for its instance
1236 to be deleted while it's dispatching events. This is the reason why
1237 https://bugs.webkit.org/show_bug.cgi?id=54785 had to be reverted.
1239 No change of behavior, so no tests.
1242 * dom/EventQueue.cpp:
1243 (WebCore::EventQueue::create):
1246 2011-03-01 Helder Correia <helder@sencha.com>
1248 Reviewed by Simon Fraser.
1250 No shadow when stroking a path with a gradient
1251 https://bugs.webkit.org/show_bug.cgi?id=55436
1253 This happens in CG and is related to bug 52509, this time to be fixed
1254 in GraphicsContext::strokePath(). The gradient needs to be drawn
1255 clipped to the stroke on a CGLayer first, then the layer drawn on the
1258 Tests: fast/canvas/canvas-strokePath-gradient-shadow.html
1259 svg/css/path-gradient-stroke-shadow.svg
1261 * platform/graphics/cg/GraphicsContextCG.cpp:
1262 (WebCore::GraphicsContext::strokePath):
1264 2011-03-01 David Hyatt <hyatt@apple.com>
1266 Reviewed by Dan Bernstein.
1268 Fix Font::spaceWidth() to be a float instead of an int.
1270 * platform/graphics/Font.h:
1271 (WebCore::Font::spaceWidth):
1273 2011-02-28 Steve Block <steveblock@google.com>
1275 Reviewed by Jeremy Orlow.
1277 Chromium gypi file should include Java bridge files from WebCore/bridge
1278 https://bugs.webkit.org/show_bug.cgi?id=55387
1280 No new tests, no code changes.
1282 * WebCore.gyp/WebCore.gyp:
1285 2011-03-01 James Simonsen <simonjam@chromium.org>
1287 Reviewed by Tony Gentilcore.
1289 [Web Timing] Handle the case where no responseEnd time is available.
1290 https://bugs.webkit.org/show_bug.cgi?id=55444
1292 * loader/MainResourceLoader.cpp:
1293 (WebCore::MainResourceLoader::MainResourceLoader): Initialize to 0.
1294 (WebCore::MainResourceLoader::didFinishLoading): Fall back to current time if no other time is available.
1296 2011-03-01 Patrick Gansterer <paroga@webkit.org>
1298 Unreviewed, adding missing change for r80034.
1300 Add a handler class for Win32 HANDLE
1301 https://bugs.webkit.org/show_bug.cgi?id=55334
1303 * platform/win/Win32Handle.h: Added missing WTF_MAKE_NONCOPYABLE macro.
1305 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
1307 Unreviewed, rolling out r80037.
1308 http://trac.webkit.org/changeset/80037
1309 https://bugs.webkit.org/show_bug.cgi?id=55508
1311 broke compile on SL (Requested by tonyg-cr on #webkit).
1318 * WebCore.vcproj/WebCore.vcproj:
1319 * WebCore.xcodeproj/project.pbxproj:
1320 * css/CSSParser.cpp:
1321 (WebCore::CSSParser::parseValue):
1323 * css/CSSStyleSelector.cpp:
1324 (WebCore::CSSStyleSelector::applyProperty):
1328 * rendering/RenderBlockLineLayout.cpp:
1329 (WebCore::dirtyLineBoxesForRenderer):
1330 * rendering/RenderObject.h:
1331 * rendering/RenderObjectChildList.cpp:
1332 (WebCore::RenderObjectChildList::removeChildNode):
1333 (WebCore::RenderObjectChildList::appendChildNode):
1334 (WebCore::RenderObjectChildList::insertChildNode):
1335 (WebCore::RenderObjectChildList::updateBeforeAfterContent):
1336 * rendering/RenderQuote.cpp: Removed.
1337 * rendering/RenderQuote.h: Removed.
1338 * rendering/RenderingAllInOne.cpp:
1339 * rendering/style/ContentData.cpp:
1340 (WebCore::ContentData::dataEquivalent):
1341 (WebCore::ContentData::deleteContent):
1342 * rendering/style/ContentData.h:
1343 * rendering/style/QuotesData.cpp: Removed.
1344 * rendering/style/QuotesData.h: Removed.
1345 * rendering/style/RenderStyle.cpp:
1346 * rendering/style/RenderStyle.h:
1347 * rendering/style/RenderStyleConstants.h:
1348 * rendering/style/StyleAllInOne.cpp:
1349 * rendering/style/StyleRareInheritedData.cpp:
1350 (WebCore::StyleRareInheritedData::operator==):
1351 * rendering/style/StyleRareInheritedData.h:
1353 2011-03-01 Abhishek Arya <inferno@chromium.org>
1355 Reviewed by Dave Hyatt.
1357 Paint outline for tables.
1358 https://bugs.webkit.org/show_bug.cgi?id=55474
1360 Test: fast/table/table-and-parts-outline.html
1362 * rendering/RenderTable.cpp:
1363 (WebCore::RenderTable::paintObject):
1365 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
1367 Unreviewed, rolling out r80028.
1368 http://trac.webkit.org/changeset/80028
1369 https://bugs.webkit.org/show_bug.cgi?id=55502
1371 'caused crashes; rolling out while investigating' (Requested
1372 by jorlow on #webkit).
1374 * dom/EventQueue.cpp:
1375 (WebCore::EventQueue::enqueueEvent):
1376 (WebCore::EventQueue::pendingEventTimerFired):
1377 (WebCore::EventQueue::dispatchEvent):
1379 * dom/ExceptionCode.cpp:
1380 * storage/IDBCursor.cpp:
1381 (WebCore::IDBCursor::update):
1382 (WebCore::IDBCursor::deleteFunction):
1383 * storage/IDBDatabaseException.h:
1384 * storage/IDBDatabaseException.idl:
1385 * storage/IDBIndex.cpp:
1386 (WebCore::IDBIndex::openCursor):
1387 (WebCore::IDBIndex::openKeyCursor):
1388 (WebCore::IDBIndex::get):
1389 (WebCore::IDBIndex::getKey):
1390 * storage/IDBObjectStore.cpp:
1391 (WebCore::IDBObjectStore::get):
1392 (WebCore::IDBObjectStore::add):
1393 (WebCore::IDBObjectStore::put):
1394 (WebCore::IDBObjectStore::deleteFunction):
1395 (WebCore::IDBObjectStore::clear):
1396 (WebCore::IDBObjectStore::openCursor):
1397 * storage/IDBRequest.cpp:
1398 (WebCore::IDBRequest::IDBRequest):
1399 (WebCore::IDBRequest::~IDBRequest):
1400 (WebCore::IDBRequest::readyState):
1401 (WebCore::IDBRequest::dispatchEvent):
1402 (WebCore::IDBRequest::enqueueEvent):
1403 (WebCore::IDBRequest::source):
1404 * storage/IDBRequest.h:
1405 * storage/IDBTransaction.cpp:
1406 (WebCore::IDBTransaction::onAbort):
1407 * storage/IDBTransaction.h:
1409 2011-03-01 Carol Szabo <carol.szabo@nokia.com>
1411 Reviewed by David Hyatt <hyatt@apple.com>
1413 content property doesn't support quotes
1414 https://bugs.webkit.org/show_bug.cgi?id=6503
1416 Added full support for quotes as defined by CSS 2.1.
1418 Tests: fast/css/content/content-quotes-01.html
1419 fast/css/content/content-quotes-02.html
1420 fast/css/content/content-quotes-03.html
1421 fast/css/content/content-quotes-04.html
1422 fast/css/content/content-quotes-05.html
1428 * WebCore.vcproj/WebCore.vcproj:
1429 * WebCore.xcodeproj/project.pbxproj:
1430 Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
1431 * css/CSSParser.cpp:
1432 (WebCore::CSSParser::parseValue):
1433 (WebCore::CSSParser::parseQuotes):
1435 Added needed stylesheet parsing support for quotes,
1436 (no-)open-quote and (no-)close-quote
1437 * css/CSSStyleSelector.cpp:
1438 (WebCore::CSSStyleSelector::applyProperty):
1439 Handled setting of the new quotes RenderStyle property and added
1440 handling of quotes for the content property.
1444 replaced the '"' workaround with open/close-quote
1445 * rendering/RenderBlockLineLayout.cpp:
1446 (WebCore::dirtyLineBoxesForRenderer):
1447 Made RenderQuote behave like RenderCounter.
1448 Needed to ensure that the Quote text is calculated before layout,
1449 just as it is for RenderCounter.
1450 * rendering/RenderObject.h:
1451 (WebCore::RenderObject::isQuote):
1452 * rendering/RenderObjectChildList.cpp:
1453 (WebCore::RenderObjectChildList::removeChildNode):
1454 (WebCore::RenderObjectChildList::appendChildNode):
1455 (WebCore::RenderObjectChildList::insertChildNode):
1456 Handled updating of quote depth when renderers are added and removed
1458 (WebCore::RenderObjectChildList::updateBeforeAfterContent):
1459 * rendering/RenderQuote.cpp: Added.
1460 (WebCore::adjustDepth):
1461 (WebCore::RenderQuote::RenderQuote):
1462 (WebCore::RenderQuote::~RenderQuote):
1463 (WebCore::RenderQuote::renderName):
1464 (WebCore::RenderQuote::placeQuote):
1465 (WebCore::RenderQuote::originalText):
1466 (WebCore::RenderQuote::computePreferredLogicalWidths):
1467 (WebCore::RenderQuote::rendererSubtreeAttached):
1468 (WebCore::RenderQuote::rendererRemovedFromTree):
1469 (WebCore::RenderQuote::styleDidChange):
1470 * rendering/RenderQuote.h: Added.
1471 (WebCore::RenderQuote::isQuote):
1472 (WebCore::toRenderQuote):
1473 * rendering/RenderingAllInOne.cpp:
1474 Included RenderQuote.cpp
1475 * rendering/style/StyleAllInOne.cpp:
1476 Included QuotesData.cpp
1477 * rendering/style/ContentData.cpp:
1478 (WebCore::ContentData::dataEquivalent):
1479 Checked for quotetype identity.
1480 (WebCore::ContentData::deleteContent):
1481 Accounted for the new QUOTE_TYPE.
1482 * rendering/style/ContentData.h:
1483 (WebCore::ContentData::isQuote):
1484 (WebCore::ContentData::quote):
1485 (WebCore::ContentData::setQuote):
1486 * rendering/style/RenderStyle.cpp:
1487 (WebCore::RenderStyle::setContent):
1488 * rendering/style/RenderStyle.h:
1489 (WebCore::InheritedFlags::quotes):
1490 (WebCore::InheritedFlags::setQuotes):
1491 * rendering/style/RenderStyleConstants.h:
1492 * rendering/style/StyleRareInheritedData.cpp:
1493 (WebCore::StyleRareInheritedData::operator==):
1494 Included quotes in equality check.
1495 * rendering/style/StyleRareInheritedData.h:
1498 2011-03-01 Michael Nordman <michaeln@google.com>
1500 Reviewed by Alexey Proskuryakov.
1502 Alter the relative priorities of network vs fallback namespaces in the appcache.
1503 If a resource url is in an appcache's network namespace and fallback namespace, the network
1504 namespace wins (with the exception of the special '*' network namespace which does not take
1505 priority over the fallback namespace.
1506 https://bugs.webkit.org/show_bug.cgi?id=49292
1508 Test: http/tests/appcache/online-fallback-layering.html
1510 * loader/appcache/ApplicationCache.cpp:
1511 (WebCore::ApplicationCache::isURLInOnlineWhitelist):
1512 * loader/appcache/ApplicationCacheHost.cpp:
1513 (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
1514 (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):
1515 * loader/appcache/ApplicationCacheStorage.cpp:
1516 (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
1518 2011-03-01 Patrick Gansterer <paroga@webkit.org>
1520 Reviewed by Adam Roben.
1522 Add a handler class for Win32 HANDLE
1523 https://bugs.webkit.org/show_bug.cgi?id=55334
1525 This class will call CloseHandle in the destructor for valid handles.
1527 * platform/win/Win32Handle.h: Added.
1529 2011-03-01 Eric Carlson <eric.carlson@apple.com>
1531 Reviewed by Chris Marrin.
1533 <audio> and <video> should respect private browsing mode
1534 https://bugs.webkit.org/show_bug.cgi?id=55287
1535 <rdar://problem/9057699>
1537 No new tests, this is just the plumbing.
1540 (WebCore::Document::privateBrowsingStateDidChange): New.
1541 (WebCore::Document::registerForPrivateBrowsingStateChangedCallbacks): Ditto.
1542 (WebCore::Document::unregisterForPrivateBrowsingStateChangedCallbacks): Ditto.
1546 (WebCore::Element::privateBrowsingStateDidChange): New.
1548 * html/HTMLMediaElement.cpp:
1549 (WebCore::HTMLMediaElement::HTMLMediaElement): Register for privacy mode changes.
1550 (WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for privacy mode changes.
1551 (WebCore::HTMLMediaElement::loadResource): Tell player current privacy mode.
1552 (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): New, call through to MediaPlayer.
1553 * html/HTMLMediaElement.h:
1556 (WebCore::Page::privateBrowsingStateChanged): Call document()->privateBrowsingStateDidChange.
1558 * platform/graphics/MediaPlayer.cpp:
1559 (WebCore::MediaPlayer::setPrivateBrowsingMode): New, call through to media engine.
1560 * platform/graphics/MediaPlayer.h:
1562 * platform/graphics/MediaPlayerPrivate.h:
1563 (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode): Declare new interface.
1565 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
1567 Reviewed by Steve Block.
1569 When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
1570 https://bugs.webkit.org/show_bug.cgi?id=54785
1572 This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
1573 the right thing and continue to do the right thing. It also modifies EventQueue
1574 so that we can cancel an event. To do this efficiently, the vector is now a
1577 Canelling the event is harder/messier, but the most deterministic thing to do.
1578 To the user, the work isn't done until we fire the onsuccess/onerror handler.
1579 So the event (which does fire that) needs to be cancelable.
1581 transaction-abort.html tests this.
1583 * dom/EventQueue.cpp:
1584 (WebCore::EventQueue::enqueueEvent):
1585 (WebCore::EventQueue::cancelEvent):
1586 (WebCore::EventQueue::pendingEventTimerFired):
1587 (WebCore::EventQueue::dispatchEvent):
1589 * dom/ExceptionCode.cpp:
1590 * storage/IDBCursor.cpp:
1591 (WebCore::IDBCursor::update):
1592 (WebCore::IDBCursor::deleteFunction):
1593 * storage/IDBDatabaseBackendImpl.cpp:
1594 (WebCore::IDBDatabaseBackendImpl::close):
1595 * storage/IDBDatabaseException.h:
1596 * storage/IDBIndex.cpp:
1597 (WebCore::IDBIndex::openCursor):
1598 (WebCore::IDBIndex::openKeyCursor):
1599 (WebCore::IDBIndex::get):
1600 (WebCore::IDBIndex::getKey):
1601 * storage/IDBObjectStore.cpp:
1602 (WebCore::IDBObjectStore::get):
1603 (WebCore::IDBObjectStore::add):
1604 (WebCore::IDBObjectStore::put):
1605 (WebCore::IDBObjectStore::deleteFunction):
1606 (WebCore::IDBObjectStore::clear):
1607 (WebCore::IDBObjectStore::openCursor):
1608 * storage/IDBRequest.cpp:
1609 (WebCore::IDBRequest::IDBRequest):
1610 (WebCore::IDBRequest::~IDBRequest):
1611 (WebCore::IDBRequest::readyState):
1612 (WebCore::IDBRequest::markEarlyDeath):
1613 (WebCore::IDBRequest::source):
1614 (WebCore::IDBRequest::abort):
1615 (WebCore::IDBRequest::onSuccess):
1616 (WebCore::IDBRequest::dispatchEvent):
1617 (WebCore::IDBRequest::enqueueEvent):
1618 * storage/IDBRequest.h:
1619 * storage/IDBTransaction.cpp:
1620 (WebCore::IDBTransaction::registerRequest):
1621 (WebCore::IDBTransaction::unregisterRequest):
1622 (WebCore::IDBTransaction::onAbort):
1623 * storage/IDBTransaction.h:
1625 2011-03-01 Jeremy Orlow <jorlow@chromium.org>
1627 Reviewed by Steve Block.
1629 Only IndexedDB's error event should be cancelable
1630 https://bugs.webkit.org/show_bug.cgi?id=55413
1632 * storage/IDBRequest.cpp:
1633 (WebCore::createSuccessEvent):
1634 * storage/IDBTransaction.cpp:
1635 (WebCore::IDBTransaction::onAbort):
1636 (WebCore::IDBTransaction::onComplete):
1638 2011-03-01 Jia Pu <jpu@apple.com>
1640 Reviewed by Darin Adler.
1642 Remove CorrectionIndicator markers sooner.
1643 https://bugs.webkit.org/show_bug.cgi?id=54893
1644 <rdar://problem/8997524>
1646 Test: platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html
1648 This patch changes the autocorrection behavior on Mac OS X. We want to remove CorrectionIndicator
1649 marker after any editing command if the command:
1650 1. is not a SpellingCorrectionCommand itself.
1651 2. is not the command that triggers the autocorrection.
1652 This is achieved by adding shouldRetainAutocorrectionIndicator() function to EditCommand. This function returns
1653 false for all commands derived from EditCommand, except SpellingCorrectionCommand and TypingCommand. This function
1654 always returns true for SpellingCorrectionCommand. For TypingCommand, the return value is determined by member
1655 variable m_shouldRetainAutocorrectionIndicator, which can be modified by passing option into the TypingCommand's
1658 To avoid constantly searching marker list, we use variable DocumentMarkerController::m_absentMarkerTypeCache
1659 to cache whether there is any marker of a particular type.
1661 This patch also fixes two minor existing bugs.
1663 1. We used to show reversion panel for word with CorrectionIndicator marker. This is incorrect because
1664 CorrectionIndicator marker can be removed from corrected words. Since all autocorrected words have Replacement
1665 marker unless the whole word is deleted, the correct behavior is to show reversion panel for word with Replacement
1666 marker, since all autocorrected words have such marker. However, since we don't want to show the reversion panel
1667 if an autocorrected word has been edited, we also check to see if the Replacement marker's description is null.
1669 This works as following:
1670 When we apply an autocorrection, we add Replacement marker to corrected word, and store original word
1671 as the marker's description. If the user edited the corrected word afterward, we set description to null.
1672 So when we decide whether to show a reversion panel, we not only check for the existence of Replacement
1673 marker, but also check if description is null.
1675 2. Fixed an assertion violation in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited(), which would
1676 occur when deleting the first character in an editable area.
1678 * dom/DocumentMarker.h: Added m_possiblyExistingMarkerTypes to allow quickly checking whether a marker type is
1679 completely in from the document.
1681 * dom/DocumentMarkerController.cpp: Most of the functions listed here are optimized for early return by checking
1682 the return value of possiblyHasMarkers() at beginning.
1683 (WebCore::DocumentMarkerController::possiblyHasMarkers):
1684 (WebCore::DocumentMarkerController::DocumentMarkerController):
1685 (WebCore::DocumentMarkerController::detach):
1686 (WebCore::DocumentMarkerController::removeMarkers):
1687 (WebCore::DocumentMarkerController::addMarker):
1688 (WebCore::DocumentMarkerController::copyMarkers):
1689 (WebCore::DocumentMarkerController::markerContainingPoint):
1690 (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1691 (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
1692 (WebCore::DocumentMarkerController::repaintMarkers):
1693 (WebCore::DocumentMarkerController::shiftMarkers):
1694 (WebCore::DocumentMarkerController::setMarkersActive):
1695 (WebCore::DocumentMarkerController::hasMarkers):
1696 (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1697 * dom/DocumentMarkerController.h:
1698 * editing/EditCommand.cpp:
1699 (WebCore::EditCommand::apply):
1700 (WebCore::EditCommand::shouldRetainAutocorrectionIndicator):
1701 (WebCore::EditCommand::setShouldRetainAutocorrectionIndicator):
1702 * editing/EditCommand.h:
1703 * editing/Editor.cpp:
1704 (WebCore::Editor::respondToChangedSelection):
1705 (WebCore::Editor::appliedEditing):
1706 (WebCore::Editor::insertTextWithoutSendingTextEvent):
1707 (WebCore::Editor::insertLineBreak):
1708 (WebCore::Editor::insertParagraphSeparator):
1709 (WebCore::Editor::markMisspellingsAfterTypingToWord):
1710 (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
1711 (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
1712 (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
1714 * editing/EditorCommand.cpp:
1715 (WebCore::executeInsertLineBreak):
1716 (WebCore::executeInsertParagraph):
1717 (WebCore::executeInsertText):
1718 * editing/SpellingCorrectionCommand.cpp:
1719 (WebCore::SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator):
1720 * editing/SpellingCorrectionCommand.h:
1721 * editing/TypingCommand.cpp:
1722 (WebCore::TypingCommand::TypingCommand):
1723 (WebCore::TypingCommand::deleteSelection):
1724 (WebCore::TypingCommand::deleteKeyPressed):
1725 (WebCore::TypingCommand::forwardDeleteKeyPressed):
1726 (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection):
1727 (WebCore::TypingCommand::insertText):
1728 (WebCore::TypingCommand::insertLineBreak):
1729 (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
1730 (WebCore::TypingCommand::insertParagraphSeparator):
1731 * editing/TypingCommand.h:
1732 (WebCore::TypingCommand::create):
1733 (WebCore::TypingCommand::shouldRetainAutocorrectionIndicator):
1734 (WebCore::TypingCommand::setShouldRetainAutocorrectionIndicator):
1735 * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html:
1737 2011-03-01 Renata Hodovan <reni@webkit.org>
1739 Reviewed by Andreas Kling.
1741 FEDisplacementMapElement changes doesn't require relayout
1742 https://bugs.webkit.org/show_bug.cgi?id=55454
1744 When the FEDisplacementMapElement receives an update message but the given value remains the same we don't need
1745 to relayout the filter.
1747 No new tests are needed because this modification is covered by the dynamic update tests of FEDisplacementMap.
1749 * platform/graphics/filters/FEDisplacementMap.cpp:
1750 (WebCore::FEDisplacementMap::setXChannelSelector):
1751 (WebCore::FEDisplacementMap::setYChannelSelector):
1752 (WebCore::FEDisplacementMap::setScale):
1753 * platform/graphics/filters/FEDisplacementMap.h:
1754 * svg/SVGFEDisplacementMapElement.cpp:
1755 (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute):
1756 (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
1757 * svg/SVGFEDisplacementMapElement.h:
1759 2011-03-01 Dan Bernstein <mitz@apple.com>
1761 Reviewed by Darin Adler.
1763 <rdar://problem/8902714> Expand ruby text when it is shorter than the ruby base
1764 https://bugs.webkit.org/show_bug.cgi?id=55487
1767 (ruby > rt): Changed the default text-align value to -webkit-auto to signal
1768 the default expansion behavior.
1769 * rendering/RenderBlock.h:
1770 (WebCore::RenderRubyText::textAlignmentForLine): Made protected.
1771 (WebCore::RenderBlock::adjustInlineDirectionLineBounds): Made protected.
1772 * rendering/RenderRubyText.cpp:
1773 (WebCore::RenderRubyText::textAlignmentForLine): Added. If text-align is
1774 -webkit-auto, returns JUSTIFY to allow expansion.
1775 (WebCore::RenderRubyText::adjustInlineDirectionLineBounds): Added. If
1776 text-align is -webkit-auto, insets the line such that the inset on each side
1777 is the half the inter-ideograph expansion, or one ruby character wide,
1778 whichever is smaller.
1779 * rendering/RenderRubyText.h:
1781 2011-03-01 Sam Weinig <sam@webkit.org>
1783 Reviewed by Timothy Hatcher.
1785 WebKit2 needs to be made localizable
1786 https://bugs.webkit.org/show_bug.cgi?id=55483
1788 * English.lproj/Localizable.strings: Copied from Source/WebKit/English.lproj/Localizable.strings.
1789 * WebCore.xcodeproj/project.pbxproj:
1790 Move Localizable.strings to WebCore.
1793 Add export for localizedString function.
1795 * platform/LocalizedStrings.h:
1796 * platform/mac/LocalizedStringsMac.mm: Added.
1797 Add function to get localized version of a string from the WebCore bundle.
1799 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
1801 Reviewed by Timothy Hatcher.
1803 All Console Messages should be passed to ChromeClients.
1804 https://bugs.webkit.org/show_bug.cgi?id=54926
1806 Do not filter the message type here, allow clients
1807 to filter and deal with the different message types.
1810 (WebCore::Console::addMessage):
1812 2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
1814 Reviewed by Kenneth Rohde Christiansen.
1816 Viewport parsing no longer accepts "1.0;" value as valid.
1817 https://bugs.webkit.org/show_bug.cgi?id=53705
1819 When parsing numeric values, the "css-viewport" spec says
1820 to use the number prefix, and the non numeric part of the
1821 string can be ignored. This matches our behavior before
1822 r67376. The change was that checking the error out condition
1823 of String::toFloat doesn't necessarily mean that there
1824 was a non-numeric prefix. This patch checks if there was
1825 or wasn't a non-numeric prefix.
1827 There is a console warning in any case where a numeric
1828 value is not parsed cleanly. There is an error warning
1829 when it is not a number at all, and a tip warning when
1830 it has been truncated.
1832 Error messages are slightly improved to provide more
1833 context, both the key and value, when an error happens.
1835 Test: fast/viewport/viewport-129.html
1837 * dom/ViewportArguments.cpp:
1838 (WebCore::numericPrefix):
1839 (WebCore::findSizeValue):
1840 (WebCore::findScaleValue):
1841 (WebCore::findUserScalableValue):
1842 (WebCore::findTargetDensityDPIValue):
1843 (WebCore::viewportErrorMessageTemplate):
1844 (WebCore::viewportErrorMessageLevel):
1845 (WebCore::reportViewportWarning):
1846 * dom/ViewportArguments.h:
1848 2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
1850 Reviewed by Pavel Feldman.
1852 Web Inspector: InjectedScript.setPropertyValue doesn't work.
1853 https://bugs.webkit.org/show_bug.cgi?id=55475
1855 * inspector/InjectedScript.cpp:
1856 (WebCore::InjectedScript::setPropertyValue):
1858 2011-03-01 Steve Block <steveblock@google.com>
1860 Reviewed by Jeremy Orlow.
1862 Remove unused JavaString::uchars()
1863 https://bugs.webkit.org/show_bug.cgi?id=55465
1865 No new tests, removing dead code only.
1867 * bridge/jni/JNIBridge.h:
1868 * bridge/jni/jsc/JavaStringJSC.h:
1869 (JSC::Bindings::JavaStringImpl::utf8):
1870 * bridge/jni/v8/JavaStringV8.h:
1872 2011-03-01 Alexander Pavlov <apavlov@chromium.org>
1874 Reviewed by Yury Semikhatsky.
1876 Web Inspector: Extremely slow DOM search in GMail
1877 https://bugs.webkit.org/show_bug.cgi?id=55456
1879 The solution comprises three major parts:
1880 - avoid multiple invocations of highlightSearchResults(), one per each nodeIds chunk.
1881 - cache highlighted node's innerHTML so that no extra _nodeTitleInfo() calls will be needed.
1882 - replace hand-written Text nodes iteration with a snapshot-based ".//text()" XPathResult.
1884 * inspector/front-end/ElementsPanel.js:
1885 (WebInspector.ElementsPanel.prototype.searchCanceled):
1886 (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
1887 * inspector/front-end/ElementsTreeOutline.js:
1888 (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
1889 (WebInspector.ElementsTreeElement.prototype.updateTitle):
1891 * inspector/front-end/utilities.js:
1894 2011-03-01 Adam Roben <aroben@apple.com>
1896 Fix multiple-definition linker warnings introduced by r79978 on Windows
1898 * rendering/RenderingAllInOne.cpp: Removed TextControlInnerElements.cpp, as it is now being
1899 compiled separately.
1901 2011-03-01 Andras Becsi <abecsi@webkit.org>
1903 Reviewed by Csaba Osztrogonác.
1905 [Qt] Clean up the project files and move common options to WebKit.pri.
1907 No new tests needed.
1909 * WebCore.pri: Move common options to WebKit.pri.
1910 * WebCore.pro: Ditto.
1912 2011-03-01 Steve Block <steveblock@google.com>
1914 Reviewed by Pavel Feldman.
1916 JNI code in Java bridge is not correctly guarded
1917 https://bugs.webkit.org/show_bug.cgi?id=55459
1919 No new tests, build fix only.
1921 * bridge/jni/v8/JNIBridgeV8.cpp:
1922 * bridge/jni/v8/JNIBridgeV8.h:
1923 * bridge/jni/v8/JNIUtilityPrivate.cpp:
1924 * bridge/jni/v8/JNIUtilityPrivate.h:
1925 * bridge/jni/v8/JavaClassV8.cpp:
1926 * bridge/jni/v8/JavaClassV8.h:
1927 * bridge/jni/v8/JavaInstanceV8.cpp:
1928 * bridge/jni/v8/JavaInstanceV8.h:
1929 * bridge/jni/v8/JavaNPObjectV8.cpp:
1930 * bridge/jni/v8/JavaNPObjectV8.h:
1932 2011-03-01 Steve Block <steveblock@google.com>
1934 Reviewed by Jeremy Orlow.
1936 Bridge.h should not include BridgeJSC.h
1937 https://bugs.webkit.org/show_bug.cgi?id=55212
1939 Instead, BridgeJSC.h should include Bridge.h and code should include
1940 BridgeJSC.h as appropriate.
1942 This prevents ports that use V8 from having to include JSC-specific
1943 files, even if the contents of those files are guarded.
1945 No new tests, cleanup only.
1947 * bindings/js/JSPluginElementFunctions.cpp:
1948 * bindings/js/ScriptControllerBrew.cpp:
1949 * bindings/js/ScriptControllerGtk.cpp:
1950 * bindings/js/ScriptControllerHaiku.cpp:
1951 * bindings/js/ScriptControllerQt.cpp:
1952 * bindings/js/ScriptControllerMac.mm:
1953 * bindings/js/ScriptControllerWin.cpp:
1954 * bindings/js/ScriptControllerWx.cpp:
1955 * bindings/js/ScriptInstance.h:
1956 * bindings/objc/WebScriptObject.mm:
1958 * bridge/c/c_class.h:
1959 * bridge/c/c_instance.h:
1960 * bridge/c/c_runtime.h:
1961 * bridge/jni/jsc/JNIBridgeJSC.h:
1962 * bridge/jni/jsc/JavaInstanceJSC.h:
1963 * bridge/jsc/BridgeJSC.h:
1964 * bridge/objc/objc_runtime.h:
1965 * bridge/qt/qt_class.h:
1966 * bridge/qt/qt_instance.h:
1967 * bridge/qt/qt_pixmapruntime.h:
1968 * bridge/qt/qt_runtime.h:
1969 * bridge/runtime_array.h:
1970 * bridge/runtime_method.h:
1971 * bridge/runtime_object.h:
1972 * bridge/runtime_root.cpp:
1973 * bridge/testbindings.cpp:
1974 * bridge/testbindings.mm:
1975 * bridge/testqtbindings.cpp:
1976 * page/win/FrameWin.cpp:
1977 * platform/graphics/wince/MediaPlayerProxy.cpp:
1978 * plugins/PluginView.cpp:
1979 * plugins/PluginViewNone.cpp:
1980 * plugins/gtk/PluginViewGtk.cpp:
1981 * plugins/mac/PluginViewMac.mm:
1982 * plugins/qt/PluginViewQt.cpp:
1983 * plugins/symbian/PluginViewSymbian.cpp:
1984 * plugins/win/PluginViewWin.cpp:
1986 2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
1988 Reviewed by Antti Koivisto.
1990 SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
1991 https://bugs.webkit.org/show_bug.cgi?id=54800
1993 Wrong handling of currentColor on inherit
1994 https://bugs.webkit.org/show_bug.cgi?id=38102
1996 Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
1997 two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
1998 It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
1999 once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
2000 accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
2001 type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).
2003 <g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
2004 <g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.
2006 In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
2007 as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
2008 when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
2009 available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
2010 exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.
2012 A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
2013 CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
2014 Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
2015 (Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)
2017 Add several new tests covering the patch.
2019 Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
2020 svg/animations/animate-color-fill-currentColor.html
2021 svg/custom/SVGPaint-mutate-attribute.svg
2022 svg/custom/SVGPaint-mutate-inline-style.svg
2024 * GNUMakefile.am: Add CSSMutableValue.h
2025 * WebCore.gypi: Ditto.
2026 * WebCore.xcodeproj/project.pbxproj: Ditto.
2027 * css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration.
2028 (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
2029 * css/CSSMutableStyleDeclaration.h: Add destructor.
2030 * css/CSSMutableValue.h: Added.
2031 (WebCore::CSSMutableValue::CSSMutableValue):
2032 (WebCore::CSSMutableValue::~CSSMutableValue):
2033 (WebCore::CSSMutableValue::isMutableValue):
2034 (WebCore::CSSMutableValue::node):
2035 (WebCore::CSSMutableValue::setNode):
2036 (WebCore::CSSMutableValue::setNeedsStyleRecalc):
2037 * css/CSSStyleDeclaration.cpp:
2038 (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
2040 (WebCore::CSSValue::isMutableValue): Return false, default.
2041 * css/SVGCSSComputedStyleDeclaration.cpp:
2042 (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects.
2043 (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
2044 * css/SVGCSSStyleSelector.cpp:
2045 (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
2046 * rendering/style/SVGRenderStyle.cpp:
2047 (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
2048 * rendering/style/SVGRenderStyle.h: Ditto.
2049 (WebCore::SVGRenderStyle::initialFillOpacity):
2050 (WebCore::SVGRenderStyle::initialFillPaintType):
2051 (WebCore::SVGRenderStyle::initialFillPaintColor):
2052 (WebCore::SVGRenderStyle::initialFillPaintUri):
2053 (WebCore::SVGRenderStyle::initialStrokeOpacity):
2054 (WebCore::SVGRenderStyle::initialStrokePaintType):
2055 (WebCore::SVGRenderStyle::initialStrokePaintColor):
2056 (WebCore::SVGRenderStyle::initialStrokePaintUri):
2057 (WebCore::SVGRenderStyle::initialStrokeMiterLimit):
2058 (WebCore::SVGRenderStyle::initialStopOpacity):
2059 (WebCore::SVGRenderStyle::initialFloodOpacity):
2060 (WebCore::SVGRenderStyle::setFillPaint):
2061 (WebCore::SVGRenderStyle::setStrokePaint):
2062 (WebCore::SVGRenderStyle::fillPaintType):
2063 (WebCore::SVGRenderStyle::fillPaintColor):
2064 (WebCore::SVGRenderStyle::fillPaintUri):
2065 (WebCore::SVGRenderStyle::strokePaintType):
2066 (WebCore::SVGRenderStyle::strokePaintColor):
2067 (WebCore::SVGRenderStyle::strokePaintUri):
2068 (WebCore::SVGRenderStyle::hasStroke):
2069 (WebCore::SVGRenderStyle::hasFill):
2070 * rendering/style/SVGRenderStyleDefs.cpp: Ditto.
2071 (WebCore::StyleFillData::StyleFillData):
2072 (WebCore::StyleFillData::operator==):
2073 (WebCore::StyleStrokeData::StyleStrokeData):
2074 (WebCore::StyleStrokeData::operator==):
2075 * rendering/style/SVGRenderStyleDefs.h: Ditto.
2076 * rendering/svg/RenderSVGResource.cpp: Ditto.
2077 (WebCore::requestPaintingResource):
2078 * rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
2079 (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
2080 * rendering/svg/SVGResources.cpp: Ditto.
2081 (WebCore::paintingResourceFromSVGPaint):
2082 (WebCore::SVGResources::buildCachedResources):
2083 * svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object.
2084 (WebCore::SVGColor::setRGBColor):
2085 (WebCore::SVGColor::setRGBColorICCColor):
2086 (WebCore::SVGColor::setColor):
2088 * svg/SVGPaint.cpp: Ditto.
2089 (WebCore::SVGPaint::setUri):
2090 (WebCore::SVGPaint::setPaint):
2093 2011-03-01 Andrey Adaikin <aandrey@google.com>
2095 Reviewed by Pavel Feldman.
2097 Web Inspector: [Text editor] Handle decorated lines in the editor
2098 https://bugs.webkit.org/show_bug.cgi?id=55373
2100 * inspector/front-end/SourceFrame.js:
2101 (WebInspector.SourceFrame.prototype._startEditing):
2102 (WebInspector.SourceFrame.prototype._endEditing):
2103 (WebInspector.SourceFrame.prototype._createTextViewer):
2104 * inspector/front-end/TextViewer.js:
2105 (WebInspector.TextEditorGutterPanel.prototype.textChanged):
2106 (WebInspector.TextEditorGutterChunk.prototype.addDecoration):
2107 (WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
2108 (WebInspector.TextEditorMainPanel.prototype.set readOnly):
2109 (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
2110 (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
2111 (WebInspector.TextEditorMainPanel.prototype._markDirtyLines):
2112 (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
2113 (WebInspector.TextEditorMainPanel.prototype._removeDecorationsInRange):
2114 (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
2115 (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
2116 (WebInspector.TextEditorMainChunk.prototype.addDecoration):
2117 (WebInspector.TextEditorMainChunk.prototype.removeDecoration):
2118 (WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
2119 (WebInspector.TextEditorMainChunk.prototype.get decorated):
2121 2011-03-01 Philippe Normand <pnormand@igalia.com>
2123 Unreviewed GTK build fix after r79978
2127 2011-03-01 Andras Becsi <abecsi@webkit.org>
2129 Unreviewed build fix.
2131 [Qt] Fix minimal build.
2133 No new tests needed.
2135 * WebCore.pri: Is included in WebKit2.pro, so XP_UNIX can remain here.
2137 2011-03-01 anthony taranto <anthony.taranto@gmail.com>
2139 Return undefined value from ScriptController::evaluate(), allowing the
2140 caller to distinguish between an error and an undefined return value.
2141 https://bugs.webkit.org/show_bug.cgi?id=51528
2143 * bindings/v8/ScriptController.cpp:
2145 2011-03-01 Roland Steiner <rolandsteiner@chromium.org>
2147 Reviewed by Kent Tamura.
2149 Bug 54853 - Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
2150 https://bugs.webkit.org/show_bug.cgi?id=54853
2152 Moving the files from rendering to html/shadow, with the exception of
2153 the class RenderTextControlInnerBlock, which I moved to RenderTextControlSingleLine
2154 (this place is not ideal, but only a temporary state during the larger refactoring
2157 No new tests. (refactoring)
2163 * WebCore.vcproj/WebCore.vcproj:
2164 * WebCore.xcodeproj/project.pbxproj:
2165 * html/shadow/TextControlInnerElements.cpp: Copied from Source/WebCore/rendering/TextControlInnerElements.cpp.
2166 * html/shadow/TextControlInnerElements.h: Copied from Source/WebCore/rendering/TextControlInnerElements.h.
2167 * rendering/RenderTextControlSingleLine.cpp:
2168 (WebCore::RenderTextControlInnerBlock::positionForPoint):
2169 * rendering/RenderTextControlSingleLine.h:
2170 (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
2171 (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
2172 * rendering/TextControlInnerElements.cpp: Removed.
2173 * rendering/TextControlInnerElements.h: Removed.
2175 2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
2177 Reviewed by Tony Chang.
2179 applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
2180 https://bugs.webkit.org/show_bug.cgi?id=55338
2182 Deployed EditingStyle in applyInlineStyleToPushDown and removeInlineStyleFromElement.
2184 Also added a convenience function EditingStyle::setProperty, which lazily instantiates
2185 new CSSMutableStyleDeclaration for m_mutableStyle.
2187 * editing/ApplyStyleCommand.cpp:
2188 (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle*.
2189 (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Ditto.
2190 (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
2191 (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls the above three functions.
2192 (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownInlineStyleAroundNode.
2193 * editing/ApplyStyleCommand.h:
2194 * editing/EditingStyle.cpp:
2195 (WebCore::HTMLElementEquivalent::addToStyle): Takes EditingStyle*; calls EditingStyle::setProperty.
2196 (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
2197 (WebCore::EditingStyle::setProperty): Added. This member function lazily instantiates
2198 new CSSMutableStyleDeclaration for m_mutableStyle.
2199 (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Takes EditingStyle*.
2200 (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Ditto.
2201 (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Ditto.
2202 * editing/EditingStyle.h: Added HTMLElementEquivalent and HTMLAttributeEquivalent as friends.
2203 (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Ditto.
2204 * editing/InsertTextCommand.cpp: Removed unnecessary includes.
2205 * editing/RemoveCSSPropertyCommand.h: Ditto.
2207 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
2209 Not reviewed: chromium rebuilds XMLViewer after noop. Fixed gyp file.
2211 * WebCore.gyp/WebCore.gyp:
2213 2011-02-28 David Levin <levin@chromium.org>
2215 Reviewed by Darin Adler.
2217 KURL should expose a referrer property.
2218 https://bugs.webkit.org/show_bug.cgi?id=55415
2220 No change in functionality so no new tests.
2222 * loader/FrameLoader.cpp:
2223 (WebCore::FrameLoader::setOutgoingReferrer): Refactor to put the majority
2224 of functionality in KURL::strippedForUseAsReferrer() so that this code can
2225 be more easily reused.
2226 * platform/KURL.cpp:
2227 (WebCore::KURL::strippedForUseAsReferrer): Converts the url to a string
2228 which is suitable for use as a referrer.
2231 2011-02-28 Chang Shu <cshu@webkit.org>
2233 Reviewed by Ryosuke Niwa.
2235 Remove the support of Frame::isContentEditable and its dependencies.
2236 https://bugs.webkit.org/show_bug.cgi?id=54292
2238 Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and
2239 Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result,
2240 Editor::clientIsEditable and its client-side implementation can be removed.
2243 * accessibility/AccessibilityRenderObject.cpp:
2244 (WebCore::AccessibilityRenderObject::isReadOnly):
2245 * editing/Editor.cpp:
2247 * editing/SelectionController.cpp:
2248 (WebCore::SelectionController::setSelectionFromNone):
2249 * html/HTMLElement.cpp:
2250 (WebCore::HTMLElement::isContentEditable):
2251 (WebCore::HTMLElement::isContentRichlyEditable):
2252 * page/DragController.cpp:
2253 (WebCore::DragController::operationForLoad):
2254 * page/EditorClient.h:
2258 2011-02-28 Kent Tamura <tkent@chromium.org>
2260 Reviewed by Darin Adler.
2262 Number type input cannot be set to empty string if it has an initial value
2263 https://bugs.webkit.org/show_bug.cgi?id=53744
2265 We need to distinguish null strings and empty strings for
2266 InputElementData::value. So InputType::sanitizeValue() also needs to
2269 * dom/InputElement.h: Add a comment to InputElementData::value and
2270 setValue about null strings.
2271 * html/InputType.h: Add a comment to sanitizeValue about null strings.
2272 * html/NumberInputType.cpp:
2273 (WebCore::NumberInputType::sanitizeValue): Returns a null string if the
2274 proposed value is a null string. Returning an empty string if the
2275 proposed value is not a number.
2277 2011-02-28 Kent Tamura <tkent@chromium.org>
2279 Reviewed by Darin Adler.
2281 Number type input should not handle mouse wheel events if it has no focus.
2282 https://bugs.webkit.org/show_bug.cgi?id=53638
2284 * html/TextFieldInputType.cpp:
2285 (WebCore::TextFieldInputType::handleWheelEventForSpinButton): Check focused().
2287 2011-02-28 Noel Gordon <noel.gordon@gmail.com>
2288 Reviewed by James Robinson.
2290 [chromium] GradientSkia: use the common Gradient stop sorting methods.
2291 https://bugs.webkit.org/show_bug.cgi?id=54625
2293 Remove a FIXME: call the Gradient.cpp stop storting routines, no need
2294 to duplicate that code herein.
2296 No change in behavior, so no new tests.
2298 * platform/graphics/skia/GradientSkia.cpp:
2299 (WebCore::Gradient::platformGradient):
2301 2011-02-28 Steve Block <steveblock@google.com>
2303 Reviewed by Jeremy Orlow.
2305 JNI code should include <jni.h> on non-OSX platforms.
2306 https://bugs.webkit.org/show_bug.cgi?id=55219
2308 On Mac we need to include <JavaVM/jni.h> as this is a framework
2309 include. We include jni.h through JNIUtility.h to minimize the
2312 No new tests, build fix only.
2314 * WebCore.xcodeproj/project.pbxproj
2315 * bridge/jni/JNIUtility.h:
2316 * bridge/jni/jni_jsobject.h:
2317 * bridge/jni/jsc/JNIBridgeJSC.h:
2318 * bridge/jni/jsc/JavaInstanceJSC.h:
2319 * bridge/jni/v8/JavaInstanceV8.h:
2321 2011-02-28 Nebojsa Sabovic <neb@chromium.org>
2323 Reviewed by James Robinson.
2325 [chromium] Pepper plugins render upside down
2326 https://bugs.webkit.org/show_bug.cgi?id=55101
2328 No layout tests for pepper plugins (yet).
2330 * platform/graphics/chromium/PluginLayerChromium.h:
2332 2011-02-28 Tony Gentilcore <tonyg@chromium.org>
2334 Reviewed by Adam Barth.
2336 Follow HTML5 spec for document.open() a little more closely
2337 https://bugs.webkit.org/show_bug.cgi?id=55392
2339 See: 3.5.1.4 at http://www.whatwg.org/specs/web-apps/current-work/#dom-document-open.
2341 The second return check matches the spec. The first return check (isExecutingScript())
2342 was left in place because without it, fast/tokenizer/write-external-script-open.html
2343 would fail. It also possible there is a spec bug because FF4 crashes on that test and
2344 IE9 prints "FAILURE." The isLoadingMainResource() check was removed because the main
2345 resource is always loading while parser->isParsing().
2347 Test: fast/parser/double-write-from-closed-iframe.html
2350 (WebCore::Document::open):
2352 2011-02-28 Avi Drissman <avi@google.com>
2354 Reviewed by James Robinson.
2356 WebCursorInfo needs to match enums in platform/Cursor.h
2357 https://bugs.webkit.org/show_bug.cgi?id=55094
2359 * platform/chromium/CursorChromium.cpp:
2360 (WebCore::grabCursor):
2361 (WebCore::grabbingCursor):
2362 * platform/chromium/PlatformCursor.h:
2364 2011-02-28 Jia Pu <jpu@apple.com>
2366 Reviewed by Darin Adler.
2368 [Mac] Make "Change back to …" contextual menu item work with new autocorrection.
2369 https://bugs.webkit.org/show_bug.cgi?id=55396
2370 <rdar://problem/8836093>
2372 The change in InlineTextBox.cpp fixes a bug, where the rectangle of Replacement marker isn't
2373 calculated. We need this to do hit test when deciding whether to show "Change back to ..." on
2376 The change in Editor.cpp is for notifying spellchecker about the reversion whenever "Change
2377 back to ..." is clicked.
2379 * editing/Editor.cpp:
2380 (WebCore::Editor::changeBackToReplacedString):
2381 * rendering/InlineTextBox.cpp:
2382 (WebCore::InlineTextBox::paintDocumentMarkers):
2384 2011-02-28 Victoria Kirst <vrk@google.com>
2386 Reviewed by Kenneth Russell.
2388 [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium
2389 https://bugs.webkit.org/show_bug.cgi?id=55269
2391 Mesa does not support mapTexSubImage2D, so this change lets
2392 GPU-accelerated video work with DRT layout tests.
2394 * platform/graphics/chromium/VideoLayerChromium.cpp:
2395 (WebCore::VideoLayerChromium::updateTexture):
2397 2011-02-28 David Hyatt <hyatt@apple.com>
2399 Reviewed by Dan Bernstein.
2401 https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text. Change staticX and staticY
2402 to be staticInlinePosition and staticBlockPosition. Patch all of the computations involving these variables to be writing
2403 mode aware. Mixed writing modes are not yet supported.
2405 Added new tests in fast/block/positioning/auto.
2407 * rendering/RenderBlock.cpp:
2408 (WebCore::RenderBlock::adjustPositionedBlock):
2409 (WebCore::RenderBlock::layoutPositionedObjects):
2410 * rendering/RenderBlock.h:
2411 (WebCore::RenderBlock::startOffsetForLine):
2412 * rendering/RenderBlockLineLayout.cpp:
2413 (WebCore::RenderBlock::appendRunsForObject):
2414 (WebCore::setStaticPositions):
2415 (WebCore::RenderBlock::skipTrailingWhitespace):
2416 (WebCore::RenderBlock::skipLeadingWhitespace):
2417 (WebCore::RenderBlock::findNextLineBreak):
2418 * rendering/RenderBox.cpp:
2419 (WebCore::RenderBox::positionLineBox):
2420 (WebCore::computeInlineStaticDistance):
2421 (WebCore::RenderBox::computePositionedLogicalWidth):
2422 (WebCore::computeBlockStaticDistance):
2423 (WebCore::RenderBox::computePositionedLogicalHeight):
2424 (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
2425 (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
2426 * rendering/RenderBoxModelObject.h:
2427 (WebCore::RenderBoxModelObject::borderAndPaddingLogicalLeft):
2428 (WebCore::RenderBoxModelObject::borderAndPaddingStart):
2429 (WebCore::RenderBoxModelObject::borderLogicalLeft):
2430 (WebCore::RenderBoxModelObject::borderLogicalRight):
2431 * rendering/RenderFlexibleBox.cpp:
2432 (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2433 (WebCore::RenderFlexibleBox::layoutVerticalBox):
2434 * rendering/RenderInline.cpp:
2435 (WebCore::RenderInline::relativePositionedInlineOffset):
2436 * rendering/RenderLayer.cpp:
2437 (WebCore::RenderLayer::RenderLayer):
2438 * rendering/RenderLayer.h:
2439 (WebCore::RenderLayer::staticInlinePosition):
2440 (WebCore::RenderLayer::staticBlockPosition):
2441 (WebCore::RenderLayer::setStaticInlinePosition):
2442 (WebCore::RenderLayer::setStaticBlockPosition):
2443 * rendering/style/RenderStyle.h:
2444 (WebCore::InheritedFlags::hasAutoLeftAndRight):
2445 (WebCore::InheritedFlags::hasAutoTopAndBottom):
2446 (WebCore::InheritedFlags::hasStaticInlinePosition):
2447 (WebCore::InheritedFlags::hasStaticBlockPosition):
2449 2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
2451 Reviewed by Anders Carlsson.
2453 [Qt][WK2] Plugin initialization
2454 https://bugs.webkit.org/show_bug.cgi?id=48127
2456 No function change so no new tests.
2458 * WebCore.pri: Lift the definition of the XP_UNIX macro
2459 from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
2461 2011-02-28 Dean Jackson <dino@apple.com>
2463 Reviewed by Eric Carlson.
2465 https://bugs.webkit.org/show_bug.cgi?id=55239
2467 Allow webkitEnterFullScreen to be called from outside
2468 a user gesture, but only when the correct restrictions
2469 have been lifted in WebCore. Add a new restriction type
2470 for this situation. Meanwhile, expose the current
2471 restrictions externally from HTMLMediaElement, so that
2472 clients can easily set restrictions on their port.
2474 No new tests. This doesn't change existing behavior. Some
2475 WebKit clients may lift the restriction.
2477 * html/HTMLMediaElement.cpp:
2478 (WebCore::HTMLMediaElement::HTMLMediaElement):
2479 - ensure restrictions initialize with fullscreen restricted
2480 * html/HTMLMediaElement.h:
2481 (WebCore::HTMLMediaElement::requireUserGestureForLoad):
2482 (WebCore::HTMLMediaElement::requireUserGestureForRateChange):
2483 (WebCore::HTMLMediaElement::requireUserGestureForFullScreen):
2484 (WebCore::HTMLMediaElement::setBehaviorRestrictions):
2485 - new methods to expose the current restrictions
2486 * html/HTMLVideoElement.cpp:
2487 (WebCore::HTMLVideoElement::webkitEnterFullscreen):
2489 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
2491 Unreviewed, rolling out r78789.
2492 http://trac.webkit.org/changeset/78789
2493 https://bugs.webkit.org/show_bug.cgi?id=55409
2495 Incorrect canvas fallback implementation (Requested by
2496 inferno-sec on #webkit).
2498 * accessibility/AccessibilityObject.h:
2499 * accessibility/AccessibilityRenderObject.cpp:
2500 (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
2501 (WebCore::AccessibilityRenderObject::canHaveChildren):
2502 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2504 * accessibility/mac/AccessibilityObjectWrapper.mm:
2505 * html/HTMLFormControlElement.cpp:
2506 (WebCore::HTMLFormControlElement::isFocusable):
2507 * rendering/RenderHTMLCanvas.cpp:
2508 * rendering/RenderHTMLCanvas.h:
2509 * rendering/RenderObject.cpp:
2510 (WebCore::RenderObject::repaint):
2511 * rendering/RenderTreeAsText.cpp:
2514 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
2516 Unreviewed, rolling out r79425.
2517 http://trac.webkit.org/changeset/79425
2518 https://bugs.webkit.org/show_bug.cgi?id=55406
2520 Incorrect canvas fallback implementation. (Requested by
2521 inferno-sec on #webkit).
2523 * rendering/RenderHTMLCanvas.cpp:
2524 (WebCore::RenderHTMLCanvas::nodeAtPoint):
2526 2011-02-28 Adam Klein <adamk@chromium.org>
2528 Reviewed by Adam Barth.
2530 [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
2531 https://bugs.webkit.org/show_bug.cgi?id=54774
2533 See http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods
2534 for the spec implemented by this patch.
2536 Test: fast/filesystem/resolve-uri.html
2538 * fileapi/DOMFileSystemBase.cpp:
2539 (WebCore::DOMFileSystemBase::crackFileSystemURL):
2540 * fileapi/DOMFileSystemBase.h:
2541 Added constants for "temporary" and "persistent".
2542 * fileapi/EntryBase.cpp:
2543 Replace hardcoded strings with aforementioned constants.
2544 * fileapi/FileSystemCallbacks.cpp:
2545 (WebCore::ResolveURICallbacks::create):
2546 (WebCore::ResolveURICallbacks::ResolveURICallbacks):
2547 (WebCore::ResolveURICallbacks::didOpenFileSystem):
2548 Chains a call of openFileSystem to calls to getDirectory/getFile.
2549 * fileapi/FileSystemCallbacks.h:
2550 * fileapi/LocalFileSystem.cpp:
2551 (WebCore::LocalFileSystem::readFileSystem):
2552 * fileapi/LocalFileSystem.h:
2553 Remove size argument from readFileSystem()
2554 * page/DOMWindow.cpp:
2555 (WebCore::DOMWindow::resolveLocalFileSystemURI):
2557 * page/DOMWindow.idl:
2559 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
2561 Reviewed by Oliver Hunt.
2563 Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
2565 * bridge/qt/qt_runtime.cpp:
2566 (JSC::Bindings::QtConnectionObject::execute):
2568 2011-02-25 David Levin <levin@chromium.org>
2570 Reviewed by Darin Adler.
2572 Remove some duplicate code from KURLGoogle.cpp
2573 https://bugs.webkit.org/show_bug.cgi?id=55266
2575 No change in functionality so no new tests.
2577 * WebCore.gyp/WebCore.gyp: Make KURL.cpp get built by Chromium.
2578 * platform/KURL.cpp:
2579 Simply moved #include's and some code that was identical (i.e.
2580 had been copied) to KURLGoogle.cpp outside of ifdef !USE(GOOGLEURL)
2581 to reduce duplication.
2582 * platform/KURLGoogle.cpp:
2583 Removed the duplicate code.
2585 2011-02-28 Oliver Hunt <oliver@apple.com>
2587 Reviewed by Gavin Barraclough.
2589 Make ScopeChainNode GC allocated
2590 https://bugs.webkit.org/show_bug.cgi?id=55283
2592 Update WebCore to deal with the absence of the ScopeChain
2595 * ForwardingHeaders/runtime/ScopeChain.h: Added.
2596 * bindings/js/JSHTMLElementCustom.cpp:
2597 (WebCore::JSHTMLElement::pushEventHandlerScope):
2598 * bindings/js/JSJavaScriptCallFrameCustom.cpp:
2599 (WebCore::JSJavaScriptCallFrame::scopeChain):
2600 (WebCore::JSJavaScriptCallFrame::scopeType):
2601 * bindings/js/JSLazyEventListener.cpp:
2602 (WebCore::JSLazyEventListener::initializeJSFunction):
2603 * bindings/js/JSMainThreadExecState.h:
2604 (WebCore::JSMainThreadExecState::evaluate):
2605 * bindings/js/JSNodeCustom.cpp:
2606 (WebCore::JSNode::pushEventHandlerScope):
2607 * bindings/js/JavaScriptCallFrame.cpp:
2608 (WebCore::JavaScriptCallFrame::scopeChain):
2609 * bindings/js/JavaScriptCallFrame.h:
2610 * bindings/scripts/CodeGeneratorJS.pm:
2611 * bridge/c/c_class.cpp:
2612 * bridge/c/c_runtime.cpp:
2613 * bridge/jni/JNIBridge.cpp:
2614 * bridge/qt/qt_runtime.cpp:
2615 (JSC::Bindings::QtConnectionObject::execute):
2616 * plugins/PluginViewNone.cpp:
2618 2011-02-28 Chang Shu <cshu@webkit.org>
2620 Reviewed by Adele Peterson.
2622 REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
2623 https://bugs.webkit.org/show_bug.cgi?id=55323
2625 Draw focus ring on selected items only if spatial navigation is enabled.
2627 Test: fast/forms/select-listbox-multiple-no-focusring.html
2629 * rendering/RenderBlock.h:
2630 * rendering/RenderListBox.cpp:
2631 (WebCore::RenderListBox::addFocusRingRects):
2633 2011-02-28 Abhishek Arya <inferno@chromium.org>
2635 Reviewed by Anders Carlsson.
2637 We can cancel the plugin load and fail with error before m_manualStream
2638 got a chance to initialize in PluginView::didReceiveResponse. This can
2639 happen when we run pending document onload events during plugin load that
2640 remove the frame from underneath. So, change the assert into a null check.
2641 https://bugs.webkit.org/show_bug.cgi?id=55307
2643 * plugins/PluginView.cpp:
2644 (WebCore::PluginView::didFail):
2646 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
2648 Reviewed by Alexey Proskuryakov.
2650 Build fix for Intel ICC Compiler.
2651 https://bugs.webkit.org/show_bug.cgi?id=55221
2653 The virtual inheritance seems to confuse ICC.
2654 Anything that links with webkit has an undefined reference otherwise.
2656 * svg/SVGTransformable.cpp:
2657 (WebCore::SVGTransformable::~SVGTransformable):
2658 * svg/SVGTransformable.h:
2660 2011-02-28 Sergio Villar Senin <svillar@igalia.com>
2662 Reviewed by Martin Robinson.
2664 [Gtk] Resource size is incorrectly reported to WebCore
2665 https://bugs.webkit.org/show_bug.cgi?id=53228
2667 When calling didReceiveData we are sending an invalid value for
2668 lengthReceived. Sometimes we were even passing a boolean value instead of the
2669 expected integer. We should pass the size of the received data instead of the
2670 total amount of data received.
2672 * platform/network/ResourceHandleInternal.h:
2673 (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2674 * platform/network/soup/ResourceHandleSoup.cpp:
2675 (WebCore::gotChunkCallback):
2676 (WebCore::sendRequestCallback):
2677 (WebCore::readCallback):
2679 2011-02-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2681 Reviewed by Dan Bernstein.
2683 Cleanup the include guard form an Objective-C files
2684 https://bugs.webkit.org/show_bug.cgi?id=55379
2686 Normally Objective-C files do not need include guard.
2687 r76916 introduced an include guard in EmptyProtocolDefinitions.h.
2688 The guard is no longer needed after r76991.
2690 No new tests as there is no new functionality.
2692 * platform/mac/EmptyProtocolDefinitions.h:
2694 2011-02-28 Pavel Podivilov <podivilov@chromium.org>
2696 Reviewed by Pavel Feldman.
2698 Web Inspector: [REGRESSION] no resources in scripts panel because debugger is enabled too early.
2699 https://bugs.webkit.org/show_bug.cgi?id=55389
2701 * inspector/InspectorAgent.cpp:
2702 (WebCore::InspectorAgent::populateScriptObjects):
2703 * inspector/InspectorDebuggerAgent.cpp:
2704 (WebCore::InspectorDebuggerAgent::setFrontend):
2705 (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
2706 * inspector/InspectorDebuggerAgent.h:
2708 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
2710 Unreviewed, rolling out r79877.
2711 http://trac.webkit.org/changeset/79877
2712 https://bugs.webkit.org/show_bug.cgi?id=55388
2714 Breaks chromium build (Requested by antonm_ on #webkit).
2717 * platform/graphics/chromium/ContentLayerChromium.cpp:
2718 (WebCore::ContentLayerChromium::updateContentsIfDirty):
2719 (WebCore::ContentLayerChromium::resizeUploadBufferForImage):
2720 (WebCore::ContentLayerChromium::resizeUploadBuffer):
2721 (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels):
2722 (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels):
2723 (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
2724 (WebCore::ContentLayerChromium::updateTextureIfNeeded):
2725 (WebCore::ContentLayerChromium::draw):
2726 * platform/graphics/chromium/ContentLayerChromium.h:
2727 * platform/graphics/chromium/ImageLayerChromium.cpp:
2728 (WebCore::ImageLayerChromium::updateContentsIfDirty):
2729 * platform/graphics/chromium/ImageLayerChromium.h:
2730 * platform/graphics/chromium/LayerTilerChromium.cpp:
2731 (WebCore::LayerTilerChromium::contentRectToTileIndices):
2732 (WebCore::LayerTilerChromium::update):
2733 * platform/graphics/chromium/LayerTilerChromium.h:
2734 * platform/graphics/chromium/PlatformCanvas.cpp: Removed.
2735 * platform/graphics/chromium/PlatformCanvas.h: Removed.
2736 * platform/graphics/chromium/PlatformImage.cpp: Removed.
2737 * platform/graphics/chromium/PlatformImage.h: Removed.
2739 2011-02-28 Pavel Podivilov <podivilov@chromium.org>
2741 Reviewed by Pavel Feldman.
2743 Web Inspector: add live edit test.
2744 https://bugs.webkit.org/show_bug.cgi?id=55360
2746 Test: inspector/debugger/live-edit.html
2748 * inspector/front-end/SourceFrame.js:
2749 (WebInspector.SourceFrame.prototype._doubleClick):
2750 (WebInspector.SourceFrame.prototype._didEditLine):
2752 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
2754 Not reviewed. Follow up to r79858, removing optimistic assertion that fails on debug bot.
2756 * inspector/InspectorBrowserDebuggerAgent.cpp:
2757 (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
2759 2011-02-25 Adrienne Walker <enne@google.com>
2761 Reviewed by James Robinson.
2763 [chromium] Abstract "pixels with a graphics context" into its own class
2764 https://bugs.webkit.org/show_bug.cgi?id=55259
2766 This creates new PlatformCanvas/PlatformImage classes which wrap
2767 all of the #ifdef Skia/Cg warts from the compositor. All classes
2768 (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
2769 modified to use these abstractions.
2771 Tests: LayoutTests/compositing
2774 * platform/graphics/chromium/ContentLayerChromium.cpp:
2775 (WebCore::ContentLayerChromium::updateContentsIfDirty):
2776 (WebCore::ContentLayerChromium::resizeUploadBuffer):
2777 (WebCore::ContentLayerChromium::updateTextureIfNeeded):
2778 (WebCore::ContentLayerChromium::updateTexture):
2779 (WebCore::ContentLayerChromium::draw):
2780 * platform/graphics/chromium/ContentLayerChromium.h:
2781 * platform/graphics/chromium/ImageLayerChromium.cpp:
2782 (WebCore::ImageLayerChromium::updateContentsIfDirty):
2783 (WebCore::ImageLayerChromium::updateTextureIfNeeded):
2784 * platform/graphics/chromium/ImageLayerChromium.h:
2785 * platform/graphics/chromium/LayerTilerChromium.cpp:
2786 (WebCore::LayerTilerChromium::contentRectToTileIndices):
2787 (WebCore::LayerTilerChromium::update):
2788 (WebCore::LayerTilerChromium::updateFromPixels):
2789 * platform/graphics/chromium/LayerTilerChromium.h:
2790 * platform/graphics/chromium/PlatformCanvas.cpp: Added.
2791 (WebCore::PlatformCanvas::PlatformCanvas):
2792 (WebCore::PlatformCanvas::~PlatformCanvas):
2793 (WebCore::PlatformCanvas::resize):
2794 (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
2795 (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
2796 (WebCore::PlatformCanvas::Painter::Painter):
2797 (WebCore::PlatformCanvas::Painter::~Painter):
2798 * platform/graphics/chromium/PlatformCanvas.h: Added.
2799 (WebCore::PlatformCanvas::AutoLocker::pixels):
2800 (WebCore::PlatformCanvas::Painter::context):
2801 (WebCore::PlatformCanvas::size):
2802 * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
2803 (WebCore::PlatformImage::PlatformImage):
2804 (WebCore::PlatformImage::updateFromImage):
2805 * platform/graphics/chromium/PlatformImage.h: Added.
2806 (WebCore::PlatformImage::pixels):
2807 (WebCore::PlatformImage::size):
2809 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
2811 Unreviewed, rolling out r79784.
2812 http://trac.webkit.org/changeset/79784
2813 https://bugs.webkit.org/show_bug.cgi?id=55386
2815 This change causes lots of assertion failures in Debug builds
2816 (Requested by aroben on #webkit).
2818 * css/CSSStyleSelector.cpp:
2819 (WebCore::convertToLength):
2820 (WebCore::CSSStyleSelector::applyProperty):
2821 (WebCore::CSSStyleSelector::createTransformOperations):
2822 * platform/Length.h:
2823 (WebCore::Length::Length):
2824 (WebCore::Length::operator==):
2825 (WebCore::Length::operator!=):
2826 (WebCore::Length::rawValue):
2827 (WebCore::Length::type):
2828 (WebCore::Length::quirk):
2829 (WebCore::Length::setValue):
2830 (WebCore::Length::setRawValue):
2831 (WebCore::Length::calcFloatValue):
2832 (WebCore::Length::isZero):
2833 (WebCore::Length::blend):
2834 * rendering/AutoTableLayout.cpp:
2835 (WebCore::AutoTableLayout::recalcColumn):
2836 (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
2837 * rendering/FixedTableLayout.cpp:
2838 (WebCore::FixedTableLayout::calcWidthArray):
2840 2011-02-28 Andreas Kling <kling@webkit.org>
2842 Reviewed by Darin Adler.
2844 Use Frame::ownerElement() directly where appropriate.
2845 https://bugs.webkit.org/show_bug.cgi?id=55385
2847 Don't take the roundabout way through frame->document->ownerElement
2848 which just checks that the document->frame is non-null.
2850 No new test, refactoring only.
2852 * editing/SelectionController.cpp:
2853 (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
2854 * loader/FrameLoader.cpp:
2855 (WebCore::FrameLoader::loadWithDocumentLoader):
2856 * page/DOMWindow.cpp:
2857 (WebCore::DOMWindow::dispatchLoadEvent):
2858 * page/EventHandler.cpp:
2859 (WebCore::EventHandler::scrollRecursively):
2860 (WebCore::EventHandler::logicalScrollRecursively):
2861 * page/FrameView.cpp:
2862 (WebCore::FrameView::init):
2863 (WebCore::FrameView::layout):
2864 (WebCore::FrameView::repaintContentRectangle):
2865 (WebCore::FrameView::windowClipRect):
2866 (WebCore::FrameView::paintContents):
2868 2011-02-28 Pavel Podivilov <podivilov@chromium.org>
2870 Reviewed by Pavel Feldman.
2872 Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
2873 https://bugs.webkit.org/show_bug.cgi?id=55377
2875 * inspector/front-end/ScriptsPanel.js:
2876 (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
2877 (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
2878 (WebInspector.ScriptsPanel.prototype._createSourceFrame):
2879 (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
2881 2011-02-28 Patrick Gansterer <paroga@webkit.org>
2883 Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r79569.
2885 * svg/SVGDocumentExtensions.cpp:
2886 (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
2888 2011-02-28 Renata Hodovan <reni@webkit.org>
2890 Reviewed by Andreas Kling.
2892 Optimize parameter transmissions in FEConvolveMatrix.
2893 https://bugs.webkit.org/show_bug.cgi?id=55381
2895 Parameter transmission via reference is more efficient than with copy. So they are substituted.
2897 No new tests are needed since this is a refactoring.
2899 * platform/graphics/filters/FEConvolveMatrix.cpp:
2900 (WebCore::FEConvolveMatrix::setKernelSize):
2901 (WebCore::FEConvolveMatrix::setTargetOffset):
2902 (WebCore::FEConvolveMatrix::setKernelUnitLength):
2903 * platform/graphics/filters/FEConvolveMatrix.h:
2905 2011-02-28 Yury Semikhatsky <yurys@chromium.org>
2907 Unreviewed. Fix Chromium tests failures due to r79858.
2909 * inspector/InspectorAgent.cpp:
2910 (WebCore::InspectorAgent::inspectedPageDestroyed):
2912 2011-02-28 Vsevolod Vlasov <vsevik@chromium.org>
2914 Reviewed by Pavel Feldman.
2916 XML without style should render as syntax-highlighted source.
2917 https://bugs.webkit.org/show_bug.cgi?id=13807
2919 XML tree view mode implemented. If XML does not have any style
2920 information, it is rendered as highlighted source with collapsable
2923 Tests: fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml
2924 fast/encoding/dumpAsText/utf-16-no-bom.xml
2925 http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
2926 http/tests/xmlviewer/dumpAsText/frames.html
2927 http/tests/xmlviewer/dumpAsText/mathml.xml
2928 http/tests/xmlviewer/dumpAsText/svg.xml
2929 http/tests/xmlviewer/dumpAsText/wml.xml
2930 http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
2931 http/tests/xmlviewer/dumpAsText/xlink.xml
2932 http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
2933 http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
2934 http/tests/xmlviewer/dumpAsText/xmlviewer.xml
2935 http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
2936 http/tests/xmlviewer/dumpAsText/xul.xml
2937 svg/hixie/error/dumpAsText/004.xml
2938 svg/hixie/error/dumpAsText/005.xml
2941 * DerivedSources.make:
2943 * WebCore.gyp/WebCore.gyp:
2945 * WebCore.vcproj/WebCore.vcproj:
2946 * WebCore.xcodeproj/project.pbxproj:
2947 * css/CSSStyleSelector.cpp:
2948 (WebCore::CSSStyleSelector::matchUARules):
2950 (WebCore::Document::Document):
2951 (WebCore::Document::createElement):
2953 (WebCore::Document::usesViewSourceStyles):
2954 (WebCore::Document::setUsesViewSourceStyles):
2955 (WebCore::Document::sawElementsInKnownNamespaces):
2956 * dom/XMLDocumentParser.h:
2957 * dom/XMLDocumentParserLibxml2.cpp:
2958 (WebCore::XMLDocumentParser::XMLDocumentParser):
2959 (WebCore::XMLDocumentParser::processingInstruction):
2960 (WebCore::XMLDocumentParser::initializeParserContext):
2961 (WebCore::XMLDocumentParser::doEnd):
2962 * dom/XMLDocumentParserQt.cpp:
2963 (WebCore::XMLDocumentParser::XMLDocumentParser):
2964 (WebCore::XMLDocumentParser::initializeParserContext):
2965 (WebCore::XMLDocumentParser::parseProcessingInstruction):
2966 * html/HTMLViewSourceDocument.cpp:
2967 (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
2968 * xml/XMLTreeViewer.cpp: Added.
2969 (WebCore::XMLTreeViewer::XMLTreeViewer):
2970 (WebCore::XMLTreeViewer::hasNoStyleInformation):
2971 (WebCore::XMLTreeViewer::transformDocumentToTreeView):
2972 * xml/XMLTreeViewer.h: Added.
2973 (WebCore::XMLTreeViewer::~XMLTreeViewer):
2974 * xml/XMLViewer.xsl: Added.
2975 * xml/XSLStyleSheet.h:
2976 (WebCore::XSLStyleSheet::createForXMLTreeViewer):
2978 2011-02-28 Yury Semikhatsky <yurys@chromium.org>
2980 Reviewed by Pavel Feldman.
2982 Web Inspector: debugger agents should have same livetime as InspectorAgent
2983 https://bugs.webkit.org/show_bug.cgi?id=55369
2985 DOM and JS debugger agents are now created in InspectorAgent's constructor and owned
2986 by the agent. Debugger state is cleared on frontend disconnect.
2988 * inspector/Inspector.idl:
2989 * inspector/InspectorAgent.cpp:
2990 (WebCore::InspectorAgent::InspectorAgent):
2991 (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2992 (WebCore::InspectorAgent::setFrontend):
2993 (WebCore::InspectorAgent::disconnectFrontend):
2994 (WebCore::InspectorAgent::populateScriptObjects):
2995 (WebCore::InspectorAgent::didCommitLoad):
2996 (WebCore::InspectorAgent::showScriptsPanel):
2997 * inspector/InspectorAgent.h:
2998 * inspector/InspectorBrowserDebuggerAgent.cpp:
2999 (WebCore::InspectorBrowserDebuggerAgent::create):
3000 (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
3001 (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
3002 (WebCore::InspectorBrowserDebuggerAgent::debuggerWasEnabled):
3003 (WebCore::InspectorBrowserDebuggerAgent::debuggerWasDisabled):
3004 (WebCore::InspectorBrowserDebuggerAgent::disable):
3005 (WebCore::InspectorBrowserDebuggerAgent::setFrontend):
3006 (WebCore::InspectorBrowserDebuggerAgent::clearFrontend):
3007 (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
3008 (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
3009 (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
3010 (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
3011 (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
3012 (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
3013 (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
3014 (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
3015 (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
3016 (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
3017 (WebCore::InspectorBrowserDebuggerAgent::clear):
3018 * inspector/InspectorBrowserDebuggerAgent.h:
3019 * inspector/InspectorController.cpp:
3020 (WebCore::InspectorController::debuggerEnabled):
3021 (WebCore::InspectorController::showAndEnableDebugger):
3022 (WebCore::InspectorController::disableDebugger):
3023 * inspector/InspectorDebuggerAgent.cpp:
3024 (WebCore::InspectorDebuggerAgent::create):
3025 (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
3026 (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
3027 (WebCore::InspectorDebuggerAgent::startUserInitiatedDebugging):
3028 (WebCore::InspectorDebuggerAgent::enable):
3029 (WebCore::InspectorDebuggerAgent::disable):
3030 (WebCore::InspectorDebuggerAgent::enabled):
3031 (WebCore::InspectorDebuggerAgent::restore):
3032 (WebCore::InspectorDebuggerAgent::setFrontend):
3033 (WebCore::InspectorDebuggerAgent::clearFrontend):
3034 (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
3035 (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
3036 (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
3037 (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
3038 (WebCore::InspectorDebuggerAgent::currentCallFrames):
3039 (WebCore::InspectorDebuggerAgent::didParseSource):
3040 (WebCore::InspectorDebuggerAgent::clear):
3041 * inspector/InspectorDebuggerAgent.h:
3042 (WebCore::InspectorDebuggerAgent::enable):
3043 (WebCore::InspectorDebuggerAgent::disable):
3044 (WebCore::InspectorDebuggerAgent::Listener::~Listener):
3045 (WebCore::InspectorDebuggerAgent::setListener):
3046 * inspector/InspectorInstrumentation.cpp:
3047 (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
3048 (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
3049 (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
3050 (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
3051 (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
3052 (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
3053 (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
3054 * inspector/front-end/DebuggerModel.js:
3055 (WebInspector.DebuggerModel.prototype.enableDebugger):
3056 (WebInspector.DebuggerModel.prototype.disableDebugger):
3058 2011-02-28 Renata Hodovan <reni@webkit.org>
3060 Reviewed by Andreas Kling.
3062 FECompositeElement changes doesn't require relayout.
3063 https://bugs.webkit.org/show_bug.cgi?id=55367
3065 When the FECompositeElement receives an update message but the given value remains the same we don't need
3066 to relayout the filter.
3068 No new tests are needed because this modification is covered by the dynamic update tests of FEComposite.
3070 * platform/graphics/filters/FEComposite.cpp:
3071 (WebCore::FEComposite::setOperation):
3072 (WebCore::FEComposite::setK1):
3073 (WebCore::FEComposite::setK2):
3074 (WebCore::FEComposite::setK3):
3075 (WebCore::FEComposite::setK4):
3076 * platform/graphics/filters/FEComposite.h:
3077 * svg/SVGFECompositeElement.cpp:
3078 (WebCore::SVGFECompositeElement::setFilterEffectAttribute):
3079 (WebCore::SVGFECompositeElement::svgAttributeChanged):
3080 * svg/SVGFECompositeElement.h:
3082 2011-02-28 Andreas Kling <kling@webkit.org>
3084 Reviewed by Kenneth Rohde Christiansen.
3086 FrameLoader: Reorder early-returns in checkCompleted()
3087 https://bugs.webkit.org/show_bug.cgi?id=55366
3089 Check allChildrenAreComplete() last, since it's the most expensive.
3091 * loader/FrameLoader.cpp:
3092 (WebCore::FrameLoader::checkCompleted):
3094 2011-02-28 Ryosuke Niwa <rniwa@webkit.org>
3096 Reviewed by Kent Tamura.
3098 Range::processContents needs cleanup
3099 https://bugs.webkit.org/show_bug.cgi?id=51006
3101 Refactored Range::processContents. Extracted childOfCommonRootBeforeOffset from processContents
3102 which is used to find processStart and processEnd respectively. In the case of processStart,
3103 we use the next sibling of the node returned by childOfCommonRootBeforeOffset when m_start is not
3104 the common root because copying m_start's ancestors will result in processing too much contents.
3106 Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.
3108 In addition, lengthOfContentsInNode was modified to return the correct length instead of
3109 numeric_limits<unsigned>::max() because the convention that processContentsBetweenOffsets automatically
3110 corrects the length when endOffset is numeric_limits<unsigned>::max() seemed more confusing than
3111 having two switch statements that need to be consistent.
3113 Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
3114 LengthOfContentsInNode added in r78409 violated WebKit C++ rules and caused build failures on Mac and
3118 (WebCore::childOfCommonRootBeforeOffset): Extracted from processContents.
3119 (WebCore::lengthOfContentsInNode): Added.
3120 (WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode,
3122 (WebCore::deleteCharacterData): Added.
3123 (WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterData and processNodes.
3124 (WebCore::Range::processNodes): Extracted from processContents and processContentsBetweenOffsets.
3125 (WebCore::Range::processAncestorsAndTheirSiblings):
3128 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
3130 Not reviewed. Test harness change follow up.
3131 Consider missing localized string a warning, not an error in the front-end.
3133 * inspector/front-end/inspector.js:
3134 (WebInspector.UIString):
3136 2011-02-28 Steve Block <steveblock@google.com>
3138 Reviewed by Jeremy Orlow.
3140 getJNIEnv() passes wrong type to AttachCurrentThread() for JNIEnv argument on Android
3141 https://bugs.webkit.org/show_bug.cgi?id=55218
3143 AttachCurrentThread() in Android's JVM takes a JINEnv**
3146 No new tests, build fix only.
3148 * bridge/jni/JNIUtility.cpp:
3149 (JSC::Bindings::getJNIEnv):
3151 2011-02-28 Renata Hodovan <reni@webkit.org>
3153 Reviewed by Andreas Kling.
3155 FETurbulenceElement changes doesn't require relayout
3156 https://bugs.webkit.org/show_bug.cgi?id=55141
3158 When the FETurbulenceElement receives an update message but the given value remains the same we don't need
3159 to relayout the filter.
3160 Besides fix a typo in FETurbulence and change the paramterer type of FETurbulence::setNumOctaves from bool
3161 to int according to the spec.
3163 No new tests are needed because this modification is covered by the dynamic update tests of FETurbulence.
3165 * platform/graphics/filters/FETurbulence.cpp:
3166 (WebCore::FETurbulence::FETurbulence):
3167 (WebCore::FETurbulence::create):
3168 (WebCore::FETurbulence::type):
3169 (WebCore::FETurbulence::setType):
3170 (WebCore::FETurbulence::setBaseFrequencyY):
3171 (WebCore::FETurbulence::setBaseFrequencyX):
3172 (WebCore::FETurbulence::setSeed):
3173 (WebCore::FETurbulence::setNumOctaves):
3174 (WebCore::FETurbulence::setStitchTiles):
3175 (WebCore::operator<<):
3176 * platform/graphics/filters/FETurbulence.h:
3177 * svg/SVGFETurbulenceElement.cpp:
3178 (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute):
3179 (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
3180 (WebCore::SVGFETurbulenceElement::build):
3181 * svg/SVGFETurbulenceElement.h:
3183 2011-02-28 Pavel Feldman <pfeldman@chromium.org>
3185 Reviewed by Yury Semikhatsky.
3187 WebInspector: InspectorAgent calls offsetWidth in the middle of painting
3188 https://bugs.webkit.org/show_bug.cgi?id=54597
3190 * inspector/InspectorAgent.cpp:
3191 (WebCore::InspectorAgent::drawElementTitle):
3193 2011-02-28 Roland Steiner <rolandsteiner@chromium.org>
3195 Reviewed by Kent Tamura.
3197 Bug 55355 - TextIterator should not be a friend of RenderTextControl
3198 https://bugs.webkit.org/show_bug.cgi?id=55355
3200 Remove need for 'friend' clause by making innerTextElement() public.
3202 No new tests. (simple refactoring)
3204 * rendering/RenderTextControl.h:
3206 2011-02-27 Patrick Gansterer <paroga@webkit.org>
3208 Reviewed by Darin Adler.
3210 Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWinCE
3211 https://bugs.webkit.org/show_bug.cgi?id=55317
3213 This functions are obsolete, since r78499 added TextCodecUTF8.
3214 Also remove the "fast path" for UTF-8 data, because we now have a separate TextCodec.
3216 * platform/text/TextEncodingRegistry.cpp:
3217 (WebCore::buildBaseTextCodecMaps):
3218 * platform/text/wince/TextCodecWinCE.cpp:
3219 * platform/text/wince/TextCodecWinCE.h:
3221 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
3223 Reviewed by Sam Weinig.
3225 Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and RenderBlock::m_positionedObjects
3226 https://bugs.webkit.org/show_bug.cgi?id=55327
3228 Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positionedObjects so we do not have
3229 to release the memory manually.
3231 * rendering/RenderBlock.cpp:
3232 (WebCore::RenderBlock::~RenderBlock):
3233 (WebCore::RenderBlock::selectionGaps):
3234 (WebCore::RenderBlock::insertPositionedObject):
3235 (WebCore::RenderBlock::insertFloatingObject):
3236 (WebCore::RenderBlock::addOverhangingFloats):
3237 (WebCore::RenderBlock::addIntrudingFloats):
3238 * rendering/RenderBlock.h:
3239 (WebCore::RenderBlock::positionedObjects):
3241 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
3243 Reviewed by Andreas Kling.
3245 Eliminate DeprecatedPtrList
3246 https://bugs.webkit.org/show_bug.cgi?id=17425
3248 Remove the implementation of DeprecatedPtrList and all its references
3249 from the build systems.
3257 * WebCore.vcproj/WebCore.vcproj:
3258 * WebCore.xcodeproj/project.pbxproj:
3259 * platform/DeprecatedPtrList.h: Removed.
3260 * platform/DeprecatedPtrListImpl.cpp: Removed.
3261 * platform/DeprecatedPtrListImpl.h: Removed.
3263 2011-02-27 Andreas Kling <kling@webkit.org>
3265 Reviewed by Kenneth Rohde Christiansen.
3267 [Qt] Use WTF ref counting for FontPlatformDataPrivate
3268 https://bugs.webkit.org/show_bug.cgi?id=55303
3270 Make FontPlatformDataPrivate a RefCounted<FPDP>.
3271 Incidentally fixes an uninitialized member bug in FontPlatformData().
3273 * platform/graphics/qt/FontPlatformData.h:
3274 (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
3275 (WebCore::FontPlatformData::FontPlatformData):
3276 (WebCore::FontPlatformData::isHashTableDeletedValue):
3277 (WebCore::FontPlatformData::font):
3278 (WebCore::FontPlatformData::size):
3279 (WebCore::FontPlatformData::family):
3280 (WebCore::FontPlatformData::bold):
3281 (WebCore::FontPlatformData::italic):
3282 (WebCore::FontPlatformData::smallCaps):
3283 (WebCore::FontPlatformData::pixelSize):
3284 * platform/graphics/qt/FontPlatformDataQt.cpp:
3285 (WebCore::toQFontWeight):
3286 (WebCore::FontPlatformData::operator==):
3287 (WebCore::FontPlatformData::hash):
3289 2011-02-27 Benjamin Poulain <ikipou@gmail.com>
3291 Reviewed by Darin Adler.
3293 Eliminate DeprecatedPtrList from RenderBlock
3294 https://bugs.webkit.org/show_bug.cgi?id=54972
3296 Refactor RenderBlock to get rid of the DeprecatedPtrList.
3297 The floating objects are stored in a ListHashSet.
3299 Refactoring covered by existing test.
3301 * rendering/RenderBlock.cpp:
3302 (WebCore::RenderBlock::~RenderBlock):
3303 (WebCore::RenderBlock::addOverflowFromFloats):
3304 (WebCore::RenderBlock::repaintOverhangingFloats):
3305 (WebCore::RenderBlock::paintFloats):
3306 (WebCore::RenderBlock::selectionGaps):
3307 (WebCore::RenderBlock::insertFloatingObject):
3308 (WebCore::RenderBlock::removeFloatingObject):
3309 (WebCore::RenderBlock::removeFloatingObjectsBelow):
3310 (WebCore::RenderBlock::positionNewFloats):
3311 (WebCore::RenderBlock::positionNewFloatOnLine):
3312 (WebCore::RenderBlock::logicalLeftOffsetForLine):
3313 (WebCore::RenderBlock::logicalRightOffsetForLine):
3314 (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
3315 (WebCore::RenderBlock::lowestFloatLogicalBottom):
3316 (WebCore::RenderBlock::clearFloats):
3317 (WebCore::RenderBlock::addOverhangingFloats):
3318 (WebCore::RenderBlock::addIntrudingFloats):
3319 (WebCore::RenderBlock::containsFloat):
3320 (WebCore::RenderBlock::hitTestFloats):
3321 (WebCore::RenderBlock::adjustForBorderFit):
3322 * rendering/RenderBlock.h:
3323 (WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
3324 (WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
3325 (WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
3326 (WebCore::RenderBlock::FloatingObjectHashTranslator::equal):
3327 * rendering/RenderBlockLineLayout.cpp:
3328 (WebCore::RenderBlock::layoutInlineChildren):
3329 (WebCore::RenderBlock::matchedEndLine):
3331 2011-02-26 Adam Barth <abarth@webkit.org>
3333 Reviewed by Eric Seidel.
3335 <input value="type=submit"> throws a warning (“HTML parse error”)
3336 https://bugs.webkit.org/show_bug.cgi?id=55120
3338 This patch removes parse error messages from the HTML parser. These
3339 messages are displayed at the wrong times, aren't tested, and aren't
3340 helpful. We'll try again with some more informative messages and
3343 * html/parser/HTMLTreeBuilder.cpp:
3344 (WebCore::HTMLTreeBuilder::parseError):
3346 2011-02-26 Patrick Gansterer <paroga@webkit.org>
3348 Reviewed by Alexey Proskuryakov.
3350 Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
3351 https://bugs.webkit.org/show_bug.cgi?id=55309
3353 This functions are obsolete, since r78499 added TextCodecUTF8.
3355 * platform/text/TextEncodingRegistry.cpp:
3356 (WebCore::buildBaseTextCodecMaps):
3357 * platform/text/brew/TextCodecBrew.cpp:
3358 * platform/text/brew/TextCodecBrew.h:
3360 2011-02-26 Justin Schuh <jschuh@chromium.org>
3362 Reviewed by Darin Adler.
3364 Delay firing of mutation events while setting attribute values
3365 https://bugs.webkit.org/show_bug.cgi?id=55199
3367 Test: fast/dom/attribute-change-on-mutate.html
3370 (WebCore::Attr::setValue):
3372 2011-02-26 Yi Shen <yi.4.shen@nokia.com>
3374 Reviewed by Andreas Kling.
3376 [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
3377 https://bugs.webkit.org/show_bug.cgi?id=55252
3379 Need to invoke a callback function to notify the HTMLMediaElement
3380 when MediaPlayerPrivateQt's playback state gets changed.
3382 * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
3383 (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll
3384 (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement
3385 (WebCore::MediaPlayerPrivateQt::stateChanged):
3386 * platform/graphics/qt/MediaPlayerPrivateQt.h:
3388 2011-02-25 Abhishek Arya <inferno@chromium.org>
3390 Reviewed by Adam Barth.
3392 When plugin document parser finishes parsing, it runs the raw
3393 document's parser finish functions which call the pending document
3394 onload events that removes the frame from underneath. So, we protect
3395 frame (and hence frameloader) in DocumentLoader::commitLoad.
3396 https://bugs.webkit.org/show_bug.cgi?id=55289
3398 Test: fast/frames/iframe-plugin-load-remove-document-crash.html
3400 * loader/DocumentLoader.cpp:
3401 (WebCore::DocumentLoader::commitLoad):
3403 2011-02-26 Pavel Feldman <pfeldman@chromium.org>
3405 Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.
3407 2011-02-26 Pavel Feldman <pfeldman@chromium.org>
3409 Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
3410 https://bugs.webkit.org/show_bug.cgi?id=55302
3414 2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>
3416 Reviewed by Pavel Feldman.
3418 XML without style should render as syntax-highlighted source.
3419 https://bugs.webkit.org/show_bug.cgi?id=13807
3421 XML tree view mode implemented. If XML does not have any style
3422 information, it is rendered as highlighted source with collapsable
3425 Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
3426 http/tests/xmlviewer/dumpAsText/frames.html
3427 http/tests/xmlviewer/dumpAsText/mathml.xml
3428 http/tests/xmlviewer/dumpAsText/svg.xml
3429 http/tests/xmlviewer/dumpAsText/wml.xml
3430 http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
3431 http/tests/xmlviewer/dumpAsText/xlink.xml
3432 http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
3433 http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
3434 http/tests/xmlviewer/dumpAsText/xmlviewer.xml
3435 http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
3436 http/tests/xmlviewer/dumpAsText/xul.xml
3439 * DerivedSources.make:
3441 * WebCore.gyp/WebCore.gyp:
3443 * WebCore.vcproj/WebCore.vcproj:
3444 * WebCore.xcodeproj/project.pbxproj:
3445 * css/CSSStyleSelector.cpp:
3446 (WebCore::CSSStyleSelector::matchUARules):
3448 (WebCore::Document::Document):
3449 (WebCore::Document::createElement):
3451 (WebCore::Document::usesViewSourceStyles):
3452 (WebCore::Document::setUsesViewSourceStyles):
3453 (WebCore::Document::sawElementsInKnownNamespaces):
3454 * dom/XMLDocumentParser.h:
3455 * dom/XMLDocumentParserLibxml2.cpp:
3456 (WebCore::XMLDocumentParser::XMLDocumentParser):
3457 (WebCore::XMLDocumentParser::processingInstruction):
3458 (WebCore::XMLDocumentParser::initializeParserContext):
3459 (WebCore::XMLDocumentParser::doEnd):
3460 * dom/XMLDocumentParserQt.cpp:
3461 (WebCore::XMLDocumentParser::XMLDocumentParser):
3462 (WebCore::XMLDocumentParser::initializeParserContext):
3463 (WebCore::XMLDocumentParser::parseProcessingInstruction):
3464 * html/HTMLViewSourceDocument.cpp:
3465 (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
3466 * xml/XMLTreeViewer.cpp: Added.
3467 (WebCore::XMLTreeViewer::XMLTreeViewer):
3468 (WebCore::XMLTreeViewer::hasNoStyleInformation):
3469 (WebCore::XMLTreeViewer::transformDocumentToTreeView):
3470 * xml/XMLTreeViewer.h: Added.
3471 (WebCore::XMLTreeViewer::~XMLTreeViewer):
3472 * xml/XMLViewer.xsl: Added.
3473 * xml/XSLStyleSheet.h:
3474 (WebCore::XSLStyleSheet::createFromString):
3476 2011-02-26 Andreas Kling <kling@webkit.org>