[New Multicolumn] Make sure region styling works for columns inside regions.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2013-03-03  David Hyatt  <hyatt@apple.com>
2
3         [New Multicolumn] Make sure region styling works for columns inside regions.
4         https://bugs.webkit.org/show_bug.cgi?id=111276
5
6         Reviewed by Sam Weinig.
7
8         Test: fast/regions/region-styling-in-columns.html
9
10         * rendering/RenderFlowThread.cpp:
11         (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
12         (WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
13         * rendering/RenderFlowThread.h:
14         (CurrentRenderFlowThreadMaintainer):
15         Fix the CurrentRenderFlowThreadMaintainer so that it saves off the old render flow thread
16         and restores it when done. This effectively makes flow thread layout a push/pop stack,
17         since with in-flow threads, this is allowed. We assert that a nested flow thread is
18         in-flow to preserve the invariant that you can't nest CSS Regions flow thread.
19
20         * rendering/RenderRegion.cpp:
21         (WebCore::RenderRegion::computeChildrenStyleInRegion):
22         Add isInFlowRenderFlowThread() to the anonymous check to make sure a style gets made
23         for the nested flow thread.
24
25 2013-03-04  Andrey Lushnikov  <lushnikov@chromium.org>
26
27         Web Inspector: WebInspector.AceTextEditor throws a warning
28         https://bugs.webkit.org/show_bug.cgi?id=111315
29
30         Reviewed by Pavel Feldman.
31
32         Add WebInspector.AceTextEditor to externs.js to suppress closure
33         compilation warning.
34
35         No new tests: no change in behaviour.
36
37         * inspector/front-end/externs.js:
38         (WebInspector.AceTextEditor):
39
40 2013-03-04  Antoine Quint  <graouts@apple.com>
41
42         Fix debug build under certain configurations, cause was
43         http://trac.webkit.org/changeset/144624.
44
45         * inspector/InspectorController.cpp:
46         (WebCore::InspectorController::InspectorController):
47         * inspector/InspectorLayerTreeAgent.cpp:
48         (WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
49         * inspector/InspectorLayerTreeAgent.h:
50         (WebCore):
51         (WebCore::InspectorLayerTreeAgent::create):
52         (InspectorLayerTreeAgent):
53
54 2013-03-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
55
56         [Qt] REGRESSION(r141240) Crash in PluginPackage::fetchInfo
57         https://bugs.webkit.org/show_bug.cgi?id=111322
58
59         Reviewed by Simon Hausmann.
60
61         Do not try to load blacklisted plugins.
62
63         * plugins/qt/PluginPackageQt.cpp:
64         (WebCore::PluginPackage::fetchInfo):
65
66 2013-03-04  Alexis Menard  <alexis@webkit.org>
67
68         transition properties can't be found in CSSStyleDeclaration
69         https://bugs.webkit.org/show_bug.cgi?id=110011
70
71         Reviewed by Antti Koivisto.
72
73         The previous approach for handling the unprefixing was to alias the
74         unprefixed properties with the prefixed ones in CSSPropertyNames.in.
75         Unfortunately it will alias the properties in the parsing code which will just
76         identically parse the two versions. This means that when we populate StylePropertySet
77         we do not have information whether we just parsed the prefixed, the
78         unprefixed properties or we parsed both. The patch takes another
79         approach by creating two distinct sets of properties (unprefixed and
80         prefixed). Each properties have their own id and we now handle them in
81         the parsing code as disctints properties and add both versions to the
82         declared style. In order to avoid properties getting out of sync, 
83         this patch adds few facilities to StylePropertySet to update the
84         prefixed and the unprefixed entries. Finally the style resolution
85         happens only for the prefixed version (to limit the size of this patch)
86         and the unprefixed versions are not resolved. This is to avoid creating
87         the animation objects twice for the resolved style.
88
89         Test : transitions/transitions-parsing.html
90
91         * css/CSSComputedStyleDeclaration.cpp:
92         (WebCore):
93         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
94         * css/CSSParser.cpp:
95         (WebCore::CSSParser::addPropertyWithPrefixingVariant): Always add the
96         prefixed and the unprefixed property even if only one is specified.
97         (WebCore):
98         (WebCore::CSSParser::parseValue):
99         (WebCore::CSSParser::parseTransitionShorthand): Add both prefixed and
100         unprefixed longhands to the declarated style.
101         (WebCore::CSSParser::parseAnimationProperty):
102         * css/CSSParser.h:
103         (CSSParser):
104         * css/CSSProperty.cpp:
105         (WebCore::CSSProperty::isInheritedProperty):
106         * css/CSSProperty.h:
107         (WebCore:: prefixingVariantForPropertyId): This function takes a given
108         property id and returns its prefixed or unprefixed id if it exists. If
109         not it returns the same id.
110         (WebCore):
111         * css/CSSPropertyNames.in:
112         * css/StylePropertySet.cpp:
113         (WebCore::StylePropertySet::getPropertyValue):
114         (WebCore::StylePropertySet::removeShorthandProperty):
115         (WebCore::StylePropertySet::removeProperty):
116         (WebCore::StylePropertySet::removeProperty): Remove
117         also the prefixed or unprefixed shorthand if it exists.
118         (WebCore):
119         (WebCore::StylePropertySet::setProperty):
120         (WebCore::StylePropertySet:: appendPrefixingVariantProperty):
121         (WebCore::StylePropertySet::setPrefixingVariantProperty): If it
122         exists a unprefixed or prefixed counterpart of the property we're
123         trying to set, then we update the other one.
124         (WebCore::StylePropertySet::asText):
125         (WebCore::StylePropertySet::mergeAndOverrideOnConflict):
126         * css/StylePropertySet.h:
127         (StylePropertySet):
128         * css/StylePropertyShorthand.cpp:
129         (WebCore::transitionShorthand):
130         (WebCore):
131         (WebCore::shorthandForProperty): Define the transitions unprefixed
132         longhands.
133         * css/StylePropertyShorthand.h:
134         (WebCore):
135         * css/StyleResolver.cpp:
136         (WebCore::StyleResolver::applyProperty): StyleBuilder will handle the
137         resolution and the creation of the animations for the style. As the
138         declarated style now contains declarations for the prefixed and
139         unprefixed property we do not want to resolve two times and create duplicate animations.
140         Therefore when we try to resolve the unprefixed version we just bail out.
141
142 2013-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
143
144         Web Inspector: CPU Flame Chart: reveal profiler DataGrid node when user clicks on a FlameChart item.
145         https://bugs.webkit.org/show_bug.cgi?id=111309
146
147         Reviewed by Yury Semikhatsky.
148
149         * inspector/front-end/CPUProfileView.js:
150         (WebInspector.CPUProfileView.prototype._revealProfilerNode):
151         * inspector/front-end/FlameChart.js:
152         (WebInspector.FlameChart):
153         (WebInspector.FlameChart.prototype._onClick):
154
155 2013-03-04  Antoine Quint  <graouts@apple.com>
156
157         Web Inspector: remove existing LayerTreeAgent protocol APIs
158         https://bugs.webkit.org/show_bug.cgi?id=111251
159
160         In order to eventually provide a more useful API for the LayerTreeAgent
161         that will be done in followup bugs, we remove the current API exposed by
162         the agent providing a clean slate that will make future patches easier
163         to read. Additionally, we remove the "childLayers" property on the Layer
164         object since we will no longer be providing a hierarchy of layers, but
165         rather a flat list of layers attached to a node and its descendants.
166
167         No new tests since we're removing the APIs exposed by the LayerTreeAgent.
168         Subsequent patches will add tests as new APIs are added.
169
170         Reviewed by Timothy Hatcher.
171
172         * inspector/Inspector.json:
173         * inspector/InspectorDOMAgent.cpp:
174         * inspector/InspectorDOMAgent.h:
175         * inspector/InspectorLayerTreeAgent.cpp:
176         (WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
177         * inspector/InspectorLayerTreeAgent.h:
178         (InspectorLayerTreeAgent):
179
180 2013-03-04  Li Yin  <li.yin@intel.com>
181
182         MediaStream.ended must return true when it is created with ended tracks.
183         https://bugs.webkit.org/show_bug.cgi?id=111293
184
185         Reviewed by Kentaro Hara.
186
187         Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#MediaStream-ended
188         When a MediaStream object is created, its ended attribute must be set to false,
189         unless it is being created using the MediaStream() constructor whose arguments
190         are lists of MediaStreamTrack objects that are all ended, in which case the
191         MediaStream object must be created with its ended attribute set to true.
192
193         Test: fast/mediastream/MediaStreamConstructor.html
194
195         * platform/mediastream/MediaStreamDescriptor.h:
196         (WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
197
198 2013-03-04  Alexander Pavlov  <apavlov@chromium.org>
199
200         Web Inspector: Adding new rules broken if a <style> tag is added to document dynamically
201         https://bugs.webkit.org/show_bug.cgi?id=111299
202
203         Reviewed by Pavel Feldman.
204
205         The CSSStyleSheet instance should be retrieved directly from the HTMLStyleElement just created,
206         not from the document.styleSheets list.
207
208         Test: inspector/styles/add-new-rule-with-style-after-body.html
209
210         * inspector/InspectorCSSAgent.cpp:
211         (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
212
213 2013-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
214
215         Web Inspector: Unreviewed. Fix for closure type annotations.
216
217         * inspector/front-end/FlameChart.js:
218
219 2013-03-04  Kondapally Kalyan  <kalyan.kondapally@intel.com>
220
221         [EFL] Build fix when compiling with GLES2 support enabled.
222         https://bugs.webkit.org/show_bug.cgi?id=111291
223
224         Reviewed by Kenneth Rohde Christiansen.
225
226         This patch fixes build issues when compiling with GLES2
227         support. As part of the fix the patch removes Evas specific
228         workaround of using GLX with EGL in PlatformContext as GLES2 
229         is the main target with EGL.
230
231         * platform/graphics/OpenGLESShims.h:
232         * platform/graphics/opengl/GLPlatformContext.cpp:
233         (WebCore::GLCurrentContextWrapper::GLCurrentContextWrapper):
234         * platform/graphics/texmap/TextureMapper.h:
235
236 2013-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
237
238         Web Inspector: implement Flame Chart for CPU profiler.
239         https://bugs.webkit.org/show_bug.cgi?id=111162
240
241         Reviewed by Yury Semikhatsky.
242
243         It is an initial implementation. The next step is to provide
244         function names and other stats about the hovered item.
245
246         * WebCore.gypi:
247         * WebCore.vcproj/WebCore.vcproj:
248         * WebCore.vcxproj/WebCore.vcxproj:
249         * WebCore.vcxproj/WebCore.vcxproj.filters:
250         * inspector/compile-front-end.py:
251         * inspector/front-end/CPUProfileView.js:
252         (WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
253         * inspector/front-end/FlameChart.js: Added.
254         (WebInspector.FlameChart):
255         (WebInspector.FlameChart.prototype._onMouseMove):
256         (WebInspector.FlameChart.prototype.findNodeCallback):
257         (WebInspector.FlameChart.prototype._coordinatesToNode):
258         (WebInspector.FlameChart.prototype.onResize):
259         (WebInspector.FlameChart.prototype._rootNodes):
260         (WebInspector.FlameChart.prototype.draw):
261         (WebInspector.FlameChart.prototype._drawNode):
262         (WebInspector.FlameChart.prototype._forEachNode):
263         (WebInspector.FlameChart.prototype._drawBar):
264         (WebInspector.FlameChart.prototype.update):
265         * inspector/front-end/Settings.js:
266         (WebInspector.ExperimentsSettings):
267         * inspector/front-end/WebKit.qrc:
268         * inspector/front-end/flameChart.css: Added.
269         (.flame-chart):
270
271 2013-03-04  Marja Hölttä  <marja@chromium.org>
272
273         [V8] Add a "context type" parameter to GetTemplate and ConfigureV8SomethingTemplate functions
274         https://bugs.webkit.org/show_bug.cgi?id=110875
275
276         The parameter will later be used for generating specialized V8
277         bindings for the 3 different world types (main world, isolated
278         work, worker).
279
280         Reviewed by Kentaro Hara.
281
282         No new tests (no changes in behavior yet).
283
284         * bindings/scripts/CodeGeneratorV8.pm:
285         (GenerateHeader):
286         (GenerateDomainSafeFunctionGetter):
287         (GenerateDomainSafeFunctionSetter):
288         (GenerateNormalAttrGetter):
289         (GenerateNamedConstructor):
290         (GenerateImplementation):
291         * bindings/v8/DOMDataStore.cpp:
292         (WebCore::DOMDataStore::DOMDataStore):
293         * bindings/v8/DOMDataStore.h:
294         (DOMDataStore):
295         * bindings/v8/DOMWrapperWorld.cpp:
296         (WebCore):
297         (WebCore::DOMWrapperWorld::setInitializingWindow):
298         (WebCore::DOMWrapperWorld::DOMWrapperWorld):
299         (WebCore::DOMWrapperWorld::contextHasCorrectPrototype):
300         * bindings/v8/DOMWrapperWorld.h:
301         (DOMWrapperWorld):
302         (WebCore::DOMWrapperWorld::getWorld):
303         * bindings/v8/Dictionary.cpp:
304         (WebCore::Dictionary::get):
305         * bindings/v8/PageScriptDebugServer.cpp:
306         (WebCore::retrieveFrameWithGlobalObjectCheck):
307         * bindings/v8/V8AdaptorFunction.cpp:
308         (WebCore::V8AdaptorFunction::getTemplate):
309         (WebCore::V8AdaptorFunction::wrap):
310         * bindings/v8/V8AdaptorFunction.h:
311         (V8AdaptorFunction):
312         * bindings/v8/V8Binding.cpp:
313         (WebCore::toDOMWindow):
314         (WebCore::toScriptExecutionContext):
315         (WebCore::worldType):
316         (WebCore):
317         (WebCore::worldTypeInMainThread):
318         * bindings/v8/V8Binding.h:
319         (WebCore):
320         * bindings/v8/V8DOMWindowShell.cpp:
321         (WebCore::V8DOMWindowShell::clearForNavigation):
322         (WebCore::V8DOMWindowShell::installDOMWindow):
323         * bindings/v8/V8DOMWrapper.cpp:
324         (WebCore::V8DOMWrapper::createWrapper):
325         * bindings/v8/V8Initializer.cpp:
326         (WebCore::findFrame):
327         * bindings/v8/V8PerContextData.cpp:
328         (WebCore::V8PerContextData::constructorForTypeSlowCase):
329         * bindings/v8/WorkerScriptController.cpp:
330         (WebCore::WorkerScriptController::WorkerScriptController):
331         (WebCore::WorkerScriptController::controllerForContext):
332         * bindings/v8/WrapperTypeInfo.h:
333         (WebCore::WrapperTypeInfo::getTemplate):
334         * bindings/v8/custom/V8DOMWindowCustom.cpp:
335         (WebCore::V8DOMWindow::eventAttrGetterCustom):
336         (WebCore::V8DOMWindow::eventAttrSetterCustom):
337         (WebCore::V8DOMWindow::toStringMethodCustom):
338         (WebCore::V8DOMWindow::namedSecurityCheck):
339         (WebCore::V8DOMWindow::indexedSecurityCheck):
340         (WebCore::toV8):
341         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
342         (WebCore::V8HTMLDocument::wrapInShadowObject):
343         * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
344         (WebCore::V8HTMLImageElementConstructor::GetTemplate):
345         * bindings/v8/custom/V8HTMLImageElementConstructor.h:
346         (V8HTMLImageElementConstructor):
347         * bindings/v8/custom/V8InjectedScriptManager.cpp:
348         (WebCore::createInjectedScriptHostV8Wrapper):
349         (WebCore::InjectedScriptManager::canAccessInspectedWindow):
350         * bindings/v8/custom/V8LocationCustom.cpp:
351         (WebCore::V8Location::reloadAttrGetterCustom):
352         (WebCore::V8Location::replaceAttrGetterCustom):
353         (WebCore::V8Location::assignAttrGetterCustom):
354         * bindings/v8/custom/V8MessageEventCustom.cpp:
355         (WebCore::V8MessageEvent::initMessageEventMethodCustom):
356
357 2013-03-04  Andrey Lushnikov  <lushnikov@chromium.org>
358
359         Web Inspector: add Ace editor experiment
360         https://bugs.webkit.org/show_bug.cgi?id=111191
361
362         Reviewed by Pavel Feldman.
363
364         No new tests.
365
366         Add Ace text editor experiment.
367
368         * WebCore.gypi:
369         * inspector/front-end/AceTextEditor.js: Added.
370         * inspector/front-end/Settings.js:
371         (WebInspector.ExperimentsSettings):
372         * inspector/front-end/SourceFrame.js:
373         (WebInspector.SourceFrame):
374         * inspector/front-end/ace/ace.js: Added.
375         * inspector/front-end/ace/acedevtools.css: Added.
376         * inspector/front-end/ace/mode_css.js: Added.
377         * inspector/front-end/ace/mode_html.js: Added.
378         * inspector/front-end/ace/mode_javascript.js: Added.
379         * inspector/front-end/ace/theme_textmate.js: Added.
380         * inspector/front-end/ace/LICENSE.txt: Added.
381
382 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
383
384         Add build flag for FontLoader
385         https://bugs.webkit.org/show_bug.cgi?id=111289
386
387         Reviewed by Benjamin Poulain.
388
389         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
390
391         * Configurations/FeatureDefines.xcconfig:
392
393 2013-03-04  Mike West  <mkwst@chromium.org>
394
395         XSSAuditor should strip dangerous attributes from SMIL animation elements.
396         https://bugs.webkit.org/show_bug.cgi?id=111071
397
398         Reviewed by Adam Barth.
399
400         SMIL animation elements can, amusingly enough, animate the 'href' of a
401         link. This patch teaches XSSAuditor how to deal with the
402         semicolon-separated 'animation[values]' attribute in order to ensure
403         that it doesn't contain JavaScript URLs that could be animated into
404         place for an unsuspecting user to click on.
405
406         Test: http/tests/security/xssAuditor/svg-animate.html
407
408         * html/parser/XSSAuditor.cpp:
409         (WebCore::isSemicolonSeparatedAttribute): Added.
410             This returns true if the given attribute is SVGNames::valuesAttr,
411             but makes it possible to easily extend the list with additional
412             attributes with this strange property.
413         (WebCore::semicolonSeparatedValueContainsJavaScriptURL): Added.
414             Given a semicolon-separated string, determine if it contains any
415             JavaScript URLs.
416         (WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
417             When looking for dangerousness, determine whether or not we should
418             be comparing against each member of a semicolon-separated list.
419
420 2013-03-04  Arvid Nilsson  <anilsson@rim.com>
421
422         [BlackBerry] New files for BlackBerry::Platform::Graphics::GraphicsContext integration
423         https://bugs.webkit.org/show_bug.cgi?id=111153
424
425         Reviewed by Rob Buis.
426
427         BlackBerry PR 293208
428
429         This patch contains contributions from many members of the BlackBerry
430         WebKit team:
431
432         Rob Buis
433         Robin Cao
434         Eli Fidler
435         Mike Lattanzio
436         Yong Li
437         Maxim Mogilnitsky
438         Joshua Netterfield
439         Arvid Nilsson
440         Jakob Petsovits
441         Konrad Piascik
442         Jeff Rogers
443         Artem Simonov
444         Filip Spacek
445         George Staikos
446
447         Covered by existing tests.
448
449         * platform/graphics/blackberry/FontBlackBerry.cpp: Added.
450         (FSFixedToFloat):
451         (FloatToFSFixed):
452         (WebCore):
453         (WebCore::Font::drawComplexText):
454         (WebCore::Font::floatWidthForComplexText):
455         (WebCore::Font::offsetForPositionForComplexText):
456         (WebCore::Font::selectionRectForComplexText):
457         (WebCore::Font::drawGlyphs):
458         (WebCore::Font::canReturnFallbackFontsForComplexText):
459         (WebCore::Font::drawEmphasisMarksForComplexText):
460         (WebCore::Font::canExpandAroundIdeographsInComplexText):
461         * platform/graphics/blackberry/FontCacheBlackBerry.cpp: Added.
462         (WebCore):
463         (WebCore::FontCache::platformInit):
464         (WebCore::FontCache::getFontDataForCharacters):
465         (WebCore::FontCache::getSimilarFontPlatformData):
466         (WebCore::FontCache::getLastResortFallbackFont):
467         (WebCore::FontCache::getTraitsInFamily):
468         (WebCore::getFamilyNameStringFromFontDescriptionAndFamily):
469         (WebCore::fontWeightToFontconfigWeight):
470         (WebCore::FontCache::createFontPlatformData):
471         * platform/graphics/blackberry/FontCustomPlatformData.h: Added.
472         (WebCore):
473         (FontCustomPlatformData):
474         * platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp: Added.
475         (WebCore):
476         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
477         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
478         (WebCore::FontCustomPlatformData::fontPlatformData):
479         (WebCore::FontCustomPlatformData::supportsFormat):
480         (WebCore::createFontCustomPlatformData):
481         * platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp: Added.
482         (WebCore):
483         (WebCore::FontPlatformData::FontPlatformData):
484         (WebCore::FontPlatformData::~FontPlatformData):
485         (WebCore::FontPlatformData::name):
486         (WebCore::FontPlatformData::applyState):
487         (WebCore::FontPlatformData::platformDataInit):
488         (WebCore::FontPlatformData::platformDataAssign):
489         (WebCore::FontPlatformData::platformIsEqual):
490         (WebCore::FontPlatformData::description):
491         (WebCore::FontPlatformData::harfbuzzFace):
492         (WebCore::FontPlatformData::scaledFont):
493         (WebCore::FontPlatformData::setFakeBold):
494         (WebCore::FontPlatformData::setFakeItalic):
495         (WebCore::FontPlatformData::platformFontHandle):
496         (WebCore::FontPlatformData::isFixedPitch):
497         * platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp: Added.
498         (WebCore):
499         (WorldTypeScopedPtr):
500         (WebCore::WorldTypeScopedPtr::WorldTypeScopedPtr):
501         (WebCore::WorldTypeScopedPtr::~WorldTypeScopedPtr):
502         (WebCore::WorldTypeScopedPtr::get):
503         (WebCore::GlyphPage::fill):
504         * platform/graphics/blackberry/GradientBlackBerry.cpp: Added.
505         (WebCore):
506         (WebCore::totalStopsNeeded):
507         (WebCore::fillStops):
508         (WebCore::Gradient::platformGradient):
509         (WebCore::Gradient::platformDestroy):
510         (WebCore::Gradient::fill):
511         (WebCore::Gradient::setPlatformGradientSpaceTransform):
512         * platform/graphics/blackberry/GraphicsContextBlackBerry.cpp: Added.
513         (WebCore):
514         (GraphicsContextPlatformPrivate):
515         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
516         (WebCore::GraphicsContext::platformInit):
517         (WebCore::GraphicsContext::platformDestroy):
518         (WebCore::GraphicsContext::platformContext):
519         (WebCore::GraphicsContext::savePlatformState):
520         (WebCore::GraphicsContext::restorePlatformState):
521         (WebCore::GraphicsContext::setIsAcceleratedContext):
522         (WebCore::GraphicsContext::isAcceleratedContext):
523         (WebCore::GraphicsContext::getCTM):
524         (WebCore::GraphicsContext::concatCTM):
525         (WebCore::GraphicsContext::setCTM):
526         (WebCore::GraphicsContext::scale):
527         (WebCore::GraphicsContext::rotate):
528         (WebCore::GraphicsContext::translate):
529         (WebCore::GraphicsContext::drawEllipse):
530         (WebCore::GraphicsContext::strokeArc):
531         (WebCore::GraphicsContext::drawConvexPolygon):
532         (WebCore::GraphicsContext::drawRect):
533         (WebCore::GraphicsContext::fillRect):
534         (WebCore::GraphicsContext::clearRect):
535         (WebCore::GraphicsContext::strokeRect):
536         (WebCore::GraphicsContext::fillRoundedRect):
537         (WebCore::GraphicsContext::roundToDevicePixels):
538         (WebCore::GraphicsContext::setPlatformShadow):
539         (WebCore::GraphicsContext::clearPlatformShadow):
540         (WebCore::GraphicsContext::beginPlatformTransparencyLayer):
541         (WebCore::GraphicsContext::endPlatformTransparencyLayer):
542         (WebCore::GraphicsContext::supportsTransparencyLayers):
543         (WebCore::GraphicsContext::setLineCap):
544         (WebCore::GraphicsContext::setLineDash):
545         (WebCore::GraphicsContext::setLineJoin):
546         (WebCore::GraphicsContext::setMiterLimit):
547         (WebCore::GraphicsContext::setAlpha):
548         (WebCore::GraphicsContext::clip):
549         (WebCore::GraphicsContext::clipOut):
550         (WebCore::GraphicsContext::clipConvexPolygon):
551         (WebCore::GraphicsContext::addRoundedRectClip):
552         (WebCore::GraphicsContext::clipOutRoundedRect):
553         (WebCore::GraphicsContext::clipBounds):
554         (WebCore::GraphicsContext::addInnerRoundedRectClip):
555         (WebCore::GraphicsContext::setURLForRect):
556         (WebCore::GraphicsContext::setPlatformTextDrawingMode):
557         (WebCore::GraphicsContext::setPlatformStrokeColor):
558         (WebCore::GraphicsContext::setPlatformStrokeStyle):
559         (WebCore::GraphicsContext::setPlatformStrokeThickness):
560         (WebCore::GraphicsContext::setPlatformFillColor):
561         (WebCore::GraphicsContext::setPlatformCompositeOperation):
562         (WebCore::GraphicsContext::setPlatformShouldAntialias):
563         (WebCore::GraphicsContext::setImageInterpolationQuality):
564         (WebCore::GraphicsContext::imageInterpolationQuality):
565         * platform/graphics/blackberry/ITypeUtils.h: Added.
566         (floatToITypeFixed):
567         (intToITypeFixed):
568         (iTypeFixedToFloat):
569         * platform/graphics/blackberry/ImageBufferBlackBerry.cpp: Added.
570         (WebCore):
571         (WebCore::makeBufferCurrent):
572         (WebCore::getImageDataInternal):
573         (WebCore::ImageBufferData::getImageData):
574         (WebCore::flushAndDraw):
575         (WebCore::ImageBufferData::draw):
576         (WebCore::ImageBuffer::ImageBuffer):
577         (WebCore::ImageBuffer::~ImageBuffer):
578         (WebCore::ImageBuffer::context):
579         (WebCore::ImageBuffer::platformLayer):
580         (WebCore::ImageBuffer::copyImage):
581         (WebCore::ImageBuffer::clip):
582         (WebCore::ImageBuffer::draw):
583         (WebCore::ImageBuffer::drawPattern):
584         (WebCore::ImageBuffer::platformTransformColorSpace):
585         (WebCore::ImageBuffer::getUnmultipliedImageData):
586         (WebCore::ImageBuffer::getPremultipliedImageData):
587         (WebCore::ImageBuffer::putByteArray):
588         (WebCore::ImageBuffer::toDataURL):
589         * platform/graphics/blackberry/ImageBufferDataBlackBerry.h: Added.
590         (WebCore):
591         (ImageBufferData):
592         * platform/graphics/blackberry/PathBlackBerry.cpp: Added.
593         (WebCore):
594         (WebCore::scratchContext):
595         (WebCore::Path::Path):
596         (WebCore::Path::~Path):
597         (WebCore::Path::operator=):
598         (WebCore::Path::currentPoint):
599         (WebCore::Path::contains):
600         (WebCore::Path::strokeContains):
601         (WebCore::Path::translate):
602         (WebCore::Path::boundingRect):
603         (WebCore::Path::strokeBoundingRect):
604         (WebCore::Path::moveTo):
605         (WebCore::Path::addLineTo):
606         (WebCore::Path::addQuadCurveTo):
607         (WebCore::Path::addBezierCurveTo):
608         (WebCore::Path::addArcTo):
609         (WebCore::Path::closeSubpath):
610         (WebCore::Path::addArc):
611         (WebCore::Path::addRect):
612         (WebCore::Path::addEllipse):
613         (WebCore::Path::platformAddPathForRoundedRect):
614         (WebCore::Path::clear):
615         (WebCore::Path::isEmpty):
616         (WebCore::Path::hasCurrentPoint):
617         (WebCore::Path::apply):
618         (WebCore::Path::transform):
619         (WebCore::GraphicsContext::fillPath):
620         (WebCore::GraphicsContext::strokePath):
621         (WebCore::GraphicsContext::drawFocusRing):
622         (WebCore::GraphicsContext::drawLine):
623         (WebCore::GraphicsContext::drawLineForDocumentMarker):
624         (WebCore::GraphicsContext::drawLineForText):
625         (WebCore::GraphicsContext::clip):
626         (WebCore::GraphicsContext::clipPath):
627         (WebCore::GraphicsContext::canvasClip):
628         (WebCore::GraphicsContext::clipOut):
629         * platform/graphics/blackberry/PatternBlackBerry.cpp: Added.
630         (WebCore):
631         (WebCore::Pattern::platformDestroy):
632         (WebCore::Pattern::platformPattern):
633         (WebCore::Pattern::setPlatformPatternSpaceTransform):
634         * platform/graphics/blackberry/PlatformSupport.cpp: Added.
635         (WebCore):
636         (WebCore::PlatformSupport::getFontFamilyForCharacters):
637         * platform/graphics/blackberry/PlatformSupport.h: Added.
638         (WebCore):
639         (PlatformSupport):
640         (FontFamily):
641         * platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp: Added.
642         (WebCore):
643         (WebCore::FSFixedToFloat):
644         (WebCore::SimpleFontData::platformInit):
645         (WebCore::SimpleFontData::platformCharWidthInit):
646         (WebCore::SimpleFontData::platformDestroy):
647         (WebCore::SimpleFontData::createScaledFontData):
648         (WebCore::SimpleFontData::smallCapsFontData):
649         (WebCore::SimpleFontData::emphasisMarkFontData):
650         (WebCore::SimpleFontData::containsCharacters):
651         (WebCore::SimpleFontData::determinePitch):
652         (WebCore::SimpleFontData::platformBoundsForGlyph):
653         (WebCore::SimpleFontData::platformWidthForGlyph):
654         (WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
655
656 2013-03-04  Adam Bergkvist  <adam.bergkvist@ericsson.com>
657
658         MediaStream API: local addTrack() and removeTrack() operations should not fire events.
659         https://bugs.webkit.org/show_bug.cgi?id=111079
660
661         Reviewed by Adam Barth.
662
663         Removed the scheduling of "addtrack" and "removetrack" events by
664         addTrack and removeTrack(). Replaced the test since the old test was
665         driven by the event firing removed by this patch.
666
667         Test: fast/mediastream/MediaStream-add-remove-tracks.html
668
669         * Modules/mediastream/MediaStream.cpp:
670         (WebCore::MediaStream::addTrack):
671         (WebCore::MediaStream::removeTrack):
672
673 2013-03-04  Alexander Pavlov  <apavlov@chromium.org>
674
675         Web Inspector: touchmove not emulated inside iframe
676         https://bugs.webkit.org/show_bug.cgi?id=111292
677
678         Reviewed by Vsevolod Vlasov.
679
680         Move fake touch event dispatching from mouseMoved() into handleMouseMoveEvent()
681         and bail out earlier from dispatchSyntheticTouchEventIfEnabled() when the event
682         should be dispatched on a subframe.
683
684         * page/EventHandler.cpp:
685         (WebCore::EventHandler::mouseMoved):
686         (WebCore::EventHandler::handleMouseMoveEvent):
687         (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
688
689 2013-03-04  Mike West  <mkwst@chromium.org>
690
691         Long URLs in error messages should be shortened
692         https://bugs.webkit.org/show_bug.cgi?id=111133
693
694         Reviewed by Jochen Eisinger.
695
696         When generating console messages, we're often copying the page's URL
697         in order to add detail about where the error occurred. Generally, this
698         is fine, but in edge cases (multi-meg 'data:' URLs), we're using far
699         more memory than we should, and impacting performance.
700
701         This patch adds an 'elidedString()' method to KURL for use in this
702         sort of case; when generating console messages, we should insert the
703         elided URL rather than the full URL.
704
705         This shouldn't change any visible behavior; we're already visually
706         eliding URLs in console messages for URLs above 150 characters. This
707         patch simply changes the underlying string to ensure that no URL is
708         over 1k in length to begin with.
709
710         * platform/KURL.cpp:
711         (WebCore::KURL::elidedString): Added.
712         * platform/KURL.h:
713             An exciting new method that gives you the same result as string()
714             for URLs less than 1k long, and elides the middle of URLs longer
715             than 1k by replacing everything but the first and last 0.5k with
716             "...".
717         * bindings/ScriptControllerBase.cpp:
718         (WebCore::ScriptController::canExecuteScripts):
719         * Modules/websockets/WebSocket.cpp:
720         (WebCore::WebSocket::connect):
721         (WebCore::WebSocket::send):
722         * Modules/websockets/WebSocketChannel.cpp:
723         (WebCore::WebSocketChannel::send):
724         (WebCore::WebSocketChannel::fail):
725         * bindings/ScriptControllerBase.cpp:
726         (WebCore::ScriptController::canExecuteScripts):
727         * dom/Document.cpp:
728         (WebCore::Document::processHttpEquiv):
729         * dom/ScriptElement.cpp:
730         (WebCore::ScriptElement::executeScript):
731         * html/HTMLMediaElement.cpp:
732         (WebCore::HTMLMediaElement::canPlayType):
733         (WebCore::HTMLMediaElement::isSafeToLoadURL):
734         * loader/FrameLoader.cpp:
735         (WebCore::FrameLoader::submitForm):
736         (WebCore::FrameLoader::loadFrameRequest):
737         (WebCore::FrameLoader::commitProvisionalLoad):
738         (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
739         (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
740         (WebCore::createWindow):
741         * loader/MainResourceLoader.cpp:
742         (WebCore::MainResourceLoader::willSendRequest):
743         (WebCore::MainResourceLoader::responseReceived):
744         * loader/appcache/ApplicationCacheGroup.cpp:
745         (WebCore::ApplicationCacheGroup::didReceiveResponse):
746         (WebCore::ApplicationCacheGroup::didFail):
747         * loader/cache/CachedResourceLoader.cpp:
748         (WebCore::CachedResourceLoader::canRequest):
749         (WebCore::CachedResourceLoader::requestResource):
750         (WebCore::CachedResourceLoader::loadResource):
751         (WebCore::CachedResourceLoader::printAccessDeniedMessage):
752         * page/ContentSecurityPolicy.cpp:
753         (WebCore::CSPDirectiveList::checkSourceAndReportViolation):
754         (WebCore::CSPDirectiveList::allowScriptNonce):
755         (WebCore::CSPDirectiveList::allowPluginType):
756             Use 'KURL::elidedString()' rather than 'KURL::string()'
757         * loader/MixedContentChecker.cpp:
758         (WebCore::MixedContentChecker::logWarning):
759             Here, we're doing the same as above, but it enables us to throw
760             away the asUTF8() function entirely by switching to makeString
761             rather than String::format.
762
763 2013-03-04  Andrey Lushnikov  <lushnikov@chromium.org>
764
765         Web Inspector: add runtime flag to determine if inspector's source files were flattened.
766         https://bugs.webkit.org/show_bug.cgi?id=111184
767
768         Reviewed by Pavel Feldman.
769
770         - Add a file "buildSystemOnly.js" which will be included into
771         devtools.html only by GYP build system. This script sets a single flag
772         which essentially means that inspector source files were run
773         through a build system and flattened.
774         - Update "importScript" and "registerRequiredCSS" functions to correct
775         paths according to the "flattenImports" flag.
776
777         No new tests: no change in behaviour.
778
779         * WebCore.gypi:
780         * inspector/front-end/CodeMirrorTextEditor.js:
781         (WebInspector.CodeMirrorTextEditor):
782         * inspector/front-end/View.js:
783         (WebInspector.View.prototype.registerRequiredCSS):
784         * inspector/front-end/buildSystemOnly.js: Added.
785         * inspector/front-end/utilities.js:
786
787 2013-03-04  Vsevolod Vlasov  <vsevik@chromium.org>
788
789         Web Inspector: Fix front-end compilation
790         https://bugs.webkit.org/show_bug.cgi?id=111286
791
792         Reviewed by Alexander Pavlov.
793
794         * inspector/InjectedScriptSource.js:
795         * inspector/front-end/FileSystemProjectDelegate.js:
796         * inspector/front-end/NavigatorView.js:
797         (WebInspector.NavigatorView.prototype.removeUISourceCode):
798         (WebInspector.NavigatorTreeNode.prototype.reset):
799         (WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
800
801 2013-03-03  Kondapally Kalyan  <kalyan.kondapally@intel.com>
802
803         [EFL][WebGL] Add proper checks to enable GraphicsSurface usage on EGL without XCompositeWindow.
804         https://bugs.webkit.org/show_bug.cgi?id=108034
805
806         Reviewed by Laszlo Gombos.
807
808         Covered by existing WebGL tests.
809
810         Currently, we set GRAPHICS_SURFACE to true if support for XCompositeWindow
811         is identified during compile time. This is ok, when using GLX. We might not
812         have support for XCompositeWindow when using EGL and GLES2.0. This patch
813         makes changes so that GRAPHICS_SURFACE is always enabled with EGL and adds
814         GLX guard to the parts of code dependent on XCompositeWindow support.
815
816         * platform/graphics/opengl/GLPlatformSurface.cpp:
817         * platform/graphics/surfaces/glx/GLXConfigSelector.h:
818         (WebCore::GLXConfigSelector::findMatchingConfig):
819         * platform/graphics/surfaces/glx/X11Helper.cpp:
820         (WebCore::X11Helper::createOffScreenWindow):
821         (WebCore::X11Helper::isXRenderExtensionSupported):
822         * platform/graphics/surfaces/glx/X11Helper.h:
823
824 2013-03-03  Alexander Pavlov  <apavlov@chromium.org>
825
826         Web Inspector: [PageAgent] can't find frame by security origin.
827         https://bugs.webkit.org/show_bug.cgi?id=110849
828
829         Use toRawString() in order to compare Frames' SecurityOrigins for storage-related goals.
830
831         Reviewed by Vsevolod Vlasov.
832
833         * inspector/InspectorPageAgent.cpp:
834         (WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
835
836 2013-03-03  Alexander Pavlov  <apavlov@chromium.org>
837
838         Unreviewed, rolling out r144455.
839         http://trac.webkit.org/changeset/144455
840         https://bugs.webkit.org/show_bug.cgi?id=111165
841
842         A simpler solution to the SecurityOrigin -> localStorage
843         lookup exists
844
845         * inspector/front-end/DOMStorage.js:
846         (WebInspector.DOMStorage.storageId):
847         (WebInspector.DOMStorage.prototype.get id):
848         (WebInspector.DOMStorage.prototype.getItems):
849         (WebInspector.DOMStorage.prototype.setItem):
850         (WebInspector.DOMStorage.prototype.removeItem):
851         (WebInspector.DOMStorageModel.prototype._securityOriginAdded):
852         (WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
853         (WebInspector.DOMStorageModel.prototype._storageKey):
854         * inspector/front-end/ExtensionAuditCategory.js:
855         * inspector/front-end/FileSystemModel.js:
856         (WebInspector.FileSystemModel.prototype._reset):
857         (WebInspector.FileSystemModel.prototype._securityOriginAdded):
858         (WebInspector.FileSystemModel.prototype._securityOriginRemoved):
859         (WebInspector.FileSystemModel.prototype._addOrigin):
860         (WebInspector.FileSystemModel.prototype._removeOrigin):
861         (WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
862         (WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
863         (WebInspector.FileSystemModel.prototype._removeFileSystem):
864         (WebInspector.FileSystemModel.FileSystem.prototype.get name):
865         * inspector/front-end/IndexedDBModel.js:
866         (WebInspector.IndexedDBModel.prototype._reset):
867         (WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
868         (WebInspector.IndexedDBModel.prototype._securityOriginAdded):
869         (WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
870         (WebInspector.IndexedDBModel.prototype._addOrigin):
871         (WebInspector.IndexedDBModel.prototype._removeOrigin):
872         (WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
873         (WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
874         (WebInspector.IndexedDBModel.prototype._loadDatabase):
875         (WebInspector.IndexedDBModel.prototype.):
876         (WebInspector.IndexedDBModel.prototype._requestData):
877         (WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
878         * inspector/front-end/IndexedDBViews.js:
879         (WebInspector.IDBDatabaseView.prototype._refreshDatabase):
880         * inspector/front-end/ResourceTreeModel.js:
881         (WebInspector.ResourceTreeModel):
882         (WebInspector.ResourceTreeModel.prototype._addFrame):
883         (WebInspector.ResourceTreeModel.prototype._addSecurityOrigin):
884         (WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin):
885         (WebInspector.ResourceTreeModel.prototype.securityOrigins):
886         (WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
887         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
888         (WebInspector.ResourceTreeModel.prototype._frameDetached):
889         (WebInspector.ResourceTreeFrame):
890         (WebInspector.ResourceTreeFrame.prototype._navigate):
891         * inspector/front-end/ResourcesPanel.js:
892         (WebInspector.IDBDatabaseTreeElement):
893         (WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
894         (WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
895         (WebInspector.IDBIndexTreeElement.prototype.get itemURL):
896         (WebInspector.DOMStorageTreeElement):
897         (WebInspector.DOMStorageTreeElement.prototype.get itemURL):
898         (WebInspector.FileSystemTreeElement):
899
900 2013-03-01  Vsevolod Vlasov  <vsevik@chromium.org>
901
902         Web Inspector: Let user know when file system based uiSourceCode was changed on disk.
903         https://bugs.webkit.org/show_bug.cgi?id=110133
904
905         Reviewed by Pavel Feldman.
906
907         We now check if file system based uiSourceCode content was updated externally when 
908         UISourceCodeFrame is shown or inspector window is focused.
909         If there is no working copy being edited right now we replace old content with the new one silently.
910         Otherwise ask user if he wants to replace his working copy with the new content.
911
912         * English.lproj/localizedStrings.js:
913         * WebCore.vcproj/WebCore.vcproj:
914         * inspector/front-end/DefaultTextEditor.js:
915         (WebInspector.DefaultTextEditor.prototype.editRange):
916         * inspector/front-end/FileSystemProjectDelegate.js:
917         (WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
918         (WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
919         (WebInspector.FileSystemProjectDelegate.prototype._contentRequestFinished):
920         (WebInspector.FileSystemProjectDelegate.prototype.requestUpdatedFileContent):
921         (WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
922         (WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
923         * inspector/front-end/JavaScriptSourceFrame.js:
924         (WebInspector.JavaScriptSourceFrame.prototype.wasShown):
925         (WebInspector.JavaScriptSourceFrame.prototype.willHide):
926         * inspector/front-end/SimpleWorkspaceProvider.js:
927         (WebInspector.SimpleProjectDelegate.prototype.requestUpdatedFileContent):
928         * inspector/front-end/SourceFrame.js:
929         (WebInspector.SourceFrame.prototype.setContent):
930         * inspector/front-end/UISourceCode.js:
931         (WebInspector.UISourceCode.prototype.checkContentUpdated.updatedContentLoaded):
932         (WebInspector.UISourceCode.prototype.checkContentUpdated):
933         * inspector/front-end/UISourceCodeFrame.js:
934         (WebInspector.UISourceCodeFrame.prototype.wasShown):
935         (WebInspector.UISourceCodeFrame.prototype.willHide):
936         (WebInspector.UISourceCodeFrame.prototype._windowFocused):
937         (WebInspector.UISourceCodeFrame.prototype._checkContentUpdated):
938         * inspector/front-end/Workspace.js:
939         (WebInspector.ProjectDelegate.prototype.requestUpdatedFileContent):
940         (WebInspector.Project.prototype.requestUpdatedFileContent):
941
942 2013-03-03  Arpita Bahuguna  <a.bah@samsung.com>
943
944         createAttribute/setAttributeNode does not properly normalize case
945         https://bugs.webkit.org/show_bug.cgi?id=90341
946
947         Reviewed by Darin Adler.
948
949         setAttributeNode() verifies for existing attributes in a case sensitive
950         manner. Thus, it would add another attribute if specified in a case
951         different from the existing one. Instead, like setAttribute(), it too
952         should modify the existing attribute's value.
953
954         Test: fast/dom/Element/setAttributeNode-case-insensitivity.html
955
956         * dom/Element.cpp:
957         (WebCore::Element::setAttributeNode):
958         Made changes to check for an existing attribute by converting the
959         specified attribute's localName to lowercase.
960
961 2013-03-03  Kentaro Hara  <haraken@chromium.org>
962
963         Unreviewed. Rebaselined run-bindings-tests.
964
965         * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
966         (WebCore::TestActiveDOMObjectV8Internal::indexedSecurityCheck):
967         (TestActiveDOMObjectV8Internal):
968         (WebCore::TestActiveDOMObjectV8Internal::namedSecurityCheck):
969         (WebCore::ConfigureV8TestActiveDOMObjectTemplate):
970         * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
971         (V8TestActiveDOMObject):
972
973 2013-03-03  Kentaro Hara  <haraken@chromium.org>
974
975         Unreviewed build fix after r144590.
976
977         * bindings/scripts/CodeGeneratorV8.pm:
978         (GenerateSecurityCheckFunctions):
979
980 2013-03-03  Kentaro Hara  <haraken@chromium.org>
981
982         Unreviewed build fix after r144587.
983
984         * bindings/v8/V8Binding.cpp:
985         (WebCore::toV8Context):
986         * bindings/v8/V8MutationCallback.cpp:
987         (WebCore::V8MutationCallback::V8MutationCallback):
988
989 2013-03-01  Kentaro Hara  <haraken@chromium.org>
990
991         [V8] HTMLDocument.all should have [Replaceable]
992         https://bugs.webkit.org/show_bug.cgi?id=111230
993
994         Reviewed by Adam Barth.
995
996         (Although HTMLDocument.all is already removed from the spec,)
997         it is expected to behave as a [Replaceable] attribute. By adding
998         a [Replaceable] IDL attribute, we can remove custom implementation
999         of HTMLDocument.all.
1000
1001         I confimed that exactly the same code is generated for .all getter
1002         and setter.
1003
1004         No tests. No change in behavior.
1005
1006         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
1007         * html/HTMLDocument.idl:
1008
1009 2013-03-01  Kentaro Hara  <haraken@chromium.org>
1010
1011         [V8] indexedSecurityCheck() and namedSecurityCheck() should be auto-generated
1012         https://bugs.webkit.org/show_bug.cgi?id=111225
1013
1014         Reviewed by Adam Barth.
1015
1016         indexedSecurityCheck() and namedSecurityCheck() should be auto-generated,
1017         except for DOMWindow's ones.
1018
1019         No tests. No change in behavior.
1020
1021         * bindings/scripts/CodeGeneratorV8.pm:
1022         (GenerateHeader):
1023         (GenerateImplementation):
1024         (GenerateSecurityCheckFunctions):
1025         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1026         (WebCore::V8DOMWindow::namedSecurityCheckCustom):
1027         (WebCore::V8DOMWindow::indexedSecurityCheckCustom):
1028         * bindings/v8/custom/V8HistoryCustom.cpp:
1029         * bindings/v8/custom/V8LocationCustom.cpp:
1030
1031 2013-03-01  Kentaro Hara  <haraken@chromium.org>
1032
1033         [V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
1034         https://bugs.webkit.org/show_bug.cgi?id=111214
1035
1036         Reviewed by Adam Barth.
1037
1038         $implContentDecls stores generated code that is put in a namespace 'XXXV8Internal'.
1039         For clarification, it should be renamed to $implContentInternals.
1040
1041         No tests. No change in behavior.
1042
1043         * bindings/scripts/CodeGeneratorV8.pm:
1044         (GenerateDomainSafeFunctionGetter):
1045         (GenerateDomainSafeFunctionSetter):
1046         (GenerateConstructorGetter):
1047         (GenerateNormalAttrGetterCallback):
1048         (GenerateNormalAttrGetter):
1049         (GenerateReplaceableAttrSetterCallback):
1050         (GenerateReplaceableAttrSetter):
1051         (GenerateNormalAttrSetterCallback):
1052         (GenerateNormalAttrSetter):
1053         (GenerateOverloadedFunction):
1054         (GenerateFunctionCallback):
1055         (GenerateFunction):
1056         (GenerateOverloadedConstructorCallback):
1057         (GenerateSingleConstructorCallback):
1058         (GenerateEventConstructor):
1059         (GenerateTypedArrayConstructor):
1060         (GenerateImplementation):
1061         (WriteData):
1062
1063 2013-03-01  Kentaro Hara  <haraken@chromium.org>
1064
1065         [V8] Rename getWorld() to isolatedWorld(), and getWorldForEnteredContext() to isolatedWorldForEnteredContext()
1066         https://bugs.webkit.org/show_bug.cgi?id=111212
1067
1068         Reviewed by Adam Barth.
1069
1070         The rename I did in r142424 was wrong. Given that getWorld() returns 0
1071         for the main world, it should be named isolatedWorld(). Similarly,
1072         given that getWorldForEnteredContext() returns 0 for the main world,
1073         it should be named isolatedWorldForEnteredContext().
1074
1075         No tests. No change in behavior.
1076
1077         * bindings/v8/CustomElementHelpers.cpp:
1078         (WebCore::CustomElementHelpers::isFeatureAllowed):
1079         * bindings/v8/DOMDataStore.cpp:
1080         (WebCore::DOMDataStore::current):
1081         * bindings/v8/DOMWrapperWorld.cpp:
1082         (WebCore::DOMWrapperWorld::makeContextWeak):
1083         * bindings/v8/DOMWrapperWorld.h:
1084         (WebCore::DOMWrapperWorld::isolatedWorld):
1085         * bindings/v8/ScriptController.cpp:
1086         (WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
1087         (WebCore::ScriptController::currentWorldContext):
1088         * bindings/v8/V8Binding.h:
1089         (WebCore::isolatedWorldForEnteredContext):
1090         * bindings/v8/WorldContextHandle.cpp:
1091         (WebCore::WorldContextHandle::WorldContextHandle):
1092         * bindings/v8/custom/V8DocumentCustom.cpp:
1093         (WebCore::wrap):
1094         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
1095         (WebCore::wrap):
1096         * bindings/v8/custom/V8SVGDocumentCustom.cpp:
1097         (WebCore::wrap):
1098         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
1099         (WebCore::V8XMLHttpRequest::constructorCustom):
1100
1101 2013-03-01  Kentaro Hara  <haraken@chromium.org>
1102
1103         [V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
1104         https://bugs.webkit.org/show_bug.cgi?id=111223
1105
1106         Reviewed by Adam Barth.
1107
1108         HTMLDocument::getNamedProperty() is used by DOMWindowShell.
1109         It can be a static method in DOMWindowShell.
1110
1111         No tests. No change in behavior.
1112
1113         * bindings/scripts/CodeGeneratorV8.pm:
1114         (GenerateHeader):
1115         * bindings/v8/V8DOMWindowShell.cpp:
1116         (WebCore::getNamedProperty):
1117         (WebCore):
1118         (WebCore::getter):
1119         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
1120
1121 2013-03-03  Dan Bernstein  <mitz@apple.com>
1122
1123         Build fix after r144565. Reverted r144533.
1124
1125         * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
1126
1127 2013-03-03  Adam Barth  <abarth@webkit.org>
1128
1129         Attempt to fix the Qt build after r144498
1130         https://bugs.webkit.org/show_bug.cgi?id=111272
1131
1132         Reviewed by Eric Seidel.
1133
1134         Update the Qt version of the XML parser to call the new API.
1135
1136         * xml/parser/XMLDocumentParserQt.cpp:
1137         (WebCore::XMLDocumentParser::resumeParsing):
1138         (WebCore::XMLDocumentParser::appendFragmentSource):
1139
1140 2013-03-03  Dean Jackson  <dino@apple.com>
1141
1142         Plug-ins that are appropriately large w.r.t page size should autostart
1143         https://bugs.webkit.org/show_bug.cgi?id=111242
1144
1145         Reviewed by Brady Eidson.
1146
1147         A "full-page" plug-in site should never snapshot. The trick is
1148         how to determine what is full-page. This change implements the
1149         following algorithm.
1150
1151         - The plug-in is in the main frame (not an iframe).
1152         - The plug-in is sized with width and height 100%.
1153         - The displayed area of the plug-in is more than 96% of the viewport area.
1154
1155         This is definitely not foolproof. For example, zombo.com has a slight
1156         border around its plug-in. As the window size gets smaller, the body margin
1157         takes up more than 5% of the width or height, and the plug-in doesn't pass
1158         the tests above.
1159
1160         * html/HTMLPlugInImageElement.cpp:
1161         (WebCore): New static constant: sizingFullPageThresholdPercentage
1162         (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Implements
1163             the rules described above.
1164
1165 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1166
1167         [Win] IDLParser.pm fails to parse OESTextureHalfFloat and causes a build failure
1168         https://bugs.webkit.org/show_bug.cgi?id=111267
1169
1170         Reviewed by Kentaro Hara.
1171
1172         Allow empty definitions.
1173
1174         * bindings/scripts/IDLParser.pm:
1175         (Parse):
1176
1177 2013-03-03  David Kilzer  <ddkilzer@apple.com>
1178
1179         BUILD FIX: RenderLayerFilterInfo.h needs to include Element.h with ENABLE(SVG)
1180
1181         Fixes the following build failures:
1182
1183             In file included from Source/WebCore/rendering/RenderLayerFilterInfo.cpp:33:
1184             Source/WebCore/rendering/RenderLayerFilterInfo.h:118:19: error: use of undeclared identifier 'Element'
1185                 Vector<RefPtr<Element> > m_internalSVGReferences;
1186                               ^
1187             Source/WebCore/rendering/RenderLayerFilterInfo.h:118:28: error: expected a type
1188                 Vector<RefPtr<Element> > m_internalSVGReferences;
1189                                        ^
1190             Source/WebCore/rendering/RenderLayerFilterInfo.h:118:30: error: private field 'm_internalSVGReferences' is not used [-Werror,-Wunused-private-field]
1191                 Vector<RefPtr<Element> > m_internalSVGReferences;
1192                                          ^
1193             3 errors generated.
1194
1195         * rendering/RenderLayerFilterInfo.h: Include Element.h within
1196         ENABLE(SVG).  Move ENABLE(SVG) block below unconditional
1197         headers.
1198
1199 2013-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1200
1201         Unreviewed, rolling out r144567.
1202         http://trac.webkit.org/changeset/144567
1203         https://bugs.webkit.org/show_bug.cgi?id=111266
1204
1205         Does not compile on apple-win (Requested by abarth on
1206         #webkit).
1207
1208         * WebCore.exp.in:
1209         * dom/Document.cpp:
1210         (WebCore::Document::iconURLs):
1211         * dom/Document.h:
1212         (Document):
1213         * loader/icon/IconController.cpp:
1214         (WebCore::IconController::iconURL):
1215         (WebCore::IconController::urlsForTypes):
1216         * loader/icon/IconController.h:
1217         (IconController):
1218         * testing/Internals.cpp:
1219         (WebCore::Internals::iconURLs):
1220         * testing/Internals.h:
1221         * testing/Internals.idl:
1222
1223 2013-03-03  Mike West  <mkwst@chromium.org>
1224
1225         CSP 1.1: Support CSP 1.1 directives on the unprefixed header.
1226         https://bugs.webkit.org/show_bug.cgi?id=111254
1227
1228         Reviewed by Adam Barth.
1229
1230         We'd like to ensure that early adopters don't get stuck on a prefixed
1231         header; when CSP 1.1 is baked enough to be supported in multiple
1232         browsers, everything should Just Work™.
1233
1234         This patch changes WebKit's behavior regarding CSP_NEXT features.
1235         Currently, they're only exposed on the prefixed header ('X-WebKit-CSP').
1236         This patch exposes those features on the canonical header, assuming
1237         that the runtime flag is set. This shouldn't have any effect at all on
1238         ports that haven't yet enabled CSP_NEXT, and will simply clear the way
1239         for a clean deployment to a wider audience once the specification
1240         process is further along.
1241
1242         This change shouldn't have any effect on the existing tests: they
1243         should run just as they did before. The next step will be to adjust
1244         the LayoutTests for 1.1 to prefer the canonical header, but I'll do
1245         that in another patch to reduce churn.
1246
1247         Related, the enum names no longer made sense: the difference between the
1248         canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
1249         prefix, not the functionality. This patch renames them for clarity.
1250
1251         * dom/Document.cpp:
1252         (WebCore::Document::processHttpEquiv):
1253         * loader/FrameLoader.cpp:
1254         (WebCore::FrameLoader::didBeginDocument):
1255             Use the new enum names.
1256         * page/ContentSecurityPolicy.cpp:
1257         (CSPDirectiveList):
1258         (WebCore::CSPDirectiveList::CSPDirectiveList):
1259         (WebCore::CSPDirectiveList::addDirective):
1260             Drop the 'm_experimental' property from CSPDirectiveList; we'll
1261             control the behavior via the runtime flag from now on.
1262
1263             Also, this fixes a small bug in 'addDirective()': we never threw
1264             unrecognized directive errors for users who were sending the
1265             prefixed header. Oops!
1266         (WebCore::ContentSecurityPolicy::deprecatedHeaderType):
1267             Use the new enum names.
1268         * page/ContentSecurityPolicy.h:
1269             Redefine the enum for clarity: 'PrefixedReport' and 'Report'
1270             rather than 'ReportAllDirectives' and 'ReportStableDirectives'.
1271
1272 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1273
1274         Another Windows build fix attempt after r144567.
1275         Try touching the IDL file in a hope it'll regenerate JSInternals.cpp.
1276
1277         * testing/Internals.idl:
1278
1279 2013-03-03  Adam Barth  <abarth@webkit.org>
1280
1281         Unreviewed attempted build fix. Adds back some includes removed in
1282         http://trac.webkit.org/changeset/144565.
1283
1284         * Modules/mediastream/RTCPeerConnection.cpp:
1285         * bindings/ScriptControllerBase.cpp:
1286         * bindings/objc/DOM.mm:
1287         * bindings/v8/ScriptController.cpp:
1288         * bindings/v8/V8DOMWindowShell.cpp:
1289         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1290         * css/CSSFontSelector.cpp:
1291         * css/WebKitCSSSVGDocumentValue.cpp:
1292         * dom/DOMImplementation.cpp:
1293         * dom/PendingScript.h:
1294         * dom/ScriptElement.cpp:
1295         * dom/ScriptElement.h:
1296         * history/CachedFrame.cpp:
1297         * html/DOMURL.cpp:
1298         * html/HTMLAnchorElement.cpp:
1299         * html/HTMLAppletElement.cpp:
1300         * html/HTMLElement.cpp:
1301         * html/HTMLEmbedElement.cpp:
1302         * html/HTMLFrameSetElement.cpp:
1303         * html/HTMLHtmlElement.cpp:
1304         * html/HTMLImageElement.cpp:
1305         * html/HTMLObjectElement.cpp:
1306         * html/HTMLPlugInElement.cpp:
1307         * html/ImageDocument.cpp:
1308         * html/ImageInputType.cpp:
1309         * html/MediaDocument.cpp:
1310         * html/PluginDocument.cpp:
1311         * html/canvas/WebGLRenderingContext.cpp:
1312         (WebCore):
1313         * html/parser/HTMLConstructionSite.cpp:
1314         * html/parser/HTMLParserOptions.cpp:
1315         * html/parser/XSSAuditorDelegate.cpp:
1316         * inspector/InspectorDebuggerAgent.cpp:
1317         * inspector/InspectorFileSystemAgent.cpp:
1318         * inspector/InspectorFrontendHost.cpp:
1319         * inspector/InspectorInstrumentation.h:
1320         * inspector/InspectorPageAgent.cpp:
1321         * inspector/NetworkResourcesData.cpp:
1322         * inspector/NetworkResourcesData.h:
1323         (WebCore):
1324         * loader/CookieJar.cpp:
1325         * loader/CrossOriginAccessControl.cpp:
1326         * loader/FrameLoader.cpp:
1327         * loader/MainResourceLoader.cpp:
1328         * loader/MixedContentChecker.cpp:
1329         * loader/PingLoader.cpp:
1330         * loader/SubframeLoader.cpp:
1331         * loader/SubresourceLoader.cpp:
1332         * loader/appcache/ApplicationCacheGroup.cpp:
1333         * loader/appcache/ApplicationCacheHost.cpp:
1334         * loader/cache/CachedResource.cpp:
1335         * loader/icon/IconController.cpp:
1336         * page/DOMWindowExtension.cpp:
1337         * page/Frame.cpp:
1338         * page/PerformanceTiming.cpp:
1339         * page/PointerLockController.cpp:
1340         * page/animation/CSSPropertyAnimation.cpp:
1341         * platform/chromium/PasteboardChromium.cpp:
1342         * platform/efl/ErrorsEfl.cpp:
1343         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
1344         * platform/gtk/ErrorsGtk.cpp:
1345         * platform/gtk/PasteboardGtk.cpp:
1346         * platform/gtk/PasteboardHelper.h:
1347         * platform/mac/ClipboardMac.mm:
1348         * platform/mac/HTMLConverter.mm:
1349         * platform/qt/PasteboardQt.cpp:
1350         * plugins/DOMMimeType.cpp:
1351         * plugins/PluginView.cpp:
1352         * rendering/HitTestResult.cpp:
1353         * rendering/RenderImage.cpp:
1354         * rendering/RenderImageResource.cpp:
1355         * rendering/RenderImageResourceStyleImage.cpp:
1356         * rendering/RenderLayer.cpp:
1357         * rendering/RenderLayerBacking.cpp:
1358         * svg/SVGImageLoader.cpp:
1359         * svg/SVGUseElement.cpp:
1360         * testing/MockPagePopupDriver.cpp:
1361         * xml/XSLStyleSheet.h:
1362         (WebCore):
1363
1364 2013-03-03  Ruslan Abdikeev  <aruslan@chromium.org>
1365
1366         <link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
1367         https://bugs.webkit.org/show_bug.cgi?id=109061
1368
1369         Reviewed by Adam Barth.
1370
1371         Test: fast/dom/icon-url-list-apple-touch.html
1372
1373         Added iconTypes parameter to Document::iconURLs().
1374         Added Document::shortcutIconURLs() with original semantics of iconURLs().
1375         Fixed IconController.cpp to provide iconTypesMask to iconURLs().
1376         Renamed iconTypes to iconTypesMask to make the meaning clearer.
1377
1378         * WebCore.exp.in:
1379         * dom/Document.cpp:
1380         (WebCore::Document::shortcutIconURLs):
1381         (WebCore):
1382         (WebCore::Document::iconURLs):
1383         * dom/Document.h:
1384         (Document):
1385         * loader/icon/IconController.cpp:
1386         (WebCore::IconController::iconURL):
1387         (WebCore::IconController::urlsForTypes):
1388         * testing/Internals.cpp:
1389         (WebCore::Internals::iconURLs):
1390         (WebCore::Internals::shortcutIconURLs):
1391         (WebCore):
1392         (WebCore::Internals::allIconURLs):
1393         * testing/Internals.h:
1394         * testing/Internals.idl:
1395
1396 2013-03-03  Mike West  <mkwst@chromium.org>
1397
1398         CSP: Throw a warning when a '*-report-only' header doesn't contain a 'report-uri' directive.
1399         https://bugs.webkit.org/show_bug.cgi?id=111208
1400
1401         Reviewed by Adam Barth.
1402
1403         Developers in the wild have been observed to serve a report-only CSP
1404         header with a policy that doesn't contain a 'report-uri' directive.
1405         This has zero effect, of course, and we should help them understand
1406         that by throwing a warning up on the console.
1407
1408         Test: http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html
1409
1410         * page/ContentSecurityPolicy.cpp:
1411         (WebCore::CSPDirectiveList::isReportOnly): Added.
1412         (WebCore::CSPDirectiveList::reportURIs): Added.
1413         (WebCore::CSPDirectiveList::create):
1414             After creating a CSPDirectiveList, check whether it's in
1415             report-only mode without a report-uri. If so, warn the developer.
1416         (WebCore::ContentSecurityPolicy::reportMissingReportURI): Added.
1417             Write an exciting message to the console, warning the developer
1418             about her expensive no-op machine.
1419
1420 2013-03-03  Adam Barth  <abarth@webkit.org>
1421
1422         Unreviewed rollout of http://trac.webkit.org/r144530
1423         As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
1424         https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
1425         large number of ASSERTs in chromium-win.
1426
1427         * CMakeLists.txt:
1428         * GNUmakefile.list.am:
1429         * Modules/mediastream/RTCPeerConnection.cpp:
1430         * Modules/notifications/Notification.cpp:
1431         * Target.pri:
1432         * WebCore.exp.in:
1433         * WebCore.gypi:
1434         * WebCore.vcproj/WebCore.vcproj:
1435         * WebCore.vcxproj/WebCore.vcxproj:
1436         * WebCore.vcxproj/WebCore.vcxproj.filters:
1437         * WebCore.xcodeproj/project.pbxproj:
1438         * bindings/ScriptControllerBase.cpp:
1439         * bindings/js/JSNodeCustom.cpp:
1440         * bindings/js/ScriptController.cpp:
1441         * bindings/js/ScriptSourceCode.h:
1442         (WebCore):
1443         * bindings/objc/DOM.mm:
1444         * bindings/v8/ScriptController.cpp:
1445         * bindings/v8/V8DOMWindowShell.cpp:
1446         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1447         * css/CSSCrossfadeValue.h:
1448         (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
1449         (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
1450         * css/CSSFontFaceSource.h:
1451         * css/CSSFontSelector.cpp:
1452         * css/WebKitCSSSVGDocumentValue.cpp:
1453         * css/WebKitCSSSVGDocumentValue.h:
1454         (WebCore):
1455         * dom/Clipboard.cpp:
1456         (WebCore::Clipboard::Clipboard):
1457         * dom/ContainerNode.cpp:
1458         * dom/DOMImplementation.cpp:
1459         * dom/PendingScript.h:
1460         * dom/ScriptElement.cpp:
1461         * dom/ScriptElement.h:
1462         * history/CachedFrame.cpp:
1463         * html/DOMURL.cpp:
1464         * html/HTMLAnchorElement.cpp:
1465         * html/HTMLAppletElement.cpp:
1466         * html/HTMLElement.cpp:
1467         * html/HTMLEmbedElement.cpp:
1468         * html/HTMLFrameSetElement.cpp:
1469         * html/HTMLHtmlElement.cpp:
1470         * html/HTMLImageElement.cpp:
1471         * html/HTMLObjectElement.cpp:
1472         * html/HTMLPlugInElement.cpp:
1473         * html/ImageDocument.cpp:
1474         * html/ImageInputType.cpp:
1475         * html/MediaDocument.cpp:
1476         * html/PluginDocument.cpp:
1477         * html/canvas/WebGLRenderingContext.cpp:
1478         (WebCore):
1479         * html/parser/HTMLConstructionSite.cpp:
1480         * html/parser/HTMLParserOptions.cpp:
1481         * html/parser/HTMLScriptRunner.h:
1482         * html/parser/XSSAuditor.cpp:
1483         * html/parser/XSSAuditorDelegate.cpp:
1484         * inspector/InspectorDebuggerAgent.cpp:
1485         * inspector/InspectorFileSystemAgent.cpp:
1486         * inspector/InspectorFrontendHost.cpp:
1487         * inspector/InspectorInstrumentation.h:
1488         (WebCore):
1489         * inspector/InspectorPageAgent.cpp:
1490         * inspector/NetworkResourcesData.cpp:
1491         * inspector/NetworkResourcesData.h:
1492         (WebCore):
1493         * loader/CookieJar.cpp:
1494         * loader/CrossOriginAccessControl.cpp:
1495         * loader/CrossOriginAccessControl.h:
1496         (WebCore):
1497         * loader/CrossOriginPreflightResultCache.h:
1498         * loader/DocumentThreadableLoader.h:
1499         * loader/FrameLoader.cpp:
1500         (WebCore::FrameLoader::FrameLoader):
1501         * loader/FrameLoader.h:
1502         (WebCore):
1503         (WebCore::FrameLoader::policyChecker):
1504         * loader/ImageLoader.cpp:
1505         * loader/ImageLoader.h:
1506         * loader/LinkLoader.h:
1507         (WebCore):
1508         * loader/MainResourceLoader.cpp:
1509         * loader/MainResourceLoader.h:
1510         (WebCore):
1511         * loader/MixedContentChecker.cpp:
1512         * loader/PingLoader.cpp:
1513         * loader/PolicyChecker.h:
1514         (WebCore):
1515         * loader/ProgressTracker.cpp:
1516         * loader/SubframeLoader.cpp:
1517         * loader/SubresourceLoader.cpp:
1518         * loader/TextTrackLoader.cpp:
1519         * loader/TextTrackLoader.h:
1520         (WebCore):
1521         * loader/ThreadableLoader.h:
1522         * loader/appcache/ApplicationCacheGroup.cpp:
1523         * loader/appcache/ApplicationCacheGroup.h:
1524         (WebCore):
1525         * loader/appcache/ApplicationCacheHost.cpp:
1526         * loader/archive/cf/LegacyWebArchive.cpp:
1527         * loader/cache/CachedFont.cpp:
1528         * loader/cache/CachedFont.h:
1529         (CachedFontClient):
1530         (WebCore::CachedFontClient::~CachedFontClient):
1531         (WebCore::CachedFontClient::expectedType):
1532         (WebCore::CachedFontClient::resourceClientType):
1533         (WebCore::CachedFontClient::fontLoaded):
1534         (WebCore):
1535         * loader/cache/CachedFontClient.h: Removed.
1536         * loader/cache/CachedImage.cpp:
1537         * loader/cache/CachedRawResource.cpp:
1538         * loader/cache/CachedRawResource.h:
1539         (WebCore):
1540         (CachedRawResourceClient):
1541         (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
1542         (WebCore::CachedRawResourceClient::expectedType):
1543         (WebCore::CachedRawResourceClient::resourceClientType):
1544         (WebCore::CachedRawResourceClient::dataSent):
1545         (WebCore::CachedRawResourceClient::responseReceived):
1546         (WebCore::CachedRawResourceClient::dataReceived):
1547         (WebCore::CachedRawResourceClient::redirectReceived):
1548         (WebCore::CachedRawResourceClient::dataDownloaded):
1549         * loader/cache/CachedRawResourceClient.h: Removed.
1550         * loader/cache/CachedResource.cpp:
1551         * loader/cache/CachedResourceHandle.cpp:
1552         (WebCore):
1553         * loader/cache/CachedResourceHandle.h:
1554         (WebCore):
1555         (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
1556         (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
1557         * loader/cache/CachedSVGDocument.h:
1558         (CachedSVGDocumentClient):
1559         (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
1560         (WebCore::CachedSVGDocumentClient::expectedType):
1561         (WebCore::CachedSVGDocumentClient::resourceClientType):
1562         (WebCore):
1563         * loader/cache/CachedSVGDocumentClient.h: Removed.
1564         * loader/cache/CachedSVGDocumentReference.cpp: Removed.
1565         * loader/cache/CachedSVGDocumentReference.h:
1566         (WebCore):
1567         (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
1568         (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
1569         * loader/cache/CachedStyleSheetClient.h:
1570         (WebCore):
1571         * loader/cache/MemoryCache.h:
1572         (WebCore):
1573         (MemoryCache):
1574         * loader/chromium/CachedRawResourceChromium.cpp:
1575         * loader/icon/IconController.cpp:
1576         * loader/icon/IconLoader.h:
1577         * loader/mac/ResourceLoaderMac.mm:
1578         * page/DOMWindowExtension.cpp:
1579         * page/Frame.cpp:
1580         (WebCore::Frame::Frame):
1581         (WebCore):
1582         (WebCore::Frame::reportMemoryUsage):
1583         * page/Frame.h:
1584         (WebCore):
1585         (Frame):
1586         (WebCore::Frame::init):
1587         (WebCore::Frame::loader):
1588         * page/PerformanceNavigation.cpp:
1589         * page/PerformanceTiming.cpp:
1590         * page/PointerLockController.cpp:
1591         * page/Settings.cpp:
1592         * page/animation/CSSPropertyAnimation.cpp:
1593         * platform/chromium/PasteboardChromium.cpp:
1594         * platform/efl/ErrorsEfl.cpp:
1595         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1596         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
1597         * platform/graphics/filters/FilterOperation.cpp:
1598         (WebCore):
1599         * platform/graphics/filters/FilterOperation.h:
1600         (WebCore):
1601         (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
1602         (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
1603         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
1604         * platform/gtk/ErrorsGtk.cpp:
1605         * platform/gtk/PasteboardGtk.cpp:
1606         * platform/gtk/PasteboardHelper.h:
1607         * platform/mac/ClipboardMac.h:
1608         * platform/mac/ClipboardMac.mm:
1609         * platform/mac/HTMLConverter.mm:
1610         * platform/mac/PasteboardMac.mm:
1611         * platform/network/AuthenticationChallengeBase.cpp:
1612         * platform/network/cf/CookieJarCFNet.cpp:
1613         * platform/network/cf/ResourceRequestCFNet.cpp:
1614         * platform/network/mac/CookieStorageMac.mm:
1615         * platform/qt/PasteboardQt.cpp:
1616         * plugins/DOMMimeType.cpp:
1617         * plugins/PluginRequest.h: Removed.
1618         * plugins/PluginStream.h:
1619         (PluginStreamClient):
1620         (WebCore::PluginStreamClient::~PluginStreamClient):
1621         (WebCore::PluginStreamClient::streamDidFinishLoading):
1622         (WebCore):
1623         * plugins/PluginStreamClient.h: Removed.
1624         * plugins/PluginView.cpp:
1625         * plugins/PluginView.h:
1626         (WebCore):
1627         (PluginRequest):
1628         (WebCore::PluginRequest::PluginRequest):
1629         (WebCore::PluginRequest::frameLoadRequest):
1630         (WebCore::PluginRequest::notifyData):
1631         (WebCore::PluginRequest::sendNotification):
1632         (WebCore::PluginRequest::shouldAllowPopups):
1633         * rendering/HitTestResult.cpp:
1634         * rendering/InlineFlowBox.cpp:
1635         * rendering/RenderBox.cpp:
1636         * rendering/RenderEmbeddedObject.cpp:
1637         * rendering/RenderImage.cpp:
1638         * rendering/RenderImageResource.cpp:
1639         (WebCore::RenderImageResource::RenderImageResource):
1640         (WebCore):
1641         * rendering/RenderImageResource.h:
1642         (WebCore::RenderImageResource::image):
1643         (WebCore::RenderImageResource::errorOccurred):
1644         (WebCore::RenderImageResource::usesImageContainerSize):
1645         (WebCore::RenderImageResource::imageHasRelativeWidth):
1646         (WebCore::RenderImageResource::imageHasRelativeHeight):
1647         (WebCore::RenderImageResource::imageSize):
1648         * rendering/RenderImageResourceStyleImage.cpp:
1649         * rendering/RenderLayer.cpp:
1650         * rendering/RenderLayerBacking.cpp:
1651         * rendering/RenderLayerFilterInfo.h:
1652         (WebCore):
1653         * rendering/RenderListItem.cpp:
1654         * rendering/RenderListMarker.cpp:
1655         * rendering/RenderSnapshottedPlugIn.cpp:
1656         * rendering/RenderTableCol.cpp:
1657         * rendering/RenderTableRow.cpp:
1658         * rendering/RenderTableSection.cpp:
1659         * rendering/style/StyleCachedShader.h:
1660         * rendering/style/StyleCustomFilterProgram.cpp: Removed.
1661         * rendering/style/StyleCustomFilterProgram.h:
1662         (WebCore):
1663         (WebCore::StyleCustomFilterProgram::vertexShaderString):
1664         (StyleCustomFilterProgram):
1665         (WebCore::StyleCustomFilterProgram::fragmentShaderString):
1666         (WebCore::StyleCustomFilterProgram::isLoaded):
1667         (WebCore::StyleCustomFilterProgram::willHaveClients):
1668         (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
1669         (WebCore::StyleCustomFilterProgram::notifyFinished):
1670         * svg/SVGFEImageElement.h:
1671         * svg/SVGFontFaceUriElement.h:
1672         (SVGFontFaceUriElement):
1673         * svg/SVGImageLoader.cpp:
1674         * svg/SVGUseElement.cpp:
1675         * svg/SVGUseElement.h:
1676         * svg/graphics/SVGImageCache.cpp:
1677         * testing/MockPagePopupDriver.cpp:
1678         * xml/XSLStyleSheet.h:
1679         (WebCore):
1680         * xml/XSLTProcessorLibxslt.cpp:
1681         * xml/parser/XMLDocumentParser.cpp:
1682         * xml/parser/XMLDocumentParser.h:
1683         * xml/parser/XMLDocumentParserLibxml2.cpp:
1684
1685 2013-03-03  Kentaro Hara  <haraken@chromium.org>
1686
1687         [V8] Remove TranslateParameter() from CodeGeneratorV8.pm
1688         https://bugs.webkit.org/show_bug.cgi?id=111218
1689
1690         Reviewed by Adam Barth.
1691
1692         TranslateParameter() does nothing. It tries to convert TimeoutHandler to DOMString,
1693         but there is no non-custom method that uses TimeoutHandler.
1694
1695         The only place where TimeoutHandler is used in the WebKit IDL is setTimeout() and setInterval().
1696         However, the latest spec uses 'any' instead of TimeoutHandler.
1697         http://dev.w3.org/html5/spec-LC/timers.html
1698         Thus, this patch updates the IDL declarations of setTimeout() and setInterval()
1699         according to the spec. By this change, TimeoutHandler is gone away from the WebKit IDL.
1700         (Anyway this IDL change has no effect, because setTimeout() and setInterval() are written
1701         in custom bindings.)
1702
1703         No tests. No change in behavior.
1704
1705         * bindings/scripts/CodeGeneratorV8.pm:
1706         (GenerateParametersCheck):
1707         * page/DOMWindow.idl:
1708         * workers/WorkerContext.idl:
1709
1710 2013-03-03  James Weatherall  <wez@chromium.org>
1711
1712         keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
1713         https://bugs.webkit.org/show_bug.cgi?id=85642
1714
1715         Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.
1716
1717         Reviewed by Adam Barth.
1718
1719         * platform/chromium/KeyCodeConversionGtk.cpp:
1720         (WebCore::windowsKeyCodeForKeyEvent):
1721
1722 2013-03-03  Adam Barth  <abarth@webkit.org>
1723
1724         REGRESSION(144520): Does not compile on chromium-win
1725         https://bugs.webkit.org/show_bug.cgi?id=111261
1726
1727         Unreviewed rollout of http://trac.webkit.org/changeset/144520. This
1728         patch does not compile for chromium-win. See the bug for the compile
1729         error.
1730
1731         * rendering/ExclusionShapeInsideInfo.cpp:
1732         * rendering/ExclusionShapeInsideInfo.h:
1733         (WebCore):
1734         (LineSegmentRange):
1735         (WebCore::LineSegmentRange::LineSegmentRange):
1736         (WebCore::ExclusionShapeInsideInfo::isEnabledFor):
1737         * rendering/RenderBlock.cpp:
1738         (WebCore::RenderBlock::willBeDestroyed):
1739         (WebCore::RenderBlock::exclusionShapeInsideInfo):
1740         (WebCore):
1741         (WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
1742         * rendering/RenderBlock.h:
1743         (WebCore):
1744         (RenderBlock):
1745         (RenderBlockRareData):
1746         * rendering/RenderBlockLineLayout.cpp:
1747         (WebCore::constructBidiRunsForLine):
1748
1749 2013-03-02  Zan Dobersek  <zdobersek@igalia.com>
1750
1751         REGRESSION (r144517): IndexedDB layout test failures on GTK
1752         https://bugs.webkit.org/show_bug.cgi?id=111243
1753
1754         Reviewed by Martin Robinson.
1755
1756         Changes to the custom JSC bindings for IDBAny are required after r144517,
1757         specifically the case of IDBAny object having the KeyPathType type has to be covered.
1758         These changes are analogous to those made to the V8 bindings in the mentioned commit.
1759
1760         No new tests - already covered by existing tests.
1761
1762         * bindings/js/JSIDBAnyCustom.cpp:
1763         (WebCore::toJS): A helper function that wraps an IDBKeyPath into a JSValue.
1764         (WebCore): Shuffle the order inside the switch statement a bit to match the V8 custom bindings.
1765         Cover the case where the IDBAny object has the KeyPathType, calling the new helper method.
1766
1767 2013-03-02  Darin Adler  <darin@apple.com>
1768
1769         Another try at fixing the build.
1770
1771         * loader/cache/MemoryCache.cpp: Added an include of CachedResourceHandle.h.
1772
1773 2013-03-02  Darin Adler  <darin@apple.com>
1774
1775         Try to fix build.
1776
1777         * inspector/InspectorInstrumentation.h: Add missing forward declaration
1778         of CachedResource.
1779
1780 2013-02-18  Darin Adler  <darin@apple.com>
1781
1782         Cut down the number of source files that depend on Clipboard.h
1783         https://bugs.webkit.org/show_bug.cgi?id=110030
1784
1785         Reviewed by Ryosuke Niwa.
1786
1787         I am doing some work on Clipboard and it's better to recompile 50 files
1788         each time we touch the header instead of 700. Also cut down on includes
1789         of DragState.h.
1790
1791         * WebCore.exp.in: Updated for new MouseEvent::create function.
1792
1793         * dom/ClipboardEvent.cpp: Added include of Clipboard.h since we use it
1794         here and the world no longer includes it everywhere.
1795
1796         * dom/ClipboardEvent.h: Forward declared Clipboard instead of including
1797         Clipboard.h. Also made some overrides private because they can be.
1798
1799         * dom/DataTransferItem.h: Removed unneeded include of Clipboard.h.
1800
1801         * dom/MouseEvent.cpp: Added include of Clipboard.h since we use it
1802         here and the world no longer includes it everywhere.
1803         (WebCore::MouseEvent::create): Made the create function non-inline
1804         since we can't compile it without including Clipboard.h and we don't
1805         want to include Clipboard.h in the header. This is not so commonly
1806         used or so hot that this needs to be inlined.
1807
1808         * dom/MouseEvent.h: Forward declared Clipboard instead of including
1809         Clipboard.h. Made MouseEvent::create a non-inline function and also
1810         used overloading instead of default arguments, since we can't compile
1811         a default argument of type PassRefPtr<Clipboard> without including
1812         Clipboard.h.
1813
1814         * dom/WheelEvent.cpp: Added include of Clipboard.h since we use it
1815         here and the world no longer includes it everywhere.
1816
1817         * dom/WheelEvent.h: Forward declare PlatformWheelEvent since it is used
1818         in this header. Previously we'd get it indirectly from including a header
1819         that included Clipboard.h.
1820
1821         * editing/Editor.cpp: Added include of Clipboard.h since we use it here
1822         and the world no longer includes it everywhere.
1823
1824         * inspector/InspectorDebuggerAgent.cpp: Added include of CachedResource.h.
1825         We used to get this indirectly through Clipboard.h.
1826
1827         * inspector/InspectorFrontendHost.cpp: Added includes of ResourceError.h
1828         and ResourceResponse.h. We used to get these indirectly through Clipboard.h.
1829         Also removed unneeded include of <wtf/RefPtr.h>.
1830
1831         * inspector/NetworkResourcesData.cpp: Added include of CachedResource.h.
1832         We used to get this indirectly through Clipboard.h.
1833
1834         * loader/PingLoader.cpp: Added include of ResourceResponse.h.
1835         We used to get this indirectly through Clipboard.h.
1836
1837         * page/DragController.cpp: Added include of DragState.h.
1838         We used to get this indirectly through EventHandler.h
1839
1840         * page/EventHandler.h: Forward declared DragState and Element instead of
1841         including DragState.h. Also added an include of LayoutPoint.h, which we
1842         used to get indirectly through DragState.h.
1843
1844 2013-02-27  Darin Adler  <darin@apple.com>
1845
1846         StringHasher functions require alignment that call sites do not all guarantee
1847         https://bugs.webkit.org/show_bug.cgi?id=110171
1848
1849         Reviewed by Benjamin Poulain.
1850
1851         * platform/graphics/WidthCache.h:
1852         (WebCore::WidthCache::SmallStringKey::SmallStringKey): Use the newly added
1853         addCharactersAssumingAligned to make sure we don't slow this call site down.
1854         It's safe since this code always adds characters two at a time.
1855
1856 2013-03-02  Adam Barth  <abarth@webkit.org>
1857
1858         XSSAuditor has a subtle race condition when used with the threaded HTML parser
1859         https://bugs.webkit.org/show_bug.cgi?id=111253
1860
1861         Reviewed by Eric Seidel.
1862
1863         We were refing and derefing a StringImpl for a main-thread
1864         AtomicString. Using QualifiedNames on the background thread is very
1865         fragile and we should figure out a more robust solution.
1866
1867         * html/parser/XSSAuditor.cpp:
1868         (WebCore::findAttributeWithName):
1869
1870 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
1871
1872         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
1873         https://bugs.webkit.org/show_bug.cgi?id=109772
1874
1875         Reviewed by Andreas Kling.
1876
1877         The function computedStyleIncludingVisitedInfo() is purely internal to WebCore,
1878         it is better defined on Internals than on TestRunner.
1879
1880         * testing/Internals.cpp:
1881         (WebCore::Internals::computedStyleIncludingVisitedInfo):
1882         * testing/Internals.h:
1883         * testing/Internals.idl:
1884
1885 2013-03-02  David Kilzer  <ddkilzer@apple.com>
1886
1887         BUILD FIX (r143637): Export ScriptController::javaScriptContext() on iOS
1888         <http://webkit.org/b/106059>
1889
1890         Fixes the following build failure:
1891
1892             Undefined symbols for architecture armv7:
1893               "__ZN7WebCore16ScriptController17javaScriptContextEv", referenced from:
1894                   -[WebFrame javaScriptContext] in WebFrame.o
1895                   __ZN20WebFrameLoaderClient35dispatchDidClearWindowObjectInWorldEPN7WebCore15DOMWrapperWorldE in WebFrameLoaderClient.o
1896             ld: symbol(s) not found for architecture armv7
1897
1898         * WebCore.exp.in: Export ScriptController::javaScriptContext()
1899         even more unconditionally.
1900
1901 2013-03-02  Eric Seidel  <eric@webkit.org>
1902
1903         Remove two unnecessary mallocs from the main-thread-parser code path
1904         https://bugs.webkit.org/show_bug.cgi?id=111249
1905
1906         Reviewed by Adam Barth.
1907
1908         I noticed these while fixing up our Vector -> String conversions
1909         but never went back to fix the FIXME.
1910
1911         AtomicString(Vector<UChar, capacity>) is smart enough to avoid mallocing
1912         if the represented string is already in the AtomicString table.  It
1913         also handles 8bit vs. 16bit and empty() just like nameString() does.
1914
1915         I also removed a 3rd caller to nameString() in the XSSAuditor which
1916         was causing an unnecessary malloc in both the main and background
1917         thread parser paths.
1918
1919         * html/parser/AtomicHTMLToken.h:
1920         (WebCore::AtomicHTMLToken::AtomicHTMLToken):
1921         * html/parser/HTMLToken.h:
1922         * html/parser/XSSAuditor.cpp:
1923         (WebCore):
1924         (WebCore::threadSafeMatch):
1925         (WebCore::hasName):
1926
1927 2013-03-02  Eric Seidel  <eric@webkit.org>
1928
1929         constructTreeFromCompactHTMLToken should call clearExternalCharacters
1930         https://bugs.webkit.org/show_bug.cgi?id=111248
1931
1932         Reviewed by Adam Barth.
1933
1934         I don't know how to write a test for this.  It's possible characters()
1935         is never accessed from HTMLStackItem::token(), but it's better to be
1936         safe than sorry here.
1937
1938         * html/parser/HTMLDocumentParser.cpp:
1939         (WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
1940
1941 2013-03-02  Rob Buis  <rbuis@rim.com>
1942
1943         Text overflow ellipsis wrong color when using webkit-text-fill-color
1944         https://bugs.webkit.org/show_bug.cgi?id=54841
1945
1946         Reviewed by David Hyatt.
1947
1948         Take -webkit-text-fill-color into account for ellipsis painting.
1949
1950         Test: fast/css/text-overflow-ellipsis-color.html
1951
1952         * rendering/EllipsisBox.cpp:
1953         (WebCore::EllipsisBox::paint):
1954
1955 2013-03-02  Ryosuke Niwa  <rniwa@webkit.org>
1956
1957         Fix a typo in my previous commit (r144534).
1958
1959         * platform/win/PasteboardWin.cpp:
1960
1961 2013-03-02  Nayan Kumar K  <nayankk@motorola.com>
1962
1963         [WebGL] Support for texImage2D of type HALF_FLOAT_OES with ArrayBufferView.
1964         https://bugs.webkit.org/show_bug.cgi?id=110818
1965
1966         Reviewed by Kenneth Russell.
1967
1968         As per OES_texture_half_float specification texImage2D and texSubImage2D entry
1969         points taking ArrayBufferView should extended to accept null with the pixel type
1970         HALF_FLOAT_OES.
1971
1972         Tests: fast/canvas/webgl/oes-texture-half-float-not-supported.html
1973                fast/canvas/webgl/oes-texture-half-float.html
1974
1975         * CMakeLists.txt:
1976         * DerivedSources.make:
1977         * DerivedSources.pri:
1978         * GNUmakefile.list.am:
1979         * Target.pri:
1980         * WebCore.gypi:
1981         * WebCore.xcodeproj/project.pbxproj:
1982         * bindings/js/JSWebGLRenderingContextCustom.cpp:
1983         (WebCore::toJS):
1984         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
1985         (WebCore::toV8Object):
1986         * html/canvas/OESTextureHalfFloat.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
1987         (WebCore):
1988         (WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
1989         (WebCore::OESTextureHalfFloat::~OESTextureHalfFloat):
1990         (WebCore::OESTextureHalfFloat::getName):
1991         (WebCore::OESTextureHalfFloat::create):
1992         * html/canvas/OESTextureHalfFloat.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
1993         (WebCore):
1994         (OESTextureHalfFloat):
1995         * html/canvas/OESTextureHalfFloat.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
1996         * html/canvas/WebGLExtension.h:
1997         * html/canvas/WebGLRenderingContext.cpp:
1998         (WebCore):
1999         (WebCore::WebGLRenderingContext::getExtension):
2000         (WebCore::WebGLRenderingContext::texImage2D):
2001         (WebCore::WebGLRenderingContext::texSubImage2D):
2002         (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
2003         (WebCore::WebGLRenderingContext::validateTexFuncData):
2004         * html/canvas/WebGLRenderingContext.h:
2005         (WebCore):
2006         (WebGLRenderingContext):
2007         * html/canvas/WebGLRenderingContext.idl:
2008         * platform/graphics/Extensions3D.h:
2009         (Extensions3D):
2010         * platform/graphics/GraphicsContext3D.cpp:
2011         (WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
2012         * platform/graphics/GraphicsContext3D.h:
2013         * platform/graphics/GraphicsTypes3D.h:
2014         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
2015         (WebCore::GraphicsContext3D::texImage2D):
2016
2017 2013-03-02  Ryosuke Niwa  <rniwa@webkit.org>
2018
2019         Windows build fix attempt after r144530.
2020
2021         * platform/win/PasteboardWin.cpp:
2022
2023 2013-03-01  Dan Bernstein  <mitz@apple.com>
2024
2025         Tried to fix the build after r144530.
2026
2027         * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Include the header for the
2028         base class.
2029
2030 2013-03-01  Terry Anderson  <tdanderson@chromium.org>
2031
2032         Remove unused member variable m_useLatchedEventNode from PlatformWheelEvent.h
2033         https://bugs.webkit.org/show_bug.cgi?id=107314
2034
2035         Reviewed by Darin Adler.
2036
2037         EventHandler::handleGestureScrollCore() was removed in http://trac.webkit.org/changeset/140177,
2038         and this was the only place where the member variable |m_useLatchedEventNode| in
2039         PlatformWheelEvent was mutated. This variable is no longer needed and so it should be removed.
2040
2041         No change in behavior, so no new tests needed.
2042
2043         * platform/PlatformWheelEvent.h:
2044         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2045         (WebCore::PlatformWheelEvent::useLatchedEventNode):
2046         (PlatformWheelEvent):
2047
2048 2013-02-28  Alexey Proskuryakov  <ap@apple.com>
2049
2050         Reduce amount of rebuilding when touching networking headers
2051         https://bugs.webkit.org/show_bug.cgi?id=111035
2052
2053         Reviewed by Eric Seidel.
2054
2055         This uses a number of common unsurprising techniques. One interesting observation
2056         is that including CachedResource related headers is very expensive. We can usually
2057         get away with their Client counterparts, and with CachedResourceHandle.
2058
2059         * page/Frame.cpp:
2060         * page/Frame.h:
2061         Don't include FrameLoader, greatly reducing include graph for most non-loader files.
2062         This required making Frame::init() non-inline - I'm not sure why it ever was.
2063
2064         * loader/FrameLoader.cpp:
2065         * loader/FrameLoader.h:
2066         Even though FrameLoader is logically on loading side of WebCore, it's included in
2067         too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
2068         largest wins. As a future improvement, we should probably convert other members
2069         to OwnPtrs.
2070
2071         * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
2072         definition of a class it holds, but default construction does not.
2073
2074         * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
2075         not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
2076
2077         * loader/cache/CachedFont.h:
2078         * loader/cache/CachedFontClient.h: Added.
2079         * loader/cache/CachedRawResource.h:
2080         * loader/cache/CachedRawResourceClient.h: Added.
2081         * loader/cache/CachedSVGDocument.h:
2082         * loader/cache/CachedSVGDocumentClient.h: Added.
2083         These types were defining client types in the same headers, making it impossible
2084         to avoid including networking headers through CachedResource. Moved clients into
2085         separate files.
2086
2087         * plugins/PluginStream.h:
2088         * plugins/PluginStreamClient.h: Added.
2089         Similar situation here.
2090
2091         * loader/cache/CachedResourceHandle.cpp:
2092         * loader/cache/CachedResourceHandle.h:
2093         Moved functions that need to know about CachedResource to .cpp file. This is another
2094         huge win. Added a destructor, so that CachedResource woudn't be needed in all files
2095         that include CachedResourceHandle.
2096
2097         * loader/cache/CachedSVGDocumentReference.cpp: Added.
2098         * loader/cache/CachedSVGDocumentReference.h:
2099         Moved constructor and virtual function implementations to a .cpp file - they need
2100         not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
2101
2102         * platform/graphics/filters/FilterOperation.cpp:
2103         * platform/graphics/filters/FilterOperation.h:
2104         Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
2105         CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
2106         rendering code that it seems best to cut any ties with resources and loading.
2107         Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
2108         classes are generally harmful (due to code bloat).
2109
2110         * plugins/PluginRequest.h: Added.
2111         * plugins/PluginView.h:
2112         Moved PluginRequest into a separate file, it was out of place in a view hierarchy
2113         class file.
2114
2115         * rendering/RenderImageResource.cpp:
2116         * rendering/RenderImageResource.h:
2117         Moved definitions of virtual functions to a .cpp file. Thre is no win from having
2118         them inline, and now we don't need CachedImage.h in the header.
2119
2120         * rendering/style/StyleCustomFilterProgram.cpp: Added.
2121         * rendering/style/StyleCustomFilterProgram.h:
2122         Ditto.
2123
2124         * CMakeLists.txt:
2125         * GNUmakefile.list.am:
2126         * Modules/mediastream/RTCPeerConnection.cpp:
2127         * Modules/notifications/Notification.cpp:
2128         * Target.pri:
2129         * WebCore.exp.in:
2130         * WebCore.gypi:
2131         * WebCore.vcproj/WebCore.vcproj:
2132         * WebCore.vcxproj/WebCore.vcxproj:
2133         * WebCore.vcxproj/WebCore.vcxproj.filters:
2134         * WebCore.xcodeproj/project.pbxproj:
2135         * bindings/ScriptControllerBase.cpp:
2136         * bindings/js/JSNodeCustom.cpp:
2137         * bindings/js/ScriptController.cpp:
2138         * bindings/js/ScriptSourceCode.h:
2139         * bindings/objc/DOM.mm:
2140         * bindings/v8/ScriptController.cpp:
2141         * bindings/v8/V8DOMWindowShell.cpp:
2142         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2143         * css/CSSFontFaceSource.h:
2144         * css/CSSFontSelector.cpp:
2145         * css/WebKitCSSSVGDocumentValue.cpp:
2146         * css/WebKitCSSSVGDocumentValue.h:
2147         * dom/Clipboard.cpp:
2148         * dom/ContainerNode.cpp:
2149         * dom/DOMImplementation.cpp:
2150         * dom/PendingScript.h:
2151         * dom/ScriptElement.cpp:
2152         * dom/ScriptElement.h:
2153         * history/CachedFrame.cpp:
2154         * html/DOMURL.cpp:
2155         * html/HTMLAnchorElement.cpp:
2156         * html/HTMLAppletElement.cpp:
2157         * html/HTMLElement.cpp:
2158         * html/HTMLEmbedElement.cpp:
2159         * html/HTMLFrameSetElement.cpp:
2160         * html/HTMLHtmlElement.cpp:
2161         * html/HTMLImageElement.cpp:
2162         * html/HTMLObjectElement.cpp:
2163         * html/HTMLPlugInElement.cpp:
2164         * html/ImageDocument.cpp:
2165         * html/ImageInputType.cpp:
2166         * html/MediaDocument.cpp:
2167         * html/PluginDocument.cpp:
2168         * html/canvas/WebGLRenderingContext.cpp:
2169         * html/parser/HTMLConstructionSite.cpp:
2170         * html/parser/HTMLParserOptions.cpp:
2171         * html/parser/HTMLScriptRunner.h:
2172         * html/parser/XSSAuditor.cpp:
2173         * html/parser/XSSAuditorDelegate.cpp:
2174         * inspector/InspectorDebuggerAgent.cpp:
2175         * inspector/InspectorFileSystemAgent.cpp:
2176         * inspector/InspectorFrontendHost.cpp:
2177         * inspector/InspectorInstrumentation.h:
2178         * inspector/InspectorPageAgent.cpp:
2179         * inspector/NetworkResourcesData.cpp:
2180         * inspector/NetworkResourcesData.h:
2181         * loader/CookieJar.cpp:
2182         * loader/CrossOriginAccessControl.cpp:
2183         * loader/CrossOriginPreflightResultCache.h:
2184         * loader/DocumentThreadableLoader.h:
2185         * loader/ImageLoader.cpp:
2186         * loader/ImageLoader.h:
2187         * loader/LinkLoader.h:
2188         * loader/MainResourceLoader.cpp:
2189         * loader/MainResourceLoader.h:
2190         * loader/MixedContentChecker.cpp:
2191         * loader/PingLoader.cpp:
2192         * loader/PolicyChecker.h:
2193         * loader/ProgressTracker.cpp:
2194         * loader/SubframeLoader.cpp:
2195         * loader/SubresourceLoader.cpp:
2196         * loader/TextTrackLoader.cpp:
2197         * loader/TextTrackLoader.h:
2198         * loader/ThreadableLoader.h:
2199         * loader/appcache/ApplicationCacheGroup.cpp:
2200         * loader/appcache/ApplicationCacheGroup.h:
2201         * loader/appcache/ApplicationCacheHost.cpp:
2202         * loader/archive/cf/LegacyWebArchive.cpp:
2203         * loader/cache/CachedFont.cpp:
2204         * loader/cache/CachedImage.cpp:
2205         * loader/cache/CachedRawResource.cpp:
2206         * loader/cache/CachedResource.cpp:
2207         * loader/cache/CachedStyleSheetClient.h:
2208         * loader/cache/MemoryCache.cpp:
2209         * loader/cache/MemoryCache.h:
2210         * loader/chromium/CachedRawResourceChromium.cpp:
2211         * loader/icon/IconController.cpp:
2212         * loader/icon/IconLoader.h:
2213         * loader/mac/ResourceLoaderMac.mm:
2214         * page/DOMWindowExtension.cpp:
2215         * page/DragController.cpp:
2216         * page/PerformanceNavigation.cpp:
2217         * page/PerformanceTiming.cpp:
2218         * page/PointerLockController.cpp:
2219         * page/Settings.cpp:
2220         * page/animation/CSSPropertyAnimation.cpp:
2221         * platform/chromium/PasteboardChromium.cpp:
2222         * platform/efl/ErrorsEfl.cpp:
2223         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2224         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
2225         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
2226         * platform/gtk/ErrorsGtk.cpp:
2227         * platform/gtk/PasteboardGtk.cpp:
2228         * platform/gtk/PasteboardHelper.h:
2229         * platform/mac/ClipboardMac.h:
2230         * platform/mac/ClipboardMac.mm:
2231         * platform/mac/HTMLConverter.mm:
2232         * platform/mac/PasteboardMac.mm:
2233         * platform/network/AuthenticationChallengeBase.cpp:
2234         * platform/network/cf/CookieJarCFNet.cpp:
2235         * platform/network/cf/ResourceRequestCFNet.cpp:
2236         * platform/network/mac/CookieStorageMac.mm:
2237         * platform/qt/PasteboardQt.cpp:
2238         * plugins/DOMMimeType.cpp:
2239         * plugins/PluginView.cpp:
2240         * rendering/HitTestResult.cpp:
2241         * rendering/InlineFlowBox.cpp:
2242         * rendering/RenderBox.cpp:
2243         * rendering/RenderEmbeddedObject.cpp:
2244         * rendering/RenderImage.cpp:
2245         * rendering/RenderImageResourceStyleImage.cpp:
2246         * rendering/RenderLayer.cpp:
2247         * rendering/RenderLayerBacking.cpp:
2248         * rendering/RenderLayerFilterInfo.h:
2249         * rendering/RenderListItem.cpp:
2250         * rendering/RenderListMarker.cpp:
2251         * rendering/RenderSnapshottedPlugIn.cpp:
2252         * rendering/RenderTableCol.cpp:
2253         * rendering/RenderTableRow.cpp:
2254         * rendering/RenderTableSection.cpp:
2255         * rendering/style/StyleCachedShader.h:
2256         * svg/SVGFEImageElement.h:
2257         * svg/SVGFontFaceUriElement.h:
2258         * svg/SVGImageLoader.cpp:
2259         * svg/SVGUseElement.cpp:
2260         * svg/SVGUseElement.h:
2261         * svg/graphics/SVGImageCache.cpp:
2262         * testing/MockPagePopupDriver.cpp:
2263         * xml/XSLStyleSheet.h:
2264         * xml/XSLTProcessorLibxslt.cpp:
2265         * xml/parser/XMLDocumentParser.cpp:
2266         * xml/parser/XMLDocumentParser.h:
2267         * xml/parser/XMLDocumentParserLibxml2.cpp:
2268         Many self-evident changes - removing unnecessary header includes, adding smaller
2269         more local ones that are now necessary.
2270
2271 2013-03-01  David Hyatt  <hyatt@apple.com>
2272
2273         [New Multicolumn] Transformed objects inside fragmented transparent objects don't render
2274         https://bugs.webkit.org/show_bug.cgi?id=111221.
2275
2276         Reviewed by Simon Fraser.
2277
2278         Improve transparencyClipBox so that it understands when moving into descendants
2279         that it does in fact have to break up the transformed clip rect across the
2280         fragments.
2281         
2282         Make sure when handling fragmented transforms using multiple paints that
2283         the test that determines the extent of the transform within the fragments
2284         uses transparencyClipBox. This gives us an accurate set of columns that the
2285         final transformed result will paint across.
2286
2287         Tests: fast/multicol/mixed-opacity-fixed-test.html
2288                fast/multicol/mixed-opacity-test.html
2289                fast/multicol/transform-inside-opacity.html
2290
2291         * rendering/RenderLayer.cpp:
2292         (WebCore::transparencyClipBox):
2293         (WebCore::expandClipRectForDescendantsAndReflection):
2294         Break transformed boxes up into fragments when they are
2295         being requested by an ancestor.
2296
2297         (WebCore::RenderLayer::collectFragments):
2298         (WebCore::RenderLayer::paintTransformedLayerIntoFragments):
2299         (WebCore::RenderLayer::hitTestTransformedLayerInFragments):
2300         * rendering/RenderLayer.h:
2301         (RenderLayer):
2302         Modify collectFragments so that we pass in the correct range
2303         within the columns that can possibly cover the fragmented
2304         transformed box.
2305
2306 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
2307
2308         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
2309         https://bugs.webkit.org/show_bug.cgi?id=110943
2310
2311         Reviewed by Yury Semikhatsky.
2312
2313         Unfortunately in many cases raw pointer may point to an object that has been deleted.
2314         There is no working solution to solve this problem in general.
2315         It could be solved only on case by case basis.
2316
2317         * inspector/HeapGraphSerializer.cpp:
2318         (WebCore::HeapGraphSerializer::HeapGraphSerializer):
2319         (WebCore::HeapGraphSerializer::reportLeaf):
2320         * loader/cache/MemoryCache.cpp:
2321         (WebCore::MemoryCache::reportMemoryUsage):
2322         * platform/graphics/BitmapImage.cpp:
2323         (WebCore::FrameData::reportMemoryUsage):
2324         * platform/graphics/skia/MemoryInstrumentationSkia.cpp:
2325         (reportMemoryUsage):
2326
2327 2013-03-01  Kentaro Hara  <haraken@chromium.org>
2328
2329         Style recalculation takes too long when adding whitespace text nodes
2330         https://bugs.webkit.org/show_bug.cgi?id=110786
2331
2332         Reviewed by Darin Adler.
2333
2334         // This takes 216 msec.
2335         for (var i = 0; i < 1500; ++i) {
2336           document.body.appendChild(document.createTextNode('x'));
2337           document.body.appendChild(document.createElement('div'));
2338           document.body.appendChild(document.createTextNode('x'));
2339         }
2340
2341         // But this takes 25.3 seconds.
2342         for (var i = 0; i < 1500; ++i) {
2343           document.body.appendChild(document.createTextNode(' '));
2344           document.body.appendChild(document.createElement('div'));
2345           document.body.appendChild(document.createTextNode(' '));
2346         }
2347
2348         The reason is that we do not create renderers for empty text
2349         nodes and thus we are hitting the worst O(N^2) case in Node::attach().
2350         (See FIXME in Node::attach().)
2351
2352         This patch adds a logic to bail out the loop to avoid the O(N^2) case.
2353         Specifically, the patch bails out the loop if we encounter a text node
2354         for which we again decided not to create a renderer. This bail out is
2355         reasonable because the fact that we again decided not to create a renderer
2356         for the text node indicates that there will be no affect of the result
2357         of Text::textRendererIsNeeded() of the rest of the sibling nodes.
2358
2359         Performance test: https://bugs.webkit.org/attachment.cgi?id=190545
2360         Performance result in Chromium/Linux: 25.3 sec => 48 msec !
2361
2362         Test: perf/append-text-nodes-without-renderers.html (for performance)
2363               fast/dynamic/create-renderer-for-whitespace-only-text.html (for correctness)
2364
2365         The loop was introduced in r29054. We have to make sure that
2366         all layout tests that were updated in r29054 pass with this patch.
2367         See http://trac.webkit.org/changeset/29054.
2368
2369         * dom/Node.cpp:
2370         (WebCore::Node::attach):
2371
2372 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
2373
2374         Moved markerTextForListItem from TestRunner to Internals
2375         https://bugs.webkit.org/show_bug.cgi?id=110939
2376
2377         Reviewed by Benjamin Poulain.
2378
2379         TestRunner framework is an old way of testing webkit, it would be
2380         better to incorporate the testing frame directly into the WebCore itself
2381         as to make it more compatible with WK2.
2382
2383         * testing/Internals.cpp:
2384         (WebCore::Internals::markerTextForListItem):
2385         (WebCore):
2386         * testing/Internals.h:
2387         * testing/Internals.idl:
2388
2389 2013-03-01  Elliott Sprehn  <esprehn@gmail.com>
2390
2391         Don't leak Documents when using MutationObserver from extensions
2392         https://bugs.webkit.org/show_bug.cgi?id=111234
2393
2394         Reviewed by Adam Barth.
2395
2396         MutationObserverCallback holds a WorldContextHandle which secretly isn't
2397         a handle to anything when it's for the main world. When it's for a non-main
2398         world though, like those used in extensions, it becomes a strong reference
2399         to the v8::Context which results in leaks by creating cycles:
2400
2401         MutationObserver -> Callback -> World -> Document -> Node -> MutationObserver.
2402
2403         Instead we should keep a RefPtr to a DOMWrapperWorld in the callback and then
2404         get the v8::Context from that inside handleEvent.
2405
2406         Tests: ManualTests/leak-observer-nonmain-world.html
2407
2408         * bindings/v8/V8Binding.cpp:
2409         (WebCore::toV8Context): Added overload that takes a DOMWrapperWorld.
2410         * bindings/v8/V8Binding.h:
2411         * bindings/v8/V8MutationCallback.cpp:
2412         (WebCore::V8MutationCallback::V8MutationCallback):
2413         (WebCore::V8MutationCallback::handleEvent):
2414         * bindings/v8/V8MutationCallback.h:
2415         (V8MutationCallback):
2416
2417 2013-03-01  Bear Travis  <betravis@adobe.com>
2418
2419         [css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
2420         https://bugs.webkit.org/show_bug.cgi?id=110995
2421
2422         Reviewed by Julien Chaffraix.
2423
2424         This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
2425         which enables us to move away from the global ExclusionShapeInsideInfo map.
2426         Some additional refactoring was done to remove ExclusionShapeInsideInfo's
2427         dependency on InlineIterator, which depended on RenderBlock. This work required
2428         adding a new LineSegmentIterator struct.
2429
2430         Refactoring, no new tests.
2431
2432         * rendering/ExclusionShapeInsideInfo.cpp:
2433         (WebCore):
2434         (WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
2435         constructor to the .cpp file, as InlineIterator is now forward declared in
2436         the .h file.
2437         (WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
2438         the .cpp file, as RenderBlock is now forward declared in the .h file.
2439         * rendering/ExclusionShapeInsideInfo.h:
2440         (WebCore):
2441         (LineSegmentIterator): A simple struct for containing segment positions for
2442         layout.
2443         (WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
2444         (LineSegmentRange): Transitioning to store LineSegmentIterator.
2445         (WebCore::LineSegmentRange::LineSegmentRange): Ditto.
2446         (ExclusionShapeInsideInfo):
2447         * rendering/RenderBlock.cpp:
2448         (WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
2449         its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
2450         (WebCore):
2451         (WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
2452         the RenderBlockRareData struct rather than the global map.
2453         * rendering/RenderBlock.h:
2454         (WebCore):
2455         (WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
2456         is present if the shape-inside style is set.
2457         (WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
2458         the current block.
2459         (WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
2460         for the current block.
2461         (RenderBlockRareData): Add the ExclusionShapeInsideInfo member.
2462         * rendering/RenderBlockLineLayout.cpp:
2463         (WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
2464         layout based on the stored LineSegmentIterators.
2465
2466 2013-03-01  Terry Anderson  <tdanderson@chromium.org>
2467
2468         EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines 
2469         so its behavior matches other user-initiated scrolls
2470         https://bugs.webkit.org/show_bug.cgi?id=109769
2471
2472         Reviewed by James Robinson.
2473
2474         To ensure that the scrolling behavior of GestureScrollUpdate events are consistent with
2475         the scrolling behavior of mousewheel events, use the existing user-generated scroll logic
2476         instead of calling into RenderLayer::scrollByRecursively(). This patch fixes the bug
2477         reported in https://bugs.webkit.org/show_bug.cgi?id=109316, where the example page can
2478         be scrolled using touch but cannot be scrolled using mousewheels.
2479
2480         Note that this patch does not use any of the mousewheel event-handling code.
2481
2482         Tests: fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html
2483                fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
2484                fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html
2485                fast/events/touch/gesture/touch-gesture-noscroll-body.html
2486
2487         * page/EventHandler.cpp:
2488         (WebCore::EventHandler::clear):
2489         (WebCore::EventHandler::handleGestureEvent):
2490         (WebCore::EventHandler::handleGestureScrollBegin):
2491         (WebCore::EventHandler::handleGestureScrollUpdate):
2492         (WebCore::EventHandler::sendScrollEventToView):
2493             By calling this function at the start of handleGestureScrollUpdate() in the case
2494             where |m_scrollGestureHandlingNode| is null, we ensure that the scroll updates
2495             can still scroll the page itself, if possible.
2496         (WebCore):
2497         (WebCore::EventHandler::clearGestureScrollNodes):
2498         * page/EventHandler.h:
2499         (EventHandler):
2500         * platform/PlatformWheelEvent.h:
2501         (WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):
2502
2503 2013-03-01  Alec Flett  <alecflett@chromium.org>
2504
2505         IndexedDB: Avoid ScriptValue copies in IDBAny
2506         https://bugs.webkit.org/show_bug.cgi?id=111002
2507
2508         Reviewed by Adam Barth.
2509
2510         This avoids some v8 handle thrashing in the long term,
2511         and protects us against some crashes in the short term.
2512
2513         The crashes will be fixed in 
2514         https://bugs.webkit.org/show_bug.cgi?id=110206.
2515
2516         * Modules/indexeddb/IDBAny.cpp:
2517         (WebCore::IDBAny::createNull):
2518         (WebCore::IDBAny::createString):
2519         (WebCore::IDBAny::IDBAny):
2520         (WebCore::IDBAny::scriptValue):
2521         * Modules/indexeddb/IDBAny.h:
2522         (WebCore::IDBAny::create):
2523         (IDBAny):
2524         (WebCore::IDBAny::keyPath):
2525         * bindings/v8/custom/V8IDBAnyCustom.cpp:
2526         (WebCore::toV8):
2527         (WebCore):
2528
2529 2013-03-01  Victor Carbune  <vcarbune@chromium.org>
2530
2531         Support padding, margin and border for internal UA cue styling
2532         https://bugs.webkit.org/show_bug.cgi?id=110703
2533
2534         Reviewed by Eric Carlson.
2535
2536         For some particular user agent styling this allows the possibility
2537         of making the window around the cue text bigger to match some user
2538         styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).
2539
2540         These properties *cannot* be set through by using the ::cue
2541         pseudo-element and, as specified, are used only internally.
2542
2543         Note: This patch is identical to the previously commited one,
2544         as it was rolled back without related tests failing.
2545
2546         Test: media/track/track-cue-rendering-with-padding.html
2547
2548         * css/mediaControls.css:
2549         (video::-webkit-media-text-track-display): Set the CSS box model
2550         to include in the specified width or height the values of
2551         padding / margin / border by using -webkit-box-sizing and avoid
2552         overflow over 100% width because of having these properties set.
2553         * rendering/RenderTextTrackCue.cpp:
2554         (WebCore::RenderTextTrackCue::isOutside): To not interfere with
2555         the regular WebVTT positioning algorithm, the check is done for
2556         the absolute content box.
2557         (WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
2558         an extra adjustment step to accomodate vertical padding (and not
2559         overflow the cue container)
2560
2561 2013-03-01  Andy Estes  <aestes@apple.com>
2562
2563         REGRESSION (r125809): CFStrings created via StringImpl::createCFString()  might reference freed memory when Objective-C garbage collection is enabled
2564         https://bugs.webkit.org/show_bug.cgi?id=111219
2565
2566         Reviewed by Benjamin Poulain.
2567
2568         StringImpl::createCFString() uses CFStringCreateWithBytesNoCopy() in
2569         order to create CFString without making an unnecessary copy. In order
2570         to ensure that the the StringImpl's backing buffer isn't deallocated
2571         while the CFString is still alive, we use a custom CFAllocator to
2572         ref/deref the StringImpl at the appropriate times.
2573
2574         However, custom allocators aren't supported when Objective-C garbage
2575         collection is enabled, so in this case we use the default CF allocator.
2576         Since we can't guarantee the lifetime of the StringImpl in this case,
2577         we should just fall back to copying the string, as we did prior to r125809.
2578
2579         * platform/text/cf/StringImplCF.cpp:
2580         (garbageCollectionEnabled): Moved the check for whether garbage
2581         collection is enabled from StringWrapperCFAllocator::create() to here.
2582         (WTF::StringWrapperCFAllocator::create): Call garbageCollectionEnabled().
2583         (WTF::StringImpl::createCFString): If garbage collection is enabled,
2584         call the variants of CFStringCreate that copy the string.
2585
2586 2013-03-01  Roger Fong  <roger_fong@apple.com>
2587
2588         Unreviewed AppleWin build fix.
2589
2590         * platform/network/cf/ResourceHandleCFNet.cpp:
2591         (WebCore::ResourceHandle::createCFURLConnection):
2592
2593 2013-03-01  Martin Robinson  <mrobinson@igalia.com>
2594
2595         [GTK] Allow sharing the WebCore include list with the Chromium build
2596         https://bugs.webkit.org/show_bug.cgi?id=110241
2597
2598         Reviewed by Dirk Pranke.
2599
2600         * WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
2601         * WebCore.gypi: Added shared include directories.
2602
2603 2013-03-01  Alexey Proskuryakov  <ap@apple.com>
2604
2605         Make in-memory blobs work in NetworkProcess
2606         https://bugs.webkit.org/show_bug.cgi?id=111132
2607
2608         Reviewed by Sam Weinig.
2609
2610         * WebCore.exp.in:
2611         * WebCore.xcodeproj/project.pbxproj:
2612         Exported functions now needed by WebKit2, and made some headers Private instead
2613         of Project.
2614
2615 2013-03-01  Eric Seidel  <eric@webkit.org>
2616
2617         Threaded HTML Parser has an extra copy of every byte from the network
2618         https://bugs.webkit.org/show_bug.cgi?id=111135
2619
2620         Reviewed by Adam Barth.
2621
2622         Every LayoutTest executes this code in threaded parsing mode.
2623
2624         * dom/DecodedDataDocumentParser.cpp:
2625         (WebCore::DecodedDataDocumentParser::appendBytes):
2626          - Pass ownership of the decoded string to the parser.
2627         (WebCore::DecodedDataDocumentParser::flush):
2628          - Same.
2629         * dom/DecodedDataDocumentParser.h:
2630         (DecodedDataDocumentParser):
2631         * dom/Document.cpp:
2632         (WebCore::Document::setContent):
2633         * dom/DocumentParser.h:
2634         (DocumentParser):
2635         * dom/RawDataDocumentParser.h:
2636         (WebCore::RawDataDocumentParser::append):
2637         * html/FTPDirectoryDocument.cpp:
2638         (FTPDirectoryDocumentParser):
2639         (WebCore::FTPDirectoryDocumentParser::append):
2640         * html/parser/HTMLDocumentParser.cpp:
2641         (WebCore::HTMLDocumentParser::append):
2642         * html/parser/HTMLDocumentParser.h:
2643         (HTMLDocumentParser):
2644         * html/parser/HTMLViewSourceParser.cpp:
2645         (WebCore::HTMLViewSourceParser::append):
2646         * html/parser/HTMLViewSourceParser.h:
2647         (HTMLViewSourceParser):
2648         * html/parser/TextDocumentParser.cpp:
2649         (WebCore::TextDocumentParser::append):
2650         * html/parser/TextDocumentParser.h:
2651         (TextDocumentParser):
2652         * loader/DocumentWriter.cpp:
2653         (WebCore::DocumentWriter::replaceDocument):
2654         * xml/parser/XMLDocumentParser.cpp:
2655         (WebCore::XMLDocumentParser::append):
2656         * xml/parser/XMLDocumentParser.h:
2657         (XMLDocumentParser):
2658         * xml/parser/XMLDocumentParserLibxml2.cpp:
2659         (WebCore::XMLDocumentParser::resumeParsing):
2660
2661 2013-03-01  David Hyatt  <hyatt@apple.com>
2662
2663         [New Multicolumn] Change inRenderFlowThread to follow containing block chain
2664         https://bugs.webkit.org/show_bug.cgi?id=111206
2665
2666         Reviewed by Simon Fraser.
2667
2668         This patch removes inRenderFlowThread and changes enclosingRenderFlowThread()
2669         to flowThreadContainingBlock(). flowThreadContainingBlock() now follows
2670         the containing block chain instead of the parent chain when outside of layout.
2671         (It already did the right thing when called during layout.)
2672         
2673         By removing inRenderFlowThread (which was following the parent chain), all
2674         code that is checking for flow thread containment now correctly uses the
2675         containing block chain. This allows for content to escape in-flow flow threads
2676         and do the right thing without asserting.
2677         
2678         Test: fast/multicol/positioned-outside-of-columns.html
2679
2680         * dom/WebKitNamedFlow.cpp:
2681         (WebCore::inFlowThread):
2682         (WebCore::WebKitNamedFlow::getRegionsByContent):
2683         * rendering/RenderBlock.cpp:
2684         (WebCore::RenderBlock::removeLeftoverAnonymousBlock):
2685         (WebCore::RenderBlock::collapseAnonymousBoxChild):
2686         (WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize):
2687         (WebCore::RenderBlock::computeRegionRangeForBlock):
2688         (WebCore::RenderBlock::layoutBlock):
2689         (WebCore::RenderBlock::computeOverflow):
2690         (WebCore::RenderBlock::determineLogicalLeftPositionForChild):
2691         (WebCore::RenderBlock::computeLogicalLocationForFloat):
2692         (WebCore::RenderBlock::logicalLeftOffsetForContent):
2693         (WebCore::RenderBlock::logicalRightOffsetForContent):
2694         (WebCore::RenderBlock::hasNextPage):
2695         (WebCore::RenderBlock::applyBeforeBreak):
2696         (WebCore::RenderBlock::applyAfterBreak):
2697         (WebCore::RenderBlock::pageLogicalTopForOffset):
2698         (WebCore::RenderBlock::pageLogicalHeightForOffset):
2699         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
2700         (WebCore::RenderBlock::adjustForUnsplittableChild):
2701         (WebCore::RenderBlock::adjustLinePositionForPagination):
2702         (WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
2703         (WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
2704         (WebCore::RenderBlock::regionAtBlockOffset):
2705         (WebCore::RenderBlock::setStaticInlinePositionForChild):
2706         (WebCore::RenderBlock::logicalWidthChangedInRegions):
2707         (WebCore::RenderBlock::clampToStartAndEndRegions):
2708         * rendering/RenderBlock.h:
2709         (RenderBlock):
2710         * rendering/RenderBlockLineLayout.cpp:
2711         (WebCore::layoutExclusionShapeInsideInfo):
2712         (WebCore::LineLayoutState::LineLayoutState):
2713         (WebCore::LineLayoutState::flowThread):
2714         (WebCore::LineLayoutState::setFlowThread):
2715         (LineLayoutState):
2716         (WebCore::RenderBlock::layoutRunsAndFloatsInRange):
2717         (WebCore::RenderBlock::linkToEndLineIfNeeded):
2718         (WebCore::RenderBlock::layoutInlineChildren):
2719         (WebCore::RenderBlock::determineStartPosition):
2720         (WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
2721         * rendering/RenderBox.cpp:
2722         (WebCore::RenderBox::clearRenderBoxRegionInfo):
2723         (WebCore::RenderBox::renderBoxRegionInfo):
2724         (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
2725         (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
2726         (WebCore::RenderBox::computePositionedLogicalWidth):
2727         (WebCore::RenderBox::computePositionedLogicalHeight):
2728         * rendering/RenderDeprecatedFlexibleBox.cpp:
2729         (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
2730         * rendering/RenderFlexibleBox.cpp:
2731         (WebCore::RenderFlexibleBox::layoutBlock):
2732         * rendering/RenderFlowThread.cpp:
2733         (WebCore::RenderFlowThread::objectInFlowRegion):
2734         * rendering/RenderGrid.cpp:
2735         (WebCore::RenderGrid::layoutBlock):
2736         * rendering/RenderInline.cpp:
2737         (WebCore::RenderInline::updateAlwaysCreateLineBoxes):
2738         * rendering/RenderLayer.cpp:
2739         (WebCore::accumulateOffsetTowardsAncestor):
2740         * rendering/RenderLayerCompositor.cpp:
2741         (WebCore::RenderLayerCompositor::canBeComposited):
2742         * rendering/RenderMedia.cpp:
2743         (WebCore::RenderMedia::layout):
2744         * rendering/RenderObject.cpp:
2745         (WebCore::RenderObject::locateFlowThreadContainingBlock):
2746         (WebCore::RenderObject::containerForRepaint):
2747         (WebCore::RenderObject::willBeRemovedFromTree):
2748         (WebCore::RenderObject::removeFromRenderFlowThread):
2749         (WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
2750         * rendering/RenderObject.h:
2751         (RenderObject):
2752         (WebCore::RenderObject::flowThreadContainingBlock):
2753         * rendering/RenderRegion.cpp:
2754         (WebCore::RenderRegion::setObjectStyleInRegion):
2755         * rendering/RenderView.cpp:
2756         (WebCore::RenderView::addChild):
2757         (WebCore::RenderView::initializeLayoutState):
2758         (WebCore::RenderView::setSelection):
2759         * rendering/RenderView.h:
2760         (WebCore::RenderView::pushLayoutState):
2761         * rendering/RootInlineBox.cpp:
2762         (WebCore::RootInlineBox::containingRegion):
2763         (WebCore::RootInlineBox::setContainingRegion):
2764
2765 2013-02-28  Sam Weinig  <sam@webkit.org>
2766
2767         Add SPI for marking a WebView as doing things on behalf of another process
2768         https://bugs.webkit.org/show_bug.cgi?id=111125
2769
2770         Reviewed by Alexey Proskuryakov.
2771
2772         * platform/network/NetworkingContext.h:
2773         (NetworkingContext):
2774         * platform/network/cf/ResourceHandleCFNet.cpp:
2775         (WebCore::ResourceHandle::createCFURLConnection):
2776         * platform/network/mac/ResourceHandleMac.mm:
2777         (WebCore::ResourceHandle::createNSURLConnection):
2778         Set the sourceApplicationAuditData on the URL connection if available.
2779
2780 2013-03-01  Brent Fulgham  <bfulgham@webkit.org>
2781
2782         [Windows] Unreviewed VS2010 build fix.
2783
2784         * WebCore.vcxproj/WebCore.vcxproj: Add missing TimelineTraceEventProcessor
2785           files to the project.
2786         * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
2787
2788 2013-03-01  Bear Travis  <betravis@adobe.com>
2789
2790         [css exclusions] setting shape-inside on a parent does not relayout child blocks' inline content
2791         https://bugs.webkit.org/show_bug.cgi?id=108128
2792
2793         Reviewed by David Hyatt.
2794
2795         Ensure that blocks lay out when their parent's shape-inside changes.
2796         ExclusionShapeInsideInfo now stores an additional flag indicating whether
2797         the shape has changed and its block's children require layout. Each block
2798         can look up the flag via LayoutState to determine whether it needs to lay
2799         out its children.
2800
2801         Test: fast/exclusions/shape-inside/shape-inside-dynamic-nested.html
2802
2803         * rendering/ExclusionShapeInfo.h:
2804         (WebCore::ExclusionShapeInfo::shapeSizeDirty): Add a method to determine
2805         if the shape has changed.
2806         (ExclusionShapeInfo):
2807         * rendering/ExclusionShapeInsideInfo.h:
2808         (WebCore::ExclusionShapeInsideInfo::setNeedsLayout): Set the flag indicating
2809         layout is necessary.
2810         (WebCore::ExclusionShapeInsideInfo::needsLayout): Retrieve the layout flag.
2811         (ExclusionShapeInsideInfo):
2812         (WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Initialize
2813         the layout flag.
2814         * rendering/RenderBlock.cpp:
2815         (WebCore::exclusionInfoRequiresRelayout): Return true if the shape info should
2816         cause a relayout. Also update the needsLayout flag on the ExclusionShapeInsideInfo.
2817         (WebCore):
2818         (WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize): Return a boolean
2819         indicating whether regions or exclusions updates should cause a relayout.
2820         (WebCore::RenderBlock::layoutBlock): Relayout children if the shape inside has
2821         changed.
2822         * rendering/RenderBlock.h:
2823         (RenderBlock):
2824         * rendering/RenderBlockLineLayout.cpp:
2825         (WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Changing to be a
2826         class method.
2827         (WebCore::LineWidth::LineWidth): Changing to use class method.
2828         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
2829         (WebCore::constructBidiRunsForLine): Ditto.
2830         (WebCore::RenderBlock::layoutRunsAndFloatsInRange): Ditto.
2831         (WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.
2832
2833 2013-03-01  Uday Kiran  <udaykiran@motorola.com>
2834
2835         getComputedStyle not implemented for -webkit-column-rule shorthand
2836         https://bugs.webkit.org/show_bug.cgi?id=111203
2837
2838         Reviewed by Alexis Menard.
2839
2840         Implement getComputedStyle for -webkit-column-rule property.
2841
2842         Test: fast/css/getComputedStyle/getComputedStyle-column-rule.html
2843
2844         * css/CSSComputedStyleDeclaration.cpp:
2845         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2846
2847 2013-02-28  David Hyatt  <hyatt@apple.com>
2848
2849         REGRESSION(r144318) 1-7% perf. regression on SVG/SvgHitTesting
2850         https://bugs.webkit.org/show_bug.cgi?id=111117
2851
2852         Make sure the allocated vector has a capacity of 1, since that is
2853         far and away the most common case.
2854
2855         Reviewed by Andreas Kling.
2856
2857         * rendering/RenderFlowThread.h:
2858         (WebCore):
2859         * rendering/RenderLayer.h:
2860         (WebCore):
2861         * rendering/RenderMultiColumnSet.cpp:
2862         (WebCore::RenderMultiColumnSet::collectLayerFragments):
2863         * rendering/RenderMultiColumnSet.h:
2864         * rendering/RenderRegion.h:
2865         (WebCore):
2866         (WebCore::RenderRegion::collectLayerFragments):
2867
2868 2013-03-01  Enrica Casucci  <enrica@apple.com>
2869
2870         Crash at WebCore::SharedBuffer::hasPlatformData writing an image to the pasteboard.
2871         https://bugs.webkit.org/show_bug.cgi?id=111211.
2872         <rdar://problem/8772758>
2873
2874         Reviewed by Ryosuke Niwa.
2875
2876         This is a speculative fix since we don't have a solid repro case.
2877         Adding null check every time we build a SharedBuffer from an NSData
2878         we have obtained manipulating data from the pasteboard.
2879
2880         * platform/mac/PasteboardMac.mm:
2881         (WebCore::writeFileWrapperAsRTFDAttachment):
2882         (WebCore::Pasteboard::writeImage):
2883
2884 2013-03-01  Enrica Casucci  <enrica@apple.com>
2885
2886         Crash at WebCore::SharedBuffer::hasPlatformData during paste.
2887         https://bugs.webkit.org/show_bug.cgi?id=111207.
2888         <rdar://problem/13024528>
2889
2890         Reviewed by Ryosuke Niwa.
2891
2892         This is a speculative fix since we don't have a solid repro case.
2893         Adding null check every time we get a SharedBuffer from the pasteboard.
2894
2895         * platform/mac/PasteboardMac.mm:
2896         (WebCore::Pasteboard::plainText):
2897         (WebCore::documentFragmentWithRTF):
2898
2899 2013-03-01  Alexey Proskuryakov  <ap@apple.com>
2900
2901         Build fix for builds with BLOB disabled. This fixes it for me on Mac at least.
2902
2903         * platform/network/BlobRegistryImpl.cpp:
2904
2905 2013-03-01  peavo@outlook.com  <peavo@outlook.com>
2906
2907         [Curl] Session cookies should not be persistent.
2908         https://bugs.webkit.org/show_bug.cgi?id=111060
2909
2910         Reviewed by Brent Fulgham.
2911
2912         Curl saves both persistent cookies, and session cookies to the cookie file.
2913         The session cookies should be deleted before starting a new session.
2914
2915         * platform/network/curl/ResourceHandleManager.cpp:
2916         (WebCore::ResourceHandleManager::ResourceHandleManager): Call method to initialize cookie session.
2917         (WebCore::ResourceHandleManager::initCookieSession): Added method to initialize cookie session.
2918         * platform/network/curl/ResourceHandleManager.h: Added method to initialize cookie session.
2919
2920 2013-03-01  Vsevolod Vlasov  <vsevik@chromium.org>
2921
2922         Web Inspector: Navigator should show tree element for each folder in the source path.
2923         https://bugs.webkit.org/show_bug.cgi?id=108943
2924
2925         Reviewed by Pavel Feldman.
2926
2927         NavigatorView now renders tree element for each folder in uiSourceCode uri.
2928         Merging several folders into one tree elememnt when folder has only one folder as a child is supported.
2929         ScriptsNavigator has horizontal scroll now.
2930         Projects are shown in ScriptsNavigator by their displayName. This allows us to show several root file system folders
2931         with the same name in the navigator (e.g. 'Source/WebCore/inspector' and 'LayoutTests/inspector').
2932
2933         Test: inspector/debugger/navigator-view.html: Renamed from scripts-file-selector.html
2934
2935         * English.lproj/localizedStrings.js:
2936         * inspector/front-end/NavigatorView.js:
2937         (WebInspector.NavigatorView):
2938         (WebInspector.NavigatorView.iconClassForType):
2939         (WebInspector.NavigatorView.prototype.addUISourceCode):
2940         (WebInspector.NavigatorView.prototype._getProjectNode):
2941         (WebInspector.NavigatorView.prototype._createProjectNode):
2942         (WebInspector.NavigatorView.prototype._getOrCreateProjectNode):
2943         (WebInspector.NavigatorView.prototype._getFolderNode):
2944         (WebInspector.NavigatorView.prototype._createFolderNode):
2945         (WebInspector.NavigatorView.prototype._getOrCreateFolderNode):
2946         (WebInspector.NavigatorView.prototype._getUISourceCodeParentNode):
2947         (WebInspector.NavigatorView.prototype._getOrCreateUISourceCodeParentNode):
2948         (WebInspector.NavigatorView.prototype.revealUISourceCode):
2949         (WebInspector.NavigatorView.prototype.removeUISourceCode):
2950         (WebInspector.NavigatorView.prototype.rename):
2951         (WebInspector.NavigatorView.prototype.reset):
2952         (.typeWeight):
2953         (WebInspector.NavigatorTreeOutline._treeElementsCompare):
2954         (WebInspector.BaseNavigatorTreeElement):
2955         (WebInspector.BaseNavigatorTreeElement.prototype.type):
2956         (WebInspector.NavigatorFolderTreeElement):
2957         (WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):
2958         (WebInspector.NavigatorFolderTreeElement.prototype.onattach):
2959         (WebInspector.NavigatorSourceTreeElement):
2960         (WebInspector.NavigatorTreeNode):
2961         (WebInspector.NavigatorTreeNode.prototype.treeElement):
2962         (WebInspector.NavigatorTreeNode.prototype.dispose):
2963         (WebInspector.NavigatorTreeNode.prototype.isRoot):
2964         (WebInspector.NavigatorTreeNode.prototype.hasChildren):
2965         (WebInspector.NavigatorTreeNode.prototype.populate):
2966         (WebInspector.NavigatorTreeNode.prototype.wasPopulated):
2967         (WebInspector.NavigatorTreeNode.prototype.didAddChild):
2968         (WebInspector.NavigatorTreeNode.prototype.willRemoveChild):
2969         (WebInspector.NavigatorTreeNode.prototype.isPopulated):
2970         (WebInspector.NavigatorTreeNode.prototype.isEmpty):
2971         (WebInspector.NavigatorTreeNode.prototype.child):
2972         (WebInspector.NavigatorTreeNode.prototype.children):
2973         (WebInspector.NavigatorTreeNode.prototype.appendChild):
2974         (WebInspector.NavigatorTreeNode.prototype.removeChild):
2975         (WebInspector.NavigatorTreeNode.prototype.reset):
2976         (WebInspector.NavigatorRootTreeNode):
2977         (WebInspector.NavigatorRootTreeNode.prototype.isRoot):
2978         (WebInspector.NavigatorRootTreeNode.prototype.treeElement):
2979         (WebInspector.NavigatorRootTreeNode.prototype.wasPopulated):
2980         (WebInspector.NavigatorRootTreeNode.prototype.didAddChild):
2981         (WebInspector.NavigatorRootTreeNode.prototype.willRemoveChild):
2982         (WebInspector.NavigatorUISourceCodeTreeNode):
2983         (WebInspector.NavigatorUISourceCodeTreeNode.prototype.treeElement):
2984         (WebInspector.NavigatorUISourceCodeTreeNode.prototype.updateTitle):
2985         (WebInspector.NavigatorUISourceCodeTreeNode.prototype.hasChildren):
2986         (WebInspector.NavigatorUISourceCodeTreeNode.prototype.dispose):
2987         (WebInspector.NavigatorUISourceCodeTreeNode.prototype._titleChanged):
2988         (WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyChanged):
2989         (WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyCommitted):
2990         (WebInspector.NavigatorUISourceCodeTreeNode.prototype._formattedChanged):
2991         (WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):
2992         (WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.commitHandler):
2993         (WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.cancelHandler):
2994         (WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.afterEditing):
2995         (WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename):
2996         (WebInspector.NavigatorFolderTreeNode):
2997         (WebInspector.NavigatorFolderTreeNode.prototype.treeElement):
2998         (WebInspector.NavigatorFolderTreeNode.prototype._createTreeElement):
2999         (WebInspector.NavigatorFolderTreeNode.prototype.wasPopulated):
3000         (WebInspector.NavigatorFolderTreeNode.prototype._addChildrenRecursive):
3001         (WebInspector.NavigatorFolderTreeNode.prototype._shouldMerge):
3002         (WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
3003         (WebInspector.NavigatorFolderTreeNode.prototype.willRemoveChild):
3004         * inspector/front-end/ScriptsNavigator.js:
3005         * inspector/front-end/SimpleWorkspaceProvider.js:
3006         (WebInspector.SimpleProjectDelegate.prototype.displayName):
3007         * inspector/front-end/navigatorView.css:
3008         (.navigator > ol):
3009         (.navigator .base-navigator-tree-element-title):
3010         (.navigator-tabbed-pane .navigator-container):
3011
3012 2013-03-01  Arvid Nilsson  <anilsson@rim.com>
3013
3014         [BlackBerry] Upstream BlackBerry::Platform::Graphics::GraphicsContext integration related changes in platform/graphics/blackberry
3015         https://bugs.webkit.org/show_bug.cgi?id=111072
3016
3017         Reviewed by Rob Buis.
3018
3019         BlackBerry PR 293208
3020
3021         This patch contains contributions from many members of the BlackBerry
3022         WebKit team:
3023
3024         Rob Buis
3025         Robin Cao
3026         Michael Carmody
3027         Max Feil
3028         Eli Fidler
3029         Antonio Gomes
3030         Jacky Jiang
3031         Mike Lattanzio
3032         Yong Li
3033         Andrew Lo
3034         Maxim Mogilnitsky
3035         Joshua Netterfield
3036         Arvid Nilsson
3037         Jakob Petsovits
3038         Konrad Piascik
3039         Jeff Rogers
3040         Artem Simonov
3041         Filip Spacek
3042         George Staikos
3043         Cosmin Truta
3044
3045         Covered by existing tests.
3046
3047         * platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
3048         (WebCore::CanvasLayerWebKitThread::deleteTextures):
3049         (CanvasLayerCompositingThreadClient):
3050         (WebCore::CanvasLayerCompositingThreadClient::layerCompositingThreadDestroyed):
3051         (WebCore::CanvasLayerCompositingThreadClient::layerVisibilityChanged):
3052         (WebCore::CanvasLayerCompositingThreadClient::uploadTexturesIfNeeded):
3053         (WebCore::CanvasLayerCompositingThreadClient::clearBuffer):
3054         (WebCore):
3055         (WebCore::CanvasLayerCompositingThreadClient::CanvasLayerCompositingThreadClient):
3056         (WebCore::CanvasLayerCompositingThreadClient::drawTextures):
3057         (WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
3058         (WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
3059         (WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
3060         (WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
3061         (WebCore::CanvasLayerWebKitThread::clearBuffer):
3062         * platform/graphics/blackberry/CanvasLayerWebKitThread.h:
3063         (WebCore):
3064         (WebCore::CanvasLayerWebKitThread::create):
3065         (CanvasLayerWebKitThread):
3066         * platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
3067         (WebCore::DisplayRefreshMonitor::displayLinkFired):
3068         * platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
3069         (WebCore::DrawingBuffer::DrawingBuffer):
3070         (WebCore):
3071         (WebCore::DrawingBuffer::publishToPlatformLayer):
3072         (WebCore::DrawingBuffer::platformLayer):
3073         * platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
3074         (WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
3075         (WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
3076         (WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
3077         (WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
3078         (WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
3079         (WebCore::EGLImageLayerCompositingThreadClient::setTextureAccessor):
3080         * platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:
3081         (Graphics):
3082         (EGLImageLayerCompositingThreadClient):
3083         (WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):
3084         * platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
3085         (WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
3086         (WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
3087         (WebCore::EGLImageLayerWebKitThread::updateFrontBuffer):
3088         (WebCore::EGLImageLayerWebKitThread::deleteFrontBuffer):
3089         (WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
3090         (WebCore::EGLImageLayerWebKitThread::createTextureIfNeeded):
3091         (WebCore::EGLImageLayerWebKitThread::blitToFrontBuffer):
3092         * platform/graphics/blackberry/EGLImageLayerWebKitThread.h:
3093         (Graphics):
3094         (EGLImageLayerWebKitThread):
3095         * platform/graphics/blackberry/FloatRectBlackBerry.cpp:
3096         (WebCore::FloatRect::normalized):
3097         (WebCore):
3098         * platform/graphics/blackberry/FontCacheBlackberry.cpp: Removed.
3099         * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
3100         (WebCore::GraphicsContext3D::GraphicsContext3D):
3101         (WebCore::GraphicsContext3D::paintToCanvas):
3102         (WebCore::GraphicsContext3D::getImageData):
3103         (WebCore):
3104         * platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
3105         (WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
3106         (WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
3107         (WebCore::GraphicsLayerBlackBerry::clearBackgroundColor):
3108         (WebCore):
3109         (WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
3110         (WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
3111         (WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
3112         (WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
3113         (WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
3114         * platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
3115         (GraphicsLayerBlackBerry):
3116         (WebCore::GraphicsLayerBlackBerry::notifySyncRequired):
3117         * platform/graphics/blackberry/ImageBlackBerry.cpp:
3118         (WebCore::ImageFrame::asNewNativeImage):
3119         (WebCore):
3120         (WebCore::FrameData::clear):
3121         (WebCore::BitmapImage::BitmapImage):
3122         (WebCore::BitmapImage::checkForSolidColor):
3123         (WebCore::BitmapImage::invalidatePlatformData):
3124         (WebCore::BitmapImage::draw):
3125         (WebCore::Image::drawPattern):
3126         * platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Removed.
3127         * platform/graphics/blackberry/LayerCompositingThread.cpp:
3128         (WebCore::LayerCompositingThread::drawTextures):
3129         (WebCore::LayerCompositingThread::drawSurface):
3130         (WebCore::LayerCompositingThread::contentsTexture):
3131         (WebCore::LayerCompositingThread::commitPendingTextureUploads):
3132         (WebCore):
3133         * platform/graphics/blackberry/LayerCompositingThread.h:
3134         (Graphics):
3135         (LayerCompositingThread):
3136         * platform/graphics/blackberry/LayerCompositingThreadClient.h:
3137         (Graphics):
3138         (WebCore):
3139         (LayerCompositingThreadClient):
3140         (WebCore::LayerCompositingThreadClient::contentsTexture):
3141         (WebCore::LayerCompositingThreadClient::commitPendingTextureUploads):
3142         * platform/graphics/blackberry/LayerData.h:
3143         (WebCore::LayerData::LayerData):
3144         (WebCore::LayerData::contentsResolutionIndependent):
3145         (LayerData):
3146         (WebCore::LayerData::layerProgram):
3147         (WebCore::LayerData::isContainerForFixedPositionLayers):
3148         (WebCore::LayerData::isFixedToTop):
3149         (WebCore::LayerData::isFixedToLeft):
3150         (WebCore::LayerData::frameVisibleRect):
3151         (WebCore::LayerData::frameContentsSize):
3152         (WebCore::LayerData::contentsScale):
3153         * platform/graphics/blackberry/LayerFilterRenderer.cpp:
3154         (WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
3155         (WebCore::LayerFilterRenderer::initializeSharedGLObjects):
3156         (WebCore::LayerFilterRenderer::ping):
3157         (WebCore::LayerFilterRenderer::pong):
3158         (WebCore::LayerFilterRenderer::pushSnapshot):
3159         (WebCore::LayerFilterRenderer::popSnapshot):
3160         (WebCore::LayerFilterRenderer::applyActions):
3161         * platform/graphics/blackberry/LayerRenderer.cpp:
3162         (WebCore):
3163         (WebCore::LayerRenderer::LayerRenderer):
3164         (WebCore::LayerRenderer::~LayerRenderer):
3165         (WebCore::LayerRenderer::setViewport):
3166         (WebCore::LayerRenderer::compositeLayers):
3167         (WebCore::LayerRenderer::compositeBuffer):
3168         (WebCore::LayerRenderer::drawColor):
3169         (WebCore::LayerRenderer::useSurface):
3170         (WebCore::LayerRenderer::drawLayersOnSurfaces):
3171         (WebCore::glRound):
3172         (WebCore::LayerRenderer::toOpenGLWindowCoordinates):
3173         (WebCore::LayerRenderer::drawDebugBorder):
3174         (WebCore::LayerRenderer::drawHolePunchRect):
3175         (WebCore::LayerRenderer::updateLayersRecursive):
3176         (WebCore::LayerRenderer::compositeLayersRecursive):
3177         (WebCore::LayerRenderer::createProgram):
3178         (WebCore::LayerRenderer::useProgram):
3179         (WebCore::LayerRenderer::useLayerProgram):
3180         * platform/graphics/blackberry/LayerRenderer.h:
3181         (LayerRenderer):
3182         * platform/graphics/blackberry/LayerRendererSurface.cpp:
3183         (WebCore::LayerRendererSurface::ensureTexture):
3184         * platform/graphics/blackberry/LayerTile.cpp:
3185         (WebCore::LayerTile::LayerTile):
3186         (WebCore::LayerTile::setContents):
3187         (WebCore::LayerTile::updateContents):
3188         * platform/graphics/blackberry/LayerTile.h:
3189         (LayerTile):
3190         (WebCore::LayerTile::renderState):
3191         (WebCore::LayerTile::needsRender):
3192         (WebCore::LayerTile::setNeedsRender):
3193         (WebCore::LayerTile::setRenderPending):
3194         (WebCore::LayerTile::setRenderDone):
3195         * platform/graphics/blackberry/LayerTileIndex.h:
3196         * platform/graphics/blackberry/LayerTiler.cpp:
3197         (WebCore):
3198         (WebCore::defaultTileSize):
3199         (WebCore::LayerTiler::LayerTiler):
3200         (WebCore::LayerTiler::updateTextureContentsIfNeeded):
3201         (WebCore::LayerTiler::createBuffer):
3202         (WebCore::LayerTiler::willCommit):
3203         (WebCore::LayerTiler::commitPendingTextureUploads):
3204         (WebCore::LayerTiler::layerVisibilityChanged):
3205         (WebCore::LayerTiler::uploadTexturesIfNeeded):
3206         (WebCore::LayerTiler::processTextureJob):
3207         (WebCore::LayerTiler::addTileJob):
3208         (WebCore::LayerTiler::performTileJob):
3209         (WebCore::LayerTiler::drawTile):
3210         (WebCore::LayerTiler::drawTextures):
3211         (WebCore::LayerTiler::pruneTextures):
3212         (WebCore::LayerTiler::updateTileSize):
3213         (WebCore::LayerTiler::setNeedsBacking):
3214         (WebCore::LayerTiler::contentsTexture):
3215         * platform/graphics/blackberry/LayerTiler.h:
3216         (WebCore::LayerTiler::tileSize):
3217         (LayerTiler):
3218         (WebCore::LayerTiler::TextureJob::TextureJob):
3219         (WebCore::LayerTiler::TextureJob::setContents):
3220         (WebCore::LayerTiler::TextureJob::updateContents):
3221         (TextureJob):
3222         (WebCore::LayerTiler::needsRender):
3223         (WebCore::LayerTiler::removeUpdateContentsJobs):
3224         * platform/graphics/blackberry/LayerWebKitThread.cpp:
3225         (WebCore::LayerWebKitThread::LayerWebKitThread):
3226         (WebCore::LayerWebKitThread::~LayerWebKitThread):
3227         (WebCore::LayerWebKitThread::paintContents):
3228         (WebCore::LayerWebKitThread::commitPendingTextureUploads):
3229         (WebCore::LayerWebKitThread::setContents):
3230         (WebCore::LayerWebKitThread::setNeedsCommit):
3231         (WebCore::LayerWebKitThread::notifyAnimationsStarted):
3232         (WebCore::LayerWebKitThread::commitOnWebKitThread):
3233         (WebCore::LayerWebKitThread::startAnimations):
3234         (WebCore::LayerWebKitThread::updateTextureContents):
3235         (WebCore::LayerWebKitThread::commitOnCompositingThread):
3236         (WebCore::LayerWebKitThread::addSublayer):
3237         (WebCore):
3238         (WebCore::LayerWebKitThread::addOverlay):
3239         (WebCore::LayerWebKitThread::insert):
3240         (WebCore::LayerWebKitThread::removeFromSuperlayer):
3241         (WebCore::LayerWebKitThread::removeSublayerOrOverlay):
3242         (WebCore::LayerWebKitThread::remove):
3243         (WebCore::LayerWebKitThread::replaceSublayer):
3244         (WebCore::LayerWebKitThread::filtersCanBeComposited):
3245         (WebCore::LayerWebKitThread::removeAll):
3246         (WebCore::LayerWebKitThread::setSublayers):
3247         (WebCore::LayerWebKitThread::updateLayerHierarchy):
3248         (WebCore::LayerWebKitThread::setIsMask):
3249         (WebCore::LayerWebKitThread::releaseLayerResources):
3250         * platform/graphics/blackberry/LayerWebKitThread.h:
3251         (WebCore::LayerWebKitThread::insertSublayer):
3252         (LayerWebKitThread):
3253         (WebCore::LayerWebKitThread::isMask):
3254         (WebCore::LayerWebKitThread::removeAllSublayers):
3255         (WebCore::LayerWebKitThread::setFixedPosition):
3256         (WebCore::LayerWebKitThread::setIsContainerForFixedPositionLayers):
3257         (WebCore::LayerWebKitThread::setFixedToTop):
3258         (WebCore::LayerWebKitThread::setFixedToLeft):
3259         (WebCore::LayerWebKitThread::setFrameVisibleRect):
3260         (WebCore::LayerWebKitThread::setFrameContentsSize):
3261         (WebCore::LayerWebKitThread::setLayerProgram):
3262         * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
3263         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
3264         (WebCore::MediaPlayerPrivate::play):
3265         (WebCore::MediaPlayerPrivate::supportsFullscreen):
3266         (WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
3267         (WebCore::MediaPlayerPrivate::prepareForRendering):
3268         (WebCore):
3269         (WebCore::MediaPlayerPrivate::resizeSourceDimensions):
3270         (WebCore::MediaPlayerPrivate::percentLoaded):
3271         (WebCore::MediaPlayerPrivate::updateStates):
3272         (WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
3273         (WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
3274         (WebCore::MediaPlayerPrivate::notifyChallengeResult):
3275         (WebCore::MediaPlayerPrivate::isProcessingUserGesture):
3276         (WebCore::loadBufferingImageData):
3277         (WebCore::MediaPlayerPrivate::setBuffering):
3278         (WebCore::MediaPlayerPrivate::drawBufferingAnimation):
3279         (WebCore::MediaPlayerPrivate::onConditionallyEnterFullscreen):
3280         (WebCore::MediaPlayerPrivate::onExitFullscreen):
3281         (WebCore::MediaPlayerPrivate::onCreateHolePunchRect):
3282         (WebCore::MediaPlayerPrivate::onDestroyHolePunchRect):
3283         * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
3284         (BlackBerry):
3285         (Platform):
3286         (Graphics):
3287         (MediaPlayerPrivate):
3288         * platform/graphics/blackberry/PluginLayerWebKitThread.cpp:
3289         (WebCore::PluginLayerWebKitThread::setPluginView):
3290         * platform/graphics/blackberry/Texture.cpp:
3291         (WebCore::Texture::Texture):
3292         (WebCore::Texture::updateContents):
3293         (WebCore::Texture::setContentsToColor):
3294         (WebCore::Texture::protect):
3295         * platform/graphics/blackberry/Texture.h:
3296         (Texture):
3297         (WebCore::Texture::textureId):
3298         (WebCore::Texture::isDirty):
3299         (WebCore::Texture::hasTexture):
3300         (WebCore::Texture::sizeInBytes):
3301         (WebCore::Texture::setTextureId):
3302         (WebCore::Texture::setSize):
3303         * platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
3304         (WebCore::TextureCacheCompositingThread::allocateTextureId):
3305         (WebCore::freeTextureId):
3306         (WebCore::TextureCacheCompositingThread::collectGarbage):
3307         (WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
3308         (WebCore):
3309         (WebCore::TextureCacheCompositingThread::textureDestroyed):
3310         (WebCore::TextureCacheCompositingThread::install):
3311         (WebCore::TextureCacheCompositingThread::resizeTexture):
3312         (WebCore::TextureCacheCompositingThread::evict):
3313         (WebCore::TextureCacheCompositingThread::prune):
3314         (WebCore::TextureCacheCompositingThread::clear):
3315         (WebCore::TextureCacheCompositingThread::textureForTiledContents):
3316         (WebCore::TextureCacheCompositingThread::updateContents):
3317         * platform/graphics/blackberry/TextureCacheCompositingThread.h:
3318         (TextureCacheCompositingThread):
3319         (WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
3320         (ZombieTexture):
3321         * platform/graphics/blackberry/skia/ImageBufferDataSkia.h: Removed.
3322         * platform/graphics/blackberry/skia/PlatformSupport.cpp: Removed.
3323         * platform/graphics/blackberry/skia/PlatformSupport.h: Removed.
3324
3325 2013-03-01  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3326
3327         [Qt] Fix the Mac build with the current qtbase/dev branch
3328         https://bugs.webkit.org/show_bug.cgi?id=111190
3329
3330         Reviewed by Allan Sandfeld Jensen.
3331
3332         QMAKE_MACOSX_DEPLOYMENT_TARGET now influences
3333         __MAC_OS_X_VERSION_MIN_REQUIRED through -mmacosx-version-min after
3334         changes in qtbase to support iOS.
3335
3336         Having only WebCore defining it to 10.5 would create a mismatch of
3337         ENABLE_THREADING_LIBDISPATCH with WTF to cause undefined symbols
3338         while linking both together at the end.
3339
3340         Fix it by removing the statement which isn't needed anymore.
3341         qtbase/mkspecs/common/mac-minimum-version.conf already defines
3342         10.6 as the minimum Mac version.
3343
3344         * Target.pri:
3345
3346 2013-03-01  Vsevolod Vlasov  <vsevik@chromium.org>
3347
3348         Web Inspector: [Regression] Snippets renaming is broken.
3349         https://bugs.webkit.org/show_bug.cgi?id=111181
3350
3351         Reviewed by Alexander Pavlov.
3352
3353         * inspector/front-end/NavigatorView.js:
3354         * inspector/front-end/ScriptSnippetModel.js:
3355         * inspector/front-end/ScriptsPanel.js:
3356         (WebInspector.ScriptsPanel.prototype.set _fileRenamed):
3357         * inspector/front-end/UISourceCode.js:
3358         (WebInspector.UISourceCode.prototype.rename):
3359
3360 2013-03-01  David Hyatt  <hyatt@apple.com>
3361
3362         Fix a misspelled word in RenderObject.h. staticly -> statically.
3363
3364         Reviewed by Dean Jackson.
3365
3366         * rendering/RenderObject.h:
3367         (WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
3368         (WebCore::RenderObject::RenderObjectBitfields::isPositioned):
3369
3370 2013-03-01  David Hyatt  <hyatt@apple.com>
3371
3372         [New Multicolumn] Change flow thread containment to be a state.
3373         https://bugs.webkit.org/show_bug.cgi?id=111110
3374
3375         Change m_inRenderFlowThread from a single bit to an actual state. This
3376         will let us track whether we're inside a multicolumn (in-flow) flow thread
3377         or a named (out-of-flow) flow thread. In the former case, we're going to have
3378         to do more work to maintain this state, but for now I've kept all the logic
3379         the same just for the initial landing.
3380
3381         Reviewed by Andreas Kling.
3382
3383         * dom/NodeRenderingContext.cpp:
3384         (WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
3385         (WebCore::NodeRenderingContext::createRendererForTextIfNeeded):
3386         * rendering/RenderBlock.cpp:
3387         (WebCore::RenderBlock::clone):
3388         * rendering/RenderFlowThread.cpp:
3389         (WebCore::RenderFlowThread::RenderFlowThread):
3390         * rendering/RenderInline.cpp:
3391         (WebCore::RenderInline::clone):
3392         * rendering/RenderMultiColumnFlowThread.cpp:
3393         (WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
3394         * rendering/RenderObject.cpp:
3395         (WebCore::RenderObject::setFlowThreadStateIncludingDescendants):
3396         (WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
3397         * rendering/RenderObject.h:
3398         (WebCore::RenderObject::setParent):
3399         (RenderObject):
3400         (WebCore::RenderObject::inRenderFlowThread):
3401         (WebCore::RenderObject::flowThreadState):
3402         (WebCore::RenderObject::setFlowThreadState):
3403         (WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
3404         (RenderObjectBitfields):
3405         (WebCore::RenderObject::RenderObjectBitfields::flowThreadState):
3406         (WebCore::RenderObject::RenderObjectBitfields::setFlowThreadState):
3407         * rendering/RenderView.cpp:
3408         (WebCore::RenderView::addChild):
3409         
3410 2013-03-01  Jessie Berlin  <jberlin@apple.com>
3411
3412         Build fix.
3413
3414         Roll out r144431 because it was a build fix for r144422, which was rolled out in r144446.
3415
3416         * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
3417
3418 2013-03-01  David Kilzer  <ddkilzer@apple.com>
3419
3420         BUILD FIX (r144358): Add UNUSED_PARAM() macros to WebCore::Extensions3DOpenGL::drawBuffersEXT()
3421         <http://webkit.org/b/109331>
3422
3423         Fixes the following build failures:
3424
3425             Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:51: error: unused parameter 'n' [-Werror,-Wunused-parameter]
3426             void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)
3427                                                               ^
3428             Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:70: error: unused parameter 'bufs' [-Werror,-Wunused-parameter]
3429             void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)
3430                                                                                  ^
3431             2 errors generated.
3432
3433         * platform/graphics/opengl/Extensions3DOpenGL.cpp:
3434         (WebCore::Extensions3DOpenGL::drawBuffersEXT): Add UNUSED_PARAM()
3435         macros.
3436
3437 2013-03-01  Dan Carney  <dcarney@google.com>
3438
3439         [v8] ScriptValue has dangerous copy semantics
3440         https://bugs.webkit.org/show_bug.cgi?id=110206
3441
3442         Reviewed by Kentaro Hara.
3443
3444         Update ScriptValue to used a SharedPersistent,
3445         making it impossible to return dead references.
3446