[LFC] Add Display::Box::nonCollapsedMarginBox for verification purposes.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2018-06-28  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC] Add Display::Box::nonCollapsedMarginBox for verification purposes.
4         https://bugs.webkit.org/show_bug.cgi?id=187140
5
6         Reviewed by Antti Koivisto.
7
8         * layout/FormattingContext.cpp:
9         (WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
10         (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
11         * layout/Verification.cpp:
12         (WebCore::Layout::outputMismatchingBoxInformationIfNeeded):
13         * layout/blockformatting/BlockFormattingContext.cpp:
14         (WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):
15         * layout/displaytree/DisplayBox.cpp:
16         (WebCore::Display::Box::nonCollapsedMarginBox const):
17         * layout/displaytree/DisplayBox.h:
18         (WebCore::Display::Box::setVerticalNonCollapsedMargin):
19
20 2018-06-28  Zalan Bujtas  <zalan@apple.com>
21
22         [LFC] The margin bottom of the document element does not collapse with its last inflow child's bottom margin.
23         https://bugs.webkit.org/show_bug.cgi?id=187135
24
25         Reviewed by Antti Koivisto.
26
27         * layout/blockformatting/BlockFormattingContext.h:
28         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
29         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
30         * layout/blockformatting/BlockMarginCollapse.cpp:
31         (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBottom):
32         (WebCore::Layout::BlockFormattingContext::MarginCollapse::isMarginBottomCollapsedWithParent):
33         (WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginBottomFromLastChild):
34
35 2018-06-28  Dirk Schulze  <krit@webkit.org>
36
37         [css-masking] Update clip-path box mapping to unified box
38         https://bugs.webkit.org/show_bug.cgi?id=185797
39
40         Reviewed by Simon Fraser.
41
42         The box mapping for fill-box, stroke-box, view-box on HTML elements
43         and content-box, padding-box, margin-box, border-box for SVG elements
44         was aligned with the transform-box CSS property.
45
46         Furthermore, the keywords fill changed to fill-box and stroke changed
47         to stroke-box.
48
49         https://drafts.fxtf.org/css-masking-1/#typedef-geometry-box
50
51         Update the -webkit-clip-path property.
52
53         Tests: svg/clip-path/clip-path-shape-border-box-expected.svg
54                svg/clip-path/clip-path-shape-border-box.svg
55                svg/clip-path/clip-path-shape-content-box-expected.svg
56                svg/clip-path/clip-path-shape-content-box.svg
57                svg/clip-path/clip-path-shape-margin-box-expected.svg
58                svg/clip-path/clip-path-shape-margin-box.svg
59                svg/clip-path/clip-path-shape-padding-box-expected.svg
60                svg/clip-path/clip-path-shape-padding-box.svg
61
62         * css/CSSPrimitiveValueMappings.h:
63         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
64         (WebCore::CSSPrimitiveValue::operator CSSBoxType const):
65         * css/CSSValueKeywords.in:
66         * css/StyleBuilderConverter.h:
67         (WebCore::StyleBuilderConverter::convertClipPath):
68         * css/parser/CSSPropertyParser.cpp:
69         (WebCore::consumeBasicShapeOrBox):
70         * rendering/RenderBlock.cpp:
71         (WebCore::RenderBlock::nodeAtPoint):
72         * rendering/RenderLayer.cpp:
73         (WebCore::computeReferenceBox):
74         * rendering/shapes/BoxShape.cpp:
75         (WebCore::computeRoundedRectForBoxShape):
76         * rendering/shapes/ShapeOutsideInfo.cpp:
77         (WebCore::ShapeOutsideInfo::setReferenceBoxLogicalSize):
78         (WebCore::ShapeOutsideInfo::logicalTopOffset const):
79         (WebCore::ShapeOutsideInfo::logicalLeftOffset const):
80         * rendering/style/RenderStyleConstants.h:
81         * rendering/svg/SVGRenderingContext.cpp:
82         (WebCore::SVGRenderingContext::prepareToRenderSVGContent):
83
84 2018-06-27  Timothy Hatcher  <timothy@apple.com>
85
86         Don't expose new semantic -apple-system color keywords on iOS.
87         https://bugs.webkit.org/show_bug.cgi?id=187080
88         rdar://problem/41505699
89
90         Reviewed by Tim Horton.
91
92         * DerivedSources.make: Use gnu++14, since gnu++17 is giving errors on macOS 10.12.
93         * css/CSSValueKeywords.in: Define new semantic colors only on macOS.
94
95 2018-06-27  Zalan Bujtas  <zalan@apple.com>
96
97         [LFC] Compute both the collapsed and the non-collapsed margin values.
98         https://bugs.webkit.org/show_bug.cgi?id=187129
99
100         Reviewed by Antti Koivisto.
101
102         For validation purposes only at this point.
103
104         * layout/FormattingContext.cpp:
105         (WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
106         (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
107         * layout/FormattingContext.h:
108         * layout/FormattingContextGeometry.cpp:
109         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
110         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
111         (WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
112         (WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
113         * layout/blockformatting/BlockFormattingContext.cpp:
114         (WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):
115         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
116         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
117         * layout/blockformatting/BlockMarginCollapse.cpp:
118         (WebCore::Layout::isMarginTopCollapsedWithParent):
119         (WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
120         (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):
121
122 2018-06-27  Zalan Bujtas  <zalan@apple.com>
123
124         [LFC] Align inFlowNonReplacedHeightAndMargin() style with the rest of the compute functions.
125         https://bugs.webkit.org/show_bug.cgi?id=187126
126
127         Reviewed by Antti Koivisto.
128
129         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
130         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
131
132 2018-06-27  Yusuke Suzuki  <utatane.tea@gmail.com>
133
134         [GTK][WPE] Use LazyNeverDestroyed<XErrorTrapper> to remove static initializers
135         https://bugs.webkit.org/show_bug.cgi?id=187089
136
137         Reviewed by Michael Catanzaro.
138
139         Do not allow copying since XErrorTrapper's logic relies on the address of XErrorTrapper.
140
141         * platform/graphics/x11/XErrorTrapper.h:
142
143 2018-06-27  Zalan Bujtas  <zalan@apple.com>
144
145         [LFC] Align inFlowNonReplacedWidthAndMargin() style with the rest of the compute functions.
146         https://bugs.webkit.org/show_bug.cgi?id=187124
147
148         Reviewed by Antti Koivisto.
149
150         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
151         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
152
153 2018-06-27  Dirk Schulze  <krit@webkit.org>
154
155         -webkit-clip-path wrong offset for clipPath references
156         https://bugs.webkit.org/show_bug.cgi?id=129246
157
158         Reviewed by Simon Fraser.
159
160         Compute the correct offset for reference clip-paths by reusing
161         some of the logic from basic shapes.
162         Makes reference based clip-path interoperable and follows the
163         spec.
164
165         Test: css3/masking/clip-path-reference-2.html
166
167         * rendering/RenderLayer.cpp:
168         (WebCore::computeReferenceBox):
169         (WebCore::RenderLayer::computeClipPath const):
170         (WebCore::RenderLayer::setupClipPath):
171
172 2018-06-27  Antti Koivisto  <antti@apple.com>
173
174         Don't invoke post resolution callbacks when resolving computed style
175         https://bugs.webkit.org/show_bug.cgi?id=187113
176         <rdar://problem/41365766>
177
178         Reviewed by Geoff Garen.
179
180         Post-resolution callbacks should only be invoked when we resolve the full document style,
181         not when resolving computed style for a single element.
182
183         Tests: fast/dom/object-computed-style-event.html
184
185         * dom/Document.cpp:
186         (WebCore::Document::styleForElementIgnoringPendingStylesheets):
187         * dom/Element.cpp:
188         (WebCore::Element::resolveComputedStyle):
189
190         Also ref the ancestor stack to be safe.
191
192         * style/StyleTreeResolver.cpp:
193         (WebCore::Style::PostResolutionCallbackDisabler::PostResolutionCallbackDisabler):
194         (WebCore::Style::PostResolutionCallbackDisabler::~PostResolutionCallbackDisabler):
195
196         Add an option to not drain the callback queue on destruction. In this mode we
197         just block network loads.
198
199         * style/StyleTreeResolver.h:
200
201 2018-06-27  Timothy Hatcher  <timothy@apple.com>
202
203         Find on page selection color isn't adapted for dark mode.
204         https://bugs.webkit.org/show_bug.cgi?id=187072
205         rdar://problem/40354841
206
207         Reviewed by Tim Horton.
208
209         * page/mac/TextIndicatorWindow.mm:
210         (-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]): Use [NSColor findHighlightColor].
211         * platform/mac/LocalDefaultSystemAppearance.h:
212         (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): Added.
213         * platform/mac/LocalDefaultSystemAppearance.mm:
214         (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Set m_usingDarkAppearance.
215         * rendering/InlineTextBox.cpp:
216         (WebCore::InlineTextBox::paintPlatformDocumentMarkers): Use TextPaintPhase::Decoration since this
217         matches step three of InlineTextBox::paint ("Paint fancy decorations"). This allows TextMatch to
218         paint a forground and not end up painting during this "fancy decorations" phase.
219         (WebCore::InlineTextBox::resolveStyleForMarkedText): Set the fillColor for TextMarker to force a
220         dark text color which will draw over the yellow highlight.
221         (WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Added support for TextPaintPhase::Decoration.
222         Seperate DocumentMarker::TelephoneNumber and DocumentMarker::TextMatch. Have DocumentMarker::TextMatch
223         support Forground and Background phases.
224         * rendering/RenderTheme.cpp:
225         (WebCore::RenderTheme::platformColorsDidChange):
226         (WebCore::RenderTheme::activeTextSearchHighlightColor const): Added. Call the platfrom version.
227         (WebCore::RenderTheme::inactiveTextSearchHighlightColor const): Added. Ditto.
228         (WebCore::RenderTheme::platformActiveTextSearchHighlightColor const): Added StyleColor::Options.
229         (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor const): Ditto.
230         * rendering/RenderTheme.h:
231         * rendering/RenderThemeMac.h:
232         * rendering/RenderThemeMac.mm:
233         (WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const): Added.
234         (WebCore::RenderThemeMac::platformInactiveTextSearchHighlightColor const): Added.
235         (WebCore::RenderThemeMac::platformColorsDidChange): Clear new color caches.
236         (WebCore::RenderThemeMac::systemColor const): Cache system colors by light and dark mode.
237
238 2018-06-27  Chris Dumez  <cdumez@apple.com>
239
240         Crash under SWServer::unregisterServiceWorkerClient()
241         https://bugs.webkit.org/show_bug.cgi?id=187115
242         <rdar://problem/41539197>
243
244         Reviewed by Youenn Fablet.
245
246         Connections are usually destroyed before their SWServer. However, as per crash traces, it is possible
247         for SWServers to get destroyed while they still have connections. When this happens, the connections
248         (which are owned by the SWServer) get destroyed with other SWServer data members. In turn, the
249         connection destructor tries to unregister its clients from the server that is currently being destroyed.
250
251         To address the issue, the SWServer destructor now destroys remaining connections early, before SWServer's
252         other data members get destroyed.
253
254         * workers/service/server/SWServer.cpp:
255         (WebCore::SWServer::~SWServer):
256
257 2018-06-27  Youenn Fablet  <youenn@apple.com>
258
259         NetworkLoadChecker should not need to hard ref NetworkConnectionToWebProcess
260         https://bugs.webkit.org/show_bug.cgi?id=186551
261
262         Reviewed by Daniel Bates.
263
264         No change of behavior.
265         Add a way to set the client receiving any CSP warning/error notification.
266
267         * page/csp/ContentSecurityPolicy.h:
268         (WebCore::ContentSecurityPolicy::setClient):
269
270 2018-06-27  Zalan Bujtas  <zalan@apple.com>
271
272         [LFC] Do not collapse margin with the parent when element has border/padding.
273         https://bugs.webkit.org/show_bug.cgi?id=187114
274
275         Reviewed by Antti Koivisto.
276
277         * layout/blockformatting/BlockFormattingContext.cpp:
278         (WebCore::Layout::BlockFormattingContext::layout const):
279         * layout/blockformatting/BlockMarginCollapse.cpp:
280         (WebCore::Layout::isMarginTopCollapsedWithParent):
281         (WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
282         (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):
283
284 2018-06-27  Simon Fraser  <simon.fraser@apple.com>
285
286         Fix Windows build after r233268.
287
288         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
289         (PlatformCALayerWin::hasContents const):
290         * platform/graphics/ca/win/PlatformCALayerWin.h:
291
292 2018-06-27  Zalan Bujtas  <zalan@apple.com>
293
294         [LFC] Out-of-flow positioned element's height depends on its containing block's height.
295         https://bugs.webkit.org/show_bug.cgi?id=187082
296
297         Reviewed by Antti Koivisto.
298
299         We can't really compute the final height of an out-of-flow element until after its containing block's height is computed.
300
301         * layout/FormattingContext.cpp:
302         (WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
303         * layout/FormattingContext.h:
304         * layout/LayoutContext.cpp:
305         (WebCore::Layout::LayoutContext::updateLayout):
306         (WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):
307         * layout/LayoutContext.h:
308         * layout/blockformatting/BlockFormattingContext.cpp:
309         (WebCore::Layout::BlockFormattingContext::layout const):
310         * layout/layouttree/LayoutContainer.h:
311         (WebCore::Layout::Container::outOfFlowDescendants const):
312         (WebCore::Layout::Container::outOfFlowDescendants): Deleted.
313
314 2018-06-27  Youenn Fablet  <youenn@apple.com>
315
316         Disable content blockers in NetworkLoadChecker except for ping loads
317         https://bugs.webkit.org/show_bug.cgi?id=187083
318         <rdar://problem/41440083>
319
320         Reviewed by Chris Dumez.
321
322         Add internals API to reload a frame without content extensions.
323
324         Test: http/tests/contentextensions/reload-without-contentextensions.html
325
326         * testing/Internals.cpp:
327         (WebCore::Internals::reloadWithoutContentExtensions):
328         * testing/Internals.h:
329         * testing/Internals.idl:
330
331 2018-06-27  Simon Fraser  <simon.fraser@apple.com>
332
333         https://hackernoon.com/ uses lots of layer backing store
334         https://bugs.webkit.org/show_bug.cgi?id=186909
335         rdar://problem/40257540
336
337         Reviewed by Tim Horton.
338         
339         The existing "backing store detached" logic, which was used to eliminate backing store
340         for compositing layers outside the viewport, had a number of bugs that allowed layers
341         to have backing store when they should not.
342         
343         Specifically, any code path that ended up in setNeedsDisplay{InRect}() in PlatformCALayer
344         could trigger backing store creation on layers that should have never had any.
345         
346         Rather than monkeypatch all the GraphicsLayerCA call sites that call setNeedsDisplay{InRect}(),
347         just bail early from the PlatformCALayer* methods that trigger repaints.
348         
349         Tests didn't catch this because they just dumped the state of the backingStoreAttached flag. To fix this,
350         create backingStoreAttachedForTesting() which also tests whether the layer has contents.
351
352         Test: compositing/backing/backing-store-attachment-outside-viewport.html
353
354         * platform/graphics/GraphicsLayer.cpp:
355         (WebCore::GraphicsLayer::dumpProperties const):
356         (showGraphicsLayerTree):
357         * platform/graphics/GraphicsLayer.h:
358         (WebCore::GraphicsLayer::backingStoreAttachedForTesting const):
359         * platform/graphics/GraphicsLayerClient.h:
360         * platform/graphics/ca/GraphicsLayerCA.cpp:
361         (WebCore::GraphicsLayerCA::backingStoreAttachedForTesting const):
362         (WebCore::GraphicsLayerCA::setNeedsDisplay):
363         * platform/graphics/ca/GraphicsLayerCA.h:
364         * platform/graphics/ca/PlatformCALayer.h:
365         * platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
366         * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
367         (PlatformCALayerCocoa::setNeedsDisplay):
368         (PlatformCALayerCocoa::setNeedsDisplayInRect):
369         (PlatformCALayerCocoa::hasContents const):
370
371 2018-06-27  David Kilzer  <ddkilzer@apple.com>
372
373         Fix clang static analyzer warnings: Branch condition evaluates to a garbage value
374         <https://webkit.org/b/186968>
375
376         Reviewed by Zalan Bujtas.
377
378         This patch changes two stack-allocated `bool` variables into
379         `std::optional<bool>` since the functions that set the variable
380         may return early without setting it.  It also changes one
381         stack-allocated pointer to be initialized to `nullptr`.
382
383         * animation/AnimationTimeline.cpp:
384         (WebCore::AnimationTimeline::updateCSSTransitionsForElement):
385         Update for change to CSSPropertyAnimation::getPropertyAtIndex()
386         argument type.
387
388         * editing/ios/EditorIOS.mm:
389         (WebCore::Editor::writeImageToPasteboard): Initialize
390         `cachedImage` stack pointer to nullptr since getImage() has an
391         early return that doesn't set `cachedImage`.
392         * editing/mac/EditorMac.mm:
393         (WebCore::Editor::writeImageToPasteboard): Ditto.
394
395         * page/animation/CSSPropertyAnimation.cpp:
396         (WebCore::CSSPropertyAnimation::getPropertyAtIndex):
397         * page/animation/CSSPropertyAnimation.h:
398         (WebCore::CSSPropertyAnimation::getPropertyAtIndex):
399         - Change method to take `std::optional<bool>` instead of `bool`
400           as second argument since the method may return early without
401           setting `isShorthand`.
402
403         * page/animation/CompositeAnimation.cpp:
404         (WebCore::CompositeAnimation::updateTransitions): Update for
405         change to CSSPropertyAnimation::getPropertyAtIndex() argument
406         type.
407
408         * rendering/InlineFlowBox.cpp:
409         (WebCore::InlineFlowBox::placeBoxesInBlockDirection): Also
410         rename local `emphasisMarkIsOver` to `emphasisMarkIsAbove` to
411         match other call sites.
412         (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
413         (WebCore::InlineFlowBox::computeOverAnnotationAdjustment const):
414         (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment const):
415         - Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove()
416           argument type.
417         * rendering/InlineTextBox.cpp:
418         (WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
419         - Change method to take `std::optional<bool>` instead of `bool`
420           as second argument since the method may return early without
421           setting `above`.
422         (WebCore::InlineTextBox::paintMarkedTextForeground):
423         - Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove()
424           argument type.
425         * rendering/InlineTextBox.h:
426         (WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
427         - Change method to take `std::optional<bool>` instead of `bool`.
428
429 2018-06-27  Zalan Bujtas  <zalan@apple.com>
430
431         [LFC] Move formatting context root layout logic to a dedicated function.
432         https://bugs.webkit.org/show_bug.cgi?id=187097
433
434         Reviewed by Antti Koivisto.
435
436         * layout/blockformatting/BlockFormattingContext.cpp:
437         (WebCore::Layout::BlockFormattingContext::layout const):
438         (WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
439         * layout/blockformatting/BlockFormattingContext.h:
440
441 2018-06-27  Zalan Bujtas  <zalan@apple.com>
442
443         [LFC] Compute static position for out-of-flow elements only when required.
444         https://bugs.webkit.org/show_bug.cgi?id=187096
445
446         Reviewed by Antti Koivisto.
447
448         Computing static position for out-of-flow elements could be somewhat expensive, so let's not do it unless we actually need it.
449
450         * layout/FormattingContextGeometry.cpp:
451         (WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
452         (WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
453         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
454         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
455         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
456         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
457         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
458         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
459         (WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned): Deleted.
460
461 2018-06-27  Nan Wang  <n_wang@apple.com>
462
463         AX: [iOS] Remove the ability to set keyboard focus when VoiceOver takes focus
464         https://bugs.webkit.org/show_bug.cgi?id=187076
465
466         Reviewed by Chris Fleizach.
467
468         We shouldn't set keyboard focus when assistive technology takes focus since
469         this is causing website incompatibility issues by causing focus to be lost.
470
471         Test: accessibility/ios-simulator/accessibility-focus-do-not-set-focus.html
472
473         * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
474         (-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
475
476 2018-06-21  Emilio Cobos Álvarez  <emilio@crisal.io>
477
478         Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
479         https://bugs.webkit.org/show_bug.cgi?id=186881
480
481         Reviewed by Antti Koivisto.
482
483         Every caller does this already.
484
485         No new tests, no change in behavior.
486
487         * style/StyleTreeResolver.cpp:
488         (WebCore::Style::resetStyleForNonRenderedDescendants):
489         (WebCore::Style::TreeResolver::resolveComposedTree):
490
491 2018-06-27  Tomas Popela  <tpopela@redhat.com>
492
493         [GStreamer] Coverity scan issues
494         https://bugs.webkit.org/show_bug.cgi?id=187087
495
496         Reviewed by Xabier Rodriguez-Calvar.
497
498         Fix uninitialized members.
499
500         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
501         * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
502         * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
503
504 2018-06-27  Zan Dobersek  <zdobersek@igalia.com>
505
506         [GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
507         https://bugs.webkit.org/show_bug.cgi?id=187033
508
509         Reviewed by Michael Catanzaro.
510
511         Move the GCryptUtilities helpers that operate on libgcrypt values and
512         constants into a separate source file. This limits a bit the amount of
513         inlining the compiler might feel compelled to do, and the resulting
514         shared library is 8kB smaller in size.
515
516         * crypto/gcrypt/GCryptUtilities.cpp: Copied from Source/WebCore/crypto/gcrypt/GCryptUtilities.h.
517         (WebCore::hmacAlgorithm):
518         (WebCore::digestAlgorithm):
519         (WebCore::hashCryptoDigestAlgorithm):
520         (WebCore::mpiLength):
521         (WebCore::mpiData):
522         (WebCore::mpiZeroPrefixedData):
523         (WebCore::mpiSignedData):
524         * crypto/gcrypt/GCryptUtilities.h:
525         (WebCore::hmacAlgorithm): Deleted.
526         (WebCore::digestAlgorithm): Deleted.
527         (WebCore::hashCryptoDigestAlgorithm): Deleted.
528         (WebCore::mpiLength): Deleted.
529         (WebCore::mpiData): Deleted.
530         (WebCore::mpiZeroPrefixedData): Deleted.
531         (WebCore::mpiSignedData): Deleted.
532         * platform/SourcesGCrypt.txt:
533
534 2018-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
535
536         [JSC] Pass VM& to functions more
537         https://bugs.webkit.org/show_bug.cgi?id=186241
538
539         Reviewed by Mark Lam.
540
541         * bindings/js/JSCustomElementRegistryCustom.cpp:
542         (WebCore::JSCustomElementRegistry::define):
543
544 2018-06-26  Simon Fraser  <simon.fraser@apple.com>
545
546         CSSGradientValue's color stops vector wastes 12KB on theverge.com
547         https://bugs.webkit.org/show_bug.cgi?id=186988
548
549         Reviewed by Sam Weinig.
550
551         Shrink the color stops vector when we're done parsing the stops.
552
553         * css/CSSGradientValue.h:
554         (WebCore::CSSGradientValue::doneAddingStops):
555         * css/parser/CSSPropertyParserHelpers.cpp:
556         (WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
557         (WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
558         (WebCore::CSSPropertyParserHelpers::consumeAngularGradientColorStops):
559
560 2018-06-25  Yusuke Suzuki  <utatane.tea@gmail.com>
561
562         Remove static initializers more
563         https://bugs.webkit.org/show_bug.cgi?id=186969
564
565         Reviewed by Michael Catanzaro.
566
567         This patch removes static initializers more. They typically exists in GTK port.
568
569         No behavior change.
570
571         * Sources.txt:
572         * WebCore.xcodeproj/project.pbxproj:
573         * page/ResourceUsageData.cpp: Removed.
574         * page/ResourceUsageData.h:
575         Remove ResourceUsageData constructors since default constructors are enough.
576
577         (WebCore::MemoryCategoryInfo::MemoryCategoryInfo):
578         * platform/gtk/PasteboardHelper.cpp:
579         (WebCore::markupPrefix):
580         (WebCore::removeMarkupPrefix):
581         (WebCore::PasteboardHelper::fillSelectionData):
582         Use NeverDestroyed<> and static functions.
583
584         * platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:
585         (WebCore::defaultVolumeCapability):
586         (WebCore::GStreamerAudioCaptureSource::capabilities const):
587         CapabilityValueOrRange's constructor is not constexpr.
588
589         * platform/network/soup/SoupNetworkSession.cpp:
590         (WebCore::initialAcceptLanguages):
591         (WebCore::proxySettings):
592         (WebCore::SoupNetworkSession::SoupNetworkSession):
593         (WebCore::SoupNetworkSession::setupProxy):
594         (WebCore::SoupNetworkSession::setProxySettings):
595         (WebCore::SoupNetworkSession::setInitialAcceptLanguages):
596         Use NeverDestroyed<> and static functions.
597
598 2018-06-26  Daniel Bates  <dabates@apple.com>
599
600         REGRESSION (r231479): Unable to buy Odeon cinema tickets in STP (bogus 'X-Frame-Options' to 'SAMEORIGIN')
601         https://bugs.webkit.org/show_bug.cgi?id=186090
602         <rdar://problem/40692595>
603
604         Reviewed by Andy Estes.
605
606         Fix up Content Security Policy logic for checking the frame ancestors now that we
607         exclude the frame that initiated the load request.
608
609         Test: http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow.html
610
611         * page/csp/ContentSecurityPolicy.cpp:
612         (WebCore::ContentSecurityPolicy::allowFrameAncestors const): 
613         * page/csp/ContentSecurityPolicyDirectiveList.cpp:
614         (WebCore::checkFrameAncestors):
615
616 2018-06-26  Chris Dumez  <cdumez@apple.com>
617
618         Simplify NetworkStorageSession::getAllStorageAccessEntries()
619         https://bugs.webkit.org/show_bug.cgi?id=187016
620
621         Reviewed by Youenn Fablet.
622
623         Iterate over the HashMaps' values instead of iterating over their keys and then looking them
624         up in the HashMap.
625
626         * platform/network/cf/NetworkStorageSessionCFNet.cpp:
627         (WebCore::NetworkStorageSession::getAllStorageAccessEntries const):
628
629 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
630
631         [Mac] AirPlay picker uses incorrect theme in Dark mode
632         https://bugs.webkit.org/show_bug.cgi?id=187054
633         <rdar://problem/41291093>
634
635         Reviewed by Timothy Hatcher.
636
637         * Modules/mediasession/WebMediaSessionManager.cpp:
638         (WebCore::WebMediaSessionManager::showPlaybackTargetPicker): Add useDefaultAppearance parameter.
639         * Modules/mediasession/WebMediaSessionManager.h:
640
641         * platform/graphics/MediaPlaybackTargetPicker.cpp:
642         (WebCore::MediaPlaybackTargetPicker::showPlaybackTargetPicker): Ditto.
643         * platform/graphics/MediaPlaybackTargetPicker.h:
644
645         * platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
646         * platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
647         (WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker): Choose theme based on
648         useDefaultAppearance parameter.
649
650         * platform/mock/MediaPlaybackTargetPickerMock.cpp:
651         (WebCore::MediaPlaybackTargetPickerMock::showPlaybackTargetPicker): Log parameter.
652         * platform/mock/MediaPlaybackTargetPickerMock.h:
653
654 2018-06-26  Thibault Saunier  <tsaunier@igalia.com>
655
656         [GStreamer] Do not forget to set stream on track switching
657         https://bugs.webkit.org/show_bug.cgi?id=187049
658
659         Reviewed by Philippe Normand.
660
661         This was an overlooked issue introduced in Bug #186678
662
663         This is already tested, but we currently run only tests against playbin2
664
665         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
666         (WebCore::MediaPlayerPrivateGStreamer::enableTrack):
667
668 2018-06-26  Zalan Bujtas  <zalan@apple.com>
669
670         [LFC] Fixed positioning is a subcategory of absolute positioning.
671         https://bugs.webkit.org/show_bug.cgi?id=187043
672
673         Reviewed by Antti Koivisto.
674
675         https://www.w3.org/TR/CSS22/visuren.html#absolute-positioning
676         References in this specification to an absolutely positioned element (or its box) imply that the element's 'position'
677         property has the value 'absolute' or 'fixed'.
678
679         * layout/layouttree/LayoutBox.cpp:
680         (WebCore::Layout::Box::isAbsolutelyPositioned const):
681         * layout/layouttree/LayoutBox.h:
682         (WebCore::Layout::Box::isOutOfFlowPositioned const):
683
684 2018-06-26  Commit Queue  <commit-queue@webkit.org>
685
686         Unreviewed, rolling out r233143.
687         https://bugs.webkit.org/show_bug.cgi?id=187046
688
689         broke media/video-ended-event-negative-playback.html
690         (Requested by philn on #webkit).
691
692         Reverted changeset:
693
694         "[GStreamer] Remove useless workaround"
695         https://bugs.webkit.org/show_bug.cgi?id=186921
696         https://trac.webkit.org/changeset/233143
697
698 2018-06-25  Zalan Bujtas  <zalan@apple.com>
699
700         [LFC] Computed height for in-flow non-replaced should not include padding and border.
701         https://bugs.webkit.org/show_bug.cgi?id=187031
702
703         Reviewed by Antti Koivisto.
704
705         In certain cases the height of a non-replaced in-flow box is computed using the bottom position of its last in-flow child.
706         The in-flow child's bottom position is in the coordinate system of the containing block's border box (border box's top left is 0, 0) ->
707         it includes both the (top) border and the padding of the containing block.
708
709         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
710         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
711
712 2018-06-26  Zan Dobersek  <zdobersek@igalia.com>
713
714         Crash in WebAnimation::runPendingPlayTask
715         https://bugs.webkit.org/show_bug.cgi?id=186189
716
717         Reviewed by Carlos Garcia Campos.
718
719         Avoid crashes on nullopt std::optional dereference in the
720         runPendingPlayTask() and runPendingPauseTask() methods of the
721         WebAnimation class by defaulting to a Seconds(0) value.
722
723         In both cases the std::optional value is the current time retrieved from
724         the associated DocumentTimeline object. But there's no guarantee that
725         the timeline is active and the resulting time value is resolved (i.e.
726         not nullopt). Dereferencing the nullopt Seconds value doesn't cause a
727         problem on configurations still building as C++14 and the fallback
728         std::optional implementation provided by WTF -- no signal is raised, and
729         a 0 value is returned. Configurations building as C++17 on the other
730         hand use the stdlib-provided std::optional that does raise a signal on
731         invalid access, leading to crashes.
732
733         The default-to-Seconds(0) solution avoids crashes on configurations
734         that build with C++17 support enabled, and thus match configurations
735         that are still using WTF's std::optional. This still doesn't address the
736         underlying problem of retrieving current time from an inactive document
737         timeline and using it as ready time for the pending play/pause task
738         execution.
739
740         runPendingPlayTask() change addresses crashes in the following tests:
741         - fast/animation/css-animation-resuming-when-visible.html
742         - fast/animation/css-animation-resuming-when-visible-with-style-change.html
743         - imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html
744         - imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/getAnimations.html
745
746         runPendingPauseTask() change addresses crashes in the following tests:
747         - animations/multiple-animations-timing-function.html
748
749         * animation/WebAnimation.cpp:
750         (WebCore::WebAnimation::runPendingPlayTask):
751         (WebCore::WebAnimation::runPendingPauseTask):
752
753 2018-06-26  Antoine Quint  <graouts@apple.com>
754
755         [Web Animations] Show the feature as "Supported in Preview"
756         https://bugs.webkit.org/show_bug.cgi?id=187037
757
758         Reviewed by Dean Jackson.
759
760         Web Animations are enabled by default in STP.
761
762         * features.json:
763
764 2018-06-26  Miguel Gomez  <magomez@igalia.com>
765
766         [GTK] Many webpages can crash the browser in WebCore::CoordinatedGraphicsLayer::transformedVisibleRect
767         https://bugs.webkit.org/show_bug.cgi?id=179304
768
769         Reviewed by Michael Catanzaro.
770
771         When adding new CoordinatedGraphicsLayers to the tree, check that they have the appropriate
772         CompositingCoordinator. If that's not the case, set the appropriate one to the layer and its
773         children and set the state of those layers so they are rendered properly.
774
775         * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
776         (WebCore::CoordinatedGraphicsLayer::addChild):
777         (WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
778         (WebCore::CoordinatedGraphicsLayer::addChildAbove):
779         (WebCore::CoordinatedGraphicsLayer::addChildBelow):
780         (WebCore::CoordinatedGraphicsLayer::replaceChild):
781         (WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded):
782         * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
783
784 2018-06-25  Keith Rollin  <krollin@apple.com>
785
786         Adjust WEBCORE_EXPORT annotations for LTO
787         https://bugs.webkit.org/show_bug.cgi?id=186944
788         <rdar://problem/41384880>
789
790         Reviewed by David Kilzer.
791
792         Adjust a number of places that result in WebKit's
793         'check-for-weak-vtables-and-externals' script reporting weak external
794         symbols:
795
796             ERROR: WebCore has a weak external symbol in it (/Volumes/Data/dev/webkit/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore)
797             ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
798             ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
799             ...
800
801         These cases are caused by inline methods being marked with WTF_EXPORT
802         (or related macro) or with an inline function being in a class marked
803         as such, and when enabling LTO builds.
804
805         For the most part, address these by removing the WEBCORE_EXPORT
806         annotation from inline methods. In some cases, move the implementation
807         out-of-line because it's the class that has the WEBCORE_EXPORT on it
808         and removing the annotation from the class would be too disruptive.
809         Finally, in other cases, move the implementation out-of-line because
810         check-for-weak-vtables-and-externals still complains when keeping the
811         implementation inline and removing the annotation; this seems to
812         typically (but not always) happen with destructors.
813
814         No new tests. There is no changed functionality. Only the annotation
815         and treatment of inline methods are altered.
816
817         * animation/AnimationTimeline.h:
818         (WebCore::AnimationTimeline::pause):
819         * page/CacheStorageProvider.h:
820         (): Deleted.
821         * page/scrolling/ScrollingTree.h:
822         (WebCore::ScrollingTree::reportSynchronousScrollingReasonsChanged):
823         (WebCore::ScrollingTree::reportExposedUnfilledArea):
824         * platform/audio/PlatformMediaSessionManager.h:
825         (WebCore::PlatformMediaSessionManager::hasActiveNowPlayingSession const):
826         (WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingTitle const):
827         (WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingDuration const):
828         (WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingElapsedTime const):
829         (WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingInfoUniqueIdentifier const):
830         (WebCore::PlatformMediaSessionManager::registeredAsNowPlayingApplication const):
831         * platform/audio/mac/CARingBuffer.cpp:
832         (WebCore::CARingBuffer::~CARingBuffer):
833         * platform/audio/mac/CARingBuffer.h:
834         (WebCore::CARingBuffer::~CARingBuffer): Deleted.
835         * platform/cocoa/VideoFullscreenModelVideoElement.h:
836         * platform/gamepad/GamepadProvider.h:
837         * platform/graphics/GraphicsLayer.h:
838         (WebCore::GraphicsLayer::displayListAsText const):
839         (WebCore::GraphicsLayer::setIsTrackingDisplayListReplay):
840         (WebCore::GraphicsLayer::isTrackingDisplayListReplay const):
841         (WebCore::GraphicsLayer::replayDisplayListAsText const):
842         * platform/mac/PlaybackSessionInterfaceMac.h:
843         * platform/mediastream/RealtimeMediaSourceCenter.h:
844         (WebCore::RealtimeMediaSourceCenter::setAudioFactory):
845         (WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):
846         * platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
847         (WebCore::LibWebRTCProvider::setActive):
848         (WebCore::LibWebRTCProvider::createDecoderFactory):
849         (WebCore::LibWebRTCProvider::createEncoderFactory):
850         (WebCore::LibWebRTCProvider::disableEnumeratingAllNetworkInterfaces):
851         (WebCore::LibWebRTCProvider::enableEnumeratingAllNetworkInterfaces):
852         * platform/mediastream/libwebrtc/LibWebRTCProvider.h:
853         * platform/network/ResourceHandleClient.h:
854         (WebCore::ResourceHandleClient::willCacheResponseAsync):
855         * testing/MockGamepadProvider.h:
856         * workers/service/server/SWServer.h:
857         (WebCore::SWServer::Connection::~Connection):
858
859 2018-06-25  Zalan Bujtas  <zalan@apple.com>
860
861         [LFC] Adjust static position for out-of-flow positioned boxes.
862         https://bugs.webkit.org/show_bug.cgi?id=187000
863
864         Reviewed by Antti Koivisto.
865
866         The static position of an out-of-flow positioned box is the the position where box would go
867         if it was in-flow positioned. This position needs to the resolved in the containing block's coordinate system.
868
869         * layout/blockformatting/BlockFormattingContext.h:
870         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
871         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
872         (WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned):
873         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
874
875 2018-06-25  Brady Eidson  <beidson@apple.com>
876
877         Remove RELEASE_ASSERT added in r230875.
878         <rdar://problem/40860061> and https://bugs.webkit.org/show_bug.cgi?id=187022
879
880         Reviewed by Brent Fulgham.
881
882         There's actually more than one way for a network session to be destroyed, and that can happen
883         asynchronously and unpredictably.
884
885         And the request to start up a WebSocket and do its handshake is also asynchronous and unpredictable
886  
887         It's an expected race.
888
889         If the NetworkStorageSession cannot be found then the WebSocket handshake should just fail.
890
891         * platform/network/SocketStreamHandleImpl.cpp:
892         (WebCore::cookieDataForHandshake): If the NetworkStorageSession cannot be found, return std::nullopt.
893         (WebCore::SocketStreamHandleImpl::platformSendHandshake): If the cookieData is null, fail the handshake.
894
895 2018-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
896
897         [iPad apps on macOS] Web process crashes when attempting to play embedded YouTube video in News
898         https://bugs.webkit.org/show_bug.cgi?id=187011
899         <rdar://problem/40906808>
900
901         Reviewed by Tim Horton.
902
903         Disable remote media commands when running iOS WebKit on macOS. The iOS flavor of RemoteCommandListener
904         currently throws an exception when attempting to soft-link the MediaPlayer framework, which prevents video from
905         being played altogether. For a followup tracking touch bar integration in iOS WebKit on macOS, see:
906         <rdar://problem/39164732>.
907
908         Manually tested by playing a YouTube video in News.
909
910         * platform/RemoteCommandListener.cpp:
911         * platform/ios/RemoteCommandListenerIOS.h:
912         * platform/ios/RemoteCommandListenerIOS.mm:
913
914 2018-06-25  Keith Rollin  <krollin@apple.com>
915         Unreviewed, rolling out r233087.
916
917         Causes 5% Mac PLT regression.
918
919         Reverted changeset:
920
921         "Recalc styles every time defaultAppearance changes."
922         https://bugs.webkit.org/show_bug.cgi?id=186866
923         https://trac.webkit.org/changeset/233087
924
925 2018-06-25  Brent Fulgham  <bfulgham@apple.com>
926
927         REGRESSION(r229722): WebKitLegacy clients can crash when loading alternate page
928         https://bugs.webkit.org/show_bug.cgi?id=187008
929         
930         Reviewed by Chris Dumez.
931
932         The new call to 'clearProvisionalLoadForPolicyCheck' added in r229722 broke loading
933         behavior in WebKitLegacy.
934
935         1. We can now enter 'cancelPolicyCheckIfNeeded' without a Frame loader, in what appears
936            to be a recursive call during the load cancellation (the 'm_waitingForContentPolicy'
937            and 'm_waitingForNavigationPolicy' have already been nulled). It seems like we should
938            return early here, or perhaps just move the RELEASE_ASSERT inside the case where we
939            have an active policy check happening.
940
941         2. We also enter FrameLoader::checkContentPolicy without an active document loader. We
942            should recognize this case and handle it, rather than trying to dereference a nullptr
943            document loader.
944
945         * loader/DocumentLoader.cpp:
946         (WebCore::DocumentLoader::cancelPolicyCheckIfNeeded): Move the RELEASE_ASSERT inside the
947         conditional where the frameLoader is actually used.
948         * loader/FrameLoader.cpp:
949         (WebCore::FrameLoader::checkContentPolicy): Recognize that the activeDocumentLoader may
950         be nullptr at this point, and take appropriate action (rather than crashing).
951
952 2018-06-25  Simon Fraser  <simon.fraser@apple.com>
953
954         MatchedPropertiesCacheItem wastes 388KB of vector capacity on nytimes.com
955         https://bugs.webkit.org/show_bug.cgi?id=186990
956
957         Reviewed by Antti Koivisto.
958
959         MatchedPropertiesCacheItem.matchedProperties was appended to, so it allocated capacity
960         in 16-size chunks. Instead, assign to it so it only allocates as much capacity as is needed.
961         Copy-constructing is more wasteful, since it copies the 64-chunk size from the right-hand side.
962
963         * css/StyleResolver.cpp:
964         (WebCore::StyleResolver::addToMatchedPropertiesCache):
965         * css/StyleResolver.h:
966         (WebCore::StyleResolver::MatchedPropertiesCacheItem::MatchedPropertiesCacheItem):
967
968 2018-06-25  Chris Dumez  <cdumez@apple.com>
969
970         Null dereference crash un ApplicationCacheGroup::startLoadingEntry()
971         https://bugs.webkit.org/show_bug.cgi?id=187012
972         <rdar://problem/40793716>
973
974         Reviewed by Youenn Fablet.
975
976         m_entryLoader can be null because ApplicationCacheResourceLoader::create() return null when
977         CachedResourceLoader::requestRawResource() fails synchronously. In such case, the completion
978         handler gets called with a ApplicationCacheResourceLoader::Error::CannotRequestResource error.
979
980         To address the issue, we capture the request's URL in the lambda and use it instead of trying
981         to get the URL from the loader's resource.
982
983         * loader/appcache/ApplicationCacheGroup.cpp:
984         (WebCore::ApplicationCacheGroup::startLoadingEntry):
985
986 2018-06-25  Ross Kirsling  <ross.kirsling@sony.com>
987
988         REGRESSION (r233140): Windows build failure due to incomplete FrameView and RenderBox types
989         https://bugs.webkit.org/show_bug.cgi?id=186997
990
991         * animation/KeyframeEffectReadOnly.cpp:
992
993 2018-06-25  Antoine Quint  <graouts@apple.com>
994
995         REGRESSION: hardware-accelerated animation fails on inline element
996         https://bugs.webkit.org/show_bug.cgi?id=186981
997         <rdar://problem/41418697>
998
999         Reviewed by Dean Jackson.
1000
1001         Ensure we only queue accelerated actions when we have a renderer so we don't attempt
1002         to start an accelerated animation too soon.
1003
1004         Test: webanimations/opacity-animation-yields-compositing-span.html
1005
1006         * animation/KeyframeEffectReadOnly.cpp:
1007         (WebCore::KeyframeEffectReadOnly::updateAcceleratedAnimationState):
1008
1009 2018-06-25  David Kilzer  <ddkilzer@apple.com>
1010
1011         REGRESSION (r233140): v2: Windows build failure due to incomplete DocumentAnimationScheduler type
1012         <https://webkit.org/b/186997>
1013
1014         * dom/Document.cpp:
1015         (WebCore::Document::prepareForDestruction):
1016         (WebCore::Document::windowScreenDidChange):
1017         * dom/Document.h:
1018         - DocumentAnimationScheduler is behind the
1019           USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) macro, which
1020           is disabled on Windows.
1021         - This also reverts my fix in r233144 since it didn't work.
1022
1023 2018-06-25  Youenn Fablet  <youenn@apple.com>
1024
1025         Add API to control mock media devices
1026         https://bugs.webkit.org/show_bug.cgi?id=186958
1027
1028         Reviewed by Eric Carlson.
1029
1030         Refactor code to introduce a MockDevice structure that can be used in multiple processes.
1031         Update mock sources and center to use MockDevice.
1032         Add API to update mock media devices.
1033
1034         Make MediaDevices an ActiveDOMObject so that it does not get collected when ondevicechange is set.
1035
1036          Test: fast/mediastream/device-change-event-2.html
1037
1038         * Modules/mediastream/MediaDevices.cpp:
1039         (WebCore::MediaDevices::MediaDevices):
1040         (WebCore::MediaDevices::stop):
1041         (WebCore::MediaDevices::scheduledEventTimerFired):
1042         (WebCore::MediaDevices::hasPendingActivity const):
1043         (WebCore::MediaDevices::activeDOMObjectName const):
1044         (WebCore::MediaDevices::canSuspendForDocumentSuspension const):
1045         * Modules/mediastream/MediaDevices.h:
1046         * Modules/mediastream/MediaDevices.idl:
1047         * WebCore.xcodeproj/project.pbxproj:
1048         * platform/mediastream/RealtimeMediaSourceCenter.h:
1049         * platform/mock/MockMediaDevice.h: Added.
1050         (WebCore::MockMicrophoneProperties::encode const):
1051         (WebCore::MockMicrophoneProperties::decode):
1052         (WebCore::MockCameraProperties::encode const):
1053         (WebCore::MockCameraProperties::decode):
1054         (WebCore::MockDisplayProperties::encode const):
1055         (WebCore::MockDisplayProperties::decode):
1056         (WebCore::MockMediaDevice::isMicrophone const):
1057         (WebCore::MockMediaDevice::isCamera const):
1058         (WebCore::MockMediaDevice::isDisplay const):
1059         (WebCore::MockMediaDevice::type const):
1060         (WebCore::MockMediaDevice::encode const):
1061         (WebCore::MockMediaDevice::decodeMockMediaDevice):
1062         (WebCore::MockMediaDevice::decode):
1063         * platform/mock/MockRealtimeAudioSource.cpp:
1064         (WebCore::MockRealtimeAudioSource::startProducingData):
1065         * platform/mock/MockRealtimeMediaSource.cpp:
1066         (WebCore::defaultDevices):
1067         (WebCore::devices):
1068         (WebCore::deviceMap):
1069         (WebCore::deviceListForDevice):
1070         (WebCore::MockRealtimeMediaSource::createCaptureDevice):
1071         (WebCore::MockRealtimeMediaSource::resetDevices):
1072         (WebCore::MockRealtimeMediaSource::setDevices):
1073         (WebCore::MockRealtimeMediaSource::addDevice):
1074         (WebCore::MockRealtimeMediaSource::removeDevice):
1075         (WebCore::MockRealtimeMediaSource::captureDeviceWithPersistentID):
1076         (WebCore::MockRealtimeMediaSource::audioDevices):
1077         (WebCore::MockRealtimeMediaSource::videoDevices):
1078         (WebCore::MockRealtimeMediaSource::displayDevices):
1079         (WebCore::MockRealtimeMediaSource::MockRealtimeMediaSource):
1080         (WebCore::MockRealtimeMediaSource::initializeCapabilities):
1081         (WebCore::MockRealtimeMediaSource::initializeSettings):
1082         (WebCore::MockRealtimeMediaSource::settings const):
1083         (WebCore::MockRealtimeMediaSource::supportedConstraints):
1084         * platform/mock/MockRealtimeMediaSource.h:
1085         (WebCore::MockRealtimeMediaSource::device const):
1086         * platform/mock/MockRealtimeMediaSourceCenter.cpp:
1087         (WebCore::MockRealtimeMediaSourceCenter::singleton):
1088         (WebCore::MockRealtimeMediaSourceCenter::setMockRealtimeMediaSourceCenterEnabled):
1089         (WebCore::MockRealtimeMediaSourceCenter::setDevices):
1090         (WebCore::MockRealtimeMediaSourceCenter::addDevice):
1091         (WebCore::MockRealtimeMediaSourceCenter::removeDevice):
1092         * platform/mock/MockRealtimeMediaSourceCenter.h:
1093         * platform/mock/MockRealtimeVideoSource.cpp:
1094         (WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
1095         (WebCore::MockRealtimeVideoSource::initializeCapabilities):
1096         (WebCore::MockRealtimeVideoSource::drawText):
1097         (WebCore::MockRealtimeVideoSource::generateFrame):
1098         * platform/mock/MockRealtimeVideoSource.h:
1099         (WebCore::MockRealtimeVideoSource::mockCamera const):
1100         (WebCore::MockRealtimeVideoSource::mockScreen const):
1101
1102 2018-06-25  Simon Fraser  <simon.fraser@apple.com>
1103
1104         AutoTableLayout wastes 52KB of Vector capacity on nytimes.com
1105         https://bugs.webkit.org/show_bug.cgi?id=186710
1106
1107         Reviewed by Zalan Bujtas.
1108         
1109         Call resizeToFit() to only allocate enough capacity for the number of columns.
1110
1111         * rendering/AutoTableLayout.cpp:
1112         (WebCore::AutoTableLayout::fullRecalc):
1113         (WebCore::AutoTableLayout::insertSpanCell): Whitespace fix.
1114         * rendering/AutoTableLayout.h:
1115
1116 2018-06-25  Zalan Bujtas  <zalan@apple.com>
1117
1118         [LFC] Adjust static position with containing block's content box top/left
1119         https://bugs.webkit.org/show_bug.cgi?id=186999
1120
1121         Reviewed by Antti Koivisto.
1122
1123         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
1124         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
1125         * layout/displaytree/DisplayBox.cpp:
1126         (WebCore::Display::Box::contentBox const):
1127         * layout/displaytree/DisplayBox.h:
1128         (WebCore::Display::Box::contentBoxTop const):
1129         (WebCore::Display::Box::contentBoxLeft const):
1130
1131 2018-06-25  David Kilzer  <ddkilzer@apple.com>
1132
1133         REGRESSION (r233140): Windows build failure due to incomplete DocumentAnimationScheduler type
1134         <https://webkit.org/b/186997>
1135
1136         * dom/Document.cpp:
1137         * dom/Document.h:
1138         - Attempt to fix Windows build failure by moving include of
1139           DocumentAnimationScheduler.h from Document.cpp to Document.h.
1140
1141 2018-06-25  Philippe Normand  <pnormand@igalia.com>
1142
1143         [GStreamer] Remove useless workaround
1144         https://bugs.webkit.org/show_bug.cgi?id=186921
1145
1146         Reviewed by Xabier Rodriguez-Calvar.
1147
1148         In bug 67407 a workaround was added for GStreamer 0.10. With 1.x
1149         the media/video-reverse-play-duration.html test passes without any
1150         workaround needed. The other test mentioned in that bug was
1151         removed, it seems.
1152
1153         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1154         (WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):
1155
1156 2018-06-24  Tomas Popela  <tpopela@redhat.com>
1157
1158         Unreviewed, address Darin's comment
1159         https://bugs.webkit.org/show_bug.cgi?id=186757
1160
1161         * page/linux/ResourceUsageThreadLinux.cpp:
1162         (WebCore::cpuPeriod):
1163
1164 2018-06-25  Antoine Quint  <graouts@apple.com>
1165
1166         [Web Animations] Make imported/mozilla/css-animations/test_animation-pausing.html pass reliably
1167         https://bugs.webkit.org/show_bug.cgi?id=183826
1168         <rdar://problem/40997412>
1169
1170         Reviewed by Dean Jackson.
1171
1172         The CSS Animations Level 2 specification defines that calling pause() on a CSSAnimation object is "sticky"
1173         until a call to play() is made, meaning that any changes to the running state via the CSS animation-play-state
1174         property is overridden by the stickiness of the pause() call. In this patch we add an m_stickyPaused flag which
1175         is set in API calls to pause() and play(). While this flag is true, changes to the animation-play-state property
1176         to the "running" value are ignored.
1177
1178         * animation/CSSAnimation.cpp:
1179         (WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
1180         (WebCore::CSSAnimation::bindingsPlay):
1181         (WebCore::CSSAnimation::bindingsPause):
1182         * animation/CSSAnimation.h:
1183
1184 2018-06-25  Antoine Quint  <graouts@apple.com>
1185
1186         [Web Animations] Ensure animations are updated prior to requestAnimationFrame callbacks
1187         https://bugs.webkit.org/show_bug.cgi?id=186997
1188         <rdar://problem/41419414>
1189
1190         Reviewed by Dean Jackson.
1191
1192         Some sub-tests of imported/mozilla/css-animations/test_animation-pausing.html clearly expect that animations
1193         would be resolved prior to firing a requestAnimationFrame() callback, as the HTML5 event loop mandates. But until
1194         now, both DocumentTimeline and ScriptedAnimationController would make calls to DisplayRefreshMonitorManager::scheduleAnimation()
1195         that were not coordinated and so the order in which the DocumentTimeline and ScriptedAnimationController callbacks
1196         were performed was not guaranteed.
1197
1198         In this patch we add a new DocumentAnimationScheduler class which is created by a Document to manage this specific
1199         situation. Now DocumentTimeline and ScriptedAnimationController use this supporting object instead of being their
1200         own DisplayRefreshMonitorClient and call scheduleWebAnimationsResolution() and scheduleScriptedAnimationResolution()
1201         respectively to indicate the need to schedule an animation through the DisplayRefreshMonitorManager to serve the specific
1202         needs of either, or both, classes. Then DocumentAnimationScheduler ensures that Web Animations resolution happens
1203         prior to requestAnimationFrame callbacks when both are scheduled.
1204
1205         In the future we should be able to move more code from DocumentTimeline and ScriptedAnimationController over to
1206         DocumentAnimationScheduler, such as support for throttling and using a timer-based fallback, but this patch provides
1207         the minimal functionality required to provide a sounder foundation.
1208
1209         * Modules/webvr/VRDisplay.cpp:
1210         (WebCore::VRDisplay::requestAnimationFrame):
1211         * Sources.txt:
1212         * WebCore.xcodeproj/project.pbxproj:
1213         * animation/DocumentAnimationScheduler.cpp: Added.
1214         (WebCore::DocumentAnimationScheduler::create):
1215         (WebCore::DocumentAnimationScheduler::DocumentAnimationScheduler):
1216         (WebCore::DocumentAnimationScheduler::detachFromDocument):
1217         (WebCore::DocumentAnimationScheduler::scheduleWebAnimationsResolution):
1218         (WebCore::DocumentAnimationScheduler::scheduleScriptedAnimationResolution):
1219         (WebCore::DocumentAnimationScheduler::displayRefreshFired):
1220         (WebCore::DocumentAnimationScheduler::windowScreenDidChange):
1221         (WebCore::DocumentAnimationScheduler::createDisplayRefreshMonitor const):
1222         * animation/DocumentAnimationScheduler.h: Copied from Source/WebCore/animation/CSSAnimation.h.
1223         * animation/DocumentTimeline.cpp:
1224         (WebCore::DocumentTimeline::create):
1225         (WebCore::DocumentTimeline::DocumentTimeline):
1226         (WebCore::DocumentTimeline::scheduleAnimationResolution):
1227         (WebCore::DocumentTimeline::windowScreenDidChange): Deleted.
1228         (WebCore::DocumentTimeline::createDisplayRefreshMonitor const): Deleted.
1229         * animation/DocumentTimeline.h:
1230         * dom/Document.cpp:
1231         (WebCore::Document::prepareForDestruction):
1232         (WebCore::Document::windowScreenDidChange):
1233         (WebCore::Document::requestAnimationFrame):
1234         (WebCore::Document::animationScheduler):
1235         (WebCore::Document::timeline):
1236         * dom/Document.h:
1237         * dom/ScriptedAnimationController.cpp:
1238         (WebCore::ScriptedAnimationController::ScriptedAnimationController):
1239         (WebCore::ScriptedAnimationController::scheduleAnimation):
1240         (WebCore::ScriptedAnimationController::documentAnimationSchedulerDidFire):
1241         (WebCore::ScriptedAnimationController::windowScreenDidChange): Deleted.
1242         (WebCore::ScriptedAnimationController::displayRefreshFired): Deleted.
1243         (WebCore::ScriptedAnimationController::createDisplayRefreshMonitor const): Deleted.
1244         * dom/ScriptedAnimationController.h:
1245         (WebCore::ScriptedAnimationController::create):
1246
1247 2018-06-25  Zan Dobersek  <zdobersek@igalia.com>
1248
1249         [GCrypt] Zero-prefix (if necessary) output of RSA-based encryption and signing operations
1250         https://bugs.webkit.org/show_bug.cgi?id=186967
1251
1252         Reviewed by Michael Catanzaro.
1253
1254         Output for RSA-based encryption and signing operations should match the
1255         length of the RSA key. The way we retrieve the MPI data means libgcrypt
1256         can ignore the high-bit zero values and leave us with a valid result
1257         that's shorter in length compared to the RSA key. For instance, if the
1258         output MPI fits into 2040 bits while a 2048-bit key was used we'll end
1259         up with MPI data that will be fitted into a 255-byte Vector, one byte
1260         short of the expected output length.
1261
1262         To avoid this, mpiZeroPrefixedData() is now used when retrieving output
1263         of these RSA operations, and the value of the key size in bytes is
1264         passed to it. This efficiently prepares the output Vector and then
1265         copies the MPI data into it, respecting the MPI data length as well as
1266         the desired length of the output.
1267
1268         No new tests -- relevant tests are now stable (i.e. not sporadically
1269         failing anymore), associated expectations are removed.
1270
1271         * crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:
1272         (WebCore::gcryptDerive): Also use mpiZeroPrefixedData().
1273         * crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
1274         (WebCore::gcryptEncrypt):
1275         (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
1276         * crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
1277         (WebCore::gcryptSign):
1278         (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
1279         * crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
1280         (WebCore::gcryptEncrypt):
1281         (WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
1282         * crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:
1283         (WebCore::gcryptSign):
1284         (WebCore::CryptoAlgorithmRSA_PSS::platformSign):
1285         * crypto/gcrypt/GCryptUtilities.h:
1286         (WebCore::mpiZeroPrefixedData):
1287
1288 2018-06-24  Simon Fraser  <simon.fraser@apple.com>
1289
1290         Fix the DUMP_NODE_STATISTICS code so that it compiles
1291         https://bugs.webkit.org/show_bug.cgi?id=186982
1292
1293         Reviewed by Anders Carlsson.
1294
1295         The DUMP_NODE_STATISTICS code had bitrotted. ENTITY_NODE no longer exists.
1296         liveNodeSet needs to be a static function with a NeverDestroyed<>.
1297
1298         * dom/Node.cpp:
1299         (WebCore::Node::dumpStatistics):
1300         (WebCore::Node::trackForDebugging):
1301         (WebCore::Node::~Node):
1302
1303 2018-06-24  Simon Fraser  <simon.fraser@apple.com>
1304
1305         Fix the composition underline to be transformed by -apple-color-filter
1306         https://bugs.webkit.org/show_bug.cgi?id=186983
1307         rdar://problem/40515558
1308
1309         Reviewed by Zalan Bujtas.
1310         
1311         Transform the composition underline color with the color filter.
1312
1313         Test: css3/color-filters/color-filter-composition-underline-color.html
1314
1315         * rendering/InlineTextBox.cpp:
1316         (WebCore::InlineTextBox::paintCompositionUnderline const):
1317
1318 2018-06-23  Zalan Bujtas  <zalan@apple.com>
1319
1320         [Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units
1321         https://bugs.webkit.org/show_bug.cgi?id=186585
1322         <rdar://problem/30685325>
1323
1324         Reviewed by Tim Horton.
1325
1326         Use the existing "override viewport size for viewport units" mechanism to compute the preferred
1327         viewport unit values for the Mail Viewer html content. 
1328
1329         Test: fast/dynamic/mail-autosize-viewport-unit.html
1330
1331         * page/FrameView.cpp:
1332         (WebCore::FrameView::FrameView):
1333         (WebCore::FrameView::enableAutoSizeMode):
1334         (WebCore::FrameView::clearViewportSizeOverrideForCSSViewportUnits):
1335         (WebCore::FrameView::setViewportSizeForCSSViewportUnits):
1336         (WebCore::FrameView::overrideViewportSizeForCSSViewportUnits):
1337         (WebCore::FrameView::viewportSizeForCSSViewportUnits const):
1338         * page/FrameView.h:
1339
1340 2018-06-23  Zalan Bujtas  <zalan@apple.com>
1341
1342         [LFC] Relatively positioned renderer needs offsetting for validation
1343         https://bugs.webkit.org/show_bug.cgi?id=186959
1344
1345         Reviewed by Antti Koivisto.
1346
1347         * layout/FormattingContextGeometry.cpp:
1348         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
1349         * layout/Verification.cpp:
1350         (WebCore::Layout::outputMismatchingBoxInformationIfNeeded):
1351
1352 2018-06-23  Zalan Bujtas  <zalan@apple.com>
1353
1354         [LFC] Miscellaneous fixes to fix simple absolute positioning.
1355         https://bugs.webkit.org/show_bug.cgi?id=186962
1356
1357         Reviewed by Antti Koivisto.
1358
1359         1. Collect out-of-flow formatting root descendants.
1360         2. Remove invalid and redundant ASSERTs
1361           invalid because the assertion is missing border, padding etc.
1362           redundant becasue we assert on geometry correctness in validateGeometryConstraintsAfterLayout.  
1363
1364         * layout/FormattingContext.cpp:
1365         (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
1366         (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
1367         (WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
1368         * layout/layouttree/LayoutContainer.cpp:
1369         (WebCore::Layout::Container::addOutOfFlowDescendant):
1370         (WebCore::Layout::Container::setOutOfFlowDescendants): Deleted.
1371         * layout/layouttree/LayoutContainer.h:
1372         * layout/layouttree/LayoutTreeBuilder.cpp:
1373         (WebCore::Layout::TreeBuilder::createSubTree):
1374
1375 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1376
1377         [WTF] Add user-defined literal for ASCIILiteral
1378         https://bugs.webkit.org/show_bug.cgi?id=186839
1379
1380         Reviewed by Darin Adler.
1381
1382         No behavior change.
1383
1384         * Modules/applicationmanifest/ApplicationManifestParser.cpp:
1385         (WebCore::ApplicationManifestParser::parseManifest):
1386         (WebCore::ApplicationManifestParser::logManifestPropertyNotAString):
1387         (WebCore::ApplicationManifestParser::logManifestPropertyInvalidURL):
1388         (WebCore::ApplicationManifestParser::logDeveloperWarning):
1389         (WebCore::ApplicationManifestParser::parseStartURL):
1390         (WebCore::ApplicationManifestParser::parseDisplay):
1391         (WebCore::ApplicationManifestParser::parseName):
1392         (WebCore::ApplicationManifestParser::parseDescription):
1393         (WebCore::ApplicationManifestParser::parseShortName):
1394         (WebCore::ApplicationManifestParser::parseScope):
1395         * Modules/beacon/NavigatorBeacon.cpp:
1396         (WebCore::NavigatorBeacon::logError):
1397         (WebCore::NavigatorBeacon::sendBeacon):
1398         * Modules/cache/DOMCache.cpp:
1399         (WebCore::DOMCache::requestFromInfo):
1400         (WebCore::DOMCache::addAll):
1401         (WebCore::DOMCache::put):
1402         * Modules/cache/DOMCacheEngine.cpp:
1403         (WebCore::DOMCacheEngine::errorToException):
1404         * Modules/credentialmanagement/BasicCredential.cpp:
1405         (WebCore::BasicCredential::type const):
1406         * Modules/credentialmanagement/CredentialsContainer.cpp:
1407         (WebCore::CredentialsContainer::get):
1408         (WebCore::CredentialsContainer::store):
1409         (WebCore::CredentialsContainer::isCreate):
1410         (WebCore::CredentialsContainer::preventSilentAccess const):
1411         * Modules/entriesapi/DOMFileSystem.cpp:
1412         (WebCore::DOMFileSystem::root):
1413         (WebCore::validatePathIsExpectedType):
1414         (WebCore::resolveRelativeVirtualPath):
1415         (WebCore::DOMFileSystem::getEntry):
1416         * Modules/entriesapi/FileSystemDirectoryEntry.cpp:
1417         (WebCore::FileSystemDirectoryEntry::getEntry):
1418         * Modules/entriesapi/FileSystemDirectoryReader.cpp:
1419         (WebCore::FileSystemDirectoryReader::readEntries):
1420         * Modules/fetch/FetchBody.cpp:
1421         (WebCore::FetchBody::consumeAsStream):
1422         * Modules/fetch/FetchBodyConsumer.cpp:
1423         (WebCore::FetchBodyConsumer::loadingFailed):
1424         * Modules/fetch/FetchBodyOwner.cpp:
1425         (WebCore::FetchBodyOwner::arrayBuffer):
1426         (WebCore::FetchBodyOwner::blob):
1427         (WebCore::FetchBodyOwner::consumeOnceLoadingFinished):
1428         (WebCore::FetchBodyOwner::formData):
1429         (WebCore::FetchBodyOwner::json):
1430         (WebCore::FetchBodyOwner::text):
1431         (WebCore::FetchBodyOwner::blobLoadingFailed):
1432         (WebCore::FetchBodyOwner::consumeBodyAsStream):
1433         * Modules/fetch/FetchHeaders.cpp:
1434         (WebCore::canWriteHeader):
1435         * Modules/fetch/FetchLoader.cpp:
1436         (WebCore::FetchLoader::startLoadingBlobURL):
1437         (WebCore::FetchLoader::start):
1438         * Modules/fetch/FetchRequest.cpp:
1439         (WebCore::setMethod):
1440         (WebCore::computeReferrer):
1441         (WebCore::buildOptions):
1442         (WebCore::FetchRequest::initializeOptions):
1443         (WebCore::FetchRequest::initializeWith):
1444         (WebCore::FetchRequest::setBody):
1445         (WebCore::FetchRequest::referrer const):
1446         (WebCore::FetchRequest::clone):
1447         * Modules/fetch/FetchResponse.cpp:
1448         (WebCore::FetchResponse::create):
1449         (WebCore::FetchResponse::redirect):
1450         (WebCore::FetchResponse::clone):
1451         (WebCore::FetchResponse::BodyLoader::didFail):
1452         * Modules/fetch/FetchResponse.h:
1453         * Modules/geolocation/GeoNotifier.cpp:
1454         (WebCore::GeoNotifier::timerFired):
1455         * Modules/geolocation/Geolocation.cpp:
1456         (WebCore::Geolocation::startRequest):
1457         (WebCore::Geolocation::requestUsesCachedPosition):
1458         (WebCore::Geolocation::makeCachedPositionCallbacks):
1459         (WebCore::Geolocation::setIsAllowed):
1460         (WebCore::Geolocation::cancelRequests):
1461         (WebCore::Geolocation::handlePendingPermissionNotifiers):
1462         * Modules/indexeddb/IDBCursor.cpp:
1463         (WebCore::IDBCursor::update):
1464         (WebCore::IDBCursor::advance):
1465         (WebCore::IDBCursor::continuePrimaryKey):
1466         (WebCore::IDBCursor::continueFunction):
1467         (WebCore::IDBCursor::deleteFunction):
1468         * Modules/indexeddb/IDBDatabase.cpp:
1469         (WebCore::IDBDatabase::createObjectStore):
1470         (WebCore::IDBDatabase::transaction):
1471         (WebCore::IDBDatabase::deleteObjectStore):
1472         * Modules/indexeddb/IDBFactory.cpp:
1473         (WebCore::IDBFactory::open):
1474         (WebCore::IDBFactory::openInternal):
1475         (WebCore::IDBFactory::deleteDatabase):
1476         (WebCore::IDBFactory::cmp):
1477         * Modules/indexeddb/IDBIndex.cpp:
1478         (WebCore::IDBIndex::setName):
1479         (WebCore::IDBIndex::openCursor):
1480         (WebCore::IDBIndex::openKeyCursor):
1481         (WebCore::IDBIndex::count):
1482         (WebCore::IDBIndex::doCount):
1483         (WebCore::IDBIndex::get):
1484         (WebCore::IDBIndex::doGet):
1485         (WebCore::IDBIndex::getKey):
1486         (WebCore::IDBIndex::doGetKey):
1487         (WebCore::IDBIndex::getAll):
1488         (WebCore::IDBIndex::getAllKeys):
1489         * Modules/indexeddb/IDBKeyData.cpp:
1490         (WebCore::IDBKeyData::loggingString const):
1491         * Modules/indexeddb/IDBKeyRangeData.cpp:
1492         (WebCore::IDBKeyRangeData::loggingString const):
1493         * Modules/indexeddb/IDBObjectStore.cpp:
1494         (WebCore::IDBObjectStore::setName):
1495         (WebCore::IDBObjectStore::openCursor):
1496         (WebCore::IDBObjectStore::openKeyCursor):
1497         (WebCore::IDBObjectStore::get):
1498         (WebCore::IDBObjectStore::getKey):
1499         (WebCore::IDBObjectStore::putOrAdd):
1500         (WebCore::IDBObjectStore::doDelete):
1501         (WebCore::IDBObjectStore::deleteFunction):
1502         (WebCore::IDBObjectStore::clear):
1503         (WebCore::IDBObjectStore::createIndex):
1504         (WebCore::IDBObjectStore::index):
1505         (WebCore::IDBObjectStore::deleteIndex):
1506         (WebCore::IDBObjectStore::count):
1507         (WebCore::IDBObjectStore::doCount):
1508         (WebCore::IDBObjectStore::getAll):
1509         (WebCore::IDBObjectStore::getAllKeys):
1510         * Modules/indexeddb/IDBRequest.cpp:
1511         (WebCore::IDBRequest::result const):
1512         (WebCore:: const):
1513         (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
1514         * Modules/indexeddb/IDBTransaction.cpp:
1515         (WebCore::IDBTransaction::objectStore):
1516         (WebCore::IDBTransaction::abort):
1517         (WebCore::IDBTransaction::putOrAddOnServer):
1518         * Modules/indexeddb/server/IDBServer.cpp:
1519         (WebCore::IDBServer::IDBServer::performGetAllDatabaseNames):
1520         * Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
1521         (WebCore::IDBServer::MemoryIDBBackingStore::deleteRange):
1522         (WebCore::IDBServer::MemoryIDBBackingStore::addRecord):
1523         (WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
1524         (WebCore::IDBServer::MemoryIDBBackingStore::getAllRecords):
1525         (WebCore::IDBServer::MemoryIDBBackingStore::getIndexRecord):
1526         (WebCore::IDBServer::MemoryIDBBackingStore::getCount):
1527         (WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
1528         (WebCore::IDBServer::MemoryIDBBackingStore::iterateCursor):
1529         * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
1530         (WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
1531         (WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
1532         (WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromEncodedFilename):
1533         (WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
1534         (WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
1535         (WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
1536         (WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
1537         (WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
1538         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
1539         (WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
1540         (WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
1541         (WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
1542         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
1543         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
1544         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
1545         (WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
1546         (WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
1547         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteUnusedBlobFileRecords):
1548         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
1549         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
1550         (WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
1551         (WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
1552         (WebCore::IDBServer::SQLiteIDBBackingStore::getBlobRecordsForObjectStoreRecord):
1553         (WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
1554         (WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
1555         (WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
1556         (WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
1557         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
1558         (WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
1559         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
1560         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
1561         (WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
1562         (WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
1563         (WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
1564         (WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
1565         (WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
1566         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
1567         * Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
1568         (WebCore::IDBServer::SQLiteIDBTransaction::begin):
1569         (WebCore::IDBServer::SQLiteIDBTransaction::commit):
1570         (WebCore::IDBServer::SQLiteIDBTransaction::abort):
1571         * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
1572         (WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
1573         (WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
1574         (WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
1575         (WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
1576         (WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
1577         (WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
1578         (WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
1579         * Modules/indexeddb/shared/IDBError.h:
1580         (WebCore::IDBError::userDeleteError):
1581         * Modules/indexeddb/shared/IDBTransactionInfo.cpp:
1582         (WebCore::IDBTransactionInfo::loggingString const):
1583         * Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
1584         (WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):
1585         * Modules/mediastream/PeerConnectionBackend.cpp:
1586         (WebCore::PeerConnectionBackend::addIceCandidate):
1587         * Modules/mediastream/UserMediaRequest.cpp:
1588         (WebCore::UserMediaRequest::deny):
1589         * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
1590         (WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):
1591         * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
1592         (WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate):
1593         * Modules/paymentrequest/PaymentRequest.cpp:
1594         (WebCore::checkAndCanonicalizeTotal):
1595         (WebCore::PaymentRequest::create):
1596         * Modules/quota/DOMWindowQuota.cpp:
1597         (WebCore::DOMWindowQuota::webkitStorageInfo const):
1598         * Modules/webaudio/AudioBufferSourceNode.cpp:
1599         (WebCore::AudioBufferSourceNode::looping):
1600         (WebCore::AudioBufferSourceNode::setLooping):
1601         * Modules/webaudio/AudioNode.cpp:
1602         (WebCore::AudioNode::channelCountMode):
1603         (WebCore::AudioNode::channelInterpretation):
1604         * Modules/webaudio/MediaStreamAudioSource.cpp:
1605         (WebCore::MediaStreamAudioSource::MediaStreamAudioSource):
1606         * Modules/webauthn/AuthenticatorManager.cpp:
1607         (WebCore::AuthenticatorManagerInternal::produceClientDataJson):
1608         (WebCore::AuthenticatorManagerInternal::initTimeoutTimer):
1609         (WebCore::AuthenticatorManager::create const):
1610         (WebCore::AuthenticatorManager::discoverFromExternalSource const):
1611         (WebCore::AuthenticatorManager::isUserVerifyingPlatformAuthenticatorAvailable const):
1612         * Modules/webauthn/cocoa/LocalAuthenticator.mm:
1613         (WebCore::LocalAuthenticator::makeCredential):
1614         (WebCore::LocalAuthenticator::getAssertion):
1615         * Modules/webdatabase/DatabaseTracker.cpp:
1616         (WebCore::DatabaseTracker::usage):
1617         * Modules/websockets/WebSocket.cpp:
1618         (WebCore::WebSocket::connect):
1619         (WebCore::WebSocket::close):
1620         (WebCore::WebSocket::binaryType const):
1621         * Modules/websockets/WebSocketHandshake.cpp:
1622         (WebCore::WebSocketHandshake::readStatusLine):
1623         (WebCore::WebSocketHandshake::readHTTPHeaders):
1624         (WebCore::WebSocketHandshake::checkResponseHeaders):
1625         * Modules/webvr/VRDisplay.cpp:
1626         (WebCore::VRDisplay::requestPresent):
1627         (WebCore::VRDisplay::exitPresent):
1628         * accessibility/AccessibilityObject.cpp:
1629         (WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
1630         (WebCore::AccessibilityObject::invalidStatus const):
1631         * accessibility/AccessibilityRenderObject.cpp:
1632         (WebCore::AccessibilityRenderObject::textUnderElement const):
1633         * bindings/js/JSCustomElementInterface.cpp:
1634         (WebCore::constructCustomElementSynchronously):
1635         * bindings/js/JSCustomElementRegistryCustom.cpp:
1636         (WebCore::getCustomElementCallback):
1637         (WebCore::validateCustomElementNameAndThrowIfNeeded):
1638         (WebCore::JSCustomElementRegistry::define):
1639         * bindings/js/JSCustomXPathNSResolver.cpp:
1640         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
1641         * bindings/js/JSDOMConstructorBase.cpp:
1642         (WebCore::callThrowTypeError):
1643         * bindings/js/JSDOMConstructorBase.h:
1644         (WebCore::JSDOMConstructorBase::className):
1645         * bindings/js/JSDOMConstructorNotConstructable.h:
1646         (WebCore::JSDOMConstructorNotConstructable::callThrowTypeError):
1647         * bindings/js/JSDOMExceptionHandling.cpp:
1648         (WebCore::createDOMException):
1649         (WebCore::throwSequenceTypeError):
1650         (WebCore::throwNonFiniteTypeError):
1651         * bindings/js/JSDOMIterator.h:
1652         (WebCore::iteratorForEach):
1653         (WebCore::IteratorTraits>::next):
1654         * bindings/js/JSDOMWindowBase.cpp:
1655         (WebCore::isResponseCorrect):
1656         (WebCore::handleResponseOnStreamingAction):
1657         (WebCore::JSDOMWindowBase::compileStreaming):
1658         (WebCore::JSDOMWindowBase::instantiateStreaming):
1659         * bindings/js/JSDOMWindowCustom.cpp:
1660         (WebCore::JSDOMWindow::preventExtensions):
1661         (WebCore::JSDOMWindow::toStringName):
1662         * bindings/js/JSHTMLElementCustom.cpp:
1663         (WebCore::constructJSHTMLElement):
1664         * bindings/js/JSLocationCustom.cpp:
1665         (WebCore::JSLocation::preventExtensions):
1666         (WebCore::JSLocation::toStringName):
1667         * bindings/js/JSReadableStreamPrivateConstructors.cpp:
1668         (WebCore::constructJSReadableStreamDefaultController):
1669         (WebCore::constructJSReadableByteStreamController):
1670         (WebCore::constructJSReadableStreamBYOBRequest):
1671         * bindings/js/JSRemoteDOMWindowCustom.cpp:
1672         (WebCore::JSRemoteDOMWindow::preventExtensions):
1673         (WebCore::JSRemoteDOMWindow::toStringName):
1674         * bindings/js/ReadableStreamDefaultController.cpp:
1675         (WebCore::ReadableStreamDefaultController::invoke):
1676         * bindings/js/ScriptModuleLoader.cpp:
1677         (WebCore::resolveModuleSpecifier):
1678         (WebCore::ScriptModuleLoader::resolve):
1679         (WebCore::ScriptModuleLoader::fetch):
1680         (WebCore::ScriptModuleLoader::evaluate):
1681         (WebCore::ScriptModuleLoader::importModule):
1682         (WebCore::ScriptModuleLoader::notifyFinished):
1683         * bindings/js/SerializedScriptValue.cpp:
1684         (WebCore::maybeThrowExceptionIfSerializationFailed):
1685         * bindings/js/WorkerScriptController.cpp:
1686         (WebCore::WorkerScriptController::evaluate):
1687         * bindings/scripts/CodeGeneratorJS.pm:
1688         (GenerateDefaultValue):
1689         (GenerateConstructorHelperMethods):
1690         (GenerateCallTracer):
1691         * bindings/scripts/test/JS/JSInterfaceName.cpp:
1692         (WebCore::JSInterfaceNameConstructor::initializeProperties):
1693         * bindings/scripts/test/JS/JSMapLike.cpp:
1694         (WebCore::JSMapLikeConstructor::initializeProperties):
1695         * bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
1696         (WebCore::JSReadOnlyMapLikeConstructor::initializeProperties):
1697         * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
1698         (WebCore::JSTestActiveDOMObjectConstructor::initializeProperties):
1699         * bindings/scripts/test/JS/JSTestCEReactions.cpp:
1700         (WebCore::JSTestCEReactionsConstructor::initializeProperties):
1701         * bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
1702         (WebCore::JSTestCEReactionsStringifierConstructor::initializeProperties):
1703         * bindings/scripts/test/JS/JSTestCallTracer.cpp:
1704         (WebCore::JSTestCallTracerConstructor::initializeProperties):
1705         (WebCore::jsTestCallTracerTestAttributeInterfaceGetter):
1706         (WebCore::setJSTestCallTracerTestAttributeInterfaceSetter):
1707         (WebCore::jsTestCallTracerTestAttributeSpecifiedGetter):
1708         (WebCore::setJSTestCallTracerTestAttributeSpecifiedSetter):
1709         (WebCore::jsTestCallTracerTestAttributeWithVariantGetter):
1710         (WebCore::setJSTestCallTracerTestAttributeWithVariantSetter):
1711         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterfaceBody):
1712         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecifiedBody):
1713         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArgumentsBody):
1714         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
1715         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgumentBody):
1716         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
1717         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
1718         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):
1719         * bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
1720         (WebCore::JSTestCallbackInterfaceConstructor::initializeProperties):
1721         * bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
1722         (WebCore::JSTestClassWithJSBuiltinConstructorConstructor::initializeProperties):
1723         * bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
1724         (WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::initializeProperties):
1725         * bindings/scripts/test/JS/JSTestDOMJIT.cpp:
1726         (WebCore::JSTestDOMJITConstructor::initializeProperties):
1727         * bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
1728         (WebCore::JSTestEnabledBySettingConstructor::initializeProperties):
1729         * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
1730         (WebCore::JSTestEventConstructorConstructor::initializeProperties):
1731         * bindings/scripts/test/JS/JSTestEventTarget.cpp:
1732         (WebCore::JSTestEventTargetConstructor::initializeProperties):
1733         * bindings/scripts/test/JS/JSTestException.cpp:
1734         (WebCore::JSTestExceptionConstructor::initializeProperties):
1735         * bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
1736         (WebCore::JSTestGenerateIsReachableConstructor::initializeProperties):
1737         * bindings/scripts/test/JS/JSTestGlobalObject.cpp:
1738         (WebCore::JSTestGlobalObjectConstructor::initializeProperties):
1739         * bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
1740         (WebCore::JSTestIndexedSetterNoIdentifierConstructor::initializeProperties):
1741         * bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
1742         (WebCore::JSTestIndexedSetterThrowingExceptionConstructor::initializeProperties):
1743         * bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
1744         (WebCore::JSTestIndexedSetterWithIdentifierConstructor::initializeProperties):
1745         * bindings/scripts/test/JS/JSTestInterface.cpp:
1746         (WebCore::JSTestInterfaceConstructor::construct):
1747         (WebCore::JSTestInterfaceConstructor::initializeProperties):
1748         * bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
1749         (WebCore::JSTestInterfaceLeadingUnderscoreConstructor::initializeProperties):
1750         * bindings/scripts/test/JS/JSTestIterable.cpp:
1751         (WebCore::JSTestIterableConstructor::initializeProperties):
1752         * bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
1753         (WebCore::JSTestJSBuiltinConstructorConstructor::initializeProperties):
1754         * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
1755         (WebCore::JSTestMediaQueryListListenerConstructor::initializeProperties):
1756         * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
1757         (WebCore::JSTestNamedAndIndexedSetterNoIdentifierConstructor::initializeProperties):
1758         * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
1759         (WebCore::JSTestNamedAndIndexedSetterThrowingExceptionConstructor::initializeProperties):
1760         * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
1761         (WebCore::JSTestNamedAndIndexedSetterWithIdentifierConstructor::initializeProperties):
1762         * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
1763         (WebCore::JSTestNamedConstructorConstructor::initializeProperties):
1764         (WebCore::JSTestNamedConstructorNamedConstructor::construct):
1765         (WebCore::JSTestNamedConstructorNamedConstructor::initializeProperties):
1766         * bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
1767         (WebCore::JSTestNamedDeleterNoIdentifierConstructor::initializeProperties):
1768         * bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
1769         (WebCore::JSTestNamedDeleterThrowingExceptionConstructor::initializeProperties):
1770         * bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
1771         (WebCore::JSTestNamedDeleterWithIdentifierConstructor::initializeProperties):
1772         * bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
1773         (WebCore::JSTestNamedDeleterWithIndexedGetterConstructor::initializeProperties):
1774         * bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
1775         (WebCore::JSTestNamedGetterCallWithConstructor::initializeProperties):
1776         * bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
1777         (WebCore::JSTestNamedGetterNoIdentifierConstructor::initializeProperties):
1778         * bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
1779         (WebCore::JSTestNamedGetterWithIdentifierConstructor::initializeProperties):
1780         * bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
1781         (WebCore::JSTestNamedSetterNoIdentifierConstructor::initializeProperties):
1782         * bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
1783         (WebCore::JSTestNamedSetterThrowingExceptionConstructor::initializeProperties):
1784         * bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
1785         (WebCore::JSTestNamedSetterWithIdentifierConstructor::initializeProperties):
1786         * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
1787         (WebCore::JSTestNamedSetterWithIndexedGetterConstructor::initializeProperties):
1788         * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
1789         (WebCore::JSTestNamedSetterWithIndexedGetterAndSetterConstructor::initializeProperties):
1790         * bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
1791         (WebCore::JSTestNamedSetterWithOverrideBuiltinsConstructor::initializeProperties):
1792         * bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
1793         (WebCore::JSTestNamedSetterWithUnforgablePropertiesConstructor::initializeProperties):
1794         * bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
1795         (WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltinsConstructor::initializeProperties):
1796         * bindings/scripts/test/JS/JSTestNode.cpp:
1797         (WebCore::JSTestNodeConstructor::initializeProperties):
1798         * bindings/scripts/test/JS/JSTestObj.cpp:
1799         (WebCore::convertDictionary<TestObj::Dictionary>):
1800         (WebCore::JSTestObjConstructor::initializeProperties):
1801         (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringAndDefaultValueBody):
1802         * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
1803         (WebCore::JSTestOverloadedConstructorsConstructor::initializeProperties):
1804         * bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
1805         (WebCore::JSTestOverloadedConstructorsWithSequenceConstructor::initializeProperties):
1806         * bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
1807         (WebCore::JSTestOverrideBuiltinsConstructor::initializeProperties):
1808         * bindings/scripts/test/JS/JSTestPluginInterface.cpp:
1809         (WebCore::JSTestPluginInterfaceConstructor::initializeProperties):
1810         * bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
1811         (WebCore::JSTestPromiseRejectionEventConstructor::initializeProperties):
1812         * bindings/scripts/test/JS/JSTestSerialization.cpp:
1813         (WebCore::JSTestSerializationConstructor::initializeProperties):
1814         * bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
1815         (WebCore::JSTestSerializationIndirectInheritanceConstructor::initializeProperties):
1816         * bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
1817         (WebCore::JSTestSerializationInheritConstructor::initializeProperties):
1818         * bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
1819         (WebCore::JSTestSerializationInheritFinalConstructor::initializeProperties):
1820         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
1821         (WebCore::JSTestSerializedScriptValueInterfaceConstructor::initializeProperties):
1822         * bindings/scripts/test/JS/JSTestStringifier.cpp:
1823         (WebCore::JSTestStringifierConstructor::initializeProperties):
1824         * bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
1825         (WebCore::JSTestStringifierAnonymousOperationConstructor::initializeProperties):
1826         * bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
1827         (WebCore::JSTestStringifierNamedOperationConstructor::initializeProperties):
1828         * bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
1829         (WebCore::JSTestStringifierOperationImplementedAsConstructor::initializeProperties):
1830         * bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
1831         (WebCore::JSTestStringifierOperationNamedToStringConstructor::initializeProperties):
1832         * bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
1833         (WebCore::JSTestStringifierReadOnlyAttributeConstructor::initializeProperties):
1834         * bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
1835         (WebCore::JSTestStringifierReadWriteAttributeConstructor::initializeProperties):
1836         * bindings/scripts/test/JS/JSTestTypedefs.cpp:
1837         (WebCore::JSTestTypedefsConstructor::initializeProperties):
1838         * bridge/c/c_instance.cpp:
1839         (JSC::Bindings::CInstance::invokeMethod):
1840         (JSC::Bindings::CInstance::invokeDefaultMethod):
1841         (JSC::Bindings::CInstance::invokeConstruct):
1842         (JSC::Bindings::CInstance::stringValue const):
1843         (JSC::Bindings::CInstance::toJSPrimitive const):
1844         * bridge/objc/objc_instance.mm:
1845         (ObjcInstance::invokeMethod):
1846         * bridge/objc/objc_runtime.mm:
1847         (JSC::Bindings::ObjcArray::setValueAt const):
1848         * contentextensions/ContentExtensionsBackend.cpp:
1849         (WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
1850         * crypto/SubtleCrypto.cpp:
1851         (WebCore::rejectWithException):
1852         (WebCore::SubtleCrypto::encrypt):
1853         (WebCore::SubtleCrypto::decrypt):
1854         (WebCore::SubtleCrypto::sign):
1855         (WebCore::SubtleCrypto::verify):
1856         (WebCore::SubtleCrypto::deriveKey):
1857         (WebCore::SubtleCrypto::deriveBits):
1858         (WebCore::SubtleCrypto::exportKey):
1859         (WebCore::SubtleCrypto::wrapKey):
1860         (WebCore::SubtleCrypto::unwrapKey):
1861         * crypto/keys/CryptoKeyEC.cpp:
1862         (WebCore::CryptoKeyEC::algorithm const):
1863         * css/CSSInheritedValue.cpp:
1864         (WebCore::CSSInheritedValue::customCSSText const):
1865         * css/CSSInitialValue.cpp:
1866         (WebCore::CSSInitialValue::customCSSText const):
1867         * css/CSSKeyframesRule.cpp:
1868         (WebCore::CSSKeyframesRule::insertRule):
1869         * css/CSSRevertValue.cpp:
1870         (WebCore::CSSRevertValue::customCSSText const):
1871         * css/CSSStyleSheet.h:
1872         * css/CSSUnsetValue.cpp:
1873         (WebCore::CSSUnsetValue::customCSSText const):
1874         * css/CSSValueList.cpp:
1875         (WebCore::CSSValueList::customCSSText const):
1876         * css/DOMMatrixReadOnly.cpp:
1877         (WebCore::DOMMatrixReadOnly::validateAndFixup):
1878         (WebCore::DOMMatrixReadOnly::toFloat32Array const):
1879         (WebCore::DOMMatrixReadOnly::toFloat64Array const):
1880         (WebCore::DOMMatrixReadOnly::toString const):
1881         * css/DeprecatedCSSOMValueList.cpp:
1882         (WebCore::DeprecatedCSSOMValueList::cssText const):
1883         * css/FontFace.cpp:
1884         (WebCore::FontFace::create):
1885         (WebCore::FontFace::unicodeRange const):
1886         (WebCore::FontFace::featureSettings const):
1887         * css/MediaQuery.cpp:
1888         (WebCore::MediaQuery::serialize const):
1889         * css/PropertySetCSSStyleDeclaration.cpp:
1890         (WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
1891         * css/WebKitCSSMatrix.cpp:
1892         (WebCore::WebKitCSSMatrix::toString const):
1893         * css/parser/MediaQueryParser.cpp:
1894         (WebCore::MediaQueryParser::commitMediaQuery):
1895         * dom/CDATASection.cpp:
1896         (WebCore::CDATASection::nodeName const):
1897         * dom/Comment.cpp:
1898         (WebCore::Comment::nodeName const):
1899         * dom/DOMException.cpp:
1900         (WebCore::DOMException::description const):
1901         (WebCore::DOMException::create):
1902         * dom/DOMException.h:
1903         (WebCore::DOMException::name):
1904         (WebCore::DOMException::message):
1905         * dom/DOMImplementation.cpp:
1906         (WebCore::DOMImplementation::createHTMLDocument):
1907         * dom/DataTransfer.cpp:
1908         (WebCore::DataTransfer::DataTransfer):
1909         (WebCore::DataTransfer::types const):
1910         (WebCore::DataTransfer::createForInputEvent):
1911         (WebCore::DataTransfer::dropEffect const):
1912         (WebCore::DataTransfer::effectAllowed const):
1913         * dom/DataTransferItem.cpp:
1914         (WebCore::DataTransferItem::kind const):
1915         * dom/Document.cpp:
1916         (WebCore::Document::suggestedMIMEType const):
1917         (WebCore::Document::contentType const):
1918         (WebCore::Document::nodeName const):
1919         (WebCore::Document::writeln):
1920         (WebCore::Document::canNavigate):
1921         (WebCore::Document::designMode const):
1922         (WebCore::Document::requestFullScreenForElement):
1923         * dom/DocumentFragment.cpp:
1924         (WebCore::DocumentFragment::nodeName const):
1925         * dom/InlineStyleSheetOwner.cpp:
1926         (WebCore::InlineStyleSheetOwner::createSheet):
1927         * dom/MouseEvent.cpp:
1928         (WebCore::MouseEvent::initMouseEventQuirk):
1929         * dom/ScriptElement.cpp:
1930         (WebCore::ScriptElement::requestModuleScript):
1931         * dom/ScriptElementCachedScriptFetcher.cpp:
1932         (WebCore::ScriptElementCachedScriptFetcher::requestModuleScript const):
1933         * dom/ScriptExecutionContext.cpp:
1934         (WebCore::ScriptExecutionContext::dispatchErrorEvent):
1935         * dom/ScriptedAnimationController.cpp:
1936         (WebCore::throttlingReasonsToString):
1937         * dom/Text.cpp:
1938         (WebCore::Text::nodeName const):
1939         * dom/TextEncoder.cpp:
1940         (WebCore::TextEncoder::encoding const):
1941         * dom/Traversal.cpp:
1942         (WebCore::NodeIteratorBase::acceptNode):
1943         * editing/EditCommand.cpp:
1944         (WebCore::inputTypeNameForEditingAction):
1945         * editing/Editing.cpp:
1946         (WebCore::createTabSpanElement):
1947         * editing/Editor.cpp:
1948         (WebCore::createDataTransferForClipboardEvent):
1949         * editing/EditorCommand.cpp:
1950         (WebCore::executeInsertBacktab):
1951         (WebCore::executeInsertLineBreak):
1952         (WebCore::executeInsertNewline):
1953         (WebCore::executeInsertTab):
1954         (WebCore::executeJustifyCenter):
1955         (WebCore::executeJustifyFull):
1956         (WebCore::executeJustifyLeft):
1957         (WebCore::executeJustifyRight):
1958         (WebCore::executeStrikethrough):
1959         (WebCore::executeSubscript):
1960         (WebCore::executeSuperscript):
1961         (WebCore::executeToggleBold):
1962         (WebCore::executeToggleItalic):
1963         (WebCore::executeUnderline):
1964         (WebCore::executeUnscript):
1965         (WebCore::stateBold):
1966         (WebCore::stateItalic):
1967         (WebCore::stateStrikethrough):
1968         (WebCore::stateSubscript):
1969         (WebCore::stateSuperscript):
1970         (WebCore::stateUnderline):
1971         (WebCore::stateJustifyCenter):
1972         (WebCore::stateJustifyFull):
1973         (WebCore::stateJustifyLeft):
1974         (WebCore::stateJustifyRight):
1975         (WebCore::Editor::Command::value const):
1976         * editing/SmartReplace.cpp:
1977         (WebCore::getSmartSet):
1978         * fileapi/FileCocoa.mm:
1979         (WebCore::File::computeNameAndContentTypeForReplacedFile):
1980         * html/BaseCheckableInputType.cpp:
1981         (WebCore::BaseCheckableInputType::saveFormControlState const):
1982         * html/BaseChooserOnlyDateAndTimeInputType.cpp:
1983         (WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
1984         * html/ColorInputType.cpp:
1985         (WebCore::ColorInputType::fallbackValue const):
1986         * html/DOMFormData.cpp:
1987         (WebCore::DOMFormData::createFileEntry):
1988         * html/FTPDirectoryDocument.cpp:
1989         (WebCore::processFilesizeString):
1990         (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
1991         * html/HTMLAnchorElement.cpp:
1992         (WebCore::HTMLAnchorElement::relList const):
1993         (WebCore::HTMLAnchorElement::isSystemPreviewLink const):
1994         * html/HTMLAppletElement.cpp:
1995         (WebCore::HTMLAppletElement::HTMLAppletElement):
1996         (WebCore::HTMLAppletElement::updateWidget):
1997         * html/HTMLCanvasElement.cpp:
1998         (WebCore::toEncodingMimeType):
1999         (WebCore::HTMLCanvasElement::toDataURL):
2000         (WebCore::HTMLCanvasElement::captureStream):
2001         * html/HTMLElement.cpp:
2002         (WebCore::HTMLElement::contentEditable const):
2003         * html/HTMLFormControlElement.cpp:
2004         (WebCore::shouldAutofocus):
2005         * html/HTMLHtmlElement.cpp:
2006         (WebCore::HTMLHtmlElement::insertedByParser):
2007         * html/HTMLKeygenElement.cpp:
2008         (WebCore::HTMLKeygenElement::keytype const):
2009         * html/HTMLMediaElement.cpp:
2010         (WebCore::HTMLMediaElement::canPlayType const):
2011         (WebCore::stringForNetworkState):
2012         (WebCore::HTMLMediaElement::preload const):
2013         (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
2014         * html/HTMLObjectElement.cpp:
2015         (WebCore::mapDataParamToSrc):
2016         * html/HTMLPlugInElement.cpp:
2017         (WebCore::HTMLPlugInElement::setReplacement):
2018         * html/ImageData.cpp:
2019         (WebCore::ImageData::create):
2020         * html/ImageDocument.cpp:
2021         (WebCore::ImageDocument::createDocumentStructure):
2022         * html/ImageInputType.cpp:
2023         (WebCore::ImageInputType::appendFormData const):
2024         * html/PluginDocument.cpp:
2025         (WebCore::PluginDocumentParser::createDocumentStructure):
2026         * html/canvas/WebGL2RenderingContext.cpp:
2027         (WebCore::WebGL2RenderingContext::getExtension):
2028         (WebCore::WebGL2RenderingContext::getSupportedExtensions):
2029         (WebCore::WebGL2RenderingContext::getParameter):
2030         * html/canvas/WebGLCompressedTextureASTC.cpp:
2031         (WebCore::WebGLCompressedTextureASTC::WebGLCompressedTextureASTC):
2032         (WebCore::WebGLCompressedTextureASTC::getSupportedProfiles):
2033         (WebCore::WebGLCompressedTextureASTC::supported):
2034         (WebCore::m_isLDRSupported): Deleted.
2035         * html/canvas/WebGLRenderingContext.cpp:
2036         (WebCore::WebGLRenderingContext::getExtension):
2037         (WebCore::WebGLRenderingContext::getSupportedExtensions):
2038         (WebCore::WebGLRenderingContext::getParameter):
2039         * html/canvas/WebGLRenderingContextBase.cpp:
2040         (WebCore::WebGLRenderingContextBase::create):
2041         (WebCore::WebGLRenderingContextBase::enableSupportedExtension):
2042         * html/canvas/WebGLRenderingContextBase.h:
2043         * html/canvas/WebGPUEnums.cpp:
2044         (WebCore::web3DCompareFunctionName):
2045         * html/parser/HTMLParserIdioms.cpp:
2046         (WebCore::parseCORSSettingsAttribute):
2047         * html/parser/HTMLPreloadScanner.cpp:
2048         (WebCore::TokenPreloadScanner::initiatorFor):
2049         * html/parser/HTMLResourcePreloader.cpp:
2050         (WebCore::PreloadRequest::resourceRequest):
2051         * html/parser/HTMLTreeBuilder.cpp:
2052         (WebCore::HTMLTreeBuilder::insertPhoneNumberLink):
2053         * html/track/DataCue.cpp:
2054         (WebCore::DataCue::toJSONString const):
2055         * html/track/InbandGenericTextTrack.cpp:
2056         (WebCore::InbandGenericTextTrack::updateCueFromCueData):
2057         * html/track/TextTrackCue.cpp:
2058         (WebCore::TextTrackCue::toJSON const):
2059         * html/track/TextTrackCueGeneric.cpp:
2060         (WebCore::TextTrackCueGeneric::toJSONString const):
2061         * html/track/TrackBase.cpp:
2062         (WebCore::TrackBase::setLanguage):
2063         * html/track/VTTCue.cpp:
2064         (WebCore::VTTCue::toJSON const):
2065         * inspector/CommandLineAPIModule.cpp:
2066         (WebCore::CommandLineAPIModule::CommandLineAPIModule):
2067         * inspector/InspectorCanvas.cpp:
2068         (WebCore::InspectorCanvas::getCanvasContentAsDataURL):
2069         (WebCore::InspectorCanvas::indexForData):
2070         (WebCore::InspectorCanvas::buildInitialState):
2071         (WebCore::InspectorCanvas::buildArrayForCanvasGradient):
2072         (WebCore::InspectorCanvas::buildArrayForCanvasPattern):
2073         * inspector/InspectorFrontendClient.h:
2074         (WebCore::InspectorFrontendClient::debuggableType):
2075         * inspector/InspectorFrontendClientLocal.cpp:
2076         (WebCore::InspectorFrontendClientLocal::openInNewTab):
2077         * inspector/InspectorFrontendHost.cpp:
2078         (WebCore::InspectorFrontendHost::userInterfaceLayoutDirection):
2079         (WebCore::InspectorFrontendHost::platform):
2080         (WebCore::InspectorFrontendHost::port):
2081         * inspector/InspectorOverlay.cpp:
2082         (WebCore::InspectorOverlay::setIndicating):
2083         (WebCore::InspectorOverlay::drawPaintRects):
2084         (WebCore::InspectorOverlay::drawRulers):
2085         (WebCore::appendPathSegment):
2086         * inspector/InspectorStyleSheet.h:
2087         (WebCore::InspectorCSSId::InspectorCSSId):
2088         * inspector/TimelineRecordFactory.cpp:
2089         (WebCore::TimelineRecordFactory::createGenericRecord):
2090         (WebCore::TimelineRecordFactory::createFunctionCallData):
2091         (WebCore::TimelineRecordFactory::createConsoleProfileData):
2092         (WebCore::TimelineRecordFactory::createProbeSampleData):
2093         (WebCore::TimelineRecordFactory::createEventDispatchData):
2094         (WebCore::TimelineRecordFactory::createGenericTimerData):
2095         (WebCore::TimelineRecordFactory::createTimerInstallData):
2096         (WebCore::TimelineRecordFactory::createEvaluateScriptData):
2097         (WebCore::TimelineRecordFactory::createTimeStampData):
2098         (WebCore::TimelineRecordFactory::createAnimationFrameData):
2099         (WebCore::TimelineRecordFactory::createPaintData):
2100         (WebCore::TimelineRecordFactory::appendLayoutRoot):
2101         * inspector/WebInjectedScriptHost.cpp:
2102         (WebCore::WebInjectedScriptHost::subtype):
2103         (WebCore::jsStringForPaymentRequestState):
2104         (WebCore::WebInjectedScriptHost::getInternalProperties):
2105         * inspector/agents/InspectorApplicationCacheAgent.cpp:
2106         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
2107         * inspector/agents/InspectorCSSAgent.cpp:
2108         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
2109         (WebCore::InspectorCSSAgent::getMatchedStylesForNode):
2110         (WebCore::InspectorCSSAgent::createStyleSheet):
2111         (WebCore::InspectorCSSAgent::addRule):
2112         (WebCore::InspectorCSSAgent::elementForId):
2113         (WebCore::InspectorCSSAgent::assertStyleSheetForId):
2114         * inspector/agents/InspectorCanvasAgent.cpp:
2115         (WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
2116         (WebCore::InspectorCanvasAgent::requestNode):
2117         (WebCore::InspectorCanvasAgent::requestContent):
2118         (WebCore::InspectorCanvasAgent::resolveCanvasContext):
2119         (WebCore::InspectorCanvasAgent::startRecording):
2120         (WebCore::InspectorCanvasAgent::stopRecording):
2121         (WebCore::InspectorCanvasAgent::requestShaderSource):
2122         (WebCore::InspectorCanvasAgent::updateShader):
2123         (WebCore::InspectorCanvasAgent::setShaderProgramDisabled):
2124         (WebCore::InspectorCanvasAgent::setShaderProgramHighlighted):
2125         (WebCore::InspectorCanvasAgent::assertInspectorCanvas):
2126         (WebCore::InspectorCanvasAgent::assertInspectorProgram):
2127         * inspector/agents/InspectorDOMAgent.cpp:
2128         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2129         (WebCore::InspectorDOMAgent::assertNode):
2130         (WebCore::InspectorDOMAgent::assertDocument):
2131         (WebCore::InspectorDOMAgent::assertElement):
2132         (WebCore::InspectorDOMAgent::assertEditableNode):
2133         (WebCore::InspectorDOMAgent::assertEditableElement):
2134         (WebCore::InspectorDOMAgent::getDocument):
2135         (WebCore::InspectorDOMAgent::pushNodeToFrontend):
2136         (WebCore::InspectorDOMAgent::requestChildNodes):
2137         (WebCore::InspectorDOMAgent::querySelector):
2138         (WebCore::InspectorDOMAgent::querySelectorAll):
2139         (WebCore::InspectorDOMAgent::releaseBackendNodeIds):
2140         (WebCore::InspectorDOMAgent::setAttributesAsText):
2141         (WebCore::InspectorDOMAgent::removeNode):
2142         (WebCore::InspectorDOMAgent::setOuterHTML):
2143         (WebCore::InspectorDOMAgent::insertAdjacentHTML):
2144         (WebCore::InspectorDOMAgent::setNodeValue):
2145         (WebCore::InspectorDOMAgent::setEventListenerDisabled):
2146         (WebCore::InspectorDOMAgent::performSearch):
2147         (WebCore::InspectorDOMAgent::getSearchResults):
2148         (WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
2149         (WebCore::InspectorDOMAgent::highlightQuad):
2150         (WebCore::InspectorDOMAgent::highlightSelector):
2151         (WebCore::InspectorDOMAgent::highlightNode):
2152         (WebCore::InspectorDOMAgent::highlightNodeList):
2153         (WebCore::InspectorDOMAgent::moveTo):
2154         (WebCore::InspectorDOMAgent::focus):
2155         (WebCore::InspectorDOMAgent::setInspectedNode):
2156         (WebCore::InspectorDOMAgent::resolveNode):
2157         (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
2158         (WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):
2159         * inspector/agents/InspectorDOMDebuggerAgent.cpp:
2160         (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
2161         (WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
2162         (WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
2163         (WebCore::domTypeName):
2164         (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
2165         * inspector/agents/InspectorDOMStorageAgent.cpp:
2166         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2167         (WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
2168         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
2169         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
2170         (WebCore::InspectorDOMStorageAgent::findStorageArea):
2171         * inspector/agents/InspectorDatabaseAgent.cpp:
2172         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
2173         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
2174         * inspector/agents/InspectorIndexedDBAgent.cpp:
2175         (WebCore::Inspector::idbKeyRangeFromKeyRange):
2176         (WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
2177         (WebCore::InspectorIndexedDBAgent::requestData):
2178         * inspector/agents/InspectorLayerTreeAgent.cpp:
2179         (WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
2180         (WebCore::InspectorLayerTreeAgent::layersForNode):
2181         (WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
2182         * inspector/agents/InspectorMemoryAgent.cpp:
2183         (WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
2184         * inspector/agents/InspectorNetworkAgent.cpp:
2185         (WebCore::InspectorNetworkAgent::InspectorNetworkAgent):
2186         (WebCore::InspectorNetworkAgent::getResponseBody):
2187         (WebCore::InspectorNetworkAgent::loadResource):
2188         (WebCore::InspectorNetworkAgent::resolveWebSocket):
2189         (WebCore::InspectorNetworkAgent::createTextDecoder):
2190         (WebCore::InspectorNetworkAgent::searchInRequest):
2191         * inspector/agents/InspectorPageAgent.cpp:
2192         (WebCore::InspectorPageAgent::resourceContent):
2193         (WebCore::InspectorPageAgent::InspectorPageAgent):
2194         (WebCore::InspectorPageAgent::navigate):
2195         (WebCore::InspectorPageAgent::assertFrame):
2196         (WebCore::InspectorPageAgent::assertDocumentLoader):
2197         (WebCore::InspectorPageAgent::snapshotNode):
2198         (WebCore::InspectorPageAgent::snapshotRect):
2199         (WebCore::InspectorPageAgent::archive):
2200         * inspector/agents/InspectorTimelineAgent.cpp:
2201         (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
2202         (WebCore::InspectorTimelineAgent::setInstruments):
2203         (WebCore::InspectorTimelineAgent::startFromConsole):
2204         (WebCore::InspectorTimelineAgent::stopFromConsole):
2205         (WebCore::InspectorTimelineAgent::didCompleteRecordEntry):
2206         * inspector/agents/InspectorWorkerAgent.cpp:
2207         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
2208         (WebCore::InspectorWorkerAgent::initialized):
2209         (WebCore::InspectorWorkerAgent::sendMessageToWorker):
2210         * inspector/agents/WebConsoleAgent.cpp:
2211         (WebCore::WebConsoleAgent::setLoggingChannelLevel):
2212         * inspector/agents/page/PageDebuggerAgent.cpp:
2213         (WebCore::PageDebuggerAgent::injectedScriptForEval):
2214         * inspector/agents/page/PageNetworkAgent.cpp:
2215         (WebCore::PageNetworkAgent::scriptExecutionContext):
2216         * inspector/agents/page/PageRuntimeAgent.cpp:
2217         (WebCore::PageRuntimeAgent::injectedScriptForEval):
2218         * inspector/agents/worker/ServiceWorkerAgent.cpp:
2219         (WebCore::ServiceWorkerAgent::ServiceWorkerAgent):
2220         * inspector/agents/worker/WorkerDebuggerAgent.cpp:
2221         (WebCore::WorkerDebuggerAgent::injectedScriptForEval):
2222         * inspector/agents/worker/WorkerRuntimeAgent.cpp:
2223         (WebCore::WorkerRuntimeAgent::injectedScriptForEval):
2224         * loader/ContentFilter.cpp:
2225         (WebCore::ContentFilter::handleProvisionalLoadFailure):
2226         * loader/CrossOriginAccessControl.cpp:
2227         (WebCore::passesAccessControlCheck):
2228         (WebCore::validatePreflightResponse):
2229         * loader/CrossOriginPreflightChecker.cpp:
2230         (WebCore::CrossOriginPreflightChecker::notifyFinished):
2231         (WebCore::CrossOriginPreflightChecker::doPreflight):
2232         * loader/DocumentLoader.cpp:
2233         (WebCore::isRemoteWebArchive):
2234         (WebCore::DocumentLoader::startIconLoading):
2235         * loader/DocumentThreadableLoader.cpp:
2236         (WebCore::DocumentThreadableLoader::reportRedirectionWithBadScheme):
2237         (WebCore::DocumentThreadableLoader::reportContentSecurityPolicyError):
2238         (WebCore::DocumentThreadableLoader::reportCrossOriginResourceSharingError):
2239         (WebCore::DocumentThreadableLoader::reportIntegrityMetadataError):
2240         * loader/FormSubmission.cpp:
2241         (WebCore::FormSubmission::Attributes::parseEncodingType):
2242         * loader/FormSubmission.h:
2243         (WebCore::FormSubmission::Attributes::methodString):
2244         * loader/FrameLoader.cpp:
2245         (WebCore::FrameLoader::initForSynthesizedDocument):
2246         (WebCore::FrameLoader::loadURLIntoChildFrame):
2247         (WebCore::FrameLoader::defaultSubstituteDataForURL):
2248         (WebCore::FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded):
2249         (WebCore::FrameLoader::dispatchBeforeUnloadEvent):
2250         * loader/LinkLoader.cpp:
2251         (WebCore::LinkLoader::preconnectIfNeeded):
2252         * loader/NavigationScheduler.cpp:
2253         (WebCore::NavigationScheduler::scheduleLocationChange):
2254         * loader/PingLoader.cpp:
2255         (WebCore::PingLoader::sendViolationReport):
2256         * loader/ResourceLoadStatistics.cpp:
2257         (WebCore::ResourceLoadStatistics::primaryDomain):
2258         (WebCore::ResourceLoadStatistics::areDomainsAssociated):
2259         * loader/ResourceLoader.cpp:
2260         (WebCore::ResourceLoader::loadDataURL):
2261         (WebCore::ResourceLoader::didBlockAuthenticationChallenge):
2262         * loader/SubresourceLoader.cpp:
2263         (WebCore::SubresourceLoader::willSendRequestInternal):
2264         (WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):
2265         * loader/ThreadableLoader.cpp:
2266         (WebCore::ThreadableLoader::logError):
2267         * loader/appcache/ApplicationCacheGroup.cpp:
2268         (WebCore::ApplicationCacheGroup::abort):
2269         (WebCore::ApplicationCacheGroup::didFinishLoadingEntry):
2270         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2271         (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
2272         * loader/appcache/ApplicationCacheHost.cpp:
2273         (WebCore::ApplicationCacheHost::createFileURL):
2274         * loader/appcache/ManifestParser.cpp:
2275         (WebCore::parseManifest):
2276         * loader/archive/ArchiveFactory.cpp:
2277         (WebCore::createArchiveMIMETypesMap):
2278         * loader/cache/CachedResource.cpp:
2279         (WebCore::CachedResource::load):
2280         * loader/cache/CachedResourceLoader.cpp:
2281         (WebCore::CachedResourceLoader::canRequest):
2282         (WebCore::CachedResourceLoader::requestResource):
2283         * loader/cache/CachedResourceRequest.cpp:
2284         (WebCore::acceptHeaderValueFromType):
2285         (WebCore::CachedResourceRequest::updateAcceptEncodingHeader):
2286         * loader/cache/CachedScript.cpp:
2287         (WebCore::CachedScript::CachedScript):
2288         * loader/cache/MemoryCache.cpp:
2289         (WebCore::MemoryCache::getOriginsWithCache):
2290         * loader/soup/ResourceLoaderSoup.cpp:
2291         (WebCore::ResourceLoader::loadGResource):
2292         * page/DOMSelection.cpp:
2293         (WebCore::DOMSelection::type const):
2294         * page/DOMWindow.cpp:
2295         (WebCore::DOMWindow::close):
2296         (WebCore::DOMWindow::addEventListener):
2297         (WebCore::DOMWindow::createWindow):
2298         * page/DebugPageOverlays.cpp:
2299         (WebCore::touchEventRegionColors):
2300         * page/DiagnosticLoggingKeys.cpp:
2301         (WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
2302         (WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
2303         (WebCore::DiagnosticLoggingKeys::memoryCacheEntryDecisionKey):
2304         (WebCore::DiagnosticLoggingKeys::memoryCacheUsageKey):
2305         (WebCore::DiagnosticLoggingKeys::missingValidatorFieldsKey):
2306         (WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
2307         (WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
2308         (WebCore::DiagnosticLoggingKeys::postPageBackgroundingCPUUsageKey):
2309         (WebCore::DiagnosticLoggingKeys::postPageBackgroundingMemoryUsageKey):
2310         (WebCore::DiagnosticLoggingKeys::pageHandlesWebGLContextLossKey):
2311         (WebCore::DiagnosticLoggingKeys::postPageLoadCPUUsageKey):
2312         (WebCore::DiagnosticLoggingKeys::postPageLoadMemoryUsageKey):
2313         (WebCore::DiagnosticLoggingKeys::provisionalLoadKey):
2314         (WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
2315         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
2316         (WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
2317         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
2318         (WebCore::DiagnosticLoggingKeys::pageLoadedKey):
2319         (WebCore::DiagnosticLoggingKeys::playedKey):
2320         (WebCore::DiagnosticLoggingKeys::engineFailedToLoadKey):
2321         (WebCore::DiagnosticLoggingKeys::entryRightlyNotWarmedUpKey):
2322         (WebCore::DiagnosticLoggingKeys::entryWronglyNotWarmedUpKey):
2323         (WebCore::DiagnosticLoggingKeys::navigationKey):
2324         (WebCore::DiagnosticLoggingKeys::needsRevalidationKey):
2325         (WebCore::DiagnosticLoggingKeys::networkCacheKey):
2326         (WebCore::DiagnosticLoggingKeys::networkCacheFailureReasonKey):
2327         (WebCore::DiagnosticLoggingKeys::networkCacheUnusedReasonKey):
2328         (WebCore::DiagnosticLoggingKeys::networkCacheReuseFailureKey):
2329         (WebCore::DiagnosticLoggingKeys::networkKey):
2330         (WebCore::DiagnosticLoggingKeys::networkProcessCrashedKey):
2331         (WebCore::DiagnosticLoggingKeys::neverSeenBeforeKey):
2332         (WebCore::DiagnosticLoggingKeys::noKey):
2333         (WebCore::DiagnosticLoggingKeys::noCacheKey):
2334         (WebCore::DiagnosticLoggingKeys::noStoreKey):
2335         (WebCore::DiagnosticLoggingKeys::nonVisibleStateKey):
2336         (WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
2337         (WebCore::DiagnosticLoggingKeys::pageCacheKey):
2338         (WebCore::DiagnosticLoggingKeys::pageCacheFailureKey):
2339         (WebCore::DiagnosticLoggingKeys::noDocumentLoaderKey):
2340         (WebCore::DiagnosticLoggingKeys::noLongerInCacheKey):
2341         (WebCore::DiagnosticLoggingKeys::otherKey):
2342         (WebCore::DiagnosticLoggingKeys::mainDocumentErrorKey):
2343         (WebCore::DiagnosticLoggingKeys::mainResourceKey):
2344         (WebCore::DiagnosticLoggingKeys::isErrorPageKey):
2345         (WebCore::DiagnosticLoggingKeys::isExpiredKey):
2346         (WebCore::DiagnosticLoggingKeys::isReloadIgnoringCacheDataKey):
2347         (WebCore::DiagnosticLoggingKeys::loadingKey):
2348         (WebCore::DiagnosticLoggingKeys::hasPluginsKey):
2349         (WebCore::DiagnosticLoggingKeys::httpsNoStoreKey):
2350         (WebCore::DiagnosticLoggingKeys::imageKey):
2351         (WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
2352         (WebCore::DiagnosticLoggingKeys::inactiveKey):
2353         (WebCore::DiagnosticLoggingKeys::internalErrorKey):
2354         (WebCore::DiagnosticLoggingKeys::invalidSessionIDKey):
2355         (WebCore::DiagnosticLoggingKeys::isAttachmentKey):
2356         (WebCore::DiagnosticLoggingKeys::isConditionalRequestKey):
2357         (WebCore::DiagnosticLoggingKeys::isDisabledKey):
2358         (WebCore::DiagnosticLoggingKeys::noCurrentHistoryItemKey):
2359         (WebCore::DiagnosticLoggingKeys::quirkRedirectComingKey):
2360         (WebCore::DiagnosticLoggingKeys::rawKey):
2361         (WebCore::DiagnosticLoggingKeys::redirectKey):
2362         (WebCore::DiagnosticLoggingKeys::isLoadingKey):
2363         (WebCore::DiagnosticLoggingKeys::documentLoaderStoppingKey):
2364         (WebCore::DiagnosticLoggingKeys::domainCausingCrashKey):
2365         (WebCore::DiagnosticLoggingKeys::domainCausingEnergyDrainKey):
2366         (WebCore::DiagnosticLoggingKeys::domainCausingJetsamKey):
2367         (WebCore::DiagnosticLoggingKeys::simulatedPageCrashKey):
2368         (WebCore::DiagnosticLoggingKeys::exceededActiveMemoryLimitKey):
2369         (WebCore::DiagnosticLoggingKeys::exceededInactiveMemoryLimitKey):
2370         (WebCore::DiagnosticLoggingKeys::exceededBackgroundCPULimitKey):
2371         (WebCore::DiagnosticLoggingKeys::domainVisitedKey):
2372         (WebCore::DiagnosticLoggingKeys::cannotSuspendActiveDOMObjectsKey):
2373         (WebCore::DiagnosticLoggingKeys::cpuUsageKey):
2374         (WebCore::DiagnosticLoggingKeys::createSharedBufferFailedKey):
2375         (WebCore::DiagnosticLoggingKeys::activeInForegroundTabKey):
2376         (WebCore::DiagnosticLoggingKeys::activeInBackgroundTabOnlyKey):
2377         (WebCore::DiagnosticLoggingKeys::applicationCacheKey):
2378         (WebCore::DiagnosticLoggingKeys::applicationManifestKey):
2379         (WebCore::DiagnosticLoggingKeys::audioKey):
2380         (WebCore::DiagnosticLoggingKeys::backNavigationDeltaKey):
2381         (WebCore::DiagnosticLoggingKeys::canCacheKey):
2382         (WebCore::DiagnosticLoggingKeys::cacheControlNoStoreKey):
2383         (WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
2384         (WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationReasonKey):
2385         (WebCore::DiagnosticLoggingKeys::deniedByClientKey):
2386         (WebCore::DiagnosticLoggingKeys::deviceMotionKey):
2387         (WebCore::DiagnosticLoggingKeys::deviceOrientationKey):
2388         (WebCore::DiagnosticLoggingKeys::diskCacheKey):
2389         (WebCore::DiagnosticLoggingKeys::diskCacheAfterValidationKey):
2390         (WebCore::DiagnosticLoggingKeys::reloadKey):
2391         (WebCore::DiagnosticLoggingKeys::replaceKey):
2392         (WebCore::DiagnosticLoggingKeys::retrievalRequestKey):
2393         (WebCore::DiagnosticLoggingKeys::resourceLoadedKey):
2394         (WebCore::DiagnosticLoggingKeys::resourceResponseSourceKey):
2395         (WebCore::DiagnosticLoggingKeys::retrievalKey):
2396         (WebCore::DiagnosticLoggingKeys::revalidatingKey):
2397         (WebCore::DiagnosticLoggingKeys::reloadFromOriginKey):
2398         (WebCore::DiagnosticLoggingKeys::reloadRevalidatingExpiredKey):
2399         (WebCore::DiagnosticLoggingKeys::sameLoadKey):
2400         (WebCore::DiagnosticLoggingKeys::scriptKey):
2401         (WebCore::DiagnosticLoggingKeys::serviceWorkerKey):
2402         (WebCore::DiagnosticLoggingKeys::streamingMedia):
2403         (WebCore::DiagnosticLoggingKeys::styleSheetKey):
2404         (WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithRevalidationKey):
2405         (WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithoutRevalidationKey):
2406         (WebCore::DiagnosticLoggingKeys::svgDocumentKey):
2407         (WebCore::DiagnosticLoggingKeys::synchronousMessageFailedKey):
2408         (WebCore::DiagnosticLoggingKeys::telemetryPageLoadKey):
2409         (WebCore::DiagnosticLoggingKeys::timedOutKey):
2410         (WebCore::DiagnosticLoggingKeys::canceledLessThan2SecondsKey):
2411         (WebCore::DiagnosticLoggingKeys::canceledLessThan5SecondsKey):
2412         (WebCore::DiagnosticLoggingKeys::canceledLessThan20SecondsKey):
2413         (WebCore::DiagnosticLoggingKeys::canceledMoreThan20SecondsKey):
2414         (WebCore::DiagnosticLoggingKeys::failedLessThan2SecondsKey):
2415         (WebCore::DiagnosticLoggingKeys::failedLessThan5SecondsKey):
2416         (WebCore::DiagnosticLoggingKeys::failedLessThan20SecondsKey):
2417         (WebCore::DiagnosticLoggingKeys::failedMoreThan20SecondsKey):
2418         (WebCore::DiagnosticLoggingKeys::occurredKey):
2419         (WebCore::DiagnosticLoggingKeys::succeededLessThan2SecondsKey):
2420         (WebCore::DiagnosticLoggingKeys::succeededLessThan5SecondsKey):
2421         (WebCore::DiagnosticLoggingKeys::succeededLessThan20SecondsKey):
2422         (WebCore::DiagnosticLoggingKeys::succeededMoreThan20SecondsKey):
2423         (WebCore::DiagnosticLoggingKeys::uncacheableStatusCodeKey):
2424         (WebCore::DiagnosticLoggingKeys::underMemoryPressureKey):
2425         (WebCore::DiagnosticLoggingKeys::unknownEntryRequestKey):
2426         (WebCore::DiagnosticLoggingKeys::unlikelyToReuseKey):
2427         (WebCore::DiagnosticLoggingKeys::unsupportedHTTPMethodKey):
2428         (WebCore::DiagnosticLoggingKeys::unsuspendableDOMObjectKey):
2429         (WebCore::DiagnosticLoggingKeys::unusedKey):
2430         (WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
2431         (WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
2432         (WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
2433         (WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
2434         (WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
2435         (WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
2436         (WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
2437         (WebCore::DiagnosticLoggingKeys::usedKey):
2438         (WebCore::DiagnosticLoggingKeys::userZoomActionKey):
2439         (WebCore::DiagnosticLoggingKeys::varyingHeaderMismatchKey):
2440         (WebCore::DiagnosticLoggingKeys::videoKey):
2441         (WebCore::DiagnosticLoggingKeys::visibleNonActiveStateKey):
2442         (WebCore::DiagnosticLoggingKeys::visibleAndActiveStateKey):
2443         (WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithRevalidationKey):
2444         (WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithoutRevalidationKey):
2445         (WebCore::DiagnosticLoggingKeys::webViewKey):
2446         (WebCore::DiagnosticLoggingKeys::yesKey):
2447         (WebCore::DiagnosticLoggingKeys::expiredKey):
2448         (WebCore::DiagnosticLoggingKeys::fontKey):
2449         (WebCore::DiagnosticLoggingKeys::prunedDueToMemoryPressureKey):
2450         (WebCore::DiagnosticLoggingKeys::prunedDueToMaxSizeReached):
2451         (WebCore::DiagnosticLoggingKeys::prunedDueToProcessSuspended):
2452         (WebCore::WebCore::DiagnosticLoggingKeys::notHTTPFamilyKey):
2453         (WebCore::WebCore::DiagnosticLoggingKeys::webGLStateKey):
2454         (WebCore::DiagnosticLoggingKeys::memoryUsageToDiagnosticLoggingKey):
2455         (WebCore::DiagnosticLoggingKeys::foregroundCPUUsageToDiagnosticLoggingKey):
2456         (WebCore::DiagnosticLoggingKeys::backgroundCPUUsageToDiagnosticLoggingKey):
2457         (WebCore::DiagnosticLoggingKeys::resourceLoadStatisticsTelemetryKey):
2458         * page/DisabledAdaptations.cpp:
2459         (WebCore::watchAdaptationName):
2460         * page/EventHandler.cpp:
2461         (WebCore::EventHandler::handlePasteGlobalSelection):
2462         (WebCore::convertDragOperationToDropZoneOperation):
2463         * page/EventSource.cpp:
2464         (WebCore::EventSource::EventSource):
2465         * page/History.cpp:
2466         (WebCore::History::stateObjectAdded):
2467         * page/NavigatorBase.cpp:
2468         (WebCore::NavigatorBase::appName):
2469         (WebCore::NavigatorBase::appCodeName):
2470         * page/Page.cpp:
2471         (WebCore::Page::logNavigation):
2472         * page/PageDebuggable.cpp:
2473         (WebCore::PageDebuggable::url const):
2474         * page/PageSerializer.cpp:
2475         (WebCore::PageSerializer::serializeCSSStyleSheet):
2476         * page/PerformanceMark.h:
2477         * page/PerformanceMeasure.h:
2478         * page/PerformanceObserver.cpp:
2479         (WebCore::PerformanceObserver::observe):
2480         * page/PerformanceResourceTiming.cpp:
2481         (WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
2482         * page/PerformanceUserTiming.cpp:
2483         (WebCore::restrictedMarkFunction):
2484         * page/PointerLockController.cpp:
2485         (WebCore::PointerLockController::requestPointerLock):
2486         * page/PrintContext.cpp:
2487         (WebCore::PrintContext::pageProperty):
2488         * page/SecurityOrigin.cpp:
2489         (WebCore::SecurityOrigin::toString const):
2490         * page/SecurityOriginData.cpp:
2491         (WebCore::SecurityOriginData::toString const):
2492         (WebCore::SecurityOriginData::databaseIdentifier const):
2493         * page/cocoa/ResourceUsageOverlayCocoa.mm:
2494         (WebCore::gcTimerString):
2495         * page/csp/ContentSecurityPolicy.cpp:
2496         (WebCore::ContentSecurityPolicy::reportViolation const):
2497         (WebCore::ContentSecurityPolicy::reportUnsupportedDirective const):
2498         * page/linux/ResourceUsageOverlayLinux.cpp:
2499         (WebCore::cpuUsageString):
2500         (WebCore::gcTimerString):
2501         * platform/ContentType.cpp:
2502         (WebCore::ContentType::codecsParameter):
2503         (WebCore::ContentType::profilesParameter):
2504         * platform/Decimal.cpp:
2505         (WebCore::Decimal::toString const):
2506         * platform/MIMETypeRegistry.cpp:
2507         (WebCore::initializeSupportedImageMIMETypes):
2508         (WebCore::typesForCommonExtension):
2509         (WebCore::initializeUnsupportedTextMIMETypes):
2510         (WebCore::MIMETypeRegistry::getNormalizedMIMEType):
2511         * platform/SchemeRegistry.cpp:
2512         (WebCore::SchemeRegistry::canServiceWorkersHandleURLScheme):
2513         * platform/URL.cpp:
2514         (WebCore::mimeTypeFromDataURL):
2515         * platform/UserAgentQuirks.cpp:
2516         (WebCore::UserAgentQuirks::stringForQuirk):
2517         * platform/cocoa/KeyEventCocoa.mm:
2518         (WebCore::keyForCharCode):
2519         * platform/cocoa/NetworkExtensionContentFilter.mm:
2520         (WebCore::NetworkExtensionContentFilter::unblockHandler const):
2521         * platform/cocoa/ParentalControlsContentFilter.mm:
2522         (WebCore::ParentalControlsContentFilter::unblockHandler const):
2523         * platform/cocoa/PasteboardCocoa.mm:
2524         (WebCore::Pasteboard::fileContentState):
2525         * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
2526         (WebCore::MacApplication::isSafari):
2527         (WebCore::MacApplication::isAppleMail):
2528         (WebCore::MacApplication::isIBooks):
2529         (WebCore::MacApplication::isITunes):
2530         (WebCore::MacApplication::isMicrosoftMessenger):
2531         (WebCore::MacApplication::isAdobeInstaller):
2532         (WebCore::MacApplication::isAOLInstantMessenger):
2533         (WebCore::MacApplication::isMicrosoftMyDay):
2534         (WebCore::MacApplication::isMicrosoftOutlook):
2535         (WebCore::MacApplication::isQuickenEssentials):
2536         (WebCore::MacApplication::isAperture):
2537         (WebCore::MacApplication::isVersions):
2538         (WebCore::MacApplication::isHRBlock):
2539         (WebCore::MacApplication::isIAdProducer):
2540         (WebCore::MacApplication::isSolidStateNetworksDownloader):
2541         (WebCore::IOSApplication::isMobileMail):
2542         (WebCore::IOSApplication::isMobileSafari):
2543         (WebCore::IOSApplication::isWebBookmarksD):
2544         (WebCore::IOSApplication::isDumpRenderTree):
2545         (WebCore::IOSApplication::isMobileStore):
2546         (WebCore::IOSApplication::isSpringBoard):
2547         (WebCore::IOSApplication::isWebApp):
2548         (WebCore::IOSApplication::isIBooks):
2549         (WebCore::IOSApplication::isIBooksStorytime):
2550         (WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
2551         (WebCore::IOSApplication::isCardiogram):
2552         (WebCore::IOSApplication::isNike):
2553         * platform/cocoa/UserAgentCocoa.mm:
2554         (WebCore::userAgentBundleVersion):
2555         * platform/gamepad/cocoa/GameControllerGamepad.mm:
2556         (WebCore::GameControllerGamepad::setupAsExtendedGamepad):
2557         (WebCore::GameControllerGamepad::setupAsGamepad):
2558         * platform/graphics/InbandTextTrackPrivateClient.h:
2559         (WebCore::GenericCueData::toJSONString const):
2560         * platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
2561         (WebCore::CDMFactoryFairPlayStreaming::supportsKeySystem):
2562         * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
2563         (WebCore::isEqual):
2564         (WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
2565         (WebCore::CDMInstanceFairPlayStreamingAVFObjC::keySystem const):
2566         * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
2567         (WebCore::CDMSessionAVContentKeySession::generateKeyRequest):
2568         * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
2569         (WebCore::CDMSessionAVStreamSession::generateKeyRequest):
2570         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
2571         (WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
2572         * platform/graphics/ca/GraphicsLayerCA.cpp:
2573         (WebCore::propertyIdToString):
2574         * platform/graphics/ca/TileController.cpp:
2575         (WebCore::TileController::tileGridContainerLayerName):
2576         (WebCore::TileController::zoomedOutTileGridContainerLayerName):
2577         * platform/graphics/cg/ImageBufferCG.cpp:
2578         (WebCore::ImageBuffer::toDataURL const):
2579         (WebCore::dataURL):
2580         * platform/graphics/cv/VideoTextureCopierCV.cpp:
2581         (WebCore::VideoTextureCopierCV::initializeContextObjects):
2582         (WebCore::VideoTextureCopierCV::initializeUVContextObjects):
2583         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
2584         (WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
2585         (WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):
2586         * platform/graphics/iso/ISOVTTCue.cpp:
2587         (WebCore::ISOWebVTTCue::toJSONString const):
2588         * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:
2589         (Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):
2590         * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
2591         (WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions):
2592         * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
2593         (WebCore::GraphicsContext3D::getUnmangledInfoLog):
2594         * platform/graphics/texmap/TextureMapperContextAttributes.cpp:
2595         (WebCore::TextureMapperContextAttributes::get):
2596         * platform/graphics/win/ImageBufferDirect2D.cpp:
2597         (WebCore::ImageBuffer::toDataURL const):
2598         (WebCore::ImageDataToDataURL):
2599         * platform/gtk/PasteboardGtk.cpp:
2600         (WebCore::Pasteboard::typesForLegacyUnsafeBindings):
2601         * platform/gtk/PasteboardHelper.cpp:
2602         * platform/gtk/PlatformKeyboardEventGtk.cpp:
2603         (WebCore::PlatformKeyboardEvent::keyValueForGdkKeyCode):
2604         (WebCore::PlatformKeyboardEvent::keyCodeForHardwareKeyCode):
2605         * platform/image-decoders/bmp/BMPImageDecoder.h:
2606         * platform/image-decoders/gif/GIFImageDecoder.h:
2607         * platform/image-decoders/ico/ICOImageDecoder.h:
2608         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
2609         * platform/image-decoders/png/PNGImageDecoder.h:
2610         * platform/image-decoders/webp/WEBPImageDecoder.h:
2611         * platform/ios/Device.cpp:
2612         (WebCore::deviceName):
2613         * platform/ios/PasteboardIOS.mm:
2614         (WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):
2615         * platform/ios/PlatformEventFactoryIOS.mm:
2616         (WebCore::keyForKeyEvent):
2617         (WebCore::codeForKeyEvent):
2618         * platform/ios/PlatformPasteboardIOS.mm:
2619         (WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
2620         * platform/mac/PasteboardMac.mm:
2621         (WebCore::Pasteboard::read):
2622         (WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):
2623         * platform/mac/PlatformEventFactoryMac.mm:
2624         (WebCore::keyForKeyEvent):
2625         (WebCore::codeForKeyEvent):
2626         * platform/mac/PlatformPasteboardMac.mm:
2627         (WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
2628         * platform/mediastream/MediaConstraints.cpp:
2629         (WebCore::addDefaultVideoConstraints):
2630         * platform/mediastream/PeerMediaDescription.h:
2631         * platform/mediastream/RealtimeMediaSource.cpp:
2632         (WebCore::RealtimeMediaSource::applyConstraints):
2633         * platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:
2634         (WebCore::DisplayCaptureManagerCocoa::screenCaptureDeviceWithPersistentID):
2635         * platform/mock/MockRealtimeMediaSource.cpp:
2636         (WebCore::deviceMap):
2637         (WebCore::MockRealtimeMediaSource::audioDevices):
2638         (WebCore::MockRealtimeMediaSource::videoDevices):
2639         (WebCore::MockRealtimeMediaSource::displayDevices):
2640         * platform/mock/MockRealtimeVideoSource.cpp:
2641         (WebCore::MockRealtimeVideoSource::drawText):
2642         * platform/network/BlobRegistryImpl.cpp:
2643         (WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):
2644         * platform/network/DataURLDecoder.cpp:
2645         (WebCore::DataURLDecoder::parseMediaType):
2646         * platform/network/FormData.cpp:
2647         (WebCore::FormData::appendMultiPartFileValue):
2648         * platform/network/HTTPParsers.cpp:
2649         (WebCore::parseHTTPRequestLine):
2650         (WebCore::parseHTTPHeader):
2651         (WebCore::normalizeHTTPMethod):
2652         * platform/network/ResourceRequestBase.cpp:
2653         (WebCore::ResourceRequestBase::redirectedRequest const):
2654         * platform/network/ResourceRequestBase.h:
2655         (WebCore::ResourceRequestBase::ResourceRequestBase):
2656         * platform/network/curl/ResourceHandleCurl.cpp:
2657         (WebCore::ResourceHandle::handleDataURL):
2658         * platform/network/curl/SynchronousLoaderClientCurl.cpp:
2659         (WebCore::SynchronousLoaderClient::platformBadResponseError):
2660         * platform/network/win/DownloadBundleWin.cpp:
2661         (WebCore::DownloadBundle::fileExtension):
2662         * platform/sql/SQLiteDatabase.cpp:
2663         (WebCore::SQLiteDatabase::open):
2664         (WebCore::SQLiteDatabase::setFullsync):
2665         (WebCore::SQLiteDatabase::maximumSize):
2666         (WebCore::SQLiteDatabase::pageSize):
2667         (WebCore::SQLiteDatabase::freeSpaceSize):
2668         (WebCore::SQLiteDatabase::totalSize):
2669         (WebCore::SQLiteDatabase::clearAllTables):
2670         (WebCore::SQLiteDatabase::runVacuumCommand):
2671         (WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
2672         (WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
2673         * platform/sql/SQLiteFileSystem.cpp:
2674         (WebCore::SQLiteFileSystem::deleteDatabaseFile):
2675         * platform/text/LocaleICU.cpp:
2676         (WebCore::LocaleICU::dateFormat):
2677         (WebCore::getFormatForSkeleton):
2678         * platform/text/LocaleNone.cpp:
2679         (WebCore::LocaleNone::dateFormat):
2680         (WebCore::LocaleNone::monthFormat):
2681         (WebCore::LocaleNone::shortMonthFormat):
2682         (WebCore::LocaleNone::timeFormat):
2683         (WebCore::LocaleNone::shortTimeFormat):
2684         (WebCore::LocaleNone::dateTimeFormatWithSeconds):
2685         (WebCore::LocaleNone::dateTimeFormatWithoutSeconds):
2686         * platform/text/LocaleToScriptMappingDefault.cpp:
2687         (WebCore::scriptNameToCode):
2688         (WebCore::localeToScriptCodeForFontSelection):
2689         * platform/text/TextEncodingRegistry.cpp:
2690         (WebCore::defaultTextEncodingNameForSystemLanguage):
2691         * platform/win/FileSystemWin.cpp:
2692         (WebCore::FileSystem::bundleName):
2693         * platform/wpe/RenderThemeWPE.cpp:
2694         (WebCore::RenderThemeWPE::mediaControlsStyleSheet):
2695         * rendering/RenderMenuList.cpp:
2696         (RenderMenuList::setText):
2697         * rendering/RenderThemeIOS.mm:
2698         (WebCore::RenderThemeIOS::extraDefaultStyleSheet):
2699         * svg/SVGComponentTransferFunctionElement.h:
2700         (WebCore::SVGPropertyTraits<ComponentTransferType>::toString):
2701         * svg/SVGFEColorMatrixElement.h:
2702         (WebCore::SVGPropertyTraits<ColorMatrixType>::toString):
2703         * svg/SVGFECompositeElement.h:
2704         (WebCore::SVGPropertyTraits<CompositeOperationType>::toString):
2705         * svg/SVGFEConvolveMatrixElement.h:
2706         (WebCore::SVGPropertyTraits<EdgeModeType>::toString):
2707         * svg/SVGFEDisplacementMapElement.h:
2708         (WebCore::SVGPropertyTraits<ChannelSelectorType>::toString):
2709         * svg/SVGFEMorphologyElement.h:
2710         (WebCore::SVGPropertyTraits<MorphologyOperatorType>::toString):
2711         * svg/SVGFETurbulenceElement.h:
2712         (WebCore::SVGPropertyTraits<SVGStitchOptions>::toString):
2713         (WebCore::SVGPropertyTraits<TurbulenceType>::toString):
2714         * svg/SVGGradientElement.h:
2715         (WebCore::SVGPropertyTraits<SVGSpreadMethodType>::toString):
2716         * svg/SVGLocatable.cpp:
2717         (WebCore::SVGLocatable::getTransformToElement):
2718         * svg/SVGMarkerTypes.h:
2719         (WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::toString):
2720         * svg/SVGMatrixValue.h:
2721         * svg/SVGSVGElement.cpp:
2722         (WebCore::SVGSVGElement::SVGSVGElement):
2723         (WebCore::SVGSVGElement::parseAttribute):
2724         * svg/SVGTextContentElement.h:
2725         (WebCore::SVGPropertyTraits<SVGLengthAdjustType>::toString):
2726         * svg/SVGTextPathElement.h:
2727         (WebCore::SVGPropertyTraits<SVGTextPathMethodType>::toString):
2728         (WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::toString):
2729         * svg/SVGToOTFFontConversion.cpp:
2730         (WebCore::SVGToOTFFontConverter::appendCFFTable):
2731         * svg/SVGUnitTypes.h:
2732         (WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::toString):
2733         * svg/SVGUseElement.cpp:
2734         (WebCore::SVGUseElement::toClipPath):
2735         * svg/graphics/SVGImage.cpp:
2736         (WebCore::SVGImage::filenameExtension const):
2737         * testing/InternalSettings.cpp:
2738         (WebCore::InternalSettings::userInterfaceDirectionPolicy):
2739         (WebCore::InternalSettings::systemLayoutDirection):
2740         * testing/Internals.cpp:
2741         (WebCore::Internals::areSVGAnimationsPaused const):
2742         (WebCore::Internals::accessKeyModifiers const):
2743         (WebCore::Internals::setMediaDeviceState):
2744         (WebCore::Internals::audioSessionCategory const):
2745         (WebCore::Internals::systemPreviewRelType):
2746         * testing/MockCDMFactory.cpp:
2747         (WebCore::MockCDM::sanitizeResponse const):
2748         (WebCore::MockCDMInstance::updateLicense):
2749         * testing/MockContentFilter.cpp:
2750         (WebCore::MockContentFilter::unblockRequestDeniedScript const):
2751         * testing/MockCredentialsMessenger.cpp:
2752         (WebCore::MockCredentialsMessenger::~MockCredentialsMessenger):
2753         (WebCore::MockCredentialsMessenger::makeCredential):
2754         (WebCore::MockCredentialsMessenger::getAssertion):
2755         * testing/MockPaymentCoordinator.cpp:
2756         (WebCore::MockPaymentCoordinator::showPaymentUI):
2757         * workers/WorkerRunLoop.cpp:
2758         (WebCore::WorkerRunLoop::debuggerMode):
2759         * workers/WorkerScriptLoader.cpp:
2760         (WebCore::WorkerScriptLoader::loadSynchronously):
2761         (WebCore::WorkerScriptLoader::createResourceRequest):
2762         (WebCore::WorkerScriptLoader::didReceiveData):
2763         * workers/service/ExtendableEvent.cpp:
2764         (WebCore::ExtendableEvent::waitUntil):
2765         * workers/service/FetchEvent.cpp:
2766         (WebCore::FetchEvent::~FetchEvent):
2767         (WebCore::FetchEvent::respondWith):
2768         (WebCore::FetchEvent::promiseIsSettled):
2769         * workers/service/SWClientConnection.cpp:
2770         (WebCore::SWClientConnection::clearPendingJobs):
2771         * workers/service/ServiceWorker.cpp:
2772         (WebCore::ServiceWorker::postMessage):
2773         * workers/service/ServiceWorkerClients.cpp:
2774         (WebCore::ServiceWorkerClients::openWindow):
2775         (WebCore::ServiceWorkerClients::claim):
2776         * workers/service/ServiceWorkerContainer.cpp:
2777         (WebCore::ServiceWorkerContainer::addRegistration):
2778         (WebCore::ServiceWorkerContainer::getRegistration):
2779         (WebCore::ServiceWorkerContainer::startScriptFetchForJob):
2780         * workers/service/ServiceWorkerJob.cpp:
2781         (WebCore::ServiceWorkerJob::fetchScriptWithContext):
2782         (WebCore::ServiceWorkerJob::didReceiveResponse):
2783         * workers/service/ServiceWorkerRegistration.cpp:
2784         (WebCore::ServiceWorkerRegistration::update):
2785         * workers/service/ServiceWorkerWindowClient.cpp:
2786         (WebCore::ServiceWorkerWindowClient::focus):
2787         (WebCore::ServiceWorkerWindowClient::navigate):
2788         * workers/service/context/ServiceWorkerDebuggable.h:
2789         * workers/service/context/ServiceWorkerFetch.cpp:
2790         (WebCore::ServiceWorkerFetch::dispatchFetchEvent):
2791         * workers/service/server/RegistrationDatabase.cpp:
2792         (WebCore::RegistrationDatabase::doPushChanges):
2793         (WebCore::RegistrationDatabase::importRecords):
2794         * workers/service/server/SWServerJobQueue.cpp:
2795         (WebCore::SWServerJobQueue::runRegisterJob):
2796         (WebCore::SWServerJobQueue::runUnregisterJob):
2797         (WebCore::SWServerJobQueue::runUpdateJob):
2798         * xml/XMLErrors.cpp:
2799         (WebCore::createXHTMLParserErrorHeader):
2800         (WebCore::XMLErrors::insertErrorMessageBlock):
2801         * xml/XMLHttpRequest.cpp:
2802         (WebCore::XMLHttpRequest::send):
2803         (WebCore::XMLHttpRequest::responseMIMEType const):
2804         * xml/XMLTreeViewer.cpp:
2805         (WebCore::XMLTreeViewer::transformDocumentToTreeView):
2806         * xml/XPathPredicate.cpp:
2807         (WebCore::XPath::evaluatePredicate):
2808         * xml/XPathValue.cpp:
2809         (WebCore::XPath::Value::toString const):
2810         * xml/parser/CharacterReferenceParserInlines.h:
2811         (WebCore::consumeCharacterReference):
2812
2813 2018-06-22  Youenn Fablet  <youenn@apple.com>
2814
2815         Disable WebSocket in WatchOS
2816         https://bugs.webkit.org/show_bug.cgi?id=186931
2817         <rdar://problem/39584458>
2818
2819         Reviewed by Wenson Hsieh.
2820
2821         Add a runtime flag to enable/disable WebSocket.
2822         By default, flag is on for all platforms except for WatchOS.
2823
2824         Test: fast/dom/Window/watchos/websocket/watchos/no-websocket-in-watchos.html
2825
2826         * Modules/websockets/WebSocket.idl:
2827         * page/RuntimeEnabledFeatures.cpp:
2828         (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
2829         * page/RuntimeEnabledFeatures.h:
2830         (WebCore::RuntimeEnabledFeatures::setWebSocketEnabled):
2831         (WebCore::RuntimeEnabledFeatures::webSocketEnabled const):
2832
2833 2018-06-22  Woodrow Wang  <woodrow_wang@apple.com>
2834
2835         SubresourceLoader::didFail() should only log message if state is Initialized
2836         https://bugs.webkit.org/show_bug.cgi?id=185124
2837
2838         Reviewed by Daniel Bates.
2839
2840         Functionality does not change. Moved console logging to be 
2841         after checking state of subresource loader. We only need to 
2842         log if the state is initialized. This is consistent with other
2843         functions in the file. We can also remove a null check for the 
2844         frame pointer (m_frame). The superclass ResourceLoader constructor
2845         takes an lvalue reference and initializes m_frame, ensuring
2846         m_frame cannot be null. It is only set to null by 
2847         ResourceLoader::releaseResources(), which is only called after the 
2848         resource finishes loading or fails to load. Thus, in didFail(), 
2849         m_frame must be non-null when we're logging and up until the end of the function.  
2850
2851         * loader/SubresourceLoader.cpp:
2852         (WebCore::SubresourceLoader::didFail):
2853
2854 2018-06-22  Timothy Hatcher  <timothy@apple.com>
2855
2856         Corner of two scroll bars is white with dark mode enabled.
2857         https://bugs.webkit.org/show_bug.cgi?id=186819
2858         rdar://problem/40434350
2859
2860         Reviewed by Tim Horton.
2861
2862         * Configurations/WebCore.xcconfig:
2863         * WebCore.xcodeproj/project.pbxproj:
2864         * inspector/InspectorOverlay.cpp:
2865         (WebCore::InspectorOverlay::paint): Added LocalDefaultSystemAppearance.
2866         * page/Page.h:
2867         * platform/ScrollView.cpp:
2868         (WebCore::ScrollView::paintScrollCorner): Dropped ScrollView argument.
2869         * platform/ScrollbarTheme.h:
2870         (WebCore::ScrollbarTheme::paintScrollCorner): Ditto.
2871         * platform/ScrollbarThemeComposite.cpp:
2872         (WebCore::ScrollbarThemeComposite::paintScrollCorner): Deleted. Default is the same.
2873         * platform/ScrollbarThemeComposite.h:
2874         * platform/mac/LocalDefaultSystemAppearance.h:
2875         * platform/mac/LocalDefaultSystemAppearance.mm:
2876         (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Added recursion early return.
2877         (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): Ditto.
2878         * platform/mac/ScrollbarThemeMac.h:
2879         * platform/mac/ScrollbarThemeMac.mm:
2880         (WebCore::ScrollbarThemeMac::paintScrollCorner): Added.
2881         * rendering/RenderLayer.cpp:
2882         (WebCore::RenderLayer::paintScrollCorner): Call ScrollbarTheme::paintScrollCorner.
2883         * rendering/RenderLayerBacking.cpp:
2884         (WebCore::RenderLayerBacking::paintContents): Added LocalDefaultSystemAppearance.
2885         * rendering/RenderLayerCompositor.cpp:
2886         (WebCore::RenderLayerCompositor::paintContents): Added LocalDefaultSystemAppearance.
2887         * rendering/RenderScrollbarTheme.cpp:
2888         (WebCore::RenderScrollbarTheme::paintScrollCorner): Call ScrollbarTheme::paintScrollCorner.
2889         * rendering/RenderScrollbarTheme.h:
2890         * svg/graphics/SVGImage.cpp:
2891         (WebCore::SVGImage::draw): Added LocalDefaultSystemAppearance.
2892
2893 2018-06-22  Tim Horton  <timothy_horton@apple.com>
2894
2895         Make it possible to add a border around loading or failed-to-load images
2896         https://bugs.webkit.org/show_bug.cgi?id=186614
2897         <rdar://problem/39050152>
2898
2899         Reviewed by Zalan Bujtas.
2900
2901         Tests: http/tests/images/loading-image-border.html
2902                http/tests/images/loading-image-no-border.html
2903
2904         * rendering/RenderImage.cpp:
2905         (WebCore::RenderImage::paintIncompleteImageOutline):
2906         (WebCore::RenderImage::paintReplaced):
2907         * rendering/RenderImage.h:
2908         Factor the missing-image outline out, and - if desired - paint it in
2909         cases where the image is still loading or otherwise pending, not just
2910         when the image fails to load.
2911
2912         * page/Settings.yaml:
2913         * testing/InternalSettings.cpp:
2914         (WebCore::InternalSettings::Backup::Backup):
2915         (WebCore::InternalSettings::Backup::restoreTo):
2916         (WebCore::InternalSettings::setIncompleteImageBorderEnabled):
2917         * testing/InternalSettings.h:
2918         * testing/InternalSettings.idl:
2919         Add and expose a setting to enable the feature.
2920
2921 2018-06-22  Brady Eidson  <beidson@apple.com>
2922
2923         WKURLSchemeHandler doesn't handle sync XHR.
2924         <rdar://problem/40955884> and https://bugs.webkit.org/show_bug.cgi?id=186902
2925
2926         Reviewed by Chris Dumez.
2927
2928         * English.lproj/Localizable.strings:
2929
2930 2018-06-22  Jer Noble  <jer.noble@apple.com>
2931
2932         [Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit fullscreen handler after r231924
2933         https://bugs.webkit.org/show_bug.cgi?id=186945
2934         <rdar://problem/37277469>
2935
2936         Reviewed by Simon Fraser.
2937
2938         * platform/ios/VideoFullscreenInterfaceAVKit.mm:
2939         (VideoFullscreenInterfaceAVKit::exitFullscreen):
2940         (VideoFullscreenInterfaceAVKit::exitFullscreenHandler):
2941         (VideoFullscreenInterfaceAVKit::cleanupFullscreen):
2942
2943 2018-06-22  Per Arne Vollan  <pvollan@apple.com>
2944
2945         Unreviewed build fix on Windows.
2946
2947         * testing/Internals.h:
2948
2949 2018-06-22  Youenn Fablet  <youenn@apple.com>
2950
2951         Incoming G722 doesn't work
2952         https://bugs.webkit.org/show_bug.cgi?id=186307
2953         <rdar://problem/40809745>
2954
2955         Reviewed by Eric Carlson.
2956
2957         WebRTC backends usually does the following:
2958         - Initially call RealtimeIncomingAudioSource with 16KHz data
2959         - Switch to 48KHz when actual data is decoded.
2960         We added a check that was discarding any 16KHz data, but in case of G722, the data remains as 16KHz and is then never read.
2961         The solution is to remove the check that discards 16KHz information.
2962         We then need to fix a bug in AudioTrackPrivateMediaStreamCocoa that was preventing proper handling of change of audio data configuration.
2963
2964         Test: webrtc/audio-peer-connection-g722.html
2965
2966         * platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
2967         (WebCore::AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable):
2968         * platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:
2969         (WebCore::RealtimeIncomingAudioSourceCocoa::OnData):
2970
2971 2018-06-22  Timothy Hatcher  <timothy@apple.com>
2972
2973         Recalc styles every time defaultAppearance changes.
2974         https://bugs.webkit.org/show_bug.cgi?id=186866
2975         rdar://problem/41309805
2976
2977         Reviewed by Tim Horton.
2978
2979         * page/Page.cpp:
2980         (WebCore::Page::setUseSystemAppearance): Added. Recalc styles and update system colors.
2981         (WebCore::Page::setDefaultAppearance): Added. Ditto.
2982         * page/Page.h:
2983         (WebCore::Page::setUseSystemAppearance): Deleted impl.
2984         (WebCore::Page::setDefaultAppearance): Deleted impl.
2985
2986 2018-06-22  Thibault Saunier  <tsaunier@igalia.com>
2987
2988         [GStreamer] Avoid sending SELECT_STREAM events when nothing changed
2989         https://bugs.webkit.org/show_bug.cgi?id=186678
2990
2991         Reviewed by Philippe Normand.
2992
2993         This avoid extra work in decodebin3 and should work around a crash
2994         in decodebin3 when we send spurious SELECT_STREAM in the mediastream
2995         layout tests.
2996
2997         GStreamer was also missing safe guards in the GstStream APIs which have been
2998         added in gstreamer core in 8833ca942ea21c58c0f63822f0e2b61695b39447
2999         "stream: Add some missing API safe guards".
3000
3001         Should fix following flakes:
3002           - fast/mediastream/MediaStream-video-element-track-stop.html
3003           - fast/mediastream/change-tracks-media-stream-being-played.html
3004
3005         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3006         (WebCore::MediaPlayerPrivateGStreamer::enableTrack):
3007
3008 2018-06-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3009
3010         REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
3011         https://bugs.webkit.org/show_bug.cgi?id=186206
3012
3013         Unreviewed manual rollout of r230950
3014
3015         * platform/graphics/texmap/TextureMapperLayer.h:
3016         * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
3017         (WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
3018
3019 2018-06-20  Darin Adler  <darin@apple.com>
3020
3021         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3022         https://bugs.webkit.org/show_bug.cgi?id=186875
3023
3024         Reviewed by Anders Carlsson.
3025
3026         * platform/cocoa/ThemeCocoa.mm:
3027         (WebCore::passKitBundle): Use isDirectory:YES when creating a URL pointing to a framework,
3028         since frameworks are directories.
3029
3030 2018-06-22  Miguel Gomez  <magomez@igalia.com>
3031
3032         [WPE][ThreadedRendering] WPE crashes rendering SVG content when using ThreadedRendering
3033         https://bugs.webkit.org/show_bug.cgi?id=186914
3034
3035         Reviewed by Carlos Garcia Campos.
3036
3037         Add GraphicsContextImpl::clipToImageBuffer() to the interface and the implementors. Forward
3038         the call to GraphicsContext::clipToImageBuffer() to the implementation if possible in the
3039         cairo case.
3040
3041         Covered by existent tests.
3042
3043         * platform/graphics/GraphicsContextImpl.h:
3044         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3045         (WebCore::GraphicsContext::clipToImageBuffer):
3046         * platform/graphics/cairo/GraphicsContextImplCairo.cpp:
3047         (WebCore::GraphicsContextImplCairo::clipToImageBuffer):
3048         * platform/graphics/cairo/GraphicsContextImplCairo.h:
3049         * platform/graphics/displaylists/DisplayListRecorder.cpp:
3050         (WebCore::DisplayList::Recorder::clipToImageBuffer):
3051         * platform/graphics/displaylists/DisplayListRecorder.h:
3052         * platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
3053         (Nicosia::CairoOperationRecorder::clipToImageBuffer):
3054         * platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
3055
3056 2018-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3057
3058         [CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
3059         https://bugs.webkit.org/show_bug.cgi?id=186911
3060
3061         Reviewed by Michael Catanzaro.
3062
3063         This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
3064         didn't start a clean build. The problem is that the CMake command to generate
3065         SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
3066         SelectorPseudoClassAndCompatibilityElementMap.in.
3067
3068         * CMakeLists.txt:
3069
3070 2018-06-22  Miguel Gomez  <magomez@igalia.com>
3071
3072         [WPE][ThreadedRendering] WPE crashes rendering some pieces of text when using ThreadedRendering
3073         https://bugs.webkit.org/show_bug.cgi?id=186886
3074
3075         Reviewed by Žan Doberšek.
3076
3077         Modify DisplayList DrawGlyphs element to use a GraphicsContext for replaying. To do so, modify
3078         GraphicsContext::drawGlyphs() API so it doesn't require a FontCascade, and update all the calls
3079         to it.
3080
3081         Covered by existent tests.
3082
3083         * platform/graphics/FontCascade.cpp:
3084         (WebCore::FontCascade::drawGlyphBuffer const):
3085         * platform/graphics/GraphicsContext.cpp:
3086         (WebCore::GraphicsContext::drawGlyphs):
3087         * platform/graphics/GraphicsContext.h:
3088         * platform/graphics/displaylists/DisplayListItems.cpp:
3089         (WebCore::DisplayList::DrawGlyphs::apply const):
3090         * rendering/mathml/MathOperator.cpp:
3091         (WebCore::MathOperator::paintGlyph):
3092         (WebCore::MathOperator::paint):
3093         * rendering/mathml/RenderMathMLToken.cpp:
3094         (WebCore::RenderMathMLToken::paint):
3095
3096 2018-06-15  Jer Noble  <jer.noble@apple.com>
3097
3098         Address fullscreen api CSS env feedback
3099         https://bugs.webkit.org/show_bug.cgi?id=186684
3100
3101         Reviewed by Simon Fraser.
3102
3103         Test: fullscreen/fullscreen-env.html
3104
3105         + Update the phishing alert text to be more explicit about the specific threats
3106           phishing sites represent.
3107         + Make the top inset static, rather than dynamic.
3108         + Add bottom, left, and right insets for completeness.
3109         + Set the fullscreen animation duration as well as delay.
3110         + Notify the page when the controls show and hide.
3111
3112         * English.lproj/Localizable.strings:
3113         * css/CSSSelector.cpp:
3114         (WebCore::CSSSelector::selectorText const):
3115         * css/CSSSelector.h:
3116         * css/SelectorChecker.cpp:
3117         (WebCore::SelectorChecker::checkOne const):
3118         * css/SelectorCheckerTestFunctions.h:
3119         (WebCore::matchesFullScreenControlsHiddenPseudoClass):
3120         * css/SelectorPseudoClassAndCompatibilityElementMap.in:
3121         * cssjit/SelectorCompiler.cpp:
3122         (WebCore::SelectorCompiler::addPseudoClassType):
3123         * dom/ConstantPropertyMap.cpp:
3124         (WebCore::ConstantPropertyMap::nameForProperty const):
3125         (WebCore::ConstantPropertyMap::updateConstantsForFullscreenInsets):
3126         (WebCore::ConstantPropertyMap::didChangeFullscreenInsets):
3127         (WebCore::ConstantPropertyMap::setFullscreenAutoHideDuration):
3128         (WebCore::ConstantPropertyMap::setFullscreenInsetTop): Deleted.
3129         * dom/ConstantPropertyMap.h:
3130         * dom/Document.cpp:
3131         (WebCore::Document::areFullscreenControlsHidden const):
3132         (WebCore::Document::setFullscreenControlsHidden):
3133         * dom/Document.h:
3134         * page/Page.cpp:
3135         (WebCore::Page::setFullscreenInsets):
3136         (WebCore::Page::setFullscreenAutoHideDuration):
3137         (WebCore::Page::setFullscreenControlsHidden):
3138         (WebCore::Page::setFullscreenInsetTop): Deleted.
3139         * page/Page.h:
3140         (WebCore::Page::fullscreenInsets const):
3141         * testing/Internals.cpp:
3142         (WebCore::Internals::resetToConsistentState):
3143         (WebCore::Internals::setFullscreenInsets):
3144         (WebCore::Internals::setFullscreenAutoHideDuration):
3145         (WebCore::Internals::setFullscreenControlsHidden):
3146         (WebCore::Internals::setFullscreenInsetTop): Deleted.
3147         * testing/Internals.h:
3148         * testing/Internals.idl:
3149
3150 2018-06-21  Jer Noble  <jer.noble@apple.com>
3151
3152         [Fullscreen] Page sometimes ends up with an incorrect zoom level after entering fullscreen
3153         https://bugs.webkit.org/show_bug.cgi?id=186822
3154
3155         Reviewed by Simon Fraser.
3156
3157         * dom/Document.cpp:
3158         (WebCore::Document::setOverrideViewportArguments):
3159         (WebCore::Document::updateViewportArguments):
3160         * dom/Document.h:
3161
3162 2018-06-20  Said Abou-Hallawa  <sabouhallawa@apple.com>
3163
3164         RenderSVGInline has to be inline always regardless of its css display value
3165         https://bugs.webkit.org/show_bug.cgi?id=186656
3166
3167         Reviewed by Zalan Bujtas.
3168
3169         According to https://www.w3.org/TR/SVG2/text.html#TextLayout, the <text>
3170         element has to be laid out as if it were a block element and any <tspan>,
3171         <textPath>, <a> and <tref> descendants were inline elements.
3172
3173         If a css rule, which contains the property "display: block;", is applied
3174         to any of children of a <text> element, this property has to be ignored.
3175
3176         We currently ignore this property in RenderSVGInline::updateFromStyle()
3177         by forcing setInline(true). But we do not do the same thing in 
3178         RenderTreeBuilder::normalizeTreeAfterStyleChange(). In fact we allow
3179         making the children of the <text> element to be non-inline. This puts
3180         the render tree in weired state and causes many assertions to fire while
3181         laying out RenderSVGText. 
3182
3183         Test: svg/dom/svg-inline-text-display-block-crash.html
3184
3185         * rendering/updating/RenderTreeBuilder.cpp:
3186         (WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange):
3187
3188 2018-06-20  Zalan Bujtas  <zalan@apple.com>
3189
3190         Do not reuse generated inline renderer for the first letter.
3191         https://bugs.webkit.org/show_bug.cgi?id=186657
3192         <rdar://problem/41157892>
3193
3194         Reviewed by Simon Fraser.
3195
3196         When the first letter pseudo element is present, we construct a dedicated subtree for its content like this:
3197
3198         <div><span>foobar</span></div> -> with ::first-letter on the <div>
3199         DIV RenderBlock
3200             SPAN RenderInline
3201                 RenderInline (generated wrapper for the first letter content)
3202                     RenderText (fist letter content)
3203                 RenderText (remaining text content)
3204
3205         "display: contents" on the <span> forces us not to construct a RenderInline for the <span> (or just come up with a wrapper at best).
3206         FirstLetter::createRenderers logic needs to check for such cases and pick the correct parent for the first letter subtree accordingly.
3207
3208         Test: fast/text/first-letter-with-display-contents-crash.html
3209               imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html is not crashing anymore either.
3210
3211         * rendering/updating/RenderTreeBuilderFirstLetter.cpp:
3212         (WebCore::RenderTreeBuilder::FirstLetter::createRenderers):
3213
3214 2018-06-21  Chris Dumez  <cdumez@apple.com>
3215
3216         JSPerformanceObserverCallback creates a GC strongly-referenced Function that is never cleaned up
3217         https://bugs.webkit.org/show_bug.cgi?id=186873
3218         <rdar://problem/41271574>
3219
3220         Reviewed by Simon Fraser.
3221
3222         Add [IsWeakCallback] to PerformanceObserverCallback interface so that the generated
3223         JSPerformanceObserverCallback uses a JSC::Weak instead of a JSC::Strong to store the
3224         js function. To keep the function alive, add [JSCustomMarkFunction] to PerformanceObserver
3225         interface and have its visitAdditionalChildren() visit the callback's js function.
3226         Finally, because we want the callback to still be called even if the JS does not keep
3227         the PerformanceObserver wrapper alive, add [CustomIsReachable] to PerformanceObserver
3228         interface and have its isReachableFromOpaqueRoots() return true if the observer is
3229         registered (i.e. it may need to call the callback in the future).
3230
3231         I have confirmed locally, that the Performance / PerformanceObserver / Document
3232         objects properly get destroyed if I navigate away from a page that had a performance
3233         observer and trigger a memory pressure warning. Also,
3234         `notifyutil -p com.apple.WebKit.showAllDocuments` no longer shows the old document.
3235
3236         Tests: performance-api/performance-observer-callback-after-gc.html
3237                performance-api/performance-observer-no-document-leak.html
3238
3239         * Sources.txt:
3240         * WebCore.xcodeproj/project.pbxproj:
3241         * bindings/js/JSPerformanceObserverCustom.cpp: Added.
3242         (WebCore::JSPerformanceObserver::visitAdditionalChildren):
3243         (WebCore::JSPerformanceObserverOwner::isReachableFromOpaqueRoots):
3244         * bindings/js/ScriptController.cpp:
3245         * page/PerformanceObserver.cpp:
3246         (WebCore::PerformanceObserver::disassociate):
3247         * page/PerformanceObserver.h:
3248         (WebCore::PerformanceObserver::isRegistered const):
3249         (WebCore::PerformanceObserver::callback):
3250         * page/PerformanceObserver.idl:
3251         * page/PerformanceObserverCallback.h:
3252         * page/PerformanceObserverCallback.idl:
3253
3254 2018-06-20  Antoine Quint  <graouts@apple.com>
3255
3256         [Web Animations] Make imported/mozilla/css-animations/test_animation-ready.html pass reliably
3257         https://bugs.webkit.org/show_bug.cgi?id=183830
3258         <rdar://problem/40997539>
3259
3260         Reviewed by Dean Jackson.
3261
3262         The CSS Animations Level 2 spec explains how the Web Animations API and CSS Animations interact and requires
3263         pending styles changes on the target element of a CSS Animation to be flushed when using a Web Animations API
3264         on it in order to ensure that any animation- CSS property is accounted for.
3265
3266         * animation/CSSAnimation.cpp:
3267         (WebCore::CSSAnimation::bindingsStartTime const):
3268         (WebCore::CSSAnimation::setBindingsStartTime):
3269         (WebCore::CSSAnimation::bindingsCurrentTime const):
3270         (WebCore::CSSAnimation::setBindingsCurrentTime):
3271         (WebCore::CSSAnimation::bindingsPlayState const):
3272         (WebCore::CSSAnimation::bindingsPending const):
3273         (WebCore::CSSAnimation::bindingsReady):
3274         (WebCore::CSSAnimation::bindingsFinished):
3275         (WebCore::CSSAnimation::bindingsPlay):
3276         (WebCore::CSSAnimation::bindingsPause):
3277         (WebCore::CSSAnimation::flushPendingStyleChanges const):
3278         * animation/CSSAnimation.h:
3279         * animation/WebAnimation.h:
3280         (WebCore::WebAnimation::bindingsPlayState const):
3281         (WebCore::WebAnimation::bindingsPending const):
3282         (WebCore::WebAnimation::bindingsReady):
3283         (WebCore::WebAnimation::bindingsFinished):
3284         (WebCore::WebAnimation::bindingsPlay):
3285         (WebCore::WebAnimation::bindingsPause):
3286         * animation/WebAnimation.idl:
3287
3288 2018-06-21  Jer Noble  <jer.noble@apple.com>
3289
3290         [Fullscreen] Suspend page (and pause video) while phishing warning is presented
3291         https://bugs.webkit.org/show_bug.cgi?id=186856
3292         <rdar://problem/41212444>
3293
3294         Reviewed by Tim Horton.
3295
3296         Pause the media element when the page is suspended, and unpause when the page resumes.
3297
3298         * html/HTMLMediaElement.cpp:
3299         (WebCore::HTMLMediaElement::HTMLMediaElement):
3300         (WebCore::HTMLMediaElement::suspend):
3301         (WebCore::HTMLMediaElement::resume):
3302         * html/HTMLMediaElement.h:
3303
3304 2018-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3305
3306         Bad optional access in WebCore::ContentSecurityPolicySource::portMatches
3307         https://bugs.webkit.org/show_bug.cgi?id=186535
3308
3309         Reviewed by Daniel Bates.
3310
3311         Make sure the ports have explicit values before dereferencing them.
3312
3313         This is hard to test. If the layout test script-src-parsing-implicit-and-explicit-port-number
3314         continues to pass for WebKitLegacy, then I have at least probably not broken anything. To
3315         reproduce the crash in a layout test that I can run, I think I would need to implement
3316         internals.registerDefaultPortForProtocol for modern WebKit, which is too much work for this
3317         crash. Otherwise, we'd need to run the test server on port 80, which would be unfriendly.
3318
3319         * page/csp/ContentSecurityPolicySource.cpp:
3320         (WebCore::ContentSecurityPolicySource::portMatches const):
3321
3322 2018-06-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3323
3324         [GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add
3325         https://bugs.webkit.org/show_bug.cgi?id=186880
3326
3327         Reviewed by Xabier Rodriguez-Calvar.
3328
3329         Bug 180253 has added assertions the arugments `start` and `end` is
3330         valid MediaTime in PlatformTimeRanges::add. Since then, some
3331         LayoutTests fail due to the assertion failure.
3332
3333         The invalid MediaTime is added into the PlatformTimeRanges in
3334         MediaPlayerPrivateGStreamer::buffered. Before adding MediaTime,
3335         original implementation checks MediaTime::operator bool() returns
3336         true. But, this method returns true if the time value is invalid.
3337         Then, PlatformTimeRanges::add is called with an invalid MediaTime.
3338
3339         No new tests (No behavior change).
3340
3341         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3342         (WebCore::MediaPlayerPrivateGStreamer::buffered const): Check
3343         maxTimeLoaded() is valid before adding to `timeRanges`.
3344
3345 2018-06-20  David Kilzer  <ddkilzer@apple.com>
3346
3347         Fix leaks in WebCore found by clang static analyzer in deep mode
3348         <https://webkit.org/b/186865>
3349
3350         Reviewed by Joseph Pecoraro.
3351
3352         * platform/mac/WebCoreNSURLExtras.mm:
3353         (WebCore::mapHostNames): Fix leak of an empty NSMutableArray
3354         during an early return.  RetainPtr<> is not used here since
3355         a pointer to the NSMutableArray * is passed around.
3356         * platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:
3357         (WebCore::ScreenDisplayCaptureSourceMac::createDisplayStream):
3358         Fix leak of a CGDisplayModeRef during an early return.
3359
3360 2018-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3361
3362         Unreviewed, fix the watchOS build after r233016.
3363
3364         * page/EventHandler.cpp:
3365         (WebCore::EventHandler::selectionExtentRespectingEditingBoundary):
3366
3367         Move this helper out of the ENABLE(DRAG_SUPPORT) guard.
3368
3369         * page/EventHandler.h:
3370
3371 2018-06-20  Simon Fraser  <simon.fraser@apple.com>
3372
3373         AnimationList wastes 60KB of vector capacity
3374         https://bugs.webkit.org/show_bug.cgi?id=186701
3375
3376         Reviewed by Chris Dumez.
3377
3378         AnimationList was the second most wasteful call site for Vector capacity on theverge.com,
3379         wasting almost 60KB. Lists had between 1 and 3 entries, so give AnimationList's vector of
3380         Animations a min capacity of zero so it doesn't grow in increments of 16.
3381         
3382         Also shrink Animation from 88 bytes to 72 bytes by optimizing packing.
3383
3384         * platform/animation/Animation.cpp:
3385         (WebCore::Animation::Animation):
3386         (WebCore::Animation::operator=):
3387         (WebCore::Animation::animationsMatch const):
3388         * platform/animation/Animation.h:
3389         (WebCore::Animation::animationMode const):
3390         (WebCore::Animation::setAnimationMode):
3391         * platform/animation/AnimationList.h:
3392
3393 2018-06-20  Simon Fraser  <simon.fraser@apple.com>
3394
3395         ContentSecurityPolicySourceList wastes 51KB of Vector capacity on cnn.com
3396         https://bugs.webkit.org/show_bug.cgi?id=186706
3397
3398         Reviewed by Chris Dumez.