[GTK] Add Since tags to GObject DOM bindings documentation
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Add Since tags to GObject DOM bindings documentation
4         https://bugs.webkit.org/show_bug.cgi?id=139356
5
6         Reviewed by Gustavo Noronha Silva.
7
8         Now that we have a small stable API, and new symbols are added
9         manually, we can also add the version to the symbols file, that
10         the code generator can ue to add Since tags to the gtk-doc.
11
12         * bindings/gobject/webkitdom.symbols: Add @2.8 to the new symbols
13         added for 2.8.
14         * bindings/scripts/CodeGeneratorGObject.pm:
15         (GenerateConstants): Add Since tag to gtk-doc if there's a version
16         number for the symbol in the .symbols file.
17         (GenerateFunction): Ditto.
18         (ReadStableSymbols):
19
20 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
21
22         [GTK] Missing API detected in GObject DOM bindings after r176630
23         https://bugs.webkit.org/show_bug.cgi?id=139201
24
25         Reviewed by Gustavo Noronha Silva.
26
27         Bring back WebKitDOMDeprecated and add custom versions of the
28         removed symbols as deprecated in favor of the new ones. Also add
29         the new ones as stable API.
30
31         * CMakeLists.txt: Pass a list of additional dependencies to GENERATE_BINDINGS.
32         * PlatformGTK.cmake: Ditto.
33         * PlatformMac.cmake: Ditto.
34         * bindings/gobject/WebKitDOMDeprecated.cpp: Added.
35         (webkit_dom_html_element_get_inner_html):
36         (webkit_dom_html_element_set_inner_html):
37         (webkit_dom_html_element_get_outer_html):
38         (webkit_dom_html_element_set_outer_html):
39         * bindings/gobject/WebKitDOMDeprecated.h: Added.
40         * bindings/gobject/WebKitDOMDeprecated.symbols: Added.
41         * bindings/gobject/webkitdom.symbols:
42
43 2014-12-06  Csaba Osztrogonác  <ossy@webkit.org>
44
45         URTBF after r176915.
46
47         DisplayRefreshMonitorClient is the parent class of GraphicsLayerUpdater
48         only if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true, so override
49         is incorrect if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.
50
51         That's why r176915 broke the build on non PLATFORM(COCOA) platforms,
52         such as GTK, EFL, Apple Windows.
53
54         Additionally displayRefreshFired is only used inside USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
55         guard, so there is no reason to define it for non COCOA platforms.
56
57         * platform/graphics/GraphicsLayerUpdater.cpp:
58         * platform/graphics/GraphicsLayerUpdater.h:
59
60 2014-12-06  Anders Carlsson  <andersca@apple.com>
61
62         Fix build with newer versions of clang.
63         rdar://problem/18978733
64
65         Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.
66
67         * page/scrolling/AsyncScrollingCoordinator.h:
68         * page/scrolling/ScrollingStateFixedNode.h:
69         * page/scrolling/ScrollingStateFrameScrollingNode.h:
70         * page/scrolling/ScrollingStateOverflowScrollingNode.h:
71         * page/scrolling/ScrollingStateStickyNode.h:
72         * page/scrolling/ScrollingTreeFrameScrollingNode.h:
73         (WebCore::ScrollingTreeFrameScrollingNode::updateLayersAfterDelegatedScroll): Deleted.
74         * page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
75         * platform/graphics/GraphicsLayerUpdater.h:
76         * platform/mac/ScrollbarThemeMac.h:
77         (WebCore::ScrollbarThemeMac::supportsControlTints): Deleted.
78         (WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): Deleted.
79         * rendering/RenderLayerCompositor.h:
80         * rendering/RenderSnapshottedPlugIn.h:
81
82 2014-12-06  Anders Carlsson  <andersca@apple.com>
83
84         Fix build with newer versions of clang.
85         rdar://problem/18978687
86
87         Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.
88
89         * html/HTMLElement.h:
90         * html/HTMLMediaElement.h:
91         * html/track/VTTCue.h:
92         * loader/FrameNetworkingContext.h:
93         (WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Deleted.
94         * loader/cache/CachedImage.h:
95         * page/SuspendableTimer.h:
96         * platform/Scrollbar.h:
97         * platform/graphics/InbandTextTrackPrivate.h:
98         * rendering/RenderBlockFlow.h:
99
100 2014-12-06  Anders Carlsson  <andersca@apple.com>
101
102         Follow-up build fix.
103
104         * Configurations/Base.xcconfig:
105
106 2014-12-06  Anders Carlsson  <andersca@apple.com>
107
108         Fix build with newer versions of clang.
109         rdar://problem/18978689
110
111         Disable the "inconsistent missing override" warning due to our use of macros in SVG where it's hard to
112         know whether we can add an override or not.
113
114         Also, cast return values of +alloc to the right type, and add some casts for vector iterator arithmetic.
115
116         * Configurations/Base.xcconfig:
117         * Modules/webdatabase/DatabaseBackendBase.cpp:
118         (WebCore::guidForOriginAndName):
119         * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
120         (-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
121         * editing/cocoa/HTMLConverter.mm:
122         (_shadowForShadowStyle):
123         (HTMLConverter::_addTableForElement):
124         * platform/graphics/SVGGlyph.cpp:
125         (WebCore::isCompatibleArabicForm):
126         * platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
127         (WebCore::AudioSourceProviderAVFObjC::createMix):
128         * platform/graphics/mac/FontMac.mm:
129         (WebCore::showLetterpressedGlyphsWithAdvances):
130         * platform/ios/PlatformSpeechSynthesizerIOS.mm:
131         (-[WebSpeechSynthesisWrapper speakUtterance:]):
132         * platform/ios/WebCoreMotionManager.mm:
133         (-[WebCoreMotionManager initializeOnMainThread]):
134         * rendering/RenderTableSection.cpp:
135         (WebCore::RenderTableSection::spannedRows):
136         (WebCore::RenderTableSection::spannedColumns):
137
138 2014-12-06  peavo@outlook.com  <peavo@outlook.com>
139
140         [WinCairo] Compile error, missing guard.
141         https://bugs.webkit.org/show_bug.cgi?id=139338
142
143         Reviewed by Alex Christensen.
144
145         There is missing a ENABLE(CSS_SELECTORS_LEVEL4) guard in CSSParser.cpp.
146
147         * css/CSSParser.cpp:
148         (WebCore::CSSParser::realLex):
149
150 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
151
152         AX: I cannot activate links on the mobile version of news.google.com
153         https://bugs.webkit.org/show_bug.cgi?id=139330
154
155         Reviewed by Simon Fraser.
156
157         This website only listens for touch events. VoiceOver normally dispatches click and mouse events,
158         so on iOS this falls and VoiceOver is not able to activate anything.
159
160         The solution here is to dispatch simulated touch down/up events.
161
162         Test: platform/ios-simulator/ios-accessibility/press-fires-touch-events.html
163
164         * accessibility/AccessibilityObject.cpp:
165         (WebCore::AccessibilityObject::press):
166         (WebCore::AccessibilityObject::dispatchTouchEvent):
167         * accessibility/AccessibilityObject.h:
168         (WebCore::AccessibilityObject::isDetachedFromParent):
169         * page/EventHandler.h:
170         * page/ios/EventHandlerIOS.mm:
171         (WebCore::EventHandler::dispatchSimulatedTouchEvent):
172         * platform/ios/PlatformEventFactoryIOS.h:
173         * platform/ios/PlatformEventFactoryIOS.mm:
174         (WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
175         (WebCore::PlatformEventFactory::createPlatformSimulatedTouchEvent):
176
177 2014-12-05  Myles C. Maxfield  <mmaxfield@apple.com>
178
179         Directional single quotation marks are not rotated in vertical text
180         https://bugs.webkit.org/show_bug.cgi?id=138526
181
182         Reviewed by Darin Adler.
183
184         In vertical text, directional single quotation marks are not rotated along with
185         the rest of the letters.
186
187         Test: fast/text/vertical-quotation-marks.html
188
189         * platform/graphics/FontGlyphs.cpp:
190         (WebCore::shouldIgnoreRotation):
191
192 2014-12-05  Dhi Aurrahman  <diorahman@rockybars.com>
193
194         Implement parser for :lang pseudo class selector arguments that contain wildcard '*' subtags
195         https://bugs.webkit.org/show_bug.cgi?id=139014
196
197         Reviewed by Benjamin Poulain.
198
199         Consider each language range in :lang() that consists of an asterisk 
200         immediately followed by an identifier beginning with an ASCII hyphen 
201         as a valid input for the selector as specified in [1].
202
203         [1] http://dev.w3.org/csswg/selectors4/#the-lang-pseudo 
204
205         Test: fast/css/parsing-css-lang.html
206
207         * css/CSSGrammar.y.in:
208         * css/CSSParser.cpp:
209         (WebCore::CSSParser::realLex):
210
211 2014-12-05  Simon Fraser  <simon.fraser@apple.com>
212
213         Programmatic scrolling and content changes are not always synchronized
214         https://bugs.webkit.org/show_bug.cgi?id=139245
215         rdar://problem/18833612
216
217         Reviewed by Anders Carlsson.
218         
219         For programmatic scrolls, AsyncScrollingCoordinator::requestScrollPositionUpdate()
220         calls updateScrollPositionAfterAsyncScroll(), then dispatches the requested
221         scroll position to the scrolling thread.
222         
223         Once the scrolling thread commits, it calls back to the main thread via
224         scheduleUpdateScrollPositionAfterAsyncScroll(), which schedules a second
225         call to updateScrollPositionAfterAsyncScroll() on a timer. That's a problem,
226         because some other scroll may have happened in the meantime; when the timer
227         fires, it can sometimes restore a stale scroll position.
228         
229         Fix by bailing early from scheduleUpdateScrollPositionAfterAsyncScroll()
230         for programmatic scrolls, since we know that requestScrollPositionUpdate()
231         already did the updateScrollPositionAfterAsyncScroll().
232
233         Test:
234             ManualTests/programmatic-scroll-flicker.html
235
236         * page/FrameView.cpp:
237         (WebCore::FrameView::reset): nullptr.
238         (WebCore::FrameView::setScrollPosition): Ditto.
239         (WebCore::FrameView::setWasScrolledByUser): Ditto.
240         * page/scrolling/AsyncScrollingCoordinator.cpp:
241         (WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate): Use a local variable for
242         isProgrammaticScroll just to make sure we use the same value for the duration of this function.
243         (WebCore::AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll): Do nothing
244         if this is a programmatic scroll.
245
246 2014-12-05  Timothy Horton  <timothy_horton@apple.com>
247
248         Build fix.
249
250         * platform/spi/mac/TUCallSPI.h:
251
252 2014-12-05  Roger Fong  <roger_fong@apple.com>
253
254         [Win] proj files copying over too many resources..
255         https://bugs.webkit.org/show_bug.cgi?id=139315.
256         <rdar://problem/19148278>
257
258         Reviewed by Brent Fulgham.
259
260         * WebCore.vcxproj/WebCore.proj: Don't copy over bin32 build output.
261
262 2014-12-05  Timothy Horton  <timothy_horton@apple.com>
263
264         Use the system string for telephone number menu
265         https://bugs.webkit.org/show_bug.cgi?id=139324
266         <rdar://problem/18726471>
267
268         * platform/spi/mac/TUCallSPI.h: Added.
269         Actually add the SPI header from the last commit.
270
271 2014-12-05  Tim Horton  <timothy_horton@apple.com>
272
273         Use the system string for telephone number menu
274         https://bugs.webkit.org/show_bug.cgi?id=139324
275         <rdar://problem/18726471>
276
277         Reviewed by Anders Carlsson.
278
279         * WebCore.xcodeproj/project.pbxproj:
280         * platform/spi/mac/TUCallSPI.h: Added.
281         Add an SPI header.
282
283 2014-12-05  Jer Noble  <jer.noble@apple.com>
284
285         [MSE][Mac] Return absolute value of error code from CDMSessionMediaSourceAVFObjC::update().
286         https://bugs.webkit.org/show_bug.cgi?id=139316
287
288         Reviewed by Eric Carlson.
289
290         Similarly to our asynchronous error reporting, return the absolute value of the error code.
291
292         * platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
293         (WebCore::systemCodeForError):
294         (WebCore::CDMSessionMediaSourceAVFObjC::update):
295
296 2014-12-05  Anders Carlsson  <andersca@apple.com>
297
298         Fix build on Windows.
299
300         * page/SessionIDHash.h:
301
302 2014-12-05  Zalan Bujtas  <zalan@apple.com>
303
304         Issue repaint at setUnavailablePluginIndicatorIsHidden() only when embedded object's indicator status changes.
305         https://bugs.webkit.org/show_bug.cgi?id=139311
306
307         Reviewed by Tim Horton.
308
309         Not testable.
310
311         * rendering/RenderEmbeddedObject.cpp:
312         (WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsHidden):
313
314 2014-12-05  Andreas Kling  <akling@apple.com>
315
316         PassRef should deref on destruction if pointee was not moved.
317         <https://webkit.org/b/139309>
318
319         Reviewed by Antti Koivisto.
320
321         Remove calls to PassRef::dropRef() since it's no longer necessary to manually
322         notify PassRef that you didn't move the pointee.
323
324         * rendering/RenderElement.cpp:
325         (WebCore::RenderElement::createFor):
326         (WebCore::RenderElement::setStyle):
327         * style/StyleResolveTree.cpp:
328         (WebCore::Style::resolveTree):
329
330 2014-12-05  Benjamin Poulain  <bpoulain@apple.com>
331
332         Fix style sharing with the "type" and "readonly" attributes
333         https://bugs.webkit.org/show_bug.cgi?id=139283
334
335         Reviewed by Antti Koivisto.
336
337         There are two bugs adressed with this patch:
338         1) The attributes "type" and "readonly" where only handled correctly
339            for input elements. For everything else, they could incorrectly
340            be ignored for style sharing.
341         2) The handling of attributes was incorrect for selector lists, leading
342            to various bugs (incorrect style sharing in some cases, disabling
343            style sharing on valid cases).
344
345         For [1], the problem was that attribute checking had been limited to
346         StyleResolver::canShareStyleWithControl(). That function is for handling
347         the special states of input element. For any other element, the attributes
348         were simply ignored.
349
350         For [2], there were a bunch of small problems. First, containsUncommonAttributeSelector()
351         was not recursive, which caused it to ignored any nested selector list. This used to be
352         correct but since we have advanced selectors we can no longer assumed selectors are not nested.
353
354         A second issue was that any attribute in a selector list was causing us to fall back
355         to the slow case. Now that we have the fast :matches(), we really don't want that.
356
357         The function containsUncommonAttributeSelector() was transformed into a recursive function
358         tracking where we are in the selector.
359
360         At the entry point, we start with the flag "startsOnRightmostElement" set to true. The flag is then
361         updated on the stack of each recursive call.
362
363         For example, "webkit > is:matches(freaking > awesome)". We evalute "is" with the flag to true, then recurse
364         into evaluating "freaking > awesome" with the flag still set to true. When we evalute ">", the flag
365         is set to false to evaluate any following selectors.
366         After evaluating "freaking > awesome", we go back to our previous stack frame, and the flag
367         is back to true and we can continue evaluating with the curren top level state.
368
369         From some logging, I discovered that the attribute handling is way too aggressive.
370         This is not a regression and I cannot fix that easily so I left a fixme.
371
372         Tests: fast/css/data-attribute-style-sharing-1.html
373                fast/css/data-attribute-style-sharing-2.html
374                fast/css/data-attribute-style-sharing-3.html
375                fast/css/data-attribute-style-sharing-4.html
376                fast/css/data-attribute-style-sharing-5.html
377                fast/css/data-attribute-style-sharing-6.html
378                fast/css/data-attribute-style-sharing-7.html
379                fast/css/readonly-attribute-style-sharing-1.html
380                fast/css/readonly-attribute-style-sharing-2.html
381                fast/css/readonly-attribute-style-sharing-3.html
382                fast/css/readonly-attribute-style-sharing-4.html
383                fast/css/readonly-attribute-style-sharing-5.html
384                fast/css/readonly-attribute-style-sharing-6.html
385                fast/css/readonly-attribute-style-sharing-7.html
386                fast/css/type-attribute-style-sharing-1.html
387                fast/css/type-attribute-style-sharing-2.html
388                fast/css/type-attribute-style-sharing-3.html
389                fast/css/type-attribute-style-sharing-4.html
390                fast/css/type-attribute-style-sharing-5.html
391                fast/css/type-attribute-style-sharing-6.html
392                fast/css/type-attribute-style-sharing-7.html
393
394         * css/RuleSet.cpp:
395         (WebCore::containsUncommonAttributeSelector):
396         (WebCore::RuleData::RuleData):
397         (WebCore::selectorListContainsAttributeSelector): Deleted.
398         * css/StyleResolver.cpp:
399         (WebCore::StyleResolver::canShareStyleWithControl):
400         (WebCore::StyleResolver::canShareStyleWithElement):
401
402 2014-12-05  Jer Noble  <jer.noble@apple.com>
403
404         [WTF] MediaTime should support round-tripping from and to doubles.
405         https://bugs.webkit.org/show_bug.cgi?id=139248
406
407         Reviewed by Eric Carlson.
408
409         Check whether the MediaTime's underlying data is floating point before converting
410         to a CMTime or QTTime.
411
412         * platform/graphics/avfoundation/MediaTimeAVFoundation.cpp:
413         (WebCore::toCMTime):
414         * platform/graphics/mac/MediaTimeQTKit.mm:
415         (WebCore::toQTTime):
416
417 2014-12-05  Anders Carlsson  <andersca@apple.com>
418
419         Add a private browsing mode to MiniBrowser
420         https://bugs.webkit.org/show_bug.cgi?id=139308
421
422         Reviewed by Sam Weinig.
423
424         Use -1 instead of -2 for the deleted value.
425
426         * page/SessionIDHash.h:
427
428 2014-12-05  Chris Dumez  <cdumez@apple.com>
429
430         Move 'text-emphasis-style' CSS property to the new StyleBuilder
431         https://bugs.webkit.org/show_bug.cgi?id=139285
432
433         Reviewed by Sam Weinig.
434
435         Move 'text-emphasis-style' CSS property to the new StyleBuilder by
436         using custom code.
437
438         No new tests, no behavior change.
439
440         * css/CSSPropertyNames.in:
441         * css/DeprecatedStyleBuilder.cpp:
442         (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
443         (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue): Deleted.
444         (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue): Deleted.
445         (WebCore::ApplyPropertyTextEmphasisStyle::applyValue): Deleted.
446         (WebCore::ApplyPropertyTextEmphasisStyle::createHandler): Deleted.
447         * css/StyleBuilderCustom.h:
448         (WebCore::StyleBuilderCustom::applyInitialWebkitTextEmphasisStyle):
449         (WebCore::StyleBuilderCustom::applyInheritWebkitTextEmphasisStyle):
450         (WebCore::StyleBuilderCustom::applyValueWebkitTextEmphasisStyle):
451
452 2014-12-05  Eric Carlson  <eric.carlson@apple.com>
453
454         [iOS] remove "enter optimized fullscreen" gesture
455         https://bugs.webkit.org/show_bug.cgi?id=139301
456
457         Reviewed by Jer Noble.
458
459         * Modules/mediacontrols/mediaControlsiOS.js:
460         (ControllerIOS.prototype.handleWrapperTouchStart): Remove gesture recognizer.
461
462 2014-12-05  Beth Dakin  <bdakin@apple.com>
463
464         rdar://problem/19156353 Additional build-fixes needed.
465
466         Rubber-stamped by Tim Horton.
467
468         This is a bit unfortunate, but we need to always forward-declare this for now.
469         * platform/spi/mac/QuickLookMacSPI.h:
470
471 2014-12-05  David Kilzer  <ddkilzer@apple.com>
472
473         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
474         <http://webkit.org/b/139286>
475
476         Reviewed by Daniel Bates.
477
478         * Configurations/FeatureDefines.xcconfig: Switch back to using
479         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
480
481 2014-12-05  Eric Carlson  <eric.carlson@apple.com>
482
483         [iOS] allow host application to opt-out of alternate fullscreen pt. 2
484         https://bugs.webkit.org/show_bug.cgi?id=139227
485
486         Reviewed by Jer Noble and Anders Carlsson
487
488         * WebCore.exp.in: Export HTMLMediaSession::allowsAlternateFullscreen, change the signature of 
489             WebVideoFullscreenInterfaceAVKit::setupFullscreen.
490
491         * platform/ios/WebVideoFullscreenControllerAVKit.mm:
492         (-[WebVideoFullscreenController enterFullscreen:mode:]): Update for
493             WebVideoFullscreenInterfaceAVKit::setupFullscreen change.
494
495         * platform/ios/WebVideoFullscreenInterfaceAVKit.h: Add argument to setupFullscreen.
496         * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
497         (WebVideoFullscreenInterfaceAVKit::setupFullscreen): Ditto.
498
499 2014-12-05  Shivakumar JM  <shiva.jm@samsung.com>
500
501         Fix build warning in WebCore/platform/graphics module
502         https://bugs.webkit.org/show_bug.cgi?id=139290
503
504         Reviewed by Carlos Garcia Campos.
505
506         Fix a build warning by removing parameter name from function.
507
508         No new tests, no behavior change.
509
510         * platform/graphics/freetype/FontCacheFreeType.cpp:
511         (WebCore::getFamilyNameStringFromFontDescriptionAndFamily):
512
513 2014-12-05  sungmin cho  <sungmin17.cho@lge.com>
514
515         GraphicsLayerTextureMapper: Rename parameter to be more clear
516         https://bugs.webkit.org/show_bug.cgi?id=139288
517
518         Reviewed by Martin Robinson.
519
520         Rename 'media' to 'platformLayer'.
521
522         No new tests, no change in functionality.
523
524         * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
525         (WebCore::GraphicsLayerTextureMapper::setContentsToPlatformLayer):
526
527 2014-12-04  Mark Rowe  <mrowe@apple.com>
528
529         Fix pre-Yosemite builds.
530
531         The #ifs in two SPI wrapper headers were incorrect, resulting in code being included
532         prior to Yosemite that required Yosemite to compile.
533
534         * platform/spi/mac/NSSharingServicePickerSPI.h:
535         * platform/spi/mac/NSSharingServiceSPI.h:
536
537 2014-12-02  Brian J. Burg  <burg@cs.washington.edu>
538
539         Web Inspector: timeline probe records have inaccurate per-probe hit counts
540         https://bugs.webkit.org/show_bug.cgi?id=138976
541
542         Reviewed by Joseph Pecoraro.
543
544         Update the signature for breakpointActionProbe to take batchId and sampleId.
545         Covered by existing test inspector-protocol/debugger/didSampleProbe-multiple-probes.html.
546
547         * inspector/InspectorTimelineAgent.cpp:
548         (WebCore::InspectorTimelineAgent::breakpointActionProbe):
549         * inspector/InspectorTimelineAgent.h:
550         * inspector/TimelineRecordFactory.cpp:
551         (WebCore::TimelineRecordFactory::createProbeSampleData):
552         * inspector/TimelineRecordFactory.h:
553
554 2014-12-04  Adenilson Cavalcanti  <cavalcantii@gmail.com>
555
556         Groove/inset/outset borders show solid if the color is black
557         https://bugs.webkit.org/show_bug.cgi?id=58608
558
559         Reviewed by Simon Fraser.
560
561         Test: fast/borders/mixed-border-style2.html
562
563         This patch will lighten/darken the border side colors, handling
564         border decoration in a similar way as Firefox does.
565
566         * rendering/RenderObject.cpp:
567         (WebCore::RenderObject::drawLineForBoxSide):
568         (WebCore::RenderObject::calculateBorderStyleColor):
569         * rendering/RenderObject.h:
570
571 2014-12-04  Chris Dumez  <cdumez@apple.com>
572
573         Move 'webkit-aspect-ratio' CSS property to the new StyleBuilder
574         https://bugs.webkit.org/show_bug.cgi?id=139250
575
576         Reviewed by Sam Weinig.
577
578         Move 'aspect-ratio' CSS property to the new StyleBuilder by
579         using custom code.
580
581         No new tests, no behavior change.
582
583         * css/CSSPropertyNames.in:
584         * css/DeprecatedStyleBuilder.cpp:
585         (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
586         (WebCore::ApplyPropertyAspectRatio::applyInheritValue): Deleted.
587         (WebCore::ApplyPropertyAspectRatio::applyInitialValue): Deleted.
588         (WebCore::ApplyPropertyAspectRatio::applyValue): Deleted.
589         (WebCore::ApplyPropertyAspectRatio::createHandler): Deleted.
590         * css/StyleBuilderCustom.h:
591         (WebCore::StyleBuilderCustom::applyInitialWebkitAspectRatio):
592         (WebCore::StyleBuilderCustom::applyInheritWebkitAspectRatio):
593         (WebCore::StyleBuilderCustom::applyValueWebkitAspectRatio):
594
595 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
596
597         Further fix the 32-bit build.
598
599         * page/mac/TextIndicatorWindow.mm:
600         (WebCore::TextIndicatorWindow::setTextIndicator):
601
602 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
603
604         Fix the 32-bit build.
605
606         * page/mac/TextIndicatorWindow.h:
607         * page/mac/TextIndicatorWindow.mm:
608         (WebCore::TextIndicatorWindow::setTextIndicator):
609
610 2014-12-04  Tim Horton  <timothy_horton@apple.com>
611
612         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
613         https://bugs.webkit.org/show_bug.cgi?id=139252
614         <rdar://problem/19140827>
615
616         Reviewed by Anders Carlsson.
617
618         * WebCore.exp.in:
619         * page/TextIndicator.cpp:
620         (WebCore::TextIndicator::createWithSelectionInFrame):
621         (WebCore::TextIndicator::TextIndicator):
622         * page/TextIndicator.h:
623         (WebCore::TextIndicator::selectionRectInWindowCoordinates):
624         (WebCore::TextIndicator::textBoundingRectInWindowCoordinates):
625         (WebCore::TextIndicator::selectionRectInScreenCoordinates): Deleted.
626         (WebCore::TextIndicator::textBoundingRectInScreenCoordinates): Deleted.
627         Go back to keeping the rects in "window" coordinates.
628
629         * page/mac/TextIndicatorWindow.h:
630         * page/mac/TextIndicatorWindow.mm:
631         (-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
632         (WebCore::TextIndicatorWindow::setTextIndicator):
633         Let callers pass in the contentRect instead of trying to share the code
634         to compute it, since it needs to be different for legacy and modern WebKit.
635
636 2014-12-04  Oliver Hunt  <oliver@apple.com>
637
638         Serialization of MapData object provides unsafe access to internal types
639         https://bugs.webkit.org/show_bug.cgi?id=138653
640
641         Reviewed by Geoffrey Garen.
642
643         We now keep the value portion of the key/value pair in MapData as a
644         separate stack. This allows us to maintain the spec semantic of
645         "atomic" serialisation of the key/value pair without retaining the
646         use of a potentially invalid iterator.
647
648         * bindings/js/SerializedScriptValue.cpp:
649         (WebCore::CloneSerializer::serialize):
650
651 2014-12-04  Radu Stavila  <stavila@adobe.com>
652
653         [SVG Masking] Add support for referencing <mask> elements from -webkit-mask-image
654         https://bugs.webkit.org/show_bug.cgi?id=139092
655
656         Reviewed by Simon Fraser.
657
658         This patch improves the -webkit-mask-image property by allowing it to reference
659         a <mask> element defined in an inline or external SVG document.
660         Up until now, each image to be used as a mask consisted of a FillLayer object 
661         whose m_image member represented the mask. Now, in order to accomodate
662         <mask> elements referenced by a fragment identifier (e.g. file.svg#mask1)
663         a new class was created (MaskImageOperation) and added as a member of the 
664         FillLayer. As such, from now on, all FillLayer objects used for masking will
665         store the masking information in this new member.
666         When parsing the -webkit-mask-image property (or the -webkit-mask shorthand)
667         a new MaskImageOperation object is created for each image. If the value represents
668         an external URL, a pending SVG document will be created which will be loaded 
669         during the phase that loads the pending resources. When the download is complete,
670         the MaskImageOperation is notified by the CachedSVGDocument class and checks if
671         the received download is a valid SVG and the requested fragment identifier
672         actually exists and identifies a <mask> element. If it does, that element's
673         renderer (of type RenderSVGResourceMasker) will be used when painting the mask layers.
674         Otherwise, the MaskImageOperation class will use the already downloaded data 
675         buffer to create a CachedImage from it and use that instead, basically emulating
676         the previous behavior, when only images were accepted. This ensures that all existing
677         behavior, like painting entire SVGs, painting normal images (e.g. PNG/JPG), painting
678         generated images (e.g. linear-gradient) works as it did before.
679
680         No new tests required, this patch doesn't change any current functionality. 
681         It only adds support for referencing <mask> elements for the -webkit-mask-image 
682         property. This is sub-part 1 of the bigger patch https://bugs.webkit.org/show_bug.cgi?id=129682.
683
684         * CMakeLists.txt:
685         * WebCore.vcxproj/WebCore.vcxproj:
686         * WebCore.vcxproj/WebCore.vcxproj.filters:
687         * WebCore.xcodeproj/project.pbxproj:
688         * css/CSSValue.cpp:
689         (WebCore::CSSValue::cssText):
690         (WebCore::CSSValue::destroy):
691         * css/CSSValue.h:
692         (WebCore::CSSValue::isWebKitCSSResourceValue):
693         * css/StyleResolver.cpp:
694         (WebCore::StyleResolver::State::clear):
695         (WebCore::StyleResolver::createMaskImageOperations):
696         * css/StyleResolver.h:
697         (WebCore::StyleResolver::State::maskImagesWithPendingSVGDocuments):
698         * css/WebKitCSSResourceValue.cpp: Added.
699         (WebCore::WebKitCSSResourceValue::WebKitCSSResourceValue):
700         (WebCore::WebKitCSSResourceValue::customCSSText):
701         (WebCore::WebKitCSSResourceValue::isCSSValueNone):
702         * css/WebKitCSSResourceValue.h: Added.
703         (WebCore::WebKitCSSResourceValue::create):
704         (WebCore::WebKitCSSResourceValue::innerValue):
705         * loader/cache/CachedResourceLoader.cpp:
706         (WebCore::CachedResourceLoader::addCachedResource):
707         * loader/cache/CachedResourceLoader.h:
708         * loader/cache/CachedSVGDocument.cpp:
709         (WebCore::CachedSVGDocument::CachedSVGDocument):
710         (WebCore::CachedSVGDocument::finishLoading):
711         * loader/cache/CachedSVGDocument.h:
712         * loader/cache/CachedSVGDocumentReference.cpp:
713         (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
714         (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
715         (WebCore::CachedSVGDocumentReference::load):
716         * loader/cache/CachedSVGDocumentReference.h:
717         * page/FrameView.cpp:
718         (WebCore::FrameView::isSVGDocument):
719         * page/FrameView.h:
720         * page/Page.cpp:
721         (WebCore::Page::createPageFromBuffer):
722         * page/Page.h:
723         * platform/ScrollView.h:
724         (WebCore::ScrollView::isSVGDocument):
725         * platform/graphics/MaskImageOperation.cpp: Added.
726         (WebCore::MaskImageOperation::create):
727         (WebCore::MaskImageOperation::MaskImageOperation):
728         (WebCore::MaskImageOperation::~MaskImageOperation):
729         (WebCore::MaskImageOperation::isCSSValueNone):
730         (WebCore::MaskImageOperation::cssValue):
731         (WebCore::MaskImageOperation::isMaskLoaded):
732         (WebCore::MaskImageOperation::setRenderLayerImageClient):
733         (WebCore::MaskImageOperation::addRendererImageClient):
734         (WebCore::MaskImageOperation::removeRendererImageClient):
735         (WebCore::MaskImageOperation::getOrCreateCachedSVGDocumentReference):
736         (WebCore::MaskImageOperation::notifyFinished): This is the method that gets called when the document has finished 
737         downloading and checks if it can find a valid <mask> element.
738         (WebCore::MaskImageOperation::drawMask):
739         (WebCore::MaskImageOperation::getSVGMasker):
740         * platform/graphics/MaskImageOperation.h: Added.
741         * rendering/RenderBoxModelObject.cpp: The BackgroundImageGeometry class was moved out of RenderBoxModelObject in 
742         order to be used as a parameter for other methods. This was necessary to avoid having methods with very many parameters.
743         (WebCore::BackgroundImageGeometry::setNoRepeatX):
744         (WebCore::BackgroundImageGeometry::setNoRepeatY):
745         (WebCore::BackgroundImageGeometry::useFixedAttachment):
746         (WebCore::BackgroundImageGeometry::clip):
747         (WebCore::BackgroundImageGeometry::relativePhase):
748         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX): Deleted.
749         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY): Deleted.
750         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment): Deleted.
751         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip): Deleted.
752         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase): Deleted.
753         * rendering/RenderBoxModelObject.h:
754         (WebCore::BackgroundImageGeometry::BackgroundImageGeometry):
755         (WebCore::BackgroundImageGeometry::destOrigin):
756         (WebCore::BackgroundImageGeometry::setDestOrigin):
757         (WebCore::BackgroundImageGeometry::destRect):
758         (WebCore::BackgroundImageGeometry::setDestRect):
759         (WebCore::BackgroundImageGeometry::phase):
760         (WebCore::BackgroundImageGeometry::setPhase):
761         (WebCore::BackgroundImageGeometry::tileSize):
762         (WebCore::BackgroundImageGeometry::setTileSize):
763         (WebCore::BackgroundImageGeometry::spaceSize):
764         (WebCore::BackgroundImageGeometry::setSpaceSize):
765         (WebCore::BackgroundImageGeometry::setPhaseX):
766         (WebCore::BackgroundImageGeometry::setPhaseY):
767         (WebCore::BackgroundImageGeometry::setHasNonLocalGeometry):
768         (WebCore::BackgroundImageGeometry::hasNonLocalGeometry):
769         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::BackgroundImageGeometry): Deleted.
770         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin): Deleted.
771         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin): Deleted.
772         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect): Deleted.
773         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect): Deleted.
774         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase): Deleted.
775         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase): Deleted.
776         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize): Deleted.
777         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize): Deleted.
778         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::spaceSize): Deleted.
779         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setSpaceSize): Deleted.
780         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseX): Deleted.
781         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseY): Deleted.
782         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setHasNonLocalGeometry): Deleted.
783         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::hasNonLocalGeometry): Deleted.
784         * rendering/RenderLayer.cpp:
785         (WebCore::RenderLayer::RenderLayer):
786         (WebCore::RenderLayer::~RenderLayer):
787         * rendering/RenderLayer.h:
788         * rendering/RenderLayerMaskImageInfo.cpp: Added.
789         (WebCore::RenderLayer::MaskImageInfo::layerToMaskMap): Returns a static map that links MaskImageInfo objects to RenderLayers.
790         (WebCore::RenderLayer::MaskImageInfo::getIfExists): Returns the MaskImageInfo associated with a specific RenderLayer.
791         (WebCore::RenderLayer::MaskImageInfo::get): Returns the MaskImageInfo associated with a specific RenderLayer (creates it if necessary).
792         (WebCore::RenderLayer::MaskImageInfo::remove): Removes the MaskImageInfo associated with a specific RenderLayer.
793         (WebCore::RenderLayer::MaskImageInfo::MaskImageInfo):
794         (WebCore::RenderLayer::MaskImageInfo::~MaskImageInfo):
795         (WebCore::RenderLayer::MaskImageInfo::notifyFinished): Gets called when the SVG document finished loading, triggers repaint.
796         (WebCore::RenderLayer::MaskImageInfo::imageChanged): Gets called when the image object changed, triggers repaint.
797         (WebCore::RenderLayer::MaskImageInfo::updateMaskImageClients): Goes through all mask layers and sets image/SVG clients. 
798         Updates list of internal and external SVG references.
799         (WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients): Removes all image/SVG clients and clears lists of internal and external SVG references.
800         * rendering/RenderLayerMaskImageInfo.h: Added.
801         * rendering/RenderObject.h:
802         (WebCore::RenderObject::isRenderSVGResourceMasker):
803         * rendering/style/FillLayer.cpp:
804         (WebCore::FillLayer::FillLayer):
805         (WebCore::FillLayer::operator=):
806         (WebCore::FillLayer::operator==):
807         (WebCore::FillLayer::cullEmptyLayers):
808         (WebCore::FillLayer::hasNonEmptyMaskImage):
809         (WebCore::FillLayer::imagesAreLoaded):
810         * rendering/style/FillLayer.h:
811         (WebCore::FillLayer::maskImage):
812         (WebCore::FillLayer::imageOrMaskImage):
813         (WebCore::FillLayer::setMaskImage):
814         (WebCore::FillLayer::clearMaskImage):
815         (WebCore::FillLayer::hasMaskImage):
816         * rendering/svg/RenderSVGResourceMasker.cpp:
817         (WebCore::RenderSVGResourceMasker::applySVGMask):
818         (WebCore::RenderSVGResourceMasker::applyResource):
819         (WebCore::RenderSVGResourceMasker::drawMaskForRenderer):
820         * rendering/svg/RenderSVGResourceMasker.h:
821         * svg/SVGMaskElement.cpp:
822         (WebCore::SVGMaskElement::createElementRenderer):
823         (WebCore::SVGMaskElement::addClientRenderLayer):
824         (WebCore::SVGMaskElement::removeClientRenderLayer):
825         * svg/SVGMaskElement.h:
826         * svg/SVGUseElement.cpp:
827         (WebCore::SVGUseElement::setCachedDocument):
828         * svg/graphics/SVGImage.cpp:
829         (WebCore::SVGImage::dataChanged):
830
831 2014-12-04  Commit Queue  <commit-queue@webkit.org>
832
833         Unreviewed, rolling out r176789.
834         https://bugs.webkit.org/show_bug.cgi?id=139255
835
836         Broke the non Mac-WK2 builds (Requested by stavila on
837         #webkit).
838
839         Reverted changeset:
840
841         "Remove isSpecifiedFont boolean from FontDescription"
842         https://bugs.webkit.org/show_bug.cgi?id=139233
843         http://trac.webkit.org/changeset/176789
844
845 2014-12-03  Antti Koivisto  <antti@apple.com>
846
847         Remove isSpecifiedFont boolean from FontDescription
848         https://bugs.webkit.org/show_bug.cgi?id=139233
849
850         Reviewed by Andreas Kling.
851
852         It is barely used.
853
854         * css/StyleBuilderCustom.h:
855         (WebCore::StyleBuilderCustom::applyInheritFontFamily):
856         (WebCore::StyleBuilderCustom::applyValueFontFamily):
857         * platform/graphics/FontDescription.cpp:
858         (WebCore::genericFamiliesSet):
859         (WebCore::FontDescription::hasGenericFirstFamily):
860
861             Add a function to test for generic families.
862
863         * platform/graphics/FontDescription.h:
864         (WebCore::FontDescription::FontDescription):
865         (WebCore::FontDescription::setTextRenderingMode):
866         (WebCore::FontDescription::operator==):
867         (WebCore::FontDescription::isSpecifiedFont): Deleted.
868         (WebCore::FontDescription::setIsSpecifiedFont): Deleted.
869         * rendering/RenderText.cpp:
870         (WebCore::RenderText::computeUseBackslashAsYenSymbol):
871
872             This is the only client.
873             Figure out the equivalent information dynamically if needed.
874
875 2014-12-03  Joonghun Park  <jh718.park@samsung.com>
876
877         Use std::unique_ptr instead of PassOwnPtr|OwnPtr for Pasteboard
878         https://bugs.webkit.org/show_bug.cgi?id=139019
879
880         Reviewed by Darin Adler.
881
882         No new tests, no behavior changes.
883
884         * dom/DataTransfer.cpp:
885         (WebCore::DataTransfer::DataTransfer):
886         * dom/DataTransfer.h:
887         * editing/Editor.cpp:
888         (WebCore::Editor::dispatchCPPEvent):
889         * page/mac/EventHandlerMac.mm:
890         (WebCore::EventHandler::createDraggingDataTransfer):
891         * platform/Pasteboard.h:
892         * platform/efl/PasteboardEfl.cpp:
893         (WebCore::Pasteboard::createForCopyAndPaste):
894         (WebCore::Pasteboard::createPrivate):
895         (WebCore::Pasteboard::createForDragAndDrop):
896         * platform/gtk/PasteboardGtk.cpp:
897         (WebCore::Pasteboard::createForCopyAndPaste):
898         (WebCore::Pasteboard::createForGlobalSelection):
899         (WebCore::Pasteboard::createPrivate):
900         (WebCore::Pasteboard::createForDragAndDrop):
901         (WebCore::Pasteboard::create): Deleted.
902         * platform/ios/PasteboardIOS.mm:
903         (WebCore::Pasteboard::createForCopyAndPaste):
904         (WebCore::Pasteboard::createPrivate):
905         * platform/mac/PasteboardMac.mm:
906         (WebCore::Pasteboard::createForCopyAndPaste):
907         (WebCore::Pasteboard::createPrivate):
908         (WebCore::Pasteboard::createForDragAndDrop):
909         (WebCore::Pasteboard::create): Deleted.
910         * platform/win/PasteboardWin.cpp:
911         (WebCore::Pasteboard::createForCopyAndPaste):
912         (WebCore::Pasteboard::createPrivate):
913         (WebCore::Pasteboard::createForDragAndDrop):
914
915 2014-12-03  Benjamin Poulain  <bpoulain@apple.com>
916
917         Get rid of FrameLoaderClient::dispatchWillRequestResource
918         https://bugs.webkit.org/show_bug.cgi?id=139235
919
920         Reviewed by Alexey Proskuryakov.
921
922         It is useless.
923
924         * loader/FrameLoaderClient.h:
925         (WebCore::FrameLoaderClient::dispatchWillRequestResource): Deleted.
926         * loader/cache/CachedResourceLoader.cpp:
927         (WebCore::CachedResourceLoader::requestResource):
928
929 2014-12-03  Myles C. Maxfield  <mmaxfield@apple.com>
930
931         List markers in RTL languages do not draw the first character.
932         https://bugs.webkit.org/show_bug.cgi?id=139244
933
934         Reviewed by Simon Fraser.
935
936         Off-by-one error when reversing the string (from LTR to RTL)
937
938         Test: fast/lists/rtl-marker.html
939
940         * rendering/RenderListMarker.cpp:
941         (WebCore::RenderListMarker::paint):
942
943 2014-12-03  Beth Dakin  <bdakin@apple.com>
944
945         <input> elements get whitespace action menu instead of editable text menu
946         https://bugs.webkit.org/show_bug.cgi?id=139241
947         -and corresponding-
948         rdar://problem/19072083
949
950         Reviewed by Sam Weinig.
951
952         Since we will hit test form controls as form controls, we need a new function to 
953         determine if the hit point is over text inside that form control or not.
954         * WebCore.exp.in:
955         * rendering/HitTestResult.cpp:
956         (WebCore::HitTestResult::isOverTextInsideFormControlElement):
957         * rendering/HitTestResult.h:
958
959 2014-12-03  Tim Horton  <timothy_horton@apple.com>
960
961         Keyboard input should be disabled in the preview popover
962         https://bugs.webkit.org/show_bug.cgi?id=139219
963         <rdar://problem/19052381>
964
965         Reviewed by Anders Carlsson.
966
967         * page/ChromeClient.h:
968         (WebCore::ChromeClient::shouldDispatchFakeMouseMoveEvents):
969         * page/EventHandler.cpp:
970         (WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
971         Allow ChromeClient to disable the dispatch of "fake" mouseMove events
972         that happens during scrolling.
973
974 2014-12-03  Antti Koivisto  <antti@apple.com>
975
976         Remove genericFamily enum from FontDescription
977         https://bugs.webkit.org/show_bug.cgi?id=139207
978
979         Reviewed by Andreas Kling.
980
981         We use predefined AtomicStrings for generic families. The side enum adds no information.
982
983         * css/CSSFontSelector.cpp:
984         (WebCore::resolveGenericFamily):
985         (WebCore::CSSFontSelector::getFontData):
986
987             Match the existing quirk where the default font can be replaced by @font-face rule but user generic families can't.
988
989         (WebCore::CSSFontSelector::resolvesFamilyFor):
990         (WebCore::fontDataForGenericFamily): Deleted.
991         * css/DeprecatedStyleBuilder.cpp:
992         (WebCore::ApplyPropertyFontFamily::applyInheritValue):
993         (WebCore::ApplyPropertyFontFamily::applyInitialValue):
994         (WebCore::ApplyPropertyFontFamily::applyValue):
995         * css/StyleResolver.cpp:
996         (WebCore::StyleResolver::checkForGenericFamilyChange):
997
998             Remove the explicit monospace check, earlier useFixedDefaultSize check is equivalent.
999
1000         (WebCore::StyleResolver::initializeFontStyle):
1001         * platform/graphics/FontDescription.h:
1002         (WebCore::FontDescription::FontDescription):
1003         (WebCore::FontDescription::useFixedDefaultSize):
1004         (WebCore::FontDescription::setWeight):
1005         (WebCore::FontDescription::equalForTextAutoSizing):
1006         (WebCore::FontDescription::operator==):
1007         (WebCore::FontDescription::genericFamily): Deleted.
1008         (WebCore::FontDescription::setGenericFamily): Deleted.
1009         * platform/mac/ThemeMac.mm:
1010         (WebCore::ThemeMac::controlFont):
1011         * rendering/RenderTheme.cpp:
1012         (WebCore::RenderTheme::adjustStyle):
1013
1014             Reset the lineheight unconditionally for buttons.
1015             This always happened before because the explicitly set generic family made the font compare false.
1016
1017         * rendering/RenderThemeIOS.mm:
1018         (WebCore::RenderThemeIOS::systemFont):
1019         * rendering/RenderThemeMac.mm:
1020         (WebCore::RenderThemeMac::systemFont):
1021         (WebCore::RenderThemeMac::setFontFromControlSize):
1022         * style/StyleResolveForDocument.cpp:
1023         (WebCore::Style::resolveForDocument):
1024
1025             Resolve document style for final value immediately as it can't be affected by @font-face rules.
1026
1027 2014-12-03  Zalan Bujtas  <zalan@apple.com>
1028
1029         ASSERTION: RenderMultiColumnFlowThread::processPossibleSpannerDescendant() when column spanner's parent is not a RenderBlockFlow.
1030         https://bugs.webkit.org/show_bug.cgi?id=139188
1031         rdar://problem/18502182
1032
1033         Reviewed by David Hyatt.
1034
1035         This patch ensures that the validation check for spanner in isValidColumnSpanner() is in synch
1036         with the expectation in RenderMultiColumnFlowThread::processPossibleSpannerDescendant().
1037         (descendant's parent is expected to be a RenderBlockFlow)
1038
1039         Test: fast/multicol/svg-content-as-column-spanner-crash.html
1040
1041         * rendering/RenderMultiColumnFlowThread.cpp:
1042         (WebCore::isValidColumnSpanner):
1043
1044 2014-12-03  peavo@outlook.com  <peavo@outlook.com>
1045
1046         [TexMap] Redundant method in GraphicsLayerTextureMapper.
1047         https://bugs.webkit.org/show_bug.cgi?id=138005
1048
1049         Reviewed by Alex Christensen.
1050
1051         The TextureMapperLayer method descendantsOrSelfHaveRunningAnimations() can be used
1052         instead of the GraphicsLayerTextureMapper method startedAnimation().
1053
1054         * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
1055         (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
1056         (WebCore::GraphicsLayerTextureMapper::addAnimation):
1057         * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
1058
1059 2014-12-03  Jeremy Jones  <jeremyj@apple.com>
1060
1061         Subtitle menu should only appear when useful.
1062         https://bugs.webkit.org/show_bug.cgi?id=139133
1063
1064         Reviewed by Eric Carlson.
1065
1066         * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
1067         (-[WebAVPlayerController hasLegibleMediaSelectionOptions]): only enable when there are non default options.
1068         (-[WebAVPlayerController hasAudioMediaSelectionOptions]): only enable when there is more than one option.
1069
1070 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
1071
1072         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
1073         https://bugs.webkit.org/show_bug.cgi?id=139071
1074
1075         Reviewed by Chris Fleizach.
1076
1077         Adds a new InlineRole accessibility role type for non-focusable inline
1078         elements which have an event handler or attribute suggesting possible
1079         inclusion by the platform. This is mapped to ATK_ROLE_STATIC for GTK and
1080         EFL. On the Mac, it is currently ignored to preserve existing behavior.
1081
1082         Added new test cases to the existing roles-exposed.html test.
1083
1084         * accessibility/AccessibilityObject.cpp:
1085         (WebCore::AccessibilityObject::supportsDatetimeAttribute): Added.
1086         * accessibility/AccessibilityObject.h: Added InlineRole.
1087         * accessibility/AccessibilityRenderObject.cpp:
1088         (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Handle InlineRole.
1089         * accessibility/atk/AccessibilityObjectAtk.cpp:
1090         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Include InlineRole objects.
1091         * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
1092         (atkRole):
1093         * accessibility/mac/AccessibilityObjectMac.mm:
1094         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore InlineRole objects.
1095         * html/HTMLTagNames.in: Added 'time'.
1096
1097 2014-12-03  Jer Noble  <jer.noble@apple.com>
1098
1099         [Mac] Hang when calling -[AVAsset resolvedURL].
1100         https://bugs.webkit.org/show_bug.cgi?id=139223
1101
1102         Reviewed by Eric Carlson.
1103
1104         On a particularly slow-loading site, a call to -[AVAsset resolvedURL] can take an arbitrarily long
1105         time. Treat this AVAsset property similar to other "metadata" properties, and check the load status
1106         of the property before requesting it.
1107
1108         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
1109         (WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check the load state of -resolvedURL.
1110         (WebCore::MediaPlayerPrivateAVFoundationObjC::resolvedURL): Ditto.
1111         (WebCore::assetMetadataKeyNames): Add @"resolvedURL".
1112
1113 2014-12-03  Csaba Osztrogonác  <ossy@webkit.org>
1114
1115         URTBF after r176721 to fix ENABLE(CSS_DEVICE_ADAPTATION) build.
1116
1117         * css/CSSParser.cpp:
1118         (WebCore::CSSParser::parseViewportProperty):
1119
1120 2014-12-03  Chris Dumez  <cdumez@apple.com>
1121
1122         Move 'display' CSS property to the new StyleBuilder
1123         https://bugs.webkit.org/show_bug.cgi?id=139218
1124
1125         Reviewed by Antti Koivisto.
1126
1127         Move 'display' CSS property to the new StyleBuilder.
1128
1129         No new tests, no behavior change.
1130
1131         * css/CSSPropertyNames.in:
1132         * css/DeprecatedStyleBuilder.cpp:
1133         (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
1134         (WebCore::ApplyPropertyDisplay::isValidDisplayValue): Deleted.
1135         (WebCore::ApplyPropertyDisplay::applyInheritValue): Deleted.
1136         (WebCore::ApplyPropertyDisplay::applyInitialValue): Deleted.
1137         (WebCore::ApplyPropertyDisplay::applyValue): Deleted.
1138         (WebCore::ApplyPropertyDisplay::createHandler): Deleted.
1139         * css/StyleBuilderCustom.h:
1140         (WebCore::StyleBuilderCustom::isValidDisplayValue):
1141         (WebCore::StyleBuilderCustom::applyInheritDisplay):
1142         (WebCore::StyleBuilderCustom::applyValueDisplay):
1143         * css/makeprop.pl:
1144         Add support for passing multiple values for Custom option, e.g.:
1145         'Custom=Inherit|Value'. This was useful as we did not need custom
1146         code for display's initial value.
1147
1148 2014-12-03  Chris Dumez  <cdumez@apple.com>
1149
1150         Modernize the CSSParser code
1151         https://bugs.webkit.org/show_bug.cgi?id=139209
1152
1153         Reviewed by Antti Koivisto.
1154
1155         Modernize the CSSParser code by:
1156         - Using more references instead of pointers
1157         - Using nullptr instead of 0
1158
1159         No new tests, no behavior change.
1160
1161 2014-12-03  David Kilzer  <ddkilzer@apple.com>
1162
1163         [iOS] REGRESSION (r176622): WebCore fails to link
1164
1165         Speculative fix for the following build failure:
1166
1167             Ld WebCore
1168             Undefined symbols for architecture armv7s:
1169               "__ZN3JSC10IdentifierC1EPNS_9ExecStateERKN3WTF12AtomicStringE", referenced from:
1170                   __ZN7WebCoreL24createAccelerationObjectEPKNS_16DeviceMotionData12AccelerationEPN3JSC9ExecStateE in JSDeviceMotionEventCustom.o
1171
1172         * bindings/js/JSDeviceMotionEventCustom.cpp: Include
1173         <runtime/IdentifierInlines.h> to define missing symbol.
1174
1175 2014-12-02  Dean Jackson  <dino@apple.com>
1176
1177         [Media] Audio content shouldn't have fullscreen buttons, even if in a video element
1178         https://bugs.webkit.org/show_bug.cgi?id=139200
1179         <rdar://problem/18914506>
1180
1181         Reviewed by Eric Carlson.
1182
1183         An audio-only resource, even if loaded into a <video> element, should not
1184         present the fullscreen or optimised fullscreen controls. This includes a
1185         MediaDocument, which is always a <video> element. We can detect this by
1186         examining the length of the videoTracks property as our content loads.
1187
1188         Test: media/audio-as-video-fullscreen.html
1189
1190         * Modules/mediacontrols/mediaControlsApple.js:
1191         (Controller): Initialize a hasVisualMedia to false.
1192         (Controller.prototype.handleReadyStateChange): If we see a videoTrack, hasVisualMedia is now true.
1193         (Controller.prototype.updateFullscreenButtons): Merge the updateFullscreenButton and
1194         updateOptimizedFullscreenButton methods into this single spot, and check for
1195         hasVisualMedia.
1196         (Controller.prototype.updateFullscreenButton): Deleted.
1197         (Controller.prototype.updateOptimizedFullscreenButton): Deleted.
1198
1199         * Modules/mediacontrols/mediaControlsBase.js: Do the same for the other ports.
1200
1201 2014-12-02  Dean Jackson  <dino@apple.com>
1202
1203         Missing support for innerHTML on SVGElement
1204         https://bugs.webkit.org/show_bug.cgi?id=136903
1205
1206         Unreviewed followup from r176630. Minor style nits that I missed in my review.
1207
1208         * dom/Element.h: Remove unnecessary parameter name.
1209         * html/parser/HTMLTreeBuilder.cpp: Whitespace cleanup.
1210         (WebCore::HTMLTreeBuilder::adjustedCurrentStackItem):
1211
1212 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1213
1214         [EFL] Add subtle crypto to the build system
1215         https://bugs.webkit.org/show_bug.cgi?id=138612
1216
1217         Reviewed by Csaba Osztrogonác.
1218
1219         It is obvious to make Efl use GnuTLS as well,
1220         and since there seems no reason why to separate
1221         Efl and Gtk implementations from each other, I
1222         also propose renaming the gtk directory and file
1223         suffixes to gnutls.
1224
1225         No new tests needed.
1226
1227         * PlatformEfl.cmake:
1228         * PlatformGTK.cmake:
1229         * crypto/gnutls/CryptoAlgorithmAES_CBCGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp.
1230         (WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
1231         (WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
1232         * crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmAES_KWGtk.cpp.
1233         (WebCore::CryptoAlgorithmAES_KW::platformEncrypt):
1234         (WebCore::CryptoAlgorithmAES_KW::platformDecrypt):
1235         * crypto/gnutls/CryptoAlgorithmHMACGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmHMACGtk.cpp.
1236         (WebCore::getGnutlsDigestAlgorithm):
1237         (WebCore::calculateSignature):
1238         (WebCore::CryptoAlgorithmHMAC::platformSign):
1239         (WebCore::CryptoAlgorithmHMAC::platformVerify):
1240         * crypto/gnutls/CryptoAlgorithmRSAES_PKCS1_v1_5GnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRSAES_PKCS1_v1_5Gtk.cpp.
1241         (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
1242         (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
1243         * crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRSASSA_PKCS1_v1_5Gtk.cpp.
1244         (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
1245         (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
1246         * crypto/gnutls/CryptoAlgorithmRSA_OAEPGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRSA_OAEPGtk.cpp.
1247         (WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
1248         (WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
1249         * crypto/gnutls/CryptoAlgorithmRegistryGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRegistryGtk.cpp.
1250         (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
1251         * crypto/gnutls/CryptoDigestGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoDigestGtk.cpp.
1252         (WebCore::CryptoDigest::CryptoDigest):
1253         (WebCore::CryptoDigest::~CryptoDigest):
1254         (WebCore::CryptoDigest::create):
1255         (WebCore::CryptoDigest::addBytes):
1256         (WebCore::CryptoDigest::computeHash):
1257         * crypto/gnutls/CryptoKeyRSAGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoKeyRSAGtk.cpp.
1258         (WebCore::CryptoKeyRSA::CryptoKeyRSA):
1259         (WebCore::CryptoKeyRSA::create):
1260         (WebCore::CryptoKeyRSA::~CryptoKeyRSA):
1261         (WebCore::CryptoKeyRSA::restrictToHash):
1262         (WebCore::CryptoKeyRSA::isRestrictedToHash):
1263         (WebCore::CryptoKeyRSA::keySizeInBits):
1264         (WebCore::CryptoKeyRSA::buildAlgorithmDescription):
1265         (WebCore::CryptoKeyRSA::exportData):
1266         (WebCore::CryptoKeyRSA::generatePair):
1267         * crypto/gnutls/SerializedCryptoKeyWrapGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/SerializedCryptoKeyWrapGtk.cpp.
1268         (WebCore::getDefaultWebCryptoMasterKey):
1269         (WebCore::wrapSerializedCryptoKey):
1270         (WebCore::unwrapSerializedCryptoKey):
1271         * crypto/keys/CryptoKeyRSA.h:
1272
1273 2014-12-02  Benjamin Poulain  <benjamin@webkit.org>
1274
1275         Little cleanup of the default stylesheet
1276         https://bugs.webkit.org/show_bug.cgi?id=139168
1277
1278         Reviewed by Antti Koivisto.
1279
1280         The default stylesheet has a lot of historical junk that need cleaning. This patch addresses
1281         only the bits that do not change behaviors and have positive perf and readability impact.
1282
1283         I have limited :matches() to attributes for now. The idea is to only target
1284         simple selectors that are not used for filtering by the collectors.
1285         We should eventually clean up more cases, one thing at a time.
1286
1287         Tests: fast/css/map-tag-default-display.html
1288                fast/selectors/map-tag-default-display.html
1289
1290         * css/html.css:
1291         (map): Deleted.
1292         map was explicitely setting its display to inline. Remove that since it is the default.
1293
1294         (head): Deleted.
1295         (meta): Deleted.
1296         (title): Deleted.
1297         (link): Deleted.
1298         (style): Deleted.
1299         (script): Deleted.
1300         (div): Deleted.
1301         (layer): Deleted.
1302         (article, aside, footer, header, hgroup, main, nav, section): Deleted.
1303         (address): Deleted.
1304         (head, link, meta, script, style, title):
1305         (address, article, aside, div, footer, header, hgroup, layer, main, nav, section):
1306         Group the standard blocks in a single rule.
1307
1308         (input:matches([type="hidden"], [type="image"], [type="file"])):
1309         (input:matches([type="radio"], [type="checkbox"])):
1310         (input:matches([type="button"], [type="submit"], [type="reset"])):
1311         (input:matches([type="button"], [type="submit"], [type="reset"]), input[type="file"]::-webkit-file-upload-button, button):
1312         (input:matches([type="button"], [type="submit"], [type="reset"]):active, input[type="file"]::-webkit-file-upload-button:active, button:active):
1313         (input:matches([type="button"], [type="submit"], [type="reset"]):active, input[type="file"]:active::-webkit-file-upload-button, button:active):
1314         (input[type="file"]:active:disabled::-webkit-file-upload-button, button:active:disabled):
1315         (input:matches([type="checkbox"], [type="radio"]):checked):
1316         (input:matches([type="checkbox"], [type="radio"]):checked:disabled):
1317         (select:matches([size], [multiple], [size][multiple])):
1318         (select:matches([size="0"], [size="1"])):
1319         (input[type="hidden"], input[type="image"], input[type="file"]): Deleted.
1320         (input[type="radio"], input[type="checkbox"]): Deleted.
1321         (input[type="button"], input[type="submit"], input[type="reset"]): Deleted.
1322         (input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button): Deleted.
1323         (input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active, input[type="file"]::-webkit-file-upload-button:active, button:active): Deleted.
1324         (input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active, input[type="file"]:active::-webkit-file-upload-button, button:active): Deleted.
1325         (input[type="button"]:active:disabled, input[type="submit"]:active:disabled, input[type="reset"]:active:disabled, input[type="file"]:active:disabled::-webkit-file-upload-button, button:active:disabled): Deleted.
1326         (input[type="checkbox"]:checked, input[type="radio"]:checked): Deleted.
1327         (input[type="checkbox"]:checked:disabled, input[type="radio"]:checked:disabled): Deleted.
1328         (select[size][multiple]): Deleted.
1329         (select[size="1"]): Deleted.
1330         Group every selector lists that only differentiates complex selectors through attributes
1331         into a simple complex selector with :matches().
1332
1333 2014-12-02  Mark Lam  <mark.lam@apple.com>
1334
1335         Rolling out r176592, r176603, r176616, and r176705 until build and perf issues are resolved.
1336         https://bugs.webkit.org/show_bug.cgi?id=138821
1337
1338         Not reviewed.
1339
1340         * bindings/js/SerializedScriptValue.cpp:
1341         (WebCore::CloneDeserializer::deserializeString):
1342         * editing/TextIterator.cpp:
1343         (WebCore::SearchBuffer::isBadMatch):
1344         * page/mac/ServicesOverlayController.mm:
1345         (WebCore::ServicesOverlayController::buildSelectionHighlight):
1346         * platform/graphics/SegmentedFontData.cpp:
1347         (WebCore::SegmentedFontData::fontDataForCharacter):
1348         (WebCore::SegmentedFontData::containsCharacter):
1349         (WebCore::SegmentedFontData::isLoading):
1350         * platform/graphics/WOFFFileFormat.cpp:
1351         (WebCore::convertWOFFToSfnt):
1352         * platform/graphics/cairo/GradientCairo.cpp:
1353         (WebCore::Gradient::platformGradient):
1354         * platform/image-decoders/gif/GIFImageDecoder.cpp:
1355         (WebCore::GIFImageDecoder::clearFrameBufferCache):
1356         * rendering/RenderBox.cpp:
1357         (WebCore::RenderBox::paintFillLayers):
1358         * rendering/style/GridResolvedPosition.cpp:
1359         (WebCore::firstNamedGridLineBeforePosition):
1360         (WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
1361         * svg/SVGFontElement.cpp:
1362         (WebCore::kerningForPairOfStringsAndGlyphs):
1363         * svg/SVGPathByteStream.h:
1364         (WebCore::SVGPathByteStream::append):
1365         * xml/XPathNodeSet.h:
1366         (WebCore::XPath::NodeSet::begin):
1367         (WebCore::XPath::NodeSet::end):
1368
1369 2014-12-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1370
1371         Fix build break EFL port since r176696
1372         https://bugs.webkit.org/show_bug.cgi?id=139215
1373
1374         Unreviewed, build fix for EFL port.
1375
1376         * storage/StorageNamespaceProvider.h: Include SecurityOriginHash.h from WebCore/page directory.
1377
1378 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
1379
1380         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
1381         https://bugs.webkit.org/show_bug.cgi?id=139005
1382
1383         Reviewed by Chris Fleizach.
1384
1385         Expose table captions and rows via ATK. Accomplishing the former is done
1386         by role mapping and inclusion of the object as a child of the table for
1387         ATK. Accomplishing the latter was mostly a matter of deleting all the ATK
1388         platform code that had been forcing rows to be ignored. Because captions
1389         are not being exposed on the Mac, they are now explicitly being ignored
1390         for that platform.
1391
1392         Tests: accessibility/aria-table-hierarchy.html
1393                accessibility/table-hierarchy.html
1394
1395         * accessibility/AccessibilityObject.h:
1396         * accessibility/AccessibilityRenderObject.cpp:
1397         (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Added CaptionRole.
1398         * accessibility/AccessibilityTable.cpp:
1399         (WebCore::AccessibilityTable::addChildren): Include non-ignored captions as table children.
1400         * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
1401         (webkitAccessibleGetNChildren): Removed special handling for tables.
1402         (webkitAccessibleRefChild): Removed special handling for tables.
1403         (webkitAccessibleGetIndexInParent): Removed special handling for table cells.
1404         (atkRole): Corrected broken mapping for RowRole.
1405         (getNChildrenForTable): Deleted.
1406         (getChildForTable): Deleted.
1407         (getIndexInParentForCellInRow): Deleted.
1408         * accessibility/mac/AccessibilityObjectMac.mm:
1409         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore captions as table children.
1410
1411 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1412
1413         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1414         https://bugs.webkit.org/show_bug.cgi?id=139149
1415
1416         Reviewed by Anders Carlsson.
1417
1418         * WebCore.exp.in: Added ApplicationCache::deleteAllCaches.
1419
1420         * loader/appcache/ApplicationCache.h:
1421         * loader/appcache/ApplicationCache.cpp:
1422         (WebCore::ApplicationCache::deleteAllCaches): Added.
1423
1424         * loader/appcache/ApplicationCacheStorage.cpp:
1425         (WebCore::ApplicationCacheStorage::getManifestURLs): Removed logging. It is OK to
1426         have this function called when there is no database file.
1427
1428         * loader/appcache/ApplicationCacheStorage.h: Renamed manifestURLs to getManifestURLs,
1429         because WebKit style.
1430
1431 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1432
1433         Remove a SnowLeopard-era quirk for QuickLook
1434         https://bugs.webkit.org/show_bug.cgi?id=139208
1435         <rdar://problem/19121822>
1436
1437         Reviewed by Alexey Proskuryakov.
1438
1439         * WebCore.exp.in:
1440         * WebCore.xcodeproj/project.pbxproj:
1441         * loader/EmptyClients.h:
1442         * loader/FrameLoader.cpp:
1443         (WebCore::FrameLoader::subresourceCachePolicy):
1444         * loader/FrameLoaderClient.h:
1445         * platform/mac/QuickLookMac.h: Removed.
1446         * platform/mac/QuickLookMac.mm: Removed.
1447
1448 2014-12-02  Anders Carlsson  <andersca@apple.com>
1449
1450         Begin stubbing out a StorageNamespaceProvider class
1451         https://bugs.webkit.org/show_bug.cgi?id=139203
1452
1453         Reviewed by Tim Horton.
1454
1455         * CMakeLists.txt:
1456         * WebCore.vcxproj/WebCore.vcxproj:
1457         * WebCore.vcxproj/WebCore.vcxproj.filters:
1458         * WebCore.xcodeproj/project.pbxproj:
1459         Add new files.
1460
1461         * page/DOMWindow.cpp:
1462         (WebCore::DOMWindow::localStorage):
1463         If the page has a storage namespace provider, get the local storage from it.
1464
1465         * page/Page.cpp:
1466         (WebCore::Page::Page):
1467         Move the storage namespace provider from the configuration.
1468
1469         (WebCore::Page::setStorageNamespaceProvider):
1470         Add a setter. This will be used by setGroupName.
1471
1472         * page/Page.h:
1473         (WebCore::Page::storageNamespaceProvider):
1474         Add a getter.
1475
1476         * page/PageConfiguration.cpp:
1477         * page/PageConfiguration.h:
1478         Add a storage namespace provider member.
1479
1480         * storage/StorageNamespaceProvider.cpp:
1481         (WebCore::StorageNamespaceProvider::StorageNamespaceProvider):
1482         (WebCore::StorageNamespaceProvider::~StorageNamespaceProvider):
1483         (WebCore::StorageNamespaceProvider::addPage):
1484         (WebCore::StorageNamespaceProvider::removePage):
1485         (WebCore::StorageNamespaceProvider::localStorageNamespace):
1486         (WebCore::StorageNamespaceProvider::transientLocalStorageNamespace):
1487         * storage/StorageNamespaceProvider.h:
1488         Stub out a storage namespace provider class.
1489
1490 2014-12-02  Beth Dakin  <bdakin@apple.com>
1491
1492         More build fixing.
1493
1494         * platform/spi/mac/QuickLookMacSPI.h:
1495
1496 2014-12-02  Beth Dakin  <bdakin@apple.com>
1497
1498         Another build fix.
1499
1500         * platform/spi/mac/NSMenuSPI.h:
1501
1502 2014-12-02  Beth Dakin  <bdakin@apple.com>
1503
1504         Speculative build fix.
1505
1506         * platform/spi/mac/QuickLookMacSPI.h:
1507
1508 2014-12-02  Beth Dakin  <bdakin@apple.com>
1509
1510         Speculative build fix.
1511
1512         * platform/spi/mac/QuickLookMacSPI.h:
1513
1514 2014-12-02  Eric Carlson  <eric.carlson@apple.com>
1515
1516         Unreviewed, fix typo introduced in r176673.
1517
1518         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
1519         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
1520
1521 2014-12-02  Beth Dakin  <bdakin@apple.com>
1522
1523         Should use standardQuickLookMenuItem for apps that don't implement customizations
1524         https://bugs.webkit.org/show_bug.cgi?id=139193
1525         -and corresponding-
1526         rdar://problem/18944696
1527
1528         Reviewed by Anders Carlsson.
1529
1530         New SPI headers.
1531         * WebCore.xcodeproj/project.pbxproj:
1532         * platform/spi/mac/NSMenuSPI.h: Added.
1533         * platform/spi/mac/QuickLookMacSPI.h: Added.
1534
1535 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
1536
1537         Generalize PageActivityAssertionToken
1538         https://bugs.webkit.org/show_bug.cgi?id=139106
1539
1540         Reviewed by Sam Weinig.
1541
1542         PageActivityAssertionToken is a RAII mechanism implementing a counter, used by PageThrottler
1543         to count user visible activity in progress on the page (currently page load and media playback).
1544         Use of an RAII type is prevents a number of possible errors, including double counting a single
1545         media element, or failing to decrement the count after a media element has been deallocated.
1546
1547         The current implementation has a number of drawbacks that have been addressed by this refactoring:
1548          - specific to single use in PageThrottler class - not reusable.
1549          - incomplete encapsulation - the counter and WeakPtrFactory that comprise the current implementation
1550            are not encapsulated (are in the client type, PageThrottler).
1551          - tokens are not shared - PageActivityAssertionToken instances are managed by std::unique, every
1552            increment requires an object allocation.
1553          - redundancy - the current implementation uses a WeakPtr to safely reference the PageThrottler, this
1554            is internally implemented using a reference counted type, resulting in two counters being
1555            incremented (one in the PageActivityAssertionToken, one in the PageThrottler).
1556
1557         In the reimplementation:
1558          - a callback is provided via a lambda function, which allows for easy reuse without a lot of
1559            boilerplate code.
1560          - the counter, callback and ownership of the otherwise weakly-owned token is encapsulated within the
1561            RefCounter type.
1562          - a single count within RefCounter::Count stores the counter value, and also manage the lifetime
1563            of this object.
1564          - standard RefPtrs are used to manage references to the RefCounter::Count.
1565
1566         * WebCore.xcodeproj/project.pbxproj:
1567             - removed PageActivityAssertionToken.cpp/.h
1568         * html/HTMLMediaElement.cpp:
1569             - removed PageActivityAssertionToken.h
1570         * html/HTMLMediaElement.h:
1571             - std::unique_ptr<PageActivityAssertionToken> -> RefPtr<RefCounter::Count>
1572         * loader/FrameLoader.cpp:
1573             - removed PageActivityAssertionToken.h
1574         * loader/FrameLoader.h:
1575             - std::unique_ptr<PageActivityAssertionToken> -> RefPtr<RefCounter::Count>
1576         * loader/SubresourceLoader.cpp:
1577             - removed PageActivityAssertionToken.h
1578         * loader/SubresourceLoader.h:
1579             - removed class PageActivityAssertionToken
1580         * page/Page.cpp:
1581             - removed PageActivityAssertionToken.h
1582         (WebCore::Page::Page):
1583             - removed Page* parameter to PageThrottler
1584         * page/Page.h:
1585             - removed class PageActivityAssertionToken
1586         * page/PageActivityAssertionToken.cpp: Removed.
1587         * page/PageActivityAssertionToken.h: Removed.
1588             - removed PageActivityAssertionToken.cpp/.h
1589         * page/PageThrottler.cpp:
1590         (WebCore::PageThrottler::PageThrottler):
1591             - removed m_page, m_weakPtrFactory, m_activityCount; added m_pageActivityCounter.
1592         (WebCore::PageThrottler::mediaActivityToken):
1593             - std::unique_ptr<PageActivityAssertionToken> -> PassRefPtr<RefCounter::Count>
1594         (WebCore::PageThrottler::pageLoadActivityToken):
1595             - std::unique_ptr<PageActivityAssertionToken> -> PassRefPtr<RefCounter::Count>
1596         (WebCore::PageThrottler::pageActivityCounterValueDidChange):
1597             - merged functionality of incrementActivityCount/decrementActivityCount
1598         (WebCore::PageThrottler::incrementActivityCount): Deleted.
1599             - see pageActivityCounterValueDidChange
1600         (WebCore::PageThrottler::decrementActivityCount): Deleted.
1601             - see pageActivityCounterValueDidChange
1602         * page/PageThrottler.h:
1603         (WebCore::PageThrottler::weakPtr): Deleted.
1604             - no longer required; this functionality is now encapsulated within RefCounter.
1605
1606 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1607
1608         Always show the arrow for text selection services
1609         https://bugs.webkit.org/show_bug.cgi?id=139191
1610         <rdar://problem/18903995>
1611
1612         Reviewed by Anders Carlsson.
1613
1614         * platform/spi/mac/DataDetectorsSPI.h:
1615         * page/mac/ServicesOverlayController.mm:
1616         Move a few things to DataDetectorsSPI.h.
1617
1618         (WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
1619         (WebCore::ServicesOverlayController::buildSelectionHighlight):
1620         Make use of the real DDHighlightStyle names.
1621         Add DDHighlightStyleButtonShowAlways for selection services.
1622
1623 2014-12-02  Anders Carlsson  <andersca@apple.com>
1624
1625         Fix iOS build.
1626
1627         * WebCore.exp.in:
1628
1629 2014-12-02  Chris Dumez  <cdumez@apple.com>
1630
1631         Crash when setting 'flex' CSS property to 'calc(2 * 3) calc(2 * 3)'
1632         https://bugs.webkit.org/show_bug.cgi?id=139162
1633
1634         Reviewed by Darin Adler.
1635
1636         Add support for calculated values in 'flex' CSS property.
1637         Previously, those did not work in release builds, and were hitting
1638         an assertion in debug builds.
1639
1640         Test: fast/css/flex-calculated-value.html
1641
1642         * css/CSSParser.cpp:
1643         (WebCore::CSSParser::validCalculationUnit):
1644         Do not call RefPtr::release() as we are not interested in the return
1645         value. Assign nullptr to the member instead.
1646
1647         (WebCore::CSSParser::parseValue):
1648         (WebCore::CSSParser::parseFillPositionComponent):
1649         (WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
1650         (WebCore::CSSParser::parseFontWeight):
1651         (WebCore::CSSParser::parsedDouble):
1652         (WebCore::CSSParser::colorIntFromValue):
1653         (WebCore::CSSParser::parseColorParameters):
1654         (WebCore::CSSParser::parseHSLParameters):
1655         (WebCore::CSSParser::parseFlex):
1656         * css/CSSParser.h:
1657
1658 2014-12-02  Eric Carlson  <eric.carlson@apple.com>
1659
1660         Fix logging typo
1661         https://bugs.webkit.org/show_bug.cgi?id=139182
1662
1663         Reviewed by Alexey Proskuryakov.
1664
1665         No new tests, only logging code is changed.
1666
1667         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
1668         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Don't use %f to log a string.
1669
1670 2014-12-02  Anders Carlsson  <andersca@apple.com>
1671
1672         Get rid of the WinINet based network implementation
1673         https://bugs.webkit.org/show_bug.cgi?id=139187
1674
1675         Reviewed by Andreas Kling.
1676
1677         This code was only used by the Windows CE port. Now it's unused.
1678
1679         * platform/network/ResourceHandle.h:
1680         * platform/network/ResourceHandleInternal.h:
1681         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1682         * platform/network/win/AuthenticationChallenge.h: Removed.
1683         * platform/network/win/CookieJarWin.cpp: Removed.
1684         * platform/network/win/CredentialStorageWin.cpp: Removed.
1685         * platform/network/win/ProxyServerWin.cpp: Removed.
1686         * platform/network/win/ResourceError.h: Removed.
1687         * platform/network/win/ResourceHandleWin.cpp: Removed.
1688         * platform/network/win/ResourceRequest.h: Removed.
1689         * platform/network/win/ResourceResponse.h: Removed.
1690         * platform/network/win/SocketStreamError.h: Removed.
1691         * platform/network/win/SocketStreamHandle.h: Removed.
1692         * platform/network/win/SocketStreamHandleWin.cpp: Removed.
1693
1694 2014-12-02  Chris Dumez  <cdumez@apple.com>
1695
1696         Crash when setting 'column-span' CSS property to 'calc(2 * 3)'
1697         https://bugs.webkit.org/show_bug.cgi?id=139170
1698
1699         Reviewed by Darin Adler.
1700
1701         Add support for calculated values for 'column-span' and 'column-width'
1702         CSS properties. Previously, these were not working in release builds
1703         and hitting assertions in debug builds.
1704
1705         Tests: fast/css/column-width-calculated-value.html
1706                fast/css/webkit-column-span-calculated-value.html
1707
1708         * css/CSSParser.cpp:
1709         (WebCore::CSSParser::parseValue):
1710
1711 2014-12-02  Anders Carlsson  <andersca@apple.com>
1712
1713         Remove visited link handling from PageGroup
1714         https://bugs.webkit.org/show_bug.cgi?id=139185
1715
1716         Reviewed by Sam Weinig.
1717
1718         * CMakeLists.txt:
1719         * WebCore.exp.in:
1720         * WebCore.vcxproj/WebCore.vcxproj:
1721         * WebCore.vcxproj/WebCore.vcxproj.filters:
1722         * WebCore.xcodeproj/project.pbxproj:
1723         * loader/HistoryController.cpp:
1724         * page/Chrome.cpp:
1725         (WebCore::ChromeClient::populateVisitedLinks): Deleted.
1726         * page/ChromeClient.h:
1727         * page/DefaultVisitedLinkStore.cpp: Removed.
1728         * page/DefaultVisitedLinkStore.h: Removed.
1729         * page/Page.cpp:
1730         (WebCore::Page::Page):
1731         (WebCore::Page::~Page):
1732         (WebCore::Page::visitedLinkStore):
1733         (WebCore::Page::setVisitedLinkStore):
1734         (WebCore::Page::removeAllVisitedLinks): Deleted.
1735         * page/Page.h:
1736         * page/PageGroup.cpp:
1737         (WebCore::PageGroup::PageGroup):
1738         (WebCore::PageGroup::visitedLinkStore): Deleted.
1739         (WebCore::PageGroup::isLinkVisited): Deleted.
1740         (WebCore::PageGroup::addVisitedLinkHash): Deleted.
1741         (WebCore::PageGroup::addVisitedLink): Deleted.
1742         (WebCore::PageGroup::removeVisitedLink): Deleted.
1743         (WebCore::PageGroup::removeVisitedLinks): Deleted.
1744         (WebCore::PageGroup::removeAllVisitedLinks): Deleted.
1745         (WebCore::PageGroup::setShouldTrackVisitedLinks): Deleted.
1746         * page/PageGroup.h:
1747
1748 2014-12-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1749
1750         Use references instead of pointers in EditingStyle
1751         https://bugs.webkit.org/show_bug.cgi?id=137918
1752
1753         Reviewed by Darin Adler.
1754
1755         * editing/EditingStyle.cpp:
1756         (WebCore::extractPropertyValue):
1757         (WebCore::identifierForStyleProperty):
1758         (WebCore::textColorFromStyle):
1759         (WebCore::backgroundColorFromStyle):
1760         (WebCore::textAlignResolvingStartAndEnd):
1761         (WebCore::EditingStyle::triStateOfStyle):
1762         (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
1763         (WebCore::EditingStyle::prepareToApplyAt):
1764         (WebCore::EditingStyle::removeStyleFromRulesAndContext):
1765         (WebCore::StyleChange::StyleChange):
1766         (WebCore::setTextDecorationProperty):
1767         (WebCore::StyleChange::extractTextStyles):
1768         (WebCore::diffTextDecorations):
1769         (WebCore::fontWeightIsBold):
1770         (WebCore::extractPropertiesNotIn):
1771         (WebCore::getPropertiesNotIn):
1772         * editing/EditingStyle.h:
1773
1774 2014-12-02  Bartlomiej Gajda  <b.gajda@samsung.com>
1775
1776         [GStreamer] Media Source sending seek event fails.
1777         https://bugs.webkit.org/show_bug.cgi?id=139181
1778
1779         Reviewed by Philippe Normand.
1780
1781         There were callbacks connected to app_src on 'seek', but if stream type is not seekable, they would never launch,
1782         and seeking (as in MediaPlayerPrivateGStreamer::doSeek) fails.
1783
1784         No new tests needed.
1785
1786         * platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
1787         (webkit_media_src_init):
1788
1789 2014-12-02  Chris Dumez  <cdumez@apple.com>
1790
1791         Move 'font-family' CSS property to the new StyleBuilder
1792         https://bugs.webkit.org/show_bug.cgi?id=139172
1793
1794         Reviewed by Antti Koivisto.
1795
1796         Move 'font-family' CSS property to the new StyleBuilder by using
1797         custom code.
1798
1799         No new tests, no behavior change.
1800
1801         * css/CSSPropertyNames.in:
1802         * css/DeprecatedStyleBuilder.cpp:
1803         (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
1804         (WebCore::ApplyPropertyFontFamily::applyInheritValue): Deleted.
1805         (WebCore::ApplyPropertyFontFamily::applyInitialValue): Deleted.
1806         (WebCore::ApplyPropertyFontFamily::applyValue): Deleted.
1807         (WebCore::ApplyPropertyFontFamily::createHandler): Deleted.
1808         * css/StyleBuilderCustom.h:
1809         (WebCore::StyleBuilderCustom::applyInitialFontFamily):
1810         (WebCore::StyleBuilderCustom::applyInheritFontFamily):
1811         (WebCore::StyleBuilderCustom::applyValueFontFamily):
1812
1813 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1814
1815         Fix class was previously declared as a struct warnings
1816         https://bugs.webkit.org/show_bug.cgi?id=139131
1817
1818         Reviewed by Csaba Osztrogonác.
1819
1820         No new tests needed.
1821
1822         * platform/graphics/texmap/TextureMapperGL.h:
1823
1824 2014-12-02  Sylvain Galineau  <galineau@adobe.com>
1825
1826         Missing support for innerHTML on SVGElement
1827         https://bugs.webkit.org/show_bug.cgi?id=136903
1828
1829         Reviewed by Dean Jackson.
1830
1831         Two parts to this patch:
1832         1. Move innerHTML/outerHTML to Element so SVG elements can inherit them, per https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#innerhtml
1833         2. Make sure fragment insertion is processed relative to the proper node, per http://www.whatwg.org/specs/web-apps/current-work/#adjusted-current-node
1834
1835         The latter part was ported over from Blink. 
1836
1837         Test: svg/in-html/svg-inner-html.html
1838
1839         * bindings/objc/PublicDOMInterfaces.h: Move innerHTML/outerHTML to Element.
1840         * dom/Element.cpp:
1841         (WebCore::Element::mergeWithNextTextNode): Helper used by Element::innerHTML/outerHTML as well as HTMLElement::innerText/outerText; moved to Element as protected static.
1842         (WebCore::Element::innerHTML): Moved from HTMLElement.
1843         (WebCore::Element::outerHTML): Moved from HTMLElement.
1844         (WebCore::Element::setOuterHTML): Moved from HTMLElement.
1845         (WebCore::Element::setInnerHTML): Moved from HTMLElement.
1846         * dom/Element.h: 
1847         * dom/Element.idl:
1848         * html/HTMLElement.cpp:
1849         (WebCore::HTMLElement::innerHTML): Deleted.
1850         (WebCore::HTMLElement::outerHTML): Deleted.
1851         (WebCore::HTMLElement::setInnerHTML): Deleted.
1852         (WebCore::mergeWithNextTextNode): Deleted.
1853         (WebCore::HTMLElement::setOuterHTML): Deleted.
1854         * html/HTMLElement.h:
1855         * html/HTMLElement.idl:
1856         * html/parser/HTMLTreeBuilder.cpp:
1857         (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): no more m_contextElement.
1858         (WebCore::HTMLTreeBuilder::constructTree): read namespace from adjusted current node.
1859         (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): use contextElementStackItem for insertion.
1860         (WebCore::HTMLTreeBuilder::adjustedCurrentStackItem): compute adjusted current node.
1861         (WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent): use adjusted current node for context.
1862         (WebCore::HTMLTreeBuilder::processTokenInForeignContent): use adjusted current node to read namespace.
1863         * html/parser/HTMLTreeBuilder.h:
1864         (WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): Deleted. Read from contextElementStackItem.
1865         (WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElementStackItem): Added.
1866
1867 2014-11-20  Jeffrey Pfau  <jpfau@apple.com>
1868
1869         Add cancelable version of willSendRequest
1870         https://bugs.webkit.org/show_bug.cgi?id=138987
1871
1872         Reviewed by Anders Carlsson.
1873
1874         Covered by existing tests.
1875
1876         * loader/ResourceLoader.cpp:
1877         (WebCore::ResourceLoader::willSendRequest):
1878         * loader/ResourceLoader.h:
1879
1880 2014-12-01  Benjamin Poulain  <benjamin@webkit.org>
1881
1882         Add the dynamic specificity of the selector list argument when matching :nth-child() and :nth-last-child()
1883         https://bugs.webkit.org/show_bug.cgi?id=139001
1884
1885         Reviewed by Andreas Kling.
1886
1887         When matching :nth-child(An+B of selector list) or :nth-last-child(An+B of selector list),
1888         we were previously ignoring the arguments.
1889
1890         That behavior seems to be confusing for users. We made the proposal to include the selector list
1891         like when using :matches():
1892             http://lists.w3.org/Archives/Public/www-style/2014Oct/0533.html
1893         David Baron also agrees with this behavior:
1894             http://lists.w3.org/Archives/Public/www-style/2014Oct/0534.html
1895
1896         This patch adds the specificity computation.
1897
1898         Tests: fast/css/nth-child-specificity-1.html
1899                fast/css/nth-child-specificity-2.html
1900                fast/css/nth-last-child-specificity-1.html
1901                fast/css/nth-last-child-specificity-2.html
1902
1903         * css/CSSSelector.cpp:
1904         (WebCore::simpleSelectorFunctionalPseudoClassStaticSpecificity):
1905         * css/SelectorChecker.cpp:
1906         (WebCore::SelectorChecker::checkOne):
1907         (WebCore::SelectorChecker::matchSelectorList):
1908         * css/SelectorChecker.h:
1909         * cssjit/SelectorCompiler.cpp:
1910         (WebCore::SelectorCompiler::addPseudoClassType):
1911
1912 2014-12-01  Chris Dumez  <cdumez@apple.com>
1913
1914         Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder
1915         https://bugs.webkit.org/show_bug.cgi?id=138938
1916
1917         Reviewed by Sam Weinig.
1918
1919         Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' CSS properties
1920         from StyleResolver to the new StyleBuilder by using custom code.
1921
1922         No new tests, no behavior change.
1923
1924         * css/CSSPropertyNames.in:
1925         * css/StyleBuilderCustom.h:
1926         (WebCore::StyleBuilderCustom::applyTextOrBoxShadowValue):
1927         (WebCore::StyleBuilderCustom::applyInitialTextShadow):
1928         (WebCore::StyleBuilderCustom::applyInheritTextShadow):
1929         (WebCore::StyleBuilderCustom::applyValueTextShadow):
1930         (WebCore::StyleBuilderCustom::applyInitialBoxShadow):
1931         (WebCore::StyleBuilderCustom::applyInheritBoxShadow):
1932         (WebCore::StyleBuilderCustom::applyValueBoxShadow):
1933         (WebCore::StyleBuilderCustom::applyInitialWebkitBoxShadow):
1934         (WebCore::StyleBuilderCustom::applyInheritWebkitBoxShadow):
1935         (WebCore::StyleBuilderCustom::applyValueWebkitBoxShadow):
1936         * css/StyleResolver.cpp:
1937         (WebCore::StyleResolver::applyProperty):
1938
1939 2014-12-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1940
1941         [EFL] Add a ENABLE_CSS_SCROLL_SNAP macro to CMake build system
1942         https://bugs.webkit.org/show_bug.cgi?id=139085
1943
1944         Reviewed by Andreas Kling.
1945
1946         * PlatformEfl.cmake: 
1947             Include page/scrolling/AxisScrollSnapOffsets.cpp to EFL build files to fix build break.
1948
1949 2014-12-01  Zalan Bujtas  <zalan@apple.com>
1950
1951         Twitter avatar moves when hovering/unhovering the "follow" button.
1952         https://bugs.webkit.org/show_bug.cgi?id=139147
1953         rdar://problem/19096508
1954
1955         Reviewed by Simon Fraser.
1956
1957         This patch ensures that the out of flow positioned render boxes (RenderReplaced) do not
1958         get repositioned when their inline box wrappers move.
1959         Ideally, out of flow positioned renderers do not have inline wrappers by the time we start
1960         placing inline boxes, but in certain case (optimized code path for descendantsHaveSameLineHeightAndBaseline()),
1961         they are still part of the inline box tree.
1962         This patch prevents those renderer boxes from getting positioned as part of the inline box placement.
1963         They will get removed later at RenderBlockFlow::computeBlockDirectionPositionsForLine().
1964
1965         Test: fast/inline/out-of-flow-positioned-render-replaced-box-moves.html
1966
1967         * rendering/InlineBox.cpp:
1968         (WebCore::InlineBox::adjustPosition):
1969
1970 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1971
1972         Null deref under TextIndicator::createWithSelectionInFrame using find-in-page on bugzilla
1973         https://bugs.webkit.org/show_bug.cgi?id=139164
1974         <rdar://problem/19107247>
1975
1976         Reviewed by Beth Dakin.
1977
1978         * page/TextIndicator.cpp:
1979         (WebCore::TextIndicator::createWithSelectionInFrame):
1980         Null-check the ImageBuffer in addition to the Image.
1981
1982 2014-12-01  Anders Carlsson  <andersca@apple.com>
1983
1984         Remove IWebCookieManager on Windows
1985         https://bugs.webkit.org/show_bug.cgi?id=139144
1986
1987         Reviewed by Sam Weinig.
1988
1989         Remove code that handles overriding the cookie storage.
1990
1991         * platform/network/NetworkStorageSession.h:
1992         * platform/network/cf/NetworkStorageSessionCFNet.cpp:
1993         (WebCore::cookieStorageOverride): Deleted.
1994         (WebCore::overrideCookieStorage): Deleted.
1995         (WebCore::overridenCookieStorage): Deleted.
1996         * platform/network/cf/ResourceHandleCFNet.cpp:
1997         (WebCore::ResourceHandle::createCFURLConnection):
1998
1999 2014-12-01  Dean Jackson  <dino@apple.com>
2000
2001         [iOS Media] Slider knob should not have a border
2002         https://bugs.webkit.org/show_bug.cgi?id=139160
2003         <rdar://problem/19075185>
2004
2005         Reviewed by Jer Noble.
2006
2007         The change in r175715 required adding !important to a bunch
2008         of rules for pseudo elements. The border width of slider knobs
2009         for media controls should be zero, so add an !important there.
2010
2011         * Modules/mediacontrols/mediaControlsiOS.css:
2012         (audio::-webkit-media-controls-timeline::-webkit-slider-thumb): Change
2013         border to border-width and force it to zero.
2014
2015 2014-12-01  Chris Dumez  <cdumez@apple.com>
2016
2017         Take into consideration canvas drawing for throttling DOM timers
2018         https://bugs.webkit.org/show_bug.cgi?id=139140
2019         <rdar://problem/19102218>
2020
2021         Reviewed by Andreas Kling.
2022
2023         Take into consideration canvas drawing for throttling DOM timers so
2024         that:
2025         - Timers drawing on a visible canvas can no longer get throttled.
2026           This fixes the following sites:
2027           - http://hint.fm/wind/
2028           - http://radar.weather.gov/Conus/full_loop.php
2029         - Timers that are drawing on a canvas that is not user observable
2030           now get throttled, thus using less CPU. As an example, on
2031           http://hint.fm/wind/, CPU usage is at 110% when the canvas is
2032           inside the viewport on my machine. CPU usage would remain at
2033           110% when scrolling the canvas outside the viewport before this
2034           patch. After this patch, the CPU usage goes down to 5% when
2035           the canvas is outside the viewport.
2036
2037         Tests: fast/canvas/canvas-inside-viewport-timer-throttling.html
2038                fast/canvas/canvas-outside-viewport-timer-throttling.html
2039
2040         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
2041         (WebCore::JSCSSStyleDeclaration::putDelegate):
2042         * html/HTMLCanvasElement.cpp:
2043         (WebCore::HTMLCanvasElement::notifyObserversCanvasChanged):
2044         * page/DOMTimer.cpp:
2045         (WebCore::DOMTimerFireState::setScriptMadeNonUserObservableChangesToElement):
2046         (WebCore::DOMTimer::scriptDidCauseElementRepaint):
2047         (WebCore::DOMTimerFireState::setScriptMadeNonUserObservableChangesToElementStyle): Deleted.
2048         (WebCore::DOMTimer::scriptDidUpdateStyleOfElement): Deleted.
2049         * page/DOMTimer.h:
2050
2051 2014-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2052
2053         Crash in Font::dashesForIntersectionsWithRect() due to underlining SVG fonts
2054         https://bugs.webkit.org/show_bug.cgi?id=139158
2055
2056         Reviewed by Simon Fraser.
2057
2058         RenderingContexts are only created if the primary SimpleFontData is an SVG font,
2059         but dashesForIntersectionWithRect() uses the first character's SimpleFontData.
2060         One might be an SVG font but the other might not be.
2061
2062         Note that this brittle design will be fixed with the SVG -> OTF translator.
2063
2064         Test: fast/css3-text/css3-text-decoration/text-decoration-skip/decoration-skip-crash-fallback-svg.html
2065
2066         * platform/graphics/mac/FontMac.mm:
2067         (WebCore::Font::dashesForIntersectionsWithRect):
2068
2069 2014-12-01  Bartlomiej Gajda  <b.gajda@samsung.com>
2070
2071         [MSE] Fix not always calling mediaPlayer seek.
2072         https://bugs.webkit.org/show_bug.cgi?id=139139
2073
2074         Reviewed by Jer Noble.
2075
2076         Original comment states that media source shall always be notified of seek if it's not closed.
2077
2078         No new tests needed.
2079
2080         * html/HTMLMediaElement.cpp:
2081         (WebCore::HTMLMediaElement::seekTimerFired):
2082
2083 2014-12-01  Tim Horton  <timothy_horton@apple.com>
2084
2085         Implement yellow highlight for WebKit1 data detectors
2086         https://bugs.webkit.org/show_bug.cgi?id=138956
2087         <rdar://problem/18992185>
2088
2089         Reviewed by Beth Dakin.
2090
2091         * page/TextIndicator.cpp:
2092         (WebCore::TextIndicator::createWithSelectionInFrame):
2093         (WebCore::TextIndicator::TextIndicator):
2094         * page/TextIndicator.h:
2095         (WebCore::TextIndicator::selectionRectInScreenCoordinates):
2096         (WebCore::TextIndicator::textBoundingRectInScreenCoordinates):
2097         (WebCore::TextIndicator::selectionRectInWindowCoordinates): Deleted.
2098         (WebCore::TextIndicator::textBoundingRectInWindowCoordinates): Deleted.
2099         Store TextIndicator rects in screen coordinates, since that's what we
2100         want anyway, and this makes it easier to share this code between the WebKits.
2101
2102         * page/mac/TextIndicatorWindow.mm:
2103         (-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
2104         (WebCore::TextIndicatorWindow::setTextIndicator):
2105         Avoid some rect conversion because the TextIndicator rects are already in screen coordinates.
2106
2107 2014-12-01  Anders Carlsson  <andersca@apple.com>
2108
2109         Remove old site specific quirks code that was added in 2009
2110         https://bugs.webkit.org/show_bug.cgi?id=139141
2111
2112         Reviewed by Antti Koivisto.
2113
2114         * platform/network/NetworkingContext.h:
2115         * platform/network/ResourceHandleInternal.h:
2116         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2117         * platform/network/mac/ResourceHandleMac.mm:
2118         (WebCore::ResourceHandle::start):
2119
2120 2014-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2121
2122         Web Inspector: DOMExceptions do not show the error message string in Pause Reason section
2123         https://bugs.webkit.org/show_bug.cgi?id=138988
2124
2125         Reviewed by Timothy Hatcher.
2126
2127         * inspector/WebInjectedScriptHost.cpp:
2128         (WebCore::WebInjectedScriptHost::type):
2129         Give all DOM Exception types the "error" RemoteObject subtype.
2130
2131 2014-12-01  Bartlomiej Gajda  <b.gajda@samsung.com>
2132
2133         [MSE] Unset timestamps of trackbuffers during Reset Parser State algorithm.
2134         https://bugs.webkit.org/show_bug.cgi?id=139075.
2135
2136         Reviewed by Jer Noble.
2137
2138         Specification requires from us to unset timestamps for trackBuffers
2139         during abort() method.
2140
2141         Test: media/media-source/media-source-append-nonsync-sample-after-abort.html
2142
2143         * Modules/mediasource/SourceBuffer.cpp:
2144         (WebCore::SourceBuffer::resetParserState):
2145         (WebCore::SourceBuffer::abort):
2146         * Modules/mediasource/SourceBuffer.h:
2147
2148 2014-12-01  Chris Dumez  <cdumez@apple.com>
2149
2150         Transform StyleBuilderCustom into a class and mark it as a friend of RenderStyle
2151         https://bugs.webkit.org/show_bug.cgi?id=138999
2152
2153         Reviewed by Sam Weinig.
2154
2155         Transform StyleBuilderCustom into a class and mark it as a friend of
2156         RenderStyle. This is needed because some of the StyleBuilderCustom
2157         functions need to access RenderStyle's private API.
2158
2159         No new tests, no behavior change.
2160
2161         * css/StyleBuilderCustom.h:
2162           Move functions from StyleBuilderFunctions namespace to
2163           StyleBuilderCustom class.
2164
2165         * css/makeprop.pl:
2166           Use StyleBuilderCustom scope instead of StyleBuilderFunctions for
2167           custom implementation.
2168
2169         * rendering/style/RenderStyle.h:
2170           Mark StyleBuilderCustom class as a friend, similarly to what was
2171           already done for DeprecatedStyleBuilder and StyleResolver.
2172
2173 2014-11-17  Oliver Hunt  <oliver@apple.com>
2174
2175         Make sure range based iteration of Vector<> still receives bounds checking
2176         https://bugs.webkit.org/show_bug.cgi?id=138821
2177
2178         Reviewed by Mark Lam.
2179
2180         There are a few uses of begin()/end() that explicitly require pointers,
2181         so we use getPtr() to extract the underlying pointer generically.
2182
2183         * bindings/js/SerializedScriptValue.cpp:
2184         (WebCore::CloneDeserializer::deserializeString):
2185         * editing/TextIterator.cpp:
2186         (WebCore::SearchBuffer::isBadMatch):
2187         * page/mac/ServicesOverlayController.mm:
2188         (WebCore::ServicesOverlayController::buildSelectionHighlight):
2189         * platform/graphics/SegmentedFontData.cpp:
2190         (WebCore::SegmentedFontData::fontDataForCharacter):
2191         (WebCore::SegmentedFontData::containsCharacter):
2192         (WebCore::SegmentedFontData::isLoading):
2193         * platform/graphics/WOFFFileFormat.cpp:
2194         (WebCore::convertWOFFToSfnt):
2195         * rendering/RenderBox.cpp:
2196         (WebCore::RenderBox::paintFillLayers):
2197         * rendering/style/GridResolvedPosition.cpp:
2198         (WebCore::firstNamedGridLineBeforePosition):
2199         (WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
2200         * svg/SVGFontElement.cpp:
2201         (WebCore::kerningForPairOfStringsAndGlyphs):
2202         * svg/SVGPathByteStream.h:
2203         (WebCore::SVGPathByteStream::append):
2204         * xml/XPathNodeSet.h:
2205         (WebCore::XPath::NodeSet::begin):
2206         (WebCore::XPath::NodeSet::end):
2207
2208 2014-11-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2209
2210         Fix a build warning when CSS_SCROLL_SNAP is enabled
2211         https://bugs.webkit.org/show_bug.cgi?id=139084
2212
2213         Reviewed by Andrei Bucur.
2214
2215         Fix a build warning. Copy constructor of StyleScrollSnapPoints should initialize its base class.
2216
2217         * rendering/style/StyleScrollSnapPoints.cpp:
2218         (WebCore::StyleScrollSnapPoints::StyleScrollSnapPoints): Call RefCounted().
2219
2220 2014-11-29  Sam Weinig  <sam@webkit.org>
2221
2222         Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
2223         https://bugs.webkit.org/show_bug.cgi?id=139104
2224
2225         Reviewed by Anders Carlsson.
2226
2227         * css/CSSPropertyNames.in:
2228         * css/StyleBuilderCustom.h:
2229         (WebCore::StyleBuilderFunctions::applyValueWebkitLocale):
2230         (WebCore::StyleBuilderFunctions::applyValueWebkitWritingMode):
2231         (WebCore::StyleBuilderFunctions::applyValueWebkitTextOrientation):
2232         (WebCore::StyleBuilderFunctions::applyValueWebkitJustifySelf):
2233         (WebCore::StyleBuilderFunctions::applyValueWebkitPerspective):
2234         * css/StyleResolver.cpp:
2235         (WebCore::StyleResolver::applyProperty):
2236
2237 2014-11-29  Anders Carlsson  <andersca@apple.com>
2238
2239         Add an EmptyVisitedLinkStore implementation
2240         https://bugs.webkit.org/show_bug.cgi?id=139102
2241
2242         Reviewed by Sam Weinig.
2243
2244         * loader/EmptyClients.cpp:
2245         (WebCore::fillWithEmptyClients):
2246         * loader/EmptyClients.h:
2247
2248 2014-11-28  Sam Weinig  <sam@webkit.org>
2249
2250         Move the '-webkit-initial-letter', '-webkit-line-box-contain' and '-webkit-text-stroke-width' CSS properties to the new StyleBuilder
2251         https://bugs.webkit.org/show_bug.cgi?id=139053
2252
2253         Reviewed by Andreas Kling.
2254
2255         * css/CSSPropertyNames.in:
2256         * css/StyleBuilderConverter.h:
2257         (WebCore::StyleBuilderConverter::convertInitialLetter):
2258         (WebCore::StyleBuilderConverter::convertTextStrokeWidth):
2259         (WebCore::StyleBuilderConverter::convertLineBoxContain):
2260         * css/StyleResolver.cpp:
2261         (WebCore::StyleResolver::applyProperty):
2262
2263 2014-11-26  Philippe Normand  <pnormand@igalia.com>
2264
2265         [GStreamer] HTTP source element lacks SCHEDULING query support
2266         https://bugs.webkit.org/show_bug.cgi?id=139064
2267
2268         Reviewed by Carlos Garcia Campos.
2269
2270         No new tests, covered by http/tests/media/hls.
2271
2272         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
2273         (webKitWebSrcQueryWithParent): Make the element handle SCHEDULING
2274         queries with the BANDWIDTH_LIMITED flag. This helps uridecodebin
2275         to configure itself for adaptive streaming playback scenarios.
2276
2277 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
2278
2279         [EFL] Remove E_Dbus dependency
2280         https://bugs.webkit.org/show_bug.cgi?id=136355
2281
2282         Reviewed by Gyuyoung Kim.
2283
2284         E_Dbus is the simple wrapper of Dbus but it has not been maintained since EFL 1.8.
2285         Instead, EFL introduced Eldbus, which is almost similar with E_Dbus but provides more dbus like interface.
2286         This patch replaces E_Dbus implementation to Eldbus.
2287
2288         * PlatformEfl.cmake:
2289         * platform/efl/BatteryProviderEfl.cpp:
2290         (WebCore::BatteryProviderEfl::BatteryProviderEfl):
2291         (WebCore::BatteryProviderEfl::~BatteryProviderEfl):
2292         (WebCore::BatteryProviderEfl::stopUpdating):
2293         (WebCore::batteryProperties):
2294         (WebCore::batteryPropertiesChanged):
2295         (WebCore::BatteryProviderEfl::deviceTypeCallback):
2296         (WebCore::BatteryProviderEfl::enumerateDevices):
2297         (WebCore::BatteryProviderEfl::startUpdating):
2298         (WebCore::BatteryProviderEfl::setBatteryStatus):
2299         (WebCore::BatteryProviderEfl::timerFired): Deleted.
2300         (WebCore::BatteryProviderEfl::getBatteryStatus): Deleted.
2301         (WebCore::BatteryProviderEfl::setBatteryClient): Deleted.
2302         * platform/efl/BatteryProviderEfl.h:
2303         (WebCore::BatteryProviderEfl::connection):
2304         (WebCore::BatteryProviderEfl::setSignalHandler):
2305         (WebCore::BatteryProviderEfl::~BatteryProviderEfl): Deleted.
2306
2307 2014-11-27  Antti Koivisto  <antti@apple.com>
2308
2309         CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
2310         https://bugs.webkit.org/show_bug.cgi?id=139057
2311
2312         Reviewed by Anders Carlsson.
2313
2314         No test, don't know how to repro.
2315
2316         * html/HTMLPlugInImageElement.cpp:
2317         (WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.
2318
2319 2014-11-27  Joanmarie Diggs  <jdiggs@igalia.com>
2320
2321         AX: [ATK] Meter and Option elements do not expose their id attribute
2322         https://bugs.webkit.org/show_bug.cgi?id=139017
2323
2324         Reviewed by Mario Sanchez Prada.
2325
2326         The options in a collapsed select element lack a node, so get the id
2327         attribute from the associated action element. In the case of a meter,
2328         the meter element itself is not exposed; its RenderMeter is instead.
2329         So associate the meter element's id with the exposed RenderMeter.
2330
2331         No new tests. Instead, updated existing expectations to reflect the fix.
2332
2333         * accessibility/AccessibilityObject.h:
2334         * accessibility/AccessibilityProgressIndicator.cpp:
2335         (WebCore::AccessibilityProgressIndicator::element):
2336         * accessibility/AccessibilityProgressIndicator.h:
2337         * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
2338         (webkitAccessibleGetAttributes):
2339
2340 2014-11-27  Anders Carlsson  <andersca@apple.com>
2341
2342         Add a Page::setVisitedLinkStore member function
2343         https://bugs.webkit.org/show_bug.cgi?id=139065
2344
2345         Reviewed by Antti Koivisto.
2346
2347         This will be used in a subsequent commit.
2348
2349         * WebCore.exp.in:
2350         * page/Page.cpp:
2351         (WebCore::Page::setVisitedLinkStore):
2352         * page/Page.h:
2353
2354 2014-11-25  Sukolsak Sakshuwong  <sukolsak@gmail.com>
2355
2356         Add parsing for :dir()
2357         https://bugs.webkit.org/show_bug.cgi?id=138932
2358
2359         Reviewed by Benjamin Poulain.
2360
2361         Add support for parsing :dir() pseudo class. The implementation of selector
2362         matching will be in a follow-up patch.
2363
2364         * css/CSSGrammar.y.in:
2365         * css/CSSParser.cpp:
2366         (WebCore::CSSParser::detectFunctionTypeToken):
2367         * css/CSSSelector.cpp:
2368         (WebCore::appendPseudoClassFunctionTail):
2369         (WebCore::CSSSelector::selectorText):
2370         * css/CSSSelector.h:
2371         * css/SelectorChecker.cpp:
2372         (WebCore::SelectorChecker::checkOne):
2373         * css/SelectorPseudoClassAndCompatibilityElementMap.in:
2374         * cssjit/SelectorCompiler.cpp:
2375         (WebCore::SelectorCompiler::addPseudoClassType):
2376
2377 2014-11-25  Anders Carlsson  <andersca@apple.com>
2378
2379         Remove user content handling from PageGroup
2380         https://bugs.webkit.org/show_bug.cgi?id=139051
2381
2382         Reviewed by Antti Koivisto.
2383
2384         Remove m_userContentController from PageGroup and the related functions and symbol exports.
2385
2386         * WebCore.exp.in:
2387         * page/PageGroup.cpp:
2388         (WebCore::PageGroup::PageGroup):
2389         (WebCore::PageGroup::~PageGroup):
2390         (WebCore::PageGroup::addPage):
2391         (WebCore::PageGroup::removePage):
2392         (WebCore::PageGroup::addUserScriptToWorld): Deleted.
2393         (WebCore::PageGroup::addUserStyleSheetToWorld): Deleted.
2394         (WebCore::PageGroup::removeUserScriptFromWorld): Deleted.
2395         (WebCore::PageGroup::removeUserStyleSheetFromWorld): Deleted.
2396         (WebCore::PageGroup::removeUserScriptsFromWorld): Deleted.
2397         (WebCore::PageGroup::removeUserStyleSheetsFromWorld): Deleted.
2398         (WebCore::PageGroup::removeAllUserContent): Deleted.
2399         * page/PageGroup.h:
2400
2401 2014-11-25  Anders Carlsson  <andersca@apple.com>
2402
2403         Add a user content controller to WebViewGroup and use it for user content
2404         https://bugs.webkit.org/show_bug.cgi?id=139043
2405
2406         Reviewed by Antti Koivisto.
2407
2408         * WebCore.exp.in:
2409         Export symbols.
2410
2411         * page/Page.cpp:
2412         (WebCore::Page::setUserContentController):
2413         Invalidate the injected style cache when setting a new user content controller.
2414
2415 2014-11-25  Philippe Normand  <pnormand@igalia.com>
2416
2417         [GStreamer] gstmpegts is not initialized
2418         https://bugs.webkit.org/show_bug.cgi?id=139039
2419
2420         Reviewed by Carlos Garcia Campos.
2421
2422         * platform/graphics/gstreamer/GStreamerUtilities.cpp:
2423         (WebCore::initializeGStreamer): Initialize the gstmpegts library.
2424
2425 2014-11-24  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2426
2427         Fix unused variable warning in Biquad.cpp
2428         https://bugs.webkit.org/show_bug.cgi?id=139031
2429
2430         Reviewed by Andreas Kling.
2431
2432         No new tests needed.
2433
2434         * platform/audio/Biquad.cpp:
2435
2436 2014-11-24  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2437
2438         Remove Qt cruft related to tap higlighting
2439         https://bugs.webkit.org/show_bug.cgi?id=139030
2440
2441         Reviewed by Andreas Kling.
2442
2443         No new tests needed.
2444
2445         * CMakeLists.txt:
2446         * page/GestureTapHighlighter.cpp: Removed.
2447         * page/GestureTapHighlighter.h: Removed.
2448
2449 2014-11-24  Dhi Aurrahman  <diorahman@rockybars.com>
2450
2451         Fix the parsing and re-serialization of :lang pseudo class selector when it has multiple arguments with same value
2452         https://bugs.webkit.org/show_bug.cgi?id=139013
2453
2454         Reviewed by Benjamin Poulain.
2455
2456         Fix the parsing and re-serialization of :lang pseudo class selector when 
2457         it has multiple arguments with same value e.g. :lang(en, en, en). Previously, 
2458         given :lang(en, en, en) selector, it was parsed and reserialized 
2459         as :lang(enenen) instead of :lang(en, en, en)
2460
2461         Related test on parsing and re-serialization of css selectors is updated.
2462
2463         * css/CSSSelector.cpp:
2464         (WebCore::appendArgumentList):
2465
2466 2014-11-24  Zalan Bujtas  <zalan@apple.com>
2467
2468         Fix r176527. Iterate through the text renderers.
2469         https://bugs.webkit.org/show_bug.cgi?id=139007
2470
2471         Reviewed by Antti Koivisto.
2472
2473         * rendering/SimpleLineLayout.cpp:
2474         (WebCore::SimpleLineLayout::canUseFor):
2475
2476 2014-11-24  Zalan Bujtas  <zalan@apple.com>
2477
2478         Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
2479         https://bugs.webkit.org/show_bug.cgi?id=139035
2480
2481         Reviewed by Antti Koivisto.
2482
2483         Move new line logic to FlowContents class.
2484         This is in preparation to support <br>.
2485
2486         No change in functionality.
2487
2488         * rendering/SimpleLineLayout.cpp:
2489         (WebCore::SimpleLineLayout::TextFragment::TextFragment):
2490         (WebCore::SimpleLineLayout::removeTrailingWhitespace):
2491         (WebCore::SimpleLineLayout::nextFragment):
2492         (WebCore::SimpleLineLayout::createLineRuns):
2493         * rendering/SimpleLineLayoutFlowContents.h:
2494         (WebCore::SimpleLineLayout::FlowContents::isNewline):
2495         (WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter): Deleted.
2496
2497 2014-11-24  Benjamin Poulain  <benjamin@webkit.org>
2498
2499         Move :placeholder-shown out of experimental
2500         https://bugs.webkit.org/show_bug.cgi?id=138998
2501
2502         Reviewed by Andreas Kling.
2503
2504         The pseudo class :placeholder-shown is used by the inspector, disabling it breaks
2505         the sidebar.
2506
2507         The implementation has been stable for a while, we can move it to stable.
2508
2509         * css/CSSSelector.cpp:
2510         (WebCore::CSSSelector::selectorText):
2511         * css/CSSSelector.h:
2512         * css/SelectorChecker.cpp:
2513         (WebCore::SelectorChecker::checkOne):
2514         * css/SelectorPseudoClassAndCompatibilityElementMap.in:
2515         * cssjit/SelectorCompiler.cpp:
2516         (WebCore::SelectorCompiler::addPseudoClassType):
2517         (WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
2518         (WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPlaceholderShown):
2519
2520 2014-11-24  Antti Koivisto  <antti@apple.com>
2521
2522         Avoid String concatenation with line break iterator
2523         https://bugs.webkit.org/show_bug.cgi?id=139034
2524
2525         Reviewed by Zalan Bujtas.
2526
2527         Test: fast/text/simple-lines-multiple-renderers-break.html
2528
2529         * rendering/SimpleLineLayoutFlowContents.cpp:
2530         (WebCore::SimpleLineLayout::initializeSegments):
2531
2532             Include String too so it doesn't need to be fetched from the renderer.
2533
2534         (WebCore::SimpleLineLayout::FlowContents::FlowContents):
2535         (WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):
2536
2537             Make this iterative instead of recursive.
2538             Uset setPriorContext to provide previous characters instead of concatenating
2539             the string from all the previous segments.
2540
2541         (WebCore::SimpleLineLayout::findNextNonWhitespace):
2542         (WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):
2543
2544             Search using segments instead of the concatenated string.
2545
2546         (WebCore::SimpleLineLayout::FlowContents::textWidth):
2547         (WebCore::SimpleLineLayout::FlowContents::segmentIndexForPositionSlow):
2548         (WebCore::SimpleLineLayout::FlowContents::runWidth):
2549         (WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow): Deleted.
2550         (WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Deleted.
2551         (WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition): Deleted.
2552         * rendering/SimpleLineLayoutFlowContents.h:
2553         (WebCore::SimpleLineLayout::FlowContents::characterAt):
2554         (WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
2555         (WebCore::SimpleLineLayout::FlowContents::segmentIndexForPosition):
2556         (WebCore::SimpleLineLayout::FlowContents::segmentForPosition):
2557
2558 2014-11-24  Zalan Bujtas  <zalan@apple.com>
2559
2560         SimpleLineLayout::canUseFor() should iterate through RenderTexts to check if their content is eligible for simple line layout.
2561         https://bugs.webkit.org/show_bug.cgi?id=139007
2562
2563         Reviewed by Antti Koivisto.
2564
2565         Tests: fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html
2566                fast/text/simple-line-layout-multiple-renderers-with-float.html
2567
2568         * rendering/SimpleLineLayout.cpp:
2569         (WebCore::SimpleLineLayout::canUseFor):
2570
2571 2014-11-22  Sam Weinig  <sam@webkit.org>
2572
2573         Move the '-webkit-box-reflext' CSS property to the new StyleBuilder
2574         https://bugs.webkit.org/show_bug.cgi?id=139008
2575
2576         Reviewed by Anders Carlsson.
2577
2578         * css/CSSPropertyNames.in:
2579         * css/StyleBuilderConverter.h:
2580         (WebCore::StyleBuilderConverter::convertReflection):
2581         * css/StyleResolver.cpp:
2582         (WebCore::StyleResolver::applyProperty):
2583
2584 2014-11-24  Antti Koivisto  <antti@apple.com>
2585
2586         Remove unused Style struct from SimpleLineLayout.cpp
2587         https://bugs.webkit.org/show_bug.cgi?id=139027
2588
2589         Reviewed by Sam Weinig.
2590
2591         It was moved to FlowContents.
2592
2593         * rendering/SimpleLineLayout.cpp:
2594         (WebCore::SimpleLineLayout::Style::Style): Deleted.
2595
2596 2014-11-24  peavo@outlook.com  <peavo@outlook.com>
2597
2598         [Curl] Compile error in ResourceHandleManager.cpp.
2599         https://bugs.webkit.org/show_bug.cgi?id=139026
2600
2601         Reviewed by Brent Fulgham.
2602
2603         The parameter types of the constructor of the Timer class has changed.
2604
2605         * platform/network/curl/ResourceHandleManager.cpp:
2606         (WebCore::ResourceHandleManager::ResourceHandleManager):
2607         (WebCore::ResourceHandleManager::downloadTimerCallback):
2608         * platform/network/curl/ResourceHandleManager.h:
2609
2610 2014-11-24  Joanmarie Diggs  <jdiggs@igalia.com>
2611
2612         AX: [ATK] Unskip the skipped ATK tests in roles-exposed.html
2613         https://bugs.webkit.org/show_bug.cgi?id=139016
2614
2615         Reviewed by Chris Fleizach.
2616
2617         There was one test that could not be unskipped without making a change
2618         for that one to pass: mapping DocumentRegionRole to ATK_ROLE_PANEL. The
2619         rest of the "fix" is just unskipping tests for ATK and updating the test
2620         expectations.
2621
2622         No new tests needed.
2623
2624         * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
2625         (atkRole):
2626
2627 2014-11-23  Antti Koivisto  <antti@apple.com>
2628
2629         Use segment vector for FlowContents
2630         https://bugs.webkit.org/show_bug.cgi?id=139015
2631
2632         Reviewed by Zalan Bujtas.
2633
2634         And FlowContents::Segment struct and use it.
2635
2636         * rendering/SimpleLineLayout.cpp:
2637         (WebCore::SimpleLineLayout::removeTrailingWhitespace):
2638         (WebCore::SimpleLineLayout::createLineRuns):
2639         (WebCore::SimpleLineLayout::splitRunsAtRendererBoundary):
2640
2641             Use segments.
2642             If there is only one segment there is nothing to do. Bail out.
2643
2644         * rendering/SimpleLineLayoutFlowContents.cpp:
2645         (WebCore::SimpleLineLayout::initializeSegments):
2646
2647             Move initialization to a function so m_segments can be const.
2648             Don't add empty end segment, handle the end case in code.
2649
2650         (WebCore::SimpleLineLayout::FlowContents::FlowContents):
2651         (WebCore::SimpleLineLayout::FlowContents::textWidth):
2652
2653             Simplify and use segments.
2654
2655         (WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow):
2656
2657             Replace hand-rolled binary search with std::lower_bounds.
2658
2659         (WebCore::SimpleLineLayout::FlowContents::segmentForRenderer):
2660         (WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
2661         (WebCore::SimpleLineLayout::FlowContents::renderer): Deleted.
2662         (WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): Deleted.
2663         * rendering/SimpleLineLayoutFlowContents.h:
2664         (WebCore::SimpleLineLayout::FlowContents::hasOneSegment):
2665         (WebCore::SimpleLineLayout::FlowContents::length):
2666         (WebCore::SimpleLineLayout::FlowContents::isEnd):
2667         (WebCore::SimpleLineLayout::FlowContents::isEndOfContent): Deleted.
2668
2669             Renamed.
2670
2671         (WebCore::SimpleLineLayout::FlowContents::segmentForPosition):
2672
2673             Inline the fast path.
2674
2675         * rendering/SimpleLineLayoutResolver.cpp:
2676         (WebCore::SimpleLineLayout::RunResolver::Run::text):
2677         (WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):
2678
2679 2014-11-22  Simon Fraser  <simon.fraser@apple.com>
2680
2681         Extend WKRenderObject and WKRenderLayer with some more useful data
2682         https://bugs.webkit.org/show_bug.cgi?id=139006
2683
2684         Reviewed by Sam Weinig.
2685
2686         Export WebCore::RenderLayerBacking::backingStoreMemoryEstimate() const.
2687
2688         * WebCore.exp.in:
2689
2690 2014-11-22  Antti Koivisto  <antti@apple.com>
2691
2692         Make locale part of the SimpleLineLayout::FlowContent::Style
2693         https://bugs.webkit.org/show_bug.cgi?id=139004
2694
2695         Reviewed by Zalan Bujtas.
2696
2697         That's the only part of style not extracted out of RenderStyle in the constructor.
2698
2699         * rendering/SimpleLineLayoutFlowContents.cpp:
2700         (WebCore::SimpleLineLayout::FlowContents::Style::Style):
2701         (WebCore::SimpleLineLayout::FlowContents::FlowContents):
2702         (WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
2703         * rendering/SimpleLineLayoutFlowContents.h:
2704
2705             Also remove RenderBlockFlow member since it is now unused.
2706
2707         (WebCore::SimpleLineLayout::FlowContents::Style::Style): Deleted.
2708
2709             Move to cpp.
2710
2711 2014-11-22  Joanmarie Diggs  <jdiggs@igalia.com>
2712
2713         AX: [ATK] Accessible names missing for imagemap images and links
2714         https://bugs.webkit.org/show_bug.cgi?id=127288
2715
2716         Reviewed by Chris Fleizach.
2717
2718         Return the alt text, if present, for the accessible name for image maps
2719         and image map links for ATK. Also expose the accessible element with
2720         ATK_ROLE_IMAGE_MAP instead of ATK_ROLE_IMAGE.
2721
2722         Test: accessibility/image-with-alt-and-map.html
2723
2724         * accessibility/AccessibilityObject.h:
2725         (WebCore::AccessibilityObject::isImageMap):
2726         * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
2727         (webkitAccessibleGetName):
2728         (atkRole):
2729
2730 2014-11-22  Andreas Kling  <akling@apple.com>
2731
2732         Remove unused Document::ignoreAutofocus().
2733         <https://webkit.org/b/139002>
2734
2735         Reviewed by Antti Koivisto.
2736
2737         No one ever actually changes this flag, so let's remove it.
2738
2739         * dom/Document.cpp:
2740         (WebCore::Document::Document):
2741         * dom/Document.h:
2742         (WebCore::Document::ignoreAutofocus): Deleted.
2743         (WebCore::Document::setIgnoreAutofocus): Deleted.
2744         * html/HTMLFormControlElement.cpp:
2745         (WebCore::shouldAutofocus):
2746
2747 2014-11-22  Csaba Osztrogonác  <ossy@webkit.org>
2748
2749         URTBF after r176459 to fix GTK build.
2750
2751         * platform/ScrollAnimatorNone.cpp:
2752         (WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
2753         (WebCore::ScrollAnimatorNone::requestAnimationTimerFired):
2754         * platform/ScrollAnimatorNone.h:
2755
2756 2014-11-22  Andreas Kling  <akling@apple.com>
2757
2758         Convert PassRefPtr return types to RefPtr.
2759         <https://webkit.org/b/138995>
2760
2761         Reviewed by Anders Carlsson.
2762
2763         Convert an assortment of DOM and HTML related functions
2764         to return RefPtr instead of PassRefPtr.
2765
2766 2014-11-21  Jer Noble  <jer.noble@apple.com>
2767
2768         Unreviewed iOS build fix; move new symbols out of Mac-only exports.
2769
2770         * WebCore.exp.in:
2771
2772 2014-11-21  Timothy Horton  <timothy_horton@apple.com>
2773
2774         Remove a file that r176499 presumably did not mean to add.
2775
2776         * WebCore.exp.in.orig: Removed.
2777
2778 2014-11-21  Jer Noble  <jer.noble@apple.com>
2779
2780         Support multiple signatures of diagnostic logging.
2781         https://bugs.webkit.org/show_bug.cgi?id=138690
2782
2783         Reviewed by Anders Carlsson.
2784
2785         Pull logDiagnosticMessage() out of ChromeClient and make a new client interface,
2786         DiagnosticLoggingClient, which supports multiple kinds of diagnostic logging,
2787         namely: simple logging without a parameter, logging with a success parameter, and
2788         logging with a generic string value parameter.
2789
2790         * html/HTMLMediaElement.cpp:
2791         (WebCore::HTMLMediaElement::parseAttribute): Use DiagnosticLoggingClient.
2792         * loader/FrameLoader.cpp:
2793         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.
2794         * loader/SubframeLoader.cpp:
2795         (WebCore::logPluginRequest): Ditto.
2796         * page/ChromeClient.h:
2797         (WebCore::ChromeClient::logDiagnosticMessage): Deleted.
2798         * page/DiagnosticLoggingClient.h: 
2799         (WebCore::DiagnosticLoggingClient::logDiagnosticMessage): Added.
2800         (WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithResult): Added.
2801         (WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithValue): Added.
2802         (WebCore::DiagnosticLoggingClient::~DiagnosticLoggingClient): Empty destructor.
2803
2804         Rename Page::PageClient to PageConfiguration, and pass that configuration from
2805         Page into MainFrame upon construction.
2806
2807         * inspector/InspectorOverlay.cpp:
2808         (WebCore::InspectorOverlay::overlayPage): Use PageConfiguration instead of PageClients.
2809         * loader/EmptyClients.cpp:
2810         (WebCore::fillWithEmptyClients): Ditto.
2811         * loader/EmptyClients.h:
2812         * page/MainFrame.cpp:
2813         (WebCore::MainFrame::MainFrame): Pass loaderClientForMainFrame through to the
2814             Frame constructor.
2815         (WebCore::MainFrame::create): Takes a PageConfiguration.
2816         * page/MainFrame.h:
2817         (WebCore::MainFrame::diagnosticLoggingClient): Simple accessor.
2818         * page/Page.cpp:
2819         (WebCore::Page::Page):
2820         (WebCore::Page::PageClients::PageClients): Deleted.
2821         (WebCore::Page::PageClients::~PageClients): Deleted.
2822         * page/Page.h:
2823         * page/PageConfiguration.cpp: Added.
2824         (WebCore::PageConfiguration::PageConfiguration): Renamed from PageClients().
2825         (WebCore::PageConfiguration::~PageConfiguration): Renamed from ~PageClients().
2826         * page/PageConfiguration.h: Added.
2827         * svg/graphics/SVGImage.cpp:
2828         (WebCore::SVGImage::dataChanged): Use PageConfiguration instead of PageClients.
2829
2830         Add new files and symbols to the project.
2831
2832         * CMakeLists.txt:
2833         * WebCore.exp.in:
2834         * WebCore.vcxproj/WebCore.vcxproj:
2835         * WebCore.xcodeproj/project.pbxproj:
2836
2837 2014-11-21  Chris Dumez  <cdumez@apple.com>
2838
2839         Throttled DOMTimers can prevent their document from being garbage collected
2840         https://bugs.webkit.org/show_bug.cgi?id=138915
2841
2842         Reviewed by Andreas Kling.
2843
2844         Throttled DOMTimers whose interval depend on viewport changes would
2845         keep a Vector of elements outside viewport causing them to be throttled
2846         so that we could check later on (upon scroll or layout) if those
2847         elements are still outside viewport. The issue is that these elements
2848         could potentially be removed from the document (and destroyed) after
2849         the timer has fired. To handle this, DOMTimer was ref'ing the
2850         elements. Unfortunately, this was causing us to leak the document
2851         as the elements in the Vector would keep the document alive.
2852
2853         To handle this issue, this patch updates the DOMTimer Vector to use
2854         weak pointers. The WeakPtrFactory is stored in ElementRareData to
2855         avoid wasting memory for all kinds of Elements (it is a fair assumption
2856         that the number of elements whose style is animated via timers is low).
2857
2858         Test: fast/dom/throttled-timer-running-on-document-destruction.html
2859
2860         * dom/Element.cpp:
2861         (WebCore::Element::createWeakPtr):
2862         * dom/Element.h:
2863         * dom/ElementRareData.cpp:
2864         * dom/ElementRareData.h:
2865         (WebCore::ElementRareData::weakPtrFactory):
2866         * page/DOMTimer.cpp:
2867         (WebCore::DOMTimerFireState::elementsChangedOutsideViewport):
2868         (WebCore::DOMTimer::updateThrottlingStateAfterViewportChange):
2869         * page/DOMTimer.h:
2870
2871 2014-11-21  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2872
2873         Unreviewed, EFL build fix since r176459.
2874
2875         r176459 removed Timer parameter in timer callbacks only for Mac port.
2876         So this patch applies it to remaining classes for EFL port.
2877
2878         No new tests, fix build break.
2879
2880         * Modules/mediastream/RTCDTMFSender.cpp:
2881         (WebCore::RTCDTMFSender::RTCDTMFSender):
2882         * Modules/mediastream/RTCDataChannel.cpp:
2883         (WebCore::RTCDataChannel::RTCDataChannel):
2884         * Modules/mediastream/RTCPeerConnection.cpp:
2885         (WebCore::RTCPeerConnection::RTCPeerConnection):
2886         * Modules/vibration/Vibration.cpp:
2887         (WebCore::Vibration::Vibration):
2888         (WebCore::Vibration::timerFired):
2889         * Modules/vibration/Vibration.h:
2890         * bindings/js/GCController.cpp:
2891         (WebCore::GCController::GCController):
2892         * platform/efl/BatteryProviderEfl.cpp:
2893         (WebCore::BatteryProviderEfl::BatteryProviderEfl):
2894         (WebCore::BatteryProviderEfl::timerFired):
2895         * platform/efl/BatteryProviderEfl.h:
2896         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
2897         (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
2898         (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
2899         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2900         * platform/graphics/texmap/TextureMapper.cpp:
2901         (WebCore::BitmapTexturePool::BitmapTexturePool):
2902         (WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
2903         * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
2904         (WebCore::CompositingCoordinator::CompositingCoordinator):
2905         (WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
2906         * platform/graphics/texmap/coordinated/CompositingCoordinator.h:
2907         * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
2908         (WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
2909         (WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
2910         * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
2911         * platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
2912         (WebCore::CoordinatedImageBacking::CoordinatedImageBacking):
2913         (WebCore::CoordinatedImageBacking::clearContentsTimerFired):
2914         * platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
2915         * platform/mock/DeviceMotionClientMock.cpp:
2916         (WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
2917         (WebCore::DeviceMotionClientMock::timerFired):
2918         * platform/mock/DeviceMotionClientMock.h:
2919         * platform/mock/TimerEventBasedMock.h:
2920         (WebCore::TimerEvent::TimerEvent):
2921         (WebCore::TimerEvent::timerFired):
2922
2923 2014-11-21  Benjamin Poulain  <bpoulain@apple.com>
2924
2925         Start using the new :not() and :matches() in the Web Inspector
2926         https://bugs.webkit.org/show_bug.cgi?id=138978
2927
2928         Reviewed by Joseph Pecoraro.
2929
2930         There are only minor pending issues on :not() and :matches(). The feedback
2931         has only been positive so far. It is time to move them out the experimental
2932         flag.
2933
2934         * css/CSSGrammar.y.in:
2935         * css/CSSParser.cpp:
2936         (WebCore::CSSParser::detectFunctionTypeToken):
2937         * css/CSSSelector.cpp:
2938         (WebCore::simpleSelectorSpecificityInternal):
2939         (WebCore::simpleSelectorFunctionalPseudoClassStaticSpecificity):
2940         (WebCore::appendSelectorList):
2941         (WebCore::CSSSelector::selectorText):
2942         * css/CSSSelector.h:
2943         * css/SelectorChecker.cpp:
2944         (WebCore::SelectorChecker::checkOne):
2945         (WebCore::SelectorChecker::determineLinkMatchType):
2946         * css/SelectorPseudoClassAndCompatibilityElementMap.in:
2947         * cssjit/SelectorCompiler.cpp:
2948         (WebCore::SelectorCompiler::addPseudoClassType):
2949
2950 2014-11-21  Chris Dumez  <cdumez@apple.com>
2951
2952         Unreviewed, iOS build fix after r176462.
2953
2954         Export a few extra symbols.
2955
2956         * WebCore.exp.in:
2957
2958 2014-11-21  Chris Dumez  <cdumez@apple.com>
2959
2960         Properties in CSSPropertyNames.in should use the new StyleBuilder by default
2961         https://bugs.webkit.org/show_bug.cgi?id=138983
2962
2963         Reviewed by Andreas Kling.
2964
2965         This patch makes using the new StyleBuilder the default and drops the
2966         [NewStyleBuilder] option as a result. A new [LegacyStyleBuilder] option
2967         is introduced for CSS properties that are not generated in the new
2968         StyleBuilder yet.
2969
2970         * css/CSSPropertyNames.in:
2971         * css/SVGCSSPropertyNames.in:
2972         * css/makeprop.pl:
2973
2974 2014-11-21  Chris Dumez  <cdumez@apple.com>
2975
2976         [iOS] Regression(r176202): line-height is wrong on marco.org
2977         https://bugs.webkit.org/show_bug.cgi?id=138970
2978
2979         Reviewed by Simon Fraser.
2980
2981         After r176202, on iOS with IOS_TEXT_AUTOSIZING enabled, we would
2982         multiply the lineHeight by RenderStyle::textSizeAdjust()::multiplier()
2983         unconditionally. However, we're only supposed to do so if
2984         RenderStyle::textSizeAdjust()::isPercentage() returns true. This
2985         patch reintroduces the textSizeAdjust().isPercentage() check that was
2986         inadvertently dropped when refactoring the code to be shared between
2987         iOS and OS X.
2988
2989         Additionally, the multiplier is only supposed the be applied if the
2990         input CSSPrimitiveValue is a Length or a Number. However, after
2991         r176202, we would apply the multiplier if the CSSPrimitiveValue is
2992         a Percentage or a Number. This patch updates the code to match the
2993         behavior prior to r176202.
2994
2995         Test: fast/css/line-height-text-autosizing.html
2996
2997         * css/StyleBuilderCustom.h:
2998         (WebCore::StyleBuilderFunctions::convertLineHeight):
2999         (WebCore::StyleBuilderFunctions::applyValueLineHeight):
3000
3001 2014-11-21  Chris Fleizach  <cfleizach@apple.com>
3002
3003         AX: com.apple.WebKit.WebContent crashed at WebCore: WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const
3004         https://bugs.webkit.org/show_bug.cgi?id=138905
3005
3006         Reviewed by Mario Sanchez Prada.
3007
3008         The crash log indicates that m_renderer is null at the time we ask ancestorsOfType(). 
3009         This is more of a speculative fix, since I am not entirely sure m_renderer is null when we enter the method.
3010
3011         Unable to determine cause of crash or how to reproduce on demand.
3012
3013         * accessibility/AccessibilityRenderObject.cpp:
3014         (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
3015
3016 2014-11-21  Jer Noble  <jer.noble@apple.com>
3017
3018         [EME][Mac] Check the underlying error if the one returned by AVFoundation is AVErrorUnknown.
3019         https://bugs.webkit.org/show_bug.cgi?id=138986
3020
3021         Reviewed by Eric Carlson.
3022
3023         When we recieve an error with the code AVErrorUnknown, look for an underlying error from CoreMedia (or another
3024         lower-level framework) with a (presumably) more informative error code, and return that code instead.
3025
3026         * platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
3027         (WebCore::systemCodeForError):
3028         (WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
3029         (WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):
3030
3031 2014-11-21  Chris Fleizach  <cfleizach@apple.com>
3032
3033         AX: Unclear that user and password are autofilled, no VoiceOver version of the yellow outline.
3034         https://bugs.webkit.org/show_bug.cgi?id=138904
3035
3036         Reviewed by Mario Sanchez Prada.
3037
3038         Add an attribute that marks when a text field is auto-filled.
3039
3040         Test: accessibility/auto-filled-value.html
3041
3042         * accessibility/AccessibilityObject.cpp:
3043         (WebCore::AccessibilityObject::isValueAutofilled):
3044         * accessibility/AccessibilityObject.h:
3045         * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
3046         (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
3047         (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
3048
3049 2014-11-21  Andreas Kling  <akling@apple.com>
3050
3051         RenderElement::removeChild() doesn't need a return value.
3052         <https://webkit.org/b/138985>
3053
3054         Reviewed by Pantti Koivisto.
3055
3056         Nobody uses the return value from RenderElement::removeChild().
3057         Change it to return void and remove all the unnecessary plumbing.
3058
3059         * rendering/RenderBlock.cpp:
3060         (WebCore::RenderBlock::removeChild):
3061         * rendering/RenderBlock.h:
3062         * rendering/RenderBlockFlow.cpp:
3063         (WebCore::RenderBlockFlow::removeChild):
3064         * rendering/RenderBlockFlow.h:
3065         * rendering/RenderButton.cpp:
3066         (WebCore::RenderButton::removeChild):
3067         * rendering/RenderButton.h:
3068         * rendering/RenderElement.cpp:
3069         (WebCore::RenderElement::removeChild):
3070         (WebCore::RenderElement::removeChildInternal):
3071         * rendering/RenderElement.h:
3072         * rendering/RenderMenuList.cpp:
3073         (RenderMenuList::removeChild):
3074         * rendering/RenderMenuList.h:
3075         * rendering/RenderRuby.cpp:
3076         (WebCore::RenderRubyAsInline::removeChild):
3077         (WebCore::RenderRubyAsBlock::removeChild):
3078         * rendering/RenderRuby.h:
3079         * rendering/RenderRubyRun.cpp:
3080         (WebCore::RenderRubyRun::removeChild):
3081         * rendering/RenderRubyRun.h:
3082         * rendering/mathml/RenderMathMLRoot.cpp:
3083         (WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
3084         (WebCore::RenderMathMLRootWrapper::removeChild):
3085         * rendering/mathml/RenderMathMLRoot.h:
3086         * rendering/mathml/RenderMathMLScripts.cpp:
3087         (WebCore::RenderMathMLScripts::removeChildInternal):
3088         (WebCore::RenderMathMLScripts::removeChild):
3089         (WebCore::RenderMathMLScriptsWrapper::removeChildInternal):
3090         (WebCore::RenderMathMLScriptsWrapper::removeChild):
3091         * rendering/mathml/RenderMathMLScripts.h:
3092         * rendering/svg/RenderSVGContainer.cpp:
3093         (WebCore::RenderSVGContainer::removeChild):
3094         * rendering/svg/RenderSVGContainer.h:
3095         * rendering/svg/RenderSVGInline.cpp:
3096         (WebCore::RenderSVGInline::removeChild):
3097         * rendering/svg/RenderSVGInline.h:
3098         * rendering/svg/RenderSVGRoot.cpp:
3099         (WebCore::RenderSVGRoot::removeChild):
3100         * rendering/svg/RenderSVGRoot.h:
3101         * rendering/svg/RenderSVGText.cpp:
3102         (WebCore::RenderSVGText::removeChild):
3103         * rendering/svg/RenderSVGText.h:
3104
3105 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3106
3107         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3108         ​https://bugs.webkit.org/show_bug.cgi?id=138960
3109         <rdar://problem/19056715>
3110
3111         Reviewed by Anders Carlsson.
3112
3113         * platform/spi/mac/DataDetectorsSPI.h:
3114         Add some DataDetectors SPI.
3115
3116 2014-11-21  Jer Noble  <jer.noble@apple.com>
3117
3118         [Mac] Random crashes inside media libraries when creating then destroying media quickly.
3119         https://bugs.webkit.org/show_bug.cgi?id=138980
3120
3121         Reviewed by Eric Carlson.
3122
3123         Speculative fix for random crashes in the layout tests which occur randomly but regularly. The theory is
3124         that creating-then-destroying our media objects too quickly triggers crashes deep within the media frameworks
3125         when their initialization threads don't have a chance to complete before the main player object is destroyed.
3126         Test out this theory by delaying the destruction of the AVPlayer object for 1s after its owner is destroyed.
3127
3128         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
3129         (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
3130
3131 2014-11-21  Jer Noble  <jer.noble@apple.com>
3132
3133         [Mac] Delay of 1-2s after the first paint of a video frame.
3134         https://bugs.webkit.org/show_bug.cgi?id=138979
3135
3136         Reviewed by Eric Carlson.
3137
3138         Only bother waiting for a signal that a new image is ready when the image isn't ready in the first place.
3139
3140         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
3141         (WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
3142
3143 2014-11-21  Glenn Adams  <glenn@skynav.com> and Myles C. Maxfield  <mmaxfield@apple.com>
3144
3145         Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
3146         https://bugs.webkit.org/show_bug.cgi?id=89235
3147
3148         Reviewed by Eric Seidel and Dave Hyatt.
3149
3150         This patch adds semantic support for the CSS3 line-break property (qua -webkit-line-break),
3151         and enables testing on (apple) mac ports. Follow on patches will enable these tests on
3152         other ports as they are incrementally verified.
3153
3154         See also wiki documentation at:
3155         [1] http://trac.webkit.org/wiki/LineBreaking
3156         [2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping
3157
3158         Tests: css3/line-break/line-break-auto-centered.html
3159                css3/line-break/line-break-auto-half-kana.html
3160                css3/line-break/line-break-auto-hyphens.html
3161                css3/line-break/line-break-auto-inseparables.html
3162                css3/line-break/line-break-auto-iteration-marks.html
3163                css3/line-break/line-break-auto-postfixes.html
3164                css3/line-break/line-break-auto-prefixes.html
3165                css3/line-break/line-break-auto-sound-marks.html
3166                css3/line-break/line-break-loose-centered.html
3167                css3/line-break/line-break-loose-half-kana.html
3168                css3/line-break/line-break-loose-hyphens.html
3169                css3/line-break/line-break-loose-inseparables.html
3170                css3/line-break/line-break-loose-iteration-marks.html
3171                css3/line-break/line-break-loose-postfixes.html
3172                css3/line-break/line-break-loose-prefixes.html
3173                css3/line-break/line-break-loose-sound-marks.html
3174                css3/line-break/line-break-normal-centered.html
3175                css3/line-break/line-break-normal-half-kana.html
3176                css3/line-break/line-break-normal-hyphens.html
3177                css3/line-break/line-break-normal-inseparables.html
3178                css3/line-break/line-break-normal-iteration-marks.html
3179                css3/line-break/line-break-normal-postfixes.html
3180                css3/line-break/line-break-normal-prefixes.html
3181                css3/line-break/line-break-normal-sound-marks.html
3182                css3/line-break/line-break-strict-centered.html
3183                css3/line-break/line-break-strict-half-kana.html
3184                css3/line-break/line-break-strict-hyphens.html
3185                css3/line-break/line-break-strict-inseparables.html
3186                css3/line-break/line-break-strict-iteration-marks.html
3187                css3/line-break/line-break-strict-postfixes.html
3188                css3/line-break/line-break-strict-prefixes.html
3189                css3/line-break/line-break-strict-sound-marks.html
3190
3191         These tests were previously added in http://trac.webkit.org/changeset/143378, but skipped
3192         in generic TestExpectations. In this patch, they are marked as Pass for the (apple) mac ports.
3193
3194         * platform/text/LineBreakIteratorPoolICU.h:
3195         (WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
3196         Add static function to construct ICU locale argument (also used as pool key) with additional
3197         break keyword.
3198         (LineBreakIteratorPool):
3199         (WebCore::LineBreakIteratorPool::take):
3200         (WebCore::LineBreakIteratorPool::put):
3201         Remove direct dependency from ICU library (and types), moving that dependency into
3202         new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
3203         Update to take line break mode into account.
3204         Create (and cache) different break iterators depending on line break mode (in addition to locale),
3205         which entails expanding pool entry key format to optionally append "@break=" +
3206         "loose"|"normal"|"strict" keyword to locale string.
3207
3208         * platform/text/TextBreakIterator.h:
3209         (WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
3210         (WebCore::LazyLineBreakIterator::isLooseCJKMode):
3211         (WebCore::LazyLineBreakIterator::get):
3212         (WebCore::LazyLineBreakIterator::reset):
3213         (LazyLineBreakIterator):
3214         Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
3215         Add state member to indicate line break mode.
3216
3217         * platform/text/TextBreakIteratorICU.cpp:
3218         (WebCore::acquireLineBreakIterator):
3219         Use new line break mode when making iterator from pool.
3220         Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
3221         i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
3222         (WebCore::releaseLineBreakIterator):
3223         Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
3224         i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
3225         (WebCore):
3226         (WebCore::isCJKLocale):
3227         New functions for determining if CJK rules apply.
3228         (WebCore::openLineBreakIterator):
3229         New function for abstracting opening of ICU style line break iterator. This is now
3230         used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
3231         This function also takes into account the line break mode.
3232
3233         Note that this function only calls ubrk_openRules() when the author has opted-in via
3234         using the -webkit-line-break CSS property. Eventually, we would like to be able to
3235         customize the rules that ICU's line breaking algorithm uses (especially for CJK text);
3236         however, ubrk_openRules() currently parses its input string to create a DFA and is
3237         therefore very slow. In fact, it's so slow that increasing our cache size in
3238         LineBreakIteratorPool doesn't actually help enough. Also note that the default value
3239         for the line-break CSS property is 'auto'.
3240         (WebCore::closeLineBreakIterator):
3241         (WebCore::mapLineIteratorModeToRules):
3242         New function for abstracting closing of ICU style line break iterator. This is now
3243         used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
3244
3245         * rendering/RenderBlockLineLayout.cpp:
3246         (WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
3247         Pass line break iterator mode flag when reseting LazyLineBreakIterator.
3248         Add looseMode local variable to prevent need for computing under isBreakable().
3249
3250         * rendering/RenderText.cpp:
3251         (WebCore::mapLineBreakToIteratorMode):
3252         Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
3253         and RenderBlock::LineBreaker::nextLineBreak.
3254         (WebCore):
3255         (WebCore::RenderText::computePreferredLogicalWidths):
3256         Ensure (lazy line) breakIterator is initialized for line break mode.
3257         Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.
3258
3259         * rendering/RenderText.h:
3260         (WebCore):
3261         Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
3262         and RenderBlock::LineBreaker::nextLineBreak.
3263
3264         * rendering/break_lines.cpp:
3265         (WebCore):
3266         Introduce (local) enum NBSPBehavior for expanding template on nextBreakablePosition.
3267         (WebCore::isBreakableSpace):
3268         Add externally specified loose mode parameter to prevent need to invoke line break iterator
3269         accessor method on each invocation. Use new loose mode flavors off NBP functions.
3270         (WebCore::needsLineBreakIterator):
3271         Use enum NBSP behavior template parameter rather than boolean.
3272         (WebCore::nextBreakablePositionNonLoosely):
3273         Extend name to distinguish from loose flavor of this function.
3274         (WebCore::nextBreakablePositionLoosely):
3275         Add loose flavor of NBP invoked only when loose mode applies, in which case ASCII shortcut
3276         table cannot be used.
3277         (WebCore::nextBreakablePosition):
3278         (WebCore::nextBreakablePositionIgnoringNBSP):
3279         Use (renamed) non-loose flavor of NBP.
3280         (WebCore::nextBreakablePositionLoose):
3281         (WebCore::nextBreakablePositionIgnoringNBSPLoose):
3282         Introduce loose flavor of NBP template expansions.
3283
3284         * rendering/break_lines.h:
3285         (WebCore):
3286         (WebCore::isBreakable):
3287         Add externally specified loose mode parameter to prevent need to invoke line break iterator
3288         accessor method on each invocation.
3289
3290 2014-11-21  Anders Carlsson  <andersca@apple.com>
3291
3292         More build fixes.
3293
3294         * Modules/mediastream/MediaStream.cpp:
3295         (WebCore::MediaStream::MediaStream):
3296
3297 2014-11-21  Eric Carlson  <eric.carlson@apple.com>
3298
3299         [iOS] allocate volume view on the main thread
3300         https://bugs.webkit.org/show_bug.cgi?id=138971
3301         rdar://problem/18016958
3302
3303         Reviewed by Jer Noble.
3304
3305         * platform/audio/ios/MediaSessionManagerIOS.mm:
3306         (-[WebMediaSessionHelper allocateVolumeView]): New, dispatch to the main thread if necessary before allocating
3307             the volume view.
3308         (-[WebMediaSessionHelper initWithCallback:]): Call allocateVolumeView.
3309
3310 2014-11-21  Zalan Bujtas  <zalan@apple.com>
3311
3312         REGRESSION(r175259) Simple line layout text measuring behavior changed.
3313         https://bugs.webkit.org/show_bug.cgi?id=138947
3314         rdar://problem/19050653
3315
3316         Reviewed by Antti Koivisto.
3317
3318         In certain cases, when block flow needs to compute the preferred width of a particular text
3319         renderer, we use the non-simple line layout text measuring.
3320         However, the same text renderer might end up at simple line layout later.
3321         Complex line layout measures text including the trailing space and it subtracts
3322         (the constant value of) space width afterwards, while simple line layout measures
3323         runs without the extra space.
3324         In such cases, this may result different word widths and produce unexpected line breaking. (preferred width != final width)
3325         In long term, any text renderer qualified for simple line layout should go through the simple
3326         text measuring code path. (https://bugs.webkit.org/show_bug.cgi?id=138973)
3327         For now, just copy complex line layout behaviour. This also matches the previous simple line layout line breaking implementation.
3328
3329         Test: fast/text/simple-line-text-measuring-with-trailing-space.html
3330
3331         * rendering/SimpleLineLayoutFlowContents.cpp:
3332         (WebCore::SimpleLineLayout::FlowContents::textWidth):
3333
3334 2014-11-21  Anders Carlsson  <andersca@apple.com>
3335
3336         More Windows build fixes.
3337
3338         * platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
3339         (WebCore::LegacyCACFLayerTreeHost::LegacyCACFLayerTreeHost):
3340         (WebCore::LegacyCACFLayerTreeHost::renderTimerFired):
3341         * platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
3342         * platform/mock/GeolocationClientMock.cpp:
3343         (WebCore::GeolocationClientMock::GeolocationClientMock):
3344         (WebCore::GeolocationClientMock::permissionTimerFired):
3345         (WebCore::GeolocationClientMock::controllerTimerFired):
3346         * platform/mock/GeolocationClientMock.h:
3347
3348 2014-11-21  Andreas Kling  <akling@apple.com>
3349
3350         RenderMathMLScripts isPrescript() helper should take a reference.
3351         <https://webkit.org/b/138975>
3352
3353         Reviewed by Antti Koivisto.
3354
3355         Tidy this up a bit, since it's never called with a null pointer.
3356
3357         * rendering/mathml/RenderMathMLScripts.cpp:
3358         (WebCore::isPrescript):
3359         (WebCore::RenderMathMLScripts::fixAnonymousStyles):
3360         (WebCore::RenderMathMLScripts::addChildInternal):
3361         (WebCore::RenderMathMLScripts::removeChildInternal):
3362         (WebCore::RenderMathMLScripts::layout):
3363         (WebCore::RenderMathMLScriptsWrapper::addChildInternal):
3364         (WebCore::RenderMathMLScriptsWrapper::removeChildInternal):
3365
3366 2014-11-21  Anders Carlsson  <andersca@apple.com>
3367
3368         Windows build fixes.
3369
3370         * plugins/PluginPackage.cpp:
3371         (WebCore::PluginPackage::freeLibraryTimerFired):
3372         (WebCore::PluginPackage::PluginPackage):
3373         * plugins/PluginPackage.h:
3374         * plugins/PluginStream.cpp:
3375         (WebCore::PluginStream::PluginStream):
3376         (WebCore::PluginStream::delayDeliveryTimerFired):
3377         (WebCore::PluginStream::deliverData): Deleted.
3378         * plugins/PluginStream.h:
3379         * plugins/PluginView.cpp:
3380         (WebCore::PluginView::popPopupsStateTimerFired):
3381         (WebCore::PluginView::requestTimerFired):
3382         (WebCore::PluginView::invalidateTimerFired):
3383         (WebCore::PluginView::PluginView):
3384         (WebCore::PluginView::lifeSupportTimerFired):
3385         (WebCore::PluginView::performRequest): Deleted.
3386         (WebCore::PluginView::setValue): Deleted.
3387         (WebCore::PluginView::setParameters): Deleted.
3388         (WebCore::PluginView::userAgent): Deleted.
3389         * plugins/PluginView.h:
3390         * plugins/win/PluginMessageThrottlerWin.cpp:
3391         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
3392         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
3393         * plugins/win/PluginMessageThrottlerWin.h:
3394
3395 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3396
3397         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
3398         https://bugs.webkit.org/show_bug.cgi?id=138960
3399         <rdar://problem/19056715>
3400
3401         Reviewed by Beth Dakin.
3402
3403         * platform/spi/mac/DataDetectorsSPI.h:
3404         Softlink some SPI.
3405
3406 2014-11-21  Tim Horton  <timothy_horton@apple.com>
3407
3408         Move TextIndicator{Window} to WebCore
3409         https://bugs.webkit.org/show_bug.cgi?id=138954
3410         <rdar://problem/18992185>
3411
3412         Some adjustments by Csaba Osztrogonác.
3413         Reviewed by Anders Carlsson.
3414
3415         Move TextIndicator and TextIndicatorWindow to WebCore so that both
3416         WebKits can share the implementation.
3417
3418         * CMakeLists.txt:
3419         Build TextIndicator.
3420
3421         * WebCore.exp.in:
3422         Export TextIndicator{Window} symbols for the WebKits.
3423
3424         * WebCore.xcodeproj/project.pbxproj:
3425         * page/TextIndicator.cpp: Renamed from Source/WebKit2/Shared/TextIndicator.cpp.
3426         * page/TextIndicator.h: Renamed from Source/WebKit2/Shared/TextIndicator.h.
3427         Straighforward move of TextIndicator from WebKit2, except:
3428
3429         Move TextIndicator::Data and TextIndicator::PresentationTransition out directly
3430         into the WebCore namespace to allow for implementation of WebKit2 argument coders.
3431
3432         Use Image instead of ShareableBitmap internally.
3433
3434         Move the TextIndicatorData encode/decode to WebCoreArgumentCoders.
3435         
3436         * page/mac/TextIndicatorWindow.h: Renamed from Source/WebKit2/UIProcess/mac/TextIndicatorWindow.h.
3437         * page/mac/TextIndicatorWindow.mm: Renamed from Source/WebKit2/UIProcess/mac/TextIndicatorWindow.mm.
3438         Straighforward move of TextIndicatorWindow from WebKit2.
3439
3440 2014-11-21  Anders Carlsson  <andersca@apple.com>
3441
3442         Remove the Timer parameters from timer callbacks
3443         https://bugs.webkit.org/show_bug.cgi?id=138974
3444
3445         Reviewed by Antti Koivisto.
3446
3447         * Modules/encryptedmedia/MediaKeySession.cpp:
3448         (WebCore::MediaKeySession::MediaKeySession):
3449         (WebCore::MediaKeySession::keyRequestTimerFired):
3450         (WebCore::MediaKeySession::addKeyTimerFired):
3451         * Modules/encryptedmedia/MediaKeySession.h:
3452         * Modules/geolocation/Geolocation.cpp:
3453         (WebCore::Geolocation::GeoNotifier::GeoNotifier):
3454         (WebCore::Geolocation::GeoNotifier::timerFired):
3455         (WebCore::Geolocation::Geolocation):
3456         (WebCore::Geolocation::resumeTimerFired):
3457         * Modules/geolocation/Geolocation.h:
3458         * Modules/indexeddb/IDBTransactionBackend.cpp:
3459         (WebCore::IDBTransactionBackend::IDBTransactionBackend):
3460         (WebCore::IDBTransactionBackend::taskTimerFired):
3461         * Modules/indexeddb/IDBTransactionBackend.h:
3462         * Modules/mediasource/SourceBuffer.cpp:
3463         (WebCore::SourceBuffer::SourceBuffer):
3464         (WebCore::SourceBuffer::appendBufferTimerFired):
3465         (WebCore::SourceBuffer::removeTimerFired):
3466         * Modules/mediasource/SourceBuffer.h:
3467         * Modules/mediastream/MediaStream.cpp:
3468         (WebCore::MediaStream::MediaStream):
3469         (WebCore::MediaStream::scheduledEventTimerFired):
3470         * Modules/mediastream/MediaStream.h:
3471         * Modules/mediastream/RTCDTMFSender.cpp: