Reduce usages of String::createUninitialized
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-08-17  Annie Sullivan  <sullivan@chromium.org>
2
3         Reduce usages of String::createUninitialized
4         https://bugs.webkit.org/show_bug.cgi?id=66399
5
6         Constructs Strings with StringBuilder instead of calling createUninitialized.
7
8         Reviewed by Adam Barth.
9
10         No new tests; no functional change.
11
12         * dom/StyleElement.cpp:
13         (WebCore::StyleElement::process):
14         * dom/Text.cpp:
15         (WebCore::Text::wholeText):
16         * html/parser/HTMLSourceTracker.cpp:
17         (WebCore::HTMLSourceTracker::sourceForToken):
18         * platform/graphics/Font.cpp:
19         (WebCore::Font::normalizeSpaces):
20         * platform/text/TextCodecUserDefined.cpp:
21         (WebCore::TextCodecUserDefined::decode):
22
23 2011-08-17  Emil A Eklund  <eae@chromium.org>
24
25         Switch FrameView to to new layout types
26         https://bugs.webkit.org/show_bug.cgi?id=66147
27
28         Reviewed by Eric Seidel.
29
30         Convert Frame & FrameView to new layout abstraction as a part of the
31         ongoing conversion work.
32
33         No new tests, no new functionality.
34
35         * page/Frame.cpp:
36         (WebCore::Frame::visiblePositionForPoint):
37         (WebCore::Frame::documentAtPoint):
38         (WebCore::Frame::rangeForPoint):
39         (WebCore::Frame::setPageAndTextZoomFactors):
40         (WebCore::Frame::scalePage):
41         * page/Frame.h:
42         * page/FrameView.cpp:
43         (WebCore::FrameView::create):
44         (WebCore::FrameView::reset):
45         (WebCore::FrameView::init):
46         (WebCore::FrameView::invalidateRect):
47         (WebCore::FrameView::setFrameRect):
48         (WebCore::FrameView::setMarginWidth):
49         (WebCore::FrameView::setMarginHeight):
50         (WebCore::FrameView::setContentsSize):
51         (WebCore::FrameView::adjustViewSize):
52         (WebCore::FrameView::scrollXForFixedPosition):
53         (WebCore::FrameView::scrollYForFixedPosition):
54         (WebCore::FrameView::scrollOffsetForFixedPosition):
55         (WebCore::FrameView::currentMousePosition):
56         (WebCore::FrameView::scrollContentsFastPath):
57         (WebCore::FrameView::scrollContentsSlowPath):
58         (WebCore::FrameView::setScrollPosition):
59         (WebCore::FrameView::repaintContentRectangle):
60         (WebCore::FrameView::scrollToAnchor):
61         (WebCore::FrameView::performPostLayoutTasks):
62         (WebCore::FrameView::windowClipRect):
63         (WebCore::FrameView::windowClipRectForLayer):
64         (WebCore::FrameView::scrollTo):
65         (WebCore::FrameView::invalidateScrollbarRect):
66         (WebCore::FrameView::getTickmarks):
67         (WebCore::FrameView::windowResizerRect):
68         (WebCore::FrameView::setVisibleScrollerThumbRect):
69         (WebCore::FrameView::paintScrollCorner):
70         (WebCore::FrameView::paintContents):
71         (WebCore::FrameView::paintOverhangAreas):
72         (WebCore::FrameView::forceLayoutForPagination):
73         (WebCore::FrameView::convertFromRenderer):
74         (WebCore::FrameView::convertToRenderer):
75         (WebCore::FrameView::convertToContainingView):
76         (WebCore::FrameView::convertFromContainingView):
77         * page/FrameView.h:
78         (WebCore::FrameView::marginWidth):
79         (WebCore::FrameView::marginHeight):
80         * page/mac/FrameMac.mm:
81         (WebCore::Frame::snapshotDragImage):
82         (WebCore::Frame::nodeImage):
83
84 2011-08-17  Emil A Eklund  <eae@chromium.org>
85
86         Switch html/* to to new layout types
87         https://bugs.webkit.org/show_bug.cgi?id=66347
88
89         Reviewed by Eric Seidel.
90
91         Convert HTML* and shadow element to new layout abstraction as a part of
92         the ongoing conversion work.
93
94         No new tests, no new functionality.
95
96         * html/HTMLAreaElement.cpp:
97         (WebCore::HTMLAreaElement::invalidateCachedRegion):
98         (WebCore::HTMLAreaElement::mapMouseEvent):
99         (WebCore::HTMLAreaElement::computePath):
100         (WebCore::HTMLAreaElement::computeRect):
101         (WebCore::HTMLAreaElement::getRegion):
102         * html/HTMLAreaElement.h:
103         * html/HTMLCanvasElement.cpp:
104         (WebCore::HTMLCanvasElement::paint):
105         * html/HTMLCanvasElement.h:
106         * html/HTMLMapElement.cpp:
107         (WebCore::HTMLMapElement::mapMouseEvent):
108         * html/HTMLMapElement.h:
109         * html/ImageDocument.cpp:
110         (WebCore::ImageDocumentParser::finish):
111         (WebCore::ImageDocument::scale):
112         (WebCore::ImageDocument::resizeImageToFit):
113         (WebCore::ImageDocument::imageFitsInWindow):
114         * html/ValidationMessage.cpp:
115         (WebCore::adjustBubblePosition):
116         * html/canvas/CanvasRenderingContext2D.cpp:
117         (WebCore::size):
118         (WebCore::CanvasRenderingContext2D::drawImage):
119         * html/shadow/MediaControlElements.cpp:
120         (WebCore::MediaControlPanelElement::startDrag):
121         (WebCore::MediaControlPanelElement::continueDrag):
122         (WebCore::MediaControlPanelElement::setPosition):
123         (WebCore::MediaControlPanelElement::defaultEventHandler):
124         * html/shadow/MediaControlElements.h:
125         * html/shadow/SliderThumbElement.cpp:
126         (WebCore::SliderThumbElement::dragFrom):
127         (WebCore::SliderThumbElement::setPositionFromPoint):
128         * html/shadow/SliderThumbElement.h:
129         * rendering/RenderImage.cpp:
130         (WebCore::RenderImage::nodeAtPoint):
131
132 2011-08-17  David Grogan  <dgrogan@chromium.org>
133
134         Change references to leveldb.gyp to leveldatabase.gyp as part of the
135         leveldb refactoring going on in chromium: crbug.com/89378
136         https://bugs.webkit.org/show_bug.cgi?id=66332
137
138         Reviewed by Tony Gentilcore.
139
140         Tests: new-run-webkit-tests --debug --chromium --no-retry-failures --build-directory=llvm storage/indexeddb
141
142         * WebCore.gyp/WebCore.gyp:
143
144 2011-08-17  Hayato Ito  <hayato@chromium.org>
145
146         Implement proper handling of focus/blur events in regard to shadow DOM boundaries.
147         https://bugs.webkit.org/show_bug.cgi?id=61421
148
149         Reviewed by Dimitri Glazkov.
150
151         Introduces FocusEventDispatchMediator/BlurEventDispatchMediator so
152         that focus/blue events are stopped at the lowest common shadow boundary.
153
154         * dom/Document.cpp:
155         (WebCore::Document::setFocusedNode):
156         * dom/Event.cpp:
157         (WebCore::FocusEventDispatchMediator::create):
158         (WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
159         (WebCore::FocusEventDispatchMediator::dispatchEvent):
160         (WebCore::BlurEventDispatchMediator::create):
161         (WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
162         (WebCore::BlurEventDispatchMediator::dispatchEvent):
163         * dom/Event.h:
164         * dom/Node.cpp:
165         (WebCore::Node::dispatchFocusEvent):
166         (WebCore::Node::dispatchBlurEvent):
167         * dom/Node.h:
168         * html/HTMLFormControlElement.cpp:
169         (WebCore::HTMLFormControlElement::dispatchBlurEvent):
170         * html/HTMLFormControlElement.h:
171         * html/HTMLSelectElement.cpp:
172         (WebCore::HTMLSelectElement::dispatchFocusEvent):
173         (WebCore::HTMLSelectElement::dispatchBlurEvent):
174         * html/HTMLSelectElement.h:
175         * html/HTMLTextFormControlElement.cpp:
176         (WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
177         (WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
178         * html/HTMLTextFormControlElement.h:
179         * page/FocusController.cpp:
180         (WebCore::dispatchEventsOnWindowAndFocusedNode):
181
182 2011-08-17  Ben Wells  <benwells@chromium.org>
183
184         Canvas fill and fillRect with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
185         https://bugs.webkit.org/show_bug.cgi?id=66036
186
187         These modes cannot be passed straight through to the underlying graphics context as the graphics context
188         and the HTML5 canvas spec have different interpretations to them. In the graphics context, the compositing
189         modes are applied just over the area being filled. In the HTML5 spec, the compositing modes are applied over
190         the entire canvas.
191
192         The SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy modes all need some kind of extra action
193         to just performing the composited fill on the canvas, as they need t he canvas to be cleared outside of the 
194         area being filled.
195
196         Previous to this change the Copy mode did not do this clearing at all. The other modes did but if the
197         transformed path being filled contained anti-aliasing at its edges artifacts were introduced.
198
199         With this change, Copy now does a complete erase of the canvas before performing a fill as per normal.
200         The other modes use a temporary buffer just big enough for the transformed path (in device coordinates).
201         The fill is first done there in SourceOver mode. Then this is drawn into the canvas context using the
202         appropriate mode, with any areas outside the draw area being cleared.
203
204         Reviewed by James Robinson.
205
206         Test: fast/canvas/canvas-composite-transformclip.html
207
208         * html/HTMLCanvasElement.h:
209         * html/canvas/CanvasRenderingContext2D.cpp:
210         (WebCore::CanvasRenderingContext2D::fill):
211         (WebCore::CanvasRenderingContext2D::fillRect):
212         (WebCore::CanvasRenderingContext2D::clearCanvas):
213         (WebCore::CanvasRenderingContext2D::transformAreaToDevice):
214         (WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
215         * html/canvas/CanvasRenderingContext2D.h:
216         * platform/graphics/skia/ImageBufferSkia.cpp:
217         (WebCore::ImageBuffer::ImageBuffer):
218
219 2011-08-17  Emil A Eklund  <eae@chromium.org>
220
221         Switch inspector to to new layout types
222         https://bugs.webkit.org/show_bug.cgi?id=66358
223
224         Reviewed by Eric Seidel.
225
226         Convert inspector code to new layout abstraction as a part of the ongoing
227         conversion work.
228
229         No new tests, no new functionality.
230
231         * inspector/DOMNodeHighlighter.cpp:
232         (WebCore::DOMNodeHighlighter::drawNodeHighlight):
233         * inspector/InspectorInstrumentation.cpp:
234         (WebCore::InspectorInstrumentation::willPaintImpl):
235         * inspector/InspectorInstrumentation.h:
236         (WebCore::InspectorInstrumentation::willPaint):
237         * inspector/InspectorTimelineAgent.cpp:
238         (WebCore::InspectorTimelineAgent::willPaint):
239         * inspector/InspectorTimelineAgent.h:
240         * inspector/TimelineRecordFactory.cpp:
241         (WebCore::TimelineRecordFactory::createPaintData):
242         * inspector/TimelineRecordFactory.h:
243
244 2011-08-17  Levi Weintraub  <leviw@chromium.org>
245
246         Switch Editing code to new layout types
247         https://bugs.webkit.org/show_bug.cgi?id=66355
248
249         Reviewed by Eric Seidel.
250
251         Converting remaining editing code to the LayoutUnit abstraction.
252
253         No new tests, no change in functionality.
254
255         * editing/Editor.cpp:
256         (WebCore::Editor::rangeForPoint):
257         (WebCore::Editor::insideVisibleArea):
258         (WebCore::Editor::countMatchesForText):
259         * editing/Editor.h:
260         * editing/mac/FrameSelectionMac.mm:
261         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
262
263 2011-08-17  Levi Weintraub  <leviw@chromium.org>
264
265         Switch Accessibility code to new layout types
266         https://bugs.webkit.org/show_bug.cgi?id=66348
267
268         Reviewed by Eric Seidel.
269
270         Converting remaining Accessibility code to the LayoutUnit abstraction.
271
272         No new tests, no change in functionality
273
274         * accessibility/AccessibilityImageMapLink.cpp:
275         (WebCore::AccessibilityImageMapLink::elementRect):
276         * accessibility/AccessibilityImageMapLink.h:
277         * accessibility/AccessibilityListBox.cpp:
278         (WebCore::AccessibilityListBox::elementAccessibilityHitTest):
279         * accessibility/AccessibilityListBox.h:
280         * accessibility/AccessibilityListBoxOption.cpp:
281         (WebCore::AccessibilityListBoxOption::elementRect):
282         * accessibility/AccessibilityListBoxOption.h:
283         * accessibility/AccessibilityMenuListOption.cpp:
284         (WebCore::AccessibilityMenuListOption::elementRect):
285         * accessibility/AccessibilityMenuListOption.h:
286         (WebCore::AccessibilityMenuListOption::size):
287         * accessibility/AccessibilityMenuListPopup.h:
288         (WebCore::AccessibilityMenuListPopup::elementRect):
289         (WebCore::AccessibilityMenuListPopup::size):
290         * accessibility/AccessibilityObject.cpp:
291         (WebCore::AccessibilityObject::clickPoint):
292         (WebCore::AccessibilityObject::orientation):
293         (WebCore::AccessibilityObject::elementAccessibilityHitTest):
294         * accessibility/AccessibilityObject.h:
295         (WebCore::AccessibilityObject::accessibilityHitTest):
296         (WebCore::AccessibilityObject::boundingBoxRect):
297         (WebCore::AccessibilityObject::size):
298         (WebCore::AccessibilityObject::boundsForVisiblePositionRange):
299         (WebCore::AccessibilityObject::doAXBoundsForRange):
300         * accessibility/AccessibilityRenderObject.cpp:
301         (WebCore::AccessibilityRenderObject::isOffScreen):
302         (WebCore::AccessibilityRenderObject::boundingBoxRect):
303         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
304         (WebCore::AccessibilityRenderObject::elementRect):
305         (WebCore::AccessibilityRenderObject::size):
306         (WebCore::AccessibilityRenderObject::clickPoint):
307         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
308         (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
309         (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
310         (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
311         * accessibility/AccessibilityRenderObject.h:
312         * accessibility/AccessibilityScrollView.cpp:
313         (WebCore::AccessibilityScrollView::accessibilityHitTest):
314         (WebCore::AccessibilityScrollView::elementRect):
315         * accessibility/AccessibilityScrollView.h:
316         * accessibility/AccessibilityScrollbar.cpp:
317         (WebCore::AccessibilityScrollbar::elementRect):
318         * accessibility/AccessibilityScrollbar.h:
319         * accessibility/AccessibilitySlider.cpp:
320         (WebCore::AccessibilitySliderThumb::elementRect):
321         (WebCore::AccessibilitySliderThumb::size):
322         * accessibility/AccessibilitySlider.h:
323         * accessibility/AccessibilityTableColumn.cpp:
324         (WebCore::AccessibilityTableColumn::elementRect):
325         (WebCore::AccessibilityTableColumn::size):
326         * accessibility/AccessibilityTableColumn.h:
327         * accessibility/AccessibilityTableHeaderContainer.cpp:
328         (WebCore::AccessibilityTableHeaderContainer::elementRect):
329         (WebCore::AccessibilityTableHeaderContainer::size):
330         * accessibility/AccessibilityTableHeaderContainer.h:
331         * accessibility/mac/AccessibilityObjectWrapper.mm:
332         (-[AccessibilityObjectWrapper position]):
333         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
334         (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
335
336 2011-08-17  Emil A Eklund  <eae@chromium.org>
337
338         Switch focus handling to to new layout types
339         https://bugs.webkit.org/show_bug.cgi?id=66331
340
341         Reviewed by Eric Seidel.
342
343         Convert FocusController and SpatialNavigation to new layout abstraction
344         as a part of the ongoing conversion work.
345
346         No new tests, no new functionality.
347
348         * page/FocusController.cpp:
349         (WebCore::updateFocusCandidateIfNeeded):
350         (WebCore::FocusController::findFocusCandidateInContainer):
351         (WebCore::FocusController::advanceFocusDirectionallyInContainer):
352         (WebCore::FocusController::advanceFocusDirectionally):
353         * page/FocusController.h:
354         * page/SpatialNavigation.cpp:
355         (WebCore::alignmentForRects):
356         (WebCore::start):
357         (WebCore::middle):
358         (WebCore::end):
359         (WebCore::areRectsFullyAligned):
360         (WebCore::areRectsPartiallyAligned):
361         (WebCore::areRectsMoreThanFullScreenApart):
362         (WebCore::below):
363         (WebCore::rightOf):
364         (WebCore::isRectInDirection):
365         (WebCore::hasOffscreenRect):
366         (WebCore::scrollInDirection):
367         (WebCore::deflateIfOverlapped):
368         (WebCore::canScrollInDirection):
369         (WebCore::rectToAbsoluteCoordinates):
370         (WebCore::nodeRectInAbsoluteCoordinates):
371         (WebCore::frameRectInAbsoluteCoordinates):
372         (WebCore::entryAndExitPointsForDirection):
373         (WebCore::distanceDataForNode):
374         (WebCore::canBeScrolledIntoView):
375         (WebCore::virtualRectForDirection):
376         (WebCore::virtualRectForAreaElementAndDirection):
377         * page/SpatialNavigation.h:
378
379 2011-08-17  Levi Weintraub  <leviw@chromium.org>
380
381         Switch Document, DocumentMarker, Clipboard, and Range to new layout types
382         https://bugs.webkit.org/show_bug.cgi?id=66330
383
384         Reviewed by Eric Seidel.
385
386         Converting the remaining DOM classes to use the LayoutUnit abstraction.
387
388         No new tests, no new behavior.
389
390         * dom/Clipboard.h:
391         (WebCore::Clipboard::dragLocation):
392         * dom/Document.cpp:
393         (WebCore::Document::nodesFromRect):
394         (WebCore::nodeFromPoint):
395         (WebCore::Document::caretRangeFromPoint):
396         (WebCore::Document::prepareMouseEvent):
397         * dom/Document.h:
398         * dom/DocumentMarkerController.cpp:
399         (WebCore::DocumentMarkerController::markerContainingPoint):
400         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
401         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
402         * dom/DocumentMarkerController.h:
403         * dom/Range.cpp:
404         (WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
405         * dom/RenderedDocumentMarker.h:
406         (WebCore::RenderedDocumentMarker::contains):
407         (WebCore::RenderedDocumentMarker::setRenderedRect):
408         (WebCore::RenderedDocumentMarker::renderedRect):
409         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
410         (WebCore::RenderedDocumentMarker::invalidate):
411
412 2011-08-17  Dan Bernstein  <mitz@apple.com>
413
414         Removed an unused setting.
415
416         Reviewed by Anders Carlsson.
417
418         * WebCore.exp.in:
419         * page/Settings.cpp:
420         (WebCore::Settings::Settings): Removed initializer for m_needsTigerMailQuirks.
421         * page/Settings.h: Removed accessors.
422
423 2011-08-17  Oliver Hunt  <oliver@apple.com>
424
425         Move towards supporting user controlled prototypes on CanvasPixelArray
426         https://bugs.webkit.org/show_bug.cgi?id=66429
427
428         Reviewed by Gavin Barraclough.
429
430         Start using a per-global object structure for canvas pixel array.
431
432         * bindings/js/JSImageDataCustom.cpp:
433         (WebCore::toJS):
434
435 2011-08-17  Luke Macpherson   <macpherson@chromium.org>
436
437         Support cast from CSSPrimitiveValue to unsigned, and use in appropriate places in CSSStyleSelector::applyProperty
438         https://bugs.webkit.org/show_bug.cgi?id=66281
439
440         Reviewed by Eric Seidel.
441
442         No new tests - refactoring only.
443
444         The return if type!=CSS_NUMBER case becomes an ASSERT because it is unreachable unless there is an error in the parser.
445
446         * css/CSSPrimitiveValueMappings.h:
447         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
448         Support cast from unsigned to CSSPrimitiveValue
449         (WebCore::CSSPrimitiveValue::operator unsigned):
450         Support cast from CSSPrimitiveValue to unsigned
451         * css/CSSStyleSelector.cpp:
452         (WebCore::CSSStyleSelector::applyProperty):
453         Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for CSSPropertyWebkitBoxFlex,
454         CSSPropertyWebkitBoxFlexGroup and CSSPropertyWebkitBoxOrdinalGroup properties.
455
456 2011-08-17  Scott Byer  <scottbyer@chromium.org>
457
458         ScrollAnimatorNone: Remove unused field
459         https://bugs.webkit.org/show_bug.cgi?id=66312
460
461         Reviewed by Adam Barth.
462
463         No functional change; no test needed.
464
465         * platform/ScrollAnimatorNone.cpp:
466         (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
467         (WebCore::ScrollAnimatorNone::scroll):
468         * platform/ScrollAnimatorNone.h:
469
470 2011-08-17  Jeff Miller  <jeffm@apple.com>
471
472         Work-in-progress on Soft link against AVFoundationCF and CoreMedia
473         https://bugs.webkit.org/show_bug.cgi?id=65725
474         
475         Don't bother with SOFT_LINK_LIBRARY(libdispatch), we're going to continue to statically link to it since
476         the DLL will have already been loaded by other parts of AAS and is guaranteed to be available if AVFoundation
477         is enabled.
478
479         Reviewed by Anders Carlsson.
480
481         No new tests; no functional change.
482
483         * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Removed SOFT_LINK_DEBUG_LIBRARY(libdispatch) and SOFT_LINK_LIBRARY(libdispatch).
484         (WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable): Don't check for libdispatch.
485
486 2011-08-17  Brady Eidson  <beidson@apple.com>
487
488         https://bugs.webkit.org/show_bug.cgi?id=66354 and <rdar://problem/9965209>
489         Regression:  On Lion, redirects lose HTTP authentication headers
490
491         Reviewed by Alexey Proskuryakov and Darin Adler.
492
493         This changes makes WebCore try to apply basic credentials after a redirect if the redirect is to the same origin,
494         assuming the redirected URL did not contain credentials directly.
495
496         Tests: http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html
497                http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
498                http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html
499
500         * platform/network/cf/ResourceHandleCFNet.cpp:
501         (WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
502         (WebCore::ResourceHandle::createCFURLConnection): Use the applyBasicAuthorizationHeader helper.
503         (WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.
504
505         * platform/network/mac/ResourceHandleMac.mm:
506         (WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
507         (WebCore::ResourceHandle::createNSURLConnection): Use the applyBasicAuthorizationHeader helper.
508         (WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.
509
510 2011-08-17  Chris Fleizach  <cfleizach@apple.com>
511
512         Accessibility stack exhaustion using role attribute
513         https://bugs.webkit.org/show_bug.cgi?id=65174
514
515         Reviewed by Darin Adler.
516
517         Forgot to commit review comments.
518
519         * accessibility/AccessibilityRenderObject.cpp:
520         (WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
521
522 2011-08-17  Chris Fleizach  <cfleizach@apple.com>
523
524         Accessibility stack exhaustion using role attribute
525         https://bugs.webkit.org/show_bug.cgi?id=65174
526
527         Make sure we do not call accessibilityIsIgnored() during the AccessibilityObject
528         creation flow. That can lead to loops.
529    
530         Reviewed by Darin Adler.
531
532         Tests: accessibility/crash-determining-aria-role-when-label-present.html
533
534         * accessibility/AccessibilityObject.cpp:
535         (WebCore::createARIARoleMap):
536         * accessibility/AccessibilityRenderObject.cpp:
537         (WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
538         (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
539         * accessibility/AccessibilityRenderObject.h:
540
541 2011-08-17  James Robinson  <jamesr@chromium.org>
542
543         [chromium] Crash if compositing is disabled during updateLayers()
544         https://bugs.webkit.org/show_bug.cgi?id=66353
545
546         Reviewed by Kenneth Russell.
547
548         If compositing is turned off during LayerRendererChromium::updateLayers(), the rootLayer() will become null.
549         Sicne CCLayerTreeHost::doComposite() calls updateLayers() and then drawLayers() without checking for this case,
550         drawLayers() has to return without doing anything if the root layer is null.
551
552         Crash fixed based on crash reports.  No known reliably repro case, unfortunately.
553
554         * platform/graphics/chromium/LayerRendererChromium.cpp:
555         (WebCore::LayerRendererChromium::drawLayers):
556
557 2011-08-17  Dan Bernstein  <mitz@apple.com>
558
559         <rdar://problem/9971293> Mid-word breaks can occur in the middle of a surrogate pair
560         https://bugs.webkit.org/show_bug.cgi?id=66402
561
562         Reviewed by Dave Hyatt.
563
564         Test: fast/text/midword-break-before-surrogate-pair-2.html
565
566         * rendering/RenderBlockLineLayout.cpp:
567         (WebCore::RenderBlock::LineBreaker::nextLineBreak): Just never allow a mid-word
568         break before a trailing surrogate.
569
570 2011-08-16  Chang Shu  <cshu@webkit.org>
571
572         Support reset in WebCore::Internals
573         https://bugs.webkit.org/show_bug.cgi?id=66307
574
575         Reviewed by Dimitri Glazkov.
576
577         New tests will be added when function reset is implemented.
578
579         Added framework code in WebCoreTestSupport. The real implementation of
580         Internals::reset() depends on the need from the settings that require a reset.
581
582         * testing/Internals.cpp:
583         (WebCore::Internals::reset):
584         * testing/Internals.h:
585         * testing/js/WebCoreTestSupport.cpp:
586         (WebCoreTestSupport::resetInternalsObject):
587         * testing/js/WebCoreTestSupport.h:
588         * testing/v8/WebCoreTestSupport.cpp:
589         (WebCoreTestSupport::resetInternalsObject):
590         * testing/v8/WebCoreTestSupport.h:
591
592 2011-08-17  Tony Chang  <tony@chromium.org>
593
594         Fix chromium mac compile.  MediaPlayerPrivateAVFoundationObjC.* moved
595         and the WebCore.gypi file wasn't updated.
596
597         * WebCore.gypi:
598
599 2011-08-17  Abhishek Arya  <inferno@chromium.org>
600
601         Crash in Document::recalcStyleSelector
602         https://bugs.webkit.org/show_bug.cgi?id=66335
603
604         Reviewed by Simon Fraser.
605
606         When node is getting destroyed and its removedFromDocument
607         is not called due to entire document structure torn down(using
608         removeAllChildren), make sure to clear out the stylesheet
609         candidate node from document's structures in its destructor.
610
611         Test: svg/dom/stylesheet-candidate-node-crash-main.html
612
613         * dom/ProcessingInstruction.cpp:
614         (WebCore::ProcessingInstruction::~ProcessingInstruction):
615         * html/HTMLLinkElement.cpp:
616         (WebCore::HTMLLinkElement::~HTMLLinkElement):
617         * html/HTMLStyleElement.cpp:
618         (WebCore::HTMLStyleElement::~HTMLStyleElement):
619         * svg/SVGStyleElement.cpp:
620         (WebCore::SVGStyleElement::~SVGStyleElement):
621
622 2011-08-17  Sam White  <samuel.white@rochester.edu>
623
624         AccessibilityObject levels are inconsistent
625         https://bugs.webkit.org/show_bug.cgi?id=66180
626         
627         Updated accessibilityTable to return level values consistent with other accessibilityObjects that
628         return level values. This means a value of 0 is now only returned when tableLevel() is called on a
629         non-table element.
630
631         Reviewed by Chris Fleizach.
632
633         Test: platform/mac/accessibility/element-level.html
634
635         * accessibility/AccessibilityTable.cpp:
636         (WebCore::AccessibilityTable::tableLevel):
637         * accessibility/mac/AccessibilityObjectWrapper.mm:
638         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
639
640 2011-08-17  Ryosuke Niwa  <rniwa@webkit.org>
641
642         An arrow key collapses directionless selection range in the wrong direction in BiDi
643         https://bugs.webkit.org/show_bug.cgi?id=64626
644
645         Reviewed by Darin Adler.
646
647         The bug was caused by willBeModified's always using block direction to determine
648         the direction to which the selection is collapsed. Fixed the bug by calling directionOfSelection
649         in willBeModified, which will return the text direction of the surrounding context when
650         the start and the end have the same direction. When the text directions at the start and at the end
651         of selection do not match, it uses the block's text direction.
652
653         Test: editing/selection/collapse-selection-in-bidi.html
654
655         * editing/FrameSelection.cpp:
656         (WebCore::FrameSelection::directionOfSelection): Added.
657         (WebCore::FrameSelection::willBeModified): Calls directionOfSelection.
658         (WebCore::FrameSelection::modifyMovingRight): Ditto.
659         (WebCore::FrameSelection::modifyMovingLeft): Ditto.
660         * editing/FrameSelection.h:
661
662 2011-08-17  Jeff Miller  <jeffm@apple.com>
663
664         Some AVFoundation source files should be in platform-specific directories
665         https://bugs.webkit.org/show_bug.cgi?id=66352
666         
667         Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf,
668         and moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
669         
670         While I was at it, added svn:eol-style property to the MediaPlayerPrivateAVFoundationObjC.* files.
671         
672         Also, for some reason, Visual Studio decided to re-sort a couple files in \inspector\front-end\ in WebCore.vcproj, even though
673         I just re-sorted the project in r93215.
674
675         Reviewed by Eric Carlson.
676
677         No new tests; no functional change.
678
679         * WebCore.vcproj/WebCore.vcproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf.
680
681         * WebCore.vcproj/WebCoreMediaQT.vsprops: Added $(ProjectDir)..\platform\graphics\avfoundation\cf to include paths.
682
683         * WebCore.xcodeproj/project.pbxproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
684
685         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Removed.
686         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Removed.
687         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Removed.
688         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Removed.
689
690         * platform/graphics/avfoundation/cf: Added.
691         * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp.
692         * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h.
693
694         * platform/graphics/avfoundation/objc: Added.
695         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h.
696         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm.
697
698 2011-08-17  Luke Macpherson   <macpherson@chromium.org>
699
700         Only set m_fontDirty if TextSizeAdjust is actually changed.
701         https://bugs.webkit.org/show_bug.cgi?id=66022
702
703         Reviewed by Darin Adler.
704
705         No new tests. Refactoring only.
706
707         Reduces instances where the font information is dirtied to save recalculation where it is not necessary.
708
709         * css/CSSStyleSelector.cpp:
710         (WebCore::CSSStyleSelector::applyProperty):
711         Call new setTextSizeAdjust function.
712         * css/CSSStyleSelector.h:
713         (WebCore::CSSStyleSelector::setTextSizeAdjust):
714         Add wrapper for RenderStyle::setTextSizeAdjust() that automatically updates m_fontDirty.
715         * rendering/style/RenderStyle.h:
716         (WebCore::RenderStyle::setTextSizeAdjust):
717         Make setTextSizeAdjust return true if the unlderlying value was changed.
718
719 2011-08-17  Kenichi Ishibashi  <bashi@chromium.org>
720
721         [Chromium] Crash in HarfbuzzFace::~HarfbuzzFace
722         https://bugs.webkit.org/show_bug.cgi?id=66211
723
724         Holds Skia's unique font ID instead of FontPlatformData to avoid accessing freed FontPlatformData.
725
726         Reviewed by Tony Chang.
727
728         No new tests; no functional change.
729
730         * platform/graphics/chromium/HarfbuzzSkia.cpp:
731         (WebCore::releaseCachedHarfbuzzFace): Changed the argument.
732         (WebCore::HarfbuzzFace::HarfbuzzFace): Changed to have Skia's font uniqueID instead of FontPlatformData.
733         (WebCore::HarfbuzzFace::~HarfbuzzFace): Uses m_uniqueID to call releaseCachedHarfbuzzFace.
734         * platform/graphics/chromium/HarfbuzzSkia.h:
735
736 2011-08-17  Jeff Miller  <jeffm@apple.com>
737
738         Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
739
740         * WebCore.vcproj/WebCore.vcproj:
741
742 2011-08-17  Sailesh Agrawal  <sail@chromium.org>
743
744         Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface
745         https://bugs.webkit.org/show_bug.cgi?id=66311
746
747         Reviewed by Dimitri Glazkov.
748
749         Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.
750
751         * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
752         (wkScrollbarMinimumTotalLengthNeededForThumb):
753
754 2011-08-17  Steve Block  <steveblock@google.com>
755
756         Unreviewed, rolling out r93186.
757         http://trac.webkit.org/changeset/93186
758         https://bugs.webkit.org/show_bug.cgi?id=66114
759
760         Breaks LayoutTests on Chromium canary bots
761
762         * platform/graphics/chromium/LayerChromium.h:
763         * platform/graphics/chromium/LayerRendererChromium.cpp:
764         (WebCore::LayerRendererChromium::updateLayers):
765         (WebCore::LayerRendererChromium::drawLayersInternal):
766         (WebCore::LayerRendererChromium::drawLayer):
767         * platform/graphics/chromium/cc/CCLayerImpl.h:
768
769 2011-08-17  Ryosuke Niwa  <rniwa@webkit.org>
770
771         Get rid of calls to deprecatedNode and deprecatedEditingOffset in
772         AccessibilityRenderObject.cpp and InsertTextCommand.cpp
773         https://bugs.webkit.org/show_bug.cgi?id=66014
774
775         Reviewed by Hajime Morita.
776
777         Removed calls to deprecatedNode and deprecatedEditingOffsets in the following files.
778
779         * accessibility/AccessibilityRenderObject.cpp:
780         (WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls Position::rootEditableElement
781         and Range::setEnd(const Position&, ExceptionCode) instead of manually pulling deprecatedNode
782         and deprecatedEditingOffset.
783         (WebCore::AccessibilityRenderObject::index): Abstracted the logic to loop through render objects
784         from deprecatedNodes' renderer to m_renderer as renderObjectContainsPosition.
785         * dom/Position.h:
786         (WebCore::Position::rootEditableElement): Added.
787         * dom/Range.cpp:
788         (WebCore::Range::setStart): Added.
789         (WebCore::Range::setEnd): Added.
790         * dom/Range.h:
791         * editing/InsertTextCommand.cpp:
792         (WebCore::InsertTextCommand::insertTab):
793         * editing/RenderedPosition.cpp:
794         (WebCore::renderObjectContainsPosition): Extracted from AccessibilityRenderObject::index.
795         * editing/RenderedPosition.h:
796
797 2011-08-17  Sailesh Agrawal  <sail@chromium.org>
798
799         Chromium Mac: Fix issue where scrollbar wouldn't be drawn until page finished loading
800         https://bugs.webkit.org/show_bug.cgi?id=66238
801
802         Reviewed by Dimitri Glazkov.
803
804         Overlay scrollbars were not visible if the user scrolled a page while the page was loading. The sequence of events necessary to reproduce this bug were:
805           1. -[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:] is called
806           2. animation is delayed because shouldSuspendScrollAnimations() is true
807           3. ScrollAnimatorChromiumMac::scroll() is called before the ScrollAnimatorChromiumMac::m_initialScrollbarPaintTimer is fired.
808           4. At this point the scrollbar painter assumes the scrollbar is already visible (because of 1.) so the scrollbar's alpha stays at 0. Thus the scrollbar isn't visible until the page finishes loading.
809         It turns out that the root problem was that when the initialScrollbarPainterTimer fired I wasn't flashing the scrollbar correctly. My implementation of wkScrollbarPainterForceFlashScrollers() just called flashScrollers. The Safari implementation of this function also calls hideOverlayScrollers. Calling hideOverlayScrollers causes the alpha to change to 0 which prevents step 4 from happening.
810
811         Also, now that wkScrollbarPainterForceFlashScrollers is working correctly I don't need the extra logic I added to the initialScrollbarPainterTimer handler. That logic restarted the timer if shouldSuspendScrollAnimations() was true. But this isn't necessary since calling wkScrollbarPainterForceFlashScrollers() causes -[ScrollbarPainterDelegate setUpAnimation:...] to be called which does the exact same thing. Removing the extra logic reverts http://trac.webkit.org/changeset/92316.
812
813         * platform/chromium/ScrollAnimatorChromiumMac.mm:
814         (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
815         * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
816         (wkScrollbarPainterForceFlashScrollers):
817
818 2011-08-16  Andrey Kosyakov  <caseq@chromium.org>
819
820         Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
821         https://bugs.webkit.org/show_bug.cgi?id=66131
822
823         Reviewed by Pavel Feldman.
824
825         Test: inspector/view-events.html
826
827         - added a notion of an optional parent to a View
828         - maintain a list of View children
829         - dispatch common view events, such as show/hide/resize automatically through the hierarchy of visible views.
830         - promoted Panel's logic of (re)storing scroll positions to view
831         - demoted inheritScrollPositionFromView to a couple of views that need it.
832
833         * inspector/front-end/ApplicationCacheItemsView.js:
834         (WebInspector.ApplicationCacheItemsView.prototype.onResize):
835         * inspector/front-end/ConsoleView.js:
836         (WebInspector.ConsoleView.prototype.populateStatusBar):
837         (WebInspector.ConsoleView.prototype.elementsToRestoreScrollPositionsFor):
838         * inspector/front-end/CookieItemsView.js:
839         (WebInspector.CookieItemsView.prototype.onResize):
840         (WebInspector.SimpleCookiesTable.prototype.onResize):
841         * inspector/front-end/DOMStorageItemsView.js:
842         (WebInspector.DOMStorageItemsView.prototype.onResize):
843         * inspector/front-end/DetailedHeapshotView.js:
844         (WebInspector.DetailedHeapshotView.prototype.onResize):
845         * inspector/front-end/Drawer.js:
846         (WebInspector.Drawer.prototype.set visibleView):
847         (WebInspector.Drawer.prototype.show):
848         (WebInspector.Drawer.prototype.hide):
849         (WebInspector.Drawer.prototype.onResize):
850         (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
851         (WebInspector.Drawer.prototype._animateDrawerHeight):
852         (WebInspector.Drawer.prototype._statusBarDragging):
853         (WebInspector.Drawer.prototype._endStatusBarDragging):
854         * inspector/front-end/ElementsPanel.js:
855         (WebInspector.ElementsPanel.prototype.onResize):
856         * inspector/front-end/ExtensionPanel.js:
857         * inspector/front-end/FontView.js:
858         (WebInspector.FontView.prototype.onResize):
859         * inspector/front-end/IFrameView.js:
860         (WebInspector.IFrameView):
861         * inspector/front-end/NetworkItemView.js:
862         (WebInspector.NetworkItemView.prototype._installHighlightSupport):
863         * inspector/front-end/NetworkPanel.js:
864         (WebInspector.NetworkLogView):
865         (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor):
866         (WebInspector.NetworkLogView.prototype.onResize):
867         (WebInspector.NetworkLogView.prototype.wasShown):
868         (WebInspector.NetworkLogView.prototype.willHide):
869         (WebInspector.NetworkPanel):
870         (WebInspector.NetworkPanel.prototype.show):
871         (WebInspector.NetworkPanel.prototype._showResource):
872         (WebInspector.NetworkPanel.prototype._closeVisibleResource):
873         * inspector/front-end/Panel.js:
874         (WebInspector.Panel.prototype.show):
875         (WebInspector.Panel.prototype.hide):
876         (WebInspector.Panel.prototype.performSearch.processChunk):
877         (WebInspector.Panel.prototype.performSearch):
878         (WebInspector.Panel.prototype.updateSidebarWidth):
879         * inspector/front-end/PanelEnablerView.js:
880         (WebInspector.PanelEnablerView.prototype.show):
881         (WebInspector.PanelEnablerView.prototype.onResize):
882         * inspector/front-end/ProfileView.js:
883         (WebInspector.CPUProfileView.prototype.onResize):
884         * inspector/front-end/ProfilesPanel.js:
885         (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
886         * inspector/front-end/ResourceCookiesView.js:
887         (WebInspector.ResourceCookiesView.prototype.onResize):
888         * inspector/front-end/ResourcePreviewView.js:
889         (WebInspector.ResourcePreviewView.prototype.contentLoaded):
890         * inspector/front-end/ResourceResponseView.js:
891         (WebInspector.ResourceResponseView.prototype.contentLoaded):
892         * inspector/front-end/ResourceTimingView.js:
893         (WebInspector.ResourceTimingView.prototype.show):
894         * inspector/front-end/ResourcesPanel.js:
895         (WebInspector.ResourcesPanel.prototype.show):
896         (WebInspector.ResourcesPanel.prototype._innerShowView):
897         (WebInspector.ResourcesPanel.prototype.closeVisibleView):
898         (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
899         (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
900         * inspector/front-end/ScriptsPanel.js:
901         (WebInspector.ScriptsPanel.prototype.show):
902         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
903         (WebInspector.ScriptsPanel.prototype._removeSourceFrame):
904         (WebInspector.ScriptsPanel.prototype.setSidebarWidth):
905         * inspector/front-end/SourceFrame.js:
906         (WebInspector.SourceFrame):
907         (WebInspector.SourceFrame.prototype.show):
908         (WebInspector.SourceFrame.prototype.willHide):
909         (WebInspector.SourceFrame.prototype.clearMessages):
910         (WebInspector.SourceFrame.prototype._setTextViewerDecorations):
911         (WebInspector.SourceFrame.prototype.inheritScrollPositions):
912         * inspector/front-end/TabbedPane.js:
913         (WebInspector.TabbedPane.prototype.appendTab):
914         * inspector/front-end/TextViewer.js:
915         (WebInspector.TextViewer.prototype.elementsToRestoreScrollPositionsFor):
916         (WebInspector.TextViewer.prototype.inheritScrollPositions):
917         (WebInspector.TextViewer.prototype.onResize):
918         * inspector/front-end/TimelinePanel.js:
919         (WebInspector.TimelinePanel.prototype.onResize):
920         (WebInspector.TimelinePanel.prototype.elementsToRestoreScrollPositionsFor):
921         (WebInspector.TimelinePanel.prototype.show):
922         * inspector/front-end/View.js:
923         (WebInspector.View):
924         (WebInspector.View.prototype.wasShown):
925         (WebInspector.View.prototype.willHide):
926         (WebInspector.View.prototype._innerShow):
927         (WebInspector.View.prototype.show):
928         (WebInspector.View.prototype._innerHide):
929         (WebInspector.View.prototype.hide):
930         (WebInspector.View.prototype._detach):
931         (WebInspector.View.prototype.elementsToRestoreScrollPositionsFor):
932         (WebInspector.View.prototype.storeScrollPositions):
933         (WebInspector.View.prototype.restoreScrollPositions):
934         (WebInspector.View.prototype.addChildView):
935         (WebInspector.View.prototype.removeChildView):
936         (WebInspector.View.prototype.onResize):
937         (WebInspector.View.prototype.doResize):
938         (WebInspector.View.prototype.dispatchToSelfAndVisibleChildren):
939         (WebInspector.View.prototype.dispatchToVisibleChildren):
940         * inspector/front-end/inspector.js:
941         (WebInspector.windowResize):
942
943 2011-08-16  Luke Macpherson   <macpherson@chromium.org>
944
945         Represent RenderStyle::textOverflow property using an enum instead of a bool.
946         https://bugs.webkit.org/show_bug.cgi?id=66356
947
948         Reviewed by Dan Bernstein.
949
950         No new tests - no behavioral changes.
951
952         * css/CSSPrimitiveValueMappings.h:
953         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
954         Support cast from TextOverflow to CSSPrimitiveValue.
955         (WebCore::CSSPrimitiveValue::operator TextOverflow):
956         Support cast from CSSPrimitiveValue to TextOverflow.
957         * css/CSSStyleSelector.cpp:
958         (WebCore::CSSStyleSelector::applyProperty):
959         Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.
960         * rendering/style/RenderStyle.h:
961         (WebCore::InheritedFlags::textOverflow):
962         Return TextOverflow enum.
963         (WebCore::InheritedFlags::setTextOverflow):
964         Accept TextOverflow enum parameter.
965         (WebCore::InheritedFlags::initialTextOverflow):
966         Return TextOverflowClip.
967         * rendering/style/RenderStyleConstants.h:
968         Define TextOverflow enum.
969         * rendering/style/StyleRareNonInheritedData.h:
970         Change representation of text overflow from bool to one-bit unsigned.
971
972 2011-08-16  Jeff Miller  <jeffm@apple.com>
973
974         Apple's Windows production build should fail to compile if AVFoundation is not enabled
975         https://bugs.webkit.org/show_bug.cgi?id=66339
976         
977         Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
978
979         Reviewed by Darin Adler.
980
981         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
982
983 2011-08-16  David Levin  <levin@chromium.org>
984
985         REGRESSION (r89086): All worker xhr requests trigger preflight requests.
986         https://bugs.webkit.org/show_bug.cgi?id=66340
987
988         Reviewed by Adam Barth.
989
990         Test coming in a more comprehensive patch shortly. This is just a very targetted
991         patch to allow for easier merging.
992
993         * loader/CrossOriginAccessControl.cpp:
994         (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
995         of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
996         set before calling this function. This is similar to what is done for "origin" in here.
997
998 2011-08-16  Shawn Singh  <shawnsingh@chromium.org>
999
1000         Computing screen-space transform for LayerChromium and CCLayerImpl
1001         https://bugs.webkit.org/show_bug.cgi?id=66114
1002
1003         Reviewed by James Robinson.
1004
1005         Test: compositing/backface-visibility-hierarchical-transform.html
1006
1007         Added a data member to LayerChromium and CCLayerImpl that holds
1008         the screen-space transform.   The transform is computed in
1009         calculateDrawTransformsAndVisibility(), which is used during
1010         updating (LayerChromium) and drawing (CCLayerImpl).  This transform
1011         will also be used for other things, such as HUD drawing, in upcoming
1012         patches.
1013
1014         Also fixed a FIXME in LayerRendererChromium::drawLayer, which
1015         was not computing the entire hierarchy of transforms to determine
1016         back-face visibility.  Now it simply uses the screen space transform.
1017
1018         * platform/graphics/chromium/LayerChromium.h:
1019         (WebCore::LayerChromium::screenSpaceDrawTransform):
1020         (WebCore::LayerChromium::setScreenSpaceDrawTransform):
1021         * platform/graphics/chromium/LayerRendererChromium.cpp:
1022         (WebCore::LayerRendererChromium::updateLayers):
1023         (WebCore::LayerRendererChromium::drawLayersInternal):
1024         (WebCore::LayerRendererChromium::drawLayer):
1025         (WebCore::calculateDrawTransformsAndVisibility):
1026         * platform/graphics/chromium/cc/CCLayerImpl.h:
1027         (WebCore::CCLayerImpl::screenSpaceDrawTransform):
1028         (WebCore::CCLayerImpl::setScreenSpaceDrawTransform):
1029
1030 2011-08-16  Hayato Ito  <hayato@chromium.org>
1031
1032         Implement proper handling of events which happen in children of shadow hosts.
1033         https://bugs.webkit.org/show_bug.cgi?id=66285
1034
1035         Reviewed by Dimitri Glazkov.
1036
1037         Fix the issue where a shadow host stops an event propagation if an
1038         event happens at the children of shadow hosts, outside of the shadow root.
1039
1040         Test: fast/dom/shadow/shadow-contents-event.html
1041
1042         * dom/EventDispatcher.cpp:
1043         (WebCore::EventDispatcher::adjustToShadowBoundaries):
1044
1045 2011-08-16  Per-Erik Brodin  <per-erik.brodin@ericsson.com>
1046
1047         Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions
1048         https://bugs.webkit.org/show_bug.cgi?id=65694
1049
1050         Reviewed by Alexey Proskuryakov.
1051
1052         No new tests since there is no change in behavior.
1053
1054         * fileapi/FileReaderLoader.cpp:
1055         (WebCore::FileReaderLoader::start):
1056         * loader/DocumentThreadableLoader.cpp:
1057         (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
1058         (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
1059         * loader/ThreadableLoader.h:
1060         (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
1061         * notifications/Notification.cpp:
1062         (WebCore::Notification::startLoading):
1063         * xml/XMLHttpRequest.cpp:
1064         (WebCore::XMLHttpRequest::createRequest):
1065
1066 2011-08-16  Scott Byer  <scottbyer@chromium.org>
1067
1068         Fix spelling error.
1069         https://bugs.webkit.org/show_bug.cgi?id=66261
1070
1071         Reviewed by Adam Barth.
1072
1073         No functional change, no tests needed.
1074
1075         * platform/ScrollAnimator.cpp:
1076         (WebCore::ScrollAnimator::scroll):
1077         (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
1078         (WebCore::ScrollAnimator::notifyPositionChanged):
1079         * platform/ScrollAnimator.h:
1080         * platform/ScrollAnimatorNone.cpp:
1081         (WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
1082         (WebCore::ScrollAnimatorNone::animationTimerFired):
1083         * platform/ScrollAnimatorWin.cpp:
1084         (WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
1085         (WebCore::ScrollAnimatorWin::animateScroll):
1086         * platform/chromium/ScrollAnimatorChromiumMac.h:
1087         * platform/chromium/ScrollAnimatorChromiumMac.mm:
1088         (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
1089         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
1090         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
1091         (WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):
1092         * platform/mac/ScrollAnimatorMac.h:
1093         * platform/mac/ScrollAnimatorMac.mm:
1094         (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
1095         (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
1096         (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
1097         (WebCore::ScrollAnimatorMac::notifyPositionChanged):
1098
1099 2011-08-16  Joseph Pecoraro  <joepeck@webkit.org>
1100
1101         ASSERT in fast/css/custom-font-xheight.html
1102         https://bugs.webkit.org/show_bug.cgi?id=66328
1103
1104         Reviewed by Dan Bernstein.
1105
1106         In r93140 the temporary font created for a remote CSS font face
1107         was created without being retained. We need to protect the
1108         font from being purged while we hold onto it, so add a font cache
1109         purge preventer.
1110
1111         * css/CSSFontFaceSource.cpp:
1112         (WebCore::CSSFontFaceSource::getFontData):
1113
1114 2011-08-16  Joseph Pecoraro  <joepeck@webkit.org>
1115
1116         Unreviewed Chromium Windows build fix after r93140. Take 4.
1117         Namespace the now public enum as FontCache::ShouldRetain.
1118
1119         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
1120         (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
1121
1122 2011-08-15  Stephen White  <senorblanco@chromium.org>
1123
1124         Canvas resizing can be slow
1125         https://bugs.webkit.org/show_bug.cgi?id=66251
1126
1127         Canvas resizing was slow due to re-allocation of the ImageBuffer on
1128         each size change (width or height).  This was introduced inadvertently
1129         by calls to isAccelerated() during canvas reset().  Since we won't 
1130         know if we have successfully accelerated until ImageBuffer creation,
1131         move the compositor invalidation to createImageBuffer() as well.
1132         This patch also attempts to unify the Skia and CG accelerated canvas
1133         paths.  The DrawingBuffer used by the Skia path is now owned by 
1134         ImageBuffer[Skia], similar to how the IOSurface is owned by
1135         ImageBuffer[CG].  Some of the logic for when to accelerate was moved
1136         into HTMLCanvasElement and unified with the CG path.  Acceleration is
1137         also now enabled by the same "Accelerated" ImageBuffer create flag
1138         used by the CG path.  DrawingBuffer is now re-created even for a 
1139         same-size change (same as the memory buffer), but we speed it up
1140         by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr
1141         instead of GraphicsContext3D::teximage2DResourceSafe() (no need to
1142         clear it, since it's done with a glClear anyway).
1143
1144         Reviewed by Kenneth Russell.
1145
1146         Covered by existing tests in fast/canvas and canvas/philip.
1147
1148         * html/HTMLCanvasElement.cpp:
1149         (WebCore::HTMLCanvasElement::reset):
1150         Don't call isAccelerated() from reset(), since we don't want to
1151         inadvertently create the ImageBuffer.  Also, since we won't know if
1152         we have successfully accelerated until createImageBuffer() is
1153         called, defer the compositor invalidation to createImageBuffer() as
1154         well.
1155         (WebCore::HTMLCanvasElement::shouldAccelerate):
1156         Unify the CG and Skia ports' logic for when to accelerate (Skia
1157         logic moved in from CanvasRenderingContext2D).
1158         (WebCore::HTMLCanvasElement::createImageBuffer):
1159         Use the unified shouldAccelerate() logic, and pass it as a flag
1160         to ImageBuffer.  Do compositor invalidation as well.
1161         * html/HTMLCanvasElement.h:
1162         (WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
1163         Expose hasCreatedImageBuffer() publically, so
1164         CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create
1165         it.
1166         * html/canvas/CanvasRenderingContext2D.cpp:
1167         (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
1168         (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
1169         Remove all acceleration setting and resetting, since it's now done
1170         during ImageBuffer creation.
1171         (WebCore::CanvasRenderingContext2D::isAccelerated):
1172         Check if the image buffer was created, so we don't inadvertently
1173         create it here.
1174         (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
1175         Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its
1176         WebViewImpl may be null.  Ask the render tree instead.
1177         (WebCore::CanvasRenderingContext2D::reset):
1178         Don't reset acceleration here, since we don't own it anymore.
1179         (WebCore::CanvasRenderingContext2D::platformLayer):
1180         Call into the ImageBuffer to get our PlatformLayer.
1181         * html/canvas/CanvasRenderingContext2D.h:
1182         Remove m_drawingBuffer, and all acceleration-related calls.
1183         * platform/graphics/GraphicsContext.cpp:
1184         * platform/graphics/GraphicsContext.h:
1185         Remove setGraphicsContext3D(), and paintsIntoImageBuffer().
1186         * platform/graphics/ImageBuffer.cpp:
1187         (WebCore::ImageBuffer::platformLayer):
1188         Implement a dummy platformLayer() call for non-skia ports.
1189         * platform/graphics/ImageBuffer.h:
1190         Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).
1191         * platform/graphics/chromium/ImageBufferDataSkia.h:
1192         Add a DrawingBuffer data member.
1193         * platform/graphics/gpu/DrawingBuffer.cpp:
1194         (WebCore::DrawingBuffer::reset):
1195         Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().
1196         Since we immediately clear the framebuffer via glClear(), this whole
1197         resource safe business is overkill.
1198         * platform/graphics/skia/GraphicsContextSkia.cpp:
1199         Remove setGraphicsContext3D() and paintsIntoImageBuffer().  This
1200         functionality is handled by ImageBuffer now.
1201         * platform/graphics/skia/ImageBufferSkia.cpp:
1202         (WebCore::ImageBuffer::ImageBuffer):
1203         Give the ImageBufferData ownership of the DrawingBuffer.
1204         (WebCore::ImageBuffer::platformLayer):
1205         Implement an accessor for the DrawingBuffer's PlatformLayer.
1206         * platform/graphics/skia/PlatformContextSkia.cpp:
1207         (WebCore::PlatformContextSkia::setGraphicsContext3D):
1208         * platform/graphics/skia/PlatformContextSkia.h:
1209         Remove isPathSkiaSafe() extern (unused).
1210         Remove paintsIntoImageBuffer() (now unused).  Remove IntSize param
1211         from setGraphicsContext3D() (unused).
1212
1213 2011-08-16  Joseph Pecoraro  <joepeck@webkit.org>
1214
1215         Unreviewed Chromium Windows build fix after r93140. Take 3.
1216         Include the proper includes!
1217
1218         * platform/graphics/FontCache.h:
1219
1220 2011-08-16  Mihnea Ovidenie  <mihnea@adobe.com>
1221
1222         Unmatrix algorithm implementation is wrong
1223         https://bugs.webkit.org/show_bug.cgi?id=66080
1224
1225         Reviewed by Dean Jackson.
1226
1227         Current version of the algorithm negates only the scaleX while
1228         it should negate also scaleY and scaleZ when appropriate.
1229
1230         Test: animations/animation-matrix-negative-scale-unmatrix.html
1231
1232         * platform/graphics/transforms/TransformationMatrix.cpp:
1233         (WebCore::decompose):
1234
1235 2011-08-16  Joseph Pecoraro  <joepeck@webkit.org>
1236
1237         Unreviewed Chromium Windows build fix after r93140.
1238
1239         This just makes the troublesome enum public. If this
1240         fixes the build I will file a follow-up bug to clean-up
1241         these build issues and either keep the enum public and
1242         cleanup other functions or restore the enum to private.
1243         There is no harm in making the enum public right now.
1244
1245         * platform/graphics/FontCache.h:
1246
1247 2011-08-16  Joseph Pecoraro  <joepeck@webkit.org>
1248
1249         Unreviewed Chromium Windows build fix after r93140.
1250
1251         * platform/graphics/FontCache.h:
1252
1253 2011-08-16  Joseph Pecoraro  <joepeck@webkit.org>
1254
1255         Unreviewed Windows and Chromium Windows build fix after r93140.
1256
1257         * platform/graphics/FontCache.h:
1258         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
1259         (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
1260         (WebCore::getLastResortFallbackFontProc):
1261         (WebCore::FontCache::getLastResortFallbackFont):
1262         * platform/graphics/win/FontCacheWin.cpp:
1263         (WebCore::FontCache::fontDataFromDescriptionAndLogFont):
1264         (WebCore::FontCache::getLastResortFallbackFont):
1265
1266 2011-08-16  Adam Roben  <aroben@apple.com>
1267
1268         Make placeholder text remain visible until a character is typed on Windows
1269
1270         Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
1271         is focused on Windows, which doesn't match Lion or Windows native text fields
1272
1273         Covered by existing tests (which are currently failing on the bots until this patch lands).
1274
1275         Reviewed by Dave Hyatt.
1276
1277         * rendering/RenderThemeSafari.h:
1278         (WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):
1279         * rendering/RenderThemeWin.h:
1280         (WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
1281         Added overrides to return true.
1282
1283 2011-08-16  David Hyatt  <hyatt@apple.com>
1284
1285         https://bugs.webkit.org/show_bug.cgi?id=66254
1286
1287         Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into
1288         repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread
1289         content.
1290
1291         Reviewed by Simon Fraser.
1292
1293         Added new tests in fast/repaint.
1294
1295         * rendering/RenderFlowThread.cpp:
1296         (WebCore::RenderFlowThread::repaintRectangleInRegions):
1297         * rendering/RenderFlowThread.h:
1298         * rendering/RenderObject.cpp:
1299         (WebCore::RenderObject::enclosingRenderFlowThread):
1300         (WebCore::RenderObject::containerForRepaint):
1301         (WebCore::RenderObject::repaintUsingContainer):
1302         * rendering/RenderObject.h:
1303         * rendering/RenderView.cpp:
1304         (WebCore::RenderView::RenderView):
1305         (WebCore::RenderView::renderFlowThreadWithName):
1306         * rendering/RenderView.h:
1307         (WebCore::RenderView::hasRenderFlowThreads):
1308
1309 2011-08-16  Joseph Pecoraro  <joepeck@webkit.org>
1310
1311         Abandoned Memory: Temporary CSS Fonts May Never Be Purged
1312         https://bugs.webkit.org/show_bug.cgi?id=66153
1313
1314         Reviewed by Dan Bernstein.
1315
1316         While a remote CSS font face is loading we fallback to a
1317         temporary font. We don't want to retain the fallback font
1318         because noone takes ownership of the temporary font. This
1319         patch adds a way to get an uncached fallback font, which
1320         plumbs the ShouldRetain enum through the different platform
1321         implementations of getLastResortFallbackFont.
1322
1323         No new tests, no functional change.
1324
1325         * css/CSSFontFaceSource.cpp:
1326         (WebCore::CSSFontFaceSource::getFontData):
1327         * platform/graphics/FontCache.cpp:
1328         (WebCore::FontCache::getNonRetainedLastResortFallbackFont):
1329         * platform/graphics/FontCache.h:
1330         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
1331         (WebCore::fontDataFromDescriptionAndLogFont):
1332         (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
1333         (WebCore::getLastResortFallbackFontProc):
1334         (WebCore::FontCache::getLastResortFallbackFont):
1335         * platform/graphics/chromium/FontCacheLinux.cpp:
1336         (WebCore::FontCache::getLastResortFallbackFont):
1337         * platform/graphics/freetype/FontCacheFreeType.cpp:
1338         (WebCore::FontCache::getLastResortFallbackFont):
1339         * platform/graphics/haiku/FontCacheHaiku.cpp:
1340         (WebCore::FontCache::getLastResortFallbackFont):
1341         * platform/graphics/mac/FontCacheMac.mm:
1342         (WebCore::FontCache::getLastResortFallbackFont):
1343         * platform/graphics/pango/FontCachePango.cpp:
1344         (WebCore::FontCache::getLastResortFallbackFont):
1345         * platform/graphics/qt/FontCacheQt.cpp:
1346         (WebCore::FontCache::getLastResortFallbackFont):
1347         * platform/graphics/win/FontCacheWin.cpp:
1348         (WebCore::fontDataFromDescriptionAndLogFont):
1349         (WebCore::FontCache::getLastResortFallbackFont):
1350         * platform/graphics/wince/FontCacheWinCE.cpp:
1351         * platform/graphics/wx/FontCacheWx.cpp:
1352         (WebCore::FontCache::getLastResortFallbackFont):
1353
1354 2011-08-16  Alexei Svitkine  <asvitkine@chromium.org>
1355
1356         Chromium Mac: Rubber banding gutter drawing
1357         https://bugs.webkit.org/show_bug.cgi?id=66226
1358
1359         Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
1360         draw the overhang areas.
1361         Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
1362         Add a different implementation for Chromium Mac.
1363
1364         Reviewed by Dimitri Glazkov.
1365
1366         No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
1367
1368         * platform/ScrollView.cpp:
1369         (WebCore::ScrollView::wheelEvent):
1370         * platform/ScrollbarTheme.h:
1371         (WebCore::ScrollbarTheme::paintOverhangAreas):
1372         * platform/ScrollbarThemeComposite.cpp:
1373         (WebCore::ScrollbarThemeComposite::paintOverhangAreas):
1374         * platform/ScrollbarThemeComposite.h:
1375         * platform/chromium/ScrollbarThemeChromiumMac.h:
1376         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1377         (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
1378         (WebCore::scrollbarStateToThemeState):
1379         (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
1380         (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
1381
1382 2011-08-12  Wyatt Carss  <wcarss@chromium.org>
1383
1384         Programmatically set selection should not have direction on Mac
1385         https://bugs.webkit.org/show_bug.cgi?id=60529
1386
1387         Reviewed by Ryosuke Niwa.
1388
1389         Modified default value of VisibleSelection->m_isDirectional from 'true'
1390         to 'false' by adding a defaulted argument to several VisibleSelection 
1391         constructors to make programmatic selection be directionless by default 
1392         on Mac. Also modified several calls to VisibleSelection's constructors
1393         to correctly preserve directionality.
1394         
1395         Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)
1396         a call to setExtent triggers an editing delegate that uses the
1397         FrameSelection. The direction here should have been preserved from before,
1398         but setIsDirectional was not called until after FrameSelection.cpp:869. It
1399         has been moved up to make things behave.
1400
1401         * WebCore.exp.in:
1402         * editing/ApplyBlockElementCommand.cpp:
1403         (WebCore::ApplyBlockElementCommand::doApply):
1404         (WebCore::ApplyBlockElementCommand::formatSelection):
1405         * editing/ApplyStyleCommand.cpp:
1406         (WebCore::ApplyStyleCommand::updateStartEnd):
1407         * editing/BreakBlockquoteCommand.cpp:
1408         (WebCore::BreakBlockquoteCommand::doApply):
1409         * editing/CompositeEditCommand.cpp:
1410         (WebCore::CompositeEditCommand::moveParagraphWithClones):
1411         (WebCore::CompositeEditCommand::moveParagraphs):
1412         (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
1413         (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
1414         * editing/CreateLinkCommand.cpp:
1415         (WebCore::CreateLinkCommand::doApply):
1416         * editing/DeleteSelectionCommand.cpp:
1417         (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
1418         (WebCore::DeleteSelectionCommand::doApply):
1419         * editing/Editor.cpp:
1420         (WebCore::Editor::selectionForCommand):
1421         * editing/FrameSelection.cpp:
1422         (WebCore::shouldAlwaysUseDirectionalSelection):
1423         (WebCore::FrameSelection::FrameSelection):
1424         (WebCore::FrameSelection::moveTo):
1425         (WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
1426         (WebCore::FrameSelection::modify):
1427         (WebCore::FrameSelection::setBase):
1428         (WebCore::FrameSelection::setExtent):
1429         * editing/FrameSelection.h:
1430         * editing/InsertLineBreakCommand.cpp:
1431         (WebCore::InsertLineBreakCommand::doApply):
1432         * editing/InsertListCommand.cpp:
1433         (WebCore::InsertListCommand::doApply):
1434         * editing/InsertParagraphSeparatorCommand.cpp:
1435         (WebCore::InsertParagraphSeparatorCommand::doApply):
1436         * editing/InsertTextCommand.cpp:
1437         (WebCore::InsertTextCommand::performTrivialReplace):
1438         (WebCore::InsertTextCommand::doApply):
1439         * editing/MoveSelectionCommand.cpp:
1440         (WebCore::MoveSelectionCommand::doApply):
1441         * editing/ReplaceSelectionCommand.cpp:
1442         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
1443         * editing/TypingCommand.cpp:
1444         (WebCore::TypingCommand::makeEditableRootEmpty):
1445         (WebCore::TypingCommand::deleteKeyPressed):
1446         (WebCore::TypingCommand::forwardDeleteKeyPressed):
1447         * editing/VisibleSelection.cpp:
1448         (WebCore::VisibleSelection::VisibleSelection):
1449         * editing/VisibleSelection.h:
1450         * page/EventHandler.cpp:
1451         (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
1452         (WebCore::EventHandler::updateSelectionForMouseDrag):
1453
1454 2011-08-16  Jeffrey Pfau  <jpfau@apple.com>
1455
1456         New XML parser: Add document fragment parser
1457         https://bugs.webkit.org/show_bug.cgi?id=66317
1458
1459         Reviewed by Adam Barth.
1460
1461         * dom/DocumentFragment.cpp:
1462         (WebCore::DocumentFragment::parseXML):
1463         * xml/parser/NewXMLDocumentParser.cpp:
1464         (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
1465         (WebCore::NewXMLDocumentParser::parseDocumentFragment):
1466         * xml/parser/NewXMLDocumentParser.h:
1467         (WebCore::NewXMLDocumentParser::create):
1468         * xml/parser/XMLTokenizer.h:
1469         * xml/parser/XMLTreeBuilder.cpp:
1470         (WebCore::XMLTreeBuilder::XMLTreeBuilder):
1471         (WebCore::XMLTreeBuilder::pushCurrentNode):
1472         * xml/parser/XMLTreeBuilder.h:
1473         (WebCore::XMLTreeBuilder::create):
1474         (WebCore::XMLTreeBuilder::NodeStackItem::node):
1475
1476 2011-08-16  Jeffrey Pfau  <jpfau@apple.com>
1477
1478         New XML parser: Replace assertions regarding character data in the prolog with proper checks
1479         https://bugs.webkit.org/show_bug.cgi?id=66269
1480
1481         Reviewed by Adam Barth.
1482
1483         This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.
1484
1485         * xml/parser/XMLTreeBuilder.cpp:
1486         (WebCore::XMLTreeBuilder::processProcessingInstruction):
1487         (WebCore::XMLTreeBuilder::processXMLDeclaration):
1488         (WebCore::XMLTreeBuilder::processDOCTYPE):
1489         (WebCore::XMLTreeBuilder::enterText):
1490         (WebCore::XMLTreeBuilder::failOnText):
1491         * xml/parser/XMLTreeBuilder.h:
1492
1493 2011-08-16  Alexander Pavlov  <apavlov@chromium.org>
1494
1495         Web Inspector: word wrap long edits
1496         https://bugs.webkit.org/show_bug.cgi?id=65512
1497
1498         Reviewed by Pavel Feldman.
1499
1500         * inspector/front-end/inspector.css:
1501         (.styles-section .properties li.child-editing):
1502
1503 2011-08-16  Pavel Feldman  <pfeldman@google.com>
1504
1505         Web Inspector: convert DOM breakpoint types to strings.
1506         https://bugs.webkit.org/show_bug.cgi?id=66304
1507
1508         Reviewed by Yury Semikhatsky.
1509
1510         * inspector/Inspector.json:
1511         * inspector/InspectorDOMDebuggerAgent.cpp:
1512         (WebCore::domTypeForName):
1513         (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
1514         (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
1515         * inspector/InspectorDOMDebuggerAgent.h:
1516         * inspector/front-end/DOMBreakpointsSidebarPane.js:
1517         (WebInspector.DOMBreakpointsSidebarPane):
1518
1519 2011-08-16  Pavel Feldman  <pfeldman@google.com>
1520
1521         Web Inspector: force pseudo element state when checking it in the styles sidebar.
1522         https://bugs.webkit.org/show_bug.cgi?id=66292
1523
1524         This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
1525         calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
1526         they are guarded with the inline checks for the front-end count.
1527
1528         Reviewed by David Hyatt.
1529
1530         * css/CSSStyleSelector.cpp:
1531         (WebCore::CSSStyleSelector::initForStyleResolve):
1532         (WebCore::CSSStyleSelector::styleRulesForElement):
1533         (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
1534         (WebCore::CSSStyleSelector::checkSelector):
1535         (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
1536         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
1537         * css/CSSStyleSelector.h:
1538         * inspector/InspectorCSSAgent.cpp:
1539         (WebCore::computePseudoClassMask):
1540         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
1541         (WebCore::InspectorCSSAgent::clearFrontend):
1542         (WebCore::InspectorCSSAgent::forcePseudoState):
1543         (WebCore::InspectorCSSAgent::getStylesForNode):
1544         (WebCore::InspectorCSSAgent::didRemoveDocument):
1545         (WebCore::InspectorCSSAgent::didRemoveDOMNode):
1546         (WebCore::InspectorCSSAgent::clearPseudoState):
1547         * inspector/InspectorCSSAgent.h:
1548         * inspector/InspectorController.cpp:
1549         (WebCore::InspectorController::disconnectFrontend):
1550         * inspector/InspectorInstrumentation.cpp:
1551         (WebCore::InspectorInstrumentation::forcePseudoStateImpl):
1552         * inspector/InspectorInstrumentation.h:
1553         (WebCore::InspectorInstrumentation::forcePseudoState):
1554
1555 2011-08-16  Tony Chang  <tony@chromium.org>
1556
1557         Unreviewed, rolling out r93114.
1558         http://trac.webkit.org/changeset/93114
1559         https://bugs.webkit.org/show_bug.cgi?id=66226
1560
1561         broke the chromium mac compile
1562
1563         * platform/ScrollView.cpp:
1564         (WebCore::ScrollView::wheelEvent):
1565         * platform/ScrollbarTheme.h:
1566         * platform/ScrollbarThemeComposite.cpp:
1567         * platform/ScrollbarThemeComposite.h:
1568         * platform/chromium/ScrollbarThemeChromiumMac.h:
1569         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1570         (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
1571         (WebCore::scrollbarStateToThemeState):
1572         (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
1573         * platform/mac/ScrollbarThemeMac.h:
1574
1575 2011-08-16  Alexei Svitkine  <asvitkine@chromium.org>
1576
1577         Chromium Mac: Rubber banding gutter drawing
1578         https://bugs.webkit.org/show_bug.cgi?id=66226
1579
1580         Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
1581         draw the overhang areas.
1582         Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
1583         Add a different implementation for Chromium Mac.
1584
1585         Reviewed by Dimitri Glazkov.
1586
1587         No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
1588
1589         * platform/ScrollView.cpp:
1590         (WebCore::ScrollView::wheelEvent):
1591         * platform/ScrollbarTheme.h:
1592         (WebCore::ScrollbarTheme::paintOverhangAreas):
1593         * platform/ScrollbarThemeComposite.cpp:
1594         (WebCore::ScrollbarThemeComposite::paintOverhangAreas):
1595         * platform/ScrollbarThemeComposite.h:
1596         * platform/chromium/ScrollbarThemeChromiumMac.h:
1597         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1598         (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
1599         (WebCore::scrollbarStateToThemeState):
1600         (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
1601         (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
1602
1603 2011-08-16  Luke Macpherson   <macpherson@chromium.org>
1604
1605         Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.
1606         https://bugs.webkit.org/show_bug.cgi?id=66273
1607
1608         Reviewed by Simon Fraser.
1609
1610         No new tests - no functionality changed - refactoring only.
1611
1612         * css/CSSPrimitiveValueMappings.h:
1613         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1614         Define cast from CSSPrimitiveValue to ETransformStyle3D.
1615         (WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
1616         Define cast from ETransformStyle3D to CSSPrimitiveValue.
1617         * css/CSSStyleSelector.cpp:
1618         (WebCore::CSSStyleSelector::applyProperty):
1619         Use appropriate macro to handle CSSPropertyWebkitTransformStyle.
1620
1621 2011-08-16  Luke Macpherson   <macpherson@chromium.org>
1622
1623         Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()
1624         https://bugs.webkit.org/show_bug.cgi?id=66279
1625
1626         Reviewed by Simon Fraser.
1627
1628         No new tests - no functionality changed - simple refactoring only.
1629
1630         * css/CSSStyleSelector.cpp:
1631         (WebCore::CSSStyleSelector::applyProperty):
1632         Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
1633         This works because PrimitiveValue now supports cast to int.
1634
1635 2011-08-16  Eric Carlson  <eric.carlson@apple.com>
1636
1637         [REGRESSION] Media controls should always be enabled when scripting is disabled
1638         https://bugs.webkit.org/show_bug.cgi?id=66303
1639
1640         Reviewed by Dimitri Glazkov.
1641
1642         Tests: media/video-controls-no-scripting-iframe.html
1643                media/video-controls-no-scripting.html
1644
1645         * html/HTMLMediaElement.cpp:
1646         (WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code
1647             to configureMediaControls.
1648         (WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.
1649         (WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in 
1650             attributeChanged and preDispatchEventHandler here.
1651         (WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code
1652             to configureMediaControls.
1653         * html/HTMLMediaElement.h:
1654
1655 2011-08-16  Pavel Feldman  <pfeldman@google.com>
1656
1657         Web Inspector: hide non-conservative methods from the protocol documentation.
1658         https://bugs.webkit.org/show_bug.cgi?id=66301
1659
1660         Reviewed by Yury Semikhatsky.
1661
1662         * inspector/Inspector.json:
1663
1664 2011-08-16  Andras Becsi  <abecsi@webkit.org>
1665
1666         Web Inspector: nuke background events collection (dead feature)
1667         https://bugs.webkit.org/show_bug.cgi?id=66296
1668
1669         Fix the GTK build after r93095.
1670
1671         Unreviewed build fix.
1672
1673         No new tests neede.
1674
1675         * GNUmakefile.list.am: Remove nonexistent sources.
1676
1677 2011-08-16  Andras Becsi  <abecsi@webkit.org>
1678
1679         Reviewed by Csaba Osztrogonác.
1680
1681         Need AtomicStrings for the various font family names
1682         https://bugs.webkit.org/show_bug.cgi?id=28024
1683
1684         Unify the usage of '-webkit' prefixed font family names by using
1685         global AtomicStrings.
1686         Use a .in file to generate the needed sources through make_names.pl.
1687
1688         No new tests needed.
1689
1690         * CMakeLists.txt:
1691         * CodeGenerators.pri:
1692         * DerivedSources.make:
1693         * GNUmakefile.am:
1694         * GNUmakefile.list.am:
1695         * WebCore.gyp/WebCore.gyp:
1696         * WebCore.gyp/scripts/action_makenames.py:
1697         * WebCore.gypi:
1698         * WebCore.vcproj/WebCore.vcproj:
1699         * WebCore.xcodeproj/project.pbxproj:
1700         * css/CSSComputedStyleDeclaration.cpp:
1701         (WebCore::identifierForFamily):
1702         * css/CSSFontSelector.cpp:
1703         (WebCore::CSSFontSelector::addFontFaceRule):
1704         (WebCore::fontDataForGenericFamily):
1705         * css/CSSStyleSelector.cpp:
1706         (WebCore::CSSStyleSelector::applyProperty):
1707         * css/WebKitFontFamilyNames.in: Added.
1708         * dom/make_names.pl:
1709         * page/Frame.cpp:
1710         (WebCore::Frame::Frame):
1711         * platform/graphics/FontCache.cpp:
1712         (WebCore::FontCache::getFontData):
1713         * platform/graphics/FontDescription.h:
1714         (WebCore::FontDescription::useFixedDefaultSize):
1715
1716 2011-08-16  Pavel Feldman  <pfeldman@google.com>
1717
1718         Web Inspector: nuke background events collection (dead feature)
1719         https://bugs.webkit.org/show_bug.cgi?id=66296
1720
1721         Reviewed by Yury Semikhatsky.
1722
1723         * CMakeLists.txt:
1724         * WebCore.gypi:
1725         * WebCore.pro:
1726         * WebCore.vcproj/WebCore.vcproj:
1727         * WebCore.xcodeproj/project.pbxproj:
1728         * inspector/EventsCollector.cpp: Removed.
1729         * inspector/EventsCollector.h: Removed.
1730         * inspector/Inspector.json:
1731         * inspector/InspectorFrontendProxy.cpp: Removed.
1732         * inspector/InspectorFrontendProxy.h: Removed.
1733         * inspector/InspectorResourceAgent.cpp:
1734         (WebCore::InspectorResourceAgent::setFrontend):
1735         (WebCore::InspectorResourceAgent::clearFrontend):
1736         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
1737         * inspector/InspectorResourceAgent.h:
1738         * inspector/front-end/NetworkPanel.js:
1739         (WebInspector.NetworkLogView):
1740
1741 2011-08-16  Lindsay Mathieson   <lindsay.mathieson@gmail.com>
1742
1743         [Qt] Missing spell check support
1744         https://bugs.webkit.org/show_bug.cgi?id=44114
1745
1746         Reviewed by Benjamin Poulain.
1747
1748         Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.
1749
1750         * platform/graphics/qt/GraphicsContextQt.cpp:
1751         (WebCore::drawErrorUnderline):
1752         (WebCore::GraphicsContext::drawLineForTextChecking):
1753
1754 2011-08-15  MORITA Hajime  <morrita@google.com>
1755
1756         REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating <textarea> value.
1757         https://bugs.webkit.org/show_bug.cgi?id=66216
1758
1759         Reviewed by Ryosuke Niwa.
1760
1761         Element::spellcheckAttributeState() uses Element::hasAttribute(),
1762         which calls updateStyleAttribute(), which potentially makes style
1763         dirty. But that is problematic since Editor calls spellcheckAttributeState()
1764         during the spell-checking phase and make the style dirty,
1765         which can trigger re-layout, which wipes the shadow tree of a textarea
1766         out by pre-committed "value" text.
1767
1768         This change removes the hasAttribute() call from
1769         spellcheckAttributeState().
1770
1771         Test: editing/input/style-change-during-input.html
1772
1773         * dom/Element.cpp:
1774         (WebCore::Element::spellcheckAttributeState):
1775
1776 2011-08-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1777
1778         [CMAKE] Wrap files of websocket and worker in each macro.
1779         https://bugs.webkit.org/show_bug.cgi?id=65012
1780
1781         Move files of web socket and workers into each macro block in CMakeList.txt.
1782         And, header files related to WORKER and SHARED_WORKER are wrapped by macro in cpp files.
1783
1784         Reviewed by Daniel Bates.
1785
1786         * CMakeLists.txt:
1787         * UseJSC.cmake:
1788         * bindings/js/JSDOMWindowCustom.cpp:
1789         * bindings/js/JSWorkerContextBase.cpp:
1790         * bindings/js/ScriptState.cpp:
1791         * bindings/js/WorkerScriptController.cpp:
1792
1793 2011-08-15  Jeffrey Pfau  <jpfau@apple.com>
1794
1795         New XML parser: add xml namespace to the default map of namespaces
1796         https://bugs.webkit.org/show_bug.cgi?id=66266
1797
1798         Reviewed by Adam Barth.
1799
1800         * xml/parser/XMLTreeBuilder.cpp:
1801         (WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):
1802
1803 2011-08-15  Hayato Ito  <hayato@chromium.org>
1804
1805         Fix crash when mouse moves from <summary> element to parent <details> element.
1806         https://bugs.webkit.org/show_bug.cgi?id=66210
1807
1808         Reviewed by Dimitri Glazkov.
1809
1810         This is a regression caused by r92922, which wrongly assumes that
1811         a shadow host always has a shadow root as an immediate child in
1812         ancestors chain. This assumption does not apply to <details>
1813         element. <details> element is implemented as a shadow host, but
1814         may have a <summary> element as an immediate child element in
1815         ancestors chain.
1816
1817         Test: fast/dom/shadow/details-summary-mouseover.html
1818
1819         * dom/EventDispatcher.cpp:
1820         (WebCore::EventDispatcher::adjustToShadowBoundaries):
1821
1822 2011-08-15  Jeffrey Pfau  <jpfau@apple.com>
1823
1824         New XML parser: Use xmlnsAtom instead of redundant xmlnsPrefix
1825         https://bugs.webkit.org/show_bug.cgi?id=66264
1826
1827         Reviewed by Adam Barth.
1828
1829         * xml/parser/XMLTreeBuilder.cpp:
1830         (WebCore::XMLTreeBuilder::processNamespaces):
1831         (WebCore::XMLTreeBuilder::processAttributes):
1832
1833 2011-08-15  Emil A Eklund  <eae@chromium.org>
1834
1835         Switch Element/Node to to new layout types
1836         https://bugs.webkit.org/show_bug.cgi?id=66260
1837
1838         Reviewed by Eric Seidel.
1839
1840         Convert Element, Node, ElementRareData and ContainerNode to new layout
1841         abstraction as a part of the ongoing conversion work.
1842
1843         No new tests, no new functionality.
1844
1845         * dom/ContainerNode.cpp:
1846         (WebCore::ContainerNode::getLowerRightCorner):
1847         (WebCore::ContainerNode::getRect):
1848         * dom/ContainerNode.h:
1849         * dom/Element.cpp:
1850         (WebCore::Element::scrollIntoView):
1851         (WebCore::Element::scrollIntoViewIfNeeded):
1852         (WebCore::adjustForLocalZoom):
1853         (WebCore::Element::boundsInWindowSpace):
1854         (WebCore::Element::getClientRects):
1855         (WebCore::Element::getBoundingClientRect):
1856         (WebCore::Element::screenRect):
1857         (WebCore::Element::minimumSizeForResizing):
1858         (WebCore::Element::setMinimumSizeForResizing):
1859         * dom/Element.h:
1860         * dom/ElementRareData.h:
1861         * dom/Node.cpp:
1862         (WebCore::Node::getRect):
1863         (WebCore::Node::renderRect):
1864         (WebCore::Node::hasNonEmptyBoundingBox):
1865         * dom/Node.h:
1866
1867 2011-08-15  Alexey Proskuryakov  <ap@apple.com>
1868
1869         Regional indicator symbols that are combined should behave as a single character when editing
1870         https://bugs.webkit.org/show_bug.cgi?id=65395
1871
1872         Reviewed by Dan Bernstein.
1873
1874         Part one: make backspace work.
1875
1876         Test: editing/deleting/regional-indicators.html
1877
1878         * rendering/RenderText.cpp:
1879         (WebCore::isRegionalIndicator):
1880         (WebCore::RenderText::previousOffsetForBackwardDeletion): Added a special case for regional
1881         indicator symbols.
1882
1883 2011-08-15  Jeffrey Pfau  <jpfau@apple.com>
1884
1885         New XML parser: Re-entering a character node should not clobber the buffered characters
1886         https://bugs.webkit.org/show_bug.cgi?id=66257
1887
1888         Reviewed by Adam Barth.
1889
1890         * xml/parser/XMLTreeBuilder.cpp:
1891         (WebCore::XMLTreeBuilder::enterText):
1892
1893 2011-08-15  Dmitry Titov  <dimich@chromium.org>
1894
1895         FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
1896         https://bugs.webkit.org/show_bug.cgi?id=66165
1897
1898         Reviewed by Darin Fisher.
1899
1900         No new tests since no change in behavior.
1901         The original issue is only reproducible on Chromium in multi-process mode
1902         and is tested there by a browsertest.
1903
1904         * loader/DocumentLoader.cpp:
1905         (WebCore::DocumentLoader::transferLoadingResourcesFromPage):
1906         Passing ResourceLoader* into the FrameLoaderClient notification.
1907         Also, fixed the bug where the same ResourceRequest was passed for all subresources.
1908         * loader/EmptyClients.h:
1909         (WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage):
1910         * loader/FrameLoader.cpp:
1911         (WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage):
1912         * loader/FrameLoader.h:
1913         * loader/FrameLoaderClient.h:
1914         * loader/ResourceLoadNotifier.cpp:
1915         (WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage):
1916         * loader/ResourceLoadNotifier.h:
1917         * loader/ResourceLoader.cpp:
1918         (WebCore::ResourceLoader::init):
1919         * loader/ResourceLoader.h:
1920         (WebCore::ResourceLoader::originalRequest): Added the originalRequest() accessor that
1921         returns the request as it existed before redirects (but after client's will SendRequest).
1922         This is to be able to pass the original request for loading subresources into
1923         FrameLoaderClient::transferLoadingResourceFromPage, since that one is used to invoke
1924         assignIdentifierToInitialRequest, which needs original request.
1925
1926 2011-08-15  Mark Hahnenberg  <mhahnenberg@apple.com>
1927
1928         Refactor JS objects to allocate in static create methods rather than constructors
1929         https://bugs.webkit.org/show_bug.cgi?id=65347
1930
1931         Reviewed by Geoffrey Garen.
1932
1933         No new tests.
1934
1935         Removed all calls to deprecatedGetDOMObject from initialization lists as part of a 
1936         larger refactoring to get rid of all allocation during initialization.
1937
1938         * bindings/js/JSDOMBinding.h:
1939         * bridge/c/CRuntimeObject.cpp:
1940         (JSC::Bindings::CRuntimeObject::CRuntimeObject):
1941         * bridge/c/CRuntimeObject.h:
1942         (JSC::Bindings::CRuntimeObject::create):
1943         * bridge/c/c_instance.cpp:
1944         (JSC::Bindings::CRuntimeMethod::create):
1945         (JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
1946         * bridge/jni/jsc/JavaInstanceJSC.cpp:
1947         (JavaRuntimeMethod::create):
1948         (JavaRuntimeMethod::JavaRuntimeMethod):
1949         * bridge/jni/jsc/JavaRuntimeObject.cpp:
1950         (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
1951         * bridge/jni/jsc/JavaRuntimeObject.h:
1952         (JSC::Bindings::JavaRuntimeObject::create):
1953         * bridge/objc/objc_runtime.h:
1954         (JSC::Bindings::ObjcFallbackObjectImp::create):
1955         * bridge/objc/objc_runtime.mm:
1956         (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
1957         * bridge/qt/qt_instance.cpp:
1958         (JSC::Bindings::QtRuntimeObject::create):
1959         (JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
1960         * bridge/qt/qt_pixmapruntime.cpp:
1961         (JSC::Bindings::QtPixmapRuntimeObject::create):
1962         (JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
1963         * bridge/qt/qt_runtime.cpp:
1964         (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
1965         (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
1966         (JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
1967         * bridge/qt/qt_runtime.h:
1968         (JSC::Bindings::QtRuntimeMetaMethod::create):
1969         (JSC::Bindings::QtRuntimeConnectionMethod::create):
1970         * bridge/runtime_array.cpp:
1971         (JSC::RuntimeArray::RuntimeArray):
1972         * bridge/runtime_array.h:
1973         (JSC::RuntimeArray::create):
1974         * bridge/runtime_object.cpp:
1975
1976 2011-08-15  Adam Roben  <aroben@apple.com>
1977
1978         Update pages' style and content scale when the window's backing scale factor changes
1979
1980         Unfortunately, I couldn't think of a way to test this in an automated fashion.
1981
1982         Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
1983         scale factor changes
1984
1985         Reviewed by Simon Fraser.
1986
1987         * WebCore.exp.in: Export Frame::deviceOrScaleFactorChanged.
1988
1989         * page/Frame.cpp:
1990         (WebCore::Frame::deviceScaleFactorChanged):
1991         * page/Frame.h:
1992         Added this new function. We recalc style so that, e.g., device-scale-factor-dependent media
1993         queries will be reevaluated, and we tell compositing layers about the new scale factor so
1994         they can rerender at the new resolution.
1995
1996 2011-08-15  Cary Clark  <caryclark@google.com>
1997
1998         Revise Skia on Chrome Mac to return fallback fonts.
1999         https://bugs.webkit.org/show_bug.cgi?id=62986
2000
2001         Reviewed by Darin Fisher.
2002
2003         Since Skia on Chrome Mac uses CoreText to determine
2004         text metrics, CG font architecture is used to return
2005         fallback fonts.
2006
2007         This improves many existing layout tests, including
2008         justify-ideograph-simple and t0905-c414-flt-04-c 
2009
2010         * platform/graphics/skia/FontSkia.cpp:
2011         (WebCore::Font::canReturnFallbackFontsForComplexText):
2012
2013 2011-08-15  Aaron Boodman  <aa@chromium.org>
2014
2015         Pass additional details to client in didCreateIsolatedContext
2016         https://bugs.webkit.org/show_bug.cgi?id=66037
2017
2018         Reviewed by Darin Fisher.
2019
2020         * bindings/v8/IsolatedWorld.cpp:
2021         (WebCore::IsolatedWorld::IsolatedWorld):
2022         * bindings/v8/IsolatedWorld.h:
2023         (WebCore::IsolatedWorld::create):
2024         (WebCore::IsolatedWorld::id):
2025         * bindings/v8/V8IsolatedContext.cpp:
2026         (WebCore::V8IsolatedContext::V8IsolatedContext):
2027         * bindings/v8/V8IsolatedContext.h:
2028         * bindings/v8/V8Proxy.cpp:
2029         (WebCore::V8Proxy::evaluateInIsolatedWorld):
2030         * loader/EmptyClients.h:
2031         (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
2032         * loader/FrameLoaderClient.h:
2033
2034 2011-08-15  Chris Rogers  <crogers@google.com>
2035
2036         Add shell implementation for Web Audio API's MediaElementAudioSourceNode
2037         https://bugs.webkit.org/show_bug.cgi?id=66175
2038
2039         Reviewed by Kenneth Russell.
2040
2041         Test: webaudio/mediaelementaudiosourcenode.html
2042
2043         * DerivedSources.make:
2044         * WebCore.gypi:
2045         * WebCore.xcodeproj/project.pbxproj:
2046         * html/HTMLMediaElement.idl:
2047         * webaudio/AudioContext.cpp:
2048         (WebCore::AudioContext::createMediaElementSource):
2049         * webaudio/AudioContext.h:
2050         * webaudio/AudioContext.idl:
2051         * webaudio/AudioNode.h:
2052         * webaudio/MediaElementAudioSourceNode.cpp: Added.
2053         (WebCore::MediaElementAudioSourceNode::create):
2054         (WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
2055         (WebCore::MediaElementAudioSourceNode::process):
2056         (WebCore::MediaElementAudioSourceNode::reset):
2057         * webaudio/MediaElementAudioSourceNode.h: Added.
2058         (WebCore::MediaElementAudioSourceNode::mediaElement):
2059         * webaudio/MediaElementAudioSourceNode.idl: Added.
2060
2061 2011-08-15  Emil A Eklund  <eae@chromium.org>
2062
2063         Switch mouse events to to new layout types
2064         https://bugs.webkit.org/show_bug.cgi?id=66179
2065
2066         Reviewed by Eric Seidel.
2067
2068         Convert mouse events to new layout abstraction as a part of the ongoing
2069         conversion work.
2070
2071         No new tests, no new functionality.
2072
2073         * dom/MouseRelatedEvent.cpp:
2074         (WebCore::contentsScrollOffset):
2075         (WebCore::MouseRelatedEvent::MouseRelatedEvent):
2076         (WebCore::MouseRelatedEvent::initCoordinates):
2077         (WebCore::MouseRelatedEvent::computePageLocation):
2078         (WebCore::MouseRelatedEvent::computeRelativePosition):
2079         (WebCore::MouseRelatedEvent::pageLocation):
2080         * dom/MouseRelatedEvent.h:
2081         (WebCore::MouseRelatedEvent::screenLocation):
2082         (WebCore::MouseRelatedEvent::clientLocation):
2083         (WebCore::MouseRelatedEvent::absoluteLocation):
2084         (WebCore::MouseRelatedEvent::setAbsoluteLocation):
2085         * page/EventHandler.cpp:
2086         (WebCore::EventHandler::clear):
2087         (WebCore::EventHandler::handleMousePressEventSingleClick):
2088         (WebCore::selectionExtentRespectingEditingBoundary):
2089         (WebCore::EventHandler::hitTestResultAtPoint):
2090         (WebCore::EventHandler::currentMousePosition):
2091         (WebCore::documentPointForWindowPoint):
2092         (WebCore::EventHandler::handleMousePressEvent):
2093         (WebCore::EventHandler::mouseMoved):
2094         (WebCore::EventHandler::handleWheelEvent):
2095         (WebCore::EventHandler::sendContextMenuEvent):
2096         (WebCore::EventHandler::sendContextMenuEventForKey):
2097         (WebCore::EventHandler::fakeMouseMoveEventTimerFired):
2098         (WebCore::EventHandler::dragHysteresisExceeded):
2099         (WebCore::EventHandler::handleDrag):
2100         (WebCore::EventHandler::handleTouchEvent):
2101         * page/EventHandler.h:
2102         * platform/PlatformMouseEvent.h:
2103         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2104         (WebCore::PlatformMouseEvent::pos):
2105         (WebCore::PlatformMouseEvent::x):
2106         (WebCore::PlatformMouseEvent::y):
2107         (WebCore::PlatformMouseEvent::globalX):
2108         (WebCore::PlatformMouseEvent::globalY):
2109         * platform/mac/PlatformMouseEventMac.mm:
2110         (WebCore::globalPoint):
2111         (WebCore::pointForEvent):
2112         (WebCore::globalPointForEvent):
2113
2114 2011-08-15  Ryosuke Niwa  <rniwa@webkit.org>
2115
2116         webkit-indent-blockquote is unnecessary
2117         https://bugs.webkit.org/show_bug.cgi?id=66195
2118
2119         Reviewed by Tony Chang.
2120
2121         Stop adding class="webkit-indent-blockquote" on blockquotes created by execCommand('Indent') and
2122         execCommand('Outdent'). Also removed the code to add the class attribute in ApplyBlockElementCommand
2123         since no other class inherited from ApplyBlockElementCommand uses this feature.
2124
2125         * editing/ApplyBlockElementCommand.cpp:
2126         (WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand):
2127         (WebCore::ApplyBlockElementCommand::createBlockElement):
2128         * editing/ApplyBlockElementCommand.h:
2129         * editing/IndentOutdentCommand.cpp:
2130         (WebCore::IndentOutdentCommand::IndentOutdentCommand):
2131
2132 2011-08-15  Levi Weintraub  <leviw@chromium.org>
2133
2134         Switch remaining SVG Rendering methods to LayoutUnits
2135         https://bugs.webkit.org/show_bug.cgi?id=66169
2136
2137         Reviewed by Eric Seidel.
2138
2139         Changing remaining integer SVG methods to use the LayoutUnits abstraction.
2140
2141         No tests as no change in functionality.
2142
2143         * rendering/svg/RenderSVGBlock.cpp:
2144         (WebCore::RenderSVGBlock::visualOverflowRect):
2145         * rendering/svg/RenderSVGBlock.h:
2146         * rendering/svg/RenderSVGContainer.cpp:
2147         (WebCore::RenderSVGContainer::paint):
2148         * rendering/svg/RenderSVGForeignObject.cpp:
2149         (WebCore::RenderSVGForeignObject::paint):
2150         (WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
2151         (WebCore::RenderSVGForeignObject::computeRectForRepaint):
2152         * rendering/svg/RenderSVGHiddenContainer.cpp:
2153         (WebCore::RenderSVGHiddenContainer::paint):
2154         * rendering/svg/RenderSVGImage.cpp:
2155         (WebCore::RenderSVGImage::paint):
2156         * rendering/svg/RenderSVGInlineText.cpp:
2157         (WebCore::RenderSVGInlineText::linesBoundingBox):
2158         * rendering/svg/RenderSVGInlineText.h:
2159         * rendering/svg/RenderSVGModelObject.cpp:
2160         (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
2161         * rendering/svg/RenderSVGPath.cpp:
2162         (WebCore::RenderSVGPath::paint):
2163         * rendering/svg/RenderSVGRoot.cpp:
2164         (WebCore::RenderSVGRoot::localToBorderBoxTransform):
2165         (WebCore::RenderSVGRoot::parentOriginToBorderBox):
2166         (WebCore::RenderSVGRoot::borderOriginToContentBox):
2167         (WebCore::RenderSVGRoot::localToRepaintContainerTransform):
2168         (WebCore::RenderSVGRoot::localToParentTransform):
2169         (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
2170         (WebCore::RenderSVGRoot::computeRectForRepaint):
2171         * rendering/svg/RenderSVGRoot.h:
2172         * rendering/svg/RenderSVGText.cpp:
2173         (WebCore::RenderSVGText::paint):
2174         * rendering/svg/SVGInlineFlowBox.cpp:
2175         (WebCore::SVGInlineFlowBox::paint):
2176         * rendering/svg/SVGInlineTextBox.cpp:
2177         (WebCore::SVGInlineTextBox::paint):
2178         * rendering/svg/SVGRenderSupport.cpp:
2179         (WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
2180         (WebCore::SVGRenderSupport::computeRectForRepaint):
2181         * rendering/svg/SVGRenderSupport.h:
2182         * rendering/svg/SVGRootInlineBox.cpp:
2183         (WebCore::SVGRootInlineBox::paint):
2184         (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
2185         (WebCore::SVGRootInlineBox::layoutChildBoxes):
2186         (WebCore::SVGRootInlineBox::layoutRootBox):
2187         (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
2188         * rendering/svg/SVGRootInlineBox.h:
2189
2190 2011-08-12  Jeff Miller  <jeffm@apple.com>
2191
2192         MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
2193         https://bugs.webkit.org/show_bug.cgi?id=66171
2194         
2195         MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
2196         to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC.  I also added better logging to notificationCallback().
2197
2198         Reviewed by Jon Honeycutt.
2199
2200         No new tests, uses existing media tests.
2201
2202         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
2203         (WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
2204         (WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.
2205
2206 2011-08-15  Adam Roben  <aroben@apple.com>
2207
2208         Rename an instance of pageScaleFactorChanged I missed in r93040
2209
2210         I tried to make a test for this but failed. It would probably have been easier if we dumped
2211         layers' content scales in layerTreeAsText output.
2212
2213         Followup to <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to
2214         the device scale factor
2215
2216         * platform/graphics/ca/GraphicsLayerCA.cpp:
2217         (WebCore::GraphicsLayerCA::deviceOrPageScaleFactorChanged):
2218         * platform/graphics/ca/GraphicsLayerCA.h:
2219         Renamed from pageScaleFactorChanged to match the base class.
2220
2221 2011-08-15  Pavel Feldman  <pfeldman@google.com>
2222
2223         Web Inspector: [V8] crash upon stepIn while not on pause.
2224         https://bugs.webkit.org/show_bug.cgi?id=66221
2225
2226         Reviewed by Yury Semikhatsky.
2227
2228         * inspector/InspectorDebuggerAgent.cpp:
2229         (WebCore::InspectorDebuggerAgent::resume):
2230         (WebCore::InspectorDebuggerAgent::stepOver):
2231         (WebCore::InspectorDebuggerAgent::stepInto):
2232         (WebCore::InspectorDebuggerAgent::stepOut):
2233         (WebCore::InspectorDebuggerAgent::assertPaused):
2234         * inspector/InspectorDebuggerAgent.h:
2235         * inspector/front-end/ScriptsPanel.js:
2236         (WebInspector.ScriptsPanel.prototype._stepOverClicked):
2237         (WebInspector.ScriptsPanel.prototype._stepIntoClicked):
2238         (WebInspector.ScriptsPanel.prototype._stepOutClicked):
2239
2240 2011-08-15  Vsevolod Vlasov  <vsevik@chromium.org>
2241
2242         Web Inspector: Network panel: display the current search match index in the toolbar.
2243         https://bugs.webkit.org/show_bug.cgi?id=66051
2244
2245         Reviewed by Pavel Feldman.
2246
2247         * inspector/front-end/NetworkPanel.js:
2248         (WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):
2249         (WebInspector.NetworkLogView.prototype.performSearch):
2250         (WebInspector.NetworkPanel):
2251         (WebInspector.NetworkPanel.prototype._onSearchCountUpdated):
2252         (WebInspector.NetworkPanel.prototype._onSearchIndexUpdated):
2253
2254 2011-08-10  Adam Roben  <aroben@apple.com>
2255
2256         Clear up scale factor terminology
2257
2258         WebKit by and large deals with two scale factors: one intrinsic to the device on which the
2259         software is running, and one that is per-Page and can be controlled via API calls. This
2260         patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
2261         code use those names. It should introduce no behavior changes.
2262
2263         Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
2264         device scale factor
2265
2266         Reviewed by Simon Fraser.
2267
2268         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2269         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2270         Removed an unused member. This is unrelated to this patch.
2271
2272         * css/MediaQueryEvaluator.cpp:
2273         * html/HTMLCanvasElement.cpp:
2274         * html/HTMLCanvasElement.h:
2275         * loader/EmptyClients.h:
2276         * page/Chrome.cpp:
2277         * page/Chrome.h:
2278         * page/ChromeClient.h:
2279         * page/DOMWindow.cpp:
2280         * page/Frame.cpp:
2281         * page/Frame.h:
2282         * platform/graphics/GraphicsLayer.cpp:
2283         * platform/graphics/GraphicsLayer.h:
2284         * platform/graphics/GraphicsLayerClient.h:
2285         * platform/graphics/ca/GraphicsLayerCA.cpp:
2286         * rendering/RenderInline.cpp:
2287         * rendering/RenderLayerBacking.cpp:
2288         * rendering/RenderLayerBacking.h:
2289         * rendering/RenderLayerCompositor.cpp:
2290         * rendering/RenderLayerCompositor.h:
2291         * rendering/RenderObject.cpp:
2292
2293 2011-08-15  Oliver Varga  <Varga.Oliver@stud.u-szeged.hu>
2294
2295         Reviewed by Nikolas Zimmermann.
2296
2297         Speed up SVGSMILElement::findInstanceTime.
2298         https://bugs.webkit.org/show_bug.cgi?id=61025
2299
2300         Replace the linear search to binary search on ordered list because
2301         the previous searches from the beginning was not efficient.
2302         Out of index error fixed by Renata Hodovan.
2303
2304         No new tests this is only a performance tweak.
2305
2306         * svg/animation/SVGSMILElement.cpp:
2307         (WebCore::extractTimeFromVector):
2308         (WebCore::SVGSMILElement::findInstanceTime):
2309
2310 2011-08-15  Hayato Ito  <hayato@chromium.org>
2311
2312         Implement proper handling of focusin/focusout events in regard to shadow DOM boundaries.
2313         https://bugs.webkit.org/show_bug.cgi?id=64249
2314
2315         Reviewed by Dimitri Glazkov.
2316
2317         Introduces FocusInEventDispatchMediator/FocusOutEventDispatchMediator so
2318         that we can shrink ancestors of event target node considering shadow
2319         DOM boundaries before dispatching focusin/focusout events.
2320
2321         Test: fast/dom/shadow/shadow-boundary-events.html
2322
2323         * dom/Document.cpp:
2324         (WebCore::Document::setFocusedNode):
2325         * dom/Node.cpp:
2326         (WebCore::Node::dispatchFocusInEvent):
2327         (WebCore::Node::dispatchFocusOutEvent):
2328         (WebCore::Node::dispatchDOMActivateEvent):
2329         (WebCore::Node::defaultEventHandler):
2330         * dom/Node.h:
2331         * dom/UIEvent.cpp:
2332         (WebCore::FocusInEventDispatchMediator::create):
2333         (WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
2334         (WebCore::FocusInEventDispatchMediator::dispatchEvent):
2335         (WebCore::FocusOutEventDispatchMediator::create):
2336         (WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
2337         (WebCore::FocusOutEventDispatchMediator::dispatchEvent):
2338         * dom/UIEvent.h:
2339
2340 2011-08-15  Pavel Feldman  <pfeldman@google.com>
2341
2342         Web Inspector: not all of the properties have valid descriptors on all platforms.
2343         Includes PropertyDescriptor protocol documentation fixes.
2344         https://bugs.webkit.org/show_bug.cgi?id=66215
2345
2346         Activations, LocalStorage and some other properties potentially don't have
2347         valid property descriptors. InjectedScript should use conservative getter in order to
2348         mitigate this.
2349
2350         Reviewed by Yury Semikhatsky.
2351
2352         * inspector/InjectedScriptSource.js:
2353         * inspector/Inspector.json:
2354
2355 2011-08-15  Pavel Feldman  <pfeldman@google.com>
2356
2357         Web Inspector: context menu on the link in the console does not have standard link options.
2358         https://bugs.webkit.org/show_bug.cgi?id=66214
2359
2360         Reviewed by Yury Semikhatsky.
2361
2362         * English.lproj/localizedStrings.js:
2363         * inspector/front-end/ConsoleView.js:
2364         * inspector/front-end/ElementsPanel.js:
2365         * inspector/front-end/ElementsTreeOutline.js:
2366         (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
2367         * inspector/front-end/NetworkPanel.js:
2368         (WebInspector.NetworkLogView.prototype._contextMenu):
2369         * inspector/front-end/StylesSidebarPane.js:
2370         (WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
2371         * inspector/front-end/inspector.js:
2372         (WebInspector.openLinkExternallyLabel):
2373         (WebInspector.copyLinkAddressLabel):
2374         (WebInspector.populateHrefContextMenu):
2375
2376 2011-08-14  Pavel Feldman  <pfeldman@chromium.org>
2377
2378         Web Inspector: showContextMenu missing in Remote DevTools
2379         https://bugs.webkit.org/show_bug.cgi?id=63725
2380
2381         Reviewed by Yury Semikhatsky.
2382
2383         * WebCore.gypi:
2384         * WebCore.vcproj/WebCore.vcproj:
2385         * inspector/front-end/ConsoleView.js:
2386         * inspector/front-end/SoftContextMenu.js: Added.
2387         (.WebInspector.SoftContextMenu):
2388         (.WebInspector.SoftContextMenu.prototype.show):
2389         (.WebInspector.SoftContextMenu.prototype._createMenuItem):
2390         (.WebInspector.SoftContextMenu.prototype._createSeparator):
2391         (.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
2392         (.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
2393         (.WebInspector.SoftContextMenu.prototype._triggerAction):
2394         (.WebInspector.SoftContextMenu.prototype._menuItemMouseOver):
2395         (.WebInspector.SoftContextMenu.prototype._menuItemMouseOut):
2396         (.WebInspector.SoftContextMenu.prototype._highlightMenuItem):
2397         (.WebInspector.SoftContextMenu.prototype._highlightPrevious):
2398         (.WebInspector.SoftContextMenu.prototype._highlightNext):
2399         (.WebInspector.SoftContextMenu.prototype._menuKeyDown):
2400         (.WebInspector.SoftContextMenu.prototype._glassPaneMouseUp):
2401         (.WebInspector.SoftContextMenu.prototype._discardMenu):
2402         (.InspectorFrontendHost.showContextMenu):
2403         * inspector/front-end/WebKit.qrc:
2404         * inspector/front-end/inspector.css:
2405         (.soft-context-menu-glass-pane):
2406         (.soft-context-menu):
2407         (.soft-context-menu-item):
2408         (.soft-context-menu-separator):
2409         (.soft-context-menu-item-mouse-over):
2410         * inspector/front-end/inspector.html:
2411
2412 2011-08-13  Abhishek Arya  <inferno@chromium.org>
2413
2414         Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
2415         https://bugs.webkit.org/show_bug.cgi?id=66187
2416
2417         Reviewed by Adam Barth.
2418
2419         RefPtr a few ContainerNodes to prevent premature deletion.
2420
2421         Test: fast/html/process-end-tag-for-inbody-crash.html
2422
2423         * html/parser/HTMLTreeBuilder.cpp:
2424         (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
2425         (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
2426         (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2427
2428 2011-08-14  Kalev Lember  <kalevlember@gmail.com>
2429
2430         Fix GTK Windows build after r92308.
2431         https://bugs.webkit.org/show_bug.cgi?id=66140
2432
2433         Reviewed by Xan Lopez.
2434
2435         * config.h: Don't try to include WebCoreHeaderDetection.h for GTK.
2436
2437 2011-08-13  Sam Weinig  <sam@webkit.org>
2438
2439         Remove forward declaration of -[WebUndefined dealloc] to appease the bot gods.
2440
2441         * bindings/objc/WebScriptObject.mm:
2442
2443 2011-08-13  Sam Weinig  <sam@webkit.org>
2444
2445         Remove assertion from -[WebUndefined dealloc] to try to mollify the bots.
2446
2447         * bindings/objc/WebScriptObject.mm:
2448         (-[WebUndefined dealloc]):
2449
2450 2011-08-13  Sam Weinig  <sam@webkit.org>
2451
2452         Remove unused variables from WebVideoFullscreenController.h
2453         https://bugs.webkit.org/show_bug.cgi?id=66192
2454
2455         Reviewed by Dan Bernstein.
2456
2457         * platform/mac/WebVideoFullscreenController.h:
2458         Remove _isWindowLoaded, _savedUIMode and _savedUIOptions which were not used.
2459
2460 2011-08-13  Sam Weinig  <sam@webkit.org>
2461
2462         Fix incorrect objective-c initialize in WebCore
2463         https://bugs.webkit.org/show_bug.cgi?id=66191
2464
2465         Reviewed by David Kilzer.
2466
2467         * accessibility/mac/AccessibilityObjectWrapper.mm:
2468         (-[AccessibilityObjectWrapper initWithAccessibilityObject:]):
2469         * rendering/RenderThemeMac.mm:
2470         (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
2471         Correctly initialize by assigning to self and nil checking the result.
2472
2473 2011-08-13  Adam Barth  <abarth@webkit.org>
2474
2475         Fix clang build.
2476
2477         * platform/chromium/PopupMenuChromium.h:
2478
2479 2011-08-13  David Kilzer  <ddkilzer@apple.com>
2480
2481         <http://webkit.org/b/66188> WebCore.xcodeproj has duplicate entries again
2482
2483         Reviewed by Dan Bernstein.
2484
2485         * WebCore.xcodeproj/project.pbxproj: Remove duplicate entries
2486         by using uniq.  Originally noticed by Xcode 4.
2487
2488 2011-08-12  Dan Bernstein  <mitz@apple.com>
2489
2490         <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text
2491         https://bugs.webkit.org/show_bug.cgi?id=66178
2492
2493         Reviewed by Simon Fraser.
2494
2495         * WebCore.exp.in: Export setShowsToolTipOverTruncatedText().
2496         * page/Chrome.cpp:
2497         (WebCore::Chrome::setToolTip): If no title is found, and the page is set to show tooltips over
2498         truncated text, try to set the tooltip to the full text of the truncated text, if any.
2499         * page/Settings.cpp:
2500         (WebCore::Settings::Settings): Initialize new member variable.
2501         (WebCore::Settings::setShowsToolTipOverTruncatedText): Added this setter.
2502         * page/Settings.h:
2503         (WebCore::Settings::showsToolTipOverTruncatedText): Added this getter.
2504         * rendering/HitTestResult.cpp:
2505         (WebCore::HitTestResult::innerTextIfTruncated): Added. If the inner node or its nearest enclosing
2506         block has text-overflow: ellipsis and has truncated lines, return the node’s (full) inner text.
2507         * rendering/HitTestResult.h:
2508         * rendering/RootInlineBox.h:
2509         (WebCore::RootInlineBox::hasEllipsisBox): Made this public.
2510
2511 2011-08-12  Stephen White  <senorblanco@chromium.org>
2512
2513         Ownership of canvas's GraphicsContext3D should be moved to PlatformContextSkia
2514         https://bugs.webkit.org/show_bug.cgi?id=66154
2515
2516         Reviewed by Kenneth Russell.
2517
2518         Covered by existing tests in fast/canvas and canvas/philip.
2519
2520         * html/canvas/CanvasRenderingContext2D.cpp:
2521         (WebCore::CanvasRenderingContext2D::isAccelerated):
2522         Plumb this call through GraphicsContext::isAcceleratedContext().
2523         (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
2524         For the ACCELERATED_2D_CANVAS path, plumb this call through
2525         (the new) GraphicsContext::paintsIntoCanvasBuffer().
2526         (WebCore::CanvasRenderingContext2D::clearAcceleration):
2527         (WebCore::CanvasRenderingContext2D::resetAcceleration):
2528         Remove the use of the m_context3D member; use a temporary instead.
2529         * html/canvas/CanvasRenderingContext2D.h:
2530         Remove the m_context3D member.
2531         * platform/graphics/GraphicsContext.cpp:
2532         (WebCore::GraphicsContext::isAcceleratedContext):
2533         (WebCore::GraphicsContext::paintsIntoImageBuffer):
2534         Implement stub versions of these functions for other platforms.
2535         * platform/graphics/GraphicsContext.h:
2536         Expose isAcceleratedContext() to all platforms.  Add
2537         paintsIntoImageBuffer() member function.
2538         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2539         (WebCore::SharedGraphicsContext3D::create):
2540         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2541         * platform/graphics/skia/GraphicsContextSkia.cpp:
2542         (WebCore::GraphicsContext::setGraphicsContext3D):
2543         (WebCore::GraphicsContext::isAcceleratedContext):
2544         (WebCore::GraphicsContext::paintsIntoImageBuffer):
2545         Basically gut this class leaving only a static creation function.
2546         * platform/graphics/skia/ImageSkia.cpp:
2547         (WebCore::paintSkBitmap):
2548         (WebCore::Image::drawPattern):
2549         Use isAccelerated() in place of useSkiaGpu().
2550         * platform/graphics/skia/PlatformContextSkia.cpp:
2551         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2552         (WebCore::PlatformContextSkia::paintsIntoImageBuffer):
2553         * platform/graphics/skia/PlatformContextSkia.h:
2554         (WebCore::PlatformContextSkia::isAccelerated):
2555         Rename useSkiaGpu() to isAccelerated().  Plumb through 
2556         paintsIntoImageBuffer() to GraphicsContext3D.
2557
2558 2011-08-12  Sam Weinig  <sam@webkit.org>
2559
2560         Use __builtin_trap() for CRASH when building with clang
2561         https://bugs.webkit.org/show_bug.cgi?id=66152
2562
2563         Reviewed by Anders Carlsson.
2564
2565         * bindings/js/SerializedScriptValue.cpp:
2566         (WebCore::CloneBase::fail):
2567         * bindings/objc/WebScriptObject.mm:
2568         * platform/mac/BlockExceptions.h:
2569         * platform/text/cf/StringImplCF.cpp:
2570         Add NO_RETURN_DUE_TO_ASSERT.
2571
2572         * bridge/IdentifierRep.h:
2573         Don't define the destructor since it is never called,
2574
2575 2011-08-12  Joseph Pecoraro  <joepeck@webkit.org>
2576
2577         Abandoned Memory: Temporary CSS Fonts May Never Be Purged
2578         https://bugs.webkit.org/show_bug.cgi?id=66153
2579
2580         Reviewed by Dan Bernstein.
2581
2582         No new tests, this is not a functional change.
2583
2584         * css/CSSFontFaceSource.cpp:
2585         (WebCore::CSSFontFaceSource::getFontData):
2586         If the CSS font-face is loading from a URL then immediately
2587         fallback to a system font matching the description, since we
2588         cannot determine a reasonable family name from the m_string
2589         URL. The URL could be a dataURI.
2590
2591 2011-08-12  Fady Samuel  <fsamuel@chromium.org>
2592
2593         Refactoring of PopupMenuChromium For Readability and Maintainability
2594         https://bugs.webkit.org/show_bug.cgi?id=66009
2595
2596         Reviewed by Darin Fisher.
2597
2598         Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp},
2599         and PopupLisBox.{h|cpp}  for readability and maintainability.
2600
2601         No new tests as there's no change in functionality.
2602
2603         * WebCore.gypi:
2604         * platform/chromium/PopupContainer.cpp: Added.
2605         (WebCore::constructRelativeMouseEvent):
2606         (WebCore::constructRelativeWheelEvent):
2607         (WebCore::PopupContainer::create):
2608         (WebCore::PopupContainer::PopupContainer):
2609         (WebCore::PopupContainer::~PopupContainer):
2610         (WebCore::PopupContainer::layoutAndCalculateWidgetRect):
2611         (WebCore::PopupContainer::showPopup):
2612         (WebCore::PopupContainer::hidePopup):
2613         (WebCore::PopupContainer::notifyPopupHidden):
2614         (WebCore::PopupContainer::layoutAndGetRTLOffset):
2615         (WebCore::PopupContainer::handleMouseDownEvent):
2616         (WebCore::PopupContainer::handleMouseMoveEvent):
2617         (WebCore::PopupContainer::handleMouseReleaseEvent):
2618         (WebCore::PopupContainer::handleWheelEvent):
2619         (WebCore::PopupContainer::handleTouchEvent):
2620         (WebCore::PopupContainer::handleGestureEvent):
2621         (WebCore::PopupContainer::handleKeyEvent):
2622         (WebCore::PopupContainer::hide):
2623         (WebCore::PopupContainer::paint):
2624         (WebCore::PopupContainer::paintBorder):
2625         (WebCore::PopupContainer::isInterestedInEventForKey):
2626         (WebCore::PopupContainer::chromeClientChromium):
2627         (WebCore::PopupContainer::showInRect):
2628         (WebCore::PopupContainer::refresh):
2629         (WebCore::PopupContainer::isRTL):
2630         (WebCore::PopupContainer::selectedIndex):
2631         (WebCore::PopupContainer::menuItemHeight):
2632         (WebCore::PopupContainer::menuItemFontSize):
2633         (WebCore::PopupContainer::menuStyle):
2634         (WebCore::popupData):
2635         (WebCore::PopupContainer::getSelectedItemToolTip):
2636         * platform/chromium/PopupContainer.h: Added.
2637         (WebCore::PopupContainer::listBox):
2638         (WebCore::PopupContainer::popupType):
2639         * platform/chromium/PopupListBox.cpp: Added.
2640         (WebCore::PopupListBox::PopupListBox):
2641         (WebCore::PopupListBox::handleMouseDownEvent):
2642         (WebCore::PopupListBox::handleMouseMoveEvent):
2643         (WebCore::PopupListBox::handleMouseReleaseEvent):
2644         (WebCore::PopupListBox::handleWheelEvent):
2645         (WebCore::PopupListBox::isInterestedInEventForKey):
2646         (WebCore::PopupListBox::handleTouchEvent):
2647         (WebCore::PopupListBox::handleGestureEvent):
2648         (WebCore::isCharacterTypeEvent):
2649         (WebCore::PopupListBox::handleKeyEvent):
2650         (WebCore::PopupListBox::hostWindow):
2651         (WebCore::stripLeadingWhiteSpace):
2652         (WebCore::PopupListBox::typeAheadFind):
2653         (WebCore::PopupListBox::paint):
2654         (WebCore::PopupListBox::paintRow):
2655         (WebCore::PopupListBox::getRowFont):
2656         (WebCore::PopupListBox::abandon):
2657         (WebCore::PopupListBox::pointToRowIndex):
2658         (WebCore::PopupListBox::acceptIndex):
2659         (WebCore::PopupListBox::selectIndex):
2660         (WebCore::PopupListBox::setOriginalIndex):
2661         (WebCore::PopupListBox::getRowHeight):
2662         (WebCore::PopupListBox::getRowBounds):
2663         (WebCore::PopupListBox::invalidateRow):
2664         (WebCore::PopupListBox::scrollToRevealRow):
2665         (WebCore::PopupListBox::isSelectableItem):
2666         (WebCore::PopupListBox::clearSelection):
2667         (WebCore::PopupListBox::selectNextRow):
2668         (WebCore::PopupListBox::selectPreviousRow):
2669         (WebCore::PopupListBox::adjustSelectedIndex):
2670         (WebCore::PopupListBox::hidePopup):
2671         (WebCore::PopupListBox::updateFromElement):
2672         (WebCore::PopupListBox::setMaxWidthAndLayout):
2673         (WebCore::PopupListBox::layout):
2674         (WebCore::PopupListBox::clear):
2675         (WebCore::PopupListBox::isPointInBounds):
2676         * platform/chromium/PopupListBox.h: Added.
2677         (WebCore::PopupItem::PopupItem):
2678         (WebCore::PopupListBox::create):
2679         (WebCore::PopupListBox::selectedIndex):
2680         (WebCore::PopupListBox::numItems):
2681         (WebCore::PopupListBox::setBaseWidth):
2682         (WebCore::PopupListBox::setMaxHeight):
2683         (WebCore::PopupListBox::setMaxWidth):
2684         (WebCore::PopupListBox::disconnectClient):
2685         (WebCore::PopupListBox::items):
2686         (WebCore::PopupListBox::~PopupListBox):
2687         (WebCore::PopupListBox::scrollToRevealSelection):
2688         * platform/chromium/PopupMenuChromium.cpp:
2689         * platform/chromium/PopupMenuChromium.h:
2690
2691 2011-08-12  Mark Rowe  <mrowe@apple.com>
2692
2693         Be more forward-looking in the choice of compiler.
2694
2695         Rubber-stamped by Jon Honeycutt.
2696
2697         * Configurations/CompilerVersion.xcconfig:
2698
2699 2011-08-12  Nat Duca  <nduca@chromium.org>
2700
2701         [chromium] Fix comile warning on CCLayerTreeHost
2702
2703         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
2704         (WebCore::CCLayerTreeHost::CCLayerTreeHost):
2705
2706 2011-08-12  Ryosuke Niwa  <rniwa@webkit.org>
2707
2708         Apple-style-span class seems unnecessary
2709         https://bugs.webkit.org/show_bug.cgi?id=12248
2710
2711         Reviewed by Justin Garcia.
2712
2713         Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
2714         no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
2715         style spans. WebKit continues to recognize Apple style spans to remove them.
2716
2717         Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.
2718
2719         * editing/ApplyStyleCommand.cpp:
2720         (WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
2721         (WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
2722         (WebCore::createFontElement): No longer adds class="Apple-style-span".
2723         (WebCore::createStyleSpanElement): Ditto.
2724         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
2725         instead of isUnstyledStyleSpan since there won't be any Apple style spans.
2726         (WebCore::dummySpanAncestorForNode):
2727         (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
2728         (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
2729         (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
2730         (WebCore::ApplyStyleCommand::removeCSSStyle):
2731         * editing/ApplyStyleCommand.h:
2732         * editing/EditingStyle.cpp:
2733         (WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.
2734         * editing/ReplaceSelectionCommand.cpp:
2735         (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
2736         of isStyleSpan.
2737         (WebCore::handleStyleSpansBeforeInsertion): Ditto.
2738         (WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
2739         (WebCore::ReplaceSelectionCommand::doApply): Ditto.
2740         * editing/markup.cpp:
2741         (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".
2742
2743 2011-08-12  Nat Duca  <nduca@chromium.org>
2744
2745         [chromium] Fix compositor breakage due to duplicate context creation AND by context-lost
2746         https://bugs.webkit.org/show_bug.cgi?id=66168
2747
2748         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
2749         (WebCore::CCLayerTreeHost::CCLayerTreeHost):
2750         (WebCore::CCLayerTreeHost::initialize):
2751
2752 2011-08-12  Levi Weintraub  <leviw@chromium.org>
2753
2754         Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units
2755         https://bugs.webkit.org/show_bug.cgi?id=66149
2756
2757         Reviewed by Eric Seidel.
2758
2759         Changing RenderMenuList, RenderListBox, and RenderFieldSet to the LayoutUnit
2760         abstraction from ints.
2761
2762         No tests as no change in functionality.
2763
2764         * rendering/RenderFieldset.cpp:
2765         (WebCore::RenderFieldset::layoutSpecialExcludedChild):
2766         * rendering/RenderListBox.cpp:
2767         (WebCore::RenderListBox::numVisibleItems):
2768         (WebCore::RenderListBox::listHeight):
2769         (WebCore::RenderListBox::baselinePosition):
2770         (WebCore::RenderListBox::itemBoundingBoxRect):
2771         (WebCore::itemOffsetForAlignment):
2772         (WebCore::RenderListBox::panScroll):
2773         (WebCore::RenderListBox::scrollToward):
2774         (WebCore::RenderListBox::autoscroll):
2775         (WebCore::RenderListBox::scrollSize):
2776         (WebCore::RenderListBox::scrollPosition):
2777         (WebCore::RenderListBox::setScrollOffset):
2778         (WebCore::RenderListBox::itemHeight):
2779         (WebCore::RenderListBox::verticalScrollbarWidth):
2780         (WebCore::RenderListBox::scrollWidth):
2781         (WebCore::RenderListBox::scrollHeight):
2782         (WebCore::RenderListBox::scrollLeft):
2783         (WebCore::RenderListBox::setScrollLeft):
2784         (WebCore::RenderListBox::scrollTop):
2785         (WebCore::RenderListBox::setScrollTop):
2786         (WebCore::RenderListBox::controlClipRect):
2787         (WebCore::RenderListBox::invalidateScrollbarRect):
2788         (WebCore::RenderListBox::convertFromScrollbarToContainingView):
2789         (WebCore::RenderListBox::convertFromContainingViewToScrollbar):
2790         (WebCore::RenderListBox::contentsSize):
2791         (WebCore::RenderListBox::currentMousePosition):
2792         * rendering/RenderListBox.h:
2793         (WebCore::RenderListBox::scrollCornerRect):
2794         (WebCore::RenderListBox::invalidateScrollCornerRect):
2795         * rendering/RenderMenuList.cpp:
2796         (WebCore::RenderMenuList::controlClipRect):
2797         (WebCore::RenderMenuList::showPopup):
2798         * rendering/RenderMenuList.h:
2799
2800 2011-08-12  David Hyatt  <hyatt@apple.com>
2801
2802         https://bugs.webkit.org/show_bug.cgi?id=66133
2803         
2804         Make hit testing work on RenderRegions. Pass off the hit testing to the RenderFlowThread
2805         layer tree (just as we did with painting).
2806
2807         Reviewed by Sam Weinig.
2808
2809         Added hit-test-float.html to demonstrate basic hit testing of content flowed into regions.
2810
2811         * rendering/HitTestRequest.h:
2812         (WebCore::HitTestRequest::type):
2813         * rendering/RenderFlowThread.cpp:
2814         (WebCore::RenderFlowThread::hitTestRegion):
2815         * rendering/RenderFlowThread.h:
2816         * rendering/RenderRegion.cpp:
2817         (WebCore::RenderRegion::paintReplaced):
2818         (WebCore::RenderRegion::nodeAtPoint):
2819         * rendering/RenderRegion.h:
2820
2821 2011-08-12  Levi Weintraub  <leviw@chromium.org>
2822
2823         Switch RenderTable* to new layout types
2824         https://bugs.webkit.org/show_bug.cgi?id=66146
2825
2826         Reviewed by Eric Seidel.
2827
2828         Converting RenderTable* classes to new LayoutUnits from ints.
2829
2830         No new tests as no new functionality.
2831
2832         * rendering/RenderTable.cpp:
2833         (WebCore::RenderTable::firstLineBoxBaseline):
2834         (WebCore::RenderTable::overflowClipRect):
2835         * rendering/RenderTable.h:
2836         (WebCore::RenderTable::columnPositions):
2837         * rendering/RenderTableCol.cpp:
2838         (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
2839         * rendering/RenderTableRow.cpp:
2840         (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
2841         * rendering/RenderTableSection.cpp:
2842         (WebCore::RenderTableSection::setCellLogicalWidths):
2843         (WebCore::RenderTableSection::calcRowLogicalHeight):
2844         (WebCore::RenderTableSection::layoutRows):
2845         (WebCore::RenderTableSection::calcOuterBorderBefore):
2846         (WebCore::RenderTableSection::calcOuterBorderAfter):
2847         (WebCore::RenderTableSection::calcOuterBorderStart):
2848         (WebCore::RenderTableSection::calcOuterBorderEnd):
2849         (WebCore::RenderTableSection::firstLineBoxBaseline):
2850         (WebCore::RenderTableSection::paintObject):
2851         (WebCore::RenderTableSection::nodeAtPoint):
2852         * rendering/RenderTableSection.h:
2853         (WebCore::RenderTableSection::outerBorderBefore):
2854         (WebCore::RenderTableSection::outerBorderAfter):
2855         (WebCore::RenderTableSection::outerBorderStart):
2856         (WebCore::RenderTableSection::outerBorderEnd):
2857         (WebCore::RenderTableSection::getBaseline):
2858
2859 2011-08-12  Adam Bergkvist  <adam.bergkvist@ericsson.com>
2860
2861         Reviewed by Alexey Proskuryakov.
2862
2863         EventSource loader should not buffer data
2864         https://bugs.webkit.org/show_bug.cgi?id=61863
2865
2866         Disabled buffering in the EventSource loader.
2867
2868         Added a manual test.
2869
2870         * manual-tests/eventsource/eventsource-loader-buffering.html: Added.
2871         * manual-tests/eventsource/eventsource-loader-buffering.php: Added.
2872         * page/EventSource.cpp:
2873         (WebCore::EventSource::connect):
2874
2875 2011-08-11  Pratik Solanki  <psolanki@apple.com>
2876
2877         ResourceLoader::didReceiveDataArray() does not handle m_shouldBufferData correctly
2878         https://bugs.webkit.org/show_bug.cgi?id=65926
2879
2880         Reviewed by Alexey Proskuryakov.
2881
2882         * loader/mac/ResourceLoaderMac.mm:
2883         (WebCore::ResourceLoader::didReceiveDataArray): Make sure we call the client callbacks when
2884         m_shouldBufferData is set to false.
2885
2886 2011-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2887
2888         Unreviewed, rolling out r92976.
2889         http://trac.webkit.org/changeset/92976
2890         https://bugs.webkit.org/show_bug.cgi?id=66159
2891
2892         Does not compile on chromium-win (Requested by abarth|gardener
2893         on #webkit).
2894
2895         * WebCore.gypi:
2896         * platform/chromium/PopupContainer.cpp: Removed.
2897         * platform/chromium/PopupContainer.h: Removed.
2898         * platform/chromium/PopupListBox.cpp: Removed.
2899         * platform/chromium/PopupListBox.h: Removed.
2900         * platform/chromium/PopupMenuChromium.cpp:
2901         (WebCore::PopupListBox::create):
2902         (WebCore::PopupListBox::selectedIndex):
2903         (WebCore::PopupListBox::numItems):
2904         (WebCore::PopupListBox::setBaseWidth):
2905         (WebCore::PopupListBox::setMaxHeight):
2906         (WebCore::PopupListBox::setMaxWidth):
2907         (WebCore::PopupListBox::disconnectClient):
2908         (WebCore::PopupListBox::items):
2909         (WebCore::PopupListBox::PopupListBox):
2910         (WebCore::PopupListBox::~PopupListBox):
2911         (WebCore::PopupListBox::scrollToRevealSelection):
2912         (WebCore::constructRelativeMouseEvent):
2913         (WebCore::constructRelativeWheelEvent):
2914         (WebCore::PopupContainer::create):
2915         (WebCore::PopupContainer::PopupContainer):
2916         (WebCore::PopupContainer::~PopupContainer):
2917         (WebCore::PopupContainer::layoutAndCalculateWidgetRect):
2918         (WebCore::PopupContainer::showPopup):
2919         (WebCore::PopupContainer::hidePopup):
2920         (WebCore::PopupContainer::notifyPopupHidden):
2921         (WebCore::PopupContainer::layoutAndGetRTLOffset):
2922         (WebCore::PopupContainer::handleMouseDownEvent):
2923         (WebCore::PopupContainer::handleMouseMoveEvent):
2924         (WebCore::PopupContainer::handleMouseReleaseEvent):
2925         (WebCore::PopupContainer::handleWheelEvent):
2926         (WebCore::PopupContainer::handleTouchEvent):
2927         (WebCore::PopupContainer::handleGestureEvent):
2928         (WebCore::PopupContainer::handleKeyEvent):
2929         (WebCore::PopupContainer::hide):
2930         (WebCore::PopupContainer::paint):
2931         (WebCore::PopupContainer::paintBorder):
2932         (WebCore::PopupContainer::isInterestedInEventForKey):
2933         (WebCore::PopupContainer::chromeClientChromium):
2934         (WebCore::PopupContainer::showInRect):
2935         (WebCore::PopupContainer::refresh):
2936         (WebCore::PopupContainer::isRTL):
2937         (WebCore::PopupContainer::selectedIndex):
2938         (WebCore::PopupContainer::menuItemHeight):
2939         (WebCore::PopupContainer::menuItemFontSize):
2940         (WebCore::PopupContainer::menuStyle):
2941         (WebCore::popupData):
2942         (WebCore::PopupContainer::getSelectedItemToolTip):
2943         (WebCore::PopupListBox::handleMouseDownEvent):
2944         (WebCore::PopupListBox::handleMouseMoveEvent):
2945         (WebCore::PopupListBox::handleMouseReleaseEvent):
2946         (WebCore::PopupListBox::handleWheelEvent):
2947         (WebCore::PopupListBox::isInterestedInEventForKey):
2948         (WebCore::PopupListBox::handleTouchEvent):
2949         (WebCore::PopupListBox::handleGestureEvent):
2950         (WebCore::isCharacterTypeEvent):
2951         (WebCore::PopupListBox::handleKeyEvent):
2952         (WebCore::PopupListBox::hostWindow):
2953         (WebCore::stripLeadingWhiteSpace):
2954         (WebCore::PopupListBox::typeAheadFind):
2955         (WebCore::PopupListBox::paint):
2956         (WebCore::PopupListBox::paintRow):
2957         (WebCore::PopupListBox::getRowFont):
2958         (WebCore::PopupListBox::abandon):
2959         (WebCore::PopupListBox::pointToRowIndex):
2960         (WebCore::PopupListBox::acceptIndex):
2961         (WebCore::PopupListBox::selectIndex):
2962         (WebCore::PopupListBox::setOriginalIndex):
2963         (WebCore::PopupListBox::getRowHeight):
2964         (WebCore::PopupListBox::getRowBounds):
2965         (WebCore::PopupListBox::invalidateRow):
2966         (WebCore::PopupListBox::scrollToRevealRow):
2967         (WebCore::PopupListBox::isSelectableItem):
2968         (WebCore::PopupListBox::clearSelection):
2969         (WebCore::PopupListBox::selectNextRow):
2970         (WebCore::PopupListBox::selectPreviousRow):
2971         (WebCore::PopupListBox::adjustSelectedIndex):
2972         (WebCore::PopupListBox::hidePopup):
2973         (WebCore::PopupListBox::updateFromElement):
2974         (WebCore::PopupListBox::setMaxWidthAndLayout):
2975         (WebCore::PopupListBox::layout):
2976         (WebCore::PopupListBox::clear):
2977         (WebCore::PopupListBox::isPointInBounds):
2978         * platform/chromium/PopupMenuChromium.h:
2979         (WebCore::PopupItem::PopupItem):
2980         (WebCore::PopupContainer::listBox):
2981         (WebCore::PopupContainer::popupType):
2982
2983 2011-08-12  Andy Estes  <aestes@apple.com>
2984
2985         Cancel in onbeforeunload dialog sometime causes a button to stop working.
2986         https://bugs.webkit.org/show_bug.cgi?id=26211
2987
2988         Reviewed by Alexey Proskuryakov.
2989
2990         Test: fast/loader/form-submission-after-beforeunload-cancel.html
2991
2992         If an onbeforeunload handler cancels a navigation that was triggered by
2993         a form submission, WebCore's multiple form submission protection
2994         prevents the form from being submitted a second time even though no
2995         first submission actually took place. Fix this by clearing
2996         m_submittedFormURL if the onbeforeunload handler cancels the load. This
2997         allows the submission to be retried.
2998
2999         * loader/FrameLoader.cpp:
3000         (WebCore::FrameLoader::shouldClose): Set m_submittedFormURL to KURL()
3001         if shouldClose() will return false.
3002
3003 2011-08-12  David Hyatt  <hyatt@apple.com>
3004
3005         https://bugs.webkit.org/show_bug.cgi?id=66130
3006         
3007         RenderRegions need to paint the entire RenderFlowThread layer tree. Instead of just calling
3008         paintBlock, make sure RenderRegions paint the flow thread's layer tree instead with the appropriate
3009         offset.
3010         
3011         Fix RenderRegions to derive from RenderReplaced instead of RenderBox, since it simplifies the code.
3012         They no longer have to subclass their own layout method or worry about all of the painting logic
3013         for anything other than the content area.
3014
3015         Reviewed by Anders Carlsson.
3016
3017         Existing tests have a layer tree example, and so those results are updated to show the tree now.
3018
3019         * rendering/RenderFlowThread.cpp:
3020         (WebCore::RenderFlowThread::createFlowThreadStyle):
3021         (WebCore::RenderFlowThread::paintIntoRegion):
3022         * rendering/RenderLayer.cpp:
3023         (WebCore::RenderLayer::collectLayers):
3024         * rendering/RenderRegion.cpp:
3025         (WebCore::RenderRegion::RenderRegion):
3026         (WebCore::RenderRegion::paintReplaced):
3027         (WebCore::RenderRegion::styleDidChange):
3028         * rendering/RenderRegion.h:
3029
3030 2011-08-12  Chris Rogers  <crogers@google.com>
3031
3032         Fix mac build when web audio is enabled
3033         https://bugs.webkit.org/show_bug.cgi?id=66150
3034
3035         Unreviewed build fix.
3036
3037         * platform/audio/mac/AudioFileReaderMac.cpp:
3038         (WebCore::AudioFileReader::createBus):
3039
3040 2011-08-12  Jeff Miller  <jeffm@apple.com>
3041
3042         Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
3043         https://bugs.webkit.org/show_bug.cgi?id=65724
3044
3045         Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
3046         ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
3047         access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
3048         AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).
3049
3050         Reviewed by Eric Carlson.
3051
3052         No new tests, uses existing media tests.
3053
3054         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
3055         (WebCore::AVFWrapper::callbackContext): Added.
3056         (WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
3057         (WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
3058         (WebCore::AVFWrapper::mapLock): Added.
3059         (WebCore::AVFWrapper::map): Added.
3060         (WebCore::AVFWrapper::addToMap): Added.
3061         (WebCore::AVFWrapper::removeFromMap): Added.
3062         (WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
3063         (WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
3064         (WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
3065         (WebCore::AVFWrapper::createPlayer): Use callbackContext().
3066         (WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
3067         (WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
3068         (WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
3069         (WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
3070         (WebCore::AVFWrapper::checkPlayability): Use callbackContext().
3071         (WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
3072         (WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().
3073         (WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.
3074         (WebCore::AVFWrapper::seekToTime): Use callbackContext().
3075         (WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().
3076
3077 2011-08-12  Fady Samuel  <fsamuel@chromium.org>
3078
3079         Refactoring of PopupMenuChromium
3080         https://bugs.webkit.org/show_bug.cgi?id=66009
3081
3082         Reviewed by Darin Fisher.
3083
3084         Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp}, and PopupLisBox.{h|cpp}
3085         for readability and maintainability.
3086
3087         No new tests as no functionality has changed.
3088
3089         * WebCore.gypi:
3090         * platform/chromium/PopupContainer.cpp: Added.
3091         (WebCore::constructRelativeMouseEvent):
3092         (WebCore::constructRelativeWheelEvent):
3093         (WebCore::PopupContainer::create):
3094         (WebCore::PopupContainer::PopupContainer):
3095         (WebCore::PopupContainer::~PopupContainer):
3096         (WebCore::PopupContainer::layoutAndCalculateWidgetRect):
3097         (WebCore::PopupContainer::showPopup):
3098         (WebCore::PopupContainer::hidePopup):
3099         (WebCore::PopupContainer::notifyPopupHidden):
3100         (WebCore::PopupContainer::layoutAndGetRTLOffset):
3101         (WebCore::PopupContainer::handleMouseDownEvent):
3102         (WebCore::PopupContainer::handleMouseMoveEvent):
3103         (WebCore::PopupContainer::handleMouseReleaseEvent):
3104         (WebCore::PopupContainer::handleWheelEvent):
3105         (WebCore::PopupContainer::handleTouchEvent):
3106         (WebCore::PopupContainer::handleGestureEvent):
3107         (WebCore::PopupContainer::handleKeyEvent):
3108         (WebCore::PopupContainer::hide):
3109         (WebCore::PopupContainer::paint):
3110         (WebCore::PopupContainer::paintBorder):
3111         (WebCore::PopupContainer::isInterestedInEventForKey):
3112         (WebCore::PopupContainer::chromeClientChromium):
3113         (WebCore::PopupContainer::showInRect):
3114         (WebCore::PopupContainer::refresh):
3115         (WebCore::PopupContainer::isRTL):
3116         (WebCore::PopupContainer::selectedIndex):
3117         (WebCore::PopupContainer::menuItemHeight):
3118         (WebCore::PopupContainer::menuItemFontSize):
3119         (WebCore::PopupContainer::menuStyle):
3120         (WebCore::popupData):
3121         (WebCore::PopupContainer::getSelectedItemToolTip):
3122         * platform/chromium/PopupContainer.h: Added.
3123         (WebCore::PopupContainer::listBox):
3124         (WebCore::PopupContainer::popupType):
3125         * platform/chromium/PopupListBox.cpp: Added.
3126         (WebCore::PopupListBox::PopupListBox):
3127         (WebCore::PopupListBox::handleMouseDownEvent):
3128         (WebCore::PopupListBox::handleMouseMoveEvent):
3129         (WebCore::PopupListBox::handleMouseReleaseEvent):
3130         (WebCore::PopupListBox::handleWheelEvent):
3131         (WebCore::PopupListBox::isInterestedInEventForKey):
3132         (WebCore::PopupListBox::handleTouchEvent):
3133         (WebCore::PopupListBox::handleGestureEvent):
3134         (WebCore::isCharacterTypeEvent):
3135         (WebCore::PopupListBox::handleKeyEvent):
3136         (WebCore::PopupListBox::hostWindow):
3137         (WebCore::stripLeadingWhiteSpace):
3138         (WebCore::PopupListBox::typeAheadFind):
3139         (WebCore::PopupListBox::paint):
3140         (WebCore::PopupListBox::paintRow):
3141         (WebCore::PopupListBox::getRowFont):
3142         (WebCore::PopupListBox::abandon):
3143         (WebCore::PopupListBox::pointToRowIndex):
3144         (WebCore::PopupListBox::acceptIndex):
3145         (WebCore::PopupListBox::selectIndex):
3146         (WebCore::PopupListBox::setOriginalIndex):
3147         (WebCore::PopupListBox::getRowHeight):
3148         (WebCore::PopupListBox::getRowBounds):
3149         (WebCore::PopupListBox::invalidateRow):
3150         (WebCore::PopupListBox::scrollToRevealRow):
3151         (WebCore::PopupListBox::isSelectableItem):
3152         (WebCore::PopupListBox::clearSelection):
3153         (WebCore::PopupListBox::selectNextRow):
3154         (WebCore::PopupListBox::selectPreviousRow):
3155         (WebCore::PopupListBox::adjustSelectedIndex):
3156         (WebCore::PopupListBox::hidePopup):
3157         (WebCore::PopupListBox::updateFromElement):
3158         (WebCore::PopupListBox::setMaxWidthAndLayout):
3159         (WebCore::PopupListBox::layout):
3160         (WebCore::PopupListBox::clear):
3161         (WebCore::PopupListBox::isPointInBounds):
3162         * platform/chromium/PopupListBox.h: Added.
3163         (WebCore::PopupItem::PopupItem):
3164         (WebCore::PopupListBox::create):
3165         (WebCore::PopupListBox::selectedIndex):
3166         (WebCore::PopupListBox::numItems):
3167         (WebCore::PopupListBox::setBaseWidth):
3168         (WebCore::PopupListBox::setMaxHeight):
3169         (WebCore::PopupListBox::setMaxWidth):
3170         (WebCore::PopupListBox::disconnectClient):
3171         (WebCore::PopupListBox::items):
3172         (WebCore::PopupListBox::~PopupListBox):
3173         (WebCore::PopupListBox::scrollToRevealSelection):
3174         * platform/chromium/PopupMenuChromium.cpp:
3175         * platform/chromium/PopupMenuChromium.h:
3176
3177 2011-08-12  Sam Weinig  <sam@webkit.org>
3178
3179         Move compiler specific macros to their own header
3180         https://bugs.webkit.org/show_bug.cgi?id=66119
3181
3182         Reviewed by Anders Carlsson.
3183
3184         * ForwardingHeaders/wtf/Compiler.h: Added.
3185
3186 2011-08-12  No'am Rosenthal  <noam.rosenthal@nokia.com>
3187
3188         [Qt][REGRESSION] composited content doesn't render since r92651
3189         https://bugs.webkit.org/show_bug.cgi?id=66108
3190
3191         Reviewed by Benjamin Poulain.
3192
3193         Changed the signature for GraphicsLayerTextureMapper::syncCompositingState to match
3194         the new signature in GraphicsLayer.h.
3195
3196         No new tests. This is a regression that's covered by existing pixel tests.
3197
3198         * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
3199         (WebCore::GraphicsLayerTextureMapper::syncCompositingState):
3200         * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
3201
3202 2011-08-12  Alexandru Chiculita  <achicu@adobe.com>
3203
3204         Original patch by Mihnea Ovidenie <mihnea@adobe.com>.
3205         Also contains some improvements done by Dave Hyatt <hyatt@apple.com>.
3206
3207         [CSSRegions]RenderFlowThread should display its content using RenderRegion
3208         https://bugs.webkit.org/show_bug.cgi?id=65627
3209
3210         RenderFlowThread collects RenderObjects from a flow. These objects are displayed by means
3211         of RenderRegion objects that get the content from the same flow.
3212
3213         Reviewed by David Hyatt.
3214
3215         Tests: fast/regions/content-flowed-into-regions-dynamically-added.html
3216                fast/regions/content-flowed-into-regions-dynamically-removed.html
3217                fast/regions/content-flowed-into-regions-with-dyn-index.html
3218                fast/regions/content-flowed-into-regions-with-index-dom.html
3219                fast/regions/content-flowed-into-regions-with-index.html
3220                fast/regions/content-flowed-into-regions.html
3221                fast/regions/flow-content-basic-vertical-rl.html
3222                fast/regions/flow-content-basic-vertical.html
3223
3224         * dom/Node.cpp:
3225         (WebCore::Node::diff):
3226         * rendering/RenderFlowThread.cpp:
3227         (WebCore::RenderFlowThread::RenderFlowThread):
3228         (WebCore::RenderFlowThread::createFlowThreadStyle):
3229         (WebCore::RenderFlowThread::styleDidChange):
3230         (WebCore::compareRenderRegions):
3231         (WebCore::RenderFlowThread::addRegionToThread):
3232         (WebCore::RenderFlowThread::removeRegionFromThread):
3233         (WebCore::RenderFlowThread::layout):
3234         (WebCore::RenderFlowThread::computeLogicalWidth):
3235         (WebCore::RenderFlowThread::computeLogicalHeight):
3236         (WebCore::RenderFlowThread::paintIntoRegion):
3237         * rendering/RenderFlowThread.h:
3238         * rendering/RenderObject.cpp:
3239         (WebCore::RenderObject::createObject):
3240         * rendering/RenderRegion.cpp:
3241         (WebCore::RenderRegion::RenderRegion):
3242         (WebCore::RenderRegion::~RenderRegion):
3243         (WebCore::RenderRegion::paint):
3244         (WebCore::RenderRegion::styleDidChange):
3245         * rendering/RenderRegion.h:
3246         (WebCore::RenderRegion::setRegionRect):
3247         (WebCore::RenderRegion::regionRect):
3248         * rendering/RenderTreeAsText.cpp:
3249         (WebCore::writeLayers):
3250         * rendering/RenderView.cpp:
3251         (WebCore::RenderView::styleDidChange):
3252         (WebCore::RenderView::renderFlowThreadWithName):
3253         * rendering/RenderView.h:
3254
3255 2011-08-12  Abhishek Arya  <inferno@chromium.org>
3256
3257         Crash in WebCore::editingIgnoresContent
3258         https://bugs.webkit.org/show_bug.cgi?id=66125
3259
3260         Reviewed by Ryosuke Niwa.
3261
3262         RefPtr a few nodes in case they get blown away in
3263         dispatchEvent calls.
3264
3265         Test: editing/selection/select-start-remove-root-crash.html
3266
3267         * editing/FrameSelection.cpp:
3268         (WebCore::FrameSelection::selectAll):
3269         * editing/ReplaceSelectionCommand.cpp:
3270         (WebCore::ReplacementFragment::ReplacementFragment):
3271
3272 2011-08-11  Pavel Podivilov  <podivilov@chromium.org>
3273
3274         Web Inspector: properly update console message count in source frames and resources panel.
3275         https://bugs.webkit.org/show_bug.cgi?id=57009
3276
3277         Reviewed by Yury Semikhatsky.
3278
3279         * inspector/front-end/ConsoleView.js:
3280         (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
3281         * inspector/front-end/SourceFrame.js:
3282         (WebInspector.SourceFrame.prototype.show):
3283         (WebInspector.SourceFrame.prototype.addMessageToSource):
3284         (WebInspector.SourceFrame.prototype._updateMessageRepeatCount):
3285
3286 2011-08-12  Pavel Feldman  <pfeldman@google.com>
3287
3288         Not reviewed: follow up to inspector test breakage.
3289
3290         * inspector/front-end/ScriptsPanel.js:
3291         (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
3292
3293 2011-08-12  Yury Semikhatsky  <yurys@chromium.org>
3294
3295         Web Inspector: expand exception properties when wrapping it as object.
3296         https://bugs.webkit.org/show_bug.cgi?id=66035
3297
3298         Use toString() value as a description for value thrown during eval.
3299
3300         Reviewed by Pavel Feldman.
3301
3302         * inspector/InjectedScriptSource.js:
3303         (.):
3304
3305 2011-08-12  Pavel Feldman  <pfeldman@google.com>
3306
3307         Web Inspector: make folders optional in the Scripts' panel file selector.
3308         https://bugs.webkit.org/show_bug.cgi?id=66100
3309
3310         Reviewed by Yury Semikhatsky.
3311
3312         * English.lproj/localizedStrings.js:
3313         * inspector/front-end/ScriptsPanel.js:
3314         (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
3315         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
3316         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
3317         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
3318         (WebInspector.ScriptsPanel.prototype.reset):
3319         (WebInspector.ScriptsPanel.prototype._resetFilesSelect):
3320         * inspector/front-end/Settings.js:
3321         (WebInspector.Settings):
3322         * inspector/front-end/SettingsScreen.js:
3323         (WebInspector.SettingsScreen):
3324
3325 2011-08-12  Pavel Podivilov  <podivilov@chromium.org>
3326
3327         Web Inspector: add space between error info and error message in source frame message bubble.
3328         https://bugs.webkit.org/show_bug.cgi?id=65069
3329
3330         Reviewed by Pavel Feldman.
3331
3332         * inspector/front-end/ConsoleView.js:
3333         (WebInspector.ConsoleMessage.prototype._formatMessage):
3334
3335 2011-08-12  Pavel Feldman  <pfeldman@google.com>
3336
3337         Web Inspector: console loses focus upon reloading the page from the inspector.
3338         https://bugs.webkit.org/show_bug.cgi?id=66068
3339
3340         Reviewed by Yury Semikhatsky.
3341
3342         * inspector/front-end/AuditsPanel.js:
3343         (WebInspector.AuditsPanel.prototype._auditFinishedCallback):
3344         (WebInspector.AuditsPanel.prototype._clearButtonClicked):
3345         * inspector/front-end/DataGrid.js:
3346         (WebInspector.DataGrid.prototype.revealAndSelect):
3347         (WebInspector.DataGridNode.prototype.revealAndSelect):
3348         * inspector/front-end/DetailedHeapshotView.js:
3349         (WebInspector.DetailedHeapshotView.prototype._jumpToSearchResult):
3350         * inspector/front-end/ElementsPanel.js:
3351         (WebInspector.ElementsPanel.this.treeOutline.selectedNodeChanged):
3352         (WebInspector.ElementsPanel.get this):
3353         (WebInspector.ElementsPanel):
3354         (WebInspector.ElementsPanel.prototype._reset):
3355         (WebInspector.ElementsPanel.prototype._setDocument.selectNode):
3356         (WebInspector.ElementsPanel.prototype._setDocument.selectLastSelectedNode):
3357         (WebInspector.ElementsPanel.prototype._setDocument):
3358         (WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
3359         (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
3360         (WebInspector.ElementsPanel.prototype.switchToAndFocus):
3361         (WebInspector.ElementsPanel.prototype.selectedDOMNode):
3362         (WebInspector.ElementsPanel.prototype.selectDOMNode):
3363         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
3364         (WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
3365         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
3366         (WebInspector.ElementsPanel.prototype.updateStyles):
3367         (WebInspector.ElementsPanel.prototype.updateMetrics):
3368         (WebInspector.ElementsPanel.prototype.updateProperties):
3369         (WebInspector.ElementsPanel.prototype.updateEventListeners):
3370         (WebInspector.ElementsPanel.prototype.handleCopyEvent):
3371         (WebInspector.ElementsPanel.prototype.updateFocusedNode):
3372         * inspector/front-end/ElementsTreeOutline.js:
3373         (WebInspector.ElementsTreeOutline):
3374         (WebInspector.ElementsTreeOutline.prototype.selectedDOMNode):
3375         (WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
3376         (WebInspector.ElementsTreeOutline.prototype.update):
3377         (WebInspector.ElementsTreeOutline.prototype._revealAndSelectNode):
3378         (WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
3379         (WebInspector.ElementsTreeOutline.prototype._ondrop):
3380         (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
3381         (WebInspector.ElementsTreeElement.prototype._updateChildren):
3382         (WebInspector.ElementsTreeElement.prototype.onselect):
3383         (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
3384         (WebInspector.ElementsTreeElement.prototype._startEditingTarget):
3385         (WebInspector.ElementsTreeElement.prototype._startEditing):
3386         * inspector/front-end/Panel.js:
3387         (WebInspector.Panel.prototype.reset):
3388         * inspector/front-end/ProfileView.js:
3389         (WebInspector.CPUProfileView.prototype._jumpToSearchResult):
3390         * inspector/front-end/ProfilesPanel.js:
3391         (WebInspector.ProfilesPanel.prototype._addProfileHeader):
3392         (WebInspector.ProfilesPanel.prototype.showProfile):
3393         (WebInspector.ProfileSidebarTreeElement.prototype.onselect):
3394         * inspector/front-end/ResourcesPanel.js:
3395         (WebInspector.ResourcesPanel.prototype._initDefaultSelection.get if):
3396         (WebInspector.ResourcesPanel.prototype._initDefaultSelection):
3397         (WebInspector.ResourcesPanel.prototype.reset):
3398         (WebInspector.ResourcesPanel.prototype.showResource):
3399         * inspector/front-end/StylesSidebarPane.js:
3400         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
3401         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
3402         * inspector/front-end/TimelinePanel.js:
3403         (WebInspector.TimelinePanel.prototype._createTopPane):
3404         * inspector/front-end/inspector.js:
3405         * inspector/front-end/inspectorCommon.css:
3406         (body):
3407         * inspector/front-end/treeoutline.js:
3408         (TreeOutline.prototype.revealAndSelect):
3409         (TreeElement.prototype.selectOnMouseDown):
3410         (TreeElement.prototype.revealAndSelect):
3411         (TreeElement.prototype.select):
3412
3413 2011-08-12  Yury Semikhatsky  <yurys@chromium.org>
3414
3415         Unreviewed. Inspector clean-up: remove unused method declaration from InspectorAgent.h
3416
3417         * inspector/InspectorAgent.h:
3418
3419 2011-08-12  Vsevolod Vlasov  <vsevik@chromium.org>
3420
3421         Web Inspector: Network resource identifier should have RequestId type and requestId name in protocol.
3422         https://bugs.webkit.org/show_bug.cgi?id=66061
3423
3424         Reviewed by Pavel Feldman.
3425
3426         * inspector/ConsoleMessage.cpp:
3427         (WebCore::ConsoleMessage::ConsoleMessage):
3428         (WebCore::ConsoleMessage::addToFrontend):
3429         * inspector/ConsoleMessage.h:
3430         * inspector/IdentifiersFactory.cpp:
3431         (WebCore::IdentifiersFactory::requestId):
3432         * inspector/IdentifiersFactory.h:
3433         * inspector/Inspector.json:
3434         * inspector/InspectorConsoleAgent.cpp:
3435         (WebCore::InspectorConsoleAgent::didReceiveResponse):
3436         (WebCore::InspectorConsoleAgent::didFailLoading):
3437         * inspector/InspectorResourceAgent.cpp:
3438         (WebCore::InspectorResourceAgent::willSendRequest):
3439         (WebCore::InspectorResourceAgent::markResourceAsCached):
3440         (WebCore::InspectorResourceAgent::didReceiveResponse):
3441         (WebCore::InspectorResourceAgent::didReceiveData):
3442         (WebCore::InspectorResourceAgent::didFinishLoading):
3443         (WebCore::InspectorResourceAgent::didFailLoading):
3444         (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
3445         (WebCore::InspectorResourceAgent::setInitialScriptContent):
3446         (WebCore::InspectorResourceAgent::didReceiveScriptResponse):
3447         (WebCore::InspectorResourceAgent::setInitialXHRContent):
3448         (WebCore::InspectorResourceAgent::didReceiveXHRResponse):
3449         (WebCore::InspectorResourceAgent::didCreateWebSocket):
3450         (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
3451         (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
3452         (WebCore::InspectorResourceAgent::didCloseWebSocket):
3453         (WebCore::InspectorResourceAgent::getResourceContent):
3454         * inspector/InspectorResourceAgent.h:
3455         * inspector/InspectorTimelineAgent.cpp:
3456         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3457         (WebCore::InspectorTimelineAgent::willReceiveResourceData):
3458         (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
3459         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
3460         * inspector/NetworkResourcesData.cpp:
3461         (WebCore::NetworkResourcesData::ResourceData::ResourceData):
3462         (WebCore::NetworkResourcesData::resourceCreated):
3463         (WebCore::NetworkResourcesData::responseReceived):
3464         (WebCore::NetworkResourcesData::setResourceType):
3465         (WebCore::NetworkResourcesData::resourceType):
3466         (WebCore::NetworkResourcesData::setResourceContent):
3467         (WebCore::NetworkResourcesData::maybeAddResourceData):
3468         (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
3469         (WebCore::NetworkResourcesData::addCachedResource):
3470         (WebCore::NetworkResourcesData::addResourceSharedBuffer):
3471         (WebCore::NetworkResourcesData::data):
3472         (WebCore::NetworkResourcesData::clear):
3473         (WebCore::NetworkResourcesData::ensureNoDataForRequestId):
34