Find in page for typographic quotes does not find low (German) quotes
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2018-06-28  Olivia Barnett  <obarnett@apple.com>
2
3         Find in page for typographic quotes does not find low (German) quotes
4         https://bugs.webkit.org/show_bug.cgi?id=187164
5         <rdar://problem/29612785>
6
7         Reviewed by Tim Horton.
8
9         Added additional quote test to LayoutTests/fast/text/find-quotes.html.
10
11         Added functionality to replace German quotes when matching.
12
13         * editing/TextIterator.cpp:
14         (WebCore::foldQuoteMark):
15         (WebCore::foldQuoteMarks):
16
17 2018-06-28  Antti Koivisto  <antti@apple.com>
18
19         REGRESSION (233281): fast/dom/location-new-window-no-crash.html and some other tests are timing out
20         https://bugs.webkit.org/show_bug.cgi?id=187156
21
22         Reviewed by Zalan Bujtas.
23
24         We need still need to re-enable memory cache client calls even when not doing other post-resolution callbacks.
25
26         * style/StyleTreeResolver.cpp:
27         (WebCore::Style::memoryCacheClientCallsResumeQueue):
28
29         Add a separate queue for this.
30
31         (WebCore::Style::suspendMemoryCacheClientCalls):
32         (WebCore::Style::PostResolutionCallbackDisabler::~PostResolutionCallbackDisabler):
33
34 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
35
36         [iOS] DataTransfer.getData always returns the empty string when dropping text
37         https://bugs.webkit.org/show_bug.cgi?id=187130
38         <rdar://problem/41014117>
39
40         Reviewed by Ryosuke Niwa.
41
42         Currently, DataTransfer.getData() always returns the empty string on drop. This is because all data on drop is
43         backed by local files in the temporary directory, so the number of files is never 0; this, combined with the
44         fact that WebKit will suppress access to the DataTransfer object if there is one or more file in the pasteboard,
45         means that getData() never works for drag and drop on iOS at the moment. To fix this, we need to know whether a
46         dropped item provider is a file.
47
48         Ideally, we'd have a flag to tell us whether or not an NSItemProvider being dropped is a file, or instead just
49         inline data - in fact, this flag already exists in the form of UIPreferredPresentationStyle. Unfortunately, not
50         all apps that vend draggable files specify this, so we can't simply ask the item provider whether it's intended
51         to be a file. As a workaround, we can use several heuristics to determine the "file content state" of the drag
52         pasteboard on iOS (see below for more details).
53
54         This patch adds some plumbing through the client layers to grab a list of item information describing each
55         dropped item provider on iOS. Using this information, we tweak the logic in Pasteboard::fileContentState to make
56         an educated guess at whether or not the pasteboard really contains files; if we determine that the pasteboard
57         probably contains no files, we'll allow DataTransfer.getData() to retrieve information from the pasteboard.
58         Otherwise, if the pasteboard may contain files, we'll fall back to our current behavior of including the "Files"
59         type in DataTransfer.types and allowing the page to grab file data using DataTransfer.files or
60         DataTransfer.items.
61
62         Tests:  DataInteractionTests.DataTransferGetDataReadPlainAndRichText
63                 DataInteractionTests.DataTransferSuppressGetDataDueToPresenceOfTextFile
64
65         * dom/DataTransfer.cpp:
66         (WebCore::DataTransfer::filesFromPasteboardAndItemList const):
67
68         Check Pasteboard::fileContentState() to ensure that we don't expose files when DataTransfer.types does not
69         contain the "Files" type, and vice versa, and DataTranser.files is also empty in this case.
70
71         * dom/DataTransferItemList.cpp:
72         * platform/PasteboardItemInfo.h:
73
74         Add a couple of additional members to PasteboardItemInfo: suggestedFileName and hasDeclaredNonTextType, a flag
75         that indicates whether or not the pasteboard item has a type representation that is a declared type, but is not
76         a text type (i.e. does not conform to "public.text", "public.url", or rich text format with attachment types).
77
78         (WebCore::PasteboardItemInfo::encode const):
79         (WebCore::PasteboardItemInfo::decode):
80         * platform/PasteboardStrategy.h:
81         * platform/PlatformPasteboard.h:
82         * platform/cocoa/PasteboardCocoa.mm:
83         (WebCore::Pasteboard::fileContentState):
84
85         Instead of always considering a dropped item provider on iOS to represent a file, only do so if at least one of
86         the following conditions are met:
87         - The drop session contains multiple item providers (flocking text selections is a very rare use case).
88         - The item provider was explicitly marked as an attachment.
89         - The item provider has a suggested file name.
90         - The item provider has any other content that is not text.
91
92         In the case where none of the above conditions are met, the item provider (if it ends up being a file) is
93         essentially indistinguishable from inline data. An example of this is dropping a plain text file that is
94         unnamed, with no presentation style, and alongside no other items nor other known type representations. These
95         are cases in which whether the item is treated as a file or as inline data is (hopefully) irrelevant.
96
97         * platform/ios/PlatformPasteboardIOS.mm:
98         (WebCore::PlatformPasteboard::allPasteboardItemInfo):
99         (WebCore::PlatformPasteboard::informationForItemAtIndex):
100
101 2018-06-28  Timothy Hatcher  <timothy@apple.com>
102
103         Don't force black text when TextIndicator draws backgrounds or all content.
104         https://bugs.webkit.org/show_bug.cgi?id=187161
105         rdar://problem/40434644
106
107         Reviewed by Tim Horton.
108
109         * page/TextIndicator.cpp:
110         (WebCore::snapshotOptionsForTextIndicatorOptions):
111         Only set SnapshotOptionsForceBlackText when TextIndicatorOptionRespectTextColor and
112         TextIndicatorOptionPaintBackgrounds are not set.
113
114 2018-06-28  Timothy Hatcher  <timothy@apple.com>
115
116         Find on page selection color isn't adapted for dark mode.
117         https://bugs.webkit.org/show_bug.cgi?id=187072
118
119         Unreviewed, revert part of r233280.
120
121         * rendering/RenderThemeMac.mm:
122         (WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const): Use pure yellow again.
123
124 2018-06-28  Antoine Quint  <graouts@apple.com>
125
126         [Web Animations] Make imported/mozilla/css-animations/test_animation-starttime.html pass reliably
127         https://bugs.webkit.org/show_bug.cgi?id=183834
128         <rdar://problem/40997932>
129
130         Reviewed by Dean Jackson.
131
132         We need to run pending tasks in the "update animations" procedure to ensure that the start time has been set
133         to a different time than the timeline time at the time the animation was asked to play(). This ensure the
134         timeline current time has progressed and can be queried to a different value in a requestAnimationFrame()
135         callback.
136
137         When invalidating events, we need to make sure we disregard instances when an animation has and is still pending
138         so that we wait until we change the pending state to work out which events to enqueue.
139
140         * animation/DeclarativeAnimation.cpp:
141         (WebCore::DeclarativeAnimation::invalidateDOMEvents):
142         * animation/DocumentTimeline.cpp:
143         (WebCore::DocumentTimeline::updateAnimations):
144         * animation/WebAnimation.cpp:
145         (WebCore::WebAnimation::updatePendingTasks):
146         (WebCore::WebAnimation::timeToNextRequiredTick const):
147         (WebCore::WebAnimation::runPendingTasks):
148         * animation/WebAnimation.h:
149
150 2018-06-28  Ryosuke Niwa  <rniwa@webkit.org>
151
152         Release assert in ScriptController::canExecuteScripts via WebCore::SVGUseElement::insertedIntoAncestor
153         https://bugs.webkit.org/show_bug.cgi?id=187137
154         <rdar://problem/41081885>
155
156         Reviewed by Zalan Bujtas.
157
158         The bug was caused by SVGUseElement::notifyFinished firing a DOM event via SVGUseElement::updateExternalDocument
159         inside SVGUseElement::insertedIntoAncestor. Ideally, we make every call to notifyFinished asynchronous
160         but simply delay the call to updateExternalDocument() until didFinishInsertingNode() for now.
161
162         No new tests since the failure is caught with the newly added assertion in notifyFinished by existing SVG tests
163         such as svg/batik/filters/filterRegions.svg and svg/batik/text/smallFonts.svg. Unfortunately, I could not
164         construct a test case which hits this release assertion since the real crash happens when the cached resource
165         had an error but in the all cases I could find, the resource response with an error results in a reload or
166         an asynchronous failure callback.
167
168         * loader/cache/CachedResource.cpp:
169         (WebCore::CachedResource::didAddClient): Added a FIXME.
170         * svg/SVGUseElement.cpp:
171         (WebCore::SVGUseElement::insertedIntoAncestor): Delay the call to updateExternalDocument.
172         (WebCore::SVGUseElement::didFinishInsertingNode): Invoke updateExternalDocument.
173         (WebCore::SVGUseElement::notifyFinished): Added an assertion.
174         * svg/SVGUseElement.h:
175
176 2018-06-28  Chris Dumez  <cdumez@apple.com>
177
178         Unreviewed, rolling out r233309.
179
180         Invalidates previous database model without versioning
181
182         Reverted changeset:
183
184         "Fix encoding / decoding issues in ResourceLoadStatistics"
185         https://bugs.webkit.org/show_bug.cgi?id=186890
186         https://trac.webkit.org/changeset/233309
187
188 2018-06-28  Timothy Hatcher  <timothy@apple.com>
189
190         Focus ring color does not honor dark mode or system accent color.
191         https://bugs.webkit.org/show_bug.cgi?id=187144
192         rdar://problem/41105081
193
194         Reviewed by Tim Horton.
195
196         Pass the focus ring color through to the GraphicsContext methods that draw it.
197
198         * platform/graphics/GraphicsContext.h:
199         * platform/graphics/cocoa/GraphicsContextCocoa.mm:
200         (WebCore::drawFocusRingAtTime):
201         (WebCore::drawFocusRing):
202         (WebCore::drawFocusRingToContext):
203         (WebCore::drawFocusRingToContextAtTime):
204         (WebCore::GraphicsContext::drawFocusRing):
205         (WebCore::GraphicsContext::focusRingColor): Deleted.
206         * platform/mac/ThemeMac.mm:
207         (WebCore::drawCellFocusRingWithFrameAtTime):
208         * rendering/RenderElement.cpp:
209         (WebCore::RenderElement::paintFocusRing):
210         * rendering/RenderImage.cpp:
211         (WebCore::RenderImage::paintAreaElementFocusRing):
212
213 2018-06-28  Aditya Keerthi  <akeerthi@apple.com>
214
215         REGRESSION (r232040): Cursor jumping in Safari text fields
216         https://bugs.webkit.org/show_bug.cgi?id=187142
217         <rdar://problem/41397577>
218
219         Reviewed by Tim Horton.
220
221         r232040 enabled click events to fire on nodes that are already being edited in
222         iOS. This resulted FrameSelection::setSelection being called twice. One call
223         originated from the UIWKTextInteractionAssistant, which snaps the caret to word
224         boundaries. The other call originates from handleMousePressEvent in EventHandler,
225         and uses character boundaries. Consequently, we see the caret jumping around.
226
227         To fix this issue, an early return was added in the handleMousePressEvent
228         codepath, which prevents FrameSelection::setSelection from being called when
229         clicking on a node that is already being edited. This ensures that the
230         UIWKTextInteractionAssistant codepath is the only influence on the caret position.
231
232         Test: fast/events/ios/click-selectionchange-once.html
233
234         * page/EventHandler.cpp:
235         (WebCore::EventHandler::handleMousePressEventSingleClick):
236
237 2018-06-28  Chris Dumez  <cdumez@apple.com>
238
239         Fix encoding / decoding issues in ResourceLoadStatistics
240         https://bugs.webkit.org/show_bug.cgi?id=186890
241
242         Reviewed by Brent Fulgham.
243
244         * loader/ResourceLoadStatistics.cpp:
245         (WebCore::encodeHashCountedSet):
246         (WebCore::encodeHashSet):
247         Do not return early if the container we're trying to encode is empty. Instead,
248         have the encoder encode an empty array. This is important for encoding / decoding
249         to be fully symmetric. Otherwise, when trying to decode one of these empty containers,
250         the decoder would fail (silently since we were ignoring decoding errors). Worse, the
251         decoder might succeed but actually be decoding the *next* container in the file, since
252         we have several HashCountedSets / HashSets encoded one after another.
253
254         (WebCore::decodeHashCountedSet):
255         (WebCore::decodeHashSet):
256         Return a boolean to indicate if the decoding suceeded or not.
257
258         (WebCore::ResourceLoadStatistics::decode):
259         Check for container decoding errors and return false when decoding fails.
260         Otherwise, we would just silently keep going.
261
262 2018-06-28  Sihui Liu  <sihui_liu@apple.com>
263
264         Cookie API: cookie creation time is wrong
265         https://bugs.webkit.org/show_bug.cgi?id=187101
266
267         Reviewed by Geoffrey Garen.
268
269         Covered by API test: WebKit.WKHTTPCookieStoreCreationTime.
270
271         * platform/network/cocoa/CookieCocoa.mm:
272         (WebCore::Cookie::operator NSHTTPCookie * _Nullable  const):
273
274 2018-06-28  Zalan Bujtas  <zalan@apple.com>
275
276         [LFC] Add Display::Box::nonCollapsedMarginBox for verification purposes.
277         https://bugs.webkit.org/show_bug.cgi?id=187140
278
279         Reviewed by Antti Koivisto.
280
281         * layout/FormattingContext.cpp:
282         (WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
283         (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
284         * layout/Verification.cpp:
285         (WebCore::Layout::outputMismatchingBoxInformationIfNeeded):
286         * layout/blockformatting/BlockFormattingContext.cpp:
287         (WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):
288         * layout/displaytree/DisplayBox.cpp:
289         (WebCore::Display::Box::nonCollapsedMarginBox const):
290         * layout/displaytree/DisplayBox.h:
291         (WebCore::Display::Box::setVerticalNonCollapsedMargin):
292
293 2018-06-28  Zalan Bujtas  <zalan@apple.com>
294
295         [LFC] The margin bottom of the document element does not collapse with its last inflow child's bottom margin.
296         https://bugs.webkit.org/show_bug.cgi?id=187135
297
298         Reviewed by Antti Koivisto.
299
300         * layout/blockformatting/BlockFormattingContext.h:
301         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
302         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
303         * layout/blockformatting/BlockMarginCollapse.cpp:
304         (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBottom):
305         (WebCore::Layout::BlockFormattingContext::MarginCollapse::isMarginBottomCollapsedWithParent):
306         (WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginBottomFromLastChild):
307
308 2018-06-28  Dirk Schulze  <krit@webkit.org>
309
310         [css-masking] Update clip-path box mapping to unified box
311         https://bugs.webkit.org/show_bug.cgi?id=185797
312
313         Reviewed by Simon Fraser.
314
315         The box mapping for fill-box, stroke-box, view-box on HTML elements
316         and content-box, padding-box, margin-box, border-box for SVG elements
317         was aligned with the transform-box CSS property.
318
319         Furthermore, the keywords fill changed to fill-box and stroke changed
320         to stroke-box.
321
322         https://drafts.fxtf.org/css-masking-1/#typedef-geometry-box
323
324         Update the -webkit-clip-path property.
325
326         Tests: svg/clip-path/clip-path-shape-border-box-expected.svg
327                svg/clip-path/clip-path-shape-border-box.svg
328                svg/clip-path/clip-path-shape-content-box-expected.svg
329                svg/clip-path/clip-path-shape-content-box.svg
330                svg/clip-path/clip-path-shape-margin-box-expected.svg
331                svg/clip-path/clip-path-shape-margin-box.svg
332                svg/clip-path/clip-path-shape-padding-box-expected.svg
333                svg/clip-path/clip-path-shape-padding-box.svg
334
335         * css/CSSPrimitiveValueMappings.h:
336         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
337         (WebCore::CSSPrimitiveValue::operator CSSBoxType const):
338         * css/CSSValueKeywords.in:
339         * css/StyleBuilderConverter.h:
340         (WebCore::StyleBuilderConverter::convertClipPath):
341         * css/parser/CSSPropertyParser.cpp:
342         (WebCore::consumeBasicShapeOrBox):
343         * rendering/RenderBlock.cpp:
344         (WebCore::RenderBlock::nodeAtPoint):
345         * rendering/RenderLayer.cpp:
346         (WebCore::computeReferenceBox):
347         * rendering/shapes/BoxShape.cpp:
348         (WebCore::computeRoundedRectForBoxShape):
349         * rendering/shapes/ShapeOutsideInfo.cpp:
350         (WebCore::ShapeOutsideInfo::setReferenceBoxLogicalSize):
351         (WebCore::ShapeOutsideInfo::logicalTopOffset const):
352         (WebCore::ShapeOutsideInfo::logicalLeftOffset const):
353         * rendering/style/RenderStyleConstants.h:
354         * rendering/svg/SVGRenderingContext.cpp:
355         (WebCore::SVGRenderingContext::prepareToRenderSVGContent):
356
357 2018-06-27  Timothy Hatcher  <timothy@apple.com>
358
359         Don't expose new semantic -apple-system color keywords on iOS.
360         https://bugs.webkit.org/show_bug.cgi?id=187080
361         rdar://problem/41505699
362
363         Reviewed by Tim Horton.
364
365         * DerivedSources.make: Use gnu++14, since gnu++17 is giving errors on macOS 10.12.
366         * css/CSSValueKeywords.in: Define new semantic colors only on macOS.
367
368 2018-06-27  Zalan Bujtas  <zalan@apple.com>
369
370         [LFC] Compute both the collapsed and the non-collapsed margin values.
371         https://bugs.webkit.org/show_bug.cgi?id=187129
372
373         Reviewed by Antti Koivisto.
374
375         For validation purposes only at this point.
376
377         * layout/FormattingContext.cpp:
378         (WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
379         (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
380         * layout/FormattingContext.h:
381         * layout/FormattingContextGeometry.cpp:
382         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
383         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
384         (WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
385         (WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
386         * layout/blockformatting/BlockFormattingContext.cpp:
387         (WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):
388         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
389         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
390         * layout/blockformatting/BlockMarginCollapse.cpp:
391         (WebCore::Layout::isMarginTopCollapsedWithParent):
392         (WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
393         (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):
394
395 2018-06-27  Zalan Bujtas  <zalan@apple.com>
396
397         [LFC] Align inFlowNonReplacedHeightAndMargin() style with the rest of the compute functions.
398         https://bugs.webkit.org/show_bug.cgi?id=187126
399
400         Reviewed by Antti Koivisto.
401
402         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
403         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
404
405 2018-06-27  Yusuke Suzuki  <utatane.tea@gmail.com>
406
407         [GTK][WPE] Use LazyNeverDestroyed<XErrorTrapper> to remove static initializers
408         https://bugs.webkit.org/show_bug.cgi?id=187089
409
410         Reviewed by Michael Catanzaro.
411
412         Do not allow copying since XErrorTrapper's logic relies on the address of XErrorTrapper.
413
414         * platform/graphics/x11/XErrorTrapper.h:
415
416 2018-06-27  Zalan Bujtas  <zalan@apple.com>
417
418         [LFC] Align inFlowNonReplacedWidthAndMargin() style with the rest of the compute functions.
419         https://bugs.webkit.org/show_bug.cgi?id=187124
420
421         Reviewed by Antti Koivisto.
422
423         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
424         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
425
426 2018-06-27  Dirk Schulze  <krit@webkit.org>
427
428         -webkit-clip-path wrong offset for clipPath references
429         https://bugs.webkit.org/show_bug.cgi?id=129246
430
431         Reviewed by Simon Fraser.
432
433         Compute the correct offset for reference clip-paths by reusing
434         some of the logic from basic shapes.
435         Makes reference based clip-path interoperable and follows the
436         spec.
437
438         Test: css3/masking/clip-path-reference-2.html
439
440         * rendering/RenderLayer.cpp:
441         (WebCore::computeReferenceBox):
442         (WebCore::RenderLayer::computeClipPath const):
443         (WebCore::RenderLayer::setupClipPath):
444
445 2018-06-27  Antti Koivisto  <antti@apple.com>
446
447         Don't invoke post resolution callbacks when resolving computed style
448         https://bugs.webkit.org/show_bug.cgi?id=187113
449         <rdar://problem/41365766>
450
451         Reviewed by Geoff Garen.
452
453         Post-resolution callbacks should only be invoked when we resolve the full document style,
454         not when resolving computed style for a single element.
455
456         Tests: fast/dom/object-computed-style-event.html
457
458         * dom/Document.cpp:
459         (WebCore::Document::styleForElementIgnoringPendingStylesheets):
460         * dom/Element.cpp:
461         (WebCore::Element::resolveComputedStyle):
462
463         Also ref the ancestor stack to be safe.
464
465         * style/StyleTreeResolver.cpp:
466         (WebCore::Style::PostResolutionCallbackDisabler::PostResolutionCallbackDisabler):
467         (WebCore::Style::PostResolutionCallbackDisabler::~PostResolutionCallbackDisabler):
468
469         Add an option to not drain the callback queue on destruction. In this mode we
470         just block network loads.
471
472         * style/StyleTreeResolver.h:
473
474 2018-06-27  Timothy Hatcher  <timothy@apple.com>
475
476         Find on page selection color isn't adapted for dark mode.
477         https://bugs.webkit.org/show_bug.cgi?id=187072
478         rdar://problem/40354841
479
480         Reviewed by Tim Horton.
481
482         * page/mac/TextIndicatorWindow.mm:
483         (-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]): Use [NSColor findHighlightColor].
484         * platform/mac/LocalDefaultSystemAppearance.h:
485         (WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): Added.
486         * platform/mac/LocalDefaultSystemAppearance.mm:
487         (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Set m_usingDarkAppearance.
488         * rendering/InlineTextBox.cpp:
489         (WebCore::InlineTextBox::paintPlatformDocumentMarkers): Use TextPaintPhase::Decoration since this
490         matches step three of InlineTextBox::paint ("Paint fancy decorations"). This allows TextMatch to
491         paint a forground and not end up painting during this "fancy decorations" phase.
492         (WebCore::InlineTextBox::resolveStyleForMarkedText): Set the fillColor for TextMarker to force a
493         dark text color which will draw over the yellow highlight.
494         (WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Added support for TextPaintPhase::Decoration.
495         Seperate DocumentMarker::TelephoneNumber and DocumentMarker::TextMatch. Have DocumentMarker::TextMatch
496         support Forground and Background phases.
497         * rendering/RenderTheme.cpp:
498         (WebCore::RenderTheme::platformColorsDidChange):
499         (WebCore::RenderTheme::activeTextSearchHighlightColor const): Added. Call the platfrom version.
500         (WebCore::RenderTheme::inactiveTextSearchHighlightColor const): Added. Ditto.
501         (WebCore::RenderTheme::platformActiveTextSearchHighlightColor const): Added StyleColor::Options.
502         (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor const): Ditto.
503         * rendering/RenderTheme.h:
504         * rendering/RenderThemeMac.h:
505         * rendering/RenderThemeMac.mm:
506         (WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const): Added.
507         (WebCore::RenderThemeMac::platformInactiveTextSearchHighlightColor const): Added.
508         (WebCore::RenderThemeMac::platformColorsDidChange): Clear new color caches.
509         (WebCore::RenderThemeMac::systemColor const): Cache system colors by light and dark mode.
510
511 2018-06-27  Chris Dumez  <cdumez@apple.com>
512
513         Crash under SWServer::unregisterServiceWorkerClient()
514         https://bugs.webkit.org/show_bug.cgi?id=187115
515         <rdar://problem/41539197>
516
517         Reviewed by Youenn Fablet.
518
519         Connections are usually destroyed before their SWServer. However, as per crash traces, it is possible
520         for SWServers to get destroyed while they still have connections. When this happens, the connections
521         (which are owned by the SWServer) get destroyed with other SWServer data members. In turn, the
522         connection destructor tries to unregister its clients from the server that is currently being destroyed.
523
524         To address the issue, the SWServer destructor now destroys remaining connections early, before SWServer's
525         other data members get destroyed.
526
527         * workers/service/server/SWServer.cpp:
528         (WebCore::SWServer::~SWServer):
529
530 2018-06-27  Youenn Fablet  <youenn@apple.com>
531
532         NetworkLoadChecker should not need to hard ref NetworkConnectionToWebProcess
533         https://bugs.webkit.org/show_bug.cgi?id=186551
534
535         Reviewed by Daniel Bates.
536
537         No change of behavior.
538         Add a way to set the client receiving any CSP warning/error notification.
539
540         * page/csp/ContentSecurityPolicy.h:
541         (WebCore::ContentSecurityPolicy::setClient):
542
543 2018-06-27  Zalan Bujtas  <zalan@apple.com>
544
545         [LFC] Do not collapse margin with the parent when element has border/padding.
546         https://bugs.webkit.org/show_bug.cgi?id=187114
547
548         Reviewed by Antti Koivisto.
549
550         * layout/blockformatting/BlockFormattingContext.cpp:
551         (WebCore::Layout::BlockFormattingContext::layout const):
552         * layout/blockformatting/BlockMarginCollapse.cpp:
553         (WebCore::Layout::isMarginTopCollapsedWithParent):
554         (WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
555         (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):
556
557 2018-06-27  Simon Fraser  <simon.fraser@apple.com>
558
559         Fix Windows build after r233268.
560
561         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
562         (PlatformCALayerWin::hasContents const):
563         * platform/graphics/ca/win/PlatformCALayerWin.h:
564
565 2018-06-27  Zalan Bujtas  <zalan@apple.com>
566
567         [LFC] Out-of-flow positioned element's height depends on its containing block's height.
568         https://bugs.webkit.org/show_bug.cgi?id=187082
569
570         Reviewed by Antti Koivisto.
571
572         We can't really compute the final height of an out-of-flow element until after its containing block's height is computed.
573
574         * layout/FormattingContext.cpp:
575         (WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
576         * layout/FormattingContext.h:
577         * layout/LayoutContext.cpp:
578         (WebCore::Layout::LayoutContext::updateLayout):
579         (WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):
580         * layout/LayoutContext.h:
581         * layout/blockformatting/BlockFormattingContext.cpp:
582         (WebCore::Layout::BlockFormattingContext::layout const):
583         * layout/layouttree/LayoutContainer.h:
584         (WebCore::Layout::Container::outOfFlowDescendants const):
585         (WebCore::Layout::Container::outOfFlowDescendants): Deleted.
586
587 2018-06-27  Youenn Fablet  <youenn@apple.com>
588
589         Disable content blockers in NetworkLoadChecker except for ping loads
590         https://bugs.webkit.org/show_bug.cgi?id=187083
591         <rdar://problem/41440083>
592
593         Reviewed by Chris Dumez.
594
595         Add internals API to reload a frame without content extensions.
596
597         Test: http/tests/contentextensions/reload-without-contentextensions.html
598
599         * testing/Internals.cpp:
600         (WebCore::Internals::reloadWithoutContentExtensions):
601         * testing/Internals.h:
602         * testing/Internals.idl:
603
604 2018-06-27  Simon Fraser  <simon.fraser@apple.com>
605
606         https://hackernoon.com/ uses lots of layer backing store
607         https://bugs.webkit.org/show_bug.cgi?id=186909
608         rdar://problem/40257540
609
610         Reviewed by Tim Horton.
611         
612         The existing "backing store detached" logic, which was used to eliminate backing store
613         for compositing layers outside the viewport, had a number of bugs that allowed layers
614         to have backing store when they should not.
615         
616         Specifically, any code path that ended up in setNeedsDisplay{InRect}() in PlatformCALayer
617         could trigger backing store creation on layers that should have never had any.
618         
619         Rather than monkeypatch all the GraphicsLayerCA call sites that call setNeedsDisplay{InRect}(),
620         just bail early from the PlatformCALayer* methods that trigger repaints.
621         
622         Tests didn't catch this because they just dumped the state of the backingStoreAttached flag. To fix this,
623         create backingStoreAttachedForTesting() which also tests whether the layer has contents.
624
625         Test: compositing/backing/backing-store-attachment-outside-viewport.html
626
627         * platform/graphics/GraphicsLayer.cpp:
628         (WebCore::GraphicsLayer::dumpProperties const):
629         (showGraphicsLayerTree):
630         * platform/graphics/GraphicsLayer.h:
631         (WebCore::GraphicsLayer::backingStoreAttachedForTesting const):
632         * platform/graphics/GraphicsLayerClient.h:
633         * platform/graphics/ca/GraphicsLayerCA.cpp:
634         (WebCore::GraphicsLayerCA::backingStoreAttachedForTesting const):
635         (WebCore::GraphicsLayerCA::setNeedsDisplay):
636         * platform/graphics/ca/GraphicsLayerCA.h:
637         * platform/graphics/ca/PlatformCALayer.h:
638         * platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
639         * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
640         (PlatformCALayerCocoa::setNeedsDisplay):
641         (PlatformCALayerCocoa::setNeedsDisplayInRect):
642         (PlatformCALayerCocoa::hasContents const):
643
644 2018-06-27  David Kilzer  <ddkilzer@apple.com>
645
646         Fix clang static analyzer warnings: Branch condition evaluates to a garbage value
647         <https://webkit.org/b/186968>
648
649         Reviewed by Zalan Bujtas.
650
651         This patch changes two stack-allocated `bool` variables into
652         `std::optional<bool>` since the functions that set the variable
653         may return early without setting it.  It also changes one
654         stack-allocated pointer to be initialized to `nullptr`.
655
656         * animation/AnimationTimeline.cpp:
657         (WebCore::AnimationTimeline::updateCSSTransitionsForElement):
658         Update for change to CSSPropertyAnimation::getPropertyAtIndex()
659         argument type.
660
661         * editing/ios/EditorIOS.mm:
662         (WebCore::Editor::writeImageToPasteboard): Initialize
663         `cachedImage` stack pointer to nullptr since getImage() has an
664         early return that doesn't set `cachedImage`.
665         * editing/mac/EditorMac.mm:
666         (WebCore::Editor::writeImageToPasteboard): Ditto.
667
668         * page/animation/CSSPropertyAnimation.cpp:
669         (WebCore::CSSPropertyAnimation::getPropertyAtIndex):
670         * page/animation/CSSPropertyAnimation.h:
671         (WebCore::CSSPropertyAnimation::getPropertyAtIndex):
672         - Change method to take `std::optional<bool>` instead of `bool`
673           as second argument since the method may return early without
674           setting `isShorthand`.
675
676         * page/animation/CompositeAnimation.cpp:
677         (WebCore::CompositeAnimation::updateTransitions): Update for
678         change to CSSPropertyAnimation::getPropertyAtIndex() argument
679         type.
680
681         * rendering/InlineFlowBox.cpp:
682         (WebCore::InlineFlowBox::placeBoxesInBlockDirection): Also
683         rename local `emphasisMarkIsOver` to `emphasisMarkIsAbove` to
684         match other call sites.
685         (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
686         (WebCore::InlineFlowBox::computeOverAnnotationAdjustment const):
687         (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment const):
688         - Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove()
689           argument type.
690         * rendering/InlineTextBox.cpp:
691         (WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
692         - Change method to take `std::optional<bool>` instead of `bool`
693           as second argument since the method may return early without
694           setting `above`.
695         (WebCore::InlineTextBox::paintMarkedTextForeground):
696         - Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove()
697           argument type.
698         * rendering/InlineTextBox.h:
699         (WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
700         - Change method to take `std::optional<bool>` instead of `bool`.
701
702 2018-06-27  Zalan Bujtas  <zalan@apple.com>
703
704         [LFC] Move formatting context root layout logic to a dedicated function.
705         https://bugs.webkit.org/show_bug.cgi?id=187097
706
707         Reviewed by Antti Koivisto.
708
709         * layout/blockformatting/BlockFormattingContext.cpp:
710         (WebCore::Layout::BlockFormattingContext::layout const):
711         (WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
712         * layout/blockformatting/BlockFormattingContext.h:
713
714 2018-06-27  Zalan Bujtas  <zalan@apple.com>
715
716         [LFC] Compute static position for out-of-flow elements only when required.
717         https://bugs.webkit.org/show_bug.cgi?id=187096
718
719         Reviewed by Antti Koivisto.
720
721         Computing static position for out-of-flow elements could be somewhat expensive, so let's not do it unless we actually need it.
722
723         * layout/FormattingContextGeometry.cpp:
724         (WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
725         (WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
726         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
727         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
728         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
729         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
730         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
731         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
732         (WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned): Deleted.
733
734 2018-06-27  Nan Wang  <n_wang@apple.com>
735
736         AX: [iOS] Remove the ability to set keyboard focus when VoiceOver takes focus
737         https://bugs.webkit.org/show_bug.cgi?id=187076
738
739         Reviewed by Chris Fleizach.
740
741         We shouldn't set keyboard focus when assistive technology takes focus since
742         this is causing website incompatibility issues by causing focus to be lost.
743
744         Test: accessibility/ios-simulator/accessibility-focus-do-not-set-focus.html
745
746         * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
747         (-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
748
749 2018-06-21  Emilio Cobos Álvarez  <emilio@crisal.io>
750
751         Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
752         https://bugs.webkit.org/show_bug.cgi?id=186881
753
754         Reviewed by Antti Koivisto.
755
756         Every caller does this already.
757
758         No new tests, no change in behavior.
759
760         * style/StyleTreeResolver.cpp:
761         (WebCore::Style::resetStyleForNonRenderedDescendants):
762         (WebCore::Style::TreeResolver::resolveComposedTree):
763
764 2018-06-27  Tomas Popela  <tpopela@redhat.com>
765
766         [GStreamer] Coverity scan issues
767         https://bugs.webkit.org/show_bug.cgi?id=187087
768
769         Reviewed by Xabier Rodriguez-Calvar.
770
771         Fix uninitialized members.
772
773         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
774         * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
775         * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
776
777 2018-06-27  Zan Dobersek  <zdobersek@igalia.com>
778
779         [GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
780         https://bugs.webkit.org/show_bug.cgi?id=187033
781
782         Reviewed by Michael Catanzaro.
783
784         Move the GCryptUtilities helpers that operate on libgcrypt values and
785         constants into a separate source file. This limits a bit the amount of
786         inlining the compiler might feel compelled to do, and the resulting
787         shared library is 8kB smaller in size.
788
789         * crypto/gcrypt/GCryptUtilities.cpp: Copied from Source/WebCore/crypto/gcrypt/GCryptUtilities.h.
790         (WebCore::hmacAlgorithm):
791         (WebCore::digestAlgorithm):
792         (WebCore::hashCryptoDigestAlgorithm):
793         (WebCore::mpiLength):
794         (WebCore::mpiData):
795         (WebCore::mpiZeroPrefixedData):
796         (WebCore::mpiSignedData):
797         * crypto/gcrypt/GCryptUtilities.h:
798         (WebCore::hmacAlgorithm): Deleted.
799         (WebCore::digestAlgorithm): Deleted.
800         (WebCore::hashCryptoDigestAlgorithm): Deleted.
801         (WebCore::mpiLength): Deleted.
802         (WebCore::mpiData): Deleted.
803         (WebCore::mpiZeroPrefixedData): Deleted.
804         (WebCore::mpiSignedData): Deleted.
805         * platform/SourcesGCrypt.txt:
806
807 2018-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
808
809         [JSC] Pass VM& to functions more
810         https://bugs.webkit.org/show_bug.cgi?id=186241
811
812         Reviewed by Mark Lam.
813
814         * bindings/js/JSCustomElementRegistryCustom.cpp:
815         (WebCore::JSCustomElementRegistry::define):
816
817 2018-06-26  Simon Fraser  <simon.fraser@apple.com>
818
819         CSSGradientValue's color stops vector wastes 12KB on theverge.com
820         https://bugs.webkit.org/show_bug.cgi?id=186988
821
822         Reviewed by Sam Weinig.
823
824         Shrink the color stops vector when we're done parsing the stops.
825
826         * css/CSSGradientValue.h:
827         (WebCore::CSSGradientValue::doneAddingStops):
828         * css/parser/CSSPropertyParserHelpers.cpp:
829         (WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
830         (WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
831         (WebCore::CSSPropertyParserHelpers::consumeAngularGradientColorStops):
832
833 2018-06-25  Yusuke Suzuki  <utatane.tea@gmail.com>
834
835         Remove static initializers more
836         https://bugs.webkit.org/show_bug.cgi?id=186969
837
838         Reviewed by Michael Catanzaro.
839
840         This patch removes static initializers more. They typically exists in GTK port.
841
842         No behavior change.
843
844         * Sources.txt:
845         * WebCore.xcodeproj/project.pbxproj:
846         * page/ResourceUsageData.cpp: Removed.
847         * page/ResourceUsageData.h:
848         Remove ResourceUsageData constructors since default constructors are enough.
849
850         (WebCore::MemoryCategoryInfo::MemoryCategoryInfo):
851         * platform/gtk/PasteboardHelper.cpp:
852         (WebCore::markupPrefix):
853         (WebCore::removeMarkupPrefix):
854         (WebCore::PasteboardHelper::fillSelectionData):
855         Use NeverDestroyed<> and static functions.
856
857         * platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:
858         (WebCore::defaultVolumeCapability):
859         (WebCore::GStreamerAudioCaptureSource::capabilities const):
860         CapabilityValueOrRange's constructor is not constexpr.
861
862         * platform/network/soup/SoupNetworkSession.cpp:
863         (WebCore::initialAcceptLanguages):
864         (WebCore::proxySettings):
865         (WebCore::SoupNetworkSession::SoupNetworkSession):
866         (WebCore::SoupNetworkSession::setupProxy):
867         (WebCore::SoupNetworkSession::setProxySettings):
868         (WebCore::SoupNetworkSession::setInitialAcceptLanguages):
869         Use NeverDestroyed<> and static functions.
870
871 2018-06-26  Daniel Bates  <dabates@apple.com>
872
873         REGRESSION (r231479): Unable to buy Odeon cinema tickets in STP (bogus 'X-Frame-Options' to 'SAMEORIGIN')
874         https://bugs.webkit.org/show_bug.cgi?id=186090
875         <rdar://problem/40692595>
876
877         Reviewed by Andy Estes.
878
879         Fix up Content Security Policy logic for checking the frame ancestors now that we
880         exclude the frame that initiated the load request.
881
882         Test: http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow.html
883
884         * page/csp/ContentSecurityPolicy.cpp:
885         (WebCore::ContentSecurityPolicy::allowFrameAncestors const): 
886         * page/csp/ContentSecurityPolicyDirectiveList.cpp:
887         (WebCore::checkFrameAncestors):
888
889 2018-06-26  Chris Dumez  <cdumez@apple.com>
890
891         Simplify NetworkStorageSession::getAllStorageAccessEntries()
892         https://bugs.webkit.org/show_bug.cgi?id=187016
893
894         Reviewed by Youenn Fablet.
895
896         Iterate over the HashMaps' values instead of iterating over their keys and then looking them
897         up in the HashMap.
898
899         * platform/network/cf/NetworkStorageSessionCFNet.cpp:
900         (WebCore::NetworkStorageSession::getAllStorageAccessEntries const):
901
902 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
903
904         [Mac] AirPlay picker uses incorrect theme in Dark mode
905         https://bugs.webkit.org/show_bug.cgi?id=187054
906         <rdar://problem/41291093>
907
908         Reviewed by Timothy Hatcher.
909
910         * Modules/mediasession/WebMediaSessionManager.cpp:
911         (WebCore::WebMediaSessionManager::showPlaybackTargetPicker): Add useDefaultAppearance parameter.
912         * Modules/mediasession/WebMediaSessionManager.h:
913
914         * platform/graphics/MediaPlaybackTargetPicker.cpp:
915         (WebCore::MediaPlaybackTargetPicker::showPlaybackTargetPicker): Ditto.
916         * platform/graphics/MediaPlaybackTargetPicker.h:
917
918         * platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
919         * platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
920         (WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker): Choose theme based on
921         useDefaultAppearance parameter.
922
923         * platform/mock/MediaPlaybackTargetPickerMock.cpp:
924         (WebCore::MediaPlaybackTargetPickerMock::showPlaybackTargetPicker): Log parameter.
925         * platform/mock/MediaPlaybackTargetPickerMock.h:
926
927 2018-06-26  Thibault Saunier  <tsaunier@igalia.com>
928
929         [GStreamer] Do not forget to set stream on track switching
930         https://bugs.webkit.org/show_bug.cgi?id=187049
931
932         Reviewed by Philippe Normand.
933
934         This was an overlooked issue introduced in Bug #186678
935
936         This is already tested, but we currently run only tests against playbin2
937
938         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
939         (WebCore::MediaPlayerPrivateGStreamer::enableTrack):
940
941 2018-06-26  Zalan Bujtas  <zalan@apple.com>
942
943         [LFC] Fixed positioning is a subcategory of absolute positioning.
944         https://bugs.webkit.org/show_bug.cgi?id=187043
945
946         Reviewed by Antti Koivisto.
947
948         https://www.w3.org/TR/CSS22/visuren.html#absolute-positioning
949         References in this specification to an absolutely positioned element (or its box) imply that the element's 'position'
950         property has the value 'absolute' or 'fixed'.
951
952         * layout/layouttree/LayoutBox.cpp:
953         (WebCore::Layout::Box::isAbsolutelyPositioned const):
954         * layout/layouttree/LayoutBox.h:
955         (WebCore::Layout::Box::isOutOfFlowPositioned const):
956
957 2018-06-26  Commit Queue  <commit-queue@webkit.org>
958
959         Unreviewed, rolling out r233143.
960         https://bugs.webkit.org/show_bug.cgi?id=187046
961
962         broke media/video-ended-event-negative-playback.html
963         (Requested by philn on #webkit).
964
965         Reverted changeset:
966
967         "[GStreamer] Remove useless workaround"
968         https://bugs.webkit.org/show_bug.cgi?id=186921
969         https://trac.webkit.org/changeset/233143
970
971 2018-06-25  Zalan Bujtas  <zalan@apple.com>
972
973         [LFC] Computed height for in-flow non-replaced should not include padding and border.
974         https://bugs.webkit.org/show_bug.cgi?id=187031
975
976         Reviewed by Antti Koivisto.
977
978         In certain cases the height of a non-replaced in-flow box is computed using the bottom position of its last in-flow child.
979         The in-flow child's bottom position is in the coordinate system of the containing block's border box (border box's top left is 0, 0) ->
980         it includes both the (top) border and the padding of the containing block.
981
982         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
983         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
984
985 2018-06-26  Zan Dobersek  <zdobersek@igalia.com>
986
987         Crash in WebAnimation::runPendingPlayTask
988         https://bugs.webkit.org/show_bug.cgi?id=186189
989
990         Reviewed by Carlos Garcia Campos.
991
992         Avoid crashes on nullopt std::optional dereference in the
993         runPendingPlayTask() and runPendingPauseTask() methods of the
994         WebAnimation class by defaulting to a Seconds(0) value.
995
996         In both cases the std::optional value is the current time retrieved from
997         the associated DocumentTimeline object. But there's no guarantee that
998         the timeline is active and the resulting time value is resolved (i.e.
999         not nullopt). Dereferencing the nullopt Seconds value doesn't cause a
1000         problem on configurations still building as C++14 and the fallback
1001         std::optional implementation provided by WTF -- no signal is raised, and
1002         a 0 value is returned. Configurations building as C++17 on the other
1003         hand use the stdlib-provided std::optional that does raise a signal on
1004         invalid access, leading to crashes.
1005
1006         The default-to-Seconds(0) solution avoids crashes on configurations
1007         that build with C++17 support enabled, and thus match configurations
1008         that are still using WTF's std::optional. This still doesn't address the
1009         underlying problem of retrieving current time from an inactive document
1010         timeline and using it as ready time for the pending play/pause task
1011         execution.
1012
1013         runPendingPlayTask() change addresses crashes in the following tests:
1014         - fast/animation/css-animation-resuming-when-visible.html
1015         - fast/animation/css-animation-resuming-when-visible-with-style-change.html
1016         - imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html
1017         - imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/getAnimations.html
1018
1019         runPendingPauseTask() change addresses crashes in the following tests:
1020         - animations/multiple-animations-timing-function.html
1021
1022         * animation/WebAnimation.cpp:
1023         (WebCore::WebAnimation::runPendingPlayTask):
1024         (WebCore::WebAnimation::runPendingPauseTask):
1025
1026 2018-06-26  Antoine Quint  <graouts@apple.com>
1027
1028         [Web Animations] Show the feature as "Supported in Preview"
1029         https://bugs.webkit.org/show_bug.cgi?id=187037
1030
1031         Reviewed by Dean Jackson.
1032
1033         Web Animations are enabled by default in STP.
1034
1035         * features.json:
1036
1037 2018-06-26  Miguel Gomez  <magomez@igalia.com>
1038
1039         [GTK] Many webpages can crash the browser in WebCore::CoordinatedGraphicsLayer::transformedVisibleRect
1040         https://bugs.webkit.org/show_bug.cgi?id=179304
1041
1042         Reviewed by Michael Catanzaro.
1043
1044         When adding new CoordinatedGraphicsLayers to the tree, check that they have the appropriate
1045         CompositingCoordinator. If that's not the case, set the appropriate one to the layer and its
1046         children and set the state of those layers so they are rendered properly.
1047
1048         * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
1049         (WebCore::CoordinatedGraphicsLayer::addChild):
1050         (WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
1051         (WebCore::CoordinatedGraphicsLayer::addChildAbove):
1052         (WebCore::CoordinatedGraphicsLayer::addChildBelow):
1053         (WebCore::CoordinatedGraphicsLayer::replaceChild):
1054         (WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded):
1055         * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
1056
1057 2018-06-25  Keith Rollin  <krollin@apple.com>
1058
1059         Adjust WEBCORE_EXPORT annotations for LTO
1060         https://bugs.webkit.org/show_bug.cgi?id=186944
1061         <rdar://problem/41384880>
1062
1063         Reviewed by David Kilzer.
1064
1065         Adjust a number of places that result in WebKit's
1066         'check-for-weak-vtables-and-externals' script reporting weak external
1067         symbols:
1068
1069             ERROR: WebCore has a weak external symbol in it (/Volumes/Data/dev/webkit/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore)
1070             ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
1071             ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
1072             ...
1073
1074         These cases are caused by inline methods being marked with WTF_EXPORT
1075         (or related macro) or with an inline function being in a class marked
1076         as such, and when enabling LTO builds.
1077
1078         For the most part, address these by removing the WEBCORE_EXPORT
1079         annotation from inline methods. In some cases, move the implementation
1080         out-of-line because it's the class that has the WEBCORE_EXPORT on it
1081         and removing the annotation from the class would be too disruptive.
1082         Finally, in other cases, move the implementation out-of-line because
1083         check-for-weak-vtables-and-externals still complains when keeping the
1084         implementation inline and removing the annotation; this seems to
1085         typically (but not always) happen with destructors.
1086
1087         No new tests. There is no changed functionality. Only the annotation
1088         and treatment of inline methods are altered.
1089
1090         * animation/AnimationTimeline.h:
1091         (WebCore::AnimationTimeline::pause):
1092         * page/CacheStorageProvider.h:
1093         (): Deleted.
1094         * page/scrolling/ScrollingTree.h:
1095         (WebCore::ScrollingTree::reportSynchronousScrollingReasonsChanged):
1096         (WebCore::ScrollingTree::reportExposedUnfilledArea):
1097         * platform/audio/PlatformMediaSessionManager.h:
1098         (WebCore::PlatformMediaSessionManager::hasActiveNowPlayingSession const):
1099         (WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingTitle const):
1100         (WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingDuration const):
1101         (WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingElapsedTime const):
1102         (WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingInfoUniqueIdentifier const):
1103         (WebCore::PlatformMediaSessionManager::registeredAsNowPlayingApplication const):
1104         * platform/audio/mac/CARingBuffer.cpp:
1105         (WebCore::CARingBuffer::~CARingBuffer):
1106         * platform/audio/mac/CARingBuffer.h:
1107         (WebCore::CARingBuffer::~CARingBuffer): Deleted.
1108         * platform/cocoa/VideoFullscreenModelVideoElement.h:
1109         * platform/gamepad/GamepadProvider.h:
1110         * platform/graphics/GraphicsLayer.h:
1111         (WebCore::GraphicsLayer::displayListAsText const):
1112         (WebCore::GraphicsLayer::setIsTrackingDisplayListReplay):
1113         (WebCore::GraphicsLayer::isTrackingDisplayListReplay const):
1114         (WebCore::GraphicsLayer::replayDisplayListAsText const):
1115         * platform/mac/PlaybackSessionInterfaceMac.h:
1116         * platform/mediastream/RealtimeMediaSourceCenter.h:
1117         (WebCore::RealtimeMediaSourceCenter::setAudioFactory):
1118         (WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):
1119         * platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
1120         (WebCore::LibWebRTCProvider::setActive):
1121         (WebCore::LibWebRTCProvider::createDecoderFactory):
1122         (WebCore::LibWebRTCProvider::createEncoderFactory):
1123         (WebCore::LibWebRTCProvider::disableEnumeratingAllNetworkInterfaces):
1124         (WebCore::LibWebRTCProvider::enableEnumeratingAllNetworkInterfaces):
1125         * platform/mediastream/libwebrtc/LibWebRTCProvider.h:
1126         * platform/network/ResourceHandleClient.h:
1127         (WebCore::ResourceHandleClient::willCacheResponseAsync):
1128         * testing/MockGamepadProvider.h:
1129         * workers/service/server/SWServer.h:
1130         (WebCore::SWServer::Connection::~Connection):
1131
1132 2018-06-25  Zalan Bujtas  <zalan@apple.com>
1133
1134         [LFC] Adjust static position for out-of-flow positioned boxes.
1135         https://bugs.webkit.org/show_bug.cgi?id=187000
1136
1137         Reviewed by Antti Koivisto.
1138
1139         The static position of an out-of-flow positioned box is the the position where box would go
1140         if it was in-flow positioned. This position needs to the resolved in the containing block's coordinate system.
1141
1142         * layout/blockformatting/BlockFormattingContext.h:
1143         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
1144         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
1145         (WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned):
1146         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
1147
1148 2018-06-25  Brady Eidson  <beidson@apple.com>
1149
1150         Remove RELEASE_ASSERT added in r230875.
1151         <rdar://problem/40860061> and https://bugs.webkit.org/show_bug.cgi?id=187022
1152
1153         Reviewed by Brent Fulgham.
1154
1155         There's actually more than one way for a network session to be destroyed, and that can happen
1156         asynchronously and unpredictably.
1157
1158         And the request to start up a WebSocket and do its handshake is also asynchronous and unpredictable
1159  
1160         It's an expected race.
1161
1162         If the NetworkStorageSession cannot be found then the WebSocket handshake should just fail.
1163
1164         * platform/network/SocketStreamHandleImpl.cpp:
1165         (WebCore::cookieDataForHandshake): If the NetworkStorageSession cannot be found, return std::nullopt.
1166         (WebCore::SocketStreamHandleImpl::platformSendHandshake): If the cookieData is null, fail the handshake.
1167
1168 2018-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1169
1170         [iPad apps on macOS] Web process crashes when attempting to play embedded YouTube video in News
1171         https://bugs.webkit.org/show_bug.cgi?id=187011
1172         <rdar://problem/40906808>
1173
1174         Reviewed by Tim Horton.
1175
1176         Disable remote media commands when running iOS WebKit on macOS. The iOS flavor of RemoteCommandListener
1177         currently throws an exception when attempting to soft-link the MediaPlayer framework, which prevents video from
1178         being played altogether. For a followup tracking touch bar integration in iOS WebKit on macOS, see:
1179         <rdar://problem/39164732>.
1180
1181         Manually tested by playing a YouTube video in News.
1182
1183         * platform/RemoteCommandListener.cpp:
1184         * platform/ios/RemoteCommandListenerIOS.h:
1185         * platform/ios/RemoteCommandListenerIOS.mm:
1186
1187 2018-06-25  Keith Rollin  <krollin@apple.com>
1188         Unreviewed, rolling out r233087.
1189
1190         Causes 5% Mac PLT regression.
1191
1192         Reverted changeset:
1193
1194         "Recalc styles every time defaultAppearance changes."
1195         https://bugs.webkit.org/show_bug.cgi?id=186866
1196         https://trac.webkit.org/changeset/233087
1197
1198 2018-06-25  Brent Fulgham  <bfulgham@apple.com>
1199
1200         REGRESSION(r229722): WebKitLegacy clients can crash when loading alternate page
1201         https://bugs.webkit.org/show_bug.cgi?id=187008
1202         
1203         Reviewed by Chris Dumez.
1204
1205         The new call to 'clearProvisionalLoadForPolicyCheck' added in r229722 broke loading
1206         behavior in WebKitLegacy.
1207
1208         1. We can now enter 'cancelPolicyCheckIfNeeded' without a Frame loader, in what appears
1209            to be a recursive call during the load cancellation (the 'm_waitingForContentPolicy'
1210            and 'm_waitingForNavigationPolicy' have already been nulled). It seems like we should
1211            return early here, or perhaps just move the RELEASE_ASSERT inside the case where we
1212            have an active policy check happening.
1213
1214         2. We also enter FrameLoader::checkContentPolicy without an active document loader. We
1215            should recognize this case and handle it, rather than trying to dereference a nullptr
1216            document loader.
1217
1218         * loader/DocumentLoader.cpp:
1219         (WebCore::DocumentLoader::cancelPolicyCheckIfNeeded): Move the RELEASE_ASSERT inside the
1220         conditional where the frameLoader is actually used.
1221         * loader/FrameLoader.cpp:
1222         (WebCore::FrameLoader::checkContentPolicy): Recognize that the activeDocumentLoader may
1223         be nullptr at this point, and take appropriate action (rather than crashing).
1224
1225 2018-06-25  Simon Fraser  <simon.fraser@apple.com>
1226
1227         MatchedPropertiesCacheItem wastes 388KB of vector capacity on nytimes.com
1228         https://bugs.webkit.org/show_bug.cgi?id=186990
1229
1230         Reviewed by Antti Koivisto.
1231
1232         MatchedPropertiesCacheItem.matchedProperties was appended to, so it allocated capacity
1233         in 16-size chunks. Instead, assign to it so it only allocates as much capacity as is needed.
1234         Copy-constructing is more wasteful, since it copies the 64-chunk size from the right-hand side.
1235
1236         * css/StyleResolver.cpp:
1237         (WebCore::StyleResolver::addToMatchedPropertiesCache):
1238         * css/StyleResolver.h:
1239         (WebCore::StyleResolver::MatchedPropertiesCacheItem::MatchedPropertiesCacheItem):
1240
1241 2018-06-25  Chris Dumez  <cdumez@apple.com>
1242
1243         Null dereference crash un ApplicationCacheGroup::startLoadingEntry()
1244         https://bugs.webkit.org/show_bug.cgi?id=187012
1245         <rdar://problem/40793716>
1246
1247         Reviewed by Youenn Fablet.
1248
1249         m_entryLoader can be null because ApplicationCacheResourceLoader::create() return null when
1250         CachedResourceLoader::requestRawResource() fails synchronously. In such case, the completion
1251         handler gets called with a ApplicationCacheResourceLoader::Error::CannotRequestResource error.
1252
1253         To address the issue, we capture the request's URL in the lambda and use it instead of trying
1254         to get the URL from the loader's resource.
1255
1256         * loader/appcache/ApplicationCacheGroup.cpp:
1257         (WebCore::ApplicationCacheGroup::startLoadingEntry):
1258
1259 2018-06-25  Ross Kirsling  <ross.kirsling@sony.com>
1260
1261         REGRESSION (r233140): Windows build failure due to incomplete FrameView and RenderBox types
1262         https://bugs.webkit.org/show_bug.cgi?id=186997
1263
1264         * animation/KeyframeEffectReadOnly.cpp:
1265
1266 2018-06-25  Antoine Quint  <graouts@apple.com>
1267
1268         REGRESSION: hardware-accelerated animation fails on inline element
1269         https://bugs.webkit.org/show_bug.cgi?id=186981
1270         <rdar://problem/41418697>
1271
1272         Reviewed by Dean Jackson.
1273
1274         Ensure we only queue accelerated actions when we have a renderer so we don't attempt
1275         to start an accelerated animation too soon.
1276
1277         Test: webanimations/opacity-animation-yields-compositing-span.html
1278
1279         * animation/KeyframeEffectReadOnly.cpp:
1280         (WebCore::KeyframeEffectReadOnly::updateAcceleratedAnimationState):
1281
1282 2018-06-25  David Kilzer  <ddkilzer@apple.com>
1283
1284         REGRESSION (r233140): v2: Windows build failure due to incomplete DocumentAnimationScheduler type
1285         <https://webkit.org/b/186997>
1286
1287         * dom/Document.cpp:
1288         (WebCore::Document::prepareForDestruction):
1289         (WebCore::Document::windowScreenDidChange):
1290         * dom/Document.h:
1291         - DocumentAnimationScheduler is behind the
1292           USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) macro, which
1293           is disabled on Windows.
1294         - This also reverts my fix in r233144 since it didn't work.
1295
1296 2018-06-25  Youenn Fablet  <youenn@apple.com>
1297
1298         Add API to control mock media devices
1299         https://bugs.webkit.org/show_bug.cgi?id=186958
1300
1301         Reviewed by Eric Carlson.
1302
1303         Refactor code to introduce a MockDevice structure that can be used in multiple processes.
1304         Update mock sources and center to use MockDevice.
1305         Add API to update mock media devices.
1306
1307         Make MediaDevices an ActiveDOMObject so that it does not get collected when ondevicechange is set.
1308
1309          Test: fast/mediastream/device-change-event-2.html
1310
1311         * Modules/mediastream/MediaDevices.cpp:
1312         (WebCore::MediaDevices::MediaDevices):
1313         (WebCore::MediaDevices::stop):
1314         (WebCore::MediaDevices::scheduledEventTimerFired):
1315         (WebCore::MediaDevices::hasPendingActivity const):
1316         (WebCore::MediaDevices::activeDOMObjectName const):
1317         (WebCore::MediaDevices::canSuspendForDocumentSuspension const):
1318         * Modules/mediastream/MediaDevices.h:
1319         * Modules/mediastream/MediaDevices.idl:
1320         * WebCore.xcodeproj/project.pbxproj:
1321         * platform/mediastream/RealtimeMediaSourceCenter.h:
1322         * platform/mock/MockMediaDevice.h: Added.
1323         (WebCore::MockMicrophoneProperties::encode const):
1324         (WebCore::MockMicrophoneProperties::decode):
1325         (WebCore::MockCameraProperties::encode const):
1326         (WebCore::MockCameraProperties::decode):
1327         (WebCore::MockDisplayProperties::encode const):
1328         (WebCore::MockDisplayProperties::decode):
1329         (WebCore::MockMediaDevice::isMicrophone const):
1330         (WebCore::MockMediaDevice::isCamera const):
1331         (WebCore::MockMediaDevice::isDisplay const):
1332         (WebCore::MockMediaDevice::type const):
1333         (WebCore::MockMediaDevice::encode const):
1334         (WebCore::MockMediaDevice::decodeMockMediaDevice):
1335         (WebCore::MockMediaDevice::decode):
1336         * platform/mock/MockRealtimeAudioSource.cpp:
1337         (WebCore::MockRealtimeAudioSource::startProducingData):
1338         * platform/mock/MockRealtimeMediaSource.cpp:
1339         (WebCore::defaultDevices):
1340         (WebCore::devices):
1341         (WebCore::deviceMap):
1342         (WebCore::deviceListForDevice):
1343         (WebCore::MockRealtimeMediaSource::createCaptureDevice):
1344         (WebCore::MockRealtimeMediaSource::resetDevices):
1345         (WebCore::MockRealtimeMediaSource::setDevices):
1346         (WebCore::MockRealtimeMediaSource::addDevice):
1347         (WebCore::MockRealtimeMediaSource::removeDevice):
1348         (WebCore::MockRealtimeMediaSource::captureDeviceWithPersistentID):
1349         (WebCore::MockRealtimeMediaSource::audioDevices):
1350         (WebCore::MockRealtimeMediaSource::videoDevices):
1351         (WebCore::MockRealtimeMediaSource::displayDevices):
1352         (WebCore::MockRealtimeMediaSource::MockRealtimeMediaSource):
1353         (WebCore::MockRealtimeMediaSource::initializeCapabilities):
1354         (WebCore::MockRealtimeMediaSource::initializeSettings):
1355         (WebCore::MockRealtimeMediaSource::settings const):
1356         (WebCore::MockRealtimeMediaSource::supportedConstraints):
1357         * platform/mock/MockRealtimeMediaSource.h:
1358         (WebCore::MockRealtimeMediaSource::device const):
1359         * platform/mock/MockRealtimeMediaSourceCenter.cpp:
1360         (WebCore::MockRealtimeMediaSourceCenter::singleton):
1361         (WebCore::MockRealtimeMediaSourceCenter::setMockRealtimeMediaSourceCenterEnabled):
1362         (WebCore::MockRealtimeMediaSourceCenter::setDevices):
1363         (WebCore::MockRealtimeMediaSourceCenter::addDevice):
1364         (WebCore::MockRealtimeMediaSourceCenter::removeDevice):
1365         * platform/mock/MockRealtimeMediaSourceCenter.h:
1366         * platform/mock/MockRealtimeVideoSource.cpp:
1367         (WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
1368         (WebCore::MockRealtimeVideoSource::initializeCapabilities):
1369         (WebCore::MockRealtimeVideoSource::drawText):
1370         (WebCore::MockRealtimeVideoSource::generateFrame):
1371         * platform/mock/MockRealtimeVideoSource.h:
1372         (WebCore::MockRealtimeVideoSource::mockCamera const):
1373         (WebCore::MockRealtimeVideoSource::mockScreen const):
1374
1375 2018-06-25  Simon Fraser  <simon.fraser@apple.com>
1376
1377         AutoTableLayout wastes 52KB of Vector capacity on nytimes.com
1378         https://bugs.webkit.org/show_bug.cgi?id=186710
1379
1380         Reviewed by Zalan Bujtas.
1381         
1382         Call resizeToFit() to only allocate enough capacity for the number of columns.
1383
1384         * rendering/AutoTableLayout.cpp:
1385         (WebCore::AutoTableLayout::fullRecalc):
1386         (WebCore::AutoTableLayout::insertSpanCell): Whitespace fix.
1387         * rendering/AutoTableLayout.h:
1388
1389 2018-06-25  Zalan Bujtas  <zalan@apple.com>
1390
1391         [LFC] Adjust static position with containing block's content box top/left
1392         https://bugs.webkit.org/show_bug.cgi?id=186999
1393
1394         Reviewed by Antti Koivisto.
1395
1396         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
1397         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
1398         * layout/displaytree/DisplayBox.cpp:
1399         (WebCore::Display::Box::contentBox const):
1400         * layout/displaytree/DisplayBox.h:
1401         (WebCore::Display::Box::contentBoxTop const):
1402         (WebCore::Display::Box::contentBoxLeft const):
1403
1404 2018-06-25  David Kilzer  <ddkilzer@apple.com>
1405
1406         REGRESSION (r233140): Windows build failure due to incomplete DocumentAnimationScheduler type
1407         <https://webkit.org/b/186997>
1408
1409         * dom/Document.cpp:
1410         * dom/Document.h:
1411         - Attempt to fix Windows build failure by moving include of
1412           DocumentAnimationScheduler.h from Document.cpp to Document.h.
1413
1414 2018-06-25  Philippe Normand  <pnormand@igalia.com>
1415
1416         [GStreamer] Remove useless workaround
1417         https://bugs.webkit.org/show_bug.cgi?id=186921
1418
1419         Reviewed by Xabier Rodriguez-Calvar.
1420
1421         In bug 67407 a workaround was added for GStreamer 0.10. With 1.x
1422         the media/video-reverse-play-duration.html test passes without any
1423         workaround needed. The other test mentioned in that bug was
1424         removed, it seems.
1425
1426         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1427         (WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):
1428
1429 2018-06-24  Tomas Popela  <tpopela@redhat.com>
1430
1431         Unreviewed, address Darin's comment
1432         https://bugs.webkit.org/show_bug.cgi?id=186757
1433
1434         * page/linux/ResourceUsageThreadLinux.cpp:
1435         (WebCore::cpuPeriod):
1436
1437 2018-06-25  Antoine Quint  <graouts@apple.com>
1438
1439         [Web Animations] Make imported/mozilla/css-animations/test_animation-pausing.html pass reliably
1440         https://bugs.webkit.org/show_bug.cgi?id=183826
1441         <rdar://problem/40997412>
1442
1443         Reviewed by Dean Jackson.
1444
1445         The CSS Animations Level 2 specification defines that calling pause() on a CSSAnimation object is "sticky"
1446         until a call to play() is made, meaning that any changes to the running state via the CSS animation-play-state
1447         property is overridden by the stickiness of the pause() call. In this patch we add an m_stickyPaused flag which
1448         is set in API calls to pause() and play(). While this flag is true, changes to the animation-play-state property
1449         to the "running" value are ignored.
1450
1451         * animation/CSSAnimation.cpp:
1452         (WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
1453         (WebCore::CSSAnimation::bindingsPlay):
1454         (WebCore::CSSAnimation::bindingsPause):
1455         * animation/CSSAnimation.h:
1456
1457 2018-06-25  Antoine Quint  <graouts@apple.com>
1458
1459         [Web Animations] Ensure animations are updated prior to requestAnimationFrame callbacks
1460         https://bugs.webkit.org/show_bug.cgi?id=186997
1461         <rdar://problem/41419414>
1462
1463         Reviewed by Dean Jackson.
1464
1465         Some sub-tests of imported/mozilla/css-animations/test_animation-pausing.html clearly expect that animations
1466         would be resolved prior to firing a requestAnimationFrame() callback, as the HTML5 event loop mandates. But until
1467         now, both DocumentTimeline and ScriptedAnimationController would make calls to DisplayRefreshMonitorManager::scheduleAnimation()
1468         that were not coordinated and so the order in which the DocumentTimeline and ScriptedAnimationController callbacks
1469         were performed was not guaranteed.
1470
1471         In this patch we add a new DocumentAnimationScheduler class which is created by a Document to manage this specific
1472         situation. Now DocumentTimeline and ScriptedAnimationController use this supporting object instead of being their
1473         own DisplayRefreshMonitorClient and call scheduleWebAnimationsResolution() and scheduleScriptedAnimationResolution()
1474         respectively to indicate the need to schedule an animation through the DisplayRefreshMonitorManager to serve the specific
1475         needs of either, or both, classes. Then DocumentAnimationScheduler ensures that Web Animations resolution happens
1476         prior to requestAnimationFrame callbacks when both are scheduled.
1477
1478         In the future we should be able to move more code from DocumentTimeline and ScriptedAnimationController over to
1479         DocumentAnimationScheduler, such as support for throttling and using a timer-based fallback, but this patch provides
1480         the minimal functionality required to provide a sounder foundation.
1481
1482         * Modules/webvr/VRDisplay.cpp:
1483         (WebCore::VRDisplay::requestAnimationFrame):
1484         * Sources.txt:
1485         * WebCore.xcodeproj/project.pbxproj:
1486         * animation/DocumentAnimationScheduler.cpp: Added.
1487         (WebCore::DocumentAnimationScheduler::create):
1488         (WebCore::DocumentAnimationScheduler::DocumentAnimationScheduler):
1489         (WebCore::DocumentAnimationScheduler::detachFromDocument):
1490         (WebCore::DocumentAnimationScheduler::scheduleWebAnimationsResolution):
1491         (WebCore::DocumentAnimationScheduler::scheduleScriptedAnimationResolution):
1492         (WebCore::DocumentAnimationScheduler::displayRefreshFired):
1493         (WebCore::DocumentAnimationScheduler::windowScreenDidChange):
1494         (WebCore::DocumentAnimationScheduler::createDisplayRefreshMonitor const):
1495         * animation/DocumentAnimationScheduler.h: Copied from Source/WebCore/animation/CSSAnimation.h.
1496         * animation/DocumentTimeline.cpp:
1497         (WebCore::DocumentTimeline::create):
1498         (WebCore::DocumentTimeline::DocumentTimeline):
1499         (WebCore::DocumentTimeline::scheduleAnimationResolution):
1500         (WebCore::DocumentTimeline::windowScreenDidChange): Deleted.
1501         (WebCore::DocumentTimeline::createDisplayRefreshMonitor const): Deleted.
1502         * animation/DocumentTimeline.h:
1503         * dom/Document.cpp:
1504         (WebCore::Document::prepareForDestruction):
1505         (WebCore::Document::windowScreenDidChange):
1506         (WebCore::Document::requestAnimationFrame):
1507         (WebCore::Document::animationScheduler):
1508         (WebCore::Document::timeline):
1509         * dom/Document.h:
1510         * dom/ScriptedAnimationController.cpp:
1511         (WebCore::ScriptedAnimationController::ScriptedAnimationController):
1512         (WebCore::ScriptedAnimationController::scheduleAnimation):
1513         (WebCore::ScriptedAnimationController::documentAnimationSchedulerDidFire):
1514         (WebCore::ScriptedAnimationController::windowScreenDidChange): Deleted.
1515         (WebCore::ScriptedAnimationController::displayRefreshFired): Deleted.
1516         (WebCore::ScriptedAnimationController::createDisplayRefreshMonitor const): Deleted.
1517         * dom/ScriptedAnimationController.h:
1518         (WebCore::ScriptedAnimationController::create):
1519
1520 2018-06-25  Zan Dobersek  <zdobersek@igalia.com>
1521
1522         [GCrypt] Zero-prefix (if necessary) output of RSA-based encryption and signing operations
1523         https://bugs.webkit.org/show_bug.cgi?id=186967
1524
1525         Reviewed by Michael Catanzaro.
1526
1527         Output for RSA-based encryption and signing operations should match the
1528         length of the RSA key. The way we retrieve the MPI data means libgcrypt
1529         can ignore the high-bit zero values and leave us with a valid result
1530         that's shorter in length compared to the RSA key. For instance, if the
1531         output MPI fits into 2040 bits while a 2048-bit key was used we'll end
1532         up with MPI data that will be fitted into a 255-byte Vector, one byte
1533         short of the expected output length.
1534
1535         To avoid this, mpiZeroPrefixedData() is now used when retrieving output
1536         of these RSA operations, and the value of the key size in bytes is
1537         passed to it. This efficiently prepares the output Vector and then
1538         copies the MPI data into it, respecting the MPI data length as well as
1539         the desired length of the output.
1540
1541         No new tests -- relevant tests are now stable (i.e. not sporadically
1542         failing anymore), associated expectations are removed.
1543
1544         * crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:
1545         (WebCore::gcryptDerive): Also use mpiZeroPrefixedData().
1546         * crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
1547         (WebCore::gcryptEncrypt):
1548         (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
1549         * crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
1550         (WebCore::gcryptSign):
1551         (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
1552         * crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
1553         (WebCore::gcryptEncrypt):
1554         (WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
1555         * crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:
1556         (WebCore::gcryptSign):
1557         (WebCore::CryptoAlgorithmRSA_PSS::platformSign):
1558         * crypto/gcrypt/GCryptUtilities.h:
1559         (WebCore::mpiZeroPrefixedData):
1560
1561 2018-06-24  Simon Fraser  <simon.fraser@apple.com>
1562
1563         Fix the DUMP_NODE_STATISTICS code so that it compiles
1564         https://bugs.webkit.org/show_bug.cgi?id=186982
1565
1566         Reviewed by Anders Carlsson.
1567
1568         The DUMP_NODE_STATISTICS code had bitrotted. ENTITY_NODE no longer exists.
1569         liveNodeSet needs to be a static function with a NeverDestroyed<>.
1570
1571         * dom/Node.cpp:
1572         (WebCore::Node::dumpStatistics):
1573         (WebCore::Node::trackForDebugging):
1574         (WebCore::Node::~Node):
1575
1576 2018-06-24  Simon Fraser  <simon.fraser@apple.com>
1577
1578         Fix the composition underline to be transformed by -apple-color-filter
1579         https://bugs.webkit.org/show_bug.cgi?id=186983
1580         rdar://problem/40515558
1581
1582         Reviewed by Zalan Bujtas.
1583         
1584         Transform the composition underline color with the color filter.
1585
1586         Test: css3/color-filters/color-filter-composition-underline-color.html
1587
1588         * rendering/InlineTextBox.cpp:
1589         (WebCore::InlineTextBox::paintCompositionUnderline const):
1590
1591 2018-06-23  Zalan Bujtas  <zalan@apple.com>
1592
1593         [Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units
1594         https://bugs.webkit.org/show_bug.cgi?id=186585
1595         <rdar://problem/30685325>
1596
1597         Reviewed by Tim Horton.
1598
1599         Use the existing "override viewport size for viewport units" mechanism to compute the preferred
1600         viewport unit values for the Mail Viewer html content. 
1601
1602         Test: fast/dynamic/mail-autosize-viewport-unit.html
1603
1604         * page/FrameView.cpp:
1605         (WebCore::FrameView::FrameView):
1606         (WebCore::FrameView::enableAutoSizeMode):
1607         (WebCore::FrameView::clearViewportSizeOverrideForCSSViewportUnits):
1608         (WebCore::FrameView::setViewportSizeForCSSViewportUnits):
1609         (WebCore::FrameView::overrideViewportSizeForCSSViewportUnits):
1610         (WebCore::FrameView::viewportSizeForCSSViewportUnits const):
1611         * page/FrameView.h:
1612
1613 2018-06-23  Zalan Bujtas  <zalan@apple.com>
1614
1615         [LFC] Relatively positioned renderer needs offsetting for validation
1616         https://bugs.webkit.org/show_bug.cgi?id=186959
1617
1618         Reviewed by Antti Koivisto.
1619
1620         * layout/FormattingContextGeometry.cpp:
1621         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
1622         * layout/Verification.cpp:
1623         (WebCore::Layout::outputMismatchingBoxInformationIfNeeded):
1624
1625 2018-06-23  Zalan Bujtas  <zalan@apple.com>
1626
1627         [LFC] Miscellaneous fixes to fix simple absolute positioning.
1628         https://bugs.webkit.org/show_bug.cgi?id=186962
1629
1630         Reviewed by Antti Koivisto.
1631
1632         1. Collect out-of-flow formatting root descendants.
1633         2. Remove invalid and redundant ASSERTs
1634           invalid because the assertion is missing border, padding etc.
1635           redundant becasue we assert on geometry correctness in validateGeometryConstraintsAfterLayout.  
1636
1637         * layout/FormattingContext.cpp:
1638         (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
1639         (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
1640         (WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
1641         * layout/layouttree/LayoutContainer.cpp:
1642         (WebCore::Layout::Container::addOutOfFlowDescendant):
1643         (WebCore::Layout::Container::setOutOfFlowDescendants): Deleted.
1644         * layout/layouttree/LayoutContainer.h:
1645         * layout/layouttree/LayoutTreeBuilder.cpp:
1646         (WebCore::Layout::TreeBuilder::createSubTree):
1647
1648 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1649
1650         [WTF] Add user-defined literal for ASCIILiteral
1651         https://bugs.webkit.org/show_bug.cgi?id=186839
1652
1653         Reviewed by Darin Adler.
1654
1655         No behavior change.
1656
1657         * Modules/applicationmanifest/ApplicationManifestParser.cpp:
1658         (WebCore::ApplicationManifestParser::parseManifest):
1659         (WebCore::ApplicationManifestParser::logManifestPropertyNotAString):
1660         (WebCore::ApplicationManifestParser::logManifestPropertyInvalidURL):
1661         (WebCore::ApplicationManifestParser::logDeveloperWarning):
1662         (WebCore::ApplicationManifestParser::parseStartURL):
1663         (WebCore::ApplicationManifestParser::parseDisplay):
1664         (WebCore::ApplicationManifestParser::parseName):
1665         (WebCore::ApplicationManifestParser::parseDescription):
1666         (WebCore::ApplicationManifestParser::parseShortName):
1667         (WebCore::ApplicationManifestParser::parseScope):
1668         * Modules/beacon/NavigatorBeacon.cpp:
1669         (WebCore::NavigatorBeacon::logError):
1670         (WebCore::NavigatorBeacon::sendBeacon):
1671         * Modules/cache/DOMCache.cpp:
1672         (WebCore::DOMCache::requestFromInfo):
1673         (WebCore::DOMCache::addAll):
1674         (WebCore::DOMCache::put):
1675         * Modules/cache/DOMCacheEngine.cpp:
1676         (WebCore::DOMCacheEngine::errorToException):
1677         * Modules/credentialmanagement/BasicCredential.cpp:
1678         (WebCore::BasicCredential::type const):
1679         * Modules/credentialmanagement/CredentialsContainer.cpp:
1680         (WebCore::CredentialsContainer::get):
1681         (WebCore::CredentialsContainer::store):
1682         (WebCore::CredentialsContainer::isCreate):
1683         (WebCore::CredentialsContainer::preventSilentAccess const):
1684         * Modules/entriesapi/DOMFileSystem.cpp:
1685         (WebCore::DOMFileSystem::root):
1686         (WebCore::validatePathIsExpectedType):
1687         (WebCore::resolveRelativeVirtualPath):
1688         (WebCore::DOMFileSystem::getEntry):
1689         * Modules/entriesapi/FileSystemDirectoryEntry.cpp:
1690         (WebCore::FileSystemDirectoryEntry::getEntry):
1691         * Modules/entriesapi/FileSystemDirectoryReader.cpp:
1692         (WebCore::FileSystemDirectoryReader::readEntries):
1693         * Modules/fetch/FetchBody.cpp:
1694         (WebCore::FetchBody::consumeAsStream):
1695         * Modules/fetch/FetchBodyConsumer.cpp:
1696         (WebCore::FetchBodyConsumer::loadingFailed):
1697         * Modules/fetch/FetchBodyOwner.cpp:
1698         (WebCore::FetchBodyOwner::arrayBuffer):
1699         (WebCore::FetchBodyOwner::blob):
1700         (WebCore::FetchBodyOwner::consumeOnceLoadingFinished):
1701         (WebCore::FetchBodyOwner::formData):
1702         (WebCore::FetchBodyOwner::json):
1703         (WebCore::FetchBodyOwner::text):
1704         (WebCore::FetchBodyOwner::blobLoadingFailed):
1705         (WebCore::FetchBodyOwner::consumeBodyAsStream):
1706         * Modules/fetch/FetchHeaders.cpp:
1707         (WebCore::canWriteHeader):
1708         * Modules/fetch/FetchLoader.cpp:
1709         (WebCore::FetchLoader::startLoadingBlobURL):
1710         (WebCore::FetchLoader::start):
1711         * Modules/fetch/FetchRequest.cpp:
1712         (WebCore::setMethod):
1713         (WebCore::computeReferrer):
1714         (WebCore::buildOptions):
1715         (WebCore::FetchRequest::initializeOptions):
1716         (WebCore::FetchRequest::initializeWith):
1717         (WebCore::FetchRequest::setBody):
1718         (WebCore::FetchRequest::referrer const):
1719         (WebCore::FetchRequest::clone):
1720         * Modules/fetch/FetchResponse.cpp:
1721         (WebCore::FetchResponse::create):
1722         (WebCore::FetchResponse::redirect):
1723         (WebCore::FetchResponse::clone):
1724         (WebCore::FetchResponse::BodyLoader::didFail):
1725         * Modules/fetch/FetchResponse.h:
1726         * Modules/geolocation/GeoNotifier.cpp:
1727         (WebCore::GeoNotifier::timerFired):
1728         * Modules/geolocation/Geolocation.cpp:
1729         (WebCore::Geolocation::startRequest):
1730         (WebCore::Geolocation::requestUsesCachedPosition):
1731         (WebCore::Geolocation::makeCachedPositionCallbacks):
1732         (WebCore::Geolocation::setIsAllowed):
1733         (WebCore::Geolocation::cancelRequests):
1734         (WebCore::Geolocation::handlePendingPermissionNotifiers):
1735         * Modules/indexeddb/IDBCursor.cpp:
1736         (WebCore::IDBCursor::update):
1737         (WebCore::IDBCursor::advance):
1738         (WebCore::IDBCursor::continuePrimaryKey):
1739         (WebCore::IDBCursor::continueFunction):
1740         (WebCore::IDBCursor::deleteFunction):
1741         * Modules/indexeddb/IDBDatabase.cpp:
1742         (WebCore::IDBDatabase::createObjectStore):
1743         (WebCore::IDBDatabase::transaction):
1744         (WebCore::IDBDatabase::deleteObjectStore):
1745         * Modules/indexeddb/IDBFactory.cpp:
1746         (WebCore::IDBFactory::open):
1747         (WebCore::IDBFactory::openInternal):
1748         (WebCore::IDBFactory::deleteDatabase):
1749         (WebCore::IDBFactory::cmp):
1750         * Modules/indexeddb/IDBIndex.cpp:
1751         (WebCore::IDBIndex::setName):
1752         (WebCore::IDBIndex::openCursor):
1753         (WebCore::IDBIndex::openKeyCursor):
1754         (WebCore::IDBIndex::count):
1755         (WebCore::IDBIndex::doCount):
1756         (WebCore::IDBIndex::get):
1757         (WebCore::IDBIndex::doGet):
1758         (WebCore::IDBIndex::getKey):
1759         (WebCore::IDBIndex::doGetKey):
1760         (WebCore::IDBIndex::getAll):
1761         (WebCore::IDBIndex::getAllKeys):
1762         * Modules/indexeddb/IDBKeyData.cpp:
1763         (WebCore::IDBKeyData::loggingString const):
1764         * Modules/indexeddb/IDBKeyRangeData.cpp:
1765         (WebCore::IDBKeyRangeData::loggingString const):
1766         * Modules/indexeddb/IDBObjectStore.cpp:
1767         (WebCore::IDBObjectStore::setName):
1768         (WebCore::IDBObjectStore::openCursor):
1769         (WebCore::IDBObjectStore::openKeyCursor):
1770         (WebCore::IDBObjectStore::get):
1771         (WebCore::IDBObjectStore::getKey):
1772         (WebCore::IDBObjectStore::putOrAdd):
1773         (WebCore::IDBObjectStore::doDelete):
1774         (WebCore::IDBObjectStore::deleteFunction):
1775         (WebCore::IDBObjectStore::clear):
1776         (WebCore::IDBObjectStore::createIndex):
1777         (WebCore::IDBObjectStore::index):
1778         (WebCore::IDBObjectStore::deleteIndex):
1779         (WebCore::IDBObjectStore::count):
1780         (WebCore::IDBObjectStore::doCount):
1781         (WebCore::IDBObjectStore::getAll):
1782         (WebCore::IDBObjectStore::getAllKeys):
1783         * Modules/indexeddb/IDBRequest.cpp:
1784         (WebCore::IDBRequest::result const):
1785         (WebCore:: const):
1786         (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
1787         * Modules/indexeddb/IDBTransaction.cpp:
1788         (WebCore::IDBTransaction::objectStore):
1789         (WebCore::IDBTransaction::abort):
1790         (WebCore::IDBTransaction::putOrAddOnServer):
1791         * Modules/indexeddb/server/IDBServer.cpp:
1792         (WebCore::IDBServer::IDBServer::performGetAllDatabaseNames):
1793         * Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
1794         (WebCore::IDBServer::MemoryIDBBackingStore::deleteRange):
1795         (WebCore::IDBServer::MemoryIDBBackingStore::addRecord):
1796         (WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
1797         (WebCore::IDBServer::MemoryIDBBackingStore::getAllRecords):
1798         (WebCore::IDBServer::MemoryIDBBackingStore::getIndexRecord):
1799         (WebCore::IDBServer::MemoryIDBBackingStore::getCount):
1800         (WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
1801         (WebCore::IDBServer::MemoryIDBBackingStore::iterateCursor):
1802         * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
1803         (WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
1804         (WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
1805         (WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromEncodedFilename):
1806         (WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
1807         (WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
1808         (WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
1809         (WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
1810         (WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
1811         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
1812         (WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
1813         (WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
1814         (WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
1815         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
1816         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
1817         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
1818         (WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
1819         (WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
1820         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteUnusedBlobFileRecords):
1821         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
1822         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
1823         (WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
1824         (WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
1825         (WebCore::IDBServer::SQLiteIDBBackingStore::getBlobRecordsForObjectStoreRecord):
1826         (WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
1827         (WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
1828         (WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
1829         (WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
1830         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
1831         (WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
1832         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
1833         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
1834         (WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
1835         (WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
1836         (WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
1837         (WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
1838         (WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
1839         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
1840         * Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
1841         (WebCore::IDBServer::SQLiteIDBTransaction::begin):
1842         (WebCore::IDBServer::SQLiteIDBTransaction::commit):
1843         (WebCore::IDBServer::SQLiteIDBTransaction::abort):
1844         * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
1845         (WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
1846         (WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
1847         (WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
1848         (WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
1849         (WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
1850         (WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
1851         (WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
1852         * Modules/indexeddb/shared/IDBError.h:
1853         (WebCore::IDBError::userDeleteError):
1854         * Modules/indexeddb/shared/IDBTransactionInfo.cpp:
1855         (WebCore::IDBTransactionInfo::loggingString const):
1856         * Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
1857         (WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):
1858         * Modules/mediastream/PeerConnectionBackend.cpp:
1859         (WebCore::PeerConnectionBackend::addIceCandidate):
1860         * Modules/mediastream/UserMediaRequest.cpp:
1861         (WebCore::UserMediaRequest::deny):
1862         * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
1863         (WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):
1864         * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
1865         (WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate):
1866         * Modules/paymentrequest/PaymentRequest.cpp:
1867         (WebCore::checkAndCanonicalizeTotal):
1868         (WebCore::PaymentRequest::create):
1869         * Modules/quota/DOMWindowQuota.cpp:
1870         (WebCore::DOMWindowQuota::webkitStorageInfo const):
1871         * Modules/webaudio/AudioBufferSourceNode.cpp:
1872         (WebCore::AudioBufferSourceNode::looping):
1873         (WebCore::AudioBufferSourceNode::setLooping):
1874         * Modules/webaudio/AudioNode.cpp:
1875         (WebCore::AudioNode::channelCountMode):
1876         (WebCore::AudioNode::channelInterpretation):
1877         * Modules/webaudio/MediaStreamAudioSource.cpp:
1878         (WebCore::MediaStreamAudioSource::MediaStreamAudioSource):
1879         * Modules/webauthn/AuthenticatorManager.cpp:
1880         (WebCore::AuthenticatorManagerInternal::produceClientDataJson):
1881         (WebCore::AuthenticatorManagerInternal::initTimeoutTimer):
1882         (WebCore::AuthenticatorManager::create const):
1883         (WebCore::AuthenticatorManager::discoverFromExternalSource const):
1884         (WebCore::AuthenticatorManager::isUserVerifyingPlatformAuthenticatorAvailable const):
1885         * Modules/webauthn/cocoa/LocalAuthenticator.mm:
1886         (WebCore::LocalAuthenticator::makeCredential):
1887         (WebCore::LocalAuthenticator::getAssertion):
1888         * Modules/webdatabase/DatabaseTracker.cpp:
1889         (WebCore::DatabaseTracker::usage):
1890         * Modules/websockets/WebSocket.cpp:
1891         (WebCore::WebSocket::connect):
1892         (WebCore::WebSocket::close):
1893         (WebCore::WebSocket::binaryType const):
1894         * Modules/websockets/WebSocketHandshake.cpp:
1895         (WebCore::WebSocketHandshake::readStatusLine):
1896         (WebCore::WebSocketHandshake::readHTTPHeaders):
1897         (WebCore::WebSocketHandshake::checkResponseHeaders):
1898         * Modules/webvr/VRDisplay.cpp:
1899         (WebCore::VRDisplay::requestPresent):
1900         (WebCore::VRDisplay::exitPresent):
1901         * accessibility/AccessibilityObject.cpp:
1902         (WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
1903         (WebCore::AccessibilityObject::invalidStatus const):
1904         * accessibility/AccessibilityRenderObject.cpp:
1905         (WebCore::AccessibilityRenderObject::textUnderElement const):
1906         * bindings/js/JSCustomElementInterface.cpp:
1907         (WebCore::constructCustomElementSynchronously):
1908         * bindings/js/JSCustomElementRegistryCustom.cpp:
1909         (WebCore::getCustomElementCallback):
1910         (WebCore::validateCustomElementNameAndThrowIfNeeded):
1911         (WebCore::JSCustomElementRegistry::define):
1912         * bindings/js/JSCustomXPathNSResolver.cpp:
1913         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
1914         * bindings/js/JSDOMConstructorBase.cpp:
1915         (WebCore::callThrowTypeError):
1916         * bindings/js/JSDOMConstructorBase.h:
1917         (WebCore::JSDOMConstructorBase::className):
1918         * bindings/js/JSDOMConstructorNotConstructable.h:
1919         (WebCore::JSDOMConstructorNotConstructable::callThrowTypeError):
1920         * bindings/js/JSDOMExceptionHandling.cpp:
1921         (WebCore::createDOMException):
1922         (WebCore::throwSequenceTypeError):
1923         (WebCore::throwNonFiniteTypeError):
1924         * bindings/js/JSDOMIterator.h:
1925         (WebCore::iteratorForEach):
1926         (WebCore::IteratorTraits>::next):
1927         * bindings/js/JSDOMWindowBase.cpp:
1928         (WebCore::isResponseCorrect):
1929         (WebCore::handleResponseOnStreamingAction):
1930         (WebCore::JSDOMWindowBase::compileStreaming):
1931         (WebCore::JSDOMWindowBase::instantiateStreaming):
1932         * bindings/js/JSDOMWindowCustom.cpp:
1933         (WebCore::JSDOMWindow::preventExtensions):
1934         (WebCore::JSDOMWindow::toStringName):
1935         * bindings/js/JSHTMLElementCustom.cpp:
1936         (WebCore::constructJSHTMLElement):
1937         * bindings/js/JSLocationCustom.cpp:
1938         (WebCore::JSLocation::preventExtensions):
1939         (WebCore::JSLocation::toStringName):
1940         * bindings/js/JSReadableStreamPrivateConstructors.cpp:
1941         (WebCore::constructJSReadableStreamDefaultController):
1942         (WebCore::constructJSReadableByteStreamController):
1943         (WebCore::constructJSReadableStreamBYOBRequest):
1944         * bindings/js/JSRemoteDOMWindowCustom.cpp:
1945         (WebCore::JSRemoteDOMWindow::preventExtensions):
1946         (WebCore::JSRemoteDOMWindow::toStringName):
1947         * bindings/js/ReadableStreamDefaultController.cpp:
1948         (WebCore::ReadableStreamDefaultController::invoke):
1949         * bindings/js/ScriptModuleLoader.cpp:
1950         (WebCore::resolveModuleSpecifier):
1951         (WebCore::ScriptModuleLoader::resolve):
1952         (WebCore::ScriptModuleLoader::fetch):
1953         (WebCore::ScriptModuleLoader::evaluate):
1954         (WebCore::ScriptModuleLoader::importModule):
1955         (WebCore::ScriptModuleLoader::notifyFinished):
1956         * bindings/js/SerializedScriptValue.cpp:
1957         (WebCore::maybeThrowExceptionIfSerializationFailed):
1958         * bindings/js/WorkerScriptController.cpp:
1959         (WebCore::WorkerScriptController::evaluate):
1960         * bindings/scripts/CodeGeneratorJS.pm:
1961         (GenerateDefaultValue):
1962         (GenerateConstructorHelperMethods):
1963         (GenerateCallTracer):
1964         * bindings/scripts/test/JS/JSInterfaceName.cpp:
1965         (WebCore::JSInterfaceNameConstructor::initializeProperties):
1966         * bindings/scripts/test/JS/JSMapLike.cpp:
1967         (WebCore::JSMapLikeConstructor::initializeProperties):
1968         * bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
1969         (WebCore::JSReadOnlyMapLikeConstructor::initializeProperties):
1970         * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
1971         (WebCore::JSTestActiveDOMObjectConstructor::initializeProperties):
1972         * bindings/scripts/test/JS/JSTestCEReactions.cpp:
1973         (WebCore::JSTestCEReactionsConstructor::initializeProperties):
1974         * bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
1975         (WebCore::JSTestCEReactionsStringifierConstructor::initializeProperties):
1976         * bindings/scripts/test/JS/JSTestCallTracer.cpp:
1977         (WebCore::JSTestCallTracerConstructor::initializeProperties):
1978         (WebCore::jsTestCallTracerTestAttributeInterfaceGetter):
1979         (WebCore::setJSTestCallTracerTestAttributeInterfaceSetter):
1980         (WebCore::jsTestCallTracerTestAttributeSpecifiedGetter):
1981         (WebCore::setJSTestCallTracerTestAttributeSpecifiedSetter):
1982         (WebCore::jsTestCallTracerTestAttributeWithVariantGetter):
1983         (WebCore::setJSTestCallTracerTestAttributeWithVariantSetter):
1984         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterfaceBody):
1985         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecifiedBody):
1986         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArgumentsBody):
1987         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
1988         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgumentBody):
1989         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
1990         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
1991         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):
1992         * bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
1993         (WebCore::JSTestCallbackInterfaceConstructor::initializeProperties):
1994         * bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
1995         (WebCore::JSTestClassWithJSBuiltinConstructorConstructor::initializeProperties):
1996         * bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
1997         (WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::initializeProperties):
1998         * bindings/scripts/test/JS/JSTestDOMJIT.cpp:
1999         (WebCore::JSTestDOMJITConstructor::initializeProperties):
2000         * bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
2001         (WebCore::JSTestEnabledBySettingConstructor::initializeProperties):
2002         * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
2003         (WebCore::JSTestEventConstructorConstructor::initializeProperties):
2004         * bindings/scripts/test/JS/JSTestEventTarget.cpp:
2005         (WebCore::JSTestEventTargetConstructor::initializeProperties):
2006         * bindings/scripts/test/JS/JSTestException.cpp:
2007         (WebCore::JSTestExceptionConstructor::initializeProperties):
2008         * bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
2009         (WebCore::JSTestGenerateIsReachableConstructor::initializeProperties):
2010         * bindings/scripts/test/JS/JSTestGlobalObject.cpp:
2011         (WebCore::JSTestGlobalObjectConstructor::initializeProperties):
2012         * bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
2013         (WebCore::JSTestIndexedSetterNoIdentifierConstructor::initializeProperties):
2014         * bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
2015         (WebCore::JSTestIndexedSetterThrowingExceptionConstructor::initializeProperties):
2016         * bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
2017         (WebCore::JSTestIndexedSetterWithIdentifierConstructor::initializeProperties):
2018         * bindings/scripts/test/JS/JSTestInterface.cpp:
2019         (WebCore::JSTestInterfaceConstructor::construct):
2020         (WebCore::JSTestInterfaceConstructor::initializeProperties):
2021         * bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
2022         (WebCore::JSTestInterfaceLeadingUnderscoreConstructor::initializeProperties):
2023         * bindings/scripts/test/JS/JSTestIterable.cpp:
2024         (WebCore::JSTestIterableConstructor::initializeProperties):
2025         * bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
2026         (WebCore::JSTestJSBuiltinConstructorConstructor::initializeProperties):
2027         * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
2028         (WebCore::JSTestMediaQueryListListenerConstructor::initializeProperties):
2029         * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
2030         (WebCore::JSTestNamedAndIndexedSetterNoIdentifierConstructor::initializeProperties):
2031         * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
2032         (WebCore::JSTestNamedAndIndexedSetterThrowingExceptionConstructor::initializeProperties):
2033         * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
2034         (WebCore::JSTestNamedAndIndexedSetterWithIdentifierConstructor::initializeProperties):
2035         * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
2036         (WebCore::JSTestNamedConstructorConstructor::initializeProperties):
2037         (WebCore::JSTestNamedConstructorNamedConstructor::construct):
2038         (WebCore::JSTestNamedConstructorNamedConstructor::initializeProperties):
2039         * bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
2040         (WebCore::JSTestNamedDeleterNoIdentifierConstructor::initializeProperties):
2041         * bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
2042         (WebCore::JSTestNamedDeleterThrowingExceptionConstructor::initializeProperties):
2043         * bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
2044         (WebCore::JSTestNamedDeleterWithIdentifierConstructor::initializeProperties):
2045         * bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
2046         (WebCore::JSTestNamedDeleterWithIndexedGetterConstructor::initializeProperties):
2047         * bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
2048         (WebCore::JSTestNamedGetterCallWithConstructor::initializeProperties):
2049         * bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
2050         (WebCore::JSTestNamedGetterNoIdentifierConstructor::initializeProperties):
2051         * bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
2052         (WebCore::JSTestNamedGetterWithIdentifierConstructor::initializeProperties):
2053         * bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
2054         (WebCore::JSTestNamedSetterNoIdentifierConstructor::initializeProperties):
2055         * bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
2056         (WebCore::JSTestNamedSetterThrowingExceptionConstructor::initializeProperties):
2057         * bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
2058         (WebCore::JSTestNamedSetterWithIdentifierConstructor::initializeProperties):
2059         * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
2060         (WebCore::JSTestNamedSetterWithIndexedGetterConstructor::initializeProperties):
2061         * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
2062         (WebCore::JSTestNamedSetterWithIndexedGetterAndSetterConstructor::initializeProperties):
2063         * bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
2064         (WebCore::JSTestNamedSetterWithOverrideBuiltinsConstructor::initializeProperties):
2065         * bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
2066         (WebCore::JSTestNamedSetterWithUnforgablePropertiesConstructor::initializeProperties):
2067         * bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
2068         (WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltinsConstructor::initializeProperties):
2069         * bindings/scripts/test/JS/JSTestNode.cpp:
2070         (WebCore::JSTestNodeConstructor::initializeProperties):
2071         * bindings/scripts/test/JS/JSTestObj.cpp:
2072         (WebCore::convertDictionary<TestObj::Dictionary>):
2073         (WebCore::JSTestObjConstructor::initializeProperties):
2074         (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringAndDefaultValueBody):
2075         * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
2076         (WebCore::JSTestOverloadedConstructorsConstructor::initializeProperties):
2077         * bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
2078         (WebCore::JSTestOverloadedConstructorsWithSequenceConstructor::initializeProperties):
2079         * bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
2080         (WebCore::JSTestOverrideBuiltinsConstructor::initializeProperties):
2081         * bindings/scripts/test/JS/JSTestPluginInterface.cpp:
2082         (WebCore::JSTestPluginInterfaceConstructor::initializeProperties):
2083         * bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
2084         (WebCore::JSTestPromiseRejectionEventConstructor::initializeProperties):
2085         * bindings/scripts/test/JS/JSTestSerialization.cpp:
2086         (WebCore::JSTestSerializationConstructor::initializeProperties):
2087         * bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
2088         (WebCore::JSTestSerializationIndirectInheritanceConstructor::initializeProperties):
2089         * bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
2090         (WebCore::JSTestSerializationInheritConstructor::initializeProperties):
2091         * bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
2092         (WebCore::JSTestSerializationInheritFinalConstructor::initializeProperties):
2093         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
2094         (WebCore::JSTestSerializedScriptValueInterfaceConstructor::initializeProperties):
2095         * bindings/scripts/test/JS/JSTestStringifier.cpp:
2096         (WebCore::JSTestStringifierConstructor::initializeProperties):
2097         * bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
2098         (WebCore::JSTestStringifierAnonymousOperationConstructor::initializeProperties):
2099         * bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
2100         (WebCore::JSTestStringifierNamedOperationConstructor::initializeProperties):
2101         * bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
2102         (WebCore::JSTestStringifierOperationImplementedAsConstructor::initializeProperties):
2103         * bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
2104         (WebCore::JSTestStringifierOperationNamedToStringConstructor::initializeProperties):
2105         * bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
2106         (WebCore::JSTestStringifierReadOnlyAttributeConstructor::initializeProperties):
2107         * bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
2108         (WebCore::JSTestStringifierReadWriteAttributeConstructor::initializeProperties):
2109         * bindings/scripts/test/JS/JSTestTypedefs.cpp:
2110         (WebCore::JSTestTypedefsConstructor::initializeProperties):
2111         * bridge/c/c_instance.cpp:
2112         (JSC::Bindings::CInstance::invokeMethod):
2113         (JSC::Bindings::CInstance::invokeDefaultMethod):
2114         (JSC::Bindings::CInstance::invokeConstruct):
2115         (JSC::Bindings::CInstance::stringValue const):
2116         (JSC::Bindings::CInstance::toJSPrimitive const):
2117         * bridge/objc/objc_instance.mm:
2118         (ObjcInstance::invokeMethod):
2119         * bridge/objc/objc_runtime.mm:
2120         (JSC::Bindings::ObjcArray::setValueAt const):
2121         * contentextensions/ContentExtensionsBackend.cpp:
2122         (WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
2123         * crypto/SubtleCrypto.cpp:
2124         (WebCore::rejectWithException):
2125         (WebCore::SubtleCrypto::encrypt):
2126         (WebCore::SubtleCrypto::decrypt):
2127         (WebCore::SubtleCrypto::sign):
2128         (WebCore::SubtleCrypto::verify):
2129         (WebCore::SubtleCrypto::deriveKey):
2130         (WebCore::SubtleCrypto::deriveBits):
2131         (WebCore::SubtleCrypto::exportKey):
2132         (WebCore::SubtleCrypto::wrapKey):
2133         (WebCore::SubtleCrypto::unwrapKey):
2134         * crypto/keys/CryptoKeyEC.cpp:
2135         (WebCore::CryptoKeyEC::algorithm const):
2136         * css/CSSInheritedValue.cpp:
2137         (WebCore::CSSInheritedValue::customCSSText const):
2138         * css/CSSInitialValue.cpp:
2139         (WebCore::CSSInitialValue::customCSSText const):
2140         * css/CSSKeyframesRule.cpp:
2141         (WebCore::CSSKeyframesRule::insertRule):
2142         * css/CSSRevertValue.cpp:
2143         (WebCore::CSSRevertValue::customCSSText const):
2144         * css/CSSStyleSheet.h:
2145         * css/CSSUnsetValue.cpp:
2146         (WebCore::CSSUnsetValue::customCSSText const):
2147         * css/CSSValueList.cpp:
2148         (WebCore::CSSValueList::customCSSText const):
2149         * css/DOMMatrixReadOnly.cpp:
2150         (WebCore::DOMMatrixReadOnly::validateAndFixup):
2151         (WebCore::DOMMatrixReadOnly::toFloat32Array const):
2152         (WebCore::DOMMatrixReadOnly::toFloat64Array const):
2153         (WebCore::DOMMatrixReadOnly::toString const):
2154         * css/DeprecatedCSSOMValueList.cpp:
2155         (WebCore::DeprecatedCSSOMValueList::cssText const):
2156         * css/FontFace.cpp:
2157         (WebCore::FontFace::create):
2158         (WebCore::FontFace::unicodeRange const):
2159         (WebCore::FontFace::featureSettings const):
2160         * css/MediaQuery.cpp:
2161         (WebCore::MediaQuery::serialize const):
2162         * css/PropertySetCSSStyleDeclaration.cpp:
2163         (WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
2164         * css/WebKitCSSMatrix.cpp:
2165         (WebCore::WebKitCSSMatrix::toString const):
2166         * css/parser/MediaQueryParser.cpp:
2167         (WebCore::MediaQueryParser::commitMediaQuery):
2168         * dom/CDATASection.cpp:
2169         (WebCore::CDATASection::nodeName const):
2170         * dom/Comment.cpp:
2171         (WebCore::Comment::nodeName const):
2172         * dom/DOMException.cpp:
2173         (WebCore::DOMException::description const):
2174         (WebCore::DOMException::create):
2175         * dom/DOMException.h:
2176         (WebCore::DOMException::name):
2177         (WebCore::DOMException::message):
2178         * dom/DOMImplementation.cpp:
2179         (WebCore::DOMImplementation::createHTMLDocument):
2180         * dom/DataTransfer.cpp:
2181         (WebCore::DataTransfer::DataTransfer):
2182         (WebCore::DataTransfer::types const):
2183         (WebCore::DataTransfer::createForInputEvent):
2184         (WebCore::DataTransfer::dropEffect const):
2185         (WebCore::DataTransfer::effectAllowed const):
2186         * dom/DataTransferItem.cpp:
2187         (WebCore::DataTransferItem::kind const):
2188         * dom/Document.cpp:
2189         (WebCore::Document::suggestedMIMEType const):
2190         (WebCore::Document::contentType const):
2191         (WebCore::Document::nodeName const):
2192         (WebCore::Document::writeln):
2193         (WebCore::Document::canNavigate):
2194         (WebCore::Document::designMode const):
2195         (WebCore::Document::requestFullScreenForElement):
2196         * dom/DocumentFragment.cpp:
2197         (WebCore::DocumentFragment::nodeName const):
2198         * dom/InlineStyleSheetOwner.cpp:
2199         (WebCore::InlineStyleSheetOwner::createSheet):
2200         * dom/MouseEvent.cpp:
2201         (WebCore::MouseEvent::initMouseEventQuirk):
2202         * dom/ScriptElement.cpp:
2203         (WebCore::ScriptElement::requestModuleScript):
2204         * dom/ScriptElementCachedScriptFetcher.cpp:
2205         (WebCore::ScriptElementCachedScriptFetcher::requestModuleScript const):
2206         * dom/ScriptExecutionContext.cpp:
2207         (WebCore::ScriptExecutionContext::dispatchErrorEvent):
2208         * dom/ScriptedAnimationController.cpp:
2209         (WebCore::throttlingReasonsToString):
2210         * dom/Text.cpp:
2211         (WebCore::Text::nodeName const):
2212         * dom/TextEncoder.cpp:
2213         (WebCore::TextEncoder::encoding const):
2214         * dom/Traversal.cpp:
2215         (WebCore::NodeIteratorBase::acceptNode):
2216         * editing/EditCommand.cpp:
2217         (WebCore::inputTypeNameForEditingAction):
2218         * editing/Editing.cpp:
2219         (WebCore::createTabSpanElement):
2220         * editing/Editor.cpp:
2221         (WebCore::createDataTransferForClipboardEvent):
2222         * editing/EditorCommand.cpp:
2223         (WebCore::executeInsertBacktab):
2224         (WebCore::executeInsertLineBreak):
2225         (WebCore::executeInsertNewline):
2226         (WebCore::executeInsertTab):
2227         (WebCore::executeJustifyCenter):
2228         (WebCore::executeJustifyFull):
2229         (WebCore::executeJustifyLeft):
2230         (WebCore::executeJustifyRight):
2231         (WebCore::executeStrikethrough):
2232         (WebCore::executeSubscript):
2233         (WebCore::executeSuperscript):
2234         (WebCore::executeToggleBold):
2235         (WebCore::executeToggleItalic):
2236         (WebCore::executeUnderline):
2237         (WebCore::executeUnscript):
2238         (WebCore::stateBold):
2239         (WebCore::stateItalic):
2240         (WebCore::stateStrikethrough):
2241         (WebCore::stateSubscript):
2242         (WebCore::stateSuperscript):
2243         (WebCore::stateUnderline):
2244         (WebCore::stateJustifyCenter):
2245         (WebCore::stateJustifyFull):
2246         (WebCore::stateJustifyLeft):
2247         (WebCore::stateJustifyRight):
2248         (WebCore::Editor::Command::value const):
2249         * editing/SmartReplace.cpp:
2250         (WebCore::getSmartSet):
2251         * fileapi/FileCocoa.mm:
2252         (WebCore::File::computeNameAndContentTypeForReplacedFile):
2253         * html/BaseCheckableInputType.cpp:
2254         (WebCore::BaseCheckableInputType::saveFormControlState const):
2255         * html/BaseChooserOnlyDateAndTimeInputType.cpp:
2256         (WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
2257         * html/ColorInputType.cpp:
2258         (WebCore::ColorInputType::fallbackValue const):
2259         * html/DOMFormData.cpp:
2260         (WebCore::DOMFormData::createFileEntry):
2261         * html/FTPDirectoryDocument.cpp:
2262         (WebCore::processFilesizeString):
2263         (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
2264         * html/HTMLAnchorElement.cpp:
2265         (WebCore::HTMLAnchorElement::relList const):
2266         (WebCore::HTMLAnchorElement::isSystemPreviewLink const):
2267         * html/HTMLAppletElement.cpp:
2268         (WebCore::HTMLAppletElement::HTMLAppletElement):
2269         (WebCore::HTMLAppletElement::updateWidget):
2270         * html/HTMLCanvasElement.cpp:
2271         (WebCore::toEncodingMimeType):
2272         (WebCore::HTMLCanvasElement::toDataURL):
2273         (WebCore::HTMLCanvasElement::captureStream):
2274         * html/HTMLElement.cpp:
2275         (WebCore::HTMLElement::contentEditable const):
2276         * html/HTMLFormControlElement.cpp:
2277         (WebCore::shouldAutofocus):
2278         * html/HTMLHtmlElement.cpp:
2279         (WebCore::HTMLHtmlElement::insertedByParser):
2280         * html/HTMLKeygenElement.cpp:
2281         (WebCore::HTMLKeygenElement::keytype const):
2282         * html/HTMLMediaElement.cpp:
2283         (WebCore::HTMLMediaElement::canPlayType const):
2284         (WebCore::stringForNetworkState):
2285         (WebCore::HTMLMediaElement::preload const):
2286         (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
2287         * html/HTMLObjectElement.cpp:
2288         (WebCore::mapDataParamToSrc):
2289         * html/HTMLPlugInElement.cpp:
2290         (WebCore::HTMLPlugInElement::setReplacement):
2291         * html/ImageData.cpp:
2292         (WebCore::ImageData::create):
2293         * html/ImageDocument.cpp:
2294         (WebCore::ImageDocument::createDocumentStructure):
2295         * html/ImageInputType.cpp:
2296         (WebCore::ImageInputType::appendFormData const):
2297         * html/PluginDocument.cpp:
2298         (WebCore::PluginDocumentParser::createDocumentStructure):
2299         * html/canvas/WebGL2RenderingContext.cpp:
2300         (WebCore::WebGL2RenderingContext::getExtension):
2301         (WebCore::WebGL2RenderingContext::getSupportedExtensions):
2302         (WebCore::WebGL2RenderingContext::getParameter):
2303         * html/canvas/WebGLCompressedTextureASTC.cpp:
2304         (WebCore::WebGLCompressedTextureASTC::WebGLCompressedTextureASTC):
2305         (WebCore::WebGLCompressedTextureASTC::getSupportedProfiles):
2306         (WebCore::WebGLCompressedTextureASTC::supported):
2307         (WebCore::m_isLDRSupported): Deleted.
2308         * html/canvas/WebGLRenderingContext.cpp:
2309         (WebCore::WebGLRenderingContext::getExtension):
2310         (WebCore::WebGLRenderingContext::getSupportedExtensions):
2311         (WebCore::WebGLRenderingContext::getParameter):
2312         * html/canvas/WebGLRenderingContextBase.cpp:
2313         (WebCore::WebGLRenderingContextBase::create):
2314         (WebCore::WebGLRenderingContextBase::enableSupportedExtension):
2315         * html/canvas/WebGLRenderingContextBase.h:
2316         * html/canvas/WebGPUEnums.cpp:
2317         (WebCore::web3DCompareFunctionName):
2318         * html/parser/HTMLParserIdioms.cpp:
2319         (WebCore::parseCORSSettingsAttribute):
2320         * html/parser/HTMLPreloadScanner.cpp:
2321         (WebCore::TokenPreloadScanner::initiatorFor):
2322         * html/parser/HTMLResourcePreloader.cpp:
2323         (WebCore::PreloadRequest::resourceRequest):
2324         * html/parser/HTMLTreeBuilder.cpp:
2325         (WebCore::HTMLTreeBuilder::insertPhoneNumberLink):
2326         * html/track/DataCue.cpp:
2327         (WebCore::DataCue::toJSONString const):
2328         * html/track/InbandGenericTextTrack.cpp:
2329         (WebCore::InbandGenericTextTrack::updateCueFromCueData):
2330         * html/track/TextTrackCue.cpp:
2331         (WebCore::TextTrackCue::toJSON const):
2332         * html/track/TextTrackCueGeneric.cpp:
2333         (WebCore::TextTrackCueGeneric::toJSONString const):
2334         * html/track/TrackBase.cpp:
2335         (WebCore::TrackBase::setLanguage):
2336         * html/track/VTTCue.cpp:
2337         (WebCore::VTTCue::toJSON const):
2338         * inspector/CommandLineAPIModule.cpp:
2339         (WebCore::CommandLineAPIModule::CommandLineAPIModule):
2340         * inspector/InspectorCanvas.cpp:
2341         (WebCore::InspectorCanvas::getCanvasContentAsDataURL):
2342         (WebCore::InspectorCanvas::indexForData):
2343         (WebCore::InspectorCanvas::buildInitialState):
2344         (WebCore::InspectorCanvas::buildArrayForCanvasGradient):
2345         (WebCore::InspectorCanvas::buildArrayForCanvasPattern):
2346         * inspector/InspectorFrontendClient.h:
2347         (WebCore::InspectorFrontendClient::debuggableType):
2348         * inspector/InspectorFrontendClientLocal.cpp:
2349         (WebCore::InspectorFrontendClientLocal::openInNewTab):
2350         * inspector/InspectorFrontendHost.cpp:
2351         (WebCore::InspectorFrontendHost::userInterfaceLayoutDirection):
2352         (WebCore::InspectorFrontendHost::platform):
2353         (WebCore::InspectorFrontendHost::port):
2354         * inspector/InspectorOverlay.cpp:
2355         (WebCore::InspectorOverlay::setIndicating):
2356         (WebCore::InspectorOverlay::drawPaintRects):
2357         (WebCore::InspectorOverlay::drawRulers):
2358         (WebCore::appendPathSegment):
2359         * inspector/InspectorStyleSheet.h:
2360         (WebCore::InspectorCSSId::InspectorCSSId):
2361         * inspector/TimelineRecordFactory.cpp:
2362         (WebCore::TimelineRecordFactory::createGenericRecord):
2363         (WebCore::TimelineRecordFactory::createFunctionCallData):
2364         (WebCore::TimelineRecordFactory::createConsoleProfileData):
2365         (WebCore::TimelineRecordFactory::createProbeSampleData):
2366         (WebCore::TimelineRecordFactory::createEventDispatchData):
2367         (WebCore::TimelineRecordFactory::createGenericTimerData):
2368         (WebCore::TimelineRecordFactory::createTimerInstallData):
2369         (WebCore::TimelineRecordFactory::createEvaluateScriptData):
2370         (WebCore::TimelineRecordFactory::createTimeStampData):
2371         (WebCore::TimelineRecordFactory::createAnimationFrameData):
2372         (WebCore::TimelineRecordFactory::createPaintData):
2373         (WebCore::TimelineRecordFactory::appendLayoutRoot):
2374         * inspector/WebInjectedScriptHost.cpp:
2375         (WebCore::WebInjectedScriptHost::subtype):
2376         (WebCore::jsStringForPaymentRequestState):
2377         (WebCore::WebInjectedScriptHost::getInternalProperties):
2378         * inspector/agents/InspectorApplicationCacheAgent.cpp:
2379         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
2380         * inspector/agents/InspectorCSSAgent.cpp:
2381         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
2382         (WebCore::InspectorCSSAgent::getMatchedStylesForNode):
2383         (WebCore::InspectorCSSAgent::createStyleSheet):
2384         (WebCore::InspectorCSSAgent::addRule):
2385         (WebCore::InspectorCSSAgent::elementForId):
2386         (WebCore::InspectorCSSAgent::assertStyleSheetForId):
2387         * inspector/agents/InspectorCanvasAgent.cpp:
2388         (WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
2389         (WebCore::InspectorCanvasAgent::requestNode):
2390         (WebCore::InspectorCanvasAgent::requestContent):
2391         (WebCore::InspectorCanvasAgent::resolveCanvasContext):
2392         (WebCore::InspectorCanvasAgent::startRecording):
2393         (WebCore::InspectorCanvasAgent::stopRecording):
2394         (WebCore::InspectorCanvasAgent::requestShaderSource):
2395         (WebCore::InspectorCanvasAgent::updateShader):
2396         (WebCore::InspectorCanvasAgent::setShaderProgramDisabled):
2397         (WebCore::InspectorCanvasAgent::setShaderProgramHighlighted):
2398         (WebCore::InspectorCanvasAgent::assertInspectorCanvas):
2399         (WebCore::InspectorCanvasAgent::assertInspectorProgram):
2400         * inspector/agents/InspectorDOMAgent.cpp:
2401         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2402         (WebCore::InspectorDOMAgent::assertNode):
2403         (WebCore::InspectorDOMAgent::assertDocument):
2404         (WebCore::InspectorDOMAgent::assertElement):
2405         (WebCore::InspectorDOMAgent::assertEditableNode):
2406         (WebCore::InspectorDOMAgent::assertEditableElement):
2407         (WebCore::InspectorDOMAgent::getDocument):
2408         (WebCore::InspectorDOMAgent::pushNodeToFrontend):
2409         (WebCore::InspectorDOMAgent::requestChildNodes):
2410         (WebCore::InspectorDOMAgent::querySelector):
2411         (WebCore::InspectorDOMAgent::querySelectorAll):
2412         (WebCore::InspectorDOMAgent::releaseBackendNodeIds):
2413         (WebCore::InspectorDOMAgent::setAttributesAsText):
2414         (WebCore::InspectorDOMAgent::removeNode):
2415         (WebCore::InspectorDOMAgent::setOuterHTML):
2416         (WebCore::InspectorDOMAgent::insertAdjacentHTML):
2417         (WebCore::InspectorDOMAgent::setNodeValue):
2418         (WebCore::InspectorDOMAgent::setEventListenerDisabled):
2419         (WebCore::InspectorDOMAgent::performSearch):
2420         (WebCore::InspectorDOMAgent::getSearchResults):
2421         (WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
2422         (WebCore::InspectorDOMAgent::highlightQuad):
2423         (WebCore::InspectorDOMAgent::highlightSelector):
2424         (WebCore::InspectorDOMAgent::highlightNode):
2425         (WebCore::InspectorDOMAgent::highlightNodeList):
2426         (WebCore::InspectorDOMAgent::moveTo):
2427         (WebCore::InspectorDOMAgent::focus):
2428         (WebCore::InspectorDOMAgent::setInspectedNode):
2429         (WebCore::InspectorDOMAgent::resolveNode):
2430         (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
2431         (WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):
2432         * inspector/agents/InspectorDOMDebuggerAgent.cpp:
2433         (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
2434         (WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
2435         (WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
2436         (WebCore::domTypeName):
2437         (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
2438         * inspector/agents/InspectorDOMStorageAgent.cpp:
2439         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2440         (WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
2441         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
2442         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
2443         (WebCore::InspectorDOMStorageAgent::findStorageArea):
2444         * inspector/agents/InspectorDatabaseAgent.cpp:
2445         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
2446         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
2447         * inspector/agents/InspectorIndexedDBAgent.cpp:
2448         (WebCore::Inspector::idbKeyRangeFromKeyRange):
2449         (WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
2450         (WebCore::InspectorIndexedDBAgent::requestData):
2451         * inspector/agents/InspectorLayerTreeAgent.cpp:
2452         (WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
2453         (WebCore::InspectorLayerTreeAgent::layersForNode):
2454         (WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
2455         * inspector/agents/InspectorMemoryAgent.cpp:
2456         (WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
2457         * inspector/agents/InspectorNetworkAgent.cpp:
2458         (WebCore::InspectorNetworkAgent::InspectorNetworkAgent):
2459         (WebCore::InspectorNetworkAgent::getResponseBody):
2460         (WebCore::InspectorNetworkAgent::loadResource):
2461         (WebCore::InspectorNetworkAgent::resolveWebSocket):
2462         (WebCore::InspectorNetworkAgent::createTextDecoder):
2463         (WebCore::InspectorNetworkAgent::searchInRequest):
2464         * inspector/agents/InspectorPageAgent.cpp:
2465         (WebCore::InspectorPageAgent::resourceContent):
2466         (WebCore::InspectorPageAgent::InspectorPageAgent):
2467         (WebCore::InspectorPageAgent::navigate):
2468         (WebCore::InspectorPageAgent::assertFrame):
2469         (WebCore::InspectorPageAgent::assertDocumentLoader):
2470         (WebCore::InspectorPageAgent::snapshotNode):
2471         (WebCore::InspectorPageAgent::snapshotRect):
2472         (WebCore::InspectorPageAgent::archive):
2473         * inspector/agents/InspectorTimelineAgent.cpp:
2474         (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
2475         (WebCore::InspectorTimelineAgent::setInstruments):
2476         (WebCore::InspectorTimelineAgent::startFromConsole):
2477         (WebCore::InspectorTimelineAgent::stopFromConsole):
2478         (WebCore::InspectorTimelineAgent::didCompleteRecordEntry):
2479         * inspector/agents/InspectorWorkerAgent.cpp:
2480         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
2481         (WebCore::InspectorWorkerAgent::initialized):
2482         (WebCore::InspectorWorkerAgent::sendMessageToWorker):
2483         * inspector/agents/WebConsoleAgent.cpp:
2484         (WebCore::WebConsoleAgent::setLoggingChannelLevel):
2485         * inspector/agents/page/PageDebuggerAgent.cpp:
2486         (WebCore::PageDebuggerAgent::injectedScriptForEval):
2487         * inspector/agents/page/PageNetworkAgent.cpp:
2488         (WebCore::PageNetworkAgent::scriptExecutionContext):
2489         * inspector/agents/page/PageRuntimeAgent.cpp:
2490         (WebCore::PageRuntimeAgent::injectedScriptForEval):
2491         * inspector/agents/worker/ServiceWorkerAgent.cpp:
2492         (WebCore::ServiceWorkerAgent::ServiceWorkerAgent):
2493         * inspector/agents/worker/WorkerDebuggerAgent.cpp:
2494         (WebCore::WorkerDebuggerAgent::injectedScriptForEval):
2495         * inspector/agents/worker/WorkerRuntimeAgent.cpp:
2496         (WebCore::WorkerRuntimeAgent::injectedScriptForEval):
2497         * loader/ContentFilter.cpp:
2498         (WebCore::ContentFilter::handleProvisionalLoadFailure):
2499         * loader/CrossOriginAccessControl.cpp:
2500         (WebCore::passesAccessControlCheck):
2501         (WebCore::validatePreflightResponse):
2502         * loader/CrossOriginPreflightChecker.cpp:
2503         (WebCore::CrossOriginPreflightChecker::notifyFinished):
2504         (WebCore::CrossOriginPreflightChecker::doPreflight):
2505         * loader/DocumentLoader.cpp:
2506         (WebCore::isRemoteWebArchive):
2507         (WebCore::DocumentLoader::startIconLoading):
2508         * loader/DocumentThreadableLoader.cpp:
2509         (WebCore::DocumentThreadableLoader::reportRedirectionWithBadScheme):
2510         (WebCore::DocumentThreadableLoader::reportContentSecurityPolicyError):
2511         (WebCore::DocumentThreadableLoader::reportCrossOriginResourceSharingError):
2512         (WebCore::DocumentThreadableLoader::reportIntegrityMetadataError):
2513         * loader/FormSubmission.cpp:
2514         (WebCore::FormSubmission::Attributes::parseEncodingType):
2515         * loader/FormSubmission.h:
2516         (WebCore::FormSubmission::Attributes::methodString):
2517         * loader/FrameLoader.cpp:
2518         (WebCore::FrameLoader::initForSynthesizedDocument):
2519         (WebCore::FrameLoader::loadURLIntoChildFrame):
2520         (WebCore::FrameLoader::defaultSubstituteDataForURL):
2521         (WebCore::FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded):
2522         (WebCore::FrameLoader::dispatchBeforeUnloadEvent):
2523         * loader/LinkLoader.cpp:
2524         (WebCore::LinkLoader::preconnectIfNeeded):
2525         * loader/NavigationScheduler.cpp:
2526         (WebCore::NavigationScheduler::scheduleLocationChange):
2527         * loader/PingLoader.cpp:
2528         (WebCore::PingLoader::sendViolationReport):
2529         * loader/ResourceLoadStatistics.cpp:
2530         (WebCore::ResourceLoadStatistics::primaryDomain):
2531         (WebCore::ResourceLoadStatistics::areDomainsAssociated):
2532         * loader/ResourceLoader.cpp:
2533         (WebCore::ResourceLoader::loadDataURL):
2534         (WebCore::ResourceLoader::didBlockAuthenticationChallenge):
2535         * loader/SubresourceLoader.cpp:
2536         (WebCore::SubresourceLoader::willSendRequestInternal):
2537         (WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):
2538         * loader/ThreadableLoader.cpp:
2539         (WebCore::ThreadableLoader::logError):
2540         * loader/appcache/ApplicationCacheGroup.cpp:
2541         (WebCore::ApplicationCacheGroup::abort):
2542         (WebCore::ApplicationCacheGroup::didFinishLoadingEntry):
2543         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2544         (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
2545         * loader/appcache/ApplicationCacheHost.cpp:
2546         (WebCore::ApplicationCacheHost::createFileURL):
2547         * loader/appcache/ManifestParser.cpp:
2548         (WebCore::parseManifest):
2549         * loader/archive/ArchiveFactory.cpp:
2550         (WebCore::createArchiveMIMETypesMap):
2551         * loader/cache/CachedResource.cpp:
2552         (WebCore::CachedResource::load):
2553         * loader/cache/CachedResourceLoader.cpp:
2554         (WebCore::CachedResourceLoader::canRequest):
2555         (WebCore::CachedResourceLoader::requestResource):
2556         * loader/cache/CachedResourceRequest.cpp:
2557         (WebCore::acceptHeaderValueFromType):
2558         (WebCore::CachedResourceRequest::updateAcceptEncodingHeader):
2559         * loader/cache/CachedScript.cpp:
2560         (WebCore::CachedScript::CachedScript):
2561         * loader/cache/MemoryCache.cpp:
2562         (WebCore::MemoryCache::getOriginsWithCache):
2563         * loader/soup/ResourceLoaderSoup.cpp:
2564         (WebCore::ResourceLoader::loadGResource):
2565         * page/DOMSelection.cpp:
2566         (WebCore::DOMSelection::type const):
2567         * page/DOMWindow.cpp:
2568         (WebCore::DOMWindow::close):
2569         (WebCore::DOMWindow::addEventListener):
2570         (WebCore::DOMWindow::createWindow):
2571         * page/DebugPageOverlays.cpp:
2572         (WebCore::touchEventRegionColors):
2573         * page/DiagnosticLoggingKeys.cpp:
2574         (WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
2575         (WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
2576         (WebCore::DiagnosticLoggingKeys::memoryCacheEntryDecisionKey):
2577         (WebCore::DiagnosticLoggingKeys::memoryCacheUsageKey):
2578         (WebCore::DiagnosticLoggingKeys::missingValidatorFieldsKey):
2579         (WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
2580         (WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
2581         (WebCore::DiagnosticLoggingKeys::postPageBackgroundingCPUUsageKey):
2582         (WebCore::DiagnosticLoggingKeys::postPageBackgroundingMemoryUsageKey):
2583         (WebCore::DiagnosticLoggingKeys::pageHandlesWebGLContextLossKey):
2584         (WebCore::DiagnosticLoggingKeys::postPageLoadCPUUsageKey):
2585         (WebCore::DiagnosticLoggingKeys::postPageLoadMemoryUsageKey):
2586         (WebCore::DiagnosticLoggingKeys::provisionalLoadKey):
2587         (WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
2588         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
2589         (WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
2590         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
2591         (WebCore::DiagnosticLoggingKeys::pageLoadedKey):
2592         (WebCore::DiagnosticLoggingKeys::playedKey):
2593         (WebCore::DiagnosticLoggingKeys::engineFailedToLoadKey):
2594         (WebCore::DiagnosticLoggingKeys::entryRightlyNotWarmedUpKey):
2595         (WebCore::DiagnosticLoggingKeys::entryWronglyNotWarmedUpKey):
2596         (WebCore::DiagnosticLoggingKeys::navigationKey):
2597         (WebCore::DiagnosticLoggingKeys::needsRevalidationKey):
2598         (WebCore::DiagnosticLoggingKeys::networkCacheKey):
2599         (WebCore::DiagnosticLoggingKeys::networkCacheFailureReasonKey):
2600         (WebCore::DiagnosticLoggingKeys::networkCacheUnusedReasonKey):
2601         (WebCore::DiagnosticLoggingKeys::networkCacheReuseFailureKey):
2602         (WebCore::DiagnosticLoggingKeys::networkKey):
2603         (WebCore::DiagnosticLoggingKeys::networkProcessCrashedKey):
2604         (WebCore::DiagnosticLoggingKeys::neverSeenBeforeKey):
2605         (WebCore::DiagnosticLoggingKeys::noKey):
2606         (WebCore::DiagnosticLoggingKeys::noCacheKey):
2607         (WebCore::DiagnosticLoggingKeys::noStoreKey):
2608         (WebCore::DiagnosticLoggingKeys::nonVisibleStateKey):
2609         (WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
2610         (WebCore::DiagnosticLoggingKeys::pageCacheKey):
2611         (WebCore::DiagnosticLoggingKeys::pageCacheFailureKey):
2612         (WebCore::DiagnosticLoggingKeys::noDocumentLoaderKey):
2613         (WebCore::DiagnosticLoggingKeys::noLongerInCacheKey):
2614         (WebCore::DiagnosticLoggingKeys::otherKey):
2615         (WebCore::DiagnosticLoggingKeys::mainDocumentErrorKey):
2616         (WebCore::DiagnosticLoggingKeys::mainResourceKey):
2617         (WebCore::DiagnosticLoggingKeys::isErrorPageKey):
2618         (WebCore::DiagnosticLoggingKeys::isExpiredKey):
2619         (WebCore::DiagnosticLoggingKeys::isReloadIgnoringCacheDataKey):
2620         (WebCore::DiagnosticLoggingKeys::loadingKey):
2621         (WebCore::DiagnosticLoggingKeys::hasPluginsKey):
2622         (WebCore::DiagnosticLoggingKeys::httpsNoStoreKey):
2623         (WebCore::DiagnosticLoggingKeys::imageKey):
2624         (WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
2625         (WebCore::DiagnosticLoggingKeys::inactiveKey):
2626         (WebCore::DiagnosticLoggingKeys::internalErrorKey):
2627         (WebCore::DiagnosticLoggingKeys::invalidSessionIDKey):
2628         (WebCore::DiagnosticLoggingKeys::isAttachmentKey):
2629         (WebCore::DiagnosticLoggingKeys::isConditionalRequestKey):
2630         (WebCore::DiagnosticLoggingKeys::isDisabledKey):
2631         (WebCore::DiagnosticLoggingKeys::noCurrentHistoryItemKey):
2632         (WebCore::DiagnosticLoggingKeys::quirkRedirectComingKey):
2633         (WebCore::DiagnosticLoggingKeys::rawKey):
2634         (WebCore::DiagnosticLoggingKeys::redirectKey):
2635         (WebCore::DiagnosticLoggingKeys::isLoadingKey):
2636         (WebCore::DiagnosticLoggingKeys::documentLoaderStoppingKey):
2637         (WebCore::DiagnosticLoggingKeys::domainCausingCrashKey):
2638         (WebCore::DiagnosticLoggingKeys::domainCausingEnergyDrainKey):
2639         (WebCore::DiagnosticLoggingKeys::domainCausingJetsamKey):
2640         (WebCore::DiagnosticLoggingKeys::simulatedPageCrashKey):
2641         (WebCore::DiagnosticLoggingKeys::exceededActiveMemoryLimitKey):
2642         (WebCore::DiagnosticLoggingKeys::exceededInactiveMemoryLimitKey):
2643         (WebCore::DiagnosticLoggingKeys::exceededBackgroundCPULimitKey):
2644         (WebCore::DiagnosticLoggingKeys::domainVisitedKey):
2645         (WebCore::DiagnosticLoggingKeys::cannotSuspendActiveDOMObjectsKey):
2646         (WebCore::DiagnosticLoggingKeys::cpuUsageKey):
2647         (WebCore::DiagnosticLoggingKeys::createSharedBufferFailedKey):
2648         (WebCore::DiagnosticLoggingKeys::activeInForegroundTabKey):
2649         (WebCore::DiagnosticLoggingKeys::activeInBackgroundTabOnlyKey):
2650         (WebCore::DiagnosticLoggingKeys::applicationCacheKey):
2651         (WebCore::DiagnosticLoggingKeys::applicationManifestKey):
2652         (WebCore::DiagnosticLoggingKeys::audioKey):
2653         (WebCore::DiagnosticLoggingKeys::backNavigationDeltaKey):
2654         (WebCore::DiagnosticLoggingKeys::canCacheKey):
2655         (WebCore::DiagnosticLoggingKeys::cacheControlNoStoreKey):
2656         (WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
2657         (WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationReasonKey):
2658         (WebCore::DiagnosticLoggingKeys::deniedByClientKey):
2659         (WebCore::DiagnosticLoggingKeys::deviceMotionKey):
2660         (WebCore::DiagnosticLoggingKeys::deviceOrientationKey):
2661         (WebCore::DiagnosticLoggingKeys::diskCacheKey):
2662         (WebCore::DiagnosticLoggingKeys::diskCacheAfterValidationKey):
2663         (WebCore::DiagnosticLoggingKeys::reloadKey):
2664         (WebCore::DiagnosticLoggingKeys::replaceKey):
2665         (WebCore::DiagnosticLoggingKeys::retrievalRequestKey):
2666         (WebCore::DiagnosticLoggingKeys::resourceLoadedKey):
2667         (WebCore::DiagnosticLoggingKeys::resourceResponseSourceKey):
2668         (WebCore::DiagnosticLoggingKeys::retrievalKey):
2669         (WebCore::DiagnosticLoggingKeys::revalidatingKey):
2670         (WebCore::DiagnosticLoggingKeys::reloadFromOriginKey):
2671         (WebCore::DiagnosticLoggingKeys::reloadRevalidatingExpiredKey):
2672         (WebCore::DiagnosticLoggingKeys::sameLoadKey):
2673         (WebCore::DiagnosticLoggingKeys::scriptKey):
2674         (WebCore::DiagnosticLoggingKeys::serviceWorkerKey):
2675         (WebCore::DiagnosticLoggingKeys::streamingMedia):
2676         (WebCore::DiagnosticLoggingKeys::styleSheetKey):
2677         (WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithRevalidationKey):
2678         (WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithoutRevalidationKey):
2679         (WebCore::DiagnosticLoggingKeys::svgDocumentKey):
2680         (WebCore::DiagnosticLoggingKeys::synchronousMessageFailedKey):
2681         (WebCore::DiagnosticLoggingKeys::telemetryPageLoadKey):
2682         (WebCore::DiagnosticLoggingKeys::timedOutKey):
2683         (WebCore::DiagnosticLoggingKeys::canceledLessThan2SecondsKey):
2684         (WebCore::DiagnosticLoggingKeys::canceledLessThan5SecondsKey):
2685         (WebCore::DiagnosticLoggingKeys::canceledLessThan20SecondsKey):
2686         (WebCore::DiagnosticLoggingKeys::canceledMoreThan20SecondsKey):
2687         (WebCore::DiagnosticLoggingKeys::failedLessThan2SecondsKey):
2688         (WebCore::DiagnosticLoggingKeys::failedLessThan5SecondsKey):
2689         (WebCore::DiagnosticLoggingKeys::failedLessThan20SecondsKey):
2690         (WebCore::DiagnosticLoggingKeys::failedMoreThan20SecondsKey):
2691         (WebCore::DiagnosticLoggingKeys::occurredKey):
2692         (WebCore::DiagnosticLoggingKeys::succeededLessThan2SecondsKey):
2693         (WebCore::DiagnosticLoggingKeys::succeededLessThan5SecondsKey):
2694         (WebCore::DiagnosticLoggingKeys::succeededLessThan20SecondsKey):
2695         (WebCore::DiagnosticLoggingKeys::succeededMoreThan20SecondsKey):
2696         (WebCore::DiagnosticLoggingKeys::uncacheableStatusCodeKey):
2697         (WebCore::DiagnosticLoggingKeys::underMemoryPressureKey):
2698         (WebCore::DiagnosticLoggingKeys::unknownEntryRequestKey):
2699         (WebCore::DiagnosticLoggingKeys::unlikelyToReuseKey):
2700         (WebCore::DiagnosticLoggingKeys::unsupportedHTTPMethodKey):
2701         (WebCore::DiagnosticLoggingKeys::unsuspendableDOMObjectKey):
2702         (WebCore::DiagnosticLoggingKeys::unusedKey):
2703         (WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
2704         (WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
2705         (WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
2706         (WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
2707         (WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
2708         (WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
2709         (WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
2710         (WebCore::DiagnosticLoggingKeys::usedKey):
2711         (WebCore::DiagnosticLoggingKeys::userZoomActionKey):
2712         (WebCore::DiagnosticLoggingKeys::varyingHeaderMismatchKey):
2713         (WebCore::DiagnosticLoggingKeys::videoKey):
2714         (WebCore::DiagnosticLoggingKeys::visibleNonActiveStateKey):
2715         (WebCore::DiagnosticLoggingKeys::visibleAndActiveStateKey):
2716         (WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithRevalidationKey):
2717         (WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithoutRevalidationKey):
2718         (WebCore::DiagnosticLoggingKeys::webViewKey):
2719         (WebCore::DiagnosticLoggingKeys::yesKey):
2720         (WebCore::DiagnosticLoggingKeys::expiredKey):
2721         (WebCore::DiagnosticLoggingKeys::fontKey):
2722         (WebCore::DiagnosticLoggingKeys::prunedDueToMemoryPressureKey):
2723         (WebCore::DiagnosticLoggingKeys::prunedDueToMaxSizeReached):
2724         (WebCore::DiagnosticLoggingKeys::prunedDueToProcessSuspended):
2725         (WebCore::WebCore::DiagnosticLoggingKeys::notHTTPFamilyKey):
2726         (WebCore::WebCore::DiagnosticLoggingKeys::webGLStateKey):
2727         (WebCore::DiagnosticLoggingKeys::memoryUsageToDiagnosticLoggingKey):
2728         (WebCore::DiagnosticLoggingKeys::foregroundCPUUsageToDiagnosticLoggingKey):
2729         (WebCore::DiagnosticLoggingKeys::backgroundCPUUsageToDiagnosticLoggingKey):
2730         (WebCore::DiagnosticLoggingKeys::resourceLoadStatisticsTelemetryKey):
2731         * page/DisabledAdaptations.cpp:
2732         (WebCore::watchAdaptationName):
2733         * page/EventHandler.cpp:
2734         (WebCore::EventHandler::handlePasteGlobalSelection):
2735         (WebCore::convertDragOperationToDropZoneOperation):
2736         * page/EventSource.cpp:
2737         (WebCore::EventSource::EventSource):
2738         * page/History.cpp:
2739         (WebCore::History::stateObjectAdded):
2740         * page/NavigatorBase.cpp:
2741         (WebCore::NavigatorBase::appName):
2742         (WebCore::NavigatorBase::appCodeName):
2743         * page/Page.cpp:
2744         (WebCore::Page::logNavigation):
2745         * page/PageDebuggable.cpp:
2746         (WebCore::PageDebuggable::url const):
2747         * page/PageSerializer.cpp:
2748         (WebCore::PageSerializer::serializeCSSStyleSheet):
2749         * page/PerformanceMark.h:
2750         * page/PerformanceMeasure.h:
2751         * page/PerformanceObserver.cpp:
2752         (WebCore::PerformanceObserver::observe):
2753         * page/PerformanceResourceTiming.cpp:
2754         (WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
2755         * page/PerformanceUserTiming.cpp:
2756         (WebCore::restrictedMarkFunction):
2757         * page/PointerLockController.cpp:
2758         (WebCore::PointerLockController::requestPointerLock):
2759         * page/PrintContext.cpp:
2760         (WebCore::PrintContext::pageProperty):
2761         * page/SecurityOrigin.cpp:
2762         (WebCore::SecurityOrigin::toString const):
2763         * page/SecurityOriginData.cpp:
2764         (WebCore::SecurityOriginData::toString const):
2765         (WebCore::SecurityOriginData::databaseIdentifier const):
2766         * page/cocoa/ResourceUsageOverlayCocoa.mm:
2767         (WebCore::gcTimerString):
2768         * page/csp/ContentSecurityPolicy.cpp:
2769         (WebCore::ContentSecurityPolicy::reportViolation const):
2770         (WebCore::ContentSecurityPolicy::reportUnsupportedDirective const):
2771         * page/linux/ResourceUsageOverlayLinux.cpp:
2772         (WebCore::cpuUsageString):
2773         (WebCore::gcTimerString):
2774         * platform/ContentType.cpp:
2775         (WebCore::ContentType::codecsParameter):
2776         (WebCore::ContentType::profilesParameter):
2777         * platform/Decimal.cpp:
2778         (WebCore::Decimal::toString const):
2779         * platform/MIMETypeRegistry.cpp:
2780         (WebCore::initializeSupportedImageMIMETypes):
2781         (WebCore::typesForCommonExtension):
2782         (WebCore::initializeUnsupportedTextMIMETypes):
2783         (WebCore::MIMETypeRegistry::getNormalizedMIMEType):
2784         * platform/SchemeRegistry.cpp:
2785         (WebCore::SchemeRegistry::canServiceWorkersHandleURLScheme):
2786         * platform/URL.cpp:
2787         (WebCore::mimeTypeFromDataURL):
2788         * platform/UserAgentQuirks.cpp:
2789         (WebCore::UserAgentQuirks::stringForQuirk):
2790         * platform/cocoa/KeyEventCocoa.mm:
2791         (WebCore::keyForCharCode):
2792         * platform/cocoa/NetworkExtensionContentFilter.mm:
2793         (WebCore::NetworkExtensionContentFilter::unblockHandler const):
2794         * platform/cocoa/ParentalControlsContentFilter.mm:
2795         (WebCore::ParentalControlsContentFilter::unblockHandler const):
2796         * platform/cocoa/PasteboardCocoa.mm:
2797         (WebCore::Pasteboard::fileContentState):
2798         * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
2799         (WebCore::MacApplication::isSafari):
2800         (WebCore::MacApplication::isAppleMail):
2801         (WebCore::MacApplication::isIBooks):
2802         (WebCore::MacApplication::isITunes):
2803         (WebCore::MacApplication::isMicrosoftMessenger):
2804         (WebCore::MacApplication::isAdobeInstaller):
2805         (WebCore::MacApplication::isAOLInstantMessenger):
2806         (WebCore::MacApplication::isMicrosoftMyDay):
2807         (WebCore::MacApplication::isMicrosoftOutlook):
2808         (WebCore::MacApplication::isQuickenEssentials):
2809         (WebCore::MacApplication::isAperture):
2810         (WebCore::MacApplication::isVersions):
2811         (WebCore::MacApplication::isHRBlock):
2812         (WebCore::MacApplication::isIAdProducer):
2813         (WebCore::MacApplication::isSolidStateNetworksDownloader):
2814         (WebCore::IOSApplication::isMobileMail):
2815         (WebCore::IOSApplication::isMobileSafari):
2816         (WebCore::IOSApplication::isWebBookmarksD):
2817         (WebCore::IOSApplication::isDumpRenderTree):
2818         (WebCore::IOSApplication::isMobileStore):
2819         (WebCore::IOSApplication::isSpringBoard):
2820         (WebCore::IOSApplication::isWebApp):
2821         (WebCore::IOSApplication::isIBooks):
2822         (WebCore::IOSApplication::isIBooksStorytime):
2823         (WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
2824         (WebCore::IOSApplication::isCardiogram):
2825         (WebCore::IOSApplication::isNike):
2826         * platform/cocoa/UserAgentCocoa.mm:
2827         (WebCore::userAgentBundleVersion):
2828         * platform/gamepad/cocoa/GameControllerGamepad.mm:
2829         (WebCore::GameControllerGamepad::setupAsExtendedGamepad):
2830         (WebCore::GameControllerGamepad::setupAsGamepad):
2831         * platform/graphics/InbandTextTrackPrivateClient.h:
2832         (WebCore::GenericCueData::toJSONString const):
2833         * platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
2834         (WebCore::CDMFactoryFairPlayStreaming::supportsKeySystem):
2835         * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
2836         (WebCore::isEqual):
2837         (WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
2838         (WebCore::CDMInstanceFairPlayStreamingAVFObjC::keySystem const):
2839         * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
2840         (WebCore::CDMSessionAVContentKeySession::generateKeyRequest):
2841         * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
2842         (WebCore::CDMSessionAVStreamSession::generateKeyRequest):
2843         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
2844         (WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
2845         * platform/graphics/ca/GraphicsLayerCA.cpp:
2846         (WebCore::propertyIdToString):
2847         * platform/graphics/ca/TileController.cpp:
2848         (WebCore::TileController::tileGridContainerLayerName):
2849         (WebCore::TileController::zoomedOutTileGridContainerLayerName):
2850         * platform/graphics/cg/ImageBufferCG.cpp:
2851         (WebCore::ImageBuffer::toDataURL const):
2852         (WebCore::dataURL):
2853         * platform/graphics/cv/VideoTextureCopierCV.cpp:
2854         (WebCore::VideoTextureCopierCV::initializeContextObjects):
2855         (WebCore::VideoTextureCopierCV::initializeUVContextObjects):
2856         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
2857         (WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
2858         (WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):
2859         * platform/graphics/iso/ISOVTTCue.cpp:
2860         (WebCore::ISOWebVTTCue::toJSONString const):
2861         * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:
2862         (Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):
2863         * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
2864         (WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions):
2865         * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
2866         (WebCore::GraphicsContext3D::getUnmangledInfoLog):
2867         * platform/graphics/texmap/TextureMapperContextAttributes.cpp:
2868         (WebCore::TextureMapperContextAttributes::get):
2869         * platform/graphics/win/ImageBufferDirect2D.cpp:
2870         (WebCore::ImageBuffer::toDataURL const):
2871         (WebCore::ImageDataToDataURL):
2872         * platform/gtk/PasteboardGtk.cpp:
2873         (WebCore::Pasteboard::typesForLegacyUnsafeBindings):
2874         * platform/gtk/PasteboardHelper.cpp:
2875         * platform/gtk/PlatformKeyboardEventGtk.cpp:
2876         (WebCore::PlatformKeyboardEvent::keyValueForGdkKeyCode):
2877         (WebCore::PlatformKeyboardEvent::keyCodeForHardwareKeyCode):
2878         * platform/image-decoders/bmp/BMPImageDecoder.h:
2879         * platform/image-decoders/gif/GIFImageDecoder.h:
2880         * platform/image-decoders/ico/ICOImageDecoder.h:
2881         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
2882         * platform/image-decoders/png/PNGImageDecoder.h:
2883         * platform/image-decoders/webp/WEBPImageDecoder.h:
2884         * platform/ios/Device.cpp:
2885         (WebCore::deviceName):
2886         * platform/ios/PasteboardIOS.mm:
2887         (WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):
2888         * platform/ios/PlatformEventFactoryIOS.mm:
2889         (WebCore::keyForKeyEvent):
2890         (WebCore::codeForKeyEvent):
2891         * platform/ios/PlatformPasteboardIOS.mm:
2892         (WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
2893         * platform/mac/PasteboardMac.mm:
2894         (WebCore::Pasteboard::read):
2895         (WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):
2896         * platform/mac/PlatformEventFactoryMac.mm:
2897         (WebCore::keyForKeyEvent):
2898         (WebCore::codeForKeyEvent):
2899         * platform/mac/PlatformPasteboardMac.mm:
2900         (WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
2901         * platform/mediastream/MediaConstraints.cpp:
2902         (WebCore::addDefaultVideoConstraints):
2903         * platform/mediastream/PeerMediaDescription.h:
2904         * platform/mediastream/RealtimeMediaSource.cpp:
2905         (WebCore::RealtimeMediaSource::applyConstraints):
2906         * platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:
2907         (WebCore::DisplayCaptureManagerCocoa::screenCaptureDeviceWithPersistentID):
2908         * platform/mock/MockRealtimeMediaSource.cpp:
2909         (WebCore::deviceMap):
2910         (WebCore::MockRealtimeMediaSource::audioDevices):
2911         (WebCore::MockRealtimeMediaSource::videoDevices):
2912         (WebCore::MockRealtimeMediaSource::displayDevices):
2913         * platform/mock/MockRealtimeVideoSource.cpp:
2914         (WebCore::MockRealtimeVideoSource::drawText):
2915         * platform/network/BlobRegistryImpl.cpp:
2916         (WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):
2917         * platform/network/DataURLDecoder.cpp:
2918         (WebCore::DataURLDecoder::parseMediaType):
2919         * platform/network/FormData.cpp:
2920         (WebCore::FormData::appendMultiPartFileValue):
2921         * platform/network/HTTPParsers.cpp:
2922         (WebCore::parseHTTPRequestLine):
2923         (WebCore::parseHTTPHeader):
2924         (WebCore::normalizeHTTPMethod):
2925         * platform/network/ResourceRequestBase.cpp:
2926         (WebCore::ResourceRequestBase::redirectedRequest const):
2927         * platform/network/ResourceRequestBase.h:
2928         (WebCore::ResourceRequestBase::ResourceRequestBase):
2929         * platform/network/curl/ResourceHandleCurl.cpp:
2930         (WebCore::ResourceHandle::handleDataURL):
2931         * platform/network/curl/SynchronousLoaderClientCurl.cpp:
2932         (WebCore::SynchronousLoaderClient::platformBadResponseError):
2933         * platform/network/win/DownloadBundleWin.cpp:
2934         (WebCore::DownloadBundle::fileExtension):
2935         * platform/sql/SQLiteDatabase.cpp:
2936         (WebCore::SQLiteDatabase::open):
2937         (WebCore::SQLiteDatabase::setFullsync):
2938         (WebCore::SQLiteDatabase::maximumSize):
2939         (WebCore::SQLiteDatabase::pageSize):
2940         (WebCore::SQLiteDatabase::freeSpaceSize):
2941         (WebCore::SQLiteDatabase::totalSize):
2942         (WebCore::SQLiteDatabase::clearAllTables):
2943         (WebCore::SQLiteDatabase::runVacuumCommand):
2944         (WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
2945         (WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
2946         * platform/sql/SQLiteFileSystem.cpp:
2947         (WebCore::SQLiteFileSystem::deleteDatabaseFile):
2948         * platform/text/LocaleICU.cpp:
2949         (WebCore::LocaleICU::dateFormat):
2950         (WebCore::getFormatForSkeleton):
2951         * platform/text/LocaleNone.cpp:
2952         (WebCore::LocaleNone::dateFormat):
2953         (WebCore::LocaleNone::monthFormat):
2954         (WebCore::LocaleNone::shortMonthFormat):
2955         (WebCore::LocaleNone::timeFormat):
2956         (WebCore::LocaleNone::shortTimeFormat):
2957         (WebCore::LocaleNone::dateTimeFormatWithSeconds):
2958         (WebCore::LocaleNone::dateTimeFormatWithoutSeconds):
2959         * platform/text/LocaleToScriptMappingDefault.cpp:
2960         (WebCore::scriptNameToCode):
2961         (WebCore::localeToScriptCodeForFontSelection):
2962         * platform/text/TextEncodingRegistry.cpp:
2963         (WebCore::defaultTextEncodingNameForSystemLanguage):
2964         * platform/win/FileSystemWin.cpp:
2965         (WebCore::FileSystem::bundleName):
2966         * platform/wpe/RenderThemeWPE.cpp:
2967         (WebCore::RenderThemeWPE::mediaControlsStyleSheet):
2968         * rendering/RenderMenuList.cpp:
2969         (RenderMenuList::setText):
2970         * rendering/RenderThemeIOS.mm:
2971         (WebCore::RenderThemeIOS::extraDefaultStyleSheet):
2972         * svg/SVGComponentTransferFunctionElement.h:
2973         (WebCore::SVGPropertyTraits<ComponentTransferType>::toString):
2974         * svg/SVGFEColorMatrixElement.h:
2975         (WebCore::SVGPropertyTraits<ColorMatrixType>::toString):
2976         * svg/SVGFECompositeElement.h:
2977         (WebCore::SVGPropertyTraits<CompositeOperationType>::toString):
2978         * svg/SVGFEConvolveMatrixElement.h:
2979         (WebCore::SVGPropertyTraits<EdgeModeType>::toString):
2980         * svg/SVGFEDisplacementMapElement.h:
2981         (WebCore::SVGPropertyTraits<ChannelSelectorType>::toString):
2982         * svg/SVGFEMorphologyElement.h:
2983         (WebCore::SVGPropertyTraits<MorphologyOperatorType>::toString):
2984         * svg/SVGFETurbulenceElement.h:
2985         (WebCore::SVGPropertyTraits<SVGStitchOptions>::toString):
2986         (WebCore::SVGPropertyTraits<TurbulenceType>::toString):
2987         * svg/SVGGradientElement.h:
2988         (WebCore::SVGPropertyTraits<SVGSpreadMethodType>::toString):
2989         * svg/SVGLocatable.cpp:
2990         (WebCore::SVGLocatable::getTransformToElement):
2991         * svg/SVGMarkerTypes.h:
2992         (WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::toString):
2993         * svg/SVGMatrixValue.h:
2994         * svg/SVGSVGElement.cpp:
2995         (WebCore::SVGSVGElement::SVGSVGElement):
2996         (WebCore::SVGSVGElement::parseAttribute):
2997         * svg/SVGTextContentElement.h:
2998         (WebCore::SVGPropertyTraits<SVGLengthAdjustType>::toString):
2999         * svg/SVGTextPathElement.h:
3000         (WebCore::SVGPropertyTraits<SVGTextPathMethodType>::toString):
3001         (WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::toString):
3002         * svg/SVGToOTFFontConversion.cpp:
3003         (WebCore::SVGToOTFFontConverter::appendCFFTable):
3004         * svg/SVGUnitTypes.h:
3005         (WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::toString):
3006         * svg/SVGUseElement.cpp:
3007         (WebCore::SVGUseElement::toClipPath):
3008         * svg/graphics/SVGImage.cpp:
3009         (WebCore::SVGImage::filenameExtension const):
3010         * testing/InternalSettings.cpp:
3011         (WebCore::InternalSettings::userInterfaceDirectionPolicy):
3012         (WebCore::InternalSettings::systemLayoutDirection):
3013         * testing/Internals.cpp:
3014         (WebCore::Internals::areSVGAnimationsPaused const):
3015         (WebCore::Internals::accessKeyModifiers const):
3016         (WebCore::Internals::setMediaDeviceState):
3017         (WebCore::Internals::audioSessionCategory const):
3018         (WebCore::Internals::systemPreviewRelType):
3019         * testing/MockCDMFactory.cpp:
3020         (WebCore::MockCDM::sanitizeResponse const):
3021         (WebCore::MockCDMInstance::updateLicense):
3022         * testing/MockContentFilter.cpp:
3023         (WebCore::MockContentFilter::unblockRequestDeniedScript const):
3024         * testing/MockCredentialsMessenger.cpp:
3025         (WebCore::MockCredentialsMessenger::~MockCredentialsMessenger):
3026         (WebCore::MockCredentialsMessenger::makeCredential):
3027         (WebCore::MockCredentialsMessenger::getAssertion):
3028         * testing/MockPaymentCoordinator.cpp:
3029         (WebCore::MockPaymentCoordinator::showPaymentUI):
3030         * workers/WorkerRunLoop.cpp:
3031         (WebCore::WorkerRunLoop::debuggerMode):
3032         * workers/WorkerScriptLoader.cpp:
3033         (WebCore::WorkerScriptLoader::loadSynchronously):
3034         (WebCore::WorkerScriptLoader::createResourceRequest):
3035         (WebCore::WorkerScriptLoader::didReceiveData):
3036         * workers/service/ExtendableEvent.cpp:
3037         (WebCore::ExtendableEvent::waitUntil):
3038         * workers/service/FetchEvent.cpp:
3039         (WebCore::FetchEvent::~FetchEvent):
3040         (WebCore::FetchEvent::respondWith):
3041         (WebCore::FetchEvent::promiseIsSettled):
3042         * workers/service/SWClientConnection.cpp:
3043         (WebCore::SWClientConnection::clearPendingJobs):
3044         * workers/service/ServiceWorker.cpp:
3045         (WebCore::ServiceWorker::postMessage):
3046         * workers/service/ServiceWorkerClients.cpp:
3047         (WebCore::ServiceWorkerClients::openWindow):
3048         (WebCore::ServiceWorkerClients::claim):
3049         * workers/service/ServiceWorkerContainer.cpp:
3050         (WebCore::ServiceWorkerContainer::addRegistration):
3051         (WebCore::ServiceWorkerContainer::getRegistration):
3052         (WebCore::ServiceWorkerContainer::startScriptFetchForJob):
3053         * workers/service/ServiceWorkerJob.cpp:
3054         (WebCore::ServiceWorkerJob::fetchScriptWithContext):
3055         (WebCore::ServiceWorkerJob::didReceiveResponse):
3056         * workers/service/ServiceWorkerRegistration.cpp:
3057         (WebCore::ServiceWorkerRegistration::update):
3058         * workers/service/ServiceWorkerWindowClient.cpp:
3059         (WebCore::ServiceWorkerWindowClient::focus):
3060         (WebCore::ServiceWorkerWindowClient::navigate):
3061         * workers/service/context/ServiceWorkerDebuggable.h:
3062         * workers/service/context/ServiceWorkerFetch.cpp:
3063         (WebCore::ServiceWorkerFetch::dispatchFetchEvent):
3064         * workers/service/server/RegistrationDatabase.cpp:
3065         (WebCore::RegistrationDatabase::doPushChanges):
3066         (WebCore::RegistrationDatabase::importRecords):
3067         * workers/service/server/SWServerJobQueue.cpp:
3068         (WebCore::SWServerJobQueue::runRegisterJob):
3069         (WebCore::SWServerJobQueue::runUnregisterJob):
3070         (WebCore::SWServerJobQueue::runUpdateJob):
3071         * xml/XMLErrors.cpp:
3072         (WebCore::createXHTMLParserErrorHeader):
3073         (WebCore::XMLErrors::insertErrorMessageBlock):
3074         * xml/XMLHttpRequest.cpp:
3075         (WebCore::XMLHttpRequest::send):
3076         (WebCore::XMLHttpRequest::responseMIMEType const):
3077         * xml/XMLTreeViewer.cpp:
3078         (WebCore::XMLTreeViewer::transformDocumentToTreeView):
3079         * xml/XPathPredicate.cpp:
3080         (WebCore::XPath::evaluatePredicate):
3081         * xml/XPathValue.cpp:
3082         (WebCore::XPath::Value::toString const):
3083         * xml/parser/CharacterReferenceParserInlines.h:
3084         (WebCore::consumeCharacterReference):
3085
3086 2018-06-22  Youenn Fablet  <youenn@apple.com>
3087
3088         Disable WebSocket in WatchOS
3089         https://bugs.webkit.org/show_bug.cgi?id=186931
3090         <rdar://problem/39584458>
3091
3092         Reviewed by Wenson Hsieh.
3093
3094         Add a runtime flag to enable/disable WebSocket.
3095         By default, flag is on for all platforms except for WatchOS.
3096
3097         Test: fast/dom/Window/watchos/websocket/watchos/no-websocket-in-watchos.html
3098
3099         * Modules/websockets/WebSocket.idl:
3100         * page/RuntimeEnabledFeatures.cpp:
3101         (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
3102         * page/RuntimeEnabledFeatures.h:
3103         (WebCore::RuntimeEnabledFeatures::setWebSocketEnabled):
3104         (WebCore::RuntimeEnabledFeatures::webSocketEnabled const):
3105
3106 2018-06-22  Woodrow Wang  <woodrow_wang@apple.com>
3107
3108         SubresourceLoader::didFail() should only log message if state is Initialized
3109         https://bugs.webkit.org/show_bug.cgi?id=185124
3110
3111         Reviewed by Daniel Bates.
3112
3113         Functionality does not change. Moved console logging to be 
3114         after checking state of subresource loader. We only need to 
3115         log if the state is initialized. This is consistent with other
3116         functions in the file. We can also remove a null check for the 
3117         frame pointer (m_frame). The superclass ResourceLoader constructor
3118         takes an lvalue reference and initializes m_frame, ensuring
3119         m_frame cannot be null. It is only set to null by 
3120         ResourceLoader::releaseResources(), which is only called after the 
3121         resource finishes loading or fails to load. Thus, in didFail(), 
3122         m_frame must be non-null when we're logging and up until the end of the function.  
3123
3124         * loader/SubresourceLoader.cpp:
3125         (WebCore::SubresourceLoader::didFail):
3126
3127 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3128
3129         Corner of two scroll bars is white with dark mode enabled.
3130         https://bugs.webkit.org/show_bug.cgi?id=186819
3131         rdar://problem/40434350
3132
3133         Reviewed by Tim Horton.
3134
3135         * Configurations/WebCore.xcconfig:
3136         * WebCore.xcodeproj/project.pbxproj:
3137         * inspector/InspectorOverlay.cpp:
3138         (WebCore::InspectorOverlay::paint): Added LocalDefaultSystemAppearance.
3139         * page/Page.h:
3140         * platform/ScrollView.cpp:
3141         (WebCore::ScrollView::paintScrollCorner): Dropped ScrollView argument.
3142         * platform/ScrollbarTheme.h:
3143         (WebCore::ScrollbarTheme::paintScrollCorner): Ditto.
3144         * platform/ScrollbarThemeComposite.cpp:
3145         (WebCore::ScrollbarThemeComposite::paintScrollCorner): Deleted. Default is the same.
3146         * platform/ScrollbarThemeComposite.h:
3147         * platform/mac/LocalDefaultSystemAppearance.h:
3148         * platform/mac/LocalDefaultSystemAppearance.mm:
3149         (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Added recursion early return.
3150         (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): Ditto.
3151         * platform/mac/ScrollbarThemeMac.h:
3152         * platform/mac/ScrollbarThemeMac.mm:
3153         (WebCore::ScrollbarThemeMac::paintScrollCorner): Added.
3154         * rendering/RenderLayer.cpp:
3155         (WebCore::RenderLayer::paintScrollCorner): Call ScrollbarTheme::paintScrollCorner.
3156         * rendering/RenderLayerBacking.cpp:
3157         (WebCore::RenderLayerBacking::paintContents): Added LocalDefaultSystemAppearance.
3158         * rendering/RenderLayerCompositor.cpp:
3159         (WebCore::RenderLayerCompositor::paintContents): Added LocalDefaultSystemAppearance.
3160         * rendering/RenderScrollbarTheme.cpp:
3161         (WebCore::RenderScrollbarTheme::paintScrollCorner): Call ScrollbarTheme::paintScrollCorner.
3162         * rendering/RenderScrollbarTheme.h:
3163         * svg/graphics/SVGImage.cpp:
3164         (WebCore::SVGImage::draw): Added LocalDefaultSystemAppearance.
3165
3166 2018-06-22  Tim Horton  <timothy_horton@apple.com>
3167
3168         Make it possible to add a border around loading or failed-to-load images
3169         https://bugs.webkit.org/show_bug.cgi?id=186614
3170         <rdar://problem/39050152>
3171
3172         Reviewed by Zalan Bujtas.
3173
3174         Tests: http/tests/images/loading-image-border.html
3175                http/tests/images/loading-image-no-border.html
3176
3177         * rendering/RenderImage.cpp:
3178         (WebCore::RenderImage::paintIncompleteImageOutline):
3179         (WebCore::RenderImage::paintReplaced):
3180         * rendering/RenderImage.h:
3181         Factor the missing-image outline out, and - if desired - paint it in
3182         cases where the image is still loading or otherwise pending, not just
3183         when the image fails to load.
3184
3185         * page/Settings.yaml:
3186         * testing/InternalSettings.cpp:
3187         (WebCore::InternalSettings::Backup::Backup):
3188         (WebCore::InternalSettings::Backup::restoreTo):
3189         (WebCore::InternalSettings::setIncompleteImageBorderEnabled):
3190         * testing/InternalSettings.h:
3191         * testing/InternalSettings.idl:
3192         Add and expose a setting to enable the feature.
3193
3194 2018-06-22  Brady Eidson  <beidson@apple.com>
3195
3196         WKURLSchemeHandler doesn't handle sync XHR.
3197         <rdar://problem/40955884> and https://bugs.webkit.org/show_bug.cgi?id=186902
3198
3199         Reviewed by Chris Dumez.
3200
3201         * English.lproj/Localizable.strings:
3202
3203 2018-06-22  Jer Noble  <jer.noble@apple.com>
3204
3205         [Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit fullscreen handler after r231924
3206         https://bugs.webkit.org/show_bug.cgi?id=186945
3207         <rdar://problem/37277469>
3208
3209         Reviewed by Simon Fraser.
3210
3211         * platform/ios/VideoFullscreenInterfaceAVKit.mm:
3212         (VideoFullscreenInterfaceAVKit::exitFullscreen):
3213         (VideoFullscreenInterfaceAVKit::exitFullscreenHandler):
3214         (VideoFullscreenInterfaceAVKit::cleanupFullscreen):
3215
3216 2018-06-22  Per Arne Vollan  <pvollan@apple.com>
3217
3218         Unreviewed build fix on Windows.
3219
3220         * testing/Internals.h:
3221
3222 2018-06-22  Youenn Fablet  <youenn@apple.com>
3223
3224         Incoming G722 doesn't work
3225         https://bugs.webkit.org/show_bug.cgi?id=186307
3226         <rdar://problem/40809745>
3227
3228         Reviewed by Eric Carlson.
3229
3230         WebRTC backends usually does the following:
3231         - Initially call RealtimeIncomingAudioSource with 16KHz data
3232         - Switch to 48KHz when actual data is decoded.
3233         We added a check that was discarding any 16KHz data, but in case of G722, the data remains as 16KHz and is then never read.
3234         The solution is to remove the check that discards 16KHz information.
3235         We then need to fix a bug in AudioTrackPrivateMediaStreamCocoa that was preventing proper handling of change of audio data configuration.
3236
3237         Test: webrtc/audio-peer-connection-g722.html
3238
3239         * platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
3240         (WebCore::AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable):
3241         * platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:
3242         (WebCore::RealtimeIncomingAudioSourceCocoa::OnData):
3243
3244 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3245
3246         Recalc styles every time defaultAppearance changes.
3247         https://bugs.webkit.org/show_bug.cgi?id=186866
3248         rdar://problem/41309805
3249
3250         Reviewed by Tim Horton.
3251
3252         * page/Page.cpp:
3253         (WebCore::Page::setUseSystemAppearance): Added. Recalc styles and update system colors.
3254         (WebCore::Page::setDefaultAppearance): Added. Ditto.
3255         * page/Page.h:
3256         (WebCore::Page::setUseSystemAppearance): Deleted impl.
3257         (WebCore::Page::setDefaultAppearance): Deleted impl.
3258
3259 2018-06-22  Thibault Saunier  <tsaunier@igalia.com>
3260
3261         [GStreamer] Avoid sending SELECT_STREAM events when nothing changed
3262         https://bugs.webkit.org/show_bug.cgi?id=186678
3263
3264         Reviewed by Philippe Normand.
3265
3266         This avoid extra work in decodebin3 and should work around a crash
3267         in decodebin3 when we send spurious SELECT_STREAM in the mediastream
3268         layout tests.
3269
3270         GStreamer was also missing safe guards in the GstStream APIs which have been
3271         added in gstreamer core in 8833ca942ea21c58c0f63822f0e2b61695b39447
3272         "stream: Add some missing API safe guards".
3273
3274         Should fix following flakes:
3275           - fast/mediastream/MediaStream-video-element-track-stop.html
3276           - fast/mediastream/change-tracks-media-stream-being-played.html
3277
3278         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3279         (WebCore::MediaPlayerPrivateGStreamer::enableTrack):
3280
3281 2018-06-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3282
3283         REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
3284         https://bugs.webkit.org/show_bug.cgi?id=186206
3285
3286         Unreviewed manual rollout of r230950
3287
3288         * platform/graphics/texmap/TextureMapperLayer.h:
3289         * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
3290         (WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
3291
3292 2018-06-20  Darin Adler  <darin@apple.com>
3293
3294         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3295         https://bugs.webkit.org/show_bug.cgi?id=186875
3296
3297         Reviewed by Anders Carlsson.
3298
3299         * platform/cocoa/ThemeCocoa.mm:
3300         (WebCore::passKitBundle): Use isDirectory:YES when creating a URL pointing to a framework,
3301         since frameworks are directories.
3302
3303 2018-06-22  Miguel Gomez  <magomez@igalia.com>
3304
3305         [WPE][ThreadedRendering] WPE crashes rendering SVG content when using ThreadedRendering
3306         https://bugs.webkit.org/show_bug.cgi?id=186914
3307
3308         Reviewed by Carlos Garcia Campos.
3309
3310         Add GraphicsContextImpl::clipToImageBuffer() to the interface and the implementors. Forward
3311         the call to GraphicsContext::clipToImageBuffer() to the implementation if possible in the
3312         cairo case.
3313
3314         Covered by existent tests.
3315
3316         * platform/graphics/GraphicsContextImpl.h:
3317         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3318         (WebCore::GraphicsContext::clipToImageBuffer):
3319         * platform/graphics/cairo/GraphicsContextImplCairo.cpp:
3320         (WebCore::GraphicsContextImplCairo::clipToImageBuffer):
3321         * platform/graphics/cairo/GraphicsContextImplCairo.h:
3322         * platform/graphics/displaylists/DisplayListRecorder.cpp:
3323         (WebCore::DisplayList::Recorder::clipToImageBuffer):
3324         * platform/graphics/displaylists/DisplayListRecorder.h:
3325         * platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
3326         (Nicosia::CairoOperationRecorder::clipToImageBuffer):
3327         * platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
3328
3329 2018-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3330
3331         [CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
3332         https://bugs.webkit.org/show_bug.cgi?id=186911
3333
3334         Reviewed by Michael Catanzaro.
3335
3336         This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
3337         didn't start a clean build. The problem is that the CMake command to generate
3338         SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
3339         SelectorPseudoClassAndCompatibilityElementMap.in.
3340
3341         * CMakeLists.txt:
3342
3343 2018-06-22  Miguel Gomez  <magomez@igalia.com>
3344
3345         [WPE][ThreadedRendering] WPE crashes rendering some pieces of text when using ThreadedRendering
3346         https://bugs.webkit.org/show_bug.cgi?id=186886
3347
3348         Reviewed by Žan Doberšek.
3349
3350         Modify DisplayList DrawGlyphs element to use a GraphicsContext for replaying. To do so, modify
3351         GraphicsContext::drawGlyphs() API so it doesn't require a FontCascade, and update all the calls
3352         to it.
3353
3354         Covered by existent tests.
3355
3356         * platform/graphics/FontCascade.cpp:
3357         (WebCore::FontCascade::drawGlyphBuffer const):
3358         * platform/graphics/GraphicsContext.cpp:
3359         (WebCore::GraphicsContext::drawGlyphs):
3360         * platform/graphics/GraphicsContext.h:
3361         * platform/graphics/displaylists/DisplayListItems.cpp:
3362         (WebCore::DisplayList::DrawGlyphs::apply const):
3363         * rendering/mathml/MathOperator.cpp:
3364         (WebCore::MathOperator::paintGlyph):
3365         (WebCore::MathOperator::paint):
3366         * rendering/mathml/RenderMathMLToken.cpp:
3367         (WebCore::RenderMathMLToken::paint):
3368
3369 2018-06-15  Jer Noble  <jer.noble@apple.com>
3370
3371         Address fullscreen api CSS env feedback
3372         https://bugs.webkit.org/show_bug.cgi?id=186684
3373
3374         Reviewed by Simon Fraser.
3375
3376         Test: fullscreen/fullscreen-env.html
3377
3378         + Update the phishing alert text to be more explicit about the specific threats
3379           phishing sites represent.
3380         + Make the top inset static, rather than dynamic.
3381         + Add bottom, left, and right insets for completeness.
3382         + Set the fullscreen animation duration as well as delay.
3383         + Notify the page when the controls show and hide.
3384
3385         * English.lproj/Localizable.strings:
3386         * css/CSSSelector.cpp:
3387         (WebCore::CSSSelector::selectorText const):
3388         * css/CSSSelector.h:
3389         * css/SelectorChecker.cpp:
3390         (WebCore::SelectorChecker::checkOne const):
3391         * css/SelectorCheckerTestFunctions.h:
3392         (WebCore::matchesFullScreenControlsHiddenPseudoClass):
3393