Source/WebCore/ChangeLog

   1 2011-02-25  Andrey Kosyakov  <caseq@chromium.org>
   2
   3         Reviewed by Pavel Feldman.
   4
   5         Web Inspector: factor search logic out of inspector.js
   6         https://bugs.webkit.org/show_bug.cgi?id=54965
   7
   8         * WebCore.gypi:
   9         * WebCore.vcproj/WebCore.vcproj:
  10         * inspector/front-end/ElementsPanel.js:
  11         (WebInspector.ElementsPanel.prototype.searchCanceled):
  12         (WebInspector.ElementsPanel.prototype.switchToAndFocus):
  13         (WebInspector.ElementsPanel.prototype._updateMatchesCount):
  14         * inspector/front-end/Panel.js:
  15         (WebInspector.Panel.prototype.searchCanceled):
  16         (WebInspector.Panel.prototype.performSearch.updateMatchesCount):
  17         * inspector/front-end/ScriptsPanel.js:
  18         (WebInspector.ScriptsPanel.prototype.searchCanceled):
  19         (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
  20         (WebInspector.ScriptsPanel.prototype.performSearch):
  21         * inspector/front-end/SearchController.js: Added.
  22         (WebInspector.SearchController):
  23         (WebInspector.SearchController.prototype.updateSearchMatchesCount):
  24         (WebInspector.SearchController.prototype.updateSearchLabel):
  25         (WebInspector.SearchController.prototype.cancelSearch):
  26         (WebInspector.SearchController.prototype.handleShortcut):
  27         (WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
  28         (WebInspector.SearchController.prototype.activePanelChanged):
  29         (WebInspector.SearchController.prototype._updateSearchMatchesCount):
  30         (WebInspector.SearchController.prototype._focusSearchField):
  31         (WebInspector.SearchController.prototype._onSearchFieldManualFocus):
  32         (WebInspector.SearchController.prototype._onKeyDown):
  33         (WebInspector.SearchController.prototype._onSearch):
  34         (WebInspector.SearchController.prototype._performSearch):
  35         * inspector/front-end/WebKit.qrc:
  36         * inspector/front-end/inspector.html:
  37         * inspector/front-end/inspector.js:
  38         (WebInspector.set currentPanel):
  39         (WebInspector.set attached):
  40         (WebInspector.doLoadedDone):
  41         (WebInspector.documentKeyDown):
  42
  43 2011-03-02  Renata Hodovan  <reni@webkit.org>
  44
  45         Reviewed by Andreas Kling.
  46
  47         FEMorphologyElement changes doesn't require relayout
  48         https://bugs.webkit.org/show_bug.cgi?id=55462
  49
  50         When the FEMorphologyElement receives an update message but the given value remains the same we don't need
  51         to relayout the filter.
  52
  53         No new tests are needed because this modification is covered by the dynamic update tests of FEMorphology.
  54
  55         * platform/graphics/filters/FEMorphology.cpp:
  56         (WebCore::FEMorphology::setMorphologyOperator):
  57         (WebCore::FEMorphology::setRadiusX):
  58         (WebCore::FEMorphology::setRadiusY):
  59         * platform/graphics/filters/FEMorphology.h:
  60         * svg/SVGFEMorphologyElement.cpp:
  61         (WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
  62         (WebCore::SVGFEMorphologyElement::svgAttributeChanged):
  63         * svg/SVGFEMorphologyElement.h:
  64
  65 2011-03-01  Kent Tamura  <tkent@chromium.org>
  66
  67         Reviewed by Dimitri Glazkov.
  68
  69         Assertion fails when a form validation bubble appears
  70         https://bugs.webkit.org/show_bug.cgi?id=55550
  71
  72         Test: fast/forms/interactive-validation-attach-assertion.html
  73
  74         * html/ValidationMessage.cpp:
  75         (WebCore::ValidationMessage::buildBubbleTree):
  76          Just remove unnecessary attach().
  77
  78 2011-03-01  Kent Tamura  <tkent@chromium.org>
  79
  80         Reviewed by Dimitri Glazkov.
  81
  82         Support localized numbers in <input type=number>
  83         https://bugs.webkit.org/show_bug.cgi?id=42484
  84
  85         This change adds support of localized numbers in <input type=number>.
  86         This affects only the UI, and not HTMLInputElement::value.
  87
  88         - Remove the keyboard input restriction feature because it is hard to
  89           retrieve characters usable for localized numbers in ICU.
  90
  91         - Separate convertFromVisibleValue() from sanitizeValue().
  92           sanitizeValue() is used for not only converting a renderer value to a
  93           DOM value.
  94
  95         - Implement LocalizedNumber functions for ICU and NSNumberFormatter.
  96           It is used only in Chromium for now.
  97
  98         Test: manual-tests/input-number-localization.html
  99
 100         * WebCore.gypi: Use LocalizedNumberICU.cpp.
 101         * WebCore.xcodeproj/project.pbxproj:
 102           Add LocalizedNumberMac.mm and remove LocalizedNumberNone.cpp.
 103         * dom/InputElement.h: Introduce convertFromVisibleValue().
 104         * html/HTMLInputElement.cpp:
 105         (WebCore::HTMLInputElement::convertFromVisibleValue):
 106         * html/HTMLInputElement.h:
 107         * html/InputType.cpp:
 108         (WebCore::InputType::convertFromVisibleValue):
 109         * html/InputType.h:
 110         * html/NumberInputType.cpp: Remove isHTMLNumberCharacter(),
 111           isNumberCharacter(), and handleBeforeTextInsertedEvent() because we
 112           remove the keyboard input restriction feature for type=number.
 113         (WebCore::NumberInputType::convertFromVisibleValue):
 114         (WebCore::NumberInputType::sanitizeValue):
 115         * html/NumberInputType.h:
 116         * manual-tests/input-number-localization.html: Add a manual test because
 117           the behavior depends on the current locale.
 118         * platform/text/LocalizedNumber.h: Remove isLocalizedNumberCharacter().
 119         * platform/text/LocalizedNumberICU.cpp:
 120           Implement LocalizedNumber functions with ICU NumberFormat.
 121         (WebCore::createFormatterForCurrentLocale):
 122         (WebCore::parseLocalizedNumber):
 123         (WebCore::formatLocalizedNumber):
 124         * platform/text/LocalizedNumberNone.cpp: Remove isLocalizedNumberCharacter().
 125         * platform/text/mac/LocalizedNumberMac.mm:
 126           Implement LocalizedNumber functions with NSNumberFormatter.
 127         (WebCore::parseLocalizedNumber):
 128         (WebCore::formatLocalizedNumber):
 129         * rendering/RenderTextControlSingleLine.cpp:
 130         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
 131         * wml/WMLInputElement.h:
 132         (WebCore::WMLInputElement::convertFromVisibleValue):
 133           Implemented as a function doing nothing.
 134
 135 2011-03-01  Yuta Kitamura  <yutak@chromium.org>
 136
 137         Reviewed by Darin Adler.
 138
 139         REGRESSION(r78383): Failure to connect on websocketstest.com
 140         https://bugs.webkit.org/show_bug.cgi?id=54811
 141
 142         After r78383, KURL::setPort() no longer appends ":port" part
 143         if that port is the default port for URL scheme. This broke
 144         SocketStreamHandleCFNet, whose code was based on an assumption
 145         that KURL::setPort() always inserts ":port" part.
 146
 147         To fix this, KURL::port() call is removed from SocketStreamHandle
 148         and the port number is calculated on-the-fly.
 149
 150         Unfortunately it is impossible to write a test; this bug only
 151         affects WebSockets connecting to the default port (port 80
 152         for ws, port 443 for wss), while we use different ports to test
 153         WebSockets in LayoutTests.
 154
 155         * platform/network/cf/SocketStreamHandle.h:
 156         * platform/network/cf/SocketStreamHandleCFNet.cpp:
 157         (WebCore::SocketStreamHandle::SocketStreamHandle):
 158         (WebCore::SocketStreamHandle::createStreams):
 159         (WebCore::SocketStreamHandle::port):
 160
 161 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
 162
 163         Unreviewed, rolling out r80079.
 164         http://trac.webkit.org/changeset/80079
 165         https://bugs.webkit.org/show_bug.cgi?id=55547
 166
 167         "Broke the Win debug build?" (Requested by dcheng on #webkit).
 168
 169         * Configurations/FeatureDefines.xcconfig:
 170         * GNUmakefile.am:
 171         * features.pri:
 172
 173 2011-02-25  Adrienne Walker  <enne@google.com>
 174
 175         Reviewed by James Robinson.
 176
 177         [chromium] Abstract "pixels with a graphics context" into its own class
 178         https://bugs.webkit.org/show_bug.cgi?id=55259
 179
 180         This creates new PlatformCanvas/PlatformImage classes which wrap
 181         all of the #ifdef Skia/Cg warts from the compositor.  All classes
 182         (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
 183         modified to use these abstractions.
 184
 185         Tests: LayoutTests/compositing
 186
 187         * WebCore.gypi:
 188         * platform/graphics/chromium/ContentLayerChromium.cpp:
 189         (WebCore::ContentLayerChromium::updateContentsIfDirty):
 190         (WebCore::ContentLayerChromium::resizeUploadBuffer):
 191         (WebCore::ContentLayerChromium::updateTextureIfNeeded):
 192         (WebCore::ContentLayerChromium::updateTexture):
 193         (WebCore::ContentLayerChromium::draw):
 194         * platform/graphics/chromium/ContentLayerChromium.h:
 195         * platform/graphics/chromium/ImageLayerChromium.cpp:
 196         (WebCore::ImageLayerChromium::updateContentsIfDirty):
 197         (WebCore::ImageLayerChromium::updateTextureIfNeeded):
 198         * platform/graphics/chromium/ImageLayerChromium.h:
 199         * platform/graphics/chromium/LayerTilerChromium.cpp:
 200         (WebCore::LayerTilerChromium::contentRectToTileIndices):
 201         (WebCore::LayerTilerChromium::update):
 202         (WebCore::LayerTilerChromium::updateFromPixels):
 203         * platform/graphics/chromium/LayerTilerChromium.h:
 204         * platform/graphics/chromium/PlatformCanvas.cpp: Added.
 205         (WebCore::PlatformCanvas::PlatformCanvas):
 206         (WebCore::PlatformCanvas::~PlatformCanvas):
 207         (WebCore::PlatformCanvas::resize):
 208         (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
 209         (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
 210         (WebCore::PlatformCanvas::Painter::Painter):
 211         (WebCore::PlatformCanvas::Painter::~Painter):
 212         * platform/graphics/chromium/PlatformCanvas.h: Added.
 213         (WebCore::PlatformCanvas::AutoLocker::pixels):
 214         (WebCore::PlatformCanvas::Painter::context):
 215         (WebCore::PlatformCanvas::size):
 216         * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
 217         (WebCore::PlatformImage::PlatformImage):
 218         (WebCore::PlatformImage::updateFromImage):
 219         * platform/graphics/chromium/PlatformImage.h: Added.
 220         (WebCore::PlatformImage::pixels):
 221         (WebCore::PlatformImage::size):
 222
 223 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
 224
 225         Reviewed by David Levin.
 226
 227         Add feature define for data transfer items
 228         https://bugs.webkit.org/show_bug.cgi?id=55510
 229
 230         * Configurations/FeatureDefines.xcconfig:
 231         * GNUmakefile.am:
 232         * features.pri:
 233
 234 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
 235
 236         Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
 237
 238         * dom/ViewportArguments.cpp:
 239         (WebCore::computeViewportAttributes):
 240         (WebCore::numericPrefix):
 241         (WebCore::findSizeValue):
 242         (WebCore::setViewportFeature):
 243         (WebCore::viewportErrorMessageTemplate):
 244         (WebCore::viewportErrorMessageLevel):
 245         * dom/ViewportArguments.h:
 246
 247 2011-03-01  Jeremy Orlow  <jorlow@chromium.org>
 248
 249         Reviewed by James Robinson.
 250
 251         IDBKeyRange.bound() should not use the optional options object
 252         https://bugs.webkit.org/show_bug.cgi?id=55419
 253
 254         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept
 255
 256         Added some code to existing tests to cover these cases.
 257
 258         * storage/IDBKeyRange.cpp:
 259         (WebCore::IDBKeyRange::bound):
 260         * storage/IDBKeyRange.h:
 261         * storage/IDBKeyRange.idl:
 262
 263 2011-03-01  Dan Bernstein  <mitz@apple.com>
 264
 265         Build fix.
 266
 267         * dom/DocumentMarkerController.cpp:
 268         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
 269
 270 2011-03-01  Kent Tamura  <tkent@chromium.org>
 271
 272         Unreviewed. Apply sort-Xcode-project-file.
 273
 274         * WebCore.xcodeproj/project.pbxproj:
 275
 276 2011-03-01  Jeremy Orlow  <jorlow@chromium.org>
 277
 278         Reviewed by James Robinson.
 279
 280         V8 code generator doesn't properly support a single SerializedScriptValue attribute
 281         https://bugs.webkit.org/show_bug.cgi?id=55530
 282
 283         This is tested by the bindings tests changes.
 284
 285         * bindings/scripts/CodeGeneratorV8.pm:
 286         * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: Added.
 287         (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterfacePrivate::WebDOMTestSerializedScriptValueInterfacePrivate):
 288         (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterface):
 289         (WebDOMTestSerializedScriptValueInterface::operator=):
 290         (WebDOMTestSerializedScriptValueInterface::impl):
 291         (WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptValueInterface):
 292         (WebDOMTestSerializedScriptValueInterface::value):
 293         (toWebCore):
 294         (toWebKit):
 295         * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Added.
 296         * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Added.
 297         (WebKit::kit):
 298         (webkit_dom_test_serialized_script_value_interface_get_value):
 299         (WebKit::core):
 300         (webkit_dom_test_serialized_script_value_interface_finalize):
 301         (webkit_dom_test_serialized_script_value_interface_set_property):
 302         (webkit_dom_test_serialized_script_value_interface_get_property):
 303         (webkit_dom_test_serialized_script_value_interface_constructed):
 304         (webkit_dom_test_serialized_script_value_interface_class_init):
 305         (webkit_dom_test_serialized_script_value_interface_init):
 306         (WebKit::wrapTestSerializedScriptValueInterface):
 307         * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: Added.
 308         * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: Added.
 309         * bindings/scripts/test/JS/JSTestInterface.cpp:
 310         (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
 311         (WebCore::JSTestInterface::JSTestInterface):
 312         * bindings/scripts/test/JS/JSTestInterface.h:
 313         * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
 314         (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
 315         (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
 316         (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
 317         * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
 318         * bindings/scripts/test/JS/JSTestObj.cpp:
 319         (WebCore::JSTestObjConstructor::JSTestObjConstructor):
 320         (WebCore::JSTestObj::JSTestObj):
 321         (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
 322         (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
 323         (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
 324         (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
 325         (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
 326         (WebCore::jsTestObjPrototypeFunctionSerializedValue):
 327         (WebCore::jsTestObjPrototypeFunctionIdbKey):
 328         (WebCore::jsTestObjPrototypeFunctionOptionsObject):
 329         (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
 330         (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
 331         (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
 332         (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
 333         (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
 334         (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
 335         (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
 336         (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
 337         (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
 338         (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
 339         (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
 340         (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
 341         (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
 342         (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
 343         * bindings/scripts/test/JS/JSTestObj.h:
 344         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Added.
 345         (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
 346         (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
 347         (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
 348         (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
 349         (WebCore::JSTestSerializedScriptValueInterfacePrototype::self):
 350         (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
 351         (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
 352         (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
 353         (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
 354         (WebCore::jsTestSerializedScriptValueInterfaceValue):
 355         (WebCore::jsTestSerializedScriptValueInterfaceConstructor):
 356         (WebCore::JSTestSerializedScriptValueInterface::getConstructor):
 357         (WebCore::toJS):
 358         (WebCore::toTestSerializedScriptValueInterface):
 359         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h.
 360         (WebCore::JSTestSerializedScriptValueInterface::createStructure):
 361         (WebCore::JSTestSerializedScriptValueInterface::impl):
 362         (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):
 363         (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
 364         * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Added.
 365         * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Added.
 366         (-[DOMTestSerializedScriptValueInterface dealloc]):
 367         (-[DOMTestSerializedScriptValueInterface finalize]):
 368         (-[DOMTestSerializedScriptValueInterface value]):
 369         (core):
 370         (kit):
 371         * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Added.
 372         * bindings/scripts/test/TestSerializedScriptValueInterface.idl: Added.
 373         * bindings/scripts/test/V8/V8TestInterface.cpp:
 374         (WebCore::ConfigureV8TestInterfaceTemplate):
 375         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Copied from Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp.
 376         (WebCore::TestSerializedScriptValueInterfaceInternal::V8_USE):
 377         (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
 378         (WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
 379         (WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
 380         (WebCore::V8TestSerializedScriptValueInterface::HasInstance):
 381         (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
 382         (WebCore::V8TestSerializedScriptValueInterface::derefObject):
 383         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Added.
 384         (WebCore::V8TestSerializedScriptValueInterface::toNative):
 385         (WebCore::V8TestSerializedScriptValueInterface::wrap):
 386         (WebCore::toV8):
 387
 388 2011-03-01  Oliver Hunt  <oliver@apple.com>
 389
 390         Reviewed by Joseph Pecoraro.
 391
 392         Misaligned memory access in CloneDeserializer on all ARM arch.
 393         https://bugs.webkit.org/show_bug.cgi?id=48742
 394
 395         Push platforms that need aligned memory access down the
 396         endian independent serialization and deserialization
 397         paths.
 398
 399         * bindings/js/SerializedScriptValue.cpp:
 400
 401 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
 402
 403         Reviewed by Kenneth Rohde Christiansen.
 404
 405         Viewport Warning/Error Messages Are Now Inaccurate
 406         https://bugs.webkit.org/show_bug.cgi?id=53707
 407
 408         Correct and improve the error messages for viewport
 409         parsing. Clarify the difference between incorrect
 410         keys, values, and when to use the device-width or
 411         device-height constants.
 412
 413         * dom/ViewportArguments.cpp:
 414         (WebCore::computeViewportAttributes): suggest using keywords if fixed input matches device width or height.
 415         (WebCore::numericPrefix):
 416         (WebCore::findSizeValue): remove incorrect warnings about fixed numbers because we don't know the device width or height.
 417         (WebCore::setViewportFeature): report a warning for an unrecognized key.
 418         (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
 419         (WebCore::viewportErrorMessageLevel):
 420         * dom/ViewportArguments.h:
 421
 422 2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>
 423
 424         Reviewed by Darin Adler.
 425
 426         WebKit does not merge text decorations in the typing style and the selected element properly
 427         https://bugs.webkit.org/show_bug.cgi?id=55349
 428
 429         The bug was caused by EditingStyle::mergeTypingStyle's not properly merging text decoration property.
 430         Fixed the bug by extracting a function from ApplyStyleCommand::pushDownInlineStyleAroundNode and
 431         calling it in pushDownInlineStyleAroundNode and in mergeTypingStyle.
 432
 433         Test: editing/execCommand/merge-text-decoration-with-typing-style.html
 434
 435         * editing/ApplyStyleCommand.cpp:
 436         (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Takes EditingStyle*;
 437         calls mergeInlineStyleOfElement.
 438         (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls applyInlineStyleToPushDown.
 439         (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
 440         * editing/ApplyStyleCommand.h:
 441         * editing/EditingStyle.cpp:
 442         (WebCore::EditingStyle::mergeTypingStyle): Added; calls mergeStyle.
 443         (WebCore::EditingStyle::mergeInlineStyleOfElement): Ditto.
 444         (WebCore::EditingStyle::mergeStyle): Extracted from applyInlineStyleToPushDown.
 445         * editing/EditingStyle.h:
 446
 447 2011-03-01  Levi Weintraub  <leviw@chromium.org>
 448
 449         Reviewed by Ryosuke Niwa.
 450
 451         Stop instantiating legacy editing Positions in VisiblePosition
 452         https://bugs.webkit.org/show_bug.cgi?id=52919
 453
 454         Changing VisiblePosition completely away from legacy positions.
 455
 456         No new tests since this is functionaly equivalent.
 457
 458         * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
 459         adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
 460         outside of WebCore, they should be parent anchored.
 461         * accessibility/AXObjectCache.cpp:
 462         (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
 463         * accessibility/AccessibilityObject.cpp:
 464         (WebCore::startOfStyleRange):
 465         (WebCore::endOfStyleRange):
 466         * accessibility/AccessibilityRenderObject.cpp:
 467         (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
 468         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
 469         (objectAndOffsetUnignored):
 470         * dom/Position.cpp:
 471         (WebCore::Position::document): Added this inline function to avoid the necessity
 472         of calling anchorNode to assure a document from a Position.
 473         (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
 474         (WebCore::Position::downstream): ditto
 475         * dom/Range.cpp:
 476         (WebCore::Range::editingStartPosition):
 477         * editing/Editor.cpp:
 478         (WebCore::Editor::canDeleteRange):
 479         * editing/ReplaceSelectionCommand.cpp:
 480         (WebCore::ReplaceSelectionCommand::doApply):
 481         * editing/SelectionController.cpp:
 482         (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
 483         (WebCore::SelectionController::setSelectedRange):
 484         * editing/TextIterator.cpp:
 485         (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
 486         * editing/TypingCommand.cpp:
 487         (WebCore::TypingCommand::deleteKeyPressed):
 488         * editing/VisiblePosition.cpp:
 489         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
 490         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
 491         (WebCore::VisiblePosition::canonicalPosition):
 492         (WebCore::VisiblePosition::characterAfter):
 493         (WebCore::VisiblePosition::localCaretRect):
 494         (WebCore::makeRange):
 495         (WebCore::startVisiblePosition):
 496         (WebCore::endVisiblePosition):
 497         (WebCore::setStart):
 498         (WebCore::setEnd):
 499         (WebCore::isFirstVisiblePositionInNode):
 500         (WebCore::isLastVisiblePositionInNode):
 501         * editing/VisiblePosition.h:
 502         (WebCore::VisiblePosition::VisiblePosition):
 503         * editing/htmlediting.cpp:
 504         (WebCore::firstInSpecialElement):
 505         (WebCore::lastInSpecialElement):
 506         (WebCore::visiblePositionBeforeNode):
 507         (WebCore::visiblePositionAfterNode):
 508         * editing/visible_units.cpp:
 509         (WebCore::startPositionForLine):
 510         (WebCore::endPositionForLine):
 511         (WebCore::previousLinePosition):
 512         (WebCore::nextLinePosition):
 513         (WebCore::startOfParagraph):
 514         (WebCore::endOfParagraph):
 515         (WebCore::endOfBlock):
 516         (WebCore::startOfDocument):
 517         (WebCore::endOfDocument):
 518         (WebCore::logicalStartPositionForLine):
 519         (WebCore::logicalEndPositionForLine):
 520         * page/DOMSelection.cpp:
 521         (WebCore::DOMSelection::collapse):
 522         (WebCore::DOMSelection::setBaseAndExtent):
 523         (WebCore::DOMSelection::setPosition):
 524         (WebCore::DOMSelection::extend):
 525         * page/EventHandler.cpp:
 526         (WebCore::EventHandler::handleMousePressEventSingleClick):
 527         * rendering/RenderObject.cpp:
 528         (WebCore::RenderObject::createVisiblePosition):
 529         * rendering/RenderTextControl.cpp:
 530         (WebCore::RenderTextControl::visiblePositionForIndex):
 531         * svg/SVGTextContentElement.cpp:
 532         (WebCore::SVGTextContentElement::selectSubString):
 533
 534 2011-03-01  Jeremy Orlow  <jorlow@chromium.org>
 535
 536        Reviewed by Steve Block.
 537
 538        When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
 539        https://bugs.webkit.org/show_bug.cgi?id=54785
 540
 541        This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
 542        the right thing and continue to do the right thing. It also modifies EventQueue
 543        so that we can cancel an event. To do this efficiently, the vector is now a
 544        ListHashSet.
 545
 546        Cancelling the event is harder/messier, but the most deterministic thing to do.
 547        To the user, the work isn't done until we fire the onsuccess/onerror handler.
 548        So the event (which does fire that) needs to be cancelable.
 549
 550        transaction-abort.html tests this.
 551
 552        * dom/EventQueue.cpp:
 553        (WebCore::EventQueue::enqueueEvent):
 554        (WebCore::EventQueue::cancelEvent):
 555        (WebCore::EventQueue::pendingEventTimerFired):
 556        (WebCore::EventQueue::dispatchEvent):
 557        * dom/EventQueue.h:
 558        * dom/ExceptionCode.cpp:
 559        * storage/IDBCursor.cpp:
 560        (WebCore::IDBCursor::update):
 561        (WebCore::IDBCursor::deleteFunction):
 562        * storage/IDBDatabaseBackendImpl.cpp:
 563        (WebCore::IDBDatabaseBackendImpl::close):
 564        * storage/IDBDatabaseException.h:
 565        * storage/IDBIndex.cpp:
 566        (WebCore::IDBIndex::openCursor):
 567        (WebCore::IDBIndex::openKeyCursor):
 568        (WebCore::IDBIndex::get):
 569        (WebCore::IDBIndex::getKey):
 570        * storage/IDBObjectStore.cpp:
 571        (WebCore::IDBObjectStore::get):
 572        (WebCore::IDBObjectStore::add):
 573        (WebCore::IDBObjectStore::put):
 574        (WebCore::IDBObjectStore::deleteFunction):
 575        (WebCore::IDBObjectStore::clear):
 576        (WebCore::IDBObjectStore::openCursor):
 577        * storage/IDBRequest.cpp:
 578        (WebCore::IDBRequest::IDBRequest):
 579        (WebCore::IDBRequest::~IDBRequest):
 580        (WebCore::IDBRequest::readyState):
 581        (WebCore::IDBRequest::markEarlyDeath):
 582        (WebCore::IDBRequest::source):
 583        (WebCore::IDBRequest::abort):
 584        (WebCore::IDBRequest::onSuccess):
 585        (WebCore::IDBRequest::dispatchEvent):
 586        (WebCore::IDBRequest::enqueueEvent):
 587        * storage/IDBRequest.h:
 588        * storage/IDBTransaction.cpp:
 589        (WebCore::IDBTransaction::registerRequest):
 590        (WebCore::IDBTransaction::unregisterRequest):
 591        (WebCore::IDBTransaction::onAbort):
 592        * storage/IDBTransaction.h:
 593
 594 2011-03-01  Jeremy Orlow  <jorlow@chromium.org>
 595
 596         Reviewed by Mihai Parparita.
 597
 598         EventQueue needs to be ref counted
 599         https://bugs.webkit.org/show_bug.cgi?id=55512
 600
 601         EventQueue needs to be ref counted because it's possible for its instance
 602         to be deleted while it's dispatching events. This is the reason why
 603         https://bugs.webkit.org/show_bug.cgi?id=54785 had to be reverted.
 604
 605         No change of behavior, so no tests.
 606
 607         * dom/Document.h:
 608         * dom/EventQueue.cpp:
 609         (WebCore::EventQueue::create):
 610         * dom/EventQueue.h:
 611
 612 2011-03-01  Helder Correia  <helder@sencha.com>
 613
 614         Reviewed by Simon Fraser.
 615
 616         No shadow when stroking a path with a gradient
 617         https://bugs.webkit.org/show_bug.cgi?id=55436
 618
 619         This happens in CG and is related to bug 52509, this time to be fixed
 620         in GraphicsContext::strokePath(). The gradient needs to be drawn
 621         clipped to the stroke on a CGLayer first, then the layer drawn on the
 622         GraphicsContext.
 623
 624         Tests: fast/canvas/canvas-strokePath-gradient-shadow.html
 625                svg/css/path-gradient-stroke-shadow.svg
 626
 627         * platform/graphics/cg/GraphicsContextCG.cpp:
 628         (WebCore::GraphicsContext::strokePath):
 629
 630 2011-03-01  David Hyatt  <hyatt@apple.com>
 631
 632         Reviewed by Dan Bernstein.
 633
 634         Fix Font::spaceWidth() to be a float instead of an int.
 635
 636         * platform/graphics/Font.h:
 637         (WebCore::Font::spaceWidth):
 638
 639 2011-02-28  Steve Block  <steveblock@google.com>
 640
 641         Reviewed by Jeremy Orlow.
 642
 643         Chromium gypi file should include Java bridge files from WebCore/bridge
 644         https://bugs.webkit.org/show_bug.cgi?id=55387
 645
 646         No new tests, no code changes.
 647
 648         * WebCore.gyp/WebCore.gyp:
 649         * WebCore.gypi:
 650
 651 2011-03-01  James Simonsen  <simonjam@chromium.org>
 652
 653         Reviewed by Tony Gentilcore.
 654
 655         [Web Timing] Handle the case where no responseEnd time is available.
 656         https://bugs.webkit.org/show_bug.cgi?id=55444
 657
 658         * loader/MainResourceLoader.cpp:
 659         (WebCore::MainResourceLoader::MainResourceLoader): Initialize to 0.
 660         (WebCore::MainResourceLoader::didFinishLoading): Fall back to current time if no other time is available.
 661
 662 2011-03-01  Patrick Gansterer  <paroga@webkit.org>
 663
 664         Unreviewed, adding missing change for r80034.
 665
 666         Add a handler class for Win32 HANDLE
 667         https://bugs.webkit.org/show_bug.cgi?id=55334
 668
 669         * platform/win/Win32Handle.h: Added missing WTF_MAKE_NONCOPYABLE macro.
 670
 671 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
 672
 673         Unreviewed, rolling out r80037.
 674         http://trac.webkit.org/changeset/80037
 675         https://bugs.webkit.org/show_bug.cgi?id=55508
 676
 677         broke compile on SL (Requested by tonyg-cr on #webkit).
 678
 679         * Android.mk:
 680         * CMakeLists.txt:
 681         * GNUmakefile.am:
 682         * WebCore.gypi:
 683         * WebCore.pro:
 684         * WebCore.vcproj/WebCore.vcproj:
 685         * WebCore.xcodeproj/project.pbxproj:
 686         * css/CSSParser.cpp:
 687         (WebCore::CSSParser::parseValue):
 688         * css/CSSParser.h:
 689         * css/CSSStyleSelector.cpp:
 690         (WebCore::CSSStyleSelector::applyProperty):
 691         * css/html.css:
 692         (q:before):
 693         (q:after):
 694         * rendering/RenderBlockLineLayout.cpp:
 695         (WebCore::dirtyLineBoxesForRenderer):
 696         * rendering/RenderObject.h:
 697         * rendering/RenderObjectChildList.cpp:
 698         (WebCore::RenderObjectChildList::removeChildNode):
 699         (WebCore::RenderObjectChildList::appendChildNode):
 700         (WebCore::RenderObjectChildList::insertChildNode):
 701         (WebCore::RenderObjectChildList::updateBeforeAfterContent):
 702         * rendering/RenderQuote.cpp: Removed.
 703         * rendering/RenderQuote.h: Removed.
 704         * rendering/RenderingAllInOne.cpp:
 705         * rendering/style/ContentData.cpp:
 706         (WebCore::ContentData::dataEquivalent):
 707         (WebCore::ContentData::deleteContent):
 708         * rendering/style/ContentData.h:
 709         * rendering/style/QuotesData.cpp: Removed.
 710         * rendering/style/QuotesData.h: Removed.
 711         * rendering/style/RenderStyle.cpp:
 712         * rendering/style/RenderStyle.h:
 713         * rendering/style/RenderStyleConstants.h:
 714         * rendering/style/StyleAllInOne.cpp:
 715         * rendering/style/StyleRareInheritedData.cpp:
 716         (WebCore::StyleRareInheritedData::operator==):
 717         * rendering/style/StyleRareInheritedData.h:
 718
 719 2011-03-01  Abhishek Arya  <inferno@chromium.org>
 720
 721         Reviewed by Dave Hyatt.
 722
 723         Paint outline for tables.
 724         https://bugs.webkit.org/show_bug.cgi?id=55474
 725
 726         Test: fast/table/table-and-parts-outline.html
 727
 728         * rendering/RenderTable.cpp:
 729         (WebCore::RenderTable::paintObject):
 730
 731 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
 732
 733         Unreviewed, rolling out r80028.
 734         http://trac.webkit.org/changeset/80028
 735         https://bugs.webkit.org/show_bug.cgi?id=55502
 736
 737         'caused crashes; rolling out while investigating' (Requested
 738         by jorlow on #webkit).
 739
 740         * dom/EventQueue.cpp:
 741         (WebCore::EventQueue::enqueueEvent):
 742         (WebCore::EventQueue::pendingEventTimerFired):
 743         (WebCore::EventQueue::dispatchEvent):
 744         * dom/EventQueue.h:
 745         * dom/ExceptionCode.cpp:
 746         * storage/IDBCursor.cpp:
 747         (WebCore::IDBCursor::update):
 748         (WebCore::IDBCursor::deleteFunction):
 749         * storage/IDBDatabaseException.h:
 750         * storage/IDBDatabaseException.idl:
 751         * storage/IDBIndex.cpp:
 752         (WebCore::IDBIndex::openCursor):
 753         (WebCore::IDBIndex::openKeyCursor):
 754         (WebCore::IDBIndex::get):
 755         (WebCore::IDBIndex::getKey):
 756         * storage/IDBObjectStore.cpp:
 757         (WebCore::IDBObjectStore::get):
 758         (WebCore::IDBObjectStore::add):
 759         (WebCore::IDBObjectStore::put):
 760         (WebCore::IDBObjectStore::deleteFunction):
 761         (WebCore::IDBObjectStore::clear):
 762         (WebCore::IDBObjectStore::openCursor):
 763         * storage/IDBRequest.cpp:
 764         (WebCore::IDBRequest::IDBRequest):
 765         (WebCore::IDBRequest::~IDBRequest):
 766         (WebCore::IDBRequest::readyState):
 767         (WebCore::IDBRequest::dispatchEvent):
 768         (WebCore::IDBRequest::enqueueEvent):
 769         (WebCore::IDBRequest::source):
 770         * storage/IDBRequest.h:
 771         * storage/IDBTransaction.cpp:
 772         (WebCore::IDBTransaction::onAbort):
 773         * storage/IDBTransaction.h:
 774
 775 2011-03-01  Carol Szabo  <carol.szabo@nokia.com>
 776
 777         Reviewed by David Hyatt  <hyatt@apple.com>
 778
 779         content property doesn't support quotes
 780         https://bugs.webkit.org/show_bug.cgi?id=6503
 781
 782         Added full support for quotes as defined by CSS 2.1.
 783
 784         Tests: fast/css/content/content-quotes-01.html
 785                fast/css/content/content-quotes-02.html
 786                fast/css/content/content-quotes-03.html
 787                fast/css/content/content-quotes-04.html
 788                fast/css/content/content-quotes-05.html
 789
 790         * Android.mk:
 791         * CMakeLists.txt:
 792         * GNUmakefile.am:
 793         * WebCore.pro:
 794         * WebCore.vcproj/WebCore.vcproj:
 795         * WebCore.xcodeproj/project.pbxproj:
 796         Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
 797         * css/CSSParser.cpp:
 798         (WebCore::CSSParser::parseValue):
 799         (WebCore::CSSParser::parseQuotes):
 800         * css/CSSParser.h:
 801         Added needed stylesheet parsing support for quotes,
 802         (no-)open-quote and (no-)close-quote
 803         * css/CSSStyleSelector.cpp:
 804         (WebCore::CSSStyleSelector::applyProperty):
 805         Handled setting of the new quotes RenderStyle property and added
 806         handling of quotes for the content property.
 807         * css/html.css:
 808         (q:before):
 809         (q:after):
 810         replaced the '"' workaround with open/close-quote
 811         * rendering/RenderBlockLineLayout.cpp:
 812         (WebCore::dirtyLineBoxesForRenderer):
 813         Made RenderQuote behave like RenderCounter.
 814         Needed to ensure that the Quote text is calculated before layout,
 815         just as it is for RenderCounter.
 816         * rendering/RenderObject.h:
 817         (WebCore::RenderObject::isQuote):
 818         * rendering/RenderObjectChildList.cpp:
 819         (WebCore::RenderObjectChildList::removeChildNode):
 820         (WebCore::RenderObjectChildList::appendChildNode):
 821         (WebCore::RenderObjectChildList::insertChildNode):
 822         Handled updating of quote depth when renderers are added and removed
 823         from the tree.
 824         (WebCore::RenderObjectChildList::updateBeforeAfterContent):
 825         * rendering/RenderQuote.cpp: Added.
 826         (WebCore::adjustDepth):
 827         (WebCore::RenderQuote::RenderQuote):
 828         (WebCore::RenderQuote::~RenderQuote):
 829         (WebCore::RenderQuote::renderName):
 830         (WebCore::RenderQuote::placeQuote):
 831         (WebCore::RenderQuote::originalText):
 832         (WebCore::RenderQuote::computePreferredLogicalWidths):
 833         (WebCore::RenderQuote::rendererSubtreeAttached):
 834         (WebCore::RenderQuote::rendererRemovedFromTree):
 835         (WebCore::RenderQuote::styleDidChange):
 836         * rendering/RenderQuote.h: Added.
 837         (WebCore::RenderQuote::isQuote):
 838         (WebCore::toRenderQuote):
 839         * rendering/RenderingAllInOne.cpp:
 840         Included RenderQuote.cpp
 841         * rendering/style/StyleAllInOne.cpp:
 842         Included QuotesData.cpp
 843         * rendering/style/ContentData.cpp:
 844         (WebCore::ContentData::dataEquivalent):
 845         Checked for quotetype identity.
 846         (WebCore::ContentData::deleteContent):
 847         Accounted for the new QUOTE_TYPE.
 848         * rendering/style/ContentData.h:
 849         (WebCore::ContentData::isQuote):
 850         (WebCore::ContentData::quote):
 851         (WebCore::ContentData::setQuote):
 852         * rendering/style/RenderStyle.cpp:
 853         (WebCore::RenderStyle::setContent):
 854         * rendering/style/RenderStyle.h:
 855         (WebCore::InheritedFlags::quotes):
 856         (WebCore::InheritedFlags::setQuotes):
 857         * rendering/style/RenderStyleConstants.h:
 858         * rendering/style/StyleRareInheritedData.cpp:
 859         (WebCore::StyleRareInheritedData::operator==):
 860         Included quotes in equality check.
 861         * rendering/style/StyleRareInheritedData.h:
 862         Added quotes
 863
 864 2011-03-01  Michael Nordman  <michaeln@google.com>
 865
 866         Reviewed by Alexey Proskuryakov.
 867
 868         Alter the relative priorities of network vs fallback namespaces in the appcache.
 869         If a resource url is in an appcache's network namespace and fallback namespace, the network
 870         namespace wins (with the exception of the special '*' network namespace which does not take
 871         priority over the fallback namespace.
 872         https://bugs.webkit.org/show_bug.cgi?id=49292
 873
 874         Test: http/tests/appcache/online-fallback-layering.html
 875
 876         * loader/appcache/ApplicationCache.cpp:
 877         (WebCore::ApplicationCache::isURLInOnlineWhitelist):
 878         * loader/appcache/ApplicationCacheHost.cpp:
 879         (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
 880         (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):
 881         * loader/appcache/ApplicationCacheStorage.cpp:
 882         (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
 883
 884 2011-03-01  Patrick Gansterer  <paroga@webkit.org>
 885
 886         Reviewed by Adam Roben.
 887
 888         Add a handler class for Win32 HANDLE
 889         https://bugs.webkit.org/show_bug.cgi?id=55334
 890
 891         This class will call CloseHandle in the destructor for valid handles.
 892
 893         * platform/win/Win32Handle.h: Added.
 894
 895 2011-03-01  Eric Carlson  <eric.carlson@apple.com>
 896
 897         Reviewed by Chris Marrin.
 898
 899         <audio> and <video> should respect private browsing mode
 900         https://bugs.webkit.org/show_bug.cgi?id=55287
 901         <rdar://problem/9057699>
 902
 903         No new tests, this is just the plumbing.
 904
 905         * dom/Document.cpp:
 906         (WebCore::Document::privateBrowsingStateDidChange): New.
 907         (WebCore::Document::registerForPrivateBrowsingStateChangedCallbacks): Ditto.
 908         (WebCore::Document::unregisterForPrivateBrowsingStateChangedCallbacks): Ditto.
 909         * dom/Document.h:
 910
 911         * dom/Element.h:
 912         (WebCore::Element::privateBrowsingStateDidChange): New.
 913
 914         * html/HTMLMediaElement.cpp:
 915         (WebCore::HTMLMediaElement::HTMLMediaElement): Register for privacy mode changes.
 916         (WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for privacy mode changes.
 917         (WebCore::HTMLMediaElement::loadResource): Tell player current privacy mode.
 918         (WebCore::HTMLMediaElement::privateBrowsingStateDidChange):  New, call through to MediaPlayer.
 919         * html/HTMLMediaElement.h:
 920
 921         * page/Page.cpp:
 922         (WebCore::Page::privateBrowsingStateChanged): Call document()->privateBrowsingStateDidChange.
 923
 924         * platform/graphics/MediaPlayer.cpp:
 925         (WebCore::MediaPlayer::setPrivateBrowsingMode): New, call through to media engine.
 926         * platform/graphics/MediaPlayer.h:
 927
 928         * platform/graphics/MediaPlayerPrivate.h:
 929         (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):  Declare new interface.
 930
 931 2011-03-01  Jeremy Orlow  <jorlow@chromium.org>
 932
 933         Reviewed by Steve Block.
 934
 935         When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
 936         https://bugs.webkit.org/show_bug.cgi?id=54785
 937
 938         This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
 939         the right thing and continue to do the right thing. It also modifies EventQueue
 940         so that we can cancel an event. To do this efficiently, the vector is now a
 941         ListHashSet.
 942
 943         Canelling the event is harder/messier, but the most deterministic thing to do.
 944         To the user, the work isn't done until we fire the onsuccess/onerror handler.
 945         So the event (which does fire that) needs to be cancelable.
 946
 947         transaction-abort.html tests this.
 948
 949         * dom/EventQueue.cpp:
 950         (WebCore::EventQueue::enqueueEvent):
 951         (WebCore::EventQueue::cancelEvent):
 952         (WebCore::EventQueue::pendingEventTimerFired):
 953         (WebCore::EventQueue::dispatchEvent):
 954         * dom/EventQueue.h:
 955         * dom/ExceptionCode.cpp:
 956         * storage/IDBCursor.cpp:
 957         (WebCore::IDBCursor::update):
 958         (WebCore::IDBCursor::deleteFunction):
 959         * storage/IDBDatabaseBackendImpl.cpp:
 960         (WebCore::IDBDatabaseBackendImpl::close):
 961         * storage/IDBDatabaseException.h:
 962         * storage/IDBIndex.cpp:
 963         (WebCore::IDBIndex::openCursor):
 964         (WebCore::IDBIndex::openKeyCursor):
 965         (WebCore::IDBIndex::get):
 966         (WebCore::IDBIndex::getKey):
 967         * storage/IDBObjectStore.cpp:
 968         (WebCore::IDBObjectStore::get):
 969         (WebCore::IDBObjectStore::add):
 970         (WebCore::IDBObjectStore::put):
 971         (WebCore::IDBObjectStore::deleteFunction):
 972         (WebCore::IDBObjectStore::clear):
 973         (WebCore::IDBObjectStore::openCursor):
 974         * storage/IDBRequest.cpp:
 975         (WebCore::IDBRequest::IDBRequest):
 976         (WebCore::IDBRequest::~IDBRequest):
 977         (WebCore::IDBRequest::readyState):
 978         (WebCore::IDBRequest::markEarlyDeath):
 979         (WebCore::IDBRequest::source):
 980         (WebCore::IDBRequest::abort):
 981         (WebCore::IDBRequest::onSuccess):
 982         (WebCore::IDBRequest::dispatchEvent):
 983         (WebCore::IDBRequest::enqueueEvent):
 984         * storage/IDBRequest.h:
 985         * storage/IDBTransaction.cpp:
 986         (WebCore::IDBTransaction::registerRequest):
 987         (WebCore::IDBTransaction::unregisterRequest):
 988         (WebCore::IDBTransaction::onAbort):
 989         * storage/IDBTransaction.h:
 990
 991 2011-03-01  Jeremy Orlow  <jorlow@chromium.org>
 992
 993         Reviewed by Steve Block.
 994
 995         Only IndexedDB's error event should be cancelable
 996         https://bugs.webkit.org/show_bug.cgi?id=55413
 997
 998         * storage/IDBRequest.cpp:
 999         (WebCore::createSuccessEvent):
1000         * storage/IDBTransaction.cpp:
1001         (WebCore::IDBTransaction::onAbort):
1002         (WebCore::IDBTransaction::onComplete):
1003
1004 2011-03-01  Jia Pu  <jpu@apple.com>
1005
1006         Reviewed by Darin Adler.
1007
1008         Remove CorrectionIndicator markers sooner.
1009         https://bugs.webkit.org/show_bug.cgi?id=54893
1010         <rdar://problem/8997524>
1011
1012         Test: platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html
1013
1014         This patch changes the autocorrection behavior on Mac OS X. We want to remove CorrectionIndicator
1015         marker after any editing command if the command:
1016         1. is not a SpellingCorrectionCommand itself.
1017         2. is not the command that triggers the autocorrection.
1018         This is achieved by adding shouldRetainAutocorrectionIndicator() function to EditCommand. This function returns
1019         false for all commands derived from EditCommand, except SpellingCorrectionCommand and TypingCommand. This function
1020         always returns true for SpellingCorrectionCommand. For TypingCommand, the return value is determined by member
1021         variable m_shouldRetainAutocorrectionIndicator, which can be modified by passing option into the TypingCommand's
1022         public functions.
1023
1024         To avoid constantly searching marker list, we use variable DocumentMarkerController::m_absentMarkerTypeCache
1025         to cache whether there is any marker of a particular type.
1026
1027         This patch also fixes two minor existing bugs.
1028
1029         1. We used to show reversion panel for word with CorrectionIndicator marker. This is incorrect because
1030         CorrectionIndicator marker can be removed from corrected words. Since all autocorrected words have Replacement
1031         marker unless the whole word is deleted, the correct behavior is to show reversion panel for word with Replacement
1032         marker, since all autocorrected words have such marker. However, since we don't want to show the reversion panel
1033         if an autocorrected word has been edited, we also check to see if the Replacement marker's description is null.
1034
1035         This works as following:
1036         When we apply an autocorrection, we add Replacement marker to corrected word, and store original word
1037         as the marker's description. If the user edited the corrected word afterward, we set description to null.
1038         So when we decide whether to show a reversion panel, we not only check for the existence of Replacement
1039         marker, but also check if description is null.
1040
1041         2. Fixed an assertion violation in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited(), which would
1042         occur when deleting the first character in an editable area.
1043
1044         * dom/DocumentMarker.h: Added m_possiblyExistingMarkerTypes to allow quickly checking whether a marker type is
1045            completely in from the document.
1046
1047         * dom/DocumentMarkerController.cpp: Most of the functions listed here are optimized for early return by checking
1048            the return value of possiblyHasMarkers() at beginning.
1049         (WebCore::DocumentMarkerController::possiblyHasMarkers):
1050         (WebCore::DocumentMarkerController::DocumentMarkerController):
1051         (WebCore::DocumentMarkerController::detach):
1052         (WebCore::DocumentMarkerController::removeMarkers):
1053         (WebCore::DocumentMarkerController::addMarker):
1054         (WebCore::DocumentMarkerController::copyMarkers):
1055         (WebCore::DocumentMarkerController::markerContainingPoint):
1056         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1057         (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
1058         (WebCore::DocumentMarkerController::repaintMarkers):
1059         (WebCore::DocumentMarkerController::shiftMarkers):
1060         (WebCore::DocumentMarkerController::setMarkersActive):
1061         (WebCore::DocumentMarkerController::hasMarkers):
1062         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1063         * dom/DocumentMarkerController.h:
1064         * editing/EditCommand.cpp:
1065         (WebCore::EditCommand::apply):
1066         (WebCore::EditCommand::shouldRetainAutocorrectionIndicator):
1067         (WebCore::EditCommand::setShouldRetainAutocorrectionIndicator):
1068         * editing/EditCommand.h:
1069         * editing/Editor.cpp:
1070         (WebCore::Editor::respondToChangedSelection):
1071         (WebCore::Editor::appliedEditing):
1072         (WebCore::Editor::insertTextWithoutSendingTextEvent):
1073         (WebCore::Editor::insertLineBreak):
1074         (WebCore::Editor::insertParagraphSeparator):
1075         (WebCore::Editor::markMisspellingsAfterTypingToWord):
1076         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
1077         (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
1078         (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
1079         * editing/Editor.h:
1080         * editing/EditorCommand.cpp:
1081         (WebCore::executeInsertLineBreak):
1082         (WebCore::executeInsertParagraph):
1083         (WebCore::executeInsertText):
1084         * editing/SpellingCorrectionCommand.cpp:
1085         (WebCore::SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator):
1086         * editing/SpellingCorrectionCommand.h:
1087         * editing/TypingCommand.cpp:
1088         (WebCore::TypingCommand::TypingCommand):
1089         (WebCore::TypingCommand::deleteSelection):
1090         (WebCore::TypingCommand::deleteKeyPressed):
1091         (WebCore::TypingCommand::forwardDeleteKeyPressed):
1092         (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection):
1093         (WebCore::TypingCommand::insertText):
1094         (WebCore::TypingCommand::insertLineBreak):
1095         (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
1096         (WebCore::TypingCommand::insertParagraphSeparator):
1097         * editing/TypingCommand.h:
1098         (WebCore::TypingCommand::create):
1099         (WebCore::TypingCommand::shouldRetainAutocorrectionIndicator):
1100         (WebCore::TypingCommand::setShouldRetainAutocorrectionIndicator):
1101         * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html:
1102
1103 2011-03-01  Renata Hodovan  <reni@webkit.org>
1104
1105         Reviewed by Andreas Kling.
1106
1107         FEDisplacementMapElement changes doesn't require relayout
1108         https://bugs.webkit.org/show_bug.cgi?id=55454
1109
1110         When the FEDisplacementMapElement receives an update message but the given value remains the same we don't need
1111         to relayout the filter.
1112
1113         No new tests are needed because this modification is covered by the dynamic update tests of FEDisplacementMap.
1114
1115         * platform/graphics/filters/FEDisplacementMap.cpp:
1116         (WebCore::FEDisplacementMap::setXChannelSelector):
1117         (WebCore::FEDisplacementMap::setYChannelSelector):
1118         (WebCore::FEDisplacementMap::setScale):
1119         * platform/graphics/filters/FEDisplacementMap.h:
1120         * svg/SVGFEDisplacementMapElement.cpp:
1121         (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute):
1122         (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
1123         * svg/SVGFEDisplacementMapElement.h:
1124
1125 2011-03-01  Dan Bernstein  <mitz@apple.com>
1126
1127         Reviewed by Darin Adler.
1128
1129         <rdar://problem/8902714> Expand ruby text when it is shorter than the ruby base
1130         https://bugs.webkit.org/show_bug.cgi?id=55487
1131
1132         * css/html.css:
1133         (ruby > rt): Changed the default text-align value to -webkit-auto to signal
1134         the default expansion behavior.
1135         * rendering/RenderBlock.h:
1136         (WebCore::RenderRubyText::textAlignmentForLine): Made protected.
1137         (WebCore::RenderBlock::adjustInlineDirectionLineBounds): Made protected.
1138         * rendering/RenderRubyText.cpp:
1139         (WebCore::RenderRubyText::textAlignmentForLine): Added. If text-align is
1140         -webkit-auto, returns JUSTIFY to allow expansion.
1141         (WebCore::RenderRubyText::adjustInlineDirectionLineBounds): Added. If
1142         text-align is -webkit-auto, insets the line such that the inset on each side
1143         is the half the inter-ideograph expansion, or one ruby character wide,
1144         whichever is smaller.
1145         * rendering/RenderRubyText.h:
1146
1147 2011-03-01  Sam Weinig  <sam@webkit.org>
1148
1149         Reviewed by Timothy Hatcher.
1150
1151         WebKit2 needs to be made localizable
1152         https://bugs.webkit.org/show_bug.cgi?id=55483
1153
1154         * English.lproj/Localizable.strings: Copied from Source/WebKit/English.lproj/Localizable.strings.
1155         * WebCore.xcodeproj/project.pbxproj:
1156         Move Localizable.strings to WebCore.
1157
1158         * WebCore.exp.in:
1159         Add export for localizedString function.
1160
1161         * platform/LocalizedStrings.h:
1162         * platform/mac/LocalizedStringsMac.mm: Added.
1163         Add function to get localized version of a string from the WebCore bundle.
1164
1165 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
1166
1167         Reviewed by Timothy Hatcher.
1168
1169         All Console Messages should be passed to ChromeClients.
1170         https://bugs.webkit.org/show_bug.cgi?id=54926
1171
1172         Do not filter the message type here, allow clients
1173         to filter and deal with the different message types.
1174
1175         * page/Console.cpp:
1176         (WebCore::Console::addMessage):
1177
1178 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
1179
1180         Reviewed by Kenneth Rohde Christiansen.
1181
1182         Viewport parsing no longer accepts "1.0;" value as valid.
1183         https://bugs.webkit.org/show_bug.cgi?id=53705
1184
1185         When parsing numeric values, the "css-viewport" spec says
1186         to use the number prefix, and the non numeric part of the
1187         string can be ignored. This matches our behavior before
1188         r67376. The change was that checking the error out condition
1189         of String::toFloat doesn't necessarily mean that there
1190         was a non-numeric prefix. This patch checks if there was
1191         or wasn't a non-numeric prefix.
1192
1193         There is a console warning in any case where a numeric
1194         value is not parsed cleanly. There is an error warning
1195         when it is not a number at all, and a tip warning when
1196         it has been truncated.
1197
1198         Error messages are slightly improved to provide more
1199         context, both the key and value, when an error happens.
1200
1201         Test: fast/viewport/viewport-129.html
1202
1203         * dom/ViewportArguments.cpp:
1204         (WebCore::numericPrefix):
1205         (WebCore::findSizeValue):
1206         (WebCore::findScaleValue):
1207         (WebCore::findUserScalableValue):
1208         (WebCore::findTargetDensityDPIValue):
1209         (WebCore::viewportErrorMessageTemplate):
1210         (WebCore::viewportErrorMessageLevel):
1211         (WebCore::reportViewportWarning):
1212         * dom/ViewportArguments.h:
1213
1214 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
1215
1216         Reviewed by Pavel Feldman.
1217
1218         Web Inspector: InjectedScript.setPropertyValue doesn't work.
1219         https://bugs.webkit.org/show_bug.cgi?id=55475
1220
1221         * inspector/InjectedScript.cpp:
1222         (WebCore::InjectedScript::setPropertyValue):
1223
1224 2011-03-01  Steve Block  <steveblock@google.com>
1225
1226         Reviewed by Jeremy Orlow.
1227
1228         Remove unused JavaString::uchars()
1229         https://bugs.webkit.org/show_bug.cgi?id=55465
1230
1231         No new tests, removing dead code only.
1232
1233         * bridge/jni/JNIBridge.h:
1234         * bridge/jni/jsc/JavaStringJSC.h:
1235         (JSC::Bindings::JavaStringImpl::utf8):
1236         * bridge/jni/v8/JavaStringV8.h:
1237
1238 2011-03-01  Alexander Pavlov  <apavlov@chromium.org>
1239
1240         Reviewed by Yury Semikhatsky.
1241
1242         Web Inspector: Extremely slow DOM search in GMail
1243         https://bugs.webkit.org/show_bug.cgi?id=55456
1244
1245         The solution comprises three major parts:
1246         - avoid multiple invocations of highlightSearchResults(), one per each nodeIds chunk.
1247         - cache highlighted node's innerHTML so that no extra _nodeTitleInfo() calls will be needed.
1248         - replace hand-written Text nodes iteration with a snapshot-based ".//text()" XPathResult.
1249
1250         * inspector/front-end/ElementsPanel.js:
1251         (WebInspector.ElementsPanel.prototype.searchCanceled):
1252         (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
1253         * inspector/front-end/ElementsTreeOutline.js:
1254         (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
1255         (WebInspector.ElementsTreeElement.prototype.updateTitle):
1256         ():
1257         * inspector/front-end/utilities.js:
1258         ():
1259
1260 2011-03-01  Adam Roben  <aroben@apple.com>
1261
1262         Fix multiple-definition linker warnings introduced by r79978 on Windows
1263
1264         * rendering/RenderingAllInOne.cpp: Removed TextControlInnerElements.cpp, as it is now being
1265         compiled separately.
1266
1267 2011-03-01  Andras Becsi  <abecsi@webkit.org>
1268
1269         Reviewed by Csaba Osztrogonác.
1270
1271         [Qt] Clean up the project files and move common options to WebKit.pri.
1272
1273         No new tests needed.
1274
1275         * WebCore.pri: Move common options to WebKit.pri.
1276         * WebCore.pro: Ditto.
1277
1278 2011-03-01  Steve Block  <steveblock@google.com>
1279
1280         Reviewed by Pavel Feldman.
1281
1282         JNI code in Java bridge is not correctly guarded
1283         https://bugs.webkit.org/show_bug.cgi?id=55459
1284
1285         No new tests, build fix only.
1286
1287         * bridge/jni/v8/JNIBridgeV8.cpp:
1288         * bridge/jni/v8/JNIBridgeV8.h:
1289         * bridge/jni/v8/JNIUtilityPrivate.cpp:
1290         * bridge/jni/v8/JNIUtilityPrivate.h:
1291         * bridge/jni/v8/JavaClassV8.cpp:
1292         * bridge/jni/v8/JavaClassV8.h:
1293         * bridge/jni/v8/JavaInstanceV8.cpp:
1294         * bridge/jni/v8/JavaInstanceV8.h:
1295         * bridge/jni/v8/JavaNPObjectV8.cpp:
1296         * bridge/jni/v8/JavaNPObjectV8.h:
1297
1298 2011-03-01  Steve Block  <steveblock@google.com>
1299
1300         Reviewed by Jeremy Orlow.
1301
1302         Bridge.h should not include BridgeJSC.h
1303         https://bugs.webkit.org/show_bug.cgi?id=55212
1304
1305         Instead, BridgeJSC.h should include Bridge.h and code should include
1306         BridgeJSC.h as appropriate.
1307
1308         This prevents ports that use V8 from having to include JSC-specific
1309         files, even if the contents of those files are guarded.
1310
1311         No new tests, cleanup only.
1312
1313         * bindings/js/JSPluginElementFunctions.cpp:
1314         * bindings/js/ScriptControllerBrew.cpp:
1315         * bindings/js/ScriptControllerGtk.cpp:
1316         * bindings/js/ScriptControllerHaiku.cpp:
1317         * bindings/js/ScriptControllerQt.cpp:
1318         * bindings/js/ScriptControllerMac.mm:
1319         * bindings/js/ScriptControllerWin.cpp:
1320         * bindings/js/ScriptControllerWx.cpp:
1321         * bindings/js/ScriptInstance.h:
1322         * bindings/objc/WebScriptObject.mm:
1323         * bridge/Bridge.h:
1324         * bridge/c/c_class.h:
1325         * bridge/c/c_instance.h:
1326         * bridge/c/c_runtime.h:
1327         * bridge/jni/jsc/JNIBridgeJSC.h:
1328         * bridge/jni/jsc/JavaInstanceJSC.h:
1329         * bridge/jsc/BridgeJSC.h:
1330         * bridge/objc/objc_runtime.h:
1331         * bridge/qt/qt_class.h:
1332         * bridge/qt/qt_instance.h:
1333         * bridge/qt/qt_pixmapruntime.h:
1334         * bridge/qt/qt_runtime.h:
1335         * bridge/runtime_array.h:
1336         * bridge/runtime_method.h:
1337         * bridge/runtime_object.h:
1338         * bridge/runtime_root.cpp:
1339         * bridge/testbindings.cpp:
1340         * bridge/testbindings.mm:
1341         * bridge/testqtbindings.cpp:
1342         * page/win/FrameWin.cpp:
1343         * platform/graphics/wince/MediaPlayerProxy.cpp:
1344         * plugins/PluginView.cpp:
1345         * plugins/PluginViewNone.cpp:
1346         * plugins/gtk/PluginViewGtk.cpp:
1347         * plugins/mac/PluginViewMac.mm:
1348         * plugins/qt/PluginViewQt.cpp:
1349         * plugins/symbian/PluginViewSymbian.cpp:
1350         * plugins/win/PluginViewWin.cpp:
1351
1352 2011-03-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1353
1354         Reviewed by Antti Koivisto.
1355
1356         SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
1357         https://bugs.webkit.org/show_bug.cgi?id=54800
1358
1359         Wrong handling of currentColor on inherit
1360         https://bugs.webkit.org/show_bug.cgi?id=38102
1361
1362         Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
1363         two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
1364         It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
1365         once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
1366         accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
1367         type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).
1368
1369         <g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
1370         <g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.
1371
1372         In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
1373         as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
1374         when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
1375         available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
1376         exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.
1377
1378         A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
1379         CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
1380         Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
1381         (Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)
1382
1383         Add several new tests covering the patch.
1384
1385         Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
1386                svg/animations/animate-color-fill-currentColor.html
1387                svg/custom/SVGPaint-mutate-attribute.svg
1388                svg/custom/SVGPaint-mutate-inline-style.svg
1389
1390         * GNUMakefile.am: Add CSSMutableValue.h
1391         * WebCore.gypi: Ditto.
1392         * WebCore.xcodeproj/project.pbxproj: Ditto.
1393         * css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration.
1394         (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
1395         * css/CSSMutableStyleDeclaration.h: Add destructor.
1396         * css/CSSMutableValue.h: Added.
1397         (WebCore::CSSMutableValue::CSSMutableValue):
1398         (WebCore::CSSMutableValue::~CSSMutableValue):
1399         (WebCore::CSSMutableValue::isMutableValue):
1400         (WebCore::CSSMutableValue::node):
1401         (WebCore::CSSMutableValue::setNode):
1402         (WebCore::CSSMutableValue::setNeedsStyleRecalc):
1403         * css/CSSStyleDeclaration.cpp:
1404         (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
1405         * css/CSSValue.h:
1406         (WebCore::CSSValue::isMutableValue): Return false, default.
1407         * css/SVGCSSComputedStyleDeclaration.cpp:
1408         (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects.
1409         (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
1410         * css/SVGCSSStyleSelector.cpp:
1411         (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
1412         * rendering/style/SVGRenderStyle.cpp:
1413         (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
1414         * rendering/style/SVGRenderStyle.h: Ditto.
1415         (WebCore::SVGRenderStyle::initialFillOpacity):
1416         (WebCore::SVGRenderStyle::initialFillPaintType):
1417         (WebCore::SVGRenderStyle::initialFillPaintColor):
1418         (WebCore::SVGRenderStyle::initialFillPaintUri):
1419         (WebCore::SVGRenderStyle::initialStrokeOpacity):
1420         (WebCore::SVGRenderStyle::initialStrokePaintType):
1421         (WebCore::SVGRenderStyle::initialStrokePaintColor):
1422         (WebCore::SVGRenderStyle::initialStrokePaintUri):
1423         (WebCore::SVGRenderStyle::initialStrokeMiterLimit):
1424         (WebCore::SVGRenderStyle::initialStopOpacity):
1425         (WebCore::SVGRenderStyle::initialFloodOpacity):
1426         (WebCore::SVGRenderStyle::setFillPaint):
1427         (WebCore::SVGRenderStyle::setStrokePaint):
1428         (WebCore::SVGRenderStyle::fillPaintType):
1429         (WebCore::SVGRenderStyle::fillPaintColor):
1430         (WebCore::SVGRenderStyle::fillPaintUri):
1431         (WebCore::SVGRenderStyle::strokePaintType):
1432         (WebCore::SVGRenderStyle::strokePaintColor):
1433         (WebCore::SVGRenderStyle::strokePaintUri):
1434         (WebCore::SVGRenderStyle::hasStroke):
1435         (WebCore::SVGRenderStyle::hasFill):
1436         * rendering/style/SVGRenderStyleDefs.cpp: Ditto.
1437         (WebCore::StyleFillData::StyleFillData):
1438         (WebCore::StyleFillData::operator==):
1439         (WebCore::StyleStrokeData::StyleStrokeData):
1440         (WebCore::StyleStrokeData::operator==):
1441         * rendering/style/SVGRenderStyleDefs.h: Ditto.
1442         * rendering/svg/RenderSVGResource.cpp: Ditto.
1443         (WebCore::requestPaintingResource):
1444         * rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
1445         (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
1446         * rendering/svg/SVGResources.cpp: Ditto.
1447         (WebCore::paintingResourceFromSVGPaint):
1448         (WebCore::SVGResources::buildCachedResources):
1449         * svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object.
1450         (WebCore::SVGColor::setRGBColor):
1451         (WebCore::SVGColor::setRGBColorICCColor):
1452         (WebCore::SVGColor::setColor):
1453         * svg/SVGColor.h:
1454         * svg/SVGPaint.cpp: Ditto.
1455         (WebCore::SVGPaint::setUri):
1456         (WebCore::SVGPaint::setPaint):
1457         * svg/SVGPaint.h:
1458
1459 2011-03-01  Andrey Adaikin  <aandrey@google.com>
1460
1461         Reviewed by Pavel Feldman.
1462
1463         Web Inspector: [Text editor] Handle decorated lines in the editor
1464         https://bugs.webkit.org/show_bug.cgi?id=55373
1465
1466         * inspector/front-end/SourceFrame.js:
1467         (WebInspector.SourceFrame.prototype._startEditing):
1468         (WebInspector.SourceFrame.prototype._endEditing):
1469         (WebInspector.SourceFrame.prototype._createTextViewer):
1470         * inspector/front-end/TextViewer.js:
1471         (WebInspector.TextEditorGutterPanel.prototype.textChanged):
1472         (WebInspector.TextEditorGutterChunk.prototype.addDecoration):
1473         (WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
1474         (WebInspector.TextEditorMainPanel.prototype.set readOnly):
1475         (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
1476         (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
1477         (WebInspector.TextEditorMainPanel.prototype._markDirtyLines):
1478         (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
1479         (WebInspector.TextEditorMainPanel.prototype._removeDecorationsInRange):
1480         (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
1481         (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
1482         (WebInspector.TextEditorMainChunk.prototype.addDecoration):
1483         (WebInspector.TextEditorMainChunk.prototype.removeDecoration):
1484         (WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
1485         (WebInspector.TextEditorMainChunk.prototype.get decorated):
1486
1487 2011-03-01  Philippe Normand  <pnormand@igalia.com>
1488
1489         Unreviewed GTK build fix after r79978
1490
1491         * GNUmakefile.am:
1492
1493 2011-03-01  Andras Becsi  <abecsi@webkit.org>
1494
1495         Unreviewed build fix.
1496
1497         [Qt] Fix minimal build.
1498
1499         No new tests needed.
1500
1501         * WebCore.pri: Is included in WebKit2.pro, so XP_UNIX can remain here.
1502
1503 2011-03-01  anthony taranto  <anthony.taranto@gmail.com>
1504
1505         Return undefined value from ScriptController::evaluate(), allowing the
1506         caller to distinguish between an error and an undefined return value.
1507         https://bugs.webkit.org/show_bug.cgi?id=51528
1508
1509         * bindings/v8/ScriptController.cpp:
1510
1511 2011-03-01  Roland Steiner  <rolandsteiner@chromium.org>
1512
1513         Reviewed by Kent Tamura.
1514
1515         Bug 54853 - Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
1516         https://bugs.webkit.org/show_bug.cgi?id=54853
1517
1518         Moving the files from rendering to html/shadow, with the exception of
1519         the class RenderTextControlInnerBlock, which I moved to RenderTextControlSingleLine
1520         (this place is not ideal, but only a temporary state during the larger refactoring
1521         for <input>).
1522
1523         No new tests. (refactoring)
1524
1525         * Android.mk:
1526         * CMakeLists.txt:
1527         * WebCore.gypi:
1528         * WebCore.pro:
1529         * WebCore.vcproj/WebCore.vcproj:
1530         * WebCore.xcodeproj/project.pbxproj:
1531         * html/shadow/TextControlInnerElements.cpp: Copied from Source/WebCore/rendering/TextControlInnerElements.cpp.
1532         * html/shadow/TextControlInnerElements.h: Copied from Source/WebCore/rendering/TextControlInnerElements.h.
1533         * rendering/RenderTextControlSingleLine.cpp:
1534         (WebCore::RenderTextControlInnerBlock::positionForPoint):
1535         * rendering/RenderTextControlSingleLine.h:
1536         (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
1537         (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
1538         * rendering/TextControlInnerElements.cpp: Removed.
1539         * rendering/TextControlInnerElements.h: Removed.
1540
1541 2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1542
1543         Reviewed by Tony Chang.
1544
1545         applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
1546         https://bugs.webkit.org/show_bug.cgi?id=55338
1547
1548         Deployed EditingStyle in applyInlineStyleToPushDown and removeInlineStyleFromElement.
1549
1550         Also added a convenience function EditingStyle::setProperty, which lazily instantiates
1551         new CSSMutableStyleDeclaration for m_mutableStyle.
1552
1553         * editing/ApplyStyleCommand.cpp:
1554         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle*.
1555         (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Ditto.
1556         (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
1557         (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls the above three functions.
1558         (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownInlineStyleAroundNode.
1559         * editing/ApplyStyleCommand.h:
1560         * editing/EditingStyle.cpp:
1561         (WebCore::HTMLElementEquivalent::addToStyle): Takes EditingStyle*; calls EditingStyle::setProperty.
1562         (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
1563         (WebCore::EditingStyle::setProperty): Added.  This member function lazily instantiates
1564         new CSSMutableStyleDeclaration for m_mutableStyle.
1565         (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Takes EditingStyle*.
1566         (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Ditto.
1567         (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Ditto.
1568         * editing/EditingStyle.h: Added HTMLElementEquivalent and HTMLAttributeEquivalent as friends.
1569         (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Ditto.
1570         * editing/InsertTextCommand.cpp: Removed unnecessary includes.
1571         * editing/RemoveCSSPropertyCommand.h: Ditto.
1572
1573 2011-02-28  Pavel Feldman  <pfeldman@chromium.org>
1574
1575         Not reviewed: chromium rebuilds XMLViewer after noop. Fixed gyp file.
1576
1577         * WebCore.gyp/WebCore.gyp:
1578
1579 2011-02-28  David Levin  <levin@chromium.org>
1580
1581         Reviewed by Darin Adler.
1582
1583         KURL should expose a referrer property.
1584         https://bugs.webkit.org/show_bug.cgi?id=55415
1585
1586         No change in functionality so no new tests.
1587
1588         * loader/FrameLoader.cpp:
1589         (WebCore::FrameLoader::setOutgoingReferrer): Refactor to put the majority
1590         of functionality in KURL::strippedForUseAsReferrer() so that this code can
1591         be more easily reused.
1592         * platform/KURL.cpp:
1593         (WebCore::KURL::strippedForUseAsReferrer): Converts the url to a string
1594         which is suitable for use as a referrer.
1595         * platform/KURL.h:
1596
1597 2011-02-28  Chang Shu  <cshu@webkit.org>
1598
1599         Reviewed by Ryosuke Niwa.
1600
1601         Remove the support of Frame::isContentEditable and its dependencies.
1602         https://bugs.webkit.org/show_bug.cgi?id=54292
1603
1604         Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and
1605         Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result,
1606         Editor::clientIsEditable and its client-side implementation can be removed.
1607
1608         * WebCore.exp.in:
1609         * accessibility/AccessibilityRenderObject.cpp:
1610         (WebCore::AccessibilityRenderObject::isReadOnly):
1611         * editing/Editor.cpp:
1612         * editing/Editor.h:
1613         * editing/SelectionController.cpp:
1614         (WebCore::SelectionController::setSelectionFromNone):
1615         * html/HTMLElement.cpp:
1616         (WebCore::HTMLElement::isContentEditable):
1617         (WebCore::HTMLElement::isContentRichlyEditable):
1618         * page/DragController.cpp:
1619         (WebCore::DragController::operationForLoad):
1620         * page/EditorClient.h:
1621         * page/Frame.cpp:
1622         * page/Frame.h:
1623
1624 2011-02-28  Kent Tamura  <tkent@chromium.org>
1625
1626         Reviewed by Darin Adler.
1627
1628         Number type input cannot be set to empty string if it has an initial value
1629         https://bugs.webkit.org/show_bug.cgi?id=53744
1630
1631         We need to distinguish null strings and empty strings for
1632         InputElementData::value. So InputType::sanitizeValue() also needs to
1633         take care of it.
1634
1635         * dom/InputElement.h: Add a comment to InputElementData::value and
1636           setValue about null strings.
1637         * html/InputType.h: Add a comment to sanitizeValue about null strings.
1638         * html/NumberInputType.cpp:
1639         (WebCore::NumberInputType::sanitizeValue): Returns a null string if the
1640           proposed value is a null string. Returning an empty string if the
1641           proposed value is not a number.
1642
1643 2011-02-28  Kent Tamura  <tkent@chromium.org>
1644
1645         Reviewed by Darin Adler.
1646
1647         Number type input should not handle mouse wheel events if it has no focus.
1648         https://bugs.webkit.org/show_bug.cgi?id=53638
1649
1650         * html/TextFieldInputType.cpp:
1651         (WebCore::TextFieldInputType::handleWheelEventForSpinButton): Check focused().
1652
1653 2011-02-28  Noel Gordon  <noel.gordon@gmail.com>
1654         Reviewed by James Robinson.
1655
1656         [chromium] GradientSkia: use the common Gradient stop sorting methods.
1657         https://bugs.webkit.org/show_bug.cgi?id=54625
1658
1659         Remove a FIXME: call the Gradient.cpp stop storting routines, no need
1660         to duplicate that code herein.
1661
1662         No change in behavior, so no new tests.
1663
1664         * platform/graphics/skia/GradientSkia.cpp:
1665         (WebCore::Gradient::platformGradient):
1666
1667 2011-02-28  Steve Block  <steveblock@google.com>
1668
1669         Reviewed by Jeremy Orlow.
1670
1671         JNI code should include <jni.h> on non-OSX platforms.
1672         https://bugs.webkit.org/show_bug.cgi?id=55219
1673
1674         On Mac we need to include <JavaVM/jni.h> as this is a framework
1675         include. We include jni.h through JNIUtility.h to minimize the
1676         number of ifdefs.
1677
1678         No new tests, build fix only.
1679
1680         * WebCore.xcodeproj/project.pbxproj
1681         * bridge/jni/JNIUtility.h:
1682         * bridge/jni/jni_jsobject.h:
1683         * bridge/jni/jsc/JNIBridgeJSC.h:
1684         * bridge/jni/jsc/JavaInstanceJSC.h:
1685         * bridge/jni/v8/JavaInstanceV8.h:
1686
1687 2011-02-28  Nebojsa Sabovic  <neb@chromium.org>
1688
1689         Reviewed by James Robinson.
1690
1691         [chromium] Pepper plugins render upside down
1692         https://bugs.webkit.org/show_bug.cgi?id=55101
1693
1694         No layout tests for pepper plugins (yet).
1695
1696         * platform/graphics/chromium/PluginLayerChromium.h:
1697
1698 2011-02-28  Tony Gentilcore  <tonyg@chromium.org>
1699
1700         Reviewed by Adam Barth.
1701
1702         Follow HTML5 spec for document.open() a little more closely
1703         https://bugs.webkit.org/show_bug.cgi?id=55392
1704
1705         See: 3.5.1.4 at http://www.whatwg.org/specs/web-apps/current-work/#dom-document-open.
1706
1707         The second return check matches the spec. The first return check (isExecutingScript())
1708         was left in place because without it, fast/tokenizer/write-external-script-open.html
1709         would fail. It also possible there is a spec bug because FF4 crashes on that test and
1710         IE9 prints "FAILURE." The isLoadingMainResource() check was removed because the main
1711         resource is always loading while parser->isParsing().
1712
1713         Test: fast/parser/double-write-from-closed-iframe.html
1714
1715         * dom/Document.cpp:
1716         (WebCore::Document::open):
1717
1718 2011-02-28  Avi Drissman  <avi@google.com>
1719
1720         Reviewed by James Robinson.
1721
1722         WebCursorInfo needs to match enums in platform/Cursor.h
1723         https://bugs.webkit.org/show_bug.cgi?id=55094
1724
1725         * platform/chromium/CursorChromium.cpp:
1726         (WebCore::grabCursor):
1727         (WebCore::grabbingCursor):
1728         * platform/chromium/PlatformCursor.h:
1729
1730 2011-02-28  Jia Pu  <jpu@apple.com>
1731
1732         Reviewed by Darin Adler.
1733
1734         [Mac] Make "Change back to …" contextual menu item work with new autocorrection.
1735         https://bugs.webkit.org/show_bug.cgi?id=55396
1736         <rdar://problem/8836093>
1737
1738         The change in InlineTextBox.cpp fixes a bug, where the rectangle of Replacement marker isn't
1739         calculated. We need this to do hit test when deciding whether to show "Change back to ..." on
1740         contextual menu.
1741
1742         The change in Editor.cpp is for notifying spellchecker about the reversion whenever "Change
1743         back to ..." is clicked.
1744
1745         * editing/Editor.cpp:
1746         (WebCore::Editor::changeBackToReplacedString):
1747         * rendering/InlineTextBox.cpp:
1748         (WebCore::InlineTextBox::paintDocumentMarkers):
1749
1750 2011-02-28  Victoria Kirst  <vrk@google.com>
1751
1752         Reviewed by Kenneth Russell.
1753
1754         [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium
1755         https://bugs.webkit.org/show_bug.cgi?id=55269
1756
1757         Mesa does not support mapTexSubImage2D, so this change lets
1758         GPU-accelerated video work with DRT layout tests.
1759
1760         * platform/graphics/chromium/VideoLayerChromium.cpp:
1761         (WebCore::VideoLayerChromium::updateTexture):
1762
1763 2011-02-28  David Hyatt  <hyatt@apple.com>
1764
1765         Reviewed by Dan Bernstein.
1766
1767         https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.  Change staticX and staticY
1768         to be staticInlinePosition and staticBlockPosition.  Patch all of the computations involving these variables to be writing
1769         mode aware.  Mixed writing modes are not yet supported.
1770
1771         Added new tests in fast/block/positioning/auto.
1772
1773         * rendering/RenderBlock.cpp:
1774         (WebCore::RenderBlock::adjustPositionedBlock):
1775         (WebCore::RenderBlock::layoutPositionedObjects):
1776         * rendering/RenderBlock.h:
1777         (WebCore::RenderBlock::startOffsetForLine):
1778         * rendering/RenderBlockLineLayout.cpp:
1779         (WebCore::RenderBlock::appendRunsForObject):
1780         (WebCore::setStaticPositions):
1781         (WebCore::RenderBlock::skipTrailingWhitespace):
1782         (WebCore::RenderBlock::skipLeadingWhitespace):
1783         (WebCore::RenderBlock::findNextLineBreak):
1784         * rendering/RenderBox.cpp:
1785         (WebCore::RenderBox::positionLineBox):
1786         (WebCore::computeInlineStaticDistance):
1787         (WebCore::RenderBox::computePositionedLogicalWidth):
1788         (WebCore::computeBlockStaticDistance):
1789         (WebCore::RenderBox::computePositionedLogicalHeight):
1790         (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
1791         (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
1792         * rendering/RenderBoxModelObject.h:
1793         (WebCore::RenderBoxModelObject::borderAndPaddingLogicalLeft):
1794         (WebCore::RenderBoxModelObject::borderAndPaddingStart):
1795         (WebCore::RenderBoxModelObject::borderLogicalLeft):
1796         (WebCore::RenderBoxModelObject::borderLogicalRight):
1797         * rendering/RenderFlexibleBox.cpp:
1798         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1799         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1800         * rendering/RenderInline.cpp:
1801         (WebCore::RenderInline::relativePositionedInlineOffset):
1802         * rendering/RenderLayer.cpp:
1803         (WebCore::RenderLayer::RenderLayer):
1804         * rendering/RenderLayer.h:
1805         (WebCore::RenderLayer::staticInlinePosition):
1806         (WebCore::RenderLayer::staticBlockPosition):
1807         (WebCore::RenderLayer::setStaticInlinePosition):
1808         (WebCore::RenderLayer::setStaticBlockPosition):
1809         * rendering/style/RenderStyle.h:
1810         (WebCore::InheritedFlags::hasAutoLeftAndRight):
1811         (WebCore::InheritedFlags::hasAutoTopAndBottom):
1812         (WebCore::InheritedFlags::hasStaticInlinePosition):
1813         (WebCore::InheritedFlags::hasStaticBlockPosition):
1814
1815 2011-02-28  Balazs Kelemen  <kbalazs@webkit.org>
1816
1817         Reviewed by Anders Carlsson.
1818
1819         [Qt][WK2] Plugin initialization
1820         https://bugs.webkit.org/show_bug.cgi?id=48127
1821
1822         No function change so no new tests.
1823
1824         * WebCore.pri: Lift the definition of the XP_UNIX macro
1825         from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
1826
1827 2011-02-28  Dean Jackson  <dino@apple.com>
1828
1829         Reviewed by Eric Carlson.
1830
1831         https://bugs.webkit.org/show_bug.cgi?id=55239
1832
1833         Allow webkitEnterFullScreen to be called from outside
1834         a user gesture, but only when the correct restrictions
1835         have been lifted in WebCore. Add a new restriction type
1836         for this situation. Meanwhile, expose the current
1837         restrictions externally from HTMLMediaElement, so that
1838         clients can easily set restrictions on their port.
1839
1840         No new tests. This doesn't change existing behavior. Some
1841         WebKit clients may lift the restriction.
1842
1843         * html/HTMLMediaElement.cpp:
1844         (WebCore::HTMLMediaElement::HTMLMediaElement):
1845         - ensure restrictions initialize with fullscreen restricted
1846         * html/HTMLMediaElement.h:
1847         (WebCore::HTMLMediaElement::requireUserGestureForLoad):
1848         (WebCore::HTMLMediaElement::requireUserGestureForRateChange):
1849         (WebCore::HTMLMediaElement::requireUserGestureForFullScreen):
1850         (WebCore::HTMLMediaElement::setBehaviorRestrictions):
1851         - new methods to expose the current restrictions
1852         * html/HTMLVideoElement.cpp:
1853         (WebCore::HTMLVideoElement::webkitEnterFullscreen):
1854
1855 2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1856
1857         Unreviewed, rolling out r78789.
1858         http://trac.webkit.org/changeset/78789
1859         https://bugs.webkit.org/show_bug.cgi?id=55409
1860
1861         Incorrect canvas fallback implementation (Requested by
1862         inferno-sec on #webkit).
1863
1864         * accessibility/AccessibilityObject.h:
1865         * accessibility/AccessibilityRenderObject.cpp:
1866         (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
1867         (WebCore::AccessibilityRenderObject::canHaveChildren):
1868         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1869         (atkRole):
1870         * accessibility/mac/AccessibilityObjectWrapper.mm:
1871         * html/HTMLFormControlElement.cpp:
1872         (WebCore::HTMLFormControlElement::isFocusable):
1873         * rendering/RenderHTMLCanvas.cpp:
1874         * rendering/RenderHTMLCanvas.h:
1875         * rendering/RenderObject.cpp:
1876         (WebCore::RenderObject::repaint):
1877         * rendering/RenderTreeAsText.cpp:
1878         (WebCore::write):
1879
1880 2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1881
1882         Unreviewed, rolling out r79425.
1883         http://trac.webkit.org/changeset/79425
1884         https://bugs.webkit.org/show_bug.cgi?id=55406
1885
1886         Incorrect canvas fallback implementation. (Requested by
1887         inferno-sec on #webkit).
1888
1889         * rendering/RenderHTMLCanvas.cpp:
1890         (WebCore::RenderHTMLCanvas::nodeAtPoint):
1891
1892 2011-02-28  Adam Klein  <adamk@chromium.org>
1893
1894         Reviewed by Adam Barth.
1895
1896         [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
1897         https://bugs.webkit.org/show_bug.cgi?id=54774
1898
1899         See http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods
1900         for the spec implemented by this patch.
1901
1902         Test: fast/filesystem/resolve-uri.html
1903
1904         * fileapi/DOMFileSystemBase.cpp:
1905         (WebCore::DOMFileSystemBase::crackFileSystemURL):
1906         * fileapi/DOMFileSystemBase.h:
1907         Added constants for "temporary" and "persistent".
1908         * fileapi/EntryBase.cpp:
1909         Replace hardcoded strings with aforementioned constants.
1910         * fileapi/FileSystemCallbacks.cpp:
1911         (WebCore::ResolveURICallbacks::create):
1912         (WebCore::ResolveURICallbacks::ResolveURICallbacks):
1913         (WebCore::ResolveURICallbacks::didOpenFileSystem):
1914         Chains a call of openFileSystem to calls to getDirectory/getFile.
1915         * fileapi/FileSystemCallbacks.h:
1916         * fileapi/LocalFileSystem.cpp:
1917         (WebCore::LocalFileSystem::readFileSystem):
1918         * fileapi/LocalFileSystem.h:
1919         Remove size argument from readFileSystem()
1920         * page/DOMWindow.cpp:
1921         (WebCore::DOMWindow::resolveLocalFileSystemURI):
1922         * page/DOMWindow.h:
1923         * page/DOMWindow.idl:
1924
1925 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
1926
1927         Reviewed by Oliver Hunt.
1928
1929         Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
1930
1931         * bridge/qt/qt_runtime.cpp:
1932         (JSC::Bindings::QtConnectionObject::execute):
1933
1934 2011-02-25  David Levin  <levin@chromium.org>
1935
1936         Reviewed by Darin Adler.
1937
1938         Remove some duplicate code from KURLGoogle.cpp
1939         https://bugs.webkit.org/show_bug.cgi?id=55266
1940
1941         No change in functionality so no new tests.
1942
1943         * WebCore.gyp/WebCore.gyp: Make KURL.cpp get built by Chromium.
1944         * platform/KURL.cpp:
1945         Simply moved #include's and some code that was identical (i.e.
1946         had been copied) to KURLGoogle.cpp outside of ifdef !USE(GOOGLEURL)
1947         to reduce duplication.
1948         * platform/KURLGoogle.cpp:
1949         Removed the duplicate code.
1950
1951 2011-02-28  Oliver Hunt  <oliver@apple.com>
1952
1953         Reviewed by Gavin Barraclough.
1954
1955         Make ScopeChainNode GC allocated
1956         https://bugs.webkit.org/show_bug.cgi?id=55283
1957
1958         Update WebCore to deal with the absence of the ScopeChain
1959         class.
1960
1961         * ForwardingHeaders/runtime/ScopeChain.h: Added.
1962         * bindings/js/JSHTMLElementCustom.cpp:
1963         (WebCore::JSHTMLElement::pushEventHandlerScope):
1964         * bindings/js/JSJavaScriptCallFrameCustom.cpp:
1965         (WebCore::JSJavaScriptCallFrame::scopeChain):
1966         (WebCore::JSJavaScriptCallFrame::scopeType):
1967         * bindings/js/JSLazyEventListener.cpp:
1968         (WebCore::JSLazyEventListener::initializeJSFunction):
1969         * bindings/js/JSMainThreadExecState.h:
1970         (WebCore::JSMainThreadExecState::evaluate):
1971         * bindings/js/JSNodeCustom.cpp:
1972         (WebCore::JSNode::pushEventHandlerScope):
1973         * bindings/js/JavaScriptCallFrame.cpp:
1974         (WebCore::JavaScriptCallFrame::scopeChain):
1975         * bindings/js/JavaScriptCallFrame.h:
1976         * bindings/scripts/CodeGeneratorJS.pm:
1977         * bridge/c/c_class.cpp:
1978         * bridge/c/c_runtime.cpp:
1979         * bridge/jni/JNIBridge.cpp:
1980         * bridge/qt/qt_runtime.cpp:
1981         (JSC::Bindings::QtConnectionObject::execute):
1982         * plugins/PluginViewNone.cpp:
1983
1984 2011-02-28  Chang Shu  <cshu@webkit.org>
1985
1986         Reviewed by Adele Peterson.
1987
1988         REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
1989         https://bugs.webkit.org/show_bug.cgi?id=55323
1990
1991         Draw focus ring on selected items only if spatial navigation is enabled.
1992
1993         Test: fast/forms/select-listbox-multiple-no-focusring.html
1994
1995         * rendering/RenderBlock.h:
1996         * rendering/RenderListBox.cpp:
1997         (WebCore::RenderListBox::addFocusRingRects):
1998
1999 2011-02-28  Abhishek Arya  <inferno@chromium.org>
2000
2001         Reviewed by Anders Carlsson.
2002
2003         We can cancel the plugin load and fail with error before m_manualStream
2004         got a chance to initialize in PluginView::didReceiveResponse. This can
2005         happen when we run pending document onload events during plugin load that
2006         remove the frame from underneath. So, change the assert into a null check.
2007         https://bugs.webkit.org/show_bug.cgi?id=55307
2008
2009         * plugins/PluginView.cpp:
2010         (WebCore::PluginView::didFail):
2011
2012 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
2013
2014         Reviewed by Alexey Proskuryakov.
2015
2016         Build fix for Intel ICC Compiler.
2017         https://bugs.webkit.org/show_bug.cgi?id=55221
2018
2019         The virtual inheritance seems to confuse ICC.
2020         Anything that links with webkit has an undefined reference otherwise.
2021
2022         * svg/SVGTransformable.cpp:
2023         (WebCore::SVGTransformable::~SVGTransformable):
2024         * svg/SVGTransformable.h:
2025
2026 2011-02-28  Sergio Villar Senin  <svillar@igalia.com>
2027
2028         Reviewed by Martin Robinson.
2029
2030         [Gtk] Resource size is incorrectly reported to WebCore
2031         https://bugs.webkit.org/show_bug.cgi?id=53228
2032
2033         When calling didReceiveData we are sending an invalid value for
2034         lengthReceived. Sometimes we were even passing a boolean value instead of the
2035         expected integer. We should pass the size of the received data instead of the
2036         total amount of data received.
2037
2038         * platform/network/ResourceHandleInternal.h:
2039         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2040         * platform/network/soup/ResourceHandleSoup.cpp:
2041         (WebCore::gotChunkCallback):
2042         (WebCore::sendRequestCallback):
2043         (WebCore::readCallback):
2044
2045 2011-02-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2046
2047         Reviewed by Dan Bernstein.
2048
2049         Cleanup the include guard form an Objective-C files
2050         https://bugs.webkit.org/show_bug.cgi?id=55379
2051
2052         Normally Objective-C files do not need include guard.
2053         r76916 introduced an include guard in EmptyProtocolDefinitions.h.
2054         The guard is no longer needed after r76991.
2055
2056         No new tests as there is no new functionality.
2057
2058         * platform/mac/EmptyProtocolDefinitions.h:
2059
2060 2011-02-28  Pavel Podivilov  <podivilov@chromium.org>
2061
2062         Reviewed by Pavel Feldman.
2063
2064         Web Inspector: [REGRESSION] no resources in scripts panel because debugger is enabled too early.
2065         https://bugs.webkit.org/show_bug.cgi?id=55389
2066
2067         * inspector/InspectorAgent.cpp:
2068         (WebCore::InspectorAgent::populateScriptObjects):
2069         * inspector/InspectorDebuggerAgent.cpp:
2070         (WebCore::InspectorDebuggerAgent::setFrontend):
2071         (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
2072         * inspector/InspectorDebuggerAgent.h:
2073
2074 2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2075
2076         Unreviewed, rolling out r79877.
2077         http://trac.webkit.org/changeset/79877
2078         https://bugs.webkit.org/show_bug.cgi?id=55388
2079
2080         Breaks chromium build (Requested by antonm_ on #webkit).
2081
2082         * WebCore.gypi:
2083         * platform/graphics/chromium/ContentLayerChromium.cpp:
2084         (WebCore::ContentLayerChromium::updateContentsIfDirty):
2085         (WebCore::ContentLayerChromium::resizeUploadBufferForImage):
2086         (WebCore::ContentLayerChromium::resizeUploadBuffer):
2087         (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels):
2088         (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels):
2089         (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
2090         (WebCore::ContentLayerChromium::updateTextureIfNeeded):
2091         (WebCore::ContentLayerChromium::draw):
2092         * platform/graphics/chromium/ContentLayerChromium.h:
2093         * platform/graphics/chromium/ImageLayerChromium.cpp:
2094         (WebCore::ImageLayerChromium::updateContentsIfDirty):
2095         * platform/graphics/chromium/ImageLayerChromium.h:
2096         * platform/graphics/chromium/LayerTilerChromium.cpp:
2097         (WebCore::LayerTilerChromium::contentRectToTileIndices):
2098         (WebCore::LayerTilerChromium::update):
2099         * platform/graphics/chromium/LayerTilerChromium.h:
2100         * platform/graphics/chromium/PlatformCanvas.cpp: Removed.
2101         * platform/graphics/chromium/PlatformCanvas.h: Removed.
2102         * platform/graphics/chromium/PlatformImage.cpp: Removed.
2103         * platform/graphics/chromium/PlatformImage.h: Removed.
2104
2105 2011-02-28  Pavel Podivilov  <podivilov@chromium.org>
2106
2107         Reviewed by Pavel Feldman.
2108
2109         Web Inspector: add live edit test.
2110         https://bugs.webkit.org/show_bug.cgi?id=55360
2111
2112         Test: inspector/debugger/live-edit.html
2113
2114         * inspector/front-end/SourceFrame.js:
2115         (WebInspector.SourceFrame.prototype._doubleClick):
2116         (WebInspector.SourceFrame.prototype._didEditLine):
2117
2118 2011-02-28  Pavel Feldman  <pfeldman@chromium.org>
2119
2120         Not reviewed. Follow up to r79858, removing optimistic assertion that fails on debug bot.
2121
2122         * inspector/InspectorBrowserDebuggerAgent.cpp:
2123         (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
2124
2125 2011-02-25  Adrienne Walker  <enne@google.com>
2126
2127         Reviewed by James Robinson.
2128
2129         [chromium] Abstract "pixels with a graphics context" into its own class
2130         https://bugs.webkit.org/show_bug.cgi?id=55259
2131
2132         This creates new PlatformCanvas/PlatformImage classes which wrap
2133         all of the #ifdef Skia/Cg warts from the compositor.  All classes
2134         (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
2135         modified to use these abstractions.
2136
2137         Tests: LayoutTests/compositing
2138
2139         * WebCore.gypi:
2140         * platform/graphics/chromium/ContentLayerChromium.cpp:
2141         (WebCore::ContentLayerChromium::updateContentsIfDirty):
2142         (WebCore::ContentLayerChromium::resizeUploadBuffer):
2143         (WebCore::ContentLayerChromium::updateTextureIfNeeded):
2144         (WebCore::ContentLayerChromium::updateTexture):
2145         (WebCore::ContentLayerChromium::draw):
2146         * platform/graphics/chromium/ContentLayerChromium.h:
2147         * platform/graphics/chromium/ImageLayerChromium.cpp:
2148         (WebCore::ImageLayerChromium::updateContentsIfDirty):
2149         (WebCore::ImageLayerChromium::updateTextureIfNeeded):
2150         * platform/graphics/chromium/ImageLayerChromium.h:
2151         * platform/graphics/chromium/LayerTilerChromium.cpp:
2152         (WebCore::LayerTilerChromium::contentRectToTileIndices):
2153         (WebCore::LayerTilerChromium::update):
2154         (WebCore::LayerTilerChromium::updateFromPixels):
2155         * platform/graphics/chromium/LayerTilerChromium.h:
2156         * platform/graphics/chromium/PlatformCanvas.cpp: Added.
2157         (WebCore::PlatformCanvas::PlatformCanvas):
2158         (WebCore::PlatformCanvas::~PlatformCanvas):
2159         (WebCore::PlatformCanvas::resize):
2160         (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
2161         (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
2162         (WebCore::PlatformCanvas::Painter::Painter):
2163         (WebCore::PlatformCanvas::Painter::~Painter):
2164         * platform/graphics/chromium/PlatformCanvas.h: Added.
2165         (WebCore::PlatformCanvas::AutoLocker::pixels):
2166         (WebCore::PlatformCanvas::Painter::context):
2167         (WebCore::PlatformCanvas::size):
2168         * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
2169         (WebCore::PlatformImage::PlatformImage):
2170         (WebCore::PlatformImage::updateFromImage):
2171         * platform/graphics/chromium/PlatformImage.h: Added.
2172         (WebCore::PlatformImage::pixels):
2173         (WebCore::PlatformImage::size):
2174
2175 2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2176
2177         Unreviewed, rolling out r79784.
2178         http://trac.webkit.org/changeset/79784
2179         https://bugs.webkit.org/show_bug.cgi?id=55386
2180
2181         This change causes lots of assertion failures in Debug builds
2182         (Requested by aroben on #webkit).
2183
2184         * css/CSSStyleSelector.cpp:
2185         (WebCore::convertToLength):
2186         (WebCore::CSSStyleSelector::applyProperty):
2187         (WebCore::CSSStyleSelector::createTransformOperations):
2188         * platform/Length.h:
2189         (WebCore::Length::Length):
2190         (WebCore::Length::operator==):
2191         (WebCore::Length::operator!=):
2192         (WebCore::Length::rawValue):
2193         (WebCore::Length::type):
2194         (WebCore::Length::quirk):
2195         (WebCore::Length::setValue):
2196         (WebCore::Length::setRawValue):
2197         (WebCore::Length::calcFloatValue):
2198         (WebCore::Length::isZero):
2199         (WebCore::Length::blend):
2200         * rendering/AutoTableLayout.cpp:
2201         (WebCore::AutoTableLayout::recalcColumn):
2202         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
2203         * rendering/FixedTableLayout.cpp:
2204         (WebCore::FixedTableLayout::calcWidthArray):
2205
2206 2011-02-28  Andreas Kling  <kling@webkit.org>
2207
2208         Reviewed by Darin Adler.
2209
2210         Use Frame::ownerElement() directly where appropriate.
2211         https://bugs.webkit.org/show_bug.cgi?id=55385
2212
2213         Don't take the roundabout way through frame->document->ownerElement
2214         which just checks that the document->frame is non-null.
2215
2216         No new test, refactoring only.
2217
2218         * editing/SelectionController.cpp:
2219         (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
2220         * loader/FrameLoader.cpp:
2221         (WebCore::FrameLoader::loadWithDocumentLoader):
2222         * page/DOMWindow.cpp:
2223         (WebCore::DOMWindow::dispatchLoadEvent):
2224         * page/EventHandler.cpp:
2225         (WebCore::EventHandler::scrollRecursively):
2226         (WebCore::EventHandler::logicalScrollRecursively):
2227         * page/FrameView.cpp:
2228         (WebCore::FrameView::init):
2229         (WebCore::FrameView::layout):
2230         (WebCore::FrameView::repaintContentRectangle):
2231         (WebCore::FrameView::windowClipRect):
2232         (WebCore::FrameView::paintContents):
2233
2234 2011-02-28  Pavel Podivilov  <podivilov@chromium.org>
2235
2236         Reviewed by Pavel Feldman.
2237
2238         Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
2239         https://bugs.webkit.org/show_bug.cgi?id=55377
2240
2241         * inspector/front-end/ScriptsPanel.js:
2242         (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
2243         (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
2244         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
2245         (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
2246
2247 2011-02-28  Patrick Gansterer  <paroga@webkit.org>
2248
2249         Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r79569.
2250
2251         * svg/SVGDocumentExtensions.cpp:
2252         (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
2253
2254 2011-02-28  Renata Hodovan  <reni@webkit.org>
2255
2256         Reviewed by Andreas Kling.
2257
2258         Optimize parameter transmissions in FEConvolveMatrix.
2259         https://bugs.webkit.org/show_bug.cgi?id=55381
2260
2261         Parameter transmission via reference is more efficient than with copy. So they are substituted.
2262
2263         No new tests are needed since this is a refactoring.
2264
2265         * platform/graphics/filters/FEConvolveMatrix.cpp:
2266         (WebCore::FEConvolveMatrix::setKernelSize):
2267         (WebCore::FEConvolveMatrix::setTargetOffset):
2268         (WebCore::FEConvolveMatrix::setKernelUnitLength):
2269         * platform/graphics/filters/FEConvolveMatrix.h:
2270
2271 2011-02-28  Yury Semikhatsky  <yurys@chromium.org>
2272
2273         Unreviewed. Fix Chromium tests failures due to r79858.
2274
2275         * inspector/InspectorAgent.cpp:
2276         (WebCore::InspectorAgent::inspectedPageDestroyed):
2277
2278 2011-02-28  Vsevolod Vlasov  <vsevik@chromium.org>
2279
2280         Reviewed by Pavel Feldman.
2281
2282         XML without style should render as syntax-highlighted source.
2283         https://bugs.webkit.org/show_bug.cgi?id=13807
2284
2285         XML tree view mode implemented. If XML does not have any style
2286         information, it is rendered as highlighted source with collapsable
2287         elements.
2288
2289         Tests: fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml
2290                fast/encoding/dumpAsText/utf-16-no-bom.xml
2291                http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
2292                http/tests/xmlviewer/dumpAsText/frames.html
2293                http/tests/xmlviewer/dumpAsText/mathml.xml
2294                http/tests/xmlviewer/dumpAsText/svg.xml
2295                http/tests/xmlviewer/dumpAsText/wml.xml
2296                http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
2297                http/tests/xmlviewer/dumpAsText/xlink.xml
2298                http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
2299                http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
2300                http/tests/xmlviewer/dumpAsText/xmlviewer.xml
2301                http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
2302                http/tests/xmlviewer/dumpAsText/xul.xml
2303                svg/hixie/error/dumpAsText/004.xml
2304                svg/hixie/error/dumpAsText/005.xml
2305
2306         * CMakeLists.txt:
2307         * DerivedSources.make:
2308         * GNUmakefile.am:
2309         * WebCore.gyp/WebCore.gyp:
2310         * WebCore.gypi:
2311         * WebCore.vcproj/WebCore.vcproj:
2312         * WebCore.xcodeproj/project.pbxproj:
2313         * css/CSSStyleSelector.cpp:
2314         (WebCore::CSSStyleSelector::matchUARules):
2315         * dom/Document.cpp:
2316         (WebCore::Document::Document):
2317         (WebCore::Document::createElement):
2318         * dom/Document.h:
2319         (WebCore::Document::usesViewSourceStyles):
2320         (WebCore::Document::setUsesViewSourceStyles):
2321         (WebCore::Document::sawElementsInKnownNamespaces):
2322         * dom/XMLDocumentParser.h:
2323         * dom/XMLDocumentParserLibxml2.cpp:
2324         (WebCore::XMLDocumentParser::XMLDocumentParser):
2325         (WebCore::XMLDocumentParser::processingInstruction):
2326         (WebCore::XMLDocumentParser::initializeParserContext):
2327         (WebCore::XMLDocumentParser::doEnd):
2328         * dom/XMLDocumentParserQt.cpp:
2329         (WebCore::XMLDocumentParser::XMLDocumentParser):
2330         (WebCore::XMLDocumentParser::initializeParserContext):
2331         (WebCore::XMLDocumentParser::parseProcessingInstruction):
2332         * html/HTMLViewSourceDocument.cpp:
2333         (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
2334         * xml/XMLTreeViewer.cpp: Added.
2335         (WebCore::XMLTreeViewer::XMLTreeViewer):
2336         (WebCore::XMLTreeViewer::hasNoStyleInformation):
2337         (WebCore::XMLTreeViewer::transformDocumentToTreeView):
2338         * xml/XMLTreeViewer.h: Added.
2339         (WebCore::XMLTreeViewer::~XMLTreeViewer):
2340         * xml/XMLViewer.xsl: Added.
2341         * xml/XSLStyleSheet.h:
2342         (WebCore::XSLStyleSheet::createForXMLTreeViewer):
2343
2344 2011-02-28  Yury Semikhatsky  <yurys@chromium.org>
2345
2346         Reviewed by Pavel Feldman.
2347
2348         Web Inspector: debugger agents should have same livetime as InspectorAgent
2349         https://bugs.webkit.org/show_bug.cgi?id=55369
2350
2351         DOM and JS debugger agents are now created in InspectorAgent's constructor and owned
2352         by the agent. Debugger state is cleared on frontend disconnect.
2353
2354         * inspector/Inspector.idl:
2355         * inspector/InspectorAgent.cpp:
2356         (WebCore::InspectorAgent::InspectorAgent):
2357         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2358         (WebCore::InspectorAgent::setFrontend):
2359         (WebCore::InspectorAgent::disconnectFrontend):
2360         (WebCore::InspectorAgent::populateScriptObjects):
2361         (WebCore::InspectorAgent::didCommitLoad):
2362         (WebCore::InspectorAgent::showScriptsPanel):
2363         * inspector/InspectorAgent.h:
2364         * inspector/InspectorBrowserDebuggerAgent.cpp:
2365         (WebCore::InspectorBrowserDebuggerAgent::create):
2366         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
2367         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
2368         (WebCore::InspectorBrowserDebuggerAgent::debuggerWasEnabled):
2369         (WebCore::InspectorBrowserDebuggerAgent::debuggerWasDisabled):
2370         (WebCore::InspectorBrowserDebuggerAgent::disable):
2371         (WebCore::InspectorBrowserDebuggerAgent::setFrontend):
2372         (WebCore::InspectorBrowserDebuggerAgent::clearFrontend):
2373         (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
2374         (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
2375         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
2376         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
2377         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
2378         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
2379         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
2380         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
2381         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
2382         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
2383         (WebCore::InspectorBrowserDebuggerAgent::clear):
2384         * inspector/InspectorBrowserDebuggerAgent.h:
2385         * inspector/InspectorController.cpp:
2386         (WebCore::InspectorController::debuggerEnabled):
2387         (WebCore::InspectorController::showAndEnableDebugger):
2388         (WebCore::InspectorController::disableDebugger):
2389         * inspector/InspectorDebuggerAgent.cpp:
2390         (WebCore::InspectorDebuggerAgent::create):
2391         (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
2392         (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
2393         (WebCore::InspectorDebuggerAgent::startUserInitiatedDebugging):
2394         (WebCore::InspectorDebuggerAgent::enable):
2395         (WebCore::InspectorDebuggerAgent::disable):
2396         (WebCore::InspectorDebuggerAgent::enabled):
2397         (WebCore::InspectorDebuggerAgent::restore):
2398         (WebCore::InspectorDebuggerAgent::setFrontend):
2399         (WebCore::InspectorDebuggerAgent::clearFrontend):
2400         (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
2401         (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
2402         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
2403         (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
2404         (WebCore::InspectorDebuggerAgent::currentCallFrames):
2405         (WebCore::InspectorDebuggerAgent::didParseSource):
2406         (WebCore::InspectorDebuggerAgent::clear):
2407         * inspector/InspectorDebuggerAgent.h:
2408         (WebCore::InspectorDebuggerAgent::enable):
2409         (WebCore::InspectorDebuggerAgent::disable):
2410         (WebCore::InspectorDebuggerAgent::Listener::~Listener):
2411         (WebCore::InspectorDebuggerAgent::setListener):
2412         * inspector/InspectorInstrumentation.cpp:
2413         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
2414         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
2415         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
2416         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
2417         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
2418         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
2419         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2420         * inspector/front-end/DebuggerModel.js:
2421         (WebInspector.DebuggerModel.prototype.enableDebugger):
2422         (WebInspector.DebuggerModel.prototype.disableDebugger):
2423
2424 2011-02-28  Renata Hodovan  <reni@webkit.org>
2425
2426         Reviewed by Andreas Kling.
2427
2428         FECompositeElement changes doesn't require relayout.
2429         https://bugs.webkit.org/show_bug.cgi?id=55367
2430
2431         When the FECompositeElement receives an update message but the given value remains the same we don't need
2432         to relayout the filter.
2433
2434         No new tests are needed because this modification is covered by the dynamic update tests of FEComposite.
2435
2436         * platform/graphics/filters/FEComposite.cpp:
2437         (WebCore::FEComposite::setOperation):
2438         (WebCore::FEComposite::setK1):
2439         (WebCore::FEComposite::setK2):
2440         (WebCore::FEComposite::setK3):
2441         (WebCore::FEComposite::setK4):
2442         * platform/graphics/filters/FEComposite.h:
2443         * svg/SVGFECompositeElement.cpp:
2444         (WebCore::SVGFECompositeElement::setFilterEffectAttribute):
2445         (WebCore::SVGFECompositeElement::svgAttributeChanged):
2446         * svg/SVGFECompositeElement.h:
2447
2448 2011-02-28  Andreas Kling  <kling@webkit.org>
2449
2450         Reviewed by Kenneth Rohde Christiansen.
2451
2452         FrameLoader: Reorder early-returns in checkCompleted()
2453         https://bugs.webkit.org/show_bug.cgi?id=55366
2454
2455         Check allChildrenAreComplete() last, since it's the most expensive.
2456
2457         * loader/FrameLoader.cpp:
2458         (WebCore::FrameLoader::checkCompleted):
2459
2460 2011-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2461
2462         Reviewed by Kent Tamura.
2463
2464         Range::processContents needs cleanup
2465         https://bugs.webkit.org/show_bug.cgi?id=51006
2466
2467         Refactored Range::processContents.  Extracted childOfCommonRootBeforeOffset from processContents
2468         which is used to find processStart and processEnd respectively.  In the case of processStart,
2469         we use the next sibling of the node returned by childOfCommonRootBeforeOffset when m_start is not
2470         the common root because copying m_start's ancestors will result in processing too much contents.
2471
2472         Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.
2473
2474         In addition, lengthOfContentsInNode was modified to return the correct length instead of
2475         numeric_limits<unsigned>::max() because the convention that processContentsBetweenOffsets automatically
2476         corrects the length when endOffset is numeric_limits<unsigned>::max() seemed more confusing than
2477         having two switch statements that need to be consistent.
2478
2479         Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
2480         LengthOfContentsInNode added in r78409 violated WebKit C++ rules and caused build failures on Mac and
2481         other ports.
2482
2483         * dom/Range.cpp:
2484         (WebCore::childOfCommonRootBeforeOffset): Extracted from processContents.
2485         (WebCore::lengthOfContentsInNode): Added.
2486         (WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode,
2487         and processNodes.
2488         (WebCore::deleteCharacterData): Added.
2489         (WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterData and processNodes.
2490         (WebCore::Range::processNodes): Extracted from processContents and processContentsBetweenOffsets.
2491         (WebCore::Range::processAncestorsAndTheirSiblings):
2492         * dom/Range.h:
2493
2494 2011-02-28  Pavel Feldman  <pfeldman@chromium.org>
2495
2496         Not reviewed. Test harness change follow up.
2497         Consider missing localized string a warning, not an error in the front-end.
2498
2499         * inspector/front-end/inspector.js:
2500         (WebInspector.UIString):
2501
2502 2011-02-28  Steve Block  <steveblock@google.com>
2503
2504         Reviewed by Jeremy Orlow.
2505
2506         getJNIEnv() passes wrong type to AttachCurrentThread() for JNIEnv argument on Android
2507         https://bugs.webkit.org/show_bug.cgi?id=55218
2508
2509         AttachCurrentThread() in Android's JVM takes a JINEnv**
2510         argument.
2511
2512         No new tests, build fix only.
2513
2514         * bridge/jni/JNIUtility.cpp:
2515         (JSC::Bindings::getJNIEnv):
2516
2517 2011-02-28  Renata Hodovan  <reni@webkit.org>
2518
2519         Reviewed by Andreas Kling.
2520
2521         FETurbulenceElement changes doesn't require relayout
2522         https://bugs.webkit.org/show_bug.cgi?id=55141
2523
2524         When the FETurbulenceElement receives an update message but the given value remains the same we don't need
2525         to relayout the filter.
2526         Besides fix a typo in FETurbulence and change the paramterer type of FETurbulence::setNumOctaves from bool
2527         to int according to the spec.
2528
2529         No new tests are needed because this modification is covered by the dynamic update tests of FETurbulence.
2530
2531         * platform/graphics/filters/FETurbulence.cpp:
2532         (WebCore::FETurbulence::FETurbulence):
2533         (WebCore::FETurbulence::create):
2534         (WebCore::FETurbulence::type):
2535         (WebCore::FETurbulence::setType):
2536         (WebCore::FETurbulence::setBaseFrequencyY):
2537         (WebCore::FETurbulence::setBaseFrequencyX):
2538         (WebCore::FETurbulence::setSeed):
2539         (WebCore::FETurbulence::setNumOctaves):
2540         (WebCore::FETurbulence::setStitchTiles):
2541         (WebCore::operator<<):
2542         * platform/graphics/filters/FETurbulence.h:
2543         * svg/SVGFETurbulenceElement.cpp:
2544         (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute):
2545         (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
2546         (WebCore::SVGFETurbulenceElement::build):
2547         * svg/SVGFETurbulenceElement.h:
2548
2549 2011-02-28  Pavel Feldman  <pfeldman@chromium.org>
2550
2551         Reviewed by Yury Semikhatsky.
2552
2553         WebInspector: InspectorAgent calls offsetWidth in the middle of painting
2554         https://bugs.webkit.org/show_bug.cgi?id=54597
2555
2556         * inspector/InspectorAgent.cpp:
2557         (WebCore::InspectorAgent::drawElementTitle):
2558
2559 2011-02-28  Roland Steiner  <rolandsteiner@chromium.org>
2560
2561         Reviewed by Kent Tamura.
2562
2563         Bug 55355 - TextIterator should not be a friend of RenderTextControl
2564         https://bugs.webkit.org/show_bug.cgi?id=55355
2565
2566         Remove need for 'friend' clause by making innerTextElement() public.
2567
2568         No new tests. (simple refactoring)
2569
2570         * rendering/RenderTextControl.h:
2571
2572 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
2573
2574         Reviewed by Darin Adler.
2575
2576         Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWinCE
2577         https://bugs.webkit.org/show_bug.cgi?id=55317
2578
2579         This functions are obsolete, since r78499 added TextCodecUTF8.
2580         Also remove the "fast path" for UTF-8 data, because we now have a separate TextCodec.
2581
2582         * platform/text/TextEncodingRegistry.cpp:
2583         (WebCore::buildBaseTextCodecMaps):
2584         * platform/text/wince/TextCodecWinCE.cpp:
2585         * platform/text/wince/TextCodecWinCE.h:
2586
2587 2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2588
2589         Reviewed by Sam Weinig.
2590
2591         Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and RenderBlock::m_positionedObjects
2592         https://bugs.webkit.org/show_bug.cgi?id=55327
2593
2594         Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positionedObjects so we do not have
2595         to release the memory manually.
2596
2597         * rendering/RenderBlock.cpp:
2598         (WebCore::RenderBlock::~RenderBlock):
2599         (WebCore::RenderBlock::selectionGaps):
2600         (WebCore::RenderBlock::insertPositionedObject):
2601         (WebCore::RenderBlock::insertFloatingObject):
2602         (WebCore::RenderBlock::addOverhangingFloats):
2603         (WebCore::RenderBlock::addIntrudingFloats):
2604         * rendering/RenderBlock.h:
2605         (WebCore::RenderBlock::positionedObjects):
2606
2607 2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2608
2609         Reviewed by Andreas Kling.
2610
2611         Eliminate DeprecatedPtrList
2612         https://bugs.webkit.org/show_bug.cgi?id=17425
2613
2614         Remove the implementation of DeprecatedPtrList and all its references
2615         from the build systems.
2616
2617         * Android.mk:
2618         * CMakeLists.txt:
2619         * GNUmakefile.am:
2620         * WebCore.gypi:
2621         * WebCore.order:
2622         * WebCore.pro:
2623         * WebCore.vcproj/WebCore.vcproj:
2624         * WebCore.xcodeproj/project.pbxproj:
2625         * platform/DeprecatedPtrList.h: Removed.
2626         * platform/DeprecatedPtrListImpl.cpp: Removed.
2627         * platform/DeprecatedPtrListImpl.h: Removed.
2628
2629 2011-02-27  Andreas Kling  <kling@webkit.org>
2630
2631         Reviewed by Kenneth Rohde Christiansen.
2632
2633         [Qt] Use WTF ref counting for FontPlatformDataPrivate
2634         https://bugs.webkit.org/show_bug.cgi?id=55303
2635
2636         Make FontPlatformDataPrivate a RefCounted<FPDP>.
2637         Incidentally fixes an uninitialized member bug in FontPlatformData().
2638
2639         * platform/graphics/qt/FontPlatformData.h:
2640         (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
2641         (WebCore::FontPlatformData::FontPlatformData):
2642         (WebCore::FontPlatformData::isHashTableDeletedValue):
2643         (WebCore::FontPlatformData::font):
2644         (WebCore::FontPlatformData::size):
2645         (WebCore::FontPlatformData::family):
2646         (WebCore::FontPlatformData::bold):
2647         (WebCore::FontPlatformData::italic):
2648         (WebCore::FontPlatformData::smallCaps):
2649         (WebCore::FontPlatformData::pixelSize):
2650         * platform/graphics/qt/FontPlatformDataQt.cpp:
2651         (WebCore::toQFontWeight):
2652         (WebCore::FontPlatformData::operator==):
2653         (WebCore::FontPlatformData::hash):
2654
2655 2011-02-27  Benjamin Poulain  <ikipou@gmail.com>
2656
2657         Reviewed by Darin Adler.
2658
2659         Eliminate DeprecatedPtrList from RenderBlock
2660         https://bugs.webkit.org/show_bug.cgi?id=54972
2661
2662         Refactor RenderBlock to get rid of the DeprecatedPtrList.
2663         The floating objects are stored in a ListHashSet.
2664
2665         Refactoring covered by existing test.
2666
2667         * rendering/RenderBlock.cpp:
2668         (WebCore::RenderBlock::~RenderBlock):
2669         (WebCore::RenderBlock::addOverflowFromFloats):
2670         (WebCore::RenderBlock::repaintOverhangingFloats):
2671         (WebCore::RenderBlock::paintFloats):
2672         (WebCore::RenderBlock::selectionGaps):
2673         (WebCore::RenderBlock::insertFloatingObject):
2674         (WebCore::RenderBlock::removeFloatingObject):
2675         (WebCore::RenderBlock::removeFloatingObjectsBelow):
2676         (WebCore::RenderBlock::positionNewFloats):
2677         (WebCore::RenderBlock::positionNewFloatOnLine):
2678         (WebCore::RenderBlock::logicalLeftOffsetForLine):
2679         (WebCore::RenderBlock::logicalRightOffsetForLine):
2680         (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
2681         (WebCore::RenderBlock::lowestFloatLogicalBottom):
2682         (WebCore::RenderBlock::clearFloats):
2683         (WebCore::RenderBlock::addOverhangingFloats):
2684         (WebCore::RenderBlock::addIntrudingFloats):
2685         (WebCore::RenderBlock::containsFloat):
2686         (WebCore::RenderBlock::hitTestFloats):
2687         (WebCore::RenderBlock::adjustForBorderFit):
2688         * rendering/RenderBlock.h:
2689         (WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
2690         (WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
2691         (WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
2692         (WebCore::RenderBlock::FloatingObjectHashTranslator::equal):
2693         * rendering/RenderBlockLineLayout.cpp:
2694         (WebCore::RenderBlock::layoutInlineChildren):
2695         (WebCore::RenderBlock::matchedEndLine):
2696
2697 2011-02-26  Adam Barth  <abarth@webkit.org>
2698
2699         Reviewed by Eric Seidel.
2700
2701         <input value="type=submit"> throws a warning (“HTML parse error”)
2702         https://bugs.webkit.org/show_bug.cgi?id=55120
2703
2704         This patch removes parse error messages from the HTML parser.  These
2705         messages are displayed at the wrong times, aren't tested, and aren't
2706         helpful.  We'll try again with some more informative messages and
2707         better testing.
2708
2709         * html/parser/HTMLTreeBuilder.cpp:
2710         (WebCore::HTMLTreeBuilder::parseError):
2711
2712 2011-02-26  Patrick Gansterer  <paroga@webkit.org>
2713
2714         Reviewed by Alexey Proskuryakov.
2715
2716         Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
2717         https://bugs.webkit.org/show_bug.cgi?id=55309
2718
2719         This functions are obsolete, since r78499 added TextCodecUTF8.
2720
2721         * platform/text/TextEncodingRegistry.cpp:
2722         (WebCore::buildBaseTextCodecMaps):
2723         * platform/text/brew/TextCodecBrew.cpp:
2724         * platform/text/brew/TextCodecBrew.h:
2725
2726 2011-02-26  Justin Schuh  <jschuh@chromium.org>
2727
2728         Reviewed by Darin Adler.
2729
2730         Delay firing of mutation events while setting attribute values
2731         https://bugs.webkit.org/show_bug.cgi?id=55199
2732
2733         Test: fast/dom/attribute-change-on-mutate.html
2734
2735         * dom/Attr.cpp:
2736         (WebCore::Attr::setValue):
2737
2738 2011-02-26  Yi Shen  <yi.4.shen@nokia.com>
2739
2740         Reviewed by Andreas Kling.
2741
2742         [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
2743         https://bugs.webkit.org/show_bug.cgi?id=55252
2744
2745         Need to invoke a callback function to notify the HTMLMediaElement
2746         when MediaPlayerPrivateQt's playback state gets changed.
2747
2748         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
2749         (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll
2750         (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement
2751         (WebCore::MediaPlayerPrivateQt::stateChanged):
2752         * platform/graphics/qt/MediaPlayerPrivateQt.h:
2753
2754 2011-02-25  Abhishek Arya  <inferno@chromium.org>
2755
2756         Reviewed by Adam Barth.
2757
2758         When plugin document parser finishes parsing, it runs the raw
2759         document's parser finish functions which call the pending document
2760         onload events that removes the frame from underneath. So, we protect
2761         frame (and hence frameloader) in DocumentLoader::commitLoad.
2762         https://bugs.webkit.org/show_bug.cgi?id=55289
2763
2764         Test: fast/frames/iframe-plugin-load-remove-document-crash.html
2765
2766         * loader/DocumentLoader.cpp:
2767         (WebCore::DocumentLoader::commitLoad):
2768
2769 2011-02-26  Pavel Feldman  <pfeldman@chromium.org>
2770
2771         Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.
2772
2773 2011-02-26  Pavel Feldman  <pfeldman@chromium.org>
2774
2775         Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
2776         https://bugs.webkit.org/show_bug.cgi?id=55302
2777
2778         * CMakeLists.txt:
2779
2780 2011-02-25  Vsevolod Vlasov  <vsevik@chromium.org>
2781
2782         Reviewed by Pavel Feldman.
2783
2784         XML without style should render as syntax-highlighted source.
2785         https://bugs.webkit.org/show_bug.cgi?id=13807
2786
2787         XML tree view mode implemented. If XML does not have any style
2788         information, it is rendered as highlighted source with collapsable
2789         elements.
2790
2791         Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
2792                http/tests/xmlviewer/dumpAsText/frames.html
2793                http/tests/xmlviewer/dumpAsText/mathml.xml
2794                http/tests/xmlviewer/dumpAsText/svg.xml
2795                http/tests/xmlviewer/dumpAsText/wml.xml
2796                http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
2797                http/tests/xmlviewer/dumpAsText/xlink.xml
2798                http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
2799                http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
2800                http/tests/xmlviewer/dumpAsText/xmlviewer.xml
2801                http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
2802                http/tests/xmlviewer/dumpAsText/xul.xml
2803
2804         * CMakeLists.txt:
2805         * DerivedSources.make:
2806         * GNUmakefile.am:
2807         * WebCore.gyp/WebCore.gyp:
2808         * WebCore.gypi:
2809         * WebCore.vcproj/WebCore.vcproj:
2810         * WebCore.xcodeproj/project.pbxproj:
2811         * css/CSSStyleSelector.cpp:
2812         (WebCore::CSSStyleSelector::matchUARules):
2813         * dom/Document.cpp:
2814         (WebCore::Document::Document):
2815         (WebCore::Document::createElement):
2816         * dom/Document.h:
2817         (WebCore::Document::usesViewSourceStyles):
2818         (WebCore::Document::setUsesViewSourceStyles):
2819         (WebCore::Document::sawElementsInKnownNamespaces):
2820         * dom/XMLDocumentParser.h:
2821         * dom/XMLDocumentParserLibxml2.cpp:
2822         (WebCore::XMLDocumentParser::XMLDocumentParser):
2823         (WebCore::XMLDocumentParser::processingInstruction):
2824         (WebCore::XMLDocumentParser::initializeParserContext):
2825         (WebCore::XMLDocumentParser::doEnd):
2826         * dom/XMLDocumentParserQt.cpp:
2827         (WebCore::XMLDocumentParser::XMLDocumentParser):
2828         (WebCore::XMLDocumentParser::initializeParserContext):
2829         (WebCore::XMLDocumentParser::parseProcessingInstruction):
2830         * html/HTMLViewSourceDocument.cpp:
2831         (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
2832         * xml/XMLTreeViewer.cpp: Added.
2833         (WebCore::XMLTreeViewer::XMLTreeViewer):
2834         (WebCore::XMLTreeViewer::hasNoStyleInformation):
2835         (WebCore::XMLTreeViewer::transformDocumentToTreeView):
2836         * xml/XMLTreeViewer.h: Added.
2837         (WebCore::XMLTreeViewer::~XMLTreeViewer):
2838         * xml/XMLViewer.xsl: Added.
2839         * xml/XSLStyleSheet.h:
2840         (WebCore::XSLStyleSheet::createFromString):
2841
2842 2011-02-26  Andreas Kling  <kling@webkit.org>
2843
2844         Reviewed by Kenneth Rohde Christiansen.
2845
2846         [Qt] Enable usage of synchronous HTTP feature in Qt
2847         https://bugs.webkit.org/show_bug.cgi?id=37191
2848
2849         Currently, we spin an event loop when doing synchronous calls to
2850         wait for completion. This patch uses synchronous requests in Qt,
2851         if available, and spins the event loop as a fallback solution.
2852
2853         Based on work by Simon Hausmann and Peter Hartmann.
2854
2855         * platform/network/qt/QNetworkReplyHandler.cpp:
2856         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2857         (WebCore::QNetworkReplyHandler::start):
2858         * platform/network/qt/QNetworkReplyHandler.h:
2859         * platform/network/qt/ResourceHandleQt.cpp:
2860         (WebCore::WebCoreSynchronousLoader::setReplyFinished):
2861         (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
2862         (WebCore::WebCoreSynchronousLoader::didFinishLoading):
2863         (WebCore::WebCoreSynchronousLoader::didFail):
2864         (WebCore::ResourceHandle::loadResourceSynchronously):
2865
2866 2011-02-26  Ryosuke Niwa  <rniwa@webkit.org>
2867
2868         Reviewed by Kent Tamura.
2869
2870         REGRESSION(r79398): Webkit crash on dojo theme tester page
2871         https://bugs.webkit.org/show_bug.cgi?id=55290
2872
2873         The bug was caused by selectionStartCSSPropertyValue's not considering the possibility
2874         of selectionStartStyle() returning a null pointer. Fixed it by adding a null check.
2875
2876         Test: editing/execCommand/value-without-selection-crash.html
2877
2878         * editing/Editor.cpp:
2879         (WebCore::Editor::selectionStartCSSPropertyValue):
2880
2881 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2882
2883         Reviewed by Pavel Feldman.
2884
2885         DumpRenderTree should reset frame opener between tests.
2886         https://bugs.webkit.org/show_bug.cgi?id=54874
2887
2888         No new tests. (no code affected, just exporting a method for DumpRenderTree use)
2889
2890         * WebCore.exp.in:
2891
2892 2011-02-26  Jia Pu  <jpu@apple.com>
2893
2894         Reviewed by Dan Bernstein.
2895
2896         On Mac, need to remove misspell underline in Editor::learnSpelling().
2897         https://bugs.webkit.org/show_bug.cgi?id=55251
2898
2899         This change makes sure that the misspelling markers are removed after the word is learned.
2900
2901         * editing/Editor.cpp:
2902         (WebCore::Editor::learnSpelling):
2903
2904 2011-02-26  Rik Cabanier  <cabanier@adobe.com>
2905
2906         Reviewed by David Hyatt.
2907
2908         Fix that allows fixed length values to be floating point
2909         https://bugs.webkit.org/show_bug.cgi?id=52699
2910
2911         Transitions now return matrices in floating point. 2 of the transition tests were failing
2912         because they expected integer values.
2913
2914         * WebCore.xcodeproj/project.pbxproj:
2915         * css/CSSStyleSelector.cpp:
2916         (WebCore::convertToLength):
2917         (WebCore::convertToIntLength):
2918         (WebCore::convertToFloatLength):
2919         (WebCore::CSSStyleSelector::applyProperty):
2920         (WebCore::CSSStyleSelector::createTransformOperations):
2921         * platform/Length.h:
2922         (WebCore::Length::Length):
2923         (WebCore::Length::operator==):
2924         (WebCore::Length::operator!=):
2925         (WebCore::Length::rawValue):
2926         (WebCore::Length::type):
2927         (WebCore::Length::quirk):
2928         (WebCore::Length::setValue):
2929         (WebCore::Length::calcFloatValue):
2930         (WebCore::Length::isZero):
2931         (WebCore::Length::blend):
2932         (WebCore::Length::getIntValue):
2933         (WebCore::Length::getFloatValue):
2934         * rendering/AutoTableLayout.cpp:
2935         (WebCore::AutoTableLayout::recalcColumn):
2936         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
2937         * rendering/FixedTableLayout.cpp:
2938         (WebCore::FixedTableLayout::calcWidthArray):
2939
2940 2011-02-26  Eric Seidel  <eric@webkit.org>
2941
2942         Reviewed by Maciej Stachowiak.
2943
2944         malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
2945         https://bugs.webkit.org/show_bug.cgi?id=55204
2946
2947         * dom/ContainerNode.cpp:
2948         (WebCore::ContainerNode::removeChildren):
2949          - Using an inlineCapacity of 10 for now. We may want to tweak it later.
2950          - This removes yet another malloc from code which removes nodes (which is rather common).
2951
2952 2011-02-26  Eric Seidel  <eric@webkit.org>
2953
2954         Reviewed by Maciej Stachowiak.
2955
2956         HashSet<T>::end() creation is expensive and should be avoided
2957         https://bugs.webkit.org/show_bug.cgi?id=55205
2958
2959         In the common case, m_ranges is an empty set.  When that's
2960         the case, we spend all our time in skipEmptyBuckets, walking
2961         the hash storage skipping over empty buckets.
2962
2963         This looks to be at least a 5% speedup on (my local version of) peacekeeper's domDynamicCreationCreateElement.
2964
2965         Before:
2966         avg 383.6666666666667
2967         median 386
2968         stdev 7.152311203768722
2969         min 360
2970         max 391
2971
2972         After:
2973         avg 366.3333333333333
2974         median 366
2975         stdev 2.712112747574399
2976         min 362
2977         max 377
2978
2979         * dom/Document.cpp:
2980         (WebCore::Document::nodeChildrenChanged):
2981         (WebCore::Document::nodeChildrenWillBeRemoved):
2982         (WebCore::Document::nodeWillBeRemoved):
2983         (WebCore::Document::textInserted):
2984         (WebCore::Document::textRemoved):
2985         (WebCore::Document::textNodesMerged):
2986         (WebCore::Document::textNodeSplit):
2987
2988 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2989
2990         Unreviewed, rolling out r79764.
2991         http://trac.webkit.org/changeset/79764
2992         https://bugs.webkit.org/show_bug.cgi?id=55295
2993
2994         "broke Chromium builds" (Requested by rniwa on #webkit).
2995
2996         * WebCore.exp.in:
2997
2998 2011-02-26  Adam Klein  <adamk@chromium.org>
2999
3000         Reviewed by Adam Barth.
3001
3002         [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
3003         https://bugs.webkit.org/show_bug.cgi?id=54585
3004
3005         In order to move toURI to EntryBase, it needed access to
3006         SecurityOrigin. Most of the changes below were to pass a
3007         ScriptExecutionContext to DOMFileSystemBase to enable this.
3008
3009         Test: fast/filesystem/workers/file-entry-to-uri-sync.html
3010
3011         * WebCore.gypi:
3012         * WebCore.xcodeproj/project.pbxproj:
3013         * fileapi/DOMFileSystem.cpp:
3014         (WebCore::DOMFileSystem::DOMFileSystem):
3015         * fileapi/DOMFileSystemBase.cpp:
3016         (WebCore::DOMFileSystemBase::DOMFileSystemBase):
3017         (WebCore::DOMFileSystemBase::securityOrigin):
3018         * fileapi/DOMFileSystemBase.h:
3019         (WebCore::DOMFileSystemBase::create):
3020         * fileapi/DOMFileSystemSync.cpp:
3021         (WebCore::DOMFileSystemSync::create):
3022         (WebCore::DOMFileSystemSync::DOMFileSystemSync):
3023         * fileapi/DOMFileSystemSync.h:
3024         (WebCore::DOMFileSystemSync::create):
3025         * fileapi/Entry.cpp:
3026         * fileapi/Entry.h:
3027         * fileapi/EntryBase.cpp: Added.
3028         (WebCore::EntryBase::EntryBase):
3029         (WebCore::EntryBase::~EntryBase):
3030         (WebCore::EntryBase::toURI):
3031         * fileapi/EntryBase.h:
3032         * fileapi/EntrySync.idl:
3033
3034 2011-02-26  Alice Boxhall  <aboxhall@chromium.org>
3035
3036         Reviewed by Ojan Vafai.
3037
3038         typing enter in the input element should not fire textInput
3039         https://bugs.webkit.org/show_bug.cgi?id=54152
3040
3041         Stop textInput event propagation in HTMLInputElement::preDispatchEventHandler if the event target should submit implicitly.
3042
3043         Test: fast/forms/textinput-not-fired-on-enter-in-input.html
3044
3045         * html/HTMLInputElement.cpp:
3046         (WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType->shouldSubmitImplicitly for textInputEvents and stop propagation if true.
3047
3048 2011-02-26  James Simonsen  <simonjam@chromium.org>
3049
3050         Reviewed by Tony Gentilcore.
3051
3052         [Web Timing] loadEvent timing should refer to first load event if there are many
3053         https://bugs.webkit.org/show_bug.cgi?id=55201
3054
3055         Test: fast/dom/webtiming-document-open.html
3056
3057         * page/DOMWindow.cpp:
3058         (WebCore::DOMWindow::dispatchLoadEvent):
3059
3060 2011-02-26  Tony Gentilcore  <tonyg@chromium.org>
3061
3062         Reviewed by Adam Barth.
3063
3064         Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
3065         https://bugs.webkit.org/show_bug.cgi?id=54810
3066
3067         No new tests because no new functionality.
3068
3069         * dom/Document.cpp:
3070         (WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare
3071         minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was
3072         broken by r52919. The effect would be that ports that set an extra layout delay can't yield
3073         between tokens. Note: can't be const because minimumLayoutDelay sets a member.
3074         * dom/Document.h:
3075         * html/parser/HTMLParserScheduler.cpp:
3076         (WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
3077         (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
3078
3079 2011-02-26  David Dorwin  <ddorwin@chromium.org>
3080
3081         Reviewed by Darin Fisher.
3082
3083         Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.
3084
3085         fullscreen javascript bindings not implemented for v8
3086         https://bugs.webkit.org/show_bug.cgi?id=44797
3087
3088         Tested by the existing fullscreen Layout Tests.
3089
3090         * WebCore.gyp/WebCore.gyp:
3091         * WebCore.gypi:
3092
3093 2011-02-26  Tony Gentilcore  <tonyg@chromium.org>
3094
3095         Reviewed by Adam Barth.
3096
3097         Prevent parser yields from triggering early dumpAsText()
3098         https://bugs.webkit.org/show_bug.cgi?id=55187
3099
3100         DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPISense()
3101         indicates the page is done. isLoadingInAPISense depends on
3102         HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
3103         insert() or append().
3104
3105         This means that if the parser is pumping in a resumeParsingAfterScriptExecution() or
3106         resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. This patch
3107         fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLevel and
3108         incrementing it in pumpTokenizer().
3109
3110         When I locally cause the parser to yield after every token, a lot of tests fail
3111         because DRT snapshots too early. This patch fixes those tests, however I'm having
3112         trouble writing a test case that reliably reproduces the problem without this patch
3113         and passes with it (without changing yield constants). This is because it requires
3114         4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 12k, which
3115         doesn't always happen).
3116
3117         * html/parser/HTMLDocumentParser.cpp:
3118         (WebCore::HTMLDocumentParser::HTMLDocumentParser):
3119         (WebCore::HTMLDocumentParser::~HTMLDocumentParser):
3120         (WebCore::HTMLDocumentParser::processingData):
3121         (WebCore::HTMLDocumentParser::pumpTokenizer):
3122         (WebCore::HTMLDocumentParser::insert):
3123         (WebCore::HTMLDocumentParser::append):
3124         * html/parser/HTMLDocumentParser.h:
3125         (WebCore::HTMLDocumentParser::inPumpSession):
3126         (WebCore::HTMLDocumentParser::shouldDelayEnd):
3127         * html/parser/HTMLParserScheduler.h:
3128         (WebCore::PumpSession::PumpSession):
3129         * html/parser/NestingLevelIncrementer.h:
3130
3131 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
3132
3133         Reviewed by David Kilzer.
3134
3135         https://bugs.webkit.org/show_bug.cgi?id=48781
3136
3137         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
3138
3139         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
3140         should paint the default broken image when an image fails to load or decode.  The method also passes the
3141         URL of the failed image.
3142
3143         Test: fast/images/support-broken-image-delegate.html
3144
3145         * loader/FrameLoaderClient.h:
3146         (WebCore::FrameLoaderClient::shouldPaintBrokenImage):
3147         * loader/cache/CachedImage.cpp:
3148         (WebCore::CachedImage::CachedImage):
3149         (WebCore::CachedImage::image):
3150         (WebCore::CachedImage::checkShouldPaintBrokenImage):
3151         (WebCore::CachedImage::error):
3152         * loader/cache/CachedImage.h:
3153
3154 2011-02-26  Chris Evans  <cevans@chromium.org>
3155
3156         Reviewed by Adam Barth.
3157
3158         Database: Data race: should only touch the transaction queue inside the
3159         lock.
3160         https://bugs.webkit.org/show_bug.cgi?id=55031
3161
3162         * storage/Database.cpp:
3163         (WebCore::Database::changeVersion): only touch queue inside lock.
3164         (WebCore::Database::runTransaction): only touch queue inside lock.
3165
3166 2011-02-26  Yi Shen  <yi.4.shen@nokia.com>
3167
3168         Reviewed by Eric Carlson.
3169
3170         Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
3171         https://bugs.webkit.org/show_bug.cgi?id=55147
3172
3173         When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
3174         a volumechangeEvent event should be fired if the volume gets changed.
3175
3176         Test: media/event-attributes.html
3177
3178         * html/HTMLMediaElement.cpp:
3179         (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0.
3180         (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.
3181
3182 2011-02-26  Eric Seidel  <eric@webkit.org>
3183
3184         Reviewed by Maciej Stachowiak.
3185
3186         disableRangeMutation quirk for mail slows down peacekeeper domDynamicCreationCreateElement
3187         https://bugs.webkit.org/show_bug.cgi?id=55127
3188
3189         Before:
3190         avg 513.4
3191         median 515
3192         stdev 7.234638899074368
3193         min 490
3194         max 528
3195
3196         After:
3197         avg 508.15
3198         median 510
3199         stdev 6.966168243733426
3200         min 485
3201         max 515
3202
3203         Yes, the stdev is a bit high to actually support my conclusions.  But looking
3204         at the profile, this change makes a lot of sense.  I'll up the iterations
3205         for future testing.
3206
3207         * dom/Document.cpp:
3208         (WebCore::disableRangeMutation):
3209          - This check should only be compiled in if we're planning to run on Tiger or Leopard.
3210
3211 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3212
3213         Reviewed by Pavel Feldman.
3214
3215         DumpRenderTree should reset frame opener between tests.
3216         https://bugs.webkit.org/show_bug.cgi?id=54874
3217
3218         No new tests. (no code affected, just exporting a method for DumpRenderTree use)
3219
3220         * WebCore.exp.in:
3221
3222 2011-02-26  Chang Shu  <chang.shu@nokia.com>
3223
3224         Reviewed by Antonio Gomes.
3225
3226         Based on patch by Carlos Garcia Campos  <cgarcia@igalia.com>.
3227
3228         Spatial Navigation: Add support for <select> element in multiple selection mode
3229         https://bugs.webkit.org/show_bug.cgi?id=49261
3230
3231         When spatial navigation is enabled, use space key to toggle select
3232         items. And the up and down keys should not affect selection but just
3233         navigate through items, which is indicated visually by a focus ring.
3234
3235         New Test: fast/spatial-navigation/snav-single-select-list.html
3236         Enhanced Test: fast/spatial-navigation/snav-multiple-select.html
3237
3238         * dom/SelectElement.cpp:
3239         (WebCore::SelectElement::listBoxDefaultEventHandler):
3240         * rendering/RenderListBox.cpp:
3241         (WebCore::RenderListBox::addFocusRingRects):
3242         * rendering/RenderListBox.h:
3243
3244 2011-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3245
3246         Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.
3247
3248         * editing/EditingStyle.cpp:
3249
3250 2011-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3251
3252         Reviewed by Darin Adler.
3253
3254         Move HTMLEquivalent and its subclasses to EditingStyle
3255         https://bugs.webkit.org/show_bug.cgi?id=55207
3256
3257         Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to EditingStyle,
3258         and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquivalent,
3259         and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDecorationEquivalent,
3260         HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.
3261
3262         Also extracted the logic to determine which element and attribute are removed
3263         as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttributes,
3264         and extractConflictingImplicitStyleOfAttributes.
3265
3266         * editing/ApplyStyleCommand.cpp:
3267         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
3268         (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
3269         * editing/ApplyStyleCommand.h:
3270         * editing/EditingStyle.cpp:
3271         (WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.cpp.
3272         (WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto.
3273         (WebCore::HTMLElementEquivalent::matches): Ditto.
3274         (WebCore::HTMLElementEquivalent::hasAttribute): Ditto.
3275         (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto.
3276         (WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto.
3277         (WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto.
3278         (WebCore::HTMLElementEquivalent::addToStyle): Ditto.
3279         (WebCore::HTMLTextDecorationEquivalent::create): Ditto.
3280         (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Ditto.
3281         (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto.
3282         (WebCore::HTMLAttributeEquivalent::create): Ditto.
3283         (WebCore::HTMLAttributeEquivalent::matches): Ditto.
3284         (WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto.
3285         (WebCore::HTMLAttributeEquivalent::attributeName): Ditto.
3286         (WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto.
3287         (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto.
3288         (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
3289         (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto.
3290         (WebCore::HTMLFontSizeEquivalent::create): Ditto.
3291         (WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto.
3292         (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto.
3293         (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added.
3294         (WebCore::htmlAttributeEquivalents): Added.
3295         (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added.
3296         (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Added.
3297         * editing/EditingStyle.h:
3298
3299 2011-02-25  Chris Fleizach  <cfleizach@apple.com>
3300
3301         Reviewed by Anders Carlsson.
3302
3303         AX: Add Xcode entries back to the navigator list for Accessibility cpp files
3304         https://bugs.webkit.org/show_bug.cgi?id=55280
3305
3306         * WebCore.xcodeproj/project.pbxproj:
3307
3308 2011-02-25  Fumitoshi Ukai  <ukai@chromium.org>
3309
3310         Reviewed by Adam Barth.
3311
3312         WebSocket uses insecure random numbers
3313         https://bugs.webkit.org/show_bug.cgi?id=54714
3314
3315         * websockets/WebSocketHandshake.cpp:
3316         (WebCore::randomNumberLessThan):
3317         (WebCore::generateSecWebSocketKey):
3318         (WebCore::generateKey3):
3319
3320 2011-02-25  Eric Carlson  <eric.carlson@apple.com>
3321
3322         Reviewed by Darin Adler.
3323
3324         Add API to enumerate/delete files downloaded for <audio> and <video>
3325         https://bugs.webkit.org/show_bug.cgi?id=55267
3326
3327         Add review changes missed in r79737.
3328
3329         * html/HTMLMediaElement.cpp:
3330         (WebCore::HTMLMediaElement::clearMediaCacheForSite): Pass string by reference.
3331         * html/HTMLMediaElement.h:
3332         * platform/graphics/MediaPlayer.cpp:
3333         (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
3334         * platform/graphics/MediaPlayer.h:
3335         * platform/graphics/MediaPlayerPrivate.h:
3336         (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
3337
3338 2011-02-25  Eric Carlson  <eric.carlson@apple.com>
3339
3340         Reviewed by Darin Adler.
3341
3342         Add API to enumerate/delete files downloaded for <audio> and <video>
3343         https://bugs.webkit.org/show_bug.cgi?id=55267
3344         <rdar://problem/9049280>
3345
3346         No new tests, this is just the plumbing.
3347
3348         * html/HTMLMediaElement.cpp:
3349         (WebCore::HTMLMediaElement::getSitesInMediaCache): New, call through to MediaPlayer.
3350         (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
3351         (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
3352         * html/HTMLMediaElement.h:
3353
3354         * platform/graphics/MediaPlayer.cpp:
3355         (WebCore::MediaPlayer::getSitesInMediaCache): New, call through to media engine.
3356         (WebCore::MediaPlayer::clearMediaCache): Ditto.
3357         (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
3358         * platform/graphics/MediaPlayer.h:
3359
3360         * platform/graphics/MediaPlayerPrivate.h:
3361         (WebCore::MediaPlayerPrivateInterface::getSitesInMediaCache): Declare new interface.
3362         (WebCore::MediaPlayerPrivateInterface::clearMediaCache): Ditto.
3363         (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
3364
3365 2011-02-25  Abhishek Arya  <inferno@chromium.org>
3366
3367         Reviewed by Dave Hyatt.
3368
3369         Don't add inline continuation outline to the containing block's
3370         continuationOutlineTable list if it is not enclosed by an anonymous block.
3371         https://bugs.webkit.org/show_bug.cgi?id=54690
3372
3373         We currently don't reconnect inline continuations after a child removal.
3374         As a result, those merged inlines do not get seperated and hence not get enclosed
3375         by anonymous blocks. In this case, it is better to bail out and paint it ourself.
3376
3377         Test: fast/table/table-continuation-outline-paint-crash.html
3378
3379         * rendering/InlineFlowBox.cpp:
3380         (WebCore::InlineFlowBox::paint):
3381         * rendering/RenderBlock.cpp:
3382         (WebCore::RenderBlock::paintsContinuationOutline): helper function to tell
3383         if this containing block has the continuation flow in its continuations list.
3384         * rendering/RenderBlock.h: helper function definition.
3385         * rendering/RenderInline.cpp:
3386         (WebCore::RenderInline::destroy): debug only code that asserts if we leave
3387         behind a continuation in the containing block's continuation list when it is
3388         getting destroyed.
3389
3390 2011-02-25  David Hyatt  <hyatt@apple.com>
3391
3392         Reviewed by Adam Roben.
3393
3394         https://bugs.webkit.org/show_bug.cgi?id=55265, remove the unused "Static" type
3395         from Length.
3396
3397         * css/CSSPrimitiveValue.cpp:
3398         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3399         * platform/Length.h:
3400         (WebCore::Length::isFixed):
3401         * rendering/AutoTableLayout.cpp:
3402         (WebCore::AutoTableLayout::layout):
3403         * rendering/RenderImage.cpp:
3404         (WebCore::RenderImage::isLogicalWidthSpecified):
3405         (WebCore::RenderImage::isLogicalHeightSpecified):
3406         * rendering/RenderObject.h:
3407         (WebCore::RenderObject::markContainingBlocksForLayout):
3408         * rendering/style/RenderStyle.h:
3409         (WebCore::InheritedFlags::hasStaticX):
3410         (WebCore::InheritedFlags::hasStaticY):
3411
3412 2011-02-25  Brian Weinstein  <bweinstein@apple.com>
3413
3414         Windows build fix.
3415
3416         * platform/network/cf/CookieJarCFNet.cpp:
3417         (WebCore::getHostnamesWithCookies): Add a const_cast.
3418         (WebCore::deleteCookiesForHostname): Ditto.
3419
3420 2011-02-25  Pavel Feldman  <pfeldman@chromium.org>
3421
3422         Reviewed by Timothy Hatcher.
3423
3424         Web Inspector: Empty Elements panel after closing and reopening Inspector
3425         https://bugs.webkit.org/show_bug.cgi?id=55248
3426
3427         Fixing regression real quick. Test to follow.
3428
3429         * inspector/InspectorDOMAgent.cpp:
3430         (WebCore::InspectorDOMAgent::reset):
3431
3432 2011-02-25  Pavel Feldman  <pfeldman@chromium.org>
3433
3434         Not reviewed: added missing handle scope into V8InjectedScriptHostCustom.
3435         https://bugs.webkit.org/show_bug.cgi?id=55256
3436
3437         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
3438         (WebCore::InjectedScriptHost::nodeAsScriptValue):
3439         (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
3440
3441 2011-02-25  David Hyatt  <hyatt@apple.com>
3442
3443         Reviewed by Sam Weinig.
3444
3445         https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
3446
3447         Make positioned objects work with all possible crazy combinations of mixed writing modes.  Added new helper
3448         functions that flip around the padding box of the containing block and then add in the appropriate border
3449         side to ensure that the offset of the positioned object is actually correctly placed in the containing block's
3450         local coordinate space.
3451
3452         Added two new tests of both replaced and non-replaced positioned elements in mixed writing mode environments.
3453
3454         * rendering/RenderBox.cpp:
3455         (WebCore::computeLogicalLeftPositionedOffset):
3456         (WebCore::RenderBox::computePositionedLogicalWidthUsing):
3457         (WebCore::computeLogicalTopPositionedOffset):
3458         (WebCore::RenderBox::computePositionedLogicalHeightUsing):
3459         (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
3460         (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
3461
3462 2011-02-25  Brian Weinstein  <bweinstein@apple.com>
3463
3464         Reviewed by Brady Eidson and looked over by Jessie Berlin.
3465
3466         WebKit2: Need a way to manage cookies from the web process
3467         https://bugs.webkit.org/show_bug.cgi?id=55086
3468
3469         Implement the functions needed to manage cookies in CookieJar (getHostnamesWithCookies,
3470         deleteCookiesWithHostname, and deleteAllCookies) for Mac and CFNetwork (stub out the rest),
3471         and call them from WebKit2's WebCookieManager.
3472
3473         No change in behavior needing tests.
3474
3475         * WebCore.exp.in: Added needed functions to export.
3476         * platform/CookieJar.h:
3477
3478         * platform/mac/CookieJar.mm:
3479         (WebCore::getHostnamesWithCookies): Gets all hostnames with cookies from NSHTTPCookieStorage.
3480         (WebCore::deleteCookiesForHostname): Deletes all cookies with a given hostname from
3481             NSHTTPCookieStorage.
3482         (WebCore::deleteAllCookies): Deletes all cookies from NSHTTPCookieStorage.
3483
3484         * platform/network/cf/CookieJarCFNet.cpp:
3485         (WebCore::getHostnamesWithCookies): Implement using CFNetwork cookie APIs.
3486         (WebCore::deleteCookiesForHostname): Ditto.
3487         (WebCore::deleteAllCookies): Ditto.
3488
3489         * platform/efl/CookieJarEfl.cpp: Added stub functions.
3490 &n