Move sudden termination symbols to the Mac-only section
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2013-05-12  David Kilzer  <ddkilzer@apple.com>
2
3         Move sudden termination symbols to the Mac-only section
4
5         * WebCore.exp.in: Move the sudden termination symbols to the
6         !PLATFORM(IOS) section for reals this time.
7
8 2013-05-12  Darin Adler  <darin@apple.com>
9
10         Fix Mac build.
11
12         * platform/mac/PasteboardMac.mm: Add back include of ClipboardMac.h
13         that was removed by accident a couple of patches back.
14
15 2013-05-12  Darin Adler  <darin@apple.com>
16
17         [Mac] Moved files function from ClipboardMac to PasteboardMac
18         https://bugs.webkit.org/show_bug.cgi?id=116008
19
20         Reviewed by Anders Carlsson.
21
22         * dom/Clipboard.cpp:
23         (WebCore::Clipboard::files): Added. Moved the DOM-depdendent and
24         platform-independent part of the files function in ClipboardMac here.
25
26         * dom/Clipboard.h: Made files function non-virtual in non-legacy case.
27
28         * platform/Pasteboard.h: Removed static member function
29         absoluteURLsFromPasteboardFilenames since it can now be private to
30         PasteboardMac. Added member function readFilenames.
31
32         * platform/mac/ClipboardMac.h: Removed function member files and also
33         now-unused data member m_clipboardContents.
34
35         * platform/mac/ClipboardMac.mm: Removed files function.
36         (WebCore::ClipboardMac::ClipboardMac): Removed code to initialize
37         m_clipboardContents.
38
39         * platform/mac/PasteboardMac.mm:
40         (WebCore::absoluteURLsFromPasteboardFilenames): Changed from a static
41         member function to a file-local function.
42         (WebCore::absoluteURLsFromPasteboard): Changed to call the function
43         above in its new location.
44         (WebCore::Pasteboard::readFilenames): Added. Code from ClipboardMac,
45         minus the DOM-specific parts. Added a FIXME about the peculiar round
46         trip through NSURL this code takes.
47
48 2013-05-12  Anders Carlsson  <andersca@apple.com>
49
50         Fix WebKit2 build.
51
52         * WebCore.exp.in:
53         Put WebCore::disableSuddenTermination and WebCore::enableSuddenTermination symbols in the right section.
54
55 2013-05-12  Darin Adler  <darin@apple.com>
56
57         [Mac] Move types function from ClipboardMac to PasteboardMac
58         https://bugs.webkit.org/show_bug.cgi?id=116007
59
60         Reviewed by Anders Carlsson.
61
62         * dom/Clipboard.cpp:
63         (WebCore::Clipboard::types): Added. Calls through to Pasteboard
64         after doing checks needed at this level.
65
66         * dom/Clipboard.h: Made types function non-virtual in non-legacy case,
67         and removed non-helpful comment.
68
69         * platform/Pasteboard.h: Updated includes and comments at the top of
70         the file a bit. Removed static member function addHTMLClipboardTypesForCocoaType,
71         since it can now be private to PasteboardMac. Added member function types.
72
73         * platform/mac/ClipboardMac.h: Removed types function.
74         * platform/mac/ClipboardMac.mm: Ditto.
75
76         * platform/mac/PasteboardMac.mm:
77         (WebCore::addHTMLClipboardTypesForCocoaType): Made this a file-local
78         function instead of a static member function.
79         (WebCore::Pasteboard::types): Added. Moved from ClipboardMac.
80
81 2013-05-12  Darin Adler  <darin@apple.com>
82
83         [Mac] Move setData from ClipboardMac to PasteboardMac
84         https://bugs.webkit.org/show_bug.cgi?id=116006
85
86         Reviewed by Anders Carlsson.
87
88         * dom/Clipboard.cpp:
89         (WebCore::Clipboard::setData): Added. Calls through to Pasteboard
90         after doing checks needed at this level.
91
92         * dom/Clipboard.h: Made setData non-virtual in non-legacy case.
93
94         * platform/Pasteboard.h: Updated includes and forward declarations.
95         Removed static member function cocoaTypeFromHTMLClipboardType, since
96         it can now be private to PasteboardMac. Added static member function
97         addHTMLClipboardTypesForCocoaType, which is shared between the
98         ClipboardMac and PasteboardMac files for now. Added writeString.
99
100         * platform/mac/ClipboardMac.h: Removed setData.
101
102         * platform/mac/ClipboardMac.mm: Removed utiTypeFromCocoaType,
103         addHTMLClipboardTypesForCocoaType, and setData.
104         (WebCore::ClipboardMac::types): Call addHTMLClipboardTypesForCocoaType
105         as a Pasteboard static member function, for now.
106
107         * platform/mac/PasteboardMac.mm:
108         (WebCore::cocoaTypeFromHTMLClipboardType): Added. Moved from ClipboardMac.
109         (WebCore::Pasteboard::readString): Changed to call
110         cocoaTypeFromHTMLClipboardType as a file-local function, not a member
111         function (in fact, we didn't need to repeat the class name before, either,
112         so this is just removing something we didn't need).
113         (WebCore::utiTypeFromCocoaType): Added. Moved from ClipboardMac.
114         (WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType): Ditto.
115         (WebCore::Pasteboard::writeString): Ditto.
116
117 2013-05-12  Darin Adler  <darin@apple.com>
118
119         [Mac] Move getData from ClipboardMac to PasteboardMac
120         https://bugs.webkit.org/show_bug.cgi?id=116005
121
122         Reviewed by Anders Carlsson.
123
124         * dom/Clipboard.cpp:
125         (WebCore::Clipboard::Clipboard): Added a new boolean argument, forFileDrag,
126         to the constructor. Maybe we can find a better way to do this once we move
127         all the platforms over, but this boolean seems a good way to do it for now.
128         (WebCore::Clipboard::getData): Added. Calls through to Pasteboard after
129         doing the canReadData check, which is part of DOM rules, not the platform.
130         Also checks for the file drag case like the old ClipboardMac code did.
131
132         * dom/Clipboard.h: Made getData non-virtual in non-legacy case.
133
134         * platform/Pasteboard.h: Added a static member function named
135         absoluteURLsFromPasteboardFilenames, temporary so it can be shared between
136         ClipboardMac and PasteboardMac. Added a readString public function member,
137         and a m_changeCount data member. The type of m_changeCount is long since
138         that can always hold an NSInteger but yet is a type we can compile without
139         including the header file that defines NSInteger.
140
141         * platform/mac/ClipboardMac.h: Removed getData.
142         * platform/mac/ClipboardMac.mm: Removed getData.
143         (WebCore::ClipboardMac::ClipboardMac): Added code to pass in the new
144         forFileDrag boolean.
145         (WebCore::ClipboardMac::files): Call absoluteURLsFromPasteboardFilenames
146         as a static member function in Pasteboard since we moved it there.
147
148         * platform/mac/PasteboardMac.mm:
149         (WebCore::Pasteboard::Pasteboard): Initialize the change count, so later
150         pasteboard operations can check it.
151         (WebCore::Pasteboard::absoluteURLsFromPasteboardFilenames): Added. Moved
152         here from ClipboardMac.
153         (WebCore::absoluteURLsFromPasteboard): Ditto.
154         (WebCore::Pasteboard::readString): Added. Moved here from ClipboardMac.
155
156 2013-05-12  Anders Carlsson  <andersca@apple.com>
157
158         Stop including UnusedParam.h
159         https://bugs.webkit.org/show_bug.cgi?id=116003
160
161         Reviewed by Sam Weinig.
162
163         UnusedParam.h is empty now so there's no need to include it anymore.
164
165         * Modules/encryptedmedia/CDMPrivateAVFoundation.mm:
166         * Modules/indexeddb/IDBFactoryBackendImpl.cpp:
167         * Modules/indexeddb/IDBObjectStore.cpp:
168         * Modules/webdatabase/DatabaseServer.cpp:
169         * Modules/webdatabase/DatabaseThread.cpp:
170         * bindings/js/JSDOMWindowBase.cpp:
171         * bindings/objc/DOMObject.mm:
172         * css/CSSCursorImageValue.cpp:
173         * css/DeprecatedStyleBuilder.cpp:
174         * dom/EventDispatcher.cpp:
175         * dom/Node.cpp:
176         * editing/AlternativeTextController.h:
177         * editing/Editor.cpp:
178         * html/HTMLPlugInElement.cpp:
179         * html/canvas/CanvasRenderingContext2D.cpp:
180         * html/canvas/OESVertexArrayObject.h:
181         * html/parser/HTMLConstructionSite.cpp:
182         * html/parser/HTMLTokenizer.cpp:
183         * html/track/InbandTextTrack.cpp:
184         * inspector/InspectorCanvasInstrumentation.h:
185         * inspector/InspectorConsoleInstrumentation.h:
186         * inspector/InspectorController.cpp:
187         * inspector/InspectorCounters.h:
188         * inspector/InspectorDatabaseInstrumentation.h:
189         * inspector/InspectorInstrumentation.h:
190         * loader/DocumentThreadableLoader.cpp:
191         * loader/PingLoader.cpp:
192         * loader/appcache/ApplicationCacheGroup.cpp:
193         * loader/cache/CachedResourceLoader.cpp:
194         * loader/mac/DocumentLoaderMac.cpp:
195         * page/ChromeClient.h:
196         * page/Console.cpp:
197         * page/FrameView.cpp:
198         * page/PageConsole.cpp:
199         * page/animation/AnimationController.cpp:
200         * page/animation/ImplicitAnimation.cpp:
201         * page/animation/KeyframeAnimation.cpp:
202         * platform/LocalizedStrings.cpp:
203         * platform/ScrollAnimator.h:
204         * platform/ThreadGlobalData.cpp:
205         * platform/blackberry/AsyncFileSystemBlackBerry.cpp:
206         * platform/graphics/Font.cpp:
207         * platform/graphics/GlyphBuffer.h:
208         * platform/graphics/Gradient.cpp:
209         * platform/graphics/ShadowBlur.cpp:
210         * platform/graphics/SimpleFontData.cpp:
211         * platform/graphics/SimpleFontData.h:
212         * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
213         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
214         * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
215         * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
216         * platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
217         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
218         * platform/graphics/blackberry/GradientBlackBerry.cpp:
219         * platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
220         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
221         * platform/graphics/ca/mac/PlatformCALayerMac.mm:
222         * platform/graphics/ca/mac/WebTileLayer.mm:
223         * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
224         * platform/graphics/cg/GraphicsContextCG.cpp:
225         * platform/graphics/cg/ImageBufferCG.cpp:
226         * platform/graphics/cg/ImageSourceCG.cpp:
227         * platform/graphics/clutter/PlatformClutterAnimation.cpp:
228         * platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
229         * platform/graphics/gstreamer/GStreamerVersioning.cpp:
230         * platform/graphics/mac/GraphicsContext3DMac.mm:
231         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
232         * platform/graphics/mac/SimpleFontDataMac.mm:
233         * platform/graphics/mac/WebGLLayer.mm:
234         * platform/graphics/mac/WebLayer.mm:
235         * platform/graphics/mac/WebTiledLayer.mm:
236         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
237         * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
238         * platform/graphics/qt/GraphicsContext3DQt.cpp:
239         * platform/graphics/texmap/TextureMapper.h:
240         * platform/graphics/wince/ImageBufferWinCE.cpp:
241         * platform/mac/PasteboardMac.mm:
242         * platform/mac/ScrollAnimatorMac.mm:
243         * platform/mac/ScrollViewMac.mm:
244         * platform/mac/ScrollbarThemeMac.mm:
245         * platform/mac/SharedTimerMac.mm:
246         * platform/mac/WebCoreFullScreenPlaceholderView.mm:
247         * platform/mac/WebCoreObjCExtras.mm:
248         * platform/mac/WebFontCache.mm:
249         * platform/mac/WebVideoFullscreenController.mm:
250         * platform/mac/WebVideoFullscreenHUDWindowController.mm:
251         * platform/mac/WebWindowAnimation.mm:
252         * platform/network/blackberry/CredentialStorageBlackBerry.cpp:
253         * platform/network/cf/ResourceErrorCF.cpp:
254         * platform/network/mac/CookieStorageMac.mm:
255         * platform/network/mac/ResourceHandleMac.mm:
256         * platform/network/win/ResourceHandleWin.cpp:
257         * platform/text/TextEncodingDetectorICU.cpp:
258         * rendering/RenderFlowThread.h:
259         * rendering/RenderImage.cpp:
260         * rendering/RenderLayer.cpp:
261         * rendering/RenderObject.cpp:
262         * rendering/RenderTreeAsText.cpp:
263         * rendering/svg/RenderSVGResourceClipper.cpp:
264         * rendering/svg/RenderSVGResourceFilter.cpp:
265         * rendering/svg/RenderSVGResourceGradient.cpp:
266         * rendering/svg/RenderSVGResourceMasker.cpp:
267         * rendering/svg/SVGRenderSupport.cpp:
268         * rendering/svg/SVGTextLayoutEngineSpacing.cpp:
269         * workers/WorkerContext.cpp:
270         * workers/WorkerScriptLoader.cpp:
271         * xml/XMLHttpRequest.cpp:
272         * xml/parser/XMLDocumentParserLibxml2.cpp:
273
274 2013-05-12  Darin Adler  <darin@apple.com>
275
276         [Mac] Move clearAllData from ClipboardMac to PasteboardMac
277         https://bugs.webkit.org/show_bug.cgi?id=116001
278
279         Reviewed by Andreas Kling.
280
281         * dom/Clipboard.cpp:
282         (WebCore::Clipboard::clearAllData): Added. Calls through to Pasteboard after
283         doing the canWriteData check, which is part of DOM rules, not the platform.
284
285         * dom/Clipboard.h: Made clearAllData non-virtual in non-legacy case.
286
287         * platform/mac/ClipboardMac.h: Removed clearAllData.
288         * platform/mac/ClipboardMac.mm: Ditto.
289
290 2013-05-12  Darin Adler  <darin@apple.com>
291
292         [Mac] Move clearData from ClipboardMac to PasteboardMac
293         https://bugs.webkit.org/show_bug.cgi?id=116000
294
295         Reviewed by Andreas Kling.
296
297         * dom/Clipboard.cpp:
298         (WebCore::Clipboard::clearData): Added. Calls through to Pasteboard after
299         doing the canWriteData check, which is part of DOM rules, not the platform.
300
301         * dom/Clipboard.h: Made clearData non-virtual in non-legacy case.
302
303         * platform/Pasteboard.h: Added an overload of the clear function that takes
304         a single type and clears only that type. Also temporarily exported the
305         cocoaTypeFromHTMLClipboardType function as a static member so it can be used
306         in both ClipboardMac and PasteboardMac during the transition.
307
308         * platform/mac/ClipboardMac.h: Removed clearData.
309         * platform/mac/ClipboardMac.mm: Removed clearData.
310         (WebCore::ClipboardMac::getData): Changed to call cocoaTypeFromHTMLClipboardType
311         as a Pasteboard class static member function.
312         (WebCore::ClipboardMac::setData): Ditto.
313
314         * platform/mac/PasteboardMac.mm:
315         (WebCore::Pasteboard::cocoaTypeFromHTMLClipboardType): Moved here from
316         ClipboardMac.
317         (WebCore::Pasteboard::clear): Added. Moved here from ClipboardMac.
318
319 2013-05-12  Darin Adler  <darin@apple.com>
320
321         [Mac] Move hasData from ClipboardMac to PasteboardMac
322         https://bugs.webkit.org/show_bug.cgi?id=115999
323
324         Reviewed by Andreas Kling.
325
326         * dom/Clipboard.cpp:
327         (WebCore::Clipboard::hasData): Added. Calls through to Pasteboard.
328
329         * dom/Clipboard.h: Added LEGACY_VIRTUAL and LEGACY_PURE macros,
330         only for within this header file. These help us keep many functions
331         as pure virtual in the legacy style Clipboard class, but have them
332         be non-virtual in the normal/future style. Use LEGACY_VIRTUAL and
333         LEGACY_PURE to make the hasData member non-virtual.
334
335         * platform/Pasteboard.h: Added hasData, and added some blank lines and a FIXME.
336
337         * platform/mac/ClipboardMac.h: Removed hasData override.
338         * platform/mac/ClipboardMac.mm: Ditto.
339
340         * platform/mac/PasteboardMac.mm:
341         (WebCore::Pasteboard::hasData): Added. Moved code here from ClipboardMac.
342
343 2013-05-12  David Kilzer  <ddkilzer@apple.com>
344
345         BUILD FIX (r149971): sudden termination is a Mac-only concept
346
347         * WebCore.exp.in: Move sudden termination symbols to Mac-only
348         section.
349
350 2013-05-12  Andreas Kling  <akling@apple.com>
351
352         Node: Use FINAL instead of the non-virtual shadowing hack.
353         <http://webkit.org/b/115995>
354
355         Reviewed by Anders Carlsson.
356
357         Decorate Element/Attr implementations of prefix/localName/namespaceURI getters with FINAL
358         so that call sites with a more specific pointer type than Node* can avoid the virtual dispatch.
359
360         * dom/Attr.h:
361         * dom/Element.h:
362         * dom/Node.cpp:
363         * dom/Node.h:
364
365 2013-05-11  Darin Adler  <darin@apple.com>
366
367         [Mac] Give every Clipboard an underlying Pasteboard
368         https://bugs.webkit.org/show_bug.cgi?id=115979
369
370         Reviewed by Andreas Kling.
371
372         This is the first step in Clipboard and Pasteboard refactoring
373         to fix the overlap and many layering violations.
374
375         * dom/Clipboard.cpp:
376         (WebCore::Clipboard::Clipboard): Add an m_pasteboard data member,
377         Mac-only for now, but eventually for all platforms.
378         (WebCore::Clipboard::~Clipboard): No longer inline the destructor.
379
380         * dom/Clipboard.h: Add WTF_USE_LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS
381         flag, currently true for all non-Mac platforms. Make the constructor
382         no longer inline. Added a PassOwnPtr<Pasteboard> argument to the
383         constructor and an OwnPtr<Pasteboard> data member.
384
385         * platform/Pasteboard.h: Added a create function to make it easy
386         to create a pasteboard given a pasteboard name.
387
388         * platform/mac/ClipboardMac.mm:
389         (WebCore::ClipboardMac::ClipboardMac): Create a pasteboard and pass
390         it to the Clipboard constructor.
391
392         * platform/mac/PasteboardMac.mm:
393         (WebCore::Pasteboard::create): Added.
394
395 2013-05-12  Andreas Kling  <akling@apple.com>
396
397         Unload event listeners should prevent Safari from insta-killing the web process on last tab close.
398         <http://webkit.org/b/115988>
399         <rdar://problem/13870943>
400
401         Reviewed by Anders Carlsson.
402
403         Add two methods to Chrome (and ChromeClient):
404
405             - enableSuddenTermination()
406             - disableSuddenTermination()
407
408         ..and call these from DOMWindow instead of the free global functions.
409
410         For WebKit1, it just calls the NSProcessInfo methods to keep behavior the same.
411         For WebKit2, the new methods plumb through the information to the UI process.
412
413         Also updated the DOMWindow logic to think in terms of per-DOMWindow sudden termination counters
414         instead of a process-global one, since that gets confusing in a WK2 world.
415         When a DOMWindow transitions between having/not having unload/beforeunload event listeners,
416         we send a notification to the Chrome.
417
418         * WebCore.exp.in:
419         * WebCore.xcodeproj/project.pbxproj:
420         * page/Chrome.h:
421         (WebCore::Chrome::enableSuddenTermination):
422         (WebCore::Chrome::disableSuddenTermination):
423         * page/ChromeClient.h:
424         (WebCore::ChromeClient::enableSuddenTermination):
425         (WebCore::ChromeClient::disableSuddenTermination):
426         * page/DOMWindow.cpp:
427         (WebCore::addUnloadEventListener):
428         (WebCore::removeUnloadEventListener):
429         (WebCore::removeAllUnloadEventListeners):
430         (WebCore::addBeforeUnloadEventListener):
431         (WebCore::removeBeforeUnloadEventListener):
432         (WebCore::removeAllBeforeUnloadEventListeners):
433         (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
434         (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
435         (WebCore::DOMWindow::enableSuddenTermination):
436         (WebCore::DOMWindow::disableSuddenTermination):
437         * page/DOMWindow.h:
438         (DOMWindow):
439
440 2013-05-12  Anders Carlsson  <andersca@apple.com>
441
442         Remove Complex.h from WTF
443         https://bugs.webkit.org/show_bug.cgi?id=115989
444
445         Reviewed by Beth Dakin.
446
447         Replace Complex declarations with std::complex<double>. Pass by value since the struct
448         is small enough to go into two registers on X86-64.
449
450         * Modules/webaudio/RealtimeAnalyser.cpp:
451         (WebCore::RealtimeAnalyser::doFFTAnalysis):
452         (WebCore::RealtimeAnalyser::getFloatFrequencyData):
453         (WebCore::RealtimeAnalyser::getByteFrequencyData):
454         (WebCore::RealtimeAnalyser::getByteTimeDomainData):
455         * platform/audio/Biquad.cpp:
456         (WebCore::Biquad::setZeroPolePairs):
457         (WebCore::Biquad::setAllpassPole):
458         (WebCore::Biquad::getFrequencyResponse):
459         * platform/audio/Biquad.h:
460         * platform/audio/FFTFrame.cpp:
461         (WebCore::FFTFrame::interpolateFrequencyComponents):
462         (WebCore::FFTFrame::extractAverageGroupDelay):
463         (WebCore::FFTFrame::addConstantGroupDelay):
464
465 2013-05-12  Simon Fraser  <simon.fraser@apple.com>
466
467         Dropdowns on http://www.exploratorium.edu don't show anything
468         https://bugs.webkit.org/show_bug.cgi?id=115991
469
470         Reviewed by Dan Bernstein.
471         
472         We can't optimize away the backing store of a layer by saying that
473         it paints into a composited ancestor if its composited bounds are not contained
474         by that ancestor.
475
476         Test: compositing/backing/no-backing-for-clip-overhang.html
477
478         * rendering/RenderLayerBacking.cpp:
479         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Pass in our 
480         previously computed composited bounds relative to our composited ancestor,
481         and its composited bounds.
482         * rendering/RenderLayerCompositor.cpp:
483         (WebCore::RenderLayerCompositor::requiresOwnBackingStore): If the ancestor's
484         composited bounds don't contain the layer's composited bounds, the layer
485         needs its own backing store.
486         * rendering/RenderLayerCompositor.h:
487
488 2013-05-12  Commit Queue  <commit-queue@webkit.org>
489
490         Unreviewed, rolling out r149955.
491         http://trac.webkit.org/changeset/149955
492         https://bugs.webkit.org/show_bug.cgi?id=115990
493
494         Broke lots of tests (Requested by smfr on #webkit).
495
496         * WebCore.exp.in:
497         * rendering/InlineFlowBox.h:
498         * rendering/InlineTextBox.h:
499         (InlineTextBox):
500         * rendering/RenderApplet.h:
501         * rendering/RenderBR.h:
502         * rendering/RenderBlock.h:
503         (RenderBlock):
504         (WebCore::RenderBlock::virtualContinuation):
505         (WebCore::RenderBlock::virtualChildren):
506         (WebCore::RenderBlock::isRenderBlock):
507         (WebCore::RenderBlock::isBlockFlow):
508         (WebCore::RenderBlock::isInlineBlockOrInlineTable):
509         (WebCore::RenderBlock::dirtyLinesFromChangedChild):
510         (WebCore::RenderBlock::collapsedMarginBefore):
511         (WebCore::RenderBlock::collapsedMarginAfter):
512         * rendering/RenderBox.h:
513         (WebCore::RenderBox::borderBoundingBox):
514         (RenderBox):
515         (WebCore::RenderBox::marginLogicalLeft):
516         (WebCore::RenderBox::marginLogicalRight):
517         * rendering/RenderBoxModelObject.h:
518         (WebCore::RenderBoxModelObject::isBoxModelObject):
519         * rendering/RenderButton.h:
520         * rendering/RenderCombineText.h:
521         * rendering/RenderCounter.h:
522         * rendering/RenderDeprecatedFlexibleBox.h:
523         * rendering/RenderDetailsMarker.h:
524         * rendering/RenderEmbeddedObject.h:
525         (RenderEmbeddedObject):
526         (WebCore::RenderEmbeddedObject::isEmbeddedObject):
527         (WebCore::RenderEmbeddedObject::virtualChildren):
528         * rendering/RenderFieldset.h:
529         * rendering/RenderFileUploadControl.h:
530         * rendering/RenderFlexibleBox.h:
531         * rendering/RenderFlowThread.h:
532         * rendering/RenderFrame.h:
533         * rendering/RenderFrameSet.h:
534         * rendering/RenderFullScreen.cpp:
535         * rendering/RenderFullScreen.h:
536         * rendering/RenderGrid.h:
537         * rendering/RenderHTMLCanvas.h:
538         * rendering/RenderIFrame.h:
539         * rendering/RenderImage.h:
540         (RenderImage):
541         (WebCore::RenderImage::isRenderImage):
542         * rendering/RenderInline.h:
543         (RenderInline):
544         (WebCore::RenderInline::virtualContinuation):
545         (WebCore::RenderInline::virtualChildren):
546         (WebCore::RenderInline::isRenderInline):
547         (WebCore::RenderInline::layout):
548         (WebCore::RenderInline::requiresLayer):
549         (WebCore::RenderInline::offsetWidth):
550         (WebCore::RenderInline::offsetHeight):
551         (WebCore::RenderInline::borderBoundingBox):
552         (WebCore::RenderInline::dirtyLinesFromChangedChild):
553         * rendering/RenderLayerModelObject.h:
554         * rendering/RenderListBox.h:
555         * rendering/RenderListItem.h:
556         * rendering/RenderListMarker.h:
557         * rendering/RenderMedia.h:
558         (WebCore::RenderMedia::virtualChildren):
559         (WebCore::RenderMedia::canHaveChildren):
560         (WebCore::RenderMedia::isMedia):
561         (WebCore::RenderMedia::isImage):
562         (WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):
563         * rendering/RenderMediaControlElements.h:
564         * rendering/RenderMenuList.h:
565         * rendering/RenderMeter.h:
566         * rendering/RenderMultiColumnBlock.h:
567         * rendering/RenderMultiColumnFlowThread.h:
568         * rendering/RenderMultiColumnSet.h:
569         * rendering/RenderNamedFlowThread.h:
570         * rendering/RenderPart.h:
571         (RenderPart):
572         (WebCore::RenderPart::isRenderPart):
573         (WebCore::RenderPart::renderName):
574         * rendering/RenderProgress.h:
575         * rendering/RenderRegion.h:
576         (WebCore::RenderRegion::isRenderRegion):
577         * rendering/RenderRegionSet.h:
578         * rendering/RenderReplaced.h:
579         (RenderReplaced):
580         (WebCore::RenderReplaced::renderName):
581         * rendering/RenderReplica.h:
582         * rendering/RenderRuby.h:
583         * rendering/RenderRubyBase.h:
584         * rendering/RenderRubyRun.h:
585         * rendering/RenderRubyText.h:
586         * rendering/RenderScrollbarPart.h:
587         * rendering/RenderSearchField.h:
588         * rendering/RenderSlider.h:
589         * rendering/RenderSnapshottedPlugIn.h:
590         (RenderSnapshottedPlugIn):
591         * rendering/RenderTable.h:
592         (RenderTable):
593         (WebCore::RenderTable::renderName):
594         (WebCore::RenderTable::isTable):
595         (WebCore::RenderTable::avoidsFloats):
596         * rendering/RenderTableCaption.h:
597         * rendering/RenderTableCell.h:
598         * rendering/RenderTableCol.h:
599         * rendering/RenderTableRow.h:
600         * rendering/RenderTableSection.h:
601         * rendering/RenderText.h:
602         (RenderText):
603         (WebCore::RenderText::marginLeft):
604         (WebCore::RenderText::marginRight):
605         (WebCore::RenderText::styleWillChange):
606         (WebCore::RenderText::length):
607         (WebCore::RenderText::paint):
608         (WebCore::RenderText::layout):
609         * rendering/RenderTextControl.h:
610         (RenderTextControl):
611         (WebCore::RenderTextControl::renderName):
612         (WebCore::RenderTextControl::isTextControl):
613         (WebCore::RenderTextControl::avoidsFloats):
614         * rendering/RenderTextControlMultiLine.h:
615         * rendering/RenderTextControlSingleLine.h:
616         (RenderTextControlSingleLine):
617         (WebCore::RenderTextControlSingleLine::isTextField):
618         * rendering/RenderTextFragment.h:
619         * rendering/RenderTextTrackCue.h:
620         * rendering/RenderVideo.h:
621         * rendering/RenderView.h:
622         * rendering/RenderWidget.h:
623         (RenderWidget):
624         (WebCore::RenderWidget::isWidget):
625         * rendering/RenderWordBreak.h:
626         * rendering/RootInlineBox.h:
627         (RootInlineBox):
628         * rendering/mathml/RenderMathMLBlock.h:
629         * rendering/svg/RenderSVGBlock.h:
630         (RenderSVGBlock):
631         * rendering/svg/RenderSVGContainer.h:
632         (WebCore::RenderSVGContainer::setNeedsBoundariesUpdate):
633         (WebCore::RenderSVGContainer::virtualChildren):
634         (WebCore::RenderSVGContainer::isSVGContainer):
635         (WebCore::RenderSVGContainer::renderName):
636         (RenderSVGContainer):
637         (WebCore::RenderSVGContainer::objectBoundingBox):
638         (WebCore::RenderSVGContainer::strokeBoundingBox):
639         (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
640         * rendering/svg/RenderSVGEllipse.h:
641         * rendering/svg/RenderSVGForeignObject.h:
642         * rendering/svg/RenderSVGGradientStop.h:
643         * rendering/svg/RenderSVGHiddenContainer.h:
644         (WebCore::RenderSVGHiddenContainer::renderName):
645         (RenderSVGHiddenContainer):
646         (WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer):
647         * rendering/svg/RenderSVGImage.h:
648         * rendering/svg/RenderSVGInline.h:
649         (WebCore::RenderSVGInline::renderName):
650         (WebCore::RenderSVGInline::requiresLayer):
651         (WebCore::RenderSVGInline::isSVGInline):
652         (RenderSVGInline):
653         * rendering/svg/RenderSVGInlineText.h:
654         * rendering/svg/RenderSVGModelObject.h:
655         (WebCore::RenderSVGModelObject::requiresLayer):
656         (RenderSVGModelObject):
657         * rendering/svg/RenderSVGPath.h:
658         * rendering/svg/RenderSVGRect.h:
659         * rendering/svg/RenderSVGResourceClipper.h:
660         * rendering/svg/RenderSVGResourceContainer.h:
661         (RenderSVGResourceContainer):
662         (WebCore::RenderSVGResourceContainer::isSVGResourceContainer):
663         (WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer):
664         * rendering/svg/RenderSVGResourceFilter.h:
665         * rendering/svg/RenderSVGResourceFilterPrimitive.h:
666         * rendering/svg/RenderSVGResourceGradient.h:
667         (RenderSVGResourceGradient):
668         (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
669         * rendering/svg/RenderSVGResourceLinearGradient.h:
670         * rendering/svg/RenderSVGResourceMarker.h:
671         * rendering/svg/RenderSVGResourceMasker.h:
672         * rendering/svg/RenderSVGResourcePattern.h:
673         * rendering/svg/RenderSVGResourceRadialGradient.h:
674         * rendering/svg/RenderSVGRoot.h:
675         * rendering/svg/RenderSVGShape.h:
676         (WebCore::RenderSVGShape::setNeedsBoundariesUpdate):
677         (WebCore::RenderSVGShape::setNeedsTransformUpdate):
678         (WebCore::RenderSVGShape::repaintRectInLocalCoordinates):
679         (WebCore::RenderSVGShape::localToParentTransform):
680         (WebCore::RenderSVGShape::localTransform):
681         (WebCore::RenderSVGShape::isSVGShape):
682         (RenderSVGShape):
683         (WebCore::RenderSVGShape::objectBoundingBox):
684         (WebCore::RenderSVGShape::strokeBoundingBox):
685         * rendering/svg/RenderSVGTSpan.h:
686         * rendering/svg/RenderSVGText.h:
687         * rendering/svg/RenderSVGTextPath.h:
688         * rendering/svg/RenderSVGTransformableContainer.h:
689         * rendering/svg/RenderSVGViewportContainer.h:
690
691 2013-05-12  Anders Carlsson  <andersca@apple.com>
692
693         Simplify AutodrainedPool
694         https://bugs.webkit.org/show_bug.cgi?id=115986
695
696         Reviewed by Andreas Kling.
697
698         Remove calls to AutodrainedPool::cycle as well as the iteration counter passed to the constructor.
699         Instead, just declare RAII pools where it seems necessary.
700
701         * Modules/webdatabase/DatabaseThread.cpp:
702         (WebCore::DatabaseThread::databaseThread):
703         * fileapi/FileThread.cpp:
704         (WebCore::FileThread::runLoop):
705         * loader/icon/IconDatabase.cpp:
706         (WebCore::IconDatabase::setIconDataForIconURL):
707         (WebCore::IconDatabase::performURLImport):
708         (WebCore::IconDatabase::readFromDatabase):
709
710 2013-05-12  Andreas Kling  <akling@apple.com>
711
712         Apply FINAL to the Node hierarchy.
713         <http://webkit.org/b/115984>
714
715         Mostly from Blink r149454 by <cevans@chromium.org>
716         <http://src.chromium.org/viewvc/blink?view=revision&revision=149454>
717
718         A couple of the stable DOM/ microbenchmarks are perf positive on Linux clang:
719
720             - CloneNodes time reduced from 162.4 to 156.5 ms.
721             - CreateNodes time reduced from 113.9 to 104.9 ms.
722
723         * dom/: Beat things with the FINAL stick.
724         * html/: Ditto.
725         * svg/: Ditto.
726
727 2013-05-12  Andreas Kling  <akling@apple.com>
728
729         Devirtualize some things on Document.
730
731         From Blink r149967 by <esprehn@chromium.org>
732         <http://src.chromium.org/viewvc/blink?view=revision&revision=149967>
733
734         Several methods on Document are virtual but don't override a super class method
735         and don't need to be virtual. This patch devirtualizes:
736
737             - createElementNS()
738             - finishedParsing()
739             - suspendScriptedAnimationControllerCallbacks()
740             - resumeScriptedAnimationControllerCallbacks()
741
742         It also removes the suspend and resume callbacks from ScriptExecutionContext
743         since they didn't need to be there.
744
745         * dom/Document.h:
746         * dom/ScriptExecutionContext.h:
747
748 2013-05-12  Andreas Kling  <akling@apple.com>
749
750         Remove redundant call to removeAllEventListeners() in Document::open().
751
752         From Blink r150175 by <dcheng@chromium.org>
753         <http://src.chromium.org/viewvc/blink?view=revision&revision=150175>
754
755         Document::open() already calls Document::removeAllEventListeners(), which
756         removes the event listeners from the DOMWindow it's attached to, so
757         there's no need to do it manually here as well.
758
759         * dom/Document.cpp:
760         (WebCore::Document::open):
761
762 2013-05-12  Andreas Kling  <akling@apple.com>
763
764         Apply FINAL to the RenderObject hierarchy.
765         <http://webkit.org/b/115977>
766
767         Mostly from Blink r148795 by <cevans@chromium.org>
768         <http://src.chromium.org/viewvc/blink?view=revision&revision=148795>
769
770         * rendering/: Beat things with the FINAL stick.
771         * WebCore.exp.in: Export a now-needed symbol.
772
773 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
774
775         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
776         https://bugs.webkit.org/show_bug.cgi?id=115914
777
778         Reviewed by Martin Robinson.
779
780         * platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:
781         (WebCore::FullscreenVideoControllerGtk::hideHud):
782         (WebCore::FullscreenVideoControllerGtk::initializeWindow):
783         * platform/gtk/GtkVersioning.c:
784         * platform/gtk/GtkVersioning.h:
785         * platform/gtk/WidgetRenderingContext.cpp:
786         (WebCore::WidgetRenderingContext::WidgetRenderingContext):
787         * plugins/gtk/gtk2xtbin.c:
788         (gtk_xtbin_realize):
789
790 2013-05-11  Brent Fulgham  <bfulgham@apple.com>
791
792         [Windows] Unreviewed build fix after r149932
793
794         * make-export-file-generator: Don't attempt to import
795         (or use) non-existent cxxabi functions on Windows.
796
797 2013-05-11  Simon Fraser  <simon.fraser@apple.com>
798
799         Add more info to compositing log channel output
800         https://bugs.webkit.org/show_bug.cgi?id=115978
801
802         Reviewed by Dean Jackson.
803
804         Add to compositing log channel output whether a layer paints
805         into its compositing ancestor.
806
807         * rendering/RenderLayerCompositor.cpp:
808         (WebCore::RenderLayerCompositor::logLayerInfo):
809
810 2013-05-10  Simon Fraser  <simon.fraser@apple.com>
811
812         REGRESSION: Fixed background on ColterReed.com scrolls
813         https://bugs.webkit.org/show_bug.cgi?id=115951
814
815         Reviewed by Beth Dakin.
816         
817         The logic for painting the fixed root background into its own layer was
818         broken when the document element's layer was composited. This could be caused
819         by a negative z-index child of the body, or by an explicit compositing-causing
820         style on the <html>.
821         
822         There were two issues. First, when painting the layer for the fixed root
823         background, we would simply short-circuit the fixed background paint in
824         RenderLayer::paintLayer(), when checking for a composited layer. We have
825         to continue to paint through the composited <html> layer to get the root
826         background in this case.
827         
828         Secondly, RenderLayerBacking::paintIntoLayer() would only set the PaintLayerPaintingSkipRootBackground
829         flag if this RenderLayerBacking had a m_backgroundLayer. However, when the <html> is
830         composited, we need to skip painting the root layer for both the RenderView's backing,
831         and for the <html>'s backing. Checking whether there is *any* layer that paints
832         the fixed root background (i.e. checking compositor()->fixedRootBackgroundLayer())
833         is a simple way to fix this test.
834
835         Tests: platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html.html
836                platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed.html
837
838         * rendering/RenderLayer.cpp:
839         (WebCore::paintForFixedRootBackground):
840         (WebCore::RenderLayer::paintLayer):
841         * rendering/RenderLayerBacking.cpp:
842         (WebCore::RenderLayerBacking::paintIntoLayer):
843
844 2013-05-11  Simon Fraser  <simon.fraser@apple.com>
845
846         Possible crash when going Back while loading PDF
847         https://bugs.webkit.org/show_bug.cgi?id=115972
848
849         Reviewed by Dan Bernstein.
850
851         It's possible for m_frame to be null when Document::findUnsafeParentScrollPropagationBoundary()
852         is called, so null-check currentFrame.
853
854         * dom/Document.cpp:
855         (WebCore::Document::findUnsafeParentScrollPropagationBoundary):
856
857 2013-05-11  Alexey Proskuryakov  <ap@apple.com>
858
859         <rdar://problem/13823864> TextCodecICU complains about ambiguous codec names with current ICU release
860         https://bugs.webkit.org/show_bug.cgi?id=115953
861
862         Reviewed by Darin Adler.
863
864         Store and use canonical converter name to create converters.
865
866         As a side effect, we now actually reuse cached converters - previously we would compare
867         a standard encoding name to internal canonical one, which rarely match.
868
869         * platform/text/TextCodecICU.h:
870         * platform/text/TextCodecICU.cpp:
871         (WebCore::TextCodecICU::create): Pass canonical ICU converter name to constructor.
872         (WebCore::TextCodecICU::registerEncodingNames): 
873             - Updated terminology.
874             - Added a comment that special cases should be kept in sync between registerEncodingNames
875             and registerCodecs.
876             - Moved maccyrillic alias to a correct section. It's not present in ICU even today.
877             - Changed a few aliases to actually map to standard name, not to an overridden one
878             (this doesn't change behavior since addToTextEncodingNameMap looks up canonical
879             name, but is clearer).
880         (WebCore::TextCodecICU::registerCodecs): Store a converter name to use with each
881         canonical encoding name.
882         (WebCore::TextCodecICU::TextCodecICU): Ditto.
883         (WebCore::TextCodecICU::releaseICUConverter): Reset the converter to remove any
884         leftover data.
885         (WebCore::TextCodecICU::createICUConverter): 
886             - Compare converter name to converter name, not to another alias name.
887             - Use proper string comparison instead of pointer comparison.
888             - When creating a converter, assert that the name is not ambigous - canonical
889             converter names should never be, otherwise there would be no way to create
890             the converter without ambiguity.
891
892 2013-05-11  Antoine Quint  <graouts@apple.com>
893
894         [Mac] The captions menu should not use a canned max-width and max-height
895         https://bugs.webkit.org/show_bug.cgi?id=115968
896
897         Reviewed by Eric Carlson.
898
899         Use more real estate to display the captions menu should the caption names
900         be long.
901
902         * css/mediaControlsQuickTime.css:
903         (video::-webkit-media-controls-closed-captions-container):
904         (video::-webkit-media-controls-closed-captions-track-list):
905         Make the captions menu scale to a max-width and max-height to allow 4px
906         above and below the menu, except on the right where it always aligns with
907         the captions icon in the media controller.
908         * html/shadow/MediaControlsApple.cpp:
909         (WebCore::MediaControlsApple::createControls):
910         Move the captions menu element to be a child of the controls instead of
911         the panel such that it may scale relative to the controls when using %
912         CSS values.
913
914 2013-05-11  Jochen Eisinger  <jochen@chromium.org>
915
916         Disallow a window to focus itself via javascript URLs or using target _self
917         https://bugs.webkit.org/show_bug.cgi?id=115906
918
919         Reviewed by Geoffrey Garen.
920
921         Test: fast/dom/Window/window-focus-self.html
922
923         * loader/FrameLoader.cpp:
924         (WebCore::createWindow):
925         * page/DOMWindow.cpp:
926         (WebCore::DOMWindow::focus):
927
928 2013-05-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
929
930         Fix several style warnings in generated bindings
931         https://bugs.webkit.org/show_bug.cgi?id=115961
932
933         Reviewed by Kentaro Hara.
934
935         Fix several style errors in the bindings generated under
936         Source/WebCore/bindings/scripts/test/
937
938         No new tests, no behavior change.
939
940         * bindings/scripts/CodeGeneratorCPP.pm:
941         (GenerateImplementation):
942         (WriteData):
943         * bindings/scripts/CodeGeneratorJS.pm:
944         (GenerateHeader):
945         (GenerateImplementation):
946         (WriteData):
947         * bindings/scripts/CodeGeneratorObjC.pm:
948         (GenerateHeader):
949         * bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
950         * bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
951         * bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
952         * bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
953         * bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
954         * bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
955         * bindings/scripts/test/CPP/WebDOMTestException.cpp:
956         * bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
957         * bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
958         * bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
959         * bindings/scripts/test/CPP/WebDOMTestNode.cpp:
960         * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
961         * bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp:
962         * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
963         * bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
964         * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
965         (WebCore::toJS):
966         * bindings/scripts/test/JS/JSTestActiveDOMObject.h:
967         (WebCore::JSTestActiveDOMObject::releaseImplIfNotNull):
968         * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
969         (WebCore::toJS):
970         * bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
971         (WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):
972         * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
973         (WebCore::toJS):
974         * bindings/scripts/test/JS/JSTestEventConstructor.h:
975         (WebCore::JSTestEventConstructor::releaseImplIfNotNull):
976         * bindings/scripts/test/JS/JSTestEventTarget.cpp:
977         (WebCore::toJS):
978         * bindings/scripts/test/JS/JSTestEventTarget.h:
979         (WebCore::JSTestEventTarget::releaseImplIfNotNull):
980         * bindings/scripts/test/JS/JSTestException.cpp:
981         (WebCore::toJS):
982         * bindings/scripts/test/JS/JSTestException.h:
983         (WebCore::JSTestException::releaseImplIfNotNull):
984         * bindings/scripts/test/JS/JSTestInterface.cpp:
985         (WebCore::toJS):
986         * bindings/scripts/test/JS/JSTestInterface.h:
987         (WebCore::JSTestInterface::releaseImplIfNotNull):
988         * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
989         (WebCore::toJS):
990         * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
991         (WebCore::JSTestMediaQueryListListener::releaseImplIfNotNull):
992         * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
993         (WebCore::toJS):
994         * bindings/scripts/test/JS/JSTestNamedConstructor.h:
995         (WebCore::JSTestNamedConstructor::releaseImplIfNotNull):
996         * bindings/scripts/test/JS/JSTestObj.cpp:
997         (WebCore::toJS):
998         * bindings/scripts/test/JS/JSTestObj.h:
999         (WebCore::JSTestObj::releaseImplIfNotNull):
1000         * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
1001         (WebCore::toJS):
1002         * bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
1003         (WebCore::JSTestOverloadedConstructors::releaseImplIfNotNull):
1004         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
1005         (WebCore::toJS):
1006         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
1007         (WebCore::JSTestSerializedScriptValueInterface::releaseImplIfNotNull):
1008         * bindings/scripts/test/JS/JSTestTypedefs.cpp:
1009         (WebCore::toJS):
1010         * bindings/scripts/test/JS/JSTestTypedefs.h:
1011         (WebCore::JSTestTypedefs::releaseImplIfNotNull):
1012         * bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h:
1013         (WebCore):
1014         * bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h:
1015         (WebCore):
1016         * bindings/scripts/test/ObjC/DOMTestCallbackInternal.h:
1017         (WebCore):
1018         * bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h:
1019         (WebCore):
1020         * bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h:
1021         (WebCore):
1022         * bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h:
1023         (WebCore):
1024         * bindings/scripts/test/ObjC/DOMTestExceptionInternal.h:
1025         (WebCore):
1026         * bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h:
1027         (WebCore):
1028         * bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h:
1029         (WebCore):
1030         * bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h:
1031         (WebCore):
1032         * bindings/scripts/test/ObjC/DOMTestNodeInternal.h:
1033         (WebCore):
1034         * bindings/scripts/test/ObjC/DOMTestObjInternal.h:
1035         (WebCore):
1036         * bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h:
1037         (WebCore):
1038         * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h:
1039         (WebCore):
1040         * bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h:
1041         (WebCore):
1042
1043 2013-05-11  Anders Carlsson  <andersca@apple.com>
1044
1045         Make it a build error to put invalid C++ symbol names in WebCore.exp.in
1046         https://bugs.webkit.org/show_bug.cgi?id=115958
1047
1048         Reviewed by Andreas Kling.
1049
1050         While invalid C++ symbols will eventually show up as a link error since the symbol won't be found,
1051         this makes it easier to catch invalid symbols inside of #ifdefs.
1052
1053         * make-export-file-generator:
1054         Try to demangle C++ symbols before printing them.
1055
1056 2013-05-11  David Kilzer  <ddkilzer@apple.com>
1057
1058         BUILD FIX (r149718): Move exported symbol into ENABLE(FULLSCREEN_API) section
1059
1060         Fixes the following build failure when ENABLE(FULLSCREEN_API) is
1061         off:
1062
1063             Undefined symbols for architecture i386:
1064               "__ZNK7WebCore7Element25containsFullScreenElementEv", referenced from:
1065                  -exported_symbol[s_list] command line option
1066
1067         * WebCore.exp.in: Move the symbol.
1068
1069 2013-05-11  Robert Hogan  <robert@webkit.org>
1070
1071         Unreviewed, remove some lint accidentally left in r149929.
1072
1073         * rendering/InlineFlowBox.cpp:
1074         (WebCore::verticalAlignApplies):
1075
1076 2013-03-17  Robert Hogan  <robert@webkit.org>
1077
1078         Text flow broken in elements with vertical align top/bottom and inline elements taller than line-height
1079         https://bugs.webkit.org/show_bug.cgi?id=111974
1080
1081         Reviewed by Ryosuke Niwa.
1082         
1083         Per http://www.w3.org/TR/CSS2/visudet.html#propdef-vertical-align 'vertical-align' only applies to inline and table-cell
1084         elements.
1085
1086         Test: fast/css/vertical-align-block-elements.html
1087
1088         * rendering/InlineFlowBox.cpp:
1089         (WebCore::isTextInBlockElement):
1090         (WebCore):
1091         (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
1092         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
1093         (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
1094
1095 2013-05-11  Benjamin Poulain  <bpoulain@apple.com>
1096
1097         Make CanvasStyle a plain object instead of an RefCounted object
1098         https://bugs.webkit.org/show_bug.cgi?id=115775
1099
1100         Reviewed by Andreas Kling.
1101
1102         CanvasStyle is just 2 words wide. We do not gain anything from allocating
1103         it on the heap. Change the object to be just a type and some data.
1104
1105         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
1106         (WebCore::toJS):
1107         (WebCore::toHTMLCanvasStyle):
1108         * html/HTMLCanvasElement.cpp:
1109         * html/canvas/CanvasRenderingContext2D.cpp:
1110         (WebCore::CanvasRenderingContext2D::State::State):
1111         (WebCore::CanvasRenderingContext2D::setStrokeStyle):
1112         (WebCore::CanvasRenderingContext2D::setFillStyle):
1113         (WebCore::CanvasRenderingContext2D::setStrokeColor):
1114         (WebCore::CanvasRenderingContext2D::setFillColor):
1115         (WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
1116         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1117         * html/canvas/CanvasRenderingContext2D.h:
1118         (WebCore::CanvasRenderingContext2D::strokeStyle):
1119         (CanvasRenderingContext2D):
1120         (WebCore::CanvasRenderingContext2D::fillStyle):
1121         (State):
1122         * html/canvas/CanvasStyle.cpp:
1123         (WebCore::CanvasStyle::CanvasStyle):
1124         (WebCore::CanvasStyle::createFromString):
1125         (WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
1126         (WebCore::CanvasStyle::isEquivalentColor):
1127         (WebCore):
1128         (WebCore::CanvasStyle::operator=):
1129         (WebCore::CanvasStyle::applyStrokeColor):
1130         (WebCore::CanvasStyle::applyFillColor):
1131         * html/canvas/CanvasStyle.h:
1132         (CanvasStyle):
1133         (WebCore::CanvasStyle::isValid):
1134         (WebCore::CanvasStyle::CanvasStyle):
1135         (WebCore):
1136         (WebCore::CanvasStyle::operator=):
1137
1138 2013-05-11  Benjamin Poulain  <benjamin@webkit.org>
1139
1140         Gradient::platformGradient: Vector reserveCapacity -> reserveInitialCapacity
1141         https://bugs.webkit.org/show_bug.cgi?id=115779
1142
1143         Reviewed by Andreas Kling.
1144
1145         * platform/graphics/cg/GradientCG.cpp:
1146         (WebCore::Gradient::platformGradient): Clang is surprisingly smart at removing
1147         all the branches of this function. Remove two more with reserveInitialCapacity.
1148
1149 2013-05-10  Alexey Proskuryakov  <ap@apple.com>
1150
1151         <rdar://problem/13666412> Clean up some edge cases of URL parsing.
1152         https://bugs.webkit.org/show_bug.cgi?id=104919
1153
1154         Reviewed by Darin Adler.
1155
1156         Test: fast/url/segments-userinfo-vs-host.html
1157
1158         * page/SecurityOrigin.cpp:
1159         (WebCore::schemeRequiresHost):
1160         (WebCore::shouldTreatAsUniqueOrigin):
1161         Updated function name and comments (host is not the same as authority). We still
1162         need this check - KURL can still produce http URLs with an empty host (even as this
1163         patch reduces the number of such cases). So can Gecko and current draft of URL
1164         Standard.
1165         It would be good to have a guarantee that such useless URLs can not come out of
1166         URL parser, as relying on downstream code re-parsing the URL correctly would be fragile.
1167
1168         * platform/KURL.cpp:
1169         (WebCore::hostPortIsEmptyButCredentialsArePresent): Updated an argument name for
1170         correctness.
1171         (WebCore::KURL::parse):
1172         1. Reverted behavior changes from <http://trac.webkit.org/changeset/82181> - I could
1173         find no reason to allow "@" in hostnames, and having a URL like this re-parsed by
1174         a different parser would likely produce different results. It's better to just treat
1175         these edge case URLs as invalid.
1176         2. When hostname component is a lone colon, preserve it in parsed URL string,
1177         as otherwise path would get pushed in its place when re-parsing.
1178         3. When authority component is a lone colon, don't forget to "//" after scheme, too.
1179         4. Added some assertions about contents of authority component, to catch potential
1180         mis-parsing earlier.
1181
1182 2013-05-10  Alexey Proskuryakov  <ap@apple.com>
1183
1184         Make TextCodecICU not depend on TextEncoding
1185         https://bugs.webkit.org/show_bug.cgi?id=115848
1186
1187         Reviewed by Darin Adler.
1188
1189         * platform/text/TextCodecICU.cpp:
1190         (WebCore::TextCodecICU::create):
1191         (WebCore::TextCodecICU::TextCodecICU):
1192         (WebCore::TextCodecICU::createICUConverter):
1193         (WebCore::TextCodecICU::decode):
1194         (WebCore::TextCodecICU::encode):
1195         * platform/text/TextCodecICU.h:
1196         Use a plain encoding string in platform encoder wrapper, not a higher level concept.
1197
1198 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1199
1200         Remove Mac OS X Leopard (10.5) support
1201         https://bugs.webkit.org/show_bug.cgi?id=107964
1202
1203         Reviewed by Ryosuke Niwa.
1204
1205         Removed the code for 10.5 and removed if-def for 10.6.
1206
1207         No new tests, covered by existing tests.
1208
1209         * platform/LocalizedStrings.cpp:
1210         (WebCore::contextMenuItemTagLookUpInDictionary):
1211         * platform/graphics/cg/GraphicsContextCG.cpp:
1212         * platform/mac/EmptyProtocolDefinitions.h:
1213         * platform/mac/NSScrollerImpDetails.h:
1214         * platform/mac/WebCoreSystemInterface.h:
1215         * platform/text/mac/HyphenationMac.mm:
1216
1217 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1218
1219         Remove USE(OS_RANDOMNESS)
1220         https://bugs.webkit.org/show_bug.cgi?id=108095
1221
1222         Reviewed by Darin Adler.
1223
1224         Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
1225         ports.
1226
1227         No new tests as this is covered by existing tests.
1228
1229         * page/Crypto.cpp:
1230         (WebCore::Crypto::getRandomValues):
1231         * platform/UUID.cpp:
1232         (WebCore::createCanonicalUUIDString):
1233
1234 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1235
1236         Remove [NoInterfaceObject] from several WebAudio IDL interfaces
1237         https://bugs.webkit.org/show_bug.cgi?id=115894
1238
1239         Reviewed by Darin Adler.
1240
1241         Several WebAudio IDL interfaces had [NoInterfaceObject] extended attribute set,
1242         meaning that there was no corresponding attribute on the global window object.
1243         This behavior is not according to the specification:
1244         https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html
1245
1246         This patch removes the [NoInterfaceObject] extended attribute where needed to
1247         match the specification.
1248
1249         No new tests, already covered by existing tests.
1250
1251         * Modules/webaudio/AnalyserNode.idl:
1252         * Modules/webaudio/AudioBuffer.idl:
1253         * Modules/webaudio/AudioBufferSourceNode.idl:
1254         * Modules/webaudio/AudioDestinationNode.idl:
1255         * Modules/webaudio/AudioListener.idl:
1256         * Modules/webaudio/AudioNode.idl:
1257         * Modules/webaudio/AudioParam.idl:
1258         * Modules/webaudio/BiquadFilterNode.idl:
1259         * Modules/webaudio/ChannelMergerNode.idl:
1260         * Modules/webaudio/ChannelSplitterNode.idl:
1261         * Modules/webaudio/ConvolverNode.idl:
1262         * Modules/webaudio/DelayNode.idl:
1263         * Modules/webaudio/DynamicsCompressorNode.idl:
1264         * Modules/webaudio/GainNode.idl:
1265         * Modules/webaudio/MediaElementAudioSourceNode.idl:
1266         * Modules/webaudio/MediaStreamAudioDestinationNode.idl:
1267         * Modules/webaudio/MediaStreamAudioSourceNode.idl:
1268         * Modules/webaudio/OscillatorNode.idl:
1269         * Modules/webaudio/ScriptProcessorNode.idl:
1270         * Modules/webaudio/WaveShaperNode.idl:
1271         * Modules/webaudio/WaveTable.idl:
1272
1273 2013-05-10  Simon Fraser  <simon.fraser@apple.com>
1274
1275         REGRESSION (r145680): No box shadow rendered on element with positioned child that obscures it
1276         https://bugs.webkit.org/show_bug.cgi?id=115840
1277
1278         Reviewed by Antti Koivisto.
1279         
1280         In r107836, we moved some box-shadow painting into the paintFillLayer code for performance.
1281         However, in r145680 we started to skip background painting when we know the background is
1282         obscured. This broke shadow painting in some cases.
1283         
1284         Fix by always painting the background fill layers if we know that they will also
1285         paint the shadow.
1286
1287         Test: fast/box-shadow/box-shadow-obscured-backgrounds.html
1288
1289         * rendering/RenderBox.cpp:
1290         (WebCore::RenderBox::paintBackground):
1291
1292 2013-05-10  Simon Fraser  <simon.fraser@apple.com>
1293
1294         REGRESSION (r143626): Element shows as garbage in image gallery
1295         https://bugs.webkit.org/show_bug.cgi?id=115946
1296
1297         Reviewed by Antti Koivisto.
1298         
1299         RenderLayer::backgroundIsKnownToBeOpaqueInRect() used hasVisibleContent()
1300         to check whether the layer's content was hidden via the visibility property.
1301         However, this assumed that a passing hasVisibleContent() check meant that the
1302         entire area was covered by the renderers and layers checked layer.
1303         
1304         This is not always true. It's possible to have a visibility:hidden layer
1305         with a non-covering visbility:visible child, or even a single RenderText
1306         child that happens to have visibility:visible style. In these situations,
1307         hasVisibleContent() returns true but the entire area is not painted.
1308         
1309         So we have to fall back to on a more conservative check using the
1310         visibility style, which will give is a reliable answer for the current layer.
1311
1312         Tests: compositing/contents-opaque/hidden-with-visible-child.html
1313                compositing/contents-opaque/hidden-with-visible-text.html
1314
1315         * rendering/RenderLayer.cpp:
1316         (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
1317
1318 2013-05-10  Simon Fraser  <simon.fraser@apple.com>
1319
1320         Garbage down left side of nytimes.com page (if subscriber)
1321         https://bugs.webkit.org/show_bug.cgi?id=115839
1322
1323         Reviewed by Antti Koivisto.
1324         
1325         RenderLayer::backgroundIsKnownToBeOpaqueInRect() would incorrectly return true
1326         for layers where the given rect wasn't contained in the background rect, but
1327         where some child layer obscured the rect, even though clipping hid part
1328         of that child layer.
1329         
1330         So bail from RenderLayer::backgroundIsKnownToBeOpaqueInRect() if we have
1331         any overflow clipping. This could be enhanced in future to test whether child
1332         layers obscure the clipping rect, but that would be more expensive.
1333
1334         Test: compositing/contents-opaque/overflow-hidden-child-layers.html
1335
1336         * rendering/RenderLayer.cpp:
1337         (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
1338
1339 2013-05-10  Eric Carlson  <eric.carlson@apple.com>
1340
1341         In-band captions not visible immediately after track mode change
1342         https://bugs.webkit.org/show_bug.cgi?id=115922
1343
1344         Reviewed by Dean Jackson.
1345
1346         Test: media/track/track-in-band-mode.html
1347
1348         * html/HTMLMediaElement.cpp:
1349         (WebCore::HTMLMediaElement::textTrackModeChanged): Add cues for all loaded tracks, regardless
1350             of track type.
1351
1352 2013-05-10  Timothy Hatcher  <timothy@apple.com>
1353
1354         Web Inspector: determine the resource type in InspectorResourceAgent::willSendRequest.
1355
1356         This allows the Network timeline and Resources sidebar to filter Resources earlier,
1357         before the server sends a response. Useful for long polling (comet) XHRs.
1358
1359         https://webkit.org/b/74935
1360         rdar://problem/13726105
1361
1362         Reviewed by Joseph Pecoraro.
1363
1364         * inspector/Inspector.json:
1365         (Network.requestWillBeSent): Added.
1366         * inspector/InspectorResourceAgent.cpp:
1367         (WebCore::InspectorResourceAgent::willSendRequest): Send the type if it isn't Other along in requestWillBeSent.
1368         (WebCore::InspectorResourceAgent::didReceiveResponse): Don't determine the type here anymore. Clear the CachedResource
1369         if isNotModified like the old code path did by not setting cachedResource if !isNotModified.
1370
1371 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1372
1373         [CMake] Consolidate list of files to build for WebCore plugin support
1374         https://bugs.webkit.org/show_bug.cgi?id=104429
1375
1376         Reviewed by Rob Buis.
1377
1378         Move the common files to support plugins and the logic for disabling
1379         plugins) to CMakeLists.txt from PlatformXXX.cmake.
1380
1381         No new tests as there is no new functionality.
1382
1383         * CMakeLists.txt:
1384         * PlatformBlackBerry.cmake:
1385         * PlatformEfl.cmake:
1386         * PlatformWinCE.cmake:
1387
1388 2013-05-10  Robert Hogan  <robert@webkit.org>
1389
1390         REGRESSION(r148121): Empty Span does not get a linebox when it's in an anonymous block
1391         https://bugs.webkit.org/show_bug.cgi?id=115818
1392
1393         Reviewed by David Hyatt.
1394
1395         r148121 only worried about split inlines inside anonymous blocks - it ought to have 
1396         catered for empty inlines, with no continuations, inside a single solitary anonymous block too.
1397
1398         Test: fast/inline/anonymous-block-with-empty-inline.html
1399
1400         * rendering/RenderBlockLineLayout.cpp:
1401         (WebCore::hasInlineDirectionBordersPaddingOrMargin):
1402
1403 2013-05-10  Zan Dobersek  <zdobersek@igalia.com>
1404
1405         [GTK] Remove unnecessary includes in WidgetGtk.cpp
1406         https://bugs.webkit.org/show_bug.cgi?id=115912
1407
1408         Reviewed by Andreas Kling.
1409
1410         No new tests - no new functionality.
1411
1412         * platform/gtk/WidgetGtk.cpp: Remove the unnecessary includes of the Chrome.h, Frame.h, FrameView.h,
1413         Page.h and RenderObject.h headers as the included declarations are not used anywhere. ScrollView.h is
1414         included instead as it is required and was previously included by one of the removed header inclusions.
1415
1416 2013-05-10  Zan Dobersek  <zdobersek@igalia.com>
1417
1418         [Cairo] Remove the unnecessary ImageData.h include in ImageBufferCairo.cpp
1419         https://bugs.webkit.org/show_bug.cgi?id=115911
1420
1421         Reviewed by Carlos Garcia Campos.
1422
1423         No new tests - no new functionality.
1424
1425         * platform/graphics/cairo/ImageBufferCairo.cpp: Remove the ImageData.h include
1426         as the included declarations are not used anywhere.
1427
1428 2013-05-10  Zan Dobersek  <zdobersek@igalia.com>
1429
1430         [Cairo] Remove the unnecessary CSSParser.h include in GradientCairo.cpp
1431         https://bugs.webkit.org/show_bug.cgi?id=115910
1432
1433         Reviewed by Laszlo Gombos.
1434
1435         No new tests - no new functionality.
1436
1437         * platform/graphics/cairo/GradientCairo.cpp: Remove the CSSParser.h include
1438         as the included declarations are not used anywhere.
1439
1440 2013-05-10  Dean Jackson  <dino@apple.com>
1441
1442         Include tab character as a word end for kerning
1443         https://bugs.webkit.org/show_bug.cgi?id=115915
1444         <rdar://problem/13861491>
1445
1446         Reviewed by Enrica Casucci.
1447
1448         This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=112507
1449         which only looked for a space character as a word end. It should
1450         look for tab characters too.
1451
1452         Test: fast/text/word-space-with-kerning-4.html
1453
1454         * rendering/RenderBlockLineLayout.cpp:
1455         (WebCore::setLogicalWidthForTextRun): Look for '\t'.
1456
1457 2013-05-10  Anders Carlsson  <andersca@apple.com>
1458
1459         Remove EventTracer
1460         https://bugs.webkit.org/show_bug.cgi?id=115916
1461
1462         Reviewed by Sam Weinig.
1463
1464         EventTracer is dead code, remove it.
1465
1466         * CMakeLists.txt:
1467         * GNUmakefile.list.am:
1468         * Target.pri:
1469         * WebCore.vcproj/WebCore.vcproj:
1470         * WebCore.vcxproj/WebCore.vcxproj:
1471         * WebCore.vcxproj/WebCore.vcxproj.filters:
1472         * WebCore.xcodeproj/project.pbxproj:
1473         * platform/EventTracer.cpp: Removed.
1474         * platform/EventTracer.h: Removed.
1475
1476 2013-05-10  Zan Dobersek  <zdobersek@igalia.com>
1477
1478         [GTK] Generated files are regenerated always
1479         https://bugs.webkit.org/show_bug.cgi?id=115908
1480
1481         Reviewed by Carlos Garcia Campos.
1482
1483         No new tests - no change in functionality.
1484
1485         * GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the JavaScriptCore bindings.
1486         The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through
1487         the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target
1488         which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required.
1489
1490 2013-05-10  Andreas Kling  <akling@apple.com>
1491
1492         Caching of generated images in CSS should be smarter.
1493         <http://webkit.org/b/115902>
1494         <rdar://problem/13542727>
1495
1496         Reviewed by Antti Koivisto.
1497
1498         Add an IntSize => GeneratorGeneratedImage cache at the CSSImageGeneratorValue level.
1499
1500         CSSGradientValue is currently the only CSSImageGeneratorValue subclass that makes use of the cache.
1501         Generated images are kept for 3 seconds after last use.
1502
1503         The main problem with the previous approach was that background renderers (e.g <body>, <tr>, etc)
1504         would be passed to multiple CSSImageGeneratorValue::getImage() calls with different sizes requested
1505         for each of the descendent renderers that inherit their background from the same parent.
1506         The cache wasn't smart enough for this, it just thought the background renderer was changing size
1507         a lot, and would regenerate the image over and over.
1508
1509         We already had caching of intermediate image buffers for GeneratorGeneratedImage::drawPattern().
1510         This removes the eviction timer from that cache so that the intermediate images can live a bit longer.
1511
1512         (WebCore::CSSImageGeneratorValue::cachedImageForSize):
1513         (WebCore::CSSImageGeneratorValue::saveCachedImageForSize):
1514
1515             Renamed from getImage() and putImage().
1516
1517         (WebCore::CSSImageGeneratorValue::evictCachedGeneratedImage):
1518         (WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
1519         (WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):
1520
1521             Let the CachedGeneratedImage throw itself out from cache when the timer fires.
1522
1523         * css/CSSImageGeneratorValue.h:
1524         (CachedGeneratedImage):
1525
1526             Exactly what it sounds like. These go into CSSImageGeneratorValue::m_images with the size
1527             as the hash key.
1528
1529         * platform/graphics/GeneratorGeneratedImage.cpp:
1530         (WebCore::GeneratorGeneratedImage::drawPattern):
1531         * platform/graphics/GeneratorGeneratedImage.h:
1532         (WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
1533         (WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
1534
1535             Keep the intermediate image for drawPattern() until destruction instead of dropping it on
1536             a timer. These objects are now evicted by the CSSImageGeneratorValue's image cache
1537             after 3 seconds of disuse rather than kept for the lifetime of the renderer.
1538
1539         * css/CSSCanvasValue.cpp:
1540         (WebCore::CSSCanvasValue::canvasChanged):
1541         (WebCore::CSSCanvasValue::canvasResized):
1542         * css/CSSCrossfadeValue.cpp:
1543         (WebCore::CSSCrossfadeValue::crossfadeChanged):
1544         * rendering/style/StyleGeneratedImage.cpp:
1545         (WebCore::StyleGeneratedImage::addClient):
1546         * css/CSSImageGeneratorValue.cpp:
1547         (WebCore::CSSImageGeneratorValue::addClient):
1548         (WebCore::CSSImageGeneratorValue::removeClient):
1549
1550             CSSImageGeneratorValue::m_clients is now a HashCountedSet<RenderObject*>, tweak accordingly.
1551
1552 2013-05-10  Anders Carlsson  <andersca@apple.com>
1553
1554         Remove MemoryUsageSupport class
1555         https://bugs.webkit.org/show_bug.cgi?id=115913
1556
1557         Reviewed by Andreas Kling.
1558
1559         MemoryUsageSupport was just used by a single call site in InspectorTimelineAgent,
1560         and the function called always returns zero on all platforms! Remove it.
1561
1562         * CMakeLists.txt:
1563         * GNUmakefile.list.am:
1564         * Target.pri:
1565         * WebCore.vcproj/WebCore.vcproj:
1566         * WebCore.vcxproj/WebCore.vcxproj:
1567         * WebCore.vcxproj/WebCore.vcxproj.filters:
1568         * WebCore.xcodeproj/project.pbxproj:
1569         * inspector/InspectorMemoryAgent.cpp:
1570         * inspector/InspectorTimelineAgent.cpp:
1571         (WebCore):
1572         (WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
1573         * platform/MemoryUsageSupport.cpp: Removed.
1574         * platform/MemoryUsageSupport.h: Removed.
1575         * platform/qt/MemoryUsageSupportQt.cpp: Removed.
1576
1577 2013-05-10  Ryosuke Niwa  <rniwa@webkit.org>
1578
1579         REGRESSION (r149652): Videos do not play on cnn.com, just black box
1580         https://bugs.webkit.org/show_bug.cgi?id=115887
1581
1582         Reviewed by Antti Koivisto.
1583
1584         The bug was caused by window and document named item maps counting the same element twice
1585         when it has the same id and name attribute values. Fixed the bug by avoiding to add or remove
1586         an element per id and name attribute updates when it had already been added or removed by
1587         name and id attribute updates respectively.
1588
1589         We do this by checking whether the other attribute affects the element's precense in window
1590         and document named item maps and avoiding to add or remove the attribute when they do and
1591         the other attribute is present in updateId and updateName.
1592
1593         Consider a scenario when an object element has id "foo", and name attribute is about to be also
1594         set to "foo". If the id attribute doesn't affect element's presense in window or document
1595         named item maps, we're done. If it does, then the maps already have this element so we don't
1596         want to add it again. Conversely, if the element already has id and name attributes set to
1597         "foo", and we're moving the id attribute, then we want to remove the element from the maps only
1598         if the id doesn't affect the presence of the element in the maps.
1599
1600         Unfortuntely, this logic doesn't work when we're inserting or removing an element on its entirely
1601         because updateId and updateName are called when both id and name attributes are present so skip
1602         this step (AlwaysUpdateHTMLDocumentNamedItemMaps) for the id attribute to break the symmetry.
1603
1604         Test: fast/dom/HTMLDocument/image-with-same-id-and-name.html
1605               fast/dom/HTMLDocument/object-with-same-id-and-name.html
1606
1607         * dom/Element.cpp:
1608         (WebCore::Element::insertedInto): Call updateId and updateName with
1609         AlwaysUpdateHTMLDocumentNamedItemMaps.
1610         (WebCore::Element::removedFrom): Ditto.
1611         (WebCore::Element::updateName): Don't add or remove this element if the id attribute has already
1612         done so except when we're inserting, removing, or cloning an element.
1613         (WebCore::Element::updateId): Ditto for the name attribute.
1614         (WebCore::Element::cloneAttributesFromElement): Added a comment and assert that we never call this
1615         function when this element is in the document. We can't update window and documemt named item
1616         maps here because image element's id attribute value, for example, is present in the document's
1617         named item map if it has a name attribute. Since this function calls updateId and updateName
1618         before updating attributes, this check is going to fail in DocumentNameCollection's
1619         nodeMatchesIfIdAttributeMatch and bad things will happen.
1620
1621         * dom/Element.h:
1622
1623         * editing/ReplaceNodeWithSpanCommand.cpp:
1624         (WebCore::swapInNodePreservingAttributesAndChildren): Clone children and attributes before
1625         inserting the swapped span to avoid hitting the assertion in cloneAttributesFromElement we added.
1626
1627         * html/HTMLImageElement.cpp:
1628         (WebCore::HTMLImageElement::parseAttribute):
1629
1630         * html/HTMLObjectElement.cpp:
1631         (WebCore::HTMLObjectElement::updateDocNamedItem):
1632
1633 2013-05-09  Dean Jackson  <dino@apple.com>
1634
1635         Don't trust character widths for internal OS X fonts in form controls
1636         https://bugs.webkit.org/show_bug.cgi?id=115883
1637         <rdar://problem/13817757>
1638
1639         Reviewed by Darin Adler.
1640
1641         We ignore the character width for a bunch of fonts when predicting
1642         the width of a form control. Some of the internal fonts in OS X are
1643         not in the ignored list. Rather than add them, simply test for
1644         fonts whose family begins with a period character ".".
1645
1646         * rendering/RenderTextControl.cpp:
1647         (WebCore::RenderTextControl::hasValidAvgCharWidth): Return false for
1648             any family that starts with "."
1649
1650 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1651
1652         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1653         https://bugs.webkit.org/show_bug.cgi?id=115904
1654
1655         Reviewed by Martin Robinson.
1656
1657         * bindings/gobject/WebKitDOMEventTarget.cpp:
1658         * platform/gtk/GtkVersioning.c:
1659         * platform/gtk/GtkVersioning.h:
1660
1661 2013-05-10  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1662
1663         Unreviewed. Fix the ENABLE(SHARED_WORKERS) build after r149864.
1664
1665         * workers/SharedWorkerThread.cpp: include "SecurityOrigin.h"
1666
1667 2013-05-10  Claudio Saavedra  <csaavedra@igalia.com>
1668
1669         Fix build after r149864.
1670
1671         Unreviewed build fix.
1672
1673         * loader/ThreadableLoader.h: include <wtf/text/AtomicString.h>
1674         when building with RESOURCE_TIMING enabled.
1675
1676 2013-05-10  Anders Carlsson  <andersca@apple.com>
1677
1678         Fix build.
1679
1680         * bindings/js/ScriptController.cpp:
1681
1682 2013-05-10  Anders Carlsson  <andersca@apple.com>
1683
1684         Remove ScriptInstance.h
1685         https://bugs.webkit.org/show_bug.cgi?id=115900
1686
1687         Reviewed by Andreas Kling.
1688
1689         Remove yet another abstraction now that we don't support V8.
1690
1691         * GNUmakefile.list.am:
1692         * WebCore.vcproj/WebCore.vcproj:
1693         * WebCore.vcxproj/WebCore.vcxproj:
1694         * WebCore.vcxproj/WebCore.vcxproj.filters:
1695         * WebCore.xcodeproj/project.pbxproj:
1696         * bindings/js/ScriptController.h:
1697         (Bindings):
1698         (ScriptController):
1699         * bindings/js/ScriptControllerMac.mm:
1700         (WebCore::ScriptController::createScriptInstanceForWidget):
1701         * bindings/js/ScriptInstance.h: Removed.
1702         * html/HTMLPlugInElement.cpp:
1703         (WebCore::HTMLPlugInElement::getInstance):
1704         * html/HTMLPlugInElement.h:
1705         (Bindings):
1706         (HTMLPlugInElement):
1707         * platform/graphics/wince/MediaPlayerProxy.h:
1708         (WebMediaPlayerProxy):
1709         * rendering/RenderEmbeddedObject.cpp:
1710         * rendering/RenderSnapshottedPlugIn.cpp:
1711
1712 2013-05-10  Anders Carlsson  <andersca@apple.com>
1713
1714         Unreviewed, rolling out r149866.
1715         http://trac.webkit.org/changeset/149866
1716         https://bugs.webkit.org/show_bug.cgi?id=115898
1717
1718         Broke tests
1719
1720         * dom/Document.cpp:
1721         (WebCore::Document::setDomain):
1722         (WebCore::Document::initSecurityContext):
1723         * page/SecurityOrigin.cpp:
1724         (WebCore::SecurityOrigin::SecurityOrigin):
1725         (WebCore::SecurityOrigin::isolatedCopy):
1726         (WebCore::SecurityOrigin::setDomainFromDOM):
1727         (WebCore::SecurityOrigin::grantUniversalAccess):
1728         * page/SecurityOrigin.h:
1729         (SecurityOrigin):
1730
1731 2013-05-10  Andrei Bucur  <abucur@adobe.com>
1732
1733         Remove overflow dead code
1734         https://bugs.webkit.org/show_bug.cgi?id=115893
1735
1736         Reviewed by Antti Koivisto.
1737
1738         The patch removes unused public overflow accesor functions from RenderOverflow and InlineFlowBox.
1739
1740         Tests: no tests, code cleanup.
1741
1742         * rendering/InlineFlowBox.h: Removed logicalLeftLayoutOverflow and logicalRightLayoutOverflow.
1743         * rendering/RenderOverflow.h: Removed setMinYLayoutOverflow, setMaxYLayoutOverflow,
1744             setMinXLayoutOverflow, setMaxXLayoutOverflow, setMinYVisualOverflow, setMaxYVisualOverflow,
1745             setMinXVisualOverflow and setMaxXVisualOverflow.
1746
1747 2013-05-10  Anders Carlsson  <andersca@apple.com>
1748
1749         Begin making SecurityOrigin immutable
1750         https://bugs.webkit.org/show_bug.cgi?id=115898
1751
1752         Reviewed by Andreas Kling.
1753
1754         Replace SecurityOrigin::setDomainFromDOM and SecurityOrigin::grantUniversalAccess with
1755         member functions that return new SecurityOrigin objects.
1756
1757         * dom/Document.cpp:
1758         (WebCore::Document::setDomain):
1759         Update the security origin to one returned by copyWithDomainSetFromDOM.
1760     
1761         (WebCore::Document::initSecurityContext):
1762         Set the security origin to one returned by copyWithUniversalAccessGranted().
1763
1764         * page/SecurityOrigin.cpp:
1765         (WebCore::SecurityOrigin::SecurityOrigin):
1766         Add a new constructor that takes all the member variables as parameters. This is a little unwieldy at the moment,
1767         but all the boolean parameters could be replaced by a bitmask of flags.
1768
1769         (WebCore::SecurityOrigin::isolatedCopy):
1770         Call the new constructor.
1771
1772         (WebCore::SecurityOrigin::copyWithDomainSetFromDOM):
1773         Return a new security origin with m_domainWasSetInDOM set to true and the domain updated.
1774
1775         (WebCore::SecurityOrigin::copyWithUniversalAccessGranted):
1776         Return a new security origin with m_universalAccess set to true.
1777
1778 2013-05-10  Anders Carlsson  <andersca@apple.com>
1779
1780         Remove ScriptController::updateSecurityOrigin
1781         https://bugs.webkit.org/show_bug.cgi?id=115895
1782
1783         Reviewed by Antti Koivisto.
1784
1785         ScriptController::updateSecurityOrigin is just dead code now that the V8 bindings are gone.
1786
1787         * bindings/js/ScriptController.cpp:
1788         * bindings/js/ScriptController.h:
1789         * dom/Document.cpp:
1790         (WebCore::Document::setIsViewSource):
1791         (WebCore::Document::setDomain):
1792         * dom/Document.h:
1793         (Document):
1794         * dom/SecurityContext.cpp:
1795         (WebCore::SecurityContext::enforceSandboxFlags):
1796         * dom/SecurityContext.h:
1797         (SecurityContext):
1798
1799 2013-05-10  Anders Carlsson  <andersca@apple.com>
1800
1801         Stop including SecurityOrigin.h where unnecessary
1802         https://bugs.webkit.org/show_bug.cgi?id=115897
1803
1804         Reviewed by Antti Koivisto.
1805
1806         Move rarely called functions out of line so headers don't have to include SecurityOrigin.h
1807
1808         * Modules/indexeddb/IDBFactoryBackendImpl.h:
1809         * Modules/webdatabase/DatabaseBackendBase.cpp:
1810         (WebCore::DatabaseBackendBase::databaseDebugName):
1811         * Modules/webdatabase/DatabaseBackendBase.h:
1812         (DatabaseBackendBase):
1813         * Modules/webdatabase/DatabaseSync.h:
1814         * bindings/js/JSDOMWindowCustom.h:
1815         * html/parser/XSSAuditor.cpp:
1816         * loader/ThreadableLoader.cpp:
1817         (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
1818         (WebCore::ThreadableLoaderOptions::~ThreadableLoaderOptions):
1819         (WebCore::ThreadableLoader::create):
1820         * loader/ThreadableLoader.h:
1821         (ThreadableLoaderOptions):
1822         * loader/WorkerThreadableLoader.cpp:
1823         * workers/DedicatedWorkerContext.cpp:
1824         * workers/DedicatedWorkerThread.cpp:
1825         * workers/SharedWorkerContext.cpp:
1826         * workers/WorkerThread.cpp:
1827         * workers/WorkerThread.h:
1828
1829 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1830
1831         Unreviewed. Fix GTK+ build after r149839.
1832
1833         * platform/gtk/RenderThemeGtk3.cpp:
1834         (WebCore::gtkStyleChangedCallback):
1835
1836 2013-05-09  Chris Fleizach  <cfleizach@apple.com>
1837
1838         AX: VoiceOver is no longer seeing items in poorly formed tables
1839         https://bugs.webkit.org/show_bug.cgi?id=115837
1840
1841         Reviewed by Darin Adler.
1842
1843         In case the author didn't include the rows of a table as the 
1844         direct children, a table needs to dive down its descendant chain
1845         until the rows are found. 
1846
1847         I also took the opportunity to clean up a bit around what the different
1848         meanings of table are in the accessibility classes.
1849
1850         Test: accessibility/poorly-formed-aria-table.html
1851
1852         * accessibility/AccessibilityARIAGrid.cpp:
1853         (WebCore::AccessibilityARIAGrid::addRowDescendant):
1854         (WebCore::AccessibilityARIAGrid::addChildren):
1855         * accessibility/AccessibilityARIAGrid.h:
1856         (AccessibilityARIAGrid):
1857         * accessibility/AccessibilityARIAGridRow.cpp:
1858         (WebCore::AccessibilityARIAGridRow::parentTable):
1859         (WebCore):
1860         * accessibility/AccessibilityARIAGridRow.h:
1861         (AccessibilityARIAGridRow):
1862         * accessibility/AccessibilityObject.h:
1863         (WebCore::AccessibilityObject::isTable):
1864         * accessibility/AccessibilityTable.h:
1865         (AccessibilityTable):
1866         (WebCore::AccessibilityTable::isTable):
1867         (WebCore::toAccessibilityTable):
1868         * accessibility/AccessibilityTableRow.cpp:
1869         (WebCore::AccessibilityTableRow::parentTable):
1870
1871 2013-05-09  Yael Aharon  <yael.aharon@intel.com>
1872
1873         REGRESSION: Disabled multiline select element now responds to (certain) clicks
1874         https://bugs.webkit.org/show_bug.cgi?id=115710
1875
1876         Reviewed by Kent Tamura.
1877
1878         After http://trac.webkit.org/changeset/140286, select elements can scroll whether they
1879         are disabled or not. While they scroll, they also change the selected item.
1880         This patch allows the select element to scroll, but does not change the selection
1881         if the select element is disabled.        
1882
1883         Test: fast/forms/select/listbox-disabled-scroll-no-onchange.html
1884         Test: fast/forms/select/listbox-disabled-no-autoscroll.html
1885
1886         * rendering/RenderListBox.cpp:
1887         (WebCore::RenderListBox::autoscroll):
1888         * rendering/RenderListBox.cpp:
1889         (WebCore::RenderListBox::stopAutoscroll):
1890
1891 2013-05-09  Anders Carlsson  <andersca@apple.com>
1892
1893         Clean up SecurityOrigin::databaseIdentifier
1894         https://bugs.webkit.org/show_bug.cgi?id=115882
1895
1896         Reviewed by Beth Dakin.
1897
1898         Remove m_encodedHost and just call encodeHost from databaseIdentifier().
1899         Also, use a StringBuilder when constructing the database identifier to avoid allocating
1900         temporary String objects over and over.
1901
1902         * page/SecurityOrigin.cpp:
1903         (WebCore::SecurityOrigin::SecurityOrigin):
1904         (WebCore):
1905         (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
1906         (WebCore::SecurityOrigin::databaseIdentifier):
1907         * page/SecurityOrigin.h:
1908         (SecurityOrigin):
1909
1910 2013-05-09  Anders Carlsson  <andersca@apple.com>
1911
1912         Remove m_securityOrigin from XMLHttpRequest
1913         https://bugs.webkit.org/show_bug.cgi?id=115881
1914
1915         Reviewed by Alexey Proskuryakov.
1916
1917         The security origin passed to XMLHttpRequest::create was always null, so just get rid of the member variable completely.
1918
1919         * xml/XMLHttpRequest.cpp:
1920         (WebCore::XMLHttpRequest::create):
1921         (WebCore::XMLHttpRequest::XMLHttpRequest):
1922         (WebCore::XMLHttpRequest::securityOrigin):
1923         * xml/XMLHttpRequest.h:
1924         (XMLHttpRequest):
1925
1926 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1927
1928         [NoInterfaceObject] extended attribute should be removed for several interfaces
1929         https://bugs.webkit.org/show_bug.cgi?id=115852
1930
1931         Reviewed by Benjamin Poulain.
1932
1933         Remove [NoInterfaceObject] extended attribute from the following Web IDL
1934         interfaces: SecurityPolicy, History, Location, Navigator, Performance,
1935         PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceNavigation,
1936         PerformanceResourceTiming, PerformanceTiming and Screen.
1937
1938         These interfaces should not have the [NoInterfaceObject] extended attribute
1939         according to their respective specifications:
1940         - http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-history-interface
1941         - http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-location-interface
1942         - https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicy
1943         - http://www.w3.org/html/wg/drafts/html/master/webappapis.html#the-navigator-object
1944         - http://www.w3.org/TR/navigation-timing/#performance
1945         - https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html#sec-PerformanceEntry-interface
1946         - http://www.w3.org/TR/navigation-timing/#performancenavigation
1947         - http://www.w3.org/TR/navigation-timing/#performancetiming
1948         - http://www.w3.org/TR/user-timing/#performancemark
1949         - http://www.w3.org/TR/user-timing/#performancemeasure
1950         - http://www.w3c-test.org/webperf/specs/ResourceTiming/#performanceresourcetiming
1951         - http://dev.w3.org/csswg/cssom-view/#the-screen-interface
1952
1953         The new behavior is consistent with the specifications, Firefox and soon Blink.
1954
1955         No new tests, already covered by existing tests.
1956
1957         * page/DOMSecurityPolicy.idl:
1958         * page/History.idl:
1959         * page/Location.idl:
1960         * page/Navigator.idl:
1961         * page/Performance.idl:
1962         * page/PerformanceEntry.idl:
1963         * page/PerformanceMark.idl:
1964         * page/PerformanceMeasure.idl:
1965         * page/PerformanceNavigation.idl:
1966         * page/PerformanceResourceTiming.idl:
1967         * page/PerformanceTiming.idl:
1968         * page/Screen.idl:
1969
1970 2013-05-09  Robert Hogan  <robert@webkit.org>
1971
1972         REGRESSION (Safari 3-Safari 4): Replaced element with percent height in table has incorrect height
1973         https://bugs.webkit.org/show_bug.cgi?id=26394
1974
1975         Reviewed by David Hyatt.
1976
1977         Text controls or any object that has scrollable content should not flex inside a table cell. 
1978         This makes our behaviour the same as IE, FF and Opera (Presto).
1979
1980         * rendering/RenderTableSection.cpp:
1981         (WebCore::RenderTableSection::layoutRows):
1982
1983 2013-05-09  Anders Carlsson  <andersca@apple.com>
1984
1985         Build fix.
1986
1987         * WebCore.exp.in:
1988
1989 2013-05-09  Anders Carlsson  <andersca@apple.com>
1990
1991         Add a StorageStrategy hook for creating transient local storage namespaces
1992         https://bugs.webkit.org/show_bug.cgi?id=115870
1993
1994         Reviewed by Geoffrey Garen.
1995
1996         * WebCore.exp.in:
1997         Export symbol needed by WebKit2.
1998         
1999         * dom/Document.cpp:
2000         (WebCore::Document::topOrigin):
2001         * dom/Document.h:
2002         * dom/ScriptExecutionContext.h:
2003         * workers/WorkerContext.h:
2004         Remove const qualifier from topOrigin() to avoid ugly const_casts when assigning into a RefPtr<SecurityOrigin> variable.
2005
2006         * page/PageGroup.cpp:
2007         (WebCore::PageGroup::transientLocalStorage):
2008         Do a single hash lookup instead of three and use the SecurityOrigin itself as the hash key instead of a string representation of it.
2009
2010         * page/PageGroup.h:
2011         Update HashMap declaration.
2012
2013         * storage/StorageNamespace.cpp:
2014         (WebCore::StorageNamespace::transientLocalStorageNamespace):
2015         Add new implementation that will optionally call out to the storage strategy.
2016
2017         * storage/StorageNamespaceImpl.cpp:
2018         (WebCore::StorageNamespaceImpl::transientLocalStorageNamespace):
2019         Move the default implementation here from PageGroup.
2020         
2021         * storage/StorageStrategy.cpp:
2022         (WebCore::StorageStrategy::transientLocalStorageNamespace):
2023         Call the default implementation.
2024
2025 2013-05-09  Enrica Casucci  <enrica@apple.com>
2026
2027         A change in system environment should force all CSS properties to be recomputed.
2028         https://bugs.webkit.org/show_bug.cgi?id=115872
2029         <rdar://problem/13781171>
2030
2031         Reviewed by Antti Koivisto.
2032
2033         When a change in the global environment occurs, for example system colors,
2034         we need to make sure all the CSS properties are recomputed and not fetched
2035         from the cache. For this reason we invalidate the properties cache.
2036         I've also renamed the function to give it a more meaningful name.
2037         
2038         * page/Page.cpp:
2039         (WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):
2040         * page/Page.h:
2041         * rendering/RenderTheme.cpp:
2042         (WebCore::RenderTheme::platformColorsDidChange):
2043
2044 2013-05-09  Antti Koivisto  <antti@apple.com>
2045
2046         Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
2047         <http://webkit.org/b/115590>
2048
2049         Reviewed by Darin Adler.
2050
2051         Common pseudo selectors should go into their respective rule buckets instead of ending up in the universal one.
2052
2053         * css/RuleSet.cpp:
2054         (WebCore::RuleSet::findBestRuleSetAndAdd):
2055         
2056             Check tag selectors with * local name (usually created for namespace) for a suitable narrower bucket too.
2057
2058 2013-05-09  Darin Adler  <darin@apple.com>
2059
2060         RenderQuote has giant function for language to quotes map
2061         https://bugs.webkit.org/show_bug.cgi?id=115807
2062
2063         Reviewed by Anders Carlsson.
2064
2065         * rendering/RenderQuote.cpp:
2066         (WebCore::RenderQuote::RenderQuote): Updated for m_isAttached name change.
2067         (WebCore::RenderQuote::~RenderQuote): Updated for name change, and also split
2068         assertion with && in it into two separate assertions.
2069         (WebCore::checkNumberOfDistinctQuoteCharacters): Added. Helper function that is used
2070         to check that the number of distinct quote characters is small enough to fit into
2071         our fixed size array below.
2072         (WebCore::quotesForLanguage): Replaces the old quotesDataLanguageMap function.
2073         Returns a pointer to a struct that contains the four quote characters. This new
2074         function doesn't have the massive amount of code that the old one did. We use the
2075         standard library bsearch function to do a binary search.
2076         (WebCore::stringForQuoteCharacter): Added. This returns a string for a given quote
2077         character; one string for any given character.
2078         (WebCore::quotationMarkString): Added. Returns the string for the quotation mark.
2079         (WebCore::apostropheStringImpl): Added. Returns the string for the apostrophe.
2080         (WebCore::RenderQuote::originalText): Rewrote this to include all the logic that
2081         used to be in the quotesData function.
2082         (WebCore::RenderQuote::attachQuote): Tweak assertions as above. Removed unneeded
2083         special case for the first quote in a RenderView; sharing the code is better and
2084         there is no significant performance difference. Also use m_isAttached directly
2085         when looking at predecessores so there is no need for an isAttached function.
2086         (WebCore::RenderQuote::detachQuote): Updated assertions and for name change.
2087         (WebCore::RenderQuote::updateDepth): Ditto.
2088
2089         * rendering/RenderQuote.h: Removed unneeded includes. Marked the class FINAL since
2090         we call the originalText function in the class and we don't want to do a virtual
2091         function dispatch for that. Removed uneeded const from an argument. Removed a
2092         stray semicolon. Removed the quotesData and isAttached functions, since they are no
2093         longer needed. Renamed m_attached to m_isAttached.
2094
2095         * rendering/style/QuotesData.cpp: Removed the overload of QuotesData::create that
2096         takes four quote strings. This was only used to build up the quotes table.
2097         * rendering/style/QuotesData.h: Ditto.
2098
2099 2013-05-09  Max Feil  <mfeil@rim.com>
2100
2101         shouldUsePluginDocument() needs to be respected when a document is created
2102         https://bugs.webkit.org/show_bug.cgi?id=110308
2103
2104         Reviewed by Rob Buis.
2105
2106         In DOMImplementation::createDocument() we should create
2107         a PluginDocument for mime types that return "true" for
2108         shouldAlwaysUsePluginDocument(), even if there is no pluginData
2109         for them. This lets a client choose plugins for which the "missing
2110         plugin" text or icon should appear more consistently. Otherwise
2111         plugins referenced by iFrames will be treated as an HTMLDocument,
2112         possibly resulting in binary files rendered as gibberish text.
2113
2114         Layout test platform/blackberry/plugins/swf-as-src-of-iframe.html
2115
2116         * dom/DOMImplementation.cpp:
2117         (WebCore::DOMImplementation::createDocument):
2118
2119 2013-05-09  Timothy Hatcher  <timothy@apple.com>
2120
2121         Fix an exception when hovering native functions while paused in the debugger.
2122
2123         https://webkit.org/b/115866
2124         rdar://problem/13681982
2125
2126         Reviewed by Darin Adler and Joseph Pecoraro.
2127
2128         * inspector/InjectedScriptSource.js:
2129         (InjectedScript.prototype.getFunctionDetails): Return an error if the details
2130         is null or undefined.
2131
2132 2013-05-09  Darin Adler  <darin@apple.com>
2133
2134         [Mac] CFError leak under Objective-C garbage collection
2135         https://bugs.webkit.org/show_bug.cgi?id=115862
2136
2137         Reviewed by Benjamin Poulain.
2138
2139         * platform/network/mac/ResourceErrorMac.mm:
2140         (WebCore::ResourceError::nsError): Use adoptCF instead of adoptNS since
2141         the CFError needs a CFRelease, not an -[NSObject release].
2142
2143 2013-05-09  Alberto Garcia  <agarcia@igalia.com>
2144
2145         BlackBerry: fix call to PluginLayerWebKitThread::setHolePunchRect()
2146         https://bugs.webkit.org/show_bug.cgi?id=114953
2147
2148         Reviewed by Rob Buis.
2149
2150         data->layer needs a cast in order to call setHolePunchRect().
2151
2152         * plugins/blackberry/NPCallbacksBlackBerry.cpp:
2153         (WebCore::npSetHolePunchHandler):
2154
2155 2013-05-09  Mike Fenton  <mifenton@rim.com>
2156
2157         [BlackBerry] Style updates required based on new check-webkit-style
2158         https://bugs.webkit.org/show_bug.cgi?id=115857
2159
2160         Reviewed by Rob Buis.
2161
2162         Update WebCore/platform/graphics BlackBerry sources
2163         to match check-webkit-style updates.
2164
2165         Internally reviewed by Jakob Petsovits.
2166
2167         * platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
2168         * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
2169         (WebCore::GraphicsContext3D::readPixelsIMG):
2170         (WebCore::GraphicsContext3D::paintToCanvas):
2171         * platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
2172         (WebCore::GraphicsLayerBlackBerry::updateLayerPosition):
2173         * platform/graphics/blackberry/IntRectBlackBerry.cpp:
2174         (WebCore::IntRect::IntRect):
2175         * platform/graphics/blackberry/LayerCompositingThread.h:
2176         (WTF::::deref):
2177         * platform/graphics/blackberry/LayerFilterRenderer.cpp:
2178         (WebCore::LayerFilterRenderer::initializeSharedGLObjects):
2179         (WebCore::LayerFilterRenderer::actionsForOperations):
2180         (WebCore::LayerFilterRenderer::applyActions):
2181         * platform/graphics/blackberry/LayerRenderer.cpp:
2182         (WebCore::LayerRenderer::setViewport):
2183         (WebCore::LayerRenderer::compositeBuffer):
2184         (WebCore::LayerRenderer::drawColor):
2185         (WebCore::LayerRenderer::compositeLayersRecursive):
2186         * platform/graphics/blackberry/LayerWebKitThread.cpp:
2187         (WebCore::LayerWebKitThread::setFrame):
2188         * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
2189         (WebCore::MediaPlayerPrivate::play):
2190         (WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
2191         * platform/image-decoders/blackberry/JPEGImageDecoder.cpp:
2192         (WebCore::JPEGImageDecoder::JPEGImageDecoder):
2193
2194 2013-05-09  Mike Fenton  <mifenton@rim.com>
2195
2196         [BlackBerry] Style updates required based on new check-webkit-style
2197         https://bugs.webkit.org/show_bug.cgi?id=115857
2198
2199         Reviewed by Rob Buis.
2200
2201         Update WebCore/platform/network/blackberry
2202         to match check-webkit-style updates.
2203
2204         * platform/network/blackberry/NetworkJob.cpp:
2205         (WebCore::NetworkJob::initialize):
2206         (WebCore::NetworkJob::handleSetCookieHeader):
2207         (WebCore::NetworkJob::sendResponseIfNeeded):
2208         (WebCore::NetworkJob::shouldSendClientData):
2209         * platform/network/blackberry/NetworkJob.h:
2210         (NetworkJob):
2211         * platform/network/blackberry/NetworkManager.cpp:
2212         (WebCore::NetworkManager::startJob):
2213         * platform/network/blackberry/rss/RSSFilterStream.cpp:
2214         (WebCore::isRSSContent):
2215         (WebCore::transcode):
2216
2217 2013-05-09  Mike Fenton  <mifenton@rim.com>
2218
2219         [BlackBerry] Style updates required based on new check-webkit-style
2220         https://bugs.webkit.org/show_bug.cgi?id=115857
2221
2222         Reviewed by Rob Buis.
2223
2224         Update WebCore/platform/blackberry to match check-webkit-style updates.
2225
2226         No functional changes.
2227
2228         * platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
2229         * platform/blackberry/CookieManager.cpp:
2230         (WebCore::CookieManager::getRawCookies):
2231         * platform/blackberry/CookieMap.h:
2232         (WebCore::CookieMap::count):
2233         * platform/blackberry/CookieParser.cpp:
2234         (WebCore::CookieParser::parseOneCookie):
2235         * platform/blackberry/LoggingBlackBerry.cpp:
2236         * platform/blackberry/PageClientBlackBerry.h:
2237         (Platform):
2238         (Graphics):
2239         (WebCore):
2240         * platform/blackberry/ParsedCookie.cpp:
2241         (WebCore::ParsedCookie::appendWebCoreCookie):
2242         * platform/blackberry/RenderThemeBlackBerry.cpp:
2243         (WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
2244         (WebCore::RenderThemeBlackBerry::paintButton):
2245         (WebCore::RenderThemeBlackBerry::paintSliderThumb):
2246         * platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
2247         (WebCore::signedPublicKeyAndChallengeString):
2248         * platform/blackberry/ScrollAnimatorBlackBerry.h:
2249
2250 2013-05-09  Chris Rogers  <crogers@google.com>
2251
2252         Require use of AudioBus::create() to avoid ref-counting issues
2253         https://bugs.webkit.org/show_bug.cgi?id=115836
2254
2255         Reviewed by Andreas Kling.
2256
2257         There were a couple of places still embedding raw AudioBus objects as
2258         member variables or local variables causing ref-counting problems
2259         now that AudioBus is ref-counted.  Make AudioBus constructor private
2260         to enforce use of AudioBus::create().
2261
2262         Adapted from Blink patch:
2263         https://chromiumcodereview.appspot.com/14628008/
2264
2265         * Modules/webaudio/AudioDestinationNode.h:
2266         (WebCore::AudioDestinationNode::LocalAudioInputProvider::LocalAudioInputProvider):
2267         (WebCore::AudioDestinationNode::LocalAudioInputProvider::set):
2268         (WebCore::AudioDestinationNode::LocalAudioInputProvider::provideInput):
2269         (LocalAudioInputProvider):
2270         * Modules/webaudio/AudioNodeInput.cpp:
2271         (WebCore::AudioNodeInput::AudioNodeInput):
2272         (WebCore::AudioNodeInput::updateInternalBus):
2273         * Modules/webaudio/AudioNodeOutput.cpp:
2274         (WebCore::AudioNodeOutput::AudioNodeOutput):
2275         (WebCore::AudioNodeOutput::updateInternalBus):
2276         * Modules/webaudio/AudioParam.cpp:
2277         (WebCore::AudioParam::calculateFinalValues):
2278         * Modules/webaudio/ConvolverNode.cpp:
2279         (WebCore::ConvolverNode::setBuffer):
2280         * Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
2281         (WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
2282         (WebCore::MediaStreamAudioDestinationNode::process):
2283         * Modules/webaudio/MediaStreamAudioDestinationNode.h:
2284         * Modules/webaudio/OfflineAudioDestinationNode.cpp:
2285         (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
2286         * Modules/webaudio/ScriptProcessorNode.cpp:
2287         (WebCore::ScriptProcessorNode::ScriptProcessorNode):
2288         (WebCore::ScriptProcessorNode::process):
2289         * Modules/webaudio/ScriptProcessorNode.h:
2290         (ScriptProcessorNode):
2291         * platform/audio/AudioBus.cpp:
2292         (WebCore::AudioBus::create):
2293         (WebCore):
2294         (WebCore::AudioBus::AudioBus):
2295         (WebCore::AudioBus::createBufferFromRange):
2296         (WebCore::AudioBus::createBySampleRateConverting):
2297         (WebCore::AudioBus::createByMixingToMono):
2298         * platform/audio/AudioBus.h:
2299         (AudioBus):
2300         * platform/audio/AudioFIFO.cpp:
2301         (WebCore::AudioFIFO::AudioFIFO):
2302         (WebCore::AudioFIFO::consume):
2303         (WebCore::AudioFIFO::push):
2304         * platform/audio/AudioFIFO.h:
2305         (AudioFIFO):
2306         * platform/audio/AudioPullFIFO.cpp:
2307         (WebCore::AudioPullFIFO::AudioPullFIFO):
2308         (WebCore::AudioPullFIFO::fillBuffer):
2309         * platform/audio/AudioPullFIFO.h:
2310         (AudioPullFIFO):
2311         * platform/audio/AudioResampler.cpp:
2312         (WebCore::AudioResampler::AudioResampler):
2313         (WebCore::AudioResampler::configureChannels):
2314         * platform/audio/MultiChannelResampler.cpp:
2315         * platform/audio/Reverb.cpp:
2316         (WebCore::Reverb::initialize):
2317         * platform/audio/SincResampler.cpp:
2318         (WebCore::SincResampler::consumeSource):
2319         (WebCore):
2320         * platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
2321         (WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
2322         * platform/audio/gstreamer/AudioDestinationGStreamer.h:
2323         (AudioDestinationGStreamer):
2324         * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
2325         (WebCore::AudioFileReader::createBus):
2326         * platform/audio/ios/AudioDestinationIOS.cpp:
2327         (WebCore::AudioDestinationIOS::AudioDestinationIOS):
2328         (WebCore::AudioDestinationIOS::render):
2329         * platform/audio/ios/AudioDestinationIOS.h:
2330         (AudioDestinationIOS):
2331         * platform/audio/mac/AudioDestinationMac.cpp:
2332         (WebCore::AudioDestinationMac::AudioDestinationMac):
2333         (WebCore::AudioDestinationMac::render):
2334         * platform/audio/mac/AudioDestinationMac.h:
2335         (AudioDestinationMac):
2336         * platform/audio/mac/AudioFileReaderMac.cpp:
2337         (WebCore::AudioFileReader::createBus):
2338
2339 2013-05-09  Alberto Garcia  <agarcia@igalia.com>
2340
2341         [BlackBerry] Upstream the input popups
2342         https://bugs.webkit.org/show_bug.cgi?id=114608
2343
2344         Reviewed by Rob Buis.
2345
2346         This patch contains contributions from many members of the
2347         BlackBerry WebKit team, including:
2348
2349         Chris Hutten-Czapski
2350         David Hoon
2351         Jessica Cao
2352         Rob Buis
2353         Tiancheng Jiang
2354
2355         * Resources/blackberry/colorControlBlackBerry.css: Added.
2356         (.color-picker-popup-area):
2357         (.color-picker-content):
2358         (.color-picker-block):
2359         (#color-picker-swatch-block):
2360         (.color-picker-switcher):
2361         (.color-picker-check-mark):
2362         (.color-picker-option):
2363         (.color-picker-button):
2364         (.color-picker-highlight):
2365         (input):
2366         (.color-picker-sharp):
2367         (.color-picker-off):
2368         (.color-picker-inactive-font):
2369         (.color-picker-row):
2370         (.color-picker-hex-style):
2371         (.color-picker-input):
2372         (.color-picker-well):
2373         (.color-picker-input .color-picker-well):
2374         (.color-picker-slider):
2375         (.color-picker-slider-output):
2376         (.color-picker-range):
2377         (.color-picker-range::-webkit-slider-thumb):
2378         (.color-picker-range::-webkit-slider-thumb:active):
2379         (.red-ranger-bg):
2380         (.green-ranger-bg):
2381         (.blue-ranger-bg):
2382         (@media only screen and (height: 768px)):
2383         (@media only screen and (height: 720px)):
2384         * Resources/blackberry/colorControlBlackBerry.js: Added.
2385         (.):
2386         * Resources/blackberry/popupControlBlackBerry.css:
2387         (body):
2388         (.popup-area):
2389         (.popup-header):
2390         (.popup-content):
2391         (.popup-buttons):
2392         (.popup-button):
2393         (@media only screen and (width: 720px) and (height: 720px)):
2394         * Resources/blackberry/selectControlBlackBerry.css:
2395         (.popup-content):
2396         (@media (min-height: 918px)):
2397         (.option):
2398         (@media only screen and (width: 720px) and (height: 720px)):
2399         (.contents):
2400         (.option:active):
2401         (.selected):
2402         (.selected .contents::after):
2403         (.text):
2404         (.disabled):
2405         (.optgroup):
2406         (.optgroup-option):
2407         * Resources/blackberry/selectControlBlackBerry.js:
2408         (.):
2409         * Resources/blackberry/timeControlBlackBerry.css: Added.
2410         (#popup-content-time):
2411         (.column):
2412         (.column:not(:last-child)):
2413         (.cell):
2414         (.yearmonthdate .cell div:last-child):
2415         (.row-highlight-container):
2416         (.row-highlight-filler):
2417         (.row-highlight):
2418         (.tall-bit):
2419         (@media only screen and (width: 720px) and (height: 720px)):
2420         * Resources/blackberry/timeControlBlackBerry.js: Added.
2421         (.):
2422
2423 2013-05-09  Rob Buis  <rbuis@rim.com>
2424
2425         [BlackBerry] texmap code generates warnings
2426         https://bugs.webkit.org/show_bug.cgi?id=115815
2427
2428         Reviewed by Benjamin Poulain.
2429
2430         Add USE(TEXTURE_MAPPER) guards since Source/WebCore/CMakeLists.txt includes
2431         these files unconditionally.
2432
2433         * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
2434         * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
2435         * platform/graphics/texmap/TextureMapper.h:
2436         * platform/graphics/texmap/TextureMapperBackingStore.cpp:
2437         * platform/graphics/texmap/TextureMapperBackingStore.h:
2438         * platform/graphics/texmap/TextureMapperFPSCounter.cpp:
2439         * platform/graphics/texmap/TextureMapperFPSCounter.h:
2440         * platform/graphics/texmap/TextureMapperGL.cpp:
2441         * platform/graphics/texmap/TextureMapperGL.h:
2442         * platform/graphics/texmap/TextureMapperLayer.cpp:
2443         * platform/graphics/texmap/TextureMapperLayer.h:
2444         * platform/graphics/texmap/TextureMapperTile.cpp:
2445         * platform/graphics/texmap/TextureMapperTile.h:
2446         * platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
2447         * platform/graphics/texmap/TextureMapperTiledBackingStore.h:
2448
2449 2013-05-09  Alberto Garcia  <agarcia@igalia.com>
2450
2451         PluginDatabase: add plugin directory for the BlackBerry port.
2452         https://bugs.webkit.org/show_bug.cgi?id=114943
2453
2454         Reviewed by Rob Buis.
2455
2456         XP_UNIX is defined for the BlackBerry port, but we don't want to
2457         share the same code here.
2458
2459         * plugins/PluginDatabase.cpp:
2460         (WebCore::PluginDatabase::defaultPluginDirectories):
2461         (WebCore::PluginDatabase::isPreferredPluginDirectory):
2462
2463 2013-05-09  Seokju Kwon  <seokju.kwon@gmail.com>
2464
2465         Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
2466         https://bugs.webkit.org/show_bug.cgi?id=115850
2467
2468         Reviewed by Andreas Kling.
2469
2470         Removed the Memory Instrumentation Code after r148921.
2471
2472         No new tests, no behavior change.
2473
2474         * inspector/compile-front-end.py:
2475         * inspector/front-end/NativeMemorySnapshotView.js: Removed.
2476         * inspector/front-end/ProfilesPanel.js:
2477         (WebInspector.ProfilesPanel):
2478         * inspector/front-end/Settings.js:
2479         (WebInspector.Settings):
2480         (WebInspector.ExperimentsSettings):
2481         * inspector/front-end/SettingsScreen.js:
2482         * inspector/front-end/WebKit.qrc:
2483         * inspector/front-end/inspector.css:
2484         * inspector/front-end/inspector.js:
2485         (WebInspector._panelDescriptors):
2486         * inspector/front-end/nativeMemoryProfiler.css: Removed.
2487
2488 2013-05-09  Zan Dobersek  <zdobersek@igalia.com>
2489
2490         Unreviewed GTK build fix after r149796.
2491
2492         * GNUmakefile.am: Add a phony target for the window constructors file and include it among
2493         the dependencies for the non-generated code.
2494
2495 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2496
2497         Unreviewed build fix for Qt minimal build.
2498
2499         r149796 broke builds that have WEB_SOCKETS flag disabled.
2500
2501         * page/DOMWindow.idl:
2502
2503 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2504
2505         Add support for [NoInterfaceObject] Web IDL extended attribute
2506         https://bugs.webkit.org/show_bug.cgi?id=115714
2507
2508         Reviewed by Kentaro Hara.
2509
2510         *Constructor attributes on the global DOMWindow object are now automatically
2511         generated for each non-callback interface that is not declared with the
2512         [NoInterfaceObject] extended attribute. It is thus no longer needed for
2513         developers to manually add *Constructor attributes for their new interfaces
2514         unless they wish to register an "extra" constructor for their interface.
2515
2516         This patch does not modify at all the behavior on JS side. To achieve this,
2517         [NoInterfaceObject] extended attribute is added to interfaces that should
2518         not have it according to specification (e.g. History, Location, ...).
2519         This can be improved later as the behavior should not change with this
2520         patch.
2521
2522         No new tests, no behavior change.
2523
2524         * CMakeLists.txt:
2525         * DerivedSources.make:
2526         * DerivedSources.pri:
2527         * GNUmakefile.am:
2528         * GNUmakefile.list.am:
2529         * Modules/battery/BatteryManager.idl:
2530         * Modules/encryptedmedia/MediaKeyMessageEvent.idl:
2531         * Modules/encryptedmedia/MediaKeyNeededEvent.idl:
2532         * Modules/encryptedmedia/MediaKeySession.idl:
2533         * Modules/encryptedmedia/MediaKeys.idl:
2534         * Modules/filesystem/DOMFileSystem.idl:
2535         * Modules/filesystem/DOMFileSystemSync.idl:
2536         * Modules/filesystem/DirectoryEntry.idl:
2537         * Modules/filesystem/DirectoryEntrySync.idl:
2538         * Modules/filesystem/DirectoryReader.idl:
2539         * Modules/filesystem/DirectoryReaderSync.idl:
2540         * Modules/filesystem/Entry.idl:
2541         * Modules/filesystem/EntryArray.idl:
2542         * Modules/filesystem/EntryArraySync.idl:
2543         * Modules/filesystem/EntrySync.idl:
2544         * Modules/filesystem/FileEntry.idl:
2545         * Modules/filesystem/FileEntrySync.idl:
2546         * Modules/filesystem/FileWriter.idl:
2547         * Modules/filesystem/FileWriterSync.idl:
2548         * Modules/filesystem/Metadata.idl:
2549         * Modules/gamepad/Gamepad.idl:
2550         * Modules/gamepad/GamepadList.idl:
2551         * Modules/geolocation/Coordinates.idl:
2552         * Modules/geolocation/Geolocation.idl:
2553         * Modules/geolocation/Geoposition.idl:
2554         * Modules/geolocation/PositionError.idl:
2555         * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
2556         * Modules/indexeddb/IDBAny.idl:
2557         * Modules/mediasource/MediaSource.idl:
2558         * Modules/mediasource/SourceBuffer.idl:
2559         * Modules/mediasource/SourceBufferList.idl:
2560         * Modules/mediastream/DOMWindowMediaStream.idl: Removed.
2561         * Modules/mediastream/MediaStream.idl:
2562         * Modules/mediastream/MediaStreamTrack.idl:
2563         * Modules/mediastream/MediaStreamTrackEvent.idl:
2564         * Modules/mediastream/NavigatorUserMediaError.idl:
2565         * Modules/mediastream/RTCDTMFSender.idl:
2566         * Modules/mediastream/RTCDTMFToneChangeEvent.idl:
2567         * Modules/mediastream/RTCDataChannel.idl:
2568         * Modules/mediastream/RTCDataChannelEvent.idl:
2569         * Modules/mediastream/RTCIceCandidateEvent.idl:
2570         * Modules/mediastream/RTCPeerConnection.idl:
2571         * Modules/mediastream/RTCStatsReport.idl:
2572         * Modules/mediastream/RTCStatsResponse.idl:
2573         * Modules/networkinfo/NetworkInfoConnection.idl:
2574         * Modules/notifications/DOMWindowNotifications.idl:
2575         * Modules/notifications/NotificationCenter.idl:
2576         * Modules/quota/StorageInfo.idl:
2577         * Modules/quota/StorageQuota.idl:
2578         * Modules/speech/DOMWindowSpeech.idl: Removed.
2579         * Modules/speech/DOMWindowSpeechSynthesis.idl:
2580         * Modules/speech/SpeechGrammar.idl:
2581         * Modules/speech/SpeechGrammarList.idl:
2582         * Modules/speech/SpeechRecognition.idl:
2583         * Modules/speech/SpeechRecognitionAlternative.idl:
2584         * Modules/speech/SpeechRecognitionError.idl:
2585         * Modules/speech/SpeechRecognitionEvent.idl:
2586         * Modules/speech/SpeechRecognitionResult.idl:
2587         * Modules/speech/SpeechRecognitionResultList.idl:
2588         * Modules/speech/SpeechSynthesis.idl:
2589         * Modules/speech/SpeechSynthesisVoice.idl:
2590         * Modules/webaudio/AnalyserNode.idl:
2591         * Modules/webaudio/AudioBuffer.idl:
2592         * Modules/webaudio/AudioBufferSourceNode.idl:
2593         * Modules/webaudio/AudioContext.idl:
2594         * Modules/webaudio/AudioDestinationNode.idl:
2595         * Modules/webaudio/AudioListener.idl:
2596         * Modules/webaudio/AudioNode.idl:
2597         * Modules/webaudio/AudioParam.idl:
2598         * Modules/webaudio/AudioSourceNode.idl:
2599         * Modules/webaudio/BiquadFilterNode.idl:
2600         * Modules/webaudio/ChannelMergerNode.idl:
2601         * Modules/webaudio/ChannelSplitterNode.idl:
2602         * Modules/webaudio/ConvolverNode.idl:
2603         * Modules/webaudio/DOMWindowWebAudio.idl: Removed.
2604         * Modules/webaudio/DelayNode.idl:
2605         * Modules/webaudio/DynamicsCompressorNode.idl:
2606         * Modules/webaudio/GainNode.idl:
2607         * Modules/webaudio/MediaElementAudioSourceNode.idl:
2608         * Modules/webaudio/MediaStreamAudioDestinationNode.idl:
2609         * Modules/webaudio/MediaStreamAudioSourceNode.idl:
2610         * Modules/webaudio/OfflineAudioContext.idl:
2611         * Modules/webaudio/OscillatorNode.idl:
2612         * Modules/webaudio/PannerNode.idl:
2613         * Modules/webaudio/ScriptProcessorNode.idl:
2614         * Modules/webaudio/WaveShaperNode.idl:
2615         * Modules/webaudio/WaveTable.idl:
2616         * Modules/webdatabase/DOMWindowWebDatabase.idl:
2617         * Modules/webdatabase/Database.idl:
2618         * Modules/webdatabase/DatabaseSync.idl:
2619         * Modules/webdatabase/SQLError.idl:
2620         * Modules/webdatabase/SQLResultSet.idl:
2621         * Modules/webdatabase/SQLResultSetRowList.idl:
2622         * Modules/webdatabase/SQLTransaction.idl:
2623         * Modules/webdatabase/SQLTransactionSync.idl:
2624         * Modules/websockets/DOMWindowWebSocket.idl: Removed.
2625         * Modules/websockets/WebSocket.idl:
2626         * PlatformBlackBerry.cmake:
2627         * UseJSC.cmake:
2628         * WebCore.xcodeproj/project.pbxproj:
2629         * bindings/scripts/IDLAttributes.txt:
2630         * bindings/scripts/IDLParser.pm:
2631         (parseTypedef):
2632         * bindings/scripts/preprocess-idls.pl:
2633         (GenerateConstructorAttribute):
2634         (getFileContents):
2635         (getPartialInterfaceNameFromIDL):
2636         (isCallbackInterfaceFromIDL):
2637         (trim):
2638         (getInterfaceExtendedAttributesFromIDL):
2639         * css/CSSFontFaceLoadEvent.idl:
2640         * css/CSSFontFaceRule.idl:
2641         * css/CSSSupportsRule.idl:
2642         * css/CSSUnknownRule.idl:
2643         * css/DOMWindowCSS.idl:
2644         * css/FontLoader.idl:
2645         * css/MediaQueryList.idl:
2646         * css/MediaQueryListListener.idl:
2647         * css/StyleMedia.idl:
2648         * dom/CustomElementConstructor.idl:
2649         * dom/DOMError.idl:
2650         * dom/DOMNamedFlowCollection.idl:
2651         * dom/DataTransferItem.idl:
2652         * dom/DataTransferItemList.idl:
2653         * dom/EventListener.idl:
2654         * dom/EventTarget.idl:
2655         * dom/NodeIterator.idl:
2656         * dom/ShadowRoot.idl:
2657         * dom/TreeWalker.idl:
2658         * dom/WebKitNamedFlow.idl:
2659         * fileapi/FileException.idl:
2660         * fileapi/FileReaderSync.idl:
2661         * html/HTMLAudioElement.idl:
2662         * html/HTMLDetailsElement.idl:
2663         * html/HTMLOptionElement.idl:
2664         * html/MediaError.idl:
2665         * html/MediaKeyError.idl:
2666         * html/MicroDataItemValue.idl:
2667         * html/RadioNodeList.idl:
2668         * html/ValidityState.idl:
2669         * html/canvas/CanvasRenderingContext.idl:
2670         * html/canvas/DOMPath.idl:
2671         * html/canvas/EXTDrawBuffers.idl:
2672         * html/canvas/EXTTextureFilterAnisotropic.idl:
2673         * html/canvas/OESElementIndexUint.idl:
2674         * html/canvas/OESStandardDerivatives.idl:
2675         * html/canvas/OESTextureFloat.idl:
2676         * html/canvas/OESTextureHalfFloat.idl:
2677         * html/canvas/OESVertexArrayObject.idl:
2678         * html/canvas/WebGLCompressedTextureATC.idl:
2679         * html/canvas/WebGLCompressedTexturePVRTC.idl:
2680         * html/canvas/WebGLCompressedTextureS3TC.idl:
2681         * html/canvas/WebGLContextAttributes.idl:
2682         * html/canvas/WebGLDebugRendererInfo.idl:
2683         * html/canvas/WebGLDebugShaders.idl:
2684         * html/canvas/WebGLDepthTexture.idl:
2685         * html/canvas/WebGLLoseContext.idl:
2686         * html/canvas/WebGLVertexArrayObjectOES.idl:
2687         * html/track/AudioTrack.idl:
2688         * html/track/AudioTrackList.idl:
2689         * html/track/TextTrackRegionList.idl:
2690         * html/track/VideoTrack.idl:
2691         * html/track/VideoTrackList.idl:
2692         * inspector/InjectedScriptHost.idl:
2693         * inspector/InspectorFrontendHost.idl:
2694         * inspector/JavaScriptCallFrame.idl:
2695         * inspector/ScriptProfile.idl:
2696         * inspector/ScriptProfileNode.idl:
2697         * loader/appcache/DOMApplicationCache.idl:
2698         * page/AbstractView.idl:
2699         * page/BarInfo.idl:
2700         * page/Console.idl:
2701         * page/Crypto.idl:
2702         * page/DOMSecurityPolicy.idl:
2703         * page/DOMWindow.idl:
2704         * page/History.idl:
2705         * page/Location.idl:
2706         * page/MemoryInfo.idl:
2707         * page/Navigator.idl:
2708         * page/PagePopupController.idl:
2709         * page/Performance.idl:
2710         * page/PerformanceEntry.idl:
2711         * page/PerformanceEntryList.idl:
2712         * page/PerformanceMark.idl:
2713         * page/PerformanceMeasure.idl:
2714         * page/PerformanceNavigation.idl:
2715         * page/PerformanceResourceTiming.idl:
2716         * page/PerformanceTiming.idl:
2717         * page/Screen.idl:
2718         * page/SpeechInputResult.idl:
2719         * page/SpeechInputResultList.idl:
2720         * page/WorkerNavigator.idl:
2721         * page/make_settings.pl:
2722         (generateInternalSettingsIdlFile):
2723         * svg/ElementTimeControl.idl:
2724         * svg/SVGAnimationElement.idl:
2725         * svg/SVGExternalResourcesRequired.idl:
2726         * svg/SVGFilterPrimitiveStandardAttributes.idl:
2727         * svg/SVGFitToViewBox.idl:
2728         * svg/SVGLangSpace.idl:
2729         * svg/SVGLocatable.idl:
2730         * svg/SVGStyledElement.idl:
2731         * svg/SVGTests.idl:
2732         * svg/SVGTransformable.idl:
2733         * svg/SVGURIReference.idl:
2734         * testing/InternalSettings.idl:
2735         * testing/Internals.idl:
2736         * testing/MallocStatistics.idl:
2737         * testing/TypeConversions.idl:
2738         * workers/AbstractWorker.idl:
2739         * workers/DedicatedWorkerContext.idl:
2740         * workers/SharedWorker.idl:
2741         * workers/SharedWorkerContext.idl:
2742         * workers/WorkerContext.idl:
2743         * workers/WorkerLocation.idl:
2744         * xml/XPathExpression.idl:
2745         * xml/XPathNSResolver.idl:
2746
2747 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
2748
2749         [GTK][AC] Buildfix after r149694
2750         https://bugs.webkit.org/show_bug.cgi?id=115797
2751
2752         Reviewed by Gustavo Noronha Silva.
2753
2754         Some interfaces, such as a return value and parameters of functions are changed.
2755
2756         No new tests since no functionality changed.
2757
2758         * platform/graphics/clutter/GraphicsLayerClutter.cpp:
2759         (WebCore::animationHasStepsTimingFunction):
2760         (WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
2761         (WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
2762         (WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
2763         (WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
2764         (WebCore::GraphicsLayerClutter::setAnimationEndpoints):
2765         (WebCore::GraphicsLayerClutter::setAnimationKeyframes):
2766         * platform/graphics/clutter/GraphicsLayerClutter.h:
2767         (GraphicsLayerClutter):
2768
2769 2013-05-08  Rob Buis  <rbuis@rim.com>
2770
2771         Fix some compiler warnings (miscellaneous)
2772         https://bugs.webkit.org/show_bug.cgi?id=80790
2773
2774         Reviewed by Brent Fulgham.
2775
2776         Get rid of the following warning for BlackBerry:
2777
2778         NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
2779
2780         by not compiling any of the code to add protocols to the protocol whitelist.
2781
2782         * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
2783         (WebCore::initProtocolHandlerWhitelist):
2784
2785 2013-05-08  peavo@outlook.com  <peavo@outlook.com>
2786
2787         [Windows] The function seekFile() is not implemented.
2788         https://bugs.webkit.org/show_bug.cgi?id=115246
2789
2790         Reviewed by Brent Fulgham.
2791
2792         Implemented seekFile() function for Windows.
2793
2794         * platform/win/FileSystemWin.cpp:
2795         (WebCore::seekFile):
2796
2797 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
2798
2799         Web Inspector: Fix a typo in Settings.js
2800         https://bugs.webkit.org/show_bug.cgi?id=115849
2801
2802         Reviewed by Joseph Pecoraro.
2803
2804         No new tests, no behavior change.
2805
2806         * inspector/front-end/Settings.js:
2807         (WebInspector.Settings):
2808
2809 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
2810
2811         SecurityOrigin doesn’t need to forward declare or include Document
2812         https://bugs.webkit.org/show_bug.cgi?id=115847
2813
2814         Reviewed by Alexey Proskuryakov.
2815
2816         Merge https://chromium.googlesource.com/chromium/blink/+/fc7a88caa9c41f3471d8994a530643e5225f82fc.
2817
2818         Removed unused Document forward declaration+include from SecurityOrigin.
2819
2820         * page/SecurityOrigin.cpp:
2821         * page/SecurityOrigin.h:
2822
2823 2013-05-08  David Kilzer  <ddkilzer@apple.com>
2824
2825         BUILD FIX: Don't use adoptCF() with NSDictionary * object
2826
2827         Fixes the following build failure:
2828
2829             In file included from Source/WebCore/platform/network/mac/ResourceErrorMac.mm:27:
2830             In file included from Source/WebCore/platform/network/cf/ResourceError.h:31:
2831             /usr/local/include/wtf/RetainPtr.h:81:13: error: static_assert failed "Don't use adoptCF with Objective-C pointer types, use adoptNS."
2832                         static_assert(!std::is_convertible<T, id>::value, "Don't use adoptCF with Objective-C pointer types, use adoptNS.");
2833                         ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2834             /usr/local/include/wtf/RetainPtr.h:274:16: note: in instantiation of member function 'WTF::RetainPtr<NSDictionary *>::RetainPtr' requested here
2835                     return RetainPtr<T>(AdoptCF, o);
2836                            ^
2837             Source/WebCore/platform/network/mac/ResourceErrorMac.mm:214:44: note: in instantiation of function template specialization 'WTF::adoptCF<NSDictionary *>' requested here
2838                     RetainPtr<NSDictionary> userInfo = adoptCF((NSDictionary *) CFErrorCopyUserInfo(error));
2839                                                        ^
2840             1 error generated.
2841
2842         * platform/network/mac/ResourceErrorMac.mm:
2843         (WebCore::ResourceError::nsError): Switch from adoptCF() to
2844         adoptNS().  This is in USE(CFNETWORK) code, so it's not
2845         exercised on the Mac.
2846
2847 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
2848
2849         Remove Editor::setSelectionOffsets
2850         https://bugs.webkit.org/show_bug.cgi?id=115831
2851
2852         Reviewed by Andreas Kling.
2853
2854         Removed the function added in r120985 for Chromium Android port.
2855
2856         * editing/Editor.cpp:
2857         * editing/Editor.h:
2858
2859 2013-05-07  Ryosuke Niwa  <rniwa@webkit.org>
2860
2861         Potential use-after-free of Frame
2862         https://bugs.webkit.org/show_bug.cgi?id=115774
2863
2864         Reviewed by Simon Fraser.
2865
2866         Merge https://chromium.googlesource.com/chromium/blink/+/c5b4a6db82e8280c7fc55ee3dc3a84c6b026e66e.
2867
2868         * page/Frame.cpp:
2869         (WebCore::Frame::setPrinting):
2870         (WebCore::Frame::setPageAndTextZoomFactors):
2871         (WebCore::Frame::deviceOrPageScaleFactorChanged):
2872
2873 2013-05-08  Roger Fong  <roger_fong@apple.com>
2874
2875         Unreviewed build fix, AppleWin port.
2876
2877         * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
2878         * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
2879         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2880         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
2881         (WebCore::MediaPlayerPrivateAVFoundation::seek):
2882         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
2883         (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
2884         (WebCore):
2885         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2886         (MediaPlayerPrivateAVFoundation):
2887
2888 2013-05-08  Xingnan Wang  <xingnan.wang@intel.com>
2889
2890         Heap-use-after-free in WebCore::AudioNodeOutput::pull
2891         https://bugs.webkit.org/show_bug.cgi?id=111362
2892
2893         Reviewed by Chris Rogers.
2894
2895         * Modules/webaudio/AudioBuffer.cpp:
2896         (WebCore::AudioBuffer::createFromAudioFileData):
2897         * Modules/webaudio/AudioNodeInput.cpp:
2898         (WebCore::AudioNodeInput::AudioNodeInput):
2899         (WebCore::AudioNodeInput::updateInternalBus):
2900         * Modules/webaudio/AudioNodeInput.h:
2901         (AudioNodeInput):
2902         * Modules/webaudio/AudioNodeOutput.cpp:
2903         (WebCore::AudioNodeOutput::AudioNodeOutput):
2904         (WebCore::AudioNodeOutput::updateInternalBus):
2905         (WebCore::AudioNodeOutput::pull):
2906         (WebCore::AudioNodeOutput::bus):
2907         * Modules/webaudio/AudioNodeOutput.h:
2908         (AudioNodeOutput):
2909         * Modules/webaudio/OfflineAudioDestinationNode.cpp:
2910         (WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
2911         * Modules/webaudio/OfflineAudioDestinationNode.h:
2912         (OfflineAudioDestinationNode):
2913         * platform/audio/AudioBus.cpp:
2914         (WebCore::AudioBus::createBufferFromRange):
2915         (WebCore::AudioBus::createBySampleRateConverting):
2916         (WebCore::AudioBus::createByMixingToMono):
2917         * platform/audio/AudioBus.h:
2918         (AudioBus):
2919         * platform/audio/AudioFileReader.h:
2920         (WebCore):
2921         * platform/audio/AudioResampler.cpp:
2922         (WebCore::AudioResampler::AudioResampler):
2923         (WebCore::AudioResampler::configureChannels):
2924         * platform/audio/AudioResampler.h:
2925         (AudioResampler):
2926         * platform/audio/HRTFElevation.cpp:
2927         (WebCore::getConcatenatedImpulseResponsesForSubject):
2928         (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
2929         * platform/audio/MultiChannelResampler.cpp:
2930         * platform/audio/Reverb.cpp:
2931         (WebCore::Reverb::initialize):
2932         * platform/audio/Reverb.h:
2933         (Reverb):
2934         * platform/audio/efl/AudioBusEfl.cpp:
2935         (WebCore::AudioBus::loadPlatformResource):
2936         * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
2937         (AudioFileReader):
2938         (WebCore::AudioFileReader::createBus):
2939         (WebCore::createBusFromAudioFile):
2940         (WebCore::createBusFromInMemoryAudioFile):
2941         * platform/audio/gtk/AudioBusGtk.cpp:
2942         (WebCore::AudioBus::loadPlatformResource):
2943         * platform/audio/mac/AudioBusMac.mm:
2944         (WebCore::AudioBus::loadPlatformResource):
2945         * platform/audio/mac/AudioFileReaderMac.cpp:
2946         (WebCore::AudioFileReader::createBus):
2947         (WebCore::createBusFromAudioFile):
2948         (WebCore::createBusFromInMemoryAudioFile):
2949         * platform/audio/mac/AudioFileReaderMac.h:
2950         (AudioFileReader):
2951         * platform/audio/qt/AudioBusQt.cpp:
2952         (WebCore::AudioBus::loadPlatformResource):
2953
2954 2013-05-08  Eli Fidler  <efidler@blackberry.com>
2955
2956         [BlackBerry] Fix usage of BlackBerry::Platform::String
2957         https://bugs.webkit.org/show_bug.cgi?id=115781
2958
2959         Reviewed by Rob Buis.
2960
2961         BlackBerry PRs 304193 and 327181
2962         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
2963
2964         We currently have a problem where we're passing UTF-8 encoded data into
2965         the char* constructors of BlackBerry::Platform::String. This means the string
2966         thinks its data is not UTF-8.
2967
2968         * platform/blackberry/ClipboardBlackBerry.cpp:
2969         (WebCore::ClipboardBlackBerry::setData):
2970         (WebCore::ClipboardBlackBerry::writeURL):
2971         (WebCore::ClipboardBlackBerry::writePlainText):
2972         * platform/blackberry/CookieManager.cpp:
2973         (WebCore::CookieManager::getRawCookies):
2974         (WebCore::CookieManager::getBackingStoreCookies):
2975         * platform/blackberry/CookieParser.cpp:
2976         (WebCore::CookieParser::CookieParser):
2977         (WebCore::CookieParser::parseOneCookie):
2978         * platform/blackberry/CursorBlackBerry.cpp:
2979         (WebCore::Cursor::Cursor):
2980         * platform/blackberry/PlatformBlob.cpp:
2981         (WebCore::PlatformBlob::nextDataItem):
2982         * platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
2983         (WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
2984         (WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
2985         (WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
2986         (WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
2987         (WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
2988         (WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
2989         (WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
2990         (WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
2991         (WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
2992         (WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
2993         (WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
2994         (WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
2995         (WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
2996         (WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
2997         * platform/graphics/blackberry/ImageBlackBerry.cpp:
2998         (WebCore::Image::loadPlatformResource):
2999         * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
3000         (WebCore::MediaPlayerPrivate::load):
3001         (WebCore::MediaPlayerPrivate::notifyChallengeResult):
3002         (WebCore::toWebMediaStreamSource):
3003         (WebCore::toWebMediaStreamDescriptor):
3004         * platform/network/blackberry/NetworkManager.cpp:
3005         (WebCore::NetworkManager::startJob):
3006         * platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
3007         (WebCore::SocketStreamHandle::SocketStreamHandle):
3008         * platform/network/blackberry/rss/RSSFilterStream.cpp:
3009         (WebCore::RSSFilterStream::notifyStatusReceived):
3010         (WebCore::RSSFilterStream::notifyHeadersReceived):
3011         (WebCore::RSSFilterStream::convertContentToHtml):
3012         (WebCore::RSSFilterStream::charset):
3013         (WebCore::RSSFilterStream::removeHeader):
3014         (WebCore::RSSFilterStream::updateHeader):
3015         (WebCore::RSSFilterStream::updateRSSHeaders):
3016         * platform/network/blackberry/rss/RSSFilterStream.h:
3017         * platform/text/blackberry/StringBlackBerry.cpp:
3018         (WTF::String::operator BlackBerry::Platform::String):
3019
3020 2013-05-08  Anders Carlsson  <andersca@apple.com>
3021
3022         Assert at compile time that we don't pass Objective-C object pointers to adoptCF
3023         https://bugs.webkit.org/show_bug.cgi?id=115823
3024
3025         Reviewed by Geoffrey Garen.
3026
3027         * platform/graphics/ca/mac/TileController.mm:
3028         (WebCore::TileController::TileController):
3029         Use adoptNS for CALayer.
3030
3031 2013-05-08  Eric Carlson  <eric.carlson@apple.com>
3032
3033         TextTrackCue should support empty content
3034         https://bugs.webkit.org/show_bug.cgi?id=115821
3035
3036         Reviewed by Jer Noble.
3037
3038         Test: media/track/track-cue-empty-text-crash.html
3039
3040         * html/shadow/MediaControlElements.cpp:
3041         (WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't bother trying to render
3042             cues with no content.
3043
3044         * html/track/TextTrackCue.cpp:
3045         (WebCore::TextTrackCue::getCueAsHTML): Return early if there isn't a node tree.
3046         (WebCore::TextTrackCue::createCueRenderingTree): Ditto.
3047         (WebCore::TextTrackCue::determineTextDirection): Ditto.
3048         (WebCore::TextTrackCue::updateDisplayTree): Return early if there isn't a cue rendering tree.
3049
3050 2013-05-08  Roger Fong  <roger_fong@apple.com>
3051
3052         Unreviewed AppleWin build fix.
3053
3054         * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
3055         (MediaPlayerPrivateAVFoundationCF):
3056         (WebCore::MediaPlayerPrivateAVFoundationCF::currentTrack):
3057
3058 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
3059
3060         [GTK] Plumb the Automake build system for the Battery Status API feature
3061         https://bugs.webkit.org/show_bug.cgi?id=115718
3062
3063         Reviewed by Martin Robinson.
3064
3065         No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
3066         pass when it is.
3067
3068         * GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.
3069         Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
3070         List these IDL files using a wildcard under the EXTRA_DIST list.
3071         * GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
3072         * bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.
3073
3074 2013-05-08  Roger Fong  <roger_fong@apple.com>
3075
3076         Unreviewed. AppleWin VS2010 build fix.
3077
3078         * WebCore.vcxproj/WebCore.vcxproj:
3079         * WebCore.vcxproj/WebCore.vcxproj.filters:
3080
3081 2013-05-08  Darin Adler  <darin@apple.com>
3082
3083         REGRESSION(r149700): fast/css-generated-content/close-quote-negative-depth.html
3084         https://bugs.webkit.org/show_bug.cgi?id=115776
3085
3086         Reviewed by Anders Carlsson.
3087
3088         I changed depth to more closely match what is in the CSS3 specification.
3089         There may be a more optimal way to make it work, but this seems the most straightforward.
3090
3091         * rendering/RenderQuote.cpp:
3092         (WebCore::RenderQuote::RenderQuote): Initialize m_depth to -1 because that depth
3093         is consistent with the empty string that is the initial value of the text. The
3094         real depth will be calculated when the node is attached.
3095         (WebCore::RenderQuote::originalText): Removed the "depth - 1" logic that
3096         used to be done for close quotes. Instead, the updateDepth function now correctly
3097         subtracts one for the close quote itself, not just afterward. Also added an early
3098         exit when the depth is negative; these changes together fix the bug.
3099         (WebCore::RenderQuote::attachQuote): Added a call to updateDepth even for the render
3100         quote head, we now need that to set the depth either to 0 or to -1.
3101         (WebCore::RenderQuote::detachQuote): Removed code to set m_depth to 0;  if we are not
3102         resetting the text then m_depth should be left matching the text, otherwise updateDepth
3103         might not do its job correctly if the quote is later re-attached. What matters is that
3104         m_depth and the text are in sync.
3105         (WebCore::RenderQuote::updateDepth): Changed updating logic in two ways. First,
3106         compute the depth in a local variable rather than computing it in a data member
3107         after first saving off the old value of the data member. That's clearer style.
3108         Second, add the code to change negative depths to zero when propagating to the
3109         next quote in the chain, which matches how the standard is written, and decrement
3110         the depth of the close quote itself, not the quote after the close quote.
3111
3112 2013-05-08  Eric Carlson  <eric.carlson@apple.com>
3113
3114         Prevent crash when track is deleted during video element deletion.
3115         https://bugs.webkit.org/show_bug.cgi?id=106183
3116
3117         Reviewed by Dean Jackson.
3118
3119         Test: media/track/track-remove-crash.html
3120
3121         * html/HTMLMediaElement.cpp:
3122         (WebCore::HTMLMediaElement::removedFrom): Set m_inActiveDocument to false so we
3123             do not process text track cues or dispatch related events.
3124
3125 2013-05-08  Eric Carlson  <eric.carlson@apple.com>
3126
3127         [Mac] Unreviewed buildfix after r149741.
3128
3129         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
3130         (WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible):
3131
3132 2013-05-08  Eric Carlson  <eric.carlson@apple.com>
3133
3134         [Mac] Inband text tracks are not in track menu on Lion
3135         https://bugs.webkit.org/show_bug.cgi?id=115740
3136
3137         Reviewed by Dean Jackson.
3138
3139         No new tests, covered by existing tests.
3140
3141         * html/HTMLMediaElement.cpp:
3142         (WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_legacyWebKitClosedCaptionsVisible.
3143         (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_closedCaptionsVisible
3144             to false immediately, it will be reset to the appropriate value if necessary.
3145         (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
3146         (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
3147         * html/HTMLMediaElement.h:
3148
3149         * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Remove 
3150             HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) requirement. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
3151             AVFOUNDATION_MEDIA_SELECTION_GROUP
3152         * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Ditto.
3153
3154         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: 
3155         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Ditto.
3156         (WebCore::MediaPlayerPrivateAVFoundation::seek): Ditto.
3157         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
3158         (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
3159         (WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Ditto.
3160         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:  Ditto.
3161
3162         * platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:  Ditto.
3163         * platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
3164         (WebCore::InbandTextTrackPrivateLegacyAVFObjC::kind): Don't look at media characteristics, 
3165             a legacy CC track is always Captions.
3166         (WebCore::InbandTextTrackPrivateLegacyAVFObjC::isClosedCaptions): Ditto.
3167         (WebCore::InbandTextTrackPrivateLegacyAVFObjC::containsOnlyForcedSubtitles): Ditto.
3168         (WebCore::InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent): Ditto.
3169         (WebCore::InbandTextTrackPrivateLegacyAVFObjC::isEasyToRead): Ditto.
3170         (WebCore::InbandTextTrackPrivateLegacyAVFObjC::label): Use different AVFoundation API on 10.7.
3171         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
3172
3173         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
3174         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): AVFOUNDATION_TEXT_TRACK_SUPPORT ->
3175             AVFOUNDATION_MEDIA_SELECTION_GROUP.
3176         (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
3177         (WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
3178             AVFOUNDATION_MEDIA_SELECTION_GROUP.
3179         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Support legacy CC tracks
3180             only on 10.8. AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP
3181         (WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Ditto.
3182         (WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
3183         (WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): AVFOUNDATION_TEXT_TRACK_SUPPORT -> 
3184             AVFOUNDATION_MEDIA_SELECTION_GROUP
3185
3186 2013-05-08  Sergio Villar Senin  <svillar@igalia.com>
3187
3188         Allow blank spaces before colon (:) on CSS variable definition
3189         https://bugs.webkit.org/show_bug.cgi?id=115802
3190
3191         Reviewed by Darin Adler.
3192
3193         Test: css3/css-variable-definition.html
3194
3195         Modified the grammar to allow blank spaces before the colon on CSS
3196         variable definitions.
3197
3198         * css/CSSGrammar.y.in:
3199
3200 2013-05-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3201
3202         [GStreamer] Does memory buffering even with preload set to none
3203         https://bugs.webkit.org/show_bug.cgi?id=115754
3204
3205         Reviewed by Philippe Normand.
3206
3207         Covered by existing tests.
3208
3209         Revision 148840 fixed on-disk buffering being done when preload is set to none,
3210         but memory buffering is still being done. That is because setting the state to
3211         paused causes GStreamer to start loading the media, to gather information. Only
3212         doing that when committing the load avoids that while maintaining the tested
3213         behaviour unchanged.
3214
3215         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3216         (WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
3217         (WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.
3218
3219 2013-05-08  Andreas Kling  <akling@apple.com>
3220
3221         SVGStyledElement::getPresentationAttribute() does not need to be virtual.
3222
3223         From Blink r149888 by <cevans@chromium.org>
3224         <http://src.chromium.org/viewvc/blink?view=revision&revision=149888>
3225
3226         * svg/SVGStyledElement.h:
3227
3228 2013-05-08  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3229
3230         Crash when loading link to audio file
3231         https://bugs.webkit.org/show_bug.cgi?id=115794
3232
3233         Reviewed by Jocelyn Turcotte.
3234
3235         Do not access a null pointer frame.
3236
3237         * loader/appcache/ApplicationCacheHost.cpp:
3238         (WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
3239
3240 2013-05-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3241
3242         Remove unused [TransferList] extended attribute
3243         https://bugs.webkit.org/show_bug.cgi?id=115788
3244
3245         Reviewed by Kentaro Hara.
3246
3247         Remove [TransferList] extended attribute and corresponding tests as it has no
3248         effect on the generated JSC bindings.
3249
3250         No new tests, no behavior change.
3251
3252         * bindings/scripts/IDLAttributes.txt:
3253         * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
3254         * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
3255         (WebDOMTestSerializedScriptValueInterface):
3256         * bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
3257         * bindings/scripts/test/CPP/WebDOMTestTypedefs.h:
3258         (WebDOMTestTypedefs):
3259         * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
3260         * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
3261         * bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
3262         * bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
3263         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
3264         (WebCore):
3265         (WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
3266         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
3267         (JSTestSerializedScriptValueInterfacePrototype):
3268         (JSTestSerializedScriptValueInterfaceConstructor):
3269         * bindings/scripts/test/JS/JSTestTypedefs.cpp:
3270         (WebCore):
3271         * bindings/scripts/test/JS/JSTestTypedefs.h:
3272         (WebCore):
3273         * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
3274         * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
3275         * bindings/scripts/test/ObjC/DOMTestTypedefs.h:
3276         * bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
3277         * bindings/scripts/test/TestSerializedScriptValueInterface.idl:
3278         * bindings/scripts/test/TestTypedefs.idl:
3279
3280 2013-05-08  Dongseong Hwang  <dongseong.hwang@intel.com>
3281
3282         Make optional arguments in CanvasRenderingContext2D match the spec.
3283         https://bugs.webkit.org/show_bug.cgi?id=115723
3284
3285         Reviewed by Dean Jackson.
3286
3287         WebKit r98985 set many arguments optional although the canvas spec[1] does not
3288         indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec.
3289
3290         [1] http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/
3291
3292         Covered by existing tests:
3293           canvas/philip/tests/2d.missingargs.html
3294           fast/canvas/canvas-overloads-strokeRect.html
3295           inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
3296
3297         * html/canvas/CanvasRenderingContext2D.idl:
3298
3299 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
3300
3301         Remove unused method and de-virtualize others in Element.h
3302         https://bugs.webkit.org/show_bug.cgi?id=115770
3303
3304         Reviewed by Andreas Kling.
3305
3306         Merge https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49
3307
3308         The de-virtualization possibilities were noted whilst "FINALizing" the Node
3309         hierarchy. If a method is successfully marked FINAL but then fails when marked
3310         OVERRIDE as well, the method by definition does not need to be virtual.
3311
3312         * WebCore.exp.in:
3313         * dom/Element.h:
3314         (WebCore::Element::hasAuthorShadowRoot):
3315
3316 2013-05-06  Darin Adler  <darin@apple.com>
3317
3318         Use adoptCF and adoptNS in more places
3319         https://bugs.webkit.org/show_bug.cgi?id=115657
3320
3321         Reviewed by Sam Weinig.
3322
3323         This is similar to my last set of changes, but covers code that I missed with
3324         global replace using the Safari Xcode workspace.
3325
3326         * platform/cf/win/CertificateCFWin.cpp:
3327         (WebCore::copyCertificateToData):
3328         * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
3329         (WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
3330         (WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
3331         (WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
3332         (WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
3333         (WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
3334         (WebCore::mimeTypeCache):
3335         (WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
3336         (WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
3337         (WebCore::AVFWrapper::createAssetForURL):
3338         (WebCore::AVFWrapper::createPlayer):
3339         (WebCore::AVFWrapper::createPlayerItem):
3340         (WebCore::AVFWrapper::setAsset):
3341         (WebCore::AVFWrapper::platformLayer):
3342         (WebCore::AVFWrapper::createAVCFVideoLayer):
3343         (WebCore::AVFWrapper::createImageGenerator):
3344         * platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
3345         (WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):
3346         * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
3347         (toCACFTimingFunction):
3348         (PlatformCAAnimation::PlatformCAAnimation):
3349         (PlatformCAAnimation::setFromValue):
3350         (PlatformCAAnimation::setToValue):
3351         (PlatformCAAnimation::setValues):
3352         (PlatformCAAnimation::setKeyTimes):
3353         (PlatformCAAnimation::setTimingFunctions):
3354         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
3355         (PlatformCALayer::PlatformCALayer):
3356         (PlatformCALayer::setBackgroundColor):
3357         (PlatformCALayer::setBorderColor):
3358         * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
3359         (PlatformCALayerWinInternal::PlatformCALayerWinInternal):
3360         (PlatformCALayerWinInternal::addTile):
3361         * platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
3362         (WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost):
3363         * platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
3364         (PlatformVideoWindow::PlatformVideoWindow):
3365         * platform/graphics/win/FontCustomPlatformData.cpp:
3366         (WebCore::FontCustomPlatformData::fontPlatformData):
3367         * platform/graphics/win/FontPlatformDataCGWin.cpp:
3368         (WebCore::getPostScriptName):
3369         (WebCore::FontPlatformData::platformDataInit):
3370         * platform/graphics/win/GraphicsContextCGWin.cpp:
3371         (WebCore::GraphicsContext::drawWindowsBitmap):
3372         * platform/graphics/win/ImageCGWin.cpp:
3373         (WebCore::BitmapImage::create):
3374         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
3375         (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
3376         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3377         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::rfc2616DateStringFromTime):
3378         (WebCore::QTCFDictionaryCreateWithDataCallback):
3379         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
3380         * platform/graphics/win/WKCAImageQueue.cpp:
3381         (WebCore::WKCAImageQueue::WKCAImageQueue):
3382         * platform/image-decoders/ImageDecoder.h:
3383         (WebCore::ImageDecoder::qcmsOutputDeviceProfile):
3384         * platform/network/cf/AuthenticationCF.cpp:
3385         (WebCore::core):
3386         * platform/network/cf/CookieJarCFNet.cpp:
3387         (WebCore::cookieDomain):
3388         (WebCore::cookieName):
3389         (WebCore::cookiePath):
3390         (WebCore::cookieValue):
3391         (WebCore::filterCookies):
3392         (WebCore::setCookiesFromDOM):
3393         (WebCore::cookiesForDOM):
3394         (WebCore::cookieRequestHeaderFieldValue):
3395         (WebCore::getRawCookies):
3396         (WebCore::deleteCookie):
3397         (WebCore::getHostnamesWithCookies):
3398         (WebCore::deleteCookiesForHostname):
3399         * platform/network/curl/ResourceHandleManager.cpp:
3400         (WebCore::certificatePath):
3401         * platform/win/ClipboardUtilitiesWin.cpp:
3402         (WebCore::urlFromPath):
3403         (WebCore::getURL):
3404         * platform/win/LocalizedStringsWin.cpp:
3405         (WebCore::createWebKitBundle):
3406         (WebCore::localizedString):
3407         * platform/win/SearchPopupMenuWin.cpp:
3408         (WebCore::SearchPopupMenuWin::saveRecentSearches):
3409         (WebCore::SearchPopupMenuWin::loadRecentSearches):
3410         * plugins/mac/PluginPackageMac.cpp:
3411         (WebCore::stringListFromResourceId):
3412         (WebCore::PluginPackage::fetchInfo):
3413         (WebCore::PluginPackage::load):
3414         * plugins/mac/PluginViewMac.mm:
3415         (WebCore::PluginView::platformStart):
3416         * rendering/RenderThemeSafari.cpp:
3417         (WebCore::RenderThemeSafari::platformFocusRingColor):
3418         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
3419         (WebCore::RenderThemeSafari::paintSliderTrack):
3420         Use adoptCF and adoptNS throughout.
3421
3422 2013-05-07  Benjamin Poulain  <bpoulain@apple.com>
3423
3424         Make CanvasStyle's CMYKAValues allocated on the heap and move the pointer in the union.
3425         https://bugs.webkit.org/show_bug.cgi?id=115764
3426
3427         Reviewed by Andreas Kling.
3428
3429         CMYKA input is uncommon enough that we should not pay the price for
3430         every CanvasStyle.
3431         Make those values heap allocated and put the pointer in the union. Since
3432         the RGBA32 values are needed for CMYKA, a RGBA32 value is added to the structure.
3433
3434         * html/canvas/CanvasStyle.cpp:
3435         (WebCore::CanvasStyle::CanvasStyle):
3436         (WebCore::CanvasStyle::~CanvasStyle):
3437         (WebCore::CanvasStyle::isEquivalentColor):
3438         (WebCore::CanvasStyle::isEquivalentCMYKA):
3439         (WebCore::CanvasStyle::applyStrokeColor):
3440         (WebCore::CanvasStyle::applyFillColor):
3441         * html/canvas/CanvasStyle.h:
3442         (CanvasStyle):
3443         (CMYKAValues):
3444         (WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
3445         (WebCore::CanvasStyle::color):
3446         (WebCore):
3447
3448 2013-05-07  Darin Adler  <darin@apple.com>
3449
3450         Use OwnPtr instead of deleteAllValues for requests in PluginView
3451         https://bugs.webkit.org/show_bug.cgi?id=115731
3452
3453         Reviewed by Sam Weinig.
3454
3455         * plugins/PluginView.cpp:
3456         (WebCore::PluginView::~PluginView): Removed the call to deleteAllValues.
3457         (WebCore::PluginView::requestTimerFired): Use release to remove an OwnPtr
3458         from m_requests rather than an explicit delete. Also use !isEmpty instead
3459         of size > 0.
3460         (WebCore::PluginView::scheduleRequest): Changed argument type to PassOwnPtr.
3461         (WebCore::PluginView::load): Use adoptPtr to call scheduleRequest.
3462
3463         * plugins/PluginView.h: Changed argument type of scheduleRequest to