<http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs ...
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-03-15  David Kilzer  <ddkilzer@apple.com>
2
3         <http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++
4
5         Reviewed by Simon Fraser.
6
7         Typedef-ing Objective-C classes as void* for pure C++ makes it
8         easier for bugs to creep in because compilers can't do any type
9         checking for void pointers.
10
11         * platform/graphics/GraphicsContext3D.h: Changed typedef
12         declarations for CALayer and WebGLLayer from void* to structs.
13         (WebCore::GraphicsContext3D::platformLayer): Changed
14         static_cast<CALayer*> to reinterpret_cast<CALayer*> now that
15         CALayer and WebGLLayer are not void pointers.
16         * platform/graphics/GraphicsLayer.h: Changed typedef declaration
17         for PlatformLayer from void* to struct CALayer.
18         * platform/graphics/ca/PlatformCAAnimation.h: Changed typedef
19         declaration for CAPropertyAnimation from void* to a struct.
20         Extracted typdef for PlatformAnimationRef.
21
22 2011-03-15  Ilya Sherman  <isherman@chromium.org>
23
24         Reviewed by Tony Chang.
25
26         Autofilled form elements are assigned fixed background color but not text color
27         https://bugs.webkit.org/show_bug.cgi?id=48382
28
29         Test: fast/forms/input-autofilled.html
30
31         * css/html.css:
32         (input:-webkit-autofill): Added foreground color: #000000
33         * css/wml.css:
34         (input:-webkit-autofill): Added foreground color: #000000
35
36 2011-03-15  Alexis Menard  <alexis.menard@openbossa.org>
37
38         Reviewed by Eric Carlson.
39
40         HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "public" state of the element
41         if it's an internal pause for example.
42         https://bugs.webkit.org/show_bug.cgi?id=56374
43
44         In case of an internal pause, the callback from the mediaplayer should be ignored to avoid reflecting the
45         change into the DOM.
46
47         No new tests: Verified manually.
48
49         * html/HTMLMediaElement.cpp:
50         (WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
51
52 2011-03-12  Pavel Podivilov  <podivilov@chromium.org>
53
54         Reviewed by Yury Semikhatsky.
55
56         Web Inspector: re-implement xhr breakpoints.
57         https://bugs.webkit.org/show_bug.cgi?id=56252
58
59         - restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
60         - store xhr breakpoints in a separate setting
61         - move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane
62
63         Test: inspector/debugger/xhr-breakpoints.html
64
65         * inspector/InspectorBrowserDebuggerAgent.cpp:
66         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
67         (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
68         (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
69         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
70         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
71         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
72         (WebCore::InspectorBrowserDebuggerAgent::clear):
73         * inspector/InspectorBrowserDebuggerAgent.h:
74         * inspector/front-end/BreakpointManager.js:
75         (WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
76         (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
77         (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
78         (WebInspector.BreakpointManager.prototype._projectChanged):
79         (WebInspector.BreakpointManager.prototype._validateBreakpoints):
80         (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
81         * inspector/front-end/BreakpointsSidebarPane.js:
82         (WebInspector.XHRBreakpointsSidebarPane):
83         (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
84         (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
85         (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
86         (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
87         (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
88         (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
89         (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
90         (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing):
91         (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
92         (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
93         (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
94         (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
95         (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
96         (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
97         * inspector/front-end/CallStackSidebarPane.js:
98         (WebInspector.CallStackSidebarPane.prototype.update):
99         (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
100         * inspector/front-end/ScriptsPanel.js:
101         (WebInspector.ScriptsPanel):
102         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
103         (WebInspector.ScriptsPanel.prototype._clearInterface):
104         * inspector/front-end/Settings.js:
105         (WebInspector.Settings):
106         * inspector/front-end/inspector.js:
107         (WebInspector.resetFocusElement):
108         (WebInspector.set attached):
109
110 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
111
112         Reviewed by Darin Adler.
113
114         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
115         info into the headers rather than in export symbol definition files, but disable it on 
116         all platforms initially so we can deal with port build issues one port at a time.
117         
118         https://bugs.webkit.org/show_bug.cgi?id=27551
119
120         * config.h:
121         * platform/mac/LoggingMac.mm:
122
123 2011-03-15  Ilya Tikhonovsky  <loislo@chromium.org>
124
125         Unreviewed build fix.
126
127         Chromium: shared lib linux build are failing.
128
129         Two exclude rules for LocalizedNumberNone and TextEncodingDetectorNone were added to the wrong library.
130         It was webcore_remaining instead of webcore_platform.
131
132         * WebCore.gyp/WebCore.gyp:
133
134 2011-03-15  Yury Semikhatsky  <yurys@chromium.org>
135
136         Reviewed by Pavel Feldman.
137
138         Web Inspector: expanding/collapsing object shouldn&apos;t affect outer console.group expansion state
139         https://bugs.webkit.org/show_bug.cgi?id=56373
140
141         * inspector/front-end/Section.js:
142         (WebInspector.Section):
143         (WebInspector.Section.prototype.toggleExpanded):
144         (WebInspector.Section.prototype.handleClick): stop click even propagation if it was handled by this section.
145
146 2011-03-15  Pavel Feldman  <pfeldman@chromium.org>
147
148         Reviewed by Yury Semikhatsky.
149
150         Web Inspector: crash upon "//html//@id" search in elements panel.
151         https://bugs.webkit.org/show_bug.cgi?id=56334
152
153         * inspector/InspectorDOMAgent.cpp:
154         * inspector/front-end/ElementsTreeOutline.js:
155
156 2011-03-15  Andrey Kosyakov  <caseq@chromium.org>
157
158         Reviewed by Yury Semikhatsky.
159
160         Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix)
161         https://bugs.webkit.org/show_bug.cgi?id=56327
162
163         * inspector/front-end/ExtensionAPI.js:
164         (WebInspector.injectedExtensionAPI):
165         * inspector/front-end/ExtensionAPISchema.json:
166
167 2011-03-15  Yury Semikhatsky  <yurys@chromium.org>
168
169         Reviewed by Pavel Feldman.
170
171         Web Inspector: when console.groupEnd calls twice
172         https://bugs.webkit.org/show_bug.cgi?id=56114
173
174         Test: inspector/console/console-nested-group.html
175
176         * inspector/ConsoleMessage.h:
177         (WebCore::ConsoleMessage::type):
178         * inspector/InspectorConsoleAgent.cpp:
179         (WebCore::InspectorConsoleAgent::addConsoleMessage): do not coalesce adjacent EndGroup messages.
180
181 2011-03-15  Chris Mumford  <chris.mumford@palm.com>
182
183         Reviewed by Adam Barth.
184
185         Initializing several member variables that were not initialized in
186         their constructors. These values were all read prior to initialization
187         as reported by Valgrind.
188
189         No new tests: No feature additions/removals.
190
191         * accessibility/AccessibilityImageMapLink.cpp:
192         (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
193         * editing/DeleteSelectionCommand.cpp:
194         (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
195         * html/HTMLCanvasElement.cpp:
196         (WebCore::HTMLCanvasElement::HTMLCanvasElement):
197         * xml/XPathResult.cpp:
198         (WebCore::XPathResult::XPathResult):
199
200 2011-03-15  Ben Taylor  <bentaylor.solx86@gmail.com>
201
202         Reviewed by Adam Barth.
203
204         https://bugs.webkit.org/show_bug.cgi?id=56255
205         Fix build on Solaris 10/Sun Studio 12 C++
206
207         No new tests. This is to fix compilation on Solaris 10 with Sun Studio 12 C++
208
209         * bridge/runtime_array.h:
210         (JSC::RuntimeArray::getConcreteArray):
211
212 2011-03-14  Sam Weinig  <sam@webkit.org>
213
214         Reviewed by Adam Roben
215
216         about:blank fake responses don't get serialized when sent the UIProcess
217         <rdar://problem/9108119>
218         https://bugs.webkit.org/show_bug.cgi?id=56357
219
220         Test: AboutBlankLoad
221
222         * platform/network/cf/ResourceResponse.h:
223         * platform/network/cf/ResourceResponseCFNet.cpp:
224         (WebCore::ResourceResponse::cfURLResponse):
225         Create a CFURLResponseRef if one does not exist yet as we do for
226         NSURLResponses on the mac.
227
228 2011-03-14  Alexis Menard  <alexis.menard@openbossa.org>
229
230         Reviewed by Kenneth Rohde Christiansen.
231
232         [Qt] Seeking videos using the timeline bar does not work properly and stop the video playback.
233         https://bugs.webkit.org/show_bug.cgi?id=56145
234
235         We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough.
236         positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because
237         of a bug in QtMultimedia.
238
239         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
240         (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
241         (WebCore::MediaPlayerPrivateQt::seek):
242         (WebCore::MediaPlayerPrivateQt::stateChanged):
243         (WebCore::MediaPlayerPrivateQt::positionChanged):
244         * platform/graphics/qt/MediaPlayerPrivateQt.h:
245
246 2011-03-14  Alexey Proskuryakov  <ap@apple.com>
247
248         Reviewed by Adam Roben.
249
250         https://bugs.webkit.org/show_bug.cgi?id=44138
251         Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html
252
253         https://bugs.webkit.org/show_bug.cgi?id=55375
254         http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
255
256         https://bugs.webkit.org/show_bug.cgi?id=56185
257         http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
258
259         * platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that
260         a pointer can be passed across threads when wrapped in a RefPtr.
261
262         * platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists
263         when executing a method on main thread by using RefPtr.
264
265 2011-03-14  Sam Weinig  <sam@webkit.org>
266
267         Mac build fix. Part 1 of N.
268
269         * WebCore.exp.in:
270
271 2011-03-14  Joseph Pecoraro  <joepeck@webkit.org>
272
273         Reviewed by Eric Carlson.
274
275         Stalled media elements don't stop delaying the load event
276         https://bugs.webkit.org/show_bug.cgi?id=56316
277
278         We should stop delaying the load event when the load has
279         stalled naturally, or if we require a user gesture to
280         continue the load.
281
282         Test: http/tests/media/video-play-stall-before-meta-data.html
283
284         * html/HTMLMediaElement.cpp:
285         (WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying.
286         (WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying.
287
288 2011-03-13  MORITA Hajime  <morrita@google.com>
289
290         Reviewed by Tony Chang.
291
292         Crash when dragging and dropping in a document with an invalid XHTML header
293         https://bugs.webkit.org/show_bug.cgi?id=48799
294
295         DragController tried to dispatch textInput event even when the
296         drag destination is not the editable area.
297         This change skips the event dispatching on that case.
298         
299         Test: editing/pasteboard/drop-file-svg.html
300
301         * page/DragController.cpp:
302         (WebCore::DragController::dispatchTextInputEventFor):
303         (WebCore::DragController::concludeEditDrag):
304
305 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
306
307         Unreviewed, rolling out r81094.
308         http://trac.webkit.org/changeset/81094
309         https://bugs.webkit.org/show_bug.cgi?id=56355
310
311         Broke the chromium DRT related build. (Requested by dave_levin
312         on #webkit).
313
314         * WebCore.exp.in:
315         * WebCore.order:
316         * page/Frame.cpp:
317         (WebCore::Frame::layerTreeAsText):
318         * page/Frame.h:
319         * rendering/RenderLayerCompositor.cpp:
320         (WebCore::RenderLayerCompositor::layerTreeAsText):
321         * rendering/RenderLayerCompositor.h:
322
323 2011-03-14  Adam Barth  <abarth@webkit.org>
324
325         Apparently we need to exclude DefaultSharedWorkerRepository.cpp from
326         the Chromium build, otherwise the objects visible in the global scope
327         change.
328
329         * WebCore.gyp/WebCore.gyp:
330
331 2011-03-14  Adam Barth  <abarth@webkit.org>
332
333         Attempted Chromium build fix.  Exclude AllInOne harder.
334
335         * WebCore.gyp/WebCore.gyp:
336
337 2011-03-14  Ryosuke Niwa  <rniwa@webkit.org>
338
339         Reviewed by Darin Adler.
340
341         EventHandler calls shouldChangeSelection needlessly
342         https://bugs.webkit.org/show_bug.cgi?id=56324
343
344         Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
345         avoided calling shouldChangeSelection and setSelection when the existing
346         selection is identical to that of new selection.
347
348         * page/EventHandler.cpp:
349         (WebCore::setSelectionIfNeeded): Extracted.
350         (WebCore::setNonDirectionalSelectionIfNeeded): Extracted.
351         (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above.
352         (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
353         (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
354         (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
355         (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.
356         (WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
357
358 2011-03-14  Daniel Sievers  <sievers@google.com>
359
360         Reviewed by Simon Fraser.
361
362         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
363         https://bugs.webkit.org/show_bug.cgi?id=56139
364
365         * WebCore.exp.in:
366         * WebCore.order:
367         * page/Frame.cpp:
368         (WebCore::Frame::layerTreeAsText):
369         * page/Frame.h:
370         * rendering/RenderLayerCompositor.cpp:
371         (WebCore::RenderLayerCompositor::layerTreeAsText):
372         * rendering/RenderLayerCompositor.h:
373
374 2011-03-14  Adam Barth  <abarth@webkit.org>
375
376         Reviewed by Dimitri Glazkov.
377
378         Add remaining files to WebCore.gypi
379         https://bugs.webkit.org/show_bug.cgi?id=56351
380
381         Adding the remaining files to WebCore.gypi required updating the
382         include/exclude lists in WebCore.gyp.  These lists aren't overly
383         elegant, but we can try to improve them in the future.
384
385         * WebCore.gyp/WebCore.gyp:
386         * WebCore.gypi:
387         * bindings/v8/ScriptCachedFrameData.cpp:
388             - Added ifdefs to this file to match the header.
389         * platform/graphics/WOFFFileFormat.cpp:
390             - Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER).
391
392 2011-03-14  Anton Muhin  <antonm@chromium.org>
393
394         Reviewed by Adam Barth.
395
396         [v8] Rework object group building.
397         https://bugs.webkit.org/show_bug.cgi?id=55399
398
399         Instead of going top-down (from owner to owned elements), go up---from objects
400         to their group ids.  That fits better to v8's object grouping model and guarantees
401         that each wrapper belongs to the single group.
402
403         Alas, this cannot be implemented for one kind of objects---CSSProperties.
404
405         Part of core GC algorithm and tested extensively by exisiting layout tests.
406
407         * bindings/scripts/CodeGeneratorV8.pm:
408         * bindings/scripts/test/V8/V8TestInterface.cpp:
409         * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
410         * bindings/scripts/test/V8/V8TestObj.cpp:
411         * bindings/v8/V8GCController.cpp:
412         (WebCore::calculateGroupId):
413         (WebCore::calculateRootStyleSheet):
414         (WebCore::GrouperVisitor::visitDOMWrapper):
415         (WebCore::GrouperVisitor::applyGrouping):
416         (WebCore::V8GCController::gcPrologue):
417         * bindings/v8/WrapperTypeInfo.h:
418         (WebCore::WrapperTypeInfo::isSubclass):
419         * css/CSSRuleList.h:
420         (WebCore::CSSRuleList::styleList):
421         * css/StyleSheetList.h:
422         (WebCore::StyleSheetList::document):
423
424 2011-03-14  Kent Tamura  <tkent@chromium.org>
425
426         Reviewed by James Robinson.
427
428         Assertion failure by form validation message for <select required> with float:left
429         https://bugs.webkit.org/show_bug.cgi?id=55995
430
431         Test: fast/forms/interactive-validation-select-crash.html
432
433         * rendering/RenderBlock.cpp:
434         (WebCore::canMergeContiguousAnonymousBlocks):
435           isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().
436
437 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
438
439         Reviewed by Adam Roben.
440
441         [Qt][WK2]Unbreak InjectedBundle on Qt
442         https://bugs.webkit.org/show_bug.cgi?id=54109
443
444         No code changes so no new tests.
445
446         Revert the changes that were needed to use KURL
447         in WebKitTestRunner.
448
449         * Configurations/WebCore.xcconfig:
450         * WebCore.exp.in:
451
452 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
453
454         Reviewed by Kenneth Rohde Christiansen.
455
456         [Qt] Compilation fails with --3d-canvas 
457         https://bugs.webkit.org/show_bug.cgi?id=55964
458
459         * WebCore.pro:
460         * platform/graphics/qt/Extensions3DQt.cpp:
461
462 2011-03-14  Brian Weinstein  <bweinstein@apple.com>
463
464         Reviewed by Adam Roben and Gavin Barraclough.
465
466         FileSystemWin.cpp needs listDirectory() implementation
467         https://bugs.webkit.org/show_bug.cgi?id=56331
468         <rdar://problem/9126635>
469         
470         Move PathWalker from an inline class in WebKit2 to its own class in WebCore,
471         so it can be used from both WebCore and WebKit2.
472         
473         Implement FileSystemWin::listDirectory using PathWalker to populate the Vector
474         of paths matching the passed in pattern.
475
476         * WebCore.vcproj/WebCore.vcproj:
477         * platform/win/FileSystemWin.cpp:
478         (WebCore::listDirectory): Call through to PathWalker.
479         * platform/win/PathWalker.cpp: Added.
480         (WebCore::PathWalker::PathWalker): Moved from WebKit2. Added a second argument
481             for the pattern to pass to the Windows File APIs.
482         (WebCore::PathWalker::~PathWalker): Moved from WebKit2.
483         (WebCore::PathWalker::isValid): Ditto.
484         (WebCore::PathWalker::data): Ditto.
485         (WebCore::PathWalker::step): Ditto.
486         * platform/win/PathWalker.h: Added.
487
488 2011-03-14  Brady Eidson  <beidson@apple.com>
489
490         Reviewed by Anders Carlsson.
491
492         https://bugs.webkit.org/show_bug.cgi?id=56320
493         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
494
495         Remove HistoryItem::icon():
496         * history/HistoryItem.cpp:
497         * history/HistoryItem.h:
498         * WebCore.exp.in:
499
500         * loader/icon/IconDatabaseBase.h:
501         (WebCore::IconDatabaseBase::defaultIcon):
502
503 2011-03-14  Andy Estes  <aestes@apple.com>
504
505         Reviewed by Darin Adler.
506
507         Timer-based events should inherit the user gesture state of their
508         originating event in certain cases.
509         https://bugs.webkit.org/show_bug.cgi?id=55104
510
511         If a timer is installed by a gesture-originated event and will fire
512         within one second, the timer-initiated event should behave as if it
513         were also initiated by a user gesture. Multi-shot timers should only
514         get this behavior on their first execution. Nested timers should not
515         get this behavior. This makes us compatible with Gecko when handling
516         popups and file chooser dialogs created from timer events.
517
518         Test: fast/events/popup-blocking-timers.html
519
520         * page/DOMTimer.cpp:
521         (WebCore::timeoutId): Create a helper function so that m_timeoutId can
522         be initialized in the data member initialization list.
523         (WebCore::shouldForwardUserGesture): Ditto, but for
524         m_shouldForwardUserGesture.
525         (WebCore::DOMTimer::DOMTimer): Move initialization of data members from
526         the ctor body to the data member initialization list. Also rename the
527         argument 'timeout' to 'interval'.
528         (WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its
529         state based on the value of m_shouldForwardUserGesture.
530         (WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was
531         renamed to m_originalInterval.
532         * page/DOMTimer.h: Add m_shouldForwardUserGesture and rename
533         m_originalTimeout to m_originalInterval.
534
535 2011-03-09  Levi Weintraub  <leviw@chromium.org>
536
537         Reviewed by Ryosuke Niwa.
538
539         Deleting content directly following a button inserts an unnecessary placeholder
540         https://bugs.webkit.org/show_bug.cgi?id=56053
541
542         Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
543         enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
544         DeleteSelectionCommand treating them as blockflow.
545
546         Test: editing/deleting/delete-inserts-br-after-button.html
547
548         * editing/DeleteSelectionCommand.cpp:
549         (WebCore::DeleteSelectionCommand::mergeParagraphs):
550
551 2011-03-14  David Hyatt  <hyatt@apple.com>
552
553         Reviewed by Dan Bernstein.
554
555         https://bugs.webkit.org/show_bug.cgi?id=45164
556
557         REGRESSION: <a><img align=top></a> Clickable area too large
558         
559         Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
560         painting.
561
562         * rendering/InlineFlowBox.cpp:
563         (WebCore::InlineFlowBox::nodeAtPoint):
564
565 2011-03-14  Chris Marrin  <cmarrin@apple.com>
566
567         Reviewed by Adam Roben.
568
569         REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong
570         https://bugs.webkit.org/show_bug.cgi?id=52845
571
572         The lastCommitTime() value in CACFLayerTreeHost was returning as the time
573         the render previous to this one happened. That often made it seem like
574         animations started more in the past than they did, breaking many animations.
575         The startAnimations() call actually fires from a CACF callback after all the
576         WebKit content has been rendered. So sending currentTime as the start time
577         to the animations is close enough for proper synchronization.
578
579         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
580         (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
581
582 2011-03-11  Ryosuke Niwa  <rniwa@webkit.org>
583
584         Reviewed by Tony Chang.
585
586         Selection uses first mousemove's localRect instead of that of mousedown
587         https://bugs.webkit.org/show_bug.cgi?id=56213
588
589         Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
590         using the mouse coordinates of the mousedown event that started the drag.
591
592         Test: editing/selection/drag-select-rapidly.html
593
594         * page/EventHandler.cpp:
595         (WebCore::EventHandler::handleMouseDraggedEvent):
596
597 2011-03-14  Mark Rowe  <mrowe@apple.com>
598
599         Reviewed by Timothy Hatcher.
600
601         Apply a large, blunt object directly to the skull of the Leopard build.
602
603         * Configurations/Base.xcconfig: Disable the generation of debugging symbols when
604         building the Debug configuration on Leopard. This should cut the size of the object
605         files that the linker needs to process by over 85%. This will hopefully allow them
606         to fit in to the 32-bit address space of the Leopard linker.
607
608 2011-03-14  David Hyatt  <hyatt@apple.com>
609
610         Reviewed by Beth Dakin.
611
612         https://bugs.webkit.org/show_bug.cgi?id=56246
613         
614         Add support for relative positioning to table cells.   Back out the code that hacked around the lack of support
615         for offsetLeft, and add new tests to demonstrate that relative positioning works.
616
617         * css/CSSStyleSelector.cpp:
618         (WebCore::CSSStyleSelector::adjustRenderStyle):
619         * rendering/RenderObject.cpp:
620         (WebCore::RenderObject::offsetParent):
621         * rendering/RenderObject.h:
622         (WebCore::RenderObject::isRelPositioned):
623         * rendering/RenderTableCell.h:
624         * rendering/style/RenderStyle.h:
625         * rendering/style/StyleRareNonInheritedData.cpp:
626         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
627         (WebCore::StyleRareNonInheritedData::operator==):
628         * rendering/style/StyleRareNonInheritedData.h:
629
630 2011-03-14  David Hyatt  <hyatt@apple.com>
631
632         Reviewed by Beth Dakin.
633
634         Partial backout of https://bugs.webkit.org/show_bug.cgi?id=56230.  Go back to repainting the root
635         layer, since first layouts and printing mess up otherwise.
636
637         * page/FrameView.cpp:
638         (WebCore::FrameView::layout):
639
640 2011-03-11  David Hyatt  <hyatt@apple.com>
641
642         Reviewed by Simon Fraser.
643
644         Clean up full repainting of layers during layout and at other times.  Platforms that did not do an invalidation on
645         size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate
646         for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed
647         all of the child layers.  This is no longer the case since the overflow changes that tightened up visual overflow
648         and limited that overflow only to content that the layer painted.
649         
650         Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's
651         m_doFullRepaint boolean is set.  This will flush out any ports that aren't just invalidating the world on their
652         own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with
653         the other ports.
654         
655         Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer.
656         I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch),
657         but the behavior should be the same.
658         
659         No new tests, since this is untestable on ports that invalidate on a resize.
660
661         * page/FrameView.cpp:
662         (WebCore::FrameView::layout):
663         * rendering/RenderBoxModelObject.cpp:
664         (WebCore::RenderBoxModelObject::styleDidChange):
665         * rendering/RenderLayer.cpp:
666         (WebCore::RenderLayer::updateLayerPositions):
667         (WebCore::RenderLayer::removeOnlyThisLayer):
668         * rendering/RenderLayer.h:
669
670 2011-03-11  Oliver Hunt  <oliver@apple.com>
671
672         Reviewed by Gavin Barraclough.
673
674         Ensure all values are correctly tagged in the registerfile
675         https://bugs.webkit.org/show_bug.cgi?id=56214
676
677         Make sure everything builds still.
678
679         * bridge/c/c_class.cpp:
680         * bridge/c/c_runtime.cpp:
681         * bridge/jni/JavaMethod.cpp:
682         * plugins/PluginViewNone.cpp:
683
684 2011-03-14  Luiz Agostini  <luiz.agostini@openbossa.org>
685
686         Unreviewed build fix for r81035.
687
688         * html/HTMLDetailsElement.cpp:
689         (WebCore::HTMLDetailsElement::defaultEventHandler):
690         * rendering/RenderDetailsMarker.cpp:
691         (WebCore::createDownArrowPath):
692         (WebCore::createUpArrowPath):
693         (WebCore::createLeftArrowPath):
694         (WebCore::createRightArrowPath):
695
696 2011-03-13  Jer Noble  <jer.noble@apple.com>
697
698         FullScreen: Handle entering full screen security restrictions
699         https://bugs.webkit.org/show_bug.cgi?id=56264
700
701         Tests: fullscreen/full-screen-iframe-allowed.html
702                fullscreen/full-screen-iframe-not-allowed.html
703
704         Disable full screen documents in the following conditions:
705         1) requesting element is in an iframe which does not have a
706         webkitallowfullscreen attribute.
707         2) page is not processing a user gesture.
708
709         * dom/Document.cpp:
710         (WebCore::Document::fullScreenIsAllowedForElement): Added.  Checks
711             to see if elements contained in IFRAMES are allowed to
712             enter full screen.
713         (WebCore::Document::webkitRequestFullScreenForElement): Checks
714             if page is currently processing a user gesture.
715         * dom/Document.h:
716         * html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr.
717         * html/HTMLFrameElementBase.cpp:
718         (WebCore::HTMLFrameElementBase::allowFullScreen): Added.
719         * html/HTMLFrameElementBase.h:
720
721 2011-03-14  Anton D'Auria  <adauria@apple.com>
722
723         Reviewed by David Levin.
724
725         REGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAreaSync::sync
726         https://bugs.webkit.org/show_bug.cgi?id=56303
727
728         Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor.
729
730         * storage/StorageAreaSync.cpp:
731         (WebCore::StorageAreaSync::StorageAreaSync):
732
733 2011-03-14  Steve Block  <steveblock@google.com>
734
735         Reviewed by Oliver Hunt.
736
737         JavaMethod.cpp does not compile with V8
738         https://bugs.webkit.org/show_bug.cgi?id=56306
739
740         Moved the ScopeChain.h include to JavaStringJSC.
741
742         No new tests, build fix only.
743
744         * bridge/jni/JavaMethod.cpp:
745         * bridge/jni/jsc/JavaStringJSC.h
746
747 2011-02-28  Luiz Agostini  <luiz.agostini@openbossa.org>
748
749         Reviewed by Dave Hyatt.
750
751         HTML5 <details> and <summary>: rendering
752         https://bugs.webkit.org/show_bug.cgi?id=51071
753
754         Tests: fast/html/details-add-summary-1-and-click.html
755                fast/html/details-add-summary-1.html
756                fast/html/details-add-summary-10-and-click.html
757                fast/html/details-add-summary-10.html
758                fast/html/details-add-summary-2-and-click.html
759                fast/html/details-add-summary-2.html
760                fast/html/details-add-summary-3-and-click.html
761                fast/html/details-add-summary-3.html
762                fast/html/details-add-summary-4-and-click.html
763                fast/html/details-add-summary-4.html
764                fast/html/details-add-summary-5-and-click.html
765                fast/html/details-add-summary-5.html
766                fast/html/details-add-summary-6-and-click.html
767                fast/html/details-add-summary-6.html
768                fast/html/details-add-summary-7-and-click.html
769                fast/html/details-add-summary-7.html
770                fast/html/details-add-summary-8-and-click.html
771                fast/html/details-add-summary-8.html
772                fast/html/details-add-summary-9-and-click.html
773                fast/html/details-add-summary-9.html
774                fast/html/details-mouse-click.html
775                fast/html/details-no-summary1.html
776                fast/html/details-no-summary2.html
777                fast/html/details-no-summary3.html
778                fast/html/details-no-summary4.html
779                fast/html/details-open-javascript.html
780                fast/html/details-open1.html
781                fast/html/details-open2.html
782                fast/html/details-open3.html
783                fast/html/details-open4.html
784                fast/html/details-open5.html
785                fast/html/details-open6.html
786                fast/html/details-position.html
787                fast/html/details-remove-summary-1-and-click.html
788                fast/html/details-remove-summary-1.html
789                fast/html/details-remove-summary-2-and-click.html
790                fast/html/details-remove-summary-2.html
791                fast/html/details-remove-summary-3-and-click.html
792                fast/html/details-remove-summary-3.html
793                fast/html/details-remove-summary-4-and-click.html
794                fast/html/details-remove-summary-4.html
795                fast/html/details-remove-summary-5-and-click.html
796                fast/html/details-remove-summary-5.html
797                fast/html/details-remove-summary-6-and-click.html
798                fast/html/details-remove-summary-6.html
799                fast/html/details-writing-mode.html
800
801         http://www.w3.org/TR/html5/interactive-elements.html#the-details-element
802
803         The main <summary> element is the first <summary> element of a <details> element.
804         All other childs of the <details> element are rendered only if the attribute 'open' is set.
805         Click event toggles the 'open' attribute.
806
807         * html/HTMLDetailsElement.cpp:
808         (WebCore::HTMLDetailsElement::HTMLDetailsElement):
809         (WebCore::HTMLDetailsElement::findMainSummary):
810         (WebCore::HTMLDetailsElement::childrenChanged):
811         (WebCore::HTMLDetailsElement::finishParsingChildren):
812         (WebCore::HTMLDetailsElement::parseMappedAttribute):
813         (WebCore::HTMLDetailsElement::childShouldCreateRenderer):
814         (WebCore::HTMLDetailsElement::defaultEventHandler):
815         * html/HTMLDetailsElement.h:
816         (WebCore::HTMLDetailsElement::mainSummary):
817
818         Method createRenderer added to class HTMLSummaryElement.
819
820         * html/HTMLSummaryElement.cpp:
821         (WebCore::HTMLSummaryElement::createRenderer):
822         * html/HTMLSummaryElement.h:
823
824         The first <summary> element is positioned at the top of its <details> parent.
825         The area occupied by this main <summary> element is the interactive area of the
826         <details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer
827         is created and added to the corresponding RenderDetails object.
828
829         * rendering/RenderDetails.cpp:
830         (WebCore::RenderDetails::RenderDetails):
831         (WebCore::RenderDetails::destroy):
832         (WebCore::RenderDetails::summaryBlock):
833         (WebCore::RenderDetails::contentBlock):
834         (WebCore::RenderDetails::addChild):
835         (WebCore::RenderDetails::removeChild):
836         (WebCore::RenderDetails::setMarkerStyle):
837         (WebCore::RenderDetails::styleDidChange):
838         (WebCore::RenderDetails::getRenderPosition):
839         (WebCore::RenderDetails::markerDestroyed):
840         (WebCore::RenderDetails::summaryDestroyed):
841         (WebCore::RenderDetails::moveSummaryToContents):
842         (WebCore::RenderDetails::createSummaryStyle):
843         (WebCore::RenderDetails::replaceMainSummary):
844         (WebCore::RenderDetails::createDefaultSummary):
845         (WebCore::RenderDetails::checkMainSummary):
846         (WebCore::RenderDetails::layout):
847         (WebCore::RenderDetails::isOpen):
848         (WebCore::RenderDetails::getParentOfFirstLineBox):
849         (WebCore::RenderDetails::firstNonMarkerChild):
850         (WebCore::RenderDetails::updateMarkerLocation):
851         * rendering/RenderDetails.h:
852         (WebCore::RenderDetails::interactiveArea):
853         (WebCore::RenderDetails::removeLeftoverAnonymousBlock):
854         (WebCore::RenderDetails::createsAnonymousWrapper):
855         (WebCore::RenderDetails::requiresForcedStyleRecalcPropagation):
856
857         A marker is added to the main <summary> element to indicate the current value of the 'open'
858         attribute of the <details> element.
859
860         * rendering/RenderDetailsMarker.cpp:
861         (WebCore::RenderDetailsMarker::RenderDetailsMarker):
862         (WebCore::RenderDetailsMarker::destroy):
863         (WebCore::RenderDetailsMarker::lineHeight):
864         (WebCore::RenderDetailsMarker::baselinePosition):
865         (WebCore::RenderDetailsMarker::computePreferredLogicalWidths):
866         (WebCore::RenderDetailsMarker::layout):
867         (WebCore::RenderDetailsMarker::getRelativeMarkerRect):
868         (WebCore::RenderDetailsMarker::isOpen):
869         (WebCore::createPath):
870         (WebCore::createDownArrowPath):
871         (WebCore::createUpArrowPath):
872         (WebCore::createLeftArrowPath):
873         (WebCore::createRightArrowPath):
874         (WebCore::RenderDetailsMarker::orientation):
875         (WebCore::RenderDetailsMarker::getCanonicalPath):
876         (WebCore::RenderDetailsMarker::getPath):
877         (WebCore::RenderDetailsMarker::paint):
878         * rendering/RenderDetailsMarker.h:
879         (WebCore::toRenderDetailsMarker):
880
881         * rendering/RenderSummary.cpp:
882         (WebCore::RenderSummary::RenderSummary):
883         (WebCore::RenderSummary::destroy):
884         (WebCore::RenderSummary::parentDetails):
885         (WebCore::RenderSummary::styleDidChange):
886         * rendering/RenderSummary.h:
887
888         * rendering/RenderTreeAsText.cpp:
889         (WebCore::RenderTreeAsText::writeRenderObject):
890
891 2011-03-14  Brady Eidson  <beidson@apple.com>
892
893         Reviewed by Sam Weinig.
894
895         https://bugs.webkit.org/show_bug.cgi?id=56296
896         Clean up IconDatabaseBase header.
897
898         -Get rid of the "PlatformString.h" include and replace it with a forward declaration.
899         -Group methods by which are used in WebCore directly and which are used in WebKit ports.
900
901         This'll make it easier to use in external frameworks (like WebKit2).
902
903         * loader/icon/IconDatabase.h:
904         * loader/icon/IconDatabaseBase.h:
905         (WebCore::IconDatabaseBase::retainIconForPageURL):
906         (WebCore::IconDatabaseBase::releaseIconForPageURL):
907         (WebCore::IconDatabaseBase::iconForPageURL):
908         (WebCore::IconDatabaseBase::setIconURLForPageURL):
909         (WebCore::IconDatabaseBase::setIconDataForIconURL):
910         (WebCore::IconDatabaseBase::iconDataKnownForIconURL):
911         (WebCore::IconDatabaseBase::loadDecisionForIconURL):
912         (WebCore::IconDatabaseBase::importIconURLForPageURL):
913         (WebCore::IconDatabaseBase::importIconDataForIconURL):
914         (WebCore::IconDatabaseBase::open):
915
916 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
917
918         Unreviewed, rolling out r81026.
919         http://trac.webkit.org/changeset/81026
920         https://bugs.webkit.org/show_bug.cgi?id=56313
921
922         Breaks gtk 64-bit tests (Requested by podivilov on #webkit).
923
924         * inspector/InspectorBrowserDebuggerAgent.cpp:
925         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
926         (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
927         (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
928         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
929         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
930         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
931         (WebCore::InspectorBrowserDebuggerAgent::clear):
932         * inspector/InspectorBrowserDebuggerAgent.h:
933         * inspector/front-end/BreakpointManager.js:
934         (WebInspector.BreakpointManager.prototype.createXHRBreakpoint):
935         (WebInspector.BreakpointManager.prototype._createXHRBreakpoint):
936         (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
937         (WebInspector.BreakpointManager.prototype._projectChanged):
938         (WebInspector.BreakpointManager.prototype._validateBreakpoints):
939         (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
940         (WebInspector.BreakpointManager.prototype._createXHRBreakpointId):
941         (WebInspector.XHRBreakpoint):
942         (WebInspector.XHRBreakpoint.prototype._enable):
943         (WebInspector.XHRBreakpoint.prototype._disable):
944         (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
945         (WebInspector.XHRBreakpointView):
946         (WebInspector.XHRBreakpointView.prototype.compareTo):
947         (WebInspector.XHRBreakpointView.prototype.populateEditElement):
948         (WebInspector.XHRBreakpointView.prototype.populateLabelElement):
949         (WebInspector.XHRBreakpointView.prototype.populateStatusMessageElement):
950         * inspector/front-end/BreakpointsSidebarPane.js:
951         (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked):
952         (WebInspector.XHRBreakpointsSidebarPane):
953         (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
954         (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
955         (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog):
956         * inspector/front-end/CallStackSidebarPane.js:
957         (WebInspector.CallStackSidebarPane.prototype.update):
958         * inspector/front-end/ScriptsPanel.js:
959         (WebInspector.ScriptsPanel):
960         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
961         (WebInspector.ScriptsPanel.prototype._clearInterface):
962         * inspector/front-end/Settings.js:
963         (WebInspector.Settings):
964         * inspector/front-end/inspector.js:
965         (WebInspector.resetFocusElement):
966         (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded):
967         (WebInspector.createXHRBreakpointsSidebarPane):
968         (WebInspector.set attached):
969
970 2011-03-14  Mikhail Naganov  <mnaganov@chromium.org>
971
972         Reviewed by Pavel Feldman.
973
974         Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
975         https://bugs.webkit.org/show_bug.cgi?id=56312
976
977         Test: inspector/utilities.html
978
979         * inspector/front-end/utilities.js:
980
981 2011-03-12  Pavel Podivilov  <podivilov@chromium.org>
982
983         Reviewed by Yury Semikhatsky.
984
985         Web Inspector: re-implement xhr breakpoints.
986         https://bugs.webkit.org/show_bug.cgi?id=56252
987
988         - restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
989         - store xhr breakpoints in a separate setting
990         - move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane
991
992         Test: inspector/debugger/xhr-breakpoints.html
993
994         * inspector/InspectorBrowserDebuggerAgent.cpp:
995         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
996         (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
997         (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
998         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
999         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
1000         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
1001         (WebCore::InspectorBrowserDebuggerAgent::clear):
1002         * inspector/InspectorBrowserDebuggerAgent.h:
1003         * inspector/front-end/BreakpointManager.js:
1004         (WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
1005         (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
1006         (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
1007         (WebInspector.BreakpointManager.prototype._projectChanged):
1008         (WebInspector.BreakpointManager.prototype._validateBreakpoints):
1009         (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
1010         * inspector/front-end/BreakpointsSidebarPane.js:
1011         (WebInspector.XHRBreakpointsSidebarPane):
1012         (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
1013         (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
1014         (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
1015         (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
1016         (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
1017         (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
1018         (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
1019         (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing):
1020         (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
1021         (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
1022         (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
1023         (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
1024         (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
1025         (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
1026         * inspector/front-end/CallStackSidebarPane.js:
1027         (WebInspector.CallStackSidebarPane.prototype.update):
1028         (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
1029         * inspector/front-end/ScriptsPanel.js:
1030         (WebInspector.ScriptsPanel):
1031         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
1032         (WebInspector.ScriptsPanel.prototype._clearInterface):
1033         * inspector/front-end/Settings.js:
1034         (WebInspector.Settings):
1035         * inspector/front-end/inspector.js:
1036         (WebInspector.resetFocusElement):
1037         (WebInspector.set attached):
1038
1039 2011-03-14  Pavel Podivilov  <podivilov@chromium.org>
1040
1041         Reviewed by Pavel Feldman.
1042
1043         Web Inspector: move breakpoints restoring to debugger presentation model.
1044         https://bugs.webkit.org/show_bug.cgi?id=56123
1045
1046         DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since
1047         setBreakpoint/removeBreakpoint are now called from DPM only.
1048
1049         * inspector/InspectorDebuggerAgent.cpp:
1050         (WebCore::InspectorDebuggerAgent::disable):
1051         (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
1052         * inspector/front-end/DebuggerModel.js:
1053         (WebInspector.DebuggerModel.prototype.enableDebugger):
1054         (WebInspector.DebuggerModel.prototype._debuggerWasEnabled):
1055         (WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
1056         (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
1057         (WebInspector.DebuggerModel.prototype.setBreakpoint):
1058         (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
1059         (WebInspector.DebuggerModel.prototype.removeBreakpoint):
1060         (WebInspector.DebuggerModel.prototype._breakpointResolved):
1061         (WebInspector.DebuggerModel.prototype.reset):
1062         (WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled):
1063         (WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled):
1064         * inspector/front-end/DebuggerPresentationModel.js:
1065         (WebInspector.DebuggerPresentationModel):
1066         (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
1067         (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
1068         (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
1069         (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
1070         (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
1071         (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
1072         (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
1073         (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
1074         (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
1075         (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
1076         (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
1077         (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
1078         (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
1079         (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
1080         (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
1081         (WebInspector.DebuggerPresentationModel.prototype.reset):
1082         * inspector/front-end/ScriptsPanel.js:
1083         (WebInspector.ScriptsPanel):
1084         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1085         (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
1086
1087 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1088
1089         Unreviewed, rolling out r81015.
1090         http://trac.webkit.org/changeset/81015
1091         https://bugs.webkit.org/show_bug.cgi?id=56308
1092
1093         A Similar patch landed in r76960 (Requested by philn-tp on
1094         #webkit).
1095
1096         * GNUmakefile.am:
1097
1098 2011-03-14  Pavel Feldman  <pfeldman@chromium.org>
1099
1100         Reviewed by Yury Semikhatsky.
1101
1102         Web Inspector: don't use innerText, use textContent instead.
1103         https://bugs.webkit.org/show_bug.cgi?id=56307
1104
1105         * inspector/front-end/AuditFormatters.js:
1106         (WebInspector.AuditFormatters.snippet):
1107         * inspector/front-end/ElementsTreeOutline.js:
1108         * inspector/front-end/GoToLineDialog.js:
1109         * inspector/front-end/HelpScreen.js:
1110         (WebInspector.HelpScreen):
1111         * inspector/front-end/ShortcutsHelp.js:
1112         (WebInspector.ShortcutsSection.prototype.renderSection):
1113         (WebInspector.ShortcutsSection.prototype._renderHeader):
1114
1115 2011-03-14  Andrey Adaikin  <aandrey@google.com>
1116
1117         Reviewed by Pavel Feldman.
1118
1119         Web Inspector: [Text editor] Disable live-edit in favor of the text editor
1120         https://bugs.webkit.org/show_bug.cgi?id=56176
1121
1122         * inspector/front-end/Settings.js:
1123
1124 2011-03-14  Andrey Adaikin  <aandrey@google.com>
1125
1126         Reviewed by Pavel Feldman.
1127
1128         Web Inspector: [REGRESSION] scroll does not work in source frame when mouse is inside the gutter
1129         https://bugs.webkit.org/show_bug.cgi?id=56095
1130
1131         * inspector/front-end/TextViewer.js:
1132         (WebInspector.TextViewer):
1133
1134 2011-03-11  Pavel Podivilov  <podivilov@chromium.org>
1135
1136         Reviewed by Pavel Feldman.
1137
1138         Web Inspector: move breakpoints restoring after live edit to debugger presentation model.
1139         https://bugs.webkit.org/show_bug.cgi?id=56179
1140
1141         Presentation model should move breakpoints based on text diff as required by "revert to revision" action in resources panel.
1142
1143         * inspector/front-end/DebuggerModel.js:
1144         (WebInspector.DebuggerModel):
1145         (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
1146         (WebInspector.DebuggerModel.prototype.setBreakpoint):
1147         (WebInspector.DebuggerModel.prototype.reset):
1148         (WebInspector.DebuggerModel.prototype.editScriptSource.didEditScriptSource):
1149         (WebInspector.DebuggerModel.prototype.editScriptSource):
1150         (WebInspector.DebuggerModel.prototype.get callFrames):
1151         (WebInspector.DebuggerModel.prototype._pausedScript):
1152         (WebInspector.DebuggerModel.prototype._resumedScript):
1153         * inspector/front-end/DebuggerPresentationModel.js:
1154         (WebInspector.DebuggerPresentationModel):
1155         (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
1156         * inspector/front-end/ScriptsPanel.js:
1157         (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
1158
1159 2011-03-10  Alexander Pavlov  <apavlov@chromium.org>
1160
1161         Reviewed by Pavel Feldman.
1162
1163         Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
1164         https://bugs.webkit.org/show_bug.cgi?id=56111
1165
1166         This change reduces the getStylesForNode() payload more than twice for BODY elements.
1167
1168         * inspector/InspectorStyleSheet.cpp:
1169         (WebCore::InspectorStyle::populateObjectWithStyleProperties):
1170         * inspector/front-end/CSSStyleModel.js:
1171         (WebInspector.CSSProperty.parsePayload):
1172
1173 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
1174
1175         Reviewed by Steve Block.
1176
1177         Detach Geolocation from Frame when Page destroyed.
1178         https://bugs.webkit.org/show_bug.cgi?id=52877
1179
1180         On Page destruction, any outstanding Geolocation permission
1181         requests should be cancelled, because the Geolocation can only
1182         access the client indirectly via m_frame->page().
1183
1184         Page destruction is signalled by a call to the
1185         Frame::pageDestroyed() method. This explictly calls
1186         DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
1187
1188         Geolocation::reset() detaches from the GeolocationController,
1189         cancels requests, watches and single shots, and sets the
1190         permission state back to Unknown.
1191
1192         Frame::pageDestroyed() is also called by FrameLoader even though
1193         the page is not destroyed. We should still cancel permission
1194         requests, because the GeolocationClient will become inaccessible
1195         to the Geolocation object after this call.
1196
1197         Frame::transferChildFrameToNewDocument also indirectly calls
1198         Geolocation::reset when the frame is reparented between
1199         pages. Ideally we would like the Geolocation's activities to
1200         continue after reparenting, see bug
1201         https://bugs.webkit.org/show_bug.cgi?id=55577
1202
1203         Since GeolocationController is owned by Page, and all Geolocation
1204         objects will now unsubscribe from the GeolocationController on
1205         pageDetached(), we no longer need to call stopUpdating() from the
1206         GeolocationController's destructor. Instead we can simply assert
1207         that there should be no no observers. See related bug
1208         https://bugs.webkit.org/show_bug.cgi?id=52216 .
1209
1210         Introduced new method 'numberOfPendingPermissionRequests' on
1211         GeolocationClientMock to count the number of outstanding pending
1212         permission requests. This provides a reusable implementation for
1213         client-based implementations of the LayoutTestController's
1214         numberOfPendingGeolocationPermissionRequests method.
1215
1216         Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
1217
1218         * page/DOMWindow.cpp:
1219         (WebCore::DOMWindow::resetGeolocation):
1220         * page/DOMWindow.h:
1221         * page/Frame.cpp:
1222         (WebCore::Frame::pageDestroyed):
1223         (WebCore::Frame::transferChildFrameToNewDocument):
1224         * page/Geolocation.cpp:
1225         (WebCore::Geolocation::~Geolocation):
1226         (WebCore::Geolocation::page):
1227         (WebCore::Geolocation::reset):
1228         (WebCore::Geolocation::disconnectFrame):
1229         (WebCore::Geolocation::lastPosition):
1230         (WebCore::Geolocation::requestPermission):
1231         (WebCore::Geolocation::startUpdating):
1232         (WebCore::Geolocation::stopUpdating):
1233         * page/Geolocation.h:
1234         * page/GeolocationController.cpp:
1235         (WebCore::GeolocationController::~GeolocationController):
1236         * page/Navigator.cpp:
1237         (WebCore::Navigator::resetGeolocation):
1238         * page/Navigator.h:
1239         * platform/mock/GeolocationClientMock.cpp:
1240         (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
1241         * platform/mock/GeolocationClientMock.h:
1242
1243 2011-03-14  Andrey Adaikin  <aandrey@google.com>
1244
1245         Reviewed by Pavel Feldman.
1246
1247         Web Inspector: REGRESSION: Messed up with the tabIndex for text editor
1248         https://bugs.webkit.org/show_bug.cgi?id=56183
1249
1250         * inspector/front-end/SourceFrame.js:
1251         (WebInspector.SourceFrame.prototype._handleKeyDown):
1252         (WebInspector.SourceFrame.prototype._handleSave):
1253         (WebInspector.SourceFrame.prototype._handleRevertEditing):
1254         * inspector/front-end/TextViewer.js:
1255         (WebInspector.TextEditorMainPanel):
1256         (WebInspector.TextEditorMainPanel.prototype.set readOnly):
1257
1258 2011-03-14  Chris Rogers  <crogers@google.com>
1259
1260         Reviewed by Xan Lopez.
1261
1262         Add all web audio auto-generated files to GTK make system
1263         https://bugs.webkit.org/show_bug.cgi?id=50497
1264
1265         No new tests since these are build-system tweaks.
1266
1267         * GNUmakefile.am:
1268
1269 2011-03-14  Pavel Feldman  <pfeldman@chromium.org>
1270
1271         Reviewed by Yury Semikhatsky.
1272
1273         Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
1274         https://bugs.webkit.org/show_bug.cgi?id=56268
1275
1276         * inspector/Inspector.idl:
1277         * inspector/InspectorDOMAgent.cpp:
1278         (WebCore::InspectorDOMAgent::reset):
1279         (WebCore::InspectorDOMAgent::performSearch):
1280         (WebCore::InspectorDOMAgent::cancelSearch):
1281         (WebCore::InspectorDOMAgent::onMatchJobsTimer):
1282         (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
1283         * inspector/InspectorDOMAgent.h:
1284         * inspector/front-end/DOMAgent.js:
1285         (WebInspector.DOMAgent.prototype.requestDocument.mycallback):
1286         (WebInspector.DOMAgent.prototype.requestDocument):
1287         (WebInspector.DOMAgent.prototype._attributesUpdated):
1288         (WebInspector.DOMAgent.prototype._characterDataModified):
1289         (WebInspector.DOMAgent.prototype._documentUpdated):
1290         (WebInspector.DOMAgent.prototype._setDocument):
1291         (WebInspector.DOMAgent.prototype._childNodeCountUpdated):
1292         (WebInspector.DOMAgent.prototype._childNodeInserted):
1293         (WebInspector.DOMAgent.prototype._childNodeRemoved):
1294         (WebInspector.DOMAgent.prototype._removeBreakpoints):
1295         (WebInspector.DOMAgent.prototype.performSearch):
1296         (WebInspector.DOMAgent.prototype.cancelSearch):
1297         (WebInspector.DOMDispatcher.prototype.searchResults):
1298         * inspector/front-end/ElementsPanel.js:
1299         (WebInspector.ElementsPanel):
1300         (WebInspector.ElementsPanel.prototype._reset):
1301         (WebInspector.ElementsPanel.prototype._documentUpdated):
1302         (WebInspector.ElementsPanel.prototype.searchCanceled):
1303         (WebInspector.ElementsPanel.prototype.performSearch):
1304         (WebInspector.ElementsPanel.prototype._addNodesToSearchResult):
1305         (WebInspector.ElementsPanel.prototype._attributesUpdated):
1306         (WebInspector.ElementsPanel.prototype._characterDataModified):
1307         (WebInspector.ElementsPanel.prototype._nodeInserted):
1308         (WebInspector.ElementsPanel.prototype._nodeRemoved):
1309         (WebInspector.ElementsPanel.prototype._childNodeCountUpdated):
1310         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
1311
1312 2011-03-14  Pavel Feldman  <pfeldman@chromium.org>
1313
1314         Reviewed by Yury Semikhatsky.
1315
1316         Web Inspector: add tests for edit dom operations.
1317         https://bugs.webkit.org/show_bug.cgi?id=56248
1318
1319         Test: inspector/elements/edit-dom-actions.html
1320
1321         * inspector/Inspector.idl:
1322         * inspector/InspectorDOMAgent.cpp:
1323         (WebCore::InspectorDOMAgent::assertNode):
1324         (WebCore::InspectorDOMAgent::assertElement):
1325         (WebCore::InspectorDOMAgent::assertHTMLElement):
1326         (WebCore::InspectorDOMAgent::nodeToSelectOn):
1327         (WebCore::InspectorDOMAgent::querySelector):
1328         (WebCore::InspectorDOMAgent::querySelectorAll):
1329         (WebCore::InspectorDOMAgent::setAttribute):
1330         (WebCore::InspectorDOMAgent::removeAttribute):
1331         (WebCore::InspectorDOMAgent::getOuterHTML):
1332         (WebCore::InspectorDOMAgent::setOuterHTML):
1333         * inspector/InspectorDOMAgent.h:
1334         * inspector/front-end/DOMAgent.js:
1335         (WebInspector.DOMNode.prototype.setAttribute):
1336         (WebInspector.DOMNode.prototype.removeAttribute):
1337         * inspector/front-end/inspector.js:
1338         (WebInspector.startEditing.defaultFinishHandler):
1339
1340 2011-03-14  Brady Eidson  <beidson@apple.com>
1341
1342         Reviewed by Dan Bernstein.
1343
1344         <rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172
1345         Need WK2 API to view/manage origins with LocalStorage
1346
1347         * storage/StorageTracker.cpp:
1348         (WebCore::StorageTracker::initializeTracker): Make sure the TextEncoding map is initialized on the main thread
1349           before the StorageTracker thread can do it on the background thread.
1350
1351 2011-03-13  Anton D'Auria  <adauria@apple.com>
1352
1353         Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.
1354
1355         Fixed lock-taking order to prevent deadlock, added lock for m_client,
1356         removed premature return in syncImportOriginIdentifiers when tracker
1357         db does not exist because that prevented syncFileSystemAndTrackerDatabase()
1358         from running until next LocalStorage db creation, cleaned up
1359         StorageTracker::scheduleTask() code for readability.
1360         
1361         https://bugs.webkit.org/show_bug.cgi?id=56285
1362         
1363         * storage/StorageTracker.cpp:
1364         (WebCore::StorageTracker::trackerDatabasePath):
1365         (WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
1366         optionally opened (as in the case when it doesn't exist on disk), don't
1367         exit early and call syncFileSystemAndTrackerDatabase(), which will create
1368         a tracker db if localstorage db files are found on disk by calling setOriginDetails.
1369         (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
1370         (WebCore::StorageTracker::setOriginDetails):
1371         (WebCore::StorageTracker::scheduleTask): readability changes.
1372         (WebCore::StorageTracker::syncSetOriginDetails):
1373         (WebCore::StorageTracker::syncDeleteAllOrigins):
1374         (WebCore::StorageTracker::syncDeleteOrigin):
1375         (WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
1376         (WebCore::StorageTracker::setClient):
1377         * storage/StorageTracker.h:
1378
1379 2011-03-13  Anton D'Auria  <adauria@apple.com>
1380
1381         Reviewed and landed by Brady Eidson.
1382
1383         Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
1384         https://bugs.webkit.org/show_bug.cgi?id=56240
1385
1386         This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.
1387
1388         * storage/StorageTracker.cpp:
1389         (WebCore::StorageTracker::origins):
1390         (WebCore::StorageTracker::deleteAllOrigins):
1391         (WebCore::StorageTracker::deleteOrigin):
1392
1393 2011-03-13  Pratik Solanki  <psolanki@apple.com>
1394
1395         Reviewed by Dan Bernstein.
1396
1397         Make adjustMIMETypeIfNecessary use CFNetwork directly
1398         https://bugs.webkit.org/show_bug.cgi?id=55912
1399
1400         Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.
1401
1402         * platform/network/mac/WebCoreURLResponse.mm:
1403         (WebCore::adjustMIMETypeIfNecessary):
1404
1405 2011-03-13  Dan Bernstein  <mitz@apple.com>
1406
1407         Reviewed by Sam Weinig.
1408
1409         Include hyphenation information in text representation of render tree
1410         https://bugs.webkit.org/show_bug.cgi?id=56287
1411
1412         (WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
1413         string.
1414
1415 2011-03-13  David Levin  <levin@chromium.org>
1416
1417         Improve my hasitly added build fix and added a bug https://bugs.webkit.org/show_bug.cgi?id=56288
1418         above addressing this FIXME.
1419
1420         * css/CSSStyleSelector.cpp:
1421         (WebCore::CSSStyleSelector::applyProperty):
1422
1423 2011-03-13  David Levin  <levin@chromium.org>
1424
1425         Build fix adding remaining enum values to switch statement.
1426
1427         * css/CSSStyleSelector.cpp:
1428         (WebCore::CSSStyleSelector::applyProperty):
1429
1430 2011-03-13  Sam Weinig  <sam@webkit.org>
1431
1432         Fix windows build.
1433
1434         * platform/network/cf/ResourceErrorCF.cpp:
1435         (WebCore::ResourceError::ResourceError):
1436         Add missing constructor.
1437
1438 2011-03-13  David Sosby  <dsosby@rim.com>
1439
1440         Reviewed by Dan Bernstein.
1441
1442         REGRESSION: Soft hyphen is not always rendered
1443         https://bugs.webkit.org/show_bug.cgi?id=56017
1444         
1445         The check to flag a text block as hyphenated was only
1446         occurring at break points in the line. If no break points
1447         were found after the soft hyphen then the line would not
1448         be flagged hyphenated. Adding a check for soft hyphen at
1449         the end of the text run resolves the issue.
1450
1451         Test: fast/text/soft-hyphen-4.html
1452
1453         * rendering/RenderBlockLineLayout.cpp:
1454         (WebCore::RenderBlock::findNextLineBreak):
1455
1456 2011-03-13  Dan Bernstein  <mitz@apple.com>
1457
1458         Reviewed by Mark Rowe.
1459
1460         REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
1461         https://bugs.webkit.org/show_bug.cgi?id=56280
1462
1463         * rendering/RenderBlockLineLayout.cpp:
1464         (WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.
1465
1466 2011-03-13  Sam Weinig  <sam@webkit.org>
1467
1468         Reviewed by Anders Carlsson.
1469
1470         Add ability to create a WKErrorRef
1471         <rdar://problem/9115768>
1472         https://bugs.webkit.org/show_bug.cgi?id=56279
1473
1474         * WebCore.exp.in:
1475         Add new exports.
1476
1477         * platform/network/cf/ResourceError.h:
1478         * platform/network/cf/ResourceErrorCF.cpp:
1479         (WebCore::ResourceError::platformCompare):
1480         (WebCore::ResourceError::cfError):
1481         (WebCore::ResourceError::operator CFErrorRef):
1482         (WebCore::ResourceError::ResourceError):
1483         (WebCore::ResourceError::cfStreamError):
1484         (WebCore::ResourceError::operator CFStreamError):
1485         * platform/network/mac/ResourceErrorMac.mm:
1486         (WebCore::ResourceError::ResourceError):
1487         (WebCore::ResourceError::platformCompare):
1488         (WebCore::ResourceError::nsError):
1489         (WebCore::ResourceError::operator NSError *):
1490         (WebCore::ResourceError::cfError):
1491         (WebCore::ResourceError::operator CFErrorRef):
1492         Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
1493         regardless of whether CFNetwork is being used.
1494
1495 2011-03-13  Pratik Solanki  <psolanki@apple.com>
1496
1497         Reviewed by Brady Eidson.
1498
1499         Make adjustMIMETypeIfNecessary use CFNetwork directly
1500         https://bugs.webkit.org/show_bug.cgi?id=55912
1501
1502         Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
1503         WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
1504         identical.
1505
1506         Testing is covered by existing LayoutTests.
1507
1508         * WebCore.exp.in:
1509         * platform/mac/WebCoreSystemInterface.h:
1510         * platform/mac/WebCoreSystemInterface.mm:
1511         * platform/network/mac/ResourceHandleMac.mm:
1512         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
1513         * platform/network/mac/WebCoreURLResponse.h:
1514         * platform/network/mac/WebCoreURLResponse.mm:
1515         (WebCore::createBinaryExtensionsSet):
1516         (WebCore::createExtensionToMIMETypeMap):
1517         (WebCore::mimeTypeFromUTITree):
1518         (WebCore::adjustMIMETypeIfNecessary):
1519
1520 2011-03-13  Jeremy Moskovich  <jeremy@chromium.org>
1521
1522         Reviewed by Dimitri Glazkov.
1523
1524         Update comment in CSSValueKeywords.in
1525         https://bugs.webkit.org/show_bug.cgi?id=56266
1526
1527         The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
1528         in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.
1529
1530         No tests - just updating a comment.
1531
1532         * css/CSSValueKeywords.in:
1533
1534 2011-03-13  Anton D'Auria  <adauria@apple.com>
1535
1536         Reviewed by Alice Liu.
1537
1538         StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
1539         https://bugs.webkit.org/show_bug.cgi?id=56259
1540
1541         Move all StorageTracker initialization to
1542         StorageTracker::initializeTracker. This also removes the
1543         requirement that the StorageTracker constructor isn't run
1544         on the main thread.
1545
1546         * storage/StorageTracker.cpp:
1547         (WebCore::StorageTracker::initializeTracker):
1548         (WebCore::StorageTracker::tracker):
1549         (WebCore::StorageTracker::StorageTracker):
1550
1551 2011-03-13  Rob Buis  <rwlbuis@gmail.com>
1552
1553         Reviewed by Dave Hyatt.
1554
1555         REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
1556         https://bugs.webkit.org/show_bug.cgi?id=53470
1557
1558         Prefer !important over normal properties when dealing with duplicate properties in style rules.
1559
1560         Test: fast/css/duplicate-property-in-rule-important.html
1561
1562         * css/CSSMutableStyleDeclaration.cpp:
1563         (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
1564
1565 2011-03-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1566
1567         Unreviewed, rolling out r80895.
1568         http://trac.webkit.org/changeset/80895
1569         https://bugs.webkit.org/show_bug.cgi?id=56261
1570
1571         Causing crashes in several tests including
1572         t1202-counters-16-c.html (see
1573         http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
1574         (Requested by dave_levin on #webkit).
1575
1576         * rendering/CounterNode.cpp:
1577         (WebCore::CounterNode::CounterNode):
1578         (WebCore::CounterNode::create):
1579         (WebCore::CounterNode::resetRenderer):
1580         (WebCore::CounterNode::resetRenderers):
1581         (WebCore::CounterNode::recount):
1582         (WebCore::CounterNode::insertAfter):
1583         (WebCore::CounterNode::removeChild):
1584         (WebCore::showTreeAndMark):
1585         * rendering/CounterNode.h:
1586         (WebCore::CounterNode::renderer):
1587         * rendering/RenderCounter.cpp:
1588         (WebCore::findPlaceForCounter):
1589         (WebCore::RenderCounter::~RenderCounter):
1590         (WebCore::RenderCounter::originalText):
1591         (WebCore::RenderCounter::invalidate):
1592         (WebCore::destroyCounterNodeWithoutMapRemoval):
1593         (WebCore::RenderCounter::destroyCounterNodes):
1594         (WebCore::RenderCounter::destroyCounterNode):
1595         (WebCore::updateCounters):
1596         (showCounterRendererTree):
1597         * rendering/RenderCounter.h:
1598         * rendering/RenderObjectChildList.cpp:
1599         (WebCore::invalidateCountersInContainer):
1600         (WebCore::RenderObjectChildList::invalidateCounters):
1601         * rendering/RenderObjectChildList.h:
1602
1603 2011-03-12  Darin Adler  <darin@apple.com>
1604
1605         Reviewed by Dan Bernstein.
1606
1607         REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
1608         https://bugs.webkit.org/show_bug.cgi?id=56258
1609
1610         No tests because the wrong hashing is mostly harmless. The only symptom
1611         we have seen is an occasional assertion in debug builds about the size
1612         not being a multiple of two. But a worse hash is worse for performance too.
1613
1614         * platform/cf/BinaryPropertyList.cpp:
1615         (WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather
1616         than the number of array entries.
1617
1618 2011-03-12  Cameron Zwarich  <zwarich@apple.com>
1619
1620         Not reviewed.
1621
1622         Fix the build with newer GCCs and remove some extra whitespae.
1623
1624         * bindings/js/SerializedScriptValue.cpp:
1625         (WebCore::uint8_t):
1626
1627 2011-03-12  Cameron Zwarich  <zwarich@apple.com>
1628
1629         Rubber-stamped by Oliver Hunt.
1630
1631         Removed unused ARMv5 code. The ARMv5 case now falls under the general
1632         unaligned accessed case.
1633
1634         * bindings/js/SerializedScriptValue.cpp:
1635         (WebCore::CloneDeserializer::readLittleEndian):
1636         (WebCore::CloneDeserializer::readString):
1637
1638 2011-03-12  Cameron Zwarich  <zwarich@apple.com>
1639
1640         Reviewed by Oliver Hunt.
1641
1642         WebCore fails to build with Clang on ARM
1643         https://bugs.webkit.org/show_bug.cgi?id=56257
1644
1645         Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
1646         namespace scope, since explicit specializations are not allowed at class scope.
1647
1648         * bindings/js/SerializedScriptValue.cpp:
1649         (WebCore::writeLittleEndian):
1650
1651 2011-03-11  Darin Adler  <darin@apple.com>
1652
1653         Reviewed by Sam Weinig.
1654
1655         Dragging image to desktop gives webloc instead of image file in WebKit2
1656         https://bugs.webkit.org/show_bug.cgi?id=56193
1657
1658         * WebCore.exp.in: Added some additional exports. Re-sorted.
1659
1660 2011-03-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1661
1662         Unreviewed, rolling out r80919.
1663         http://trac.webkit.org/changeset/80919
1664         https://bugs.webkit.org/show_bug.cgi?id=56251
1665
1666         all windows bots failed to compile this change (Requested by
1667         loislo on #webkit).
1668
1669         * bridge/c/c_class.cpp:
1670         * bridge/c/c_runtime.cpp:
1671         * bridge/jni/JavaMethod.cpp:
1672         * plugins/PluginViewNone.cpp:
1673
1674 2011-03-12  Patrick Gansterer  <paroga@webkit.org>
1675
1676         Unreviewed WinCE build fix for r80900.
1677
1678         * CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.
1679
1680 2011-03-12  Andras Becsi  <abecsi@webkit.org>
1681
1682         Unreviewed typo fix.
1683
1684         No new tests needed.
1685
1686         * WebCore.pro: Fix typo in header name.
1687
1688 2011-03-12  Pavel Feldman  <pfeldman@chromium.org>
1689
1690         Not reviewed: Inspect Element action regression fix.
1691
1692         * inspector/front-end/inspector.js:
1693         (WebInspector.inspect):
1694
1695 2011-03-12  Ilya Tikhonovsky  <loislo@chromium.org>
1696
1697         Unreviewed. One line fix for inspector/dom-breakpoints.html
1698
1699         * inspector/front-end/BreakpointManager.js:
1700         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
1701
1702 2011-03-12  Ilya Tikhonovsky  <loislo@chromium.org>
1703
1704         Unreviewed build fix.
1705
1706         Almost all inspector tests are crashing after r80928.
1707
1708         * inspector/front-end/inspector.js:
1709
1710 2011-03-11  Pavel Feldman  <pfeldman@chromium.org>
1711
1712         Reviewed by Yury Semikhatsky.
1713
1714         Web Inspector: follow up to error reporting, fixing multiple regressions.
1715         https://bugs.webkit.org/show_bug.cgi?id=56243
1716
1717         * inspector/InjectedScript.cpp:
1718         (WebCore::InjectedScript::setPropertyValue):
1719         * inspector/InjectedScript.h:
1720         * inspector/Inspector.idl:
1721         * inspector/InspectorDOMAgent.cpp:
1722         (WebCore::InspectorDOMAgent::getChildNodes):
1723         (WebCore::InspectorDOMAgent::getOuterHTML):
1724         (WebCore::InspectorDOMAgent::getEventListenersForNode):
1725         * inspector/InspectorDOMAgent.h:
1726         * inspector/InspectorRuntimeAgent.cpp:
1727         (WebCore::InspectorRuntimeAgent::setPropertyValue):
1728         * inspector/InspectorRuntimeAgent.h:
1729         * inspector/front-end/DOMAgent.js:
1730         (WebInspector.DOMNode.prototype.setNodeName):
1731         (WebInspector.DOMNode.prototype.setNodeValue):
1732         (WebInspector.DOMNode.prototype.getChildNodes):
1733         (WebInspector.DOMNode.prototype.getOuterHTML):
1734         (WebInspector.DOMNode.prototype.setOuterHTML):
1735         (WebInspector.DOMNode.prototype.removeNode):
1736         (WebInspector.DOMNode.prototype.copyNode):
1737         (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
1738         (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
1739         (WebInspector.EventListeners.getEventListenersForNode):
1740         * inspector/front-end/DOMStorage.js:
1741         (WebInspector.DOMStorage.prototype.getEntries):
1742         (WebInspector.DOMStorage.prototype.setItem):
1743         (WebInspector.DOMStorage.prototype.removeItem):
1744         * inspector/front-end/DOMStorageItemsView.js:
1745         (WebInspector.DOMStorageItemsView.prototype.update):
1746         (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
1747         * inspector/front-end/ElementsTreeOutline.js:
1748         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
1749         (WebInspector.ElementsTreeElement.prototype.updateChildren):
1750         ():
1751         * inspector/front-end/EventListenersSidebarPane.js:
1752         (WebInspector.EventListenersSidebarPane.prototype.update.callback):
1753         (WebInspector.EventListenersSidebarPane.prototype.update):
1754         * inspector/front-end/ObjectPropertiesSection.js:
1755         (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback):
1756         (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
1757         * inspector/front-end/PropertiesSidebarPane.js:
1758         (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
1759         * inspector/front-end/RemoteObject.js:
1760         (WebInspector.RemoteObject.prototype.setPropertyValue):
1761         (WebInspector.RemoteObject.prototype.evaluate):
1762         * inspector/front-end/inspector.js:
1763
1764 2011-03-12  Jer Noble  <jer.noble@apple.com>
1765
1766         Unreviewed build fix.
1767
1768         Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
1769         checks.
1770
1771         * dom/Document.cpp:
1772         (WebCore::Document::webkitWillEnterFullScreenForElement):
1773         (WebCore::Document::webkitDidEnterFullScreenForElement):
1774         (WebCore::Document::webkitWillExitFullScreenForElement):
1775         (WebCore::Document::webkitDidExitFullScreenForElement):
1776
1777 2011-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1778
1779         Unreviewed build fix.
1780
1781         [EFL] Fix build break because of several reason.
1782         https://bugs.webkit.org/show_bug.cgi?id=56244
1783
1784         * CMakeLists.txt: Add missing files.
1785         * platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).
1786
1787 2011-03-11  Yury Semikhatsky  <yurys@chromium.org>
1788
1789         Reviewed by Pavel Feldman.
1790
1791         Web Inspector: move profiler related methods from inspector agent to profiler agent
1792         https://bugs.webkit.org/show_bug.cgi?id=56204
1793
1794         * inspector/Inspector.idl:
1795         * inspector/InspectorAgent.cpp:
1796         (WebCore::InspectorAgent::InspectorAgent):
1797         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
1798         (WebCore::InspectorAgent::setFrontend):
1799         (WebCore::InspectorAgent::disconnectFrontend):
1800         (WebCore::InspectorAgent::populateScriptObjects):
1801         (WebCore::InspectorAgent::showProfilesPanel):
1802         * inspector/InspectorAgent.h:
1803         * inspector/InspectorController.cpp:
1804         (WebCore::InspectorController::enableProfiler):
1805         (WebCore::InspectorController::disableProfiler):
1806         (WebCore::InspectorController::profilerEnabled):
1807         (WebCore::InspectorController::startUserInitiatedProfiling):
1808         (WebCore::InspectorController::stopUserInitiatedProfiling):
1809         (WebCore::InspectorController::isRecordingUserInitiatedProfile):
1810         * inspector/InspectorInstrumentation.cpp:
1811         (WebCore::InspectorInstrumentation::profilerEnabledImpl):
1812         * inspector/InspectorProfilerAgent.cpp:
1813         (WebCore::InspectorProfilerAgent::create):
1814         (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
1815         (WebCore::InspectorProfilerAgent::enable):
1816         (WebCore::InspectorProfilerAgent::disable):
1817         (WebCore::InspectorProfilerAgent::setFrontend):
1818         (WebCore::InspectorProfilerAgent::clearFrontend):
1819         (WebCore::InspectorProfilerAgent::restore):
1820         (WebCore::InspectorProfilerAgent::restoreEnablement):
1821         (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
1822         (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
1823         * inspector/InspectorProfilerAgent.h:
1824         (WebCore::InspectorProfilerAgent::start):
1825         (WebCore::InspectorProfilerAgent::stop):
1826         * inspector/front-end/ProfileView.js:
1827         (WebInspector.CPUProfileType.prototype.buttonClicked):
1828         * inspector/front-end/ProfilesPanel.js:
1829         (WebInspector.ProfilesPanel):
1830         (WebInspector.ProfilesPanel.prototype._registerProfileType):
1831         (WebInspector.ProfilesPanel.prototype._toggleProfiling):
1832         * inspector/front-end/inspector.js:
1833         (WebInspector._createPanels):
1834
1835 2011-03-11  Jer Noble  <jer.noble@apple.com>
1836
1837         Reviewed by Anders Carlsson.
1838
1839         WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
1840         https://bugs.webkit.org/show_bug.cgi?id=56226
1841
1842         * dom/Document.cpp:
1843         (WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
1844         (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
1845         (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
1846         (WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
1847         (WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
1848
1849 2011-03-11  Jer Noble  <jer.noble@apple.com>
1850
1851         Reviewed by Anders Carlsson.
1852
1853         Create new interface stubs to support full screen mode in WebKit2.
1854
1855         WebKit2: Plumb new full screen animation APIs through WebKit2.
1856         https://bugs.webkit.org/show_bug.cgi?id=55993
1857
1858         * page/ChromeClient.h:
1859         (WebCore::ChromeClient::setRootFullScreenLayer): Added.
1860
1861 2011-03-11  Oliver Hunt  <oliver@apple.com>
1862
1863         Reviewed by Gavin Barraclough.
1864
1865         Ensure all values are correctly tagged in the registerfile
1866         https://bugs.webkit.org/show_bug.cgi?id=56214
1867
1868         Make sure everything builds still.
1869
1870         * bridge/c/c_class.cpp:
1871         * bridge/c/c_runtime.cpp:
1872         * bridge/jni/JavaMethod.cpp:
1873         * plugins/PluginViewNone.cpp:
1874
1875 2011-03-11  Mark Rowe  <mrowe@apple.com>
1876
1877         Fix the 32-bit build.
1878
1879         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1880         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
1881
1882 2011-03-11  Mark Rowe  <mrowe@apple.com>
1883
1884         Rubber-stamped by Eric Carlsson.
1885
1886         <rdar://problem/9124537> Crashes during layout tests due to overrelease of AVFoundation objects.
1887
1888         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
1889         (WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
1890         (WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):
1891
1892 2011-03-11  Chris Marrin  <cmarrin@apple.com>
1893
1894         Unreviewed.
1895
1896         Fixes an error with the checkin for https://bugs.webkit.org/show_bug.cgi?id=52468
1897
1898         * platform/graphics/ca/GraphicsLayerCA.cpp:
1899         (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
1900
1901 2011-03-11  Brady Eidson  <beidson@apple.com>
1902
1903         Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
1904
1905         * loader/icon/IconDatabase.h: Make this guy public.
1906
1907 2011-03-11  Brady Eidson  <beidson@apple.com>
1908
1909         Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
1910
1911         * loader/icon/IconDatabase.h:
1912         (WebCore::IconDatabase::delayDatabaseCleanup): Maybe Qt has Icon Database disabled, so we need to define this here?
1913
1914 2011-03-11  Brady Eidson  <beidson@apple.com>
1915
1916         https://bugs.webkit.org/show_bug.cgi?id=56216
1917         Fix the Qt build following the same pattern of the patch.
1918
1919         * loader/icon/IconDatabase.h:
1920         * loader/icon/IconDatabaseBase.cpp:
1921         (WebCore::IconDatabaseBase::databasePath): Added to the virtual base.
1922         * loader/icon/IconDatabaseBase.h:
1923         (WebCore::IconDatabaseBase::isOpen): Ditto.
1924
1925 2011-03-11  Ben Taylor  <bentaylor.solx86@gmail.com>
1926
1927         Reviewed by Alexey Proskuryakov.
1928
1929         https://bugs.webkit.org/show_bug.cgi?id=56198
1930         Fix conditional which had an int for one case and a pointer for another.
1931
1932         No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++
1933
1934         * loader/appcache/ApplicationCacheGroup.cpp:
1935         (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
1936
1937 2011-03-11  Brady Eidson  <beidson@apple.com>
1938
1939         Windows build fix.
1940
1941         * history/HistoryItem.cpp:
1942         * loader/icon/IconDatabaseBase.cpp:
1943
1944 2011-03-11  Brady Eidson  <beidson@apple.com>
1945
1946         Reviewed by Sam Weinig.
1947
1948         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
1949         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
1950
1951         Project file stuff:
1952         * Android.mk:
1953         * CMakeLists.txt:
1954         * GNUmakefile.am:
1955         * WebCore.gyp/WebCore.gyp:
1956         * WebCore.gypi:
1957         * WebCore.pro:
1958         * WebCore.xcodeproj/project.pbxproj:
1959         * WebCore.vcproj/WebCore.vcproj:
1960
1961         * loader/icon/IconDatabase.cpp:
1962         * loader/icon/IconDatabase.h: Inherit from IconDatabaseBase.
1963
1964         * loader/icon/IconDatabaseBase.cpp: Added.
1965         (WebCore::IconDatabaseBase::iconURLForPageURL):
1966         (WebCore::iconDatabase):
1967         (WebCore::setGlobalIconDatabase):
1968         * loader/icon/IconDatabaseBase.h: Added.
1969         (WebCore::IconDatabaseBase::IconDatabaseBase):
1970         (WebCore::IconDatabaseBase::~IconDatabaseBase):
1971         (WebCore::IconDatabaseBase::setEnabled):
1972         (WebCore::IconDatabaseBase::isEnabled):
1973         (WebCore::IconDatabaseBase::defaultIcon):
1974         (WebCore::IconDatabaseBase::retainIconForPageURL):
1975         (WebCore::IconDatabaseBase::releaseIconForPageURL):
1976         (WebCore::IconDatabaseBase::iconForPageURL):
1977         (WebCore::IconDatabaseBase::setIconURLForPageURL):
1978         (WebCore::IconDatabaseBase::setIconDataForIconURL):
1979         (WebCore::IconDatabaseBase::iconDataKnownForIconURL):
1980         (WebCore::IconDatabaseBase::loadDecisionForIconURL):
1981         (WebCore::IconDatabaseBase::pageURLMappingCount):
1982         (WebCore::IconDatabaseBase::retainedPageURLCount):
1983         (WebCore::IconDatabaseBase::iconRecordCount):
1984         (WebCore::IconDatabaseBase::iconRecordCountWithData):
1985         (WebCore::IconDatabaseBase::importIconURLForPageURL):
1986         (WebCore::IconDatabaseBase::importIconDataForIconURL):
1987         (WebCore::IconDatabaseBase::shouldStopThreadActivity):
1988         (WebCore::IconDatabaseBase::open):
1989         (WebCore::IconDatabaseBase::close):
1990         (WebCore::IconDatabaseBase::removeAllIcons):
1991         (WebCore::IconDatabaseBase::setPrivateBrowsingEnabled):
1992         (WebCore::IconDatabaseBase::setClient):
1993
1994         * loader/icon/IconDatabaseNone.cpp: Removed.
1995
1996 2011-03-11  Brady Eidson  <beidson@apple.com>
1997
1998         Attempt at a build-fix for https://bugs.webkit.org/show_bug.cgi?id=51878
1999
2000         * page/PageGroup.h: Declare this method, even if the definition will end up being empty.
2001
2002 2011-03-11  Michael Nordman  <michaeln@google.com>
2003
2004         Reviewed by Dmitry Titov.
2005
2006         Adding the '~' to the dtor (duh).
2007
2008         No new tests.
2009
2010         * storage/SQLCallbackWrapper.h:
2011         (WebCore::SQLCallbackWrapper::~SQLCallbackWrapper):
2012
2013 2011-03-11  Carol Szabo  <carol.szabo@nokia.com>
2014
2015         Reviewed by David Hyatt.
2016
2017         Introduced double linkage between a CounterNode and its display renderer.
2018
2019         use of freed pointer in WebCore::RenderCounter::originalText()
2020         https://bugs.webkit.org/show_bug.cgi?id=56065
2021
2022         No new tests. This bug could only be reproduced manually by
2023         refreshing the page during load at a critical point.
2024         See bug attachment for testing.
2025
2026         * rendering/CounterNode.cpp:
2027         Introduced new member "m_owner" to store the renderer that has the
2028         style directives that produce the CounterNode.
2029         Repurposed m_renderer to reffer to the RenderCounter that shows the
2030         CounterNode.
2031         (WebCore::CounterNode::CounterNode):
2032         Updated member initialization.
2033         (WebCore::CounterNode::create):
2034         (WebCore::CounterNode::resetRenderer):
2035         (WebCore::CounterNode::resetRenderers):
2036         (WebCore::CounterNode::recount):
2037         (WebCore::CounterNode::removeChild):
2038         (WebCore::CounterNode::insertAfter):
2039         No functional changes.
2040         (WebCore::showTreeAndMark):
2041         Added flushing to ensure that the output is complete.
2042         * rendering/CounterNode.h:
2043         (WebCore::CounterNode::owner):
2044         Renamed from renderer()
2045         (WebCore::CounterNode::renderer):
2046         (WebCore::CounterNode::setRenderer):
2047         Added new accessors for the display renderer.
2048         * rendering/RenderCounter.cpp:
2049         (WebCore::findPlaceForCounter):
2050         Fixed comments. No functional changes.
2051         (WebCore::RenderCounter::~RenderCounter):
2052         Made sure that the CounterNode that this renderers displays is
2053         detached from this.
2054         (WebCore::RenderCounter::originalText):
2055         (WebCore::RenderCounter::invalidate):
2056         Added code to update m_renderer on the displayed CounterNode.
2057         (WebCore::destroyCounterNodeWithoutMapRemoval):
2058         (WebCore::RenderCounter::destroyCounterNodes):
2059         (WebCore::RenderCounter::destroyCounterNode):
2060         (WebCore::updateCounters):
2061         No change, just kept code in line with the changes above.
2062         (showCounterRendererTree):
2063         Added fflush to ensure complete display.
2064         * rendering/RenderCounter.h:
2065         * rendering/RenderObjectChildList.cpp:
2066         * rendering/RenderObjectChildList.h:
2067         Removed unneeded invalidateCounters related functions.
2068
2069 2011-03-11  Luke Macpherson   <macpherson@chromium.org>
2070
2071         Reviewed by Eric Seidel.
2072
2073         Introduce lookup-table based approach for applying CSS properties.
2074         The aim is to be a starting point for refactoring
2075         CSSStyleSelector::applyProperty() into more readable, maintainable code.
2076         https://bugs.webkit.org/show_bug.cgi?id=54707
2077
2078         No new behavior / covered by existing tests.
2079
2080         * css/CSSStyleApplyProperty.cpp: Added.
2081         (WebCore::ApplyPropertyNull):
2082         Class that provides empty implementations of inherit, initial, value.
2083         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
2084         Class that calls the appropriate RenderStyle setters directly.
2085         (WebCore::ApplyPropertyColorBase::ApplyPropertyColorBase):
2086         Class for handling CSSProperty*Color.
2087         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
2088         Class for handling CSSPropertyColor.
2089         (WebCore::CSSStyleApplyProperty::sharedCSSStyleApplyProperty):
2090         Singleton initializer.
2091         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2092         Constructor that bulds up the map from property id to apply-er objects.
2093         * css/CSSStyleApplyProperty.h: Added.
2094         (WebCore::CSSStyleApplyProperty::inherit):
2095         Handle the inherit case for a given property.
2096         (WebCore::CSSStyleApplyProperty::initial):
2097         Handle the initial case for a given property.
2098         (WebCore::CSSStyleApplyProperty::value):
2099         Apply a value to a given property.
2100         (WebCore::CSSStyleApplyProperty::implements):
2101         Returns true if the provided property id is implemented.
2102         (WebCore::CSSStyleApplyProperty::index):
2103         Private function to determine the index of a property the property map.
2104         (WebCore::CSSStyleApplyProperty::valid):
2105         Function to determine that a given property id is valid.
2106         (WebCore::CSSStyleApplyProperty::setPropertyValue):
2107         (WebCore::CSSStyleApplyProperty::propertyValue):
2108         * css/CSSStyleSelector.cpp:
2109         (WebCore::CSSStyleSelector::CSSStyleSelector):
2110         Get reference to the CSSStyleApplyProperty singleton.
2111         (WebCore::CSSStyleSelector::applyProperty):
2112         Now calls into CSSStyleApplyProperty for implemented property ids.
2113         Deleted color-related methods from the property id switch.
2114         * css/CSSStyleSelector.h:
2115         (WebCore::CSSStyleSelector::style):
2116         Made public to allow access from CSSStyleApplyProperty.
2117         (WebCore::CSSStyleSelector::parentStyle):
2118         Made public to allow access from CSSStyleApplyProperty.
2119         * rendering/style/RenderStyle.h:
2120         Made CSSStyleApplyProperty a friend class. Necessary because it needs
2121         to access the private getters and setters on this clsass.
2122
2123 2011-03-11  Anton D'Auria  <adauria@apple.com>
2124
2125         Reviewed and landed by Brady Eidson.
2126
2127         Add WebKit1 API to view and delete local storage
2128         https://bugs.webkit.org/show_bug.cgi?id=51878
2129
2130         Created StorageTracker as a central point for tracking and deleting LocalStorage per origin.
2131         StorageTracker maintains its own database of origin identifiers and backing db paths,
2132         and this allows it to contain more relational data in the future, like variable quotas per origin.
2133
2134         On initialization, StorageTracker syncs its database with LocalStorage files on disk. It adds
2135         an origin entry when StorageAreaSync performs a first sync for an origin.
2136
2137         All StorageTracker file operations are performed on one background thread with a task queue.
2138
2139         Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html
2140                storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html
2141                storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html
2142                storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html
2143                storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html
2144
2145         * GNUmakefile.am:
2146         * WebCore.exp.in:
2147         * WebCore.gypi:
2148         * WebCore.pro:
2149         * WebCore.vcproj/WebCore.vcproj:
2150         * WebCore.xcodeproj/project.pbxproj:
2151         * page/PageGroup.cpp:
2152         (WebCore::PageGroup::clearLocalStorageForAllOrigins):
2153         (WebCore::PageGroup::clearLocalStorageForOrigin):
2154         (WebCore::PageGroup::syncLocalStorage):
2155         (WebCore::PageGroup::numberOfPageGroups):
2156         * page/PageGroup.h:
2157         * platform/chromium/FileSystemChromium.cpp:
2158         (WebCore::listDirectory):
2159         * platform/posix/FileSystemPOSIX.cpp:
2160         (WebCore::listDirectory):
2161         * storage/LocalStorageTask.cpp:
2162         (WebCore::LocalStorageTask::LocalStorageTask):
2163         (WebCore::LocalStorageTask::performTask):
2164         * storage/LocalStorageTask.h:
2165         (WebCore::LocalStorageTask::createOriginIdentifiersImport):
2166         (WebCore::LocalStorageTask::createSetOriginDetails):
2167         (WebCore::LocalStorageTask::createDeleteOrigin):
2168         (WebCore::LocalStorageTask::createDeleteAllOrigins):
2169         * storage/StorageAreaImpl.cpp:
2170         (WebCore::StorageAreaImpl::clearForOriginDeletion):
2171         (WebCore::StorageAreaImpl::sync):
2172         * storage/StorageAreaImpl.h:
2173         * storage/StorageAreaSync.cpp:
2174         (WebCore::StorageAreaSync::scheduleCloseDatabase):
2175         (WebCore::StorageAreaSync::openDatabase):
2176         (WebCore::StorageAreaSync::sync):
2177         (WebCore::StorageAreaSync::deleteEmptyDatabase):
2178         (WebCore::StorageAreaSync::scheduleSync):
2179         * storage/StorageAreaSync.h:
2180         * storage/StorageNamespace.h:
2181         * storage/StorageNamespaceImpl.cpp:
2182         (WebCore::StorageNamespaceImpl::clearOriginForDeletion):
2183         (WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
2184         (WebCore::StorageNamespaceImpl::sync):
2185         * storage/StorageNamespaceImpl.h:
2186         * storage/StorageTracker.cpp: Added.
2187         (WebCore::StorageTracker::initializeTracker):
2188         (WebCore::StorageTracker::tracker):
2189         (WebCore::StorageTracker::StorageTracker):
2190         (WebCore::StorageTracker::setStorageDirectoryPath):
2191         (WebCore::StorageTracker::trackerDatabasePath):
2192         (WebCore::StorageTracker::openTrackerDatabase):
2193         (WebCore::StorageTracker::importOriginIdentifiers):
2194         (WebCore::StorageTracker::syncImportOriginIdentifiers):
2195         (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
2196         (WebCore::StorageTracker::setOriginDetails):
2197         (WebCore::StorageTracker::scheduleTask):
2198         (WebCore::StorageTracker::syncSetOriginDetails):
2199         (WebCore::StorageTracker::origins):
2200         (WebCore::StorageTracker::deleteAllOrigins):
2201         (WebCore::StorageTracker::syncDeleteAllOrigins):
2202         (WebCore::StorageTracker::deleteOrigin):
2203         (WebCore::StorageTracker::syncDeleteOrigin):
2204         (WebCore::StorageTracker::willDeleteAllOrigins):
2205         (WebCore::StorageTracker::willDeleteOrigin):
2206         (WebCore::StorageTracker::canDeleteOrigin):
2207         (WebCore::StorageTracker::cancelDeletingOrigin):
2208         (WebCore::StorageTracker::setClient):
2209         (WebCore::StorageTracker::syncLocalStorage):
2210         * storage/StorageTracker.h: Added.
2211         * storage/StorageTrackerClient.h: Added.
2212         (WebCore::StorageTrackerClient::~StorageTrackerClient):
2213
2214 2011-03-11  Steve Block  <steveblock@google.com>
2215
2216         Reviewed by Jeremy Orlow.
2217
2218         JavaMethod does not correctly check for a null jstring for the method name
2219         https://bugs.webkit.org/show_bug.cgi?id=56187
2220
2221         No new tests, simple typo fix.
2222
2223         * bridge/jni/JavaMethod.cpp:
2224         (JavaMethod::JavaMethod):
2225
2226 2011-03-11  Adrienne Walker  <enne@google.com>
2227
2228         Reviewed by James Robinson.
2229
2230         [chromium] Compositor uses too much texture memory for scrollbars
2231         https://bugs.webkit.org/show_bug.cgi?id=56212
2232
2233         Compositor invalidations can be off the page (and very large), but
2234         scrollbars only need to care about the invalidation that's visible.
2235         The large invalidation was causing the tiler layer size to grow
2236         needlessly larger than the scrollbar.
2237
2238         * platform/graphics/chromium/LayerRendererChromium.cpp:
2239         (WebCore::LayerRendererChromium::invalidateRootLayerRect):
2240
2241 2011-03-11  David Hyatt  <hyatt@apple.com>
2242
2243         Reviewed by Simon Fraser.
2244
2245         https://bugs.webkit.org/show_bug.cgi?id=52987
2246         
2247         REGRESSION: Overflowing columns not repainted correctly
2248         
2249         Make sure to add in column overflow as visual overflow as well.  It was only propagating layout overflow, which is obviously not
2250         sufficient, since blocks paint their own columns.
2251
2252         Added fast/multicol/scrolling-overflow.html
2253
2254         * rendering/RenderBlock.cpp:
2255         (WebCore::RenderBlock::addOverflowFromChildren):
2256
2257 2011-03-11  Matthew Delaney  <mdelaney@apple.com>
2258
2259         Reviewed by Simon Fraser.
2260
2261         Set canvasUsesAcceleratedDrawing setting to be off(false) by default
2262         https://bugs.webkit.org/show_bug.cgi?id=56215
2263
2264         No new tests. Does not affect behavior. Just keeping the setting off by default.
2265
2266         * page/Settings.cpp:
2267         (WebCore::Settings::Settings):
2268
2269 2011-03-11  Andy Estes  <aestes@apple.com>
2270
2271         Reviewed by David Hyatt.
2272
2273         Table cells with dynamically added percentage height descendants do not
2274         grow in size if the table has already been laid out.
2275         https://bugs.webkit.org/show_bug.cgi?id=56174
2276         
2277         Table cells ignore their specified size and collapse to fit their
2278         children. When a descendent with percentage height is present before
2279         the table is first laid out, the descendent is sized based on the
2280         specified size of the table cell. However, when the child isn't present
2281         when the table is first laid out, the table cell ignores its specified
2282         size and collapses down to 0. Then, when the child div is added in a
2283         separate run loop iteration, it is sized to be 100% of the collapsed
2284         cell height instead of 100% of the cell's specified height. We should
2285         not get different layouts depending on the timing of tree construction.
2286         
2287         Fix this by clearing intrinsic padding before calculating the table
2288         cell's override height when we detect a child that should flex the
2289         table cell.
2290
2291         Test: fast/table/dynamic-descendant-percentage-height.html
2292
2293         * rendering/RenderTableCell.cpp:
2294         (WebCore::RenderTableCell::setOverrideSizeFromRowHeight): clear
2295         intrinsic padding before setting the override size.
2296         * rendering/RenderTableCell.h:
2297         * rendering/RenderTableSection.cpp:
2298         (WebCore::RenderTableSection::layoutRows): Call
2299         setOverrideSizeFromRowHeight() instead of setOverrideSize().
2300
2301 2011-03-11  Michael Nordman  <michaeln@google.com>
2302
2303         Reviewed by David Levin.
2304
2305         Add SQLCallbackWrapper
2306         Instead of directly holding RefPtrs to the Callback objects in SQLStatement and SQLTransaction, hold a wrapper objects
2307         which holds those references whose dtors will schedule the release of those references on the ScriptExecution thread.
2308         https://bugs.webkit.org/show_bug.cgi?id=55919
2309
2310         No new tests, existing tests apply.
2311
2312         * GNUmakefile.am:
2313         * WebCore.gypi:
2314         * WebCore.pro:
2315         * WebCore.vcproj/WebCore.vcproj:
2316         * WebCore.xcodeproj/project.pbxproj:
2317         * storage/SQLCallbackWrapper.h: Added.
2318         (WebCore::SQLCallbackWrapper::SQLCallbackWrapper):
2319         (WebCore::SQLCallbackWrapper::clear):
2320         (WebCore::SQLCallbackWrapper::unwrap):
2321         (WebCore::SQLCallbackWrapper::hasCallback):
2322         (WebCore::SQLCallbackWrapper::safeRelease):
2323         * storage/SQLStatement.cpp:
2324         (WebCore::SQLStatement::create):
2325         (WebCore::SQLStatement::SQLStatement):
2326         (WebCore::SQLStatement::performCallback):
2327         * storage/SQLStatement.h:
2328         (WebCore::SQLStatement::hasStatementCallback):
2329         (WebCore::SQLStatement::hasStatementErrorCallback):
2330         * storage/SQLTransaction.cpp:
2331         (WebCore::SQLTransaction::SQLTransaction):
2332         (WebCore::SQLTransaction::executeSQL):
2333         (WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
2334         (WebCore::SQLTransaction::deliverTransactionCallback):
2335         (WebCore::SQLTransaction::deliverStatementCallback):
2336         (WebCore::SQLTransaction::postflightAndCommit):
2337         (WebCore::SQLTransaction::deliverSuccessCallback):
2338         (WebCore::SQLTransaction::handleTransactionError):
2339         (WebCore::SQLTransaction::deliverTransactionErrorCallback):
2340         * storage/SQLTransaction.h:
2341
2342 2011-03-11  Eric Carlson  <eric.carlson@apple.com>
2343
2344         Reviewed by Sam Weinig.
2345
2346         <rdar://problem/8955589> Adopt AVFoundation media back end on Lion.
2347
2348         No new tests, existing media tests cover this.
2349
2350         * WebCore.xcodeproj/project.pbxproj:
2351         * platform/graphics/MediaPlayer.cpp:
2352         (WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationObjC.
2353         (WebCore::bestMediaEngineForTypeAndCodecs): Kill some whitespace.
2354         (WebCore::MediaPlayer::loadWithNextMediaEngine): Ditto.
2355         (WebCore::MediaPlayer::inMediaDocument): Ditto.
2356         * platform/graphics/MediaPlayer.h:
2357
2358         * platform/graphics/avfoundation: Added.
2359         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Added.
2360         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Added.
2361
2362         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Added.
2363         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Added.
2364
2365 2011-03-11  Dean Jackson  <dino@apple.com>
2366
2367         Reviewed by Simon Fraser.
2368
2369         https://bugs.webkit.org/show_bug.cgi?id=56205
2370         m_restrictions needs to allow multiple values (a bitfield)
2371
2372         HTMLMediaElement::m_restrictions needs to hold multiple values, so
2373         change BehaviorRestrictions to an unsigned typedef and rename the
2374         existing enum BehaviorRestrictionFlags.
2375
2376         * html/HTMLMediaElement.h:
2377         (WebCore::HTMLMediaElement::setBehaviorRestrictions):
2378
2379 2011-03-11  David Hyatt  <hyatt@apple.com>
2380
2381         Reviewed by Dan Bernstein.
2382
2383         https://bugs.webkit.org/show_bug.cgi?id=47206
2384         
2385         Table rows don't support ::before/::after.  Add support to RenderTableRow::styleDidChange so that ::before/::after content gets
2386         properly constructed.
2387
2388         Added fast/css-generated-content/table-row-before-after.html
2389
2390         * rendering/RenderTableRow.cpp:
2391         (WebCore::RenderTableRow::styleDidChange):
2392         * rendering/RenderTableRow.h:
2393
2394 2011-03-11  James Robinson  <jamesr@chromium.org>
2395
2396         Reviewed by Kenneth Russell.
2397
2398         [chromium] Avoid updating a composited layer&apos;s contents if the layer has nonpositive dimensions
2399         https://bugs.webkit.org/show_bug.cgi?id=56209
2400
2401         This matches the behavior prior to r80482.  No test since the only changes in
2402         behavior are avoiding work on invisible layers, which is unobservable,
2403         and fixing a crash due to bug 56153.
2404
2405         * platform/graphics/chromium/LayerRendererChromium.cpp:
2406         (WebCore::LayerRendererChromium::updateContentsRecursive):
2407
2408 2011-03-11  David Hyatt  <hyatt@apple.com>
2409
2410         Reviewed by Simon Fraser.
2411
2412         https://bugs.webkit.org/show_bug.cgi?id=47159
2413         
2414         CSS2.1 failures in background position parsing.
2415         
2416         Rewrite background position component parsing to match the spec.  Our old parsing would allow "100% left" to be valid
2417         when it should not have.  Rename parseFillPositionXY to parseFillPositionComponent and pass in enough information for
2418         it to understand what the first component was.
2419         
2420         For individual property parsing using background-position-x/y, I added new functions that just handle that without
2421         worrying about the other component.
2422         
2423         In order to pass the CSS2.1 test, I also had to fix multiple background parsing.  The number of layers in multiple
2424         backgrounds is determined solely by the background-image property and not by any of the other properties.  cullEmptyLayers
2425         has been changed to always consider a layer empty if it has no image set, even if other properties are set.
2426         
2427         A number of layout tests had to be patched as they were invalid.  A couple of them relied on incorrect background-position
2428         parsing (e.g., "50 left") and another relied on incorrect multiple background parsing.  It's not clear if the computed style
2429         should actually include the additional values when no image is set though, so that should perhaps be the subject of a 
2430         follow-up bug.
2431
2432         Added fast/backgrounds/background-position-parsing.html
2433
2434         * css/CSSParser.cpp:
2435         (WebCore::CSSParser::parseFillPositionX):
2436         (WebCore::CSSParser::parseFillPositionY):
2437         (WebCore::CSSParser::parseFillPositionComponent):
2438         (WebCore::CSSParser::parseFillPosition):
2439         (WebCore::CSSParser::parseFillProperty):
2440         (WebCore::CSSParser::parseTransformOrigin):
2441         (WebCore::CSSParser::parsePerspectiveOrigin):
2442         * css/CSSParser.h:
2443         * rendering/style/FillLayer.cpp:
2444         (WebCore::FillLayer::fillUnsetProperties):
2445         (WebCore::FillLayer::cullEmptyLayers):
2446
2447 2011-03-11  Vangelis Kokkevis  <vangelis@chromium.org>
2448
2449         Reviewed by James Robinson.
2450
2451         [chromium] Allow large layers with non-identity transforms to be drawn
2452         as long as their visible portion is smaller than the largest supported
2453         texture size. This code will soon be replaced by tiled layers.
2454         https://bugs.webkit.org/show_bug.cgi?id=55984
2455
2456         Test: platform/chromium/compositing/huge-layer-rotated.html
2457
2458         * platform/graphics/chromium/ContentLayerChromium.cpp:
2459         (WebCore::ContentLayerChromium::updateContentsIfDirty):
2460         (WebCore::ContentLayerChromium::draw):
2461         * platform/graphics/chromium/ContentLayerChromium.h:
2462
2463 2011-03-09  Chris Marrin  <cmarrin@apple.com>
2464
2465         Reviewed by Adam Roben.
2466
2467         REGRESSION (5.0.3-ToT): Scrolling text doesn&apos;t scroll in Star Wars intro animation
2468         https://bugs.webkit.org/show_bug.cgi?id=52468
2469
2470         Added WIN32 to the ifdef controlling whether animations are applied in normal or
2471         reverse order. On Mac, animations used to be applied in reverse, but 
2472         <rdar://problem/7095638> fixed this in the release after Snow Leopard.
2473         But that patch has not be applied to the Safari Windows SDK yet. For now
2474         I've made Windows use the reverse order logig. <rdar://problem/9112233> is
2475         tracking the inclusion of the patch on Windows.
2476
2477         * platform/graphics/ca/GraphicsLayerCA.cpp:
2478         (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
2479
2480 2011-03-11  Tony Gentilcore  <tonyg@chromium.org>
2481
2482         Reviewed by Eric Seidel.
2483
2484         Let the parser yield for layout before running scripts
2485         https://bugs.webkit.org/show_bug.cgi?id=54355
2486
2487         Prior to this patch, the parser would yield to perform a layout/paint before running a
2488         script only if the script or a stylesheet blocking the script is not loaded yet. Since we
2489         don't preload scan into the body while parsing the head, typically we'll block on a script
2490         early in the body that causes us to yield to do the first paint within a reasonable time.
2491
2492         However, I'm planning to change the PreloadScanner to scan into the body from the head.
2493         That significantly improves overall load time, but would hurt first paint time because
2494         fewer scripts would be blocked during parsing and thus wouldn't yield.
2495
2496         This change causes us to yield before running scripts if we haven't painted yet (regardless
2497         of whether or not the script is loaded). In addition to allowing the above mentioned
2498         PreloadScanner change to be implemented without regressing first paint time, this also
2499         improves first paint time by itself.
2500
2501         I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
2502         bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
2503         6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
2504         signifcant change in page load time.
2505
2506         Within the pages tested, 33 had no statistically significant change in time to first paint,
2507         12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
2508         are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.
2509
2510         * html/parser/HTMLDocumentParser.cpp:
2511         (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point.
2512         (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused
2513         means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does
2514         the right thing whether we are just before a token or waiting for a script. Now that we may
2515         yield before a token or before a script, this may be called while paused.
2516         * html/parser/HTMLParserScheduler.cpp:
2517         (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
2518         * page/FrameView.h:
2519         (WebCore::FrameView::hasEverPainted): Added.
2520
2521 2011-03-11  Dimitri Glazkov  <dglazkov@chromium.org>
2522
2523         Fix crashes in dom/html/level2/html/HTMLInputElement*.
2524
2525         * css/CSSStyleSelector.cpp:
2526         (WebCore::CSSStyleSelector::adjustRenderStyle): Added a null-check for e,
2527             because e can certainly be a null.
2528
2529 2011-03-09  Dimitri Glazkov  <dglazkov@chromium.org>
2530
2531         Reviewed by David Hyatt.
2532
2533         Choke text-decoration when entering shadow DOM subtree.
2534         https://bugs.webkit.org/show_bug.cgi?id=56044
2535
2536         No new tests, because the functionality can't be tested yet.
2537
2538         * css/CSSStyleSelector.cpp:
2539         (WebCore::CSSStyleSelector::adjustRenderStyle): Added a check for shadow DOM root.
2540
2541 2011-03-08  Dimitri Glazkov  <dglazkov@chromium.org>
2542
2543         Reviewed by Eric Carlson.
2544
2545         Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer.
2546         https://bugs.webkit.org/show_bug.cgi?id=55972
2547
2548         Instead of poking at the time display elements all the way from RenderMedia,
2549         let the standard layout cycle take care of things. Move the logic of calculating
2550         when to collapse the time display elements into a custom renderer, since
2551         this is not something that can be accomplished with CSS.
2552
2553         Also, the logic of keeping the timeline slider at least 100px needed refreshing,
2554         since it didn't actually keep it at 100px.
2555
2556         * html/shadow/MediaControls.cpp: Moved the logic of determining visibility
2557             of time display elements to RenderMediaControlTimeDisplay, eliminating
2558             updateTimeDisplayVisibility method.
2559         * html/shadow/MediaControls.h: Removed decl.
2560         * rendering/MediaControlElements.cpp:
2561         (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
2562             Added new renderer class.
2563         (WebCore::RenderMediaControlTimeDisplay::layout): Simplified (and corrected)
2564             size-sensing logic, still using hard-coded values.
2565         (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
2566             Removed m_isVisible member, which is no longer necessary.
2567         (WebCore::MediaControlTimeDisplayElement::createRenderer): Added to
2568             return the new renderer.
2569         * rendering/MediaControlElements.h: Adjusted decls.
2570         * rendering/RenderMedia.cpp:
2571         (WebCore::RenderMedia::layout): Remove the now-unnecessary poking at
2572             media controls in layout.
2573
2574 2011-03-09  Dimitri Glazkov  <dglazkov@chromium.org>
2575
2576         Reviewed by Eric Carlson.
2577
2578         Start focusing updates to media controls, away from always updating everything.
2579         https://bugs.webkit.org/show_bug.cgi?id=56038
2580
2581         For now, the new methods just call generic MediaControls::update.
2582
2583         Covered by existing tests.
2584
2585         * html/HTMLMediaElement.cpp:
2586         (WebCore::HTMLMediaElement::attributeChanged): Changed to use MediaControls::reset.
2587         (WebCore::HTMLMediaElement::setMuted): Changed to use MediaControls::changedMute.
2588         (WebCore::HTMLMediaElement::updateVolume): Changed to use MediaControls::changedVolume.
2589         (WebCore::HTMLMediaElement::defaultEventHandler): Changed to use the new mediaControls
2590             accessor.
2591         (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Changed to use
2592             MediaControls::changedClosedCaptionsVisibility.
2593         (WebCore::HTMLMediaElement::mediaControls): Added.
2594         (WebCore::HTMLMediaElement::hasMediaControls): Added.
2595         * html/HTMLMediaElement.h: Added decls.
2596         * html/shadow/MediaControls.cpp:
2597         (WebCore::MediaControls::reset): Added.
2598         (WebCore::MediaControls::changedMute): Added.
2599         (WebCore::MediaControls::changedVolume): Added.
2600         (WebCore::MediaControls::changedClosedCaptionsVisibility): Added.
2601         * html/shadow/MediaControls.h: Added decls.
2602
2603 2011-03-11  Alexis Menard  <alexis.menard@openbossa.org>
2604
2605         Reviewed by Martin Robinson.
2606
2607         [GStreamer] When seeking webKitWebSrcStop release the frame but should not.
2608         https://bugs.webkit.org/show_bug.cgi?id=55703
2609
2610         When calling webKitWebSrcStop in case of a seeking, the frame should not
2611         be reset (the source hasn't change). The frame may be used to get the network
2612         context. Some network stack (like Qt) are relaying on the network context
2613         to work.
2614
2615         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
2616         (webKitWebSrcStop):
2617
2618 2011-03-11  Dean Jackson  <dino@apple.com>
2619
2620         Unreviewed.
2621
2622         Build fixes for GTK and Leopard.
2623
2624         * bindings/gobject/GNUmakefile.am:
2625         - add missing WebKitAnimation* generated bindings
2626         * page/WebKitAnimation.idl:
2627         - use double in place of float (the core values are double anyway)
2628
2629 2011-03-11  Dean Jackson  <dino@apple.com>
2630
2631         Unreviewed build fix for QT.
2632
2633         * WebCore.pro:
2634
2635 2011-03-11  Dean Jackson  <dino@apple.com>
2636
2637         Reviewed by Simon Fraser and Chris Marrin.
2638
2639         https://bugs.webkit.org/show_bug.cgi?id=54151
2640         Implement an API to play/pause/scrub animations
2641
2642         This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
2643         APIs, exposed via Element.getWebKitAnimations(). This first pass
2644         is a read-only API - a subsequent commit will add the ability
2645         to scrub animations.
2646
2647         Test: animations/animation-api-1.html
2648
2649         * Android.derived.jscbindings.mk:
2650         * Android.derived.v8bindings.mk:
2651         * Android.mk:
2652         * Android.v8bindings.mk:
2653         * CMakeLists.txt:
2654         * CodeGenerators.pri:
2655         * DerivedSources.cpp:
2656         * DerivedSources.make:
2657         * GNUmakefile.am:
2658         * WebCore.gypi:
2659         * WebCore.pro:
2660         * WebCore.vcproj/WebCore.vcproj:
2661         * WebCore.xcodeproj/project.pbxproj:
2662         - All build settings updated for new files
2663         * bindings/js/JSBindingsAllInOne.cpp:
2664         - Include new custom files
2665         * bindings/js/JSWebKitAnimationCustom.cpp: Added.
2666         (WebCore::JSWebKitAnimation::iterationCount):
2667         - Custom property getter so that we can return INFINITY
2668         * bindings/js/JSWebKitAnimationListCustom.cpp: Added.
2669         (WebCore::JSWebKitAnimationList::markChildren):
2670         - Make sure WebKitAnimations are marked
2671         * bindings/v8/custom/V8WebKitAnimationCustom.cpp: Added.
2672         (WebCore::V8WebkitAnimation::iterationCountAccessorGetter):
2673         - Custom property getter so that we can return INFINITY
2674         * dom/Element.cpp:
2675         (WebCore::Element::webkitGetAnimations):
2676         * dom/Element.h:
2677         * dom/Element.idl:
2678         - New API entry point
2679         * page/DOMWindow.idl:
2680         - Constructor definitions for WebKitAnimation and WebKitAnimationList
2681         * page/animation/AnimationBase.cpp:
2682         (WebCore::AnimationBase::~AnimationBase):
2683         - Since AnimationBase can now live longer (if a WebKitAnimation is
2684         held in Javascript) we need to guard for the renderer having disappeared.
2685         (WebCore::AnimationBase::setElapsedTime):
2686         (WebCore::AnimationBase::play):
2687         (WebCore::AnimationBase::pause):
2688         - Stub implementations at present
2689         * page/animation/AnimationBase.h:
2690         (WebCore::AnimationBase::animation):
2691         - Expose the Animation properties
2692         * page/animation/AnimationController.cpp:
2693         (WebCore::AnimationControllerPrivate::animationsForRenderer):
2694         (WebCore::AnimationController::animationsForRenderer):
2695         - Builds the list of WebKitAnimations
2696         * page/animation/AnimationController.h:
2697         * page/animation/AnimationControllerPrivate.h:
2698         * page/animation/CompositeAnimation.cpp:
2699         (WebCore::CompositeAnimation::updateKeyframeAnimations):
2700         - Make sure we clear the renderer if we are removing the animation
2701         (WebCore::CompositeAnimation::animations):
2702         * page/animation/CompositeAnimation.h:
2703         * page/WebKitAnimation.cpp: Added.
2704         (WebCore::WebKitAnimation::WebKitAnimation):
2705         (WebCore::WebKitAnimation::name):
2706         (WebCore::WebKitAnimation::duration):
2707         (WebCore::WebKitAnimation::elapsedTime):
2708         (WebCore::WebKitAnimation::setElapsedTime):
2709         (WebCore::WebKitAnimation::delay):
2710         (WebCore::WebKitAnimation::iterationCount):
2711         (WebCore::WebKitAnimation::paused):
2712         (WebCore::WebKitAnimation::ended):
2713         (WebCore::WebKitAnimation::direction):
2714         (WebCore::WebKitAnimation::fillMode):
2715         (WebCore::WebKitAnimation::pause):
2716         (WebCore::WebKitAnimation::play):
2717         - The implementation of the new API. All the read-only parts are
2718         done, but elapsedTime, play() and pause() are stubs.
2719         * page/WebKitAnimation.h: Added.
2720         (WebCore::WebKitAnimation::create):
2721         (WebCore::WebKitAnimation::~WebKitAnimation):
2722         * page/WebKitAnimation.idl: Added.
2723         * page/WebKitAnimationList.cpp: Added.
2724         * page/WebKitAnimationList.h: Added.
2725         * page/WebKitAnimationList.idl: Added.
2726         - Copies NodeList implementation
2727
2728 2011-03-11  Ilya Tikhonovsky  <loislo@chromium.org>
2729
2730         Reviewed by Yury Semikhatsky.
2731
2732         Web Inspector: introduce error argument for all the callbacks on frontend.
2733         https://bugs.webkit.org/show_bug.cgi?id=56100
2734
2735         * inspector/CodeGeneratorInspector.pm:
2736         * inspector/front-end/AuditRules.js:
2737         (WebInspector.AuditRules.evaluateInTargetWindow):
2738         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
2739         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
2740         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
2741         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
2742         * inspector/front-end/CSSStyleModel.js:
2743         (WebInspector.CSSStyleModel.prototype.getStylesAsync):
2744         (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
2745         (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
2746         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
2747         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
2748         (WebInspector.CSSStyleModel.prototype.addRule):
2749         (WebInspector.CSSStyleModel.prototype.addRule.callback):
2750         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
2751         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
2752         (WebInspector.CSSStyleModel.prototype._onRevert):
2753         (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
2754         (WebInspector.CSSProperty.prototype.setText.callback):
2755         (WebInspector.CSSProperty.prototype.setText):
2756         (WebInspector.CSSProperty.prototype.setDisabled.callback):
2757         (WebInspector.CSSProperty.prototype.setDisabled):
2758         (WebInspector.CSSStyleSheet.createForId):
2759         (WebInspector.CSSStyleSheet.prototype.setText):
2760         * inspector/front-end/ConsoleView.js:
2761         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
2762         * inspector/front-end/DOMAgent.js:
2763         (WebInspector.DOMNode.prototype.setNodeName):
2764         (WebInspector.DOMNode.prototype.setNodeValue):
2765         (WebInspector.DOMNode.prototype.setAttribute):
2766         (WebInspector.DOMNode.prototype.removeAttribute):
2767         (WebInspector.DOMNode.prototype.childNodes.mycallback):
2768         (WebInspector.DOMNode.prototype.childNodes):
2769         (WebInspector.DOMNode.prototype.outerHTML):
2770         (WebInspector.DOMNode.prototype.setOuterHTML):
2771         (WebInspector.DOMNode.prototype.removeNode):
2772         (WebInspector.DOMNode.prototype.copyNode):
2773         (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
2774         (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
2775         (WebInspector.DOMAgent.prototype._documentUpdated):
2776         (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
2777         (WebInspector.Cookies.getCookiesAsync):
2778         (WebInspector.EventListeners.getEventListenersForNodeAsync):
2779         * inspector/front-end/DOMStorage.js:
2780         (WebInspector.DOMStorage.prototype.getEntries):
2781         (WebInspector.DOMStorage.prototype.setItem):
2782         (WebInspector.DOMStorage.prototype.removeItem):
2783         * inspector/front-end/Database.js:
2784         (WebInspector.Database.prototype.getTableNames):
2785         (WebInspector.Database.prototype.executeSql):
2786         * inspector/front-end/DebuggerModel.js:
2787         (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
2788         (WebInspector.DebuggerModel.prototype.setBreakpoint):
2789         (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
2790         (WebInspector.DebuggerModel.prototype.editScriptSource):
2791         * inspector/front-end/ElementsPanel.js:
2792         (WebInspector.ElementsPanel.prototype._setSearchingForNode):
2793         * inspector/front-end/ElementsTreeOutline.js:
2794         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
2795         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
2796         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
2797         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
2798         ():
2799         * inspector/front-end/ExtensionPanel.js:
2800         (WebInspector.ExtensionWatchSidebarPane.prototype._onEvaluate):
2801         * inspector/front-end/ExtensionServer.js:
2802         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
2803         * inspector/front-end/NetworkManager.js:
2804         (WebInspector.NetworkManager.prototype.requestContent):
2805         (WebInspector.NetworkManager.prototype._processCachedResources):
2806         * inspector/front-end/ProfileView.js:
2807         (WebInspector.CPUProfileView.profileCallback):
2808         (WebInspector.CPUProfileView):
2809         * inspector/front-end/ProfilesPanel.js:
2810         * inspector/front-end/RemoteObject.js:
2811         (WebInspector.RemoteObject.resolveNode):
2812         (WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder):
2813         (WebInspector.RemoteObject.prototype.getProperties):
2814         (WebInspector.RemoteObject.prototype.setPropertyValue):
2815         (WebInspector.RemoteObject.prototype.evaluate):
2816         * inspector/front-end/Script.js:
2817         (WebInspector.Script.prototype.requestSource.didGetScriptSource):
2818         (WebInspector.Script.prototype.requestSource):
2819         * inspector/front-end/ScriptsPanel.js:
2820         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
2821         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
2822         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
2823         * inspector/front-end/inspector.js:
2824         ():
2825         (WebInspector.doLoadedDone.onPopulateScriptObjects):
2826         (WebInspector.doLoadedDone.propertyNamesCallback):
2827         (WebInspector.doLoadedDone):
2828
2829 2011-03-11  Yury Semikhatsky  <yurys@chromium.org>
2830
2831         Reviewed by Pavel Feldman.
2832
2833         Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
2834         https://bugs.webkit.org/show_bug.cgi?id=56173
2835
2836         Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
2837
2838         * CMakeLists.txt:
2839         * GNUmakefile.am:
2840         * WebCore.gypi:
2841         * WebCore.pro:
2842         * WebCore.vcproj/WebCore.vcproj:
2843         * WebCore.xcodeproj/project.pbxproj:
2844         * bindings/js/JSInjectedScriptHostCustom.cpp:
2845         * bindings/js/JSInjectedScriptManager.cpp: Added.
2846         (WebCore::InjectedScriptManager::createInjectedScript):
2847         (WebCore::InjectedScriptManager::discardInjectedScript):
2848         (WebCore::InjectedScriptManager::injectedScriptFor):
2849         (WebCore::InjectedScriptManager::canAccessInspectedWindow):
2850         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2851         * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
2852         (WebCore::WeakReferenceCallback):
2853         (WebCore::createInjectedScriptHostV8Wrapper):
2854         (WebCore::InjectedScriptManager::createInjectedScript):
2855         (WebCore::InjectedScriptManager::discardInjectedScript):
2856         (WebCore::InjectedScriptManager::injectedScriptFor):
2857         (WebCore::InjectedScriptManager::canAccessInspectedWindow):
2858         * inspector/ConsoleMessage.cpp:
2859         (WebCore::ConsoleMessage::addToFrontend):
2860         * inspector/ConsoleMessage.h:
2861         * inspector/InjectedScript.cpp:
2862         (WebCore::InjectedScript::canAccessInspectedWindow):
2863         * inspector/InjectedScript.h:
2864         * inspector/InjectedScriptHost.cpp:
2865         (WebCore::InjectedScriptHost::create):
2866         (WebCore::InjectedScriptHost::InjectedScriptHost):
2867         (WebCore::InjectedScriptHost::~InjectedScriptHost):
2868         (WebCore::InjectedScriptHost::disconnect):
2869         (WebCore::InjectedScriptHost::inspectImpl):
2870         (WebCore::InjectedScriptHost::clearConsoleMessages):
2871         (WebCore::InjectedScriptHost::databaseIdImpl):
2872         (WebCore::InjectedScriptHost::storageIdImpl):
2873         * inspector/InjectedScriptHost.h:
2874         (WebCore::InjectedScriptHost::init):
2875         (WebCore::InjectedScriptHost::setFrontend):
2876         (WebCore::InjectedScriptHost::clearFrontend):
2877         * inspector/InjectedScriptManager.cpp: Added.
2878         (WebCore::InjectedScriptManager::create):
2879         (WebCore::InjectedScriptManager::InjectedScriptManager):
2880         (WebCore::InjectedScriptManager::~InjectedScriptManager):
2881         (WebCore::InjectedScriptManager::disconnect):
2882         (WebCore::InjectedScriptManager::injectedScriptHost):
2883         (WebCore::InjectedScriptManager::injectedScriptForId):
2884         (WebCore::InjectedScriptManager::injectedScriptForObjectId):
2885         (WebCore::InjectedScriptManager::discardInjectedScripts):
2886         (WebCore::InjectedScriptManager::releaseObjectGroup):
2887         (WebCore::InjectedScriptManager::injectedScriptSource):
2888         (WebCore::InjectedScriptManager::injectScript):
2889         * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
2890         * inspector/Inspector.idl:
2891         * inspector/InspectorAgent.cpp:
2892         (WebCore::InspectorAgent::InspectorAgent):
2893         (WebCore::InspectorAgent::inspectedPageDestroyed):
2894         (WebCore::InspectorAgent::focusNode):
2895         (WebCore::InspectorAgent::didClearWindowObjectInWorld):
2896         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
2897         (WebCore::InspectorAgent::didCommitLoad):
2898         (WebCore::InspectorAgent::domContentLoadedEventFired):
2899         * inspector/InspectorAgent.h:
2900         * inspector/InspectorBrowserDebuggerAgent.cpp:
2901         * inspector/InspectorConsoleAgent.cpp:
2902         (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
2903         (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
2904         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
2905         (WebCore::InspectorConsoleAgent::addInspectedNode):
2906         (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
2907         (WebCore::InspectorConsoleAgent::addConsoleMessage):
2908         * inspector/InspectorConsoleAgent.h:
2909         * inspector/InspectorController.cpp:
2910         (WebCore::InspectorController::InspectorController):
2911         (WebCore::InspectorController::connectFrontend):
2912         (WebCore::InspectorController::disconnectFrontend):
2913         * inspector/InspectorController.h:
2914         * inspector/InspectorDOMAgent.cpp:
2915         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2916         (WebCore::InspectorDOMAgent::discardBindings):
2917         (WebCore::InspectorDOMAgent::pushNodeToFrontend):
2918         (WebCore::InspectorDOMAgent::resolveNode):
2919         * inspector/InspectorDOMAgent.h:
2920         (WebCore::InspectorDOMAgent::create):
2921         * inspector/InspectorDebuggerAgent.cpp:
2922         (WebCore::InspectorDebuggerAgent::create):
2923         (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
2924         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
2925         (WebCore::InspectorDebuggerAgent::currentCallFrames):
2926         * inspector/InspectorDebuggerAgent.h:
2927         * inspector/InspectorRuntimeAgent.cpp:
2928         (WebCore::InspectorRuntimeAgent::create):
2929         (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
2930         (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
2931         (WebCore::InspectorRuntimeAgent::evaluate):
2932         (WebCore::InspectorRuntimeAgent::evaluateOn):
2933         (WebCore::InspectorRuntimeAgent::getProperties):
2934         (WebCore::InspectorRuntimeAgent::setPropertyValue):
2935         (WebCore::InspectorRuntimeAgent::releaseObject):
2936         (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
2937         * inspector/InspectorRuntimeAgent.h:
2938         * inspector/front-end/ElementsPanel.js:
2939         (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
2940         (WebInspector.ElementsPanel):
2941
2942 2011-03-11  Anton Muhin  <antonm@chromium.org>
2943
2944         Reviewed by Adam Barth.
2945
2946         [v8] Change the way group id for CSS objects is calculated
2947         https://bugs.webkit.org/show_bug.cgi?id=56117
2948
2949         Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
2950         as they should not be reachable in JavaScript.
2951
2952         Covered by existing layout tests.  Fact of absence of retention is not trivial to prove.
2953
2954         * bindings/v8/V8GCController.cpp:
2955         (WebCore::calculateGroupId):
2956         (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
2957
2958 2011-03-11  Alexander Pavlov  <apavlov@chromium.org>
2959
2960         Reviewed by Yury Semikhatsky.
2961
2962         Web Inspector: hover over elements in Elements panel does not highlight nodes
2963         https://bugs.webkit.org/show_bug.cgi?id=56121
2964
2965         In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
2966         is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
2967         for these 16px when computing the test point coordinates.
2968
2969         * inspector/front-end/ElementsTreeOutline.js:
2970         (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
2971
2972 2011-03-11  Yury Semikhatsky  <yurys@chromium.org>
2973
2974         Unreviewed. Roll out r80837.
2975
2976         * CMakeLists.txt:
2977         * GNUmakefile.am:
2978         * WebCore.gypi:
2979         * WebCore.pro:
2980         * WebCore.vcproj/WebCore.vcproj:
2981         * WebCore.xcodeproj/project.pbxproj:
2982         * bindings/js/JSInjectedScriptHostCustom.cpp:
2983         (WebCore::InjectedScriptHost::createInjectedScript):
2984         (WebCore::InjectedScriptHost::discardInjectedScript):
2985         (WebCore::InjectedScriptHost::injectedScriptFor):
2986         (WebCore::InjectedScriptHost::canAccessInspectedWindow):
2987         * bindings/js/JSInjectedScriptManager.cpp: Removed.
2988         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2989         (WebCore::WeakReferenceCallback):
2990         (WebCore::createInjectedScriptHostV8Wrapper):
2991         (WebCore::InjectedScriptHost::createInjectedScript):
2992         (WebCore::InjectedScriptHost::discardInjectedScript):
2993         (WebCore::InjectedScriptHost::injectedScriptFor):
2994         (WebCore::InjectedScriptHost::canAccessInspectedWindow):
2995         * bindings/v8/custom/V8InjectedScriptManager.cpp: Removed.
2996         * inspector/ConsoleMessage.cpp:
2997         (WebCore::ConsoleMessage::addToFrontend):
2998         * inspector/ConsoleMessage.h:
2999         * inspector/InjectedScript.cpp:
3000         (WebCore::InjectedScript::canAccessInspectedWindow):
3001         * inspector/InjectedScript.h:
3002         * inspector/InjectedScriptHost.cpp:
3003         (WebCore::InjectedScriptHost::InjectedScriptHost):
3004         (WebCore::InjectedScriptHost::~InjectedScriptHost):
3005         (WebCore::InjectedScriptHost::inspectImpl):
3006         (WebCore::InjectedScriptHost::clearConsoleMessages):
3007         (WebCore::InjectedScriptHost::databaseIdImpl):
3008         (WebCore::InjectedScriptHost::storageIdImpl):
3009         (WebCore::InjectedScriptHost::injectedScriptForId):
3010         (WebCore::InjectedScriptHost::injectedScriptForObjectId):
3011         (WebCore::InjectedScriptHost::injectedScriptForMainFrame):
3012         (WebCore::InjectedScriptHost::discardInjectedScripts):
3013         (WebCore::InjectedScriptHost::releaseObjectGroup):
3014         (WebCore::InjectedScriptHost::frontend):
3015         (WebCore::InjectedScriptHost::injectedScriptSource):
3016         (WebCore::InjectedScriptHost::injectScript):
3017         * inspector/InjectedScriptHost.h:
3018         (WebCore::InjectedScriptHost::create):
3019         (WebCore::InjectedScriptHost::inspectorAgent):
3020         (WebCore::InjectedScriptHost::disconnectController):
3021         * inspector/InjectedScriptManager.cpp: Removed.
3022         * inspector/InjectedScriptManager.h: Removed.
3023         * inspector/Inspector.idl:
3024         * inspector/InspectorAgent.cpp:
3025         (WebCore::InspectorAgent::InspectorAgent):
3026         (WebCore::InspectorAgent::inspectedPageDestroyed):
3027         (WebCore::InspectorAgent::focusNode):
3028         (WebCore::InspectorAgent::didClearWindowObjectInWorld):
3029         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
3030         (WebCore::InspectorAgent::didCommitLoad):
3031         (WebCore::InspectorAgent::domContentLoadedEventFired):
3032         * inspector/InspectorAgent.h:
3033         (WebCore::InspectorAgent::injectedScriptHost):
3034         * inspector/InspectorBrowserDebuggerAgent.cpp:
3035         * inspector/InspectorConsoleAgent.cpp:
3036         (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
3037         (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
3038         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
3039         (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
3040         (WebCore::InspectorConsoleAgent::addConsoleMessage):
3041         * inspector/InspectorConsoleAgent.h:
3042         * inspector/InspectorController.cpp:
3043         (WebCore::InspectorController::InspectorController):
3044         (WebCore::InspectorController::connectFrontend):
3045         (WebCore::InspectorController::disconnectFrontend):
3046         * inspector/InspectorController.h:
3047         * inspector/InspectorDOMAgent.cpp:
3048         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
3049         (WebCore::InspectorDOMAgent::discardBindings):
3050         (WebCore::InspectorDOMAgent::addInspectedNode):
3051         (WebCore::InspectorDOMAgent::pushNodeToFrontend):
3052         (WebCore::InspectorDOMAgent::resolveNode):
3053         * inspector/InspectorDOMAgent.h:
3054         (WebCore::InspectorDOMAgent::create):
3055         * inspector/InspectorDebuggerAgent.cpp:
3056         (WebCore::InspectorDebuggerAgent::create):
3057         (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
3058         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
3059         (WebCore::InspectorDebuggerAgent::currentCallFrames):
3060         * inspector/InspectorDebuggerAgent.h:
3061         * inspector/InspectorRuntimeAgent.cpp:
3062         (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
3063         (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
3064         (WebCore::InspectorRuntimeAgent::evaluate):
3065         (WebCore::InspectorRuntimeAgent::evaluateOn):
3066         (WebCore::InspectorRuntimeAgent::getProperties):
3067         (WebCore::InspectorRuntimeAgent::setPropertyValue):
3068         (WebCore::InspectorRuntimeAgent::releaseObject):
3069         (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
3070         * inspector/InspectorRuntimeAgent.h:
3071         (WebCore::InspectorRuntimeAgent::create):
3072         * inspector/front-end/ElementsPanel.js:
3073         (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
3074         (WebInspector.ElementsPanel):
3075
3076 2011-03-11  Yury Semikhatsky  <yurys@chromium.org>
3077
3078         Reviewed by Pavel Feldman.
3079
3080         Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
3081         https://bugs.webkit.org/show_bug.cgi?id=56173
3082
3083         Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.
3084
3085         * CMakeLists.txt:
3086         * GNUmakefile.am:
3087         * WebCore.gypi:
3088         * WebCore.pro:
3089         * WebCore.vcproj/WebCore.vcproj:
3090         * WebCore.xcodeproj/project.pbxproj:
3091         * bindings/js/JSInjectedScriptHostCustom.cpp:
3092         * bindings/js/JSInjectedScriptManager.cpp: Added.
3093         (WebCore::InjectedScriptManager::createInjectedScript):
3094         (WebCore::InjectedScriptManager::discardInjectedScript):
3095         (WebCore::InjectedScriptManager::injectedScriptFor):
3096         (WebCore::InjectedScriptManager::canAccessInspectedWindow):
3097         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
3098         * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
3099         (WebCore::WeakReferenceCallback):
3100         (WebCore::createInjectedScriptHostV8Wrapper):
3101         (WebCore::InjectedScriptManager::createInjectedScript):
3102         (WebCore::InjectedScriptManager::discardInjectedScript):
3103         (WebCore::InjectedScriptManager::injectedScriptFor):
3104         (WebCore::InjectedScriptManager::canAccessInspectedWindow):
3105         * inspector/ConsoleMessage.cpp:
3106         (WebCore::ConsoleMessage::addToFrontend):
3107         * inspector/ConsoleMessage.h:
3108         * inspector/InjectedScript.cpp:
3109         (WebCore::InjectedScript::canAccessInspectedWindow):
3110         * inspector/InjectedScript.h:
3111         * inspector/InjectedScriptHost.cpp:
3112         (WebCore::InjectedScriptHost::create):
3113         (WebCore::InjectedScriptHost::InjectedScriptHost):
3114         (WebCore::InjectedScriptHost::~InjectedScriptHost):
3115         (WebCore::InjectedScriptHost::disconnect):
3116         (WebCore::InjectedScriptHost::inspectImpl):
3117         (WebCore::InjectedScriptHost::clearConsoleMessages):
3118         (WebCore::InjectedScriptHost::databaseIdImpl):
3119         (WebCore::InjectedScriptHost::storageIdImpl):
3120         * inspector/InjectedScriptHost.h:
3121         (WebCore::InjectedScriptHost::init):
3122         (WebCore::InjectedScriptHost::setFrontend):
3123         (WebCore::InjectedScriptHost::clearFrontend):
3124         * inspector/InjectedScriptManager.cpp: Added.
3125         (WebCore::InjectedScriptManager::create):
3126         (WebCore::InjectedScriptManager::InjectedScriptManager):
3127         (WebCore::InjectedScriptManager::~InjectedScriptManager):
3128         (WebCore::InjectedScriptManager::disconnect):
3129         (WebCore::InjectedScriptManager::injectedScriptHost):
3130         (WebCore::InjectedScriptManager::injectedScriptForId):
3131         (WebCore::InjectedScriptManager::injectedScriptForObjectId):
3132         (WebCore::InjectedScriptManager::discardInjectedScripts):
3133         (WebCore::InjectedScriptManager::releaseObjectGroup):
3134         (WebCore::InjectedScriptManager::injectedScriptSource):
3135         (WebCore::InjectedScriptManager::injectScript):
3136         * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
3137         * inspector/Inspector.idl:
3138         * inspector/InspectorAgent.cpp:
3139         (WebCore::InspectorAgent::InspectorAgent):
3140         (WebCore::InspectorAgent::inspectedPageDestroyed):
3141         (WebCore::InspectorAgent::focusNode):
3142         (WebCore::InspectorAgent::didClearWindowObjectInWorld):
3143         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
3144         (WebCore::InspectorAgent::didCommitLoad):
3145         (WebCore::InspectorAgent::domContentLoadedEventFired):
3146         * inspector/InspectorAgent.h:
3147         * inspector/InspectorBrowserDebuggerAgent.cpp:
3148         * inspector/InspectorConsoleAgent.cpp:
3149         (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
3150         (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
3151         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
3152         (WebCore::InspectorConsoleAgent::addInspectedNode):
3153         (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
3154         (WebCore::InspectorConsoleAgent::addConsoleMessage):
3155         * inspector/InspectorConsoleAgent.h:
3156         * inspector/InspectorController.cpp:
3157         (WebCore::InspectorController::InspectorController):
3158         (WebCore::InspectorController::connectFrontend):
3159         (WebCore::InspectorController::disconnectFrontend):
3160         * inspector/InspectorController.h:
3161         * inspector/InspectorDOMAgent.cpp:
3162         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
3163         (WebCore::InspectorDOMAgent::discardBindings):
3164         (WebCore::InspectorDOMAgent::pushNodeToFrontend):
3165         (WebCore::InspectorDOMAgent::resolveNode):
3166         * inspector/InspectorDOMAgent.h:
3167         (WebCore::InspectorDOMAgent::create):
3168         * inspector/InspectorDebuggerAgent.cpp:
3169         (WebCore::InspectorDebuggerAgent::create):
3170         (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
3171         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
3172         (WebCore::InspectorDebuggerAgent::currentCallFrames):
3173         * inspector/InspectorDebuggerAgent.h:
3174         * inspector/InspectorRuntimeAgent.cpp:
3175         (WebCore::InspectorRuntimeAgent::create):
3176         (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
3177         (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
3178         (WebCore::InspectorRuntimeAgent::evaluate):
3179         (WebCore::InspectorRuntimeAgent::evaluateOn):
3180         (WebCore::InspectorRuntimeAgent::getProperties):
3181         (WebCore::InspectorRuntimeAgent::setPropertyValue):
3182         (WebCore::InspectorRuntimeAgent::releaseObject):
3183         (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
3184         * inspector/InspectorRuntimeAgent.h:
3185         * inspector/front-end/ElementsPanel.js:
3186         (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
3187         (WebInspector.ElementsPanel):
3188
3189 2011-03-09  Hans Wennborg  <hans@chromium.org>
3190
3191         Reviewed by Jeremy Orlow.
3192
3193         IndexedDB: Make IDBBackingStore abstract
3194         https://bugs.webkit.org/show_bug.cgi?id=56013
3195
3196         Make IDBBackingStore abstract to allow for multiple implementations.
3197         Move the SQLite implementation to IDBSQLiteBackingStore.
3198
3199         No new tests: refactoring only.
3200
3201         * WebCore.gypi:
3202         * storage/IDBBackingStore.h:
3203         (WebCore::IDBBackingStore::~IDBBackingStore):
3204         * storage/IDBFactoryBackendImpl.cpp:
3205         (WebCore::IDBFactoryBackendImpl::open):
3206         * storage/IDBSQLiteBackingStore.cpp:
3207         (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
3208         (WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore):
3209         (WebCore::runCommands):
3210         (WebCore::createTables):
3211         (WebCore::createMetaDataTable):
3212         (WebCore::getDatabaseSchemaVersion):
3213         (WebCore::migrateDatabase):
3214         (WebCore::IDBSQLiteBackingStore::open):
3215         (WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData):
3216         (WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData):
3217         (WebCore::IDBSQLiteBackingStore::getObjectStores):
3218         (WebCore::IDBSQLiteBackingStore::createObjectStore):
3219         (WebCore::doDelete):
3220         (WebCore::IDBSQLiteBackingStore::deleteObjectStore):
3221         (WebCore::whereSyntaxForKey):
3222         (WebCore::bindKeyToQuery):
3223         (WebCore::lowerCursorWhereFragment):
3224         (WebCore::upperCursorWhereFragment):
3225         (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
3226         (WebCore::bindKeyToQueryWithNulls):
3227         (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
3228         (WebCore::IDBSQLiteBackingStore::clearObjectStore):
3229         (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
3230         (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
3231         (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
3232         (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
3233         (WebCore::IDBSQLiteBackingStore::getIndexes):
3234         (WebCore::IDBSQLiteBackingStore::createIndex):
3235         (WebCore::IDBSQLiteBackingStore::deleteIndex):
3236         (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
3237         (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
3238         (WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
3239         (WebCore::keyFromQuery):
3240         (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
3241         (WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
3242         (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
3243         (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
3244         (WebCore::IDBSQLiteBackingStore::openIndexCursor):
3245         (WebCore::IDBSQLiteBackingStore::createTransaction):
3246         * storage/IDBSQLiteBackingStore.h: Added.
3247
3248 2011-03-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3249
3250         Unreviewed build error fix.
3251
3252         [EFL] Fix build break when SHARED_CORE is ON
3253         https://bugs.webkit.org/show_bug.cgi?id=56155
3254
3255         * platform/efl/ContextMenuEfl.cpp:
3256         (WebCore::ContextMenu::ContextMenu):
3257         * platform/efl/ContextMenuItemEfl.cpp:
3258         (WebCore::ContextMenuItem::nativeMenuItem):
3259         (WebCore::ContextMenuItem::ContextMenuItem):
3260         (WebCore::ContextMenuItem::~ContextMenuItem):
3261
3262 2011-03-11  Andrey Kosyakov  <caseq@chromium.org>
3263
3264         Reviewed by Pavel Feldman.
3265
3266         Web Inspector: resource load cancellation is reported to console as an error
3267         https://bugs.webkit.org/show_bug.cgi?id=55764
3268
3269         - mark interruptionForPolicyChangeError as cancellation
3270         - do not log resource cancelation as an error
3271         - always push resource to front-end before console message, so front-end can use resource info while formatting message.
3272
3273         * inspector/InspectorConsoleAgent.cpp:
3274         (WebCore::InspectorConsoleAgent::didFailLoading):
3275         * inspector/InspectorInstrumentation.cpp:
3276         (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
3277         (WebCore::InspectorInstrumentation::didFailLoadingImpl):
3278         * loader/MainResourceLoader.cpp:
3279         (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
3280
3281 2011-03-10  Alexander Pavlov  <apavlov@chromium.org>
3282
3283         Reviewed by Yury Semikhatsky.
3284
3285         Web Inspector: Get rid of has/add/removeStyleClass() methods on Element.prototype - Step 1
3286         https://bugs.webkit.org/show_bug.cgi?id=56096
3287
3288         No new tests, as this is a refactoring.
3289
3290         * inspector/front-end/BreakpointsSidebarPane.js:
3291         (WebInspector.EventListenerBreakpointsSidebarPane):
3292         * inspector/front-end/DetailedHeapshotView.js:
3293         * inspector/front-end/ResourcesPanel.js:
3294         (WebInspector.ResourcesPanel):
3295         (WebInspector.BaseStorageTreeElement):
3296         (WebInspector.BaseStorageTreeElement.prototype.onattach):
3297         (WebInspector.StorageCategoryTreeElement):
3298         (WebInspector.FrameTreeElement):
3299         (WebInspector.FrameResourceTreeElement):
3300         (WebInspector.DatabaseTreeElement):
3301         (WebInspector.DatabaseTableTreeElement):
3302         (WebInspector.DOMStorageTreeElement):
3303         (WebInspector.CookieTreeElement):
3304         (WebInspector.ApplicationCacheTreeElement):
3305         (WebInspector.ResourceRevisionTreeElement):
3306         * inspector/front-end/utilities.js:
3307         (Element.prototype.removeStyleClass):
3308         (Element.prototype.addStyleClass):
3309         (Element.prototype.hasStyleClass):
3310
3311 2011-03-11  Brian Salomon  <bsalomon@google.com>
3312
3313         Reviewed by Kenneth Russell.
3314
3315         Adds GrContext flush call to PlatformContextSkia destructor. 
3316 Calls GrContext flush with int parameter instead of bool due to skia 
3317 revision.       
3318
3319         No new tests needed.
3320
3321         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3322         (WebCore::DrawingBuffer::publishToPlatformLayer):
3323         * platform/graphics/skia/PlatformContextSkia.cpp:
3324         (WebCore::PlatformContextSkia::~PlatformContextSkia):
3325         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
3326
3327 2011-03-10  Chris Guillory  <chris.guillory@google.com>
3328
3329         Reviewed by James Robinson.
3330
3331         Fix for Coverity discovered NO_EFFECT (self-assign) defect.
3332         https://bugs.webkit.org/show_bug.cgi?id=54143
3333
3334         * platform/graphics/gpu/TilingData.cpp:
3335         (WebCore::TilingData::setMaxTextureSize):
3336
3337 2011-03-10  Emil A Eklund  <eae@chromium.org>
3338
3339         Reviewed by Alexey Proskuryakov.
3340
3341         The web colours palevioletred and mediumpurple are incorrect
3342         https://bugs.webkit.org/show_bug.cgi?id=46658
3343
3344         Changed value for the palevioletred and mediumpurple colors to match
3345         the css3 specification.
3346
3347         Test: fast/css/named-colors.html
3348
3349         * inspector/front-end/Color.js:
3350         * platform/ColorData.gperf:
3351
3352 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3353
3354         Unreviewed build fix.
3355
3356         [WML] Fix build error
3357         https://bugs.webkit.org/show_bug.cgi?id=56078
3358
3359         * wml/WMLInputElement.cpp:
3360         (WebCore::WMLInputElement::defaultEventHandler):
3361
3362 2011-03-10  Jeremy Moskovich  <jeremy@chromium.org>
3363
3364         Reviewed by Darin Adler.
3365
3366         Fix navigation menus on a bunch of sites in WebKit.
3367         https://bugs.webkit.org/show_bug.cgi?id=52535
3368
3369         WebKit doesn't support position:relative for several table elements and
3370         overwrites the style internally when position:relative is encountered.
3371         Unfortunately position:relative affects the choice of nodes returned by
3372         offsetParent.
3373
3374         This CL adds a bit to RenderStyle to track whether position:relative was
3375         overwritten.  The value is then consulted in offsetParent which makes us
3376         match FF/IE.
3377
3378         Tests: fast/block/positioning/offsetLeft-relative-iframe.html
3379                fast/block/positioning/offsetLeft-relative-td.html
3380
3381         * css/CSSStyleSelector.cpp:
3382         (WebCore::CSSStyleSelector::adjustRenderStyle):
3383         * rendering/RenderObject.cpp:
3384         (WebCore::RenderObject::isOriginallyRelPositioned):
3385         (WebCore::RenderObject::offsetParent):
3386         * rendering/RenderObject.h:
3387         * rendering/style/RenderStyle.h: Add a bit to track the original value of position:relative.
3388         (WebCore::InheritedFlags::positionWasRelative):
3389         (WebCore::InheritedFlags::setPositionWasRelative):
3390         * rendering/style/StyleRareNonInheritedData.cpp:
3391         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3392         (WebCore::StyleRareNonInheritedData::operator==):
3393         * rendering/style/StyleRareNonInheritedData.h:
3394
3395 2011-03-10  Adam Barth  <abarth@webkit.org>
3396
3397         Reviewed by Darin Adler.
3398
3399         REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel()
3400         https://bugs.webkit.org/show_bug.cgi?id=51357
3401
3402         Previously, we would try to print from a callstack that didn't want a
3403         nested event loop, leading to re-entrancy problems.  In this patch, we
3404         complete the print call asynchronously, giving us a clean stack on
3405         which to run the nested event loop.
3406
3407         Test: printing/print-close-crash.html
3408
3409         * page/DOMWindow.cpp:
3410         (WebCore::DOMWindow::DOMWindow):
3411         (WebCore::DOMWindow::print):
3412         (WebCore::DOMWindow::printTimerFired):
3413         * page/DOMWindow.h:
3414
3415 2011-03-11  Roland Steiner  <rolandsteiner@chromium.org>
3416
3417         Reviewed by Ryosuke Niwa.
3418
3419         Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
3420         https://bugs.webkit.org/show_bug.cgi?id=55570
3421
3422         Add a virtual function toInputElement() to Node that has a default
3423         implementation of returning 0.
3424         For HTMLInputElement and WMLInputElement (which derive from InputElement)
3425         override this to return the object.
3426         Change all calling sites of the old toInputElement to use the new member
3427         function. This also allows us to save some casts.
3428
3429         No new tests. (refactoring)
3430
3431         * WebCore.exp.in:
3432         * accessibility/AXObjectCache.cpp:
3433         (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
3434         * accessibility/AccessibilityRenderObject.cpp:
3435         (WebCore::AccessibilityRenderObject::isPasswordField):
3436         (WebCore::AccessibilityRenderObject::isIndeterminate):
3437         (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
3438         (WebCore::AccessibilityRenderObject::isChecked):
3439         * css/CSSStyleSelector.cpp:
3440         (WebCore::CSSStyleSelector::canShareStyleWithElement):
3441         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
3442         * dom/CheckedRadioButtons.cpp:
3443         (WebCore::CheckedRadioButtons::removeButton):
3444         * dom/InputElement.cpp:
3445         * dom/InputElement.h:
3446         * dom/Node.cpp:
3447         (WebCore::Node::toInputElement):
3448         * dom/Node.h:
3449         * html/HTMLInputElement.h:
3450         (WebCore::HTMLInputElement::toInputElement):
3451         * rendering/RenderTextControlSingleLine.cpp:
3452         (WebCore::RenderTextControlSingleLine::inputElement):
3453         * rendering/RenderTheme.cpp:
3454         (WebCore::RenderTheme::isChecked):
3455         (WebCore::RenderTheme::isIndeterminate):
3456         * wml/WMLInputElement.h:
3457         (WebCore::WMLInputElement::toInputElement):
3458
3459 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3460
3461         Reviewed by Kenneth Rohde Christiansen.
3462
3463         [EFL] New mediaControl css file for EFL
3464         https://bugs.webkit.org/show_bug.cgi?id=55460
3465
3466         Add new mediaControl css file for html5 video UI.
3467
3468         * CMakeLists.txt:
3469         * CMakeListsEfl.txt:
3470         * css/mediaControlsEfl.css: Added.
3471         (audio):
3472