[LFC] Miscellaneous fixes to fix simple absolute positioning.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2018-06-23  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC] Miscellaneous fixes to fix simple absolute positioning.
4         https://bugs.webkit.org/show_bug.cgi?id=186962
5
6         Reviewed by Antti Koivisto.
7
8         1. Collect out-of-flow formatting root descendants.
9         2. Remove invalid and redundant ASSERTs
10           invalid because the assertion is missing border, padding etc.
11           redundant becasue we assert on geometry correctness in validateGeometryConstraintsAfterLayout.  
12
13         * layout/FormattingContext.cpp:
14         (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
15         (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
16         (WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
17         * layout/layouttree/LayoutContainer.cpp:
18         (WebCore::Layout::Container::addOutOfFlowDescendant):
19         (WebCore::Layout::Container::setOutOfFlowDescendants): Deleted.
20         * layout/layouttree/LayoutContainer.h:
21         * layout/layouttree/LayoutTreeBuilder.cpp:
22         (WebCore::Layout::TreeBuilder::createSubTree):
23
24 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
25
26         [WTF] Add user-defined literal for ASCIILiteral
27         https://bugs.webkit.org/show_bug.cgi?id=186839
28
29         Reviewed by Darin Adler.
30
31         No behavior change.
32
33         * Modules/applicationmanifest/ApplicationManifestParser.cpp:
34         (WebCore::ApplicationManifestParser::parseManifest):
35         (WebCore::ApplicationManifestParser::logManifestPropertyNotAString):
36         (WebCore::ApplicationManifestParser::logManifestPropertyInvalidURL):
37         (WebCore::ApplicationManifestParser::logDeveloperWarning):
38         (WebCore::ApplicationManifestParser::parseStartURL):
39         (WebCore::ApplicationManifestParser::parseDisplay):
40         (WebCore::ApplicationManifestParser::parseName):
41         (WebCore::ApplicationManifestParser::parseDescription):
42         (WebCore::ApplicationManifestParser::parseShortName):
43         (WebCore::ApplicationManifestParser::parseScope):
44         * Modules/beacon/NavigatorBeacon.cpp:
45         (WebCore::NavigatorBeacon::logError):
46         (WebCore::NavigatorBeacon::sendBeacon):
47         * Modules/cache/DOMCache.cpp:
48         (WebCore::DOMCache::requestFromInfo):
49         (WebCore::DOMCache::addAll):
50         (WebCore::DOMCache::put):
51         * Modules/cache/DOMCacheEngine.cpp:
52         (WebCore::DOMCacheEngine::errorToException):
53         * Modules/credentialmanagement/BasicCredential.cpp:
54         (WebCore::BasicCredential::type const):
55         * Modules/credentialmanagement/CredentialsContainer.cpp:
56         (WebCore::CredentialsContainer::get):
57         (WebCore::CredentialsContainer::store):
58         (WebCore::CredentialsContainer::isCreate):
59         (WebCore::CredentialsContainer::preventSilentAccess const):
60         * Modules/entriesapi/DOMFileSystem.cpp:
61         (WebCore::DOMFileSystem::root):
62         (WebCore::validatePathIsExpectedType):
63         (WebCore::resolveRelativeVirtualPath):
64         (WebCore::DOMFileSystem::getEntry):
65         * Modules/entriesapi/FileSystemDirectoryEntry.cpp:
66         (WebCore::FileSystemDirectoryEntry::getEntry):
67         * Modules/entriesapi/FileSystemDirectoryReader.cpp:
68         (WebCore::FileSystemDirectoryReader::readEntries):
69         * Modules/fetch/FetchBody.cpp:
70         (WebCore::FetchBody::consumeAsStream):
71         * Modules/fetch/FetchBodyConsumer.cpp:
72         (WebCore::FetchBodyConsumer::loadingFailed):
73         * Modules/fetch/FetchBodyOwner.cpp:
74         (WebCore::FetchBodyOwner::arrayBuffer):
75         (WebCore::FetchBodyOwner::blob):
76         (WebCore::FetchBodyOwner::consumeOnceLoadingFinished):
77         (WebCore::FetchBodyOwner::formData):
78         (WebCore::FetchBodyOwner::json):
79         (WebCore::FetchBodyOwner::text):
80         (WebCore::FetchBodyOwner::blobLoadingFailed):
81         (WebCore::FetchBodyOwner::consumeBodyAsStream):
82         * Modules/fetch/FetchHeaders.cpp:
83         (WebCore::canWriteHeader):
84         * Modules/fetch/FetchLoader.cpp:
85         (WebCore::FetchLoader::startLoadingBlobURL):
86         (WebCore::FetchLoader::start):
87         * Modules/fetch/FetchRequest.cpp:
88         (WebCore::setMethod):
89         (WebCore::computeReferrer):
90         (WebCore::buildOptions):
91         (WebCore::FetchRequest::initializeOptions):
92         (WebCore::FetchRequest::initializeWith):
93         (WebCore::FetchRequest::setBody):
94         (WebCore::FetchRequest::referrer const):
95         (WebCore::FetchRequest::clone):
96         * Modules/fetch/FetchResponse.cpp:
97         (WebCore::FetchResponse::create):
98         (WebCore::FetchResponse::redirect):
99         (WebCore::FetchResponse::clone):
100         (WebCore::FetchResponse::BodyLoader::didFail):
101         * Modules/fetch/FetchResponse.h:
102         * Modules/geolocation/GeoNotifier.cpp:
103         (WebCore::GeoNotifier::timerFired):
104         * Modules/geolocation/Geolocation.cpp:
105         (WebCore::Geolocation::startRequest):
106         (WebCore::Geolocation::requestUsesCachedPosition):
107         (WebCore::Geolocation::makeCachedPositionCallbacks):
108         (WebCore::Geolocation::setIsAllowed):
109         (WebCore::Geolocation::cancelRequests):
110         (WebCore::Geolocation::handlePendingPermissionNotifiers):
111         * Modules/indexeddb/IDBCursor.cpp:
112         (WebCore::IDBCursor::update):
113         (WebCore::IDBCursor::advance):
114         (WebCore::IDBCursor::continuePrimaryKey):
115         (WebCore::IDBCursor::continueFunction):
116         (WebCore::IDBCursor::deleteFunction):
117         * Modules/indexeddb/IDBDatabase.cpp:
118         (WebCore::IDBDatabase::createObjectStore):
119         (WebCore::IDBDatabase::transaction):
120         (WebCore::IDBDatabase::deleteObjectStore):
121         * Modules/indexeddb/IDBFactory.cpp:
122         (WebCore::IDBFactory::open):
123         (WebCore::IDBFactory::openInternal):
124         (WebCore::IDBFactory::deleteDatabase):
125         (WebCore::IDBFactory::cmp):
126         * Modules/indexeddb/IDBIndex.cpp:
127         (WebCore::IDBIndex::setName):
128         (WebCore::IDBIndex::openCursor):
129         (WebCore::IDBIndex::openKeyCursor):
130         (WebCore::IDBIndex::count):
131         (WebCore::IDBIndex::doCount):
132         (WebCore::IDBIndex::get):
133         (WebCore::IDBIndex::doGet):
134         (WebCore::IDBIndex::getKey):
135         (WebCore::IDBIndex::doGetKey):
136         (WebCore::IDBIndex::getAll):
137         (WebCore::IDBIndex::getAllKeys):
138         * Modules/indexeddb/IDBKeyData.cpp:
139         (WebCore::IDBKeyData::loggingString const):
140         * Modules/indexeddb/IDBKeyRangeData.cpp:
141         (WebCore::IDBKeyRangeData::loggingString const):
142         * Modules/indexeddb/IDBObjectStore.cpp:
143         (WebCore::IDBObjectStore::setName):
144         (WebCore::IDBObjectStore::openCursor):
145         (WebCore::IDBObjectStore::openKeyCursor):
146         (WebCore::IDBObjectStore::get):
147         (WebCore::IDBObjectStore::getKey):
148         (WebCore::IDBObjectStore::putOrAdd):
149         (WebCore::IDBObjectStore::doDelete):
150         (WebCore::IDBObjectStore::deleteFunction):
151         (WebCore::IDBObjectStore::clear):
152         (WebCore::IDBObjectStore::createIndex):
153         (WebCore::IDBObjectStore::index):
154         (WebCore::IDBObjectStore::deleteIndex):
155         (WebCore::IDBObjectStore::count):
156         (WebCore::IDBObjectStore::doCount):
157         (WebCore::IDBObjectStore::getAll):
158         (WebCore::IDBObjectStore::getAllKeys):
159         * Modules/indexeddb/IDBRequest.cpp:
160         (WebCore::IDBRequest::result const):
161         (WebCore:: const):
162         (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
163         * Modules/indexeddb/IDBTransaction.cpp:
164         (WebCore::IDBTransaction::objectStore):
165         (WebCore::IDBTransaction::abort):
166         (WebCore::IDBTransaction::putOrAddOnServer):
167         * Modules/indexeddb/server/IDBServer.cpp:
168         (WebCore::IDBServer::IDBServer::performGetAllDatabaseNames):
169         * Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
170         (WebCore::IDBServer::MemoryIDBBackingStore::deleteRange):
171         (WebCore::IDBServer::MemoryIDBBackingStore::addRecord):
172         (WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
173         (WebCore::IDBServer::MemoryIDBBackingStore::getAllRecords):
174         (WebCore::IDBServer::MemoryIDBBackingStore::getIndexRecord):
175         (WebCore::IDBServer::MemoryIDBBackingStore::getCount):
176         (WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
177         (WebCore::IDBServer::MemoryIDBBackingStore::iterateCursor):
178         * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
179         (WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
180         (WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
181         (WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromEncodedFilename):
182         (WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
183         (WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
184         (WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
185         (WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
186         (WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
187         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
188         (WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
189         (WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
190         (WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
191         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
192         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
193         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
194         (WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
195         (WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
196         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteUnusedBlobFileRecords):
197         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
198         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
199         (WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
200         (WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
201         (WebCore::IDBServer::SQLiteIDBBackingStore::getBlobRecordsForObjectStoreRecord):
202         (WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
203         (WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
204         (WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
205         (WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
206         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
207         (WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
208         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
209         (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
210         (WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
211         (WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
212         (WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
213         (WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
214         (WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
215         (WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
216         * Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
217         (WebCore::IDBServer::SQLiteIDBTransaction::begin):
218         (WebCore::IDBServer::SQLiteIDBTransaction::commit):
219         (WebCore::IDBServer::SQLiteIDBTransaction::abort):
220         * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
221         (WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
222         (WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
223         (WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
224         (WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
225         (WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
226         (WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
227         (WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
228         * Modules/indexeddb/shared/IDBError.h:
229         (WebCore::IDBError::userDeleteError):
230         * Modules/indexeddb/shared/IDBTransactionInfo.cpp:
231         (WebCore::IDBTransactionInfo::loggingString const):
232         * Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
233         (WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):
234         * Modules/mediastream/PeerConnectionBackend.cpp:
235         (WebCore::PeerConnectionBackend::addIceCandidate):
236         * Modules/mediastream/UserMediaRequest.cpp:
237         (WebCore::UserMediaRequest::deny):
238         * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
239         (WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):
240         * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
241         (WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate):
242         * Modules/paymentrequest/PaymentRequest.cpp:
243         (WebCore::checkAndCanonicalizeTotal):
244         (WebCore::PaymentRequest::create):
245         * Modules/quota/DOMWindowQuota.cpp:
246         (WebCore::DOMWindowQuota::webkitStorageInfo const):
247         * Modules/webaudio/AudioBufferSourceNode.cpp:
248         (WebCore::AudioBufferSourceNode::looping):
249         (WebCore::AudioBufferSourceNode::setLooping):
250         * Modules/webaudio/AudioNode.cpp:
251         (WebCore::AudioNode::channelCountMode):
252         (WebCore::AudioNode::channelInterpretation):
253         * Modules/webaudio/MediaStreamAudioSource.cpp:
254         (WebCore::MediaStreamAudioSource::MediaStreamAudioSource):
255         * Modules/webauthn/AuthenticatorManager.cpp:
256         (WebCore::AuthenticatorManagerInternal::produceClientDataJson):
257         (WebCore::AuthenticatorManagerInternal::initTimeoutTimer):
258         (WebCore::AuthenticatorManager::create const):
259         (WebCore::AuthenticatorManager::discoverFromExternalSource const):
260         (WebCore::AuthenticatorManager::isUserVerifyingPlatformAuthenticatorAvailable const):
261         * Modules/webauthn/cocoa/LocalAuthenticator.mm:
262         (WebCore::LocalAuthenticator::makeCredential):
263         (WebCore::LocalAuthenticator::getAssertion):
264         * Modules/webdatabase/DatabaseTracker.cpp:
265         (WebCore::DatabaseTracker::usage):
266         * Modules/websockets/WebSocket.cpp:
267         (WebCore::WebSocket::connect):
268         (WebCore::WebSocket::close):
269         (WebCore::WebSocket::binaryType const):
270         * Modules/websockets/WebSocketHandshake.cpp:
271         (WebCore::WebSocketHandshake::readStatusLine):
272         (WebCore::WebSocketHandshake::readHTTPHeaders):
273         (WebCore::WebSocketHandshake::checkResponseHeaders):
274         * Modules/webvr/VRDisplay.cpp:
275         (WebCore::VRDisplay::requestPresent):
276         (WebCore::VRDisplay::exitPresent):
277         * accessibility/AccessibilityObject.cpp:
278         (WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
279         (WebCore::AccessibilityObject::invalidStatus const):
280         * accessibility/AccessibilityRenderObject.cpp:
281         (WebCore::AccessibilityRenderObject::textUnderElement const):
282         * bindings/js/JSCustomElementInterface.cpp:
283         (WebCore::constructCustomElementSynchronously):
284         * bindings/js/JSCustomElementRegistryCustom.cpp:
285         (WebCore::getCustomElementCallback):
286         (WebCore::validateCustomElementNameAndThrowIfNeeded):
287         (WebCore::JSCustomElementRegistry::define):
288         * bindings/js/JSCustomXPathNSResolver.cpp:
289         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
290         * bindings/js/JSDOMConstructorBase.cpp:
291         (WebCore::callThrowTypeError):
292         * bindings/js/JSDOMConstructorBase.h:
293         (WebCore::JSDOMConstructorBase::className):
294         * bindings/js/JSDOMConstructorNotConstructable.h:
295         (WebCore::JSDOMConstructorNotConstructable::callThrowTypeError):
296         * bindings/js/JSDOMExceptionHandling.cpp:
297         (WebCore::createDOMException):
298         (WebCore::throwSequenceTypeError):
299         (WebCore::throwNonFiniteTypeError):
300         * bindings/js/JSDOMIterator.h:
301         (WebCore::iteratorForEach):
302         (WebCore::IteratorTraits>::next):
303         * bindings/js/JSDOMWindowBase.cpp:
304         (WebCore::isResponseCorrect):
305         (WebCore::handleResponseOnStreamingAction):
306         (WebCore::JSDOMWindowBase::compileStreaming):
307         (WebCore::JSDOMWindowBase::instantiateStreaming):
308         * bindings/js/JSDOMWindowCustom.cpp:
309         (WebCore::JSDOMWindow::preventExtensions):
310         (WebCore::JSDOMWindow::toStringName):
311         * bindings/js/JSHTMLElementCustom.cpp:
312         (WebCore::constructJSHTMLElement):
313         * bindings/js/JSLocationCustom.cpp:
314         (WebCore::JSLocation::preventExtensions):
315         (WebCore::JSLocation::toStringName):
316         * bindings/js/JSReadableStreamPrivateConstructors.cpp:
317         (WebCore::constructJSReadableStreamDefaultController):
318         (WebCore::constructJSReadableByteStreamController):
319         (WebCore::constructJSReadableStreamBYOBRequest):
320         * bindings/js/JSRemoteDOMWindowCustom.cpp:
321         (WebCore::JSRemoteDOMWindow::preventExtensions):
322         (WebCore::JSRemoteDOMWindow::toStringName):
323         * bindings/js/ReadableStreamDefaultController.cpp:
324         (WebCore::ReadableStreamDefaultController::invoke):
325         * bindings/js/ScriptModuleLoader.cpp:
326         (WebCore::resolveModuleSpecifier):
327         (WebCore::ScriptModuleLoader::resolve):
328         (WebCore::ScriptModuleLoader::fetch):
329         (WebCore::ScriptModuleLoader::evaluate):
330         (WebCore::ScriptModuleLoader::importModule):
331         (WebCore::ScriptModuleLoader::notifyFinished):
332         * bindings/js/SerializedScriptValue.cpp:
333         (WebCore::maybeThrowExceptionIfSerializationFailed):
334         * bindings/js/WorkerScriptController.cpp:
335         (WebCore::WorkerScriptController::evaluate):
336         * bindings/scripts/CodeGeneratorJS.pm:
337         (GenerateDefaultValue):
338         (GenerateConstructorHelperMethods):
339         (GenerateCallTracer):
340         * bindings/scripts/test/JS/JSInterfaceName.cpp:
341         (WebCore::JSInterfaceNameConstructor::initializeProperties):
342         * bindings/scripts/test/JS/JSMapLike.cpp:
343         (WebCore::JSMapLikeConstructor::initializeProperties):
344         * bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
345         (WebCore::JSReadOnlyMapLikeConstructor::initializeProperties):
346         * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
347         (WebCore::JSTestActiveDOMObjectConstructor::initializeProperties):
348         * bindings/scripts/test/JS/JSTestCEReactions.cpp:
349         (WebCore::JSTestCEReactionsConstructor::initializeProperties):
350         * bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
351         (WebCore::JSTestCEReactionsStringifierConstructor::initializeProperties):
352         * bindings/scripts/test/JS/JSTestCallTracer.cpp:
353         (WebCore::JSTestCallTracerConstructor::initializeProperties):
354         (WebCore::jsTestCallTracerTestAttributeInterfaceGetter):
355         (WebCore::setJSTestCallTracerTestAttributeInterfaceSetter):
356         (WebCore::jsTestCallTracerTestAttributeSpecifiedGetter):
357         (WebCore::setJSTestCallTracerTestAttributeSpecifiedSetter):
358         (WebCore::jsTestCallTracerTestAttributeWithVariantGetter):
359         (WebCore::setJSTestCallTracerTestAttributeWithVariantSetter):
360         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterfaceBody):
361         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecifiedBody):
362         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArgumentsBody):
363         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
364         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgumentBody):
365         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
366         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
367         (WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):
368         * bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
369         (WebCore::JSTestCallbackInterfaceConstructor::initializeProperties):
370         * bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
371         (WebCore::JSTestClassWithJSBuiltinConstructorConstructor::initializeProperties):
372         * bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
373         (WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::initializeProperties):
374         * bindings/scripts/test/JS/JSTestDOMJIT.cpp:
375         (WebCore::JSTestDOMJITConstructor::initializeProperties):
376         * bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
377         (WebCore::JSTestEnabledBySettingConstructor::initializeProperties):
378         * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
379         (WebCore::JSTestEventConstructorConstructor::initializeProperties):
380         * bindings/scripts/test/JS/JSTestEventTarget.cpp:
381         (WebCore::JSTestEventTargetConstructor::initializeProperties):
382         * bindings/scripts/test/JS/JSTestException.cpp:
383         (WebCore::JSTestExceptionConstructor::initializeProperties):
384         * bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
385         (WebCore::JSTestGenerateIsReachableConstructor::initializeProperties):
386         * bindings/scripts/test/JS/JSTestGlobalObject.cpp:
387         (WebCore::JSTestGlobalObjectConstructor::initializeProperties):
388         * bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
389         (WebCore::JSTestIndexedSetterNoIdentifierConstructor::initializeProperties):
390         * bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
391         (WebCore::JSTestIndexedSetterThrowingExceptionConstructor::initializeProperties):
392         * bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
393         (WebCore::JSTestIndexedSetterWithIdentifierConstructor::initializeProperties):
394         * bindings/scripts/test/JS/JSTestInterface.cpp:
395         (WebCore::JSTestInterfaceConstructor::construct):
396         (WebCore::JSTestInterfaceConstructor::initializeProperties):
397         * bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
398         (WebCore::JSTestInterfaceLeadingUnderscoreConstructor::initializeProperties):
399         * bindings/scripts/test/JS/JSTestIterable.cpp:
400         (WebCore::JSTestIterableConstructor::initializeProperties):
401         * bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
402         (WebCore::JSTestJSBuiltinConstructorConstructor::initializeProperties):
403         * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
404         (WebCore::JSTestMediaQueryListListenerConstructor::initializeProperties):
405         * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
406         (WebCore::JSTestNamedAndIndexedSetterNoIdentifierConstructor::initializeProperties):
407         * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
408         (WebCore::JSTestNamedAndIndexedSetterThrowingExceptionConstructor::initializeProperties):
409         * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
410         (WebCore::JSTestNamedAndIndexedSetterWithIdentifierConstructor::initializeProperties):
411         * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
412         (WebCore::JSTestNamedConstructorConstructor::initializeProperties):
413         (WebCore::JSTestNamedConstructorNamedConstructor::construct):
414         (WebCore::JSTestNamedConstructorNamedConstructor::initializeProperties):
415         * bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
416         (WebCore::JSTestNamedDeleterNoIdentifierConstructor::initializeProperties):
417         * bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
418         (WebCore::JSTestNamedDeleterThrowingExceptionConstructor::initializeProperties):
419         * bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
420         (WebCore::JSTestNamedDeleterWithIdentifierConstructor::initializeProperties):
421         * bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
422         (WebCore::JSTestNamedDeleterWithIndexedGetterConstructor::initializeProperties):
423         * bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
424         (WebCore::JSTestNamedGetterCallWithConstructor::initializeProperties):
425         * bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
426         (WebCore::JSTestNamedGetterNoIdentifierConstructor::initializeProperties):
427         * bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
428         (WebCore::JSTestNamedGetterWithIdentifierConstructor::initializeProperties):
429         * bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
430         (WebCore::JSTestNamedSetterNoIdentifierConstructor::initializeProperties):
431         * bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
432         (WebCore::JSTestNamedSetterThrowingExceptionConstructor::initializeProperties):
433         * bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
434         (WebCore::JSTestNamedSetterWithIdentifierConstructor::initializeProperties):
435         * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
436         (WebCore::JSTestNamedSetterWithIndexedGetterConstructor::initializeProperties):
437         * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
438         (WebCore::JSTestNamedSetterWithIndexedGetterAndSetterConstructor::initializeProperties):
439         * bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
440         (WebCore::JSTestNamedSetterWithOverrideBuiltinsConstructor::initializeProperties):
441         * bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
442         (WebCore::JSTestNamedSetterWithUnforgablePropertiesConstructor::initializeProperties):
443         * bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
444         (WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltinsConstructor::initializeProperties):
445         * bindings/scripts/test/JS/JSTestNode.cpp:
446         (WebCore::JSTestNodeConstructor::initializeProperties):
447         * bindings/scripts/test/JS/JSTestObj.cpp:
448         (WebCore::convertDictionary<TestObj::Dictionary>):
449         (WebCore::JSTestObjConstructor::initializeProperties):
450         (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringAndDefaultValueBody):
451         * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
452         (WebCore::JSTestOverloadedConstructorsConstructor::initializeProperties):
453         * bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
454         (WebCore::JSTestOverloadedConstructorsWithSequenceConstructor::initializeProperties):
455         * bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
456         (WebCore::JSTestOverrideBuiltinsConstructor::initializeProperties):
457         * bindings/scripts/test/JS/JSTestPluginInterface.cpp:
458         (WebCore::JSTestPluginInterfaceConstructor::initializeProperties):
459         * bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
460         (WebCore::JSTestPromiseRejectionEventConstructor::initializeProperties):
461         * bindings/scripts/test/JS/JSTestSerialization.cpp:
462         (WebCore::JSTestSerializationConstructor::initializeProperties):
463         * bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
464         (WebCore::JSTestSerializationIndirectInheritanceConstructor::initializeProperties):
465         * bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
466         (WebCore::JSTestSerializationInheritConstructor::initializeProperties):
467         * bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
468         (WebCore::JSTestSerializationInheritFinalConstructor::initializeProperties):
469         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
470         (WebCore::JSTestSerializedScriptValueInterfaceConstructor::initializeProperties):
471         * bindings/scripts/test/JS/JSTestStringifier.cpp:
472         (WebCore::JSTestStringifierConstructor::initializeProperties):
473         * bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
474         (WebCore::JSTestStringifierAnonymousOperationConstructor::initializeProperties):
475         * bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
476         (WebCore::JSTestStringifierNamedOperationConstructor::initializeProperties):
477         * bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
478         (WebCore::JSTestStringifierOperationImplementedAsConstructor::initializeProperties):
479         * bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
480         (WebCore::JSTestStringifierOperationNamedToStringConstructor::initializeProperties):
481         * bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
482         (WebCore::JSTestStringifierReadOnlyAttributeConstructor::initializeProperties):
483         * bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
484         (WebCore::JSTestStringifierReadWriteAttributeConstructor::initializeProperties):
485         * bindings/scripts/test/JS/JSTestTypedefs.cpp:
486         (WebCore::JSTestTypedefsConstructor::initializeProperties):
487         * bridge/c/c_instance.cpp:
488         (JSC::Bindings::CInstance::invokeMethod):
489         (JSC::Bindings::CInstance::invokeDefaultMethod):
490         (JSC::Bindings::CInstance::invokeConstruct):
491         (JSC::Bindings::CInstance::stringValue const):
492         (JSC::Bindings::CInstance::toJSPrimitive const):
493         * bridge/objc/objc_instance.mm:
494         (ObjcInstance::invokeMethod):
495         * bridge/objc/objc_runtime.mm:
496         (JSC::Bindings::ObjcArray::setValueAt const):
497         * contentextensions/ContentExtensionsBackend.cpp:
498         (WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
499         * crypto/SubtleCrypto.cpp:
500         (WebCore::rejectWithException):
501         (WebCore::SubtleCrypto::encrypt):
502         (WebCore::SubtleCrypto::decrypt):
503         (WebCore::SubtleCrypto::sign):
504         (WebCore::SubtleCrypto::verify):
505         (WebCore::SubtleCrypto::deriveKey):
506         (WebCore::SubtleCrypto::deriveBits):
507         (WebCore::SubtleCrypto::exportKey):
508         (WebCore::SubtleCrypto::wrapKey):
509         (WebCore::SubtleCrypto::unwrapKey):
510         * crypto/keys/CryptoKeyEC.cpp:
511         (WebCore::CryptoKeyEC::algorithm const):
512         * css/CSSInheritedValue.cpp:
513         (WebCore::CSSInheritedValue::customCSSText const):
514         * css/CSSInitialValue.cpp:
515         (WebCore::CSSInitialValue::customCSSText const):
516         * css/CSSKeyframesRule.cpp:
517         (WebCore::CSSKeyframesRule::insertRule):
518         * css/CSSRevertValue.cpp:
519         (WebCore::CSSRevertValue::customCSSText const):
520         * css/CSSStyleSheet.h:
521         * css/CSSUnsetValue.cpp:
522         (WebCore::CSSUnsetValue::customCSSText const):
523         * css/CSSValueList.cpp:
524         (WebCore::CSSValueList::customCSSText const):
525         * css/DOMMatrixReadOnly.cpp:
526         (WebCore::DOMMatrixReadOnly::validateAndFixup):
527         (WebCore::DOMMatrixReadOnly::toFloat32Array const):
528         (WebCore::DOMMatrixReadOnly::toFloat64Array const):
529         (WebCore::DOMMatrixReadOnly::toString const):
530         * css/DeprecatedCSSOMValueList.cpp:
531         (WebCore::DeprecatedCSSOMValueList::cssText const):
532         * css/FontFace.cpp:
533         (WebCore::FontFace::create):
534         (WebCore::FontFace::unicodeRange const):
535         (WebCore::FontFace::featureSettings const):
536         * css/MediaQuery.cpp:
537         (WebCore::MediaQuery::serialize const):
538         * css/PropertySetCSSStyleDeclaration.cpp:
539         (WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
540         * css/WebKitCSSMatrix.cpp:
541         (WebCore::WebKitCSSMatrix::toString const):
542         * css/parser/MediaQueryParser.cpp:
543         (WebCore::MediaQueryParser::commitMediaQuery):
544         * dom/CDATASection.cpp:
545         (WebCore::CDATASection::nodeName const):
546         * dom/Comment.cpp:
547         (WebCore::Comment::nodeName const):
548         * dom/DOMException.cpp:
549         (WebCore::DOMException::description const):
550         (WebCore::DOMException::create):
551         * dom/DOMException.h:
552         (WebCore::DOMException::name):
553         (WebCore::DOMException::message):
554         * dom/DOMImplementation.cpp:
555         (WebCore::DOMImplementation::createHTMLDocument):
556         * dom/DataTransfer.cpp:
557         (WebCore::DataTransfer::DataTransfer):
558         (WebCore::DataTransfer::types const):
559         (WebCore::DataTransfer::createForInputEvent):
560         (WebCore::DataTransfer::dropEffect const):
561         (WebCore::DataTransfer::effectAllowed const):
562         * dom/DataTransferItem.cpp:
563         (WebCore::DataTransferItem::kind const):
564         * dom/Document.cpp:
565         (WebCore::Document::suggestedMIMEType const):
566         (WebCore::Document::contentType const):
567         (WebCore::Document::nodeName const):
568         (WebCore::Document::writeln):
569         (WebCore::Document::canNavigate):
570         (WebCore::Document::designMode const):
571         (WebCore::Document::requestFullScreenForElement):
572         * dom/DocumentFragment.cpp:
573         (WebCore::DocumentFragment::nodeName const):
574         * dom/InlineStyleSheetOwner.cpp:
575         (WebCore::InlineStyleSheetOwner::createSheet):
576         * dom/MouseEvent.cpp:
577         (WebCore::MouseEvent::initMouseEventQuirk):
578         * dom/ScriptElement.cpp:
579         (WebCore::ScriptElement::requestModuleScript):
580         * dom/ScriptElementCachedScriptFetcher.cpp:
581         (WebCore::ScriptElementCachedScriptFetcher::requestModuleScript const):
582         * dom/ScriptExecutionContext.cpp:
583         (WebCore::ScriptExecutionContext::dispatchErrorEvent):
584         * dom/ScriptedAnimationController.cpp:
585         (WebCore::throttlingReasonsToString):
586         * dom/Text.cpp:
587         (WebCore::Text::nodeName const):
588         * dom/TextEncoder.cpp:
589         (WebCore::TextEncoder::encoding const):
590         * dom/Traversal.cpp:
591         (WebCore::NodeIteratorBase::acceptNode):
592         * editing/EditCommand.cpp:
593         (WebCore::inputTypeNameForEditingAction):
594         * editing/Editing.cpp:
595         (WebCore::createTabSpanElement):
596         * editing/Editor.cpp:
597         (WebCore::createDataTransferForClipboardEvent):
598         * editing/EditorCommand.cpp:
599         (WebCore::executeInsertBacktab):
600         (WebCore::executeInsertLineBreak):
601         (WebCore::executeInsertNewline):
602         (WebCore::executeInsertTab):
603         (WebCore::executeJustifyCenter):
604         (WebCore::executeJustifyFull):
605         (WebCore::executeJustifyLeft):
606         (WebCore::executeJustifyRight):
607         (WebCore::executeStrikethrough):
608         (WebCore::executeSubscript):
609         (WebCore::executeSuperscript):
610         (WebCore::executeToggleBold):
611         (WebCore::executeToggleItalic):
612         (WebCore::executeUnderline):
613         (WebCore::executeUnscript):
614         (WebCore::stateBold):
615         (WebCore::stateItalic):
616         (WebCore::stateStrikethrough):
617         (WebCore::stateSubscript):
618         (WebCore::stateSuperscript):
619         (WebCore::stateUnderline):
620         (WebCore::stateJustifyCenter):
621         (WebCore::stateJustifyFull):
622         (WebCore::stateJustifyLeft):
623         (WebCore::stateJustifyRight):
624         (WebCore::Editor::Command::value const):
625         * editing/SmartReplace.cpp:
626         (WebCore::getSmartSet):
627         * fileapi/FileCocoa.mm:
628         (WebCore::File::computeNameAndContentTypeForReplacedFile):
629         * html/BaseCheckableInputType.cpp:
630         (WebCore::BaseCheckableInputType::saveFormControlState const):
631         * html/BaseChooserOnlyDateAndTimeInputType.cpp:
632         (WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
633         * html/ColorInputType.cpp:
634         (WebCore::ColorInputType::fallbackValue const):
635         * html/DOMFormData.cpp:
636         (WebCore::DOMFormData::createFileEntry):
637         * html/FTPDirectoryDocument.cpp:
638         (WebCore::processFilesizeString):
639         (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
640         * html/HTMLAnchorElement.cpp:
641         (WebCore::HTMLAnchorElement::relList const):
642         (WebCore::HTMLAnchorElement::isSystemPreviewLink const):
643         * html/HTMLAppletElement.cpp:
644         (WebCore::HTMLAppletElement::HTMLAppletElement):
645         (WebCore::HTMLAppletElement::updateWidget):
646         * html/HTMLCanvasElement.cpp:
647         (WebCore::toEncodingMimeType):
648         (WebCore::HTMLCanvasElement::toDataURL):
649         (WebCore::HTMLCanvasElement::captureStream):
650         * html/HTMLElement.cpp:
651         (WebCore::HTMLElement::contentEditable const):
652         * html/HTMLFormControlElement.cpp:
653         (WebCore::shouldAutofocus):
654         * html/HTMLHtmlElement.cpp:
655         (WebCore::HTMLHtmlElement::insertedByParser):
656         * html/HTMLKeygenElement.cpp:
657         (WebCore::HTMLKeygenElement::keytype const):
658         * html/HTMLMediaElement.cpp:
659         (WebCore::HTMLMediaElement::canPlayType const):
660         (WebCore::stringForNetworkState):
661         (WebCore::HTMLMediaElement::preload const):
662         (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
663         * html/HTMLObjectElement.cpp:
664         (WebCore::mapDataParamToSrc):
665         * html/HTMLPlugInElement.cpp:
666         (WebCore::HTMLPlugInElement::setReplacement):
667         * html/ImageData.cpp:
668         (WebCore::ImageData::create):
669         * html/ImageDocument.cpp:
670         (WebCore::ImageDocument::createDocumentStructure):
671         * html/ImageInputType.cpp:
672         (WebCore::ImageInputType::appendFormData const):
673         * html/PluginDocument.cpp:
674         (WebCore::PluginDocumentParser::createDocumentStructure):
675         * html/canvas/WebGL2RenderingContext.cpp:
676         (WebCore::WebGL2RenderingContext::getExtension):
677         (WebCore::WebGL2RenderingContext::getSupportedExtensions):
678         (WebCore::WebGL2RenderingContext::getParameter):
679         * html/canvas/WebGLCompressedTextureASTC.cpp:
680         (WebCore::WebGLCompressedTextureASTC::WebGLCompressedTextureASTC):
681         (WebCore::WebGLCompressedTextureASTC::getSupportedProfiles):
682         (WebCore::WebGLCompressedTextureASTC::supported):
683         (WebCore::m_isLDRSupported): Deleted.
684         * html/canvas/WebGLRenderingContext.cpp:
685         (WebCore::WebGLRenderingContext::getExtension):
686         (WebCore::WebGLRenderingContext::getSupportedExtensions):
687         (WebCore::WebGLRenderingContext::getParameter):
688         * html/canvas/WebGLRenderingContextBase.cpp:
689         (WebCore::WebGLRenderingContextBase::create):
690         (WebCore::WebGLRenderingContextBase::enableSupportedExtension):
691         * html/canvas/WebGLRenderingContextBase.h:
692         * html/canvas/WebGPUEnums.cpp:
693         (WebCore::web3DCompareFunctionName):
694         * html/parser/HTMLParserIdioms.cpp:
695         (WebCore::parseCORSSettingsAttribute):
696         * html/parser/HTMLPreloadScanner.cpp:
697         (WebCore::TokenPreloadScanner::initiatorFor):
698         * html/parser/HTMLResourcePreloader.cpp:
699         (WebCore::PreloadRequest::resourceRequest):
700         * html/parser/HTMLTreeBuilder.cpp:
701         (WebCore::HTMLTreeBuilder::insertPhoneNumberLink):
702         * html/track/DataCue.cpp:
703         (WebCore::DataCue::toJSONString const):
704         * html/track/InbandGenericTextTrack.cpp:
705         (WebCore::InbandGenericTextTrack::updateCueFromCueData):
706         * html/track/TextTrackCue.cpp:
707         (WebCore::TextTrackCue::toJSON const):
708         * html/track/TextTrackCueGeneric.cpp:
709         (WebCore::TextTrackCueGeneric::toJSONString const):
710         * html/track/TrackBase.cpp:
711         (WebCore::TrackBase::setLanguage):
712         * html/track/VTTCue.cpp:
713         (WebCore::VTTCue::toJSON const):
714         * inspector/CommandLineAPIModule.cpp:
715         (WebCore::CommandLineAPIModule::CommandLineAPIModule):
716         * inspector/InspectorCanvas.cpp:
717         (WebCore::InspectorCanvas::getCanvasContentAsDataURL):
718         (WebCore::InspectorCanvas::indexForData):
719         (WebCore::InspectorCanvas::buildInitialState):
720         (WebCore::InspectorCanvas::buildArrayForCanvasGradient):
721         (WebCore::InspectorCanvas::buildArrayForCanvasPattern):
722         * inspector/InspectorFrontendClient.h:
723         (WebCore::InspectorFrontendClient::debuggableType):
724         * inspector/InspectorFrontendClientLocal.cpp:
725         (WebCore::InspectorFrontendClientLocal::openInNewTab):
726         * inspector/InspectorFrontendHost.cpp:
727         (WebCore::InspectorFrontendHost::userInterfaceLayoutDirection):
728         (WebCore::InspectorFrontendHost::platform):
729         (WebCore::InspectorFrontendHost::port):
730         * inspector/InspectorOverlay.cpp:
731         (WebCore::InspectorOverlay::setIndicating):
732         (WebCore::InspectorOverlay::drawPaintRects):
733         (WebCore::InspectorOverlay::drawRulers):
734         (WebCore::appendPathSegment):
735         * inspector/InspectorStyleSheet.h:
736         (WebCore::InspectorCSSId::InspectorCSSId):
737         * inspector/TimelineRecordFactory.cpp:
738         (WebCore::TimelineRecordFactory::createGenericRecord):
739         (WebCore::TimelineRecordFactory::createFunctionCallData):
740         (WebCore::TimelineRecordFactory::createConsoleProfileData):
741         (WebCore::TimelineRecordFactory::createProbeSampleData):
742         (WebCore::TimelineRecordFactory::createEventDispatchData):
743         (WebCore::TimelineRecordFactory::createGenericTimerData):
744         (WebCore::TimelineRecordFactory::createTimerInstallData):
745         (WebCore::TimelineRecordFactory::createEvaluateScriptData):
746         (WebCore::TimelineRecordFactory::createTimeStampData):
747         (WebCore::TimelineRecordFactory::createAnimationFrameData):
748         (WebCore::TimelineRecordFactory::createPaintData):
749         (WebCore::TimelineRecordFactory::appendLayoutRoot):
750         * inspector/WebInjectedScriptHost.cpp:
751         (WebCore::WebInjectedScriptHost::subtype):
752         (WebCore::jsStringForPaymentRequestState):
753         (WebCore::WebInjectedScriptHost::getInternalProperties):
754         * inspector/agents/InspectorApplicationCacheAgent.cpp:
755         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
756         * inspector/agents/InspectorCSSAgent.cpp:
757         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
758         (WebCore::InspectorCSSAgent::getMatchedStylesForNode):
759         (WebCore::InspectorCSSAgent::createStyleSheet):
760         (WebCore::InspectorCSSAgent::addRule):
761         (WebCore::InspectorCSSAgent::elementForId):
762         (WebCore::InspectorCSSAgent::assertStyleSheetForId):
763         * inspector/agents/InspectorCanvasAgent.cpp:
764         (WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
765         (WebCore::InspectorCanvasAgent::requestNode):
766         (WebCore::InspectorCanvasAgent::requestContent):
767         (WebCore::InspectorCanvasAgent::resolveCanvasContext):
768         (WebCore::InspectorCanvasAgent::startRecording):
769         (WebCore::InspectorCanvasAgent::stopRecording):
770         (WebCore::InspectorCanvasAgent::requestShaderSource):
771         (WebCore::InspectorCanvasAgent::updateShader):
772         (WebCore::InspectorCanvasAgent::setShaderProgramDisabled):
773         (WebCore::InspectorCanvasAgent::setShaderProgramHighlighted):
774         (WebCore::InspectorCanvasAgent::assertInspectorCanvas):
775         (WebCore::InspectorCanvasAgent::assertInspectorProgram):
776         * inspector/agents/InspectorDOMAgent.cpp:
777         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
778         (WebCore::InspectorDOMAgent::assertNode):
779         (WebCore::InspectorDOMAgent::assertDocument):
780         (WebCore::InspectorDOMAgent::assertElement):
781         (WebCore::InspectorDOMAgent::assertEditableNode):
782         (WebCore::InspectorDOMAgent::assertEditableElement):
783         (WebCore::InspectorDOMAgent::getDocument):
784         (WebCore::InspectorDOMAgent::pushNodeToFrontend):
785         (WebCore::InspectorDOMAgent::requestChildNodes):
786         (WebCore::InspectorDOMAgent::querySelector):
787         (WebCore::InspectorDOMAgent::querySelectorAll):
788         (WebCore::InspectorDOMAgent::releaseBackendNodeIds):
789         (WebCore::InspectorDOMAgent::setAttributesAsText):
790         (WebCore::InspectorDOMAgent::removeNode):
791         (WebCore::InspectorDOMAgent::setOuterHTML):
792         (WebCore::InspectorDOMAgent::insertAdjacentHTML):
793         (WebCore::InspectorDOMAgent::setNodeValue):
794         (WebCore::InspectorDOMAgent::setEventListenerDisabled):
795         (WebCore::InspectorDOMAgent::performSearch):
796         (WebCore::InspectorDOMAgent::getSearchResults):
797         (WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
798         (WebCore::InspectorDOMAgent::highlightQuad):
799         (WebCore::InspectorDOMAgent::highlightSelector):
800         (WebCore::InspectorDOMAgent::highlightNode):
801         (WebCore::InspectorDOMAgent::highlightNodeList):
802         (WebCore::InspectorDOMAgent::moveTo):
803         (WebCore::InspectorDOMAgent::focus):
804         (WebCore::InspectorDOMAgent::setInspectedNode):
805         (WebCore::InspectorDOMAgent::resolveNode):
806         (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
807         (WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):
808         * inspector/agents/InspectorDOMDebuggerAgent.cpp:
809         (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
810         (WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
811         (WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
812         (WebCore::domTypeName):
813         (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
814         * inspector/agents/InspectorDOMStorageAgent.cpp:
815         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
816         (WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
817         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
818         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
819         (WebCore::InspectorDOMStorageAgent::findStorageArea):
820         * inspector/agents/InspectorDatabaseAgent.cpp:
821         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
822         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
823         * inspector/agents/InspectorIndexedDBAgent.cpp:
824         (WebCore::Inspector::idbKeyRangeFromKeyRange):
825         (WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
826         (WebCore::InspectorIndexedDBAgent::requestData):
827         * inspector/agents/InspectorLayerTreeAgent.cpp:
828         (WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
829         (WebCore::InspectorLayerTreeAgent::layersForNode):
830         (WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
831         * inspector/agents/InspectorMemoryAgent.cpp:
832         (WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
833         * inspector/agents/InspectorNetworkAgent.cpp:
834         (WebCore::InspectorNetworkAgent::InspectorNetworkAgent):
835         (WebCore::InspectorNetworkAgent::getResponseBody):
836         (WebCore::InspectorNetworkAgent::loadResource):
837         (WebCore::InspectorNetworkAgent::resolveWebSocket):
838         (WebCore::InspectorNetworkAgent::createTextDecoder):
839         (WebCore::InspectorNetworkAgent::searchInRequest):
840         * inspector/agents/InspectorPageAgent.cpp:
841         (WebCore::InspectorPageAgent::resourceContent):
842         (WebCore::InspectorPageAgent::InspectorPageAgent):
843         (WebCore::InspectorPageAgent::navigate):
844         (WebCore::InspectorPageAgent::assertFrame):
845         (WebCore::InspectorPageAgent::assertDocumentLoader):
846         (WebCore::InspectorPageAgent::snapshotNode):
847         (WebCore::InspectorPageAgent::snapshotRect):
848         (WebCore::InspectorPageAgent::archive):
849         * inspector/agents/InspectorTimelineAgent.cpp:
850         (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
851         (WebCore::InspectorTimelineAgent::setInstruments):
852         (WebCore::InspectorTimelineAgent::startFromConsole):
853         (WebCore::InspectorTimelineAgent::stopFromConsole):
854         (WebCore::InspectorTimelineAgent::didCompleteRecordEntry):
855         * inspector/agents/InspectorWorkerAgent.cpp:
856         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
857         (WebCore::InspectorWorkerAgent::initialized):
858         (WebCore::InspectorWorkerAgent::sendMessageToWorker):
859         * inspector/agents/WebConsoleAgent.cpp:
860         (WebCore::WebConsoleAgent::setLoggingChannelLevel):
861         * inspector/agents/page/PageDebuggerAgent.cpp:
862         (WebCore::PageDebuggerAgent::injectedScriptForEval):
863         * inspector/agents/page/PageNetworkAgent.cpp:
864         (WebCore::PageNetworkAgent::scriptExecutionContext):
865         * inspector/agents/page/PageRuntimeAgent.cpp:
866         (WebCore::PageRuntimeAgent::injectedScriptForEval):
867         * inspector/agents/worker/ServiceWorkerAgent.cpp:
868         (WebCore::ServiceWorkerAgent::ServiceWorkerAgent):
869         * inspector/agents/worker/WorkerDebuggerAgent.cpp:
870         (WebCore::WorkerDebuggerAgent::injectedScriptForEval):
871         * inspector/agents/worker/WorkerRuntimeAgent.cpp:
872         (WebCore::WorkerRuntimeAgent::injectedScriptForEval):
873         * loader/ContentFilter.cpp:
874         (WebCore::ContentFilter::handleProvisionalLoadFailure):
875         * loader/CrossOriginAccessControl.cpp:
876         (WebCore::passesAccessControlCheck):
877         (WebCore::validatePreflightResponse):
878         * loader/CrossOriginPreflightChecker.cpp:
879         (WebCore::CrossOriginPreflightChecker::notifyFinished):
880         (WebCore::CrossOriginPreflightChecker::doPreflight):
881         * loader/DocumentLoader.cpp:
882         (WebCore::isRemoteWebArchive):
883         (WebCore::DocumentLoader::startIconLoading):
884         * loader/DocumentThreadableLoader.cpp:
885         (WebCore::DocumentThreadableLoader::reportRedirectionWithBadScheme):
886         (WebCore::DocumentThreadableLoader::reportContentSecurityPolicyError):
887         (WebCore::DocumentThreadableLoader::reportCrossOriginResourceSharingError):
888         (WebCore::DocumentThreadableLoader::reportIntegrityMetadataError):
889         * loader/FormSubmission.cpp:
890         (WebCore::FormSubmission::Attributes::parseEncodingType):
891         * loader/FormSubmission.h:
892         (WebCore::FormSubmission::Attributes::methodString):
893         * loader/FrameLoader.cpp:
894         (WebCore::FrameLoader::initForSynthesizedDocument):
895         (WebCore::FrameLoader::loadURLIntoChildFrame):
896         (WebCore::FrameLoader::defaultSubstituteDataForURL):
897         (WebCore::FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded):
898         (WebCore::FrameLoader::dispatchBeforeUnloadEvent):
899         * loader/LinkLoader.cpp:
900         (WebCore::LinkLoader::preconnectIfNeeded):
901         * loader/NavigationScheduler.cpp:
902         (WebCore::NavigationScheduler::scheduleLocationChange):
903         * loader/PingLoader.cpp:
904         (WebCore::PingLoader::sendViolationReport):
905         * loader/ResourceLoadStatistics.cpp:
906         (WebCore::ResourceLoadStatistics::primaryDomain):
907         (WebCore::ResourceLoadStatistics::areDomainsAssociated):
908         * loader/ResourceLoader.cpp:
909         (WebCore::ResourceLoader::loadDataURL):
910         (WebCore::ResourceLoader::didBlockAuthenticationChallenge):
911         * loader/SubresourceLoader.cpp:
912         (WebCore::SubresourceLoader::willSendRequestInternal):
913         (WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):
914         * loader/ThreadableLoader.cpp:
915         (WebCore::ThreadableLoader::logError):
916         * loader/appcache/ApplicationCacheGroup.cpp:
917         (WebCore::ApplicationCacheGroup::abort):
918         (WebCore::ApplicationCacheGroup::didFinishLoadingEntry):
919         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
920         (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
921         * loader/appcache/ApplicationCacheHost.cpp:
922         (WebCore::ApplicationCacheHost::createFileURL):
923         * loader/appcache/ManifestParser.cpp:
924         (WebCore::parseManifest):
925         * loader/archive/ArchiveFactory.cpp:
926         (WebCore::createArchiveMIMETypesMap):
927         * loader/cache/CachedResource.cpp:
928         (WebCore::CachedResource::load):
929         * loader/cache/CachedResourceLoader.cpp:
930         (WebCore::CachedResourceLoader::canRequest):
931         (WebCore::CachedResourceLoader::requestResource):
932         * loader/cache/CachedResourceRequest.cpp:
933         (WebCore::acceptHeaderValueFromType):
934         (WebCore::CachedResourceRequest::updateAcceptEncodingHeader):
935         * loader/cache/CachedScript.cpp:
936         (WebCore::CachedScript::CachedScript):
937         * loader/cache/MemoryCache.cpp:
938         (WebCore::MemoryCache::getOriginsWithCache):
939         * loader/soup/ResourceLoaderSoup.cpp:
940         (WebCore::ResourceLoader::loadGResource):
941         * page/DOMSelection.cpp:
942         (WebCore::DOMSelection::type const):
943         * page/DOMWindow.cpp:
944         (WebCore::DOMWindow::close):
945         (WebCore::DOMWindow::addEventListener):
946         (WebCore::DOMWindow::createWindow):
947         * page/DebugPageOverlays.cpp:
948         (WebCore::touchEventRegionColors):
949         * page/DiagnosticLoggingKeys.cpp:
950         (WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
951         (WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
952         (WebCore::DiagnosticLoggingKeys::memoryCacheEntryDecisionKey):
953         (WebCore::DiagnosticLoggingKeys::memoryCacheUsageKey):
954         (WebCore::DiagnosticLoggingKeys::missingValidatorFieldsKey):
955         (WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
956         (WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
957         (WebCore::DiagnosticLoggingKeys::postPageBackgroundingCPUUsageKey):
958         (WebCore::DiagnosticLoggingKeys::postPageBackgroundingMemoryUsageKey):
959         (WebCore::DiagnosticLoggingKeys::pageHandlesWebGLContextLossKey):
960         (WebCore::DiagnosticLoggingKeys::postPageLoadCPUUsageKey):
961         (WebCore::DiagnosticLoggingKeys::postPageLoadMemoryUsageKey):
962         (WebCore::DiagnosticLoggingKeys::provisionalLoadKey):
963         (WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
964         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
965         (WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
966         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
967         (WebCore::DiagnosticLoggingKeys::pageLoadedKey):
968         (WebCore::DiagnosticLoggingKeys::playedKey):
969         (WebCore::DiagnosticLoggingKeys::engineFailedToLoadKey):
970         (WebCore::DiagnosticLoggingKeys::entryRightlyNotWarmedUpKey):
971         (WebCore::DiagnosticLoggingKeys::entryWronglyNotWarmedUpKey):
972         (WebCore::DiagnosticLoggingKeys::navigationKey):
973         (WebCore::DiagnosticLoggingKeys::needsRevalidationKey):
974         (WebCore::DiagnosticLoggingKeys::networkCacheKey):
975         (WebCore::DiagnosticLoggingKeys::networkCacheFailureReasonKey):
976         (WebCore::DiagnosticLoggingKeys::networkCacheUnusedReasonKey):
977         (WebCore::DiagnosticLoggingKeys::networkCacheReuseFailureKey):
978         (WebCore::DiagnosticLoggingKeys::networkKey):
979         (WebCore::DiagnosticLoggingKeys::networkProcessCrashedKey):
980         (WebCore::DiagnosticLoggingKeys::neverSeenBeforeKey):
981         (WebCore::DiagnosticLoggingKeys::noKey):
982         (WebCore::DiagnosticLoggingKeys::noCacheKey):
983         (WebCore::DiagnosticLoggingKeys::noStoreKey):
984         (WebCore::DiagnosticLoggingKeys::nonVisibleStateKey):
985         (WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
986         (WebCore::DiagnosticLoggingKeys::pageCacheKey):
987         (WebCore::DiagnosticLoggingKeys::pageCacheFailureKey):
988         (WebCore::DiagnosticLoggingKeys::noDocumentLoaderKey):
989         (WebCore::DiagnosticLoggingKeys::noLongerInCacheKey):
990         (WebCore::DiagnosticLoggingKeys::otherKey):
991         (WebCore::DiagnosticLoggingKeys::mainDocumentErrorKey):
992         (WebCore::DiagnosticLoggingKeys::mainResourceKey):
993         (WebCore::DiagnosticLoggingKeys::isErrorPageKey):
994         (WebCore::DiagnosticLoggingKeys::isExpiredKey):
995         (WebCore::DiagnosticLoggingKeys::isReloadIgnoringCacheDataKey):
996         (WebCore::DiagnosticLoggingKeys::loadingKey):
997         (WebCore::DiagnosticLoggingKeys::hasPluginsKey):
998         (WebCore::DiagnosticLoggingKeys::httpsNoStoreKey):
999         (WebCore::DiagnosticLoggingKeys::imageKey):
1000         (WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
1001         (WebCore::DiagnosticLoggingKeys::inactiveKey):
1002         (WebCore::DiagnosticLoggingKeys::internalErrorKey):
1003         (WebCore::DiagnosticLoggingKeys::invalidSessionIDKey):
1004         (WebCore::DiagnosticLoggingKeys::isAttachmentKey):
1005         (WebCore::DiagnosticLoggingKeys::isConditionalRequestKey):
1006         (WebCore::DiagnosticLoggingKeys::isDisabledKey):
1007         (WebCore::DiagnosticLoggingKeys::noCurrentHistoryItemKey):
1008         (WebCore::DiagnosticLoggingKeys::quirkRedirectComingKey):
1009         (WebCore::DiagnosticLoggingKeys::rawKey):
1010         (WebCore::DiagnosticLoggingKeys::redirectKey):
1011         (WebCore::DiagnosticLoggingKeys::isLoadingKey):
1012         (WebCore::DiagnosticLoggingKeys::documentLoaderStoppingKey):
1013         (WebCore::DiagnosticLoggingKeys::domainCausingCrashKey):
1014         (WebCore::DiagnosticLoggingKeys::domainCausingEnergyDrainKey):
1015         (WebCore::DiagnosticLoggingKeys::domainCausingJetsamKey):
1016         (WebCore::DiagnosticLoggingKeys::simulatedPageCrashKey):
1017         (WebCore::DiagnosticLoggingKeys::exceededActiveMemoryLimitKey):
1018         (WebCore::DiagnosticLoggingKeys::exceededInactiveMemoryLimitKey):
1019         (WebCore::DiagnosticLoggingKeys::exceededBackgroundCPULimitKey):
1020         (WebCore::DiagnosticLoggingKeys::domainVisitedKey):
1021         (WebCore::DiagnosticLoggingKeys::cannotSuspendActiveDOMObjectsKey):
1022         (WebCore::DiagnosticLoggingKeys::cpuUsageKey):
1023         (WebCore::DiagnosticLoggingKeys::createSharedBufferFailedKey):
1024         (WebCore::DiagnosticLoggingKeys::activeInForegroundTabKey):
1025         (WebCore::DiagnosticLoggingKeys::activeInBackgroundTabOnlyKey):
1026         (WebCore::DiagnosticLoggingKeys::applicationCacheKey):
1027         (WebCore::DiagnosticLoggingKeys::applicationManifestKey):
1028         (WebCore::DiagnosticLoggingKeys::audioKey):
1029         (WebCore::DiagnosticLoggingKeys::backNavigationDeltaKey):
1030         (WebCore::DiagnosticLoggingKeys::canCacheKey):
1031         (WebCore::DiagnosticLoggingKeys::cacheControlNoStoreKey):
1032         (WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
1033         (WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationReasonKey):
1034         (WebCore::DiagnosticLoggingKeys::deniedByClientKey):
1035         (WebCore::DiagnosticLoggingKeys::deviceMotionKey):
1036         (WebCore::DiagnosticLoggingKeys::deviceOrientationKey):
1037         (WebCore::DiagnosticLoggingKeys::diskCacheKey):
1038         (WebCore::DiagnosticLoggingKeys::diskCacheAfterValidationKey):
1039         (WebCore::DiagnosticLoggingKeys::reloadKey):
1040         (WebCore::DiagnosticLoggingKeys::replaceKey):
1041         (WebCore::DiagnosticLoggingKeys::retrievalRequestKey):
1042         (WebCore::DiagnosticLoggingKeys::resourceLoadedKey):
1043         (WebCore::DiagnosticLoggingKeys::resourceResponseSourceKey):
1044         (WebCore::DiagnosticLoggingKeys::retrievalKey):
1045         (WebCore::DiagnosticLoggingKeys::revalidatingKey):
1046         (WebCore::DiagnosticLoggingKeys::reloadFromOriginKey):
1047         (WebCore::DiagnosticLoggingKeys::reloadRevalidatingExpiredKey):
1048         (WebCore::DiagnosticLoggingKeys::sameLoadKey):
1049         (WebCore::DiagnosticLoggingKeys::scriptKey):
1050         (WebCore::DiagnosticLoggingKeys::serviceWorkerKey):
1051         (WebCore::DiagnosticLoggingKeys::streamingMedia):
1052         (WebCore::DiagnosticLoggingKeys::styleSheetKey):
1053         (WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithRevalidationKey):
1054         (WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithoutRevalidationKey):
1055         (WebCore::DiagnosticLoggingKeys::svgDocumentKey):
1056         (WebCore::DiagnosticLoggingKeys::synchronousMessageFailedKey):
1057         (WebCore::DiagnosticLoggingKeys::telemetryPageLoadKey):
1058         (WebCore::DiagnosticLoggingKeys::timedOutKey):
1059         (WebCore::DiagnosticLoggingKeys::canceledLessThan2SecondsKey):
1060         (WebCore::DiagnosticLoggingKeys::canceledLessThan5SecondsKey):
1061         (WebCore::DiagnosticLoggingKeys::canceledLessThan20SecondsKey):
1062         (WebCore::DiagnosticLoggingKeys::canceledMoreThan20SecondsKey):
1063         (WebCore::DiagnosticLoggingKeys::failedLessThan2SecondsKey):
1064         (WebCore::DiagnosticLoggingKeys::failedLessThan5SecondsKey):
1065         (WebCore::DiagnosticLoggingKeys::failedLessThan20SecondsKey):
1066         (WebCore::DiagnosticLoggingKeys::failedMoreThan20SecondsKey):
1067         (WebCore::DiagnosticLoggingKeys::occurredKey):
1068         (WebCore::DiagnosticLoggingKeys::succeededLessThan2SecondsKey):
1069         (WebCore::DiagnosticLoggingKeys::succeededLessThan5SecondsKey):
1070         (WebCore::DiagnosticLoggingKeys::succeededLessThan20SecondsKey):
1071         (WebCore::DiagnosticLoggingKeys::succeededMoreThan20SecondsKey):
1072         (WebCore::DiagnosticLoggingKeys::uncacheableStatusCodeKey):
1073         (WebCore::DiagnosticLoggingKeys::underMemoryPressureKey):
1074         (WebCore::DiagnosticLoggingKeys::unknownEntryRequestKey):
1075         (WebCore::DiagnosticLoggingKeys::unlikelyToReuseKey):
1076         (WebCore::DiagnosticLoggingKeys::unsupportedHTTPMethodKey):
1077         (WebCore::DiagnosticLoggingKeys::unsuspendableDOMObjectKey):
1078         (WebCore::DiagnosticLoggingKeys::unusedKey):
1079         (WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
1080         (WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
1081         (WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
1082         (WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
1083         (WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
1084         (WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
1085         (WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
1086         (WebCore::DiagnosticLoggingKeys::usedKey):
1087         (WebCore::DiagnosticLoggingKeys::userZoomActionKey):
1088         (WebCore::DiagnosticLoggingKeys::varyingHeaderMismatchKey):
1089         (WebCore::DiagnosticLoggingKeys::videoKey):
1090         (WebCore::DiagnosticLoggingKeys::visibleNonActiveStateKey):
1091         (WebCore::DiagnosticLoggingKeys::visibleAndActiveStateKey):
1092         (WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithRevalidationKey):
1093         (WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithoutRevalidationKey):
1094         (WebCore::DiagnosticLoggingKeys::webViewKey):
1095         (WebCore::DiagnosticLoggingKeys::yesKey):
1096         (WebCore::DiagnosticLoggingKeys::expiredKey):
1097         (WebCore::DiagnosticLoggingKeys::fontKey):
1098         (WebCore::DiagnosticLoggingKeys::prunedDueToMemoryPressureKey):
1099         (WebCore::DiagnosticLoggingKeys::prunedDueToMaxSizeReached):
1100         (WebCore::DiagnosticLoggingKeys::prunedDueToProcessSuspended):
1101         (WebCore::WebCore::DiagnosticLoggingKeys::notHTTPFamilyKey):
1102         (WebCore::WebCore::DiagnosticLoggingKeys::webGLStateKey):
1103         (WebCore::DiagnosticLoggingKeys::memoryUsageToDiagnosticLoggingKey):
1104         (WebCore::DiagnosticLoggingKeys::foregroundCPUUsageToDiagnosticLoggingKey):
1105         (WebCore::DiagnosticLoggingKeys::backgroundCPUUsageToDiagnosticLoggingKey):
1106         (WebCore::DiagnosticLoggingKeys::resourceLoadStatisticsTelemetryKey):
1107         * page/DisabledAdaptations.cpp:
1108         (WebCore::watchAdaptationName):
1109         * page/EventHandler.cpp:
1110         (WebCore::EventHandler::handlePasteGlobalSelection):
1111         (WebCore::convertDragOperationToDropZoneOperation):
1112         * page/EventSource.cpp:
1113         (WebCore::EventSource::EventSource):
1114         * page/History.cpp:
1115         (WebCore::History::stateObjectAdded):
1116         * page/NavigatorBase.cpp:
1117         (WebCore::NavigatorBase::appName):
1118         (WebCore::NavigatorBase::appCodeName):
1119         * page/Page.cpp:
1120         (WebCore::Page::logNavigation):
1121         * page/PageDebuggable.cpp:
1122         (WebCore::PageDebuggable::url const):
1123         * page/PageSerializer.cpp:
1124         (WebCore::PageSerializer::serializeCSSStyleSheet):
1125         * page/PerformanceMark.h:
1126         * page/PerformanceMeasure.h:
1127         * page/PerformanceObserver.cpp:
1128         (WebCore::PerformanceObserver::observe):
1129         * page/PerformanceResourceTiming.cpp:
1130         (WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
1131         * page/PerformanceUserTiming.cpp:
1132         (WebCore::restrictedMarkFunction):
1133         * page/PointerLockController.cpp:
1134         (WebCore::PointerLockController::requestPointerLock):
1135         * page/PrintContext.cpp:
1136         (WebCore::PrintContext::pageProperty):
1137         * page/SecurityOrigin.cpp:
1138         (WebCore::SecurityOrigin::toString const):
1139         * page/SecurityOriginData.cpp:
1140         (WebCore::SecurityOriginData::toString const):
1141         (WebCore::SecurityOriginData::databaseIdentifier const):
1142         * page/cocoa/ResourceUsageOverlayCocoa.mm:
1143         (WebCore::gcTimerString):
1144         * page/csp/ContentSecurityPolicy.cpp:
1145         (WebCore::ContentSecurityPolicy::reportViolation const):
1146         (WebCore::ContentSecurityPolicy::reportUnsupportedDirective const):
1147         * page/linux/ResourceUsageOverlayLinux.cpp:
1148         (WebCore::cpuUsageString):
1149         (WebCore::gcTimerString):
1150         * platform/ContentType.cpp:
1151         (WebCore::ContentType::codecsParameter):
1152         (WebCore::ContentType::profilesParameter):
1153         * platform/Decimal.cpp:
1154         (WebCore::Decimal::toString const):
1155         * platform/MIMETypeRegistry.cpp:
1156         (WebCore::initializeSupportedImageMIMETypes):
1157         (WebCore::typesForCommonExtension):
1158         (WebCore::initializeUnsupportedTextMIMETypes):
1159         (WebCore::MIMETypeRegistry::getNormalizedMIMEType):
1160         * platform/SchemeRegistry.cpp:
1161         (WebCore::SchemeRegistry::canServiceWorkersHandleURLScheme):
1162         * platform/URL.cpp:
1163         (WebCore::mimeTypeFromDataURL):
1164         * platform/UserAgentQuirks.cpp:
1165         (WebCore::UserAgentQuirks::stringForQuirk):
1166         * platform/cocoa/KeyEventCocoa.mm:
1167         (WebCore::keyForCharCode):
1168         * platform/cocoa/NetworkExtensionContentFilter.mm:
1169         (WebCore::NetworkExtensionContentFilter::unblockHandler const):
1170         * platform/cocoa/ParentalControlsContentFilter.mm:
1171         (WebCore::ParentalControlsContentFilter::unblockHandler const):
1172         * platform/cocoa/PasteboardCocoa.mm:
1173         (WebCore::Pasteboard::fileContentState):
1174         * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
1175         (WebCore::MacApplication::isSafari):
1176         (WebCore::MacApplication::isAppleMail):
1177         (WebCore::MacApplication::isIBooks):
1178         (WebCore::MacApplication::isITunes):
1179         (WebCore::MacApplication::isMicrosoftMessenger):
1180         (WebCore::MacApplication::isAdobeInstaller):
1181         (WebCore::MacApplication::isAOLInstantMessenger):
1182         (WebCore::MacApplication::isMicrosoftMyDay):
1183         (WebCore::MacApplication::isMicrosoftOutlook):
1184         (WebCore::MacApplication::isQuickenEssentials):
1185         (WebCore::MacApplication::isAperture):
1186         (WebCore::MacApplication::isVersions):
1187         (WebCore::MacApplication::isHRBlock):
1188         (WebCore::MacApplication::isIAdProducer):
1189         (WebCore::MacApplication::isSolidStateNetworksDownloader):
1190         (WebCore::IOSApplication::isMobileMail):
1191         (WebCore::IOSApplication::isMobileSafari):
1192         (WebCore::IOSApplication::isWebBookmarksD):
1193         (WebCore::IOSApplication::isDumpRenderTree):
1194         (WebCore::IOSApplication::isMobileStore):
1195         (WebCore::IOSApplication::isSpringBoard):
1196         (WebCore::IOSApplication::isWebApp):
1197         (WebCore::IOSApplication::isIBooks):
1198         (WebCore::IOSApplication::isIBooksStorytime):
1199         (WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
1200         (WebCore::IOSApplication::isCardiogram):
1201         (WebCore::IOSApplication::isNike):
1202         * platform/cocoa/UserAgentCocoa.mm:
1203         (WebCore::userAgentBundleVersion):
1204         * platform/gamepad/cocoa/GameControllerGamepad.mm:
1205         (WebCore::GameControllerGamepad::setupAsExtendedGamepad):
1206         (WebCore::GameControllerGamepad::setupAsGamepad):
1207         * platform/graphics/InbandTextTrackPrivateClient.h:
1208         (WebCore::GenericCueData::toJSONString const):
1209         * platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
1210         (WebCore::CDMFactoryFairPlayStreaming::supportsKeySystem):
1211         * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
1212         (WebCore::isEqual):
1213         (WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
1214         (WebCore::CDMInstanceFairPlayStreamingAVFObjC::keySystem const):
1215         * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
1216         (WebCore::CDMSessionAVContentKeySession::generateKeyRequest):
1217         * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
1218         (WebCore::CDMSessionAVStreamSession::generateKeyRequest):
1219         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
1220         (WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
1221         * platform/graphics/ca/GraphicsLayerCA.cpp:
1222         (WebCore::propertyIdToString):
1223         * platform/graphics/ca/TileController.cpp:
1224         (WebCore::TileController::tileGridContainerLayerName):
1225         (WebCore::TileController::zoomedOutTileGridContainerLayerName):
1226         * platform/graphics/cg/ImageBufferCG.cpp:
1227         (WebCore::ImageBuffer::toDataURL const):
1228         (WebCore::dataURL):
1229         * platform/graphics/cv/VideoTextureCopierCV.cpp:
1230         (WebCore::VideoTextureCopierCV::initializeContextObjects):
1231         (WebCore::VideoTextureCopierCV::initializeUVContextObjects):
1232         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1233         (WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
1234         (WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):
1235         * platform/graphics/iso/ISOVTTCue.cpp:
1236         (WebCore::ISOWebVTTCue::toJSONString const):
1237         * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:
1238         (Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):
1239         * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
1240         (WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions):
1241         * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
1242         (WebCore::GraphicsContext3D::getUnmangledInfoLog):
1243         * platform/graphics/texmap/TextureMapperContextAttributes.cpp:
1244         (WebCore::TextureMapperContextAttributes::get):
1245         * platform/graphics/win/ImageBufferDirect2D.cpp:
1246         (WebCore::ImageBuffer::toDataURL const):
1247         (WebCore::ImageDataToDataURL):
1248         * platform/gtk/PasteboardGtk.cpp:
1249         (WebCore::Pasteboard::typesForLegacyUnsafeBindings):
1250         * platform/gtk/PasteboardHelper.cpp:
1251         * platform/gtk/PlatformKeyboardEventGtk.cpp:
1252         (WebCore::PlatformKeyboardEvent::keyValueForGdkKeyCode):
1253         (WebCore::PlatformKeyboardEvent::keyCodeForHardwareKeyCode):
1254         * platform/image-decoders/bmp/BMPImageDecoder.h:
1255         * platform/image-decoders/gif/GIFImageDecoder.h:
1256         * platform/image-decoders/ico/ICOImageDecoder.h:
1257         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
1258         * platform/image-decoders/png/PNGImageDecoder.h:
1259         * platform/image-decoders/webp/WEBPImageDecoder.h:
1260         * platform/ios/Device.cpp:
1261         (WebCore::deviceName):
1262         * platform/ios/PasteboardIOS.mm:
1263         (WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):
1264         * platform/ios/PlatformEventFactoryIOS.mm:
1265         (WebCore::keyForKeyEvent):
1266         (WebCore::codeForKeyEvent):
1267         * platform/ios/PlatformPasteboardIOS.mm:
1268         (WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
1269         * platform/mac/PasteboardMac.mm:
1270         (WebCore::Pasteboard::read):
1271         (WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):
1272         * platform/mac/PlatformEventFactoryMac.mm:
1273         (WebCore::keyForKeyEvent):
1274         (WebCore::codeForKeyEvent):
1275         * platform/mac/PlatformPasteboardMac.mm:
1276         (WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
1277         * platform/mediastream/MediaConstraints.cpp:
1278         (WebCore::addDefaultVideoConstraints):
1279         * platform/mediastream/PeerMediaDescription.h:
1280         * platform/mediastream/RealtimeMediaSource.cpp:
1281         (WebCore::RealtimeMediaSource::applyConstraints):
1282         * platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:
1283         (WebCore::DisplayCaptureManagerCocoa::screenCaptureDeviceWithPersistentID):
1284         * platform/mock/MockRealtimeMediaSource.cpp:
1285         (WebCore::deviceMap):
1286         (WebCore::MockRealtimeMediaSource::audioDevices):
1287         (WebCore::MockRealtimeMediaSource::videoDevices):
1288         (WebCore::MockRealtimeMediaSource::displayDevices):
1289         * platform/mock/MockRealtimeVideoSource.cpp:
1290         (WebCore::MockRealtimeVideoSource::drawText):
1291         * platform/network/BlobRegistryImpl.cpp:
1292         (WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):
1293         * platform/network/DataURLDecoder.cpp:
1294         (WebCore::DataURLDecoder::parseMediaType):
1295         * platform/network/FormData.cpp:
1296         (WebCore::FormData::appendMultiPartFileValue):
1297         * platform/network/HTTPParsers.cpp:
1298         (WebCore::parseHTTPRequestLine):
1299         (WebCore::parseHTTPHeader):
1300         (WebCore::normalizeHTTPMethod):
1301         * platform/network/ResourceRequestBase.cpp:
1302         (WebCore::ResourceRequestBase::redirectedRequest const):
1303         * platform/network/ResourceRequestBase.h:
1304         (WebCore::ResourceRequestBase::ResourceRequestBase):
1305         * platform/network/curl/ResourceHandleCurl.cpp:
1306         (WebCore::ResourceHandle::handleDataURL):
1307         * platform/network/curl/SynchronousLoaderClientCurl.cpp:
1308         (WebCore::SynchronousLoaderClient::platformBadResponseError):
1309         * platform/network/win/DownloadBundleWin.cpp:
1310         (WebCore::DownloadBundle::fileExtension):
1311         * platform/sql/SQLiteDatabase.cpp:
1312         (WebCore::SQLiteDatabase::open):
1313         (WebCore::SQLiteDatabase::setFullsync):
1314         (WebCore::SQLiteDatabase::maximumSize):
1315         (WebCore::SQLiteDatabase::pageSize):
1316         (WebCore::SQLiteDatabase::freeSpaceSize):
1317         (WebCore::SQLiteDatabase::totalSize):
1318         (WebCore::SQLiteDatabase::clearAllTables):
1319         (WebCore::SQLiteDatabase::runVacuumCommand):
1320         (WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
1321         (WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
1322         * platform/sql/SQLiteFileSystem.cpp:
1323         (WebCore::SQLiteFileSystem::deleteDatabaseFile):
1324         * platform/text/LocaleICU.cpp:
1325         (WebCore::LocaleICU::dateFormat):
1326         (WebCore::getFormatForSkeleton):
1327         * platform/text/LocaleNone.cpp:
1328         (WebCore::LocaleNone::dateFormat):
1329         (WebCore::LocaleNone::monthFormat):
1330         (WebCore::LocaleNone::shortMonthFormat):
1331         (WebCore::LocaleNone::timeFormat):
1332         (WebCore::LocaleNone::shortTimeFormat):
1333         (WebCore::LocaleNone::dateTimeFormatWithSeconds):
1334         (WebCore::LocaleNone::dateTimeFormatWithoutSeconds):
1335         * platform/text/LocaleToScriptMappingDefault.cpp:
1336         (WebCore::scriptNameToCode):
1337         (WebCore::localeToScriptCodeForFontSelection):
1338         * platform/text/TextEncodingRegistry.cpp:
1339         (WebCore::defaultTextEncodingNameForSystemLanguage):
1340         * platform/win/FileSystemWin.cpp:
1341         (WebCore::FileSystem::bundleName):
1342         * platform/wpe/RenderThemeWPE.cpp:
1343         (WebCore::RenderThemeWPE::mediaControlsStyleSheet):
1344         * rendering/RenderMenuList.cpp:
1345         (RenderMenuList::setText):
1346         * rendering/RenderThemeIOS.mm:
1347         (WebCore::RenderThemeIOS::extraDefaultStyleSheet):
1348         * svg/SVGComponentTransferFunctionElement.h:
1349         (WebCore::SVGPropertyTraits<ComponentTransferType>::toString):
1350         * svg/SVGFEColorMatrixElement.h:
1351         (WebCore::SVGPropertyTraits<ColorMatrixType>::toString):
1352         * svg/SVGFECompositeElement.h:
1353         (WebCore::SVGPropertyTraits<CompositeOperationType>::toString):
1354         * svg/SVGFEConvolveMatrixElement.h:
1355         (WebCore::SVGPropertyTraits<EdgeModeType>::toString):
1356         * svg/SVGFEDisplacementMapElement.h:
1357         (WebCore::SVGPropertyTraits<ChannelSelectorType>::toString):
1358         * svg/SVGFEMorphologyElement.h:
1359         (WebCore::SVGPropertyTraits<MorphologyOperatorType>::toString):
1360         * svg/SVGFETurbulenceElement.h:
1361         (WebCore::SVGPropertyTraits<SVGStitchOptions>::toString):
1362         (WebCore::SVGPropertyTraits<TurbulenceType>::toString):
1363         * svg/SVGGradientElement.h:
1364         (WebCore::SVGPropertyTraits<SVGSpreadMethodType>::toString):
1365         * svg/SVGLocatable.cpp:
1366         (WebCore::SVGLocatable::getTransformToElement):
1367         * svg/SVGMarkerTypes.h:
1368         (WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::toString):
1369         * svg/SVGMatrixValue.h:
1370         * svg/SVGSVGElement.cpp:
1371         (WebCore::SVGSVGElement::SVGSVGElement):
1372         (WebCore::SVGSVGElement::parseAttribute):
1373         * svg/SVGTextContentElement.h:
1374         (WebCore::SVGPropertyTraits<SVGLengthAdjustType>::toString):
1375         * svg/SVGTextPathElement.h:
1376         (WebCore::SVGPropertyTraits<SVGTextPathMethodType>::toString):
1377         (WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::toString):
1378         * svg/SVGToOTFFontConversion.cpp:
1379         (WebCore::SVGToOTFFontConverter::appendCFFTable):
1380         * svg/SVGUnitTypes.h:
1381         (WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::toString):
1382         * svg/SVGUseElement.cpp:
1383         (WebCore::SVGUseElement::toClipPath):
1384         * svg/graphics/SVGImage.cpp:
1385         (WebCore::SVGImage::filenameExtension const):
1386         * testing/InternalSettings.cpp:
1387         (WebCore::InternalSettings::userInterfaceDirectionPolicy):
1388         (WebCore::InternalSettings::systemLayoutDirection):
1389         * testing/Internals.cpp:
1390         (WebCore::Internals::areSVGAnimationsPaused const):
1391         (WebCore::Internals::accessKeyModifiers const):
1392         (WebCore::Internals::setMediaDeviceState):
1393         (WebCore::Internals::audioSessionCategory const):
1394         (WebCore::Internals::systemPreviewRelType):
1395         * testing/MockCDMFactory.cpp:
1396         (WebCore::MockCDM::sanitizeResponse const):
1397         (WebCore::MockCDMInstance::updateLicense):
1398         * testing/MockContentFilter.cpp:
1399         (WebCore::MockContentFilter::unblockRequestDeniedScript const):
1400         * testing/MockCredentialsMessenger.cpp:
1401         (WebCore::MockCredentialsMessenger::~MockCredentialsMessenger):
1402         (WebCore::MockCredentialsMessenger::makeCredential):
1403         (WebCore::MockCredentialsMessenger::getAssertion):
1404         * testing/MockPaymentCoordinator.cpp:
1405         (WebCore::MockPaymentCoordinator::showPaymentUI):
1406         * workers/WorkerRunLoop.cpp:
1407         (WebCore::WorkerRunLoop::debuggerMode):
1408         * workers/WorkerScriptLoader.cpp:
1409         (WebCore::WorkerScriptLoader::loadSynchronously):
1410         (WebCore::WorkerScriptLoader::createResourceRequest):
1411         (WebCore::WorkerScriptLoader::didReceiveData):
1412         * workers/service/ExtendableEvent.cpp:
1413         (WebCore::ExtendableEvent::waitUntil):
1414         * workers/service/FetchEvent.cpp:
1415         (WebCore::FetchEvent::~FetchEvent):
1416         (WebCore::FetchEvent::respondWith):
1417         (WebCore::FetchEvent::promiseIsSettled):
1418         * workers/service/SWClientConnection.cpp:
1419         (WebCore::SWClientConnection::clearPendingJobs):
1420         * workers/service/ServiceWorker.cpp:
1421         (WebCore::ServiceWorker::postMessage):
1422         * workers/service/ServiceWorkerClients.cpp:
1423         (WebCore::ServiceWorkerClients::openWindow):
1424         (WebCore::ServiceWorkerClients::claim):
1425         * workers/service/ServiceWorkerContainer.cpp:
1426         (WebCore::ServiceWorkerContainer::addRegistration):
1427         (WebCore::ServiceWorkerContainer::getRegistration):
1428         (WebCore::ServiceWorkerContainer::startScriptFetchForJob):
1429         * workers/service/ServiceWorkerJob.cpp:
1430         (WebCore::ServiceWorkerJob::fetchScriptWithContext):
1431         (WebCore::ServiceWorkerJob::didReceiveResponse):
1432         * workers/service/ServiceWorkerRegistration.cpp:
1433         (WebCore::ServiceWorkerRegistration::update):
1434         * workers/service/ServiceWorkerWindowClient.cpp:
1435         (WebCore::ServiceWorkerWindowClient::focus):
1436         (WebCore::ServiceWorkerWindowClient::navigate):
1437         * workers/service/context/ServiceWorkerDebuggable.h:
1438         * workers/service/context/ServiceWorkerFetch.cpp:
1439         (WebCore::ServiceWorkerFetch::dispatchFetchEvent):
1440         * workers/service/server/RegistrationDatabase.cpp:
1441         (WebCore::RegistrationDatabase::doPushChanges):
1442         (WebCore::RegistrationDatabase::importRecords):
1443         * workers/service/server/SWServerJobQueue.cpp:
1444         (WebCore::SWServerJobQueue::runRegisterJob):
1445         (WebCore::SWServerJobQueue::runUnregisterJob):
1446         (WebCore::SWServerJobQueue::runUpdateJob):
1447         * xml/XMLErrors.cpp:
1448         (WebCore::createXHTMLParserErrorHeader):
1449         (WebCore::XMLErrors::insertErrorMessageBlock):
1450         * xml/XMLHttpRequest.cpp:
1451         (WebCore::XMLHttpRequest::send):
1452         (WebCore::XMLHttpRequest::responseMIMEType const):
1453         * xml/XMLTreeViewer.cpp:
1454         (WebCore::XMLTreeViewer::transformDocumentToTreeView):
1455         * xml/XPathPredicate.cpp:
1456         (WebCore::XPath::evaluatePredicate):
1457         * xml/XPathValue.cpp:
1458         (WebCore::XPath::Value::toString const):
1459         * xml/parser/CharacterReferenceParserInlines.h:
1460         (WebCore::consumeCharacterReference):
1461
1462 2018-06-22  Youenn Fablet  <youenn@apple.com>
1463
1464         Disable WebSocket in WatchOS
1465         https://bugs.webkit.org/show_bug.cgi?id=186931
1466         <rdar://problem/39584458>
1467
1468         Reviewed by Wenson Hsieh.
1469
1470         Add a runtime flag to enable/disable WebSocket.
1471         By default, flag is on for all platforms except for WatchOS.
1472
1473         Test: fast/dom/Window/watchos/websocket/watchos/no-websocket-in-watchos.html
1474
1475         * Modules/websockets/WebSocket.idl:
1476         * page/RuntimeEnabledFeatures.cpp:
1477         (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
1478         * page/RuntimeEnabledFeatures.h:
1479         (WebCore::RuntimeEnabledFeatures::setWebSocketEnabled):
1480         (WebCore::RuntimeEnabledFeatures::webSocketEnabled const):
1481
1482 2018-06-22  Woodrow Wang  <woodrow_wang@apple.com>
1483
1484         SubresourceLoader::didFail() should only log message if state is Initialized
1485         https://bugs.webkit.org/show_bug.cgi?id=185124
1486
1487         Reviewed by Daniel Bates.
1488
1489         Functionality does not change. Moved console logging to be 
1490         after checking state of subresource loader. We only need to 
1491         log if the state is initialized. This is consistent with other
1492         functions in the file. We can also remove a null check for the 
1493         frame pointer (m_frame). The superclass ResourceLoader constructor
1494         takes an lvalue reference and initializes m_frame, ensuring
1495         m_frame cannot be null. It is only set to null by 
1496         ResourceLoader::releaseResources(), which is only called after the 
1497         resource finishes loading or fails to load. Thus, in didFail(), 
1498         m_frame must be non-null when we're logging and up until the end of the function.  
1499
1500         * loader/SubresourceLoader.cpp:
1501         (WebCore::SubresourceLoader::didFail):
1502
1503 2018-06-22  Timothy Hatcher  <timothy@apple.com>
1504
1505         Corner of two scroll bars is white with dark mode enabled.
1506         https://bugs.webkit.org/show_bug.cgi?id=186819
1507         rdar://problem/40434350
1508
1509         Reviewed by Tim Horton.
1510
1511         * Configurations/WebCore.xcconfig:
1512         * WebCore.xcodeproj/project.pbxproj:
1513         * inspector/InspectorOverlay.cpp:
1514         (WebCore::InspectorOverlay::paint): Added LocalDefaultSystemAppearance.
1515         * page/Page.h:
1516         * platform/ScrollView.cpp:
1517         (WebCore::ScrollView::paintScrollCorner): Dropped ScrollView argument.
1518         * platform/ScrollbarTheme.h:
1519         (WebCore::ScrollbarTheme::paintScrollCorner): Ditto.
1520         * platform/ScrollbarThemeComposite.cpp:
1521         (WebCore::ScrollbarThemeComposite::paintScrollCorner): Deleted. Default is the same.
1522         * platform/ScrollbarThemeComposite.h:
1523         * platform/mac/LocalDefaultSystemAppearance.h:
1524         * platform/mac/LocalDefaultSystemAppearance.mm:
1525         (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Added recursion early return.
1526         (WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): Ditto.
1527         * platform/mac/ScrollbarThemeMac.h:
1528         * platform/mac/ScrollbarThemeMac.mm:
1529         (WebCore::ScrollbarThemeMac::paintScrollCorner): Added.
1530         * rendering/RenderLayer.cpp:
1531         (WebCore::RenderLayer::paintScrollCorner): Call ScrollbarTheme::paintScrollCorner.
1532         * rendering/RenderLayerBacking.cpp:
1533         (WebCore::RenderLayerBacking::paintContents): Added LocalDefaultSystemAppearance.
1534         * rendering/RenderLayerCompositor.cpp:
1535         (WebCore::RenderLayerCompositor::paintContents): Added LocalDefaultSystemAppearance.
1536         * rendering/RenderScrollbarTheme.cpp:
1537         (WebCore::RenderScrollbarTheme::paintScrollCorner): Call ScrollbarTheme::paintScrollCorner.
1538         * rendering/RenderScrollbarTheme.h:
1539         * svg/graphics/SVGImage.cpp:
1540         (WebCore::SVGImage::draw): Added LocalDefaultSystemAppearance.
1541
1542 2018-06-22  Tim Horton  <timothy_horton@apple.com>
1543
1544         Make it possible to add a border around loading or failed-to-load images
1545         https://bugs.webkit.org/show_bug.cgi?id=186614
1546         <rdar://problem/39050152>
1547
1548         Reviewed by Zalan Bujtas.
1549
1550         Tests: http/tests/images/loading-image-border.html
1551                http/tests/images/loading-image-no-border.html
1552
1553         * rendering/RenderImage.cpp:
1554         (WebCore::RenderImage::paintIncompleteImageOutline):
1555         (WebCore::RenderImage::paintReplaced):
1556         * rendering/RenderImage.h:
1557         Factor the missing-image outline out, and - if desired - paint it in
1558         cases where the image is still loading or otherwise pending, not just
1559         when the image fails to load.
1560
1561         * page/Settings.yaml:
1562         * testing/InternalSettings.cpp:
1563         (WebCore::InternalSettings::Backup::Backup):
1564         (WebCore::InternalSettings::Backup::restoreTo):
1565         (WebCore::InternalSettings::setIncompleteImageBorderEnabled):
1566         * testing/InternalSettings.h:
1567         * testing/InternalSettings.idl:
1568         Add and expose a setting to enable the feature.
1569
1570 2018-06-22  Brady Eidson  <beidson@apple.com>
1571
1572         WKURLSchemeHandler doesn't handle sync XHR.
1573         <rdar://problem/40955884> and https://bugs.webkit.org/show_bug.cgi?id=186902
1574
1575         Reviewed by Chris Dumez.
1576
1577         * English.lproj/Localizable.strings:
1578
1579 2018-06-22  Jer Noble  <jer.noble@apple.com>
1580
1581         [Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit fullscreen handler after r231924
1582         https://bugs.webkit.org/show_bug.cgi?id=186945
1583         <rdar://problem/37277469>
1584
1585         Reviewed by Simon Fraser.
1586
1587         * platform/ios/VideoFullscreenInterfaceAVKit.mm:
1588         (VideoFullscreenInterfaceAVKit::exitFullscreen):
1589         (VideoFullscreenInterfaceAVKit::exitFullscreenHandler):
1590         (VideoFullscreenInterfaceAVKit::cleanupFullscreen):
1591
1592 2018-06-22  Per Arne Vollan  <pvollan@apple.com>
1593
1594         Unreviewed build fix on Windows.
1595
1596         * testing/Internals.h:
1597
1598 2018-06-22  Youenn Fablet  <youenn@apple.com>
1599
1600         Incoming G722 doesn't work
1601         https://bugs.webkit.org/show_bug.cgi?id=186307
1602         <rdar://problem/40809745>
1603
1604         Reviewed by Eric Carlson.
1605
1606         WebRTC backends usually does the following:
1607         - Initially call RealtimeIncomingAudioSource with 16KHz data
1608         - Switch to 48KHz when actual data is decoded.
1609         We added a check that was discarding any 16KHz data, but in case of G722, the data remains as 16KHz and is then never read.
1610         The solution is to remove the check that discards 16KHz information.
1611         We then need to fix a bug in AudioTrackPrivateMediaStreamCocoa that was preventing proper handling of change of audio data configuration.
1612
1613         Test: webrtc/audio-peer-connection-g722.html
1614
1615         * platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
1616         (WebCore::AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable):
1617         * platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:
1618         (WebCore::RealtimeIncomingAudioSourceCocoa::OnData):
1619
1620 2018-06-22  Timothy Hatcher  <timothy@apple.com>
1621
1622         Recalc styles every time defaultAppearance changes.
1623         https://bugs.webkit.org/show_bug.cgi?id=186866
1624         rdar://problem/41309805
1625
1626         Reviewed by Tim Horton.
1627
1628         * page/Page.cpp:
1629         (WebCore::Page::setUseSystemAppearance): Added. Recalc styles and update system colors.
1630         (WebCore::Page::setDefaultAppearance): Added. Ditto.
1631         * page/Page.h:
1632         (WebCore::Page::setUseSystemAppearance): Deleted impl.
1633         (WebCore::Page::setDefaultAppearance): Deleted impl.
1634
1635 2018-06-22  Thibault Saunier  <tsaunier@igalia.com>
1636
1637         [GStreamer] Avoid sending SELECT_STREAM events when nothing changed
1638         https://bugs.webkit.org/show_bug.cgi?id=186678
1639
1640         Reviewed by Philippe Normand.
1641
1642         This avoid extra work in decodebin3 and should work around a crash
1643         in decodebin3 when we send spurious SELECT_STREAM in the mediastream
1644         layout tests.
1645
1646         GStreamer was also missing safe guards in the GstStream APIs which have been
1647         added in gstreamer core in 8833ca942ea21c58c0f63822f0e2b61695b39447
1648         "stream: Add some missing API safe guards".
1649
1650         Should fix following flakes:
1651           - fast/mediastream/MediaStream-video-element-track-stop.html
1652           - fast/mediastream/change-tracks-media-stream-being-played.html
1653
1654         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1655         (WebCore::MediaPlayerPrivateGStreamer::enableTrack):
1656
1657 2018-06-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1658
1659         REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
1660         https://bugs.webkit.org/show_bug.cgi?id=186206
1661
1662         Unreviewed manual rollout of r230950
1663
1664         * platform/graphics/texmap/TextureMapperLayer.h:
1665         * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
1666         (WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
1667
1668 2018-06-20  Darin Adler  <darin@apple.com>
1669
1670         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
1671         https://bugs.webkit.org/show_bug.cgi?id=186875
1672
1673         Reviewed by Anders Carlsson.
1674
1675         * platform/cocoa/ThemeCocoa.mm:
1676         (WebCore::passKitBundle): Use isDirectory:YES when creating a URL pointing to a framework,
1677         since frameworks are directories.
1678
1679 2018-06-22  Miguel Gomez  <magomez@igalia.com>
1680
1681         [WPE][ThreadedRendering] WPE crashes rendering SVG content when using ThreadedRendering
1682         https://bugs.webkit.org/show_bug.cgi?id=186914
1683
1684         Reviewed by Carlos Garcia Campos.
1685
1686         Add GraphicsContextImpl::clipToImageBuffer() to the interface and the implementors. Forward
1687         the call to GraphicsContext::clipToImageBuffer() to the implementation if possible in the
1688         cairo case.
1689
1690         Covered by existent tests.
1691
1692         * platform/graphics/GraphicsContextImpl.h:
1693         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1694         (WebCore::GraphicsContext::clipToImageBuffer):
1695         * platform/graphics/cairo/GraphicsContextImplCairo.cpp:
1696         (WebCore::GraphicsContextImplCairo::clipToImageBuffer):
1697         * platform/graphics/cairo/GraphicsContextImplCairo.h:
1698         * platform/graphics/displaylists/DisplayListRecorder.cpp:
1699         (WebCore::DisplayList::Recorder::clipToImageBuffer):
1700         * platform/graphics/displaylists/DisplayListRecorder.h:
1701         * platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
1702         (Nicosia::CairoOperationRecorder::clipToImageBuffer):
1703         * platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
1704
1705 2018-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1706
1707         [CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
1708         https://bugs.webkit.org/show_bug.cgi?id=186911
1709
1710         Reviewed by Michael Catanzaro.
1711
1712         This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
1713         didn't start a clean build. The problem is that the CMake command to generate
1714         SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
1715         SelectorPseudoClassAndCompatibilityElementMap.in.
1716
1717         * CMakeLists.txt:
1718
1719 2018-06-22  Miguel Gomez  <magomez@igalia.com>
1720
1721         [WPE][ThreadedRendering] WPE crashes rendering some pieces of text when using ThreadedRendering
1722         https://bugs.webkit.org/show_bug.cgi?id=186886
1723
1724         Reviewed by Žan Doberšek.
1725
1726         Modify DisplayList DrawGlyphs element to use a GraphicsContext for replaying. To do so, modify
1727         GraphicsContext::drawGlyphs() API so it doesn't require a FontCascade, and update all the calls
1728         to it.
1729
1730         Covered by existent tests.
1731
1732         * platform/graphics/FontCascade.cpp:
1733         (WebCore::FontCascade::drawGlyphBuffer const):
1734         * platform/graphics/GraphicsContext.cpp:
1735         (WebCore::GraphicsContext::drawGlyphs):
1736         * platform/graphics/GraphicsContext.h:
1737         * platform/graphics/displaylists/DisplayListItems.cpp:
1738         (WebCore::DisplayList::DrawGlyphs::apply const):
1739         * rendering/mathml/MathOperator.cpp:
1740         (WebCore::MathOperator::paintGlyph):
1741         (WebCore::MathOperator::paint):
1742         * rendering/mathml/RenderMathMLToken.cpp:
1743         (WebCore::RenderMathMLToken::paint):
1744
1745 2018-06-15  Jer Noble  <jer.noble@apple.com>
1746
1747         Address fullscreen api CSS env feedback
1748         https://bugs.webkit.org/show_bug.cgi?id=186684
1749
1750         Reviewed by Simon Fraser.
1751
1752         Test: fullscreen/fullscreen-env.html
1753
1754         + Update the phishing alert text to be more explicit about the specific threats
1755           phishing sites represent.
1756         + Make the top inset static, rather than dynamic.
1757         + Add bottom, left, and right insets for completeness.
1758         + Set the fullscreen animation duration as well as delay.
1759         + Notify the page when the controls show and hide.
1760
1761         * English.lproj/Localizable.strings:
1762         * css/CSSSelector.cpp:
1763         (WebCore::CSSSelector::selectorText const):
1764         * css/CSSSelector.h:
1765         * css/SelectorChecker.cpp:
1766         (WebCore::SelectorChecker::checkOne const):
1767         * css/SelectorCheckerTestFunctions.h:
1768         (WebCore::matchesFullScreenControlsHiddenPseudoClass):
1769         * css/SelectorPseudoClassAndCompatibilityElementMap.in:
1770         * cssjit/SelectorCompiler.cpp:
1771         (WebCore::SelectorCompiler::addPseudoClassType):
1772         * dom/ConstantPropertyMap.cpp:
1773         (WebCore::ConstantPropertyMap::nameForProperty const):
1774         (WebCore::ConstantPropertyMap::updateConstantsForFullscreenInsets):
1775         (WebCore::ConstantPropertyMap::didChangeFullscreenInsets):
1776         (WebCore::ConstantPropertyMap::setFullscreenAutoHideDuration):
1777         (WebCore::ConstantPropertyMap::setFullscreenInsetTop): Deleted.
1778         * dom/ConstantPropertyMap.h:
1779         * dom/Document.cpp:
1780         (WebCore::Document::areFullscreenControlsHidden const):
1781         (WebCore::Document::setFullscreenControlsHidden):
1782         * dom/Document.h:
1783         * page/Page.cpp:
1784         (WebCore::Page::setFullscreenInsets):
1785         (WebCore::Page::setFullscreenAutoHideDuration):
1786         (WebCore::Page::setFullscreenControlsHidden):
1787         (WebCore::Page::setFullscreenInsetTop): Deleted.
1788         * page/Page.h:
1789         (WebCore::Page::fullscreenInsets const):
1790         * testing/Internals.cpp:
1791         (WebCore::Internals::resetToConsistentState):
1792         (WebCore::Internals::setFullscreenInsets):
1793         (WebCore::Internals::setFullscreenAutoHideDuration):
1794         (WebCore::Internals::setFullscreenControlsHidden):
1795         (WebCore::Internals::setFullscreenInsetTop): Deleted.
1796         * testing/Internals.h:
1797         * testing/Internals.idl:
1798
1799 2018-06-21  Jer Noble  <jer.noble@apple.com>
1800
1801         [Fullscreen] Page sometimes ends up with an incorrect zoom level after entering fullscreen
1802         https://bugs.webkit.org/show_bug.cgi?id=186822
1803
1804         Reviewed by Simon Fraser.
1805
1806         * dom/Document.cpp:
1807         (WebCore::Document::setOverrideViewportArguments):
1808         (WebCore::Document::updateViewportArguments):
1809         * dom/Document.h:
1810
1811 2018-06-20  Said Abou-Hallawa  <sabouhallawa@apple.com>
1812
1813         RenderSVGInline has to be inline always regardless of its css display value
1814         https://bugs.webkit.org/show_bug.cgi?id=186656
1815
1816         Reviewed by Zalan Bujtas.
1817
1818         According to https://www.w3.org/TR/SVG2/text.html#TextLayout, the <text>
1819         element has to be laid out as if it were a block element and any <tspan>,
1820         <textPath>, <a> and <tref> descendants were inline elements.
1821
1822         If a css rule, which contains the property "display: block;", is applied
1823         to any of children of a <text> element, this property has to be ignored.
1824
1825         We currently ignore this property in RenderSVGInline::updateFromStyle()
1826         by forcing setInline(true). But we do not do the same thing in 
1827         RenderTreeBuilder::normalizeTreeAfterStyleChange(). In fact we allow
1828         making the children of the <text> element to be non-inline. This puts
1829         the render tree in weired state and causes many assertions to fire while
1830         laying out RenderSVGText. 
1831
1832         Test: svg/dom/svg-inline-text-display-block-crash.html
1833
1834         * rendering/updating/RenderTreeBuilder.cpp:
1835         (WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange):
1836
1837 2018-06-20  Zalan Bujtas  <zalan@apple.com>
1838
1839         Do not reuse generated inline renderer for the first letter.
1840         https://bugs.webkit.org/show_bug.cgi?id=186657
1841         <rdar://problem/41157892>
1842
1843         Reviewed by Simon Fraser.
1844
1845         When the first letter pseudo element is present, we construct a dedicated subtree for its content like this:
1846
1847         <div><span>foobar</span></div> -> with ::first-letter on the <div>
1848         DIV RenderBlock
1849             SPAN RenderInline
1850                 RenderInline (generated wrapper for the first letter content)
1851                     RenderText (fist letter content)
1852                 RenderText (remaining text content)
1853
1854         "display: contents" on the <span> forces us not to construct a RenderInline for the <span> (or just come up with a wrapper at best).
1855         FirstLetter::createRenderers logic needs to check for such cases and pick the correct parent for the first letter subtree accordingly.
1856
1857         Test: fast/text/first-letter-with-display-contents-crash.html
1858               imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html is not crashing anymore either.
1859
1860         * rendering/updating/RenderTreeBuilderFirstLetter.cpp:
1861         (WebCore::RenderTreeBuilder::FirstLetter::createRenderers):
1862
1863 2018-06-21  Chris Dumez  <cdumez@apple.com>
1864
1865         JSPerformanceObserverCallback creates a GC strongly-referenced Function that is never cleaned up
1866         https://bugs.webkit.org/show_bug.cgi?id=186873
1867         <rdar://problem/41271574>
1868
1869         Reviewed by Simon Fraser.
1870
1871         Add [IsWeakCallback] to PerformanceObserverCallback interface so that the generated
1872         JSPerformanceObserverCallback uses a JSC::Weak instead of a JSC::Strong to store the
1873         js function. To keep the function alive, add [JSCustomMarkFunction] to PerformanceObserver
1874         interface and have its visitAdditionalChildren() visit the callback's js function.
1875         Finally, because we want the callback to still be called even if the JS does not keep
1876         the PerformanceObserver wrapper alive, add [CustomIsReachable] to PerformanceObserver
1877         interface and have its isReachableFromOpaqueRoots() return true if the observer is
1878         registered (i.e. it may need to call the callback in the future).
1879
1880         I have confirmed locally, that the Performance / PerformanceObserver / Document
1881         objects properly get destroyed if I navigate away from a page that had a performance
1882         observer and trigger a memory pressure warning. Also,
1883         `notifyutil -p com.apple.WebKit.showAllDocuments` no longer shows the old document.
1884
1885         Tests: performance-api/performance-observer-callback-after-gc.html
1886                performance-api/performance-observer-no-document-leak.html
1887
1888         * Sources.txt:
1889         * WebCore.xcodeproj/project.pbxproj:
1890         * bindings/js/JSPerformanceObserverCustom.cpp: Added.
1891         (WebCore::JSPerformanceObserver::visitAdditionalChildren):
1892         (WebCore::JSPerformanceObserverOwner::isReachableFromOpaqueRoots):
1893         * bindings/js/ScriptController.cpp:
1894         * page/PerformanceObserver.cpp:
1895         (WebCore::PerformanceObserver::disassociate):
1896         * page/PerformanceObserver.h:
1897         (WebCore::PerformanceObserver::isRegistered const):
1898         (WebCore::PerformanceObserver::callback):
1899         * page/PerformanceObserver.idl:
1900         * page/PerformanceObserverCallback.h:
1901         * page/PerformanceObserverCallback.idl:
1902
1903 2018-06-20  Antoine Quint  <graouts@apple.com>
1904
1905         [Web Animations] Make imported/mozilla/css-animations/test_animation-ready.html pass reliably
1906         https://bugs.webkit.org/show_bug.cgi?id=183830
1907         <rdar://problem/40997539>
1908
1909         Reviewed by Dean Jackson.
1910
1911         The CSS Animations Level 2 spec explains how the Web Animations API and CSS Animations interact and requires
1912         pending styles changes on the target element of a CSS Animation to be flushed when using a Web Animations API
1913         on it in order to ensure that any animation- CSS property is accounted for.
1914
1915         * animation/CSSAnimation.cpp:
1916         (WebCore::CSSAnimation::bindingsStartTime const):
1917         (WebCore::CSSAnimation::setBindingsStartTime):
1918         (WebCore::CSSAnimation::bindingsCurrentTime const):
1919         (WebCore::CSSAnimation::setBindingsCurrentTime):
1920         (WebCore::CSSAnimation::bindingsPlayState const):
1921         (WebCore::CSSAnimation::bindingsPending const):
1922         (WebCore::CSSAnimation::bindingsReady):
1923         (WebCore::CSSAnimation::bindingsFinished):
1924         (WebCore::CSSAnimation::bindingsPlay):
1925         (WebCore::CSSAnimation::bindingsPause):
1926         (WebCore::CSSAnimation::flushPendingStyleChanges const):
1927         * animation/CSSAnimation.h:
1928         * animation/WebAnimation.h:
1929         (WebCore::WebAnimation::bindingsPlayState const):
1930         (WebCore::WebAnimation::bindingsPending const):
1931         (WebCore::WebAnimation::bindingsReady):
1932         (WebCore::WebAnimation::bindingsFinished):
1933         (WebCore::WebAnimation::bindingsPlay):
1934         (WebCore::WebAnimation::bindingsPause):
1935         * animation/WebAnimation.idl:
1936
1937 2018-06-21  Jer Noble  <jer.noble@apple.com>
1938
1939         [Fullscreen] Suspend page (and pause video) while phishing warning is presented
1940         https://bugs.webkit.org/show_bug.cgi?id=186856
1941         <rdar://problem/41212444>
1942
1943         Reviewed by Tim Horton.
1944
1945         Pause the media element when the page is suspended, and unpause when the page resumes.
1946
1947         * html/HTMLMediaElement.cpp:
1948         (WebCore::HTMLMediaElement::HTMLMediaElement):
1949         (WebCore::HTMLMediaElement::suspend):
1950         (WebCore::HTMLMediaElement::resume):
1951         * html/HTMLMediaElement.h:
1952
1953 2018-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1954
1955         Bad optional access in WebCore::ContentSecurityPolicySource::portMatches
1956         https://bugs.webkit.org/show_bug.cgi?id=186535
1957
1958         Reviewed by Daniel Bates.
1959
1960         Make sure the ports have explicit values before dereferencing them.
1961
1962         This is hard to test. If the layout test script-src-parsing-implicit-and-explicit-port-number
1963         continues to pass for WebKitLegacy, then I have at least probably not broken anything. To
1964         reproduce the crash in a layout test that I can run, I think I would need to implement
1965         internals.registerDefaultPortForProtocol for modern WebKit, which is too much work for this
1966         crash. Otherwise, we'd need to run the test server on port 80, which would be unfriendly.
1967
1968         * page/csp/ContentSecurityPolicySource.cpp:
1969         (WebCore::ContentSecurityPolicySource::portMatches const):
1970
1971 2018-06-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1972
1973         [GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add
1974         https://bugs.webkit.org/show_bug.cgi?id=186880
1975
1976         Reviewed by Xabier Rodriguez-Calvar.
1977
1978         Bug 180253 has added assertions the arugments `start` and `end` is
1979         valid MediaTime in PlatformTimeRanges::add. Since then, some
1980         LayoutTests fail due to the assertion failure.
1981
1982         The invalid MediaTime is added into the PlatformTimeRanges in
1983         MediaPlayerPrivateGStreamer::buffered. Before adding MediaTime,
1984         original implementation checks MediaTime::operator bool() returns
1985         true. But, this method returns true if the time value is invalid.
1986         Then, PlatformTimeRanges::add is called with an invalid MediaTime.
1987
1988         No new tests (No behavior change).
1989
1990         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1991         (WebCore::MediaPlayerPrivateGStreamer::buffered const): Check
1992         maxTimeLoaded() is valid before adding to `timeRanges`.
1993
1994 2018-06-20  David Kilzer  <ddkilzer@apple.com>
1995
1996         Fix leaks in WebCore found by clang static analyzer in deep mode
1997         <https://webkit.org/b/186865>
1998
1999         Reviewed by Joseph Pecoraro.
2000
2001         * platform/mac/WebCoreNSURLExtras.mm:
2002         (WebCore::mapHostNames): Fix leak of an empty NSMutableArray
2003         during an early return.  RetainPtr<> is not used here since
2004         a pointer to the NSMutableArray * is passed around.
2005         * platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:
2006         (WebCore::ScreenDisplayCaptureSourceMac::createDisplayStream):
2007         Fix leak of a CGDisplayModeRef during an early return.
2008
2009 2018-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2010
2011         Unreviewed, fix the watchOS build after r233016.
2012
2013         * page/EventHandler.cpp:
2014         (WebCore::EventHandler::selectionExtentRespectingEditingBoundary):
2015
2016         Move this helper out of the ENABLE(DRAG_SUPPORT) guard.
2017
2018         * page/EventHandler.h:
2019
2020 2018-06-20  Simon Fraser  <simon.fraser@apple.com>
2021
2022         AnimationList wastes 60KB of vector capacity
2023         https://bugs.webkit.org/show_bug.cgi?id=186701
2024
2025         Reviewed by Chris Dumez.
2026
2027         AnimationList was the second most wasteful call site for Vector capacity on theverge.com,
2028         wasting almost 60KB. Lists had between 1 and 3 entries, so give AnimationList's vector of
2029         Animations a min capacity of zero so it doesn't grow in increments of 16.
2030         
2031         Also shrink Animation from 88 bytes to 72 bytes by optimizing packing.
2032
2033         * platform/animation/Animation.cpp:
2034         (WebCore::Animation::Animation):
2035         (WebCore::Animation::operator=):
2036         (WebCore::Animation::animationsMatch const):
2037         * platform/animation/Animation.h:
2038         (WebCore::Animation::animationMode const):
2039         (WebCore::Animation::setAnimationMode):
2040         * platform/animation/AnimationList.h:
2041
2042 2018-06-20  Simon Fraser  <simon.fraser@apple.com>
2043
2044         ContentSecurityPolicySourceList wastes 51KB of Vector capacity on cnn.com
2045         https://bugs.webkit.org/show_bug.cgi?id=186706
2046
2047         Reviewed by Chris Dumez.
2048
2049         Make ContentSecurityPolicySourceList::parse() call shrinkToFit() on m_list
2050         after parsing to eliminate wasted vector capacity.
2051         
2052         Shrink ContentSecurityPolicySource down to 40 bytes by optimizing packing.
2053
2054         * page/csp/ContentSecurityPolicySource.cpp:
2055         (WebCore::ContentSecurityPolicySource::ContentSecurityPolicySource):
2056         * page/csp/ContentSecurityPolicySource.h:
2057         * page/csp/ContentSecurityPolicySourceList.cpp:
2058         (WebCore::ContentSecurityPolicySourceList::matches const):
2059         (WebCore::ContentSecurityPolicySourceList::parse):
2060         (WebCore::ContentSecurityPolicySourceList::matches): Deleted.
2061         * page/csp/ContentSecurityPolicySourceList.h:
2062
2063 2018-06-20  Megan Gardner  <megan_gardner@apple.com>
2064
2065         Restrict Selection in contenteditable the extent of that contenteditable
2066         https://bugs.webkit.org/show_bug.cgi?id=186792
2067
2068         Reviewed by Wenson Hsieh.
2069
2070         My system currently will not allow me to run tests. I will add one when I can update.
2071
2072         Expose the already existing funcitonality to restrict a selection to a single contentenditable
2073
2074         * page/EventHandler.cpp:
2075         (WebCore::EventHandler::selectionExtentRespectingEditingBoundary):
2076         (WebCore::selectionExtentRespectingEditingBoundary): Deleted.
2077         * page/EventHandler.h:
2078         * rendering/HitTestResult.h:
2079
2080 2018-06-20  Simon Fraser  <simon.fraser@apple.com>
2081
2082         CSSFontFace wastes 59KB of Vector capacity on nytimes.com
2083         https://bugs.webkit.org/show_bug.cgi?id=186708
2084
2085         Reviewed by Anders Carlsson.
2086
2087         Most CSSFontFace have one or two CSSFontFaceSource so don't allocate
2088         vector capacity in the default 16-size chunks.
2089
2090         * css/CSSFontFace.h:
2091
2092 2018-06-20  Antoine Quint  <graouts@apple.com>
2093
2094         [Web Animations] Make imported/mozilla/css-transitions/test_element-get-animations.html pass reliably
2095         https://bugs.webkit.org/show_bug.cgi?id=183841
2096         <rdar://problem/40998101>
2097
2098         Reviewed by Dean Jackson.
2099
2100         We must ignore CSS Animations with "animation-name: none".
2101
2102         * animation/AnimationTimeline.cpp:
2103         (WebCore::AnimationTimeline::updateCSSAnimationsForElement):
2104
2105 2018-06-20  Miguel Gomez  <magomez@igalia.com>
2106
2107         [GTK][ThreadedRendering][Nicosia] Themed elements cannot be rendered using threaded rendering
2108         https://bugs.webkit.org/show_bug.cgi?id=186840
2109
2110         Reviewed by Carlos Garcia Campos.
2111
2112         Disable threaded rendering for GTK port.
2113
2114         * platform/graphics/nicosia/NicosiaPaintingEngine.cpp:
2115         (Nicosia::PaintingEngine::create):
2116
2117 2018-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
2118
2119         [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads
2120         https://bugs.webkit.org/show_bug.cgi?id=186836
2121
2122         Reviewed by Carlos Garcia Campos.
2123
2124         Use "PaintingThread" name.
2125
2126         * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:
2127         (Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):
2128
2129 2018-06-19  Antoine Quint  <graouts@apple.com>
2130
2131         [Web Animations] Make imported/mozilla/css-animations/test_pseudoElement-get-animations.html pass reliably
2132         https://bugs.webkit.org/show_bug.cgi?id=183818
2133         <rdar://problem/40997015>
2134
2135         Reviewed by Dean Jackson.
2136
2137         We add a new opt-in flag to return sorted animations when calling AnimationTimeline::animationsForElement() so that
2138         Element::getAnimations() can opt into returning animations sorted by the rules defined by the CSS Transitions spec.
2139         The rule is that CSS Transitions must be sorted prior to CSS Animations and regular Web Animations, and then sorted
2140         by the time they were generated and, if generated at the same time, sorted alphabetically based on the transitioned
2141         property. To be able to accomodate this, we add a new generationTime() method to CSSTransition.
2142
2143         * animation/AnimationTimeline.cpp:
2144         (WebCore::AnimationTimeline::animationsForElement const):
2145         (WebCore::AnimationTimeline::updateCSSTransitionsForElement):
2146         * animation/AnimationTimeline.h:
2147         * animation/CSSTransition.cpp:
2148         (WebCore::CSSTransition::create):
2149         (WebCore::CSSTransition::CSSTransition):
2150         * animation/CSSTransition.h:
2151         * dom/Element.cpp:
2152         (WebCore::Element::getAnimations):
2153
2154 2018-06-19  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2155
2156         [Curl] Allow passing contents of Root CA data directly.
2157         https://bugs.webkit.org/show_bug.cgi?id=185782
2158
2159         Currently the data must be in a file and set by its path. This patch
2160         allow application to set root CA data by passing binary data directly.
2161
2162         Reviewed by Yusuke Suzuki.
2163
2164         No new tests. Tested internally.
2165
2166         * platform/network/curl/CurlRequest.cpp:
2167         (WebCore::CurlRequest::setupTransfer):
2168         * platform/network/curl/CurlSSLHandle.cpp:
2169         (WebCore::CurlSSLHandle::CurlSSLHandle):
2170         (WebCore::CurlSSLHandle::getCACertPathEnv):
2171         (WebCore::CurlSSLHandle::setCACertPath):
2172         (WebCore::CurlSSLHandle::setCACertData):
2173         (WebCore::CurlSSLHandle::clearCACertInfo):
2174         * platform/network/curl/CurlSSLHandle.h:
2175         (WebCore::CurlSSLHandle::getCipherList const):
2176         (WebCore::CurlSSLHandle::getSignatureAlgorithmsList const):
2177         (WebCore::CurlSSLHandle::getCurvesList const):
2178         (WebCore::CurlSSLHandle::setCipherList):
2179         (WebCore::CurlSSLHandle::setSignatureAlgorithmsList):
2180         (WebCore::CurlSSLHandle::setCurvesList):
2181         (WebCore::CurlSSLHandle::setIgnoreSSLErrors):
2182         (WebCore::CurlSSLHandle::getCACertInfo const):
2183         (WebCore::CurlSSLHandle::getCACertPath const): Deleted.
2184         (WebCore::CurlSSLHandle::setCACertPath): Deleted.
2185         * platform/network/curl/CurlSSLVerifier.cpp:
2186         (WebCore::CurlSSLVerifier::CurlSSLVerifier):
2187
2188 2018-06-19  Dean Jackson  <dino@apple.com>
2189
2190         ARKit badge drop shadow updates its blur radius based on page zoom
2191         https://bugs.webkit.org/show_bug.cgi?id=186829
2192         <rdar://problem/40738779>
2193
2194         Reviewed by Tim Horton.
2195
2196         We need to make sure the shadow blur radius takes into account the
2197         current zoom. Thankfully, the GraphicsContext platform code already
2198         does this, so just use it.
2199
2200         * rendering/RenderThemeIOS.mm:
2201         (WebCore::RenderThemeIOS::paintSystemPreviewBadge):
2202
2203 2018-06-19  Dean Jackson  <dino@apple.com>
2204
2205         Blank viewer comes up and then auto-dismisses when device is not connected to Internet
2206         https://bugs.webkit.org/show_bug.cgi?id=186825
2207         <rdar://problem/40294170>
2208
2209         Reviewed by Tim Horton.
2210
2211         Export isSuccessful() to WebKit.
2212
2213         * platform/network/ResourceResponseBase.h:
2214
2215 2018-06-19  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2216
2217         [Curl] Enable Proxy Authentication.
2218         https://bugs.webkit.org/show_bug.cgi?id=185266
2219
2220         Add support for Proxy Authentication to curl network layer.
2221
2222         Reviewed by Alex Christensen.
2223
2224         No new tests in public. Tested internally.
2225
2226         * platform/network/curl/AuthenticationChallenge.h:
2227         * platform/network/curl/AuthenticationChallengeCurl.cpp:
2228         (WebCore::AuthenticationChallenge::protectionSpaceServerTypeFromURI):
2229         (WebCore::AuthenticationChallenge::protectionSpaceFromHandle):
2230         (WebCore::AuthenticationChallenge::determineProxyPort):
2231         (WebCore::AuthenticationChallenge::authenticationSchemeFromCurlAuth):
2232         (WebCore::AuthenticationChallenge::parseRealm):
2233         * platform/network/curl/CurlContext.cpp:
2234         (WebCore::CurlHandle::enableProxyIfExists):
2235         (WebCore::CurlHandle::getProxyUrl):
2236         (WebCore::CurlHandle::getProxyAuthAvail):
2237         (WebCore::CurlHandle::getPrimaryPort): Deleted.
2238         * platform/network/curl/CurlContext.h:
2239         (WebCore::CurlContext::setDefaultProxyAuthMethod):
2240         (WebCore::CurlContext::setProxyAuthMethod):
2241         * platform/network/curl/CurlProxySettings.cpp:
2242         (WebCore::determineAuthMethod):
2243         (WebCore::CurlProxySettings::setAuthMethod):
2244         (WebCore::protocolIsInSocksFamily):
2245         * platform/network/curl/CurlProxySettings.h:
2246         (WebCore::CurlProxySettings::setDefaultAuthMethod):
2247         (WebCore::CurlProxySettings::authMethod const):
2248         * platform/network/curl/CurlRequest.cpp:
2249         (WebCore::CurlRequest::didReceiveHeader):
2250         * platform/network/curl/CurlResponse.h:
2251         (WebCore::CurlResponse::isolatedCopy const):
2252         * platform/network/curl/ResourceResponse.h:
2253         * platform/network/curl/ResourceResponseCurl.cpp:
2254         (WebCore::ResourceResponse::isProxyAuthenticationRequired const):
2255
2256 2018-06-19  Tim Horton  <timothy_horton@apple.com>
2257
2258         Unpainted area while scrolling in Reader is white
2259         https://bugs.webkit.org/show_bug.cgi?id=186541
2260         <rdar://problem/40471363>
2261
2262         Reviewed by Timothy Hatcher.
2263
2264         New test: tiled-drawing/simple-document-with-dynamic-background-color.html
2265
2266         For platforms that do not use the overhang layer, we depend on
2267         RenderView's background color to fill unpainted space.
2268
2269         RenderView's background color is only updated inside updateRootLayerConfiguration,
2270         and it is possible with a simple enough page to change the document's
2271         background color without running that code.
2272
2273         * page/FrameView.cpp:
2274         (WebCore::FrameView::setTransparent):
2275         (WebCore::FrameView::setBaseBackgroundColor):
2276         Make use of the newly added rootBackgroundColorOrTransparencyChanged.
2277
2278         (WebCore::FrameView::calculateExtendedBackgroundMode const):
2279         Update a comment, since the function it mentioned is no longer.
2280
2281         (WebCore::FrameView::updateTilesForExtendedBackgroundMode):
2282         Remove this code that clears the root extended background color
2283         if using tiles to extend in both directions. Two reasons:
2284         1) it seems harmless to also have a root extended background color
2285         2) this just gets clobbered by the call in RenderView::paintBoxDecorations
2286
2287         * rendering/RenderLayerCompositor.cpp:
2288         (WebCore::RenderLayerCompositor::updateCompositingLayers):
2289         Add a bit that will do a updateConfiguration() on the root layer if no
2290         other work needs to be done, so that we can update the root layer's
2291         transparency or background color without doing a full layer rebuild.
2292
2293         (WebCore::RenderLayerCompositor::rootOrBodyStyleChanged):
2294         Make use of the newly added rootBackgroundColorOrTransparencyChanged.
2295
2296         (WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
2297         Change rootBackgroundTransparencyChanged to also cover color changes.
2298         Fold setRootExtendedBackgroundColor in here, and make use of
2299         setRootLayerConfigurationNeedsUpdate() instead of doing a full rebuild.
2300         Previously, we would bail if the transparency state hadn't changed;
2301         now, we'll also update the root layer's background color and the
2302         exposed-to-WebKit extended background color if they change too.
2303
2304         (WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged): Deleted.
2305         (WebCore::RenderLayerCompositor::setRootExtendedBackgroundColor): Deleted.
2306
2307         * rendering/RenderLayerCompositor.h:
2308         Add setRootLayerConfigurationNeedsUpdate, remove setRootExtendedBackgroundColor,
2309         and add both a bit indicating that the root layer configuration needs updating
2310         and the cached view background color to make the early return in
2311         rootBackgroundColorOrTransparencyChanged possible.
2312
2313         * rendering/RenderView.cpp:
2314         (WebCore::RenderView::paintBoxDecorations):
2315         Make use of the newly added rootBackgroundColorOrTransparencyChanged.
2316
2317 2018-06-19  Youenn Fablet  <youenn@apple.com>
2318
2319         Need to properly handle removal of worker in SWServer::unregisterServiceWorkerClient timer lambda
2320         https://bugs.webkit.org/show_bug.cgi?id=186674
2321         <rdar://problem/40974812>
2322
2323         Reviewed by Chris Dumez.
2324
2325         While looping over the running workers map and trying to terminate some of the workers,
2326         there is a chance that the map will be modified synchronously which may affect iterating the map.
2327         This patch removes that potential threat.
2328
2329         * workers/service/server/SWServer.cpp:
2330         (WebCore::SWServer::unregisterServiceWorkerClient):
2331
2332 2018-06-19  Antoine Quint  <graouts@apple.com>
2333
2334         [Web Animations] Make imported/mozilla/css-animations/test_animation-playstate.html pass reliably
2335         https://bugs.webkit.org/show_bug.cgi?id=183828
2336         <rdar://problem/40997469>
2337
2338         Reviewed by Dean Jackson.
2339
2340         We need to ensure pending styles have been resolved prior to returning the play state for a CSS Animation since
2341         it can be controlled by the animation-play-state CSS property. To that end we expose a specific bindings-only
2342         method which we override for CSSAnimation to force a style update.
2343
2344         * animation/CSSAnimation.cpp:
2345         (WebCore::CSSAnimation::bindingsPlayState const):
2346         * animation/CSSAnimation.h:
2347         * animation/WebAnimation.h:
2348         (WebCore::WebAnimation::bindingsPlayState const):
2349         * animation/WebAnimation.idl:
2350
2351 2018-06-19  David Kilzer  <ddkilzer@apple.com>
2352
2353         Revert: Add logging when splashboardd enables WebThread
2354         <https://webkit.org/b/186793>
2355         <rdar://problem/41213255>
2356
2357         Turns out this isn't needed, so reverting r232959.
2358
2359         * platform/RuntimeApplicationChecks.h:
2360         * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
2361         (WebCore::IOSApplication::isSplashBoardd): Deleted.
2362         * platform/ios/wak/WebCoreThread.mm:
2363         (WebThreadEnable):
2364
2365 2018-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2366
2367         [WebKit on watchOS] Vend username text content type when using scribble in login fields
2368         https://bugs.webkit.org/show_bug.cgi?id=186791
2369         <rdar://problem/41226935>
2370
2371         Reviewed by Beth Dakin.
2372
2373         Expose AutofillElements' autofillable username input element. See WebKit ChangeLog for more details.
2374
2375         * editing/ios/AutofillElements.h:
2376         (WebCore::AutofillElements::username const):
2377
2378 2018-06-19  Chris Dumez  <cdumez@apple.com>
2379
2380         WebCoreNSURLSessionDataTaskClient::redirectReceived() calls WebCore on non-main thread
2381         https://bugs.webkit.org/show_bug.cgi?id=186805
2382         <rdar://problem/36960714>
2383
2384         Reviewed by Youenn Fablet.
2385
2386         Make sure WebCoreNSURLSessionDataTaskClient::redirectReceived() dispatches to the main
2387         thread before calling its completion handler. Otherwise, we end up calling into WebCore
2388         on a NSOperationQueue background thread and we crash.
2389
2390         * platform/network/cocoa/WebCoreNSURLSession.mm:
2391         (WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):
2392
2393 2018-06-19  Chris Dumez  <cdumez@apple.com>
2394
2395         HTTPHeaderMap wastes 226KB of HashTable capacity on cnn.com
2396         https://bugs.webkit.org/show_bug.cgi?id=186735
2397         <rdar://problem/41189164>
2398
2399         Reviewed by Geoffrey Garen.
2400
2401         Resource requests and responses normally do not have a large amount of HTTP headers
2402         (local testing shows 6 common headers on average and 0.3 uncommon ones).
2403         As a result, move the internal representation of HTTPHeaderMap from HashMaps to
2404         Vectors. Given the number of headers, the impact on performance should be negligible.
2405         However, the new implementation uses a lot less memory. In a follow-up, we can save
2406         even more memory by calling HTTPHeaderMap::shrinkToFit() when possible.
2407
2408         * loader/CrossOriginAccessControl.cpp:
2409         (WebCore::createAccessControlPreflightRequest):
2410         * loader/DocumentLoader.cpp:
2411         (WebCore::DocumentLoader::responseReceived):
2412         * loader/cache/CachedRawResource.cpp:
2413         (WebCore::CachedRawResource::canReuse const):
2414         * platform/network/HTTPHeaderMap.cpp:
2415         (WebCore::HTTPHeaderMap::isolatedCopy const):
2416         (WebCore::HTTPHeaderMap::get const):
2417         (WebCore::HTTPHeaderMap::set):
2418         (WebCore::HTTPHeaderMap::add):
2419         (WebCore::HTTPHeaderMap::append):
2420         (WebCore::HTTPHeaderMap::addIfNotPresent):
2421         (WebCore::HTTPHeaderMap::contains const):
2422         (WebCore::HTTPHeaderMap::remove):
2423         * platform/network/HTTPHeaderMap.h:
2424         (WebCore::HTTPHeaderMap::CommonHeader::isolatedCopy const):
2425         (WebCore::HTTPHeaderMap::CommonHeader::operator== const):
2426         (WebCore::HTTPHeaderMap::UncommonHeader::isolatedCopy const):
2427         (WebCore::HTTPHeaderMap::UncommonHeader::operator== const):
2428         (WebCore::HTTPHeaderMap::HTTPHeaderMapConstIterator::HTTPHeaderMapConstIterator):
2429         (WebCore::HTTPHeaderMap::HTTPHeaderMapConstIterator::updateKeyValue):
2430         (WebCore::HTTPHeaderMap::shrinkToFit):
2431         (WebCore::HTTPHeaderMap::commonHeaders const):
2432         (WebCore::HTTPHeaderMap::uncommonHeaders const):
2433         (WebCore::HTTPHeaderMap::commonHeaders):
2434         (WebCore::HTTPHeaderMap::uncommonHeaders):
2435         (WebCore::HTTPHeaderMap::CommonHeader::encode const):
2436         (WebCore::HTTPHeaderMap::CommonHeader::decode):
2437         (WebCore::HTTPHeaderMap::UncommonHeader::encode const):
2438         (WebCore::HTTPHeaderMap::UncommonHeader::decode):
2439         (WebCore::HTTPHeaderMap::encode const):
2440         (WebCore::HTTPHeaderMap::decode):
2441         * platform/network/ResourceResponseBase.cpp:
2442         (WebCore::ResourceResponseBase::filter):
2443         (WebCore::ResourceResponseBase::sanitizeHTTPHeaderFields):
2444
2445 2018-06-19  Youenn Fablet  <youenn@apple.com>
2446
2447         Network Preflights do not show in WebInspector after moving CORS checks to NetworkProcess
2448         https://bugs.webkit.org/show_bug.cgi?id=186312
2449         <rdar://problem/40495434>
2450
2451         Reviewed by Chris Dumez.
2452
2453         Test: http/wpt/fetch/inspect-preflight.html
2454
2455         No change of behavior in regular conditions.
2456         All intermediate requests/responses are now buffered in NetworkProcess if Web inspector shows up.
2457         Add NetworkLoadInformation and NetworkIntermediateLoadInformation for that purpose.
2458
2459         Add a new LoaderStrategy method to grab this information from NetworkProcess synchronously.
2460         Add Internals API for testing the storage by the Network Process and the sending to WebProcess.
2461
2462         * WebCore.xcodeproj/project.pbxproj:
2463         * loader/LoaderStrategy.cpp:
2464         (WebCore::LoaderStrategy::intermediateLoadInformationFromResourceLoadIdentifier):
2465         * loader/LoaderStrategy.h:
2466         * platform/network/NetworkLoadInformation.h: Added.
2467         (WebCore::NetworkTransactionInformation::encode const):
2468         (WebCore::NetworkTransactionInformation::decode):
2469         * testing/Internals.cpp:
2470         (WebCore::Internals::setCaptureExtraNetworkLoadMetricsEnabled):
2471         (WebCore::Internals::ongoingLoadDescriptions):
2472         * testing/Internals.h:
2473         * testing/Internals.idl:
2474
2475 2018-06-19  Antoine Quint  <graouts@apple.com>
2476
2477         [Web Animations] Make imported/mozilla/css-transitions/test_animation-cancel.html pass reliably
2478         https://bugs.webkit.org/show_bug.cgi?id=183821
2479         <rdar://problem/40997034>
2480
2481         Reviewed by Dean Jackson.
2482
2483         If an element gets a "display: none" style RenderTreeUpdater::tearDownRenderers() will be called with a RendererUpdateCancelingAnimations
2484         teardown type on all of its children. We need to ensure all declarative animations, and only those since regular Web Animations should be
2485         kept active regardless of their target's style, are canceled in this situation.
2486
2487         * animation/AnimationTimeline.cpp:
2488         (WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement):
2489         * animation/AnimationTimeline.h:
2490         * rendering/updating/RenderTreeUpdater.cpp:
2491         (WebCore::RenderTreeUpdater::tearDownRenderers):
2492
2493 2018-06-19  David Kilzer  <ddkilzer@apple.com>
2494
2495         Add logging when splashboardd enables WebThread
2496         <https://webkit.org/b/186793>
2497         <rdar://problem/41213255>
2498
2499         Reviewed by Daniel Bates.
2500
2501         * platform/RuntimeApplicationChecks.h:
2502         (WebCore::IOSApplication::isSplashBoardd): Add declaration.
2503         * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
2504         (WebCore::IOSApplication::isSplashBoardd): Add implementation.
2505         * platform/ios/wak/WebCoreThread.mm:
2506         (WebThreadEnable): Call RELEASE_LOG_FAULT() if this is called by
2507         splashboardd.
2508
2509 2018-06-19  Miguel Gomez  <magomez@igalia.com>
2510
2511         [GTK][WPE][Nicosia] Add environment variable to enable threaded rendering and set the number of painting threads
2512         https://bugs.webkit.org/show_bug.cgi?id=186801
2513
2514         Reviewed by Carlos Garcia Campos.
2515
2516         Add and environment variable to enable the usage of the threaded renderer and define the number
2517         of painting threads.
2518
2519         No new tests.
2520
2521         * platform/graphics/nicosia/NicosiaPaintingEngine.cpp:
2522         (Nicosia::PaintingEngine::create):
2523         * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:
2524         (Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):
2525         * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.h:
2526
2527 2018-06-19  Youenn Fablet  <youenn@apple.com>
2528
2529         RTCRtpSender.replaceTrack(null) ends current track
2530         https://bugs.webkit.org/show_bug.cgi?id=184911
2531         <rdar://problem/40758138>
2532
2533         Reviewed by Eric Carlson.
2534
2535         Before the patch, when replacing the sender track by null, the previous track was stopped.
2536         Instead of doing that, the track now stays alive and it is the realtime source that is stopped.
2537         This ensures that the data is no longer sent while the track can still be used elsewhere.
2538
2539         Covered by updated and rebased tests.
2540
2541         * Modules/mediastream/PeerConnectionBackend.h:
2542         * Modules/mediastream/RTCPeerConnection.cpp:
2543         (WebCore::RTCPeerConnection::addTransceiver):
2544         (WebCore::RTCPeerConnection::enqueueReplaceTrackTask):
2545         (WebCore::RTCPeerConnection::replaceTrack):
2546         * Modules/mediastream/RTCPeerConnection.h:
2547         * Modules/mediastream/RTCRtpSender.cpp:
2548         (WebCore::RTCRtpSender::replaceTrack):
2549         * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
2550         (WebCore::updateTrackSource):
2551         (WebCore::LibWebRTCPeerConnectionBackend::replaceTrack):
2552         * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
2553
2554 2018-06-18  Chris Dumez  <cdumez@apple.com>
2555
2556         Better pack ResourceRequest
2557         https://bugs.webkit.org/show_bug.cgi?id=186717
2558
2559         Reviewed by Darin Adler.
2560
2561         Better pack ResourceRequest to reduce its size from 240 to 232 bytes
2562         on Mac.
2563
2564         * platform/network/ResourceRequestBase.h:
2565
2566 2018-06-18  Antoine Quint  <graouts@apple.com>
2567
2568         [Web Animations] Implement "Starting of transitions" section from CSS Transitions
2569         https://bugs.webkit.org/show_bug.cgi?id=186517
2570         <rdar://problem/41000798>
2571
2572         Reviewed by Dean Jackson.
2573
2574         We implement the whole section at https://drafts.csswg.org/css-transitions-1/#starting so that we have spec-compliant starting of CSS Transitions.
2575         To correctly implement this we now maintain two maps of transitions for a given property, a set of running transitions (m_elementToRunningCSSTransitionByCSSPropertyID)
2576         and a set of completed transition (m_elementToCompletedCSSTransitionByCSSPropertyID).
2577
2578         * animation/AnimationTimeline.cpp:
2579         (WebCore::removeCSSTransitionFromMap): Add a utility to remove a CSSTransition from one of the two HashMap<Element*, HashMap<CSSPropertyID, RefPtr<CSSTransition>>>
2580         managed by AnimationTimeline (m_elementToRunningCSSTransitionByCSSPropertyID and m_elementToCompletedCSSTransitionByCSSPropertyID).
2581         (WebCore::AnimationTimeline::animationWasRemovedFromElement): Use the new removeCSSTransitionFromMap() utility.
2582         (WebCore::AnimationTimeline::updateCSSAnimationsForElement): We rename "oldStyle" to "currentStyle" to align with the naming used by updateCSSAnimationsForElement().
2583         We also remove an initial check that has been pushed up to Style::TreeResolver::createAnimatedElementUpdate().
2584         (WebCore::propertyInStyleMatchesValueForTransitionInMap): When running the steps mandated by the spec we often need to check whether a given property has a transition
2585         in an AnimationList that matches the value used in a given RenderStyle.
2586         (WebCore::transitionCombinedDuration): We need to compute the combined duration twice while running the steps mandated by the spec, so we have a dedicated utility.
2587         (WebCore::transitionMatchesProperty): New utility that indicates whether a WebCore::Animation matches a given property, by virtue of targeting it directly, targeting
2588         a shorthand for which this property is a longhand, or targeting "all".
2589         (WebCore::AnimationTimeline::updateCSSTransitionsForElement): This is where all of the new implementation for starting transitions happens. We implement the steps
2590         as they appear in the spec.
2591         (WebCore::shouldBackingAnimationBeConsideredForCSSTransition): Deleted.
2592         * animation/AnimationTimeline.h:
2593         * animation/CSSAnimation.cpp:
2594         (WebCore::CSSAnimation::syncPropertiesWithBackingAnimation): Since only CSS Animations respect the delay and duration values as parsed directly in a WebCore:Animation
2595         object, we move code that was previously in DeclarativeAnimation::syncPropertiesWithBackingAnimation to this method. CSS Transitions set those values based on the
2596         delay and duration parameters passed to CSSTransition::create() and computed in AnimationTimeline::updateCSSTransitionsForElement().
2597         * animation/CSSTransition.cpp:
2598         (WebCore::CSSTransition::create): Since the transition's delay and duration is computed in AnimationTimeline::updateCSSTransitionsForElement(), we now require them
2599         to be passed when creating a CSSTransition and pass those to the new setTimingProperties() function. We also expect a target style and reversing-adjusted start style,
2600         as well as a reversing-shortening factor.
2601         (WebCore::CSSTransition::CSSTransition): 
2602         (WebCore::CSSTransition::resolve): We need to be able to query the last style computed by a call to resolve() from AnimationTimeline::updateCSSTransitionsForElement(),
2603         we subclass this newly-virtual WebAnimation method and clone the style after we blended the property targeted by this transition.
2604         (WebCore::CSSTransition::setTimingProperties): Set the transition delay and duration as provided in the call to create().
2605         (WebCore::CSSTransition::canBeListed const): Fix a crash that was found while working on this bug where we could access a null effect.
2606         (WebCore::CSSTransition::initialize): Deleted.
2607         (WebCore::CSSTransition::matchesBackingAnimationAndStyles const): Deleted.
2608         * animation/CSSTransition.h:
2609         * animation/DeclarativeAnimation.cpp:
2610         (WebCore::DeclarativeAnimation::syncPropertiesWithBackingAnimation): This virtual method now has an empty definition since the timing properties are now only set
2611         for CSSAnimation.
2612         * animation/KeyframeEffectReadOnly.cpp:
2613         (WebCore::KeyframeEffectReadOnly::stylesWouldYieldNewCSSTransitionsBlendingKeyframes const): Deleted.
2614         * animation/KeyframeEffectReadOnly.h:
2615         * animation/WebAnimation.h:
2616         * page/animation/CSSPropertyAnimation.cpp:
2617         (WebCore::AnimationPropertyWrapperBase::canInterpolate const): Since we need to be able to determine whether some property values can be interpolated, we add a new
2618         canInterpolate() method to the base wrapper class so the cases where we can't interpolate values (length with an "auto" type) may return false.
2619         (WebCore::LengthPropertyWrapper::LengthPropertyWrapper): Lengths can only be interpolated if both the start and end values are not "auto".
2620         (WebCore::LengthVariantPropertyWrapper::LengthVariantPropertyWrapper):
2621         (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
2622         (WebCore::CSSPropertyAnimation::canPropertyBeInterpolated):
2623         * page/animation/CSSPropertyAnimation.h:
2624         * style/StyleTreeResolver.cpp:
2625         (WebCore::Style::TreeResolver::createAnimatedElementUpdate): Move a check found in both updateCSSAnimationsForElement() and updateCSSTransitionsForElement() to their
2626         shared call site.
2627
2628 2018-06-18  Nan Wang  <n_wang@apple.com>
2629
2630         AX: [macOS] When zoom is enabled, focus doesn't follow text cursor
2631         https://bugs.webkit.org/show_bug.cgi?id=186697
2632
2633         Reviewed by Darin Adler.
2634
2635         Now that web process doesn't have access to NSScreen. The conversion of the 
2636         rects is wrong. Fixed this by using the right function that's available in
2637         WebCore to get the rects.
2638
2639         * editing/mac/FrameSelectionMac.mm:
2640         (WebCore::accessibilityConvertScreenRect):
2641
2642 2018-06-18  Youenn Fablet  <youenn@apple.com>
2643
2644         Expose RTCPeerConnectionIceEventInit constructor
2645         https://bugs.webkit.org/show_bug.cgi?id=186770
2646
2647         Reviewed by Alex Christensen.
2648
2649         Add event constructor as per specification.
2650         Add support for the url attribute.
2651         For that purpose, we need to pipe that information from LibWebRTCMediaEndpoint
2652         up to RTCPeerConnectionIceEvent.
2653
2654         Covered by rebased test.
2655
2656         * Modules/mediastream/PeerConnectionBackend.cpp:
2657         (WebCore::PeerConnectionBackend::fireICECandidateEvent):
2658         (WebCore::PeerConnectionBackend::disableICECandidateFiltering):
2659         (WebCore::PeerConnectionBackend::newICECandidate):
2660         (WebCore::PeerConnectionBackend::doneGatheringCandidates):
2661         (WebCore::PeerConnectionBackend::finishedRegisteringMDNSName):
2662         * Modules/mediastream/PeerConnectionBackend.h:
2663         * Modules/mediastream/RTCPeerConnectionIceEvent.cpp:
2664         (WebCore::RTCPeerConnectionIceEvent::create):
2665         (WebCore::RTCPeerConnectionIceEvent::RTCPeerConnectionIceEvent):
2666         * Modules/mediastream/RTCPeerConnectionIceEvent.h:
2667         (WebCore::RTCPeerConnectionIceEvent::url const):
2668         * Modules/mediastream/RTCPeerConnectionIceEvent.idl:
2669         * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
2670         (WebCore::LibWebRTCMediaEndpoint::OnIceCandidate):
2671         * bindings/js/WebCoreBuiltinNames.h:
2672         * dom/EventNames.in:
2673
2674 2018-06-18  Simon Fraser  <simon.fraser@apple.com>
2675
2676         SVGTransformListValues wastes 127KB of Vector capacity on nytimes.com
2677         https://bugs.webkit.org/show_bug.cgi?id=186704
2678
2679         Reviewed by Said Abou-Hallawa.
2680
2681         SVGTransformListValues has inline capacity 1, and every SVGGraphicsElement has
2682         a SVGSynchronizableAnimatedProperty<WebCore::SVGTransformListValues>, so the inline
2683         capacity wastes space for every SVGGraphicsElement that doesn't have a transform (i.e.
2684         most of them).
2685         
2686         So make SVGTransformListValues have zero inline capacity, and set its min capacity to
2687         2, rather than the default 16, since most transform lists are short.
2688
2689         * svg/SVGTransformListValues.h:
2690
2691 2018-06-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
2692
2693         Document should not be mutated under SMILTimeContainer::updateAnimations()
2694         https://bugs.webkit.org/show_bug.cgi?id=186658
2695
2696         Reviewed by Simon Fraser.
2697
2698         To update the animation of an SVG <animate> element, we call
2699         SVGAnimateElementBase::resetAnimatedType(). It ensures the pointer m_animator
2700         is valid. If it animates a css property, it calls computeCSSPropertyValue()
2701         which calls resolveStyle() via other calls. resolveStyle() may call delayed
2702         callbacks through the destructor of PostResolutionCallbackDisabler. These
2703         callbacks may fire events. These events may execute JS event handlers.
2704         If one of these event handlers deletes the same SVG <animate> we animate,
2705         we will end up calling SVGAnimateElementBase::resetAnimatedPropertyType()
2706         of the same <animate> element. This function  will delete the same m_animator
2707         which resetAnimatedType() still holds and will use later. This code
2708         re-entrance is unexpected and unwanted.
2709
2710         The fix is to disable mutating the DOM while updating the SVG animations.
2711
2712         Test: svg/dom/css-animate-input-foucs-crash.html
2713
2714         * svg/animation/SMILTimeContainer.cpp:
2715         (WebCore::SMILTimeContainer::updateAnimations):
2716
2717 2018-06-18  Commit Queue  <commit-queue@webkit.org>
2718
2719         Unreviewed, rolling out r232935.
2720         https://bugs.webkit.org/show_bug.cgi?id=186783
2721
2722         This patch broke macOS 32-bit build (Requested by n_wang on
2723         #webkit).
2724
2725         Reverted changeset:
2726
2727         "AX: [macOS] When zoom is enabled, focus doesn't follow text
2728         cursor"
2729         https://bugs.webkit.org/show_bug.cgi?id=186697
2730         https://trac.webkit.org/changeset/232935
2731
2732 2018-06-18  Nan Wang  <n_wang@apple.com>
2733
2734         AX: [macOS] When zoom is enabled, focus doesn't follow text cursor
2735         https://bugs.webkit.org/show_bug.cgi?id=186697
2736
2737         Reviewed by Darin Adler.
2738
2739         Now that web process doesn't have access to NSScreen. The conversion of the 
2740         rects is wrong. Fixed this by using the right function that's available in
2741         WebCore to convert the rects.
2742
2743         * editing/mac/FrameSelectionMac.mm:
2744         (WebCore::accessibilityConvertScreenRect):
2745
2746 2018-06-18  Youenn Fablet  <youenn@apple.com>
2747
2748         Validate Cross-Origin-Resource-Policy for resources cached in the MemoryCache
2749         https://bugs.webkit.org/show_bug.cgi?id=186639
2750         <rdar://problem/41106984>
2751
2752         Reviewed by Geoffrey Garen.
2753
2754         Add a method to check CORP.
2755         Make use of it to validate any memory cached resource.
2756         Whitelist CORP header so that it is not filtered out by Network Process.
2757
2758         Test: http/wpt/cross-origin-resource-policy/image-in-iframe-loads.html
2759
2760         * loader/CrossOriginAccessControl.cpp:
2761         (WebCore::shouldCrossOriginResourcePolicyCancelLoad):
2762         (WebCore::validateCrossOriginResourcePolicy):
2763         * loader/CrossOriginAccessControl.h:
2764         * loader/cache/CachedResourceLoader.cpp:
2765         (WebCore::CachedResourceLoader::requestResource):
2766         * platform/network/ResourceResponseBase.cpp:
2767         (WebCore::isSafeRedirectionResponseHeader):
2768         (WebCore::isSafeCrossOriginResponseHeader):
2769
2770 2018-06-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2771
2772         [WTF] Remove workarounds needed to support libstdc++-4
2773         https://bugs.webkit.org/show_bug.cgi?id=186762
2774
2775         Reviewed by Michael Catanzaro.
2776
2777         Revert r226299, r226300 r226301 and r226302.
2778
2779         No new tests, no change in behaviour.
2780
2781         * platform/graphics/FontSelectionAlgorithm.h:
2782         (WebCore::FontSelectionValue::clampFloat):
2783         * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
2784         (WebCore::MediaPlayerPrivateAVFoundationCF::currentMediaTime const):
2785         * platform/graphics/win/UniscribeController.cpp:
2786         (WebCore::UniscribeController::shapeAndPlaceItem):
2787
2788 2018-06-18  Karl Leplat  <karl.leplat_ext@softathome.com>
2789
2790         [Threaded paintingEngine] Fix rendering glitches
2791         https://bugs.webkit.org/show_bug.cgi?id=186764
2792
2793         Reviewed by Žan Doberšek.
2794
2795         * platform/graphics/nicosia/NicosiaPaintingEngineBasic.cpp:
2796         (Nicosia::PaintingEngineBasic::paint):
2797         To keep backwards compatibility with no multi-threaded,
2798         we call Nicosia::Buffer functions beginPainting() and completePainting().
2799
2800
2801 2018-06-18  Tomas Popela  <tpopela@redhat.com>
2802
2803         Properly check the sscanf return valua
2804         https://bugs.webkit.org/show_bug.cgi?id=186757
2805
2806         Reviewed by Carlos Garcia Campos.
2807
2808         Check if we matched anything and if we matched the expected amount of
2809         data.
2810
2811         * page/linux/ResourceUsageThreadLinux.cpp:
2812         (WebCore::cpuPeriod):
2813
2814 2018-06-18  Tomas Popela  <tpopela@redhat.com>
2815
2816         [GTK] Wrong variable used in RenderThemeGtk
2817         https://bugs.webkit.org/show_bug.cgi?id=186756
2818
2819         Reviewed by Carlos Garcia Campos.
2820
2821         Use SliderThumbHorizontalPart instead of SliderHorizontalPart.
2822
2823         * rendering/RenderThemeGtk.cpp:
2824         (WebCore::RenderThemeGtk::adjustSliderThumbSize const):
2825
2826 2018-06-18  Philippe Normand  <pnormand@igalia.com>
2827
2828         [GStreamer] Crash when adding in-band text track with playbin3 enabled
2829         https://bugs.webkit.org/show_bug.cgi?id=186654
2830
2831         Reviewed by Xabier Rodriguez-Calvar.
2832
2833         Text track indexes should be relative to the total amount of
2834         in-band text tracks. The previous code would induce the creation
2835         of in-band text tracks with indexes relative to the total amount
2836         of all in-band (audio, video, text) tracks.
2837
2838         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
2839         (WebCore::MediaPlayerPrivateGStreamer::updateTracks):
2840
2841 2018-06-17  Zalan Bujtas  <zalan@apple.com>
2842
2843         Anonymous block collapsing can destroy the renderer's parent.
2844         https://bugs.webkit.org/show_bug.cgi?id=186655
2845         <rdar://problem/41157554>
2846
2847         Reviewed by Antti Koivisto.
2848
2849         While destroying a chain of renderers (text renderer -> first letter renderer), we need to
2850         check if the anonymous block collapsing destroyed the parent renderer (see webkit.org/b/186746).
2851
2852         Test: fast/text/first-letter-with-anon-wrapper-crash.html
2853
2854         * rendering/updating/RenderTreeBuilder.cpp:
2855         (WebCore::RenderTreeBuilder::destroyAndCleanUpAnonymousWrappers):
2856
2857 2018-06-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2858
2859         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 3)
2860         https://bugs.webkit.org/show_bug.cgi?id=186442
2861         <rdar://problem/40879364>
2862
2863         Reviewed by Darin Adler.
2864
2865         Rename references to "Extra zoom mode". No change in behavior.
2866
2867         * page/DisabledAdaptations.cpp:
2868         (WebCore::watchAdaptationName):
2869         (WebCore::extraZoomModeAdaptationName): Deleted.
2870         * page/DisabledAdaptations.h:
2871         * page/ViewportConfiguration.cpp:
2872         (WebCore::needsUpdateAfterChangingDisabledAdaptations):
2873         (WebCore::ViewportConfiguration::shouldOverrideDeviceWidthAndShrinkToFit const):
2874         * page/WindowFeatures.cpp:
2875         (WebCore::parseDisabledAdaptations):
2876         * testing/Internals.cpp:
2877         (WebCore::Internals::extraZoomModeAdaptationName const): Deleted.
2878         * testing/Internals.h:
2879         * testing/Internals.idl:
2880
2881 2018-06-17  Youenn Fablet  <youenn@apple.com>
2882
2883         Rename Document::hasHadActiveMediaStreamTrack to Document::hasHadCaptureMediaStreamTrack
2884         https://bugs.webkit.org/show_bug.cgi?id=186743
2885         rdar://problem/41151193
2886
2887         Reviewed by Eric Carlson.
2888
2889         Covered by existing tests.
2890
2891         Rename setter and getter to be more accurate.
2892         Move the place to call the setter to when creating a capture stream.
2893
2894         * Modules/mediastream/MediaDevicesRequest.cpp:
2895         (WebCore::MediaDevicesRequest::start):
2896         * Modules/mediastream/MediaStream.cpp:
2897         (WebCore::MediaStream::statusDidChange):
2898         * Modules/mediastream/UserMediaRequest.cpp:
2899         (WebCore::UserMediaRequest::mediaStreamIsReady):
2900         * dom/Document.h:
2901         (WebCore::Document::setHasCaptureMediaStreamTrack):
2902         (WebCore::Document::hasHadCaptureMediaStreamTrack const):
2903         (WebCore::Document::setHasActiveMediaStreamTrack): Deleted.
2904         (WebCore::Document::hasHadActiveMediaStreamTrack const): Deleted.
2905
2906 2018-06-17  Zalan Bujtas  <zalan@apple.com>
2907
2908         [LFC] DisplayBox API should be more clear about height/width vs. contentBoxHeight/width
2909         https://bugs.webkit.org/show_bug.cgi?id=186744
2910
2911         Reviewed by Antti Koivisto.
2912
2913         Display::Box::height/width -> border box size.
2914         Display::Box::contentBoxHeight/width -> content box size.
2915         Display::Box::top/left/bottom/right -> border box position in the containing box's coordinate system.
2916         Display::Box::marginBox/borderBox/paddingBox/contentBox -> relative to border box (border box is { 0, 0 })
2917  
2918         (This patch also removes the box-sizing logic from Display::Box. FormattingContext::Geometry should set the
2919         correct contentBoxSize/borderBoxSize based on the CSS property.)
2920
2921         * layout/FormattingContext.cpp:
2922         (WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
2923         (WebCore::Layout::FormattingContext::computeFloatingWidthAndMargin const):
2924         (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
2925         (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
2926         (WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):
2927         * layout/FormattingContextGeometry.cpp:
2928         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
2929         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
2930         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
2931         (WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
2932         (WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
2933         (WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
2934         (WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
2935         (WebCore::Layout::FormattingContext::Geometry::computedPadding):
2936         (WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
2937         (WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):
2938         * layout/LayoutContext.cpp:
2939         (WebCore::Layout::LayoutContext::initializeRoot):
2940         * layout/blockformatting/BlockFormattingContext.cpp:
2941         (WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):
2942         (WebCore::Layout::BlockFormattingContext::computeInFlowWidthAndMargin const):
2943         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
2944         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
2945         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
2946         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
2947         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
2948         * layout/displaytree/DisplayBox.cpp:
2949         (WebCore::Display::Box::marginBox const):
2950         (WebCore::Display::Box::borderBox const):
2951         (WebCore::Display::Box::paddingBox const):
2952         (WebCore::Display::Box::contentBox const):
2953         * layout/displaytree/DisplayBox.h:
2954         (WebCore::Display::Box::top const):
2955         (WebCore::Display::Box::left const):
2956         (WebCore::Display::Box::bottom const):
2957         (WebCore::Display::Box::right const):
2958         (WebCore::Display::Box::topLeft const):
2959         (WebCore::Display::Box::bottomRight const):
2960         (WebCore::Display::Box::size const):
2961         (WebCore::Display::Box::width const):
2962         (WebCore::Display::Box::height const):
2963         (WebCore::Display::Box::rect const):
2964         (WebCore::Display::Box::setTopLeft):
2965         (WebCore::Display::Box::setTop):
2966         (WebCore::Display::Box::setLeft):
2967         (WebCore::Display::Box::moveHorizontally):
2968         (WebCore::Display::Box::moveVertically):
2969         (WebCore::Display::Box::setHasValidContentHeight):
2970         (WebCore::Display::Box::setHasValidContentWidth):
2971         (WebCore::Display::Box::setContentBoxHeight):
2972         (WebCore::Display::Box::setContentBoxWidth):
2973         (WebCore::Display::Box::contentBoxHeight const):
2974         (WebCore::Display::Box::contentBoxWidth const):
2975         (WebCore::Display::Box::setWidth): Deleted.
2976         (WebCore::Display::Box::setHeight): Deleted.
2977         (WebCore::Display::Box::setSize): Deleted.
2978
2979 2018-06-17  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2980
2981         [GTK] Correct behavior for dark themes
2982         https://bugs.webkit.org/show_bug.cgi?id=186219
2983
2984         Reviewed by Michael Catanzaro.
2985
2986         Override RenderThemeGtk::isControlStyled() to not style
2987         text inputs if color is set different than default.
2988
2989         No new tests. Manual theme test and existing layout tests already cover it.
2990
2991         * rendering/RenderThemeGtk.cpp:
2992         (WebCore::RenderThemeGtk::isControlStyled const):
2993         * rendering/RenderThemeGtk.h:
2994
2995 2018-06-12  Darin Adler  <darin@apple.com>
2996
2997         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
2998         https://bugs.webkit.org/show_bug.cgi?id=186526
2999
3000         Reviewed by Anders Carlsson.
3001
3002         * platform/ios/UserAgentIOS.mm:
3003         (WebCore::deviceNameForUserAgent): Drop unnecessary use of RetainPtr.
3004
3005         * platform/mac/URLMac.mm:
3006         (WebCore::URL::operator NSURL * const): Use bridgingAutorelease.
3007
3008 2018-06-16  Chris Dumez  <cdumez@apple.com>
3009
3010         Better pack ResourceResponse
3011         https://bugs.webkit.org/show_bug.cgi?id=186718
3012
3013         Reviewed by Simon Fraser.
3014
3015         Better pack ResourceResponse to reduce its size on Mac from 632 to 616 bytes.
3016
3017         * platform/network/ResourceResponseBase.h:
3018
3019 2018-06-15  Chris Dumez  <cdumez@apple.com>
3020
3021         Better pack MediaQuery
3022         https://bugs.webkit.org/show_bug.cgi?id=186716
3023
3024         Reviewed by Simon Fraser.
3025
3026         Better pack MediaQuery to reduce its size from 48 bytes to 40 and save
3027         some memory.
3028
3029         * css/MediaQuery.cpp:
3030         (WebCore::MediaQuery::MediaQuery):
3031         * css/MediaQuery.h:
3032
3033 2018-06-15  Chris Dumez  <cdumez@apple.com>
3034
3035         StyleRuleMedia wastes 158KB of Vector capacity on cnn.com
3036         https://bugs.webkit.org/show_bug.cgi?id=186705
3037         <rdar://problem/41173637>
3038
3039         Reviewed by Simon Fraser.
3040
3041         Call shrinkToFit on RefPtr<StyleRuleBase> vectors in CSSParserImpl, after we're
3042         done parsing and before constructing StyleRuleMedia, StyleRuleSupports and
3043         deferred rules in StyleRuleGroup.
3044
3045         * css/parser/CSSParserImpl.cpp:
3046         (WebCore::CSSParserImpl::parseDeferredRuleList):
3047         (WebCore::CSSParserImpl::consumeMediaRule):
3048         (WebCore::CSSParserImpl::consumeSupportsRule):
3049
3050 2018-06-15  Chris Dumez  <cdumez@apple.com>
3051
3052         MediaQuerySet wastes a lot of vector capacity
3053         https://bugs.webkit.org/show_bug.cgi?id=186696
3054         <rdar://problem/41172850>
3055
3056         Reviewed by Simon Fraser.
3057
3058         Call shrinkToFit() on the MediaQuerySet after we're done parsing it
3059         to avoid wasting memory.
3060
3061         * css/parser/MediaQueryParser.cpp:
3062         (WebCore::MediaQueryParser::parseInternal):
3063
3064 2018-06-15  Chris Dumez  <cdumez@apple.com>
3065
3066         CachedRawResource wastes 57K of Vector capacity
3067         https://bugs.webkit.org/show_bug.cgi?id=186703
3068         <rdar://problem/41173515>
3069
3070         Reviewed by Simon Fraser.
3071
3072         Use 0 as minimum capacity for CachedRawResource::m_redirectChain, instead of the
3073         default value of 16. m_redirectChain usually contains very few items so 16 is
3074         wasteful, especially considering that m_redirectChain contains fairly large
3075         objects (std::pair<ResourceRequest, ResourceResponse>). CachedRawResource are
3076         stored in the memory cache so it is important to not use more memory than
3077         necessary.
3078
3079         We are also not worried about the performance cost of allocations here since
3080         this vector is only populated on HTTP redirects.
3081
3082         * loader/cache/CachedRawResource.h:
3083
3084 2018-06-15  Antti Koivisto  <antti@apple.com>
3085
3086         Semantic colors should not be transformed by color-filter
3087         https://bugs.webkit.org/show_bug.cgi?id=186566
3088         <rdar://problem/40705739>
3089
3090         Reviewed by Simon Fraser.
3091
3092         Test: css3/color-filters/color-filter-ignore-semantic.html
3093
3094         * platform/graphics/Color.h:
3095         (WebCore::Color::Color):
3096         (WebCore::Color::isSemantic const):
3097         (WebCore::Color::setIsSemantic):
3098
3099         Add a bit to Color to indicate it originated from a semantic color name.
3100         Note that a color compares unequal to the semantic version of the same color.
3101
3102         * platform/graphics/filters/FilterOperations.cpp:
3103         (WebCore::FilterOperations::transformColor const):
3104         * platform/graphics/mac/ColorMac.h:
3105         * platform/graphics/mac/ColorMac.mm:
3106         (WebCore::semanticColorFromNSColor):
3107         * rendering/RenderThemeMac.mm:
3108         (WebCore::RenderThemeMac::systemColor const):
3109
3110         Set the bit for semantic system colors.
3111
3112         * rendering/RenderTreeAsText.cpp:
3113         (WebCore::RenderTreeAsText::writeRenderObject):
3114
3115         Fix up the output to avoid unneccary render tree dump changes.
3116
3117 2018-06-15  Chris Dumez  <cdumez@apple.com>
3118
3119         Add API test coverage for SW RegistrationDatabase destruction and fix issues found by the test
3120         https://bugs.webkit.org/show_bug.cgi?id=186681
3121
3122         Reviewed by Brady Eidson.
3123
3124         * workers/service/server/RegistrationDatabase.cpp:
3125         (WebCore::RegistrationDatabase::RegistrationDatabase):
3126         (WebCore::RegistrationDatabase::importRecords):
3127         * workers/service/server/RegistrationDatabase.h:
3128         Rename m_session to m_sessionID for clarity.
3129
3130         * workers/service/server/RegistrationStore.cpp:
3131         (WebCore::RegistrationStore::~RegistrationStore):
3132         Drop bad assertion now that the RegistrationDatabase is refcounted
3133         and can outlive the RegistrationStore. The RegistrationDatabase will
3134         take care of closing / destroying the SQLiteDatabase on the background
3135         thread when destroyed.
3136
3137 2018-06-15  Timothy Hatcher  <timothy@apple.com>
3138
3139         REGRESSION (r232799): Form controls are blank in dark mode.
3140
3141         https://bugs.webkit.org/show_bug.cgi?id=186677
3142         rdar://problem/41162899
3143
3144         Reviewed by Wenson Hsieh.
3145
3146         * rendering/RenderThemeMac.mm:
3147         (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
3148         Dark mode controls don't have borders, just a semi-transparent background of shadows.
3149         In the dark mode case we can't disable borders, or we will not paint anything for the control.
3150
3151 2018-06-15  Zalan Bujtas  <zalan@apple.com>
3152
3153         [LFC] Fix static position left/top
3154         https://bugs.webkit.org/show_bug.cgi?id=186640
3155
3156         Reviewed by Antti Koivisto.
3157
3158         In visual formatting model, we normally go like [top, left] while LayoutPoint takes [x, y]. Let's make this less error prone.
3159
3160         * layout/FormattingContext.h:
3161         (WebCore::Layout::FormattingContext::Geometry::Position::operator LayoutPoint const):
3162         * layout/blockformatting/BlockFormattingContext.h:
3163         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
3164         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
3165         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
3166
3167 2018-06-15  Chris Dumez  <cdumez@apple.com>
3168
3169         Crash under WebCore::SWServer::registrationStoreImportComplete()
3170         https://bugs.webkit.org/show_bug.cgi?id=186644
3171         <rdar://problem/40982257>
3172
3173         Reviewed by Brady Eidson.
3174
3175         Fix lifetime management issues with RegistrationDatabase. RegistrationDatabase
3176         was previously subclassing CrossThreadTaskHandler. CrossThreadTaskHandler
3177         currently is not safe for objects that can get destroyed (such as
3178         RegistrationDatabase). This is because it does not keep the object alive
3179         when going to the background thread or back to the main thread. This would
3180         cause crashes such as the one in the radar.
3181
3182         To address the issue, stop subclassing CrossThreadTaskHandler and use a
3183         simple WorkQueue instead. RegistrationDatabase is now ThreadSafeRefCounted
3184         and we take care of ref'ing it whenever we dispatch a task to the work queue
3185         or back to the main thread. Because the RegistrationDatabase can now outlive
3186         the RegistrationStore, m_store is now a WeakPtr.
3187
3188         * workers/service/server/RegistrationDatabase.cpp:
3189         (WebCore::RegistrationDatabase::RegistrationDatabase):
3190         (WebCore::RegistrationDatabase::~RegistrationDatabase):
3191         (WebCore::RegistrationDatabase::postTaskToWorkQueue):
3192         (WebCore::RegistrationDatabase::openSQLiteDatabase):
3193         (WebCore::RegistrationDatabase::importRecordsIfNecessary):
3194         (WebCore::RegistrationDatabase::pushChanges):
3195         (WebCore::RegistrationDatabase::clearAll):
3196         (WebCore::RegistrationDatabase::importRecords):
3197         (WebCore::RegistrationDatabase::addRegistrationToStore):
3198         (WebCore::RegistrationDatabase::databaseFailedToOpen):
3199         (WebCore::RegistrationDatabase::databaseOpenedAndRecordsImported):
3200         * workers/service/server/RegistrationDatabase.h:
3201         (WebCore::RegistrationDatabase::create):
3202         * workers/service/server/RegistrationStore.cpp:
3203         (WebCore::RegistrationStore::RegistrationStore):
3204         (WebCore::RegistrationStore::~RegistrationStore):
3205         (WebCore::RegistrationStore::pushChangesToDatabase):
3206         (WebCore::RegistrationStore::clearAll):
3207         * workers/service/server/RegistrationStore.h:
3208
3209 2018-06-15  Zalan Bujtas  <zalan@apple.com>
3210
3211         [LFC] Align compute functions styles.
3212         https://bugs.webkit.org/show_bug.cgi?id=186649
3213
3214         Reviewed by Antti Koivisto.
3215
3216         Improve code readability.
3217
3218         * layout/FormattingContext.h:
3219         * layout/FormattingContextGeometry.cpp:
3220         (WebCore::Layout::contentHeightForFormattingContextRoot):
3221         (WebCore::Layout::FormattingContext::Geometry::computedValueIfNotAuto):
3222         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
3223         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
3224         (WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
3225         (WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
3226         (WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
3227         (WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
3228         (WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
3229         (WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
3230         (WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):
3231         (WebCore::Layout::computedValueIfNotAuto): Deleted.
3232         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
3233         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
3234         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
3235         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
3236         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
3237         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
3238
3239 2018-06-15  Zalan Bujtas  <zalan@apple.com>
3240
3241         [LFC] Add FormattingContextLayout logging channel
3242         https://bugs.webkit.org/show_bug.cgi?id=186637
3243
3244         Reviewed by Antti Koivisto.
3245
3246         Add some basic layout logging (-WebCoreLogging "FormattingContextLayout").
3247
3248         * layout/FormattingContext.cpp:
3249         (WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const):
3250         (WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
3251         * layout/FormattingContextGeometry.cpp:
3252         (WebCore::Layout::contentHeightForFormattingContextRoot):
3253         (WebCore::Layout::shrinkToFitWidth):
3254         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
3255         (WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
3256         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
3257         (WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
3258         (WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
3259         (WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
3260         (WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
3261         (WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
3262         (WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
3263         (WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
3264         (WebCore::Layout::FormattingContext::Geometry::computedBorder):
3265         (WebCore::Layout::FormattingContext::Geometry::computedPadding):
3266         (WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
3267         (WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):
3268         * layout/Verification.cpp:
3269         (WebCore::Layout::outputMismatchingBoxInformationIfNeeded):
3270         (WebCore::Layout::verifyAndOutputSubtree):
3271         (WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree const):
3272         * layout/blockformatting/BlockFormattingContext.cpp:
3273         (WebCore::Layout::BlockFormattingContext::layout const):
3274         * layout/blockformatting/BlockFormattingContextGeometry.cpp:
3275         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
3276         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
3277         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
3278         (WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
3279         (WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
3280         * layout/layouttree/LayoutTreeBuilder.cpp:
3281         (WebCore::Layout::outputLayoutBox):
3282         (WebCore::Layout::outputLayoutTree):
3283         (WebCore::Layout::TreeBuilder::showLayoutTree):
3284         (WebCore::Layout::printLayoutTreeForLiveDocuments):
3285         * layout/layouttree/LayoutTreeBuilder.h:
3286         * platform/Logging.h:
3287
3288 2018-06-15  Antoine Quint  <graouts@apple.com>
3289
3290         [Web Animations] CSS Animations should take precedence over CSS Transitions
3291         https://bugs.webkit.org/show_bug.cgi?id=186651
3292
3293         Reviewed by Dean Jackson.
3294
3295         Ensure CSS Animations override CSS Transitions by modifying the order in which animations are returned by animationsForElement().
3296
3297         * animation/AnimationTimeline.cpp:
3298         (WebCore::AnimationTimeline::animationsForElement const):
3299
3300 2018-06-14  Youenn Fablet  <youenn@apple.com>
3301
3302         Make NetworkProcess get cache storage parameters at creation of the CacheStorage engine
3303         https://bugs.webkit.org/show_bug.cgi?id=186166
3304
3305         Reviewed by Alex Christensen.
3306
3307         Covered by existing tests.
3308
3309         * platform/network/NetworkStorageSession.h:
3310         (WebCore::NetworkStorageSession::cacheStorageDirectory const): Deleted.
3311         (WebCore::NetworkStorageSession::setCacheStorageDirectory): Deleted.
3312         (WebCore::NetworkStorageSession::cacheStoragePerOriginQuota const): Deleted.
3313         (WebCore::NetworkStorageSession::setCacheStoragePerOriginQuota): Deleted.
3314
3315 2018-06-14  Matt Lewis  <jlewis3@apple.com>
3316
3317         Unreviewed, rolling out r232823.
3318
3319         This caused both test timeouts and api failures.
3320
3321         Reverted changeset:
3322
3323         "[Mail] Use the Mail Viewer width as the base for resolving
3324         horizontal viewport units"
3325         https://bugs.webkit.org/show_bug.cgi?id=186585
3326         https://trac.webkit.org/changeset/232823
3327
3328 2018-06-14  Nan Wang  <n_wang@apple.com>
3329
3330         AX: Crash in AccessibilityNodeObject::textUnderElement(WebCore::AccessibilityTextUnderElementMode) const + 536
3331         https://bugs.webkit.org/show_bug.cgi?id=186629
3332
3333         Reviewed by Chris Fleizach.
3334
3335         This crashed when we passed a null node to ancestorsOfType. Fixed it
3336         by adding a null check.
3337
3338         Test: accessibility/hidden-object-text-value-crash.html
3339
3340         * accessibility/AccessibilityNodeObject.cpp:
3341         (WebCore::AccessibilityNodeObject::textUnderElement const):
3342
3343 2018-06-14  Timothy Hatcher  <timothy@apple.com>
3344
3345         Expose more semantic system colors.
3346
3347         https://bugs.webkit.org/show_bug.cgi?id=186609
3348         rdar://problem/39287277
3349
3350         Reviewed by Tim Horton.
3351
3352         Add the following semantic colors:
3353          -apple-system-control-accent
3354          -apple-system-even-alternating-content-background
3355          -apple-system-odd-alternating-content-background
3356          -apple-system-selected-content-background
3357          -apple-system-unemphasized-selected-content-background
3358          -apple-system-selected-text
3359          -apple-system-unemphasized-selected-text
3360          -apple-system-selected-text-background
3361          -apple-system-unemphasized-selected-text-background
3362          -apple-system-placeholder-text
3363          -apple-system-find-highlight-background
3364          -apple-system-separator
3365
3366         * css/CSSValueKeywords.in:
3367         * rendering/RenderThemeMac.mm:
3368         (WebCore::RenderThemeMac::systemColor const):
3369
3370 2018-06-14  Eric Carlson  <eric.carlson@apple.com>
3371
3372         [iOS] WebAVPlayerController isPlayingOnSecondScreen should be declared read-write
3373         https://bugs.webkit.org/show_bug.cgi?id=186621
3374         <rdar://problem/40243303>
3375
3376         Reviewed by Jer Noble.
3377
3378         * platform/ios/WebAVPlayerController.h:
3379
3380 2018-06-13  Zalan Bujtas  <zalan@apple.com>
3381
3382         [LFC] Miscellaneous fixes to be able to layout <div> with fixed width/height
3383         https://bugs.webkit.org/show_bug.cgi?id=186616
3384
3385         Reviewed by Antti Koivisto.
3386
3387         1. Move box horizontally/vertically when relevant margin is computed.
3388         2. Fix isStretchedToViewport() logic and make sure that the width/height is adjusted with the margin when the box is stretchy.
3389         3. Fix isPaddingApplicable() and add "GenericElement" for elements that don't need special handling.
3390
3391         With this patch LFC produces the correct geometry for the following content:
3392         <html><body><div style="width: 100px; height: 100px;"></div></body></html>
3393
3394         * layout/FormattingContext.cpp:
3395         (WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
3396         (WebCore::Layout::FormattingContext::computeFloatingWidthAndMargin const):
3397         * layout/blockformatting/BlockFormattingContext.cpp:
3398         (WebCore::Layout::BlockFormattingContext::layout const):