Fix one of the Qt builds.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2012-09-06  Sam Weinig  <sam@webkit.org>
2
3         Fix one of the Qt builds.
4
5         * dom/TransformSource.h:
6
7 2012-09-06  Zan Dobersek  <zandobersek@gmail.com>
8
9         Unreviewed GTK build fix.
10
11         CSS Compositing is not currently supported on the GTK port, so
12         the feature define should default to 0.
13
14         * GNUmakefile.features.am:
15
16 2012-09-05  James Robinson  <jamesr@chromium.org>
17
18         SharedGraphicsContext3D shouldn't depend on CCProxy
19         https://bugs.webkit.org/show_bug.cgi?id=95921
20
21         Reviewed by Adrienne Walker.
22
23         This class just wants to ASSERT() that we're on or not on the main thread. There's perfectly fine cross-platform
24         code in WTF to do that.
25
26         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
27         (WebCore::SharedGraphicsContext3D::getForImplThread):
28         (WebCore::SharedGraphicsContext3D::haveForImplThread):
29         (WebCore::SharedGraphicsContext3D::createForImplThread):
30
31 2012-09-06  Zan Dobersek  <zandobersek@gmail.com>
32
33         [Gtk] Remove configuration options for features that are not supported by the Gtk port
34         https://bugs.webkit.org/show_bug.cgi?id=87664
35
36         Reviewed by Martin Robinson.
37
38         Remove addition of macros to feature_defines for features that are completely
39         unsupported by the Gtk port. They're not required anymore since the accompanying
40         configuration flags are also being removed.
41
42         No new tests - no new functionality.
43
44         * GNUmakefile.am:
45         * bindings/gobject/GNUmakefile.am:
46
47 2012-09-06  Max Vujovic  <mvujovic@adobe.com>
48
49         [CSS Shaders] Vertex attributes should be unbound after a custom filter is applied
50         https://bugs.webkit.org/show_bug.cgi?id=95891
51
52         Reviewed by Dean Jackson.
53
54         Now we unbind the vertex attributes after a custom filter is applied.
55
56         Before this patch, Chromium's GPU process would sometimes print the following error message:
57         "ERROR:gles2_cmd_decoder.cc(5142)] 002CA47B: GL ERROR :GL_INVALID_OPERATION : 
58         glDrawElements: attempt to render with no buffer attached to enabled attribute 2"
59
60         This would happen in the following situation: 
61         1) There are two FECustomFilters on the page.
62         2) One FECustomFilter has a detached mesh. One FECustomFilter has an attached mesh. The 
63            detached FECustomFilter has one more vertex attribute (a_triangleCoord) than the attached
64            FECustomFilter.
65         3) The detached FECustomFilter is destroyed, but a_triangleCoord remains bound.
66         4) The attached FECustomFilter tries to render, but Chromium notices that there is no buffer
67            attached to the a_triangleCoord attribute.
68
69         No new tests. We can't create an automated test for this because it only reproduces using
70         Chromium's GPU process. DRT does not use Chromium's GPU process.
71
72         * platform/graphics/filters/FECustomFilter.cpp:
73         (WebCore::FECustomFilter::applyShader):
74             Unbind the vertex attributes after the drawElements call.
75         (WebCore::FECustomFilter::unbindVertexAttribute):
76         (WebCore):
77         (WebCore::FECustomFilter::unbindVertexAttributes):
78             Unbind all of the attributes that we bound earlier.
79         * platform/graphics/filters/FECustomFilter.h:
80         (FECustomFilter):
81
82 2012-09-05  Sam Weinig  <sam@webkit.org>
83
84         Part 2 of removing PlatformString.h, remove PlatformString.h
85         https://bugs.webkit.org/show_bug.cgi?id=95931
86
87         Reviewed by Adam Barth.
88
89         Remove PlatformString.h
90
91         * GNUmakefile.list.am:
92         * Modules/filesystem/AsyncFileWriter.h:
93         * Modules/filesystem/DOMFilePath.h:
94         * Modules/filesystem/DOMFileSystemBase.h:
95         * Modules/filesystem/DirectoryEntry.h:
96         * Modules/filesystem/DirectoryEntrySync.h:
97         * Modules/filesystem/DirectoryReader.h:
98         * Modules/filesystem/DirectoryReaderBase.h:
99         * Modules/filesystem/DirectoryReaderSync.h:
100         * Modules/filesystem/EntryBase.cpp:
101         * Modules/filesystem/EntrySync.h:
102         * Modules/filesystem/FileEntrySync.h:
103         * Modules/filesystem/FileSystemCallbacks.h:
104         * Modules/filesystem/LocalFileSystem.h:
105         * Modules/geolocation/GeolocationError.h:
106         * Modules/geolocation/Geoposition.h:
107         * Modules/geolocation/PositionError.h:
108         * Modules/indexeddb/IDBAny.h:
109         * Modules/indexeddb/IDBDatabaseBackendInterface.h:
110         * Modules/indexeddb/IDBDatabaseCallbacks.h:
111         * Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
112         * Modules/indexeddb/IDBDatabaseError.h:
113         * Modules/indexeddb/IDBFactory.h:
114         * Modules/indexeddb/IDBFactoryBackendInterface.h:
115         * Modules/indexeddb/IDBIndex.h:
116         * Modules/indexeddb/IDBIndexBackendInterface.h:
117         * Modules/indexeddb/IDBKey.h:
118         * Modules/indexeddb/IDBKeyPath.h:
119         * Modules/indexeddb/IDBMetadata.h:
120         * Modules/indexeddb/IDBObjectStore.h:
121         * Modules/indexeddb/IDBObjectStoreBackendInterface.h:
122         * Modules/indexeddb/IDBTransactionBackendInterface.h:
123         * Modules/indexeddb/IDBUpgradeNeededEvent.h:
124         * Modules/indexeddb/IDBVersionChangeEvent.h:
125         * Modules/mediastream/MediaStreamTrack.h:
126         * Modules/networkinfo/NetworkInfoConnection.h:
127         * Modules/notifications/DOMWindowNotifications.h:
128         * Modules/speech/SpeechGrammar.h:
129         * Modules/speech/SpeechRecognition.h:
130         * Modules/speech/SpeechRecognitionAlternative.h:
131         * Modules/speech/SpeechRecognitionClient.h:
132         * Modules/speech/SpeechRecognitionError.h:
133         * Modules/webaudio/AudioContext.cpp:
134         * Modules/webaudio/AudioParam.h:
135         * Modules/webdatabase/AbstractDatabase.h:
136         * Modules/webdatabase/ChangeVersionWrapper.h:
137         * Modules/webdatabase/DOMWindowWebDatabase.h:
138         * Modules/webdatabase/Database.h:
139         * Modules/webdatabase/DatabaseAuthorizer.cpp:
140         * Modules/webdatabase/DatabaseAuthorizer.h:
141         * Modules/webdatabase/DatabaseDetails.h:
142         * Modules/webdatabase/DatabaseSync.h:
143         * Modules/webdatabase/DatabaseTask.h:
144         * Modules/webdatabase/DatabaseTracker.h:
145         * Modules/webdatabase/OriginUsageRecord.h:
146         * Modules/webdatabase/SQLError.h:
147         * Modules/webdatabase/SQLStatement.h:
148         * Modules/webdatabase/SQLStatementSync.h:
149         * Modules/webdatabase/SQLTransaction.cpp:
150         * Modules/webdatabase/SQLTransactionSync.cpp:
151         * Modules/webdatabase/SQLTransactionSync.h:
152         * Modules/webdatabase/WorkerContextWebDatabase.h:
153         * Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
154         * Modules/webdatabase/chromium/QuotaTracker.h:
155         * Modules/websockets/ThreadableWebSocketChannel.cpp:
156         * Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
157         * Modules/websockets/WebSocketHandshake.h:
158         * Modules/websockets/WebSocketHandshakeResponse.h:
159         * Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
160         * Modules/websockets/WorkerThreadableWebSocketChannel.h:
161         * WebCore.gypi:
162         * WebCore.vcproj/WebCore.vcproj:
163         * WebCore.xcodeproj/project.pbxproj:
164         * bindings/gobject/ConvertToUTF8String.cpp:
165         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
166         * bindings/js/JSClipboardCustom.cpp:
167         * bindings/js/JSImageDataCustom.cpp:
168         * bindings/js/JSInspectorFrontendHostCustom.cpp:
169         * bindings/js/JSLazyEventListener.h:
170         * bindings/js/JSStorageCustom.cpp:
171         * bindings/js/JSXSLTProcessorCustom.cpp:
172         * bindings/js/JavaScriptCallFrame.cpp:
173         * bindings/js/ScheduledAction.h:
174         * bindings/js/ScriptDebugServer.h:
175         * bindings/js/ScriptHeapSnapshot.h:
176         * bindings/js/ScriptValue.h:
177         * bindings/js/SerializedScriptValue.h:
178         * bindings/objc/DOMCustomXPathNSResolver.mm:
179         * bindings/objc/DOMXPath.mm:
180         * bindings/objc/WebScriptObject.mm:
181         * bindings/scripts/CodeGeneratorJS.pm:
182         (AddIncludesForTypeInImpl):
183         (AddIncludesForSVGAnimatedType):
184         * bindings/scripts/CodeGeneratorV8.pm:
185         (AddIncludesForType):
186         * bindings/v8/Dictionary.h:
187         * bindings/v8/JavaScriptCallFrame.h:
188         * bindings/v8/NPV8Object.cpp:
189         * bindings/v8/ScriptDebugServer.h:
190         * bindings/v8/ScriptFunctionCall.h:
191         * bindings/v8/ScriptHeapSnapshot.h:
192         * bindings/v8/ScriptProfile.h:
193         * bindings/v8/ScriptProfileNode.h:
194         * bindings/v8/ScriptProfiler.h:
195         * bindings/v8/ScriptSourceCode.h:
196         * bindings/v8/V8Binding.cpp:
197         * bindings/v8/V8DOMWrapper.h:
198         * bindings/v8/V8LazyEventListener.h:
199         * bindings/v8/V8NPUtils.cpp:
200         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
201         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
202         * bindings/v8/custom/V8LocationCustom.cpp:
203         * bridge/IdentifierRep.cpp:
204         * bridge/NP_jsobject.cpp:
205         * bridge/c/c_utility.cpp:
206         * css/CSSBasicShapes.h:
207         * css/CSSBorderImageSliceValue.cpp:
208         * css/CSSCharsetRule.h:
209         * css/CSSCursorImageValue.cpp:
210         * css/CSSFontFaceSrcValue.h:
211         * css/CSSGradientValue.cpp:
212         * css/CSSInheritedValue.cpp:
213         * css/CSSInitialValue.cpp:
214         * css/CSSLineBoxContainValue.cpp:
215         * css/CSSMediaRule.h:
216         * css/CSSProperty.cpp:
217         * css/CSSPropertySourceData.cpp:
218         * css/CSSPropertySourceData.h:
219         * css/CSSReflectValue.cpp:
220         * css/CSSTimingFunctionValue.cpp:
221         * css/CSSUnicodeRangeValue.cpp:
222         * css/CSSValueList.cpp:
223         * css/Counter.h:
224         * css/FontFeatureValue.h:
225         * css/FontValue.cpp:
226         * css/MediaQuery.h:
227         * css/MediaQueryEvaluator.h:
228         * css/MediaQueryListListener.h:
229         * css/ShadowValue.cpp:
230         * css/StyleMedia.h:
231         * css/StyleSheet.h:
232         * css/StyleSheetList.cpp:
233         * css/WebKitCSSMatrix.h:
234         * css/WebKitCSSTransformValue.cpp:
235         * dom/DOMStringList.h:
236         * dom/DOMStringMap.h:
237         * dom/DocumentMarker.h:
238         * dom/ErrorEvent.h:
239         * dom/ExceptionBase.h:
240         * dom/MessagePortChannel.h:
241         * dom/MutationRecord.h:
242         * dom/TransformSource.h:
243         * dom/ViewportArguments.cpp:
244         * editing/DOMTransactionStep.h:
245         * editing/EditingStyle.h:
246         * editing/MarkupAccumulator.h:
247         * editing/SmartReplaceICU.cpp:
248         * editing/SpellChecker.h:
249         * editing/SurroundingText.h:
250         * fileapi/AsyncFileStream.cpp:
251         * fileapi/Blob.h:
252         * fileapi/BlobURL.cpp:
253         * fileapi/File.h:
254         * history/HistoryItem.h:
255         * history/blackberry/HistoryItemViewState.h:
256         * history/cf/HistoryPropertyList.h:
257         * html/DOMFormData.cpp:
258         * html/DOMURL.h:
259         * html/MicroDataItemValue.h:
260         * html/PublicURLManager.h:
261         * html/canvas/CanvasPattern.cpp:
262         * html/canvas/CanvasRenderingContext2D.h:
263         * html/canvas/CanvasStyle.h:
264         * html/canvas/WebGLActiveInfo.h:
265         * html/canvas/WebGLGetInfo.h:
266         * html/canvas/WebGLRenderingContext.h:
267         * html/parser/CSSPreloadScanner.h:
268         * html/parser/HTMLEntitySearch.h:
269         * html/parser/HTMLEntityTable.h:
270         * html/parser/HTMLMetaCharsetParser.cpp:
271         * inspector/CodeGeneratorInspector.py:
272         (InspectorFrontend_h):
273         * inspector/ContentSearchUtils.h:
274         * inspector/InjectedScript.cpp:
275         * inspector/InjectedScriptBase.cpp:
276         * inspector/InjectedScriptManager.h:
277         * inspector/InjectedScriptModule.h:
278         * inspector/InjectedScriptWebGLModule.h:
279         * inspector/InspectorAgent.h:
280         * inspector/InspectorCSSAgent.h:
281         * inspector/InspectorController.h:
282         * inspector/InspectorDOMDebuggerAgent.h:
283         * inspector/InspectorDOMStorageAgent.h:
284         * inspector/InspectorDatabaseAgent.h:
285         * inspector/InspectorDatabaseResource.h:
286         * inspector/InspectorFrontendClientLocal.cpp:
287         * inspector/InspectorFrontendClientLocal.h:
288         * inspector/InspectorFrontendHost.h:
289         * inspector/InspectorIndexedDBAgent.h:
290         * inspector/InspectorPageAgent.h:
291         * inspector/InspectorProfilerAgent.h:
292         * inspector/InspectorResourceAgent.h:
293         * inspector/InspectorState.h:
294         * inspector/InspectorStyleSheet.h:
295         * inspector/InspectorStyleTextEditor.h:
296         * inspector/InspectorValues.h:
297         * inspector/InspectorWebGLAgent.h:
298         * inspector/InspectorWorkerResource.h:
299         * inspector/ScriptArguments.h:
300         * inspector/ScriptBreakpoint.h:
301         * inspector/ScriptCallFrame.h:
302         * inspector/ScriptDebugListener.h:
303         * inspector/TimelineRecordFactory.h:
304         * inspector/generate-inspector-protocol-version:
305         (main):
306         * loader/DocumentLoader.cpp:
307         * loader/DocumentWriter.h:
308         * loader/FTPDirectoryParser.h:
309         * loader/FormState.h:
310         * loader/HistoryController.h:
311         * loader/PolicyChecker.h:
312         * loader/ResourceLoadScheduler.h:
313         * loader/SubframeLoader.h:
314         * loader/SubstituteData.h:
315         * loader/WorkerThreadableLoader.h:
316         * loader/appcache/ApplicationCache.h:
317         * loader/appcache/ApplicationCacheGroup.h:
318         * loader/archive/ArchiveFactory.cpp:
319         * loader/archive/ArchiveResourceCollection.h:
320         * loader/cache/CachedResource.h:
321         * loader/cache/MemoryCache.h:
322         * loader/icon/IconRecord.h:
323         * loader/icon/PageURLRecord.h:
324         * loader/mac/LoaderNSURLExtras.mm:
325         * loader/win/DocumentLoaderWin.cpp:
326         * page/Console.cpp:
327         * page/Coordinates.h:
328         * page/DOMSelection.cpp:
329         * page/EventSource.cpp:
330         * page/GroupSettings.h:
331         * page/NavigatorBase.cpp:
332         * page/OriginAccessEntry.h:
333         * page/Page.h:
334         * page/SecurityOrigin.h:
335         * page/SpeechInputResult.h:
336         * page/UserContentURLPattern.h:
337         * page/WindowFeatures.cpp:
338         * page/WindowFeatures.h:
339         * page/WorkerNavigator.h:
340         * page/animation/AnimationControllerPrivate.h:
341         * platform/AsyncFileSystem.h:
342         * platform/AsyncFileSystemCallbacks.h:
343         * platform/ContentType.h:
344         * platform/ContextMenu.h:
345         * platform/ContextMenuItem.h:
346         * platform/Cookie.h:
347         * platform/CrossThreadCopier.cpp:
348         * platform/DateComponents.cpp:
349         * platform/FileChooser.h:
350         * platform/FileStream.cpp:
351         * platform/FileSystem.h:
352         * platform/KURL.cpp:
353         (WebCore):
354         * platform/KURL.h:
355         * platform/KURLHash.h:
356         * platform/KillRing.h:
357         * platform/Language.cpp:
358         * platform/Length.cpp:
359         * platform/LinkHash.cpp:
360         * platform/Logging.cpp:
361         * platform/MIMETypeRegistry.h:
362         * platform/SSLKeyGenerator.h:
363         * platform/SchemeRegistry.h:
364         * platform/SharedBuffer.h:
365         * platform/Theme.h:
366         * platform/UUID.h:
367         * platform/animation/Animation.h:
368         * platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
369         * platform/blackberry/CookieManager.h:
370         * platform/blackberry/CookieMap.h:
371         * platform/blackberry/DragDataBlackBerry.cpp:
372         * platform/blackberry/KURLBlackBerry.cpp:
373         * platform/blackberry/LocalizedStringsBlackBerry.cpp:
374         * platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
375         * platform/blackberry/TemporaryLinkStubs.cpp:
376         * platform/cf/FileSystemCF.cpp:
377         * platform/cf/SchedulePair.h:
378         * platform/chromium/ChromiumDataObject.h:
379         * platform/chromium/ClipboardUtilitiesChromium.cpp:
380         * platform/chromium/DragDataChromium.cpp:
381         * platform/chromium/FileSystemChromium.cpp:
382         * platform/chromium/FileSystemChromiumMac.mm:
383         * platform/chromium/LanguageChromium.cpp:
384         * platform/chromium/SSLKeyGeneratorChromium.cpp:
385         * platform/cocoa/KeyEventCocoa.mm:
386         * platform/efl/ErrorsEfl.h:
387         * platform/efl/LanguageEfl.cpp:
388         * platform/efl/LocalizedStringsEfl.cpp:
389         * platform/efl/LoggingEfl.cpp:
390         * platform/efl/PasteboardEfl.cpp:
391         * platform/efl/PlatformScreenEfl.cpp:
392         * platform/graphics/ANGLEWebKitBridge.h:
393         * platform/graphics/BitmapImage.cpp:
394         * platform/graphics/FontPlatformData.cpp:
395         * platform/graphics/GlyphPageTreeNode.cpp:
396         * platform/graphics/GraphicsContext3D.h:
397         * platform/graphics/GraphicsTypes.cpp:
398         * platform/graphics/SegmentedFontData.cpp:
399         * platform/graphics/blackberry/IconBlackBerry.cpp:
400         * platform/graphics/blackberry/LayerData.h:
401         * platform/graphics/blackberry/LayerFilterRenderer.cpp:
402         * platform/graphics/blackberry/LayerRenderer.cpp:
403         * platform/graphics/blackberry/skia/PlatformSupport.h:
404         * platform/graphics/ca/PlatformCALayer.h:
405         * platform/graphics/ca/PlatformCALayerClient.h:
406         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
407         * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
408         * platform/graphics/cairo/ImageBufferCairo.cpp:
409         * platform/graphics/cairo/PathCairo.cpp:
410         * platform/graphics/cg/ImageSourceCGMac.mm:
411         * platform/graphics/cg/PathCG.cpp:
412         * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
413         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
414         * platform/graphics/chromium/IconChromium.cpp:
415         * platform/graphics/chromium/IconChromiumAndroid.cpp:
416         * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
417         * platform/graphics/efl/IconEfl.cpp:
418         * platform/graphics/filters/FEComposite.h:
419         * platform/graphics/filters/FEDisplacementMap.h:
420         * platform/graphics/filters/SourceAlpha.cpp:
421         * platform/graphics/filters/SourceAlpha.h:
422         * platform/graphics/filters/SourceGraphic.cpp:
423         * platform/graphics/filters/SourceGraphic.h:
424         * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
425         * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
426         * platform/graphics/mac/IconMac.mm:
427         * platform/graphics/mac/ImageMac.mm:
428         * platform/graphics/opentype/OpenTypeUtilities.h:
429         * platform/graphics/openvg/PathOpenVG.cpp:
430         * platform/graphics/pango/FontPlatformDataPango.cpp:
431         * platform/graphics/qt/FontCacheQt.cpp:
432         * platform/graphics/qt/FontPlatformDataQt.cpp:
433         * platform/graphics/qt/IconQt.cpp:
434         * platform/graphics/qt/ImageQt.cpp:
435         * platform/graphics/qt/PathQt.cpp:
436         * platform/graphics/skia/FontCustomPlatformData.h:
437         * platform/graphics/skia/ImageSkia.cpp:
438         * platform/graphics/win/FontCustomPlatformData.h:
439         * platform/graphics/win/FontPlatformDataCGWin.cpp:
440         * platform/graphics/win/FontPlatformDataCairoWin.cpp:
441         * platform/graphics/win/FontPlatformDataWin.cpp:
442         * platform/graphics/win/IconWin.cpp:
443         * platform/graphics/win/ImageCGWin.cpp:
444         * platform/graphics/win/ImageCairoWin.cpp:
445         * platform/graphics/win/SimpleFontDataCGWin.cpp:
446         * platform/graphics/wince/FontCustomPlatformData.h:
447         * platform/graphics/wince/FontPlatformData.cpp:
448         * platform/graphics/wince/ImageWinCE.cpp:
449         * platform/graphics/wince/MediaPlayerProxy.cpp:
450         * platform/graphics/wince/PathWinCE.cpp:
451         * platform/graphics/wince/PlatformPathWinCE.cpp:
452         * platform/graphics/wx/FontCacheWx.cpp:
453         * platform/graphics/wx/FontPlatformDataWx.cpp:
454         * platform/graphics/wx/IconWx.cpp:
455         * platform/graphics/wx/PathWx.cpp:
456         * platform/gtk/ErrorsGtk.h:
457         * platform/gtk/FileSystemGtk.cpp:
458         * platform/gtk/GtkPopupMenu.h:
459         * platform/gtk/KeyBindingTranslator.h:
460         * platform/gtk/LanguageGtk.cpp:
461         * platform/gtk/LocalizedStringsGtk.cpp:
462         * platform/gtk/LoggingGtk.cpp:
463         * platform/gtk/PasteboardGtk.cpp:
464         * platform/image-decoders/ImageDecoder.h:
465         * platform/leveldb/LevelDBSlice.h:
466         * platform/mac/FileSystemMac.mm:
467         * platform/mediastream/MediaStreamSource.h:
468         * platform/mock/GeolocationClientMock.h:
469         * platform/network/BlobData.h:
470         * platform/network/BlobRegistryImpl.h:
471         * platform/network/BlobResourceHandle.h:
472         * platform/network/Credential.h:
473         * platform/network/FormData.h:
474         * platform/network/FormDataBuilder.h:
475         * platform/network/HTTPParsers.cpp:
476         * platform/network/HTTPRequest.h:
477         * platform/network/HTTPValidation.cpp:
478         * platform/network/ProtectionSpace.h:
479         * platform/network/ResourceErrorBase.h:
480         * platform/network/SocketStreamErrorBase.h:
481         * platform/network/blackberry/DNSBlackBerry.cpp:
482         * platform/network/blackberry/DeferredData.h:
483         * platform/network/blackberry/NetworkJob.h:
484         * platform/network/cf/CookieJarCFNet.cpp:
485         * platform/network/curl/CookieJarCurl.cpp:
486         * platform/network/curl/ResourceHandleManager.h:
487         * platform/network/qt/DnsPrefetchHelper.cpp:
488         * platform/network/soup/ResourceRequestSoup.cpp:
489         * platform/network/soup/ResourceResponseSoup.cpp:
490         * platform/network/win/CookieJarWin.cpp:
491         * platform/posix/FileSystemPOSIX.cpp:
492         * platform/qt/ClipboardQt.cpp:
493         * platform/qt/CookieJarQt.cpp:
494         * platform/qt/FileSystemQt.cpp:
495         * platform/qt/LanguageQt.cpp:
496         * platform/qt/LocalizedStringsQt.cpp:
497         * platform/qt/LoggingQt.cpp:
498         * platform/qt/PlatformSupport.h:
499         * platform/sql/SQLValue.h:
500         * platform/sql/SQLiteDatabase.h:
501         * platform/sql/SQLiteFileSystem.h:
502         * platform/text/DecodeEscapeSequences.h:
503         * platform/text/LineEnding.cpp:
504         * platform/text/ParserUtilities.h:
505         * platform/text/PlatformString.h: Removed.
506         * platform/text/RegularExpression.h:
507         * platform/text/SegmentedString.h:
508         * platform/text/StringWithDirection.h:
509         * platform/text/SuffixTree.h:
510         * platform/text/TextBreakIteratorICU.cpp:
511         * platform/text/TextCodec.cpp:
512         * platform/text/TextCodec.h:
513         * platform/text/TextCodecLatin1.cpp:
514         * platform/text/TextCodecUTF16.cpp:
515         * platform/text/TextCodecUserDefined.cpp:
516         * platform/text/TextEncoding.cpp:
517         * platform/text/blackberry/StringBlackBerry.cpp:
518         * platform/text/cf/StringCF.cpp:
519         * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
520         * platform/text/gtk/TextCodecGtk.cpp:
521         * platform/text/mac/StringMac.mm:
522         * platform/text/mac/TextCodecMac.cpp:
523         * platform/text/qt/TextCodecQt.cpp:
524         * platform/text/win/TextCodecWin.h:
525         * platform/text/wince/TextBreakIteratorWinCE.cpp:
526         * platform/win/BString.cpp:
527         * platform/win/DragDataWin.cpp:
528         * platform/win/GDIObjectCounter.h:
529         * platform/win/LoggingWin.cpp:
530         * platform/win/WCDataObject.cpp:
531         * platform/wince/DragDataWinCE.cpp:
532         * platform/wx/ClipboardWx.cpp:
533         * platform/wx/FileSystemWx.cpp:
534         * platform/wx/LanguageWx.cpp:
535         * platform/wx/LocalizedStringsWx.cpp:
536         * platform/wx/LoggingWx.cpp:
537         * platform/wx/PasteboardWx.cpp:
538         * platform/wx/PopupMenuWx.cpp:
539         * plugins/PluginData.h:
540         * plugins/PluginDatabase.h:
541         * plugins/PluginDebug.cpp:
542         * plugins/PluginPackage.h:
543         * plugins/PluginStream.h:
544         * rendering/style/StyleDashboardRegion.h:
545         * storage/Storage.cpp:
546         * storage/StorageArea.h:
547         * storage/StorageEvent.h:
548         * storage/StorageEventDispatcher.h:
549         * storage/StorageMap.h:
550         * storage/StorageNamespace.h:
551         * storage/StorageNamespaceImpl.h:
552         * storage/StorageSyncManager.h:
553         * storage/StorageTask.h:
554         * storage/StorageTracker.h:
555         * svg/SVGPathByteStreamBuilder.h:
556         * svg/SVGPathParser.h:
557         * svg/SVGPathStringSource.h:
558         * svg/SVGStyledElement.cpp:
559         * svg/animation/SMILTimeContainer.h:
560         * svg/graphics/filters/SVGFilterBuilder.cpp:
561         * svg/graphics/filters/SVGFilterBuilder.h:
562         * testing/Internals.h:
563         * workers/DefaultSharedWorkerRepository.cpp:
564         * workers/WorkerLocation.cpp:
565         * workers/WorkerThread.cpp:
566         * xml/DOMParser.cpp:
567         * xml/NativeXPathNSResolver.cpp:
568         * xml/XMLSerializer.cpp:
569         * xml/XMLSerializer.h:
570         * xml/XPathExpression.cpp:
571         * xml/XPathValue.h:
572         * xml/XSLTUnicodeSort.cpp:
573
574 2012-09-06  Dana Jansens  <danakj@chromium.org>
575
576         [chromium] Add a customized copy() method to CCRenderPassDrawQuad
577         https://bugs.webkit.org/show_bug.cgi?id=95871
578
579         Reviewed by Adrienne Walker.
580
581         CCRenderPassDrawQuad is special because a copied quad will need to
582         point to a different RenderPass id, since new ids are given to copied
583         RenderPasses. Add a custom copy() method to CCRenderPassDrawQuad that
584         takes as input the new RenderPass id that should appear in the copied
585         quad.
586
587         Test: CCDrawQuad.copyRenderPassDrawQuad
588
589         * platform/graphics/chromium/cc/CCDrawQuad.cpp:
590         (WebCore::CCDrawQuad::copy):
591         * platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
592         (WebCore::CCRenderPassDrawQuad::copy):
593         (WebCore):
594         * platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
595         (CCRenderPassDrawQuad):
596
597 2012-09-06  Nikhil Bhargava  <nbhargava@google.com>
598
599         Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
600         https://bugs.webkit.org/show_bug.cgi?id=95780
601
602         Reviewed by Eric Seidel.
603
604         Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
605         and Clipboard. There is a minor compile-time performance boost.
606
607         * Modules/mediastream/MediaStreamEvent.h:
608         * dom/Event.cpp:
609         * dom/Event.h:
610         (WebCore):
611         * dom/EventDispatchMediator.cpp:
612         * dom/EventListenerMap.cpp:
613         * dom/MouseRelatedEvent.h:
614         * dom/UIEvent.cpp:
615         * html/FormAssociatedElement.h:
616         (WebCore):
617         * inspector/TimelineRecordFactory.cpp:
618         * platform/graphics/FontPlatformData.h:
619         * rendering/RenderLineBoxList.h:
620         * rendering/style/RenderStyle.h:
621         (WebCore):
622         * svg/SVGAnimatedType.h:
623         * svg/SVGExternalResourcesRequired.cpp:
624         * svg/SVGExternalResourcesRequired.h:
625         (WebCore):
626         * svg/SVGURIReference.h:
627         (WebCore):
628
629 2012-09-06  Dan Bernstein  <mitz@apple.com>
630
631         REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
632         https://bugs.webkit.org/show_bug.cgi?id=95972
633
634         Reverted r127712, because it was based on the false premise that “[Optional] works the way
635         XMLHttpRequest expects”.
636
637         * bindings/js/JSXMLHttpRequestCustom.cpp:
638         (WebCore::JSXMLHttpRequest::open):
639         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
640         (WebCore::V8XMLHttpRequest::openCallback):
641         (WebCore):
642         * xml/XMLHttpRequest.cpp:
643         (WebCore::XMLHttpRequest::open):
644         (WebCore):
645         * xml/XMLHttpRequest.h:
646         (XMLHttpRequest):
647         * xml/XMLHttpRequest.idl:
648
649 2012-09-06  Keishi Hattori  <keishi@webkit.org>
650
651         Use native function bind in page popups
652         https://bugs.webkit.org/show_bug.cgi?id=95976
653
654         Reviewed by Kent Tamura.
655
656         We should be using Function.prototype.bind instead of our own bind implementation.
657
658         No new tests. No behavior change.
659
660         * Resources/pagepopups/calendarPicker.js:
661         (CalendarPicker):
662         (CalendarPicker.prototype._layoutButtons):
663         (YearMonthController.prototype.attachTo):
664         (YearMonthController.prototype._attachLeftButtonsTo):
665         (YearMonthController.prototype._attachRightButtonsTo):
666         (DaysTable.prototype.attachTo):
667         * Resources/pagepopups/colorSuggestionPicker.js:
668         (ColorPicker):
669         (ColorPicker.prototype._layout):
670         * Resources/pagepopups/pickerCommon.js:
671
672 2012-09-06  Eugene Klyuchnikov  <eustas.bug@gmail.com>
673
674         Web Inspector: Timeline: cache "filteredRecords" for better scrolling performance.
675         https://bugs.webkit.org/show_bug.cgi?id=95731
676
677         Reviewed by Yury Semikhatsky.
678
679         Now scrolling is sluggish on large datasets.
680         Performance degrades, because each refresh causes DFS on all recorded items.
681         Solution: caching/invalidation of DFS (filtering) results.
682
683         Also fixed "truncate selected record range on mode change" glitch.
684
685         * inspector/front-end/TimelinePanel.js:
686         (WebInspector.TimelinePanel):
687         (WebInspector.TimelinePanel.prototype._scheduleRefresh):
688         Add flag for cache invalidation.
689         * inspector/front-end/TimelinePresentationModel.js:
690         (WebInspector.TimelinePresentationModel.prototype.invalidateFilteredRecords):
691         Added.
692         (WebInspector.TimelinePresentationModel.prototype.filteredRecords):
693         Caching/using cached results.
694
695 2012-09-06  Ilya Tikhonovsky  <loislo@chromium.org>
696
697         Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
698         https://bugs.webkit.org/show_bug.cgi?id=95957
699
700         Reviewed by Yury Semikhatsky.
701
702         Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
703         instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
704         At a later stage, when each type of memory will be counted in MemoryInstrumentation
705         we will build the blocks hierarchy for the front-end automatically.
706
707         * dom/MemoryInstrumentation.cpp:
708         (WebCore):
709         * dom/MemoryInstrumentation.h:
710         (GenericMemoryTypes):
711         (WebCore::MemoryInstrumentation::addRootObject):
712         (WebCore::MemoryObjectInfo::reportObjectInfo):
713         (WebCoreMemoryTypes):
714         * inspector/InspectorMemoryAgent.cpp:
715         (MemoryBlockName):
716         (WebCore):
717         * inspector/MemoryInstrumentationImpl.cpp:
718         (WebCore::MemoryInstrumentationImpl::countObjectSize):
719         * inspector/front-end/NativeMemorySnapshotView.js:
720         (WebInspector.MemoryBlockViewProperties._initialize):
721         * loader/cache/CachedRawResource.cpp:
722         (WebCore::CachedRawResource::reportMemoryUsage):
723         * loader/cache/CachedResource.cpp:
724         (WebCore::CachedResource::reportMemoryUsage):
725         * loader/cache/CachedResourceHandle.cpp:
726         (WebCore::CachedResourceHandleBase::reportMemoryUsage):
727         * platform/SharedBuffer.cpp:
728         (WebCore::SharedBuffer::reportMemoryUsage):
729
730 2012-09-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
731
732         CSS 3 'overflow-wrap' property implementation
733         https://bugs.webkit.org/show_bug.cgi?id=94475
734
735         Reviewed by Ojan Vafai.
736
737         Added 'overflow-wrap' property implementation according to
738         http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
739         The specification declares that 'word-wrap' as a shorthand
740         for the 'overflow-wrap' property. So what was basically done
741         is declaring of new 'overflow-wrap' property and renaming
742         of the internal data structures from 'WordWrap' to 'OverflowWrap'.
743         Both 'overflow-wrap' and 'word-wrap' properties share the same
744         handlers and thus have the same behaviour.
745
746         Test: fast/text/overflow-wrap.html
747
748         * WebCore.order: Rename exported setWordWrap to setOverflowWrap.
749         * css/CSSComputedStyleDeclaration.cpp:  Add CSSPropertyOverflowWrap to computedProperties.
750         (WebCore):
751         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
752         * css/CSSParser.cpp: Validation for the 'overflow-wrap' property.
753         (WebCore::isValidKeywordPropertyAndValue):
754         (WebCore::isKeywordPropertyID):
755         (WebCore::CSSParser::parseValue):
756         * css/CSSPrimitiveValueMappings.h:
757         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
758         (WebCore::CSSPrimitiveValue::operator EOverflowWrap):
759         * css/CSSProperty.cpp:
760         (WebCore::CSSProperty::isInheritedProperty): CSSPropertyOverflowWrap is inherited.
761         * css/CSSPropertyNames.in: Declare new 'overflow-wrap' property.
762         * css/StyleBuilder.cpp: Assign property handler (same as for 'word-wrap').
763         (WebCore::StyleBuilder::StyleBuilder):
764         * css/StyleResolver.cpp:
765         (WebCore::StyleResolver::collectMatchingRulesForList): Renaming.
766         * rendering/RenderTextControl.cpp: Ditto.
767         (WebCore::RenderTextControl::computeLogicalHeight):
768         * rendering/RenderTextControlSingleLine.cpp: Ditto.
769         (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
770         * rendering/style/RenderStyle.cpp: Ditto.
771         (WebCore::RenderStyle::diff):
772         * rendering/style/RenderStyle.h: Ditto.
773         * rendering/style/RenderStyleConstants.h: Ditto.
774         * rendering/style/StyleRareInheritedData.cpp: Ditto.
775         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
776         (WebCore::StyleRareInheritedData::operator==):
777         * rendering/style/StyleRareInheritedData.h: Ditto.
778         (StyleRareInheritedData):
779
780 2012-09-06  Arvid Nilsson  <anilsson@rim.com>
781
782         [BlackBerry] Always log shader compilation failure
783         https://bugs.webkit.org/show_bug.cgi?id=95948
784
785         Reviewed by George Staikos.
786
787         Also add shader source to the logs. In addition, don't bail on the
788         first failure, run through all shaders so we get a complete set of
789         logs.
790
791         No new tests: no change in functionality.
792
793         * platform/graphics/blackberry/LayerRenderer.cpp:
794         (WebCore::LayerRenderer::loadShader):
795         (WebCore::LayerRenderer::initializeSharedGLObjects):
796
797 2012-09-06  Patrick Gansterer  <paroga@webkit.org>
798
799         Remove String::operator+=() from windows platform code
800         https://bugs.webkit.org/show_bug.cgi?id=95904
801
802         Reviewed by Benjamin Poulain.
803
804         Use StringBuilder and operator+() to concatenate strings instead of operator+=().
805
806         * platform/win/ClipboardWin.cpp:
807         (WebCore::filesystemPathFromUrlOrTitle):
808
809 2012-09-06  Keishi Hattori  <keishi@webkit.org>
810
811         Refactor CalendarPicker to not use global variables.
812         https://bugs.webkit.org/show_bug.cgi?id=95830
813
814         Reviewed by Kent Tamura.
815
816         Introduce CalendarPicker so we can have multiple Pickers in one page
817         popup in the future.
818
819         No new tests. No behavior change.
820
821         * Resources/pagepopups/calendarPicker.js:
822         (initialize):
823         (resetMain):
824         (openCalendarPicker):
825         (CalendarPicker):
826         (CalendarPicker.prototype._layout):
827         (CalendarPicker.prototype.handleToday):
828         (CalendarPicker.prototype.handleClear):
829         (CalendarPicker.prototype.fixWindowSize):
830         (CalendarPicker.prototype._layoutButtons):
831         (YearMonthController):
832         (YearMonthController.prototype.attachTo):
833         (YearMonthController.prototype._redraw):
834         (YearMonthController.prototype._handleYearMonthChange):
835         (YearMonthController.prototype.moveRelatively):
836         (DaysTable):
837         (DaysTable.prototype.attachTo):
838         (CalendarPicker.prototype.stepMismatch):
839         (CalendarPicker.prototype.outOfRange):
840         (CalendarPicker.prototype.isValidDate):
841         (DaysTable.prototype._renderMonth):
842         (DaysTable.prototype._navigateToMonth):
843         (DaysTable.prototype._maybeSetPreviousMonth):
844         (DaysTable.prototype._maybeSetNextMonth):
845         (DaysTable.prototype._handleDayClick):
846         (DaysTable.prototype._handleKey):
847         (CalendarPicker.prototype._handleBodyKeyDown):
848         * Resources/pagepopups/colorSuggestionPicker.js:
849         (ColorPicker):
850         (ColorPicker.prototype._layout):
851         (ColorPicker.prototype._handleKeyDown):
852         (ColorPicker.prototype._handleSwatchClick):
853         * Resources/pagepopups/pickerCommon.js:
854         (Picker):
855         (Picker.prototype.submitValue):
856         (Picker.prototype.handleCancel):
857         (Picker.prototype.chooseOtherColor):
858
859 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
860
861         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
862         https://bugs.webkit.org/show_bug.cgi?id=95965
863
864         Reviewed by Tor Arne Vestbø.
865
866         Moved all ANGLE build rules from here to Source/Thirty/ANGLE and
867         instead depend on the new library with a simple WEBKIT += ANGLE.
868
869         * DerivedSources.pri:
870         * Target.pri:
871         * platform/graphics/ANGLEWebKitBridge.h: Simplify the include statement
872         for the internal shader compiler API, aligned with the other platforms.
873
874 2012-09-06  Kangil Han  <kangil.han@samsung.com>
875
876         [EFL] Keep placeholder text visible until first input from user.
877         https://bugs.webkit.org/show_bug.cgi?id=95851
878
879         Reviewed by Gyuyoung Kim.
880
881         Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
882         Therefore, this patch enabled it.
883
884         * platform/efl/RenderThemeEfl.h:
885         (WebCore::RenderThemeEfl::shouldShowPlaceholderWhenFocused):
886
887 2012-09-06  Elliott Sprehn  <esprehn@chromium.org>
888
889         Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive
890         https://bugs.webkit.org/show_bug.cgi?id=95519
891
892         Reviewed by Adam Barth.
893
894         Add new V8DependentRetained that allows keeping a v8::Object alive as long as another
895         v8::Object is alive. This is useful for keeping callbacks attached to wrappers without
896         keeping strong references to v8::Objects in the C++ side which can result in leaks
897         when cycles are created.
898
899         No new tests needed, this will be used to fix MutationObservers which will have tests.
900
901         * WebCore.gypi:
902         * bindings/v8/V8DependentRetained.h: Added.
903         (WebCore):
904         (V8DependentRetained):
905         (WebCore::V8DependentRetained::V8DependentRetained):
906         (WebCore::V8DependentRetained::~V8DependentRetained):
907         (WebCore::V8DependentRetained::get): Gets the v8::Object value.
908         (WebCore::V8DependentRetained::isEmpty): Checks if the value is still alive.
909         (WebCore::V8DependentRetained::createPropertyName):
910         (WebCore::V8DependentRetained::ownerWeakCallback): Clear the value when the owner is released.
911         (WebCore::V8DependentRetained::valueWeakCallback):
912         (WebCore::V8DependentRetained::release):
913         * bindings/v8/V8HiddenPropertyName.cpp:
914         (WebCore::V8HiddenPropertyName::hiddenReferenceName): Modified to allow creating hidden String or Symbol names.
915         * bindings/v8/V8HiddenPropertyName.h:
916         (V8HiddenPropertyName):
917         * bindings/v8/V8PerIsolateData.cpp:
918         (WebCore::V8PerIsolateData::V8PerIsolateData):
919         * bindings/v8/V8PerIsolateData.h:
920         (WebCore::V8PerIsolateData::nextDependentRetainedId): Returns the next available hidden property index.
921         (V8PerIsolateData):
922
923 2012-09-06  Otto Derek Cheung  <otcheung@rim.com>
924
925         [BlackBerry] Removing String operator += uses in Cookie Files
926         https://bugs.webkit.org/show_bug.cgi?id=95884
927
928         Reviewed by Rob Buis.
929
930         Replacing all usages of String operator +=  in the Cookie code because it is being deprecated.
931         String concats are now done using + or StringBuilder.
932
933         PR 203054
934
935         Tested using Browser Test Cookie suite on browsertest01.rim.net/networking/cookies.
936
937         * platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
938         (WebCore::CookieDatabaseBackingStore::upgradeTableIfNeeded):
939         (WebCore::CookieDatabaseBackingStore::invokeOpen):
940         (WebCore::CookieDatabaseBackingStore::invokeRemoveAll):
941         * platform/blackberry/CookieManager.cpp:
942         (WebCore::CookieManager::getRawCookies):
943
944 2012-09-06  Dana Jansens  <danakj@chromium.org>
945
946         [chromium] Add a copy() method to CCRenderPass
947         https://bugs.webkit.org/show_bug.cgi?id=95485
948
949         Reviewed by Adrienne Walker.
950
951         This method allows the ubercomp layer to make a clone of its delegated
952         RenderPasses to insert into the current frame.
953
954         Tests: CCRenderPassTest.copyShouldBeIdenticalExceptIdAndQuads
955
956         * platform/graphics/chromium/cc/CCRenderPass.cpp:
957         (WebCore::CCRenderPass::copy):
958         (WebCore):
959         * platform/graphics/chromium/cc/CCRenderPass.h:
960         (CCRenderPass):
961
962 2012-09-06  Adam Barth  <abarth@chromium.org>
963
964         XMLHttpRequest.open does not need custom bindings
965         https://bugs.webkit.org/show_bug.cgi?id=95903
966
967         Reviewed by Kentaro Hara.
968
969         There doesn't appear to be any reason that XMLHttpRequest.open needs
970         custom bindings now that [Optional] works the way XMLHttpRequest
971         expects.
972
973         * bindings/js/JSXMLHttpRequestCustom.cpp:
974         (WebCore):
975         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
976         * xml/XMLHttpRequest.cpp:
977         (WebCore::XMLHttpRequest::open):
978         (WebCore):
979         (WebCore::XMLHttpRequest::internalOpen):
980         * xml/XMLHttpRequest.h:
981         (XMLHttpRequest):
982         * xml/XMLHttpRequest.idl:
983
984 2012-09-06  Adam Barth  <abarth@chromium.org>
985
986         Three XSLTProcessor functions don't need to be [Custom]
987         https://bugs.webkit.org/show_bug.cgi?id=95899
988
989         Reviewed by Kentaro Hara.
990
991         These functions are marked [Custom] because they predate our
992         improvements to [Optional]. Now that we have
993         [Optional=DefaultIsUndefined], we can autogenerate these functions.
994
995         There is a (slight!) difference in behavior. Now, in the case of a type
996         error, we return null instead of undefined. This change is unlikely to
997         cause compatibility problems because the vast majority of folks will
998         pass the correct arguments, and, in the few cases where folks pass the
999         wrong argument types, null and undefined will likely work similarly
1000         (e.g., they're both falsy and throw when you try to access properties).
1001
1002         * bindings/js/JSXSLTProcessorCustom.cpp:
1003         * bindings/v8/custom/V8XSLTProcessorCustom.cpp:
1004         * xml/XSLTProcessor.cpp:
1005         (WebCore::XSLTProcessor::transformToDocument):
1006         (WebCore::XSLTProcessor::transformToFragment):
1007         * xml/XSLTProcessor.h:
1008         (WebCore::XSLTProcessor::importStylesheet):
1009         * xml/XSLTProcessor.idl:
1010
1011 2012-09-06  Patrick Gansterer  <paroga@webkit.org>
1012
1013         Remove String::operator+=() from plugin code
1014         https://bugs.webkit.org/show_bug.cgi?id=95896
1015
1016         Reviewed by Adam Barth.
1017
1018         Use operator+() to concatenate strings instead of operator+=().
1019
1020         * plugins/PluginView.cpp:
1021         (WebCore::parseRFC822HeaderFields):
1022
1023 2012-09-06  Patrick Gansterer  <paroga@webkit.org>
1024
1025         More fixes for String::operator+=() in Debug mode
1026         https://bugs.webkit.org/show_bug.cgi?id=95888
1027
1028         Reviewed by Adam Barth.
1029
1030         Use StringBuilder to concatenate strings instead of operator+=().
1031
1032         * dom/Element.cpp:
1033         (WebCore::Element::formatForDebugger):
1034         * dom/Node.cpp:
1035         (WebCore::appendAttributeDesc):
1036         (WebCore::Node::showNode):
1037         (WebCore::traverseTreeAndMark):
1038         (WebCore::Node::formatForDebugger):
1039         * dom/Position.cpp:
1040         (WebCore::Position::formatForDebugger):
1041         * dom/Range.cpp:
1042         (WebCore):
1043         (WebCore::Range::formatForDebugger):
1044         * dom/Text.cpp:
1045         (WebCore::Text::formatForDebugger):
1046         * editing/VisibleSelection.cpp:
1047         (WebCore::VisibleSelection::formatForDebugger):
1048
1049 2012-09-04  Vsevolod Vlasov  <vsevik@chromium.org>
1050
1051         Web Inspector: Fix inconsistencies in NetworkUISourceCodeProvider implementation.
1052         https://bugs.webkit.org/show_bug.cgi?id=95752
1053
1054         Reviewed by Alexander Pavlov.
1055
1056         NetworkUISourceCodeProvider does not receive ResourceAdded event until resource is finished anymore.
1057         StylesSourceMapping now listens for workspace event instead of being called directly by NetworkUISourceCodeProvider.
1058         StylesSourceMapping is now created from inspector.js.
1059         ProjectDidReset event introduced instead of setTimeout hacks in mappings.
1060
1061         * inspector/front-end/NetworkUISourceCodeProvider.js:
1062         (WebInspector.NetworkUISourceCodeProvider):
1063         (WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
1064         (WebInspector.NetworkUISourceCodeProvider.prototype._projectWillReset):
1065         (WebInspector.NetworkUISourceCodeProvider.prototype._projectDidReset):
1066         * inspector/front-end/ResourceTreeModel.js:
1067         (WebInspector.ResourceTreeModel):
1068         (WebInspector.ResourceTreeModel.prototype._onRequestFinished):
1069         * inspector/front-end/ScriptSnippetModel.js:
1070         (WebInspector.ScriptSnippetModel):
1071         (WebInspector.ScriptSnippetModel.prototype._projectWillReset):
1072         (WebInspector.ScriptSnippetModel.prototype._projectDidReset):
1073         * inspector/front-end/StylesSourceMapping.js:
1074         (WebInspector.StylesSourceMapping):
1075         (WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
1076         (WebInspector.StylesSourceMapping.prototype._addUISourceCode):
1077         (WebInspector.StylesSourceMapping.prototype._reset):
1078         * inspector/front-end/Workspace.js:
1079         (WebInspector.WorkspaceController.prototype._mainFrameNavigated):
1080         (WebInspector.Project.prototype.reset):
1081         * inspector/front-end/inspector.js:
1082
1083 2012-09-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1084
1085         Unreviewed, rolling out r127700.
1086         http://trac.webkit.org/changeset/127700
1087         https://bugs.webkit.org/show_bug.cgi?id=95941
1088
1089         Breaks inspector closure compilation, uses not defined
1090         variables. (Requested by vsevik on #webkit).
1091
1092         * dom/NamedFlowCollection.cpp:
1093         (WebCore::NamedFlowCollection::ensureFlowWithName):
1094         (WebCore::NamedFlowCollection::discardNamedFlow):
1095         * inspector/Inspector.json:
1096         * inspector/InspectorCSSAgent.cpp:
1097         (WebCore::InspectorCSSAgent::reset):
1098         (WebCore::InspectorCSSAgent::didCreateNamedFlow):
1099         (WebCore::InspectorCSSAgent::didRemoveNamedFlow):
1100         (WebCore::InspectorCSSAgent::getNamedFlowCollection):
1101         (WebCore::InspectorCSSAgent::getFlowByName):
1102         (WebCore):
1103         * inspector/InspectorCSSAgent.h:
1104         (WebCore):
1105         (InspectorCSSAgent):
1106         * inspector/InspectorInstrumentation.cpp:
1107         (WebCore):
1108         (WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
1109         (WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):
1110         * inspector/InspectorInstrumentation.h:
1111         (InspectorInstrumentation):
1112         (WebCore::InspectorInstrumentation::didCreateNamedFlow):
1113         (WebCore::InspectorInstrumentation::didRemoveNamedFlow):
1114         * inspector/front-end/CSSStyleModel.js:
1115         (WebInspector.CSSStyleModel):
1116         (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
1117         (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
1118         (WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
1119         (WebInspector.CSSStyleModel.prototype._namedFlowCreated):
1120         (WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
1121         (WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
1122         (WebInspector.CSSDispatcher.prototype.namedFlowCreated):
1123         (WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
1124         (WebInspector.NamedFlow):
1125         (WebInspector.NamedFlow.parsePayloadArray):
1126         * rendering/RenderNamedFlowThread.cpp:
1127         (WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
1128
1129 2012-09-06  Adam Barth  <abarth@chromium.org>
1130
1131         [V8] V8HTMLDocument has two out-of-style function names
1132         https://bugs.webkit.org/show_bug.cgi?id=95893
1133
1134         Reviewed by Kentaro Hara.
1135
1136         Just a simple style cleanup.
1137
1138         * bindings/scripts/CodeGeneratorV8.pm:
1139         (GenerateHeader):
1140         * bindings/v8/V8DOMWindowShell.cpp:
1141         (WebCore::getter):
1142         * bindings/v8/V8DOMWrapper.cpp:
1143         (WebCore::V8DOMWrapper::instantiateV8Object):
1144         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
1145         (WebCore::V8HTMLDocument::wrapInShadowObject):
1146         (WebCore::V8HTMLDocument::getNamedProperty):
1147
1148 2012-09-05  Andrei Poenaru  <poenaru@adobe.com>
1149
1150         Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
1151         https://bugs.webkit.org/show_bug.cgi?id=93443
1152
1153         Reviewed by Alexander Pavlov.
1154
1155         Added "regionLayoutUpdate" event to the protocol.
1156
1157         Removed "getFlowByName" from protocol.
1158
1159         The front-end keeps in sync the requested Named Flow Collections.
1160
1161         Modified existing test: inspector/styles/protocol-css-regions-commands.html
1162
1163         * dom/NamedFlowCollection.cpp:
1164         (WebCore::NamedFlowCollection::ensureFlowWithName):
1165         (WebCore::NamedFlowCollection::discardNamedFlow):
1166         * inspector/Inspector.json:
1167         * inspector/InspectorCSSAgent.cpp:
1168         (UpdateRegionLayoutTask):
1169         (WebCore::UpdateRegionLayoutTask::reset):
1170         (WebCore):
1171         (WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
1172         (WebCore::UpdateRegionLayoutTask::scheduleFor):
1173         (WebCore::UpdateRegionLayoutTask::onTimer):
1174         (WebCore::InspectorCSSAgent::reset):
1175         (WebCore::InspectorCSSAgent::didCreateNamedFlow):
1176         (WebCore::InspectorCSSAgent::willRemoveNamedFlow):
1177         (WebCore::InspectorCSSAgent::didUpdateRegionLayout):
1178         (WebCore::InspectorCSSAgent::regionLayoutUpdated):
1179         (WebCore::InspectorCSSAgent::getNamedFlowCollection):
1180         (WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
1181         * inspector/InspectorCSSAgent.h:
1182         (WebCore):
1183         (InspectorCSSAgent):
1184         * inspector/InspectorInstrumentation.cpp:
1185         (WebCore):
1186         (WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
1187         (WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
1188         (WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
1189         * inspector/InspectorInstrumentation.h:
1190         (InspectorInstrumentation):
1191         (WebCore::InspectorInstrumentation::didCreateNamedFlow):
1192         (WebCore::InspectorInstrumentation::willRemoveNamedFlow):
1193         (WebCore):
1194         (WebCore::InspectorInstrumentation::didUpdateRegionLayout):
1195         * inspector/front-end/CSSStyleModel.js:
1196         (WebInspector.CSSStyleModel):
1197         (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
1198         (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
1199         (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
1200         (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
1201         (WebInspector.CSSStyleModel.prototype._namedFlowCreated):
1202         (WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
1203         (WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
1204         (WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
1205         (WebInspector.CSSDispatcher.prototype.namedFlowCreated):
1206         (WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
1207         (WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
1208         (WebInspector.NamedFlow):
1209         (WebInspector.NamedFlowCollection):
1210         (WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
1211         (WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
1212         (WebInspector.NamedFlowCollection.prototype.flowByName):
1213         * rendering/RenderNamedFlowThread.cpp:
1214         (WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
1215
1216 2012-09-05  Dana Jansens  <danakj@chromium.org>
1217
1218         [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
1219         https://bugs.webkit.org/show_bug.cgi?id=95374
1220
1221         Reviewed by Adrienne Walker.
1222
1223         The ubercomp layer will hold a RenderPass full of DrawQuads, and needs
1224         to add quads to the current frame in appendQuads(). It will do this by
1225         copying the quads it has in its RenderPass into the frame's RenderPass.
1226
1227         These methods allows it to make a clone of its quads.
1228
1229         Test: CCDrawQuadTest.copySharedQuadState
1230               CCDrawQuadTest.copyCheckerboardDrawQuad
1231               CCDrawQuadTest.copyDebugBorderDrawQuad
1232               CCDrawQuadTest.copyIOSurfaceDrawQuad
1233               CCDrawQuadTest.copyRenderPassDrawQuad
1234               CCDrawQuadTest.copySolidColorDrawQuad
1235               CCDrawQuadTest.copyStreamVideoDrawQuad
1236               CCDrawQuadTest.copyTextureDrawQuad
1237               CCDrawQuadTest.copyTileDrawQuadcopy
1238               CCDrawQuadTest.copyYUVVideoDrawQuad
1239
1240         * platform/graphics/chromium/cc/CCDrawQuad.cpp:
1241         (WebCore::CCDrawQuad::copy):
1242         (WebCore):
1243         * platform/graphics/chromium/cc/CCDrawQuad.h:
1244         (CCDrawQuad):
1245         * platform/graphics/chromium/cc/CCSharedQuadState.cpp:
1246         (WebCore::CCSharedQuadState::copy):
1247         (WebCore):
1248         * platform/graphics/chromium/cc/CCSharedQuadState.h:
1249         (CCSharedQuadState):
1250
1251 2012-09-05  Tim Horton  <timothy_horton@apple.com>
1252
1253         Unreviewed; revert a change to ScrollingTreeNodeMac which accidentally
1254         slipped into http://trac.webkit.org/changeset/127474.
1255
1256         This change will be properly landed shortly as part of
1257         https://bugs.webkit.org/show_bug.cgi?id=93898.
1258
1259         * page/scrolling/mac/ScrollingTreeNodeMac.mm:
1260         (WebCore::ScrollingTreeNodeMac::update):
1261
1262 2012-09-05  Nate Chapin  <japhet@chromium.org>
1263
1264         Remove duplicate error() impls in CachedResource subclasses
1265         https://bugs.webkit.org/show_bug.cgi?id=81161
1266
1267         Reviewed by Antti Koivisto.
1268
1269         No new tests, refactor only.
1270
1271         * loader/cache/CachedCSSStyleSheet.cpp:
1272         * loader/cache/CachedCSSStyleSheet.h:
1273         * loader/cache/CachedFont.cpp:
1274         * loader/cache/CachedFont.h:
1275         * loader/cache/CachedImage.cpp:
1276         * loader/cache/CachedResource.h: Make checkNotify()
1277              virtual, so the right checkNotify() gets called in error().
1278         * loader/cache/CachedScript.cpp:
1279         * loader/cache/CachedScript.h:
1280         * loader/cache/CachedXSLStyleSheet.cpp:
1281         * loader/cache/CachedXSLStyleSheet.h:
1282
1283 2012-09-05  James Robinson  <jamesr@chromium.org>
1284
1285         Unreviewed chromium windows build fix.
1286
1287         Some of the rules in webcore_remaining only apply to files under WebCore/platform/. Since r127687 moved all such
1288         files from the webcore_files variable to webcore_platform_files, these rules have to be applied to
1289         webcore_platform instead. This also means that these files link into webcore_platform instead of
1290         webcore_remaining, which makes a lot more sense, and we can delete several redundant rules.
1291
1292         * WebCore.gyp/WebCore.gyp:
1293
1294 2012-09-05  Nate Chapin  <japhet@chromium.org>
1295
1296         [chromium] Some SubstituteData loads broken after r121912
1297         https://bugs.webkit.org/show_bug.cgi?id=91685
1298
1299         Reviewed by Adam Barth.
1300
1301         Test: WebFrameTest.ReplaceNavigationAfterHistoryNavigation in chromium's webkit_unit_tests.
1302
1303         * loader/DocumentLoader.cpp:
1304         (WebCore::DocumentLoader::commitData): receivedFirstData() should be called exactly once per load,
1305             on the first commit. I had mistakely assumed in r121912 that isReplacing() was true only for multipart
1306             loads, and only after the first commit (chromium uses it for some SubstituteData loads to ensure the error page
1307             replaces the failed load). We need to check whether we are loading multipart content before assuming isReplacing()
1308             will tell us what we need to know.
1309
1310 2012-09-05  James Robinson  <jamesr@chromium.org>
1311
1312         [chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
1313         https://bugs.webkit.org/show_bug.cgi?id=95876
1314
1315         Reviewed by Tony Chang.
1316
1317         This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
1318         path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.
1319
1320         * WebCore.gyp/WebCore.gyp:
1321         * WebCore.gypi:
1322
1323 2012-09-05  Joshua Bell  <jsbell@chromium.org>
1324
1325         IndexedDB: Large integer versions not persisted correctly
1326         https://bugs.webkit.org/show_bug.cgi?id=95873
1327
1328         Reviewed by Tony Chang.
1329
1330         Correctly encode AND decode integer versions numbers as VarInts.
1331
1332         Test: storage/indexeddb/intversion-encoding.html
1333
1334         * Modules/indexeddb/IDBLevelDBBackingStore.cpp:
1335         (WebCore::getVarInt):
1336         (WebCore):
1337         (WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
1338
1339 2012-09-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1340
1341         Unreviewed, rolling out r127596.
1342         http://trac.webkit.org/changeset/127596
1343         https://bugs.webkit.org/show_bug.cgi?id=95928
1344
1345         newly added tests are failing (Requested by bashi1 on
1346         #webkit).
1347
1348         * rendering/RenderBox.cpp:
1349         (WebCore::RenderBox::computePositionedLogicalWidth):
1350         * rendering/RenderRegion.cpp:
1351         * rendering/RenderRegion.h:
1352         (RenderRegion):
1353
1354 2012-09-05  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1355
1356         Build failure with accelerated compositing disabled
1357         https://bugs.webkit.org/show_bug.cgi?id=95872
1358
1359         Reviewed by James Robinson.
1360
1361         Define DrawingBuffer::markContextChanged even when accelerated
1362         compositing is not used.
1363
1364         No functional change, so no new tests.
1365
1366         * platform/graphics/gpu/DrawingBuffer.h:
1367         (WebCore::DrawingBuffer::markContentsChanged):
1368         (DrawingBuffer):
1369
1370 2012-09-05  Michelangelo De Simone  <michelangelo@webkit.org>
1371
1372         Parse the array() function for custom filters
1373         https://bugs.webkit.org/show_bug.cgi?id=94226
1374
1375         Reviewed by Dirk Schulze.
1376
1377         The patch adds the support for the array() function parsing;
1378         according to the specs this function - to be used within custom
1379         filters - accepts number (float) values. This patch parses array()
1380         arguments using comma as separator: the spec will be updated
1381         accordingly shortly.
1382
1383         * GNUmakefile.list.am:
1384         * Target.pri:
1385         * WebCore.gypi:
1386         * WebCore.vcproj/WebCore.vcproj:
1387         * WebCore.xcodeproj/project.pbxproj:
1388         * css/CSSParser.cpp:
1389         (WebCore::CSSParser::parseCustomFilterArrayFunction): New method to
1390         parse the content of array() function.
1391         (WebCore):
1392         (WebCore::CSSParser::parseCustomFilter): parseCustomFilterArrayFunction is
1393         called whenever a "array(" function is encountered.
1394         * css/CSSParser.h:
1395         (WebCore):
1396         * css/CSSValue.cpp:
1397         (WebCore::CSSValue::reportMemoryUsage):
1398         (WebCore::CSSValue::cssText):
1399         (WebCore::CSSValue::destroy):
1400         (WebCore::CSSValue::cloneForCSSOM):
1401         * css/CSSValue.h:
1402         (WebCore::CSSValue::isWebKitCSSArrayFunctionValue):
1403         * css/WebKitCSSArrayFunctionValue.cpp: Added.
1404         (WebCore):
1405         (WebCore::WebKitCSSArrayFunctionValue::WebKitCSSArrayFunctionValue):
1406         (WebCore::WebKitCSSArrayFunctionValue::customCssText):
1407         (WebCore::WebKitCSSArrayFunctionValue::cloneForCSSOM):
1408         (WebCore::WebKitCSSArrayFunctionValue::reportDescendantMemoryUsage):
1409         * css/WebKitCSSArrayFunctionValue.h: Added.
1410         (WebCore):
1411         (WebKitCSSArrayFunctionValue):
1412         (WebCore::WebKitCSSArrayFunctionValue::create):
1413
1414 2012-09-05  Matt Falkenhagen  <falken@chromium.org>
1415
1416         Vertically center non-anchored <dialog> elements
1417         https://bugs.webkit.org/show_bug.cgi?id=90670
1418
1419         Reviewed by Ojan Vafai.
1420
1421         This adjusts the static default position of non-anchored
1422         dialog elements so they are vertically centered in or at the top of
1423         the viewport, as per the spec.
1424
1425         The approach is to add a RenderDialog class whose layout()
1426         function adjusts the position after normal RenderBlock::layout runs.
1427
1428         Test: fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html
1429
1430         * CMakeLists.txt:
1431         * GNUmakefile.list.am:
1432         * Target.pri:
1433         * WebCore.gypi:
1434         * WebCore.xcodeproj/project.pbxproj:
1435         * html/HTMLDialogElement.cpp:
1436         (WebCore::HTMLDialogElement::createRenderer):
1437         (WebCore):
1438         * html/HTMLDialogElement.h:
1439         (HTMLDialogElement):
1440         * rendering/RenderBox.cpp:
1441         (WebCore::RenderBox::mapAbsoluteToLocalPoint): Remove assertion since now absoluteToLocal is called during layout.
1442         * rendering/RenderBoxModelObject.cpp:
1443         (WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint): Ditto.
1444         * rendering/RenderDialog.cpp: Added.
1445         (WebCore):
1446         (WebCore::RenderDialog::layout): Compute the desired top position in the absolute coordinate system, and then set top to the
1447         corresponding local coordinate.
1448         * rendering/RenderDialog.h: Added.
1449         (WebCore):
1450         (RenderDialog):
1451         (WebCore::RenderDialog::RenderDialog):
1452         (WebCore::RenderDialog::~RenderDialog):
1453         (WebCore::RenderDialog::renderName):
1454         * rendering/RenderObject.h:
1455         (RenderObject):
1456         (WebCore::RenderObject::isDialog):
1457         * rendering/RenderingAllInOne.cpp:
1458
1459 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
1460
1461         Unreviewed, rolling out r127612, r127660, and r127664.
1462         http://trac.webkit.org/changeset/127612
1463         http://trac.webkit.org/changeset/127660
1464         http://trac.webkit.org/changeset/127664
1465         https://bugs.webkit.org/show_bug.cgi?id=95920
1466
1467         * CMakeLists.txt:
1468         * GNUmakefile.list.am:
1469         * Modules/mediastream/RTCErrorCallback.h:
1470         (WebCore):
1471         (RTCErrorCallback):
1472         * Modules/mediastream/RTCErrorCallback.idl:
1473         * Modules/mediastream/RTCPeerConnection.cpp:
1474         (WebCore::RTCPeerConnection::createOffer):
1475         * Modules/mediastream/RTCPeerConnection.h:
1476         (WebCore):
1477         (RTCPeerConnection):
1478         * Modules/mediastream/RTCPeerConnection.idl:
1479         * Modules/mediastream/RTCSessionDescriptionCallback.h:
1480         (WebCore):
1481         (RTCSessionDescriptionCallback):
1482         * Modules/mediastream/RTCSessionDescriptionCallback.idl:
1483         * Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
1484         (WebCore::RTCSessionDescriptionRequestImpl::create):
1485         (WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
1486         (WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
1487         (WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
1488         (WebCore::RTCSessionDescriptionRequestImpl::clear):
1489         * Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
1490         (RTCSessionDescriptionRequestImpl):
1491         * Modules/mediastream/RTCVoidRequestImpl.cpp: Removed.
1492         * Modules/mediastream/RTCVoidRequestImpl.h: Removed.
1493         * WebCore.gypi:
1494         * platform/chromium/support/WebRTCVoidRequest.cpp: Removed.
1495         * platform/mediastream/RTCPeerConnectionHandler.cpp:
1496         (RTCPeerConnectionHandlerDummy):
1497         (WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):
1498         * platform/mediastream/RTCPeerConnectionHandler.h:
1499         (WebCore):
1500         (WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):
1501         (RTCPeerConnectionHandler):
1502         (WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):
1503         * platform/mediastream/RTCVoidRequest.h: Removed.
1504         * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
1505         * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
1506         (RTCPeerConnectionHandlerChromium):
1507
1508 2012-09-05  Victoria Kirst  <vrk@chromium.org>
1509
1510         Add the duration attribute to MediaSource
1511         https://bugs.webkit.org/show_bug.cgi?id=95149
1512
1513         Reviewed by Eric Carlson.
1514
1515         Add support for the duration attribute recently added to the MediaSource spec.
1516         http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration
1517
1518         Test: http/tests/media/media-source/video-media-source-duration-changed.html
1519
1520         * Modules/mediasource/MediaSource.cpp:
1521         (WebCore::MediaSource::duration): Added duration method.
1522         (WebCore):
1523         (WebCore::MediaSource::setDuration): Added duration setter.
1524         * Modules/mediasource/MediaSource.h:
1525         (MediaSource):
1526         * Modules/mediasource/MediaSource.idl:
1527         * platform/graphics/MediaPlayer.cpp:
1528         (WebCore::NullMediaPlayerPrivate::sourceSetDuration): Add empty definition.
1529         (WebCore::MediaPlayer::sourceSetDuration): Forward call to m_private.
1530         (WebCore):
1531         * platform/graphics/MediaPlayer.h:
1532         * platform/graphics/MediaPlayerPrivate.h:
1533         (WebCore::MediaPlayerPrivateInterface::sourceSetDuration): Add empty definition.
1534
1535 2012-09-05  Mihai Parparita  <mihaip@chromium.org>
1536
1537         [Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
1538         https://bugs.webkit.org/show_bug.cgi?id=95865
1539
1540         Reviewed by Darin Fisher.
1541
1542         r55549 made them be runtime-enabled (since the Chromium implementation
1543         was not complete at the time), but they've been enabled by default
1544         since http://crrev.com/41850
1545
1546         * bindings/generic/RuntimeEnabledFeatures.cpp:
1547         (WebCore):
1548         * bindings/generic/RuntimeEnabledFeatures.h:
1549         (RuntimeEnabledFeatures):
1550         * page/History.idl:
1551
1552 2012-09-05  Joshua Bell  <jsbell@chromium.org>
1553
1554         IndexedDB: Integer version lost after first open/close/open cycle
1555         https://bugs.webkit.org/show_bug.cgi?id=95864
1556
1557         Reviewed by Tony Chang.
1558
1559         New backing stores were being created with an old schema version, causing migration
1560         to occur when the backing store was re-opened, which would overwrite valid integer
1561         version metadata. New backing stores should be created with the latest schema version
1562         since no migration is desired.
1563
1564         Test: storage/indexeddb/intversion-persistence.html
1565
1566         * Modules/indexeddb/IDBLevelDBBackingStore.cpp:
1567         (WebCore::setUpMetadata):
1568
1569 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
1570
1571         [Chromium] Unreviewed, build fix attempt after r127660
1572
1573         Make clang happy.
1574
1575         * platform/mediastream/RTCPeerConnectionHandler.cpp:
1576         (WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):
1577         Use ASSERT_UNUSED() to suppress -Wunused-private-field warning
1578
1579 2012-09-05  Patrick Gansterer  <paroga@webkit.org>
1580
1581         Build fix for Windows.
1582
1583         * rendering/RenderThemeWin.cpp: Added missing header include.
1584
1585 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
1586
1587         [Chromium] Unreviewed, build fix attempt on win
1588
1589         r127612 breaks chromium win build.
1590
1591         * WebCore.gypi:
1592         * platform/mediastream/RTCPeerConnectionHandler.cpp:
1593         (WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):
1594         (WebCore):
1595         (WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):
1596         * platform/mediastream/RTCPeerConnectionHandler.h:
1597         (RTCPeerConnectionHandler):
1598
1599 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
1600
1601         [EFL][WK2] Provide implementation for WebProcess functions
1602         https://bugs.webkit.org/show_bug.cgi?id=95857
1603
1604         Reviewed by Kenneth Rohde Christiansen.
1605
1606         Add implementation for getVolumeFreeSizeForPath()
1607         in FileSystem which is required by soup-related
1608         code in WebKit2.
1609
1610         No new tests, no behavior change.
1611
1612         * platform/FileSystem.h:
1613         (WebCore):
1614         * platform/efl/FileSystemEfl.cpp:
1615         (WebCore::getVolumeFreeSizeForPath):
1616         (WebCore):
1617
1618 2012-09-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1619
1620         Unreviewed, rolling out r127635.
1621         http://trac.webkit.org/changeset/127635
1622         https://bugs.webkit.org/show_bug.cgi?id=95905
1623
1624         breaks chromium win and mac build (Requested by bashi1 on
1625         #webkit).
1626
1627         * WebCore.gyp/WebCore.gyp:
1628         * WebCore.gypi:
1629
1630 2012-09-05  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
1631
1632         Make RenderStyle::colorIncludingFallback use private getters
1633         https://bugs.webkit.org/show_bug.cgi?id=95863
1634
1635         Reviewed by Eric Seidel.
1636
1637         For readibility and maintanability reasons, it is better to use getters for
1638         visited* color variables than accessing them directly.
1639
1640         * rendering/style/RenderStyle.cpp:
1641         (WebCore::RenderStyle::colorIncludingFallback):
1642
1643 2012-09-05  Benjamin Poulain  <bpoulain@apple.com>
1644
1645         More fixes for String::operator+=() on Mac
1646         https://bugs.webkit.org/show_bug.cgi?id=95880
1647
1648         Reviewed by Adam Barth.
1649
1650         Followup for r127574, I forgot some use of strings.
1651
1652         * css/StylePropertySet.cpp:
1653         (WebCore::StylePropertySet::getShorthandValue): Use String builder to construct the shorthand.
1654
1655 2012-09-05  James Robinson  <jamesr@chromium.org>
1656
1657         [chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
1658         https://bugs.webkit.org/show_bug.cgi?id=95876
1659
1660         Reviewed by Tony Chang.
1661
1662         This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
1663         path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.
1664
1665         * WebCore.gyp/WebCore.gyp:
1666         * WebCore.gypi:
1667
1668 2012-09-05  James Robinson  <jamesr@chromium.org>
1669
1670         Unreviewed, rolling out r127629.
1671         http://trac.webkit.org/changeset/127629
1672         https://bugs.webkit.org/show_bug.cgi?id=95876
1673
1674         Broke build
1675
1676         * WebCore.gyp/WebCore.gyp:
1677         * WebCore.gypi:
1678
1679 2012-09-05  James Robinson  <jamesr@chromium.org>
1680
1681         [chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
1682         https://bugs.webkit.org/show_bug.cgi?id=95876
1683
1684         Reviewed by Tony Chang.
1685
1686         This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
1687         path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.
1688
1689         * WebCore.gyp/WebCore.gyp:
1690         * WebCore.gypi:
1691
1692 2012-09-05  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1693
1694         [EFL] Slider progress bar goes crazy with negative ranges
1695         https://bugs.webkit.org/show_bug.cgi?id=95753
1696
1697         Reviewed by Kenneth Rohde Christiansen.
1698
1699         Now the calculation of what the current value represents in terms
1700         of progress (from 0 to 1) is correctly done.
1701
1702         Test: fast/forms/range/input-range-progress-indicator.html
1703
1704         * platform/efl/RenderThemeEfl.cpp:
1705         (WebCore::RenderThemeEfl::paintThemePart):
1706
1707 2012-09-05  Mark Pilgrim  <pilgrim@chromium.org>
1708
1709         [Chromium] Remove getRenderStyleForStrike from PlatformSupport
1710         https://bugs.webkit.org/show_bug.cgi?id=95363
1711
1712         Reviewed by Adam Barth.
1713
1714         Part of a refactoring series. See tracking bug 82948.
1715
1716         * platform/chromium/PlatformSupport.h:
1717         (PlatformSupport):
1718         * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
1719         (WebCore::FontPlatformData::operator==):
1720         (WebCore::FontPlatformData::getRenderStyleForStrike):
1721         (WebCore):
1722         (WebCore::FontPlatformData::querySystemForRenderStyle):
1723         * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
1724         (FontPlatformData):
1725
1726 2012-09-05  Sami Kyostila  <skyostil@google.com>
1727
1728         Enable/disable composited scrolling based on overflow
1729         https://bugs.webkit.org/show_bug.cgi?id=95323
1730
1731         Reviewed by Simon Fraser.
1732
1733         When an overflow:{auto,overlay} and -webkit-overflow-scrolling:touch
1734         element gains or loses overflow, we should correspondingly enable and
1735         disable composited scrolling depending on whether the element can be
1736         scrolled or not.
1737
1738         The previous logic in RenderLayer::usesCompositedScrolling() already
1739         checked for actual overflow, but we also need to recompute the
1740         compositing requirements when the amount of overflow changes during
1741         layout. Additionally, layers using composited scrolling are marked as
1742         self-painting to ensure they are always promoted to composited layers
1743         when needed.
1744
1745         Test: compositing/overflow/overflow-auto-with-touch-toggle.html
1746
1747         Note that the behavior for maintaining a stacking context even without
1748         the presense of overflow is covered by platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html.
1749
1750         * rendering/RenderLayer.cpp:
1751         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
1752         (WebCore::RenderLayer::shouldBeSelfPaintingLayer):
1753
1754 2012-09-05  Mike Fenton  <mifenton@rim.com>
1755
1756         [BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
1757         https://bugs.webkit.org/show_bug.cgi?id=95773
1758
1759         Reviewed by Rob Buis.
1760
1761         Properly initialize the passed variables even
1762         though we haven't implemented the modifier state
1763         to ensure the values are deterministic.
1764
1765         * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
1766         (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
1767
1768 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
1769
1770         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
1771         https://bugs.webkit.org/show_bug.cgi?id=95839
1772
1773         Reviewed by Adam Barth.
1774
1775         As well as adding the local/remote descriptions stuff, I removed the source attribute from
1776         RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.
1777
1778         Tests: fast/mediastream/RTCPeerConnection-localDescription.html
1779                fast/mediastream/RTCPeerConnection-remoteDescription.html
1780
1781         * CMakeLists.txt:
1782         * GNUmakefile.list.am:
1783         * Modules/mediastream/RTCErrorCallback.h:
1784         (RTCErrorCallback):
1785         * Modules/mediastream/RTCErrorCallback.idl:
1786         * Modules/mediastream/RTCPeerConnection.cpp:
1787         (WebCore::RTCPeerConnection::createOffer):
1788         (WebCore::RTCPeerConnection::setLocalDescription):
1789         (WebCore):
1790         (WebCore::RTCPeerConnection::localDescription):
1791         (WebCore::RTCPeerConnection::setRemoteDescription):
1792         (WebCore::RTCPeerConnection::remoteDescription):
1793         * Modules/mediastream/RTCPeerConnection.h:
1794         (WebCore):
1795         (RTCPeerConnection):
1796         * Modules/mediastream/RTCPeerConnection.idl:
1797         * Modules/mediastream/RTCSessionDescriptionCallback.h:
1798         (RTCSessionDescriptionCallback):
1799         * Modules/mediastream/RTCSessionDescriptionCallback.idl:
1800         * Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
1801         (WebCore::RTCSessionDescriptionRequestImpl::create):
1802         (WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
1803         (WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
1804         (WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
1805         (WebCore::RTCSessionDescriptionRequestImpl::clear):
1806         * Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
1807         (RTCSessionDescriptionRequestImpl):
1808         * Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.
1809         (WebCore):
1810         (WebCore::RTCVoidRequestImpl::create):
1811         (WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
1812         (WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
1813         (WebCore::RTCVoidRequestImpl::requestSucceeded):
1814         (WebCore::RTCVoidRequestImpl::requestFailed):
1815         (WebCore::RTCVoidRequestImpl::stop):
1816         (WebCore::RTCVoidRequestImpl::clear):
1817         * Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.
1818         (WebCore):
1819         (RTCVoidRequestImpl):
1820         * WebCore.gypi:
1821         * platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
1822         (WebKit):
1823         (WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
1824         (WebKit::WebRTCVoidRequest::assign):
1825         (WebKit::WebRTCVoidRequest::reset):
1826         (WebKit::WebRTCVoidRequest::requestSucceeded):
1827         (WebKit::WebRTCVoidRequest::requestFailed):
1828         (ExtraDataContainer):
1829         (WebKit::ExtraDataContainer::ExtraDataContainer):
1830         (WebKit::ExtraDataContainer::extraData):
1831         (WebKit::WebRTCVoidRequest::extraData):
1832         (WebKit::WebRTCVoidRequest::setExtraData):
1833         * platform/mediastream/RTCPeerConnectionHandler.cpp:
1834         (RTCPeerConnectionHandlerDummy):
1835         (WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
1836         (WebCore):
1837         (WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
1838         (WebCore::RTCPeerConnectionHandlerDummy::localDescription):
1839         (WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):
1840         * platform/mediastream/RTCPeerConnectionHandler.h:
1841         (WebCore):
1842         (RTCPeerConnectionHandler):
1843         * platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.
1844         (WebCore):
1845         (RTCVoidRequest):
1846         (ExtraData):
1847         (WebCore::RTCVoidRequest::ExtraData::~ExtraData):
1848         (WebCore::RTCVoidRequest::~RTCVoidRequest):
1849         (WebCore::RTCVoidRequest::extraData):
1850         (WebCore::RTCVoidRequest::setExtraData):
1851         (WebCore::RTCVoidRequest::RTCVoidRequest):
1852         * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
1853         (WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
1854         (WebCore):
1855         (WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
1856         (WebCore::RTCPeerConnectionHandlerChromium::localDescription):
1857         (WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):
1858         * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
1859         (RTCPeerConnectionHandlerChromium):
1860
1861 2012-09-01  Dirk Schulze  <krit@webkit.org>
1862
1863         Use -webkit-clip-path shapes to clip HTML elements
1864         https://bugs.webkit.org/show_bug.cgi?id=95646
1865
1866         Reviewed by Dean Jackson.
1867
1868         -webkit-clip-path creates a new layer for HTML elements now. The border,
1869         background and content gets clipped by the clip path after any filter was
1870         applied.
1871
1872         Tests: css3/masking/clip-path-circle-filter.html
1873                css3/masking/clip-path-circle-overflow.html
1874                css3/masking/clip-path-circle-overflow-hidden.html
1875                css3/masking/clip-path-circle-relative-overflow.html
1876                css3/masking/clip-path-circle.html
1877                css3/masking/clip-path-ellipse.html
1878                css3/masking/clip-path-polygon-evenodd.html
1879                css3/masking/clip-path-polygon-nonzero.html
1880                css3/masking/clip-path-polygon.html
1881                css3/masking/clip-path-rectangle.html
1882
1883         * rendering/RenderBox.h: Create new layer on clip-path.
1884         * rendering/RenderBoxModelObject.h:
1885         (WebCore::RenderBoxModelObject::requiresLayer): Create new layer on clip-path.
1886         * rendering/RenderInline.h:
1887         (WebCore::RenderInline::requiresLayer): Create new layer on clip-path.
1888         * rendering/RenderLayer.cpp: Apply clip-path on context of object.
1889         (WebCore::RenderLayer::paintLayerContents): Create new layer on clip-path.
1890         * rendering/RenderObject.h:
1891         (WebCore::RenderObject::hasClipPath): Indicates that renderer needs to be clipped by clip-path.
1892         * rendering/RenderTableRow.h: Create new layer on clip-path.
1893
1894 2012-09-05  Kangil Han  <kangil.han@samsung.com>
1895
1896         [EFL] Use explicit constructor in RenderThemeEfl.
1897         https://bugs.webkit.org/show_bug.cgi?id=95853
1898
1899         Reviewed by Kentaro Hara.
1900
1901         Added explicit keyword in constructor of RenderThemeEfl in order to avoid implicit type conversion.
1902
1903         * platform/efl/RenderThemeEfl.h:
1904         (RenderThemeEfl):
1905
1906 2012-09-05  Vincent Scheib  <scheib@chromium.org>
1907
1908         webkitPointerLockElement returns null when pointer lock request is pending.
1909         https://bugs.webkit.org/show_bug.cgi?id=91186
1910
1911         Reviewed by Dimitri Glazkov.
1912
1913         Script should wait for a pointerlockchange event before detecting
1914         if it has acquired lock. However, if a script attempted to poll
1915         pointerLockElement it could be confused when lock was still pending.
1916         This change ensures that if lock is not yet acquired then
1917         pointerLockElement will return null.
1918
1919         Test: pointer-lock/pointerlockelement-null-when-pending.html
1920
1921         * dom/Document.cpp:
1922         (WebCore::Document::webkitPointerLockElement):
1923         * page/PointerLockController.cpp:
1924         (WebCore::PointerLockController::requestPointerLock):
1925         (WebCore::PointerLockController::elementRemoved):
1926         (WebCore::PointerLockController::documentDetached):
1927         (WebCore::PointerLockController::lockPending):
1928         (WebCore):
1929         (WebCore::PointerLockController::didAcquirePointerLock):
1930         (WebCore::PointerLockController::didNotAcquirePointerLock):
1931         (WebCore::PointerLockController::didLosePointerLock):
1932         (WebCore::PointerLockController::clearElement):
1933         * page/PointerLockController.h:
1934         (PointerLockController):
1935
1936 2012-09-05  Sami Kyostila  <skyostil@chromium.org>
1937
1938         [chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
1939         https://bugs.webkit.org/show_bug.cgi?id=95679
1940
1941         Reviewed by James Robinson.
1942
1943         Implement scrollable sublayers in ScrollingCoordinatorChromium and introduce a
1944         WebLayerScrollClient which is notified of scroll events on its associated
1945         scroll layer. GraphicsLayerChromium uses it to apply scroll events targeted to
1946         its platform layer to a ScrollableArea, i.e., the RenderLayer corresponding to
1947         the scrollable element.
1948
1949         Tests: GraphicsLayerChromiumTest.applyScrollToScrollableArea
1950                WebLayerTest.ScrollClient
1951
1952         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1953         (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
1954         (WebCore::GraphicsLayerChromium::didScroll):
1955         (WebCore):
1956         * platform/graphics/chromium/GraphicsLayerChromium.h:
1957         (WebCore):
1958         (WebCore::GraphicsLayerChromium::setScrollableArea):
1959         (WebCore::GraphicsLayerChromium::scrollableArea):
1960         (GraphicsLayerChromium):
1961         * platform/graphics/chromium/LayerChromium.cpp:
1962         * platform/graphics/chromium/LayerChromium.h:
1963         (WebKit):
1964         (WebCore):
1965         (WebCore::LayerChromium::setLayerScrollClient):
1966         (LayerChromium):
1967
1968 2012-09-05  Peter Rybin  <peter.rybin@gmail.com>
1969
1970         Web Inspector: CodeGeneratorInspector.py: support asynchronous command implementation
1971         https://bugs.webkit.org/show_bug.cgi?id=95649
1972
1973         Reviewed by Yury Semikhatsky.
1974
1975         Generator is extended to generate callback object for each asynchronous command.
1976
1977         * inspector/CodeGeneratorInspector.py:
1978         (Writer.append_multiline):
1979         (Writer):
1980         (Writer.get_indent):
1981         (TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
1982         (InspectorBackendDispatcherImpl):
1983         (CallbackBase):
1984         (Generator.process_event):
1985         (Generator):
1986         (Generator.EventMethodStructTemplate):
1987         (Generator.EventMethodStructTemplate.append_prolog):
1988         (Generator.EventMethodStructTemplate.append_epilog):
1989         (Generator.process_command):
1990         (Generator.CallbackMethodStructTemplate):
1991         (Generator.CallbackMethodStructTemplate.append_prolog):
1992         (Generator.CallbackMethodStructTemplate.append_epilog):
1993         (Generator.generate_send_method):
1994
1995 2012-09-05  Kevin Ellis  <kevers@chromium.org>
1996
1997         [chromium] Unify size of popup menu for touch and non-touch.
1998         https://bugs.webkit.org/show_bug.cgi?id=95606
1999
2000         Reviewed by Adam Barth.
2001
2002         Use minimum height for popup menus entries regardless of whether the
2003         popup menu is displayed on a touch screen.  Replaces use of touch
2004         padding.  Height meets minimum size requirement for a low error rate
2005         while still looking aesthetic for non-touch.
2006
2007         Covered by existing tests.
2008
2009         * platform/chromium/PopupListBox.cpp:
2010         (WebCore::PopupListBox::getRowHeight):
2011         * platform/chromium/PopupMenuChromium.cpp:
2012         (WebCore):
2013         * platform/chromium/PopupMenuChromium.h:
2014         (PopupMenuChromium):
2015
2016 2012-09-05  Mihnea Ovidenie  <mihnea@adobe.com>
2017
2018         [CSS Regions] Auto width is not working for Regions
2019         https://bugs.webkit.org/show_bug.cgi?id=74135
2020
2021         Reviewed by Julien Chaffraix.
2022
2023         It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
2024         Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
2025         (http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
2026         For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
2027         values (the same for all regions with width auto in a region chain).
2028         When a region has width:auto, the computation of width should be done using normal block/box sizing code, instead of replaced element code.
2029         Contains code contributed by Alexandru Chiculita(achicu@adobe.com).
2030
2031         Tests: fast/regions/autowidth-abspos-regionchain.html
2032                fast/regions/autowidth-abspos.html
2033                fast/regions/autowidth-float.html
2034                fast/regions/autowidth-inlineblock.html
2035                fast/regions/autowidth-nonreplaced-abspos.html
2036                fast/regions/autowidth-nonreplacedblock-normalflow.html
2037                fast/regions/autowidth-normalflow-maxwidth.html
2038                fast/regions/autowidth-normalflow-minmaxwidth.html
2039                fast/regions/autowidth-normalflow-minwidth.html
2040                fast/regions/autowidth-normalflow-vertrl.html
2041                fast/regions/autowidth-normalflow.html
2042
2043         * rendering/RenderBox.cpp: 
2044         (WebCore::RenderBox::computePositionedLogicalWidth): For positioned auto-width regions, skip the code path for replaced elements.
2045         * rendering/RenderRegion.cpp:
2046         (WebCore): Override min/maxPreferredLogicalWidth as they are used in the process of computing width for regions with auto width.
2047         As this moment, a region is still a RenderReplaced element, so this code needs to be revisited when the region will become a RenderBlock.
2048         Also, for min/max-width, we support only <length> values. We will extend support for other values in a following patch.
2049         (WebCore::RenderRegion::minPreferredLogicalWidth):
2050         (WebCore::RenderRegion::maxPreferredLogicalWidth):
2051         * rendering/RenderRegion.h:
2052         (RenderRegion):
2053         Override isInlineBlockOrInlineTable() and shouldComputeSizeAsReplaced() to ensure that computation for width auto follows the normal
2054         block/box sizing code.
2055
2056 2012-09-05  Ilya Tikhonovsky  <loislo@chromium.org>
2057
2058         Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
2059         https://bugs.webkit.org/show_bug.cgi?id=95850
2060
2061         Reviewed by Yury Semikhatsky.
2062
2063         I'd like to extract MemoryObjectTypes into separate classes.
2064         After that we will be able to move core NMI instrumentation code to WTF.
2065
2066         * bindings/js/ScriptWrappable.h:
2067         (WebCore::ScriptWrappable::reportMemoryUsage):
2068         * bindings/v8/DOMDataStore.cpp:
2069         (WebCore::DOMDataStore::reportMemoryUsage):
2070         * bindings/v8/IntrusiveDOMWrapperMap.h:
2071         (WebCore::ChunkedTable::reportMemoryUsage):
2072         * bindings/v8/ScriptWrappable.h:
2073         (WebCore::ScriptWrappable::reportMemoryUsage):
2074         * bindings/v8/V8Binding.cpp:
2075         (WebCore::StringCache::reportMemoryUsage):
2076         * bindings/v8/V8DOMMap.h:
2077         * bindings/v8/V8PerIsolateData.cpp:
2078         (WebCore::V8PerIsolateData::reportMemoryUsage):
2079         * css/CSSAspectRatioValue.cpp:
2080         (WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):
2081         * css/CSSBorderImageSliceValue.cpp:
2082         (WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
2083         * css/CSSCalculationValue.cpp:
2084         (WebCore::CSSCalcValue::reportDescendantMemoryUsage):
2085         * css/CSSCanvasValue.cpp:
2086         (WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
2087         * css/CSSCharsetRule.cpp:
2088         (WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
2089         * css/CSSComputedStyleDeclaration.cpp:
2090         (WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
2091         * css/CSSCrossfadeValue.cpp:
2092         (WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
2093         * css/CSSCursorImageValue.cpp:
2094         (WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
2095         * css/CSSFontFaceRule.cpp:
2096         (WebCore::CSSFontFaceRule::reportDescendantMemoryUsage):
2097         * css/CSSFontFaceSrcValue.cpp:
2098         (WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
2099         * css/CSSFunctionValue.cpp:
2100         (WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
2101         * css/CSSGradientValue.cpp:
2102         (WebCore::CSSGradientColorStop::reportMemoryUsage):
2103         (WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
2104         (WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
2105         (WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
2106         * css/CSSImageGeneratorValue.cpp:
2107         (WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
2108         * css/CSSImageSetValue.cpp:
2109         (WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
2110         (WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
2111         * css/CSSImageValue.cpp:
2112         (WebCore::CSSImageValue::reportDescendantMemoryUsage):
2113         * css/CSSImportRule.cpp:
2114         (WebCore::CSSImportRule::reportDescendantMemoryUsage):
2115         * css/CSSInheritedValue.cpp:
2116         (WebCore::CSSInheritedValue::reportDescendantMemoryUsage):
2117         * css/CSSInitialValue.cpp:
2118         (WebCore::CSSInitialValue::reportDescendantMemoryUsage):
2119         * css/CSSLineBoxContainValue.cpp:
2120         (WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):
2121         * css/CSSMediaRule.cpp:
2122         (WebCore::CSSMediaRule::reportDescendantMemoryUsage):
2123         * css/CSSPageRule.cpp:
2124         (WebCore::CSSPageRule::reportDescendantMemoryUsage):
2125         * css/CSSPrimitiveValue.cpp:
2126         (WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
2127         * css/CSSProperty.cpp:
2128         (WebCore::CSSProperty::reportMemoryUsage):
2129         * css/CSSReflectValue.cpp:
2130         (WebCore::CSSReflectValue::reportDescendantMemoryUsage):
2131         * css/CSSRule.cpp:
2132         (WebCore::CSSRule::reportBaseClassMemoryUsage):
2133         * css/CSSRuleList.cpp:
2134         (WebCore::StaticCSSRuleList::reportMemoryUsage):
2135         * css/CSSRuleList.h:
2136         * css/CSSSelectorList.cpp:
2137         (WebCore::CSSSelectorList::reportMemoryUsage):
2138         * css/CSSStyleRule.cpp:
2139         (WebCore::CSSStyleRule::reportDescendantMemoryUsage):
2140         * css/CSSStyleSheet.cpp:
2141         (WebCore::CSSStyleSheet::reportMemoryUsage):
2142         * css/CSSTimingFunctionValue.cpp:
2143         (WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
2144         (WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
2145         (WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):
2146         * css/CSSUnicodeRangeValue.cpp:
2147         (WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):
2148         * css/CSSUnknownRule.h:
2149         (WebCore::CSSUnknownRule::reportDescendantMemoryUsage):
2150         * css/CSSValue.cpp:
2151         (WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
2152         * css/CSSValueList.cpp:
2153         (WebCore::CSSValueList::reportDescendantMemoryUsage):
2154         * css/CSSVariableValue.h:
2155         (WebCore::CSSVariableValue::reportDescendantMemoryUsage):
2156         * css/FontFeatureValue.cpp:
2157         (WebCore::FontFeatureValue::reportDescendantMemoryUsage):
2158         * css/FontValue.cpp:
2159         (WebCore::FontValue::reportDescendantMemoryUsage):
2160         * css/MediaList.cpp:
2161         (WebCore::MediaQuerySet::reportMemoryUsage):
2162         (WebCore::MediaList::reportMemoryUsage):
2163         * css/MediaQuery.cpp:
2164         (WebCore::MediaQuery::reportMemoryUsage):
2165         * css/MediaQueryExp.cpp:
2166         (WebCore::MediaQueryExp::reportMemoryUsage):
2167         * css/PropertySetCSSStyleDeclaration.cpp:
2168         (WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
2169         (WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
2170         (WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
2171         * css/ShadowValue.cpp:
2172         (WebCore::ShadowValue::reportDescendantMemoryUsage):
2173         * css/StylePropertySet.cpp:
2174         (WebCore::StylePropertySet::reportMemoryUsage):
2175         * css/StyleResolver.cpp:
2176         (WebCore::StyleResolver::Features::reportMemoryUsage):
2177         (WebCore::StyleResolver::collectMatchingRulesForList):
2178         * css/StyleRule.cpp:
2179         (WebCore::StyleRuleBase::reportMemoryUsage):
2180         (WebCore::StyleRule::reportDescendantMemoryUsage):
2181         (WebCore::StyleRulePage::reportDescendantMemoryUsage):
2182         (WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
2183         (WebCore::StyleRuleBlock::reportDescendantMemoryUsage):
2184         (WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
2185         (WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
2186         * css/StyleRuleImport.cpp:
2187         (WebCore::StyleRuleImport::reportDescendantMemoryUsage):
2188         * css/StyleSheetContents.cpp:
2189         (WebCore::StyleSheetContents::reportMemoryUsage):
2190         * css/WebKitCSSFilterValue.cpp:
2191         (WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):
2192         * css/WebKitCSSKeyframeRule.cpp:
2193         (WebCore::StyleKeyframe::reportMemoryUsage):
2194         (WebCore::WebKitCSSKeyframeRule::reportDescendantMemoryUsage):
2195         * css/WebKitCSSKeyframesRule.cpp:
2196         (WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
2197         (WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):
2198         * css/WebKitCSSMixFunctionValue.cpp:
2199         (WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):
2200         * css/WebKitCSSRegionRule.cpp:
2201         (WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):
2202         * css/WebKitCSSSVGDocumentValue.cpp:
2203         (WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
2204         * css/WebKitCSSShaderValue.cpp:
2205         (WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
2206         * css/WebKitCSSTransformValue.cpp:
2207         (WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):
2208         * dom/Attribute.h:
2209         (WebCore::Attribute::reportMemoryUsage):
2210         * dom/CharacterData.cpp:
2211         (WebCore::CharacterData::reportMemoryUsage):
2212         * dom/ContainerNode.h:
2213         (WebCore::ContainerNode::reportMemoryUsage):
2214         * dom/Document.cpp:
2215         (WebCore::Document::reportMemoryUsage):
2216         * dom/DocumentEventQueue.cpp:
2217         (WebCore::DocumentEventQueue::reportMemoryUsage):
2218         * dom/Element.h:
2219         (WebCore::Element::reportMemoryUsage):
2220         * dom/ElementAttributeData.cpp:
2221         (WebCore::ElementAttributeData::reportMemoryUsage):
2222         * dom/Event.cpp:
2223         (WebCore::Event::reportMemoryUsage):
2224         * dom/MemoryInstrumentation.cpp:
2225         (WebCore):
2226         * dom/MemoryInstrumentation.h:
2227         (WebCore):
2228         (GenericMemoryTypes):
2229         (WebCore::MemoryInstrumentation::addRootObject):
2230         (WebCore::MemoryObjectInfo::reportObjectInfo):
2231         (WebCoreMemoryTypes):
2232         * dom/Node.cpp:
2233         (WebCore::Node::reportMemoryUsage):
2234         * dom/QualifiedName.h:
2235         (WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
2236         (WebCore::QualifiedName::reportMemoryUsage):
2237         * html/HTMLImageElement.cpp:
2238         (WebCore::HTMLImageElement::reportMemoryUsage):
2239         * inspector/InspectorMemoryAgent.cpp:
2240         (WebCore):
2241         * loader/DocumentLoader.cpp:
2242         (WebCore::DocumentLoader::reportMemoryUsage):
2243         * loader/FrameLoader.cpp:
2244         (WebCore::FrameLoader::reportMemoryUsage):
2245         * loader/MainResourceLoader.cpp:
2246         (WebCore::MainResourceLoader::reportMemoryUsage):
2247         * loader/ResourceLoader.cpp:
2248         (WebCore::ResourceLoader::reportMemoryUsage):
2249         * loader/SubresourceLoader.cpp:
2250         (WebCore::SubresourceLoader::reportMemoryUsage):
2251         * loader/SubstituteData.cpp:
2252         (WebCore::SubstituteData::reportMemoryUsage):
2253         * loader/cache/CachedCSSStyleSheet.cpp:
2254         (WebCore::CachedCSSStyleSheet::reportMemoryUsage):
2255         * loader/cache/CachedFont.cpp:
2256         (WebCore::CachedFont::reportMemoryUsage):
2257         * loader/cache/CachedImage.cpp:
2258         (WebCore::CachedImage::reportMemoryUsage):
2259         * loader/cache/CachedRawResource.cpp:
2260         (WebCore::CachedRawResource::reportMemoryUsage):
2261         * loader/cache/CachedResource.cpp:
2262         (WebCore::CachedResource::reportMemoryUsage):
2263         * loader/cache/CachedResourceHandle.cpp:
2264         (WebCore::CachedResourceHandleBase::reportMemoryUsage):
2265         * loader/cache/CachedResourceLoader.cpp:
2266         (WebCore::CachedResourceLoader::reportMemoryUsage):
2267         * loader/cache/CachedSVGDocument.cpp:
2268         (WebCore::CachedSVGDocument::reportMemoryUsage):
2269         * loader/cache/CachedScript.cpp:
2270         (WebCore::CachedScript::reportMemoryUsage):
2271         * loader/cache/CachedShader.cpp:
2272         (WebCore::CachedShader::reportMemoryUsage):
2273         * loader/cache/CachedXSLStyleSheet.cpp:
2274         (WebCore::CachedXSLStyleSheet::reportMemoryUsage):
2275         * loader/cache/MemoryCache.cpp:
2276         (WebCore::MemoryCache::reportMemoryUsage):
2277         * page/Frame.cpp:
2278         (WebCore::Frame::reportMemoryUsage):
2279         * platform/SharedBuffer.cpp:
2280         (WebCore::SharedBuffer::reportMemoryUsage):
2281         * platform/TreeShared.h:
2282         (WebCore::TreeShared::reportMemoryUsage):
2283         * platform/graphics/BitmapImage.cpp:
2284         (WebCore::BitmapImage::reportMemoryUsage):
2285         * platform/graphics/CrossfadeGeneratedImage.cpp:
2286         (WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
2287         * platform/graphics/GeneratedImage.cpp:
2288         (WebCore::GeneratedImage::reportMemoryUsage):
2289         * platform/graphics/GeneratorGeneratedImage.cpp:
2290         (WebCore::GeneratorGeneratedImage::reportMemoryUsage):
2291         * platform/graphics/Image.cpp:
2292         (WebCore::Image::reportMemoryUsage):
2293         * platform/network/FormData.cpp:
2294         (WebCore::FormData::reportMemoryUsage):
2295         * platform/network/ResourceRequestBase.cpp:
2296         (WebCore::ResourceRequestBase::reportMemoryUsage):
2297         * platform/network/ResourceResponseBase.cpp:
2298         (WebCore::ResourceResponseBase::reportMemoryUsage):
2299         * rendering/style/RenderStyle.cpp:
2300         (WebCore::RenderStyle::reportMemoryUsage):
2301         * rendering/style/StyleRareInheritedData.cpp:
2302         (WebCore::StyleRareInheritedData::reportMemoryUsage):
2303         * rendering/style/StyleRareNonInheritedData.cpp:
2304         (WebCore::StyleRareNonInheritedData::reportMemoryUsage):
2305         * svg/SVGColor.cpp:
2306         (WebCore::SVGColor::reportDescendantMemoryUsage):
2307         * svg/SVGPaint.cpp:
2308         (WebCore::SVGPaint::reportDescendantMemoryUsage):
2309         * svg/graphics/SVGImage.cpp:
2310         (WebCore::SVGImage::reportMemoryUsage):
2311
2312 2012-09-05  Ilya Tikhonovsky  <loislo@chromium.org>
2313
2314         Web Inspector: NMI: extract overloaded instrumentation members for WebCore classes from core NMI code.
2315         https://bugs.webkit.org/show_bug.cgi?id=95834
2316
2317         Reviewed by Yury Semikhatsky.
2318
2319         I'd like to remove custom instrumentation methods from MemoryInstrumentation class
2320         before upstreaming it to WTF. I've done it with help of MemoryInstrumentationTraits template helper.
2321
2322         Unfortunately it is not possible to use template class because mac-ews bot reports warning: redundant redeclaration of 'something' in same scope.
2323         I've found that it is an old problem in gcc that is forced by -Wredundant-decls flag on the bot. See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15867
2324
2325         * dom/MemoryInstrumentation.cpp:
2326         (WebCore::::addInstrumentedObject):
2327         (WebCore):
2328         * dom/MemoryInstrumentation.h:
2329         (WebCore):
2330         (MemoryInstrumentationTraits):
2331         (MemoryInstrumentation):
2332         (WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
2333         (InstrumentedPointer):
2334         (WebCore::MemoryInstrumentation::addObject):
2335         (WebCore::MemoryInstrumentation::addInstrumentedObject):
2336         (WebCore::MemoryInstrumentation::addRawBuffer):
2337         (WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject):
2338         (WebCore::MemoryInstrumentation::OwningTraits::addObject):
2339         (WebCore::::addInstrumentedObject):
2340         (WebCore::::addObject):
2341         (WebCore::MemoryObjectInfo::MemoryObjectInfo):
2342         (WebCore::MemoryObjectInfo::objectType):
2343         (WebCore::MemoryObjectInfo::reportObjectInfo):
2344         (MemoryObjectInfo):
2345         (WebCore::MemoryClassInfo::MemoryClassInfo):
2346         (MemoryClassInfo):
2347         (WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
2348         (WebCore::MemoryInstrumentation::addObjectImpl):
2349         (WebCore::MemoryInstrumentation::addHashMap):
2350         (WebCore::MemoryInstrumentation::addHashSet):
2351         (WebCore::MemoryInstrumentation::addInstrumentedCollection):
2352         (WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
2353         (WebCore::MemoryInstrumentation::addInstrumentedMapValues):
2354         (WebCore::MemoryInstrumentation::addListHashSet):
2355         (WebCore::MemoryInstrumentation::addVector):
2356         * inspector/MemoryInstrumentationImpl.cpp:
2357         (WebCore::MemoryInstrumentationImpl::countObjectSize):
2358         * inspector/MemoryInstrumentationImpl.h:
2359         (WebCore::MemoryInstrumentationImpl::totalSize):
2360         (MemoryInstrumentationImpl):
2361
2362 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2363
2364         [Qt] Build fix on OS X
2365
2366         Copy/paste-error resulted in us compiling InspectorPageOverlay.h
2367
2368         Reviewed by Ossy.
2369
2370         * DerivedSources.pri:
2371
2372 2012-09-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2373
2374         Unreviewed, rolling out r127573.
2375         http://trac.webkit.org/changeset/127573
2376         https://bugs.webkit.org/show_bug.cgi?id=95844
2377
2378         Breaks EFL Debug bot tests. (Requested by drott on #webkit).
2379
2380         * platform/efl/RenderThemeEfl.cpp:
2381         (WebCore::RenderThemeEfl::themePartCacheEntryReset):
2382         (WebCore::RenderThemeEfl::cacheThemePartNew):
2383         (WebCore::RenderThemeEfl::paintThemePart):
2384         (WebCore::RenderThemeEfl::setThemePath):
2385         (WebCore::RenderThemeEfl::createCanvas):
2386         (WebCore::RenderThemeEfl::createEdje):
2387         (WebCore::RenderThemeEfl::applyPartDescriptions):
2388         (WebCore::RenderThemeEfl::themeChanged):
2389         (WebCore):
2390         * platform/efl/RenderThemeEfl.h:
2391         (RenderThemeEfl):
2392
2393 2012-09-05  MORITA Hajime  <morrita@google.com>
2394
2395         ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
2396         https://bugs.webkit.org/show_bug.cgi?id=91704
2397
2398         Reviewed by Kentaro Hara.
2399
2400         This change implement ShadowRoot::cloneNode() which throws an exception.
2401         This also adds an overloaded version cloneNode() to ShadowRoot.idl
2402         which is enabled only for JavaScript instead of changing the
2403         signature of Node::cloneNode().
2404
2405         Note that changing the existing signature can break GObject bindings
2406         compatibility.
2407
2408         Test: fast/dom/shadow/shadowroot-clonenode.html
2409
2410         * dom/ShadowRoot.cpp:
2411         (WebCore::ShadowRoot::cloneNode):
2412         (WebCore):
2413         * dom/ShadowRoot.h:
2414         (ShadowRoot):
2415         * dom/ShadowRoot.idl:
2416
2417 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
2418
2419         [Qt] Unreviewed trivial build fix: Use DOMAllInOne.cpp only if we have xslt available.
2420
2421         * Target.pri:
2422
2423 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2424
2425         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
2426         https://bugs.webkit.org/show_bug.cgi?id=92735
2427
2428         Reviewed by Hajime Morita.
2429
2430         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
2431
2432         Covered by existing test cases.
2433
2434         * testing/Internals.cpp:
2435         (WebCore::Internals::numberOfPages):
2436         (WebCore):
2437         (WebCore::Internals::pageProperty):
2438         (WebCore::Internals::pageSizeAndMarginsInPixels):
2439         * testing/Internals.h:
2440         (Internals):
2441         * testing/Internals.idl:
2442
2443 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
2444
2445         [Qt] Automate the use of AllInOne files in the Qt build
2446         https://bugs.webkit.org/show_bug.cgi?id=95837
2447
2448         Reviewed by Tor Arne Vestbø.
2449
2450         Replace the manual use of SVGAllInOne.cpp with automated use through
2451         the ALL_IN_ONE_SOURCES variable. This adds a few more all-in-one sources
2452         to the build and leaves out some that do not compile yet due to various
2453         platform-dependant pre-processor macro issues.
2454
2455         * Target.pri:
2456
2457 2012-09-05  Benjamin Poulain  <bpoulain@apple.com>
2458
2459         Fix the uses of String::operator+=() for Mac
2460         https://bugs.webkit.org/show_bug.cgi?id=95818
2461
2462         Reviewed by Dan Bernstein.
2463
2464         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
2465         (WebCore::JSCSSStyleDeclaration::putDelegate):
2466         This is a legitimate use of String::append(), it is the only
2467         concatenation in this function.
2468
2469         * loader/appcache/ManifestParser.cpp:
2470         (WebCore::parseManifest): Ditto.
2471
2472 2012-09-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2473
2474         [EFL] Fuzzy load the Edje theme for HTML forms
2475         https://bugs.webkit.org/show_bug.cgi?id=95832
2476
2477         Reviewed by Gyuyoung Kim.
2478
2479         Change the theme so that it is first loaded when actually used.
2480         This also fixed the case that it was impossible to change theme
2481         a second time.
2482
2483         Tested by current tests. API unit test coming in separate patch.
2484
2485         * platform/efl/RenderThemeEfl.cpp:
2486         (WebCore::RenderThemeEfl::themePartCacheEntryReset):
2487         (WebCore::RenderThemeEfl::cacheThemePartNew):
2488         (WebCore::RenderThemeEfl::paintThemePart):
2489         (WebCore::RenderThemeEfl::setThemePath):
2490         (WebCore::RenderThemeEfl::edje):
2491         (WebCore::RenderThemeEfl::applyPartDescriptions):
2492         * platform/efl/RenderThemeEfl.h:
2493         (RenderThemeEfl):
2494
2495 2012-09-05  Chris Guan  <chris.guan@torchmobile.com.cn>
2496
2497         [Blackberry] Add document url and securityOrigin to platform request.
2498         https://bugs.webkit.org/show_bug.cgi?id=95822
2499
2500         Reviewed by George Staikos.
2501         Internally Reviewed by Joe Mason.
2502
2503         It is a webworks requirement.
2504
2505         * platform/network/blackberry/NetworkManager.cpp:
2506         (WebCore::NetworkManager::startJob):
2507
2508 2012-09-04  Ilya Tikhonovsky  <loislo@chromium.org>
2509
2510         Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
2511         https://bugs.webkit.org/show_bug.cgi?id=95739
2512
2513         Reviewed by Yury Semikhatsky.
2514
2515         When we go deeper into different parts of browser like skia, chromium itself etc.
2516         we can't use a single enum for all reported object types.
2517         The current idea is to use plain simple strings as ObjectType identifiers.
2518         In the future patches we will extract these identifiers into separate class or namespace
2519         and and split it between components.
2520
2521         * dom/MemoryInstrumentation.cpp:
2522         (WebCore):
2523         * dom/MemoryInstrumentation.h:
2524         (MemoryInstrumentation):
2525         * inspector/InspectorMemoryAgent.cpp:
2526         (WebCore::addMemoryBlockFor):
2527         (WebCore):
2528         * inspector/MemoryInstrumentationImpl.cpp:
2529         (WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
2530         (WebCore::MemoryInstrumentationImpl::countObjectSize):
2531         * inspector/MemoryInstrumentationImpl.h:
2532         (WebCore::MemoryInstrumentationImpl::totalSize):
2533         (WebCore::MemoryInstrumentationImpl::reportedSizeForAllTypes):
2534         (MemoryInstrumentationImpl):
2535
2536 2012-09-05  Patrick Gansterer  <paroga@webkit.org>
2537
2538         Build fix for WinCE after r127525.
2539
2540         * platform/graphics/wince/FontCustomPlatformData.h:
2541         (WebCore):
2542
2543 2012-09-04  Keishi Hattori  <keishi@webkit.org>
2544
2545         Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
2546         https://bugs.webkit.org/show_bug.cgi?id=95681
2547
2548         Reviewed by Kent Tamura.
2549
2550         We are moving calendar picker PagePopupClient to WebKit layer so ports
2551         can use their platform native chooser UI if they have one.
2552         DateTimeChooser, DateTimeChooserClient etc. will be reused when we
2553         implement the week picker and month picker.
2554
2555         No new tests. No behavior change. Covered by existing calendar picker tests.
2556
2557         * WebCore.gypi:
2558         * html/shadow/CalendarPickerElement.cpp:
2559         (WebCore::CalendarPickerElement::CalendarPickerElement):
2560         (WebCore::CalendarPickerElement::~CalendarPickerElement):
2561         (WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value.
2562         (WebCore):
2563         (WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended.
2564         (WebCore::CalendarPickerElement::openPopup):
2565         (WebCore::CalendarPickerElement::closePopup):
2566         * html/shadow/CalendarPickerElement.h:
2567         (CalendarPickerElement):
2568         * loader/EmptyClients.cpp:
2569         (WebCore):
2570         (WebCore::EmptyChromeClient::openDateTimeChooser):
2571         * loader/EmptyClients.h:
2572         (EmptyChromeClient):
2573         * page/ChromeClient.h:
2574         (WebCore):
2575         (ChromeClient):
2576         * platform/DateTimeChooser.h:
2577         (WebCore):
2578         (DateTimeChooserParameters): Contains information needed to open the DateTimeChooser.
2579         (DateTimeChooser):
2580         (WebCore::DateTimeChooser::~DateTimeChooser):
2581         * platform/DateTimeChooserClient.h:
2582         (WebCore):
2583         (DateTimeChooserClient):
2584         (WebCore::DateTimeChooserClient::~DateTimeChooserClient):
2585
2586 2012-09-04  Mike Lawther  <mikelawther@chromium.org>
2587
2588         CSS3 calc: expressions with 'em' units do not zoom correctly.
2589         https://bugs.webkit.org/show_bug.cgi?id=95705
2590
2591         Reviewed by Ojan Vafai.
2592
2593         Each primitive value in a CSS calc expression now has (zoom) multiplier and scale factor applied
2594         independently. Previously the multiplier and a single scale factor was applied to the expression
2595         as a whole, but this failed to account for expressions involving font relative units. This is 
2596         because the multiplier should not be applied to font relative units.
2597
2598         Test: css3/calc/zoom-with-em.html
2599
2600         * css/CSSPrimitiveValue.cpp:
2601         (WebCore::CSSPrimitiveValue::computeLengthDouble):
2602
2603 2012-09-04  Brian Anderson  <brianderson@chromium.org>
2604
2605         [chromium] Prevent compositor ticking if it can't draw
2606         https://bugs.webkit.org/show_bug.cgi?id=95399
2607
2608         Reviewed by James Robinson.
2609
2610         Background extensions had an always ticking compositor even though
2611         they couldn't draw. This patch disables the ticks when canDraw is false
2612         and adds a notification mechanism for when canDraw changes states so
2613         we can recover properly.
2614
2615         Tests updated for new interfaces.
2616         Regression test added to make sure ticking stops when canDraw is false.
2617         notifyIfCanDrawChanged test added to make sure notifications are sent
2618         for any changes that might affect canDraw.
2619
2620         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
2621         (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
2622         (WebCore::CCLayerTreeHostImpl::notifyIfCanDrawChanged):
2623         (WebCore):
2624         (WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
2625         (WebCore::CCLayerTreeHostImpl::setRootLayer):
2626         (WebCore::CCLayerTreeHostImpl::initializeRenderer):
2627         (WebCore::CCLayerTreeHostImpl::setViewportSize):
2628         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
2629         (CCLayerTreeHostImplClient):
2630         (WebCore::CCLayerTreeHostImpl::resetContentsTexturesPurged):
2631         (CCLayerTreeHostImpl):
2632         * platform/graphics/chromium/cc/CCScheduler.cpp:
2633         (WebCore::CCScheduler::setCanDraw):
2634         (WebCore):
2635         (WebCore::CCScheduler::processScheduledActions):
2636         * platform/graphics/chromium/cc/CCScheduler.h:
2637         (CCScheduler):
2638         * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
2639         (WebCore::CCSchedulerStateMachine::toString):
2640         (WebCore):
2641         (WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):
2642         * platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
2643         (CCSchedulerStateMachine):
2644         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
2645         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
2646         (WebCore::CCThreadProxy::onCanDrawStateChanged):
2647         (WebCore):
2648         (WebCore::CCThreadProxy::beginFrame):
2649         (WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
2650         * platform/graphics/chromium/cc/CCThreadProxy.h:
2651
2652 2012-09-04  Adam Barth  <abarth@chromium.org>
2653
2654         Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
2655         https://bugs.webkit.org/show_bug.cgi?id=95800
2656
2657         Reviewed by Benjamin Poulain.
2658
2659         This patch is a re-spin of part of the patch from
2660         https://bugs.webkit.org/show_bug.cgi?id=95502, but with the tests
2661         fixed.  :)
2662
2663         * css/StylePropertySet.cpp:
2664         (WebCore::StylePropertySet::get4Values):
2665         (WebCore::StylePropertySet::getLayeredShorthandValue):
2666
2667 2012-09-04  Keishi Hattori  <keishi@webkit.org>
2668
2669         REGRESSION(r126132): MediaSlider and MediaVolumeSlider thumbs don't match mouse when dragged
2670         https://bugs.webkit.org/show_bug.cgi?id=95701
2671
2672         Reviewed by Kent Tamura.
2673
2674         MediaSlider and MediaVolumeSlider thumbs didn't match mouse when dragged because of the negative margin applied to the thumb.
2675
2676         Test: platform/chromium/media/media-volume-slider-hit-test.html
2677
2678         * html/shadow/SliderThumbElement.cpp:
2679         (WebCore::SliderThumbElement::setPositionFromPoint): Account for margins when calculating the position.
2680
2681 2012-09-04  Tony Chang  <tony@chromium.org>
2682
2683         Add a const version of RenderBox::computeLogicalHeight
2684         https://bugs.webkit.org/show_bug.cgi?id=95787
2685
2686         Reviewed by Ojan Vafai.
2687
2688         After this, we can rename the old computeLogicalHeight to computeAndSetLogicalHeight
2689         to make it clear that it is modifying values.
2690
2691         No new tests, this should just be a refactor.
2692
2693         * rendering/RenderBox.cpp:
2694         (WebCore::RenderBox::constrainLogicalHeightByMinMax): Make const.
2695         (WebCore::RenderBox::computeLogicalHeight): Add a const version that takes a LogicalExtentComputedValues struct for out values.
2696         (WebCore::RenderBox::computeLogicalHeightUsing): Make const.
2697         (WebCore::RenderBox::computeContentLogicalHeightUsing): Make const.
2698         (WebCore::RenderBox::computePercentageLogicalHeight): Add a const cast. I tried to
2699         convert everything below to const, but that's not a simple task. Also, computeReplacedLogicalHeightUsing
2700         is already using a const_cast.
2701         * rendering/RenderBox.h:
2702         (RenderBox): Add const to method signatures.
2703
2704 2012-09-04  Dirk Schulze  <krit@webkit.org>
2705
2706         -webkit-clip-path does not apply origin for polygon()
2707         https://bugs.webkit.org/show_bug.cgi?id=95656
2708
2709         Reviewed by Tim Horton.
2710
2711         The polygon() shape function did not apply origin of bouding box on created path. The shape was
2712         not moved to the correct position.
2713
2714         Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg
2715                svg/clip-path/clip-path-shape-polygon-relative.svg
2716
2717         * rendering/style/BasicShapes.cpp:
2718         (WebCore::BasicShapePolygon::path): Apply origin of bounding box.
2719
2720 2012-09-04  Adam Barth  <abarth@chromium.org>
2721
2722         Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
2723         https://bugs.webkit.org/show_bug.cgi?id=95798
2724
2725         Reviewed by Eric Seidel.
2726
2727         This patch makes the chromium-linux port build without
2728         WTF::String::operator+=.  There are a couple places that require some
2729         more careful study, and I've whitelisted those uses by defining
2730         WTF_DEPRECATED_STRING_OPERATORS at the top of the files. (See
2731         https://bugs.webkit.org/show_bug.cgi?id=95797 for an explanation of
2732         WTF_DEPRECATED_STRING_OPERATORS.)
2733
2734         * css/StylePropertySet.cpp:
2735         * inspector/InspectorOverlay.cpp:
2736         (WebCore::InspectorOverlay::drawNodeHighlight):
2737         * platform/graphics/filters/CustomFilterValidatedProgram.cpp:
2738         (WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):
2739
2740 2012-09-04  Tony Chang  <tony@chromium.org>
2741
2742         Use TrackedRendererListHashSet typedef for percentHeightDescendants()
2743         https://bugs.webkit.org/show_bug.cgi?id=95791
2744
2745         Reviewed by Ojan Vafai.
2746
2747         There were a couple callers that were using ListHashSet<RenderBox*> instead of the typedef.
2748
2749         No new tests, this is just a refactor.
2750
2751         * rendering/RenderTableSection.cpp:
2752         (WebCore::RenderTableSection::layoutRows):
2753         * rendering/RenderView.cpp:
2754         (WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
2755
2756 2012-09-04  Alec Flett  <alecflett@chromium.org>
2757
2758         IndexedDB: remove final createIndex backend glue
2759         https://bugs.webkit.org/show_bug.cgi?id=95385
2760
2761         Reviewed by Adam Barth.
2762
2763         Remove all code that created index keys in the IndexedDB backend.
2764
2765         No new tests, this is just removal of dead code.
2766
2767         * Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Removed.
2768         * Modules/indexeddb/IDBKeyPathBackendImpl.h: Removed.
2769         * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
2770         (WebCore):
2771         * WebCore.gyp/WebCore.gyp:
2772         * WebCore.gypi:
2773         * storage/chromium/IDBKeyPathBackendImpl.cpp: Removed.
2774
2775 2012-09-04  Sergey Glazunov  <serg.glazunov@gmail.com>
2776
2777         Frame element doesn't always unload its child frame.
2778         https://bugs.webkit.org/show_bug.cgi?id=94717
2779
2780         Reviewed by Hajime Morita.
2781
2782         It's possible for a frame element that has been removed from the document
2783         to retain an active child frame. This inconsistent state may become a source
2784         of security vulnerabilities.
2785
2786         The patch adds a global HashSet to store the nodes currently processed by
2787         ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until
2788         the processing is complete.
2789
2790         Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately
2791         followed by the actual removal.
2792
2793         Test: fast/frames/out-of-document-iframe-has-child-frame.html
2794
2795         * dom/ContainerNode.cpp:
2796         (WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop.
2797         (WebCore::ContainerNode::removeChild): Rearrange some event firing code.
2798         (WebCore::ContainerNode::removeChildren): Ditto.
2799         * dom/ContainerNodeAlgorithms.cpp:
2800         (WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*).
2801         * dom/ContainerNodeAlgorithms.h:
2802         (WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
2803         (ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector.
2804         (WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
2805         (WebCore::ChildFrameDisconnector::rootNodes):
2806         (WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter.
2807         (WebCore::ChildFrameDisconnector::nodeHasDisconnector):
2808         (WebCore):
2809         * dom/Node.cpp:
2810         (WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector.
2811         * html/HTMLFrameElementBase.cpp:
2812         (WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document.
2813
2814 2012-09-03  Sam Weinig  <sam@webkit.org>
2815
2816         Part 1 of removing PlatformString.h, move remaining functions to new homes
2817         https://bugs.webkit.org/show_bug.cgi?id=95702
2818
2819         Reviewed by Beth Dakin.
2820
2821         Move utf8Buffer() to SharedBuffer.h/cpp
2822         Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp
2823
2824         * CMakeLists.txt:
2825         * GNUmakefile.list.am:
2826         * Target.pri:
2827         * WebCore.gypi:
2828         * WebCore.vcproj/WebCore.vcproj:
2829         * WebCore.xcodeproj/project.pbxproj:
2830         Update projects.
2831
2832         * platform/text/TextAllInOne.cpp:
2833         Add TextBreakIterator.cpp.
2834
2835         * editing/Editor.h:
2836         Forward declare SharedBuffer, now that PlatformString.h doesn't.
2837
2838         * html/InputType.cpp:
2839         #include TextBreakIterator.h.
2840
2841         * loader/appcache/ApplicationCacheStorage.h:
2842         Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer.
2843
2844         * platform/LocalizedStrings.cpp:
2845         Replace inclusion of PlatformString.h with TextBreakIterator.h
2846  
2847         * platform/SharedBuffer.cpp:
2848         * platform/SharedBuffer.h:
2849         Move utf8Buffer() here.
2850
2851         * platform/text/PlatformString.h:
2852         Remove everything except the #include of WTFString.h.
2853
2854         * platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp.
2855         (WebCore::numGraphemeClusters):
2856         (WebCore::numCharactersInGraphemeClusters):
2857         * platform/text/TextBreakIterator.h:
2858         Move numGraphemeClusters() and numCharactersInGraphemeClusters() here. 
2859
2860 2012-09-04  Julien Chaffraix  <jchaffraix@webkit.org>
2861
2862         REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
2863         https://bugs.webkit.org/show_bug.cgi?id=95776
2864
2865         Reviewed by Simon Fraser.
2866
2867         r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
2868         the offset were positive which got exposed to other code paths, leading to the regression.
2869
2870         Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.
2871
2872         * rendering/RenderLayer.cpp:
2873         (WebCore::RenderLayer::clampScrollOffset):
2874         Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.
2875
2876 2012-09-04  Joshua Bell  <jsbell@chromium.org>
2877
2878         IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
2879         https://bugs.webkit.org/show_bug.cgi?id=95777
2880
2881         Reviewed by Tony Chang.
2882
2883         IDBRequests are kept alive as long as they may fire events, which includes
2884         if the associated IDBCursor object can be advanced. When the transaction
2885         is finished the IDBCursor is notified which in turn tells the IDBRequest
2886         that the cursor won't be the source of more events. However, if this occurs
2887         and no further events fire the IDBRequest doesn't clear it's "has pending
2888         activity flag". Clear the flag on the notification if the request is
2889         otherwise complete.
2890
2891         No new tests - ActiveDOMObjects and leaks are persnickety.
2892
2893         * Modules/indexeddb/IDBRequest.cpp:
2894         (WebCore::IDBRequest::finishCursor):
2895
2896 2012-09-04  Max Vujovic  <mvujovic@adobe.com>
2897
2898         [CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes.
2899         https://bugs.webkit.org/show_bug.cgi?id=93870
2900
2901         Reviewed by Dirk Schulze.
2902
2903         Add expressions for the aforementioned blend modes. The expressions are lifted directly
2904         from the CSS Compositing and Blending spec [1]. WebKit adds these blending expressions to
2905         the author's shader.
2906
2907         [1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal
2908
2909         Test: css3/filters/custom/custom-filter-blend-modes.html
2910
2911         * platform/graphics/filters/CustomFilterValidatedProgram.cpp:
2912         (WebCore::CustomFilterValidatedProgram::blendFunctionString):
2913
2914 2012-09-04  Nikhil Bhargava  <nbhargava@google.com>
2915
2916         Fix style for Event.h
2917         https://bugs.webkit.org/show_bug.cgi?id=95779
2918
2919         Reviewed by Eric Seidel.
2920
2921         Changes indenting for Event.h to match style guidelines for namespaces
2922
2923         * dom/Event.h:
2924
2925 2012-09-04  Jeffrey Pfau  <jpfau@apple.com>
2926
2927         Make plugins respect third-party storage blocking setting
2928         https://bugs.webkit.org/show_bug.cgi?id=94888
2929
2930         Reviewed by Brady Eidson.
2931
2932         Added functions for discerning if a plugin should be able to access its storage in its current origin.
2933
2934         Tests: http/tests/security/cross-origin-plugin-allowed.html
2935                http/tests/security/cross-origin-plugin.html
2936
2937         * WebCore.exp.in: Export FrameTree::top and SecurityOrigin::canAccessStorage
2938         * page/SecurityOrigin.h: Added canAccessPluginStorage
2939         (WebCore::SecurityOrigin::canAccessPluginStorage):
2940
2941 2012-09-04  Robert Hogan  <robert@webkit.org>
2942
2943         Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer
2944         https://bugs.webkit.org/show_bug.cgi?id=95632
2945
2946         Reviewed by Abhishek Arya.
2947
2948         Don't add floats to the floating object set of blocks that avoid floats. There's no point in doing that
2949         and they will never get cleared out during relayout.
2950
2951         Tests: fast/css/intruding-floats-crash.html
2952
2953         * rendering/RenderBlock.cpp:
2954         (WebCore::RenderBlock::clearFloatsIfNeeded):
2955
2956 2012-09-04  Michael Saboff  <msaboff@apple.com>
2957
2958         equal() in CSSParser.cpp should check the length of characters
2959         https://bugs.webkit.org/show_bug.cgi?id=95706
2960
2961         Reviewed by Abhishek Arya.
2962
2963         Pass the length of string literals to CSSParser static functions equal() and 
2964         equalIgnoringCase() so that checks won't access out of bounds memory.
2965
2966         Added test fast/css/crash-comparing-equal.html.
2967
2968         * css/CSSParser.cpp:
2969         (WebCore::equal): Use template to retrieve the length of string literal.
2970         (WebCore::equalIgnoringCase): Ditto.
2971         (WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*
2972
2973 2012-09-04  Antonio Gomes  <agomes@rim.com>
2974
2975         [BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
2976         https://bugs.webkit.org/show_bug.cgi?id=95778
2977         PR #202252
2978
2979         Reviewed by Rob Buis.
2980         Internally reviewed by Arvid Nilsson.
2981
2982         Upstream has switch away from using the parent scroll layer's bounds origin
2983         in order to translate contents of all its child layers. Instead now, it directly
2984         sets the scroll position of the child scrollable contents layer.
2985
2986         No new tests, since it is a catch-up with upstreaming code.
2987
2988         Source/WebCore:
2989         * platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
2990         (WebCore):
2991         * platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
2992         (GraphicsLayerBlackBerry):
2993         * platform/graphics/blackberry/LayerCompositingThread.cpp:
2994         (WebCore::LayerCompositingThread::updateAnimations):
2995         * platform/graphics/blackberry/LayerCompositingThread.h:
2996         (WebCore::LayerOverride::LayerOverride):
2997         (LayerOverride):
2998         * platform/graphics/blackberry/LayerData.h:
2999         (LayerData):
3000         * platform/graphics/blackberry/LayerRenderer.cpp:
3001         (WebCore::LayerRenderer::updateLayersRecursive):
3002         * platform/graphics/blackberry/LayerWebKitThread.h:
3003         * rendering/RenderLayerBacking.cpp:
3004         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
3005
3006 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3007
3008         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3009         https://bugs.webkit.org/show_bug.cgi?id=95734
3010
3011         Reviewed by Adam Barth.
3012
3013         createOffer sends a request to the platform implementer requesting it to gather up all candidates.
3014         This can take some time, therefore the request is async.
3015
3016         Test: fast/mediastream/RTCPeerConnection-createOffer.html
3017
3018         * CMakeLists.txt:
3019         * GNUmakefile.list.am:
3020         * Modules/mediastream/RTCErrorCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
3021         (WebCore):
3022         (RTCErrorCallback):
3023         (WebCore::RTCErrorCallback::~RTCErrorCallback):
3024         * Modules/mediastream/RTCErrorCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
3025         * Modules/mediastream/RTCPeerConnection.cpp:
3026         (WebCore::RTCPeerConnection::createOffer):
3027         (WebCore):
3028         * Modules/mediastream/RTCPeerConnection.h:
3029         (WebCore):
3030         (RTCPeerConnection):
3031         * Modules/mediastream/RTCPeerConnection.idl:
3032         * Modules/mediastream/RTCSessionDescriptionCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
3033         (WebCore):
3034         (RTCSessionDescriptionCallback):
3035         (WebCore::RTCSessionDescriptionCallback::~RTCSessionDescriptionCallback):
3036         * Modules/mediastream/RTCSessionDescriptionCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
3037         * Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp: Added.
3038         (WebCore):
3039         (WebCore::RTCSessionDescriptionRequestImpl::create):
3040         (WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
3041         (WebCore::RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl):
3042         (WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
3043         (WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
3044         (WebCore::RTCSessionDescriptionRequestImpl::stop):
3045         (WebCore::RTCSessionDescriptionRequestImpl::clear):
3046         * Modules/mediastream/RTCSessionDescriptionRequestImpl.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
3047         (WebCore):
3048         (RTCSessionDescriptionRequestImpl):
3049         * WebCore.gypi:
3050         * platform/chromium/support/WebRTCSessionDescriptionDescriptor.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.
3051         (WebKit):
3052         (WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
3053         (WebKit::WebRTCSessionDescriptionDescriptor::assign):
3054         (WebKit::WebRTCSessionDescriptionDescriptor::reset):
3055         (WebKit::WebRTCSessionDescriptionDescriptor::operator WTF::PassRefPtr<WebCore::RTCSessionDescriptionDescriptor>):
3056         (WebKit::WebRTCSessionDescriptionDescriptor::initialize):
3057         (WebKit::WebRTCSessionDescriptionDescriptor::type):
3058         (WebKit::WebRTCSessionDescriptionDescriptor::setType):
3059         (WebKit::WebRTCSessionDescriptionDescriptor::sdp):
3060         (WebKit::WebRTCSessionDescriptionDescriptor::setSDP):
3061         * platform/chromium/support/WebRTCSessionDescriptionRequest.cpp: Added.
3062         (WebKit):
3063         (WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
3064         (WebKit::WebRTCSessionDescriptionRequest::assign):
3065         (WebKit::WebRTCSessionDescriptionRequest::reset):
3066         (WebKit::WebRTCSessionDescriptionRequest::requestSucceeded):
3067         (WebKit::WebRTCSessionDescriptionRequest::requestFailed):
3068         (ExtraDataContainer):
3069         (WebKit::ExtraDataContainer::ExtraDataContainer):
3070         (WebKit::ExtraDataContainer::extraData):
3071         (WebKit::WebRTCSessionDescriptionRequest::extraData):
3072         (WebKit::WebRTCSessionDescriptionRequest::setExtraData):
3073         * platform/mediastream/RTCPeerConnectionHandler.cpp:
3074         (RTCPeerConnectionHandlerDummy):
3075         (WebCore::RTCPeerConnectionHandlerDummy::createOffer):
3076         (WebCore):
3077         * platform/mediastream/RTCPeerConnectionHandler.h:
3078         (WebCore):
3079         (RTCPeerConnectionHandler):
3080         * platform/mediastream/RTCSessionDescriptionDescriptor.h:
3081         (WebCore::RTCSessionDescriptionDescriptor::type):
3082         (WebCore::RTCSessionDescriptionDescriptor::sdp):
3083         * platform/mediastream/RTCSessionDescriptionRequest.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
3084         (WebCore):
3085         (RTCSessionDescriptionRequest):
3086         (ExtraData):
3087         (WebCore::RTCSessionDescriptionRequest::ExtraData::~ExtraData):
3088         (WebCore::RTCSessionDescriptionRequest::~RTCSessionDescriptionRequest):
3089         (WebCore::RTCSessionDescriptionRequest::extraData):
3090         (WebCore::RTCSessionDescriptionRequest::setExtraData):
3091         (WebCore::RTCSessionDescriptionRequest::RTCSessionDescriptionRequest):
3092         * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
3093         (WebCore::RTCPeerConnectionHandlerChromium::createOffer):
3094         (WebCore):
3095         * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
3096         (RTCPeerConnectionHandlerChromium):
3097
3098 2012-09-04  Dan Bernstein  <mitz@apple.com>
3099
3100         Reverted r127468 (the fix for <http://webkit.org/b/93443>) because the test it included caused
3101         an assertion failure in Document::updateStyleIfNeeded().
3102
3103         * dom/NamedFlowCollection.cpp:
3104         (WebCore::NamedFlowCollection::ensureFlowWithName):
3105         (WebCore::NamedFlowCollection::discardNamedFlow):
3106         * inspector/Inspector.json:
3107         * inspector/InspectorCSSAgent.cpp:
3108         (WebCore::InspectorCSSAgent::didCreateNamedFlow):
3109         (WebCore::InspectorCSSAgent::didRemoveNamedFlow):
3110         (WebCore::InspectorCSSAgent::getNamedFlowCollection):
3111         (WebCore::InspectorCSSAgent::getFlowByName):
3112         (WebCore):
3113         * inspector/InspectorCSSAgent.h:
3114         (InspectorCSSAgent):
3115         * inspector/InspectorInstrumentation.cpp:
3116         (WebCore):
3117         (WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
3118         (WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):
3119         * inspector/InspectorInstrumentation.h:
3120         (InspectorInstrumentation):
3121         (WebCore::InspectorInstrumentation::didCreateNamedFlow):
3122         (WebCore::InspectorInstrumentation::didRemoveNamedFlow):
3123         * inspector/front-end/CSSStyleModel.js:
3124         (WebInspector.CSSStyleModel):
3125         (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
3126         (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
3127         (WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
3128         (WebInspector.CSSStyleModel.prototype._namedFlowCreated):
3129         (WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
3130         (WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
3131         (WebInspector.CSSDispatcher.prototype.namedFlowCreated):
3132         (WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
3133         (WebInspector.NamedFlow):
3134         (WebInspector.NamedFlow.parsePayloadArray):
3135         * rendering/RenderNamedFlowThread.cpp:
3136         (WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
3137
3138 2012-09-04  Simon Fraser  <simon.fraser@apple.com>
3139
3140         Regression: Heap-use-after-free in WebCore::FrameView::scrollContentsFastPath
3141         https://bugs.webkit.org/show_bug.cgi?id=95754
3142
3143         Reviewed by Dave Hyatt.
3144
3145         It's possible to have a renderer with position:fixed or sticky style,
3146         but no layer, for example a RenderScrollBarPart. Don't register such
3147         renderers with the FrameView.
3148         
3149         Moved the code that registers/unregisters with the FrameView from
3150         styleWillChange() to styleDidChange(), since in the latter case
3151         we can check if we have a RenderLayer. Only register renderers with layers.
3152         We always unregister, which required removing an assertion in
3153         FrameView::removeFixedObject(), and replacing it with a null check of m_fixedObjects.
3154
3155         Test: fast/css/remove-fixed-resizer-crash.html
3156
3157         * page/FrameView.cpp:
3158         (WebCore::FrameView::removeFixedObject):
3159         * rendering/RenderBoxModelObject.cpp:
3160         (WebCore::RenderBoxModelObject::styleWillChange):
3161         (WebCore::RenderBoxModelObject::styleDidChange):
3162
3163 2012-09-04  Dominik Röttsches  <dominik.rottsches@intel.com>
3164
3165         ResourceErrorBase needs to identify timeouts
3166         https://bugs.webkit.org/show_bug.cgi?id=95755
3167
3168         Reviewed by Alexey Proskuryakov.
3169
3170         Adding a property to check whether this ResourceError was raised due to a timeout.
3171         This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
3172         I need to identify some layers up whether the original network problem has been a timeout.
3173
3174         No new tests, no change in behavior yet.
3175
3176         * platform/network/ResourceErrorBase.cpp:
3177         (WebCore::ResourceErrorBase::copy): Copying new member.
3178         (WebCore::ResourceErrorBase::compare): Comparing new member.
3179         * platform/network/ResourceErrorBase.h:
3180         (WebCore::ResourceErrorBase::setIsTimeout): New setter.
3181         (WebCore::ResourceErrorBase::isTimeout): New getter.
3182         (ResourceErrorBase),
3183         (WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.
3184
3185 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3186
3187         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3188         https://bugs.webkit.org/show_bug.cgi?id=95721
3189
3190         Reviewed by Adam Barth.
3191
3192         This allows the platform implementor to throw an NOT_SUPPORTED_ERR exception if it doesn support these methods.
3193
3194         Patch covered by expanded existing test.
3195
3196         * Modules/mediastream/MediaStreamTrackList.cpp:
3197         (WebCore::MediaStreamTrackList::add):
3198         (WebCore::MediaStreamTrackList::remove):
3199         * platform/mediastream/MediaStreamCenter.h:
3200         (MediaStreamCenter):
3201         * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
3202         (WebCore::MediaStreamCenterBlackBerry::didAddMediaStreamTrack):
3203         (WebCore):
3204         (WebCore::MediaStreamCenterBlackBerry::didRemoveMediaStreamTrack):
3205         * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
3206         (MediaStreamCenterBlackBerry):
3207         * platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
3208         (WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
3209         (WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):
3210         * platform/mediastream/chromium/MediaStreamCenterChromium.h:
3211         (MediaStreamCenterChromium):
3212         * platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
3213         (WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
3214         (WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):
3215         * platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
3216         (MediaStreamCenterGStreamer):
3217
3218 2012-09-04  Joanmarie Diggs  <jdiggs@igalia.com>
3219
3220         [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
3221         https://bugs.webkit.org/show_bug.cgi?id=95740
3222
3223         Reviewed by Martin Robinson.
3224
3225         Added sanity check to be sure we have a render object prior to seeing if
3226         said object is an anonymous block.
3227
3228         Testing via unit test because a non-flaky layout test crasher could not
3229         be found.
3230
3231         * accessibility/gtk/AccessibilityObjectAtk.cpp:
3232         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
3233         Sanity check for render object added.
3234
3235 2012-09-04  Christophe Dumez  <christophe.dumez@intel.com>
3236
3237         Automatic features should work in sandboxed iframes if "allow-scripts" flag is set
3238         https://bugs.webkit.org/show_bug.cgi?id=93961
3239
3240         Reviewed by Adam Barth.
3241
3242         Allow automatic features (video autoplay and form control
3243         autofocus) in a sandboxed iframe that has "allow-scripts"
3244         flag set. This behavior is according to the latest
3245         specification at:
3246         http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin
3247
3248         This sandboxed automatic features browsing context flag is
3249         relaxed by the same keyword as scripts, because when
3250         scripts are enabled these features are trivially possible
3251         anyway, and it would be unfortunate to force authors to
3252         use script to do them when sandboxed rather than allowing
3253         them to use the declarative features.
3254
3255         Tests: fast/forms/autofocus-in-sandbox-with-allow-scripts.html
3256                media/auto-play-in-sandbox-with-allow-scripts.html
3257
3258         * dom/SecurityContext.cpp:
3259         (WebCore::SecurityContext::parseSandboxPolicy):
3260
3261 2012-09-04  Sami Kyostila  <skyostil@google.com>
3262
3263         Register scrolling layers with ScrollingCoordinator
3264         https://bugs.webkit.org/show_bug.cgi?id=78862
3265
3266         Reviewed by James Robinson.
3267
3268         In order to allow scrollable child layers to be scrolled off the main
3269         thread, register them with the ScrollingCoordinator. These layers are
3270         also removed from the non-fast scrollable region.
3271
3272         Whenever the scroll offset or other scroll geometry related attribute of
3273         a compositor scrolled layer changes, the ScrollingCoordinator is
3274         informed to allow it to update its internal representation of the
3275         scrollable layer.
3276
3277         No tests because the ScrollingCoordinator is currently not testable.
3278
3279         * page/scrolling/ScrollingCoordinator.cpp:
3280         (WebCore::computeNonFastScrollableRegion): Composited scrolling layers
3281         can be scrolled off the main thread.
3282         (WebCore):
3283         (WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
3284         Callback to ScrollingCoordinator about changes the composited scrolling layers.
3285         * page/scrolling/ScrollingCoordinator.h:
3286         (WebCore):
3287         (ScrollingCoordinator):
3288         * page/scrolling/ScrollingCoordinatorNone.cpp:
3289         (WebCore):
3290         (WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
3291         * platform/ScrollableArea.h:
3292         (WebCore::ScrollableArea::usesCompositedScrolling):
3293         * rendering/RenderLayer.cpp:
3294         (WebCore):
3295         (WebCore::RenderLayer::usesCompositedScrolling):
3296         * rendering/RenderLayer.h:
3297         (RenderLayer):
3298         (WebCore::RenderLayer::usesCompositedScrolling):
3299         * rendering/RenderLayerBacking.cpp:
3300         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
3301         (WebCore::RenderLayerBacking::updateScrollingLayers):
3302         * rendering/RenderLayerCompositor.cpp:
3303         (WebCore::RenderLayerCompositor::scrollingLayerDidChange):
3304         (WebCore):
3305         * rendering/RenderLayerCompositor.h:
3306         (RenderLayerCompositor):
3307
3308 2012-09-04  Brian Anderson  <brianderson@chromium.org>
3309
3310         [chromium] Do not allow infinite pending frames in CCFrameRateController
3311         https://bugs.webkit.org/show_bug.cgi?id=94254
3312
3313         Reviewed by James Robinson.
3314
3315         Removes support for infinite pending frames in CCFrameRateController
3316         if swap acks are available.        
3317
3318         Functionality covered by existing tests.
3319
3320         * platform/graphics/chromium/cc/CCFrameRateController.cpp:
3321         (WebCore::CCFrameRateController::CCFrameRateController):
3322         (WebCore::CCFrameRateController::setMaxFramesPending):
3323         (WebCore::CCFrameRateController::setSwapBuffersCompleteSupported):
3324         (WebCore):
3325         (WebCore::CCFrameRateController::onTimerTick):
3326         (WebCore::CCFrameRateController::didBeginFrame):
3327         (WebCore::CCFrameRateController::didFinishFrame):
3328         * platform/graphics/chromium/cc/CCFrameRateController.h:
3329         (CCFrameRateController):
3330         * platform/graphics/chromium/cc/CCScheduler.cpp:
3331         (WebCore::CCScheduler::setSwapBuffersCompleteSupported):
3332         (WebCore):
3333         * platform/graphics/chromium/cc/CCScheduler.h:
3334         (CCScheduler):
3335         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
3336         (WebCore::CCThreadProxy::initializeRendererOnImplThread):
3337
3338 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3339
3340         ASSERTion failure when SVG element is removed from document and readded
3341         https://bugs.webkit.org/show_bug.cgi?id=95517
3342         <rdar://problem/12175583>
3343
3344         Reviewed by Brady Eidson.
3345
3346         Previously, SVG animations would cease to animate when their parent
3347         <svg> element was removed and re-added to the document.
3348
3349         Instead, to match Firefox and Opera, we should continue the animation
3350         with the same beginTime (i.e. the animation continues as if it had never
3351         been removed from the document).
3352
3353         Test: svg/animations/reinserting-svg-into-document.html
3354
3355         * svg/SVGSVGElement.cpp:
3356         (WebCore::SVGSVGElement::insertedInto): Don't call begin() on an already-started SMILTimeContainer().
3357         * svg/animation/SMILTimeContainer.cpp: 
3358         (WebCore::SMILTimeContainer::isStarted): Added.
3359         * svg/animation/SMILTimeContainer.h: Add isStarted().
3360         * svg/animation/SVGSMILElement.cpp:
3361         (WebCore::SVGSMILElement::insertedInto): Always reschedule SVGSMILElements with
3362         their parent SMILTimeContainer when they are inserted into the document, otherwise
3363         they are lost (and never again update) when their subtree is removed and then
3364         readded to the document.
3365
3366 2012-09-04  Andrei Bucur  <abucur@adobe.com>
3367
3368         [CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion.
3369         https://bugs.webkit.org/show_bug.cgi?id=95645
3370
3371         Reviewed by Abhishek Arya.
3372
3373         This patch cleans up the render named flow thread before destruction by unregistering left-over content nodes.
3374
3375         Tests: fast/regions/moved-content-node-crash.html
3376
3377         * rendering/RenderNamedFlowThread.cpp:
3378         (WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
3379
3380 2012-09-04  Koji Ishii  <kojiishi@gmail.com>
3381
3382         [chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium
3383         https://bugs.webkit.org/show_bug.cgi?id=95744
3384
3385         Patch by Koji Ishii <kojiishi@gmail.com> on 2012-09-04
3386         Unreviewed build fix, verified by Scott Graham.
3387
3388         The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant
3389         because '/opentype/' was already included to webcore_remaining.
3390         It was not only redundant but also breaks incremental linking.
3391
3392         No new tests are required because no behavior changes.
3393
3394         * WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform.
3395
3396 2012-09-04  Otto Derek Cheung  <otcheung@rim.com>
3397
3398         [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
3399         https://bugs.webkit.org/show_bug.cgi?id=95747
3400
3401         PR199729
3402
3403         Reviewed by Rob Buis.
3404         Internally Reviewed by Joe Mason.
3405
3406         If the browser has never saved a secure protocol cookie in its mapping before,
3407         and it tries to set and retreive a secure cookie over a non-secure
3408         protocol, it will not show up because the link between the secure and
3409         non-secure mapping isn't created until a cookie (sent through secure) is set.
3410
3411         The fix is to also check for the linkage in getRawCookies. Note that we cannot
3412         map the secure CookieMap to the non-secure one because getRawCookies is a const
3413         function.
3414
3415         Manually tested using our Browser Test suite.
3416
3417         * platform/blackberry/CookieManager.cpp:
3418         (WebCore::CookieManager::getRawCookies):
3419
3420 2012-09-04  Philippe Normand  <pnormand@igalia.com>
3421
3422         [GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
3423         https://bugs.webkit.org/show_bug.cgi?id=95751
3424
3425         Reviewed by Martin Robinson.
3426
3427         In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
3428         gst_message_new_duration was renamed to
3429         gst_message_new_duration_changed.
3430
3431         However the only place where we used this is in the HTTP source
3432         element and only if appsrc < 0.10.27 is used at runtime. In the
3433         case of GStreamer 1.0 this condition will be always false so we
3434         can disable this code at build time.
3435
3436         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
3437         (StreamingClient::didReceiveResponse):
3438
3439 2012-09-04  Andrei Poenaru  <poenaru@adobe.com>
3440
3441         Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
3442         https://bugs.webkit.org/show_bug.cgi?id=93443
3443
3444         Reviewed by Pavel Feldman.
3445
3446         Added "regionLayoutUpdate" event to the protocol.
3447
3448         Removed "getFlowByName" from protocol.
3449
3450         The front-end keeps in sync the requested Named Flow Collections.
3451
3452         Modified existing test: inspector/styles/protocol-css-regions-commands.html
3453
3454         * dom/NamedFlowCollection.cpp:
3455         (WebCore::NamedFlowCollection::ensureFlowWithName):
3456         (WebCore::NamedFlowCollection::discardNamedFlow):
3457         * inspector/Inspector.json:
3458         * inspector/InspectorCSSAgent.cpp:
3459         (WebCore::InspectorCSSAgent::didCreateNamedFlow):
3460         (WebCore::InspectorCSSAgent::willRemoveNamedFlow):
3461         (WebCore):
3462         (WebCore::InspectorCSSAgent::didUpdateRegionLayout):
3463         (WebCore::InspectorCSSAgent::getNamedFlowCollection):
3464         (WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
3465         * inspector/InspectorCSSAgent.h:
3466         (InspectorCSSAgent):
3467         * inspector/InspectorInstrumentation.cpp:
3468         (WebCore):
3469         (WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
3470         (WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
3471         (WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
3472         * inspector/InspectorInstrumentation.h:
3473         (InspectorInstrumentation):
3474         (WebCore::InspectorInstrumentation::didCreateNamedFlow):
3475         (WebCore::InspectorInstrumentation::willRemoveNamedFlow):