Remove redundant helper from RenderRegion.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2013-06-22  Zalan Bujtas  <zalan@apple.com>
2
3         Remove redundant helper from RenderRegion.
4         https://bugs.webkit.org/show_bug.cgi?id=117915
5
6         Reviewed by Andreas Kling.
7
8         Minor code cleanup.
9
10         * rendering/RenderRegion.cpp:
11         (WebCore::RenderRegion::regionOversetState):
12         (WebCore::RenderRegion::setRegionOversetState):
13         * rendering/RenderRegion.h:
14
15 2013-06-22  Mark Rowe  <mrowe@apple.com>
16
17         Build fix after r151878.
18
19         * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
20         (WebCore::WebCoreAVFResourceLoader::startLoading): Pass the new UseDefaultOriginRestrictionsForType
21         argument to the ResourceLoaderOptions constructor.
22
23 2013-06-22  Simon Fraser  <simon.fraser@apple.com>
24
25         Followup from r151877 .
26         Fix crash in fast/frames/iframe-access-screen-of-deleted.html by null-checking the widget.
27
28         * platform/mac/PlatformScreenMac.mm:
29         (WebCore::screenForWidget):
30
31 2013-06-22  Hans Muller  <hmuller@adobe.com>
32
33         [CSS Shapes] limit shape image values to same origin
34         https://bugs.webkit.org/show_bug.cgi?id=117610
35
36         Reviewed by Alexey Proskuryakov.
37
38         Restrict the image URL values for shape-inside and shape-outside to
39         the same origin as the document. The alpha channel of image shape values
40         will be thresholded to produce the shape's boundaries (see bug 116643)
41         so normal image access rules aren't secure enough.
42
43         Added a RequestOriginPolicy ResourceLoaderOption which is used by
44         StyleResolver::loadPendingShapeImage() to request the additional restriction.
45         The change should have no other effect although it does enable one to apply
46         the same restriction to other resources which can currently be loaded from
47         any origin - see CachedResourceLoader::canRequest().
48
49         Test: http/tests/security/shape-inside-image-origin.html
50
51         * css/CSSImageValue.cpp:
52         (WebCore::CSSImageValue::cachedImage): Add an effectively optional ResourceLoaderOptions parameter.
53         * css/CSSImageValue.h:
54         (WebCore::CSSImageValue::cachedImage): Ditto.
55         * css/StyleResolver.cpp:
56         (WebCore::StyleResolver::loadPendingShapeImage): Load the image with the default CachedResourceLoader options plus RestrictToSameOrigin.
57         (WebCore::StyleResolver::loadPendingImages): Call loadPendingShapeImage().
58         * css/StyleResolver.h:
59         * loader/DocumentLoader.cpp:
60         (WebCore::DocumentLoader::startLoadingMainResource): Update the ResourceLoaderOptions static variable.
61         * loader/NetscapePlugInStreamLoader.cpp:
62         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): Ditto.
63         * loader/ResourceLoader.h:
64         (WebCore::ResourceLoader::options):
65         * loader/ResourceLoaderOptions.h: Add RequestOriginPolicy enum.
66         (WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
67         * loader/SubresourceLoader.cpp:
68         (WebCore::SubresourceLoader::willSendRequest): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
69         * loader/cache/CachedResourceLoader.cpp:
70         (WebCore::CachedResourceLoader::requestImage):
71         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Update load() ResourceLoaderOptions.
72         (WebCore::CachedResourceLoader::canRequest): Replaced ContentSecurityPolicyCheck parameter with ResourceLoaderOptions.
73         (WebCore::CachedResourceLoader::requestResource): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
74         (WebCore::CachedResourceLoader::defaultCachedResourceOptions): Added UseDefaultOriginRestrictionsForType initializer.
75         * loader/cache/CachedResourceLoader.h:
76         * loader/icon/IconLoader.cpp:
77         (WebCore::IconLoader::startLoading): Added UseDefaultOriginRestrictionsForType intializer.
78
79 2013-06-22  Simon Fraser  <simon.fraser@apple.com>
80
81         screen.availWidth always returns width of primary display
82         https://bugs.webkit.org/show_bug.cgi?id=117863
83
84         Reviewed by Geoffrey Garen.
85
86         In WebKit2, Widgets have no platformWidget, so trying to get to the
87         NSScreen via the platform widget's window never succeeded, and we always
88         fell back on getting info for the main display.
89
90         However, we were already pushing the WKView's displayID down to the
91         WebProcess for the requestAnimationFrame infrastructure, so use that.
92
93         Add a virtual function on Widget windowDisplayID(), that is overridden
94         in FrameView to return the PlatformDisplayID which Page has.
95
96         Fix PlatformScreenMac to fall back to Widget::windowDisplayID() when it fails
97         to get an NSWindow from the Widget.
98
99         Add a utility category on NSScreen to get an NSScreen's displayID, and to
100         find an NSScreen given a displayID.
101
102         * WebCore.exp.in:
103         * WebCore.xcodeproj/project.pbxproj:
104         * page/FrameView.cpp:
105         (WebCore::FrameView::windowDisplayID):
106         * page/FrameView.h:
107         * platform/Widget.cpp:
108         (WebCore::Widget::windowDisplayID):
109         * platform/Widget.h:
110         * platform/mac/PlatformScreenMac.h: Added.
111         * platform/mac/PlatformScreenMac.mm:
112         (+[NSScreen screenForDislayID:]):
113         (-[NSScreen displayID]):
114         (WebCore::screenRect):
115         (WebCore::screenAvailableRect):
116         * platform/mac/WidgetMac.mm:
117         (WebCore::Widget::windowDisplayID):
118
119 2013-06-21  Geoffrey Garen  <ggaren@apple.com>
120
121         Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
122         https://bugs.webkit.org/show_bug.cgi?id=117903
123
124         Reviewed by Darin Adler.
125
126         * css/StyleResolver.cpp:
127         (WebCore::StyleResolver::loadPendingSVGDocuments): Add a NULL check for
128         RenderStyle here...
129         (WebCore::StyleResolver::loadPendingResources): ...and here.
130
131 2013-06-21  Simon Fraser  <simon.fraser@apple.com>
132
133         Occasional crash swiping between pages
134         https://bugs.webkit.org/show_bug.cgi?id=117902
135
136         Reviewed by Beth Dakin.
137
138         m_scrollingStateTree->rootStateNode() can be null when quickly swiping between pages,
139         so check this in ScrollingCoordinatorMac::commitTreeState().
140
141         * page/scrolling/mac/ScrollingCoordinatorMac.mm:
142         (WebCore::ScrollingCoordinatorMac::commitTreeState):
143
144 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
145
146         AX: Title for ListItemRole should consist of concatenated child text elements.
147         https://bugs.webkit.org/show_bug.cgi?id=117892
148
149         Reviewed by Chris Fleizach.
150
151         accessibility/listitem-title.html
152
153         * accessibility/AccessibilityNodeObject.cpp:
154         (WebCore::AccessibilityNodeObject::visibleText): Add ListItemRole to set of
155         elements that concatenate their children for display purposes.
156         (WebCore::AccessibilityNodeObject::title): Ditto.
157
158 2013-06-21  Sergio Correia  <sergio.correia@openbossa.org>
159
160         [MediaStream]: Remove ``>= 0'' assertion from a size_t variable
161         https://bugs.webkit.org/show_bug.cgi?id=117890
162
163         Reviewed by Adam Barth.
164
165         This patch fixes a strict build by removing the ``>= 0'' assertion from
166         a size_t (unsigned type) variable in RTCStatsResponse.cpp.
167
168         No new tests; build fix.
169
170         * Modules/mediastream/RTCStatsResponse.cpp:
171         (WebCore::RTCStatsResponse::addStatistic): Remove ``>=0''assertion,
172         since the variable is unsigned and is always >= 0.
173
174 2013-06-21  Alex Christensen  <achristensen@apple.com>
175
176         GraphicsContext3DNEON.h cannot be found on Windows and does not need to be found.
177         https://bugs.webkit.org/show_bug.cgi?id=117894
178
179         Reviewed by Brent Fulgham.
180
181         * platform/graphics/GraphicsContext3D.cpp:
182         Added #if HAVE(ARM_NEON_INTRINSICS) around #include "GraphicsContext3DNEON.h"
183
184 2013-06-21  Robert Hogan  <robert@webkit.org>
185
186         Ignoring padding-right of inline elements in containers with undefined width
187         https://bugs.webkit.org/show_bug.cgi?id=76451
188
189         Reviewed by David Hyatt.
190
191         Collapsed trailing space on a normal wrap line should not cause a line-break 
192         if it is the difference between fitting on the line and breaking. Likewise, on a line that
193         has a mix of auto-wrap and no-wrap inlines we don't want a trailing space at the end of a no-wrap inline
194         to be the difference between that no-wrap inline fitting or breaking the line. This latter
195         scenario is covered already by inline-whitespace-wrapping-8.html.
196
197         Test: fast/text/whitespace/inline-whitespace-wrapping-9.html
198
199         * rendering/RenderBlockLineLayout.cpp:
200         (WebCore::LineWidth::fitsOnLine):
201         (WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
202         (WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
203         (WebCore::LineWidth::currentWidth):
204         (WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
205         (WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
206
207 2013-06-21  Alex Christensen  <achristensen@apple.com>
208
209         Added WebGL source files to Windows build and made Windows build successfully with them.
210         https://bugs.webkit.org/show_bug.cgi?id=117853
211
212         Reviewed by Brent Fulgham.
213
214         * WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
215         * WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.
216         * WebCore.vcxproj/WebCorePreBuild.cmd: Copy ANGLE headers and glext.h before building WebCore (which now uses them).
217         * platform/graphics/ANGLEWebKitBridge.h: Look in newly copied directory for ShaderLang.h.
218         * platform/graphics/OpenGLShims.h: Include GL/glext.h.
219         * platform/graphics/gpu/LoopBlinnShader.cpp: 
220         (WebCore::LoopBlinnShader::use): Fixed parameter ordering in call to uniformMatrix4fv.
221         * platform/graphics/opengl/GLPlatformSurface.cpp:
222         (WebCore::GLPlatformSurface::createOffScreenSurface): Added notImplemented for non-EGL builds for now.
223
224 2013-06-21  Eric Carlson  <eric.carlson@apple.com>
225
226         Update platform text track menu
227         https://bugs.webkit.org/show_bug.cgi?id=117884
228
229         Reviewed by Jer Noble.
230
231         * html/HTMLMediaElement.cpp:
232         (WebCore::HTMLMediaElement::setSelectedTextTrack):
233         * html/track/TextTrack.cpp:
234         (WebCore::TextTrack::platformTextTrack):
235         * platform/graphics/PlatformTextTrack.h:
236         (WebCore::PlatformTextTrack::create): 
237         (WebCore::PlatformTextTrack::uniqueId):
238         (WebCore::PlatformTextTrack::captionMenuOffItem):
239         (WebCore::PlatformTextTrack::captionMenuAutomaticItem):
240         (WebCore::PlatformTextTrack::PlatformTextTrack):
241
242 2013-06-21  James Craig  <james@cookiecrook.com>
243
244         AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
245         https://bugs.webkit.org/show_bug.cgi?id=117883
246
247         Reviewed by Chris Fleizach.
248
249         Some of the media controls were returning the wrong role. Updated existing test coverage.
250
251         * accessibility/AccessibilityMediaControls.h:
252         (WebCore::AccessibilityMediaTimeDisplay::roleValue):
253
254 2013-06-21  Alex Christensen  <achristensen@apple.com>
255
256         Added glext.h from http://www.opengl.org/registry/oldspecs/glext.h for Windows
257         This file does not meet WebKit style guidelines.
258         Part of https://bugs.webkit.org/show_bug.cgi?id=117853
259         
260         Reviewed by Brent Fulgham.
261
262         * platform/graphics/win/GL: Added.
263         * platform/graphics/win/GL/glext.h: Added.
264
265 2013-06-21  Ruth Fong  <ruth_fong@apple.com>
266
267         Fix TextTrackCue::cueIndex() to handle the null case of TextTrack::cues(() properly
268         https://bugs.webkit.org/show_bug.cgi?id=117815
269         <rdar://problem/14211041> 
270
271         Reviewed by Ryosuke Niwa.
272
273         This patch adds assert statements to try to catch when 
274         track()->cues() returns a null pointer.
275
276         * html/track/TextTrackCue.cpp:
277         (WebCore::TextTrackCue::cueIndex):
278
279 2013-06-21  Jer Noble  <jer.noble@apple.com>
280
281         [iOS] Hang drawing captions after pressing the home button while playing a video
282         https://bugs.webkit.org/show_bug.cgi?id=117882
283
284         Reviewed by Eric Carlson.
285
286         Instead of rendering in a callback on the main thread, pre-render the captions and pass to the main
287         thread as a CGImage. As such, rename paintTextTrackRepresentation() to createTextTrackRepresentationImage().
288
289         * html/shadow/MediaControlElements.cpp:
290         (WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage): Renamed from
291             paintTextTrackRepresentation. Now returns an Image object.
292         * html/shadow/MediaControlElements.h:
293         * platform/graphics/MediaPlayer.h:
294         * platform/graphics/TextTrackRepresentation.h:
295
296 2013-06-21  Radu Stavila  <stavila@adobe.com>
297
298         [CSS Regions] Move overset compute code from flow thread to named flow thread
299         https://bugs.webkit.org/show_bug.cgi?id=117835
300
301         Reviewed by Andreas Kling.
302
303         Moved computeOversetStateForRegions() and overset() methods from RenderFlowThread to RenderNamedFlowThread. 
304         Added ASSERTS in RenderRegion::regionOversetState and RenderRegion::setRegionOversetState to ensure
305         the region was created from an element.
306
307         * rendering/RenderBlock.cpp:
308         (WebCore::RenderBlock::computeOverflow):
309         * rendering/RenderFlowThread.cpp:
310         (WebCore::RenderFlowThread::RenderFlowThread):
311         * rendering/RenderFlowThread.h:
312         * rendering/RenderNamedFlowThread.cpp:
313         (WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
314         (WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
315         * rendering/RenderNamedFlowThread.h:
316         (WebCore::RenderNamedFlowThread::overset):
317         * rendering/RenderRegion.cpp:
318         (WebCore::RenderRegion::regionOversetState):
319         (WebCore::RenderRegion::setRegionOversetState):
320
321 2013-06-21  Commit Queue  <commit-queue@webkit.org>
322
323         Unreviewed, rolling out r151838.
324         http://trac.webkit.org/changeset/151838
325         https://bugs.webkit.org/show_bug.cgi?id=117880
326
327         Breaks MediaPlayerPrivateQt on Mac (Requested by carewolf on
328         #webkit).
329
330         * html/HTMLMediaElement.h:
331
332 2013-06-20  Brent Fulgham  <bfulgham@apple.com>
333
334         [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs
335         https://bugs.webkit.org/show_bug.cgi?id=117837
336
337         Reviewed by Chris Fleizach.
338
339         accessibility/aria-tab-role-on-buttons.html
340
341         * accessibility/AccessibilityNodeObject.cpp:
342         (WebCore::AccessibilityNodeObject::canSetSelectedAttribute): Indicate that certain accessibility
343         types (such as Tabs) can be selected.
344         * accessibility/AccessibilityNodeObject.h: Signature for canSelectAttribute override.
345
346 2013-06-21  Allan Sandfeld Jensen  <allan.jensen@digia.com>
347
348         Remove unused GesturePinch events
349         https://bugs.webkit.org/show_bug.cgi?id=117875
350
351         Reviewed by Andreas Kling.
352
353         The gesturePinch events have not been used for some time, even Chromium
354         had stop using them before moving out of webkit.
355
356         * dom/GestureEvent.cpp:
357         (WebCore::GestureEvent::create):
358         * page/EventHandler.cpp:
359         (WebCore::EventHandler::handleGestureEvent):
360         * platform/PlatformEvent.h:
361
362 2013-06-21  Radu Stavila  <stavila@adobe.com>
363
364         Improve the reattaching process while applying the :hover style
365         https://bugs.webkit.org/show_bug.cgi?id=117590
366
367         Reviewed by Andreas Kling.
368
369         Changes made:
370             - context is properly propagated to the element's children and to Shadow DOM elements.
371             - context is properly set on the lazyReattach method.
372             - another hit-testing is triggered when needed.
373             - when a hovered element is detached, it's ancestors are also removed from the hovered state.
374
375         Tests: fast/css/hover-display-block-inline.html
376                fast/css/hover-display-block-none.html
377
378         * dom/ContainerNode.cpp:
379         (WebCore::ContainerNode::attach):
380         (WebCore::ContainerNode::detach):
381         * dom/ContainerNode.h:
382         (WebCore::ContainerNode::attachChildren):
383         (WebCore::ContainerNode::detachChildrenIfNeeded):
384         (WebCore::ContainerNode::detachChildren):
385         * dom/Document.cpp:
386         (WebCore::Document::recalcStyle):
387         (WebCore::Document::updateHoverActiveState):
388         * dom/Element.cpp:
389         (WebCore::Element::attach):
390         (WebCore::Element::detach):
391         * dom/ElementShadow.cpp:
392         (WebCore::ElementShadow::attach):
393         (WebCore::ElementShadow::detach):
394         * dom/ElementShadow.h:
395         * dom/Node.h:
396         (WebCore::Node::lazyReattach):
397
398 2013-06-21  Allan Sandfeld Jensen  <allan.jensen@digia.com>
399
400         HTMLMediaElement should inherit from MediaPlayerClient privately
401         https://bugs.webkit.org/show_bug.cgi?id=117874
402
403         Reviewed by Andreas Kling.
404
405         Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
406         MediaPlayerClient due to the Chromium port.
407         This can now be fixed to a private inheritance.
408
409         * html/HTMLMediaElement.h:
410
411 2013-06-21  Allan Sandfeld Jensen  <allan.jensen@digia.com>
412
413         Remove Chromium-only TouchDisambiguation
414         https://bugs.webkit.org/show_bug.cgi?id=117873
415
416         Reviewed by Andreas Kling.
417
418         * page/TouchDisambiguation.cpp: Removed.
419         * page/TouchDisambiguation.h: Removed.
420
421 2013-06-21  Zalan Bujtas  <zalan@apple.com>
422
423         Rollout r150602: Restoring text-overflow vs. floating rendering behaviour.
424         https://bugs.webkit.org/show_bug.cgi?id=117871
425
426         Unreviewed. Rolling out r150602.
427         Undesirable rendering behaviour.
428
429         * rendering/RenderBlockLineLayout.cpp:
430         (WebCore::RenderBlock::checkLinesForTextOverflow):
431
432 2013-06-21  Radu Stavila  <stavila@adobe.com>
433
434         Web Inspector: Integrate new regionOversetChange event into inspector
435         https://bugs.webkit.org/show_bug.cgi?id=117833
436
437         Added the new regionOversetChange event to the WebInspector.
438
439         Reviewed by Joseph Pecoraro.
440
441         Tests:  inspector/styles/protocol-css-regions-commands.html:
442
443         * inspector/Inspector.json:
444         * inspector/InspectorCSSAgent.cpp:
445         (WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
446         (WebCore::ChangeRegionOversetTask::scheduleFor):
447         (WebCore::ChangeRegionOversetTask::unschedule):
448         (WebCore::ChangeRegionOversetTask::reset):
449         (WebCore::ChangeRegionOversetTask::onTimer):
450         (WebCore::InspectorCSSAgent::resetNonPersistentData):
451         (WebCore::InspectorCSSAgent::willRemoveNamedFlow):
452         (WebCore::InspectorCSSAgent::didChangeRegionOverset):
453         (WebCore::InspectorCSSAgent::regionOversetChanged):
454         * inspector/InspectorCSSAgent.h:
455         * inspector/InspectorInstrumentation.cpp:
456         (WebCore::InspectorInstrumentation::didChangeRegionOversetImpl):
457         * inspector/InspectorInstrumentation.h:
458         (WebCore::InspectorInstrumentation::didChangeRegionOverset):
459         * inspector/front-end/CSSNamedFlowCollectionsView.js:
460         (WebInspector.CSSNamedFlowCollectionsView.prototype._regionOversetChanged):
461         (WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):
462         (WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):
463         * inspector/front-end/CSSStyleModel.js:
464         (WebInspector.CSSStyleModel.prototype._regionOversetChanged):
465         (WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
466         (WebInspector.CSSDispatcher.prototype.regionOversetChanged):
467         * rendering/RenderNamedFlowThread.cpp:
468         (WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
469
470 2013-06-21  Sergio Correia  <sergio.correia@openbossa.org>
471
472         [EFL] NetworkStateNotifierEfl: Use closeWithRetry instead of looping for EINTR on close
473         https://bugs.webkit.org/show_bug.cgi?id=117872
474
475         Reviewed by Christophe Dumez.
476
477         closeWithRetry works around the Linux behavior of closing the file descriptor
478         unconditionally even if the close() call is interrupted.
479
480         No new tests, no behavior change.
481
482         * platform/network/efl/NetworkStateNotifierEfl.cpp:
483         (WebCore::NetworkStateNotifier::~NetworkStateNotifier): Use closeWithRetry instead of
484         looping for EINTR on close.
485
486 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
487
488         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
489         https://bugs.webkit.org/show_bug.cgi?id=117825
490
491         Reviewed by Kentaro Hara.
492
493         Partially revert r150663 so that we use Settings to enable WebAudio instead of
494         RuntimeEnabledFeatures.
495
496         Introduce a new [EnabledBySetting] IDL extended attribute which behaves similarly to
497         the existing [EnabledAtRuntime] but relies on Settings instead of RuntimeEnabledFeatures
498         to determine if the feature should be enabled. Make use of this new IDL attribute for
499         webkitAudioContext interface.
500
501         No new tests, no behavior change.
502
503         * Modules/webaudio/AudioContext.idl:
504         * WebCore.exp.in:
505         * WebCore.order:
506         * bindings/generic/RuntimeEnabledFeatures.cpp:
507         * bindings/generic/RuntimeEnabledFeatures.h:
508         * bindings/scripts/CodeGeneratorJS.pm:
509         (GenerateImplementation):
510         * bindings/scripts/IDLAttributes.txt:
511         * bindings/scripts/preprocess-idls.pl:
512         (GenerateConstructorAttribute):
513         * bindings/scripts/test/JS/JSTestObj.cpp:
514         (WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
515         (WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
516         * bindings/scripts/test/JS/JSTestObj.h:
517         * bindings/scripts/test/ObjC/DOMTestObj.h:
518         * bindings/scripts/test/ObjC/DOMTestObj.mm:
519         (-[DOMTestObj TestSubObjEnabledBySetting]):
520         (-[DOMTestObj setTestSubObjEnabledBySetting:]):
521         * bindings/scripts/test/TestObj.idl:
522         * page/Settings.in:
523
524 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
525
526         [ATK] Added support for aria-required attribute.
527         https://bugs.webkit.org/show_bug.cgi?id=117730
528
529         Reviewed by Chris Fleizach.
530
531         Tests: accessibility/aria-required.html
532                accessibility/html5-required-attribute.html
533
534         The aria-required attribute is used to indicate that user input is required on an
535         element before a form can be submitted.
536
537         * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
538         (setAtkStateSetFromCoreObject):
539
540 2013-06-21  Chris Fleizach  <cfleizach@apple.com>
541
542         IndieUI: Add basic IndieUI infrastructure
543         https://bugs.webkit.org/show_bug.cgi?id=117367
544
545         Unreviewed. Revert erroneous file that was included accidentally.
546
547         * accessibility/AccessibilityNodeObject.h:
548
549 2013-06-21  Chris Fleizach  <cfleizach@apple.com>
550
551         IndieUI: Add basic IndieUI infrastructure
552         https://bugs.webkit.org/show_bug.cgi?id=117367
553
554         Reviewed by Ryosuke Niwa.
555
556         IndieUI is a new W3C spec that aims to abstract the connection between input and action, so that
557         a user (possibly using assistive technologies like a screen reader) does not need a specific kind
558         of device (like a mouse) to interact with an object.
559         http://www.w3.org/WAI/IndieUI/
560
561         This initial patch adds in the basic support for UIRequestEvent and the uiactions attribute.
562         It modifies the config files to enable and build this feature.
563
564         Tests: indieui/create-uirequestevent.html
565                indieui/uiactions.html
566
567         * CMakeLists.txt:
568         * Configurations/FeatureDefines.xcconfig:
569         * DerivedSources.make:
570         * GNUmakefile.am:
571         * Modules/indieui: Added.
572         * Modules/indieui/UIRequestEvent.cpp: Added.
573         (WebCore::UIRequestEventInit::UIRequestEventInit):
574         (WebCore::UIRequestEvent::create):
575         (WebCore::UIRequestEvent::UIRequestEvent):
576         (WebCore::UIRequestEvent::~UIRequestEvent):
577         (WebCore::UIRequestEvent::interfaceName):
578         (WebCore::UIRequestEventDispatchMediator::UIRequestEventDispatchMediator):
579         (WebCore::UIRequestEventDispatchMediator::event):
580         (WebCore::UIRequestEventDispatchMediator::dispatchEvent):
581         * Modules/indieui/UIRequestEvent.h: Added.
582         (WebCore::UIRequestEvent::receiver):
583         (WebCore::UIRequestEventDispatchMediator::create):
584         * Modules/indieui/UIRequestEvent.idl: Added.
585         * WebCore.xcodeproj/project.pbxproj:
586         * accessibility/AccessibilityNodeObject.h:
587         * dom/Element.cpp:
588         (WebCore::Element::setUIActions):
589         (WebCore::Element::UIActions):
590         * dom/Element.h:
591         * dom/Element.idl:
592         * dom/Event.cpp:
593         (WebCore::EventInit::EventInit):
594         * dom/Event.h:
595         * dom/EventNames.in:
596         * dom/Node.cpp:
597         (WebCore::Node::dispatchUIRequestEvent):
598         * dom/Node.h:
599         * dom/UIEvent.cpp:
600         (WebCore::UIEventInit::UIEventInit):
601         * dom/UIEvent.h:
602         * html/HTMLAttributeNames.in:
603
604 2013-06-20  Ryosuke Niwa  <rniwa@webkit.org>
605
606         REGRESSION(r145788): mouse drag on canvas shouldn't start selection
607         https://bugs.webkit.org/show_bug.cgi?id=117860
608
609         Reviewed by Benjamin Poulain.
610
611         Like HTMLImageElement, HTMLCanvasElement shouldn't start selection.
612
613         Also uninline some virtual function overrides.
614
615         Test: fast/events/mosuedrag-on-canvas-should-not-start-selection.html
616
617         * html/HTMLCanvasElement.cpp:
618         (WebCore::HTMLCanvasElement::areAuthorShadowsAllowed):
619         (WebCore::HTMLCanvasElement::canContainRangeEndPoint):
620         (WebCore::HTMLCanvasElement::canStartSelection):
621         * html/HTMLCanvasElement.h:
622
623 2013-06-20  Ryosuke Niwa  <rniwa@webkit.org>
624
625         REGRESSION(r149652): accessing items in .children via id doesn't work when element is not rooted in DOM tree
626         https://bugs.webkit.org/show_bug.cgi?id=117836
627
628         Reviewed by Benjamin Poulain.
629
630         When the root node of a HTML collection is not in the document or in a shadow tree,
631         we shouldn't use its tree scope's id and name maps to find name getters.
632
633         Always use the slow path in such cases.
634
635         Test: fast/dom/htmlallcollection-detached-node-children.html
636
637         * html/HTMLCollection.cpp:
638         (WebCore::HTMLCollection::namedItem):
639
640 2013-06-20  Alexey Proskuryakov  <ap@apple.com>
641
642         https://bugs.webkit.org/show_bug.cgi?id=116495
643         Fix null-pointer deref in DocumentLoader::responseReceived()
644
645         Patch by Nate Chapin, reviewed by Mike West and myself.
646
647         Test: http/tests/security/XFrameOptions/x-frame-options-deny-delete-frame-in-load-event.html
648
649         * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::responseReceived): Added
650         a null check.
651
652 2013-06-20  Roger Fong  <roger_fong@apple.com>
653
654         Unreviewed. Roll out part of r150618.
655
656         * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
657
658 2013-06-20  Enrica Casucci  <enrica@apple.com>
659
660         Initial advance on the first glyph of the run is not correctly set for rtl text.
661         https://bugs.webkit.org/show_bug.cgi?id=117839
662         <rdar://problem/13860717>
663
664         Reviewed by Sam Weinig.
665
666         We need to set the initial advance to the glyphBuffer, using the
667         initial advance of the complex run that will be drawn first.
668         In order to choose the run correctly we must consider the text direction.
669
670         Test: fast/text/complex-first-glyph-with-initial-advance.html
671
672         * platform/graphics/mac/ComplexTextController.cpp:
673         (WebCore::ComplexTextController::advance):
674
675 2013-06-20  Alex Christensen  <achristensen@apple.com>
676
677         Fixed WebGL compile errors on Windows.
678         https://bugs.webkit.org/show_bug.cgi?id=117805
679
680         Reviewed by Brent Fulgham.
681
682         * html/canvas/WebGLRenderingContext.cpp: Included CString.h.
683         Added PLATFORM(WIN) to existing lists of platform macros.
684         * platform/graphics/ANGLEWebKitBridge.h:
685         * platform/graphics/GraphicsContext3D.h:
686         (WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):
687         * platform/graphics/OpenGLESShims.h:
688
689 2013-06-20  Simon Fraser  <simon.fraser@apple.com>
690
691         FrameView needs to initialize paintsEntireContents on creation
692         https://bugs.webkit.org/show_bug.cgi?id=117844
693
694         Reviewed by Anders Carlsson.
695
696         In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
697         In this mode, FrameView::paintsEntireContents() is true. However,
698         we would only call setPaintsEntireContents(true) on the FrameView
699         when the view's layer-backed status changes. FrameView also needs
700         to fetch this state when it is initialized, because we may be creating
701         a new FrameView for an already layer-backed WebHTMLView.
702
703         * page/ChromeClient.h:
704         (WebCore::ChromeClient::shouldPaintEntireContents):
705         * page/FrameView.cpp:
706         (WebCore::FrameView::init):
707
708 2013-06-20  Simon Fraser  <simon.fraser@apple.com>
709
710         Sticky elements are missing or misplaced sometimes when reloading a page that scrolls to a named anchor
711         https://bugs.webkit.org/show_bug.cgi?id=117819
712
713         Reviewed by Anders Carlsson.
714         
715         At the end of FrameView::performPostLayoutTasks() we call scrollToAnchor() which attempts
716         to restore the scroll position to a named anchor, even when the document has been
717         changed by layout. This ends up in a call to ScrollView::scrollTo(), which in turn
718         calls repaintFixedElementsAfterScrolling(). However, repaintFixedElementsAfterScrolling()
719         would bail if m_nestedLayoutCount != 0, so we never updated layer positions which
720         depend on scroll position (but which would not be updated by layout, since their
721         renderers are not marked for layout when scrolling happens).
722         
723         We've solved this problem once before in updateFixedElementsAfterScrolling() which
724         checks for m_nestedLayoutCount <= 1, so that we do work on the outermost nested layout.
725         Apply that same fix to repaintFixedElementsAfterScrolling().
726
727         Very timing-dependent, so hard to make a test.
728
729         * page/FrameView.cpp:
730         (WebCore::FrameView::repaintFixedElementsAfterScrolling):
731
732 2013-06-20  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
733
734         HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
735         https://bugs.webkit.org/show_bug.cgi?id=117830
736
737         Reviewed by Anders Carlsson.
738
739         The order of the template arguments at HashSet alternate 'find', 'contains' and
740         'add' methods is reversed so that callers can just pass the translator
741         and let the compiler deduce input argument type.
742
743         No new tests. No new functionality.
744
745         * dom/QualifiedName.cpp:
746         (WebCore::QualifiedName::QualifiedName):
747         * platform/graphics/cg/SubimageCacheWithTimer.cpp:
748         (WebCore::SubimageCacheWithTimer::getSubimage):
749         * svg/SVGAElement.cpp:
750         (WebCore::SVGAElement::isSupportedAttribute):
751         * svg/SVGAnimateMotionElement.cpp:
752         (WebCore::SVGAnimateMotionElement::isSupportedAttribute):
753         * svg/SVGAnimateTransformElement.cpp:
754         (WebCore::SVGAnimateTransformElement::isSupportedAttribute):
755         * svg/SVGAnimationElement.cpp:
756         (WebCore::SVGAnimationElement::isSupportedAttribute):
757         * svg/SVGCircleElement.cpp:
758         (WebCore::SVGCircleElement::isSupportedAttribute):
759         * svg/SVGClipPathElement.cpp:
760         (WebCore::SVGClipPathElement::isSupportedAttribute):
761         * svg/SVGComponentTransferFunctionElement.cpp:
762         (WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):
763         * svg/SVGCursorElement.cpp:
764         (WebCore::SVGCursorElement::isSupportedAttribute):
765         * svg/SVGEllipseElement.cpp:
766         (WebCore::SVGEllipseElement::isSupportedAttribute):
767         * svg/SVGFEBlendElement.cpp:
768         (WebCore::SVGFEBlendElement::isSupportedAttribute):
769         * svg/SVGFEColorMatrixElement.cpp:
770         (WebCore::SVGFEColorMatrixElement::isSupportedAttribute):
771         * svg/SVGFEComponentTransferElement.cpp:
772         (WebCore::SVGFEComponentTransferElement::isSupportedAttribute):
773         * svg/SVGFECompositeElement.cpp:
774         (WebCore::SVGFECompositeElement::isSupportedAttribute):
775         * svg/SVGFEConvolveMatrixElement.cpp:
776         (WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):
777         * svg/SVGFEDiffuseLightingElement.cpp:
778         (WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):
779         * svg/SVGFEDisplacementMapElement.cpp:
780         (WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):
781         * svg/SVGFEDropShadowElement.cpp:
782         (WebCore::SVGFEDropShadowElement::isSupportedAttribute):
783         * svg/SVGFEGaussianBlurElement.cpp:
784         (WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):
785         * svg/SVGFEImageElement.cpp:
786         (WebCore::SVGFEImageElement::isSupportedAttribute):
787         * svg/SVGFELightElement.cpp:
788         (WebCore::SVGFELightElement::isSupportedAttribute):
789         * svg/SVGFEMergeNodeElement.cpp:
790         (WebCore::SVGFEMergeNodeElement::isSupportedAttribute):
791         * svg/SVGFEMorphologyElement.cpp:
792         (WebCore::SVGFEMorphologyElement::isSupportedAttribute):
793         * svg/SVGFEOffsetElement.cpp:
794         (WebCore::SVGFEOffsetElement::isSupportedAttribute):
795         * svg/SVGFESpecularLightingElement.cpp:
796         (WebCore::SVGFESpecularLightingElement::isSupportedAttribute):
797         * svg/SVGFETileElement.cpp:
798         (WebCore::SVGFETileElement::isSupportedAttribute):
799         * svg/SVGFETurbulenceElement.cpp:
800         (WebCore::SVGFETurbulenceElement::isSupportedAttribute):
801         * svg/SVGFilterElement.cpp:
802         (WebCore::SVGFilterElement::isSupportedAttribute):
803         (WebCore::SVGFilterElement::childShouldCreateRenderer):
804         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
805         (WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):
806         * svg/SVGForeignObjectElement.cpp:
807         (WebCore::SVGForeignObjectElement::isSupportedAttribute):
808         * svg/SVGGElement.cpp:
809         (WebCore::SVGGElement::isSupportedAttribute):
810         * svg/SVGGradientElement.cpp:
811         (WebCore::SVGGradientElement::isSupportedAttribute):
812         * svg/SVGImageElement.cpp:
813         (WebCore::SVGImageElement::isSupportedAttribute):
814         * svg/SVGLineElement.cpp:
815         (WebCore::SVGLineElement::isSupportedAttribute):
816         * svg/SVGLinearGradientElement.cpp:
817         (WebCore::SVGLinearGradientElement::isSupportedAttribute):
818         * svg/SVGMPathElement.cpp:
819         (WebCore::SVGMPathElement::isSupportedAttribute):
820         * svg/SVGMarkerElement.cpp:
821         (WebCore::SVGMarkerElement::isSupportedAttribute):
822         * svg/SVGMaskElement.cpp:
823         (WebCore::SVGMaskElement::isSupportedAttribute):
824         * svg/SVGPathElement.cpp:
825         (WebCore::SVGPathElement::isSupportedAttribute):
826         * svg/SVGPatternElement.cpp:
827         (WebCore::SVGPatternElement::isSupportedAttribute):
828         * svg/SVGPolyElement.cpp:
829         (WebCore::SVGPolyElement::isSupportedAttribute):
830         * svg/SVGRadialGradientElement.cpp:
831         (WebCore::SVGRadialGradientElement::isSupportedAttribute):
832         * svg/SVGRectElement.cpp:
833         (WebCore::SVGRectElement::isSupportedAttribute):
834         * svg/SVGScriptElement.cpp:
835         (WebCore::SVGScriptElement::isSupportedAttribute):
836         * svg/SVGStopElement.cpp:
837         (WebCore::SVGStopElement::isSupportedAttribute):
838         * svg/SVGStyleElement.cpp:
839         (WebCore::SVGStyleElement::isSupportedAttribute):
840         * svg/SVGStyledTransformableElement.cpp:
841         (WebCore::SVGStyledTransformableElement::isSupportedAttribute):
842         * svg/SVGSymbolElement.cpp:
843         (WebCore::SVGSymbolElement::isSupportedAttribute):
844         * svg/SVGTRefElement.cpp:
845         (WebCore::SVGTRefElement::isSupportedAttribute):
846         * svg/SVGTextContentElement.cpp:
847         (WebCore::SVGTextContentElement::isSupportedAttribute):
848         * svg/SVGTextElement.cpp:
849         (WebCore::SVGTextElement::isSupportedAttribute):
850         * svg/SVGTextPathElement.cpp:
851         (WebCore::SVGTextPathElement::isSupportedAttribute):
852         * svg/SVGTextPositioningElement.cpp:
853         (WebCore::SVGTextPositioningElement::isSupportedAttribute):
854         * svg/SVGUseElement.cpp:
855         (WebCore::SVGUseElement::isSupportedAttribute):
856         (WebCore::isDisallowedElement):
857         * svg/SVGViewElement.cpp:
858         (WebCore::SVGViewElement::isSupportedAttribute):
859         * svg/animation/SVGSMILElement.cpp:
860         (WebCore::SVGSMILElement::isSupportedAttribute):
861
862 2013-06-20  Commit Queue  <commit-queue@webkit.org>
863
864         Unreviewed, rolling out r151451.
865         http://trac.webkit.org/changeset/151451
866         https://bugs.webkit.org/show_bug.cgi?id=117848
867
868         "Broke quite a lot of sites" (Requested by rhogan on #webkit).
869
870         * rendering/RenderBox.cpp:
871         (WebCore::RenderBox::computePositionedLogicalWidth):
872         (WebCore::RenderBox::computePositionedLogicalHeight):
873         * rendering/RenderBox.h:
874         (WebCore::RenderBox::intrinsicSize):
875         * rendering/RenderButton.h:
876         * rendering/RenderListBox.cpp:
877         (WebCore::RenderListBox::RenderListBox):
878         (WebCore::RenderListBox::computeLogicalHeight):
879         * rendering/RenderListBox.h:
880         * rendering/RenderMenuList.h:
881         * rendering/RenderReplaced.h:
882         * rendering/RenderTextControl.cpp:
883         (WebCore::RenderTextControl::RenderTextControl):
884         (WebCore::RenderTextControl::computeLogicalHeight):
885         * rendering/RenderTextControl.h:
886
887 2013-06-20  Commit Queue  <commit-queue@webkit.org>
888
889         Unreviewed, rolling out r151788.
890         http://trac.webkit.org/changeset/151788
891         https://bugs.webkit.org/show_bug.cgi?id=117847
892
893         "This is the wrong fix" (Requested by rhogan on #webkit).
894
895         * rendering/RenderTextControl.cpp:
896         (WebCore::RenderTextControl::computeLogicalHeight):
897         (WebCore::RenderTextControl::computePreferredLogicalWidths):
898
899 2013-05-24  Balazs Kelemen  <kbalazs@webkit.org>
900
901         [Gstreamer] cleanup buffering and state updates
902         https://bugs.webkit.org/show_bug.cgi?id=116642
903
904         Reviewed by Philippe Normand.
905
906         Covered by existing media tests, especially the ones that have been unskipped.
907
908         Always do download buffering. It should not differ if preload is "none" because
909         it's about when to start buffering, not about how. Fix a bunch other subtle issues
910         to make this change go smoothly with the tests. As a bonus some tests that were
911         failing so far started to pass.
912         It is possible to further tweak the buffering in a way that will enable us to support
913         a different and appropriate behavior for preload="metadata" but it should be managed
914         a bit differently. I will implement it in a follow-up.
915
916         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
917         (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
918         (WebCore::MediaPlayerPrivateGStreamer::load): Don't call setDownloadBuffering
919         yet. Now it also responsible for starting the fill timer and it turned out that
920         setting the download flag before the pipeline is set to a state has negative
921         effect on some tests. Most probably GStreamer starts buffering too early if
922         we set the download flag.
923         (WebCore::MediaPlayerPrivateGStreamer::commitLoad): Call setDownloadBuffering now.
924         (WebCore::MediaPlayerPrivateGStreamer::play): Ditto, plus set m_delayingLoad to false
925         because otherwise setPreload will wrongly assume that the load has not been committed
926         yet if prepareToPlay is not called before play.
927         (WebCore::MediaPlayerPrivateGStreamer::pause): Make sure we don't commit a load here
928         if it was not committed yet by looking in the pipeline state.
929         (WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): No need to observe the
930         type of buffering.
931         (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Introduced m_downloadFinished to update
932         ready and network states in updateStates based on it. The previously used condition
933         - (maxTimeLoaded() == duration()) - was not correct in the case when duration is not known.
934         (WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): Removed a lie. If the fill timer is not active
935         it does not necesarily means that download has been finished. This lie was actually ensuring
936         a lot of tests to pass because it made the condition (maxTimeLoaded() == duration()) true.
937         Now that state updates has been cleaned up we don't need to lie.
938         (WebCore::MediaPlayerPrivateGStreamer::updateStates): Merge all the parts that takes part in updating
939         ready and network states. It was untrackable. Unset download buffering for for live streams early so
940         we don't need to restart them.
941         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
942         (MediaPlayerPrivateGStreamer): Removed m_startedBuffering because there is no need for it now.
943
944 2013-06-20  Eric Carlson  <eric.carlson@apple.com>
945
946         ASSERT removing then adding a <track> element
947         https://bugs.webkit.org/show_bug.cgi?id=117814
948
949         Reviewed by Jer Noble.
950
951         Test: media/track/add-and-remove-track.html
952
953         * html/HTMLTrackElement.cpp:
954         (WebCore::HTMLTrackElement::insertedInto): Always call ensureTrack before adding the track
955             to the parent <video> element.
956         (WebCore::HTMLTrackElement::ensureTrack): Call m_track->setTrackElement() in case the
957             parent was cleared after m_track was created.
958
959         * html/track/LoadableTextTrack.cpp:
960         (WebCore::LoadableTextTrack::setTrackElement): New, set m_trackElement.
961         * html/track/LoadableTextTrack.h:
962
963 2013-06-20  Roger Fong  <roger_fong@apple.com>
964
965         Unreviewed. Build fix for Apple Windows port.
966
967         * rendering/RenderThemeWin.cpp:
968         (WebCore::cssValueIdToSysColorIndex):
969
970 2013-06-20  Alexey Proskuryakov  <ap@apple.com>
971
972         [Mac] Downloaded file name encoding is incorrect when download link opens in a new window
973         https://bugs.webkit.org/show_bug.cgi?id=117818
974         <rdar://problem/14212635>
975
976         Reviewed by Brady Eidson.
977
978         No tests added. The machinery we have for logging downloaded file name is very
979         far from being able to work in a secondary window.
980
981         * loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
982         Made a targeted fix - don't update encoding fallback array if we already have one,
983         there is no chance for it to be more correct. In this case, it's incorrect because
984         it comes from a new blank window, instead of original referer.
985         We have a lot of code in addExtraFieldsToRequest() to struggle with this, and we have
986         a FIXME to try not calling it from policy delegate.
987
988 2013-06-18  Robert Hogan  <robert@webkit.org>
989
990         REGRESSION (r151451): Text not vertically centered correctly on icloud.com
991         https://bugs.webkit.org/show_bug.cgi?id=117744
992
993         Reviewed by David Hyatt.
994
995         The positioned height and width computation adds in the element's border and padding so 
996         don't add it to the intrinsic height and preferred widths of text controls that are
997         absolutely positioned.
998
999         Test: fast/replaced/height-of-positioned-text-control.html
1000
1001         * rendering/RenderTextControl.cpp:
1002         (WebCore::RenderTextControl::computeLogicalHeight):
1003         (WebCore::RenderTextControl::computePreferredLogicalWidths):
1004
1005 2013-06-20  Roger Fong  <roger_fong@apple.com>
1006
1007         Make Windows makefile copy build output to a different folder.
1008         <rdar://problem/14219184>.
1009
1010         * WebCore.vcxproj/WebCore.make:
1011
1012 2013-06-19  Jer Noble  <jer.noble@apple.com>
1013
1014         Roll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
1015         https://bugs.webkit.org/show_bug.cgi?id=117811
1016
1017         Reviewed by Eric Carlson.
1018
1019         When comparing Generic cues, we should check that their type is Generic, not WebVTT.
1020
1021         * html/track/TextTrackCueGeneric.cpp:
1022         (WebCore::TextTrackCueGeneric::isOrderedBefore):
1023
1024 2013-06-20  Ralph Thomas  <ralpht@gmail.com>
1025
1026         [CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
1027         https://bugs.webkit.org/show_bug.cgi?id=117711
1028
1029         Reviewed by Laszlo Gombos.
1030
1031         No new tests, no CMake platforms currently enable this functionality.
1032
1033         * CMakeLists.txt:
1034
1035 2013-06-20  Alexis Menard  <alexis@webkit.org>
1036
1037         Cleanup usage of CSSPropertyID and CSSValueID inside WebKit.
1038         https://bugs.webkit.org/show_bug.cgi?id=117829
1039
1040         Reviewed by Andreas Kling.
1041
1042         A lot of call sites were using integers to represent them. While it's
1043         not incorrect per se, it's not ideal for various reason such as type
1044         safety or to remove ambiguity.
1045
1046         This patch eradicate the wrong usage by not letting any integer based
1047         API for getting CSSValueIDs or CSSPropertyIDs from CSSPrimitiveValues.
1048
1049         Instead we use new but typed functions to construct the values as well
1050         as getting them. Two customs and internal types were added to CSSPrimitiveValue
1051         to handle correctly the new APIs.
1052
1053         It's good to note that in order to preserve compatibility on the
1054         CSSPrimitiveValue type whenever CSSPrimitiveValue handles a CSSValueID
1055         or a CSSPropertyID the return type for the public API will be CSS_IDENT
1056         despite it is a separate internal type.
1057
1058         No new tests: refactor, existing tests should cover.
1059
1060         * css/CSSComputedStyleDeclaration.cpp:
1061         (WebCore::ComputedStyleExtractor::propertyMatches):
1062         * css/CSSFontSelector.cpp:
1063         (WebCore::CSSFontSelector::addFontFaceRule):
1064         * css/CSSGradientValue.cpp:
1065         (WebCore::positionFromValue):
1066         (WebCore::CSSLinearGradientValue::customCssText):
1067         (WebCore::CSSLinearGradientValue::createGradient):
1068         (WebCore::CSSRadialGradientValue::customCssText):
1069         (WebCore::CSSRadialGradientValue::createGradient):
1070         * css/CSSParser.cpp:
1071         (WebCore::CSSParser::parseSystemColor):
1072         (WebCore::isFillPositionKeyword):
1073         (WebCore::CSSParser::parse4ValuesFillPosition):
1074         (WebCore::CSSParser::parse3ValuesFillPosition):
1075         (WebCore::CSSParser::parseFillPosition):
1076         (WebCore::CSSParser::parseFillRepeat):
1077         (WebCore::CSSParser::parseRadialGradient):
1078         (WebCore::CSSParser::isBlendMode):
1079         (WebCore::CSSParser::isCompositeOperator):
1080         * css/CSSParser.h:
1081         * css/CSSParserValues.cpp:
1082         (WebCore::CSSParserValue::createCSSValue):
1083         * css/CSSPrimitiveValue.cpp:
1084         (WebCore::isValidCSSUnitTypeForDoubleConversion):
1085         (WebCore::CSSPrimitiveValue::primitiveType):
1086         (WebCore::propertyName):
1087         (WebCore::valueName):
1088         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1089         (WebCore::CSSPrimitiveValue::cleanup):
1090         (WebCore::CSSPrimitiveValue::getStringValue):
1091         (WebCore::CSSPrimitiveValue::customCssText):
1092         (WebCore::CSSPrimitiveValue::cloneForCSSOM):
1093         (WebCore::CSSPrimitiveValue::equals):
1094         * css/CSSPrimitiveValue.h:
1095         (WebCore::CSSPrimitiveValue::isFontRelativeLength):
1096         (WebCore::CSSPrimitiveValue::isValueID):
1097         (WebCore::CSSPrimitiveValue::createIdentifier):
1098         (WebCore::CSSPrimitiveValue::createParserOperator):
1099         (WebCore::CSSPrimitiveValue::getPropertyID):
1100         (WebCore::CSSPrimitiveValue::getValueID):
1101         * css/CSSPrimitiveValueMappings.h:
1102         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1103         (WebCore::CSSPrimitiveValue::operator CSSReflectionDirection):
1104         (WebCore::CSSPrimitiveValue::operator ColumnSpan):
1105         (WebCore::CSSPrimitiveValue::operator PrintColorAdjust):
1106         (WebCore::CSSPrimitiveValue::operator EBorderStyle):
1107         (WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
1108         (WebCore::CSSPrimitiveValue::operator CompositeOperator):
1109         (WebCore::CSSPrimitiveValue::operator ControlPart):
1110         (WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
1111         (WebCore::CSSPrimitiveValue::operator EFillAttachment):
1112         (WebCore::CSSPrimitiveValue::operator EFillBox):
1113         (WebCore::CSSPrimitiveValue::operator EFillRepeat):
1114         (WebCore::CSSPrimitiveValue::operator EBoxPack):
1115         (WebCore::CSSPrimitiveValue::operator EBoxAlignment):
1116         (WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
1117         (WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):
1118         (WebCore::CSSPrimitiveValue::operator EBoxSizing):
1119         (WebCore::CSSPrimitiveValue::operator EBoxDirection):
1120         (WebCore::CSSPrimitiveValue::operator EBoxLines):
1121         (WebCore::CSSPrimitiveValue::operator EBoxOrient):
1122         (WebCore::CSSPrimitiveValue::operator ECaptionSide):
1123         (WebCore::CSSPrimitiveValue::operator EClear):
1124         (WebCore::CSSPrimitiveValue::operator ECursor):
1125         (WebCore::CSSPrimitiveValue::operator CursorVisibility):
1126         (WebCore::CSSPrimitiveValue::operator EDisplay):
1127         (WebCore::CSSPrimitiveValue::operator EEmptyCell):
1128         (WebCore::CSSPrimitiveValue::operator EAlignItems):
1129         (WebCore::CSSPrimitiveValue::operator EJustifyContent):
1130         (WebCore::CSSPrimitiveValue::operator EFlexDirection):
1131         (WebCore::CSSPrimitiveValue::operator EAlignContent):
1132         (WebCore::CSSPrimitiveValue::operator EFlexWrap):
1133         (WebCore::CSSPrimitiveValue::operator EFloat):
1134         (WebCore::CSSPrimitiveValue::operator LineBreak):
1135         (WebCore::CSSPrimitiveValue::operator EListStylePosition):
1136         (WebCore::CSSPrimitiveValue::operator EListStyleType):
1137         (WebCore::CSSPrimitiveValue::operator EMarginCollapse):
1138         (WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
1139         (WebCore::CSSPrimitiveValue::operator RegionFragment):
1140         (WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
1141         (WebCore::CSSPrimitiveValue::operator ENBSPMode):
1142         (WebCore::CSSPrimitiveValue::operator EOverflow):
1143         (WebCore::CSSPrimitiveValue::operator EPageBreak):
1144         (WebCore::CSSPrimitiveValue::operator EPosition):
1145         (WebCore::CSSPrimitiveValue::operator EResize):
1146         (WebCore::CSSPrimitiveValue::operator ETableLayout):
1147         (WebCore::CSSPrimitiveValue::operator ETextAlign):
1148         (WebCore::CSSPrimitiveValue::operator TextAlignLast):
1149         (WebCore::CSSPrimitiveValue::operator TextJustify):
1150         (WebCore::CSSPrimitiveValue::operator TextDecoration):
1151         (WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
1152         (WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):
1153         (WebCore::CSSPrimitiveValue::operator ETextSecurity):
1154         (WebCore::CSSPrimitiveValue::operator ETextTransform):
1155         (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
1156         (WebCore::CSSPrimitiveValue::operator EUserDrag):
1157         (WebCore::CSSPrimitiveValue::operator EUserModify):
1158         (WebCore::CSSPrimitiveValue::operator EUserSelect):
1159         (WebCore::CSSPrimitiveValue::operator EVerticalAlign):
1160         (WebCore::CSSPrimitiveValue::operator EVisibility):
1161         (WebCore::CSSPrimitiveValue::operator EWhiteSpace):
1162         (WebCore::CSSPrimitiveValue::operator EWordBreak):
1163         (WebCore::CSSPrimitiveValue::operator EOverflowWrap):
1164         (WebCore::CSSPrimitiveValue::operator TextDirection):
1165         (WebCore::CSSPrimitiveValue::operator WritingMode):
1166         (WebCore::CSSPrimitiveValue::operator TextCombine):
1167         (WebCore::CSSPrimitiveValue::operator RubyPosition):
1168         (WebCore::CSSPrimitiveValue::operator TextEmphasisPosition):
1169         (WebCore::CSSPrimitiveValue::operator TextOverflow):
1170         (WebCore::CSSPrimitiveValue::operator TextEmphasisFill):
1171         (WebCore::CSSPrimitiveValue::operator TextEmphasisMark):
1172         (WebCore::CSSPrimitiveValue::operator TextOrientation):
1173         (WebCore::CSSPrimitiveValue::operator EPointerEvents):
1174         (WebCore::CSSPrimitiveValue::operator FontDescription::Kerning):
1175         (WebCore::CSSPrimitiveValue::operator FontSmoothingMode):
1176         (WebCore::CSSPrimitiveValue::operator FontWeight):
1177         (WebCore::CSSPrimitiveValue::operator FontItalic):
1178         (WebCore::CSSPrimitiveValue::operator FontSmallCaps):
1179         (WebCore::CSSPrimitiveValue::operator TextRenderingMode):
1180         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1181         (WebCore::CSSPrimitiveValue::operator Hyphens):
1182         (WebCore::CSSPrimitiveValue::operator LineSnap):
1183         (WebCore::CSSPrimitiveValue::operator LineAlign):
1184         (WebCore::CSSPrimitiveValue::operator Order):
1185         (WebCore::CSSPrimitiveValue::operator ESpeak):
1186         (WebCore::CSSPrimitiveValue::operator BlendMode):
1187         (WebCore::CSSPrimitiveValue::operator LineCap):
1188         (WebCore::CSSPrimitiveValue::operator LineJoin):
1189         (WebCore::CSSPrimitiveValue::operator WindRule):
1190         (WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
1191         (WebCore::CSSPrimitiveValue::operator EBorderCollapse):
1192         (WebCore::CSSPrimitiveValue::operator EBorderFit):
1193         (WebCore::CSSPrimitiveValue::operator EImageRendering):
1194         (WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
1195         (WebCore::CSSPrimitiveValue::operator ColumnAxis):
1196         (WebCore::CSSPrimitiveValue::operator ColumnProgression):
1197         (WebCore::CSSPrimitiveValue::operator WrapFlow):
1198         (WebCore::CSSPrimitiveValue::operator WrapThrough):
1199         (WebCore::CSSPrimitiveValue::operator GridAutoFlow):
1200         (WebCore::CSSPrimitiveValue::convertToLength):
1201         (WebCore::CSSPrimitiveValue::operator EBufferedRendering):
1202         (WebCore::CSSPrimitiveValue::operator EColorInterpolation):
1203         (WebCore::CSSPrimitiveValue::operator EColorRendering):
1204         (WebCore::CSSPrimitiveValue::operator EDominantBaseline):
1205         (WebCore::CSSPrimitiveValue::operator EShapeRendering):
1206         (WebCore::CSSPrimitiveValue::operator ETextAnchor):
1207         (WebCore::CSSPrimitiveValue::operator SVGWritingMode):
1208         (WebCore::CSSPrimitiveValue::operator EVectorEffect):
1209         (WebCore::CSSPrimitiveValue::operator EMaskType):
1210         * css/CSSToStyleMap.cpp:
1211         (WebCore::CSSToStyleMap::mapFillAttachment):
1212         (WebCore::CSSToStyleMap::mapFillSize):
1213         (WebCore::CSSToStyleMap::mapAnimationDirection):
1214         (WebCore::CSSToStyleMap::mapAnimationFillMode):
1215         (WebCore::CSSToStyleMap::mapAnimationIterationCount):
1216         (WebCore::CSSToStyleMap::mapAnimationName):
1217         (WebCore::CSSToStyleMap::mapAnimationPlayState):
1218         (WebCore::CSSToStyleMap::mapAnimationProperty):
1219         (WebCore::CSSToStyleMap::mapAnimationTimingFunction):
1220         (WebCore::CSSToStyleMap::mapNinePieceImageQuad):
1221         (WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
1222         * css/Counter.h:
1223         (WebCore::Counter::listStyleIdent):
1224         * css/DeprecatedStyleBuilder.cpp:
1225         (WebCore::ApplyPropertyNumber::applyValue):
1226         (WebCore::ApplyPropertyAuto::applyValue):
1227         (WebCore::ApplyPropertyClip::applyValue):
1228         (WebCore::ApplyPropertyColor::applyValue):
1229         (WebCore::ApplyPropertyLength::applyValue):
1230         (WebCore::ApplyPropertyString::applyValue):
1231         (WebCore::ApplyPropertyComputeLength::applyValue):
1232         (WebCore::ApplyPropertyFontFamily::applyValue):
1233         (WebCore::ApplyPropertyFontSize::applyValue):
1234         (WebCore::ApplyPropertyFontWeight::applyValue):
1235         (WebCore::ApplyPropertyFontVariantLigatures::applyValue):
1236         (WebCore::ApplyPropertyCounter::applyValue):
1237         (WebCore::ApplyPropertyCursor::applyValue):
1238         (WebCore::ApplyPropertyTextAlign::applyValue):
1239         (WebCore::ApplyPropertyMarqueeIncrement::applyValue):
1240         (WebCore::ApplyPropertyMarqueeRepetition::applyValue):
1241         (WebCore::ApplyPropertyMarqueeSpeed::applyValue):
1242         (WebCore::ApplyPropertyLineHeight::applyValue):
1243         (WebCore::ApplyPropertyPageSize::getPageSizeFromName):
1244         (WebCore::ApplyPropertyPageSize::applyValue):
1245         (WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
1246         (WebCore::ApplyPropertyResize::applyValue):
1247         (WebCore::ApplyPropertyVerticalAlign::applyValue):
1248         (WebCore::ApplyPropertyZoom::applyValue):
1249         (WebCore::ApplyPropertyClipPath::applyValue):
1250         (WebCore::ApplyPropertyShape::applyValue):
1251         (WebCore::ApplyPropertyImageResolution::applyValue):
1252         (WebCore::ApplyPropertyTextIndent::applyValue):
1253         * css/MediaQueryEvaluator.cpp:
1254         (WebCore::orientationMediaFeatureEval):
1255         (WebCore::view_modeMediaFeatureEval):
1256         (WebCore::pointerMediaFeatureEval):
1257         * css/SVGCSSParser.cpp:
1258         (WebCore::CSSParser::parseSVGValue):
1259         * css/SVGCSSStyleSelector.cpp:
1260         (WebCore::StyleResolver::applySVGProperty):
1261         * css/StylePropertySet.cpp:
1262         (WebCore::StylePropertySet::getLayeredShorthandValue):
1263         * css/StyleResolver.cpp:
1264         (WebCore::createGridTrackBreadth):
1265         (WebCore::createGridTrackList):
1266         (WebCore::createGridPosition):
1267         (WebCore::StyleResolver::applyProperty):
1268         (WebCore::colorForCSSValue):
1269         (WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
1270         (WebCore::StyleResolver::colorFromPrimitiveValue):
1271         (WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
1272         (WebCore::StyleResolver::createFilterOperations):
1273         * css/ViewportStyleResolver.cpp:
1274         (WebCore::ViewportStyleResolver::getViewportArgumentValue):
1275         * css/WebKitCSSMatrix.cpp:
1276         (WebCore::WebKitCSSMatrix::setMatrixValue):
1277         * editing/ApplyStyleCommand.cpp:
1278         (WebCore::toIdentifier):
1279         * editing/EditingStyle.cpp:
1280         (WebCore::identifierForStyleProperty):
1281         (WebCore::HTMLElementEquivalent::create):
1282         (WebCore::HTMLElementEquivalent::HTMLElementEquivalent):
1283         (WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
1284         (WebCore::HTMLTextDecorationEquivalent::create):
1285         (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent):
1286         (WebCore::EditingStyle::textDirection):
1287         (WebCore::EditingStyle::prepareToApplyAt):
1288         (WebCore::EditingStyle::textDirectionForSelection):
1289         (WebCore::fontWeightIsBold):
1290         (WebCore::legacyFontSizeFromCSSValue):
1291         (WebCore::isTransparentColorValue):
1292         * editing/EditingStyle.h:
1293         * editing/markup.cpp:
1294         (WebCore::propertyMissingOrEqualToNone):
1295         * platform/blackberry/RenderThemeBlackBerry.cpp:
1296         (WebCore::RenderThemeBlackBerry::systemFont):
1297         * platform/blackberry/RenderThemeBlackBerry.h:
1298         (WebCore::RenderThemeBlackBerry::systemFont):
1299         * platform/blackberry/RenderThemeEfl.cpp:
1300         (WebCore::RenderThemeEfl::systemFont):
1301         * platform/blackberry/RenderThemeEfl.h:
1302         (WebCore::RenderThemeEfl::systemFont):
1303         * platform/gtk/RenderThemeGtk.cpp:
1304         (WebCore::RenderThemeGtk::systemFont):
1305         * platform/gtk/RenderThemeGtk.h:
1306         * platform/gtk/RenderThemeGtk2.cpp:
1307         (WebCore::RenderThemeGtk::systemColor):
1308         * platform/gtk/RenderThemeGtk3.cpp:
1309         (WebCore::RenderThemeGtk::systemColor):
1310         * platform/qt/RenderThemeQt.cpp:
1311         (WebCore::RenderThemeQt::systemFont):
1312         (WebCore::RenderThemeQt::systemColor):
1313         * platform/qt/RenderThemeQt.h:
1314         * rendering/RenderTheme.cpp:
1315         (WebCore::RenderTheme::systemColor):
1316         * rendering/RenderTheme.h:
1317         * rendering/RenderThemeMac.h:
1318         * rendering/RenderThemeMac.mm:
1319         (WebCore::RenderThemeMac::systemFont):
1320         (WebCore::RenderThemeMac::systemColor):
1321         * rendering/RenderThemeSafari.h:
1322         (WebCore::RenderThemeSafari::systemFont):
1323         * rendering/RenderThemeSafari.cpp:
1324         (WebCore::RenderThemeSafari::systemFont):
1325         * rendering/RenderThemeWin.cpp:
1326         (WebCore::RenderThemeWin::systemFont):
1327         (WebCore::cssValueIdToSysColorIndex):
1328         (WebCore::RenderThemeWin::systemColor):
1329         * rendering/RenderThemeWin.h:
1330         * rendering/RenderThemeWinCE.cpp:
1331         (WebCore::RenderThemeWinCE::systemFont):
1332         (WebCore::cssValueIdToSysColorIndex):
1333         (WebCore::RenderThemeWinCE::systemColor):
1334         * rendering/RenderThemeWinCE.h:
1335
1336 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
1337
1338         AX: List Items should support a default action
1339         https://bugs.webkit.org/show_bug.cgi?id=117812
1340
1341         Reviewed by Chris Fleizach.
1342
1343         * accessibility/AccessibilityObject.cpp:
1344         (WebCore::AccessibilityObject::actionVerb): Provide a "select" verb
1345         for use in ListItemRole objects.
1346         * platform/LocalizedStrings.cpp:
1347         (WebCore::AXListItemActionVerb): Added.
1348         * platform/LocalizedStrings.h:
1349         * platform/blackberry/LocalizedStringsBlackBerry.cpp:
1350         (WebCore::AXListItemActionVerb):
1351         * platform/efl/LocalizedStringsEfl.cpp:
1352         (WebCore::AXListItemActionVerb):
1353         * platform/gtk/LocalizedStringsGtk.cpp:
1354         (WebCore::AXListItemActionVerb):
1355
1356 2013-06-20  Radu Stavila  <stavila@adobe.com>
1357
1358         [CSS Regions] Add new regionOversetChange event
1359         https://bugs.webkit.org/show_bug.cgi?id=117508
1360
1361         Added regionOversetChange event and tests for it. The overset value of the region has been moved to the ElementRareData
1362         object instead of the RenderRegion object. This was needed for the case when a reattach is performed (for instance by changing
1363         the display type of the region's containing block) and the RenderRegion object is destroyed. When computing the overset again,
1364         there would be no "previous" value to compare it to and decide whether the regionOversetChange event must be dispatched.
1365
1366         Reviewed by Antti Koivisto.
1367
1368         Tests:  fast/regions/webkit-named-flow-event-add-to-flow.html:
1369                 fast/regions/webkit-named-flow-event-auto-height.html:
1370                 fast/regions/webkit-named-flow-event-crash.html:
1371                 fast/regions/webkit-named-flow-event-no-regions.html:
1372                 fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
1373                 fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
1374                 fast/regions/webkit-named-flow-event-remove-from-dom.html:
1375                 fast/regions/webkit-named-flow-event-remove-from-flow.html:
1376                 fast/regions/webkit-named-flow-event-target.html:
1377                 fast/regions/webkit-named-flow-event-to-null.html:
1378                 fast/regions/webkit-named-flow-event.html:
1379
1380
1381         * GNUmakefile.list.am:
1382         * Target.pri:
1383         * WebCore.xcodeproj/project.pbxproj:
1384         * dom/Element.cpp:
1385         (WebCore::Element::setRegionOversetState):
1386         (WebCore::Element::regionOversetState):
1387         (WebCore::Element::webkitRegionOverset):
1388         * dom/Element.h:
1389         * dom/ElementRareData.cpp:
1390         * dom/ElementRareData.h:
1391         (WebCore::ElementRareData::regionOversetState):
1392         (WebCore::ElementRareData::setRegionOversetState):
1393         (WebCore::ElementRareData::ElementRareData):
1394         * dom/EventNames.h:
1395         * dom/WebKitNamedFlow.cpp:
1396         (WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
1397         (WebCore::WebKitNamedFlow::dispatchRegionOversetChangeEvent):
1398         * dom/WebKitNamedFlow.h:
1399         (WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
1400         (WebCore::ChangeRegionOversetTask::scheduleFor):
1401         (WebCore::ChangeRegionOversetTask::unschedule):
1402         (WebCore::ChangeRegionOversetTask::reset):
1403         (WebCore::ChangeRegionOversetTask::onTimer):
1404         * rendering/RegionOversetState.h: Added.
1405         * rendering/RenderBlock.cpp:
1406         (WebCore::RenderBlock::computeOverflow):
1407         * rendering/RenderFlowThread.cpp:
1408         (WebCore::RenderFlowThread::RenderFlowThread):
1409         (WebCore::RenderFlowThread::layout):
1410         (WebCore::RenderFlowThread::computeOversetStateForRegions):
1411         * rendering/RenderFlowThread.h:
1412         * rendering/RenderNamedFlowThread.cpp:
1413         (WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
1414         (WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
1415         (WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
1416         * rendering/RenderNamedFlowThread.h:
1417         * rendering/RenderRegion.cpp:
1418         (WebCore::RenderRegion::RenderRegion):
1419         (WebCore::RenderRegion::regionOversetState):
1420         (WebCore::RenderRegion::setRegionOversetState):
1421         * rendering/RenderRegion.h:
1422
1423 2013-06-20  James Craig  <james@cookiecrook.com>
1424
1425         AX: aria-required is not exposed on all expected roles
1426         https://bugs.webkit.org/show_bug.cgi?id=115123
1427
1428         Reviewed by Chris Fleizach.
1429
1430         aria-required is now exposed on more roles. Updated existing test file.
1431
1432         * accessibility/AccessibilityNodeObject.cpp:
1433         (WebCore::AccessibilityNodeObject::supportsRequiredAttribute):
1434         * accessibility/AccessibilityNodeObject.h:
1435         * accessibility/AccessibilityObject.h:
1436         (WebCore::AccessibilityObject::supportsRequiredAttribute):
1437         * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
1438         (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
1439
1440 2013-06-20  Seokju Kwon  <seokju.kwon@gmail.com>
1441
1442         Web Inspector: Use console.timeStamp instead of console.markTimeline
1443         https://bugs.webkit.org/show_bug.cgi?id=117810
1444
1445         Reviewed by Joseph Pecoraro.
1446
1447         Webkit supports both console.timeStamp and console.markTimeline.
1448         And they do the exact same thing.
1449         This patch gets rid of console.markTimeline for Chrome/Firebug compatibility.
1450
1451         No new functionality, no new tests.
1452
1453         * WebCore.order:
1454         * page/Console.cpp:
1455         * page/Console.h:
1456         * page/Console.idl:
1457
1458 2013-06-20  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1459
1460         background-color and text-decoration are not preserved when merging paragraphs
1461         https://bugs.webkit.org/show_bug.cgi?id=116215
1462
1463         Reviewed by Ryosuke Niwa.
1464
1465         In mergeInlineAndImplicitStyleOfElement(), style from matched rules are retrieved.
1466         If they contain either background-color or text-decoration they will be removed
1467         by removeNonEditingProperties() due to copyEditingProperties() implicit
1468         'OnlyInheritableEditingProperties' parameter.
1469         We have already had similar issue at https://bugs.webkit.org/show_bug.cgi?id=53196
1470
1471         Tests: editing/deleting/merge-div-from-span-with-style.html
1472                editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html
1473                editing/deleting/merge-paragraph-from-span-with-style.html
1474
1475         * editing/EditingStyle.cpp:
1476         (WebCore::copyEditingProperties):
1477         (WebCore::editingStyleFromComputedStyle):
1478         Add EditingStyle:: due to move EditingPropertiesToInclude to EditingStyle.h.
1479
1480         (WebCore::toEditingProperties):
1481         Add a helper to easy convert PropertiesToInclude to EditingPropertiesToInclude,
1482         needed in mergeInlineAndImplicitStyleOfElement().
1483
1484         (WebCore::EditingStyle::removeAllButEditingProperties):
1485         Add a parameter to choose which editing properties should be preserved while
1486         removing all properties (OnlyInheritableEditingProperties implicite).
1487
1488         (WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
1489         Call removeAllButEditingProperties with parameter.
1490
1491         * editing/EditingStyle.h:
1492         Move EditingPropertiesType to the header as it's needed by removeAllButEditingProperties().
1493         Change EditingPropertiesType to EditingPropertiesToInclude to be consistent with
1494         PropertiesToInclude.
1495         Change removeNonEditingProperties() to removeAllButEditingProperties().
1496
1497 2013-06-19  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1498
1499         The order of the generated supplemental code is not guaranteed
1500         https://bugs.webkit.org/show_bug.cgi?id=117820
1501
1502         Reviewed by Kentaro Hara.
1503
1504         Sort the supplemental idl files before generating the code so that it is
1505         generated in a consistent order.
1506
1507         No new tests, covered by existing bindings tests.
1508
1509         * bindings/scripts/generate-bindings.pl:
1510
1511 2013-06-19  Commit Queue  <commit-queue@webkit.org>
1512
1513         Unreviewed, rolling out r151769.
1514         http://trac.webkit.org/changeset/151769
1515         https://bugs.webkit.org/show_bug.cgi?id=117821
1516
1517         Broke windows build due to missing GL/glext.h header.
1518         (Requested by bfulgham on #webkit).
1519
1520         * WebCore.vcxproj/WebCore.vcxproj:
1521         * WebCore.vcxproj/WebCore.vcxproj.filters:
1522
1523 2013-06-19  Alex Christensen  <alex.christensen@flexsim.com>
1524
1525         Added WebGL files to Windows build without enabling them.
1526         https://bugs.webkit.org/show_bug.cgi?id=117809
1527
1528         Reviewed by Brent Fulgham.
1529
1530         * WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
1531         * WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.
1532
1533 2013-06-19  Alex Christensen  <achristensen@apple.com>
1534
1535         Windows build should include WebGL generated files if WebGL is enabled.
1536         https://bugs.webkit.org/show_bug.cgi?id=117802
1537
1538         Reviewed by Brent Fulgham.
1539
1540         Added WebGL generated files to Windows build if WebGL is enabled.
1541         * DerivedSources.cpp:
1542         * WebCore.vcxproj/WebCore.vcxproj:
1543         * WebCore.vcxproj/WebCore.vcxproj.filters:
1544
1545 2013-06-19  Alexey Proskuryakov  <ap@apple.com>
1546
1547         [Mac] Common crashes when playing media
1548         https://bugs.webkit.org/show_bug.cgi?id=117813
1549         <rdar://problem/13837412>
1550
1551         Reviewed by Eric Carlson.
1552
1553         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
1554         (-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):
1555         This method may be called from a secondary thread, but it does things that are
1556         not thread safe.
1557
1558 2013-06-19  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
1559
1560         Incomplete repaint of input elements in writing-mode overflow
1561         https://bugs.webkit.org/show_bug.cgi?id=110246
1562
1563         Reviewed by Simon Fraser.
1564
1565         We calculate repaint rect using unflipped rect.
1566         However, RenderBox::applyCachedClipAndScrollOffsetForRepaint() which is called from repaint rect calculation
1567         wants that its argument rect is flipped.
1568         The reason is:
1569         - paintRect.move(-scrolledContentOffset()); cannot scroll if the rect is unflipped.
1570         - It cannot clip using intersect.
1571         Passing unflipped rect to applyCachedClipAndScrollOffsetForRepaint() cause invalid clipping.
1572         Therefore, this patch flipped the rect at the first part of the function and unflipped it at the last part of the function.
1573
1574         Scroll bar rect is absolute rect, so it is flipped rect.
1575         RenderLayer::invalidateScrollbarRect() pass the rect to repaintRectangle() which expects an argument rect is unflipped.
1576         This cause part of overlapping scroll bar doesn't fade out.
1577         Therefore, this patch flipped the rect and pass it to repaintRectangle().
1578
1579         Tests: fast/repaint/horizontal-bt-overflow-child.html
1580                fast/repaint/horizontal-bt-overflow-parent.html
1581                fast/repaint/horizontal-bt-overflow-same.html
1582                fast/repaint/vertical-overflow-child.html
1583                fast/repaint/vertical-overflow-parent.html
1584                fast/repaint/vertical-overflow-same.html
1585
1586         * rendering/RenderBox.cpp:
1587         (WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
1588         * rendering/RenderLayer.cpp:
1589         (WebCore::RenderLayer::invalidateScrollbarRect):
1590
1591 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
1592
1593         Use the PlatformEvent timestamp when creating a DOM Event
1594         https://bugs.webkit.org/show_bug.cgi?id=117179
1595
1596         Reviewed by Darin Adler.
1597
1598         Previously, the platform event's timestamp was ignored by WebCore and each
1599         new event would get a new timestamp by calling WTF::currentTime().
1600
1601         The problem is there can be a significant delay between the input event and
1602         it being dispatched to JavaScript. Computing the velocity/acceleration of the cursor
1603         is impossible since the delay vary from event to events.
1604         On WebKit2, the delay per event typically vary between 0 and 30ms.
1605
1606         This patch changes the Event creation code to use the timer passed by the underlying platform event.
1607
1608         * WebCore.exp.in:
1609         * dom/Event.cpp:
1610         (WebCore::Event::Event):
1611         * dom/Event.h:
1612         * dom/GestureEvent.cpp:
1613         (WebCore::GestureEvent::create):
1614         (WebCore::GestureEvent::GestureEvent):
1615         * dom/GestureEvent.h:
1616         * dom/KeyboardEvent.cpp:
1617         (WebCore::KeyboardEvent::KeyboardEvent):
1618         * dom/KeyboardEvent.h:
1619         * dom/MouseEvent.cpp:
1620         (WebCore::MouseEvent::create):
1621         (WebCore::MouseEvent::MouseEvent):
1622         (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
1623         * dom/MouseEvent.h:
1624         * dom/MouseRelatedEvent.cpp:
1625         (WebCore::MouseRelatedEvent::MouseRelatedEvent):
1626         * dom/MouseRelatedEvent.h:
1627         * dom/TouchEvent.cpp:
1628         (WebCore::TouchEvent::TouchEvent):
1629         * dom/UIEvent.cpp:
1630         (WebCore::UIEvent::UIEvent):
1631         * dom/UIEvent.h:
1632         * dom/UIEventWithKeyState.h:
1633         (WebCore::UIEventWithKeyState::UIEventWithKeyState):
1634         * dom/WheelEvent.cpp:
1635         (WebCore::WheelEvent::WheelEvent):
1636         (WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
1637         * dom/WheelEvent.h:
1638         (WebCore::WheelEvent::create):
1639         * page/EventHandler.cpp:
1640         (WebCore::EventHandler::dispatchDragEvent):
1641         * platform/mac/PlatformEventFactoryMac.mm:
1642         (WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
1643         (WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
1644         (WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
1645         (WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1646
1647 2013-06-19  Alexis Menard  <alexis@webkit.org>
1648
1649         Make sure to use CSSValueID and CSSPropertyID rather than integers
1650         https://bugs.webkit.org/show_bug.cgi?id=117481
1651
1652         Reviewed by Benjamin Poulain.
1653
1654         This will ensure that types are enforced when passing arguments in various
1655         css functions. Having a compile time check make sure that no mistakes
1656         will be done over the type.
1657
1658         The parser was also patched to directly use CSSValueID over integers.
1659         This patch also fixes various call sites abusing the usage of integers.
1660         This is part 1 of 2.
1661
1662         No new tests : existing ones should cover.
1663
1664         * WebCore.xcodeproj/project.pbxproj: copy CSSValueKeywords.h as it could be used in WebKit/ for example.
1665         * css/CSSComputedStyleDeclaration.cpp:
1666         (WebCore::valueForRepeatRule):
1667         (WebCore::cssIdentifierForFontSizeKeyword):
1668         (WebCore::identifierForFamily):
1669         (WebCore::valueForFamily):
1670         * css/CSSGrammar.y.in:
1671         * css/CSSParser.cpp:
1672         (WebCore::parseColorValue):
1673         (WebCore::parseKeywordValue):
1674         (WebCore::CSSParser::parseValidPrimitive):
1675         (WebCore::CSSParser::parseValue):
1676         (WebCore::CSSParser::parseContent):
1677         (WebCore::CSSParser::parseBackgroundColor):
1678         (WebCore::CSSParser::parseFillPositionComponent):
1679         (WebCore::CSSParser::parse3ValuesFillPosition):
1680         (WebCore::CSSParser::parseFillRepeat):
1681         (WebCore::CSSParser::parseAnimationProperty):
1682         (WebCore::CSSParser::parseCounterContent):
1683         (WebCore::CSSParser::parseLineHeight):
1684         (WebCore::CSSParser::parseFontSize):
1685         (WebCore::CSSParser::createFontWeightValueKeyword):
1686         (WebCore::CSSParser::parseFontWeight):
1687         (WebCore::parseDeprecatedGradientColorStop):
1688         (WebCore::parseGradientColorOrKeyword):
1689         (WebCore::CSSParser::parseDeprecatedRadialGradient):
1690         (WebCore::CSSParser::rewriteSpecifiers):
1691         * css/CSSParser.h:
1692         * css/CSSParserValues.h:
1693         * css/CSSPrimitiveValue.h:
1694         * css/CSSValuePool.cpp:
1695         (WebCore::CSSValuePool::createIdentifierValue):
1696         * css/CSSValuePool.h:
1697         * css/StylePropertySet.cpp:
1698         (WebCore::MutableStylePropertySet::setProperty):
1699         * css/StylePropertySet.h:
1700         * dom/StyledElement.cpp:
1701         (WebCore::StyledElement::setInlineStyleProperty):
1702         (WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
1703         * dom/StyledElement.h:
1704         * editing/EditingStyle.cpp:
1705         (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
1706         (WebCore::EditingStyle::prepareToApplyAt):
1707         * editing/EditorCommand.cpp:
1708         (WebCore::executeApplyStyle):
1709         (WebCore::executeFontSize):
1710         * html/HTMLElement.cpp:
1711         (WebCore::unicodeBidiAttributeForDirAuto):
1712         (WebCore::HTMLElement::applyAlignmentAttributeToStyle):
1713         * html/HTMLFontElement.cpp:
1714         (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):
1715         (WebCore::HTMLFontElement::collectStyleForPresentationAttribute):
1716         * html/HTMLFontElement.h:
1717         * html/HTMLTableElement.cpp:
1718         (WebCore::leakBorderStyle):
1719         * html/track/TextTrackCue.cpp:
1720         (WebCore::TextTrackCue::getCSSWritingDirection):
1721         (WebCore::TextTrackCue::getCSSWritingMode):
1722         * html/track/TextTrackCue.h:
1723
1724 2013-06-19  Bem Jones-Bey  <bjonesbe@adobe.com>
1725
1726         Fix a few missed renames from Exclusions -> Shapes
1727         https://bugs.webkit.org/show_bug.cgi?id=117803
1728
1729         Reviewed by David Hyatt.
1730
1731         In the great CSS Exclusions to CSS Shapes rename, a few instances were
1732         missed. This fixes those instances.
1733
1734         No new tests, no behavior change, just renames.
1735
1736         * rendering/RenderBlock.cpp:
1737         (WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
1738         (WebCore::RenderBlock::updateRegionsAndShapesAfterChildLayout):
1739         (WebCore::RenderBlock::layoutBlock):
1740         (WebCore::RenderBlock::logicalLeftOffsetForLine):
1741         (WebCore::RenderBlock::logicalRightOffsetForLine):
1742         * rendering/RenderBlock.h:
1743         * rendering/RenderDeprecatedFlexibleBox.cpp:
1744         (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
1745         * rendering/RenderFlexibleBox.cpp:
1746         (WebCore::RenderFlexibleBox::layoutBlock):
1747         * rendering/RenderGrid.cpp:
1748         (WebCore::RenderGrid::layoutBlock):
1749
1750 2013-06-19  Oliver Hunt  <oliver@apple.com>
1751
1752         Incorrect use of jsCast in a finalizer
1753         https://bugs.webkit.org/show_bug.cgi?id=117807
1754
1755         Reviewed by Geoffrey Garen.
1756
1757         We can't use jsCast in a finalizer as it checks an object's structure,
1758         and the structure may already have been swept by that point.  Use a
1759         static_cast instead.
1760
1761         * bridge/runtime_array.cpp:
1762         (JSC::RuntimeArray::destroy):
1763
1764 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
1765
1766         [Windows] AX: Extend notification handling
1767         https://bugs.webkit.org/show_bug.cgi?id=117761.
1768
1769         Reviewed by Anders Carlsson.
1770
1771         accessibility/press-works-on-control-types.html
1772
1773         * accessibility/win/AXObjectCacheWin.cpp:
1774         (WebCore::AXObjectCache::postPlatformNotification): Add handlers for more event notifications.
1775         * accessibility/win/AccessibilityObjectWrapperWin.cpp:
1776         (WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Protect against null
1777         pointer dereference found during testing.
1778         * dom/Document.cpp:
1779         (WebCore::Document::implicitClose): Execute notification handler for Windows as well as Mac.
1780         * page/FrameView.cpp:
1781         (WebCore::FrameView::layout): Ditto.
1782
1783 2013-06-19  peavo@outlook.com  <peavo@outlook.com>
1784
1785         [WinCairo] Webfont rendering is broken.
1786         https://bugs.webkit.org/show_bug.cgi?id=117695
1787
1788         Reviewed by Brent Fulgham.
1789
1790         The native font handle created from webfont data is invalid.
1791         In much the same way it's done in WinApple, we first need to install the webfont,
1792         create a native font handle from the new font name,
1793         and pass the font handle to the FontPlatformData object, where it's needed to get the glyphs.
1794
1795         * platform/graphics/FontPlatformData.h: Added HFONT parameter to constructor.
1796         * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
1797         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Release installed webfont.
1798         (WebCore::FontCustomPlatformData::fontPlatformData): Create valid HFONT handle for webfont.
1799         (WebCore::createUniqueFontName): Added method to create webfont name.
1800         (WebCore::createFontCustomPlatformData): Install font from webfont data.
1801         * platform/graphics/win/FontCustomPlatformDataCairo.h: Removed.
1802         * platform/graphics/win/FontPlatformDataCairoWin.cpp:
1803         (WebCore::FontPlatformData::FontPlatformData): Added HFONT parameter to constructor.
1804
1805 2013-06-19  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1806
1807         Implement WebIDL implements
1808         https://bugs.webkit.org/show_bug.cgi?id=117785
1809
1810         Reviewed by Kentaro Hara.
1811
1812         Add support for Web IDL 'implements' statements to the bindings generator:
1813         http://www.w3.org/TR/WebIDL/#dfn-implements-statement
1814
1815         Introduce ChildNode IDL interface and have Element, DocumentType and
1816         CharacterData implement it, to match the specification:
1817         http://dom.spec.whatwg.org/#childnode
1818
1819         There is no change in behavior, merely refactoring to match the
1820         specification by leveraging support for Web IDL implements statements.
1821
1822         No new tests, no behavior change.
1823
1824         * CMakeLists.txt:
1825         * DerivedSources.make:
1826         * DerivedSources.pri:
1827         * GNUmakefile.list.am:
1828         * bindings/scripts/generate-bindings.pl:
1829         * bindings/scripts/preprocess-idls.pl:
1830         (GeneratePartialInterface):
1831         (getImplementersFromIDL):
1832         * bindings/scripts/test/CPP/WebDOMTestImplements.cpp: Added.
1833         * bindings/scripts/test/CPP/WebDOMTestImplements.h: Added.
1834         * bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
1835         (WebDOMTestInterface::implementsStr1):
1836         (WebDOMTestInterface::implementsStr2):
1837         (WebDOMTestInterface::setImplementsStr2):
1838         (WebDOMTestInterface::implementsNode):
1839         (WebDOMTestInterface::setImplementsNode):
1840         (WebDOMTestInterface::implementsMethod1):
1841         (WebDOMTestInterface::implementsMethod4):
1842         * bindings/scripts/test/CPP/WebDOMTestInterface.h:
1843         * bindings/scripts/test/GObject/WebKitDOMTestImplements.cpp: Added.
1844         * bindings/scripts/test/GObject/WebKitDOMTestImplements.h: Added.
1845         * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
1846         (webkit_dom_test_interface_set_property):
1847         (webkit_dom_test_interface_get_property):
1848         (webkit_dom_test_interface_class_init):
1849         (webkit_dom_test_interface_implements_method1):
1850         (webkit_dom_test_interface_implements_method2):
1851         (webkit_dom_test_interface_implements_method4):
1852         (webkit_dom_test_interface_get_implements_str1):
1853         (webkit_dom_test_interface_get_implements_str2):
1854         (webkit_dom_test_interface_set_implements_str2):
1855         (webkit_dom_test_interface_get_implements_node):
1856         (webkit_dom_test_interface_set_implements_node):
1857         * bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
1858         * bindings/scripts/test/JS/JSTestImplements.cpp: Added.
1859         * bindings/scripts/test/JS/JSTestImplements.h: Added.
1860         * bindings/scripts/test/JS/JSTestInterface.cpp:
1861         (WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr):
1862         (WebCore::jsTestInterfaceConstructorImplementsStaticAttr):
1863         (WebCore::jsTestInterfaceImplementsStr1):
1864         (WebCore::jsTestInterfaceImplementsStr2):
1865         (WebCore::jsTestInterfaceImplementsStr3):
1866         (WebCore::jsTestInterfaceImplementsNode):
1867         (WebCore::setJSTestInterfaceConstructorImplementsStaticAttr):
1868         (WebCore::setJSTestInterfaceImplementsStr2):
1869         (WebCore::setJSTestInterfaceImplementsStr3):
1870         (WebCore::setJSTestInterfaceImplementsNode):
1871         (WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1):
1872         (WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
1873         (WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3):
1874         (WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4):
1875         (WebCore::jsTestInterfaceIMPLEMENTSCONSTANT1):
1876         (WebCore::jsTestInterfaceIMPLEMENTSCONSTANT2):
1877         * bindings/scripts/test/JS/JSTestInterface.h:
1878         * bindings/scripts/test/ObjC/DOMTestImplements.cpp: Added.
1879         * bindings/scripts/test/ObjC/DOMTestImplements.h: Added.
1880         * bindings/scripts/test/ObjC/DOMTestInterface.h:
1881         * bindings/scripts/test/ObjC/DOMTestInterface.mm:
1882         (-[DOMTestInterface implementsStr1]):
1883         (-[DOMTestInterface implementsStr2]):
1884         (-[DOMTestInterface setImplementsStr2:]):
1885         (-[DOMTestInterface implementsStr3]):
1886         (-[DOMTestInterface setImplementsStr3:]):
1887         (-[DOMTestInterface implementsNode]):
1888         (-[DOMTestInterface setImplementsNode:]):
1889         (-[DOMTestInterface implementsMethod1]):
1890         (-[DOMTestInterface implementsMethod2:objArg:]):
1891         (-[DOMTestInterface implementsMethod3]):
1892         (-[DOMTestInterface implementsMethod4]):
1893         * bindings/scripts/test/TestImplements.idl: Added.
1894         * dom/CharacterData.idl:
1895         * dom/ChildNode.idl: Copied from Source/WebCore/dom/DocumentType.idl.
1896         * dom/DocumentType.idl:
1897         * dom/Element.idl:
1898
1899 2013-06-19  Robert Hogan  <robert@webkit.org>
1900
1901         Incorrect computation of shrink-to-fit width for block with white-space:nowrap and floating children
1902         https://bugs.webkit.org/show_bug.cgi?id=114879
1903
1904         Reviewed by David Hyatt.
1905         Per http://www.w3.org/TR/CSS21/visudet.html#Computing_widths_and_margins when width is auto then floating non-replaced,
1906         absolute non-replaced, and inline-block non-replaced elements should use shrink-to-fit width. This trumps any no-wrap property 
1907         on the element so if we are shrinking to fit ensure our minimum width respects all possible line breaks.
1908
1909         Test: fast/block/shrink-to-fit-width-container-with-floating-children.html
1910
1911         * rendering/RenderBlock.cpp:
1912         (WebCore::RenderBlock::computeIntrinsicLogicalWidths):
1913
1914 2013-06-19  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1915
1916         Do not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter] is used
1917         https://bugs.webkit.org/show_bug.cgi?id=117795
1918
1919         Reviewed by Kentaro Hara.
1920
1921         Fix the JS bindings generator so that it stops including JS*Custom.h header whenever
1922         [CustomPutFunction] or [CustomNamedSetter] IDL extended attributes are used. We don't
1923         really need this custom header and this forces the developer to create dummy custom
1924         headers so that it builds.
1925
1926         If the developer really needs such custom header to be included, he can still use
1927         [JSCustomHeader] IDL extended attribute to do so.
1928
1929         This patch also remove the dummy custom headers that were created but are no longer
1930         required to build.
1931
1932         No new tests, no behavior change. Already covered by the following bindings test:
1933         TestInterface.idl
1934
1935         * GNUmakefile.list.am:
1936         * Target.pri:
1937         * WebCore.vcxproj/WebCore.vcxproj:
1938         * WebCore.vcxproj/WebCore.vcxproj.filters:
1939         * WebCore.xcodeproj/project.pbxproj:
1940         * bindings/js/JSDOMStringMapCustom.h: Removed.
1941         * bindings/js/JSHTMLAppletElementCustom.cpp:
1942         * bindings/js/JSHTMLAppletElementCustom.h: Removed.
1943         * bindings/js/JSHTMLEmbedElementCustom.cpp:
1944         * bindings/js/JSHTMLEmbedElementCustom.h: Removed.
1945         * bindings/js/JSHTMLObjectElementCustom.cpp:
1946         * bindings/js/JSHTMLObjectElementCustom.h: Removed.
1947         * bindings/js/JSHistoryCustom.cpp:
1948         * bindings/js/JSHistoryCustom.h: Removed.
1949         * bindings/js/JSLocationCustom.cpp:
1950         * bindings/js/JSLocationCustom.h: Removed.
1951         * bindings/js/JSStorageCustom.cpp:
1952         * bindings/js/JSStorageCustom.h: Removed.
1953         * bindings/scripts/CodeGeneratorJS.pm:
1954         (GenerateHeader):
1955
1956 2013-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1957
1958         [BlackBerry] Several tests crash due to an assert when creating an ImageBuffer
1959         https://bugs.webkit.org/show_bug.cgi?id=117793
1960
1961         Reviewed by Rob Buis.
1962
1963         JIRA 388741
1964
1965         Fixes a crash in several layout tests due to an assert when
1966         creating an ImageBuffer with an empty size.
1967
1968         * platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
1969         (WebCore::ImageBuffer::ImageBuffer): Return early if the given
1970         size is empty.
1971
1972 2013-06-19  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
1973
1974         [GStreamer] [texmap] the bytesPerLine is wrong when updating the texture
1975         https://bugs.webkit.org/show_bug.cgi?id=117551
1976
1977         Reviewed by Philippe Normand.
1978
1979         The bytesPerLine (or stride) is wrong when updating the texture
1980         content. This is because the naturalSize() is not updated to the
1981         current buffer. This patch extracts the current value of the size and
1982         the stride.
1983
1984         No tests required.
1985
1986         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1987         (WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
1988         (WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
1989
1990 2013-06-19  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
1991
1992         Adjust internal size on gstreamer source element when receiving data if necessary
1993         https://bugs.webkit.org/show_bug.cgi?id=116534
1994
1995         Reviewed by Philippe Normand.
1996
1997         If the size received in didReceiveResponse is smaller than the actual size of the received data
1998         update the internal size and the appsrc size to the proper value.
1999
2000         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
2001         (StreamingClient::didReceiveData):
2002
2003 2013-06-19  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2004
2005         [GStreamer] Potential race condition when getting the video sink caps.
2006         https://bugs.webkit.org/show_bug.cgi?id=117736
2007
2008         Reviewed by Philippe Normand.
2009
2010         There is a potential race condition with the pad setting caps, as the
2011         buffer and the caps won't match when renegotiation happens, and might
2012         cause a crash.
2013
2014         This patch keeps an instance of the current caps in the video sink,
2015         and it is accessible through a getter method. Hence the player can ask
2016         for the current caps without running into a race condition.
2017
2018         No new tests. No change in behaviour.
2019
2020         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
2021         (WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
2022         (WebCore::MediaPlayerPrivateGStreamerBase::paint):
2023         (WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):
2024         (WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
2025         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
2026         * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
2027         (webkitVideoSinkGetProperty):
2028         (webkitVideoSinkStop):
2029         (webkitVideoSinkSetCaps):
2030         (webkit_video_sink_class_init):
2031
2032 2013-06-19  Kihong Kwon  <kihong.kwon@samsung.com>
2033
2034         Vibration can be canceled even if page visibility status is hidden
2035         https://bugs.webkit.org/show_bug.cgi?id=117333
2036
2037         Reviewed by Gyuyoung Kim.
2038
2039         vibration can be canceled in the onvisibilitychange listener even if page visibility is changed to hidden status.
2040         Therefore cancelVibration needs to work when page visibility is hidden.
2041
2042         Tests: vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html
2043
2044         * Modules/vibration/NavigatorVibration.cpp:
2045         (WebCore::NavigatorVibration::vibrate):
2046         * Modules/vibration/Vibration.h:
2047         (WebCore::Vibration::isVibrating):
2048         * testing/Internals.cpp:
2049         (WebCore::Internals::isVibrating):
2050         * testing/Internals.h:
2051         * testing/Internals.idl:
2052
2053 2013-06-18  Ryosuke Niwa  <rniwa@webkit.org>
2054
2055         Input type range slider is not updated when min or max are changed
2056         https://bugs.webkit.org/show_bug.cgi?id=117778
2057
2058         Reviewed by Kent Tamura.
2059
2060         Merge https://chromium.googlesource.com/chromium/blink/+/089c7a0ba2d85b9b59632c2603fbc6472b310be1.
2061
2062         Test: fast/forms/range/range-change-min-max.html
2063
2064         * html/RangeInputType.cpp:
2065         (WebCore::RangeInputType::minOrMaxAttributeChanged):
2066
2067 2013-06-18  Ryosuke Niwa  <rniwa@webkit.org>
2068
2069         Remove two superfluous overrides of supportsFocus
2070         https://bugs.webkit.org/show_bug.cgi?id=117770
2071
2072         Reviewed by Benjamin Poulain.
2073
2074         Merge https://chromium.googlesource.com/chromium/blink/+/4228964a63e3a889a40efce0d01866629fdcd9b9.
2075
2076         * html/HTMLOptGroupElement.cpp:
2077         * html/HTMLOptGroupElement.h:
2078         * html/HTMLOptionElement.cpp:
2079         * html/HTMLOptionElement.h:
2080
2081 2013-06-18  Darin Adler  <darin@apple.com>
2082
2083         Improve style of null checks in FrameView::setFrameRect
2084         https://bugs.webkit.org/show_bug.cgi?id=117681
2085
2086         Reviewed by Sam Weinig.
2087
2088         * page/FrameView.cpp:
2089         (WebCore::FrameView::setFrameRect): Used nested if statements and local variables
2090         to tighten this code up a little.
2091
2092 2013-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2093
2094         Move IDL extended attributes to their correct location
2095         https://bugs.webkit.org/show_bug.cgi?id=117732
2096
2097         Reviewed by Kentaro Hara.
2098
2099         Move IDL extended attributes to their correct location according to the
2100         latest Web IDL specification. We used to be inconsistent in the positioning
2101         of the extended attributes. This simplifies a lot the code of the IDL parser
2102         and makes our IDL files more standard.
2103
2104         Based on Blink r148345 by Kentaro Hara <haraken@chromium.org>.
2105
2106         No new tests, no behavior change.
2107
2108         * Modules/encryptedmedia/MediaKeyMessageEvent.idl:
2109         * Modules/notifications/Notification.idl:
2110         * Modules/speech/SpeechSynthesisVoice.idl:
2111         * bindings/scripts/IDLParser.pm:
2112         (parseDefinitions):
2113         (parseInterfaceMembers):
2114         (parseInterfaceMember):
2115         (parseDictionaryMembers):
2116         (parseAttributeOrOperationOrIterator):
2117         (parseAttribute):
2118         * css/CSSFontFaceLoadEvent.idl:
2119         * dom/Document.idl:
2120         * dom/Element.idl:
2121         * dom/Node.idl:
2122         * html/HTMLBodyElement.idl:
2123         * html/HTMLEmbedElement.idl:
2124         * html/HTMLFrameSetElement.idl:
2125         * html/HTMLMediaElement.idl:
2126         * html/HTMLSelectElement.idl:
2127         * html/HTMLSourceElement.idl:
2128         * page/DOMWindow.idl:
2129         * svg/SVGElementInstance.idl:
2130         * svg/SVGScriptElement.idl:
2131         * testing/TypeConversions.idl:
2132
2133 2013-06-18  Jessie Berlin  <jberlin@apple.com>
2134
2135         Let the script to update the Localizable.strings file do the reordering it wants to do.
2136
2137         Rubber-stamped by Anders Carlsson.
2138
2139         * English.lproj/Localizable.strings:
2140
2141 2013-06-18  Brent Fulgham  <bfulgham@apple.com>
2142
2143         [Windows] Unreviewed gardening -- show missing AccessibilityNodeObject source
2144         files in Visual Studio.
2145
2146         * WebCore.vcxproj/WebCore.vcxproj: Add missing files.
2147         * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
2148
2149 2013-06-18  Commit Queue  <commit-queue@webkit.org>
2150
2151         Unreviewed, rolling out r151513.
2152         http://trac.webkit.org/changeset/151513
2153         https://bugs.webkit.org/show_bug.cgi?id=117763
2154
2155         It causes assertions in debug (Requested by benjaminp on
2156         #webkit).
2157
2158         * rendering/RenderLayerBacking.cpp:
2159         (WebCore::RenderLayerBacking::startAnimation):
2160         (WebCore::RenderLayerBacking::startTransition):
2161
2162 2013-06-18  Roger Fong  <roger_fong@apple.com>
2163
2164         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
2165         <rdar://problem/14118143>.
2166
2167         Rubberstamped by Brent Fulgham.
2168
2169         * WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj:
2170         * WebCore.vcxproj/QTMovieWin/QTMovieWinCairoDebug.props:
2171         * WebCore.vcxproj/QTMovieWin/QTMovieWinCairoRelease.props:
2172         * WebCore.vcxproj/QTMovieWin/QTMovieWinDebug.props:
2173         * WebCore.vcxproj/QTMovieWin/QTMovieWinPostBuild.cmd:
2174         * WebCore.vcxproj/QTMovieWin/QTMovieWinProduction.props:
2175         * WebCore.vcxproj/QTMovieWin/QTMovieWinRelease.props:
2176         * WebCore.vcxproj/WebCore.vcxproj:
2177         * WebCore.vcxproj/WebCoreDebug.props:
2178         * WebCore.vcxproj/WebCoreDebugWinCairo.props:
2179         * WebCore.vcxproj/WebCoreGenerated.vcxproj:
2180         * WebCore.vcxproj/WebCoreGeneratedDebug.props:
2181         * WebCore.vcxproj/WebCoreGeneratedDebugWinCairo.props:
2182         * WebCore.vcxproj/WebCoreGeneratedProduction.props:
2183         * WebCore.vcxproj/WebCoreGeneratedRelease.props:
2184         * WebCore.vcxproj/WebCoreGeneratedReleaseWinCairo.props:
2185         * WebCore.vcxproj/WebCoreProduction.props:
2186         * WebCore.vcxproj/WebCoreRelease.props:
2187         * WebCore.vcxproj/WebCoreReleaseWinCairo.props:
2188         * WebCore.vcxproj/WebCoreTestSupport.vcxproj:
2189         * WebCore.vcxproj/build-generated-files.sh:
2190
2191 2013-06-18  Zoltan Horvath  <zoltan@webkit.org>
2192
2193         [CSS Shapes] Remove lineOverflowsFromShapeInside boolean from RenderBlock::layoutRunsAndFloatsInRange function
2194         https://bugs.webkit.org/show_bug.cgi?id=117757
2195
2196         Reviewed by David Hyatt.
2197
2198         We don't need keep lineOverflowsFromShapeInside boolean in RenderBlock::layoutRunsAndFloatsInRange and in its
2199         helpers because it's easy to decide whether we are in an shape content overflow state or not, so I got rid of
2200         lineOverflowsFromShapeInside's occurences and updated the affected functions.
2201
2202         Covered by existing overflow tests in fast/exclusions/shape-inside and fast/regions/shape-inside.
2203
2204         * rendering/RenderBlock.h: Update helper's definition.
2205         * rendering/RenderBlockLineLayout.cpp:
2206         (WebCore::pushShapeContentOverflowBelowTheContentBox): Add condition when overflow is already positioned.
2207         (WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Remove lineOverflowsFromShapeInside.
2208         (WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread):  Remove lineOverflowsFromShapeInside.
2209         (WebCore::RenderBlock::layoutRunsAndFloatsInRange):  Remove lineOverflowsFromShapeInside.
2210
2211 2013-06-18  Zalan Bujtas  <zalan@apple.com>
2212
2213         widthMediaFeatureEval ends up with null FrameView during iframe unload.
2214         https://bugs.webkit.org/show_bug.cgi?id=117754
2215
2216         Reviewed by Geoffrey Garen.
2217
2218         Ensure that MediaQueryEvaluator checks against NULL FrameView.
2219
2220         While frames are being unloaded, the Frame object does not necessarily have valid
2221         FrameView anymore. Layout on the main frame can end up querying media values on such child
2222         frames, while detaching.
2223
2224         Test: fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html
2225
2226         * css/MediaQueryEvaluator.cpp:
2227         (WebCore::orientationMediaFeatureEval):
2228         (WebCore::aspect_ratioMediaFeatureEval):
2229         (WebCore::evalResolution):
2230         (WebCore::heightMediaFeatureEval):
2231         (WebCore::widthMediaFeatureEval):
2232         (WebCore::MediaQueryEvaluator::eval):
2233
2234 2013-06-18  Ruth Fong  <ruth_fong@apple.com>
2235
2236         Expose a getMediaType method in WebKit
2237         https://bugs.webkit.org/show_bug.cgi?id=117667
2238
2239         Reviewed by Brady Eidson.
2240
2241         * WebCore.exp.in: Updated to add a symbol for 
2242         HitTestResult::mediaIsVideo method
2243         and alphabetize the list of exposed methods.
2244
2245 2013-06-18  Ryosuke Niwa  <rniwa@webkit.org>
2246
2247         Remove unused bool argument from ReplacementFragment's constructor
2248         https://bugs.webkit.org/show_bug.cgi?id=117752
2249
2250         Reviewed by Antti Koivisto.
2251
2252         Merge https://chromium.googlesource.com/chromium/blink/+/265586d9f154a9dff657511d09926429b8e1b53d.
2253
2254         * editing/ReplaceSelectionCommand.cpp:
2255         (WebCore::ReplacementFragment::ReplacementFragment):
2256         (WebCore::ReplaceSelectionCommand::doApply):
2257
2258 2013-06-18  Eric Carlson  <eric.carlson@apple.com>
2259
2260         Not all subtitle tracks are SDH
2261         https://bugs.webkit.org/show_bug.cgi?id=117738
2262
2263         Reviewed by Dean Jackson.
2264
2265         No new tests, existing tests updated.
2266
2267         * html/track/InbandTextTrack.cpp:
2268         (WebCore::InbandTextTrack::isSDH): New.
2269
2270         * html/track/InbandTextTrack.h: Add isSDH override.
2271         * html/track/TextTrack.h:
2272
2273         * page/CaptionUserPreferencesMac.mm:
2274         (WebCore::trackDisplayName): Only add "SDH" label if a track claims to be SDH.
2275
2276         * platform/graphics/InbandTextTrackPrivate.h:
2277         (WebCore::InbandTextTrackPrivate::isSDH): New.
2278
2279         * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
2280         * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
2281         (WebCore::InbandTextTrackPrivateAVFObjC::isSDH): Return true if track has both "transcribes
2282             spoken dialog for accessibility" and "describes music and sound for accessibility" 
2283             characteristics.
2284
2285 2013-06-18  Ryosuke Niwa  <rniwa@webkit.org>
2286
2287         Simplify FormKeyGenerator::willDeleteForm
2288         https://bugs.webkit.org/show_bug.cgi?id=117751
2289
2290         Reviewed by Antti Koivisto.
2291
2292         Merge https://chromium.googlesource.com/chromium/blink/+/c6399efb9da863eb1d1fc98b17ef925998b985ac
2293
2294         * html/FormController.cpp:
2295         (WebCore::FormKeyGenerator::willDeleteForm):
2296
2297 2013-06-18  Ryosuke Niwa  <rniwa@webkit.org>
2298
2299         REGRESSION(r147602): Search text field doesn't render selection when it has some :focus rules
2300         https://bugs.webkit.org/show_bug.cgi?id=117747
2301
2302         Reviewed by Kent Tamura.
2303
2304         Merge https://chromium.googlesource.com/chromium/blink/+/7ff656c8239ce3b125246abcc8b149a603fcff28
2305
2306         r147612 added setNeedsLayout(true, MarkOnlyThis) for
2307         TextControlInnerTextElement renderer. It's ok for input[type=text]
2308         because RenderTextControlSingleLine also has needsLayout flag, and it
2309         has only the inner text renderer as a child.
2310
2311         As for input[type=search], it doesn't work. Renderer structure for
2312         input[type=search] is:
2313
2314         RenderTextControlSingleLine
2315         └Renderer for TextControlInnerContainer
2316           └Renderer for TextControlInnerElement
2317             └Renderer for TextControlInnerTextElement
2318
2319         After r147612, there is a case that only RenderTextControlSingleLine
2320         and TextControlInnerTextElement renderer have needsLayout flag, and
2321         others don't.  It won't trigger layout for
2322         TextControlInnerTextElement renderer.
2323
2324         We should set needsLayout flags of TextControlInnerContainer renderer
2325         and TextControlInnerElement renderer by MarkContainingBlockChain.
2326
2327         Manual Tests: search-select-all-with-focus-style.html
2328         (I tried but couldn't make a test that works in DRT)
2329
2330         * rendering/RenderTextControlSingleLine.cpp:
2331         (WebCore::RenderTextControlSingleLine::styleDidChange):
2332
2333 2013-06-18  Dean Jackson  <dino@apple.com>
2334
2335         Attempted build fix for non-Mac.
2336
2337         * platform/graphics/SimpleFontData.cpp:
2338         (WebCore::SimpleFontData::nonSyntheticItalicFontData):
2339
2340 2013-06-18  Dean Jackson  <dino@apple.com>
2341
2342         Synthesized vertical italics on rotated glyphs are transformed incorrectly
2343         https://bugs.webkit.org/show_bug.cgi?id=117726
2344
2345         Reviewed by Enrica Casucci.
2346
2347         If a font does not have italic glyphs, and is in a vertical flow, then
2348         the synthesis of italics was skewing in the wrong direction. While here,
2349         ensure that no CJK text will get italics in vertical layout.
2350
2351         This is a topic under discussion in the CSS Working Group. The resolution
2352         at the June 2013 face-to-face was that:
2353         - italics in Japanese (and Chinese) text are rare in vertical layout
2354         - most people wanted Latin text to italicize in the direction of the line flow
2355
2356         The final behaviour was left undefined, but we consider the change here
2357         to be sufficient for now. In all cases, the best solution is to avoid
2358         synthesized italics by specifying a font that includes such forms.
2359
2360         Tests: fast/text/international/synthesized-italic-vertical-latin.html
2361                fast/text/international/synthesized-italic-vertical.html
2362
2363         * platform/graphics/FontGlyphs.cpp:
2364         (WebCore::glyphDataAndPageForCJKCharacterWithoutSyntheticItalic): New function
2365             that makes a new glyph data pair that is marked as NOT using a synthesized italic.
2366         (WebCore::FontGlyphs::glyphDataAndPageForCharacter): If this is a CJK character and
2367             has a synthesized oblique, then run it through the function above to make a new glyph data pair.
2368         * platform/graphics/SimpleFontData.cpp:
2369         (WebCore::SimpleFontData::nonSyntheticItalicFontData): Creates/returns a new SimpleFontData that will
2370             not synthesize italics.
2371         * platform/graphics/SimpleFontData.h: New method nonSyntheticItalicFontData.
2372         * platform/graphics/mac/FontMac.mm:
2373         (WebCore::Font::drawGlyphs): This is the actual bug fix. If you are in a vertical flow, the
2374             skew direction should be downwards, not leftwards.
2375
2376 2013-06-18  Commit Queue  <commit-queue@webkit.org>
2377
2378         Unreviewed, rolling out r151549.
2379         http://trac.webkit.org/changeset/151549
2380         https://bugs.webkit.org/show_bug.cgi?id=117741
2381
2382         broke selection in the web inspector source after scrolling
2383         (Requested by smfr on #webkit).
2384
2385         * rendering/RenderBox.cpp:
2386         (WebCore::RenderBox::computeRectForRepaint):
2387         * rendering/RenderLayerModelObject.cpp:
2388         * rendering/RenderLayerModelObject.h:
2389
2390 2013-06-18  Santosh Mahto  <santosh.ma@samsung.com>
2391
2392         <video> element delays document load event for ~ 3 seconds
2393         https://bugs.webkit.org/show_bug.cgi?id=90272
2394
2395         Reviewed by Eric Carlson.
2396
2397         Test: media/media-preload-no-delay-loadevent.html
2398
2399         * html/HTMLMediaElement.cpp:
2400         (WebCore::HTMLMediaElement::prepareForLoad):
2401         No need to delay document load event here  when preload="none"
2402
2403 2013-06-18  Diego Pino Garcia  <dpino@igalia.com>
2404
2405         [GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used by ObjC bindings only)
2406         https://bugs.webkit.org/show_bug.cgi?id=117546
2407
2408         Reviewed by Xan Lopez.
2409
2410         According to the WebKit IDL spec the modifier ObjCPolymorphic only
2411         applies to the Objective-C bindings generator
2412
2413         * bindings/scripts/CodeGeneratorGObject.pm:
2414         (IsPolymorphic): Remove comment. Search parameter 'type' in array, instead of
2415         concatening a series of 'or' conditionals.
2416
2417 2013-06-18  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2418
2419         Fix after r151673
2420         https://bugs.webkit.org/show_bug.cgi?id=116042
2421
2422         Reviewed by Philippe Normand.
2423
2424         Removed a spurious semicolon in the video sink caps definition.
2425
2426         No new tests, no behavior change.
2427
2428         * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
2429
2430 2013-06-18  Praveen R Jadhav  <praveen.j@samsung.com>
2431
2432         [WebSpeech] Speech Recognition requires convertValue support in JSDictionary
2433         https://bugs.webkit.org/show_bug.cgi?id=117731
2434
2435         Reviewed by Christophe Dumez.
2436
2437         Build fails after enabling ENABLE_SCRIPTED_SPEECH feature. This patch
2438         resolves the issue.
2439
2440         No new tests. No change in behaviour.
2441
2442         * bindings/js/JSDictionary.cpp:
2443         (WebCore::JSDictionary::convertValue):
2444         * bindings/js/JSDictionary.h:
2445
2446 2013-06-18  Mary Wu  <mary.wu@torchmobile.com.cn>
2447
2448         [BlackBerry] only notify download client when download error
2449         https://bugs.webkit.org/show_bug.cgi?id=117687
2450
2451         Reviewed by Rob Buis.
2452
2453         When met network error in downloading, we notify the error to download
2454         client through download stream, we shouldn't notify page client the error.
2455         RIM JIRA 419985
2456
2457         * platform/network/blackberry/NetworkJob.cpp:
2458         (WebCore::NetworkJob::shouldNotifyClientFailed):
2459
2460 2013-06-18  Mario Sanchez Prada  <mario.prada@samsung.com>
2461
2462         Shader compiler not properly configured for GLES on cairo based ports
2463         https://bugs.webkit.org/show_bug.cgi?id=117705
2464
2465         Reviewed by Martin Robinson.
2466
2467         Configure the shader compiler with SH_ESSL_OUTPUT for GLESv2
2468         compliant platforms, and with SH_GLSL_OUTPUT otherwise.
2469
2470         * platform/graphics/cairo/GraphicsContext3DCairo.cpp:
2471         (WebCore::GraphicsContext3D::GraphicsContext3D):
2472
2473 2013-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2474
2475         touching any idl rebuilds all derived sources
2476         https://bugs.webkit.org/show_bug.cgi?id=117708
2477
2478         Reviewed by Kentaro Hara.
2479
2480         Fix preprocess-idls.pl script to update the following files only
2481         if they have changed:
2482         DerivedSources/WebCore/supplemental_dependency.tmp
2483         DerivedSources/WebCore/DOMWindowConstructors.idl
2484         DerivedSources/WebCore/WorkerContextConstructors.idl
2485
2486         This avoids triggering uselessly bindings generation for all IDL
2487         files whenever an IDL file is touched.
2488
2489         No new tests, no behavior change.
2490
2491         * bindings/scripts/preprocess-idls.pl:
2492         (WriteFileIfChanged):
2493         (GeneratePartialInterface):
2494
2495 2013-06-18  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2496
2497         [GStreamer] [texmap] upload a video buffer into the video texture
2498         https://bugs.webkit.org/show_bug.cgi?id=116042
2499
2500         Reviewed by Philippe Normand.
2501
2502         This patch prepares more quickly the texture when the video frame is
2503         already in the GPU memory.
2504
2505         It is done using a new buffer's metadata available in GStreamer 1.2,
2506         and its purpose is to upload buffers into a OpenGL texture.
2507
2508         If the decoder provides buffers with this metadata, the buffer will be
2509         uploaded into the texture used for the video display and it will be
2510         rendered, avoiding a expensive mem copies. This is particularly useful
2511         for Full HD videos, where all the processing and display will be done
2512         in the GPU.
2513
2514         No new tests, covered by existing tests.
2515
2516         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
2517         (WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
2518         (WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
2519         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
2520         * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
2521         (webkitVideoSinkProposeAllocation):
2522
2523 2013-06-17  Peter Gal  <galpeter@inf.u-szeged.hu>
2524
2525         [curl] Set the http response status text
2526         https://bugs.webkit.org/show_bug.cgi?id=117307
2527
2528         Reviewed by Brent Fulgham.
2529
2530         No new tests, covered by existing ones.
2531
2532         * platform/network/curl/ResourceHandleManager.cpp:
2533         (WebCore::headerCallback):
2534
2535 2013-06-14  Brent Fulgham  <bfulgham@apple.com>
2536
2537         AX: Correct accessibility role when -webkit-box:display is used.
2538         https://bugs.webkit.org/show_bug.cgi?id=117706
2539
2540         Reviewed by Chris Fleizach.
2541
2542         accessibility/box-styled-lists.html
2543
2544         * accessibility/AccessibilityRenderObject.cpp:
2545         (WebCore::AccessibilityRenderObject::determineAccessibilityRole): If HTML token is
2546         of the list element type, treat it as a ListItemRole accessibility role, regardless
2547         of what specific renderer is being used.
2548
2549 2013-06-17  Roger Fong  <roger_fong@apple.com>
2550
2551         Add some UNUSED_PARAMs to RenderBlock.cpp so that it builds properly if CSS_EXCLUSIONS is disabled.
2552         https://bugs.webkit.org/show_bug.cgi?id=117722.
2553
2554         Rubberstamped by Jon Lee.
2555
2556         * rendering/RenderBlock.cpp:
2557         (WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
2558         (WebCore::RenderBlock::logicalLeftOffsetForLine):
2559         (WebCore::RenderBlock::logicalRightOffsetForLine):
2560
2561 2013-06-17  Beth Dakin  <bdakin@apple.com>
2562
2563         PageBanners appear over HTML5 video when media element is in full screen mode
2564         https://bugs.webkit.org/show_bug.cgi?id=117721
2565         -and corresponding-
2566         <rdar://problem/13686998>
2567
2568         Reviewed by Sam Weinig.
2569
2570         Update the scrolling tree when a header/footer has been removed.
2571         * rendering/RenderLayerCompositor.cpp:
2572         (WebCore::RenderLayerCompositor::updateLayerForHeader):
2573         (WebCore::RenderLayerCompositor::updateLayerForFooter):
2574
2575 2013-06-17  Roger Fong  <roger_fong@apple.com>
2576
2577         Modify Windows makefiles to copy some bin output into Program Files.
2578         https://bugs.webkit.org/show_bug.cgi?id=117714.
2579         <rdar://problem/14179054>
2580
2581         Reviewed by Brent Fulgham.
2582
2583         * WebCore.vcxproj/WebCore.make:
2584
2585 2013-06-17  Max Vujovic  <mvujovic@adobe.com>
2586
2587         Crash in loadPendingShaders
2588         https://bugs.webkit.org/show_bug.cgi?id=117665
2589
2590         Reviewed by Dean Jackson.
2591
2592         Speculative fix because the crash reports do not contain a test case.
2593
2594         Rearrange the conditions to check m_state.hasPendingShaders() first. Additionally, check if
2595         m_state.style() is non-null.
2596
2597         No new tests. We don't know how to reproduce this crash yet.
2598
2599         * css/StyleResolver.cpp:
2600         (WebCore::StyleResolver::loadPendingShaders):
2601
2602 2013-06-17  Ruth Fong  <ruth_fong@apple.com>
2603
2604         REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime
2605         https://bugs.webkit.org/show_bug.cgi?id=20599
2606
2607         Add a "Download Video"/"Download Audio" context menu item to download media
2608         elements.
2609
2610         Reviewed by Beth Dakin.
2611
2612         No new tests. media/context-menu-action.html,
2613         which has been disabled by bug 116651, is used to test context menus.
2614
2615         * English.lproj/Localizable.strings: Updated to
2616         include localizable strings for "Download Video" and "Download Audio".
2617
2618         * page/ContextMenuController.cpp: Updated to 
2619         include and handle a "Download Video/Audio" context menu item.
2620
2621         * platform/ContextMenuItem.h:
2622
2623         * platform/LocalizedStrings.cpp: 
2624         * platform/LocalizedStrings.h:
2625         * platform/efl/LocalizedStringsEfl.cpp:
2626         * platform/gtk/LocalizedStringsGtk.cpp:
2627         * platform/qt/LocalizedStringsQt.cpp: 
2628         Updated to include localizable strings for "Download Video" and "Download Audio".
2629
2630 2013-06-17  Zoltan Horvath  <zoltan@webkit.org>
2631
2632         [CSS Shapes] Consider bottom borders when calculating the position of the overflow
2633         https://bugs.webkit.org/show_bug.cgi?id=117663
2634
2635         Reviewed by Alexandru Chiculita.
2636
2637         When you have a shape and the content overflows from the shape we need to push the overflow below the content box,
2638         not below the border box. We didn't consider the bottom borders of the content box, now I fixed it too and the overflow
2639         just starts after the content box. I added a new helper function called pushShapeContentOverflowBelowTheContentBox. Now
2640         both the shape in flow thread and the shape overflow use the same function. I added a new test and modified the existing
2641         tests to cover all the affected cases.
2642
2643         Test: fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
2644         Existing overflow tests also modified to test the behavior:
2645               fast/exclusions/shape-inside/shape-inside-empty-expected.html
2646               fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html
2647               fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
2648               fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html
2649               fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html
2650               fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html
2651               fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html
2652
2653         * rendering/RenderBlockLineLayout.cpp:
2654         (WebCore::pushShapeContentOverflowBelowTheContentBox):
2655         (WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine):
2656         (WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread):
2657
2658 2013-06-17  Igor Oliveira  <igor.o@sisa.samsung.com>
2659
2660         [CSS Regions] ::before and ::after pseudo-elements are not displayed for regions
2661         https://bugs.webkit.org/show_bug.cgi?id=80163
2662
2663         When the implementation of the before/after was moved to the DOM, before/after generated
2664         content stoppped to work with css regions. The problem happens when:
2665         1. RenderRegion can not have children and when the PseudoElement::attach tries to create a renderer for the
2666         generated content, it fails.
2667         2. RenderRegion::canHaveGeneratedChildren should not be false because regions can have generated content.
2668
2669         Reviewed by David Hyatt.
2670
2671         Tests: fast/regions/region-dynamic-after-before.html
2672                fast/regions/region-generated-content-before-after.html
2673
2674         * dom/NodeRenderingContext.cpp:
2675         (WebCore::NodeRenderingContext::shouldCreateRenderer):
2676         * rendering/RenderRegion.h:
2677
2678 2013-06-17  Michael Brüning  <michael.bruning@digia.com>
2679
2680         [Mac] Remove unmaintained GStreamer specific video code.
2681         https://bugs.webkit.org/show_bug.cgi?id=117694
2682
2683         Reviewed by Philippe Normand.
2684
2685         No new tests, no behaviour change.
2686
2687         * platform/mac/WebVideoFullscreenController.mm:
2688         (-[WebVideoFullscreenController setupVideoOverlay:]):
2689         (-[WebVideoFullscreenController windowDidLoad]):
2690         (-[WebVideoFullscreenController setMediaElement:]):
2691         (-[WebVideoFullscreenController windowDidExitFullscreen]):
2692
2693 2013-06-17  Michael Brüning  <michael.bruning@digia.com>
2694
2695         [Qt] Remove Qt specific QTKIT flagged code.
2696         https://bugs.webkit.org/show_bug.cgi?id=117635
2697
2698         Reviewed by Simon Hausmann.
2699
2700         Due to disabling QTKIT for Qt in r151546, the
2701         code the flags that are not taken into account
2702         anymore and the code that has been rendered
2703         unreachable by this are removed.
2704
2705         No new tests, no behavioural change.
2706
2707         * Target.pri:
2708         * WebCore.exp.in:
2709         * page/Settings.cpp:
2710         * page/Settings.h:
2711         * platform/KURL.h:
2712         * platform/SharedBuffer.h:
2713         * platform/cf/KURLCFNet.cpp:
2714         (WebCore::KURL::fileSystemPath):
2715         * platform/cf/SharedBufferCF.cpp:
2716         * platform/graphics/FloatSize.h:
2717         * platform/graphics/IntRect.h:
2718         * platform/graphics/IntSize.h:
2719         * platform/graphics/MediaPlayer.cpp:
2720         (WebCore::installedMediaEngines):
2721         * platform/graphics/cg/FloatSizeCG.cpp:
2722         * platform/graphics/cg/IntRectCG.cpp:
2723         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
2724         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2725         (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
2726         (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
2727         (WebCore::MediaPlayerPrivateQTKit::paint):
2728         (-[WebCoreMovieObserver layerHostChanged:]):
2729         * platform/mac/SharedBufferMac.mm:
2730         (+[WebCoreSharedBufferData initialize]):
2731         (WebCore::SharedBuffer::createWithContentsOfFile):
2732
2733 2013-06-17  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2734
2735         REGRESSSION(r151632) : Build error on ASSERT(WTF_USE_GRAMMAR_CHECKING)
2736         https://bugs.webkit.org/show_bug.cgi?id=117692
2737
2738         Reviewed by Jocelyn Turcotte.
2739
2740         Ifdef the feature-depending code and fix the assertions to check runtime conditions.
2741
2742         * editing/Editor.cpp:
2743         (WebCore::Editor::advanceToNextMisspelling):
2744         (WebCore::Editor::markMisspellingsOrBadGrammar):
2745         (WebCore::Editor::markBadGrammar):
2746         * editing/TextCheckingHelper.cpp:
2747         (WebCore::findBadGrammars):
2748         (WebCore::TextCheckingHelper::findFirstGrammarDetail):
2749         (WebCore::TextCheckingHelper::findFirstBadGrammar):
2750         (WebCore::TextCheckingHelper::isUngrammatical):
2751         (WebCore::TextCheckingHelper::markAllBadGrammar):
2752         (WebCore::checkTextOfParagraph):
2753         * editing/TextCheckingHelper.h:
2754
2755 2013-06-17  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2756
2757         Unreviewed, rolling out r151632.
2758         http://trac.webkit.org/changeset/151632
2759         https://bugs.webkit.org/show_bug.cgi?id=117585
2760
2761         Debug build error ASSERT(WTF_USE_GRAMMAR_CHECKING) for non MAC
2762         platforms
2763
2764         * page/ContextMenuController.cpp:
2765         (WebCore::ContextMenuController::contextMenuItemSelected):
2766         (WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
2767         (WebCore::ContextMenuController::populate):
2768         (WebCore::ContextMenuController::checkOrEnableIfNeeded):
2769         * platform/LocalizedStrings.cpp:
2770         (WebCore::contextMenuItemTagSpellingMenu):
2771         (WebCore::contextMenuItemTagShowSpellingPanel):
2772         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2773         * platform/LocalizedStrings.h:
2774         * platform/efl/LocalizedStringsEfl.cpp:
2775         (WebCore::contextMenuItemTagSpellingMenu):
2776         (WebCore::contextMenuItemTagShowSpellingPanel):
2777         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2778         * platform/gtk/LocalizedStringsGtk.cpp:
2779         (WebCore::contextMenuItemTagSpellingMenu):
2780         (WebCore::contextMenuItemTagShowSpellingPanel):
2781         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2782         * platform/qt/LocalizedStringsQt.cpp:
2783         (WebCore::contextMenuItemTagSpellingMenu):
2784         (WebCore::contextMenuItemTagShowSpellingPanel):
2785         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2786
2787 2013-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2788
2789         Unreviewed. Fix make distcheck.
2790
2791         * GNUmakefile.list.am: Remove non existent files from compilation
2792         and add a missing header file.
2793
2794 2013-06-14  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2795
2796         Context menu grammar checking items are available when GRAMMAR_CHECKING macro is off
2797         https://bugs.webkit.org/show_bug.cgi?id=117585
2798
2799         Reviewed by Anders Carlsson.
2800
2801         Do not add "Check Grammar With Spelling" and "Ignore Grammar" to the context menu
2802         when GRAMMAR_CHECKING is off.
2803         Replace "Spelling and Grammar" with "Spelling" as the sub menu title and "Show/Hide Spelling
2804         and Grammar" with "Show/Hide Spelling" when GRAMMAR_CHECKING is off.
2805
2806         Additionally, guard grammar checking in context menu code to not necessarily
2807         compile it.
2808
2809         No new layout tests because every port has a different way of showing
2810         spelling/grammar context menu items.
2811
2812         * page/ContextMenuController.cpp:
2813         (WebCore::ContextMenuController::contextMenuItemSelected):
2814         (WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
2815         (WebCore::ContextMenuController::populate):
2816         (WebCore::ContextMenuController::checkOrEnableIfNeeded):
2817         * platform/LocalizedStrings.cpp:
2818         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2819         (WebCore::contextMenuItemTagSpellingMenu):
2820         (WebCore::contextMenuItemTagShowSpellingPanel):
2821         * platform/LocalizedStrings.h:
2822         * platform/efl/LocalizedStringsEfl.cpp:
2823         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2824         (WebCore::contextMenuItemTagSpellingMenu):
2825         (WebCore::contextMenuItemTagShowSpellingPanel):
2826         * platform/gtk/LocalizedStringsGtk.cpp:
2827         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2828         (WebCore::contextMenuItemTagSpellingMenu):
2829         (WebCore::contextMenuItemTagShowSpellingPanel):
2830         * platform/qt/LocalizedStringsQt.cpp:
2831         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2832         (WebCore::contextMenuItemTagSpellingMenu):
2833         (WebCore::contextMenuItemTagShowSpellingPanel):
2834
2835 2013-06-16  Simon Fraser  <simon.fraser@apple.com>
2836
2837         Fix test assertion after r151624
2838
2839         An assertion was hit in RenderObject::willBeDestroyed()
2840         for fast/css/getComputedStyle/getComputedStyle-background-shorthand.html
2841         because the code asserted that the RenderObject had been removed from
2842         the FrameView's slowRepaintObject set before remove() was called,
2843         so move the assertion to after that call.
2844
2845         * rendering/RenderObject.cpp:
2846         (WebCore::RenderObject::willBeDestroyed):
2847
2848 2013-06-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2849
2850         Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()
2851         https://bugs.webkit.org/show_bug.cgi?id=117685
2852
2853         Reviewed by Andreas Kling.
2854
2855         From Blink r152490 by <vivek.vg@samsung.com>
2856
2857         * page/FrameView.cpp:
2858         (WebCore::FrameView::invalidateRect): Avoid hostWindow() twice call.
2859
2860 2013-06-16  Kent Tamura  <tkent@chromium.org>
2861
2862         Fix two assertion failures in Range::insertNode
2863         https://bugs.webkit.org/show_bug.cgi?id=116511
2864
2865         Reviewed by Ryosuke Niwa.
2866
2867         > ASSERTION FAILED: childBefore == (offset ? container->childNode(offset - 1) : 0)
2868         > third_party/WebKit/Source/WebCore/dom/RangeBoundaryPoint.h(115) : void WebCore::RangeBoundaryPoint::set(PassRefPtr<WebCore::Node>, int, WebCore::Node *)
2869
2870         > ASSERTION FAILED: child->parentNode()
2871         > ../../third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h(133) : void WebCore::RangeBoundaryPoint::setToBeforeChild(WebCore::Node *)
2872         >  1   0x87594b2 WebCore::RangeBoundaryPoint::setToBeforeChild(WebCore::Node*)
2873         >  2   0x87534a9 WebCore::Range::insertNode(WTF::PassRefPtr<WebCore::Node>, int&)
2874
2875         Range::insertNode calls Node::insertBefore, in which an event handler
2876         can update the DOM structure so that RangeBoundaryPoint don't like. We
2877         postpone event dispatching by EventQueueScope.
2878
2879         Also, remove old comments about Acid3. The behavior is standardized.
2880         (Step 9 of http://dom.spec.whatwg.org/#dom-range-insertnode)
2881
2882         This patch imports http://src.chromium.org/viewvc/blink?view=revision&revision=150470 .
2883
2884         Test: fast/dom/Range/range-insertNode-assertion.html
2885
2886         * dom/Range.cpp:
2887         (WebCore::Range::insertNode):
2888          - Add EventQueueScope
2889          - Remove obsolete comments
2890
2891 2013-06-16  Simon Fraser  <simon.fraser@apple.com>
2892
2893         Fixed backgrounds in composited layers not repainted on scrolling
2894         https://bugs.webkit.org/show_bug.cgi?id=117684
2895
2896         Reviewed by Tim Horton.
2897         
2898         FrameView is aware that "slow-repaint objects" (i.e. renderers with 
2899         background-attachment:fixed) require a slow-scrolling path. However,
2900         it was ignorant of the fact that such objects could be painting into
2901         compositing layers; it simply dirtied the main tiles, and nothing else.
2902         
2903         Fix by having FrameView track the slow-repaints objects explicitly, as we
2904         do for position:fixed, and repaint each of them on scrolling.
2905
2906         Test: compositing/repaint/fixed-background-scroll.html
2907
2908         * page/FrameView.cpp:
2909         (WebCore::FrameView::FrameView): No need to initialize m_slowRepaintObjectCount,
2910         which is now an OwnPtr<RenderObjectSet>.
2911         (WebCore::FrameView::useSlowRepaints): Use hasSlowRepaintObjects() now.
2912         (WebCore::FrameView::addSlowRepaintObject): Now adds the object to a set,
2913         allocating the set if necessary.
2914         (WebCore::FrameView::removeSlowRepaintObject): Remove the object from the set,
2915         and deallocate the set if empty.
2916         (WebCore::FrameView::scrollContentsSlowPath): Call repaintSlowRepaintObjects();
2917         this is the change that fixes the bug for always-composited implementations (e.g.
2918         tile cache). This is a conservative change; we still invalidate the tile cache
2919         as well. This could be optimized later.
2920         (WebCore::FrameView::repaintSlowRepaintObjects): Repaint each object in the set.
2921         Their appropriate compositing ancestor will be repainted.
2922         (WebCore::FrameView::scrollPositionChangedViaPlatformWidget): Call
2923         repaintSlowRepaintObjects() so that fixed backgrounds in composited layers are
2924         correctly repainted; this fixes the bug for WebKit1.
2925         * page/FrameView.h: Replace m_slowRepaintObjectCount with a HashSet of
2926         RenderObjects.
2927         (WebCore::FrameView::hasSlowRepaintObject): Takes a RenderObject* now.
2928         (WebCore::FrameView::hasSlowRepaintObjects): Ditto.
2929         * rendering/RenderObject.cpp:
2930         (WebCore::RenderObject::styleWillChange): Pass the RenderObject.
2931         (WebCore::RenderObject::willBeDestroyed): Assert that this RenderObject
2932         has been removed from FrameView's set of slow-repaint objects already, if
2933         the document is not being destroyed.
2934         (WebCore::RenderObject::willBeRemovedFromTree): Pass the RenderObject.
2935
2936 2013-06-15  Simon Fraser  <simon.fraser@apple.com>
2937
2938         Painting of fixed background images is wrong in composited layers
2939         https://bugs.webkit.org/show_bug.cgi?id=65793
2940
2941         Reviewed by Sam Weinig.
2942         
2943         The code that computed background image geometry for background-attachment:fixed
2944         images was unaware of compositing, so often painting the image at the wrong location.
2945         
2946         Fix by having RenderBoxModelObject::calculateBackgroundImageGeometry() do the correct
2947         math for fixed backgrounds in composited layer by offsetting the viewport rect by
2948         the paint container's absolute position.
2949
2950         Tests: compositing/backgrounds/fixed-background-on-descendant.html
2951                compositing/backgrounds/fixed-backgrounds.html
2952
2953         * rendering/RenderBox.cpp:
2954         (WebCore::RenderBox::getBackgroundPaintedExtent): Now returns a bool indicating
2955         whether it is returning a reliable extent rect. It can return false in the case where
2956         a background is fixed, since computing the correct extent would require finding
2957         the appropriate composited ancestor to pass to calculateBackgroundImageGeometry().
2958         This is OK since this function is used for "background opaque" optimizations.
2959         (WebCore::RenderBox::computeBackgroundIsKnownToBeObscured): If getBackgroundPaintedExtent()
2960         returns false, return false.
2961         (WebCore::RenderBox::maskClipRect): We removed mask-attachment, so we never need to
2962         compute the composited ancestor here and can pass null.
2963         (WebCore::RenderBox::repaintLayerRectsForImage): Unwrap a comment.
2964         If the changed image is related to a fixed background, geometry.hasNonLocalGeometry()
2965         will be true. In that cause, just repaint the entire renderer rather than groveling
2966         around for a composited ancestor.
2967         * rendering/RenderBox.h: Changed name and signature of backgroundPaintedExtent.
2968         * rendering/RenderBoxModelObject.cpp:
2969         (WebCore::RenderBoxModelObject::paintFillLayerExtended): calculateBackgroundImageGeometry()
2970         now needs to know the painting container.
2971         (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Now takes a painting
2972         container, that is required to correctly compute the viewport-relative offset for fixed
2973         backgrounds. geometry.setHasNonLocalGeometry() is set for fixed backgrounds to indicate
2974         to callers that, if they didn't pass a paint container, the destRect is not accurate.
2975         The main bug fix is also here: we move the viewportRect by the absolute location of
2976         paint container, which is equivalent to the composited layer offset.
2977         (WebCore::RenderBoxModelObject::getGeometryForBackgroundImage): calculateBackgroundImageGeometry()
2978         takes a paint container.
2979         * rendering/RenderBoxModelObject.h:
2980         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::BackgroundImageGeometry):
2981         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setHasNonLocalGeometry):
2982         (WebCore::RenderBoxModelObject::BackgroundImageGeometry::hasNonLocalGeometry):
2983         * rendering/RenderImage.cpp:
2984         (WebCore::RenderImage::computeBackgroundIsKnownToBeObscured): If getBackgroundPaintedExtent()
2985         can't cheaply give an accurate answer, return false.
2986         * rendering/RenderLayerBacking.cpp:
2987         (WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage): Pass the paint container,
2988         which is our own renderer.
2989
2990 2013-06-15  Simon Fraser  <simon.fraser@apple.com>
2991
2992         webkit-backface-visibility on a parent element stops background-position from updating
2993         https://bugs.webkit.org/show_bug.cgi?id=116319
2994
2995         Reviewed by Darin Adler.
2996
2997         The optimization added in r102952 was incorrect in the case where a style change
2998         resulted in a positioned-movement-only layout but also required a repaint; it assumed
2999         that a composited layer did not need to be repainted for a a positioned-movement-only layout.
3000         
3001         Fix by making RenderObject::setNeedsLayoutForPositionedMovement() check whether the
3002         style change requires a repaint, and calling setLayerNeedsFullRepaint() in that situation.
3003
3004         Test: compositing/repaint/positioned-movement.html
3005
3006         * rendering/RenderLayer.h: RepaintStatus values do not need to be bit flags.
3007         * rendering/RenderObject.cpp:
3008         (WebCore::RenderObject::setStyle): Pass the old style to setNeedsPositionedMovementLayout().
3009         (WebCore::RenderObject::styleDidChange): Ditto.
3010         * rendering/RenderObject.h:
3011         (WebCore::RenderObject::setNeedsPositionedMovementLayout): Now takes a const RenderStyle*.
3012         * rendering/style/RenderStyle.cpp:
3013         (WebCore::RenderStyle::diff): Remove a comment now that this bug is fixed.
3014         (WebCore::RenderStyle::diffRequiresRepaint): Public wrapper for changeRequiresRepaint().
3015         That function never uses contextSensitiveProperties so we can safely ignore them.
3016         * rendering/style/RenderStyle.h: Expose a way to call changeRequiresRepaint().
3017
3018 2013-06-15  Darin Adler  <darin@apple.com>
3019
3020         Try to fix iOS after last Pasteboard change.
3021
3022         * platform/ios/PasteboardIOS.mm:
3023         (WebCore::Pasteboard::writeSelection): Put the new code inline here because the
3024         stringSelectionForPasteboard function is currently Mac-only.
3025
3026 2013-06-15  Darin Adler  <darin@apple.com>
3027
3028         Move Pasteboard::getStringSelection to Editor, fixing a layering violation
3029         https://bugs.webkit.org/show_bug.cgi?id=117673
3030
3031         Reviewed by Ryosuke Niwa.
3032
3033         * editing/Editor.h: Added stringSelectionForPasteboardWithImageAltText.
3034
3035         * editing/mac/EditorMac.mm:
3036         (WebCore::Editor::stringSelectionForPasteboard): Moved code here from the Pasteboard
3037         class, since all the Pasteboard class did really was turn around and call back here.
3038         (WebCore::Editor::stringSelectionForPasteboardWithImageAltText): Added. Variant of
3039         the function above that includes image alt text. Separate named functions are often
3040         the best pattern for something like this unless there are many different combinations.
3041
3042         * platform/Pasteboard.h: Remove the Mac-only Pasteboard::getStringSelectioon.
3043
3044         * platform/ios/PasteboardIOS.mm:
3045         (WebCore::Pasteboard::writeSelection):
3046         * platform/mac/PasteboardMac.mm:
3047         (WebCore::Pasteboard::writeSelectionForTypes):
3048         Call the two new functions instead of the old Pasteboard::getStringSelection.
3049
3050 2013-06-15  Darin Adler  <darin@apple.com>
3051
3052         Support using clang instead of gcc for bindings preprocessing
3053         https://bugs.webkit.org/show_bug.cgi?id=117674
3054
3055         Reviewed by Sam Weinig.
3056
3057         I couldn't build on my computer because I don't have gcc installed.
3058         This is my cut at fixing it.
3059
3060         * bindings/scripts/CodeGeneratorObjC.pm:
3061         (ReadPublicInterfaces): Use clang if present.
3062         * bindings/scripts/preprocessor.pm:
3063         (applyPreprocessor): Ditto.
3064
3065 2013-06-14  Robert Hogan  <robert@webkit.org>
3066
3067         REGRESSION (r148367): Facebook and Twitter icons at macworld.com are stacked vertically, obscuring Twitter one
3068         https://bugs.webkit.org/show_bug.cgi?id=117284
3069
3070         Reviewed by David Hyatt.
3071
3072         Test: fast/text/whitespace/inline-whitespace-wrapping-7.html
3073
3074         We were looking for line breaks in trailing collapsed whitespace even when inside a nowrap inline.
3075         It's wrong to do this as we don't know yet if we will want or need to break - that decision has to
3076         be deferred until we enter a part of the line that is autowrap.
3077
3078         * rendering/RenderBlockLineLayout.cpp:
3079         (WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
3080
3081 2013-06-14  Lukasz Gajowy  <l.gajowy@samsung.com>
3082
3083         background-color is not preserved when inserting a new paragraph
3084         https://bugs.webkit.org/show_bug.cgi?id=117138
3085
3086         Reviewed by Ryosuke Niwa.
3087
3088         The style isn't copied because background-color isn't defined as inheritable property.
3089
3090         Test: editing/inserting/insert-paragraph-not-preserving-background-color.html
3091
3092         * editing/InsertParagraphSeparatorCommand.cpp:
3093         (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
3094         Passing EditingPropertiesInEffect instead of implicit parameter OnlyEditingInheritableProperties.
3095
3096 2013-06-14  Adam Barth  <abarth@webkit.org>
3097
3098         Threaded HTML parser can ASSERT in some situations
3099         https://bugs.webkit.org/show_bug.cgi?id=117662
3100
3101         Reviewed by Ryosuke Niwa.
3102
3103         This patch merges https://chromium.googlesource.com/chromium/blink/+/3c0a112b42d72c7623f78463166dd7f04d680b4c
3104
3105         --->8---
3106         The parser is supposed to stop processing data when there's a pending
3107         location change, but before this CL we would actually process the first
3108         token from every chunk when there was a pending location change.
3109
3110         If the first token in a chunk was a "script" start tag, that would put
3111         the tree builder into TextMode, which can only process character
3112         tokens. If the next chunk starts with another start tag token, the tree
3113         builder would be sad and hit an ASSERT.
3114
3115         This CL reorders a couple lines in HTMLDocumentParser so that we check
3116         for pending location changes before processing any tokens. This change
3117         stops us from processing the first token from each chunk while there is
3118         a pending location change.
3119
3120         This issue can reproduce on any platform, but it reproduced often on
3121         Android because mobile markup often elides spaces between consecutive
3122         script tags. If there are space characters between the script tags,
3123         then those space characters will be the first ones processes in the
3124         chunk, which doesn't trigger the ASSERT.
3125         ---8<---
3126
3127         Since we landed this patch in Blink, we've been able to reproduce this
3128         issue on desktops as well. I spoke with rniwa in #webkit and he said
3129         that WebKit doesn't have any current plans to enable the threaded
3130         parser but that it was probably worth merging this patch anyway.
3131
3132         Test: http/tests/navigation/pending-location-change-assert.html
3133
3134         * html/parser/HTMLDocumentParser.cpp:
3135         (WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
3136
3137 2013-06-14  Patrick Gansterer  <paroga@webkit.org>
3138
3139         Introduce USE(WINGDI) for the Windows port
3140         https://bugs.webkit.org/show_bug.cgi?id=116138
3141
3142         Reviewed by Ryosuke Niwa.
3143
3144         Using USE(WINGDI) instead of OS(WINCE) will allow us to
3145         compile the GDI based Windows port on WinNT too.
3146
3147         * config.h:
3148         * platform/graphics/BitmapImage.h:
3149         * platform/graphics/FontPlatformData.h:
3150         * platform/graphics/GlyphBuffer.h:
3151         (WebCore):
3152         (GlyphBuffer):
3153         * platform/graphics/Gradient.h:
3154         (Gradient):
3155         * platform/graphics/GraphicsContext.cpp:
3156         (WebCore):
3157         * platform/graphics/GraphicsContext.h:
3158         (WebCore):
3159         (GraphicsContext):
3160         * platform/graphics/ImageBufferData.h:
3161         * platform/graphics/NativeImagePtr.h:
3162         (WebCore):
3163         * platform/graphics/Path.h:
3164         * platform/graphics/Pattern.h:
3165         * plugins/win/PluginViewWin.cpp:
3166         (WebCore::PluginView::paintWindowedPluginIntoContext):
3167         (WebCore::PluginView::paint):
3168         (WebCore::PluginView::snapshot):
3169
3170 2013-06-13  Jer Noble  <jer.noble@apple.com>
3171
3172         Report the memory cost of HTMLMediaElements to GC.
3173         https://bugs.webkit.org/show_bug.cgi?id=117608
3174
3175         Reviewed by Darin Adler.
3176
3177         Report the extra memory cost of a HTMLMediaElement to the VM, in order to
3178         encourage GC to occur after a media element is removed from the DOM.
3179
3180         Because we cannot know for sure the memory cost of our underlying media
3181         framework objects, use the worst case scenario for the media memory cost:
3182         the buffered percentage of movie * the total data length of the movie.
3183
3184         * html/HTMLMediaElement.cpp:
3185         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_reportedExtraMemoryCost.
3186         (WebCore::HTMLMediaElement::removedFrom): Report the extra memory cost.
3187         * html/HTMLMediaElement.h:
3188         * html/TimeRanges.cpp:
3189         (TimeRanges::totalDuration): Added convenience function.
3190         * html/TimeRanges.h:
3191         * platform/graphics/MediaPlayer.cpp:
3192         (WebCore::MediaPlayer::extraMemoryCost): Pass to MediaPlayerPrivate.
3193         * platform/graphics/MediaPlayer.h:
3194         * platform/graphics/MediaPlayerPrivate.h:
3195         (WebCore::MediaPlayerPrivateInterface::extraMemoryCost): Default to 0.
3196         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
3197         (WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): Return the percentage
3198             loaded * total data length.
3199         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
3200
3201 2013-06-13  Jer Noble  <jer.noble@apple.com>
3202
3203         Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController.
3204         https://bugs.webkit.org/show_bug.cgi?id=117597
3205
3206         Reviewed by Eric Carlson.
3207
3208         Check for media elements with AVFoundation media types and create a AVPlayerLayer
3209         rather than a QTMovieLayer.
3210
3211         * platform/mac/WebVideoFullscreenController.h:
3212         * platform/mac/WebVideoFullscreenController.mm:
3213         (-[WebVideoFullscreenController setupVideoOverlay:]): Take a CALayer rather than a
3214             QTMovieLayer. Move the code which connects the layer with it's media source into
3215             setMediaElement.
3216         (-[WebVideoFullscreenController windowDidLoad]): Give the window's contentView a generic
3217             CALayer instaead of a QTMovieLayer.
3218         (-[WebVideoFullscreenController setMediaElement:]): Test whether the incoming media 
3219             element is backed by a QTMovie or an AVPlayer, and create the appropriate layer.
3220         (-[WebVideoFullscreenController windowDidExitFullscreen]): Remove the observer of
3221             AVPlayer's rate property.
3222         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
3223             If the keyPath is "rate", call rateChanged.
3224
3225 2013-06-14  Enrica Casucci  <enrica@apple.com>
3226
3227         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
3228         https://bugs.webkit.org/show_bug.cgi?id=117647
3229         <rdar://problem/13881024>
3230
3231         Reviewed by Darin Adler.
3232         
3233         The API returns the matched ranges in the DOM order regardless of the
3234         find direction, but the index of the first match after the user selection
3235         should take the find direction into account.
3236
3237         Extended existing test in TestWebKitAPI.
3238
3239         * page/Page.cpp:
3240         (WebCore::Page::findStringMatchingRanges): Added handling of the Backwards case.
3241         * page/Page.h: Fixed incorrect name of the enum.
3242
3243 2013-06-14  Jer Noble  <jer.noble@apple.com>
3244
3245         REGRESSION (r150651): Web Audio doesn't work at all (silence or squawks) on Mountain Lion
3246         https://bugs.webkit.org/show_bug.cgi?id=117652
3247
3248         Reviewed by Eric Carlson.
3249
3250         r150651 disabled setting the buffer size to a large value, but in so doing, also
3251         disabled setting the buffer size to a small value for Web Audio. Narrow the Mountain
3252         Lion protection to just the <video> element case.
3253         
3254         * platform/audio/mac/AudioSessionManagerMac.cpp:
3255         (AudioSessionManager::updateSessionState):
3256
3257 2013-06-14  Ryosuke Niwa  <rniwa@webkit.org>
3258
3259         Function names on Object.prototype should be common identifiers
3260         https://bugs.webkit.org/show_bug.cgi?id=117614
3261
3262         Reviewed by Darin Adler.
3263
3264         Use the added common identifiers.
3265
3266         * bindings/js/JSDOMWindowBase.cpp:
3267         (WebCore::JSDOMWindowBase::finishCreation):
3268         (WebCore::JSDOMWindowBase::updateDocument):
3269
3270 2013-06-14  Arpita Bahuguna  <a.bah@samsung.com>
3271
3272         Editing: wrong text position when you click enter on the text behind the image
3273         https://bugs.webkit.org/show_bug.cgi?id=115023
3274
3275         Reviewed by Ryosuke Niwa.
3276
3277         When trying to break a line after an image followed by some text, contrary
3278         to the expected behavior the text doesn't move to a new line, instead, the
3279         caret position just shifts to the end of line.
3280
3281         As per the existing implementation for inserting a paragraph separator,
3282         the insertion position obtained corresponds to the point after the image
3283         element.
3284         Since the insertion position doesn't resolve to being offset in the
3285         following text node (0 offset), no splitting of text occurs and the block
3286         to be inserted is placed after the containing (start) block (thereby
3287         causing the caret position to shift).
3288
3289         If the computed insertionPosition points to an element that shall be
3290         ignored for editing purposes (i.e. cannot have a VisiblePosition inside
3291         it), and the position lies either at the start or at the end of such
3292         an element, we should move our Position either upstream or
3293         downstream (respectively) so as to obtain a valid position which can
3294         be used further for splitting of the text.
3295         
3296         Test: editing/inserting/insert-paragraph-after-non-editable-node-before-text.html
3297
3298         * editing/InsertParagraphSeparatorCommand.cpp:
3299         (WebCore::InsertParagraphSeparatorCommand::doApply):
3300         Moving the insertionPosition either upstream or downstream, if the point
3301         lies either at the start or at the end of the anchor node.
3302         The ensuing position, if a text node, can then be used for splitting of
3303         the text correctly.
3304
3305 2013-06-14  Alberto Garcia  <agarcia@igalia.com>
3306
3307         [BlackBerry] Remove implementation of ContextMenu classes
3308         https://bugs.webkit.org/show_bug.cgi?id=114860
3309
3310         Reviewed by Rob Buis.
3311
3312         This code is not being used so we can safely remove it.
3313
3314         * PlatformBlackBerry.cmake:
3315         * platform/blackberry/ContextMenuBlackBerry.cpp: Removed.
3316         * platform/blackberry/ContextMenuItemBlackBerry.cpp: Removed.
3317         * platform/blackberry/LocalizedStringsBlackBerry.cpp:
3318
3319 2013-06-14  Brent Fulgham  <bfulgham@apple.com>
3320
3321         [Windows] Provide simple <meter> drawing logic for testing.
3322         https://bugs.webkit.org/show_bug.cgi?id=117645.
3323
3324         Reviewed by Anders Carlsson.
3325
3326         accessbility/meter-element.html
3327
3328         * rendering/RenderThemeSafari.cpp: Simple test implementation
3329         (WebCore::RenderThemeSafari::adjustMeterStyle): Added.
3330         (WebCore::RenderThemeSafari::supportsMeter): Added.
3331         (WebCore::RenderThemeSafari::meterSizeForBounds): Added.
3332         (WebCore::RenderThemeSafari::paintMeter): Added.
3333         * rendering/RenderThemeSafari.h:
3334         * rendering/RenderThemeWin.cpp:
3335         (WebCore::RenderThemeWin::progressBarTheme): Added.
3336         (WebCore::RenderThemeWin::getClassicThemeData): Support meters.
3337         (WebCore::RenderThemeWin::getThemeData): Support meter theme.
3338         (WebCore::RenderThemeWin::adjustMeterStyle): Added.
3339         (WebCore::RenderThemeWin::supportsMeter): Added.
3340         (WebCore::RenderThemeWin::meterSizeForBounds): Added.
3341         (WebCore::RenderThemeWin::paintMeter): Added.
3342         * rendering/RenderThemeWin.h:
3343
3344 2013-06-14  Eric Carlson  <eric.carlson@apple.com>
3345
3346         Potential use-after-free with an event fired at a HTMLMediaElement which is currently being deleted
3347         https://bugs.webkit.org/show_bug.cgi?id=117466
3348
3349         Reviewed by Oliver Hunt.
3350         
3351         Merge https://chromium.googlesource.com/chromium/blink/+/f4200a0093b3d9376f703961615359ec7fb712b4
3352         
3353         If an event is created using as target an HTMLMediaElement which is
3354         currently being deleted it becomes a heap-use-after free situation.
3355
3356         The GenericEventQueue instance is already owned by the HTMLMediaElement,
3357         and there already is an underlying mechanism to set the target of the
3358         event to NULL, if their target is owner of the queue.
3359
3360         In order to avoid creating this reference in the first place, we enqueue
3361         the event with a NULL target to defer the refcount increment until the
3362         timer for dispatching the event happens (which won't happen at all if
3363         garbage collection is already destroying the objects).
3364
3365         Test: media/track/media-element-enqueue-event-crash.html
3366
3367         * dom/GenericEventQueue.cpp:
3368         (WebCore::GenericEventQueue::enqueueEvent): Don't ASSERT if the event has no target.
3369
3370         * html/HTMLMediaElement.cpp:
3371         (WebCore::HTMLMediaElement::~HTMLMediaElement): Close the event queue so it won't try to
3372             dispatch any pending events.
3373         (WebCore::HTMLMediaElement::scheduleEvent): Don't set the event target, it will happen just
3374             prior to event dispatch.
3375         (WebCore::HTMLMediaElement::stop): Close the event queue.
3376
3377 2013-06-14  Dean Jackson  <dino@apple.com>
3378
3379         Clicking on snapshotting plug-ins does not restart them
3380         https://bugs.webkit.org/show_bug.cgi?id=117620
3381         <rdar://problem/13821729>
3382
3383         Follow-up review comments from Darin Adler, with some
3384         discussion on IRC.
3385
3386         Sprinkle OVERRIDE on virtual functions where needed. Also
3387         make sure that the Event is a MouseEvent before casting to it.
3388
3389         * html/HTMLPlugInElement.h: Move defaultEventHandler back to protected and add OVERRIDE.
3390         * html/HTMLPlugInImageElement.cpp:
3391         (WebCore::HTMLPlugInImageElement::defaultEventHandler): Check for MouseEvent and
3392         use toMouseEvent().
3393         * html/HTMLPlugInImageElement.h: Sprinkle some OVERRIDEs, and move defaultEventHandler
3394         to private.
3395
3396 2013-06-14  Timothy Hatcher  <timothy@apple.com>
3397
3398         Remove front-end from the WebCore Xcode project.
3399         https://bugs.webkit.org/show_bug.cgi?id=117640
3400
3401         Reviewed by Darin Adler.
3402
3403         * WebCore.xcodeproj/project.pbxproj:
3404
3405 2013-06-14  Jaehun Lim  <ljaehun.lim@samsung.com>
3406
3407         CSSParser::parseImageSet() doesn't need a parameter.
3408         https://bugs.webkit.org/show_bug.cgi?id=117617
3409
3410         Reviewed by Darin Adler.
3411
3412         parseImageSet() can get m_valueList directly.
3413         And minor fixes.
3414
3415         No new tests, no behavior change.
3416
3417         * css/CSSParser.cpp:
3418         (WebCore::CSSParser::parseValue):
3419         (WebCore::CSSParser::parseContent):
3420         (WebCore::CSSParser::parseFillImage):
3421         (WebCore::CSSParser::parseBorderImage):
3422         (WebCore::CSSParser::parseImageSet):
3423         * css/CSSParser.h:
3424
3425 2013-06-14  Tiancheng Jiang  <tijiang@rim.com>
3426
3427         [BlackBerry] Dropdown button UX updates.
3428         https://bugs.webkit.org/show_bug.cgi?id=117642.
3429
3430         Reviewed by Rob Buis.
3431
3432         JIRA 388652
3433         Internally Reviewed by Jeff Rogers.
3434
3435         Change arrow assert.
3436
3437         * platform/blackberry/RenderThemeBlackBerry.cpp:
3438         (WebCore::RenderThemeBlackBerry::paintMenuList):
3439
3440 2013-06-14  Arvid Nilsson  <anilsson@rim.com>
3441
3442         [BlackBerry] LayerTiler fails to tile really big layers
3443         https://bugs.webkit.org/show_bug.cgi?id=117211
3444
3445         Reviewed by Carlos Garcia Campos.
3446
3447         PR 273550
3448
3449         The cause for this bug was that LayerTiler computed which tiles are
3450         visible by exhaustively mapping every tile to normalized device
3451         coordinates and checking if it intersected the viewport. If there was a
3452