2011-06-06 Emil A Eklund <eae@chromium.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-06-06  Emil A Eklund  <eae@chromium.org>
2
3         Reviewed by Eric Seidel.
4
5         Convert RenderBox::popContentsClip to IntPoint
6         https://bugs.webkit.org/show_bug.cgi?id=62132
7
8         Covered by existing tests.
9
10         * rendering/RenderBlock.cpp:
11         (WebCore::RenderBlock::paint):
12         * rendering/RenderBox.cpp:
13         (WebCore::RenderBox::popContentsClip):
14         * rendering/RenderBox.h:
15         * rendering/RenderTable.cpp:
16         (WebCore::RenderTable::paint):
17         * rendering/RenderTableSection.cpp:
18         (WebCore::RenderTableSection::paint):
19
20 2011-06-06  Levi Weintraub  <leviw@chromium.org>
21
22         Reviewed by Eric Seidel.
23
24         Remove tx/ty offset from selectionRect
25         https://bugs.webkit.org/show_bug.cgi?id=62146
26
27         Removing unused offset parameters from selectionRect.
28
29         No new tests since this is just cleanup.
30
31         * rendering/EllipsisBox.cpp:
32         (WebCore::EllipsisBox::selectionRect):
33         * rendering/EllipsisBox.h:
34         * rendering/InlineTextBox.cpp:
35         (WebCore::InlineTextBox::selectionRect):
36         * rendering/InlineTextBox.h:
37         * rendering/RenderText.cpp:
38         (WebCore::RenderText::absoluteRectsForRange):
39         (WebCore::ellipsisRectForBox):
40         (WebCore::RenderText::absoluteQuadsForRange):
41         (WebCore::RenderText::selectionRectForRepaint):
42         * rendering/svg/RenderSVGInlineText.cpp:
43         (WebCore::RenderSVGInlineText::localCaretRect):
44         * rendering/svg/SVGInlineTextBox.cpp:
45         (WebCore::SVGInlineTextBox::selectionRect):
46         * rendering/svg/SVGInlineTextBox.h:
47
48 2011-06-06  Paul Kinlan  <paulkinlan@google.com>
49
50         Reviewed by Jeremy Orlow.
51
52         Let developers call createEvent("PopStateEvent"), previously it wasn't
53         exposed and threw an exeception. 
54         https://bugs.webkit.org/show_bug.cgi?id=62099
55
56         * WebCore/dom/Document.cpp:
57         * WebCore/dom/PopStateEvent.cpp:
58         * WebCore/dom/PopStateEvent.h:
59
60 2011-06-03  Levi Weintraub  <leviw@chromium.org>
61
62         Reviewed by Eric Seidel.
63
64         Switch paintSelection to use IntPoint
65         https://bugs.webkit.org/show_bug.cgi?id=62059
66
67         Switching paintSelection to use an IntPoint to represent the paint offset
68         instead of a pair of ints.
69
70         No new tests since this is simple refactoring.
71
72         * rendering/EllipsisBox.cpp:
73         (WebCore::EllipsisBox::paint):
74         (WebCore::EllipsisBox::paintSelection):
75         * rendering/EllipsisBox.h:
76         * rendering/RenderBlock.cpp:
77         (WebCore::RenderBlock::paintObject):
78         (WebCore::RenderBlock::paintSelection):
79         * rendering/RenderBlock.h:
80
81 2011-06-06  Emil A Eklund  <eae@chromium.org>
82
83         Reviewed by Eric Seidel.
84
85         Convert RenderBox::clipRect to IntPoint
86         https://bugs.webkit.org/show_bug.cgi?id=62045
87
88         Covered by existing tests.
89
90         * rendering/RenderBox.cpp:
91         (WebCore::RenderBox::clipRect):
92         * rendering/RenderBox.h:
93         * rendering/RenderLayer.cpp:
94         (WebCore::RenderLayer::calculateClipRects):
95         (WebCore::RenderLayer::calculateRects):
96         (WebCore::RenderLayer::repaintBlockSelectionGaps):
97         * rendering/RenderLayerBacking.cpp:
98         (WebCore::clipBox):
99
100 2011-06-06  Peter Kasting  <pkasting@google.com>
101
102         Reviewed by Antonio Gomes.
103
104         Remove unnecessary args from scroll functions.
105         https://bugs.webkit.org/show_bug.cgi?id=61648
106
107         No behavior change, so no tests.
108
109         * WebCore.exp.in:
110         * WebCore.order:
111         * dom/Element.cpp:
112         (WebCore::Element::scrollIntoView):
113         (WebCore::Element::scrollIntoViewIfNeeded):
114         * editing/FrameSelection.cpp:
115         (WebCore::FrameSelection::revealSelection):
116         * page/EventHandler.cpp:
117         (WebCore::EventHandler::handleMousePressEvent):
118         * page/FrameView.cpp:
119         (WebCore::FrameView::scrollToAnchor):
120         * rendering/RenderBox.cpp:
121         (WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
122         (WebCore::RenderBox::canBeProgramaticallyScrolled):
123         * rendering/RenderBox.h:
124         * rendering/RenderLayer.cpp:
125         (WebCore::RenderLayer::scrollRectToVisible):
126         (WebCore::RenderLayer::autoscroll):
127         * rendering/RenderLayer.h:
128         * rendering/RenderListBox.h:
129         (WebCore::RenderListBox::canBeProgramaticallyScrolled):
130         * rendering/RenderTextControl.h:
131         (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
132
133 2011-06-06  Levi Weintraub  <leviw@chromium.org>
134
135         Reviewed by Eric Seidel.
136
137         Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
138         https://bugs.webkit.org/show_bug.cgi?id=62134
139
140         Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
141         IntPoint representing the paint offset instead of a pair of ints.
142
143         No new tests as this simple refactoring.
144
145         * rendering/RenderBlock.cpp:
146         (WebCore::RenderBlock::paintColumnRules):
147         (WebCore::RenderBlock::paintColumnContents):
148         (WebCore::RenderBlock::paintContents):
149         (WebCore::RenderBlock::paintObject):
150         (WebCore::RenderBlock::paintSelection):
151         * rendering/RenderBlock.h:
152
153 2011-06-06  Yael Aharon  <yael.aharon@nokia.com>
154
155         Reviewed by Eric Seidel.
156
157         Inline elements are wrapped prematurely with non-zero border, margin or padding.
158         https://bugs.webkit.org/show_bug.cgi?id=60459
159
160         When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
161         the width of the right border/margin/padding should be included in line breaking calculation only once,
162         and not for each descendant.
163
164         Test: fast/inline/inline-wrap-with-parent-padding.html
165
166         * rendering/RenderBlockLineLayout.cpp:
167         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
168
169 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
170
171         Reviewed by Tony Gentilcore.
172
173         Add a "prerender" state for page visibility.
174         https://bugs.webkit.org/show_bug.cgi?id=62062
175
176         * page/PageVisibilityState.cpp:
177         (WebCore::pageVisibilityStateString):
178         * page/PageVisibilityState.h:
179
180 2011-06-06  Cary Clark  <caryclark@google.com>
181
182         Reviewed by Eric Seidel.
183
184         Fix typo in CachedFont.cpp #define
185         https://bugs.webkit.org/show_bug.cgi?id=62127
186
187         No new tests. The define typo in question is
188         not yet enabled, so this change has no functional
189         impact.
190
191         * loader/cache/CachedFont.cpp:
192         change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME
193
194 2011-06-03  Levi Weintraub  <leviw@chromium.org>
195
196         Reviewed by Eric Seidel.
197
198         Switch paintFloats, paintChildren, and paintEllipsisBoxes to use IntPoint
199         https://bugs.webkit.org/show_bug.cgi?id=62058
200
201         Switching paintFloats, paintChildren, and paintEllipsisBoxes to take IntPoints representing
202         their paint offsets instead of pairs of ints.
203
204         No new tests since this is simple refactoring.
205
206         * rendering/RenderBlock.cpp:
207         (WebCore::RenderBlock::paintColumnContents):
208         (WebCore::RenderBlock::paintContents):
209         (WebCore::RenderBlock::paintChildren):
210         (WebCore::RenderBlock::paintObject):
211         (WebCore::RenderBlock::paintFloats):
212         (WebCore::RenderBlock::paintEllipsisBoxes):
213         * rendering/RenderBlock.h:
214
215 2011-06-06  Steve Block  <steveblock@google.com>
216
217         Reviewed by Yury Semikhatsky.
218
219         Use of ENABLE(INSPECTOR) is inconsistent
220         https://bugs.webkit.org/show_bug.cgi?id=62118
221
222         Correctly guard implementation of ScriptProfiler.
223
224         No new tests, build fix only.
225
226         * bindings/v8/ScriptProfiler.cpp:
227         (WebCore::ScriptProfiler::initialize):
228
229 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
230
231         Reviewed by Dimitri Glazkov.
232
233         Add WebCoreTestSupport project.
234         https://bugs.webkit.org/show_bug.cgi?id=61076
235
236         * WebCore.vcproj/WebCoreCommon.vsprops:
237         * WebCore.vcproj/WebCoreTestSupport.vcproj: Added.
238         * WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCoreTestSupport.h.
239
240 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
241
242         Reviewed by Kent Tamura.
243
244         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
245         https://bugs.webkit.org/show_bug.cgi?id=61628
246
247         This patch modifies only the build system. Therefore,
248         there are no new tests.
249
250         * Configurations/FeatureDefines.xcconfig:
251
252 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
253
254         Reviewed by Kent Tamura.
255
256         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
257         https://bugs.webkit.org/show_bug.cgi?id=61631
258         
259         This patch modifies only the build system. Therefore,
260         there are no new tests.
261
262         * Configurations/FeatureDefines.xcconfig:
263
264 2011-06-03  Hans Wennborg  <hans@chromium.org>
265
266         Reviewed by Tony Gentilcore.
267
268         IndexedDB: Clean-up function prototypes in IDBLevelDBBackingStore.cpp
269         https://bugs.webkit.org/show_bug.cgi?id=62013
270
271         Clean up the prototypes for cursor open functions by introducing the
272         CursorOptions struct.
273
274         Just clean-up, no new functionality so no new tests.
275
276         * storage/IDBLevelDBBackingStore.cpp:
277         (WebCore::CursorOptions::CursorImplCommon::CursorImplCommon):
278         (WebCore::CursorOptions::CursorImplCommon::firstSeek):
279         (WebCore::CursorOptions::CursorImplCommon::continueFunction):
280         (WebCore::CursorOptions::ObjectStoreCursorImpl::create):
281         (WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
282         (WebCore::CursorOptions::IndexKeyCursorImpl::create):
283         (WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl):
284         (WebCore::CursorOptions::IndexCursorImpl::create):
285         (WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl):
286         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
287         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
288         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
289
290 2011-06-06  Mustafizur Rahaman  <mustaf.here@gmail.com>
291
292         Reviewed by Darin Adler.
293
294         Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
295         https://bugs.webkit.org/show_bug.cgi?id=48290
296         
297         "highlight" is not a valid globalComposite operation
298         as per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing
299         Therefore, removed the option from the source code.
300         
301         Tests: No new tests required.
302         LayoutTests\canvas\philip\tests\2d.composite.operation.highlight.html can be used for testing.
303
304         * css/CSSPrimitiveValueMappings.h:
305         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
306         (WebCore::CSSPrimitiveValue::operator CompositeOperator):
307         * platform/graphics/GraphicsTypes.cpp:
308         * platform/graphics/GraphicsTypes.h:
309         * platform/graphics/cairo/CairoUtilities.cpp:
310         (WebCore::toCairoOperator):
311         * platform/graphics/cg/GraphicsContextCG.cpp:
312         (WebCore::GraphicsContext::setPlatformCompositeOperation):
313         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
314         (WebCore::SharedGraphicsContext3D::applyCompositeOperator):
315         * platform/graphics/openvg/PainterOpenVG.cpp:
316         (WebCore::PlatformPainterState::applyBlending):
317         * platform/graphics/qt/GraphicsContextQt.cpp:
318         (WebCore::toQtCompositionMode):
319         * platform/graphics/skia/SkiaUtils.cpp:
320
321 2011-06-04  Abhishek Arya  <inferno@chromium.org>
322
323         Reviewed by Kent Tamura.
324
325         Add some asserts for array boundary checks in TextRun. Fix
326         an integer issue in linux text controller code.
327         https://bugs.webkit.org/show_bug.cgi?id=62085
328
329         Testing ComplexTextControllerLinux change requires a testcase
330         > 32 kb which is not feasible. All other changes are tested by
331         existing layouttests.
332
333         * platform/graphics/TextRun.h:
334         (WebCore::TextRun::operator[]): add assert.
335         (WebCore::TextRun::data): add assert.
336         * platform/graphics/WidthIterator.cpp:
337         (WebCore::WidthIterator::advance): bail early and prevent access
338         to one byte across the text run boundary.
339         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
340         (WebCore::ComplexTextController::getNormalizedTextRun): wrong
341         int16 vs int comparison.
342         * rendering/svg/SVGTextRunRenderingContext.cpp:
343         (WebCore::SVGTextRunWalker::walk): bail early when from and to
344         is outside the text run boundary. this hit easily after adding
345         the assert when from = to = end and read in run.data(from). 
346
347 2011-06-05  Kent Tamura  <tkent@chromium.org>
348
349         Reviewed by Dimitri Glazkov.
350
351         Rolling out r84528.
352         http://trac.webkit.org/changeset/84528
353         https://bugs.webkit.org/show_bug.cgi?id=62100
354
355         It made several problems on elements with new shadow DOM.
356
357         * dom/Element.cpp:
358         (WebCore::Element::copyNonAttributeProperties):
359
360 2011-06-05  Igor Oliveira  <igor.oliveira@openbossa.org>
361
362         Reviewed by Kenneth Rohde Christiansen.
363
364         fast/viewport/viewport-45.html fails in GTK+/Qt
365         https://bugs.webkit.org/show_bug.cgi?id=47481
366
367         computeViewportAttributes does many math operations with float point arithmetic
368         and in some cases there is loss of precision making tests have incorrect values.
369
370         * dom/ViewportArguments.cpp:
371         (WebCore::computeViewportAttributes):
372
373 == Rolled over to ChangeLog-2011-06-04 ==