adea47759a41cca14c38273d4ec520f0676fe742
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-03-08  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Anders Carlsson.
4
5         Overflow: scroll areas should not paint white in scroll corner if the 
6         scrollbars are overlay.
7         <rdar://problem/9082871>
8
9         * rendering/RenderLayer.cpp:
10         (WebCore::RenderLayer::paintScrollCorner):
11         Don't paint the scroll corner white if we have overlay scrollbars.
12
13 2011-03-08  Chris Marrin  <cmarrin@apple.com>
14
15         Reviewed by Darin Adler.
16
17         The first time animations are committed they have a bad start time
18         https://bugs.webkit.org/show_bug.cgi?id=55947
19
20         Do a check for a returned lastCommitTime of <=0 and replace it
21         with the mediaTime.
22
23
24         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
25         (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
26
27 2011-03-08  James Kozianski  <koz@chromium.org>
28
29         Reviewed by David Levin.
30
31         Expose isValidProtocol() in KURL.h.
32         https://bugs.webkit.org/show_bug.cgi?id=54594
33
34         This is needed to validate protocols used in calls to
35         navigator.registerProtocolHandler().
36
37         * platform/KURL.cpp:
38         * platform/KURL.h:
39         * platform/KURLGoogle.cpp:
40         (WebCore::isValidProtocol):
41
42 2011-03-08  Adam Roben  <aroben@apple.com>
43
44         Set svn:mime-type to text/css for all Inspector CSS files
45
46         This will cause them to be served with the correct MIME type from svn.webkit.org's web
47         interface.
48
49         Rubber-stamped by Tim Hatcher.
50
51         * inspector/front-end/audits.css: Added property svn:mime-type.
52         * inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
53         * inspector/front-end/heapProfiler.css: Added property svn:mime-type.
54         * inspector/front-end/helpScreen.css: Added property svn:mime-type.
55         * inspector/front-end/inspector.css: Added property svn:mime-type.
56         * inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
57         * inspector/front-end/networkPanel.css: Added property svn:mime-type.
58         * inspector/front-end/popover.css: Added property svn:mime-type.
59         * inspector/front-end/textViewer.css: Added property svn:mime-type.
60
61 2011-03-08  Andrei Popescu  <andreip@google.com>
62
63         Reviewed by Steve Block.
64
65         IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
66         https://bugs.webkit.org/show_bug.cgi?id=55938
67
68         The IndexedDatabase specification changed and IDBIndex objects are no
69         longer created asynchronously. We therefore no longer need this method.
70
71         No new tests, just cleanup.
72
73         * storage/IDBCallbacks.h:
74         * storage/IDBRequest.cpp:
75         * storage/IDBRequest.h:
76
77 2011-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
78
79         Unreviewed, rolling out r80551.
80         http://trac.webkit.org/changeset/80551
81         https://bugs.webkit.org/show_bug.cgi?id=55933
82
83         It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
84
85         * WebCore.pro:
86         * platform/SharedBuffer.cpp:
87         * platform/SharedBuffer.h:
88         * platform/network/qt/QNetworkReplyHandler.cpp:
89         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
90         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
91         (WebCore::QNetworkReplyHandler::forwardData):
92         (WebCore::QNetworkReplyHandler::start):
93         * platform/network/qt/QNetworkReplyHandler.h:
94         * platform/network/qt/ResourceHandleQt.cpp:
95         (WebCore::ResourceHandle::supportsBufferedData):
96         (WebCore::ResourceHandle::bufferedData):
97         * platform/qt/QtByteBlock.cpp: Removed.
98         * platform/qt/QtByteBlock.h: Removed.
99         * platform/qt/SharedBufferQt.cpp:
100
101 2011-03-08  Andreas Kling  <kling@webkit.org>
102
103         Reviewed by Benjamin Poulain.
104
105         RenderObject: Pass complex type arguments as const-references.
106
107         * WebCore.exp.in:
108         * rendering/RenderObject.h:
109         * rendering/RenderObject.cpp:
110         (WebCore::RenderObject::drawBoxSideFromPath):
111         (WebCore::RenderObject::drawArcForBoxSide):
112         (WebCore::RenderObject::localToAbsolute):
113         (WebCore::RenderObject::absoluteToLocal):
114
115 2011-03-08  Andreas Kling  <kling@webkit.org>
116
117         Reviewed by Antonio Gomes.
118
119         Path: Make measurement functions const
120         https://bugs.webkit.org/show_bug.cgi?id=55914
121
122         * platform/graphics/Path.cpp:
123         (WebCore::Path::length):
124         (WebCore::Path::pointAtLength):
125         (WebCore::Path::normalAngleAtLength):
126         * platform/graphics/Path.h:
127         * platform/graphics/cairo/PathCairo.cpp:
128         (WebCore::Path::strokeBoundingRect):
129         * platform/graphics/cg/PathCG.cpp:
130         (WebCore::Path::strokeBoundingRect):
131         * platform/graphics/openvg/PathOpenVG.cpp:
132         (WebCore::Path::strokeBoundingRect):
133         (WebCore::Path::length):
134         (WebCore::Path::pointAtLength):
135         (WebCore::Path::normalAngleAtLength):
136         * platform/graphics/qt/PathQt.cpp:
137         (WebCore::Path::strokeBoundingRect):
138         (WebCore::Path::length):
139         (WebCore::Path::pointAtLength):
140         (WebCore::Path::normalAngleAtLength):
141         * platform/graphics/skia/PathSkia.cpp:
142         (WebCore::Path::strokeBoundingRect):
143         * platform/graphics/wince/PathWinCE.cpp:
144         (WebCore::Path::strokeBoundingRect):
145         * platform/graphics/wx/PathWx.cpp:
146         (WebCore::Path::strokeBoundingRect):
147
148 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
149
150         Reviewed by Martin Robinson.
151
152         [GTK] Do not set juntion sides on scrollbar stepper buttons
153         https://bugs.webkit.org/show_bug.cgi?id=55868
154
155         Fixes rendering of steppers for themes using rounded stepper
156         buttons on scrollbars like Adwaita.
157
158         * platform/gtk/ScrollbarThemeGtk3.cpp:
159         (WebCore::ScrollbarThemeGtk::paintButton):
160
161 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
162
163         Reviewed by Martin Robinson.
164
165         [GTK] Use doubles instead of integers for coordinates when rendering arrows
166         https://bugs.webkit.org/show_bug.cgi?id=55866
167
168         To prevent off-by-one rounding errors.
169
170         * platform/gtk/RenderThemeGtk3.cpp:
171         (WebCore::RenderThemeGtk::paintMenuList):
172         * platform/gtk/ScrollbarThemeGtk3.cpp:
173         (WebCore::ScrollbarThemeGtk::paintButton):
174
175 2011-03-08  Markus Goetz  <guruz@guruz.de>
176
177         Reviewed by Kenneth Rohde Christiansen.
178
179         [Qt] Use the QNetworkAccessManager zerocopy feature
180         https://bugs.webkit.org/show_bug.cgi?id=50082
181
182         The feature will be introduced in Qt 4.8.
183         This patch is backwards compatible with Qt 4.7.
184
185         * WebCore.pro:
186         * platform/SharedBuffer.cpp:
187         * platform/SharedBuffer.h:
188         * platform/network/qt/QNetworkReplyHandler.cpp:
189         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
190         (WebCore::QNetworkReplyHandler::bufferedData):
191         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
192         (WebCore::QNetworkReplyHandler::downloadProgress):
193         (WebCore::QNetworkReplyHandler::forwardData):
194         (WebCore::QNetworkReplyHandler::start):
195         * platform/network/qt/QNetworkReplyHandler.h:
196         * platform/network/qt/ResourceHandleQt.cpp:
197         (WebCore::ResourceHandle::supportsBufferedData):
198         (WebCore::ResourceHandle::bufferedData):
199         * platform/qt/SharedBufferQt.cpp:
200         (WebCore::SharedBuffer::wrapQtByteBlock):
201         (WebCore::SharedBuffer::hasPlatformData):
202         (WebCore::SharedBuffer::platformData):
203         (WebCore::SharedBuffer::platformDataSize):
204         (WebCore::SharedBuffer::maybeTransferPlatformData):
205         (WebCore::SharedBuffer::clearPlatformData):
206
207 2011-03-08  Alejandro G. Castro  <alex@igalia.com>
208
209         Reviewed by Martin Robinson.
210
211         [GTK] Fix compilation warnings after r80429
212         https://bugs.webkit.org/show_bug.cgi?id=55864
213
214         * platform/gtk/WidgetGtk.cpp:
215
216 2011-03-08  Philippe Normand  <pnormand@igalia.com>
217
218         Unreviewed, GTK build fix after r80536
219
220         * GNUmakefile.am:
221
222 2011-03-08  Zan Dobersek  <zandobersek@gmail.com>
223
224         Reviewed by Martin Robinson.
225
226         [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
227         https://bugs.webkit.org/show_bug.cgi?id=55878
228
229         Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
230         when saving GdkPixbuf to a buffer.
231
232         * platform/graphics/gtk/ImageBufferGtk.cpp:
233         (WebCore::ImageBuffer::toDataURL):
234
235 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
236
237         Unreviewed.
238
239         Final build fix for r80536.
240
241         * DerivedSources.make:
242
243 2011-03-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
244
245         Reviewed by Kent Tamura.
246
247         [EFL] Adjust functions of WebCore's efl port to WebKit coding style
248         https://bugs.webkit.org/show_bug.cgi?id=55924
249
250         Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.
251
252         * platform/efl/PlatformKeyboardEventEfl.cpp:
253         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
254         * platform/efl/PlatformMouseEventEfl.cpp:
255         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
256         * platform/efl/WidgetEfl.cpp:
257         (WebCore::Widget::frameRectsChanged):
258         (WebCore::Widget::setEvasObject):
259
260 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
261
262         Unreviewed.
263
264         More build fixes for r80536.
265
266         * CMakeLists.txt:
267         * platform/chromium/ClipboardChromium.cpp:
268         * platform/chromium/ClipboardChromium.h:
269
270 2011-03-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
271
272         Reviewed by Antonio Gomes.
273
274         [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
275         https://bugs.webkit.org/show_bug.cgi?id=55917
276
277         Adjust webkit style to ScrollbarEfl files.
278
279         * platform/efl/ScrollbarEfl.cpp:
280         (scrollbarEflEdjeMessage):
281         (ScrollbarEfl::setParent):
282         (ScrollbarEfl::updateThumbPositionAndProportion):
283         (ScrollbarEfl::frameRectsChanged):
284         (ScrollbarEfl::paint):
285         * platform/efl/ScrollbarEfl.h:
286
287 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
288
289         Unreviewed.
290
291         Build fix for Chromium after r80536.
292
293         * platform/chromium/DataTransferItemChromium.cpp:
294         * platform/chromium/DataTransferItemsChromium.cpp:
295
296 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
297
298         Unreviewed.
299
300         More build fixes for r80536.
301
302         * CMakeLists.txt:
303         * platform/chromium/ClipboardChromium.cpp:
304         * platform/chromium/ClipboardChromium.h:
305
306 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
307
308         Reviewed by David Levin.
309
310         Add support for DataTransferItems
311         https://bugs.webkit.org/show_bug.cgi?id=55115
312
313         This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
314         basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
315         all functionality on the DataTransferItems collection has been implemented.
316         This change does not actually hook up DataTransferItems to reflect the actual contents of a
317         drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
318         enabled via several followup patches.
319
320         Test: editing/pasteboard/data-transfer-items.html
321
322         * Android.mk:
323         * CMakeLists.txt:
324         * CodeGenerators.pri:
325         * DerivedSources.cpp:
326         * DerivedSources.make:
327         * GNUmakefile.am:
328         * WebCore.gypi:
329         * WebCore.pro:
330         * WebCore.vcproj/WebCore.vcproj:
331         * WebCore.xcodeproj/project.pbxproj:
332         * bindings/generic/RuntimeEnabledFeatures.cpp:
333         * bindings/generic/RuntimeEnabledFeatures.h:
334         (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
335         (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
336         * bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
337         * dom/Clipboard.h:
338         (WebCore::Clipboard::policy):
339         * dom/Clipboard.idl:
340         * dom/DataTransferItem.cpp: Added.
341         * dom/DataTransferItem.h: Added.
342         (WebCore::DataTransferItem::~DataTransferItem):
343         * dom/DataTransferItem.idl: Added.
344         * dom/DataTransferItems.h: Added.
345         (WebCore::DataTransferItems::~DataTransferItems):
346         * dom/DataTransferItems.idl: Added.
347         * dom/StringCallback.cpp: Added.
348         (WebCore::StringCallback::scheduleCallback):
349         * dom/StringCallback.h: Added.
350         (WebCore::StringCallback::~StringCallback):
351         * dom/StringCallback.idl: Added.
352         * platform/chromium/ClipboardChromium.cpp:
353         (WebCore::ClipboardChromium::items):
354         * platform/chromium/ClipboardChromium.h:
355         * platform/chromium/DataTransferItemChromium.cpp: Added.
356         (WebCore::DataTransferItemChromium::create):
357         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
358         (WebCore::DataTransferItemChromium::kind):
359         (WebCore::DataTransferItemChromium::type):
360         (WebCore::DataTransferItemChromium::getAsString):
361         * platform/chromium/DataTransferItemChromium.h: Added.
362         * platform/chromium/DataTransferItemsChromium.cpp: Added.
363         (WebCore::DataTransferItemsChromium::create):
364         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
365         (WebCore::DataTransferItemsChromium::length):
366         (WebCore::DataTransferItemsChromium::item):
367         (WebCore::DataTransferItemsChromium::deleteItem):
368         (WebCore::DataTransferItemsChromium::clear):
369         (WebCore::DataTransferItemsChromium::add):
370         * platform/chromium/DataTransferItemsChromium.h: Added.
371
372 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
373
374         Reviewed by Darin Adler.
375
376         selectionHasStyle and selectionStartHasStyle should use EditingStyle
377         https://bugs.webkit.org/show_bug.cgi?id=55902
378
379         Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
380         This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.
381
382         Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
383         to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
384         call sites of these two functions.
385
386         * WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
387         selectionStartHasStyle because it's not called anywhere outside of WebCore.
388         * WebCore.order: Ditto.
389         * editing/EditingStyle.cpp:
390         (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id
391         and a property value.
392         (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
393         * editing/EditingStyle.h:
394         (WebCore::EditingStyle::create): Added.
395         * editing/Editor.cpp:
396         (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of
397         a CSSStyleDeclaration.
398         (WebCore::Editor::selectionHasStyle): Ditto.
399         * editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
400         * editing/EditorCommand.cpp:
401         (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle.
402         (WebCore::stateStyle): Ditto.
403         * page/ContextMenuController.cpp:
404         (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
405
406 2011-03-07  Alexey Proskuryakov  <ap@apple.com>
407
408         Reviewed by Darin Adler.
409
410         REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
411         https://bugs.webkit.org/show_bug.cgi?id=55898
412
413         <rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
414         linkifying e-mail addresses in in -[DOMCharacterData setData:]
415
416         Changes render tree of fast/text/large-text-composed-char.html, but not image results.
417
418         * dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData):
419         Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
420
421         * dom/CharacterData.h: Moved a constant for maximum length from Text.h.
422
423         * dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
424         * dom/Text.h:
425         This function was unused in ToT. Moved code around to share with CharacterData.
426
427         * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
428         Chnaged to split large text nodes while parsing again.
429
430 2011-03-07  Alice Boxhall  <aboxhall@chromium.org>
431
432         Reviewed by Adam Barth.
433
434         Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
435         https://bugs.webkit.org/show_bug.cgi?id=54522
436
437         Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.
438
439         No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
440
441         * platform/image-encoders/JPEGImageEncoder.cpp:
442         (WebCore::jpegEmptyOutputBuffer):
443
444 2011-03-07  Sergey Glazunov  <serg.glazunov@gmail.com>
445
446         Reviewed by Eric Seidel.
447
448         Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
449         https://bugs.webkit.org/show_bug.cgi?id=55896
450
451         Test: svg/dom/vkern-element-crash.html
452
453         * svg/SVGHKernElement.cpp:
454         (WebCore::SVGHKernElement::insertedIntoDocument):
455         * svg/SVGVKernElement.cpp:
456         (WebCore::SVGVKernElement::insertedIntoDocument):
457
458 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
459
460         Unreviewed, rolling out r80514.
461         http://trac.webkit.org/changeset/80514
462         https://bugs.webkit.org/show_bug.cgi?id=55915
463
464         Caused assertion failures (Requested by ukai on #webkit).
465
466         * platform/graphics/skia/GraphicsContextSkia.cpp:
467         (WebCore::GraphicsContext::setPlatformShadow):
468         * platform/graphics/skia/ImageSkia.cpp:
469         (WebCore::paintSkBitmap):
470
471 2011-03-07  Cosmin Truta  <ctruta@chromium.org>
472
473         Reviewed by Adam Barth.
474
475         SVG <image> referenced by <use> is displayed incorrectly
476         https://bugs.webkit.org/show_bug.cgi?id=55750
477
478         The result of sourceURI must use the URL of the enclosing document as base.
479         Otherwise, the base may sometimes be empty, and, as a consequence,
480         the intermediate KURL object may be invalid.
481
482         Test: svg/custom/use-image-in-g.svg
483
484         * svg/SVGImageLoader.cpp:
485         (WebCore::SVGImageLoader::sourceURI):
486
487 2011-03-07  Helder Correia  <helder@sencha.com>
488
489         Reviewed by Simon Fraser.
490
491         Shadow is not shown when using strokeRect with a gradient strokeStyle
492         https://bugs.webkit.org/show_bug.cgi?id=52509
493
494         This happens in CG and is related to bug 51869, this time to be fixed
495         in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
496         We need to draw the gradient clipped to the stroke on a CGLayer first,
497         and then draw the layer on the GraphicsContext.
498
499         Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html
500                svg/css/rect-gradient-stroke-shadow.svg
501
502         * platform/graphics/cg/GraphicsContextCG.cpp:
503         (WebCore::GraphicsContext::strokeRect):
504
505 2011-03-07  Justin Novosad  <junov@chromium.org>
506
507         Reviewed by Kenneth Russell.
508
509         Fix for blurs behind bitmap images in Chromium, and boosting
510         shadow blur quality 
511         Bug URLs:
512                 https://bugs.webkit.org/show_bug.cgi?id=55410
513                 https://bugs.webkit.org/show_bug.cgi?id=55506
514
515         No new tests. Covered by existing layout tests. 
516
517         * platform/graphics/skia/GraphicsContextSkia.cpp:
518         (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
519         * platform/graphics/skia/ImageSkia.cpp:
520         (WebCore::paintSkBitmap): Propagate the draw looper from context to painter
521
522 2011-03-07  Andreas Kling  <kling@webkit.org>
523
524         Unreviewed Mac build fix after r80508.
525
526         * WebCore.exp.in:
527
528 2011-03-07  Enrica Casucci  <enrica@apple.com>
529
530         Unreviewed build fix.
531
532         Rolling back  http://trac.webkit.org/changeset/80497 due to the
533         32-bit build failures.
534
535         * WebCore.xcodeproj/project.pbxproj:
536         * platform/mac/HTMLConverter.h: Removed.
537         * platform/mac/HTMLConverter.mm: Removed.
538         * platform/mac/PasteboardMac.mm:
539         (WebCore::Pasteboard::writeSelection):
540
541 2011-03-07  Andreas Kling  <kling@webkit.org>
542
543         Reviewed by Benjamin Poulain.
544
545         FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.
546
547         * page/FrameView.cpp:
548         (WebCore::FrameView::setBaseBackgroundColor):
549         * page/FrameView.h:
550
551 2011-03-07  Adam Barth  <abarth@webkit.org>
552
553         Reviewed by Dimitri Glazkov.
554
555         REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
556         https://bugs.webkit.org/show_bug.cgi?id=55894
557
558         The m_frame can disappear out from under us, and there's no point in
559         checking whether the load is complete in a non-existant frame.
560
561         Test: fast/parser/document-write-into-initial-document.html
562
563         * dom/Document.cpp:
564         (WebCore::Document::explicitClose):
565
566 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
567
568         Unreviewed, rolling out r80500.
569         http://trac.webkit.org/changeset/80500
570         https://bugs.webkit.org/show_bug.cgi?id=55908
571
572         Caused mysterious GYP error (Requested by abarth on #webkit).
573
574         * WebCore.gyp/WebCore.gyp:
575         * WebCore.gypi:
576
577 2011-03-07  Adam Barth  <abarth@webkit.org>
578
579         Fix Chromium Mac build.  This header should only be included when the
580         feature is enabled.
581
582         * platform/cf/RunLoopTimerCF.cpp:
583
584 2011-03-07  Adam Barth  <abarth@webkit.org>
585
586         Reviewed by Dimitri Glazkov.
587
588         Add WML files to WebCore.gypi
589         https://bugs.webkit.org/show_bug.cgi?id=55905
590
591         * WebCore.gyp/WebCore.gyp:
592         * WebCore.gypi:
593
594 2011-03-07  Adrienne Walker  <enne@google.com>
595
596         Reviewed by James Robinson.
597
598         [chromium] Add missing include to #define Skia parameter
599         https://bugs.webkit.org/show_bug.cgi?id=55885
600
601         * platform/graphics/chromium/ShaderChromium.h:
602
603 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
604
605         Reviewed by Beth Dakin.
606
607         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
608         https://bugs.webkit.org/show_bug.cgi?id=55706
609
610         * WebCore.exp.in:
611         * accessibility/AXObjectCache.cpp:
612         (WebCore::AXObjectCache::rootObjectForFrame):
613         * accessibility/AXObjectCache.h:
614         * accessibility/AccessibilityScrollView.cpp:
615         (WebCore::AccessibilityScrollView::isAttachment):
616         (WebCore::AccessibilityScrollView::widgetForAttachmentView):
617         * accessibility/AccessibilityScrollView.h:
618         (WebCore::AccessibilityScrollView::firstChild):
619         * accessibility/mac/AccessibilityObjectWrapper.mm:
620         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
621
622 2011-03-07  Enrica Casucci  <enrica@apple.com>
623
624         Reviewed by Darin Adler.
625         
626         REGRESSION: Copied content loses formatting on paste to external apps.
627         https://bugs.webkit.org/show_bug.cgi?id=47615
628         <rdar://problem/9001214>
629
630         This is a resubmission of a patch that was landed a while ago then rolled
631         back because of a build failure on SnowLeopard and Leopard.
632         
633         This patch adds a way for WebKit2 to create NSAttributedStrings from
634         a DOM range without using the AppKit api initWithDOMRange that internally
635         needs to access the WebView. The NSAttributedString is needed to create
636         RTF formats in the pasteboard.
637         This is to be considered a first step, since in the future we want to have
638         an implementation based on the TextIterator.
639
640         * WebCore.xcodeproj/project.pbxproj: Added new file.
641         * platform/mac/HTMLConverter.h: Added.
642         * platform/mac/HTMLConverter.mm: Added.
643         * platform/mac/PasteboardMac.mm:
644         (WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
645         class for WebKit2 to create the NSAttributedString from the DOM range.
646
647 2011-03-07  Adam Barth  <abarth@webkit.org>
648
649         Reviewed by Dimitri Glazkov.
650
651         Add some missing platform files to WebCore.gypi
652         https://bugs.webkit.org/show_bug.cgi?id=55897
653
654         There are a bunch more, but this is a start.
655
656         * WebCore.gyp/WebCore.gyp:
657         * WebCore.gypi:
658
659 2011-03-07  Steve Block  <steveblock@google.com>
660
661         Reviewed by Jeremy Orlow.
662
663         Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
664         https://bugs.webkit.org/show_bug.cgi?id=55879
665
666         No new tests, refactoring only.
667
668         * Android.v8bindings.mk:
669         * WebCore.gypi:
670         * bridge/jni/v8/JavaClassV8.cpp:
671         * bridge/jni/v8/JavaClassV8.h:
672         * bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp.
673         (JavaField::JavaField):
674         * bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
675         (JSC::Bindings::JavaField::name):
676         (JSC::Bindings::JavaField::type):
677         (JSC::Bindings::JavaField::getJNIType):
678         * bridge/jni/v8/JavaInstanceV8.cpp:
679         * bridge/jni/v8/JavaNPObjectV8.cpp:
680
681 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
682
683         Reviewed by Tony Chang.
684
685         Add plumbing for paste support to ChromiumDataObject::types()
686         https://bugs.webkit.org/show_bug.cgi?id=55792
687
688         This is a preliminary patch to support event.dataTransfer.items. This
689         adds plumbing to support retrieving the types in a paste event. It also
690         moves the check for files in a drag/paste up to ClipboardChromium, since
691         internal code needs to be able to differentiate between actual files in
692         a drag and someone that simply decided to use "Files" as a custom type
693         string.
694
695         Test: editing/pasteboard/onpaste-text-html-types.html
696
697         * platform/chromium/ChromiumDataObject.cpp:
698         (WebCore::ChromiumDataObject::types):
699         (WebCore::ChromiumDataObject::containsFilenames):
700         * platform/chromium/ChromiumDataObject.h:
701         * platform/chromium/ClipboardChromium.cpp:
702         (WebCore::ClipboardChromium::types):
703         * platform/chromium/ClipboardMimeTypes.cpp:
704         * platform/chromium/ClipboardMimeTypes.h:
705
706 2011-03-07  Takayoshi Kochi  <kochi@chromium.org>
707
708         Reviewed by Tony Chang.
709
710         [chromium] Use preferred locale information when choosing fallback
711         font using fontconfig on Linux platform.
712         http://bugs.webkit.org/show_bug.cgi?id=55453
713
714         No new tests, as it depends on ICU and locale setting, so it will be
715         covered by Chromium side.
716
717         * platform/chromium/PlatformBridge.h:
718         * platform/graphics/chromium/FontCacheLinux.cpp:
719
720 2011-03-07  Adam Barth  <abarth@webkit.org>
721
722         Reviewed by Eric Seidel.
723
724         Add gobject, cpp, and objc bindings to WebCore.gypi
725         https://bugs.webkit.org/show_bug.cgi?id=55892
726
727         These are also excluded from the Chromium build but needed for various
728         other ports.
729
730         * WebCore.gyp/WebCore.gyp:
731         * WebCore.gypi:
732
733 2011-03-07  Sergey Glazunov  <serg.glazunov@gmail.com>
734
735         Reviewed by Dimitri Glazkov.
736
737         Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
738         https://bugs.webkit.org/show_bug.cgi?id=55803
739
740         Test: fast/dom/dom-method-document-change.html
741
742         * dom/ContainerNode.cpp:
743         (WebCore::ContainerNode::insertBefore):
744         (WebCore::ContainerNode::replaceChild):
745         (WebCore::ContainerNode::appendChild):
746         * dom/Node.cpp:
747         (WebCore::Node::checkReplaceChild):
748         (WebCore::Node::checkAddChild):
749         * dom/Node.h:
750
751 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
752
753         Unreviewed, rolling out r80484.
754         http://trac.webkit.org/changeset/80484
755         https://bugs.webkit.org/show_bug.cgi?id=55891
756
757         requires Chromium DEPS roll (Requested by dcheng on #webkit).
758
759         * platform/chromium/ChromiumDataObject.cpp:
760         (WebCore::ChromiumDataObject::types):
761         * platform/chromium/ChromiumDataObject.h:
762         (WebCore::ChromiumDataObject::containsFilenames):
763         * platform/chromium/ClipboardChromium.cpp:
764         (WebCore::ClipboardChromium::types):
765         * platform/chromium/ClipboardMimeTypes.cpp:
766         * platform/chromium/ClipboardMimeTypes.h:
767
768 2011-03-07  Adam Barth  <abarth@webkit.org>
769
770         Reviewed by Dimitri Glazkov.
771
772         Add missing bindings/js files to WebCore.gypi
773         https://bugs.webkit.org/show_bug.cgi?id=55888
774
775         These files are excluded from the Chromium build but needed for the Mac
776         build.
777
778         * WebCore.gypi:
779
780 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
781
782         Reviewed by Tony Chang.
783
784         Add plumbing for paste support to ChromiumDataObject::types()
785         https://bugs.webkit.org/show_bug.cgi?id=55792
786
787         This is a preliminary patch to support event.dataTransfer.items. This
788         adds plumbing to support retrieving the types in a paste event. It also
789         moves the check for files in a drag/paste up to ClipboardChromium, since
790         internal code needs to be able to differentiate between actual files in
791         a drag and someone that simply decided to use "Files" as a custom type
792         string.
793
794         Test: editing/pasteboard/onpaste-text-html-types.html
795
796         * platform/chromium/ChromiumDataObject.cpp:
797         (WebCore::ChromiumDataObject::types):
798         (WebCore::ChromiumDataObject::containsFilenames):
799         * platform/chromium/ChromiumDataObject.h:
800         * platform/chromium/ClipboardChromium.cpp:
801         (WebCore::ClipboardChromium::types):
802         * platform/chromium/ClipboardMimeTypes.cpp:
803         * platform/chromium/ClipboardMimeTypes.h:
804
805 2011-03-07  Joseph Pecoraro  <joepeck@webkit.org>
806
807         Reviewed by Kenneth Rohde Christiansen.
808
809         Viewport Warning/Error Messages Are Now Inaccurate
810         https://bugs.webkit.org/show_bug.cgi?id=53707
811
812         Correct and improve the error messages for viewport parsing.
813
814         Tests: fast/viewport/viewport-warnings-1.html
815                fast/viewport/viewport-warnings-2.html
816                fast/viewport/viewport-warnings-3.html
817                fast/viewport/viewport-warnings-4.html
818                fast/viewport/viewport-warnings-5.html
819                fast/viewport/viewport-warnings-6.html
820
821         * dom/ViewportArguments.cpp:
822         (WebCore::numericPrefix):
823         (WebCore::findSizeValue): remove incorrect device-width / height tips.
824         (WebCore::setViewportFeature): report a warning for an unrecognized key.
825         (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
826         (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
827         * dom/ViewportArguments.h: removed no longer used warnings.
828
829 2011-03-07  James Robinson  <jamesr@chromium.org>
830
831         Reviewed by Kenneth Russell.
832
833         [chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
834         https://bugs.webkit.org/show_bug.cgi?id=54047
835
836         This splits up LayerRendererChromium::drawLayers() into two phases,
837         one that updates layers and one that actually draws them.  Most of the
838         patch is moving the bodies of drawLayers() and updateLayersRecursive()
839         into smaller helper functions.
840
841         The main entry point is renamed updateAndDrawLayers(), but otherwise
842         has the same signature as drawLayers() did.  Internally it does the
843         following:
844
845         1.) Updates the root layer's contents
846         2.) Updates the root layer's scrollbars
847         3.) Updates the RenderSurface tree and the contents of all child
848         layers
849         4.) Draws the root layer and root layer scrollbars
850         5.) Draws all child layers using the previously updated
851         CCLayerImpl/RenderSurface data.
852
853         A few things still need to be done after this patch to complete the separation
854         of the update and draw step, but they can happen in later patches:
855         *) The root layer and root layer scrollbars contents should be
856         uploaded to textures at draw time, not update time.
857         *) The RenderSurface tree should be updated at draw time, not update
858         time.
859
860         Covered by the compositing/ tests.
861
862         * platform/graphics/chromium/LayerRendererChromium.cpp:
863         (WebCore::LayerRendererChromium::LayerRendererChromium):
864         (WebCore::LayerRendererChromium::updateRootLayerContents):
865         (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
866         (WebCore::LayerRendererChromium::drawRootLayer):
867         (WebCore::LayerRendererChromium::updateAndDrawLayers):
868         (WebCore::LayerRendererChromium::updateLayers):
869         (WebCore::LayerRendererChromium::drawLayers):
870         (WebCore::LayerRendererChromium::getFramebufferPixels):
871         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
872         (WebCore::LayerRendererChromium::updateContentsRecursive):
873         (WebCore::LayerRendererChromium::drawLayer):
874         * platform/graphics/chromium/LayerRendererChromium.h:
875         (WebCore::LayerRendererChromium::visibleRectSize):
876         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
877         (WebCore::RenderSurfaceChromium::drawSurface):
878         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
879         * platform/graphics/chromium/cc/CCLayerImpl.h:
880
881 2011-03-07  Adam Barth  <abarth@webkit.org>
882
883         Reviewed by Eric Seidel.
884
885         Sort WebCore.gypi
886         https://bugs.webkit.org/show_bug.cgi?id=55887
887
888         These files should be in order.  This is preparation for adding in the
889         missing files.
890
891         * WebCore.gypi:
892
893 2011-03-07  Csaba Osztrogon√°c  <ossy@webkit.org>
894
895         Unreviewed buildfix after r80478.
896
897         * dom/Document.cpp: Add suggested parentheses to make GCC happy.
898         (WebCore::Document::didReceiveTask):
899
900 2011-03-07  Yong Li  <yoli@rim.com>
901
902         Reviewed by Darin Adler.
903
904         Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
905         Schedule them with timer when page loading is resumed. The tasks will be performed
906         in the original order. This fixes the problem that database callbacks could be missed
907         when page loading was deferred.
908         https://bugs.webkit.org/show_bug.cgi?id=49401
909
910         Manual test added: manual-tests/database-callback-deferred.html.
911
912         * dom/Document.cpp:
913         (WebCore::Document::Document):
914         (WebCore::Document::~Document):
915         (WebCore::Document::didReceiveTask):
916         (WebCore::Document::postTask):
917         (WebCore::Document::pendingTasksTimerFired):
918         (WebCore::Document::willDeferLoading):
919         (WebCore::Document::didResumeLoading):
920         * dom/Document.h:
921         * manual-tests/database-callback-deferred.html: Added.
922         * page/PageGroupLoadDeferrer.cpp:
923         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
924         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
925
926 2011-03-07  Antti Koivisto  <antti@apple.com>
927
928         Reviewed by Sam Weinig.
929
930         Use HashMaps for caching primitive values
931         https://bugs.webkit.org/show_bug.cgi?id=55873
932         
933         Most documents use only small subset of cacheable primitive values. By replacing
934         fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
935         expanding the range of cacheable values.
936
937         * css/CSSPrimitiveValueCache.cpp:
938         (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
939         (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
940         (WebCore::CSSPrimitiveValueCache::createColorValue):
941         (WebCore::CSSPrimitiveValueCache::createValue):
942         * css/CSSPrimitiveValueCache.h:
943
944 2011-03-07  Steve Block  <steveblock@google.com>
945
946         Reviewed by Jeremy Orlow.
947
948         Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
949         https://bugs.webkit.org/show_bug.cgi?id=55881
950
951         No new tests, refactoring only.
952
953         * Android.jscbindings.mk:
954         * GNUmakefile.am:
955         * WebCore.xcodeproj/project.pbxproj:
956         * bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
957         * bridge/jni/jsc/JNIBridgeJSC.h: Removed.
958         * bridge/jni/jsc/JNIUtilityPrivate.cpp:
959         * bridge/jni/jsc/JavaClassJSC.cpp:
960         * bridge/jni/jsc/JavaClassJSC.h:
961         * bridge/jni/jsc/JavaInstanceJSC.cpp:
962
963 2011-03-07  Sam Weinig  <sam@webkit.org>
964
965         Reviewed by Anders Carlsson.
966
967         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
968         https://bugs.webkit.org/show_bug.cgi?id=55827
969
970         * loader/EmptyClients.h:
971         (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):
972         * loader/FrameLoaderClient.h:
973         * loader/MainResourceLoader.cpp:
974         (WebCore::MainResourceLoader::didReceiveResponse):
975         * loader/PolicyChecker.cpp:
976         (WebCore::PolicyChecker::checkContentPolicy):
977         * loader/PolicyChecker.h:
978         Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
979         and pass the entire response, instead of just the MIMEType.
980
981 2011-03-07  Eric Carlson  <eric.carlson@apple.com>
982
983         Reviewed by Darin Adler.
984
985         Add API to enumerate/delete files downloaded for <audio> and <video>
986         https://bugs.webkit.org/show_bug.cgi?id=55267
987         <rdar://problem/9049280>
988
989         No new tests, this is just more plumbing.
990
991         * html/HTMLMediaElement.cpp:
992         (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method.
993         (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
994         (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
995         * html/HTMLMediaElement.h:
996
997         * platform/graphics/MediaPlayer.cpp:
998         (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions.
999         (WebCore::addMediaEngine): Ditto.
1000         (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines.
1001         (WebCore::MediaPlayer::clearMediaCache): Ditto.
1002         (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
1003         * platform/graphics/MediaPlayer.h:
1004
1005         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1006         (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
1007
1008         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1009         (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
1010
1011         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1012         (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
1013
1014         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
1015         (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
1016
1017         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1018         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.
1019
1020         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1021         (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.
1022
1023 2011-03-07  Steve Block  <steveblock@google.com>
1024
1025         Reviewed by Jeremy Orlow.
1026
1027         Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
1028         https://bugs.webkit.org/show_bug.cgi?id=55774
1029
1030         No new tests, refactoring only.
1031
1032         * Android.jscbindings.mk:
1033         * Android.v8bindings.mk:
1034         * GNUmakefile.am:
1035         * WebCore.gypi:
1036         * WebCore.xcodeproj/project.pbxproj:
1037         * bridge/jni/JavaMethod.cpp:
1038         (JavaMethod::JavaMethod):
1039         (JavaMethod::~JavaMethod):
1040         (appendClassName):
1041         (JavaMethod::signature):
1042         (JavaMethod::JNIReturnType):
1043         (JavaMethod::methodID):
1044         * bridge/jni/JavaMethod.h:
1045         (JSC::Bindings::JavaMethod::name):
1046         (JSC::Bindings::JavaMethod::returnType):
1047         (JSC::Bindings::JavaMethod::parameterAt):
1048         (JSC::Bindings::JavaMethod::numParameters):
1049         (JSC::Bindings::JavaMethod::isStatic):
1050         * bridge/jni/JavaString.h:
1051         (JSC::Bindings::JavaString::JavaString):
1052         (JSC::Bindings::JavaString::utf8):
1053         (JSC::Bindings::JavaString::length):
1054         (JSC::Bindings::JavaString::impl):
1055         * bridge/jni/jni_jsobject.mm:
1056         * bridge/jni/jsc/JNIBridgeJSC.h:
1057         * bridge/jni/v8/JNIBridgeV8.h:
1058         * bridge/jni/v8/JavaClassV8.cpp:
1059         * bridge/jni/v8/JavaClassV8.h:
1060         * bridge/jni/v8/JavaInstanceV8.cpp:
1061
1062 2011-03-07  Jeremy Orlow  <jorlow@chromium.org>
1063
1064         Reviewed by Steve Block.
1065
1066         Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
1067         https://bugs.webkit.org/show_bug.cgi?id=55812
1068
1069         This brings us in line with what's in the spec:
1070         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html
1071
1072         * storage/IDBCursor.cpp:
1073         (WebCore::IDBCursor::create):
1074         (WebCore::IDBCursor::IDBCursor):
1075         (WebCore::IDBCursor::source):
1076         * storage/IDBCursor.h:
1077         * storage/IDBCursor.idl:
1078         * storage/IDBCursorWithValue.cpp:
1079         (WebCore::IDBCursorWithValue::create):
1080         (WebCore::IDBCursorWithValue::IDBCursorWithValue):
1081         * storage/IDBCursorWithValue.h:
1082         * storage/IDBIndex.cpp:
1083         (WebCore::IDBIndex::IDBIndex):
1084         * storage/IDBIndex.h:
1085         (WebCore::IDBIndex::create):
1086         (WebCore::IDBIndex::objectStore):
1087         * storage/IDBIndex.idl:
1088         * storage/IDBObjectStore.cpp:
1089         (WebCore::IDBObjectStore::createIndex):
1090         (WebCore::IDBObjectStore::index):
1091         * storage/IDBRequest.cpp:
1092         (WebCore::IDBRequest::onSuccess):
1093
1094 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1095
1096         Reviewed by Beth Dakin.
1097
1098         AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
1099         https://bugs.webkit.org/show_bug.cgi?id=55735
1100
1101         The ARIA grid implementation needed to verify the row/column range of a cell instead of 
1102         assuming a 1-1 mapping between children and row/column.
1103
1104         Test: platform/mac/accessibility/aria-table-with-colspan-cells.html
1105
1106         * accessibility/AccessibilityARIAGrid.cpp:
1107         (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
1108
1109 2011-03-07  Andrei Popescu  <andreip@google.com>
1110
1111         Reviewed by Steve Block.
1112
1113         IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
1114         IDBObjectStore objects used to be created asynchronously, so we needed
1115         this method to be invoked, with the new object store as the parameter,
1116         whenever the creation succeeded. The spec has changed so that IDBObjectStore
1117         objects are created synchronously, so this method is no longer needed.
1118         https://bugs.webkit.org/show_bug.cgi?id=55777
1119
1120         No new tests, just refactoring.
1121
1122         * storage/IDBCallbacks.h:
1123         * storage/IDBRequest.cpp:
1124         * storage/IDBRequest.h:
1125
1126 2011-03-04  Steve Block  <steveblock@google.com>
1127
1128         Reviewed by Jeremy Orlow.
1129
1130         JavaParameter should be removed
1131         https://bugs.webkit.org/show_bug.cgi?id=55772
1132
1133         No new tests, refactoring only.
1134
1135         * bridge/jni/JNIBridge.cpp:
1136         (JavaMethod::JavaMethod):
1137         (JavaMethod::~JavaMethod):
1138         (JavaMethod::signature):
1139         * bridge/jni/JNIBridge.h:
1140         (JSC::Bindings::JavaMethod::parameterAt):
1141         (JSC::Bindings::JavaMethod::numParameters):
1142         * bridge/jni/JNIUtility.h:
1143         * bridge/jni/jsc/JavaInstanceJSC.cpp:
1144         (JavaInstance::invokeMethod):
1145         * bridge/jni/v8/JNIUtilityPrivate.cpp:
1146         (JSC::Bindings::convertNPVariantToJValue):
1147         * bridge/jni/v8/JNIUtilityPrivate.h:
1148         * bridge/jni/v8/JavaInstanceV8.cpp:
1149         (JavaInstance::invokeMethod):
1150
1151 2011-03-07  Antti Koivisto  <antti@apple.com>
1152
1153         Reviewed by Oliver Hunt.
1154
1155         REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots 
1156         https://bugs.webkit.org/show_bug.cgi?id=55166
1157         <rdar://problem/9050430>
1158         
1159         Make CSS primitive value cache per-document.
1160         
1161         Test: http/tests/security/cross-origin-css-primitive.html
1162
1163         * Android.mk:
1164         * CMakeLists.txt:
1165         * GNUmakefile.am:
1166         * WebCore.gypi:
1167         * WebCore.pro:
1168         * WebCore.vcproj/WebCore.vcproj:
1169         * WebCore.xcodeproj/project.pbxproj:
1170         * css/CSSComputedStyleDeclaration.cpp:
1171         (WebCore::valueForNinePieceImage):
1172         (WebCore::zoomAdjustedPixelValue):
1173         (WebCore::zoomAdjustedNumberValue):
1174         (WebCore::zoomAdjustedPixelValueForLength):
1175         (WebCore::valueForReflection):
1176         (WebCore::getPositionOffsetValue):
1177         (WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
1178         (WebCore::getBorderRadiusCornerValue):
1179         (WebCore::computedTransform):
1180         (WebCore::getDelayValue):
1181         (WebCore::getDurationValue):
1182         (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
1183         (WebCore::CSSComputedStyleDeclaration::valueForShadow):
1184         (WebCore::valueForFamily):
1185         (WebCore::renderTextDecorationFlagsToCSSValue):
1186         (WebCore::fillRepeatToCSSValue):
1187         (WebCore::fillSizeToCSSValue):
1188         (WebCore::contentToCSSValue):
1189         (WebCore::counterToCSSValue):
1190         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1191         * css/CSSParser.cpp:
1192         (WebCore::CSSParser::parseSheet):
1193         (WebCore::CSSParser::parseRule):
1194         (WebCore::CSSParser::parseKeyframeRule):
1195         (WebCore::CSSParser::parseValue):
1196         (WebCore::CSSParser::parseColor):
1197         (WebCore::CSSParser::parseSelector):
1198         (WebCore::CSSParser::parseDeclaration):
1199         (WebCore::CSSParser::setStyleSheet):
1200         (WebCore::CSSParser::parseWCSSInputProperty):
1201         (WebCore::parseBackgroundClip):
1202         (WebCore::CSSParser::parseFillShorthand):
1203         (WebCore::CSSParser::parsePage):
1204         (WebCore::CSSParser::parseSizeParameter):
1205         (WebCore::CSSParser::parseContent):
1206         (WebCore::CSSParser::parseAttr):
1207         (WebCore::CSSParser::parseBackgroundColor):
1208         (WebCore::CSSParser::parseFillPositionXY):
1209         (WebCore::CSSParser::parseFillPosition):
1210         (WebCore::CSSParser::parseFillRepeat):
1211         (WebCore::CSSParser::parseFillSize):
1212         (WebCore::CSSParser::parseFillProperty):
1213         (WebCore::CSSParser::parseAnimationDelay):
1214         (WebCore::CSSParser::parseAnimationDirection):
1215         (WebCore::CSSParser::parseAnimationDuration):
1216         (WebCore::CSSParser::parseAnimationFillMode):
1217         (WebCore::CSSParser::parseAnimationIterationCount):
1218         (WebCore::CSSParser::parseAnimationName):
1219         (WebCore::CSSParser::parseAnimationPlayState):
1220         (WebCore::CSSParser::parseAnimationProperty):
1221         (WebCore::CSSParser::parseTransformOriginShorthand):
1222         (WebCore::CSSParser::parseAnimationTimingFunction):
1223         (WebCore::CSSParser::parseDashboardRegions):
1224         (WebCore::CSSParser::parseCounterContent):
1225         (WebCore::CSSParser::parseShape):
1226         (WebCore::CSSParser::parseFont):
1227         (WebCore::CSSParser::parseFontFamily):
1228         (WebCore::CSSParser::parseFontStyle):
1229         (WebCore::CSSParser::parseFontVariant):
1230         (WebCore::CSSParser::parseFontWeight):
1231         (WebCore::ShadowParseContext::ShadowParseContext):
1232         (WebCore::ShadowParseContext::commitLength):
1233         (WebCore::ShadowParseContext::commitStyle):
1234         (WebCore::CSSParser::parseShadow):
1235         (WebCore::CSSParser::parseReflect):
1236         (WebCore::BorderImageParseContext::BorderImageParseContext):
1237         (WebCore::BorderImageParseContext::commitNumber):
1238         (WebCore::BorderImageParseContext::commitBorderImage):
1239         (WebCore::CSSParser::parseBorderImage):
1240         (WebCore::CSSParser::parseBorderRadius):
1241         (WebCore::CSSParser::parseCounter):
1242         (WebCore::parseDeprecatedGradientPoint):
1243         (WebCore::parseDeprecatedGradientColorStop):
1244         (WebCore::CSSParser::parseDeprecatedGradient):
1245         (WebCore::valueFromSideKeyword):
1246         (WebCore::parseGradientColorOrKeyword):
1247         (WebCore::CSSParser::parseLinearGradient):
1248         (WebCore::CSSParser::parseRadialGradient):
1249         (WebCore::CSSParser::parseGradientColorStops):
1250         (WebCore::CSSParser::parseTransform):
1251         (WebCore::CSSParser::parseTransformOrigin):
1252         (WebCore::CSSParser::parseTextEmphasisStyle):
1253         * css/CSSParser.h:
1254         (WebCore::CSSParser::primitiveValueCache):
1255         * css/CSSPrimitiveValue.cpp:
1256         * css/CSSPrimitiveValue.h:
1257         (WebCore::CSSPrimitiveValue::createIdentifier):
1258         (WebCore::CSSPrimitiveValue::createColor):
1259         (WebCore::CSSPrimitiveValue::create):
1260         * css/CSSPrimitiveValueCache.cpp: Added.
1261         (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
1262         (WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
1263         (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
1264         (WebCore::CSSPrimitiveValueCache::createColorValue):
1265         (WebCore::CSSPrimitiveValueCache::createValue):
1266         * css/CSSPrimitiveValueCache.h: Added.
1267         (WebCore::CSSPrimitiveValueCache::create):
1268         (WebCore::CSSPrimitiveValueCache::createValue):
1269         * dom/Document.cpp:
1270         (WebCore::Document::cssPrimitiveValueCache):
1271         * dom/Document.h:
1272
1273 2011-03-06  Adam Barth  <abarth@webkit.org>
1274
1275         Reviewed by Eric Seidel.
1276
1277         Filter sources in WebCore GYP build for Mac
1278         https://bugs.webkit.org/show_bug.cgi?id=55857
1279
1280         This patch removes a large number of files that do not build as part of
1281         the Mac build.  I'm not fully sold on this method of
1282         including/excluding files, but it's the "gyp way" so we should probably
1283         try it first.
1284
1285         This patch also sets xcode_list_excluded_files to 0, which removes the
1286         excluded files from the Xcode project file, which is necessary in order
1287         to prevent the header map feature from including the wrong header file.
1288
1289         * gyp/WebCore.gyp:
1290
1291 2011-03-07  Ryuan Choi  <ryuan.choi@samsung.com>
1292
1293         Unreviewed EFL build fix.
1294
1295         [EFL] Build break on Debug build.
1296         https://bugs.webkit.org/show_bug.cgi?id=55858
1297
1298         * platform/efl/RenderThemeEfl.cpp:
1299         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
1300
1301 2011-03-06  Adam Barth  <abarth@webkit.org>
1302
1303         Reviewed by Eric Seidel.
1304
1305         Add webcore_derived_source_files to WebCore.gypi
1306         https://bugs.webkit.org/show_bug.cgi?id=55856
1307
1308         This is the list of files generated by the Mac port.  It's possible
1309         other ports generate a different list of files.
1310
1311         * WebCore.gypi:
1312         * gyp/WebCore.gyp:
1313
1314 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
1315
1316         Reviewed by Kent Tamura.
1317
1318         Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
1319         https://bugs.webkit.org/show_bug.cgi?id=55839
1320         http://crbug.com/73866
1321         http://crbug.com/62527
1322
1323         We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.
1324
1325         Test: fast/forms/input-appearance-spinbutton-visibility.html
1326
1327         * rendering/RenderTextControlSingleLine.cpp:
1328         (WebCore::RenderTextControlSingleLine::styleDidChange):
1329
1330 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
1331
1332         Reviewed by Kent Tamura.
1333
1334         [Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
1335         https://bugs.webkit.org/show_bug.cgi?id=54795
1336
1337         Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.
1338
1339         Test: manual-tests/popup-width-restriction-within-screen.html
1340
1341         * manual-tests/popup-width-restriction-within-screen.html: Added.
1342         * platform/chromium/PopupMenuChromium.cpp:
1343         (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
1344
1345 2011-03-06  Yuta Kitamura  <yutak@chromium.org>
1346
1347         Reviewed by Kent Tamura.
1348
1349         Add SHA-1 for new WebSocket protocol
1350         https://bugs.webkit.org/show_bug.cgi?id=55039
1351
1352         * ForwardingHeaders/wtf/SHA1.h: Added.
1353
1354 2011-03-06  Eric Carlson  <eric.carlson@apple.com>
1355
1356         Reviewed by Antti Koivisto.
1357
1358         QuickTime based media engines should respect private browsing mode
1359         https://bugs.webkit.org/show_bug.cgi?id=55848
1360
1361         No new tests, it is only possible to test this by manually deleting and monitoring the
1362         the Quicktime caches.
1363
1364         * html/HTMLMediaElement.cpp:
1365         (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
1366
1367         * platform/graphics/MediaPlayer.cpp:
1368         (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing.
1369         (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine.
1370         (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
1371         * platform/graphics/MediaPlayer.h:
1372         * platform/graphics/MediaPlayerPrivate.h:
1373         (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
1374
1375         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1376         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1377         (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing.
1378         (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when
1379             creating new movie.
1380         (WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in
1381             m_privateBrowsing and set movie attribute.
1382
1383         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1384         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
1385             Initialize m_privateBrowsing.
1386         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store 
1387             privacy setting in m_privateBrowsing and call QTMovie.
1388         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
1389
1390         * platform/graphics/win/QTMovie.cpp:
1391         (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing.
1392         (QTMovie::load):Pass private browsing property when creating new movie.
1393         (QTMovie::setPrivateBrowsingMode):  New, store privacy setting in m_privateBrowsing and 
1394             set movie property.
1395         * platform/graphics/win/QTMovie.h:
1396
1397 2011-03-06  Daniel Bates  <dbates@rim.com>
1398
1399         Reviewed by Darin Adler.
1400
1401         style.borderSpacing always returns empty string
1402         https://bugs.webkit.org/show_bug.cgi?id=54816
1403
1404         Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
1405         the value for border-spacing from the value of the WebKit internal CSS
1406         property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
1407
1408         The CSS property border-spacing describes the horizontal and vertical border
1409         spacing for an HTML Table element. Notice, WebKit internally represents the value
1410         of this property as two properties: -webkit-border-horizontal-spacing and
1411         -webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
1412         respectively. And WebKit doesn't know to reconstitute these internal properties.
1413         Therefore style.borderSpacing always returns the empty string.
1414
1415         Test: fast/css/table-border-spacing.html
1416
1417         * css/CSSMutableStyleDeclaration.cpp:
1418         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1419         (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
1420         * css/CSSMutableStyleDeclaration.h:
1421
1422 2011-03-06  Dan Bernstein  <mitz@apple.com>
1423
1424         Reviewed by Oliver Hunt.
1425
1426         <rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
1427         https://bugs.webkit.org/show_bug.cgi?id=55850
1428
1429         Tests: fast/css/parsing-hyphenate-limit.html
1430                fast/text/hyphenate-limit-before-after.html
1431
1432         * css/CSSComputedStyleDeclaration.cpp:
1433         (WebCore::computedProperties) Updated this array with the new properties and some old properties
1434         that it was missing.
1435         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
1436         CSSPropertyWebkitHyphenateLimit{Before,After}.
1437
1438         * css/CSSParser.cpp:
1439         (WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
1440         'auto' and non-negative integers.
1441
1442         * css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
1443
1444         * css/CSSStyleSelector.cpp:
1445         (WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.
1446
1447         * rendering/RenderBlockLineLayout.cpp:
1448         (WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
1449         allow hyphenation if the prefix and the suffix are sufficiently long.
1450         (WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().
1451
1452         * rendering/style/RenderStyle.cpp:
1453         (WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.
1454
1455         * rendering/style/RenderStyle.h:
1456         (WebCore::InheritedFlags::hyphenationLimitBefore): Added.
1457         (WebCore::InheritedFlags::hyphenationLimitAfter): Added.
1458         (WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
1459         (WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
1460         (WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
1461         representation of 'auto'.
1462         (WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.
1463
1464         * rendering/style/StyleRareInheritedData.cpp:
1465         (WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
1466         (WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.
1467         * rendering/style/StyleRareInheritedData.h:
1468
1469 2011-03-06  Jessie Berlin  <jberlin@apple.com>
1470
1471         Reviewed by Sam Weinig.
1472
1473         WebKit2: Use CFNetwork Sessions API.
1474         https://bugs.webkit.org/show_bug.cgi?id=55435.
1475
1476         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
1477         Private Browsing Storage Session.
1478
1479         * WebCore.exp.in:
1480         Add the new WKSI functions.
1481         * platform/mac/WebCoreSystemInterface.h:
1482         Ditto.
1483         * platform/mac/WebCoreSystemInterface.mm:
1484         Ditto.
1485
1486         * platform/mac/CookieJar.mm:
1487         (WebCore::cookies):
1488         If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
1489         Otherwise, behave the same as before.
1490         (WebCore::cookieRequestHeaderFieldValue):
1491         Ditto.
1492         (WebCore::setCookies):
1493         Ditto.
1494         (WebCore::cookiesEnabled):
1495         Ditto
1496         (WebCore::getRawCookies):
1497         Ditto.
1498         (WebCore::deleteCookie):
1499         Ditto.
1500
1501         * platform/network/CookieStorage.h:
1502         * platform/network/cf/CookieStorageCFNet.cpp:
1503         (WebCore::privateBrowsingCookieStorage):
1504         Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
1505         function instead of at the global scope.
1506         (WebCore::currentCookieStorage):
1507         Use privateBrowsingCookieStorage.
1508         (WebCore::setCurrentCookieStorage):
1509         Ditto.
1510         (WebCore::setCookieStoragePrivateBrowsingEnabled):
1511         If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
1512         wkCreatePrivateInMemoryHTTPCookieStorage.
1513         * platform/network/mac/CookieStorageMac.mm:
1514         (WebCore::privateBrowsingCookieStorage):
1515         Keep track of the Private Browsing Cookie Storage.
1516         (WebCore::setCookieStoragePrivateBrowsingEnabled):
1517         If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
1518         Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
1519
1520         * platform/network/mac/ResourceHandleMac.mm:
1521         (WebCore::shouldRelaxThirdPartyCookiePolicy):
1522         Refactor the logic to determine whether or not to relax the third party cookie policy here.
1523         If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
1524         (WebCore::ResourceHandle::createNSURLConnection):
1525         Use shouldRelaxThirdPartyCookiePolicy.
1526         (WebCore::ResourceHandle::loadResourceSynchronously):
1527         Ditto.
1528
1529 2011-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1530
1531         Unreviewed, rolling out r80428.
1532         http://trac.webkit.org/changeset/80428
1533         https://bugs.webkit.org/show_bug.cgi?id=55833
1534
1535         Broke SnowLeopard (Requested by xan_ on #webkit).
1536
1537         * plugins/gtk/PluginViewGtk.cpp:
1538         (WebCore::PluginView::handlePostReadFile):
1539
1540 2011-03-01  Martin Robinson  <mrobinson@igalia.com>
1541
1542         Reviewed by Xan Lopez.
1543
1544         [GTK] Windowless plugins override the view cursor
1545         https://bugs.webkit.org/show_bug.cgi?id=55531
1546
1547         manual test: manual-tests/plugins/windowless.html
1548
1549         * platform/gtk/WidgetGtk.cpp:
1550         (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
1551         * plugins/gtk/PluginViewGtk.cpp:
1552         (WebCore::PluginView::initXEvent): Instead of setting the window for windowless
1553         plugin events, set the window value to none. This method is also used to send
1554         focus in / focus out events to windowed plugins, but this is not one of the plugin
1555         types where the window parameter matters. This matches what Mozilla does. Also
1556         pass in the display of the widget itself, not the default display.
1557         (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area,
1558         reset the cursor.
1559         (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
1560         widget the top-level window explicitly. This matches Mozilla.
1561
1562 2011-03-05  Martin Robinson  <mrobinson@igalia.com>
1563
1564         Reviewed by Xan Lopez.
1565
1566         [GTK] http/tests/plugins/post-url-file.html fails on GTK+
1567         https://bugs.webkit.org/show_bug.cgi?id=55826
1568
1569         Correct the implementation of handlePostReadFile which uses GIO APIs and
1570         actually resizes the buffer to fit the entire size of the file data. This
1571         was likely leading to memory corruption until now.
1572
1573         * plugins/gtk/PluginViewGtk.cpp:
1574         (WebCore::PluginView::handlePostReadFile): Fix this method.
1575
1576 2011-03-05  Mikhail Naganov  <mnaganov@chromium.org>
1577
1578         Reviewed by Pavel Feldman.
1579
1580         Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
1581         https://bugs.webkit.org/show_bug.cgi?id=55824
1582
1583         Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
1584
1585         * inspector/front-end/DetailedHeapshotView.js:
1586         (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
1587         * inspector/front-end/ProfilesPanel.js:
1588         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
1589         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
1590         (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
1591         (WebInspector.ProfilesPanel.prototype.handleShortcut):
1592         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint):
1593         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint):
1594         (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
1595         (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
1596
1597 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
1598
1599         Reviewed by Laszlo Gombos.
1600
1601         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
1602         https://bugs.webkit.org/show_bug.cgi?id=48636
1603
1604         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
1605
1606         * WebCore.pri:
1607         * features.pri:
1608
1609 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
1610
1611         Not reviewed: adding null check to prevent inspector tests from failing.
1612
1613         * inspector/front-end/TextViewer.js:
1614         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
1615         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
1616
1617 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
1618
1619         Not reviewed: chromium rebaseline, flaky test fix.
1620
1621         * inspector/front-end/BreakpointManager.js:
1622         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
1623         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
1624         (WebInspector.DOMBreakpointView.prototype._format.formatters.s):
1625         (WebInspector.DOMBreakpointView.prototype._format.append):
1626         (WebInspector.DOMBreakpointView.prototype._format):
1627
1628 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
1629
1630         Reviewed by Yury Semikhatsky.
1631
1632         Web Inspector: [chromium] pause when script is running is broken.
1633         https://bugs.webkit.org/show_bug.cgi?id=55762
1634
1635         * inspector/CodeGeneratorInspector.pm:
1636
1637 2011-03-05  Adam Barth  <abarth@webkit.org>
1638
1639         Reviewed by Dimitri Glazkov.
1640
1641         Add Derived Sources to WebCore GYP build
1642         https://bugs.webkit.org/show_bug.cgi?id=55813
1643
1644         Adding the derived source action to the GYP file required tweaking
1645         DerivedSources.make.  I'm not sure how DerivedSources.make worked
1646         before beause these paths were incorrectly based.
1647
1648         * DerivedSources.make:
1649         * gyp/generate-derived-sources.sh: Added.
1650         * gyp/WebCore.gyp:
1651
1652 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
1653
1654         Reviewed by Yury Semikhatsky.
1655
1656         Web Inspector: fix layout tests flakiness.
1657         https://bugs.webkit.org/show_bug.cgi?id=55816
1658
1659         - Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
1660         - Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
1661
1662         * inspector/CodeGeneratorInspector.pm:
1663         * inspector/InspectorAgent.cpp:
1664         (WebCore::InspectorAgent::InspectorAgent):
1665         (WebCore::InspectorAgent::disconnectFrontend):
1666         (WebCore::InspectorAgent::populateScriptObjects):
1667         (WebCore::InspectorAgent::evaluateForTestInFrontend):
1668         (WebCore::InspectorAgent::issueEvaluateForTestCommands):
1669         * inspector/InspectorAgent.h:
1670         * inspector/front-end/TimelinePanel.js:
1671         (WebInspector.TimelinePanel.FormattedRecord):
1672         * inspector/front-end/inspector.js:
1673         (WebInspector.dispatch):
1674
1675 2011-03-05  Adam Barth  <abarth@webkit.org>
1676
1677         Reviewed by Dimitri Glazkov.
1678
1679         WebCore GYP build should generate fewer than 10,000 compile errors per file
1680         https://bugs.webkit.org/show_bug.cgi?id=55810
1681
1682         This patch adds some missing include paths.  We need to figure out how
1683         to handle separate include paths per port.  It's clear that
1684         ForwardingHeaders are only useful for Mac, but it's less clear how to
1685         handle the others.
1686
1687         * WebCore.gypi:
1688         * gyp/WebCore.gyp:
1689
1690 2011-03-05  Dan Bernstein  <mitz@apple.com>
1691
1692         Reviewed by Cameron Zwarich.
1693
1694         <rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
1695         https://bugs.webkit.org/show_bug.cgi?id=55817
1696
1697         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
1698         (WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
1699         a CGFont obtained from Core Text for the primary font. This CGFont may be different from
1700         the CGFont stored in the FontPlatformData.
1701
1702 2011-03-05  Ilya Sherman  <isherman@chromium.org>
1703
1704         Reviewed by Darin Adler.
1705
1706         HTMLInputElement::setValue() should schedule change event when the element is focused.
1707         Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
1708         In service of https://code.google.com/p/chromium/issues/detail?id=42716
1709         https://bugs.webkit.org/show_bug.cgi?id=53160
1710
1711         Test: fast/forms/onchange-change-type.html
1712         Test: fast/forms/onchange-setvalueforuser.html
1713
1714         * WebCore.exp.in:
1715         * dom/Document.cpp:
1716         (WebCore::Document::setFocusedNode):
1717         * dom/Element.h:
1718         (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
1719         (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
1720         * html/HTMLFormControlElement.cpp:
1721         (WebCore::HTMLFormControlElement::HTMLFormControlElement):
1722         (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added.
1723         (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added.
1724         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
1725         (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
1726         * html/HTMLFormControlElement.h:
1727         * html/HTMLInputElement.cpp:
1728         (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag.
1729         (WebCore::HTMLInputElement::setValue):
1730             For a focused text field, dispatch an input event, but delay the change event until the field loses focus.
1731         (WebCore::HTMLInputElement::defaultEventHandler):
1732         (WebCore::HTMLInputElement::stepUpFromRenderer):
1733         * html/shadow/TextControlInnerElements.cpp:
1734         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
1735         * rendering/RenderTextControl.cpp:
1736         (WebCore::RenderTextControl::RenderTextControl):
1737         (WebCore::RenderTextControl::subtreeHasChanged):
1738         * rendering/RenderTextControl.h:
1739         * rendering/RenderTextControlMultiLine.cpp:
1740         (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
1741         * rendering/RenderTextControlSingleLine.cpp:
1742         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
1743         * wml/WMLInputElement.cpp:
1744         (WebCore::WMLInputElement::WMLInputElement):
1745         (WebCore::WMLInputElement::defaultEventHandler):
1746         * wml/WMLInputElement.h:
1747         (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added.
1748         (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.
1749
1750 2011-03-04  Xianzhu Wang  <wangxianzhu@google.com>
1751
1752         Reviewed by Adam Barth.
1753
1754         Remove fake request loading of SVGImage to avoid MainResourceLoader
1755         leak. The frame->init() already ensures initialization of the
1756         document loader.
1757
1758         https://bugs.webkit.org/show_bug.cgi?id=55017
1759
1760         Test: fast/images/svg-image-leak-loader.html
1761
1762         * svg/graphics/SVGImage.cpp:
1763         (WebCore::SVGImage::dataChanged):
1764
1765 2011-03-04  Mike Reed  <reed@google.com>
1766
1767         Reviewed by Mihai Parparita.
1768
1769         [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
1770         https://bugs.webkit.org/show_bug.cgi?id=49477
1771
1772         * platform/graphics/skia/PathSkia.cpp:
1773         (WebCore::Path::addArc):
1774
1775 2011-03-04  Jia Pu  <jpu@apple.com>
1776
1777         Reviewed by Darin Adler.
1778
1779         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
1780         https://bugs.webkit.org/show_bug.cgi?id=55717
1781         <rdar://problem/9018127>
1782
1783         manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
1784
1785         Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
1786         coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
1787         to convert the bounding box to window coordinate using ScrollView::contentToWindow().
1788
1789         * dom/Range.cpp:
1790         (WebCore::Range::getBoundingClientRect):
1791         (WebCore::Range::boundingRect):
1792         * dom/Range.h:
1793         * editing/Editor.cpp:
1794         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
1795         (WebCore::Editor::correctionPanelTimerFired):
1796         (WebCore::Editor::windowRectForRange):
1797         * editing/Editor.h:
1798         * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
1799         * manual-tests/autocorrection/document-for-iframe-test.html: Added.
1800
1801 2011-03-04  Jia Pu  <jpu@apple.com>
1802
1803         Reviewed by Darin Adler.
1804
1805         Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
1806         https://bugs.webkit.org/show_bug.cgi?id=55731
1807
1808         No new tests. There's no behavioral change.
1809
1810         This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
1811
1812         * editing/Editor.cpp:
1813         (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
1814
1815 2011-03-04  John Bauman  <jbauman@chromium.org>
1816
1817         Reviewed by Kenneth Russell.
1818
1819         [chromium] premultipliedAlpha WebGL context attribute is ignored.
1820         https://bugs.webkit.org/show_bug.cgi?id=55411
1821
1822         Update compositor to set the blending of each layer correctly.
1823
1824         Test: compositing/webgl/webgl-nonpremultiplied-blend.html
1825
1826         * platform/graphics/chromium/CanvasLayerChromium.cpp:
1827         (WebCore::CanvasLayerChromium::CanvasLayerChromium):
1828         (WebCore::CanvasLayerChromium::draw):
1829         * platform/graphics/chromium/CanvasLayerChromium.h:
1830         * platform/graphics/chromium/ContentLayerChromium.cpp:
1831         (WebCore::ContentLayerChromium::draw):
1832         * platform/graphics/chromium/LayerRendererChromium.cpp:
1833         (WebCore::LayerRendererChromium::drawLayers):
1834         * platform/graphics/chromium/WebGLLayerChromium.cpp:
1835         (WebCore::WebGLLayerChromium::setContext):
1836
1837 2011-03-04  Adam Barth  <abarth@webkit.org>
1838
1839         Reviewed by Eric Seidel.
1840
1841         WebCore GYP build should link with the correct frameworks
1842         https://bugs.webkit.org/show_bug.cgi?id=55804
1843
1844         * gyp/WebCore.gyp:
1845
1846 2011-03-04  Adam Barth  <abarth@webkit.org>
1847
1848         Reviewed by Eric Seidel.
1849
1850         WebCore GYP build should Check For Inappropriate Files in Framework
1851         https://bugs.webkit.org/show_bug.cgi?id=55806
1852
1853         * gyp/WebCore.gyp:
1854
1855 2011-03-04  Dimitri Glazkov  <dglazkov@chromium.org>
1856
1857         Reviewed by Adam Barth.
1858
1859         Add skeletal WebCore.gyp
1860         https://bugs.webkit.org/show_bug.cgi?id=55802
1861
1862         This doesn't yet build, but the basic structure is there.
1863
1864         * WebCore.gypi: Added headers and include directories variables.
1865         * gyp/WebCore.gyp: Added.
1866
1867 2011-03-04  Adam Barth  <abarth@webkit.org>
1868
1869         Reviewed by Dimitri Glazkov.
1870
1871         Remove unneeded round-trips through ../Source in the Chromium GYP build
1872         https://bugs.webkit.org/show_bug.cgi?id=55795
1873
1874         This is just cleanup work, but it was bugging me.
1875
1876         * WebCore.gyp/WebCore.gyp:
1877
1878 2011-03-04  Mike Reed  <reed@google.com>
1879
1880         Reviewed by James Robinson.
1881
1882         Option to use skia's native text drawing APIs when drawing text
1883         on Windows, rather than from outlines using drawPath(). This will
1884         only have a significant effect when the skia-gpu backend is enabled.
1885         https://bugs.webkit.org/show_bug.cgi?id=55609
1886
1887         No new tests. This is disabled by default. When enabled, it will draw
1888         essentially the same, but with slightly different antialiased edges, due
1889         to differences between the current scanconverter and GDI's font scaler.
1890         When enabled, we will have to recalibrate layouttest image results. 
1891
1892         * platform/graphics/skia/SkiaFontWin.cpp:
1893         (WebCore::skiaDrawText):
1894         (WebCore::setupPaintForFont):
1895         (WebCore::paintSkiaText):
1896
1897 2011-03-04  Adrienne Walker  <enne@google.com>
1898
1899         Reviewed by James Robinson.
1900
1901         [chromium] Fix texture stride issues on large content and image layers.
1902         https://bugs.webkit.org/show_bug.cgi?id=55679
1903
1904         This was an error caused during the refactoring in r80081.
1905
1906         Tests: LayoutTests/compositing/tiling/huge-layer-img.html
1907
1908         * platform/graphics/chromium/ContentLayerChromium.cpp:
1909         (WebCore::ContentLayerChromium::updateTexture):
1910         * platform/graphics/chromium/ImageLayerChromium.cpp:
1911         (WebCore::ImageLayerChromium::updateTextureIfNeeded):
1912
1913 2011-03-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1914
1915         Unreviewed, rolling out r80379.
1916         http://trac.webkit.org/changeset/80379
1917         https://bugs.webkit.org/show_bug.cgi?id=55799
1918
1919         "Breaks leopard compile (implicit conversion)" (Requested by
1920         tonyg-cr on #webkit).
1921
1922         * css/CSSStyleSelector.cpp:
1923         (WebCore::convertToLength):
1924         (WebCore::CSSStyleSelector::applyProperty):
1925         (WebCore::CSSStyleSelector::createTransformOperations):
1926         * platform/Length.h:
1927         (WebCore::Length::Length):
1928         (WebCore::Length::operator==):
1929         (WebCore::Length::operator!=):
1930         (WebCore::Length::rawValue):
1931         (WebCore::Length::type):
1932         (WebCore::Length::quirk):
1933         (WebCore::Length::setValue):
1934         (WebCore::Length::setRawValue):
1935         (WebCore::Length::calcFloatValue):
1936         (WebCore::Length::isZero):
1937         (WebCore::Length::blend):
1938         * rendering/AutoTableLayout.cpp:
1939         (WebCore::AutoTableLayout::recalcColumn):
1940         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
1941         * rendering/FixedTableLayout.cpp:
1942         (WebCore::FixedTableLayout::calcWidthArray):
1943
1944 2011-03-04  Jessie Berlin  <jberlin@apple.com>
1945
1946         Reviewed by Darin Adler.
1947
1948         WebKit2: Use CFNetwork Sessions API.
1949         https://bugs.webkit.org/show_bug.cgi?id=55435.
1950
1951         Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
1952         contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
1953
1954         * platform/network/cf/ResourceHandleCFNet.cpp:
1955         (WebCore::makeFinalRequest):
1956         (WebCore::ResourceHandle::willSendRequest):
1957         * platform/network/cf/ResourceRequestCFNet.cpp:
1958         * platform/network/mac/ResourceHandleMac.mm:
1959         (WebCore::ResourceHandle::createNSURLConnection):
1960         (WebCore::ResourceHandle::willSendRequest):
1961         * platform/network/mac/ResourceRequestMac.mm:
1962
1963 2011-03-04  Yuqiang Xian  <yuqiang.xian@intel.com>
1964
1965         Reviewed by Darin Adler.
1966
1967         improve layout performance by reducing the traversal time of the floating objects
1968         https://bugs.webkit.org/show_bug.cgi?id=55440
1969
1970         We observered large overhead on traversing the floating objects list
1971         in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
1972         when the list becomes enormous, for example in the default 30x30 maze test
1973         from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
1974         there're >3700 floating objects. When placing a new floating object the
1975         entire list (from begin to end) is traversed for multiple times.
1976         There's a low hanging fruit to reduce the chances to do the traversal
1977         which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
1978         As the two routines either cares about FloatLeft objects or FloatRight objects only,
1979         if we know there's no corresponding type floating objects in the list
1980         we can avoid the traversal actually. One thing we could do is to record
1981         the number of FloatLeft objects and the number of FloatRight objects and
1982         add a check before doing the traversal. This can reduce the time by 45%
1983         to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
1984         Chromium browser 11 (from 503s to 269s).
1985
1986         No new tests, relying on existing layout tests.
1987
1988         * rendering/RenderBlock.cpp:
1989         (WebCore::RenderBlock::~RenderBlock):
1990         (WebCore::RenderBlock::addOverflowFromFloats):
1991         (WebCore::RenderBlock::repaintOverhangingFloats):
1992         (WebCore::RenderBlock::paintFloats):
1993         (WebCore::RenderBlock::selectionGaps):
1994         (WebCore::RenderBlock::insertFloatingObject):
1995         (WebCore::RenderBlock::removeFloatingObject):
1996         (WebCore::RenderBlock::removeFloatingObjectsBelow):
1997         (WebCore::RenderBlock::positionNewFloats):
1998         (WebCore::RenderBlock::positionNewFloatOnLine):
1999         (WebCore::RenderBlock::logicalLeftOffsetForLine):
2000         (WebCore::RenderBlock::logicalRightOffsetForLine):
2001         (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
2002         (WebCore::RenderBlock::lowestFloatLogicalBottom):
2003         (WebCore::RenderBlock::clearFloats):
2004         (WebCore::RenderBlock::addOverhangingFloats):
2005         (WebCore::RenderBlock::addIntrudingFloats):
2006         (WebCore::RenderBlock::containsFloat):
2007         (WebCore::RenderBlock::hitTestFloats):
2008         (WebCore::RenderBlock::adjustForBorderFit):
2009         (WebCore::RenderBlock::FloatingObjects::clear):
2010         (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
2011         (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
2012         * rendering/RenderBlock.h:
2013         (WebCore::RenderBlock::containsFloats):
2014         (WebCore::RenderBlock::FloatingObjects::FloatingObjects):
2015         (WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
2016         (WebCore::RenderBlock::FloatingObjects::hasRightObjects):
2017         (WebCore::RenderBlock::FloatingObjects::set):
2018         * rendering/RenderBlockLineLayout.cpp:
2019         (WebCore::RenderBlock::layoutInlineChildren):
2020         (WebCore::RenderBlock::matchedEndLine):
2021
2022 2011-03-04  Rik Cabanier  <cabanier@gmail.com>
2023
2024         Reviewed by David Hyatt.
2025
2026         Fix that allows fixed length values to be floating point
2027         https://bugs.webkit.org/show_bug.cgi?id=52699
2028
2029         * WebCore.xcodeproj/project.pbxproj:
2030         * css/CSSStyleSelector.cpp:
2031         (WebCore::convertToLength):
2032         (WebCore::convertToIntLength):
2033         (WebCore::convertToFloatLength):
2034         (WebCore::CSSStyleSelector::applyProperty):
2035         (WebCore::CSSStyleSelector::createTransformOperations):
2036         * platform/Length.h:
2037         (WebCore::Length::Length):
2038         (WebCore::Length::operator==):
2039         (WebCore::Length::operator!=):
2040         (WebCore::Length::rawValue):
2041         (WebCore::Length::type):
2042         (WebCore::Length::quirk):
2043         (WebCore::Length::setValue):
2044         (WebCore::Length::calcFloatValue):
2045         (WebCore::Length::isZero):
2046         (WebCore::Length::blend):
2047         (WebCore::Length::getIntValue):
2048         (WebCore::Length::getFloatValue):
2049         * rendering/AutoTableLayout.cpp:
2050         (WebCore::AutoTableLayout::recalcColumn):
2051         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
2052         * rendering/FixedTableLayout.cpp:
2053         (WebCore::FixedTableLayout::calcWidthArray):
2054
2055 2011-03-04  Steve Falkenburg  <sfalken@apple.com>
2056
2057         Reviewed by Jon Honeycutt.
2058
2059         Adopt VersionStamper tool for Windows WebKit DLLs
2060         https://bugs.webkit.org/show_bug.cgi?id=55784
2061         
2062         We now use a tool to stamp the version number onto the Apple WebKit DLLs
2063         during the post-build step.
2064
2065         * WebCore.vcproj/QTMovieWin.rc: Removed.
2066         * WebCore.vcproj/QTMovieWin.vcproj:
2067         * WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
2068         * WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
2069         * WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
2070
2071 2011-03-04  Cosmin Truta  <ctruta@chromium.org>
2072
2073         Reviewed by Adam Barth.
2074
2075         Clarify comment about potential memory leak in SVGImage
2076         https://bugs.webkit.org/show_bug.cgi?id=55362
2077
2078         No functionality change. No new tests.
2079
2080         * svg/graphics/SVGImage.cpp:
2081         (WebCore::SVGImage::dataChanged):
2082
2083 2011-03-04  Jessie Berlin  <jberlin@apple.com>
2084
2085         Reviewed by Maciej Stachowiak.
2086
2087         WebKit2: Use CFNetwork Sessions API.
2088         https://bugs.webkit.org/show_bug.cgi?id=55435.
2089
2090         When Private Browsing is enabled, get the cached url response from the cache associated with
2091         the Private Browsing Storage Session.
2092
2093         * WebCore.exp.in:
2094         Export the symbol for ResourceHandle::privateBrowsingStorageSession.
2095
2096 2011-03-04  Steve Block  <steveblock@google.com>
2097
2098         Reviewed by Jeremy Orlow.
2099
2100         JSC and V8 versions of Java bridge should share JobjectWrapper
2101         https://bugs.webkit.org/show_bug.cgi?id=55763
2102
2103         No new tests, refactoring only.
2104
2105         * Android.jscbindings.mk:
2106         * Android.v8bindings.mk:
2107         * WebCore.gypi:
2108         * WebCore.order:
2109         * WebCore.xcodeproj/project.pbxproj:
2110         * bridge/jni/JobjectWrapper.cpp:
2111         (JobjectWrapper::JobjectWrapper):
2112         (JobjectWrapper::~JobjectWrapper):
2113         * bridge/jni/JobjectWrapper.h:
2114         (JSC::Bindings::JobjectWrapper::instance):
2115         (JSC::Bindings::JobjectWrapper::setInstance):
2116         (JSC::Bindings::JobjectWrapper::ref):
2117         (JSC::Bindings::JobjectWrapper::deref):
2118         * bridge/jni/jsc/JNIBridgeJSC.cpp:
2119         (JavaField::JavaField):
2120         (JavaArray::JavaArray):
2121         * bridge/jni/jsc/JNIBridgeJSC.h:
2122         * bridge/jni/jsc/JavaInstanceJSC.cpp:
2123         (JavaInstance::JavaInstance):
2124         * bridge/jni/jsc/JavaInstanceJSC.h:
2125
2126 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
2127
2128         Reviewed by Nikolas Zimmermann.
2129
2130         Move shared code into SVGStyledTransformableElement::svgAttributeChanged
2131         https://bugs.webkit.org/show_bug.cgi?id=55771
2132
2133         All sub classes of SVGStyledTransformableElement request a relayout
2134         the same way. So move that code into the common base class.
2135
2136         * svg/SVGCircleElement.cpp:
2137         (WebCore::SVGCircleElement::svgAttributeChanged):
2138         * svg/SVGEllipseElement.cpp:
2139         (WebCore::SVGEllipseElement::svgAttributeChanged):
2140         * svg/SVGForeignObjectElement.cpp:
2141         (WebCore::SVGForeignObjectElement::svgAttributeChanged):
2142         * svg/SVGGElement.cpp:
2143         (WebCore::SVGGElement::svgAttributeChanged):
2144         * svg/SVGImageElement.cpp:
2145         (WebCore::SVGImageElement::svgAttributeChanged):
2146         * svg/SVGLineElement.cpp:
2147         (WebCore::SVGLineElement::svgAttributeChanged):
2148         * svg/SVGPathElement.cpp:
2149         (WebCore::SVGPathElement::svgAttributeChanged):
2150         * svg/SVGPolyElement.cpp:
2151         (WebCore::SVGPolyElement::svgAttributeChanged):
2152         * svg/SVGRectElement.cpp:
2153         (WebCore::SVGRectElement::svgAttributeChanged):
2154         * svg/SVGStyledTransformableElement.cpp:
2155         (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
2156         * svg/SVGStyledTransformableElement.h:
2157         * svg/SVGUseElement.cpp:
2158         (WebCore::SVGUseElement::svgAttributeChanged):
2159
2160 2011-03-03  John Abd-El-Malek  <jam@chromium.org>
2161
2162         Reviewed by Dimitri Glazkov.
2163
2164         [chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
2165         https://bugs.webkit.org/show_bug.cgi?id=55748
2166
2167         * platform/network/chromium/ResourceResponse.cpp:
2168         (WebCore::ResourceResponse::doPlatformCopyData):
2169         (WebCore::ResourceResponse::doPlatformAdopt):
2170         * platform/network/chromium/ResourceResponse.h:
2171         (WebCore::ResourceResponse::ResourceResponse):
2172
2173 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2174
2175         Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
2176
2177         Reviewed by Darin Adler.
2178
2179         * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
2180
2181 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
2182
2183         Reviewed by Yury Semikhatsky.
2184
2185         Web Inspector: extract all code that depends on source mapping from SourceFrame.
2186         https://bugs.webkit.org/show_bug.cgi?id=55464
2187
2188         Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
2189         to encapsulate source mapping aspects from SourceFrame.
2190
2191         * inspector/front-end/ResourceView.js:
2192         (WebInspector.ResourceView.createResourceView):
2193         (WebInspector.SourceFrameDelegateForResourcesPanel):
2194         (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
2195         * inspector/front-end/ScriptsPanel.js:
2196         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
2197         (WebInspector.SourceFrameDelegateForScriptsPanel):
2198         * inspector/front-end/SourceFrame.js:
2199         (WebInspector.SourceFrame):
2200         (WebInspector.SourceFrame.prototype.show):
2201         (WebInspector.SourceFrame.prototype._createTextViewer):
2202         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
2203         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
2204         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
2205         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
2206         (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
2207         (WebInspector.SourceFrame.prototype._contextMenu):
2208         (WebInspector.SourceFrame.prototype._mouseDown):
2209         (WebInspector.SourceFrame.prototype._mouseMove):
2210         (WebInspector.SourceFrame.prototype._hidePopup):
2211         (WebInspector.SourceFrame.prototype._mouseHover):
2212         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
2213         (WebInspector.SourceFrame.prototype._showPopup):
2214         (WebInspector.SourceFrame.prototype._doubleClick):
2215         (WebInspector.SourceFrame.prototype._didEditLine):
2216         (WebInspector.SourceFrameDelegate):
2217         (WebInspector.SourceFrameDelegate.prototype.requestContent):
2218         (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
2219         (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
2220         (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
2221         (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
2222         (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
2223         (WebInspector.SourceFrameDelegate.prototype.continueToLine):
2224         (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
2225         (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
2226         (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
2227         (WebInspector.SourceFrameDelegate.prototype.evaluate):
2228         (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
2229
2230 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
2231
2232         Reviewed by Pavel Feldman.
2233
2234         Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
2235         https://bugs.webkit.org/show_bug.cgi?id=55686
2236
2237         - Use internal ids for resources in extension server.
2238         - Log errors in inspector tests.
2239
2240         * inspector/front-end/ExtensionServer.js:
2241         (WebInspector.ExtensionServer):
2242         (WebInspector.ExtensionServer.prototype.resetResources):
2243         (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
2244         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
2245         (WebInspector.ExtensionServer.prototype._onGetHAR):
2246         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
2247         (WebInspector.ExtensionServer.prototype._resourceId):
2248         (WebInspector.ExtensionServer.prototype._resourceById):
2249         * inspector/front-end/HAREntry.js:
2250         (WebInspector.HARLog):
2251         (WebInspector.HARLog.prototype._convertResource):
2252         * inspector/front-end/NetworkPanel.js:
2253         (WebInspector.NetworkPanel.prototype._reset):
2254
2255 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
2256
2257         Reviewed by Pavel Feldman.
2258
2259         Web Inspector: exceptions when building context menu in network panel
2260         https://bugs.webkit.org/show_bug.cgi?id=55678
2261
2262         * inspector/front-end/DataGrid.js:
2263         (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
2264         (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
2265         * inspector/front-end/NetworkPanel.js:
2266         (WebInspector.NetworkPanel.prototype._contextMenu):
2267
2268 2011-03-04  Ilya Sherman  <isherman@chromium.org>
2269
2270         Reviewed by James Robinson.
2271
2272         Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
2273         This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
2274         is a FramelessScrollView -- which is mostly just for Autofill.
2275         In service of http://crbug.com/73772 (crash)
2276         https://bugs.webkit.org/show_bug.cgi?id=55557
2277
2278         No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
2279         In particular, DRT crashes when trying to render a FramelessScrollView.
2280
2281         * platform/ScrollbarTheme.h:
2282         (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner().
2283         (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
2284         * platform/chromium/FramelessScrollView.cpp:
2285         (WebCore::FramelessScrollView::paintContents):
2286         (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
2287         * platform/chromium/FramelessScrollView.h:
2288         * platform/chromium/ScrollbarThemeChromium.cpp:
2289         * platform/chromium/ScrollbarThemeChromium.h:
2290
2291 2011-03-04  Yury Semikhatsky  <yurys@chromium.org>
2292
2293         Reviewed by Pavel Feldman.
2294
2295         Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
2296         https://bugs.webkit.org/show_bug.cgi?id=55770
2297
2298         * inspector/InspectorAgent.cpp:
2299         (WebCore::InspectorAgent::InspectorAgent):
2300         (WebCore::InspectorAgent::didCommitLoad):
2301         * inspector/InspectorCSSAgent.cpp:
2302         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
2303         (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
2304         * inspector/InspectorCSSAgent.h:
2305         * inspector/InspectorDatabaseAgent.cpp:
2306         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
2307         * inspector/InspectorInstrumentation.cpp:
2308         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
2309         * inspector/InspectorInstrumentation.h:
2310         (WebCore::InspectorInstrumentation::didCommitLoad):
2311         * inspector/InspectorProfilerAgent.cpp:
2312         (WebCore::InspectorProfilerAgent::create):
2313         (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
2314         (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
2315         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
2316         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
2317         (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
2318         (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
2319         * inspector/InspectorProfilerAgent.h:
2320         * inspector/InstrumentingAgents.h:
2321         (WebCore::InstrumentingAgents::InstrumentingAgents):
2322         (WebCore::InstrumentingAgents::inspectorCSSAgent):
2323         (WebCore::InstrumentingAgents::setInspectorCSSAgent):
2324         (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
2325         (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
2326         (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
2327         (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
2328         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
2329         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
2330         (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
2331         (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
2332         (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
2333         (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
2334         (WebCore::InstrumentingAgents::inspectorProfilerAgent):
2335         (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
2336
2337 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
2338
2339         Reviewed by Yury Semikhatsky.
2340
2341         Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
2342         https://bugs.webkit.org/show_bug.cgi?id=55773
2343
2344         * inspector/CodeGeneratorInspector.pm:
2345         * inspector/InjectedScript.cpp:
2346         (WebCore::InjectedScript::releaseObjectGroup):
2347         * inspector/InjectedScript.h:
2348         * inspector/InjectedScriptHost.cpp:
2349         (WebCore::InjectedScriptHost::releaseObjectGroup):
2350         * inspector/InjectedScriptHost.h:
2351         * inspector/InjectedScriptSource.js:
2352         (.):
2353         * inspector/Inspector.idl:
2354         * inspector/InspectorConsoleAgent.cpp:
2355         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
2356         * inspector/InspectorRuntimeAgent.cpp:
2357         (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
2358         * inspector/InspectorRuntimeAgent.h:
2359         * inspector/front-end/ConsoleView.js:
2360         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
2361         (WebInspector.ConsoleView.prototype.completions):
2362         * inspector/front-end/PropertiesSidebarPane.js:
2363         * inspector/front-end/SourceFrame.js:
2364         (WebInspector.SourceFrame.prototype._hidePopup):
2365         * inspector/front-end/WatchExpressionsSidebarPane.js:
2366         (WebInspector.WatchExpressionsSection.prototype.update):
2367
2368 2011-03-02  Andrey Adaikin  <aandrey@google.com>
2369
2370         Reviewed by Pavel Feldman.
2371
2372         Web Inspector: Gutter height should be 100% when few lines are displayed
2373         https://bugs.webkit.org/show_bug.cgi?id=55574
2374
2375         * inspector/front-end/SourceFrame.js:
2376         (WebInspector.SourceFrame.prototype._startEditing):
2377         * inspector/front-end/TextViewer.js:
2378         (WebInspector.TextViewer.prototype._syncScroll):
2379         (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
2380         (WebInspector.TextEditorGutterPanel.prototype.textChanged):
2381         (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
2382         * inspector/front-end/textViewer.css:
2383         (.text-editor-lines):
2384         (.text-editor-contents .inner-container):
2385         (.webkit-line-number):
2386
2387 2011-03-04  Andrey Adaikin  <aandrey@google.com>
2388
2389         Reviewed by Pavel Feldman.
2390
2391         Web Inspector: [Text editor] Do bisect to find visible chunks
2392         https://bugs.webkit.org/show_bug.cgi?id=55685
2393
2394         * inspector/front-end/TextViewer.js:
2395         (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
2396         (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
2397         (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
2398         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
2399         (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
2400         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
2401
2402 2011-03-04  Andrey Adaikin  <aandrey@google.com>
2403
2404         Reviewed by Pavel Feldman.
2405
2406         Web Inspector: [Text editor] DOMNodeRemoved events are missing
2407         https://bugs.webkit.org/show_bug.cgi?id=55769
2408
2409         * inspector/front-end/TextViewer.js:
2410         (WebInspector.TextEditorMainPanel):
2411         (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
2412         (WebInspector.TextEditorMainChunk):
2413         (WebInspector.TextEditorMainChunk.prototype._createRow):
2414
2415 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
2416
2417         Reviewed by Yury Semikhatsky.
2418
2419         Web Inspector: Remove unnecessary domain and success flags from the response messages.
2420         https://bugs.webkit.org/show_bug.cgi?id=55768
2421
2422         We have domain property in the response messages but it is not used because we dispatch
2423         the responses on the callback associated with seq.
2424
2425         If we have property 'errors' in the response then success eq false and true in the other case.
2426
2427         * inspector/CodeGeneratorInspector.pm:
2428
2429 2011-03-04  Christian Dywan  <christian@lanedo.com>
2430
2431         Reviewed by Gustavo Noronha Silva.
2432
2433         Enable Copy Image Address context menu item in the Gtk port
2434         https://bugs.webkit.org/show_bug.cgi?id=55136
2435
2436         * page/ContextMenuController.cpp:
2437         * platform/ContextMenuItem.h:
2438         * platform/LocalizationStrategy.h:
2439         * platform/LocalizedStrings.cpp:
2440         * platform/LocalizedStrings.h:
2441         * platform/gtk/ContextMenuItemGtk.cpp:
2442         * platform/gtk/LocalizedStringsGtk.cpp:
2443
2444 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
2445
2446         Reviewed by Yury Semikhatsky.
2447
2448         Web Inspector: implement getCompletions via evaluate.
2449         https://bugs.webkit.org/show_bug.cgi?id=55759
2450
2451         * inspector/InjectedScript.cpp:
2452         * inspector/InjectedScript.h:
2453         * inspector/InjectedScriptSource.js:
2454         * inspector/Inspector.idl:
2455         * inspector/InspectorDebuggerAgent.cpp:
2456         * inspector/InspectorDebuggerAgent.h:
2457         * inspector/InspectorRuntimeAgent.cpp:
2458         * inspector/InspectorRuntimeAgent.h:
2459         * inspector/front-end/ConsoleView.js:
2460         (WebInspector.ConsoleView.prototype.completions.evaluated):
2461         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
2462         (WebInspector.ConsoleView.prototype.completions):
2463         (WebInspector.ConsoleView.prototype._reportCompletions):
2464         * inspector/front-end/ScriptsPanel.js:
2465         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
2466         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
2467         * inspector/front-end/SourceFrame.js:
2468         (WebInspector.SourceFrame.prototype._showPopup):
2469         (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
2470
2471 2011-03-04  Steve Block  <steveblock@google.com>
2472
2473         Reviewed by Jeremy Orlow.
2474
2475         V8 version of JavaString should obtain string from JNI in UTF-16 encoding
2476         https://bugs.webkit.org/show_bug.cgi?id=55566
2477
2478         We obtain the string from JNI in UTF-16 encoding and convert
2479         to UTF-8 using our own routines as required. This matches the
2480         behaviour of the JSC version of JavaString.
2481
2482         No new tests, no change in behaviour.
2483
2484         * bridge/jni/v8/JavaStringV8.h:
2485         (JSC::Bindings::JavaStringImpl::init):
2486         (JSC::Bindings::JavaStringImpl::utf8):
2487         (JSC::Bindings::JavaStringImpl::impl):
2488
2489 2011-03-03  Pavel Feldman  <pfeldman@chromium.org>
2490
2491         Reviewed by Yury Semikhatsky.
2492
2493         Web Inspector: do not push document into front-end, make it request one.
2494         https://bugs.webkit.org/show_bug.cgi?id=55664
2495
2496         * inspector/Inspector.idl:
2497         * inspector/InspectorAgent.cpp:
2498         (WebCore::InspectorAgent::InspectorAgent):
2499         * inspector/InspectorAgent.h:
2500         * inspector/InspectorBrowserDebuggerAgent.cpp:
2501         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
2502         * inspector/InspectorDOMAgent.cpp:
2503         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2504         (WebCore::InspectorDOMAgent::clearFrontend):
2505         (WebCore::InspectorDOMAgent::setDocument):
2506         (WebCore::InspectorDOMAgent::getDocument):
2507         (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
2508         (WebCore::InspectorDOMAgent::boundNodeId):
2509         (WebCore::InspectorDOMAgent::resolveNode):
2510         (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
2511         * inspector/InspectorDOMAgent.h:
2512         (WebCore::InspectorDOMAgent::create):
2513         * inspector/front-end/BreakpointManager.js:
2514         (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
2515         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
2516         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
2517         * inspector/front-end/DOMAgent.js:
2518         (WebInspector.DOMDocument):
2519         (WebInspector.DOMAgent):
2520         (WebInspector.DOMAgent.prototype.requestDocument):
2521         (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
2522         (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
2523         (WebInspector.DOMAgent.prototype._attributesUpdated):
2524         (WebInspector.DOMAgent.prototype._characterDataModified):
2525         (WebInspector.DOMAgent.prototype._documentUpdated):
2526         (WebInspector.DOMAgent.prototype._setDocument):
2527         (WebInspector.DOMAgent.prototype._setDetachedRoot):
2528         (WebInspector.DOMAgent.prototype._setChildNodes):
2529         (WebInspector.DOMAgent.prototype._childNodeInserted):
2530         (WebInspector.DOMAgent.prototype._childNodeRemoved):
2531         (WebInspector.DOMDispatcher.prototype.documentUpdated):
2532         * inspector/front-end/ElementsPanel.js:
2533         (WebInspector.ElementsPanel.prototype.show):
2534         (WebInspector.ElementsPanel.prototype.setDocument):
2535         * inspector/front-end/MetricsSidebarPane.js:
2536         * inspector/front-end/RemoteObject.js:
2537         (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
2538
2539 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
2540
2541         Reviewed by Pavel Feldman.
2542
2543         Web Inspector: summary bar may overlap content of the network item view
2544         https://bugs.webkit.org/show_bug.cgi?id=55656
2545
2546         - drop custom summary bar placement logic, do it with CSS instead.
2547
2548         * inspector/front-end/NetworkPanel.js:
2549         (WebInspector.NetworkPanel.prototype.resize):
2550         (WebInspector.NetworkPanel.prototype._createSummaryBar):
2551         (WebInspector.NetworkPanel.prototype._updateSummaryBar):
2552         (WebInspector.NetworkPanel.prototype._updateFilter):
2553         (WebInspector.NetworkPanel.prototype.show):
2554         (WebInspector.NetworkPanel.prototype.refresh):
2555         (WebInspector.NetworkPanel.prototype._reset):
2556         (WebInspector.NetworkPanel.prototype._setLargerResources):
2557         (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
2558         * inspector/front-end/networkPanel.css:
2559         (.network-sidebar .data-grid td):
2560         (.network-sidebar tr.filler td):
2561         (.network-summary-bar):
2562         (.network-sidebar .data-grid .network-summary-bar td):
2563         (.network-summary-bar img):
2564
2565 2011-03-04  James Su <suzhe@chromium.org>
2566
2567         Reviewed by Dimitri Glazkov.
2568
2569         [Chromium] keycode is always 0 when using non-Latin keyboard layout.
2570         https://bugs.webkit.org/show_bug.cgi?id=54939
2571
2572         Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
2573
2574         No intended functionality change.
2575
2576         * WebCore.gyp/WebCore.gyp:
2577         * WebCore.gypi:
2578
2579 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
2580
2581         Unreviewed EFL build fix for r80324.
2582
2583         * platform/efl/RenderThemeEfl.cpp:
2584         (WebCore::RenderThemeEfl::paintThemePart):
2585
2586 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
2587
2588         Unreviewed EFL build fix for r80324.
2589
2590         * platform/efl/RenderThemeEfl.cpp:
2591         (WebCore::RenderThemeEfl::paintThemePart):
2592
2593 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
2594
2595         Reviewed by Pavel Feldman.
2596
2597         Web Inspector: AppCache agent should have same lifetime as InspectorAgent
2598         https://bugs.webkit.org/show_bug.cgi?id=55673
2599
2600         * inspector/InspectorAgent.cpp:
2601         (WebCore::InspectorAgent::InspectorAgent):
2602         (WebCore::InspectorAgent::setFrontend):
2603         (WebCore::InspectorAgent::disconnectFrontend):
2604         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
2605         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
2606         (WebCore::InspectorAgent::didCommitLoad):
2607         * inspector/InspectorApplicationCacheAgent.cpp:
2608         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
2609         (WebCore::InspectorApplicationCacheAgent::setFrontend):
2610         (WebCore::InspectorApplicationCacheAgent::clearFrontend):
2611         * inspector/InspectorApplicationCacheAgent.h:
2612         * inspector/InspectorInstrumentation.cpp:
2613         (WebCore::InspectorInstrumentation::networkStateChangedImpl):
2614         (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
2615         * inspector/InstrumentingAgents.h:
2616         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
2617         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
2618
2619 2011-03-03  Brian Weinstein  <bweinstein@apple.com>
2620
2621         Reviewed by Adam Roben.
2622
2623         Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
2624         
2625         Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
2626         on all platforms, and stub the functions on platforms that don't implement them.
2627         
2628         Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
2629         for platforms that don't implement them.
2630
2631         * platform/android/TemporaryLinkStubs.cpp:
2632         * platform/brew/TemporaryLinkStubs.cpp:
2633         * platform/chromium/TemporaryLinkStubs.cpp:
2634         * platform/efl/TemporaryLinkStubs.cpp:
2635         * platform/gtk/TemporaryLinkStubs.cpp:
2636         * platform/haiku/TemporaryLinkStubs.cpp:
2637         * platform/qt/TemporaryLinkStubsQt.cpp:
2638         * platform/win/TemporaryLinkStubs.cpp:
2639
2640 2011-03-03  Eric Seidel  <eric@webkit.org>
2641
2642         Reviewed by Dimitri Glazkov.
2643
2644         Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
2645         https://bugs.webkit.org/show_bug.cgi?id=55720
2646
2647         There are two thing going on here:
2648         1. Delaying nextRenderer calculation until we actually use it,
2649            previously we would always compute nextRenderer (expensive!)
2650            even if no renderer insertion was to occur.
2651         2. Fix fullscreen elements to be inserted into the right place
2652            in the rendering tree.  Previously they would always be the last
2653            child in their parent's list, even if that wasn't the right place.
2654
2655         I don't know of any way to trigger the fullscreen bug,
2656         but I tested this with peacekeeper and saw no performance change.
2657
2658         Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
2659         but I don't really trust the stability of peacekeeper to begin with.
2660
2661         This paves the way for further improvement in our nextRenderer calculation.
2662
2663         * dom/Node.cpp:
2664         (WebCore::Node::attach):
2665         (WebCore::Node::previousRenderer):
2666         (WebCore::Node::nextRenderer):
2667         (WebCore::Node::createRendererAndStyle):
2668         (WebCore::wrapWithRenderFullScreen):
2669         (WebCore::Node::createRendererIfNeeded):
2670         * dom/Node.h:
2671
2672 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2673
2674         Reviewed by Darin Adler.
2675
2676         Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
2677         https://bugs.webkit.org/show_bug.cgi?id=55554
2678
2679         * platform/Length.cpp:
2680         (WebCore::newLengthArray): Pass nullptr instead of 0.
2681
2682 2011-03-03  Nat Duca  <nduca@chromium.org>
2683
2684         Reviewed by James Robinson.
2685
2686         [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
2687         LayerRendererChromium that draws compositor FPS and, optionally,
2688         the layer tree.
2689         https://bugs.webkit.org/show_bug.cgi?id=54710
2690
2691         * WebCore.gypi:
2692         * platform/graphics/chromium/Canvas2DLayerChromium.h:
2693         (WebCore::Canvas2DLayerChromium::drawsContent):
2694         * platform/graphics/chromium/CanvasLayerChromium.h:
2695         (WebCore::CanvasLayerChromium::layerTypeAsString):
2696         * platform/graphics/chromium/ContentLayerChromium.cpp:
2697         (WebCore::writeIndent):
2698         (WebCore::ContentLayerChromium::dumpLayerProperties):
2699         * platform/graphics/chromium/ContentLayerChromium.h:
2700         (WebCore::ContentLayerChromium::drawsContent):
2701         (WebCore::ContentLayerChromium::layerTypeAsString):
2702         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
2703         (WebCore::GraphicsLayerChromium::setName):
2704         (WebCore::GraphicsLayerChromium::updateNames):
2705         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
2706         (WebCore::GraphicsLayerChromium::setupContentsLayer):
2707         * platform/graphics/chromium/GraphicsLayerChromium.h:
2708         * platform/graphics/chromium/ImageLayerChromium.h:
2709         (WebCore::ImageLayerChromium::drawsContent):
2710         (WebCore::ImageLayerChromium::layerTypeAsString):
2711         * platform/graphics/chromium/LayerChromium.cpp:
2712         (WebCore::LayerChromium::LayerChromium):
2713         (WebCore::LayerChromium::setName):
2714         (WebCore::LayerChromium::layerTreeAsText):
2715         (WebCore::writeIndent):
2716         (WebCore::LayerChromium::dumpLayer):
2717         (WebCore::LayerChromium::dumpLayerProperties):
2718         * platform/graphics/chromium/LayerChromium.h:
2719         (WebCore::LayerChromium::name):
2720         (WebCore::LayerChromium::drawsContent):
2721         (WebCore::LayerChromium::debugID):
2722         (WebCore::LayerChromium::layerTypeAsString):
2723         * platform/graphics/chromium/LayerRendererChromium.cpp:
2724         (WebCore::LayerRendererChromium::LayerRendererChromium):
2725         (WebCore::LayerRendererChromium::~LayerRendererChromium):
2726         (WebCore::LayerRendererChromium::drawLayers):
2727         (WebCore::LayerRendererChromium::present):
2728         (WebCore::LayerRendererChromium::layerTreeAsText):
2729         (WebCore::LayerRendererChromium::dumpRenderSurfaces):
2730         * platform/graphics/chromium/LayerRendererChromium.h:
2731         (WebCore::LayerRendererChromium::getHeadsUpDisplay):
2732         (WebCore::LayerRendererChromium::rootVisibleRect):
2733         * platform/graphics/chromium/PluginLayerChromium.h:
2734         (WebCore::PluginLayerChromium::drawsContent):
2735         (WebCore::PluginLayerChromium::layerTypeAsString):
2736         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
2737         (WebCore::RenderSurfaceChromium::name):
2738         (WebCore::writeIndent):
2739         (WebCore::RenderSurfaceChromium::dumpSurface):
2740         * platform/graphics/chromium/RenderSurfaceChromium.h:
2741         * platform/graphics/chromium/VideoLayerChromium.h:
2742         (WebCore::VideoLayerChromium::drawsContent):
2743         (WebCore::VideoLayerChromium::layerTypeAsString):
2744         * platform/graphics/chromium/WebGLLayerChromium.h:
2745         (WebCore::WebGLLayerChromium::drawsContent):
2746         (WebCore::WebGLLayerChromium::layerTypeAsString):
2747         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
2748         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
2749         (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
2750         (WebCore::CCHeadsUpDisplay::draw):
2751         (WebCore::CCHeadsUpDisplay::drawHudContents):
2752         (WebCore::CCHeadsUpDisplay::onPresent):
2753         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
2754         (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
2755         (WebCore::CCHeadsUpDisplay::showFPSCounter):
2756         (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
2757         (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
2758         (WebCore::CCHeadsUpDisplay::enabled):
2759         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2760         (WebCore::CCLayerImpl::CCLayerImpl):
2761         (WebCore::writeIndent):
2762         (WebCore::CCLayerImpl::dumpLayerProperties):
2763         * platform/graphics/chromium/cc/CCLayerImpl.h:
2764         (WebCore::CCLayerImpl::debugID):
2765         (WebCore::CCLayerImpl::setName):
2766         (WebCore::CCLayerImpl::name):
2767
2768 2011-03-02  Ojan Vafai  <ojan@chromium.org>
2769
2770         Reviewed by Darin Adler.
2771
2772         crash in adoptNode with mutation events
2773         https://bugs.webkit.org/show_bug.cgi?id=50046
2774
2775         If the DOM is modified during the removeChild call in adoptNode,
2776         then the setDocument call that follows can leave the DOM in an
2777         inconsistent state.
2778
2779         * dom/Document.cpp:
2780         (WebCore::Document::adoptNode):
2781
2782 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
2783
2784         Reviewed by Darin Adler.
2785
2786         Add audio tag tests to the media controls manual test suite.
2787         https://bugs.webkit.org/show_bug.cgi?id=55722
2788
2789         * manual-tests/media-controls.html: Added 4 audio tests.
2790
2791 2011-03-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2792
2793         Reviewed by Eric Seidel.
2794
2795         [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
2796         https://bugs.webkit.org/show_bug.cgi?id=54392
2797
2798         Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
2799         WebCore's functions should adhere WebKit coding style.
2800
2801         * platform/efl/RenderThemeEfl.cpp:
2802         (WebCore::RenderThemeEfl::themePartCacheEntryReset):
2803         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
2804         (WebCore::RenderThemeEfl::cacheThemePartNew):
2805         (WebCore::RenderThemeEfl::cacheThemePartReset):
2806         (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
2807         (WebCore::RenderThemeEfl::cacheThemePartGet):
2808         (WebCore::RenderThemeEfl::cacheThemePartFlush):
2809         (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
2810         (WebCore::RenderThemeEfl::paintThemePart):
2811         (WebCore::renderThemeEflColorClassSelectionActive):
2812         (WebCore::renderThemeEflColorClassSelectionInactive):
2813         (WebCore::renderThemeEflColorClassFocusRing):
2814         (WebCore::renderThemeEflColorClassButtonText):
2815         (WebCore::renderThemeEflColorClassComboText):
2816         (WebCore::renderThemeEflColorClassEntryText):
2817         (WebCore::renderThemeEflColorClassSearchText):
2818         (WebCore::RenderThemeEfl::applyPartDescription):
2819         (WebCore::RenderThemeEfl::applyPartDescriptions):
2820         (WebCore::RenderThemeEfl::controlSupportsTints):
2821         (WebCore::RenderThemeEfl::baselinePosition):
2822         (WebCore::RenderThemeEfl::paintSliderTrack):
2823         (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
2824         (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
2825         (WebCore::RenderThemeEfl::paintSliderThumb):
2826         (WebCore::RenderThemeEfl::adjustCheckboxStyle):
2827         (WebCore::RenderThemeEfl::paintCheckbox):
2828         (WebCore::RenderThemeEfl::adjustRadioStyle):
2829         (WebCore::RenderThemeEfl::paintRadio):
2830         (WebCore::RenderThemeEfl::adjustButtonStyle):
2831         (WebCore::RenderThemeEfl::paintButton):
2832         (WebCore::RenderThemeEfl::adjustMenuListStyle):
2833         (WebCore::RenderThemeEfl::paintMenuList):
2834         (WebCore::RenderThemeEfl::adjustTextFieldStyle):
2835         (WebCore::RenderThemeEfl::paintTextField):
2836         (WebCore::RenderThemeEfl::adjustTextAreaStyle):
2837         (WebCore::RenderThemeEfl::paintTextArea):
2838         (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
2839         (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
2840         (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
2841         (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
2842         (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
2843         (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
2844         (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
2845         (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
2846         (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
2847         (WebCore::RenderThemeEfl::paintSearchField):
2848         (WebCore::RenderThemeEfl::adjustProgressBarStyle):
2849         (WebCore::RenderThemeEfl::paintProgressBar):
2850         (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
2851         (WebCore::RenderThemeEfl::paintMediaMuteButton):
2852         (WebCore::RenderThemeEfl::paintMediaPlayButton):
2853         (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
2854         (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
2855         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
2856         (WebCore::RenderThemeEfl::paintMediaSliderThumb):
2857         (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
2858         (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
2859         (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
2860         (WebCore::RenderThemeEfl::paintMediaCurrentTime):
2861
2862 2011-03-03  Andy Estes  <aestes@apple.com>
2863
2864         Reviewed by Adam Barth.
2865
2866         Assertion failure in toElement(WebCore::Node*)
2867         https://bugs.webkit.org/show_bug.cgi?id=55697
2868
2869         Test: fast/parser/fragment-foreign-content.html
2870
2871         * html/parser/HTMLTreeBuilder.cpp:
2872         (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
2873         element in the HTMLElementStack might be a DocumentFragment if a
2874         fragment is being parsed who's first node is foreign content.
2875
2876 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2877
2878         Reviewed by Kenneth Rohde Christiansen.
2879
2880         [QT] Implement mock client-based geolocation for layout testing
2881         https://bugs.webkit.org/show_bug.cgi?id=54334
2882
2883         Implements client() to GeolocationController to re-use geolocationClientMock class
2884         for layout testing purpose.
2885
2886         * page/GeolocationController.h:
2887         (WebCore::GeolocationController::client):
2888
2889 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2890
2891         Reviewed by Kent Tamura.
2892
2893         Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
2894         https://bugs.webkit.org/show_bug.cgi?id=55352
2895
2896         Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:
2897
2898         * editing/CompositeEditCommand.cpp:
2899         (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and
2900         no longer calls deprecated functions.
2901         * editing/InsertTextCommand.cpp:
2902         (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion.
2903         Check if the text node inside a tab span before checking if the container node is a text node
2904         because the position before or after a text node can still be inside a tab span.
2905         (WebCore::InsertTextCommand::input): No longer calls deprecated functions.
2906         * editing/InsertTextCommand.h:
2907         * editing/ModifySelectionListLevel.cpp:
2908         (WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start
2909         or the end of selection could be an immediate child of a list node (e.g. br inside ul)
2910
2911 2011-03-03  Hans Wennborg  <hans@chromium.org>
2912
2913         Reviewed by Jeremy Orlow.
2914
2915         IndexedDB: Move last bits of SQL into IDBBackingStore
2916         https://bugs.webkit.org/show_bug.cgi?id=55668
2917
2918         After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
2919
2920         No new tests: refactoring only.
2921
2922         * storage/IDBBackingStore.cpp:
2923         (WebCore::IDBBackingStore::createTransaction):
2924         * storage/IDBBackingStore.h:
2925         * storage/IDBCursorBackendImpl.h:
2926         * storage/IDBDatabaseBackendImpl.cpp:
2927         (WebCore::IDBDatabaseBackendImpl::backingStore):
2928         * storage/IDBDatabaseBackendImpl.h:
2929         * storage/IDBIndexBackendImpl.h:
2930         * storage/IDBKey.h:
2931         * storage/IDBObjectStoreBackendImpl.h:
2932         * storage/IDBTransactionBackendImpl.cpp:
2933         (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
2934         * storage/IDBTransactionBackendImpl.h:
2935         * storage/IDBTransactionBackendInterface.h:
2936         * storage/IDBTransactionCoordinator.cpp:
2937
2938 2011-03-03  Adam Klein  <adamk@chromium.org>
2939
2940         Reviewed by David Levin.
2941
2942         [fileapi] Tighten up ResolveURICallbacks
2943         https://bugs.webkit.org/show_bug.cgi?id=55638
2944
2945         Two changes:
2946           - Retry only on TYPE_MISMATCH_ERR now that Chromium
2947             properly sets that error code.
2948           - Call DirectoryEntry instead of DOMFileSystem methods.
2949
2950         No change in behavior, so no new tests.
2951
2952         * fileapi/FileSystemCallbacks.cpp:
2953         (WebCore::ResolveURICallbacks::didOpenFileSystem):
2954
2955 2011-03-03  Anders Carlsson  <andersca@apple.com>
2956
2957         Reviewed by Sam Weinig.
2958
2959         Get rid of Page::globalHistoryItem
2960         https://bugs.webkit.org/show_bug.cgi?id=55738
2961
2962         The m_globalHistoryItem is only used by Mac and Windows WebKit1.
2963         Instead of having WebCore updating this member variable, just call out
2964         to a FrameLoaderClient member function and let WebKit keep it up to date.
2965
2966         * loader/EmptyClients.h:
2967         (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
2968         (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
2969         * loader/FrameLoader.cpp:
2970         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2971         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2972         * loader/FrameLoaderClient.h:
2973         (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
2974         * loader/HistoryController.cpp:
2975         (WebCore::HistoryController::goToItem):
2976         (WebCore::HistoryController::updateForStandardLoad):
2977         (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
2978         * page/Page.cpp:
2979         * page/Page.h:
2980
2981 2011-03-02  Jeremy Orlow  <jorlow@chromium.org>
2982
2983         Reviewed by Steve Block.
2984
2985         Cursor.continue with a key param should test less than, not equal to
2986         https://bugs.webkit.org/show_bug.cgi?id=55640
2987
2988         If you supply a param to cursor.continue, we sould guarantee that
2989         the item we continue to is greater than or equal to the parameter.
2990         Right now, we only test equality.
2991
2992         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
2993         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor
2994
2995         Test: storage/indexeddb/cursor-continue.html
2996
2997         * storage/IDBCursorBackendImpl.cpp:
2998         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
2999         * storage/IDBKey.cpp:
3000         (WebCore::IDBKey::isLessThan):
3001         (WebCore::IDBKey::isEqual):
3002         * storage/IDBKey.h:
3003
3004 2011-03-03  Brent Fulgham  <bfulgham@webkit.org>
3005
3006         Build fix. Need win/cURL DownloadBundle stub.
3007
3008         * platform/network/curl/DownloadBundle.h: Added.
3009
3010 2011-03-03  Geoffrey Garen  <ggaren@apple.com>
3011
3012         Rolled out 80277 and 80280 because they caused event handler layout test
3013         failures.
3014
3015         * WebCore.xcodeproj/project.pbxproj:
3016         * bindings/js/JSDOMGlobalObject.cpp:
3017         * bindings/js/JSDOMGlobalObject.h:
3018         * bindings/js/JSDOMWindowBase.cpp:
3019         * bindings/js/JSDOMWindowBase.h:
3020         * bindings/js/JSDOMWindowCustom.h:
3021         * bindings/js/JSWorkerContextBase.cpp:
3022
3023 2011-03-03  Brady Eidson  <beidson@apple.com>
3024
3025         Reviewed by Darin Adler.
3026
3027         https://bugs.webkit.org/show_bug.cgi?id=55721
3028         Global IconDatabase should be returned by reference, not as a pointer
3029
3030         * history/HistoryItem.cpp:
3031         (WebCore::HistoryItem::HistoryItem):
3032         (WebCore::HistoryItem::~HistoryItem):
3033         (WebCore::HistoryItem::reset):
3034         (WebCore::HistoryItem::icon):
3035         (WebCore::HistoryItem::setURLString):
3036
3037         * loader/FrameLoader.cpp:
3038         (WebCore::FrameLoader::startIconLoader):
3039         (WebCore::FrameLoader::commitIconURLToIconDatabase):
3040
3041         * loader/archive/cf/LegacyWebArchive.cpp:
3042         (WebCore::LegacyWebArchive::create):
3043
3044         * loader/icon/IconDatabase.cpp:
3045         (WebCore::iconDatabase):
3046         * loader/icon/IconDatabase.h:
3047         * loader/icon/IconDatabaseNone.cpp:
3048         (WebCore::iconDatabase):
3049         * loader/icon/wince/IconDatabaseWinCE.cpp:
3050         (WebCore::iconDatabase):
3051
3052         * loader/icon/IconLoader.cpp:
3053         (WebCore::IconLoader::finishLoading):
3054
3055 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
3056
3057         Reviewed by Martin Robinson.
3058
3059         Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
3060         https://bugs.webkit.org/show_bug.cgi?id=52742
3061
3062         Use firstPositionInOrBeforeNode to instantiate appropriate position.
3063
3064         * page/FocusController.cpp:
3065         (WebCore::FocusController::advanceFocusInDocumentOrder):
3066
3067 2011-03-03  Andy Estes  <aestes@apple.com>
3068
3069         Reviewed by Darin Adler.
3070
3071         When displaying the missing plug-in sheet, pass the 'pluginspage'
3072         attribute to the UI process.
3073         https://bugs.webkit.org/show_bug.cgi?id=55553
3074
3075         * WebCore.exp.in: Export __ZN7WebCore9HTMLNames15pluginspageAttrE.
3076         * html/HTMLAttributeNames.in: Add 'pluginspage' as a known content
3077         attribute.
3078
3079 2011-03-03  Jessie Berlin  <jberlin@apple.com>
3080
3081         Reviewed by Adam Roben.
3082
3083         WebKit2: Use CFNetwork Sessions API.
3084         https://bugs.webkit.org/show_bug.cgi?id=55435
3085
3086         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
3087
3088         * WebCore.exp.in:
3089         Support using WKCopyRequestWithStorageSession in WebCore.
3090         * platform/mac/WebCoreSystemInterface.h:
3091         Ditto.
3092         * platform/mac/WebCoreSystemInterface.mm:
3093         Ditto.
3094
3095         * platform/network/cf/ResourceHandleCFNet.cpp:
3096         (WebCore::makeFinalRequest):
3097         If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
3098         (WebCore::ResourceHandle::willSendRequest):
3099         Ditto.
3100         * platform/network/mac/ResourceHandleMac.mm:
3101         (WebCore::ResourceHandle::createNSURLConnection):
3102         Ditto.
3103         (WebCore::ResourceHandle::willSendRequest):
3104         Ditto.
3105
3106         * platform/network/cf/ResourceRequest.h:
3107         * platform/network/cf/ResourceRequestCFNet.cpp:
3108         (WebCore::ResourceRequest::setStorageSession):
3109         Call through to WKSI.
3110         * platform/network/mac/ResourceRequestMac.mm:
3111         (WebCore::ResourceRequest::setStorageSession):
3112         Ditto.
3113
3114 2011-03-03  Chris Marrin  <cmarrin@apple.com>
3115
3116         Reviewed by Simon Fraser.
3117
3118         REGRESSION: Accelerated transitions are jumpy
3119         https://bugs.webkit.org/show_bug.cgi?id=55022
3120
3121         Changed the way default TimingFunction is stored according to Adam Roben's
3122         suggestion.
3123
3124         * platform/animation/TimingFunction.h:
3125         (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
3126
3127 2011-03-03  Dan Bernstein  <mitz@apple.com>
3128
3129         Reviewed by Sam Weinig.
3130
3131         Rename -webkit-hyphenate-locale to -webkit-locale
3132         https://bugs.webkit.org/show_bug.cgi?id=55709
3133
3134         * css/CSSComputedStyleDeclaration.cpp:
3135         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3136         * css/CSSParser.cpp:
3137         (WebCore::CSSParser::parseValue):
3138         (WebCore::cssPropertyID):
3139         * css/CSSPropertyNames.in:
3140         * css/CSSStyleSelector.cpp:
3141         (WebCore::CSSStyleSelector::applyProperty):
3142         * rendering/RenderBlockLineLayout.cpp:
3143         (WebCore::RenderBlock::findNextLineBreak):
3144         * rendering/style/RenderStyle.cpp:
3145         (WebCore::RenderStyle::diff):
3146         * rendering/style/RenderStyle.h:
3147         (WebCore::InheritedFlags::locale):
3148         (WebCore::InheritedFlags::setLocale):
3149         (WebCore::InheritedFlags::initialLocale):
3150         * rendering/style/StyleRareInheritedData.cpp:
3151         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3152         (WebCore::StyleRareInheritedData::operator==):
3153         * rendering/style/StyleRareInheritedData.h:
3154
3155 2011-03-03  Kevin Ollivier  <kevino@theolliviers.com>
3156
3157         [wx] Build fixes. Use Font::textMetrics to get ascent value, and add missing include.
3158
3159         * platform/wx/DragDataWx.cpp:
3160         * platform/wx/wxcode/win/non-kerned-drawing.cpp:
3161         (WebCore::drawTextWithSpacing):
3162
3163 2011-03-03  Oliver Hunt  <oliver@apple.com>
3164
3165         Reviewed by Geoffrey Garen.
3166
3167         JSVariableObject needs to use WriteBarrier for symboltable property storage
3168         https://bugs.webkit.org/show_bug.cgi?id=55698
3169
3170         Update to pass JSGlobalData for the symbol table write used
3171         to set the document property.
3172
3173         * bindings/js/JSDOMWindowBase.cpp:
3174         (WebCore::JSDOMWindowBase::updateDocument):
3175
3176 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
3177
3178         More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.
3179
3180         * WebCore.xcodeproj/project.pbxproj:
3181         * page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
3182         * page/mac/WebCoreKeyboardUIMode.h: Removed.
3183
3184 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
3185
3186         Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
3187
3188         * page/ChromeClient.h:
3189
3190 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
3191
3192         Reviewed by Darin Adler.
3193
3194         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
3195         https://bugs.webkit.org/show_bug.cgi?id=55633
3196         <rdar://problem/8963023>
3197
3198         * loader/EmptyClients.h: (WebCore::EmptyChromeClient::keyboardUIMode):
3199         * page/ChromeClient.h:
3200         * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks):
3201         Merged tabsToLinks() and keyboardUIMode(). The latter returned a superset of information
3202         returned by former.
3203
3204 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
3205
3206         Fix Win compile break, caused by r80276.
3207
3208         * rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton
3209             to match RenderTheme.h.
3210
3211 2011-03-02  Geoffrey Garen  <ggaren@apple.com>
3212
3213         Reviewed by Darin Adler.
3214
3215         Moved all variable object storage inline -- upping the object size limit to 1K
3216         https://bugs.webkit.org/show_bug.cgi?id=55653
3217
3218         * bindings/js/JSDOMGlobalObject.cpp:
3219         * bindings/js/JSDOMGlobalObject.h:
3220         * bindings/js/JSDOMWindowBase.cpp:
3221         * bindings/js/JSDOMWindowBase.h:
3222         * bindings/js/JSDOMWindowCustom.h:
3223         * bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
3224
3225 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
3226
3227         Reviewed by Darin Adler.
3228
3229         Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
3230         https://bugs.webkit.org/show_bug.cgi?id=55099
3231
3232         Cleanup, no behavior change.
3233
3234         * html/shadow/MediaControls.cpp:
3235         (WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox
3236             instead of Node.
3237         * rendering/RenderMediaControls.cpp:
3238         (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed
3239             to use RenderBox as argument.
3240         * rendering/RenderMediaControls.h: Ditto.
3241         * rendering/RenderTheme.cpp:
3242         (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
3243         * rendering/RenderTheme.h: Ditto.
3244         * rendering/RenderThemeChromiumMac.h: Ditto.
3245         * rendering/RenderThemeChromiumMac.mm:
3246         (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
3247         * rendering/RenderThemeMac.h: Ditto.
3248         * rendering/RenderThemeMac.mm:
3249         (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
3250         * rendering/RenderThemeWin.cpp:
3251         (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
3252
3253 2011-03-03  Alexis Menard  <alexis.menard@openbossa.org>
3254
3255         Reviewed by Andreas Kling.
3256
3257         When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
3258         Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
3259         for GstElement.
3260
3261         * WebCore.pro:
3262         * features.pri:
3263
3264 2011-03-03  Anders Carlsson  <andersca@apple.com>
3265
3266         Try to fix the Windows build again.
3267
3268         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3269         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3270
3271 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3272
3273         Reviewed by Dimitri Glazkov.
3274
3275         Add another CRASH() for CSSSelector double frees
3276         https://bugs.webkit.org/show_bug.cgi?id=55693
3277
3278         To help track down bug 53045, add a CRASH call when the the array and/or
3279         CSSSelector member in CSSSelectorList is disposed of more than once.
3280
3281         Just a check, no new tests necessary.
3282         
3283         * css/CSSSelectorList.cpp:
3284         (WebCore::CSSSelectorList::deleteSelectors):
3285
3286 2011-03-03  Anders Carlsson  <andersca@apple.com>
3287
3288         Yet another attempt at fixing the Windows build.
3289
3290         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
3291         * platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
3292         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
3293         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3294
3295 2011-03-02  Chris Marrin  <cmarrin@apple.com>
3296
3297         Reviewed by Simon Fraser.
3298
3299         REGRESSION: Accelerated transitions are jumpy
3300         https://bugs.webkit.org/show_bug.cgi?id=55022
3301
3302         Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
3303         is now always passed in. The TimingFunction class now has a static method to get
3304         a default object which has the 'ease' values in it. I now assert in both Mac and
3305         Win implementations if a null TimingFunction pointer is seen.
3306
3307         * platform/animation/TimingFunction.h:
3308         (WebCore::CubicBezierTimingFunction::create):
3309         (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
3310         (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
3311         * platform/graphics/ca/GraphicsLayerCA.cpp:
3312         (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
3313         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
3314         (toCAMediaTimingFunction):
3315         * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
3316         (toCACFTimingFunction):
3317
3318 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3319
3320         Unreviewed build fix.
3321
3322         Fix clang compile after r80220
3323         https://bugs.webkit.org/show_bug.cgi?id=55692
3324
3325         * storage/IDBBackingStore.cpp:
3326         (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
3327
3328 2011-03-03  Anders Carlsson  <andersca@apple.com>
3329
3330         Attempt to fix the Windows build.
3331
3332         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3333         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3334
3335 2011-03-02  Brian Weinstein  <bweinstein@apple.com>
3336
3337         Reviewed by Adam Roben.
3338
3339         Rest of WebKit2: Need a way to send notifications to client when cookies change
3340         https://bugs.webkit.org/show_bug.cgi?id=55427
3341         <rdar://problem/9056027>
3342
3343         Add functions to be exported.
3344
3345         * WebCore.exp.in:
3346
3347 2011-03-03  Anders Carlsson  <andersca@apple.com>
3348
3349         Reviewed by Darin Adler.
3350
3351         Improve WebCore build time by ~5%
3352         https://bugs.webkit.org/show_bug.cgi?id=55688
3353
3354         Forward declare the CATransform3D and CGAffineTransform structs instead of including
3355         large chunks of QuartzCore and Core Graphics.
3356
3357         On an 8 core Mac Pro, this sped up building WebCore by about 5%.
3358
3359         * platform/graphics/ca/GraphicsLayerCA.cpp:
3360         * platform/graphics/ca/TransformationMatrixCA.cpp:
3361         * platform/graphics/transforms/TransformationMatrix.h:
3362
3363 2011-03-03  Andrey Kosyakov  <caseq@chromium.org>
3364
3365         Unreviewed. Adjusted call to a method renamed in r80102.
3366
3367         * inspector/front-end/SourceFrame.js:
3368         (WebInspector.SourceFrame.prototype._startEditing):
3369
3370 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3371
3372         Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
3373         by contexts not created by WebCore.
3374
3375         https://webkit.org/b/55642
3376
3377         Reviewed by Oliver Hunt.
3378
3379         * bindings/js/SerializedScriptValue.cpp:
3380         (WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
3381         (WebCore::SerializedScriptValue::deserialize): Ditto.
3382
3383 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
3384
3385         Reviewed by Darin Adler.
3386
3387         WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
3388         https://bugs.webkit.org/show_bug.cgi?id=55498
3389         <rdar://problem/8752706>
3390
3391         Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
3392                http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
3393
3394         * websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response
3395         header fields. Removed separate member variables for those, as they were duplicating data
3396         available in response, and there is no reason to squeeze microsecods here.
3397
3398         * websockets/WebSocketHandshake.cpp:
3399         (WebCore::WebSocketHandshake::reset): There are no longer member variables for header field
3400         values to reset here.
3401         (WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders().
3402         (WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
3403         (WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
3404         (WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
3405         (WebCore::WebSocketHandshake::serverSetCookie): Ditto.
3406         (WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
3407         (WebCore::WebSocketHandshake::serverUpgrade): Added.
3408         (WebCore::WebSocketHandshake::serverConnection): Added.
3409         (WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection
3410         header field presence and values.
3411
3412 2011-03-03  Helder Correia  <helder@sencha.com>
3413
3414         Reviewed by Andreas Kling.
3415
3416         [Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
3417         https://bugs.webkit.org/show_bug.cgi?id=55651
3418
3419         When relying on ContextShadow and using a gradient stroke for a path,
3420         the alpha of the shadow is incorrect.
3421
3422         * platform/graphics/qt/GraphicsContextQt.cpp:
3423         (WebCore::GraphicsContext::strokePath):
3424
3425 2011-03-03  Martin Robinson  <mrobinson@igalia.com>
3426
3427         XHTMLMP build broken after r78342
3428         https://bugs.webkit.org/show_bug.cgi?id=55286
3429
3430         Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
3431         instead of FrameLoader.
3432
3433         No new tests. This is a build fix.
3434
3435         * dom/Document.cpp:
3436         (WebCore::Document::isXHTMLMPDocument):
3437
3438 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
3439
3440         Reviewed by Eric Carlson.
3441
3442         Tweak MediaControlMuteButtonElement class hierarchy.
3443         https://bugs.webkit.org/show_bug.cgi?id=55614
3444
3445         This allows the mute button on the panel to have event handlers that are
3446         different from the mute button in the volume slider.
3447
3448         No change in behavior, covered by existing tests.
3449
3450         * html/shadow/MediaControls.cpp:
3451         (WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
3452         * rendering/MediaControlElements.cpp:
3453         (WebCore::MediaControlMuteButtonElement::updateDisplayType):
3454         (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added.
3455         (WebCore::MediaControlPanelMuteButtonElement::create): Added.
3456         (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
3457         * rendering/MediaControlElements.h: Added defs.
3458
3459 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
3460
3461         Reviewed by Pavel Feldman.
3462
3463         Web Inspector: Resource agent should have same lifetime as Inspector agent
3464         https://bugs.webkit.org/show_bug.cgi?id=55461
3465
3466         * inspector/Inspector.idl:
3467         * inspector/InspectorAgent.cpp:
3468         (WebCore::InspectorAgent::InspectorAgent):
3469         (WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed
3470         to clear frontend reference in all agents.
3471         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3472         (WebCore::InspectorAgent::setFrontend):
3473         (WebCore::InspectorAgent::disconnectFrontend):
3474         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
3475         (WebCore::InspectorAgent::didCommitLoad):
3476         * inspector/InspectorAgent.h:
3477         (WebCore::InspectorAgent::resourceAgent):
3478         * inspector/InspectorBrowserDebuggerAgent.cpp:
3479         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
3480         * inspector/InspectorDebuggerAgent.cpp:
3481         (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
3482         * inspector/InspectorInstrumentation.cpp:
3483         (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
3484         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
3485         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
3486         (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
3487         (WebCore::InspectorInstrumentation::retrieveResourceAgent):
3488         * inspector/InspectorResourceAgent.cpp:
3489         (WebCore::InspectorResourceAgent::setFrontend):
3490         (WebCore::InspectorResourceAgent::clearFrontend):
3491         (WebCore::InspectorResourceAgent::restore):
3492         (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
3493         (WebCore::InspectorResourceAgent::enable):
3494         (WebCore::InspectorResourceAgent::disable):
3495         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
3496         * inspector/InspectorResourceAgent.h:
3497         (WebCore::InspectorResourceAgent::create):
3498         * inspector/InspectorTimelineAgent.cpp:
3499         (WebCore::InspectorTimelineAgent::restore):
3500         * inspector/InspectorTimelineAgent.h:
3501         * inspector/front-end/NetworkManager.js:
3502         (WebInspector.NetworkManager):
3503         (WebInspector.NetworkManager.prototype.frontendReused):
3504         * inspector/front-end/inspector.js:
3505         (WebInspector.frontendReused):
3506
3507 2011-03-03  Andras Becsi  <abecsi@webkit.org>
3508
3509         Reviewed by Andreas Kling.
3510
3511         CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
3512         https://bugs.webkit.org/show_bug.cgi?id=55661
3513
3514         Test case originally written by Andreas Kling <andreas.kling@nokia.com>
3515
3516         Test: fast/canvas/rgba-parsing.html
3517
3518         * css/CSSParser.cpp:
3519         (WebCore::isValidDouble): Check whether the given string is a valid double.
3520         (WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
3521
3522 2011-03-03  David Holloway  <dhollowa@chromium.org>
3523
3524         Reviewed by Dimitri Glazkov.
3525
3526         Changes HTMLTextFormControlElement::placeholderShouldBeVisible to account
3527         for non-empty suggestion text.  The visibility of the placeholder text
3528         now turned off when suggestion text is set.
3529         https://bugs.webkit.org/show_bug.cgi?id=55245
3530
3531         No new tests because, by design, the suggestion text is not accessible
3532         through the DOM.
3533
3534         * html/HTMLFormControlElement.cpp:
3535         (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
3536         * html/HTMLFormControlElement.h:
3537         (WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
3538         * html/HTMLInputElement.h:
3539         (WebCore::HTMLInputElement::isEmptySuggestedValue):
3540
3541 2011-03-03  Andy Estes  <aestes@apple.com>
3542
3543         Reviewed by Eric Seidel.
3544
3545         HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
3546         https://bugs.webkit.org/show_bug.cgi?id=48719
3547         
3548         Instead of pushing a fake HTMLHtmlElement onto the open element stack
3549         during fragment parsing only to later remove it and reparent its
3550         children to the DocumentFragment, push the DocumentFragment directly
3551         onto the open element stack as the root node. This requires refactoring
3552         HTMLElementStack to hold ContainerNode pointers rather than Element
3553         pointers, which has implications for HTMLConstructionSite and
3554         HTMLTreeBuilder as well.
3555         
3556         With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
3557         is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
3558         test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
3559         regression no longer lies in fragment parsing.
3560
3561         No new tests. No change in behavior.
3562
3563         * dom/Element.h:
3564         (WebCore::Node::hasLocalName):
3565         * dom/Node.h:
3566         * html/parser/HTMLConstructionSite.cpp:
3567         (WebCore::HTMLNames::hasImpliedEndTag):
3568         (WebCore::HTMLConstructionSite::HTMLConstructionSite):
3569         (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
3570         (WebCore::HTMLConstructionSite::insertComment):
3571         (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
3572         (WebCore::HTMLConstructionSite::attachToCurrent):
3573         (WebCore::HTMLConstructionSite::insertScriptElement):
3574         (WebCore::HTMLConstructionSite::insertTextNode):
3575         (WebCore::HTMLConstructionSite::createElement):
3576         (WebCore::HTMLConstructionSite::createHTMLElement):
3577         (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
3578         (WebCore::HTMLConstructionSite::generateImpliedEndTags):
3579         (WebCore::HTMLConstructionSite::findFosterSite):
3580         (WebCore::HTMLConstructionSite::shouldFosterParent):
3581         * html/parser/HTMLConstructionSite.h:
3582         (WebCore::HTMLConstructionSite::currentNode):
3583         * html/parser/HTMLElementStack.cpp:
3584         (WebCore::HTMLNames::isNumberedHeaderElement):
3585         (WebCore::HTMLNames::isScopeMarker):
3586         (WebCore::HTMLNames::isListItemScopeMarker):
3587         (WebCore::HTMLNames::isTableScopeMarker):
3588         (WebCore::HTMLNames::isTableBodyScopeMarker):
3589         (WebCore::HTMLNames::isTableRowScopeMarker):
3590         (WebCore::HTMLNames::isButtonScopeMarker):
3591         (WebCore::HTMLNames::isSelectScopeMarker):
3592         (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
3593         (WebCore::HTMLElementStack::ElementRecord::replaceElement):
3594         (WebCore::HTMLElementStack::HTMLElementStack):
3595         (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
3596         (WebCore::HTMLElementStack::popAll):
3597         (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
3598         (WebCore::HTMLElementStack::popUntil):
3599         (WebCore::HTMLElementStack::popUntilPopped):
3600         (WebCore::HTMLElementStack::popUntilTableScopeMarker):
3601         (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
3602         (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
3603         (WebCore::HTMLElementStack::pushHTMLHtmlElement):
3604         (WebCore::HTMLElementStack::push):
3605         (WebCore::HTMLElementStack::insertAbove):
3606         (WebCore::HTMLElementStack::find):
3607         (WebCore::HTMLElementStack::topmost):
3608         (WebCore::HTMLElementStack::contains):
3609         (WebCore::inScopeCommon):
3610         (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
3611         (WebCore::HTMLElementStack::htmlElement):
3612         (WebCore::HTMLElementStack::rootNode):
3613         (WebCore::HTMLElementStack::pushCommon):
3614         * html/parser/HTMLElementStack.h:
3615         (WebCore::HTMLElementStack::ElementRecord::element):
3616         (WebCore::HTMLElementStack::ElementRecord::node):
3617         (WebCore::HTMLElementStack::topNode):
3618         * html/parser/HTMLTreeBuilder.cpp:
3619         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
3620         (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
3621         (WebCore::HTMLTreeBuilder::processStartTagForInBody):
3622         (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
3623         (WebCore::HTMLTreeBuilder::processStartTag):
3624         (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
3625         (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
3626         (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
3627         (WebCore::HTMLTreeBuilder::processEndTagForInCell):
3628         (WebCore::HTMLTreeBuilder::processEndTagForInBody):
3629         (WebCore::HTMLTreeBuilder::processEndTag):
3630         (WebCore::HTMLTreeBuilder::processEndOfFile):
3631         (WebCore::HTMLTreeBuilder::finished):
3632         * html/parser/HTMLTreeBuilder.h:
3633
3634 2011-03-02  Yury Semikhatsky  <yurys@chromium.org>
3635
3636         Reviewed by Pavel Feldman.
3637
3638         Web Inspector: inspector protocol should allow different domains to have methods with same name
3639         https://bugs.webkit.org/show_bug.cgi?id=55558
3640
3641         * inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
3642
3643 2011-03-02  Pavel Podivilov  <podivilov@chromium.org>
3644
3645         Reviewed by Yury Semikhatsky.
3646
3647         Web Inspector: make selected call frame debugger presentation model property.
3648         https://bugs.webkit.org/show_bug.cgi?id=55582
3649
3650         * inspector/front-end/CallStackSidebarPane.js:
3651         (WebInspector.CallStackSidebarPane):
3652         (WebInspector.CallStackSidebarPane.prototype.update):
3653         (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
3654         (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
3655         * inspector/front-end/ConsoleView.js:
3656         (WebInspector.ConsoleView.prototype.completions):
3657         * inspector/front-end/DebuggerPresentationModel.js:
3658         (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
3659         (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
3660         * inspector/front-end/ScriptsPanel.js:
3661         (WebInspector.ScriptsPanel):
3662         (WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame):
3663         (WebInspector.ScriptsPanel.prototype._debuggerResumed):
3664         (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
3665         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
3666
3667 2011-03-03  Jia Pu  <jpu@apple.com>
3668
3669         Reviewed by Darin Adler.
3670
3671         On Mac OS X, spelling suggestion panel stops showing up after change set 80121
3672         https://bugs.webkit.org/show_bug.cgi?id=55628
3673
3674         Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.
3675
3676         * editing/Editor.cpp:
3677         (WebCore::Editor::appliedEditing):
3678         * manual-tests/autocorrection/autocorrection-contraction.html:
3679
3680 2011-03-03  Pavel Podivilov  <podivilov@chromium.org>
3681
3682         Reviewed by Pavel Feldman.
3683
3684         Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
3685         https://bugs.webkit.org/show_bug.cgi?id=55569
3686
3687         sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.
3688
3689         * inspector/front-end/DebuggerPresentationModel.js:
3690         * inspector/front-end/ScriptsPanel.js:
3691
3692 2011-03-03  Steve Block  <steveblock@google.com>
3693
3694         Reviewed by David Levin.
3695
3696         JavaString API should be implementable by both JSC and V8
3697         https://bugs.webkit.org/show_bug.cgi?id=55567
3698
3699         Remove JavaString's UString operator and replace it with a
3700         script-engine-independent impl() method, which returns a
3701         StringImpl and can be implemented with both JSC and V8.
3702
3703         No new tests, refactoring only. 
3704
3705         * bridge/jni/JNIBridge.h:
3706         (JSC::Bindings::JavaString::impl):
3707         * bridge/jni/jni_jsobject.mm:
3708         (JavaJSObject::call):
3709         (JavaJSObject::eval):
3710         (JavaJSObject::getMember):
3711         (JavaJSObject::setMember):
3712         (JavaJSObject::removeMember):
3713         * bridge/jni/jsc/JNIBridgeJSC.cpp:
3714         (JavaField::valueFromInstance):
3715         (JavaField::setValueToInstance):
3716         * bridge/jni/jsc/JavaClassJSC.cpp:
3717         (JavaClass::JavaClass):
3718         * bridge/jni/jsc/JavaInstanceJSC.cpp:
3719         (JavaInstance::invokeMethod):
3720         * bridge/jni/jsc/JavaStringJSC.h:
3721         (JSC::Bindings::JavaStringImpl::impl):
3722         * bridge/jni/v8/JavaStringV8.h:
3723         (JSC::Bindings::JavaStringImpl::impl):
3724
3725 2011-03-03  Benjamin Poulain  <ikipou@gmail.com>
3726
3727         Reviewed by Adam Roben.
3728
3729         REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
3730         https://bugs.webkit.org/show_bug.cgi?id=55602
3731
3732         Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.
3733
3734         The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
3735         objects need to be deleted manually with ListHashSet.
3736
3737         * rendering/RenderBlock.cpp:
3738         (WebCore::RenderBlock::clearFloats):
3739
3740 2011-03-03  Hans Wennborg  <hans@chromium.org>
3741
3742         Reviewed by Jeremy Orlow.
3743
3744         IndexedDB: Move SQL code, especially for cursors, to IDBBackingStore
3745         https://bugs.webkit.org/show_bug.cgi?id=55376
3746
3747         Move SQL code from IDBKey, IDBKeyRange, IDBIndexBackendImpl,
3748         IDBObjectStoreBackendImpl, and especially IDBCursorBackendImpl.
3749
3750         No new functionality, so no new tests.
3751
3752         * storage/IDBBackingStore.cpp:
3753         (WebCore::lowerCursorWhereFragment):
3754         (WebCore::upperCursorWhereFragment):
3755         (WebCore::IDBBackingStore::deleteObjectStoreRecord):
3756         (WebCore::IDBBackingStore::keyExistsInObjectStore):
3757         (WebCore::IDBBackingStore::getObjectViaIndex):
3758         (WebCore::keyFromQuery):
3759         (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
3760         (WebCore::IDBBackingStore::keyExistsInIndex):
3761         (WebCore::CursorImplCommon::CursorImplCommon::continueInternal):
3762         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
3763         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::objectStoreDataId):
3764         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::key):
3765         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::value):
3766         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::continueFunction):
3767         (WebCore::IDBBackingStore::openObjectStoreCursor):
3768         (WebCore::ObjectStoreCursorImpl::loadCurrentRow):
3769         (WebCore::ObjectStoreCursorImpl::currentRowExists):
3770         (WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
3771         (WebCore::IndexKeyCursorImpl::indexDataId):
3772         (WebCore::IndexKeyCursorImpl::key):
3773         (WebCore::IndexKeyCursorImpl::primaryKey):
3774         (WebCore::IndexKeyCursorImpl::continueFunction):
3775         (WebCore::IDBBackingStore::openIndexKeyCursor):
3776         (WebCore::IndexKeyCursorImpl::loadCurrentRow):
3777         (WebCore::IndexKeyCursorImpl::currentRowExists):
3778         (WebCore::IndexCursorImpl::IndexCursorImpl):
3779         (WebCore::IndexCursorImpl::indexDataId):
3780         (WebCore::IndexCursorImpl::key):
3781         (WebCore::IndexCursorImpl::primaryKey):
3782         (WebCore::IndexCursorImpl::value):
3783         (WebCore::IndexCursorImpl::continueFunction):
3784         (WebCore::IDBBackingStore::openIndexCursor):
3785         (WebCore::IndexCursorImpl::loadCurrentRow):
3786         (WebCore::IndexCursorImpl::currentRowExists):
3787         * storage/IDBBackingStore.h:
3788         (WebCore::IDBBackingStore::Cursor::~Cursor):
3789         * storage/IDBCursorBackendImpl.cpp:
3790         (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
3791         (WebCore::IDBCursorBackendImpl::key):
3792         (WebCore::IDBCursorBackendImpl::value):
3793         (WebCore::IDBCursorBackendImpl::update):
3794         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
3795         (WebCore::IDBCursorBackendImpl::deleteFunction):
3796         * storage/IDBCursorBackendImpl.h:
3797         (WebCore::IDBCursorBackendImpl::create):
3798         * storage/IDBIndexBackendImpl.cpp:
3799         (WebCore::IDBIndexBackendImpl::openCursorInternal):
3800         (WebCore::IDBIndexBackendImpl::getInternal):
3801         (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
3802         * storage/IDBIndexBackendImpl.h:
3803         * storage/IDBKey.cpp:
3804         (WebCore::IDBKey::isEqual):
3805         * storage/IDBKey.h:
3806         * storage/IDBKeyRange.cpp:
3807         * storage/IDBKeyRange.h:
3808         * storage/IDBObjectStoreBackendImpl.cpp:
3809         (WebCore::IDBObjectStoreBackendImpl::putInternal):
3810         (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
3811         (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
3812         * storage/IDBObjectStoreBackendImpl.h:
3813
3814 2011-03-03  Peter Kasting  <pkasting@google.com>
3815
3816         Reviewed by James Robinson.
3817
3818         Drop redundant "Windows; " from the Windows-specific User Agent string.
3819         https://bugs.webkit.org/show_bug.cgi?id=54567
3820
3821         * StringsNotToBeLocalized.txt:
3822
3823 2011-03-03  Mario Sanchez Prada  <msanchez@igalia.com>
3824
3825         Reviewed by Martin Robinson.
3826
3827         [GTK] Combo boxes should emit object:selection-changed even when collapsed
3828         https://bugs.webkit.org/show_bug.cgi?id=53146
3829
3830         Emit the selection-changed signals when the menu list value has changed
3831
3832         Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
3833
3834         * accessibility/gtk/AXObjectCacheAtk.cpp:
3835         (WebCore::getListObject): New, return the right list object for
3836         menu lists and list boxes.
3837         (WebCore::notifyChildrenSelectionChange): Support menu lists.
3838         (WebCore::AXObjectCache::postPlatformNotification): Call function
3839         notifyChildrenSelectionChange for AXMenuListValueChanged.
3840
3841 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
3842
3843         Reviewed by Tony Chang.
3844
3845         applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
3846         https://bugs.webkit.org/show_bug.cgi?id=55338
3847
3848         Include wtf/Forward.h instead of wtf/text/String.h
3849
3850         * editing/EditingStyle.h:
3851
3852 2011-03-03  Csaba Osztrogon√°c  <ossy@webkit.org>
3853
3854         Unreviewed trivial fix after r80169.
3855
3856         [Qt][WK2] Memory exhausted when building qtwebkit2 on linux
3857         https://bugs.webkit.org/show_bug.cgi?id=55484
3858
3859         * WebCore.pro: Typo fix. We have to use linux-g++* instead of linux-g++.
3860
3861
3862 2011-03-02  MORITA Hajime  <morrita@google.com>
3863
3864         Reviewed by Kent Tamura.
3865
3866         [Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleAction
3867         https://bugs.webkit.org/show_bug.cgi?id=54440
3868
3869         - Extracted FrameActionScheduler from FrameView
3870         - Extracted FrameAction abstract class from ScheduledEvent,
3871           which has fire() virtual method.
3872         - Renamed ScheduledEvent EventFrameAction
3873         
3874         With this change, Any action can be hooked up to the end of the layout.
3875         
3876         No new tests. No behavioral change.
3877
3878         * Android.mk:
3879         * CMakeLists.txt:
3880         * GNUmakefile.am:
3881         * WebCore.gypi:
3882         * WebCore.pro:
3883         * WebCore.vcproj/WebCore.vcproj:
3884         * WebCore.xcodeproj/project.pbxproj:
3885         * page/FrameActionScheduler.cpp: Added.
3886         (WebCore::EventFrameAction::EventFrameAction):
3887         (WebCore::EventFrameAction::fire):
3888         (WebCore::FrameActionScheduler::FrameActionScheduler):
3889         (WebCore::FrameActionScheduler::~FrameActionScheduler):
3890         (WebCore::FrameActionScheduler::isEmpty):
3891         (WebCore::FrameActionScheduler::clear):
3892         (WebCore::FrameActionScheduler::pause):
3893         (WebCore::FrameActionScheduler::resume):
3894         (WebCore::FrameActionScheduler::dispatch):
3895         (WebCore::FrameActionScheduler::scheduleAction):
3896         (WebCore::FrameActionScheduler::scheduleEvent):
3897         * page/FrameActionScheduler.h: Added.
3898         (WebCore::FrameAction::FrameAction):
3899         (WebCore::FrameAction::~FrameAction):
3900         (WebCore::FrameActionScheduler::isScheduled):
3901         * page/FrameView.cpp:
3902         (WebCore::FrameView::FrameView):
3903         (WebCore::FrameView::~FrameView):
3904         (WebCore::FrameView::layout):
3905         (WebCore::FrameView::scheduleEvent):
3906         (WebCore::FrameView::pauseScheduledEvents):
3907         (WebCore::FrameView::resumeScheduledEvents):
3908         (WebCore::FrameView::performPostLayoutTasks):
3909         (WebCore::FrameView::updateOverflowStatus):
3910         * page/FrameView.h:
3911
3912 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3913
3914         Unreviewed, rolling out r80201.
3915         http://trac.webkit.org/changeset/80201
3916         https://bugs.webkit.org/show_bug.cgi?id=55648
3917
3918         "caused tests to crash on several bots" (Requested by rniwa on
3919         #webkit).
3920
3921         * dom/Element.h:
3922         (WebCore::Node::hasTagName):
3923         * dom/Node.h:
3924         * html/parser/HTMLConstructionSite.cpp:
3925         (WebCore::HTMLNames::hasImpliedEndTag):
3926         (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
3927         (WebCore::HTMLConstructionSite::insertComment):
3928         (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
3929         (WebCore::HTMLConstructionSite::attachToCurrent):
3930         (WebCore::HTMLConstructionSite::insertScriptElement):
3931         (WebCore::HTMLConstructionSite::insertTextNode):
3932         (WebCore::HTMLConstructionSite::createElement):
3933         (WebCore::HTMLConstructionSite::createHTMLElement):
3934         (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
3935         (WebCore::HTMLConstructionSite::generateImpliedEndTags):
3936         (WebCore::HTMLConstructionSite::findFosterSite):
3937         (WebCore::HTMLConstructionSite::shouldFosterParent):
3938         * html/parser/HTMLConstructionSite.h:
3939         * html/parser/HTMLElementStack.cpp:
3940         (WebCore::HTMLNames::isNumberedHeaderElement):
3941         (WebCore::HTMLNames::isScopeMarker):
3942         (WebCore::HTMLNames::isListItemScopeMarker):
3943         (WebCore::HTMLNames::isTableScopeMarker):
3944         (WebCore::HTMLNames::isTableBodyScopeMarker):
3945         (WebCore::HTMLNames::isTableRowScopeMarker):
3946         (WebCore::HTMLNames::isButtonScopeMarker):
3947         (WebCore::HTMLNames::isSelectScopeMarker):
3948         (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
3949         (WebCore::HTMLElementStack::ElementRecord::replaceElement):
3950         (WebCore::HTMLElementStack::HTMLElementStack):
3951         (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
3952         (WebCore::HTMLElementStack::popAll):
3953         (WebCore::HTMLElementStack::popUntilTableScopeMarker):
3954         (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
3955         (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
3956         (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
3957         (WebCore::HTMLElementStack::pushHTMLHtmlElement):
3958         (WebCore::HTMLElementStack::push):
3959         (WebCore::HTMLElementStack::insertAbove):
3960         (WebCore::HTMLElementStack::find):
3961         (WebCore::HTMLElementStack::topmost):
3962         (WebCore::inScopeCommon):
3963         (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
3964         (WebCore::HTMLElementStack::htmlElement):
3965         (WebCore::HTMLElementStack::bodyElement):
3966         (WebCore::HTMLElementStack::pushCommon):
3967         * html/parser/HTMLElementStack.h:
3968         (WebCore::HTMLElementStack::ElementRecord::element):
3969         (WebCore::HTMLElementStack::top):
3970         * html/parser/HTMLTreeBuilder.cpp:
3971         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
3972         (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
3973         (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
3974         (WebCore::HTMLTreeBuilder::processStartTagForInBody):
3975         (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
3976         (WebCore::HTMLTreeBuilder::processStartTag):
3977         (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
3978         (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
3979         (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
3980         (WebCore::HTMLTreeBuilder::processEndTagForInCell):
3981         (WebCore::HTMLTreeBuilder::processEndTagForInBody):
3982         (WebCore::HTMLTreeBuilder::processEndTag):
3983         (WebCore::HTMLTreeBuilder::processEndOfFile):
3984         (WebCore::HTMLTreeBuilder::finished):
3985         * html/parser/HTMLTreeBuilder.h:
3986
3987 2011-03-02  Yury Semikhatsky  <yurys@chromium.org>
3988
3989         Reviewed by Pavel Feldman.
3990
3991         Web Inspector: break down InspectorFrontend into domain-specific classes
3992         https://bugs.webkit.org/show_bug.cgi?id=55584
3993
3994         * inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains nested classes for
3995         all domains that have event notifications.
3996         * inspector/ConsoleMessage.cpp:
3997         (WebCore::ConsoleMessage::addToFrontend):
3998         (WebCore::ConsoleMessage::updateRepeatCountInConsole):
3999         * inspector/ConsoleMessage.h:
4000         * inspector/InjectedScriptHost.cpp:
4001         (WebCore::InjectedScriptHost::inspectImpl):
4002         * inspector/Inspector.idl:
4003         * inspector/InspectorAgent.cpp:
4004         (WebCore::InspectorAgent::inspectedPageDestroyed):
4005         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
4006         (WebCore::InspectorAgent::setFrontend):
4007         (WebCore::InspectorAgent::disconnectFrontend):
4008         (WebCore::InspectorAgent::populateScriptObjects):
4009         (WebCore::InspectorAgent::pushDataCollectedOffline):
4010         (WebCore::InspectorAgent::didCommitLoad):
4011         (WebCore::InspectorAgent::domContentLoadedEventFired):
4012         (WebCore::InspectorAgent::loadEventFired):
4013         (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
4014         (WebCore::InspectorAgent::evaluateForTestInFrontend):
4015         (WebCore::InspectorAgent::showPanel):
4016         * inspector/InspectorApplicationCacheAgent.cpp:
4017         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
4018         * inspector/InspectorApplicationCacheAgent.h:
4019         * inspector/InspectorConsoleAgent.cpp:
4020         (WebCore::InspectorConsoleAgent::setFrontend):
4021         * inspector/InspectorConsoleAgent.h:
4022         * inspector/InspectorController.cpp:
4023         (WebCore::InspectorController::show):
4024         (WebCore::InspectorController::close):
4025         * inspector/InspectorDOMAgent.cpp:
4026         (WebCore::InspectorDOMAgent::setFrontend):
4027         * inspector/InspectorDOMAgent.h:
4028         * inspector/InspectorDOMStorageResource.cpp:
4029         (WebCore::InspectorDOMStorageResource::bind):
4030         * inspector/InspectorDOMStorageResource.h:
4031         * inspector/InspectorDatabaseAgent.cpp:
4032         (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
4033         (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
4034         (WebCore::InspectorDatabaseAgent::setFrontend):
4035         * inspector/InspectorDatabaseResource.cpp:
4036         (WebCore::InspectorDatabaseResource::bind):
4037         * inspector/InspectorDatabaseResource.h:
4038         * inspector/InspectorDebuggerAgent.cpp:
4039         (WebCore::InspectorDebuggerAgent::setFrontend):
4040         * inspector/InspectorDebuggerAgent.h:
4041         * inspector/InspectorProfilerAgent.cpp:
4042         * inspector/InspectorProfilerAgent.h:
4043         (WebCore::InspectorProfilerAgent::setFrontend):
4044         (WebCore::InspectorProfilerAgent::clearFrontend):
4045         * inspector/InspectorResourceAgent.cpp:
4046         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
4047         * inspector/InspectorResourceAgent.h:
4048         * inspector/InspectorTimelineAgent.cpp:
4049         (WebCore::InspectorTimelineAgent::setFrontend):
4050         * inspector/InspectorTimelineAgent.h:
4051         * inspector/front-end/DOMAgent.js:
4052         (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
4053         (WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
4054         * inspector/front-end/inspector.js:
4055
4056 2011-03-02  Kent Tamura  <tkent@chromium.org>
4057
4058         Unreviewed, a trivial regression fix.
4059
4060         Fix LocalizedNumberICU regression by r80198 and r80199.
4061         https://bugs.webkit.org/show_bug.cgi?id=55629
4062
4063         * platform/text/LocalizedNumberICU.cpp:
4064           We should use U_SUCCESS().
4065         (WebCore::createFormatterForCurrentLocale):
4066         (WebCore::parseLocalizedNumber):
4067
4068 2011-03-02  Dan Bernstein  <mitz@apple.com>
4069
4070         Let Xcode know that Localizable.strings is UTF-16-encoded.
4071
4072         * WebCore.xcodeproj/project.pbxproj:
4073
4074 2011-03-02  Andy Estes  <aestes@apple.com>
4075
4076         Reviewed by Eric Seidel.
4077
4078         HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
4079         https://bugs.webkit.org/show_bug.cgi?id=48719
4080         
4081         Instead of pushing a fake HTMLHtmlElement onto the open element stack
4082         during fragment parsing only to later remove it and reparent its
4083         children to the DocumentFragment, push the DocumentFragment directly
4084         onto the open element stack as the root node. This requires refactoring
4085         HTMLElementStack to hold ContainerNode pointers rather than Element
4086         pointers, which has implications for HTMLConstructionSite and
4087         HTMLTreeBuilder as well.
4088         
4089         With this patch, the regression in Peacekeeper due to the introduction
4090         of the HTML5 fragment parsing algorithm is ~14%. The regression from
4091         Safari 5.0.3 is ~24%.
4092
4093         No new tests. No change in behavior.
4094
4095         * dom/Element.h:
4096         (WebCore::Node::hasLocalName):
4097         * dom/Node.h:
4098         * html/parser/HTMLConstructionSite.cpp:
4099         (WebCore::HTMLNames::hasImpliedEndTag):
4100         (WebCore::HTMLConstructionSite::HTMLConstructionSite):
4101         (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
4102         (WebCore::HTMLConstructionSite::insertComment):
4103         (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
4104         (WebCore::HTMLConstructionSite::attachToCurrent):
4105         (WebCore::HTMLConstructionSite::insertScriptElement):
4106         (WebCore::HTMLConstructionSite::insertTextNode):
4107         (WebCore::HTMLConstructionSite::createElement):
4108         (WebCore::HTMLConstructionSite::createHTMLElement):
4109         (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
4110         (WebCore::HTMLConstructionSite::generateImpliedEndTags):
4111         (WebCore::HTMLConstructionSite::findFosterSite):
4112         (WebCore::HTMLConstructionSite::shouldFosterParent):
4113         * html/parser/HTMLConstructionSite.h:
4114         (WebCore::HTMLConstructionSite::currentNode):
4115         * html/parser/HTMLElementStack.cpp:
4116         (WebCore::HTMLNames::isNumberedHeaderElement):
4117         (WebCore::HTMLNames::isScopeMarker):
4118         (WebCore::HTMLNames::isListItemScopeMarker):
4119         (WebCore::HTMLNames::isTableScopeMarker):
4120         (WebCore::HTMLNames::isTableBodyScopeMarker):
4121         (WebCore::HTMLNames::isTableRowScopeMarker):
4122         (WebCore::HTMLNames::isButtonScopeMarker):
4123         (WebCore::HTMLNames::isSelectScopeMarker):
4124         (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
4125         (WebCore::HTMLElementStack::ElementRecord::replaceElement):
4126         (WebCore::HTMLElementStack::HTMLElementStack):
4127         (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
4128         (WebCore::HTMLElementStack::popAll):
4129         (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
4130         (WebCore::HTMLElementStack::popUntil):
4131         (WebCore::HTMLElementStack::popUntilPopped):
4132         (WebCore::HTMLElementStack::popUntilTableScopeMarker):
4133         (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
4134         (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
4135         (WebCore::HTMLElementStack::pushHTMLHtmlElement):
4136         (WebCore::HTMLElementStack::push):
4137         (WebCore::HTMLElementStack::insertAbove):
4138         (WebCore::HTMLElementStack::find):