aaa85852fdc58ed1ff86a204f063f8f46e622089
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2016-09-26  Nan Wang  <n_wang@apple.com>
2
3         AX: Progress: [Mac] Content in label element should be used as AXTitle or AXDescription
4         https://bugs.webkit.org/show_bug.cgi?id=162573
5
6         Reviewed by Chris Fleizach.
7
8         Exposed the label element's text as the AXTitle of the progress indicator.
9
10         Test: accessibility/mac/progress-with-label-element.html
11
12         * accessibility/AccessibilityNodeObject.cpp:
13         (WebCore::AccessibilityNodeObject::titleElementText):
14         (WebCore::AccessibilityNodeObject::title):
15
16 2016-09-26  Ryan Haddad  <ryanhaddad@apple.com>
17
18         Rebaseline bindings tests after r206386.
19
20         Unreviewed test gardening.
21
22         * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
23         * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
24         * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
25         * bindings/scripts/test/JS/JSTestGlobalObject.cpp:
26         * bindings/scripts/test/JS/JSTestInterface.cpp:
27         * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
28         * bindings/scripts/test/JS/JSTestNode.cpp:
29         * bindings/scripts/test/JS/JSTestNondeterministic.cpp:
30         * bindings/scripts/test/JS/JSTestObj.cpp:
31         * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
32         * bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
33         * bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
34         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
35         * bindings/scripts/test/JS/JSTestTypedefs.cpp:
36
37 2016-09-26  Youenn Fablet  <youenn@apple.com>
38
39         ASSERTION FAILED: m_origin || m_type == CachedResource::MainResource
40         https://bugs.webkit.org/show_bug.cgi?id=162472
41         <rdar://problem/28431522>
42
43         Reviewed by Chris Dumez.
44
45         Covered by existing tests.
46
47         * loader/cache/CachedImage.cpp:
48         (WebCore::CachedImage::CachedImage): Fixing the last CachedImage constructor.
49         Using CachedResource protected constructor.
50         * loader/cache/CachedResource.h: Small clean-up.
51
52 2016-09-26  Youenn Fablet  <youenn@apple.com>
53
54         [GTK][EFL] imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html is failing
55         https://bugs.webkit.org/show_bug.cgi?id=162547
56
57         Reviewed by Carlos Garcia Campos.
58
59         Covered by LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html now passing.
60
61         * platform/network/soup/SoupNetworkSession.cpp:
62         (WebCore::SoupNetworkSession::createTestingSession): Setting a default Accept-Language value.
63
64 2016-09-26  Mark Lam  <mark.lam@apple.com>
65
66         Added RETURN_IF_EXCEPTION() macro and use it for exception checks.
67         https://bugs.webkit.org/show_bug.cgi?id=162521
68
69         Reviewed by Saam Barati.
70
71         No new tests because this patch is mostly refactoring.  The only change in
72         behavior is that functions that have a JSValue return type will now return the
73         empty JSValue when an exception is thrown.  I tested this behavior by running
74         the existing JSC and layout tests.
75
76         * bindings/js/ArrayValue.cpp:
77         (WebCore::ArrayValue::get):
78         * bindings/js/IDBBindingUtilities.cpp:
79         (WebCore::toJS):
80         * bindings/js/JSApplePaySessionCustom.cpp:
81         (WebCore::JSApplePaySession::completeShippingMethodSelection):
82         (WebCore::JSApplePaySession::completeShippingContactSelection):
83         (WebCore::JSApplePaySession::completePaymentMethodSelection):
84         * bindings/js/JSAudioTrackCustom.cpp:
85         (WebCore::JSAudioTrack::setKind):
86         (WebCore::JSAudioTrack::setLanguage):
87         * bindings/js/JSBlobCustom.cpp:
88         (WebCore::constructJSBlob):
89         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
90         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
91         * bindings/js/JSCommandLineAPIHostCustom.cpp:
92         (WebCore::getJSListenerFunctions):
93         * bindings/js/JSCryptoAlgorithmDictionary.cpp:
94         (WebCore::JSCryptoAlgorithmDictionary::getAlgorithmIdentifier):
95         (WebCore::getHashAlgorithm):
96         (WebCore::createAesCbcParams):
97         (WebCore::createAesKeyGenParams):
98         (WebCore::createHmacKeyParams):
99         (WebCore::createRsaKeyGenParams):
100         (WebCore::createRsaOaepParams):
101         * bindings/js/JSCryptoKeySerializationJWK.cpp:
102         (WebCore::getStringFromJSON):
103         (WebCore::JSCryptoKeySerializationJWK::reconcileUsages):
104         (WebCore::JSCryptoKeySerializationJWK::keyDataRSAComponents):
105         (WebCore::buildJSONForRSAComponents):
106         (WebCore::addUsagesToJSON):
107         (WebCore::JSCryptoKeySerializationJWK::serialize):
108         * bindings/js/JSCustomElementInterface.cpp:
109         (WebCore::constructCustomElementSynchronously):
110         (WebCore::JSCustomElementInterface::upgradeElement):
111         * bindings/js/JSCustomElementRegistryCustom.cpp:
112         (WebCore::getCustomElementCallback):
113         (WebCore::JSCustomElementRegistry::define):
114         (WebCore::whenDefinedPromise):
115         * bindings/js/JSDOMBinding.cpp:
116         (WebCore::valueToUSVString):
117         (WebCore::hasIteratorMethod):
118         (WebCore::toSmallerInt):
119         (WebCore::toSmallerUInt):
120         (WebCore::toInt32EnforceRange):
121         (WebCore::toUInt32EnforceRange):
122         (WebCore::toInt64EnforceRange):
123         (WebCore::toUInt64EnforceRange):
124         * bindings/js/JSDOMBinding.h:
125         (WebCore::toJSSequence):
126         (WebCore::toJS):
127         (WebCore::jsFrozenArray):
128         * bindings/js/JSDOMPromise.cpp:
129         (WebCore::rejectPromiseWithExceptionIfAny):
130         * bindings/js/JSDOMStringMapCustom.cpp:
131         (WebCore::JSDOMStringMap::putDelegate):
132         * bindings/js/JSDOMWindowCustom.cpp:
133         (WebCore::JSDOMWindow::setLocation):
134         (WebCore::JSDOMWindow::open):
135         (WebCore::JSDOMWindow::showModalDialog):
136         (WebCore::handlePostMessage):
137         (WebCore::JSDOMWindow::setTimeout):
138         (WebCore::JSDOMWindow::setInterval):
139         * bindings/js/JSDataCueCustom.cpp:
140         (WebCore::constructJSDataCue):
141         * bindings/js/JSDeviceMotionEventCustom.cpp:
142         (WebCore::readAccelerationArgument):
143         (WebCore::readRotationRateArgument):
144         (WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
145         * bindings/js/JSDictionary.cpp:
146         (WebCore::JSDictionary::tryGetProperty):
147         (WebCore::JSDictionary::convertValue):
148         * bindings/js/JSDictionary.h:
149         (WebCore::JSDictionary::tryGetPropertyAndResult):
150         * bindings/js/JSDocumentCustom.cpp:
151         (WebCore::JSDocument::getCSSCanvasContext):
152         * bindings/js/JSFileCustom.cpp:
153         (WebCore::constructJSFile):
154         * bindings/js/JSGeolocationCustom.cpp:
155         (WebCore::JSGeolocation::getCurrentPosition):
156         (WebCore::JSGeolocation::watchPosition):
157         * bindings/js/JSHTMLAllCollectionCustom.cpp:
158         (WebCore::callHTMLAllCollection):
159         * bindings/js/JSHTMLCanvasElementCustom.cpp:
160         (WebCore::JSHTMLCanvasElement::getContext):
161         * bindings/js/JSHTMLElementCustom.cpp:
162         (WebCore::constructJSHTMLElement):
163         * bindings/js/JSHistoryCustom.cpp:
164         (WebCore::JSHistory::pushState):
165         (WebCore::JSHistory::replaceState):
166         * bindings/js/JSIDBDatabaseCustom.cpp:
167         (WebCore::JSIDBDatabase::createObjectStore):
168         * bindings/js/JSMessageEventCustom.cpp:
169         (WebCore::handleInitMessageEvent):
170         * bindings/js/JSMessagePortCustom.cpp:
171         (WebCore::fillMessagePortArray):
172         * bindings/js/JSMessagePortCustom.h:
173         (WebCore::handlePostMessage):
174         * bindings/js/JSMockContentFilterSettingsCustom.cpp:
175         (WebCore::JSMockContentFilterSettings::setDecisionPoint):
176         (WebCore::toDecision):
177         (WebCore::JSMockContentFilterSettings::setDecision):
178         (WebCore::JSMockContentFilterSettings::setUnblockRequestDecision):
179         * bindings/js/JSNodeFilterCustom.cpp:
180         (WebCore::JSNodeFilter::acceptNode):
181         * bindings/js/JSNodeOrString.cpp:
182         (WebCore::toNodeOrStringVector):
183         * bindings/js/JSSQLTransactionCustom.cpp:
184         (WebCore::JSSQLTransaction::executeSql):
185         * bindings/js/JSSVGLengthCustom.cpp:
186         (WebCore::JSSVGLength::convertToSpecifiedUnits):
187         * bindings/js/JSStorageCustom.cpp:
188         (WebCore::JSStorage::getOwnPropertyNames):
189         * bindings/js/JSTextTrackCustom.cpp:
190         (WebCore::JSTextTrack::setLanguage):
191         * bindings/js/JSVideoTrackCustom.cpp:
192         (WebCore::JSVideoTrack::setKind):
193         (WebCore::JSVideoTrack::setLanguage):
194         * bindings/js/JSWebGL2RenderingContextCustom.cpp:
195         (WebCore::JSWebGL2RenderingContext::getIndexedParameter):
196         * bindings/js/JSWebGLRenderingContextBaseCustom.cpp:
197         (WebCore::getObjectParameter):
198         (WebCore::JSWebGLRenderingContextBase::getExtension):
199         (WebCore::JSWebGLRenderingContextBase::getFramebufferAttachmentParameter):
200         (WebCore::JSWebGLRenderingContextBase::getParameter):
201         (WebCore::JSWebGLRenderingContextBase::getProgramParameter):
202         (WebCore::JSWebGLRenderingContextBase::getShaderParameter):
203         (WebCore::toVector):
204         (WebCore::dataFunctionf):
205         (WebCore::dataFunctionMatrix):
206         * bindings/js/JSWebKitSubtleCryptoCustom.cpp:
207         (WebCore::cryptoKeyFormatFromJSValue):
208         (WebCore::cryptoKeyUsagesFromJSValue):
209         (WebCore::JSWebKitSubtleCrypto::generateKey):
210         (WebCore::importKey):
211         (WebCore::JSWebKitSubtleCrypto::importKey):
212         (WebCore::exportKey):
213         (WebCore::JSWebKitSubtleCrypto::exportKey):
214         (WebCore::JSWebKitSubtleCrypto::unwrapKey):
215         * bindings/js/JSWorkerCustom.cpp:
216         (WebCore::constructJSWorker):
217         * bindings/js/JSWorkerGlobalScopeCustom.cpp:
218         (WebCore::JSWorkerGlobalScope::importScripts):
219         (WebCore::JSWorkerGlobalScope::setTimeout):
220         (WebCore::JSWorkerGlobalScope::setInterval):
221         * bindings/js/ReadableStreamDefaultController.cpp:
222         (WebCore::ReadableStreamDefaultController::invoke):
223         * bindings/js/ScheduledAction.cpp:
224         (WebCore::ScheduledAction::create):
225         * bindings/scripts/CodeGeneratorJS.pm:
226         (GenerateDictionaryImplementationContent):
227         (GenerateImplementation):
228         (GenerateParametersCheck):
229         (GenerateImplementationFunctionCall):
230         (GenerateConstructorDefinition):
231         * html/HTMLMediaElement.cpp:
232         (WebCore::controllerJSValue):
233         (WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
234         (WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):
235
236 2016-09-26  Michael Catanzaro  <mcatanzaro@igalia.com>
237
238         -Wtautological-compare triggered in URLParser::internalValuesConsistent
239         https://bugs.webkit.org/show_bug.cgi?id=162551
240
241         Reviewed by Alex Christensen.
242
243         Fix logic error.
244
245         * platform/URLParser.cpp:
246         (WebCore::URLParser::internalValuesConsistent):
247
248 2016-09-26  Michael Catanzaro  <mcatanzaro@igalia.com>
249
250         Add CairoUniquePtr and use it in FontPlatformDataFreetype.cpp
251         https://bugs.webkit.org/show_bug.cgi?id=162557
252
253         Reviewed by Alex Christensen.
254
255         * platform/graphics/cairo/CairoUniquePtr.h: Added.
256         (WebCore::CairoPtrDeleter<cairo_font_options_t>::operator()):
257         * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
258         (WebCore::getDefaultCairoFontOptions): Return a smart pointer.
259         (WebCore::FontPlatformData::buildScaledFont): Use smart pointer.
260
261 2016-09-26  Michael Catanzaro  <mcatanzaro@igalia.com>
262
263         Silence unused parameter warnings from Geoclue2Interface.c
264         https://bugs.webkit.org/show_bug.cgi?id=162545
265
266         Reviewed by Carlos Garcia Campos.
267
268         * PlatformGTK.cmake:
269
270 2016-09-26  Michael Catanzaro  <mcatanzaro@igalia.com>
271
272         std::unique_ptr deleter functions should not check if pointer is null
273         https://bugs.webkit.org/show_bug.cgi?id=162558
274
275         Reviewed by Alex Christensen.
276
277         std::unique_ptr already does this before calling the deleter.
278
279         * platform/graphics/x11/XUniquePtr.h:
280         (WebCore::XPtrDeleter::operator()):
281         (WebCore::XPtrDeleter<XImage>::operator()):
282         (WebCore::XPtrDeleter<_XGC>::operator()):
283         (WebCore::XPtrDeleter<__GLXcontextRec>::operator()):
284
285 2016-09-26  Per Arne Vollan  <pvollan@apple.com>
286
287         [Win][Debug] Compile fix.
288         https://bugs.webkit.org/show_bug.cgi?id=162550
289
290         Reviewed by Alex Christensen.
291
292         Windows headers need the FragmentForwardIterator '==' operator in debug mode.
293
294         * rendering/SimpleLineLayout.cpp:
295         (WebCore::SimpleLineLayout::FragmentForwardIterator::operator==):
296
297 2016-09-26  Michael Catanzaro  <mcatanzaro@igalia.com>
298
299         [GTK] Unnecessary extern functions in FontPlatformDataFreeType.cpp
300         https://bugs.webkit.org/show_bug.cgi?id=162555
301
302         Reviewed by Carlos Garcia Campos.
303
304         These functions should be file-static.
305
306         * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
307         (WebCore::convertFontConfigSubpixelOrder):
308         (WebCore::convertFontConfigHintStyle):
309         (WebCore::setCairoFontOptionsFromFontConfigPattern):
310
311 == Rolled over to ChangeLog-2016-09-26 ==