Make CSS JIT run on ARM64.

[WebKit-https.git] / Source / WebCore / ChangeLog

2014-05-23  Alex Christensen  <achristensen@webkit.org>

        Make CSS JIT run on ARM64.
        https://bugs.webkit.org/show_bug.cgi?id=133156

        Reviewed by Benjamin Poulain.

        * cssjit/FunctionCall.h:
        (WebCore::FunctionCall::saveAllocatedRegisters):
        (WebCore::FunctionCall::restoreAllocatedRegisters):
        Use StackAllocator's new push and pop functions to push and pop a vector instead of iterating it.
        * cssjit/RegisterAllocator.h:
        (WebCore::RegisterAllocator::reserveCalleeSavedRegisters):
        (WebCore::RegisterAllocator::restoreCalleeSavedRegisters):
        Return a vector of registers to allocate instead of doing the allocation to make the RegisterAllocator
        not need to know about the StackAllocator and to use the new vector push and pop functions.
        (WebCore::RegisterAllocator::~RegisterAllocator):
        Store RegisterIDs instead of StackReferences to avoid needing to know about the stack.
        * cssjit/SelectorCompiler.cpp:
        (WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
        Removed the requirement for assert to be disabled to print disassembly when debugging css jit.
        (WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
        (WebCore::SelectorCompiler::SelectorCodeGenerator::generateEpilogue):
        Added to correctly push the link register and frame pointer.
        This is required if the jit code calls a function on arm64 and helpful for debugging tools on x86_64.
        (WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
        Generate the prologue and epilogue which respectively push and pop
        the link register, frame pointer, and callee saved registers if needed.
        * cssjit/StackAllocator.h:
        (WebCore::StackAllocator::push):
        (WebCore::StackAllocator::pop):
        Added new vector push and pop functions to use stp and ldb instructions on arm64.

2014-05-23  Jeremy Jones  <jeremyj@apple.com>

        Hide fullscreen immediately when switching tabs.
        https://bugs.webkit.org/show_bug.cgi?id=133239

        Reviewed by Eric Carlson.

        This change allows fullscreen to disappear immediately while still cleaning
        up fullscreen normally.

        * WebCore.exp.in:
        * platform/ios/WebVideoFullscreenControllerAVKit.h:
        renamed function to requestHideAndExitFullscreen

        * platform/ios/WebVideoFullscreenControllerAVKit.mm:
        renamed function to requestHideAndExitFullscreen

        (-[WebVideoFullscreenController requestHideAndExitFullscreen]):
        rename of requestExitFullscreen that also hides.

        (-[WebVideoFullscreenController requestExitFullscreen]): Deleted.
        * platform/ios/WebVideoFullscreenInterfaceAVKit.h: declare requestHideAndExitFullscreen()
        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
        (WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen):
        this hides the window before requesting exitfullscreen from the model.

2014-05-23  Tim Horton  <timothy_horton@apple.com>

        [iOS] WKPDFView should have a page indicator
        https://bugs.webkit.org/show_bug.cgi?id=133109
        <rdar://problem/16383003>

        Reviewed by Anders Carlsson.

        * English.lproj/Localizable.strings:

2014-05-23  Enrica Casucci  <enrica@apple.com>

        Remove invalid ASSERT in wordRangeForPosition.
        https://bugs.webkit.org/show_bug.cgi?id=133232

        Reviewed by Ryosuke Niwa.

        In WK2 for iOS this function is called on every selection change.
        The selection could be set by Javascript in an element that is not visible.
        In that case we won't be able to create a VisiblePosition therefore wordRangeForPosition
        should not ASSERT that the VisiblePosition is not null, but rather
        perform an early return if it is null.

        * editing/VisibleUnits.cpp:
        (WebCore::wordRangeFromPosition):

2014-05-23  Manuel Rego Casasnovas  <rego@igalia.com>

        [CSS Grid Layout] Use gridRowCount() and gridColumnCount() when possible
        https://bugs.webkit.org/show_bug.cgi?id=133213

        Reviewed by Sergio Villar Senin.

        Use gridRowCount() and gridColumnCount() instead of m_grid.size() and
        m_grid[0].size() to make the code more descriptive and easier to
        understand.

        No new tests (No change in behavior).

        * rendering/RenderGrid.cpp:
        (WebCore::RenderGrid::growGrid):
        (WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):

2014-05-23  Alexey Proskuryakov  <ap@apple.com>

        REGRESSION (r153917): Chart for the Category Explorer within Quicken Essentials
        does not draw until you force a redraw
        https://bugs.webkit.org/show_bug.cgi?id=133228
        <rdar://problem/15221231>

        Reviewed by Simon Fraser.

        * platform/RuntimeApplicationChecks.cpp: (WebCore::applicationIsQuickenEssentials):
        * platform/RuntimeApplicationChecks.h:
        Added a check for Quicken Essentials.

        * platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Don't do an early return
        for Quicken Essentials, it depends on drawing to update its layer.

2014-05-23  Mihnea Ovidenie  <mihnea@adobe.com>

        REGRESSION(r169105): fast/regions/cssom/region-range-for-box-crash.html is more crashy than before
        https://bugs.webkit.org/show_bug.cgi?id=133124

        Reviewed by David Hyatt.

        When adjusting the end points of a subtree selection in the case of a document
        with named flows, we have to make sure that we pass the computed end
        points to the visible selection algorithm only if the end points are
        part of the same subtree, otherwise assume a selection clear behavior.

        The test fast/regions/cssom/region-range-for-box-crash.html is used to
        test this behavior.

        * rendering/SelectionSubtreeRoot.cpp:
        (WebCore::SelectionSubtreeRoot::adjustForVisibleSelection):
        (WebCore::SelectionSubtreeRoot::selectionStartEndPositions): Moved to header file.
        * rendering/SelectionSubtreeRoot.h:
        (WebCore::SelectionSubtreeRoot::selectionStartEndPositions):

2014-05-23  Jeremy Jones  <jeremyj@apple.com>

        reset m_havePreparedToPlay when changing media engines.
        https://bugs.webkit.org/show_bug.cgi?id=133199

        Reviewed by Eric Carlson.

        If a play request comes in before the media player is created, m_havePreparedToPlay
        is set to true. But when the player is created, this prevents the new player from
        getting the prepare call.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): set m_havePreparedToPlay false.

2014-05-23  Oliver Hunt  <oliver@apple.com>

        Navigator object needs to have properties directly on the instance object
        https://bugs.webkit.org/show_bug.cgi?id=133221

        Reviewed by Mark Lam.

        Flag the Navigator object as requiring properties to be on the instance
        as there were a few compatibility issues when on the prototype.

        * bindings/scripts/CodeGeneratorJS.pm:
        (InterfaceRequiresAttributesOnInstance):

2014-05-23  Simon Fraser  <simon.fraser@apple.com>

        Switch CSSGradientValue to use more references
        https://bugs.webkit.org/show_bug.cgi?id=133206

        Reviewed by Andreas Kling.

        Switch from pointers to references in various places.

        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::image):
        (WebCore::CSSGradientValue::addStops):
        (WebCore::positionFromValue):
        (WebCore::CSSGradientValue::computeEndPoint):
        (WebCore::CSSLinearGradientValue::createGradient):
        (WebCore::CSSRadialGradientValue::resolveRadius):
        (WebCore::CSSRadialGradientValue::createGradient):
        * css/CSSGradientValue.h:

2014-05-23  Zalan Bujtas  <zalan@apple.com>

        Subpixel rendering: Make webkit-box-shadow painting subpixel aware.
        https://bugs.webkit.org/show_bug.cgi?id=133201
        <rdar://problem/16072830>

        Reviewed by Simon Fraser.

        This patch enables webkit-box-shadow to be painted on a subpixel position. However, we
        still truncate -webkit-box-shadow property values. Tracked here: http://webkit.org/b/133202

        Test: fast/box-shadow/hidpi-webkit-box-shadow-subpixel-position.html

        * platform/graphics/FloatRoundedRect.cpp:
        (WebCore::FloatRoundedRect::inflateWithRadii): same as in from RoundedRect.
        (WebCore::FloatRoundedRect::adjustRadii): same as in from RoundedRect.
        * platform/graphics/FloatRoundedRect.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow):

2014-05-22  peavo@outlook.com  <peavo@outlook.com>

        [Curl] Crash when exceeding maximum cache limit.
        https://bugs.webkit.org/show_bug.cgi?id=133185

        Reviewed by Brent Fulgham.

        When the maximum cache limit is exceeded, I get a crash.
        This happens when deleting cache entries, because a reference to the url string object in the LRU list
        is used as a parameter to invalidateCacheEntry(), when called from makeRoomForNewEntry().
        When the string is removed from the LRU list in makeRoomForNewEntry(), the string is deleted.
        Next, the string is accessed again to remove the url from the index, and we crash.

        This can be fixed by removing the string from the LRU list after it is removed from the index.

        Fixing the crash also revealed an infinite loop problem.
        If the url for some reason only exist in the LRU list, and not in the index,
        we will inifitely loop in makeRoomForNewEntry(), trying to remove this url from the cache, but never succeeding.
        This can be fixed by removing the url from the LRU list, also when it's not in the index.

        * platform/network/curl/CurlCacheManager.cpp:
        (WebCore::CurlCacheManager::makeRoomForNewEntry): Avoid infinite loop by checking if there are more cache entries to remove.
        (WebCore::CurlCacheManager::invalidateCacheEntry): Avoid crash and infinite loop by removing url from LRU list last.

2014-05-22  Simon Fraser  <simon.fraser@apple.com>

        Make viewport units work in CSS gradients
        https://bugs.webkit.org/show_bug.cgi?id=133204
        <rdar://problem/17012259>
        
        Reviewed by Tim Horton.
        
        Make viewport percentage lengths work in gradients.

        Test: fast/gradients/viewport-units-gradient.html

        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::addStops):
        (WebCore::CSSLinearGradientValue::createGradient):
        (WebCore::CSSRadialGradientValue::createGradient):
        * css/CSSGradientValue.h:

2014-05-22  Benjamin Poulain  <bpoulain@apple.com>

        [iOS][WK2] Add support for minimal-ui viewports
        https://bugs.webkit.org/show_bug.cgi?id=133162

        Reviewed by Simon Fraser.

        Add support for minimal-ui directly into the Viewport configuration.

        ViewportConfiguration knows about two kinds of layout size in scrollview coordinates:
        -normal size
        -minimal ui size.

        Initially, the page is initialized with resetMinimalUI() and starts with a normal layout.

        At any time before the main resource is loaded, the Web page can update its viewport meta tag
        to include minimal-ui. The viewport configuration is updated immediately to reflect the minimal-ui
        layout size. Any layout after that takes minimal-ui into account.

        * WebCore.exp.in:
        * css/LengthFunctions.cpp:
        (WebCore::minimumValueForLength):
        (WebCore::floatValueForLength):
        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::viewportPercentageValue):
        * dom/ViewportArguments.h:
        (WebCore::ViewportArguments::operator==):
        * page/FrameView.cpp:
        (WebCore::FrameView::setViewportSizeForCSSViewportUnits):
        (WebCore::FrameView::viewportSizeForCSSViewportUnits):
        (WebCore::FrameView::setViewportSize): Deleted.
        (WebCore::FrameView::viewportSize): Deleted.
        * page/FrameView.h:
        * page/ViewportConfiguration.cpp:
        (WebCore::ViewportConfiguration::ViewportConfiguration):
        (WebCore::ViewportConfiguration::setMinimumLayoutSize):
        (WebCore::ViewportConfiguration::setMinimumLayoutSizeForMinimalUI):
        (WebCore::ViewportConfiguration::activeMinimumLayoutSizeInScrollViewCoordinates):
        (WebCore::ViewportConfiguration::resetMinimalUI):
        (WebCore::ViewportConfiguration::pageWillRenderFirstFrame):
        (WebCore::ViewportConfiguration::initialScale):
        (WebCore::ViewportConfiguration::minimumScale):
        (WebCore::ViewportConfiguration::updateConfiguration):
        (WebCore::ViewportConfiguration::layoutWidth):
        (WebCore::ViewportConfiguration::layoutHeight):
        (WebCore::ViewportConfiguration::description):
        * page/ViewportConfiguration.h:
        (WebCore::ViewportConfiguration::minimumLayoutSizeForMinimalUI):
        (WebCore::ViewportConfiguration::usesMinimalUI):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::viewportSizeForCSSViewportUnits):
        (WebCore::RenderView::viewportSize): Deleted.
        * rendering/RenderView.h:

2014-05-22  Ryosuke Niwa  <rniwa@webkit.org>

        Can't type in status in facebook.com on iOS Safari because keyboard disappears
        https://bugs.webkit.org/show_bug.cgi?id=133196

        Reviewed by Geoffrey Garen.

        Fixed the bug by rolling out r156252.

        When the user taps on the status on facebook.com, the page focuses a textarea,
        which is then made momentarily invisible by setting display:none.
        The page then removes display:none later and expects the textarea to be still focused.

        With r156252, the focus is removed after the page sets display:none and the keyboard disappears.
        Since the focus is never reset on the textarea, the user can never type in anything.

        The specification may need to change here given that this (rather odd) behavior/expectation exists
        on one of the most popular websites on the Web.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::recalcStyle):
        (WebCore::Document::updateLayout):
        (WebCore::Document::resetHiddenFocusElementSoon): Deleted.
        (WebCore::Document::resetHiddenFocusElementTimer): Deleted.
        * dom/Document.h:

2014-05-22  Myles C. Maxfield  <mmaxfield@apple.com>

        http/tests/security/xss-DENIED-xsl-document-redirect.xml fails with NetworkProcess
        https://bugs.webkit.org/show_bug.cgi?id=132523

        Reviewed by Alexey Proskuryakov.

        We should not manufacture a response in the event of an error during a
        synchronous XHR. In addition, this test removes two places that are
        sensitive to such a manufactured response.

        Updates test expectations.

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::loadRequest): Don't inspect a
        loader response if there is an error
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
        manufacture a response
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
        manufacture a response
        * xml/XSLTProcessorLibxslt.cpp:
        (WebCore::docLoaderFunc): Only use the response's URL if no error
        occurred.

2014-05-22  Myles C. Maxfield  <litherum@gmail.com>

        Unreviewed typo fix.

        Reviewed by NOBODY.

        No new tests.

        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::dashesForIntersectionsWithRect): Accidentally said run.length() instead of glyphBuffer.size().

2014-05-22  Andreas Kling  <akling@apple.com>

        [iOS WebKit2] Web process should try to shrink its memory footprint when going into background.
        <https://webkit.org/b/133197>
        <rdar://problem/17011561>

        Make releaseMemory() public so we can call it from the process-will-suspend callback.

        Reviewed by Gavin Barraclough.

        * WebCore.exp.in:
        * platform/MemoryPressureHandler.h:

2014-05-22  Andreas Kling  <akling@apple.com>

        Hook up a setting for showing detailed logging during memory pressure relief.
        <https://webkit.org/b/133194>

        Make the pressure relief logger opt-in. Also make it flush memory back to the
        OS (for both malloc and FastMalloc) to get more accurate numbers at each step.

        Reviewed by Gavin Barraclough.

        * WebCore.exp.in:
        * platform/MemoryPressureHandler.cpp:
        * platform/MemoryPressureHandler.h:
        (WebCore::MemoryPressureHandler::ReliefLogger::ReliefLogger):
        (WebCore::MemoryPressureHandler::ReliefLogger::~ReliefLogger):
        (WebCore::MemoryPressureHandler::ReliefLogger::setLoggingEnabled):
        * platform/cocoa/MemoryPressureHandlerCocoa.mm:
        (WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage):

2014-05-22  Brady Eidson  <beidson@apple.com>

        Don't scan for phone numbers in editable regions
        <rdar://problem/16949846> and https://bugs.webkit.org/show_bug.cgi?id=133192

        Reviewed by Enrica Casucci.

        No new tests (Currently untested WK2-only feature)

        * editing/Editor.cpp:
        (WebCore::Editor::scanRangeForTelephoneNumbers): Skip the range if the Node is editable.

2014-05-22  Jeremy Jones  <jeremyj@apple.com>

        Captions layout incorrectly in fullscreen.
        https://bugs.webkit.org/show_bug.cgi?id=133175

        Reviewed by Eric Carlson.

        When doing layout for fullscreen, geometry should be absolute so it is not influenced
        by the rest of the page. This change adds style for CSSPropertyPosition, CSSPropertyLeft,
        and CSSPropertyTop.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlTextTrackContainerElement::updateDisplay):
        Refactor style changes into updateStyleForTextTrackRepresentation().
        (WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
        Refactor style changes into updateStyleForTextTrackRepresentation().
        (WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation):
        Refactor style changes into updateStyleForTextTrackRepresentation().
        (WebCore::MediaControlTextTrackContainerElement::updateStyleForTextTrackRepresentation):
        Consolidate style changes here. Include the two existing and three new style changes.
        * html/shadow/MediaControlElements.h:
        Declare updateStyleForTextTrackRepresentation().

2014-05-22  Simon Fraser  <simon.fraser@apple.com>

        REGRESSION (r155977): Very stuttery 3D css animation on jtechcommunications.com
        https://bugs.webkit.org/show_bug.cgi?id=133179
        <rdar://problem/16864666>

        Reviewed by Dean Jackson.

        Revert code added in r155977 to try to pick a good contentsScale for layers
        based on a root-relative transform. This resulted in pages with too much 
        backing store, and too many cases where layers repainted during animations,
        causing stutter.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::GraphicsLayerCA):
        (WebCore::GraphicsLayerCA::flushCompositingState):
        (WebCore::GraphicsLayerCA::recursiveCommitChanges):
        (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
        (WebCore::GraphicsLayerCA::updateContentsOpaque):
        (WebCore::GraphicsLayerCA::updateAnimations):
        (WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
        (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
        (WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
        (WebCore::GraphicsLayerCA::updateContentsScale):
        (WebCore::clampedContentsScaleForScale): Deleted.
        (WebCore::maxScaleFromTransform): Deleted.
        (WebCore::GraphicsLayerCA::updateRootRelativeScale): Deleted.
        (WebCore::GraphicsLayerCA::getTransformFromAnimationsWithMaxScaleImpact): Deleted.
        * platform/graphics/ca/GraphicsLayerCA.h:

2014-05-22  Martin Hock  <mhock@apple.com>

        [iOS] Enable -apple-system- styled elements to respond to system font size changes.
        https://bugs.webkit.org/show_bug.cgi?id=133186
        <rdar://problem/16583782>

        Reviewed by Enrica Casucci.

        * WebCore.exp.in:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderThemeIOS.h:
        * rendering/RenderThemeIOS.mm:
        (WebCore::_contentSizeCategory):
        (WebCore::RenderThemeIOS::contentSizeCategory):
        (WebCore::RenderThemeIOS::setContentSizeCategory):

2014-05-22  Jer Noble  <jer.noble@apple.com>

        [MSE] Stored samples are not freed when SourceBuffer is removed from MediaSource
        https://bugs.webkit.org/show_bug.cgi?id=133174

        Reviewed by Eric Carlson.

        Clear out stored MediaSamples from SourceBuffer's TrackBuffer storage when
        aborting loading. Also, report the memory cost of those samples, so that the
        SourceBuffer will be GCd more readily.

        Add a mechanism for reporting the size of a MediaSample:
        * Modules/mediasource/SourceBuffer.h:
        * platform/MediaSample.h:
        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
        * platform/mock/mediasource/MockSourceBufferPrivate.cpp:

        Track the memory usage of a SampleMap when adding and removing samples, as well
        as allowing the SampleMap to be cleared wholesale:
        * Modules/mediasource/SampleMap.cpp:
        (WebCore::SampleMap::clear): Release all stored MediaSamples.
        (WebCore::SampleMap::addSample): Update m_totalSize.
        (WebCore::SampleMap::removeSample): Ditto.
        * Modules/mediasource/SampleMap.h:
        (WebCore::SampleMap::SampleMap): Initialize m_totalSize.
        (WebCore::SampleMap::sizeInBytes): Simple accessor.

        Clear the stored samples when loading is aborted, and report the extra memory
        cost
        * Modules/mediasource/SourceBuffer.cpp:
        (WebCore::SourceBuffer::SourceBuffer): Initialize m_reportedExtraMemoryCost.
        (WebCore::SourceBuffer::removedFromMediaSource): Clear all stored samples.
        (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Call reportExtraMemoryCost().
        (WebCore::SourceBuffer::reportExtraMemoryCost): Inform the vm of the new
            extra memory cost incurred by the object.

2014-05-22  Enrica Casucci  <enrica@apple.com>

        REGRESSION (WebKit2): Keyboard should have Search button in duckduckgo.com.
        https://bugs.webkit.org/show_bug.cgi?id=133183
        <rdar://problem/17004207>

        Reviewed by Geoff Garen.

        Adding new export.

        * WebCore.exp.in:

2014-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        REGRESSION(r163712): [GTK] Misspelling and grammar underline marks are no longer drawn
        https://bugs.webkit.org/show_bug.cgi?id=133047

        Reviewed by Darin Adler.

        Change two conditions changed by mistake in r163712.

        * editing/TextCheckingHelper.cpp:
        (WebCore::findMisspellings): Enter the loop also when wordStart is 0.
        (WebCore::TextCheckingHelper::findFirstMisspelling): Skip the work
        when the text is a single character. Also reworked it to use a for
        loop to improve the readability.

2014-05-22  Piotr Grad  <p.grad@samsung.com>

        Video is resumed with old playback rate.
        https://bugs.webkit.org/show_bug.cgi?id=132905

        Reviewed by Philippe Normand.

        Setting '0' playback rate is causing pipeline to pause.
        GStreamer player impl. exposed this information to upper layers but it should not.
        Solution is to hidden such situation behind m_playbackRatePause flag.

        Test: media/video-paused-0-rate.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
        (WebCore::MediaPlayerPrivateGStreamer::play):
        (WebCore::MediaPlayerPrivateGStreamer::pause):
        (WebCore::MediaPlayerPrivateGStreamer::doSeek):
        (WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
        (WebCore::MediaPlayerPrivateGStreamer::paused):
        (WebCore::MediaPlayerPrivateGStreamer::setRate):
        (WebCore::MediaPlayerPrivateGStreamer::updateStates):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

2014-05-22  Antti Koivisto  <antti@apple.com>

        Text markers don't paint on simple lines
        https://bugs.webkit.org/show_bug.cgi?id=133177

        Reviewed by Anders Carlsson.
        
        Marker painting code does not yet support simple lines.

        Tests: fast/text/mark-matches-rendering-simple-lines.html
               fast/text/mark-matches-rendering.html

        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::addMarker):
        
            Force text blocks with markers to use line boxes.

        * testing/Internals.cpp:
        (WebCore::Internals::setMarkedTextMatchesAreHighlighted):
        
            Expose this so we can make reftests for marker rendering.

        * testing/Internals.h:
        * testing/Internals.idl:

2014-05-22  Manuel Rego Casasnovas  <rego@igalia.com>

        [CSS Grid Layout] Guard RenderObject::isRenderGrid() method
        https://bugs.webkit.org/show_bug.cgi?id=132380

        Reviewed by Benjamin Poulain.

        Guard RenderObject::isRenderGrid() method under ENABLE_CSS_GRID_LAYOUT compilation flag.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::computeLogicalWidthInRegion):
        * rendering/RenderObject.h:

2014-05-21  Antti Koivisto  <antti@apple.com>

        REGRESSION(r167870): Crash in simple line layout code with :after
        https://bugs.webkit.org/show_bug.cgi?id=133155
        <rdar://problem/16977696>

        Reviewed by Darin Adler.
        
        Fix https://bugs.webkit.org/show_bug.cgi?id=132241 in a safer way.
        The underline behavior is tested by the existing fast/text/simple-lines-hover-underline.html

        Test: fast/text/simple-lines-hover-after.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::invalidateLineLayoutPath): Deleted.

            Move to RenderBlockFlow.

        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::invalidateLineLayoutPath):
        * rendering/RenderBlockFlow.cpp:
        (WebCore::RenderBlockFlow::styleDidChange):
        
            Invalidate layout if style changes in a manner that makes us ineligible to use the simple line layout path.

        (WebCore::RenderBlockFlow::invalidateLineLayoutPath):
        
            Drop the simple line layout on path invalidation if it exists. It may not be valid anymore.
            Also invalidate the layout if this happens so we'll reconstruct the lines later.

        (WebCore::RenderBlockFlow::simpleLineLayout): Deleted.
        (WebCore::RenderBlockFlow::ensureLineBoxes):
        (WebCore::RenderBlockFlow::createLineBoxes): Deleted.
                
            Revert some of the changes made it r167870.

        * rendering/RenderBlockFlow.h:
        (WebCore::RenderBlockFlow::simpleLineLayout):
        
            Add strong validity assert.

2014-05-21  Eric Carlson  <eric.carlson@apple.com>

        [iOS] two media control button strings are not localized
        https://bugs.webkit.org/show_bug.cgi?id=133160

        Reviewed by Geoffrey Garen.

        * English.lproj/mediaControlsLocalizedStrings.js:

2014-05-21  Dean Jackson  <dino@apple.com>

        [iOS] Update some of the media controls buttons to be bigger
        https://bugs.webkit.org/show_bug.cgi?id=133158
        <rdar://problem/16475828>

        Reviewed by Simon Fraser.

        The buttons in the media controls on iOS are too small
        to be comfortably pressed. Make them the size of the controls
        panel and the expected iOS button size (44x44px).

        The artwork for the buttons now includes the padding. I've
        added a file from which you can edit the artwork, then
        copy it into the CSS (because editing directly in CSS is
        a huge pain).

        So far just the play/pause and fullscreen button have been
        updated. There will be a follow-up patch to fix the remaining
        buttons and the scrubber.

        * Modules/mediacontrols/assets-apple-iOS.svg: Added.
        * Modules/mediacontrols/mediaControlsiOS.css:
        (audio::-webkit-media-controls-panel):
        (audio::-webkit-media-controls-fullscreen-button):
        (audio::-webkit-media-controls-play-button):
        (audio::-webkit-media-controls-play-button:active):
        (audio::-webkit-media-controls-play-button.paused):
        (audio::-webkit-media-controls-fullscreen-button:active):
        (@media only screen and (-webkit-min-device-pixel-ratio: 2)): Deleted.

2014-05-21  Zalan Bujtas  <zalan@apple.com>

        Garbage when rubber-banding at the right edge of a page zoomed to non-integral scale.
        https://bugs.webkit.org/show_bug.cgi?id=133139
        <rdar://problem/16503353>

        Reviewed by Simon Fraser.

        Do not pixel align the root content layer. The alignment code expands the graphics's layer size
        which makes the right and bottom tiles bigger than the content.
        Painting the body's background color produces pixel cracks, because the content can not
        fill the expanded tiles completely.

        Not testable.

        * platform/graphics/GraphicsLayerClient.h:
        (WebCore::GraphicsLayerClient::needsPixelAligment):
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::updateGeometry):
        (WebCore::GraphicsLayerCA::computePixelAlignment):
        * platform/graphics/ca/mac/TileGrid.mm:
        (WebCore::TileGrid::rectForTileIndex):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::needsPixelAligment):
        * rendering/RenderLayerBacking.h:

2014-05-21  Radu Stavila  <stavila@adobe.com>

        REGRESSION (r168046): Invalid layout in WebCore::RenderBox::containingBlockLogicalWidthForPositioned
        https://bugs.webkit.org/show_bug.cgi?id=132933

        Reviewed by Darin Adler.

        Invalid layout is performed when calling containingBlockLogicalWidthForPositioned for a RenderTableSection object.

        Test: fast/multicol/newmulticol/table-section-crash.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):

2014-05-21  Simon Pena  <simon.pena@samsung.com>

        [EFL] Ensure EGLOffScreenContext::initialize calls platformMakeCurrent on the surface
        https://bugs.webkit.org/show_bug.cgi?id=124832

        Reviewed by Antonio Gomes.

        The original code was only calling platformMakeCurrent when the
        GL_EXT_robustness extension is supported: the alternate code path
        would only create a context, but it wouldn't make that context
        current. This patch ensures platformMakeCurrent is also called for
        the alternate code path, and, if it fails to make the context
        current, will destroy the context. Effectively, this makes both
        code paths behave in the same way.

        * platform/graphics/surfaces/egl/EGLContext.cpp:
        (WebCore::EGLOffScreenContext::initialize):

2014-05-20  Brent Fulgham  <bfulgham@apple.com>

        [Mac] DataCues do not work properly when rewinding video
        https://bugs.webkit.org/show_bug.cgi?id=133138
        <rdar://problem/16979086>

        Reviewed by Eric Carlson.

        Make the TrackPrivateBase responsible for knowing if a type of track needs a non-zero
        startTimeVariance value.

        Also, correct a bug in the equality test for DataCue objects.

        * html/track/DataCue.cpp:
        (WebCore::DataCue::isEqual): Handle the JSValue data types consistently, so that we don't attempt
        to compare a JSNull against a default JSValue object.
        * html/track/InbandTextTrack.cpp:
        (WebCore::InbandTextTrack::startTimeVariance): Added.
        * html/track/InbandTextTrack.h:
        * html/track/TextTrack.cpp:
        (WebCore::TextTrack::hasCue): Use new startTimeVariance method location.
        * html/track/TextTrack.h:
        (WebCore::TextTrack::startTimeVariance): Added.
        * html/track/TextTrackCue.cpp:
        (WebCore::TextTrackCue::hasEquivalentStartTime): Use new startTimeVariance location.
        * html/track/TextTrackCue.h:
        (WebCore::TextTrackCue::startTimeVariance): Deleted.
        * html/track/TextTrackCueGeneric.h:
        * platform/graphics/TrackPrivateBase.h:
        (WebCore::TrackPrivateBase::startTimeVariance): Added.
        * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:

2014-05-20  Mark Hahnenberg  <mhahnenberg@apple.com>

        Watchdog timer should be lazily allocated
        https://bugs.webkit.org/show_bug.cgi?id=133135

        Reviewed by Geoffrey Garen.

        No new tests.

        We incur a noticeable amount of overhead on some benchmarks due to checking if the Watchdog ever fired. 
        There is no reason to do this checking if we never activated the Watchdog, which can only be done through 
        JSContextGroupSetExecutionTimeLimit or JSContextGroupClearExecutionTimeLimit. 

        By allocating the Watchdog lazily on the VM we can avoid all of the associated overhead when we don't use 
        these two API functions (which is true of most clients).

        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::handleEvent):
        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate):
        (WebCore::WorkerScriptController::scheduleExecutionTermination):
        (WebCore::WorkerScriptController::isExecutionTerminating):

2014-05-20  Dean Jackson  <dino@apple.com>

        [Mac] Allow popup menus to override default appearance
        https://bugs.webkit.org/show_bug.cgi?id=133129

        Reviewed by Tim Horton.

        WebKitSystemInterface's WKPopupMenu has a flag to hide
        the arrows at the end of a popup-menu (e.g. <select>).
        Expose that via adding a hasDefaultAppearance flag to
        PopupMenuStyle, which then passes it on to WKSI.

        * platform/PopupMenuStyle.h:
        (WebCore::PopupMenuStyle::PopupMenuStyle): New flag in constructor.
        (WebCore::PopupMenuStyle::hasDefaultAppearance): New flag.
        * platform/mac/WebCoreSystemInterface.h: wkPopupMenu signature has changed to accept
        the new flag.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.
        * rendering/RenderMenuList.cpp:
        (RenderMenuList::itemStyle): Pass in true as default appearance when creating
        the PopupMenuStyle. We don't need it.
        (RenderMenuList::menuStyle): In this case we pass in the negated value of
        style().hasAppearance(), which indicates if we are overriding the built-in drawing.
        * rendering/RenderSearchField.cpp:
        (WebCore::RenderSearchField::menuStyle): Use true as the default value.

2014-05-20  Eric Carlson  <eric.carlson@apple.com>

        [Mac] do not deactivate an audio session that has running I/O
        https://bugs.webkit.org/show_bug.cgi?id=133127

        Reviewed by Jer Noble.

        * page/Settings.h:
        (WebCore::Settings::setShouldManageAudioSessionCategory): Renamed from setShouldManageAudioSession.
        (WebCore::Settings::shouldManageAudioSessionCategory): Renamed from shouldManageAudioSession.
        (WebCore::Settings::setShouldManageAudioSession): Deleted.
        (WebCore::Settings::shouldManageAudioSession): Deleted.

        * platform/audio/mac/MediaSessionManagerMac.cpp:
        (MediaSessionManager::updateSessionState): Don't deactivate the session if there are any
            Video or Audio sessions.

        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Drive-by change to log errors 
            returned by -statusOfValueForKey:error: in debug builds.

2014-05-20  Beth Dakin  <bdakin@apple.com>

        REGRESSION: All non-mainframe scrollbars don't paint after r169065
        https://bugs.webkit.org/show_bug.cgi?id=133132
        -and corresponding-
        <rdar://problem/16968850>

        Reviewed by Geoff Garen.

        We should not universally return true here. This feature will only work for 
        scrollbars with layers.
        * platform/ScrollableArea.h:
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::supportsUpdateOnSecondaryThread):

2014-05-20  Daniel Bates  <dabates@apple.com>

        Element within flattened frame may update its scroll state during the layout phase of the wrong RenderView
        https://bugs.webkit.org/show_bug.cgi?id=133013
        <rdar://problem/16760154>

        Reviewed by David Hyatt.

        Fixes an issue where the scroll state of an element may be updated during the layout of the wrong
        RenderView. In particular, the scroll state of an element inside a CSS flex box in a flattened
        frame f is updated during the layout of the RenderView associated with the parent frame of f instead
        of during the layout of the RenderView associated with f.

        The layout machinery assumes that the scroll state of each scrollable element is updated before the
        completion of layout for its associated RenderView. Currently we have logic to defer updating the scroll
        state of a scrollable element until completion of recursive layout. For a page with a flattened frame, we
        defer such updates until completion of layout for all RenderViews along the ancestor frame hierarchy of
        each flattened frame regardless of the RenderView associated with the element that originated the
        deferred scroll state request. Instead, only the RenderView associated with the element that deferred its
        scroll state update should dispatch the scroll state update.

        Tests: fast/frames/flattening/scrollable-flexbox-inside-iframe-with-zero-height-and-needs-full-repaint-crash.html
               fast/frames/flattening/scrollable-flexbox-inside-iframe-with-zero-height-assertion-failure.html

        * rendering/RenderBlock.cpp: Removed WTF::-prefix in typedef definition for ContinuationOutlineTableMap.
        (WebCore::UpdateScrollInfoAfterLayoutTransaction::UpdateScrollInfoAfterLayoutTransaction): Added; a struct
        that represents a RenderView v, nested transaction count, and a list of RenderBlocks in v that will need
        to have their scroll state updated.
        (WebCore::updateScrollInfoAfterLayoutTransactionStack): Added; returns the global stack of transactions.
        (WebCore::RenderBlock::willBeDestroyed): Call removeFromUpdateScrollInfoAfterLayoutTransaction(), which
        was formerly named as removeFromDelayedUpdateScrollInfoSet.
        (WebCore::currentUpdateScrollInfoAfterLayoutTransaction): Added; returns the top-most transaction in the
        global stack.
        (WebCore::RenderBlock::beginUpdateScrollInfoAfterLayoutTransaction): Modified as appropriate to make use
        of the global stack of transactions; formerly named startDelayUpdateScrollInfo.
        (WebCore::RenderBlock::endAndCommitUpdateScrollInfoAfterLayoutTransaction): Modified as appropriate to
        make use of the global stack of transactions; formerly named finishDelayUpdateScrollInfo.
        (WebCore::RenderBlock::removeFromUpdateScrollInfoAfterLayoutTransaction): Modified as appropriate to make
        use of the global stack of transactions; formerly named removeFromDelayedUpdateScrollInfoSet.
        (WebCore::RenderBlock::updateScrollInfoAfterLayout): Modified as appropriate to make use of the global
        stack of transactions.
        (WebCore::RenderBlock::layout): Ditto.
        (WebCore::RenderBlock::startDelayUpdateScrollInfo): Deleted.
        (WebCore::RenderBlock::finishDelayUpdateScrollInfo): Deleted.
        (WebCore::RenderBlock::removeFromDelayedUpdateScrollInfoSet): Deleted.
        * rendering/RenderBlock.h:
        * rendering/RenderBlockFlow.cpp:
        (WebCore::RenderBlockFlow::willBeDestroyed): Call removeFromUpdateScrollInfoAfterLayoutTransaction(), which
        was formerly named removeFromDelayedUpdateScrollInfoSet.
        * rendering/RenderDeprecatedFlexibleBox.cpp:
        (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): Call {begin, end}UpdateScrollInfoAfterLayoutTransaction(),
        which was formerly named {start, end}DelayUpdateScrollInfo.
        (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Ditto.
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock): Ditto.

2014-05-20  Beth Dakin  <bdakin@apple.com>

        REGRESSION (r169065): Mountain Lion run-api-tests failures: ASSERTION FAILED: 
        Uncaught exception - -[NSRegularLegacyScrollerImp setPresentationValue:]: 
        unrecognized selector sent to instance 0x7ff51aa38000
        https://bugs.webkit.org/show_bug.cgi?id=133121

        Reviewed by Tim Horton.

        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar):

2014-05-19  Simon Fraser  <simon.fraser@apple.com>

        REGRESSION (r169063) Fixed and sticky nodes misplaced on scrolling sometimes
        https://bugs.webkit.org/show_bug.cgi?id=133106
        <rdar://problem/16967648>

        Reviewed by Sam Weinig.

        Fix regression from r169063. That commit removed scrolledContentsLayers from 
        frame scrolling nodes, but they do actually use them.
        
        So put them back; not in the base class, because they have a somewhat different
        meaning for overflow scrolling and frame scrolling.

        * WebCore.exp.in:
        * page/scrolling/AsyncScrollingCoordinator.cpp:
        (WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
        (WebCore::AsyncScrollingCoordinator::updateFrameScrollingNode):
        * page/scrolling/AsyncScrollingCoordinator.h:
        * page/scrolling/ScrollingCoordinator.h:
        (WebCore::ScrollingCoordinator::updateFrameScrollingNode):
        * page/scrolling/ScrollingStateFrameScrollingNode.cpp:
        (WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
        (WebCore::ScrollingStateFrameScrollingNode::setScrolledContentsLayer):
        * page/scrolling/ScrollingStateFrameScrollingNode.h:
        * page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
        (WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

2014-05-20  Radu Stavila  <stavila@adobe.com>

        REGRESSION: [CSS Regions] Content flowed directly into the flow thread that ends up in the second region is not properly repainted
        https://bugs.webkit.org/show_bug.cgi?id=133111

        Reviewed by David Hyatt.

        When computing the repaint rect of an element flowed into a flow thread, if the element is flowed directly into
        the flow thread (meaning its containing block is the flow thread itself), the region's position within the flow
        must no longer be taken into consideration, because its already included in the element's |topLeft|.

        Test: fast/regions/hover-element-flowed-second-region.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::computeRectForRepaint):

2014-05-20  Alex Christensen  <achristensen@webkit.org>

        Fix web timing assertion failure.
        https://bugs.webkit.org/show_bug.cgi?id=133094
        <rdar://problem/16966032>

        Reviewed by Alexey Proskuryakov.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::getConnectionTimingData):
        Set requestStart and responseStart to 0 instead of -1 to match the 
        ResourceLoadTiming constructor and prevent the assertion failure in
        PerformanceTiming::responseStart.

2014-05-20  Prashant Hiremath  <hiremathprashants@gmail.com>

        Only set title on SVG documents
        https://bugs.webkit.org/show_bug.cgi?id=133068

        Reviewed by Dirk Schulze.

        Test: svg/custom/html_document_set_title.html

        * svg/SVGTitleElement.cpp:
        (WebCore::SVGTitleElement::insertedInto):
        (WebCore::SVGTitleElement::removedFrom):
        (WebCore::SVGTitleElement::childrenChanged):

2014-05-20  peavo@outlook.com  <peavo@outlook.com>

        [Curl] Invalid content in cache file, causes broken rendering.
        https://bugs.webkit.org/show_bug.cgi?id=133069

        Reviewed by Brent Fulgham.

        When data for a url is received as multiple parts, the cache file for the url is truncated when opened for writing,
        and will only contain the last part of data received.
        This is fixed by only opening the file once, and close it after all data has been received.

        * platform/network/curl/CurlCacheEntry.cpp:
        (WebCore::CurlCacheEntry::CurlCacheEntry): Initialize cache file handle member.
        (WebCore::CurlCacheEntry::~CurlCacheEntry): Close cache file.
        (WebCore::CurlCacheEntry::saveCachedData): Only open cache file once to avoid truncating.
        (WebCore::CurlCacheEntry::didFail): Close cache file.
        (WebCore::CurlCacheEntry::didFinishLoading): Ditto.
        (WebCore::CurlCacheEntry::openContentFile): Added method to open cache file.
        (WebCore::CurlCacheEntry::closeContentFile): Added method to close cache file.
        * platform/network/curl/CurlCacheEntry.h: Added file handle member, and methods to open and close cache file.

2014-05-20  Radu Stavila  <stavila@adobe.com>

        [CSS Regions] Block incorrectly sized when containing an unsplittable box
        https://bugs.webkit.org/show_bug.cgi?id=132601

        Reviewed by Antti Koivisto.

        When laying out elements in a region, when an inline element is encountered
        the size of its parent must not be increased beyond the bottom of the current region,
        unless if its the last region. This will ensure that the next sibling of the
        inline element is correctly laid out at the top of the next region, instead
        of leaving an empty space equal to the height of the overflow, as it did until now.

        Tests: fast/regions/inline-block-inside-anonymous-overflow.html
               fast/regions/inline-block-overflow.html

        * rendering/RenderBlockFlow.cpp:
        (WebCore::RenderBlockFlow::adjustLinePositionForPagination):
        (WebCore::RenderBlockFlow::hasNextPage):
        * rendering/RenderBlockFlow.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
        (WebCore::RenderBlockFlow::linkToEndLineIfNeeded):
        (WebCore::RenderBlockFlow::determineStartPosition):
        (WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):

2014-05-20  Mihnea Ovidenie  <mihnea@adobe.com>

        [CSS Regions] Crash while painting block selection gaps in regions
        https://bugs.webkit.org/show_bug.cgi?id=132720

        Reviewed by David Hyatt.

        The fix for WebKit bug https://bugs.webkit.org/show_bug.cgi?id=131511
        allowed selection highlight to match the DOM selection when the start
        and end point of the selection were in different flow threads. In order
        to enable that, the selection was performed separately on view and
        render flow threads, considered selection subtrees.

        However, the start and end points for each selection subtree were computed
        by means of Range class but it is not always possible to construct a valid
        Range from two pairs of RenderObjects and offsets.

        This patch keeps the substrees approach but instead of storing the endpoints
        for each subtree in a Range and continuously extending the Range, it stores them
        using the already available SelectionSubtreeRoot class. After the end points are
        computed for each subtree and before processing the subtree selection, the end points
        are adjusted in a similar fashion as the one used in FrameSelection::updateAppearance(),
        to make sure we are passing the same expected information to the method implementing
        the visible selection processing.

        Test: fast/regions/selection-gaps-paint-crash.html

        * rendering/RenderView.cpp:
        (WebCore::RenderView::splitSelectionBetweenSubtrees):
        * rendering/SelectionSubtreeRoot.cpp:
        (WebCore::SelectionSubtreeRoot::adjustForVisibleSelection):
        * rendering/SelectionSubtreeRoot.h:
        (WebCore::SelectionSubtreeRoot::selectionClear):

2014-05-19  Simon Fraser  <simon.fraser@apple.com>

        Scrolling pages with large TiledBacking content layers creates way too many tiles
        https://bugs.webkit.org/show_bug.cgi?id=133101

        Reviewed by Tim Horton.

        Fix the GraphicsLayerCA::adjustTiledLayerVisibleRect() logic to avoid making giant rects if the old
        and new visible rects don't overlap.

        * platform/graphics/TiledBacking.h:
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::adjustTiledLayerVisibleRect):
        * platform/graphics/ca/mac/TileController.h:

2014-05-19  Simon Fraser  <simon.fraser@apple.com>

        Correctly maintain the "isInWindow" state for all TiledBackings
        https://bugs.webkit.org/show_bug.cgi?id=133095

        Reviewed by Tim Horton.
        
        We never updated the "isInWindow" state for TiledBacking that wasn't the RenderView's
        backing. Fix it by having RenderLayerCompositor::setIsInWindow() recurse through all
        layers (if necessary), updating their state. Also set the state on newly created
        TiledBackings.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::layerTiledBackingUsageChanged):
        (WebCore::RenderLayerCompositor::setIsInWindowForLayerIncludingDescendants):
        (WebCore::RenderLayerCompositor::setIsInWindow):
        (WebCore::RenderLayerCompositor::pageTiledBacking): Deleted.
        * rendering/RenderLayerCompositor.h:

2014-05-19  Dean Jackson  <dino@apple.com>

        [iOS] Use status display for live streams
        https://bugs.webkit.org/show_bug.cgi?id=133097

        Reviewed by Sam Weinig.

        Follow-on from https://bugs.webkit.org/show_bug.cgi?id=131390
        Allow the iOS controls to use the status display field.

        * Modules/mediacontrols/mediaControlsiOS.js:
        (ControllerIOS.prototype.configureInlineControls): Live streams should
        not have a timeline or rewind button.

2014-05-19  Myles C. Maxfield  <litherum@gmail.com>

        Text decorations do not contribute to visual overflow
        https://bugs.webkit.org/show_bug.cgi?id=132773

        Reviewed by Antti Koivisto.

        This patch creates a function, visualOverflowForDecorations, which computes
        how much visual overflow to add around a text box due to text decorations. Most of the time,
        text decorations are fully contained within the text box, so the result is usually 0.

        This function exists within style/InlineTextBoxStyle.cpp, which is an added file. This is
        so that it can be called from setLogicalWidthForTextRun() inside RenderBlockLineLayout.cpp
        and from RenderStyle::changeAffectsVisualOverflow(). The former case passes in the full
        InlineTextBox and the latter case just passes in a RenderStyle (because the InlineTextBox
        is unavailable.)

        This patch also modifies RenderTableSection::spannedColumns() to fix an off-by-one error
        that was causing table borders to not be drawn when they existed right on the edge of
        a repaint rect.

        Tests: fast/css3-text/css3-text-decoration/repaint/underline-outside-of-layout-rect.html
        Tests: fast/repaint/border-collapse-table-off-by-one-expected.html

        * WebCore.vcxproj/WebCore.vcxproj: Adding reference to new InlineTextBoxStyle.cpp file
        * WebCore.vcxproj/WebCore.vcxproj.filters: Adding reference to new InlineTextBoxStyle files
        * WebCore.xcodeproj/project.pbxproj: Adding reference to new InlineTextBoxStyle files
        * rendering/InlineTextBox.cpp:
        (WebCore::computeUnderlineOffset): Moved to InlineTextBox.cpp
        (WebCore::getWavyStrokeParameters): Moved to InlineTextBox.cpp
        (WebCore::InlineTextBox::paintDecoration): Update to use newly refactored functions
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::setLogicalWidthForTextRun): Call visualOverflowForDecorations()
        * rendering/RenderTableSection.cpp:
        * rendering/RenderTableSelection.cpp: Fix off-by-one error when the boundary of a repaint
        rect lies exactly on top of a table column position
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::changeAffectsVisualOverflow): Inspects shadows and text decorations
        (WebCore::RenderStyle::changeRequiresLayout): Calls changeAffectsVisualOverflow()
        (WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline): Moved code from here
        to changeAffectsVisualOverflow().
        * rendering/style/RenderStyle.h: Function signature
        * style/InlineTextBoxStyle.cpp: Added.
        (WebCore::computeUnderlineOffset): Moved from InlineTextBox.cpp
        (WebCore::getWavyStrokeParameters): Moved from InlineTextBox.cpp
        (WebCore::extendIntToFloat): Convenience function for dealing with the fact that
        underline bounding boxes use floats and GlyphOverflow uses ints
        (WebCore::visualOverflowForDecorations): Given
        vertical overflow bounds, possibly extend those to include location of
        decorations.
        * style/InlineTextBoxStyle.h: Added. Function signatures.
        (WebCore::textDecorationStrokeThickness): Refactored from InlineTextBox.cpp
        (WebCore::wavyOffsetFromDecoration): Refactored from InlineTextBox.cpp
        * platform/graphics/Font.h:
        (WebCore::GlyphOverflow::isEmpty): Convenience function
        (WebCore::GlyphOverflow::extendTo): Convenience function

2014-05-19  Alex Christensen  <achristensen@webkit.org>

        Unreviewed build fix after r169082

        * platform/network/ResourceHandle.h:
        Added NSDictionary declaration.

2014-05-19  Beth Dakin  <bdakin@apple.com>

        REGRESSION: Standalone images need to take topContentInset into account
        https://bugs.webkit.org/show_bug.cgi?id=133092
        -and corresponding-
        <rdar://problem/16945791>

        Reviewed by Darin Adler.

        The FrameView’s size is accurate in terms of the NSWindow size, but that is not 
        really what the ImageDocument code is looking for here. The ImageDocument wants to 
        know the size of the unobscured viewport area. We should use visibleSize() for 
        that.
        * html/ImageDocument.cpp:
        (WebCore::ImageDocument::scale):
        (WebCore::ImageDocument::imageFitsInWindow):
        (WebCore::ImageDocument::imageClicked):

2014-05-19  Alex Christensen  <achristensen@webkit.org>

        Collect web timing data on iOS.
        https://bugs.webkit.org/show_bug.cgi?id=133075

        Reviewed by Sam Weinig.

        * platform/network/ResourceHandle.h:
        Added setCollectsTimingData wrapper and getConnectionTimingData declarations.
        getConnectionTimingData with a dictionary parameter is a private helper function.
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::start):
        Call setCollectsTimingData wrapper when creating a connection to ensure that timing data is collected.
        * platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
        (WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveResponseCallback):
        * platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:
        * platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
        (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
        * platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
        * platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
        (WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
        * platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:
        Pass the CFURLConnectionRef to didReceiveResponse to get timing data from.
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::getConnectionTimingData):
        Moved from getTimingData to compile regardless of using CFNetwork and added wrapper with CFDictionaryRef.
        (WebCore::ResourceHandle::setCollectsTimingData):
        Added wrapper to call objc function from c++.
        (WebCore::ResourceHandle::getTimingData):
        Renamed to getConnectionTimingData.
        * platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
        Updated function name from getTimingData to getConnectionTimingData.

2014-05-19  Chris Fleizach  <cfleizach@apple.com>

        AX: VoiceOver sees the WebArea out of order when topContentInset is used
        https://bugs.webkit.org/show_bug.cgi?id=133091

        Reviewed by Simon Fraser.

        Modify the scroll view's frame so that it recognizes the content inset.
        This is needed so that when VoiceOver sorts elements to create an ordering,
        the web area is not ordered at the top of the screen.

        Test: platform/mac-wk2/accessibility/content-inset-scrollview-frame.html

        * accessibility/AccessibilityScrollView.cpp:
        (WebCore::AccessibilityScrollView::elementRect):

2014-05-19  Beth Dakin  <bdakin@apple.com>

        Scrollbars display incorrectly after switching between fast and slow scrolling 
        mode, affects Find and real sites
        https://bugs.webkit.org/show_bug.cgi?id=133077
        -and corresponding-
        <rdar://problem/16888608>

        Reviewed by Tim Horton.

        We should always return true here when updating on the secondary thread is 
        supported. It does not need to be gated on whether we are actively taking 
        advantage of that support at this moment.
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::supportsUpdateOnSecondaryThread):

        Always update the presentationValue whenever we update the doubleValue just to 
        keep them in sync.
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar):

2014-05-19  Simon Fraser  <simon.fraser@apple.com>

        Split scrolling tree ScrollingNodes into FrameScrollingNodes and OverflowScrollingNodes
        https://bugs.webkit.org/show_bug.cgi?id=133022

        Reviewed by Sam Weinig.

        In both the scrolling state tree and the scrolling tree, split the "scrolling nodes"
        into FrameScrolling and OverflowScrolling nodes.
        
        Move what was the "viewportSize" property onto the base class for the scrolling
        nodes, calling it "scrollableAreaSize".
        
        Make minimum/maximumScrollPosition() virtual so we can share more code (and there
        is more code sharing to be done in future).

        * Configurations/WebCore.xcconfig: Remove ScrollingStateScrollingNodeMac.mm and ScrollingTreeScrollingNodeMac.mm
        from the list, using #ifdefs in the file instead.
        * WebCore.exp.in: Lots of exports.
        * WebCore.xcodeproj/project.pbxproj: New files.
        * page/scrolling/AsyncScrollingCoordinator.cpp:
        (WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
        (WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
        (WebCore::AsyncScrollingCoordinator::updateFrameScrollingNode):
        (WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode):
        (WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):
        (WebCore::AsyncScrollingCoordinator::updateScrollingNode): Deleted.
        (WebCore::AsyncScrollingCoordinator::setScrollbarPaintersFromScrollbarsForNode): Deleted.
        This tiny function didn't need to exist.
        * page/scrolling/AsyncScrollingCoordinator.h:
        * page/scrolling/ScrollingCoordinator.h:
        (WebCore::ScrollingCoordinator::updateFrameScrollingNode):
        (WebCore::ScrollingCoordinator::updateOverflowScrollingNode):
        (WebCore::ScrollingCoordinator::updateScrollingNode): Deleted.
        * page/scrolling/ScrollingStateFrameScrollingNode.cpp: Copied from Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp.
        (WebCore::ScrollingStateFrameScrollingNode::create):
        (WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
        (WebCore::ScrollingStateFrameScrollingNode::~ScrollingStateFrameScrollingNode):
        (WebCore::ScrollingStateFrameScrollingNode::clone):
        (WebCore::ScrollingStateFrameScrollingNode::setFrameScaleFactor):
        (WebCore::ScrollingStateFrameScrollingNode::setNonFastScrollableRegion):
        (WebCore::ScrollingStateFrameScrollingNode::setWheelEventHandlerCount):
        (WebCore::ScrollingStateFrameScrollingNode::setSynchronousScrollingReasons):
        (WebCore::ScrollingStateFrameScrollingNode::setScrollBehaviorForFixedElements):
        (WebCore::ScrollingStateFrameScrollingNode::setHeaderHeight):
        (WebCore::ScrollingStateFrameScrollingNode::setFooterHeight):
        (WebCore::ScrollingStateFrameScrollingNode::setTopContentInset):
        (WebCore::ScrollingStateFrameScrollingNode::setCounterScrollingLayer):
        (WebCore::ScrollingStateFrameScrollingNode::setInsetClipLayer):
        (WebCore::ScrollingStateFrameScrollingNode::setContentShadowLayer):
        (WebCore::ScrollingStateFrameScrollingNode::setHeaderLayer):
        (WebCore::ScrollingStateFrameScrollingNode::setFooterLayer):
        (WebCore::ScrollingStateFrameScrollingNode::setScrollbarPaintersFromScrollbars):
        (WebCore::ScrollingStateFrameScrollingNode::dumpProperties):
        * page/scrolling/ScrollingStateFrameScrollingNode.h: Copied from Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h.
        * page/scrolling/ScrollingStateNode.h:
        (WebCore::LayerRepresentation::layerID):
        (WebCore::ScrollingStateNode::isFrameScrollingNode):
        (WebCore::ScrollingStateNode::isOverflowScrollingNode):
        * page/scrolling/ScrollingStateOverflowScrollingNode.cpp: Added.
        (WebCore::ScrollingStateOverflowScrollingNode::create):
        (WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode):
        (WebCore::ScrollingStateOverflowScrollingNode::~ScrollingStateOverflowScrollingNode):
        (WebCore::ScrollingStateOverflowScrollingNode::clone):
        (WebCore::ScrollingStateOverflowScrollingNode::setScrolledContentsLayer):
        (WebCore::ScrollingStateOverflowScrollingNode::dumpProperties):
        * page/scrolling/ScrollingStateOverflowScrollingNode.h: Copied from Source/WebCore/page/scrolling/mac/ScrollingStateScrollingNodeMac.mm.
        (WebCore::ScrollingStateOverflowScrollingNode::scrolledContentsLayer):
        * page/scrolling/ScrollingStateScrollingNode.cpp:
        (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
        (WebCore::ScrollingStateScrollingNode::setScrollableAreaSize):
        (WebCore::ScrollingStateScrollingNode::setTotalContentsSize):
        (WebCore::ScrollingStateScrollingNode::dumpProperties):
        (WebCore::ScrollingStateScrollingNode::create): Deleted.
        (WebCore::ScrollingStateScrollingNode::clone): Deleted.
        (WebCore::ScrollingStateScrollingNode::setViewportSize): Deleted.
        (WebCore::ScrollingStateScrollingNode::setFrameScaleFactor): Deleted.
        (WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion): Deleted.
        (WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount): Deleted.
        (WebCore::ScrollingStateScrollingNode::setSynchronousScrollingReasons): Deleted.
        (WebCore::ScrollingStateScrollingNode::setScrollBehaviorForFixedElements): Deleted.
        (WebCore::ScrollingStateScrollingNode::setHeaderHeight): Deleted.
        (WebCore::ScrollingStateScrollingNode::setFooterHeight): Deleted.
        (WebCore::ScrollingStateScrollingNode::setTopContentInset): Deleted.
        (WebCore::ScrollingStateScrollingNode::setScrolledContentsLayer): Deleted.
        (WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer): Deleted.
        (WebCore::ScrollingStateScrollingNode::setInsetClipLayer): Deleted.
        (WebCore::ScrollingStateScrollingNode::setContentShadowLayer): Deleted.
        (WebCore::ScrollingStateScrollingNode::setHeaderLayer): Deleted.
        (WebCore::ScrollingStateScrollingNode::setFooterLayer): Deleted.
        (WebCore::ScrollingStateScrollingNode::setScrollbarPaintersFromScrollbars): Deleted.
        * page/scrolling/ScrollingStateScrollingNode.h:
        (WebCore::ScrollingStateScrollingNode::scrollableAreaSize):
        (WebCore::ScrollingStateScrollingNode::totalContentsSize):
        * page/scrolling/ScrollingStateTree.cpp:
        (WebCore::ScrollingStateTree::attachNode):
        (WebCore::ScrollingStateTree::commit):
        * page/scrolling/ScrollingStateTree.h:
        (WebCore::ScrollingStateTree::rootStateNode):
        (WebCore::ScrollingStateTree::setRootStateNode):
        * page/scrolling/ScrollingTree.cpp:
        (WebCore::ScrollingTree::commitNewTreeState):
        * page/scrolling/ScrollingTreeFrameScrollingNode.cpp: Added.
        (WebCore::ScrollingTreeFrameScrollingNode::ScrollingTreeFrameScrollingNode):
        (WebCore::ScrollingTreeFrameScrollingNode::~ScrollingTreeFrameScrollingNode):
        (WebCore::ScrollingTreeFrameScrollingNode::updateBeforeChildren):
        * page/scrolling/ScrollingTreeFrameScrollingNode.h: Copied from Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h.
        (WebCore::ScrollingTreeFrameScrollingNode::updateLayersAfterDelegatedScroll):
        (WebCore::ScrollingTreeFrameScrollingNode::synchronousScrollingReasons):
        (WebCore::ScrollingTreeFrameScrollingNode::shouldUpdateScrollLayerPositionSynchronously):
        (WebCore::ScrollingTreeFrameScrollingNode::frameScaleFactor):
        (WebCore::ScrollingTreeFrameScrollingNode::headerHeight):
        (WebCore::ScrollingTreeFrameScrollingNode::footerHeight):
        (WebCore::ScrollingTreeFrameScrollingNode::topContentInset):
        (WebCore::ScrollingTreeFrameScrollingNode::scrollBehaviorForFixedElements):
        * page/scrolling/ScrollingTreeNode.h:
        (WebCore::ScrollingTreeNode::isFrameScrollingNode):
        (WebCore::ScrollingTreeNode::isOverflowScrollingNode):
        * page/scrolling/ScrollingTreeOverflowScrollingNode.cpp: Copied from Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h.
        (WebCore::ScrollingTreeOverflowScrollingNode::ScrollingTreeOverflowScrollingNode):
        (WebCore::ScrollingTreeOverflowScrollingNode::~ScrollingTreeOverflowScrollingNode):
        * page/scrolling/ScrollingTreeOverflowScrollingNode.h: Copied from Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h.
        * page/scrolling/ScrollingTreeScrollingNode.cpp:
        (WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
        (WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
        (WebCore::ScrollingTreeScrollingNode::updateAfterChildren):
        (WebCore::ScrollingTreeScrollingNode::setScrollPosition):
        (WebCore::ScrollingTreeScrollingNode::setScrollPositionWithoutContentEdgeConstraints):
        (WebCore::ScrollingTreeScrollingNode::minimumScrollPosition):
        (WebCore::ScrollingTreeScrollingNode::maximumScrollPosition):
        * page/scrolling/ScrollingTreeScrollingNode.h:
        (WebCore::ScrollingTreeScrollingNode::scrollableAreaSize):
        (WebCore::ScrollingTreeScrollingNode::totalContentsSize):
        (WebCore::ScrollingTreeScrollingNode::totalContentsSizeForRubberBand):
        (WebCore::ScrollingTreeScrollingNode::setTotalContentsSizeForRubberBand):
        (WebCore::ScrollingTreeScrollingNode::synchronousScrollingReasons): Deleted.
        (WebCore::ScrollingTreeScrollingNode::shouldUpdateScrollLayerPositionSynchronously): Deleted.
        (WebCore::ScrollingTreeScrollingNode::viewportSize): Deleted.
        (WebCore::ScrollingTreeScrollingNode::frameScaleFactor): Deleted.
        (WebCore::ScrollingTreeScrollingNode::headerHeight): Deleted.
        (WebCore::ScrollingTreeScrollingNode::footerHeight): Deleted.
        (WebCore::ScrollingTreeScrollingNode::scrollBehaviorForFixedElements): Deleted.
        (WebCore::ScrollingTreeScrollingNode::topContentInset): Deleted.
        * page/scrolling/ios/ScrollingCoordinatorIOS.mm:
        (WebCore::ScrollingCoordinatorIOS::createScrollingTreeNode):
        * page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h: Renamed from Source/WebCore/page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h.
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::scrollLayer):
        * page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm: Renamed from Source/WebCore/page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm.
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::create):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::ScrollingTreeFrameScrollingNodeIOS):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::~ScrollingTreeFrameScrollingNodeIOS):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::updateBeforeChildren):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::updateAfterChildren):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::scrollPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::setScrollPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::setScrollPositionWithoutContentEdgeConstraints):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::setScrollLayerPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::updateLayersAfterViewportChange):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::updateLayersAfterDelegatedScroll):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::updateChildNodesAfterScroll):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::minimumScrollPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::maximumScrollPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::scrollBy):
        (WebCore::ScrollingTreeFrameScrollingNodeIOS::scrollByWithoutContentEdgeConstraints):
        * page/scrolling/mac/ScrollingCoordinatorMac.mm:
        (WebCore::ScrollingCoordinatorMac::createScrollingTreeNode):
        * page/scrolling/mac/ScrollingStateFrameScrollingNodeMac.mm: Renamed from Source/WebCore/page/scrolling/mac/ScrollingStateScrollingNodeMac.mm.
        (WebCore::ScrollingStateFrameScrollingNode::setScrollbarPaintersFromScrollbars):
        * page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h: Renamed from Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.h.
        * page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm: Renamed from Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm.
        (WebCore::ScrollingTreeFrameScrollingNodeMac::create):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::ScrollingTreeFrameScrollingNodeMac):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::updateAfterChildren):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::handleWheelEvent):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::allowsHorizontalStretching):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::allowsVerticalStretching):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::stretchAmount):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::pinnedInDirection):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::canScrollHorizontally):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::canScrollVertically):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::shouldRubberBandInDirection):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::absoluteScrollPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::immediateScrollBy):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::immediateScrollByWithoutContentEdgeConstraints):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::startSnapRubberbandTimer):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::stopSnapRubberbandTimer):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::adjustScrollPositionToBoundsIfNecessary):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::scrollPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollPositionWithoutContentEdgeConstraints):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::updateLayersAfterViewportChange):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::minimumScrollPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::maximumScrollPosition):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::scrollBy):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::scrollByWithoutContentEdgeConstraints):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::updateMainFramePinState):
        (WebCore::ScrollingTreeFrameScrollingNodeMac::logExposedUnfilledArea):
        (WebCore::logThreadedScrollingMode):
        (WebCore::logWheelEventHandlerCountChanged):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

2014-05-19  Simon Fraser  <simon.fraser@apple.com>

        Images missing sometimes with composited clipping layers
        https://bugs.webkit.org/show_bug.cgi?id=133065
        <rdar://problem/15224559>

        Reviewed by Beth Dakin.
        
        When support for solid colors on layers was added, a layer was considered a candidate
        for the solid color optimization without regard to whether it had descendent layers
        with "paintsIntoCompositedAncestor" requirements.
        
        Fix hasVisibleNonCompositingDescendantLayers(), renaming it to isPaintDestinationForDescendentLayers()
        and having it take into account whether descendent layers need to paint into an
        ancestor.
        
        Also, this test has to happen after those descendent layers have had their
        compositing state updated, so move the isSimpleContainerCompositingLayer() to
        a new updateAfterDescendents() function which is called from the various
        places we do compositing-udpate-tree-walks.

        Test: compositing/backing/solid-color-with-paints-into-ancestor.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGeometry):
        (WebCore::RenderLayerBacking::updateAfterDescendents):
        (WebCore::RenderLayerBacking::paintsChildren):
        (WebCore::compositedWithOwnBackingStore):
        (WebCore::descendentLayerPaintsIntoAncestor):
        (WebCore::RenderLayerBacking::isPaintDestinationForDescendentLayers):
        (WebCore::hasVisibleNonCompositingDescendant): Deleted.
        (WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers): Deleted.
        * rendering/RenderLayerBacking.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
        (WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
        (WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

2014-05-19  Zalan Bujtas  <zalan@apple.com>

        REGRESSION (r133351, sub-pixel layout): Right-to-left block with text-overflow: ellipsis truncates prematurely (breaks facebook.com Hebrew UI)
        https://bugs.webkit.org/show_bug.cgi?id=112227

        Reviewed by Maciej Stachowiak.

        This patch removes unnecessary integral snapping of inlines at layout time.

        The general rule of thumb of using round/floor/ceil at layout time is to not use them.
 
        When some computed values (x, y, width, height) get snapped during layout, while others don't,
        intersecting/measuring mismatches could occur and they could end up producing visual artifacts such as truncations.
        This patch also enables iframe content to be positioned on odd device pixel positions on retina displays.
        
        Tests: fast/frames/hidpi-position-iframe-on-device-pixel.html
               fast/inline/hidpi-rtl-text-does-not-fit-line-and-gets-cut-off.html

        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::logicalLeftOffsetForLine):
        (WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): Deleted.
        (WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine): Deleted.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::updateLogicalInlinePositions):
        (WebCore::RenderBlockFlow::deleteEllipsisLineBoxes):
        (WebCore::RenderBlockFlow::checkLinesForTextOverflow):

2014-05-18  Chris Fleizach  <cfleizach@apple.com>

        AX: iOS: using AXAttributeCacheEnabler is too slow for every accessibilityElementAtIndex:
        https://bugs.webkit.org/show_bug.cgi?id=133043

        Reviewed by Mario Sanchez Prada.

        iOS Accessibility code tries to improve performance by caching attributes when accessing
        elements through the platform API. However, those API calls can be used very frequently when 
        iterating elements. Creating the AXAttributeCacheEnabler object and tearing it down is proving
        to be the hottest code path in samples for accessibility access.

        We need to move the logic for enabling/disabling the attribute cache to a level that can make
        a more informed decision about when to enable/disable.

        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
        (-[WebAccessibilityObjectWrapper enableAttributeCaching]):
        (-[WebAccessibilityObjectWrapper disableAttributeCaching]):
        (-[WebAccessibilityObjectWrapper accessibilityElementCount]):
        (-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
        (-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):

2014-05-18  Simon Fraser  <simon.fraser@apple.com>

        Use RenderStyle& in more places in RenderLayerBacking
        https://bugs.webkit.org/show_bug.cgi?id=133061

        Reviewed by Andreas Kling.

        Convert several member functions to use references to RenderStyle rather
        than pointers. Move canCreateTiledImage() higher in the file (no code
        changes). Other minor cleanup.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
        (WebCore::RenderLayerBacking::updateOpacity):
        (WebCore::RenderLayerBacking::updateTransform):
        (WebCore::RenderLayerBacking::updateFilters):
        (WebCore::RenderLayerBacking::updateBlendMode):
        (WebCore::RenderLayerBacking::updateGeometry):
        (WebCore::hasBoxDecorations):
        (WebCore::canCreateTiledImage):
        (WebCore::hasBoxDecorationsOrBackgroundImage):
        (WebCore::hasPerspectiveOrPreserves3D):
        (WebCore::supportsDirectBoxDecorationsComposition):
        (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
        (WebCore::RenderLayerBacking::contentChanged):
        (WebCore::RenderLayerBacking::startTransition):
        * rendering/RenderLayerBacking.h:

2014-05-17  Simon Fraser  <simon.fraser@apple.com>

        Rename some RenderLayerBacking member functions
        https://bugs.webkit.org/show_bug.cgi?id=133030

        Reviewed by Sam Weinig.

        Remove "GraphicsLayer" from some member function names on RenderLayerBacking.
        
        No behavior change.

        * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
        (WebCore::AVFWrapper::createAVCFVideoLayer):
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateClipRects):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateAfterLayout):
        (WebCore::RenderLayerBacking::updateConfiguration):
        (WebCore::RenderLayerBacking::updateGeometry):
        (WebCore::RenderLayerBacking::contentChanged):
        (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Deleted.
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Deleted.
        * rendering/RenderLayerBacking.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateLayerCompositingState):
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
        (WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
        (WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
        (WebCore::RenderLayerCompositor::attachRootLayer):

2014-05-19  Antti Koivisto  <antti@apple.com>

        Fix assertion failure with simple line layout debug borders enabled.

        Rubber-stamped by Andreas Kling.

        * rendering/SimpleLineLayoutFunctions.cpp:
        (WebCore::SimpleLineLayout::paintDebugBorders): We shoudn't try to paint empty rects.

2014-05-18  Andreas Kling  <akling@apple.com>

        Reduce constructor copypasta in RenderText and RenderElement.
        <https://webkit.org/b/133056>

        Use delegating constructors to remove duplicated initializer lists
        from the constructors of RenderText and RenderElement.

        Reviewed by Anders Carlsson.

        * rendering/RenderElement.cpp:
        (WebCore::RenderElement::RenderElement):
        * rendering/RenderElement.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText):
        * rendering/RenderText.h:

2014-05-18  Brent Fulgham  <bfulgham@apple.com>

        Crash during scroll when latched
        https://bugs.webkit.org/show_bug.cgi?id=133064

        Reviewed by Simon Fraser.

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::platformPrepareForWheelEvents): Prevent dereference of NULL
        wheelEventTarget argument.

2014-05-18  Svetlana Redchenko  <redchenko@yandex-team.ru>

        Input ::selection pseudo class does not work leading to hidden selection
        https://bugs.webkit.org/show_bug.cgi?id=38943

        Reviewed by Darin Adler.

        Test: fast/selectors/input-with-selection-pseudo-element.html

        When text is selected inside input element, it should change the
        color and background color according to the ::selection pseudo element.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::selectionBackgroundColor):
        (WebCore::RenderObject::selectionColor):
        (WebCore::RenderObject::selectionPseudoStyle):
        * rendering/RenderObject.h:

2014-05-18  Sam Weinig  <sam@webkit.org>

        [WebKit2] Implement ScriptMessageHandlers
        https://bugs.webkit.org/show_bug.cgi?id=133053

        Reviewed by Anders Carlsson.

        * DerivedSources.make:
        * WebCore.exp.in:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::finishCreation):
        * bindings/js/JSUserMessageHandlersNamespaceCustom.cpp: Added.
        (WebCore::JSUserMessageHandlersNamespace::getOwnPropertySlotDelegate):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::shouldHaveWebKitNamespaceForWorld):
        (WebCore::DOMWindow::webkitNamespace):
        * page/DOMWindow.h:
        * page/UserContentController.cpp:
        (WebCore::UserContentController::addUserMessageHandlerDescriptor):
        (WebCore::UserContentController::removeUserMessageHandlerDescriptor):
        * page/UserContentController.h:
        (WebCore::UserContentController::userMessageHandlerDescriptors):
        * page/UserMessageHandler.cpp: Added.
        (WebCore::UserMessageHandler::UserMessageHandler):
        (WebCore::UserMessageHandler::~UserMessageHandler):
        (WebCore::UserMessageHandler::postMessage):
        (WebCore::UserMessageHandler::name):
        (WebCore::UserMessageHandler::world):
        * page/UserMessageHandler.h: Added.
        (WebCore::UserMessageHandler::create):
        * page/UserMessageHandler.idl: Added.
        * page/UserMessageHandlerDescriptor.cpp: Added.
        (WebCore::UserMessageHandlerDescriptor::UserMessageHandlerDescriptor):
        (WebCore::UserMessageHandlerDescriptor::~UserMessageHandlerDescriptor):
        (WebCore::UserMessageHandlerDescriptor::name):
        (WebCore::UserMessageHandlerDescriptor::world):
        * page/UserMessageHandlerDescriptor.h: Added.
        (WebCore::UserMessageHandlerDescriptor::Client::~Client):
        (WebCore::UserMessageHandlerDescriptor::create):
        (WebCore::UserMessageHandlerDescriptor::client):
        * page/UserMessageHandlerDescriptorTypes.h: Added.
        * page/UserMessageHandlersNamespace.cpp: Added.
        (WebCore::UserMessageHandlersNamespace::UserMessageHandlersNamespace):
        (WebCore::UserMessageHandlersNamespace::~UserMessageHandlersNamespace):
        (WebCore::UserMessageHandlersNamespace::handler):
        * page/UserMessageHandlersNamespace.h: Added.
        (WebCore::UserMessageHandlersNamespace::create):
        * page/UserMessageHandlersNamespace.idl: Added.
        * page/WebKitNamespace.cpp: Added.
        (WebCore::WebKitNamespace::WebKitNamespace):
        (WebCore::WebKitNamespace::~WebKitNamespace):
        (WebCore::WebKitNamespace::messageHandlers):
        * page/WebKitNamespace.h: Added.
        (WebCore::WebKitNamespace::create):
        * page/WebKitNamespace.idl: Added.

2014-05-18  Maciej Stachowiak  <mjs@apple.com>

        REGRESSION (r156546): Default media controls are laid out incorrectly when media element is styled with direction:rtl
        https://bugs.webkit.org/show_bug.cgi?id=132531
        <rdar://problem/16806267>
        
        Reviewed by Mark Rowe.

        This was already tested by the media/video-rtl.htm reftest, now unskipped.

        * Modules/mediacontrols/mediaControlsApple.css:
        (audio::-webkit-media-controls-panel): Add missing direction: ltr

2014-05-18  Rik Cabanier  <cabanier@adobe.com>

        support for navigator.hardwareConcurrency
        https://bugs.webkit.org/show_bug.cgi?id=132588

        Reviewed by Filip Pizlo.

        Added a new API that returns the number of CPU cores up to 8.

        Test: fast/dom/navigator-hardwareConcurrency.html

        * Configurations/FeatureDefines.xcconfig:
        * page/Navigator.cpp:
        (WebCore::Navigator::hardwareConcurrency):
        * page/Navigator.h:
        * page/Navigator.idl:

2014-05-18  Anders Carlsson  <andersca@apple.com>

        Fix iOS build.

        * WebCore.exp.in:
        Move UserContentController symbols to the right place.

2014-05-18  Jon Lee  <jonlee@apple.com>

        Build fix for r169006.

        Unreviewed.

        * loader/ResourceLoader.h: Return didCreateQuickLookHandle() to public.

2014-05-18  Antti Koivisto  <antti@apple.com>

        REGRESSION (r160259): text-combine glyphs are not rendered
        https://bugs.webkit.org/show_bug.cgi?id=127324

        Reviewed by Andreas Kling.
        
        The original text gets overwritten by a change that is supposed to affect rendered text only.
        Fixed by giving the text update functions well-defined purposes.

        Test: fast/text/text-combine-rendering.html

        * rendering/RenderCombineText.cpp:
        (WebCore::RenderCombineText::styleDidChange):
        (WebCore::RenderCombineText::setRenderedText):
        (WebCore::RenderCombineText::combineText):
        (WebCore::RenderCombineText::setTextInternal): Deleted.
        * rendering/RenderCombineText.h:
        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::computePreferredLogicalWidths):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::setRenderedText):
        
            This function now updates the rendered text but does not change the original.
            Get the original text by calling originalText().

        (WebCore::RenderText::setText):
        
            This the only place original text now changes.

        (WebCore::RenderText::setTextInternal): Deleted.
        
            Renamed to setRenderedText.

        * rendering/RenderText.h:
        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::setRenderedText):
        (WebCore::RenderSVGInlineText::setTextInternal): Deleted.
        * rendering/svg/RenderSVGInlineText.h:

2014-05-17  Maciej Stachowiak  <mjs@apple.com>

        Don't attempt to update id or name for nodes that are already removed
        https://bugs.webkit.org/show_bug.cgi?id=133041

        Reviewed by Sam Weinig.

        Tests: fast/dom/remove-element-with-id-that-was-inserted-on-DOMNodeRemoved.html
               fast/dom/remove-element-with-name-that-was-inserted-on-DOMNodeRemoved.html

        * dom/Element.cpp:
        (WebCore::Element::removedFrom): Skip updating ids and names for an element not
        in a treescope, as we already do for elements not in a document.

2014-05-17  Alexey Proskuryakov  <ap@apple.com>

        REGRESSION (NetworkProcess): Trying to use appcache fallback crashes in ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
        https://bugs.webkit.org/show_bug.cgi?id=133007
        <rdar://problem/13702706>

        appcache tests often fail on the Mac WebKit2 bot
        https://bugs.webkit.org/show_bug.cgi?id=82061

        Reviewed by Maciej Stachowiak.

        Covered by existing tests, which this patch enables.

        * WebCore.exp.in: Export ResourceLoader::cancel(const ResourceError&). It used
        to be virtual, but marking subclasses final has resulted in the compiler calling
        it directly from WebKitLegacy framework. Seeing that no subclass overrides it,
        I then made it non-virtual.
        Also export ApplicationCacheHost functions that are now used from WebKit2.

        * loader/ResourceLoader.h: Made the class abstract (as I didn't realize at first
        that it's always either a SubresourceLoader or a NetscapePlugInStreamLoader).
        Made ResourceHandleClient functions private, as they should never be called other
        than via a ResourceHandleClient pointer.

        * loader/NetscapePlugInStreamLoader.h:
        * loader/SubresourceLoader.h:
        Marked these final.

        * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSwitchToSubstituteResource):
        Added a function to be called when switching to a substitute resource. We still
        need a ResourceLoader at this point, as substitute resource will be delivered through
        it, but we don't want it to continue its current load.

        * loader/appcache/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache):
        Call the ResourceLoader function instead of using handle, which is null when
        using out of process networking.

2014-05-17  Andreas Kling  <akling@apple.com>

        We shouldn't make a ScrollingThread on iOS.
        <https://webkit.org/b/133038>
        <rdar://problem/16947589>

        Don't call ScrollingThred::dispatch() from the pressure relief
        code on iOS since that will end up instantiating a scrolling thread
        which we'd otherwise never have.

        Reviewed by Sam Weinig.

        * platform/MemoryPressureHandler.cpp:
        (WebCore::MemoryPressureHandler::releaseMemory):

2014-05-17  Piotr Grad  <p.grad@samsung.com>

        Setting playback rate on video with media controller is not ignored.
        https://bugs.webkit.org/show_bug.cgi?id=129048

        Reviewed by Jer Noble.

        Replaced queries for m_playbackRate with effectivePlaybackRate()
        which includes media controller playback rate.

        Test: media/video-controller-child-rate.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::parseAttribute):
        * html/HTMLMediaElement.h:

2014-05-16  Anders Carlsson  <andersca@apple.com>

        Expose WKUserScript as API
        https://bugs.webkit.org/show_bug.cgi?id=133017
        <rdar://problem/16948059>

        Reviewed by Sam Weinig.

        * WebCore.exp.in:
        Export symbols.

        * WebCore.xcodeproj/project.pbxproj:
        Change UserContentController.h to be a private header.

        * page/Page.cpp:
        (WebCore::Page::Page):
        Set m_userContentController from the page configuration and add it if it's not null.

        * page/Page.h:
        Add UserContentController to PageClients.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::addPage):
        Only try to add a user content controller if the page doesn't already have one.

        (WebCore::PageGroup::removePage):
        Only try to remove the user content controller if it's the group one.

2014-05-17  Andreas Kling  <akling@apple.com>

        REGRESSION (r166422): All RenderBox objects grew 104 bytes from adding repaint timers.
        <https://webkit.org/b/133027>
        <rdar://problem/16867410>

        Instead of storing a rarely-used repaint timer on every RenderBox, store one
        on the RenderView, and keep a hash set of renderers needing repaint.

        Renderers get a flag tracking whether they have a pending lazy repaint.
        This way we can avoid hash lookups in the common case.

        Also added a static assertion to catch RenderBox growing in the future.

        Reviewed by Antti Koivisto.

        * rendering/RenderBox.cpp:
        (WebCore::SameSizeAsRenderBox::~SameSizeAsRenderBox):
        (WebCore::RenderBox::RenderBox):
        (WebCore::RenderBox::~RenderBox):
        (WebCore::RenderBox::paintBoxDecorations):
        (WebCore::RenderBox::layoutOverflowRectForPropagation):
        * rendering/RenderBox.h:
        * rendering/RenderElement.cpp:
        (WebCore::RenderElement::RenderElement):
        * rendering/RenderElement.h:
        (WebCore::RenderElement::setRenderBoxNeedsLazyRepaint):
        (WebCore::RenderElement::renderBoxNeedsLazyRepaint):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView):
        (WebCore::RenderView::scheduleLazyRepaint):
        (WebCore::RenderView::unscheduleLazyRepaint):
        (WebCore::RenderView::lazyRepaintTimerFired):
        * rendering/RenderView.h:

2014-05-16  Jer Noble  <jer.noble@apple.com>

        [Mac][MSE] setCurrentTime() goes down fastSeek path in MediaPlayerPrivateMediaSourceAVFObjC.
        https://bugs.webkit.org/show_bug.cgi?id=133023

        Reviewed by Eric Carlson.

        When seeking a MSE video, do not go down the fastSeekForMediaTime() path if the
        seek resulted from a setCurrentTime() call. The logic can lead to attempted seeks
        before buffered ranges.

        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
        (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
        * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
        * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
        (WebCore::MediaSourcePrivateAVFObjC::seekToTime):

2014-05-16  Benjamin Poulain  <bpoulain@apple.com>

        [iOS] ScrollView::visibleContentRectInternal is bypassing the iOS code for unobscuredContentRect
        https://bugs.webkit.org/show_bug.cgi?id=133008

        Reviewed by Simon Fraser.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::visibleContentRectInternal):
        ScrollView::visibleContentRectInternal() was calling the internal implementation of visibleContentRect().
        That was skipping the iOS implementation and getting the framerect directly. That size is invalid on iOS
        when the exposed rect and unobscured rect are not the same.

2014-05-16  Jer Noble  <jer.noble@apple.com>

        [Mac] naturalSize not updated when preload=metadata
        https://bugs.webkit.org/show_bug.cgi?id=132994

        Reviewed by Eric Carlson.

        Test: media/video-load-preload-metadata-naturalsize.html

        When preload=metadata, we never create an AVPlayerItem, and therefore never receive a
        presentationSize KVO. When an AVAsset informs us that its tracks have changed, and there
        is no AVPlayerItem, recalculate presentation size based on the first video track's natural
        size.

        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
        (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

2014-05-16  Simon Fraser  <simon.fraser@apple.com>

        Remove "region-based columns" prefs
        https://bugs.webkit.org/show_bug.cgi?id=133006
        <rdar://problem/16945824>

        Reviewed by Dave Hyatt.

        Remove "region-based columns" prefs and related code, since this is only
        way to render columns now.

        * page/Settings.in:

2014-05-16  Antti Koivisto  <antti@apple.com>

        Link search area for touch events is too large in some cases
        https://bugs.webkit.org/show_bug.cgi?id=132988
        <rdar://problem/16917843>

        Reviewed by Simon Fraser.

        * page/ios/FrameIOS.mm:
        (WebCore::Frame::qualifyingNodeAtViewportLocation):
        
            - Adjust the search area to screen ppi.
            - Remove cut-off at scale 1. This made us pick physically far-away elements when zoomed in.
            
        * platform/PlatformScreen.h:
        * platform/ios/PlatformScreenIOS.mm:
        (WebCore::mobileGestaltFloatValue):
        (WebCore::screenPPIFactor):

            Figure out screens physical PPI relative to a base.

2014-05-16  Jer Noble  <jer.noble@apple.com>

        [MSE] Crash at  WebCore::SourceBuffer::~SourceBuffer + 110
        https://bugs.webkit.org/show_bug.cgi?id=132973

        Reviewed by Eric Carlson.

        Change SourceBuffer::m_private into a Ref<>, and add an assertion to
        SourceBufferPrivateAVFObjC's destructor if its client has not been cleared.

        Eliminate unnecessary churn in MediaSourcePrivateAVFObjC by having the predicate
        functor take bare pointers, rather than a PassRefPtr.

        The underlying problem seems to be in WebAVStreamDataParserListener. RefPtrs were
        being created off the main thread to a non-thread safe ref counted class. In some
        situations, this would result in double decrementing the ref, which would cause an
        early destruction of the underlying object. Instead replace these RefPtr strong
        pointers with explicit weak ones. Ensure the parser and its delegate are not freed
        before the append operation completes by passing strong pointers into the async
        append operation lambda.

        There were a few places where we weren't null checking m_mediaSource before using it,
        and at least one place where we weren't clearing m_mediaSource.

        * Modules/mediasource/SourceBuffer.cpp:
        (WebCore::SourceBuffer::SourceBuffer): Use Ref instead of RefPtr.
        (WebCore::SourceBuffer::appendBufferTimerFired): Ditto.
        * Modules/mediasource/SourceBuffer.h:
        * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
        (WebCore::MediaSourcePrivateAVFObjCHasAudio): Take a bare pointer, instead of a PassRefPtr.
        (WebCore::MediaSourcePrivateAVFObjCHasVideo): Ditto.
        * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
        (WebCore::MediaSourcePrivateAVFObjC::removeSourceBuffer): Clear the back pointer when removing a buffer.
        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
        (-[WebAVStreamDataParserListener initWithParser:parent:WebCore::]): Use WeakPtr instead of RefPtr.
        (-[WebAVStreamDataParserListener invalidate]): Ditto.
        (-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]): Ditto.
        (-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:withDiscontinuity:]): Ditto.
        (-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]): Ditto.
        (-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]): Ditto.
        (-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]): Ditto.
        (-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]): Ditto.
        (WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
        (WebCore::SourceBufferPrivateAVFObjC::append): Ditto.

2014-05-16  Zalan Bujtas  <zalan@apple.com>

        Subpixel rendering: Push named flows in region to device pixel when painting.
        https://bugs.webkit.org/show_bug.cgi?id=132986

        Reviewed by Simon Fraser.

        Remove integral rounding when named flow sets the painting offset on the graphics context.
        Use device pixel snapping instead to ensure that we can paint on odd device pixel positions on retina displays. 

        Test: fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateClipRects):

2014-05-16  Radu Stavila  <stavila@adobe.com>

        [CSS Regions] Add ASSERT to make sure using the flowThread cache does not return incorrect results
        https://bugs.webkit.org/show_bug.cgi?id=132906

        Reviewed by Simon Fraser.

        If flowThreadContainingBlock() is called on an object which is in a different
        flow thread than the one currently being laid out, this method will return an incorrect
        result. I added an assertion for that to make sure we catch and treat any such scenarios.
        For the moment, this assertion is only validated for regions, as multicol still has some issues.

        No new tests required.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::locateFlowThreadContainingBlockNoCache):
        (WebCore::RenderObject::locateFlowThreadContainingBlock):
        * rendering/RenderObject.h:

2014-05-16  Martin Hock  <mhock@apple.com>

        MemoryCache::addImageToCache should return the result of add().
        https://bugs.webkit.org/show_bug.cgi?id=132928
        <rdar://problem/16651547>

        Reviewed by Alexey Proskuryakov.

        API test: WebKit1.MemoryCacheADdImageToCache (MemoryCacheAddImageToCacheIOS.mm)

        * loader/cache/MemoryCache.cpp:
        (WebCore::MemoryCache::addImageToCache):

2014-05-16  Andrei Bucur  <abucur@adobe.com>

        [CSS Regions] Reduce the RenderRegion invasiveness in rendering code
        https://bugs.webkit.org/show_bug.cgi?id=132121

        Reviewed by Antti Koivisto.

        Remove the RenderRegion / RenderNamedFlowFragment parameters and fields from
        the painting / hit testing data structures and use a stateful approach to
        correctly handle regions.

        When painting or hit testing, the current flow thread is saved along the current
        region. They are accessed through the |currentRenderNamedFlowFragment| helper
        method on RenderObject or RenderLayer.

        The patch also changes a bunch of 0s to nullptrs.

        Tests: No new tests, no functional change.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
        * rendering/HitTestLocation.cpp:
        (WebCore::HitTestLocation::HitTestLocation):
        (WebCore::HitTestLocation::operator=):
        * rendering/HitTestLocation.h:
        (WebCore::HitTestLocation::region): Deleted.
        * rendering/HitTestResult.h:
        * rendering/PaintInfo.h:
        (WebCore::PaintInfo::PaintInfo):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::selectionGaps):
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::nodeAtPoint):
        (WebCore::RenderBox::paintBoxDecorations):
        (WebCore::RenderBox::pushContentsClip):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paint):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::paintLayerContents):
        (WebCore::RenderLayer::paintLayerByApplyingTransform):
        (WebCore::RenderLayer::collectFragments):
        (WebCore::RenderLayer::updatePaintingInfoForFragments):
        (WebCore::RenderLayer::paintTransformedLayerIntoFragments):
        (WebCore::RenderLayer::paintBackgroundForFragments):
        (WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
        (WebCore::RenderLayer::paintOutlineForFragments):
        (WebCore::RenderLayer::paintMaskForFragments):
        (WebCore::RenderLayer::hitTest):
        (WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::hitTestTransformedLayerInFragments):
        (WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
        (WebCore::RenderLayer::calculateClipRects):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateCompositedBounds):
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::addToOverlapMap):
        (WebCore::RenderLayerCompositor::clippedByAncestor):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::currentRenderNamedFlowFragment):
        * rendering/RenderObject.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::shouldPaint):
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::nodeAtPoint):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeLayers):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::paint):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paintReplaced):

2014-05-16  Kiran  <kiran.guduru@samsung.com>

        RTCDtmfSender default values need to be updated.
        https://bugs.webkit.org/show_bug.cgi?id=132952

        Reviewed by Eric Carlson.

        The default ToneDuration and ToneGap values are modified in the updated spec.
        So these values need to be updated.

        Test: fast/mediastream/RTCPeerConnection-dtmf.html.

        * Modules/mediastream/RTCDTMFSender.cpp:

2014-05-15  Daniel Bates  <dabates@apple.com>

        Attempt to fix the Apple Mavericks Release, Apple MountainLion Release,
        Apple MountainLion Release (32-bit Build), EFL, and GTK builds following
        <http://trac.webkit.org/changeset/168921> (https://bugs.webkit.org/show_bug.cgi?id=132669)

        * dom/ContainerNode.cpp: Include SVGElement.h for the definition of Node::hasTagName(const SVGQualifiedName&).

2014-05-15  Daniel Bates  <dabates@apple.com>

        ASSERT_NOT_REACHED() in DocumentOrderedMap::get() when removing SVG subtree
        https://bugs.webkit.org/show_bug.cgi?id=132669
        <rdar://problem/14931432>

        Reviewed by Brent Fulgham and Ryosuke Niwa.

        Fixes an assertion failure when removing an SVG element with a duplicate id.

        When removing an SVG element with id A we synchronously instruct each element that references A
        to find the first element with id A, call this N, from the document root and register itself to
        either receive subsequent notifications from N (say, there is another element with id A) or as
        waiting for an element with id A (say, N = nullptr; => we removed the last element with id A from
        the document). Because the elements that reference A perform this operation synchronously when
        removing an element they consult an transient state of the DocumentOrderedMap when querying for the
        element with id A.
    
        Without loss of generality, let E, E_1, E_2, and E_3 be elements, where E_1, E_2, E_3 are children
        of E in that order and E_1.id = E_2.id = A and E_3.href = #A (that is, it references an element
        with id A). Suppose we remove E then we remove E_1, update DocumentOrderedMap to decrement its count
        for id A, and notify E_3 to look for an element with id A. This leads to an assertion failure since
        DocumentOrderedMap expects to find an element with id A, E_2, but cannot find such an element when
        traversing from the document root because E was unlinked from the document root (i.e. E_2 is in a
        disjoint subtree).

        Tests: svg/custom/change-id-of-use-during-removal.html
               svg/custom/remove-subtree-including-path-with-duplicate-id-referenced-by-later-textpath.html
               svg/custom/remove-subtree-including-text-with-duplicate-id-referenced-by-later-tref.html
               svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-earlier-use.html
               svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-animate.html
               svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-feimage.html
               svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-mpath.html
               svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-use.html
               svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-later-use2.html
               svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-use-in-different-subtree.html
               svg/custom/remove-subtree-including-use-with-duplicate-id-referenced-by-use-with-duplicate-id-in-different-subtree.html
               svg/custom/remove-use-with-duplicate-id-referenced-by-later-use.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChild): Call SVGDocumentExtensions::rebuildElements() after we remove
        a DOM subtree so that applicable SVG elements can update their referenced element when the DocumentOrderedMap
        is in a stable-state.
        (WebCore::ContainerNode::removeChildren): Ditto.
        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::rebuildElements): Added; notifies SVG elements that their href attribute
        changed so that they query the DocumentOrderedMap for the element they reference by id in their href attribute.
        (WebCore::SVGDocumentExtensions::clearTargetDependencies): Added; Called from removing
        an SVG element S from the DOM. Appends all elements that reference the id of S to the end of a Vector of
        elements to be rebuilt (when SVGDocumentExtensions::rebuildElements() is called) and notifies these elements
        that have been marked to be rebuilt so that they can invalidate their state (e.g. stop animating).
        (WebCore::SVGDocumentExtensions::rebuildAllElementReferencesForTarget): Changed to take its argument by reference
        (since it's always non-null) and simplified logic to synchronously notify SVG updates that their referenced element
        may have changed. Calling SVGElement::svgAttributeChanged() on an element E should at most remove the dependencies
        of E.
        * svg/SVGDocumentExtensions.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::~SVGElement): Substitute "*this" for "this" as SVGDocumentExtensions::rebuildAllElementReferencesForTarget()
        now takes a reference instead of a pointer.
        (WebCore::SVGElement::removedFrom): Modified to call SVGDocumentExtensions::clearTargetDependencies().
        (WebCore::SVGElement::attributeChanged): Substitute "*this" for "this" as SVGDocumentExtensions::rebuildAllElementReferencesForTarget()
        now takes a reference instead of a pointer.
        * svg/SVGElement.h:
        (WebCore::SVGElement::callClearTarget): Added; calls through to private virtual SVGElement::clearTarget().
        (WebCore::SVGElement::clearTarget): Added.
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::clearTarget): Added.
        * svg/SVGTRefElement.h:
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::clearTarget): Added.
        * svg/animation/SVGSMILElement.h:

2014-05-15  Simon Fraser  <simon.fraser@apple.com>

        [iOS WK2] When zoomed, fixed elements jump at the start of a scroll, and jump back at the end.
        https://bugs.webkit.org/show_bug.cgi?id=132978
        <rdar://problem/16894428>

        Reviewed by Benjamin Poulain.

        This was the actual cause of the bug; r168560 changed the rect passed in here
        to be the customFixedPositionRect rather than the unobscured rect, but we
        used it to call FrameView::rectForViewportConstrainedObjects() which gave back
        another bogus rect. So just use the rect passed in.

        * page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:
        (WebCore::ScrollingTreeScrollingNodeIOS::updateLayersAfterViewportChange):

2014-05-15  Daniel Bates  <dabates@apple.com>

        SVG element may reference arbitrary DOM element before running its insertion logic
        https://bugs.webkit.org/show_bug.cgi?id=132757
        <rdar://problem/15703817>

        Reviewed by Ryosuke Niwa.

        Fixes an issue where an SVG element may reference an arbitrary DOM element e before e finished being
        inserted in the tree.

        Currently when an SVG element A is inserted into a document we use document.getElementById() to find the
        element B it references (if any). If A is inserted before B and B has the same id as a later element in
        the document then A can find B before B is notified that its been inserted into the document (i.e. before
        Element::insertedFrom() is called on B). Instead, A should call document.getElementById() only after
        cessation of the insertion operation that inserted it to ensure that all inserted nodes (including B)
        processed their insertion-specific logic.

        Tests: svg/custom/reparent-animate-element.html
               svg/custom/reparent-feimage-element.html
               svg/custom/reparent-mpath-element.html
               svg/custom/reparent-textpath-element.html
               svg/custom/reparent-tref-element.html
               svg/custom/reparent-use-element.html

        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
        we are called back to resolve our target element (i.e. call SVGFEImageElement::buildPendingResources())
        after the subtree we're in is inserted.
        (WebCore::SVGFEImageElement::didNotifySubtreeInsertions): Added; turns around and calls SVGFEImageElement::buildPendingResources().
        * svg/SVGFEImageElement.h:
        * svg/SVGMPathElement.cpp:
        (WebCore::SVGMPathElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
        we are called back to resolve our target element (i.e. call SVGMPathElement::buildPendingResources())
        after the subtree we're in is inserted.
        (WebCore::SVGMPathElement::didNotifySubtreeInsertions): Added; turns around and calls SVGMPathElement::buildPendingResources().
        * svg/SVGMPathElement.h:
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
        we are called back to resolve our target element (i.e. call SVGTRefElement::buildPendingResources())
        after the subtree we're in is inserted.
        (WebCore::SVGTRefElement::didNotifySubtreeInsertions): Added; turns around and calls SVGTRefElement::buildPendingResources().
        * svg/SVGTRefElement.h:
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
        we are called back to resolve our target element (i.e. call SVGTextPathElement::buildPendingResources())
        after the subtree we're in is inserted.
        (WebCore::SVGTextPathElement::didNotifySubtreeInsertions): Added; turns around and calls SVGTextPathElement::buildPendingResources().
        * svg/SVGTextPathElement.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
        we are called back to resolve our target element (i.e. call SVGUseElement::buildPendingResources()) after its subtree is
        inserted.
        (WebCore::SVGUseElement::didNotifySubtreeInsertions): Added; turns around and calls SVGUseElement::buildPendingResources().
        * svg/SVGUseElement.h:
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::insertedInto): Return InsertionShouldCallDidNotifySubtreeInsertions so that
        we are called back to resolve our target element (i.e. call SVGSMILElement::buildPendingResources())
        after the subtree we're in is inserted.
        (WebCore::SVGSMILElement::didNotifySubtreeInsertions): Added; turns around and calls SVGSMILElement::buildPendingResources().
        * svg/animation/SVGSMILElement.h:

2014-05-15  Mark Hahnenberg  <mhahnenberg@apple.com>

        JSDOMWindow should not claim HasImpureGetOwnPropertySlot
        https://bugs.webkit.org/show_bug.cgi?id=132918

        Reviewed by Geoffrey Garen.

        Tests: js/cached-window-properties.html
               js/cached-window-prototype-properties.html

        We now correctly handle the impurity of JSDOMWindow's custom getOwnPropertySlot without needing the 
        blanket HasImpureGetOwnPropertySlot. We do this through the use of watchpoints and by explicitly forbidding
        any caching beyond a certain point using PropertySlot::disableCaching. Getting rid of this flag will allow 
        us to cache many properties/methods on both the JSDOMWindow and its prototype, which are very commonly used 
        across the web.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::getOwnPropertySlot):
        * bindings/scripts/CodeGeneratorJS.pm:
        (HasComplexGetOwnProperty):
        (InterfaceRequiresAttributesOnInstance):
        (InstanceOverridesGetOwnPropertySlot):
        (GenerateHeader):

2014-05-15  Alexey Proskuryakov  <ap@apple.com>

        NetworkProcess crashes at ResourceHandle::continueDidReceiveResponse
        https://bugs.webkit.org/show_bug.cgi?id=132966
        <rdar://problem/16373694>

        Reviewed by Brady Eidson.

        Covered by many fast/files tests.

        * platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::continueDidReceiveResponse):
        * platform/network/BlobResourceHandle.h:
        * platform/network/ResourceHandle.h:
        Don't call delegate's continueDidReceiveResponse when loading a blob:// URL,
        the delegate is null. On the Mac, we used to lazily create it, which was also wrong,
        but at least not observable.

2014-05-15  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r168899.
        https://bugs.webkit.org/show_bug.cgi?id=132965

        Broke some compositing regions tests on Mavericks (Requested
        by mihnea___ on #webkit).

        Reverted changeset:

        "[CSS Regions] Reduce the RenderRegion invasiveness in
        rendering code"
        https://bugs.webkit.org/show_bug.cgi?id=132121
        http://trac.webkit.org/changeset/168899

2014-05-15  Alex Christensen  <achristensen@webkit.org>

        Add pointer lock to features without enabling it.
        https://bugs.webkit.org/show_bug.cgi?id=132961

        Reviewed by Sam Weinig.

        * Configurations/FeatureDefines.xcconfig:
        Added ENABLE_POINTER_LOCK to list of features.
        * WebCore.exp.in:
        Added linker symbols which differ with pointer lock enabled.
        * WebCore.xcodeproj/project.pbxproj:
        Added PointerLockController.cpp to build.

2014-05-15  Mark Hahnenberg  <mhahnenberg@apple.com>

        Move subframe name getter lookup later in JSDOMWindow::getOwnPropertySlot
        https://bugs.webkit.org/show_bug.cgi?id=132922

        Reviewed by Geoffrey Garen.

        No new tests.

        In JSDOMWindow::getOwnPropertySlot, we currently look for the property on the JSDOMWindow, 
        then we search the window's subframes for name getters, then we look in the window's prototype 
        chain. Apparently we were doing the lookup in this order to be compatible with Mozilla, but 
        Mozilla no longer implements this behavior. Instead, they do the lookup on the prototype before 
        looking for subframe name getters. We should change this to match Mozilla. This has the convenient 
        side effect of allowing us to cache lookups in the window's prototype chain.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::getOwnPropertySlot):

2014-05-15  Simon Fraser  <simon.fraser@apple.com>

        [UI-side compositing] Fix copying animations between layers, and pausing them
        https://bugs.webkit.org/show_bug.cgi?id=132943
        <rdar://problem/16906369&16906541>

        Reviewed by Tim Horton.

        Pass the animation key back to animationStarted(), though this isn't used
        when animations are running in-process.

        * platform/graphics/ca/PlatformCALayer.h:
        * platform/graphics/ca/mac/PlatformCALayerMac.h:
        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        (-[WebAnimationDelegate animationDidStart:]):
        (PlatformCALayerMac::animationStarted):
        * platform/graphics/ca/win/PlatformCALayerWin.cpp:
        (PlatformCALayerWin::animationStarted):
        * platform/graphics/ca/win/PlatformCALayerWin.h:

2014-05-15  Andrei Bucur  <abucur@adobe.com>

        [CSS Regions] Reduce the RenderRegion invasiveness in rendering code
        https://bugs.webkit.org/show_bug.cgi?id=132121

        Reviewed by Antti Koivisto.

        Remove the RenderRegion / RenderNamedFlowFragment parameters and fields from
        the painting / hit testing data structures and use a stateful approach to
        correctly handle regions.

        When painting or hit testing, the current flow thread is saved along the current
        region. They are accessed through the |currentRenderNamedFlowFragment| helper
        method on RenderObject or RenderLayer.

        The patch also changes a bunch of 0s to nullptrs.

        Tests: No new tests, no functional change.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
        * rendering/HitTestLocation.cpp:
        (WebCore::HitTestLocation::HitTestLocation):
        (WebCore::HitTestLocation::operator=):
        * rendering/HitTestLocation.h:
        (WebCore::HitTestLocation::region): Deleted.
        * rendering/HitTestResult.h:
        * rendering/PaintInfo.h:
        (WebCore::PaintInfo::PaintInfo):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::selectionGaps):
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::nodeAtPoint):
        (WebCore::RenderBox::paintBoxDecorations):
        (WebCore::RenderBox::pushContentsClip):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paint):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::paintLayerContents):
        (WebCore::RenderLayer::paintLayerByApplyingTransform):
        (WebCore::RenderLayer::collectFragments):
        (WebCore::RenderLayer::updatePaintingInfoForFragments):
        (WebCore::RenderLayer::paintTransformedLayerIntoFragments):
        (WebCore::RenderLayer::paintBackgroundForFragments):
        (WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
        (WebCore::RenderLayer::paintOutlineForFragments):
        (WebCore::RenderLayer::paintMaskForFragments):
        (WebCore::RenderLayer::hitTest):
        (WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::hitTestTransformedLayerInFragments):
        (WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
        (WebCore::RenderLayer::calculateClipRects):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateCompositedBounds):
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::addToOverlapMap):
        (WebCore::RenderLayerCompositor::clippedByAncestor):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::currentRenderNamedFlowFragment):
        * rendering/RenderObject.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::shouldPaint):
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::nodeAtPoint):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeLayers):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::paint):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paintReplaced):

2014-05-14  Simon Fraser  <simon.fraser@apple.com>

        Clean up "has non-zero begin time" terminology in animations
        https://bugs.webkit.org/show_bug.cgi?id=132942

        Reviewed by Tim Horton.

        Change the "non-zero beginTime" terminology in the platform CA animations
        code to "explicit beginTime": this flag really means that we explicitly set
        the beginTime of the animation, rather than let CA set the beginTime when
        committing the animation. This flag is used for animations with negative
        delay, and when pausing.
        
        The WKNonZeroBeginTimeFlag key was spread across PlatformCALayerMac and PlatformCAAnimationMac,
        so hide it behind getter/setter functions.
        
        Remove lots of m_layer.get() in PlatformCAAnimationMac.

        * platform/graphics/ca/mac/PlatformCAAnimationMac.h:
        * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
        (WebCore::hasExplicitBeginTime):
        (WebCore::setHasExplicitBeginTime):
        (PlatformCAAnimationMac::copy):
        (PlatformCAAnimationMac::keyPath):
        (PlatformCAAnimationMac::beginTime):
        (PlatformCAAnimationMac::setBeginTime):
        (PlatformCAAnimationMac::duration):
        (PlatformCAAnimationMac::setDuration):
        (PlatformCAAnimationMac::speed):
        (PlatformCAAnimationMac::setSpeed):
        (PlatformCAAnimationMac::timeOffset):
        (PlatformCAAnimationMac::setTimeOffset):
        (PlatformCAAnimationMac::repeatCount):
        (PlatformCAAnimationMac::setRepeatCount):
        (PlatformCAAnimationMac::autoreverses):
        (PlatformCAAnimationMac::setAutoreverses):
        (PlatformCAAnimationMac::fillMode):
        (PlatformCAAnimationMac::setFillMode):
        (PlatformCAAnimationMac::setTimingFunction):
        (PlatformCAAnimationMac::copyTimingFunctionFrom):
        (PlatformCAAnimationMac::isRemovedOnCompletion):
        (PlatformCAAnimationMac::setRemovedOnCompletion):
        (PlatformCAAnimationMac::isAdditive):
        (PlatformCAAnimationMac::setAdditive):
        (PlatformCAAnimationMac::valueFunction):
        (PlatformCAAnimationMac::setValueFunction):
        (hasNonZeroBeginTimeFlag): Deleted.
        (setNonZeroBeginTimeFlag): Deleted.
        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        (-[WebAnimationDelegate animationDidStart:]):

2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Compile all installed resources as GResources
        https://bugs.webkit.org/show_bug.cgi?id=131099

        Reviewed by Philippe Normand.

        * PlatformGTK.cmake: Do not install the resources.
        * platform/audio/gtk/AudioBusGtk.cpp:
        (WebCore::AudioBus::loadPlatformResource): Load the audio resource
        from GResources and use createBusFromInMemoryAudioFile().
        * platform/graphics/Image.h: Remove unsued function loadPlatformThemeIcon.
        * platform/graphics/gtk/ImageGtk.cpp:
        (WebCore::loadImageFromGResource): Load the given icon name from GResources.
        (WebCore::loadResourceSharedBuffer): Use char* instead of CString.
        (WebCore::loadMissingImageIconFromTheme): Try to load the missing
        icon from the current GTK icon theme.
        (WebCore::Image::loadPlatformResource): Call
        loadMissingImageIconFromTheme for missing icon or
        loadImageFromGResource for any other icon name.
        (WebCore::getPathToImageResource): Deleted.
        (WebCore::getThemeIconFileName): Deleted.
        (WebCore::loadImageFromFile): Deleted.
        (WebCore::Image::loadPlatformThemeIcon): Deleted.

2014-05-14  Beth Dakin  <bdakin@apple.com>

        Tiled scrolling indicator needs to take topContentInset into account
        https://bugs.webkit.org/show_bug.cgi?id=132940

        Reviewed by Simon Fraser.

        The tiled scrolling indicator needs to move down by the value of the 
        topContentInset. This patch makes that happen by caching the topContentInset in 
        the TileController. This does feel a little silly since there is already a 
        function called setTiledScrollingIndicatorPosition() on TiledBacking. However, it 
        was often the case that calling that function had no effect because m_coverageMap 
        had not yet been created, and then the information was lost. So instead, we cache 
        the value.

        Set TiledBacking’s copy of topContentInset whenever it changes for the FrameView.
        * page/FrameView.cpp:
        (WebCore::FrameView::topContentInsetDidChange):

        New function to set the inset. Use the inset to position the coverage map.
        * platform/graphics/TiledBacking.h:
        * platform/graphics/ca/mac/TileController.h:
        * platform/graphics/ca/mac/TileController.mm:
        (WebCore::TileController::TileController):
        (WebCore::TileController::setTopContentInset):

        When the coverage map is created, consult the value of the inset.
        * platform/graphics/ca/mac/TileCoverageMap.mm:
        (WebCore::TileCoverageMap::TileCoverageMap):

        Once the backing has been ensured, set the inset.
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateBacking):

2014-05-14  Brent Fulgham  <bfulgham@apple.com>

        Merge r1267628 from branch.
        <rdar://problem/15751219>

            Pratik Solanki  <psolanki@apple.com>

            Reviewed by Simon Fraser.",

            TileController relied on the tiling mode in TileCache to determine if it should use low-res
            tiles when zooming. Unfortunately, sometimes the tiling mode gets set to Zooming even though
            it's actually a pan. Thus we can end up with blurry tiles. Fix this by adding a new flag on
            TileCache that controls this behavior and have UIKit set it only when we have an actual zoom
            operation.
 
        * platform/ios/LegacyTileCache.h:
        (WebCore::LegacyTileCache::tileControllerShouldUseLowScaleTiles):
        (WebCore::LegacyTileCache::setTileControllerShouldUseLowScaleTiles):
        * platform/ios/LegacyTileCache.mm:
        (WebCore::LegacyTileCache::LegacyTileCache):
        * platform/ios/wak/WAKWindow.h:
        * platform/ios/wak/WAKWindow.mm:
        (-[WAKWindow setTileControllerShouldUseLowScaleTiles:]):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles):

2014-05-14  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r168750.
        https://bugs.webkit.org/show_bug.cgi?id=132935

        Caused repaint bugs (Requested by weinig on #webkit).

        Reverted changeset:

        "Text decorations do not contribute to visual overflow"
        https://bugs.webkit.org/show_bug.cgi?id=132773
        http://trac.webkit.org/changeset/168750

2014-05-14  Simon Fraser  <simon.fraser@apple.com>

        [New multicolumn] Spin in RenderMultiColumnSet::repaintFlowThreadContent()
        https://bugs.webkit.org/show_bug.cgi?id=132884

        Reviewed by Beth Dakin.

        On iOS, wikipedia pages can hang under RenderMultiColumnSet::repaintFlowThreadContent().
        It appears that computedColumnHeight is set to 0 in prepareForLayout, but layout never happens
        on the RenderMultiColumnSet in some cases, leaving the column height set to zero.
        This caused columnIndexAtOffset() to return bad values, which resulted in very long loops
        in repaintFlowThreadContent().
        
        This fix is a stop-gap.

        * rendering/RenderMultiColumnSet.cpp:
        (WebCore::RenderMultiColumnSet::columnIndexAtOffset):

2014-05-14  Benjamin Poulain  <bpoulain@apple.com>

        Remove FrameView::viewportConstrainedExtentRect, it is unused
        https://bugs.webkit.org/show_bug.cgi?id=132927

        Reviewed by Simon Fraser.

        * page/FrameView.cpp:
        (WebCore::FrameView::viewportConstrainedExtentRect): Deleted.
        * page/FrameView.h:
        Simon replaced this by viewportConstrainedVisibleContentRect, remove the old code.

2014-05-14  Matthew Hanson  <matthew_hanson@apple.com>

        Only define MAX_GRID_TRACK_REPETITIONS if CSS_GRID_LAYOUT is enabled.

        Reviewed by Dean Jackson.

        This was causing -Wunused-const-variable errors.

        * css/CSSParser.cpp: Add include guard.

2014-05-14  Beth Dakin  <bdakin@apple.com>

        Tile cache has way too many tiles when pinch-zoomed in
        https://bugs.webkit.org/show_bug.cgi?id=132929
        -and corresponding-
        <rdar://problem/16527172>

        Reviewed by Benjamin Poulain.

        This patch makes the margin sizing functions return the set margin size scaled by 
        the TileGrid's scale. We also need to get rid of the old notion we used to have
        that margin tiles might be allowed to have a different size than the other tiles. 
        We don't want that. They should have the normal margin size, but they should
        affect the overall coverage area.

        Scale by the TileGrid's scale.
        * platform/graphics/ca/mac/TileController.mm:
        (WebCore::TileController::topMarginHeight):
        (WebCore::TileController::bottomMarginHeight):
        (WebCore::TileController::leftMarginWidth):
        (WebCore::TileController::rightMarginWidth):

        Get rid of adjustRectAtTileIndexForMargin() since we do not want to ever do this 
        adjustment. Use tileSize instead of margin size for all sizing computations.
        * platform/graphics/ca/mac/TileGrid.h:
        * platform/graphics/ca/mac/TileGrid.mm:
        (WebCore::TileGrid::rectForTileIndex):
        (WebCore::TileGrid::getTileIndexRangeForRect):
        (WebCore::TileGrid::adjustRectAtTileIndexForMargin): Deleted.

2014-05-14  Dean Jackson  <dino@apple.com>

        [Mac] Search fields should not use centered look
        https://bugs.webkit.org/show_bug.cgi?id=132930
        <rdar://problem/16825842>

        Reviewed by Beth Dakin.

        We need to explicitly set the centeredLook property
        to NO on modern releases of Mac.

        * rendering/RenderThemeMac.mm: Declare a new private property and set it to NO.
        (WebCore::RenderThemeMac::search):

2014-05-14  Zalan Bujtas  <zalan@apple.com>

        Subpixel layout: Change Element.offset* client* scroll* return type to double.
        https://bugs.webkit.org/show_bug.cgi?id=132895

        Reviewed by Simon Fraser.

        This patch changes Element.offset*, Element.client* and Element.scroll* APIs return
        type from long to double to match the latest CSSOM View Module spec[1].
        Element.offset* and Element.client* do return subpixel values from now on.
        Element.scroll* still return integral values as the scrolling code hasn't adopted to subpixel rendering yet.

        subpixelCSSOMElementMetricsEnabled setting is added to be able to turn this feature on/off
        from WK2 preferences. It toggles the return value from subpixel to floored integral.
        It does not change layout/rendering behavior.

        Reference list of what other browsers do:
        IE: http://blogs.msdn.com/b/ie/archive/2012/02/17/sub-pixel-rendering-and-the-css-object-model.aspx
        Blink: http://www.chromestatus.com/features/5497402177880064
        Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=825607

        [1] http://www.w3.org/TR/2013/WD-cssom-view-20131217/

        Test: cssom/subpixel-offsetleft-top-width-height-values.html

        * dom/Element.cpp:
        (WebCore::localZoomForRenderer):
        (WebCore::adjustForLocalZoom):
        (WebCore::convertToNonSubpixelValueIfNeeded):
        (WebCore::Element::offsetLeft):
        (WebCore::Element::offsetTop):
        (WebCore::Element::offsetWidth):
        (WebCore::Element::offsetHeight):
        (WebCore::Element::clientLeft):
        (WebCore::Element::clientTop):
        (WebCore::Element::clientWidth):
        (WebCore::Element::clientHeight):
        (WebCore::Element::scrollLeft):
        (WebCore::Element::scrollTop):
        (WebCore::Element::setScrollLeft):
        (WebCore::Element::setScrollTop):
        (WebCore::Element::scrollWidth):
        (WebCore::Element::scrollHeight):
        * dom/Element.h:
        * dom/Element.idl:
        * html/HTMLBodyElement.cpp:
        (WebCore::adjustForZoom):
        (WebCore::HTMLBodyElement::scrollLeft):
        (WebCore::HTMLBodyElement::setScrollLeft):
        (WebCore::HTMLBodyElement::scrollTop):
        (WebCore::HTMLBodyElement::setScrollTop):
        (WebCore::HTMLBodyElement::scrollHeight):
        (WebCore::HTMLBodyElement::scrollWidth):
        * html/HTMLBodyElement.h:
        * page/Settings.in:

2014-05-14  Brady Eidson  <beidson@apple.com>

        Implement NSSharingServiceDelegate method "transitionImageForShareItem"
        <rdar://problem/16878020> and https://bugs.webkit.org/show_bug.cgi?id=132911

        Reviewed by Tim Horton.

        * WebCore.exp.in:
        * WebCore.xcodeproj/project.pbxproj:

2014-05-14  Alex Christensen  <achristensen@webkit.org>

        Another unreviewed build fix.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::getTimingData):
        Added necessary UNUSED_PARAMs.

2014-05-14  Alex Christensen  <achristensen@webkit.org>

        Unreviewed build fix after r168849.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::getTimingData):
        Protect use of timing data with ENABLE(WEB_TIMING).

2014-05-14  Alex Christensen  <achristensen@webkit.org>

        Refactor duplicate code in web timing.
        https://bugs.webkit.org/show_bug.cgi?id=132917

        Reviewed by Alexey Proskuryakov.

        * platform/network/ResourceHandle.h:
        Added getTimingData declaration.
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::getTimingData):
        * platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
        Moved duplicate code to ResourceHandle.

2014-05-14  Alex Christensen  <achristensen@webkit.org>

        Use references instead of pointers with ResourceLoadTiming.
        https://bugs.webkit.org/show_bug.cgi?id=132846

        Reviewed by Alexey Proskuryakov.

        * WebCore.exp.in:
        Removed ResourceResponseBase::setResourceLoadTiming linker symbol.
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceResponse):
        * page/PerformanceResourceTiming.cpp:
        (WebCore::PerformanceResourceTiming::domainLookupStart):
        (WebCore::PerformanceResourceTiming::domainLookupEnd):
        (WebCore::PerformanceResourceTiming::connectStart):
        (WebCore::PerformanceResourceTiming::connectEnd):
        (WebCore::PerformanceResourceTiming::secureConnectionStart):
        (WebCore::PerformanceResourceTiming::requestStart):
        Use references instead of pointers.
        * page/PerformanceResourceTiming.h:
        Make an instance instead of a RefPtr.
        * page/PerformanceTiming.cpp:
        (WebCore::PerformanceTiming::domainLookupStart):
        (WebCore::PerformanceTiming::domainLookupEnd):
        (WebCore::PerformanceTiming::connectStart):
        (WebCore::PerformanceTiming::connectEnd):
        (WebCore::PerformanceTiming::secureConnectionStart):
        (WebCore::PerformanceTiming::requestStart):
        (WebCore::PerformanceTiming::responseStart):
        Check to see if the loader exists, then use ResourceLoadTiming reference.
        (WebCore::PerformanceTiming::resourceLoadTiming): Deleted.
        * page/PerformanceTiming.h:
        Removed resourceLoadTiming declaration.
        * platform/network/ResourceLoadTiming.h:
        (WebCore::ResourceLoadTiming::ResourceLoadTiming):
        (WebCore::ResourceLoadTiming::operator=):
        Replaced reference counting with copy constructors.
        (WebCore::ResourceLoadTiming::create): Deleted.
        (WebCore::ResourceLoadTiming::deepCopy): Deleted.
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::copyData):
        (WebCore::ResourceResponseBase::resourceLoadTiming):
        (WebCore::ResourceResponseBase::setResourceLoadTiming):
        (WebCore::ResourceResponseBase::compare):
        * platform/network/ResourceResponseBase.h:
        * platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::didStartRequest):
        (WebCore::networkEventCallback):
        Use references instead of pointers.

2014-05-14  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r168837.
        https://bugs.webkit.org/show_bug.cgi?id=132913

        The patch added an assertion which fires on 6 tests (Requested
        by ap on #webkit).

        Reverted changeset:

        "[CSS Regions] Add ASSERT to make sure using the flowThread
        cache does not return incorrect results"
        https://bugs.webkit.org/show_bug.cgi?id=132906
        http://trac.webkit.org/changeset/168837

2014-05-13  Jon Honeycutt  <jhoneycutt@apple.com>

        Revert "Don't dispatch 'beforeload' event inside FrameView::layout()",
        commit 84fe8cf6fbe8b5de9a06300ca3ef6d0ffc96948c, and associated
        follow-up fixes:

            "platform/mac/plugins/testplugin-onnew-onpaint.html failing after
                r168668", commit c17be3bf5127baf94310af4b4b9bf5a57d29aaf4
            "[Win] Unreviewed build fix after r168668.", commit
                4fa470ad12c38ee7d4c114541b6dd321181a8bc9

        The original merged patch appears to have caused a regression in
        fast/dom/HTMLObjectElement/object-as-frame.html.

        <https://bugs.webkit.org/show_bug.cgi?id=132886>

        Reviewed by Alexey Proskuryakov.

        * WebCore.exp.in:
        * dom/Document.cpp:
        (WebCore::Document::updateLayoutIgnorePendingStylesheets):
        * dom/Document.h:
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::renderWidgetForJSBindings):
        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::reset):
        (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
        (WebCore::FrameView::performPostLayoutTasks):
        (WebCore::FrameView::updateEmbeddedObjectsTimerFired): Deleted.
        * page/FrameView.h:
        * testing/Internals.cpp:
        (WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks): Deleted.
        * testing/Internals.h:
        * testing/Internals.idl:

2014-05-14  Kiran  <kiran.guduru@samsung.com>

        alidation for getUserMedia() errorCallback is missing.
        https://bugs.webkit.org/show_bug.cgi?id=132901

        Reviewed by Darin Adler.

        The patch adds the validation for getUserMedia errorCallBack
        and throws TypeMismatchError.

        Test: fast/mediastream/getusermedia.html 

        * Modules/mediastream/NavigatorUserMedia.cpp:
        (WebCore::NavigatorUserMedia::webkitGetUserMedia):

2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>

        Remove CSS_STICKY_POSITION guards
        https://bugs.webkit.org/show_bug.cgi?id=132676

        Reviewed by Simon Fraser.

        * Configurations/FeatureDefines.xcconfig:
        * css/CSSParser.cpp:
        (WebCore::isValidKeywordPropertyAndValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EPosition):
        * css/CSSValueKeywords.in:
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::convertPositionStyle):

2014-05-14  Radu Stavila  <stavila@adobe.com>

        [CSS Regions] Add ASSERT to make sure using the flowThread cache does not return incorrect results
        https://bugs.webkit.org/show_bug.cgi?id=132906

        Reviewed by Andrei Bucur.

        If flowThreadContainingBlock() is called on an object which is in a different
        flow thread than the one currently being laid out, this method will return an incorrect
        result. I added an assertion for that to make sure we catch and treat any such scenarios.

        No new tests required.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::locateFlowThreadContainingBlockNoCache):
        (WebCore::RenderObject::locateFlowThreadContainingBlock):
        * rendering/RenderObject.h:

2014-05-14  Andrei Bucur  <abucur@adobe.com>

        [CSS Regions] Don't relayout when updating the region range unless necessary
        https://bugs.webkit.org/show_bug.cgi?id=132120

        Reviewed by Antti Koivisto.

        The patch reduces the cases when a relayout is made for boxes that change the region range.
        This lowers the amount of nested layouts in most cases and produces big layout speedups for trees
        without overhanging floats.

        Tests: Major performance improvement with speedups of 50-60% on:
        Layout/RegionsAuto.html, Layout/RegionsAutoMaxHeight.html and Layout/RegionsFixed.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateRegionRangeForBoxChild): Ask the child box if it needs a relayout
        in case its region range changes.
        * rendering/RenderBlockFlow.cpp:
        (WebCore::RenderBlockFlow::layoutBlockChild): It's not necessary to do two layouts here because
        there's no block direction position change between them for the child.
        (WebCore::RenderBlockFlow::needsLayoutAfterRegionRangeChange): If the block doesn't have floats
        or if it expands to enclose the floats it doesn't need to relayout after a region range chage.
        It's not possible for it to have a float inside overflow that must be repositioned using the new
        range.
        * rendering/RenderBlockFlow.h:
        * rendering/RenderBox.h:
        (WebCore::RenderBox::needsLayoutAfterRegionRangeChange): By default don't relayout after a region
        range change.

2014-05-14  Antti Koivisto  <antti@apple.com>

        RuleData should ref the StyleRule
        https://bugs.webkit.org/show_bug.cgi?id=132865

        Reviewed by Andreas Kling.

        As a defensive move make RuleData ref the StyleRule. 
        This adds some ref churn but the overall performance impact should be minimal.

        * css/RuleSet.h:
        (WebCore::RuleData::rule):

2014-05-14  Antti Koivisto  <antti@apple.com>

        GIF animations don't restart after scrolling on iOS WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=132900

        Reviewed by Andreas Kling.

        * WebCore.exp.in:

2014-05-13  Andrei Bucur  <abucur@adobe.com>

        [CSS Regions] Assertion failure in some cases with inline blocks
        https://bugs.webkit.org/show_bug.cgi?id=132859

        Reviewed by Mihnea Ovidenie.

        The patch hardens the conditions when the region range caches are
        populated to avoid desynchronizations when objects move during layout.
        This is true especially in the case of the boxes found inside
        inline blocks, that get their range from the containing line.

        There is a new function |computedRegionRangeForBox| that will always
        return a region range for a box using a best effort algorithm. This should
        be used only when there's no need to cache region information.

        This change also allows better control over the lifecycle of the
        |RenderBoxRegionInfo| objects stored on the regions. We can now iterate
        over the full range of the box when cleaning up the region box info. The
        same applies for the width change detection function.

        Test: fast/regions/inline-block-shifted-region.html

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlockFlow::updateRegionForLine): Don't set the containing
        region if the block doesn't have a range. The returned value would not
        be correctly clamped.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBlock::hasRegionRangeInFlowThread):
        * rendering/RenderBox.h:
        * rendering/RenderFlowThread.cpp:
        (WebCore::RenderFlowThread::removeRenderBoxRegionInfo): Iterate only over
        the range of the box, not from the start of the region chain.
        (WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock): Same as
        above.
        (WebCore::RenderFlowThread::hasCachedRegionRangeForBox):
        (WebCore::RenderFlowThread::getRegionRangeForBoxFromCachedInfo):
        (WebCore::RenderFlowThread::getRegionRangeForBox):
        (WebCore::RenderFlowThread::computedRegionRangeForBox): Best effort function
        to determine the range of a box. It will always return something as long
        as the flow thread has regions.
        (WebCore::RenderFlowThread::objectShouldFragmentInFlowRegion): Use the new function
        to determine the range.
        * rendering/RenderFlowThread.h:
        * rendering/RenderNamedFlowThread.cpp:
        (WebCore::RenderNamedFlowThread::absoluteQuadsForBox): Use the new function to determine
        the range.

2014-05-13  Simon Fraser  <simon.fraser@apple.com>

        Fix "ASSERTION FAILED: m_representation == PlatformLayerRepresentation" with UI-side compositing
        https://bugs.webkit.org/show_bug.cgi?id=132899

        Reviewed by Beth Dakin.

        Export some things

        * WebCore.exp.in:

2014-05-13  Hans Muller  <hmuller@adobe.com>

        [CSS Shapes] line height grows around polygon and incorrectly causes text to wrap to next line
        https://bugs.webkit.org/show_bug.cgi?id=131622

        Reviewed by Bem Jones-Bey.

        Corrected an earlier PolygonShape fix https://bugs.webkit.org/show_bug.cgi?id=132132
        When the top or bottom of a layout line is coincident with a polygon edge vertex, we
        only consider it an intersection if the edge extends into the line.

        Test: fast/shapes/shape-outside-floats/shape-outside-edge-case.html

        * rendering/shapes/PolygonShape.cpp:
        (WebCore::OffsetPolygonEdge::clippedEdgeXRange):

2014-05-13  Beth Dakin  <bdakin@apple.com>

        m_layerForOverhangAreas is sometimes not positioned correctly when topContentInset 
        has changed
        https://bugs.webkit.org/show_bug.cgi?id=132898
        -and corresponding-
        <rdar://problem/16644710>

        Reviewed by Anders Carlsson.

        This function is called whenever the topContentInset changes, so use it as an 
        opportunity to ensure that m_layerForOverhangAreas has been positioned correctly.
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::frameViewDidChangeSize):

        Everyone gets an anchor point!
        (WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

2014-05-13  Dean Jackson  <dino@apple.com>

        Attempted build fix after https://bugs.webkit.org/show_bug.cgi?id=132891

        * page/PageDebuggable.cpp:

2014-05-13  Timothy Hatcher  <timothy@apple.com>

        Force developerExtrasEnabled when a remote Inspector client connects.

        https://bugs.webkit.org/show_bug.cgi?id=132891

        Reviewed by Joseph Pecoraro.

        * page/PageDebuggable.cpp:
        (WebCore::PageDebuggable::PageDebuggable): Initialize m_forcedDeveloperExtrasEnabled to false.
        (WebCore::PageDebuggable::connect): Set m_forcedDeveloperExtrasEnabled if the setting is changed.
        (WebCore::PageDebuggable::disconnect): Switch developerExtrasEnabled back to false
        if m_forcedDeveloperExtrasEnabled is true.
        * page/PageDebuggable.h: Added m_forcedDeveloperExtrasEnabled.

2014-05-13  Beth Dakin  <bdakin@apple.com>

        REGRESSION (topContentInset): Searching through Facebook Messenger's chat causes 
        scrolling in News Feed
        https://bugs.webkit.org/show_bug.cgi?id=132889
        -and corresponding-
        <rdar://problem/16715716>

        Reviewed by Simon Fraser.

        First of all, scrollOffsetRelativeToDocument() was very poorly named. This patch 
        re-names it to the much more accurate documentScrollOffsetRelativeToViewOrigin(). 
        Re-naming it makes it clear that ONE call site was not getting the right offset. 
        That call site does not want to know the document’s position relative to the view 
        origin, but rather it wants to know the Document’s position relative to the 
        scrolling origin.

        Export new name.
        * WebCore.exp.in:

        Use newly re-named documentScrollPositionRelativeToViewOrigin().
        * page/FrameView.cpp:
        (WebCore::FrameView::convertToRenderer):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::documentScrollOffsetRelativeToViewOrigin):
        (WebCore::ScrollView::documentScrollPositionRelativeToViewOrigin):
        (WebCore::ScrollView::documentScrollOffsetRelativeToScrollableAreaOrigin):
        (WebCore::ScrollView::rootViewToContents):
        (WebCore::ScrollView::windowToContents):
        (WebCore::ScrollView::scrollOffsetRelativeToDocument): Deleted.
        (WebCore::ScrollView::scrollPositionRelativeToDocument): Deleted.
        * platform/ScrollView.h:

        THIS is the spot that needs the new function, 
        documentScrollOffsetRelativeToScrollableAreaOrigin()()
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):

2014-05-13  Dean Jackson  <dino@apple.com>

        [iOS] Page scale update messages for media controls should only fire at the end of zooming
        https://bugs.webkit.org/show_bug.cgi?id=132857
        <rdar://problem/16631009>

        Reviewed by Simon Fraser.

        As the user was zooming, the media controls that responded
        to the page scale (and resized themselves) would do so
        slightly out of sync with the screen refreshes, and it looked
        terrible. They really only need to get told at the end
        of the zoom that they need to relayout.

        Allow setPageScaleFactor to accept another parameter
        that indicates if the change is stable. That way, changes
        during a user triggers zoom gesture can be ignored for
        media controls.

        * WebCore.exp.in: Page::setPageScaleFactor takes a new parameter.
        * dom/Document.cpp:
        (WebCore::Document::pageScaleFactorChangedAndStable): Renamed from pageScaleFactorChanged.
        (WebCore::Document::pageScaleFactorChanged): Deleted.
        * dom/Document.h:
        * page/Page.cpp:
        (WebCore::Page::setPageScaleFactor): Accepts a new inStableState parameter,
        and tells the main frame that the scale factor has changed if it's stable.
        * page/Page.h:

2014-05-13  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed build fix after r168755.

        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):

2014-05-13  Eric Carlson  <eric.carlson@apple.com>

        [Mac] hasVideo should return true when video is ready to display
        https://bugs.webkit.org/show_bug.cgi?id=132885

        Reviewed by Jer Noble.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::parseAttribute):

        * platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
        (WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Don't change the
            enabled state of the AVPlayerItemTrack during setup.

        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
            m_cachedIsReadyForDisplay.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Remove "enabled" KVO observers.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Observe "readyForDisplay"
            change notifications.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): Remove for "readyForDisplay"
            observer.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): Return cached readyForDisplay
            state instead of polling every time.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Call setHasVideo(true) if the
            player layer is ready for display.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Update logging.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::firstFrameAvailableDidChange): Cache readyForDisplay
            state, call tracksChanged() if we haven't seen a video track yet.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::trackEnabledDidChange): New.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive): Correct logging.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange): Remove old "enabled" listeners
            before release tracks, add new ones to new tracks.
        (WebCore::assetTrackMetadataKeyNames): Add "enabled" to the list of properties we require to 
            be loaded before announcing that metadata has loaded.
        (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Observe 
            "readyForDisplay" and "enabled".

        * platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:
        (WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack): Don't change the
            enabled state of the AVPlayerItemTrack during setup.

2014-05-13  Myles C. Maxfield  <litherum@gmail.com>

        Text decorations do not contribute to visual overflow
        https://bugs.webkit.org/show_bug.cgi?id=132773

        Reviewed by Darin Adler.

        Tests: fast/css3-text/css3-text-decoration/repaint/underline-outside-of-layout-rect.html

        * rendering/InlineTextBox.cpp:
        (WebCore::textDecorationStrokeThickness): Refactor into a common function
        (WebCore::wavyOffsetFromDecoration): Ditto
        (WebCore::InlineText