Cleanup: Use exceptionless Range::* methods rather than ignoring exceptions.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2013-02-05  Mike West  <mkwst@chromium.org>
2
3         Cleanup: Use exceptionless Range::* methods rather than ignoring exceptions.
4         https://bugs.webkit.org/show_bug.cgi?id=108773
5
6         Reviewed by Darin Adler.
7
8         We often call Range::{start,end}{Container,Offset} with an ExceptionCode
9         that's completely ignored. In these cases, we should simply use the
10         exceptionless version of the method instead.
11
12         * dom/DocumentMarkerController.cpp:
13         (WebCore::DocumentMarkerController::addMarker):
14             Here, I also moved parameters onto one line to make the
15             stylebot happy.
16         (WebCore::DocumentMarkerController::addTextMatchMarker):
17         (WebCore::DocumentMarkerController::setMarkersActive):
18             Dropped ignored ExceptionCode variable entirely.
19         * accessibility/AccessibilityRenderObject.cpp:
20         (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
21             Can't drop the variable because of the selectNodeContents call.
22         * editing/Editor.cpp:
23         (WebCore::Editor::canDeleteRange):
24             Dropped ignored ExceptionCode variable entirely.
25         (WebCore::Editor::advanceToNextMisspelling):
26             Can't drop the variable because of setStart/setEnd.
27         * editing/EditorCommand.cpp:
28         (WebCore::unionDOMRanges):
29             Can't drop the variable because of compareBoundaryPoints.
30         * editing/MarkupAccumulator.cpp:
31         (WebCore::MarkupAccumulator::appendNodeValue):
32             Dropped ignored ExceptionCode variable entirely.
33         * editing/TextCheckingHelper.cpp:
34         (WebCore::TextCheckingParagraph::offsetAsRange):
35         (WebCore::TextCheckingHelper::findFirstMisspelling):
36         (WebCore::TextCheckingHelper::findFirstGrammarDetail):
37         (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
38         * editing/markup.cpp:
39         (WebCore::StyledMarkupAccumulator::renderedText):
40         (WebCore::StyledMarkupAccumulator::stringValueForRange):
41             Dropped ignored ExceptionCode variable entirely.
42         * editing/visible_units.cpp:
43         (WebCore::previousBoundary):
44             Can't drop the variable due to many other calls.
45         * page/DOMSelection.cpp:
46         (WebCore::DOMSelection::deleteFromDocument):
47         (WebCore::DOMSelection::containsNode):
48             For both these cases, the 'ASSERT(!ec)' after the statement I've
49             edited only checked the last occurance of the exception: that is,
50             if 'startXxx(ec)' threw an exception, it would be overwritten by
51             the 'setBaseAndExtend()' or 'compareBoundaryPoints()' exception.
52             Removing the exception parameters from the parameters' calls
53             shouldn't effect behavior.
54         * platform/chromium/PasteboardChromium.cpp:
55         (WebCore::Pasteboard::writeSelection):
56         * platform/mac/HTMLConverter.mm:
57         (+[WebHTMLConverter editingAttributedStringFromRange:]):
58         * platform/win/ClipboardWin.cpp:
59         (WebCore::ClipboardWin::writeRange):
60         * platform/win/PasteboardWin.cpp:
61         (WebCore::Pasteboard::writeSelection):
62         * platform/wince/PasteboardWinCE.cpp:
63         (WebCore::Pasteboard::writeSelection):
64             Dropped ignored ExceptionCode variable entirely.
65
66 2013-02-05  Yury Semikhatsky  <yurys@chromium.org>
67
68         Web Inspector:  introduce Memory.getDOMCounters
69         https://bugs.webkit.org/show_bug.cgi?id=108822
70
71         Reviewed by Pavel Feldman.
72
73         Introduced Memory.getDOMCounters command that returns number of Documents, Nodes
74         and JS event listeners in the inspected process.
75
76         * inspector/Inspector.json:
77         * inspector/InspectorMemoryAgent.cpp:
78         (WebCore::InspectorMemoryAgent::getDOMCounters):
79         (WebCore):
80         * inspector/InspectorMemoryAgent.h:
81         (InspectorMemoryAgent):
82
83 2013-02-04  Ilya Tikhonovsky  <loislo@chromium.org>
84
85         Web Inspector: Native Memory Instrumentation: rename Image m_data member to m_encodedImageData for the consistency
86         https://bugs.webkit.org/show_bug.cgi?id=108913
87
88         Reviewed by Yury Semikhatsky.
89
90         No new tests because no API changes.
91
92         * platform/graphics/Image.cpp:
93         (WebCore::Image::setData):
94         (WebCore::Image::reportMemoryUsage):
95         * platform/graphics/Image.h:
96         (WebCore::Image::data):
97         (Image):
98
99 2013-02-05  Hajime Morrita  <morrita@google.com>
100
101         Unreviewed Linux ASAN build fix for r141783.
102
103         * platform/RefCountedSupplement.h:
104         (Wrapper):
105         * platform/Supplementable.h:
106         (Supplement):
107
108 2013-02-05  Mike West  <mkwst@chromium.org>
109
110         [chromium] Unreviewed: Fix broken SVG-disabled build.
111         https://bugs.webkit.org/show_bug.cgi?id=108916
112
113         The new enum value CSSPropertyWebkitGridAutoFlow was introduced in
114         r141787, and accidentally left out of CSSParser::parseValue's big
115         switch. This causes problems in non-SVG builds.
116
117         * css/CSSParser.cpp:
118         (WebCore::CSSParser::parseValue):
119
120 2013-02-05  Tommy Widenflycht  <tommyw@google.com>
121
122         MediaStream API: Update RTCPeerConnections stream accessors to match the latest specification
123         https://bugs.webkit.org/show_bug.cgi?id=108179
124
125         Reviewed by Adam Barth.
126
127         http://dev.w3.org/2011/webrtc/editor/webrtc.html#interface-definition
128         The attributes localStreams and remoteStreams have been changes to the methods
129         getLocalStreams() and getRemoteStreams() which return a native array instead.
130
131         Existing tests updated to cover patch.
132
133         * CMakeLists.txt:
134         * GNUmakefile.list.am:
135         * Modules/mediastream/MediaStream.h:
136         (WebCore):
137         * Modules/mediastream/MediaStreamList.cpp: Removed.
138         * Modules/mediastream/MediaStreamList.h: Removed.
139         * Modules/mediastream/MediaStreamList.idl: Removed.
140         * Modules/mediastream/RTCPeerConnection.cpp:
141         (WebCore::RTCPeerConnection::RTCPeerConnection):
142         (WebCore::RTCPeerConnection::addStream):
143         (WebCore::RTCPeerConnection::removeStream):
144         (WebCore::RTCPeerConnection::getLocalStreams):
145         (WebCore::RTCPeerConnection::getRemoteStreams):
146         (WebCore::RTCPeerConnection::didAddRemoteStream):
147         (WebCore::RTCPeerConnection::didRemoveRemoteStream):
148         * Modules/mediastream/RTCPeerConnection.h:
149         (RTCPeerConnection):
150         * Modules/mediastream/RTCPeerConnection.idl:
151         * WebCore.gypi:
152
153 2013-02-05  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
154
155         [Qt][EFL][WebGL] Webgl doesn't work on nvidia cards
156         https://bugs.webkit.org/show_bug.cgi?id=108059
157
158         Reviewed by Kenneth Rohde Christiansen.
159
160         Commit r138327 fixed repainting issues on mesa3d GL library by re-binding
161         texture to the window after every glXSwapBuffer. Unfortunatelly re-bind
162         breaks rendering on NVidia cards with NVidia propiertary drivers.
163         This change limits texture re-binding only for mesa3d GL library.
164
165         No new tests. HW specific fix.
166
167         * platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
168         (WebCore::OffScreenRootWindow::isMesaGLX):
169         (OffScreenRootWindow):
170         (WebCore::GraphicsSurface::platformSwapBuffers):
171
172 2013-02-05  Praveen Jadhav  <praveen.j@samsung.com>
173
174         Floating point precision error in AudioPannerNode.
175         https://bugs.webkit.org/show_bug.cgi?id=106001
176
177         Reviewed by Kentaro Hara.
178
179         Specifications Update: 
180         https://dvcs.w3.org/hg/audio/rev/69a39a516e45
181
182         Conversion from double to float and back to double
183         results in precision error. Avoiding these conversions
184         will make sure that proper values are retained in the
185         parameters.
186
187         * Modules/webaudio/PannerNode.h:
188         (WebCore::PannerNode::refDistance):
189         (WebCore::PannerNode::setRefDistance):
190         (WebCore::PannerNode::maxDistance):
191         (WebCore::PannerNode::setMaxDistance):
192         (WebCore::PannerNode::rolloffFactor):
193         (WebCore::PannerNode::setRolloffFactor):
194         (WebCore::PannerNode::coneInnerAngle):
195         (WebCore::PannerNode::setConeInnerAngle):
196         (WebCore::PannerNode::coneOuterAngle):
197         (WebCore::PannerNode::setConeOuterAngle):
198         (WebCore::PannerNode::coneOuterGain):
199         (WebCore::PannerNode::setConeOuterGain):
200         * Modules/webaudio/PannerNode.idl:
201
202 2013-02-05  Kent Tamura  <tkent@chromium.org>
203
204         INPUT_MULTIPLE_FIELDS_UI: Use disabled attribute internally instead of readonly attribute
205         https://bugs.webkit.org/show_bug.cgi?id=108911
206
207         Reviewed by Kentaro Hara.
208
209         Use 'disabled' attribute for shadow elements for <input> with
210         multiple-fields UI instead of 'readonly' attribute because 'readonly'
211         attribute represents focusable-but-non-editable state in HTML though
212         we'd like to represent non-focusable-and-non-editable state.
213
214         The summary of changes:
215         - Use 'disabled' attribute instead of 'readonly' attribute for DateTimeFieldElement,
216         - Rename C++ functions for it,
217         - Call isFocusable instead of isReadOnly to check focusable state.
218
219         No new tests. This doesn't make user-visible behavior changes.
220
221         * css/html.css:
222         Replace [readonly] with [disabled] for sub-fields.
223         * html/shadow/DateTimeEditElement.cpp:
224         (DateTimeEditBuilder):
225         (WebCore::DateTimeEditBuilder::visitField):
226         (WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
227         (WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
228         (WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled):
229         (WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled):
230         (WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled):
231         (WebCore::DateTimeEditBuilder::shouldYearFieldDisabled):
232         (WebCore::DateTimeEditElement::anyEditableFieldsHaveValues):
233         (WebCore::DateTimeEditElement::focusOnNextField): Use isFocusable.
234         (WebCore::DateTimeEditElement::focusOnPreviousField): Use isFocusable.
235         * html/shadow/DateTimeFieldElement.cpp:
236         (WebCore::DateTimeFieldElement::isFocusable):
237         (WebCore::DateTimeFieldElement::isDisabled):
238         (WebCore::DateTimeFieldElement::setDisabled):
239         * html/shadow/DateTimeFieldElement.h:
240         (DateTimeFieldElement): Make isFocusable public in order that
241         DateTimeEditElement can call it.
242         * html/shadow/DateTimeNumericFieldElement.cpp:
243         (WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
244         (WebCore::DateTimeNumericFieldElement::setEmptyValue):
245         * html/shadow/DateTimeSymbolicFieldElement.cpp:
246         (WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
247
248 2013-02-05  Kentaro Hara  <haraken@chromium.org>
249
250         [V8] Reduce usage of deprecatedString() and deprecatedInteger()
251         https://bugs.webkit.org/show_bug.cgi?id=108909
252
253         Reviewed by Adam Barth.
254
255         By passing an Isolate parameter around, we can reduce usage of
256         deprecated methods.
257
258         No tests. No change in behavior.
259
260         * bindings/scripts/CodeGeneratorV8.pm:
261         (GenerateNormalAttrSetter):
262         (GenerateEventListenerCallback):
263         * bindings/scripts/test/V8/V8TestEventTarget.cpp:
264         (WebCore::TestEventTargetV8Internal::addEventListenerCallback):
265         (WebCore::TestEventTargetV8Internal::removeEventListenerCallback):
266         * bindings/scripts/test/V8/V8TestObj.cpp:
267         (WebCore::TestObjV8Internal::addEventListenerCallback):
268         (WebCore::TestObjV8Internal::removeEventListenerCallback):
269         * bindings/v8/IDBBindingUtilities.cpp:
270         (WebCore::get):
271         (WebCore::set):
272         (WebCore::getNthValueOnKeyPath):
273         (WebCore::canInjectNthValueOnKeyPath):
274         (WebCore::ensureNthValueOnKeyPath):
275         (WebCore::createIDBKeyFromScriptValueAndKeyPath):
276         (WebCore::injectIDBKeyIntoScriptValue):
277         (WebCore::canInjectIDBKeyIntoScriptValue):
278         * bindings/v8/NPV8Object.cpp:
279         (WebCore::createValueListFromVariantArgs):
280         (_NPN_Invoke):
281         (_NPN_InvokeDefault):
282         (_NPN_SetProperty):
283         (_NPN_Construct):
284         * bindings/v8/ScriptController.cpp:
285         (WebCore::ScriptController::compileAndRunScript):
286         * bindings/v8/ScriptProfiler.cpp:
287         (WebCore):
288         (WebCore::ScriptProfiler::takeHeapSnapshot):
289         * bindings/v8/ScriptSourceCode.cpp:
290         (WebCore::ScriptSourceCode::compileScript):
291         * bindings/v8/ScriptSourceCode.h:
292         (ScriptSourceCode):
293         * bindings/v8/V8LazyEventListener.cpp:
294         (WebCore::V8LazyEventListener::prepareListenerObject):
295         * bindings/v8/V8NPObject.cpp:
296         (WebCore::npObjectInvokeImpl):
297         (WebCore::npObjectGetProperty):
298         * bindings/v8/V8NPUtils.cpp:
299         (WebCore::convertNPVariantToV8Object):
300         * bindings/v8/V8NPUtils.h:
301         (WebCore):
302         * bindings/v8/V8Utilities.cpp:
303         (WebCore::createHiddenDependency):
304         (WebCore::removeHiddenDependency):
305         (WebCore::transferHiddenDependency):
306         * bindings/v8/V8Utilities.h:
307         (WebCore):
308         * bindings/v8/WorkerScriptController.cpp:
309         (WebCore::WorkerScriptController::evaluate):
310         * bindings/v8/custom/V8DOMWindowCustom.cpp:
311         (WebCore::V8DOMWindow::addEventListenerCallback):
312         (WebCore::V8DOMWindow::removeEventListenerCallback):
313
314 2013-02-04  Dean Jackson  <dino@apple.com>
315
316         [Mac] Captions menu should indicate language and type of track
317         https://bugs.webkit.org/show_bug.cgi?id=108882
318
319         Reviewed by Eric Carlson.
320
321         On Mac, we want a specific format for menu items in a caption list. Since
322         other ports might want different formats, move the generation of the label
323         into CaptionsUserPreferences where it can be overridden.
324
325         This required CaptionsUserPreferences to become public on the PageGroup, so
326         it could be used when creating the menu. Also, since CaptionsUserPreferences
327         was hidden on Mountain Lion and below, be a little more specific about
328         which pieces can be seen on which builds.
329
330         Covered by exisiting media/video-controls-captions-trackmenu tests.
331
332         * English.lproj/Localizable.strings: Remove textTrackClosedCaptionsText.
333         * html/shadow/MediaControlElements.cpp:
334         (WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Build only
335             one section and get the track's display name from the user preferences.
336         * page/CaptionUserPreferences.h:
337         (WebCore::CaptionUserPreferences::displayNameForTrack): Default implementation of
338             virtual function that provides a label for a captions menu item.
339         * page/CaptionUserPreferencesMac.h: Add the new virtual function, and expose just
340             a bit of this class outside 10.9 builds.
341         * page/CaptionUserPreferencesMac.mm:
342         (WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac): Guard features for system version.
343         (WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac): Ditto.
344         (WebCore::CaptionUserPreferencesMac::displayNameForTrack): New OS X-specific method that
345             returns a string for the menu label.
346         * page/PageGroup.cpp:
347         (WebCore::PageGroup::captionPreferences): Unguard for system version.
348         * page/PageGroup.h: Make captionPreferences public.
349         * platform/LocalizedStrings.cpp: Remove textTrackClosedCaptionsText - not needed any more.
350         * platform/LocalizedStrings.h: Remove textTrackClosedCaptionsText.
351
352 2013-02-04  Kentaro Hara  <haraken@chromium.org>
353
354         [V8] Pass an Isolate to V8DOMConfiguration
355         https://bugs.webkit.org/show_bug.cgi?id=108900
356
357         Reviewed by Adam Barth.
358
359         No tests. No change in behavior.
360
361         * bindings/scripts/CodeGeneratorV8.pm:
362         (GenerateHeader):
363         (GenerateImplementation):
364         (GenerateToV8Converters):
365         * bindings/scripts/test/V8/V8Float64Array.cpp:
366         (WebCore::ConfigureV8Float64ArrayTemplate):
367         (WebCore::V8Float64Array::createWrapper):
368         * bindings/scripts/test/V8/V8Float64Array.h:
369         (WebCore::V8Float64Array::installPerContextProperties):
370         * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
371         (WebCore::ConfigureV8TestActiveDOMObjectTemplate):
372         (WebCore::V8TestActiveDOMObject::createWrapper):
373         * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
374         (WebCore::V8TestActiveDOMObject::installPerContextProperties):
375         * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
376         (WebCore::ConfigureV8TestCustomNamedGetterTemplate):
377         (WebCore::V8TestCustomNamedGetter::createWrapper):
378         * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
379         (WebCore::V8TestCustomNamedGetter::installPerContextProperties):
380         * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
381         (WebCore::ConfigureV8TestEventConstructorTemplate):
382         (WebCore::V8TestEventConstructor::createWrapper):
383         * bindings/scripts/test/V8/V8TestEventConstructor.h:
384         (WebCore::V8TestEventConstructor::installPerContextProperties):
385         * bindings/scripts/test/V8/V8TestEventTarget.cpp:
386         (WebCore::ConfigureV8TestEventTargetTemplate):
387         (WebCore::V8TestEventTarget::createWrapper):
388         * bindings/scripts/test/V8/V8TestEventTarget.h:
389         (WebCore::V8TestEventTarget::installPerContextProperties):
390         * bindings/scripts/test/V8/V8TestException.cpp:
391         (WebCore::ConfigureV8TestExceptionTemplate):
392         (WebCore::V8TestException::createWrapper):
393         * bindings/scripts/test/V8/V8TestException.h:
394         (WebCore::V8TestException::installPerContextProperties):
395         * bindings/scripts/test/V8/V8TestInterface.cpp:
396         (WebCore::ConfigureV8TestInterfaceTemplate):
397         (WebCore::V8TestInterface::createWrapper):
398         * bindings/scripts/test/V8/V8TestInterface.h:
399         (WebCore::V8TestInterface::installPerContextProperties):
400         * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
401         (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
402         (WebCore::V8TestMediaQueryListListener::createWrapper):
403         * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
404         (WebCore::V8TestMediaQueryListListener::installPerContextProperties):
405         * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
406         (WebCore::ConfigureV8TestNamedConstructorTemplate):
407         (WebCore::V8TestNamedConstructor::createWrapper):
408         * bindings/scripts/test/V8/V8TestNamedConstructor.h:
409         (WebCore::V8TestNamedConstructor::installPerContextProperties):
410         * bindings/scripts/test/V8/V8TestNode.cpp:
411         (WebCore::ConfigureV8TestNodeTemplate):
412         (WebCore::V8TestNode::createWrapper):
413         * bindings/scripts/test/V8/V8TestNode.h:
414         (WebCore::V8TestNode::installPerContextProperties):
415         * bindings/scripts/test/V8/V8TestObj.cpp:
416         (WebCore::ConfigureV8TestObjTemplate):
417         (WebCore::V8TestObj::installPerContextProperties):
418         (WebCore::V8TestObj::createWrapper):
419         * bindings/scripts/test/V8/V8TestObj.h:
420         (V8TestObj):
421         * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
422         (WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
423         (WebCore::V8TestOverloadedConstructors::createWrapper):
424         * bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
425         (WebCore::V8TestOverloadedConstructors::installPerContextProperties):
426         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
427         (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
428         (WebCore::V8TestSerializedScriptValueInterface::createWrapper):
429         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
430         (WebCore::V8TestSerializedScriptValueInterface::installPerContextProperties):
431         * bindings/v8/V8DOMConfiguration.cpp:
432         (WebCore::V8DOMConfiguration::batchConfigureAttributes):
433         (WebCore::V8DOMConfiguration::batchConfigureConstants):
434         (WebCore::V8DOMConfiguration::batchConfigureCallbacks):
435         (WebCore::V8DOMConfiguration::configureTemplate):
436         * bindings/v8/V8DOMConfiguration.h:
437         (V8DOMConfiguration):
438         (WebCore::V8DOMConfiguration::configureAttribute):
439         * bindings/v8/V8DOMWindowShell.cpp:
440         (WebCore::V8DOMWindowShell::installDOMWindow):
441
442 2013-02-04  Kentaro Hara  <haraken@chromium.org>
443
444         [V8] Clean up CodeGeneratorV8.pm by introducing HasCustom{Getter,Setter,Method}
445         https://bugs.webkit.org/show_bug.cgi?id=108896
446
447         Reviewed by Adam Barth.
448
449         No tests. No change in generated code.
450
451         * bindings/scripts/CodeGeneratorV8.pm:
452         (GenerateHeader):
453         (HasCustomGetter):
454         (HasCustomSetter):
455         (HasCustomMethod):
456         (GetFunctionTemplateCallbackName):
457         (GenerateSingleBatchedAttribute):
458         (GenerateImplementation):
459         (RequiresCustomSignature):
460
461 2013-02-04  Kent Tamura  <tkent@chromium.org>
462
463         Fix crash by <select> type change on focus
464         https://bugs.webkit.org/show_bug.cgi?id=108830
465
466         Reviewed by Abhishek Arya.
467
468         Test: fast/forms/select/select-change-type-on-focus.html
469
470         * html/HTMLSelectElement.cpp:
471         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
472         focus() calls may change the renderer type.
473
474 2013-02-04  Kentaro Hara  <haraken@chromium.org>
475
476         [V8] Pass an Isolate to opaqueRootForGC()
477         https://bugs.webkit.org/show_bug.cgi?id=108886
478
479         Reviewed by Adam Barth.
480
481         No tests. No change in behavior.
482
483         * bindings/scripts/CodeGeneratorV8.pm:
484         (GenerateOpaqueRootForGC):
485         (GenerateHeader):
486         * bindings/v8/V8GCController.cpp:
487         (WebCore::V8GCController::opaqueRootForGC):
488         * bindings/v8/WrapperTypeInfo.h:
489         (WebCore):
490         (WebCore::WrapperTypeInfo::opaqueRootForGC):
491         * bindings/v8/custom/V8NodeListCustom.cpp:
492         (WebCore::V8NodeList::opaqueRootForGC):
493
494 2013-02-04  Wei James  <james.wei@intel.com>
495
496         Heap-buffer-overflow in WebCore::AudioBufferSourceNode::process
497         https://bugs.webkit.org/show_bug.cgi?id=108515
498
499         After calling setBuffer() with a buffer having a different number of
500         channels, there can in rare cases be a slight delay before the output
501         bus is updated to the new number of channels because of use of
502         tryLocks() in the context's updating system.
503         In this case, if the the buffer has just been changed and we're
504         not quite ready yet then just output silence.
505
506         Reviewed by Chris Rogers.
507
508         * Modules/webaudio/AudioBufferSourceNode.cpp:
509         (WebCore::AudioBufferSourceNode::process):
510         (WebCore::AudioBufferSourceNode::renderFromBuffer):
511
512 2013-02-04  James Simonsen  <simonjam@chromium.org>
513
514         [Chromium] Add a signal for when the body is inserted in the document
515         https://bugs.webkit.org/show_bug.cgi?id=108725
516
517         Reviewed by Adam Barth.
518
519         This is an important signal for resource scheduling. We know we have enough to paint something,
520         so we can start kicking off image preloads.
521
522         Test: Chromium webkit_unit_tests
523
524         * html/parser/HTMLConstructionSite.cpp:
525         (WebCore::HTMLConstructionSite::insertHTMLBodyElement):
526         * loader/FrameLoaderClient.h:
527         (FrameLoaderClient):
528         (WebCore::FrameLoaderClient::dispatchWillInsertBody):
529
530 2013-02-04  Benjamin Poulain  <bpoulain@apple.com>
531
532         Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals
533         https://bugs.webkit.org/show_bug.cgi?id=108741
534
535         Reviewed by Tony Chang.
536
537         Move suspendAnimations and resumeAnimations to group all the animation related
538         code together.
539
540         Add support for numberOfActiveAnimations, similarily to the feature previously defined
541         in TestRunner.
542
543         * testing/Internals.cpp:
544         (WebCore::Internals::numberOfActiveAnimations):
545         (WebCore):
546         (WebCore::Internals::suspendAnimations):
547         (WebCore::Internals::resumeAnimations):
548         * testing/Internals.h:
549         (Internals):
550         * testing/Internals.idl:
551
552 2013-02-04  Nayan Kumar K  <nayankk@motorola.com>
553
554         [WEBGL] Rename WEBKIT_WEBGL_compressed_texture_s3tc to WEBGL_compressed_texture_s3tc
555         https://bugs.webkit.org/show_bug.cgi?id=108866
556
557         Reviewed by Kenneth Russell.
558
559         WEBGL_compressed_texture_s3tc is one of the community approved WebGL extension.
560         Hence remove the vendor prefix from WEBKIT_WEBGL_compressed_texture_s3tc.
561         Specification: http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_s3tc/
562
563         No tests currently present to test WEBKIT_WEBGL_compressed_texture_s3tc.
564
565         * bindings/js/JSWebGLRenderingContextCustom.cpp:
566         (WebCore::toJS):
567         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
568         (WebCore::toV8Object):
569         * html/canvas/WebGLCompressedTextureS3TC.cpp:
570         (WebCore::WebGLCompressedTextureS3TC::getName):
571         * html/canvas/WebGLExtension.h:
572         * html/canvas/WebGLRenderingContext.cpp:
573         (WebCore):
574         (WebCore::WebGLRenderingContext::getExtension):
575
576 2013-02-04  Nayan Kumar K  <nayankk@motorola.com>
577
578         [WEBGL] Rename WEBKIT_WEBGL_lose_context to WEBGL_lose_context.
579         https://bugs.webkit.org/show_bug.cgi?id=108694
580
581         Reviewed by Kenneth Russell.
582
583         WEBGL_lose_context is one of the community approved WebGL extension.
584         Hence remove the vendor prefix from WEBKIT_WEBGL_lose_context extension.
585         Spefication: http://www.khronos.org/registry/webgl/extensions/WEBGL_lose_context/
586
587         Tests already exists, modified them to verify the change in extension name.
588
589         * bindings/js/JSWebGLRenderingContextCustom.cpp:
590         (WebCore::toJS):
591         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
592         (WebCore::toV8Object):
593         * html/canvas/WebGLExtension.h:
594         * html/canvas/WebGLLoseContext.cpp:
595         (WebCore::WebGLLoseContext::getName):
596         * html/canvas/WebGLRenderingContext.cpp:
597         (WebCore):
598         (WebCore::WebGLRenderingContext::getExtension):
599         (WebCore::WebGLRenderingContext::getSupportedExtensions):
600
601 2013-02-04  Dean Jackson  <dino@apple.com>
602
603         Default element styles are not always collected for sharing detection
604         https://bugs.webkit.org/show_bug.cgi?id=108404
605
606         Reviewed by Antti Koivisto.
607
608         The method ensureDefaultStyleSheetsForElement is run as we add elements
609         to the document. This may update the defaultStyle of the document, but
610         does not recollect any changes into the StyleResolver. This means that
611         style sharing might be overly ambitious, thinking it can share a style
612         for an element which was matched in the new rules. This showed up most
613         often in the Shadow Root for media elements, which would add a set of
614         style rules, but the shadow children would sometimes share styles even
615         when they shouldn't.
616
617         The fix is to detect if we need to collect after adding a
618         style for an element. This might cause a little more work, but
619         in my testing it doesn't happen very often.
620
621         Unfortunately it is hard to get a reproducible test for this.
622
623         * css/CSSDefaultStyleSheets.cpp:
624         (WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement): As we load in
625             styles, keep track of whether or not we change the default style.
626         * css/CSSDefaultStyleSheets.h:
627         (CSSDefaultStyleSheets): New boolean parameter indicating if the style has changed.
628         * css/StyleResolver.cpp:
629         (WebCore::StyleResolver::styleForElement): Collect features if the element
630             caused the default style to update.
631         (WebCore::StyleResolver::collectFeatures): Protect for null in updates.
632
633 2013-02-04  Jun Jiang  <jun.a.jiang@intel.com>
634
635         Fix the issue that some possible source formats are ignored for float textures in texture packing for CG port
636         https://bugs.webkit.org/show_bug.cgi?id=108812
637
638         Reviewed by Kenneth Russell.
639
640         Already covered by latest WebGL conformance test.
641
642         * platform/graphics/GraphicsContext3D.cpp:
643         (WebCore):
644
645 2013-02-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
646
647         [EFL] Remove needless local variables in LocalizedStringsEfl.cpp
648         https://bugs.webkit.org/show_bug.cgi?id=108869
649
650         Reviewed by Kentaro Hara.
651
652         fromUTF8() returns static String. So, we don't need to use needless local variables.
653
654         * platform/efl/LocalizedStringsEfl.cpp:
655         (WebCore::contextMenuItemTagCopy):
656         (WebCore::contextMenuItemTagDelete):
657         (WebCore::contextMenuItemTagSelectAll):
658         (WebCore::contextMenuItemTagGoBack):
659         (WebCore::contextMenuItemTagGoForward):
660         (WebCore::contextMenuItemTagStop):
661         (WebCore::contextMenuItemTagCut):
662         (WebCore::contextMenuItemTagPaste):
663         (WebCore::contextMenuItemTagBold):
664         (WebCore::contextMenuItemTagItalic):
665         (WebCore::contextMenuItemTagUnderline):
666
667 2013-02-04  Jun Jiang  <jun.a.jiang@intel.com>
668
669         WebGL: Move the format conversion for 16-bit per channel formats into Core Graphics port only
670         https://bugs.webkit.org/show_bug.cgi?id=108304
671
672         Reviewed by Kenneth Russell.
673
674         Since the 16-bit per channel formats are only used for Core Graphics port in WebGL and not a standard to represent any file format that is widely used 
675         for each platform, it is better to limit and hide this kinds of information and processing in CG specific code only. 
676         It can make the code more clear and reduce the binary size for both CG port and non-CG port.
677
678         Already covered by current tests.
679
680         * platform/graphics/GraphicsContext3D.cpp:
681         (WebCore):
682         * platform/graphics/GraphicsContext3D.h:
683         (GraphicsContext3D):
684         (WebCore::GraphicsContext3D::srcFormatComeFromDOMElementOrImageData):
685         (ImageExtractor):
686         * platform/graphics/cg/GraphicsContext3DCG.cpp:
687         (WebCore):
688         (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
689
690 2013-02-04  Dean Jackson  <dino@apple.com>
691
692         Allow TextTracks to be marked as closed captions
693         https://bugs.webkit.org/show_bug.cgi?id=108856
694
695         Reviewed by Darin Adler.
696
697         While this isn't exposed directly in markup, some platform media frameworks can
698         provide indication that a caption track is a closed caption. Expose such a flag
699         on TextTrack and platforms can show a different UI if they want to.
700
701         No tests - this isn't used elsewhere yet, nor exposed to the DOM.
702
703         * html/track/TextTrack.cpp:
704         (WebCore::TextTrack::TextTrack): Initialise new member.
705         * html/track/TextTrack.h:
706         (WebCore::TextTrack::isClosedCaptions): New member variable.
707         (WebCore::TextTrack::setIsClosedCaptions):
708
709 2013-02-04  Chris Hopman  <cjhopman@chromium.org>
710
711         Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
712         https://bugs.webkit.org/show_bug.cgi?id=107850
713
714         Reviewed by Ojan Vafai.
715
716         On Android, EditingBehavior::shouldMoveCaret[...] controls the
717         behavior of insertion handles. This change adds a new Android specific
718         editing behavior type.
719
720         The new EditingBehavior is the same as EditingUnixBehavior except for
721         EditingBehavior::shouldMoveCaret[...]. This new behavior fixes
722         WebFrame::moveCaretTowardsWindowPoint to not span to the
723         beginning/end.
724
725         * editing/EditingBehavior.h:
726         (WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
727         (WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
728         (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
729         * editing/EditingBehaviorTypes.h:
730         * page/Settings.cpp:
731         (WebCore):
732         (WebCore::editingBehaviorTypeForPlatform):
733         * testing/InternalSettings.cpp:
734         (WebCore::InternalSettings::setEditingBehavior):
735
736 2013-02-04  Kent Tamura  <tkent@chromium.org>
737
738         INPUT_MULTIPLE_FIELDS_UI: Focus order is not controllable by tabIndex attribute on <input>
739         https://bugs.webkit.org/show_bug.cgi?id=108447
740
741         Reviewed by Hajime Morita.
742
743         We make <input> elements with the multiple-fields UI focusable.
744          - However, we don't want to change the existing focus behavior for
745            multiple-fields <input>. We'd like to focus on the last sub-field of
746            an<input> with Shift + TAB focus navigation, and focus on the first
747            sub-field of the <input> otherwise. So, we move focus immediately
748            after the <input> gets focus.
749          - We don't need the isFocusableByClickOnLabel hack any more. <input>
750            elements with the multiple-fields UI are mouse-focusable.
751
752         Test: fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html
753
754         * html/InputType.h:
755         (InputType): Add FocusDirection argument to handleFocusEvent, and remove
756         unnecessary isFocusableByClickOnLabel and focus.
757         * html/InputType.cpp:
758         (WebCore::InputType::handleFocusEvent): Ditto.
759         * html/PasswordInputType.cpp:
760         (WebCore::PasswordInputType::handleFocusEvent): Follow the argument change.
761         * html/PasswordInputType.h:
762         (PasswordInputType): Ditto.
763
764         * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
765         (WebCore::BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent):
766         If this element gets focus by FocusDirectionBackward (it means the focus
767         is moved from the first sub-field of the element,) move the focus
768         backward once more. Otherwise, we focus on the first sub-filed of the
769         element.
770         (WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable):
771         Make this keyboard-focusable. We have a wrong test to ensure read-only
772         input does NOT get focus. We'll address it later.
773         (WebCore::BaseMultipleFieldsDateAndTimeInputType::isMouseFocusable):
774         Make this mouse-focusable.
775         * html/BaseMultipleFieldsDateAndTimeInputType.h:
776         (BaseMultipleFieldsDateAndTimeInputType):
777
778         * html/HTMLInputElement.h:
779         (HTMLInputElement): Remove defaultFocus, focus, and isFocusableByClickOnLabel.
780         Add missing OVERRIDE to handleFocusEvent.
781         * html/HTMLInputElement.cpp: Remove unnecessary functions.
782         (WebCore::HTMLInputElement::handleFocusEvent):
783         Pass FocusDirection value to InputTYpe::handleFocusEvent.
784
785         * html/HTMLLabelElement.cpp:
786         (WebCore::HTMLLabelElement::defaultEventHandler):
787         Use isMouseFocusable().
788         * html/HTMLElement.cpp: Remove unnecessary isFocusableByClickOnLabel.
789         * html/HTMLElement.h: Ditto.
790
791 2013-02-04  Seulgi Kim  <seulgikim@company100.net>
792
793         Coordinated Graphics: crash in TiledBackingStore::adjustForContentsRect
794         https://bugs.webkit.org/show_bug.cgi?id=107639
795
796         Reviewed by Kenneth Rohde Christiansen.
797
798         In TiledBackingStore::adjustForContentsRect method, inflating is not
799         needed when there is no intersections between the cover/keep rect and
800         the content rect.
801
802         No new tests, no change in functionality.
803
804         * platform/graphics/TiledBackingStore.cpp:
805         (WebCore::TiledBackingStore::adjustForContentsRect):
806
807 2013-02-04  Stephen White  <senorblanco@chromium.org>
808
809         [skia] Remove use of SkSingleInputImageFilter.
810         https://bugs.webkit.org/show_bug.cgi?id=108867
811
812         Reviewed by James Robinson.
813
814         This class is but a hollow shell of its former self, and has
815         been removed in Skia.
816
817         Covered by existing tests in css3/filters.
818
819         * platform/graphics/filters/skia/DropShadowImageFilter.cpp:
820         (WebCore::DropShadowImageFilter::DropShadowImageFilter):
821         (WebCore::DropShadowImageFilter::onFilterImage):
822         * platform/graphics/filters/skia/DropShadowImageFilter.h:
823
824 2013-01-31  Kentaro Hara  <haraken@chromium.org>
825
826         Implement WheelEvent::deltaMode
827         https://bugs.webkit.org/show_bug.cgi?id=108455
828
829         Reviewed by Adam Barth.
830
831         Per the spec, WheelEvent::deltaMode should return
832         DOM_DELTA_PIXEL or DOM_DELTA_LINE or DOM_DELTA_PAGE.
833
834         Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents
835         https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent
836
837         Test: fast/event/wheel-event-constructor.html
838
839         * dom/WheelEvent.cpp:
840         (WebCore::WheelEventInit::WheelEventInit):
841         (WebCore::WheelEvent::WheelEvent):
842         (WebCore::WheelEvent::initWheelEvent):
843         (WebCore::deltaMode):
844         * dom/WheelEvent.h:
845         (WheelEventInit):
846         (WebCore::WheelEvent::create):
847         (WebCore::WheelEvent::deltaMode):
848         (WheelEvent):
849         * dom/WheelEvent.idl:
850         * page/EventHandler.cpp:
851         (WebCore::wheelGranularityToScrollGranularity):
852
853 2013-02-04  Gustavo Noronha Silva  <gns@gnome.org>
854
855         [Soup] Remove duplicate setting of first party for cookies
856         https://bugs.webkit.org/show_bug.cgi?id=108814
857
858         Reviewed by Martin Robinson.
859
860         Covered by existing tests.
861
862         * platform/network/soup/ResourceHandleSoup.cpp:
863         (WebCore::createSoupMessageForHandleAndRequest): there is no need to set
864         the first party for cookies here, since that is already done in
865         ResourceRequest::updateSoupMessage, which is called a few lines before.
866
867 2013-02-04  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
868
869         [GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
870         https://bugs.webkit.org/show_bug.cgi?id=105552
871
872         Reviewed by Philippe Normand.
873
874         Makes it possible for the GStreamer media backend to provide the buffer to which
875         the Soup networking backend will use to download data to. This makes copying
876         memory unnecessary when ResourceHandle hands data over to the media player's
877         StreamingClient. Thanks to Dan Winship for help designing the interface.
878
879         No behaviour change, covered by existing tests.
880
881         * platform/graphics/gstreamer/GStreamerVersioning.cpp:
882         (createGstBufferForData): New helper to create a GstBuffer when
883         we have a data pointer and a length.
884         (getGstBufferSize): Abstract obtaining the size of the buffer, so the code
885         is cleaner while still working for both GST 0.10 and 1.0.
886         (setGstBufferSize): Ditto, but for setting the size.
887         (getGstBufferDataPointer): Ditto, but for grabbing the data pointer.
888         (mapGstBuffer): Convenience method to take care of mapping the buffer so that
889         we can provide the data pointer to ResourceHandle.
890         (unmapGstBuffer): Convenience method which takes care of unmapping the buffer
891         and properly freeing the GstMapInfo.
892         * platform/graphics/gstreamer/GStreamerVersioning.h:
893         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
894         (StreamingClient): New methods.
895         (_WebKitWebSrcPrivate): We now store the GstBuffer we provided the data pointer from
896         so we can later unmap it and push it to the pipeline.
897         (webKitWebSrcDispose): Deal with the GstBuffer in case it exists when the source is
898         destroyed.
899         (webKitWebSrcStop): Also clear the GstBuffer in this case.
900         (StreamingClient::didReceiveData): Handle the hand-over of the buffer.
901         (StreamingClient::getBuffer): Provide ResourceHandle with a new GstBuffer's data pointer.
902         * platform/network/ResourceHandleClient.h:
903         (ResourceHandleClient):
904         (WebCore::ResourceHandleClient::ResourceHandleClient): Constructor to initialize the buffer
905         member variable to 0.
906         (WebCore::ResourceHandleClient::~ResourceHandleClient): Destructor to free the buffer if it
907         has been allocated.
908         (WebCore::ResourceHandleClient::getBuffer): Default implementation which returns a
909         newly allocated char pointer.
910         * platform/network/ResourceHandleInternal.h:
911         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
912         (ResourceHandleInternal): Store actual buffer size, which is no longer a constant.
913         * platform/network/soup/ResourceHandleSoup.cpp:
914         (WebCore::cleanupSoupRequestOperation): Clear the buffer pointer, the life-cycle of the
915         buffer is handled by the ResourceHandleClient.
916         (WebCore::nextMultipartResponsePartCallback): Get a new buffer from the client before reading.
917         (WebCore::sendRequestCallback): Ditto.
918         (WebCore::readCallback): Ditto.
919
920 2013-02-04  Mark Pilgrim  <pilgrim@chromium.org>
921
922         [Chromium] Move WorkerContextProxy to WebCore
923         https://bugs.webkit.org/show_bug.cgi?id=108847
924
925         Reviewed by Adam Barth.
926
927         Part of a larger refactoring series; see tracking bug 106829.
928
929         * WebCore.gyp/WebCore.gyp:
930         * WebCore.gypi:
931         * workers/chromium: Added.
932         * workers/chromium/WorkerContextProxyChromium.cpp: Added.
933         (WebCore):
934         (WebCore::setWorkerContextProxyCreateFunction):
935         (WebCore::WorkerContextProxy::create):
936         * workers/chromium/WorkerContextProxyChromium.h: Added.
937         (WebCore):
938
939 2013-02-04  Dima Gorbik  <dgorbik@apple.com>
940
941         WebVTT <i>, <b> and <u> elements should have default styles
942         https://bugs.webkit.org/show_bug.cgi?id=107214
943
944         Reviewed by Darin Adler.
945
946         Added default styles for basic webvtt object types.
947
948         Test: media/track/track-css-matching-default.html
949
950         * css/mediaControls.css:
951         (video::-webkit-media-text-track-container b):
952         (video::-webkit-media-text-track-container u):
953         (video::-webkit-media-text-track-container i):
954
955 2013-02-04  Abhishek Arya  <inferno@chromium.org>
956
957         Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
958         https://bugs.webkit.org/show_bug.cgi?id=108668
959
960         Reviewed by Eric Seidel.
961
962         * bindings/v8/SerializedScriptValue.cpp:
963         * css/CSSCalculationValue.cpp:
964         (WebCore::CSSCalcExpressionNodeParser::parseCalc):
965         * css/CSSImageSetValue.cpp:
966         (WebCore::CSSImageSetValue::fillImageSet):
967         (WebCore::CSSImageSetValue::customCssText):
968         * css/CSSParserValues.h:
969         (WebCore::CSSParserString::operator[]):
970         * css/CSSValueList.h:
971         (WebCore::CSSValueListInspector::item):
972         * css/StyleSheetContents.cpp:
973         (WebCore::StyleSheetContents::ruleAt):
974         (WebCore::StyleSheetContents::wrapperInsertRule):
975         (WebCore::StyleSheetContents::wrapperDeleteRule):
976         * dom/Document.cpp:
977         (WebCore::Document::processArguments):
978         * dom/Element.cpp:
979         (WebCore::Element::removeAttributeInternal):
980         * dom/ElementAttributeData.cpp:
981         (WebCore::ElementAttributeData::removeAttribute):
982         * dom/ElementAttributeData.h:
983         (WebCore::ElementAttributeData::attributeItem):
984         * dom/SpaceSplitString.h:
985         (WebCore::SpaceSplitStringData::operator[]):
986         (WebCore::SpaceSplitString::operator[]):
987         * editing/TextIterator.cpp:
988         (WebCore::TextIterator::characterAt):
989         * html/HTMLFormElement.cpp:
990         (WebCore::HTMLFormElement::removeFormElement):
991         * html/HTMLSelectElementWin.cpp:
992         (WebCore::HTMLSelectElement::platformHandleKeydownEvent):
993         * html/canvas/WebGLRenderingContext.cpp:
994         (WebCore):
995         * html/parser/HTMLFormattingElementList.cpp:
996         (WebCore::HTMLFormattingElementList::swapTo):
997         * inspector/InspectorStyleSheet.cpp:
998         (WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):
999         * inspector/InspectorStyleTextEditor.cpp:
1000         (WebCore::InspectorStyleTextEditor::replaceProperty):
1001         * inspector/InspectorValues.cpp:
1002         (WebCore::InspectorArrayBase::get):
1003         * page/WindowFeatures.cpp:
1004         (WebCore::WindowFeatures::WindowFeatures):
1005         * platform/audio/AudioArray.h:
1006         (WebCore::AudioArray::at):
1007         * platform/audio/AudioFIFO.cpp:
1008         (WebCore::AudioFIFO::findWrapLengths):
1009         * platform/graphics/GlyphPage.h:
1010         (WebCore::GlyphPage::glyphDataForIndex):
1011         (WebCore::GlyphPage::glyphAt):
1012         (WebCore::GlyphPage::setGlyphDataForIndex):
1013         * platform/graphics/TextRun.h:
1014         (WebCore::TextRun::operator[]):
1015         (WebCore::TextRun::data8):
1016         (WebCore::TextRun::data16):
1017         * platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
1018         (WebCore::HarfBuzzShaper::setDrawRange):
1019         * platform/graphics/openvg/TiledImageOpenVG.cpp:
1020         (WebCore::TiledImageOpenVG::setTile):
1021         (WebCore::TiledImageOpenVG::tile):
1022         * platform/image-decoders/ico/ICOImageDecoder.cpp:
1023         (WebCore::ICOImageDecoder::decodeAtIndex):
1024         (WebCore::ICOImageDecoder::imageTypeAtIndex):
1025         * platform/text/QuotedPrintable.cpp:
1026         (WebCore::lengthOfLineEndingAtIndex):
1027         * platform/text/SegmentedString.cpp:
1028         (WebCore::SegmentedString::advance):
1029         * platform/win/WebCoreTextRenderer.cpp:
1030         (WebCore::doDrawTextAtPoint):
1031         * rendering/InlineTextBox.cpp:
1032         (WebCore::InlineTextBox::paint):
1033         (WebCore::InlineTextBox::paintSelection):
1034
1035 2013-02-04  Nate Chapin  <japhet@chromium.org>
1036
1037         REGRESSION (r137607): Loading of archives as substitute data is broken
1038         https://bugs.webkit.org/show_bug.cgi?id=108589
1039
1040         Reviewed by Alexey Proskuryakov.
1041
1042         * loader/MainResourceLoader.cpp:
1043         (WebCore::MainResourceLoader::resourceData): Return the content from
1044             SubstituteData as mainResourceData if present.
1045
1046 2013-02-04  Julien Chaffraix  <jchaffraix@webkit.org>
1047
1048         [CSS Grid Layout] Heap-buffer-overflow in std::sort
1049         https://bugs.webkit.org/show_bug.cgi?id=108834
1050
1051         Reviewed by Abhishek Arya.
1052
1053         Test: fast/css-grid-layout/grid-strict-ordering-crash.html
1054
1055         * rendering/RenderGrid.cpp:
1056         (WebCore::sortByGridTrackGrowthPotential):
1057         The std::sort documentation says that this function should define a *strict* weak ordering. Fixed the strict
1058         part of the ordering. Also moved the function definition next to where it is needed and made the GridTrack
1059         argument const (as it shouldn't modify them or std::sort will misbehave).
1060
1061         * rendering/RenderGrid.cpp:
1062         (WebCore::sortByGridTrackGrowthPotential):
1063         (WebCore):
1064
1065 2013-02-04  Igor Oliveira  <igor.o@sisa.samsung.com>
1066
1067         [Texmap] Implement BGRA swizzling detection
1068         https://bugs.webkit.org/show_bug.cgi?id=81103
1069
1070         For OpenGLES if the extension EXT_texture_format_BGRA8888 is supported
1071         the internal and external formats need to be BGRA.
1072
1073         Reviewed by Noam Rosenthal.
1074
1075         * platform/graphics/texmap/TextureMapperGL.cpp:
1076         (WebCore):
1077         (WebCore::driverSupportsExternalTextureBGRA):
1078         (WebCore::driverSupportsSubImage):
1079         (WebCore::BitmapTextureGL::didReset):
1080
1081 2013-02-04  Dima Gorbik  <dgorbik@apple.com>
1082
1083         class="cue" is getting some default style
1084         https://bugs.webkit.org/show_bug.cgi?id=108752
1085
1086         Reviewed by Dean Jackson.
1087         
1088         The value variable inside the selector is used to store different information depending on the 
1089         type of the selector so we have to check explicitly that the selector we apply filtering to 
1090         matches a pseudo element.
1091         
1092         Existing tests modified to cover this case.
1093
1094         * css/RuleSet.cpp:
1095         (WebCore::determinePropertyWhitelistType):
1096
1097 2013-02-04  Tom Sepez  <tsepez@chromium.org>
1098
1099         [V8] Binding Integrity crash in V8HTMLEmbedElement::createWrapper
1100         https://bugs.webkit.org/show_bug.cgi?id=108841
1101
1102         Reviewed by Adam Barth.
1103
1104         * html/HTMLEmbedElement.idl:
1105         Quick change to IDL to disable binding check for now.
1106         
1107 2013-02-04  Martin Robinson  <mrobinson@igalia.com>
1108
1109         Fix GTK+ 'make dist' in preparation for the 1.11.5 release.
1110
1111         * GNUmakefile.list.am:
1112
1113 2013-02-04  Enrica Casucci  <enrica@apple.com>
1114
1115         Add specific EditActions for Bold and Italic commands.
1116         https://bugs.webkit.org/show_bug.cgi?id=108842.
1117         <rdar://problem/13098252>
1118
1119         This change is required on iOS where we need to
1120         identify the command in order to display the correct
1121         message in the undo popup. It is also in line with
1122         what we do for underline, which already has its own
1123         separate EditAction.
1124         
1125         Reviewed by Ryosuke Niwa.
1126
1127         No new tests. No behavior change.
1128
1129         * editing/EditAction.h:
1130         * editing/EditorCommand.cpp:
1131         (WebCore::executeToggleBold):
1132         (WebCore::executeToggleItalic):
1133
1134 2013-02-04  Dima Gorbik  <dgorbik@apple.com>
1135
1136         Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element
1137         https://bugs.webkit.org/show_bug.cgi?id=105478
1138
1139         Reviewed by Antti Koivisto.
1140
1141         In WebVTT lang is preprocessed and stored in the lang attribute of the element, 
1142         so we access it instead of walking up the tree the way it is done in HTML.
1143
1144         Existing tests were modified to cover this case.
1145
1146         * css/SelectorChecker.cpp:
1147         (WebCore::SelectorChecker::checkOne):
1148
1149 2013-02-04  Tim Horton  <timothy_horton@apple.com>
1150
1151         Disable autoscrolling the main frame if main frame scrolling is disabled
1152         https://bugs.webkit.org/show_bug.cgi?id=108848
1153         <rdar://problem/13004059>
1154
1155         Reviewed by Simon Fraser.
1156
1157         Ensure that the main frame can scroll at all before allowing an autoscroll.
1158
1159         * rendering/RenderBox.cpp:
1160         (WebCore::RenderBox::canAutoscroll):
1161
1162 2013-02-04  Tom Sepez  <tsepez@chromiium.org>
1163
1164         XSS Auditor bypass via svg tags and xlink:href
1165         https://bugs.webkit.org/show_bug.cgi?id=84158
1166
1167         This patch adds a test for the xlink:href attribute inside of
1168         script tokens. The test is complicated by the namespacing; the
1169         xlink hrefAttr qualified name does not contain a literal "xlink"
1170         prefix but only the URI of the namespace.
1171         
1172         Reviewed by Adam Barth.
1173
1174         Test: http/tests/security/xssAuditor/svg-script-tag.html
1175
1176         * html/parser/XSSAuditor.cpp:
1177         (WebCore::findAttributeWithName):
1178         (WebCore::XSSAuditor::filterScriptToken):
1179
1180 2013-02-04  Eric Carlson  <eric.carlson@apple.com>
1181
1182         Update CaptionUserPreferences
1183         https://bugs.webkit.org/show_bug.cgi?id=108783
1184
1185         Reviewed by Dean Jackson.
1186
1187         * html/shadow/MediaControlElements.cpp:
1188         (WebCore::MediaControlTextTrackContainerElement::updateSizes): Mark font size as important
1189             when necessary.
1190         * page/CaptionUserPreferences.h:
1191         (WebCore::CaptionUserPreferences::setUserPrefersCaptions): New, allow a port to remember that
1192             the user has chosen to see captions.
1193         (WebCore::CaptionUserPreferences::setPreferredLanguage): New, allow a port to remember the
1194             user's preferred caption language.
1195         (WebCore::CaptionUserPreferences::preferredLanguages): New, return a Vector of the user's 
1196             preferred caption languages.
1197         * page/CaptionUserPreferencesMac.h:
1198         * page/CaptionUserPreferencesMac.mm:
1199         * page/PageGroup.cpp:
1200         (WebCore::PageGroup::captionPreferences):
1201         (WebCore::PageGroup::captionFontSizeScale):
1202         * page/PageGroup.h:
1203         * platform/Language.cpp:
1204         (WebCore::userPreferredLanguagesOverride): New, return the user preferred languages override
1205             used during testing.
1206         * platform/Language.h:
1207         * platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
1208         (WebCore::InbandTextTrackPrivateAVFObjC::kind):
1209
1210 2013-02-04  Tim Horton  <timothy_horton@apple.com>
1211
1212         Allow TiledCoreAnimationDrawingArea overlay layers to become tiled
1213         https://bugs.webkit.org/show_bug.cgi?id=108729
1214         <rdar://problem/13047546>
1215
1216         Reviewed by Anders Carlsson.
1217
1218         * WebCore.exp.in:
1219         * platform/graphics/ca/GraphicsLayerCA.cpp:
1220         (WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): The "for this layer only" variant
1221         of flushCompositingState wasn't informing its client that it committed changes for the layer.
1222         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): We now explicitly want to be able to have a
1223         GraphicsLayerCA switch into or out of tiling while being unparented (we'll get a client callback and
1224         swap out its parent ourselves).
1225
1226 2013-02-04  Julien Chaffraix  <jchaffraix@webkit.org>
1227
1228         [CSS Grid Layout] Add parsing for grid-auto-flow
1229         https://bugs.webkit.org/show_bug.cgi?id=108397
1230
1231         Reviewed by Ojan Vafai.
1232
1233         Test: fast/css-grid-layout/grid-auto-flow-get-set.html
1234
1235         This change adds the parsing, application and conversion back through getComputedStyle
1236         for the new property -webkit-grid-auto-flow, which accpets the following:
1237
1238         -webkit-grid-auto-flow: none | rows | columns
1239
1240         * css/CSSComputedStyleDeclaration.cpp:
1241         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1242         Added code to convert the RenderStyle information back into a CSS value.
1243
1244         * css/CSSParser.cpp:
1245         (WebCore::isValidKeywordPropertyAndValue):
1246         (WebCore::isKeywordPropertyID):
1247         Implemented parsing for -webkit-grid-auto-flow.
1248
1249         * css/CSSPrimitiveValueMappings.h:
1250         (WebCore::CSSPrimitiveValue::operator GridAutoFlow):
1251         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1252         Added the conversion operators, used for parsing and getComputedStyle.
1253
1254         * css/CSSProperty.cpp:
1255         (WebCore::CSSProperty::isInheritedProperty):
1256         Added -webkit-grid-auto-flow to the list of the not inherited properties.
1257
1258         * css/CSSPropertyNames.in:
1259         Added the new value and keywords.
1260
1261         * css/StyleBuilder.cpp:
1262         (WebCore::StyleBuilder::StyleBuilder):
1263         Added a handler for the new CSS property.
1264
1265         * rendering/style/RenderStyle.h:
1266         Added the usual getter / setter / initial function.
1267
1268         * rendering/style/RenderStyleConstants.h:
1269         Added a new enum GridAutoFlow to hold the parsed value.
1270
1271         * rendering/style/StyleGridData.cpp:
1272         (WebCore::StyleGridData::StyleGridData):
1273         * rendering/style/StyleGridData.h:
1274         (WebCore::StyleGridData::operator==):
1275         Updated after adding a new field for the GridAutoFlow value.
1276
1277 2013-02-04  Mark Pilgrim  <pilgrim@chromium.org>
1278
1279         [Chromium] Move IDBFactoryBackendInterface to WebCore
1280         https://bugs.webkit.org/show_bug.cgi?id=108638
1281
1282         Reviewed by Adam Barth.
1283
1284         Part of a larger refactoring series; see tracking bug 106829.
1285
1286         * Modules/indexeddb/chromium: Added.
1287         * Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.
1288         (WebCore):
1289         (WebCore::setIDBFactoryBackendInterfaceCreateFunction):
1290         (WebCore::IDBFactoryBackendInterface::create):
1291         * Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.
1292         (WebCore):
1293         * WebCore.gyp/WebCore.gyp:
1294         * WebCore.gypi:
1295
1296 2013-02-04  Abhishek Arya  <inferno@chromium.org>
1297
1298         Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
1299         https://bugs.webkit.org/show_bug.cgi?id=108688
1300
1301         Reviewed by Eric Seidel.
1302
1303         * Modules/notifications/Notification.cpp:
1304         (WebCore::Notification::Notification):
1305         (WebCore::Notification::permission):
1306         (WebCore::Notification::requestPermission):
1307         * Modules/speech/SpeechGrammar.cpp:
1308         (WebCore::SpeechGrammar::setSrc):
1309         * Modules/speech/SpeechGrammarList.cpp:
1310         (WebCore::SpeechGrammarList::addFromUri):
1311         * Modules/websockets/ThreadableWebSocketChannel.cpp:
1312         (WebCore::ThreadableWebSocketChannel::create):
1313         * accessibility/AccessibilityMenuListPopup.cpp:
1314         (WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
1315         * accessibility/AccessibilityTable.cpp:
1316         (WebCore::AccessibilityTable::cellForColumnAndRow):
1317         * css/CSSFontFaceRule.cpp:
1318         (WebCore::CSSFontFaceRule::reattach):
1319         * css/CSSImageSetValue.cpp:
1320         (WebCore::CSSImageSetValue::fillImageSet):
1321         * css/CSSPageRule.cpp:
1322         (WebCore::CSSPageRule::reattach):
1323         * css/CSSStyleRule.cpp:
1324         (WebCore::CSSStyleRule::reattach):
1325         * css/StyleBuilder.cpp:
1326         (WebCore::ApplyPropertyFontVariantLigatures::applyValue):
1327         (WebCore::ApplyPropertyTextDecoration::applyValue):
1328         (WebCore::ApplyPropertyZoom::applyValue):
1329         * css/StyleResolver.cpp:
1330         (WebCore::createGridPosition):
1331         (WebCore::StyleResolver::applyProperty):
1332         (WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
1333         * css/WebKitCSSFilterRule.cpp:
1334         (WebCore::WebKitCSSFilterRule::reattach):
1335         * css/WebKitCSSKeyframesRule.cpp:
1336         (WebCore::WebKitCSSKeyframesRule::reattach):
1337         * css/WebKitCSSViewportRule.cpp:
1338         (WebCore::WebKitCSSViewportRule::reattach):
1339         * editing/EditCommand.h:
1340         (WebCore::toSimpleEditCommand):
1341         * editing/visible_units.cpp:
1342         (WebCore::startOfParagraph):
1343         (WebCore::endOfParagraph):
1344         * html/HTMLCollection.cpp:
1345         (WebCore::LiveNodeListBase::setItemCache):
1346         * loader/ThreadableLoader.cpp:
1347         (WebCore::ThreadableLoader::create):
1348         (WebCore::ThreadableLoader::loadResourceSynchronously):
1349         * loader/WorkerThreadableLoader.cpp:
1350         (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
1351         * page/Frame.cpp:
1352         (WebCore::Frame::frameForWidget):
1353         * platform/RefCountedSupplement.h:
1354         (WebCore::RefCountedSupplement::from):
1355         * rendering/RenderBlock.cpp:
1356         (WebCore::RenderBlock::splitBlocks):
1357         (WebCore::RenderBlock::firstLineBlock):
1358         * rendering/RenderBlockLineLayout.cpp:
1359         (WebCore::RenderBlock::createLineBoxes):
1360         * rendering/RenderBox.cpp:
1361         (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
1362         * rendering/svg/RenderSVGText.cpp:
1363         (WebCore::RenderSVGText::positionForPoint):
1364         * rendering/svg/SVGRootInlineBox.cpp:
1365         (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
1366         (WebCore::SVGRootInlineBox::layoutChildBoxes):
1367         * testing/js/WebCoreTestSupport.cpp:
1368         (WebCoreTestSupport::resetInternalsObject):
1369         * testing/v8/WebCoreTestSupport.cpp:
1370         (WebCoreTestSupport::resetInternalsObject):
1371         * workers/DefaultSharedWorkerRepository.cpp:
1372         (WebCore::SharedWorkerProxy::addToWorkerDocuments):
1373         (WebCore::SharedWorkerConnectTask::performTask):
1374         * workers/SharedWorker.cpp:
1375         (WebCore::SharedWorker::create):
1376         * workers/WorkerContext.cpp:
1377         (WebCore::CloseWorkerContextTask::performTask):
1378         * workers/WorkerMessagingProxy.cpp:
1379         (WebCore::MessageWorkerContextTask::performTask):
1380         (WebCore::connectToWorkerContextInspectorTask):
1381         (WebCore::disconnectFromWorkerContextInspectorTask):
1382         (WebCore::dispatchOnInspectorBackendTask):
1383         * workers/WorkerScriptLoader.cpp:
1384         (WebCore::WorkerScriptLoader::loadSynchronously):
1385         * workers/WorkerThread.cpp:
1386         (WebCore::WorkerThreadShutdownFinishTask::performTask):
1387         (WebCore::WorkerThreadShutdownStartTask::performTask):
1388
1389 2013-02-04  Dominik Röttsches  <dominik.rottsches@intel.com>
1390
1391         [Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
1392         https://bugs.webkit.org/show_bug.cgi?id=108479
1393
1394         Reviewed by Emil A Eklund.
1395
1396         Remove a FIXME that intended to solve the value truncation.
1397         Should positively affect SVG text positioning.
1398
1399         No new tests, partially covered by manual test
1400         ManualTests/harfbuzz-mouse-selection-crash.html.
1401
1402         * platform/graphics/harfbuzz/FontHarfBuzz.cpp:
1403         (WebCore::Font::offsetForPositionForComplexText):
1404
1405 2013-02-04  Vladislav Kaznacheev  <kaznacheev@chromium.org>
1406
1407         Web Inspector: Create a container class for SidebarPane instances
1408         https://bugs.webkit.org/show_bug.cgi?id=108183
1409
1410         Reviewed by Pavel Feldman.
1411
1412         SidebarPaneStack is responsible for pane title bar and expand/collapse behavior (previously handled by SidebarPane).
1413         SidebarPanes are inserted into DOM lazily and can belong to more than one container.
1414         SidebarPane is ready to be displayed in other types of containers (such as tabbed pane as requested in https://bugs.webkit.org/show_bug.cgi?id=107552).
1415         There should be no visible changes except for one: DOM breakpoint pane expand/collapse state is no longer
1416         shared between Elements and Sources sidebars.
1417
1418         * inspector/front-end/AuditResultView.js:
1419         (WebInspector.AuditResultView):
1420         * inspector/front-end/BreakpointsSidebarPane.js:
1421         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addBreakpoint):
1422         (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
1423         (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
1424         * inspector/front-end/DOMBreakpointsSidebarPane.js:
1425         (WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):
1426         * inspector/front-end/ElementsPanel.js:
1427         (WebInspector.ElementsPanel):
1428         (WebInspector.ElementsPanel.prototype.wasShown):
1429         (WebInspector.ElementsPanel.prototype.updateStyles):
1430         (WebInspector.ElementsPanel.prototype.updateMetrics):
1431         (WebInspector.ElementsPanel.prototype.updateProperties):
1432         (WebInspector.ElementsPanel.prototype.updateEventListeners):
1433         * inspector/front-end/ExtensionPanel.js:
1434         (WebInspector.ExtensionSidebarPane):
1435         * inspector/front-end/ExtensionServer.js:
1436         (WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
1437         * inspector/front-end/ScriptsPanel.js:
1438         (WebInspector.ScriptsPanel.prototype.wasShown):
1439         * inspector/front-end/SidebarPane.js:
1440         (WebInspector.SidebarPane):
1441         (WebInspector.SidebarPane.prototype.title):
1442         (WebInspector.SidebarPane.prototype.prepareContent):
1443         (WebInspector.SidebarPane.prototype.expand):
1444         (WebInspector.SidebarPane.prototype.onContentReady):
1445         (WebInspector.SidebarPane.prototype.setExpandCallback):
1446         (WebInspector.SidebarPane.prototype.setShowCallback):
1447         (WebInspector.SidebarPane.prototype.wasShown):
1448         (WebInspector.SidebarPaneStack):
1449         (WebInspector.SidebarPaneStack.prototype.wasShown):
1450         (WebInspector.SidebarPaneStack.prototype.addPane):
1451         (WebInspector.SidebarPaneStack.prototype._addTitle):
1452         (WebInspector.SidebarPaneStack.prototype._attachToPane):
1453         (WebInspector.SidebarPaneStack.prototype._isExpanded):
1454         (WebInspector.SidebarPaneStack.prototype._setExpanded):
1455         (WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
1456         (WebInspector.SidebarPaneStack.prototype._collapsePane):
1457         (WebInspector.SidebarPaneStack.prototype._togglePane):
1458         (WebInspector.SidebarPaneStack.prototype._onTitleKeyDown):
1459         * inspector/front-end/StylesSidebarPane.js:
1460         (WebInspector.StylesSidebarPane.prototype._refreshUpdate):
1461         (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
1462         (WebInspector.StylesSidebarPane.prototype.set _createNewRule):
1463         (WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):
1464         * inspector/front-end/WatchExpressionsSidebarPane.js:
1465         (WebInspector.WatchExpressionsSidebarPane):
1466         (WebInspector.WatchExpressionsSidebarPane.prototype.wasShown):
1467         (WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
1468         (WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
1469         * inspector/front-end/inspector.css:
1470         (.pane-title + .pane-title, .pane:not(.visible) + .pane-title, .pane-title:first-of-type):
1471         (.pane-title):
1472         (.pane-title:active):
1473         (.pane-title::before):
1474         (.pane-title.expanded::before):
1475         (.pane-title > select):
1476         (.pane-title > select:hover):
1477         (.pane-title > select:active):
1478         (.pane-title > select.select-settings):
1479         (.pane-title > select.select-filter):
1480         (.pane-title > select > option, .pane-title > select > hr):
1481         (.pane-title > .pane-title-button):
1482         (.pane-title > .pane-title-button:hover):
1483         (.pane-title > .pane-title-button:active, .pane-title > .pane-title-button.toggled):
1484         (.pane-title > .pane-title-button.add):
1485         (.pane-title > .pane-title-button.element-state):
1486         (.pane-title > .pane-title-button.refresh):
1487         (.pane.visible > .body):
1488         (.pane.visible:nth-last-of-type(1)):
1489         (.panel-enabler-view button:not(.status-bar-item), .pane-title-button, button.show-all-nodes):
1490         (.panel-enabler-view button:active:not(.status-bar-item), .pane-title-button:active, button.show-all-nodes:active):
1491         (body.inactive .panel-enabler-view button:not(.status-bar-item), .panel-enabler-view button:disabled:not(.status-bar-item), body.inactive .pane-title-button, .pane-title-button:disabled, body.inactive button.show-all-nodes):
1492
1493 2013-02-01  Emil A Eklund  <eae@chromium.org>
1494
1495         Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
1496         https://bugs.webkit.org/show_bug.cgi?id=108707
1497
1498         Reviewed by Eric Seidel.
1499         
1500         The computedCSSPaddingTop/Bottom/... methods in
1501         RenderBoxModelObject all do pretty much exactly the same thing
1502         yet share no code.
1503         
1504         Break out shared code into computedCSSPadding method and have
1505         the top/bottom/left/right/... ones call it with the appropriate
1506         length value.
1507
1508         No new tests, no change in functionality.
1509
1510         * rendering/RenderBoxModelObject.cpp:
1511         (WebCore::RenderBoxModelObject::computedCSSPadding):
1512         * rendering/RenderBoxModelObject.h:
1513         (WebCore::RenderBoxModelObject::computedCSSPaddingTop):
1514         (WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
1515         (WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
1516         (WebCore::RenderBoxModelObject::computedCSSPaddingRight):
1517         (WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
1518         (WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
1519         (WebCore::RenderBoxModelObject::computedCSSPaddingStart):
1520         (WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
1521         (RenderBoxModelObject):
1522
1523 2013-02-04  Andrey Lushnikov  <lushnikov@chromium.org>
1524
1525         Web Inspector: add round braces to javascript tokenizer
1526         https://bugs.webkit.org/show_bug.cgi?id=108692
1527
1528         Reviewed by Pavel Feldman.
1529
1530         Change SourceJavascriptTokenizer.re2js file to produce "brace-start"
1531         and "brace-end" tokens for round braces.
1532         Regenerate SourceJavascriptTokenizer.js according to new re2js file.
1533
1534         No new tests: no change in behaviour.
1535
1536         * inspector/front-end/SourceJavaScriptTokenizer.js:
1537         (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
1538         * inspector/front-end/SourceJavaScriptTokenizer.re2js:
1539
1540 2013-02-04  Pavel Feldman  <pfeldman@chromium.org>
1541
1542         Web Inspector: take page scale factor into account when updating overlay.
1543         https://bugs.webkit.org/show_bug.cgi?id=108831
1544
1545         Reviewed by Vsevolod Vlasov.
1546
1547         Otherwise, the ports that use page scale factor have broken overlay.
1548
1549         * inspector/InspectorOverlay.cpp:
1550         (WebCore::InspectorOverlay::update):
1551
1552 2013-02-04  Dan Carney  <dcarney@google.com>
1553
1554         [v8] explicit isolate parameter for MakeWeak calls
1555         https://bugs.webkit.org/show_bug.cgi?id=108818
1556
1557         Reviewed by Kentaro Hara.
1558
1559         No new tests. No change in functionality.
1560
1561         * bindings/v8/DOMDataStore.cpp:
1562         (WebCore::DOMDataStore::DOMDataStore):
1563         (WebCore::DOMDataStore::weakCallback):
1564         * bindings/v8/DOMDataStore.h:
1565         (WebCore::DOMDataStore::setWrapper):
1566         (WebCore::DOMDataStore::set):
1567         (WebCore::DOMDataStore::setWrapperInObject):
1568         (DOMDataStore):
1569         * bindings/v8/DOMWrapperMap.h:
1570         (WebCore::DOMWrapperMap::DOMWrapperMap):
1571         (WebCore::DOMWrapperMap::set):
1572         (WebCore::DOMWrapperMap::defaultWeakCallback):
1573         (DOMWrapperMap):
1574         * bindings/v8/DOMWrapperWorld.cpp:
1575         (WebCore::isolatedWorldWeakCallback):
1576         (WebCore::DOMWrapperWorld::makeContextWeak):
1577         * bindings/v8/ScriptState.cpp:
1578         (WebCore::ScriptState::ScriptState):
1579         (WebCore::ScriptState::weakReferenceCallback):
1580         * bindings/v8/ScriptState.h:
1581         (ScriptState):
1582         * bindings/v8/V8AbstractEventListener.cpp:
1583         (WebCore::V8AbstractEventListener::weakEventListenerCallback):
1584         (WebCore::V8AbstractEventListener::V8AbstractEventListener):
1585         (WebCore::V8AbstractEventListener::setListenerObject):
1586         * bindings/v8/V8AbstractEventListener.h:
1587         (V8AbstractEventListener):
1588         * bindings/v8/V8EventListener.cpp:
1589         (WebCore::V8EventListener::V8EventListener):
1590         * bindings/v8/V8LazyEventListener.cpp:
1591         (WebCore::V8LazyEventListener::V8LazyEventListener):
1592         * bindings/v8/V8MutationCallback.cpp:
1593         (WebCore::V8MutationCallback::V8MutationCallback):
1594         * bindings/v8/V8MutationCallback.h:
1595         (WebCore::V8MutationCallback::create):
1596         (WebCore::V8MutationCallback::weakCallback):
1597         * bindings/v8/V8NPObject.cpp:
1598         (WebCore::V8NPTemplateMap::set):
1599         (WebCore::V8NPTemplateMap::sharedInstance):
1600         (WebCore::V8NPTemplateMap::V8NPTemplateMap):
1601         (V8NPTemplateMap):
1602         (WebCore::V8NPTemplateMap::weakCallback):
1603         (WebCore::npObjectGetProperty):
1604         (WebCore):
1605         (WebCore::staticNPObjectMap):
1606         (WebCore::weakNPObjectCallback):
1607         * bindings/v8/V8ValueCache.cpp:
1608         (WebCore::cachedStringCallback):
1609         (WebCore::StringCache::v8ExternalStringSlow):
1610         * bindings/v8/custom/V8InjectedScriptManager.cpp:
1611         (WebCore::WeakReferenceCallback):
1612         (WebCore::createInjectedScriptHostV8Wrapper):
1613         * bindings/v8/custom/V8MutationObserverCustom.cpp:
1614         (WebCore::V8MutationObserver::constructorCallbackCustom):
1615
1616 2013-02-04  Dmitry Gozman  <dgozman@chromium.org>
1617
1618         Web Inspector: Allow user to change dock side by dragging toolbar
1619         https://bugs.webkit.org/show_bug.cgi?id=108073
1620
1621         Dragging toolbar to the right/bottom will change the dock side accordingly
1622         instead of changing the inspector window height (if dock to right is available).
1623
1624         Reviewed by Pavel Feldman.
1625
1626         No new tests, because of pure inspector UI change.
1627
1628         * inspector/front-end/DockController.js:
1629         (WebInspector.DockController.prototype.dockSide):
1630         * inspector/front-end/Toolbar.js:
1631         (WebInspector.Toolbar):
1632         (WebInspector.Toolbar.prototype._isDockedToBottom):
1633         (WebInspector.Toolbar.prototype._isUndocked):
1634         (WebInspector.Toolbar.prototype._toolbarDragStart):
1635         (WebInspector.Toolbar.prototype._toolbarDragEnd):
1636         (WebInspector.Toolbar.prototype._toolbarDrag):
1637         (WebInspector.Toolbar.prototype._toolbarDragMoveWindow):
1638         (WebInspector.Toolbar.prototype._toolbarDragChangeDocking):
1639         (WebInspector.Toolbar.prototype._toolbarDragChangeHeight):
1640         * inspector/front-end/UIUtils.js:
1641         (WebInspector._elementDragStart):
1642         (WebInspector._elementDragMove):
1643         (WebInspector._cancelDragEvents):
1644         (WebInspector._elementDragEnd):
1645
1646 2013-02-04  Andrey Kosyakov  <caseq@chromium.org>
1647
1648         Web Inspector: sync list of console API methods to that used by auto-complete
1649         https://bugs.webkit.org/show_bug.cgi?id=108804
1650
1651         Reviewed by Pavel Feldman.
1652
1653         - push new method names from InjectedScriptSource to RuntimeModel;
1654         - add a comment to InjectedScriptSource noting the necessity of keeping lists in sync.
1655
1656         * inspector/InjectedScriptSource.js:
1657         * inspector/front-end/RuntimeModel.js:
1658         (WebInspector.RuntimeModel.prototype.receivedPropertyNames):
1659         (WebInspector.RuntimeModel.prototype._completionsForExpression):
1660
1661 2013-02-04  Eugene Klyuchnikov  <eustas@chromium.org>
1662
1663         Web Inspector: [Network] Minor refactorings.
1664         https://bugs.webkit.org/show_bug.cgi?id=108162
1665
1666         Reviewed by Vsevolod Vlasov.
1667
1668         Apply minor refactorings to NetworkPanel.js
1669         Add hint to statusbar selector buttons.
1670
1671         * English.lproj/localizedStrings.js: Added hint string.
1672         * inspector/front-end/NetworkPanel.js:
1673         (WebInspector.NetworkLogView.prototype._createStatusBarItems): Ditto.
1674         (WebInspector.NetworkLogView.prototype._makeHeaderFragment):
1675         Applied minor refactoring.
1676         (WebInspector.NetworkLogView.prototype._createStatusBarItems.createFilterElement):
1677         Ditto.
1678         (WebInspector.NetworkLogView.prototype._updateOffscreenRows): Ditto.
1679         (WebInspector.NetworkPanel.prototype._onRowSizeChanged): Ditto.
1680
1681 2013-02-04  Eugene Klyuchnikov  <eustas@chromium.org>
1682
1683         Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
1684         https://bugs.webkit.org/show_bug.cgi?id=108437
1685
1686         Reviewed by Pavel Feldman.
1687
1688         CPU Profile code has obsolete inline-comments to clarify types.
1689         Currently we use JSDocs to specify types.
1690
1691         Also applied some minor refactorings.
1692
1693         * inspector/front-end/BottomUpProfileDataGridTree.js:
1694         (WebInspector.BottomUpProfileDataGridNode):
1695         Added JSDocs. Removed profileView parameter.
1696         (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
1697         Added JSDocs.
1698         (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
1699         Ditto.
1700         (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
1701         Ditto.
1702         (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
1703         Do not pass profileView to constructor.
1704         (WebInspector.BottomUpProfileDataGridTree):
1705         Added JSDocs. Renamed parameters.
1706         (WebInspector.BottomUpProfileDataGridTree.prototype.focus):
1707         Added JSDocs.
1708         (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
1709         Ditto.
1710         * inspector/front-end/CPUProfileView.js: Removed unused getter/setter.
1711         (WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
1712         Un-nested. Added JSDocs.
1713         (WebInspector.CPUProfileView.prototype._getBottomUpProfileDataGridTree):
1714         Added JSDocs. Turned to method from getter. Simplified.
1715         (WebInspector.CPUProfileView.prototype._getTopDownProfileDataGridTree):
1716         Added JSDocs. Turned to method from getter.
1717         (WebInspector.CPUProfileView.prototype._assignParentsInProfile):
1718         Optimized.
1719         * inspector/front-end/DataGrid.js: Added JSDocs.
1720         * inspector/front-end/ProfileDataGridTree.js:
1721         (WebInspector.ProfileDataGridNode):
1722         Added JSDocs. Removed profileView parameter.
1723         (WebInspector.ProfileDataGridNode.prototype.createCell): Added JSDocs.
1724         (WebInspector.ProfileDataGridNode.prototype.sort): Ditto.
1725         (WebInspector.ProfileDataGridNode.prototype.insertChild): Ditto.
1726         (WebInspector.ProfileDataGridNode.prototype.removeChild): Ditto.
1727         (WebInspector.ProfileDataGridNode.prototype.removeChildren):
1728         Added JSDocs. Removed parameter.
1729         (WebInspector.ProfileDataGridNode.prototype.findChild): Added JSDocs.
1730         (WebInspector.ProfileDataGridTree): Added JSDocs. Renamed parameter.
1731         * inspector/front-end/TopDownProfileDataGridTree.js:
1732         (WebInspector.TopDownProfileDataGridNode):
1733         Added JSDocs. Removed profileView parameter.
1734         (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
1735         Do not pass profileView to constructor.
1736         (WebInspector.TopDownProfileDataGridTree):
1737         Added JSDocs. Renamed parameter.
1738         (WebInspector.TopDownProfileDataGridTree.prototype.focus):
1739         Added JSDocs.
1740         (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
1741         Ditto.
1742
1743 2013-02-04  Dan Carney  <dcarney@google.com>
1744
1745         [v8] use toV8Fast in hand coded callbacks
1746         https://bugs.webkit.org/show_bug.cgi?id=108817
1747
1748         Reviewed by Kentaro Hara.
1749
1750         No new tests. No change in functionality.
1751
1752         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1753         (WebCore::V8DOMWindow::openCallback):
1754         (WebCore::V8DOMWindow::indexedPropertyGetter):
1755         (WebCore::V8DOMWindow::namedPropertyGetter):
1756         * bindings/v8/custom/V8DocumentCustom.cpp:
1757         (WebCore::V8Document::evaluateCallback):
1758         * bindings/v8/custom/V8DocumentLocationCustom.cpp:
1759         (WebCore::V8Document::locationAccessorGetter):
1760         * bindings/v8/custom/V8EventCustom.cpp:
1761         (WebCore::V8Event::dataTransferAccessorGetter):
1762         (WebCore::V8Event::clipboardDataAccessorGetter):
1763         * bindings/v8/custom/V8FileReaderCustom.cpp:
1764         (WebCore::V8FileReader::resultAccessorGetter):
1765         * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
1766         (WebCore):
1767         (WebCore::getNamedItems):
1768         (WebCore::getItem):
1769         (WebCore::V8HTMLAllCollection::namedPropertyGetter):
1770         (WebCore::V8HTMLAllCollection::itemCallback):
1771         (WebCore::V8HTMLAllCollection::namedItemCallback):
1772         (WebCore::V8HTMLAllCollection::callAsFunctionCallback):
1773         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
1774         (WebCore::V8HTMLCanvasElement::getContextCallback):
1775         * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
1776         (WebCore::V8HTMLCollection::namedPropertyGetter):
1777         * bindings/v8/custom/V8HTMLElementCustom.cpp:
1778         (WebCore::V8HTMLElement::itemValueAccessorGetter):
1779         * bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
1780         (WebCore):
1781         (WebCore::getNamedItems):
1782         (WebCore::V8HTMLFormControlsCollection::namedPropertyGetter):
1783         (WebCore::V8HTMLFormControlsCollection::namedItemCallback):
1784         * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
1785         (WebCore::V8HTMLFormElement::indexedPropertyGetter):
1786         (WebCore::V8HTMLFormElement::namedPropertyGetter):
1787         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
1788         (WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
1789         * bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
1790         (WebCore::V8HTMLLinkElement::sizesAccessorGetter):
1791         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
1792         (WebCore):
1793         (WebCore::getNamedItems):
1794         (WebCore::V8HTMLOptionsCollection::namedPropertyGetter):
1795         (WebCore::V8HTMLOptionsCollection::namedItemCallback):
1796         (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
1797         * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
1798         (WebCore::V8HTMLSelectElement::indexedPropertyGetter):
1799         * bindings/v8/custom/V8MessageEventCustom.cpp:
1800         (WebCore::V8MessageEvent::dataAccessorGetter):
1801         (WebCore::V8MessageEvent::portsAccessorGetter):
1802         * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
1803         (WebCore::V8NamedNodeMap::indexedPropertyGetter):
1804         (WebCore::V8NamedNodeMap::namedPropertyGetter):
1805         * bindings/v8/custom/V8NodeListCustom.cpp:
1806         (WebCore::V8NodeList::namedPropertyGetter):
1807         * bindings/v8/custom/V8PopStateEventCustom.cpp:
1808         (WebCore::V8PopStateEvent::stateAccessorGetter):
1809         * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
1810         (WebCore::V8SQLTransactionSync::executeSqlCallback):
1811         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
1812         (WebCore::V8StyleSheetList::namedPropertyGetter):
1813         * bindings/v8/custom/V8TrackEventCustom.cpp:
1814         (WebCore::V8TrackEvent::trackAccessorGetter):
1815         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
1816         (WebCore::V8XMLHttpRequest::responseAccessorGetter):
1817
1818 2013-02-04  David Kilzer  <ddkilzer@apple.com>
1819
1820         Remove duplicate entry from WebCore Xcode project
1821
1822             $ uniq Source/WebCore/WebCore.xcodeproj/project.pbxproj | diff -u - Source/WebCore/WebCore.xcodeproj/project.pbxproj | patch -p0 -R
1823             patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
1824
1825         * WebCore.xcodeproj/project.pbxproj: Remove duplicate.
1826
1827 2013-02-04  David Kilzer  <ddkilzer@apple.com>
1828
1829         Sort WebCore Xcode project file
1830
1831         * WebCore.xcodeproj/project.pbxproj:
1832
1833 2013-02-04  Dan Carney  <dcarney@google.com>
1834
1835         [v8] disable ascii check once latin-1 is enabled in v8
1836         https://bugs.webkit.org/show_bug.cgi?id=108805
1837
1838         Reviewed by Kentaro Hara.
1839
1840         No new tests. No change in functionality.
1841
1842         * bindings/v8/V8ValueCache.cpp:
1843         (WebCore::makeExternalString):
1844
1845 2013-02-04  Pavel Feldman  <pfeldman@chromium.org>
1846
1847         Web Inspector: make tabbed pane header a relayout boundary.
1848         https://bugs.webkit.org/show_bug.cgi?id=108650
1849
1850         Reviewed by Alexander Pavlov.
1851
1852         Otherwise, its measure width routine causes total reflow.
1853
1854         * inspector/front-end/tabbedPane.css:
1855         (.tabbed-pane-header):
1856
1857 2013-02-04  Hayato Ito  <hayato@chromium.org>
1858
1859         Split InspectorCSSOMWrappers out from StyleResolver.h into its own file.
1860         https://bugs.webkit.org/show_bug.cgi?id=108797
1861
1862         Reviewed by Hajime Morita.
1863
1864         This is a following patch after r141373. Now we can have
1865         InspectorCSSOMWrappers in its own file since CSSDefaultStyleSheets
1866         was factored out from StyleResolver.cpp in r141733.
1867
1868         WebCore/inspector/ directory is used for basic inspector
1869         functionalities. Therefore, I've put
1870         InspectorCSSOMWrappers.{h,cpp} in WebCore/css/ rather than
1871         WebCore/inspector/.
1872
1873         No new tests, refactoring only.
1874
1875         * CMakeLists.txt:
1876         * GNUmakefile.list.am:
1877         * Target.pri:
1878         * WebCore.gypi:
1879         * WebCore.xcodeproj/project.pbxproj:
1880         * css/CSSAllInOne.cpp:
1881         * css/InspectorCSSOMWrappers.cpp: Added.
1882         (WebCore):
1883         (WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
1884         (WebCore::InspectorCSSOMWrappers::collect):
1885         (WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
1886         (WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
1887         (WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
1888         (WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
1889         (WebCore::InspectorCSSOMWrappers::reportMemoryUsage):
1890         * css/InspectorCSSOMWrappers.h: Added.
1891         (WebCore):
1892         (InspectorCSSOMWrappers):
1893         * css/StyleResolver.cpp:
1894         * css/StyleResolver.h:
1895
1896 2013-02-04  Balazs Kelemen  <kbalazs@webkit.org>
1897
1898         [Soup] Wrap SoupSession by NetworkStorageSession
1899         https://bugs.webkit.org/show_bug.cgi?id=108615
1900
1901         Reviewed by Alexey Proskuryakov.
1902
1903         Implement NetworkStorageSession for ports using soup. It has been
1904         separated from NetworkingContext, so now we have a default storage
1905         session, which is the same as before but now wrapped with NetworkStorageSession,
1906         and it can be overridden by the networking context.
1907
1908         No change in behavior so no new tests.
1909
1910         * CMakeLists.txt:
1911         * GNUmakefile.list.am:
1912         * PlatformBlackBerry.cmake:
1913         * PlatformEfl.cmake:
1914         * loader/CookieJar.cpp:
1915         (WebCore):
1916         Now we also get the storage session from the networking context
1917         and not the other way.
1918
1919         * platform/network/NetworkStorageSession.h:
1920         (NetworkStorageSession):
1921         (WebCore::NetworkStorageSession::setSoupSession):
1922         (WebCore::NetworkStorageSession::soupSession):
1923         Hold a SoupSession pointer for ports using soup. Added a setter because it is
1924         necessary for API's that allow it to be specified per page, like EFL WK1.
1925
1926         * platform/network/NetworkingContext.h:
1927         (NetworkingContext):
1928         * platform/network/soup/CookieJarSoup.cpp:
1929         (WebCore::cookieJarForSession):
1930         * platform/network/soup/NetworkStorageSessionSoup.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp.
1931         (WebCore::NetworkStorageSession::NetworkStorageSession):
1932         (WebCore::NetworkStorageSession::defaultStorageSession):
1933         (WebCore::NetworkStorageSession::createDefaultSession):
1934         (WebCore::NetworkStorageSession::createPrivateBrowsingSession):
1935         (WebCore::NetworkStorageSession::switchToNewTestingSession):
1936         * platform/network/soup/ResourceHandleSoup.cpp:
1937         (WebCore::sessionFromContext):
1938
1939         * CMakeLists.txt:
1940         * GNUmakefile.list.am:
1941         * PlatformBlackBerry.cmake:
1942         * PlatformEfl.cmake:
1943         * loader/CookieJar.cpp:
1944         (WebCore):
1945         * platform/network/NetworkStorageSession.h:
1946         (NetworkStorageSession):
1947         (WebCore::NetworkStorageSession::setSoupSession):
1948         (WebCore::NetworkStorageSession::soupSession):
1949         * platform/network/NetworkingContext.h:
1950         (NetworkingContext):
1951         * platform/network/soup/CookieJarSoup.cpp:
1952         (WebCore::cookieJarForSession):
1953         * platform/network/soup/ResourceHandleSoup.cpp:
1954         (WebCore::sessionFromContext):
1955
1956 2013-02-04  Andrey Lushnikov  <lushnikov@chromium.org>
1957
1958         Web Inspector: source location in statusbar has few bugs in it
1959         https://bugs.webkit.org/show_bug.cgi?id=108748
1960
1961         Reviewed by Vsevolod Vlasov.
1962
1963         Call super method statusBarItems in SnippetJavaScriptSourceFrame class
1964         and merge its results. Fix css styles for source location in statusbar
1965         and rename its css class into a less confusing name.
1966
1967         No new test: no change in behaviour.
1968
1969         * inspector/front-end/SnippetJavaScriptSourceFrame.js:
1970         (WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
1971         * inspector/front-end/SourceFrame.js:
1972         (WebInspector.SourceFrame):
1973         * inspector/front-end/inspector.css:
1974         (.source-frame-cursor-position):
1975
1976 2013-02-04  Mike West  <mkwst@chromium.org>
1977
1978         Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
1979         https://bugs.webkit.org/show_bug.cgi?id=108766
1980
1981         Reviewed by Kentaro Hara.
1982
1983         This patch refactors checkAddChild and checkReplaceChild to remove the
1984         creation of an extra ExceptionCode that's not necessary for the
1985         desired behavior, and to bring the ExceptionCode usage into line with
1986         the rest of WebKit (this was the only case where ExceptionCode was
1987         assigned inside an 'if' statement's condition).
1988
1989         After this patch, 'ec' will always be assigned a value, even if the
1990         result of 'checkAcceptChild' is 0. This would only change behavior if
1991         'ec' was non-zero coming into the function, and 'checkAcceptChild'
1992         returned 0. Since every callsite is either directly after an explicit
1993         zeroing of 'ec', or after an 'if (ec)' clause, that case should never
1994         appear. This patch, therefore, shouldn't visibly change WebKit's
1995         behavior.
1996
1997         * dom/ContainerNode.cpp:
1998         (WebCore::checkAddChild):
1999         (WebCore::checkReplaceChild):
2000
2001 2013-02-03  David Kilzer  <ddkilzer@apple.com>
2002
2003         Upstream ENABLE_PDFKIT_PLUGIN settting
2004         <http://webkit.org/b/108792>
2005
2006         Reviewed by Tim Horton.
2007
2008         * Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
2009         on iOS since PDFKit is a Mac-only framework.
2010
2011 2013-02-03  Takashi Sakamoto  <tasak@google.com>
2012
2013         Split per-resolve logic out from StyleResolver.
2014         https://bugs.webkit.org/show_bug.cgi?id=96421
2015
2016         Reviewed by Eric Seidel.
2017
2018         Implemented class StyleResolver::State and added m_state to
2019         StyleResolver. All member variables used for per-resolve logic are
2020         moved into the state class.
2021
2022         No new tests, because just refactoring.
2023
2024         * css/SVGCSSStyleSelector.cpp:
2025         (WebCore::StyleResolver::applySVGProperty):
2026         * css/StyleResolver.cpp:
2027         (WebCore):
2028         (WebCore::StyleResolver::StyleResolver):
2029         (WebCore::StyleResolver::collectMatchingRules):
2030         (WebCore::StyleResolver::collectMatchingRulesForRegion):
2031         (WebCore::StyleResolver::sortAndTransferMatchedRules):
2032         (WebCore::StyleResolver::matchScopedAuthorRules):
2033         (WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
2034         (WebCore::StyleResolver::matchHostRules):
2035         (WebCore::StyleResolver::matchAuthorRules):
2036         (WebCore::StyleResolver::matchUserRules):
2037         (WebCore::StyleResolver::matchUARules):
2038         (WebCore::StyleResolver::collectMatchingRulesForList):
2039         (WebCore::StyleResolver::sortMatchedRules):
2040         (WebCore::StyleResolver::matchAllRules):
2041         (WebCore::StyleResolver::initElement):
2042         (WebCore::StyleResolver::initForStyleResolve):
2043         (WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
2044         (WebCore::StyleResolver::canShareStyleWithControl):
2045         (WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
2046         (WebCore::StyleResolver::canShareStyleWithElement):
2047         (WebCore::StyleResolver::locateSharedStyle):
2048         (WebCore::StyleResolver::styleForElement):
2049         (WebCore::StyleResolver::styleForKeyframe):
2050         (WebCore::StyleResolver::pseudoStyleForElement):
2051         (WebCore::StyleResolver::styleForPage):
2052         (WebCore::StyleResolver::defaultStyleForElement):
2053         (WebCore::StyleResolver::adjustRenderStyle):
2054         (WebCore::StyleResolver::updateFont):
2055         (WebCore::StyleResolver::cacheBorderAndBackground):
2056         (WebCore::StyleResolver::pseudoStyleRulesForElement):
2057         (WebCore::StyleResolver::ruleMatches):
2058         (WebCore::StyleResolver::checkRegionSelector):
2059         (WebCore::StyleResolver::applyProperties):
2060         (WebCore::StyleResolver::applyMatchedProperties):
2061         (WebCore::StyleResolver::isLeftPage):
2062         (WebCore::StyleResolver::applyPropertyToStyle):
2063         (WebCore::StyleResolver::useSVGZoomRules):
2064         (WebCore::createGridTrackBreadth):
2065         (WebCore::createGridTrackMinMax):
2066         (WebCore::createGridTrackGroup):
2067         (WebCore::createGridTrackList):
2068         (WebCore::StyleResolver::resolveVariables):
2069         (WebCore::StyleResolver::applyProperty):
2070         (WebCore::StyleResolver::cachedOrPendingFromValue):
2071         (WebCore::StyleResolver::generatedOrPendingFromValue):
2072         (WebCore::StyleResolver::setOrPendingFromValue):
2073         (WebCore::StyleResolver::cursorOrPendingFromValue):
2074         (WebCore::StyleResolver::checkForTextSizeAdjust):
2075         (WebCore::StyleResolver::initializeFontStyle):
2076         (WebCore::StyleResolver::setFontSize):
2077         (WebCore::StyleResolver::colorFromPrimitiveValue):
2078         (WebCore::StyleResolver::loadPendingSVGDocuments):
2079         (WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
2080         (WebCore::StyleResolver::loadPendingShaders):
2081         (WebCore::StyleResolver::parseCustomFilterTransformParameter):
2082         (WebCore::StyleResolver::createFilterOperations):
2083         (WebCore::StyleResolver::loadPendingImage):
2084         (WebCore::StyleResolver::loadPendingImages):
2085         (WebCore::StyleResolver::reportMemoryUsage):
2086         * css/StyleResolver.h:
2087         (WebCore::StyleResolver::style):
2088         (WebCore::StyleResolver::parentStyle):
2089         (WebCore::StyleResolver::rootElementStyle):
2090         (WebCore::StyleResolver::element):
2091         (WebCore::StyleResolver::setFontDescription):
2092         (WebCore::StyleResolver::setZoom):
2093         (WebCore::StyleResolver::setEffectiveZoom):
2094         (WebCore::StyleResolver::setTextSizeAdjust):
2095         (WebCore::StyleResolver::setWritingMode):
2096         (WebCore::StyleResolver::setTextOrientation):
2097         (WebCore::StyleResolver::hasParentNode):
2098         (WebCore::StyleResolver::addMatchedRule):
2099         (StyleResolver):
2100         (State):
2101         (WebCore::StyleResolver::State::State):
2102         (WebCore::StyleResolver::applyPropertyToRegularStyle):
2103         (WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
2104         Added "m_state." to access member variables used for per-resolve logic.
2105
2106 2013-02-03  Kent Tamura  <tkent@chromium.org>
2107
2108         Support setLangAttributeAwareFormControlUIEnabled on Chromium Windows XP
2109         https://bugs.webkit.org/show_bug.cgi?id=108791
2110
2111         Reviewed by Kentaro Hara.
2112
2113         We didn't support setLangAttributeAwareFormControlUIEnabled(true) on
2114         Chromium Windows XP because of lack of LocaleNameToLCID API. This change
2115         add manual mapping from locale names to LCIDs for Windows XP.
2116
2117         No new tests. This doesn't make any behavior changes in products, and
2118         this improves some test results.
2119
2120         * platform/text/win/LocaleWin.cpp:
2121         (WebCore): Define NameToLCIDMap.
2122         (WebCore::removeLastComponent):
2123         Remove the last component separated with '-'.
2124         (WebCore::ensureNameToLCIDMap):
2125         Add locale names used in layout tests.
2126         (WebCore::convertLocaleNameToLCID):
2127         Find an appropriate LCID longest matching with the specified locale name.
2128         (WebCore::LCIDFromLocale):
2129         Use convertLocaleNameToLCID if LocaleNameToLCID is not available.
2130
2131 2013-02-03  Kent Tamura  <tkent@chromium.org>
2132
2133         Add FocusDirection argument to HTMLTextFormControlElement::handleFocusEvent
2134         https://bugs.webkit.org/show_bug.cgi?id=108775
2135
2136         Reviewed by Hajime Morita.
2137
2138         We'd like to add a FocusDirection argument to
2139         HTMLTextFormControlElement::handleFocusEvent in order to fix Bug
2140         108447. This is a preparation for it.
2141
2142         We need to add FocusDirection arguments to some focus-related functions
2143         to pass it correctly when TAB or Shift+TAB is pressed.
2144
2145         No new tests. This doesn't make any behavior changes.
2146
2147         * html/HTMLTextFormControlElement.cpp:
2148         (WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
2149         To pass the FocusDirection argument to handleFocusEvent, we need to add
2150         it to dispatchFocusEvent too.
2151         * html/HTMLTextFormControlElement.h:
2152         (HTMLTextFormControlElement):
2153         Add FocusDirection arugment to dispatchFocusEvent.
2154         (WebCore::HTMLTextFormControlElement::handleFocusEvent):
2155         Add FocusDirection argument.
2156
2157         * dom/Node.cpp:
2158         (WebCore::Node::dispatchFocusEvent): Add FocusDirection argument.
2159         * dom/Node.h:
2160         (Node): Ditto.
2161
2162         * dom/Document.cpp:
2163         (WebCore::Document::setFocusedNode): Add FocusDirection argument in
2164         order to pass it to Node::dispatchFocusEvent.
2165         * dom/Document.h:
2166         (Document): Ditto.
2167
2168         * page/FocusController.cpp:
2169         (WebCore::dispatchEventsOnWindowAndFocusedNode):
2170         Adjust Node::dispatchFocusEvent argument.
2171         (WebCore::FocusController::advanceFocusInDocumentOrder):
2172         Pass FocusDirectio to Element::focus.
2173         (WebCore::FocusController::setFocusedNode):
2174         Add FocusDirection argument in order to pass it to Document::setFocusedNode.
2175         (WebCore::FocusController::advanceFocusDirectionallyInContainer):
2176         Pass FocusDirectio to Element::focus.
2177         * page/FocusController.h:
2178         (FocusController): Add FocusDirection argument to setFocusedNode.
2179
2180         * dom/Element.cpp:
2181         (WebCore::Element::focus):
2182         Add FocusDirection argument to pass it to FocusController::setFocusedNode.
2183         * dom/Element.h:
2184         (Element): Ditto.
2185
2186         * WebCore.exp.in:
2187         Update FocusController::setFocusedNode and Document::setFocusedNode.
2188
2189         * html/HTMLLabelElement.cpp:
2190         (WebCore::HTMLLabelElement::focus): Adjust FocusDirection argument.
2191         * html/HTMLLabelElement.h:
2192         (HTMLLabelElement): Ditto.
2193         * html/HTMLLegendElement.cpp:
2194         (WebCore::HTMLLegendElement::focus): Ditto.
2195         * html/HTMLLegendElement.h:
2196         (HTMLLegendElement): Ditto.
2197         * html/HTMLSelectElement.cpp:
2198         (WebCore::HTMLSelectElement::dispatchFocusEvent): Ditto.
2199         * html/HTMLSelectElement.h:
2200         (HTMLSelectElement): Ditto.
2201
2202         * html/HTMLInputElement.cpp:
2203         (WebCore::HTMLInputElement::defaultFocus):
2204         Add FocusDirection argument in order to pass it from
2205         HTMLInputElement::focus() to HTMLTextFormControlElement::focus().
2206         (WebCore::HTMLInputElement::focus):
2207         Pass the FocusDirection argument to InputType::focus. See above.
2208         (WebCore::HTMLInputElement::handleFocusEvent):
2209         Adjust FocusDirection argument.
2210         * html/HTMLInputElement.h:
2211         (HTMLInputElement):
2212         * html/InputType.cpp:
2213         (WebCore::InputType::focus): Add FocusDirection argument.
2214         * html/InputType.h:
2215         (InputType): Ditto.
2216
2217         * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
2218         (WebCore::BaseMultipleFieldsDateAndTimeInputType::focus):
2219         Add FocusDirection argument to follow InputType.
2220         * html/BaseMultipleFieldsDateAndTimeInputType.h:
2221         (BaseMultipleFieldsDateAndTimeInputType): Ditto.
2222
2223 2013-02-03  Kassy Coan  <kassycoan@chromium.org>
2224
2225         Adds usage instrumentation for indexedDB
2226         Includes new header file in project files
2227
2228         https://bugs.webkit.org/show_bug.cgi?id=107772
2229
2230         Reviewed by Tony Chang.
2231
2232         Currently untestable. Has zero effect apart from histogramming.
2233
2234         * GNUmakefile.list.am:
2235         * Modules/indexeddb/IDBDatabase.cpp:
2236         (WebCore::IDBDatabase::createObjectStore):
2237         (WebCore::IDBDatabase::deleteObjectStore):
2238         (WebCore::IDBDatabase::transaction):
2239         * Modules/indexeddb/IDBFactory.cpp:
2240         (WebCore::IDBFactory::openInternal):
2241         (WebCore::IDBFactory::deleteDatabase):
2242         * Modules/indexeddb/IDBHistograms.h: Added.
2243         (WebCore):
2244         * Target.pri:
2245         * WebCore.gypi:
2246         * WebCore.vcproj/WebCore.vcproj:
2247         * WebCore.xcodeproj/project.pbxproj:
2248
2249 2013-02-03  Hayato Ito  <hayato@chromium.org>
2250
2251         Split default style-sheet statics out from StyleResolver into its own class
2252         https://bugs.webkit.org/show_bug.cgi?id=107780
2253
2254         Reviewed by Dimitri Glazkov.
2255
2256         Factored static variables and logic about default style sheets out from StyleResolver into its own class
2257         CSSDefaultStyleSheets. This is a following patch after r141373.
2258
2259         No new tests, refactoring only.
2260
2261         * CMakeLists.txt:
2262         * GNUmakefile.list.am:
2263         * Target.pri:
2264         * WebCore.gypi:
2265         * WebCore.xcodeproj/project.pbxproj:
2266         * css/CSSAllInOne.cpp:
2267         * css/CSSDefaultStyleSheets.cpp: Added.
2268         (WebCore):
2269         (WebCore::elementCanUseSimpleDefaultStyle):
2270         (WebCore::screenEval):
2271         (WebCore::printEval):
2272         (WebCore::parseUASheet):
2273         (WebCore::CSSDefaultStyleSheets::initDefaultStyle):
2274         (WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
2275         (WebCore::CSSDefaultStyleSheets::loadSimpleDefaultStyle):
2276         (WebCore::CSSDefaultStyleSheets::viewSourceStyle):
2277         (WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
2278         * css/CSSDefaultStyleSheets.h: Added.
2279         (WebCore):
2280         (CSSDefaultStyleSheets):
2281         * css/StyleResolver.cpp:
2282         (WebCore):
2283         (WebCore::StyleResolver::StyleResolver):
2284         (WebCore::StyleResolver::matchUARules):
2285         (WebCore::StyleResolver::styleForElement):
2286         (WebCore::StyleResolver::styleForPage):
2287         (WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
2288         (WebCore::StyleResolver::collectFeatures):
2289         (WebCore::StyleResolver::reportMemoryUsage):
2290
2291 2013-02-03  Kentaro Hara  <haraken@chromium.org>
2292
2293         [V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
2294         https://bugs.webkit.org/show_bug.cgi?id=108441
2295
2296         Reviewed by Adam Barth.
2297
2298         A complicated condition in GetInternalFields() can be simplified
2299         by using InheritsExtendedAttribute("EventTarget").
2300
2301         No tests. No change in behavior.
2302
2303         * bindings/scripts/CodeGeneratorV8.pm:
2304         (GetInternalFields):
2305         * dom/EventTarget.idl: Added [EventTarget] which should have been added.
2306         * svg/SVGElementInstance.idl: Ditto.
2307
2308 2013-02-03  Gustavo Noronha Silva  <gns@gnome.org>
2309
2310         [Soup] Do not use local variables for the client
2311         https://bugs.webkit.org/show_bug.cgi?id=108714
2312
2313         Reviewed by Martin Robinson.
2314
2315         Covered by existing tests, refactoring code only.
2316
2317         We have had problems in the past with the client being destroyed or
2318         changed inside a method or function, and we ended up with a stale
2319         pointer, leading to crashes. This refactoring is an effort to minimize
2320         the possibility of hitting that same issue in the future.
2321
2322         * platform/network/soup/ResourceHandleSoup.cpp:
2323         (WebCore::redirectSkipCallback): no longer use a local variable to hold
2324         the client.
2325         (WebCore::wroteBodyDataCallback): ditto.
2326         (WebCore::nextMultipartResponsePartCallback): ditto.
2327         (WebCore::sendRequestCallback): ditto.
2328         (WebCore::closeCallback): ditto.
2329         (WebCore::readCallback): ditto.
2330
2331 2013-02-03  Kentaro Hara  <haraken@chromium.org>
2332
2333         [V8] Pass an Isolate to HasInstance() (part 1)
2334         https://bugs.webkit.org/show_bug.cgi?id=108617
2335
2336         Reviewed by Adam Barth.
2337
2338         This is one of efforts to pass an Isolate to GetTemplate().
2339
2340         No tests. No change in behavior.
2341
2342         * bindings/scripts/CodeGeneratorV8.pm:
2343         (JSValueToNative):
2344         * bindings/scripts/test/V8/V8Float64Array.cpp:
2345         (WebCore::Float64ArrayV8Internal::fooCallback):
2346         * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
2347         (WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
2348         * bindings/scripts/test/V8/V8TestEventTarget.cpp:
2349         (WebCore::TestEventTargetV8Internal::dispatchEventCallback):
2350         * bindings/scripts/test/V8/V8TestInterface.cpp:
2351         (WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
2352         (WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
2353         * bindings/scripts/test/V8/V8TestObj.cpp:
2354         (WebCore::TestObjV8Internal::testObjAttrAttrSetter):
2355         (WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
2356         (WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
2357         (WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
2358         (WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
2359         (WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
2360         (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
2361         (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
2362         (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
2363         (WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
2364         (WebCore::TestObjV8Internal::mutablePointAttrSetter):
2365         (WebCore::TestObjV8Internal::immutablePointAttrSetter):
2366         (WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
2367         (WebCore::TestObjV8Internal::longMethodWithArgsCallback):
2368         (WebCore::TestObjV8Internal::objMethodWithArgsCallback):
2369         (WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
2370         (WebCore::TestObjV8Internal::overloadedMethod1Callback):
2371         (WebCore::TestObjV8Internal::overloadedMethod2Callback):
2372         (WebCore::TestObjV8Internal::overloadedMethod8Callback):
2373         (WebCore::TestObjV8Internal::convert1Callback):
2374         (WebCore::TestObjV8Internal::convert2Callback):
2375         (WebCore::TestObjV8Internal::convert4Callback):
2376         (WebCore::TestObjV8Internal::convert5Callback):
2377         (WebCore::TestObjV8Internal::variadicNodeMethodCallback):
2378         * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
2379         (WebCore::V8TestOverloadedConstructors::constructor1Callback):
2380         (WebCore::V8TestOverloadedConstructors::constructor2Callback):
2381         (WebCore::V8TestOverloadedConstructors::constructor3Callback):
2382         * bindings/v8/Dictionary.cpp:
2383         (WebCore::Dictionary::get):
2384         * bindings/v8/ScriptProfiler.cpp:
2385         (WebCore::ScriptProfiler::visitNodeWrappers):
2386         * bindings/v8/SerializedScriptValue.cpp:
2387         (WebCore::SerializedScriptValue::SerializedScriptValue):
2388         (WebCore::SerializedScriptValue::deserialize):
2389         * bindings/v8/V8Binding.cpp:
2390         (WebCore::toDOMStringList):
2391         (WebCore::toXPathNSResolver):
2392         * bindings/v8/V8Binding.h:
2393         (WebCore):
2394         * bindings/v8/V8Collection.cpp:
2395         (WebCore::toOptionsCollectionSetter):
2396         * bindings/v8/V8GCController.cpp:
2397         (WebCore::WrapperVisitor::WrapperVisitor):
2398         (WrapperVisitor):
2399         (WebCore::V8GCController::majorGCPrologue):
2400         * bindings/v8/V8NPObject.cpp:
2401         (WebCore::npObjectInvokeImpl):
2402         * bindings/v8/V8Utilities.cpp:
2403         (WebCore::extractTransferables):
2404         * bindings/v8/custom/V8DocumentCustom.cpp:
2405         (WebCore::V8Document::evaluateCallback):
2406
2407 2013-02-03  Joanmarie Diggs  <jdiggs@igalia.com>
2408
2409         [GTK] Make distcheck fails
2410         https://bugs.webkit.org/show_bug.cgi?id=108756
2411
2412         Reviewed by Kentaro Hara.
2413
2414         * GNUmakefile.list.am: Remove header files which no longer exist;
2415         correct one which got added incorrectly.
2416
2417 2013-02-03  Kentaro Hara  <haraken@chromium.org>
2418
2419         [V8] Pass an Isolate to HasInstance() (part 3)
2420         https://bugs.webkit.org/show_bug.cgi?id=108622
2421
2422         Reviewed by Adam Barth.
2423
2424         This is one of efforts to pass an Isolate to GetTemplate().
2425
2426         No tests. No change in behavior.
2427
2428         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2429         (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
2430         (WebCore::V8InjectedScriptHost::typeCallback):
2431         (WebCore::V8InjectedScriptHost::getEventListenersCallback):
2432         * bindings/v8/custom/V8NodeCustom.cpp:
2433         (WebCore::V8Node::insertBeforeCallback):
2434         (WebCore::V8Node::replaceChildCallback):
2435         (WebCore::V8Node::removeChildCallback):
2436         (WebCore::V8Node::appendChildCallback):
2437         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2438         (WebCore::toWebGLUniformLocation):
2439         (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
2440         (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
2441         (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
2442         (WebCore::V8WebGLRenderingContext::getUniformCallback):
2443         (WebCore::vertexAttribAndUniformHelperf):
2444         (WebCore::uniformHelperi):
2445         (WebCore::uniformMatrixHelper):
2446         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
2447         (WebCore::isDocumentType):
2448         (WebCore::V8XMLHttpRequest::sendCallback):
2449
2450 2013-02-03  Kentaro Hara  <haraken@chromium.org>
2451
2452         [V8] Pass an Isolate to HasInstance() (part 2)
2453         https://bugs.webkit.org/show_bug.cgi?id=108620
2454
2455         Reviewed by Adam Barth.
2456
2457         This is one of efforts to pass an Isolate to GetTemplate().
2458
2459         No tests. No change in behavior.
2460
2461         * bindings/v8/custom/V8ArrayBufferViewCustom.h:
2462         (WebCore::constructWebGLArray):
2463         (WebCore::setWebGLArrayHelper):
2464         * bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
2465         (WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):
2466         * bindings/v8/custom/V8BlobCustom.cpp:
2467         (WebCore::V8Blob::constructorCallbackCustom):
2468         * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
2469         (WebCore::toCanvasStyle):
2470         (WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):
2471         * bindings/v8/custom/V8ClipboardCustom.cpp:
2472         (WebCore::V8Clipboard::setDragImageCallback):
2473         * bindings/v8/custom/V8CryptoCustom.cpp:
2474         (WebCore::V8Crypto::getRandomValuesCallback):
2475         * bindings/v8/custom/V8DOMFormDataCustom.cpp:
2476         (WebCore::V8DOMFormData::constructorCallbackCustom):
2477         (WebCore::V8DOMFormData::appendCallback):
2478         * bindings/v8/custom/V8DataViewCustom.cpp:
2479         (WebCore::V8DataView::constructorCallbackCustom):
2480         * bindings/v8/custom/V8DocumentCustom.cpp:
2481         (WebCore::V8Document::evaluateCallback):
2482         * bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
2483         (WebCore::V8HTMLMediaElement::controllerAccessorSetter):
2484         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
2485         (WebCore::V8HTMLOptionsCollection::addCallback):
2486         * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
2487         (WebCore::removeElement):
2488
2489 2013-02-03  Mike West  <mkwst@chromium.org>
2490
2491         Cleanup: 'ExceptionCode& ec', not 'ExceptionCode &ec'.
2492         https://bugs.webkit.org/show_bug.cgi?id=108769
2493
2494         Reviewed by Eric Seidel.
2495
2496         Does what it says on the tin: reference parameters should read
2497         'type& name', and this patch fixes the two occurances of 'type &name'
2498         that cropped up for ExceptionCode.
2499
2500         Pure style change; no effect on behavior.
2501
2502         * html/HTMLOptionsCollection.cpp:
2503         (WebCore::HTMLOptionsCollection::add):
2504
2505 2013-02-02  Jun Jiang  <jun.a.jiang@intel.com>
2506
2507         Optimize some operations for float type in texture format conversions of WebGL
2508         https://bugs.webkit.org/show_bug.cgi?id=107526
2509
2510         Reviewed by Darin Adler.
2511
2512         Some small changes are made to optimize the operations for float type in the texture format conversion of WebGL to improve performance.
2513
2514         Already covered by current tests.
2515
2516         * platform/graphics/GraphicsContext3D.cpp:
2517         (WebCore):
2518
2519 2013-02-02  Simon Fraser  <simon.fraser@apple.com>
2520
2521         Clean up the storage of dirty bits on nodes in the scrolling state tree
2522         https://bugs.webkit.org/show_bug.cgi?id=108744
2523
2524         Reviewed by Sam Weinig.
2525
2526         ScrollingStateNode and its subclasses used different techniques for
2527         tracking which properties changed. ScrollingStateNode tracked its layers
2528         via a bool member and some layer-specific methods, but also had virtual
2529         methods to allow subclasses to track properties via a bit mask.
2530         
2531         Clean this up by having the base class store the bit mask, and use
2532         enums to specify bits for the various properties. All properties are thus
2533         tracked in the same way. Bits are read and written through non-virtual member
2534         functions on ScrollingStateNode. All bit checking is done via hasChangedProperty().
2535
2536         * page/scrolling/ScrollingStateFixedNode.cpp:
2537         (WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode): m_changedProperties is now on the base class.
2538         (WebCore::ScrollingStateFixedNode::updateConstraints): Use setPropertyChanged()
2539         * page/scrolling/ScrollingStateFixedNode.h: Remove overrides that are no longer needed.
2540         * page/scrolling/ScrollingStateNode.cpp:
2541         (WebCore::ScrollingStateNode::ScrollingStateNode): Initialize m_changedProperties,
2542         m_scrollLayerDidChange no longer tracked separately.
2543         (WebCore::ScrollingStateNode::cloneAndReset):
2544         * page/scrolling/ScrollingStateNode.h:
2545         (WebCore::ScrollingStateNode::hasChangedProperties):
2546         (WebCore::ScrollingStateNode::hasChangedProperty): Tests the bit.
2547         (WebCore::ScrollingStateNode::resetChangedProperties): Set all bits to 0.
2548         (WebCore::ScrollingStateNode::setPropertyChanged): Set the bit.
2549         (WebCore::ScrollingStateNode::changedProperties): Private to discourage incorrect usage
2550         (changeProperties() & foo).
2551         * page/scrolling/ScrollingStateScrollingNode.cpp:
2552         (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): Base class does the copying now.
2553         (WebCore::ScrollingStateScrollingNode::setViewportRect): Use setPropertyChanged().
2554         (WebCore::ScrollingStateScrollingNode::setContentsSize): Ditto.
2555         (WebCore::ScrollingStateScrollingNode::setFrameScaleFactor): Etc.
2556         (WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
2557         (WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
2558         (WebCore::ScrollingStateScrollingNode::setShouldUpdateScrollLayerPositionOnMainThread):
2559         (WebCore::ScrollingStateScrollingNode::setHorizontalScrollElasticity):
2560         (WebCore::ScrollingStateScrollingNode::setVerticalScrollElasticity):
2561         (WebCore::ScrollingStateScrollingNode::setHasEnabledHorizontalScrollbar):
2562         (WebCore::ScrollingStateScrollingNode::setHasEnabledVerticalScrollbar):
2563         (WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarMode):
2564         (WebCore::ScrollingStateScrollingNode::setVerticalScrollbarMode):
2565         (WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
2566         (WebCore::ScrollingStateScrollingNode::setScrollOrigin):
2567         * page/scrolling/ScrollingStateScrollingNode.h:
2568         (ScrollingStateScrollingNode):
2569         * page/scrolling/ScrollingStateStickyNode.cpp:
2570         (WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
2571         (WebCore::ScrollingStateStickyNode::updateConstraints):
2572         * page/scrolling/ScrollingStateStickyNode.h:
2573         * page/scrolling/ScrollingTree.cpp:
2574         (WebCore::ScrollingTree::commitNewTreeState):
2575         * page/scrolling/ScrollingTreeScrollingNode.cpp:
2576         (WebCore::ScrollingTreeScrollingNode::update):
2577         * page/scrolling/mac/ScrollingStateNodeMac.mm:
2578         (WebCore::ScrollingStateNode::setScrollLayer):
2579         * page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
2580         (WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
2581         * page/scrolling/mac/ScrollingTreeFixedNode.mm:
2582         (WebCore::ScrollingTreeFixedNode::update):
2583         * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
2584         (WebCore::ScrollingTreeScrollingNodeMac::update):
2585         * page/scrolling/mac/ScrollingTreeStickyNode.mm:
2586         (WebCore::ScrollingTreeStickyNode::update):
2587
2588 2013-02-02  Simon Fraser  <simon.fraser@apple.com>
2589
2590         Fixed and sticky nodes have no nodeID set
2591         https://bugs.webkit.org/show_bug.cgi?id=108734
2592
2593         Reviewed by Sam Weinig.
2594         
2595         Push ScrollingNodeIDs onto scrolling nodes at construction time, and thereafter
2596         treat them as readonly. Previously, only the root scrolling node would have a node ID.
2597         
2598         Node IDs aren't actually used by the scrolling tree yet, but are useful for debugging.
2599
2600         Not testable since we only dump the scrolling state tree, not the scrolling
2601         node tree in tests.
2602
2603         * page/scrolling/ScrollingTree.cpp:
2604         (WebCore::ScrollingTree::ScrollingTree): No longer create the root node here;
2605         we can only create it when we know what its ID will be.
2606         (WebCore::ScrollingTree::updateTreeFromStateNode): Create the root node if
2607         necessary. Pass node IDs into create methods.
2608         * page/scrolling/ScrollingTreeNode.cpp:
2609         (WebCore::ScrollingTreeNode::ScrollingTreeNode):
2610         * page/scrolling/ScrollingTreeNode.h:
2611         * page/scrolling/ScrollingTreeScrollingNode.cpp:
2612         (WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
2613         * page/scrolling/ScrollingTreeScrollingNode.h:
2614         * page/scrolling/mac/ScrollingTreeFixedNode.h:
2615         * page/scrolling/mac/ScrollingTreeFixedNode.mm:
2616         (WebCore::ScrollingTreeFixedNode::create):
2617         (WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
2618         * page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
2619         * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
2620         (WebCore::ScrollingTreeScrollingNode::create):
2621         (WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
2622         * page/scrolling/mac/ScrollingTreeStickyNode.h:
2623         * page/scrolling/mac/ScrollingTreeStickyNode.mm:
2624         (WebCore::ScrollingTreeStickyNode::create):
2625         (WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):
2626
2627 2013-02-02  Takashi Sakamoto  <tasak@google.com>
2628
2629         Making -webkit-image-set() the first value of background property causes crash.
2630         https://bugs.webkit.org/show_bug.cgi?id=108409
2631
2632         Reviewed by Beth Dakin.
2633
2634         CSSParser::addFillValue should use lval->isBaseValueList() instead
2635         of lval->isValueList(). If lval is -webkit-image-set, rval is appended
2636         to -webkit-image-set.
2637
2638         Test: fast/css/image-set-value-crash-in-fillImageSet.html
2639
2640         * css/CSSParser.cpp:
2641         (WebCore::CSSParser::addFillValue):
2642         If lval is not a value list, lval is initialized by using
2643         CSSValueList::createCommaSeparated(). So we have to check whether
2644         lval is created by CSSValueList::createCommaSeparated() or not.
2645
2646 2013-02-02  David Kilzer  <ddkilzer@apple.com>
2647
2648         Upstream iOS FeatureDefines
2649         <http://webkit.org/b/108753>
2650
2651         Reviewed by Anders Carlsson.
2652
2653         * Configurations/FeatureDefines.xcconfig:
2654         - ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
2655         - ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
2656         - FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO.  Add
2657           PLATFORM_NAME variant to reduce future merge conflicts. 
2658
2659 2013-02-02  Philippe Normand  <pnormand@igalia.com>
2660
2661         [GStreamer] Media tests fix after r141695.
2662
2663         Rubber-stamped by Martin Robinson.
2664
2665         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
2666         (WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL): Remove
2667         both fragment and query string for file:// uris before loading.
2668
2669 2013-02-02  Patrick Gansterer  <paroga@webkit.org>
2670
2671         Build fix for WinCE after r141637.
2672
2673         * platform/graphics/wince/ImageBufferWinCE.cpp:
2674
2675 2013-02-01  Philippe Normand  <pnormand@igalia.com>
2676
2677         [GStreamer] webkitwebsrc is exposed to application-side
2678         https://bugs.webkit.org/show_bug.cgi?id=108088
2679
2680         Reviewed by Martin Robinson.
2681
2682         Switch the webkitwebsrc to handle webkit+http(s) uris so it is now
2683         explicit that this element is meant to be used preferrably inside
2684         WebKit. This change is internal to the player.
2685
2686         No new tests, covered by existing http/tests/media tests.
2687
2688         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
2689         (WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL):
2690         (WebCore):
2691         (WebCore::MediaPlayerPrivateGStreamer::load):
2692         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2693         (MediaPlayerPrivateGStreamer):
2694         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
2695         (webKitWebSrcGetProtocols):
2696         (webKitWebSrcSetUri):
2697
2698 2013-02-02  Simon Hausmann  <simon.hausmann@digia.com>
2699
2700         Unreviewed trivial prospective build fix for A17n disabled
2701         configurations.
2702
2703         The dummy computed object attriute cache control functions need to be defined
2704         as being member functions of AXObjectCache, because that's where they are
2705         declared.
2706
2707         * accessibility/AXObjectCache.h:
2708         (WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
2709         (WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
2710
2711 2013-02-02  Antoine Quint  <graouts@apple.com>
2712
2713         Creating a WebInspector.ContextMenu without an event crashes WebCore when calling .show()
2714         https://bugs.webkit.org/show_bug.cgi?id=108636
2715
2716         Reviewed by Pavel Feldman.
2717
2718         Return early if InspectorFrontendHost::showContextMenu() is called without an event and
2719         assert in ContextMenuController::createContextMenu() in case no event was provided.
2720
2721         * inspector/InspectorFrontendHost.cpp:
2722         (WebCore::InspectorFrontendHost::showContextMenu):
2723         * page/ContextMenuController.cpp:
2724         (WebCore::ContextMenuController::createContextMenu):
2725
2726 2013-02-02  Jonathan Feldstein  <jfeldstein@rim.com>
2727
2728         [BlackBerry] Improper initialization of ANGLEResources
2729         https://bugs.webkit.org/show_bug.cgi?id=101489
2730
2731         Reviewed by Antonio Gomes.
2732
2733         MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle have already been initialized through ShBuiltInResources function and these fields do not need to be set again in GraphicsContext3dBlackBerry.cpp. In addition, the extension flags cannot be set to true without getExtension having been called (Khronos WebGL specs, section 5.14.14.). Thus these lines need to be removed.
2734
2735         * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
2736         (WebCore::GraphicsContext3D::GraphicsContext3D):
2737
2738 2013-02-02  Vivek Galatage  <vivek.vg@samsung.com>
2739
2740         Web Inspector: Refactor InspectorDOMStorageAgent::getDOMStorageEntries to report the error messages
2741         https://bugs.webkit.org/show_bug.cgi?id=108611
2742
2743         Reviewed by Pavel Feldman.
2744
2745         Added reporting of various error messages. Moved the modification of output
2746         parameter at a later stage when there are no errors reported.
2747
2748         No new tests as code refactoring.
2749
2750         * inspector/InspectorDOMStorageAgent.cpp:
2751         (WebCore::hadException):
2752         (WebCore):
2753         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
2754
2755 2013-02-02  Andrey Lushnikov  <lushnikov@chromium.org>
2756
2757         Web Inspector: fix bug in highlighting single chars via highlightRange API of DTE
2758         https://bugs.webkit.org/show_bug.cgi?id=108685
2759
2760         Reviewed by Pavel Feldman.
2761
2762         Use Math.min instead of Math.max in rangesForLine method.
2763
2764         Updated test: text-editor-highlight-api.html
2765
2766         * inspector/front-end/DefaultTextEditor.js:
2767         (WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.rangesForLine):
2768
2769 2013-02-02  Tony Gentilcore  <tonyg@chromium.org>
2770
2771         Continue making XSSAuditor thread safe: Remove unsafe AtomicString compares
2772         https://bugs.webkit.org/show_bug.cgi?id=108557
2773
2774         Reviewed by Adam Barth.
2775
2776         Unfortunately HTMLNames comparisons will always be false on a non-main thread
2777         with our current design, so we have to use some "threadSafeMatch" helpers written
2778         for the HTMLBackgroundParser.
2779
2780         Also factor out threadSafeMatch() methods to HTMLParserIdioms.
2781
2782         No new tests because no new functionality.
2783
2784         * html/parser/BackgroundHTMLParser.cpp:
2785         (WebCore):
2786         * html/parser/HTMLParserIdioms.cpp:
2787         (WebCore::threadSafeEqual):
2788         (WebCore):
2789         (WebCore::threadSafeMatch):
2790         * html/parser/HTMLParserIdioms.h:
2791         (WebCore):
2792         * html/parser/XSSAuditor.cpp:
2793         (WebCore::XSSAuditor::eraseAttributeIfInjected):
2794
2795 2013-02-01  James Simonsen  <simonjam@chromium.org>
2796
2797         Add didChangePriority() to ResourceHandle
2798         https://bugs.webkit.org/show_bug.cgi?id=107995
2799
2800         Reviewed by Darin Fisher.
2801
2802         For PLT, it's important that preloads remain a lower priority than parser requested resources.
2803         This can lead to a 5% improvement.
2804
2805         The plan is to use this plumbing to expose the desired behavior. This patch simply allows a
2806         resource's priority to change and have it propagate to the network layer. An upcoming patch will
2807         lower the priority of preloads and then increase the priority when the parser officially requests
2808         it.
2809
2810         No new tests. No visible change, because priority doesn't change yet.
2811
2812         * loader/cache/CachedResource.cpp:
2813         (WebCore):
2814         (WebCore::CachedResource::setLoadPriority):
2815         * loader/cache/CachedResourceLoader.cpp:
2816         (WebCore::CachedResourceLoader::requestResource): Allow loads to modify priority.
2817         * loader/cache/CachedResourceRequest.h:
2818         (WebCore::CachedResourceRequest::setPriority): Notify when priority changes.
2819         * platform/network/ResourceHandle.cpp:
2820         (WebCore::ResourceHandle::didChangePriority): Added.
2821         (WebCore):
2822         * platform/network/ResourceHandle.h:
2823         (ResourceHandle):
2824         * platform/network/chromium/ResourceHandle.cpp:
2825         (WebCore::ResourceHandleInternal::didChangePriority):
2826         (WebCore):
2827         (WebCore::ResourceHandle::didChangePriority):
2828         * platform/network/chromium/ResourceHandleInternal.h:
2829         (ResourceHandleInternal):
2830
2831 2013-02-01  Roger Fong  <roger_fong@apple.com>
2832
2833         Unreviewed. Clean up WebCore VS2010 project.
2834
2835         * WebCore.vcxproj/WebCore.vcxproj:
2836         * WebCore.vcxproj/WebCore.vcxproj.filters:
2837         * WebCore.vcxproj/WebCoreCommon.props:
2838         * WebCore.vcxproj/WebCoreGenerated.make:
2839         * WebCore.vcxproj/WebCorePreLink.cmd: Removed.
2840         * WebCore.vcxproj/build-generated-files.sh:
2841
2842 2013-02-01  Sam Weinig  <sam@webkit.org>
2843
2844         Don't use deprecated method -[NSImage dissolveToPoint:fraction:]
2845         <rdar://problem/11723792>
2846         https://bugs.webkit.org/show_bug.cgi?id=108739
2847
2848         Reviewed by Anders Carlsson.
2849
2850         * platform/mac/DragImageMac.mm:
2851         (WebCore::dissolveDragImageToFraction):
2852         Remove use of deprecated NSImage methods and simplify a bit.
2853
2854 2013-02-01  Andrey Lushnikov  <lushnikov@chromium.org>
2855
2856         Web Inspector: fix "DOM Exception 8" when deleting lines containing decoration in DTE.
2857         https://bugs.webkit.org/show_bug.cgi?id=108689
2858
2859         Reviewed by Alexander Pavlov.
2860
2861         Add a check that decoration element is still added to the line before trying to delete it. This
2862         won't be true if the whole line is deleted in contentEditable,
2863         and this is the reason for the exception to be thrown.
2864
2865         No new tests.
2866
2867         * inspector/front-end/DefaultTextEditor.js:
2868         (WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
2869
2870 2013-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2871
2872         Unreviewed, rolling out r141669.
2873         http://trac.webkit.org/changeset/141669
2874         https://bugs.webkit.org/show_bug.cgi?id=108728
2875
2876         Broke the windows build. (Requested by leviw on #webkit).
2877
2878         * rendering/RenderBoxModelObject.cpp:
2879         (WebCore::RenderBoxModelObject::computedCSSPaddingTop):
2880         (WebCore):
2881         (WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
2882         (WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
2883         (WebCore::RenderBoxModelObject::computedCSSPaddingRight):
2884         (WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
2885         (WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
2886         (WebCore::RenderBoxModelObject::computedCSSPaddingStart):
2887         (WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
2888         * rendering/RenderBoxModelObject.h:
2889         (RenderBoxModelObject):
2890
2891 2013-02-01  Emil A Eklund  <eae@chromium.org>
2892
2893         Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
2894         https://bugs.webkit.org/show_bug.cgi?id=108707
2895
2896         Reviewed by Levi Weintraub.
2897         
2898         The computedCSSPaddingTop/Bottom/... methods in
2899         RenderBoxModelObject all do pretty much exactly the same thing
2900         yet share no code.
2901         
2902         Break out shared code into computedCSSPadding method and have
2903         the top/bottom/left/right/... ones call it with the appropriate
2904         length value.
2905
2906         No new tests, no change in functionality.
2907
2908         * rendering/RenderBoxModelObject.cpp:
2909         (WebCore::RenderBoxModelObject::computedCSSPadding):
2910         * rendering/RenderBoxModelObject.h:
2911         (WebCore::RenderBoxModelObject::computedCSSPaddingTop):
2912         (WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
2913         (WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
2914         (WebCore::RenderBoxModelObject::computedCSSPaddingRight):
2915         (WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
2916         (WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
2917         (WebCore::RenderBoxModelObject::computedCSSPaddingStart):
2918         (WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
2919         (RenderBoxModelObject):
2920
2921 2013-02-01  Mark Lam  <mark.lam@apple.com>
2922
2923         Replace ExceptionCode with DatabaseError in the openDatabase() code path.
2924         https://bugs.webkit.org/show_bug.cgi?id=108724.
2925
2926         Reviewed by Alexey Proskuryakov.
2927
2928         Also made DatabaseBackend::performOpenAndVerify() a little more
2929         straightforward and less repetitive.
2930
2931         No new tests.
2932
2933         * Modules/webdatabase/DOMWindowWebDatabase.cpp:
2934         (WebCore::DOMWindowWebDatabase::openDatabase):
2935         * Modules/webdatabase/Database.cpp:
2936         (WebCore::Database::openAndVerifyVersion):
2937         (WebCore::Database::performOpenAndVerify):
2938         * Modules/webdatabase/Database.h:
2939         (Database):
2940         * Modules/webdatabase/DatabaseBackend.cpp:
2941         (WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
2942         (WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
2943         (DoneCreatingDatabaseOnExitCaller):
2944         (WebCore::DoneCreatingDatabaseOnExitCaller::openSucceeded):
2945         (WebCore::DatabaseBackend::performOpenAndVerify):
2946         * Modules/webdatabase/DatabaseBackend.h:
2947         * Modules/webdatabase/DatabaseManager.cpp:
2948         (WebCore::DatabaseManager::openDatabase):
2949         (WebCore::DatabaseManager::openDatabaseSync):
2950         * Modules/webdatabase/DatabaseManager.h:
2951         (DatabaseManager):
2952         * Modules/webdatabase/DatabaseSync.cpp:
2953         (WebCore::DatabaseSync::openAndVerifyVersion):
2954         * Modules/webdatabase/DatabaseSync.h:
2955         (DatabaseSync):
2956         * Modules/webdatabase/DatabaseTask.cpp:
2957         (WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
2958         (WebCore::Database::DatabaseOpenTask::doPerformTask):
2959         * Modules/webdatabase/DatabaseTask.h:
2960         (WebCore::Database::DatabaseOpenTask::create):
2961         (Database::DatabaseOpenTask):
2962         * Modules/webdatabase/WorkerContextWebDatabase.cpp:
2963         (WebCore::WorkerContextWebDatabase::openDatabase):
2964         (WebCore::WorkerContextWebDatabase::openDatabaseSync):
2965         * WebCore.gypi:
2966
2967 2013-02-01  Yongjun Zhang  <yongjun_zhang@apple.com>
2968
2969         Document is never released if an image's src attribute is changed to a url blocked by content-security-policy.
2970         https://bugs.webkit.org/show_bug.cgi?id=108545
2971
2972         If we just scheduled an error event due to an null newImage, we should not cancel it when newImage and oldImage
2973         is not the same.  Otherwise we will ref the sourceElement in updateHasPendingEvent (m_hasPendingErrorEvent is true)
2974         but never deref it since we already cancelled the error event.
2975
2976         Reviewed by Alexey Proskuryakov.
2977
2978         Test: fast/images/image-error-event-not-firing.html
2979
2980         * loader/ImageLoader.cpp:
2981         (WebCore::ImageLoader::updateFromElement): don't cancel error event if newImage is null, we want the
2982             error event to fire.
2983
2984 2013-02-01  Benjamin Poulain  <bpoulain@apple.com>
2985
2986         Clean the String->AtomicString conversion for AnimationController::pauseAnimationAtTime
2987         https://bugs.webkit.org/show_bug.cgi?id=108558
2988
2989         Reviewed by Dean Jackson.
2990
2991         This is a step torward killing the implicit conversion from String to AtomicString.
2992
2993         The animation name are AtomicString. The API is changed all the way to the callers
2994         to take an AtomicString. When needed, we use explicit conversion.
2995
2996         * WebCore.exp.in:
2997         * page/animation/AnimationController.cpp:
2998         (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
2999         (WebCore::AnimationController::pauseAnimationAtTime):
3000         * page/animation/AnimationController.h:
3001         (AnimationController):
3002         * page/animation/AnimationControllerPrivate.h:
3003         (AnimationControllerPrivate):
3004         * page/animation/CompositeAnimation.cpp:
3005         (WebCore::CompositeAnimation::pauseAnimationAtTime):
3006         We should not null check the name. Getting a null name from the HashMap would be
3007         an error from the tests, and the HashMap would never return a value anyway.
3008         * testing/Internals.cpp:
3009         (WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):
3010
3011 2013-02-01  Dominic Mazzoni  <dmazzoni@google.com>
3012
3013         AX: memoize expensive computation during blocks where tree doesn't change
3014         https://bugs.webkit.org/show_bug.cgi?id=106497
3015
3016         Reviewed by Ryosuke Niwa.
3017
3018         Add a cache for computed attributes of AXObjects.
3019         The cache can be enabled at the start of a batch of
3020         read-only operations on the accessibility tree, and
3021         it's cleared automatically when the tree mutates.
3022         Currently accessibilityIsIgnored is cached, since it's
3023         frequently called and relatively expensive to compute.
3024
3025         No new tests.
3026
3027         * accessibility/AXObjectCache.cpp:
3028         (WebCore):
3029         (WebCore::AXComputedObjectAttributeCache::getIgnored):
3030         (WebCore::AXComputedObjectAttributeCache::setIgnored):
3031         (WebCore::AXObjectCache::postNotification):
3032         (WebCore::AXObjectCache::nodeTextChangeNotification):
3033         (WebCore::AXObjectCache::handleScrollbarUpdate):
3034         (WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
3035         (WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
3036         * accessibility/AXObjectCache.h:
3037         (AXComputedObjectAttributeCache):
3038         (WebCore::AXComputedObjectAttributeCache::create):
3039         (WebCore::AXComputedObjectAttributeCache::AXComputedObjectAttributeCache):
3040         (WebCore::AXComputedObjectAttributeCache::CachedAXObjectAttributes::CachedAXObjectAttributes):
3041         (CachedAXObjectAttributes):
3042         (WebCore):
3043         (WebCore::AXObjectCache::computedObjectAttributeCache):
3044         (AXObjectCache):
3045         (WebCore::AXComputedObjectAttributeCache::getIgnored):
3046         (WebCore::AXComputedObjectAttributeCache::setIgnored):
3047         (WebCore::startCachingComputedObjectAttributesUntilTreeMutates):
3048         (WebCore::stopCachingComputedObjectAttributes):
3049         * accessibility/AccessibilityObject.cpp:
3050         (WebCore::AccessibilityObject::findMatchingObjects):
3051         * accessibility/AccessibilityRenderObject.cpp:
3052         (WebCore):
3053         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
3054         (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
3055         * accessibility/AccessibilityRenderObject.h:
3056         (AccessibilityRenderObject):
3057
3058 2013-02-01  Alexey Proskuryakov  <ap@apple.com>
3059
3060         Build fix.
3061
3062         * Modules/webdatabase/DatabaseBackend.cpp: (DoneCreatingDatabaseOnExitCaller):
3063         Don't fail because of an unused member variable in cross-plaform code path.
3064
3065 2013-02-01  Kevin Ellis  <kevers@chromium.org>
3066
3067         [chromium] Fat scrollbars on Windows in high-DPI mode.
3068         https://bugs.webkit.org/show_bug.cgi?id=108637
3069
3070         Updates mechanism for retrieving scrollbar metrics on the
3071         Windows port of Chromium.  Previously, GetSystemMetrics calls
3072         were used, which fetches prescaled sizes in pixel rather than
3073         logical units, resulting in a double scaling when a device
3074         scale factor is set.  With the patch, the size is retrieved
3075         from the theme engine in DIP.
3076
3077         Reviewed by Adam Barth.
3078
3079         No new tests.
3080
3081         * platform/chromium/ScrollbarThemeChromiumWin.cpp:
3082         (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
3083         (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
3084         * rendering/RenderThemeChromiumWin.cpp:
3085         (WebCore):
3086         (WebCore::menuListButtonWidth):
3087
3088 2013-02-01  Mark Lam  <mark.lam@apple.com>
3089
3090         Clean up calls to DatabaseTracker::add/removeOpenDatabase().
3091         https://bugs.webkit.org/show_bug.cgi?id=108431
3092
3093         Reviewed by Geoffrey Garen.
3094
3095         Also adapted the chromium port to work with this new code.
3096         Chromium parts reviewed by Michael Nordman and David Levin.
3097
3098         This is part of the webdatabase refactoring effort.
3099
3100         No new tests.
3101
3102         * Modules/webdatabase/AbstractDatabaseServer.h:
3103         (AbstractDatabaseServer):
3104         * Modules/webdatabase/Database.cpp:
3105         (WebCore::Database::openAndVerifyVersion):
3106         (WebCore::Database::close):
3107         * Modules/webdatabase/DatabaseBackend.cpp:
3108         (WebCore::DatabaseBackend::DatabaseBackend):
3109         (WebCore::DatabaseBackend::closeDatabase):
3110         (DoneCreatingDatabaseOnExitCaller):
3111         (WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
3112         (WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
3113         (WebCore::DatabaseBackend::performOpenAndVerify):
3114         * Modules/webdatabase/DatabaseManager.cpp:
3115         (WebCore::DatabaseManager::openDatabase):
3116         (WebCore::DatabaseManager::openDatabaseSync):
3117         * Modules/webdatabase/DatabaseManager.h:
3118         (DatabaseManager):
3119         * Modules/webdatabase/DatabaseServer.cpp:
3120         * Modules/webdatabase/DatabaseServer.h:
3121         * Modules/webdatabase/DatabaseSync.cpp:
3122         (WebCore::DatabaseSync::~DatabaseSync):
3123         (WebCore::DatabaseSync::openAndVerifyVersion):
3124         (WebCore::DatabaseSync::closeImmediately):
3125         * Modules/webdatabase/DatabaseSync.h:
3126         (DatabaseSync):
3127         * Modules/webdatabase/DatabaseTracker.cpp:
3128         (WebCore::DatabaseTracker::doneCreatingDatabase):
3129         (WebCore::DatabaseTracker::addOpenDatabase):
3130         * Modules/webdatabase/DatabaseTracker.h:
3131         (DatabaseTracker):
3132         * Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
3133         (WebCore::DatabaseTracker::addOpenDatabase):
3134         (WebCore::DatabaseTracker::prepareToOpenDatabase):
3135         (WebCore::DatabaseTracker::failedToOpenDatabase):
3136
3137 2013-02-01  Andrey Lushnikov  <lushnikov@chromium.org>
3138
3139         Web Inspector: remove extra padding around overlay highlight.
3140         https://bugs.webkit.org/show_bug.cgi?id=108679
3141
3142         Reviewed by Alexander Pavlov.
3143
3144         No new tests: no change in behaviour.
3145
3146         Remove extraWidth from overlay highlight spans.
3147
3148         * inspector/front-end/DefaultTextEditor.js:
3149         (WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
3150
3151 2013-02-01  Philip Rogers  <pdr@google.com>
3152
3153         Prevent skipped repaints for children of inner SVG elements
3154         https://bugs.webkit.org/show_bug.cgi?id=108429
3155
3156         Reviewed by Eric Seidel.
3157
3158         This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
3159         of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
3160         containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.
3161
3162         I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
3163         with this patch.
3164
3165         Test: svg/repaint/svgsvgelement-repaint-children.html
3166
3167         * rendering/svg/RenderSVGViewportContainer.cpp:
3168         (WebCore::RenderSVGViewportContainer::calcViewport):
3169
3170             This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.
3171
3172         (WebCore::RenderSVGViewportContainer::calculateLocalTransform):
3173
3174             This change is straightforward and is similar to the equivalent assignment in
3175             RenderSVGTransformableContainer::calculateLocalTransform().
3176
3177 2013-02-01  Philip Rogers  <pdr@google.com>
3178
3179         Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
3180         https://bugs.webkit.org/show_bug.cgi?id=106966
3181
3182         Reviewed by Stephen White.
3183
3184         Previously, Image::currentFrameHasAlpha's default implementation returned false so SVG
3185         images always returned false for currentFrameHasAlpha. Additionally, currentFrameHasAlpha
3186         was treated as returning whether the frame had alpha when it would actually conservatively
3187         return true.
3188
3189         This patch renames hasAlpha and currentFrameHasAlpha to isKnownToBeOpaque and
3190         currentFrameIsKnownToBeOpaque, respectively. This rename better describes the actual
3191         functionality. This patch also makes Image::isKnownToBeOpaque a pure virtual function and
3192         correctly implements it for SVG images.
3193
3194         All users of isKnownToBeOpaque access SVG images using CachedImage::imageForRenderer which
3195         currently returns a cached bitmap image. Therefore, this patch will not affect existing
3196         functionality. A regression test has been added that will catch if this changes in the
3197         future (e.g., WK106159 which proposes not returning cached bitmaps). The now unnecessary
3198         isBitmapImage() calls have been removed in this patch.
3199
3200         image-box-shadow.html has been modified to test SVG images.
3201
3202         * css/CSSCrossfadeValue.cpp:
3203         (WebCore::subimageKnownToBeOpaque):
3204         (WebCore::CSSCrossfadeValue::knownToBeOpaque):
3205
3206             Mostly straightforward rename but note the logic has been slightly altered: AND -> OR.
3207
3208         * css/CSSCrossfadeValue.h:
3209         (CSSCrossfadeValue):
3210         * css/CSSGradientValue.cpp:
3211         (WebCore::CSSGradientValue::knownToBeOpaque):
3212         * css/CSSGradientValue.h:
3213         (CSSGradientValue):
3214         * css/CSSImageGeneratorValue.cpp:
3215         (WebCore::CSSImageGeneratorValue::knownToBeOpaque):
3216         * css/CSSImageGeneratorValue.h:
3217         (CSSImageGeneratorValue):
3218         * css/CSSImageValue.cpp:
3219         (WebCore::CSSImageValue::knownToBeOpaque):
3220         * css/CSSImageValue.h:
3221         (CSSImageValue):
3222         * loader/cache/CachedImage.cpp:
3223         (WebCore::CachedImage::currentFrameKnownToBeOpaque):
3224         * loader/cache/CachedImage.h:
3225         (CachedImage):
3226         * platform/graphics/BitmapImage.cpp:
3227         (WebCore::BitmapImage::currentFrameKnownToBeOpaque):
3228         * platform/graphics/BitmapImage.h:
3229         (BitmapImage):
3230         * platform/graphics/GeneratedImage.h:
3231         (GeneratedImage):
3232         * platform/graphics/Image.h:
3233
3234             Note: now a pure virtual function!
3235
3236         (Image):
3237         * platform/graphics/blackberry/LayerTiler.cpp:
3238         (WebCore::LayerTiler::updateTextureContentsIfNeeded):
3239
3240             Removed unnecessary isBitmapImage() checks.
3241
3242         * platform/graphics/cg/GraphicsContext3DCG.cpp:
3243         (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
3244
3245             Removed unnecessary isBitmapImage() checks.
3246
3247         * platform/graphics/cg/PDFDocumentImage.h:
3248         (PDFDocumentImage):
3249         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3250
3251             Removed unnecessary isBitmapImage() checks.
3252
3253         (WebCore::GraphicsLayerChromium::setContentsToImage):
3254         * platform/graphics/qt/StillImageQt.cpp:
3255         (WebCore::StillImage::currentFrameKnownToBeOpaque):
3256         * platform/graphics/qt/StillImageQt.h:
3257         (StillImage):
3258         * platform/graphics/skia/BitmapImageSingleFrameSkia.cpp:
3259         (WebCore::BitmapImageSingleFrameSkia::currentFrameKnownToBeOpaque):
3260         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
3261         (BitmapImageSingleFrameSkia):
3262         * platform/graphics/texmap/TextureMapperBackingStore.cpp:
3263         (WebCore::TextureMapperTile::updateContents):
3264         (WebCore::TextureMapperTiledBackingStore::updateContents):
3265         * platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
3266         (WebCore::CoordinatedImageBacking::update):
3267         * rendering/RenderImage.cpp:
3268         (WebCore::RenderImage::backgroundIsObscured):
3269
3270             Removed unnecessary isBitmapImage() checks and slightly reworked the logic.
3271
3272         * rendering/style/FillLayer.cpp:
3273         (WebCore::FillLayer::hasOpaqueImage):
3274         * rendering/style/StyleCachedImage.cpp:
3275         (WebCore::StyleCachedImage::knownToBeOpaque):
3276         * rendering/style/StyleCachedImage.h:
3277         (StyleCachedImage):
3278         * rendering/style/StyleCachedImageSet.cpp:
3279         (WebCore::StyleCachedImageSet::knownToBeOpaque):
3280         * rendering/style/StyleCachedImageSet.h:
3281         (StyleCachedImageSet):
3282         * rendering/style/StyleGeneratedImage.cpp:
3283         (WebCore::StyleGeneratedImage::knownToBeOpaque):
3284         * rendering/style/StyleGeneratedImage.h:
3285         (StyleGeneratedImage):
3286         * rendering/style/StyleImage.h:
3287         (StyleImage):
3288         * rendering/style/StylePendingImage.h:
3289         (WebCore::StylePendingImage::knownToBeOpaque):
3290         * svg/graphics/SVGImage.h:
3291         (SVGImage):
3292
3293 2013-02-01  Brady Eidson  <beidson@apple.com>
3294
3295         Clean up WebArchive loading with the NetworkProcess
3296         <rdar://problem/12695840> and https://bugs.webkit.org/show_bug.cgi?id=108673
3297
3298         Reviewed by Alexey Proskuryakov.
3299
3300         No new tests (No change in WebCore behavior).
3301
3302         Remove a now unneeded function and add a needed export.
3303
3304         * WebCore.exp.in:
3305         * loader/ResourceLoadScheduler.cpp:
3306         * loader/ResourceLoadScheduler.h:
3307
3308 2013-02-01  Alok Priyadarshi  <alokp@chromium.org>
3309
3310         Print GraphicsLayer::m_contentsOpaque if non-default (true)
3311         https://bugs.webkit.org/show_bug.cgi?id=108354
3312
3313         Reviewed by Simon Fraser.
3314
3315         No new tests. This change facilitates testing of GraphicsLayer opaqueness.
3316
3317         * platform/graphics/GraphicsLayer.cpp:
3318         (WebCore::GraphicsLayer::dumpProperties):
3319
3320 2013-02-01  Tony Gentilcore  <tonyg@chromium.org>
3321
3322         Continue making XSSAuditor thread safe: Remove dependency on parser's Document URL
3323         https://bugs.webkit.org/show_bug.cgi?id=108655
3324
3325         Reviewed by Adam Barth.
3326
3327         No new tests because no new functionality.
3328
3329         * html/parser/XSSAuditor.cpp:
3330         (WebCore::XSSAuditor::XSSAuditor):
3331         (WebCore::XSSAuditor::init):
3332         (WebCore::XSSAuditor::isLikelySafeResource):
3333         * html/parser/XSSAuditor.h:
3334
3335 2013-02-01  Jer Noble  <jer.noble@apple.com>
3336
3337         REGRESSION (r141281): Navigating to this HTTP Live Streaming (application/vnd.apple.mpegurl) URL downloads a file instead of playing it in the browser
3338         https://bugs.webkit.org/show_bug.cgi?id=108674
3339         <rdar://problem/13133595>
3340
3341         Reviewed by Eric Carlson.
3342
3343         When passed a HashSet of available MIME types to fill out, QTKit was overwriting the contents, which were
3344         AVFoundation's supported types. Instead, it should be appending to the list of supported types.
3345
3346         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
3347         (WebCore::concatenateHashSets): Added static utility function.
3348         (WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Concatenate instead of overwriting the passed in MIME types.
3349
3350 2013-02-01  Beth Dakin  <bdakin@apple.com>
3351
3352         Another speculative windows build fix.
3353
3354         * platform/ScrollAnimator.h:
3355
3356 2013-01-31  Dirk Schulze  <krit@webkit.org>
3357
3358         [canvas] Add more constructors to Path
3359         https://bugs.webkit.org/show_bug.cgi?id=108587
3360
3361         Reviewed by Dean Jackson.
3362
3363         Add more constructors to Path object to make it possible
3364         to copy Path objects and parse SVG strings into a Path
3365         object that can be used on the canvas context afterwards.
3366
3367         Test: fast/canvas/canvas-path-constructors.html
3368
3369         * html/canvas/DOMPath.h: New constructors for Path.
3370         (WebCore::DOMPath::create):
3371         (WebCore::DOMPath::DOMPath):
3372         * html/canvas/DOMPath.idl: Ditto.
3373
3374 2013-02-01  Zan Dobersek  <zdobersek@igalia.com>
3375
3376         [GTK] Add WTFURL source files to the build
3377         https://bugs.webkit.org/show_bug.cgi?id=108215
3378
3379         Reviewed by Benjamin Poulain.
3380
3381         * platform/KURLWTFURL.cpp:
3382         (WebCore): Only use the stub implementation of the fileSystemPath method for the
3383         Apple ports, other ports should for now still rely on their platform-specific implementations.
3384
3385 2013-02-01  Mike West  <mkwst@chromium.org>
3386
3387         Remove call to SecurityOrigin::canAccessDatabase from IDB constructor.
3388         https://bugs.webkit.org/show_bug.cgi?id=108477
3389
3390         Reviewed by Adam Barth.
3391
3392         This change removes the 'SecurityOrigin::canAccessDatabase' check from
3393         the constructor for the 'indexedDB' property on both DOMWindow and
3394         WorkerContext. After the patch for http://wkbug.com/94171 this check
3395         is redundant, as all the entry points to IDB are now gated on access
3396         being granted.
3397
3398         As a side-effect, dropping the check in WorkerContextIndexedDatabase
3399         allows us to stop holding a pointer to the ScriptExecutionContext we're
3400         extending, which can only be a good thing.
3401
3402         The tests in storage/indexeddb should continue to pass.
3403
3404         * Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
3405         (WebCore::DOMWindowIndexedDatabase::indexedDB):
3406             Drop the SecurityOrigin::canAccessDatabase check.
3407         * Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
3408         (WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
3409         (WebCore::WorkerContextIndexedDatabase::from):
3410             Drop the ScriptExecutionContext parameter from the class's
3411             constructor and callsites.
3412         (WebCore::WorkerContextIndexedDatabase::indexedDB):
3413             Drop the SecurityOrigin::canAccessDatabase check.
3414         * Modules/indexeddb/WorkerContextIndexedDatabase.h:
3415         (WorkerContextIndexedDatabase):
3416             Drop the stored pointer to ScriptExecutionContext, as we no longer
3417             need it in ::indexedDB.
3418
3419 2013-02-01  Beth Dakin  <bdakin@apple.com>
3420
3421         Speculative Windows build fix. 
3422
3423         * platform/ScrollAnimator.h:
3424         (WebCore):
3425
3426 2013-02-01  Ryosuke Niwa  <rniwa@webkit.org>
3427
3428         Smart link can erroneously move caret after an URL when typing immediately before it
3429         https://bugs.webkit.org/show_bug.cgi?id=92812
3430
3431         Reviewed by Enrica Casucci.
3432
3433         The bug was caused by smart link being triggered even when a user finished typing a word
3434         immediately before an URL. We already had a logic to avoid smart-linking an URL when the caret
3435         was after the URL but we were missing a check for when the caret is before the URL.
3436
3437         Fixed the bug by adding this check.
3438
3439         Test: editing/inserting/smart-link-when-caret-is-moved-before-URL.html
3440
3441         * editing/Editor.cpp:
3442         (WebCore::Editor::markAndReplaceFor):
3443
3444 2013-02-01  Roger Fong  <roger_fong@apple.com>
3445
3446         Unreviewed. Windows build fix. FloatSize.cpp was not included in the project.
3447
3448         * WebCore.vcproj/WebCore.vcproj:
3449
3450 2013-02-01  Julien Chaffraix  <jchaffraix@webkit.org>
3451
3452         [CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks
3453         https://bugs.webkit.org/show_bug.cgi?id=108403
3454
3455         Reviewed by Ojan Vafai.
3456
3457         Test: fast/css-grid-layout/grid-preferred-logical-widths.html
3458
3459         The code before this change was only handling minmax() with 2 fixed widths.
3460         The new code was updated to remove this artificial limitation and we now
3461         support all combination of minmax().
3462
3463         * rendering/RenderGrid.cpp:
3464         (WebCore::RenderGrid::computePreferredLogicalWidths):
3465         Updated to use computePreferredTrackWidth..
3466
3467         (WebCore::RenderGrid::computePreferredTrackWidth):
3468         Added this helper function that implements the core of the preferred width
3469         computation.
3470
3471         * rendering/RenderGrid.h: Added computePreferredTrackWidth.
3472
3473 2013-02-01  Nate Chapin  <japhet@chromium.org>
3474
3475         Cached main resources report a zero identifer on 304s