Source/WebCore: WK2: Cannot set focus on an element when focus is outside of WKView
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-03-08  Chris Fleizach  <cfleizach@apple.com>
2
3         Reviewed by Sam Weinig.
4
5         WK2: Cannot set focus on an element when focus is outside of WKView
6         https://bugs.webkit.org/show_bug.cgi?id=55281
7     
8         In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
9         Instead, the focus/unfocus messages need to be sent to the UIProcess side.
10
11         * platform/mac/WidgetMac.mm:
12         (WebCore::Widget::setFocus):
13
14 2011-03-08  Sam Weinig  <sam@webkit.org>
15
16         Reviewed by Anders Carlsson.
17
18         Overflow: scroll areas should not paint white in scroll corner if the 
19         scrollbars are overlay.
20         <rdar://problem/9082871>
21
22         * rendering/RenderLayer.cpp:
23         (WebCore::RenderLayer::paintScrollCorner):
24         Don't paint the scroll corner white if we have overlay scrollbars.
25
26 2011-03-08  Chris Marrin  <cmarrin@apple.com>
27
28         Reviewed by Darin Adler.
29
30         The first time animations are committed they have a bad start time
31         https://bugs.webkit.org/show_bug.cgi?id=55947
32
33         Do a check for a returned lastCommitTime of <=0 and replace it
34         with the mediaTime.
35
36
37         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
38         (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
39
40 2011-03-08  James Kozianski  <koz@chromium.org>
41
42         Reviewed by David Levin.
43
44         Expose isValidProtocol() in KURL.h.
45         https://bugs.webkit.org/show_bug.cgi?id=54594
46
47         This is needed to validate protocols used in calls to
48         navigator.registerProtocolHandler().
49
50         * platform/KURL.cpp:
51         * platform/KURL.h:
52         * platform/KURLGoogle.cpp:
53         (WebCore::isValidProtocol):
54
55 2011-03-08  Adam Roben  <aroben@apple.com>
56
57         Set svn:mime-type to text/css for all Inspector CSS files
58
59         This will cause them to be served with the correct MIME type from svn.webkit.org's web
60         interface.
61
62         Rubber-stamped by Tim Hatcher.
63
64         * inspector/front-end/audits.css: Added property svn:mime-type.
65         * inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
66         * inspector/front-end/heapProfiler.css: Added property svn:mime-type.
67         * inspector/front-end/helpScreen.css: Added property svn:mime-type.
68         * inspector/front-end/inspector.css: Added property svn:mime-type.
69         * inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
70         * inspector/front-end/networkPanel.css: Added property svn:mime-type.
71         * inspector/front-end/popover.css: Added property svn:mime-type.
72         * inspector/front-end/textViewer.css: Added property svn:mime-type.
73
74 2011-03-08  Andrei Popescu  <andreip@google.com>
75
76         Reviewed by Steve Block.
77
78         IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
79         https://bugs.webkit.org/show_bug.cgi?id=55938
80
81         The IndexedDatabase specification changed and IDBIndex objects are no
82         longer created asynchronously. We therefore no longer need this method.
83
84         No new tests, just cleanup.
85
86         * storage/IDBCallbacks.h:
87         * storage/IDBRequest.cpp:
88         * storage/IDBRequest.h:
89
90 2011-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
91
92         Unreviewed, rolling out r80551.
93         http://trac.webkit.org/changeset/80551
94         https://bugs.webkit.org/show_bug.cgi?id=55933
95
96         It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
97
98         * WebCore.pro:
99         * platform/SharedBuffer.cpp:
100         * platform/SharedBuffer.h:
101         * platform/network/qt/QNetworkReplyHandler.cpp:
102         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
103         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
104         (WebCore::QNetworkReplyHandler::forwardData):
105         (WebCore::QNetworkReplyHandler::start):
106         * platform/network/qt/QNetworkReplyHandler.h:
107         * platform/network/qt/ResourceHandleQt.cpp:
108         (WebCore::ResourceHandle::supportsBufferedData):
109         (WebCore::ResourceHandle::bufferedData):
110         * platform/qt/QtByteBlock.cpp: Removed.
111         * platform/qt/QtByteBlock.h: Removed.
112         * platform/qt/SharedBufferQt.cpp:
113
114 2011-03-08  Andreas Kling  <kling@webkit.org>
115
116         Reviewed by Benjamin Poulain.
117
118         RenderObject: Pass complex type arguments as const-references.
119
120         * WebCore.exp.in:
121         * rendering/RenderObject.h:
122         * rendering/RenderObject.cpp:
123         (WebCore::RenderObject::drawBoxSideFromPath):
124         (WebCore::RenderObject::drawArcForBoxSide):
125         (WebCore::RenderObject::localToAbsolute):
126         (WebCore::RenderObject::absoluteToLocal):
127
128 2011-03-08  Andreas Kling  <kling@webkit.org>
129
130         Reviewed by Antonio Gomes.
131
132         Path: Make measurement functions const
133         https://bugs.webkit.org/show_bug.cgi?id=55914
134
135         * platform/graphics/Path.cpp:
136         (WebCore::Path::length):
137         (WebCore::Path::pointAtLength):
138         (WebCore::Path::normalAngleAtLength):
139         * platform/graphics/Path.h:
140         * platform/graphics/cairo/PathCairo.cpp:
141         (WebCore::Path::strokeBoundingRect):
142         * platform/graphics/cg/PathCG.cpp:
143         (WebCore::Path::strokeBoundingRect):
144         * platform/graphics/openvg/PathOpenVG.cpp:
145         (WebCore::Path::strokeBoundingRect):
146         (WebCore::Path::length):
147         (WebCore::Path::pointAtLength):
148         (WebCore::Path::normalAngleAtLength):
149         * platform/graphics/qt/PathQt.cpp:
150         (WebCore::Path::strokeBoundingRect):
151         (WebCore::Path::length):
152         (WebCore::Path::pointAtLength):
153         (WebCore::Path::normalAngleAtLength):
154         * platform/graphics/skia/PathSkia.cpp:
155         (WebCore::Path::strokeBoundingRect):
156         * platform/graphics/wince/PathWinCE.cpp:
157         (WebCore::Path::strokeBoundingRect):
158         * platform/graphics/wx/PathWx.cpp:
159         (WebCore::Path::strokeBoundingRect):
160
161 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
162
163         Reviewed by Martin Robinson.
164
165         [GTK] Do not set juntion sides on scrollbar stepper buttons
166         https://bugs.webkit.org/show_bug.cgi?id=55868
167
168         Fixes rendering of steppers for themes using rounded stepper
169         buttons on scrollbars like Adwaita.
170
171         * platform/gtk/ScrollbarThemeGtk3.cpp:
172         (WebCore::ScrollbarThemeGtk::paintButton):
173
174 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
175
176         Reviewed by Martin Robinson.
177
178         [GTK] Use doubles instead of integers for coordinates when rendering arrows
179         https://bugs.webkit.org/show_bug.cgi?id=55866
180
181         To prevent off-by-one rounding errors.
182
183         * platform/gtk/RenderThemeGtk3.cpp:
184         (WebCore::RenderThemeGtk::paintMenuList):
185         * platform/gtk/ScrollbarThemeGtk3.cpp:
186         (WebCore::ScrollbarThemeGtk::paintButton):
187
188 2011-03-08  Markus Goetz  <guruz@guruz.de>
189
190         Reviewed by Kenneth Rohde Christiansen.
191
192         [Qt] Use the QNetworkAccessManager zerocopy feature
193         https://bugs.webkit.org/show_bug.cgi?id=50082
194
195         The feature will be introduced in Qt 4.8.
196         This patch is backwards compatible with Qt 4.7.
197
198         * WebCore.pro:
199         * platform/SharedBuffer.cpp:
200         * platform/SharedBuffer.h:
201         * platform/network/qt/QNetworkReplyHandler.cpp:
202         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
203         (WebCore::QNetworkReplyHandler::bufferedData):
204         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
205         (WebCore::QNetworkReplyHandler::downloadProgress):
206         (WebCore::QNetworkReplyHandler::forwardData):
207         (WebCore::QNetworkReplyHandler::start):
208         * platform/network/qt/QNetworkReplyHandler.h:
209         * platform/network/qt/ResourceHandleQt.cpp:
210         (WebCore::ResourceHandle::supportsBufferedData):
211         (WebCore::ResourceHandle::bufferedData):
212         * platform/qt/SharedBufferQt.cpp:
213         (WebCore::SharedBuffer::wrapQtByteBlock):
214         (WebCore::SharedBuffer::hasPlatformData):
215         (WebCore::SharedBuffer::platformData):
216         (WebCore::SharedBuffer::platformDataSize):
217         (WebCore::SharedBuffer::maybeTransferPlatformData):
218         (WebCore::SharedBuffer::clearPlatformData):
219
220 2011-03-08  Alejandro G. Castro  <alex@igalia.com>
221
222         Reviewed by Martin Robinson.
223
224         [GTK] Fix compilation warnings after r80429
225         https://bugs.webkit.org/show_bug.cgi?id=55864
226
227         * platform/gtk/WidgetGtk.cpp:
228
229 2011-03-08  Philippe Normand  <pnormand@igalia.com>
230
231         Unreviewed, GTK build fix after r80536
232
233         * GNUmakefile.am:
234
235 2011-03-08  Zan Dobersek  <zandobersek@gmail.com>
236
237         Reviewed by Martin Robinson.
238
239         [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
240         https://bugs.webkit.org/show_bug.cgi?id=55878
241
242         Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
243         when saving GdkPixbuf to a buffer.
244
245         * platform/graphics/gtk/ImageBufferGtk.cpp:
246         (WebCore::ImageBuffer::toDataURL):
247
248 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
249
250         Unreviewed.
251
252         Final build fix for r80536.
253
254         * DerivedSources.make:
255
256 2011-03-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
257
258         Reviewed by Kent Tamura.
259
260         [EFL] Adjust functions of WebCore's efl port to WebKit coding style
261         https://bugs.webkit.org/show_bug.cgi?id=55924
262
263         Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.
264
265         * platform/efl/PlatformKeyboardEventEfl.cpp:
266         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
267         * platform/efl/PlatformMouseEventEfl.cpp:
268         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
269         * platform/efl/WidgetEfl.cpp:
270         (WebCore::Widget::frameRectsChanged):
271         (WebCore::Widget::setEvasObject):
272
273 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
274
275         Unreviewed.
276
277         More build fixes for r80536.
278
279         * CMakeLists.txt:
280         * platform/chromium/ClipboardChromium.cpp:
281         * platform/chromium/ClipboardChromium.h:
282
283 2011-03-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
284
285         Reviewed by Antonio Gomes.
286
287         [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
288         https://bugs.webkit.org/show_bug.cgi?id=55917
289
290         Adjust webkit style to ScrollbarEfl files.
291
292         * platform/efl/ScrollbarEfl.cpp:
293         (scrollbarEflEdjeMessage):
294         (ScrollbarEfl::setParent):
295         (ScrollbarEfl::updateThumbPositionAndProportion):
296         (ScrollbarEfl::frameRectsChanged):
297         (ScrollbarEfl::paint):
298         * platform/efl/ScrollbarEfl.h:
299
300 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
301
302         Unreviewed.
303
304         Build fix for Chromium after r80536.
305
306         * platform/chromium/DataTransferItemChromium.cpp:
307         * platform/chromium/DataTransferItemsChromium.cpp:
308
309 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
310
311         Unreviewed.
312
313         More build fixes for r80536.
314
315         * CMakeLists.txt:
316         * platform/chromium/ClipboardChromium.cpp:
317         * platform/chromium/ClipboardChromium.h:
318
319 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
320
321         Reviewed by David Levin.
322
323         Add support for DataTransferItems
324         https://bugs.webkit.org/show_bug.cgi?id=55115
325
326         This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
327         basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
328         all functionality on the DataTransferItems collection has been implemented.
329         This change does not actually hook up DataTransferItems to reflect the actual contents of a
330         drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
331         enabled via several followup patches.
332
333         Test: editing/pasteboard/data-transfer-items.html
334
335         * Android.mk:
336         * CMakeLists.txt:
337         * CodeGenerators.pri:
338         * DerivedSources.cpp:
339         * DerivedSources.make:
340         * GNUmakefile.am:
341         * WebCore.gypi:
342         * WebCore.pro:
343         * WebCore.vcproj/WebCore.vcproj:
344         * WebCore.xcodeproj/project.pbxproj:
345         * bindings/generic/RuntimeEnabledFeatures.cpp:
346         * bindings/generic/RuntimeEnabledFeatures.h:
347         (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
348         (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
349         * bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
350         * dom/Clipboard.h:
351         (WebCore::Clipboard::policy):
352         * dom/Clipboard.idl:
353         * dom/DataTransferItem.cpp: Added.
354         * dom/DataTransferItem.h: Added.
355         (WebCore::DataTransferItem::~DataTransferItem):
356         * dom/DataTransferItem.idl: Added.
357         * dom/DataTransferItems.h: Added.
358         (WebCore::DataTransferItems::~DataTransferItems):
359         * dom/DataTransferItems.idl: Added.
360         * dom/StringCallback.cpp: Added.
361         (WebCore::StringCallback::scheduleCallback):
362         * dom/StringCallback.h: Added.
363         (WebCore::StringCallback::~StringCallback):
364         * dom/StringCallback.idl: Added.
365         * platform/chromium/ClipboardChromium.cpp:
366         (WebCore::ClipboardChromium::items):
367         * platform/chromium/ClipboardChromium.h:
368         * platform/chromium/DataTransferItemChromium.cpp: Added.
369         (WebCore::DataTransferItemChromium::create):
370         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
371         (WebCore::DataTransferItemChromium::kind):
372         (WebCore::DataTransferItemChromium::type):
373         (WebCore::DataTransferItemChromium::getAsString):
374         * platform/chromium/DataTransferItemChromium.h: Added.
375         * platform/chromium/DataTransferItemsChromium.cpp: Added.
376         (WebCore::DataTransferItemsChromium::create):
377         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
378         (WebCore::DataTransferItemsChromium::length):
379         (WebCore::DataTransferItemsChromium::item):
380         (WebCore::DataTransferItemsChromium::deleteItem):
381         (WebCore::DataTransferItemsChromium::clear):
382         (WebCore::DataTransferItemsChromium::add):
383         * platform/chromium/DataTransferItemsChromium.h: Added.
384
385 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
386
387         Reviewed by Darin Adler.
388
389         selectionHasStyle and selectionStartHasStyle should use EditingStyle
390         https://bugs.webkit.org/show_bug.cgi?id=55902
391
392         Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
393         This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.
394
395         Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
396         to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
397         call sites of these two functions.
398
399         * WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
400         selectionStartHasStyle because it's not called anywhere outside of WebCore.
401         * WebCore.order: Ditto.
402         * editing/EditingStyle.cpp:
403         (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id
404         and a property value.
405         (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
406         * editing/EditingStyle.h:
407         (WebCore::EditingStyle::create): Added.
408         * editing/Editor.cpp:
409         (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of
410         a CSSStyleDeclaration.
411         (WebCore::Editor::selectionHasStyle): Ditto.
412         * editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
413         * editing/EditorCommand.cpp:
414         (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle.
415         (WebCore::stateStyle): Ditto.
416         * page/ContextMenuController.cpp:
417         (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
418
419 2011-03-07  Alexey Proskuryakov  <ap@apple.com>
420
421         Reviewed by Darin Adler.
422
423         REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
424         https://bugs.webkit.org/show_bug.cgi?id=55898
425
426         <rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
427         linkifying e-mail addresses in in -[DOMCharacterData setData:]
428
429         Changes render tree of fast/text/large-text-composed-char.html, but not image results.
430
431         * dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData):
432         Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
433
434         * dom/CharacterData.h: Moved a constant for maximum length from Text.h.
435
436         * dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
437         * dom/Text.h:
438         This function was unused in ToT. Moved code around to share with CharacterData.
439
440         * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
441         Chnaged to split large text nodes while parsing again.
442
443 2011-03-07  Alice Boxhall  <aboxhall@chromium.org>
444
445         Reviewed by Adam Barth.
446
447         Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
448         https://bugs.webkit.org/show_bug.cgi?id=54522
449
450         Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.
451
452         No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
453
454         * platform/image-encoders/JPEGImageEncoder.cpp:
455         (WebCore::jpegEmptyOutputBuffer):
456
457 2011-03-07  Sergey Glazunov  <serg.glazunov@gmail.com>
458
459         Reviewed by Eric Seidel.
460
461         Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
462         https://bugs.webkit.org/show_bug.cgi?id=55896
463
464         Test: svg/dom/vkern-element-crash.html
465
466         * svg/SVGHKernElement.cpp:
467         (WebCore::SVGHKernElement::insertedIntoDocument):
468         * svg/SVGVKernElement.cpp:
469         (WebCore::SVGVKernElement::insertedIntoDocument):
470
471 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
472
473         Unreviewed, rolling out r80514.
474         http://trac.webkit.org/changeset/80514
475         https://bugs.webkit.org/show_bug.cgi?id=55915
476
477         Caused assertion failures (Requested by ukai on #webkit).
478
479         * platform/graphics/skia/GraphicsContextSkia.cpp:
480         (WebCore::GraphicsContext::setPlatformShadow):
481         * platform/graphics/skia/ImageSkia.cpp:
482         (WebCore::paintSkBitmap):
483
484 2011-03-07  Cosmin Truta  <ctruta@chromium.org>
485
486         Reviewed by Adam Barth.
487
488         SVG <image> referenced by <use> is displayed incorrectly
489         https://bugs.webkit.org/show_bug.cgi?id=55750
490
491         The result of sourceURI must use the URL of the enclosing document as base.
492         Otherwise, the base may sometimes be empty, and, as a consequence,
493         the intermediate KURL object may be invalid.
494
495         Test: svg/custom/use-image-in-g.svg
496
497         * svg/SVGImageLoader.cpp:
498         (WebCore::SVGImageLoader::sourceURI):
499
500 2011-03-07  Helder Correia  <helder@sencha.com>
501
502         Reviewed by Simon Fraser.
503
504         Shadow is not shown when using strokeRect with a gradient strokeStyle
505         https://bugs.webkit.org/show_bug.cgi?id=52509
506
507         This happens in CG and is related to bug 51869, this time to be fixed
508         in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
509         We need to draw the gradient clipped to the stroke on a CGLayer first,
510         and then draw the layer on the GraphicsContext.
511
512         Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html
513                svg/css/rect-gradient-stroke-shadow.svg
514
515         * platform/graphics/cg/GraphicsContextCG.cpp:
516         (WebCore::GraphicsContext::strokeRect):
517
518 2011-03-07  Justin Novosad  <junov@chromium.org>
519
520         Reviewed by Kenneth Russell.
521
522         Fix for blurs behind bitmap images in Chromium, and boosting
523         shadow blur quality 
524         Bug URLs:
525                 https://bugs.webkit.org/show_bug.cgi?id=55410
526                 https://bugs.webkit.org/show_bug.cgi?id=55506
527
528         No new tests. Covered by existing layout tests. 
529
530         * platform/graphics/skia/GraphicsContextSkia.cpp:
531         (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
532         * platform/graphics/skia/ImageSkia.cpp:
533         (WebCore::paintSkBitmap): Propagate the draw looper from context to painter
534
535 2011-03-07  Andreas Kling  <kling@webkit.org>
536
537         Unreviewed Mac build fix after r80508.
538
539         * WebCore.exp.in:
540
541 2011-03-07  Enrica Casucci  <enrica@apple.com>
542
543         Unreviewed build fix.
544
545         Rolling back  http://trac.webkit.org/changeset/80497 due to the
546         32-bit build failures.
547
548         * WebCore.xcodeproj/project.pbxproj:
549         * platform/mac/HTMLConverter.h: Removed.
550         * platform/mac/HTMLConverter.mm: Removed.
551         * platform/mac/PasteboardMac.mm:
552         (WebCore::Pasteboard::writeSelection):
553
554 2011-03-07  Andreas Kling  <kling@webkit.org>
555
556         Reviewed by Benjamin Poulain.
557
558         FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.
559
560         * page/FrameView.cpp:
561         (WebCore::FrameView::setBaseBackgroundColor):
562         * page/FrameView.h:
563
564 2011-03-07  Adam Barth  <abarth@webkit.org>
565
566         Reviewed by Dimitri Glazkov.
567
568         REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
569         https://bugs.webkit.org/show_bug.cgi?id=55894
570
571         The m_frame can disappear out from under us, and there's no point in
572         checking whether the load is complete in a non-existant frame.
573
574         Test: fast/parser/document-write-into-initial-document.html
575
576         * dom/Document.cpp:
577         (WebCore::Document::explicitClose):
578
579 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
580
581         Unreviewed, rolling out r80500.
582         http://trac.webkit.org/changeset/80500
583         https://bugs.webkit.org/show_bug.cgi?id=55908
584
585         Caused mysterious GYP error (Requested by abarth on #webkit).
586
587         * WebCore.gyp/WebCore.gyp:
588         * WebCore.gypi:
589
590 2011-03-07  Adam Barth  <abarth@webkit.org>
591
592         Fix Chromium Mac build.  This header should only be included when the
593         feature is enabled.
594
595         * platform/cf/RunLoopTimerCF.cpp:
596
597 2011-03-07  Adam Barth  <abarth@webkit.org>
598
599         Reviewed by Dimitri Glazkov.
600
601         Add WML files to WebCore.gypi
602         https://bugs.webkit.org/show_bug.cgi?id=55905
603
604         * WebCore.gyp/WebCore.gyp:
605         * WebCore.gypi:
606
607 2011-03-07  Adrienne Walker  <enne@google.com>
608
609         Reviewed by James Robinson.
610
611         [chromium] Add missing include to #define Skia parameter
612         https://bugs.webkit.org/show_bug.cgi?id=55885
613
614         * platform/graphics/chromium/ShaderChromium.h:
615
616 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
617
618         Reviewed by Beth Dakin.
619
620         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
621         https://bugs.webkit.org/show_bug.cgi?id=55706
622
623         * WebCore.exp.in:
624         * accessibility/AXObjectCache.cpp:
625         (WebCore::AXObjectCache::rootObjectForFrame):
626         * accessibility/AXObjectCache.h:
627         * accessibility/AccessibilityScrollView.cpp:
628         (WebCore::AccessibilityScrollView::isAttachment):
629         (WebCore::AccessibilityScrollView::widgetForAttachmentView):
630         * accessibility/AccessibilityScrollView.h:
631         (WebCore::AccessibilityScrollView::firstChild):
632         * accessibility/mac/AccessibilityObjectWrapper.mm:
633         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
634
635 2011-03-07  Enrica Casucci  <enrica@apple.com>
636
637         Reviewed by Darin Adler.
638         
639         REGRESSION: Copied content loses formatting on paste to external apps.
640         https://bugs.webkit.org/show_bug.cgi?id=47615
641         <rdar://problem/9001214>
642
643         This is a resubmission of a patch that was landed a while ago then rolled
644         back because of a build failure on SnowLeopard and Leopard.
645         
646         This patch adds a way for WebKit2 to create NSAttributedStrings from
647         a DOM range without using the AppKit api initWithDOMRange that internally
648         needs to access the WebView. The NSAttributedString is needed to create
649         RTF formats in the pasteboard.
650         This is to be considered a first step, since in the future we want to have
651         an implementation based on the TextIterator.
652
653         * WebCore.xcodeproj/project.pbxproj: Added new file.
654         * platform/mac/HTMLConverter.h: Added.
655         * platform/mac/HTMLConverter.mm: Added.
656         * platform/mac/PasteboardMac.mm:
657         (WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
658         class for WebKit2 to create the NSAttributedString from the DOM range.
659
660 2011-03-07  Adam Barth  <abarth@webkit.org>
661
662         Reviewed by Dimitri Glazkov.
663
664         Add some missing platform files to WebCore.gypi
665         https://bugs.webkit.org/show_bug.cgi?id=55897
666
667         There are a bunch more, but this is a start.
668
669         * WebCore.gyp/WebCore.gyp:
670         * WebCore.gypi:
671
672 2011-03-07  Steve Block  <steveblock@google.com>
673
674         Reviewed by Jeremy Orlow.
675
676         Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
677         https://bugs.webkit.org/show_bug.cgi?id=55879
678
679         No new tests, refactoring only.
680
681         * Android.v8bindings.mk:
682         * WebCore.gypi:
683         * bridge/jni/v8/JavaClassV8.cpp:
684         * bridge/jni/v8/JavaClassV8.h:
685         * bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp.
686         (JavaField::JavaField):
687         * bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
688         (JSC::Bindings::JavaField::name):
689         (JSC::Bindings::JavaField::type):
690         (JSC::Bindings::JavaField::getJNIType):
691         * bridge/jni/v8/JavaInstanceV8.cpp:
692         * bridge/jni/v8/JavaNPObjectV8.cpp:
693
694 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
695
696         Reviewed by Tony Chang.
697
698         Add plumbing for paste support to ChromiumDataObject::types()
699         https://bugs.webkit.org/show_bug.cgi?id=55792
700
701         This is a preliminary patch to support event.dataTransfer.items. This
702         adds plumbing to support retrieving the types in a paste event. It also
703         moves the check for files in a drag/paste up to ClipboardChromium, since
704         internal code needs to be able to differentiate between actual files in
705         a drag and someone that simply decided to use "Files" as a custom type
706         string.
707
708         Test: editing/pasteboard/onpaste-text-html-types.html
709
710         * platform/chromium/ChromiumDataObject.cpp:
711         (WebCore::ChromiumDataObject::types):
712         (WebCore::ChromiumDataObject::containsFilenames):
713         * platform/chromium/ChromiumDataObject.h:
714         * platform/chromium/ClipboardChromium.cpp:
715         (WebCore::ClipboardChromium::types):
716         * platform/chromium/ClipboardMimeTypes.cpp:
717         * platform/chromium/ClipboardMimeTypes.h:
718
719 2011-03-07  Takayoshi Kochi  <kochi@chromium.org>
720
721         Reviewed by Tony Chang.
722
723         [chromium] Use preferred locale information when choosing fallback
724         font using fontconfig on Linux platform.
725         http://bugs.webkit.org/show_bug.cgi?id=55453
726
727         No new tests, as it depends on ICU and locale setting, so it will be
728         covered by Chromium side.
729
730         * platform/chromium/PlatformBridge.h:
731         * platform/graphics/chromium/FontCacheLinux.cpp:
732
733 2011-03-07  Adam Barth  <abarth@webkit.org>
734
735         Reviewed by Eric Seidel.
736
737         Add gobject, cpp, and objc bindings to WebCore.gypi
738         https://bugs.webkit.org/show_bug.cgi?id=55892
739
740         These are also excluded from the Chromium build but needed for various
741         other ports.
742
743         * WebCore.gyp/WebCore.gyp:
744         * WebCore.gypi:
745
746 2011-03-07  Sergey Glazunov  <serg.glazunov@gmail.com>
747
748         Reviewed by Dimitri Glazkov.
749
750         Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
751         https://bugs.webkit.org/show_bug.cgi?id=55803
752
753         Test: fast/dom/dom-method-document-change.html
754
755         * dom/ContainerNode.cpp:
756         (WebCore::ContainerNode::insertBefore):
757         (WebCore::ContainerNode::replaceChild):
758         (WebCore::ContainerNode::appendChild):
759         * dom/Node.cpp:
760         (WebCore::Node::checkReplaceChild):
761         (WebCore::Node::checkAddChild):
762         * dom/Node.h:
763
764 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
765
766         Unreviewed, rolling out r80484.
767         http://trac.webkit.org/changeset/80484
768         https://bugs.webkit.org/show_bug.cgi?id=55891
769
770         requires Chromium DEPS roll (Requested by dcheng on #webkit).
771
772         * platform/chromium/ChromiumDataObject.cpp:
773         (WebCore::ChromiumDataObject::types):
774         * platform/chromium/ChromiumDataObject.h:
775         (WebCore::ChromiumDataObject::containsFilenames):
776         * platform/chromium/ClipboardChromium.cpp:
777         (WebCore::ClipboardChromium::types):
778         * platform/chromium/ClipboardMimeTypes.cpp:
779         * platform/chromium/ClipboardMimeTypes.h:
780
781 2011-03-07  Adam Barth  <abarth@webkit.org>
782
783         Reviewed by Dimitri Glazkov.
784
785         Add missing bindings/js files to WebCore.gypi
786         https://bugs.webkit.org/show_bug.cgi?id=55888
787
788         These files are excluded from the Chromium build but needed for the Mac
789         build.
790
791         * WebCore.gypi:
792
793 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
794
795         Reviewed by Tony Chang.
796
797         Add plumbing for paste support to ChromiumDataObject::types()
798         https://bugs.webkit.org/show_bug.cgi?id=55792
799
800         This is a preliminary patch to support event.dataTransfer.items. This
801         adds plumbing to support retrieving the types in a paste event. It also
802         moves the check for files in a drag/paste up to ClipboardChromium, since
803         internal code needs to be able to differentiate between actual files in
804         a drag and someone that simply decided to use "Files" as a custom type
805         string.
806
807         Test: editing/pasteboard/onpaste-text-html-types.html
808
809         * platform/chromium/ChromiumDataObject.cpp:
810         (WebCore::ChromiumDataObject::types):
811         (WebCore::ChromiumDataObject::containsFilenames):
812         * platform/chromium/ChromiumDataObject.h:
813         * platform/chromium/ClipboardChromium.cpp:
814         (WebCore::ClipboardChromium::types):
815         * platform/chromium/ClipboardMimeTypes.cpp:
816         * platform/chromium/ClipboardMimeTypes.h:
817
818 2011-03-07  Joseph Pecoraro  <joepeck@webkit.org>
819
820         Reviewed by Kenneth Rohde Christiansen.
821
822         Viewport Warning/Error Messages Are Now Inaccurate
823         https://bugs.webkit.org/show_bug.cgi?id=53707
824
825         Correct and improve the error messages for viewport parsing.
826
827         Tests: fast/viewport/viewport-warnings-1.html
828                fast/viewport/viewport-warnings-2.html
829                fast/viewport/viewport-warnings-3.html
830                fast/viewport/viewport-warnings-4.html
831                fast/viewport/viewport-warnings-5.html
832                fast/viewport/viewport-warnings-6.html
833
834         * dom/ViewportArguments.cpp:
835         (WebCore::numericPrefix):
836         (WebCore::findSizeValue): remove incorrect device-width / height tips.
837         (WebCore::setViewportFeature): report a warning for an unrecognized key.
838         (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
839         (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
840         * dom/ViewportArguments.h: removed no longer used warnings.
841
842 2011-03-07  James Robinson  <jamesr@chromium.org>
843
844         Reviewed by Kenneth Russell.
845
846         [chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
847         https://bugs.webkit.org/show_bug.cgi?id=54047
848
849         This splits up LayerRendererChromium::drawLayers() into two phases,
850         one that updates layers and one that actually draws them.  Most of the
851         patch is moving the bodies of drawLayers() and updateLayersRecursive()
852         into smaller helper functions.
853
854         The main entry point is renamed updateAndDrawLayers(), but otherwise
855         has the same signature as drawLayers() did.  Internally it does the
856         following:
857
858         1.) Updates the root layer's contents
859         2.) Updates the root layer's scrollbars
860         3.) Updates the RenderSurface tree and the contents of all child
861         layers
862         4.) Draws the root layer and root layer scrollbars
863         5.) Draws all child layers using the previously updated
864         CCLayerImpl/RenderSurface data.
865
866         A few things still need to be done after this patch to complete the separation
867         of the update and draw step, but they can happen in later patches:
868         *) The root layer and root layer scrollbars contents should be
869         uploaded to textures at draw time, not update time.
870         *) The RenderSurface tree should be updated at draw time, not update
871         time.
872
873         Covered by the compositing/ tests.
874
875         * platform/graphics/chromium/LayerRendererChromium.cpp:
876         (WebCore::LayerRendererChromium::LayerRendererChromium):
877         (WebCore::LayerRendererChromium::updateRootLayerContents):
878         (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
879         (WebCore::LayerRendererChromium::drawRootLayer):
880         (WebCore::LayerRendererChromium::updateAndDrawLayers):
881         (WebCore::LayerRendererChromium::updateLayers):
882         (WebCore::LayerRendererChromium::drawLayers):
883         (WebCore::LayerRendererChromium::getFramebufferPixels):
884         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
885         (WebCore::LayerRendererChromium::updateContentsRecursive):
886         (WebCore::LayerRendererChromium::drawLayer):
887         * platform/graphics/chromium/LayerRendererChromium.h:
888         (WebCore::LayerRendererChromium::visibleRectSize):
889         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
890         (WebCore::RenderSurfaceChromium::drawSurface):
891         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
892         * platform/graphics/chromium/cc/CCLayerImpl.h:
893
894 2011-03-07  Adam Barth  <abarth@webkit.org>
895
896         Reviewed by Eric Seidel.
897
898         Sort WebCore.gypi
899         https://bugs.webkit.org/show_bug.cgi?id=55887
900
901         These files should be in order.  This is preparation for adding in the
902         missing files.
903
904         * WebCore.gypi:
905
906 2011-03-07  Csaba Osztrogon√°c  <ossy@webkit.org>
907
908         Unreviewed buildfix after r80478.
909
910         * dom/Document.cpp: Add suggested parentheses to make GCC happy.
911         (WebCore::Document::didReceiveTask):
912
913 2011-03-07  Yong Li  <yoli@rim.com>
914
915         Reviewed by Darin Adler.
916
917         Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
918         Schedule them with timer when page loading is resumed. The tasks will be performed
919         in the original order. This fixes the problem that database callbacks could be missed
920         when page loading was deferred.
921         https://bugs.webkit.org/show_bug.cgi?id=49401
922
923         Manual test added: manual-tests/database-callback-deferred.html.
924
925         * dom/Document.cpp:
926         (WebCore::Document::Document):
927         (WebCore::Document::~Document):
928         (WebCore::Document::didReceiveTask):
929         (WebCore::Document::postTask):
930         (WebCore::Document::pendingTasksTimerFired):
931         (WebCore::Document::willDeferLoading):
932         (WebCore::Document::didResumeLoading):
933         * dom/Document.h:
934         * manual-tests/database-callback-deferred.html: Added.
935         * page/PageGroupLoadDeferrer.cpp:
936         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
937         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
938
939 2011-03-07  Antti Koivisto  <antti@apple.com>
940
941         Reviewed by Sam Weinig.
942
943         Use HashMaps for caching primitive values
944         https://bugs.webkit.org/show_bug.cgi?id=55873
945         
946         Most documents use only small subset of cacheable primitive values. By replacing
947         fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
948         expanding the range of cacheable values.
949
950         * css/CSSPrimitiveValueCache.cpp:
951         (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
952         (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
953         (WebCore::CSSPrimitiveValueCache::createColorValue):
954         (WebCore::CSSPrimitiveValueCache::createValue):
955         * css/CSSPrimitiveValueCache.h:
956
957 2011-03-07  Steve Block  <steveblock@google.com>
958
959         Reviewed by Jeremy Orlow.
960
961         Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
962         https://bugs.webkit.org/show_bug.cgi?id=55881
963
964         No new tests, refactoring only.
965
966         * Android.jscbindings.mk:
967         * GNUmakefile.am:
968         * WebCore.xcodeproj/project.pbxproj:
969         * bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
970         * bridge/jni/jsc/JNIBridgeJSC.h: Removed.
971         * bridge/jni/jsc/JNIUtilityPrivate.cpp:
972         * bridge/jni/jsc/JavaClassJSC.cpp:
973         * bridge/jni/jsc/JavaClassJSC.h:
974         * bridge/jni/jsc/JavaInstanceJSC.cpp:
975
976 2011-03-07  Sam Weinig  <sam@webkit.org>
977
978         Reviewed by Anders Carlsson.
979
980         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
981         https://bugs.webkit.org/show_bug.cgi?id=55827
982
983         * loader/EmptyClients.h:
984         (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):
985         * loader/FrameLoaderClient.h:
986         * loader/MainResourceLoader.cpp:
987         (WebCore::MainResourceLoader::didReceiveResponse):
988         * loader/PolicyChecker.cpp:
989         (WebCore::PolicyChecker::checkContentPolicy):
990         * loader/PolicyChecker.h:
991         Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
992         and pass the entire response, instead of just the MIMEType.
993
994 2011-03-07  Eric Carlson  <eric.carlson@apple.com>
995
996         Reviewed by Darin Adler.
997
998         Add API to enumerate/delete files downloaded for <audio> and <video>
999         https://bugs.webkit.org/show_bug.cgi?id=55267
1000         <rdar://problem/9049280>
1001
1002         No new tests, this is just more plumbing.
1003
1004         * html/HTMLMediaElement.cpp:
1005         (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method.
1006         (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
1007         (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
1008         * html/HTMLMediaElement.h:
1009
1010         * platform/graphics/MediaPlayer.cpp:
1011         (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions.
1012         (WebCore::addMediaEngine): Ditto.
1013         (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines.
1014         (WebCore::MediaPlayer::clearMediaCache): Ditto.
1015         (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
1016         * platform/graphics/MediaPlayer.h:
1017
1018         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1019         (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
1020
1021         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1022         (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
1023
1024         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1025         (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
1026
1027         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
1028         (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
1029
1030         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1031         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.
1032
1033         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1034         (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.
1035
1036 2011-03-07  Steve Block  <steveblock@google.com>
1037
1038         Reviewed by Jeremy Orlow.
1039
1040         Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
1041         https://bugs.webkit.org/show_bug.cgi?id=55774
1042
1043         No new tests, refactoring only.
1044
1045         * Android.jscbindings.mk:
1046         * Android.v8bindings.mk:
1047         * GNUmakefile.am:
1048         * WebCore.gypi:
1049         * WebCore.xcodeproj/project.pbxproj:
1050         * bridge/jni/JavaMethod.cpp:
1051         (JavaMethod::JavaMethod):
1052         (JavaMethod::~JavaMethod):
1053         (appendClassName):
1054         (JavaMethod::signature):
1055         (JavaMethod::JNIReturnType):
1056         (JavaMethod::methodID):
1057         * bridge/jni/JavaMethod.h:
1058         (JSC::Bindings::JavaMethod::name):
1059         (JSC::Bindings::JavaMethod::returnType):
1060         (JSC::Bindings::JavaMethod::parameterAt):
1061         (JSC::Bindings::JavaMethod::numParameters):
1062         (JSC::Bindings::JavaMethod::isStatic):
1063         * bridge/jni/JavaString.h:
1064         (JSC::Bindings::JavaString::JavaString):
1065         (JSC::Bindings::JavaString::utf8):
1066         (JSC::Bindings::JavaString::length):
1067         (JSC::Bindings::JavaString::impl):
1068         * bridge/jni/jni_jsobject.mm:
1069         * bridge/jni/jsc/JNIBridgeJSC.h:
1070         * bridge/jni/v8/JNIBridgeV8.h:
1071         * bridge/jni/v8/JavaClassV8.cpp:
1072         * bridge/jni/v8/JavaClassV8.h:
1073         * bridge/jni/v8/JavaInstanceV8.cpp:
1074
1075 2011-03-07  Jeremy Orlow  <jorlow@chromium.org>
1076
1077         Reviewed by Steve Block.
1078
1079         Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
1080         https://bugs.webkit.org/show_bug.cgi?id=55812
1081
1082         This brings us in line with what's in the spec:
1083         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html
1084
1085         * storage/IDBCursor.cpp:
1086         (WebCore::IDBCursor::create):
1087         (WebCore::IDBCursor::IDBCursor):
1088         (WebCore::IDBCursor::source):
1089         * storage/IDBCursor.h:
1090         * storage/IDBCursor.idl:
1091         * storage/IDBCursorWithValue.cpp:
1092         (WebCore::IDBCursorWithValue::create):
1093         (WebCore::IDBCursorWithValue::IDBCursorWithValue):
1094         * storage/IDBCursorWithValue.h:
1095         * storage/IDBIndex.cpp:
1096         (WebCore::IDBIndex::IDBIndex):
1097         * storage/IDBIndex.h:
1098         (WebCore::IDBIndex::create):
1099         (WebCore::IDBIndex::objectStore):
1100         * storage/IDBIndex.idl:
1101         * storage/IDBObjectStore.cpp:
1102         (WebCore::IDBObjectStore::createIndex):
1103         (WebCore::IDBObjectStore::index):
1104         * storage/IDBRequest.cpp:
1105         (WebCore::IDBRequest::onSuccess):
1106
1107 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1108
1109         Reviewed by Beth Dakin.
1110
1111         AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
1112         https://bugs.webkit.org/show_bug.cgi?id=55735
1113
1114         The ARIA grid implementation needed to verify the row/column range of a cell instead of 
1115         assuming a 1-1 mapping between children and row/column.
1116
1117         Test: platform/mac/accessibility/aria-table-with-colspan-cells.html
1118
1119         * accessibility/AccessibilityARIAGrid.cpp:
1120         (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
1121
1122 2011-03-07  Andrei Popescu  <andreip@google.com>
1123
1124         Reviewed by Steve Block.
1125
1126         IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
1127         IDBObjectStore objects used to be created asynchronously, so we needed
1128         this method to be invoked, with the new object store as the parameter,
1129         whenever the creation succeeded. The spec has changed so that IDBObjectStore
1130         objects are created synchronously, so this method is no longer needed.
1131         https://bugs.webkit.org/show_bug.cgi?id=55777
1132
1133         No new tests, just refactoring.
1134
1135         * storage/IDBCallbacks.h:
1136         * storage/IDBRequest.cpp:
1137         * storage/IDBRequest.h:
1138
1139 2011-03-04  Steve Block  <steveblock@google.com>
1140
1141         Reviewed by Jeremy Orlow.
1142
1143         JavaParameter should be removed
1144         https://bugs.webkit.org/show_bug.cgi?id=55772
1145
1146         No new tests, refactoring only.
1147
1148         * bridge/jni/JNIBridge.cpp:
1149         (JavaMethod::JavaMethod):
1150         (JavaMethod::~JavaMethod):
1151         (JavaMethod::signature):
1152         * bridge/jni/JNIBridge.h:
1153         (JSC::Bindings::JavaMethod::parameterAt):
1154         (JSC::Bindings::JavaMethod::numParameters):
1155         * bridge/jni/JNIUtility.h:
1156         * bridge/jni/jsc/JavaInstanceJSC.cpp:
1157         (JavaInstance::invokeMethod):
1158         * bridge/jni/v8/JNIUtilityPrivate.cpp:
1159         (JSC::Bindings::convertNPVariantToJValue):
1160         * bridge/jni/v8/JNIUtilityPrivate.h:
1161         * bridge/jni/v8/JavaInstanceV8.cpp:
1162         (JavaInstance::invokeMethod):
1163
1164 2011-03-07  Antti Koivisto  <antti@apple.com>
1165
1166         Reviewed by Oliver Hunt.
1167
1168         REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots 
1169         https://bugs.webkit.org/show_bug.cgi?id=55166
1170         <rdar://problem/9050430>
1171         
1172         Make CSS primitive value cache per-document.
1173         
1174         Test: http/tests/security/cross-origin-css-primitive.html
1175
1176         * Android.mk:
1177         * CMakeLists.txt:
1178         * GNUmakefile.am:
1179         * WebCore.gypi:
1180         * WebCore.pro:
1181         * WebCore.vcproj/WebCore.vcproj:
1182         * WebCore.xcodeproj/project.pbxproj:
1183         * css/CSSComputedStyleDeclaration.cpp:
1184         (WebCore::valueForNinePieceImage):
1185         (WebCore::zoomAdjustedPixelValue):
1186         (WebCore::zoomAdjustedNumberValue):
1187         (WebCore::zoomAdjustedPixelValueForLength):
1188         (WebCore::valueForReflection):
1189         (WebCore::getPositionOffsetValue):
1190         (WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
1191         (WebCore::getBorderRadiusCornerValue):
1192         (WebCore::computedTransform):
1193         (WebCore::getDelayValue):
1194         (WebCore::getDurationValue):
1195         (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
1196         (WebCore::CSSComputedStyleDeclaration::valueForShadow):
1197         (WebCore::valueForFamily):
1198         (WebCore::renderTextDecorationFlagsToCSSValue):
1199         (WebCore::fillRepeatToCSSValue):
1200         (WebCore::fillSizeToCSSValue):
1201         (WebCore::contentToCSSValue):
1202         (WebCore::counterToCSSValue):
1203         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1204         * css/CSSParser.cpp:
1205         (WebCore::CSSParser::parseSheet):
1206         (WebCore::CSSParser::parseRule):
1207         (WebCore::CSSParser::parseKeyframeRule):
1208         (WebCore::CSSParser::parseValue):
1209         (WebCore::CSSParser::parseColor):
1210         (WebCore::CSSParser::parseSelector):
1211         (WebCore::CSSParser::parseDeclaration):
1212         (WebCore::CSSParser::setStyleSheet):
1213         (WebCore::CSSParser::parseWCSSInputProperty):
1214         (WebCore::parseBackgroundClip):
1215         (WebCore::CSSParser::parseFillShorthand):
1216         (WebCore::CSSParser::parsePage):
1217         (WebCore::CSSParser::parseSizeParameter):
1218         (WebCore::CSSParser::parseContent):
1219         (WebCore::CSSParser::parseAttr):
1220         (WebCore::CSSParser::parseBackgroundColor):
1221         (WebCore::CSSParser::parseFillPositionXY):
1222         (WebCore::CSSParser::parseFillPosition):
1223         (WebCore::CSSParser::parseFillRepeat):
1224         (WebCore::CSSParser::parseFillSize):
1225         (WebCore::CSSParser::parseFillProperty):
1226         (WebCore::CSSParser::parseAnimationDelay):
1227         (WebCore::CSSParser::parseAnimationDirection):
1228         (WebCore::CSSParser::parseAnimationDuration):
1229         (WebCore::CSSParser::parseAnimationFillMode):
1230         (WebCore::CSSParser::parseAnimationIterationCount):
1231         (WebCore::CSSParser::parseAnimationName):
1232         (WebCore::CSSParser::parseAnimationPlayState):
1233         (WebCore::CSSParser::parseAnimationProperty):
1234         (WebCore::CSSParser::parseTransformOriginShorthand):
1235         (WebCore::CSSParser::parseAnimationTimingFunction):
1236         (WebCore::CSSParser::parseDashboardRegions):
1237         (WebCore::CSSParser::parseCounterContent):
1238         (WebCore::CSSParser::parseShape):
1239         (WebCore::CSSParser::parseFont):
1240         (WebCore::CSSParser::parseFontFamily):
1241         (WebCore::CSSParser::parseFontStyle):
1242         (WebCore::CSSParser::parseFontVariant):
1243         (WebCore::CSSParser::parseFontWeight):
1244         (WebCore::ShadowParseContext::ShadowParseContext):
1245         (WebCore::ShadowParseContext::commitLength):
1246         (WebCore::ShadowParseContext::commitStyle):
1247         (WebCore::CSSParser::parseShadow):
1248         (WebCore::CSSParser::parseReflect):
1249         (WebCore::BorderImageParseContext::BorderImageParseContext):
1250         (WebCore::BorderImageParseContext::commitNumber):
1251         (WebCore::BorderImageParseContext::commitBorderImage):
1252         (WebCore::CSSParser::parseBorderImage):
1253         (WebCore::CSSParser::parseBorderRadius):
1254         (WebCore::CSSParser::parseCounter):
1255         (WebCore::parseDeprecatedGradientPoint):
1256         (WebCore::parseDeprecatedGradientColorStop):
1257         (WebCore::CSSParser::parseDeprecatedGradient):
1258         (WebCore::valueFromSideKeyword):
1259         (WebCore::parseGradientColorOrKeyword):
1260         (WebCore::CSSParser::parseLinearGradient):
1261         (WebCore::CSSParser::parseRadialGradient):
1262         (WebCore::CSSParser::parseGradientColorStops):
1263         (WebCore::CSSParser::parseTransform):
1264         (WebCore::CSSParser::parseTransformOrigin):
1265         (WebCore::CSSParser::parseTextEmphasisStyle):
1266         * css/CSSParser.h:
1267         (WebCore::CSSParser::primitiveValueCache):
1268         * css/CSSPrimitiveValue.cpp:
1269         * css/CSSPrimitiveValue.h:
1270         (WebCore::CSSPrimitiveValue::createIdentifier):
1271         (WebCore::CSSPrimitiveValue::createColor):
1272         (WebCore::CSSPrimitiveValue::create):
1273         * css/CSSPrimitiveValueCache.cpp: Added.
1274         (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
1275         (WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
1276         (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
1277         (WebCore::CSSPrimitiveValueCache::createColorValue):
1278         (WebCore::CSSPrimitiveValueCache::createValue):
1279         * css/CSSPrimitiveValueCache.h: Added.
1280         (WebCore::CSSPrimitiveValueCache::create):
1281         (WebCore::CSSPrimitiveValueCache::createValue):
1282         * dom/Document.cpp:
1283         (WebCore::Document::cssPrimitiveValueCache):
1284         * dom/Document.h:
1285
1286 2011-03-06  Adam Barth  <abarth@webkit.org>
1287
1288         Reviewed by Eric Seidel.
1289
1290         Filter sources in WebCore GYP build for Mac
1291         https://bugs.webkit.org/show_bug.cgi?id=55857
1292
1293         This patch removes a large number of files that do not build as part of
1294         the Mac build.  I'm not fully sold on this method of
1295         including/excluding files, but it's the "gyp way" so we should probably
1296         try it first.
1297
1298         This patch also sets xcode_list_excluded_files to 0, which removes the
1299         excluded files from the Xcode project file, which is necessary in order
1300         to prevent the header map feature from including the wrong header file.
1301
1302         * gyp/WebCore.gyp:
1303
1304 2011-03-07  Ryuan Choi  <ryuan.choi@samsung.com>
1305
1306         Unreviewed EFL build fix.
1307
1308         [EFL] Build break on Debug build.
1309         https://bugs.webkit.org/show_bug.cgi?id=55858
1310
1311         * platform/efl/RenderThemeEfl.cpp:
1312         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
1313
1314 2011-03-06  Adam Barth  <abarth@webkit.org>
1315
1316         Reviewed by Eric Seidel.
1317
1318         Add webcore_derived_source_files to WebCore.gypi
1319         https://bugs.webkit.org/show_bug.cgi?id=55856
1320
1321         This is the list of files generated by the Mac port.  It's possible
1322         other ports generate a different list of files.
1323
1324         * WebCore.gypi:
1325         * gyp/WebCore.gyp:
1326
1327 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
1328
1329         Reviewed by Kent Tamura.
1330
1331         Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
1332         https://bugs.webkit.org/show_bug.cgi?id=55839
1333         http://crbug.com/73866
1334         http://crbug.com/62527
1335
1336         We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.
1337
1338         Test: fast/forms/input-appearance-spinbutton-visibility.html
1339
1340         * rendering/RenderTextControlSingleLine.cpp:
1341         (WebCore::RenderTextControlSingleLine::styleDidChange):
1342
1343 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
1344
1345         Reviewed by Kent Tamura.
1346
1347         [Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
1348         https://bugs.webkit.org/show_bug.cgi?id=54795
1349
1350         Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.
1351
1352         Test: manual-tests/popup-width-restriction-within-screen.html
1353
1354         * manual-tests/popup-width-restriction-within-screen.html: Added.
1355         * platform/chromium/PopupMenuChromium.cpp:
1356         (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
1357
1358 2011-03-06  Yuta Kitamura  <yutak@chromium.org>
1359
1360         Reviewed by Kent Tamura.
1361
1362         Add SHA-1 for new WebSocket protocol
1363         https://bugs.webkit.org/show_bug.cgi?id=55039
1364
1365         * ForwardingHeaders/wtf/SHA1.h: Added.
1366
1367 2011-03-06  Eric Carlson  <eric.carlson@apple.com>
1368
1369         Reviewed by Antti Koivisto.
1370
1371         QuickTime based media engines should respect private browsing mode
1372         https://bugs.webkit.org/show_bug.cgi?id=55848
1373
1374         No new tests, it is only possible to test this by manually deleting and monitoring the
1375         the Quicktime caches.
1376
1377         * html/HTMLMediaElement.cpp:
1378         (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
1379
1380         * platform/graphics/MediaPlayer.cpp:
1381         (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing.
1382         (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine.
1383         (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
1384         * platform/graphics/MediaPlayer.h:
1385         * platform/graphics/MediaPlayerPrivate.h:
1386         (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
1387
1388         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1389         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1390         (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing.
1391         (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when
1392             creating new movie.
1393         (WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in
1394             m_privateBrowsing and set movie attribute.
1395
1396         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1397         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
1398             Initialize m_privateBrowsing.
1399         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store 
1400             privacy setting in m_privateBrowsing and call QTMovie.
1401         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
1402
1403         * platform/graphics/win/QTMovie.cpp:
1404         (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing.
1405         (QTMovie::load):Pass private browsing property when creating new movie.
1406         (QTMovie::setPrivateBrowsingMode):  New, store privacy setting in m_privateBrowsing and 
1407             set movie property.
1408         * platform/graphics/win/QTMovie.h:
1409
1410 2011-03-06  Daniel Bates  <dbates@rim.com>
1411
1412         Reviewed by Darin Adler.
1413
1414         style.borderSpacing always returns empty string
1415         https://bugs.webkit.org/show_bug.cgi?id=54816
1416
1417         Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
1418         the value for border-spacing from the value of the WebKit internal CSS
1419         property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
1420
1421         The CSS property border-spacing describes the horizontal and vertical border
1422         spacing for an HTML Table element. Notice, WebKit internally represents the value
1423         of this property as two properties: -webkit-border-horizontal-spacing and
1424         -webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
1425         respectively. And WebKit doesn't know to reconstitute these internal properties.
1426         Therefore style.borderSpacing always returns the empty string.
1427
1428         Test: fast/css/table-border-spacing.html
1429
1430         * css/CSSMutableStyleDeclaration.cpp:
1431         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1432         (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
1433         * css/CSSMutableStyleDeclaration.h:
1434
1435 2011-03-06  Dan Bernstein  <mitz@apple.com>
1436
1437         Reviewed by Oliver Hunt.
1438
1439         <rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
1440         https://bugs.webkit.org/show_bug.cgi?id=55850
1441
1442         Tests: fast/css/parsing-hyphenate-limit.html
1443                fast/text/hyphenate-limit-before-after.html
1444
1445         * css/CSSComputedStyleDeclaration.cpp:
1446         (WebCore::computedProperties) Updated this array with the new properties and some old properties
1447         that it was missing.
1448         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
1449         CSSPropertyWebkitHyphenateLimit{Before,After}.
1450
1451         * css/CSSParser.cpp:
1452         (WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
1453         'auto' and non-negative integers.
1454
1455         * css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
1456
1457         * css/CSSStyleSelector.cpp:
1458         (WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.
1459
1460         * rendering/RenderBlockLineLayout.cpp:
1461         (WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
1462         allow hyphenation if the prefix and the suffix are sufficiently long.
1463         (WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().
1464
1465         * rendering/style/RenderStyle.cpp:
1466         (WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.
1467
1468         * rendering/style/RenderStyle.h:
1469         (WebCore::InheritedFlags::hyphenationLimitBefore): Added.
1470         (WebCore::InheritedFlags::hyphenationLimitAfter): Added.
1471         (WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
1472         (WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
1473         (WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
1474         representation of 'auto'.
1475         (WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.
1476
1477         * rendering/style/StyleRareInheritedData.cpp:
1478         (WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
1479         (WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.
1480         * rendering/style/StyleRareInheritedData.h:
1481
1482 2011-03-06  Jessie Berlin  <jberlin@apple.com>
1483
1484         Reviewed by Sam Weinig.
1485
1486         WebKit2: Use CFNetwork Sessions API.
1487         https://bugs.webkit.org/show_bug.cgi?id=55435.
1488
1489         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
1490         Private Browsing Storage Session.
1491
1492         * WebCore.exp.in:
1493         Add the new WKSI functions.
1494         * platform/mac/WebCoreSystemInterface.h:
1495         Ditto.
1496         * platform/mac/WebCoreSystemInterface.mm:
1497         Ditto.
1498
1499         * platform/mac/CookieJar.mm:
1500         (WebCore::cookies):
1501         If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
1502         Otherwise, behave the same as before.
1503         (WebCore::cookieRequestHeaderFieldValue):
1504         Ditto.
1505         (WebCore::setCookies):
1506         Ditto.
1507         (WebCore::cookiesEnabled):
1508         Ditto
1509         (WebCore::getRawCookies):
1510         Ditto.
1511         (WebCore::deleteCookie):
1512         Ditto.
1513
1514         * platform/network/CookieStorage.h:
1515         * platform/network/cf/CookieStorageCFNet.cpp:
1516         (WebCore::privateBrowsingCookieStorage):
1517         Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
1518         function instead of at the global scope.
1519         (WebCore::currentCookieStorage):
1520         Use privateBrowsingCookieStorage.
1521         (WebCore::setCurrentCookieStorage):
1522         Ditto.
1523         (WebCore::setCookieStoragePrivateBrowsingEnabled):
1524         If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
1525         wkCreatePrivateInMemoryHTTPCookieStorage.
1526         * platform/network/mac/CookieStorageMac.mm:
1527         (WebCore::privateBrowsingCookieStorage):
1528         Keep track of the Private Browsing Cookie Storage.
1529         (WebCore::setCookieStoragePrivateBrowsingEnabled):
1530         If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
1531         Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
1532
1533         * platform/network/mac/ResourceHandleMac.mm:
1534         (WebCore::shouldRelaxThirdPartyCookiePolicy):
1535         Refactor the logic to determine whether or not to relax the third party cookie policy here.
1536         If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
1537         (WebCore::ResourceHandle::createNSURLConnection):
1538         Use shouldRelaxThirdPartyCookiePolicy.
1539         (WebCore::ResourceHandle::loadResourceSynchronously):
1540         Ditto.
1541
1542 2011-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1543
1544         Unreviewed, rolling out r80428.
1545         http://trac.webkit.org/changeset/80428
1546         https://bugs.webkit.org/show_bug.cgi?id=55833
1547
1548         Broke SnowLeopard (Requested by xan_ on #webkit).
1549
1550         * plugins/gtk/PluginViewGtk.cpp:
1551         (WebCore::PluginView::handlePostReadFile):
1552
1553 2011-03-01  Martin Robinson  <mrobinson@igalia.com>
1554
1555         Reviewed by Xan Lopez.
1556
1557         [GTK] Windowless plugins override the view cursor
1558         https://bugs.webkit.org/show_bug.cgi?id=55531
1559
1560         manual test: manual-tests/plugins/windowless.html
1561
1562         * platform/gtk/WidgetGtk.cpp:
1563         (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
1564         * plugins/gtk/PluginViewGtk.cpp:
1565         (WebCore::PluginView::initXEvent): Instead of setting the window for windowless
1566         plugin events, set the window value to none. This method is also used to send
1567         focus in / focus out events to windowed plugins, but this is not one of the plugin
1568         types where the window parameter matters. This matches what Mozilla does. Also
1569         pass in the display of the widget itself, not the default display.
1570         (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area,
1571         reset the cursor.
1572         (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
1573         widget the top-level window explicitly. This matches Mozilla.
1574
1575 2011-03-05  Martin Robinson  <mrobinson@igalia.com>
1576
1577         Reviewed by Xan Lopez.
1578
1579         [GTK] http/tests/plugins/post-url-file.html fails on GTK+
1580         https://bugs.webkit.org/show_bug.cgi?id=55826
1581
1582         Correct the implementation of handlePostReadFile which uses GIO APIs and
1583         actually resizes the buffer to fit the entire size of the file data. This
1584         was likely leading to memory corruption until now.
1585
1586         * plugins/gtk/PluginViewGtk.cpp:
1587         (WebCore::PluginView::handlePostReadFile): Fix this method.
1588
1589 2011-03-05  Mikhail Naganov  <mnaganov@chromium.org>
1590
1591         Reviewed by Pavel Feldman.
1592
1593         Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
1594         https://bugs.webkit.org/show_bug.cgi?id=55824
1595
1596         Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
1597
1598         * inspector/front-end/DetailedHeapshotView.js:
1599         (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
1600         * inspector/front-end/ProfilesPanel.js:
1601         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
1602         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
1603         (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
1604         (WebInspector.ProfilesPanel.prototype.handleShortcut):
1605         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint):
1606         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint):
1607         (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
1608         (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
1609
1610 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
1611
1612         Reviewed by Laszlo Gombos.
1613
1614         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
1615         https://bugs.webkit.org/show_bug.cgi?id=48636
1616
1617         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
1618
1619         * WebCore.pri:
1620         * features.pri:
1621
1622 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
1623
1624         Not reviewed: adding null check to prevent inspector tests from failing.
1625
1626         * inspector/front-end/TextViewer.js:
1627         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
1628         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
1629
1630 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
1631
1632         Not reviewed: chromium rebaseline, flaky test fix.
1633
1634         * inspector/front-end/BreakpointManager.js:
1635         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
1636         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
1637         (WebInspector.DOMBreakpointView.prototype._format.formatters.s):
1638         (WebInspector.DOMBreakpointView.prototype._format.append):
1639         (WebInspector.DOMBreakpointView.prototype._format):
1640
1641 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
1642
1643         Reviewed by Yury Semikhatsky.
1644
1645         Web Inspector: [chromium] pause when script is running is broken.
1646         https://bugs.webkit.org/show_bug.cgi?id=55762
1647
1648         * inspector/CodeGeneratorInspector.pm:
1649
1650 2011-03-05  Adam Barth  <abarth@webkit.org>
1651
1652         Reviewed by Dimitri Glazkov.
1653
1654         Add Derived Sources to WebCore GYP build
1655         https://bugs.webkit.org/show_bug.cgi?id=55813
1656
1657         Adding the derived source action to the GYP file required tweaking
1658         DerivedSources.make.  I'm not sure how DerivedSources.make worked
1659         before beause these paths were incorrectly based.
1660
1661         * DerivedSources.make:
1662         * gyp/generate-derived-sources.sh: Added.
1663         * gyp/WebCore.gyp:
1664
1665 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
1666
1667         Reviewed by Yury Semikhatsky.
1668
1669         Web Inspector: fix layout tests flakiness.
1670         https://bugs.webkit.org/show_bug.cgi?id=55816
1671
1672         - Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
1673         - Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
1674
1675         * inspector/CodeGeneratorInspector.pm:
1676         * inspector/InspectorAgent.cpp:
1677         (WebCore::InspectorAgent::InspectorAgent):
1678         (WebCore::InspectorAgent::disconnectFrontend):
1679         (WebCore::InspectorAgent::populateScriptObjects):
1680         (WebCore::InspectorAgent::evaluateForTestInFrontend):
1681         (WebCore::InspectorAgent::issueEvaluateForTestCommands):
1682         * inspector/InspectorAgent.h:
1683         * inspector/front-end/TimelinePanel.js:
1684         (WebInspector.TimelinePanel.FormattedRecord):
1685         * inspector/front-end/inspector.js:
1686         (WebInspector.dispatch):
1687
1688 2011-03-05  Adam Barth  <abarth@webkit.org>
1689
1690         Reviewed by Dimitri Glazkov.
1691
1692         WebCore GYP build should generate fewer than 10,000 compile errors per file
1693         https://bugs.webkit.org/show_bug.cgi?id=55810
1694
1695         This patch adds some missing include paths.  We need to figure out how
1696         to handle separate include paths per port.  It's clear that
1697         ForwardingHeaders are only useful for Mac, but it's less clear how to
1698         handle the others.
1699
1700         * WebCore.gypi:
1701         * gyp/WebCore.gyp:
1702
1703 2011-03-05  Dan Bernstein  <mitz@apple.com>
1704
1705         Reviewed by Cameron Zwarich.
1706
1707         <rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
1708         https://bugs.webkit.org/show_bug.cgi?id=55817
1709
1710         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
1711         (WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
1712         a CGFont obtained from Core Text for the primary font. This CGFont may be different from
1713         the CGFont stored in the FontPlatformData.
1714
1715 2011-03-05  Ilya Sherman  <isherman@chromium.org>
1716
1717         Reviewed by Darin Adler.
1718
1719         HTMLInputElement::setValue() should schedule change event when the element is focused.
1720         Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
1721         In service of https://code.google.com/p/chromium/issues/detail?id=42716
1722         https://bugs.webkit.org/show_bug.cgi?id=53160
1723
1724         Test: fast/forms/onchange-change-type.html
1725         Test: fast/forms/onchange-setvalueforuser.html
1726
1727         * WebCore.exp.in:
1728         * dom/Document.cpp:
1729         (WebCore::Document::setFocusedNode):
1730         * dom/Element.h:
1731         (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
1732         (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
1733         * html/HTMLFormControlElement.cpp:
1734         (WebCore::HTMLFormControlElement::HTMLFormControlElement):
1735         (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added.
1736         (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added.
1737         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
1738         (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
1739         * html/HTMLFormControlElement.h:
1740         * html/HTMLInputElement.cpp:
1741         (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag.
1742         (WebCore::HTMLInputElement::setValue):
1743             For a focused text field, dispatch an input event, but delay the change event until the field loses focus.
1744         (WebCore::HTMLInputElement::defaultEventHandler):
1745         (WebCore::HTMLInputElement::stepUpFromRenderer):
1746         * html/shadow/TextControlInnerElements.cpp:
1747         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
1748         * rendering/RenderTextControl.cpp:
1749         (WebCore::RenderTextControl::RenderTextControl):
1750         (WebCore::RenderTextControl::subtreeHasChanged):
1751         * rendering/RenderTextControl.h:
1752         * rendering/RenderTextControlMultiLine.cpp:
1753         (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
1754         * rendering/RenderTextControlSingleLine.cpp:
1755         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
1756         * wml/WMLInputElement.cpp:
1757         (WebCore::WMLInputElement::WMLInputElement):
1758         (WebCore::WMLInputElement::defaultEventHandler):
1759         * wml/WMLInputElement.h:
1760         (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added.
1761         (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.
1762
1763 2011-03-04  Xianzhu Wang  <wangxianzhu@google.com>
1764
1765         Reviewed by Adam Barth.
1766
1767         Remove fake request loading of SVGImage to avoid MainResourceLoader
1768         leak. The frame->init() already ensures initialization of the
1769         document loader.
1770
1771         https://bugs.webkit.org/show_bug.cgi?id=55017
1772
1773         Test: fast/images/svg-image-leak-loader.html
1774
1775         * svg/graphics/SVGImage.cpp:
1776         (WebCore::SVGImage::dataChanged):
1777
1778 2011-03-04  Mike Reed  <reed@google.com>
1779
1780         Reviewed by Mihai Parparita.
1781
1782         [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
1783         https://bugs.webkit.org/show_bug.cgi?id=49477
1784
1785         * platform/graphics/skia/PathSkia.cpp:
1786         (WebCore::Path::addArc):
1787
1788 2011-03-04  Jia Pu  <jpu@apple.com>
1789
1790         Reviewed by Darin Adler.
1791
1792         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
1793         https://bugs.webkit.org/show_bug.cgi?id=55717
1794         <rdar://problem/9018127>
1795
1796         manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
1797
1798         Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
1799         coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
1800         to convert the bounding box to window coordinate using ScrollView::contentToWindow().
1801
1802         * dom/Range.cpp:
1803         (WebCore::Range::getBoundingClientRect):
1804         (WebCore::Range::boundingRect):
1805         * dom/Range.h:
1806         * editing/Editor.cpp:
1807         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
1808         (WebCore::Editor::correctionPanelTimerFired):
1809         (WebCore::Editor::windowRectForRange):
1810         * editing/Editor.h:
1811         * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
1812         * manual-tests/autocorrection/document-for-iframe-test.html: Added.
1813
1814 2011-03-04  Jia Pu  <jpu@apple.com>
1815
1816         Reviewed by Darin Adler.
1817
1818         Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
1819         https://bugs.webkit.org/show_bug.cgi?id=55731
1820
1821         No new tests. There's no behavioral change.
1822
1823         This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
1824
1825         * editing/Editor.cpp:
1826         (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
1827
1828 2011-03-04  John Bauman  <jbauman@chromium.org>
1829
1830         Reviewed by Kenneth Russell.
1831
1832         [chromium] premultipliedAlpha WebGL context attribute is ignored.
1833         https://bugs.webkit.org/show_bug.cgi?id=55411
1834
1835         Update compositor to set the blending of each layer correctly.
1836
1837         Test: compositing/webgl/webgl-nonpremultiplied-blend.html
1838
1839         * platform/graphics/chromium/CanvasLayerChromium.cpp:
1840         (WebCore::CanvasLayerChromium::CanvasLayerChromium):
1841         (WebCore::CanvasLayerChromium::draw):
1842         * platform/graphics/chromium/CanvasLayerChromium.h:
1843         * platform/graphics/chromium/ContentLayerChromium.cpp:
1844         (WebCore::ContentLayerChromium::draw):
1845         * platform/graphics/chromium/LayerRendererChromium.cpp:
1846         (WebCore::LayerRendererChromium::drawLayers):
1847         * platform/graphics/chromium/WebGLLayerChromium.cpp:
1848         (WebCore::WebGLLayerChromium::setContext):
1849
1850 2011-03-04  Adam Barth  <abarth@webkit.org>
1851
1852         Reviewed by Eric Seidel.
1853
1854         WebCore GYP build should link with the correct frameworks
1855         https://bugs.webkit.org/show_bug.cgi?id=55804
1856
1857         * gyp/WebCore.gyp:
1858
1859 2011-03-04  Adam Barth  <abarth@webkit.org>
1860
1861         Reviewed by Eric Seidel.
1862
1863         WebCore GYP build should Check For Inappropriate Files in Framework
1864         https://bugs.webkit.org/show_bug.cgi?id=55806
1865
1866         * gyp/WebCore.gyp:
1867
1868 2011-03-04  Dimitri Glazkov  <dglazkov@chromium.org>
1869
1870         Reviewed by Adam Barth.
1871
1872         Add skeletal WebCore.gyp
1873         https://bugs.webkit.org/show_bug.cgi?id=55802
1874
1875         This doesn't yet build, but the basic structure is there.
1876
1877         * WebCore.gypi: Added headers and include directories variables.
1878         * gyp/WebCore.gyp: Added.
1879
1880 2011-03-04  Adam Barth  <abarth@webkit.org>
1881
1882         Reviewed by Dimitri Glazkov.
1883
1884         Remove unneeded round-trips through ../Source in the Chromium GYP build
1885         https://bugs.webkit.org/show_bug.cgi?id=55795
1886
1887         This is just cleanup work, but it was bugging me.
1888
1889         * WebCore.gyp/WebCore.gyp:
1890
1891 2011-03-04  Mike Reed  <reed@google.com>
1892
1893         Reviewed by James Robinson.
1894
1895         Option to use skia's native text drawing APIs when drawing text
1896         on Windows, rather than from outlines using drawPath(). This will
1897         only have a significant effect when the skia-gpu backend is enabled.
1898         https://bugs.webkit.org/show_bug.cgi?id=55609
1899
1900         No new tests. This is disabled by default. When enabled, it will draw
1901         essentially the same, but with slightly different antialiased edges, due
1902         to differences between the current scanconverter and GDI's font scaler.
1903         When enabled, we will have to recalibrate layouttest image results. 
1904
1905         * platform/graphics/skia/SkiaFontWin.cpp:
1906         (WebCore::skiaDrawText):
1907         (WebCore::setupPaintForFont):
1908         (WebCore::paintSkiaText):
1909
1910 2011-03-04  Adrienne Walker  <enne@google.com>
1911
1912         Reviewed by James Robinson.
1913
1914         [chromium] Fix texture stride issues on large content and image layers.
1915         https://bugs.webkit.org/show_bug.cgi?id=55679
1916
1917         This was an error caused during the refactoring in r80081.
1918
1919         Tests: LayoutTests/compositing/tiling/huge-layer-img.html
1920
1921         * platform/graphics/chromium/ContentLayerChromium.cpp:
1922         (WebCore::ContentLayerChromium::updateTexture):
1923         * platform/graphics/chromium/ImageLayerChromium.cpp:
1924         (WebCore::ImageLayerChromium::updateTextureIfNeeded):
1925
1926 2011-03-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1927
1928         Unreviewed, rolling out r80379.
1929         http://trac.webkit.org/changeset/80379
1930         https://bugs.webkit.org/show_bug.cgi?id=55799
1931
1932         "Breaks leopard compile (implicit conversion)" (Requested by
1933         tonyg-cr on #webkit).
1934
1935         * css/CSSStyleSelector.cpp:
1936         (WebCore::convertToLength):
1937         (WebCore::CSSStyleSelector::applyProperty):
1938         (WebCore::CSSStyleSelector::createTransformOperations):
1939         * platform/Length.h:
1940         (WebCore::Length::Length):
1941         (WebCore::Length::operator==):
1942         (WebCore::Length::operator!=):
1943         (WebCore::Length::rawValue):
1944         (WebCore::Length::type):
1945         (WebCore::Length::quirk):
1946         (WebCore::Length::setValue):
1947         (WebCore::Length::setRawValue):
1948         (WebCore::Length::calcFloatValue):
1949         (WebCore::Length::isZero):
1950         (WebCore::Length::blend):
1951         * rendering/AutoTableLayout.cpp:
1952         (WebCore::AutoTableLayout::recalcColumn):
1953         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
1954         * rendering/FixedTableLayout.cpp:
1955         (WebCore::FixedTableLayout::calcWidthArray):
1956
1957 2011-03-04  Jessie Berlin  <jberlin@apple.com>
1958
1959         Reviewed by Darin Adler.
1960
1961         WebKit2: Use CFNetwork Sessions API.
1962         https://bugs.webkit.org/show_bug.cgi?id=55435.
1963
1964         Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
1965         contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
1966
1967         * platform/network/cf/ResourceHandleCFNet.cpp:
1968         (WebCore::makeFinalRequest):
1969         (WebCore::ResourceHandle::willSendRequest):
1970         * platform/network/cf/ResourceRequestCFNet.cpp:
1971         * platform/network/mac/ResourceHandleMac.mm:
1972         (WebCore::ResourceHandle::createNSURLConnection):
1973         (WebCore::ResourceHandle::willSendRequest):
1974         * platform/network/mac/ResourceRequestMac.mm:
1975
1976 2011-03-04  Yuqiang Xian  <yuqiang.xian@intel.com>
1977
1978         Reviewed by Darin Adler.
1979
1980         improve layout performance by reducing the traversal time of the floating objects
1981         https://bugs.webkit.org/show_bug.cgi?id=55440
1982
1983         We observered large overhead on traversing the floating objects list
1984         in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
1985         when the list becomes enormous, for example in the default 30x30 maze test
1986         from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
1987         there're >3700 floating objects. When placing a new floating object the
1988         entire list (from begin to end) is traversed for multiple times.
1989         There's a low hanging fruit to reduce the chances to do the traversal
1990         which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
1991         As the two routines either cares about FloatLeft objects or FloatRight objects only,
1992         if we know there's no corresponding type floating objects in the list
1993         we can avoid the traversal actually. One thing we could do is to record
1994         the number of FloatLeft objects and the number of FloatRight objects and
1995         add a check before doing the traversal. This can reduce the time by 45%
1996         to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
1997         Chromium browser 11 (from 503s to 269s).
1998
1999         No new tests, relying on existing layout tests.
2000
2001         * rendering/RenderBlock.cpp:
2002         (WebCore::RenderBlock::~RenderBlock):
2003         (WebCore::RenderBlock::addOverflowFromFloats):
2004         (WebCore::RenderBlock::repaintOverhangingFloats):
2005         (WebCore::RenderBlock::paintFloats):
2006         (WebCore::RenderBlock::selectionGaps):
2007         (WebCore::RenderBlock::insertFloatingObject):
2008         (WebCore::RenderBlock::removeFloatingObject):
2009         (WebCore::RenderBlock::removeFloatingObjectsBelow):
2010         (WebCore::RenderBlock::positionNewFloats):
2011         (WebCore::RenderBlock::positionNewFloatOnLine):
2012         (WebCore::RenderBlock::logicalLeftOffsetForLine):
2013         (WebCore::RenderBlock::logicalRightOffsetForLine):
2014         (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
2015         (WebCore::RenderBlock::lowestFloatLogicalBottom):
2016         (WebCore::RenderBlock::clearFloats):
2017         (WebCore::RenderBlock::addOverhangingFloats):
2018         (WebCore::RenderBlock::addIntrudingFloats):
2019         (WebCore::RenderBlock::containsFloat):
2020         (WebCore::RenderBlock::hitTestFloats):
2021         (WebCore::RenderBlock::adjustForBorderFit):
2022         (WebCore::RenderBlock::FloatingObjects::clear):
2023         (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
2024         (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
2025         * rendering/RenderBlock.h:
2026         (WebCore::RenderBlock::containsFloats):
2027         (WebCore::RenderBlock::FloatingObjects::FloatingObjects):
2028         (WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
2029         (WebCore::RenderBlock::FloatingObjects::hasRightObjects):
2030         (WebCore::RenderBlock::FloatingObjects::set):
2031         * rendering/RenderBlockLineLayout.cpp:
2032         (WebCore::RenderBlock::layoutInlineChildren):
2033         (WebCore::RenderBlock::matchedEndLine):
2034
2035 2011-03-04  Rik Cabanier  <cabanier@gmail.com>
2036
2037         Reviewed by David Hyatt.
2038
2039         Fix that allows fixed length values to be floating point
2040         https://bugs.webkit.org/show_bug.cgi?id=52699
2041
2042         * WebCore.xcodeproj/project.pbxproj:
2043         * css/CSSStyleSelector.cpp:
2044         (WebCore::convertToLength):
2045         (WebCore::convertToIntLength):
2046         (WebCore::convertToFloatLength):
2047         (WebCore::CSSStyleSelector::applyProperty):
2048         (WebCore::CSSStyleSelector::createTransformOperations):
2049         * platform/Length.h:
2050         (WebCore::Length::Length):
2051         (WebCore::Length::operator==):
2052         (WebCore::Length::operator!=):
2053         (WebCore::Length::rawValue):
2054         (WebCore::Length::type):
2055         (WebCore::Length::quirk):
2056         (WebCore::Length::setValue):
2057         (WebCore::Length::calcFloatValue):
2058         (WebCore::Length::isZero):
2059         (WebCore::Length::blend):
2060         (WebCore::Length::getIntValue):
2061         (WebCore::Length::getFloatValue):
2062         * rendering/AutoTableLayout.cpp:
2063         (WebCore::AutoTableLayout::recalcColumn):
2064         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
2065         * rendering/FixedTableLayout.cpp:
2066         (WebCore::FixedTableLayout::calcWidthArray):
2067
2068 2011-03-04  Steve Falkenburg  <sfalken@apple.com>
2069
2070         Reviewed by Jon Honeycutt.
2071
2072         Adopt VersionStamper tool for Windows WebKit DLLs
2073         https://bugs.webkit.org/show_bug.cgi?id=55784
2074         
2075         We now use a tool to stamp the version number onto the Apple WebKit DLLs
2076         during the post-build step.
2077
2078         * WebCore.vcproj/QTMovieWin.rc: Removed.
2079         * WebCore.vcproj/QTMovieWin.vcproj:
2080         * WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
2081         * WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
2082         * WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
2083
2084 2011-03-04  Cosmin Truta  <ctruta@chromium.org>
2085
2086         Reviewed by Adam Barth.
2087
2088         Clarify comment about potential memory leak in SVGImage
2089         https://bugs.webkit.org/show_bug.cgi?id=55362
2090
2091         No functionality change. No new tests.
2092
2093         * svg/graphics/SVGImage.cpp:
2094         (WebCore::SVGImage::dataChanged):
2095
2096 2011-03-04  Jessie Berlin  <jberlin@apple.com>
2097
2098         Reviewed by Maciej Stachowiak.
2099
2100         WebKit2: Use CFNetwork Sessions API.
2101         https://bugs.webkit.org/show_bug.cgi?id=55435.
2102
2103         When Private Browsing is enabled, get the cached url response from the cache associated with
2104         the Private Browsing Storage Session.
2105
2106         * WebCore.exp.in:
2107         Export the symbol for ResourceHandle::privateBrowsingStorageSession.
2108
2109 2011-03-04  Steve Block  <steveblock@google.com>
2110
2111         Reviewed by Jeremy Orlow.
2112
2113         JSC and V8 versions of Java bridge should share JobjectWrapper
2114         https://bugs.webkit.org/show_bug.cgi?id=55763
2115
2116         No new tests, refactoring only.
2117
2118         * Android.jscbindings.mk:
2119         * Android.v8bindings.mk:
2120         * WebCore.gypi:
2121         * WebCore.order:
2122         * WebCore.xcodeproj/project.pbxproj:
2123         * bridge/jni/JobjectWrapper.cpp:
2124         (JobjectWrapper::JobjectWrapper):
2125         (JobjectWrapper::~JobjectWrapper):
2126         * bridge/jni/JobjectWrapper.h:
2127         (JSC::Bindings::JobjectWrapper::instance):
2128         (JSC::Bindings::JobjectWrapper::setInstance):
2129         (JSC::Bindings::JobjectWrapper::ref):
2130         (JSC::Bindings::JobjectWrapper::deref):
2131         * bridge/jni/jsc/JNIBridgeJSC.cpp:
2132         (JavaField::JavaField):
2133         (JavaArray::JavaArray):
2134         * bridge/jni/jsc/JNIBridgeJSC.h:
2135         * bridge/jni/jsc/JavaInstanceJSC.cpp:
2136         (JavaInstance::JavaInstance):
2137         * bridge/jni/jsc/JavaInstanceJSC.h:
2138
2139 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
2140
2141         Reviewed by Nikolas Zimmermann.
2142
2143         Move shared code into SVGStyledTransformableElement::svgAttributeChanged
2144         https://bugs.webkit.org/show_bug.cgi?id=55771
2145
2146         All sub classes of SVGStyledTransformableElement request a relayout
2147         the same way. So move that code into the common base class.
2148
2149         * svg/SVGCircleElement.cpp:
2150         (WebCore::SVGCircleElement::svgAttributeChanged):
2151         * svg/SVGEllipseElement.cpp:
2152         (WebCore::SVGEllipseElement::svgAttributeChanged):
2153         * svg/SVGForeignObjectElement.cpp:
2154         (WebCore::SVGForeignObjectElement::svgAttributeChanged):
2155         * svg/SVGGElement.cpp:
2156         (WebCore::SVGGElement::svgAttributeChanged):
2157         * svg/SVGImageElement.cpp:
2158         (WebCore::SVGImageElement::svgAttributeChanged):
2159         * svg/SVGLineElement.cpp:
2160         (WebCore::SVGLineElement::svgAttributeChanged):
2161         * svg/SVGPathElement.cpp:
2162         (WebCore::SVGPathElement::svgAttributeChanged):
2163         * svg/SVGPolyElement.cpp:
2164         (WebCore::SVGPolyElement::svgAttributeChanged):
2165         * svg/SVGRectElement.cpp:
2166         (WebCore::SVGRectElement::svgAttributeChanged):
2167         * svg/SVGStyledTransformableElement.cpp:
2168         (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
2169         * svg/SVGStyledTransformableElement.h:
2170         * svg/SVGUseElement.cpp:
2171         (WebCore::SVGUseElement::svgAttributeChanged):
2172
2173 2011-03-03  John Abd-El-Malek  <jam@chromium.org>
2174
2175         Reviewed by Dimitri Glazkov.
2176
2177         [chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
2178         https://bugs.webkit.org/show_bug.cgi?id=55748
2179
2180         * platform/network/chromium/ResourceResponse.cpp:
2181         (WebCore::ResourceResponse::doPlatformCopyData):
2182         (WebCore::ResourceResponse::doPlatformAdopt):
2183         * platform/network/chromium/ResourceResponse.h:
2184         (WebCore::ResourceResponse::ResourceResponse):
2185
2186 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2187
2188         Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
2189
2190         Reviewed by Darin Adler.
2191
2192         * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
2193
2194 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
2195
2196         Reviewed by Yury Semikhatsky.
2197
2198         Web Inspector: extract all code that depends on source mapping from SourceFrame.
2199         https://bugs.webkit.org/show_bug.cgi?id=55464
2200
2201         Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
2202         to encapsulate source mapping aspects from SourceFrame.
2203
2204         * inspector/front-end/ResourceView.js:
2205         (WebInspector.ResourceView.createResourceView):
2206         (WebInspector.SourceFrameDelegateForResourcesPanel):
2207         (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
2208         * inspector/front-end/ScriptsPanel.js:
2209         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
2210         (WebInspector.SourceFrameDelegateForScriptsPanel):
2211         * inspector/front-end/SourceFrame.js:
2212         (WebInspector.SourceFrame):
2213         (WebInspector.SourceFrame.prototype.show):
2214         (WebInspector.SourceFrame.prototype._createTextViewer):
2215         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
2216         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
2217         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
2218         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
2219         (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
2220         (WebInspector.SourceFrame.prototype._contextMenu):
2221         (WebInspector.SourceFrame.prototype._mouseDown):
2222         (WebInspector.SourceFrame.prototype._mouseMove):
2223         (WebInspector.SourceFrame.prototype._hidePopup):
2224         (WebInspector.SourceFrame.prototype._mouseHover):
2225         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
2226         (WebInspector.SourceFrame.prototype._showPopup):
2227         (WebInspector.SourceFrame.prototype._doubleClick):
2228         (WebInspector.SourceFrame.prototype._didEditLine):
2229         (WebInspector.SourceFrameDelegate):
2230         (WebInspector.SourceFrameDelegate.prototype.requestContent):
2231         (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
2232         (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
2233         (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
2234         (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
2235         (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
2236         (WebInspector.SourceFrameDelegate.prototype.continueToLine):
2237         (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
2238         (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
2239         (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
2240         (WebInspector.SourceFrameDelegate.prototype.evaluate):
2241         (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
2242
2243 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
2244
2245         Reviewed by Pavel Feldman.
2246
2247         Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
2248         https://bugs.webkit.org/show_bug.cgi?id=55686
2249
2250         - Use internal ids for resources in extension server.
2251         - Log errors in inspector tests.
2252
2253         * inspector/front-end/ExtensionServer.js:
2254         (WebInspector.ExtensionServer):
2255         (WebInspector.ExtensionServer.prototype.resetResources):
2256         (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
2257         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
2258         (WebInspector.ExtensionServer.prototype._onGetHAR):
2259         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
2260         (WebInspector.ExtensionServer.prototype._resourceId):
2261         (WebInspector.ExtensionServer.prototype._resourceById):
2262         * inspector/front-end/HAREntry.js:
2263         (WebInspector.HARLog):
2264         (WebInspector.HARLog.prototype._convertResource):
2265         * inspector/front-end/NetworkPanel.js:
2266         (WebInspector.NetworkPanel.prototype._reset):
2267
2268 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
2269
2270         Reviewed by Pavel Feldman.
2271
2272         Web Inspector: exceptions when building context menu in network panel
2273         https://bugs.webkit.org/show_bug.cgi?id=55678
2274
2275         * inspector/front-end/DataGrid.js:
2276         (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
2277         (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
2278         * inspector/front-end/NetworkPanel.js:
2279         (WebInspector.NetworkPanel.prototype._contextMenu):
2280
2281 2011-03-04  Ilya Sherman  <isherman@chromium.org>
2282
2283         Reviewed by James Robinson.
2284
2285         Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
2286         This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
2287         is a FramelessScrollView -- which is mostly just for Autofill.
2288         In service of http://crbug.com/73772 (crash)
2289         https://bugs.webkit.org/show_bug.cgi?id=55557
2290
2291         No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
2292         In particular, DRT crashes when trying to render a FramelessScrollView.
2293
2294         * platform/ScrollbarTheme.h:
2295         (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner().
2296         (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
2297         * platform/chromium/FramelessScrollView.cpp:
2298         (WebCore::FramelessScrollView::paintContents):
2299         (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
2300         * platform/chromium/FramelessScrollView.h:
2301         * platform/chromium/ScrollbarThemeChromium.cpp:
2302         * platform/chromium/ScrollbarThemeChromium.h:
2303
2304 2011-03-04  Yury Semikhatsky  <yurys@chromium.org>
2305
2306         Reviewed by Pavel Feldman.
2307
2308         Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
2309         https://bugs.webkit.org/show_bug.cgi?id=55770
2310
2311         * inspector/InspectorAgent.cpp:
2312         (WebCore::InspectorAgent::InspectorAgent):
2313         (WebCore::InspectorAgent::didCommitLoad):
2314         * inspector/InspectorCSSAgent.cpp:
2315         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
2316         (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
2317         * inspector/InspectorCSSAgent.h:
2318         * inspector/InspectorDatabaseAgent.cpp:
2319         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
2320         * inspector/InspectorInstrumentation.cpp:
2321         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
2322         * inspector/InspectorInstrumentation.h:
2323         (WebCore::InspectorInstrumentation::didCommitLoad):
2324         * inspector/InspectorProfilerAgent.cpp:
2325         (WebCore::InspectorProfilerAgent::create):
2326         (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
2327         (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
2328         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
2329         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
2330         (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
2331         (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
2332         * inspector/InspectorProfilerAgent.h:
2333         * inspector/InstrumentingAgents.h:
2334         (WebCore::InstrumentingAgents::InstrumentingAgents):
2335         (WebCore::InstrumentingAgents::inspectorCSSAgent):
2336         (WebCore::InstrumentingAgents::setInspectorCSSAgent):
2337         (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
2338         (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
2339         (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
2340         (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
2341         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
2342         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
2343         (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
2344         (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
2345         (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
2346         (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
2347         (WebCore::InstrumentingAgents::inspectorProfilerAgent):
2348         (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
2349
2350 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
2351
2352         Reviewed by Yury Semikhatsky.
2353
2354         Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
2355         https://bugs.webkit.org/show_bug.cgi?id=55773
2356
2357         * inspector/CodeGeneratorInspector.pm:
2358         * inspector/InjectedScript.cpp:
2359         (WebCore::InjectedScript::releaseObjectGroup):
2360         * inspector/InjectedScript.h:
2361         * inspector/InjectedScriptHost.cpp:
2362         (WebCore::InjectedScriptHost::releaseObjectGroup):
2363         * inspector/InjectedScriptHost.h:
2364         * inspector/InjectedScriptSource.js:
2365         (.):
2366         * inspector/Inspector.idl:
2367         * inspector/InspectorConsoleAgent.cpp:
2368         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
2369         * inspector/InspectorRuntimeAgent.cpp:
2370         (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
2371         * inspector/InspectorRuntimeAgent.h:
2372         * inspector/front-end/ConsoleView.js:
2373         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
2374         (WebInspector.ConsoleView.prototype.completions):
2375         * inspector/front-end/PropertiesSidebarPane.js:
2376         * inspector/front-end/SourceFrame.js:
2377         (WebInspector.SourceFrame.prototype._hidePopup):
2378         * inspector/front-end/WatchExpressionsSidebarPane.js:
2379         (WebInspector.WatchExpressionsSection.prototype.update):
2380
2381 2011-03-02  Andrey Adaikin  <aandrey@google.com>
2382
2383         Reviewed by Pavel Feldman.
2384
2385         Web Inspector: Gutter height should be 100% when few lines are displayed
2386         https://bugs.webkit.org/show_bug.cgi?id=55574
2387
2388         * inspector/front-end/SourceFrame.js:
2389         (WebInspector.SourceFrame.prototype._startEditing):
2390         * inspector/front-end/TextViewer.js:
2391         (WebInspector.TextViewer.prototype._syncScroll):
2392         (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
2393         (WebInspector.TextEditorGutterPanel.prototype.textChanged):
2394         (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
2395         * inspector/front-end/textViewer.css:
2396         (.text-editor-lines):
2397         (.text-editor-contents .inner-container):
2398         (.webkit-line-number):
2399
2400 2011-03-04  Andrey Adaikin  <aandrey@google.com>
2401
2402         Reviewed by Pavel Feldman.
2403
2404         Web Inspector: [Text editor] Do bisect to find visible chunks
2405         https://bugs.webkit.org/show_bug.cgi?id=55685
2406
2407         * inspector/front-end/TextViewer.js:
2408         (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
2409         (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
2410         (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
2411         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
2412         (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
2413         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
2414
2415 2011-03-04  Andrey Adaikin  <aandrey@google.com>
2416
2417         Reviewed by Pavel Feldman.
2418
2419         Web Inspector: [Text editor] DOMNodeRemoved events are missing
2420         https://bugs.webkit.org/show_bug.cgi?id=55769
2421
2422         * inspector/front-end/TextViewer.js:
2423         (WebInspector.TextEditorMainPanel):
2424         (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
2425         (WebInspector.TextEditorMainChunk):
2426         (WebInspector.TextEditorMainChunk.prototype._createRow):
2427
2428 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
2429
2430         Reviewed by Yury Semikhatsky.
2431
2432         Web Inspector: Remove unnecessary domain and success flags from the response messages.
2433         https://bugs.webkit.org/show_bug.cgi?id=55768
2434
2435         We have domain property in the response messages but it is not used because we dispatch
2436         the responses on the callback associated with seq.
2437
2438         If we have property 'errors' in the response then success eq false and true in the other case.
2439
2440         * inspector/CodeGeneratorInspector.pm:
2441
2442 2011-03-04  Christian Dywan  <christian@lanedo.com>
2443
2444         Reviewed by Gustavo Noronha Silva.
2445
2446         Enable Copy Image Address context menu item in the Gtk port
2447         https://bugs.webkit.org/show_bug.cgi?id=55136
2448
2449         * page/ContextMenuController.cpp:
2450         * platform/ContextMenuItem.h:
2451         * platform/LocalizationStrategy.h:
2452         * platform/LocalizedStrings.cpp:
2453         * platform/LocalizedStrings.h:
2454         * platform/gtk/ContextMenuItemGtk.cpp:
2455         * platform/gtk/LocalizedStringsGtk.cpp:
2456
2457 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
2458
2459         Reviewed by Yury Semikhatsky.
2460
2461         Web Inspector: implement getCompletions via evaluate.
2462         https://bugs.webkit.org/show_bug.cgi?id=55759
2463
2464         * inspector/InjectedScript.cpp:
2465         * inspector/InjectedScript.h:
2466         * inspector/InjectedScriptSource.js:
2467         * inspector/Inspector.idl:
2468         * inspector/InspectorDebuggerAgent.cpp:
2469         * inspector/InspectorDebuggerAgent.h:
2470         * inspector/InspectorRuntimeAgent.cpp:
2471         * inspector/InspectorRuntimeAgent.h:
2472         * inspector/front-end/ConsoleView.js:
2473         (WebInspector.ConsoleView.prototype.completions.evaluated):
2474         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
2475         (WebInspector.ConsoleView.prototype.completions):
2476         (WebInspector.ConsoleView.prototype._reportCompletions):
2477         * inspector/front-end/ScriptsPanel.js:
2478         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
2479         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
2480         * inspector/front-end/SourceFrame.js:
2481         (WebInspector.SourceFrame.prototype._showPopup):
2482         (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
2483
2484 2011-03-04  Steve Block  <steveblock@google.com>
2485
2486         Reviewed by Jeremy Orlow.
2487
2488         V8 version of JavaString should obtain string from JNI in UTF-16 encoding
2489         https://bugs.webkit.org/show_bug.cgi?id=55566
2490
2491         We obtain the string from JNI in UTF-16 encoding and convert
2492         to UTF-8 using our own routines as required. This matches the
2493         behaviour of the JSC version of JavaString.
2494
2495         No new tests, no change in behaviour.
2496
2497         * bridge/jni/v8/JavaStringV8.h:
2498         (JSC::Bindings::JavaStringImpl::init):
2499         (JSC::Bindings::JavaStringImpl::utf8):
2500         (JSC::Bindings::JavaStringImpl::impl):
2501
2502 2011-03-03  Pavel Feldman  <pfeldman@chromium.org>
2503
2504         Reviewed by Yury Semikhatsky.
2505
2506         Web Inspector: do not push document into front-end, make it request one.
2507         https://bugs.webkit.org/show_bug.cgi?id=55664
2508
2509         * inspector/Inspector.idl:
2510         * inspector/InspectorAgent.cpp:
2511         (WebCore::InspectorAgent::InspectorAgent):
2512         * inspector/InspectorAgent.h:
2513         * inspector/InspectorBrowserDebuggerAgent.cpp:
2514         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
2515         * inspector/InspectorDOMAgent.cpp:
2516         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2517         (WebCore::InspectorDOMAgent::clearFrontend):
2518         (WebCore::InspectorDOMAgent::setDocument):
2519         (WebCore::InspectorDOMAgent::getDocument):
2520         (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
2521         (WebCore::InspectorDOMAgent::boundNodeId):
2522         (WebCore::InspectorDOMAgent::resolveNode):
2523         (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
2524         * inspector/InspectorDOMAgent.h:
2525         (WebCore::InspectorDOMAgent::create):
2526         * inspector/front-end/BreakpointManager.js:
2527         (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
2528         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
2529         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
2530         * inspector/front-end/DOMAgent.js:
2531         (WebInspector.DOMDocument):
2532         (WebInspector.DOMAgent):
2533         (WebInspector.DOMAgent.prototype.requestDocument):
2534         (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
2535         (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
2536         (WebInspector.DOMAgent.prototype._attributesUpdated):
2537         (WebInspector.DOMAgent.prototype._characterDataModified):
2538         (WebInspector.DOMAgent.prototype._documentUpdated):
2539         (WebInspector.DOMAgent.prototype._setDocument):
2540         (WebInspector.DOMAgent.prototype._setDetachedRoot):
2541         (WebInspector.DOMAgent.prototype._setChildNodes):
2542         (WebInspector.DOMAgent.prototype._childNodeInserted):
2543         (WebInspector.DOMAgent.prototype._childNodeRemoved):
2544         (WebInspector.DOMDispatcher.prototype.documentUpdated):
2545         * inspector/front-end/ElementsPanel.js:
2546         (WebInspector.ElementsPanel.prototype.show):
2547         (WebInspector.ElementsPanel.prototype.setDocument):
2548         * inspector/front-end/MetricsSidebarPane.js:
2549         * inspector/front-end/RemoteObject.js:
2550         (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
2551
2552 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
2553
2554         Reviewed by Pavel Feldman.
2555
2556         Web Inspector: summary bar may overlap content of the network item view
2557         https://bugs.webkit.org/show_bug.cgi?id=55656
2558
2559         - drop custom summary bar placement logic, do it with CSS instead.
2560
2561         * inspector/front-end/NetworkPanel.js:
2562         (WebInspector.NetworkPanel.prototype.resize):
2563         (WebInspector.NetworkPanel.prototype._createSummaryBar):
2564         (WebInspector.NetworkPanel.prototype._updateSummaryBar):
2565         (WebInspector.NetworkPanel.prototype._updateFilter):
2566         (WebInspector.NetworkPanel.prototype.show):
2567         (WebInspector.NetworkPanel.prototype.refresh):
2568         (WebInspector.NetworkPanel.prototype._reset):
2569         (WebInspector.NetworkPanel.prototype._setLargerResources):
2570         (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
2571         * inspector/front-end/networkPanel.css:
2572         (.network-sidebar .data-grid td):
2573         (.network-sidebar tr.filler td):
2574         (.network-summary-bar):
2575         (.network-sidebar .data-grid .network-summary-bar td):
2576         (.network-summary-bar img):
2577
2578 2011-03-04  James Su <suzhe@chromium.org>
2579
2580         Reviewed by Dimitri Glazkov.
2581
2582         [Chromium] keycode is always 0 when using non-Latin keyboard layout.
2583         https://bugs.webkit.org/show_bug.cgi?id=54939
2584
2585         Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
2586
2587         No intended functionality change.
2588
2589         * WebCore.gyp/WebCore.gyp:
2590         * WebCore.gypi:
2591
2592 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
2593
2594         Unreviewed EFL build fix for r80324.
2595
2596         * platform/efl/RenderThemeEfl.cpp:
2597         (WebCore::RenderThemeEfl::paintThemePart):
2598
2599 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
2600
2601         Unreviewed EFL build fix for r80324.
2602
2603         * platform/efl/RenderThemeEfl.cpp:
2604         (WebCore::RenderThemeEfl::paintThemePart):
2605
2606 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
2607
2608         Reviewed by Pavel Feldman.
2609
2610         Web Inspector: AppCache agent should have same lifetime as InspectorAgent
2611         https://bugs.webkit.org/show_bug.cgi?id=55673
2612
2613         * inspector/InspectorAgent.cpp:
2614         (WebCore::InspectorAgent::InspectorAgent):
2615         (WebCore::InspectorAgent::setFrontend):
2616         (WebCore::InspectorAgent::disconnectFrontend):
2617         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
2618         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
2619         (WebCore::InspectorAgent::didCommitLoad):
2620         * inspector/InspectorApplicationCacheAgent.cpp:
2621         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
2622         (WebCore::InspectorApplicationCacheAgent::setFrontend):
2623         (WebCore::InspectorApplicationCacheAgent::clearFrontend):
2624         * inspector/InspectorApplicationCacheAgent.h:
2625         * inspector/InspectorInstrumentation.cpp:
2626         (WebCore::InspectorInstrumentation::networkStateChangedImpl):
2627         (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
2628         * inspector/InstrumentingAgents.h:
2629         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
2630         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
2631
2632 2011-03-03  Brian Weinstein  <bweinstein@apple.com>
2633
2634         Reviewed by Adam Roben.
2635
2636         Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
2637         
2638         Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
2639         on all platforms, and stub the functions on platforms that don't implement them.
2640         
2641         Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
2642         for platforms that don't implement them.
2643
2644         * platform/android/TemporaryLinkStubs.cpp:
2645         * platform/brew/TemporaryLinkStubs.cpp:
2646         * platform/chromium/TemporaryLinkStubs.cpp:
2647         * platform/efl/TemporaryLinkStubs.cpp:
2648         * platform/gtk/TemporaryLinkStubs.cpp:
2649         * platform/haiku/TemporaryLinkStubs.cpp:
2650         * platform/qt/TemporaryLinkStubsQt.cpp:
2651         * platform/win/TemporaryLinkStubs.cpp:
2652
2653 2011-03-03  Eric Seidel  <eric@webkit.org>
2654
2655         Reviewed by Dimitri Glazkov.
2656
2657         Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
2658         https://bugs.webkit.org/show_bug.cgi?id=55720
2659
2660         There are two thing going on here:
2661         1. Delaying nextRenderer calculation until we actually use it,
2662            previously we would always compute nextRenderer (expensive!)
2663            even if no renderer insertion was to occur.
2664         2. Fix fullscreen elements to be inserted into the right place
2665            in the rendering tree.  Previously they would always be the last
2666            child in their parent's list, even if that wasn't the right place.
2667
2668         I don't know of any way to trigger the fullscreen bug,
2669         but I tested this with peacekeeper and saw no performance change.
2670
2671         Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
2672         but I don't really trust the stability of peacekeeper to begin with.
2673
2674         This paves the way for further improvement in our nextRenderer calculation.
2675
2676         * dom/Node.cpp:
2677         (WebCore::Node::attach):
2678         (WebCore::Node::previousRenderer):
2679         (WebCore::Node::nextRenderer):
2680         (WebCore::Node::createRendererAndStyle):
2681         (WebCore::wrapWithRenderFullScreen):
2682         (WebCore::Node::createRendererIfNeeded):
2683         * dom/Node.h:
2684
2685 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2686
2687         Reviewed by Darin Adler.
2688
2689         Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
2690         https://bugs.webkit.org/show_bug.cgi?id=55554
2691
2692         * platform/Length.cpp:
2693         (WebCore::newLengthArray): Pass nullptr instead of 0.
2694
2695 2011-03-03  Nat Duca  <nduca@chromium.org>
2696
2697         Reviewed by James Robinson.
2698
2699         [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
2700         LayerRendererChromium that draws compositor FPS and, optionally,
2701         the layer tree.
2702         https://bugs.webkit.org/show_bug.cgi?id=54710
2703
2704         * WebCore.gypi:
2705         * platform/graphics/chromium/Canvas2DLayerChromium.h:
2706         (WebCore::Canvas2DLayerChromium::drawsContent):
2707         * platform/graphics/chromium/CanvasLayerChromium.h:
2708         (WebCore::CanvasLayerChromium::layerTypeAsString):
2709         * platform/graphics/chromium/ContentLayerChromium.cpp:
2710         (WebCore::writeIndent):
2711         (WebCore::ContentLayerChromium::dumpLayerProperties):
2712         * platform/graphics/chromium/ContentLayerChromium.h:
2713         (WebCore::ContentLayerChromium::drawsContent):
2714         (WebCore::ContentLayerChromium::layerTypeAsString):
2715         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
2716         (WebCore::GraphicsLayerChromium::setName):
2717         (WebCore::GraphicsLayerChromium::updateNames):
2718         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
2719         (WebCore::GraphicsLayerChromium::setupContentsLayer):
2720         * platform/graphics/chromium/GraphicsLayerChromium.h:
2721         * platform/graphics/chromium/ImageLayerChromium.h:
2722         (WebCore::ImageLayerChromium::drawsContent):
2723         (WebCore::ImageLayerChromium::layerTypeAsString):
2724         * platform/graphics/chromium/LayerChromium.cpp:
2725         (WebCore::LayerChromium::LayerChromium):
2726         (WebCore::LayerChromium::setName):
2727         (WebCore::LayerChromium::layerTreeAsText):
2728         (WebCore::writeIndent):
2729         (WebCore::LayerChromium::dumpLayer):
2730         (WebCore::LayerChromium::dumpLayerProperties):
2731         * platform/graphics/chromium/LayerChromium.h:
2732         (WebCore::LayerChromium::name):
2733         (WebCore::LayerChromium::drawsContent):
2734         (WebCore::LayerChromium::debugID):
2735         (WebCore::LayerChromium::layerTypeAsString):
2736         * platform/graphics/chromium/LayerRendererChromium.cpp:
2737         (WebCore::LayerRendererChromium::LayerRendererChromium):
2738         (WebCore::LayerRendererChromium::~LayerRendererChromium):
2739         (WebCore::LayerRendererChromium::drawLayers):
2740         (WebCore::LayerRendererChromium::present):
2741         (WebCore::LayerRendererChromium::layerTreeAsText):
2742         (WebCore::LayerRendererChromium::dumpRenderSurfaces):
2743         * platform/graphics/chromium/LayerRendererChromium.h:
2744         (WebCore::LayerRendererChromium::getHeadsUpDisplay):
2745         (WebCore::LayerRendererChromium::rootVisibleRect):
2746         * platform/graphics/chromium/PluginLayerChromium.h:
2747         (WebCore::PluginLayerChromium::drawsContent):
2748         (WebCore::PluginLayerChromium::layerTypeAsString):
2749         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
2750         (WebCore::RenderSurfaceChromium::name):
2751         (WebCore::writeIndent):
2752         (WebCore::RenderSurfaceChromium::dumpSurface):
2753         * platform/graphics/chromium/RenderSurfaceChromium.h:
2754         * platform/graphics/chromium/VideoLayerChromium.h:
2755         (WebCore::VideoLayerChromium::drawsContent):
2756         (WebCore::VideoLayerChromium::layerTypeAsString):
2757         * platform/graphics/chromium/WebGLLayerChromium.h:
2758         (WebCore::WebGLLayerChromium::drawsContent):
2759         (WebCore::WebGLLayerChromium::layerTypeAsString):
2760         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
2761         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
2762         (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
2763         (WebCore::CCHeadsUpDisplay::draw):
2764         (WebCore::CCHeadsUpDisplay::drawHudContents):
2765         (WebCore::CCHeadsUpDisplay::onPresent):
2766         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
2767         (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
2768         (WebCore::CCHeadsUpDisplay::showFPSCounter):
2769         (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
2770         (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
2771         (WebCore::CCHeadsUpDisplay::enabled):
2772         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2773         (WebCore::CCLayerImpl::CCLayerImpl):
2774         (WebCore::writeIndent):
2775         (WebCore::CCLayerImpl::dumpLayerProperties):
2776         * platform/graphics/chromium/cc/CCLayerImpl.h:
2777         (WebCore::CCLayerImpl::debugID):
2778         (WebCore::CCLayerImpl::setName):
2779         (WebCore::CCLayerImpl::name):
2780
2781 2011-03-02  Ojan Vafai  <ojan@chromium.org>
2782
2783         Reviewed by Darin Adler.
2784
2785         crash in adoptNode with mutation events
2786         https://bugs.webkit.org/show_bug.cgi?id=50046
2787
2788         If the DOM is modified during the removeChild call in adoptNode,
2789         then the setDocument call that follows can leave the DOM in an
2790         inconsistent state.
2791
2792         * dom/Document.cpp:
2793         (WebCore::Document::adoptNode):
2794
2795 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
2796
2797         Reviewed by Darin Adler.
2798
2799         Add audio tag tests to the media controls manual test suite.
2800         https://bugs.webkit.org/show_bug.cgi?id=55722
2801
2802         * manual-tests/media-controls.html: Added 4 audio tests.
2803
2804 2011-03-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2805
2806         Reviewed by Eric Seidel.
2807
2808         [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
2809         https://bugs.webkit.org/show_bug.cgi?id=54392
2810
2811         Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
2812         WebCore's functions should adhere WebKit coding style.
2813
2814         * platform/efl/RenderThemeEfl.cpp:
2815         (WebCore::RenderThemeEfl::themePartCacheEntryReset):
2816         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
2817         (WebCore::RenderThemeEfl::cacheThemePartNew):
2818         (WebCore::RenderThemeEfl::cacheThemePartReset):
2819         (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
2820         (WebCore::RenderThemeEfl::cacheThemePartGet):
2821         (WebCore::RenderThemeEfl::cacheThemePartFlush):
2822         (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
2823         (WebCore::RenderThemeEfl::paintThemePart):
2824         (WebCore::renderThemeEflColorClassSelectionActive):
2825         (WebCore::renderThemeEflColorClassSelectionInactive):
2826         (WebCore::renderThemeEflColorClassFocusRing):
2827         (WebCore::renderThemeEflColorClassButtonText):
2828         (WebCore::renderThemeEflColorClassComboText):
2829         (WebCore::renderThemeEflColorClassEntryText):
2830         (WebCore::renderThemeEflColorClassSearchText):
2831         (WebCore::RenderThemeEfl::applyPartDescription):
2832         (WebCore::RenderThemeEfl::applyPartDescriptions):
2833         (WebCore::RenderThemeEfl::controlSupportsTints):
2834         (WebCore::RenderThemeEfl::baselinePosition):
2835         (WebCore::RenderThemeEfl::paintSliderTrack):
2836         (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
2837         (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
2838         (WebCore::RenderThemeEfl::paintSliderThumb):
2839         (WebCore::RenderThemeEfl::adjustCheckboxStyle):
2840         (WebCore::RenderThemeEfl::paintCheckbox):
2841         (WebCore::RenderThemeEfl::adjustRadioStyle):
2842         (WebCore::RenderThemeEfl::paintRadio):
2843         (WebCore::RenderThemeEfl::adjustButtonStyle):
2844         (WebCore::RenderThemeEfl::paintButton):
2845         (WebCore::RenderThemeEfl::adjustMenuListStyle):
2846         (WebCore::RenderThemeEfl::paintMenuList):
2847         (WebCore::RenderThemeEfl::adjustTextFieldStyle):
2848         (WebCore::RenderThemeEfl::paintTextField):
2849         (WebCore::RenderThemeEfl::adjustTextAreaStyle):
2850         (WebCore::RenderThemeEfl::paintTextArea):
2851         (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
2852         (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
2853         (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
2854         (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
2855         (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
2856         (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
2857         (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
2858         (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
2859         (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
2860         (WebCore::RenderThemeEfl::paintSearchField):
2861         (WebCore::RenderThemeEfl::adjustProgressBarStyle):
2862         (WebCore::RenderThemeEfl::paintProgressBar):
2863         (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
2864         (WebCore::RenderThemeEfl::paintMediaMuteButton):
2865         (WebCore::RenderThemeEfl::paintMediaPlayButton):
2866         (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
2867         (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
2868         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
2869         (WebCore::RenderThemeEfl::paintMediaSliderThumb):
2870         (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
2871         (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
2872         (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
2873         (WebCore::RenderThemeEfl::paintMediaCurrentTime):
2874
2875 2011-03-03  Andy Estes  <aestes@apple.com>
2876
2877         Reviewed by Adam Barth.
2878
2879         Assertion failure in toElement(WebCore::Node*)
2880         https://bugs.webkit.org/show_bug.cgi?id=55697
2881
2882         Test: fast/parser/fragment-foreign-content.html
2883
2884         * html/parser/HTMLTreeBuilder.cpp:
2885         (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
2886         element in the HTMLElementStack might be a DocumentFragment if a
2887         fragment is being parsed who's first node is foreign content.
2888
2889 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2890
2891         Reviewed by Kenneth Rohde Christiansen.
2892
2893         [QT] Implement mock client-based geolocation for layout testing
2894         https://bugs.webkit.org/show_bug.cgi?id=54334
2895
2896         Implements client() to GeolocationController to re-use geolocationClientMock class
2897         for layout testing purpose.
2898
2899         * page/GeolocationController.h:
2900         (WebCore::GeolocationController::client):
2901
2902 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2903
2904         Reviewed by Kent Tamura.
2905
2906         Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
2907         https://bugs.webkit.org/show_bug.cgi?id=55352
2908
2909         Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:
2910
2911         * editing/CompositeEditCommand.cpp:
2912         (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and
2913         no longer calls deprecated functions.
2914         * editing/InsertTextCommand.cpp:
2915         (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion.
2916         Check if the text node inside a tab span before checking if the container node is a text node
2917         because the position before or after a text node can still be inside a tab span.
2918         (WebCore::InsertTextCommand::input): No longer calls deprecated functions.
2919         * editing/InsertTextCommand.h:
2920         * editing/ModifySelectionListLevel.cpp:
2921         (WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start
2922         or the end of selection could be an immediate child of a list node (e.g. br inside ul)
2923
2924 2011-03-03  Hans Wennborg  <hans@chromium.org>
2925
2926         Reviewed by Jeremy Orlow.
2927
2928         IndexedDB: Move last bits of SQL into IDBBackingStore
2929         https://bugs.webkit.org/show_bug.cgi?id=55668
2930
2931         After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
2932
2933         No new tests: refactoring only.
2934
2935         * storage/IDBBackingStore.cpp:
2936         (WebCore::IDBBackingStore::createTransaction):
2937         * storage/IDBBackingStore.h:
2938         * storage/IDBCursorBackendImpl.h:
2939         * storage/IDBDatabaseBackendImpl.cpp:
2940         (WebCore::IDBDatabaseBackendImpl::backingStore):
2941         * storage/IDBDatabaseBackendImpl.h:
2942         * storage/IDBIndexBackendImpl.h:
2943         * storage/IDBKey.h:
2944         * storage/IDBObjectStoreBackendImpl.h:
2945         * storage/IDBTransactionBackendImpl.cpp:
2946         (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
2947         * storage/IDBTransactionBackendImpl.h:
2948         * storage/IDBTransactionBackendInterface.h:
2949         * storage/IDBTransactionCoordinator.cpp:
2950
2951 2011-03-03  Adam Klein  <adamk@chromium.org>
2952
2953         Reviewed by David Levin.
2954
2955         [fileapi] Tighten up ResolveURICallbacks
2956         https://bugs.webkit.org/show_bug.cgi?id=55638
2957
2958         Two changes:
2959           - Retry only on TYPE_MISMATCH_ERR now that Chromium
2960             properly sets that error code.
2961           - Call DirectoryEntry instead of DOMFileSystem methods.
2962
2963         No change in behavior, so no new tests.
2964
2965         * fileapi/FileSystemCallbacks.cpp:
2966         (WebCore::ResolveURICallbacks::didOpenFileSystem):
2967
2968 2011-03-03  Anders Carlsson  <andersca@apple.com>
2969
2970         Reviewed by Sam Weinig.
2971
2972         Get rid of Page::globalHistoryItem
2973         https://bugs.webkit.org/show_bug.cgi?id=55738
2974
2975         The m_globalHistoryItem is only used by Mac and Windows WebKit1.
2976         Instead of having WebCore updating this member variable, just call out
2977         to a FrameLoaderClient member function and let WebKit keep it up to date.
2978
2979         * loader/EmptyClients.h:
2980         (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
2981         (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
2982         * loader/FrameLoader.cpp:
2983         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2984         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2985         * loader/FrameLoaderClient.h:
2986         (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
2987         * loader/HistoryController.cpp:
2988         (WebCore::HistoryController::goToItem):
2989         (WebCore::HistoryController::updateForStandardLoad):
2990         (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
2991         * page/Page.cpp:
2992         * page/Page.h:
2993
2994 2011-03-02  Jeremy Orlow  <jorlow@chromium.org>
2995
2996         Reviewed by Steve Block.
2997
2998         Cursor.continue with a key param should test less than, not equal to
2999         https://bugs.webkit.org/show_bug.cgi?id=55640
3000
3001         If you supply a param to cursor.continue, we sould guarantee that
3002         the item we continue to is greater than or equal to the parameter.
3003         Right now, we only test equality.
3004
3005         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
3006         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor
3007
3008         Test: storage/indexeddb/cursor-continue.html
3009
3010         * storage/IDBCursorBackendImpl.cpp:
3011         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
3012         * storage/IDBKey.cpp:
3013         (WebCore::IDBKey::isLessThan):
3014         (WebCore::IDBKey::isEqual):
3015         * storage/IDBKey.h:
3016
3017 2011-03-03  Brent Fulgham  <bfulgham@webkit.org>
3018
3019         Build fix. Need win/cURL DownloadBundle stub.
3020
3021         * platform/network/curl/DownloadBundle.h: Added.
3022
3023 2011-03-03  Geoffrey Garen  <ggaren@apple.com>
3024
3025         Rolled out 80277 and 80280 because they caused event handler layout test
3026         failures.
3027
3028         * WebCore.xcodeproj/project.pbxproj:
3029         * bindings/js/JSDOMGlobalObject.cpp:
3030         * bindings/js/JSDOMGlobalObject.h:
3031         * bindings/js/JSDOMWindowBase.cpp:
3032         * bindings/js/JSDOMWindowBase.h:
3033         * bindings/js/JSDOMWindowCustom.h:
3034         * bindings/js/JSWorkerContextBase.cpp:
3035
3036 2011-03-03  Brady Eidson  <beidson@apple.com>
3037
3038         Reviewed by Darin Adler.
3039
3040         https://bugs.webkit.org/show_bug.cgi?id=55721
3041         Global IconDatabase should be returned by reference, not as a pointer
3042
3043         * history/HistoryItem.cpp:
3044         (WebCore::HistoryItem::HistoryItem):
3045         (WebCore::HistoryItem::~HistoryItem):
3046         (WebCore::HistoryItem::reset):
3047         (WebCore::HistoryItem::icon):
3048         (WebCore::HistoryItem::setURLString):
3049
3050         * loader/FrameLoader.cpp:
3051         (WebCore::FrameLoader::startIconLoader):
3052         (WebCore::FrameLoader::commitIconURLToIconDatabase):
3053
3054         * loader/archive/cf/LegacyWebArchive.cpp:
3055         (WebCore::LegacyWebArchive::create):
3056
3057         * loader/icon/IconDatabase.cpp:
3058         (WebCore::iconDatabase):
3059         * loader/icon/IconDatabase.h:
3060         * loader/icon/IconDatabaseNone.cpp:
3061         (WebCore::iconDatabase):
3062         * loader/icon/wince/IconDatabaseWinCE.cpp:
3063         (WebCore::iconDatabase):
3064
3065         * loader/icon/IconLoader.cpp:
3066         (WebCore::IconLoader::finishLoading):
3067
3068 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
3069
3070         Reviewed by Martin Robinson.
3071
3072         Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
3073         https://bugs.webkit.org/show_bug.cgi?id=52742
3074
3075         Use firstPositionInOrBeforeNode to instantiate appropriate position.
3076
3077         * page/FocusController.cpp:
3078         (WebCore::FocusController::advanceFocusInDocumentOrder):
3079
3080 2011-03-03  Andy Estes  <aestes@apple.com>
3081
3082         Reviewed by Darin Adler.
3083
3084         When displaying the missing plug-in sheet, pass the 'pluginspage'
3085         attribute to the UI process.
3086         https://bugs.webkit.org/show_bug.cgi?id=55553
3087
3088         * WebCore.exp.in: Export __ZN7WebCore9HTMLNames15pluginspageAttrE.
3089         * html/HTMLAttributeNames.in: Add 'pluginspage' as a known content
3090         attribute.
3091
3092 2011-03-03  Jessie Berlin  <jberlin@apple.com>
3093
3094         Reviewed by Adam Roben.
3095
3096         WebKit2: Use CFNetwork Sessions API.
3097         https://bugs.webkit.org/show_bug.cgi?id=55435
3098
3099         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
3100
3101         * WebCore.exp.in:
3102         Support using WKCopyRequestWithStorageSession in WebCore.
3103         * platform/mac/WebCoreSystemInterface.h:
3104         Ditto.
3105         * platform/mac/WebCoreSystemInterface.mm:
3106         Ditto.
3107
3108         * platform/network/cf/ResourceHandleCFNet.cpp:
3109         (WebCore::makeFinalRequest):
3110         If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
3111         (WebCore::ResourceHandle::willSendRequest):
3112         Ditto.
3113         * platform/network/mac/ResourceHandleMac.mm:
3114         (WebCore::ResourceHandle::createNSURLConnection):
3115         Ditto.
3116         (WebCore::ResourceHandle::willSendRequest):
3117         Ditto.
3118
3119         * platform/network/cf/ResourceRequest.h:
3120         * platform/network/cf/ResourceRequestCFNet.cpp:
3121         (WebCore::ResourceRequest::setStorageSession):
3122         Call through to WKSI.
3123         * platform/network/mac/ResourceRequestMac.mm:
3124         (WebCore::ResourceRequest::setStorageSession):
3125         Ditto.
3126
3127 2011-03-03  Chris Marrin  <cmarrin@apple.com>
3128
3129         Reviewed by Simon Fraser.
3130
3131         REGRESSION: Accelerated transitions are jumpy
3132         https://bugs.webkit.org/show_bug.cgi?id=55022
3133
3134         Changed the way default TimingFunction is stored according to Adam Roben's
3135         suggestion.
3136
3137         * platform/animation/TimingFunction.h:
3138         (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
3139
3140 2011-03-03  Dan Bernstein  <mitz@apple.com>
3141
3142         Reviewed by Sam Weinig.
3143
3144         Rename -webkit-hyphenate-locale to -webkit-locale
3145         https://bugs.webkit.org/show_bug.cgi?id=55709
3146
3147         * css/CSSComputedStyleDeclaration.cpp:
3148         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3149         * css/CSSParser.cpp:
3150         (WebCore::CSSParser::parseValue):
3151         (WebCore::cssPropertyID):
3152         * css/CSSPropertyNames.in:
3153         * css/CSSStyleSelector.cpp:
3154         (WebCore::CSSStyleSelector::applyProperty):
3155         * rendering/RenderBlockLineLayout.cpp:
3156         (WebCore::RenderBlock::findNextLineBreak):
3157         * rendering/style/RenderStyle.cpp:
3158         (WebCore::RenderStyle::diff):
3159         * rendering/style/RenderStyle.h:
3160         (WebCore::InheritedFlags::locale):
3161         (WebCore::InheritedFlags::setLocale):
3162         (WebCore::InheritedFlags::initialLocale):
3163         * rendering/style/StyleRareInheritedData.cpp:
3164         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3165         (WebCore::StyleRareInheritedData::operator==):
3166         * rendering/style/StyleRareInheritedData.h:
3167
3168 2011-03-03  Kevin Ollivier  <kevino@theolliviers.com>
3169
3170         [wx] Build fixes. Use Font::textMetrics to get ascent value, and add missing include.
3171
3172         * platform/wx/DragDataWx.cpp:
3173         * platform/wx/wxcode/win/non-kerned-drawing.cpp:
3174         (WebCore::drawTextWithSpacing):
3175
3176 2011-03-03  Oliver Hunt  <oliver@apple.com>
3177
3178         Reviewed by Geoffrey Garen.
3179
3180         JSVariableObject needs to use WriteBarrier for symboltable property storage
3181         https://bugs.webkit.org/show_bug.cgi?id=55698
3182
3183         Update to pass JSGlobalData for the symbol table write used
3184         to set the document property.
3185
3186         * bindings/js/JSDOMWindowBase.cpp:
3187         (WebCore::JSDOMWindowBase::updateDocument):
3188
3189 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
3190
3191         More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.
3192
3193         * WebCore.xcodeproj/project.pbxproj:
3194         * page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
3195         * page/mac/WebCoreKeyboardUIMode.h: Removed.
3196
3197 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
3198
3199         Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
3200
3201         * page/ChromeClient.h:
3202
3203 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
3204
3205         Reviewed by Darin Adler.
3206
3207         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
3208         https://bugs.webkit.org/show_bug.cgi?id=55633
3209         <rdar://problem/8963023>
3210
3211         * loader/EmptyClients.h: (WebCore::EmptyChromeClient::keyboardUIMode):
3212         * page/ChromeClient.h:
3213         * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks):
3214         Merged tabsToLinks() and keyboardUIMode(). The latter returned a superset of information
3215         returned by former.
3216
3217 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
3218
3219         Fix Win compile break, caused by r80276.
3220
3221         * rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton
3222             to match RenderTheme.h.
3223
3224 2011-03-02  Geoffrey Garen  <ggaren@apple.com>
3225
3226         Reviewed by Darin Adler.
3227
3228         Moved all variable object storage inline -- upping the object size limit to 1K
3229         https://bugs.webkit.org/show_bug.cgi?id=55653
3230
3231         * bindings/js/JSDOMGlobalObject.cpp:
3232         * bindings/js/JSDOMGlobalObject.h:
3233         * bindings/js/JSDOMWindowBase.cpp:
3234         * bindings/js/JSDOMWindowBase.h:
3235         * bindings/js/JSDOMWindowCustom.h:
3236         * bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
3237
3238 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
3239
3240         Reviewed by Darin Adler.
3241
3242         Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
3243         https://bugs.webkit.org/show_bug.cgi?id=55099
3244
3245         Cleanup, no behavior change.
3246
3247         * html/shadow/MediaControls.cpp:
3248         (WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox
3249             instead of Node.
3250         * rendering/RenderMediaControls.cpp:
3251         (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed
3252             to use RenderBox as argument.
3253         * rendering/RenderMediaControls.h: Ditto.
3254         * rendering/RenderTheme.cpp:
3255         (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
3256         * rendering/RenderTheme.h: Ditto.
3257         * rendering/RenderThemeChromiumMac.h: Ditto.
3258         * rendering/RenderThemeChromiumMac.mm:
3259         (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
3260         * rendering/RenderThemeMac.h: Ditto.
3261         * rendering/RenderThemeMac.mm:
3262         (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
3263         * rendering/RenderThemeWin.cpp:
3264         (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
3265
3266 2011-03-03  Alexis Menard  <alexis.menard@openbossa.org>
3267
3268         Reviewed by Andreas Kling.
3269
3270         When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
3271         Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
3272         for GstElement.
3273
3274         * WebCore.pro:
3275         * features.pri:
3276
3277 2011-03-03  Anders Carlsson  <andersca@apple.com>
3278
3279         Try to fix the Windows build again.
3280
3281         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3282         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3283
3284 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3285
3286         Reviewed by Dimitri Glazkov.
3287
3288         Add another CRASH() for CSSSelector double frees
3289         https://bugs.webkit.org/show_bug.cgi?id=55693
3290
3291         To help track down bug 53045, add a CRASH call when the the array and/or
3292         CSSSelector member in CSSSelectorList is disposed of more than once.
3293
3294         Just a check, no new tests necessary.
3295         
3296         * css/CSSSelectorList.cpp:
3297         (WebCore::CSSSelectorList::deleteSelectors):
3298
3299 2011-03-03  Anders Carlsson  <andersca@apple.com>
3300
3301         Yet another attempt at fixing the Windows build.
3302
3303         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
3304         * platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
3305         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
3306         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3307
3308 2011-03-02  Chris Marrin  <cmarrin@apple.com>
3309
3310         Reviewed by Simon Fraser.
3311
3312         REGRESSION: Accelerated transitions are jumpy
3313         https://bugs.webkit.org/show_bug.cgi?id=55022
3314
3315         Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
3316         is now always passed in. The TimingFunction class now has a static method to get
3317         a default object which has the 'ease' values in it. I now assert in both Mac and
3318         Win implementations if a null TimingFunction pointer is seen.
3319
3320         * platform/animation/TimingFunction.h:
3321         (WebCore::CubicBezierTimingFunction::create):
3322         (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
3323         (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
3324         * platform/graphics/ca/GraphicsLayerCA.cpp:
3325         (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
3326         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
3327         (toCAMediaTimingFunction):
3328         * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
3329         (toCACFTimingFunction):
3330
3331 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3332
3333         Unreviewed build fix.
3334
3335         Fix clang compile after r80220
3336         https://bugs.webkit.org/show_bug.cgi?id=55692
3337
3338         * storage/IDBBackingStore.cpp:
3339         (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
3340
3341 2011-03-03  Anders Carlsson  <andersca@apple.com>
3342
3343         Attempt to fix the Windows build.
3344
3345         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3346         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3347
3348 2011-03-02  Brian Weinstein  <bweinstein@apple.com>
3349
3350         Reviewed by Adam Roben.
3351
3352         Rest of WebKit2: Need a way to send notifications to client when cookies change
3353         https://bugs.webkit.org/show_bug.cgi?id=55427
3354         <rdar://problem/9056027>
3355
3356         Add functions to be exported.
3357
3358         * WebCore.exp.in:
3359
3360 2011-03-03  Anders Carlsson  <andersca@apple.com>
3361
3362         Reviewed by Darin Adler.
3363
3364         Improve WebCore build time by ~5%
3365         https://bugs.webkit.org/show_bug.cgi?id=55688
3366
3367         Forward declare the CATransform3D and CGAffineTransform structs instead of including
3368         large chunks of QuartzCore and Core Graphics.
3369
3370         On an 8 core Mac Pro, this sped up building WebCore by about 5%.
3371
3372         * platform/graphics/ca/GraphicsLayerCA.cpp:
3373         * platform/graphics/ca/TransformationMatrixCA.cpp:
3374         * platform/graphics/transforms/TransformationMatrix.h:
3375
3376 2011-03-03  Andrey Kosyakov  <caseq@chromium.org>
3377
3378         Unreviewed. Adjusted call to a method renamed in r80102.
3379
3380         * inspector/front-end/SourceFrame.js:
3381         (WebInspector.SourceFrame.prototype._startEditing):
3382
3383 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3384
3385         Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
3386         by contexts not created by WebCore.
3387
3388         https://webkit.org/b/55642
3389
3390         Reviewed by Oliver Hunt.
3391
3392         * bindings/js/SerializedScriptValue.cpp:
3393         (WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
3394         (WebCore::SerializedScriptValue::deserialize): Ditto.
3395
3396 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
3397
3398         Reviewed by Darin Adler.
3399
3400         WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
3401         https://bugs.webkit.org/show_bug.cgi?id=55498
3402         <rdar://problem/8752706>
3403
3404         Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
3405                http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
3406
3407         * websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response
3408         header fields. Removed separate member variables for those, as they were duplicating data
3409         available in response, and there is no reason to squeeze microsecods here.
3410
3411         * websockets/WebSocketHandshake.cpp:
3412         (WebCore::WebSocketHandshake::reset): There are no longer member variables for header field
3413         values to reset here.
3414         (WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders().
3415         (WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
3416         (WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
3417         (WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
3418         (WebCore::WebSocketHandshake::serverSetCookie): Ditto.
3419         (WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
3420         (WebCore::WebSocketHandshake::serverUpgrade): Added.
3421         (WebCore::WebSocketHandshake::serverConnection): Added.
3422         (WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection
3423         header field presence and values.
3424
3425 2011-03-03  Helder Correia  <helder@sencha.com>
3426
3427         Reviewed by Andreas Kling.
3428
3429         [Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
3430         https://bugs.webkit.org/show_bug.cgi?id=55651
3431
3432         When relying on ContextShadow and using a gradient stroke for a path,
3433         the alpha of the shadow is incorrect.
3434
3435         * platform/graphics/qt/GraphicsContextQt.cpp:
3436         (WebCore::GraphicsContext::strokePath):
3437
3438 2011-03-03  Martin Robinson  <mrobinson@igalia.com>
3439
3440         XHTMLMP build broken after r78342
3441         https://bugs.webkit.org/show_bug.cgi?id=55286
3442
3443         Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
3444         instead of FrameLoader.
3445
3446         No new tests. This is a build fix.
3447
3448         * dom/Document.cpp:
3449         (WebCore::Document::isXHTMLMPDocument):
3450
3451 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
3452
3453         Reviewed by Eric Carlson.
3454
3455         Tweak MediaControlMuteButtonElement class hierarchy.
3456         https://bugs.webkit.org/show_bug.cgi?id=55614
3457
3458         This allows the mute button on the panel to have event handlers that are
3459         different from the mute button in the volume slider.
3460
3461         No change in behavior, covered by existing tests.
3462
3463         * html/shadow/MediaControls.cpp:
3464         (WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
3465         * rendering/MediaControlElements.cpp:
3466         (WebCore::MediaControlMuteButtonElement::updateDisplayType):
3467         (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added.
3468         (WebCore::MediaControlPanelMuteButtonElement::create): Added.
3469         (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
3470         * rendering/MediaControlElements.h: Added defs.
3471
3472 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
3473
3474         Reviewed by Pavel Feldman.
3475
3476         Web Inspector: Resource agent should have same lifetime as Inspector agent
3477         https://bugs.webkit.org/show_bug.cgi?id=55461
3478
3479         * inspector/Inspector.idl:
3480         * inspector/InspectorAgent.cpp:
3481         (WebCore::InspectorAgent::InspectorAgent):
3482         (WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed
3483         to clear frontend reference in all agents.
3484         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3485         (WebCore::InspectorAgent::setFrontend):
3486         (WebCore::InspectorAgent::disconnectFrontend):
3487         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
3488         (WebCore::InspectorAgent::didCommitLoad):
3489         * inspector/InspectorAgent.h:
3490         (WebCore::InspectorAgent::resourceAgent):
3491         * inspector/InspectorBrowserDebuggerAgent.cpp:
3492         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
3493         * inspector/InspectorDebuggerAgent.cpp:
3494         (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
3495         * inspector/InspectorInstrumentation.cpp:
3496         (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
3497         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
3498         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
3499         (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
3500         (WebCore::InspectorInstrumentation::retrieveResourceAgent):
3501         * inspector/InspectorResourceAgent.cpp:
3502         (WebCore::InspectorResourceAgent::setFrontend):
3503         (WebCore::InspectorResourceAgent::clearFrontend):
3504         (WebCore::InspectorResourceAgent::restore):
3505         (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
3506         (WebCore::InspectorResourceAgent::enable):
3507         (WebCore::InspectorResourceAgent::disable):
3508         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
3509         * inspector/InspectorResourceAgent.h:
3510         (WebCore::InspectorResourceAgent::create):
3511         * inspector/InspectorTimelineAgent.cpp:
3512         (WebCore::InspectorTimelineAgent::restore):
3513         * inspector/InspectorTimelineAgent.h:
3514         * inspector/front-end/NetworkManager.js:
3515         (WebInspector.NetworkManager):
3516         (WebInspector.NetworkManager.prototype.frontendReused):
3517         * inspector/front-end/inspector.js:
3518         (WebInspector.frontendReused):
3519
3520 2011-03-03  Andras Becsi  <abecsi@webkit.org>
3521
3522         Reviewed by Andreas Kling.
3523
3524         CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
3525         https://bugs.webkit.org/show_bug.cgi?id=55661
3526
3527         Test case originally written by Andreas Kling <andreas.kling@nokia.com>
3528
3529         Test: fast/canvas/rgba-parsing.html
3530
3531         * css/CSSParser.cpp:
3532         (WebCore::isValidDouble): Check whether the given string is a valid double.