unicode-bidi:-webkit-plaintext does not work on <textarea>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-07-27  Levi Weintraub  <leviw@chromium.org>
2
3         unicode-bidi:-webkit-plaintext does not work on <textarea>
4         https://bugs.webkit.org/show_bug.cgi?id=65074
5
6         Reviewed by Ryosuke Niwa.
7
8         Fixing unicode-bidi style propagation into text control shadow trees.
9
10         Test: fast/text/international/unicode-bidi-plaintext-in-textarea.html
11
12         * rendering/RenderTextControl.cpp:
13         (WebCore::RenderTextControl::adjustInnerTextStyle):
14
15 2011-07-27  Eric Carlson  <eric.carlson@apple.com>
16
17         Load delegate not consulted before loading some poster images
18         https://bugs.webkit.org/show_bug.cgi?id=65270
19
20         Reviewed by Darin Adler.
21
22         Test: media/video-poster-blocked-by-willsendrequest.html
23
24         * html/HTMLVideoElement.cpp:
25         (WebCore::HTMLVideoElement::setDisplayMode): Don't ask media engine to set poster if
26             willLoadMediaElementURL returns false.
27
28 2011-07-27  Stephen White  <senorblanco@chromium.org>
29
30         Fix for printing with accelerated <canvas>
31         https://bugs.webkit.org/show_bug.cgi?id=62406
32
33         Reviewed by James Robinson.
34
35         The platform-independent side of this should be covered by existing
36         tests.  Printing itself in Chrome has few tests, sadly.  :(
37
38         * html/HTMLCanvasElement.cpp:
39         (WebCore::HTMLCanvasElement::paint):
40         * platform/graphics/skia/ImageBufferSkia.cpp:
41         (WebCore::ImageBuffer::draw):
42
43 2011-07-25  Mihai Parparita  <mihaip@chromium.org>
44
45         [Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
46         https://bugs.webkit.org/show_bug.cgi?id=65158
47
48         Reviewed by David Hyatt.
49
50         Add per-Document instance user stylesheets (as opposed to the page 
51         group user styles and the global page stylesheet).
52
53         * css/CSSStyleSelector.cpp:
54         (WebCore::CSSStyleSelector::CSSStyleSelector):
55         * css/CSSStyleSelector.h:
56         * dom/Document.cpp:
57         (WebCore::Document::~Document):
58         (WebCore::Document::createStyleSelector):
59         (WebCore::Document::addUserSheet):
60         * dom/Document.h:
61
62 2011-07-27  Vsevolod Vlasov  <vsevik@chromium.org>
63
64         Web Inspector: Disable cache option should only clear memory cache, not disable it.
65         https://bugs.webkit.org/show_bug.cgi?id=65184
66
67         Reviewed by Pavel Feldman.
68
69         * inspector/InspectorClient.h:
70         * inspector/InspectorResourceAgent.cpp:
71         (WebCore::InspectorResourceAgent::enable):
72         (WebCore::InspectorResourceAgent::disable):
73         (WebCore::InspectorResourceAgent::setCacheDisabled):
74         (WebCore::InspectorResourceAgent::mainFrameNavigated):
75
76 2011-07-27  Rob Buis  <rbuis@rim.com>
77
78         Implement getIntersectionList(), getEnclosureList(), checkIntersection() and checkEnclosure() in SVGSVGElement
79         https://bugs.webkit.org/show_bug.cgi?id=11274
80
81         Reviewed by Nikolas Zimmermann.
82
83         Implement checkIntersection/checkEnclosure and use it to implement getIntersectionList and getEnclosureList as well.
84         The referenceElement is used to provide a DOM subtree to find matches in. Also we do not allow elements that specify
85         pointer-events=none in the list.
86
87         Tests: svg/W3C-SVG-1.1-SE/struct-dom-11-f.svg
88                svg/custom/intersection-list-clipping.svg
89                svg/custom/intersection-list-nested-svg.svg
90
91         * rendering/svg/RenderSVGModelObject.cpp:
92         (WebCore::getElementCTM):
93         (WebCore::intersectsAllowingEmpty):
94         (WebCore::isGraphicsElement):
95         (WebCore::RenderSVGModelObject::checkIntersection):
96         (WebCore::RenderSVGModelObject::checkEnclosure):
97         * rendering/svg/RenderSVGModelObject.h:
98         * svg/SVGSVGElement.cpp:
99         (WebCore::SVGSVGElement::checkIntersection):
100         (WebCore::SVGSVGElement::checkEnclosure):
101
102 2011-07-27  Becsi Andras  <abecsi@webkit.org>
103
104         [Qt][V8] Fix the build.
105
106         Unreviewed build fix.
107
108         No new tests needed.
109
110         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Add missing CString.h include.
111
112 2011-07-27  Alexis Menard  <alexis.menard@openbossa.org>
113
114         [Qt] Unreviewed build fix for mac.
115
116         QtKit is now our default media player, the define is WTF_USE_QTKIT and it's not part
117         of the options passed to build-webkit, therefore DerivedSources should now generate the
118         includes when it's mac.
119
120         * DerivedSources.pro:
121         * WebCore.pro:
122
123 2011-07-27  Yury Semikhatsky  <yurys@chromium.org>
124
125         Inspector should support cd(window) in the command line
126         https://bugs.webkit.org/show_bug.cgi?id=19872
127
128         Added dropdown list with all iframes to allow selecting current evaluation context for console expressions.
129
130         Reviewed by Pavel Feldman.
131
132         Test: http/tests/inspector/console-cd.html
133
134         * WebCore.gypi:
135         * inspector/Inspector.json:
136         * inspector/InspectorController.cpp:
137         (WebCore::InspectorController::InspectorController):
138         * inspector/InspectorRuntimeAgent.cpp:
139         (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
140         (WebCore::InspectorRuntimeAgent::evaluate):
141         * inspector/InspectorRuntimeAgent.h:
142         * inspector/WorkerInspectorController.cpp:
143         * inspector/front-end/ConsoleView.js:
144         (WebInspector.ConsoleView.prototype.addContext):
145         (WebInspector.ConsoleView.prototype.removeContext):
146         (WebInspector.ConsoleView.prototype._contextUpdated):
147         (WebInspector.ConsoleView.prototype.get _currentEvaluationContextId):
148         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
149         * inspector/front-end/ContextManager.js: Added.
150         (WebInspector.ContextManager):
151         (WebInspector.ContextManager.prototype._frameAdded):
152         (WebInspector.ContextManager.prototype._frameNavigated):
153         (WebInspector.ContextManager.prototype._frameDetached):
154         (WebInspector.FrameEvaluationContext):
155         (WebInspector.FrameEvaluationContext.prototype._frameNavigated):
156         (WebInspector.FrameEvaluationContext.prototype.get id):
157         (WebInspector.FrameEvaluationContext.prototype.get url):
158         (WebInspector.FrameEvaluationContext.prototype.get displayName):
159         * inspector/front-end/ResourceTreeModel.js:
160         (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
161         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
162         * inspector/front-end/WebKit.qrc:
163         * inspector/front-end/inspector.html:
164         * inspector/front-end/inspector.js:
165
166 2011-07-27  Shinya Kawanaka  <shinyak@google.com>
167
168         Uses isHTMLSpace to normalize white spaces.
169         https://bugs.webkit.org/show_bug.cgi?id=57746
170
171         Reviewed by Kent Tamura.
172
173         Test: fast/forms/option-strip-unicode-spaces.html
174
175         * dom/OptionElement.cpp:
176         (WebCore::OptionElement::normalizeText):
177           Uses isHTMLSpace to trim and replace white spaces.
178
179 2011-05-15  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
180
181         [chromium] Remove include of skia/ext/platform_canvas.h
182         https://bugs.webkit.org/show_bug.cgi?id=60852
183
184         Reviewed by Hajime Morita.
185
186         In https://bugs.webkit.org/show_bug.cgi?id=57563 the usage of the
187         skia::PlatformCanvas was eliminated in favor of directly using
188         SkCanvas directly. The include of platform_canvas.h was not removed
189         leaving the dependency on Chromium in the header files. Remove
190         that dependency now.
191
192         * platform/graphics/skia/PlatformContextSkia.h: Remove platform_canvas.h
193
194 2011-07-27  Mikhail Naganov  <mnaganov@chromium.org>
195
196         Web Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTracingToWindowObjects' of undefined
197         https://bugs.webkit.org/show_bug.cgi?id=65213
198
199         Reviewed by Pavel Feldman.
200
201         * inspector/front-end/DetailedHeapshotView.js:
202         (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
203
204 2011-07-27  Shinya Kawanaka  <shinyak@google.com>
205
206         Knob of a disabled or readonly range control should not be draggable.
207         https://bugs.webkit.org/show_bug.cgi?id=54820
208
209         Reviewed by Kent Tamura.
210
211         Made disabled or readonly range control undraggable.
212
213         Test: fast/forms/range-drag.html
214
215         * html/RangeInputType.cpp:
216         (WebCore::RangeInputType::handleMouseDownEvent):
217           Added check that the element is readonly or disabled.
218         * html/shadow/SliderThumbElement.cpp:
219         (WebCore::SliderThumbElement::defaultEventHandler): ditto.
220
221 2011-07-27  Yuta Kitamura  <yutak@chromium.org>
222
223         WebSocket: CloseEvent attribute is not available on WebWorkers in JSC
224         https://bugs.webkit.org/show_bug.cgi?id=65232
225
226         Reviewed by Kent Tamura.
227
228         Add [NoStaticTables] attribute to CloseEvent interface definition. This attribute
229         makes the code generator obtain the attributes table used for building ClassInfo
230         through JSGlobalData, instead of directly using a statically-allocated table.
231
232         Generally speaking, NoStaticTables needs to be specified in interfaces which
233         may be accessed from workers.
234
235         Tests: http/tests/websocket/tests/hybi/workers/shared-worker-simple.html (updated)
236                http/tests/websocket/tests/hybi/workers/worker-simple.html (updated)
237
238         * websockets/CloseEvent.idl: Fixed the formatting, too.
239
240 2011-07-26  James Robinson  <jamesr@chromium.org>
241
242         [chromium] REGRESSION(90963): Content layers are not redrawn after losing the compositor context
243         https://bugs.webkit.org/show_bug.cgi?id=65224
244
245         Reviewed by Kenneth Russell.
246
247         There's no automated way to test lost compositor contexts (yet), but to test manually open up the poster circle
248         page and kill the GPU process.
249
250         * platform/graphics/chromium/ContentLayerChromium.cpp:
251         (WebCore::ContentLayerChromium::cleanupResources):
252         * platform/graphics/chromium/ContentLayerChromium.h:
253
254 2011-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
255
256         Unreviewed, rolling out r91805.
257         http://trac.webkit.org/changeset/91805
258         https://bugs.webkit.org/show_bug.cgi?id=65226
259
260         Breaks @ symbols and changes other font rendering on Windows
261         (Requested by enne on #webkit).
262
263         * platform/graphics/chromium/FontChromiumWin.cpp:
264         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
265         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
266         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
267         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
268         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
269         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
270         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
271         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
272         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
273         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
274         (WebCore::drawGlyphsWin):
275         (WebCore::Font::drawComplexText):
276         * platform/graphics/chromium/UniscribeHelper.cpp:
277         (WebCore::UniscribeHelper::draw):
278         * platform/graphics/skia/PlatformContextSkia.cpp:
279         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
280         * platform/graphics/skia/PlatformContextSkia.h:
281         * platform/graphics/skia/SkiaFontWin.cpp:
282         (WebCore::windowsCanHandleDrawTextShadow):
283         (WebCore::windowsCanHandleTextDrawing):
284         (WebCore::windowsCanHandleTextDrawingWithoutShadow):
285         * platform/graphics/skia/SkiaFontWin.h:
286
287 2011-07-26  Adrienne Walker  <enne@google.com>
288
289         Unreviewed, rolling out r91812.
290         http://trac.webkit.org/changeset/91812
291         https://bugs.webkit.org/show_bug.cgi?id=65210
292
293         Breaks OSX GPU tests.
294
295         * platform/graphics/chromium/LayerRendererChromium.cpp:
296         (WebCore::LayerRendererChromium::drawLayers):
297
298 2011-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
299
300         Unreviewed, rolling out r91809.
301         http://trac.webkit.org/changeset/91809
302         https://bugs.webkit.org/show_bug.cgi?id=65225
303
304         Does not build on Chromium Windows (Requested by abarth on
305         #webkit).
306
307         * dom/WheelEvent.cpp:
308         (WebCore::WheelEvent::WheelEvent):
309         (WebCore::WheelEvent::initWheelEvent):
310         * dom/WheelEvent.h:
311         * page/EventHandler.cpp:
312         (WebCore::EventHandler::EventHandler):
313         (WebCore::EventHandler::handleGestureEvent):
314         (WebCore::EventHandler::handleTouchEvent):
315         (WebCore::EventHandler::resetGestureRecognizer):
316         * page/EventHandler.h:
317         * page/FrameView.cpp:
318         (WebCore::FrameView::reset):
319         * platform/PlatformGestureEvent.h:
320         * platform/PlatformGestureRecognizer.h:
321         * platform/chromium/FramelessScrollView.h:
322         * platform/chromium/GestureRecognizerChromium.cpp:
323         (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
324         (WebCore::InnerGestureRecognizer::reset):
325         (WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
326         (WebCore::InnerGestureRecognizer::processTouchEventForGesture):
327         (WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
328         (WebCore::touchDown):
329         (WebCore::noGesture):
330         (WebCore::click):
331         (WebCore::isClickOrScroll):
332         (WebCore::inScroll):
333         * platform/chromium/GestureRecognizerChromium.h:
334         (WebCore::GestureRecognizerChromium::reset):
335         (WebCore::GestureRecognizerChromium::processTouchEventForGesture):
336         * platform/chromium/PopupMenuChromium.cpp:
337         * platform/chromium/PopupMenuChromium.h:
338         * platform/mac/ScrollAnimatorMac.mm:
339         (WebCore::ScrollAnimatorMac::handleGestureEvent):
340
341 2011-07-26  Dmitry Lomov  <dslomov@google.com>
342
343         [V8][Chromium] Run workers in a separate v8::Isolate 
344         https://bugs.webkit.org/show_bug.cgi?id=65004
345         This patch allocates a new v8::Isolate for every worker and enters it on worker thread.
346
347         Reviewed by David Levin.
348
349         Covered by existing chromium tests.
350
351         * bindings/v8/DOMDataStore.cpp:
352         (WebCore::DOMDataStore::DOMDataStore):
353         (WebCore::DOMDataStore::~DOMDataStore):
354         * bindings/v8/StaticDOMDataStore.cpp:
355         (WebCore::StaticDOMDataStore::StaticDOMDataStore):
356         (WebCore::StaticDOMDataStore::~StaticDOMDataStore):
357         * bindings/v8/StaticDOMDataStore.h:
358         * bindings/v8/V8Binding.h:
359         (WebCore::V8BindingPerIsolateData::registerDOMDataStore):
360         (WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):
361         * bindings/v8/V8DOMMap.cpp:
362         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
363         (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
364         * bindings/v8/WorkerContextExecutionProxy.cpp:
365         (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
366         (WebCore::WorkerContextExecutionProxy::initV8):
367         * bindings/v8/WorkerContextExecutionProxy.h:
368         * bindings/v8/WorkerScriptController.cpp:
369         (WebCore::WorkerScriptController::WorkerScriptController):
370         (WebCore::WorkerScriptController::~WorkerScriptController):
371         * bindings/v8/WorkerScriptController.h:
372
373 2011-07-26  James Robinson  <jamesr@chromium.org>
374
375         [chromium] Avoid clearing the framebuffer when compositing in release builds
376         https://bugs.webkit.org/show_bug.cgi?id=65210
377
378         Reviewed by Kenneth Russell.
379
380         We clear the default framebuffer to blue when compositing so it's
381         easier to spot regions we miss. This is useful for debugging, but eats
382         bandwidth unnecessarily in release builds.
383
384         * platform/graphics/chromium/LayerRendererChromium.cpp:
385         (WebCore::LayerRendererChromium::drawLayers):
386
387 2011-07-26  Jeffrey Pfau  <jpfau@apple.com>
388
389         New XML tokenizer
390         https://bugs.webkit.org/show_bug.cgi?id=64566
391
392         Reviewed by Adam Barth.
393
394         Add tokenizer for XML and tests in NewXMLDocumentParser for printing results of tokenization.
395
396         * GNUmakefile.list.am:
397         * WebCore.gypi:
398         * WebCore.pro:
399         * WebCore.vcproj/WebCore.vcproj:
400         * WebCore.xcodeproj/project.pbxproj:
401         * xml/parser/NewXMLDocumentParser.cpp:
402         (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
403         (WebCore::NewXMLDocumentParser::append):
404         * xml/parser/NewXMLDocumentParser.h:
405         * xml/parser/XMLToken.h:
406         * xml/parser/XMLTokenizer.cpp: Added.
407         (WebCore::XMLTokenizer::XMLTokenizer):
408         (WebCore::::shouldSkipNullCharacters):
409         (WebCore::XMLTokenizer::nextToken):
410         (WebCore::XMLTokenizer::bufferCharacter):
411         (WebCore::XMLTokenizer::parseError):
412         * xml/parser/XMLTokenizer.h: Added.
413         (WebCore::XMLTokenizer::create):
414         (WebCore::XMLTokenizer::gotError):
415         (WebCore::XMLTokenizer::shouldSkipNullCharacters):
416
417 2011-07-26  Robert Kroeger  <rjkroege@chromium.org>
418
419         [chromium] Layering violations in gesture recognizer
420         https://bugs.webkit.org/show_bug.cgi?id=65044
421
422         Reviewed by Adam Barth.
423
424         Divided the gesture recognizer up to correct a layering
425         violation by moving gesture implementation from it to
426         EventHandler::handleGestureEvent so that the gesture recognizer
427         could simply be an engine for generating gesture events from
428         touch events.
429
430         * page/EventHandler.cpp:
431         (WebCore::EventHandler::EventHandler):
432         Removed construction of gesture recognizer.
433         (WebCore::EventHandler::handleGestureEvent):
434         Extended for new gesture events added in this patch.
435         (WebCore::EventHandler::handleTouchEvent):
436         Removed call into gesture recognizer.
437         * page/EventHandler.h:
438         * page/FrameView.cpp:
439         (WebCore::FrameView::reset):
440         Removed code to reset gesture recognizer.
441         * platform/PlatformGestureEvent.h:
442         (WebCore::PlatformGestureEvent::PlatformGestureEvent):
443         (WebCore::PlatformGestureEvent::deltaX):
444         (WebCore::PlatformGestureEvent::deltaY):
445         (WebCore::PlatformGestureEvent::shiftKey):
446         (WebCore::PlatformGestureEvent::ctrlKey):
447         (WebCore::PlatformGestureEvent::altKey):
448         (WebCore::PlatformGestureEvent::metaKey):
449         Added additional gesture types and parameters.
450         * platform/PlatformGestureRecognizer.h:
451         * platform/chromium/FramelessScrollView.h:
452         Added support for displatching gesture and touch events.
453         * platform/chromium/GestureRecognizerChromium.cpp:
454         (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
455         (WebCore::InnerGestureRecognizer::reset):
456         (WebCore::InnerGestureRecognizer::constructClickGestureEvent):
457         (WebCore::InnerGestureRecognizer::processTouchEventForGestures):
458         Removed all depedencies on EventHandler. Instead, create gesture
459         events from touch event stream.
460         (WebCore::InnerGestureRecognizer::constructScrollGesture):
461         (WebCore::touchDown):
462         (WebCore::noGesture):
463         (WebCore::click):
464         (WebCore::isClickOrScroll):
465         (WebCore::inScroll):
466         (WebCore::GestureRecognizerChromium::processTouchEventForGestures):
467         (WebCore::GestureRecognizerChromium::reset):
468         * platform/chromium/GestureRecognizerChromium.h:
469         * platform/chromium/PopupMenuChromium.cpp:
470         Added support to handle touch events and gesture events.
471         (WebCore::PopupContainer::handleTouchEvent):
472         (WebCore::PopupContainer::handleGestureEvent):
473         (WebCore::PopupListBox::handleTouchEvent):
474         (WebCore::PopupListBox::handleGestureEvent):
475         * platform/chromium/PopupMenuChromium.h:
476         * platform/mac/ScrollAnimatorMac.mm:
477         (WebCore::ScrollAnimatorMac::handleGestureEvent):
478         Ignores the newly added gesture event types.
479
480 2011-07-26  Joseph Pecoraro  <joepeck@webkit.org>
481
482         Restore Composited Layers Faster from PageCache
483         https://bugs.webkit.org/show_bug.cgi?id=65216
484
485         Reviewed by Simon Fraser.
486
487         Restore the layer tree hierarchy a little sooner, when
488         restoring from the page cache. This more closely matches
489         original restore behavior.
490
491         Existing test showed no change.
492
493         * page/FrameView.cpp:
494         (WebCore::FrameView::restoreBackingStores):
495
496 2011-07-26  Mike Reed  <reed@google.com>
497
498         [skia] never draw with GDI, so that all text can be gpu-accelerated
499         https://bugs.webkit.org/show_bug.cgi?id=65203
500
501         Reviewed by Kenneth Russell.
502
503         No new tests. existing tests apply to the new drawing path
504
505         * platform/graphics/chromium/FontChromiumWin.cpp:
506         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
507         * platform/graphics/skia/SkiaFontWin.cpp:
508         (WebCore::windowsCanHandleDrawTextShadow):
509         (WebCore::windowsCanHandleTextDrawing):
510         (WebCore::windowsCanHandleTextDrawingWithoutShadow):
511
512 2011-07-26  Kenneth Russell  <kbr@google.com>
513
514         Float32Array(ArrayBuffer, index, length) constructor working incorrectly.
515         https://bugs.webkit.org/show_bug.cgi?id=57042
516
517         Reviewed by James Robinson.
518
519         * bindings/js/JSArrayBufferViewHelper.h:
520         (WebCore::constructArrayBufferViewWithArrayBufferArgument):
521         * bindings/v8/custom/V8ArrayBufferViewCustom.h:
522         (WebCore::constructWebGLArrayWithArrayBufferArgument):
523
524 2011-07-26  Chris Rogers  <crogers@google.com>
525
526         V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
527         https://bugs.webkit.org/show_bug.cgi?id=65222
528
529         Reviewed by James Robinson.
530
531         No new tests - this fixes upcoming audionode.html layout test
532
533         * bindings/v8/custom/V8AudioNodeCustom.cpp:
534         (WebCore::V8AudioNode::connectCallback):
535
536 2011-07-26  Chris Rogers  <crogers@google.com>
537
538         AudioContext is not correctly accounting for hardware resources
539         https://bugs.webkit.org/show_bug.cgi?id=65217
540
541         Reviewed by Kenneth Russell.
542
543         No new tests since audio API is not yet implemented.
544
545         * webaudio/AudioContext.cpp:
546         (WebCore::AudioContext::create):
547         (WebCore::AudioContext::AudioContext):
548         (WebCore::AudioContext::lazyInitialize):
549
550 2011-07-26  Luke Macpherson   <macpherson@chromium.org>
551
552         Handle CSS Properties that can be either auto or a primitive value in CSSStyleApplyProperty
553         https://bugs.webkit.org/show_bug.cgi?id=65164
554
555         Reviewed by Dimitri Glazkov.
556
557         No new tests / refactoring only.
558
559         * css/CSSPrimitiveValueMappings.h:
560         Add casts to/from various numeric types.
561         (WebCore::CSSPrimitiveValue::operator short):
562         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
563         (WebCore::CSSPrimitiveValue::operator unsigned short):
564         (WebCore::CSSPrimitiveValue::operator int):
565         (WebCore::CSSPrimitiveValue::operator float):
566         * css/CSSStyleApplyProperty.cpp:
567         Add class to handle properties that set an "auto" boolean on RenderStyle.
568         (WebCore::ApplyPropertyAuto::ApplyPropertyAuto):
569         (WebCore::ApplyPropertyAuto::applyInheritValue):
570         (WebCore::ApplyPropertyAuto::applyInitialValue):
571         (WebCore::ApplyPropertyAuto::applyValue):
572         (WebCore::ApplyPropertyAuto::hasAuto):
573         (WebCore::ApplyPropertyAuto::setAuto):
574         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
575         * css/CSSStyleSelector.cpp:
576         Remove existing implementations.
577         (WebCore::CSSStyleSelector::applyProperty):
578
579 2011-07-26  Pratik Solanki  <psolanki@apple.com>
580
581         Add protection space authentication callback code to CFNetwork loader on Mac
582         https://bugs.webkit.org/show_bug.cgi?id=65190
583         <rdar://problem/9842424>
584
585         Reviewed by Oliver Hunt.
586
587         Port over protection space authentication callback code from ResourceHandleMac.mm to
588         ResourceHandleCFNet.cpp.
589
590         * platform/network/ResourceHandle.h:
591         * platform/network/cf/ResourceHandleCFNet.cpp:
592         (WebCore::canRespondToProtectionSpace):
593         (WebCore::ResourceHandle::createCFURLConnection):
594         (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
595         (WebCore::WebCoreSynchronousLoaderClient::canAuthenticateAgainstProtectionSpace):
596         * platform/network/mac/ResourceHandleMac.mm:
597         (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Add logging.
598
599 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
600
601         Add support for download='filename' attribute in anchors.
602         https://bugs.webkit.org/show_bug.cgi?id=64580
603
604         Reviewed by Adam Barth.
605
606         The download attribute allows the author of the hyperlink to cause the
607         browser to download the linked URL.  The author can also supply a
608         suggested file name in the attribute value.  This feature is a recent
609         addition to HTML to better support offline applications that use blob
610         URLs.  Traditionally, web sites use the HTTP Content-Disposition header
611         to trigger downloads, but that option isn't available when working
612         offline.
613
614         There is some question about whether we should initiate a download when
615         we receive a DOM-created click event.  This patch does initiate the
616         download, but we might revise that decision in the future as part of a
617         larger change in how WebKit treats the interaction between default
618         event handlers and DOM-created events.
619
620         Tests: fast/dom/HTMLAnchorElement/anchor-download.html
621                fast/dom/HTMLAnchorElement/anchor-nodownload.html
622                fast/dom/HTMLAnchorElement/anchor-download-unset.html
623                fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
624
625         * html/HTMLAnchorElement.cpp:
626         (WebCore::HTMLAnchorElement::defaultEventHandler):
627         (WebCore::HTMLAnchorElement::handleClick):
628         * html/HTMLAnchorElement.h:
629         * html/HTMLAnchorElement.idl:
630         * html/HTMLAttributeNames.in:
631         * loader/EmptyClients.h:
632         (WebCore::EmptyFrameLoaderClient::startDownload):
633         * loader/FrameLoaderClient.h:
634
635 2011-07-26  Mark Hahnenberg  <mhahnenberg@apple.com>
636
637         Refactor automatically generated JS DOM bindings to replace operator new with static create methods
638         https://bugs.webkit.org/show_bug.cgi?id=64732
639
640         Reviewed by Oliver Hunt.
641
642         No new tests.
643
644         Replacing the public constructors in the automatically generated JS DOM bindings in CodeGeneratorJS.pm
645         with static create methods.  This is part of a larger refactoring effort to use static create methods
646         in the headers of the generated files (so as to be inline-able) in favor of public constructors throughout JSC.
647
648         * bindings/js/JSAudioConstructor.h:
649         (WebCore::JSAudioConstructor::create):
650         * bindings/js/JSDOMBinding.h:
651         (WebCore::createWrapper):
652         * bindings/js/JSDOMGlobalObject.h:
653         (WebCore::getDOMConstructor):
654         * bindings/js/JSDOMWindowCustom.cpp:
655         (WebCore::JSDOMWindow::history):
656         (WebCore::JSDOMWindow::location):
657         * bindings/js/JSDOMWindowShell.cpp:
658         (WebCore::JSDOMWindowShell::setWindow):
659         * bindings/js/JSDocumentCustom.cpp:
660         (WebCore::JSDocument::location):
661         * bindings/js/JSImageConstructor.h:
662         (WebCore::JSImageConstructor::create):
663         * bindings/js/JSImageDataCustom.cpp:
664         (WebCore::toJS):
665         * bindings/js/JSOptionConstructor.h:
666         (WebCore::JSOptionConstructor::create):
667         * bindings/js/WorkerScriptController.cpp:
668         (WebCore::WorkerScriptController::initScript):
669         * bindings/scripts/CodeGeneratorJS.pm:
670         (AddIncludesForTypeInImpl):
671         (AddIncludesForTypeInHeader):
672         (AddIncludesForType):
673         (GenerateHeader):
674         (GenerateImplementation):
675         (GenerateCallbackImplementation):
676         (GenerateConstructorDeclaration):
677         * bindings/scripts/test/JS/JSTestInterface.cpp:
678         (WebCore::JSTestInterfaceConstructor::create):
679         (WebCore::JSTestInterface::createPrototype):
680         * bindings/scripts/test/JS/JSTestInterface.h:
681         (WebCore::JSTestInterface::create):
682         (WebCore::JSTestInterfacePrototype::create):
683         * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
684         (WebCore::JSTestMediaQueryListListenerConstructor::create):
685         (WebCore::JSTestMediaQueryListListener::createPrototype):
686         * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
687         (WebCore::JSTestMediaQueryListListener::create):
688         (WebCore::JSTestMediaQueryListListenerPrototype::create):
689         * bindings/scripts/test/JS/JSTestObj.cpp:
690         (WebCore::JSTestObjConstructor::create):
691         (WebCore::JSTestObj::createPrototype):
692         * bindings/scripts/test/JS/JSTestObj.h:
693         (WebCore::JSTestObj::create):
694         (WebCore::JSTestObjPrototype::create):
695         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
696         (WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
697         (WebCore::JSTestSerializedScriptValueInterface::createPrototype):
698         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
699         (WebCore::JSTestSerializedScriptValueInterface::create):
700         (WebCore::JSTestSerializedScriptValueInterfacePrototype::create):
701         * bridge/jni/jsc/JavaArrayJSC.cpp:
702         (JavaArray::convertJObjectToArray):
703         * bridge/jsc/BridgeJSC.cpp:
704         (JSC::Bindings::Instance::newRuntimeObject):
705         * bridge/objc/objc_utility.mm:
706         (JSC::Bindings::convertObjcValueToValue):
707         * bridge/qt/qt_runtime.cpp:
708         (JSC::Bindings::convertQVariantToValue):
709         * bridge/runtime_array.h:
710         (JSC::RuntimeArray::create):
711         * bridge/runtime_object.h:
712         (JSC::Bindings::RuntimeObject::create):
713
714 2011-07-26  Xiaomei Ji  <xji@chromium.org>
715
716         --webkit-visual-word does not work in multi-line
717         https://bugs.webkit.org/show_bug.cgi?id=61344
718
719         Reviewed by Ryosuke Niwa.
720
721         Replace Position(node, offset, PositionIsOffsetInAnchor) with 
722         createPositionAvoidingIgnoredNode(node, offset) which takes care of creating position 
723         before/after <br/> etc. editingIgnoresContent node. 
724
725         When iterate InlineBox, replace prevLeafChild and nextLeafChild (which only returns 
726         InlineBox within the same line) with leftInlineBox and rightInlineBox (which returns 
727         InlineBox across multiple lines).
728
729         * editing/htmlediting.cpp:
730         (WebCore::createPositionAvoidingIgnoredNode):
731         * editing/htmlediting.h:
732         * editing/visible_units.cpp:
733         (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): Replace Position() with
734         createPositionAvoidingIgnoredNode().
735         (WebCore::leftmostPositionInRTLBoxInLTRBlock): Ditto.
736         (WebCore::rightmostPositionInLTRBoxInRTLBlock): Ditto.
737         (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): Ditto.
738         (WebCore::blockWithPreviousLineBox): Added.
739         (WebCore::previousRootInlineBox): Added.
740         (WebCore::blockWithNextLineBox): Added.
741         (WebCore::nextRootInlineBox): Added.
742         (WebCore::leftInlineBox): Added.
743         (WebCore::rightInlineBox): Added.
744         (WebCore::leftWordBoundary): Replace prevLeafChild/nextLeafChild with leftInlineBox()
745         and rightInlineBox().
746         (WebCore::rightWordBoundary): Ditto.
747         (WebCore::leftWordPositionAcrossBoundary): Ditto.
748         (WebCore::rightWordPositionAcrossBoundary): Ditto.
749
750 2011-07-26  David Hyatt  <hyatt@apple.com>
751
752         https://bugs.webkit.org/show_bug.cgi?id=60778
753
754         Use after free because of line box culling optimization regression.
755
756         In the case of a child with no line box being removed (typically
757         a <br> in quirks mode), if there is no previous sibling with a line
758         box, then we have a potential problem with the culling optimization.
759
760         The culled inline may still have other leaf line box children, but
761         they may follow the removed <br>. In this case we can't rely on
762         them, since we need a line box that comes before the <br>.
763
764         The fix is to simply recur up to the parent if we are a culled inline
765         and could not find a previous line box.
766
767         Reviewed by Dan Bernstein.
768
769         Added editing/execCommand/crash-line-break-after-outdent.html
770
771         * rendering/RenderLineBoxList.cpp:
772         (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
773
774 2011-07-26  Dan Bernstein  <mitz@apple.com>
775
776         <rdar://problem/9842889> Add a generic pictograph font family
777         https://bugs.webkit.org/show_bug.cgi?id=65197
778
779         Reviewed by Anders Carlsson.
780
781         Test: fast/css/font-family-pictograph.html
782
783         * WebCore.exp.in: Export Settings::setPictographFontFamily().
784         * css/CSSComputedStyleDeclaration.cpp:
785         (WebCore::identifierForFamily): Added -webkit-pictograph.
786         * css/CSSFontSelector.cpp:
787         (WebCore::CSSFontSelector::addFontFaceRule): Ditto.
788         (WebCore::fontDataForGenericFamily): Ditto.
789         * css/CSSStyleSelector.cpp:
790         (WebCore::CSSStyleSelector::applyProperty): Ditto.
791         * css/CSSValueKeywords.in:
792         * inspector/front-end/CSSKeywordCompletions.js: Ditto.
793         * inspector/front-end/SourceCSSTokenizer.js: Ditto.
794         (WebInspector.SourceCSSTokenizer):
795         * inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
796         * page/Settings.cpp:
797         (WebCore::Settings::pictographFontFamily): Added this getter.
798         (WebCore::Settings::setPictographFontFamily): Added this setter.
799         * page/Settings.h:
800         * platform/graphics/FontDescription.h: Added PictographFamily to the GenericFamilyType enum.
801
802 2011-07-26  Viet-Trung Luu  <viettrungluu@chromium.org>
803
804         Improve (i.e., speed up) .gyp(i) files for Chromium
805         https://bugs.webkit.org/show_bug.cgi?id=65032
806
807         Reviewed by Adam Barth.
808
809         This re-applies r91595 with the source exclusion fixed.
810
811         Test by building (in all supported configurations).
812
813         * WebCore.gyp/WebCore.gyp:
814         * WebCore.gypi:
815
816 2011-07-26  Alexis Menard  <alexis.menard@openbossa.org>
817
818         [Qt] Disable video support on linux if the dependencies are not found.
819
820         If we can't find the necessary dependencies to build the GStreamer media player
821         we disable the video support. This is related to http://trac.webkit.org/changeset/91752.
822
823         Reviewed by Holger Freyther.
824
825         No new tests, it's a build fix.
826
827         * features.pri:
828
829 2011-07-26  Evan Martin  <evan@chromium.org>
830
831         regression: generating CSSValueKeywords should not print by default
832         https://bugs.webkit.org/show_bug.cgi?id=65195
833
834         Reviewed by Tony Chang.
835
836         Some refactoring made some callers no longer pass the final 'beQuiet'
837         parameter to applyPreprocessor.  This flag was only used to print the
838         input filename anyway, so remove the flag and just make the caller
839         print the filename if it wants this.
840
841         * bindings/scripts/IDLParser.pm:
842         (Parse): print before calling applyPreprocessor, if necessary.
843         * bindings/scripts/preprocessor.pm:
844         (applyPreprocessor): remove the beQuiet flag; just always be quiet.
845
846 2011-07-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
847
848         [EFL] Do not crash on the isSlider() assert.
849         https://bugs.webkit.org/show_bug.cgi?id=65191
850
851         Reviewed by Antonio Gomes.
852
853         RenderThemeEfl's paintSliderThumb() just forwarded the call to
854         paintSliderTrack(), which, on its turn, called code that assumed that
855         object->isSlider() was true. That does not seem to be the case for
856         slidethumbs, so any page with an <input type="range"> tag would crash
857         WebKit.
858
859         We now do what RenderThemeQt does, and assume everything was properly
860         done in the call to paintSliderTrack().
861
862         No new tests, as this has been uncovered by an existing test.
863
864         * platform/efl/RenderThemeEfl.cpp:
865         (WebCore::RenderThemeEfl::paintSliderThumb):
866
867 2011-07-26  Brian Salomon  <bsalomon@google.com>
868
869         [SKIA] Make the skia GL context current when drawing text to gpu backed platform context.
870         https://bugs.webkit.org/show_bug.cgi?id=65182
871
872         Reviewed by Stephen White.
873
874         No new tests. Not sure how to test wrong-ctx bugs in layout tests.
875
876         * platform/graphics/skia/SkiaFontWin.cpp:
877         (WebCore::paintSkiaText):
878
879 2011-07-26  Emil A Eklund  <eae@chromium.org>
880
881         RenderText::absoluteRectsForRange() and absoluteQuadsForRange() have nearly duplicate code
882         https://bugs.webkit.org/show_bug.cgi?id=62478
883
884         Reviewed by Simon Fraser.
885
886         Test: fast/dom/Range/getClientRects.html
887
888         * platform/graphics/FloatRect.h:
889         (WebCore::FloatRect::isZero):
890         Add izZero method, unlike isEmpty this checks if both the width and the
891         height are zero.
892
893         * rendering/RenderText.cpp:
894         (WebCore::absoluteQuadForTextBox):
895         (WebCore::RenderText::absoluteRectsForRange):
896         (WebCore::RenderText::absoluteQuadsForRange):
897         Break duplicate code out of absoluteRectsForRange and
898         absoluteQuadsForRange into shared static function.
899         
900         Fix what I presume to be a bug in the absoluteQuadsForRange where the
901         logicalHeight was always used to set the size in absoluteQuadForTextBox
902         as oppsued to the absoluteRectsForRange implementation that uses the
903         logicalWidth or the logicalHeight depending on whether it's horizontal or
904         vertical.
905
906 2011-07-26  Alexandru Chiculita  <achicu@adobe.com>
907
908         [CSSRegions] Collect flowed elements in different render element
909         https://bugs.webkit.org/show_bug.cgi?id=64516
910
911         All the RenderObjects that have a specified "flow" name are moved out of the
912         normal flow. A RenderFlowThread will collect all such RenderObjects. There is
913         a RenderFlowThread for each flow name. The new RenderFlowThread is an anonymous
914         RenderBlock that is positioned absolute and will not render directly. In a
915         different bug/patch we will add RenderRegion that will take care of rendering the
916         RenderFlowThread on screen.
917
918         Reviewed by Simon Fraser.
919
920         Tests: fast/regions/webkit-flow-renderer-layer.html
921                fast/regions/webkit-flow-renderer-nested.html
922                fast/regions/webkit-flow-renderer.html
923
924         * WebCore.vcproj/WebCore.vcproj:
925         * WebCore.xcodeproj/project.pbxproj:
926         * dom/Node.cpp:
927         (WebCore::Node::diff):
928         * dom/NodeRenderingContext.cpp:
929         (WebCore::NodeRenderingContext::NodeRenderingContext):
930         (WebCore::NodeRenderingContext::setStyle):
931         (WebCore::NodeRenderingContext::nextRenderer):
932         (WebCore::NodeRenderingContext::previousRenderer):
933         (WebCore::NodeRenderingContext::parentRenderer):
934         (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
935         (WebCore::NodeRendererFactory::createRendererIfNeeded):
936         * dom/NodeRenderingContext.h:
937         (WebCore::NodeRenderingContext::hasFlowThreadParent):
938         (WebCore::NodeRenderingContext::parentFlowRenderer):
939         * rendering/RenderFlowThread.cpp: Added.
940         (WebCore::RenderFlowThread::RenderFlowThread):
941         (WebCore::RenderFlowThread::createFlowThreadStyle):
942         (WebCore::RenderFlowThread::nextRendererForNode):
943         (WebCore::RenderFlowThread::previousRendererForNode):
944         (WebCore::RenderFlowThread::addChild):
945         (WebCore::RenderFlowThread::removeChild):
946         * rendering/RenderFlowThread.h: Added.
947         (WebCore::toRenderFlowThread):
948         * rendering/RenderLayer.cpp:
949         (WebCore::RenderLayer::collectLayers):
950         * rendering/RenderObject.h:
951         (WebCore::RenderObject::isRenderFlowThread):
952         * rendering/RenderTreeAsText.cpp:
953         (WebCore::RenderTreeAsText::writeRenderObject):
954         (WebCore::writeLayers):
955         * rendering/RenderView.cpp:
956         (WebCore::RenderView::renderFlowThreadWithName):
957         * rendering/RenderView.h:
958         * rendering/style/RenderStyle.cpp:
959         (WebCore::RenderStyle::diff):
960
961 2011-07-26  Patrick Dubroy  <dubroy@chromium.org>
962
963         Filename text in file upload controls is not aligned with button text on
964         chromium-linux, chromium-win, and gtk.
965
966         https://bugs.webkit.org/show_bug.cgi?id=64692
967
968         The fix is to not include the margin, border, and padding in the calculation,
969         because those are already accounted for by RenderBlock::baselinePosition().
970
971         Reviewed by Dimitri Glazkov.
972
973         * rendering/RenderFileUploadControl.cpp:
974         (WebCore::RenderFileUploadControl::paintObject):
975
976 2011-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
977
978         Unreviewed, rolling out r91746.
979         http://trac.webkit.org/changeset/91746
980         https://bugs.webkit.org/show_bug.cgi?id=65180
981
982         It broke SL build (Requested by Ossy on #webkit).
983
984         * dom/OptionElement.cpp:
985         (WebCore::OptionElement::normalizeText):
986
987 2011-07-26  Pavel Feldman  <pfeldman@google.com>
988
989         Web Inspector: Better represent custom getters in the properties pane
990         https://bugs.webkit.org/show_bug.cgi?id=16734
991
992         Reviewed by Yury Semikhatsky.
993
994         Test: inspector/runtime/runtime-getProperties.html
995
996         * inspector/InjectedScriptSource.js:
997         (.):
998         * inspector/Inspector.json:
999         * inspector/front-end/ObjectPropertiesSection.js:
1000         (WebInspector.ObjectPropertyTreeElement.prototype.update):
1001
1002 2011-07-26  Alexis Menard  <alexis.menard@openbossa.org>
1003
1004         Reviewed by Andreas Kling.
1005
1006         [Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
1007         https://bugs.webkit.org/show_bug.cgi?id=63472
1008
1009         Enable the GStreamer backend and the QuickTime backend as default media players
1010         for the Qt port on Mac and Linux. QtMultimedia is now a fallback option that you
1011         can enable by passing DEFINES+=USE_QT_MULTIMEDIA=1 to enforce its usage.
1012
1013         No new tests. The media layout tests are disabled on the Qt port but hopefully with this
1014         switch we can enable them again.
1015
1016         * WebCore.pri:
1017         * WebCore.pro:
1018         * features.pri:
1019
1020 2011-07-26  Pavel Feldman  <pfeldman@google.com>
1021
1022         Web Inspector: Implement setPropertyValue using evaluate and callFunctionOn
1023         https://bugs.webkit.org/show_bug.cgi?id=65112
1024
1025         Reviewed by Yury Semikhatsky.
1026
1027         Test: inspector/runtime/runtime-setPropertyValue.html
1028
1029         * inspector/InjectedScript.cpp:
1030         * inspector/InjectedScript.h:
1031         * inspector/InjectedScriptSource.js:
1032         (.):
1033         * inspector/Inspector.json:
1034         * inspector/InspectorRuntimeAgent.cpp:
1035         * inspector/InspectorRuntimeAgent.h:
1036         * inspector/front-end/RemoteObject.js:
1037         (WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback.setPropertyValue):
1038         (WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback):
1039         (WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
1040         (WebInspector.RemoteObject.prototype.setPropertyValue):
1041
1042 2011-07-26  Pavel Feldman  <pfeldman@google.com>
1043
1044         Re-applying r91665 and r91668 with JSC issues fixed.
1045
1046         Web Inspector: use dedicated type for object id in the protocol.
1047         Web Inspector: refactor remote object structure to contain value for primitive values.
1048
1049         https://bugs.webkit.org/show_bug.cgi?id=65103
1050         https://bugs.webkit.org/show_bug.cgi?id=65110
1051
1052         Reviewed by Yury Semikhatsky.
1053
1054         * inspector/InjectedScript.cpp:
1055         (WebCore::InjectedScript::callFunctionOn):
1056         * inspector/InjectedScript.h:
1057         * inspector/InjectedScriptSource.js:
1058         * inspector/Inspector.json:
1059         * inspector/InspectorRuntimeAgent.cpp:
1060         (WebCore::InspectorRuntimeAgent::callFunctionOn):
1061         * inspector/InspectorValues.cpp:
1062         (WebCore::InspectorBasicValue::writeJSON):
1063         * inspector/front-end/ConsoleView.js:
1064         (WebInspector.ConsoleView.prototype._format):
1065         (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
1066         (WebInspector.ConsoleMessage.prototype._format):
1067         * inspector/front-end/ElementsTreeOutline.js:
1068         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
1069         * inspector/front-end/ObjectPropertiesSection.js:
1070         (WebInspector.ObjectPropertyTreeElement.prototype.update):
1071         * inspector/front-end/PropertiesSidebarPane.js:
1072         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
1073         * inspector/front-end/RemoteObject.js:
1074         (WebInspector.RemoteObject):
1075         (WebInspector.RemoteObject.fromPrimitiveValue):
1076         (WebInspector.RemoteObject.fromPayload):
1077         (WebInspector.RemoteObject.prototype.get subtype):
1078         (WebInspector.RemoteObject.prototype.callFunction):
1079         (WebInspector.LocalJSONObject.prototype.get description):
1080         (WebInspector.LocalJSONObject.prototype.get type):
1081         (WebInspector.LocalJSONObject.prototype.get subtype):
1082         * inspector/front-end/SourceFrame.js:
1083         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
1084         (WebInspector.SourceFrame.prototype._showPopup):
1085         * inspector/front-end/inspector.js:
1086         (WebInspector.log.logMessage):
1087         (WebInspector.log):
1088         (WebInspector.inspect):
1089
1090 2011-07-26  Nikolas Zimmermann  <nzimmermann@rim.com>
1091
1092         Prepare animVal support - phase 2
1093         https://bugs.webkit.org/show_bug.cgi?id=65167
1094
1095         Reviewed by Dirk Schulze.
1096
1097         Next patch preparing animVal support. Modify the SVGAnimatedProperty* classes & macros to assure that calling someElement->someProperty()
1098         will return the animVal, when the property is being animated. Not yet hooked into SVGAnimateElement, this is just a preparation.
1099
1100         Doesn't affect any tests, yet.
1101
1102         * svg/SVGPathElement.cpp: Adapt to SVGAnimatedProperty::lookupWrapper changes (new template parameters have been added).
1103         (WebCore::SVGPathElement::svgAttributeChanged):
1104         * svg/SVGPathSegWithContext.h: Ditto.
1105         (WebCore::SVGPathSegWithContext::animatedProperty):
1106         * svg/SVGPolyElement.cpp: Ditto.
1107         (WebCore::SVGPolyElement::parseMappedAttribute):
1108         * svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Implement currentAnimatedValue, an abstract way to retrieve the underlying animated value for any animated type.
1109         (WebCore::SVGAnimatedEnumerationPropertyTearOff::currentAnimatedValue): Forward call to SVGAnimatedStaticPropertyTearOff<int>, our base.
1110         * svg/properties/SVGAnimatedListPropertyTearOff.h:
1111         (WebCore::SVGAnimatedListPropertyTearOff::isAnimating): Returns whether this property is being animated or not.
1112         (WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
1113         * svg/properties/SVGAnimatedProperty.h:
1114         (WebCore::SVGAnimatedProperty::updateAnimVal): Will be used from SVGAnim*Element to update the current animVal, exposed to JS.
1115         (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper): Share more code with lookupWrapper.
1116         (WebCore::SVGAnimatedProperty::lookupWrapper): Cleanup code, avoid doing any work for non-SVGElement derived objects, like SVGViewSpec.
1117         * svg/properties/SVGAnimatedPropertyMacros.h: Make all lowerProperty() calls (eg. myRectElement->x()) return the animVal, if the property is being animated.
1118         * svg/properties/SVGAnimatedPropertyTearOff.h: Main logic for the new animVal stuff.
1119         (WebCore::SVGAnimatedPropertyTearOff::isAnimating):
1120         (WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue):
1121         (WebCore::SVGAnimatedPropertyTearOff::updateAnimVal):
1122         (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):
1123         * svg/properties/SVGAnimatedStaticPropertyTearOff.h:
1124         (WebCore::SVGAnimatedStaticPropertyTearOff::isAnimating):
1125         (WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
1126         * svg/properties/SVGPropertyTearOff.h:
1127         (WebCore::SVGPropertyTearOff::updateAnimVal):
1128
1129 2011-07-26  Shinya Kawanaka  <shinyak@google.com>
1130
1131         Uses isHTMLSpace to normalize white spaces.
1132         https://bugs.webkit.org/show_bug.cgi?id=57746
1133
1134         Reviewed by Kent Tamura.
1135
1136         Test: fast/forms/option-strip-unicode-spaces.html
1137
1138         * dom/OptionElement.cpp:
1139         (WebCore::OptionElement::normalizeText):
1140           Uses isHTMLSpace to trim and replace white spaces.
1141
1142 2011-07-25  Ryuan Choi  <ryuan.choi@samsung.com>
1143
1144         [CMAKE] Split JSC related files from WebCore/CMakeLists.txt
1145         https://bugs.webkit.org/show_bug.cgi?id=61350
1146
1147         Reviewed by Daniel Bates.
1148
1149         No new tests, just moving jsc related files from CMakeLists.txt to UseJSC.cmake.
1150
1151         * CMakeLists.txt:
1152         * UseJSC.cmake:
1153
1154 2011-07-25  Dan Bernstein  <mitz@apple.com>
1155
1156         Fix the build by committing a rename in this file that I neglected to include in the previous commit.
1157
1158         * css/CSSFontFaceSource.h:
1159
1160 2011-07-25  Dan Bernstein  <mitz@apple.com>
1161
1162         <rdar://problem/9835028> Font loading during layout can cause layout code to be re-entered via resource load delegate
1163         https://bugs.webkit.org/show_bug.cgi?id=65123
1164
1165         Reviewed by Anders Carlsson and Darin Adler.
1166
1167         Since CSSFontFaceSource::getFontData() can get called during layout, avoid calling out to loader
1168         code from under it, and instead defer that work using a zero-delay timer.
1169
1170         * css/CSSFontFaceSource.cpp:
1171         (WebCore::CSSFontFaceSource::CSSFontFaceSource):
1172         (WebCore::CSSFontFaceSource::~CSSFontFaceSource):
1173         (WebCore::CSSFontFaceSource::getFontData): Rather than starting the font load here, schedule
1174         a zero-delay timer to do it.
1175         (WebCore::CSSFontFaceSource::startLoadingTimerFired): Added. Starts loading the font if needed.
1176         * css/CSSFontFaceSource.h:
1177
1178 2011-07-25  Al Patrick  <apatrick@chromium.org>
1179
1180         Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
1181         Replaced calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.
1182         https://bugs.webkit.org/show_bug.cgi?id=65043
1183
1184         Reviewed by James Robinson.
1185
1186         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
1187         (WebCore::Canvas2DLayerChromium::updateCompositorResources):
1188         * platform/graphics/chromium/DrawingBufferChromium.cpp:
1189         (WebCore::DrawingBuffer::publishToPlatformLayer):
1190         * platform/graphics/chromium/Extensions3DChromium.h:
1191         * platform/graphics/chromium/LayerRendererChromium.cpp:
1192         (WebCore::LayerRendererChromium::LayerRendererChromium):
1193         (WebCore::LayerRendererChromium::drawLayers):
1194         (WebCore::LayerRendererChromium::addChildContext):
1195         (WebCore::LayerRendererChromium::removeChildContext):
1196         * platform/graphics/chromium/LayerRendererChromium.h:
1197
1198 2011-07-25  Sam Weinig  <sam@webkit.org>
1199
1200         Refactor ScrollableArea pinned predicates to be more generally useful
1201         <rdar://problem/9740379>
1202
1203         Reviewed by Dan Bernstein.
1204
1205         * platform/ScrollableArea.cpp:
1206         (WebCore::ScrollableArea::isPinnedInBothDirections):
1207         (WebCore::ScrollableArea::isPinnedHorizontallyInDirection):
1208         (WebCore::ScrollableArea::isPinnedVerticallyInDirection):
1209         * platform/ScrollableArea.h:
1210
1211 2011-07-25  Nico Weber  <thakis@chromium.org>
1212
1213         [chromium] components/mac: Make webcore not depend on CoreAnimation
1214         https://bugs.webkit.org/show_bug.cgi?id=65143
1215
1216         Reviewed by James Robinson.
1217
1218         * platform/chromium/ScrollAnimatorChromiumMac.mm:
1219
1220 2011-07-25  Ian Henderson  <ianh@apple.com>
1221
1222         WebFrame should have a method to determine its visual emptiness
1223         https://bugs.webkit.org/show_bug.cgi?id=64223
1224
1225         Reviewed by Dan Bernstein.
1226
1227         * page/FrameView.h:
1228         (WebCore::FrameView::isVisuallyNonEmpty): Add an accessor to FrameView
1229         so we can tell whether it's visually non-empty.
1230
1231 2011-07-25  Scott Graham  <scottmg@chromium.org>
1232
1233         REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
1234         https://bugs.webkit.org/show_bug.cgi?id=61006
1235
1236         Reviewed by Nate Chapin.
1237
1238         Rollback previous patch. Occasional crashes seen caused by
1239         CachedResource being deleted twice.
1240
1241         * loader/cache/CachedResourceLoader.cpp:
1242         (WebCore::CachedResourceLoader::CachedResourceLoader):
1243         (WebCore::CachedResourceLoader::loadDone):
1244         * loader/cache/CachedResourceLoader.h:
1245
1246 2011-07-25  Chris Rogers  <crogers@google.com>
1247
1248         Deprecate AudioBufferSourceNode .looping attribute and implement .loop
1249         https://bugs.webkit.org/show_bug.cgi?id=65133
1250
1251         Reviewed by Kenneth Russell.
1252
1253         No new tests since audio API is not yet implemented.
1254
1255         * webaudio/AudioBufferSourceNode.cpp:
1256         (WebCore::AudioBufferSourceNode::renderFromBuffer):
1257         (WebCore::AudioBufferSourceNode::totalPitchRate):
1258         (WebCore::AudioBufferSourceNode::looping):
1259         (WebCore::AudioBufferSourceNode::setLooping):
1260         * webaudio/AudioBufferSourceNode.h:
1261         (WebCore::AudioBufferSourceNode::loop):
1262         (WebCore::AudioBufferSourceNode::setLoop):
1263         * webaudio/AudioBufferSourceNode.idl:
1264
1265 2011-07-25  James Robinson  <jamesr@chromium.org>
1266
1267         [chromium] HUD texture must be unreserved after drawing
1268         https://bugs.webkit.org/show_bug.cgi?id=65122
1269
1270         Unreserve the HUD texture after drawing.  To test, start chrome in debug with --show-fps-counter.  Since this is
1271         a debugging option, no tests.
1272
1273         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
1274         (WebCore::CCHeadsUpDisplay::draw):
1275
1276 2011-07-25  David Grogan  <dgrogan@chromium.org>
1277
1278         Fix leveldb crash when compacting during destruction
1279         https://bugs.webkit.org/show_bug.cgi?id=64494
1280
1281         Reviewed by Nate Chapin.
1282
1283         Only tested manually so far by following the repro instructions at
1284         crbug.com/88944
1285
1286         * platform/leveldb/LevelDBDatabase.cpp:
1287         (WebCore::LevelDBDatabase::~LevelDBDatabase):
1288         * storage/IDBLevelDBBackingStore.cpp:
1289         (WebCore::IDBLevelDBBackingStore::~IDBLevelDBBackingStore):
1290
1291 2011-07-25  David Reveman  <reveman@chromium.org>
1292
1293         [Chromium] Use correct vertex shader when rendering video layer.
1294         https://bugs.webkit.org/show_bug.cgi?id=65131
1295
1296         Reviewed by James Robinson.
1297
1298         Add new VertexShaderQuad program that is used by LayerTilerChromium.
1299         Change VertexShaderPosTexTransform so it works with CCVideoLayerImpl.
1300
1301         * platform/graphics/chromium/LayerTilerChromium.h:
1302         * platform/graphics/chromium/ShaderChromium.cpp:
1303         (WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
1304         (WebCore::VertexShaderPosTexTransform::init):
1305         (WebCore::VertexShaderPosTexTransform::getShaderString):
1306         (WebCore::VertexShaderQuad::VertexShaderQuad):
1307         (WebCore::VertexShaderQuad::init):
1308         (WebCore::VertexShaderQuad::getShaderString):
1309         * platform/graphics/chromium/ShaderChromium.h:
1310         (WebCore::VertexShaderQuad::matrixLocation):
1311         (WebCore::VertexShaderQuad::texTransformLocation):
1312
1313 2011-07-25  Patrick Gansterer  <paroga@webkit.org>
1314
1315         Fix AtomicString vs. String usage in accessibility code
1316         https://bugs.webkit.org/show_bug.cgi?id=65086
1317
1318         Reviewed by Darin Adler.
1319
1320         Use AtomicString instead of String where appropriate
1321         to avoid implicit type conversations.
1322         Also fix a invalid reference to a temporary String.
1323
1324         * accessibility/AccessibilityObject.h:
1325         (WebCore::AccessibilityObject::setAccessibleName):
1326         * accessibility/AccessibilityRenderObject.cpp:
1327         (WebCore::AccessibilityRenderObject::elementsFromAttribute):
1328         (WebCore::AccessibilityRenderObject::ariaAccessibilityDescription):
1329         (WebCore::AccessibilityRenderObject::setAccessibleName):
1330         * accessibility/AccessibilityRenderObject.h:
1331
1332 2011-07-25  Dan Bernstein  <mitz@apple.com>
1333
1334         Reverted r91699 due to
1335         <http://webkit.org/b/65134> REGRESSION: r91699 broke some font tests (image+text)
1336
1337         Many tests relied on font loading occurring synchronously in the cached and local cases.
1338
1339         * css/CSSFontFaceSource.cpp:
1340         (WebCore::CSSFontFaceSource::CSSFontFaceSource):
1341         (WebCore::CSSFontFaceSource::~CSSFontFaceSource):
1342         (WebCore::CSSFontFaceSource::getFontData):
1343         * css/CSSFontFaceSource.h:
1344
1345 2011-06-07  Martin Robinson  <mrobinson@igalia.com>
1346
1347         Reviewed by Gustavo Noronha Silva.
1348
1349         [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
1350         https://bugs.webkit.org/show_bug.cgi?id=62252
1351
1352         Properly handle the situation where the GtkWidget wants WebCore to draw its
1353         own main frame scrollbars.
1354
1355         * platform/gtk/ScrollViewGtk.cpp:
1356         (WebCore::shouldCreateMainFrameScrollbar): Abstract this logic into a helper function.
1357         (WebCore::ScrollView::createScrollbar): Use the new helper.
1358         (WebCore::ScrollView::visibleContentRect): Use the new helper.
1359
1360 2011-07-25  David Hyatt  <hyatt@apple.com>
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=65125
1363         
1364         (1) Add the new CSS3 positioned value for floats.
1365         (2) Rename FLEFT, FRIGHT and FNONE to our more modern convention: NoFloat, LeftFloat, RightFloat.
1366         (3) Replace uses of == FNONE and != FNONE with isFloating and !isFloating.
1367
1368         Reviewed by Dan Bernstein.
1369
1370         * css/CSSParser.cpp:
1371         (WebCore::CSSParser::parseValue):
1372         * css/CSSPrimitiveValueMappings.h:
1373         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1374         (WebCore::CSSPrimitiveValue::operator EFloat):
1375         * css/CSSStyleSelector.cpp:
1376         (WebCore::CSSStyleSelector::adjustRenderStyle):
1377         * css/CSSValueKeywords.in:
1378         * editing/ReplaceSelectionCommand.cpp:
1379         (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
1380         * rendering/RenderBlock.cpp:
1381         (WebCore::RenderBlock::insertFloatingObject):
1382         (WebCore::RenderBlock::positionNewFloats):
1383         (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
1384         (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
1385         * rendering/RenderObjectChildList.cpp:
1386         (WebCore::RenderObjectChildList::updateBeforeAfterContent):
1387         * rendering/style/RenderStyle.h:
1388         (WebCore::InheritedFlags::isFloating):
1389         (WebCore::InheritedFlags::initialFloating):
1390         * rendering/style/RenderStyleConstants.h:
1391
1392 2011-07-25  Dan Bernstein  <mitz@apple.com>
1393
1394         <rdar://problem/9835028> Font loading during layout can cause layout code to be re-entered via resource load delegate
1395         https://bugs.webkit.org/show_bug.cgi?id=65123
1396
1397         Reviewed by Anders Carlsson.
1398
1399         Since CSSFontFaceSource::getFontData() can get called during layout, avoid calling out to loader
1400         code from under it, and instead defer that work using a zero-delay timer.
1401
1402         * css/CSSFontFaceSource.cpp:
1403         (WebCore::CSSFontFaceSource::CSSFontFaceSource):
1404         (WebCore::CSSFontFaceSource::~CSSFontFaceSource):
1405         (WebCore::CSSFontFaceSource::getFontData): Rather than starting the font load here, schedule
1406         a zero-delay timer to do it.
1407         (WebCore::CSSFontFaceSource::startLoadingTimerFired): Added. Starts loading the font if needed.
1408         * css/CSSFontFaceSource.h:
1409
1410 2011-07-25  Andrew Wason  <rectalogic@rectalogic.com>
1411
1412         [Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2)
1413         https://bugs.webkit.org/show_bug.cgi?id=64878
1414
1415         Reviewed by Noam Rosenthal.
1416
1417         Existing WebGL layout tests should test this.
1418
1419         Adopt GraphicsContext3DOpenGL.cpp and ANGLE compiler for Qt.
1420
1421         * WebCore.pro: Build ANGLE compiler and GraphicsContext3DOpenGL.cpp.
1422         * platform/graphics/ANGLEWebKitBridge.h:
1423         * platform/graphics/GraphicsContext3D.h: Expose exising ANGLEWebKitBridge compiler member for Qt.
1424         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
1425         * platform/graphics/qt/GraphicsContext3DQt.cpp:
1426         (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize ANGLE resources.
1427
1428 2011-07-25  Daniel Bates  <dbates@rim.com>
1429
1430         REGRESSION (r85964): Improper relayout of some nested positioned elements
1431         https://bugs.webkit.org/show_bug.cgi?id=64286
1432
1433         Reviewed by David Hyatt.
1434
1435         Fixes an issue when traversing up the containing block hierarchy after skipping
1436         relatively positioned inlines.
1437
1438         When processing a positioned element we skip any intermediate inlines to get to
1439         to enclosing block B, but don't use the containing block for B (call this P_B) to
1440         properly continue traversing up the containing block hierarchy. So, B may be
1441         considered again instead of looking at P_B. Hence, we don't set the correct dirty
1442         bits for P_B and may not schedule a relayout with respect to the correct layout node.
1443
1444         Test: fast/block/positioning/relayout-nested-positioned-elements-crash.html
1445
1446         * rendering/RenderObject.h:
1447         (WebCore::RenderObject::markContainingBlocksForLayout):
1448
1449 2011-07-25  Arno Renevier  <arno@renevier.net>
1450
1451         removes last ENABLE(DRAG_SUPPORT) gtk check
1452         https://bugs.webkit.org/show_bug.cgi?id=64518
1453
1454         Reviewed by Martin Robinson.
1455
1456         * platform/gtk/ClipboardGtk.h:
1457
1458 2011-07-25  Alexandru Chiculita  <achicu@adobe.com>
1459
1460         [CSS Exclusions] Use HANDLE_INHERIT_AND_INITIAL when parsing -webkit-wrap-shape
1461         https://bugs.webkit.org/show_bug.cgi?id=65096
1462
1463         Also the 'inherit' keyword is now treated correctly. It will
1464         copy the value from the parent style.
1465
1466         Reviewed by Tony Chang.
1467
1468         * css/CSSStyleSelector.cpp:
1469         (WebCore::CSSStyleSelector::applyProperty):
1470
1471 2011-07-25  Andrew Wason  <rectalogic@rectalogic.com>
1472
1473         glActiveTexture(0) is invalid
1474         https://bugs.webkit.org/show_bug.cgi?id=65115
1475
1476         Reviewed by Kenneth Russell.
1477
1478         Existing WebGL layout tests.
1479
1480         Fix invalid glActiveTexture(0) call.
1481
1482         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
1483         (WebCore::GraphicsContext3D::prepareTexture):
1484
1485 2011-07-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1486
1487         Unreviewed, rolling out r91665.
1488         http://trac.webkit.org/changeset/91665
1489         https://bugs.webkit.org/show_bug.cgi?id=65118
1490
1491         Breaks inspector tests on JSC (Requested by pfeldman on
1492         #webkit).
1493
1494         * inspector/InjectedScriptSource.js:
1495         (.):
1496         ():
1497         * inspector/Inspector.json:
1498         * inspector/front-end/ConsoleView.js:
1499         (WebInspector.ConsoleView.prototype._format):
1500         (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
1501         (WebInspector.ConsoleMessage.prototype._format):
1502         * inspector/front-end/ElementsTreeOutline.js:
1503         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
1504         * inspector/front-end/ObjectPropertiesSection.js:
1505         (WebInspector.ObjectPropertyTreeElement.prototype.update):
1506         * inspector/front-end/PropertiesSidebarPane.js:
1507         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
1508         * inspector/front-end/RemoteObject.js:
1509         (WebInspector.RemoteObject):
1510         (WebInspector.RemoteObject.fromPrimitiveValue):
1511         (WebInspector.RemoteObject.fromPayload):
1512         (WebInspector.RemoteObject.prototype.callFunction):
1513         (WebInspector.LocalJSONObject.prototype.get type):
1514         * inspector/front-end/SourceFrame.js:
1515         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
1516         (WebInspector.SourceFrame.prototype._showPopup):
1517         * inspector/front-end/inspector.js:
1518         (WebInspector.log.logMessage):
1519         (WebInspector.log):
1520         (WebInspector.inspect):
1521
1522 2011-07-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1523
1524         Unreviewed, rolling out r91668.
1525         http://trac.webkit.org/changeset/91668
1526         https://bugs.webkit.org/show_bug.cgi?id=65117
1527
1528         Breaks inspector tests on JSC (Requested by pfeldman on
1529         #webkit).
1530
1531         * inspector/InjectedScript.cpp:
1532         (WebCore::InjectedScript::callFunctionOn):
1533         * inspector/InjectedScript.h:
1534         * inspector/InjectedScriptSource.js:
1535         (.):
1536         * inspector/Inspector.json:
1537         * inspector/InspectorRuntimeAgent.cpp:
1538         (WebCore::InspectorRuntimeAgent::callFunctionOn):
1539
1540 2011-07-25  Pavel Feldman  <pfeldman@google.com>
1541
1542         Web Inspector: use dedicated type for object id in the protocol.
1543         https://bugs.webkit.org/show_bug.cgi?id=65110
1544
1545         Reviewed by Yury Semikhatsky.
1546
1547         * inspector/InjectedScript.cpp:
1548         (WebCore::InjectedScript::callFunctionOn):
1549         * inspector/InjectedScript.h:
1550         * inspector/InjectedScriptSource.js:
1551         (.):
1552         * inspector/Inspector.json:
1553         * inspector/InspectorRuntimeAgent.cpp:
1554         (WebCore::InspectorRuntimeAgent::callFunctionOn):
1555
1556 2011-07-25  Yury Semikhatsky  <yurys@chromium.org>
1557
1558         [Chromium] Web Inspector: live edit error should be revealed in Console
1559         https://bugs.webkit.org/show_bug.cgi?id=65109
1560
1561         Reviewed by Pavel Feldman.
1562
1563         * inspector/front-end/SourceFrame.js:
1564         (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
1565         (WebInspector.SourceFrame.prototype.commitEditing):
1566
1567 2011-07-25  Pavel Feldman  <pfeldman@google.com>
1568
1569         Web Inspector: refactor remote object structure to contain value for primitive values.
1570         https://bugs.webkit.org/show_bug.cgi?id=65103
1571
1572         Reviewed by Yury Semikhatsky.
1573
1574         * inspector/InjectedScriptSource.js:
1575         * inspector/Inspector.json:
1576         * inspector/front-end/ConsoleView.js:
1577         (WebInspector.ConsoleView.prototype._format):
1578         (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
1579         (WebInspector.ConsoleMessage.prototype._format):
1580         * inspector/front-end/ElementsTreeOutline.js:
1581         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
1582         * inspector/front-end/ObjectPropertiesSection.js:
1583         (WebInspector.ObjectPropertyTreeElement.prototype.update):
1584         * inspector/front-end/PropertiesSidebarPane.js:
1585         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
1586         * inspector/front-end/RemoteObject.js:
1587         (WebInspector.RemoteObject):
1588         (WebInspector.RemoteObject.fromPrimitiveValue):
1589         (WebInspector.RemoteObject.fromPayload):
1590         (WebInspector.RemoteObject.prototype.get subtype):
1591         (WebInspector.RemoteObject.prototype.callFunction):
1592         (WebInspector.LocalJSONObject.prototype.get type):
1593         (WebInspector.LocalJSONObject.prototype.get subtype):
1594         * inspector/front-end/SourceFrame.js:
1595         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
1596         (WebInspector.SourceFrame.prototype._showPopup):
1597         * inspector/front-end/inspector.js:
1598         (WebInspector.log.logMessage):
1599         (WebInspector.log):
1600         (WebInspector.inspect):
1601
1602 2011-07-25  Mikhail Naganov  <mnaganov@chromium.org>
1603
1604         Web Inspector: [Chromium] Fix mixing of retaining path in heap profiler.
1605         https://bugs.webkit.org/show_bug.cgi?id=65028
1606
1607         Reviewed by Pavel Feldman.
1608
1609         * inspector/front-end/DetailedHeapshotView.js:
1610         (WebInspector.HeapSnapshotPathFinderState): Added
1611         (WebInspector.HeapSnapshotRetainingPathsList): Extracted State-specific code
1612
1613 2011-07-25  Yury Semikhatsky  <yurys@chromium.org>
1614
1615         Web Inspector: worker inspector should show Scripts panel by default
1616         https://bugs.webkit.org/show_bug.cgi?id=65099
1617
1618         Reviewed by Pavel Feldman.
1619
1620         * inspector/front-end/inspector.js:
1621         (WebInspector._defaultPanelName):
1622         (WebInspector.showPanel):
1623
1624 2011-07-24  Luke Macpherson   <macpherson@chromium.org>
1625
1626         Small cleanup of m_fontDirty tracking in CSSStyleSelector
1627         https://bugs.webkit.org/show_bug.cgi?id=65090
1628
1629         Reviewed by Darin Adler.
1630
1631         1) Use existing setFontDescription helper where appropriate.
1632         2) Move always used m_fontDirty check into updateFont()
1633
1634         No new tests / cleanup only.
1635
1636         * css/CSSStyleSelector.cpp:
1637         (WebCore::CSSStyleSelector::styleForElement):
1638         (WebCore::CSSStyleSelector::styleForKeyframe):
1639         (WebCore::CSSStyleSelector::pseudoStyleForElement):
1640         (WebCore::CSSStyleSelector::styleForPage):
1641         (WebCore::CSSStyleSelector::updateFontIfDirty):
1642         (WebCore::CSSStyleSelector::applyProperty):
1643         * css/CSSStyleSelector.h:
1644
1645 2011-07-24  Kent Tamura  <tkent@chromium.org>
1646
1647         Validation message bubble position is incorrect if the containing block has paddings.
1648         https://bugs.webkit.org/show_bug.cgi?id=65091
1649
1650         Reviewed by Hajime Morita.
1651
1652         * html/ValidationMessage.cpp:
1653         (WebCore::adjustBubblePosition):
1654         We don't need to subtract paddings because the origin of
1655         position:aboslute is inside borders and outside of the padding.
1656
1657 2011-07-24  Rob Buis  <rbuis@rim.com>
1658
1659         Crash in SVGUseElement::updateContainerOffsets on <use> with no parent
1660         https://bugs.webkit.org/show_bug.cgi?id=63646
1661
1662         Reviewed by Darin Adler.
1663
1664         Prevent using invalid targetElementInstance->shadowTreeElement after shadow render tree recreation. This situation can
1665         only occur when there was a valid shadowTreeElement before setting xlink:href to empty/invalid.
1666
1667         Test: svg/custom/use-shadow-root-parent-removal.svg
1668
1669         * svg/SVGUseElement.cpp:
1670         (WebCore::SVGUseElement::svgAttributeChanged):
1671
1672 2011-07-24  Patrick Gansterer  <paroga@webkit.org>
1673
1674         Fix AtomicString vs. String usage in JSC binding
1675         https://bugs.webkit.org/show_bug.cgi?id=65085
1676
1677         Reviewed by Darin Adler.
1678
1679         Use ustringToAtomicString instead of ustringToString where appropriate.
1680
1681         * bindings/js/JSHTMLAllCollectionCustom.cpp:
1682         * bindings/js/JSHTMLCollectionCustom.cpp:
1683
1684 2011-07-24  Luke Macpherson   <macpherson@chromium.org>
1685
1686         Implement CSSPropertyOutlineOffset in CSSStyleApplyProperty.
1687         https://bugs.webkit.org/show_bug.cgi?id=64773
1688
1689         Reviewed by Dimitri Glazkov.
1690
1691         No new tests / refactoring only.
1692
1693         * css/CSSStyleApplyProperty.cpp:
1694         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
1695         * css/CSSStyleSelector.cpp:
1696         (WebCore::CSSStyleSelector::applyProperty):
1697
1698 2011-07-24  Rob Buis  <rbuis@rim.com>
1699
1700         SVG <use> element is not repositioned when moved to x=0 y=0 through script 
1701         https://bugs.webkit.org/show_bug.cgi?id=53767
1702
1703         Reviewed by Nikolas Zimmermann.
1704
1705         Only bail out on zero offset if it is not explicitly set.
1706
1707         Test: svg/custom/use-move-to-offset.svg
1708
1709         * rendering/svg/RenderSVGTransformableContainer.cpp:
1710         (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
1711         * rendering/svg/SVGShadowTreeElements.cpp:
1712         (WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement):
1713         (WebCore::SVGShadowTreeContainerElement::setContainerOffset):
1714         * rendering/svg/SVGShadowTreeElements.h:
1715         (WebCore::SVGShadowTreeContainerElement::containerOffsetChanged):
1716         (WebCore::SVGShadowTreeContainerElement::setContainerOffsetChanged):
1717
1718 2011-07-24  Jeffrey Pfau  <jpfau@apple.com>
1719
1720         Refactor HTML tokenizer code in preparation for a new XML tokenizer
1721         https://bugs.webkit.org/show_bug.cgi?id=65000
1722
1723         Reviewed by Adam Barth.
1724
1725         * GNUmakefile.list.am:
1726         * WebCore.gypi:
1727         * WebCore.pro:
1728         * WebCore.vcproj/WebCore.vcproj:
1729         * WebCore.xcodeproj/project.pbxproj:
1730         * html/parser/HTMLDocumentParser.cpp:
1731         (WebCore::HTMLNames::tokenizerStateForContextElement):
1732         (WebCore::HTMLDocumentParser::pumpTokenizer):
1733         * html/parser/HTMLTokenizer.cpp:
1734         (WebCore::HTMLNames::isEndTagBufferingState):
1735         (WebCore::HTMLTokenizer::HTMLTokenizer):
1736         (WebCore::::shouldSkipNullCharacters):
1737         (WebCore::HTMLTokenizer::reset):
1738         (WebCore::HTMLTokenizer::flushEmitAndResumeIn):
1739         (WebCore::HTMLTokenizer::nextToken):
1740         (WebCore::HTMLTokenizer::updateStateFor):
1741         * html/parser/HTMLTokenizer.h:
1742         (WebCore::HTMLTokenizer::emitAndResumeIn):
1743         (WebCore::HTMLTokenizer::emitAndReconsumeIn):
1744         (WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):
1745         * html/parser/HTMLTreeBuilder.cpp:
1746         (WebCore::HTMLTreeBuilder::processStartTagForInBody):
1747         (WebCore::HTMLTreeBuilder::processEndTag):
1748         (WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
1749         (WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
1750         (WebCore::HTMLTreeBuilder::processScriptStartTag):
1751         * html/parser/TextDocumentParser.cpp:
1752         (WebCore::TextDocumentParser::TextDocumentParser):
1753         * html/parser/TextViewSourceParser.cpp:
1754         (WebCore::TextViewSourceParser::TextViewSourceParser):
1755         * xml/parser/MarkupTokenBase.h:
1756         (WebCore::MarkupTokenBase::type):
1757         * xml/parser/MarkupTokenizerBase.h: Added.
1758         (WebCore::MarkupTokenizerBase::~MarkupTokenizerBase):
1759         (WebCore::MarkupTokenizerBase::lineNumber):
1760         (WebCore::MarkupTokenizerBase::columnNumber):
1761         (WebCore::MarkupTokenizerBase::state):
1762         (WebCore::MarkupTokenizerBase::setState):
1763         (WebCore::MarkupTokenizerBase::forceNullCharacterReplacement):
1764         (WebCore::MarkupTokenizerBase::setForceNullCharacterReplacement):
1765         (WebCore::MarkupTokenizerBase::InputStreamPreprocessor::InputStreamPreprocessor):
1766         (WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
1767         (WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
1768         (WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):
1769         (WebCore::MarkupTokenizerBase::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):
1770         (WebCore::MarkupTokenizerBase::MarkupTokenizerBase):
1771         (WebCore::MarkupTokenizerBase::bufferCharacter):
1772         (WebCore::MarkupTokenizerBase::emitAndResumeIn):
1773         (WebCore::MarkupTokenizerBase::emitAndReconsumeIn):
1774         (WebCore::MarkupTokenizerBase::emitEndOfFile):
1775         (WebCore::MarkupTokenizerBase::reset):
1776         (WebCore::MarkupTokenizerBase::haveBufferedCharacterToken):
1777         * xml/parser/MarkupTokenizerInlineMethods.h: Added.
1778         (WebCore::isTokenizerWhitespace):
1779         (WebCore::advanceStringAndASSERTIgnoringCase):
1780         (WebCore::advanceStringAndASSERT):
1781
1782 2011-07-23  Patrick Gansterer  <paroga@webkit.org>
1783
1784         Remove WTF namespace from isMainThread() calls
1785         https://bugs.webkit.org/show_bug.cgi?id=65068
1786
1787         Reviewed by Sam Weinig.
1788
1789         Because of the using WTF::isMainThread in the header there is no
1790         reason to include the namespace name when calling this function.
1791
1792         * bindings/js/JSMainThreadExecState.h:
1793         * bindings/v8/DOMDataStore.cpp:
1794         * bindings/v8/V8Binding.cpp:
1795         * bindings/v8/V8DOMMap.cpp:
1796         * bindings/v8/V8DOMWrapper.h:
1797         * page/DOMWindow.cpp:
1798         * page/History.cpp:
1799
1800 2011-07-23  Alok Priyadarshi  <alokp@chromium.org>
1801
1802         Switching off acceleration for small canvas broke gpu tests
1803         https://bugs.webkit.org/show_bug.cgi?id=65053
1804
1805         Reviewed by Stephen White.
1806
1807         No new tests. These are supposed to fix existing canvas tests on gpu.
1808
1809         * html/canvas/CanvasRenderingContext2D.cpp:
1810         (WebCore::shouldAccelerateCanvas):
1811         * page/Settings.cpp:
1812         (WebCore::Settings::Settings):
1813         (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
1814         (WebCore::Settings::setMinimumAccelerated2dCanvasSize):
1815         * page/Settings.h:
1816         (WebCore::Settings::minimumAccelerated2dCanvasSize):
1817
1818 2011-07-23  Rob Buis  <rbuis@rim.com>
1819
1820         Freed SVGTRefElement used in SVGStyledElement::buildPendingResourcesIfNeeded
1821         https://bugs.webkit.org/show_bug.cgi?id=64758
1822
1823         Reviewed by Nikolas Zimmermann.
1824
1825         Fix the crash by storing referenced content inside a shadow tree. This way removing child nodes of
1826         the <tref> does not remove the referenced content.
1827
1828         * dom/Text.cpp:
1829         (WebCore::Text::recalcStyle):
1830         * dom/Text.h:
1831         * svg/SVGTRefElement.cpp:
1832         (WebCore::SVGShadowText::create):
1833         (WebCore::SVGShadowText::SVGShadowText):
1834         (WebCore::SVGShadowText::createRenderer):
1835         (WebCore::SVGShadowText::recalcStyle):
1836         (WebCore::SVGTRefElement::updateReferencedText):
1837         (WebCore::SVGTRefElement::childShouldCreateRenderer):
1838
1839 2011-07-23  Shinya Kawanaka  <shinyak@google.com>
1840
1841         Display number field without using a thousand separator.
1842         https://bugs.webkit.org/show_bug.cgi?id=65064
1843
1844         Reviewed by Kent Tamura.
1845
1846         Separated formatters for parsing and displaying.
1847         Removed a test for thousand separator.
1848
1849         * manual-tests/input-number-localization.html:
1850         Removed a test for thousand separator.
1851         Made the test description more specific.
1852         * platform/text/LocalizedNumberICU.cpp:
1853         (WebCore::createFormatterForCurrentLocaleToDisplay):
1854         Added to introduce a formatter for display.
1855         (WebCore::numberFormatterForParsing):
1856         Changed the name to be clear.
1857         (WebCore::numberFormatterForDisplay): Added.
1858         (WebCore::parseLocalizedNumber): Used numberFormatterForParsing.
1859         (WebCore::formatLocalizedNumber): Used numberFormatterForDisplay.
1860         * platform/text/mac/LocalizedNumberMac.mm:
1861         (WebCore::createFormatterForCurrentLocaleForDisplay):
1862         Added to introduce a formatter for display.
1863         (WebCore::numberFormatterForParsing):
1864         Changed the name to be clear.
1865         (WebCore::numberFormatterForDisplay): Added.
1866         (WebCore::parseLocalizedNumber): Used numberFormatterForParsing.
1867         (WebCore::formatLocalizedNumber): Used numberFormatterForDisplay.
1868
1869 2011-07-22  James Robinson  <jamesr@chromium.org>
1870
1871         [chromium] Seperate texture management for contents textures vs render surface textures
1872         https://bugs.webkit.org/show_bug.cgi?id=64771
1873
1874         Reviewed by Kenneth Russell.
1875
1876         Splits the chromium texture management across two TextureManagers, one for contents textures and one for render
1877         surfaces.  The lifetimes and relative evicition costs for these types of textures are significantly different.
1878         Content textures need to be managed from paint time through draw time and evicting them is generally expensive,
1879         since replacing the texture requires doing a software repaint into a buffer, creating a new texture, and
1880         uploading the contents into the texture.  Render surface textures are only used while drawing and never contain
1881         useful contents between frames.  The only reason to preserve a render surface texture between frames is to avoid
1882         having to create the texture on the next frame, they never contain useful contents across frames.
1883
1884         The contents texture limits remain the same.  Render surfaces are allocated the difference between the high
1885         memory bound and the contents texture memory use during a frame and the difference between the low memory bound
1886         and the contents texture memory use between frames.
1887
1888         Covered by existing compositing tests.
1889
1890         * platform/graphics/chromium/LayerRendererChromium.cpp:
1891         (WebCore::LayerRendererChromium::releaseTextures):
1892         (WebCore::LayerRendererChromium::drawLayers):
1893         (WebCore::LayerRendererChromium::updateLayers):
1894         (WebCore::LayerRendererChromium::initializeSharedObjects):
1895         (WebCore::LayerRendererChromium::cleanupSharedObjects):
1896         * platform/graphics/chromium/LayerRendererChromium.h:
1897         (WebCore::LayerRendererChromium::contentsTextureManager):
1898         (WebCore::LayerRendererChromium::renderSurfaceTextureManager):
1899         * platform/graphics/chromium/LayerTilerChromium.cpp:
1900         (WebCore::LayerTilerChromium::createTile):
1901         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
1902         (WebCore::RenderSurfaceChromium::prepareContentsTexture):
1903         * platform/graphics/chromium/TextureManager.cpp:
1904         (WebCore::TextureManager::TextureManager):
1905         (WebCore::TextureManager::setMemoryLimitBytes):
1906         (WebCore::TextureManager::requestTexture):
1907         * platform/graphics/chromium/TextureManager.h:
1908         (WebCore::TextureManager::create):
1909         (WebCore::TextureManager::currentMemoryUseBytes):
1910         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
1911         (WebCore::CCHeadsUpDisplay::draw):
1912
1913 2011-07-22  Simon Fraser  <simon.fraser@apple.com>
1914
1915         Avoiding painting backgrounds if they are fully obscures by an object's foreground
1916         https://bugs.webkit.org/show_bug.cgi?id=65030
1917
1918         Reviewed by Dan Bernstein.
1919
1920         Some pages use animated loading GIFs as the background of <img>,
1921         but WebKit keeps animating these after the <img> has loaded.
1922         
1923         Thwart this by avoiding the painting of such backgrounds, if we can
1924         determine that they are completely obscured by the border and content
1925         of the element.
1926
1927         * platform/graphics/BitmapImage.h:
1928         (WebCore::BitmapImage::currentFrameHasAlpha): Utility method, since currentFrame()
1929         is protected.
1930         * rendering/RenderBox.cpp:
1931         (WebCore::RenderBox::paintBoxDecorations): Call paintBackground().
1932         (WebCore::RenderBox::paintBackground): New wrapper for the paintFillLayers() which
1933         paints the background layers, plus some code we call in a couple of places. This
1934         checks the new backgroundIsObscured() method before doing any painting.
1935         * rendering/RenderBox.h:
1936         (WebCore::RenderBox::backgroundIsObscured): New virtual method that determines
1937         whether any of the background is visible.
1938         * rendering/RenderBoxModelObject.h:
1939         * rendering/RenderBoxModelObject.cpp:
1940         (WebCore::BorderEdge::obscuresBackground): Returns true if this edge will
1941         entirely hide the background under it.
1942         (WebCore::RenderBoxModelObject::borderObscuresBackground): Determine whether
1943         the border hides the background.
1944         * rendering/RenderImage.cpp:
1945         (WebCore::RenderImage::backgroundIsObscured): Override the RenderBox method
1946         and return true if the image is a loaded, opaque bitmap image, and the background
1947         won't show in the border or padding areas.
1948         * rendering/RenderImage.h:
1949         * rendering/RenderTable.cpp:
1950         (WebCore::RenderTable::paintBoxDecorations): Use paintBackground().
1951
1952 2011-07-22  Kenneth Russell  <kbr@google.com>
1953
1954         HTMLImageElement::crossOrigin is hard to use because of caching
1955         https://bugs.webkit.org/show_bug.cgi?id=64813
1956
1957         Reviewed by Adam Barth.
1958
1959         Reload the resource if the allowCredentials flag doesn't match that in the request.
1960
1961         Test: http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed.html
1962
1963         * loader/cache/CachedResourceLoader.cpp:
1964         (WebCore::CachedResourceLoader::requestResource):
1965         (WebCore::CachedResourceLoader::determineRevalidationPolicy):
1966         * loader/cache/CachedResourceLoader.h:
1967
1968 2011-07-22  Simon Fraser  <simon.fraser@apple.com>
1969
1970         Need to update the acceleratesDrawing status on a layer when switching to/from tiled layers
1971         https://bugs.webkit.org/show_bug.cgi?id=65057
1972
1973         Reviewed by Joseph Pecoraro.
1974
1975         When switching to or from tiled layers, we need to update the new layer's
1976         acceleratesDrawing status.
1977
1978         * platform/graphics/ca/GraphicsLayerCA.cpp:
1979         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
1980
1981 2011-07-22  Mark Pilgrim  <pilgrim@chromium.org>
1982
1983         Add [Optional=CallWithDefaultValues] flag and use it in initXXXEvent declarations
1984         https://bugs.webkit.org/show_bug.cgi?id=64973
1985
1986         Reviewed by Adam Barth.
1987
1988         We are doing away with the interface-level LegacyDefaultOptionalArguments
1989         flag. To handle some cases of the old behavior, we need to define a new
1990         (argument-level) flag so that functions can define optional arguments
1991         but not have to declare every single combination of arguments in C++.
1992         The old code generator handled this by calling a single C++ function
1993         with all arguments, but with default values for the "optional" arguments.
1994         Thus, this patch invents a new argument-level flag called
1995         [Optional=CallWithDefaultValue] that emulates the old behavior.
1996
1997         This patch also fixes all the initXXXEvent declarations to remove the
1998         LegacyDefaultOptionalArguments flag and use the new
1999         [Optional=CallWithDefaultValue] flag only on the specific arguments that
2000         require it for backward compatibility.
2001
2002         No new tests, all existing tests pass.
2003
2004         * bindings/scripts/CodeGeneratorJS.pm:
2005         (GenerateImplementation):
2006         * bindings/scripts/CodeGeneratorV8.pm:
2007         (GenerateFunctionCallback):
2008         * dom/BeforeLoadEvent.idl:
2009         * dom/BeforeProcessEvent.idl:
2010         * dom/CompositionEvent.idl:
2011         * dom/CustomEvent.idl:
2012         * dom/DeviceMotionEvent.idl:
2013         * dom/DeviceOrientationEvent.idl:
2014         * dom/ErrorEvent.idl:
2015         * dom/Event.idl:
2016         * dom/HashChangeEvent.idl:
2017         * dom/KeyboardEvent.idl:
2018         * dom/MessageEvent.idl:
2019         * dom/MouseEvent.idl:
2020         * dom/MutationEvent.idl:
2021         * dom/OverflowEvent.idl:
2022         * dom/PageTransitionEvent.idl:
2023         * dom/PopStateEvent.idl:
2024         * dom/ProgressEvent.idl:
2025         * dom/StreamEvent.idl:
2026         * dom/TextEvent.idl:
2027         * dom/TouchEvent.idl:
2028         * dom/UIEvent.idl:
2029         * dom/WebKitAnimationEvent.idl:
2030         * dom/WebKitTransitionEvent.idl:
2031         * dom/WheelEvent.idl:
2032         * html/canvas/WebGLContextEvent.idl:
2033         * storage/StorageEvent.idl:
2034         * websockets/CloseEvent.idl:
2035
2036 2011-07-22  Jessie Berlin  <jberlin@apple.com>
2037
2038         [WebKit2] Changing the cookie accept policy in Private Browsing doesn’t work
2039         https://bugs.webkit.org/show_bug.cgi?id=64997
2040
2041         Reviewed by Ada Chan.
2042
2043         * WebCore.exp.in:
2044         * platform/mac/WebCoreSystemInterface.h:
2045         * platform/mac/WebCoreSystemInterface.mm:
2046
2047 2011-07-22  Sergey Glazunov  <serg.glazunov@gmail.com>
2048
2049         Perform the JavaScript navigation check on a complete URL
2050         https://bugs.webkit.org/show_bug.cgi?id=65038
2051
2052         Reviewed by Adam Barth.
2053
2054         Test: http/tests/security/xss-DENIED-document-baseURI-javascript.html
2055
2056         * page/DOMWindow.cpp:
2057         (WebCore::DOMWindow::setLocation):
2058         (WebCore::DOMWindow::createWindow):
2059         (WebCore::DOMWindow::open):
2060
2061 2011-07-22  Ryosuke Niwa  <rniwa@webkit.org>
2062
2063         Revert r91595 for it broke Chromium Windows build.
2064
2065         * WebCore.gyp/WebCore.gyp:
2066         * WebCore.gypi:
2067
2068 2011-07-22  Mihnea Ovidenie  <mihnea@adobe.com>
2069
2070         BORDER attribute with the IMG tag, using percentage values not working.
2071         https://bugs.webkit.org/show_bug.cgi?id=20226
2072
2073         Reviewed by Simon Fraser.
2074
2075         When border presentational attribute of image element has % in it, it should be parsed using
2076         HTML parser rules. In this case, the algorithm is the one used described in:
2077         http://www.whatwg.org/specs/web-apps/current-work/#rules-for-parsing-non-negative-integers
2078
2079         * html/HTMLImageElement.cpp:
2080         (WebCore::parseBorderWidthAttribute):
2081         (WebCore::HTMLImageElement::parseMappedAttribute):
2082         * html/parser/HTMLParserIdioms.cpp:
2083         (WebCore::parseHTMLNonNegativeInteger):
2084         * html/parser/HTMLParserIdioms.h:
2085
2086 2011-07-22  Scott Graham  <scottmg@chromium.org>
2087
2088         DocumentLoader keeps a reference to all URL strings ever loaded in m_resourcesClientKnowsAbout leading to lots of memory waste
2089         https://bugs.webkit.org/show_bug.cgi?id=61894
2090
2091         Reviewed by James Robinson.
2092
2093         DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs
2094         that have passed through FrameLoader::dispatchWillSendRequest() and is
2095         used by FrameLoader::loadedResourceFromMemoryCached to decide whether
2096         to inform the FrameLoader's m_client about this load.  Unfortunately,
2097         this set holds a reference to the URL string for every resource
2098         loaded, so on pages that use data URLs to "load" large amounts of data
2099         this leaks lots of memory. The cache improves performance going through
2100         FrameLoader::loadResourceFromMemoryCache, so rather than removing it,
2101         simply exclude 'data:' urls from the cache to save the majority of
2102         memory that is held for too long.
2103
2104         * loader/DocumentLoader.h:
2105         (WebCore::DocumentLoader::didTellClientAboutLoad):
2106
2107 2011-07-22  Alok Priyadarshi  <alokp@chromium.org>
2108
2109         Use software rendering for small canvas
2110         https://bugs.webkit.org/show_bug.cgi?id=64958
2111
2112         Reviewed by Stephen White.
2113
2114         No new tests. Does not affect rendering output, just canvas backing.
2115         If there is a regression, they should be caught by existing canvas tests.
2116
2117         * html/HTMLCanvasElement.cpp:
2118         (WebCore::HTMLCanvasElement::reset):
2119         * html/canvas/CanvasRenderingContext2D.cpp:
2120         (WebCore::shouldAccelerateCanvas):
2121         (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
2122         (WebCore::CanvasRenderingContext2D::reset):
2123         (WebCore::CanvasRenderingContext2D::platformLayer):
2124         (WebCore::CanvasRenderingContext2D::clearAcceleration):
2125         (WebCore::CanvasRenderingContext2D::resetAcceleration):
2126         * html/canvas/CanvasRenderingContext2D.h:
2127
2128 2011-07-21  Adrienne Walker  <enne@google.com>
2129
2130         Fix repainting of composited fixed position elements in iframes
2131         https://bugs.webkit.org/show_bug.cgi?id=64010
2132
2133         Reviewed by Simon Fraser.
2134
2135         In cases where an iframe's contents have their own graphics layer, the
2136         invalidation during scrolling was being sent to the wrong render
2137         layer. Fixed by checking if such a layer exists and routing scrolling
2138         invalidations there first.
2139
2140         * page/FrameView.cpp:
2141         (WebCore::FrameView::scrollContentsSlowPath):
2142
2143 2011-07-22  Viet-Trung Luu  <viettrungluu@chromium.org>
2144
2145         Improve (i.e., speed up) .gyp(i) files for Chromium
2146         https://bugs.webkit.org/show_bug.cgi?id=65032
2147
2148         Reviewed by Adam Barth.
2149
2150         Begin splitting off webcore_(privateheader_)files into separate lists
2151         (dom/html/svg in this patch), to avoid the very slow pattern of
2152         excluding all files and then filtering to include selected files.
2153
2154         Test by building (in all supported configurations).
2155
2156         * WebCore.gyp/WebCore.gyp:
2157         * WebCore.gypi:
2158
2159 2011-07-22  Tony Chang  <tony@chromium.org>
2160
2161         add placeholder RenderFlexibleBox.cpp files
2162         https://bugs.webkit.org/show_bug.cgi?id=64982
2163
2164         Reviewed by Ojan Vafai.
2165
2166         No new tests, just adding new files and making sure it compiles.
2167         Also adding the isFlexibleBox identifier to RenderObject.
2168
2169         * CMakeLists.txt:
2170         * GNUmakefile.list.am:
2171         * WebCore.gypi:
2172         * WebCore.pro:
2173         * WebCore.vcproj/WebCore.vcproj:
2174         * WebCore.xcodeproj/project.pbxproj:
2175         * rendering/RenderFlexibleBox.cpp: Added.
2176         (WebCore::RenderFlexibleBox::RenderFlexibleBox): Inherit from RenderBlock like the old flexbox.
2177         (WebCore::RenderFlexibleBox::~RenderFlexibleBox):
2178         (WebCore::RenderFlexibleBox::renderName):
2179         (WebCore::RenderFlexibleBox::layoutBlock):
2180         * rendering/RenderFlexibleBox.h: Added.
2181         (WebCore::RenderFlexibleBox::isFlexibleBox):
2182         * rendering/RenderObject.h:
2183         (WebCore::RenderObject::isFlexibleBox):
2184
2185 2011-07-22  James Robinson  <jamesr@chromium.org>
2186
2187         [chromium] Force slow scrolling path for non-composited frames in a composited page
2188         https://bugs.webkit.org/show_bug.cgi?id=64991
2189
2190         Reviewed by Darin Fisher.
2191
2192         The chromium compositor does not properly handle fast path scrolls for non-composited iframe in a composited
2193         page.
2194
2195         * page/FrameView.cpp:
2196         (WebCore::FrameView::useSlowRepaints):
2197
2198 2011-07-22  Andrew Scherkus  <scherkus@chromium.org>
2199
2200         Remove surfaceType() and texture() methods from Chromium video frame classes.
2201         https://bugs.webkit.org/show_bug.cgi?id=64818
2202
2203         Reviewed by Kenneth Russell.
2204
2205         No tests as code was never being executed.
2206
2207         * platform/graphics/chromium/VideoFrameChromium.h:
2208         * platform/graphics/chromium/VideoLayerChromium.cpp:
2209         (WebCore::VideoLayerChromium::updateCompositorResources):
2210         * platform/graphics/chromium/VideoLayerChromium.h:
2211
2212 2011-07-22  Nate Chapin  <japhet@chromium.org>
2213
2214         Don't treat child frame loads as back-forward navigations
2215         after the load event fires. This can lead to loading
2216         the wrong url in the child frame.
2217         https://bugs.webkit.org/show_bug.cgi?id=64895
2218
2219         Reviewed by Mihai Parparita.
2220
2221         Test: fast/loader/child-frame-add-after-back-forward.html
2222
2223         * dom/Document.h: Drive-by FIXME.
2224         * loader/DocumentLoader.h: Drive-by FIXME.
2225         * loader/FrameLoader.cpp:
2226         (WebCore::FrameLoader::loadURLIntoChildFrame):
2227
2228 2011-07-22  Kent Tamura  <tkent@google.com>
2229
2230         REGRESSION(r88757): The thumb of a vertical range slider is offset to the right on non-Mac.
2231         https://bugs.webkit.org/show_bug.cgi?id=65011
2232
2233         Reviewed by Dimitri Glazkov.
2234
2235         We need to update the apeearance of thumbs before the layout of RenderSlider.
2236
2237         * html/shadow/SliderThumbElement.cpp:
2238         (WebCore::RenderSliderThumb::updateAppearance):
2239         Added. This function adjsuts the apparance of a thumb for the appearance of an <input>.
2240         (WebCore::RenderSliderThumb::isSliderThumb):
2241         Added.  Returns true.
2242         (WebCore::RenderSliderThumb::layout):
2243         Remove the appearance adjustment code. It is unnecessary because it is
2244         done in RenderSlider::layout().
2245         (WebCore::trackLimiterElementOf): Added.
2246         * html/shadow/SliderThumbElement.h: Move RenderSliderThumb from SliderThumbElement.cpp.
2247         * rendering/RenderObject.h:
2248         (WebCore::RenderObject::isSliderThumb): Added. Returns false.
2249         * rendering/RenderSlider.cpp:
2250         (WebCore::RenderSlider::layout):
2251         If the renderers for the thumb element and the limiter element is
2252         RenderSliderThumb, updates its appearance.
2253
2254 2011-07-22  Kent Tamura  <tkent@chromium.org>
2255
2256         Validation message bubble is incorrectly positioned in a relative body.
2257         https://bugs.webkit.org/show_bug.cgi?id=65018
2258
2259         Reviewed by Dimitri Glazkov.
2260
2261         We use position:aboslute for validation message bubbles, and the
2262         origin of the absolute position can be not only the page, but also
2263         an ancestor block with non-static position.
2264
2265         Test: fast/forms/validation-message-in-relative-body.html
2266
2267         * html/ValidationMessage.cpp:
2268         (WebCore::adjustBubblePosition):
2269         Subtract the containing block position from the host position.
2270         (WebCore::ValidationMessage::buildBubbleTree):
2271         Change the order of appendChild() and adjustBubblePosition() in
2272         order to use RenderObject::containingBlock() in
2273         adjustbubbleposition().
2274
2275 2011-07-22  David Grogan  <dgrogan@chromium.org>
2276
2277         Fix crash in IDBRequest::abort
2278         https://bugs.webkit.org/show_bug.cgi?id=64740
2279
2280         Reviewed by Nate Chapin.
2281
2282         Tested manually with the testcase in the bug.
2283
2284         * storage/IDBRequest.cpp:
2285         (WebCore::IDBRequest::~IDBRequest):
2286         (WebCore::IDBRequest::abort):
2287
2288 2011-07-22  Patrick Gansterer  <paroga@webkit.org>
2289
2290         Replace preprocessor statements in IDL files with Conditional attribute
2291         https://bugs.webkit.org/show_bug.cgi?id=64961
2292
2293         Reviewed by Darin Adler.
2294
2295         Replaced ENABLE_DATALIST, ENABLE_DIRECTORY_UPLOAD, ENABLE_INPUT_SPEECH, ENABLE_MEDIA_STATISTICS
2296         and ENABLE_ORIENTATION_EVENTS with the corresponding Conditional attribute.
2297
2298         * html/HTMLBodyElement.idl:
2299         * html/HTMLFrameSetElement.idl:
2300         * html/HTMLInputElement.idl:
2301         * html/HTMLMediaElement.idl:
2302         * html/HTMLVideoElement.idl:
2303
2304 2011-07-22  Andrey Kosyakov  <caseq@chromium.org>
2305
2306         Web Inspector: [Extensions API] add webInspector.resources.onContentEdited
2307         https://bugs.webkit.org/show_bug.cgi?id=65024
2308
2309         Reviewed by Pavel Feldman.
2310
2311         * inspector/front-end/ExtensionAPI.js:
2312         (WebInspector.injectedExtensionAPI):
2313         * inspector/front-end/ExtensionServer.js:
2314         (WebInspector.ExtensionServer.prototype.notifyResourceContentEdited):
2315         * inspector/front-end/Resource.js:
2316         (WebInspector.Resource.prototype.addRevision):
2317
2318 2011-07-22  Pavel Podivilov  <podivilov@chromium.org>
2319
2320         Web Inspector: fix exception when paused in internal script.
2321         https://bugs.webkit.org/show_bug.cgi?id=64995
2322
2323         Reviewed by Yury Semikhatsky.
2324
2325         Test: inspector/debugger/pause-in-internal-script.html
2326
2327         * inspector/front-end/DebuggerPresentationModel.js:
2328         (WebInspector.PresenationCallFrame.prototype.sourceLine):
2329
2330 2011-07-22  Ilya Tikhonovsky  <loislo@chromium.org>
2331
2332         Web Inspector: sometimes ReceiveResponse event is attached to wrong parent.
2333         https://bugs.webkit.org/show_bug.cgi?id=65016
2334
2335         Reviewed by Yury Semikhatsky.
2336
2337         Test: inspector/timeline/timeline-receive-response-event.html
2338
2339         * inspector/InspectorTimelineAgent.cpp:
2340         (WebCore::InspectorTimelineAgent::didInstallTimer):
2341         (WebCore::InspectorTimelineAgent::didRemoveTimer):
2342         (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
2343         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
2344         (WebCore::InspectorTimelineAgent::didTimeStamp):
2345         (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
2346         (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
2347         (WebCore::InspectorTimelineAgent::appendRecord):
2348         * inspector/InspectorTimelineAgent.h:
2349         * inspector/front-end/TimelinePanel.js:
2350         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
2351
2352 2011-07-22  Kentaro Hara  <haraken@google.com>
2353
2354         REGRESSION(r89535): Form reset does not repaint a file upload control.
2355         https://bugs.webkit.org/show_bug.cgi?id=65008
2356
2357         Reviewed by Kent Tamura.
2358
2359         This patch fixes the code so that the file upload control is repainted
2360         in updateFromElement() if no files are selected.
2361
2362         Tests: fast/forms/file-input-reset.html
2363
2364         * rendering/RenderFileUploadControl.cpp:
2365         (WebCore::RenderFileUploadControl::updateFromElement): Calls repaint() if no files are selected.
2366
2367 2011-07-22  Ilya Tikhonovsky  <loislo@chromium.org>
2368
2369         Web Inspector: the max depth of the Timeline events' stack trace should be customizable.
2370         https://bugs.webkit.org/show_bug.cgi?id=65023
2371
2372         Reviewed by Yury Semikhatsky.
2373
2374         * inspector/Inspector.json:
2375         * inspector/InspectorController.cpp:
2376         (WebCore::InspectorController::startTimelineProfiler):
2377         * inspector/InspectorTimelineAgent.cpp:
2378         (WebCore::InspectorTimelineAgent::pushGCEventRecords):
2379         (WebCore::InspectorTimelineAgent::restore):
2380         (WebCore::InspectorTimelineAgent::start):
2381         (WebCore::InspectorTimelineAgent::didInstallTimer):
2382         (WebCore::InspectorTimelineAgent::didRemoveTimer):
2383         (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
2384         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
2385         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
2386         (WebCore::InspectorTimelineAgent::didTimeStamp):
2387         (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
2388         (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
2389         (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
2390         (WebCore::InspectorTimelineAgent::pushCurrentRecord):
2391         * inspector/InspectorTimelineAgent.h:
2392         * inspector/TimelineRecordFactory.cpp:
2393         (WebCore::TimelineRecordFactory::createGenericRecord):
2394         * inspector/TimelineRecordFactory.h:
2395         * inspector/front-end/TimelineManager.js:
2396         (WebInspector.TimelineManager.prototype.start):
2397
2398 2011-07-22  Sheriff Bot  <webkit.review.bot@gmail.com>
2399
2400         Unreviewed, rolling out r91024.
2401         http://trac.webkit.org/changeset/91024
2402         https://bugs.webkit.org/show_bug.cgi?id=65017
2403
2404         number of problems happened with invisible elements which grab
2405         pointer events. (Requested by loislo on #webkit).
2406
2407         * inspector/front-end/inspector.css:
2408         (.panel):
2409         (.panel.visible):
2410
2411 2011-07-22  Jia Pu  <jpu@apple.com>
2412
2413         Reviewed by Darin Adler.
2414
2415         [Mac] Need to make sure autocorrection panel is dismissed in Document::setFocusNode().
2416         https://bugs.webkit.org/show_bug.cgi?id=64824
2417         <rdar://problem/9624232>
2418
2419         * editing/Editor.cpp:
2420         (WebCore::Editor::textFieldDidEndEditing): Dismiss autocorrection panel when current node losing focus.
2421
2422 2011-07-21  Kent Tamura  <tkent@chromium.org>
2423
2424         A trivial fix for r91550.
2425         https://bugs.webkit.org/show_bug.cgi?id=65001
2426
2427         Need to update placeholder visibility when the owner elemnent style is changed.
2428
2429         * html/HTMLTextFormControlElement.h: Make updatePlaceholderVisibility() public.
2430         * rendering/RenderTextControl.cpp:
2431         (WebCore::RenderTextControl::styleDidChange):
2432         Call updatePlaceholderVisibility().
2433
2434 2011-07-21  Pratik Solanki  <psolanki@apple.com>
2435
2436         https://bugs.webkit.org/show_bug.cgi?id=65002
2437         Get authentication to work with USE(CFNETWORK) on Mac
2438
2439         Reviewed by David Kilzer.
2440
2441         Instead of creating a new CFURLAuthChallengeRef, we save and reuse the same object as the
2442         one given to us by CFNetwork.
2443
2444         * platform/network/mac/AuthenticationMac.mm:
2445         (-[WebCoreAuthenticationClientAsChallengeSender setCFChallenge:]): Accessor methods for the
2446         new CFURLAuthChallengeRef ivar.
2447         (-[WebCoreAuthenticationClientAsChallengeSender cfChallenge]):
2448         (WebCore::core): Create AuthenticationChallenge using the saved CFURLAuthChallengeRef.
2449         (WebCore::mac): Use the CFURLAuthChallengeRef object in AuthenticationChallenge instead of
2450         creating a new one.
2451
2452 2011-07-21  Kent Tamura  <tkent@chromium.org>
2453
2454         REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden.
2455         https://bugs.webkit.org/show_bug.cgi?id=65001
2456
2457         Reviewed by Dimitri Glazkov.
2458
2459         Tests: fast/forms/placeholder-in-invisible-elements.html
2460                fast/forms/search-cancel-in-invisible-elements.html
2461
2462         * html/HTMLTextFormControlElement.cpp:
2463         (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
2464         Don't show the placeholder if the 'visibility' property of the owner element is 'hidden.'
2465         * rendering/RenderTextControlSingleLine.cpp:
2466         (WebCore::RenderTextControlSingleLine::visibilityForCancelButton): ditto.
2467
2468 2011-07-21  Shinya Kawanaka  <shinyak@google.com>
2469
2470         The input[type="number"] with step="any" should not suffer from step mismatch.
2471         https://bugs.webkit.org/show_bug.cgi?id=64858
2472
2473         Reviewed by Kent Tamura.
2474
2475         Added check step="any" not to suffer from step mismatch.
2476
2477         * html/HTMLInputElement.cpp:
2478         (WebCore::HTMLInputElement::applyStep): Added check step="any".
2479         (WebCore::HTMLInputElement::alignValueForStep): Added.
2480
2481 2011-07-21  MORITA Hajime  <morrita@google.com>
2482
2483         [Refactoring] ShadowContentSelector should be ShadowInclusionSelector
2484         https://bugs.webkit.org/show_bug.cgi?id=64850
2485
2486         Reviewed by Dimitri Glazkov.
2487
2488         Renamed:
2489         - ShadowContentSelector -> ShadowInclusionSelector
2490         - ShadowContentSelector::findInclusionFor -> ShadowInclusionSelector::findFor
2491         - ShadowContentSelector::selectInclusion -> ShadowInclusionSelector::select
2492         - ShadowContentSelector::unselectInclusion -> ShadowInclusionSelector::unselect
2493         - ShadowContentSelector::didSelectInclusion -> ShadowInclusionSelector::didSelect
2494         - ShadowContentSelector::willSelectInclusionOver -> ShadowInclusionSelector::willSelectOver
2495         - ShadowContentSelector::hasChildren -> ShadowInclusionSelector::hasCandidates
2496         
2497         No new tests. Just a textual change.
2498
2499         * CMakeLists.txt:
2500         * GNUmakefile.list.am:
2501         * WebCore.gypi:
2502         * WebCore.pro:
2503         * WebCore.vcproj/WebCore.vcproj:
2504         * WebCore.xcodeproj/project.pbxproj:
2505         * dom/DOMAllInOne.cpp:
2506         * dom/NodeRenderingContext.cpp:
2507         * dom/ShadowContentElement.cpp:
2508         (WebCore::ShadowContentElement::attach):
2509         (WebCore::ShadowContentElement::detach):
2510         * dom/ShadowInclusionSelector.cpp: Renamed from Source/WebCore/dom/ShadowContentSelector.cpp.
2511         (WebCore::ShadowInclusion::append):
2512         (WebCore::ShadowInclusion::unlink):
2513         (WebCore::ShadowInclusionList::ShadowInclusionList):
2514         (WebCore::ShadowInclusionList::~ShadowInclusionList):
2515         (WebCore::ShadowInclusionList::find):
2516         (WebCore::ShadowInclusionList::clear):
2517         (WebCore::ShadowInclusionList::append):
2518         (WebCore::ShadowInclusionSelector::ShadowInclusionSelector):
2519         (WebCore::ShadowInclusionSelector::~ShadowInclusionSelector):
2520         (WebCore::ShadowInclusionSelector::select):
2521         (WebCore::ShadowInclusionSelector::unselect):
2522         (WebCore::ShadowInclusionSelector::findFor):
2523         (WebCore::ShadowInclusionSelector::didSelect):
2524         (WebCore::ShadowInclusionSelector::willSelectOver):
2525         * dom/ShadowInclusionSelector.h: Renamed from Source/WebCore/dom/ShadowContentSelector.h.
2526         (WebCore::ShadowInclusion::includer):
2527         (WebCore::ShadowInclusion::content):
2528         (WebCore::ShadowInclusion::next):
2529         (WebCore::ShadowInclusion::previous):
2530         (WebCore::ShadowInclusion::ShadowInclusion):
2531         (WebCore::ShadowInclusion::create):
2532         (WebCore::ShadowInclusionList::first):
2533         (WebCore::ShadowInclusionList::last):
2534         (WebCore::ShadowInclusionList::isEmpty):
2535         (WebCore::ShadowInclusionSet::add):
2536         (WebCore::ShadowInclusionSet::remove):
2537         (WebCore::ShadowInclusionSet::isEmpty):
2538         (WebCore::ShadowInclusionSet::Translator::hash):
2539         (WebCore::ShadowInclusionSet::Translator::equal):
2540         (WebCore::ShadowInclusionSet::Hash::hash):
2541         (WebCore::ShadowInclusionSet::Hash::equal):
2542         (WebCore::ShadowInclusionSet::find):
2543         (WebCore::ShadowInclusionSelector::hasCandidates):
2544         * dom/ShadowRoot.cpp:
2545         (WebCore::ShadowRoot::includerFor):
2546         (WebCore::ShadowRoot::attach):
2547         (WebCore::ShadowRoot::inclusions):
2548         (WebCore::ShadowRoot::ensureInclusions):
2549         * dom/ShadowRoot.h:
2550
2551 2011-07-21  Robin Qiu  <robin.qiu.dev@gmail.com>
2552
2553         https://bugs.webkit.org/show_bug.cgi?id=60737
2554
2555         ThumbPosition() in ScrollbarTheme should be ceiled before returned.
2556         Otherwise, some topest/leftest content can not be shown by dragging
2557         scrollbar thumb.
2558
2559
2560         Reviewed by Antonio Gomes.
2561
2562         Test: scrollbars/scrollbar-drag-thumb-with-large-content.html
2563
2564         * platform/ScrollbarThemeComposite.cpp:
2565         (WebCore::ScrollbarThemeComposite::thumbPosition):
2566         * platform/qt/ScrollbarThemeQt.cpp:
2567         (WebCore::ScrollbarThemeQt::thumbPosition):
2568
2569 2011-07-21  Simon Fraser  <simon.fraser@apple.com>
2570
2571         GraphicsLayers in subframes can get sync'd multiple times
2572         https://bugs.webkit.org/show_bug.cgi?id=52489
2573
2574         Reviewed by James Robinson.
2575         
2576         Avoid doing a 'syncCompositingState' pass on the GraphicsLayers
2577         for subframes, when those GraphicsLayers are rooted in the
2578         parent document.
2579
2580         * page/FrameView.cpp:
2581         (WebCore::FrameView::syncCompositingStateForThisFrame): Add a parameter
2582         that contains the rootmost frame on which sync was called. This is used
2583         to indicate to the compositor whether it's the root of the sync.
2584         (WebCore::FrameView::syncCompositingStateIncludingSubframes): Pass the current
2585         Frame in.
2586         (WebCore::FrameView::paintContents): The sync is for this frame, so pass m_frame.
2587         * page/FrameView.h:
2588         * rendering/RenderLayerCompositor.cpp:
2589         (WebCore::RenderLayerCompositor::flushPendingLayerChanges): New parameter
2590         to specify whether this compositor is in the rootmost Frame being flushed.
2591         We can avoid doing work if we know that flushing some ancestor frame would
2592         have also traversed our GraphicsLayers.
2593         * rendering/RenderLayerCompositor.h:
2594         (WebCore::RenderLayerCompositor::isFlushingLayers): Make this private, since
2595         callers are probably most intersted in enclosingCompositorFlushingLayers().
2596
2597 2011-07-21  Rafael Brandao  <rafael.lobo@openbossa.org>
2598
2599         Local files cannot load icons.
2600         https://bugs.webkit.org/show_bug.cgi?id=62459
2601         
2602         Previous policy only allowed favicons for pages whose protocol was part of HTTP family.
2603         Changed that to allow to any url that's not empty and whose protocol is not "about".
2604         Also added this check where it attempts to start loading the favicon, so it can avoid
2605         wasting time downloading a resource that won't be stored and won't be used.
2606
2607         Reviewed by Adam Barth.
2608
2609         Test: manual-tests/resources/favicon-loads-for-local-files.html
2610
2611         * loader/icon/IconController.cpp:
2612         (WebCore::IconController::startLoader): Added check to avoid to request a favicon
2613         when there's no way to store it.
2614         
2615         * loader/icon/IconDatabase.cpp:
2616         (WebCore::IconDatabase::documentCanHaveIcon): Renamed function "pageCanHaveIcon"
2617         to reflect better which url we're handling.
2618         
2619         (WebCore::IconDatabase::synchronousIconForPageURL): Ditto.
2620         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
2621         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
2622         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
2623         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
2624         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
2625         (WebCore::IconDatabase::importIconURLForPageURL): Ditto.
2626         (WebCore::IconDatabase::performURLImport): Ditto.
2627         * loader/icon/IconDatabase.h:
2628         * loader/icon/IconDatabaseBase.h:
2629         (WebCore::IconDatabaseBase::documentCanHaveIcon): Added it as virtual to replace its
2630         default behavior of not allowing favicons when we have IconDatabase enabled.
2631         
2632         * manual-tests/resources/favicon-loads-for-local-files.html: Added.
2633         * manual-tests/resources/favicon.png: Added.
2634
2635 2011-07-21  Kulanthaivel Palanichamy  <kulanthaivel@codeaurora.org>
2636
2637         Fix for bug 64046 - Wrong image height in absolutely positioned div in
2638         relatively positioned parent with bottom padding.
2639         https://bugs.webkit.org/show_bug.cgi?id=64046
2640
2641         Reviewed by David Hyatt.
2642
2643         Test: fast/css/absolute-child-with-percent-height-inside-relative-parent.html
2644
2645         * rendering/RenderBox.cpp:
2646         (WebCore::RenderBox::availableLogicalHeightUsing):
2647
2648 2011-07-21  Gavin Peters  <gavinp@chromium.org>
2649
2650         Extend the protector of a CSS style sheet.  Because checkLoaded() can recursively delete
2651         parent style elements, the protector should be extended to include the parent call.
2652
2653         https://bugs.webkit.org/show_bug.cgi?id=64736
2654
2655         Reviewed by Simon Fraser.
2656
2657         Test: fast/css/css-imports-2.html
2658
2659         * css/CSSStyleSheet.cpp:
2660         (WebCore::CSSStyleSheet::checkLoaded):
2661
2662 2011-07-21  Kenneth Russell  <kbr@google.com>
2663
2664         Update webglcontextlost / webglcontextrestored delivery to match spec changes
2665         https://bugs.webkit.org/show_bug.cgi?id=58621
2666
2667         Reviewed by James Robinson.
2668
2669         Updated conditions under which webglcontextrestored event is
2670         delivered to be spec compliant.
2671
2672         * html/canvas/WebGLRenderingContext.cpp:
2673         (WebCore::WebGLRenderingContext::WebGLRenderingContext):
2674         (WebCore::WebGLRenderingContext::loseContext):
2675         (WebCore::WebGLRenderingContext::maybeRestoreContext):
2676         * html/canvas/WebGLRenderingContext.h:
2677
2678 2011-07-21  Dave Hyatt  <hyatt@apple.com>
2679
2680         https://bugs.webkit.org/show_bug.cgi?id=64975
2681         Elements that have columns (e.g., column-width or column-count non-auto) and elements that have
2682         column-spans establish block formatting contexts, and therefore they should not be allowing
2683         child margins to collapse with their own margins.
2684
2685         Reviewed by Beth Dakin.
2686
2687         Covered by existing tests.
2688
2689         * rendering/RenderBlock.cpp:
2690         (WebCore::RenderBlock::MarginInfo::MarginInfo):
2691
2692 2011-07-21  Matthew Delaney  <mdelaney@apple.com>
2693
2694         Add fast path for ImageBuffer::draw, Take 2.
2695         https://bugs.webkit.org/show_bug.cgi?id=64535
2696
2697         Reviewed by Simon Fraser.
2698
2699         No new tests. This patch doesn't change behavior; current tests are sufficient.
2700
2701         * platform/graphics/GraphicsContext.cpp:
2702         (WebCore::GraphicsContext::drawImage): Moved the main method version next to wrapper versions.
2703
2704         * platform/graphics/ImageBuffer.h:
2705         1) Added BackingStoreCopy enum for choosing to copy backing store or not in copyImage().
2706         2) Added copyNativeImage() behind USE(CG) - same as copyImage() but gives NativeImagePtr.
2707         * platform/graphics/cg/ImageBufferCG.cpp: Added new methods described above.
2708
2709         * platform/graphics/GraphicsContext.h: Adding drawNativeImage() for fast draw path.
2710         * platform/graphics/cg/GraphicsContextCG.cpp:
2711         (WebCore::GraphicsContext::drawNativeImage): Added. Draws a nativeImagePtr into context.
2712
2713         * platform/graphics/Image.h: Added imageWithColorSpace behind CG platform ifdef
2714         * platform/graphics/cg/ImageCG.cpp:
2715         (WebCore::BitmapImage::draw): Refactored out actual image drawing code into GraphicsContext,
2716         so that it can be used by more than just BitmapImage without having to copy code.
2717         (WebCore::Image::imageWithColorSpace): Made into an Image class function.
2718
2719         Updated copyImage() to use BackingStoreCopy:
2720         * platform/graphics/qt/ImageBufferQt.cpp
2721         * platform/graphics/filters/FETile.cpp
2722         * platform/graphics/cairo/ImageBufferCairo.cpp
2723         * platform/graphics/skia/ImageBufferSkia.cpp
2724         * platform/graphics/wx/ImageBufferWx.cpp
2725         * platform/graphics/wince/ImageBufferWinCE.cpp
2726         * svg/SVGFEImageElement.cpp
2727         * svg/graphics/SVGImage.cpp
2728         * html/HTMLCanvasElement.cpp
2729         * html/canvas/WebGLRenderingContext.cpp
2730         * rendering/svg/RenderSVGResourcePattern.cpp
2731
2732 2011-07-21  David Kilzer  <ddkilzer@apple.com>
2733
2734         <http://webkit.org/b/64972> Clean up generated HTMLEntityTable.cpp output
2735
2736         Reviewed by Eric Seidel.
2737
2738         * html/parser/create-html-entity-table:
2739         - Fix duplicate "EntityName" suffix on local variables (changes
2740           fooSemicolonEntityNameEntityName to fooSemicolonEntityName)
2741           for all 2138 symbols.
2742         - Add newlines to make source file human-readable (as originally
2743           intended).
2744         - Add static (const) keywords to local variables that are never
2745           referenced externally.
2746
2747 2011-07-21  Mark Pilgrim  <pilgrim@chromium.org>
2748
2749         Remove LegacyDefaultOptionalArguments flag from FileAPI
2750         https://bugs.webkit.org/show_bug.cgi?id=64539
2751
2752         Reviewed by Adam Barth.
2753
2754         No new tests, all existing tests pass.
2755
2756         * fileapi/Blob.idl:
2757         * fileapi/DirectoryEntry.idl:
2758         * fileapi/DirectoryEntrySync.idl:
2759         * fileapi/DirectoryReader.idl:
2760         * fileapi/EntriesCallback.idl:
2761         * fileapi/Entry.idl:
2762         * fileapi/EntryArray.idl:
2763         * fileapi/EntryArraySync.idl:
2764         * fileapi/EntryCallback.idl:
2765         * fileapi/EntrySync.idl:
2766         * fileapi/ErrorCallback.idl:
2767         * fileapi/FileCallback.idl:
2768         * fileapi/FileEntry.idl:
2769         * fileapi/FileList.idl:
2770         * fileapi/FileReader.idl:
2771         * fileapi/FileReaderSync.idl:
2772         * fileapi/FileSystemCallback.idl:
2773         * fileapi/FileWriter.idl:
2774         * fileapi/FileWriterCallback.idl:
2775         * fileapi/FileWriterSync.idl:
2776         * fileapi/MetadataCallback.idl:
2777         * fileapi/WebKitBlobBuilder.idl:
2778
2779 2011-07-21  Tony Chang  <tony@chromium.org>
2780
2781         sort WebCore.xcodeproj
2782         https://bugs.webkit.org/show_bug.cgi?id=64901
2783
2784         Unreviewed, just using sort-Xcode-project-file.
2785
2786         * WebCore.xcodeproj/project.pbxproj:
2787
2788 2011-07-21  Enrica Casucci  <enrica@apple.com>
2789
2790         Cannot click to position the caret to the right of an image with display:block style.
2791         https://bugs.webkit.org/show_bug.cgi?id=64962
2792         <rdar://problem/9446343>
2793
2794         Reviewed by David Hyatt.
2795
2796         Test: editing/selection/click-on-block-image.html
2797
2798         The current implementation of positionForPoint always returns the visible
2799         position to the left of the image, if the image has a block style.
2800         This patch changes the behavior for block styled images to match the behavior
2801         for inline images.
2802
2803         * rendering/RenderReplaced.cpp:
2804         (WebCore::RenderReplaced::positionForPoint): Modified to avoid relying entirely
2805         on InlineBox to calculate the position.
2806
2807 >>>>>>> .r91495
2808 2011-07-21  Pavel Feldman  <pfeldman@google.com>
2809
2810         Not reviewed: one liner typo fix in Inspector.json.
2811
2812         * inspector/Inspector.json:
2813
2814 2011-07-21  Sam Weinig  <sam@webkit.org>
2815
2816         CSS top margin collapses when paginating
2817         https://bugs.webkit.org/show_bug.cgi?id=64906
2818
2819         Reviewed by David Hyatt.
2820
2821         * rendering/RenderBlock.cpp:
2822         (WebCore::RenderBlock::collapseMargins):
2823         (WebCore::RenderBlock::estimateLogicalTopPosition):
2824         Update to only go down paginated path when we actually have a page height (so
2825         not in the case that we are just gathering breaks) and to call the version of
2826         of nextPageLogicalTop that actually returns the next page, even if we are at
2827         the boundary point.
2828
2829         (WebCore::RenderBlock::nextPageLogicalTopExcludingBoundaryPoint):
2830         (WebCore::RenderBlock::nextPageLogicalTopIncludingBoundaryPoint):
2831         Split into two functions which differ in how they deal with the boundary condition.
2832
2833         (WebCore::RenderBlock::applyBeforeBreak):
2834         (WebCore::RenderBlock::applyAfterBreak):
2835         Switch to call nextPageLogicalTopIncludingBoundaryPoint.
2836
2837         * rendering/RenderBlock.h:
2838         Add new functions declarations and comment them.
2839
2840 2011-07-21  Pavel Feldman  <pfeldman@google.com>
2841
2842         Web Inspector: RuntimeAgent.evaluateOn should not require "return X;" syntax.
2843         https://bugs.webkit.org/show_bug.cgi?id=64691
2844
2845         Reviewed by Yury Semikhatsky.
2846
2847         I'm introducing callFunctionOn that receives function declaration in order
2848         to make call site syntax clear.
2849
2850         Test: inspector/runtime/runtime-callFunctionOn.html
2851
2852         * inspector/InjectedScript.cpp:
2853         (WebCore::InjectedScript::callFunctionOn):
2854         * inspector/InjectedScript.h:
2855         * inspector/InjectedScriptSource.js:
2856         (.):
2857         * inspector/Inspector.json:
2858         * inspector/InspectorRuntimeAgent.cpp:
2859         (WebCore::InspectorRuntimeAgent::callFunctionOn):
2860         * inspector/InspectorRuntimeAgent.h:
2861         * inspector/front-end/ElementsTreeOutline.js:
2862         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode.dimensions):
2863         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
2864         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
2865         * inspector/front-end/PropertiesSidebarPane.js:
2866         (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved.protoList):
2867         (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
2868         * inspector/front-end/RemoteObject.js:
2869         (WebInspector.RemoteObject.prototype.callFunction):
2870
2871 2011-07-21  Andrew Wason  <rectalogic@rectalogic.com>
2872
2873         [Qt] Adopt existing GraphicsContext3D members (part 1)
2874         https://bugs.webkit.org/show_bug.cgi?id=64877
2875
2876         Reviewed by Noam Rosenthal.
2877
2878         Existing WebGL layout tests should test this.
2879
2880         Remove GraphicsContext3DInternal members and use the existing
2881         corresponding members from GraphicsContext3D instead.
2882         Move most of the GraphicsContext3DInternal constructor, destructor
2883         and the reshape() method into GraphicsContext3D.
2884         The GraphicsContext3D members will be needed when we adopt
2885         GraphicsContext3DOpenGL.cpp.
2886
2887         * platform/graphics/GraphicsContext3D.h:
2888         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2889         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
2890         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
2891         (WebCore::GraphicsContext3DInternal::paintToTextureMapper):
2892         (WebCore::GraphicsContext3DInternal::boundingRect):
2893         (WebCore::GraphicsContext3DInternal::paint):
2894         (WebCore::GraphicsContext3D::GraphicsContext3D):
2895         (WebCore::GraphicsContext3D::~GraphicsContext3D):
2896         (WebCore::GraphicsContext3D::platformTexture):
2897         (WebCore::GraphicsContext3D::reshape):
2898         (WebCore::GraphicsContext3D::bindFramebuffer):
2899         (WebCore::GraphicsContext3D::getContextAttributes):
2900         (WebCore::GraphicsContext3D::getError):
2901         (WebCore::GraphicsContext3D::synthesizeGLError):
2902         (WebCore::GraphicsContext3D::markLayerComposited):
2903         (WebCore::GraphicsContext3D::markContextChanged):
2904         (WebCore::GraphicsContext3D::layerComposited):
2905         (WebCore::GraphicsContext3D::getExtensions):
2906
2907 2011-07-21  Pavel Feldman  <pfeldman@google.com>
2908
2909         Web Inspector: [protocol] extend setBreakpointByUrl request to accept incomplete URL (predicates)
2910         https://bugs.webkit.org/show_bug.cgi?id=60762
2911
2912         Reviewed by Yury Semikhatsky.
2913
2914         Test: inspector/debugger/debugger-set-breakpoint-regex.html
2915
2916         * inspector/Inspector.json:
2917         * inspector/InspectorDebuggerAgent.cpp:
2918         (WebCore::buildObjectForBreakpointCookie):
2919         (WebCore::matches):
2920         (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
2921         (WebCore::InspectorDebuggerAgent::didParseSource):
2922         * inspector/InspectorDebuggerAgent.h:
2923
2924 2011-07-21  Kent Tamura  <tkent@chromium.org>
2925
2926         REGRESSION(r88757): input[type=range] renders incorrectly in RTL context.
2927         https://bugs.webkit.org/show_bug.cgi?id=64904
2928
2929         Reviewed by Ryosuke Niwa.
2930
2931         Tests: fast/forms/input-appearance-range-rtl.html
2932
2933         * html/shadow/SliderThumbElement.cpp:
2934         (WebCore::RenderSliderThumb::layout):
2935         The thumb should be positioned based on 'right' CSS property instead of 'left.'
2936         (WebCore::SliderThumbElement::setPositionFromPoint):
2937         The fraction should be flipped in RTL.
2938
2939 2011-07-18  Vsevolod Vlasov  <vsevik@chromium.org>
2940
2941         Web Inspector: Remove networkDataRemoved field from resource.
2942         https://bugs.webkit.org/show_bug.cgi?id=64749
2943
2944         Reviewed by Pavel Feldman.
2945
2946         * inspector/front-end/NetworkManager.js:
2947         (WebInspector.NetworkManager.prototype.requestContent):
2948         (WebInspector.NetworkDispatcher.prototype._appendRedirect):
2949         * inspector/front-end/NetworkPanel.js:
2950         (WebInspector.NetworkLogView.prototype._frameNavigated):
2951
2952 2011-07-21  Tommy Widenflycht  <tommyw@google.com>
2953
2954         MediaStream API: Merging MediaStreamContainer and MediaStreamList
2955         https://bugs.webkit.org/show_bug.cgi?id=64794
2956
2957         Reviewed by Tony Gentilcore.
2958
2959         * GNUmakefile.list.am:
2960         * dom/MediaStreamContainer.h: Removed.
2961         * dom/MediaStreamList.cpp:
2962         (WebCore::MediaStreamList::create):
2963         (WebCore::MediaStreamList::MediaStreamList):
2964         (WebCore::MediaStreamList::length):
2965         (WebCore::MediaStreamList::item):
2966         (WebCore::MediaStreamList::add):
2967         (WebCore::MediaStreamList::remove):
2968         (WebCore::MediaStreamList::contains):
2969         (WebCore::MediaStreamList::get):
2970         * dom/MediaStreamList.h:
2971
2972 2011-07-20  Yury Semikhatsky  <yurys@chromium.org>
2973
2974         Web Inspector: always open dedicated worker inspector in a new window not a new tab
2975         https://bugs.webkit.org/show_bug.cgi?id=64872
2976
2977         Reviewed by Pavel Feldman.
2978
2979         * inspector/front-end/WorkerManager.js:
2980         (WebInspector.WorkerManager.prototype.openWorkerInspector):
2981
2982 2011-07-21  MORITA Hajime  <morrita@google.com>
2983
2984         [Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector
2985         https://bugs.webkit.org/show_bug.cgi?id=64849
2986
2987         Reviewed by Dimitri Glazkov.
2988
2989         This change is a reorg around Shadow inclusion mechanism.
2990         - Moved definition of ShadowInclusion, ShadowInclusionSet and ShadowInclusionList
2991           from ShadowContentElement.h to ShadowContentSelector.h, which is included
2992           from smaller number of places.
2993         - Moved ShadowInclusionSet from ShadowRoot to ShadowContentSelector
2994         - Made ShadowContentSelector's lifetime managed by ShadowRoot
2995           because ShadowInclusionSet is held by the selector.
2996         - Thus, there is no longer "active" selector (ShadowContentSelector::s_currentInstance)
2997           Because the selector is associated for each ShadowRoot object.
2998         
2999         No new tests. No behavior change.
3000
3001         * dom/NodeRenderingContext.cpp:
3002         * dom/ShadowContentElement.cpp:
3003         (WebCore::ShadowContentElement::ShadowContentElement):
3004         (WebCore::ShadowContentElement::attach):
3005         (WebCore::ShadowContentElement::detach):
3006         * dom/ShadowContentElement.h:
3007         (WebCore::ShadowContentElement::inclusions):
3008         * dom/ShadowContentSelector.cpp:
3009         (WebCore::ShadowInclusion::append):
3010         (WebCore::ShadowInclusion::unlink):
3011         (WebCore::ShadowInclusionList::ShadowInclusionList):
3012         (WebCore::ShadowInclusionList::~ShadowInclusionList):
3013         (WebCore::ShadowInclusionList::find):
3014         (WebCore::ShadowInclusionList::clear):
3015         (WebCore::ShadowInclusionList::append):
3016         (WebCore::ShadowContentSelector::ShadowContentSelector):
3017         (WebCore::ShadowContentSelector::~ShadowContentSelector):
3018         (WebCore::ShadowContentSelector::selectInclusion):
3019         (WebCore::ShadowContentSelector::unselectInclusion):
3020         (WebCore::ShadowContentSelector::findInclusionFor):
3021         (WebCore::ShadowContentSelector::didSelectInclusion):
3022         (WebCore::ShadowContentSelector::willSelectInclusionOver):
3023         * dom/ShadowContentSelector.h:
3024         (WebCore::ShadowInclusion::includer):
3025         (WebCore::ShadowInclusion::content):
3026         (WebCore::ShadowInclusion::next):
3027         (WebCore::ShadowInclusion::previous):
3028         (WebCore::ShadowInclusion::ShadowInclusion):
3029         (WebCore::ShadowInclusion::create):
3030         (WebCore::ShadowInclusionList::first):
3031         (WebCore::ShadowInclusionList::last):
3032         (WebCore::ShadowInclusionList::isEmpty):
3033         (WebCore::ShadowInclusionSet::add):
3034         (WebCore::ShadowInclusionSet::remove):
3035         (WebCore::ShadowInclusionSet::isEmpty):
3036         (WebCore::ShadowInclusionSet::Translator::hash):
3037         (WebCore::ShadowInclusionSet::Translator::equal):
3038         (WebCore::ShadowInclusionSet::Hash::hash):
3039         (WebCore::ShadowInclusionSet::Hash::equal):
3040         (WebCore::ShadowInclusionSet::find):
3041         (WebCore::ShadowContentSelector::hasChildren):
3042         * dom/ShadowRoot.cpp:
3043         (WebCore::ShadowRoot::~ShadowRoot):
3044         (WebCore::ShadowRoot::includerFor):
3045         (WebCore::ShadowRoot::attach):
3046         (WebCore::ShadowRoot::inclusions):
3047         (WebCore::ShadowRoot::ensureInclusions):
3048         * dom/ShadowRoot.h:
3049
3050 2011-07-21  Rohan McGovern  <rohan@mcgovern.id.au>
3051
3052         Reviewed by Noam Rosenthal.
3053
3054         [Qt] Qt5 Build Fix: remove useless use of qRound(int)
3055         https://bugs.webkit.org/show_bug.cgi?id=64907
3056
3057         Rounding an integer doesn't make sense.
3058         Since 2dcd3939a8bd5ff743e4c87f87b2d81b1a101467 in qtbase, this is not
3059         permitted to compile.
3060
3061         No new tests needed.
3062
3063         * platform/graphics/qt/FontPlatformDataQt.cpp:
3064         (WebCore::FontPlatformData::FontPlatformData): Eliminate qRound(int).
3065         * platform/qt/PlatformScreenQt.cpp:
3066         (WebCore::screenDepthPerComponent): Ditto.
3067
3068 2011-07-20  Ryosuke Niwa  <rniwa@webkit.org>
3069
3070         Fix a Valgrind failure caused by r91435.
3071
3072         * platform/ScrollableArea.cpp:
3073         (WebCore::ScrollableArea::ScrollableArea):
3074
3075 2011-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3076
3077         Unreviewed, rolling out r91332.
3078         http://trac.webkit.org/changeset/91332
3079         https://bugs.webkit.org/show_bug.cgi?id=64925
3080
3081         Crashes css3/images/optimize-contrast-canvas.html on safari-
3082         mac,chromium-mac (Requested by mikelawther on #webkit).
3083
3084         * html/HTMLCanvasElement.cpp:
3085         (WebCore::HTMLCanvasElement::makePresentationCopy):
3086         (WebCore::HTMLCanvasElement::copiedImage):
3087         * html/canvas/WebGLRenderingContext.cpp:
3088         (WebCore::WebGLRenderingContext::videoFrameToImage):
3089         * platform/graphics/GraphicsContext.cpp:
3090         (WebCore::GraphicsContext::drawImage):
3091         * platform/graphics/GraphicsContext.h:
3092         * platform/graphics/Image.h:
3093         * platform/graphics/ImageBuffer.h:
3094         * platform/graphics/cairo/ImageBufferCairo.cpp:
3095         (WebCore::ImageBuffer::copyImage):
3096         * platform/graphics/cg/GraphicsContextCG.cpp:
3097         * platform/graphics/cg/ImageBufferCG.cpp:
3098         (WebCore::ImageBuffer::copyImage):
3099         (WebCore::cgImage):
3100         (WebCore::ImageBuffer::draw):
3101         (WebCore::ImageBuffer::drawPattern):
3102         (WebCore::ImageBuffer::clip):
3103         (WebCore::ImageBuffer::toDataURL):
3104         * platform/graphics/cg/ImageCG.cpp:
3105         (WebCore::imageWithColorSpace):
3106         (WebCore::BitmapImage::draw):
3107         (WebCore::Image::drawPattern):
3108         * platform/graphics/filters/FETile.cpp:
3109         (WebCore::FETile::apply):
3110         * platform/graphics/qt/ImageBufferQt.cpp:
3111         (WebCore::ImageBuffer::copyImage):
3112         (WebCore::ImageBuffer::draw):
3113         (WebCore::ImageBuffer::drawPattern):
3114         * platform/graphics/skia/ImageBufferSkia.cpp:
3115         (WebCore::ImageBuffer::copyImage):
3116         * platform/graphics/wince/ImageBufferWinCE.cpp:
3117         (WebCore::ImageBuffer::copyImage):
3118         (WebCore::ImageBuffer::draw):
3119         (WebCore::ImageBuffer::drawPattern):
3120         * platform/graphics/wx/ImageBufferWx.cpp:
3121         (WebCore::ImageBuffer::copyImage):
3122         (WebCore::ImageBuffer::draw):
3123         (WebCore::ImageBuffer::drawPattern):
3124         * rendering/svg/RenderSVGResourcePattern.cpp:
3125         (WebCore::RenderSVGResourcePattern::applyResource):
3126         * svg/SVGFEImageElement.cpp:
3127         (WebCore::SVGFEImageElement::build):
3128         * svg/graphics/SVGImage.cpp:
3129         (WebCore::SVGImage::nativeImageForCurrentFrame):
3130
3131 2011-07-20  Ryosuke Niwa  <rniwa@webkit.org>
3132
3133         Chromium build fix after r91440.
3134
3135         * platform/chromium/ScrollbarThemeChromiumMac.mm:
3136         (WebCore::ScrollbarThemeChromiumMac::paint):
3137
3138 2011-07-20  Ryosuke Niwa  <rniwa@webkit.org>
3139
3140         Build fix after r91435.
3141
3142         * platform/mac/ScrollViewMac.mm:
3143         (WebCore::ScrollView::platformSetScrollbarOverlayStyle):
3144
3145 2011-07-20  Tim Horton  <timothy_horton@apple.com>
3146
3147         Reviewed by Darin Adler.
3148
3149         Errors encountered within SVG documents should be reported to the console
3150         https://bugs.webkit.org/show_bug.cgi?id=62599
3151         <rdar://problem/9727074>
3152
3153         Add SVGLength::construct, which can be used to construct an SVGLength
3154         as normal, but returns an SVGParsingError via a reference argument.
3155         The function also takes another argument, which is whether or not
3156         the SVGLength value is allowed to be negative. If not, an error is
3157         thrown. It defaults to allowing negatives if not specified.
3158
3159         * GNUmakefile.list.am:
3160         * svg/SVGLength.cpp:
3161         (WebCore::SVGLength::construct):
3162         (WebCore::SVGLength::rawValue):
3163         * svg/SVGLength.h:
3164         * svg/SVGElement.h:
3165         * svg/SVGParsingError.h: Added.
3166         * WebCore.gypi:
3167         * WebCore.pro:
3168         * WebCore.vcproj/WebCore.vcproj:
3169         * WebCore.xcodeproj/project.pbxproj:
3170
3171 2011-07-20  Levi Weintraub  <leviw@chromium.org>
3172
3173         Switch getTransformFromContainer and its uses to new layout types
3174         https://bugs.webkit.org/show_bug.cgi?id=64908
3175
3176         Reviewed by Simon Fraser.
3177
3178         Switching getTransformFromContainer and its uses to use the new Layout
3179         Types from strictly integer ones.
3180
3181         No new tests, no new functionality.
3182
3183         * rendering/RenderBox.cpp:
3184         (WebCore::RenderBox::mapLocalToContainer):
3185         * rendering/RenderInline.cpp:
3186         (WebCore::RenderInline::mapLocalToContainer):
3187         * rendering/RenderLayer.cpp:
3188         (WebCore::RenderLayer::createLocalTransformState):
3189         * rendering/RenderObject.cpp:
3190         (WebCore::RenderObject::getTransformFromContainer):
3191         * rendering/RenderObject.h:
3192         * rendering/RenderView.cpp:
3193         (WebCore::RenderView::mapLocalToContainer):
3194         (WebCore::RenderView::mapAbsoluteToLocalPoint):
3195
3196 2011-07-20  Tim Horton  <timothy_horton@apple.com>
3197
3198         Scrollbar color heuristic needs to be hooked up in WebKit1
3199         https://bugs.webkit.org/show_bug.cgi?id=64220
3200         <rdar://problem/9589140>
3201
3202         Reviewed by Darin Adler.
3203
3204         Store the scroller style on ScrollableArea, and recompute it whenever
3205         the document or body element background color changes or the base background
3206         color of the scrollview changes. Also, make sure to repaint the scrollbars
3207         whenever the style changes.
3208
3209         No new tests, since this code is only enabled on future versions of Mac OS X.
3210
3211         * WebCore.exp.in:
3212         * page/Frame.cpp:
3213         (WebCore::Frame::getDocumentBackgroundColor):
3214         * page/Frame.h:
3215         * page/FrameView.cpp:
3216         (WebCore::FrameView::recalculateScrollbarOverlayStyle):
3217         (WebCore::FrameView::setBaseBackgroundColor):
3218         (WebCore::FrameView::documentBackgroundColor): Renamed.
3219         * page/FrameView.h:
3220         * platform/ScrollView.cpp:
3221         (WebCore::ScrollView::setScrollbarOverlayStyle):
3222         * platform/ScrollView.h:
3223         * platform/ScrollableArea.cpp:
3224         (WebCore::ScrollableArea::setScrollbarOverlayStyle):
3225         * platform/ScrollableArea.h:
3226         (WebCore::ScrollableArea::scrollbarOverlayStyle):
3227         * platform/ScrollbarTheme.h:
3228         (WebCore::ScrollbarTheme::updateScrollbarOverlayStyle):
3229         * platform/mac/ScrollViewMac.mm:
3230         (WebCore::toNSScrollerKnobStyle):
3231         (WebCore::ScrollView::platformSetScrollbarOverlayStyle):
3232         * platform/mac/ScrollbarThemeMac.h:
3233         * platform/mac/ScrollbarThemeMac.mm:
3234         (WebCore::toScrollbarPainterKnobStyle):
3235         (WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
3236         (WebCore::ScrollbarThemeMac::paint):
3237         * rendering/RenderBox.cpp:
3238         (WebCore::RenderBox::styleDidChange):
3239
3240 2011-07-20  Luke Macpherson   <macpherson@chromium.org>
3241
3242         Implement CSSPropertyWebkitTransformOriginZ and Origin in CSSStyleApplyProperty.
3243         https://bugs.webkit.org/show_bug.cgi?id=64785
3244         Note that this changes a cast from
3245           computed length double -> 28 bit int -> float
3246         to
3247           computed length double -> float
3248         I couldn't see any reason in the code that this was strictly necessary,
3249         however it may have been so that X,Y,Z all have the same behavior, even though Z itself is not stored in a Length.
3250
3251         Reviewed by Simon Fraser.
3252
3253         No new tests / refactoring.
3254
3255         * css/CSSStyleApplyProperty.cpp:
3256         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
3257         * css/CSSStyleSelector.cpp:
3258         (WebCore::CSSStyleSelector::applyProperty):
3259
3260 2011-07-20  Tony Chang  <tony@chromium.org>
3261
3262         Remove stray reference to StyleFlexibleBoxData.h that was accidentally
3263         added in r91402.
3264
3265         * WebCore.xcodeproj/project.pbxproj:
3266
3267 2011-07-20  Levi Weintraub  <leviw@chromium.org>
3268
3269         Bring Int/Float graphics classes closer to parity
3270         https://bugs.webkit.org/show_bug.cgi?id=64833
3271
3272         Reviewed by James Robinson.
3273
3274         In preparation of switching to Floating point data structures, bringing the
3275         functionality and method names of the Int/Float graphics classes close together.
3276
3277         Also fixing some compiler errors when using Floats for layout units along the way.
3278
3279         No new tests, no functionality change.
3280
3281         * page/FrameView.cpp:
3282         (WebCore::FrameView::convertFromRenderer):
3283         * platform/ScrollView.cpp:
3284         (WebCore::ScrollView::wheelEvent):
3285         * platform/ScrollView.h:
3286         (WebCore::ScrollView::convertChildToSelf):
3287         (WebCore::ScrollView::convertSelfToChild):
3288         * platform/graphics/FloatPoint.h:
3289         (WebCore::operator-): Adding a single-parameter version.
3290         * platform/graphics/FloatSize.cpp:
3291         (WebCore::FloatSize::isZero): Adding isZero that uses epsilon for floats.
3292         * platform/graphics/FloatSize.h:
3293         * platform/graphics/IntPoint.h:
3294         (WebCore::IntPoint::moveBy): Renaming IntPoint version to moveBy to mirror FloatPoint.
3295         * platform/graphics/RoundedRect.cpp:
3296         (WebCore::RoundedRect::Radii::expand): Switching to specific templatized max.
3297         * platform/graphics/filters/FilterEffect.cpp:
3298         (WebCore::FilterEffect::requestedRegionOfInputImageData):
3299         * rendering/RenderBlock.cpp: Moving outstanding Int* functions to Layout units.
3300         (WebCore::RenderBlock::paintContinuationOutlines):
3301         (WebCore::RenderBlock::logicalRectToPhysicalRect):
3302         * rendering/RenderBlock.h:
3303         * rendering/RenderBox.cpp:
3304         (WebCore::RenderBox::positionForPoint):
3305         * rendering/RenderTable.cpp:
3306         (WebCore::RenderTable::subtractCaptionRect):
3307         * rendering/RenderTable.h:
3308         * rendering/RenderTableCell.cpp:
3309         (WebCore::RenderTableCell::styleOrColLogicalWidth):
3310         (WebCore::RenderTableCell::setOverrideSizeFromRowHeight):
3311         (WebCore::RenderTableCell::paintCollapsedBorder):
3312         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
3313         * rendering/RenderTableCell.h:
3314         * rendering/RenderView.h:
3315         (WebCore::RenderView::pushLayoutState):
3316         (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
3317         (WebCore::LayoutStateMaintainer::push):
3318         * rendering/RootInlineBox.cpp:
3319         (WebCore::RootInlineBox::paddedLayoutOverflowRect):
3320         (WebCore::setAscentAndDescent):
3321         * rendering/RootInlineBox.h:
3322
3323 2011-07-20  Scott Graham  <scottmg@chromium.org>
3324
3325         mouseover reporting incorrect mouse button, when the button isn't
3326         down. https://bugs.webkit.org/show_bug.cgi?id=64882
3327
3328         Reviewed by Eric Seidel.
3329
3330         Don't increment the button returned in 'which' unless the button is
3331         actually down.
3332
3333         Test: fast/events/mouseover-button.html
3334
3335         * dom/MouseEvent.cpp:
3336         (WebCore::MouseEvent::which):
3337
3338 2011-07-20  Kenneth Russell  <kbr@google.com>
3339
3340         Add restoreContext() to WEBKIT_lose_context
3341         https://bugs.webkit.org/show_bug.cgi?id=58626
3342
3343         Reviewed by James Robinson.
3344
3345         Added the restoreContext() entry point to the WEBKIT_lose_context
3346         extension. Refactored and simplified the logic associated with context
3347         loss and restoration.
3348
3349         A subsequent patch will make the delivery of the webglcontextrestored
3350         event spec compliant.
3351
3352         * html/canvas/WebGLRenderingContext.cpp:
3353         (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
3354         (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback):
3355         (WebCore::WebGLRenderingContextLostCallback::onContextLost):
3356         (WebCore::WebGLRenderingContext::isContextLost):
3357         (WebCore::WebGLRenderingContext::forceLostContext):
3358         (WebCore::WebGLRenderingContext::forceRestoreContext):
3359         (WebCore::WebGLRenderingContext::loseContext):
3360         (WebCore::WebGLRenderingContext::maybeRestoreContext):
3361         * html/canvas/WebGLRenderingContext.h:
3362         (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::WebGLRenderingContextRestoreTimer):
3363         * html/canvas/WebKitLoseContext.cpp:
3364         (WebCore::WebKitLoseContext::loseContext):
3365         (WebCore::WebKitLoseContext::restoreContext):
3366         * html/canvas/WebKitLoseContext.h:
3367         * html/canvas/WebKitLoseContext.idl:
3368
3369 2011-07-20  Tony Chang  <tony@chromium.org>
3370
3371         Pass -webkit-flex() values on to RenderStyle
3372         https://bugs.webkit.org/show_bug.cgi?id=64038
3373
3374         Reviewed by Eric Seidel.
3375
3376         No new tests, this just copies data to RenderStyle, which we can
3377         then access when doing layout.  Tests will come with the layout
3378         changes.
3379
3380         * css/CSSStyleApplyProperty.cpp:
3381         (WebCore::ApplyPropertyLength::applyValue):
3382         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
3383
3384 2011-07-20  Daniel Bates  <dbates@rim.com>
3385
3386         Attempt to fix the GTK build after changeset 91396 <http://trac.webkit.org/changeset/91396>
3387         (https://bugs.webkit.org/show_bug.cgi?id=64764).
3388
3389         * xml/parser/MarkupTokenBase.h: #include <stdio.h> in debug build for printf(3), which is used in
3390         MarkupTokenBase::printString() and MarkupTokenBase::printAttrs().
3391
3392 2011-07-19  Vsevolod Vlasov  <vsevik@chromium.org>
3393
3394         Web Inspector: Add support for disabling cache in web inspector.
3395         https://bugs.webkit.org/show_bug.cgi?id=64097
3396
3397         Reviewed by Pavel Feldman.
3398
3399         Tests: http/tests/inspector/network/network-disable-cache-memory.html
3400                http/tests/inspector/network/network-disable-cache-xhrs.html
3401
3402         * English.lproj/localizedStrings.js:
3403         * inspector/Inspector.json:
3404         * inspector/InspectorClient.h:
3405         (WebCore::InspectorClient::setCacheDisabled):
3406         * inspector/InspectorResourceAgent.cpp:
3407         (WebCore::InspectorResourceAgent::willSendRequest):
3408         (WebCore::InspectorResourceAgent::enable):
3409         (WebCore::InspectorResourceAgent::disable):
3410         (WebCore::InspectorResourceAgent::setCacheDisabled):
3411         * inspector/InspectorResourceAgent.h:
3412         * inspector/front-end/NetworkManager.js:
3413         (WebInspector.NetworkManager.prototype.inflightResourceForURL):
3414         (WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
3415         * inspector/front-end/Settings.js:
3416         (WebInspector.Settings):
3417         * inspector/front-end/SettingsScreen.js:
3418         (WebInspector.SettingsScreen):
3419
3420 2011-07-20  Peter Kasting  <pkasting@google.com>
3421
3422         Remove "const" from obviously-non-const accessors
3423         https://bugs.webkit.org/show_bug.cgi?id=62302
3424
3425         Reviewed by Darin Adler.
3426
3427         No functional change, so no new tests.
3428
3429         * WebCore.exp.in: Adjust function names to reflect non-constness.
3430         * dom/Element.cpp:
3431         (WebCore::Element::cloneElementWithoutAttributesAndChildren): Not const, calls non-const function Document::createElement().
3432         (WebCore::Element::scrollLeft): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3433         (WebCore::Element::scrollTop): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3434         (WebCore::Element::scrollWidth): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3435         (WebCore::Element::scrollHeight): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3436         (WebCore::Element::boundsInWindowSpace): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3437         (WebCore::Element::getClientRects): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3438         (WebCore::Element::getBoundingClientRect): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3439         (WebCore::Element::innerText): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3440         (WebCore::Element::outerText): Not const, calls newly non-const function Element::innerText().
3441         * dom/Element.h:
3442         * dom/Node.cpp:
3443         (WebCore::Node::isContentEditable): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3444         (WebCore::Node::shouldUseInputMethod): Not const, calls newly non-const function Node::isContentEditable().
3445         * dom/Node.h:
3446         * dom/OptionElement.h: Virtual function OptionElement::selected() not const because HTMLOptionElement implementation is non-const.
3447         * html/HTMLAnchorElement.cpp:
3448         (WebCore::HTMLAnchorElement::text): Not const, calls newly non-const function Element::innerText().
3449         * html/HTMLAnchorElement.h:
3450         * html/HTMLAppletElement.cpp:
3451         (WebCore::HTMLAppletElement::renderWidgetForJSBindings): Not const, calls non-const function RenderApplet::createWidgetIfNecessary().
3452         * html/HTMLAppletElement.h:
3453         * html/HTMLAreaElement.cpp:
3454         (WebCore::HTMLAreaElement::imageElement): Not const, calls newly non-const function HTMLMapElement::imageElement().
3455         * html/HTMLAreaElement.h:
3456         * html/HTMLBodyElement.cpp:
3457         (WebCore::HTMLBodyElement::scrollLeft): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3458         (WebCore::HTMLBodyElement::scrollTop): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3459         (WebCore::HTMLBodyElement::scrollHeight): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3460         (WebCore::HTMLBodyElement::scrollWidth): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3461         * html/HTMLBodyElement.h:
3462         * html/HTMLEmbedElement.cpp:
3463         (WebCore::HTMLEmbedElement::renderWidgetForJSBindings): Not const, calls non-const function Document::createElement().
3464         * html/HTMLEmbedElement.h:
3465         * html/HTMLFrameElementBase.cpp:
3466         (WebCore::HTMLFrameElementBase::width): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3467         (WebCore::HTMLFrameElementBase::height): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3468         * html/HTMLFrameElementBase.h:
3469         * html/HTMLImageElement.cpp:
3470         (WebCore::HTMLImageElement::width): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3471         (WebCore::HTMLImageElement::height): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3472         * html/HTMLImageElement.h:
3473         * html/HTMLInputElement.cpp:
3474         (WebCore::HTMLInputElement::shouldUseInputMethod): Virtual function not const because Node implementation is non-const.
3475         * html/HTMLInputElement.h:
3476         * html/HTMLKeygenElement.cpp:
3477         (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Virtual function not const because Element implementation is non-const.
3478         * html/HTMLMapElement.cpp:
3479         (WebCore::HTMLMapElement::imageElement): Not const, calls non-const function Document::images().
3480         * html/HTMLMapElement.h:
3481         * html/HTMLObjectElement.cpp:
3482         (WebCore::HTMLObjectElement::renderWidgetForJSBindings): Not const, calls non-const function Document::updateLayoutIgnorePendingStylesheets().
3483         * html/HTMLObjectElement.h:
3484         * html/HTMLOptionElement.cpp:
3485         (WebCore::HTMLOptionElement::selected): Not const, calls non-const function HTMLSelectElement::recalcListItemsIfNeeded().
3486         * html/HTMLOptionElement.h:
3487         * html/HTMLPlugInElement.cpp: Virtual function HTMLPlugInElement::renderWidgetForJSBindings() not const because various subclass implementations are non-const.
3488         (WebCore::HTMLPlugInElement::getInstance): Not const, calls newly non-const function HTMLPlugInElement::pluginWidget().
3489         (WebCore::HTMLPlugInElement::pluginWidget): Not const, calls newly non-const function HTMLPlugInElement::renderWidgetForJSBindings().
3490         * html/HTMLPlugInElement.h:
3491         * html/HTMLScriptElement.cpp:
3492         (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Virtual function not const because Element implementation is non-const.
3493         * html/HTMLScriptElement.h:
3494         * html/HTMLTextAreaElement.cpp:
3495         (WebCore::HTMLTextAreaElement::shouldUseInputMethod): Virtual function not const because Node implementation is non-const.
3496         * html/HTMLTextAreaElement.h:
3497         * html/shadow/SliderThumbElement.h:
3498         (