Move Source/WebCore/rendering/ code to std::unique_ptr
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2014-03-23  Zan Dobersek  <zdobersek@igalia.com>
2
3         Move Source/WebCore/rendering/ code to std::unique_ptr
4         https://bugs.webkit.org/show_bug.cgi?id=129664
5
6         Reviewed by Anders Carlsson.
7
8         Replace uses of OwnPtr and PassOwnPtr in code under Source/WebCore/rendering/ with std::unique_ptr.
9
10         * platform/graphics/FloatPolygon.cpp:
11         (WebCore::FloatPolygon::FloatPolygon):
12         * platform/graphics/FloatPolygon.h:
13         * rendering/ClipPathOperation.h:
14         * rendering/FlowThreadController.cpp:
15         (WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
16         * rendering/FlowThreadController.h:
17         * rendering/HitTestLocation.h:
18         * rendering/HitTestResult.cpp:
19         (WebCore::HitTestResult::HitTestResult):
20         (WebCore::HitTestResult::operator=):
21         (WebCore::HitTestResult::rectBasedTestResult):
22         (WebCore::HitTestResult::mutableRectBasedTestResult):
23         * rendering/HitTestResult.h:
24         * rendering/HitTestingTransformState.cpp:
25         * rendering/ImageQualityController.h:
26         * rendering/RenderBlock.cpp:
27         (WebCore::removeBlockFromDescendantAndContainerMaps):
28         (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
29         (WebCore::RenderBlock::addContinuationWithOutline):
30         (WebCore::RenderBlock::paintContinuationOutlines):
31         (WebCore::RenderBlock::insertIntoTrackedRendererMaps):
32         (WebCore::RenderBlock::removeFromTrackedRendererMaps):
33         (WebCore::RenderBlock::setComputedColumnCountAndWidth):
34         * rendering/RenderBlock.h:
35         * rendering/RenderBlockFlow.cpp:
36         (WebCore::RenderBlockFlow::createFloatingObjects):
37         * rendering/RenderBlockFlow.h:
38         * rendering/RenderBoxRegionInfo.h:
39         * rendering/RenderButton.cpp:
40         (WebCore::RenderButton::styleDidChange):
41         * rendering/RenderButton.h:
42         * rendering/RenderCounter.cpp:
43         (WebCore::makeCounterNode):
44         * rendering/RenderFlowThread.cpp:
45         (WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
46         (WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
47         * rendering/RenderFlowThread.h:
48         * rendering/RenderGeometryMap.cpp:
49         (WebCore::RenderGeometryMap::push):
50         (WebCore::RenderGeometryMap::pushView):
51         * rendering/RenderGeometryMap.h:
52         * rendering/RenderGrid.cpp:
53         (WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
54         (WebCore::RenderGrid::placeItemsOnGrid):
55         (WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
56         (WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
57         (WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
58         (WebCore::RenderGrid::resolveGridPositionsFromStyle):
59         (WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition):
60         (WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition):
61         (WebCore::RenderGrid::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
62         (WebCore::RenderGrid::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
63         * rendering/RenderGrid.h:
64         * rendering/RenderImageResource.h:
65         * rendering/RenderLayer.cpp:
66         (WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
67         (WebCore::RenderLayer::updateTransform):
68         (WebCore::RenderLayer::setupFilters):
69         (WebCore::RenderLayer::paintLayerContents):
70         (WebCore::RenderLayer::paintChildLayerIntoColumns):
71         (WebCore::RenderLayer::hitTestChildLayerColumns):
72         (WebCore::RenderLayer::updateClipRects):
73         (WebCore::RenderLayer::calculateClipRects):
74         * rendering/RenderLayer.h:
75         (WebCore::RenderLayer::clearZOrderLists):
76         * rendering/RenderLayerCompositor.cpp:
77         (WebCore::RenderLayerCompositor::notifyFlushBeforeDisplayRefresh):
78         (WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
79         * rendering/RenderLayerCompositor.h:
80         * rendering/RenderLayerFilterInfo.cpp:
81         (WebCore::RenderLayer::FilterInfo::map):
82         (WebCore::RenderLayer::FilterInfo::get):
83         * rendering/RenderLayerFilterInfo.h:
84         * rendering/RenderRegion.cpp:
85         (WebCore::RenderRegion::setRenderBoxRegionInfo):
86         (WebCore::RenderRegion::takeRenderBoxRegionInfo):
87         * rendering/RenderRegion.h:
88         * rendering/RenderTable.cpp:
89         (WebCore::RenderTable::styleDidChange):
90         * rendering/RenderTable.h:
91         * rendering/RenderView.cpp:
92         (WebCore::RenderView::selectionBounds):
93         (WebCore::RenderView::setSelection):
94         (WebCore::RenderView::compositor):
95         (WebCore::RenderView::flowThreadController):
96         (WebCore::RenderView::imageQualityController):
97         * rendering/RenderView.h:
98         * rendering/RootInlineBox.h:
99         (WebCore::RootInlineBox::appendFloat):
100         * rendering/TextAutosizer.h:
101         * rendering/shapes/PolygonShape.cpp:
102         (WebCore::computeShapePaddingBounds):
103         (WebCore::computeShapeMarginBounds):
104         * rendering/shapes/PolygonShape.h:
105         (WebCore::PolygonShape::PolygonShape):
106         * rendering/shapes/RasterShape.cpp:
107         (WebCore::RasterShapeIntervals::computeShapeMarginIntervals):
108         * rendering/shapes/RasterShape.h:
109         (WebCore::RasterShape::RasterShape):
110         * rendering/shapes/Shape.cpp:
111         (WebCore::createInsetShape):
112         (WebCore::createRectangleShape):
113         (WebCore::createCircleShape):
114         (WebCore::createEllipseShape):
115         (WebCore::createPolygonShape):
116         (WebCore::Shape::createShape):
117         (WebCore::Shape::createRasterShape):
118         (WebCore::Shape::createLayoutBoxShape):
119         * rendering/shapes/Shape.h:
120         * rendering/shapes/ShapeInfo.h:
121         (WebCore::ShapeInfo::markShapeAsDirty):
122         (WebCore::ShapeInfo::isShapeDirty):
123         * rendering/shapes/ShapeInsideInfo.h:
124         * rendering/style/ContentData.h:
125         * rendering/style/CounterDirectives.cpp:
126         (WebCore::clone):
127         * rendering/style/CounterDirectives.h:
128         * rendering/style/GridCoordinate.h:
129         * rendering/style/RenderStyle.cpp:
130         (WebCore::RenderStyle::addCachedPseudoStyle):
131         (WebCore::RenderStyle::accessCounterDirectives):
132         (WebCore::RenderStyle::accessAnimations):
133         (WebCore::RenderStyle::accessTransitions):
134         * rendering/style/RenderStyle.h:
135         * rendering/style/StyleRareNonInheritedData.cpp:
136         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
137         * rendering/style/StyleRareNonInheritedData.h:
138         * rendering/svg/RenderSVGResourceGradient.cpp:
139         (WebCore::RenderSVGResourceGradient::applyResource):
140         * rendering/svg/RenderSVGResourceGradient.h:
141         * rendering/svg/RenderSVGResourcePattern.cpp:
142         (WebCore::RenderSVGResourcePattern::buildPattern):
143         * rendering/svg/RenderSVGResourcePattern.h:
144         * rendering/svg/RenderSVGShape.cpp:
145         (WebCore::RenderSVGShape::updateShapeFromElement):
146         * rendering/svg/RenderSVGShape.h:
147         * rendering/svg/SVGResources.cpp:
148         (WebCore::SVGResources::setClipper):
149         (WebCore::SVGResources::setFilter):
150         (WebCore::SVGResources::setMarkerStart):
151         (WebCore::SVGResources::setMarkerMid):
152         (WebCore::SVGResources::setMarkerEnd):
153         (WebCore::SVGResources::setMasker):
154         (WebCore::SVGResources::setFill):
155         (WebCore::SVGResources::setStroke):
156         * rendering/svg/SVGResources.h:
157         * rendering/svg/SVGResourcesCache.cpp:
158         (WebCore::SVGResourcesCache::addResourcesFromRenderer):
159         (WebCore::SVGResourcesCache::removeResourcesFromRenderer):
160         * rendering/svg/SVGResourcesCache.h:
161         * rendering/svg/SVGTextMetricsBuilder.cpp:
162         (WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
163         * rendering/svg/SVGTextMetricsBuilder.h:
164
165 2014-03-28  Sergio Villar Senin  <svillar@igalia.com>
166
167         Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in loader
168         https://bugs.webkit.org/show_bug.cgi?id=130893
169
170         Reviewed by Darin Adler.
171
172         * loader/ImageLoader.cpp:
173         (WebCore::beforeLoadEventSender):
174         (WebCore::loadEventSender):
175         (WebCore::errorEventSender):
176         * loader/appcache/ApplicationCacheStorage.cpp:
177         (WebCore::cacheStorage):
178         * loader/appcache/ApplicationCacheStorage.h:
179         * loader/archive/ArchiveFactory.cpp:
180         (WebCore::archiveMIMETypes):
181         * loader/cache/CachedImage.cpp:
182         (WebCore::CachedImage::brokenImage):
183         * loader/cache/CachedRawResource.cpp:
184         (WebCore::shouldIgnoreHeaderForCacheReuse):
185         * loader/cache/MemoryCache.cpp:
186         (WebCore::dummyCachedImageClient):
187
188 2014-03-28  Sergio Villar Senin  <svillar@igalia.com>
189
190         Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in css
191         https://bugs.webkit.org/show_bug.cgi?id=130409
192
193         Reviewed by Darin Adler.
194
195         * css/CSSComputedStyleDeclaration.cpp:
196         (WebCore::logUnimplementedPropertyID):
197         * css/CSSDefaultStyleSheets.cpp:
198         (WebCore::screenEval):
199         (WebCore::printEval):
200         * css/CSSParser.cpp:
201         (WebCore::strictCSSParserContext):
202         * css/CSSPrimitiveValue.cpp:
203         (WebCore::cssTextCache):
204         * css/CSSProperty.cpp:
205         (WebCore::borderDirections):
206         * css/CSSStyleRule.cpp:
207         (WebCore::selectorTextCache):
208         * css/CSSValuePool.cpp:
209         (WebCore::cssValuePool):
210         * css/CSSValuePool.h:
211         * css/DeprecatedStyleBuilder.cpp:
212         (WebCore::ApplyPropertyPageSize::getPageSizeFromName):
213         (WebCore::DeprecatedStyleBuilder::sharedStyleBuilder):
214         * css/DeprecatedStyleBuilder.h:
215
216 2014-03-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
217
218         [GTK] [TextureMapper] Weird brightness with some videos with acceletared compositing
219         https://bugs.webkit.org/show_bug.cgi?id=130665
220
221         Reviewed by Martin Robinson.
222
223         When we uploaded a video texture to the mapper we were not
224         considering that some videos could be decoded into a format
225         without alpha component. Now we check if the video has alpha and
226         if it does not, we remove the alpha flag when retrieving the
227         texture from the pool. For this, the method to get the texture
228         from the pool was modified to receive the flags, that is mapped to
229         have alpha by default in order not to break any other existing
230         code.
231
232         Though we have a problem with AC in WTR and that makes it
233         currently not testable, no new tests are needed because once this
234         is fixed the current test set suffices to detect a possible
235         regression in this.
236
237         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
238         (WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): Check
239         the video format and decide if the texture shall be pulled with
240         alpha support or not.
241         * platform/graphics/texmap/TextureMapper.cpp:
242         (WebCore::TextureMapper::acquireTextureFromPool): Use the flags
243         when resetting the texture.
244         * platform/graphics/texmap/TextureMapper.h:
245         (WebCore::BitmapTexture::Flag::None): Added with 0x00.
246         (WebCore::TextureMapper::acquireTextureFromPool): Added flag
247         parameter to set up the texture with the default for including
248         alpha channel.
249
250 2014-03-30  Jinwoo Song  <jinwoo7.song@samsung.com>
251
252         Adopt range-based for loops to TextCheckerEnchant
253         https://bugs.webkit.org/show_bug.cgi?id=130714
254
255         Reviewed by Darin Adler.
256
257         * platform/text/enchant/TextCheckerEnchant.cpp:
258         (WebCore::TextCheckerEnchant::ignoreWord):
259         (WebCore::TextCheckerEnchant::learnWord):
260         (WebCore::TextCheckerEnchant::checkSpellingOfWord):
261         (WebCore::TextCheckerEnchant::getGuessesForWord):
262         (WebCore::TextCheckerEnchant::updateSpellCheckingLanguages):
263         (WebCore::TextCheckerEnchant::loadedSpellCheckingLanguages):
264         (WebCore::TextCheckerEnchant::availableSpellCheckingLanguages):
265         (WebCore::TextCheckerEnchant::freeEnchantBrokerDictionaries):
266
267 2014-03-30  Benjamin Poulain  <benjamin@webkit.org>
268
269         Second attempt to fix 32bits build after r166465
270
271         * rendering/style/RenderStyle.h:
272         The compiler probably complain about the return value, that makes more sense.
273
274 2014-03-30  Benjamin Poulain  <benjamin@webkit.org>
275
276         Attempt to fix 32bits build after r166465
277
278         * rendering/style/RenderStyle.h:
279
280 2014-03-30  Benjamin Poulain  <benjamin@webkit.org>
281
282         Make RenderStyle's non inherited flags more JSC friendly
283         https://bugs.webkit.org/show_bug.cgi?id=130939
284
285         Reviewed by Andreas Kling.
286
287         Make RenderStyle::NonInheritedFlags accessible to the JIT:
288         -Make the struct public to give access to the offset.
289         -Move away from a bit field to static offsets we can use
290          with the MacroAssembler.
291         -Reorder the field to simplify bit access of the flags we need.
292
293         * css/DeprecatedStyleBuilder.cpp:
294         (WebCore::ApplyPropertyVerticalAlign::createHandler):
295         (WebCore::ApplyPropertyDisplay::applyInitialValue):
296         (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
297         * css/StyleResolver.cpp:
298         (WebCore::StyleResolver::adjustRenderStyle):
299         * rendering/style/RenderStyle.cpp:
300         (WebCore::RenderStyle::RenderStyle):
301         (WebCore::RenderStyle::copyNonInheritedFrom):
302         (WebCore::RenderStyle::hashForTextAutosizing):
303         (WebCore::RenderStyle::equalForTextAutosizing):
304         (WebCore::RenderStyle::changeRequiresLayout):
305         * rendering/style/RenderStyle.h:
306         (WebCore::RenderStyle::hasAnyPublicPseudoStyles):
307         (WebCore::RenderStyle::hasPseudoStyle):
308         (WebCore::RenderStyle::setHasPseudoStyle):
309         * rendering/style/StyleMultiColData.cpp:
310         (WebCore::StyleMultiColData::StyleMultiColData):
311         * rendering/style/StyleRareNonInheritedData.cpp:
312         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
313
314 2014-03-30  David Kilzer  <ddkilzer@apple.com>
315
316         [iOS] Fix build of HTMLConverter.mm after r166454
317
318         Fixes the following build failures:
319
320             WebCore/editing/cocoa/HTMLConverter.mm:1507:13: error: value of type 'WebCore::Element' is not contextually convertible to 'bool'
321                     if (element)
322                         ^~~~~~~
323             WebCore/editing/cocoa/HTMLConverter.mm:1508:49: error: no matching function for call to 'core'
324                         _caches->floatPropertyValueForNode(*core(element), CSSPropertyVerticalAlign, verticalAlign);
325                                                             ^~~~
326             In file included from WebCore/editing/cocoa/HTMLConverter.mm:41:
327             In file included from WebCore/page/Frame.h:42:
328             In file included from WebCore/editing/VisibleSelection.h:30:
329             In file included from WebCore/editing/VisiblePosition.h:30:
330             In file included from WebCore/dom/Position.h:31:
331             WebCore/editing/TextAffinity.h:54:27: note: candidate function not viable: no known conversion from 'WebCore::Element' to 'NSSelectionAffinity' (aka '_NSSelectionAffinity') for 1st argument
332             inline WebCore::EAffinity core(NSSelectionAffinity affinity)
333                                       ^
334             WebCore/editing/cocoa/HTMLConverter.mm:1509:81: error: reference to non-static member function must be called; did you mean to call it with no arguments?
335                     attachment.get().bounds = CGRectMake(0, (verticalAlign / 100) * element.clientHeight, element.clientWidth, element.clientHeight);
336                                                                                     ~~~~~~~~^~~~~~~~~~~~
337                                                                                                         ()
338             WebCore/editing/cocoa/HTMLConverter.mm:1509:103: error: reference to non-static member function must be called; did you mean to call it with no arguments?
339                     attachment.get().bounds = CGRectMake(0, (verticalAlign / 100) * element.clientHeight, element.clientWidth, element.clientHeight);
340                                                                                                           ~~~~~~~~^~~~~~~~~~~
341                                                                                                                              ()
342             WebCore/editing/cocoa/HTMLConverter.mm:1509:124: error: reference to non-static member function must be called; did you mean to call it with no arguments?
343                     attachment.get().bounds = CGRectMake(0, (verticalAlign / 100) * element.clientHeight, element.clientWidth, element.clientHeight);
344                                                                                                                                ~~~~~~~~^~~~~~~~~~~~
345                                                                                                                                                    ()
346             5 errors generated.
347
348         * editing/cocoa/HTMLConverter.mm:
349         (HTMLConverter::_addAttachmentForElement):
350
351 2014-03-30  Andreas Kling  <akling@apple.com>
352
353         Make NodeList and HTMLCollection caching helpers use PassRef.
354         <https://webkit.org/b/130943>
355
356         Tweak the helpers in NodeListsNodeData to return PassRef instead of
357         PassRefPtr. This knocks 2 branches off of some pretty hot code on
358         Dromaeo/dom-query.
359
360         Reviewed by Antti Koivisto.
361
362         * dom/ChildNodeList.h:
363         * dom/ClassNodeList.h:
364         * dom/NameNodeList.h:
365         * dom/NodeRareData.h:
366         (WebCore::NodeListsNodeData::ensureChildNodeList):
367         (WebCore::NodeListsNodeData::ensureEmptyChildNodeList):
368         (WebCore::NodeListsNodeData::addCacheWithAtomicName):
369         (WebCore::NodeListsNodeData::addCacheWithName):
370         (WebCore::NodeListsNodeData::addCacheWithQualifiedName):
371         (WebCore::NodeListsNodeData::addCachedCollection):
372         * dom/TagNodeList.h:
373         * html/HTMLCollection.cpp:
374         (WebCore::HTMLCollection::create):
375         * html/HTMLCollection.h:
376         * html/HTMLFormControlsCollection.cpp:
377         (WebCore::HTMLFormControlsCollection::create):
378         * html/HTMLFormControlsCollection.h:
379         * html/RadioNodeList.h:
380
381 2014-03-29  Antti Koivisto  <antti@apple.com>
382
383         LiveNodeLists should use ElementDescendantIterator
384         https://bugs.webkit.org/show_bug.cgi?id=130931
385
386         Reviewed by Andreas Kling.
387         
388         Make LiveNodeList traversal use the common DOM tree iterator.
389
390         * dom/ChildNodeList.cpp:
391         (WebCore::ChildNodeList::ChildNodeList):
392         (WebCore::ChildNodeList::collectionBegin):
393         (WebCore::ChildNodeList::collectionTraverseForward):
394         (WebCore::ChildNodeList::collectionTraverseBackward):
395         (WebCore::ChildNodeList::invalidateCache):
396         (WebCore::ChildNodeList::collectionFirst): Deleted.
397         
398             Iterator for ChildNodeList is still just Node*.
399
400         * dom/ChildNodeList.h:
401         * dom/CollectionIndexCache.h:
402         (WebCore::CollectionIndexCache::hasValidCache):
403         (WebCore::Iterator>::CollectionIndexCache):
404         (WebCore::Iterator>::nodeCount):
405         (WebCore::Iterator>::computeNodeCountUpdatingListCache):
406         (WebCore::Iterator>::traverseBackwardTo):
407         (WebCore::Iterator>::traverseForwardTo):
408         (WebCore::Iterator>::nodeAt):
409         (WebCore::Iterator>::invalidate):
410         
411             Make CollectionIndexCache iterator based instead of using NodeType*. The iterator type may
412             still be a Node* though.
413
414         (WebCore::NodeType>::CollectionIndexCache): Deleted.
415         (WebCore::NodeType>::nodeCount): Deleted.
416         (WebCore::NodeType>::computeNodeCountUpdatingListCache): Deleted.
417         (WebCore::NodeType>::nodeBeforeCached): Deleted.
418         (WebCore::NodeType>::nodeAfterCached): Deleted.
419         (WebCore::NodeType>::nodeAt): Deleted.
420         (WebCore::NodeType>::invalidate): Deleted.
421         * dom/ElementDescendantIterator.h:
422         (WebCore::ElementDescendantIterator::operator--):
423         
424             Add backward iteration support.
425
426         (WebCore::ElementDescendantIteratorAdapter::last):
427         (WebCore::ElementDescendantConstIteratorAdapter::last):
428         
429             Add a way to get the last item.
430             Provide std::iterator_traits so we can extract the type.
431
432         * dom/LiveNodeList.h:
433         (WebCore::CachedLiveNodeList::collectionEnd):
434         (WebCore::CachedLiveNodeList<NodeListType>::CachedLiveNodeList):
435         (WebCore::CachedLiveNodeList<NodeListType>::~CachedLiveNodeList):
436         (WebCore::CachedLiveNodeList<NodeListType>::collectionBegin):
437         (WebCore::CachedLiveNodeList<NodeListType>::collectionLast):
438         (WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseForward):
439         (WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseBackward):
440         (WebCore::CachedLiveNodeList<NodeListType>::invalidateCache):
441         (WebCore::CachedLiveNodeList<NodeListType>::collectionFirst): Deleted.
442         
443             Make LiveNodeList traversal use ElementDescendantIterator.
444
445         (WebCore::nextMatchingElement): Deleted.
446         (WebCore::previousMatchingElement): Deleted.
447         * html/HTMLCollection.cpp:
448         (WebCore::HTMLCollection::HTMLCollection):
449         (WebCore::HTMLCollection::~HTMLCollection):
450         (WebCore::HTMLCollection::collectionBegin):
451         (WebCore::HTMLCollection::collectionTraverseForward):
452         (WebCore::HTMLCollection::collectionTraverseBackward):
453         (WebCore::HTMLCollection::invalidateCache):
454         (WebCore::HTMLCollection::collectionFirst): Deleted.
455         * html/HTMLCollection.h:
456         (WebCore::HTMLCollection::collectionEnd):
457         
458             HTMLCollection still uses Element* as iterator for now.
459
460 2014-03-29  Commit Queue  <commit-queue@webkit.org>
461
462         Unreviewed, rolling out r166434.
463         https://bugs.webkit.org/show_bug.cgi?id=130938
464
465         Caused crashes and other failures on cache tests (Requested by
466         ap on #webkit).
467
468         Reverted changeset:
469
470         "Web Replay: add page-level setting to bypass the MemoryCache"
471         https://bugs.webkit.org/show_bug.cgi?id=130728
472         http://trac.webkit.org/changeset/166434
473
474 2014-03-29  David Kilzer  <ddkilzer@apple.com>
475
476         Preserve selection end positions in directionOfSelection
477         <http://webkit.org/b/104813>
478         <rdar://problem/13666417>
479
480         Reviewed by Brent Fulgham.
481
482         Merged from Blink (patch by kenrb@chromium.org):
483         https://src.chromium.org/viewvc/blink?revision=150621&view=revision
484         http://crbug.com/164263
485
486             VisibleSelection::visibleStart() and VisibleSelection::visibleEnd()
487             can both cause layouts, which has the potential to invalidate any
488             rendertree-based objects. This was causing a problem in
489             FrameSelection::directionOfSelection(), where a reference to a
490             lineBox was being held across a call to visibleEnd().
491
492             This patch ensures that the any layout is completed before linebox
493             references are retrieved.
494
495         Test: editing/selection/layout-during-move-selection-crash.html
496
497         * editing/FrameSelection.cpp:
498         (WebCore::FrameSelection::directionOfSelection):
499
500 2014-03-29  Zalan Bujtas  <zalan@apple.com>
501
502         Subpixel rendering: Simple line layout should not round to integral position while painting.
503         https://bugs.webkit.org/show_bug.cgi?id=130934
504
505         Reviewed by Simon Fraser.
506
507         Remove rounding to integral position. When RenderLayer is injected and hides subpixel positions,
508         integral rounding produces different paint position.
509
510         Test: fast/flexbox/hidpi-simple-line-layout-with-flexbox-and-transition.html
511
512         * rendering/SimpleLineLayoutFunctions.cpp:
513         (WebCore::SimpleLineLayout::paintFlow):
514
515 2014-03-29  Zalan Bujtas  <zalan@apple.com>
516
517         Subpixel rendering: Make GraphicsContext::drawImageBuffer* functions float based.
518         https://bugs.webkit.org/show_bug.cgi?id=130932
519
520         Reviewed by Simon Fraser.
521         
522         This is in preparation to support device pixel based filter painting.
523         Filter calculation is still integral based.
524
525         No change in behavior.
526
527         * platform/graphics/GraphicsContext.cpp:
528         (WebCore::GraphicsContext::drawImageBuffer):
529         * platform/graphics/GraphicsContext.h:
530         * platform/graphics/filters/FilterEffect.cpp: This will eventually be fully float based.
531         Right now, this IntRect->FloatRect change is only to ensure that we can call 
532         the float based drawImageBuffer(). 
533         (WebCore::FilterEffect::drawingRegionOfInputImage):
534         * platform/graphics/filters/FilterEffect.h:
535
536 2014-03-27  Sam Weinig  <sam@webkit.org>
537
538         Convert yet more of HTMLConverter to C++
539         https://bugs.webkit.org/show_bug.cgi?id=130850
540
541         Reviewed by Anders Carlsson.
542
543         * editing/cocoa/HTMLConverter.mm:
544         (HTMLConverterCaches::isAncestorsOfStartToBeConverted):
545         (HTMLConverter::HTMLConverter):
546         (HTMLConverter::~HTMLConverter):
547         (HTMLConverter::convert):
548         (HTMLConverter::computedAttributesForElement):
549         (HTMLConverter::attributesForElement):
550         (HTMLConverter::_newParagraphForElement):
551         (HTMLConverter::_newLineForElement):
552         (HTMLConverter::_newTabForElement):
553         (HTMLConverter::_addAttachmentForElement):
554         (HTMLConverter::_addQuoteForElement):
555         (HTMLConverter::_addValue):
556         (HTMLConverter::_processHeadElement):
557         (HTMLConverter::_enterElement):
558         (HTMLConverter::_addTableCellForElement):
559         (HTMLConverter::_processElement):
560         (HTMLConverter::_addMarkersToList):
561         (HTMLConverter::_exitElement):
562         (HTMLConverter::_processText):
563         (HTMLConverter::_traverseNode):
564         (HTMLConverter::_traverseFooterNode):
565         (WebCore::attributedStringFromRange):
566         (_childrenForNode): Deleted.
567         (HTMLConverter::_computedAttributesForElement): Deleted.
568         (HTMLConverter::_attributesForElement): Deleted.
569         (HTMLConverter::_loadFromDOMRange): Deleted.
570
571 2014-03-28  Csaba Osztrogonác  <ossy@webkit.org>
572
573         Unreviewed buildfix after r166441 and r166443.
574
575         * CMakeLists.txt: Add platform/audio/AudioHardwareListener.cpp.
576
577 2014-03-28  Javier Fernandez  <jfernandez@igalia.com>
578
579         [CSS Grid Layout] The 'auto' height must be adapted to the item's margin.
580         https://bugs.webkit.org/show_bug.cgi?id=130920
581
582         Reviewed by Darin Adler.
583
584         Adding the grid-item's marginLogicalHeight to the used breadth when computing
585         content based grid-track sizes.
586
587         Test: fast/css-grid-layout/grid-item-margin-auto-columns-rows.html
588
589         * rendering/RenderGrid.cpp:
590         (WebCore::RenderGrid::logicalContentHeightForChild):
591
592 2014-03-28  James Craig  <jcraig@apple.com>
593
594         Web Inspector: AXI: support for live regions
595         https://bugs.webkit.org/show_bug.cgi?id=130725
596
597         Reviewed by Timothy Hatcher.
598
599         Tests: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
600                inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html
601
602         Initial support for @aria-live, @aria-atomic, and @aria-busy.
603
604         * inspector/InspectorDOMAgent.cpp:
605         (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
606         * inspector/protocol/DOM.json:
607
608 2014-03-28  Darin Adler  <darin@apple.com>
609
610         Fix recently-introduced off-by-one error in centerTruncateToBuffer
611         https://bugs.webkit.org/show_bug.cgi?id=130889
612         <rdar://problem/16408694>
613
614         Reviewed by Alexey Proskuryakov.
615
616         * platform/graphics/StringTruncator.cpp:
617         (WebCore::centerTruncateToBuffer): Simplified expression that computes truncatedLength.
618         Removed incorrect "+ 1" from computation of where to write characters.
619
620 2014-03-28  Benjamin Poulain  <bpoulain@apple.com>
621
622         Update the code related to SelectorPseudoTypeMap to reflect its new purpose
623         https://bugs.webkit.org/show_bug.cgi?id=130620
624
625         Reviewed by Andreas Kling.
626
627         Since r166094, SelectorPseudoTypeMap only contains PseudoClass instances and the 4 compatibility PseudoElement.
628
629         This patch rename SelectorPseudoTypeMap to SelectorPseudoClassAndCompatibilityElementMap and update the parsing
630         to split PseudoClass and PseudoElement.
631
632         * CMakeLists.txt:
633         * DerivedSources.make:
634         * WebCore.xcodeproj/project.pbxproj:
635         * css/CSSGrammar.y.in:
636         * css/CSSParserValues.cpp:
637         (WebCore::CSSParserSelector::parsePseudoClassAndCompatibilityElementSelector):
638         (WebCore::CSSParserSelector::setPseudoClassValue):
639         * css/CSSParserValues.h:
640         * css/CSSSelector.cpp:
641         (WebCore::appendPseudoClassFunctionTail):
642         (WebCore::CSSSelector::selectorText):
643         * css/SelectorPseudoClassAndCompatibilityElementMap.in: Renamed from Source/WebCore/css/SelectorPseudoTypeMap.in.
644         * css/SelectorPseudoTypeMap.h:
645         * css/makeSelectorPseudoClassAndCompatibilityElementMap.py: Renamed from Source/WebCore/css/makeSelectorPseudoTypeMap.py.
646         (enumerablePseudoType):
647         (expand_ifdef_condition):
648
649 2014-03-28  Stephanie Lewis  <slewis@apple.com>
650
651         Unreviewed build fix.
652
653         * platform/audio/AudioHardwareListener.cpp:
654         (WebCore::AudioHardwareListener::create):
655         (WebCore::AudioHardwareListener::audioHardwareListenerIsSupported): Deleted.
656         * platform/audio/AudioHardwareListener.h:
657
658 2014-03-28  Lukasz Bialek  <l.bialek@samsung.com>
659
660         Refactor cut and copy functions as suggested in FIXME line
661         https://bugs.webkit.org/show_bug.cgi?id=129867
662
663         Reviewed by Darin Adler.
664
665         Cut and Copy functions in Editor.cpp use lots of common code.
666         Those functions are merged into one to share code, several
667         additional conditions are added to preserve Cut and Copy
668         functionality.
669
670         * editing/Editor.cpp:
671         (WebCore::Editor::cut):
672         (WebCore::Editor::copy):
673         (WebCore::Editor::performCutOrCopy):
674         * editing/Editor.h:
675
676 2014-03-28  Stephanie Lewis  <slewis@apple.com>
677
678         Rename pluginDidEvaluate to better represent when it’s called.
679         Part of <rdar://problem/16061257> PluginProcess should AppNap when no plugins on active tab.
680
681         Reviewed by Anders Carlsson.
682
683         No new test because it’s just a name change.
684
685         * page/PageThrottler.h:
686         (WebCore::PageThrottler::pluginDidEvaluateWhileAudioIsPlaying):
687
688 2014-03-28  Stephanie Lewis  <slewis@apple.com>
689
690         Notification handler for telling if audio hardware is active.
691         https://bugs.webkit.org/show_bug.cgi?id=130743
692
693         Reviewed by Jer Noble.
694
695         Not web-exposed so no easy way to test.
696
697         Listen to CoreAudio to see if audio hardware is active in the current process.
698
699         * WebCore.exp.in:
700         * WebCore.xcodeproj/project.pbxproj:
701         * platform/audio/AudioHardwareListener.cpp: Added.
702         (WebCore::AudioHardwareListener::create):
703         (WebCore::AudioHardwareListener::AudioHardwareListener):
704         * platform/audio/AudioHardwareListener.h: Added.
705         (WebCore::AudioHardwareListener::Client::~Client):
706         (WebCore::AudioHardwareListener::~AudioHardwareListener):
707         (WebCore::AudioHardwareListener::isHardwareActive):
708         * platform/audio/mac/AudioHardwareListenerMac.cpp: Added.
709         (WebCore::isAudioHardwareProcessRunning):
710         (WebCore::AudioHardwareListener::create):
711         (WebCore::AudioHardwareListenerMac::create):
712         (WebCore::AudioHardwareListenerMac::AudioHardwareListenerMac):
713         (WebCore::AudioHardwareListenerMac::~AudioHardwareListenerMac):
714         (WebCore::AudioHardwareListenerMac::setHardwareActive):
715         * platform/audio/mac/AudioHardwareListenerMac.h: Added.
716
717 2014-03-28  James Craig  <jcraig@apple.com>
718
719         Web Inspector: AXI: expose what elements get generic "clickable" status
720         https://bugs.webkit.org/show_bug.cgi?id=130721
721
722         Reviewed by Timothy Hatcher.
723
724         Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
725         Test: inspector-protocol/dom/getAccessibilityPropertiesForNode_mouseEventNodeId.html
726
727         Expose ancestor element link to "Click Listener" or generic "Clickable: Yes" if current node has mouse handler.
728
729         Update AccessibilityNodeObject::mouseButtonListener() to optionally return body element if 
730             requested so that Web Inspector can display body event delegate handlers.
731
732         * accessibility/AccessibilityNodeObject.cpp:
733         (WebCore::AccessibilityNodeObject::mouseButtonListener):
734         * accessibility/AccessibilityNodeObject.h:
735         * inspector/InspectorDOMAgent.cpp:
736         (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
737         * inspector/protocol/DOM.json:
738
739 2014-03-28  Joseph Pecoraro  <pecoraro@apple.com>
740
741         Web Inspector: Really drop all locks in nested run loop on iOS if WebThread is enabled
742         https://bugs.webkit.org/show_bug.cgi?id=130912
743
744         Reviewed by Geoffrey Garen.
745
746         Previously we were calling DropAllLocks inside of a single line if statement,
747         so the JSLock was getting reaquired very quickly. We really want to DropAllLocks
748         for the duration of running the nested run loop on iOS if there is a WebThread.
749
750         * bindings/js/PageScriptDebugServer.h:
751         * bindings/js/PageScriptDebugServer.cpp:
752         (WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
753         (WebCore::PageScriptDebugServer::runEventLoopWhilePausedInternal):
754
755 2014-03-28  Brent Fulgham  <bfulgham@apple.com>
756
757         [Win] Enable Media Track testing features on Windows
758         https://bugs.webkit.org/show_bug.cgi?id=130851
759
760         Reviewed by Eric Carlson.
761
762         * testing/Internals.cpp:
763         (WebCore::Internals::resetToConsistentState): Execute code on Windows as well.
764         (WebCore::Internals::Internals): Ditto.
765         (WebCore::Internals::captionsStyleSheetOverride): Ditto.
766         (WebCore::Internals::setCaptionsStyleSheetOverride): Ditto.
767         (WebCore::Internals::setPrimaryAudioTrackLanguageOverride): Ditto.
768         (WebCore::Internals::setCaptionDisplayMode): Ditto.
769
770 2014-03-28  Brian Burg  <bburg@apple.com>
771
772         Web Replay: add page-level setting to bypass the MemoryCache
773         https://bugs.webkit.org/show_bug.cgi?id=130728
774
775         Reviewed by Timothy Hatcher.
776
777         When replaying a specific Page we don't want to store its cached resources in the
778         MemoryCache. This patch adds a page setting to prevent the page's resources from
779         being saved in the MemoryCache.
780
781         If Settings::usesMemoryCache() is false, page resources are given the special
782         SessionID bypassCacheSessionID(). The cached resource loader and memory cache
783         act as if the memory cache is disabled if the resource has this special session id.
784
785         Hook up ReplayController to override the memory cache setting during capture/replay.
786
787         Test: http/tests/cache/bypass-memory-cache-after-reload.html
788
789         * loader/cache/CachedResourceLoader.cpp:
790         (WebCore::CachedResourceLoader::requestResource):
791         (WebCore::CachedResourceLoader::revalidateResource):
792         * loader/cache/MemoryCache.cpp:
793         (WebCore::MemoryCache::add):
794         * page/Page.cpp:
795         (WebCore::Page::sessionID):
796         * page/SessionID.h:
797         (WebCore::SessionID::bypassCacheSessionID):
798         * page/Settings.cpp:
799         (WebCore::Settings::Settings):
800         * page/Settings.h:
801         (WebCore::Settings::setUsesMemoryCache):
802         (WebCore::Settings::usesMemoryCache):
803         * replay/ReplayController.cpp:
804         (WebCore::ReplayController::setForceDeterministicSettings):
805         * replay/ReplayController.h:
806         * testing/InternalSettings.cpp:
807         (WebCore::InternalSettings::Backup::Backup):
808         (WebCore::InternalSettings::Backup::restoreTo):
809         (WebCore::InternalSettings::setUsesMemoryCache):
810         * testing/InternalSettings.h:
811         * testing/InternalSettings.idl:
812
813 2014-03-28  Radu Stavila  <stavila@adobe.com>
814
815         In some situations, partial layouts of floating elements produce incorrect results.
816         https://bugs.webkit.org/show_bug.cgi?id=122668
817
818         Reviewed by David Hyatt.
819
820         When performing partial layout of float elements and checking if other float
821         elements are encountered, incorrect results were obtained by not checking
822         the size of the existing floats vector.
823
824         Test: fast/block/float/floats-in-clean-line-crash.html
825
826         * rendering/RenderBlockLineLayout.cpp:
827         (WebCore::RenderBlockFlow::checkFloatsInCleanLine):
828
829 2014-03-28  Beth Dakin  <bdakin@apple.com>
830
831         Build fix.
832
833         * rendering/RenderTheme.cpp:
834         (WebCore::RenderTheme::paint):
835
836 2014-03-28  Jer Noble  <jer.noble@apple.com>
837
838         [MSE] Implement support for SourceBuffer.remove()
839         https://bugs.webkit.org/show_bug.cgi?id=121562
840
841         Reviewed by Eric Carlson.
842
843         Test: media/media-source/media-source-remove.html
844
845         Add support for SourceBuffer.remove().
846
847         * Modules/mediasource/SourceBuffer.cpp:
848         (WebCore::SourceBuffer::SourceBuffer): Initialize new member variables.
849         (WebCore::SourceBuffer::setTimestampOffset): Update comments to match spec.
850         (WebCore::SourceBuffer::remove): Added; start removeTimer.
851         (WebCore::SourceBuffer::abortIfUpdating): Cancel removeTimer.
852         (WebCore::SourceBuffer::removedFromMediaSource): Call abortIfUpdating().
853         (WebCore::SourceBuffer::stop): Cancel removeTimer.
854         (WebCore::SourceBuffer::removeCodedFrames): Added.
855         (WebCore::SourceBuffer::removeTimerFired): Added.
856         * Modules/mediasource/SourceBuffer.h:
857         * Modules/mediasource/SourceBuffer.idl:
858
859 2014-03-27  Dean Jackson  <dino@apple.com>
860
861         Support form controls that may need incremental redraw
862         https://bugs.webkit.org/show_bug.cgi?id=130736
863
864         Reviewed by Beth Dakin.
865
866         There are some form controls that change appearance
867         over time. Expand the ControlStates so that it can
868         hold a little more information, including a reference
869         to the native form control. This way the Theme implementation
870         can repaint the existing native control if necessary. At
871         least ThemeMac was reusing a single control for painting
872         all instances before this change.
873
874         Since ControlStates is now a class, pass it around by
875         reference.
876
877         The other major change is keeping a timer to trigger a
878         repaint in RenderBox, which happens if Theme/RenderTheme
879         update the ControlState to request one.
880
881         * WebCore.xcodeproj/project.pbxproj: Add ControlStates.h.
882         * WebCore.vcxproj/WebCore.vcxproj: Ditto.
883         * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
884         * dom/Element.cpp:
885         (WebCore::Element::setActive): States now within ControlStates.
886         (WebCore::Element::setHovered): Ditto.
887         * editing/FrameSelection.cpp:
888         (WebCore::FrameSelection::focusedOrActiveStateChanged): Ditto.
889         * html/HTMLFormControlElement.cpp:
890         (WebCore::HTMLFormControlElement::disabledStateChanged): Ditto.
891         (WebCore::HTMLFormControlElement::readOnlyAttributeChanged): Ditto.
892         * html/HTMLInputElement.cpp:
893         (WebCore::HTMLInputElement::setChecked): Ditto.
894         (WebCore::HTMLInputElement::setIndeterminate): Ditto.
895         * html/HTMLOptionElement.cpp:
896         (WebCore::HTMLOptionElement::parseAttribute): Ditto.
897         * platform/ControlStates.h: New file. Copied the old ControlStates enum,
898         and added accessors to hold whether or not the state is dirty, and
899         a reference to a platform control if necessary.
900         * platform/Theme.h:
901         (WebCore::Theme::selectionColor): Pass ControlStates pointer.
902         (WebCore::Theme::paint): Ditto.
903         (WebCore::Theme::inflateControlPaintRect): Ditto.
904         * platform/ThemeTypes.h: Remove ControlStates enum.
905         * platform/efl/RenderThemeEfl.cpp:
906         (WebCore::RenderThemeEfl::applyEdjeStateFromForm): Pass ControlStates pointer.
907         (WebCore::RenderThemeEfl::paintThemePart): Ditto.
908         * platform/efl/RenderThemeEfl.h: Ditto.
909         * platform/mac/ThemeMac.h: Ditto.
910         * platform/mac/ThemeMac.mm:
911         (-[WebCoreThemeView addSubview:]): New method to make sure we don't add CALayer backed
912         views to the NSView we're using for rendering.
913         (WebCore::updateStates): Use the private animated setters if necessary.
914         (WebCore::convertControlStatesToThemeDrawState): Namespacing.
915         (WebCore::configureCheckbox): Pass ControlStates pointer.
916         (WebCore::createCheckboxCell): New helper since we're creating non-static cells.
917         (WebCore::sharedCheckboxCell): The old static provider, renamed.
918         (WebCore::paintCheckbox): Check if this paint was triggered by a state change
919         or an animation. Update the ControlStates if we need to be repainted.
920         (WebCore::radio): Parameter is now ControlStates*.
921         (WebCore::paintRadio): Ditto.
922         (WebCore::setUpButtonCell): Ditto.
923         (WebCore::button): Ditto.
924         (WebCore::paintButton): Ditto.
925         (WebCore::paintStepper): Ditto.
926         (WebCore::ThemeMac::ensuredView): Ditto.
927         (WebCore::ThemeMac::inflateControlPaintRect): Ditto.
928         (WebCore::ThemeMac::paint): Ditto.
929         (WebCore::checkbox): Deleted.
930         * rendering/RenderBox.cpp:
931         (WebCore::RenderBox::RenderBox): Initialize timer.
932         (WebCore::RenderBox::~RenderBox): Stop any pending timers and delete the ControlState if necessary.
933         (WebCore::RenderBox::paintBoxDecorations): Create a ControlStates if needed. Paint, and start the repaint
934         timer if the ControlStates say we should.
935         (WebCore::RenderBox::repaintTimerFired): Call repaint when the timer fires.
936         * rendering/RenderBox.h: Add a timer for repainting.
937         * rendering/RenderElement.cpp:
938         (WebCore::controlStatesRendererMap): A static HashMap that associates renderers with ControlStates.
939         (WebCore::RenderElement::hasControlStatesForRenderer):
940         (WebCore::RenderElement::controlStatesForRenderer):
941         (WebCore::RenderElement::removeControlStatesForRenderer):
942         (WebCore::RenderElement::addControlStatesForRenderer):
943         * rendering/RenderElement.h:
944         * rendering/RenderTheme.cpp:
945         (WebCore::RenderTheme::paint): Use a pointer to ControlStates.
946         (WebCore::RenderTheme::adjustRepaintRect): Ditto.
947         (WebCore::RenderTheme::stateChanged): Ditto.
948         (WebCore::RenderTheme::updateControlStatesForRenderer): New method that just updates the states part of ControlStates.
949         (WebCore::RenderTheme::extractControlStatesForRenderer): New method that calculates the state.
950         (WebCore::RenderTheme::controlStatesForRenderer): Deleted.
951         * rendering/RenderTheme.h:
952         * rendering/RenderThemeMac.mm:
953         (WebCore::RenderThemeMac::documentViewFor): Use a ControlStates pointer.
954
955 2014-03-28  Myles C. Maxfield  <mmaxfield@apple.com>
956
957         Clear SVGInlineTextBox fragments when the text changes.
958         https://bugs.webkit.org/show_bug.cgi?id=130879
959
960         Reviewed by Darin Adler.
961
962         Ported from Blink: https://src.chromium.org/viewvc/blink?revision=150456&view=revision
963
964         This patch modifies SVGInlineTextBox::dirtyLineBoxes to clear all
965         following text boxes when invoked. Typically this method is called
966         when the underlying text string changes, and that change needs to
967         be propagated to all the boxes that use the text beyond the point
968         where the text is first modified.
969         
970         Also cleans up final function keywords for SVGRootInlineBox.
971
972         Test: svg/custom/unicode-in-tspan-multi-svg-crash.html
973
974         * rendering/InlineTextBox.h: Added (non-recursive) dirtyOwnLineBoxes() function
975         (WebCore::InlineTextBox::dirtyOwnLineBoxes): Calls dirtyLineBoxes()
976         * rendering/svg/SVGInlineTextBox.h: Added (non-recursive) dirtyOwnLineBoxes() function
977         (WebCore::SVGInlineTextBox::dirtyOwnLineBoxes):
978         * rendering/svg/SVGInlineTextBox.cpp:
979         (WebCore::SVGInlineTextBox::dirtyOwnLineBoxes): Non-recursive part of dirtyLineBoxes()
980         (WebCore::SVGInlineTextBox::dirtyLineBoxes): Calls dirtyOwnLineBoxes() in a loop
981         * rendering/svg/SVGRootInlineBox.h:
982
983 2014-03-28  Andreas Kling  <akling@apple.com>
984
985         Rebaseline bindings tests.
986
987 2014-03-28  Michael Saboff  <msaboff@apple.com>
988
989         Unreviewed, rolling r166248 back in.
990
991         Turns out r166070 didn't cause a 2% performance loss in page load times
992
993         Reverted changeset:
994
995         Unreviewed, rolling out r166126.
996         Rollout r166126 in prepartion to roll out prerequisite r166070
997
998 2014-03-26  Antonio Gomes  <a1.gomes@sisa.samsung.com>
999
1000         [Bindings] constants are always typed to 'int'
1001         https://bugs.webkit.org/show_bug.cgi?id=130775
1002
1003         Reviewed by Darin Adler.
1004
1005         Patch fixes a bug where all constant getter generated
1006         methods were returning 'integer' values due to static_cast.
1007
1008         Compilers should be smarth enough to properly infer which
1009         jsNumber class construtor to call given a literal value.
1010
1011         Patch also fixes a bug where values whose representation
1012         is bigger an integer maximum were overflowing. For instance,
1013         NodeFilter.SHOW_ALL (0xFFFFFFFF).
1014
1015         Tests:
1016         Binding tests updated.
1017         Rebaselined fast/dom/constants.html
1018
1019         * bindings/scripts/CodeGeneratorJS.pm:
1020         (GenerateImplementation):
1021         * bindings/scripts/test/JS/JSTestInterface.cpp:
1022         (WebCore::jsTestInterfaceIMPLEMENTSCONSTANT1):
1023         (WebCore::jsTestInterfaceIMPLEMENTSCONSTANT2):
1024         (WebCore::jsTestInterfaceSUPPLEMENTALCONSTANT1):
1025         (WebCore::jsTestInterfaceSUPPLEMENTALCONSTANT2):
1026         * bindings/scripts/test/JS/JSTestObj.cpp:
1027         (WebCore::jsTestObjCONDITIONAL_CONST):
1028         (WebCore::jsTestObjCONST_VALUE_0):
1029         (WebCore::jsTestObjCONST_VALUE_1):
1030         (WebCore::jsTestObjCONST_VALUE_2):
1031         (WebCore::jsTestObjCONST_VALUE_4):
1032         (WebCore::jsTestObjCONST_VALUE_8):
1033         (WebCore::jsTestObjCONST_VALUE_9):
1034         (WebCore::jsTestObjCONST_VALUE_11):
1035         (WebCore::jsTestObjCONST_VALUE_12):
1036         (WebCore::jsTestObjCONST_VALUE_13):
1037         (WebCore::jsTestObjCONST_VALUE_14):
1038         (WebCore::jsTestObjCONST_JAVASCRIPT):
1039         (WebCore::jsTestObjReadonly):
1040
1041 2014-03-28  Myles C. Maxfield  <mmaxfield@apple.com>
1042
1043         A TrailingObject's endpoint might get decremented twice
1044         https://bugs.webkit.org/show_bug.cgi?id=130874
1045
1046         Reviewed by Darin Adler.
1047
1048         There are two places where we might shave off a trailing space from the end
1049         of a line. We don't want to hit both codepaths for a single line.
1050
1051         Fixes fast/block/update-midpoints-for-trailing-boxes-crash.html after r166245.
1052
1053         * rendering/line/BreakingContextInlineHeaders.h:
1054         (WebCore::checkMidpoints):
1055         (WebCore::BreakingContext::handleEndOfLine):
1056
1057 2014-03-28  Andreas Kling  <akling@apple.com>
1058
1059         Inline JSDOMWrapper subclasses' finishCreation().
1060         <https://webkit.org/b/130890>
1061
1062         finishCreation() is really a no-op for JSDOMWrapper subclasses in
1063         release builds. None of the ancestor classes do anything but assert
1064         in their implementations.
1065
1066         Generate the function inline, reducing binary size, and removing
1067         an unnecessary call from the JSFoo::create() helpers.
1068
1069         Reviewed by Sam Weinig.
1070
1071         * bindings/scripts/CodeGeneratorJS.pm:
1072         (GenerateHeader):
1073         (GenerateImplementation):
1074
1075 2014-03-28  Jer Noble  <jer.noble@apple.com>
1076
1077         [Mac] HLS streams will report an incorrect natural size.
1078         https://bugs.webkit.org/show_bug.cgi?id=130859
1079
1080         Reviewed by Eric Carlson.
1081
1082         Some HLS streams will report incorrect naturalSizes due to the asset's preferredTransform
1083         property not being  available at the same time as the track's natural size. Given that
1084         AVFoundation only allows one video track to be selected at a time, simply use the asset's
1085         presentation size, cached in m_cachedPresentation size in all cases.
1086
1087         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
1088         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
1089
1090 2014-03-28  Antti Koivisto  <antti@apple.com>
1091
1092         Remove NodeListRootType flag
1093         https://bugs.webkit.org/show_bug.cgi?id=130896
1094
1095         Reviewed by Anders Carlsson.
1096
1097         This can be handled statically (except for the RadioNodeList case) removing
1098         a branch from NodeList traversal.
1099
1100         * dom/ClassNodeList.h:
1101         * dom/Document.cpp:
1102         (WebCore::Document::registerNodeListForInvalidation):
1103         (WebCore::Document::unregisterNodeListForInvalidation):
1104         (WebCore::Document::registerNodeList): Deleted.
1105         (WebCore::Document::unregisterNodeList): Deleted.
1106         
1107             Mark document invalidation registered lists with a bit.
1108             Renamed for clarity.
1109
1110         * dom/Document.h:
1111         * dom/LiveNodeList.cpp:
1112         (WebCore::LiveNodeList::LiveNodeList):
1113         (WebCore::LiveNodeList::rootNode):
1114         
1115             Base class version that invokes virtual isRootedAtDocument. It is needed to support 
1116             LiveNodeList::namedItem.
1117
1118         * dom/LiveNodeList.h:
1119         (WebCore::LiveNodeList::isRegisteredForInvalidationAtDocument):
1120         (WebCore::LiveNodeList::setRegisteredForInvalidationAtDocument):
1121         (WebCore::LiveNodeList::document):
1122         (WebCore::CachedLiveNodeList<NodeListType>::CachedLiveNodeList):
1123         (WebCore::CachedLiveNodeList<NodeListType>::~CachedLiveNodeList):
1124         (WebCore::CachedLiveNodeList<NodeListType>::rootNode):
1125         
1126             Call isRootedAtDocument on the final leaf type. Except for RadioNodeList this
1127             resolves statically.
1128
1129         (WebCore::CachedLiveNodeList<NodeListType>::willValidateIndexCache):
1130         (WebCore::CachedLiveNodeList<NodeListType>::invalidateCache):
1131         (WebCore::LiveNodeList::isRootedAtDocument): Deleted.
1132         (WebCore::LiveNodeList::rootType): Deleted.
1133         (WebCore::LiveNodeList::rootNode): Deleted.
1134         * dom/NameNodeList.h:
1135         * dom/NodeRareData.h:
1136         (WebCore::NodeListsNodeData::adoptDocument):
1137         * dom/TagNodeList.h:
1138         * html/HTMLCollection.cpp:
1139         (WebCore::rootTypeFromCollectionType):
1140         * html/HTMLCollection.h:
1141         (WebCore::HTMLCollection::isRootedAtDocument):
1142         (WebCore::HTMLCollection::rootType):
1143         
1144             HTMLCollections still needs the flag.
1145
1146         * html/LabelsNodeList.cpp:
1147         (WebCore::LabelsNodeList::LabelsNodeList):
1148         * html/LabelsNodeList.h:
1149         * html/RadioNodeList.cpp:
1150         (WebCore::RadioNodeList::RadioNodeList):
1151         * html/RadioNodeList.h:
1152
1153 2014-03-28  Mario Sanchez Prada  <mario.prada@samsung.com>
1154
1155         [GTK] Geoclue2 providers won't work after reloading
1156         https://bugs.webkit.org/show_bug.cgi?id=130898
1157
1158         Reviewed by Martin Robinson.
1159
1160         Don't reuse the Geoclue2 client proxy between different calls to
1161         startPosition(), and create a new client proxy each time instead.
1162
1163         * platform/geoclue/GeolocationProviderGeoclue2.cpp:
1164         (GeolocationProviderGeoclue::startUpdating): Don't reuse the
1165         client proxy, by always calling geoclue_manager_call_get_client().
1166         (GeolocationProviderGeoclue::stopUpdating): Disconnect from the
1167         'location-updated' signal and dispose the client proxy.
1168
1169 2014-03-28  Diego Pino Garcia  <dpino@igalia.com>
1170
1171         [GTK] Too many redirects visiting www.globalforestwatch.org
1172         https://bugs.webkit.org/show_bug.cgi?id=129681
1173
1174         Reviewed by Martin Robinson.
1175
1176         * platform/gtk/UserAgentGtk.cpp:
1177         (WebCore::standardUserAgent): Append Safari version to UserAgent
1178         string.
1179
1180 2014-03-28  Michael Saboff  <msaboff@apple.com>
1181
1182         Unreviewed, rolling r166249 back in.
1183
1184         Turns out r166070 didn't cause a 2% performance loss in page load times
1185
1186         Reverted changeset:
1187
1188         Unreviewed, rolling out r166070.
1189         Rollout r166070 due to 2% performance loss in page load times
1190
1191 2014-03-28  James Craig  <jcraig@apple.com>
1192
1193         Web Inspector: Copy/paste error. EventListener block in DOM.json uses description from Node.
1194         https://bugs.webkit.org/show_bug.cgi?id=130158
1195
1196         Reviewed by Timothy Hatcher.
1197
1198         * inspector/protocol/DOM.json: Fixed a copy/paste annoyance.
1199
1200 2014-03-27  James Craig  <jcraig@apple.com>
1201
1202         Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds
1203         https://bugs.webkit.org/show_bug.cgi?id=130827
1204
1205         Reviewed by Timothy Hatcher.
1206
1207         Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
1208
1209         Support for selectedChildNodeIds in inspector-protocol: DOM.getAccessibilityPropertiesForNode.
1210
1211         * inspector/InspectorDOMAgent.cpp:
1212         (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
1213         * inspector/protocol/DOM.json:
1214
1215 2014-03-27  Brent Fulgham  <bfulgham@apple.com>
1216
1217         Specify Shadow DOM Pseudo IDs in Media Element Constructors
1218         https://bugs.webkit.org/show_bug.cgi?id=130882
1219
1220         Reviewed by Eric Carlson.
1221
1222         * html/shadow/MediaControlElements.cpp:
1223         (WebCore::MediaControlPanelElement::MediaControlPanelElement): Call setPseudoId in constructor.
1224         (WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement): Ditto.
1225         (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): Ditto.
1226         (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): Ditto.
1227         (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): Ditto.
1228         (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Ditto.
1229         (WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Ditto.
1230         (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Ditto.
1231         (WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement): Ditto.
1232         (WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Ditto.
1233         (WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Ditto.
1234         (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto.
1235         (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto.
1236         (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Ditto.
1237         (WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement): Ditto.
1238         (WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): Ditto.
1239         (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Ditto.
1240         (WebCore::MediaControlPanelVolumeSliderElement::MediaControlPanelVolumeSliderElement): Ditto.
1241         (WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement): Ditto.
1242         (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Ditto.
1243         (WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement): Ditto.
1244         (WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement): Ditto.
1245         (WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Ditto.
1246         (WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Ditto.
1247         (WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Ditto.
1248
1249 2014-03-27  Benjamin Poulain  <bpoulain@apple.com>
1250
1251         [iOS][WK2] Adjust the tile coverage on the scrollview's edges
1252         https://bugs.webkit.org/show_bug.cgi?id=130884
1253
1254         Reviewed by Dan Bernstein.
1255
1256         * platform/ios/ScrollViewIOS.mm:
1257         (WebCore::ScrollView::computeCoverageRect):
1258         Pull back the future rect inside the contentRect if it goes outside.
1259         There is no point in retiling for rubberbanding and the extra tiles should be always be
1260         on the opposite side to the edges.
1261
1262 2014-03-27  Joseph Pecoraro  <pecoraro@apple.com>
1263
1264         Remove unused LocaleMac::create method
1265         https://bugs.webkit.org/show_bug.cgi?id=130870
1266
1267         Reviewed by Andreas Kling.
1268
1269         * platform/text/mac/LocaleMac.h:
1270         * platform/text/mac/LocaleMac.mm:
1271         (WebCore::LocaleMac::create): Deleted.
1272         (WebCore::LocaleMac::shortDateFormatter): Deleted.
1273
1274 2014-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1275
1276         Clean up unneeded "mutable" keyword
1277         https://bugs.webkit.org/show_bug.cgi?id=130832
1278
1279         Reviewed by Andreas Kling.
1280
1281         As r166350, this patch cleans up unneeded "mutable" keywords.
1282         Additionally, m_validatedSelectionCache is removed because it is not used anywhere else.
1283
1284         * css/CSSFontFaceRule.h:
1285         * css/CSSStyleRule.h:
1286         * editing/FrameSelection.h:
1287
1288 2014-03-27  Enrica Casucci  <enrica@apple.com>
1289
1290         Add support for AirPlay picker in WK2 for iOS.
1291         https://bugs.webkit.org/show_bug.cgi?id=130855
1292         <rdar://problem/15349859>
1293
1294         Reviewed by Eric Carlson, Joseph Pecoraro and Benjamin Poulain.
1295
1296         Adds support in HTMLMediaSession to display the airplay picker
1297         and to monitor presence of available wireless targets.
1298
1299         * html/HTMLMediaSession.cpp:
1300         (WebCore::HTMLMediaSession::showPlaybackTargetPicker):
1301         (WebCore::HTMLMediaSession::hasWirelessPlaybackTargets):
1302         (WebCore::HTMLMediaSession::setHasPlaybackTargetAvailabilityListeners):
1303         * loader/EmptyClients.h:
1304         * page/ChromeClient.h:
1305         * platform/audio/MediaSessionManager.cpp:
1306         (WebCore::MediaSessionManager::wirelessRoutesAvailableChanged):
1307         * platform/audio/MediaSessionManager.h:
1308         (WebCore::MediaSessionManager::hasWirelessTargetsAvailable):
1309         (WebCore::MediaSessionManager::startMonitoringAirPlayRoutes):
1310         (WebCore::MediaSessionManager::stopMonitoringAirPlayRoutes):
1311         * platform/audio/ios/MediaSessionManagerIOS.h:
1312         * platform/audio/ios/MediaSessionManagerIOS.mm:
1313         (WebCore::MediaSessionManageriOS::hasWirelessTargetsAvailable):
1314         (WebCore::MediaSessionManageriOS::startMonitoringAirPlayRoutes):
1315         (WebCore::MediaSessionManageriOS::stopMonitoringAirPlayRoutes):
1316         (-[WebMediaSessionHelper initWithCallback:]):
1317         (-[WebMediaSessionHelper hasWirelessTargetsAvailable]):
1318         (-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
1319         (-[WebMediaSessionHelper stopMonitoringAirPlayRoutes]):
1320         (-[WebMediaSessionHelper wirelessRoutesAvailableDidChange:]):
1321         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
1322         (WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessVideoPlaybackDisabled):
1323         (WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessVideoPlaybackDisabled):
1324
1325 2014-03-27  Bem Jones-Bey  <bjonesbe@adobe.com>
1326
1327         [CSS Shapes][css clip-path] rounded corner calculation for box shapes is wrong
1328         https://bugs.webkit.org/show_bug.cgi?id=127982
1329
1330         Reviewed by Simon Fraser.
1331
1332         Calculate rounded corners for box shapes as defined in the CSS Shapes
1333         spec.
1334
1335         Tests: css3/masking/clip-path-border-radius-border-box-000.html
1336                css3/masking/clip-path-border-radius-content-box-000.html
1337                css3/masking/clip-path-border-radius-content-box-001.html
1338                css3/masking/clip-path-border-radius-padding-box-000.html
1339                css3/masking/clip-path-border-radius-padding-box-001.html
1340                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-000.html
1341                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-001.html
1342                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-002.html
1343                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-000.html
1344                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-001.html
1345                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-002.html
1346                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-content-box-003.html
1347                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-000.html
1348                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-001.html
1349                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-002.html
1350                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-003.html
1351                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-margin-box-004.html
1352                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-000.html
1353                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-001.html
1354                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-002.html
1355                fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-padding-box-003.html
1356
1357         * platform/graphics/RoundedRect.h:
1358         (WebCore::RoundedRect::Radii::transposedRadii): Transpose radii for
1359             vertical writing modes.
1360         (WebCore::RoundedRect::moveBy): Add method for use with clip path.
1361         (WebCore::RoundedRect::transposedRect): Transpose rect for vertical
1362             writing modes.
1363         * rendering/RenderBox.h:
1364         (WebCore::RenderBox::marginBoxRect): Return the margin box rect for
1365             the RenderBox.
1366         * rendering/RenderLayer.cpp:
1367         (WebCore::RenderLayer::setupClipPath): Call the new function for the
1368             rounded corner calculation.
1369         * rendering/shapes/ShapeInfo.cpp:
1370         (WebCore::ShapeInfo<RenderType>::computedShape): Call the new function
1371             for the rounded corner calculation.
1372         * rendering/shapes/BoxShape.cpp:
1373         (WebCore::adjustRadiusForMarginBoxShape): Helper function for
1374             computeRoundedRectForLayoutBoxShape.
1375         (WebCore::computeMarginBoxShapeRadius): Ditto.
1376         (WebCore::computeMarginBoxShapeRadii): Ditto.
1377         (WebCore::computeRoundedRectForBoxShape): Utility function to do the
1378             rounded corner calculation.
1379         * rendering/shapes/BoxShape.h: Add new function.
1380         * rendering/style/RenderStyle.h:
1381         (WebCore::RenderStyle::getRoundedInnerBorderFor): Add default argument
1382             values.
1383
1384 2014-03-27  Commit Queue  <commit-queue@webkit.org>
1385
1386         Unreviewed, rolling out r166364.
1387         https://bugs.webkit.org/show_bug.cgi?id=130872
1388
1389         Caused a test assertion (Requested by smfr on #webkit).
1390
1391         Reverted changeset:
1392
1393         "Operator stretching: expose a math data API"
1394         https://bugs.webkit.org/show_bug.cgi?id=130572
1395         http://trac.webkit.org/changeset/166364
1396
1397 2014-03-27  Benjamin Poulain  <bpoulain@apple.com>
1398
1399         [iOS][WK2] Compute a good exposed rect when scaling WKContentView
1400         https://bugs.webkit.org/show_bug.cgi?id=130761
1401
1402         Reviewed by Simon Fraser.
1403
1404         * WebCore.exp.in:
1405         * platform/ScrollView.h:
1406         * platform/ios/ScrollViewIOS.mm:
1407         (WebCore::ScrollView::setScrollVelocity):
1408         (WebCore::ScrollView::computeCoverageRect):
1409         While scaling in, do not add margins tiles. When scaling out, add 1 margin tile size
1410         all around.
1411
1412 2014-03-27  Commit Queue  <commit-queue@webkit.org>
1413
1414         Unreviewed, rolling out r166360.
1415         https://bugs.webkit.org/show_bug.cgi?id=130869
1416
1417         Seems to have broken PLT (Requested by ap on #webkit).
1418
1419         Reverted changeset:
1420
1421         "Connection::dispatchOneMessage() can be re-entered while
1422         handling Cmd-key menu"
1423         https://bugs.webkit.org/show_bug.cgi?id=130767
1424         http://trac.webkit.org/changeset/166360
1425
1426 2014-03-27  Antti Koivisto  <antti@apple.com>
1427
1428         Remove LiveNodeList::Type
1429         https://bugs.webkit.org/show_bug.cgi?id=130866
1430
1431         Reviewed by Andreas Kling.
1432
1433         We don't need dynamic type information anymore.
1434
1435         * dom/ClassNodeList.cpp:
1436         (WebCore::ClassNodeList::ClassNodeList):
1437         * dom/ContainerNode.cpp:
1438         (WebCore::ContainerNode::getElementsByTagName):
1439         (WebCore::ContainerNode::getElementsByName):
1440         (WebCore::ContainerNode::getElementsByClassName):
1441         (WebCore::ContainerNode::radioNodeList):
1442         * dom/LiveNodeList.cpp:
1443         (WebCore::LiveNodeList::LiveNodeList):
1444         * dom/LiveNodeList.h:
1445         (WebCore::LiveNodeList::invalidationType):
1446         (WebCore::CachedLiveNodeList<NodeListType>::CachedLiveNodeList):
1447         (WebCore::LiveNodeList::type): Deleted.
1448         * dom/NameNodeList.cpp:
1449         (WebCore::NameNodeList::NameNodeList):
1450         (WebCore::NameNodeList::nodeMatches): Deleted.
1451         * dom/NameNodeList.h:
1452         (WebCore::NameNodeList::nodeMatches):
1453         * dom/NodeRareData.h:
1454         (WebCore::NodeListTypeIdentifier<ClassNodeList>::value):
1455         (WebCore::NodeListTypeIdentifier<NameNodeList>::value):
1456         (WebCore::NodeListTypeIdentifier<TagNodeList>::value):
1457         (WebCore::NodeListTypeIdentifier<HTMLTagNodeList>::value):
1458         (WebCore::NodeListTypeIdentifier<RadioNodeList>::value):
1459         (WebCore::NodeListTypeIdentifier<LabelsNodeList>::value):
1460         
1461             Get unique id from type for key generation purposes only.
1462
1463         (WebCore::NodeListsNodeData::addCacheWithAtomicName):
1464         (WebCore::NodeListsNodeData::addCacheWithName):
1465         (WebCore::NodeListsNodeData::removeCacheWithAtomicName):
1466         (WebCore::NodeListsNodeData::removeCacheWithName):
1467         (WebCore::NodeListsNodeData::namedNodeListKey):
1468         * dom/TagNodeList.cpp:
1469         (WebCore::TagNodeList::TagNodeList):
1470         (WebCore::HTMLTagNodeList::HTMLTagNodeList):
1471         * dom/TagNodeList.h:
1472         * html/LabelableElement.cpp:
1473         (WebCore::LabelableElement::labels):
1474         * html/LabelsNodeList.cpp:
1475         (WebCore::LabelsNodeList::LabelsNodeList):
1476         * html/LabelsNodeList.h:
1477         * html/RadioNodeList.cpp:
1478         (WebCore::RadioNodeList::RadioNodeList):
1479         * html/RadioNodeList.h:
1480
1481 2014-03-27  Simon Fraser  <simon.fraser@apple.com>
1482
1483         Fix crash when RenderView is cleared inside of frame flattening layout
1484         https://bugs.webkit.org/show_bug.cgi?id=130864
1485
1486         Reviewed by Dan Bernstein.
1487         
1488         Navigating on http://wallstcheatsheet.com pages on iOS in WebKit1 would
1489         sometimes crash when, inside the inChildFrameLayoutWithFrameFlattening clause,
1490         our frame's RenderView would be null after doing a layout from the root frame,
1491         possibly also when WebCore was being re-entered from another thread.
1492         
1493         Add a null check to fix this.
1494         
1495         Crash was timing-dependent and hard to test.
1496
1497         * page/FrameView.cpp:
1498         (WebCore::FrameView::layout):
1499
1500 2014-03-27  Antti Koivisto  <antti@apple.com>
1501
1502         Remove some unnecessary branches from LiveNodeList traversal
1503         https://bugs.webkit.org/show_bug.cgi?id=130854
1504
1505         Reviewed by Andreas Kling.
1506
1507         Compile different traversal code paths for all NodeList subclasses.
1508
1509         * dom/ClassNodeList.cpp:
1510         (WebCore::ClassNodeList::ClassNodeList):
1511         (WebCore::ClassNodeList::~ClassNodeList):
1512         (WebCore::ClassNodeList::nodeMatches): Deleted.
1513         * dom/ClassNodeList.h:
1514         (WebCore::ClassNodeList::nodeMatches):
1515         (WebCore::ClassNodeList::nodeMatchesInlined): Deleted.
1516         
1517             Remove separate nodeMatchesInlined functions. 
1518             We now rely on exact types and marking classes final.
1519
1520         * dom/LiveNodeList.cpp:
1521         (WebCore::LiveNodeList::LiveNodeList):
1522         (WebCore::LiveNodeList::~LiveNodeList):
1523         (WebCore::LiveNodeList::namedItem):
1524         (WebCore::LiveNodeList::rootNode): Deleted.
1525         (WebCore::isMatchingElement): Deleted.
1526         (WebCore::firstMatchingElement): Deleted.
1527         (WebCore::lastMatchingElement): Deleted.
1528         (WebCore::nextMatchingElement): Deleted.
1529         (WebCore::previousMatchingElement): Deleted.
1530         (WebCore::traverseMatchingElementsForward): Deleted.
1531         (WebCore::traverseMatchingElementsBackward): Deleted.
1532         (WebCore::LiveNodeList::collectionFirst): Deleted.
1533         (WebCore::LiveNodeList::collectionLast): Deleted.
1534         (WebCore::LiveNodeList::collectionTraverseForward): Deleted.
1535         (WebCore::LiveNodeList::collectionTraverseBackward): Deleted.
1536         (WebCore::LiveNodeList::length): Deleted.
1537         (WebCore::LiveNodeList::item): Deleted.
1538         (WebCore::LiveNodeList::memoryCost): Deleted.
1539         (WebCore::LiveNodeList::invalidateCache): Deleted.
1540         * dom/LiveNodeList.h:
1541         (WebCore::LiveNodeList::invalidateCacheForAttribute):
1542         (WebCore::CachedLiveNodeList::collectionCanTraverseBackward):
1543         (WebCore::LiveNodeList::rootNode):
1544         (WebCore::CachedLiveNodeList<NodeListType>::CachedLiveNodeList):
1545         
1546             Add CachedLiveNodeList<NodeListType> utility type that interfaces with CollectionIndexCache.
1547             It is the base class for all concrete LiveNodeLists.
1548
1549         (WebCore::CachedLiveNodeList<NodeListType>::~CachedLiveNodeList):
1550         (WebCore::CachedLiveNodeList<NodeListType>::collectionFirst):
1551         (WebCore::CachedLiveNodeList<NodeListType>::collectionLast):
1552         (WebCore::nextMatchingElement):
1553         (WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseForward):
1554         (WebCore::previousMatchingElement):
1555         (WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseBackward):
1556         (WebCore::CachedLiveNodeList<NodeListType>::willValidateIndexCache):
1557         (WebCore::CachedLiveNodeList<NodeListType>::invalidateCache):
1558         (WebCore::CachedLiveNodeList<NodeListType>::length):
1559         (WebCore::CachedLiveNodeList<NodeListType>::item):
1560         (WebCore::CachedLiveNodeList<NodeListType>::memoryCost):
1561         
1562             Templated code moves to header.
1563
1564         (WebCore::LiveNodeList::LiveNodeList): Deleted.
1565         (WebCore::LiveNodeList::~LiveNodeList): Deleted.
1566         (WebCore::LiveNodeList::invalidateCache): Deleted.
1567         (WebCore::LiveNodeList::collectionCanTraverseBackward): Deleted.
1568         (WebCore::LiveNodeList::willValidateIndexCache): Deleted.
1569         * dom/NameNodeList.cpp:
1570         (WebCore::NameNodeList::NameNodeList):
1571         * dom/NameNodeList.h:
1572         * dom/Node.cpp:
1573         (WebCore::Document::invalidateNodeListAndCollectionCaches):
1574         (WebCore::NodeListsNodeData::invalidateCaches):
1575         * dom/TagNodeList.cpp:
1576         (WebCore::TagNodeList::TagNodeList):
1577         (WebCore::HTMLTagNodeList::HTMLTagNodeList):
1578         (WebCore::HTMLTagNodeList::~HTMLTagNodeList):
1579         (WebCore::TagNodeList::nodeMatches): Deleted.
1580         (WebCore::HTMLTagNodeList::nodeMatches): Deleted.
1581         * dom/TagNodeList.h:
1582         (WebCore::TagNodeList::nodeMatches):
1583         (WebCore::HTMLTagNodeList::nodeMatches):
1584         (WebCore::TagNodeList::create): Deleted.
1585         (WebCore::HTMLTagNodeList::nodeMatchesInlined): Deleted.
1586         * html/LabelsNodeList.cpp:
1587         (WebCore::LabelsNodeList::LabelsNodeList):
1588         * html/LabelsNodeList.h:
1589         * html/RadioNodeList.cpp:
1590         (WebCore::RadioNodeList::RadioNodeList):
1591         * html/RadioNodeList.h:
1592
1593 2014-03-27  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1594
1595         Remove comment from Filter.h
1596         https://bugs.webkit.org/show_bug.cgi?id=130848
1597
1598         Reviewed by Simon Fraser.
1599
1600         Exploring the use of consts on applyScale() methods didn't yield
1601         good results.
1602
1603         No new tests, no change on behavior.
1604
1605         * platform/graphics/filters/Filter.h:
1606
1607 2014-03-27  Frédéric Wang  <fred.wang@free.fr>
1608
1609         Operator stretching: expose a math data API
1610         https://bugs.webkit.org/show_bug.cgi?id=130572
1611
1612         Reviewed by Chris Fleizach.
1613
1614         We expose a new SimpleFontData API to give access to the data from the
1615         OpenType MATH table using a font cache. The class OpenTypeMathData will
1616         be implemented in bug 130324. On Darwin platform, we also implement the
1617         missing FontPlatformData::openTypeTable function which will be necessary
1618         to load the OpenType MATH table. The changes are intended to be used
1619         for MathML operator stretching (bug 130322) so tests are not added yet.
1620
1621         * CMakeLists.txt: add new OpenTypeMathData files.
1622         * WebCore.vcxproj/WebCore.vcxproj: ditto.
1623         * WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
1624         * WebCore.xcodeproj/project.pbxproj: ditto.
1625         * platform/graphics/FontCache.cpp: We add a FontCache::getMathData function to implement a cache for the math data.
1626         We make the math and vertical data share the same key for the cache.
1627         (WebCore::fontMathDataCacheInstance):
1628         (WebCore::FontCache::getMathData):
1629         (WebCore::fontVerticalDataCacheInstance):
1630         * platform/graphics/FontCache.h: We declare FontCache::getMathData and FontFileKey on all platforms.
1631         * platform/graphics/FontPlatformData.cpp:
1632         (WebCore::FontPlatformData::openTypeTable): We implement openTypeTable() on Darwin platform.
1633         * platform/graphics/FontPlatformData.h: We expose openTypeTable() on Darwin platform.
1634         * platform/graphics/SimpleFontData.cpp: We initialize m_mathData from the font cache.
1635         (WebCore::SimpleFontData::SimpleFontData):
1636         * platform/graphics/SimpleFontData.h: We expose a mathData() function to access the MATH data.
1637         * platform/graphics/opentype/OpenTypeMathData.cpp: Added. This is a new class that will be used to parse the data from the OpenType MATH table.
1638         (WebCore::OpenTypeMathData::OpenTypeMathData):
1639         * platform/graphics/opentype/OpenTypeMathData.h: Added.
1640         (WebCore::OpenTypeMathData::create):
1641         (WebCore::OpenTypeMathData::hasMathData):
1642
1643 2014-03-27  Brent Fulgham  <bfulgham@apple.com>
1644
1645         Fix a crash caused by track insertion after load()
1646         https://bugs.webkit.org/show_bug.cgi?id=130777
1647
1648         Reviewed by Eric Carlson.
1649
1650         Test: media/track/track-insert-after-load-crash.html
1651
1652         Based on the Blink change (patch by acolwell@chromium.org):
1653         https://codereview.chromium.org/211373009/
1654
1655         * html/HTMLMediaElement.cpp:
1656         (WebCore::HTMLMediaElement::parseAttribute): Remove stale LoadMediaResource flag after explicit load.
1657
1658 2014-03-27  Alexey Proskuryakov  <ap@apple.com>
1659
1660         Connection::dispatchOneMessage() can be re-entered while handling Cmd-key menu
1661         equivalents, ASSERT(!_data->_keyDownEventBeingResent)
1662         https://bugs.webkit.org/show_bug.cgi?id=130767
1663         <rdar://problem/16307487>
1664
1665         Added a wrapper for RunLoop::initializeMainThread that also adds modal run loop
1666         mode to it on Mac.
1667
1668         * CMakeLists.txt:
1669         * WebCore.exp.in:
1670         * WebCore.vcxproj/WebCore.vcxproj:
1671         * WebCore.vcxproj/WebCore.vcxproj.filters:
1672         * WebCore.xcodeproj/project.pbxproj:
1673         * platform/MainRunLoop.cpp: Added.
1674         (WebCore::initializeMainRunLoop):
1675         * platform/MainRunLoop.h: Added.
1676         * platform/mac/MainRunLoop.mm: Added.
1677         (WebCore::initializeMainRunLoop):
1678
1679 2014-03-27  Krzysztof Czech  <k.czech@samsung.com>
1680
1681         AX: Returns const reference to static string.
1682         https://bugs.webkit.org/show_bug.cgi?id=130835
1683
1684         Reviewed by Mario Sanchez Prada.
1685
1686         Avoiding some unnecessary copies by returning const reference to static string.
1687
1688         No new tests. No behaviour change.
1689
1690         * accessibility/AccessibilityMediaControls.cpp:
1691         (WebCore::AccessibilityMediaControl::controlTypeName):
1692         (WebCore::AccessibilityMediaControlsContainer::elementTypeName):
1693         * accessibility/AccessibilityMediaControls.h:
1694
1695 2014-03-27  Mihnea Ovidenie  <mihnea@adobe.com>
1696
1697         [CSSRegions] Rename inNamedFlow flag to isNamedFlowContentNode flag
1698         https://bugs.webkit.org/show_bug.cgi?id=130731
1699
1700         Reviewed by Andrei Bucur.
1701
1702         Currently, the inNamedFlow flag in Node class tells if a node is a content node, one that has a style with flow-into.
1703         Since it is used only for those nodes and not propagated through hierarchy, i want to renamed it to a more meaningful name.
1704         No new functionality, no new tests.
1705
1706         * dom/ContainerNode.cpp:
1707         (WebCore::destroyRenderTreeIfNeeded):
1708         * dom/Element.cpp:
1709         (WebCore::Element::~Element):
1710         (WebCore::Element::unregisterNamedFlowContentElement):
1711         * dom/Node.h:
1712         (WebCore::Node::isNamedFlowContentNode):
1713         (WebCore::Node::setIsNamedFlowContentNode):
1714         (WebCore::Node::clearIsNamedFlowContentNode):
1715         * rendering/RenderNamedFlowThread.cpp:
1716         (WebCore::RenderNamedFlowThread::clearContentElements):
1717         (WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
1718         (WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
1719         (WebCore::nextNodeInsideContentElement):
1720         * style/StyleResolveTree.cpp:
1721         (WebCore::Style::attachChildren):
1722         (WebCore::Style::resolveLocal):
1723
1724 2014-03-27  Mihnea Ovidenie  <mihnea@adobe.com>
1725
1726         [CSSRegions] Crash when cloning a region child with a content node child
1727         https://bugs.webkit.org/show_bug.cgi?id=129811
1728
1729         Reviewed by David Hyatt.
1730
1731         Collecting the children of a region in another named flow will be supported
1732         again in the future and it will be revisited when we will implement the content
1733         keyword: http://dev.w3.org/csswg/css-regions-1/#the-flow-into-property.
1734         Remove the support for now as it introduces unnecessary complexity in the code
1735         and potential wrong behavior.
1736
1737         Test: fast/regions/region-content-node-child-clone-crash.html
1738
1739         * dom/Element.cpp:
1740         (WebCore::Element::shouldMoveToFlowThread):
1741         (WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
1742         * dom/Element.h:
1743         * dom/ElementRareData.h:
1744         (WebCore::ElementRareData::ElementRareData):
1745         * rendering/FlowThreadController.cpp:
1746         * rendering/FlowThreadController.h:
1747         * style/StyleResolveTree.cpp:
1748         (WebCore::Style::moveToFlowThreadIfNeeded):
1749         (WebCore::Style::createRendererIfNeeded):
1750
1751 2014-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1752
1753         Remove unneeded mutable keyword in some member variables 
1754         https://bugs.webkit.org/show_bug.cgi?id=130813
1755
1756         Reviewed by Andreas Kling.
1757
1758         Some member variables have mutable keyword though they don't used by const function.
1759         This patch removes them. 
1760
1761         No new tests, no behavior changes. Just clean up.
1762
1763         * storage/StorageAreaSync.h:
1764         * svg/animation/SVGSMILElement.h:
1765
1766 2014-03-27  Commit Queue  <commit-queue@webkit.org>
1767
1768         Unreviewed, rolling out r166296 and r166331.
1769         https://bugs.webkit.org/show_bug.cgi?id=130822
1770
1771         caused some crashes and frequent assertion failures, and the
1772         fix is going to take a little while (Requested by thorton on
1773         #webkit).
1774
1775         Reverted changesets:
1776
1777         "[iOS WebKit2] Flush all surfaces after painting into all of
1778         them, instead of after painting into each one"
1779         https://bugs.webkit.org/show_bug.cgi?id=130768
1780         http://trac.webkit.org/changeset/166296
1781
1782         "Assertion failure in RemoteLayerBackingStore::flush"
1783         https://bugs.webkit.org/show_bug.cgi?id=130810
1784         http://trac.webkit.org/changeset/166331
1785
1786 2014-03-26  Simon Fraser  <simon.fraser@apple.com>
1787
1788         Fix failing scrolling tests by reverting to previous behavior where
1789         the scrolling geometry for the main frame scrolling node was only
1790         updated from frameViewLayoutUpdated() and no-where else.
1791
1792         * WebCore.exp.in:
1793         * page/scrolling/AsyncScrollingCoordinator.cpp:
1794         (WebCore::AsyncScrollingCoordinator::updateScrollingNode):
1795         * page/scrolling/AsyncScrollingCoordinator.h:
1796         * page/scrolling/ScrollingCoordinator.h:
1797         (WebCore::ScrollingCoordinator::updateScrollingNode):
1798         * rendering/RenderLayerCompositor.cpp:
1799         (WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
1800         (WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer): Deleted.
1801
1802 2014-03-26  Ryosuke Niwa  <rniwa@webkit.org>
1803
1804         HTMLConverter::_processText is slow because it walks up ancestor elements
1805         https://bugs.webkit.org/show_bug.cgi?id=130820
1806
1807         Reviewed by Sam Weinig.
1808
1809         Avoid walking up the tree from each text node by caching the aggregated attributed strings for each element.
1810         Also compute the attributed strings top-down to avoid calling mutableCopy in every iteration. 
1811
1812         This reduces the runtime of Interactive/CopyAll.html from 15s to 13s (15%).
1813
1814         * editing/cocoa/HTMLConverter.mm:
1815         (HTMLConverter::_attributesForElement):
1816         (HTMLConverter::attributesForElement):
1817         (HTMLConverter::aggregatedAttributesForAncestors):
1818         (HTMLConverter::_processText):
1819
1820 2014-03-26  Sam Weinig  <sam@webkit.org>
1821
1822         Fix iOS build.
1823
1824         * editing/cocoa/HTMLConverter.mm:
1825         (_font):
1826
1827 2014-03-26  Ryosuke Niwa  <rniwa@webkit.org>
1828
1829         Make _processText and _traverseNode in HTMLConverter more efficient
1830         https://bugs.webkit.org/show_bug.cgi?id=130769
1831
1832         Reviewed by Sam Weinig.
1833
1834         Rewrote a bunch of code in C++ and avoided creating wrappers.
1835         This reduces the runtime of Interactive/CopyAll.html from ~16.5s to 15s.
1836
1837         * editing/cocoa/HTMLConverter.mm:
1838         (HTMLConverterCaches::isAncestorsOfStartToBeConverted):
1839         (HTMLConverter::HTMLConverter):
1840         (HTMLConverter::~HTMLConverter):
1841         (HTMLConverter::_processElement):
1842         (HTMLConverter::_processText):
1843         (HTMLConverter::_traverseNode):
1844         (HTMLConverter::_traverseFooterNode):
1845         (HTMLConverterCaches::cacheAncestorsOfStartToBeConverted):
1846         (HTMLConverter::_loadFromDOMRange):
1847
1848 2014-03-26  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1849
1850         FEGaussianBlur: unify and const-ify calculateKernelSize
1851         https://bugs.webkit.org/show_bug.cgi?id=130779
1852
1853         Some methods can benefit of using const refs as also make sense to
1854         unify the interface (i.e. parameters) in calculateKernelSize/Unscaled.
1855
1856         FilterEffect::filter() will now return a reference, which helps since
1857         its descendants were accessing methods into the pointer without testing
1858         for it.
1859
1860         Reviewed by Simon Fraser.
1861
1862         No new tests, no changes on behavior.
1863
1864         * platform/graphics/filters/FEDisplacementMap.cpp:
1865         (WebCore::FEDisplacementMap::platformApplySoftware):
1866         * platform/graphics/filters/FEDropShadow.cpp:
1867         (WebCore::FEDropShadow::determineAbsolutePaintRect):
1868         (WebCore::FEDropShadow::platformApplySoftware):
1869         * platform/graphics/filters/FEGaussianBlur.cpp:
1870         (WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
1871         (WebCore::FEGaussianBlur::calculateKernelSize):
1872         (WebCore::FEGaussianBlur::determineAbsolutePaintRect):
1873         (WebCore::FEGaussianBlur::platformApplySoftware):
1874         * platform/graphics/filters/FEGaussianBlur.h:
1875         * platform/graphics/filters/FEMorphology.cpp:
1876         (WebCore::FEMorphology::determineAbsolutePaintRect):
1877         (WebCore::FEMorphology::platformApplySoftware):
1878         * platform/graphics/filters/FEOffset.cpp:
1879         (WebCore::FEOffset::determineAbsolutePaintRect):
1880         (WebCore::FEOffset::platformApplySoftware):
1881         * platform/graphics/filters/FETile.cpp:
1882         (WebCore::FETile::platformApplySoftware):
1883         * platform/graphics/filters/FETurbulence.cpp:
1884         (WebCore::FETurbulence::fillRegion):
1885         * platform/graphics/filters/Filter.h:
1886         (WebCore::Filter::applyHorizontalScale):
1887         (WebCore::Filter::applyVerticalScale):
1888         * platform/graphics/filters/FilterEffect.h:
1889         (WebCore::FilterEffect::filter):
1890         * platform/graphics/filters/SourceAlpha.cpp:
1891         (WebCore::SourceAlpha::determineAbsolutePaintRect):
1892         (WebCore::SourceAlpha::platformApplySoftware):
1893         * platform/graphics/filters/SourceGraphic.cpp:
1894         (WebCore::SourceGraphic::determineAbsolutePaintRect):
1895         (WebCore::SourceGraphic::platformApplySoftware):
1896         * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
1897         (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
1898         * svg/graphics/filters/SVGFEImage.cpp:
1899         (WebCore::FEImage::determineAbsolutePaintRect):
1900         (WebCore::FEImage::platformApplySoftware):
1901
1902 2014-03-26  Simon Fraser  <simon.fraser@apple.com>
1903
1904         Make sure childContainmentLayer is parented
1905         https://bugs.webkit.org/show_bug.cgi?id=130808
1906
1907         Reviewed by Tim Horton.
1908
1909         m_childContainmentLayer was never parented if the page
1910         created no other compositing layers, which left a dangling
1911         GraphicsLayer which in turn confused UI-side compositing a little.
1912         Fix by always parenting this layer.
1913
1914         * rendering/RenderLayerBacking.cpp:
1915         (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
1916
1917 2014-03-26  Brian Burg  <bburg@apple.com>
1918
1919         Web Replay: disable page cache during capture/replay
1920         https://bugs.webkit.org/show_bug.cgi?id=130672
1921
1922         Reviewed by Timothy Hatcher.
1923
1924         Save, set, and restore page cache settings at the correct times.
1925
1926         No new tests. If this code fails, then the tests for network replay will fail.
1927
1928         * replay/ReplayController.cpp:
1929         (WebCore::ReplayController::setForceDeterministicSettings): Added.
1930         (WebCore::ReplayController::startCapturing):
1931         (WebCore::ReplayController::stopCapturing):
1932         (WebCore::ReplayController::cancelPlayback):
1933         (WebCore::ReplayController::replayToPosition):
1934         * replay/ReplayController.h:
1935
1936 2014-03-26  Sam Weinig  <sam@webkit.org>
1937
1938         Convert more of HTMLConverter to C++
1939         https://bugs.webkit.org/show_bug.cgi?id=130811
1940
1941         Reviewed by Anders Carlsson.
1942
1943         * editing/cocoa/HTMLConverter.mm:
1944         (HTMLConverter::HTMLConverter):
1945         (HTMLConverter::~HTMLConverter):
1946         (HTMLConverter::_blockLevelElementForNode):
1947         (HTMLConverter::_colorForElement):
1948         (HTMLConverter::_computedAttributesForElement):
1949         (HTMLConverter::_attributesForElement):
1950         (HTMLConverter::_fillInBlock):
1951         (HTMLConverter::_enterElement):
1952         (HTMLConverter::_addTableForElement):
1953         (HTMLConverter::_addTableCellForElement):
1954         (HTMLConverter::_processElement):
1955         (HTMLConverter::_exitElement):
1956         (HTMLConverter::_getFloat): Deleted.
1957         (HTMLConverter::_elementIsBlockLevel): Deleted.
1958         (HTMLConverter::_elementHasOwnBackgroundColor): Deleted.
1959         (HTMLConverter::_colorForNode): Deleted.
1960
1961 2014-03-26  Simon Fraser  <simon.fraser@apple.com>
1962
1963         Hook up -webkit-overflow-scrolling:touch for iOS WK2
1964         https://bugs.webkit.org/show_bug.cgi?id=130809
1965
1966         Reviewed by Tim Horton.
1967
1968         Get -webkit-overflow-scrolling: touch working for iOS WK2.
1969         
1970         * WebCore.exp.in:
1971         * page/scrolling/AsyncScrollingCoordinator.cpp:
1972         (WebCore::AsyncScrollingCoordinator::updateScrollingNode):
1973         Send in ScrollingGeometry when we update scrolling nodes.
1974         * page/scrolling/AsyncScrollingCoordinator.h:
1975         * page/scrolling/ScrollingCoordinator.h:
1976         (WebCore::ScrollingCoordinator::updateScrollingNode):
1977         * page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
1978         Need to get to the scrolling layer in a subclass.
1979         (WebCore::ScrollingTreeScrollingNodeIOS::scrollLayer):
1980         * rendering/RenderLayer.cpp:
1981         (WebCore::RenderLayer::hasAcceleratedTouchScrolling): Remove code
1982         that temporarily disabled touch-scrolling.
1983         * rendering/RenderLayerCompositor.cpp:
1984         (WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer): When we
1985         update scrolling nodes, send in the right scrolling geometry.
1986
1987 2014-03-26  Timothy Hatcher  <timothy@apple.com>
1988
1989         Modernize the loops in InspectorPageAgent.cpp.
1990
1991         Also moves the check for hiddenFromInspector to a lower level.
1992         This hides hidden resources from more places.
1993
1994         https://bugs.webkit.org/show_bug.cgi?id=130803
1995
1996         Reviewed by Joseph Pecoraro.
1997
1998         * inspector/InspectorPageAgent.cpp:
1999         (WebCore::buildArrayForCookies):
2000         (WebCore::cachedResourcesForFrame):
2001         (WebCore::allResourcesURLsForFrame):
2002         (WebCore::InspectorPageAgent::getCookies):
2003         (WebCore::InspectorPageAgent::searchInResources):
2004         (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
2005         (WebCore::InspectorPageAgent::loaderDetachedFromFrame):
2006         (WebCore::InspectorPageAgent::buildObjectForFrameTree):
2007
2008 2014-03-26  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
2009
2010         Add platform implementation for RTCOfferAnswerOptions and RTCOfferOptions
2011         https://bugs.webkit.org/show_bug.cgi?id=130689
2012
2013         Reviewed by Eric Carlson.
2014
2015         RTCOfferAnswerOptions and RTCOfferOptions objects were being passed to platform class, causing a layer
2016         violation.
2017
2018         * Modules/mediastream/RTCOfferAnswerOptions.cpp:
2019         (WebCore::RTCOfferAnswerOptions::initialize):
2020         (WebCore::RTCOfferOptions::initialize):
2021         * Modules/mediastream/RTCOfferAnswerOptions.h:
2022         (WebCore::RTCOfferAnswerOptions::requestIdentity):
2023         (WebCore::RTCOfferAnswerOptions::privateOfferAnswerOptions):
2024         (WebCore::RTCOfferAnswerOptions::RTCOfferAnswerOptions):
2025         (WebCore::RTCOfferOptions::offerToReceiveVideo):
2026         (WebCore::RTCOfferOptions::offerToReceiveAudio):
2027         (WebCore::RTCOfferOptions::voiceActivityDetection):
2028         (WebCore::RTCOfferOptions::iceRestart):
2029         (WebCore::RTCOfferOptions::privateOfferOptions):
2030         (WebCore::RTCOfferOptions::RTCOfferOptions):
2031         * Modules/mediastream/RTCPeerConnection.cpp:
2032         (WebCore::RTCPeerConnection::createOffer):
2033         (WebCore::RTCPeerConnection::createAnswer):
2034         * platform/mediastream/RTCOfferAnswerOptionsPrivate.h: Added.
2035         * platform/mediastream/RTCPeerConnectionHandler.h:
2036         * platform/mock/RTCPeerConnectionHandlerMock.cpp:
2037         (WebCore::RTCPeerConnectionHandlerMock::createOffer):
2038         (WebCore::RTCPeerConnectionHandlerMock::createAnswer):
2039         * platform/mock/RTCPeerConnectionHandlerMock.h:
2040
2041 2014-03-26  Zalan Bujtas  <zalan@apple.com>
2042
2043         Device scale factor should always be greater than 0.
2044         https://bugs.webkit.org/show_bug.cgi?id=130798
2045
2046         Reviewed by David Kilzer.
2047
2048         Rendering context requires a device scale factor > 0 so that we can map CSS pixels
2049         to device pixels properly. Neither 0 nor a negative device pixel ratio are considered to be valid.
2050
2051         * page/Page.cpp:
2052         (WebCore::Page::setDeviceScaleFactor):
2053
2054 2014-03-26  Myles C. Maxfield  <mmaxfield@apple.com>
2055
2056         Skipping underlines disregard points completely inside the underline rect
2057         https://bugs.webkit.org/show_bug.cgi?id=130800
2058
2059         Reviewed by Dean Jackson.
2060
2061         When determining bounds for underline skipping, endpoints of glyph contours
2062         that lie entirely within the rect of the underline are ignored. This patch
2063         makes these points affect the skipping regions the same way that intersections
2064         do.
2065
2066         Test: fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html
2067
2068         * platform/graphics/mac/FontMac.mm:
2069         (WebCore::updateX): Refactored common code into a function
2070         (WebCore::findPathIntersections): Test for endpoints which lie entirely within
2071         the underline bounds
2072
2073 2014-03-26  Pratik Solanki  <psolanki@apple.com>
2074
2075         Unreviewed. iOS build fix after r166312. Soft link CMTimeRangeGetEnd.
2076
2077         * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
2078
2079 2014-03-26  Timothy Hatcher  <timothy@apple.com>
2080
2081         Propagate the hiddenFromInspector flag on ResourceRequest in
2082         places when a new request a made or passed between processes.
2083
2084         https://bugs.webkit.org/show_bug.cgi?id=130741
2085
2086         Reviewed by Joseph Pecoraro.
2087
2088         * WebCore.exp.in: Updated symbols for updateFromDelegatePreservingOldProperties.
2089         * platform/network/cf/ResourceRequest.h:
2090         * platform/network/cf/ResourceRequestCFNet.cpp:
2091         (WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
2092         (WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
2093         * platform/network/curl/ResourceRequest.h:
2094         (WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
2095         (WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
2096         * platform/network/mac/ResourceRequestMac.mm:
2097         (WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
2098         (WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
2099         * platform/network/soup/ResourceRequest.h:
2100         (WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
2101         (WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
2102
2103 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2104
2105         [CSS Shapes] Remove no-longer-used shape-inside geometry code
2106         https://bugs.webkit.org/show_bug.cgi?id=130740
2107
2108         Reviewed by David Hyatt.
2109
2110         This patch removes shape-padding support, since it can be used only with shape-inside.
2111         Shape-inside support has been removed in r166301.
2112
2113         No new tests needed, existing tests have been removed by r166301.
2114
2115         * rendering/shapes/BoxShape.cpp:
2116         (WebCore::BoxShape::shapePaddingLogicalBoundingBox): Deleted.
2117         (WebCore::BoxShape::shapePaddingBounds): Deleted.
2118         (WebCore::BoxShape::getIncludedIntervals): Deleted.
2119         (WebCore::BoxShape::firstIncludedIntervalLogicalTop): Deleted.
2120         * rendering/shapes/BoxShape.h:
2121         * rendering/shapes/PolygonShape.cpp:
2122         (WebCore::leftSide): Deleted.
2123         (WebCore::isReflexVertex): Deleted.
2124         (WebCore::computeShapePaddingBounds): Deleted.
2125         (WebCore::PolygonShape::shapePaddingBounds): Deleted.
2126         (WebCore::PolygonShape::getIncludedIntervals): Deleted.
2127         (WebCore::firstFitRectInPolygon): Deleted.
2128         (WebCore::aboveOrToTheLeft): Deleted.
2129         (WebCore::PolygonShape::firstIncludedIntervalLogicalTop): Deleted.
2130         * rendering/shapes/PolygonShape.h:
2131         (WebCore::PolygonShape::PolygonShape):
2132         * rendering/shapes/RasterShape.cpp:
2133         (WebCore::RasterShapeIntervals::firstIncludedIntervalY): Deleted.
2134         (WebCore::RasterShapeIntervals::getIncludedIntervals): Deleted.
2135         (WebCore::RasterShape::paddingIntervals): Deleted.
2136         (WebCore::RasterShape::getIncludedIntervals): Deleted.
2137         (WebCore::RasterShape::firstIncludedIntervalLogicalTop): Deleted.
2138         * rendering/shapes/RasterShape.h:
2139         * rendering/shapes/RectangleShape.cpp:
2140         (WebCore::ellipseYIntercept): Deleted.
2141         (WebCore::RectangleShape::shapePaddingBounds): Deleted.
2142         (WebCore::RectangleShape::getIncludedIntervals): Deleted.
2143         (WebCore::cornerInterceptForWidth): Deleted.
2144         (WebCore::RectangleShape::firstIncludedIntervalLogicalTop): Deleted.
2145         * rendering/shapes/RectangleShape.h:
2146         * rendering/shapes/Shape.cpp:
2147         (WebCore::Shape::createShape):
2148         (WebCore::Shape::createRasterShape):
2149         (WebCore::Shape::createBoxShape):
2150         * rendering/shapes/Shape.h:
2151         (WebCore::Shape::lineOverlapsShapePaddingBounds): Deleted.
2152         (WebCore::Shape::shapePadding): Deleted.
2153         * rendering/shapes/ShapeInfo.cpp:
2154         (WebCore::ShapeInfo<RenderType>::computedShape):
2155         * rendering/style/RenderStyle.cpp:
2156         (WebCore::RenderStyle::changeRequiresLayout):
2157         * rendering/style/RenderStyle.h:
2158         * rendering/style/StyleRareNonInheritedData.cpp:
2159         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2160         (WebCore::StyleRareNonInheritedData::operator==):
2161         * rendering/style/StyleRareNonInheritedData.h:
2162
2163 2014-03-26  Jeremy Jones  <jeremyj@apple.com>
2164
2165         Implement hasLiveStreamingContent property in WebAVPlayerController
2166         https://bugs.webkit.org/show_bug.cgi?id=128684
2167
2168         Reviewed by Simon Fraser.
2169
2170         * WebCore.exp.in:
2171         Add export for WebVideoFullscreenInterfaceAVKit::setSeekableRanges().
2172
2173         * platform/ios/WebVideoFullscreenInterface.h:
2174         Add setSeekableRanges()
2175
2176         * platform/ios/WebVideoFullscreenInterfaceAVKit.h:
2177         Add setSeekableRanges()
2178
2179         * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
2180         Remove vestigial playerLayer property. Add seekableTimeRanges property.
2181
2182         (-[WebAVPlayerController dealloc]):
2183         Release _seekableTimeRanges.
2184         Remove references to _playerLayer.
2185
2186         (-[WebAVPlayerController hasLiveStreamingContent]):
2187         Implement based on duration. Live stream has an infinite duration.
2188
2189         (+[WebAVPlayerController keyPathsForValuesAffectingHasLiveStreamingContent]):
2190         Describe dependent keys for computed property hasLiveStreamingContent.
2191
2192         (-[WebAVPlayerController skipBackwardThirtySeconds:]):
2193         Seek back 30 seconds if that time is in the seekable ranges.
2194
2195         (-[WebAVPlayerController gotoEndOfSeekableRanges:]):
2196         Jump to live by going to the of the seekable ranges.
2197
2198         (WebVideoFullscreenInterfaceAVKit::setSeekableRanges):
2199         Convert TimeRange to CMTimeRange.
2200
2201         * platform/ios/WebVideoFullscreenModelMediaElement.mm:
2202         (WebVideoFullscreenModelMediaElement::setMediaElement):
2203         Set initial seekable ranges.
2204
2205         (WebVideoFullscreenModelMediaElement::handleEvent):
2206         Update seekable ranges when time changes.
2207
2208 2014-03-26  Brent Fulgham  <bfulgham@apple.com>
2209
2210         Fix OS X build.
2211
2212         * WebCore.exp.in: Add missing export symbol.
2213
2214 2014-03-26  Simon Fraser  <simon.fraser@apple.com>
2215
2216         Fix the Windows build. Add a no-op impl for Mac non-UI-side.
2217
2218         * platform/graphics/ca/mac/PlatformCALayerMac.h:
2219         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
2220         (PlatformCALayerWin::PlatformCALayerWin):
2221         * platform/graphics/ca/win/PlatformCALayerWin.h:
2222
2223 2014-03-26  Simon Fraser  <simon.fraser@apple.com>
2224
2225         REGRESSION (r155977): matrix animations no longer animate
2226         https://bugs.webkit.org/show_bug.cgi?id=130789
2227         <rdar://problem/15650946>
2228
2229         Reviewed by Dean Jackson.
2230         
2231         r155977 erroneously removed two lines that set the end points for
2232         matrix animations (used when transform lists don't match), so
2233         put them back.
2234         
2235         Also don't repaint when updateContentsScale()
2236         is called and doesn't change the contents scale.
2237
2238         Test: compositing/animation/matrix-animation.html
2239
2240         * platform/graphics/ca/GraphicsLayerCA.cpp:
2241         (WebCore::GraphicsLayerCA::updateRootRelativeScale):
2242         (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
2243         (WebCore::GraphicsLayerCA::updateContentsScale):
2244
2245 2014-03-26  Simon Fraser  <simon.fraser@apple.com>
2246
2247         Add a custom behavior flag to GraphicsLayer, piped down to PlatformCALayer, for scrolling layers
2248         https://bugs.webkit.org/show_bug.cgi?id=130778
2249
2250         Reviewed by Tim Horton.
2251
2252         Make it possible to put a "custom behavior" flag on a layer so that,
2253         with UI-side compositing, we know to create a specific type of
2254         layer or view for that GraphicsLayer.
2255
2256         * WebCore.exp.in:
2257         * platform/graphics/GraphicsLayer.cpp:
2258         (WebCore::GraphicsLayer::GraphicsLayer):
2259         * platform/graphics/GraphicsLayer.h:
2260         (WebCore::GraphicsLayer::setCustomBehavior):
2261         (WebCore::GraphicsLayer::customBehavior):
2262         * platform/graphics/ca/GraphicsLayerCA.cpp:
2263         (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
2264         (WebCore::GraphicsLayerCA::updateCustomBehavior):
2265         (WebCore::GraphicsLayerCA::setCustomBehavior):
2266         * platform/graphics/ca/GraphicsLayerCA.h:
2267         * platform/graphics/ca/PlatformCALayer.h:
2268         * platform/graphics/ca/mac/PlatformCALayerMac.h:
2269         * platform/graphics/ca/mac/PlatformCALayerMac.mm:
2270         (PlatformCALayerMac::PlatformCALayerMac):
2271         * rendering/RenderLayerBacking.cpp:
2272         (WebCore::RenderLayerBacking::updateScrollingLayers):
2273
2274 2014-03-26  Brent Fulgham  <bfulgham@apple.com>
2275
2276         Unreviewed test correction.
2277
2278         Because of the way DRT on Windows links to WebCore, having the implementaion of the update
2279         method in the header caused a runtime failure due to duplicate symbols being bound to the
2280         compilation unit.
2281
2282         * accessibility/AXObjectCache.cpp:
2283         (WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility): Moved from header.
2284         * accessibility/AXObjectCache.h:
2285         (WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility): Deleted.
2286
2287 2014-03-26  Jer Noble  <jer.noble@apple.com>
2288
2289         REGRESSION(r162679): Poster image visible under the video
2290         https://bugs.webkit.org/show_bug.cgi?id=130783
2291
2292         Reviewed by Simon Fraser.
2293
2294         In the listed revision, we started checking for isRenderImage()
2295         instead of isImage(). RenderMedias return 'true' for the first
2296         but 'false' for the second. Change the if() statement to check
2297         for isRenderMedia() in addition to !isRenderImage().
2298
2299         * rendering/RenderLayerBacking.cpp:
2300         (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
2301
2302 2014-03-26  Antti Koivisto  <antti@apple.com>
2303
2304         Render tree construction is O(N^2) in number of siblings
2305         https://bugs.webkit.org/show_bug.cgi?id=129065
2306
2307         Reviewed by Darin Adler.
2308         
2309         When adding a new renderer to the tree we would search for the correct render tree
2310         position by traversing DOM children forward to find something that already has a renderer.
2311         In common case there is no such renderer. This would be repeated for each inserted renderer
2312         leading to O(n^2) in respect to child node count.
2313         
2314         This patch caches the computed render tree insertion position and passes it to siblings.
2315         Until the cached position is reached it can be used for all new renderers.
2316
2317         Test: perf/sibling-renderer-On2.html
2318
2319         * style/StyleResolveTree.cpp:
2320         (WebCore::Style::RenderTreePosition::parent):
2321         (WebCore::Style::RenderTreePosition::RenderTreePosition):
2322         (WebCore::Style::RenderTreePosition::canInsert):
2323         (WebCore::Style::RenderTreePosition::insert):
2324         (WebCore::Style::RenderTreePosition::computeNextSibling):
2325         (WebCore::Style::RenderTreePosition::invalidateNextSibling):
2326         (WebCore::Style::styleForElement):
2327         (WebCore::Style::elementInsideRegionNeedsRenderer):
2328         (WebCore::Style::createRendererIfNeeded):
2329         (WebCore::Style::createTextRendererIfNeeded):
2330         (WebCore::Style::attachTextRenderer):
2331         (WebCore::Style::updateTextRendererAfterContentChange):
2332         (WebCore::Style::attachChildren):
2333         (WebCore::Style::attachDistributedChildren):
2334         (WebCore::Style::attachShadowRoot):
2335         (WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
2336         (WebCore::Style::attachRenderTree):
2337         (WebCore::Style::resolveLocal):
2338         (WebCore::Style::resolveTextNode):
2339         (WebCore::Style::resolveShadowTree):
2340         (WebCore::Style::updateBeforeOrAfterPseudoElement):
2341         (WebCore::Style::resolveTree):
2342
2343 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2344
2345         Unreviewed, rolling out r166264.
2346         https://bugs.webkit.org/show_bug.cgi?id=130785
2347
2348         Broke some window.opener tests for WK2 Mavericks (Requested by
2349         brrian__ on #webkit).
2350
2351         Reverted changeset:
2352
2353         "Web Replay: resource unique identifiers should be unique-per-
2354         frame, not globally"
2355         https://bugs.webkit.org/show_bug.cgi?id=130632
2356         http://trac.webkit.org/changeset/166264
2357
2358 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2359
2360         [CSS Shapes] Remove shape-inside support
2361         https://bugs.webkit.org/show_bug.cgi?id=130698
2362
2363         Reviewed by David Hyatt.
2364
2365         CSS Shapes Level 1 (CR) only contains shape-outside. We are focusing our efforts on finalizing
2366         the implementation of shape-outside, it's worth to remove shape-inside code at this point for now.
2367
2368         A list of reasons for the removal:
2369           - Shape-inside is only part of Shapes Level 2, which needs to be improved on some topics.
2370           - Shape-inside is lack of new shapes support (e.g. inset).
2371           - Deprecated shapes (r165472) are removed from the code (e.g. rectangle), which affects shape-inside. 
2372           - The current shape-inside code spreads across the layout code.
2373           - The current shape-inside implementation is experimental in some areas,
2374             and the partially implemented code can have security implications.
2375           - Removal of shape-inside opens possibilities for code complexity and performance
2376             optimizations for shape-outside. (e.g. simpler geometry code)
2377
2378         No new tests are needed.
2379
2380         * CMakeLists.txt:
2381         * Configurations/FeatureDefines.xcconfig:
2382         * GNUmakefile.list.am:
2383         * WebCore.xcodeproj/project.pbxproj:
2384         * css/CSSComputedStyleDeclaration.cpp:
2385         (WebCore::ComputedStyleExtractor::propertyValue):
2386         * css/CSSParser.cpp:
2387         (WebCore::isSimpleLengthPropertyID):
2388         (WebCore::CSSParser::parseValue):
2389         (WebCore::CSSParser::parseShapeProperty):
2390         * css/CSSPropertyNames.in:
2391         * css/DeprecatedStyleBuilder.cpp:
2392         (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
2393         * css/StyleResolver.cpp:
2394         (WebCore::StyleResolver::applyProperty):
2395         (WebCore::StyleResolver::loadPendingImages):
2396         * page/animation/CSSPropertyAnimation.cpp:
2397         (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
2398         * rendering/LayoutState.cpp:
2399         (WebCore::LayoutState::LayoutState):
2400         * rendering/LayoutState.h:
2401         (WebCore::LayoutState::LayoutState):
2402         (WebCore::LayoutState::shapeInsideInfo): Deleted.
2403         * rendering/RenderBlock.cpp:
2404         (WebCore::RenderBlock::styleDidChange):
2405         (WebCore::RenderBlock::imageChanged):
2406         (WebCore::RenderBlock::preparePaginationBeforeBlockLayout):
2407         (WebCore::RenderBlock::relayoutShapeDescendantIfMoved): Deleted.
2408         (WebCore::RenderBlock::logicalOffsetFromShapeAncestorContainer): Deleted.
2409         (WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange): Deleted.
2410         (WebCore::RenderBlock::ensureShapeInsideInfo): Deleted.
2411         (WebCore::RenderBlock::shapeInsideInfo): Deleted.
2412         (WebCore::RenderBlock::setShapeInsideInfo): Deleted.
2413         (WebCore::RenderBlock::markShapeInsideDescendantsForLayout): Deleted.
2414         (WebCore::RenderBlock::layoutShapeInsideInfo): Deleted.
2415         (WebCore::shapeInfoRequiresRelayout): Deleted.
2416         (WebCore::RenderBlock::computeShapeSize): Deleted.
2417         (WebCore::RenderBlock::updateShapesBeforeBlockLayout): Deleted.
2418         (WebCore::RenderBlock::updateShapesAfterBlockLayout): Deleted.
2419         (WebCore::RenderBlock::prepareShapesAndPaginationBeforeBlockLayout): Deleted.
2420         * rendering/RenderBlock.h:
2421         (WebCore::RenderBlock::allowsShapeInsideInfoSharing): Deleted.
2422         * rendering/RenderBlockFlow.cpp:
2423         (WebCore::RenderBlockFlow::layoutBlock):
2424         (WebCore::RenderBlockFlow::layoutBlockChild):
2425         (WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
2426         * rendering/RenderBlockFlow.h:
2427         * rendering/RenderBlockLineLayout.cpp:
2428         (WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
2429         (WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
2430         (WebCore::constructBidiRunsForLine): Deleted.
2431         (WebCore::pushShapeContentOverflowBelowTheContentBox): Deleted.
2432         (WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLine): Deleted.
2433         (WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread): Deleted.
2434         (WebCore::adjustLogicalLineTop): Deleted.
2435         (WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded): Deleted.
2436         * rendering/RenderDeprecatedFlexibleBox.cpp:
2437         (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
2438         * rendering/RenderElement.cpp:
2439         (WebCore::RenderElement::~RenderElement):
2440         (WebCore::RenderElement::initializeStyle):
2441         (WebCore::RenderElement::setStyle):
2442         * rendering/RenderFlexibleBox.cpp:
2443         (WebCore::RenderFlexibleBox::layoutBlock):
2444         * rendering/RenderGrid.cpp:
2445         (WebCore::RenderGrid::layoutBlock):
2446         * rendering/RenderNamedFlowFragment.cpp:
2447         (WebCore::RenderNamedFlowFragment::createStyle):
2448         * rendering/RenderView.h:
2449         * rendering/SimpleLineLayout.cpp:
2450         (WebCore::SimpleLineLayout::canUseFor):
2451         * rendering/line/BreakingContextInlineHeaders.h:
2452         (WebCore::BreakingContext::handleText):
2453         (WebCore::BreakingContext::handleEndOfLine):
2454         (WebCore::updateSegmentsForShapes): Deleted.
2455         * rendering/line/LineBreaker.cpp:
2456         (WebCore::LineBreaker::nextLineBreak):
2457         * rendering/line/LineWidth.cpp:
2458         (WebCore::LineWidth::LineWidth):
2459         (WebCore::LineWidth::updateAvailableWidth):
2460         (WebCore::LineWidth::wrapNextToShapeOutside):
2461         (WebCore::LineWidth::fitBelowFloats):
2462         (WebCore::LineWidth::updateLineSegment): Deleted.
2463         (WebCore::LineWidth::updateCurrentShapeSegment): Deleted.
2464         * rendering/line/LineWidth.h:
2465         * rendering/shapes/ShapeInsideInfo.cpp: Removed.
2466         * rendering/shapes/ShapeInsideInfo.h: Removed.
2467         * rendering/style/RenderStyle.cpp:
2468         (WebCore::RenderStyle::changeRequiresLayout):
2469         * rendering/style/RenderStyle.h:
2470         * rendering/style/StyleRareNonInheritedData.cpp:
2471         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2472         (WebCore::StyleRareNonInheritedData::operator==):
2473         * rendering/style/StyleRareNonInheritedData.h:
2474
2475 2014-03-25  Brent Fulgham  <bfulgham@apple.com>
2476
2477         Avoid duplicate size checks when creating empty image
2478         https://bugs.webkit.org/show_bug.cgi?id=130730
2479
2480         Reviewed by Dean Jackson.
2481
2482         Merged from Blink (patch by ch.dumez@samsung.com):
2483         https://chromium.googlesource.com/chromium/blink/+/4861a71bc1f284fc97417f405ab7d08dc6947b88
2484         http://crbug.com/190633011
2485
2486         * html/canvas/CanvasRenderingContext2D.cpp:
2487         (WebCore::createEmptyImageData): Don't perform overflow calculation twice.
2488
2489 2014-03-26  Sergio Villar Senin  <svillar@igalia.com>
2490
2491         [CSS Grid Layout] getComputedStyle() must return the specified value for positioning properties
2492         https://bugs.webkit.org/show_bug.cgi?id=130010
2493
2494         Reviewed by Darin Adler.
2495
2496         According to the specs
2497         http://dev.w3.org/csswg/css-grid/#property-index and also to
2498         http://lists.w3.org/Archives/Public/www-style/2014Mar/0162.html
2499         the function getComputedStyle() must return the specified values
2500         for positioning properties, i.e, grid-{columns|rows}-{start|end}.
2501
2502         We were in some cases, adjusting the style in the StyleResolver
2503         (for example with two opposing spans) something that is now done
2504         in the RenderGrid because we cannot alter the original style.
2505
2506         The code moved to the renderer became more self explanatory and it
2507         now supports named grid areas with names ending in "-start" and
2508         "-end".
2509
2510         Test: fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html
2511
2512         * css/StyleResolver.cpp:
2513         (WebCore::StyleResolver::adjustRenderStyle):
2514         (WebCore::gridLineDefinedBeforeGridArea): Deleted.
2515         (WebCore::StyleResolver::adjustNamedGridItemPosition): Deleted.
2516         (WebCore::StyleResolver::adjustGridItemPosition): Deleted.
2517         * css/StyleResolver.h:
2518         * rendering/RenderGrid.cpp:
2519         (WebCore::isColumnSide):
2520         (WebCore::RenderGrid::explicitGridSizeForSide):
2521         (WebCore::gridLineDefinedBeforeGridArea):
2522         (WebCore::setNamedLinePositionIfDefinedBeforeArea):
2523         (WebCore::RenderGrid::adjustNamedGridItemPosition):
2524         (WebCore::RenderGrid::adjustGridPositionsFromStyle):
2525         (WebCore::RenderGrid::resolveGridPositionsFromStyle):
2526         (WebCore::RenderGrid::resolveNamedGridLinePositionFromStyle):
2527         (WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition):
2528         * rendering/RenderGrid.h:
2529         * rendering/style/GridPosition.h:
2530         (WebCore::GridPosition::setAutoPosition): New helper function.
2531
2532 2014-03-26  Simon Fraser  <simon.fraser@apple.com>
2533
2534         Fix the iOS build.
2535
2536         * WebCore.exp.in:
2537
2538 2014-03-26  Tim Horton  <timothy_horton@apple.com>
2539
2540         [iOS WebKit2] Flush all surfaces after painting into all of them, instead of after painting into each one
2541         https://bugs.webkit.org/show_bug.cgi?id=130768
2542         <rdar://problem/16421471>
2543
2544         Reviewed by Simon Fraser.
2545
2546         * platform/graphics/cocoa/IOSurface.h:
2547         Add a non-ensuring platformContext() getter.
2548
2549 2014-03-26  James Craig  <jcraig@apple.com>
2550
2551         Web Inspector: AXI: crash when inspecting "bar" text node in getAccessibilityPropertiesForNode layout test
2552         https://bugs.webkit.org/show_bug.cgi?id=130290
2553
2554         Reviewed by Timothy Hatcher.
2555
2556         Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
2557
2558         Fixing regression from r165590. http://webkit.org/b/129779
2559         Verify isElementNode to avoid calling toElement on document or text nodes.
2560
2561         * inspector/InspectorDOMAgent.cpp:
2562         (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
2563
2564 2014-03-25  Sergio Villar Senin  <svillar@igalia.com>
2565
2566         Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in editing/
2567         https://bugs.webkit.org/show_bug.cgi?id=130722
2568
2569         Reviewed by Antti Koivisto.
2570
2571         * editing/AlternativeTextController.cpp:
2572         (WebCore::markerTypesForAutocorrection):
2573         (WebCore::markerTypesForReplacement):
2574         (WebCore::markerTypesForAppliedDictationAlternative):
2575         * editing/EditingStyle.cpp:
2576         (WebCore::htmlElementEquivalents):
2577         (WebCore::htmlAttributeEquivalents):
2578         * editing/FormatBlockCommand.cpp:
2579         (WebCore::isElementForFormatBlock):
2580         * editing/RemoveFormatCommand.cpp:
2581         (WebCore::isElementForRemoveFormatCommand):
2582         * editing/ReplaceSelectionCommand.cpp:
2583         (WebCore::isProhibitedParagraphChild):
2584         * editing/atk/FrameSelectionAtk.cpp:
2585         (WebCore::maybeEmitTextFocusChange):
2586
2587 2014-03-25  Simon Fraser  <simon.fraser@apple.com>
2588
2589         Add a new type of scrolling tree node for overflow scrolling
2590         https://bugs.webkit.org/show_bug.cgi?id=130763
2591
2592         Reviewed by Tim Horton.
2593
2594         Prepare for overflow scrolling via the scrolling tree by adding
2595         a new scrolling node type for overflow:scroll nodes. Mostly
2596         this is a new ScrollingNodeType that gets mapped to the same
2597         scrolling state nodes and scrolling nodes, but iOS creates
2598         state and scrolling nodes specific to overflow:scroll.
2599         
2600         Change the type checking on nodes to use virtual functions instead
2601         of just checking the node type, to allow the macros to work with
2602         the new scrolling node type.
2603
2604         * WebCore.exp.in:
2605         * page/scrolling/AsyncScrollingCoordinator.cpp:
2606         (WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
2607         * page/scrolling/ScrollingCoordinator.h:
2608         * page/scrolling/ScrollingStateFixedNode.h:
2609         * page/scrolling/ScrollingStateNode.h:
2610         (WebCore::ScrollingStateNode::isFixedNode):
2611         (WebCore::ScrollingStateNode::isStickyNode):
2612         (WebCore::ScrollingStateNode::isScrollingNode):
2613         * page/scrolling/ScrollingStateScrollingNode.cpp:
2614         (WebCore::ScrollingStateScrollingNode::create):
2615         (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
2616         * page/scrolling/ScrollingStateScrollingNode.h:
2617         * page/scrolling/ScrollingStateStickyNode.h:
2618         * page/scrolling/ScrollingStateTree.cpp:
2619         (WebCore::ScrollingStateTree::attachNode):
2620         * page/scrolling/ScrollingTree.cpp:
2621         (WebCore::ScrollingTree::viewportChangedViaDelegatedScrolling):
2622         (WebCore::ScrollingTree::updateTreeFromStateNode):
2623         * page/scrolling/ScrollingTreeNode.h:
2624         (WebCore::ScrollingTreeNode::isFixedNode):
2625         (WebCore::ScrollingTreeNode::isStickyNode):
2626         (WebCore::ScrollingTreeNode::isScrollingNode):
2627         * page/scrolling/ScrollingTreeScrollingNode.cpp:
2628         (WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
2629         * page/scrolling/ScrollingTreeScrollingNode.h:
2630         * page/scrolling/ios/ScrollingCoordinatorIOS.mm:
2631         (WebCore::ScrollingCoordinatorIOS::createScrollingTreeNode):
2632         * page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
2633         * page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:
2634         (WebCore::ScrollingTreeScrollingNodeIOS::create):
2635         (WebCore::ScrollingTreeScrollingNodeIOS::ScrollingTreeScrollingNodeIOS):
2636         * page/scrolling/mac/ScrollingCoordinatorMac.mm:
2637         (WebCore::ScrollingCoordinatorMac::createScrollingTreeNode):
2638         * page/scrolling/mac/ScrollingTreeFixedNode.h:
2639         * page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
2640         * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
2641         (WebCore::ScrollingTreeScrollingNodeMac::create):
2642         (WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
2643         * page/scrolling/mac/ScrollingTreeStickyNode.h:
2644         * rendering/RenderLayerCompositor.cpp:
2645         (WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
2646
2647 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2648
2649         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2650         https://bugs.webkit.org/show_bug.cgi?id=130575
2651
2652         Reviewed by Mario Sanchez Prada.
2653
2654         ATK 2.11.92 introduces some new API and deprecates an old one.
2655         Adjust current implementation to meet requirements of the new API.
2656
2657         No new tests. Covered by existing ones.
2658
2659         * accessibility/atk/AXObjectCacheAtk.cpp:
2660         (WebCore::AXObjectCache::postPlatformNotification):
2661         * accessibility/atk/WebKitAccessibleInterfaceValue.cpp:
2662         (webkitAccessibleSetNewValue):
2663         (webkitAccessibleGetIncrementValue):
2664         (webkitAccessibleGetValueAndText):
2665         (webkitAccessibleGetIncrement):
2666         (webkitAccessibleSetValue):
2667         (webkitAccessibleGetRange):
2668         (webkitAccessibleValueSetCurrentValue):
2669         (webkitAccessibleValueGetMinimumIncrement):
2670         (webkitAccessibleValueInterfaceInit):
2671
2672 2014-03-26  Zan Dobersek  <zdobersek@igalia.com>
2673
2674         Unreviewed. Removing the remaining Automake cruft.
2675
2676         * GNUmakefile.list.am: Removed.
2677
2678 2014-03-25  Pratik Solanki  <psolanki@apple.com>
2679
2680         iOS build fix. Add missing semicolon.
2681
2682         * editing/cocoa/HTMLConverter.mm:
2683         (HTMLConverter::_addAttachmentForElement):
2684
2685 2014-03-25  Sam Weinig  <sam@webkit.org>
2686
2687         Speculative iOS build fix.
2688
2689         * editing/cocoa/HTMLConverter.mm:
2690         (HTMLConverter::_addAttachmentForElement):
2691
2692 2014-03-25  Jer Noble  <jer.noble@apple.com>
2693
2694         [MSE] Duplicate 'seeked' events.
2695         https://bugs.webkit.org/show_bug.cgi?id=130754
2696
2697         Reviewed by Eric Carlson.
2698
2699         Test: media/media-source/media-source-duplicate-seeked.html
2700
2701         During certain seek operations, HTMLMediaElement::finishSeek() can be called re-entrantly due to
2702         the ready state changing as a result of MediaSource::monitorSourceBuffers(). Move this call to the
2703         end of finishSeek() after m_seeking has been cleared.
2704
2705         * html/HTMLMediaElement.cpp:
2706         (WebCore::HTMLMediaElement::parseAttribute):
2707
2708 2014-03-25  James Craig  <jcraig@apple.com>
2709
2710         Web Inspector: AXI: add support for aria-activedescendant and reconcile UI/testing with parentNode
2711         https://bugs.webkit.org/show_bug.cgi?id=130712
2712
2713         Reviewed by Timothy Hatcher.
2714
2715         Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html
2716
2717         Support for @aria-activedescendant; code reuse changes w/ parentNode and activeDescendantNode.
2718
2719         * inspector/InspectorDOMAgent.cpp:
2720         (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
2721         * inspector/protocol/DOM.json:
2722
2723 2014-03-25  Sanghyup Lee  <sh53.lee@samsung.com>
2724
2725         When the mouse is upped after dragged out of shadowDOM, it should lose :active.
2726         https://bugs.webkit.org/show_bug.cgi?id=130660
2727
2728         Reviewed by Darin Adler.
2729
2730         This caused a regression after r165037.
2731         When we have to clear :active style of shadow DOM, we should clear host's style.
2732         This patch replaces parentElement() by parentOrShadowHostElement().
2733
2734         * dom/Document.cpp:
2735         (WebCore::Document::updateHoverActiveState):
2736
2737 2014-03-25  Eric Carlson  <eric.carlson@apple.com>
2738
2739         [Mac] Always retry a failed MediaDocument as a PluginDocument
2740         https://bugs.webkit.org/show_bug.cgi?id=130742
2741
2742         Reviewed by Jer Noble.
2743
2744         * html/HTMLMediaElement.cpp:
2745         (WebCore::HTMLMediaElement::mediaLoadingFailedFatally): If the element is in a media document,
2746             tell it that loading failed so it can retry as a plug-in.
2747
2748 2014-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2749
2750         Replace HTMLConverter::_stringForNode by propertyValueForNode
2751         https://bugs.webkit.org/show_bug.cgi?id=130711
2752
2753         Reviewed by Sam Weinig.
2754
2755         Replaced all calls to HTMLConverter::_stringForNode by that to propertyValueForNode.
2756
2757         * editing/cocoa/HTMLConverter.mm:
2758         (HTMLConverter::_computedAttributesForElement):
2759         (HTMLConverter::_addAttachmentForElement):
2760         (HTMLConverter::_enterElement):
2761         (HTMLConverter::_addTableForElement):
2762         (HTMLConverter::_addTableCellForElement):
2763         (HTMLConverter::_processElement):
2764         (HTMLConverter::_exitElement):
2765         (HTMLConverter::_processText):
2766         (HTMLConverter::_traverseNode):
2767         (HTMLConverter::_traverseFooterNode):
2768         (HTMLConverter::_stringForNode): Deleted.
2769
2770 2014-03-25  Pratik Solanki  <psolanki@apple.com>
2771
2772         Attempt to fix iOS build after r166261.
2773
2774         * WebCore.xcodeproj/project.pbxproj: Make SystemSleepListener.h a private header.
2775
2776 2014-03-21  Jer Noble  <jer.noble@apple.com>
2777
2778         [iOS] Enable caption support in full screen.
2779         https://bugs.webkit.org/show_bug.cgi?id=130603
2780
2781         Reviewed by Eric Carlson.
2782
2783         Add TextTrackRepresentation support to MediaPlayerPrivateAVFoundationObjC.
2784
2785         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
2786         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
2787         (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Add the m_textTrackRepresenationLayer if present.
2788         (WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer): Ditto.
2789         (WebCore::MediaPlayerPrivateAVFoundationObjC::requiresTextTrackRepresentation): True, if a m_videoFullscreenLayer is present.
2790         (WebCore::MediaPlayerPrivateAVFoundationObjC::setTextTrackRepresentation): Remove the old, and add the new m_textTrackRepresenationLayer.
2791
2792         Make the text track container a stacking context for painting purposes.
2793         * Modules/mediacontrols/mediaControlsiOS.css:
2794         (video::-webkit-media-text-track-container):
2795
2796 2014-03-25  Brian Burg  <bburg@apple.com>
2797
2798         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2799         https://bugs.webkit.org/show_bug.cgi?id=130632
2800
2801         Reviewed by Timothy Hatcher.
2802
2803         For replay purposes, we want to deterministically assign resource load identifiers
2804         to resource loaders, provided that the resource loaders are created in the same
2805         order.
2806
2807         To do this, we convert unique identifiers from being globally-unique to being
2808         frame-unique. When a new frame is being loaded, unique identifiers for
2809         subresources of that frame begin counting from 1.
2810
2811         No new tests. Identifier invariants are exercised by existing assertions and tests.
2812
2813         * loader/ProgressTracker.cpp:
2814         (WebCore::ProgressTracker::ProgressTracker):
2815         (WebCore::ProgressTracker::reset):
2816         (WebCore::ProgressTracker::createUniqueIdentifier):
2817         * loader/ProgressTracker.h:
2818
2819 2014-03-25  Jer Noble  <jer.noble@apple.com>
2820
2821         [Mac] Pause the media element during system sleep.
2822         https://bugs.webkit.org/show_bug.cgi?id=130718
2823
2824         Reviewed by Eric Carlson.
2825
2826         Test: media/video-system-sleep.html
2827
2828         Relying on the platform media system to pause and restart playback during
2829         system sleep can cause problems on some platforms, especially where hardware
2830         decoders are concerned. Rather than implicitly pausing the media during
2831         system sleep, explicitly pause the media before sleeping and resume (if
2832         appropriate) upon waking.
2833
2834         Add a new class to be used for system sleep notifications:
2835         * platform/SystemSleepListener.cpp: Added.
2836         (WebCore::SystemSleepListener::create):
2837         (WebCore::SystemSleepListener::SystemSleepListener):
2838         * platform/SystemSleepListener.h: Added.
2839         (WebCore::SystemSleepListener::Client::~Client):
2840         (WebCore::SystemSleepListener::~SystemSleepListener):
2841         (WebCore::SystemSleepListener::client):
2842
2843         Add a Mac-specific implementation:
2844         * platform/mac/SystemSleepListenerMac.h: Added.
2845         * platform/mac/SystemSleepListenerMac.mm: Added.
2846         (WebCore::SystemSleepListener::create):
2847         (WebCore::SystemSleepListenerMac::SystemSleepListenerMac):
2848         (WebCore::SystemSleepListenerMac::~SystemSleepListenerMac):
2849
2850         Listen for system sleep notifications in MediaSessionManager:
2851         * platform/audio/MediaSessionManager.cpp:
2852         (WebCore::MediaSessionManager::MediaSessionManager):
2853         (WebCore::MediaSessionManager::systemWillSleep):
2854         (WebCore::MediaSessionManager::systemDidWake):
2855         * platform/audio/MediaSessionManager.h:
2856
2857         Drive-by fix; notify the MediaSession that playback will begin
2858         due to autoplay, but do not begin autoplaying if the session
2859         is already interrupted:
2860         * html/HTMLMediaElement.cpp:
2861         (WebCore::HTMLMediaElement::parseAttribute):
2862
2863         Add new files to project:
2864         * WebCore.vcxproj/WebCore.vcxproj:
2865         * WebCore.xcodeproj/project.pbxproj:
2866         * CMakeLists.txt:
2867         * GNUmakefile.list.am:
2868
2869 2014-03-25  Radu Stavila  <stavila@adobe.com>
2870
2871         [CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled
2872         https://bugs.webkit.org/show_bug.cgi?id=130574
2873
2874         Reviewed by David Hyatt.
2875
2876         When computing the clip rect for painting the box decorations, the scrolled content offset
2877         must be computed by going up the containing block tree, up to the region.
2878
2879         Tests: fast/regions/scrollable-region-scrollable-absolute-content-background.html
2880                fast/regions/scrollable-region-scrollable-content-background.html
2881
2882         * rendering/RenderNamedFlowThread.cpp:
2883         (WebCore::RenderNamedFlowThread::decorationsClipRectForBoxInNamedFlowFragment):
2884
2885 2014-03-25  Joseph Pecoraro  <pecoraro@apple.com>
2886
2887         [iOS] Inspector View Indication Support
2888         https://bugs.webkit.org/show_bug.cgi?id=130709
2889
2890         Reviewed by Simon Fraser.
2891
2892         * inspector/InspectorClient.h:
2893         (WebCore::InspectorClient::showInspectorIndication):
2894         (WebCore::InspectorClient::hideInspectorIndication):
2895         * inspector/InspectorController.cpp:
2896         (WebCore::InspectorController::setIndicating):
2897         Rename indicate/hideIndication to show/hide names.
2898
2899 2014-03-25  Brent Fulgham  <bfulgham@apple.com>
2900
2901         Unreviewed build fix. Typo on checkin.
2902
2903         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
2904         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Left an unmatched open bracket.
2905
2906 2014-03-25  Jer Noble  <jer.noble@apple.com>
2907
2908         Even further unreviewed build fix after r166247. Unprotect the implementation of HTMLMediaElement::shouldDisableSleep().
2909
2910         * html/HTMLMediaElement.cpp:
2911         (WebCore::HTMLMediaElement::parseAttribute):
2912
2913 2014-03-25  Jer Noble  <jer.noble@apple.com>
2914
2915         Further unreviewed build fix after r166247. Add DisplaySleepDisabler to the windows project file and
2916         move the definition of DisplaySleepDisabler's constructor and destructor into the cpp file.
2917
2918         * WebCore.vcxproj/WebCore.vcxproj:
2919         * platform/DisplaySleepDisabler.cpp:
2920         (WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
2921         (WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):
2922         * platform/DisplaySleepDisabler.h:
2923
2924 2014-03-25  Jer Noble  <jer.noble@apple.com>
2925
2926         Unreviewed build fix after r166247. Un-platform-protect the declaration of HTMLMediaElement::shouldDisableSleep()
2927         and make WebVideoFullscreenController's _displaySleepDisabler a std::unique_ptr.
2928
2929         * html/HTMLMediaElement.h:
2930         * platform/mac/WebVideoFullscreenController.h:
2931
2932 2014-03-25  Brent Fulgham  <bfulgham@apple.com>
2933
2934         [iOS] Pass additional options to AVFoundation during playback.
2935         https://bugs.webkit.org/show_bug.cgi?id=130624
2936
2937         Reviewed by Eric Carlson.
2938
2939         * html/HTMLMediaElement.cpp:
2940         (WebCore::HTMLMediaElement::doesHaveAttribute): Return attribute value if the user
2941         passes a pointer to fill in.
2942         * html/HTMLMediaElement.h:
2943         * platform/graphics/MediaPlayer.cpp:
2944         (WebCore::MediaPlayer::doesHaveAttribute):
2945         * platform/graphics/MediaPlayer.h:
2946         (WebCore::MediaPlayerClient::doesHaveAttribute):
2947         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
2948         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Pass additional
2949         option if supplied by user.
2950
2951 2014-03-25  Michael Saboff  <msaboff@apple.com>
2952
2953         Unreviewed, rolling out r166070.
2954
2955         Rollout r166070 due to 2% performance loss in page load times
2956
2957         Reverted changeset:
2958
2959         "Change CodeGeneratorJS.pm special cases for "DOMWindow" to be
2960         general purpose"
2961         https://bugs.webkit.org/show_bug.cgi?id=130553
2962         http://trac.webkit.org/changeset/166070
2963
2964 2014-03-25  Michael Saboff  <msaboff@apple.com>
2965
2966         Unreviewed, rolling out r166126.
2967
2968         Rollout r166126 in prepartion to roll out prerequisite r166070
2969
2970         Reverted changeset:
2971
2972         "toThis() on a JSWorkerGlobalScope should return a JSProxy and
2973         not undefined"
2974         https://bugs.webkit.org/show_bug.cgi?id=130554
2975         http://trac.webkit.org/changeset/166126
2976
2977 2014-03-25  Jer Noble  <jer.noble@apple.com>
2978
2979         [iOS] Playing video does not disable display sleep.
2980         https://bugs.webkit.org/show_bug.cgi?id=130729
2981
2982         Reviewed by Eric Carlson.
2983
2984         DisplaySleepDisabler was broken by r161589, which replaced the iOS implementation with
2985         an empty one. Make a platform independent version with a Cocoa-platform subclass. Update
2986         the APIs to non-deprecated ones.
2987
2988         * platform/DisplaySleepDisabler.cpp: Added.
2989         (WebCore::DisplaySleepDisabler::create):
2990         * platform/DisplaySleepDisabler.h: Added.
2991         (WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):
2992         (WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
2993         * platform/cocoa/DisplaySleepDisablerCocoa.cpp: Renamed from Source/WebCore/platform/mac/DisplaySleepDisabler.cpp.
2994         (WebCore::DisplaySleepDisabler::create):
2995         (WebCore::DisplaySleepDisablerCocoa::DisplaySleepDisablerCocoa):
2996         (WebCore::DisplaySleepDisablerCocoa::~DisplaySleepDisablerCocoa):
2997         * platform/cocoa/DisplaySleepDisablerCocoa.h: Renamed from Source/WebCore/platform/mac/DisplaySleepDisabler.h.
2998
2999         Update m_sleepDisabler to be a std::unique_ptr, and unprotect the definition of methods which use it.
3000         * html/HTMLMediaElement.cpp:
3001         (WebCore::HTMLMediaElement::updateSleepDisabling):
3002         (WebCore::HTMLMediaElement::shouldDisableSleep):
3003         * html/HTMLMediaElement.h:
3004
3005         Add the new and renamed files to the project:
3006         * CMakeLists.txt:
3007         * GNUmakefile.list.am:
3008         * WebCore.xcodeproj/project.pbxproj:
3009
3010 2014-03-25  Dirk Schulze  <krit@webkit.org>
3011
3012         Implement ImageData constructors and WebWorkers exposure
3013         https://bugs.webkit.org/show_bug.cgi?id=130668
3014
3015         Reviewed by Dean Jackson.
3016
3017         Add new constructors for ImageData.
3018
3019         http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation
3020
3021         Test: fast/canvas/canvas-imageData.html
3022
3023         * html/ImageData.cpp: 
3024         (WebCore::ImageData::create):
3025         * html/ImageData.h:
3026         * html/ImageData.idl:
3027
3028 2014-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
3029
3030         InlineIterator position (unsigned int) variable can wrap around
3031         https://bugs.webkit.org/show_bug.cgi?id=130540
3032
3033         Reviewed by Simon Fraser.
3034
3035         We trigger an ASSERT that occurs when we are ignoring spaces (to collapse them
3036         into a single whitespace mark) but then encounter a line break. Because we don't ignore
3037         the first space (but do ignore subsequent spaces), when we hit a newline in an RTL context
3038         we want to ignore that first space as well (so as not to push the text away from the right
3039         edge). We do this by decrementing the InlineIterator pointing to this first space, so all
3040         the spaces get ignored. However, if that space is the first character in a Text node, the
3041         decrement will try to go past the beginning of the node, and trigger an ASSERT.
3042
3043         This design is not great. At some point we should rework it to more elegantly handle
3044         collapsing whitespace in both RTL and LTR writing modes.
3045
3046         This patch adds an ASSERT earlier in this codepath to catch potential problems earlier.
3047         It also pulls our sentinel value out into a separate boolean to make it more clear what is
3048         going on.
3049
3050         Test: fast/text/whitespace-only-text-in-rtl.html
3051
3052         * rendering/InlineIterator.h:
3053         (WebCore::InlineIterator::moveTo): Use the set***() calls
3054         (WebCore::InlineIterator::setOffset): ASSERT early that our math hasn't wrapped
3055         * rendering/RenderBlockLineLayout.cpp:
3056         (WebCore::RenderBlockFlow::appendRunsForObject): Use new boolean value
3057         * rendering/line/BreakingContextInlineHeaders.h:
3058         (WebCore::BreakingContext::handleText): Guard against wraps
3059         (WebCore::checkMidpoints): Use new boolean value
3060         * rendering/line/TrailingObjects.cpp:
3061         (WebCore::TrailingObjects::updateMidpointsForTrailingBoxes): Use new boolean value
3062
3063 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3064
3065         [GTK] Remove the autotools build
3066         https://bugs.webkit.org/show_bug.cgi?id=130717
3067
3068         Reviewed by Anders Carlsson.
3069
3070         * GNUmakefile.am: Removed.
3071         * bindings/gobject/GNUmakefile.am: Removed.
3072         * config.h: Removed references to autotools configure file.
3073
3074 2014-03-24  Brent Fulgham  <bfulgham@apple.com>
3075
3076         Prevent 'removetrack' events from firing when all inband text tracks are removed.
3077         https://bugs.webkit.org/show_bug.cgi?id=130704
3078
3079         Reviewed by Eric Carlson.
3080
3081         Test: media/track/track-remove-track.html
3082
3083         Based on the Blink change (patch by acolwell@chromium.org):
3084         https://codereview.chromium.org/177243018/
3085
3086         * html/HTMLMediaElement.cpp:
3087         (WebCore::HTMLMediaElement::prepareForLoad): Reorder steps to match W3C specification.
3088         (WebCore::HTMLMediaElement::noneSupported): Forget tracks as required by specification.
3089         (WebCore::HTMLMediaElement::mediaLoadingFailed): Forget tracks as required by specification.
3090         (WebCore::HTMLMediaElement::removeTextTrack): Only request the 'removetracks' event if
3091         requested by caller.
3092         (WebCore::HTMLMediaElement::removeAllInbandTracks): Renamed to 'forgetResourceSpecificTracks'
3093         (WebCore::HTMLMediaElement::noneSupported): Specify that we want the 'removetracks' event
3094         fired for this use case.
3095         (WebCore::HTMLMediaElement::prepareForLoad): Switch to new 'forgetResourceSpecificTracks' name.
3096         * html/HTMLMediaElement.h:
3097         * html/track/TextTrackList.cpp:
3098         (TextTrackList::remove): Only fire the 'removetrack' event if the caller requests it.
3099         * html/track/TextTrackList.h: Add default argument to fire the 'removetrack' event
3100         when removing a track.
3101         * html/track/TrackListBase.cpp:
3102         (TrackListBase::remove): Only fire the 'removetrack' event if the caller requests it.
3103         * html/track/TrackListBase.h: Add default argument to fire the 'removetrack' event.
3104
3105 2014-03-25  David Kilzer  <ddkilzer@apple.com>
3106
3107         Hold a reference to firstSuccessfulSubmitButton in HTMLFormElement::submit
3108         <http://webkit.org/b/130713>
3109         <rdar://problem/15661876>
3110
3111         Reviewed by Darin Adler.
3112
3113         Merged from Blink (patch by Ian Beer):
3114         http://crbug.com/303657
3115         https://src.chromium.org/viewvc/blink?view=rev&revision=158938
3116
3117         Test: fast/forms/form-submission-crash-successful-submit-button.html
3118
3119         * html/HTMLFormElement.cpp:
3120         (WebCore::HTMLFormElement::submit):
3121
3122 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
3123
3124         [ARM64] GNU assembler fails in TransformationMatrix::multiply
3125         https://bugs.webkit.org/show_bug.cgi?id=130454
3126
3127         Reviewed by Zoltan Herczeg.
3128
3129         Change the NEON intstructions to the proper style.
3130
3131         * platform/graphics/transforms/TransformationMatrix.cpp:
3132         (WebCore::TransformationMatrix::multiply):
3133
3134 2014-03-20  Sergio Villar Senin  <svillar@igalia.com>
3135
3136         [CSS Grid Layout] Vertical rectangles not considered as valid grid areas
3137         https://bugs.webkit.org/show_bug.cgi?id=130513
3138
3139         Reviewed by Andreas Kling.
3140
3141         Grid areas sized as vertical rectangles were incorrectly
3142         considered as invalid by the parser. That's because the condition
3143         checking that each new row was adjacent to the previous one was
3144         using the first row of the currently parsed grid area instead of
3145         the last one.
3146
3147         Test: fast/css-grid-layout/grid-template-areas-get-set.html
3148
3149         * css/CSSParser.cpp:
3150         (WebCore::CSSParser::parseGridTemplateAreas):
3151
3152 2014-03-25  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3153
3154         [GTK] Volume slider shows below the panel with videos in certain cases
3155         https://bugs.webkit.org/show_bug.cgi?id=130608
3156
3157         Reviewed by Jer Noble.
3158
3159         We need to delay the moment we check if the volume slider shows up
3160         or down. If the video was not visible, the offsets were 0 and it
3161         was forced to be shown below the panel.
3162
3163         Test: media/video-initially-hidden-volume-slider-up.html
3164
3165         * Modules/mediacontrols/mediaControlsApple.js:
3166         (Controller.prototype.createControls): Moved volumebox pseudo from
3167         the subclass. The test checks for it and it would fail in Mac.
3168         * Modules/mediacontrols/mediaControlsGtk.js:
3169         (ControllerGtk.prototype.createControls): Moved volumebox pseudo
3170         to the superclass.
3171         (ControllerGtk.prototype.handleMuteButtonMouseOver): Check if
3172         volume slider should show up or down.
3173         (ControllerGtk.prototype.updateReadyState): Removed check for
3174         volume slider direction.
3175
3176 2014-03-24  Brent Fulgham  <bfulgham@apple.com>
3177
3178         [Win] Enable WebVTT Regions on Windows.
3179         https://bugs.webkit.org/show_bug.cgi?id=130680
3180
3181         Reviewed by Eric Carlson.
3182
3183         * DerivedSources.cpp: Add new build components.
3184         * WebCore.vcxproj/WebCore.vcxproj: Ditto.
3185         * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
3186
3187 2014-03-24  Simon Fraser  <simon.fraser@apple.com>
3188
3189         Remove some unnecessary includes from PlatformCALayerClient.h
3190         https://bugs.webkit.org/show_bug.cgi?id=130703
3191
3192         Reviewed by Andreas Kling.
3193         
3194         No need for all these #includes.
3195
3196         * platform/graphics/ca/PlatformCALayerClient.h:
3197
3198 2014-03-24  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3199
3200         [core] FEGaussianBlur: use IntSize to simplify member function interface
3201         https://bugs.webkit.org/show_bug.cgi?id=130695
3202
3203         Reviewed by Dean Jackson.
3204
3205         By returning an IntSize to store the calculated kernel size values
3206         it is possible to have less function parameters. This patch also
3207         streamlines a bit the code in calculateUnscaledKernelSize.
3208
3209         No new tests, no change in behavior.
3210
3211         * platform/graphics/filters/FEDropShadow.cpp:
3212         (WebCore::FEDropShadow::determineAbsolutePaintRect):
3213         * platform/graphics/filters/FEGaussianBlur.cpp:
3214         (WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
3215         (WebCore::FEGaussianBlur::calculateKernelSize):
3216         (WebCore::FEGaussianBlur::determineAbsolutePaintRect):
3217         (WebCore::FEGaussianBlur::platformApplySoftware):
3218         * platform/graphics/filters/FEGaussianBlur.h:
3219         (if): Deleted.
3220         * platform/graphics/filters/FilterOperations.cpp:
3221         (WebCore::outsetSizeForBlur):
3222
3223 2014-03-24  Brian Burg  <bburg@apple.com>
3224
3225         Web Replay: capture and replay keyboard events
3226         https://bugs.webkit.org/show_bug.cgi?id=130314
3227
3228         Reviewed by Joseph Pecoraro.
3229
3230         Upstream support for capturing and replaying non-IME keyboard input.
3231         This works similarly to mouse events. It introduces optional fields and
3232         macros to encode/decode them.
3233
3234         Test: ManualTests/inspector/replay-keyboard-events.html
3235
3236         * replay/ReplayInputDispatchMethods.cpp:
3237         (WebCore::HandleKeyPress::dispatch):
3238         * replay/SerializationMethods.cpp:
3239         (JSC::EncodingTraits<NondeterministicInputBase>::encodeValue):
3240         (JSC::EncodingTraits<NondeterministicInputBase>::decodeValue): Switch existing
3241         encode/decode calls to use the shortening macros.
3242         (JSC::EncodingTraits<KeypressCommand>::encodeValue): Added.
3243         (JSC::EncodingTraits<KeypressCommand>::decodeValue): Added.
3244         (JSC::PlatformKeyboardEventAppKit::PlatformKeyboardEventAppKit): Subclass
3245         PlatformKeyboardEvent so that we can set AppKit-specific members not
3246         initialized through the main constructors.
3247         (JSC::EncodingTraits<PlatformKeyboardEvent>::encodeValue): Added.
3248         (JSC::EncodingTraits<PlatformKeyboardEvent>::decodeValue): Added.
3249         * replay/SerializationMethods.h:
3250         * replay/UserInputBridge.cpp:
3251         (WebCore::UserInputBridge::UserInputBridge): initialize m_state inside a guard.
3252         (WebCore::UserInputBridge::handleKeyEvent): fill in the implementation.
3253         * replay/WebInputs.json:
3254
3255 2014-03-24  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
3256
3257         Optimizing string construction for type error in JSNavigatorCustom.cpp
3258         https://bugs.webkit.org/show_bug.cgi?id=130683
3259
3260         Reviewed by Eric Carlson.
3261
3262         * bindings/js/JSNavigatorCustom.cpp:
3263         (WebCore::JSNavigator::webkitGetUserMedia):
3264
3265 2014-03-24  Beth Dakin  <bdakin@apple.com>
3266
3267         Legacy-style scrollbars constantly redraw after scrolling
3268         https://bugs.webkit.org/show_bug.cgi?id=130699
3269
3270         Reviewed by Simon Fraser.
3271
3272         The constant re-draw was happening because we were never calling [ScrollbarPainter 
3273         setUsePresentationValue:NO]. This is a silly bug where were should have been 
3274         looking at PlatformWheelEvent::momentumPhase() instead of 
3275         PlatformWheelEvent::phase()
3276
3277         * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
3278         (WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):
3279
3280 2014-03-24  Daniel Bates  <dabates@apple.com>
3281
3282         XSS Auditor doesn't block <script> injected before an existing <script>
3283         https://bugs.webkit.org/show_bug.cgi?id=130475
3284
3285         Merged from Blink (patch by Tom Sepez):
3286         https://src.chromium.org/viewvc/blink?view=rev&revision=169697
3287
3288         Tests: http/tests/security/xssAuditor/script-tag-expression-follows.html
3289                http/tests/security/xssAuditor/script-tag-near-start.html
3290
3291         * html/parser/XSSAuditor.cpp:
3292         (WebCore::startsHTMLCommentAt):
3293         (WebCore::startsSingleLineCommentAt):
3294         (WebCore::startsMultiLineCommentAt):
3295         (WebCore::startsOpeningScriptTagAt):
3296         (WebCore::XSSAuditor::decodedSnippetForJavaScript):
3297
3298 2014-03-24  Brent Fulgham  <bfulgham@apple.com>
3299
3300         Activate WebVTT Tests Once Merging is Complete
3301         https://bugs.webkit.org/show_bug.cgi?id=130420
3302
3303         Reviewed by Eric Carlson.
3304
3305         * Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
3306
3307 2014-03-24  Anders Carlsson  <andersca@apple.com>
3308
3309         Re-fix the build.
3310
3311         * WebCore.exp.in:
3312
3313 2014-03-24  Anders Carlsson  <andersca@apple.com>
3314
3315         Fix build.
3316
3317         * WebCore.exp.in:
3318         Move a CFNetwork only symbol inside the USE(CFNETWORK) section.
3319
3320 2014-03-24  Chris Fleizach  <cfleizach@apple.com>
3321
3322         Regression: AX: Don't expose role or notifications for invalid menus
3323         https://bugs.webkit.org/show_bug.cgi?id=129814
3324
3325         Reviewed by Mario Sanchez Prada.
3326
3327         If a role=menu has no menuitem children, it should not be a menu.
3328         This was a bit tricky to implement since we need to update the role after the children are created,
3329         but it means we have to be a bit more aggressive about when to updateChildren, so that the role
3330         is known to be valid.
3331
3332         Test: platform/mac/accessibility/invalid-menu-role-does-not-send-notification.html
3333
3334         * accessibility/AXObjectCache.cpp:
3335         (WebCore::AXObjectCache::notificationPostTimerFired):
3336         * accessibility/AccessibilityRenderObject.cpp:
3337         (WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):
3338         (WebCore::AccessibilityRenderObject::addChildren):
3339         * accessibility/AccessibilityRenderObject.h:
3340         * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
3341         (-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):
3342
3343 2014-03-24  Andy Estes  <aestes@apple.com>
3344
3345         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
3346         https://bugs.webkit.org/show_bug.cgi?id=129322
3347
3348         Reviewed by Anders Carlsson.
3349
3350         * platform/network/ResourceHandle.h:
3351         * platform/network/cf/ResourceHandleCFNet.cpp:
3352         (WebCore::ResourceHandle::releaseConnectionForDownload): Changed to
3353         return a RetainPtr that adopts the connection's retain count.
3354
3355 2014-03-24  Enrica Casucci  <enrica@apple.com>
3356
3357         Update Hindi fallback font.
3358         https://bugs.webkit.org/show_bug.cgi?id=130690
3359         <rdar://problem/16391601>
3360
3361         Reviewed by Sam Weinig.
3362
3363         Using the new available font for Hindi in the fallback list.
3364
3365         * platform/graphics/ios/FontCacheIOS.mm:
3366         (WebCore::FontCache::systemFallbackForCharacters):
3367
3368 2014-03-24  Brent Fulgham  <bfulgham@apple.com>
3369
3370         Merge Minor WebVTT Cleanups from Blink
3371         https://bugs.webkit.org/show_bug.cgi?id=130681
3372
3373         Reviewed by Eric Carlson.
3374
3375         Merged from Blink (patch by philipj@opera.com):
3376         https://chromium.googlesource.com/chromium/blink/+/693eb5e2933dca0eab5bbd604e9f3406fe9fd1ab
3377         http://crbug.com/52593009
3378         https://chromium.googlesource.com/chromium/blink/+/40b3602feab34e9be829fd742b6ad6ded322a09f
3379         http://crbug.com/104243003
3380
3381         * html/track/TextTrack.cpp:
3382         (WebCore::TextTrack::setMode):
3383         * html/track/TextTrack.idl:
3384         * html/track/TextTrackCue.h:
3385         * html/track/VTTCue.cpp:
3386         (WebCore::VTTCue::VTTCue):
3387         * html/track/VTTCue.h:
3388
3389 2014-03-24  Commit Queue  <commit-queue@webkit.org>
3390
3391         Unreviewed, rolling out r166169.
3392         https://bugs.webkit.org/show_bug.cgi?id=130682
3393
3394         This patch broke tests on Apple Mavericks (Requested by fredw
3395         on #webkit).
3396
3397         Reverted changeset:
3398
3399         "Operator stretching: expose a math data API"
3400         https://bugs.webkit.org/show_bug.cgi?id=130572
3401         http://trac.webkit.org/changeset/166169
3402
3403 2014-03-24  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3404
3405         ENABLE(CSS_GRID_LAYOUT) guard for CSSGridLineNamesValue
3406         https://bugs.webkit.org/show_bug.cgi?id=130669
3407
3408         Reviewed by Sergio Villar Senin.
3409
3410         No new tests. No new functionality.
3411
3412         * css/CSSGridLineNamesValue.cpp:
3413         * css/CSSGridLineNamesValue.h:
3414
3415 2014-03-24  Chris Fleizach  <cfleizach@apple.com>
3416
3417         <hr> should expose AXRole/AXSubrole, etc
3418         https://bugs.webkit.org/show_bug.cgi?id=109015
3419
3420         Reviewed by Mario Sanchez Prada.
3421
3422         Expose the <hr> element to Mac and iOS through the accessibility interface.
3423
3424         Test: platform/mac/accessibility/hr-element.html
3425
3426         * English.lproj/Localizable.strings:
3427         * accessibility/AccessibilityNodeObject.cpp:
3428         (WebCore::AccessibilityNodeObject::isEnabled):
3429         * accessibility/AccessibilityObject.cpp:
3430         (WebCore::AccessibilityObject::computedRoleString):
3431         * accessibility/AccessibilityRenderObject.cpp:
3432         (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
3433         * accessibility/atk/AccessibilityObjectAtk.cpp:
3434         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
3435         * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
3436         (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
3437         (-[WebAccessibilityObjectWrapper accessibilityLabel]):
3438         * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
3439         (createAccessibilityRoleMap):
3440         (-[WebAccessibilityObjectWrapper subrole]):
3441         (-[WebAccessibilityObjectWrapper roleDescription]):
3442         * platform/LocalizedStrings.cpp:
3443         (WebCore::AXHorizontalRuleDescriptionText):
3444         * platform/LocalizedStrings.h:
3445
3446 2014-03-24  Antti Koivisto  <antti@apple.com>
3447
3448         Invalidate sibling text node style when needed instead of attaching synchronously
3449         https://bugs.webkit.org/show_bug.cgi?id=130590
3450
3451         Reviewed by Andreas Kling.
3452         
3453         Make things simpler.
3454
3455         * style/StyleResolveTree.cpp:
3456         (WebCore::Style::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):
3457         
3458             Just invalidate instead of calling attach directly.
3459             Rename to match.
3460
3461         (WebCore::Style::textRendererIsNeeded):
3462         (WebCore::Style::createTextRendererIfNeeded):
3463         
3464             Mo