2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-06-30  Rafael Brandao  <rafael.lobo@openbossa.org>
2
3         Reviewed by Andreas Kling.
4
5         [Qt] build-webkit warning: cannot find file ElementShadowPseudoId.h
6         https://bugs.webkit.org/show_bug.cgi?id=63747
7
8         Removed reference to ElementShadowPseudoId.h that no longer exists.
9
10         * WebCore.pro:
11
12 2011-06-30  Anders Carlsson  <andersca@apple.com>
13
14         Fix clang build.
15
16         Remove the complete Widget constructor from the .exp.in file; since Widget is an abstract class,
17         its complete constructor can never be called and clang has stopped emitting it altogether.
18
19         * WebCore.exp.in:
20
21 2011-06-30  Levi Weintraub  <leviw@chromium.org>
22
23         Reviewed by Eric Seidel.
24
25         Switch paintingRootRect and RenderObject repaint methods to new layout types
26         https://bugs.webkit.org/show_bug.cgi?id=63746
27
28         Switching paintingRootRect and RenderObject repaint functions over to the
29         new layout unit abstraction.
30
31         No new tests, no functionality changes.
32
33         * rendering/RenderBox.cpp:
34         (WebCore::RenderBox::repaintDuringLayoutIfMoved):
35         * rendering/RenderBox.h:
36         * rendering/RenderObject.cpp:
37         (WebCore::RenderObject::paintingRootRect):
38         (WebCore::RenderObject::paint):
39         (WebCore::RenderObject::repaintUsingContainer):
40         (WebCore::RenderObject::repaintRectangle):
41         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
42         (WebCore::RenderObject::repaintDuringLayoutIfMoved):
43         * rendering/RenderObject.h:
44
45 2011-06-30  Cary Clark  <caryclark@google.com>
46
47         Reviewed by James Robinson.
48
49         Use Skia if Skia on Mac Chrome is enabled
50         https://bugs.webkit.org/show_bug.cgi?id=62999
51
52         No new tests. This does not affect existing
53         functionality.
54
55         * WebCore.gyp/WebCore.gyp:
56         Include Skia and related files and exclude CG
57         and related files when building Chromium for Skia
58         on the Mac.
59
60         * loader/cache/CachedFont.cpp:
61         Rename CHROME to CHROMIUM.
62
63         * platform/chromium/DragImageRef.h:
64         * platform/graphics/FloatPoint.h:
65         * platform/graphics/FloatRect.h:
66         * platform/graphics/FloatSize.h:
67         * platform/graphics/FontPlatformData.h:
68         (WebCore::FontPlatformData::hash):
69         * platform/graphics/GlyphBuffer.h:
70         (WebCore::GlyphBuffer::advanceAt):
71         (WebCore::GlyphBuffer::add):
72         (WebCore::GlyphBuffer::expandLastAdvance):
73         * platform/graphics/IntPoint.h:
74         * platform/graphics/IntRect.h:
75         * platform/graphics/IntSize.h:
76         * platform/graphics/SimpleFontData.h:
77         * platform/graphics/cg/FloatPointCG.cpp:
78         * platform/graphics/cg/FloatRectCG.cpp:
79         * platform/graphics/cg/FloatSizeCG.cpp:
80         * platform/graphics/cg/IntPointCG.cpp:
81         * platform/graphics/cg/IntRectCG.cpp:
82         * platform/graphics/cg/IntSizeCG.cpp:
83         * platform/graphics/mac/FontCustomPlatformData.cpp:
84         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
85         (WebCore::createFontCustomPlatformData):
86         * platform/graphics/mac/FontCustomPlatformData.h:
87         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
88         Ditto.
89
90 2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>
91
92         Reviewed by Nikolas Zimmermann.
93
94         Update SVG position values on SVG DOM updates
95         https://bugs.webkit.org/show_bug.cgi?id=62439
96
97         Test: svg/custom/crash-textPath-attributes.html
98
99         * rendering/svg/RenderSVGInline.cpp:
100         (WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs
101         to update its positioning information.
102
103         * rendering/svg/SVGInlineFlowBox.cpp:
104         (WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox
105         like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).
106
107         * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
108         (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear
109         our cached layout attributes every time we invalidate them. This avoids keeping stale
110         attribute that have a backpointer to a RenderObject.
111
112 2011-06-30  Sreeram Ramachandran  <sreeram@chromium.org>
113
114         Reviewed by Adam Barth.
115
116         Suppress modal JavaScript/HTML dialogs during unload events
117         https://bugs.webkit.org/show_bug.cgi?id=56397
118
119         Allows clients to specify whether to show alerts during unload handlers.
120         When checking for whether a page dismissal event is being dispatched,
121         it's important to check all frames on the page (otherwise it becomes a
122         loophole easily exploited).
123
124         Test: fast/loader/page-dismissal-modal-dialogs.html
125
126         * loader/FrameLoader.cpp:
127         (WebCore::FrameLoader::FrameLoader):
128         (WebCore::FrameLoader::stopLoading):
129         (WebCore::FrameLoader::loadURL):
130         (WebCore::FrameLoader::loadWithDocumentLoader):
131         (WebCore::FrameLoader::stopAllLoaders):
132         (WebCore::FrameLoader::fireBeforeUnloadEvent):
133         * loader/FrameLoader.h:
134         (WebCore::FrameLoader::pageDismissalEventBeingDispatched):
135         * loader/cache/CachedResourceLoader.cpp:
136         (WebCore::CachedResourceLoader::requestImage):
137         * page/Chrome.cpp:
138         (WebCore::canRunModalIfDuringPageDismissal):
139         (WebCore::Chrome::canRunModalNow):
140         (WebCore::Chrome::runJavaScriptAlert):
141         (WebCore::Chrome::runJavaScriptConfirm):
142         (WebCore::Chrome::runJavaScriptPrompt):
143         * page/Chrome.h:
144         * page/ChromeClient.h:
145         (WebCore::ChromeClient::shouldRunModalDialogDuringPageDismissal):
146         * page/DOMWindow.cpp:
147         (WebCore::DOMWindow::showModalDialog):
148
149 2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>
150
151         Reviewed by Nikolas Zimmermann.
152
153         Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
154         https://bugs.webkit.org/show_bug.cgi?id=63076
155
156         Tests: svg/custom/crash-text-in-textpath.svg
157                svg/custom/text-node-in-text-invalidated.svg
158
159         The problem was that we did not call setNeedsPositionUpdate on RenderSVGText. When
160         doing our layout, we would not update the attributes on our SVGRenderInlineText as
161         we would not lay it out.
162
163         This was caused by childrenChanged being overridden on SVGTextPositioningElement but
164         not on SVGTextPathElement.
165
166         As both classes shared the same mother class, it made sense to move the logic here.
167         There should be no other side effects as SVGTextPathElement and SVGTextPositioningElement
168         are the only classes deriving from SVGTextContentElement.
169
170         * svg/SVGTextContentElement.cpp:
171         (WebCore::SVGTextContentElement::childrenChanged): Moved this method from SVGTextPositioningElement.
172         * svg/SVGTextContentElement.h:
173         * svg/SVGTextPositioningElement.cpp:
174         (WebCore::SVGTextPositioningElement::svgAttributeChanged): Updated after updatePositioningValuesInRenderer
175         removal, replaced by RenderSVGText::locateRenderSVGTextAncestor.
176         * svg/SVGTextPositioningElement.h:
177
178 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
179
180         Unreviewed build fix for !ENABLE(DATABASE) after r84789.
181
182         * bindings/js/JSDOMBinding.cpp:
183
184 2011-06-30  Anders Carlsson  <andersca@apple.com>
185
186         Reviewed by Dan Bernstein.
187
188         More ScrollableArea scaffolding
189         https://bugs.webkit.org/show_bug.cgi?id=63678
190
191         Add a way to get the enclosing scrollable area for a given scrollable area.
192         Also, add ScrollableArea::isPinnedInDirectionOfScrollDelta.
193
194         * page/FrameView.cpp:
195         (WebCore::FrameView::enclosingScrollableArea):
196         Return 0 for now.
197
198         * page/FrameView.h:
199         Add FrameView::enclosingScrollableArea.
200
201         * platform/ScrollableArea.cpp:
202         (WebCore::ScrollableArea::isPinnedInDirectionOfScrollDelta):
203         Return whether the area is pinned in the direction of the scroll delta.
204
205         * platform/ScrollableArea.h:
206         Add new member functions.
207
208         * platform/chromium/FramelessScrollView.cpp:
209         (WebCore::FramelessScrollView::enclosingScrollableArea):
210         * platform/chromium/FramelessScrollView.h:
211         Add stub.
212
213         * platform/win/PopupMenuWin.h:
214         (WebCore::PopupMenuWin::enclosingScrollableArea):
215         Always return 0.
216
217         * rendering/RenderLayer.cpp:
218         (WebCore::RenderLayer::enclosingScrollableLayer):
219         Add helper function.
220
221         (WebCore::RenderLayer::scrollByRecursively):
222         Use the new enclosingScrollableLayer helper function.
223
224         (WebCore::RenderLayer::enclosingScrollableArea):
225         Return the enclosing scrollable area.
226
227         * rendering/RenderLayer.h:
228         Add new member function.
229
230         * rendering/RenderListBox.cpp:
231         (WebCore::RenderListBox::enclosingScrollableArea):
232         Return 0 for now.
233         
234         * rendering/RenderListBox.h:
235         Add new member function.
236
237 2011-06-30  Martin Robinson  <mrobinson@igalia.com>
238
239         Reviewed by Anders Carlsson.
240
241         [GTK] Crash observed with nspluginwrapper and flash
242         https://bugs.webkit.org/show_bug.cgi?id=62249
243
244         Test: plugins/invalidate-rect-with-null-npp-argument.html
245
246         * plugins/npapi.cpp:
247         (NPN_InvalidateRect): Guard against null instances here.
248
249 2011-06-30  Levi Weintraub  <leviw@chromium.org>
250
251         Reviewed by Eric Seidel.
252
253         Switch availableWidth/Height, logicalLeft/RightOffsetForLine to new layout types
254         https://bugs.webkit.org/show_bug.cgi?id=63671
255
256         Switch availableWidth/Height, logicalLeft/RightOffsetForLine functions over to the
257         new layout unit abstraction.
258
259         No new tests, no functionality changes.
260
261         * rendering/RenderBlock.cpp:
262         (WebCore::RenderBlock::logicalLeftOffsetForLine):
263         (WebCore::RenderBlock::logicalRightOffsetForLine):
264         (WebCore::RenderBlock::availableLogicalWidthForLine):
265         (WebCore::RenderBlock::availableLogicalWidth):
266         * rendering/RenderBlock.h:
267         (WebCore::RenderBlock::logicalRightOffsetForLine):
268         (WebCore::RenderBlock::logicalLeftOffsetForLine):
269         (WebCore::RenderBlock::startOffsetForLine):
270         * rendering/RenderBox.cpp:
271         (WebCore::RenderBox::availableLogicalHeight):
272         (WebCore::RenderBox::availableLogicalHeightUsing):
273         * rendering/RenderBox.h:
274         (WebCore::RenderBox::availableLogicalWidth):
275         (WebCore::RenderBox::availableWidth):
276         (WebCore::RenderBox::availableHeight):
277
278 2011-06-30  Adam Barth  <abarth@webkit.org>
279
280         Remove useless ASSERT that breaks the build.
281
282         * dom/StyledElement.cpp:
283         (WebCore::parseColorStringWithCrazyLegacyRules):
284
285 2011-06-30  Tab Atkins  <jackalmage@gmail.com>
286
287         Reviewed by Adam Barth.
288
289         Fix legacy color attribute parsing to match HTML spec
290         https://bugs.webkit.org/show_bug.cgi?id=63029
291
292         Relevant spec link: http://www.whatwg.org/specs/web-apps/current-work/complete/common-microsyntaxes.html#rules-for-parsing-a-legacy-color-value
293         Fix legacy color attribute parsing (<body bgcolor>, <font color>, etc.) to match the HTML spec and more closely match other browsers.
294
295         Test: fast/dom/attribute-legacy-colors.html
296
297         * dom/StyledElement.cpp:
298         (WebCore::StyledElement::addCSSColor):
299
300 2011-06-28  Hans Wennborg  <hans@chromium.org>
301
302         Reviewed by Tony Chang.
303
304         IndexedDB: Prepare for running layout tests with LevelDB
305         https://bugs.webkit.org/show_bug.cgi?id=63593
306
307         Migration of data from SQLite to LevelDB must be done before the
308         m_backingStore map is checked for an open LevelDB, because if a
309         previous layout test has used LevelDB, it will be in the
310         m_backingStore map.
311
312         Covered by existing layout tests.
313
314         * storage/IDBFactoryBackendImpl.cpp:
315         (WebCore::IDBFactoryBackendImpl::open):
316
317 2011-06-30  Pavel Feldman  <pfeldman@chromium.org>
318
319         Reviewed by Yury Semikhatsky.
320
321         Web Inspector: introduce "filter" icons for timeline panel and elements sidebar.
322         https://bugs.webkit.org/show_bug.cgi?id=63731
323
324         * inspector/front-end/EventListenersSidebarPane.js:
325         * inspector/front-end/Images/paneFilterButtons.png: Added.
326         * inspector/front-end/Images/statusbarButtonGlyphs.png:
327         * inspector/front-end/StylesSidebarPane.js:
328         * inspector/front-end/inspector.css:
329         (.pane > .title > select):
330         (.pane > .title > select.select-settings):
331         (.pane > .title > select.select-filter):
332         (.timeline-filter-status-bar-item .glyph):
333
334 2011-06-28  Hans Wennborg  <hans@chromium.org>
335
336         Reviewed by Tony Chang.
337
338         IndexedDB: Support for deleteIndex with LevelDB backing store
339         https://bugs.webkit.org/show_bug.cgi?id=63539
340
341         Covered by storage/indexeddb/mozilla/remove-index.html.
342
343         * storage/IDBLevelDBBackingStore.cpp:
344         (WebCore::IDBLevelDBBackingStore::deleteIndex):
345
346 2011-06-30  Abhishek Arya  <inferno@chromium.org>
347
348         Reviewed by Ryosuke Niwa.
349
350         Crash when calling DOMSubtreeModified event when extracting range
351         contents.
352         https://bugs.webkit.org/show_bug.cgi?id=63650
353
354         Convert a few nodes to RefPtrs and add commonRoot verification checks
355         for Range::processContents.
356
357         Tests: fast/dom/Range/range-extract-contents-event-fire-crash.html
358                fast/dom/Range/range-extract-contents-event-fire-crash2.html
359
360         * dom/Range.cpp:
361         (WebCore::childOfCommonRootBeforeOffset):
362         (WebCore::Range::processContents):
363         (WebCore::Range::processContentsBetweenOffsets):
364         (WebCore::Range::processAncestorsAndTheirSiblings):
365
366 2011-06-30  Dan Bernstein  <mitz@apple.com>
367
368         Reviewed by Adele Peterson.
369
370         Add +[WebView _allowsRoundingHacks]
371         https://bugs.webkit.org/show_bug.cgi?id=63734
372
373         * WebCore.exp.in: Export TextRun::allowsRoundingHacks().
374         * platform/graphics/TextRun.cpp:
375         (WebCore::TextRun::allowsRoundingHacks): Added this accessor.
376         * platform/graphics/TextRun.h:
377
378 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
379
380         Reviewed by Adam Roben.
381
382         [WIN] Don't redefine the keyboard codes
383         https://bugs.webkit.org/show_bug.cgi?id=63726
384
385         Only define the codes when undefined.
386         r64957 fixed this problem for COMPILER(MINGW) but not for OS(WINCE).
387
388         * platform/WindowsKeyboardCodes.h:
389
390 2011-06-30  Yury Semikhatsky  <yurys@chromium.org>
391
392         Reviewed by Pavel Feldman.
393
394         Web Inspector: hide "Enabled background events collection" option in context menu until the setting is persisted
395         https://bugs.webkit.org/show_bug.cgi?id=63708
396
397         The option has no much sense if it is not preserved between browser restarts.
398
399         * inspector/front-end/NetworkPanel.js:
400         (WebInspector.NetworkPanel.prototype._contextMenu):
401
402 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
403
404         Reviewed by Darin Adler.
405
406         Remove dependnecy on IDL generation for disabled features in JSC bindings
407         https://bugs.webkit.org/show_bug.cgi?id=63718
408
409         Move the #if ENABLE() line directly after #include "config.h".
410         This enables us to compile all files even when we don't generate the IDL output.
411
412         * bindings/js/IDBBindingUtilities.cpp:
413         * bindings/js/JSConsoleCustom.cpp:
414         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
415         * bindings/js/JSCustomXPathNSResolver.cpp:
416         * bindings/js/JSDOMApplicationCacheCustom.cpp:
417         * bindings/js/JSDeviceMotionEventCustom.cpp:
418         * bindings/js/JSDeviceOrientationEventCustom.cpp:
419         * bindings/js/JSInjectedScriptHostCustom.cpp:
420         * bindings/js/JSInjectedScriptManager.cpp:
421         * bindings/js/JSInspectorFrontendHostCustom.cpp:
422         * bindings/js/JSJavaScriptCallFrameCustom.cpp:
423         * bindings/js/JSSQLResultSetRowListCustom.cpp:
424         * bindings/js/JSSQLTransactionCustom.cpp:
425         * bindings/js/JSSQLTransactionSyncCustom.cpp:
426         * bindings/js/JSSVGElementInstanceCustom.cpp:
427         * bindings/js/JSStorageCustom.cpp:
428         * bindings/js/JSTouchCustom.cpp:
429         * bindings/js/JSTouchListCustom.cpp:
430         * bindings/js/JSXPathResultCustom.cpp:
431         * bindings/js/JavaScriptCallFrame.cpp:
432         * bindings/js/PageScriptDebugServer.cpp:
433         * bindings/js/ScriptDebugServer.cpp:
434         * bindings/js/ScriptGCEvent.cpp:
435         * bindings/js/ScriptProfile.cpp:
436         * bindings/js/WorkerScriptDebugServer.cpp:
437
438 2011-06-30  Alexander Pavlov  <apavlov@chromium.org>
439
440         Reviewed by Kent Tamura.
441
442         [Chromium] Autofill suggestions appear in upper left corner after input change
443         https://bugs.webkit.org/show_bug.cgi?id=63702
444
445         This change fixes a few popup layout issues, some of which have existed for quite a while:
446         - the absence of the ChromeClientImpl::screenToWindow() implementation (the method used to always return (0, 0));
447         - the confusion of window and screen coordinates passed into the autofill popup client's setWindowRect() method;
448         - the use of the current frameRect() width as the target element's width (which was wrong when refreshing
449           a popup resized during the initial layout (e.g. made wider than the target element)).
450
451         No new tests, as this is a change to platform-specific widget code. The test case is provided in the bug description.
452
453         * platform/chromium/PopupMenuChromium.cpp:
454         (WebCore::PopupContainer::layoutAndGetRTLOffset): Use original target element width, not frameRect().width(),
455         since the latter gets updated if the popup is not the same width as the target element.
456         (WebCore::PopupContainer::refresh): Restore only the popup bounds rather than its original rectangle,
457         since it sometimes breaks the invalidation region and layout.
458
459 2011-06-30  Sheriff Bot  <webkit.review.bot@gmail.com>
460
461         Unreviewed, rolling out r90102.
462         http://trac.webkit.org/changeset/90102
463         https://bugs.webkit.org/show_bug.cgi?id=63714
464
465         Lots of tests asserting beneath
466         SVGSMILElement::findInstanceTime (Requested by aroben on
467         #webkit).
468
469         * svg/animation/SVGSMILElement.cpp:
470         (WebCore::SVGSMILElement::findInstanceTime):
471
472 2011-06-30  Andrey Kosyakov  <caseq@chromium.org>
473
474         Reviewed by Yury Semikhatsky.
475
476         Web Inspector: remove ExtensionAPISchema.json
477         https://bugs.webkit.org/show_bug.cgi?id=63687
478
479         * inspector/front-end/ExtensionAPISchema.json: Removed.
480
481 2011-06-30  Ilya Tikhonovsky  <loislo@chromium.org>
482
483         Unreviewed build fix for chromium.
484
485         * inspector/CodeGeneratorInspector.pm:
486
487 2011-06-30  Ilya Tikhonovsky  <loislo@chromium.org>
488
489         Unreviewed build fix for mac.
490
491         * inspector/CodeGeneratorInspector.pm:
492
493 2011-06-30  Ilya Tikhonovsky  <loislo@chromium.org>
494
495         Reviewed by Pavel Feldman.
496
497         Web Inspector: Protocol: error object needs some improvement.
498         https://bugs.webkit.org/show_bug.cgi?id=63707
499
500         Current implementation is not useful in the code.
501         We need to have toString implementation with nice formatting
502         I'd like to use error.message property as the main place for the error's text.
503
504         * inspector/CodeGeneratorInspector.pm:
505
506 2011-06-30  Mikhail Naganov  <mnaganov@chromium.org>
507
508         Reviewed by Yury Semikhatsky.
509
510         Web Inspector: [Chromium] Support annotations for arrays in heap profiler.
511         https://bugs.webkit.org/show_bug.cgi?id=63690
512
513         * inspector/front-end/DetailedHeapshotGridNodes.js:
514         (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
515
516
517 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
518
519         Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r88663, r89187, r89220, r89431 and r89661.
520
521         * svg/SVGAnimatedAngle.h:
522         * svg/SVGAnimatedLength.h:
523         * svg/SVGAnimatedNumber.h:
524         * svg/SVGAnimatedRect.h:
525         * svg/SVGAnimatedString.h:
526
527 2011-06-30  Gabor Loki  <loki@webkit.org>
528
529         Reviewed by Csaba Osztrogonác.
530
531         Fixed several style and typo issues after r90091.
532         https://bugs.webkit.org/show_bug.cgi?id=63692
533
534         Rename yStart to extremaStartY during computing extremas
535
536         * platform/graphics/filters/FEMorphology.cpp:
537         (WebCore::FEMorphology::platformApplyGeneric):
538         * platform/graphics/filters/FEMorphology.h:
539
540 2011-06-30  Oliver Varga  <Varga.Oliver@stud.u-szeged.hu>
541
542         Reviewed by Nikolas Zimmermann.
543
544         Speed up SVGSMILElement::findInstanceTime.
545         https://bugs.webkit.org/show_bug.cgi?id=61025
546
547         Replace the linear search to binary search on ordered list because
548         the previous searches from the beginning was not efficient.
549
550         No new tests this is only a performance tweak.
551
552         * svg/animation/SVGSMILElement.cpp:
553         (WebCore::extractTimeFromVector):
554         (WebCore::SVGSMILElement::findInstanceTime):
555
556 2011-06-30  Kentaro Hara  <haraken@google.com>
557
558         Reviewed by Kent Tamura.
559
560         Change the label of an HTML5 file chooser button to "Choose Files"
561         https://bugs.webkit.org/show_bug.cgi?id=49245
562
563         We should notify capability of multiple files to users.
564
565         Test: fast/forms/input-file-label.html
566
567         * English.lproj/Localizable.strings:
568         * html/FileInputType.cpp:
569         (WebCore::UploadButtonElement::createForMultiple): Constructs a multiple file chooser button.
570         (WebCore::FileInputType::createShadowSubtree): Constructs a single/multiple file chooser button depending on 'multiple' attribute.
571         (WebCore::FileInputType::multipleAttributeChanged): Updates the label of the file chooser button.
572         * html/FileInputType.h:
573         * html/HTMLInputElement.cpp:
574         (WebCore::HTMLInputElement::parseMappedAttribute): Updates the shadow tree of the file chooser button when 'multiple' attribute is set or unset.
575         * html/InputType.cpp:
576         (WebCore::InputType::multipleAttributeChanged): Virtual method to be overridden by FileInputType.
577         * html/InputType.h:
578         * platform/DefaultLocalizationStrategy.cpp:
579         (WebCore::DefaultLocalizationStrategy::fileButtonChooseFileLabel): Updated the description for "Choose File".
580         (WebCore::DefaultLocalizationStrategy::fileButtonChooseMultipleFilesLabel): Returns a string "Choose Files".
581         * platform/DefaultLocalizationStrategy.h:
582         * platform/LocalizationStrategy.h:
583         * platform/LocalizedStrings.cpp:
584         (WebCore::fileButtonChooseMultipleFilesLabel): Wrapper method for getting the "Choose Files" label.
585         * platform/LocalizedStrings.h:
586         * platform/brew/LocalizedStringsBrew.cpp:
587         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
588         * platform/efl/LocalizedStringsEfl.cpp:
589         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
590         * platform/gtk/LocalizedStringsGtk.cpp:
591         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
592         * platform/haiku/LocalizedStringsHaiku.cpp:
593         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
594         * platform/wx/LocalizedStringsWx.cpp:
595         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
596
597 2011-06-30  Ryosuke Niwa  <rniwa@webkit.org>
598
599         Reviewed by Kent Tamura.
600
601         Replace isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&)
602         https://bugs.webkit.org/show_bug.cgi?id=63672
603
604         Replaced isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&).
605         Also added a safe toTextFormControl to HTMLFormControlElement.h.
606
607         * editing/DeleteSelectionCommand.cpp:
608         (WebCore::DeleteSelectionCommand::doApply): Calls enclosingTextFormControl instead of manually
609         checking the tag name of shadowAncestorNode.
610         * editing/Editor.cpp:
611         (WebCore::Editor::selectionForCommand): Rewritten using enclosingTextFormControl and toTextFormControl.
612         (WebCore::Editor::cut): Calls enclosingTextFormControl instead of isNodeInTextFormControl.
613         (WebCore::Editor::copy): Ditto.
614         (WebCore::Editor::setBaseWritingDirection): Calls toTextFormControl instead of manually checking tag name.
615         * editing/FrameSelection.cpp:
616         (WebCore::FrameSelection::isInPasswordField): Calls enclosingTextFormControl.
617         * editing/ReplaceSelectionCommand.cpp:
618         (WebCore::ReplaceSelectionCommand::doApply): Ditto.
619         * editing/htmlediting.cpp:
620         (WebCore::enclosingTextFormControl): Added.
621         * editing/htmlediting.h:
622         * html/HTMLFormControlElement.h:
623         (WebCore::toTextFormControl): Added.
624         * page/DragController.cpp:
625         (WebCore::DragController::startDrag): Calls enclosingTextFormControl instead of isNodeInTextFormControl.
626
627 2011-06-27  Pavel Podivilov  <podivilov@chromium.org>
628
629         Reviewed by Pavel Feldman.
630
631         Web Inspector: source code is not highlighted after drawer height animations.
632         https://bugs.webkit.org/show_bug.cgi?id=62860
633
634         * inspector/front-end/Drawer.js:
635         (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
636         (WebInspector.Drawer.prototype._animateDrawerHeight):
637
638 2011-06-30  MORITA Hajime  <morrita@google.com>
639
640         Reviewed by Dimitri Glazkov.
641
642         Crash if ShadowRoot has a text node.
643         https://bugs.webkit.org/show_bug.cgi?id=63607
644         
645         Node::styleForRenderer() for Text node wasn't shadow-aware.
646         This change allow styleForRenderer() to know its visual parent by
647         passing NodeRenderingContext.
648         
649         Changes other than NodeRenderingContext and Element is just a
650         follow up for change above.
651
652         * dom/Element.cpp: use NodeRenderingContext to resolve parent node.
653         (WebCore::Element::recalcStyle):
654         * dom/Node.cpp:
655         (WebCore::Node::styleForRenderer): Added NodeRenderingContext as a parameter.
656         * dom/Node.h:
657         * dom/NodeRenderingContext.cpp:
658         (WebCore::NodeRendererFactory::createRendererAndStyle):
659         * html/HTMLOptGroupElement.cpp:
660         (WebCore::HTMLOptGroupElement::attach):
661         * html/HTMLOptionElement.cpp:
662         (WebCore::HTMLOptionElement::attach):
663         * html/HTMLTitleElement.cpp:
664         (WebCore::HTMLTitleElement::textWithDirection):
665         * html/shadow/TextControlInnerElements.cpp:
666         (WebCore::TextControlInnerElement::styleForRenderer):
667         (WebCore::TextControlInnerTextElement::styleForRenderer):
668         * html/shadow/TextControlInnerElements.h:
669
670         Test: fast/dom/shadow/shadow-root-text-child.html
671         
672 2011-06-30  Piroska András  <Piroska.Andras@stud.u-szeged.hu>
673
674         Reviewed by Dirk Schulze.
675
676         Apply the ParallelJobs support to FEMorphology
677         https://bugs.webkit.org/show_bug.cgi?id=63064
678
679         The FEMorphology filter of SVG can consume lots of resources if it is
680         applied to a large area. The computation can be distributed to multiple
681         cores if the architecture supports.
682         The average performance progression is 20-25% on dual-core machines.
683
684         * platform/graphics/filters/FEMorphology.cpp:
685         (WebCore::FEMorphology::platformApplyGeneric): Apply the filter between yStart and yEnd interval
686         (WebCore::FEMorphology::platformApplyWorker): Call the generic apply from a parallel worker
687         (WebCore::FEMorphology::platformApply):
688         (WebCore::FEMorphology::apply): Move the functionality into platformApply
689         (WebCore::FEMorphology::externalRepresentation): Remove whitespaces
690         * platform/graphics/filters/FEMorphology.h:
691
692 2011-06-29  Kent Tamura  <tkent@chromium.org>
693
694         Reviewed by Dimitri Glazkov.
695
696         Avoid custom layout code of RenderTextControlSingleLine
697         https://bugs.webkit.org/show_bug.cgi?id=61415
698
699         If a text field has a search results button, a search cancel
700         button, a speech button, or a spin button, the editable inner text
701         element and the buttons are wrapped by a flexible box container,
702         and the editable inner text element has flexibility. As the result
703         of applying the flexible box, we don't need any horizontal layout
704         code in RenderTextControlSingleLine except the inner spin button.
705
706         Also, we remove custom hit-testing code in nodeAtPoint(). If a
707         user clicks on a position left of the inner editable text but not
708         on the search results button, the search results button doesn't
709         work though it worked.
710
711         * css/html.css:
712         (input::-webkit-textfield-decoration-container):
713           New style definition for the "container" element.
714         (input[type="search"]::-webkit-search-cancel-button):
715           It should be a block element because it's a child of the flexible box.
716           Also, this doesn't have flexibility.
717         (input[type="search"]::-webkit-search-decoration): ditto.
718         (input[type="search"]::-webkit-search-results-decoration): ditto.
719         (input[type="search"]::-webkit-search-results-button): ditto.
720         (input::-webkit-inner-spin-button): ditto.
721         (input::-webkit-input-speech-button): ditto.
722         * html/HTMLInputElement.cpp:
723         (WebCore::HTMLInputElement::containerElement):
724           Add an accessor of the flexible box container.
725           It just calls InputType::containerElement().
726         * html/HTMLInputElement.h: Declare it.
727         * html/InputType.h:
728         (WebCore::InputType::containerElement): New accessor for a shadow element.
729         * html/SearchInputType.cpp:
730         (WebCore::SearchInputType::SearchInputType):
731           m_innerBlock is moved to TextFieldInputType.
732         (WebCore::SearchInputType::needsContainer):
733           A search field always needs the flexible box container because
734           of the results button and the cancel button.
735         (WebCore::SearchInputType::createShadowSubtree):
736           Use TextFieldInputType::createShadowSubtree(), then modify the tree.
737         (WebCore::SearchInputType::destroyShadowSubtree):
738           m_innerBlock is moved to TextFieldInputType.
739         * html/SearchInputType.h:
740         * html/TextFieldInputType.cpp:
741         (WebCore::TextFieldInputType::TextFieldInputType):
742           Initialize the new members.
743         (WebCore::TextFieldInputType::needsContainer):
744           Returns true if x-webkit-speech. We check a spin button separately.
745         (WebCore::TextFieldInputType::createShadowSubtree):
746           Wrap everything with the flexible box container if needsContainer() or we need a spin button.
747         (WebCore::TextFieldInputType::containerElement): Added an accessor.
748         (WebCore::TextFieldInputType::innerBlockElement): ditto.
749         (WebCore::TextFieldInputType::innerTextElement): ditto.
750         (WebCore::TextFieldInputType::innerSpinButtonElement): ditto.
751         (WebCore::TextFieldInputType::speechButtonElement): ditto.
752         (WebCore::TextFieldInputType::destroyShadowSubtree):
753           Clear references to new shadow nodes.
754         * html/TextFieldInputType.h:
755         * rendering/RenderTextControlSingleLine.cpp:
756         (WebCore::RenderTextControlSingleLine::containerElement): Added an accessor.
757         (WebCore::RenderTextControlSingleLine::innerTextElement):
758         (WebCore::RenderTextControlSingleLine::layout):
759          - Correct heights check
760           Comparing with height(), not contentHeigth(), was incorrect.
761          - Adjust the container height like the editable inner text.
762          - Remove width adjustment
763          - Remove the speech button layout code
764           The flexible box layout is enough.
765         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
766           Remove custom code for results/cancel/speech buttons, and
767           Simplify comments.
768         (WebCore::RenderTextControlSingleLine::forwardEvent):
769           Remove custom forwarding code for results/cancel buttons.
770         (WebCore::RenderTextControlSingleLine::styleDidChange):
771           Clear the style of the container because we update it in layout().
772         (WebCore::RenderTextControlSingleLine::hasControlClip):
773           Decoration buttons should be clipped by the container.
774         (WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
775         (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
776           We don't need to use display:inline-block any more.
777         (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
778           The text wrapper element should have flexibility.
779         (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
780           Updated for the tree structure change.
781         * rendering/RenderTextControlSingleLine.h:
782
783 2011-06-29  Kent Tamura  <tkent@chromium.org>
784
785         [Mac] Attempt to fix Leopard build.
786
787         * platform/mac/CursorMac.mm:
788         (WebCore::Cursor::ensurePlatformCursor):
789
790 2011-06-29  Darin Adler  <darin@apple.com>
791
792         Reviewed by Dan Bernstein.
793
794         [Mac] Use system cursors instead of custom bitmaps where possible
795         https://bugs.webkit.org/show_bug.cgi?id=63679
796
797         * Resources/crossHairCursor.png: Removed.
798         * Resources/notAllowedCursor.png: Removed.
799         * WebCore.exp.in: Added wkCursor.
800         * WebCore/WebCore.gyp/WebCore.gyp: Removed the two now-unused PNG files.
801         * WebCore.xcodeproj/project.pbxproj: Ditto.
802
803         * platform/mac/CursorMac.mm:
804         (WebCore::Cursor::ensurePlatformCursor): Use NSCursor API for Cross, Hand,
805         VerticalText, ContextMenu, Copy, and NotAllowed. Use wkCursor for Move,
806         Alias, Progress, and the resize and panning cursors.
807
808         * platform/mac/WebCoreSystemInterface.h: Added wkCursor.
809         * platform/mac/WebCoreSystemInterface.mm: Ditto.
810
811 2011-06-29  Keishi Hattori  <keishi@webkit.org>
812
813         Reviewed by Adam Barth.
814
815         Remove extra space at EOL in view source mode
816         https://bugs.webkit.org/show_bug.cgi?id=63620
817
818         Test: fast/frames/viewsource-linebreak.html
819
820         * css/view-source.css:
821         (tbody:last-child .webkit-line-content:empty:before): If we don't do this
822         the last line will be empty and the height will be shorter than the rest.
823         * html/HTMLViewSourceDocument.cpp:
824         (WebCore::HTMLViewSourceDocument::addSource): If source file is empty, add an empty line.
825         (WebCore::HTMLViewSourceDocument::finishLine): Call when you are done with the current line.
826         Adds a BR element if the line is empty and sets current to tbody.
827         (WebCore::HTMLViewSourceDocument::addText):
828         * html/HTMLViewSourceDocument.h:
829
830 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
831
832         [WinCE] Correct logical state of WINCE test.
833
834         * platform/win/ScrollbarThemeWin.cpp: The #if OS(WINCE)
835           should have been #if !OS(WINCE)
836         (WebCore::ScrollbarThemeWin::paintTrackPiece):
837         (WebCore::ScrollbarThemeWin::paintButton):
838         (WebCore::ScrollbarThemeWin::paintThumb):
839         * rendering/RenderThemeWin.cpp: ditto.
840         (WebCore::drawControl):
841
842 2011-06-29  Justin Garcia  <justin.garcia@apple.com>
843
844         Reviewed by Enrica Casucci.
845         
846         I forgot to include these (reviewed) style fix-ups in my previous check-in.
847
848         * editing/htmlediting.cpp:
849         (WebCore::indexForVisiblePosition):
850         (WebCore::visiblePositionForIndex):
851
852 2011-06-29  Justin Garcia  <justin.garcia@apple.com>
853
854         Reviewed by Enrica Casucci.
855
856         https://bugs.webkit.org/show_bug.cgi?id=62922
857         indexForVisiblePosition(const VisiblePosition& visiblePosition) does not consider shadow content
858         
859         VisiblePositions can be inside web form text regions, which use shadow trees. Made indexForVisiblePosition
860         aware of this, and added a new parameter to obtain the scope for a VisiblePosition, in addition to its index.
861         
862         Added visiblePositionForIndex to go in the opposite direction, taking into account the scope
863         used to compute the index.
864         
865         These two functions use TextIterators to convert between VisiblePositions and indices. But 
866         TextIterator iteration using TextIteratorEmitsCharactersBetweenAllVisiblePositions does not 
867         exactly match VisiblePosition iteration, so using them to preserve a selection during an 
868         editing operation is unreliable. This can be seen in the expected results for:
869         
870         editing/execCommand/indent-pre-list.html
871         editing/execCommand/crash-indenting-list-item.html
872         
873         TextIterator's TextIteratorEmitsCharactersBetweenAllVisiblePositions mode needs to be fixed, or 
874         these functions need to be changed to iterate using actual VisiblePositions. See:
875         
876         https://bugs.webkit.org/show_bug.cgi?id=63590
877         TextIterators in TextIteratorEmitsCharactersBetweenAllVisiblePositions do not exactly match VisiblePositions
878         
879         Also:
880         
881         https://bugs.webkit.org/show_bug.cgi?id=63592
882         Use visiblePositionForIndex and indexForVisiblePosition everywhere that TextIterators are used to convert between VisiblePositions and indices
883         
884         No new tests added because indexForVisiblePosition is currently only used for editing operations
885         that cannot be performed inside web form fields.
886
887         * editing/ApplyBlockElementCommand.cpp:
888         (WebCore::ApplyBlockElementCommand::doApply):
889         * editing/InsertListCommand.cpp:
890         (WebCore::InsertListCommand::doApply):
891         * editing/htmlediting.cpp:
892         (WebCore::indexForVisiblePosition):
893         (WebCore::visiblePositionForIndex):
894         * editing/htmlediting.h:
895
896 2011-06-29  Dimitri Glazkov  <dglazkov@chromium.org>
897
898         Reviewed by Kent Tamura.
899
900         Remove ElementWithPseudoId, since now an Element can store it all by itself.
901         https://bugs.webkit.org/show_bug.cgi?id=63657
902
903         Refactoring, covered by existing tests.
904
905         * CMakeLists.txt: Removed ElementWithPseudoId from build.
906         * GNUmakefile.list.am: Ditto.
907         * WebCore.gypi: Ditto.
908         * WebCore.order: Ditto.
909         * WebCore.pro: Ditto.
910         * WebCore.vcproj/WebCore.vcproj: Ditto.
911         * WebCore.xcodeproj/project.pbxproj: Ditto.
912         * html/ColorInputType.cpp:
913         (WebCore::ColorInputType::createShadowSubtree): Changed to use plain-old HTMLDivElement.
914         * html/RangeInputType.cpp:
915         (WebCore::RangeInputType::createShadowSubtree): Ditto.
916         * html/ValidationMessage.cpp:
917         (WebCore::ValidationMessage::buildBubbleTree): Ditto.
918         * html/shadow/ElementWithPseudoId.cpp: Removed.
919         * html/shadow/ElementWithPseudoId.h: Removed.
920
921 2011-06-29  Levi Weintraub  <leviw@chromium.org>
922
923         Reviewed by Eric Seidel.
924
925         Switch computeWidth and computeHeight functions to new layout types
926         https://bugs.webkit.org/show_bug.cgi?id=63655
927
928         Switch computeWidth and computeHeight functions over to the new layout unit abstraction.
929
930         Making a point to mark rounding that should eventually be removed by linking to a new
931         tracking bug: 63645.
932
933         No new tests, no functionality changes.
934
935         * rendering/AutoTableLayout.cpp:
936         (WebCore::AutoTableLayout::computePreferredLogicalWidths):
937         * rendering/AutoTableLayout.h:
938         * rendering/FixedTableLayout.cpp:
939         (WebCore::FixedTableLayout::computePreferredLogicalWidths):
940         * rendering/FixedTableLayout.h:
941         * rendering/LayoutTypes.h:
942         * rendering/RenderBlock.cpp:
943         (WebCore::RenderBlock::computePreferredLogicalWidths):
944         (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
945         (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
946         * rendering/RenderBox.cpp:
947         (WebCore::RenderBox::computeLogicalWidthUsing):
948         (WebCore::RenderBox::computeLogicalHeight):
949         (WebCore::RenderBox::computeLogicalHeightUsing):
950         (WebCore::RenderBox::computePercentageLogicalHeight):
951         (WebCore::RenderBox::computeReplacedLogicalWidth):
952         (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
953         (WebCore::RenderBox::computeReplacedLogicalWidthUsing):
954         (WebCore::RenderBox::computeReplacedLogicalHeight):
955         (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
956         (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
957         * rendering/RenderBox.h:
958         * rendering/RenderIFrame.cpp:
959         (WebCore::RenderIFrame::computeLogicalWidth):
960         * rendering/RenderImage.cpp:
961         (WebCore::RenderImage::computeReplacedLogicalWidth):
962         (WebCore::RenderImage::computeReplacedLogicalHeight):
963         * rendering/RenderImage.h:
964         * rendering/RenderListBox.cpp:
965         (WebCore::RenderListBox::computePreferredLogicalWidths):
966         * rendering/RenderListMarker.cpp:
967         (WebCore::RenderListMarker::computePreferredLogicalWidths):
968         * rendering/RenderMenuList.cpp:
969         (WebCore::RenderMenuList::computePreferredLogicalWidths):
970         * rendering/RenderReplaced.cpp:
971         (WebCore::RenderReplaced::computeReplacedLogicalWidth):
972         (WebCore::RenderReplaced::computeReplacedLogicalHeight):
973         (WebCore::RenderReplaced::computePreferredLogicalWidths):
974         * rendering/RenderReplaced.h:
975         * rendering/RenderSlider.cpp:
976         (WebCore::RenderSlider::computePreferredLogicalWidths):
977         * rendering/RenderTable.cpp:
978         (WebCore::RenderTable::computeLogicalWidth):
979         * rendering/RenderTextControl.cpp:
980         (WebCore::RenderTextControl::computePreferredLogicalWidths):
981         * rendering/RenderVideo.cpp:
982         (WebCore::RenderVideo::computeReplacedLogicalWidth):
983         (WebCore::RenderVideo::computeReplacedLogicalHeight):
984         * rendering/RenderVideo.h:
985         * rendering/svg/RenderSVGForeignObject.cpp:
986         (WebCore::RenderSVGForeignObject::computeLogicalWidth):
987         (WebCore::RenderSVGForeignObject::computeLogicalHeight):
988         * rendering/svg/RenderSVGRoot.cpp:
989         (WebCore::RenderSVGRoot::computePreferredLogicalWidths):
990         (WebCore::RenderSVGRoot::computeIntrinsicWidth):
991         (WebCore::RenderSVGRoot::computeIntrinsicHeight):
992         (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
993         (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
994         (WebCore::RenderSVGRoot::layout):
995         * rendering/svg/RenderSVGRoot.h:
996
997 2011-06-23  Abhishek Arya  <inferno@chromium.org>
998
999         Reviewed by James Robinson.
1000
1001         In RenderBlock, RenderWidget and RenderReplaced destroy functions,
1002         call dirtyLinesFromChangedChild to tell our parent that we are going away.
1003         https://bugs.webkit.org/show_bug.cgi?id=60307
1004
1005         Test: fast/block/child-not-removed-from-parent-lineboxes-crash.html
1006               fast/block/block-not-removed-from-parent-lineboxes-crash.html
1007
1008         * rendering/RenderBlock.cpp:
1009         (WebCore::RenderBlock::destroy):
1010         * rendering/RenderReplaced.cpp:
1011         (WebCore::RenderReplaced::destroy):
1012         * rendering/RenderReplaced.h:
1013         * rendering/RenderWidget.cpp:
1014         (WebCore::RenderWidget::destroy):
1015
1016 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
1017
1018         Speculative WinCE build correction.
1019
1020         * rendering/RenderThemeWin.cpp:
1021         (WebCore::drawControl): Don't call setRGBABitmapAlpha
1022           for WinCE case.
1023
1024 2011-06-29  Ryosuke Niwa  <rniwa@webkit.org>
1025
1026         Reviewed by Darin Adler.
1027
1028         REGRESSION(r89952): r89952 added a wrong assertion in visible_units.cpp
1029         https://bugs.webkit.org/show_bug.cgi?id=63668
1030
1031         We need to assert the offset to be zero only when the position is NOT offset in node.
1032
1033         * editing/visible_units.cpp:
1034         (WebCore::startOfParagraph):
1035
1036 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
1037
1038         Speculative WinCE build correction after r90057.
1039
1040         * CMakeListsWinCE.txt: Roll back r90061, since GetWorldTransform
1041           is not available in WinCE.
1042         * platform/win/ScrollbarThemeWin.cpp: Conditionally exclude calls
1043           to DIBPixelData::setRGBABitmapAlpha for WinCE.
1044         (WebCore::ScrollbarThemeWin::paintTrackPiece):
1045         (WebCore::ScrollbarThemeWin::paintButton):
1046         (WebCore::ScrollbarThemeWin::paintThumb):
1047
1048 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
1049
1050         Speculative WinCE build correction after r90057.
1051
1052         * CMakeListsWinCE.txt: Add missing DIBPixelData.cpp to
1053         WinCE build to support setting bitmap image alpha value.
1054
1055 2011-06-29  Simon Fraser  <simon.fraser@apple.com>
1056
1057         Reviewed by Beth Dakin.
1058
1059         Lay some groundwork for rubber-banding in overflow:scroll divs
1060         https://bugs.webkit.org/show_bug.cgi?id=63654
1061
1062         Make it possible for scrollTop and scrollLeft on a RenderLayer to be
1063         set to negative values, which we will do during rubber-banding in
1064         future. Continue to clamp programmatic scrolls, and scroll positions
1065         set by layout between 0 and the max value.
1066
1067         Test: fast/layers/negative-scroll-positions.html
1068
1069         * rendering/RenderBox.cpp:
1070         (WebCore::RenderBox::setScrollLeft):
1071         (WebCore::RenderBox::setScrollTop):
1072         * rendering/RenderLayer.cpp:
1073         (WebCore::RenderLayer::scrollToOffset):
1074         (WebCore::RenderLayer::scrollTo):
1075         * rendering/RenderLayer.h:
1076         (WebCore::RenderLayer::scrollToXOffset):
1077         (WebCore::RenderLayer::scrollToYOffset):
1078         * rendering/RenderTextControlSingleLine.cpp:
1079         (WebCore::RenderTextControlSingleLine::forwardEvent):
1080
1081 2011-06-29  Anders Carlsson  <andersca@apple.com>
1082
1083         Reviewed by Simon Fraser.
1084
1085         RenderLayer::maximumScrollPosition() is wrong
1086         https://bugs.webkit.org/show_bug.cgi?id=62667
1087
1088         * platform/ScrollableArea.h:
1089         (WebCore::ScrollableArea::isVerticalScrollerPinnedToMinimumPosition):
1090         (WebCore::ScrollableArea::isVerticalScrollerPinnedToMaximumPosition):
1091         Add these for good measure; they will be needed in an upcoming patch.
1092
1093         * rendering/RenderLayer.cpp:
1094         (WebCore::RenderLayer::maximumScrollPosition):
1095         Subtract the visible content rect, including the scroll bars.
1096
1097 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
1098
1099         Speculative WinCE build correction after r90053.
1100
1101         * platform/graphics/GraphicsContext.h:
1102         (WebCore::GraphicsContext::inTransparencyLayer): Provide
1103         stub implementation for 'inTransparencyLayer'.
1104
1105 2011-06-29  Xu Fan  <qifuren1985@gmail.com>
1106
1107         Reviewed by Brent Fulgham.
1108
1109         Fix Scrollbars Transparent in Windows XP if WebKit is using Layered Window
1110         https://bugs.webkit.org/show_bug.cgi?id=61136
1111
1112         * platform/graphics/win/DIBPixelData.h: add a static method setRGBABitmapAlpha
1113         * platform/graphics/win/DIBPixelData.cpp: add implementation
1114         * platform/win/ScrollbarThemeWin.cpp: fix scroolbar transparent
1115         * rendering/RenderThemeWin.cpp: fix textbox and button transparent
1116
1117 2011-06-29  Emil A Eklund  <eae@chromium.org>
1118
1119         Reviewed by Eric Seidel.
1120
1121         Switch RenderBoxModelObject::margin* and setMargin* to to new layout types
1122         https://bugs.webkit.org/show_bug.cgi?id=63652
1123
1124         Switch margin methods for render tree over to the new layout unit abstraction.
1125
1126         No new tests, no functionality changes.
1127
1128         * rendering/InlineFlowBox.h:
1129         * rendering/RenderBlock.cpp:
1130         * rendering/RenderBlock.h:
1131         * rendering/RenderBox.cpp:
1132         * rendering/RenderBox.h:
1133         * rendering/RenderBoxModelObject.h:
1134         * rendering/RenderInline.cpp:
1135         * rendering/RenderInline.h:
1136         * rendering/RenderText.h:
1137
1138 2011-06-29  Levi Weintraub  <leviw@chromium.org>
1139
1140         Reviewed by Eric Seidel.
1141
1142         Switch paint to new layout types
1143         https://bugs.webkit.org/show_bug.cgi?id=63645
1144
1145         Switch vanilla paint function over to the new layout unit abstraction.
1146
1147         No new tests, no functionality changes.
1148
1149         * rendering/RenderBlock.cpp:
1150         (WebCore::RenderBlock::paint):
1151         * rendering/RenderBlock.h:
1152         * rendering/RenderBox.cpp:
1153         (WebCore::RenderBox::paint):
1154         * rendering/RenderBox.h:
1155         * rendering/RenderDetailsMarker.cpp:
1156         (WebCore::RenderDetailsMarker::paint):
1157         * rendering/RenderDetailsMarker.h:
1158         * rendering/RenderEmbeddedObject.cpp:
1159         (WebCore::RenderEmbeddedObject::paint):
1160         * rendering/RenderEmbeddedObject.h:
1161         * rendering/RenderFrameSet.cpp:
1162         (WebCore::RenderFrameSet::paint):
1163         * rendering/RenderFrameSet.h:
1164         * rendering/RenderImage.cpp:
1165         (WebCore::RenderImage::paint):
1166         * rendering/RenderImage.h:
1167         * rendering/RenderInline.cpp:
1168         (WebCore::RenderInline::paint):
1169         * rendering/RenderInline.h:
1170         * rendering/RenderLineBoxList.h:
1171         * rendering/RenderListItem.cpp:
1172         (WebCore::RenderListItem::paint):
1173         * rendering/RenderListItem.h:
1174         * rendering/RenderListMarker.cpp:
1175         (WebCore::RenderListMarker::paint):
1176         * rendering/RenderListMarker.h:
1177         * rendering/RenderObject.h:
1178         * rendering/RenderReplaced.cpp:
1179         (WebCore::RenderReplaced::paint):
1180         * rendering/RenderReplaced.h:
1181         * rendering/RenderReplica.cpp:
1182         (WebCore::RenderReplica::paint):
1183         * rendering/RenderReplica.h:
1184         * rendering/RenderTable.cpp:
1185         (WebCore::RenderTable::paint):
1186         * rendering/RenderTable.h:
1187         * rendering/RenderTableCell.cpp:
1188         (WebCore::RenderTableCell::paint):
1189         * rendering/RenderTableCell.h:
1190         * rendering/RenderTableRow.cpp:
1191         (WebCore::RenderTableRow::paint):
1192         * rendering/RenderTableRow.h:
1193         * rendering/RenderTableSection.cpp:
1194         (WebCore::RenderTableSection::paint):
1195         * rendering/RenderTableSection.h:
1196         * rendering/RenderTextControlSingleLine.cpp:
1197         (WebCore::RenderTextControlSingleLine::paint):
1198         * rendering/RenderTextControlSingleLine.h:
1199         * rendering/RenderTheme.h:
1200         * rendering/RenderView.cpp:
1201         (WebCore::RenderView::paint):
1202         * rendering/RenderView.h:
1203         * rendering/RenderWidget.cpp:
1204         (WebCore::RenderWidget::paint):
1205         * rendering/RenderWidget.h:
1206         * rendering/mathml/RenderMathMLBlock.h:
1207         * rendering/mathml/RenderMathMLFraction.h:
1208         * rendering/mathml/RenderMathMLRoot.h:
1209         * rendering/mathml/RenderMathMLSquareRoot.h:
1210         * rendering/svg/RenderSVGContainer.h:
1211         * rendering/svg/RenderSVGForeignObject.h:
1212         * rendering/svg/RenderSVGHiddenContainer.h:
1213         * rendering/svg/RenderSVGImage.h:
1214         * rendering/svg/RenderSVGPath.h:
1215         * rendering/svg/RenderSVGRoot.cpp:
1216         (WebCore::RenderSVGRoot::paint):
1217         * rendering/svg/RenderSVGRoot.h:
1218         * rendering/svg/RenderSVGText.h:
1219
1220 2011-06-29  Jian Li  <jianli@chromium.org>
1221
1222         Reviewed by Kenneth Russell.
1223
1224         WebGL test failing on SL bots: fast/canvas/webgl/data-view-test.html 
1225         https://bugs.webkit.org/show_bug.cgi?id=63151
1226
1227         The fix is to change to throw TypeError in custom JS/V8 bindings.
1228
1229         * bindings/js/JSDataViewCustom.cpp:
1230         (WebCore::getDataViewMember):
1231         (WebCore::setDataViewMember):
1232         * bindings/v8/custom/V8DataViewCustom.cpp:
1233         (WebCore::V8DataView::constructorCallback):
1234         (WebCore::V8DataView::getInt8Callback):
1235
1236 2011-06-29  Luke Macpherson   <macpherson@chromium.org>
1237
1238         Reviewed by Darin Adler.
1239
1240         Convert uses of computeLengthIntForLength() to computeLength<Length>()
1241         https://bugs.webkit.org/show_bug.cgi?id=63641
1242
1243         No new tests / refactoring only.
1244
1245         * css/CSSStyleSelector.cpp:
1246         (WebCore::convertToLength):
1247         (WebCore::CSSStyleSelector::applyProperty):
1248         (WebCore::CSSStyleSelector::applyPageSizeProperty):
1249         (WebCore::CSSStyleSelector::mmLength):
1250         (WebCore::CSSStyleSelector::inchLength):
1251         (WebCore::CSSStyleSelector::mapFillSize):
1252         (WebCore::CSSStyleSelector::mapFillXPosition):
1253         (WebCore::CSSStyleSelector::mapFillYPosition):
1254
1255 2011-06-29  Chris Rogers  <crogers@google.com>
1256
1257         Reviewed by Kenneth Russell.
1258
1259         Simplify AudioBufferSourceNode rendering
1260         https://bugs.webkit.org/show_bug.cgi?id=63586
1261
1262         No new tests since this doesn't change API.
1263
1264         * webaudio/AudioBufferSourceNode.cpp:
1265         (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
1266         (WebCore::AudioBufferSourceNode::process):
1267         (WebCore::AudioBufferSourceNode::renderFromBuffer):
1268         (WebCore::AudioBufferSourceNode::reset):
1269         (WebCore::AudioBufferSourceNode::setBuffer):
1270         (WebCore::AudioBufferSourceNode::noteOn):
1271         (WebCore::AudioBufferSourceNode::noteGrainOn):
1272         (WebCore::AudioBufferSourceNode::totalPitchRate):
1273         * webaudio/AudioBufferSourceNode.h:
1274
1275 2011-06-29  Martin Robinson  <mrobinson@igalia.com>
1276
1277         Reviewed by Xan Lopez.
1278
1279         [Freetype] Many tests report ERROR: Failed to get glyph page zero.
1280         https://bugs.webkit.org/show_bug.cgi?id=63498
1281
1282         Instead of conditionally instantiating the m_scaledFont member of FontPlatformData,
1283         always instantiate it. For times when the size is 0 and the instantiation would lead
1284         to a Cairo error, we use size 1 and just make operations which would fail conditional
1285         on the m_size > 0.
1286
1287         No new tests. This change is covered by existing tests. We should
1288         observe no errors on the bots after landing.
1289
1290         * platform/graphics/cairo/FontCairo.cpp:
1291         (WebCore::Font::drawGlyphs): Instead of looking at whether or not there is
1292         a scaled font to determine whether to draw, just look at the size.
1293         * platform/graphics/freetype/FontPlatformData.h: Remove the m_font member.
1294         * platform/graphics/freetype/FontPlatformDataFreeType.cpp: Always instantiate
1295         a scaled font member and remove references to m_font. If we are instantiating
1296         a scaled font for a 0 size font, instantiate a size 1 font, so that we can
1297         still use Cairo to query font properties.
1298         * platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
1299         (WebCore::GlyphPage::fill): We can assume there is always a scaled font now.
1300         * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
1301         (WebCore::SimpleFontData::platformInit): Ditto.
1302         (WebCore::SimpleFontData::createScaledFontData): Ditto.
1303         (WebCore::SimpleFontData::containsCharacters): Ditto.
1304         (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
1305
1306 2011-06-29  Eric Carlson  <eric.carlson@apple.com>
1307
1308         Reviewed by Darin Adler.
1309
1310         Media element loads blocked by a resource load delegate do not generate an error event
1311         https://bugs.webkit.org/show_bug.cgi?id=63558
1312
1313         Tests: media/media-blocked-by-beforeload.html
1314                media/media-blocked-by-willsendrequest.html
1315
1316         * html/HTMLMediaElement.cpp:
1317         (WebCore::HTMLMediaElement::selectMediaResource): Call mediaLoadingFailed instead of noneSupported
1318             so all failures follow the same code path.
1319         (WebCore::HTMLMediaElement::loadResource): Call mediaLoadingFailed when there is no frame, when 
1320             the loader delegate rejects the url, or when MediaPlayer doesn't find a media engine that
1321             supports the type.
1322         (WebCore::HTMLMediaElement::selectNextSourceChild): Fix incorrect logging.
1323         (WebCore::HTMLMediaElement::mediaLoadingFailed): Change name of parameter from "state" to
1324             "error" to make its purpose obvious.
1325
1326         * platform/graphics/MediaPlayer.cpp:
1327         (WebCore::MediaPlayer::load): Return a bool indicating whether or not the url was given to
1328             a media engine.
1329         (WebCore::MediaPlayer::loadWithNextMediaEngine): Add some logging.
1330         * platform/graphics/MediaPlayer.h:
1331
1332 2011-06-29  Darin Adler  <darin@apple.com>
1333
1334         Reviewed by Anders Carlsson.
1335
1336         [WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
1337         https://bugs.webkit.org/show_bug.cgi?id=63483
1338
1339         Test: fast/loader/create-frame-in-DOMContentLoaded.html
1340
1341         * loader/FrameLoader.cpp:
1342         (WebCore::FrameLoader::init): Added an assertion.
1343         (WebCore::FrameLoader::finishedLoadingDocument): Removed a non-helpful #if
1344         statement. The rule that we do not call the client when creating the initial
1345         empty document was nominally specific to Windows and Chromium but is needed
1346         for all platforms.
1347
1348 2011-06-29  Emil A Eklund  <eae@chromium.org>
1349
1350         Reviewed by Darin Adler.
1351
1352         Switch hitTestColumns/Contents/Floats to to new layout types
1353         https://bugs.webkit.org/show_bug.cgi?id=63589
1354
1355         Switch location and size methods for RenderBox over to the new layout unit abstraction.
1356
1357         No new tests, no functionality changes.
1358
1359         * rendering/ColumnInfo.h:
1360         (WebCore::ColumnInfo::desiredColumnWidth):
1361         (WebCore::ColumnInfo::setDesiredColumnWidth):
1362         (WebCore::ColumnInfo::columnHeight):
1363         (WebCore::ColumnInfo::setColumnCountAndHeight):
1364         (WebCore::ColumnInfo::setColumnHeight):
1365         (WebCore::ColumnInfo::updateMinimumColumnHeight):
1366         (WebCore::ColumnInfo::minimumColumnHeight):
1367         * rendering/RenderBlock.cpp:
1368         (WebCore::RenderBlock::addOverflowFromChildren):
1369         (WebCore::RenderBlock::paintColumnRules):
1370         (WebCore::RenderBlock::paintColumnContents):
1371         (WebCore::RenderBlock::hitTestFloats):
1372         (WebCore::RenderBlock::hitTestColumns):
1373         (WebCore::RenderBlock::hitTestContents):
1374         (WebCore::RenderBlock::columnRectAt):
1375         * rendering/RenderBlock.h:
1376         (WebCore::RenderBlock::xPositionForFloatIncludingMargin):
1377         (WebCore::RenderBlock::yPositionForFloatIncludingMargin):
1378         * rendering/RenderLayer.cpp:
1379         (WebCore::RenderLayer::hitTestContents):
1380         * rendering/RenderLayer.h:
1381
1382 2011-06-29  Adrienne Walker  <enne@google.com>
1383
1384         Reviewed by James Robinson.
1385
1386         [chromium] Divide by zero in TilingData
1387         https://bugs.webkit.org/show_bug.cgi?id=63305
1388
1389         Add safety checks for empty layers.
1390
1391         * platform/graphics/chromium/LayerTilerChromium.cpp:
1392         (WebCore::LayerTilerChromium::prepareToUpdate):
1393         (WebCore::LayerTilerChromium::reset):
1394         (WebCore::LayerTilerChromium::updateRect):
1395
1396 2011-06-29  Dimitri Glazkov  <dglazkov@chromium.org>
1397
1398         Reviewed by Adam Barth.
1399
1400         Extract setShadowRoot function, harden it in preparation to be exposed to script.
1401         https://bugs.webkit.org/show_bug.cgi?id=63596
1402
1403         Refactoring, covered by existing tests.
1404
1405         * dom/Element.cpp:
1406         (WebCore::validateShadowRoot): Added.
1407         (WebCore::Element::setShadowRoot): Extracted from ensureShadowRoot.
1408         (WebCore::Element::ensureShadowRoot): Changed to use setShadowRoot.
1409         * dom/Element.h: Added decl.
1410
1411 2011-06-29  Vsevolod Vlasov  <vsevik@chromium.org>
1412
1413         Reviewed by Pavel Feldman.
1414
1415         Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
1416         https://bugs.webkit.org/show_bug.cgi?id=63631
1417
1418         Test: http/tests/inspector/network/network-request-revision-content.html
1419
1420         * inspector/front-end/Resource.js:
1421         (WebInspector.ResourceRevision.prototype.requestContent):
1422
1423 2011-06-29  Igor Oliveira  <igor.oliveira@openbossa.org>
1424
1425         Reviewed by Andreas Kling.
1426
1427         [Qt] GraphicsContext::clipToImageBuffer does not support scale transformation
1428         https://bugs.webkit.org/show_bug.cgi?id=63555
1429
1430         Scale alphaMask if GraphicsContext is scaled
1431
1432         * platform/graphics/qt/GraphicsContextQt.cpp:
1433         (WebCore::GraphicsContext::pushTransparencyLayerInternal):
1434         * platform/graphics/qt/ImageBufferQt.cpp:
1435         (WebCore::ImageBuffer::clip):
1436
1437 2011-06-29  Andrey Kosyakov  <caseq@chromium.org>
1438
1439         Reviewed by Pavel Feldman.
1440
1441         Web Inspector: backend needs to provide system-unique object ids, so these remain unique across navigation
1442         https://bugs.webkit.org/show_bug.cgi?id=62894
1443
1444         * inspector/InspectorController.cpp:
1445         (WebCore::InspectorController::setAgentProcessIdentifier):
1446         * inspector/InspectorController.h:
1447         * inspector/InspectorPageAgent.cpp:
1448         (WebCore::InspectorPageAgent::setAgentIdentifier):
1449         (WebCore::InspectorPageAgent::createIdentifier):
1450         (WebCore::InspectorPageAgent::frameForId):
1451         (WebCore::InspectorPageAgent::frameId):
1452         (WebCore::InspectorPageAgent::frameDestroyed):
1453         * inspector/InspectorPageAgent.h:
1454
1455 2011-06-29  Pavel Feldman  <pfeldman@google.com>
1456
1457         Reviewed by Yury Semikhatsky.
1458
1459         Web Inspector: create status bar buttons programmatically. Add "Inspect" button to all panels.
1460         https://bugs.webkit.org/show_bug.cgi?id=63450
1461
1462         Buttons should be created in code, not in HTML. Also making Inspect Element
1463         action available on all panels (as an experiment).
1464
1465         * inspector/front-end/ConsoleView.js:
1466         (WebInspector.ConsoleView.prototype.show):
1467         (WebInspector.ConsoleView.prototype.hide):
1468         * inspector/front-end/ElementsPanel.js:
1469         (WebInspector.ElementsPanel):
1470         (WebInspector.ElementsPanel.prototype.get statusBarItems):
1471         (WebInspector.ElementsPanel.prototype.updateFocusedNode):
1472         (WebInspector.ElementsPanel.prototype._setSearchingForNode):
1473         (WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
1474         * inspector/front-end/inspector.css:
1475         (button.dock-status-bar-item.status-bar-item .glyph):
1476         (button.dock-status-bar-item.status-bar-item.toggled-on .glyph):
1477         (.console-status-bar-item .glyph):
1478         * inspector/front-end/inspector.html:
1479         * inspector/front-end/inspector.js:
1480         (WebInspector._createGlobalStatusBarItems):
1481         (WebInspector.set attached):
1482
1483 2011-06-29  Pavel Feldman  <pfeldman@google.com>
1484
1485         Reviewed by Yury Semikhatsky.
1486
1487         Web Inspector: tab crash after deleting trailing quote when editing attribute
1488         https://bugs.webkit.org/show_bug.cgi?id=63544
1489
1490         * inspector/InspectorDOMAgent.cpp:
1491         (WebCore::InspectorDOMAgent::setAttributesText):
1492         * inspector/front-end/ElementsTreeOutline.js:
1493         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded):
1494         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
1495
1496 2011-06-29  Vsevolod Vlasov  <vsevik@chromium.org>
1497
1498         Reviewed by Pavel Feldman.
1499
1500         Web Inspector: REGRESSION Inspector failing to load resource content after navigation. Safari.
1501         https://bugs.webkit.org/show_bug.cgi?id=63480
1502
1503         * inspector/front-end/NetworkManager.js:
1504         (WebInspector.NetworkDispatcher):
1505         (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
1506
1507 2011-06-29  Mike West  <mkwst@chromium.org>
1508
1509         Reviewed by Pavel Feldman.
1510
1511         Web Inspector: Missing fields in HAR
1512         https://bugs.webkit.org/show_bug.cgi?id=58127
1513         
1514         Specifically, this patch adds:
1515         - entry.request.httpVersion
1516         - entry.request.headersSize
1517         - entry.request.bodySize
1518         - entry.response.httpVersion
1519         - entry.response.headersSize
1520         - entry.response.bodySize
1521         - entry.response.content.compression
1522         
1523         Tests: http/tests/inspector/resource-har-conversion.html
1524                http/tests/inspector/resource-har-headers.html
1525                http/tests/inspector/resource-parameters.html
1526                http/tests/inspector/network/network-size.html
1527
1528         * inspector/front-end/HAREntry.js:
1529         (WebInspector.HAREntry.prototype.build):
1530         (WebInspector.HAREntry.prototype._buildRequest):
1531         (WebInspector.HAREntry.prototype._buildResponse):
1532         (WebInspector.HAREntry.prototype._buildContent):
1533         (WebInspector.HAREntry.prototype._buildCookie):
1534         (WebInspector.HAREntry.prototype._interval):
1535         (WebInspector.HAREntry.prototype.get requestBodySize):
1536         (WebInspector.HAREntry.prototype.get responseBodySize):
1537         (WebInspector.HAREntry.prototype.get responseCompression):
1538         (WebInspector.HARLog.prototype.build):
1539         * inspector/front-end/Resource.js:
1540         (WebInspector.Resource.prototype.set requestHeaders):
1541         (WebInspector.Resource.prototype.get requestHeadersText):
1542         (WebInspector.Resource.prototype.set requestHeadersText):
1543         (WebInspector.Resource.prototype.get requestHeadersSize):
1544         (WebInspector.Resource.prototype.get requestHttpVersion):
1545         (WebInspector.Resource.prototype.set responseHeaders):
1546         (WebInspector.Resource.prototype.get responseHeadersText):
1547         (WebInspector.Resource.prototype.set responseHeadersText):
1548         (WebInspector.Resource.prototype.get responseHeadersSize):
1549         (WebInspector.Resource.prototype.get responseHttpVersion):
1550
1551 2011-06-29  Hayato Ito  <hayato@chromium.org>
1552
1553         Reviewed by Hajime Morita.
1554
1555         Make a shadow host transfer a focus to the first focusable element in the shadow root when its focus() is called.
1556         https://bugs.webkit.org/show_bug.cgi?id=62358.
1557
1558         This patch doesn't take an effect on the following elements to keep a compatibility.
1559         - <input>, <textarea>, <video> and <audio> elements
1560         We'll address these elements separately after re-targeting focus events
1561         (bug 61421) is implemented.
1562
1563         A shadow root's <content> is not considered in this patch.
1564         That should be addressed in another patch. See bug 63522.
1565
1566         Test: fast/dom/shadow/shadow-host-transfer-focus.html
1567
1568         * dom/Element.cpp:
1569         (WebCore::Element::focus):
1570         * page/FocusController.cpp:
1571         (WebCore::shadowRoot):
1572         (WebCore::isTreeScopeOwner):
1573         (WebCore::FocusController::transferFocusToElementInShadowRoot):
1574         (WebCore::hasCustomFocusLogic):
1575         (WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocumentOrShadowRoot):
1576         (WebCore::FocusController::advanceFocusInDocumentOrder):
1577         (WebCore::ownerOfTreeScope):
1578         (WebCore::FocusController::findFocusableNodeAcrossTreeScope):
1579         * page/FocusController.h:
1580
1581 2011-06-29  Ryan Sleevi  <rsleevi@chromium.org>
1582
1583         Reviewed by Dirk Schulze.
1584
1585         SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative
1586         https://bugs.webkit.org/show_bug.cgi?id=61600
1587
1588         Correct the logic for checking for relative lengths in a SVGRadialGradientElement to consider cx() in addition to cy()
1589         
1590         No new tests, as there is no way to currently test this. With the bug present, a side-effect is causing the
1591         expected/correct image to be rendered. This is because the cached SVG resource is getting invalided through a
1592         different path, forcing a repaint. The repaint takes into consideration the proper dimensions, hiding the bug.
1593
1594         * svg/SVGRadialGradientElement.cpp:
1595         (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
1596
1597 2011-06-28  Dirk Schulze  <krit@webkit.org>
1598
1599         Reviewed by Nikolas Zimmermann.
1600
1601         SVGAnimatedType should support SVGBoolean animation
1602         https://bugs.webkit.org/show_bug.cgi?id=63529
1603
1604         Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
1605         This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGBoolean.
1606         
1607         The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
1608         to support animVal and baseVal later.
1609
1610         Test: svg/animations/svgboolean-animation-1.html
1611
1612         * CMakeLists.txt: Add new file to build system.
1613         * GNUmakefile.list.am: Ditto.
1614         * WebCore.gypi: Ditto.
1615         * WebCore.pro: Ditto.
1616         * WebCore.xcodeproj/project.pbxproj: Ditto.
1617         * svg/SVGAllInOne.cpp: Ditto.
1618         * svg/SVGAnimateElement.cpp: Make use of AnimatedBoolean.
1619         (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
1620         (WebCore::SVGAnimateElement::calculateAnimatedValue):
1621         (WebCore::SVGAnimateElement::calculateFromAndToValues):
1622         (WebCore::SVGAnimateElement::calculateFromAndByValues):
1623         (WebCore::SVGAnimateElement::resetToBaseValue):
1624         (WebCore::SVGAnimateElement::applyResultsToTarget):
1625         (WebCore::SVGAnimateElement::calculateDistance):
1626         * svg/SVGAnimatedBoolean.cpp: Added. New animator for SVGBoolean.
1627         (WebCore::SVGAnimatedBooleanAnimator::SVGAnimatedBooleanAnimator):
1628         (WebCore::SVGAnimatedBooleanAnimator::constructFromString):
1629         (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndToValues):
1630         (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndByValues):
1631         (WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):
1632         (WebCore::SVGAnimatedBooleanAnimator::calculateDistance):
1633         * svg/SVGAnimatedBoolean.h:
1634         (WebCore::SVGAnimatedBooleanAnimator::~SVGAnimatedBooleanAnimator):
1635         * svg/SVGAnimatedType.cpp: Use bool for SVGBoolean.
1636         (WebCore::SVGAnimatedType::~SVGAnimatedType):
1637         (WebCore::SVGAnimatedType::createBoolean):
1638         (WebCore::SVGAnimatedType::boolean):
1639         (WebCore::SVGAnimatedType::valueAsString):
1640         (WebCore::SVGAnimatedType::setValueAsString):
1641         * svg/SVGAnimatedType.h:
1642         * svg/SVGAnimatorFactory.h: New crate function for SVGAnimatedSVGBooleanAnimator.
1643         (WebCore::SVGAnimatorFactory::create):
1644
1645 2011-06-28  Dimitri Glazkov  <dglazkov@chromium.org>
1646
1647         Reviewed by Adam Barth.
1648
1649         Make applyAuthorSheets settable on ShadowRoot.
1650         https://bugs.webkit.org/show_bug.cgi?id=63599
1651
1652         Refactoring and adding not-yet used function, tests to follow when API lands.
1653
1654         * dom/ShadowRoot.cpp:
1655         (WebCore::ShadowRoot::ShadowRoot): Added initializer.
1656         (WebCore::ShadowRoot::applyAuthorSheets): Made to use member variable.
1657         (WebCore::ShadowRoot::setApplyAuthorSheets): Added.
1658         * dom/ShadowRoot.h: Tweaked, added decls.
1659
1660 2011-06-28  Ilya Sherman  <isherman@chromium.org>
1661
1662         Reviewed by Adam Barth.
1663
1664         form.autocomplete="off" does not work
1665         Rename the autoComplete() method for HTMLFormElement, HTMLFormControlElementWithState, and HTMLInputElement to shouldAutocomplete()
1666         Add the autocomplete attribute to HTMLFormElement.idl and HTMLInputElement.idl
1667         https://bugs.webkit.org/show_bug.cgi?id=35823
1668
1669         Test: fast/forms/autocomplete.html
1670
1671         * html/HTMLFormControlElement.cpp:
1672         (WebCore::HTMLFormControlElementWithState::shouldAutocomplete): Renamed from ::autoComplete()
1673         (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Update callsite.
1674         * html/HTMLFormControlElement.h:
1675         * html/HTMLFormElement.cpp:
1676         (WebCore::HTMLFormElement::~HTMLFormElement): Update callsite.
1677         (WebCore::HTMLFormElement::parseMappedAttribute): Update callsite.
1678         (WebCore::HTMLFormElement::documentDidBecomeActive): Update callsite.
1679         (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Update callsite.
1680         (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Update callsite.
1681         (WebCore::HTMLFormElement::shouldAutocomplete): Renamed from ::autoComplete()
1682         * html/HTMLFormElement.h:
1683         * html/HTMLFormElement.idl: Bind the autocomplete attribute to a JavaScript property.
1684         * html/HTMLInputElement.cpp:
1685         (WebCore::HTMLInputElement::shouldAutocomplete): Renamed from ::autoComplete()
1686         * html/HTMLInputElement.h:
1687         * html/HTMLInputElement.idl: Bind the autocomplete attribute to a JavaScript property.
1688         * WebCore.exp.in: Updated autoComplete() -> shouldAutocomplete()
1689
1690 2011-06-28  Dimitri Glazkov  <dglazkov@chromium.org>
1691
1692         Reviewed by Kent Tamura.
1693
1694         Store shadowPseudoId in ElementRareData.
1695         https://bugs.webkit.org/show_bug.cgi?id=63604
1696
1697         No new tests, because the code isn't yet used.
1698
1699         * css/CSSSelector.cpp:
1700         (WebCore::CSSSelector::isUnknownPseudoType): Added convenience helper.
1701         * css/CSSSelector.h: Added decl.
1702         * dom/Element.cpp:
1703         (WebCore::Element::shadowPseudoId): Changed to use ElementRareData.
1704         (WebCore::Element::setShadowPseudoId): Ditto.
1705         * dom/Element.h: Added decls.
1706         * dom/ElementRareData.h: Added a member to keep shadowPseudoId.
1707
1708 2011-06-28  Kenichi Ishibashi  <bashi@chromium.org>
1709
1710         Reviewed by Tony Chang.
1711
1712         [Chromium] Remove dependencies on harfbuzz from FontPlatformDataLinux and FontLinux
1713         https://bugs.webkit.org/show_bug.cgi?id=62530
1714
1715         - Moved codes of FontLinux which depend on harfbuzz APIs to ComplexTextController.  Removed Some methods of ComplexTextController(advances() and logClusters()) since they are no longer needed.
1716         - Moved RefCountedHarfbuzzFace from FontPlatformDataLinux to HarfbuzzSkia and renamed it to HarfbuzzFace.
1717
1718         No new tests because there is no behavior change (The existing tests should cover the changes).
1719
1720         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1721         (WebCore::ComplexTextController::ComplexTextController): Added arguments so eliminating setter invocations.
1722         (WebCore::ComplexTextController::setupForRTL): Added.
1723         (WebCore::ComplexTextController::setupFontForScriptRun): Adopt the change of HarfbuzzFace class.
1724         (WebCore::ComplexTextController::setGlyphPositions): Use m_item.log_clusters instead of removed method.
1725         (WebCore::ComplexTextController::glyphIndexForXPositionInScriptRun): Added.
1726         (WebCore::ComplexTextController::offsetForPosition): Ditto.
1727         (WebCore::ComplexTextController::selectionRect): Ditto.
1728         * platform/graphics/chromium/ComplexTextControllerLinux.h:
1729         (WebCore::ComplexTextController::width):
1730         * platform/graphics/chromium/FontLinux.cpp: Removed truncateFixedPointToInteger().
1731         (WebCore::Font::drawComplexText): Removed setter invocations of ComplexTextController.
1732         (WebCore::Font::floatWidthForComplexText): Ditto.
1733         (WebCore::Font::offsetForPositionForComplexText): Moved harfbuzz dependent code to ComplexTextController.
1734         (WebCore::Font::selectionRectForComplexText): Ditto.
1735         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
1736         (WebCore::FontPlatformData::harfbuzzFace): Wrapped up HB_FaceRec in HarfbuzzFace class.
1737         * platform/graphics/chromium/FontPlatformDataLinux.h: Moved RefCountedHarfbuzzFace class and renamed to HarfbuzzFace.
1738         * platform/graphics/chromium/HarfbuzzSkia.cpp:
1739         (WebCore::allocHarfbuzzFont): Moved from ComplexTextControllerLinux.cpp.
1740         (WebCore::HarfbuzzFace::HarfbuzzFace): Added.
1741         (WebCore::HarfbuzzFace::~HarfbuzzFace): Added.
1742         * platform/graphics/chromium/HarfbuzzSkia.h:
1743         (WebCore::HarfbuzzFace::create): Added.
1744         (WebCore::HarfbuzzFace::face): Added.
1745         * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
1746         (WebCore::substituteWithVerticalGlyphs): Adopt  the change of HarfbuzzFace class.
1747
1748 2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>
1749
1750         Reviewed by Eric Seidel.
1751
1752         Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
1753         https://bugs.webkit.org/show_bug.cgi?id=55930
1754
1755         Don't set style type BEFORE/AFTER on anonymous wrapper block.
1756         Rather, check style type on generated wrapped child.
1757
1758         Tests: fast/ruby/generated-after-counter-doesnt-crash.html
1759                fast/ruby/generated-before-and-after-counter-doesnt-crash.html
1760                fast/ruby/generated-before-counter-doesnt-crash.html
1761
1762         * rendering/RenderRuby.cpp:
1763         (WebCore::isAnonymousRubyInlineBlock):
1764         (WebCore::isRubyBeforeBlock):
1765         (WebCore::isRubyAfterBlock):
1766         (WebCore::rubyBeforeBlock):
1767         (WebCore::rubyAfterBlock):
1768         (WebCore::createAnonymousRubyInlineBlock):
1769         (WebCore::RenderRubyAsInline::addChild):
1770         (WebCore::RenderRubyAsBlock::addChild):
1771
1772 2011-06-28  Emil A Eklund  <eae@chromium.org>
1773
1774         Reviewed by Eric Seidel.
1775
1776         Switch RenderLayer position/size to to new layout types
1777         https://bugs.webkit.org/show_bug.cgi?id=63578
1778
1779         Switch location and size methods for RenderLayer over to the new layout unit abstraction.
1780         
1781         No new tests, no functionality changes.
1782
1783         * rendering/RenderLayer.cpp:
1784         (WebCore::RenderLayer::resize):
1785         (WebCore::RenderLayer::visibleHeight):
1786         (WebCore::RenderLayer::visibleWidth):
1787         (WebCore::RenderLayer::offsetFromResizeCorner):
1788         * rendering/RenderLayer.h:
1789         (WebCore::RenderLayer::location):
1790         (WebCore::RenderLayer::setLocation):
1791         (WebCore::RenderLayer::size):
1792         (WebCore::RenderLayer::setSize):
1793         (WebCore::RenderLayer::rect):
1794         (WebCore::RenderLayer::renderBoxLocation):
1795         (WebCore::RenderLayer::renderBoxX):
1796         (WebCore::RenderLayer::renderBoxY):
1797         * rendering/RenderListBox.cpp:
1798         (WebCore::RenderListBox::visibleHeight):
1799         (WebCore::RenderListBox::visibleWidth):
1800         * rendering/RenderListBox.h:
1801
1802 2011-06-28  Levi Weintraub  <leviw@chromium.org>
1803
1804         Reviewed by Eric Seidel.
1805
1806         Switch paintObject and paintReplaced to new layout types
1807         https://bugs.webkit.org/show_bug.cgi?id=63585
1808
1809         Switching paintObject and paintReplaced to layout type abstractions from more integral types.
1810
1811         No new tests as this is just moving to an abstraction.
1812
1813         * rendering/RenderBlock.cpp:
1814         (WebCore::RenderBlock::paintObject):
1815         * rendering/RenderBlock.h:
1816         * rendering/RenderBox.h:
1817         (WebCore::RenderBox::paintObject):
1818         * rendering/RenderEmbeddedObject.cpp:
1819         (WebCore::RenderEmbeddedObject::paintReplaced):
1820         * rendering/RenderEmbeddedObject.h:
1821         * rendering/RenderFileUploadControl.cpp:
1822         (WebCore::RenderFileUploadControl::paintObject):
1823         * rendering/RenderFileUploadControl.h:
1824         * rendering/RenderHTMLCanvas.cpp:
1825         (WebCore::RenderHTMLCanvas::paintReplaced):
1826         * rendering/RenderHTMLCanvas.h:
1827         * rendering/RenderImage.cpp:
1828         (WebCore::RenderImage::paintReplaced):
1829         * rendering/RenderImage.h:
1830         * rendering/RenderListBox.cpp:
1831         (WebCore::RenderListBox::paintObject):
1832         * rendering/RenderListBox.h:
1833         * rendering/RenderReplaced.h:
1834         (WebCore::RenderReplaced::paintReplaced):
1835         * rendering/RenderTable.cpp:
1836         (WebCore::RenderTable::paintObject):
1837         * rendering/RenderTable.h:
1838         * rendering/RenderTableSection.cpp:
1839         (WebCore::RenderTableSection::paintObject):
1840         * rendering/RenderTableSection.h:
1841         * rendering/RenderTextControl.cpp:
1842         (WebCore::RenderTextControl::paintObject):
1843         * rendering/RenderTextControl.h:
1844         * rendering/RenderVideo.cpp:
1845         (WebCore::RenderVideo::paintReplaced):
1846         * rendering/RenderVideo.h:
1847
1848 2011-06-28  Adam Langley  <agl@chromium.org>
1849
1850         Reviewed by Adam Barth.
1851
1852         Skip cache validation on back with HTTPS.
1853         https://bugs.webkit.org/show_bug.cgi?id=63537
1854
1855         For back navigations over HTTP, WebKit sets a flag to use cached data
1856         irrespective of whether it has expired. However, this isn't currently
1857         done for HTTPS.
1858
1859         The logic in question was added in
1860         https://bugs.webkit.org/show_bug.cgi?id=33993 and appears to have been
1861         precautionary. However, both Firefox and IE will use this back
1862         navigation trick for HTTPS as well and so we should probably behave
1863         likewise.
1864
1865         Test: http/tests/cache/history-only-cached-subresource-loads-max-age-https.html
1866
1867         * loader/FrameLoader.cpp:
1868         (WebCore::FrameLoader::addExtraFieldsToRequest):
1869
1870 2011-06-28  Dimitri Glazkov  <dglazkov@chromium.org>
1871
1872         Reviewed by Adam Barth.
1873
1874         Remove errant isShadowBoundary on ShadowRoot.
1875         https://bugs.webkit.org/show_bug.cgi?id=63588
1876
1877         Removing dead code, no tests for that.
1878
1879         * dom/ShadowRoot.h: Removed a function that's no longer used.
1880
1881 2011-06-28  Zeng Huiqing  <huiqing.zeng@intel.com>
1882
1883         Reviewed by Kenneth Russell.
1884
1885         [chromium]Optimize GraphicsLayerChromium::setChildren()
1886         https://bugs.webkit.org/show_bug.cgi?id=62837
1887
1888         No new tests. 
1889
1890         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1891         (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
1892         (WebCore::GraphicsLayerChromium::setChildren):
1893         (WebCore::GraphicsLayerChromium::addChild):
1894         * platform/graphics/chromium/GraphicsLayerChromium.h:
1895
1896 2011-06-28  Levi Weintraub  <leviw@chromium.org>
1897
1898         Reviewed by Eric Seidel.
1899
1900         Switch paintBoxShadow and paintBoxDecorations to new layout types
1901         https://bugs.webkit.org/show_bug.cgi?id=63577
1902
1903         Switching paintBoxShadow and paintBoxDecorations to layout type abstraction 
1904         from more integral types.
1905
1906         No new tests as this is just moving to an abstraction.
1907
1908         * rendering/InlineFlowBox.cpp:
1909         (WebCore::InlineFlowBox::paintBoxShadow):
1910         (WebCore::InlineFlowBox::paintBoxDecorations):
1911         * rendering/InlineFlowBox.h:
1912         * rendering/RenderBox.cpp:
1913         (WebCore::RenderBox::paintBoxDecorations):
1914         * rendering/RenderBox.h:
1915         * rendering/RenderBoxModelObject.cpp:
1916         (WebCore::RenderBoxModelObject::paintBoxShadow):
1917         * rendering/RenderBoxModelObject.h:
1918         * rendering/RenderFieldset.cpp:
1919         (WebCore::RenderFieldset::paintBoxDecorations):
1920         * rendering/RenderFieldset.h:
1921         * rendering/RenderTable.cpp:
1922         (WebCore::RenderTable::paintBoxDecorations):
1923         * rendering/RenderTable.h:
1924         * rendering/RenderTableCell.cpp:
1925         (WebCore::RenderTableCell::paintBoxDecorations):
1926         * rendering/RenderTableCell.h:
1927         * rendering/RenderView.cpp:
1928         (WebCore::RenderView::paintBoxDecorations):
1929         * rendering/RenderView.h:
1930
1931 2011-06-28  Emil A Eklund  <eae@chromium.org>
1932
1933         Reviewed by Eric Seidel.
1934
1935         Switch RenderBox position/size to to new layout types
1936         https://bugs.webkit.org/show_bug.cgi?id=63571
1937
1938         Switch location and size methods for RenderBox over to the new layout unit abstraction.
1939
1940         No new tests, no functionality changes.
1941
1942         * rendering/RenderBox.cpp:
1943         * rendering/RenderBox.h:
1944         * rendering/RenderBoxModelObject.cpp:
1945         * rendering/RenderBoxModelObject.h:
1946         * rendering/RenderInline.cpp:
1947         * rendering/RenderInline.h:
1948         * rendering/RenderVideo.cpp:
1949         * rendering/RenderVideo.h:
1950
1951 2011-06-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1952
1953         Unreviewed, rolling out r89968.
1954         http://trac.webkit.org/changeset/89968
1955         https://bugs.webkit.org/show_bug.cgi?id=63581
1956
1957         Broke chromium windows compile (Requested by jamesr on
1958         #webkit).
1959
1960         * WebCore.gyp/WebCore.gyp:
1961         * loader/cache/CachedFont.cpp:
1962         * platform/chromium/DragImageRef.h:
1963         * platform/graphics/FloatPoint.h:
1964         * platform/graphics/FloatRect.h:
1965         * platform/graphics/FloatSize.h:
1966         * platform/graphics/FontPlatformData.h:
1967         (WebCore::FontPlatformData::hash):
1968         * platform/graphics/GlyphBuffer.h:
1969         (WebCore::GlyphBuffer::advanceAt):
1970         (WebCore::GlyphBuffer::add):
1971         (WebCore::GlyphBuffer::expandLastAdvance):
1972         * platform/graphics/IntPoint.h:
1973         * platform/graphics/IntRect.h:
1974         * platform/graphics/IntSize.h:
1975         * platform/graphics/SimpleFontData.h:
1976         * platform/graphics/cg/FloatPointCG.cpp:
1977         * platform/graphics/cg/FloatRectCG.cpp:
1978         * platform/graphics/cg/FloatSizeCG.cpp:
1979         * platform/graphics/cg/IntPointCG.cpp:
1980         * platform/graphics/cg/IntRectCG.cpp:
1981         * platform/graphics/cg/IntSizeCG.cpp:
1982         * platform/graphics/mac/FontCustomPlatformData.cpp:
1983         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
1984         (WebCore::createFontCustomPlatformData):
1985         * platform/graphics/mac/FontCustomPlatformData.h:
1986         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
1987
1988 2011-06-28  Levi Weintraub  <leviw@chromium.org>
1989
1990         Reviewed by Eric Seidel.
1991
1992         Switch PaintMask* to new layout types
1993         https://bugs.webkit.org/show_bug.cgi?id=63576
1994
1995         Switching paintMask* to layout type abstraction from more integral types.
1996
1997         No new tests as this is just moving to an abstraction.
1998
1999         * rendering/InlineFlowBox.cpp:
2000         (WebCore::InlineFlowBox::paintMask):
2001         * rendering/InlineFlowBox.h:
2002         * rendering/RenderBox.cpp:
2003         (WebCore::RenderBox::paintMask):
2004         (WebCore::RenderBox::paintMaskImages):
2005         * rendering/RenderBox.h:
2006         * rendering/RenderFieldset.cpp:
2007         (WebCore::RenderFieldset::paintMask):
2008         * rendering/RenderFieldset.h:
2009         * rendering/RenderTable.cpp:
2010         (WebCore::RenderTable::paintMask):
2011         * rendering/RenderTable.h:
2012         * rendering/RenderTableCell.cpp:
2013         (WebCore::RenderTableCell::paintMask):
2014         * rendering/RenderTableCell.h:
2015
2016 2011-06-28  Levi Weintraub  <leviw@chromium.org>
2017
2018         Reviewed by Eric Seidel.
2019
2020         Switch paintFillLayer* to new layout types
2021         https://bugs.webkit.org/show_bug.cgi?id=63570
2022
2023         Switching painFillLayer* to layout type abstraction from more integral types.
2024
2025         No new tests as this is just moving to an abstraction.
2026
2027         * rendering/InlineFlowBox.cpp:
2028         (WebCore::InlineFlowBox::paintFillLayers):
2029         (WebCore::InlineFlowBox::paintFillLayer):
2030         * rendering/InlineFlowBox.h:
2031         * rendering/RenderBox.cpp:
2032         (WebCore::RenderBox::paintFillLayers):
2033         (WebCore::RenderBox::paintFillLayer):
2034         * rendering/RenderBox.h:
2035         * rendering/RenderBoxModelObject.cpp:
2036         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2037         * rendering/RenderBoxModelObject.h:
2038         * rendering/RenderObject.h:
2039
2040 2011-06-28  Luke Macpherson   <macpherson@chromium.org>
2041
2042         Reviewed by Eric Seidel.
2043
2044         Use appropriate macro for CSSPropertyWebkitAppearance in CSSStyleSelector::applyProperty()
2045         https://bugs.webkit.org/show_bug.cgi?id=63197
2046
2047         No new tests / no functionality changed.
2048
2049         * css/CSSStyleSelector.cpp:
2050         (WebCore::CSSStyleSelector::applyProperty):
2051         Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro and delete duplicate code.
2052
2053 2011-06-28  Cary Clark  <caryclark@google.com>
2054
2055         Reviewed by James Robinson.
2056
2057         Use Skia if Skia on Mac Chrome is enabled
2058         https://bugs.webkit.org/show_bug.cgi?id=62999
2059
2060         No new tests. This does not affect existing
2061         functionality.
2062
2063         * WebCore.gyp/WebCore.gyp:
2064         Include Skia and related files and exclude CG
2065         and related files when building Chromium for Skia
2066         on the Mac.
2067
2068         * loader/cache/CachedFont.cpp:
2069         Rename CHROME to CHROMIUM.
2070
2071         * platform/chromium/DragImageRef.h:
2072         * platform/graphics/FloatPoint.h:
2073         * platform/graphics/FloatRect.h:
2074         * platform/graphics/FloatSize.h:
2075         * platform/graphics/FontPlatformData.h:
2076         (WebCore::FontPlatformData::hash):
2077         * platform/graphics/GlyphBuffer.h:
2078         (WebCore::GlyphBuffer::advanceAt):
2079         (WebCore::GlyphBuffer::add):
2080         (WebCore::GlyphBuffer::expandLastAdvance):
2081         * platform/graphics/IntPoint.h:
2082         * platform/graphics/IntRect.h:
2083         * platform/graphics/IntSize.h:
2084         * platform/graphics/SimpleFontData.h:
2085         * platform/graphics/cg/FloatPointCG.cpp:
2086         * platform/graphics/cg/FloatRectCG.cpp:
2087         * platform/graphics/cg/FloatSizeCG.cpp:
2088         * platform/graphics/cg/IntPointCG.cpp:
2089         * platform/graphics/cg/IntRectCG.cpp:
2090         * platform/graphics/cg/IntSizeCG.cpp:
2091         * platform/graphics/mac/FontCustomPlatformData.cpp:
2092         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
2093         (WebCore::createFontCustomPlatformData):
2094         * platform/graphics/mac/FontCustomPlatformData.h:
2095         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
2096         Ditto.
2097
2098 2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>
2099
2100         Reviewed by Darin Adler.
2101
2102         Stop instantiating Position with PositionIsOffsetInAnchor in various files
2103         https://bugs.webkit.org/show_bug.cgi?id=63384
2104
2105         Refactoring.
2106
2107         Removed many if conditions that compared the anchor type to Position::PositionIsOffsetInAnchor
2108         because there were also checking that containerNode is a text node.
2109
2110         Also added Position::containerText() to avoid manually casting containerNode().
2111
2112         * dom/Position.cpp:
2113         (WebCore::Position::Position): Added an assertion to ensure BeforeChildren/AfterChildren
2114         anchor type won't be used for a node whose contents is ignored by editing.
2115         (WebCore::Position::containerText): Added.
2116         * dom/Position.h:
2117         * editing/ApplyBlockElementCommand.cpp:
2118         (WebCore::isNewLineAtPosition): Removed a redundant comparison of anchor type.
2119         (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Since containerNode
2120         is always a text node when renderStyleOfEnclosingTextNode returns a render style, use new Position
2121         constructor that takes Text* and offset.
2122         (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Removed redundant
2123         comparison of anchor type and use new Position constructor that takes Text* and offset.
2124         * editing/ApplyStyleCommand.cpp:
2125         (WebCore::ApplyStyleCommand::splitTextAtStart): Replaced an assertion that compared anchor type by
2126         an assertion that the container node is a text node; use new constructor.
2127         (WebCore::ApplyStyleCommand::splitTextAtEnd): Ditto; also added early exits in the case script
2128         modified DOM.
2129         (WebCore::ApplyStyleCommand::splitTextElementAtStart): Ditto.
2130         (WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto.
2131         (WebCore::ApplyStyleCommand::joinChildTextNodes): Use new constructor.
2132         * editing/CompositeEditCommand.cpp:
2133         (WebCore::Editor::replaceSelectedTextInNode): Calls containerText instead of manually casting containerNode.
2134         * editing/Editor.cpp:
2135         (WebCore::Editor::canDeleteRange): Call Range::startPosition instead of manually instantiating Position
2136         by calling startContainer and startOffset.
2137         * editing/FrameSelection.cpp:
2138         (WebCore::FrameSelection::setSelectedRange): Ditto.
2139         * editing/InsertTextCommand.cpp:
2140         (WebCore::InsertTextCommand::input): Calls containerText instead of manually casting containerNode.
2141         * editing/ReplaceSelectionCommand.cpp:
2142         (WebCore::ReplaceSelectionCommand::doApply): Calls containerText instead of manually casting containerNode.
2143         * editing/VisiblePosition.cpp:
2144         (WebCore::VisiblePosition::characterAfter): Removed a redundant anchor type comparison.
2145         (WebCore::startVisiblePosition): Call Range::startPosition instead of startContainer and startOffset.
2146         (WebCore::endVisiblePosition): Call Range::endPosition instead of endContainer and endOffset.
2147         * editing/htmlediting.cpp:
2148         (WebCore::firstInSpecialElement): Call containerNode() to address <rdar://problem/5027702>.
2149         (WebCore::lastInSpecialElement): Ditto; use new constructor.
2150         * editing/visible_units.cpp:
2151         (WebCore::endPositionForLine): Use new constructor.
2152         (WebCore::startOfParagraph): Ditto.
2153         (WebCore::endOfParagraph): Ditto.
2154
2155 2011-06-28  Rob Buis  <rbuis@rim.com>
2156
2157         Reviewed by Nikolas Zimmermann.
2158
2159         SVG1.1SE test text-tref-03-b.svg fails
2160         https://bugs.webkit.org/show_bug.cgi?id=63390
2161
2162         Support tref on forward referenced content by listening to DOMSubtreeModified events. This also
2163         allows updating after modifications in the referenced content subtree.
2164
2165         Tests: svg/W3C-SVG-1.1-SE/text-tref-03-b.svg
2166                svg/custom/text-tref-03-b-change-href-dom.svg
2167                svg/custom/text-tref-03-b-change-href.svg
2168                svg/custom/text-tref-03-b-dynamic.svg
2169                svg/custom/text-tref-03-b-dynamic2.svg
2170                svg/custom/text-tref-03-b-referenced-element-removal.svg
2171                svg/custom/text-tref-03-b-tref-removal.svg
2172
2173         * svg/SVGTRefElement.cpp:
2174         (WebCore::SubtreeModificationEventListener::create):
2175         (WebCore::SubtreeModificationEventListener::cast):
2176         (WebCore::SubtreeModificationEventListener::removeFromTarget):
2177         (WebCore::SubtreeModificationEventListener::SubtreeModificationEventListener):
2178         (WebCore::SubtreeModificationEventListener::operator==):
2179         (WebCore::SubtreeModificationEventListener::handleEvent):
2180         (WebCore::SVGTRefElement::updateReferencedText):
2181         (WebCore::SVGTRefElement::parseMappedAttribute):
2182         (WebCore::SVGTRefElement::svgAttributeChanged):
2183         (WebCore::SVGTRefElement::buildPendingResource):
2184         (WebCore::SVGTRefElement::removedFromDocument):
2185         * svg/SVGTRefElement.h:
2186
2187 2011-06-28  Abhishek Arya  <inferno@chromium.org>
2188
2189         Reviewed by Anders Carlsson.
2190
2191         Split the string creation into a local (while creating text runs)
2192         so that it is not destroyed prematurely.
2193         https://bugs.webkit.org/show_bug.cgi?id=63543
2194
2195         Run fast/forms/text-control-intrinsic-widths.html under valgrind/ASAN.       
2196         * rendering/RenderFileUploadControl.cpp:
2197         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
2198         this one is just done for caution, in case, we don't do the same
2199         mistake when adding legacy rounding hacks option.
2200         * rendering/RenderTextControl.cpp:
2201         (WebCore::RenderTextControl::getAvgCharWidth):
2202
2203 2011-06-28  Greg Simon  <gregsimon@chromium.org>
2204
2205         Reviewed by Dimitri Glazkov.
2206
2207         Migrate SQLite backing store to LevelDB backing store for Indexeddb.
2208         https://bugs.webkit.org/show_bug.cgi?id=62780
2209
2210         * storage/IDBFactoryBackendImpl.cpp:
2211         (WebCore::computeFileIdentifier):
2212         (WebCore::computeUniqueIdentifier):
2213         (WebCore::IDBFactoryBackendImpl::open):
2214         (WebCore::migrateObjectStores):
2215         (WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
2216         * storage/IDBLevelDBBackingStore.cpp:
2217         (WebCore::IDBLevelDBBackingStore::backingStoreExists):
2218         * storage/IDBLevelDBBackingStore.h:
2219         * storage/IDBObjectStoreBackendImpl.cpp:
2220         (WebCore::IDBObjectStoreBackendImpl::populateIndex):
2221         * storage/IDBObjectStoreBackendImpl.h:
2222         * storage/IDBSQLiteBackingStore.cpp:
2223         (WebCore::IDBSQLiteBackingStore::backingStoreExists):
2224         * storage/IDBSQLiteBackingStore.h:
2225
2226 2011-06-28  Levi Weintraub  <leviw@chromium.org>
2227
2228         Reviewed by Darin Adler.
2229
2230         Create intermediate classes as a path towards getting off of pixel offsets
2231         https://bugs.webkit.org/show_bug.cgi?id=61896
2232
2233         Creating three intermediate typedefs to aid in moving layout and hit testing from integers
2234         to floats. We'll transition the render tree over to these intermediate types and add
2235         infrastructure to support the new types behind USE(FLOAT_LAYOUT_OFFSETS). This allows the ultimate
2236         changeover to be easier.
2237
2238         Switching LayoutState over to this abstraction to verify it works correctly.
2239
2240         No new tests since this is creating a new abstraction, not changing current behavior.
2241
2242         * GNUmakefile.list.am:
2243         * WebCore.gypi:
2244         * WebCore.pro:
2245         * WebCore.vcproj/WebCore.vcproj:
2246         * WebCore.xcodeproj/project.pbxproj:
2247         * rendering/LayoutState.cpp:
2248         (WebCore::LayoutState::LayoutState):
2249         (WebCore::LayoutState::pageLogicalOffset):
2250         (WebCore::LayoutState::addForcedColumnBreak):
2251         * rendering/LayoutState.h:
2252         * rendering/LayoutTypes.h: Added.
2253
2254 2011-06-28  Jeff Miller  <jeffm@apple.com>
2255
2256         Add fullscreen.css and fullscreenQuickTime.css to the WebCore Visual Studio project for convenience.
2257         Looks like Visual Studio also re-sorted one more file since my last checkin.
2258
2259         * WebCore.vcproj/WebCore.vcproj:
2260
2261 2011-06-28  Jeff Miller  <jeffm@apple.com>
2262
2263         Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
2264
2265         * WebCore.vcproj/WebCore.vcproj:
2266
2267 2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>
2268
2269         Reviewed by Martin Robinson.
2270
2271         [GTK] Rename 3D transforms to 3D rendering
2272         https://bugs.webkit.org/show_bug.cgi?id=63508
2273
2274         This patch allows to include ENABLE_3D_RENDERING to build WebKitGtk+.
2275
2276         * GNUmakefile.am: Add ENABLE_3D_RENDERING
2277
2278 2011-06-22  Pavel Podivilov  <podivilov@chromium.org>
2279
2280         Reviewed by Yury Semikhatsky.
2281
2282         Web Inspector: use column numbers when linking to script location in timeline and console.
2283         https://bugs.webkit.org/show_bug.cgi?id=63126
2284
2285         * inspector/front-end/ConsoleView.js:
2286         (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
2287         * inspector/front-end/TimelinePanel.js:
2288         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2289         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
2290
2291 2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>
2292
2293         Reviewed by Martin Robinson.
2294
2295         [GTK] Allow to build WebKitGtk+ with accelerated compositing
2296         https://bugs.webkit.org/show_bug.cgi?id=63404
2297
2298         WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms 
2299         and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.
2300
2301         * GNUmakefile.list.am:
2302         * platform/graphics/clutter/GraphicsLayerClutter.cpp: Added.
2303         (WebCore::GraphicsLayer::create): Not implemented yet.
2304         (WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
2305         (WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
2306         (WebCore::GraphicsLayerClutter::setNeedsDisplay): Ditto.
2307         (WebCore::GraphicsLayerClutter::setNeedsDisplayInRect): Ditto.
2308         * platform/graphics/clutter/GraphicsLayerClutter.h: Added.
2309
2310 2011-06-28  Dan Bernstein  <mitz@apple.com>
2311
2312         Reviewed by Darin Adler.
2313
2314         REGRESSION (r89733): fast/text/zero-font-size.html is failing on Leopard
2315         https://bugs.webkit.org/show_bug.cgi?id=63512
2316
2317         * platform/graphics/mac/SimpleFontDataMac.mm:
2318         (WebCore::SimpleFontData::platformWidthForGlyph): Initialize the advance local variable, because
2319         on Leopard wkGetGlyphTransformedAdvances can return successfully yet not update the variable when
2320         the font size is 0. Presumably, r89733 exposed this by changing the values put on the stack just
2321         before this function is called.
2322
2323 2011-06-27  Alexander Pavlov  <apavlov@chromium.org>
2324
2325         Reviewed by Pavel Feldman.
2326
2327         Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
2328         https://bugs.webkit.org/show_bug.cgi?id=63446
2329
2330         * inspector/Inspector.json:
2331         * inspector/InspectorCSSAgent.cpp:
2332         (WebCore::computePseudoClassMask):
2333         (WebCore::InspectorCSSAgent::getStylesForNode):
2334         * inspector/InspectorCSSAgent.h:
2335         * inspector/front-end/AuditRules.js:
2336         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
2337         * inspector/front-end/CSSStyleModel.js:
2338         (WebInspector.CSSStyleModel.prototype.getStylesAsync):
2339         * inspector/front-end/StylesSidebarPane.js:
2340         (WebInspector.StylesSidebarPane.prototype.update):
2341
2342 2011-06-28  Kent Tamura  <tkent@chromium.org>
2343
2344         Fix a build error on Mac by r89907.
2345
2346         * svg/animation/SVGSMILElement.cpp:
2347         (WebCore::SVGSMILElement::endListChanged):
2348
2349 2011-06-27  Alexander Pavlov  <apavlov@chromium.org>
2350
2351         Reviewed by Kent Tamura.
2352
2353         [Chromium] SELECT or autofill popup is trimmed by screen edge on Windows
2354         https://bugs.webkit.org/show_bug.cgi?id=63438
2355
2356         If the popup is calculated to be trimmed by a screen edge, an attempt is made
2357         to alter its vertical edge alignment (set to the right edge for LTR or to the left edge for RTL)
2358         to see if the trimmed portion becomes smaller than that with the original layout.
2359         The change involves remembering the original frameRect for the popup and restoring it in refresh().
2360         This is due to the fact that the frameRect originally set in showInRect() is overwritten
2361         by layoutAndGetRTLOffset(), which breaks the originally requested popup container layout metrics.
2362         The max width is reset on every layoutAndCalculateWidgetRect(), as it can be constrained by the screen edge,
2363         and thus should be re-checked every time the popup is displayed, in case the browser window has been moved.
2364
2365         Tests: manual-tests/popup-width-restriction-within-screen.html partly covers the fix (should not regress).
2366         Other than that, there is no way to unit-test the platform-specific native code.
2367
2368         * platform/chromium/PopupMenuChromium.cpp:
2369         (WebCore::PopupListBox::setMaxWidth): Added. Avoid duplicate popup content layouts (in contrast with setMaxWidthAndLayout()).
2370         (WebCore::PopupListBox::PopupListBox):
2371         (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Attempt a left-right popup alignment inversion
2372         to minimize the trimmed content. Also restore a default max popup width.
2373         (WebCore::PopupContainer::layoutAndGetRTLOffset): Always return the popup listbox offset for the RTL (right alignment) case.
2374         The method rename is due to the return value semantics change.
2375         (WebCore::PopupContainer::showInRect): Store the originally requested frameRect for the popup.
2376         (WebCore::PopupContainer::refresh): Restore the original popup frameRect to avoid layout artifacts on refresh.
2377         (WebCore::PopupContainer::isRTL): This check should be made by the layoutAndGetRTLOffset() clients.
2378         * platform/chromium/PopupMenuChromium.h:
2379
2380 2011-06-28  Kentaro Hara  <haraken@google.com>
2381
2382         Reviewed by Kent Tamura.
2383
2384         Allow spaces between e-mail addresses in 'email' input type.
2385         https://bugs.webkit.org/show_bug.cgi?id=55987
2386
2387         Allowed spaces between e-mail addresses in 'email' input type,
2388         e.g. ' a@p.com , b@p.com ' is a valid value. Implemented the
2389         value sanitization algorithm for an e-mail value.  Added more unit
2390         tests that check the e-mail value parser.
2391
2392         Test: fast/forms/ValidityState-typeMismatch-email.html
2393
2394         * html/EmailInputType.cpp:
2395         (WebCore::EmailInputType::typeMismatchFor):
2396         (WebCore::EmailInputType::sanitizeValue):
2397         * html/EmailInputType.h:
2398         * html/parser/HTMLParserIdioms.cpp:
2399         (WebCore::stripHTMLLineBreaks):
2400         * html/parser/HTMLParserIdioms.h:
2401         (WebCore::isHTMLLineBreak):
2402
2403 2011-06-28  Kent Tamura  <tkent@chromium.org>
2404
2405         Reviewed by Hajime Morita.
2406
2407         Refactor RenderTextControl::text().
2408         https://bugs.webkit.org/show_bug.cgi?id=63519
2409
2410         No new tests because this is just a refactoring.
2411
2412         * rendering/RenderTextControl.cpp:
2413         (WebCore::RenderTextControl::setInnerTextValue):
2414          Resuce the number of text() calls.
2415         (WebCore::finishText):
2416           - Use StringBuilder.
2417           - Make this a static function.
2418             This function doesn't access anything of RenderTextControl.
2419         (WebCore::RenderTextControl::text):
2420          Use emptyString() and StringBuilder.
2421         (WebCore::RenderTextControl::textWithHardLineBreaks): ditto.
2422         * rendering/RenderTextControl.h: Remove finishText().
2423
2424 2011-06-28  Yury Semikhatsky  <yurys@chromium.org>
2425
2426         Reviewed by Pavel Feldman.
2427
2428         Web Inspector: console.group messages should never be coalesced
2429         https://bugs.webkit.org/show_bug.cgi?id=63521
2430
2431         * inspector/InspectorConsoleAgent.cpp:
2432         (WebCore::isGroupMessage):
2433         (WebCore::InspectorConsoleAgent::addConsoleMessage):
2434
2435 2011-06-28  Yury Semikhatsky  <yurys@chromium.org>
2436
2437         Reviewed by Pavel Feldman.
2438
2439         Web Inspector: console group boundaries should be more distinct in UI
2440         https://bugs.webkit.org/show_bug.cgi?id=63455
2441
2442         Show grey bracket to on the left side of a console group message to highlight
2443         the group extent.
2444
2445         * inspector/front-end/ConsoleView.js:
2446         (WebInspector.ConsoleGroup):
2447         * inspector/front-end/inspector.css:
2448         (#console-prompt):
2449         (.console-message, .console-user-command):
2450         (.console-message::before, .console-user-command::before, #console-prompt::before, .console-group-title::before):
2451         (.console-group-title::before):
2452         (.console-group):
2453         (.console-group-bracket):
2454         (.console-group.collapsed > .console-group-bracket):
2455
2456 2011-06-28  Kent Tamura  <tkent@chromium.org>
2457
2458         Reviewed by Hajime Morita.
2459
2460         Use RefPtr for the HTMLElement data members of TextFieldInptType
2461         and SearchInputType.
2462         https://bugs.webkit.org/show_bug.cgi?id=63511
2463
2464         No new tests because of no behavior change.
2465
2466         * html/SearchInputType.cpp:
2467         (WebCore::SearchInputType::SearchInputType):
2468         No need to initialize the element members explicitly because
2469         RefPtr constructor works well.
2470         (WebCore::SearchInputType::createShadowSubtree):
2471         Substitute an element to a data member, and don't call RefPtr<>::release().
2472         (WebCore::SearchInputType::innerBlockElement):
2473         Moved from the header file, and adjustment for RefPtr<>.
2474         (WebCore::SearchInputType::resultsButtonElement): ditto.
2475         (WebCore::SearchInputType::cancelButtonElement): ditto.
2476         (WebCore::SearchInputType::destroyShadowSubtree):
2477          Adjustment for RefPtr<>.
2478         * html/SearchInputType.h:
2479          - Move accessor functions to the cpp file because they are virtual.
2480          - Change element data member types: HTMLElement* -> RefPtr<HTMLElement>.
2481         * html/TextFieldInputType.cpp:
2482         (WebCore::TextFieldInputType::TextFieldInputType):
2483         No need to initialize the element members explicitly because
2484         RefPtr constructor works well.
2485         (WebCore::TextFieldInputType::~TextFieldInputType):
2486         Explicityly defines the destructor in the cpp file to avoid to
2487         make it implicitly in the header file. If the destructor was made
2488         in the header file, we would need to include HTMLElement.h in the
2489         header file.
2490         (WebCore::TextFieldInputType::createShadowSubtree):
2491         - Don't call RenderTheme::themeForPage().
2492         - Substitute an element to a data member, and don't call RefPtr<>::release().
2493         (WebCore::TextFieldInputType::setInnerTextElement):
2494          Moved from the header file to avoid to include HTMLElement.h.
2495         (WebCore::TextFieldInputType::setSpeechButtonElement): ditto.
2496         (WebCore::TextFieldInputType::innerTextElement):
2497         Moved from the header file, and adjustment for RefPtr<>.
2498         (WebCore::TextFieldInputType::innerSpinButtonElement): ditto.
2499         (WebCore::TextFieldInputType::speechButtonElement): ditto.
2500         (WebCore::TextFieldInputType::destroyShadowSubtree):
2501          Adjustment for RefPtr<>.
2502         * html/TextFieldInputType.h:
2503          - Move accessor functions to the cpp file because they are virtual.
2504          - Change element data member types: HTMLElement* -> RefPtr<HTMLElement>.
2505
2506 2011-06-28  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>
2507
2508         Reviewed by Nikolas Zimmermann.
2509
2510         SVG animation flickers when restarting
2511         https://bugs.webkit.org/show_bug.cgi?id=18450
2512
2513         Add new parameter to the following methods. The new parameter is the time of adding a "begin" or "end" time to the SVG animation.
2514          - WebCore::SVGSMILElement::addBeginTime
2515          - WebCore::SVGSMILElement::beginListChanged
2516          - WebCore::SVGSMILElement::addEndTime
2517          - WebCore::SVGSMILElement::endListChanged
2518         In case of beginTime and beginListChanged it's necessary, because the delay between the event of adding a new begin time
2519         (in WebCore::SVGAnimationElement::beginElementAt) and the actual processing (in WebCore::SVGSMILElement::endListChanged)
2520         is significant. In lack of event time we can't decide that we should consider the new time or not.
2521         If the new begin time is smaller than the event time, we musn't begin the animation, else we shoud do further calculations.
2522
2523         The following methods just modified for consistency:
2524          - WebCore::SVGSMILElement::addEndTime
2525          - WebCore::SVGSMILElement::endListChanged
2526
2527         No new tests, because currently there is no way to test SVG flickering at zero time.
2528
2529         * svg/SVGAnimationElement.cpp:
2530         (WebCore::SVGAnimationElement::beginElementAt):
2531         (WebCore::SVGAnimationElement::endElementAt):
2532         * svg/animation/SVGSMILElement.cpp:
2533         (WebCore::SVGSMILElement::attributeChanged):
2534         (WebCore::SVGSMILElement::addBeginTime):
2535         (WebCore::SVGSMILElement::addEndTime):
2536         (WebCore::SVGSMILElement::beginListChanged):
2537         (WebCore::SVGSMILElement::endListChanged):
2538           The body changed:
2539            - Use new parameter, the time of adding the new begin time.
2540            - Cancel some incorrect optimalization. We should also do further calculations when elapsed >= m_intervalBegin.
2541         (WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
2542         (WebCore::SVGSMILElement::handleConditionEvent):
2543         (WebCore::SVGSMILElement::beginByLinkActivation):
2544         * svg/animation/SVGSMILElement.h:
2545
2546 2011-06-28  Csaba Osztrogonác  <ossy@webkit.org>
2547
2548         Reviewed by Andreas Kling.
2549
2550         Adding MHTML reading support.
2551         https://bugs.webkit.org/show_bug.cgi?id=7168
2552
2553         * features.pri: Disable MHTML on Qt by default in a proper way.
2554
2555 2011-06-28  Csaba Osztrogonác  <ossy@webkit.org>
2556
2557         Reviewed by Andreas Kling.
2558
2559         [Qt] Remove ENABLE_XBL, because there aren't ENABLE(XBL) macros anymore.
2560
2561         * features.pri:
2562
2563 2011-06-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2564
2565         Unreviewed. Fix style error related to wrong include order.
2566
2567         * platform/graphics/efl/ImageEfl.cpp:
2568
2569 2011-06-27  Brian Weinstein  <bweinstein@apple.com>
2570
2571         Fix the WebCore vcproj file after r89851.
2572
2573         * WebCore.vcproj/WebCore.vcproj:
2574
2575 2011-06-27  Joe Wild  <joseph.wild@nokia.com>
2576
2577         Reviewed by Simon Fraser.
2578
2579         Crash on www.crave.cnet.com in FrameView::windowClipRect()
2580         https://bugs.webkit.org/show_bug.cgi?id=56393
2581
2582         Check for a null renderer to fix a crash. This situation can
2583         arise when external content/plugins is referenced from html
2584         elements with style="display:none".
2585
2586         Test: plugins/hidden-iframe-with-swf-plugin.html
2587
2588         * page/FrameView.cpp:
2589         (WebCore::FrameView::windowClipRect):
2590
2591 2011-06-27  Raymes Khoury  <raymes@chromium.org>
2592
2593         Reviewed by Tony Chang.
2594
2595         WebCore fails to compile in thumb mode when neon instructions are
2596         enabled.
2597
2598         There are two files (FELightingNEON.cpp and FEGaussianBlur.cpp)
2599         which fail to build when -mthumb is passed to gcc. These contain inline
2600         assembly for neon instructions on arm. This patch forces the -marm flag
2601         to be passed when compiling these files to work around this.
2602
2603         https://bugs.webkit.org/show_bug.cgi?id=62916
2604
2605         Built WebKit in Chromium and checked that -marm is passed
2606         only when building these files.
2607
2608         https://bugs.webkit.org/show_bug.cgi?id=62916
2609
2610         * WebCore.gyp/WebCore.gyp:
2611
2612 2011-06-27  Jay Civelli  <jcivelli@chromium.org>
2613
2614         Reviewed by Darin Fisher.
2615
2616         Adding binary part support to MHTML.
2617         https://bugs.webkit.org/show_bug.cgi?id=63310
2618
2619         * loader/archive/mhtml/MHTMLArchive.cpp:
2620         (WebCore::MHTMLArchive::generateMHTMLData):
2621         (WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding):
2622         * loader/archive/mhtml/MHTMLArchive.h:
2623         * loader/archive/mhtml/MHTMLParser.cpp:
2624         (WebCore::MHTMLParser::parseNextPart):
2625         * platform/SharedBuffer.cpp:
2626         (WebCore::SharedBuffer::append):
2627         * platform/SharedBuffer.h:
2628         * platform/network/MIMEHeader.cpp:
2629         (WebCore::MIMEHeader::parseContentTransferEncoding):
2630         * platform/network/MIMEHeader.h:
2631
2632 2011-06-27  Levi Weintraub  <leviw@chromium.org>
2633
2634         Reviewed by Eric Seidel.
2635
2636         Add support for unicode-bidi:plaintext CSS property
2637         https://bugs.webkit.org/show_bug.cgi?id=50949
2638
2639         Adding support for unicode-bidi: plaintext. This involves invoking P2 and P3
2640         of the Unicode BiDi algorithm on each paragraph of a block with that style.
2641         This is similar to dir=auto but done per-paragraph instead of per element.
2642
2643         Test: fast/text/international/unicode-bidi-plaintext.html
2644
2645         * css/CSSParser.cpp:
2646         (WebCore::CSSParser::parseValue):  Added plaintext.
2647         * css/CSSPrimitiveValueMappings.h:
2648         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Ditto.
2649         (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): Ditto.
2650         * css/CSSValueKeywords.in: Ditto.
2651         * html/HTMLElement.cpp:
2652         (WebCore::unicodeBidiAttributeForDirAuto): Helper to map elements with dir=auto
2653         to their proper unicode-bidi attribute.
2654         (WebCore::HTMLElement::parseMappedAttribute): Assign plaintext to pre and textarea
2655         when dir=auto.
2656         * platform/text/UnicodeBidi.h: Added plaintext.
2657         * rendering/RenderBlockLineLayout.cpp:
2658         (WebCore::determineParagraphDirection): Determines the direction of a paragraph
2659         based on the first strong character. Stops at first paragraph separator.
2660         (WebCore::RenderBlock::layoutInlineChildren): Uses determineParagraphDirection
2661         when in unicode-bidi: plaintext mode (and operating at the block's BidiContext)
2662         to set each paragraph to the proper base BidiContext.
2663         (WebCore::RenderBlock::determineStartPosition): Ditto.
2664         * rendering/style/RenderStyle.h: Gave _unicodebidi another bit to accomodate
2665         for plaintext.
2666
2667 2011-06-27  Alexis Menard  <alexis.menard@openbossa.org>
2668
2669         Reviewed by Darin Adler.
2670
2671         Use specific headers includes rather than full system headers.
2672         https://bugs.webkit.org/show_bug.cgi?id=63475
2673
2674         Use only needed headers rather than system headers.
2675
2676         No new tests, it's just a little cosmetic change.
2677
2678         * platform/mac/WebVideoFullscreenController.h:
2679         * platform/mac/WebVideoFullscreenHUDWindowController.h:
2680
2681 2011-06-27  Joseph Pecoraro  <joepeck@webkit.org>
2682
2683         Reviewed by Darin Adler.
2684
2685         Allow non-main thread text drawing in ICU ports
2686         https://bugs.webkit.org/show_bug.cgi?id=63482
2687
2688         Some ports allow multiple threads to draw strings.
2689         LineBreakIteratorPool is not thread safe and the existing
2690         ASSERT caught cases where multiple threads were trying
2691         to access the shared pool. This makes the pool a lazily
2692         created per-thread pool to allow for thread safe pool use.
2693
2694         * platform/ThreadGlobalData.h:
2695         * platform/ThreadGlobalData.cpp:
2696         (WebCore::ThreadGlobalData::ThreadGlobalData): start with null.
2697         (WebCore::ThreadGlobalData::lineBreakIteratorPool): lazily create.
2698         (WebCore::ThreadGlobalData::destroy): delete.
2699         Manage the lifetime of the per-thread pool instance.
2700
2701         * platform/text/LineBreakIteratorPoolICU.h:
2702         (WebCore::LineBreakIteratorPool::sharedPool):
2703         Use the per-thread pool instance and remove the ASSERT that
2704         this needs to be on the main thread.
2705
2706         (WebCore::LineBreakIteratorPool::create):
2707         Create a PassOwnPtr so we can use OwnPtr on pools.
2708
2709         (WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
2710         Private now that there is a public create function.
2711
2712 2011-06-27  Joseph Pecoraro  <joepeck@webkit.org>
2713
2714         Reviewed by Darin Adler.
2715
2716         Extract LineBreakIteratorPool class into its own file
2717         https://bugs.webkit.org/show_bug.cgi?id=63471
2718
2719         * GNUmakefile.list.am:
2720         * WebCore.gypi:
2721         * WebCore.vcproj/WebCore.vcproj:
2722         * WebCore.xcodeproj/project.pbxproj:
2723         Add the new file to builds that used TextBreakIteratorPoolICU.h.
2724
2725         * platform/text/LineBreakIteratorPoolICU.h: Added.
2726         (WebCore::LineBreakIteratorPool::sharedPool):
2727         (WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
2728         Expose the constructor so it can be used by others.
2729
2730         * platform/text/TextBreakIteratorICU.cpp:
2731         Remove the old LineBreakIteratorPool implementation.
2732
2733 2011-06-27  Justin Garcia  <justin.garcia@apple.com>
2734
2735         Reviewed by Ryosuke Niwa.
2736
2737         CompositeEditCommand::inputText(const String& text, bool selectedInsertText) is unused
2738         https://bugs.webkit.org/show_bug.cgi?id=62921
2739
2740         * editing/CompositeEditCommand.cpp:
2741         * editing/CompositeEditCommand.h:
2742         * editing/InsertTextCommand.cpp:
2743         (WebCore::InsertTextCommand::input):
2744
2745 2011-05-17  Nat Duca  <nduca@chromium.org>
2746
2747         Reviewed by James Robinson.
2748
2749         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
2750         https://bugs.webkit.org/show_bug.cgi?id=58408
2751
2752         Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
2753         thread and compositor thread halves of a composited view. Communication
2754         between the two is based on the design used in FileStreamProxy.
2755
2756         * WebCore.gypi:
2757         * platform/chromium/TraceEvent.h:
2758         * platform/graphics/chromium/LayerRendererChromium.cpp:
2759         (WebCore::LayerRendererChromium::create):
2760         (WebCore::LayerRendererChromium::LayerRendererChromium):
2761         (WebCore::LayerRendererChromium::setViewport):
2762         (WebCore::LayerRendererChromium::updateLayers):
2763         (WebCore::LayerRendererChromium::drawLayers):
2764         (WebCore::LayerRendererChromiumImpl::create):
2765         (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent):
2766         (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl):
2767         (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread):
2768         (WebCore::LayerRendererChromiumImplProxy::create):
2769         (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl):
2770         (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy):
2771         (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
2772         * platform/graphics/chromium/LayerRendererChromium.h:
2773         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
2774         (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
2775         (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
2776         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
2777         (WebCore::CCHeadsUpDisplay::currentFrameNumber):
2778         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
2779         (WebCore::CCLayerTreeHost::CCLayerTreeHost):
2780         (WebCore::CCLayerTreeHost::init):
2781         (WebCore::CCLayerTreeHost::~CCLayerTreeHost):
2782         (WebCore::CCLayerTreeHost::beginCommit):
2783         (WebCore::CCLayerTreeHost::commitComplete):
2784         (WebCore::CCLayerTreeHost::animateAndLayout):
2785         (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter):
2786         (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw):
2787         (WebCore::CCLayerTreeHost::setNeedsRedraw):
2788         (WebCore::CCLayerTreeHost::updateLayers):
2789         * platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
2790         (WebCore::CCLayerTreeHost::frameNumber):
2791         * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
2792         (WebCore::CCLayerTreeHostCommitter::create):
2793         (WebCore::CCLayerTreeHostCommitter::commit):
2794         * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
2795         (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
2796         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added.
2797         (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
2798         (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
2799         (WebCore::CCLayerTreeHostImpl::beginCommit):
2800         (WebCore::CCLayerTreeHostImpl::commitComplete):
2801         (WebCore::CCLayerTreeHostImpl::drawLayers):
2802         (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw):
2803         (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
2804         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
2805         (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient):
2806         (WebCore::CCLayerTreeHostImpl::frameNumber):
2807         (WebCore::CCLayerTreeHostImpl::sourceFrameNumber):
2808         (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
2809         * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added.
2810         (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy):
2811         (WebCore::CCLayerTreeHostImplProxy::start):
2812         (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy):
2813         (WebCore::CCLayerTreeHostImplProxy::isStarted):
2814         (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw):
2815         (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw):
2816         (WebCore::CCLayerTreeHostImplProxy::stop):
2817         (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
2818         (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
2819         (WebCore::CCLayerTreeHostImplProxy::isMainThread):
2820         (WebCore::CCLayerTreeHostImplProxy::isCCThread):
2821         (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit):
2822         (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
2823         (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
2824         (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
2825         (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
2826         (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
2827         (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
2828         * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added.
2829         (WebCore::CCLayerTreeHostImplProxy::host):
2830         * platform/graphics/chromium/cc/CCMainThreadTask.h:
2831         * platform/graphics/chromium/cc/CCThread.cpp:
2832         (WebCore::CCThread::runLoop):
2833         * platform/graphics/chromium/cc/CCThreadTask.h:
2834
2835 2011-06-27  Abhishek Arya  <inferno@chromium.org>
2836
2837         Reviewed by Simon Fraser.
2838
2839         Fix removal of overhanging floats on style changes to absolute/fixed position.
2840         https://bugs.webkit.org/show_bug.cgi?id=63355
2841
2842         1. If we are not currently positioned.
2843         2. And we are not floating. (If we are floating, then this will be automatically
2844            done in RenderBox::styleWillChange as part of removeFloatingOrPositionedChildFromBlockLists) 
2845         3. And we have overhanging floats from previous sibling blocks.
2846         4. And our new new style tells that we will have absolute or fixed position.
2847
2848         Then, we mark all our descendants with floats for layout. This will make sure that
2849         overhanging floats are removed. Also, it is important to do that since if that previous
2850         sibling block goes away, it is not able to tell us that to remove those floats thinking 
2851         that being a positioned block, we should have removed them already.
2852
2853         Tests: fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html
2854                fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html
2855                fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html
2856                fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html
2857                fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html
2858                fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html
2859                fast/block/float/overhanging-float-add-in-static-position-block.html
2860                fast/block/float/overhanging-float-add-in-static-position-block2.html
2861                fast/block/float/overhanging-float-remove-from-absolute-position-block.html
2862                fast/block/float/overhanging-float-remove-from-absolute-position-block2.html
2863                fast/block/float/overhanging-float-remove-from-fixed-position-block.html
2864                fast/block/float/overhanging-float-remove-from-fixed-position-block2.html
2865
2866         * rendering/RenderBlock.cpp:
2867         (WebCore::RenderBlock::styleWillChange):
2868
2869 2011-06-27  Dirk Schulze  <krit@webkit.org>
2870
2871         Reviewed by Nikolas Zimmermann.
2872
2873         SVGAnimatedType should support SVGPreserveAspectRatio animation
2874         https://bugs.webkit.org/show_bug.cgi?id=63456
2875         
2876         Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
2877         This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedPreserveAspectRatio.
2878         
2879         The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
2880         to support animVal and baseVal later.
2881
2882         Test: svg/animations/svgPreserveAspectRatio-animation-1.html
2883
2884         * CMakeLists.txt: Added new file.
2885         * GNUmakefile.list.am: Ditto.
2886         * WebCore.gypi: Ditto.
2887         * WebCore.pro: Ditto.
2888         * WebCore.xcodeproj/project.pbxproj: Ditto.
2889         * svg/SVGAllInOne.cpp: Ditto.
2890         * svg/SVGAnimateElement.cpp: Handle AnimatedPreserveAspectRatio.
2891         (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
2892         (WebCore::SVGAnimateElement::calculateAnimatedValue):
2893         (WebCore::SVGAnimateElement::calculateFromAndToValues):
2894         (WebCore::SVGAnimateElement::calculateFromAndByValues):
2895         (WebCore::SVGAnimateElement::resetToBaseValue):
2896         (WebCore::SVGAnimateElement::applyResultsToTarget):
2897         (WebCore::SVGAnimateElement::calculateDistance):
2898         * svg/SVGAnimatedPreserveAspectRatio.cpp: Added. New animator for SVGAnimatedPreserveAspectRatio.
2899         (WebCore::SVGAnimatedPreserveAspectRatioAnimator::SVGAnimatedPreserveAspectRatioAnimator):
2900         (WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString):
2901         (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndToValues):
2902         (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateFromAndByValues):
2903         (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):
2904         (WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateDistance):
2905         * svg/SVGAnimatedPreserveAspectRatio.h:
2906         (WebCore::SVGAnimatedPreserveAspectRatioAnimator::~SVGAnimatedPreserveAspectRatioAnimator):
2907         * svg/SVGAnimatedType.cpp: Support for SVGPreserveAspectRatio.
2908         (WebCore::SVGAnimatedType::~SVGAnimatedType):
2909         (WebCore::SVGAnimatedType::createPreserveAspectRatio):
2910         (WebCore::SVGAnimatedType::preserveAspectRatio):
2911         (WebCore::SVGAnimatedType::valueAsString):
2912         (WebCore::SVGAnimatedType::setValueAsString):
2913         (WebCore::SVGAnimatedType::setPreserveAspectRatioBaseValue):
2914         * svg/SVGAnimatedType.h:
2915         * svg/SVGAnimatorFactory.h:
2916         (WebCore::SVGAnimatorFactory::create):
2917
2918 2011-06-27  Alexis Menard  <alexis.menard@openbossa.org>
2919
2920         Reviewed by Kenneth Rohde Christiansen.
2921
2922         [Qt] Remove Phonon MediaPlayer from the tree.
2923         https://bugs.webkit.org/show_bug.cgi?id=63448
2924
2925         Remove Phonon mediaplayer as it is unused, not finished and
2926         unmaintained.
2927
2928         * WebCore.gypi:
2929         * WebCore.pri:
2930         * WebCore.pro:
2931         * features.pri:
2932         * platform/graphics/MediaPlayer.cpp:
2933         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Removed.
2934         * platform/graphics/qt/MediaPlayerPrivatePhonon.h: Removed.
2935
2936 2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>
2937
2938         Reviewed by Kent Tamura.
2939
2940         Crash in TextIterator
2941         https://bugs.webkit.org/show_bug.cgi?id=63334
2942
2943         Fix a crash in TextIterator. Keep m_sortedTextBoxes and renderer consistent
2944         and check !m_offset when handling first letter.
2945
2946         Also add more assertions to help detecting similar bugs.
2947
2948         Test: editing/text-iterator/first-letter-rtl-crash.html
2949
2950         * editing/TextIterator.cpp:
2951         (WebCore::TextIterator::handleTextNode):
2952         (WebCore::TextIterator::emitText):
2953
2954 2011-06-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2955
2956         Reviewed by Andreas Kling.
2957
2958         [Qt] tst_QWebFrame::overloadedSlots() fails
2959         https://bugs.webkit.org/show_bug.cgi?id=37319
2960
2961         This patch is based on Noam Rosenthal original patch in the same bug.
2962
2963         When hinted with QWebElement metatype, we qualify the conversion
2964         from JSElement as a "perfect match".
2965
2966         The test was failing because the wrong slot was called, since the QWebElement
2967         match was taken as equal to the others and not chosen when the metacall happened.
2968
2969         * bridge/qt/qt_runtime.cpp:
2970         (JSC::Bindings::convertValueToQVariant): Identify the conversion between JSElement
2971         to QWebElement as a "perfect match" (dist = 0). Add comments to explain the reason
2972         why we have the implicit conversion.
2973
2974 2011-06-27  ChangSeok Oh  <shivamidow@gmail.com>
2975
2976         Reviewed by Martin Robinson.
2977
2978         [GTK] Fix build break to support webgl
2979         https://bugs.webkit.org/show_bug.cgi?id=63425
2980
2981         Some missing files in ANGLE are just added to fix build-break.
2982
2983         No test reqired
2984
2985         * GNUmakefile.list.am:
2986
2987 2011-06-27  Hyowon Kim  <hw1008.kim@samsung.com>
2988
2989         Reviewed by Martin Robinson.
2990
2991         [EFL] Add some PLATFORM(EFL) ifdefs to GraphicsContext3D.h
2992         https://bugs.webkit.org/show_bug.cgi?id=62959
2993
2994         Add PLATFORM(EFL) ifdefs to use GraphicsContextInternal.
2995
2996         * platform/graphics/GraphicsContext3D.h:
2997
2998 2011-06-27  Alexandru Chiculita  <achicu@adobe.com>
2999
3000         Reviewed by Ojan Vafai.
3001
3002         css combinator "+" in combination with NAV tag is buggy
3003         https://bugs.webkit.org/show_bug.cgi?id=47971
3004
3005         Added a new state in css/tokenizer.flex for the "nth" rule. The state begins
3006         at nth-*( functions and ends at the first ")". It avoids parsing selectors 
3007         like "#div+nav" as: "#div" "+n" "av".
3008
3009         Test: fast/css/div_plus_nav_bug47971.html
3010
3011         * css/maketokenizer:
3012         * css/tokenizer.flex:
3013
3014 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3015
3016         Unreviewed, rolling out r89822.
3017         http://trac.webkit.org/changeset/89822
3018         https://bugs.webkit.org/show_bug.cgi?id=63461
3019
3020         Broken builds (Requested by apavlov on #webkit).
3021
3022         * inspector/Inspector.json:
3023         * inspector/InspectorCSSAgent.cpp:
3024         (WebCore::InspectorCSSAgent::getStylesForNode):
3025         * inspector/InspectorCSSAgent.h:
3026         * inspector/front-end/AuditRules.js:
3027         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
3028         * inspector/front-end/CSSStyleModel.js:
3029         (WebInspector.CSSStyleModel.prototype.getStylesAsync):
3030         * inspector/front-end/StylesSidebarPane.js:
3031         (WebInspector.StylesSidebarPane.prototype.update):
3032
3033 2011-06-27  Noel Gordon  <noel.gordon@gmail.com>
3034
3035         Reviewed by Adam Roben.
3036
3037         Send keypress events to windowless plugins on the windows port.
3038         https://bugs.webkit.org/show_bug.cgi?id=63144
3039
3040         No new tests.  Covered by existing windowless plugin tests plugins/mouse-events.html
3041         and plugins/keyboard-events.html.  Both are not yet working as desired because focus
3042         events are not being fowarded to windowed plugins on the win port (bug 62375).  Test
3043         plugin logging on the win port was added in bug 61721.  New failing expectations for
3044         plugins/keyboard-events.html were subsequently added in bug 33973 so there's no need
3045         to update test expectations in this patch.
3046
3047          * plugins/win/PluginViewWin.cpp:
3048         (WebCore::PluginView::handleKeyboardEvent): Add an ASSERT(m_plugin && !m_isWindowed)
3049         to indicate that the routine is for windowless plugins.  Remove trailing whitespace.
3050         Add handling for keyPress events (map to WM_CHAR).
3051         (WebCore::PluginView::handleMouseEvent): Add the ASSERT to indicate that the routine
3052         is for windowless plugins.  Add FIXME note.  Remove trailing whitespace.
3053
3054 2011-06-27  Alexander Pavlov  <apavlov@chromium.org>
3055
3056         Reviewed by Pavel Feldman.
3057
3058         Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
3059         https://bugs.webkit.org/show_bug.cgi?id=63446
3060
3061         * inspector/Inspector.json:
3062         * inspector/InspectorCSSAgent.cpp:
3063         (WebCore::computePseudoClassMask):
3064         (WebCore::InspectorCSSAgent::getStylesForNode):
3065         * inspector/InspectorCSSAgent.h:
3066         * inspector/front-end/AuditRules.js:
3067         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
3068         * inspector/front-end/CSSStyleModel.js:
3069         (WebInspector.CSSStyleModel.prototype.getStylesAsync):
3070         * inspector/front-end/StylesSidebarPane.js:
3071         (WebInspector.StylesSidebarPane.prototype.update):
3072
3073 2011-06-27  Pavel Feldman  <pfeldman@google.com>
3074
3075         Reviewed by Yury Semikhatsky.
3076
3077         Web Inspector: [REGRESSION r84481] updateLayout called from DrawNodeHighlight
3078         https://bugs.webkit.org/show_bug.cgi?id=63405
3079
3080         We should not call layout from paint.
3081
3082         * inspector/DOMNodeHighlighter.cpp:
3083         (WebCore::DOMNodeHighlighter::drawNodeHighlight):
3084         * inspector/DOMNodeHighlighter.h:
3085         * inspector/InspectorDOMAgent.cpp:
3086         (WebCore::InspectorDOMAgent::drawNodeHighlight):
3087
3088 2011-06-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3089
3090         Unreviewed. Fix style error in EFL port.
3091
3092         * platform/efl/PlatformKeyboardEventEfl.cpp:
3093         * platform/efl/PlatformScreenEfl.cpp:
3094         * platform/efl/SharedBufferEfl.cpp:
3095
3096 2011-06-27  Pavel Feldman  <pfeldman@google.com>
3097
3098         Reviewed by Yury Semikhatsky.
3099
3100         Web Inspector: node selection is slow in the Elements panel.
3101         https://bugs.webkit.org/show_bug.cgi?id=60813
3102
3103         * inspector/front-end/StylesSidebarPane.js:
3104         (WebInspector.StylesSidebarPane.prototype.update.stylesCallback):
3105         (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback):
3106         (WebInspector.StylesSidebarPane.prototype.update):
3107
3108 2011-06-26  Pavel Feldman  <pfeldman@chromium.org>
3109
3110         Reviewed by Yury Semikhatsky.
3111
3112         Web Inspector: roll out r88337 for making tests flaky.
3113         https://bugs.webkit.org/show_bug.cgi?id=63422
3114
3115         * inspector/front-end/ElementsPanel.js:
3116         (WebInspector.ElementsPanel):
3117         (WebInspector.ElementsPanel.prototype.updateStyles):
3118         (WebInspector.ElementsPanel.prototype._stylesUpdated):
3119         * inspector/front-end/StylesSidebarPane.js:
3120         (WebInspector.StylesSidebarPane.prototype.update.stylesCallback):
3121         (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback):
3122         (WebInspector.StylesSidebarPane.prototype.update):
3123
3124 2011-06-27  Huang Dongsung  <luxtella@company100.net>
3125
3126         Reviewed by Kenneth Rohde Christiansen.
3127
3128         TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
3129         error.
3130         https://bugs.webkit.org/show_bug.cgi?id=62422
3131
3132         REGRESSION(r77286): Remove bottomRight().
3133         REGRESSION(r77312): Change the logic to get the bottom right point.
3134         REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
3135         REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
3136         REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.
3137
3138         If the viewport width equals the contents width, especially in the mobile
3139         device, TiledBackingStore endlessly creates and deletes the rightmost
3140         column and bottom row of tiles.
3141         In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
3142         deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
3143         tiles infinitely.
3144         Modified TiledDrawingAreaProxy also.
3145
3146         * platform/graphics/TiledBackingStore.cpp:
3147         (WebCore::innerBottomRight):
3148         (WebCore::TiledBackingStore::invalidate):
3149         (WebCore::TiledBackingStore::paint):
3150         (WebCore::TiledBackingStore::createTiles):
3151
3152 2011-06-26  Adam Barth  <abarth@webkit.org>
3153
3154         Reviewed by Eric Seidel.
3155
3156         Remove LegacyDefaultOptionalArguments from WebAudio IDL files
3157         https://bugs.webkit.org/show_bug.cgi?id=63416
3158
3159         WebAudio isn't that widely used, so it's seems somewhat safe to remove
3160         legacy code generation hacks.  I'm not an expert on WebAudio, but the
3161         API doesn't appear to need many optional arguments.
3162
3163         There are a bunch of APIs that have custom bindings that look like they
3164         could be autogenerated.  I've added FIXME comments where appropriate.
3165
3166         * webaudio/AudioBuffer.idl:
3167         * webaudio/AudioContext.idl:
3168         * webaudio/AudioListener.idl:
3169         * webaudio/AudioNode.idl:
3170         * webaudio/AudioPannerNode.idl:
3171         * webaudio/AudioParam.idl:
3172         * webaudio/RealtimeAnalyserNode.idl:
3173
3174 2011-06-26  Yury Semikhatsky  <yurys@chromium.org>
3175
3176         Reviewed by Pavel Feldman.
3177
3178         Web Inspector: REGRESSION Scripts panel sidebar pane context menu has no "Remove breakpoint" item
3179         https://bugs.webkit.org/show_bug.cgi?id=63421
3180
3181         Show generic sidebar menu only if no pane-specific menu has been shown.
3182
3183         * inspector/front-end/ScriptsPanel.js:
3184         (WebInspector.ScriptsPanel):
3185
3186 2011-06-26  Adam Barth  <abarth@webkit.org>
3187
3188         Build fix for clang.  Apparently clang doesn't want us to use the std
3189         namespace in headers, which makes sense.
3190
3191         * svg/SVGAnimatedType.h:
3192
3193 2011-06-26  Adam Barth  <abarth@webkit.org>
3194
3195         Reviewed by Eric Seidel.
3196
3197         Remove LegacyDefaultOptionalArguments from XMLHttpRequest.idl and XMLHttpRequestUpload.idl
3198         https://bugs.webkit.org/show_bug.cgi?id=63418
3199
3200         The XMLHttpRequest.idl interface used to implement the new behavior
3201         manually using the RequiresAllArguments attribute.  Now that we have
3202         that behavior by default, we can simply remove the
3203         LegacyDefaultOptionalArguments attribute.
3204
3205         * xml/XMLHttpRequest.idl:
3206         * xml/XMLHttpRequestUpload.idl:
3207
3208 2011-06-26  Dirk Schulze  <krit@webkit.org>
3209
3210         Reviewed by Nikolas Zimmermann.
3211
3212         SVGAnimatedType should support SVGLengthList animation
3213         https://bugs.webkit.org/show_bug.cgi?id=63399
3214
3215         Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
3216         This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedLengthList.
3217         
3218         Interpolated animations of glyph positions are possible now.
3219
3220         Tests: svg/animations/svglengthlist-animation-1.html
3221                svg/animations/svglengthlist-animation-2.html
3222                svg/animations/svglengthlist-animation-3.html
3223                svg/animations/svglengthlist-animation-4.html
3224
3225         * CMakeLists.txt: Add new file to build system.
3226         * GNUmakefile.list.am: Ditto.
3227         * WebCore.gypi: Ditto.
3228         * WebCore.pro: Ditto.
3229         * WebCore.xcodeproj/project.pbxproj: Ditto.
3230         * svg/SVGAllInOne.cpp: Ditto.
3231         * svg/SVGAnimateElement.cpp: Make use of AnimatedLengthList.
3232         (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
3233         (WebCore::SVGAnimateElement::calculateAnimatedValue):
3234         (WebCore::SVGAnimateElement::calculateFromAndToValues):
3235         (WebCore::SVGAnimateElement::calculateFromAndByValues):
3236         (WebCore::SVGAnimateElement::resetToBaseValue):
3237         (WebCore::SVGAnimateElement::applyResultsToTarget):
3238         (WebCore::SVGAnimateElement::calculateDistance):
3239         * svg/SVGAnimatedLengthList.cpp: Added. New animator for SVGLengthList.
3240         (WebCore::SVGAnimatedLengthListAnimator::SVGAnimatedLengthListAnimator):
3241         (WebCore::SVGAnimatedLengthListAnimator::constructFromString):
3242         (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndToValues):
3243         (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues):
3244         (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
3245         (WebCore::SVGAnimatedLengthListAnimator::calculateDistance):
3246         * svg/SVGAnimatedLengthList.h:
3247         (WebCore::SVGAnimatedLengthListAnimator::~SVGAnimatedLengthListAnimator):
3248         * svg/SVGAnimatedType.cpp: Add SVGLengthList.
3249         (WebCore::SVGAnimatedType::~SVGAnimatedType):
3250         (WebCore::SVGAnimatedType::createLengthList):
3251         (WebCore::SVGAnimatedType::lengthList):
3252         (WebCore::SVGAnimatedType::valueAsString):
3253         (WebCore::SVGAnimatedType::setValueAsString):
3254         * svg/SVGAnimatedType.h:
3255         * svg/SVGAnimatorFactory.h:
3256         (WebCore::SVGAnimatorFactory::create):
3257         * svg/SVGLength.cpp: Add new constructor with LengthType, LengthMode and value.
3258         (WebCore::SVGLength::SVGLength):
3259         * svg/SVGLength.h:
3260
3261 2011-06-26  Adam Barth  <abarth@webkit.org>
3262
3263         Reviewed by Eric Seidel.
3264
3265         window.location should use the holder's prototype chain
3266         https://bugs.webkit.org/show_bug.cgi?id=63411
3267
3268         This patch corrects the prototype chain for Location, but we really
3269         should do a complete cleanup of the prototype chain generation, like we
3270         did for JavaScriptCore.
3271
3272         Test: http/tests/security/location-prototype.html
3273
3274         * bindings/scripts/CodeGeneratorV8.pm:
3275
3276 2011-06-26  Adam Barth  <abarth@webkit.org>
3277
3278         Reviewed by Eric Seidel.
3279
3280         Add [Optional] attributes where appropriate for addEventListener and removeEventListener
3281         https://bugs.webkit.org/show_bug.cgi?id=63417
3282
3283         This patch doesn't actually change behavior because these interfaces
3284         have the LegacyDefaultOptionalArguments attribute.  This patch paves
3285         the way to removing LegacyDefaultOptionalArguments from some of these
3286         interfaces as well as making the project safer for copy-and-pasting
3287         these methods into new IDL files that don't have the
3288         LegacyDefaultOptionalArguments attribute.
3289
3290         * bindings/scripts/test/TestObj.idl:
3291         * dom/EventTarget.idl:
3292         * dom/MediaStream.idl:
3293         * dom/MessagePort.idl:
3294         * dom/Node.idl:
3295         * loader/appcache/DOMApplicationCache.idl:
3296         * notifications/Notification.idl:
3297         * page/DOMWindow.idl:
3298         * page/EventSource.idl:
3299         * storage/IDBRequest.idl:
3300         * storage/IDBTransaction.idl:
3301         * svg/SVGElementInstance.idl:
3302         * websockets/WebSocket.idl:
3303         * workers/AbstractWorker.idl:
3304         * workers/WorkerContext.idl:
3305         * xml/XMLHttpRequest.idl:
3306         * xml/XMLHttpRequestUpload.idl:
3307
3308 2011-06-26  Adam Barth  <abarth@webkit.org>
3309
3310         Reviewed by Kent Tamura.
3311
3312         m_formElementsWithFormAttribute doesn't ref the objects it holds
3313         https://bugs.webkit.org/show_bug.cgi?id=62956
3314
3315         Test: fast/forms/form-associated-element-crash3.html
3316
3317         * dom/Document.h:
3318
3319 2011-06-26  Dimitri Glazkov  <dglazkov@chromium.org>
3320
3321         Reviewed by Adam Barth.
3322
3323         FileList::filenames should be FileList::paths, because it's more accurate.
3324         https://bugs.webkit.org/show_bug.cgi?id=63414
3325
3326         Refactoring, no change in behavior.
3327
3328         * fileapi/FileList.cpp:
3329         (WebCore::FileList::paths): Renamed from filenames.
3330         * fileapi/FileList.h:
3331         * html/FileInputType.cpp:
3332         (WebCore::FileInputType::handleDOMActivateEvent): Changed to use filenames, also fixed a reach-unto-thyself whoopsie.
3333         (WebCore::FileInputType::requestIcon): Ditto.
3334         (WebCore::FileInputType::filesChosen): Ditto.
3335         * rendering/RenderFileUploadControl.cpp:
3336         (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
3337
3338 2011-06-26  Young Han Lee  <joybro@company100.net>
3339
3340         Reviewed by Dirk Schulze.
3341
3342         SVGAnimation - keyTime value 1 never get animated
3343         https://bugs.webkit.org/show_bug.cgi?id=63230
3344
3345         According to the SMIL 3.0 specification, the index of the keyTimes should be 
3346         determined under the end-point-exclusive rule (e.g. Given keyTimes(0;0.5;1) 
3347         and t=0.5, the current index of the keyTimes have to be 1 not 0).
3348         http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationExamplesAdvanced
3349
3350         Test: svg/animations/animate-number-calcMode-discrete-keyTimes.html
3351
3352         * svg/SVGAnimationElement.cpp:
3353         (WebCore::SVGAnimationElement::calculateKeyTimesIndex):
3354
3355 2011-06-26  Dan Bernstein  <mitz@apple.com>
3356
3357         Reviewed by Darin Adler.
3358
3359         With word-break: break-all, words do not break correctly before a surrogate pair
3360         https://bugs.webkit.org/show_bug.cgi?id=63401
3361
3362         The code to check for mid-word breaks accumulates width one character at a time. It was actually
3363         measuring the two parts of the surrogate pair individually, so they appeared to have zero width.
3364         Fixed by checking for surrogate pairs and measuring the pair as one unit.
3365
3366         Test: fast/text/midword-break-before-surrogate-pair.html
3367
3368         * rendering/RenderBlockLineLayout.cpp:
3369         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
3370
3371 2011-06-26  Dirk Schulze  <krit@webkit.org>
3372
3373         Reviewed by Nikolas Zimmermann.
3374
3375         SVGAnimatedType should support SVGNumberOptionalNumber animation
3376         https://bugs.webkit.org/show_bug.cgi?id=63397
3377         
3378         Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
3379         This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedNumberOptionalNumber.
3380         
3381         Animations of attributes with type SVGAnimatedNumberOptionalNumber can be interpolated now. This can be used for smooth
3382         growing shadows with feGaussianBlur, feDropShadow or other filter effects.
3383
3384         Tests: svg/animations/svgnumberoptionalnumber-animation-1.html
3385                svg/animations/svgnumberoptionalnumber-animation-2.html
3386                svg/animations/svgnumberoptionalnumber-animation-3.html
3387                svg/animations/svgnumberoptionalnumber-animation-4.html
3388
3389         * CMakeLists.txt: Added new files to build system.
3390         * GNUmakefile.list.am: Ditto.
3391         * WebCore.gypi: Ditto.
3392         * WebCore.pro: Ditto.
3393         * WebCore.vcproj/WebCore.vcproj: Ditto.
3394         * WebCore.xcodeproj/project.pbxproj: Ditto.
3395         * svg/SVGAllInOne.cpp: Ditto.
3396         * svg/SVGAnimateElement.cpp: Make use of attribute type AnimatedNumberOptionalNumber.
3397         (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
3398         (WebCore::SVGAnimateElement::calculateAnimatedValue):
3399         (WebCore::SVGAnimateElement::calculateFromAndToValues):
3400         (WebCore::SVGAnimateElement::calculateFromAndByValues):
3401         (WebCore::SVGAnimateElement::resetToBaseValue):
3402         (WebCore::SVGAnimateElement::applyResultsToTarget):
3403         (WebCore::SVGAnimateElement::calculateDistance):
3404         * svg/SVGAnimatedNumberOptionalNumber.cpp: Added. New animator for SVGAnimatedNumberOptionalNumber.
3405         (WebCore::SVGAnimatedNumberOptionalNumberAnimator::SVGAnimatedNumberOptionalNumberAnimator):
3406         (WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromString):
3407         (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndToValues):
3408         (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateFromAndByValues):
3409         (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):
3410         (WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateDistance):
3411         * svg/SVGAnimatedNumberOptionalNumber.h: Added.
3412         (WebCore::SVGAnimatedNumberOptionalNumberAnimator::~SVGAnimatedNumberOptionalNumberAnimator):
3413         * svg/SVGAnimatedType.cpp: Added new type: pair<float, float>.
3414         (WebCore::SVGAnimatedType::~SVGAnimatedType):
3415         (WebCore::SVGAnimatedType::createNumberOptionalNumber):
3416         (WebCore::SVGAnimatedType::numberOptionalNumber):
3417         (WebCore::SVGAnimatedType::valueAsString):
3418         (WebCore::SVGAnimatedType::setValueAsString):
3419         * svg/SVGAnimatedType.h:
3420         * svg/SVGAnimatorFactory.h: Add new animator to factory.
3421         (WebCore::SVGAnimatorFactory::create):
3422
3423 2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>
3424
3425         Reviewed by Adam Barth.
3426
3427         Crash in frameless document with media element.
3428         https://bugs.webkit.org/show_bug.cgi?id=63393
3429
3430         Since MediaControls::create can return 0 (and does for frameless documents), we must anticipate it
3431         in the calling code.
3432
3433         Test: fast/dom/shadow/frameless-media-element-crash.html
3434
3435         * html/HTMLMediaElement.cpp:
3436         (WebCore::HTMLMediaElement::attributeChanged): Changed to bail out if controls weren't successfully created.
3437         (WebCore::HTMLMediaElement::createMediaControls): Renamed to better reflect the purpose, changed to handle failure of creation.
3438         (WebCore::HTMLMediaElement::preDispatchEventHandler): Changed to bail out if controls weren't successfully created.
3439         * html/HTMLMediaElement.h: Adjusted def.
3440
3441 2011-06-25  Joseph Pecoraro  <joepeck@webkit.org>
3442
3443         Reviewed by Darin Adler.
3444
3445         Fix some minor style issues
3446         https://bugs.webkit.org/show_bug.cgi?id=63391
3447
3448         * inspector/DOMNodeHighlighter.cpp:
3449         (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
3450         The explicit WebCore namespace usage can be dropped.
3451
3452         * rendering/RenderView.cpp:
3453         (WebCore::RenderView::mapLocalToContainer):
3454         Use ASSERT_UNUSED for a parameter that we want to ASSERT
3455         on for a debug build, but is UNUSED in a release build.
3456
3457 2011-06-25  Joseph Pecoraro  <joepeck@webkit.org>
3458
3459         Unreviewed build fix.
3460
3461         Use UNUSED_PARAM on the correct param!
3462
3463         * rendering/RenderView.cpp:
3464         (WebCore::RenderView::mapLocalToContainer):
3465
3466 2011-06-25  Joseph Pecoraro  <joepeck@webkit.org>
3467
3468         Reviewed by Simon Fraser.
3469
3470         Inspector highlight rect is wrong for contents of transformed iframes
3471         https://bugs.webkit.org/show_bug.cgi?id=53627
3472
3473         Part 2: Only adjust for the FrameView's scroll position when