Fix for <rdar://problem/8882916> Overlay scrollers require
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-01-18  Beth Dakin  <bdakin@apple.com>
2
3         Reviewed by Maciej Stachowiak.
4
5         Fix for <rdar://problem/8882916> Overlay scrollers require 
6         content to layout underneath the scrollbar area
7
8         The render tree should not include scrollbar size for
9         overlay scrollers. This patch will allow scrollers on
10         the WebView to behave like overflow:overlay.
11
12         Treat overlay scrollers the same way as the !includeScrollbars
13         case.
14         * platform/ScrollView.cpp:
15         (WebCore::ScrollView::visibleContentRect):
16
17         No corner rect for overlay scrollers.
18         (WebCore::ScrollView::scrollCornerRect):
19
20         usesOverlayScrollbars() currently always returns no.
21         * platform/ScrollbarTheme.h:
22         (WebCore::ScrollbarTheme::usesOverlayScrollbars):
23         * platform/mac/ScrollbarThemeMac.h:
24         * platform/mac/ScrollbarThemeMac.mm:
25         (WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
26
27         includeVerticalScrollbarSize() and includeHorizontalScrollbarSize()
28         should return false for overlay scrollers. They already return
29         false for overflow:overlay.
30         * rendering/RenderBox.cpp:
31         (WebCore::RenderBox::includeVerticalScrollbarSize):
32         (WebCore::RenderBox::includeHorizontalScrollbarSize):
33         * rendering/RenderBox.h:
34
35         In the render tree, always treat overlay scrollers like
36         they have a width and height of 0.
37         * rendering/RenderLayer.cpp:
38         (WebCore::RenderLayer::verticalScrollbarWidth):
39         (WebCore::RenderLayer::horizontalScrollbarHeight):
40         * rendering/RenderListBox.cpp:
41         (WebCore::RenderListBox::verticalScrollbarWidth):
42
43 2011-01-18  Evan Martin  <evan@chromium.org>
44
45         Reviewed by Tony Chang.
46
47         [chromium] simplify complex text code, fixing a handful of layout tests
48         https://bugs.webkit.org/show_bug.cgi?id=52661
49
50         Change ComplexTextControllerLinux to lay out RTL text to the left from
51         the starting point.  (Previously it always went to the right.)  This allows
52         us to map pixel offsets more directly into offsets within the text runs,
53         simplifying a few of the text-fiddling functions (they no longer need to
54         track the current position, as ComplexTextController now does it).
55
56         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
57         (WebCore::ComplexTextController::ComplexTextController):
58         (WebCore::ComplexTextController::reset):
59         (WebCore::ComplexTextController::setGlyphXPositions):
60         * platform/graphics/chromium/ComplexTextControllerLinux.h:
61         (WebCore::ComplexTextController::offsetX):
62         * platform/graphics/chromium/FontLinux.cpp:
63         (WebCore::Font::drawComplexText):
64         (WebCore::Font::floatWidthForComplexText):
65         (WebCore::glyphIndexForXPositionInScriptRun):
66         (WebCore::Font::offsetForPositionForComplexText):
67         (WebCore::Font::selectionRectForComplexText):
68
69 2011-01-19  Pavel Feldman  <pfeldman@chromium.org>
70
71         Reviewed by Yury Semikhatsky.
72
73         Web Inspector: move methods from InjectedScript domain into DOM,
74         Runtime and Debugger domains. Introduce InspectorRuntimeAgent.
75         https://bugs.webkit.org/show_bug.cgi?id=52717
76
77         * CMakeLists.txt:
78         * GNUmakefile.am:
79         * WebCore.gypi:
80         * WebCore.pro:
81         * WebCore.vcproj/WebCore.vcproj:
82         * WebCore.xcodeproj/project.pbxproj:
83         * inspector/CodeGeneratorInspector.pm:
84         * inspector/InjectedScript.cpp:
85         (WebCore::InjectedScript::evaluateOnCallFrame):
86         (WebCore::InjectedScript::getCompletions):
87         (WebCore::InjectedScript::getCompletionsOnCallFrame):
88         * inspector/InjectedScript.h:
89         * inspector/InjectedScriptHost.cpp:
90         (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
91         * inspector/InjectedScriptHost.h:
92         * inspector/InjectedScriptSource.js:
93         (.):
94         ():
95         * inspector/Inspector.idl:
96         * inspector/InspectorController.cpp:
97         (WebCore::InspectorController::connectFrontend):
98         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
99         * inspector/InspectorController.h:
100         * inspector/InspectorDOMAgent.cpp:
101         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
102         (WebCore::InspectorDOMAgent::resolveNode):
103         (WebCore::InspectorDOMAgent::getNodeProperties):
104         (WebCore::InspectorDOMAgent::getNodePrototypes):
105         (WebCore::InspectorDOMAgent::injectedScriptForNodeId):
106         * inspector/InspectorDOMAgent.h:
107         (WebCore::EventListenerInfo::EventListenerInfo):
108         (WebCore::InspectorDOMAgent::DOMListener::~DOMListener):
109         (WebCore::InspectorDOMAgent::create):
110         (WebCore::InspectorDOMAgent::cast):
111         (WebCore::InspectorDOMAgent::documents):
112         * inspector/InspectorDebuggerAgent.cpp:
113         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
114         (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
115         (WebCore::InspectorDebuggerAgent::injectedScriptForCallFrameId):
116         * inspector/InspectorDebuggerAgent.h:
117         * inspector/InspectorRuntimeAgent.cpp: Added.
118         (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
119         (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
120         (WebCore::InspectorRuntimeAgent::evaluate):
121         (WebCore::InspectorRuntimeAgent::getCompletions):
122         (WebCore::InspectorRuntimeAgent::getProperties):
123         (WebCore::InspectorRuntimeAgent::setPropertyValue):
124         (WebCore::InspectorRuntimeAgent::pushNodeToFrontend):
125         (WebCore::InspectorRuntimeAgent::injectedScriptForObjectId):
126         * inspector/InspectorRuntimeAgent.h: Copied from Source/WebCore/inspector/InjectedScript.h.
127         (WebCore::InspectorRuntimeAgent::create):
128         * inspector/front-end/ConsoleView.js:
129         (WebInspector.ConsoleView.prototype.completions):
130         * inspector/front-end/ScriptsPanel.js:
131         (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
132
133 2011-01-18  Pavel Podivilov  <podivilov@chromium.org>
134
135         Reviewed by Yury Semikhatsky.
136
137         Web Inspector: add UglifyJS parser and formatter files
138         https://bugs.webkit.org/show_bug.cgi?id=51702
139
140         * WebCore.gypi:
141         * WebCore.vcproj/WebCore.vcproj:
142         * inspector/front-end/ScriptFormatter.js:
143         (WebInspector.ScriptFormatter.positionToLocation):
144         (WebInspector.ScriptFormatter.prototype.format.messageHandler):
145         (WebInspector.ScriptFormatter.prototype.format):
146         (WebInspector.ScriptFormatter.prototype._buildMapping):
147         (WebInspector.ScriptFormatter.prototype._convertPosition):
148         * inspector/front-end/SourceFrame.js:
149         (WebInspector.SourceFrame.prototype.formatSource.didFormat):
150         (WebInspector.SourceFrame.prototype.formatSource):
151         * inspector/front-end/WebKit.qrc:
152         * inspector/front-end/parse-js.js: Added. UglifyJS parser.
153         * inspector/front-end/process.js: Added. UglifyJS formatter.
154         * inspector/front-end/scriptFormatterWorker.js: Added. Worker script that wraps UglifyJS code.
155         (onmessage):
156         (beautify):
157         (loadModule):
158         (require):
159         * inspector/front-end/utilities.js:
160         ():
161
162 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
163
164         Reviewed by Yury Semikhatsky.
165
166         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
167         https://bugs.webkit.org/show_bug.cgi?id=52721
168
169         Test: inspector/debugger-scripts.html
170
171         * bindings/js/ScriptDebugServer.cpp:
172         (WebCore::ScriptDebugServer::dispatchDidParseSource):
173         (WebCore::ScriptDebugServer::dispatchFailedToParseSource):
174         (WebCore::ScriptDebugServer::sourceParsed):
175         * bindings/js/ScriptDebugServer.h:
176         * bindings/js/ScriptSourceCode.h:
177         (WebCore::ScriptSourceCode::ScriptSourceCode):
178         * bindings/js/StringSourceProvider.h:
179         (WebCore::StringSourceProvider::create):
180         (WebCore::StringSourceProvider::startPosition):
181         (WebCore::StringSourceProvider::StringSourceProvider):
182
183 2011-01-19  Satish Sampath  <satish@chromium.org>
184
185         Reviewed by Jeremy Orlow.
186
187         Send origin/url as part of speech input requests to the embedder.
188         https://bugs.webkit.org/show_bug.cgi?id=52718
189
190         * page/SpeechInput.cpp:
191         (WebCore::SpeechInput::startRecognition): Pass up additional origin parameter.
192         * page/SpeechInput.h:
193         * page/SpeechInputClient.h:
194         * platform/mock/SpeechInputClientMock.cpp:
195         (WebCore::SpeechInputClientMock::startRecognition): Updated prototype.
196         * platform/mock/SpeechInputClientMock.h:
197         * rendering/TextControlInnerElements.cpp:
198         (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Pass the frame origin to speech input request.
199
200 2011-01-19  Hans Wennborg  <hans@chromium.org>
201
202         Reviewed by Jeremy Orlow.
203
204         IndexedDB: Support auto-increment keys
205         https://bugs.webkit.org/show_bug.cgi?id=52576
206
207         Add support for auto-increment keys.
208
209         Test: storage/indexeddb/objectstore-autoincrement.html
210
211         * storage/IDBDatabase.cpp:
212         (WebCore::IDBDatabase::createObjectStore):
213         * storage/IDBObjectStoreBackendImpl.cpp:
214         (WebCore::genAutoIncrementKey):
215         (WebCore::IDBObjectStoreBackendImpl::putInternal):
216
217 2011-01-19  Csaba Osztrogonác  <ossy@webkit.org>
218
219         Reviewed by Laszlo Gombos and Tor Arne Vestbø.
220
221         [Qt] Remove unnecessary "../Source" from paths
222         after moving source files into Source is finished.
223
224         * WebCore.pri:
225         * WebCore.pro:
226
227 2011-01-19  Alexander Pavlov  <apavlov@chromium.org>
228
229         Reviewed by Pavel Feldman.
230
231         Web Inspector: Employ TextPrompt for CSS property name/value autocompletion
232         https://bugs.webkit.org/show_bug.cgi?id=52212
233
234         WebInspector.CSSKeywordCompletions contains a hand-written list of accepted CSS property value keywords
235         for each property. WebInspector.TextPrompt is used to suggest both the name and value keywords while
236         editing styles, in place of the old custom suggestion code.
237
238         * inspector/front-end/CSSCompletions.js:
239         (WebInspector.CSSCompletions.prototype.startsWith): Fix array-out-of-bounds error.
240         * inspector/front-end/CSSKeywordCompletions.js: Added.
241         (WebInspector.CSSKeywordCompletions.forProperty):
242         * inspector/front-end/StylesSidebarPane.js:
243         (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
244         (WebInspector.StylePropertyTreeElement.prototype):
245         ():
246         * inspector/front-end/TextPrompt.js:
247         (WebInspector.TextPrompt):
248         (WebInspector.TextPrompt.prototype.removeFromElement):
249         (WebInspector.TextPrompt.prototype._onKeyDown):
250         (WebInspector.TextPrompt.prototype.tabKeyPressed):
251         (WebInspector.TextPrompt.prototype.upKeyPressed):
252         (WebInspector.TextPrompt.prototype.downKeyPressed):
253         (WebInspector.TextPrompt.prototype._moveBackInHistory):
254         (WebInspector.TextPrompt.prototype._moveForwardInHistory):
255         * inspector/front-end/inspector.css:
256         (.auto-complete-text, .editing .auto-complete-text):
257         * inspector/front-end/inspector.html:
258
259 2011-01-19  Dai Mikurube  <dmikurube@google.com>
260
261         Reviewed by Kent Tamura.
262
263         Implement onformchange and onforminput event handlers
264         https://bugs.webkit.org/show_bug.cgi?id=26141
265
266         Tests: fast/forms/formchange-event.html
267                fast/forms/forminput-event.html
268
269         * bindings/scripts/CodeGeneratorGObject.pm: Added event names.
270         * dom/Document.h: Added event definitions.
271         * dom/Document.idl: Added event definitions.
272         * dom/Element.h: Added event definitions.
273         * dom/Element.idl: Added event definitions.
274         * dom/Event.cpp:
275         (WebCore::Event::fromUserGesture): Added a condition for a formchange event in handling user gestures.
276         * dom/EventNames.h: Added event definitions.
277         * dom/InputElement.cpp:
278         (WebCore::InputElement::setValueFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents(), a virtual function which broadcasts forminput events for HTML elements.
279         * dom/Node.cpp:
280         (WebCore::Node::dispatchInputEvents): Defined basic dispatchInputEvents() described above.
281         (WebCore::Node::dispatchChangeEvents): Defined basic dispatchChangeEvents() described above.
282         (WebCore::Node::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().
283         * dom/Node.h:
284         * html/FormAssociatedElement.h: Added isResettable() to check the element is resettable or not.
285         * html/HTMLAttributeNames.in: Added event names.
286         * html/HTMLElement.cpp:
287         (WebCore::HTMLElement::parseMappedAttribute): Added event handling.
288         (WebCore::HTMLElement::shadowAncestorOwnerForm): Added to get an ancestor <form> element from a shadow element.
289         (WebCore::HTMLElement::dispatchChangeEvents): Defined dispatchChangeEvents() for HTML elements described above.
290         (WebCore::HTMLElement::dispatchInputEvents): Defined dispatchInputEvents() for HTML elements described above.
291         * html/HTMLElement.h:
292         * html/HTMLFormControlElement.cpp:
293         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Added calling dispatchFormChange() to broadcast formchange events.
294         (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Defined newly to dispatch an input event with broadcasting forminput events.
295         * html/HTMLFormControlElement.h: Added isResettable().
296         * html/HTMLFormElement.cpp:
297         (WebCore::HTMLFormElement::broadcastFormEvent): Added to broadcast forminput or formchange events.
298         (WebCore::HTMLFormElement::dispatchFormInput): Defined newly to broadcast forminput events.
299         (WebCore::HTMLFormElement::dispatchFormChange): Defined newly to broadcast formchange events.
300         * html/HTMLFormElement.h:
301         * html/HTMLFormElement.idl: Added dispatchFormInput() and dispatchFormChange() DOM API definitions.
302         * html/HTMLInputElement.cpp:
303         (WebCore::HTMLInputElement::stepUpFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents().
304         * html/HTMLInputElement.h: Added isResettable().
305         * html/HTMLKeygenElement.h: Added isResettable().
306         * html/HTMLObjectElement.h: Added isResettable().
307         * html/HTMLOutputElement.h: Added isResettable().
308         * html/HTMLSelectElement.h: Added isResettable().
309         * html/HTMLTextAreaElement.h: Added isResettable().
310         * page/DOMWindow.h: Added event definitions.
311         * page/DOMWindow.idl: Added event definitions.
312         * rendering/TextControlInnerElements.cpp:
313         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().
314
315 2011-01-19  Andrey Kosyakov  <caseq@chromium.org>
316
317         Reviewed by Pavel Feldman.
318
319         Web Inspector: [Extensions API] delete pending callback from callback map before invoking it
320         https://bugs.webkit.org/show_bug.cgi?id=52707
321
322         * inspector/front-end/ExtensionAPI.js:
323         (WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback):
324
325 2011-01-19  Levi Weintraub  <leviw@google.com>
326
327         Reviewed by Ryosuke Niwa.
328
329         Replaced rangeCompliantEquivalent with Position::parentAnchoredEquivalent
330         and simplified the logic a bit. Unfortunately, Tables and some legacy
331         editing positions still need to be handled specifically.
332
333         remove rangeCompliantEquivalent and replace it with Position methods
334         https://bugs.webkit.org/show_bug.cgi?id=25057
335
336         No new tests as this is a refactor that doesn't change behavior.
337
338         * WebCore.exp.in:
339         * dom/Document.cpp:
340         (WebCore::Document::caretRangeFromPoint):
341         * dom/Position.cpp:
342         (WebCore::Position::parentAnchoredEquivalent):
343         * dom/Position.h:
344         * editing/ApplyStyleCommand.cpp:
345         (WebCore::ApplyStyleCommand::applyBlockStyle):
346         * editing/CompositeEditCommand.cpp:
347         (WebCore::CompositeEditCommand::insertNodeAt):
348         (WebCore::CompositeEditCommand::moveParagraphs):
349         * editing/DeleteSelectionCommand.cpp:
350         (WebCore::DeleteSelectionCommand::initializePositionData):
351         (WebCore::DeleteSelectionCommand::mergeParagraphs):
352         * editing/Editor.cpp:
353         (WebCore::Editor::textDirectionForSelection):
354         (WebCore::Editor::advanceToNextMisspelling):
355         * editing/InsertLineBreakCommand.cpp:
356         (WebCore::InsertLineBreakCommand::shouldUseBreakElement):
357         * editing/InsertParagraphSeparatorCommand.cpp:
358         (WebCore::InsertParagraphSeparatorCommand::doApply):
359         * editing/ReplaceSelectionCommand.cpp:
360         (WebCore::handleStyleSpansBeforeInsertion):
361         * editing/VisiblePosition.cpp:
362         (WebCore::makeRange):
363         (WebCore::setStart):
364         (WebCore::setEnd):
365         * editing/VisibleSelection.cpp:
366         (WebCore::VisibleSelection::firstRange):
367         (WebCore::VisibleSelection::toNormalizedRange):
368         (WebCore::makeSearchRange):
369         * editing/htmlediting.cpp:
370         (WebCore::indexForVisiblePosition):
371         * editing/htmlediting.h:
372         * editing/visible_units.cpp:
373         (WebCore::previousBoundary):
374         (WebCore::nextBoundary):
375         * page/DOMSelection.cpp:
376         (WebCore::anchorPosition):
377         (WebCore::focusPosition):
378         (WebCore::basePosition):
379         (WebCore::extentPosition):
380
381 2011-01-19  Peter Rybin  <peter.rybin@gmail.com>
382
383         Reviewed by Yury Semikhatsky.
384
385         Web Inspector: script column offset is incorrect
386         https://bugs.webkit.org/show_bug.cgi?id=52580
387
388         Column is updated in 3 places, 2 less probable places contained error.
389         Fixed now.
390
391         * platform/text/SegmentedString.cpp:
392         (WebCore::SegmentedString::advanceSlowCase):
393         * platform/text/SegmentedString.h:
394         (WebCore::SegmentedString::advancePastNewline):
395
396 2011-01-18  Pavel Feldman  <pfeldman@chromium.org>
397
398         Reviewed by Yury Semikhatsky.
399
400         Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
401         https://bugs.webkit.org/show_bug.cgi?id=52652
402
403         Calls served by the InjectedScript should be first class protocol
404         citizens, not dispatched via single protocol message.
405
406         * WebCore.gypi:
407         * WebCore.vcproj/WebCore.vcproj:
408         * inspector/CodeGeneratorInspector.pm:
409         * inspector/InjectedScript.cpp:
410         (WebCore::InjectedScript::evaluate):
411         (WebCore::InjectedScript::evaluateInCallFrame):
412         (WebCore::InjectedScript::evaluateOnSelf):
413         (WebCore::InjectedScript::getCompletions):
414         (WebCore::InjectedScript::getProperties):
415         (WebCore::InjectedScript::pushNodeToFrontend):
416         (WebCore::InjectedScript::resolveNode):
417         (WebCore::InjectedScript::getNodeProperties):
418         (WebCore::InjectedScript::getNodePrototypes):
419         (WebCore::InjectedScript::setPropertyValue):
420         (WebCore::InjectedScript::makeCall):
421         * inspector/InjectedScript.h:
422         * inspector/InjectedScriptHost.cpp:
423         (WebCore::InjectedScriptHost::evaluate):
424         (WebCore::InjectedScriptHost::evaluateInCallFrame):
425         (WebCore::InjectedScriptHost::evaluateOnSelf):
426         (WebCore::InjectedScriptHost::getCompletions):
427         (WebCore::InjectedScriptHost::getProperties):
428         (WebCore::InjectedScriptHost::pushNodeToFrontend):
429         (WebCore::InjectedScriptHost::resolveNode):
430         (WebCore::InjectedScriptHost::getNodeProperties):
431         (WebCore::InjectedScriptHost::getNodePrototypes):
432         (WebCore::InjectedScriptHost::setPropertyValue):
433         (WebCore::InjectedScriptHost::injectedScriptForObjectId):
434         (WebCore::InjectedScriptHost::injectedScriptForNodeId):
435         (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
436         * inspector/InjectedScriptHost.h:
437         * inspector/InjectedScriptSource.js:
438         (.):
439         * inspector/Inspector.idl:
440         * inspector/InspectorController.cpp:
441         * inspector/InspectorController.h:
442         * inspector/InspectorValues.cpp:
443         (WebCore::InspectorObject::getNumber):
444         * inspector/InspectorValues.h:
445         * inspector/front-end/AuditRules.js:
446         (WebInspector.AuditRules.evaluateInTargetWindow):
447         * inspector/front-end/ConsoleView.js:
448         (WebInspector.ConsoleView.prototype.completions):
449         (WebInspector.ConsoleView.prototype.doEvalInWindow):
450         * inspector/front-end/ElementsTreeOutline.js:
451         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
452         * inspector/front-end/ExtensionPanel.js:
453         (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
454         * inspector/front-end/ExtensionServer.js:
455         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
456         * inspector/front-end/InjectedScriptAccess.js: Removed.
457         * inspector/front-end/PropertiesSidebarPane.js:
458         (WebInspector.PropertiesSidebarPane.prototype.update.callback):
459         (WebInspector.PropertiesSidebarPane.prototype.update):
460         * inspector/front-end/RemoteObject.js:
461         (WebInspector.RemoteObject.resolveNode):
462         (WebInspector.RemoteObject.prototype.getProperties):
463         (WebInspector.RemoteObject.prototype.setPropertyValue):
464         (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
465         * inspector/front-end/ScriptsPanel.js:
466         (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
467         * inspector/front-end/WebKit.qrc:
468         * inspector/front-end/inspector.html:
469
470 2011-01-18  Anton Muhin  <antonm@chromium.org>
471
472         Reviewed by Adam Barth.
473
474         [v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only a value type stored in the DOM map
475         https://bugs.webkit.org/show_bug.cgi?id=51683
476
477         Covered by the existing tests.
478
479         * bindings/v8/DOMDataStore.cpp:
480         (WebCore::DOMDataStore::weakNodeCallback):
481         (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
482         * bindings/v8/DOMDataStore.h:
483         * bindings/v8/V8DOMMap.h:
484         (WebCore::WeakReferenceMap::removeIfPresent):
485
486 2011-01-18 MORITA Hajime  <morrita@google.com>
487
488         Reviewed by Ryosuke Niwa.
489         
490         Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of bools.
491         https://bugs.webkit.org/show_bug.cgi?id=52608
492
493         No new tests. no behavioral change.
494
495         * GNUmakefile.am:
496         * WebCore.gypi:
497         * WebCore.pro:
498         * WebCore.vcproj/WebCore.vcproj:
499         * WebCore.xcodeproj/project.pbxproj:
500         * dom/TextEvent.cpp:
501         (WebCore::TextEvent::create):
502         (WebCore::TextEvent::createForDrop):
503         (WebCore::TextEvent::TextEvent):
504         * dom/TextEvent.h:
505         (WebCore::TextEvent::isLineBreak):
506         (WebCore::TextEvent::isBackTab):
507         (WebCore::TextEvent::isPaste):
508         (WebCore::TextEvent::isDrop):
509         * dom/TextEventInputType.h: Added. Extracted from TextEvent::TextInputType.
510         * editing/EditorCommand.cpp:
511         (WebCore::executeInsertBacktab):
512         (WebCore::executeInsertLineBreak):
513         (WebCore::executeInsertNewline):
514         (WebCore::executeInsertTab):
515         * page/EventHandler.cpp:
516         (WebCore::EventHandler::handleTextInputEvent):
517         * page/EventHandler.h:
518
519 2011-01-18  Ben Vanik  <ben.vanik@gmail.com>
520
521         Reviewed by Kenneth Russell.
522
523         Updating ANGLE in WebKit to r533.
524         https://bugs.webkit.org/show_bug.cgi?id=47194
525
526         * platform/graphics/ANGLEWebKitBridge.cpp:
527         (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
528         (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge):
529         (WebCore::ANGLEWebKitBridge::validateShaderSource):
530         Update to new ANGLE API for shader validation.
531         * platform/graphics/ANGLEWebKitBridge.h:
532         (WebCore::ANGLEWebKitBridge::setResources): 
533         Renaming types to new names.
534         * platform/graphics/mac/GraphicsContext3DMac.mm:
535         (WebCore::GraphicsContext3D::GraphicsContext3D):
536         Initialize ANGLEResources with ANGLE init call to prevent uninitialized variables.
537
538 2011-01-18  MORITA Hajime  <morrita@google.com>
539
540         Reviewed by Simon Fraser.
541
542         Refactoring: Extract RoundedIntRect class
543         https://bugs.webkit.org/show_bug.cgi?id=51664
544
545         RoundedIntRect is a pair of rect and four IntSize objects which represent
546         corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
547         Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
548         return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
549         and other functions accept RoundedIntRect as an argument.
550
551         * Android.mk:
552         * CMakeLists.txt:
553         * GNUmakefile.am:
554         * WebCore.gypi:
555         * WebCore.pro:
556         * WebCore.vcproj/WebCore.vcproj:
557         * WebCore.xcodeproj/project.pbxproj:
558         * platform/graphics/GraphicsContext.cpp:
559         (WebCore::GraphicsContext::addRoundedRectClip):
560         (WebCore::GraphicsContext::clipOutRoundedRect):
561         (WebCore::GraphicsContext::fillRoundedRect):
562         * platform/graphics/GraphicsContext.h:
563         * platform/graphics/RoundedIntRect.cpp: Added.
564         (WebCore::RoundedIntRect::Radii::isZero):
565         (WebCore::RoundedIntRect::Radii::scale):
566         (WebCore::RoundedIntRect::Radii::expand):
567         (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
568         (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
569         (WebCore::RoundedIntRect::RoundedIntRect):
570         (WebCore::RoundedIntRect::includeLogicalEdges):
571         (WebCore::RoundedIntRect::excludeLogicalEdges):
572         * platform/graphics/RoundedIntRect.h: Added.
573         (WebCore::RoundedIntRect::Radii::Radii):
574         (WebCore::RoundedIntRect::Radii::setTopLeft):
575         (WebCore::RoundedIntRect::Radii::setTopRight):
576         (WebCore::RoundedIntRect::Radii::setBottomLeft):
577         (WebCore::RoundedIntRect::Radii::setBottomRight):
578         (WebCore::RoundedIntRect::Radii::topLeft):
579         (WebCore::RoundedIntRect::Radii::topRight):
580         (WebCore::RoundedIntRect::Radii::bottomLeft):
581         (WebCore::RoundedIntRect::Radii::bottomRight):
582         (WebCore::RoundedIntRect::Radii::expand):
583         (WebCore::RoundedIntRect::Radii::shrink):
584         (WebCore::RoundedIntRect::rect):
585         (WebCore::RoundedIntRect::radii):
586         (WebCore::RoundedIntRect::isRounded):
587         (WebCore::RoundedIntRect::isEmpty):
588         (WebCore::RoundedIntRect::setRect):
589         (WebCore::RoundedIntRect::setRadii):
590         (WebCore::RoundedIntRect::move):
591         (WebCore::RoundedIntRect::inflate):
592         (WebCore::RoundedIntRect::inflateWithRadii):
593         (WebCore::RoundedIntRect::expandRadii):
594         (WebCore::RoundedIntRect::shrinkRadii):
595         * rendering/RenderBox.cpp:
596         (WebCore::RenderBox::pushContentsClip):
597         * rendering/RenderBoxModelObject.cpp:
598         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
599         (WebCore::RenderBoxModelObject::paintBorder):
600         (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
601         (WebCore::RenderBoxModelObject::paintBoxShadow):
602         * rendering/RenderBoxModelObject.h:
603         * rendering/RenderObject.cpp:
604         (WebCore::RenderObject::drawBoxSideFromPath):
605         * rendering/RenderReplaced.cpp:
606         (WebCore::RenderReplaced::paint):
607         * rendering/RenderThemeChromiumWin.cpp:
608         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
609         * rendering/RenderThemeMac.mm:
610         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
611         (WebCore::RenderThemeMac::paintSliderTrack):
612         * rendering/RenderThemeSafari.cpp:
613         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
614         (WebCore::RenderThemeSafari::paintSliderTrack):
615         * rendering/RenderThemeWinCE.cpp:
616         (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
617         * rendering/RenderWidget.cpp:
618         (WebCore::RenderWidget::paint):
619         * rendering/style/BorderData.h:
620         * rendering/style/RenderStyle.cpp:
621         (WebCore::calcRadiiFor):
622         (WebCore::calcConstraintScaleFor):
623         (WebCore::RenderStyle::getRoundedBorderFor):
624         (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
625         * rendering/style/RenderStyle.h:
626         (WebCore::InheritedFlags::setBorderRadius):
627
628 2011-01-18  MORITA Hajime  <morrita@google.com>
629
630         Reviewed by Simon Fraser.
631
632         Refactoring: Extract RoundedIntRect class
633         https://bugs.webkit.org/show_bug.cgi?id=51664
634
635         RoundedIntRect is a pair of rect and four IntSize objects which represent
636         corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
637         Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
638         return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
639         and other functions accept RoundedIntRect as an argument.
640
641         No new tests. No behavioral change.
642
643         * Android.mk:
644         * CMakeLists.txt:
645         * WebCore.gypi:
646         * WebCore.pro:
647         * WebCore.xcodeproj/project.pbxproj:
648         * platform/graphics/GraphicsContext.cpp:
649         (WebCore::GraphicsContext::addRoundedRectClip):
650         (WebCore::GraphicsContext::clipOutRoundedRect):
651         (WebCore::GraphicsContext::fillRoundedRect):
652         * platform/graphics/GraphicsContext.h:
653         * platform/graphics/RoundedIntRect.cpp: Added.
654         (WebCore::RoundedIntRect::Radii::isZero):
655         (WebCore::RoundedIntRect::Radii::scale):
656         (WebCore::RoundedIntRect::Radii::expand):
657         (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
658         (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
659         (WebCore::RoundedIntRect::RoundedIntRect):
660         (WebCore::RoundedIntRect::includeLogicalEdges):
661         (WebCore::RoundedIntRect::excludeLogicalEdges):
662         * platform/graphics/RoundedIntRect.h: Added.
663         (WebCore::RoundedIntRect::Radii::Radii):
664         (WebCore::RoundedIntRect::Radii::setTopLeft):
665         (WebCore::RoundedIntRect::Radii::setTopRight):
666         (WebCore::RoundedIntRect::Radii::setBottomLeft):
667         (WebCore::RoundedIntRect::Radii::setBottomRight):
668         (WebCore::RoundedIntRect::Radii::topLeft):
669         (WebCore::RoundedIntRect::Radii::topRight):
670         (WebCore::RoundedIntRect::Radii::bottomLeft):
671         (WebCore::RoundedIntRect::Radii::bottomRight):
672         (WebCore::RoundedIntRect::Radii::expand):
673         (WebCore::RoundedIntRect::Radii::shrink):
674         (WebCore::RoundedIntRect::rect):
675         (WebCore::RoundedIntRect::radii):
676         (WebCore::RoundedIntRect::isRounded):
677         (WebCore::RoundedIntRect::isEmpty):
678         (WebCore::RoundedIntRect::setRect):
679         (WebCore::RoundedIntRect::setRadii):
680         (WebCore::RoundedIntRect::move):
681         (WebCore::RoundedIntRect::inflate):
682         (WebCore::RoundedIntRect::inflateWithRadii):
683         (WebCore::RoundedIntRect::expandRadii):
684         (WebCore::RoundedIntRect::shrinkRadii):
685         * rendering/RenderBox.cpp:
686         (WebCore::RenderBox::pushContentsClip):
687         * rendering/RenderBoxModelObject.cpp:
688         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
689         (WebCore::RenderBoxModelObject::paintBorder):
690         (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
691         (WebCore::RenderBoxModelObject::paintBoxShadow):
692         * rendering/RenderBoxModelObject.h:
693         * rendering/RenderObject.cpp:
694         (WebCore::RenderObject::drawBoxSideFromPath):
695         * rendering/RenderReplaced.cpp:
696         (WebCore::RenderReplaced::paint):
697         * rendering/RenderThemeChromiumWin.cpp:
698         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
699         * rendering/RenderThemeMac.mm:
700         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
701         (WebCore::RenderThemeMac::paintSliderTrack):
702         * rendering/RenderThemeSafari.cpp:
703         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
704         (WebCore::RenderThemeSafari::paintSliderTrack):
705         * rendering/RenderThemeWinCE.cpp:
706         (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
707         * rendering/RenderWidget.cpp:
708         (WebCore::RenderWidget::paint):
709         * rendering/style/BorderData.h:
710         * rendering/style/RenderStyle.cpp:
711         (WebCore::calcRadiiFor):
712         (WebCore::calcConstraintScaleFor):
713         (WebCore::RenderStyle::getRoundedBorderFor):
714         (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
715         * rendering/style/RenderStyle.h:
716         (WebCore::InheritedFlags::setBorderRadius):
717
718 2011-01-18  Victoria Kirst  <vrk@chromium.org>
719
720         Reviewed by Kenneth Russell.
721
722         [chromium] Adding support for YV16 video frame formats.
723         https://bugs.webkit.org/show_bug.cgi?id=52345
724
725         * platform/graphics/chromium/VideoLayerChromium.cpp:
726         (WebCore::VideoLayerChromium::determineTextureFormat):
727         (WebCore::VideoLayerChromium::draw):
728
729 2011-01-18  David Hyatt  <hyatt@apple.com>
730
731         Reviewed by Dan Bernstein.
732
733         <rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com
734         
735         Exclude floating objects from shrinking to avoid floats.  They should never do this.  Timing-related bugs could
736         occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they
737         got encountered on the correct line exposed this issue.
738
739         Added /fast/block/float/float-overflow-hidden-containing-block-width.html.
740
741         * rendering/RenderBox.cpp:
742         (WebCore::RenderBox::shrinkToAvoidFloats):
743
744 2011-01-18  Zhenyao Mo  <zmo@google.com>
745
746         Reviewed by Kenneth Russell.
747
748         Make CheckedInt<long> and CheckedInt<unsigned long> work
749         https://bugs.webkit.org/show_bug.cgi?id=52401
750
751         * html/canvas/CheckedInt.h:
752         (WebCore::CheckedInt::CheckedInt): Merge with the patch provided by Benoit Jacob.
753         * html/canvas/WebGLBuffer.cpp:
754         (WebCore::WebGLBuffer::associateBufferDataImpl): Use CheckedInt<long> instead of CheckedInt<int>.
755         (WebCore::WebGLBuffer::associateBufferSubDataImpl): Ditto.
756
757 2011-01-18  Kenneth Russell  <kbr@google.com>
758
759         Reviewed by David Levin.
760
761         Must strip comments from WebGL shaders before enforcing character set
762         https://bugs.webkit.org/show_bug.cgi?id=52390
763
764         Strip comments from incoming shaders, preserving line numbers,
765         before validating that they conform to the ESSL character set.
766         Revert changes from http://trac.webkit.org/changeset/75735 which
767         allowed invalid characters to be passed to certain APIs.
768
769         Tested with WebGL layout tests, conformance test suite and several
770         WebGL demos in both Safari and Chromium.
771
772         * html/canvas/WebGLRenderingContext.cpp:
773         (WebCore::StripComments::StripComments::process):
774         (WebCore::WebGLRenderingContext::shaderSource):
775
776 2011-01-18  Ryosuke Niwa  <rniwa@webkit.org>
777
778         Reviewed by Eric Seidel.
779
780         Stop instantiating legacy editing positions in DeleteSelectionCommand, IndentOudentCommand,
781         InsertLineBreakCommand, InsertListCOmmand.cpp, InsertParagraphSeparatorCommand, and htmlediting.cpp
782         https://bugs.webkit.org/show_bug.cgi?id=52644
783
784         This is a cleanup to stop instantiating legacy editing positions in the following tests.
785         firstDeepEditingPositionForNode and lastDeepEditingPositionForNode in htmlediting.h are not updated
786         because doing so requires significant code changes. They are tracked on the bug 52642.
787
788         * editing/DeleteSelectionCommand.cpp:
789         (WebCore::DeleteSelectionCommand::initializeStartEnd):
790         (WebCore::updatePositionForNodeRemoval):
791         (WebCore::DeleteSelectionCommand::removeNode):
792         (WebCore::updatePositionForTextRemoval):
793         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
794         * editing/IndentOutdentCommand.cpp:
795         (WebCore::IndentOutdentCommand::outdentParagraph):
796         * editing/InsertLineBreakCommand.cpp:
797         (WebCore::InsertLineBreakCommand::doApply):
798         * editing/InsertListCommand.cpp:
799         (WebCore::InsertListCommand::doApplyForSingleParagraph):
800         (WebCore::InsertListCommand::unlistifyParagraph):
801         (WebCore::InsertListCommand::listifyParagraph):
802         * editing/InsertParagraphSeparatorCommand.cpp:
803         (WebCore::InsertParagraphSeparatorCommand::doApply):
804         * editing/htmlediting.cpp:
805         (WebCore::enclosingBlock):
806         (WebCore::enclosingList):
807         (WebCore::enclosingListChild):
808         (WebCore::indexForVisiblePosition):
809         (WebCore::isNodeVisiblyContainedWithin):
810         (WebCore::avoidIntersectionWithNode):
811
812 2011-01-18  Benjamin Kalman  <kalman@chromium.org>
813
814         Reviewed by Ryosuke Niwa.
815
816         Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch
817         https://bugs.webkit.org/show_bug.cgi?id=52610
818
819         This is a purely aesthetic change.
820
821         * editing/TextIterator.cpp:
822         (WebCore::SimplifiedBackwardsTextIterator::advance):
823         * editing/visible_units.cpp:
824         (WebCore::previousBoundary):
825
826 2011-01-18  Adam Klein  <adamk@chromium.org>
827
828         Reviewed by Darin Fisher.
829
830         [Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
831         https://bugs.webkit.org/show_bug.cgi?id=42236
832
833         * platform/chromium/ChromiumBridge.h:
834         * platform/chromium/WidgetChromium.cpp:
835         (WebCore::Widget::setCursor):
836
837 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
838
839         Reviewed by Darin Adler.
840
841         REGRESSION: A problem with Voiceover and finding links
842         https://bugs.webkit.org/show_bug.cgi?id=52324
843
844         Fallout from recent change to make WebCore return its own scroll view.
845            1) There were two scroll views in the hierarchy, one which no needed to be ignored.
846            2) Hit tests for sub frames needed to be offset.
847            3) The check for whether an attachment is ignored must happen earlier than using
848               the helpText to determine if an element should be ignored.
849
850         Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html
851
852         * accessibility/AccessibilityObject.cpp:
853         (WebCore::AccessibilityObject::elementAccessibilityHitTest):
854         * accessibility/AccessibilityRenderObject.cpp:
855         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
856         * accessibility/mac/AccessibilityObjectWrapper.mm:
857         (-[AccessibilityObjectWrapper scrollViewParent]):
858
859 2011-01-18  Adam Roben  <aroben@apple.com>
860
861         Call alternate CFHTTPCookie functions if available
862
863         Fixes <http://webkit.org/b/52637> <rdar://problem/8878984>.
864
865         Reviewed by Darin Adler.
866
867         * platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to
868         pull in the alternate CFHTTPCookie functions.
869
870         (WebCore::cookieDomain):
871         (WebCore::cookieExpirationTime):
872         (WebCore::cookieName):
873         (WebCore::cookiePath):
874         (WebCore::cookieValue):
875         Added these wrappers around the CFHTTPCookie functions. We call the
876         alternate functions if they exist, otherwise fall back to the current
877         functions.
878
879         (WebCore::filterCookies):
880         (WebCore::getRawCookies):
881         (WebCore::deleteCookie):
882         Changed to use the wrapper functions.
883
884 2011-01-18  Martin Robinson  <mrobinson@igalia.com>
885
886         Reviewed by Eric Seidel.
887
888         [GTK] Filenames are converted to URLs during edit drags
889         https://bugs.webkit.org/show_bug.cgi?id=52096
890
891         * platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the
892         conversion policy allows it.
893         (WebCore::DragData::containsURL): Ditto.
894         (WebCore::DragData::asURL): Ditto.
895
896 2011-01-18  Helder Correia  <helder@sencha.com>
897
898         Reviewed by Kenneth Rohde Christiansen.
899
900         [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
901         https://bugs.webkit.org/show_bug.cgi?id=52611
902
903         This is related to bug 52559. The shadow color alpha must be multiplied
904         by the context brush alpha.
905
906         Test: fast/canvas/canvas-fillPath-alpha-shadow.html
907
908         * platform/graphics/qt/GraphicsContextQt.cpp:
909         (WebCore::GraphicsContext::fillPath):
910
911 2011-01-18  Andrey Kosyakov  <caseq@chromium.org>
912
913         Reviewed by Yury Semikhatsky.
914
915         Web Inspector: fail resource.requestContent() immediately for WebSocket resources
916         https://bugs.webkit.org/show_bug.cgi?id=52628
917
918         * English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
919         * inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete)
920         (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
921         * inspector/front-end/Resource.js:
922         (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used.
923         (WebInspector.Resource.Type.toString): ditto.
924         (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
925         * inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
926
927 2011-01-18  Helder Correia  <helder@sencha.com>
928
929         Reviewed by Dirk Schulze.
930
931         REGRESSION(75139): SVG gradients are not applied to texts
932         https://bugs.webkit.org/show_bug.cgi?id=52531
933
934         r75139 caused a problem with filling and stroking text with a gradient
935         fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
936         was mixed up.
937
938         Test: svg/css/text-gradient-shadow.svg
939
940         * platform/graphics/cg/GraphicsContextCG.cpp:
941         (WebCore::GraphicsContext::fillRect):
942
943 2011-01-18  Leo Yang  <leo.yang@torchmobile.com.cn>
944
945         Reviewed by Nikolas Zimmermann.
946
947         Unable to indirectly animate visibility of SVGUseElement
948         https://bugs.webkit.org/show_bug.cgi?id=50240
949
950         SVGUseElement::recalcStyle should take care of its shadow
951         tree's style recalculation when it is called with change >= Inherit
952         or when childNeedsStyleRecalc() is true because in these two
953         cases needStyleRecalc() may not be true.
954
955         Test: svg/custom/use-inherit-style.svg
956
957         * svg/SVGUseElement.cpp:
958         (WebCore::SVGUseElement::recalcStyle):
959
960 2011-01-18  Pavel Podivilov  <podivilov@chromium.org>
961
962         Reviewed by Yury Semikhatsky.
963
964         Web Inspector: provide script length to frontend.
965         https://bugs.webkit.org/show_bug.cgi?id=52620
966
967         * inspector/Inspector.idl:
968         * inspector/InspectorDebuggerAgent.cpp:
969         (WebCore::InspectorDebuggerAgent::didParseSource):
970         * inspector/front-end/DebuggerModel.js:
971         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
972         (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
973         * inspector/front-end/Script.js:
974         (WebInspector.Script):
975
976 2011-01-18  Zoltan Herczeg  <zherczeg@webkit.org>
977
978         Rubber-stamped by Csaba Osztrogonác
979
980         Fixing ChangeLog
981
982         Removing a line introduced by
983         http://trac.webkit.org/changeset/75743/trunk/Source/WebCore/ChangeLog
984         Removing an unnecessary space before a time stamp.
985
986 2011-01-17  Andrey Kosyakov  <caseq@chromium.org>
987
988         Reviewed by Yury Semikhatsky.
989
990         Web Inspector: [refactoring] use events to notify NetworkManager clients
991         https://bugs.webkit.org/show_bug.cgi?id=52588
992
993         * inspector/front-end/AuditLauncherView.js:
994         (WebInspector.AuditLauncherView): Do not expose public interface to resource count. Do not reset resource count upon reset().
995         (WebInspector.AuditLauncherView.prototype._resetResourceCount):
996         (WebInspector.AuditLauncherView.prototype._onResourceStarted):
997         (WebInspector.AuditLauncherView.prototype._onResourceFinished):
998         * inspector/front-end/AuditsPanel.js: Do not expose public interface to resource start/finish events.
999         * inspector/front-end/ExtensionServer.js:
1000         (WebInspector.ExtensionServer):
1001         (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
1002         (WebInspector.ExtensionServer.prototype.initExtensions):
1003         * inspector/front-end/NetworkManager.js: Dispatch events rather than directly call clients.
1004         (WebInspector.NetworkManager):
1005         (WebInspector.NetworkManager.prototype.willSendRequest):
1006         (WebInspector.NetworkManager.prototype.markResourceAsCached):
1007         (WebInspector.NetworkManager.prototype.didReceiveResponse):
1008         (WebInspector.NetworkManager.prototype.didReceiveContentLength):
1009         (WebInspector.NetworkManager.prototype.setInitialContent):
1010         (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
1011         (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
1012         (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
1013         (WebInspector.NetworkManager.prototype._startResource):
1014         (WebInspector.NetworkManager.prototype._finishResource):
1015         * inspector/front-end/NetworkPanel.js:
1016         (WebInspector.NetworkPanel):
1017         (WebInspector.NetworkPanel.prototype._onResourceStarted):
1018         (WebInspector.NetworkPanel.prototype._appendResource):
1019         (WebInspector.NetworkPanel.prototype._onResourceUpdated):
1020         (WebInspector.NetworkPanel.prototype._refreshResource):
1021         (WebInspector.NetworkPanel.prototype._onMainResourceChanged):
1022         * inspector/front-end/ResourcesPanel.js:
1023         (WebInspector.ResourcesPanel):
1024         (WebInspector.ResourcesPanel.prototype._refreshResource):
1025
1026 2011-01-18  Pavel Feldman  <pfeldman@chromium.org>
1027
1028         Reviewed by Yury Semikhatsky.
1029
1030         Web Inspector: preserve pause on exception state in settings.
1031         https://bugs.webkit.org/show_bug.cgi?id=52619
1032
1033         * inspector/InspectorController.cpp:
1034         (WebCore::InspectorController::getInspectorState):
1035         * inspector/InspectorDebuggerAgent.cpp:
1036         (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
1037         * inspector/InspectorDebuggerAgent.h:
1038         * inspector/front-end/ScriptsPanel.js:
1039         (WebInspector.ScriptsPanel):
1040         (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
1041         (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState):
1042         (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
1043         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1044         * inspector/front-end/Settings.js:
1045         (WebInspector.Settings):
1046         * inspector/front-end/inspector.js:
1047         (WebInspector.doLoadedDone.populateInspectorState):
1048
1049 2011-01-18  Pavel Podivilov  <podivilov@chromium.org>
1050
1051         Reviewed by Yury Semikhatsky.
1052
1053         Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
1054         https://bugs.webkit.org/show_bug.cgi?id=52623
1055
1056         * inspector/front-end/ConsoleView.js:
1057         (WebInspector.ConsoleMessage):
1058         (WebInspector.ConsoleMessage.prototype._formatMessage):
1059
1060 2011-01-18  Pavel Feldman  <pfeldman@chromium.org>
1061
1062         Revert r76017. No need to guard InspectorInstrumentation:: in WebCore.
1063
1064         * page/Page.cpp:
1065         (WebCore::networkStateChanged):
1066
1067 2011-01-18  Konstantin Tokarev  <annulen@yandex.ru>
1068
1069         Reviewed by Kent Tamura.
1070
1071         Fixed compilation when Inspector is disabled
1072         https://bugs.webkit.org/show_bug.cgi?id=52564
1073
1074         * page/Page.cpp:
1075         (WebCore::networkStateChanged): Added ENABLE(INSPECTOR) guard
1076
1077 2011-01-18  MORITA Hajime  <morrita@google.com>
1078
1079         Unreviewed, rolling out r76004, r76005, r76007, and r76011.
1080         http://trac.webkit.org/changeset/76004
1081         http://trac.webkit.org/changeset/76005
1082         http://trac.webkit.org/changeset/76007
1083         http://trac.webkit.org/changeset/76011
1084         https://bugs.webkit.org/show_bug.cgi?id=51664
1085
1086         The r76004 broke pixel tests.
1087         (The failure was missed due to the tolerance.)
1088
1089         * Android.mk:
1090         * CMakeLists.txt:
1091         * GNUmakefile.am:
1092         * WebCore.gypi:
1093         * WebCore.pro:
1094         * WebCore.vcproj/WebCore.vcproj:
1095         * WebCore.xcodeproj/project.pbxproj:
1096         * platform/graphics/GraphicsContext.cpp:
1097         (WebCore::GraphicsContext::addRoundedRectClip):
1098         (WebCore::GraphicsContext::clipOutRoundedRect):
1099         * platform/graphics/GraphicsContext.h:
1100         * platform/graphics/RoundedIntRect.cpp: Removed.
1101         * platform/graphics/RoundedIntRect.h: Removed.
1102         * rendering/RenderBox.cpp:
1103         (WebCore::RenderBox::pushContentsClip):
1104         * rendering/RenderBoxModelObject.cpp:
1105         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1106         (WebCore::RenderBoxModelObject::paintBorder):
1107         (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
1108         (WebCore::uniformlyExpandBorderRadii):
1109         (WebCore::RenderBoxModelObject::paintBoxShadow):
1110         * rendering/RenderBoxModelObject.h:
1111         * rendering/RenderObject.cpp:
1112         (WebCore::RenderObject::drawBoxSideFromPath):
1113         * rendering/RenderReplaced.cpp:
1114         (WebCore::RenderReplaced::paint):
1115         * rendering/RenderThemeChromiumWin.cpp:
1116         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1117         * rendering/RenderThemeMac.mm:
1118         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
1119         (WebCore::RenderThemeMac::paintSliderTrack):
1120         * rendering/RenderThemeSafari.cpp:
1121         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
1122         (WebCore::RenderThemeSafari::paintSliderTrack):
1123         * rendering/RenderThemeWinCE.cpp:
1124         (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
1125         * rendering/RenderWidget.cpp:
1126         (WebCore::RenderWidget::paint):
1127         * rendering/style/BorderData.h:
1128         * rendering/style/RenderStyle.cpp:
1129         (WebCore::constrainCornerRadiiForRect):
1130         (WebCore::RenderStyle::getBorderRadiiForRect):
1131         (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
1132         * rendering/style/RenderStyle.h:
1133
1134 2011-01-17  Pavel Podivilov  <podivilov@chromium.org>
1135
1136         Reviewed by Yury Semikhatsky.
1137
1138         Web Inspector: add source column field to debugger call frames.
1139         https://bugs.webkit.org/show_bug.cgi?id=52443
1140
1141         * bindings/js/JavaScriptCallFrame.cpp:
1142         (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
1143         * bindings/js/JavaScriptCallFrame.h:
1144         (WebCore::JavaScriptCallFrame::create):
1145         (WebCore::JavaScriptCallFrame::line):
1146         (WebCore::JavaScriptCallFrame::column):
1147         (WebCore::JavaScriptCallFrame::update):
1148         * bindings/js/ScriptDebugServer.cpp:
1149         (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
1150         (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
1151         (WebCore::ScriptDebugServer::callEvent):
1152         (WebCore::ScriptDebugServer::atStatement):
1153         (WebCore::ScriptDebugServer::returnEvent):
1154         (WebCore::ScriptDebugServer::exception):
1155         (WebCore::ScriptDebugServer::willExecuteProgram):
1156         (WebCore::ScriptDebugServer::didExecuteProgram):
1157         (WebCore::ScriptDebugServer::didReachBreakpoint):
1158         * bindings/js/ScriptDebugServer.h:
1159         * bindings/v8/DebuggerScript.js:
1160         ():
1161         * bindings/v8/JavaScriptCallFrame.cpp:
1162         (WebCore::JavaScriptCallFrame::column):
1163         * bindings/v8/JavaScriptCallFrame.h:
1164         * inspector/InjectedScriptSource.js:
1165         ():
1166         * inspector/JavaScriptCallFrame.idl:
1167
1168 2011-01-18  Antti Koivisto  <antti@apple.com>
1169
1170         Reviewed by Dave Hyatt.
1171
1172         https://bugs.webkit.org/show_bug.cgi?id=52370
1173         <rdar://problem/8856808>
1174         Style sharing optimization no longer works on major web sites
1175         
1176         The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated 
1177         by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
1178         the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.  
1179         
1180         This patch gets the style sharing back to 25-40% range on most web sites.
1181
1182         * css/CSSMutableStyleDeclaration.h:
1183         (WebCore::CSSMutableStyleDeclaration::propertiesEqual):
1184             
1185             Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.
1186         
1187         * css/CSSSelector.h:
1188         (WebCore::CSSSelector::isSiblingSelector):
1189         
1190             Test for selectors that are affected by the sibling elements.
1191         
1192         * css/CSSStyleSelector.cpp:
1193         (WebCore::elementCanUseSimpleDefaultStyle):
1194         (WebCore::collectSiblingRulesInDefaultStyle):
1195         (WebCore::assertNoSiblingRulesInDefaultStyle):
1196             
1197             Extract sibling rules from the MathML default stylesheet. 
1198             Assert that no other default stylesheet has them.
1199             
1200         (WebCore::CSSStyleSelector::CSSStyleSelector):
1201         (WebCore::CSSStyleSelector::locateCousinList):
1202         (WebCore::CSSStyleSelector::matchesSiblingRules):
1203         (WebCore::CSSStyleSelector::canShareStyleWithElement):
1204         (WebCore::CSSStyleSelector::locateSharedStyle):
1205         (WebCore::CSSStyleSelector::styleForElement):
1206         (WebCore::collectIdsAndSiblingRulesFromList):
1207         (WebCore::CSSRuleSet::collectIdsAndSiblingRules):
1208
1209             Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
1210             where style sharing can't be used.
1211
1212         * css/CSSStyleSelector.h:
1213         * dom/NamedNodeMap.cpp:
1214         (WebCore::NamedNodeMap::mappedMapsEquivalent):
1215             
1216             Check also for CSSValue mutation from DOM. 
1217             
1218         * mathml/MathMLMathElement.cpp:
1219         (WebCore::MathMLMathElement::insertedIntoDocument):
1220         * mathml/MathMLMathElement.h:
1221         
1222             MathML default style sheet has sibling rules which don't get noticed by the normal document
1223             stylesheet parsing.
1224         
1225         * rendering/style/RenderStyle.h:
1226         (WebCore::InheritedFlags::setFirstChildState):
1227         (WebCore::InheritedFlags::setLastChildState):
1228         (WebCore::InheritedFlags::setChildIndex):
1229         
1230             These all make style non-shareable (unique).
1231
1232 2011-01-18  MORITA Hajime  <morrita@google.com>
1233
1234         Unreviewed crash fix on release builds.
1235
1236         * rendering/RenderBoxModelObject.cpp:
1237         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1238
1239 2011-01-18  Pavel Podivilov  <podivilov@chromium.org>
1240
1241         Unreviewed, update localizedStrings.js.
1242
1243         * English.lproj/localizedStrings.js:
1244
1245 2011-01-11  Pavel Podivilov  <podivilov@chromium.org>
1246
1247         Reviewed by Pavel Feldman.
1248
1249         Web Inspector: implement script beautifier prototype.
1250         https://bugs.webkit.org/show_bug.cgi?id=51588
1251
1252         * WebCore.gypi:
1253         * WebCore.vcproj/WebCore.vcproj:
1254         * inspector/front-end/ScriptFormatter.js: Added.
1255         (WebInspector.ScriptFormatter): Implements JavaScript source beautification and conversion between original and
1256         formatted line numbers
1257         (WebInspector.ScriptFormatter.findLineEndings):
1258         (WebInspector.ScriptFormatter.locationToPosition):
1259         (WebInspector.ScriptFormatter.positionToLocation):
1260         (WebInspector.ScriptFormatter.upperBound):
1261         (WebInspector.ScriptFormatter.prototype.format):
1262         (WebInspector.ScriptFormatter.prototype.originalLineNumberToFormattedLineNumber):
1263         (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalLineNumber):
1264         (WebInspector.ScriptFormatter.prototype.originalPositionToFormattedLineNumber):
1265         (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalPosition):
1266         (WebInspector.ScriptFormatter.prototype._convertPosition):
1267         * inspector/front-end/ScriptsPanel.js:
1268         (WebInspector.ScriptsPanel):
1269         (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
1270         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
1271         (WebInspector.ScriptsPanel.prototype._formatScript):
1272         * inspector/front-end/SourceFrame.js: Convert original line numbers to UI line numbers and vice versa
1273         * inspector/front-end/WebKit.qrc:
1274         * inspector/front-end/inspector.html:
1275
1276 2011-01-18  Philippe Normand  <pnormand@igalia.com>
1277
1278         Unreviewed, GTK build fix as follow-up of r76004.
1279
1280         * GNUmakefile.am: Include RoundedIntRect files in the build
1281
1282 2011-01-18  Philippe Normand  <pnormand@igalia.com>
1283
1284         Unreviewed, rolling out r76002.
1285         http://trac.webkit.org/changeset/76002
1286         https://bugs.webkit.org/show_bug.cgi?id=49790
1287
1288         breaks a bunch of fast/forms tests on mac and GTK
1289
1290         * html/HTMLOptionElement.cpp:
1291         (WebCore::HTMLOptionElement::setRenderStyle):
1292
1293 2011-01-18 MORITA Hajime <morrita@google.com>
1294
1295         Unreviewed windows build fix.
1296
1297         * WebCore.vcproj/WebCore.vcproj:
1298
1299 2011-01-17  MORITA Hajime  <morrita@google.com>
1300
1301         Reviewed by Simon Fraser.
1302
1303         Refactoring: Extract RoundedIntRect class
1304         https://bugs.webkit.org/show_bug.cgi?id=51664
1305
1306         RoundedIntRect is a pair of rect and four IntSize objects which represent
1307         corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
1308         Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
1309         return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
1310         and other functions accept RoundedIntRect as an argument.
1311
1312         No new tests. No behavioral change.
1313
1314         * Android.mk:
1315         * CMakeLists.txt:
1316         * WebCore.gypi:
1317         * WebCore.pro:
1318         * WebCore.xcodeproj/project.pbxproj:
1319         * platform/graphics/GraphicsContext.cpp:
1320         (WebCore::GraphicsContext::addRoundedRectClip):
1321         (WebCore::GraphicsContext::clipOutRoundedRect):
1322         (WebCore::GraphicsContext::fillRoundedRect):
1323         * platform/graphics/GraphicsContext.h:
1324         * platform/graphics/RoundedIntRect.cpp: Added.
1325         (WebCore::RoundedIntRect::Radii::isZero):
1326         (WebCore::RoundedIntRect::Radii::scale):
1327         (WebCore::RoundedIntRect::Radii::expand):
1328         (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
1329         (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
1330         (WebCore::RoundedIntRect::RoundedIntRect):
1331         (WebCore::RoundedIntRect::includeLogicalEdges):
1332         (WebCore::RoundedIntRect::excludeLogicalEdges):
1333         * platform/graphics/RoundedIntRect.h: Added.
1334         (WebCore::RoundedIntRect::Radii::Radii):
1335         (WebCore::RoundedIntRect::Radii::setTopLeft):
1336         (WebCore::RoundedIntRect::Radii::setTopRight):
1337         (WebCore::RoundedIntRect::Radii::setBottomLeft):
1338         (WebCore::RoundedIntRect::Radii::setBottomRight):
1339         (WebCore::RoundedIntRect::Radii::topLeft):
1340         (WebCore::RoundedIntRect::Radii::topRight):
1341         (WebCore::RoundedIntRect::Radii::bottomLeft):
1342         (WebCore::RoundedIntRect::Radii::bottomRight):
1343         (WebCore::RoundedIntRect::Radii::expand):
1344         (WebCore::RoundedIntRect::Radii::shrink):
1345         (WebCore::RoundedIntRect::location):
1346         (WebCore::RoundedIntRect::size):
1347         (WebCore::RoundedIntRect::x):
1348         (WebCore::RoundedIntRect::y):
1349         (WebCore::RoundedIntRect::width):
1350         (WebCore::RoundedIntRect::height):
1351         (WebCore::RoundedIntRect::right):
1352         (WebCore::RoundedIntRect::bottom):
1353         (WebCore::RoundedIntRect::rect):
1354         (WebCore::RoundedIntRect::radii):
1355         (WebCore::RoundedIntRect::isRounded):
1356         (WebCore::RoundedIntRect::isEmpty):
1357         (WebCore::RoundedIntRect::setRect):
1358         (WebCore::RoundedIntRect::setRadii):
1359         (WebCore::RoundedIntRect::move):
1360         (WebCore::RoundedIntRect::inflate):
1361         (WebCore::RoundedIntRect::inflateWithRadii):
1362         (WebCore::RoundedIntRect::expandRadii):
1363         (WebCore::RoundedIntRect::shrinkRadii):
1364         * rendering/RenderBox.cpp:
1365         (WebCore::RenderBox::pushContentsClip):
1366         * rendering/RenderBoxModelObject.cpp:
1367         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1368         (WebCore::RenderBoxModelObject::paintBorder):
1369         (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
1370         (WebCore::RenderBoxModelObject::paintBoxShadow):
1371         * rendering/RenderBoxModelObject.h:
1372         * rendering/RenderObject.cpp:
1373         (WebCore::RenderObject::drawBoxSideFromPath):
1374         * rendering/RenderReplaced.cpp:
1375         (WebCore::RenderReplaced::paint):
1376         * rendering/RenderThemeChromiumWin.cpp:
1377         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1378         * rendering/RenderThemeMac.mm:
1379         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
1380         (WebCore::RenderThemeMac::paintSliderTrack):
1381         * rendering/RenderThemeSafari.cpp:
1382         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
1383         (WebCore::RenderThemeSafari::paintSliderTrack):
1384         * rendering/RenderThemeWinCE.cpp:
1385         (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
1386         * rendering/RenderWidget.cpp:
1387         (WebCore::RenderWidget::paint):
1388         * rendering/style/BorderData.h:
1389         * rendering/style/RenderStyle.cpp:
1390         (WebCore::calcRadiiFor):
1391         (WebCore::calcConstraintScaleFor):
1392         (WebCore::RenderStyle::getRoundedBorderFor):
1393         (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
1394         * rendering/style/RenderStyle.h:
1395         (WebCore::InheritedFlags::setBorderRadius):
1396
1397 2011-01-17  Rob Buis  <rwlbuis@gmail.com>
1398
1399         Reviewed by Kent Tamura.
1400
1401         Color changes to option elements in a select multiple aren't drawn immediately
1402         https://bugs.webkit.org/show_bug.cgi?id=49790
1403
1404         Redirect style changes on <option> element to the owner <select> element.
1405
1406         Tests: fast/forms/select-option-background-color-change.html
1407                fast/forms/select-option-color-change.html
1408                fast/forms/select-option-visibility-change.html
1409
1410         * html/HTMLOptionElement.cpp:
1411         (WebCore::HTMLOptionElement::setRenderStyle):
1412
1413 2011-01-17  MORITA Hajime  <morrita@google.com>
1414
1415         Unreviewed, rolling out r75995.
1416         http://trac.webkit.org/changeset/75995
1417         https://bugs.webkit.org/show_bug.cgi?id=51914
1418
1419         Causes assertion failures.
1420
1421         * dom/Element.cpp:
1422         (WebCore::Element::shadowRoot):
1423         (WebCore::Element::setShadowRoot):
1424         (WebCore::Element::removeShadowRoot):
1425         * dom/ElementRareData.h:
1426         (WebCore::ElementRareData::ElementRareData):
1427
1428 2011-01-17  MORITA Hajime  <morrita@google.com>
1429
1430         Unreviewed, rolling out r75999.
1431         http://trac.webkit.org/changeset/75999
1432
1433         * dom/Element.cpp:
1434         (WebCore::Element::removeShadowRoot):
1435
1436 2011-01-17 MORITA Hajime  <morrita@google.com>
1437
1438         Unreviewed crash fix, which introduced at r75995
1439
1440         * dom/Element.cpp:
1441         (WebCore::Element::removeShadowRoot):
1442
1443 2011-01-17  MORITA Hajime  <morrita@google.com>
1444
1445         Reviewed by Dimitri Glazkov.
1446
1447         ElementRareData::m_shadowRoot should not be RefPtr.
1448         https://bugs.webkit.org/show_bug.cgi?id=51914
1449
1450         This change makes m_shadowRoot a raw pointer, as Node::m_parent is.
1451         This change is safe because shadow host pointer is stored as TreeShared::m_parent
1452         which prevents deletion unless set to null.
1453         
1454         No test, no behavioral change.
1455
1456         * dom/Element.cpp:
1457         (WebCore::Element::shadowRoot):
1458         (WebCore::Element::setShadowRoot):
1459         (WebCore::Element::removeShadowRoot):
1460         * dom/ElementRareData.h:
1461         (WebCore::ElementRareData::ElementRareData):
1462
1463 2011-01-17  Maciej Stachowiak  <mjs@apple.com>
1464
1465         Reviewed by Dan Bernstein.
1466
1467         Some WebKit2 layout tests crash due to focus being on a frame in the page cache
1468         https://bugs.webkit.org/show_bug.cgi?id=52607
1469
1470         No new tests. Existing tests crash in WebKit2 without this fix.
1471         
1472         I suspect there are other consequences besides the WebKit2 crash, but I
1473         was unable to identify any for certain.
1474
1475         * history/CachedFrame.cpp:
1476         (WebCore::CachedFrame::CachedFrame): If a frame still has focus when its page
1477         goes in the page cache, reset focus to the main frame.
1478
1479 2011-01-17  Adam Roben  <aroben@apple.com>
1480
1481         Simplify WKCACFLayerRenderer's API
1482
1483         createRenderer/destroyRenderer are now hidden behind setHostWindow.
1484         WKCACFLayerRendererClient::animationsStarted has been removed, as it
1485         was never called. (The work it was supposed to do was already being
1486         accomplished by WKCACFLayerRenderer::render telling each layer that
1487         animations are starting.)
1488
1489         Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use
1490
1491         Reviewed by Chris Marrin.
1492
1493         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
1494         (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Moved the
1495         call to setHostWindow here from the WM_CREATE handler. The WM_CREATE
1496         handler was causing the Direct3D device to be created, but MSDN says
1497         you shouldn't create a device while handling WM_CREATE. Removed
1498         no-longer-needed call to createRenderer (setHostWindow does this now)
1499         and the never-needed call to setNeedsDisplay (we never draw into the
1500         root layer; this was just creating an unnecessary backing store the
1501         size of the screen!).
1502         (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Moved WM_CREATE
1503         code, as described above. Removed call to destroyRenderer when handling
1504         WM_DESTROY; setHostWindow does this now. Fixed up our WM_PAINT handler
1505         to do a synchronous paint and to clear our dirty region, while I was in
1506         here.
1507
1508         * platform/graphics/win/WKCACFLayerRenderer.cpp:
1509         (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Changed to call
1510         setHostWindow instead of destroyRenderer; the former calls the latter
1511         if needed.
1512         (WebCore::WKCACFLayerRenderer::setHostWindow): Moved here from the
1513         header file. Destroys our old renderer (i.e., IDirect3DDevice9) if
1514         we're losing our window, or creates a renderer if we're gaining a
1515         window.
1516         (WebCore::WKCACFLayerRenderer::createRenderer): Updated for WKSI function rename.
1517         (WebCore::WKCACFLayerRenderer::destroyRenderer): Changed to clear the
1518         D3D device from our context before releasing the device.
1519
1520         * platform/graphics/win/WKCACFLayerRenderer.h: Removed
1521         WKCACFLayerRendererClient::animationsStarted. Removed setNeedsDisplay.
1522         Make createRenderer, destroyRenderer, and renderSoon private.
1523
1524 2011-01-17  Adam Roben  <aroben@apple.com>
1525
1526         Remove special-cased support for providing content for the root layer
1527
1528         Clients will just have to provide content through the normal
1529         GraphicsLayer channels now!
1530
1531         Support for <http://webkit.org/b/52582> WebView should paint directly
1532         into a GraphicsLayer when in accelerated compositing mode
1533
1534         Reviewed by Simon Fraser and Chris Marrin.
1535
1536         * platform/graphics/win/WKCACFLayerRenderer.cpp:
1537         (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Removed
1538         initialization of m_backingStoreDirty, which has itself been removed.
1539         (WebCore::WKCACFLayerRenderer::setNeedsDisplay): Moved code to schedule
1540         a sync from here to syncCompositingStateSoon. We only need to call
1541         renderSoon if we don't call syncCompositingStateSoon; the latter
1542         function calls the former.
1543         (WebCore::WKCACFLayerRenderer::paint): Removed code to handle
1544         m_backingStoreDirty. We don't want to know anything about clients'
1545         backing stores.
1546         (WebCore::WKCACFLayerRenderer::syncCompositingStateSoon): Added. Code
1547         came from setNeedsDisplay.
1548
1549         * platform/graphics/win/WKCACFLayerRenderer.h:
1550         Removed setRootContents[AndDisplay], setBackingStoreDirty, and
1551         m_backingStoreDirty. Made paint() public so that clients can force a
1552         synchronous render (e.g., when handling WM_PAINT).
1553
1554 2011-01-17  Adam Roben  <aroben@apple.com>
1555
1556         Remove contexts from WKCACFContextFlusher before destroying them
1557
1558         We aren't really using WKCACFContextFlusher for anything useful at the
1559         moment, but that will probably change in the near future.
1560
1561         I couldn't come up with a way to test this because it isn't possible to
1562         resize a window in DumpRenderTree.
1563
1564         Fixes <http://webkit.org/b/52573> REGRESSION (r75262): Crash beneath
1565         WKCACFContextFlusher::flushAllContexts when resizing window on page
1566         that uses accelerated compositing
1567
1568         Reviewed by Simon Fraser.
1569
1570         * platform/graphics/win/WKCACFLayerRenderer.cpp:
1571         (WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Remove our
1572         context from WKCACFContextFlusher. (This code was erroneously removed
1573         from WKCACFLayerRenderer::destroyRenderer in r75262. This is a more
1574         sensible place for it.)
1575
1576 2011-01-17  Adam Roben  <aroben@apple.com>
1577
1578         Don't access the CACFLayerRef's sublayers directly from PlatformCALayer
1579
1580         There might be a secret extra sublayer (the tile parent layer) that
1581         PlatformCALayer doesn't know about. When PlatformCALayer would
1582         encounter this, it would try to use the tile parent layer's
1583         PlatformCALayer wrapper, which was null, and then would crash. We now
1584         ask PlatformCALayerWinInternal for the sublayer list, since that class
1585         knows about the tile parent layer and can exclude it from the sublayer
1586         list.
1587
1588         Covered by compositing/tiling/huge-layer-resize.html.
1589
1590         Fixes <http://webkit.org/b/52597> Crash beneath
1591         PlatformCALayer::adoptSublayers when switching out of tiling mode
1592         (null-dereference of a PlatformCALayer)
1593
1594         Reviewed by Darin Adler and Chris Marrin.
1595
1596         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
1597         (PlatformCALayer::adoptSublayers):
1598         (printLayer):
1599         Changed to use PlatformCALayerWinInternal::getSublayers.
1600
1601         * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
1602         (PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
1603         of PlatformCALayers that represent our sublayers. Significantly, this
1604         code knows about the tile parent layer and can thus exclude it.
1605
1606         * platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added
1607         getSublayers.
1608
1609 2011-01-17  Naoki Takano  <takano.naoki@gmail.com>
1610
1611         Reviewed by Kent Tamura.
1612
1613         [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
1614         https://bugs.webkit.org/show_bug.cgi?id=51382
1615         http://crbug.com/60427
1616
1617         Calculate correct location of popup window whenever the items in the window change.
1618
1619         No new tests, because this fix is for Chromium project and hard to test only in WebKit project
1620
1621         * platform/chromium/PopupMenuChromium.cpp:
1622         (WebCore::PopupContainer::layoutAndCalculateWidgetRect): New Function to layout and calculate popup widget rect.
1623         (WebCore::PopupContainer::showPopup): Move widgetRect calculation logic to calculateWidgetRect().
1624         (WebCore::PopupContainer::refresh): Add parameter focusRect to take the location and the size of focus text input field to calculate correct popup window location.
1625         * platform/chromium/PopupMenuChromium.h: Append new input parameter for refresh().
1626
1627 2011-01-17  Mark Rowe  <mrowe@apple.com>
1628
1629         Fix the 32-bit build.
1630
1631         * WebCore.exp.in:
1632
1633 2011-01-17  Dan Bernstein  <mitz@apple.com>
1634
1635         Reviewed by Darin Adler.
1636
1637         Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font
1638         https://bugs.webkit.org/show_bug.cgi?id=52598
1639
1640         Test: fast/css/font-face-zero-hash-key.html
1641
1642         * css/CSSFontFaceSource.cpp:
1643         (WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.
1644         * css/CSSSegmentedFontFace.cpp:
1645         (WebCore::CSSSegmentedFontFace::getFontData): Ditto.
1646
1647 2011-01-17  David Kilzer  <ddkilzer@apple.com>
1648
1649         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
1650
1651         Reviewed by Dan Bernstein.
1652
1653         This fixes two issues:
1654
1655         Add missing DOMDocumentFragmentPrivate.h and
1656         DOMDocumentPrivate.h files to the project.  These files were
1657         never added to the the project although their *Internal.h
1658         counterparts were added in r16548 and r17390.
1659
1660         Add missing DOMDocumentFragmentInternal.h to the Headers
1661         section.  It was moved from Headers to "Copy Generated Headers"
1662         in r31045, but it should have an entry in both sections.
1663
1664         * WebCore.xcodeproj/project.pbxproj:
1665
1666 2011-01-17  Helder Correia  <helder@sencha.com>
1667
1668         Reviewed by Andreas Kling.
1669
1670         [Qt] Incorrect shadow alpha with pattern fillStyle
1671         https://bugs.webkit.org/show_bug.cgi?id=52559
1672
1673         The shadow color opacity needs to be set on the shadow painter.
1674         This is related to bug 52556.
1675
1676         Test: fast/canvas/canvas-fillPath-pattern-shadow.html
1677
1678         * platform/graphics/qt/GraphicsContextQt.cpp:
1679         (WebCore::GraphicsContext::fillPath):
1680
1681 2011-01-17  Martin Robinson  <mrobinson@igalia.com>
1682
1683         Reviewed by Andreas Kling.
1684
1685         [GTK] Port a crash fix from libsoup upstream to the libsoup cache code
1686         https://bugs.webkit.org/show_bug.cgi?id=52586
1687
1688         No new tests. This is just a merge from upstream.
1689
1690         * platform/network/soup/cache/soup-http-input-stream.c:
1691         (webkit_soup_http_input_stream_got_chunk): Properly handle unsigned numbers.
1692
1693 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1694
1695         Reviewed by Alexey Proskuryakov.
1696
1697         Fix some headers with missing or misspelled #ifndef guards
1698         https://bugs.webkit.org/show_bug.cgi?id=52545
1699
1700         No new tests because no new functionality.
1701
1702         * ForwardingHeaders/runtime/InitializeThreading.h:
1703         * editing/SmartReplace.h:
1704         * loader/CrossOriginAccessControl.h:
1705         * loader/NetscapePlugInStreamLoader.h:
1706         * platform/chromium/ClipboardUtilitiesChromium.h:
1707         * platform/graphics/cairo/DrawErrorUnderline.h:
1708         * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
1709         * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
1710         * platform/graphics/cg/PDFDocumentImage.h:
1711         * platform/win/WebCoreTextRenderer.h:
1712
1713 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
1714
1715         Not reviewed: follow-up fix for r52574: do not reuse clear() for navigation.
1716
1717         * inspector/front-end/NetworkPanel.js:
1718         (WebInspector.NetworkPanel.prototype.clear):
1719         (WebInspector.NetworkPanel.prototype.mainResourceChanged):
1720
1721 2011-01-17  Sergio Villar Senin  <svillar@igalia.com>
1722
1723         Reviewed by Martin Robinson.
1724
1725         [Gtk] No need to content sniff 304 Not Modified responses
1726         https://bugs.webkit.org/show_bug.cgi?id=52570
1727
1728         Makes no sense to wait for the outcome of content sniffing when WebCore
1729         is validating resources. If we get a 304 Not Modified it means that we can
1730         safely use the cached version of the resource we're asking for.
1731
1732         No new tests because it does not change functionality, it just
1733         calls didReceiveResponse sooner for 304 Not Modified responses.
1734
1735         * platform/network/soup/ResourceHandleSoup.cpp:
1736         (WebCore::gotHeadersCallback):
1737
1738 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1739
1740         Reviewed by Anders Carlsson.
1741
1742         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1743         navigating back to an unreachable URL
1744         https://bugs.webkit.org/show_bug.cgi?id=52388
1745
1746         Test: http/tests/navigation/go-back-to-error-page.html
1747
1748         * history/PageCache.cpp:
1749         (WebCore::PageCache::canCachePageContainingThisFrame):
1750         Do not cache any error pages (which we can recognize as having substitute data and/or an
1751         unreachableURL).
1752
1753 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
1754
1755         Not reviewed: fixing typo in r75952.
1756
1757         * inspector/front-end/NetworkPanel.js:
1758         (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
1759
1760 2011-01-17  Enrica Casucci  <enrica@apple.com>
1761
1762         Reviewed by Alexey Proskuryakov.
1763
1764         Drag and drop support: refactoring of image from link and image from selection
1765         https://bugs.webkit.org/show_bug.cgi?id=52496
1766
1767         This work cleans up the Mac code and makes it more similar to the Windows implementation,
1768         avoiding the use of an NSView when the FrameView can be used.
1769         The refactoring is a necessary step towards the complete support of drag and drop
1770         in WebKit2.
1771         
1772         * page/mac/FrameMac.mm:
1773         (WebCore::Frame::imageFromRect): Modified to use FrameView instead of NSView
1774         to generate the image for drag.
1775
1776 2011-01-17  Dan Bernstein  <mitz@apple.com>
1777
1778         Rubber-stamped by Mark Rowe.
1779
1780         Update xcodeproj svn:ignore to include xcuserdata.
1781
1782         * WebCore.xcodeproj: Modified property svn:ignore.
1783         * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.
1784
1785 2011-01-17  Alexey Proskuryakov  <ap@apple.com>
1786
1787         Leopard build fix.
1788
1789         * page/PrintContext.cpp: GCC complained about shortening a double value to float.
1790
1791 2011-01-17  Alexey Proskuryakov  <ap@apple.com>
1792
1793         Reviewed by Dan Bernstein.
1794
1795         https://bugs.webkit.org/show_bug.cgi?id=52495
1796
1797         No change in behavior, so no tests.
1798
1799         * WebCore.exp.in: Export additional methods, as I'm going to use more code from PrintContext.
1800
1801         * page/PrintContext.cpp:
1802         (WebCore::PrintContext::~PrintContext): No need to clear m_pageRects, the object is being
1803         destroyed already.
1804         (WebCore::PrintContext::pageCount): Changed page count from int to size_t.
1805         (WebCore::PrintContext::pageRect): Ditto.
1806         (WebCore::PrintContext::computePageRects): Pass allowHorizontalTiling as an argument.
1807         PrintContext already has code to calculate scale factor, so it makes sense to make methods
1808         that contain it universal (allowHorizontalTiling is always true for Safari).
1809         Round page height to an integer, because Mac code does that, and because page height is
1810         treated as integer almost everywhere else in code.
1811         (WebCore::PrintContext::begin): Allow calling this function multiple times. There is no need
1812         to return to screen mode if e.g. "print backgounds" option changes.
1813         (WebCore::PrintContext::computeAutomaticScaleFactor): Expose scale factor computation, so
1814         that clients don't have to copy it.
1815         (WebCore::PrintContext::spoolRect): Add a way to spool a precomputed rect - handy if a request
1816         comes from code that doesn't have page number.
1817         (WebCore::PrintContext::pageNumberForElement): Page number int -> size_t.
1818
1819         * page/PrintContext.h: Added comments and FIXMEs. PrintContext needs cleanup, but that
1820         depends on deciding how it really needs to work (e.g. whether computePageRects() should
1821         cause relayout).
1822
1823 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
1824
1825         Reviewed by Yury Semikhatsky.
1826
1827         Web Inspector: unify image data source assignment, add image url
1828         to the image view properties list.
1829         https://bugs.webkit.org/show_bug.cgi?id=52584
1830
1831         * English.lproj/localizedStrings.js:
1832         * inspector/front-end/ImageView.js:
1833         (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
1834         (WebInspector.ImageView.prototype._createContentIfNeeded):
1835         * inspector/front-end/NetworkPanel.js:
1836         (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
1837         * inspector/front-end/Resource.js:
1838         (WebInspector.Resource.prototype.populateImageSource):
1839         (WebInspector.Resource.prototype._contentURL):
1840         * inspector/front-end/ResourcesPanel.js:
1841         (WebInspector.FrameResourceTreeElement.prototype.onattach):
1842
1843 2011-01-17  Andrey Kosyakov  <caseq@chromium.org>
1844
1845         Reviewed by Pavel Feldman.
1846
1847         Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
1848         Make resource start/finish hanlding more consistent.
1849         https://bugs.webkit.org/show_bug.cgi?id=52452
1850
1851         * inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator
1852         (WebInspector.AuditLauncherView.prototype._resetResourceCount):
1853         (WebInspector.AuditLauncherView.prototype.resourceStarted):
1854         (WebInspector.AuditLauncherView.prototype.resourceFinished):
1855         * inspector/front-end/NetworkManager.js:
1856         (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource()
1857         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
1858         (WebInspector.NetworkManager.prototype.willSendRequest):
1859         (WebInspector.NetworkManager.prototype.markResourceAsCached):
1860         (WebInspector.NetworkManager.prototype.didReceiveResponse):
1861         (WebInspector.NetworkManager.prototype.didReceiveContentLength):
1862         (WebInspector.NetworkManager.prototype.didFinishLoading):
1863         (WebInspector.NetworkManager.prototype.didFailLoading):
1864         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
1865         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
1866         (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
1867         (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
1868         (WebInspector.NetworkManager.prototype.didCloseWebSocket):
1869         (WebInspector.NetworkManager.prototype._appendRedirect):
1870         (WebInspector.NetworkManager.prototype._startResource):
1871         (WebInspector.NetworkManager.prototype._finishResource):
1872
1873 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
1874
1875         Reviewed by Yury Semikhatsky.
1876
1877         Web Inspector: restore dom and network state upon frontend reuse.
1878         https://bugs.webkit.org/show_bug.cgi?id=52574
1879
1880         * inspector/Inspector.idl:
1881         * inspector/InspectorController.cpp:
1882         (WebCore::InspectorController::restoreInspectorStateFromCookie):
1883         (WebCore::InspectorController::populateScriptObjects):
1884         (WebCore::InspectorController::pushDataCollectedOffline):
1885         (WebCore::InspectorController::didCommitLoad):
1886         * inspector/InspectorController.h:
1887         * inspector/front-end/NetworkManager.js:
1888         (WebInspector.NetworkManager.prototype.reset):
1889         * inspector/front-end/NetworkPanel.js:
1890         (WebInspector.NetworkPanel.prototype.clear):
1891         (WebInspector.NetworkPanel.prototype.mainResourceChanged):
1892         * inspector/front-end/ResourceTreeModel.js:
1893         (WebInspector.ResourceTreeModel):
1894         (WebInspector.ResourceTreeModel.prototype.reloadCachedResources):
1895         * inspector/front-end/ResourcesPanel.js:
1896         (WebInspector.ResourcesPanel.prototype.clear):
1897         * inspector/front-end/inspector.js:
1898         (WebInspector.frontendReused):
1899
1900 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1901
1902         Unreviewed buildfix after r75944.
1903
1904         * WebCore.pro:
1905
1906 2011-01-17  Yi Shen  <yi.4.shen@nokia.com>
1907
1908         Reviewed by Andreas Kling.
1909
1910         [Qt] Extend the Platform Plugin to support full screen video handler
1911         https://bugs.webkit.org/show_bug.cgi?id=51249
1912
1913         Make MediaPlayerPrivateQt support a fullscreen player.
1914
1915         No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
1916         However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
1917         So, still skip it for Qt.
1918
1919         * WebCore.pro:
1920         * features.pri:
1921         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
1922         (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
1923         (WebCore::MediaPlayerPrivateQt::removeVideoItem):
1924         (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
1925         * platform/graphics/qt/MediaPlayerPrivateQt.h:
1926         (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
1927         (WebCore::MediaPlayerPrivateQt::mediaPlayer):
1928
1929 2011-01-17  Anthony Ricaud  <rik@webkit.org>
1930
1931         Reviewed by Kent Tamura.
1932
1933         [HTML5] Revert display:none on datalist
1934         https://bugs.webkit.org/show_bug.cgi?id=52214
1935
1936         * css/html.css:
1937
1938 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
1939
1940         Reviewed by Yury Semikhatsky.
1941
1942         Web Inspector: simplify debugger enabling routine.
1943         https://bugs.webkit.org/show_bug.cgi?id=52472
1944
1945         * inspector/Inspector.idl:
1946         * inspector/InspectorController.cpp:
1947         (WebCore::InspectorController::restoreDebugger):
1948         (WebCore::InspectorController::showAndEnableDebugger):
1949         (WebCore::InspectorController::enableDebugger):
1950         * inspector/InspectorController.h:
1951         * inspector/front-end/DebuggerModel.js:
1952         * inspector/front-end/ScriptsPanel.js:
1953         (WebInspector.ScriptsPanel.prototype.show):
1954         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
1955
1956 2011-01-17  Pavel Podivilov  <podivilov@chromium.org>
1957
1958         Reviewed by Pavel Feldman.
1959
1960         Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
1961         https://bugs.webkit.org/show_bug.cgi?id=51738
1962
1963         Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
1964         Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.
1965
1966         * inspector/front-end/ScriptView.js:
1967         (WebInspector.ScriptView):
1968         (WebInspector.SourceFrameContentProviderForScript):
1969         (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource):
1970         (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
1971         (WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
1972         * inspector/front-end/ScriptsPanel.js:
1973         (WebInspector.ScriptsPanel.prototype._addScript):
1974         (WebInspector.ScriptsPanel.prototype.sourceFrameForScript):
1975         (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
1976         * inspector/front-end/SourceFrame.js:
1977         (WebInspector.SourceFrame):
1978         (WebInspector.SourceFrame.prototype.set visible):
1979         (WebInspector.SourceFrame.prototype._createTextViewer):
1980         (WebInspector.SourceFrame.prototype._breakpointAdded):
1981         (WebInspector.SourceFrame.prototype._breakpoints):
1982         (WebInspector.SourceFrame.prototype._sourceIDForLine):
1983         (WebInspector.SourceFrame.prototype._sourceIDSet):
1984         (WebInspector.SourceFrameContentProvider):
1985         (WebInspector.SourceFrameContentProvider.prototype.requestContent):
1986         (WebInspector.SourceFrameContentProvider.prototype.scripts):
1987         * inspector/front-end/SourceView.js:
1988         (WebInspector.SourceView):
1989         (WebInspector.SourceView.prototype.show):
1990         (WebInspector.SourceView.prototype.resize):
1991         (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches):
1992         (WebInspector.SourceView.prototype.performSearch):
1993         (WebInspector.SourceView.prototype.revealLine):
1994         (WebInspector.SourceView.prototype.highlightLine):
1995         (WebInspector.SourceView.prototype._jumpToSearchResult):
1996         (WebInspector.SourceFrameContentProviderForResource):
1997         (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
1998         (WebInspector.SourceFrameContentProviderForResource.prototype.scripts):
1999
2000 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2001
2002         Reviewed by Jeremy Orlow.
2003
2004         GeolocationController should call stopUpdating on destruction
2005         https://bugs.webkit.org/show_bug.cgi?id=52216
2006
2007         Test: fast/dom/Geolocation/window-close-crash.html
2008
2009         * page/GeolocationController.cpp:
2010         (WebCore::GeolocationController::~GeolocationController):
2011
2012 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
2013
2014         Not reviewed: Qt build fix.
2015
2016         * inspector/InspectorInstrumentation.h:
2017
2018 2011-01-16  Pavel Feldman  <pfeldman@chromium.org>
2019
2020         Reviewed by Yury Semikhatsky.
2021
2022         Web Inspector: make WebCore use InspectorInstrumentation
2023         for instrumentation calls.
2024         https://bugs.webkit.org/show_bug.cgi?id=52532
2025
2026         This change makes WebCore classes issue instrumentation signals
2027         by means of InspectorInstrumentation interface. It covered migration
2028         for Document, FrameLoader, Database, DOMStorage, etc. It fixed
2029         instrumentation handling for Console as well. This all is a part
2030         of story described in the bug 52510.
2031
2032         * dom/Document.cpp:
2033         (WebCore::Document::finishedParsing):
2034         * dom/Document.h:
2035         * dom/ScriptExecutionContext.h:
2036         * inspector/InspectorBrowserDebuggerAgent.cpp:
2037         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
2038         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
2039         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
2040         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
2041         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
2042         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
2043         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
2044         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
2045         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
2046         * inspector/InspectorBrowserDebuggerAgent.h:
2047         (WebCore::InspectorBrowserDebuggerAgent::create):
2048         * inspector/InspectorConsoleAgent.cpp:
2049         (WebCore::InspectorConsoleAgent::stopTiming):
2050         (WebCore::InspectorConsoleAgent::count):
2051         * inspector/InspectorConsoleAgent.h:
2052         * inspector/InspectorController.cpp:
2053         (WebCore::InspectorController::InspectorController):
2054         (WebCore::InspectorController::~InspectorController):
2055         (WebCore::InspectorController::handleMousePress):
2056         (WebCore::InspectorController::didClearWindowObjectInWorld):
2057         (WebCore::PostWorkerNotificationToFrontendTask::performTask):
2058         * inspector/InspectorController.h:
2059         * inspector/InspectorDOMAgent.h:
2060         * inspector/InspectorDOMStorageAgent.h:
2061         * inspector/InspectorDatabaseAgent.cpp:
2062         * inspector/InspectorDatabaseAgent.h:
2063         * inspector/InspectorFrontendHost.cpp:
2064         * inspector/InspectorFrontendHost.h:
2065         * inspector/InspectorInstrumentation.cpp:
2066         (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
2067         (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl):
2068         (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
2069         (WebCore::InspectorInstrumentation::handleMousePressImpl):
2070         (WebCore::InspectorInstrumentation::mainResourceFiredLoadEventImpl):
2071         (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEventImpl):
2072         (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
2073         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
2074         (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
2075         (WebCore::InspectorInstrumentation::consoleCountImpl):
2076         (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
2077         (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
2078         (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
2079         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
2080         (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
2081         (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
2082         (WebCore::InspectorInstrumentation::didCreateWorkerImpl):
2083         (WebCore::InspectorInstrumentation::didDestroyWorkerImpl):
2084         (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
2085         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
2086         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
2087         (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
2088         (WebCore::InspectorInstrumentation::networkStateChangedImpl):
2089         (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
2090         * inspector/InspectorInstrumentation.h:
2091         (WebCore::InspectorInstrumentation::inspectorControllerCreated):
2092         (WebCore::InspectorInstrumentation::inspectorControllerDeleted):
2093         (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
2094         (WebCore::InspectorInstrumentation::inspectedPageDestroyed):
2095         (WebCore::InspectorInstrumentation::willInsertDOMNode):
2096         (WebCore::InspectorInstrumentation::didInsertDOMNode):
2097         (WebCore::InspectorInstrumentation::willRemoveDOMNode):
2098         (WebCore::InspectorInstrumentation::willModifyDOMAttr):
2099         (WebCore::InspectorInstrumentation::didModifyDOMAttr):
2100         (WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
2101         (WebCore::InspectorInstrumentation::handleMousePress):
2102         (WebCore::InspectorInstrumentation::characterDataModified):
2103         (WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
2104         (WebCore::InspectorInstrumentation::didScheduleResourceRequest):
2105         (WebCore::InspectorInstrumentation::didInstallTimer):
2106         (WebCore::InspectorInstrumentation::didRemoveTimer):
2107         (WebCore::InspectorInstrumentation::willCallFunction):
2108         (WebCore::InspectorInstrumentation::willChangeXHRReadyState):
2109         (WebCore::InspectorInstrumentation::willDispatchEvent):
2110         (WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
2111         (WebCore::InspectorInstrumentation::willEvaluateScript):
2112         (WebCore::InspectorInstrumentation::willFireTimer):
2113         (WebCore::InspectorInstrumentation::willLayout):
2114         (WebCore::InspectorInstrumentation::willLoadXHR):
2115         (WebCore::InspectorInstrumentation::willPaint):
2116         (WebCore::InspectorInstrumentation::willRecalculateStyle):
2117         (WebCore::InspectorInstrumentation::identifierForInitialRequest):
2118         (WebCore::InspectorInstrumentation::willSendRequest):
2119         (WebCore::InspectorInstrumentation::markResourceAsCached):
2120         (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
2121         (WebCore::InspectorInstrumentation::willReceiveResourceData):
2122         (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
2123         (WebCore::InspectorInstrumentation::didReceiveContentLength):
2124         (WebCore::InspectorInstrumentation::didFinishLoading):
2125         (WebCore::InspectorInstrumentation::didFailLoading):
2126         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
2127         (WebCore::InspectorInstrumentation::scriptImported):
2128         (WebCore::InspectorInstrumentation::mainResourceFiredLoadEvent):
2129         (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEvent):
2130         (WebCore::InspectorInstrumentation::frameDetachedFromParent):
2131         (WebCore::InspectorInstrumentation::didCommitLoad):
2132         (WebCore::InspectorInstrumentation::willWriteHTML):
2133         (WebCore::InspectorInstrumentation::didOpenDatabase):
2134         (WebCore::InspectorInstrumentation::didUseDOMStorage):
2135         (WebCore::InspectorInstrumentation::didCreateWorker):
2136         (WebCore::InspectorInstrumentation::didDestroyWorker):
2137         (WebCore::InspectorInstrumentation::didCreateWebSocket):
2138         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
2139         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
2140         (WebCore::InspectorInstrumentation::didCloseWebSocket):
2141         (WebCore::InspectorInstrumentation::networkStateChanged):
2142         (WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
2143         (WebCore::InspectorInstrumentation::addMessageToConsole):
2144         (WebCore::InspectorInstrumentation::consoleCount):
2145         (WebCore::InspectorInstrumentation::startConsoleTiming):
2146         (WebCore::InspectorInstrumentation::stopConsoleTiming):
2147         (WebCore::InspectorInstrumentation::consoleMarkTimeline):
2148         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
2149         (WebCore::InspectorInstrumentation::inspectorControllerForContext):
2150         (WebCore::InspectorInstrumentation::inspectorControllerForFrame):
2151         (WebCore::InspectorInstrumentation::inspectorControllerForPage):
2152         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForContext):
2153         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForDocument):
2154         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForFrame):
2155         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
2156         * inspector/InspectorState.cpp:
2157         * loader/FrameLoader.cpp:
2158         (WebCore::FrameLoader::detachFromParent):
2159         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
2160         (WebCore::FrameLoader::dispatchDidCommitLoad):
2161         * page/Chrome.cpp:
2162         (WebCore::Chrome::mouseDidMoveOverElement):
2163         * page/Console.cpp:
2164         (WebCore::Console::addMessage):
2165         (WebCore::Console::count):
2166         (WebCore::Console::markTimeline):
2167         (WebCore::Console::profile):
2168         (WebCore::Console::time):
2169         (WebCore::Console::timeEnd):
2170         (WebCore::Console::group):
2171         (WebCore::Console::groupCollapsed):
2172         (WebCore::Console::groupEnd):
2173         * page/DOMWindow.cpp:
2174         (WebCore::DOMWindow::sessionStorage):
2175         (WebCore::DOMWindow::localStorage):
2176         (WebCore::DOMWindow::dispatchLoadEvent):
2177         * page/EventHandler.cpp:
2178         (WebCore::EventHandler::handleMousePressEvent):
2179         * page/Page.cpp:
2180         (WebCore::Page::~Page):
2181         * storage/Database.cpp:
2182         (WebCore::Database::openDatabase):
2183         * workers/AbstractWorker.cpp:
2184         (WebCore::AbstractWorker::onDestroyWorker):
2185         * workers/SharedWorker.cpp:
2186         (WebCore::SharedWorker::create):
2187         * workers/Worker.cpp:
2188         (WebCore::Worker::create):
2189         * workers/WorkerMessagingProxy.cpp:
2190
2191 2011-01-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2192
2193         Unreviewed, rolling out r75923.
2194
2195         GTK guy rolls out the r75914.
2196
2197         * platform/efl/ScrollViewEfl.cpp:
2198         (WebCore::ScrollView::platformInit):
2199
2200 2011-01-17  Helder Correia  <helder@sencha.com>
2201
2202         Reviewed by Kenneth Rohde Christiansen.
2203
2204         [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
2205         https://bugs.webkit.org/show_bug.cgi?id=52556
2206
2207         The shadow color opacity needs to be set on the shadow painter.
2208         Additionally, the gradient brush should be transformed.
2209
2210         * platform/graphics/qt/GraphicsContextQt.cpp:
2211         (WebCore::GraphicsContext::fillPath):
2212
2213 2011-01-17  No'am Rosenthal  <noam.rosenthal@nokia.com>
2214
2215         Reviewed by Kenneth Rohde Christiansen.
2216
2217         [Qt] Background image rendering is slow
2218         https://bugs.webkit.org/show_bug.cgi?id=50527
2219
2220         When tiling a scaled pixmap in Image::drawPattern, scale the tile
2221         first and only then draw it to the target. Do so only when drawing
2222         more than one tile.
2223
2224         Tests in fast/backgrounds/size cover this.
2225
2226         * platform/graphics/qt/ImageQt.cpp:
2227         (WebCore::Image::drawPattern):
2228
2229 2011-01-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2230
2231         Reviewed by Simon Hausmann.
2232
2233         [Qt] [Symbian] Fix building NPAPI support
2234         https://bugs.webkit.org/show_bug.cgi?id=51981
2235
2236         Make sure that npapi.h is always included outside of the extern "C"
2237         linkage declaration block.
2238
2239         No new tests as there is no new functionality.
2240
2241         * bridge/npruntime.h:
2242
2243 2011-01-17  Philippe Normand  <pnormand@igalia.com>
2244
2245         Unreviewed, rolling out r75914.
2246         http://trac.webkit.org/changeset/75914
2247         https://bugs.webkit.org/show_bug.cgi?id=49177
2248
2249         multiple crashes on GTK
2250
2251         * platform/ScrollView.cpp:
2252         (WebCore::ScrollView::removeChild):
2253         (WebCore::ScrollView::wheelEvent):
2254         * platform/gtk/MainFrameScrollbarGtk.cpp:
2255         (MainFrameScrollbarGtk::attachAdjustment):
2256         (MainFrameScrollbarGtk::gtkValueChanged):
2257         * platform/gtk/ScrollViewGtk.cpp:
2258         (WebCore::ScrollView::platformInit):
2259         (WebCore::ScrollView::platformAddChild):
2260         (WebCore::ScrollView::platformRemoveChild):
2261
2262 2011-01-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2263
2264         Unreviewed build fix.
2265
2266         Bug 49177's patch enabled platformInit() in super class(ScrollView).
2267         But, it didn't removed the function in ScrollViewEfl.cpp.
2268
2269         * platform/efl/ScrollViewEfl.cpp:
2270
2271 2011-01-16  Dan Bernstein  <mitz@apple.com>
2272
2273         Reviewed by Sam Weinig.
2274
2275         <rdar://problem/8871903> REGRESSION (r75897): Crash with 0-by-0 iframe in scaled WebView
2276
2277         Avoid use of FloatRect::enclosingBoundingBox(), which can stretch an empty
2278         quad to a non-empty rect.
2279
2280         * rendering/RenderWidget.cpp:
2281         (WebCore::RenderWidget::setWidget):
2282         (WebCore::RenderWidget::updateWidgetPosition):
2283
2284 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2285
2286         Reviewed by Xan Lopez.
2287
2288         [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
2289         https://bugs.webkit.org/show_bug.cgi?id=49177
2290
2291         * platform/ScrollView.cpp: Move the platform guards around a little. GTK+
2292         now shares the implementation of platformAddChild and platformRemoveChild,
2293         but has its own implementation of removeChild, which knows how to inform
2294         main frame scrollbars that they no longer control the WebCore scrollbar.
2295         * platform/gtk/MainFrameScrollbarGtk.cpp:
2296         (MainFrameScrollbarGtk::attachAdjustment): If we are attaching the same adjustment
2297         that we already have, bail out early. Apply the value changed signal handler
2298         after configuring the adjustment. We don't want our reset of the adjustment to
2299         stomp on WebCore values.
2300         (MainFrameScrollbarGtk::gtkValueChanged): Do not adjust the value if the WebCore
2301         state already matches ours. This prevents some unnecessary recursion
2302         * platform/gtk/ScrollViewGtk.cpp:
2303         (WebCore::ScrollView::removeChild): Added, special cases main frame scrollbars
2304         which need their adjustments detached.
2305
2306 2011-01-13  Yuzo Fujishima  <yuzo@google.com>
2307
2308         Reviewed by Antti Koivisto.
2309
2310         Fix for Bug 52427 - Inconsistent use of m_cache in CachedResourceLoader
2311         https://bugs.webkit.org/show_bug.cgi?id=52427
2312
2313         In constructor/destructor of CachedResourceLoader, m_cache has been
2314         used to call MemoryCache::addCachedResourceLoader/removeCachedResourceLoader
2315         while cache() is used everywhere else.
2316
2317         Actually addCachedResourceLoader/removeCachedResourceLoader need not be called at all.
2318         Remove the call sites and make MemoryCache non-friend of CachedResourceLoader.
2319
2320         No new tests because the behavior remains the same.
2321
2322         * loader/cache/CachedResourceLoader.cpp:
2323         (WebCore::CachedResourceLoader::CachedResourceLoader):
2324         (WebCore::CachedResourceLoader::~CachedResourceLoader):
2325         * loader/cache/CachedResourceLoader.h:
2326         * loader/cache/MemoryCache.cpp:
2327         * loader/cache/MemoryCache.h:
2328
2329 2011-01-16  Adam Barth  <abarth@webkit.org>
2330
2331         Rubber-stamped by Eric Seidel.
2332
2333         Move WebKit into Source
2334         https://bugs.webkit.org/show_bug.cgi?id=52530
2335
2336         * WebCore.gyp/WebCore.gyp:
2337         * WebCore.pri:
2338         * WebCore.pro:
2339
2340 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
2341
2342         Reviewed by Dan Bernstein.
2343
2344         frame-removed-during-resize.html test crashes (shows up as image-map-2.html crash)
2345         https://bugs.webkit.org/show_bug.cgi?id=52549
2346
2347         Fix regression from r75900; m_widget->setFrameRect() can run script that
2348         clears m_widget, so null-check it before calling setBoundsSize().
2349         
2350         Tested by fast/replaced/frame-removed-during-resize.html
2351
2352         * rendering/RenderWidget.cpp:
2353         (WebCore::RenderWidget::setWidgetGeometry):
2354
2355 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
2356
2357         Keep Leopard build happy.
2358
2359         * platform/mac/WidgetMac.mm:
2360         (WebCore::Widget::setBoundsSize):
2361
2362 2011-01-16  Robert Hogan  <robert@webkit.org>
2363
2364         Reviewed by Andreas Kling.
2365
2366         [Qt] plugins/keyboard-events.html fails after r72717
2367         https://bugs.webkit.org/show_bug.cgi?id=50050
2368
2369         * plugins/qt/PluginViewQt.cpp:
2370         (WebCore::setXKeyEventSpecificFields): map event text to keycode
2371
2372 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
2373
2374         Reviewed by Dan Bernstein.
2375
2376         Issues with iframes and plugins when the WebView is scaled.
2377         <rdar://problem/6213380>
2378         
2379         When _scaleWebView has been called on a WebView, iframes
2380         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
2381         This is caused by AppKit NSViews not playing nicely with the scale
2382         applied through style.
2383         
2384         Work around most of these issues by adjusting the bounds size
2385         of widgets to allow iframe contents to paint with the correct scale,
2386         and fix various places in the code where we relied on coordinate
2387         transforms via NSViews (which ignore CSS transforms).
2388
2389         * WebCore.exp.in:
2390         * platform/Widget.cpp:
2391         (WebCore::Widget::setBoundsSize):
2392         * platform/Widget.h:
2393         * platform/mac/WidgetMac.mm:
2394         (WebCore::Widget::setBoundsSize):
2395         (WebCore::Widget::paint):
2396         * rendering/RenderLayerCompositor.cpp:
2397         (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
2398         * rendering/RenderWidget.cpp:
2399         (WebCore::RenderWidget::setWidgetGeometry):
2400         (WebCore::RenderWidget::setWidget):
2401         (WebCore::RenderWidget::updateWidgetPosition):
2402         * rendering/RenderWidget.h:
2403
2404 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
2405
2406         Reviewed by Dan Bernstein.
2407
2408         RenderView needs to take transforms on its layer into account
2409         https://bugs.webkit.org/show_bug.cgi?id=52536
2410         
2411         The RenderView's coordinate mapping methods failed to
2412         take into account a transform on the RenderView's layer.
2413
2414         No tests because it's not possible to get a transform
2415         on the RenderView's layer through content.
2416
2417         * rendering/RenderView.cpp:
2418         (WebCore::RenderView::mapLocalToContainer):
2419         (WebCore::RenderView::mapAbsoluteToLocalPoint):
2420
2421 2011-01-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2422
2423         Unreviewed, rolling out r75708.
2424         http://trac.webkit.org/changeset/75708
2425         https://bugs.webkit.org/show_bug.cgi?id=52521
2426
2427         Breaks Qt build if mobility is not installed. (Requested by
2428         benjaminp on #webkit).
2429
2430         * WebCore.pro:
2431         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
2432         (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
2433         * platform/graphics/qt/MediaPlayerPrivateQt.h:
2434         (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
2435
2436 2011-01-15  David Kilzer  <ddkilzer@apple.com>
2437
2438         <http://webkit.org/b/52512> REGRESSION(r73818): range.cloneContents() ignores end offset
2439
2440         Reviewed by Adele Peterson.
2441
2442         The fix for Bug 50710 in r73799 introduced an off-by-one error
2443         when copying nodes to a local NodeVector for processing.  A fix
2444         was attempted for Bug 50854 in r73818, but instead of stopping
2445         at the end offset, it iterates through all the sibling nodes
2446         because the loop variable (i) is never incremented.  To clean
2447         this up, revert back to the code in r73799 and fix the
2448         off-by-one error.
2449
2450         Test: fast/dom/Range/range-clone-contents.html
2451
2452         * dom/Range.cpp:
2453         (WebCore::Range::processContents): Fix the loop that copies
2454         nodes to a local NodeVector by restoring the code from r73799
2455         and fixing the off-by-one error.
2456
2457 2011-01-15  Adam Barth  <abarth@webkit.org>
2458
2459         Rubber-stamped by Eric Seidel.
2460
2461         Move WebKit2 into Source
2462         https://bugs.webkit.org/show_bug.cgi?id=52438
2463
2464         * WebCore.pro:
2465
2466 2011-01-15  Joone Hur  <joone.hur@collabora.co.uk>
2467
2468         Reviewed by Martin Robinson.
2469
2470         [GTK] Linux build with FileSystem API enabled fails
2471         https://bugs.webkit.org/show_bug.cgi?id=43878
2472
2473         This patch allows WebKitGtk+ to build with FileSystem API option.
2474
2475         No new tests because no new functionality.
2476
2477         * GNUmakefile.am: Included AsyncFileSystem.h,cpp and Excluded duplicated JSFileException.h,cpp.
2478         * bindings/js/JSDirectoryEntryCustom.cpp: Included ExceptionCode.h.
2479
2480 2011-01-14  Sam Magnuson  <smagnuso@gmail.com>
2481
2482         Reviewed by Kenneth Rohde Christiansen.
2483
2484         [Qt] Compile with QT_NO_GRAPHICSVIEW
2485         https://bugs.webkit.org/show_bug.cgi?id=49750
2486
2487         * platform/graphics/qt/GraphicsLayerQt.cpp:
2488         * platform/graphics/qt/GraphicsLayerQt.h:
2489         * platform/qt/PlatformMouseEventQt.cpp:
2490
2491 2011-01-14  Tony Chang  <tony@chromium.org>
2492
2493         Reviewed by Alexey Proskuryakov.
2494
2495         Strip NUL character when copying text on Windows
2496         https://bugs.webkit.org/show_bug.cgi?id=52236
2497
2498         Test: editing/pasteboard/copy-null-characters.html
2499
2500         * editing/Editor.cpp:
2501         (WebCore::Editor::selectedText):
2502         * platform/mac/PasteboardMac.mm:
2503         (WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
2504
2505 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
2506
2507         Reviewed by Antti Koivisto.
2508
2509         Rename cache() to memoryCache()
2510         https://bugs.webkit.org/show_bug.cgi?id=52433
2511
2512         No new tests because the behavior remains the same.
2513
2514         * WebCore.exp.in:
2515         * WebCore.order:
2516         * history/PageCache.cpp:
2517         (WebCore::PageCache::releaseAutoreleasedPagesNow):
2518         * inspector/InspectorResourceAgent.cpp:
2519         (WebCore::InspectorResourceAgent::cachedResource):
2520         * loader/FrameLoader.cpp:
2521         (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
2522         * loader/archive/cf/LegacyWebArchive.cpp:
2523         (WebCore::LegacyWebArchive::create):
2524         * loader/cache/CachedImage.cpp:
2525         (WebCore::CachedImage::allClientsRemoved):
2526         (WebCore::CachedImage::data):
2527         * loader/cache/CachedResource.cpp:
2528         (WebCore::CachedResource::~CachedResource):
2529         (WebCore::CachedResource::addClientToSet):
2530         (WebCore::CachedResource::removeClient):
2531         (WebCore::CachedResource::setDecodedSize):
2532         (WebCore::CachedResource::setEncodedSize):
2533         (WebCore::CachedResource::didAccessDecodedData):
2534         * loader/cache/CachedResourceLoader.cpp:
2535         (WebCore::CachedResourceLoader::CachedResourceLoader):
2536         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
2537         (WebCore::CachedResourceLoader::requestResource):
2538         (WebCore::CachedResourceLoader::revalidateResource):
2539         (WebCore::CachedResourceLoader::loadResource):
2540         (WebCore::CachedResourceLoader::clearPreloads):
2541         (WebCore::CachedResourceLoader::printPreloadStats):
2542         * loader/cache/CachedResourceRequest.cpp:
2543         (WebCore::CachedResourceRequest::load):
2544         (WebCore::CachedResourceRequest::didFail):
2545         (WebCore::CachedResourceRequest::didReceiveResponse):
2546         * loader/cache/MemoryCache.cpp:
2547         (WebCore::memoryCache):
2548         * loader/cache/MemoryCache.h:
2549
2550 2011-01-14  Dan Bernstein  <mitz@apple.com>
2551
2552         Reviewed by Simon Fraser.
2553
2554         WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
2555
2556         * WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and
2557         RenderWidget::resumeWidgetHierarchyUpdates().
2558         * manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
2559         * rendering/RenderWidget.cpp:
2560         (WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
2561         are disabled. When this assertion was added, this condition was a subset of the “calling out to
2562         plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
2563         change now suspends widget hierarchy updates even at times where plug-in code is expected to be
2564         called, which invalidates the assertion.
2565
2566 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2567
2568         Unreviewed build fix.
2569
2570         Fix Qt build after r75837
2571         https://bugs.webkit.org/show_bug.cgi?id=52494
2572
2573         * rendering/style/StyleRareInheritedData.cpp:
2574         * rendering/style/StyleRareNonInheritedData.cpp:
2575
2576 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2577
2578         Unreviewed build fix.
2579
2580         Fix Qt build after r75837
2581         https://bugs.webkit.org/show_bug.cgi?id=52494
2582
2583         * rendering/style/RenderStyle.cpp:
2584
2585 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2586
2587         Unreviewed build fix.
2588
2589         Fix Qt build after r75837
2590         https://bugs.webkit.org/show_bug.cgi?id=52494
2591
2592         * editing/EditorCommand.cpp:
2593
2594 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2595
2596         Unreviewed build fix.
2597
2598         Fix Qt build after r75837
2599         https://bugs.webkit.org/show_bug.cgi?id=52494
2600
2601         * editing/ApplyStyleCommand.cpp:
2602
2603 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2604
2605         Unreviewed build fix.
2606
2607         Fix Qt build after r75837
2608         https://bugs.webkit.org/show_bug.cgi?id=52494
2609
2610         * css/CSSStyleSelector.cpp:
2611
2612 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2613
2614         Unreviewed build fix.
2615
2616         Fix Qt build after r75837
2617         https://bugs.webkit.org/show_bug.cgi?id=52494
2618
2619         * rendering/InlineFlowBox.h:
2620         * rendering/RenderBoxModelObject.h:
2621
2622 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2623
2624         Reviewed by David Levin.
2625
2626         Do some forward declaration in RenderStyle.h
2627         https://bugs.webkit.org/show_bug.cgi?id=52453
2628
2629         No new tests because no new functionality.
2630
2631         * css/CSSComputedStyleDeclaration.cpp:
2632         * css/CSSStyleSelector.cpp:
2633         * editing/Editor.cpp:
2634         * page/EventHandler.cpp:
2635         * rendering/EllipsisBox.cpp:
2636         * rendering/InlineBox.cpp:
2637         * rendering/InlineTextBox.cpp:
2638         * rendering/RenderBlock.cpp:
2639         * rendering/RenderBlock.h:
2640         * rendering/RenderBox.cpp:
2641         * rendering/RenderBox.h:
2642         * rendering/RenderEmbeddedObject.cpp:
2643         * rendering/RenderFieldset.cpp:
2644         * rendering/RenderFileUploadControl.cpp:
2645         * rendering/RenderFrameSet.cpp:
2646         * rendering/RenderHTMLCanvas.cpp:
2647         * rendering/RenderImageResource.cpp:
2648         * rendering/RenderInputSpeech.cpp:
2649         * rendering/RenderLayer.h:
2650         * rendering/RenderLineBoxList.cpp:
2651         * rendering/RenderListBox.cpp:
2652         * rendering/RenderMediaControlsChromium.cpp:
2653         * rendering/RenderObject.cpp:
2654         * rendering/RenderObject.h:
2655         * rendering/RenderObjectChildList.cpp:
2656         * rendering/RenderProgress.cpp:
2657         * rendering/RenderScrollbarPart.cpp:
2658         * rendering/RenderTable.cpp:
2659         * rendering/RenderTable.h:
2660         * rendering/RenderTableCell.cpp:
2661         * rendering/RenderTableRow.cpp:
2662         * rendering/RenderTableSection.cpp:
2663         * rendering/RenderTheme.cpp:
2664         * rendering/RenderThemeChromiumSkia.cpp:
2665         * rendering/RenderThemeChromiumWin.cpp:
2666         * rendering/RootInlineBox.cpp:
2667         * rendering/style/RenderStyle.cpp:
2668         * rendering/style/RenderStyle.h:
2669         * rendering/style/StyleRareInheritedData.cpp:
2670
2671 2011-01-14  Ryosuke Niwa  <rniwa@webkit.org>
2672
2673         Reviewed by Eric Seidel.
2674
2675         Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
2676         BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
2677         https://bugs.webkit.org/show_bug.cgi?id=52481
2678
2679         Removed instantiation of legacy editing positions.
2680         Calls to Position::Position are replaced by calls to Position's convenience functions.
2681         
2682         Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
2683         they instantiate right positions for text nodes.
2684
2685         * accessibility/AccessibilityRenderObject.cpp:
2686         (WebCore::AccessibilityRenderObject::setSelectedTextRange):
2687         * dom/Element.cpp:
2688         (WebCore::Element::updateFocusAppearance):
2689         * editing/BreakBlockquoteCommand.cpp:
2690         (WebCore::BreakBlockquoteCommand::doApply):
2691         * editing/CompositeEditCommand.cpp:
2692         (WebCore::CompositeEditCommand::inputText):
2693         (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
2694         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
2695         (WebCore::CompositeEditCommand::moveParagraphs):
2696         (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
2697         (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
2698         (WebCore::CompositeEditCommand::splitTreeToNode):
2699         * editing/DeleteButtonController.cpp:
2700         (WebCore::enclosingDeletableElement):
2701         * editing/htmlediting.h:
2702         (WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of
2703         positionBeforeNode for a text node.
2704         (WebCore::lastPositionInOrAfterNode): Ditto.
2705
2706 2011-01-14  Helder Correia  <helder@sencha.com>
2707
2708         Reviewed by Simon Fraser.
2709
2710         Shadow is not drawn when filling a path with a gradient
2711         https://bugs.webkit.org/show_bug.cgi?id=51982
2712
2713         This happens in CG and is related to bug 51869, this time to be fixed
2714         in GraphicsContext::fillPath(const Path& path). We need to draw the
2715         gradient clipped to the path on a CGLayer first, and then draw the
2716         layer on the GraphicsContext.
2717
2718         Test: fast/canvas/canvas-fillPath-gradient-shadow.html
2719
2720         * platform/graphics/cg/GraphicsContextCG.cpp:
2721         (WebCore::GraphicsContext::fillPath):
2722
2723 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
2724
2725         Reviewed by Adam Roben.
2726
2727         Layer syncing should go through the compositor
2728         https://bugs.webkit.org/show_bug.cgi?id=52486
2729
2730         Rather than have FrameView go directly to GraphicsLayer to
2731         sync pending changes, route the call through RenderLayerCompositor.
2732         
2733         Add a FIXME about an existing issue with flushing and subframes.
2734         
2735         No behavior change, so no tests.
2736
2737         * page/FrameView.cpp:
2738         (WebCore::FrameView::syncCompositingStateForThisFrame):
2739         * rendering/RenderLayerBacking.cpp:
2740         (WebCore::RenderLayerBacking::notifySyncRequired):
2741         * rendering/RenderLayerCompositor.cpp:
2742         (WebCore::RenderLayerCompositor::scheduleLayerFlush):
2743         (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
2744         * rendering/RenderLayerCompositor.h:
2745         (WebCore::RenderLayerCompositor::notifySyncRequired):
2746
2747 2011-01-14  Abhishek Arya  <inferno@chromium.org>
2748
2749         Reviewed by David Hyatt.
2750
2751         Fix parent block calculation when trying to find top most node
2752         containing "this" float.
2753         https://bugs.webkit.org/show_bug.cgi?id=51711
2754
2755         Replace use of containingBlock and traverse the parents directly
2756         to check for float existence. containingBlock can skip parents and
2757         jump to the RenderView directly which will cause floats to not get
2758         cleared from intermediate parents.
2759
2760         Test: fast/block/float/floats-not-cleared-crash.html
2761
2762         * rendering/RenderBox.cpp:
2763         (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
2764
2765 2011-01-14  Adam Klein  <adamk@chromium.org>
2766
2767         Reviewed by Darin Fisher.
2768
2769         [Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
2770         https://bugs.webkit.org/show_bug.cgi?id=42237
2771
2772         Remove Chromium-specific implementation from WebCore.
2773
2774         No tests added; this refactor should be covered by existing history-exercising tests.
2775
2776         * WebCore.gyp/WebCore.gyp:
2777         * WebCore.gypi:
2778         * history/BackForwardListChromium.cpp: Removed.
2779         * history/BackForwardListImpl.h:
2780
2781 2011-01-12  Satish Sampath  <satish@chromium.org>
2782
2783         Reviewed by Dimitri Glazkov.
2784
2785         Fix a crash when accessing speech input from script.
2786         https://bugs.webkit.org/show_bug.cgi?id=52325
2787
2788         Test: fast/speech/speech-input-scripting.html
2789
2790         * html/HTMLInputElement.cpp:
2791         (WebCore::HTMLInputElement::parseMappedAttribute): Recreate renderer when speech input is enabled/disabled.
2792         * rendering/RenderTextControlSingleLine.cpp: Remove unused code.
2793         * rendering/RenderTextControlSingleLine.h:
2794         * rendering/TextControlInnerElements.cpp: Take self references before firing events and check for renderer validity after.
2795         (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
2796         (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
2797         (WebCore::InputFieldSpeechButtonElement::detach):
2798
2799 2011-01-14  Abhishek Arya  <inferno@chromium.org>
2800
2801         Reviewed by David Hyatt.
2802
2803         Prevent merging of anonymous blocks if one of them is already getting
2804         destroyed.
2805         https://bugs.webkit.org/show_bug.cgi?id=52402
2806
2807         Test: fast/block/merge-anonymous-block-remove-child-crash2.html
2808
2809         * rendering/RenderBlock.cpp:
2810         (WebCore::RenderBlock::RenderBlock): initialize m_beingDestroyed to false.
2811         (WebCore::RenderBlock::destroy): set m_beingDestroyed to true.
2812         (WebCore::canMergeContiguousAnonymousBlocks): do not merge if any or prev or next is being destroyed.
2813         (WebCore::RenderBlock::removeChild): remove the hack previously done for preventing oldChild merging with nextBlock's next sibling.
2814         * rendering/RenderBlock.h:
2815         (WebCore::RenderBlock::beingDestroyed): public function for m_beingDestroyed.
2816
2817 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
2818
2819         Not reviewed. Follow up to r75791: fix missing dispatch.
2820         https://bugs.webkit.org/show_bug.cgi?id=52442
2821
2822         * inspector/front-end/DebuggerModel.js:
2823         (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
2824
2825 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
2826
2827         Reviewed by Adam Roben.
2828
2829         Issues with contentsScale in GraphicsLayerCA
2830         https://bugs.webkit.org/show_bug.cgi?id=52463
2831
2832         Fix various issues with the recent contentsScale changes:
2833
2834         * platform/graphics/ca/GraphicsLayerCA.cpp:
2835         (WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1.
2836         (WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay()
2837         if the layer draws content, otherwise we'll create backing store for empty layers.
2838         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale
2839         on the new (tiled or untiled) layer.
2840         (WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.
2841
2842 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
2843
2844         Let Xcode have it's way with the project file.
2845
2846         * WebCore.xcodeproj/project.pbxproj:
2847
2848 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
2849
2850         Reviewed by Anders Carlsson.
2851
2852         Refactor some FrameView::syncCompositingState code
2853         https://bugs.webkit.org/show_bug.cgi?id=52459
2854
2855         Refactor some code in FrameView related to synchronizing
2856         compositing layer state.
2857         
2858         * page/FrameView.cpp:
2859         (WebCore::FrameView::syncCompositingStateForThisFrame):
2860         (WebCore::FrameView::syncCompositingStateRecursive):
2861         (WebCore::FrameView::paintContents):
2862         * page/FrameView.h:
2863
2864 2011-01-14  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2865
2866         Reviewed by Eric Seidel.
2867
2868         [Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
2869         https://bugs.webkit.org/show_bug.cgi?id=30179
2870
2871         * plugins/symbian/PluginViewSymbian.cpp:
2872
2873 2011-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2874
2875         Reviewed by Martin Robinson.
2876
2877         [GTK] Add volume slider to media player
2878         https://bugs.webkit.org/show_bug.cgi?id=51532
2879
2880         * css/mediaControlsGtk.css:
2881         (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
2882         (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
2883         (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
2884         * platform/gtk/RenderThemeGtk.cpp:
2885         (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
2886         (WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
2887         (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
2888         (WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
2889         * platform/gtk/RenderThemeGtk.h:
2890         * platform/gtk/RenderThemeGtk2.cpp:
2891         (WebCore::RenderThemeGtk::paintSliderTrack):
2892         (WebCore::RenderThemeGtk::paintSliderThumb):
2893         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
2894         * platform/gtk/RenderThemeGtk3.cpp:
2895         (WebCore::RenderThemeGtk::paintSliderTrack):
2896         (WebCore::RenderThemeGtk::paintSliderThumb):
2897         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
2898
2899 2011-01-14  Joone Hur  <joone.hur@collabora.co.uk>
2900
2901         Reviewed by David Levin.
2902
2903         [GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
2904         https://bugs.webkit.org/show_bug.cgi?id=52434
2905
2906         No new tests. This code will be tested when an implementation 
2907         of beginDragWithFiles is complete. 
2908
2909         * platform/gtk/FileSystemGtk.cpp:
2910         (WebCore::filenameToString): Use GOwnPtr instead of gchar pointer.
2911         (WebCore::fileSystemRepresentation): Ditto.
2912         (WebCore::filenameForDisplay): Ditto.
2913         (WebCore::pathGetFileName): Ditto.
2914
2915 2011-01-14  Pavel Podivilov  <podivilov@chromium.org>
2916
2917         Reviewed by Yury Semikhatsky.
2918
2919         Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload.
2920         https://bugs.webkit.org/show_bug.cgi?id=52215
2921
2922         * inspector/front-end/Breakpoint.js:
2923         (WebInspector.Breakpoint):
2924         (WebInspector.Breakpoint.prototype.populateLabelElement):
2925         * inspector/front-end/Script.js:
2926         (WebInspector.Script.prototype.get linesCount):
2927         (WebInspector.Script.prototype.sourceLine):
2928         (WebInspector.Script.prototype.sourceLine.didRequestSource):
2929         (WebInspector.Script.prototype.set source):
2930         (WebInspector.Script.prototype.requestSource.didGetScriptSource):
2931         (WebInspector.Script.prototype.requestSource):
2932         * inspector/front-end/ScriptView.js:
2933         (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded.didRequestSource):
2934         (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
2935         * inspector/front-end/SourceFrame.js:
2936         (WebInspector.SourceFrame.prototype._addBreakpoint):
2937         * inspector/front-end/utilities.js:
2938         (String.prototype.findAll):
2939
2940 2011-01-14  Pavel Podivilov  <podivilov@chromium.org>
2941
2942         Reviewed by Yury Semikhatsky.
2943
2944         Web Inspector: provide script column offset to frontend.
2945         https://bugs.webkit.org/show_bug.cgi?id=52377
2946
2947         * bindings/js/ScriptDebugServer.cpp:
2948         (WebCore::ScriptDebugServer::dispatchDidParseSource):
2949         * bindings/js/ScriptSourceCode.h:
2950         (WebCore::ScriptSourceCode::ScriptSourceCode):
2951         * bindings/v8/DebuggerScript.js:
2952         ():
2953         * bindings/v8/ScriptDebugServer.cpp:
2954         (WebCore::ScriptDebugServer::dispatchDidParseSource):
2955         * inspector/Inspector.idl:
2956         * inspector/InspectorDebuggerAgent.cpp:
2957         (WebCore::InspectorDebuggerAgent::didParseSource):
2958         * inspector/InspectorDebuggerAgent.h:
2959         * inspector/ScriptDebugListener.h:
2960         * inspector/front-end/DebuggerModel.js:
2961         (WebInspector.DebuggerModel.prototype.parsedScriptSource):
2962         * inspector/front-end/Script.js:
2963         (WebInspector.Script):
2964
2965 2011-01-14  Ilya Tikhonovsky  <loislo@chromium.org>
2966
2967         Unreviewed one line fix for console-xhr-logging test.
2968
2969         The problem was introduced at r75788.
2970
2971         * inspector/InspectorBrowserDebuggerAgent.cpp:
2972         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
2973
2974 2011-01-13  Yury Semikhatsky  <yurys@chromium.org>
2975
2976         Reviewed by Pavel Feldman.
2977
2978         Web Inspector: extract console related functionality into InspectorConsoleAgent
2979         https://bugs.webkit.org/show_bug.cgi?id=52282
2980
2981         * CMakeLists.txt:
2982         * GNUmakefile.am:
2983         * WebCore.gypi:
2984         * WebCore.pro:
2985         * inspector/CodeGeneratorInspector.pm:
2986         * inspector/ConsoleMessage.cpp:
2987         (WebCore::ConsoleMessage::~ConsoleMessage):
2988         * inspector/ConsoleMessage.h:
2989         * inspector/Inspector.idl:
2990         * inspector/InspectorConsoleAgent.cpp: Added.
2991         (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
2992         (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
2993         (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
2994         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
2995         (WebCore::InspectorConsoleAgent::reset):
2996         (WebCore::InspectorConsoleAgent::setFrontend):
2997         (WebCore::InspectorConsoleAgent::addMessageToConsole):
2998         (WebCore::InspectorConsoleAgent::startTiming):
2999         (WebCore::InspectorConsoleAgent::stopTiming):
3000         (WebCore::InspectorConsoleAgent::count):
3001         (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
3002         (WebCore::InspectorConsoleAgent::didReceiveResponse):
3003         (WebCore::InspectorConsoleAgent::didFailLoading):
3004         (WebCore::InspectorConsoleAgent::addConsoleMessage):
3005         * inspector/InspectorConsoleAgent.h: Added.
3006         * inspector/InspectorController.cpp:
3007         (WebCore::InspectorController::InspectorController):
3008         (WebCore::InspectorController::clearConsoleMessages):
3009         (WebCore::InspectorController::connectFrontend):
3010         (WebCore::InspectorController::disconnectFrontend):
3011         (WebCore::InspectorController::didCommitLoad):
3012         * inspector/InspectorController.h:
3013         (WebCore::InspectorController::consoleAgent):
3014         * inspector/InspectorInstrumentation.cpp:
3015         (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
3016         (WebCore::InspectorInstrumentation::didFailLoadingImpl):
3017         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
3018         (WebCore::InspectorInstrumentation::addMessageToConsole):
3019         (WebCore::InspectorInstrumentation::count):
3020         (WebCore::InspectorInstrumentation::startTiming):
3021         (WebCore::InspectorInstrumentation::stopTiming):
3022         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
3023         * inspector/InspectorInstrumentation.h:
3024         * inspector/InspectorProfilerAgent.cpp:
3025         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
3026         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
3027         * inspector/front-end/ConsoleView.js:
3028         (WebInspector.ConsoleView):
3029         (WebInspector.ConsoleView.prototype.addConsoleMessage):
3030         (WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount):
3031         (WebInspector.ConsoleView.prototype.consoleMessagesCleared):
3032         * inspector/front-end/inspector.js:
3033         * page/Console.cpp:
3034         (WebCore::Console::addMessage):
3035         (WebCore::Console::count):
3036         (WebCore::Console::profile):
3037         (WebCore::Console::time):
3038         (WebCore::Console::timeEnd):
3039         (WebCore::Console::group):
3040         (WebCore::Console::groupCollapsed):
3041         (WebCore::Console::groupEnd):
3042         * page/Console.h:
3043         * page/Console.idl:
3044
3045 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
3046
3047         Reviewed by Yury Semikhatsky.
3048
3049         Web Inspector: do not use this as protocol message
3050         dispatcher in models / agents.
3051         https://bugs.webkit.org/show_bug.cgi?id=52442
3052
3053         Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
3054         There should be a clear way to tell whether method is being called
3055         from within front-end or by the backend.
3056
3057         * inspector/front-end/DOMAgent.js:
3058         (WebInspector.DOMAgent):
3059         (WebInspector.DOMAgent.prototype.nodeForId):
3060         (WebInspector.DOMAgent.prototype._bindNodes):
3061         (WebInspector.DOMAgent.prototype._removeBreakpoints):
3062         (WebInspector.DOMDispatcher):
3063         (WebInspector.DOMDispatcher.prototype.setDocument):
3064         (WebInspector.DOMDispatcher.prototype.attributesUpdated):
3065         (WebInspector.DOMDispatcher.prototype.characterDataModified):
3066         (WebInspector.DOMDispatcher.prototype.setChildNodes):
3067         (WebInspector.DOMDispatcher.prototype.setDetachedRoot):
3068         (WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
3069         (WebInspector.DOMDispatcher.prototype.childNodeInserted):
3070         (WebInspector.DOMDispatcher.prototype.childNodeRemoved):
3071         (WebInspector.DOMDispatcher.prototype.didCommitLoad):
3072         (WebInspector.ApplicationCacheDispatcher):
3073         (WebInspector.ApplicationCacheDispatcher.prototype.getApplicationCachesAsync):
3074         (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
3075         (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
3076         * inspector/front-end/DOMStorage.js:
3077         (WebInspector.DOMStorageDispatcher):
3078         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3079         (WebInspector.DOMStorageDispatcher.prototype.selectDOMStorage):
3080         (WebInspector.DOMStorageDispatcher.prototype.updateDOMStorage):
3081         * inspector/front-end/Database.js:
3082         (WebInspector.Database.prototype.executeSql):
3083         (WebInspector.DatabaseDispatcher):
3084         (WebInspector.DatabaseDispatcher.prototype.addDatabase):
3085         (WebInspector.DatabaseDispatcher.prototype.selectDatabase):
3086         (WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
3087         (WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
3088         * inspector/front-end/DebuggerModel.js:
3089         (WebInspector.DebuggerModel):
3090         (WebInspector.DebuggerModel.prototype._pausedScript):
3091         (WebInspector.DebuggerModel.prototype._resumedScript):
3092         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
3093         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
3094         (WebInspector.DebuggerDispatcher):
3095         (WebInspector.DebuggerDispatcher.prototype.pausedScript):
3096         (WebInspector.DebuggerDispatcher.prototype.resumedScript):
3097         (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
3098         (WebInspector.DebuggerDispatcher.prototype.failedToParseScriptSource):
3099         * inspector/front-end/FileSystemView.js:
3100         (WebInspector.FileSystemDispatcher):
3101         (WebInspector.FileSystemDispatcher.prototype.getFileSystemPathsAsync):
3102         (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemPath):
3103         (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemError):
3104         (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemDisabled):
3105         * inspector/front-end/ProfilesPanel.js:
3106         (WebInspector.ProfilesPanel):
3107         (WebInspector.ProfilesPanel.prototype._addProfileHeader):
3108         (WebInspector.ProfilesPanel.prototype._removeProfileHeader):
3109         (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
3110         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
3111         (WebInspector.ProfilesPanel.prototype._setRecordingProfile):
3112         (WebInspector.ProfilerDispatcher):
3113         (WebInspector.ProfilerDispatcher.prototype.profilerWasEnabled):
3114         (WebInspector.ProfilerDispatcher.prototype.profilerWasDisabled):
3115         (WebInspector.ProfilerDispatcher.prototype.resetProfiles):
3116         (WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
3117         (WebInspector.ProfilerDispatcher.prototype.addHeapSnapshotChunk):
3118         (WebInspector.ProfilerDispatcher.prototype.finishHeapSnapshot):
3119         (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
3120         (WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
3121         * inspector/front-end/ResourceTreeModel.js:
3122         (WebInspector.ResourceTreeModel):
3123         * inspector/front-end/TimelinePanel.js:
3124         (WebInspector.TimelinePanel):
3125         (WebInspector.TimelinePanel.prototype._timelineProfilerWasStarted):
3126         (WebInspector.TimelinePanel.prototype._timelineProfilerWasStopped):
3127         (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
3128         (WebInspector.TimelineDispatcher):
3129         (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStarted):
3130         (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStopped):
3131         (WebInspector.TimelineDispatcher.prototype.addRecordToTimeline):
3132
3133 2011-01-14  Csaba Osztrogonác  <ossy@webkit.org>
3134
3135         [Qt][V8] Unreviewed buildfix after r75788.
3136
3137         * inspector/InspectorBrowserDebuggerAgent.cpp:
3138
3139 2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>
3140
3141         Reviewed by Yury Semikhatsky.
3142
3143         Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
3144         We have some methods of Debugger which are related to DOM.
3145         Lets extract these methods to BrowserDebugger agent.
3146
3147         http://bugs.webkit.org/show_bug.cgi?id=52294
3148
3149         * CMakeLists.txt:
3150         * WebCore.gypi:
3151         * WebCore.pro:
3152         * WebCore.vcproj/WebCore.vcproj:
3153         * WebCore.xcodeproj/project.pbxproj:
3154         * inspector/CodeGeneratorInspector.pm:
3155         * inspector/Inspector.idl:
3156         * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
3157         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
3158         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
3159         (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
3160         (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
3161         (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
3162         (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
3163         (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
3164         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
3165         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
3166         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
3167         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
3168         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
3169         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
3170         (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
3171         (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
3172         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
3173         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
3174         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
3175         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
3176         (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
3177         * inspector/InspectorBrowserDebuggerAgent.h: Added.
3178         (WebCore::InspectorBrowserDebuggerAgent::create):
3179         * inspector/InspectorController.cpp:
3180         (WebCore::InspectorController::InspectorController):
3181         (WebCore::InspectorController::inspectedPageDestroyed):
3182         (WebCore::InspectorController::didCommitLoad):
3183         (WebCore::InspectorController::enableDebuggerFromFrontend):
3184         (WebCore::InspectorController::disableDebugger):
3185         (WebCore::InspectorController::restoreStickyBreakpoints):
3186         (WebCore::InspectorController::restoreStickyBreakpoint):
3187         * inspector/InspectorController.h:
3188         * inspector/InspectorDOMAgent.cpp:
3189         (WebCore::InspectorDOMAgent::discardBindings):
3190         (WebCore::InspectorDOMAgent::didInsertDOMNode):
3191         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
3192         * inspector/InspectorDOMAgent.h:
3193         * inspector/InspectorInstrumentation.cpp:
3194         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
3195         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
3196         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
3197         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
3198         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
3199         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
3200         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
3201
3202 2011-01-14  Andrey Kosyakov  <caseq@chromium.org>
3203
3204         Reviewed by Pavel Feldman.
3205
3206         Web Inspector: redirected resources not handled properly in Network panel
3207         https://bugs.webkit.org/show_bug.cgi?id=52292
3208
3209         * inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
3210         * inspector/InspectorInstrumentation.cpp: Ditto.
3211         (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
3212         * inspector/InspectorResourceAgent.cpp: Ditto.
3213         (WebCore::InspectorResourceAgent::identifierForInitialRequest):
3214         * inspector/InspectorResourceAgent.h: Ditto.
3215         * inspector/InspectorInstrumentation.cpp: Ditto.
3216         (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
3217         * inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
3218         * inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource
3219         (WebInspector.ConsoleMessage.prototype._formatMessage):
3220         * inspector/front-end/ExtensionServer.js: Ditto.
3221         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
3222         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
3223         * inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map
3224         (WebInspector.HARLog.prototype.build):
3225         (WebInspector.HARLog.prototype._convertResource):
3226         * inspector/front-end/NetworkManager.js:
3227         (WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource.
3228         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
3229         (WebInspector.NetworkManager.prototype.willSendRequest):
3230         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
3231         (WebInspector.NetworkManager.prototype.setInitialContent):
3232         (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
3233         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
3234         (WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel
3235         (WebInspector.NetworkManager.prototype._appendRedirect):
3236         * inspector/front-end/NetworkPanel.js:
3237         (WebInspector.NetworkPanel):
3238         (WebInspector.NetworkPanel.prototype.get resources):
3239         (WebInspector.NetworkPanel.prototype.resourceById):
3240         (WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added.
3241         (WebInspector.NetworkPanel.prototype.refreshResource): ditto.
3242         (WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
3243         * inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation.
3244         (WebInspector.ResourceTreeModel.prototype._clearResources):
3245         (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
3246         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
3247         (WebInspector.ResourceTreeModel.prototype.createResource):
3248         * inspector/front-end/inspector.js:
3249         (WebInspector.resourceById):
3250
3251 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3252
3253         Unreviewed, rolling out r75783.
3254         http://trac.webkit.org/changeset/75783
3255         https://bugs.webkit.org/show_bug.cgi?id=52439
3256
3257         a bit strange but the same patch have broken mac builds at
3258         linking stage. (Requested by loislo2 on #webkit).
3259
3260         * CMakeLists.txt:
3261         * GNUmakefile.am:
3262         * WebCore.gypi:
3263         * WebCore.pro:
3264         * WebCore.vcproj/WebCore.vcproj:
3265         * WebCore.xcodeproj/project.pbxproj:
3266         * inspector/CodeGeneratorInspector.pm:
3267         * inspector/Inspector.idl:
3268         * inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
3269         * inspector/InspectorBrowserDebuggerAgent.h: Removed.
3270         * inspector/InspectorController.cpp:
3271         (WebCore::InspectorController::InspectorController):
3272         (WebCore::InspectorController::inspectedPageDestroyed):
3273         (WebCore::InspectorController::didCommitLoad):
3274         (WebCore::InspectorController::enableDebuggerFromFrontend):
3275         (WebCore::InspectorController::disableDebugger):
3276         (WebCore::InspectorController::restoreStickyBreakpoints):
3277         (WebCore::InspectorController::restoreStickyBreakpoint):
3278         (WebCore::InspectorController::setEventListenerBreakpoint):
3279         (WebCore::InspectorController::removeEventListenerBreakpoint):
3280         (WebCore::InspectorController::hasEventListenerBreakpoint):
3281         (WebCore::InspectorController::setXHRBreakpoint):
3282         (WebCore::InspectorController::removeXHRBreakpoint):
3283         (WebCore::InspectorController::hasXHRBreakpoint):
3284         * inspector/InspectorController.h:
3285         * inspector/InspectorDOMAgent.cpp:
3286         (WebCore::InspectorDOMAgent::discardBindings):
3287         (WebCore::InspectorDOMAgent::setDOMBreakpoint):
3288         (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
3289         (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
3290         (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
3291         (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
3292         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
3293         (WebCore::InspectorDOMAgent::didInsertDOMNode):
3294         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
3295         (WebCore::InspectorDOMAgent::hasBreakpoint):
3296         (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
3297         * inspector/InspectorDOMAgent.h:
3298         * inspector/InspectorInstrumentation.cpp:
3299         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
3300         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
3301         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
3302         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
3303         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
3304         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
3305         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
3306
3307 2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>
3308
3309         Reviewed by Yury Semikhatsky.
3310
3311         Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
3312         We have some methods of Debugger which are related to DOM.
3313         Lets extract these methods to BrowserDebugger agent.
3314
3315         http://bugs.webkit.org/show_bug.cgi?id=52294
3316
3317         * CMakeLists.txt:
3318         * WebCore.gypi:
3319         * WebCore.pro:
3320         * WebCore.vcproj/WebCore.vcproj:
3321         * WebCore.xcodeproj/project.pbxproj:
3322         * inspector/CodeGeneratorInspector.pm:
3323         * inspector/Inspector.idl:
3324         * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
3325         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
3326         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
3327         (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
3328         (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
3329         (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
3330         (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
3331         (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
3332         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
3333         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
3334         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
3335         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
3336         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
3337         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
3338         (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
3339         (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
3340         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
3341         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
3342         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
3343         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
3344         (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
3345         * inspector/InspectorBrowserDebuggerAgent.h: Added.
3346         (WebCore::InspectorBrowserDebuggerAgent::create):
3347         * inspector/InspectorController.cpp:
3348         (WebCore::InspectorController::InspectorController):
3349         (WebCore::InspectorController::inspectedPageDestroyed):
3350         (WebCore::InspectorController::didCommitLoad):
3351         (WebCore::InspectorController::enableDebuggerFromFrontend):
3352         (WebCore::InspectorController::disableDebugger):
3353         (WebCore::InspectorController::restoreStickyBreakpoints):
3354         (WebCore::InspectorController::restoreStickyBreakpoint):
3355         * inspector/InspectorController.h:
3356         * inspector/InspectorDOMAgent.cpp:
3357         (WebCore::InspectorDOMAgent::discardBindings):
3358         (WebCore::InspectorDOMAgent::didInsertDOMNode):
3359         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
3360         * inspector/InspectorDOMAgent.h:
3361         * inspector/InspectorInstrumentation.cpp:
3362         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
3363         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
3364         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
3365         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
3366         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
3367         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
3368         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
3369
3370 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
3371
3372         Not reviewed: build fix.
3373
3374         * WebCore.vcproj/WebCore.vcproj:
3375
3376 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
3377
3378         Reviewed by Yury Semikhatsky.
3379
3380         Web Inspector: extract InspectorSettings from InspectorState,
3381         simplify it.
3382         https://bugs.webkit.org/show_bug.cgi?id=52429
3383
3384         * CMakeLists.txt:
3385         * GNUmakefile.am:
3386         * WebCore.gypi:
3387         * WebCore.pro:
3388         * WebCore.xcodeproj/project.pbxproj:
3389         * inspector/InspectorClient.h:
3390         * inspector/InspectorController.cpp:
3391         (WebCore::InspectorController::InspectorController):
3392         (WebCore::InspectorController::inspectorStartsAttached):
3393         (WebCore::InspectorController::setInspectorStartsAttached):
3394         (WebCore::InspectorController::setInspectorAttachedHeight):
3395         (WebCore::InspectorController::inspectorAttachedHeight):
3396         (WebCore::InspectorController::setMonitoringXHREnabled):
3397         (WebCore::InspectorController::restoreDebugger):
3398         (WebCore::InspectorController::restoreProfiler):
3399         (WebCore::InspectorController::ensureSettingsLoaded):
3400         (WebCore::InspectorController::enableProfiler):
3401         (WebCore::InspectorController::disableProfiler):
3402         (WebCore::InspectorController::enableDebuggerFromFrontend):
3403         (WebCore::InspectorController::disableDebugger):
3404         * inspector/InspectorController.h:
3405         * inspector/InspectorSettings.cpp: Added.
3406         (WebCore::InspectorSettings::InspectorSettings):
3407         (WebCore::InspectorSettings::getBoolean):
3408         (WebCore::InspectorSettings::setBoolean):
3409         (WebCore::InspectorSettings::getLong):
3410         (WebCore::InspectorSettings::setLong):
3411         (WebCore::InspectorSettings::registerBoolean):
3412         (WebCore::InspectorSettings::registerLong):
3413         * inspector/InspectorSettings.h: Added.
3414         * inspector/InspectorState.cpp:
3415         (WebCore::InspectorState::InspectorState):
3416         (WebCore::InspectorState::setValue):
3417         (WebCore::InspectorState::setObject):
3418         (WebCore::InspectorState::registerBoolean):
3419         (WebCore::InspectorState::registerString):
3420         (WebCore::InspectorState::registerLong):
3421         (WebCore::InspectorState::registerObject):
3422         (WebCore::InspectorState::Property::create):
3423         * inspector/InspectorState.h:
3424         (WebCore::InspectorState::setBoolean):
3425         (WebCore::InspectorState::setString):
3426         (WebCore::InspectorState::setLong):
3427
3428 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3429
3430         Unreviewed, rolling out r75774.
3431         http://trac.webkit.org/changeset/75774
3432         https://bugs.webkit.org/show_bug.cgi?id=52431
3433
3434         gtk builds were broken (Requested by loislo2 on #webkit).
3435
3436         * CMakeLists.txt:
3437         * WebCore.gypi:
3438         * WebCore.pro:
3439         * WebCore.vcproj/WebCore.vcproj:
3440         * WebCore.xcodeproj/project.pbxproj:
3441         * inspector/CodeGeneratorInspector.pm:
3442         * inspector/Inspector.idl:
3443         * inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
3444         * inspector/InspectorBrowserDebuggerAgent.h: Removed.
3445         * inspector/InspectorController.cpp:
3446         (WebCore::InspectorController::InspectorController):
3447         (WebCore::InspectorController::inspectedPageDestroyed):
3448         (WebCore::InspectorController::didCommitLoad):
3449         (WebCore::InspectorController::enableDebuggerFromFrontend):
3450         (WebCore::InspectorController::disableDebugger):
3451         (WebCore::InspectorController::restoreStickyBreakpoints):
3452         (WebCore::InspectorController::restoreStickyBreakpoint):
3453         (WebCore::InspectorController::setEventListenerBreakpoint):
3454         (WebCore::InspectorController::removeEventListenerBreakpoint):
3455         (WebCore::InspectorController::hasEventListenerBreakpoint):
3456         (WebCore::InspectorController::setXHRBreakpoint):
3457         (WebCore::InspectorController::removeXHRBreakpoint):
3458         (WebCore::InspectorController::hasXHRBreakpoint):
3459         * inspector/InspectorController.h:
3460         * inspector/InspectorDOMAgent.cpp:
3461         (WebCore::InspectorDOMAgent::discardBindings):
3462         (WebCore::InspectorDOMAgent::setDOMBreakpoint):
3463         (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
3464         (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
3465         (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
3466         (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
3467         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
3468         (WebCore::InspectorDOMAgent::didInsertDOMNode):
3469         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
3470         (WebCore::InspectorDOMAgent::hasBreakpoint):
3471         (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
3472         * inspector/InspectorDOMAgent.h:
3473         * inspector/InspectorInstrumentation.cpp:
3474         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
3475         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
3476         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
3477         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl