Unreviewed, rolling out r133944.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2012-11-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r133944.
4         http://trac.webkit.org/changeset/133944
5         https://bugs.webkit.org/show_bug.cgi?id=102118
6
7         Only JS bindings support NATIVE_TYPE_ERR (Requested by arv on
8         #webkit).
9
10         * bindings/scripts/CodeGeneratorV8.pm:
11         (GenerateFunctionCallback):
12         (GenerateParametersCheck):
13         (GenerateSingleConstructorCallback):
14         (GenerateNamedConstructorCallback):
15         (TypeCanFailConversion):
16         * dom/Element.cpp:
17         (WebCore::Element::setAttributeNode):
18         (WebCore::Element::removeAttributeNode):
19         * dom/Element.idl:
20
21 2012-11-13  Adam Barth  <abarth@webkit.org>
22
23         Unreviewed.
24
25         Update run-bindings-tests results.
26
27         * bindings/scripts/test/V8/V8Float64Array.cpp:
28         (WebCore::V8Float64Array::dispatchWrapCustom):
29         (WebCore::V8Float64Array::wrapSlow):
30         * bindings/scripts/test/V8/V8Float64Array.h:
31         (WebCore::V8Float64Array::toNative):
32         (V8Float64Array):
33         (WebCore):
34         (WebCore::dispatchWrap):
35         (WebCore::toV8Object):
36         (WebCore::toV8):
37         * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
38         (WebCore::V8TestActiveDOMObject::wrapSlow):
39         * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
40         (WebCore::V8TestActiveDOMObject::toNative):
41         (V8TestActiveDOMObject):
42         (WebCore):
43         (WebCore::dispatchWrap):
44         (WebCore::toV8Object):
45         (WebCore::toV8):
46         * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
47         (WebCore::V8TestCustomNamedGetter::wrapSlow):
48         * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
49         (WebCore::V8TestCustomNamedGetter::toNative):
50         (V8TestCustomNamedGetter):
51         (WebCore):
52         (WebCore::dispatchWrap):
53         (WebCore::toV8Object):
54         (WebCore::toV8):
55         * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
56         (WebCore::V8TestEventConstructor::wrapSlow):
57         * bindings/scripts/test/V8/V8TestEventConstructor.h:
58         (WebCore::V8TestEventConstructor::toNative):
59         (V8TestEventConstructor):
60         (WebCore):
61         (WebCore::dispatchWrap):
62         (WebCore::toV8Object):
63         (WebCore::toV8):
64         * bindings/scripts/test/V8/V8TestEventTarget.cpp:
65         (WebCore::V8TestEventTarget::wrapSlow):
66         * bindings/scripts/test/V8/V8TestEventTarget.h:
67         (WebCore::V8TestEventTarget::toNative):
68         (V8TestEventTarget):
69         (WebCore):
70         (WebCore::dispatchWrap):
71         (WebCore::toV8Object):
72         (WebCore::toV8):
73         * bindings/scripts/test/V8/V8TestException.cpp:
74         (WebCore::V8TestException::wrapSlow):
75         * bindings/scripts/test/V8/V8TestException.h:
76         (WebCore::V8TestException::toNative):
77         (V8TestException):
78         (WebCore):
79         (WebCore::dispatchWrap):
80         (WebCore::toV8Object):
81         (WebCore::toV8):
82         * bindings/scripts/test/V8/V8TestInterface.cpp:
83         (WebCore::V8TestInterface::wrapSlow):
84         * bindings/scripts/test/V8/V8TestInterface.h:
85         (WebCore::V8TestInterface::toNative):
86         (V8TestInterface):
87         (WebCore):
88         (WebCore::dispatchWrap):
89         (WebCore::toV8Object):
90         (WebCore::toV8):
91         * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
92         (WebCore::V8TestMediaQueryListListener::wrapSlow):
93         * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
94         (WebCore::V8TestMediaQueryListListener::toNative):
95         (V8TestMediaQueryListListener):
96         (WebCore):
97         (WebCore::dispatchWrap):
98         (WebCore::toV8Object):
99         (WebCore::toV8):
100         * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
101         (WebCore::V8TestNamedConstructor::wrapSlow):
102         * bindings/scripts/test/V8/V8TestNamedConstructor.h:
103         (WebCore::V8TestNamedConstructor::toNative):
104         (V8TestNamedConstructor):
105         (WebCore):
106         (WebCore::dispatchWrap):
107         (WebCore::toV8Object):
108         (WebCore::toV8):
109         * bindings/scripts/test/V8/V8TestNode.cpp:
110         (WebCore::V8TestNode::wrapSlow):
111         * bindings/scripts/test/V8/V8TestNode.h:
112         (WebCore::V8TestNode::toNative):
113         (V8TestNode):
114         (WebCore):
115         (WebCore::dispatchWrap):
116         (WebCore::toV8Object):
117         (WebCore::toV8):
118         (WebCore::toV8Fast):
119         * bindings/scripts/test/V8/V8TestObj.cpp:
120         (WebCore::V8TestObj::wrapSlow):
121         * bindings/scripts/test/V8/V8TestObj.h:
122         (WebCore::V8TestObj::toNative):
123         (V8TestObj):
124         (WebCore):
125         (WebCore::dispatchWrap):
126         (WebCore::toV8Object):
127         (WebCore::toV8):
128         * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
129         (WebCore::V8TestOverloadedConstructors::wrapSlow):
130         * bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
131         (WebCore::V8TestOverloadedConstructors::toNative):
132         (V8TestOverloadedConstructors):
133         (WebCore):
134         (WebCore::dispatchWrap):
135         (WebCore::toV8Object):
136         (WebCore::toV8):
137         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
138         (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
139         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
140         (WebCore::V8TestSerializedScriptValueInterface::toNative):
141         (V8TestSerializedScriptValueInterface):
142         (WebCore):
143         (WebCore::dispatchWrap):
144         (WebCore::toV8Object):
145         (WebCore::toV8):
146
147 2012-11-13  Adam Barth  <abarth@webkit.org>
148
149         Unreviewed.
150
151         Speculative build fix for Qt.
152
153         * dom/make_names.pl:
154         (printWrapperFactoryCppFile):
155
156 2012-11-13  Sami Kyostila  <skyostil@chromium.org>
157
158         Allow painting outside overflow clip in accelerated scrolling layers
159         https://bugs.webkit.org/show_bug.cgi?id=100524
160
161         Reviewed by Simon Fraser.
162
163         In preparation for avoiding repaints when scrolling child layers, make it
164         possible to paint outside the overflow clip.
165
166         Test: compositing/overflow/updating-scrolling-content.html
167
168         * rendering/LayoutState.h:
169         (LayoutState):
170         * rendering/RenderBlock.cpp:
171         (WebCore::RenderBlock::paint):
172         * rendering/RenderBox.cpp:
173         (WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
174         * rendering/RenderLayer.cpp:
175         (WebCore::RenderLayer::repaintBlockSelectionGaps):
176
177 2012-11-13  Patrick Gansterer  <paroga@webkit.org>
178
179         Port SimpleFontDataWin.cpp to WinCE
180         https://bugs.webkit.org/show_bug.cgi?id=97889
181
182         Reviewed by Brent Fulgham.
183
184         Add #if !OS(WINCE) around some parts of the code, so it can be used by the WinCE port too in a next step.
185         Also cleaned up the include headers.
186
187         * platform/graphics/win/SimpleFontDataWin.cpp:
188         (WebCore::SimpleFontData::initGDIFont):
189         (WebCore::SimpleFontData::platformDestroy):
190         (WebCore::SimpleFontData::boundsForGDIGlyph):
191         (WebCore):
192         (WebCore::SimpleFontData::widthForGDIGlyph):
193
194 2012-11-13  Pavel Feldman  <pfeldman@chromium.org>
195
196         Web Inspector: [Chromium] move spectrum.css into the standalone css files group.
197
198         Not reviewed: moved css file in gypi.
199
200         * WebCore.gypi:
201
202 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
203
204         Unreviewed, rolling out r134434.
205         http://trac.webkit.org/changeset/134434
206         https://bugs.webkit.org/show_bug.cgi?id=102072
207
208         The test that was added asserts in loader.
209
210         * loader/FrameLoader.cpp:
211         (WebCore::createWindow):
212         * page/DOMWindow.cpp:
213         (WebCore):
214         (WebCore::DOMWindow::adjustWindowRect):
215         (WebCore::DOMWindow::moveBy):
216         (WebCore::DOMWindow::moveTo):
217         (WebCore::DOMWindow::resizeBy):
218         (WebCore::DOMWindow::resizeTo):
219         (WebCore::DOMWindow::open):
220         (WebCore::DOMWindow::showModalDialog):
221         * page/DOMWindow.h:
222         (DOMWindow):
223
224 2012-11-13  Dan Carney  <dcarney@google.com>
225
226         [V8] More efficient wrapper dispatch
227         https://bugs.webkit.org/show_bug.cgi?id=102082
228
229         Reviewed by Adam Barth.
230
231         Dispatching a call to V8Whatever::wrap involved a chain
232         of calls, each of which checked its wrapper cache.
233         This refactor gives calls only 2 choices of functions to call:
234         toV8 and toV8Object instead of wrap. wrap has been renamed to
235         dispatchWrap and no longer contains cache checks.
236         Additionally, classes which require a custom toV8 function
237         have had all wrapping and caching calls removed, as they could
238         not have been accessed.
239
240         No new tests. Sufficiently covered.
241
242         * Modules/indexeddb/IDBAny.idl:
243         * Modules/indexeddb/IDBKey.idl:
244         * WebCore.gypi:
245         * bindings/scripts/CodeGeneratorV8.pm:
246         (GenerateHeader):
247         (GenerateNormalAttrGetter):
248         (GenerateImplementation):
249         (GenerateToV8Converters):
250         * bindings/scripts/IDLAttributes.txt:
251         * bindings/v8/SerializedScriptValue.cpp:
252         * bindings/v8/custom/V8BlobCustom.cpp:
253         (WebCore::V8Blob::dispatchWrapCustom):
254         * bindings/v8/custom/V8CSSRuleCustom.cpp:
255         (WebCore::V8CSSRule::dispatchWrapCustom):
256         * bindings/v8/custom/V8CSSValueCustom.cpp:
257         (WebCore::V8CSSValue::dispatchWrapCustom):
258         * bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:
259         (WebCore::V8CanvasRenderingContext::dispatchWrapCustom):
260         * bindings/v8/custom/V8DataViewCustom.cpp:
261         (WebCore):
262         (WebCore::V8DataView::dispatchWrapCustom):
263         * bindings/v8/custom/V8DocumentCustom.cpp:
264         (WebCore::V8Document::dispatchWrapCustom):
265         * bindings/v8/custom/V8ElementCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8PerformanceEntryCustom.cpp.
266         (WebCore):
267         (WebCore::V8Element::dispatchWrapCustom):
268         * bindings/v8/custom/V8EntryCustom.cpp:
269         (WebCore::V8Entry::dispatchWrapCustom):
270         * bindings/v8/custom/V8EntrySyncCustom.cpp:
271         (WebCore::V8EntrySync::dispatchWrapCustom):
272         * bindings/v8/custom/V8EventCustom.cpp:
273         (WebCore):
274         (WebCore::V8Event::dispatchWrapCustom):
275         * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
276         (WebCore::V8HTMLCollection::dispatchWrapCustom):
277         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
278         (WebCore::V8HTMLDocument::dispatchWrapCustom):
279         * bindings/v8/custom/V8HTMLElementCustom.cpp:
280         (WebCore::V8HTMLElement::dispatchWrapCustom):
281         * bindings/v8/custom/V8ImageDataCustom.cpp:
282         (WebCore::V8ImageData::dispatchWrapCustom):
283         * bindings/v8/custom/V8NodeCustom.cpp:
284         (WebCore::V8Node::dispatchWrapCustom):
285         * bindings/v8/custom/V8PerformanceEntryCustom.cpp:
286         (WebCore::V8PerformanceEntry::dispatchWrapCustom):
287         * bindings/v8/custom/V8SVGDocumentCustom.cpp:
288         (WebCore::V8SVGDocument::dispatchWrapCustom):
289         * bindings/v8/custom/V8SVGElementCustom.cpp:
290         (WebCore::V8SVGElement::dispatchWrapCustom):
291         * bindings/v8/custom/V8SVGPathSegCustom.cpp:
292         (WebCore::V8SVGPathSeg::dispatchWrapCustom):
293         * bindings/v8/custom/V8StyleSheetCustom.cpp:
294         (WebCore::V8StyleSheet::dispatchWrapCustom):
295         * dom/Element.idl:
296         * dom/make_names.pl:
297         (printWrapperFunctions):
298         (printWrapperFactoryCppFile):
299         (printWrapperFactoryHeaderFile):
300         * html/MicroDataItemValue.idl:
301         * inspector/ScriptProfile.idl:
302         * inspector/ScriptProfileNode.idl:
303         * page/DOMWindow.idl:
304         * workers/WorkerContext.idl:
305
306 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
307
308         Unreviewed, rolling out r134367.
309         http://trac.webkit.org/changeset/134367
310         https://bugs.webkit.org/show_bug.cgi?id=100738
311
312         Speculative rollout, could have cause Dromaeo setAttribute
313         perf regression.
314
315         * dom/Element.cpp:
316         (WebCore::Element::attributeChanged):
317         (WebCore::checkNeedsStyleInvalidationForClassChange):
318         (WebCore::Element::classAttributeChanged):
319
320 2012-11-13  Marja Hölttä  <marja@chromium.org>
321
322         Add initiator to CachedResourceRequest.
323         https://bugs.webkit.org/show_bug.cgi?id=101935
324
325         Reviewed by Adam Barth.
326
327         Motivation: Chromium needs to know which elements request a
328         resource (such as an image or a script) (bug 92761). In addition,
329         for exposing resource timing information (bug 84883) we need to
330         store the initiator, and this is the first step towards it.
331
332         No new tests: No visible change in behavior.
333
334         * CMakeLists.txt:
335         * GNUmakefile.list.am:
336         * Target.pri:
337         * WebCore.gypi:
338         * WebCore.vcproj/WebCore.vcproj:
339         * WebCore.xcodeproj/project.pbxproj:
340         * css/CSSCrossfadeValue.cpp:
341         (WebCore::cachedImageForCSSValue):
342         * css/CSSCursorImageValue.cpp:
343         (WebCore::CSSCursorImageValue::cachedImage):
344         * css/CSSFontFaceSrcValue.cpp:
345         (WebCore::CSSFontFaceSrcValue::cachedFont):
346         * css/CSSImageSetValue.cpp:
347         (WebCore::CSSImageSetValue::cachedImageSet):
348         * css/CSSImageValue.cpp:
349         (WebCore::CSSImageValue::cachedImage):
350         * css/CSSImageValue.h:
351         (WebCore):
352         (CSSImageValue):
353         * css/StyleResolver.cpp:
354         (WebCore::StyleResolver::loadPendingImage):
355         * css/StyleRuleImport.cpp:
356         (WebCore::StyleRuleImport::requestStyleSheet):
357         * css/WebKitCSSSVGDocumentValue.cpp:
358         (WebCore::WebKitCSSSVGDocumentValue::load):
359         * css/WebKitCSSShaderValue.cpp:
360         (WebCore::WebKitCSSShaderValue::cachedShader):
361         * dom/ScriptElement.cpp:
362         (WebCore::ScriptElement::requestScript):
363         * html/HTMLLinkElement.cpp:
364         (WebCore::HTMLLinkElement::process):
365         * html/parser/CSSPreloadScanner.cpp:
366         (WebCore::CSSPreloadScanner::emitRule):
367         * html/parser/CSSPreloadScanner.h:
368         (CSSPreloadScanner):
369         * html/parser/HTMLPreloadScanner.cpp:
370         (WebCore::PreloadTask::preload):
371         * loader/ImageLoader.cpp:
372         (WebCore::ImageLoader::updateFromElement):
373         * loader/cache/CachedResourceLoader.cpp:
374         (WebCore::CachedResourceLoader::requestImage):
375         (WebCore::CachedResourceLoader::requestResource):
376         (WebCore::CachedResourceLoader::determineRevalidationPolicy):
377         (WebCore):
378         (WebCore::CachedResourceLoader::preload):
379         * loader/cache/CachedResourceLoader.h:
380         (WebCore):
381         (CachedResourceLoader):
382         * loader/cache/CachedResourceRequest.cpp:
383         (WebCore::CachedResourceRequest::CachedResourceRequest):
384         (WebCore):
385         (WebCore::CachedResourceRequest::~CachedResourceRequest):
386         (WebCore::CachedResourceRequest::setInitiator):
387         (WebCore::CachedResourceRequest::initiatorName):
388         (WebCore::CachedResourceRequest::initiatorDocument):
389         (WebCore::CachedResourceRequest::initiatorElement):
390         * loader/cache/CachedResourceRequest.h:
391         (WebCore):
392         (WebCore::CachedResourceRequest::setOptions):
393         (WebCore::CachedResourceRequest::defer):
394         (WebCore::CachedResourceRequest::setDefer):
395         (CachedResourceRequest):
396         * loader/cache/CachedResourceRequestInitiators.cpp: Copied from Source/WebCore/loader/cache/CachedResourceRequest.cpp.
397         (WebCore):
398         (WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):
399         * loader/cache/CachedResourceRequestInitiators.h: Copied from Source/WebCore/loader/cache/CachedResourceRequest.cpp.
400         (WebCore):
401         (CachedResourceRequestInitiators):
402         (WebCore::cachedResourceRequestInitiators):
403         * loader/icon/IconLoader.cpp:
404         (WebCore::IconLoader::startLoading):
405         * platform/ThreadGlobalData.cpp:
406         (WebCore::ThreadGlobalData::ThreadGlobalData):
407         * platform/ThreadGlobalData.h:
408         (WebCore):
409         (WebCore::ThreadGlobalData::cachedResourceRequestInitiators):
410         (ThreadGlobalData):
411         * svg/SVGFEImageElement.cpp:
412         (WebCore::SVGFEImageElement::requestImageResource):
413         * svg/SVGFontFaceUriElement.cpp:
414         (WebCore::SVGFontFaceUriElement::loadFont):
415         * svg/SVGUseElement.cpp:
416         (WebCore::SVGUseElement::svgAttributeChanged):
417
418 2012-11-13  Sheriff Bot  <webkit.review.bot@gmail.com>
419
420         Unreviewed, rolling out r134345.
421         http://trac.webkit.org/changeset/134345
422         https://bugs.webkit.org/show_bug.cgi?id=102106
423
424         Incomplete support for NATIVE_TYPE_ERR in objc and other
425         bindings (Requested by jsbell on #webkit).
426
427         * Modules/mediastream/MediaConstraintsImpl.cpp:
428         (WebCore::MediaConstraintsImpl::create):
429         * Modules/mediastream/MediaStreamTrackList.cpp:
430         (WebCore::MediaStreamTrackList::add):
431         (WebCore::MediaStreamTrackList::remove):
432         * Modules/mediastream/RTCDataChannel.cpp:
433         (WebCore::RTCDataChannel::setBinaryType):
434         * Modules/mediastream/RTCIceCandidate.cpp:
435         (WebCore::RTCIceCandidate::create):
436         * Modules/mediastream/RTCPeerConnection.cpp:
437         (WebCore::RTCPeerConnection::parseConfiguration):
438         (WebCore::RTCPeerConnection::createOffer):
439         (WebCore::RTCPeerConnection::createAnswer):
440         (WebCore::RTCPeerConnection::setLocalDescription):
441         (WebCore::RTCPeerConnection::setRemoteDescription):
442         (WebCore::RTCPeerConnection::addIceCandidate):
443         (WebCore::RTCPeerConnection::addStream):
444         (WebCore::RTCPeerConnection::removeStream):
445         * Modules/mediastream/RTCSessionDescription.cpp:
446         (WebCore::RTCSessionDescription::create):
447         (WebCore::RTCSessionDescription::setType):
448         * bindings/js/CallbackFunction.cpp:
449         (WebCore::checkFunctionOnlyCallback):
450         * bindings/js/JSCustomXPathNSResolver.cpp:
451         (WebCore::JSCustomXPathNSResolver::create):
452         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
453         (WebCore::JSHTMLOptionsCollection::add):
454         * bindings/js/JSHTMLSelectElementCustom.cpp:
455         (WebCore::selectIndexSetter):
456         * bindings/js/JSMutationObserverCustom.cpp:
457         (WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
458         * bindings/js/JSSQLResultSetRowListCustom.cpp:
459         (WebCore::JSSQLResultSetRowList::item):
460         * bindings/js/JSSQLTransactionCustom.cpp:
461         (WebCore::JSSQLTransaction::executeSql):
462         * bindings/js/JSSQLTransactionSyncCustom.cpp:
463         (WebCore::JSSQLTransactionSync::executeSql):
464         * bindings/scripts/CodeGeneratorJS.pm:
465         (GenerateParametersCheck):
466         * bindings/scripts/CodeGeneratorObjC.pm:
467         (GenerateImplementation):
468         * bindings/scripts/CodeGeneratorV8.pm:
469         (GenerateFunctionCallString):
470         * bindings/v8/V8Callback.h:
471         (WebCore::createFunctionOnlyCallback):
472         * bindings/v8/V8Collection.cpp:
473         (WebCore::toOptionsCollectionSetter):
474         * bindings/v8/custom/V8DocumentCustom.cpp:
475         (WebCore::V8Document::evaluateCallback):
476         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
477         (WebCore::V8HTMLOptionsCollection::addCallback):
478         * bindings/v8/custom/V8MutationObserverCustom.cpp:
479         (WebCore::V8MutationObserver::constructorCallback):
480         * bindings/v8/custom/V8SQLTransactionCustom.cpp:
481         (WebCore::V8SQLTransaction::executeSqlCallback):
482         * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
483         (WebCore::V8SQLTransactionSync::executeSqlCallback):
484         * dom/DOMCoreException.idl:
485         * html/HTMLElement.cpp:
486         (WebCore::HTMLElement::insertAdjacentElement):
487         * html/HTMLMediaElement.cpp:
488         (WebCore::HTMLMediaElement::webkitAddKey):
489         * html/HTMLOptionsCollection.cpp:
490         (WebCore::HTMLOptionsCollection::add):
491         * html/canvas/CanvasRenderingContext2D.cpp:
492         (WebCore::CanvasRenderingContext2D::drawImage):
493         (WebCore::CanvasRenderingContext2D::createPattern):
494         (WebCore::CanvasRenderingContext2D::putImageData):
495         (WebCore::CanvasRenderingContext2D::webkitPutImageDataHD):
496         * page/Crypto.cpp:
497         (WebCore::Crypto::getRandomValues):
498         * page/DOMSelection.cpp:
499         (WebCore::DOMSelection::extend):
500         * svg/properties/SVGTransformListPropertyTearOff.h:
501         (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
502
503 2012-11-13  Erik Arvidsson  <arv@chromium.org>
504
505         Update DOMException name: HierarchyRequestError
506         https://bugs.webkit.org/show_bug.cgi?id=102092
507
508         Reviewed by Ojan Vafai.
509
510         Patch 3 of 25 to update DOMException name to match the spec and Firefox.
511
512         Updated existing tests.
513
514         * dom/DOMCoreException.cpp:
515
516 2012-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
517
518         Clean up use of adjustWindowRect
519         https://bugs.webkit.org/show_bug.cgi?id=102072
520
521         Reviewed by Alexis Menard.
522
523         Tested by fast/dom/Window/open-window-min-size.html
524
525         * loader/FrameLoader.cpp:
526         (WebCore::createWindow):
527
528             Validate the window size here so that it is not just done for
529             .open, but also for .showModalDialog. This is compatible with
530             other browsers such as IE and Firefox (though IE > 6, enforces
531             a minimum width of 250 instead of 100 as Firefox and us.)
532
533         * page/DOMWindow.cpp:
534         (WebCore):
535         (WebCore::DOMWindow::adjustWindowRect):
536
537             Make it a static method which only takes page. It was never
538             called from anywhere without a valid page, so the page check
539             has been turned into an assert, and two of the arguments have
540             been removed as they can be accessed via the page.
541
542         (WebCore::DOMWindow::moveBy):
543         (WebCore::DOMWindow::moveTo):
544         (WebCore::DOMWindow::resizeBy):
545         (WebCore::DOMWindow::resizeTo):
546
547             Update use of adjustWindowRect.
548
549         (WebCore::DOMWindow::open):
550
551             Avoid modifying the WindowFeatures as the WebCore::createWindow
552             validates and adjusts the arguments.
553
554         * page/DOMWindow.h:
555         (DOMWindow):
556
557 2012-11-13  Bem Jones-Bey  <bjonesbe@adobe.com>
558
559         [CSS Exclusions] Update wrap-margin/padding to shape-margin/padding
560         https://bugs.webkit.org/show_bug.cgi?id=97736
561
562         Reviewed by Andreas Kling.
563
564         Rename properties to match updated spec.
565
566         Tests: fast/exclusions/shape-margin-parsing.html
567                fast/exclusions/shape-padding-parsing.html
568
569         * css/CSSComputedStyleDeclaration.cpp:
570         (WebCore):
571         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
572         * css/CSSParser.cpp:
573         (WebCore::isSimpleLengthPropertyID):
574         (WebCore::CSSParser::parseValue):
575         * css/CSSProperty.cpp:
576         (WebCore::CSSProperty::isInheritedProperty):
577         * css/CSSPropertyNames.in:
578         * css/StyleBuilder.cpp:
579         (WebCore::StyleBuilder::StyleBuilder):
580         * css/StylePropertySet.cpp:
581         (WebCore::StylePropertySet::asText):
582         * css/StylePropertyShorthand.cpp:
583         (WebCore::webkitWrapShorthand):
584         * css/StyleResolver.cpp:
585         (WebCore::StyleResolver::applyProperty):
586         * rendering/style/RenderStyle.cpp:
587         (WebCore::RenderStyle::diff):
588         * rendering/style/RenderStyle.h:
589         * rendering/style/StyleRareNonInheritedData.cpp:
590         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
591         (WebCore::StyleRareNonInheritedData::operator==):
592         * rendering/style/StyleRareNonInheritedData.h:
593         (StyleRareNonInheritedData):
594
595 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
596
597         Unreviewed, rolling out r134418.
598         http://trac.webkit.org/changeset/134418
599         https://bugs.webkit.org/show_bug.cgi?id=101903
600
601         The newly added test is crashing on cr-win.
602
603         * dom/ElementShadow.cpp:
604         * dom/ElementShadow.h:
605         * html/HTMLInputElement.cpp:
606         (WebCore::HTMLInputElement::updateType):
607         (WebCore::HTMLInputElement::setIndeterminate):
608         * html/HTMLProgressElement.cpp:
609         (WebCore::HTMLProgressElement::didElementStateChange):
610         * html/shadow/SelectRuleFeatureSet.cpp:
611         (WebCore::SelectRuleFeatureSet::add):
612         (WebCore::SelectRuleFeatureSet::clear):
613         (WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector):
614         * html/shadow/SelectRuleFeatureSet.h:
615         (SelectRuleFeatureSet):
616
617 2012-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
618
619         Unreviewed, rolling out r134391.
620         http://trac.webkit.org/changeset/134391
621         https://bugs.webkit.org/show_bug.cgi?id=99660
622
623         Speculative rollout, trying to fix browser_tests failure.
624
625         * English.lproj/localizedStrings.js:
626         * inspector/Inspector.json:
627         * inspector/InspectorClient.h:
628         * inspector/InspectorPageAgent.cpp:
629         (PageAgentState):
630         (WebCore::InspectorPageAgent::enable):
631         (WebCore::InspectorPageAgent::disable):
632         * inspector/InspectorPageAgent.h:
633         * inspector/front-end/Settings.js:
634         * inspector/front-end/SettingsScreen.js:
635         (WebInspector.GenericSettingsTab):
636         * inspector/front-end/inspector.js:
637         (WebInspector.doLoadedDone):
638
639 2012-11-13  Sheriff Bot  <webkit.review.bot@gmail.com>
640
641         Unreviewed, rolling out r134205.
642         http://trac.webkit.org/changeset/134205
643         https://bugs.webkit.org/show_bug.cgi?id=102093
644
645         Broke webkit-flow-inlines-dynamic.html on several ports
646         (Requested by mihnea on #webkit).
647
648         * css/StyleResolver.cpp:
649         (WebCore::StyleResolver::isValidRegionStyleProperty):
650         * rendering/InlineBox.cpp:
651         * rendering/InlineBox.h:
652         (WebCore):
653         (InlineBox):
654         * rendering/InlineFlowBox.cpp:
655         (WebCore::InlineFlowBox::addToLine):
656         (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
657         * rendering/RenderRegion.cpp:
658         (WebCore::RenderRegion::setRegionObjectsRegionStyle):
659         (WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
660         (WebCore::RenderRegion::computeStyleInRegion):
661         (WebCore::RenderRegion::computeChildrenStyleInRegion):
662         (WebCore::RenderRegion::setObjectStyleInRegion):
663         (WebCore::RenderRegion::clearObjectStyleInRegion):
664         * rendering/RenderRegion.h:
665         (RenderRegion):
666         (ObjectRegionStyleInfo):
667
668 2012-11-13  Andreas Kling  <kling@webkit.org>
669
670         Remove the non-const overload of ElementAttributeData::inlineStyle().
671
672         Rubber-stamped by Anders Koivisto.
673
674         No call sites actually needed a mutable StylePropertySet* from inlineStyle() anyway.
675
676         * dom/ElementAttributeData.h:
677
678 2012-11-13  Keishi Hattori  <keishi@webkit.org>
679
680         [Chromium] Enable input type month/week
681         https://bugs.webkit.org/show_bug.cgi?id=102042
682
683         Reviewed by Kent Tamura.
684
685         Enable input type month/week for Chromium.
686
687         No new tests. Tests will be added later in Bug 102045 and Bug 102046.
688
689         * bindings/generic/RuntimeEnabledFeatures.cpp:
690         (WebCore):
691
692 2012-11-13  Shinya Kawanaka  <shinyak@chromium.org>
693
694         [Refactoring] Remove shadowPseudoId() and use setPseudo() in <meter> ElementShadow.
695         https://bugs.webkit.org/show_bug.cgi?id=101906
696
697         Reviewed by Dimitri Glazkov.
698
699         We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
700         setPseudo()/pseudo() instead.
701
702         No new tests, covered by existing tests.
703
704         * html/HTMLMeterElement.cpp:
705         (WebCore::HTMLMeterElement::didElementStateChange): Since shadowPseudoId() was returning pseudo id without setting
706         it anywhere, we have to set it into pseudo attribute here.
707         (WebCore::HTMLMeterElement::createShadowSubtree): ditto.
708         * html/shadow/MeterShadowElement.cpp:
709         (WebCore::MeterInnerElement::MeterInnerElement):
710         (WebCore::MeterValueElement::valuePseudoId):
711         * html/shadow/MeterShadowElement.h:
712         (MeterInnerElement):
713         (WebCore::MeterBarElement::MeterBarElement):
714         (MeterBarElement):
715         (WebCore::MeterValueElement::MeterValueElement):
716         (WebCore::MeterValueElement::updatePseudo):
717         (MeterValueElement):
718
719 2012-11-13  Shinya Kawanaka  <shinyak@chromium.org>
720
721         Changing pseudoClass (:indeterminate) should cause distribution
722         https://bugs.webkit.org/show_bug.cgi?id=101903
723
724         Reviewed by Dimitri Glazkov.
725
726         <progress> and <input type="checkbox"> have 'indeterminate' state. When their state is changed, we have to
727         invalidate distribution if necessary. To check it, we collect a feature that :invalidate is used in select attributes.
728
729         For <input>, we also have to see 'type' is changed. According to the spec, :indeterminate should match only
730         progress element or <input type="checkbox">. So changing 'type' might also change :indeterminate state.
731
732         Tests: fast/dom/shadow/pseudoclass-update-indeterminate-input.html
733                fast/dom/shadow/pseudoclass-update-indeterminate-progress.html
734
735         * dom/ElementShadow.cpp:
736         (WebCore::invalidateParentDistributionIfNecessary): Since we will add a lot of pseudoClass check later, we would like to
737         have this kind of helper method. We will add various pseudoClass check (see Bug 101697), we reuse CSSSelector::PseudoType
738         here.
739         (WebCore):
740         * dom/ElementShadow.h:
741         (WebCore):
742         * html/HTMLInputElement.cpp:
743         (WebCore::HTMLInputElement::updateType): Invalidate parent distribution anyway, since it changes various internal states.
744         (WebCore::HTMLInputElement::setIndeterminate): Invalidate parent distribution if necessary.
745         * html/HTMLProgressElement.cpp:
746         (WebCore::HTMLProgressElement::didElementStateChange):
747         * html/shadow/SelectRuleFeatureSet.cpp:
748         (WebCore::SelectRuleFeatureSet::SelectRuleFeatureSet): Adds m_usesIndeterminate feature.
749         (WebCore::SelectRuleFeatureSet::add):
750         (WebCore::SelectRuleFeatureSet::clear):
751         (WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector):
752         * html/shadow/SelectRuleFeatureSet.h:
753         (WebCore::SelectRuleFeatureSet::hasSelectorForIndeterminate):
754         (SelectRuleFeatureSet):
755
756 2012-11-13  Andreas Kling  <kling@webkit.org>
757
758         Exploit ElementAttributeData sharing in Node.cloneNode.
759         <http://webkit.org/b/101374>
760
761         Reviewed by Anders Carlsson.
762
763         Instead of blindly creating a new ElementAttributeData for Node.cloneNode, let's be clever!
764         If the source data is immutable, simply ref it from the new node at virtually no cost.
765
766         If the source data is mutable, convert it to immutable data so it can be shared between both nodes.
767         Since the typical use-case for Node.cloneNode is to create-once/clone-many, this saves both time
768         and memory in the long run.
769
770         ~8% speed-up on PerformanceTests/DOM/CloneNodes on my MBP.
771
772         * dom/Element.cpp:
773         (WebCore::Element::cloneAttributesFromElement):
774
775             Move attribute data cloning logic from ElementAttributeData to Element.
776
777         * dom/ElementAttributeData.cpp:
778         (WebCore::ImmutableElementAttributeData::~ImmutableElementAttributeData):
779         (WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):
780         (WebCore::ElementAttributeData::ElementAttributeData):
781         (WebCore::MutableElementAttributeData::MutableElementAttributeData):
782         (WebCore::ElementAttributeData::makeMutableCopy):
783         (WebCore::ElementAttributeData::makeImmutableCopy):
784         * dom/ElementAttributeData.h:
785         (ElementAttributeData):
786         (ImmutableElementAttributeData):
787         (MutableElementAttributeData):
788
789             Add facilities for converting a mutable ElementAttributeData to an immutable one.
790             Share some code in the common base class constructor.
791
792 2012-11-13  Kentaro Hara  <haraken@chromium.org>
793
794         Unreviewed. Build fix of V8 bindings.
795
796         * bindings/v8/V8DOMWrapper.cpp:
797         (WebCore::V8DOMWrapper::maybeDOMWrapper):
798
799 2012-11-13  Andrey Adaikin  <aandrey@chromium.org>
800
801         Web Inspector: [Canvas] UI: make the Grid save scrolling position, show wait spinner icon
802         https://bugs.webkit.org/show_bug.cgi?id=102071
803
804         Reviewed by Pavel Feldman.
805
806         * inspector/front-end/CanvasProfileView.js:
807         (WebInspector.CanvasProfileView):
808         (WebInspector.CanvasProfileView.prototype.dispose):
809         (WebInspector.CanvasProfileView.prototype.elementsToRestoreScrollPositionsFor):
810         (WebInspector.CanvasProfileView.prototype._enableWaitIcon):
811         (WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
812         (WebInspector.CanvasProfileView.prototype._replayTraceLog):
813         (WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
814         (WebInspector.CanvasProfileView.prototype._createCallNode):
815         * inspector/front-end/canvasProfiler.css:
816         (#canvas-replay-image.wait):
817
818 2012-11-13  Eugene Klyuchnikov  <eustas.bug@gmail.com>
819
820         Web Inspector: Settings screen: some panel shortcuts are missing
821         https://bugs.webkit.org/show_bug.cgi?id=101026
822
823         Reviewed by Pavel Feldman.
824
825         Panels, that have not been loaded by the time shortcuts view was
826         initialized, had no chance to register shortcuts.
827
828         Solution: move shortcut registration (for shortcuts screen) to panel
829         descriptors.
830
831         More changes: add JsDoc annotations to ShortcutScreen and change "key"
832         parameter type for raw string to key descriptor object.
833
834         * WebCore.gypi: Added TimelinePanelDescriptor.js file.
835         * WebCore.vcproj/WebCore.vcproj: Ditto.
836         * inspector/compile-front-end.py: Ditto.
837         * inspector/front-end/WebKit.qrc: Ditto.
838         * inspector/front-end/inspector.html: Ditto.
839         * inspector/front-end/AdvancedSearchController.js: Add JsDoc annotation.
840         * inspector/front-end/GoToLineDialog.js: Ditto.
841         * inspector/front-end/CallStackSidebarPane.js: Removed shortcut-screen
842         shortcuts registration.
843         * inspector/front-end/ElementsPanel.js: Ditto.
844         * inspector/front-end/ScriptsPanel.js: Ditto.
845         * inspector/front-end/StylesSidebarPane.js: Ditto.
846         * inspector/front-end/TimelinePanel.js: Ditto.
847         * inspector/front-end/ConsoleView.js: Changes order of lines to increase
848         readability.
849         * inspector/front-end/ElementsPanelDescriptor.js: Add shortcut-screen
850         shortcuts registration and key descriptor constants.
851         * inspector/front-end/ScriptsPanelDescriptor.js: Ditto.
852         * inspector/front-end/TimelinePanelDescriptor.js: Ditto.
853         * inspector/front-end/Panel.js: Removed unused "uregisterShortcut"; made
854         "registerShortcuts" method accept array of key descriptors.
855         (WebInspector.PanelDescriptor.prototype.registerShortcuts): Added.
856         * inspector/front-end/ShortcutsScreen.js: Added JsDoc; changed parameter
857         type from string to key descriptor.
858         * inspector/front-end/inspector.js: Register shortcuts using
859         panel descriptors.
860         (WebInspector._panelDescriptors): Removed duplicate line.
861
862 2012-11-13  Gabor Rapcsanyi  <rgabor@webkit.org>
863
864         Optimize RGB565 and RGBA5551 packing/unpacking functions with NEON intrinsics
865         https://bugs.webkit.org/show_bug.cgi?id=102060
866
867         Reviewed by Zoltan Herczeg.
868
869         Adding more NEONized packing functions to GraphicsContext3DNEON.h.
870         These functions are three times faster with this intrinsics optimizations.
871
872         * platform/graphics/GraphicsContext3D.cpp:
873         (WebCore):
874         * platform/graphics/cpu/arm/GraphicsContext3DNEON.h:
875         (WebCore::ARM::unpackOneRowOfRGBA5551ToRGBA8NEON):
876         (ARM):
877         (WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort5551NEON):
878         (WebCore::ARM::unpackOneRowOfRGB565ToRGBA8NEON):
879         (WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort565NEON):
880
881 2012-11-13  Csaba Osztrogonác  <ossy@webkit.org>
882
883         [Qt] Enable Mutation observer
884         https://bugs.webkit.org/show_bug.cgi?id=102066
885
886         Reviewed by Pavel Feldman.
887
888         * DerivedSources.pri: Add missing IDL files.
889
890 2012-11-13  Kentaro Hara  <haraken@chromium.org>
891
892         [V8] Make isValidDOMObject() static
893         https://bugs.webkit.org/show_bug.cgi?id=101914
894
895         Reviewed by Adam Barth.
896
897         isValidDOMObject() is used by DOMWrapper.cpp only.
898
899         No tests. No change in behavior.
900
901         * bindings/v8/V8DOMWrapper.cpp:
902         (WebCore::isValidDOMObject):
903         (WebCore):
904         (WebCore::V8DOMWrapper::maybeDOMWrapper):
905         * bindings/v8/V8DOMWrapper.h:
906         (V8DOMWrapper):
907
908 2012-11-13  Mihnea Ovidenie  <mihnea@adobe.com>
909
910         [CSSRegions] Incorrect computed height for content with region-break-before
911         https://bugs.webkit.org/show_bug.cgi?id=101862
912
913         Reviewed by Julien Chaffraix.
914
915         When processing the region breaks for auto-height regions, we skipped the case
916         when the region-break-before occurred in the first region in the chain which was
917         an auto-height region. Because of that, the region computed height was not 0
918         as it was supposed to be, but rather LayoutUnit::max() / 2.
919
920         Test: fast/regions/autoheight-breakbefore-wrongheight.html
921
922         * rendering/RenderFlowThread.cpp:
923         (WebCore::RenderFlowThread::addForcedRegionBreak):
924         Make sure we process also the case when the region-break occurs at offset 0 in the flow thread
925         and the first region in chain is an auto-height region.
926         * rendering/RenderRegion.cpp:
927         (WebCore::RenderRegion::updateLogicalHeight):
928         Add an assert to make sure that the computed height for auto-height regions is always less than LayoutUnit::max() / 2.
929
930 2012-11-13  Yury Semikhatsky  <yurys@chromium.org>
931
932         Memory instrumentation: remove reportMemoryUsage method from ImageObserver
933         https://bugs.webkit.org/show_bug.cgi?id=102058
934
935         Reviewed by Pavel Feldman.
936
937         * bindings/v8/V8PerIsolateData.cpp:
938         (WebCore::V8PerIsolateData::reportMemoryUsage): drive-by fix, no need to report
939         each element of the vector as generic vector instrumentation will take care of it.
940         * platform/graphics/Image.cpp: the client is reported as weak pointer to make sure
941         we don't count its by the pointer to the base class which may differ from the actual
942         object address.
943         (WebCore::Image::reportMemoryUsage):
944         * platform/graphics/ImageObserver.h: removed reportMemoryUsage method from the interface.
945         (ImageObserver):
946
947 2012-11-13  Eberhard Graether  <egraether@google.com>
948
949         checkbox to toggle FPS counter in the inspector's settings
950         https://bugs.webkit.org/show_bug.cgi?id=99660
951
952         Reviewed by Pavel Feldman.
953
954         Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true.
955
956         No new tests.
957
958         * English.lproj/localizedStrings.js:
959         * inspector/Inspector.json:
960         * inspector/InspectorClient.h:
961         (WebCore::InspectorClient::canShowFPSCounter):
962         (WebCore::InspectorClient::setShowFPSCounter):
963         (InspectorClient):
964         * inspector/InspectorPageAgent.cpp:
965         (PageAgentState):
966         (WebCore::InspectorPageAgent::enable):
967         (WebCore::InspectorPageAgent::disable):
968         (WebCore::InspectorPageAgent::canShowFPSCounter):
969         (WebCore):
970         (WebCore::InspectorPageAgent::setShowFPSCounter):
971         * inspector/InspectorPageAgent.h:
972         * inspector/front-end/Settings.js:
973         * inspector/front-end/SettingsScreen.js:
974         (WebInspector.GenericSettingsTab):
975         (WebInspector.GenericSettingsTab.prototype.get _showFPSCounterChanged):
976         * inspector/front-end/inspector.js:
977         (WebInspector.doLoadedDone):
978
979 2012-11-12  Kent Tamura  <tkent@chromium.org>
980
981         Unable to set valid time value to input[type=time] with user interaction in some cases
982         https://bugs.webkit.org/show_bug.cgi?id=102048
983
984         Reviewed by Kentaro Hara.
985
986         The implementations of shouldMillisecondFieldReadOnly,
987         shouldMinuteFieldReadOnly, and shouldSecondFieldReadOnly were
988         incorrect. We need to check if a part of the minimum value matches to
989         the corresponding part of the current value.
990
991         Also, we had better check hour field editability.
992
993         Test: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
994
995         * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
996         (WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldHaveSecondField):
997         Fix a problem that hh:mm:00.sss didn't create a seconds field.
998         * html/shadow/DateTimeEditElement.cpp:
999         (DateTimeEditBuilder): Add shouldHourFieldReadOnly declaration.
1000         (WebCore::DateTimeEditBuilder::visitField):
1001         Add shouldHourFieldReadOnly check to Hour11/Hour12/Hour23/Hour24/Period fields.
1002         (WebCore::DateTimeEditBuilder::shouldHourFieldReadOnly):
1003         Added. An hour field should be read-only if the step value is a multiple
1004         of a day and the hour part of the minimum value matches to the hour part
1005         of the value.
1006         (WebCore::DateTimeEditBuilder::shouldMillisecondFieldReadOnly):
1007         A millisecond field should be read-only if the step value is a multiple
1008         of one second and the millisecond part of the minimum value matches to
1009         the millisecond part of the value.
1010         (WebCore::DateTimeEditBuilder::shouldMinuteFieldReadOnly):
1011         A minute field should be read-only if the step value is a multiple of
1012         one hour and the minute part of the minimum value matches to the minute
1013         part of the value.
1014         (WebCore::DateTimeEditBuilder::shouldSecondFieldReadOnly):
1015         A second field should be read-only if the step value is a multiple of
1016         one minute and the second part of the minimum value matches to the second
1017         part of the value.
1018         * platform/Decimal.cpp:
1019         (WebCore::Decimal::remainder):
1020         Fix a bug in case that the fractional part of quotient is >= 0.5. Also
1021         make this matches to C99, C++11, ECMAScript behavior.
1022
1023 2012-11-13  Yury Semikhatsky  <yurys@chromium.org>
1024
1025         Memory instrumentation: MemoryBlock name should not include full path to the block
1026         https://bugs.webkit.org/show_bug.cgi?id=102055
1027
1028         Reviewed by Pavel Feldman.
1029
1030         * inspector/InspectorMemoryAgent.cpp: pass only last path component as MemoryBlock name
1031         intead of fully qualified name.
1032
1033 2012-11-13  Pavel Feldman  <pfeldman@chromium.org>
1034
1035         Web Inspector: get rid of enter/exitTextChangeMode in the editor
1036         https://bugs.webkit.org/show_bug.cgi?id=101845
1037
1038         Reviewed by Vsevolod Vlasov.
1039
1040         They seem to do nothing.
1041
1042         * inspector/front-end/DefaultTextEditor.js:
1043         (WebInspector.DefaultTextEditor.prototype._textChanged):
1044         (WebInspector.DefaultTextEditor.prototype.editRange):
1045         (WebInspector.TextEditorMainPanel):
1046         (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
1047         (WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
1048         (WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
1049         (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
1050         * inspector/front-end/TextEditorModel.js:
1051         (WebInspector.TextEditorModel.endsWithBracketRegex.):
1052
1053 2012-11-13  Tommy Widenflycht  <tommyw@google.com>
1054
1055         Remove the custom WebSocket::send for both V8 and JSC
1056         https://bugs.webkit.org/show_bug.cgi?id=101936
1057
1058         Reviewed by Kentaro Hara.
1059
1060         This patch removes the custom WebSocket::send since it isn't needed anymore.
1061
1062         Patch covered by existing tests.
1063
1064         * Modules/websockets/WebSocket.idl:
1065         * UseV8.cmake:
1066         * WebCore.gypi:
1067         * bindings/js/JSWebSocketCustom.cpp:
1068         * bindings/v8/custom/V8WebSocketCustom.cpp: Removed.
1069
1070 2012-11-13  Pavel Feldman  <pfeldman@chromium.org>
1071
1072         Web Inspector: move indentation logic into TextEditorModel
1073         https://bugs.webkit.org/show_bug.cgi?id=101842
1074
1075         Reviewed by Vsevolod Vlasov.
1076
1077         I'd like to move as much headless logic into the TextEditorModel as possible.
1078         Drive by: removed some dead code, converted getter into function and moved undo
1079         mark state into the model as well.
1080
1081         * inspector/front-end/DefaultTextEditor.js:
1082         (WebInspector.DefaultTextEditor.prototype.editRange):
1083         (WebInspector.DefaultTextEditor.prototype._syncDecorationsForLine):
1084         (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
1085         (WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
1086         (WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
1087         (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
1088         (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
1089         (WebInspector.TextEditorMainChunk):
1090         (WebInspector.TextEditorMainChunk.prototype.isDecorated):
1091         (WebInspector.TextEditorMainChunk.prototype.set expanded):
1092         * inspector/front-end/TextEditorModel.js:
1093         (WebInspector.TextEditorModel.endsWithBracketRegex.):
1094
1095 2012-11-13  Hayato Ito  <hayato@chromium.org>
1096
1097         Unreviewed attempt to fix the chromium mac-build after r134348.
1098
1099         * platform/graphics/mac/FontMac.mm:
1100         (WebCore::Font::drawGlyphs):
1101         * platform/mac/WebCoreSystemInterface.h:
1102         * platform/mac/WebCoreSystemInterface.mm:
1103
1104 2012-11-13  Pavel Feldman  <pfeldman@chromium.org>
1105
1106         Web Inspector: migrate text editor to mutation observers
1107         https://bugs.webkit.org/show_bug.cgi?id=101841
1108
1109         Reviewed by Vsevolod Vlasov.
1110
1111         Otherwise, we miss notifications on the removed lines.
1112
1113         * inspector/front-end/DefaultTextEditor.js:
1114         (WebInspector.DefaultTextEditor.prototype.wasShown):
1115         (WebInspector.DefaultTextEditor.prototype.willHide):
1116         (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
1117         (WebInspector.TextEditorMainPanel):
1118         (WebInspector.TextEditorMainPanel.prototype._wasShown):
1119         (WebInspector.TextEditorMainPanel.prototype._willHide):
1120         (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
1121         (WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
1122         (WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
1123         (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
1124         (WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
1125         (WebInspector.TextEditorMainPanel.prototype._paintLine):
1126         (WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
1127         (WebInspector.TextEditorMainPanel.prototype._handleMutations.else.get if):
1128         (WebInspector.TextEditorMainPanel.prototype._handleMutations):
1129         (WebInspector.TextEditorMainPanel.prototype._collectDirtyLines):
1130         (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
1131         * inspector/front-end/externs.js:
1132         (WebKitMutation):
1133         (WebKitMutationObserver.prototype.observe):
1134         (WebKitMutationObserver.prototype.disconnect):
1135         * inspector/front-end/textEditor.css:
1136         (.debug-fadeout):
1137         (@-webkit-keyframes debug-fadeout):
1138         (to):
1139
1140 2012-11-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1141
1142         Optimize RGBA4444ToRGBA8 packing/unpacking functions with NEON intrinsics in GraphicsContext3D
1143         https://bugs.webkit.org/show_bug.cgi?id=101473
1144
1145         Reviewed by Zoltan Herczeg.
1146
1147         With NEON intrinsics the packing/unpacking functions can be optimized well.
1148         This particular function is about 3 times faster with ARM NEON. On top level tests
1149         the speed up was 1.18x.
1150
1151         * CMakeLists.txt:
1152         * GNUmakefile.am:
1153         * GNUmakefile.list.am:
1154         * Target.pri:
1155         * WebCore.gyp/WebCore.gyp:
1156         * WebCore.gypi:
1157         * WebCore.pri:
1158         * WebCore.xcodeproj/project.pbxproj:
1159         * platform/graphics/GraphicsContext3D.cpp:
1160         (WebCore):
1161         * platform/graphics/cpu/arm/GraphicsContext3DNEON.h: Added.
1162         (WebCore):
1163         (ARM):
1164         (WebCore::ARM::unpackOneRowOfRGBA4444ToRGBA8NEON):
1165         (WebCore::ARM::packOneRowOfRGBA8ToUnsignedShort4444NEON):
1166
1167 2012-11-13  Takashi Sakamoto  <tasak@google.com>
1168
1169         Crash when replacing parts of text inputs with content: url(...)
1170         https://bugs.webkit.org/show_bug.cgi?id=101133
1171
1172         Reviewed by Kent Tamura.
1173
1174         Disable directly setting content of elements in an input element's
1175         shadow dom tree, because the setting breaks input element's behavior.
1176
1177         Tests: fast/forms/number/number-content-url-crash.html
1178                fast/forms/search/search-content-url-crash.html
1179
1180         * css/html.css:
1181         (input::-webkit-textfield-decoration-container):
1182         Use important to disable overriding an input element's content
1183         property.
1184         * html/TextFieldInputType.cpp:
1185         (WebCore::TextFieldInputType::attach):
1186         Added ASSERTION. No content should be applied to
1187         input::-webkit-textfield-decoration-container.
1188
1189 2012-11-12  Huang Dongsung  <luxtella@company100.net>
1190
1191         [Qt] REGRESSION(134142): overscaled tiles in pixel test results and MiniBrowser
1192         https://bugs.webkit.org/show_bug.cgi?id=101918
1193
1194         Reviewed by Noam Rosenthal.
1195
1196         Remove TiledBackingStore::rect(), because it is not used anymore.
1197
1198         * platform/graphics/TiledBackingStore.h:
1199         (TiledBackingStore):
1200
1201 2012-11-12  Adam Barth  <abarth@webkit.org>
1202
1203         [V8] We should be able to recover the V8DOMWindowShell more quickly
1204         https://bugs.webkit.org/show_bug.cgi?id=102020
1205
1206         Reviewed by Kentaro Hara.
1207
1208         For isolated worlds, we used to store the V8DOMWindowShell as an
1209         internal field of the inner DOM window. This patch moves the pointer to
1210         an internal field of the v8::Context, which saves us the work of
1211         looking up the inner DOM window.
1212
1213         Unfortunately, we cannot store the V8DOMWindowShell in V8PerContextData
1214         because the V8DOMWindowShell outlives the V8PerContextData. (We destroy
1215         the V8PerContextData when we detach the V8DOMWindowShell from the
1216         frame.)
1217
1218         * bindings/scripts/CodeGeneratorV8.pm:
1219         (GetInternalFields):
1220         * bindings/v8/V8DOMWindowShell.cpp:
1221         (WebCore::V8DOMWindowShell::initializeIfNeeded):
1222         * bindings/v8/V8DOMWindowShell.h:
1223         (WebCore::V8DOMWindowShell::getEntered):
1224         * bindings/v8/V8PerContextData.h:
1225
1226 2012-11-12  Kentaro Hara  <haraken@chromium.org>
1227
1228         [V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
1229         https://bugs.webkit.org/show_bug.cgi?id=101054
1230
1231         Reviewed by Adam Barth.
1232
1233         I'm investigating a Chromium crash bug:
1234         http://code.google.com/p/chromium/issues/detail?id=155942
1235
1236         I've not yet identified the root cause (because I can't reproduce
1237         the crash), but it looks like we are storing NULL pointers to
1238         V8 internal fields. Just in case, we can add an ASSERT() to
1239         guarantee that NULL pointers are never stored. (Also I'm hoping
1240         that this ASSERT() will give me more debug information.)
1241
1242         No tests. No change in behavior.
1243
1244         * bindings/v8/V8DOMWrapper.h:
1245         (WebCore::V8DOMWrapper::setDOMWrapper):
1246
1247 2012-11-12  Shinya Kawanaka  <shinyak@chromium.org>
1248
1249         Changing id, className, or attribute should invalidate distribution
1250         https://bugs.webkit.org/show_bug.cgi?id=100738
1251
1252         Reviewed by Dimitri Glazkov.
1253
1254         When id, className, or attribute is changed, we might have to invalidate distribution.
1255         However, we don't want to do useless invalidation. So we consult with the RuleFeatureSet of ElementShadow,
1256         and invalidate distribution only if necessary.
1257
1258         When className is changed, we can share a lot of code between invalidating distribution and invalidating style.
1259         So we made checkNeedsStyleInvalidationForClassChange a template method, and share it.
1260
1261         Also we've measured how this patch makes changing attribute slow. By converting checkNeedsStyleInvalidationForClassChange
1262         to template, actually this improves the performance of changing attribute code. I've measured each code 3 times.
1263
1264         DOM/ModifyAttribute.html
1265         Before this patch:
1266                 median  stdev  min      max    [ms]
1267           1st   115.62   0.67  114.75   117.00
1268           2nd   115.08   1.13  113.25   117.58
1269           3rd   114.75   1.16  113.42   117.83
1270
1271         After this patch:
1272                 median  stdev  min      max    [ms]
1273           1st   102.55   0.95  101.25   104.50
1274           2nd   103.10   0.86  102.20   100.95
1275           3rd   103.30   1.05  102.10   106.65
1276
1277         Tests: fast/dom/shadow/distribution-attribute-modified.html
1278                fast/dom/shadow/distribution-className-modified.html
1279                fast/dom/shadow/distribution-id-modified.html
1280                fast/dom/shadow/reprojection-attribute-modified.html
1281                fast/dom/shadow/reprojection-className-modified.html
1282                fast/dom/shadow/reprojection-id-modified.html
1283
1284         * dom/Element.cpp:
1285         (WebCore::Element::attributeChanged):
1286         (WebCore::HasSelectorForClassStyleFunctor::HasSelectorForClassStyleFunctor):
1287         (HasSelectorForClassStyleFunctor):
1288         (WebCore::HasSelectorForClassStyleFunctor::operator()): Returns true if StyleResolver::hasSelectorForClass returns true.
1289         (WebCore):
1290         (WebCore::HasSelectorForClassDistributionFunctor::HasSelectorForClassDistributionFunctor):
1291         (HasSelectorForClassDistributionFunctor):
1292         (WebCore::HasSelectorForClassDistributionFunctor::operator()): Returns true if ElementShadow::hasSelectorForClass returns true.
1293         (WebCore::checkFunctorForClassChange):
1294         (WebCore::checkNeedsStyleInvalidationForClassChange): Extacted the implementation to checkFunctorForClassChange.
1295         (WebCore::checkNeedsDistributionInvalidationForClassChange):
1296         (WebCore::Element::classAttributeChanged):
1297
1298 2012-11-12  Joe Mason  <jmason@rim.com>
1299
1300         [BlackBerry] NetworkJob should not check if data is received with HEAD
1301         https://bugs.webkit.org/show_bug.cgi?id=102034
1302
1303         Reviewed by George Staikos.
1304
1305         Internal PR: 241391
1306
1307         Make HEAD requests call didFinish instead of didFail on a 404 response, even though they
1308         have no data.
1309
1310         Tests: ManualTests/blackberry/head-xhr-nonexistant-file.html
1311
1312         * platform/network/blackberry/NetworkJob.cpp:
1313         (WebCore::NetworkJob::NetworkJob):
1314         (WebCore::NetworkJob::initialize):
1315         (WebCore::NetworkJob::shouldNotifyClientFailed):
1316         * platform/network/blackberry/NetworkJob.h:
1317         (NetworkJob):
1318
1319 2012-11-12  Adam Barth  <abarth@webkit.org>
1320
1321         [V8] V8DOMWrapper::instantiateV8Object shouldn't use deprecatedDocument
1322         https://bugs.webkit.org/show_bug.cgi?id=102015
1323
1324         Reviewed by Kentaro Hara.
1325
1326         Previously, Nodes had a special path through
1327         V8DOMWrapper::instantiateV8Object using deprecatedDocument so that we
1328         could find the V8PerContextData quickly. Now that we can get the
1329         V8PerContextData from the v8::Context quickly, we can move Nodes to the
1330         general case. The net consequence is that creation of all DOM objects
1331         should be as fast as Nodes are.
1332
1333         * bindings/scripts/CodeGeneratorV8.pm:
1334         (GenerateToV8Converters):
1335         * bindings/scripts/test/V8/V8Float64Array.cpp:
1336         (WebCore::V8Float64Array::wrapSlow):
1337         * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
1338         (WebCore::V8TestActiveDOMObject::wrapSlow):
1339         * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
1340         (WebCore::V8TestCustomNamedGetter::wrapSlow):
1341         * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
1342         (WebCore::V8TestEventConstructor::wrapSlow):
1343         * bindings/scripts/test/V8/V8TestEventTarget.cpp:
1344         (WebCore::V8TestEventTarget::wrapSlow):
1345         * bindings/scripts/test/V8/V8TestException.cpp:
1346         (WebCore::V8TestException::wrapSlow):
1347         * bindings/scripts/test/V8/V8TestInterface.cpp:
1348         (WebCore::V8TestInterface::wrapSlow):
1349         * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
1350         (WebCore::V8TestMediaQueryListListener::wrapSlow):
1351         * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
1352         (WebCore::V8TestNamedConstructor::wrapSlow):
1353         * bindings/scripts/test/V8/V8TestNode.cpp:
1354         (WebCore::V8TestNode::wrapSlow):
1355         * bindings/scripts/test/V8/V8TestObj.cpp:
1356         (WebCore::V8TestObj::wrapSlow):
1357         * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
1358         (WebCore::V8TestOverloadedConstructors::wrapSlow):
1359         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
1360         (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
1361         * bindings/v8/V8Binding.cpp:
1362         * bindings/v8/V8Binding.h:
1363         (WebCore):
1364         * bindings/v8/V8DOMWrapper.cpp:
1365         (WebCore::V8DOMWrapper::instantiateV8Object):
1366         * bindings/v8/V8DOMWrapper.h:
1367         (V8DOMWrapper):
1368
1369 2012-11-12  KyungTae Kim  <ktf.kim@samsung.com>
1370
1371         Some CSS properties are not handled on StyleResolver::applyProperty
1372         https://bugs.webkit.org/show_bug.cgi?id=102027
1373
1374         Reviewed by Gyuyoung Kim.
1375
1376         The CSSPropertyMaxZoom, CSSPropertyMinZoom, CSSPropertyOrientation and CSSPropertyUserZoom
1377         need to be handled on StyleResolver::applyProperty.
1378
1379         * css/StyleResolver.cpp:
1380         (WebCore::StyleResolver::applyProperty):
1381
1382 2012-11-12  Simon Fraser  <simon.fraser@apple.com>
1383
1384         Avoid calling calculateLayerBounds() and convertToLayerCoords() more than once per layer paint
1385         https://bugs.webkit.org/show_bug.cgi?id=102031
1386
1387         Reviewed by Beth Dakin.
1388
1389         RenderLayer::paintLayerContents() and callees could end up calling convertToLayerCoords()
1390         and calculateLayerBounds() multiple times for painting a single layer.
1391         
1392         Keep track of whether we've computed the root-relative bounds and do it on demand.
1393         Compute the offset relative to rootLayer once, and pass it around as an optional parameter
1394         to functions that need it.
1395
1396         * rendering/RenderLayer.cpp:
1397         (WebCore::RenderLayer::paintLayerContents):
1398         (WebCore::RenderLayer::hitTestLayer):
1399         (WebCore::RenderLayer::calculateRects):
1400         (WebCore::RenderLayer::intersectsDamageRect):
1401         (WebCore::RenderLayer::boundingBox):
1402         (WebCore::RenderLayer::calculateLayerBounds):
1403         * rendering/RenderLayer.h:
1404         * rendering/RenderLayerCompositor.cpp:
1405         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
1406
1407 2012-11-12  Simon Fraser  <simon.fraser@apple.com>
1408
1409         Change calculateLayerBounds() from a static function to a member function
1410         https://bugs.webkit.org/show_bug.cgi?id=102022
1411
1412         Reviewed by Beth Dakin.
1413
1414         calculateLayerBounds() has grown into a substantial function after
1415         starting live as a little utility function, so make it a member function
1416         of RenderLayer, and adjust callers accordingly.
1417
1418         * rendering/RenderLayer.cpp:
1419         (WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
1420         (WebCore::RenderLayer::paintLayerContents):
1421         (WebCore::RenderLayer::calculateLayerBounds):
1422         * rendering/RenderLayer.h:
1423         * rendering/RenderLayerCompositor.cpp:
1424         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
1425
1426 2012-11-12  Alexei Filippov  <alph@chromium.org>
1427
1428         Web Inspector: Add an option to switch display of "Other" memory on/off in NMI
1429         https://bugs.webkit.org/show_bug.cgi?id=101601
1430
1431         Reviewed by Yury Semikhatsky.
1432
1433         * English.lproj/localizedStrings.js:
1434         * inspector/front-end/NativeMemorySnapshotView.js:
1435         * inspector/front-end/Settings.js:
1436         * inspector/front-end/SettingsScreen.js:
1437         (WebInspector.GenericSettingsTab):
1438
1439 2012-11-10  Dirk Schulze  <krit@webkit.org>
1440
1441         BasicShapes 'circle', 'rectangle', 'ellipse' should be animatable with themselves
1442         https://bugs.webkit.org/show_bug.cgi?id=101854
1443
1444         Reviewed by Andreas Kling.
1445
1446         The basic shapes BasicShapeCircle, BasicShapeEllipse and BasicShapeRectangle should
1447         blend with themselves. This patch introduces simple interpolation of BasicShapes for
1448         the -webkit-clip-path property.
1449
1450         Test: css3/masking/clip-path-animation.html
1451
1452         * page/animation/CSSPropertyAnimation.cpp:
1453         (WebCore::blendFunc): Added a new function that blends between two BasicShape objects.
1454             It skips blending on <clipPath> references, polygons and if the shapes are not of
1455             the same type.
1456         (WebCore):
1457         (PropertyWrapperClipPath): Added new wrapper for ClipPathShapes.
1458         (WebCore::PropertyWrapperClipPath::PropertyWrapperClipPath): Ditto.
1459         (WebCore::CSSPropertyAnimation::ensurePropertyMap): Add -webkit-clip-path to animatable
1460             properties.
1461         * rendering/style/BasicShapes.cpp:
1462             The blending is done by each shape itself. This is similar to FilterOperations or
1463             TransformOperations.
1464         (WebCore::BasicShapeRectangle::blend):
1465         (WebCore):
1466         (WebCore::BasicShapeCircle::blend):
1467         (WebCore::BasicShapeEllipse::blend):
1468         (WebCore::BasicShapePolygon::blend):
1469         * rendering/style/BasicShapes.h:
1470             Added new blending functions to header.
1471         (BasicShape):
1472         (BasicShapeRectangle):
1473         (BasicShapeCircle):
1474         (BasicShapeEllipse):
1475         (BasicShapePolygon):
1476
1477 2012-11-12  Adam Barth  <abarth@webkit.org>
1478
1479         [V8] We should be able to get V8PerContextData from a v8::Context more quickly
1480         https://bugs.webkit.org/show_bug.cgi?id=102008
1481
1482         Reviewed by Ojan Vafai.
1483
1484         This patch uses the new v8::Context::GetAlignedPointerFromEmbedderData
1485         API to get the V8PerContextData associated with a v8::Context much more
1486         quickly. We no longer need to use a hidden property on the inner global
1487         object. This patch will enable future optimizations.
1488
1489         * bindings/v8/V8HiddenPropertyName.h:
1490         (WebCore):
1491         * bindings/v8/V8PerContextData.cpp:
1492         (WebCore::V8PerContextData::dispose):
1493         (WebCore::V8PerContextData::init):
1494         * bindings/v8/V8PerContextData.h:
1495         (WebCore::V8PerContextData::from):
1496
1497 2012-11-12  Elliott Sprehn  <esprehn@chromium.org>
1498
1499         Make Frames and HTMLFrameOwnerElement less friendly
1500         https://bugs.webkit.org/show_bug.cgi?id=102003
1501
1502         Reviewed by Ojan Vafai.
1503
1504         Frame used to assign HTMLFrameOwnerElement's m_contentFrame directly
1505         this patch makes it go through a method to allow future hooks when frames
1506         are associated with owners.
1507
1508         No new tests, this is just a refactor.
1509
1510         * html/HTMLFrameOwnerElement.cpp:
1511         (WebCore::HTMLFrameOwnerElement::setContentFrame):
1512         * html/HTMLFrameOwnerElement.h:
1513         (HTMLFrameOwnerElement):
1514         (WebCore::HTMLFrameOwnerElement::clearContentFrame):
1515         * page/Frame.cpp:
1516         (WebCore::Frame::Frame): Use new methods.
1517
1518 2012-11-12  Beth Dakin  <bdakin@apple.com>
1519
1520         Zoomed-in scrolling is very slow when deviceScaleFactor > 1
1521         https://bugs.webkit.org/show_bug.cgi?id=101787
1522
1523         Reviewed by Simon Fraser.
1524
1525         This patch adds a new member to the GraphicsContextState that tracks 
1526         whether or not fonts should be subpixel-quantized. We want to default 
1527         to sibpixel-quantizing, but we'll turn it off if we're scrolling 
1528         content that cannot be scrolled on the scrolling thread.
1529
1530         State has a new bool shouldSubpixelQuantizeFonts. It defaults to true 
1531         since normally we do want to quantize.
1532         * platform/graphics/GraphicsContext.cpp:
1533         (WebCore::GraphicsContext::setShouldSubpixelQuantizeFonts):
1534         (WebCore::GraphicsContext::shouldSubpixelQuantizeFonts):
1535         * platform/graphics/GraphicsContext.h:
1536         (WebCore::GraphicsContextState::GraphicsContextState):
1537         (GraphicsContextState):
1538         (GraphicsContext):
1539
1540         wkSetCGFontRenderingMode now takes a BOOL parameter which indicates 
1541         whether or not it should try to subpixel-quantize the fonts.
1542         * platform/graphics/mac/FontMac.mm:
1543         (WebCore::Font::drawGlyphs):
1544         * platform/mac/WebCoreSystemInterface.h:
1545         * platform/mac/WebCoreSystemInterface.mm:
1546
1547         Disable subpixel-quantization for overflow areas, subframes, and 
1548         content that is scrolling on the main thread.
1549         * rendering/RenderLayer.cpp:
1550         (WebCore::RenderLayer::paintLayerContents):
1551
1552 2012-11-12  Timothy Hatcher  <timothy@apple.com>
1553
1554         Expose InspectorFrontendClientLocal::setAttachedWindow as public.
1555
1556         This allows external actions to update the docked state in the frontend.
1557
1558         https://bugs.webkit.org/show_bug.cgi?id=102023
1559
1560         Reviewed by Anders Carlsson.
1561
1562         * inspector/InspectorFrontendClientLocal.h:
1563         Moved InspectorFrontendClientLocal::setAttachedWindow to public section.
1564
1565 2012-11-12  Erik Arvidsson  <arv@chromium.org>
1566
1567         Replace DOMException TYPE_MISMATCH_ERR with TypeError
1568         https://bugs.webkit.org/show_bug.cgi?id=101604
1569
1570         Reviewed by Adam Barth.
1571
1572         DOMException.TYPE_MISMATCH_ERR is deprecated in favor of using TypeError.
1573
1574         We have historically used TYPE_MISMATCH_ERR as a blanket DOMException code when
1575         the spec mandates TypeError being thrown.
1576
1577         Updated existing tests.
1578
1579         * Modules/mediastream/MediaConstraintsImpl.cpp:
1580         * Modules/mediastream/MediaStreamTrackList.cpp:
1581         * Modules/mediastream/PeerConnection00.cpp:
1582         * Modules/mediastream/RTCDataChannel.cpp:
1583         * Modules/mediastream/RTCIceCandidate.cpp:
1584         * Modules/mediastream/RTCPeerConnection.cpp:
1585         * Modules/mediastream/RTCSessionDescription.cpp:
1586         * Modules/mediastream/SessionDescription.cpp:
1587         * bindings/js/CallbackFunction.cpp:
1588         * bindings/js/JSCustomXPathNSResolver.cpp:
1589         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
1590         * bindings/js/JSHTMLSelectElementCustom.cpp:
1591         * bindings/js/JSMutationObserverCustom.cpp:
1592         * bindings/js/JSSQLResultSetRowListCustom.cpp:
1593         * bindings/js/JSSQLTransactionCustom.cpp:
1594         * bindings/js/JSSQLTransactionSyncCustom.cpp:
1595         * bindings/scripts/CodeGeneratorJS.pm:
1596         * bindings/scripts/CodeGeneratorObjC.pm:
1597         * bindings/scripts/CodeGeneratorV8.pm:
1598         * bindings/v8/V8Callback.h:
1599         * bindings/v8/V8Collection.cpp:
1600         * bindings/v8/custom/V8DocumentCustom.cpp:
1601         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
1602         * bindings/v8/custom/V8MutationObserverCustom.cpp:
1603         * bindings/v8/custom/V8SQLTransactionCustom.cpp:
1604         * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
1605         * dom/DOMCoreException.idl:
1606         * html/HTMLElement.cpp:
1607         * html/HTMLMediaElement.cpp:
1608         * html/HTMLOptionsCollection.cpp:
1609         * html/canvas/CanvasRenderingContext2D.cpp:
1610         * page/Crypto.cpp:
1611         * page/DOMSelection.cpp:
1612         * svg/properties/SVGTransformListPropertyTearOff.h:
1613
1614 2012-11-12  Joshua Bell  <jsbell@chromium.org>
1615
1616         IndexedDB: Use sequence<> instead of DOMString[] in IDL
1617         https://bugs.webkit.org/show_bug.cgi?id=100539
1618
1619         Reviewed by Adam Barth.
1620
1621         In the binding layer, DOMString[] is implemented as an alias for DOMStringList.
1622         WebIDL usage is tending towards sequence<DOMString> anyway for inputs, so switch
1623         to that. Note webkit.org/b/100537 which requires sequence<String> instead.
1624
1625         Covered by storage/indexeddb/transaction-basics.html and objectstore-basics.html
1626
1627         * Modules/indexeddb/IDBDatabase.cpp:
1628         (WebCore::IDBDatabase::transaction): DOMStringList -> Vector<String>
1629         * Modules/indexeddb/IDBDatabase.h:
1630         (WebCore::IDBDatabase::transaction):
1631         (IDBDatabase):
1632         * Modules/indexeddb/IDBDatabase.idl: DOMString[] -> sequence<String>
1633         * Modules/indexeddb/IDBObjectStore.cpp: Move trivial impls to header.
1634         * Modules/indexeddb/IDBObjectStore.h:
1635         (WebCore::IDBObjectStore::createIndex):
1636         * Modules/indexeddb/IDBObjectStore.idl: DOMString[] -> sequence<String>
1637
1638 2012-11-12  Anders Carlsson  <andersca@apple.com>
1639
1640         Remove Leopard only gradient code
1641         https://bugs.webkit.org/show_bug.cgi?id=102033
1642
1643         Reviewed by Dan Bernstein.
1644
1645         USE_CG_SHADING was only ever true on Leopard, so we can remove it now.
1646
1647         * platform/graphics/Gradient.h:
1648         * platform/graphics/cg/GradientCG.cpp:
1649         (WebCore::Gradient::platformDestroy):
1650         (WebCore::Gradient::platformGradient):
1651         (WebCore::Gradient::paint):
1652
1653 2012-11-12  Tiancheng Jiang  <tijiang@rim.com>
1654
1655         [BlackBerry] Update BB10 form theme.
1656         https://bugs.webkit.org/show_bug.cgi?id=100760
1657
1658         Reviewed by Rob Buis.
1659
1660         RIM PR 237003
1661         Internally Reviewed by Eli Fidler.
1662         Since we nolonger use small font for form controls, adjust paddingDivisor
1663         ratio to decrease the padding value.
1664
1665         * platform/blackberry/RenderThemeBlackBerry.cpp:
1666         (WebCore):
1667
1668 2012-11-12  Simon Fraser  <simon.fraser@apple.com>
1669
1670         Fix filter dirty rect regression from r134311
1671         https://bugs.webkit.org/show_bug.cgi?id=102002
1672
1673         Reviewed by Beth Dakin.
1674
1675         When rendering with filters, the code can inflate the root-relative
1676         paintDirtyRect in RenderLayer::paintLayerContents(), and my cleanup
1677         broke this behavior.
1678     
1679         Fix by making a local copy of LayerPaintingInfo, updating its paintDirtyRect,
1680         and using it for the rest of the function.
1681
1682         * rendering/RenderLayer.cpp:
1683         (WebCore::RenderLayer::paintLayerContents):
1684
1685 2012-11-12  Kentaro Hara  <haraken@chromium.org>
1686
1687         [V8] V8Event::valueAccessorGetter() in custom binding is not used
1688         https://bugs.webkit.org/show_bug.cgi?id=101893
1689
1690         Reviewed by Adam Barth.
1691
1692         No tests. No change in behavior.
1693
1694         * bindings/v8/custom/V8EventCustom.cpp:
1695
1696 2012-11-12  Roger Fong  <roger_fong@apple.com>
1697
1698         Web Inspector: Fix docking behaviour on Windows.
1699         https://bugs.webkit.org/show_bug.cgi?id=101978
1700
1701         Reviewed by Brian Weinstein.
1702
1703         There are a number of problems with docking behaviour on Windows.
1704         For starters, it does not ever constrain the inspector's size properly while docked.
1705         It also does not properly set the whether or not the inspector can be docked/undocked.
1706         This patch fixes both issues.
1707
1708         * inspector/InspectorFrontendClientLocal.cpp:
1709         (WebCore::InspectorFrontendClientLocal::frontendLoaded):
1710         Switch order of calling bringToFront and setDockingUnavailable.
1711
1712 2012-11-12  Adam Barth  <abarth@webkit.org>
1713
1714         [V8] Update callers to use the aligned pointer API rather than the deprecated unaligned pointer API
1715         https://bugs.webkit.org/show_bug.cgi?id=101519
1716
1717         Reviewed by Ojan Vafai.
1718
1719         There should be no change in behavior.  The new API is slightly faster
1720         than the old API (and apparently works correctly internally in V8).
1721
1722         * bindings/scripts/CodeGeneratorV8.pm:
1723         (GenerateHeader):
1724         * bindings/scripts/test/V8/V8Float64Array.h:
1725         (WebCore::V8Float64Array::toNative):
1726         * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
1727         (WebCore::V8TestActiveDOMObject::toNative):
1728         * bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
1729         (WebCore::V8TestCustomNamedGetter::toNative):
1730         * bindings/scripts/test/V8/V8TestEventConstructor.h:
1731         (WebCore::V8TestEventConstructor::toNative):
1732         * bindings/scripts/test/V8/V8TestEventTarget.h:
1733         (WebCore::V8TestEventTarget::toNative):
1734         * bindings/scripts/test/V8/V8TestException.h:
1735         (WebCore::V8TestException::toNative):
1736         * bindings/scripts/test/V8/V8TestInterface.h:
1737         (WebCore::V8TestInterface::toNative):
1738         * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
1739         (WebCore::V8TestMediaQueryListListener::toNative):
1740         * bindings/scripts/test/V8/V8TestNamedConstructor.h:
1741         (WebCore::V8TestNamedConstructor::toNative):
1742         * bindings/scripts/test/V8/V8TestNode.h:
1743         (WebCore::V8TestNode::toNative):
1744         * bindings/scripts/test/V8/V8TestObj.h:
1745         (WebCore::V8TestObj::toNative):
1746         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
1747         (WebCore::V8TestSerializedScriptValueInterface::toNative):
1748         * bindings/v8/NPV8Object.cpp:
1749         (WebCore::v8ObjectToNPObject):
1750         (WebCore::npCreateV8ScriptObject):
1751         * bindings/v8/V8Collection.h:
1752         (WebCore::toNativeCollection):
1753         * bindings/v8/V8DOMWindowShell.cpp:
1754         (WebCore::setIsolatedWorldField):
1755         (WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
1756         * bindings/v8/V8DOMWrapper.cpp:
1757         (WebCore::V8DOMWrapper::isWrapperOfType):
1758         * bindings/v8/V8DOMWrapper.h:
1759         (WebCore::V8DOMWrapper::setDOMWrapper):
1760         (WebCore::V8DOMWrapper::clearDOMWrapper):
1761         * bindings/v8/WrapperTypeInfo.h:
1762         (WebCore::toNative):
1763         (WebCore::toWrapperTypeInfo):
1764
1765 2012-11-12  Andreas Kling  <kling@webkit.org>
1766
1767         Rename AttributeStyle => PresentationAttributeStyle across WebCore.
1768         <http://webkit.org/b/101975>
1769
1770         Rubber-stamped by Antti Koivisto.
1771
1772         The completely separate concepts of "attribute style" and "style attribute" were a bit too
1773         easy to confuse in variable and method names. Reconfigure our terminology to call it
1774         "presentation attribute style" instead of "attribute style".
1775
1776         * css/StyleResolver.cpp:
1777         (WebCore::StyleResolver::sweepMatchedPropertiesCache):
1778         (WebCore::StyleResolver::matchAllRules):
1779         (WebCore::StyleResolver::canShareStyleWithElement):
1780         * dom/Attr.cpp:
1781         (WebCore::Attr::style):
1782         * dom/ElementAttributeData.cpp:
1783         (WebCore::MutableElementAttributeData::MutableElementAttributeData):
1784         (WebCore::ElementAttributeData::reportMemoryUsage):
1785         * dom/ElementAttributeData.h:
1786         (WebCore::ElementAttributeData::presentationAttributeStyle):
1787         (WebCore::ElementAttributeData::setPresentationAttributeStyle):
1788         (ElementAttributeData):
1789         * dom/Node.h:
1790         (WebCore::Node::attributeStyleDirty):
1791         (WebCore::Node::setPresentationAttributeStyleDirty):
1792         (WebCore::Node::clearPresentationAttributeStyleDirty):
1793         * dom/StyledElement.cpp:
1794         (WebCore::StyledElement::attributeChanged):
1795         (WebCore::StyledElement::rebuildPresentationAttributeStyle):
1796         (WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
1797         * dom/StyledElement.h:
1798         (WebCore::StyledElement::additionalPresentationAttributeStyle):
1799         (StyledElement):
1800         (WebCore::StyledElement::collectStyleForPresentationAttribute):
1801         (WebCore::StyledElement::presentationAttributeStyle):
1802         * html/HTMLBRElement.cpp:
1803         (WebCore::HTMLBRElement::collectStyleForPresentationAttribute):
1804         * html/HTMLBRElement.h:
1805         (HTMLBRElement):
1806         * html/HTMLBodyElement.cpp:
1807         (WebCore::HTMLBodyElement::collectStyleForPresentationAttribute):
1808         * html/HTMLBodyElement.h:
1809         (HTMLBodyElement):
1810         * html/HTMLDivElement.cpp:
1811         (WebCore::HTMLDivElement::collectStyleForPresentationAttribute):
1812         * html/HTMLDivElement.h:
1813         (HTMLDivElement):
1814         * html/HTMLElement.cpp:
1815         (WebCore::HTMLElement::applyBorderAttributeToStyle):
1816         (WebCore::HTMLElement::mapLanguageAttributeToLocale):
1817         (WebCore::HTMLElement::collectStyleForPresentationAttribute):
1818         (WebCore::HTMLElement::applyAlignmentAttributeToStyle):
1819         (WebCore::HTMLElement::addHTMLLengthToStyle):
1820         * html/HTMLElement.h:
1821         (HTMLElement):
1822         * html/HTMLEmbedElement.cpp:
1823         (WebCore::HTMLEmbedElement::collectStyleForPresentationAttribute):
1824         * html/HTMLEmbedElement.h:
1825         (HTMLEmbedElement):
1826         * html/HTMLFontElement.cpp:
1827         (WebCore::HTMLFontElement::collectStyleForPresentationAttribute):
1828         * html/HTMLFontElement.h:
1829         (HTMLFontElement):
1830         * html/HTMLFrameSetElement.cpp:
1831         (WebCore::HTMLFrameSetElement::collectStyleForPresentationAttribute):
1832         * html/HTMLFrameSetElement.h:
1833         (HTMLFrameSetElement):
1834         * html/HTMLHRElement.cpp:
1835         (WebCore::HTMLHRElement::collectStyleForPresentationAttribute):
1836         * html/HTMLHRElement.h:
1837         (HTMLHRElement):
1838         * html/HTMLIFrameElement.cpp:
1839         (WebCore::HTMLIFrameElement::collectStyleForPresentationAttribute):
1840         * html/HTMLIFrameElement.h:
1841         (HTMLIFrameElement):
1842         * html/HTMLImageElement.cpp:
1843         (WebCore::HTMLImageElement::collectStyleForPresentationAttribute):
1844         * html/HTMLImageElement.h:
1845         (HTMLImageElement):
1846         * html/HTMLInputElement.cpp:
1847         (WebCore::HTMLInputElement::collectStyleForPresentationAttribute):
1848         * html/HTMLInputElement.h:
1849         (HTMLInputElement):
1850         * html/HTMLLIElement.cpp:
1851         (WebCore::HTMLLIElement::collectStyleForPresentationAttribute):
1852         * html/HTMLLIElement.h:
1853         (HTMLLIElement):
1854         * html/HTMLMarqueeElement.cpp:
1855         (WebCore::HTMLMarqueeElement::collectStyleForPresentationAttribute):
1856         * html/HTMLMarqueeElement.h:
1857         (HTMLMarqueeElement):
1858         * html/HTMLOListElement.cpp:
1859         (WebCore::HTMLOListElement::collectStyleForPresentationAttribute):
1860         * html/HTMLOListElement.h:
1861         (HTMLOListElement):
1862         * html/HTMLObjectElement.cpp:
1863         (WebCore::HTMLObjectElement::collectStyleForPresentationAttribute):
1864         * html/HTMLObjectElement.h:
1865         (HTMLObjectElement):
1866         * html/HTMLParagraphElement.cpp:
1867         (WebCore::HTMLParagraphElement::collectStyleForPresentationAttribute):
1868         * html/HTMLParagraphElement.h:
1869         (HTMLParagraphElement):
1870         * html/HTMLPlugInElement.cpp:
1871         (WebCore::HTMLPlugInElement::collectStyleForPresentationAttribute):
1872         * html/HTMLPlugInElement.h:
1873         (HTMLPlugInElement):
1874         * html/HTMLPreElement.cpp:
1875         (WebCore::HTMLPreElement::collectStyleForPresentationAttribute):
1876         * html/HTMLPreElement.h:
1877         (HTMLPreElement):
1878         * html/HTMLTableCaptionElement.cpp:
1879         (WebCore::HTMLTableCaptionElement::collectStyleForPresentationAttribute):
1880         * html/HTMLTableCaptionElement.h:
1881         (HTMLTableCaptionElement):
1882         * html/HTMLTableCellElement.cpp:
1883         (WebCore::HTMLTableCellElement::collectStyleForPresentationAttribute):
1884         (WebCore::HTMLTableCellElement::additionalPresentationAttributeStyle):
1885         * html/HTMLTableCellElement.h:
1886         (HTMLTableCellElement):
1887         * html/HTMLTableColElement.cpp:
1888         (WebCore::HTMLTableColElement::collectStyleForPresentationAttribute):
1889         (WebCore::HTMLTableColElement::additionalPresentationAttributeStyle):
1890         * html/HTMLTableColElement.h:
1891         (HTMLTableColElement):
1892         * html/HTMLTableElement.cpp:
1893         (WebCore::HTMLTableElement::collectStyleForPresentationAttribute):
1894         (WebCore::HTMLTableElement::additionalPresentationAttributeStyle):
1895         * html/HTMLTableElement.h:
1896         (HTMLTableElement):
1897         * html/HTMLTablePartElement.cpp:
1898         (WebCore::HTMLTablePartElement::collectStyleForPresentationAttribute):
1899         * html/HTMLTablePartElement.h:
1900         (HTMLTablePartElement):
1901         * html/HTMLTableSectionElement.cpp:
1902         (WebCore::HTMLTableSectionElement::additionalPresentationAttributeStyle):
1903         * html/HTMLTableSectionElement.h:
1904         (HTMLTableSectionElement):
1905         * html/HTMLTextAreaElement.cpp:
1906         (WebCore::HTMLTextAreaElement::collectStyleForPresentationAttribute):
1907         * html/HTMLTextAreaElement.h:
1908         (HTMLTextAreaElement):
1909         * html/HTMLUListElement.cpp:
1910         (WebCore::HTMLUListElement::collectStyleForPresentationAttribute):
1911         * html/HTMLUListElement.h:
1912         (HTMLUListElement):
1913         * html/HTMLVideoElement.cpp:
1914         (WebCore::HTMLVideoElement::collectStyleForPresentationAttribute):
1915         * html/HTMLVideoElement.h:
1916         (HTMLVideoElement):
1917         * inspector/InspectorCSSAgent.cpp:
1918         (WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
1919         * mathml/MathMLElement.cpp:
1920         (WebCore::MathMLElement::collectStyleForPresentationAttribute):
1921         * mathml/MathMLElement.h:
1922         (MathMLElement):
1923         * svg/SVGImageElement.cpp:
1924         (WebCore::SVGImageElement::collectStyleForPresentationAttribute):
1925         * svg/SVGImageElement.h:
1926         (SVGImageElement):
1927         * svg/SVGStyledElement.cpp:
1928         (WebCore::SVGStyledElement::collectStyleForPresentationAttribute):
1929         * svg/SVGStyledElement.h:
1930         (SVGStyledElement):
1931         * svg/SVGTextContentElement.cpp:
1932         (WebCore::SVGTextContentElement::collectStyleForPresentationAttribute):
1933         * svg/SVGTextContentElement.h:
1934         (SVGTextContentElement):
1935
1936 2012-11-12  Adam Barth  <abarth@webkit.org>
1937
1938         [V8] Many things crash when switching to V8's new aligned pointer API
1939         https://bugs.webkit.org/show_bug.cgi?id=101994
1940
1941         Reviewed by Eric Seidel.
1942
1943         When using the aligned pointer API, we need to make sure to initialize
1944         every internal field that we later read because the new API has better
1945         error checks than the old API. This patch explicitly initializes the
1946         enteredIsolatedWorldIndex internal field to zero for main worlds,
1947         fixing the LayoutTest crashes from our previous attempt to move the
1948         aligned pointer API.
1949
1950         * bindings/v8/V8DOMWindowShell.cpp:
1951         (WebCore::V8DOMWindowShell::initializeIfNeeded):
1952
1953 2012-11-12  Simon Fraser  <simon.fraser@apple.com>
1954
1955         Reduce the crazy number of parameters to RenderLayer painting member functions
1956         https://bugs.webkit.org/show_bug.cgi?id=101895
1957
1958         Reviewed by Beth Dakin.
1959
1960         The various RenderLayer::paintLayer* functions took a lot of arguments, most
1961         of which were passed down directly to descendants.
1962         
1963         Gather these arguments into a LayerPaintingInfo struct.
1964
1965         * rendering/RenderLayer.cpp:
1966         (WebCore::RenderLayer::paint): Create a LayerPaintingInfo struct to pass
1967         to descendant paint calls.
1968         (WebCore::RenderLayer::paintOverlayScrollbars): Ditto.
1969         (WebCore::RenderLayer::paintLayer): When painting transformed layers, we
1970         make a new LayerPaintingInfo because the root layer is shifted.
1971         (WebCore::RenderLayer::paintLayerContentsAndReflection):
1972         (WebCore::RenderLayer::paintLayerContents):
1973         (WebCore::RenderLayer::paintList):
1974         (WebCore::RenderLayer::paintPaginatedChildLayer):
1975         (WebCore::RenderLayer::paintChildLayerIntoColumns): Create a new LayerPaintingInfo
1976         struct for column painting.
1977         * rendering/RenderLayer.h:
1978         (WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
1979         (LayerPaintingInfo):
1980         * rendering/RenderLayerBacking.cpp:
1981         (WebCore::RenderLayerBacking::paintIntoLayer): Build a LayerPaintingInfo
1982         to enter layer painting.
1983         * rendering/RenderReplica.cpp:
1984         (WebCore::RenderReplica::paint): Ditto.
1985
1986 2012-11-12  Brady Eidson  <beidson@apple.com>
1987
1988         NetworkProcess: Use an accurate shouldContentSniff value when creating ResourceHandles
1989         https://bugs.webkit.org/show_bug.cgi?id=101872
1990
1991         Reviewed by Alexey Proskuryakov.
1992
1993         Expose shouldSniffContent to pass it along to the NetworkProcess.
1994
1995         * loader/ResourceLoader.h:
1996         (WebCore::ResourceLoader::shouldSniffContent):
1997
1998 2012-11-12  Christophe Dumez  <christophe.dumez@intel.com>
1999
2000         Fix memory leak in createSurfaceForBackingStore()
2001         https://bugs.webkit.org/show_bug.cgi?id=101941
2002
2003         Reviewed by Kenneth Rohde Christiansen.
2004
2005         Fix memory leak in createSurfaceForBackingStore(),
2006         the RefPtr<cairo_surface_t> should be released
2007         when returned since we pass ownership to the
2008         caller.
2009
2010         No new tests, no behavior change for layout tests.
2011
2012         * platform/graphics/efl/CairoUtilitiesEfl.cpp:
2013         (WebCore::createSurfaceForBackingStore):
2014
2015 2012-11-12  Joe Mason  <jmason@rim.com>
2016
2017         [BlackBerry] Update to new proxyInfo API
2018         https://bugs.webkit.org/show_bug.cgi?id=101945
2019
2020         Reviewed by George Staikos.
2021
2022         Internal PR: 234680
2023         Reviewed internally by: Leo Yang
2024
2025         The proxyAddress, proxyUsername and proxyPassword methods in BlackBerry::Platform::Settings
2026         have been replaced with a single, more efficient proxyInfo method.
2027
2028         No new tests because this is an API update with no behaviour change.
2029
2030         * platform/network/blackberry/NetworkJob.cpp:
2031         (WebCore::NetworkJob::sendRequestWithCredentials):
2032         (WebCore::NetworkJob::storeCredentials):
2033
2034 2012-11-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2035
2036         Unreviewed, rolling out r126157.
2037         http://trac.webkit.org/changeset/126157
2038         https://bugs.webkit.org/show_bug.cgi?id=101954
2039
2040         This patch caused (untestable) regression of the volume
2041         property on Mac, Win, and Blackberry ports. (Requested by
2042         jernoble on #webkit).
2043
2044         * platform/graphics/MediaPlayer.cpp:
2045         (WebCore::MediaPlayer::loadWithNextMediaEngine):
2046         (WebCore::MediaPlayer::setVolume):
2047         (WebCore::MediaPlayer::setMuted):
2048         (WebCore::MediaPlayer::setPreservesPitch):
2049         (WebCore::MediaPlayer::setSize):
2050         (WebCore::MediaPlayer::setVisible):
2051         (WebCore::MediaPlayer::setPreload):
2052
2053 2012-11-12  Arpita Bahuguna  <arpitabahuguna@gmail.com>
2054
2055         Specified width CSS tables should not include border and padding as part of that width.
2056         https://bugs.webkit.org/show_bug.cgi?id=77028
2057
2058         Reviewed by Julien Chaffraix.
2059
2060         CSS table width should not include border and padding even though HTML
2061         tables size as though their width includes border/padding.
2062
2063         This is applicable for all CSS tables with specified widths.
2064
2065         The change would also make our rendering of CSS tables with specified
2066         width similar to that of Opera, IE and FF.
2067
2068         Test: fast/table/css-table-width-with-border-padding.html
2069
2070         * rendering/RenderTable.cpp:
2071         (WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
2072         Added check for all (positive) specified widths for CSS tables to
2073         consider border and padding outside of the specified width.
2074
2075 2012-11-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2076
2077         Move resolving blob references to FormData.
2078         https://bugs.webkit.org/show_bug.cgi?id=101754
2079
2080         Reviewed by Simon Hausmann.
2081
2082         Resolving Blob-references to a set of just File and Data is done similar by several platforms.
2083         This patch adds a generic implementation in FormData and uses that from CFNetwork, Qt and
2084         BlackBerry network implementation.
2085
2086         * platform/network/FormData.cpp:
2087         (WebCore::appendBlobResolved):
2088         (WebCore::FormData::resolveBlobReferences):
2089         * platform/network/FormData.h:
2090         * platform/network/blackberry/ResourceRequestBlackBerry.cpp:
2091         (WebCore::ResourceRequest::initializePlatformRequest):
2092         * platform/network/cf/FormDataStreamCFNet.cpp:
2093         (WebCore::setHTTPBody):
2094         * platform/network/qt/QNetworkReplyHandler.cpp:
2095         (WebCore::FormDataIODevice::prepareFormElements):
2096
2097 2012-11-12  Zeno Albisser  <zeno@webkit.org>
2098
2099         GraphicsSurfaceGLX does not handle transparency correctly.
2100         https://bugs.webkit.org/show_bug.cgi?id=101943
2101
2102         GraphicsSurfacGLX must consistently use RGBA texture format.
2103         glXCreateWindow must be called after creating the XWindow
2104         that serves as a temporary offscreen texture storage, in order
2105         to allow for transparency.
2106         When creating the offscreen XWindow we must make sure,
2107         that we use a framebuffer configuration that supports
2108         an alpha mask.
2109
2110         Reviewed by Noam Rosenthal.
2111
2112         * platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
2113         (WebCore):
2114         (WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
2115         (WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
2116         (WebCore::GraphicsSurfacePrivate::createSurface):
2117         (GraphicsSurfacePrivate):
2118         (WebCore::GraphicsSurface::platformPaintToTextureMapper):
2119
2120 2012-11-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2121
2122         Unreviewed, rolling out r134225.
2123         http://trac.webkit.org/changeset/134225
2124         https://bugs.webkit.org/show_bug.cgi?id=101948
2125
2126         Appears to have broken the EFL and GTK builds (Requested by
2127         abarth on #webkit).
2128
2129         * bindings/js/JSHTMLElementCustom.cpp:
2130         (WebCore):
2131         (WebCore::JSHTMLElement::itemValue):
2132         (WebCore::JSHTMLElement::setItemValue):
2133         * bindings/v8/custom/V8HTMLElementCustom.cpp:
2134         (WebCore):
2135         (WebCore::V8HTMLElement::itemValueAccessorGetter):
2136         (WebCore::V8HTMLElement::itemValueAccessorSetter):
2137         * html/HTMLElement.idl:
2138
2139 2012-11-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2140
2141         hitTestResultAtPoint does two hit-tests if called on non main frame
2142         https://bugs.webkit.org/show_bug.cgi?id=101915
2143
2144         Reviewed by Antonio Gomes.
2145
2146         Always redirect hitTestResultAtPoint to the main-frame. This used to being
2147         done on every result that hit anything, which caused running the expensive 
2148         hit-tests multiple times in almost all cases.
2149
2150         * page/EventHandler.cpp:
2151         (WebCore::EventHandler::hitTestResultAtPoint):
2152
2153 2012-11-12  Kentaro Hara  <haraken@chromium.org>
2154
2155         [V8][JSC] ScriptProfileNode::callUID needs not to be [Custom]
2156         https://bugs.webkit.org/show_bug.cgi?id=101892
2157
2158         Reviewed by Adam Barth.
2159
2160         We can remove [Custom] from callUID in ScriptProfileNode.idl.
2161
2162         No tests. No change in behavior.
2163
2164         * GNUmakefile.list.am:
2165         * Target.pri:
2166         * UseJSC.cmake:
2167         * WebCore.gypi:
2168         * WebCore.vcproj/WebCore.vcproj:
2169         * WebCore.xcodeproj/project.pbxproj:
2170         * bindings/js/JSBindingsAllInOne.cpp:
2171         * bindings/js/JSScriptProfileNodeCustom.cpp: Removed.
2172         * bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
2173         * inspector/ScriptProfileNode.idl:
2174
2175 2012-11-12  Kentaro Hara  <haraken@chromium.org>
2176
2177         [V8] Performance::memory getter needs not to be [Custom]
2178         https://bugs.webkit.org/show_bug.cgi?id=101890
2179
2180         Reviewed by Adam Barth.
2181
2182         No tests. No change in behavior.
2183
2184         * UseV8.cmake:
2185         * WebCore.gypi:
2186         * bindings/v8/custom/V8PerformanceCustom.cpp: Removed.
2187         * page/Performance.idl:
2188
2189 2012-11-12  Kentaro Hara  <haraken@chromium.org>
2190
2191         [V8][JSC] HTMLOptionsCollection::length needs not to be [Custom]
2192         https://bugs.webkit.org/show_bug.cgi?id=101888
2193
2194         Reviewed by Adam Barth.
2195
2196         We can remove [Custom] from getter. It is possible to remove [Custom]
2197         from setter, but it changes the current behavior.
2198         (I think the current implementation of the setter is wrong.
2199         I'll fix it in another patch.)
2200
2201         No tests. No change in behavior.
2202
2203         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
2204         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
2205         * html/HTMLOptionsCollection.idl:
2206
2207 2012-11-12  Yael Aharon  <yael.aharon@intel.com>
2208
2209         [EFL][WK2][AC] Black screen when applications use software backend.
2210         https://bugs.webkit.org/show_bug.cgi?id=101659
2211
2212         Reviewed by Kenneth Rohde Christiansen.
2213
2214         Add a utility method to create a cairo_surface_t from a given Evas_Object_Image.
2215
2216         No new tests. Will be covered when running existing tests without enabling openGL.
2217
2218         * platform/graphics/efl/CairoUtilitiesEfl.cpp:
2219         (WebCore::createSurfaceForImage):
2220         (WebCore):
2221         * platform/graphics/efl/CairoUtilitiesEfl.h:
2222         (WebCore):
2223
2224 2012-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2225
2226         Unreviewed. Fix make distcheck.
2227
2228         * GNUmakefile.am: Remove editing from IDL_PATH since it doesn't
2229         contain idl files anymore.
2230         * GNUmakefile.list.am: Add missing header files.
2231
2232 2012-11-12  Tommy Widenflycht  <tommyw@google.com>
2233
2234         MediaStream API: Make sure that MediaConstraints only has optional and mandatory at the top level
2235         https://bugs.webkit.org/show_bug.cgi?id=101733
2236
2237         Reviewed by Jochen Eisinger.
2238
2239         This patch adds better verification to MediaConstraintsImpl.
2240
2241         Existing tests expanded to cover this change.
2242
2243         * Modules/mediastream/MediaConstraintsImpl.cpp:
2244         (WebCore::MediaConstraintsImpl::initialize):
2245
2246 2012-11-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2247
2248         Unreviewed, rolling out r134223.
2249         http://trac.webkit.org/changeset/134223
2250         https://bugs.webkit.org/show_bug.cgi?id=101939
2251
2252         Breaks inspector tests (Requested by pfeldman on #webkit).
2253
2254         * inspector/front-end/DefaultTextEditor.js:
2255         (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
2256         (WebInspector.TextEditorMainPanel):
2257         (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
2258         (WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
2259         (WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
2260         (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
2261         (WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
2262         (WebInspector.TextEditorMainPanel.prototype._paintLine):
2263         (WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
2264         (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
2265         (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
2266         * inspector/front-end/externs.js:
2267         * inspector/front-end/textEditor.css:
2268
2269 2012-11-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2270
2271         [Qt] Support ResourceRequest's setTimeoutInterval
2272         https://bugs.webkit.org/show_bug.cgi?id=101731
2273
2274         Reviewed by Simon Hausmann.
2275
2276         Establish a timeout and return the correct error when it is triggered.
2277
2278         Tested by existing http/tests/xmlhttprequest/timeout tests.
2279
2280         * platform/network/ResourceRequestBase.cpp:
2281         * platform/network/qt/QNetworkReplyHandler.cpp:
2282         (WebCore::QNetworkReplyHandler::release):
2283         (WebCore::QNetworkReplyHandler::finish):
2284         (WebCore::QNetworkReplyHandler::timeout):
2285         (WebCore::QNetworkReplyHandler::timerEvent):
2286         (WebCore::QNetworkReplyHandler::start):
2287         * platform/network/qt/QNetworkReplyHandler.h:
2288         (QNetworkReplyHandler):
2289
2290 2012-11-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2291
2292         Unreviewed, rolling out r134224.
2293         http://trac.webkit.org/changeset/134224
2294         https://bugs.webkit.org/show_bug.cgi?id=101937
2295
2296         asserting on bawts (Requested by kling on #webkit).
2297
2298         * rendering/style/RenderStyle.cpp:
2299         (WebCore::RenderStyle::diff):
2300         (WebCore::RenderStyle::setColor):
2301         (WebCore::RenderStyle::setVisitedLinkColor):
2302         * rendering/style/RenderStyle.h:
2303         * rendering/style/StyleBackgroundData.cpp:
2304         (WebCore::StyleBackgroundData::StyleBackgroundData):
2305         * rendering/style/StyleBackgroundData.h:
2306         (WebCore::StyleBackgroundData::color):
2307         (StyleBackgroundData):
2308         * rendering/style/StyleInheritedData.cpp:
2309         (WebCore::StyleInheritedData::StyleInheritedData):
2310         * rendering/style/StyleInheritedData.h:
2311         (StyleInheritedData):
2312         * rendering/style/StyleMultiColData.cpp:
2313         (WebCore::StyleMultiColData::StyleMultiColData):
2314         * rendering/style/StyleMultiColData.h:
2315         (StyleMultiColData):
2316         * rendering/style/StyleRareInheritedData.cpp:
2317         (SameSizeAsStyleRareInheritedData):
2318         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2319         (WebCore::StyleRareInheritedData::operator==):
2320         * rendering/style/StyleRareInheritedData.h:
2321         (WebCore):
2322         (StyleRareInheritedData):
2323         * rendering/style/StyleRareNonInheritedData.cpp:
2324         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2325         (WebCore::StyleRareNonInheritedData::operator==):
2326         * rendering/style/StyleRareNonInheritedData.h:
2327         (StyleRareNonInheritedData):
2328
2329 2012-11-12  Tiancheng Jiang  <tijiang@rim.com>
2330
2331         [BlackBerry] Update BB10 form theme.
2332         https://bugs.webkit.org/show_bug.cgi?id=100760
2333
2334         Reviewed by Rob Buis.
2335
2336         RIM PR 236993
2337         Internally Reviewed by Jeff Rogers.
2338         Use slide and paint method on slider range and media controls.
2339
2340         * platform/blackberry/RenderThemeBlackBerry.cpp:
2341         (WebCore):
2342         (WebCore::drawThreeSliceHorizontal):
2343         (WebCore::drawThreeSliceVertical):
2344         (WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
2345         (WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
2346         (WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
2347         (WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
2348         * platform/blackberry/RenderThemeBlackBerry.h:
2349         (RenderThemeBlackBerry):
2350
2351 2012-11-12  Kent Tamura  <tkent@chromium.org>
2352
2353         Refactoring: set read-only values on layout in DateTimeEditElement
2354         https://bugs.webkit.org/show_bug.cgi?id=101916
2355
2356         Reviewed by Kentaro Hara.
2357
2358         We have always updated read-only values when we set an empty value or
2359         DateTimeFieldsState. It has wasted CPU time because such read-only
2360         values are never updated after layout() essentially. So, we set
2361         read-only values in DateTimeEditBuilder used by layout(), and remove
2362         dateForReadOnlyField arguments of setEmptyValue and
2363         setValueAsDateTimeFieldsState.
2364
2365         No new tests. This should not make behavior changes.
2366
2367         * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
2368         (WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):
2369         We removed dateForReadOnlyField argument because read-only values are
2370         already set in DateTimeFieldElement::layout().
2371         * html/shadow/DateTimeEditElement.cpp:
2372         (WebCore::DateTimeEditBuilder::visitField):
2373         Set a value to a read-only minute/second/millisecond field while
2374         building UI elements.
2375         Also, changed variable types for millisecond and second fields to
2376         RefPtr<DateTimeNumericFieldElement> because we'd like to call
2377         setValueAsDate, which is private in DateTimeMillisecondFieldElement and
2378         DateTimeSecondFieldElement
2379         (WebCore::DateTimeEditElement::setValueAsDateTimeFieldsState):
2380         We removed dateForReadOnlyField argument because read-only values are
2381         already set in DateTimeFieldElement::layout().
2382         (WebCore::DateTimeEditElement::setEmptyValue): Ditto.
2383         * html/shadow/DateTimeEditElement.h:
2384         (DateTimeEditElement):
2385         Removed dateForReadOnlyField argument for setValueAsDateTimeFieldsState.
2386
2387         * html/shadow/DateTimeFieldElement.cpp:
2388         (WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
2389         We removed dateForReadOnlyField argument because read-only values are
2390         already set in DateTimeFieldElement::layout().
2391         * html/shadow/DateTimeFieldElement.h:
2392         (DateTimeFieldElement): Ditto.
2393
2394         * html/shadow/DateTimeFieldElements.cpp: Ditto.
2395         * html/shadow/DateTimeFieldElements.h: Ditto.
2396         * html/shadow/DateTimeNumericFieldElement.cpp:
2397         (WebCore::DateTimeNumericFieldElement::setEmptyValue):
2398         It should do nothing if it is read-only because a read-only value was
2399         already set just after construction.
2400         * html/shadow/DateTimeNumericFieldElement.h:
2401         (DateTimeNumericFieldElement):
2402         Removed dateForReadOnlyField argument of setEmptyValue.
2403         * html/shadow/DateTimeSymbolicFieldElement.cpp:
2404         (WebCore::DateTimeSymbolicFieldElement::setEmptyValue): Ditto.
2405         * html/shadow/DateTimeSymbolicFieldElement.h:
2406         (DateTimeSymbolicFieldElement): Ditto.
2407
2408 2012-11-12  Tiancheng Jiang  <tijiang@rim.com>
2409
2410         [BlackBerry] Update BB10 form theme.
2411         https://bugs.webkit.org/show_bug.cgi?id=100760
2412
2413         Reviewed by Rob Buis.
2414
2415         RIM PR 236993
2416         Internally Reviewed by Jeff Rogers.
2417         Enable GL slider.
2418
2419         * platform/blackberry/RenderThemeBlackBerry.cpp:
2420         (WebCore::drawThreeSlice):
2421         (WebCore):
2422         (WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
2423         (WebCore::RenderThemeBlackBerry::paintSliderThumb):
2424
2425 2012-11-12  Kentaro Hara  <haraken@chromium.org>
2426
2427         [V8][JSC] HTMLElement::itemValue() needs not to be custom
2428         https://bugs.webkit.org/show_bug.cgi?id=101882
2429
2430         Reviewed by Adam Barth.
2431
2432         We can remove a [Custom] IDL attribute.
2433
2434         No tests. No change in behavior.
2435
2436         * bindings/js/JSHTMLElementCustom.cpp:
2437         * bindings/v8/custom/V8HTMLElementCustom.cpp:
2438         * html/HTMLElement.idl:
2439
2440 2012-11-12  Andreas Kling  <kling@webkit.org>
2441
2442         RenderStyle: Pack Color members tighter in substructures.
2443         <http://webkit.org/b/101860>
2444
2445         Reviewed by Antti Koivisto.
2446
2447         For RenderStyle substructures (StyleInheritedData, et al.), unfold all WebCore::Color
2448         members into RGBA32/bool variables OR just an RGBA32 if the color can never be invalid.
2449
2450         Memory saved per instance:
2451
2452             - StyleMultiColData:          4 bytes
2453             - StyleBackgroundData:        8 bytes
2454             - StyleInheritedData:         8 bytes
2455             - StyleRareInheritedData:    24 bytes
2456             - StyleRareNonInheritedData: 24 bytes
2457
2458         323kB progression on Membuster3.
2459
2460         * rendering/style/RenderStyle.cpp:
2461         (WebCore::RenderStyle::diff):
2462         (WebCore::RenderStyle::setColor):
2463         (WebCore::RenderStyle::setVisitedLinkColor):
2464         (WebCore::RenderStyle::setVisitedLinkColumnRuleColor):
2465         (WebCore::RenderStyle::setBackgroundColor):
2466         * rendering/style/RenderStyle.h:
2467         * rendering/style/StyleBackgroundData.cpp:
2468         (WebCore::StyleBackgroundData::StyleBackgroundData):
2469         * rendering/style/StyleBackgroundData.h:
2470         (WebCore::StyleBackgroundData::color):
2471         (StyleBackgroundData):
2472         * rendering/style/StyleInheritedData.cpp:
2473         (WebCore::StyleInheritedData::StyleInheritedData):
2474         * rendering/style/StyleInheritedData.h:
2475         (StyleInheritedData):
2476         * rendering/style/StyleMultiColData.cpp:
2477         (WebCore::StyleMultiColData::StyleMultiColData):
2478         (WebCore::StyleMultiColData::setVisitedLinkColumnRuleColor):
2479         * rendering/style/StyleMultiColData.h:
2480         (StyleMultiColData):
2481         (WebCore::StyleMultiColData::visitedLinkColumnRuleColor):
2482         * rendering/style/StyleRareInheritedData.cpp:
2483         (SameSizeAsStyleRareInheritedData):
2484         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2485         (WebCore::StyleRareInheritedData::operator==):
2486         (WebCore::StyleRareInheritedData::setTextStrokeColor):
2487         (WebCore::StyleRareInheritedData::setTextFillColor):
2488         (WebCore::StyleRareInheritedData::setTextEmphasisColor):
2489         (WebCore::StyleRareInheritedData::setVisitedLinkTextStrokeColor):
2490         (WebCore::StyleRareInheritedData::setVisitedLinkTextFillColor):
2491         (WebCore::StyleRareInheritedData::setVisitedLinkTextEmphasisColor):
2492         * rendering/style/StyleRareInheritedData.h:
2493         (StyleRareInheritedData):
2494         (WebCore::StyleRareInheritedData::textStrokeColor):
2495         (WebCore::StyleRareInheritedData::textFillColor):
2496         (WebCore::StyleRareInheritedData::textEmphasisColor):
2497         (WebCore::StyleRareInheritedData::visitedLinkTextStrokeColor):
2498         (WebCore::StyleRareInheritedData::visitedLinkTextFillColor):
2499         (WebCore::StyleRareInheritedData::visitedLinkTextEmphasisColor):
2500         * rendering/style/StyleRareNonInheritedData.cpp:
2501         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2502         (WebCore::StyleRareNonInheritedData::operator==):
2503         (WebCore::StyleRareNonInheritedData::setVisitedLinkBorderLeftColor):
2504         (WebCore::StyleRareNonInheritedData::setVisitedLinkBorderRightColor):
2505         (WebCore::StyleRareNonInheritedData::setVisitedLinkBorderTopColor):
2506         (WebCore::StyleRareNonInheritedData::setVisitedLinkBorderBottomColor):
2507         (WebCore::StyleRareNonInheritedData::setVisitedLinkOutlineColor):
2508         (WebCore::StyleRareNonInheritedData::setVisitedLinkBackgroundColor):
2509         * rendering/style/StyleRareNonInheritedData.h:
2510         (WebCore::StyleRareNonInheritedData::visitedLinkBackgroundColor):
2511         (WebCore::StyleRareNonInheritedData::visitedLinkOutlineColor):
2512         (WebCore::StyleRareNonInheritedData::visitedLinkBorderLeftColor):
2513         (WebCore::StyleRareNonInheritedData::visitedLinkBorderRightColor):
2514         (WebCore::StyleRareNonInheritedData::visitedLinkBorderTopColor):
2515         (WebCore::StyleRareNonInheritedData::visitedLinkBorderBottomColor):
2516         (StyleRareNonInheritedData):
2517
2518 2012-11-12  Pavel Feldman  <pfeldman@chromium.org>
2519
2520         Web Inspector: migrate text editor to mutation observers
2521         https://bugs.webkit.org/show_bug.cgi?id=101841
2522
2523         Reviewed by Vsevolod Vlasov.
2524
2525         Otherwise, we miss notifications on the removed lines.
2526
2527         * inspector/front-end/DefaultTextEditor.js:
2528         (WebInspector.TextEditorMainPanel):
2529         (WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
2530         (WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
2531         (WebInspector.TextEditorMainPanel.prototype._handleMutations):
2532         (WebInspector.TextEditorMainPanel.prototype._handleMutation):
2533         * inspector/front-end/externs.js:
2534         (WebKitMutation):
2535         (WebKitMutationObserver.prototype.observe):
2536         (WebKitMutationObserver.prototype.disconnect):
2537
2538 2012-11-12  Allan Sandfeld Jensen  <sandfeld@kde.org>
2539
2540         [Qt] Flash-plugin starts with wrong width
2541         https://bugs.webkit.org/show_bug.cgi?id=101836
2542
2543         Reviewed by Simon Hausmann.
2544
2545         Defer the setWindow call, so that the one time it is called it will have its final size.
2546
2547         * plugins/PluginPackage.cpp:
2548         (WebCore::PluginPackage::determineQuirks):
2549
2550 2012-11-12  Tommy Widenflycht  <tommyw@google.com>
2551
2552         Remove the V8 custom code for WebSockets constructor
2553         https://bugs.webkit.org/show_bug.cgi?id=100801
2554
2555         Reviewed by Kentaro Hara.
2556
2557         This patch does the following:
2558
2559         1) Modifies the V8 code generator to support overloaded constructors,
2560            the JS generator is fixed to work as before. Proper support for JS will come later.
2561
2562         2) Modifies WebSocket.h/.cpp for the new constructors.
2563
2564         Tested by running WebSockets layout tests.
2565
2566         * Modules/websockets/WebSocket.cpp:
2567         (WebCore::WebSocket::create):
2568         (WebCore):
2569         * Modules/websockets/WebSocket.h:
2570         (WebSocket):
2571         * Modules/websockets/WebSocket.idl:
2572         * bindings/scripts/CodeGeneratorJS.pm:
2573         (GenerateConstructorDefinition):
2574         * bindings/scripts/CodeGeneratorV8.pm:
2575         (GenerateHeader):
2576         (GenerateOverloadedConstructorCallback):
2577         (GenerateSingleConstructorCallback):
2578         (GenerateConstructorCallback):
2579         (GenerateImplementation):
2580         * bindings/scripts/IDLParser.pm:
2581         (copyAttributes):
2582         (parseExtendedAttributeList):
2583         (parseExtendedAttributes):
2584         (applyExtendedAttributeList):
2585         * bindings/scripts/IDLStructure.pm:
2586         * bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp: Added.
2587         (WebDOMTestOverloadedConstructors::WebDOMTestOverloadedConstructorsPrivate::WebDOMTestOverloadedConstructorsPrivate):
2588         (WebDOMTestOverloadedConstructors::WebDOMTestOverloadedConstructorsPrivate):
2589         (WebDOMTestOverloadedConstructors::WebDOMTestOverloadedConstructors):
2590         (WebDOMTestOverloadedConstructors::operator=):
2591         (WebDOMTestOverloadedConstructors::impl):
2592         (WebDOMTestOverloadedConstructors::~WebDOMTestOverloadedConstructors):
2593         (toWebCore):
2594         (toWebKit):
2595         * bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.h: Added.
2596         (WebCore):
2597         (WebDOMTestOverloadedConstructors):
2598         * bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp: Added.
2599         (WebKit):
2600         (WebKit::kit):
2601         (WebKit::core):
2602         (WebKit::wrapTestOverloadedConstructors):
2603         (webkit_dom_test_overloaded_constructors_finalize):
2604         (webkit_dom_test_overloaded_constructors_set_property):
2605         (webkit_dom_test_overloaded_constructors_get_property):
2606         (webkit_dom_test_overloaded_constructors_constructed):
2607         (webkit_dom_test_overloaded_constructors_class_init):
2608         (webkit_dom_test_overloaded_constructors_init):
2609         * bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h: Added.
2610         (_WebKitDOMTestOverloadedConstructors):
2611         (_WebKitDOMTestOverloadedConstructorsClass):
2612         * bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h: Added.
2613         (WebKit):
2614         * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Added.
2615         (WebCore):
2616         (WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):
2617         (WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
2618         (WebCore::JSTestOverloadedConstructorsConstructor::getOwnPropertySlot):
2619         (WebCore::JSTestOverloadedConstructorsConstructor::getOwnPropertyDescriptor):
2620         (WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors):
2621         (WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
2622         (WebCore::JSTestOverloadedConstructorsPrototype::self):
2623         (WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
2624         (WebCore::JSTestOverloadedConstructors::finishCreation):
2625         (WebCore::JSTestOverloadedConstructors::createPrototype):
2626         (WebCore::JSTestOverloadedConstructors::destroy):
2627         (WebCore::JSTestOverloadedConstructors::~JSTestOverloadedConstructors):
2628         (WebCore::JSTestOverloadedConstructors::getOwnPropertySlot):
2629         (WebCore::JSTestOverloadedConstructors::getOwnPropertyDescriptor):
2630         (WebCore::jsTestOverloadedConstructorsConstructor):
2631         (WebCore::JSTestOverloadedConstructors::getConstructor):
2632         (WebCore::isObservable):
2633         (WebCore::JSTestOverloadedConstructorsOwner::isReachableFromOpaqueRoots):
2634         (WebCore::JSTestOverloadedConstructorsOwner::finalize):
2635         (WebCore::toJS):
2636         (WebCore::toTestOverloadedConstructors):
2637         * bindings/scripts/test/JS/JSTestOverloadedConstructors.h: Added.
2638         (WebCore):
2639         (JSTestOverloadedConstructors):
2640         (WebCore::JSTestOverloadedConstructors::create):
2641         (WebCore::JSTestOverloadedConstructors::createStructure):
2642         (WebCore::JSTestOverloadedConstructors::impl):
2643         (WebCore::JSTestOverloadedConstructors::releaseImpl):
2644         (WebCore::JSTestOverloadedConstructors::releaseImplIfNotNull):
2645         (JSTestOverloadedConstructorsOwner):
2646         (WebCore::wrapperOwner):
2647         (WebCore::wrapperContext):
2648         (JSTestOverloadedConstructorsPrototype):
2649         (WebCore::JSTestOverloadedConstructorsPrototype::create):
2650         (WebCore::JSTestOverloadedConstructorsPrototype::createStructure):
2651         (WebCore::JSTestOverloadedConstructorsPrototype::JSTestOverloadedConstructorsPrototype):
2652         (JSTestOverloadedConstructorsConstructor):
2653         (WebCore::JSTestOverloadedConstructorsConstructor::create):
2654         (WebCore::JSTestOverloadedConstructorsConstructor::createStructure):
2655         * bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.h: Added.
2656         * bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.mm: Added.
2657         (-[DOMTestOverloadedConstructors dealloc]):
2658         (-[DOMTestOverloadedConstructors finalize]):
2659         (core):
2660         (kit):
2661         * bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h: Added.
2662         (WebCore):
2663         * bindings/scripts/test/TestOverloadedConstructors.idl: Copied from Source/WebCore/bindings/scripts/test/TestSerializedScriptValueInterface.idl.
2664         * bindings/scripts/test/TestSerializedScriptValueInterface.idl:
2665         * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp: Added.
2666         (WebCore):
2667         (TestOverloadedConstructorsV8Internal):
2668         (WebCore::TestOverloadedConstructorsV8Internal::V8_USE):
2669         (WebCore::V8TestOverloadedConstructors::constructor1Callback):
2670         (WebCore::V8TestOverloadedConstructors::constructor2Callback):
2671         (WebCore::V8TestOverloadedConstructors::constructor3Callback):
2672         (WebCore::V8TestOverloadedConstructors::constructor4Callback):
2673         (WebCore::V8TestOverloadedConstructors::constructorCallback):
2674         (WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
2675         (WebCore::V8TestOverloadedConstructors::GetRawTemplate):
2676         (WebCore::V8TestOverloadedConstructors::GetTemplate):
2677         (WebCore::V8TestOverloadedConstructors::HasInstance):
2678         (WebCore::V8TestOverloadedConstructors::wrapSlow):
2679         (WebCore::V8TestOverloadedConstructors::derefObject):
2680         * bindings/scripts/test/V8/V8TestOverloadedConstructors.h: Added.
2681         (WebCore):
2682         (V8TestOverloadedConstructors):
2683         (WebCore::V8TestOverloadedConstructors::toNative):
2684         (WebCore::V8TestOverloadedConstructors::installPerContextProperties):
2685         (WebCore::V8TestOverloadedConstructors::installPerContextPrototypeProperties):
2686         (WebCore::V8TestOverloadedConstructors::wrap):
2687         (WebCore::toV8):
2688         * bindings/v8/custom/V8WebSocketCustom.cpp:
2689
2690 2012-11-12  Shinya Kawanaka  <shinyak@chromium.org>
2691
2692         [Refactoring] Create SelectRuleFeatureSet for collecting RuleFeatureSet for select attribute
2693         https://bugs.webkit.org/show_bug.cgi?id=101891
2694
2695         Reviewed by Hajime Morita.
2696
2697         We would like to have another class for RuleFeatureSet to collect 'select' attribute features,
2698         since it will have more features than the original RuleFeatureSet has.
2699
2700         Also, some methods of ElementShadow are removed and we provide a method to get SelectRuleFeatureSet itself.
2701
2702         No new tests, no change in behavior.
2703
2704         * CMakeLists.txt:
2705         * GNUmakefile.list.am:
2706         * Target.pri:
2707         * WebCore.gypi:
2708         * WebCore.vcproj/WebCore.vcproj:
2709         * WebCore.xcodeproj/project.pbxproj:
2710         * dom/ElementShadow.h:
2711         (ElementShadow):
2712         (WebCore::ElementShadow::selectRuleFeatureSet):
2713         (WebCore):
2714         * html/shadow/SelectRuleFeatureSet.cpp: Added.
2715         (WebCore):
2716         (WebCore::SelectRuleFeatureSet::SelectRuleFeatureSet):
2717         (WebCore::SelectRuleFeatureSet::add):
2718         (WebCore::SelectRuleFeatureSet::clear):
2719         (WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector):
2720         * html/shadow/SelectRuleFeatureSet.h: Added.
2721         (WebCore):
2722         (SelectRuleFeatureSet):
2723         (WebCore::SelectRuleFeatureSet::hasSelectorForId):
2724         (WebCore::SelectRuleFeatureSet::hasSelectorForClass):
2725         (WebCore::SelectRuleFeatureSet::hasSelectorForAttribute):
2726         * testing/Internals.cpp:
2727         (WebCore::Internals::hasSelectorForIdInShadow):
2728         (WebCore::Internals::hasSelectorForClassInShadow):
2729         (WebCore::Internals::hasSelectorForAttributeInShadow):
2730
2731 2012-11-13  Keishi Hattori  <keishi@webkit.org>
2732
2733         Build fix for Chromium Android (caused by r134216)
2734
2735         Unreviewed.
2736
2737         No new tests.
2738
2739         * platform/text/PlatformLocale.cpp:
2740         (WebCore::Locale::formatDateTime):
2741
2742 2012-11-12  Keishi Hattori  <keishi@webkit.org>
2743
2744         Add support for week/month to Locale::formatDateTime()
2745         https://bugs.webkit.org/show_bug.cgi?id=101878
2746
2747         Reviewed by Kent Tamura.
2748
2749         Adding support for week/month to Locale::formatDateTime() in preparation for datalist support for <input type=week/month>.
2750
2751         Added Chromium tests LocaleMacTest.formatWeek and LocaleMacTest.formatMonth.
2752
2753         * platform/text/PlatformLocale.cpp:
2754         (WebCore::DateTimeStringBuilder::visitField):
2755         (WebCore::Locale::formatDateTime): Support week and month types.
2756
2757 2012-11-12  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2758
2759         [Qt] Can not load MHTML documents
2760         https://bugs.webkit.org/show_bug.cgi?id=101765
2761
2762         Reviewed by Simon Hausmann.
2763
2764         Recognize common MHTML extensions so that we can recognize MHTML tests on the file-system.
2765
2766         Tested by existing mhtml/ tests.
2767
2768         * platform/qt/MIMETypeRegistryQt.cpp:
2769         (WebCore):
2770
2771 2012-11-12  Andreas Kling  <akling@apple.com>
2772
2773         Tighten vector in ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray().
2774         <http://webkit.org/b/101850>
2775
2776         Reviewed by Antti Koivisto.
2777
2778         Reserve the exact amount of space needed for m_responseContentDispositionEncodingFallbackArray.
2779         222kB progression on Membuster3.
2780
2781         * platform/network/ResourceRequestBase.cpp:
2782         (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
2783
2784 2012-11-12  Tommy Widenflycht  <tommyw@google.com>
2785
2786         MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state
2787         https://bugs.webkit.org/show_bug.cgi?id=101751
2788
2789         Reviewed by Adam Barth.
2790
2791         This patch queues the events until the JS interpreter is in an idle state.
2792
2793         Existing tests cover this patch.
2794
2795         * Modules/mediastream/RTCDataChannel.cpp:
2796         (WebCore::RTCDataChannel::RTCDataChannel):
2797         (WebCore::RTCDataChannel::readyStateChanged):
2798         (WebCore::RTCDataChannel::dataArrived):
2799         (WebCore::RTCDataChannel::error):
2800         (WebCore::RTCDataChannel::scheduleDispatchEvent):
2801         (WebCore):
2802         (WebCore::RTCDataChannel::scheduledEventTimerFired):
2803         * Modules/mediastream/RTCDataChannel.h:
2804         (RTCDataChannel):
2805         * platform/chromium/support/WebRTCDataChannel.cpp:
2806         (WebKit::WebRTCDataChannel::setBufferedAmount):
2807         (WebKit::WebRTCDataChannel::readyStateChanged):
2808         (WebKit::WebRTCDataChannel::dataArrived):
2809         (WebKit::WebRTCDataChannel::error):
2810
2811 2012-11-12  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2812
2813         Remove HTMLInputElement dependency from PickerIndicatorElement
2814         https://bugs.webkit.org/show_bug.cgi?id=101913
2815
2816         Reviewed by Kent Tamura.
2817
2818         Introduced PickerIndicatorOwner interface that replaces the role of hostInput() in
2819         PickerIndicatorElement. It makes easier to add interactions between picker indicator
2820         and its owner without having to add functions to HTMLInputElement.
2821
2822         No new tests. This is just a refactor.
2823
2824         * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
2825         (WebCore::BaseMultipleFieldsDateAndTimeInputType::isPickerIndicatorOwnerDisabledOrReadOnly): Added.
2826         (WebCore):
2827         (WebCore::BaseMultipleFieldsDateAndTimeInputType::pickerIndicatorChooseValue): Added.
2828         (WebCore::BaseMultipleFieldsDateAndTimeInputType::setupDateTimeChooserParameters): Added.
2829         (WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType):
2830         (WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
2831         (WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree):
2832         * html/BaseMultipleFieldsDateAndTimeInputType.h:
2833         (WebCore):
2834         (BaseMultipleFieldsDateAndTimeInputType): Implements PickerIndicatorOwner.
2835         * html/shadow/PickerIndicatorElement.cpp: Replaced all the use of hostInput() by using PickerIndicatorOwner.
2836         (WebCore::PickerIndicatorElement::PickerIndicatorElement):
2837         (WebCore::PickerIndicatorElement::create):
2838         (WebCore::PickerIndicatorElement::defaultEventHandler):
2839         (WebCore::PickerIndicatorElement::willRespondToMouseClickEvents):
2840         (WebCore::PickerIndicatorElement::didChooseValue):
2841         (WebCore::PickerIndicatorElement::openPopup):
2842         * html/shadow/PickerIndicatorElement.h:
2843         (PickerIndicatorElement): Added a PickerIndicatorOwner member.
2844         (PickerIndicatorOwner): An interface class for communicating picker indicator and its owner.
2845         (WebCore::PickerIndicatorElement::PickerIndicatorOwner::~PickerIndicatorOwner):
2846         (WebCore::PickerIndicatorElement::removePickerIndicatorOwner):
2847
2848 2012-11-12  Mihnea Ovidenie  <mihnea@adobe.com>
2849
2850         [CSSRegions]Add support for text-shadow in region styling
2851         https://bugs.webkit.org/show_bug.cgi?id=94472
2852
2853         Reviewed by David Hyatt.
2854
2855         Original patch by Andrei Onea.
2856         Add support for text-shadow in region styling (@-webkit-region rule).
2857         In addition to the previously supported region styling properties (background-color and color),
2858         text-shadow requires the computation of an element style in region at layout time.
2859
2860         This patch adds a new method on RenderRegion - ensureRegionStyleForObject - that
2861         can be used to retrieve the object style in region (if already cached) or to compute it
2862         on the spot. When computing the object style in region, we need to compute the style in region
2863         also for the object ancestor, up to the content nodes.
2864
2865         This patch also refactors the way styles in region are computed and stored, because
2866         we can compute the style in region not only at paint time, but also at layout time.
2867
2868         Test: fast/regions/region-style-text-shadow.html
2869
2870         * css/StyleResolver.cpp:
2871         (WebCore::StyleResolver::isValidRegionStyleProperty):
2872         Allow text-shadow to be used in region styling.
2873         * rendering/InlineBox.cpp:
2874         (WebCore::InlineBox::styleInRegion):
2875         Retrieve the region style for an InlineBox's renderer, given its RenderRegion.
2876         Compute the style in region if not computed yet.
2877         (WebCore::InlineBox::regionDuringLayout):
2878         Retrieve the region in which an InlineBox is being flowed.
2879         * rendering/InlineBox.h:
2880         * rendering/InlineFlowBox.cpp: Take region styling into account.
2881         (WebCore::InlineFlowBox::addToLine):
2882         (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
2883         * rendering/RenderRegion.cpp:
2884         (WebCore::RenderRegion::setRegionObjectsRegionStyle):
2885         (WebCore::canCacheObjectStyleInRegion):
2886         Test if we can cache the computed style in region.
2887         (WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
2888         (WebCore::RenderRegion::computeStyleInRegion):
2889         (WebCore::RenderRegion::setChildrenStyleInRegion):
2890         (WebCore::setObjectHasBoxDecorationsFlag):
2891         (WebCore::RenderRegion::setObjectStyleInRegion):
2892         (WebCore::RenderRegion::clearObjectStyleInRegion):
2893         (WebCore::RenderRegion::ensureRegionStyleForObject):
2894         * rendering/RenderRegion.h:
2895
2896 2012-11-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2897
2898         Unreviewed, rolling out r134154.
2899         http://trac.webkit.org/changeset/134154
2900         https://bugs.webkit.org/show_bug.cgi?id=101919
2901
2902         Causes plenty of crashes on GTK and Apple Win builders
2903         (Requested by zdobersek on #webkit).
2904
2905         * css/mediaControls.css:
2906         * css/mediaControlsQuickTime.css:
2907         (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
2908         (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
2909         * html/shadow/MediaControlElements.cpp:
2910         (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
2911         (WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
2912         (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
2913         (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
2914         (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
2915         * html/shadow/MediaControlElements.h:
2916         (MediaControlElement):
2917         (MediaControlToggleClosedCaptionsButtonElement):
2918         * html/shadow/MediaControlRootElement.cpp:
2919         (WebCore::MediaControlRootElement::MediaControlRootElement):
2920         (WebCore::MediaControlRootElement::create):
2921         (WebCore::MediaControlRootElement::setMediaController):
2922         (WebCore::MediaControlRootElement::hide):
2923         (WebCore::MediaControlRootElement::makeTransparent):
2924         (WebCore::MediaControlRootElement::reset):
2925         (WebCore::MediaControlRootElement::reportedError):
2926         * html/shadow/MediaControlRootElement.h:
2927         (WebCore):
2928         (MediaControlRootElement):
2929         * html/shadow/MediaControlRootElementChromium.cpp:
2930         (WebCore::MediaControlRootElementChromium::initializeControls):
2931         * html/shadow/MediaControls.h:
2932         (MediaControls):
2933         * platform/Language.cpp:
2934         (WebCore):
2935         * platform/Language.h:
2936         (WebCore):
2937         * rendering/RenderMediaControls.cpp:
2938         (WebCore::RenderMediaControls::paintMediaControlsPart):
2939         * rendering/RenderMediaControlsChromium.cpp:
2940         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
2941
2942 2012-11-12  Mike West  <mkwst@chromium.org>
2943
2944         'for (x in y)' requires 'var' declaration in ConsoleMessage.js
2945         https://bugs.webkit.org/show_bug.cgi?id=101908
2946
2947         Reviewed by Pavel Feldman.
2948
2949         r134166 should have included a 'var' declaration in its 'for (x in y)'
2950         loop. This patch adds the missing 'var' in order to prevent leakage into
2951         the global context.
2952
2953         * inspector/front-end/ConsoleMessage.js:
2954         (WebInspector.ConsoleMessageImpl.prototype.append):
2955         (WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
2956
2957 2012-11-12  Zeno Albisser  <zeno@webkit.org>
2958
2959         [Qt] MiniBrowser should not strongly depend on QtTestSupport.
2960         https://bugs.webkit.org/show_bug.cgi?id=101775
2961
2962         Introducing HAVE(QTTESTSUPPORT) to allow building
2963         MiniBrowser without QtTestSupport.
2964         This is necessary when using a production build.
2965
2966         Reviewed by Tor Arne Vestbø.
2967
2968         * Target.pri:
2969         * platform/qt/QtTestSupport.h:
2970
2971 2012-11-12  Pavel Feldman  <pfeldman@chromium.org>
2972
2973         Web Inspector: wasShown is called twice when show() is called from within wasShown
2974         https://bugs.webkit.org/show_bug.cgi?id=101858
2975
2976         Reviewed by Vsevolod Vlasov.
2977
2978         When we attach views lazily from within wasShown, the views were getting wasShown notification twice.
2979         We now mute one of them.
2980
2981         * inspector/front-end/View.js:
2982         (WebInspector.View):
2983         (WebInspector.View.prototype._inNotification):
2984         (WebInspector.View.prototype._parentIsShowing):
2985         (WebInspector.View.prototype._callOnVisibleChildren):
2986         (WebInspector.View.prototype._processWasShown):
2987         (WebInspector.View.prototype._processWillHide):
2988         (WebInspector.View.prototype._processOnResize):
2989         (WebInspector.View.prototype._notify):
2990         (WebInspector.View.prototype.show):
2991
2992 2012-11-12  Ryosuke Niwa  <rniwa@webkit.org>
2993
2994         Build fix after r134191. Turns out that FrameView::performPostLayoutTasks calls FrameSelection::updateAppearance
2995         in the middle of a layout. So we can't have assertions in recomputeCaretRect and updateAppearance.
2996
2997         Furthermore, we can't update layout in updateAppearance. So do that in its call sites.
2998
2999         * editing/FrameSelection.cpp:
3000         (WebCore::FrameSelection::setSelection):
3001         (WebCore::FrameSelection::recomputeCaretRect):
3002         (WebCore::FrameSelection::updateAppearance):
3003         (WebCore::FrameSelection::setCaretVisibility):
3004
3005 2012-11-12  Shinya Kawanaka  <shinyak@chromium.org>
3006
3007         Don't update style when attaching in HTMLMeterElement
3008         https://bugs.webkit.org/show_bug.cgi?id=101714
3009
3010         Reviewed by Hajime Morita.
3011
3012         HTMLMeterElement was updating style when it's being attached. However, updating style when attaching
3013         can cause style-update prevention. The similar thing has already happened in Bug 100507.
3014
3015         Since we have already set the default value in creating ShadowDOM subtree, we don't need to update style actually.
3016
3017         Test: fast/dom/HTMLMeterElement/meter-bar-set-value.html
3018
3019         * html/HTMLMeterElement.cpp:
3020         * html/HTMLMeterElement.h:
3021         (HTMLMeterElement): Removed attach(). We don't need it.
3022
3023 2012-11-09  Ryosuke Niwa  <rniwa@webkit.org>
3024
3025         Multiple Layout Tests (e.g. fast/repaint/japanese-rl-selection-clear.html) is failing after r133840.
3026         https://bugs.webkit.org/show_bug.cgi?id=101547
3027
3028         Reviewed by Simon Fraser.
3029
3030         I overlooked the fact when the selection is null, we still have to invalidate the caret rect that
3031         previously existed. Revert the optimization added in r133840 to skip caret invalidation when new
3032         selection is null, and add a special method to be called by FrameLoader prior to destruction instead.
3033         This will let us avoid doing an extra layout upon destruction and not regress repaint tests.
3034
3035         Covered by existing tests.
3036
3037         * editing/FrameSelection.cpp:
3038         (WebCore::FrameSelection::setSelection): Added DoNotUpdateAppearance option.
3039         (WebCore::FrameSelection::prepareForDestruction): Added.
3040         (WebCore::FrameSelection::updateAppearance): Reverted the flawed optimization added in r133840.
3041         Also, don't update style before updating selection unless text caret is disabled since we always
3042         update the layout (including style) when text caret is enabled.
3043         * editing/FrameSelection.h:
3044         (FrameSelection):
3045         * loader/FrameLoader.cpp:
3046         (WebCore::FrameLoader::clear): Call prepareForDestruction instead of clear to avoid a layout.
3047
3048 2012-11-11  Dongwoo Joshua Im  <dw.im@samsung.com>
3049
3050         [CSS3] Parsing the property, text-align-last.
3051         https://bugs.webkit.org/show_bug.cgi?id=99439
3052
3053         Reviewed by Julien Chaffraix.
3054
3055         This patch implements the parsing side of the "text-align-last" property specified
3056         in CSS3 working draft, with "-webkit-" prefix, under ENABLE_CSS3_TEXT flag.
3057         Specification link : http://www.w3.org/TR/css3-text/#text-align-last
3058
3059         Tests: fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html
3060                fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html
3061
3062         * css/CSSComputedStyleDeclaration.cpp:
3063         (WebCore):
3064         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Get the value of the text-align-last property.
3065         * css/CSSParser.cpp:
3066         (WebCore::CSSParser::parseValue): Parse the value, and check whether it is a proper value which text-align-last can have.
3067         * css/CSSPrimitiveValueMappings.h:
3068         (WebCore):
3069         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3070         (WebCore::CSSPrimitiveValue::operator ETextAlignLast):
3071         * css/CSSProperty.cpp:
3072         (WebCore::CSSProperty::isInheritedProperty):
3073         * css/CSSPropertyNames.in: Add '-webkit-text-align-last' property.
3074         * css/StyleBuilder.cpp:
3075         (WebCore::StyleBuilder::StyleBuilder):
3076         * css/StylePropertySet.cpp:
3077         (WebCore):
3078         * css/StyleResolver.cpp:
3079         (WebCore::StyleResolver::applyProperty):
3080         * rendering/style/RenderStyle.h:
3081         * rendering/style/RenderStyleConstants.h:
3082         * rendering/style/StyleRareInheritedData.cpp:
3083         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3084         (WebCore::StyleRareInheritedData::operator==):
3085         * rendering/style/StyleRareInheritedData.h:
3086         (StyleRareInheritedData): Add m_textAlignLast.
3087
3088 2012-11-11  Shinya Kawanaka  <shinyak@chromium.org>
3089
3090         [Refactoring] Remove shadowPseudoId() and use setPseudo() in HTMLKeygenElement
3091         https://bugs.webkit.org/show_bug.cgi?id=101881
3092
3093         Reviewed by Kent Tamura.
3094
3095         We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
3096         setPseudo()/pseudo() instead.
3097
3098         No new tests, simple refacotring.
3099
3100         * html/HTMLKeygenElement.cpp:
3101         (WebCore::KeygenSelectElement::KeygenSelectElement):
3102         (KeygenSelectElement):
3103
3104 2012-11-11  Adam Barth  <abarth@webkit.org>
3105
3106         Many DOMWindowProperties would benefit from being ScriptWrappable
3107         https://bugs.webkit.org/show_bug.cgi?id=101887
3108
3109         Reviewed by Kentaro Hara.
3110
3111         These object are only ever created at the behest of script, which means
3112         making them ScriptWrappable is a win.
3113
3114         * page/BarInfo.h:
3115         * page/Console.h:
3116         * page/Crypto.h:
3117         * page/History.h:
3118         * page/Location.h:
3119         * page/Navigator.h:
3120         * page/Performance.h:
3121
3122 2012-11-11  Kentaro Hara  <haraken@chromium.org>
3123
3124         [V8] HTMLDocument::all() needs not to be custom
3125         https://bugs.webkit.org/show_bug.cgi?id=101875
3126
3127         Reviewed by Adam Barth.
3128
3129         We can easily remove the custom getter from V8 because the
3130         custom setter sets .all by ForceSet(). On the other hand,
3131         it is non-trivial to remove the custom getter from JSC
3132         because the custom setter sets .all by putDirect()
3133         and the custom getter wants to get it by getDirect().
3134
3135         No tests. No change in behavior.
3136
3137         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3138         * html/HTMLDocument.idl:
3139
3140 2012-11-11  Kentaro Hara  <haraken@chromium.org>
3141
3142         [V8] V8Console::memoryAttrGetter() needs not to be custom
3143         https://bugs.webkit.org/show_bug.cgi?id=101873
3144
3145         Reviewed by Adam Barth.
3146
3147         No tests. No change in behavior.
3148
3149         * bindings/v8/custom/V8ConsoleCustom.cpp:
3150         (WebCore):
3151         * page/Console.idl:
3152
3153 2012-11-11  Shinya Kawanaka  <shinyak@chromium.org>
3154
3155         [Shadow] ElementShadow should have RuleFeatureSet for select attribute selectors.
3156         https://bugs.webkit.org/show_bug.cgi?id=101180
3157
3158         Reviewed by Dimitri Glazkov.
3159
3160         This is a preparation patch for Bug 100451.
3161
3162         We preserve RuleFeatureSet collected from select attributes in ShadowDOM.
3163         When an element attribute is changed, we might have to invalidate content distribution,
3164         however it's high cost operation. So we would like to check RuleFeatureSet used in
3165         select attributes to determine we really need to invalidate distribution.
3166
3167         Like StyleResolver, ElementShadow has several rule features. When nested ShadowDOM is used,
3168         first we collect features in nested ShadowDOM, and merge it to the parent ShadowDOM.
3169         For the performance reason, we have a flag to check whether we need to collect features again.
3170
3171         Test: fast/dom/shadow/shadow-select-attribute-featureset.html
3172
3173         * WebCore.exp.in:
3174         * dom/ElementShadow.cpp:
3175         (WebCore::ElementShadow::ElementShadow):
3176         (WebCore::ElementShadow::setShouldCollectSelectFeatureSet): Enable a flag to collect feature set of descendant
3177         nodes (and their ShadowDOM).
3178         (WebCore):
3179         (WebCore::ElementShadow::ensureSelectFeatureSetCollected):
3180         (WebCore::ElementShadow::collectSelectFeatureSetFrom): Collect RuleFeatureSet from all descendant Nodes and their
3181         ShadowDOM. We need to collect id, class, and attribute names.
3182         * dom/ElementShadow.h:
3183         (WebCore::ElementShadow::shouldCollectSelectFeatureSet):
3184         (ElementShadow):
3185         (WebCore::ElementShadow::hasSelectorForId):
3186         (WebCore):
3187         (WebCore::ElementShadow::hasSelectorForClass):
3188         (WebCore::ElementShadow::hasSelectorForAttribute):
3189         * html/shadow/HTMLContentElement.cpp:
3190         (WebCore::HTMLContentElement::parseAttribute): When select attribute is changed, enable a flag to recollect features.
3191         (WebCore::HTMLContentElement::insertedInto): We have to recollect features when HTMLContentElement is moved.
3192         (WebCore::HTMLContentElement::removedFrom): ditto.
3193         * html/shadow/HTMLContentElement.h:
3194         (WebCore::toHTMLContentElement):
3195         (WebCore):
3196         * testing/Internals.cpp:
3197         (WebCore::Internals::hasSelectorForIdInShadow):
3198         (WebCore):
3199         (WebCore::Internals::hasSelectorForClassInShadow):
3200         (WebCore::Internals::hasSelectorForAttributeInShadow):
3201         * testing/Internals.h:
3202         (Internals):
3203         * testing/Internals.idl:
3204
3205 2012-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3206
3207         Unreviewed, rolling out r134144.
3208         http://trac.webkit.org/changeset/134144
3209         https://bugs.webkit.org/show_bug.cgi?id=101876
3210
3211         seems to break win 7 chromium browser test (Requested by
3212         hayato on #webkit).
3213
3214         * WebCore.exp.in:
3215         * page/EventHandler.cpp:
3216         (WebCore):
3217         (WebCore::EventHandler::handleMouseMoveEvent):
3218         * page/EventHandler.h:
3219         (EventHandler):
3220         * testing/Internals.cpp:
3221         * testing/Internals.h:
3222         * testing/Internals.idl:
3223
3224 2012-11-11  Kent Tamura  <tkent@chromium.org>
3225
3226         Internals: MockPagePopup should not update DOM structure during detach()
3227         https://bugs.webkit.org/show_bug.cgi?id=101710
3228
3229         Reviewed by Hajime Morita.
3230
3231         PickerIndicatorElement::detach calls
3232         MockPagePopupDriver::closePagePopup, MockPagePopup::~MockPagePopup,
3233         which remove the mock iframe from the tree. But updating the tree during
3234         detach() is dangerous.
3235
3236         MockPagePopupDriver::closePagePopup calls MockpagePopup::closeLater, it
3237         requests to call 'close' asynchronously, and 'close' removes the mock
3238         iframe. We need to change MockPagePopup so that it is ref-couted and has
3239         a timer.
3240
3241         No new tests. This is a change for the test harness.
3242
3243         * testing/MockPagePopupDriver.cpp:
3244         (MockPagePopup): Make this ref-counted, add closeLater, add close, and
3245         add m_closeTimer.
3246         (WebCore::MockPagePopup::MockPagePopup): Initialize the timer.
3247         (WebCore::MockPagePopup::create): PassOwnPtr -> PassRefPtr
3248         (WebCore::MockPagePopup::closeLater):
3249         - Add one reference to avoid destruction by m_mockPagePopup.clear() in
3250           closePagePopup.
3251         - Notify didClosePopup here because the client expects didClosePopup is
3252           called synchronously.
3253         - Invoke the timer to call 'close'
3254         (WebCore::MockPagePopup::close):
3255         Just remove one reference. This means calling the desructor.
3256         (WebCore::MockPagePopup::~MockPagePopup):
3257         Move didClosePopup call to caloseLater.
3258         (WebCore::MockPagePopupDriver::closePagePopup):
3259         Request to close PagePopup.
3260         Clear PagePopupClient in m_pagePopupController because this object is
3261         necessary until MockPagePopup is closed, but it should not have a
3262         reference to the PagePopupClient.
3263         * testing/MockPagePopupDriver.h:
3264         (MockPagePopupDriver): Make MockPagePopup ref-counted.
3265
3266 2012-11-11  Adam Barth  <abarth@webkit.org>
3267
3268         axObjectCache code is more complicated than necessary
3269         https://bugs.webkit.org/show_bug.cgi?id=101820
3270
3271         Reviewed by Darin Adler.
3272
3273         This code should use OwnPtr rather than manually calling new/delete.
3274         Also, instead of using a "double check" pattern, we can just access the
3275         private fields on the top document directly.
3276
3277         * dom/Document.cpp:
3278         (WebCore::Document::Document):
3279         (WebCore::Document::clearAXObjectCache):
3280         (WebCore::Document::axObjectCacheExists):
3281         (WebCore):
3282         (WebCore::Document::axObjectCache):
3283         * dom/Document.h:
3284         (Document):
3285
3286 2012-11-10  Simon Fraser  <simon.fraser@apple.com>
3287
3288         Save one call to containerForRepaint() when updating layer positions
3289         https://bugs.webkit.org/show_bug.cgi?id=101856
3290
3291         Reviewed by Dan Bernstein.
3292
3293          RenderLayer::updateLayerPositions() has already computed the repaint container,
3294          but calls computeRepaintRects() which computes it again. Computing the repaint
3295          container involves a walk back up the layer tree, so calling it during a tree
3296          traversal is costly.
3297          
3298          Fix by passing the repaint container down into computeRepaintRects().
3299
3300         * rendering/RenderLayer.cpp:
3301         (WebCore::RenderLayer::updateLayerPositions):
3302         (WebCore::RenderLayer::computeRepaintRects):
3303         (WebCore::RenderLayer::computeRepaintRectsIncludingDescendants):
3304         (WebCore::RenderLayer::updateLayerPositionsAfterScroll):
3305         (WebCore::RenderLayer::setHasVisibleContent):
3306         * rendering/RenderLayer.h:
3307         (RenderLayer):
3308
3309 2012-11-11  Kenichi Ishibashi  <bashi@chromium.org>
3310
3311         WTFString::utf8() should have a mode of conversion to use replacement character
3312         https://bugs.webkit.org/show_bug.cgi?id=101678
3313
3314         Reviewed by Alexey Proskuryakov.
3315
3316         Follow the change on String::utf8()
3317
3318         No new tests. No changes in behavior.
3319
3320         * Modules/websockets/WebSocket.cpp:
3321         (WebCore::WebSocket::close): Pass String::StrictConversion instead of true to String::utf8().
3322         * Modules/websockets/WebSocketChannel.cpp:
3323         (WebCore::WebSocketChannel::send): Ditto.
3324         * html/MediaFragmentURIParser.cpp:
3325         (WebCore::MediaFragmentURIParser::parseFragments): Ditto.
3326         * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
3327         (WebCore::MediaPlayerPrivate::notifyChallengeResult): Ditto.
3328         * platform/network/blackberry/rss/RSSFilterStream.cpp:
3329         (WebCore::RSSFilterStream::convertContentToHtml): Ditto.
3330         * platform/network/blackberry/rss/RSSGenerator.cpp:
3331         (WebCore::RSSGenerator::generateHtml): Ditto.
3332
3333 2012-11-10  Simon Fraser  <simon.fraser@apple.com>
3334
3335         Coalesce main thread scroll position updates
3336         https://bugs.webkit.org/show_bug.cgi?id=101855
3337
3338         Reviewed by Anders Carlsson.
3339
3340         When using threaded scrolling, the dispatched updateMainFrameScrollPosition() calls 
3341         from ScrollingTree would pile up on the main thread, and we'd handle several per
3342         runloop cycle when scrolling fast. This causes extra work especially on pages
3343         with position:fixed elements which must update RenderLayers on scrolling.
3344         
3345         Fix by using a zero-delay timer in ScrollingCoordinator to coalesce these
3346         scrolling updates to one per runloop.
3347
3348         * page/scrolling/ScrollingCoordinator.cpp:
3349         (WebCore::ScrollingCoordinator::ScrollingCoordinator): Initialized data members
3350         for the scheduled scroll position update.
3351         (WebCore::ScrollingCoordinator::scheduleUpdateMainFrameScrollPosition): If 
3352         the timer is active and the parameters match, just update the target scroll
3353         position and return. If the params don't match, dispatch the scheduled update,
3354         and then the new one. Otherwise, prime the timer.
3355         (WebCore::ScrollingCoordinator::updateMainFrameScrollPositionTimerFired): Call
3356         the existing updateMainFrameScrollPosition() with the saved values.
3357         * page/scrolling/ScrollingCoordinator.h:
3358         * page/scrolling/ScrollingTree.cpp:
3359         (WebCore::ScrollingTree::updateMainFrameScrollPosition): Call scheduleUpdateMainFrameScrollPosition()
3360         rather than updateMainFrameScrollPosition().
3361         * page/scrolling/mac/ScrollingCoordinatorMac.mm:
3362         (WebCore::ScrollingCoordinatorMac::syncChildPositions): Fixed a bug that caused fixed
3363         position elements to jiggle with the patch; we should be calling syncPosition() (which just
3364         sets the position data, without touching CA layers).
3365
3366 2012-11-10  Simon Fraser  <simon.fraser@apple.com>
3367
3368         Remove ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition()
3369         https://bugs.webkit.org/show_bug.cgi?id=101514
3370
3371         Reviewed by Tim Horton.
3372
3373         ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition() is very similar to
3374         ScrollingCoordinator::updateMainFrameScrollPosition(). In order to eliminate updateMainFrameScrollPositionAndScrollLayerPosition(),
3375         we just need to plumb through a flag that says that updateMainFrameScrollPosition() should
3376         set the layer position (rather than just doing a 'sync').
3377
3378         * page/scrolling/ScrollingCoordinator.cpp:
3379         (WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
3380         * page/scrolling/ScrollingCoordinator.h:
3381         * page/scrolling/ScrollingTree.cpp:
3382         (WebCore::ScrollingTree::updateMainFrameScrollPosition):
3383         * page/scrolling/ScrollingTree.h:
3384         * page/scrolling/mac/ScrollingCoordinatorMac.h:
3385         * page/scrolling/mac/ScrollingCoordinatorMac.mm:
3386         * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
3387         (WebCore::ScrollingTreeScrollingNodeMac::setScrollPositionWithoutContentEdgeConstraints):
3388
3389 2012-11-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3390
3391         Unreviewed, rolling out r134069.
3392         http://trac.webkit.org/changeset/134069
3393         https://bugs.webkit.org/show_bug.cgi?id=101852
3394
3395         "It is a wrong way to fix the problem. See discussions in bug
3396         96614" (Requested by 1JTAAPQFJ on #webkit).
3397
3398         * bindings/js/JSDictionary.cpp:
3399         (WebCore::JSDictionary::getWithUndefinedOrNullCheck):
3400
3401 2012-11-10  Mike West  <mkwst@chromium.org>
3402
3403         Web Inspector: Multiple '%c' formatting options should all have effect.
3404         https://bugs.webkit.org/show_bug.cgi?id=101495
3405
3406         Reviewed by Pavel Feldman.
3407
3408         This patch supports multiple '%c' formatting blocks in console messages.
3409         'console.log("%cblue! %cgreen!", "color: blue;", "color: green;")' will
3410         do exactly what you expect: "blue!" will be blue, and "green!" will be
3411         green.
3412
3413         The implementation moves the styles off the message's parent 'span', and
3414         onto new 'span' elements that wrap the various textual bits of the
3415         message.
3416
3417         * inspector/front-end/ConsoleMessage.js:
3418         (WebInspector.ConsoleMessageImpl.prototype.):
3419         (WebInspector.ConsoleMessageImpl.prototype.append):
3420         (WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
3421
3422 2012-11-10  Mike West  <mkwst@chromium.org>
3423
3424         Including <CoreText/CoreText.h> breaks the chromium/mac build.
3425         https://bugs.webkit.org/show_bug.cgi?id=101851
3426
3427         Reviewed by Dan Bernstein.
3428
3429         r134146 introduced inclusion of 'CoreText/CoreText.h' in
3430         SimpleFontDataCoreText.cpp, which broke the chromium/mac build. Grepping
3431         around, it looks like this needs to be modified to include
3432         'ApplicationServices/ApplicationServices.h'.
3433
3434         * platform/graphics/mac/SimpleFontDataCoreText.cpp:
3435             Drop 'CoreText.h' in favor of 'ApplicationServices.h'.
3436         * platform/graphics/mac/ComplexTextControllerCoreText.mm:
3437             Drop the platform-specific '#if' logic; just include 'ApplicationServices.h'.
3438
3439 2012-11-10  Andreas Kling  <kling@webkit.org>
3440
3441         Don't detach from shared ElementAttributeData when overwriting attribute with identical value.
3442         <http://webkit.org/b/101849>
3443
3444         Reviewed by Anders Carlsson.
3445
3446         Defer the mutableAttributeData() call in Element::setAttributeInternal() until the last
3447         possible moment, to avoid unnecessarily detaching and cloning from attribute data.
3448
3449         120 kB progression on Membuster3.
3450
3451         * dom/Element.cpp:
3452         (WebCore::Element::setAttributeInternal):
3453         (WebCore::Element::addAttributeInternal):
3454
3455 2012-11-10  Simon Fraser  <simon.fraser@apple.com>
3456
3457         Some minor optimizations in RenderLayer
3458         https://bugs.webkit.org/show_bug.cgi?id=101847
3459
3460         Reviewed by Anders Carlsson.
3461
3462         Some minor performance improvements in RenderLayer code.
3463
3464         * rendering/RenderLayer.cpp:
3465         (WebCore::RenderLayer::updateLayerPosition): isRenderInline() is a virtual call,
3466         so prefix it with an isInline() check which tests a bit on RenderObject.
3467         (WebCore::RenderLayer::localBoundingBox): Ditto.
3468         (WebCore::RenderLayer::calculateLayerBounds): Pull layer->renderer()
3469         into a local variable.
3470
3471 2012-11-10  Anders Carlsson  <andersca@apple.com>
3472
3473         Document::m_fullScreenElementStack should be a Vector
3474         https://bugs.webkit.org/show_bug.cgi?id=101844
3475
3476         Reviewed by Andreas Kling.
3477
3478         m_fullScreenElementStack is currently a Deque where elements are being prepended
3479         and removed from the beginning in LIFO order, so it can be replaced with a Vector.
3480
3481         * dom/Document.cpp:
3482         (WebCore::Document::requestFullScreenForElement):
3483         (WebCore::Document::webkitCancelFullScreen):
3484         (WebCore::Document::popFullscreenElementStack):
3485         (WebCore::Document::pushFullscreenElementStack):