Unreviewed, rolling out r100473.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-11-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r100473.
4         http://trac.webkit.org/changeset/100473
5         https://bugs.webkit.org/show_bug.cgi?id=72534
6
7         "Broke the Mac Build" (Requested by mwenge2 on #webkit).
8
9         * CMakeLists.txt:
10         * GNUmakefile.list.am:
11         * Target.pri:
12         * WebCore.gypi:
13         * rendering/RenderBlock.cpp:
14         (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
15         * rendering/RenderObject.cpp:
16         (WebCore::RenderObject::createObject):
17         (WebCore::RenderObject::addChild):
18         * rendering/RenderObject.h:
19         * rendering/RenderTable.cpp:
20         (WebCore::RenderTable::addChild):
21         * rendering/RenderTable.h:
22         * rendering/RenderTableCaption.cpp: Removed.
23         * rendering/RenderTableCaption.h: Removed.
24
25 2011-11-16  Sheriff Bot  <webkit.review.bot@gmail.com>
26
27         Unreviewed, rolling out r100479.
28         http://trac.webkit.org/changeset/100479
29         https://bugs.webkit.org/show_bug.cgi?id=72533
30
31         "Broke the Mac Build" (Requested by mwenge2 on #webkit).
32
33         * WebCore.vcproj/WebCore.vcproj:
34         * WebCore.xcodeproj/project.pbxproj:
35         * rendering/RenderingAllInOne.cpp:
36
37 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
38
39         WebKitTestRunner needs to support accessibility-related DRT APIs
40         https://bugs.webkit.org/show_bug.cgi?id=42131
41
42         Minor changes needed to support AX testing in WKTestRunner.
43
44         Reviewed by Beth Dakin.
45
46         * WebCore.exp.in:
47              Expose focusedUIElementForPage so that the WK2 injected bundle can retrieve it.
48         * accessibility/mac/WebAccessibilityObjectWrapper.mm:
49         (accessibilitySearchKeyForString):
50             Remove an unncessary assert that was causing issues with the WK2 test run.
51
52 2011-11-16  Sergio Villar Senin  <svillar@igalia.com>
53
54         [Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET
55         https://bugs.webkit.org/show_bug.cgi?id=69219
56
57         Reviewed by Martin Robinson.
58
59         Do not stop appending data to the request body if any of the blob
60         items to upload is not accesible.
61
62         * platform/network/soup/ResourceHandleSoup.cpp:
63         (WebCore::addEncodedBlobToSoupMessageBody):
64
65 2011-11-16  Beth Dakin  <bdakin@apple.com>
66
67         https://bugs.webkit.org/show_bug.cgi?id=72400
68         Scrollbar uiStateTransitionProgress requires tracking the mouse all the time
69         -and corresponding-
70         <rdar://problem/10409328>
71
72         Reviewed by Darin Adler.
73
74         This patch makes it so we track the mouse all the time when we have legacy 
75         scrollbars (rather than only tracking the mouse when the window is key). When 
76         we're in that mode, we want to do as little work as possible when handling the 
77         mouseMoved event so that this extra tracking has little to no performance impact. 
78         Also, we don't want to change basic behaviors by having normal web content hover 
79         effects start happening when a window is in the background. So this patch also 
80         introduces a way to handle a mouseMoved event that will only affect scrollbars.
81
82         EventHandler::mouseMoved() and EventHandler::handleMouseEvent() both now take a 
83         boolean parameter that indicates if we are only updating scrollbars. If that is 
84         the case, then we make our HitTestRequest ReadOnly, and we return early once 
85         updateLastScrollbarUnderMouse() is called.
86         * WebCore.exp.in:
87         * page/EventHandler.cpp:
88         (WebCore::EventHandler::mouseMoved):
89         (WebCore::EventHandler::handleMouseMoveEvent):
90
91         In addition to calling Scrollbar::mouseExited() when appropriate, this function 
92         now calls a new function, Scrollbar::mouseEntered() when appropriate. 
93         (WebCore::EventHandler::updateLastScrollbarUnderMouse):
94         * page/EventHandler.h:
95
96         Scrollbar::mouseMoved() used to be responsible for calling 
97         ScrollAnimator::mouseEnteredScrollbar(), but now Scrollbar::mouseEntered() takes 
98         care of that instead, much like how Scrollbar::mouseExited() takes care of calling 
99         the animator's exit function.
100         * platform/Scrollbar.cpp:
101         (WebCore::Scrollbar::mouseMoved):
102         (WebCore::Scrollbar::mouseEntered):
103         * platform/Scrollbar.h:
104
105 2011-11-16  Andreas Kling  <kling@webkit.org>
106
107         CSSValue: isInheritedValue() doesn't need a dedicated bit.
108         <http://webkit.org/b/72514>
109
110         Reviewed by Antti Koivisto.
111
112         Remove CSSValue::m_isInherited and have isInheritedValue() check the
113         class type instead. There's no compelling reason for CSSInheritedValue
114         to have a dedicated bit, since nobody subclasses it anyway.
115
116         * css/CSSValue.h:
117         (WebCore::CSSValue::isInheritedValue):
118         (WebCore::CSSValue::CSSValue):
119
120 2011-11-16  Robert Hogan  <robert@webkit.org>
121
122         Fix build on Windows and Mac after r100473
123
124         Unreviewed, fix build.
125
126         * WebCore.vcproj/WebCore.vcproj:
127         * WebCore.xcodeproj/project.pbxproj:
128         * rendering/RenderingAllInOne.cpp:
129
130 2011-11-16  Philip Rogers  <pdr@google.com>
131
132         Remove extra GraphicsContextStateSaver restore() call.
133         https://bugs.webkit.org/show_bug.cgi?id=72497
134
135         Reviewed by Andreas Kling.
136
137         * html/canvas/CanvasRenderingContext2D.cpp:
138         (WebCore::CanvasRenderingContext2D::drawTextInternal):
139
140 2011-11-08  Robert Hogan  <robert@webkit.org>
141
142         CSS 2.1 failure: border-collapse-offset-002.htm fails
143         https://bugs.webkit.org/show_bug.cgi?id=71705
144
145         Table captions are implemented as children of the table but have a special
146         requirement to expand to the full width of the table rather than just the 'available'
147         width, i.e. the full width minus padding and borders.
148
149         To accomodate this create a RenderTableCaption object that reimplements containingBlockLogicalWidthForContent()
150         to return the full width of the containing block (i.e. the table) rather than the available width.
151
152         Reviewed by Antti Koivisto.
153
154         * CMakeLists.txt: Add RenderTableCaption.[cpp|h]
155         * GNUmakefile.list.am: Add RenderTableCaption.[cpp|h]
156         * Target.pri: Add RenderTableCaption.[cpp|h]
157         * WebCore.gypi: Add RenderTableCaption.[cpp|h]
158         * rendering/RenderBlock.cpp:
159         (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Use RenderTableCaption
160         * rendering/RenderObject.cpp:
161         (WebCore::RenderObject::createObject): Add RenderTableCaption.[cpp|h]
162         (WebCore::RenderObject::addChild): ditto
163         * rendering/RenderObject.h:
164         (WebCore::RenderObject::isTableCaption):
165         * rendering/RenderTable.cpp:
166         (WebCore::RenderTable::addChild):
167         * rendering/RenderTable.h:
168         * rendering/RenderTableCaption.cpp: Added.
169         (WebCore::RenderTableCaption::RenderTableCaption): Implement RenderTableCaption
170         (WebCore::RenderTableCaption::~RenderTableCaption):
171         (WebCore::RenderTableCaption::containingBlockLogicalWidthForContent): Return the containing block's full width rather than it's available width.
172         * rendering/RenderTableCaption.h: Added.
173         (WebCore::RenderTableCaption::isTableCaption):
174         (WebCore::toRenderTableCaption):
175
176 2011-11-16  Antaryami Pandia  <antaryami.pandia@motorola.com>
177
178         [Gtk] display:none has no effect on <option> element.
179         https://bugs.webkit.org/show_bug.cgi?id=72370
180
181         Reviewed by Martin Robinson.
182
183         * platform/gtk/GtkPopupMenu.cpp:
184         (WebCore::GtkPopupMenu::appendItem):
185         * platform/gtk/PopupMenuGtk.cpp:
186         (WebCore::PopupMenuGtk::createGtkActionForMenuItem):
187
188 2011-11-16  Dan Winship  <danw@gnome.org>
189
190         [GTK] Fix platformDefersLoading to handle non-http requests, and
191         to not use broken-ish libsoup APIs.
192         https://bugs.webkit.org/show_bug.cgi?id=72227
193
194         Reviewed by Martin Robinson.
195
196         * platform/network/ResourceHandleInternal.h:
197         * platform/network/soup/ResourceHandleSoup.cpp:
198         (WebCore::sendRequestCallback):
199         (WebCore::startHTTPRequest):
200         (WebCore::hasBeenSent):
201         (WebCore::ResourceHandle::platformSetDefersLoading):
202         (WebCore::readCallback): rather than deferring by using
203         soup_session_pause_message(), let the read complete, but just don't
204         process the result until we're no longer deferred.
205         (WebCore::startNonHTTPRequest): Don't start the request if
206         it's deferred.
207
208 2011-11-16  Vsevolod Vlasov  <vsevik@chromium.org>
209
210         Web Inspector: Application cache status should be updated after swapCache().
211         https://bugs.webkit.org/show_bug.cgi?id=72123
212
213         Reviewed by Pavel Feldman.
214
215         Application cache view resources and status are now updated after swapCache() call.
216         Refresh button removed from application cache view.
217         Application cache inspector tests are moved to their own folder.
218
219         Tests: http/tests/inspector/appcache/appcache-iframe-manifests.html
220                http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
221                http/tests/inspector/appcache/appcache-swap.html
222
223         * inspector/front-end/ApplicationCacheItemsView.js:
224         (WebInspector.ApplicationCacheItemsView):
225         (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):
226         (WebInspector.ApplicationCacheItemsView.prototype.wasShown):
227         (WebInspector.ApplicationCacheItemsView.prototype._maybeUpdate):
228         (WebInspector.ApplicationCacheItemsView.prototype._markDirty):
229         (WebInspector.ApplicationCacheItemsView.prototype.updateStatus):
230         (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
231         (WebInspector.ApplicationCacheItemsView.prototype._deleteCallback):
232         * loader/appcache/ApplicationCacheGroup.cpp:
233         (WebCore::ApplicationCacheGroup::setNewestCache):
234         (WebCore::ApplicationCacheGroup::makeObsolete):
235         (WebCore::ApplicationCacheGroup::setUpdateStatus):
236         * loader/appcache/ApplicationCacheHost.cpp:
237         (WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
238         (WebCore::ApplicationCacheHost::swapCache):
239
240 2011-11-16  Eric Carlson  <eric.carlson@apple.com>
241
242         addTrack() must throw an exception if 'kind' is unknown
243         https://bugs.webkit.org/show_bug.cgi?id=71915
244
245         Reviewed by Philippe Normand.
246
247         Tests: media/track/track-addtrack-kind.html
248                media/track/track-kind.html
249
250         * html/HTMLMediaElement.cpp:
251         (WebCore::HTMLMediaElement::textTrackKindChanged): New. Will be implemented for 62885.
252         (WebCore::HTMLMediaElement::addTrack): Throw if  'kind' is not a known value.
253         (WebCore::HTMLMediaElement::addTextTrack): Call textTracks(), it will allocate the track
254             list object if necessary.
255         (WebCore::HTMLMediaElement::textTracks): Never return NULL, a TextTrackList with no tracks
256             is allowed.
257         * html/HTMLMediaElement.h:
258         (WebCore::HTMLMediaElement::addTrack): Add variants to deal with optional parameters plus
259             a mandatory ExceptionCode parameter.
260         * html/HTMLMediaElement.idl: addTrack can generate an exception.
261
262         * html/HTMLTrackElement.cpp:
263         (WebCore::HTMLTrackElement::attributeChanged): kind, label, and srclang attribute changes should
264             percolate down the the TextTrack.
265         (WebCore::HTMLTrackElement::kind): Return the TextTrack kind because it is not necessarily the
266             same as the attribute value.
267         (WebCore::HTMLTrackElement::ensureTrack): Only pass legal 'kind' keywords to create a TextTrack.
268         (WebCore::HTMLTrackElement::textTrackKindChanged): Notify parent element, if any.
269         * html/HTMLTrackElement.h:
270
271         * html/TextTrack.cpp:
272         (WebCore::TextTrack::subtitlesKeyword): New, return legal kind attribute value.
273         (WebCore::TextTrack::captionsKeyword): Ditto.
274         (WebCore::TextTrack::descriptionsKeyword): Ditto.
275         (WebCore::TextTrack::chaptersKeyword): Ditto.
276         (WebCore::TextTrack::metadataKeyword): Ditto.
277         (WebCore::TextTrack::TextTrack): Call setKind to make sure m_kind is always set to legal value.
278         (WebCore::TextTrack::isValidKindKeyword): New, validate 'kind' value.
279         (WebCore::TextTrack::setKind): Only allow legal values.
280         * html/TextTrack.h:
281         (WebCore::TextTrack::kind):
282         (WebCore::TextTrack::label):
283         (WebCore::TextTrack::setLabel):
284         (WebCore::TextTrack::language):
285         (WebCore::TextTrack::setLanguage):
286         (WebCore::TextTrack::readyState):
287         (WebCore::TextTrack::mode):
288
289 2011-11-16  Andreas Kling  <kling@webkit.org>
290
291         CSSValue: Clean up initial value construction.
292         <http://webkit.org/b/72502>
293
294         Reviewed by Antti Koivisto.
295
296         Instead of determining whether a given CSSInitialValue is 'implicit' or not by
297         querying the CSSValue::ClassType (InitialClass vs. ImplicitInitialClass),
298         add a protected CSSValue member and set it from the CSSInitialValue constructor.
299
300         Also get rid of the CSSValue::m_isInitial bit since we can now replace the
301         checks by classType() == InitialClass.
302
303         No new tests, this is a cleanup.
304
305         * css/CSSInitialValue.h:
306         (WebCore::CSSInitialValue::CSSInitialValue):
307
308             Poke 'implicit' constructor argument into CSSValue::m_isImplicit.
309
310         * css/CSSValue.cpp:
311         (WebCore::CSSValue::cssText):
312         (WebCore::CSSValue::destroy):
313
314             Remove ImplicitInitialClass cases.
315
316         * css/CSSValue.h:
317         (WebCore::CSSValue::isImplicitInitialValue):
318         (WebCore::CSSValue::isInitialValue):
319         (WebCore::CSSValue::CSSValue):
320
321 2011-11-16  Antaryami Pandia  <antaryami.pandia@motorola.com>
322
323         Remove unnecessary if check from RenderListBox::paintItemForeground.
324         https://bugs.webkit.org/show_bug.cgi?id=72488
325
326         Reviewed by Andreas Kling.
327
328         * rendering/RenderListBox.cpp:
329         (WebCore::RenderListBox::paintItemForeground):
330
331 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
332
333         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
334
335         Reviewed by Tor Arne Vestbø.
336
337         * Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
338
339 2011-11-16  Iain Merrick  <husky@google.com>
340
341         [chromium] Pass screen refresh rate into compositor.
342         https://bugs.webkit.org/show_bug.cgi?id=71040
343
344         Reviewed by Tony Gentilcore.
345
346         * platform/PlatformScreen.h:
347         * platform/chromium/PlatformScreenChromium.cpp:
348         (WebCore::screenRefreshRate):
349         * platform/chromium/PlatformSupport.h:
350         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
351         (WebCore::CCSettings::CCSettings):
352         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
353         (WebCore::CCThreadProxy::initializeImplOnImplThread):
354
355 2011-11-15  Andrey Kosyakov  <caseq@chromium.org>
356
357         Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead
358         https://bugs.webkit.org/show_bug.cgi?id=72388
359
360         Reviewed by Pavel Feldman.
361
362         Tests: inspector/extensions/extensions-panel.html
363                inspector/extensions/extensions-sidebar.html
364
365         - fire ExtensionSidebarPane.on{Hidden,Shown} for non-iframe content (experssions/objects);
366         - drop ExtensionsSidebarPane.onUpdated, provide callback for setObject()/setExpression() instead;
367         - fix an exception when a page is replaced with object/expression.
368
369          inspector/front-end/ExtensionAPI.js:
370         (injectedExtensionAPI.ExtensionSidebarPaneImpl):
371         (injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
372         (injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setObject):
373         * inspector/front-end/ExtensionPanel.js:
374         (WebInspector.ExtensionNotifierView):
375         (WebInspector.ExtensionNotifierView.prototype.wasShown):
376         (WebInspector.ExtensionNotifierView.prototype.willHide):
377         (WebInspector.ExtensionSidebarPane.prototype.setObject):
378         (WebInspector.ExtensionSidebarPane.prototype.setExpression):
379         (WebInspector.ExtensionSidebarPane.prototype.setPage):
380         (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
381         (WebInspector.ExtensionSidebarPane.prototype._makeObjectPropertiesView):
382         (WebInspector.ExtensionSidebarPane.prototype._setObject):
383         * inspector/front-end/ExtensionServer.js:
384         (WebInspector.ExtensionServer.prototype._onSetSidebarContent.callback):
385         (WebInspector.ExtensionServer.prototype._onSetSidebarContent):
386         (WebInspector.ExtensionServer.prototype._dispatchCallback):
387         * inspector/front-end/View.js:
388         (WebInspector.View.prototype.detach):
389
390 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
391
392         Unreviewed, rolling out r100266.
393         http://trac.webkit.org/changeset/100266
394
395         Broke WTR.
396
397         * Target.pri:
398
399 2011-11-16  Per-Erik Brodin  <per-erik.brodin@ericsson.com>
400
401         [GTK] fast/events/event-creation.html fails creating MediaStreamEvent
402         https://bugs.webkit.org/show_bug.cgi?id=70720
403
404         Reviewed by Philippe Normand.
405
406         Added missing overriding of Event::interfaceName()
407
408         * mediastream/MediaStreamEvent.cpp:
409         (WebCore::MediaStreamEvent::stream): Changed return value to raw pointer.
410         (WebCore::MediaStreamEvent::interfaceName): Added back from r98044.
411         * mediastream/MediaStreamEvent.h:
412         * mediastream/MediaStreamEvent.idl: Changed module name to "events".
413
414 2011-11-16  Mario Sanchez Prada  <msanchez@igalia.com>
415
416         [GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
417         https://bugs.webkit.org/show_bug.cgi?id=72394
418
419         Reviewed by Martin Robinson.
420
421         No new functionality, no new tests needed.
422
423         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
424         (webkit_accessible_class_init): Initialize GQuarks.
425         (getGailTextUtilForAtk): Use gailTextUtilQuark.
426         (getPangoLayoutForAtk): Remove unused call to
427         g_object_set_data_full, since that data is no used anywhere.
428         (webkitAccessibleHyperlinkImplGetHyperlink): Use hyperlinkObjectQuark.
429
430 2011-11-15  Alexandru Chiculita  <achicu@adobe.com>
431
432         [CSSShaders] Implement the style cached resources and computed style for the shader urls
433         https://bugs.webkit.org/show_bug.cgi?id=72378
434
435         Reviewed by Dean Jackson.
436
437         Test: css3/filters/custom-filter-property-computed-style.html
438
439         * GNUmakefile.list.am:
440         * Target.pri:
441         * WebCore.gypi:
442         * WebCore.vcproj/WebCore.vcproj:
443         * WebCore.xcodeproj/project.pbxproj:
444         * css/CSSComputedStyleDeclaration.cpp:
445         (WebCore::CSSComputedStyleDeclaration::valueForFilter):
446         * css/CSSStyleSelector.cpp:
447         (WebCore::CSSStyleSelector::CSSStyleSelector):
448         (WebCore::CSSStyleSelector::styleForKeyframe):
449         (WebCore::CSSStyleSelector::pseudoStyleForElement):
450         (WebCore::CSSStyleSelector::styleForPage):
451         (WebCore::CSSStyleSelector::applyMatchedDeclarations):
452         (WebCore::CSSStyleSelector::styleShader):
453         (WebCore::CSSStyleSelector::cachedOrPendingStyleShaderFromValue):
454         (WebCore::CSSStyleSelector::loadPendingShaders):
455         (WebCore::CSSStyleSelector::createCustomFilterOperation):
456         (WebCore::CSSStyleSelector::createFilterOperations):
457         * css/CSSStyleSelector.h:
458         * css/WebKitCSSShaderValue.cpp:
459         (WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
460         (WebCore::WebKitCSSShaderValue::~WebKitCSSShaderValue):
461         (WebCore::WebKitCSSShaderValue::cachedShader):
462         (WebCore::WebKitCSSShaderValue::cachedOrPendingShader):
463         * css/WebKitCSSShaderValue.h:
464         * loader/cache/CachedResource.cpp:
465         (WebCore::defaultPriorityForResourceType):
466         * loader/cache/CachedResource.h:
467         * loader/cache/CachedResourceLoader.cpp:
468         (WebCore::createResource):
469         (WebCore::CachedResourceLoader::requestShader):
470         (WebCore::CachedResourceLoader::checkInsecureContent):
471         (WebCore::CachedResourceLoader::canRequest):
472         * loader/cache/CachedResourceLoader.h:
473         * loader/cache/CachedShader.cpp:
474         (WebCore::CachedShader::CachedShader):
475         (WebCore::CachedShader::~CachedShader):
476         * loader/cache/CachedShader.h:
477         * platform/graphics/filters/CustomFilterOperation.h:
478         * rendering/style/RenderStyle.h:
479         (WebCore::InheritedFlags::filter):
480         * rendering/style/StyleCachedShader.cpp:
481         (WebCore::StyleCachedShader::StyleCachedShader):
482         (WebCore::StyleCachedShader::cssValue):
483         * rendering/style/StyleCachedShader.h:
484         (WebCore::StyleCachedShader::create):
485         * rendering/style/StylePendingShader.h:
486         (WebCore::StylePendingShader::create):
487         (WebCore::StylePendingShader::cssValue):
488         (WebCore::StylePendingShader::cssShaderValue):
489         (WebCore::StylePendingShader::StylePendingShader):
490         * rendering/style/StyleShader.h:
491         (WebCore::StyleShader::~StyleShader):
492         (WebCore::StyleShader::isCachedShader):
493         (WebCore::StyleShader::isPendingShader):
494         (WebCore::StyleShader::StyleShader):
495
496 2011-11-15  Sergio Villar Senin  <svillar@igalia.com>
497
498         [WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
499         https://bugs.webkit.org/show_bug.cgi?id=69510
500
501         Reviewed by Simon Fraser.
502
503         End the current transparency layer before early returning from
504         paintMask() when there is a maskBoxImage which is still being
505         loaded. This will balance the previous call to
506         beginTransparencyLayer().
507
508         * rendering/InlineFlowBox.cpp:
509         (WebCore::InlineFlowBox::paintMask):
510
511 2011-11-15  Darin Adler  <darin@apple.com>
512
513         Incorrect type checks in RenderTheme media code
514         https://bugs.webkit.org/show_bug.cgi?id=72184
515
516         Reviewed by Eric Carlson.
517
518         No tests added. Ideally this patch should be revised to add tests!
519
520         * accessibility/AccessibilityMediaControls.cpp:
521         (WebCore::AccessibilityMediaControl::create): Use mediaControlElementType.
522         (WebCore::AccessibilityMediaControl::controlType): Ditto.
523         (WebCore::AccessibilityMediaTimeline::valueDescription): Use early return
524         rather than an assertion to check type of input element.
525
526         * html/shadow/MediaControlElements.cpp:
527         (WebCore::mediaControlElementType): Added. A type-safe way to get the
528         media control element type after checking isMediaControlElement but with
529         no other assumptions.
530         * html/shadow/MediaControlElements.h: Added mediaControlElementType.
531
532         * platform/efl/RenderThemeEfl.cpp:
533         (WebCore::RenderThemeEfl::paintMediaPlayButton): Use mediaControlElementType.
534         (WebCore::RenderThemeEfl::paintMediaSeekBackButton): Use mediaControlElementType.
535         (WebCore::RenderThemeEfl::paintMediaSeekForwardButton): Use mediaControlElementType.
536         * platform/gtk/RenderThemeGtk.cpp:
537         (WebCore::RenderThemeGtk::paintMediaPlayButton): Check isMediaControlElement and
538         use mediaControlElementType.
539         * rendering/RenderThemeMac.mm:
540         (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto. Also remove uneeded
541         redundant null check.
542         (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
543         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton): Ditto.
544
545 2011-11-15  Jeff Timanus  <twiz@chromium.org>
546
547         [chromium] During tear down, prevent the WebGLLayerChromium instance from attempting to stop a timer for a NULL context.
548         https://bugs.webkit.org/show_bug.cgi?id=72423
549
550         Reviewed by Kenneth Russell.
551
552         * platform/graphics/chromium/WebGLLayerChromium.cpp:
553         (WebCore::WebGLLayerChromium::setDrawingBuffer):
554
555 2011-11-15  Mark Hahnenberg  <mhahnenberg@apple.com>
556
557         Rebaseline generated WebCore bindings
558
559         Unreviewed build fix
560
561         No new tests.
562
563         * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
564         (WebCore::isObservable):
565         (WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
566         (WebCore::JSTestEventConstructorOwner::finalize):
567         * bindings/scripts/test/JS/JSTestEventConstructor.h:
568         (WebCore::JSTestEventConstructor::clearImpl):
569         (WebCore::wrapperOwner):
570         (WebCore::wrapperContext):
571         * bindings/scripts/test/JS/JSTestInterface.cpp:
572         (WebCore::JSTestInterfaceOwner::finalize):
573         * bindings/scripts/test/JS/JSTestInterface.h:
574         (WebCore::JSTestInterface::clearImpl):
575         * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
576         (WebCore::isObservable):
577         (WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
578         (WebCore::JSTestMediaQueryListListenerOwner::finalize):
579         * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
580         (WebCore::JSTestMediaQueryListListener::clearImpl):
581         (WebCore::wrapperOwner):
582         (WebCore::wrapperContext):
583         * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
584         (WebCore::JSTestNamedConstructorOwner::finalize):
585         * bindings/scripts/test/JS/JSTestNamedConstructor.h:
586         (WebCore::JSTestNamedConstructor::clearImpl):
587         * bindings/scripts/test/JS/JSTestObj.cpp:
588         (WebCore::isObservable):
589         (WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
590         (WebCore::JSTestObjOwner::finalize):
591         * bindings/scripts/test/JS/JSTestObj.h:
592         (WebCore::JSTestObj::clearImpl):
593         (WebCore::wrapperOwner):
594         (WebCore::wrapperContext):
595         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
596         (WebCore::isObservable):
597         (WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
598         (WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
599         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
600         (WebCore::JSTestSerializedScriptValueInterface::clearImpl):
601         (WebCore::wrapperOwner):
602         (WebCore::wrapperContext):
603
604 2011-11-15  Jeff Timanus  <twiz@chromium.org>
605
606         Patch removing duplicated code in the setup of the DrawingBuffer used
607         to host the back-buffer for WebGL contents.
608         https://bugs.webkit.org/show_bug.cgi?id=72327
609
610         Reviewed by Kenneth Russell.
611
612         * html/canvas/WebGLRenderingContext.cpp:
613         (WebCore::WebGLRenderingContext::copyTexImage2D):
614         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
615         (WebCore::WebGLRenderingContext::readPixels):
616
617 2011-11-15  Mark Hahnenberg  <mhahnenberg@apple.com>
618
619         JS DOM wrappers depend on destructor to deref impl RefPtrs
620         https://bugs.webkit.org/show_bug.cgi?id=72341
621
622         Reviewed by Sam Weinig.
623
624         No new tests.
625
626         Added clearing of impl RefPtrs to JS DOM wrapper nodes and removed the default 
627         wrapperOwner function in favor of generating all WeakHandleOwners and wrapperOwner functions.
628
629         * bindings/js/JSCSSValueCustom.cpp:
630         (WebCore::JSCSSValueOwner::finalize):
631         * bindings/js/JSDOMBinding.h:
632         * bindings/js/JSNodeCustom.cpp:
633         (WebCore::JSNodeOwner::finalize):
634         * bindings/scripts/CodeGeneratorJS.pm:
635         (GenerateHeader):
636         (GenerateImplementation):
637
638 2011-11-15  Joseph Pecoraro  <pecoraro@apple.com>
639
640         Web Inspector: Share Highlight Code for Drawing Outlined Quad
641         https://bugs.webkit.org/show_bug.cgi?id=72451
642
643         Reviewed by Timothy Hatcher.
644
645         * inspector/DOMNodeHighlighter.cpp:
646
647 2011-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
648
649         Unreviewed, rolling out r100308.
650         http://trac.webkit.org/changeset/100308
651         https://bugs.webkit.org/show_bug.cgi?id=72450
652
653         Introduces WebGL conformance test regressions. (Requested by
654         twiz on #webkit).
655
656         * html/canvas/WebGLRenderingContext.cpp:
657         (WebCore::WebGLRenderingContext::copyTexImage2D):
658         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
659         (WebCore::WebGLRenderingContext::readPixels):
660
661 2011-11-15  James Robinson  <jamesr@chromium.org>
662
663         Rollout http://trac.webkit.org/changeset/99813, caused some crashes in
664         TiledLayerChromium::updateCompositorResources()
665
666         * WebCore.gypi:
667         * platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Removed.
668         * platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Removed.
669         * platform/graphics/chromium/CanvasLayerTextureUpdater.cpp: Removed.
670         * platform/graphics/chromium/CanvasLayerTextureUpdater.h: Removed.
671         * platform/graphics/chromium/ContentLayerChromium.cpp:
672         (WebCore::ContentLayerChromium::createTextureUpdater):
673         * platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Removed.
674         * platform/graphics/chromium/ImageLayerChromium.cpp:
675         (WebCore::ImageLayerTextureUpdater::prepareToUpdate):
676         * platform/graphics/chromium/LayerRendererChromium.cpp:
677         * platform/graphics/chromium/LayerTextureUpdater.h:
678         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp.
679         (WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
680         (WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
681         (WebCore::FrameBuffer::FrameBuffer::initialize):
682         (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
683         (WebCore::LayerTextureUpdaterCanvas::paintContents):
684         (WebCore::LayerTextureUpdaterBitmap::create):
685         (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
686         (WebCore::LayerTextureUpdaterBitmap::sampledTexelFormat):
687         (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
688         (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
689         (WebCore::LayerTextureUpdaterSkPicture::create):
690         (WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
691         (WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
692         (WebCore::LayerTextureUpdaterSkPicture::sampledTexelFormat):
693         (WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
694         (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
695         * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added.
696         (WebCore::LayerTextureUpdaterCanvas::contentRect):
697         (WebCore::LayerTextureUpdaterBitmap::orientation):
698         (WebCore::LayerTextureUpdaterSkPicture::orientation):
699         * platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Removed.
700         * platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Removed.
701         * platform/graphics/chromium/TiledLayerChromium.cpp:
702         (WebCore::UpdatableTile::UpdatableTile):
703         (WebCore::UpdatableTile::texture):
704         (WebCore::TiledLayerChromium::updateCompositorResources):
705         (WebCore::TiledLayerChromium::pushPropertiesTo):
706         (WebCore::TiledLayerChromium::createTile):
707         (WebCore::TiledLayerChromium::protectTileTextures):
708         (WebCore::TiledLayerChromium::prepareToUpdate):
709         * platform/graphics/chromium/cc/CCTextureUpdater.cpp:
710         (WebCore::CCTextureUpdater::append):
711         (WebCore::CCTextureUpdater::update):
712         * platform/graphics/chromium/cc/CCTextureUpdater.h:
713
714 2011-11-15  Julien Chaffraix  <jchaffraix@webkit.org>
715
716         Add the needed plumbing to parse display: -webkit-inline-grid
717         https://bugs.webkit.org/show_bug.cgi?id=72438
718
719         Reviewed by Tony Chang.
720
721         Test: fast/css-grid-layout/display-grid-set-get.html
722
723         Added the needed constants and plugged everything together.
724         Again we treat display: -webkit-inline-grid like display: none
725         for the moment.
726
727         * css/CSSParser.cpp:
728         (WebCore::CSSParser::parseValue):
729         * css/CSSPrimitiveValueMappings.h:
730         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
731         * css/CSSValueKeywords.in:
732         * rendering/RenderObject.cpp:
733         (WebCore::RenderObject::createObject):
734         * rendering/style/RenderStyleConstants.h:
735
736 2011-11-15  W. James MacLean  <wjmaclean@chromium.org>
737
738         [chromium] Move setVisibleRect() calls into calculateDrawTransformAndVisibility()
739         https://bugs.webkit.org/show_bug.cgi?id=72162
740
741         Reviewed by Kenneth Russell.
742
743         Refactoring of existing functionality, so uses existing tests.
744
745         * platform/graphics/chromium/LayerRendererChromium.cpp:
746         (WebCore::LayerRendererChromium::drawLayer):
747         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
748         (WebCore::paintContentsIfDirty):
749         (WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
750         (WebCore::CCLayerTreeHost::paintLayerContents):
751         * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
752         (WebCore::walkLayersAndCalculateVisibleLayerRects):
753         (WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
754
755 2011-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
756
757         Unreviewed, rolling out r100340.
758         http://trac.webkit.org/changeset/100340
759         https://bugs.webkit.org/show_bug.cgi?id=72448
760
761         Caused assertion failure in Win dbg canary. (Requested by
762         pkasting on #webkit).
763
764         * platform/graphics/chromium/LayerRendererChromium.cpp:
765         (WebCore::LayerRendererChromium::LayerRendererChromium):
766         (WebCore::LayerRendererChromium::viewportChanged):
767         (WebCore::LayerRendererChromium::drawLayersInternal):
768         * platform/graphics/chromium/LayerRendererChromium.h:
769
770 2011-11-15  Julien Chaffraix  <jchaffraix@webkit.org>
771
772         Switch table indexing to unsigned
773         https://bugs.webkit.org/show_bug.cgi?id=72083
774
775         Reviewed by Darin Adler.
776
777         No expected change in behavior.
778
779         All of the code is now using unsigned for indexing!
780
781         * rendering/FixedTableLayout.cpp:
782         (WebCore::FixedTableLayout::layout):
783         * rendering/RenderTable.cpp:
784         (WebCore::RenderTable::colElement):
785         (WebCore::RenderTable::cellAbove):
786         * rendering/RenderTableSection.cpp:
787         (WebCore::RenderTableSection::splitColumn):
788         Added some ASSERTs to make sure we don't underflow. Looking at how
789         the different variables are populated, they should not be reached.
790
791         * rendering/RenderTableCell.cpp:
792         (WebCore::RenderTableCell::colSpan):
793         (WebCore::RenderTableCell::rowSpan):
794         Those 2 functions promotes HTMLTableCellElement's int to unsigned
795         which should be fine as we make sure their are positive. Also HTML5
796         makes those 2 fields "unsigned long" which goes in the same direction.
797
798         * rendering/AutoTableLayout.cpp:
799         (WebCore::AutoTableLayout::layout):
800         * rendering/RenderTableSection.cpp:
801         (WebCore::RenderTableSection::nodeAtPoint):
802         Rewrote a couple of reverse iterating to be able to use unsigned
803         without overflowing.
804
805         * rendering/AutoTableLayout.cpp:
806         (WebCore::AutoTableLayout::recalcColumn):
807         (WebCore::AutoTableLayout::fullRecalc):
808         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
809         (WebCore::AutoTableLayout::insertSpanCell):
810         * rendering/AutoTableLayout.h:
811         * rendering/FixedTableLayout.cpp:
812         (WebCore::FixedTableLayout::calcWidthArray):
813         * rendering/RenderTable.cpp:
814         (WebCore::RenderTable::splitColumn):
815         (WebCore::RenderTable::appendColumn):
816         (WebCore::RenderTable::recalcSections):
817         * rendering/RenderTable.h:
818         (WebCore::RenderTable::getColumnPos):
819         (WebCore::RenderTable::spanOfEffCol):
820         (WebCore::RenderTable::effColToCol):
821         * rendering/RenderTableCell.cpp:
822         (WebCore::RenderTableCell::styleOrColLogicalWidth):
823         (WebCore::CollapsedBorders::nextBorder):
824         * rendering/RenderTableCell.h:
825         * rendering/RenderTableCol.cpp:
826         (WebCore::RenderTableCol::updateFromElement):
827         * rendering/RenderTableCol.h:
828         (WebCore::RenderTableCol::span):
829         (WebCore::RenderTableCol::setSpan):
830         * rendering/RenderTableSection.cpp:
831         (WebCore::RenderTableSection::addCell):
832         (WebCore::RenderTableSection::setCellLogicalWidths):
833         (WebCore::RenderTableSection::layoutRows):
834         (WebCore::RenderTableSection::calcOuterBorderBefore):
835         (WebCore::RenderTableSection::calcOuterBorderAfter):
836         (WebCore::RenderTableSection::calcOuterBorderStart):
837         (WebCore::RenderTableSection::calcOuterBorderEnd):
838         (WebCore::RenderTableSection::paintObject):
839         (WebCore::RenderTableSection::appendColumn):
840         * rendering/RenderTableSection.h:
841         (WebCore::RenderTableSection::cellAt):
842         (WebCore::RenderTableSection::primaryCellAt):
843         (WebCore::RenderTableSection::getBaseline):
844         Mechanical change int -> unsigned.
845
846 2011-11-15  Andy Estes  <aestes@apple.com>
847
848         Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
849         https://bugs.webkit.org/show_bug.cgi?id=72106
850
851         Reviewed by Anders Carlsson.
852
853         Add a class that encapsulates the logic of scheduling, enabling and
854         invalidating a run loop observer that fires before Core Animation's
855         commit observer. Clients can subclass LayerFlushSchedulerClient and
856         implement flushLayers(), which will be called by the observer.
857
858         * WebCore.exp.in:
859         * WebCore.xcodeproj/project.pbxproj:
860         * platform/graphics/ca/LayerFlushScheduler.cpp: Added.
861         (WebCore::LayerFlushScheduler::suspend): Suspend scheduling by
862         invalidating the run loop observer. Keep a count of calls to suspend()
863         in m_suspendCount.
864         (WebCore::LayerFlushScheduler::resume): Decrement m_suspendCount.
865         Install the run loop observer when it reaches 0.
866         * platform/graphics/ca/LayerFlushSchedulerClient.h: Added.
867         (WebCore::LayerFlushSchedulerClient::~LayerFlushSchedulerClient):
868         * platform/graphics/ca/LayerFlushScheduler.h: Added.
869         * platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp: Added.
870         (LayerFlushScheduler::LayerFlushScheduler):
871         (LayerFlushScheduler::~LayerFlushScheduler):
872         (LayerFlushScheduler::runLoopObserverCallback): Call flushLayers() on
873         the LayerFlushSchedulerClient.
874         (LayerFlushScheduler::schedule): Install the run loop observer.
875         (LayerFlushScheduler::invalidate): Remove the run loop
876         observer if it is installed.
877
878 2011-11-15  Adam Klein  <adamk@chromium.org>
879
880         [v8] Use throwError instead of compiling and running script in handleMaxRecursionDepthExceeded
881         https://bugs.webkit.org/show_bug.cgi?id=72432
882
883         Reviewed by Adam Barth.
884
885         * bindings/v8/V8Proxy.cpp:
886         (WebCore::handleMaxRecursionDepthExceeded):
887
888 2011-11-15  Vincent Scheib  <scheib@chromium.org>
889
890         Pointer Lock: Refactoring: PointerLock.idl: Dropping webkit prefix
891         https://bugs.webkit.org/show_bug.cgi?id=72431
892
893         Reviewed by Adam Barth.
894
895         * page/PointerLock.cpp:
896         (WebCore::PointerLock::lock):
897         (WebCore::PointerLock::unlock):
898         (WebCore::PointerLock::isLocked):
899         * page/PointerLock.h:
900         * page/PointerLock.idl:
901
902 2011-11-15  Nat Duca  <nduca@chromium.org>
903
904         [chromium] Fuse MainThread and CCThread
905         https://bugs.webkit.org/show_bug.cgi?id=72426
906
907         Reviewed by James Robinson.
908
909         * WebCore.gypi:
910         * platform/graphics/chromium/LayerRendererChromium.cpp:
911         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
912         (WebCore::CCLayerTreeHost::CCLayerTreeHost):
913         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
914         * platform/graphics/chromium/cc/CCMainThread.cpp: Removed.
915         * platform/graphics/chromium/cc/CCMainThread.h: Removed.
916         * platform/graphics/chromium/cc/CCMainThreadTask.h: Removed.
917         * platform/graphics/chromium/cc/CCProxy.cpp:
918         (WebCore::CCProxy::setMainThread):
919         (WebCore::CCProxy::mainThread):
920         (WebCore::CCProxy::setImplThread):
921         (WebCore::CCProxy::implThread):
922         (WebCore::CCProxy::isMainThread):
923         (WebCore::CCProxy::isImplThread):
924         (WebCore::CCProxy::~CCProxy):
925         * platform/graphics/chromium/cc/CCProxy.h:
926         * platform/graphics/chromium/cc/CCScopedThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCScopedMainThreadProxy.h.
927         (WebCore::CCScopedThreadProxy::create):
928         (WebCore::CCScopedThreadProxy::postTask):
929         (WebCore::CCScopedThreadProxy::shutdown):
930         (WebCore::CCScopedThreadProxy::CCScopedThreadProxy):
931         (WebCore::CCScopedThreadProxy::runTaskIfNotShutdown):
932         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
933         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
934         (WebCore::CCThreadProxy::CCThreadProxy):
935         (WebCore::CCThreadProxy::compositeAndReadback):
936         (WebCore::CCThreadProxy::finishAllRendering):
937         (WebCore::CCThreadProxy::initializeLayerRenderer):
938         (WebCore::CCThreadProxy::setNeedsAnimate):
939         (WebCore::CCThreadProxy::setNeedsCommit):
940         (WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
941         (WebCore::CCThreadProxy::setNeedsRedraw):
942         (WebCore::CCThreadProxy::setVisible):
943         (WebCore::CCThreadProxy::start):
944         (WebCore::CCThreadProxy::stop):
945         (WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
946         (WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnImplThread):
947         (WebCore::CCThreadProxy::beginFrameAndCommit):
948         (WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
949         (WebCore::CCThreadProxy::initializeImplOnImplThread):
950         * platform/graphics/chromium/cc/CCThreadProxy.h:
951
952 2011-11-15  Vincent Scheib  <scheib@chromium.org>
953
954         Pointer Lock: Refactor: MouseEvent.idl movementX/Y
955         https://bugs.webkit.org/show_bug.cgi?id=72427
956
957         - [Conditional...] vs #if defined
958         - Runtime enabled
959         - .movementX/Y prefixed with 'webkit'
960
961         Reviewed by Adam Barth.
962
963         No new tests.
964
965         * bindings/generic/RuntimeEnabledFeatures.h:
966         (WebCore::RuntimeEnabledFeatures::webkitMovementXEnabled):
967         (WebCore::RuntimeEnabledFeatures::webkitMovementYEnabled):
968         * dom/MouseEvent.idl:
969         * dom/MouseRelatedEvent.h:
970         (WebCore::MouseRelatedEvent::webkitMovementX):
971         (WebCore::MouseRelatedEvent::webkitMovementY):
972
973 2011-10-28  Ojan Vafai  <ojan@chromium.org>
974
975         implement flex-align for flex-flow: column
976         https://bugs.webkit.org/show_bug.cgi?id=70754
977
978         Reviewed by David Hyatt.
979
980         Tests: css3/flexbox/flex-align-column.html
981                css3/flexbox/line-wrapping.html
982
983         * rendering/RenderBox.cpp:
984         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
985         When flexitems are column, they should size to the intrinsic width unless flex-flow is stretch.
986
987         * rendering/RenderFlexibleBox.cpp:
988         (WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
989         This was just using the wrong, non-flow-aware method.
990
991 2011-11-15  Jochen Eisinger  <jochen@chromium.org>
992
993         Rename ReferrerPolicy to clarify its meaning
994         https://bugs.webkit.org/show_bug.cgi?id=72420
995
996         Reviewed by Nate Chapin.
997
998         On the one hand, even if the ReferrerPolicy was set to SendReferrer, the
999         referrer wasn't necessarily send. On the other hand, I want to use the
1000         name ReferrerPolicy when implementing the meta referrer tag.
1001
1002         No change in behavior expected so no test.
1003
1004         * html/HTMLAnchorElement.cpp:
1005         (WebCore::HTMLAnchorElement::handleClick):
1006         (WebCore::handleLinkClick):
1007         * loader/FrameLoader.cpp:
1008         (WebCore::FrameLoader::changeLocation):
1009         (WebCore::FrameLoader::urlSelected):
1010         (WebCore::FrameLoader::loadFrameRequest):
1011         * loader/FrameLoader.h:
1012         * loader/FrameLoaderTypes.h:
1013         * loader/NavigationScheduler.cpp:
1014         (WebCore::ScheduledHistoryNavigation::fire):
1015         (WebCore::ScheduledFormSubmission::fire):
1016         * page/ContextMenuController.cpp:
1017         (WebCore::openNewWindow):
1018         (WebCore::ContextMenuController::contextMenuItemSelected):
1019         * WebCore.exp.in: updated.
1020
1021 2011-11-15  Adam Klein  <adamk@chromium.org>
1022
1023         Factor out V8Proxy's max recursion depth handling code
1024         https://bugs.webkit.org/show_bug.cgi?id=72422
1025
1026         Reviewed by Nate Chapin.
1027
1028         Previously, V8Proxy used slightly different code to handle stack limit
1029         violations depending on whether they occured in runScript or
1030         callFunction. As described in http://webkit.org/b/72063, I intend to
1031         expand the usage of m_recursion when calling into script. This patch
1032         is intended to unify the existing handling code, making it easier to
1033         move elsewhere without causing unintended side-effects.
1034
1035         No tests changed, as the only change in behavior is the string passed
1036         to RangeError in the runScript case, and it's not mentioned anywhere
1037         in the LayoutTests.
1038
1039         * bindings/v8/V8Proxy.cpp:
1040         (WebCore::handleMaxRecursionDepthExceeded):
1041         (WebCore::V8Proxy::runScript): Use callFunction's factored-out code.
1042         (WebCore::V8Proxy::callFunction): Simplify and factor out code into handleMaxRecursionDepthExceeded.
1043
1044 2011-11-15  Jessie Berlin  <jberlin@apple.com>
1045
1046         NSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.
1047         https://bugs.webkit.org/show_bug.cgi?id=72419
1048
1049         Reviewed by Adam Roben.
1050
1051         Adopt the copied NSURLRequest.
1052
1053         * platform/network/mac/ResourceRequestMac.mm:
1054         (WebCore::ResourceRequest::setStorageSession):
1055
1056 2011-11-15  John Bates  <jbates@google.com>
1057
1058         Page/layer flashes after GPU-accelerated CSS transition
1059         https://bugs.webkit.org/show_bug.cgi?id=72343
1060
1061         LayerRendererChromium was resizing the window to 1x1 at initialization.
1062         In some cases, there is no drawLayers before switching back to
1063         software rendering. This left the window resized to 1x1 and the
1064         following software paints would therefore not be visible. This change
1065         moves the reshape call into drawLayers so that it will only be called
1066         if rendering will occur.
1067
1068         Reviewed by James Robinson.
1069
1070         New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.
1071
1072         * platform/graphics/chromium/LayerRendererChromium.cpp:
1073         (WebCore::LayerRendererChromium::viewportChanged):
1074         (WebCore::LayerRendererChromium::doViewportChanged):
1075         (WebCore::LayerRendererChromium::drawLayersInternal):
1076         * platform/graphics/chromium/LayerRendererChromium.h:
1077
1078 2011-11-15  Julien Chaffraix  <jchaffraix@webkit.org>
1079
1080         Add the needed plumbing to parse display: -webkit-grid
1081         https://bugs.webkit.org/show_bug.cgi?id=72331
1082
1083         Reviewed by Tony Chang.
1084
1085         Test: fast/css-grid-layout/display-grid-set-get.html
1086
1087         Added parsing support for display: -webkit-grid. From a rendering perspective,
1088         the value is equivalent to display: none until we properly implement it.
1089
1090         * css/CSSParser.cpp:
1091         (WebCore::CSSParser::parseValue):
1092         * css/CSSPrimitiveValueMappings.h:
1093         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1094         * css/CSSValueKeywords.in:
1095         * rendering/style/RenderStyleConstants.h:
1096         Added the new CSS value and plumbed the parsing and style application of
1097         the new value.
1098
1099         * css/CSSPrimitiveValueMappings.h:
1100         (WebCore::CSSPrimitiveValue::operator EDisplay):
1101         Added an ASSERT here as I bumped into some non-trivial issues due to bug 72296.
1102         -wap-marquee was offsetting the new value and was wrongly casted by the CSSPrimitiveValueMapping
1103         logic outside the EDisplay range which would lead to crashes.
1104
1105         * rendering/RenderObject.cpp:
1106         (WebCore::RenderObject::createObject):
1107         Fixed the indentation to follow our coding rules.
1108
1109 2011-11-15  Vincent Scheib  <scheib@chromium.org>
1110
1111         Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
1112         https://bugs.webkit.org/show_bug.cgi?id=72315
1113
1114         Reviewed by Dimitri Glazkov.
1115
1116         * WebCore.gypi:
1117         * page/Navigator.cpp:
1118         (WebCore::Navigator::webkitPointer):
1119         * page/Navigator.h:
1120         * page/Navigator.idl:
1121         * page/PointerLock.cpp: Renamed from Source/WebCore/page/MouseLockable.cpp.
1122         (WebCore::PointerLock::PointerLock):
1123         (WebCore::PointerLock::~PointerLock):
1124         (WebCore::PointerLock::webkitLock):
1125         (WebCore::PointerLock::webkitUnlock):
1126         (WebCore::PointerLock::webkitIsLocked):
1127         * page/PointerLock.h: Renamed from Source/WebCore/page/MouseLockable.h.
1128         (WebCore::PointerLock::create):
1129         * page/PointerLock.idl: Renamed from Source/WebCore/page/MouseLockable.idl.
1130
1131 2011-10-28  Ojan Vafai  <ojan@chromium.org>
1132
1133         Overflow and relayout are broken in the new flexboxes
1134         https://bugs.webkit.org/show_bug.cgi?id=71161
1135
1136         Reviewed by David Hyatt.
1137
1138         Tests: css3/flexbox/auto-height-dynamic.html
1139                css3/flexbox/flex-item-child-overflow-expected.html
1140                css3/flexbox/flex-item-child-overflow.html
1141
1142         * rendering/RenderFlexibleBox.cpp:
1143         (WebCore::RenderFlexibleBox::layoutBlock):
1144         -Always set the logical height to 0 to start with to ensure we don't
1145         use the height from the previous layout when we are computing the
1146         intrinsic size of the flexbox.
1147         -Call computeOverflow after computeLogicalHeight so that flex-item's children's
1148         overflow is properly rendered.
1149
1150         (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
1151         -Now that we setLogicalHeight in layoutBlock, we no longer need to do it here.
1152         -Refactor flipping code. The behavior is the same, but the variable names are just
1153         more correct.
1154
1155 2011-10-28  Ojan Vafai  <ojan@chromium.org>
1156
1157         Overflow and relayout are broken in the new flexboxes
1158         https://bugs.webkit.org/show_bug.cgi?id=71161
1159
1160         Reviewed by David Hyatt.
1161
1162         Tests: css3/flexbox/auto-height-dynamic.html
1163                css3/flexbox/flex-item-child-overflow-expected.html
1164                css3/flexbox/flex-item-child-overflow.html
1165
1166         * rendering/RenderFlexibleBox.cpp:
1167         (WebCore::RenderFlexibleBox::layoutBlock):
1168         -Always set the logical height to 0 to start with to ensure we don't
1169         use the height from the previous layout when we are computing the
1170         intrinsic size of the flexbox.
1171         -Call computeOverflow after computeLogicalHeight so that flex-item's children's
1172         overflow is properly rendered.
1173
1174         (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
1175         -Now that we setLogicalHeight in layoutBlock, we no longer need to do it here.
1176         -Refactor flipping code. The behavior is the same, but the variable names are just
1177         more correct.
1178
1179 2011-11-15  Nate Chapin  <japhet@chromium.org>
1180
1181         CachedResourceRequest is now the only SubresourceLoaderClient
1182         Merge CachedResourceRequest into SubresourceLoader and delete
1183         the SubresourceLoaderClient interface. A few items were moved
1184         to CachedResource instead of SubresourceLoader.
1185         https://bugs.webkit.org/show_bug.cgi?id=71149
1186
1187         Reviewed by Adam Barth.
1188
1189         * CMakeLists.txt:
1190         * GNUmakefile.list.am:
1191         * WebCore.gypi:
1192         * WebCore.pro:
1193         * WebCore.vcproj/WebCore.vcproj:
1194         * WebCore.xcodeproj/project.pbxproj:
1195         * loader/ResourceLoadScheduler.cpp:
1196         * loader/ResourceLoadScheduler.h:
1197         * loader/ResourceLoader.cpp:
1198         * loader/SubresourceLoader.cpp:
1199         (WebCore::SubresourceLoader::SubresourceLoader):
1200         (WebCore::SubresourceLoader::create):
1201         (WebCore::SubresourceLoader::init): Do work that had previously been
1202             done in SubresourceLoader::create() after the constructor.
1203         (WebCore::SubresourceLoader::willSendRequest):
1204         (WebCore::SubresourceLoader::didSendData):
1205         (WebCore::SubresourceLoader::didReceiveResponse):
1206         (WebCore::SubresourceLoader::didReceiveData):
1207         (WebCore::SubresourceLoader::didReceiveCachedMetadata):
1208         (WebCore::SubresourceLoader::didFinishLoading):
1209         (WebCore::SubresourceLoader::didFail):
1210         (WebCore::SubresourceLoader::willCancel):
1211         (WebCore::SubresourceLoader::releaseResources): Do the cleanup work that was
1212             duplicated throughout the various terminal CachedResourceRequest callbacks.
1213         * loader/SubresourceLoader.h: Fix indentation style issues.
1214         * loader/SubresourceLoaderClient.h: Removed.
1215         * loader/cache/CachedImage.cpp:
1216         * loader/cache/CachedRawResource.cpp:
1217         * loader/cache/CachedResource.cpp:
1218         (WebCore::cachedResourceTypeToTargetType):
1219         (WebCore::CachedResource::load): Do the work that had been done in
1220             CachedResourceRequest::load().
1221         (WebCore::CachedResource::finish):
1222         (WebCore::CachedResource::setResponse):
1223         (WebCore::CachedResource::stopLoading):
1224         * loader/cache/CachedResource.h:
1225         (WebCore::CachedResource::canDelete):
1226         * loader/cache/CachedResourceLoader.cpp:
1227         * loader/cache/CachedResourceRequest.cpp: Removed.
1228         * loader/cache/CachedResourceRequest.h: Removed.
1229         * loader/cf/SubresourceLoaderCF.cpp:
1230         * loader/chromium/CachedResourceRequestChromium.cpp: Removed.
1231         * loader/chromium/SubresourceLoaderChromium.cpp:
1232
1233 2011-11-15  Anders Carlsson  <andersca@apple.com>
1234
1235         HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
1236         https://bugs.webkit.org/show_bug.cgi?id=72397
1237
1238         Reviewed by Dan Bernstein.
1239
1240         screenToWindow and windowToScreen already use root view coordinates everywhere, with the
1241         exception of Mac WebKit1 which doesn't even implement the functions.
1242
1243         * accessibility/mac/WebAccessibilityObjectWrapper.mm:
1244         (-[WebAccessibilityObjectWrapper position]):
1245         * loader/EmptyClients.h:
1246         * page/Chrome.cpp:
1247         (WebCore::Chrome::screenToRootView):
1248         (WebCore::Chrome::rootViewToScreen):
1249         * page/Chrome.h:
1250         * page/ChromeClient.h:
1251         * platform/HostWindow.h:
1252         * platform/ScrollView.cpp:
1253         (WebCore::ScrollView::contentsToScreen):
1254         (WebCore::ScrollView::screenToContents):
1255         * platform/chromium/PopupContainer.cpp:
1256         (WebCore::PopupContainer::layoutAndCalculateWidgetRect):
1257         (WebCore::PopupContainer::refresh):
1258
1259 2011-11-15  Jeff Timanus  <twiz@chromium.org>
1260
1261         Patch removing duplicated code in the setup of the DrawingBuffer used
1262         to host the back-buffer for WebGL contents.
1263         https://bugs.webkit.org/show_bug.cgi?id=72327
1264
1265         Reviewed by Julien Chaffraix.
1266
1267         * html/canvas/WebGLRenderingContext.cpp:
1268         (WebCore::WebGLRenderingContext::copyTexImage2D):
1269         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
1270         (WebCore::WebGLRenderingContext::readPixels):
1271
1272 2011-11-15  Eugene Nalimov  <enal@google.com>
1273
1274         Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
1275         https://bugs.webkit.org/show_bug.cgi?id=70421 
1276
1277         Reviewed by Adam Barth.
1278
1279         Problem demonstrated itself when HTMLAudioElement was changed to become active DOM object.
1280         Before that there were no DOM objects that simultaneously were nodes and active objects.
1281         DOM object could be held in one of 3 maps -- node map, active objects map, and all other
1282         objects map, and HTMLAudioElement should be in 2 maps simultaneously. When it was in the
1283         active DOM objects map only, its event listener could be garbage collected, because special
1284         code that groups listeners with wrappers could handle only wrappers for objects in the node
1285         map. If we put HTMLAudioElement into nodes map, it would not be active DOM node, and can be
1286         garbage collected prematurely itself (see https://bugs.webkit.org/show_bug.cgi?id=66878).
1287         Fix is to introduce 4th map -- active nodes map, and change the code accordingly.
1288
1289         Test: media/audio-garbage-collect.html
1290
1291         * bindings/scripts/CodeGeneratorV8.pm:
1292         (GenerateNamedConstructorCallback):
1293         (GetDomMapFunction):
1294         * bindings/v8/DOMDataStore.cpp:
1295         (WebCore::DOMDataStore::DOMDataStore):
1296         (WebCore::DOMDataStore::getDOMWrapperMap):
1297         (WebCore::DOMDataStore::weakNodeCallback):
1298         * bindings/v8/DOMDataStore.h:
1299         (WebCore::DOMDataStore::activeDomNodeMap):
1300         * bindings/v8/ScopedDOMDataStore.cpp:
1301         (WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
1302         (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
1303         * bindings/v8/StaticDOMDataStore.cpp:
1304         (WebCore::StaticDOMDataStore::StaticDOMDataStore):
1305         * bindings/v8/StaticDOMDataStore.h:
1306         * bindings/v8/V8DOMMap.cpp:
1307         (WebCore::getActiveDOMNodeMap):
1308         (WebCore::removeAllDOMObjects):
1309         (WebCore::visitActiveDOMNodes):
1310         * bindings/v8/V8DOMMap.h:
1311         * bindings/v8/V8DOMWrapper.cpp:
1312         (WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
1313         (WebCore::V8DOMWrapper::getWrapperSlow):
1314         * bindings/v8/V8GCController.cpp:
1315         (WebCore::GCPrologueSpecialCase):
1316         (WebCore::void):
1317         (WebCore::Node):
1318         (WebCore::GCPrologueVisitor::visitDOMWrapper):
1319         (WebCore::V8GCController::gcPrologue):
1320         (WebCore::GCEpilogueHelper::GCEpilogueSpecialCase):
1321         (WebCore::GCEpilogueVisitor::visitDOMWrapper):
1322         (WebCore::V8GCController::gcEpilogue):
1323         * dom/Node.h:
1324         (WebCore::Node::isActiveNode):
1325         * html/HTMLAudioElement.h:
1326         (WebCore::HTMLAudioElement::isActiveNode):
1327
1328 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1329
1330         Remove useless const modifier from KURL::init
1331         <http://webkit.org/b/72387>
1332
1333         Reviewed by Darin Adler.
1334
1335         * platform/KURL.cpp:
1336         (WebCore::KURL::init): Remove useless const.
1337
1338 2011-11-14  Anders Carlsson  <andersca@apple.com>
1339
1340         HostWindow invalidation functions should use root view coordinates
1341         https://bugs.webkit.org/show_bug.cgi?id=72338
1342
1343         Reviewed by Dan Bernstein.
1344
1345         Rename invalidateWindow to invalidateRootView, and invalidateContentsAndWindow
1346         to invalidateContentsAndRootView. Make sure that the rects passed to the renamed functions
1347         are in root view coordinates by changing contentsToWindow calls to contentsToRootView.
1348         
1349         In practice this doesn't matter because for all platforms except Mac WebKit1, root view coordinates
1350         and window coordinates are equivalent, and Mac WebKit1 doesn't use these invalidation functions.
1351
1352         * loader/EmptyClients.h:
1353         * page/Chrome.cpp:
1354         (WebCore::Chrome::invalidateRootView):
1355         (WebCore::Chrome::invalidateContentsAndRootView):
1356         * page/Chrome.h:
1357         * page/ChromeClient.h:
1358         * page/Frame.cpp:
1359         (WebCore::Frame::tiledBackingStorePaintEnd):
1360         * page/FrameView.cpp:
1361         (WebCore::FrameView::invalidateRect):
1362         (WebCore::FrameView::scrollContentsFastPath):
1363         * platform/HostWindow.h:
1364         * platform/ScrollView.cpp:
1365         (WebCore::ScrollView::rectToCopyOnScroll):
1366         (WebCore::ScrollView::scrollContents):
1367         (WebCore::ScrollView::wheelEvent):
1368         * platform/chromium/FramelessScrollView.cpp:
1369         (WebCore::FramelessScrollView::invalidateRect):
1370         * svg/graphics/SVGImage.cpp:
1371         (WebCore::SVGImageChromeClient::invalidateContentsAndRootView):
1372
1373 2011-11-15  Philip Rogers  <pdr@google.com>
1374
1375         Implement maxWidth for fillText and strokeText, fixing the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test.
1376         https://bugs.webkit.org/show_bug.cgi?id=61528
1377
1378         Reviewed by Stephen White.
1379
1380         Tests: fast/canvas/2d.text.draw.fill.maxWidth.gradient.html
1381                fast/canvas/2d.text.draw.fill.maxWidth.negative.html
1382                fast/canvas/2d.text.draw.fill.maxWidth.veryLarge.html
1383                fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html
1384
1385         * html/canvas/CanvasRenderingContext2D.cpp:
1386         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1387
1388 2011-11-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1389
1390         [GTK] Implement download support in WebKit2
1391         https://bugs.webkit.org/show_bug.cgi?id=72258
1392
1393         Reviewed by Martin Robinson.
1394
1395         Add common download errors to ErrorsGtk.
1396
1397         * platform/gtk/ErrorsGtk.cpp:
1398         (WebCore::downloadNetworkError):
1399         (WebCore::downloadCancelledByUserError):
1400         (WebCore::downloadDestinationError):
1401         * platform/gtk/ErrorsGtk.h:
1402
1403 2011-11-15  Cary Clark  <caryclark@google.com>
1404
1405         [chromium-mac] Enable vertical text using Skia
1406         https://bugs.webkit.org/show_bug.cgi?id=72137
1407
1408         Use Skia to draw vertical text. This is much
1409         faster and has higher fidelity than the old method
1410         of drawing text on a path.
1411
1412         The graphics context passed to Skia has been
1413         rotated 90 degrees but the character advances
1414         have not, so it is necessary to unrotate the canvas,
1415         and re-rotate the positions.
1416
1417         This generates correct output (or, at least,
1418         consistent with Chromium CG on Mac) for all vertical
1419         text tests, one of which is mentioned below.
1420         
1421         Reviewed by Stephen White.
1422
1423         Test: fast/writing-mode/text-orientation-basic.html
1424
1425         * platform/graphics/skia/FontSkia.cpp:
1426         (WebCore::setupPaint):
1427         (WebCore::Font::drawGlyphs):
1428
1429 2011-11-15  Philip Rogers  <pdr@google.com>
1430
1431         Fix SVG hit testing when padding is present
1432         https://bugs.webkit.org/show_bug.cgi?id=37325
1433
1434         Reviewed by Nikolas Zimmermann.
1435
1436         Test: svg/hittest/svg-padding.xhtml
1437
1438         * rendering/svg/RenderSVGRoot.cpp:
1439         (WebCore::RenderSVGRoot::nodeAtPoint):
1440
1441 2011-11-15  Pavel Feldman  <pfeldman@google.com>
1442
1443         Web Inspector: move generic code from DevTools.js into the WebCore.
1444         https://bugs.webkit.org/show_bug.cgi?id=72377
1445
1446         re-landing r100269.
1447
1448         Reviewed by Yury Semikhatsky.
1449
1450         * English.lproj/localizedStrings.js:
1451         * inspector/front-end/InspectorFrontendHostStub.js:
1452         (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
1453         * inspector/front-end/ProfilesPanel.js:
1454         * inspector/front-end/Resource.js:
1455         * inspector/front-end/Settings.js:
1456         * inspector/front-end/UIUtils.js:
1457         (WebInspector.setToolbarColors):
1458         (WebInspector.resetToolbarColors):
1459         * inspector/front-end/inspector.js:
1460
1461 2011-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1462
1463         Unreviewed, rolling out r100269.
1464         http://trac.webkit.org/changeset/100269
1465         https://bugs.webkit.org/show_bug.cgi?id=72383
1466
1467         "Broke dozens of tests due to exception in loadingFinished"
1468         (Requested by tonyg-cr on #webkit).
1469
1470         * English.lproj/localizedStrings.js:
1471         * inspector/front-end/InspectorFrontendHostStub.js:
1472         (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
1473         * inspector/front-end/ProfilesPanel.js:
1474         * inspector/front-end/Resource.js:
1475         * inspector/front-end/Settings.js:
1476         * inspector/front-end/UIUtils.js:
1477         * inspector/front-end/inspector.js:
1478
1479 2011-11-15  Alexander Pavlov  <apavlov@chromium.org>
1480
1481         font property does not show up as "shorthand" in inspector
1482         https://bugs.webkit.org/show_bug.cgi?id=15598
1483
1484         Reviewed by Nikolas Zimmermann.
1485
1486         The "font" CSS property is turned into a real shorthand, as its longhands used to float around
1487         in the resulting style declaration without any reference to their underlying "font" property.
1488
1489         Test: fast/css/font-shorthand.html
1490
1491         * css/CSSMutableStyleDeclaration.cpp:
1492         (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Extracted the "font" value building into fontValue().
1493         (WebCore::CSSMutableStyleDeclaration::appendFontLonghandValueIfExplicit): Added
1494         (WebCore::CSSMutableStyleDeclaration::fontValue): Build the "font" value from longhands.
1495         * css/CSSMutableStyleDeclaration.h:
1496         * css/CSSParser.cpp:
1497         (WebCore::CSSParser::addProperty): Added optional "implicit" parameter.
1498         (WebCore::CSSParser::parseFont): Build respective longhands instead of the shorthand "font" property.
1499         * css/CSSParser.h: Added optional "implicit" parameter to addProperty().
1500         * css/CSSPropertyLonghand.cpp:
1501         (WebCore::initShorthandMap): Added "font" shorthand map entry.
1502         * css/CSSStyleSelector.cpp:
1503         (WebCore::CSSStyleSelector::applyPropertyToStyle): Separated the property application from the instance setup.
1504         (WebCore::CSSStyleSelector::applyPropertyToCurrentStyle): Added.
1505         * css/CSSStyleSelector.h: Made updateFont() public.
1506         * css/FontValue.cpp:
1507         (WebCore::FontValue::customCssText): Made use of StringBuilder.
1508         * html/canvas/CanvasRenderingContext2D.cpp:
1509         (WebCore::CanvasRenderingContext2D::setFont): Apply "font" longhands rather than the (non-existent) "font" property.
1510         * inspector/front-end/StylesSidebarPane.js:
1511         (WebInspector.StylesSidebarPane.prototype._markUsedProperties): Removed a workaround for "font" not being a shorthand.
1512         * page/animation/AnimationBase.cpp:
1513         (WebCore::addShorthandProperties): Removed a workaround for "font" not being a shorthand.
1514
1515 2011-11-15  Pierre Rossi  <pierre.rossi@gmail.com>
1516
1517         [Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring.
1518         https://bugs.webkit.org/show_bug.cgi?id=72262
1519
1520         Reviewed by Antonio Gomes.
1521
1522         No new tests needed, this is purely cosmetic.
1523
1524         * platform/qt/RenderThemeQStyle.cpp:
1525         (WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
1526         * platform/qt/RenderThemeQStyle.h:
1527         * platform/qt/RenderThemeQt.cpp:
1528         (WebCore::RenderThemeQt::adjustMenuListButtonStyle): remove the call to resetBorderRadius()
1529         since the mobile theme actually didn't do this.
1530         * platform/qt/RenderThemeQtMobile.cpp:
1531         (WebCore::RenderThemeQtMobile::adjustMenuListStyle):
1532
1533 2011-11-15  Pavel Feldman  <pfeldman@google.com>
1534
1535         Web Inspector: move generic code from DevTools.js into the WebCore.
1536         https://bugs.webkit.org/show_bug.cgi?id=72377
1537
1538         This includes support for themed toolbar, remote debugging routines,
1539         removes a couple of obsolete overrides from the DevTools.js
1540
1541         Reviewed by Yury Semikhatsky.
1542
1543         * English.lproj/localizedStrings.js:
1544         * inspector/front-end/InspectorFrontendHostStub.js:
1545         (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
1546         * inspector/front-end/ProfilesPanel.js:
1547         * inspector/front-end/Resource.js:
1548         * inspector/front-end/Settings.js:
1549         * inspector/front-end/UIUtils.js:
1550         (WebInspector.setToolbarColors):
1551         (WebInspector.resetToolbarColors):
1552         * inspector/front-end/inspector.js:
1553
1554 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1555
1556         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1557
1558         Reviewed by Tor Arne Vestbø.
1559
1560         * Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
1561
1562 2011-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1563
1564         Unreviewed, rolling out r100213.
1565         http://trac.webkit.org/changeset/100213
1566         https://bugs.webkit.org/show_bug.cgi?id=72371
1567
1568         "Breaks test_shell_tests" (Requested by tonyg-cr on #webkit).
1569
1570         * page/SecurityOrigin.cpp:
1571         (WebCore::SecurityOrigin::SecurityOrigin):
1572         * platform/SchemeRegistry.cpp:
1573         (WebCore::schemesWithUniqueOrigins):
1574
1575 2011-11-15  Alpha Lam  <hclam@chromium.org>
1576
1577         [chromium] scroll deltas are cleared during commit to the main thread
1578         https://bugs.webkit.org/show_bug.cgi?id=71916
1579
1580         Reviewed by James Robinson.
1581
1582         Patch is covered by unit test.
1583
1584         Add a member m_sentScrollDelta to CCLayerImpl to keep track of the scroll delta being
1585         sent to the main thread during commit. This gives a simpler approach to keep tracking of a
1586         layer's scroll delta in impl thread.
1587
1588         * platform/graphics/chromium/LayerChromium.h:
1589         (WebCore::LayerChromium::sentScrollDelta):
1590         * platform/graphics/chromium/cc/CCLayerImpl.h:
1591         (WebCore::CCLayerImpl::sentScrollDelta):
1592         (WebCore::CCLayerImpl::setSentScrollDelta):
1593         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
1594         (WebCore::CCLayerTreeHostImpl::processScrollDeltas):
1595         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
1596
1597 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1598
1599         [Qt] REGRESSION(100123): It made inspector tests crash
1600         https://bugs.webkit.org/show_bug.cgi?id=72274
1601
1602         Reviewed by Tor Arne Vestbø.
1603
1604         * platform/qt/RenderThemeQStyle.h: Remove uninitialized and duplicated
1605         m_page member that should really come from RenderThemeQt.
1606
1607 2011-11-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1608
1609         Unreviewed. Fix build breaks when EFL port is built.
1610
1611         * CMakeLists.txt:
1612         * UseJSC.cmake:
1613
1614 2011-11-15  Noel Gordon  <noel.gordon@gmail.com>
1615
1616         Make ImageFrame member getAddr() public
1617         https://bugs.webkit.org/show_bug.cgi?id=72321
1618
1619         Reviewed by Adam Barth.
1620
1621         Make ImageFrame member getAddr() public to allow ImageFrame users access to the
1622         underlying frame pixels if needed. Image decoders, for example, could with care
1623         use this service to write decoded pixels direct to the ImageFrame pixel buffer,
1624         avoiding intermeadiate data copies from temporary decoded pixel row buffers and
1625         the decoding performance loss that that entails.
1626
1627         No new tests, refactoring only.
1628
1629         * platform/image-decoders/ImageDecoder.h:
1630         (WebCore::ImageFrame::getAddr):
1631
1632 2011-11-14  Alexander Pavlov  <apavlov@chromium.org>
1633
1634         Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
1635         https://bugs.webkit.org/show_bug.cgi?id=72261
1636
1637         Reviewed by Pavel Feldman.
1638
1639         Test: inspector/styles/svg-style.xhtml
1640
1641         * inspector/InspectorStyleSheet.cpp:
1642         (WebCore::InspectorStyleSheet::inlineStyleSheetText):
1643
1644 2011-11-15  Kent Tamura  <tkent@chromium.org>
1645
1646         [V8] Fix incorrect handling of JavaScript properties in DOMStringMap
1647         https://bugs.webkit.org/show_bug.cgi?id=53578
1648
1649         Reviewed by Adam Barth.
1650
1651         Follows a JSC behavior change by r96893.
1652
1653         * bindings/v8/custom/V8DOMStringMapCustom.cpp:
1654         (WebCore::V8DOMStringMap::namedPropertyGetter):
1655         Propagate to the JavaScript object if the DOMStringMap object
1656         doesn't have the requested item.
1657         (WebCore::V8DOMStringMap::namedPropertyDeleter): ditto.
1658         (WebCore::V8DOMStringMap::namedPropertySetter):
1659         Try to set a property to only a DOMStringMap object.
1660
1661 2011-11-14  Pavel Feldman  <pfeldman@google.com>
1662
1663         Web Inspector: Command line $x fails for 3 of 4 types of XPath query
1664         https://bugs.webkit.org/show_bug.cgi?id=72276
1665
1666         Reviewed by Timothy Hatcher.
1667
1668         Test: inspector/console/console-xpath.html
1669
1670         * inspector/InjectedScriptSource.js:
1671         (.):
1672
1673 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1674
1675         Fix the change log entry for r59190.
1676
1677         * ChangeLog-2010-05-24:
1678
1679 2011-11-14  Dmitry Lomov  <dslomov@google.com>
1680         
1681         [V8][Chromium]Serialize dense arrays densly
1682         https://bugs.webkit.org/show_bug.cgi?id=72198
1683         This patch ensures that:
1684         - Dense arrays are serialized densly, and not as name-value pairs
1685         - Sparse arrays are allocated as sparse on deserialization.
1686         The criteria to choose whether to serialize densly or sparsely is the size
1687         of a resulting serialized stream.
1688
1689         Reviewed by David Levin.
1690
1691         Test: fast/dom/Window/window-postmessage-arrays.html
1692
1693         * bindings/v8/SerializedScriptValue.cpp:
1694         (WebCore::V8ObjectMap::Writer::writeDenseArray):
1695         (WebCore::V8ObjectMap::Writer::writeGenerateFreshSparseArray):
1696         (WebCore::V8ObjectMap::Writer::writeGenerateFreshDenseArray):
1697         (WebCore::V8ObjectMap::Serializer::writeDenseArray):
1698         (WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
1699         (WebCore::V8ObjectMap::Serializer::AbstractObjectState::serializeProperties):
1700         (WebCore::V8ObjectMap::Serializer::ObjectState::advance):
1701         (WebCore::V8ObjectMap::Serializer::DenseArrayState::DenseArrayState):
1702         (WebCore::V8ObjectMap::Serializer::DenseArrayState::advance):
1703         (WebCore::V8ObjectMap::Serializer::DenseArrayState::objectDone):
1704         (WebCore::V8ObjectMap::Serializer::SparseArrayState::SparseArrayState):
1705         (WebCore::V8ObjectMap::Serializer::SparseArrayState::advance):
1706         (WebCore::V8ObjectMap::Serializer::serializeDensely):
1707         (WebCore::V8ObjectMap::Serializer::startArrayState):
1708         (WebCore::V8ObjectMap::Serializer::startObjectState):
1709         (WebCore::V8ObjectMap::Serializer::doSerialize):
1710         (WebCore::V8ObjectMap::Reader::read):
1711         (WebCore::V8ObjectMap::Deserializer::newSparseArray):
1712         (WebCore::V8ObjectMap::Deserializer::completeSparseArray):
1713         (WebCore::V8ObjectMap::Deserializer::completeDenseArray):
1714
1715 2011-11-14  Alexandre Elias  <aelias@google.com>
1716
1717         [chromium] Fix scaleDelta zoom-out visibility rect bug
1718         https://bugs.webkit.org/show_bug.cgi?id=72208
1719
1720         Since the scroll is no longer applied at the top layer of the layer
1721         tree, the scaleDelta transformation needs to be moved down to the
1722         same level.
1723
1724         Also fix zoomAnimator to be applied the same way.  I removed zoom
1725         animator layout tests, as they aren't testing the actual impl-side
1726         codepath, and are hard to continue supporting -- we should cover zoom
1727         features with unit tests in the future.
1728
1729         Reviewed by James Robinson.
1730
1731         No new tests (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)
1732
1733         * platform/graphics/chromium/LayerChromium.h:
1734         (WebCore::LayerChromium::scaleDelta):
1735         * platform/graphics/chromium/LayerRendererChromium.cpp:
1736         (WebCore::LayerRendererChromium::drawLayersInternal):
1737         * platform/graphics/chromium/LayerRendererChromium.h:
1738         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
1739         (WebCore::CCLayerImpl::CCLayerImpl):
1740         (WebCore::CCLayerImpl::setScaleDelta):
1741         * platform/graphics/chromium/cc/CCLayerImpl.h:
1742         (WebCore::CCLayerImpl::scaleDelta):
1743         * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
1744         (WebCore::calculateDrawTransformsAndVisibilityInternal):
1745         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
1746         (WebCore::CCLayerTreeHostImpl::setScaleDelta):
1747         (WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):
1748
1749 2011-11-14  Chris Fleizach  <cfleizach@apple.com>
1750
1751         WebProcess crashes when trying to display your "uploaded videos" page on Facebook
1752         https://bugs.webkit.org/show_bug.cgi?id=72334
1753
1754         Reviewed by Beth Dakin.
1755
1756         Protect against documents without frames.
1757
1758         * accessibility/mac/WebAccessibilityObjectWrapper.mm:
1759         (-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
1760
1761 2011-11-14  Oliver Hunt  <oliver@apple.com>
1762
1763         More V8 build fixes.
1764
1765         * bindings/v8/custom/V8ArrayBufferViewCustom.h:
1766         (WebCore::setWebGLArrayHelper):
1767
1768 2011-11-14  Oliver Hunt  <oliver@apple.com>
1769
1770         Fix V8 build again.
1771
1772         * bindings/scripts/CodeGeneratorV8.pm:
1773         * bindings/scripts/test/V8/V8Float64Array.cpp:
1774         (WTF::Float64Array::neuterBinding):
1775
1776 2011-11-14  Oliver Hunt  <oliver@apple.com>
1777
1778         Fix V8 build.
1779
1780         * bindings/scripts/CodeGeneratorV8.pm:
1781         * bindings/scripts/test/V8/V8Float64Array.cpp:
1782         (WTF::Float64Array::neuterBinding):
1783
1784 2011-11-14  Oliver Hunt  <oliver@apple.com>
1785
1786         Start migrating typed array impl types to WTF
1787         https://bugs.webkit.org/show_bug.cgi?id=72336
1788
1789         Reviewed by Geoffrey Garen.
1790
1791         Move typed arrays from WebCore namespace to WTF, and
1792         start reducing dependencies on WebCore types.
1793
1794         * bindings/js/JSArrayBufferViewHelper.h:
1795         (WebCore::setWebGLArrayHelper):
1796         * bindings/scripts/CodeGeneratorJS.pm:
1797         (IsTypedArrayType):
1798         (AddClassForwardIfNeeded):
1799         (GenerateImplementation):
1800         * bindings/scripts/CodeGeneratorV8.pm:
1801         (IsTypedArrayType):
1802         * bindings/scripts/test/CPP/WebDOMFloat64Array.cpp: Added.
1803         (WebDOMFloat64Array::WebDOMFloat64Array):
1804         (WebDOMFloat64Array::impl):
1805         (toWebCore):
1806         (toWebKit):
1807         * bindings/scripts/test/CPP/WebDOMFloat64Array.h: Added.
1808         (WebDOMFloat64Array::~WebDOMFloat64Array):
1809         * bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp: Added.
1810         (WebKit::kit):
1811         (WebKit::core):
1812         (webkit_dom_float64array_finalize):
1813         (webkit_dom_float64array_set_property):
1814         (webkit_dom_float64array_get_property):
1815         (webkit_dom_float64array_constructed):
1816         (webkit_dom_float64array_class_init):
1817         (webkit_dom_float64array_init):
1818         (WebKit::wrapFloat64Array):
1819         * bindings/scripts/test/GObject/WebKitDOMFloat64Array.h: Added.
1820         * bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h: Added.
1821         * bindings/scripts/test/JS/JSFloat64Array.cpp: Added.
1822         (WebCore::JSFloat64ArrayConstructor::JSFloat64ArrayConstructor):
1823         (WebCore::JSFloat64ArrayConstructor::finishCreation):
1824         (WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
1825         (WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
1826         (WebCore::JSFloat64ArrayConstructor::getConstructData):
1827         (WebCore::getJSFloat64ArrayPrototypeTable):
1828         (WebCore::JSFloat64ArrayPrototype::self):
1829         (WebCore::getJSFloat64ArrayTable):
1830         (WebCore::JSFloat64Array::JSFloat64Array):
1831         (WebCore::JSFloat64Array::finishCreation):
1832         (WebCore::JSFloat64Array::createPrototype):
1833         (WebCore::JSFloat64Array::getOwnPropertySlot):
1834         (WebCore::JSFloat64Array::getOwnPropertyDescriptor):
1835         (WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
1836         (WebCore::jsFloat64ArrayConstructor):
1837         (WebCore::JSFloat64Array::put):
1838         (WebCore::JSFloat64Array::putByIndex):
1839         (WebCore::JSFloat64Array::getOwnPropertyNames):
1840         (WebCore::JSFloat64Array::getConstructor):
1841         (WebCore::JSFloat64Array::getByIndex):
1842         (WebCore::toFloat64Array):
1843         (WTF::Float64Array::neuterBinding):
1844         * bindings/scripts/test/JS/JSFloat64Array.h: Added.
1845         (WebCore::JSFloat64Array::create):
1846         (WebCore::JSFloat64Array::createStructure):
1847         (WebCore::JSFloat64Array::impl):
1848         (WebCore::JSFloat64ArrayPrototype::create):
1849         (WebCore::JSFloat64ArrayPrototype::createStructure):
1850         (WebCore::JSFloat64ArrayPrototype::JSFloat64ArrayPrototype):
1851         (WebCore::JSFloat64ArrayConstructor::create):
1852         (WebCore::JSFloat64ArrayConstructor::createStructure):
1853         * bindings/scripts/test/ObjC/DOMFloat64Array.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
1854         * bindings/scripts/test/ObjC/DOMFloat64Array.mm: Copied from Source/WebCore/html/canvas/Float32Array.cpp.
1855         (core):
1856         (kit):
1857         * bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h: Copied from Source/WebCore/html/canvas/Int16Array.cpp.
1858         * bindings/scripts/test/TestTypedArray.idl: Copied from Source/WebCore/html/canvas/Float64Array.cpp.
1859         * bindings/scripts/test/V8/V8Float64Array.cpp: Added.
1860         (WebCore::Float64ArrayInternal::V8_USE):
1861         (WebCore::ConfigureV8Float64ArrayTemplate):
1862         (WebCore::V8Float64Array::GetRawTemplate):
1863         (WebCore::V8Float64Array::GetTemplate):
1864         (WebCore::V8Float64Array::HasInstance):
1865         (WebCore::V8Float64Array::wrapSlow):
1866         (WTF::Float64Array::neuterBinding):
1867         (WebCore::V8Float64Array::derefObject):
1868         * bindings/scripts/test/V8/V8Float64Array.h: Added.
1869         (WebCore::V8Float64Array::toNative):
1870         (WebCore::V8Float64Array::existingWrapper):
1871         (WebCore::V8Float64Array::wrap):
1872         (WebCore::toV8):
1873         * fileapi/FileReader.h:
1874         * fileapi/FileReaderLoader.h:
1875         * fileapi/FileReaderSync.h:
1876         * fileapi/WebKitBlobBuilder.h:
1877         * html/HTMLMediaElement.h:
1878         * html/canvas/ArrayBuffer.cpp:
1879         * html/canvas/ArrayBuffer.h:
1880         * html/canvas/ArrayBufferView.cpp:
1881         (WTF::ArrayBufferView::setImpl):
1882         (WTF::ArrayBufferView::setRangeImpl):
1883         (WTF::ArrayBufferView::zeroRangeImpl):
1884         (WTF::ArrayBufferView::neuter):
1885         * html/canvas/ArrayBufferView.h:
1886         * html/canvas/Float32Array.cpp:
1887         * html/canvas/Float32Array.h:
1888         (WTF::Float32Array::set):
1889         * html/canvas/Float64Array.cpp:
1890         * html/canvas/Float64Array.h:
1891         (WTF::Float64Array::set):
1892         * html/canvas/Int16Array.cpp:
1893         * html/canvas/Int16Array.h:
1894         (WTF::Int16Array::set):
1895         * html/canvas/Int32Array.cpp:
1896         * html/canvas/Int32Array.h:
1897         (WTF::Int32Array::set):
1898         * html/canvas/Int8Array.cpp:
1899         * html/canvas/Int8Array.h:
1900         (WTF::Int8Array::set):
1901         * html/canvas/IntegralTypedArrayBase.h:
1902         * html/canvas/TypedArrayBase.h:
1903         (WTF::TypedArrayBase::set):
1904         (WTF::TypedArrayBase::setRange):
1905         (WTF::TypedArrayBase::zeroRange):
1906         * html/canvas/Uint16Array.cpp:
1907         * html/canvas/Uint16Array.h:
1908         (WTF::Uint16Array::set):
1909         * html/canvas/Uint32Array.cpp:
1910         * html/canvas/Uint32Array.h:
1911         (WTF::Uint32Array::set):
1912         * html/canvas/Uint8Array.cpp:
1913         * html/canvas/Uint8Array.h:
1914         (WTF::Uint8Array::set):
1915         * html/canvas/WebGLBuffer.h:
1916         * page/Crypto.h:
1917         * webaudio/AsyncAudioDecoder.h:
1918         * webaudio/AudioBuffer.cpp:
1919         (WebCore::AudioBuffer::AudioBuffer):
1920         (WebCore::AudioBuffer::zero):
1921         * webaudio/AudioContext.h:
1922         * webaudio/JavaScriptAudioNode.h:
1923         * webaudio/RealtimeAnalyser.h:
1924         * webaudio/RealtimeAnalyserNode.h:
1925         * webaudio/WaveShaperNode.h:
1926         * websockets/ThreadableWebSocketChannel.h:
1927         * websockets/WebSocket.h:
1928         * websockets/WebSocketChannel.h:
1929         * xml/XMLHttpRequest.h:
1930
1931 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1932
1933         Add --css-grid-layout to build-webkit and the build systems
1934         https://bugs.webkit.org/show_bug.cgi?id=72320
1935
1936         Reviewed by Ojan Vafai.
1937
1938         * Configurations/FeatureDefines.xcconfig:
1939
1940 2011-11-14  Daniel Bates  <dbates@rim.com>
1941
1942         Remove unnecessary #include SVGResourcesCache.h in SVGDocumentExtensions.h; use forward declaration
1943         https://bugs.webkit.org/show_bug.cgi?id=72335
1944
1945         Reviewed by Eric Seidel.
1946
1947         It's sufficient to forward declare SVGResourcesCache in SVGDocumentExtensions.h and #include SVGResourcesCache.h
1948         in SVGDocumentExtensions.cpp. This will reduce the number of files we need to re-compile after the file
1949         SVGResourcesCache.h has been modified. Currently we #include SVGResourcesCache.h in SVGDocumentExtensions.h.
1950
1951         * rendering/svg/RenderSVGBlock.cpp: Include SVGResourcesCache.h.
1952         * rendering/svg/RenderSVGContainer.cpp: Ditto.
1953         * rendering/svg/RenderSVGForeignObject.cpp: Ditto.
1954         * rendering/svg/RenderSVGImage.cpp: Ditto.
1955         * rendering/svg/RenderSVGInline.cpp: Ditto.
1956         * rendering/svg/RenderSVGModelObject.cpp: Ditto.
1957         * rendering/svg/RenderSVGPath.cpp: Ditto.
1958         * rendering/svg/RenderSVGResource.cpp: Ditto.
1959         * rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
1960         * rendering/svg/RenderSVGResourceContainer.cpp: Ditto.
1961         * rendering/svg/RenderSVGRoot.cpp: Ditto.
1962         * rendering/svg/RenderSVGText.cpp: Ditto.
1963         * rendering/svg/SVGInlineTextBox.cpp: Ditto.
1964         * rendering/svg/SVGRenderSupport.cpp: Ditto.
1965         * svg/SVGDocumentExtensions.cpp: Ditto.
1966         * svg/SVGDocumentExtensions.h: Forward declare SVGResourcesCache.
1967
1968 2011-11-14  Rafael Weinstein  <rafaelw@chromium.org>
1969
1970         [MutationObservers] Add histogram collection for usage of DOM Mutation Events
1971         https://bugs.webkit.org/show_bug.cgi?id=72316
1972
1973         Reviewed by Ryosuke Niwa.
1974
1975         This patch adds six calls in ~Document() which simply pipe-out to the embedder
1976         the (already-collected) bits of whether varous DOM Mutation Events were registered
1977         on the document.
1978
1979         No tests needed. No functional changes.
1980
1981         * dom/Document.cpp:
1982         (WebCore::histogramMutationEventUsage):
1983         (WebCore::Document::~Document):
1984
1985 2011-11-14  Simon Fraser  <simon.fraser@apple.com>
1986
1987         div with webkit-transform + webkit-box-reflect disappears when switching tabs
1988         https://bugs.webkit.org/show_bug.cgi?id=53355
1989
1990         Reviewed by Dean Jackson.
1991
1992         Tickle Core Animation into updating the layer's content property when
1993         switching back to a tab which has composited reflections. This hack is
1994         needed becuase reflections involve sharing layer contents between layers.
1995
1996         * platform/graphics/mac/WebLayer.mm:
1997         (-[WebLayer actionForKey:]):
1998
1999 2011-11-14  Adam Barth  <abarth@webkit.org>
2000
2001         Unique origins shouldn't remember their scheme, host, or port
2002         https://bugs.webkit.org/show_bug.cgi?id=72308
2003
2004         Reviewed by Eric Seidel.
2005
2006         This patch contains the bulk (all?) of the behavior differences in this
2007         patch series.  Unique origins shouldn't remember their schemes.  Doing
2008         so causes some privileges (e.g., local access) to leak into unique
2009         origins.
2010
2011         * page/SecurityOrigin.cpp:
2012         (WebCore::SecurityOrigin::SecurityOrigin):
2013             - Explicitly clear out the protocol, host, and port for unique
2014               origins.  A future patch will refactor all this code to be more
2015               elegant.
2016         * platform/SchemeRegistry.cpp:
2017         (WebCore::schemesWithUniqueOrigins):
2018             - Merge "about" and "javascript" in with the general case now that
2019               we don't have a separate notion of an empty origin.
2020
2021 2011-11-14  Adam Barth  <abarth@webkit.org>
2022
2023         Don't special-case "data" URLs in drag-and-drop logic
2024         https://bugs.webkit.org/show_bug.cgi?id=72322
2025
2026         Reviewed by Eric Seidel.
2027
2028         See the bug for more details.
2029
2030         Test: editing/pasteboard/drag-drop-to-data-url.html
2031
2032         * page/SecurityOrigin.cpp:
2033         (WebCore::SecurityOrigin::canReceiveDragData):
2034
2035 2011-11-14  Adrienne Walker  <enne@google.com>
2036
2037         [chromium] Pipe compositor commit/swap up to WebWidgetClient
2038         https://bugs.webkit.org/show_bug.cgi?id=72041
2039
2040         Reviewed by Darin Fisher.
2041
2042         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2043         (WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
2044         (WebCore::CCLayerTreeHost::didCompleteSwapBuffers):
2045         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
2046         (WebCore::CCSingleThreadProxy::doComposite):
2047         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
2048         (WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
2049         (WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
2050         (WebCore::CCThreadProxy::didCommitAndDrawFrame):
2051         (WebCore::CCThreadProxy::didCompleteSwapBuffers):
2052         * platform/graphics/chromium/cc/CCThreadProxy.h:
2053
2054 2011-11-14  Tony Chang  <tony@chromium.org>
2055
2056         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
2057         https://bugs.webkit.org/show_bug.cgi?id=72196
2058
2059         Reviewed by Ojan Vafai.
2060
2061         * Configurations/FeatureDefines.xcconfig:
2062         * css/CSSComputedStyleDeclaration.cpp:
2063         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2064         * css/CSSFlexValue.cpp:
2065         * css/CSSFlexValue.h:
2066         * css/CSSParser.cpp:
2067         (WebCore::CSSParser::parseValue):
2068         (WebCore::CSSParser::parseFlex):
2069         * css/CSSPrimitiveValueMappings.h:
2070         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2071         * css/CSSProperty.cpp:
2072         (WebCore::CSSProperty::isInheritedProperty):
2073         * css/CSSPropertyNames.in:
2074         * css/CSSStyleApplyProperty.cpp:
2075         (WebCore::ApplyPropertyLength::applyValue):
2076         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2077         * css/CSSStyleSelector.cpp:
2078         (WebCore::CSSStyleSelector::applyProperty):
2079         * css/CSSValue.cpp:
2080         (WebCore::CSSValue::cssText):
2081         (WebCore::CSSValue::destroy):
2082         * css/CSSValue.h:
2083         * css/CSSValueKeywords.in:
2084         * rendering/RenderFlexibleBox.cpp:
2085         * rendering/RenderFlexibleBox.h:
2086         * rendering/RenderObject.cpp:
2087         (WebCore::RenderObject::createObject):
2088         * rendering/RenderObject.h:
2089         (WebCore::RenderObject::isFlexibleBoxIncludingDeprecated):
2090         * rendering/style/RenderStyle.cpp:
2091         (WebCore::RenderStyle::RenderStyle):
2092         (WebCore::RenderStyle::diff):
2093         * rendering/style/RenderStyle.h:
2094         * rendering/style/RenderStyleConstants.h:
2095         * rendering/style/StyleFlexibleBoxData.cpp:
2096         * rendering/style/StyleFlexibleBoxData.h:
2097         * rendering/style/StyleRareNonInheritedData.cpp:
2098         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2099         (WebCore::StyleRareNonInheritedData::operator==):
2100         * rendering/style/StyleRareNonInheritedData.h:
2101
2102 2011-11-14  Vincent Scheib  <scheib@chromium.org>
2103
2104         Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
2105         https://bugs.webkit.org/show_bug.cgi?id=72303
2106
2107         Reviewed by Darin Fisher.
2108
2109         * bindings/generic/RuntimeEnabledFeatures.cpp:
2110         * bindings/generic/RuntimeEnabledFeatures.h:
2111         (WebCore::RuntimeEnabledFeatures::webkitPointerLockEnabled):
2112         (WebCore::RuntimeEnabledFeatures::setWebkitPointerLockEnabled):
2113         (WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):
2114         * page/Settings.cpp:
2115         (WebCore::Settings::Settings):
2116         * page/Settings.h:
2117         (WebCore::Settings::setPointerLockEnabled):
2118         (WebCore::Settings::PointerLockEnabled):
2119
2120 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2121
2122         Unreviewed, rolling out r100176.
2123         http://trac.webkit.org/changeset/100176
2124         https://bugs.webkit.org/show_bug.cgi?id=72309
2125
2126         it broke the Mac builds (missing symbols) in a non-obvious way
2127         (Requested by jchaffraix on #webkit).
2128
2129         * CMakeLists.txt:
2130         * GNUmakefile.list.am:
2131         * Target.pri:
2132         * WebCore.gypi:
2133         * bindings/js/JSWebGLRenderingContextCustom.cpp:
2134         (WebCore::toJS):
2135         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2136         (WebCore::toV8Object):
2137         * html/canvas/WebGLExperimentalCompressedTextures.cpp: Removed.
2138         * html/canvas/WebGLExperimentalCompressedTextures.h: Removed.
2139         * html/canvas/WebGLExperimentalCompressedTextures.idl: Removed.
2140         * html/canvas/WebGLExtension.h:
2141         * html/canvas/WebGLRenderingContext.cpp:
2142         (WebCore::WebGLRenderingContext::getExtension):
2143         (WebCore::WebGLRenderingContext::getParameter):
2144         (WebCore::WebGLRenderingContext::getSupportedExtensions):
2145         * html/canvas/WebGLRenderingContext.h:
2146         * platform/graphics/Extensions3D.h:
2147         * platform/graphics/GraphicsContext3D.h:
2148         * platform/graphics/efl/GraphicsContext3DEfl.cpp:
2149         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
2150         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2151
2152 2011-11-14  Tony Chang  <tony@chromium.org>
2153
2154         remove -wap-marquee css propery value
2155         https://bugs.webkit.org/show_bug.cgi?id=72296
2156
2157         Reviewed by Adam Barth.
2158
2159         This css value is no longer used.
2160
2161         * css/CSSValueKeywords.in:
2162
2163 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2164
2165         Crash in RenderTableSection::splitColumn
2166         https://bugs.webkit.org/show_bug.cgi?id=70171
2167
2168         Reviewed by David Hyatt.
2169
2170         Tests: fast/table/crash-splitColumn-2.html
2171                fast/table/crash-splitColumn-3.html
2172                fast/table/crash-splitColumn.html
2173
2174         The old code would not take into account the fact that each RenderTableSection
2175         can set its m_needsCellRecalc flag independently of the rest.
2176
2177         This means that you cannot assume that you can always split or append columns to
2178         all the sections. Our approach is to skip sections needing cell recalc in several
2179         parts of the code as they will be properly reset to the table's representations
2180         during a cell recalc.
2181
2182         * rendering/RenderTable.cpp:
2183         (WebCore::RenderTable::splitColumn):
2184         (WebCore::RenderTable::appendColumn):
2185         Skip sections needing cell recalc as they will be properly updated later.
2186
2187         * rendering/RenderTableSection.cpp:
2188         (WebCore::RenderTableSection::addCell):
2189         Ignore a section needing cell recalc as addCell will be called after sync'ing
2190         the internal column representation in recalcCells.
2191
2192         (WebCore::RenderTableSection::recalcCells):
2193         Clear the flag at the beginning of the function to activate the previous functions.
2194         Added a comment as to why this is fine.
2195
2196         (WebCore::RenderTableSection::appendColumn):
2197         Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
2198         of recalcCells().
2199
2200 2011-11-14  Adam Barth  <abarth@webkit.org>
2201
2202         Remove the concept of an empty SecurityOrigin
2203         https://bugs.webkit.org/show_bug.cgi?id=72287
2204
2205         Reviewed by Eric Seidel.
2206
2207         This concept is fragile and doesn't exist in the specs.  Previous
2208         patches have removed most of the code relying upon this function.  This
2209         patch removes a couple stragglers.
2210
2211         * page/DOMWindow.cpp:
2212         (WebCore::DOMWindow::postMessage):
2213             - This check should really be about unique origins because it
2214               doesn't make sense to target postMessages at unique origins, as
2215               explained in the comment.
2216         * page/SecurityOrigin.cpp:
2217         * page/SecurityOrigin.h:
2218
2219 2011-11-14  Adam Barth  <abarth@webkit.org>
2220
2221         SecurityContext::isSecureTransitionTo should not refer to empty security origins
2222         https://bugs.webkit.org/show_bug.cgi?id=72277
2223
2224         Reviewed by Eric Seidel.
2225
2226         Now that we're tracking the "failed to initialized SecurityOrigin"
2227         state explicitly, we should use that to determine whether we can make a
2228         secure transition.
2229
2230         * dom/SecurityContext.cpp:
2231         (WebCore::SecurityContext::isSecureTransitionTo):
2232
2233 2011-11-14  Vincent Scheib  <scheib@chromium.org>
2234
2235         Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
2236         https://bugs.webkit.org/show_bug.cgi?id=72286
2237
2238         Reviewed by Adam Barth.
2239
2240         * bindings/generic/RuntimeEnabledFeatures.cpp:
2241         * bindings/generic/RuntimeEnabledFeatures.h:
2242         * dom/MouseEvent.idl:
2243         * dom/MouseRelatedEvent.h:
2244         * page/MouseLockable.cpp:
2245         * page/MouseLockable.h:
2246         * page/MouseLockable.idl:
2247         * page/Navigator.cpp:
2248         * page/Navigator.h:
2249         * page/Navigator.idl:
2250         * page/Settings.cpp:
2251         (WebCore::Settings::Settings):
2252         * page/Settings.h:
2253
2254 2011-11-14  Anna Cavender  <annacc@chromium.org>
2255
2256         Remove TextTrackCueIndex and TextTrackCueSet.  No longer needed.
2257         https://bugs.webkit.org/show_bug.cgi?id=72216
2258
2259         Reviewed by Sam Weinig.
2260
2261         No new tests. No new functionality.
2262
2263         * CMakeLists.txt:
2264         * GNUmakefile.list.am:
2265         * Target.pri:
2266         * WebCore.gypi:
2267         * WebCore.xcodeproj/project.pbxproj:
2268         * html/TextTrackCueIndex.cpp: Removed.
2269         * html/TextTrackCueIndex.h: Removed.
2270
2271 2011-10-10  Robert Hogan  <robert@webkit.org>
2272
2273         CSS 2.1 failure: border-spacing-applies-to-015.htm
2274         https://bugs.webkit.org/show_bug.cgi?id=69773
2275
2276         Reviewed by David Hyatt.
2277
2278         The CSS test suite expects UAs to allow multiple captions per table.
2279         Replace m_caption with a Vector called m_captions.
2280
2281         * rendering/RenderTable.cpp:
2282         (WebCore::RenderTable::RenderTable):
2283         (WebCore::RenderTable::addChild):
2284         (WebCore::RenderTable::removeChild):
2285         (WebCore::RenderTable::adjustLogicalHeightForCaption):
2286         (WebCore::RenderTable::layout):
2287         (WebCore::RenderTable::addOverflowFromChildren):
2288         (WebCore::RenderTable::paintObject):
2289         (WebCore::RenderTable::subtractCaptionRect):
2290         (WebCore::RenderTable::computePreferredLogicalWidths):
2291         (WebCore::RenderTable::nextColElement):
2292         (WebCore::RenderTable::colElement):
2293         (WebCore::RenderTable::recalcCaption):
2294         (WebCore::RenderTable::recalcSections):
2295         (WebCore::RenderTable::overflowClipRect):
2296         (WebCore::RenderTable::nodeAtPoint):
2297         * rendering/RenderTable.h:
2298
2299 2011-11-14  Gregg Tavares  <gman@google.com>
2300
2301         Implement WEBGL_EXPERIMENTAL_compressed_textures WebGL extension
2302         https://bugs.webkit.org/show_bug.cgi?id=72086
2303
2304         Reviewed by Kenneth Russell.
2305
2306         No new tests. Will write final test once on hardware.
2307
2308         * CMakeLists.txt:
2309         * GNUmakefile.list.am:
2310         * WebCore.gypi:
2311         * WebCore.pro:
2312         * bindings/js/JSWebGLRenderingContextCustom.cpp:
2313         (WebCore::toJS):
2314         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2315         (WebCore::toV8Object):
2316         * html/canvas/WebGLExperimentalCompressedTextures.cpp: Added.
2317         (WebCore::WebGLExperimentalCompressedTextures::WebGLExperimentalCompressedTextures):
2318         (WebCore::WebGLExperimentalCompressedTextures::~WebGLExperimentalCompressedTextures):
2319         (WebCore::WebGLExperimentalCompressedTextures::getName):
2320         (WebCore::WebGLExperimentalCompressedTextures::create):
2321         (WebCore::WebGLExperimentalCompressedTextures::supported):
2322         (WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFormat):
2323         (WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFuncData):
2324         (WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexSubDimensions):
2325         (WebCore::WebGLExperimentalCompressedTextures::compressedTexImage2D):
2326         (WebCore::WebGLExperimentalCompressedTextures::compressedTexSubImage2D):
2327         (WebCore::WebGLExperimentalCompressedTextures::getCompressedTextureFormats):
2328         * html/canvas/WebGLExperimentalCompressedTextures.h: Added.
2329         * html/canvas/WebGLExperimentalCompressedTextures.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
2330         * html/canvas/WebGLExtension.h:
2331         * html/canvas/WebGLRenderingContext.cpp:
2332         (WebCore::WebGLRenderingContext::getExtension):
2333         (WebCore::WebGLRenderingContext::getParameter):
2334         (WebCore::WebGLRenderingContext::getSupportedExtensions):
2335         * html/canvas/WebGLRenderingContext.h:
2336         * platform/graphics/Extensions3D.h:
2337         * platform/graphics/GraphicsContext3D.h:
2338         * platform/graphics/efl/GraphicsContext3DEfl.cpp:
2339         (WebCore::GraphicsContext3D::compressedTexImage2D):
2340         (WebCore::GraphicsContext3D::compressedTexSubImage2D):
2341         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
2342         (WebCore::GraphicsContext3D::compressedTexImage2D):
2343         (WebCore::GraphicsContext3D::compressedTexSubImage2D):
2344         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2345         (WebCore::GraphicsContext3D::compressedTexImage2D):
2346         (WebCore::GraphicsContext3D::compressedTexSubImage2D):
2347
2348 2011-11-14  Michael Nordman  <michaeln@google.com>
2349
2350         Return more complete error and exception messages when a
2351         WebSQLDatabase function fails. Produce console logging
2352         for openDatabase() errors and vacuum errors. Add a lastErrorMessage
2353         accessor to the DatabaseSync interface.
2354         https://bugs.webkit.org/show_bug.cgi?id=71575
2355
2356         Reviewed by David Levin.
2357
2358         Yes, see LayoutTests/ChangeLog in this patch.
2359
2360         * platform/sql/SQLiteDatabase.cpp:
2361         (WebCore::SQLiteDatabase::SQLiteDatabase):
2362         (WebCore::SQLiteDatabase::open):
2363         (WebCore::SQLiteDatabase::close):
2364         (WebCore::SQLiteDatabase::lastError):
2365         (WebCore::SQLiteDatabase::lastErrorMsg):
2366         (WebCore::SQLiteDatabase:: runVacuumCommand):
2367         (WebCore::SQLiteDatabase:: runIncrementalVacuumCommand):
2368         Reflect errors in the open() method in lastError() and lastErrorMsg().
2369         Return an error codes for runVacuumCommand() and runIncrementalVacuumCommand().
2370
2371         * platform/sql/SQLiteDatabase.h:
2372         * storage/AbstractDatabase.cpp:
2373         (WebCore::formatErrorMessage):
2374         (WebCore::AbstractDatabase::performOpenAndVerify):
2375         (WebCore::AbstractDatabase::logErrorMessage):
2376         During openAndVerify, produce formatted error messages that include what was being done, the sqlite error code,
2377         and the sqlite error message. Add a helper to log message to the console.
2378
2379         * storage/AbstractDatabase.h:
2380         * storage/ChangeVersionWrapper.cpp:
2381         (WebCore::ChangeVersionWrapper::performPreflight):
2382         (WebCore::ChangeVersionWrapper::performPostflight):
2383         * storage/Database.cpp:
2384         (WebCore::Database::openDatabase):
2385         (WebCore::Database::openAndVerifyVersion):
2386         (WebCore::Database::performOpenAndVerify):
2387         * storage/Database.h:
2388         * storage/DatabaseSync.cpp:
2389         (WebCore::DatabaseSync::openDatabaseSync):
2390         (WebCore::DatabaseSync::changeVersion):
2391         (WebCore::DatabaseSync::runTransaction):
2392         * storage/DatabaseSync.h:
2393         (WebCore::DatabaseSync::lastErrorMessage):
2394         (WebCore::DatabaseSync::setLastErrorMessage):
2395         * storage/DatabaseSync.idl:
2396         Add a lastErrorMessage attribute so javascript callers can
2397         retrieve more detailed information about what went wrong.
2398
2399         * storage/DatabaseTask.cpp:
2400         (WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
2401         (WebCore::Database::DatabaseOpenTask::doPerformTask):
2402         * storage/DatabaseTask.h:
2403         (WebCore::Database::DatabaseOpenTask::create):
2404         Return an errorMessage in addition to the exception code.
2405
2406         * storage/SQLError.h:
2407         (WebCore::SQLError::create):
2408         Add helpers to produced formatted error messages.
2409
2410         * storage/SQLStatement.cpp:
2411         (WebCore::SQLStatement::execute):
2412         * storage/SQLStatementSync.cpp:
2413         (WebCore::SQLStatementSync::execute):
2414         * storage/SQLTransaction.cpp:
2415         (WebCore::SQLTransaction::openTransactionAndPreflight):
2416         (WebCore::SQLTransaction::postflightAndCommit):
2417         * storage/SQLTransactionSync.cpp:
2418         (WebCore::SQLTransactionSync::executeSQL):
2419         (WebCore::SQLTransactionSync::begin):
2420         (WebCore::SQLTransactionSync::execute):
2421         (WebCore::SQLTransactionSync::commit):
2422
2423 2011-11-14  Adam Barth  <abarth@webkit.org>
2424
2425         SecurityOrigin inheritance should depend on document URL, not on "emptiness" of the SecurityOrigin
2426         https://bugs.webkit.org/show_bug.cgi?id=72283
2427
2428         Reviewed by Sam Weinig.
2429
2430         This change aligns our implementation more closely with the spec.  I
2431         don't think this change has an observable effects, but it moves us
2432         closer to removing the concept of an empty security origin.
2433
2434         * dom/Document.cpp:
2435         (WebCore::shouldInheritSecurityOriginFromOwner):
2436         (WebCore::Document::initSecurityContext):
2437
2438 2011-11-14  Erik Arvidsson  <arv@chromium.org>
2439
2440         Remove getParameter from HTMLAnchorElement and Location
2441         https://bugs.webkit.org/show_bug.cgi?id=71966
2442
2443         Reviewed by Adam Barth.
2444
2445         * html/HTMLAnchorElement.cpp: Removed getParameter.
2446         * html/HTMLAnchorElement.h: Ditto.
2447         * html/HTMLAnchorElement.idl: Ditto.
2448         * page/Location.cpp: Ditto.
2449         * page/Location.h: Ditto.
2450         * page/Location.idl: Ditto.
2451
2452 2011-11-14  Erik Arvidsson  <arv@chromium.org>
2453
2454         Remove RequiresAllArguments
2455         https://bugs.webkit.org/show_bug.cgi?id=71503
2456
2457         Reviewed by Adam Barth.
2458
2459         This removes RequiresAllArguments from the idl files as well as from the code generators.
2460         For window.move/resize/scroll we now match IE and treat missing arguments as 0.
2461         For Clipboard we now match Gecko and IE and throw an exception when setData is called with too few arguments.
2462
2463         Test: fast/events/drag-and-drop-set-drag-data-arguments.html
2464
2465         * bindings/js/JSSVGLengthCustom.cpp:
2466         (WebCore::JSSVGLength::convertToSpecifiedUnits):
2467         * bindings/scripts/CodeGeneratorJS.pm:
2468         (GenerateArgumentsCountCheck): Remove RequiresAllArguments.
2469         * bindings/scripts/CodeGeneratorV8.pm:
2470         (GenerateArgumentsCountCheck): Ditto.
2471         * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
2472         * bindings/scripts/test/CPP/WebDOMTestObj.h:
2473         * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
2474         * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
2475         * bindings/scripts/test/JS/JSTestObj.cpp:
2476         * bindings/scripts/test/JS/JSTestObj.h:
2477         * bindings/scripts/test/ObjC/DOMTestObj.h:
2478         * bindings/scripts/test/ObjC/DOMTestObj.mm:
2479         * bindings/scripts/test/TestObj.idl:
2480         * bindings/scripts/test/V8/V8TestObj.cpp:
2481         (WebCore::ConfigureV8TestObjTemplate):
2482         * dom/Clipboard.idl: Remove [RequireAllArguments] from setData which actually means we now require all arguments and throw instead of silently fail.
2483         * page/DOMWindow.idl: Treat missing arguments as 0 which makes us match IE.
2484         * websockets/WebSocket.idl: Comment changes only.
2485
2486 2011-11-08  Jer Noble  <jer.noble@apple.com>
2487
2488         Implement MediaController.
2489         https://bugs.webkit.org/show_bug.cgi?id=71408
2490
2491         Reviewed by Eric Carlson.
2492
2493         Tests: media/media-controller-playback.html
2494                media/media-controller.html
2495
2496         Adds support for the MediaController DOM object, and the mediagroup and mediacontroller
2497         HTMLMediaElement attributes.
2498
2499         MediaController is an DOM object which synchronizes playback of multiple HTMLMediaElements. It can
2500         either be created by a page script and assigned to a HTMLMediaElement using the controller property,
2501         or all HTMLMediaElements with identical mediagroup attributes will have a MediaController assigned 
2502         automatically.
2503
2504         Add an abstract interface implemented by both MediaController and HTMLMediaElement.
2505         * html/MediaControllerInterface.h: Added.
2506         (WebCore::MediaControllerInterface::~MediaControllerInterface):
2507
2508         Add the MediaController object and IDL.
2509         * html/MediaController.cpp: Added.
2510         (mediaGroupToMediaControllerMap):
2511         (MediaController::mediaControllerForMediaGroup):
2512         (MediaController::create):
2513         (MediaController::MediaController):
2514         (MediaController::~MediaController):
2515         (MediaController::addMediaElement):
2516         (MediaController::removeMediaElement):
2517         (MediaController::containsMediaElement):
2518         (MediaController::buffered):
2519         (MediaController::seekable):
2520         (MediaController::played):
2521         (MediaController::duration):
2522         (MediaController::currentTime):
2523         (MediaController::setCurrentTime):
2524         (MediaController::play):
2525         (MediaController::pause):
2526         (MediaController::setDefaultPlaybackRate):
2527         (MediaController::setPlaybackRate):
2528         (MediaController::setVolume):
2529         (MediaController::setMuted):
2530         (MediaController::reportControllerState):
2531         (MediaController::updateReadyState):
2532         (MediaController::updatePlaybackState):
2533         (MediaController::updateMediaElements):
2534         (MediaController::scheduleEvent):
2535         (MediaController::asyncEventTimerFired):
2536         (MediaController::scriptExecutionContext):
2537         (MediaController::hasAudio):
2538         (MediaController::hasVideo):
2539         (MediaController::hasClosedCaptions):
2540         (MediaController::setClosedCaptionsVisible):
2541         (MediaController::supportsScanning):
2542         (MediaController::beginScrubbing):
2543         (MediaController::endScrubbing):
2544         (MediaController::canPlay):
2545         (MediaController::isLiveStream):
2546         (MediaController::hasSource):
2547         (MediaController::returnToRealtime):
2548         (MediaController::isBlocked):
2549         (MediaController::hasEnded):
2550         * html/MediaController.h: Added.
2551         (WebCore::MediaController::mediaGroup):
2552         (WebCore::MediaController::paused):
2553         (WebCore::MediaController::defaultPlaybackRate):
2554         (WebCore::MediaController::playbackRate):
2555         (WebCore::MediaController::volume):
2556         (WebCore::MediaController::muted):
2557         (WebCore::MediaController::readyState):
2558         (WebCore::MediaController::playbackState):
2559         (WebCore::MediaController::supportsFullscreen):
2560         (WebCore::MediaController::isFullscreen):
2561         (WebCore::MediaController::enterFullscreen):
2562         (WebCore::MediaController::closedCaptionsVisible):
2563         (WebCore::MediaController::refEventTarget):
2564         (WebCore::MediaController::derefEventTarget):
2565         (WebCore::MediaController::toMediaController):
2566         (WebCore::MediaController::eventTargetData):
2567         (WebCore::MediaController::ensureEventTargetData):
2568         * html/MediaController.idl: Added.
2569
2570         Add convenience functions to TimeRanges which can calculate intersections and
2571         unions between TimeRanges objects.
2572         * html/TimeRanges.cpp:
2573         (TimeRanges::copy):
2574         (TimeRanges::invert):
2575         (TimeRanges::intersectWith):
2576         (TimeRanges::unionWith):
2577         * html/TimeRanges.h:
2578
2579         Add MediaControllerConstructor to the Window object.
2580         * page/DOMWindow.idl:
2581
2582         Add the two new attribute names, mediagroup and controller.
2583         * html/HTMLAttributeNames.in:
2584
2585         Add support for the new attributes, and add overridden behavior when a media element
2586         has a current media controller:
2587         * html/HTMLMediaElement.cpp:
2588         (WebCore::HTMLMediaElement::~HTMLMediaElement):
2589         (WebCore::HTMLMediaElement::parseMappedAttribute):
2590         (WebCore::HTMLMediaElement::prepareForLoad):
2591         (WebCore::HTMLMediaElement::setReadyState):
2592         (WebCore::HTMLMediaElement::setCurrentTime):
2593         (WebCore::HTMLMediaElement::setPlaybackRate):
2594         (WebCore::HTMLMediaElement::playInternal):
2595         (WebCore::HTMLMediaElement::togglePlayState):
2596         (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
2597         (WebCore::HTMLMediaElement::seekable):
2598         (WebCore::HTMLMediaElement::potentiallyPlaying):
2599         (WebCore::HTMLMediaElement::endedPlayback):
2600         (WebCore::HTMLMediaElement::updateVolume):
2601         (WebCore::HTMLMediaElement::updatePlayState):
2602         (WebCore::HTMLMediaElement::userCancelledLoad):
2603         (WebCore::HTMLMediaElement::mediaGroup):
2604         (WebCore::HTMLMediaElement::setMediaGroup):
2605         (WebCore::HTMLMediaElement::controller):
2606         (WebCore::HTMLMediaElement::setController):
2607         (WebCore::HTMLMediaElement::updateMediaController):
2608         (WebCore::HTMLMediaElement::isBlockedOnMediaController):
2609         * html/HTMLMediaElement.h:
2610         (WebCore::HTMLMediaElement::hasSource):
2611         (WebCore::HTMLMediaElement::isLiveStream):
2612         * html/HTMLMediaElement.idl:
2613         * bindings/js/JSHTMLMediaElementCustom.cpp: Added.
2614         (WebCore::JSHTMLMediaElement::setMediaController):
2615
2616         Add convenience functions to store a mapping of media-elements-per-document to allow
2617         a quick lookup of media elements with the same media group within a given document:
2618         * html/HTMLMediaElement.cpp:
2619         (WebCore::documentToElementSetMap):
2620         (WebCore::addElementToDocumentMap):
2621         (WebCore::removeElementFromDocumentMap):
2622         
2623         Add a function "seekable" which returns a TimeRanges containing the seekable time ranges
2624         in a media element.  By default this is a single range of [0, maxTimeSeekable].
2625         * platform/graphics/MediaPlayer.cpp:
2626         (WebCore::MediaPlayer::seekable):
2627         * platform/graphics/MediaPlayer.h:
2628         * platform/graphics/MediaPlayerPrivate.h:
2629         (WebCore::MediaPlayerPrivateInterface::seekable):
2630
2631         Support functions to cast between MediaController and EventTarget.
2632         * bindings/js/JSEventTarget.cpp:
2633         (WebCore::toJS):
2634         * dom/EventTarget.cpp:
2635         (WebCore::EventTarget::toMediaController):
2636         * dom/EventTarget.h:
2637
2638         Fixed an infinite-recursion bug due to a collision between WTF::currentTime and
2639         ClockGeneric::currentTime:
2640         * platform/ClockGeneric.cpp:
2641         (ClockGeneric::ClockGeneric):
2642         (ClockGeneric::setCurrentTime):
2643         (ClockGeneric::currentTime):
2644         (ClockGeneric::setPlayRate):
2645         (ClockGeneric::start):
2646         (ClockGeneric::stop):
2647         (ClockGeneric::now):
2648         * platform/ClockGeneric.h:
2649
2650         Boilerplate to support creating the derived sources for MediaController and adding new sources
2651         to the project:
2652         * CMakeLists.txt:
2653         * DerivedSources.cpp:
2654         * DerivedSources.make:
2655         * GNUmakefile.list.am:
2656         * WebCore.gypi:
2657         * WebCore.xcodeproj/project.pbxproj:
2658
2659 2011-11-14  Florin Malita  <fmalita@google.com>
2660
2661         Multiple foreign objects not rendered
2662         https://bugs.webkit.org/show_bug.cgi?id=72151
2663
2664         Reviewed by Adam Barth.
2665
2666         SVG end tags need to be case-adjusted (just like their start counterparts).
2667
2668         Test: svg/foreignObject/multiple-foreign-objects.html
2669
2670         * html/parser/HTMLTreeBuilder.cpp:
2671         (WebCore::HTMLTreeBuilder::processEndTag):
2672
2673 2011-11-14  Mario Sanchez Prada  <msanchez@igalia.com>
2674
2675         Add support for the caretBrowsingEnabled preference in WebKit2
2676         https://bugs.webkit.org/show_bug.cgi?id=72266
2677
2678         Reviewed by Chris Fleizach.
2679
2680         * WebCore.exp.in: Exported settings for setCaretBrowsingEnabled.
2681
2682 2011-11-14  Jonathan Backer  <backer@chromium.org>
2683
2684         [chromium] Plumb through partial swap
2685         https://bugs.webkit.org/show_bug.cgi?id=72028
2686
2687         Reviewed by Kenneth Russell.
2688
2689         * platform/graphics/chromium/Extensions3DChromium.h:
2690         * platform/graphics/chromium/LayerRendererChromium.cpp:
2691         (WebCore::LayerRendererChromium::initialize):
2692         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2693         (WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
2694
2695 2011-11-14  Andrey Kosyakov  <caseq@chromium.org>
2696
2697         Web Inspector: expose iframe window to the onShown event handler of panels & sidebars
2698         https://bugs.webkit.org/show_bug.cgi?id=72268
2699
2700         Reviewed by Pavel Feldman.
2701
2702         - replace IFrameView with ExtensionView;
2703         - inherit both ExtensionPanel and ExtensionSidebarPane from ExtensionView in the API;
2704         - move Panel.{onShow|onHide} to ExtensionView, effectively disabling show/hide notifications for non-extension panels and enabling it for sidebar panes;
2705         - expose iframe's window object in the onShow event handler.
2706
2707         * WebCore.gypi:
2708         * WebCore.vcproj/WebCore.vcproj:
2709         * inspector/compile-front-end.sh:
2710         * inspector/front-end/ExtensionAPI.js:
2711         (injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
2712         (injectedExtensionAPI):
2713         (injectedExtensionAPI.PanelWithSidebarImpl):
2714         (injectedExtensionAPI.ExtensionPanelImpl):
2715         (injectedExtensionAPI.ExtensionSidebarPaneImpl):
2716         * inspector/front-end/ExtensionPanel.js:
2717         (WebInspector.ExtensionView):
2718         (WebInspector.ExtensionView.prototype.wasShown):
2719         (WebInspector.ExtensionView.prototype.willHide):
2720         (WebInspector.ExtensionView.prototype._onLoad):
2721         (WebInspector.ExtensionPanel):
2722         (WebInspector.ExtensionSidebarPane.prototype.setPage):
2723         * inspector/front-end/ExtensionServer.js:
2724         (WebInspector.ExtensionServer.prototype.notifyViewShown):
2725         (WebInspector.ExtensionServer.prototype.notifyViewHidden):
2726         (WebInspector.ExtensionServer.prototype._onCreatePanel):
2727         * inspector/front-end/IFrameView.js: Removed.
2728         * inspector/front-end/Panel.js:
2729         (WebInspector.Panel.prototype.wasShown):
2730         (WebInspector.Panel.prototype.willHide):
2731         * inspector/front-end/WebKit.qrc:
2732         * inspector/front-end/inspector.html:
2733
2734 2011-11-14  Yury Semikhatsky  <yurys@chromium.org>
2735
2736         Web Inspector: add 'Show function definition' context menu item for function values
2737         https://bugs.webkit.org/show_bug.cgi?id=72265
2738
2739         Allow navigating to JavaScript function definition using context menu.
2740
2741         Reviewed by Pavel Feldman.
2742
2743         * English.lproj/localizedStrings.js:
2744         * inspector/front-end/DebuggerPresentationModel.js:
2745         (WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):
2746         * inspector/front-end/ObjectPropertiesSection.js:
2747         (WebInspector.ObjectPropertyTreeElement.prototype.update):
2748         (WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired):
2749         (WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired.revealFunction):
2750         * inspector/front-end/ScriptsPanel.js:
2751         (WebInspector.ScriptsPanel.prototype.showFunctionDefinition):
2752         * inspector/front-end/inspector.js:
2753         (WebInspector.showPanelForAnchorNavigation):
2754
2755 2011-11-14  Pavel Feldman  <pfeldman@google.com>
2756
2757         Web Inspector: console's protocol payload does not have url and line properties.
2758         https://bugs.webkit.org/show_bug.cgi?id=72256
2759
2760         Reviewed by Yury Semikhatsky.
2761
2762         Test: inspector/console/console-url-and-line.html
2763
2764         * inspector/ConsoleMessage.cpp:
2765         (WebCore::ConsoleMessage::ConsoleMessage):
2766         * inspector/front-end/ConsoleMessage.js:
2767         (WebInspector.ConsoleMessageImpl):
2768
2769 2011-11-14  Pavel Feldman  <pfeldman@google.com>
2770
2771         Web Inspector: [regression r99960] null callback access.
2772         https://bugs.webkit.org/show_bug.cgi?id=72263
2773
2774         Reviewed by Yury Semikhatsky.
2775
2776         * inspector/CodeGeneratorInspector.py:
2777
2778 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2779
2780         [Qt] Unbreak the build on Mac OS X
2781
2782         QMacStyle is guarded by Q_WS_MAC, which is not the case for QPA. Until
2783         that's been fixed in Qt we have to use the same guards in WebKit, not
2784         Q_OS_MAC.
2785
2786         * platform/qt/RenderThemeQStyle.cpp:
2787         (WebCore::RenderThemeQStyle::RenderThemeQStyle):
2788         (WebCore::RenderThemeQStyle::adjustButtonStyle):
2789         (WebCore::RenderThemeQStyle::paintMenuList):
2790         (WebCore::RenderThemeQStyle::paintInnerSpinButton):
2791         * platform/qt/ScrollbarThemeQt.cpp:
2792         (WebCore::ScrollbarThemeQt::paint):
2793
2794 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
2795
2796         [Qt] Replace use of QApplication with QGuiApplication.
2797
2798         Reviewed by Tor Arne Vestbø.
2799
2800         Replace use of QApplication by QGuiApplication where applicable.
2801
2802         * platform/qt/RenderThemeQt.cpp:
2803         (WebCore::RenderThemeQt::RenderThemeQt):
2804         (WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
2805         (WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
2806         (WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
2807         (WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
2808         (WebCore::RenderThemeQt::platformFocusRingColor):
2809         (WebCore::RenderThemeQt::systemColor):
2810         (WebCore::RenderThemeQt::minimumMenuListSize):
2811         (WebCore::RenderThemeQt::getMediaControlForegroundColor):
2812         (WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
2813         (WebCore::RenderThemeQt::caretBlinkInterval):
2814
2815 2011-11-14  Jaehoon Jeong  <jh4u.jeong@samsung.com>
2816
2817         [CMAKE] Add the UseV8.cmake to WebCore.
2818         https://bugs.webkit.org/show_bug.cgi?id=72000
2819
2820         Reviewed by Daniel Bates.
2821
2822         Add the UseV8.cmake to WebCore to build bindings of V8 and
2823         generate JavaScript codes given IDL input.
2824
2825         * UseV8.cmake: Added.
2826
2827 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2828
2829         [Qt] Remove the QStyle dependency in Qt's mobile theme
2830         https://bugs.webkit.org/show_bug.cgi?id=67773
2831
2832         This refactoring splits up RenderThemeQt with two
2833         subclasses, a QStyle-backed one, and a Mobile version
2834         that uses the old mobile theme for now.
2835
2836         QStyle availability is detected at compile time, and
2837         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2838         environment variable.
2839
2840         Reviewed by Simon Hausmann.
2841
2842         Covered by the existing tests.
2843
2844         * Target.pri:
2845         * platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic
2846         now lives within RenderThemeQtMobile.
2847         * platform/qt/QtMobileWebStyle.h: Removed. Ditto.
2848         * platform/qt/RenderThemeQStyle.cpp: Added.
2849         (WebCore::initStyleOption):
2850         (WebCore::RenderThemeQStyle::getStylePainter):
2851         (WebCore::StylePainterQStyle::StylePainterQStyle):
2852         (WebCore::StylePainterQStyle::init):
2853         (WebCore::RenderThemeQStyle::create):
2854         (WebCore::RenderThemeQStyle::RenderThemeQStyle):
2855         (WebCore::RenderThemeQStyle::~RenderThemeQStyle):
2856         (WebCore::RenderThemeQStyle::fallbackStyle):
2857         (WebCore::RenderThemeQStyle::qStyle):
2858         (WebCore::RenderThemeQStyle::findFrameLineWidth):
2859         (WebCore::RenderThemeQStyle::inflateButtonRect):
2860         (WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
2861         (WebCore::RenderThemeQStyle::adjustButtonStyle):
2862         (WebCore::RenderThemeQStyle::setButtonPadding):
2863         (WebCore::RenderThemeQStyle::paintButton):
2864         (WebCore::RenderThemeQStyle::adjustTextFieldStyle):
2865         (WebCore::RenderThemeQStyle::paintTextField):
2866         (WebCore::RenderThemeQStyle::adjustTextAreaStyle):
2867         (WebCore::RenderThemeQStyle::paintTextArea):
2868         (WebCore::RenderThemeQStyle::setPopupPadding):
2869         (WebCore::RenderThemeQStyle::paintMenuList):
2870         (WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
2871         (WebCore::RenderThemeQStyle::paintMenuListButton):
2872         (WebCore::RenderThemeQStyle::animationDurationForProgressBar):
2873         (WebCore::RenderThemeQStyle::paintProgressBar):
2874         (WebCore::RenderThemeQStyle::paintSliderTrack):
2875         (WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
2876         (WebCore::RenderThemeQStyle::paintSliderThumb):
2877         (WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
2878         (WebCore::RenderThemeQStyle::paintSearchField):
2879         (WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
2880         (WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
2881         (WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
2882         (WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
2883         (WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
2884         (WebCore::RenderThemeQStyle::paintInnerSpinButton):
2885         (WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
2886         (WebCore::RenderThemeQStyle::adjustSliderThumbSize):
2887         * platform/qt/RenderThemeQStyle.h: Added.
2888         (WebCore::StylePainterQStyle::isValid):
2889         (WebCore::StylePainterQStyle::drawPrimitive):
2890         (WebCore::StylePainterQStyle::drawControl):
2891         (WebCore::StylePainterQStyle::drawComplexControl):
2892         * platform/qt/RenderThemeQt.cpp:
2893         (WebCore::RenderThemeQt::RenderThemeQt):
2894         (WebCore::RenderThemeQt::isControlStyled):
2895         (WebCore::RenderThemeQt::inflateButtonRect):
2896         (WebCore::RenderThemeQt::adjustRepaintRect):
2897         (WebCore::RenderThemeQt::minimumMenuListSize):
2898         (WebCore::RenderThemeQt::adjustTextFieldStyle):
2899         (WebCore::RenderThemeQt::adjustMenuListStyle):
2900         (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
2901         (WebCore::RenderThemeQt::adjustProgressBarStyle):
2902         (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
2903         (WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
2904         (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
2905         (WebCore::RenderThemeQt::paintMediaFullscreenButton):
2906         (WebCore::RenderThemeQt::paintMediaMuteButton):
2907         (WebCore::RenderThemeQt::paintMediaPlayButton):
2908         (WebCore::RenderThemeQt::paintMediaCurrentTime):
2909         (WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
2910         (WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
2911         (WebCore::RenderThemeQt::paintMediaSliderTrack):
2912         (WebCore::RenderThemeQt::paintMediaSliderThumb):
2913         (WebCore::RenderThemeQt::adjustSliderThumbSize):
2914         (WebCore::RenderThemeQt::caretBlinkInterval):
2915         (WebCore::RenderThemeQt::fileListNameForWidth):
2916         (WebCore::StylePainter::StylePainter):
2917         (WebCore::StylePainter::init):
2918         (WebCore::StylePainter::~StylePainter):
2919         * platform/qt/RenderThemeQt.h:
2920         (WebCore::RenderThemeQt::useMobileTheme):
2921         (WebCore::StylePainter::isValid):
2922         * platform/qt/RenderThemeQtMobile.cpp: Added.
2923         (WebCore::drawRectangularControlBackground):
2924         (WebCore::RenderThemeQtMobile::getStylePainter):
2925         (WebCore::StylePainterMobile::StylePainterMobile):
2926         (WebCore::StylePainterMobile::drawChecker):
2927         (WebCore::StylePainterMobile::findChecker):
2928         (WebCore::StylePainterMobile::drawRadio):
2929         (WebCore::StylePainterMobile::findRadio):
2930         (WebCore::StylePainterMobile::drawMultipleComboButton):
2931         (WebCore::StylePainterMobile::drawSimpleComboButton):
2932         (WebCore::StylePainterMobile::getButtonImageSize):
2933         (WebCore::StylePainterMobile::findComboButton):
2934         (WebCore::StylePainterMobile::drawLineEdit):
2935         (WebCore::StylePainterMobile::drawCheckBox):
2936         (WebCore::StylePainterMobile::drawRadioButton):
2937         (WebCore::StylePainterMobile::drawPushButton):
2938         (WebCore::StylePainterMobile::drawComboBox):
2939         (WebCore::RenderThemeQtMobile::create):
2940         (WebCore::RenderTheme::themeForPage):
2941         (WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
2942         (WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
2943         (WebCore::RenderThemeQtMobile::isControlStyled):
2944         (WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
2945         (WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
2946         (WebCore::RenderThemeQtMobile::adjustButtonStyle):
2947         (WebCore::RenderThemeQtMobile::setButtonPadding):
2948         (WebCore::RenderThemeQtMobile::paintButton):
2949         (WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
2950         (WebCore::RenderThemeQtMobile::paintTextField):
2951         (WebCore::RenderThemeQtMobile::adjustMenuListStyle):
2952         (WebCore::RenderThemeQtMobile::setPopupPadding):
2953         (WebCore::RenderThemeQtMobile::paintMenuList):
2954         (WebCore::RenderThemeQtMobile::paintMenuListButton):
2955         (WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
2956         (WebCore::RenderThemeQtMobile::paintProgressBar):
2957         (WebCore::RenderThemeQtMobile::paintSliderTrack):
2958         (WebCore::RenderThemeQtMobile::paintSliderThumb):
2959         (WebCore::RenderThemeQtMobile::checkMultiple):
2960         (WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
2961         (WebCore::RenderThemeQtMobile::adjustSliderThumbSize):
2962         * platform/qt/RenderThemeQtMobile.h: Added.
2963         * platform/qt/ScrollbarThemeQt.cpp:
2964         (WebCore::ScrollbarTheme::nativeTheme):
2965         (WebCore::ScrollbarThemeQt::paint):
2966         (WebCore::ScrollbarThemeQt::scrollbarThickness):
2967         (WebCore::ScrollbarThemeQt::paintScrollCorner):
2968
2969 2011-11-14  Adam Barth  <abarth@webkit.org>
2970
2971         SecurityContext should track whether the SecurityOrigin has been initialized
2972         https://bugs.webkit.org/show_bug.cgi?id=72250
2973
2974         Reviewed by Eric Seidel.
2975
2976         This patch is another step towards https://bugs.webkit.org/show_bug.cgi?id=71745.
2977
2978         One of the things we use "empty" SecurityOrigins for is detecting
2979         whether a Document's SecurityOrigin has been initialized.  In this
2980         patch, we track that state directly on SecurityContext (which is a base
2981         class of Document), moving us closer to removing the concept of an
2982         empty SecurityOrigin.
2983
2984         * dom/Document.cpp:
2985         (WebCore::Document::initSecurityContext):
2986         * dom/SecurityContext.cpp:
2987         (WebCore::SecurityContext::SecurityContext):
2988         (WebCore::SecurityContext::setSecurityOrigin):
2989         * dom/SecurityContext.h:
2990         (WebCore::SecurityContext::didFailToInitializeSecurityOrigin):
2991         (WebCore::SecurityContext::haveInitializedSecurityOrigin):
2992
2993 2011-11-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2994
2995         Unreviewed. Fix make distcheck build.
2996
2997         * GNUmakefile.list.am: Add missing files.
2998
2999 2011-11-14  Joseph Pecoraro  <pecoraro@apple.com>
3000
3001         Web Inspector: Give HTML ContextMenu a more Native look
3002         https://bugs.webkit.org/show_bug.cgi?id=72207
3003
3004         Reviewed by Pavel Feldman.
3005
3006         * inspector/front-end/SoftContextMenu.js:
3007         (.WebInspector.SoftContextMenu.prototype._createMenuItem):
3008         Give the checkmark a class name so that it can be styled more
3009         with CSS instead of with JavaScript.
3010
3011         * inspector/front-end/inspector.css:
3012         (.soft-context-menu): tweak the border and shadow.
3013         (.soft-context-menu-item): tweak the font size and positioning.
3014         (.soft-context-menu-separator): tweak the whitespace.
3015         (.soft-context-menu-item-mouse-over): solid blue for non-mac platforms.
3016         (body.platform-mac .soft-context-menu-item-mouse-over): gradient for mac platforms.
3017         (.soft-context-menu-item-checkmark): gray color normally.
3018         (.soft-context-menu-item-mouse-over .soft-context-menu-item-checkmark): white on hover.
3019
3020 2011-11-10  Yury Semikhatsky  <yurys@chromium.org>
3021
3022         Web Inspector: function remote objetct should provide access to function position in the script
3023         https://bugs.webkit.org/show_bug.cgi?id=71808
3024
3025         Added Debugger.getFunctionLocation command for resolving function location including
3026         start line, column and script id.
3027
3028         Reviewed by Pavel Feldman.
3029
3030         Test: inspector/debugger/function-location.html
3031
3032         * bindings/js/JSInjectedScriptHostCustom.cpp:
3033         (WebCore::JSInjectedScriptHost::functionLocation):
3034         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
3035         (WebCore::V8InjectedScriptHost::functionLocationCallback):
3036         * inspector/InjectedScript.cpp:
3037         (WebCore::InjectedScript::getFunctionLocation):
3038         * inspector/InjectedScript.h:
3039         * inspector/InjectedScriptHost.idl:
3040         * inspector/InjectedScriptSource.js:
3041         (.):
3042         * inspector/Inspector.json:
3043         * inspector/InspectorDebuggerAgent.cpp:
3044         (WebCore::InspectorDebuggerAgent::getFunctionLocation):
3045         * inspector/InspectorDebuggerAgent.h:
3046
3047 2011-11-14  Rakesh KN  <rakesh.kn@motorola.com>
3048
3049         Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list
3050         https://bugs.webkit.org/show_bug.cgi?id=70496
3051
3052         Reviewed by Kent Tamura.
3053
3054         Select Multiple options in a select element with a mouse drag when no. of options
3055         are less than the no. specified in size attribute.
3056         Other browsers(IE, Opera, Firefox) support this feature
3057
3058         Test: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html
3059
3060         * html/HTMLSelectElement.cpp:
3061         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3062         Handled mouse move event with Left button pressed. We select the options under mouse
3063         when mouse drag happens and the select element cannot autoscroll.
3064
3065 2011-11-14  Yury Semikhatsky  <yurys@chromium.org>
3066
3067         Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
3068         https://bugs.webkit.org/show_bug.cgi?id=72020
3069
3070         Collect information about dedicated workers even when inspector is closed. This
3071         way we can list all dedicated workers if the front-end opens later.
3072
3073         Reviewed by Pavel Feldman.
3074
3075         Test: http/tests/inspector-enabled/dedicated-workers-list.html
3076
3077         * inspector/InspectorInstrumentation.h:
3078         (WebCore::InspectorInstrumentation::didStartWorkerContext):
3079         * inspector/InspectorWorkerAgent.cpp:
3080         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
3081         (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
3082         (WebCore::InspectorWorkerAgent::setFrontend):
3083         (WebCore::InspectorWorkerAgent::restore):
3084         (WebCore::InspectorWorkerAgent::clearFrontend):
3085         (WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
3086         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
3087         (WebCore::InspectorWorkerAgent::workerContextTerminated):
3088         (WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
3089         (WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
3090         (WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
3091         * inspector/InspectorWorkerAgent.h:
3092
3093 2011-11-14  Zalan Bujtas  <zbujtas@gmail.com>
3094
3095         Build breaks with --no-javascript-debugger --no-inspector
3096         https://bugs.webkit.org/show_bug.cgi?id=72228
3097
3098         Reviewed by Simon Hausmann.
3099
3100         * workers/WorkerMessagingProxy.cpp:
3101         (WebCore::PostMessageToPageInspectorTask::performTask):
3102         (WebCore::WorkerMessagingProxy::connectToInspector):
3103         * workers/WorkerThread.cpp:
3104         (WebCore::WorkerThread::workerThread):
3105
3106 2011-11-14  Kentaro Hara  <haraken@chromium.org>
3107
3108         Remove all custom constructors of Events in V8
3109         https://bugs.webkit.org/show_bug.cgi?id=72074
3110
3111         Reviewed by Adam Barth.
3112
3113         V8 has [ConstructorTemplate=Event] IDL, which generates
3114         Event constructors. This patch removes all the custom constructors
3115         in V8EventConstructors.cpp and generates them using
3116         [ConstructorTemplate=Event] IDL.
3117
3118         Tests: fast/events/constructors/before-load-event-constructor.html
3119                fast/events/constructors/close-event-constructor.html
3120                fast/events/constructors/custom-event-constructor.html
3121                fast/events/constructors/error-event-constructor.html
3122                fast/events/constructors/event-constructors.html
3123                fast/events/constructors/hash-change-event-constructor.html
3124                fast/events/constructors/message-event-constructor.html
3125                fast/events/constructors/overflow-event-constructor.html
3126                fast/events/constructors/page-transition-event-constructor.html
3127                fast/events/constructors/pop-state-event-constructor.html
3128                fast/events/constructors/progress-event-constructor.html
3129                fast/events/constructors/track-event-constructor.html
3130                fast/events/constructors/webkit-animation-event-constructor.html
3131                fast/events/constructors/webkit-transition-event-constructor.html
3132
3133         * Target.pri: Removed V8EventConstructors.cpp.
3134         * WebCore.gypi: Ditto.
3135         * bindings/v8/custom/V8EventConstructors.cpp: Removed.
3136         * dom/BeforeLoadEvent.idl: Replaced [V8CustomConstructor] with [V8ConstructorTemplate=Event]. Added [InitializedByConstructor] IDL to attributes that can be initialized by the generated constructor.
3137         * dom/CustomEvent.idl: Ditto.
3138         * dom/ErrorEvent.idl: Ditto.
3139         * dom/HashChangeEvent.idl: Ditto.
3140         * dom/MessageEvent.idl: Ditto.
3141         * dom/OverflowEvent.idl: Ditto.
3142         * dom/PageTransitionEvent.idl: Ditto.
3143         * dom/PopStateEvent.idl: Ditto.
3144         * dom/ProgressEvent.idl: Ditto.
3145         * dom/WebKitAnimationEvent.idl: Ditto.
3146         * dom/WebKitTransitionEvent.idl: Ditto.
3147         * html/track/TrackEvent.idl: Ditto.
3148         * websockets/CloseEvent.idl: Ditto.
3149
3150 2011-11-13  Patrick Gansterer  <paroga@webkit.org>
3151
3152         [WX] Make FontPlatformData::m_size private
3153         https://bugs.webkit.org/show_bug.cgi?id=72214
3154
3155         Reviewed by Andreas Kling.
3156
3157         Also change the order of member variables to match
3158         the order in the constructor to fix many warnings.
3159
3160         * platform/graphics/wx/FontPlatformData.h:
3161
3162 2011-11-13  Adam Barth  <abarth@webkit.org>
3163
3164         Document::initSecurityOrigin should return earlier more often
3165         https://bugs.webkit.org/show_bug.cgi?id=72244
3166
3167         Reviewed by Eric Seidel.
3168
3169         This minor tweak was suggested by Darin to make the subsequent patches
3170         easier to read.
3171
3172         * dom/Document.cpp:
3173         (WebCore::Document::initSecurityContext):
3174
3175 2011-11-13  Adam Barth  <abarth@webkit.org>
3176
3177         SecurityPolicy should refer to isUnique rather than isEmpty
3178         https://bugs.webkit.org/show_bug.cgi?id=72242
3179
3180         Reviewed by Eric Seidel.
3181
3182         It doesn't make sense to tweak the security policy for unique origins
3183         because they're different every time.  Previously, this code checked
3184         for empty origins, which are technically a subset of unique origins.  I
3185         don't think it's possible to call this code in a way that can detect
3186         the difference, but we're eventually going to remove the isEmpty
3187         function.
3188
3189         * page/SecurityPolicy.cpp:
3190         (WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
3191         (WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
3192
3193 2011-11-13  Adam Barth  <abarth@webkit.org>
3194
3195         Move isSecureTransitionTo from SecurityOrigin to SecurityContext
3196         https://bugs.webkit.org/show_bug.cgi?id=72241
3197
3198         Reviewed by Eric Seidel.
3199
3200         This patch is a step towards breaking the patch for
3201         https://bugs.webkit.org/show_bug.cgi?id=71745 up into tiny,
3202         digestible pieces.
3203
3204         * dom/SecurityContext.cpp:
3205         (WebCore::SecurityContext::isSecureTransitionTo):
3206         * dom/SecurityContext.h:
3207         * loader/DocumentWriter.cpp:
3208         (WebCore::DocumentWriter::begin):
3209         * loader/FrameLoader.cpp:
3210         (WebCore::FrameLoader::stopLoading):
3211         * page/SecurityOrigin.cpp:
3212         * page/SecurityOrigin.h:
3213
3214 2011-11-13  Nat Duca  <nduca@chromium.org>
3215
3216         [chromium] LayerRendererChromium::initialize should fail when GaphicsContext3D::makeCurrent fails
3217         https://bugs.webkit.org/show_bug.cgi?id=72102
3218
3219         Reviewed by James Robinson.
3220
3221         * platform/graphics/chromium/LayerRendererChromium.cpp:
3222         (WebCore::LayerRendererChromium::initialize):
3223         (WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
3224         (WebCore::LayerRendererChromium::makeContextCurrent):
3225         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
3226         (WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
3227
3228 2011-11-11  Vincent Scheib  <scheib@chromium.org>
3229
3230         Mouse Lock: MouseEvent IDL
3231         https://bugs.webkit.org/show_bug.cgi?id=72158
3232
3233         Reviewed by Dimitri Glazkov.
3234
3235         Tests for movementX/Y pending mock mouse lock test infrastructure.
3236
3237         * dom/MouseEvent.idl:
3238         * dom/MouseRelatedEvent.h:
3239         (WebCore::MouseRelatedEvent::movementX):
3240         (WebCore::MouseRelatedEvent::movementY):
3241
3242 2011-11-13  Julien Chaffraix  <jchaffraix@webkit.org>
3243
3244         REGRESSION(99849): NULL-deref in updateLastMediaLine when parsing some media-queries
3245         https://bugs.webkit.org/show_bug.cgi?id=72222
3246
3247         Reviewed by Pavel Feldman.
3248
3249         Test: fast/media/update-media-query-css-parser.html
3250
3251         * css/CSSGrammar.y: Added a proper NULL-check.
3252
3253 2011-11-12  Vincent Scheib  <scheib@chromium.org>
3254
3255         Mouse Lock Navigator IDL
3256         https://bugs.webkit.org/show_bug.cgi?id=72150
3257
3258         Reviewed by Dimitri Glazkov.
3259
3260         Tests require mocking (similar to geolocation) that will be built after this.
3261
3262         * WebCore.gypi:
3263         * bindings/generic/RuntimeEnabledFeatures.h:
3264         (WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):
3265         * page/MouseLockable.cpp: Added.
3266         (WebCore::MouseLockable::MouseLockable):
3267         (WebCore::MouseLockable::~MouseLockable):
3268         (WebCore::MouseLockable::webkitLock):
3269         (WebCore::MouseLockable::webkitUnlock):
3270         (WebCore::MouseLockable::webkitIsLocked):
3271         * page/MouseLockable.h: Added.
3272         (WebCore::MouseLockable::create):
3273         * page/MouseLockable.idl: Added.
3274         * page/Navigator.cpp:
3275         (WebCore::Navigator::webkitPointer):
3276         * page/Navigator.h:
3277         * page/Navigator.idl:
3278
3279 2011-11-11  Andreas Kling  <kling@webkit.org>
3280
3281         Only HTMLAllCollection needs stateful named item traversal.
3282         <http://webkit.org/b/71987>
3283
3284         Reviewed by Antti Koivisto.
3285
3286         After the ability to call collections (excluding document.all) was removed
3287         in <http://webkit.org/b/67579>, chunks of code remained in HTMLCollection
3288         and HTMLFormCollection that was only used for this purpose.
3289
3290         Restrict the nextNamedItem() mechanism to HTMLAllCollection, since it's no
3291         longer used by any of the other collections.
3292
3293         * html/HTMLCollection.h:
3294
3295             Moved nextNamedItem() to HTMLAllCollection (and made it non-virtual.)
3296             Promoted itemAfter() and checkForNameMatch() to protected methods so
3297             they can be called from HTMLAllCollection.
3298
3299         * html/HTMLAllCollection.h:
3300         * html/HTMLAllCollection.cpp:
3301         (WebCore::HTMLAllCollection::HTMLAllCollection):
3302         (WebCore::HTMLAllCollection::nextNamedItem):
3303         * html/HTMLCollection.cpp:
3304         (WebCore::HTMLCollection::HTMLCollection):
3305         (WebCore::HTMLCollection::namedItem):
3306         * html/HTMLFormCollection.cpp:
3307         (WebCore::HTMLFormCollection::namedItem):
3308         * html/HTMLFormCollection.h:
3309
3310 2011-11-13  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3311
3312         Update binding generator tests to use jsCast
3313         https://bugs.webkit.org/show_bug.cgi?id=72224
3314
3315         Reviewed by Geoffrey Garen.
3316
3317         Update the expected results for JS generator after r100006 added jsCast.
3318
3319         * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
3320         (WebCore::JSTestEventConstructor::getOwnPropertySlot):
3321         (WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):
3322
3323 2011-11-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3324
3325         Unreviewed, rolling out r100038.
3326         http://trac.webkit.org/changeset/100038
3327         https://bugs.webkit.org/show_bug.cgi?id=72225
3328
3329         It broke more than 500 layout tests on the Qt bots (Requested
3330         by Ossy_night on #webkit).
3331
3332         * platform/qt/ScrollbarThemeQt.h:
3333
3334 2011-11-12  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3335
3336         [Qt][Symbian] Remove support for WINSCW compiler
3337         https://bugs.webkit.org/show_bug.cgi?id=70178
3338
3339         Reviewed by Chang Shu.
3340
3341         No new tests as there is no new functionality.
3342
3343         * config.h: Revert r57076.
3344         * loader/cache/CachedResourceHandle.h: Revert r49017 and r49556.
3345         (WebCore::CachedResourceHandle::CachedResourceHandle):
3346         * rendering/style/RenderStyle.h: Revert r52733.
3347         (compareEqual):
3348         * bindings/scripts/CodeGeneratorJS.pm: Revert r45553.
3349         * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
3350         * bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
3351         * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
3352         * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
3353         * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
3354         * bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
3355
3356 2011-11-12  Anna Cavender  <annacc@chromium.org>
3357
3358         Add WebVTT parsing layout tests.  Patch also includes creating a TextTrackCueList
3359         in TextTrack::cues() and observing WebVTT chronological cue order.
3360         https://bugs.webkit.org/show_bug.cgi?id=72215
3361
3362         Reviewed by Eric Carlson.
3363
3364         Tests: media/track/track-webvtt-tc000-empty.html
3365                media/track/track-webvtt-tc001-utf8.html
3366                media/track/track-webvtt-tc002-bom.html
3367                media/track/track-webvtt-tc003-newlines.html
3368                media/track/track-webvtt-tc004-magic-header.html
3369                media/track/track-webvtt-tc005-header-comment.html
3370                media/track/track-webvtt-tc006-cue-identifiers.html
3371                media/track/track-webvtt-tc007-cue-no-id.html
3372                media/track/track-webvtt-tc008-timings-no-hours.html
3373                media/track/track-webvtt-tc009-timings-hour.html
3374                media/track/track-webvtt-tc010-no-timings.html
3375                media/track/track-webvtt-tc011-blank-lines.html
3376                media/track/track-webvtt-tc012-out-of-order.html
3377                media/track/track-webvtt-tc013-settings.html
3378                media/track/track-webvtt-tc014-alignment.html
3379                media/track/track-webvtt-tc015-positioning.html
3380                media/track/track-webvtt-tc016-align-positioning.html
3381                media/track/track-webvtt-tc017-line-position.html
3382                media/track/track-webvtt-tc018-align-text-line-position.html
3383                media/track/track-webvtt-tc019-cue-size.html
3384                media/track/track-webvtt-tc020-cue-size-align.html
3385                media/track/track-webvtt-tc021-valign.html
3386                media/track/track-webvtt-tc022-entities.html
3387                media/track/track-webvtt-tc023-markup.html
3388                media/track/track-webvtt-tc024-timestamp.html
3389                media/track/track-webvtt-tc025-class-markup.html
3390                media/track/track-webvtt-tc026-voice.html
3391                media/track/track-webvtt-tc027-empty-cue.html
3392                media/track/track-webvtt-tc028-unsupported-markup.html
3393
3394         * html/TextTrack.cpp:
3395         (WebCore::TextTrack::~TextTrack): Only call client if m_cues has been allocated.
3396         (WebCore::TextTrack::cues): Create a TextTrackCueList if we don't already have one.
3397         * html/TextTrack.h: The cues() function can no longer be const.
3398         * html/TextTrackCueList.cpp:
3399         (WebCore::TextTrackCueList::add): Only add the cue if the startTime comes after
3400             all other startTimes in the list.
3401
3402 2011-11-12  Nat Duca  <nduca@chromium.org>
3403
3404         Fixes to GraphicsContext3D::makeCurrent on gtk and mac
3405         https://bugs.webkit.org/show_bug.cgi?id=72218
3406
3407         Unreviewed. Forgot to handle corner cases. Thanks Nico!
3408
3409         * platform/graphics/gtk/GraphicsContext3DGtk.cpp:
3410         (WebCore::GraphicsContext3D::makeContextCurrent):
3411         * platform/graphics/gtk/GraphicsContext3DPrivate.cpp:
3412         (WebCore::GraphicsContext3DPrivate::makeContextCurrent):
3413         * platform/graphics/mac/GraphicsContext3DMac.mm:
3414         (WebCore::GraphicsContext3D::makeContextCurrent):
3415
3416 2011-11-12  Patrick Gansterer  <paroga@webkit.org>
3417
3418         Add stub implementation for SVGResources::filter()
3419         https://bugs.webkit.org/show_bug.cgi?id=72211
3420
3421         Reviewed by Dirk Schulze.
3422
3423         Add an empty implementation, which only returns 0 for !ENABLE(FILTERS)
3424         to reduce the #if ENABLE(FILTERS) complexity a bit.
3425
3426         * rendering/svg/RenderSVGContainer.cpp:
3427         (WebCore::RenderSVGContainer::selfWillPaint):
3428         * rendering/svg/RenderSVGRoot.cpp:
3429         (WebCore::RenderSVGRoot::selfWillPaint):
3430         * rendering/svg/SVGRenderSupport.cpp:
3431         (WebCore::SVGRenderSupport::filtersForceContainerLayout):
3432         * rendering/svg/SVGResources.h:
3433         (WebCore::SVGResources::filter):
3434         * rendering/svg/SVGResourcesCache.cpp:
3435         (WebCore::SVGResourcesCache::clientLayoutChanged):
3436         (WebCore::SVGResourcesCache::clientUpdatedFromElement):
3437
3438 2011-11-12  Antti Koivisto  <antti@apple.com>
3439
3440         REGRESSION(r98542): Rendering error on Google maps
3441         https://bugs.webkit.org/show_bug.cgi?id=71996
3442
3443         Reviewed by Andreas Kling.
3444         
3445         r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.
3446         
3447         Test reduction by David Barr.
3448
3449         Test: fast/css/vertical-align-length-copy-bug.html
3450
3451         * rendering/style/StyleBoxData.cpp:
3452         (WebCore::StyleBoxData::StyleBoxData):
3453         (WebCore::StyleBoxData::operator==):
3454
3455 2011-11-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3456
3457         Unreviewed, rolling out r100013.
3458         http://trac.webkit.org/changeset/100013
3459         https://bugs.webkit.org/show_bug.cgi?id=72210
3460
3461         It breaks all mac builds (Requested by WildFox on #webkit).
3462
3463         * html/HTMLAnchorElement.idl:
3464         * html/HTMLAreaElement.idl:
3465         * html/HTMLButtonElement.idl:
3466         * html/HTMLElement.idl:
3467         * html/HTMLInputElement.idl:
3468         * html/HTMLLabelElement.idl:
3469         * html/HTMLLegendElement.idl:
3470         * html/HTMLTextAreaElement.idl:
3471
3472 2011-11-12  Nikolas Zimmermann  <nzimmermann@rim.com>
3473
3474         Finish SVGLengthContext conversion in svg/
3475         https://bugs.webkit.org/show_bug.cgi?id=72105
3476
3477         Reviewed by Antti Koivisto.
3478
3479         Make SVGLengthContext(const SVGElement*) explicit, adapt all remaining call sites.
3480         Now that this process is finished, SVGLengthContext can be shared across renders,
3481         so that its possible to override the length context in a single place. This will
3482         be done in future patches.
3483
3484         Doesn't affect any tests yet.
3485
3486         * bindings/js/JSSVGLengthCustom.cpp:
3487         (WebCore::JSSVGLength::value):
3488         (WebCore::JSSVGLength::setValue):
3489         (WebCore::JSSVGLength::convertToSpecifiedUnits):
3490