2011-04-29 Geoffrey Garen <ggaren@apple.com>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-29  Geoffrey Garen  <ggaren@apple.com>
2
3         Reviewed by Alexey Proskuryakov.
4
5         REGRESSION: r83938 abandons GC memory
6         https://bugs.webkit.org/show_bug.cgi?id=59604
7
8         This bug was caused by script and image elements waiting indefinitely
9         for their loads to finish.
10
11         * bindings/js/JSNodeCustom.cpp:
12         (WebCore::isReachableFromDOM): Don't test for the load event firing,
13         since the load event doesn't fire in cases of canceled or errored loads.
14         Instead, test hasPendingActivity().
15         
16         Don't do this test at all for script elements because script elements
17         can't load while outside the document. (fast/dom/script-element-gc.html
18         verifies that this is correct.)
19
20         * html/HTMLImageElement.cpp:
21         (WebCore::HTMLImageElement::hasPendingActivity):
22         * html/HTMLImageElement.h:
23         * loader/ImageLoader.cpp:
24         (WebCore::ImageEventSender::hasPendingEvents):
25         (WebCore::ImageLoader::hasPendingLoadEvent):
26         * loader/ImageLoader.h: Added API for finding out if an image element
27         has pending activity.
28
29         * loader/cache/CachedResource.cpp:
30         (WebCore::CachedResource::setRequest): All loads are supposed to end in
31         data(allDataReceived = true) or error(), but in the edge case of a
32         canceled load, all we get is a call to setRequest(0). Be sure to
33         record that we're no longer loading in that case, otherwise our element
34         will leak forever, waiting for its load to complete.
35
36 2011-04-29  Emil Eklund  <eae@chromium.org>
37
38         Reviewed by Tony Chang.
39
40         Setting outerHTML should merge text nodes
41         https://bugs.webkit.org/show_bug.cgi?id=52686
42
43         When setting outerHTML adjacent text nodes should be merged. This matches
44         the behavior of outerText and the IE implementation of outerHTML.       
45
46         Test: fast/dom/set-outer-html.html
47
48         * html/HTMLElement.cpp:
49         (WebCore::mergeWithNextTextNode): Move function to before setOuterHTML.
50         (WebCore::HTMLElement::setOuterHTML): Merge adjacent text nodes after replacing the element.
51
52 2011-04-29  Emil A Eklund  <eae@chromium.org>
53
54         Reviewed by Dimitri Glazkov.
55
56         Onchange on text fields has an incoherent behavior
57         https://bugs.webkit.org/show_bug.cgi?id=57330
58
59         * html/HTMLFormControlElement.cpp:
60         (WebCore::HTMLTextFormControlElement::insertedIntoDocument):
61         Initialize m_textAsOfLastFormControlChangeEvent to empty string rather
62         than null for empty fields.
63
64 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
65
66         [Qt] Unreviewed buildfix after r85343.
67
68         Enable strict OwnPtr for Qt
69         https://bugs.webkit.org/show_bug.cgi?id=59667
70
71         * plugins/mac/PluginViewMac.mm:
72         (WebCore::PluginView::platformStart):
73
74 2011-04-29  Jon Lee  <jonlee@apple.com>
75
76         Reviewed by mitzpettel.
77
78         REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
79         <rdar://problem/9327332>
80         https://bugs.webkit.org/show_bug.cgi?id=59721
81
82         Removing shouldClearSelectionWhenLosingWebPageFocus().  Reverting changelist 83814.
83
84         * WebCore.exp.in:
85         * editing/EditingBehavior.h:
86
87 2011-04-29  Abhishek Arya  <inferno@chromium.org>
88
89         Reviewed by Dave Hyatt.
90
91         Allow only first table caption and destroy the remaining ones.
92         https://bugs.webkit.org/show_bug.cgi?id=58249
93
94         Previously, we were only laying out the first table caption.
95         However Table::layout didn't mark the other ones as not needing
96         layout. So after table layout completes, table is marked as not
97         needing layout with its other table caption still needing layout.
98         This causes incorrect layout root calculations and set it to a
99         node which is already getting deleted.
100
101         Tests: fast/table/dynamic-caption-add-before-child.xhtml
102                fast/table/dynamic-caption-add-remove-before-child.xhtml
103                fast/table/multiple-captions-crash.xhtml
104                fast/table/multiple-captions-crash2.xhtml
105                fast/table/multiple-captions-display.xhtml
106
107         * rendering/RenderTable.cpp:
108         (WebCore::RenderTable::addChild): when new caption or a before
109         child caption is added, we need to explicitly trigger section
110         recalc or otherwise layout won't catch it.
111         (WebCore::RenderTable::removeChild): when child to be removed is
112         m_caption, make sure to trigger style recalc on the table.
113         (WebCore::RenderTable::recalcCaption): code to destroy captions
114         other than the first one.
115         (WebCore::RenderTable::recalcSections): call recalcCaption
116         helper. Store the next sibling early since child can get destroyed
117         in recalcCaption.
118         * rendering/RenderTable.h:
119
120 2011-04-29  David Kilzer  <ddkilzer@apple.com>
121
122         Remove WML
123         https://bugs.webkit.org/show_bug.cgi?id=59678
124
125         * DerivedSources.make: Removed $(WebCore)/wml path in VPATH.
126
127 2011-04-29  James Robinson  <jamesr@chromium.org>
128
129         Unreviewed, rolling out r85330.
130         http://trac.webkit.org/changeset/85330
131         https://bugs.webkit.org/show_bug.cgi?id=41311
132
133         Caused unexpected border rendering change on 500 tests on chromium linux.
134
135         * platform/graphics/skia/GraphicsContextSkia.cpp:
136         (WebCore::GraphicsContext::drawConvexPolygon):
137         (WebCore::GraphicsContext::clipConvexPolygon):
138
139 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
140
141         [Qt] Unreviewed buildfix after r85343.
142
143         Enable strict OwnPtr for Qt
144         https://bugs.webkit.org/show_bug.cgi?id=59667
145
146         * plugins/win/PluginViewWin.cpp:
147         (WebCore::PluginView::wndProc):
148         (WebCore::PluginView::snapshot):
149
150 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
151
152         Reviewed by Adam Barth.
153
154         Enable strict OwnPtr for Qt
155         https://bugs.webkit.org/show_bug.cgi?id=59667
156
157         * platform/graphics/qt/ImageBufferQt.cpp:
158         (WebCore::ImageBufferData::ImageBufferData):
159         (WebCore::ImageBuffer::ImageBuffer):
160         * platform/graphics/qt/ImageDecoderQt.cpp:
161         (WebCore::ImageDecoderQt::setData):
162         * platform/graphics/qt/ImageDecoderQt.h:
163         * platform/network/qt/QNetworkReplyHandler.cpp:
164         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
165         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
166
167 2011-04-29  Dean Jackson  <dino@apple.com>
168
169         Reviewed by Simon Fraser.
170
171         Add ENABLE macro for WebKitAnimation
172         https://bugs.webkit.org/show_bug.cgi?id=59729
173
174         Add new feature to toggle WebKit Animation API.
175
176         * Configurations/FeatureDefines.xcconfig:
177         * GNUmakefile.am:
178         * dom/Element.idl:
179         * features.pri:
180         * page/DOMWindow.idl:
181
182 2011-04-29  Dean Jackson  <dino@apple.com>
183
184         Reviewed by Simon Fraser.
185
186         https://bugs.webkit.org/show_bug.cgi?id=59149
187         (Regression) Existing animations are not replaced when filling.
188
189         Hardware animations that fill forwards were not being correctly
190         replaced when the animation was removed. The actual animation
191         logic was working correctly, but it wasn't deleting the
192         CoreAnimation animation from the PlatformLayer. The fix was
193         to explicitly call endAnimation when disconnecting the animation
194         from its RenderObject.
195
196         Test: animations/3d/replace-filling-transform.html
197
198         * page/animation/AnimationBase.h:
199         (WebCore::AnimationBase::clear): call endAnimation as the animation is cleared
200
201 2011-04-29  Abhishek Arya  <inferno@chromium.org>
202
203         Reviewed by Nikolas Zimmermann.
204
205         When svg inline text is getting destroyed, make sure to mark
206         its svg text ancestor as needing a positioning values update.
207         This helps to recalculate layout attributes and makes sure
208         that svg inline text is not used again.
209         https://bugs.webkit.org/show_bug.cgi?id=59161
210
211         Test: svg/text/inline-text-destroy-attributes-crash.xhtml
212
213         * rendering/svg/RenderSVGInlineText.cpp:
214         (WebCore::RenderSVGInlineText::destroy):
215         * rendering/svg/RenderSVGInlineText.h:
216
217 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
218
219         [wx] Unreviewed build fix. Fix wxMSW trunk builds by adding include.
220
221         * platform/graphics/wx/GraphicsContextWx.cpp:
222
223 2011-04-29  Mike Reed  <reed@google.com>
224
225         Reviewed by Ojan Vafai.
226
227         Skia: Need to implement GraphicsContext::clipConvexPolygon()
228         https://bugs.webkit.org/show_bug.cgi?id=41311
229
230         This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
231         as that shows other issues/question unrelated to clipping.
232         https://bugs.webkit.org/show_bug.cgi?id=41311
233
234         No new tests. covered by existing layout tests
235
236         * platform/graphics/skia/GraphicsContextSkia.cpp:
237         (WebCore::setPathFromConvexPoints):
238         (WebCore::GraphicsContext::drawConvexPolygon):
239         (WebCore::GraphicsContext::clipConvexPolygon):
240
241 2011-04-29  Mike Lawther  <mikelawther@chromium.org>
242
243         Reviewed by Ojan Vafai.
244
245         Fix IR->SR typo in enum value (and resulting style fails)
246         https://bugs.webkit.org/show_bug.cgi?id=59779
247
248         No functionality change, so no new tests
249
250         * css/CSSPrimitiveValueMappings.h:
251         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
252         (WebCore::CSSPrimitiveValue::operator EShapeRendering):
253
254 2011-04-29  Pavel Feldman  <pfeldman@google.com>
255
256         Reviewed by Yury Semikhatsky.
257
258         Web Inspector: CSS editing breaks when entering "color: rgb(1"
259         https://bugs.webkit.org/show_bug.cgi?id=59789
260
261         Tests: inspector/styles/styles-add-invalid-property.html
262                inspector/styles/styles-cancel-editing.html
263                inspector/styles/styles-commit-editing.html
264
265         * inspector/front-end/CSSStyleModel.js:
266         (WebInspector.CSSProperty.prototype.setText.callback):
267         (WebInspector.CSSProperty.prototype.setText):
268         * inspector/front-end/StylesSidebarPane.js:
269         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
270         (WebInspector.StylePropertyTreeElement.prototype):
271         (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
272         * inspector/front-end/inspector.js:
273         (WebInspector.startEditing.defaultFinishHandler):
274         (WebInspector.startEditing.keyDownEventListener):
275         (WebInspector.startEditing):
276
277 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
278
279         Reviewed by Simon Hausmann.
280
281         ENABLE(QT_BEARER) -> USE(QT_BEARER)
282
283         * WebCore.pri:
284         * WebCore.pro:
285         * features.pri:
286         * platform/network/NetworkStateNotifier.h:
287         * platform/network/qt/NetworkStateNotifierQt.cpp:
288
289 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
290
291         Reviewed by Simon Hausmann.
292
293         ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
294
295         * WebCore.pri:
296         * features.pri:
297
298 2011-04-29  Pavel Podivilov  <podivilov@chromium.org>
299
300         Reviewed by Pavel Feldman.
301
302         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
303         https://bugs.webkit.org/show_bug.cgi?id=59476
304
305         * inspector/front-end/DebuggerPresentationModel.js:
306         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
307         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
308         (WebInspector.PresentationBreakpoint.prototype.serialize):
309         * inspector/front-end/ScriptsPanel.js:
310         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
311         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
312         (WebInspector.ScriptsPanel.prototype.reset):
313
314 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
315
316         Reviewed by Yury Semikhatsky.
317
318         Web Inspector: include script end line:column in scriptParsed parameters.
319         https://bugs.webkit.org/show_bug.cgi?id=59717
320
321         * bindings/js/ScriptDebugServer.cpp:
322         (WebCore::ScriptDebugServer::dispatchDidParseSource):
323         * bindings/v8/DebuggerScript.js:
324         ():
325         * bindings/v8/ScriptDebugServer.cpp:
326         (WebCore::ScriptDebugServer::dispatchDidParseSource):
327         * inspector/Inspector.json:
328         * inspector/InspectorDebuggerAgent.cpp:
329         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
330         (WebCore::InspectorDebuggerAgent::didParseSource):
331         * inspector/InspectorDebuggerAgent.h:
332         (WebCore::InspectorDebuggerAgent::Script::Script):
333         * inspector/ScriptDebugListener.h:
334         * inspector/front-end/DebuggerModel.js:
335         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
336         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
337         (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
338         * inspector/front-end/Script.js:
339         (WebInspector.Script):
340
341 2011-04-28  Yury Semikhatsky  <yurys@chromium.org>
342
343         Reviewed by Pavel Feldman.
344
345         Web Inspector: [protocol] Evaluate should expose thrown exception value
346         https://bugs.webkit.org/show_bug.cgi?id=59000
347
348         Each evaluation command may have either thrown or returned result. This is indicated
349         by wasThrown property in the protocol.
350
351         * inspector/InjectedScript.cpp:
352         (WebCore::InjectedScript::evaluate):
353         (WebCore::InjectedScript::evaluateOn):
354         (WebCore::InjectedScript::evaluateOnCallFrame):
355         (WebCore::InjectedScript::getProperties):
356         (WebCore::InjectedScript::makeEvalCall):
357         * inspector/InjectedScript.h:
358         * inspector/InjectedScriptSource.js:
359         * inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to
360         the evaluation results.
361         * inspector/InspectorDebuggerAgent.cpp:
362         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
363         * inspector/InspectorDebuggerAgent.h:
364         * inspector/InspectorRuntimeAgent.cpp:
365         (WebCore::InspectorRuntimeAgent::evaluate):
366         (WebCore::InspectorRuntimeAgent::evaluateOn):
367         (WebCore::InspectorRuntimeAgent::getProperties):
368         * inspector/InspectorRuntimeAgent.h:
369         * inspector/front-end/ConsoleView.js:
370         (WebInspector.ConsoleView.prototype.completions.evaluated):
371         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
372         (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
373         (WebInspector.ConsoleView.prototype._enterKeyPressed):
374         (WebInspector.ConsoleCommandResult):
375         * inspector/front-end/DebuggerPresentationModel.js:
376         (WebInspector.PresenationCallFrame.prototype.evaluate):
377         * inspector/front-end/ElementsTreeOutline.js:
378         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
379         * inspector/front-end/ExtensionPanel.js:
380         (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
381         * inspector/front-end/ExtensionServer.js:
382         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
383         * inspector/front-end/ObjectPropertiesSection.js:
384         (WebInspector.ObjectPropertyTreeElement.prototype.update):
385         * inspector/front-end/PropertiesSidebarPane.js:
386         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
387         * inspector/front-end/SourceFrame.js:
388         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
389         (WebInspector.SourceFrame.prototype._showPopup):
390
391 2011-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
392
393         Unreviewed, rolling out r85315.
394         http://trac.webkit.org/changeset/85315
395         https://bugs.webkit.org/show_bug.cgi?id=59792
396
397         Broke script-formatter.html test (Requested by podivilov on
398         #webkit).
399
400         * inspector/front-end/DebuggerPresentationModel.js:
401         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
402         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint):
403         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
404         (WebInspector.PresentationBreakpoint.prototype.serialize):
405         * inspector/front-end/ScriptsPanel.js:
406         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
407         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
408         (WebInspector.ScriptsPanel.prototype.reset):
409
410 2011-04-29  Vsevolod Vlasov  <vsevik@chromium.org>
411
412         Reviewed by Pavel Feldman.
413
414         Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
415         https://bugs.webkit.org/show_bug.cgi?id=58794
416
417         Added ping requests to network panel.
418
419         Test: http/tests/inspector/network/ping.html
420
421         * English.lproj/localizedStrings.js:
422         * inspector/InspectorInstrumentation.cpp:
423         (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
424         * inspector/InspectorInstrumentation.h:
425         (WebCore::InspectorInstrumentation::continueAfterPingLoader):
426         * inspector/front-end/NetworkPanel.js:
427         (WebInspector.NetworkDataGridNode.prototype.refreshResource):
428         (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
429         (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
430         * inspector/front-end/Resource.js:
431         (WebInspector.Resource.prototype.get formParameters):
432         (WebInspector.Resource.prototype.requestContentType):
433         (WebInspector.Resource.prototype.isPingRequest):
434         * loader/PingLoader.cpp:
435         (WebCore::PingLoader::PingLoader):
436         * loader/PingLoader.h:
437
438 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
439
440         Reviewed by Pavel Feldman.
441
442         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
443         https://bugs.webkit.org/show_bug.cgi?id=59476
444
445         * inspector/front-end/DebuggerPresentationModel.js:
446         (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
447         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
448         (WebInspector.PresentationBreakpoint.prototype.serialize):
449         * inspector/front-end/ScriptsPanel.js:
450         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
451         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
452         (WebInspector.ScriptsPanel.prototype.reset):
453
454 2011-04-29  Pavel Feldman  <pfeldman@google.com>
455
456         Reviewed by Yury Semikhatsky.
457
458         Web Inspector: add "open link in new tab" action into the network and resources panels.
459         https://bugs.webkit.org/show_bug.cgi?id=59788
460
461         This change also distinguishes context menu items case between platforms.
462
463         * English.lproj/localizedStrings.js:
464         * inspector/front-end/ConsoleView.js:
465         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
466         * inspector/front-end/DOMBreakpointsSidebarPane.js:
467         (WebInspector.DOMBreakpointsSidebarPane):
468         * inspector/front-end/ElementsPanel.js:
469         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
470         (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
471         * inspector/front-end/ElementsTreeOutline.js:
472         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
473         (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
474         * inspector/front-end/NetworkPanel.js:
475         (WebInspector.NetworkPanel.prototype._contextMenu):
476         * inspector/front-end/ResourcesPanel.js:
477         (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
478         (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
479         (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
480         * inspector/front-end/Settings.js:
481         * inspector/front-end/SourceFrame.js:
482         (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
483         * inspector/front-end/TextViewer.js:
484         (WebInspector.TextViewer.prototype._contextMenu):
485         * inspector/front-end/inspector.js:
486         (WebInspector.openLinkExternallyLabel):
487         (WebInspector.openResource):
488         (WebInspector.useLowerCaseMenuTitles):
489
490 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
491
492         Reviewed by Dan Bernstein.
493
494         Mask placement on composited layer is incorrect sometimes
495         https://bugs.webkit.org/show_bug.cgi?id=59775
496         
497         The mask layer always has the same size as its owning GraphicsLayer,
498         so it needs to share the same offsetFromRenderer as well. This fixes
499         the offset at which the mask layer contents are painted in cases where
500         that offset is non-zero, for example when outline style bloats all of
501         the layer sizes.
502
503         Test: compositing/masks/layer-mask-placement.html
504
505         * rendering/RenderLayerBacking.cpp:
506         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
507
508 2011-04-28  Dan Bernstein  <mitz@apple.com>
509
510         Rubber-stamped by Mark Rowe.
511
512         Reverted r81319.
513
514         Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu
515
516         * page/NavigatorBase.cpp:
517
518 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
519
520         Reviewed by Dirk Schulze.
521
522         1px box-shadow looks ugly
523         https://bugs.webkit.org/show_bug.cgi?id=58100
524         and
525         ShadowBlur incorrectly handles zero-sized blur radius in one axis
526         https://bugs.webkit.org/show_bug.cgi?id=59710
527         
528         blurLayerImage() has issues at the edges if the blur radius
529         is one, so in that case bump the buffer size out by a pixel.
530         This results in a correct, symmetrical blur.
531         
532         Also fix an issue noticed during testing where a zero
533         height or width radius would still blur on that axis,
534         because we clamp the kernel size to a minimum of two.
535
536         Test: fast/box-shadow/single-pixel-shadow.html
537
538         * platform/graphics/ShadowBlur.h:
539         * platform/graphics/ShadowBlur.cpp:
540         (WebCore::ShadowBlur::blurLayerImage):
541         Skip horizontal or vertial passes if the radius on that axis is zero.
542         Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
543         clause to the end of the loop, since it only needs to execute once
544         after the first pass.        
545         (WebCore::ShadowBlur::blurredEdgeSize):
546         New method to compute the width of the blurred edge (radius + extra
547         pixel when necessary).
548         (WebCore::ShadowBlur::calculateLayerBoundingRect):
549         (WebCore::ShadowBlur::templateSize):
550         (WebCore::ShadowBlur::drawRectShadow):
551         (WebCore::ShadowBlur::drawInsetShadow):
552         (WebCore::ShadowBlur::drawInsetShadowWithTiling):
553         (WebCore::ShadowBlur::drawRectShadowWithTiling):
554         (WebCore::ShadowBlur::drawLayerPieces):
555         Use the result of blurredEdgeSize() rather than recomputing.
556
557 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
558
559         Reviewed by Beth Dakin.
560
561         CSS sibling selector (~) does not work with :target pseudo class
562         https://bugs.webkit.org/show_bug.cgi?id=26539
563
564         Allow style recalculation of forward siblings of elements with
565         forward positional rules.
566
567         Tests: fast/css/pseudo-target-indirect-sibling-001.html
568                fast/css/pseudo-target-indirect-sibling-002.html
569
570         * dom/Element.cpp:
571         (WebCore::Element::recalcStyle):
572
573 2011-04-28  Nat Duca  <nduca@chromium.org>
574
575         Reviewed by Kenneth Russell.
576
577         [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
578         https://bugs.webkit.org/show_bug.cgi?id=59626
579
580         * platform/graphics/chromium/Extensions3DChromium.h:
581         (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
582
583 2011-04-28  Steve Lacey  <sjl@chromium.org>
584
585         Reviewed by Eric Carlson.
586
587         Change chromium media controls to use absolute positioning until bug 59644 is fixed.
588         https://bugs.webkit.org/show_bug.cgi?id=59732
589
590         * css/mediaControlsChromium.css:
591         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
592         (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
593
594 2011-04-28  Luke Macpherson   <macpherson@chromium.org>
595
596         Reviewed by Eric Seidel.
597
598         Implement CSS border width and related properties in CSSStyleApplyProperty.
599         https://bugs.webkit.org/show_bug.cgi?id=59414
600
601         No new tests as no functionality added.
602
603         * css/CSSStyleApplyProperty.cpp:
604         Separated ApplyPropertyDefault into parent and child so that other classes could inherit
605         the applyInheritValue and applyInitialValue methods only.
606         This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().
607         
608         Added ApplyPropertyWidth class for handling width based CSS properties.
609         * css/CSSStyleSelector.cpp:
610         Removed no-longer-required code for handling width based CSS properties.
611         * css/CSSStyleSelector.h:
612         Added a getter for m_rootElementStyle.
613
614 2011-04-28  Kent Tamura  <tkent@chromium.org>
615
616         Run sort-Xcode-project-file.
617
618         * WebCore.xcodeproj/project.pbxproj:
619
620 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
621
622         Reviewed by Dirk Schulze.
623
624         [Cairo] Text underline is not shadowed when text-shadow is enabled
625         https://bugs.webkit.org/show_bug.cgi?id=48074
626
627         Use ContextShadow to enable shadows for text underlines. Also remove quite a bit
628         of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
629         originally copied from the CG GraphicsContext.
630
631         * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
632           can call it from a static helper function.
633         * platform/graphics/cairo/GraphicsContextCairo.cpp:
634         (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
635         (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
636         call it multiple times when shadowing text underlines.
637         (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
638         (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
639         (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
640
641 2011-04-28  Sam Weinig  <sam@webkit.org>
642
643         Rubber-stamped by Mark Rowe.
644
645         Cleanup WebCore.xcodeproj a bit.
646
647         * WebCore.xcodeproj/project.pbxproj:
648         Added CompilerVersion.xcconfig and moved some JS bindings files into the
649         correct sub groups.
650
651 2011-04-28  David Levin  <levin@chromium.org>
652
653         Reviewed by Adam Barth.
654
655         Remove IMAGE_RESIZER related code.
656         https://bugs.webkit.org/show_bug.cgi?id=59735
657
658         * CMakeLists.txt:
659         * Configurations/FeatureDefines.xcconfig:
660         * GNUmakefile.am:
661         * GNUmakefile.list.am:
662         * WebCore.gypi:
663         * WebCore.pro:
664         * WebCore.vcproj/WebCore.vcproj:
665         * WebCore.xcodeproj/project.pbxproj:
666         * features.pri:
667         * html/AsyncImageResizer.cpp: Removed.
668         * html/AsyncImageResizer.h: Removed.
669         * html/ImageResizerThread.cpp: Removed.
670         * html/ImageResizerThread.h: Removed.
671
672 2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
673
674         Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
675
676         * inspector/front-end/Settings.js:
677         (WebInspector.Settings):
678
679 2011-04-28  Beth Dakin  <bdakin@apple.com>
680
681         Rubber-stamped by Sam Weinig.
682
683         Rolling out revision 85258! I want to fix that bug a different way.
684         * platform/mac/ScrollbarThemeMac.mm:
685         (WebCore::ScrollbarThemeMac::paint):
686
687 2011-04-28  Chang Shu  <cshu@webkit.org>
688
689         Reviewed by Eric Seidel.
690
691         isContentEditable is not working properly with document.designMode
692         https://bugs.webkit.org/show_bug.cgi?id=53031
693
694         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
695         indicates that the element.isContentEditable relies on document.designMode if its
696         and its ancestors' contenteditable attributes are set to inherit.
697
698         1. Sync document render style after document.designMode is changed.
699         2. Removed the code that does unnecessary and incorrect handling for contenteditable
700         attribute with "inherit" value.
701         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
702
703         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
704                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
705                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
706                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
707
708         * css/CSSStyleSelector.cpp:
709         (WebCore::CSSStyleSelector::styleForDocument):
710         * dom/Document.cpp:
711         (WebCore::Document::setDesignMode):
712         * dom/Node.cpp:
713         (WebCore::Node::rendererIsEditable):
714         * editing/ApplyStyleCommand.cpp:
715         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
716         * html/HTMLElement.cpp:
717         (WebCore::HTMLElement::setContentEditable):
718
719 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
720
721         Unreviewed, rolling out r85101.
722         http://trac.webkit.org/changeset/85101
723         https://bugs.webkit.org/show_bug.cgi?id=59757
724
725          it'd be better to rollout the patch and do another one with
726         another property name. Current one will bring us to a problem
727         at first run after upgrade because it's type was changed from
728         int to string. (Requested by loislo on #webkit).
729
730         * inspector/front-end/ScriptsPanel.js:
731         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
732         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
733         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
734
735 2011-04-28  Mike Reed  <reed@google.com>
736
737         Reviewed by Eric Seidel.
738
739         fix shadw behavior for both CSS and Canvas -- skia only
740         https://bugs.webkit.org/show_bug.cgi?id=59700
741
742         Test:
743         canvas/philip/tests/2d.shadow.alpha.3.html
744         canvas/philip/tests/2d.shadow.alpha.4.html
745         canvas/philip/tests/2d.shadow.alpha.5.html
746         fast/canvas/canvas-fillPath-alpha-shadow.html
747         fast/canvas/canvas-strokePath-alpha-shadow.html
748         fast/canvas/canvas-strokeRect-alpha-shadow.html
749         fast/css/text-input-with-webkit-border-radius.html
750         fast/repaint/shadow-multiple-horizontal.html
751         fast/repaint/shadow-multiple-strict-horizontal.html
752         fast/repaint/shadow-multiple-strict-vertical.html
753         fast/repaint/shadow-multiple-vertical.html
754         fast/canvas/canvas-getImageData.html
755
756         * platform/graphics/chromium/FontChromiumWin.cpp:
757         (WebCore::Font::drawGlyphs):
758         * platform/graphics/skia/GraphicsContextSkia.cpp:
759         (WebCore::GraphicsContext::setPlatformShadow):
760
761 2011-04-28  David Kilzer  <ddkilzer@apple.com>
762
763         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
764
765         Reviewed by Chris Fleizach.
766
767         Previously, AXObjectCache::attachWrapper over-retained each
768         AccessibilityObjectWrapper it created, which is why
769         AXObjectCache::detachWrapper() contained an extra -release.
770
771         * accessibility/mac/AXObjectCacheMac.mm:
772         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
773         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
774         assigns to a RetainPtr<> instance variable, it doesn't need a +1
775         retained object passed in.  Fix the leak by using a RetainPtr<>
776         for the AccessibilityObjectWrapper.
777
778 2011-04-28  Nat Duca  <nduca@chromium.org>
779
780         Reviewed by Darin Fisher.
781
782         [chromium] Compute compositor fps value and history using the frameBegin timestamp
783         https://bugs.webkit.org/show_bug.cgi?id=59668
784
785         This change switches the compositor FPS meter to use the timestamp
786         of the beginning of the frame rather than the time we call
787         swapBuffers. When scheduling is correctly tied to vsync, we can
788         have highly variable times when we finish vsync and still have
789         stable frame rates.
790
791         * platform/graphics/chromium/LayerRendererChromium.cpp:
792         (WebCore::LayerRendererChromium::updateAndDrawLayers):
793         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
794         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
795         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
796         (WebCore::CCHeadsUpDisplay::onFrameBegin):
797         (WebCore::CCHeadsUpDisplay::onPresent):
798         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
799
800 2011-04-28  Beth Dakin  <bdakin@apple.com>
801
802         Reviewed by Darin Adler.
803
804         https://bugs.webkit.org/show_bug.cgi?id=59759
805         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
806         track when there is nothing to scroll to
807         <rdar://problem/9282066>
808
809         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
810         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
811         is not right. Set the proportion to 0 in this case instead.
812         * platform/mac/ScrollbarThemeMac.mm:
813         (WebCore::ScrollbarThemeMac::paint):
814
815 2011-04-28  Dan Bernstein  <mitz@apple.com>
816
817         Reviewed by Simon Fraser.
818
819         <rdar://problem/9291132> Add support for -epub-prefixed properties
820
821         Test: fast/css/epub-properties.html
822
823         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
824         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
825         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
826         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
827         text-transform, text-transform, word-break, and -webkit-writing-mode.
828
829 2011-04-28  Adam Barth  <abarth@webkit.org>
830
831         Reviewed by Eric Seidel.
832
833         Remove WML
834         https://bugs.webkit.org/show_bug.cgi?id=59678
835
836         This patch removes WML from WebCore.  After removing WML, there's a
837         bunch of twisted code that could be untwisted, but this patch contains
838         only the purely mechanical part of removing the feature.
839
840         There's been a lot of discussion on webkit-dev about whether we should
841         remove WML.  In addition to those threads, we've had an informal poll
842         of the reviewers as well as an in-person discussion at the WebKit
843         contributor's meeting.  Removing any feature is likely to make some
844         folks unhappy, but, on balance, removing WML appears to be the right
845         thing for the project to do at this time.
846
847         * CMakeLists.txt:
848         * CodeGenerators.pri:
849         * Configurations/FeatureDefines.xcconfig:
850         * DerivedSources.cpp:
851         * DerivedSources.make:
852         * GNUmakefile.am:
853         * GNUmakefile.list.am:
854         * WebCore.gyp/WebCore.gyp:
855         * WebCore.gypi:
856         * WebCore.pro:
857         * WebCore.vcproj/WebCore.vcproj:
858         * WebCore.xcodeproj/project.pbxproj:
859         * css/CSSStyleSelector.cpp:
860         (WebCore::linkAttribute):
861         (WebCore::CSSStyleSelector::styleForElement):
862         (WebCore::CSSStyleSelector::adjustRenderStyle):
863         * css/wml.css: Removed.
864         * dom/DOMImplementation.cpp:
865         (WebCore::DOMImplementation::createDocument):
866         * dom/Document.cpp:
867         (WebCore::Document::Document):
868         (WebCore::Document::createElement):
869         * dom/Document.h:
870         (WebCore::Document::isMediaDocument):
871         * dom/Document.idl:
872         * dom/InputElement.h:
873         * dom/Node.cpp:
874         (WebCore::Node::toInputElement):
875         * dom/Node.h:
876         * dom/OptionElement.cpp:
877         (WebCore::toOptionElement):
878         (WebCore::isOptionElement):
879         * dom/OptionElement.h:
880         * dom/OptionGroupElement.cpp:
881         (WebCore::toOptionGroupElement):
882         (WebCore::isOptionGroupElement):
883         * dom/SelectElement.cpp:
884         (WebCore::toSelectElement):
885         * dom/SelectElement.h:
886         * dom/Text.cpp:
887         (WebCore::Text::attach):
888         * dom/XMLDocumentParser.cpp:
889         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
890         * dom/XMLDocumentParser.h:
891         * dom/XMLDocumentParserLibxml2.cpp:
892         (WebCore::XMLDocumentParser::internalSubset):
893         (WebCore::getEntityHandler):
894         * dom/XMLDocumentParserQt.cpp:
895         (WebCore::XMLDocumentParser::parse):
896         (WebCore::XMLDocumentParser::parseDtd):
897         * editing/htmlediting.cpp:
898         (WebCore::canHaveChildrenForEditing):
899         * features.pri:
900         * history/BackForwardList.h:
901         * history/BackForwardListImpl.cpp:
902         * history/BackForwardListImpl.h:
903         * history/PageCache.cpp:
904         (WebCore::PageCache::canCachePageContainingThisFrame):
905         * html/HTMLAnchorElement.h:
906         * inspector/ConsoleMessage.cpp:
907         (WebCore::messageSourceValue):
908         * inspector/front-end/ConsoleView.js:
909         (WebInspector.ConsoleMessage.prototype.toString):
910         * loader/FrameLoader.cpp:
911         (WebCore::isBackForwardLoadType):
912         (WebCore::FrameLoader::transitionToCommitted):
913         (WebCore::FrameLoader::shouldReload):
914         (WebCore::FrameLoader::loadDifferentDocumentItem):
915         (WebCore::FrameLoader::loadItem):
916         * loader/FrameLoaderTypes.h:
917         * loader/HistoryController.cpp:
918         (WebCore::HistoryController::restoreDocumentState):
919         * manual-tests/wml: Removed.
920         * manual-tests/wml/StartTests.wml: Removed.
921         * manual-tests/wml/a-br-element.wml: Removed.
922         * manual-tests/wml/a-element.wml: Removed.
923         * manual-tests/wml/a-img-element.wml: Removed.
924         * manual-tests/wml/access-target.wml: Removed.
925         * manual-tests/wml/anchor-br-element.wml: Removed.
926         * manual-tests/wml/anchor-element.wml: Removed.
927         * manual-tests/wml/anchor-img-element.wml: Removed.
928         * manual-tests/wml/card-newcontext-attr.wml: Removed.
929         * manual-tests/wml/card-onenterbackward.wml: Removed.
930         * manual-tests/wml/card-onenterforward.wml: Removed.
931         * manual-tests/wml/card-ontimer.wml: Removed.
932         * manual-tests/wml/deck-access-control.wml: Removed.
933         * manual-tests/wml/input-format.wml: Removed.
934         * manual-tests/wml/onevent-go.wml: Removed.
935         * manual-tests/wml/onevent-noop.wml: Removed.
936         * manual-tests/wml/onevent-prev.wml: Removed.
937         * manual-tests/wml/onevent-refresh.wml: Removed.
938         * manual-tests/wml/onevent-shadow.wml: Removed.
939         * manual-tests/wml/resources: Removed.
940         * manual-tests/wml/resources/smiley.png: Removed.
941         * manual-tests/wml/select-element.wml: Removed.
942         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
943         * manual-tests/wml/select-onpick-event.wml: Removed.
944         * manual-tests/wml/setvar-element.wml: Removed.
945         * manual-tests/wml/targetdeck.wml: Removed.
946         * manual-tests/wml/task-go-in-anchor.wml: Removed.
947         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
948         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
949         * manual-tests/wml/template-go.wml: Removed.
950         * manual-tests/wml/template-ontimer.wml: Removed.
951         * manual-tests/wml/timer.wml: Removed.
952         * manual-tests/wml/variable-substitution.wml: Removed.
953         * page/Console.cpp:
954         (WebCore::printMessageSourceAndLevelPrefix):
955         * page/Console.h:
956         * page/Frame.cpp:
957         (WebCore::Frame::Frame):
958         * page/Page.cpp:
959         * page/Page.h:
960         * platform/MIMETypeRegistry.cpp:
961         (WebCore::initializeSupportedNonImageMimeTypes):
962         * platform/network/FormDataBuilder.h:
963         * platform/network/mac/ResourceHandleMac.mm:
964         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
965         * platform/wince/MIMETypeRegistryWinCE.cpp:
966         (WebCore::initMIMETypeEntensionMap):
967         * rendering/HitTestResult.cpp:
968         (WebCore::HitTestResult::altDisplayString):
969         (WebCore::HitTestResult::absoluteImageURL):
970         (WebCore::HitTestResult::absoluteLinkURL):
971         (WebCore::HitTestResult::isLiveLink):
972         * rendering/RenderBox.cpp:
973         * rendering/RenderButton.cpp:
974         (WebCore::RenderButton::updateFromElement):
975         * rendering/RenderFieldset.cpp:
976         (WebCore::RenderFieldset::findLegend):
977         * rendering/RenderImage.cpp:
978         (WebCore::RenderImage::updateAltText):
979         * rendering/RenderObject.cpp:
980         (WebCore::RenderObject::isLegend):
981         (WebCore::RenderObject::offsetParent):
982         * wml: Removed.
983         * wml/WMLAElement.cpp: Removed.
984         * wml/WMLAElement.h: Removed.
985         * wml/WMLAccessElement.cpp: Removed.
986         * wml/WMLAccessElement.h: Removed.
987         * wml/WMLAnchorElement.cpp: Removed.
988         * wml/WMLAnchorElement.h: Removed.
989         * wml/WMLAttributeNames.in: Removed.
990         * wml/WMLBRElement.cpp: Removed.
991         * wml/WMLBRElement.h: Removed.
992         * wml/WMLCardElement.cpp: Removed.
993         * wml/WMLCardElement.h: Removed.
994         * wml/WMLDoElement.cpp: Removed.
995         * wml/WMLDoElement.h: Removed.
996         * wml/WMLDocument.cpp: Removed.
997         * wml/WMLDocument.h: Removed.
998         * wml/WMLElement.cpp: Removed.
999         * wml/WMLElement.h: Removed.
1000         * wml/WMLErrorHandling.cpp: Removed.
1001         * wml/WMLErrorHandling.h: Removed.
1002         * wml/WMLEventHandlingElement.cpp: Removed.
1003         * wml/WMLEventHandlingElement.h: Removed.
1004         * wml/WMLFieldSetElement.cpp: Removed.
1005         * wml/WMLFieldSetElement.h: Removed.
1006         * wml/WMLFormControlElement.cpp: Removed.
1007         * wml/WMLFormControlElement.h: Removed.
1008         * wml/WMLGoElement.cpp: Removed.
1009         * wml/WMLGoElement.h: Removed.
1010         * wml/WMLImageElement.cpp: Removed.
1011         * wml/WMLImageElement.h: Removed.
1012         * wml/WMLImageLoader.cpp: Removed.
1013         * wml/WMLImageLoader.h: Removed.
1014         * wml/WMLInputElement.cpp: Removed.
1015         * wml/WMLInputElement.h: Removed.
1016         * wml/WMLInsertedLegendElement.cpp: Removed.
1017         * wml/WMLInsertedLegendElement.h: Removed.
1018         * wml/WMLIntrinsicEvent.cpp: Removed.
1019         * wml/WMLIntrinsicEvent.h: Removed.
1020         * wml/WMLIntrinsicEventHandler.cpp: Removed.
1021         * wml/WMLIntrinsicEventHandler.h: Removed.
1022         * wml/WMLMetaElement.cpp: Removed.
1023         * wml/WMLMetaElement.h: Removed.
1024         * wml/WMLNoopElement.cpp: Removed.
1025         * wml/WMLNoopElement.h: Removed.
1026         * wml/WMLOnEventElement.cpp: Removed.
1027         * wml/WMLOnEventElement.h: Removed.
1028         * wml/WMLOptGroupElement.cpp: Removed.
1029         * wml/WMLOptGroupElement.h: Removed.
1030         * wml/WMLOptionElement.cpp: Removed.
1031         * wml/WMLOptionElement.h: Removed.
1032         * wml/WMLPElement.cpp: Removed.
1033         * wml/WMLPElement.h: Removed.
1034         * wml/WMLPageState.cpp: Removed.
1035         * wml/WMLPageState.h: Removed.
1036         * wml/WMLPostfieldElement.cpp: Removed.
1037         * wml/WMLPostfieldElement.h: Removed.
1038         * wml/WMLPrevElement.cpp: Removed.
1039         * wml/WMLPrevElement.h: Removed.
1040         * wml/WMLRefreshElement.cpp: Removed.
1041         * wml/WMLRefreshElement.h: Removed.
1042         * wml/WMLSelectElement.cpp: Removed.
1043         * wml/WMLSelectElement.h: Removed.
1044         * wml/WMLSetvarElement.cpp: Removed.
1045         * wml/WMLSetvarElement.h: Removed.
1046         * wml/WMLTableElement.cpp: Removed.
1047         * wml/WMLTableElement.h: Removed.
1048         * wml/WMLTagNames.in: Removed.
1049         * wml/WMLTaskElement.cpp: Removed.
1050         * wml/WMLTaskElement.h: Removed.
1051         * wml/WMLTemplateElement.cpp: Removed.
1052         * wml/WMLTemplateElement.h: Removed.
1053         * wml/WMLTimerElement.cpp: Removed.
1054         * wml/WMLTimerElement.h: Removed.
1055         * wml/WMLVariables.cpp: Removed.
1056         * wml/WMLVariables.h: Removed.
1057
1058 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1059
1060         Unreviewed, rolling out r85233 and r85235.
1061         http://trac.webkit.org/changeset/85233
1062         http://trac.webkit.org/changeset/85235
1063         https://bugs.webkit.org/show_bug.cgi?id=59754
1064
1065         Causes issues with jsc. (Requested by dave_levin on #webkit).
1066
1067         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
1068         * loader/icon/IconDatabase.cpp:
1069         (WebCore::IconDatabase::defaultIcon):
1070         (WebCore::IconDatabase::setIconDataForIconURL):
1071         (WebCore::IconDatabase::getOrCreateIconRecord):
1072         (WebCore::IconDatabase::readFromDatabase):
1073
1074 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
1075
1076         Reviewed by Adam Barth.
1077
1078         Introducing a new class that allows serialization of a page back
1079         to HTML/XML with all its sub-frames and also retrieves the page's
1080         resources.
1081         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
1082         https://bugs.webkit.org/show_bug.cgi?id=58947
1083
1084         * Android.mk:
1085         * CMakeLists.txt:
1086         * GNUmakefile.list.am:
1087         * WebCore.gypi:
1088         * WebCore.pro:
1089         * WebCore.vcproj/WebCore.vcproj:
1090         * dom/Document.cpp:
1091         (WebCore::Document::suggestedMIMEType):
1092         * dom/Document.h:
1093         * editing/MarkupAccumulator.cpp:
1094         (WebCore::MarkupAccumulator::appendCustomAttributes):
1095         (WebCore::MarkupAccumulator::appendElement):
1096         * editing/MarkupAccumulator.h:
1097         * html/parser/HTMLMetaCharsetParser.cpp:
1098         (WebCore::HTMLMetaCharsetParser::processMeta):
1099         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
1100         * html/parser/HTMLMetaCharsetParser.h:
1101         * page/PageSerializer.cpp: Added.
1102         * page/PageSerializer.h: Added.
1103
1104 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
1105
1106         Reviewed by Tony Chang.
1107
1108         IndexedDB createIndex should fail if name arg is null
1109         https://bugs.webkit.org/show_bug.cgi?id=58365
1110
1111         Test: storage/indexeddb/mozilla/create-index-null-name.html
1112
1113         * storage/IDBObjectStore.idl:
1114         * storage/IDBObjectStoreBackendImpl.cpp:
1115         (WebCore::IDBObjectStoreBackendImpl::createIndex):
1116
1117 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
1118
1119         Reviewed by Tony Chang.
1120
1121         IndexedDB put() should fail if second (key) parameter is null
1122         https://bugs.webkit.org/show_bug.cgi?id=58613
1123
1124         If key arg is not specified, prpKey ends up as a null pointer in ::put().
1125         However, if the key arg is specified but is null, prpKey ends up as a
1126         valid IDBKey which has a null key type. As it happens, we need to be able
1127         to detect the difference between these cases (the key arg is optional but
1128         if specified must not be null).
1129
1130         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
1131
1132         * storage/IDBObjectStoreBackendImpl.cpp:
1133         (WebCore::IDBObjectStoreBackendImpl::put):
1134
1135 2011-04-07  David Levin  <levin@chromium.org>
1136
1137         Reviewed by Darin Adler.
1138
1139         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
1140         https://bugs.webkit.org/show_bug.cgi?id=31639
1141
1142         No new functionality exposed so no new tests. (The change is basically adding
1143         more testing.)
1144
1145         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
1146         * loader/icon/IconDatabase.cpp:
1147         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
1148         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
1149         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
1150         (WebCore::IconDatabase::readFromDatabase): Ditto.
1151
1152 2011-04-28  Kenneth Russell  <kbr@google.com>
1153
1154         Unreviewed build fix for Web Audio with strict OwnPtr.
1155
1156         * platform/audio/HRTFDatabaseLoader.cpp:
1157         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
1158
1159 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
1160
1161         Reviewed by Geoffrey Garen.
1162
1163         Walk shadow hosts as well as parent nodes when finding opaque roots.
1164         https://bugs.webkit.org/show_bug.cgi?id=59571
1165
1166         Test: fast/dom/shadow/gc-shadow.html
1167
1168         * bindings/js/JSDOMBinding.h:
1169         (WebCore::root):
1170
1171 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
1172
1173         Reviewed by Xan Lopez.
1174
1175         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
1176         https://bugs.webkit.org/show_bug.cgi?id=59715
1177
1178         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
1179         into WebCore so that WebKit1 and WebKit2 can share the code.
1180
1181         No new tests. This is covered by fast/events/click-count.html.
1182
1183         * GNUmakefile.list.am: Added new files.
1184         * platform/gtk/GtkClickCounter.cpp: Added.
1185         (WebCore::GtkClickCounter::GtkClickCounter): Added.
1186         (WebCore::GtkClickCounter::reset): Added.
1187         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
1188         (WebCore::getEventTime): Added.
1189         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
1190         * platform/gtk/GtkClickCounter.h: Added.
1191
1192 2011-04-28  Dan Bernstein  <mitz@apple.com>
1193
1194         Build fix.
1195
1196         * css/CSSParser.cpp:
1197         (WebCore::cssPropertyID):
1198
1199 2011-04-28  Dan Bernstein  <mitz@apple.com>
1200
1201         Reviewed by Simon Fraser.
1202
1203         Allow specifying CSS property aliases in CSSPropertyNames.in files
1204         https://bugs.webkit.org/show_bug.cgi?id=59712
1205
1206         * css/CSSParser.cpp:
1207         (WebCore::cssPropertyID): Removed code to handle some aliases
1208         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
1209         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
1210         defining an alias, and add an appropriate entry to the gperf file.
1211
1212 2011-04-28  Arno Renevier  <arno@renevier.net>
1213
1214         Reviewed by Gustavo Noronha Silva.
1215
1216         [Soup] does not load css stylesheets without content-type
1217         https://bugs.webkit.org/show_bug.cgi?id=59697
1218
1219         When sniffing content type, do not replace http Content-Type header in
1220         soup message anymore, but keep sniffed content type in a separate
1221         variable.
1222
1223         * platform/network/soup/ResourceHandleSoup.cpp:
1224         (WebCore::contentSniffedCallback):
1225         * platform/network/soup/ResourceResponse.h:
1226         (WebCore::ResourceResponse::sniffedContentType):
1227         (WebCore::ResourceResponse::setSniffedContentType):
1228         * platform/network/soup/ResourceResponseSoup.cpp:
1229         (WebCore::ResourceResponse::updateFromSoupMessage):
1230
1231 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
1232
1233         Reviewed by Andreas Kling.
1234
1235         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
1236         https://bugs.webkit.org/show_bug.cgi?id=59704
1237
1238         No new tests, just code cleanup.
1239
1240         * WebCore.pri:
1241
1242 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
1243
1244         Reviewed by Pavel Feldman.
1245
1246         Web Inspector: remove "Pretty print" source frame context menu item.
1247         https://bugs.webkit.org/show_bug.cgi?id=59709
1248
1249         * inspector/front-end/DebuggerPresentationModel.js:
1250         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
1251         * inspector/front-end/ScriptsPanel.js:
1252         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1253         * inspector/front-end/SourceFrame.js:
1254         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
1255
1256 2011-04-28  Satish Sampath  <satish@chromium.org>
1257
1258         Reviewed by Tony Gentilcore.
1259
1260         Speech input button layout issues with padding and border.
1261         https://bugs.webkit.org/show_bug.cgi?id=59613
1262
1263         * rendering/RenderTextControlSingleLine.cpp:
1264         (WebCore::RenderTextControlSingleLine::layout):
1265         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1266         (WebCore::RenderTextControlSingleLine::forwardEvent):
1267
1268 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1269
1270         Reviewed by Martin Robinson.
1271
1272         [GTK] Check whether to use native scrollbars at run time
1273         https://bugs.webkit.org/show_bug.cgi?id=59694
1274
1275         It's currently decided at build time depending on whether webkit2
1276         build is enabled or not. That makes imposible to build both
1277         webkit1 and webkit2 using the same libWebCore.
1278
1279         * GNUmakefile.am:
1280         * platform/ScrollView.cpp:
1281         (WebCore::ScrollView::wheelEvent):
1282         * platform/gtk/ScrollViewGtk.cpp:
1283         (WebCore::ScrollView::createScrollbar):
1284
1285 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1286
1287         Reviewed by Yury Semikhatsky.
1288
1289         Web Inspector: add status bar button for pretty print.
1290         https://bugs.webkit.org/show_bug.cgi?id=59467
1291
1292         * WebCore.gypi:
1293         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
1294         * inspector/front-end/ScriptsPanel.js:
1295         (WebInspector.ScriptsPanel):
1296         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
1297         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1298         * inspector/front-end/WebKit.qrc:
1299         * inspector/front-end/inspector.css:
1300         (.scripts-toggle-pretty-print-status-bar-item .glyph):
1301         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
1302
1303 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1304
1305         Reviewed by Yury Semikhatsky.
1306
1307         Web Inspector: add ResourceTreeModel tests.
1308         https://bugs.webkit.org/show_bug.cgi?id=59616
1309
1310         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
1311                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
1312                http/tests/inspector/resource-tree/resource-tree-reload.html
1313
1314         * inspector/front-end/ResourceTreeModel.js:
1315         (WebInspector.ResourceTreeModel.prototype.frontendReused):
1316         (WebInspector.ResourceTreeModel.prototype._addFrame):
1317         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1318         (WebInspector.ResourceTreeModel.prototype._frameDetached):
1319         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
1320         (WebInspector.ResourceTreeModel.prototype.forAllResources):
1321         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
1322         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
1323         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
1324         * inspector/front-end/ResourcesPanel.js:
1325         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1326         (WebInspector.ResourcesPanel.prototype._frameAdded):
1327         (WebInspector.ResourcesPanel.prototype._frameDetached):
1328         (WebInspector.ResourcesPanel.prototype._frameNavigated):
1329         (WebInspector.FrameTreeElement):
1330         (WebInspector.FrameTreeElement.prototype.frameNavigated):
1331
1332 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1333
1334         Reviewed by Yury Semikhatsky.
1335
1336         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
1337         https://bugs.webkit.org/show_bug.cgi?id=59592
1338
1339         * inspector/front-end/DetailedHeapshotGridNodes.js:
1340         (WebInspector.HeapSnapshotGridNode.prototype._populate):
1341         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
1342         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
1343         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
1344         * inspector/front-end/DetailedHeapshotView.js:
1345         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
1346         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
1347         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
1348         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
1349         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
1350         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
1351         (WebInspector.DetailedHeapshotView.prototype.changeView):
1352         * inspector/front-end/HeapSnapshot.js:
1353         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
1354         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
1355         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
1356         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
1357         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
1358         * inspector/front-end/heapProfiler.css:
1359         (div.retaining-paths-view td.path-column div:hover):
1360
1361 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1362
1363         Reviewed by Yury Semikhatsky.
1364
1365         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
1366         https://bugs.webkit.org/show_bug.cgi?id=59454
1367
1368         Test: inspector/profiler/heap-snapshot-loader.html
1369
1370         * inspector/front-end/HeapSnapshot.js:
1371         (WebInspector.HeapSnapshotLoader):
1372         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
1373         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
1374         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
1375         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
1376         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
1377         * inspector/front-end/HeapSnapshotProxy.js:
1378         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
1379
1380 2011-04-28  ojab  <ojab@ojab.ru>
1381
1382         Reviewed by David Levin.
1383
1384         Fix build with libpng-1.5.1
1385         https://bugs.webkit.org/show_bug.cgi?id=59607
1386
1387         * platform/image-decoders/png/PNGImageDecoder.cpp:
1388         (WebCore::readColorProfile):
1389
1390 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
1391
1392         Reviewed by Nikolas Zimmermann.
1393
1394         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
1395         https://bugs.webkit.org/show_bug.cgi?id=59447
1396
1397         This patch contains two sub-routines, one for speeding up
1398         alpha channel only gaussian blur (by 2.5 times) and one
1399         for speeding up all channel blur (by 4 times).
1400
1401         The common code is also redesigned to better fit for platform
1402         specific code. This means large chunks of code was moved to
1403         different files, and all platform specific files are added to
1404         all build systems.
1405
1406         * CMakeLists.txt:
1407         * GNUmakefile.am:
1408         * GNUmakefile.list.am:
1409         * WebCore.gypi:
1410         * WebCore.pro:
1411         * WebCore.vcproj/WebCore.vcproj:
1412         * WebCore.vcproj/WebCoreCommon.vsprops:
1413         * WebCore.xcodeproj/project.pbxproj:
1414         * platform/graphics/filters/FEGaussianBlur.cpp:
1415         (WebCore::FEGaussianBlur::platformApplyGeneric):
1416         (WebCore::FEGaussianBlur::apply):
1417         * platform/graphics/filters/FEGaussianBlur.h:
1418         (WebCore::FEGaussianBlur::kernelPosition):
1419         (WebCore::FEGaussianBlur::platformApply):
1420         * platform/graphics/filters/FELighting.cpp:
1421         (WebCore::FELighting::platformApplyGeneric):
1422         (WebCore::FELighting::drawLighting):
1423         * platform/graphics/filters/FELighting.h:
1424         (WebCore::FELighting::platformApply):
1425         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
1426         (WebCore::WTF_ALIGNED):
1427         (WebCore::feGaussianBlurConstantsForNeon):
1428         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
1429         (WebCore::FEGaussianBlur::platformApplyNeon):
1430         * platform/graphics/filters/arm/FELightingNEON.cpp:
1431         (WebCore::WTF_ALIGNED):
1432         (WebCore::FELighting::getPowerCoefficients):
1433         * platform/graphics/filters/arm/FELightingNEON.h:
1434         (WebCore::FELighting::platformApplyNeon):
1435
1436 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
1437
1438         Reviewed by Yury Semikhatsky.
1439
1440         Web Inspector: provide a hotkey for script pause
1441         https://bugs.webkit.org/show_bug.cgi?id=59593
1442
1443         In fact, F8 works as a hotkey, but this fact was not reflected
1444         in the shortcut help popup.
1445
1446         * English.lproj/localizedStrings.js:
1447         * inspector/front-end/ScriptsPanel.js:
1448         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
1449
1450 2011-04-28  Adam Barth  <abarth@webkit.org>
1451
1452         Reviewed by Eric Seidel.
1453
1454         PluginStream should play nice with strict OwnPtr
1455         https://bugs.webkit.org/show_bug.cgi?id=59675
1456
1457         These failures appear when enabling strict OwnPtr on Qt.
1458
1459         * plugins/PluginStream.cpp:
1460         (WebCore::PluginStream::PluginStream):
1461         (WebCore::PluginStream::didReceiveData):
1462
1463 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
1464
1465         Reviewed by Pavel Feldman.
1466
1467         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
1468         https://bugs.webkit.org/show_bug.cgi?id=59326
1469
1470         Concrete CachedResource successors for stylesheets and scripts
1471         can decode their content better than the generic approach we use.
1472
1473         * inspector/InspectorPageAgent.cpp:
1474         (WebCore::decodeSharedBuffer):
1475         (WebCore::prepareCachedResourceBuffer):
1476         (WebCore::cachedResourceDecoded):
1477         (WebCore::InspectorPageAgent::resourceContent):
1478         (WebCore::InspectorPageAgent::resourceData):
1479         * inspector/InspectorStyleSheet.cpp:
1480         (WebCore::InspectorStyleSheet::originalStyleSheetText):
1481
1482 2011-04-28  Jon Lee  <jonlee@apple.com>
1483
1484         Reviewed by Simon Fraser.
1485
1486         REGRESSION: white overlay scrollbars on apple.com/startpage
1487         https://bugs.webkit.org/show_bug.cgi?id=59540
1488         <rdar://problem/9338653>
1489
1490         Now we look at the document background in addition to the <body> element,
1491         and blend those colors in with the base background of the frame view to
1492         arrive at our aggregate color. This provides a better result to determine
1493         overlay scrollbar style.
1494
1495         * page/Frame.cpp:
1496         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
1497         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
1498
1499 2011-04-27  Adam Barth  <abarth@webkit.org>
1500
1501         Reviewed by Maciej Stachowiak.
1502
1503         Fix OwnPtr issues in IndexedDB
1504         https://bugs.webkit.org/show_bug.cgi?id=59656
1505
1506         This patch is an attempt to fix the clang build.  Clang can't seem to
1507         cope with OwnPtrs to classes declared in an anonymous namespace because
1508         OwnPtr's copy constructor isn't defined (but would need to be defined
1509         in this translation unit).
1510
1511         * platform/leveldb/LevelDBDatabase.cpp:
1512
1513 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
1514
1515         Reviewed by Antonio Gomes.
1516
1517         [EFL] Change cursor to LAZY_NATIVE_CURSOR
1518         https://bugs.webkit.org/show_bug.cgi?id=59411
1519
1520         Enable LAZY_NATIVE_CURSOR on EFL build.
1521
1522         No test added because functionality is unchanged.
1523
1524         * CMakeListsEfl.txt: Add Cursor.cpp
1525         * platform/Cursor.h:
1526         (WebCore::Cursor::Cursor):
1527         * platform/efl/CursorEfl.cpp:
1528         (WebCore::Cursor::Cursor):
1529         (WebCore::Cursor::~Cursor):
1530         (WebCore::getCursorString):
1531         (WebCore::Cursor::ensurePlatformCursor):
1532         * platform/efl/WidgetEfl.cpp:
1533         (WebCore::Widget::setCursor):
1534
1535 2011-04-27  Adam Barth  <abarth@webkit.org>
1536
1537         Build fix from the future.  Another trival strict OwnPtr fixes.  This
1538         is the last futuristic build fix I can detect with my time traveling
1539         abilities.
1540
1541         * platform/graphics/chromium/TransparencyWin.cpp:
1542         (WebCore::TransparencyWin::initializeNewContext):
1543
1544 2011-04-27  Dmitry Lomov  <dslomov@google.com>
1545
1546         Reviewed by David Levin.
1547
1548         CrossThreadCopier should not have a default specialization for raw pointers
1549         https://bugs.webkit.org/show_bug.cgi?id=59234
1550         Removed the ablity to pass raw pointers cross-thread
1551         Added and applied annotations for doing that
1552
1553         * fileapi/FileReader.cpp:
1554         (WebCore::FileReader::readInternal):
1555         (WebCore::FileReader::abort):
1556         * fileapi/FileStreamProxy.cpp:
1557         (WebCore::FileStreamProxy::startOnFileThread):
1558         (WebCore::FileStreamProxy::stopOnFileThread):
1559         (WebCore::FileStreamProxy::getSize):
1560         (WebCore::FileStreamProxy::getSizeOnFileThread):
1561         (WebCore::FileStreamProxy::openForRead):
1562         (WebCore::FileStreamProxy::openForReadOnFileThread):
1563         (WebCore::FileStreamProxy::openForWrite):
1564         (WebCore::FileStreamProxy::openForWriteOnFileThread):
1565         (WebCore::FileStreamProxy::close):
1566         (WebCore::FileStreamProxy::read):
1567         (WebCore::FileStreamProxy::readOnFileThread):
1568         (WebCore::FileStreamProxy::write):
1569         (WebCore::FileStreamProxy::writeOnFileThread):
1570         (WebCore::FileStreamProxy::truncate):
1571         (WebCore::FileStreamProxy::truncateOnFileThread):
1572         * loader/WorkerThreadableLoader.cpp:
1573         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
1574         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
1575         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
1576         * page/GeolocationPositionCache.cpp:
1577         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
1578         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
1579         * platform/CrossThreadCopier.h:
1580         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
1581         (WebCore::AllowCrossThreadAccessWrapper::value):
1582         (WebCore::AllowCrossThreadAccess):
1583         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
1584         (WebCore::AllowExtendedLifetimeWrapper::value):
1585         (WebCore::AllowExtendedLifetime):
1586         * platform/graphics/chromium/cc/CCCompletionEvent.h:
1587         * storage/IDBObjectStoreBackendImpl.cpp:
1588         (WebCore::IDBObjectStoreBackendImpl::get):
1589         (WebCore::IDBObjectStoreBackendImpl::put):
1590         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1591         (WebCore::IDBObjectStoreBackendImpl::clear):
1592         (WebCore::IDBObjectStoreBackendImpl::createIndex):
1593         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
1594         (WebCore::IDBObjectStoreBackendImpl::openCursor):
1595         * storage/SQLCallbackWrapper.h:
1596         (WebCore::SQLCallbackWrapper::clear):
1597         * websockets/WorkerThreadableWebSocketChannel.cpp:
1598         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
1599         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
1600         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
1601         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
1602         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
1603         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
1604         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
1605         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
1606         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
1607         * workers/WorkerMessagingProxy.cpp:
1608         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
1609
1610 2011-04-27  Adam Barth  <abarth@webkit.org>
1611
1612         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
1613
1614         * page/Frame.cpp:
1615         (WebCore::Frame::setTiledBackingStoreEnabled):
1616         * platform/audio/ReverbConvolver.cpp:
1617         (WebCore::ReverbConvolver::ReverbConvolver):
1618
1619 2011-04-27  Adam Barth  <abarth@webkit.org>
1620
1621         Reviewed by David Levin.
1622
1623         Fix five strict PassOwnPtr violations in WebCore
1624         https://bugs.webkit.org/show_bug.cgi?id=59640
1625
1626         * css/MediaList.cpp:
1627         (WebCore::MediaList::deleteMedium):
1628         (WebCore::MediaList::setMediaText):
1629         (WebCore::MediaList::appendMedium):
1630         * css/MediaQuery.h:
1631         * dom/MessagePort.cpp:
1632         (WebCore::MessagePort::disentanglePorts):
1633         (WebCore::MessagePort::entanglePorts):
1634         * inspector/InspectorStyleSheet.cpp:
1635         (ParsedStyleSheet::setText):
1636         * rendering/RenderTheme.cpp:
1637         (WebCore::RenderTheme::adjustStyle):
1638         (WebCore::RenderTheme::adjustMeterStyle):
1639         * rendering/RenderThemeMac.mm:
1640         (WebCore::RenderThemeMac::adjustMenuListStyle):
1641         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
1642         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
1643         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
1644         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
1645         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
1646         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
1647         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
1648
1649 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
1650
1651         Reviewed by Beth Dakin.
1652
1653         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
1654         https://bugs.webkit.org/show_bug.cgi?id=59648
1655
1656         Test: accessibility/aria-fallback-roles.html
1657
1658         * accessibility/AccessibilityObject.cpp:
1659         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
1660
1661 2011-04-27  Beth Dakin  <bdakin@apple.com>
1662
1663         Reviewed by Dan Bernstein.
1664
1665         https://bugs.webkit.org/show_bug.cgi?id=59671
1666         Race condition with scrollbar animations and closing a page can cause a crash in 
1667         WebCore::FrameView::setVisibleScrollerThumbRect + 15
1668         -and corresponding-
1669         <rdar://problem/9329253>
1670
1671         It is definitely possible for Page to be null here. So we should null-check it! 
1672         And we should not ASSERT.
1673         * page/FrameView.cpp:
1674         (WebCore::FrameView::didCompleteRubberBand):
1675         (WebCore::FrameView::scrollbarStyleChanged):
1676         (WebCore::FrameView::setVisibleScrollerThumbRect):
1677
1678 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1679
1680         WinCE build fix after r85143.
1681
1682         * platform/graphics/wince/FontWinCE.cpp:
1683         (WebCore::TextRunComponent::TextRunComponent):
1684
1685 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
1686
1687         Reviewed by Tony Chang.
1688
1689         IndexedDB object store delete should fail if key is null
1690         https://bugs.webkit.org/show_bug.cgi?id=58614
1691
1692         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
1693
1694         * storage/IDBObjectStoreBackendImpl.cpp:
1695         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1696
1697 2011-04-27  Eric Seidel  <eric@webkit.org>
1698
1699         Reviewed by Ryosuke Niwa.
1700
1701         Should have an easy way to construct starting BidiStatus for a paragraph root
1702         https://bugs.webkit.org/show_bug.cgi?id=59226
1703
1704         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
1705         I've made this a constructor for BidiStatus instead.
1706
1707         As part of this effort I added a direction() accessor for TextRun and got
1708         rid of the old m_rtl bool.  This is part of the generic effort in the
1709         Bidi code to replace old bool usage with the superior TextDirection enum
1710         (this generally makes the code cleaner).
1711
1712         As part of this replacement effort I found several places which were
1713         assuming LTR (by passing rtl=false) when they probably want to use
1714         the current text direction.  I suspect that LTR vs. RTL may affect
1715         string width in the case of ligatures.  It's unclear.
1716
1717         This is almost entirely a mechanical change.
1718
1719         * html/canvas/CanvasRenderingContext2D.cpp:
1720         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1721         * platform/graphics/GraphicsContext.cpp:
1722         (WebCore::GraphicsContext::drawBidiText):
1723         * platform/graphics/TextRun.h:
1724         (WebCore::TextRun::TextRun):
1725         (WebCore::TextRun::direction):
1726         (WebCore::TextRun::rtl):
1727         (WebCore::TextRun::ltr):
1728         (WebCore::TextRun::setDirection):
1729         * platform/text/BidiResolver.h:
1730         (WebCore::BidiStatus::BidiStatus):
1731         * rendering/EllipsisBox.cpp:
1732         (WebCore::EllipsisBox::paint):
1733         (WebCore::EllipsisBox::selectionRect):
1734         (WebCore::EllipsisBox::paintSelection):
1735         * rendering/InlineTextBox.cpp:
1736         (WebCore::InlineTextBox::selectionRect):
1737         (WebCore::InlineTextBox::paint):
1738         (WebCore::InlineTextBox::paintSelection):
1739         (WebCore::InlineTextBox::paintCompositionBackground):
1740         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1741         (WebCore::InlineTextBox::paintTextMatchMarker):
1742         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1743         (WebCore::InlineTextBox::offsetForPosition):
1744         (WebCore::InlineTextBox::positionForOffset):
1745         * rendering/RenderBlockLineLayout.cpp:
1746         (WebCore::RenderBlock::determineStartPosition):
1747         * rendering/RenderFileUploadControl.cpp:
1748         (WebCore::RenderFileUploadControl::paintObject):
1749         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1750         * rendering/RenderListBox.cpp:
1751         (WebCore::RenderListBox::updateFromElement):
1752         (WebCore::RenderListBox::paintItemForeground):
1753         * rendering/RenderTextControl.cpp:
1754         (WebCore::RenderTextControl::getAvgCharWidth):
1755         (WebCore::RenderTextControl::paintPlaceholder):
1756         * rendering/svg/SVGInlineTextBox.cpp:
1757         (WebCore::SVGInlineTextBox::constructTextRun):
1758         * rendering/svg/SVGTextMetrics.cpp:
1759         (WebCore::constructTextRun):
1760
1761 2011-04-27  Robert Hogan  <robert@webkit.org>
1762
1763         Reviewed by Adam Barth.
1764
1765         Allow shadowing of history object
1766         https://bugs.webkit.org/show_bug.cgi?id=55965
1767
1768         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1769                http/tests/history/cross-origin-replace-history-object.html
1770
1771         * page/DOMWindow.idl:
1772
1773 2011-04-27  James Robinson  <jamesr@chromium.org>
1774
1775         Reviewed by Kenneth Russell.
1776
1777         [chromium] Ensure compositing layers are up to date before entering doComposite
1778         https://bugs.webkit.org/show_bug.cgi?id=59159
1779
1780         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1781         GraphicsLayerClient::paintContents() implementations).
1782
1783         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1784         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1785         * platform/graphics/chromium/LayerChromium.cpp:
1786         (WebCore::LayerChromium::LayerChromium):
1787         (WebCore::LayerChromium::~LayerChromium):
1788         * platform/graphics/chromium/LayerRendererChromium.cpp:
1789         (WebCore::LayerRendererChromium::updateLayers):
1790         * platform/graphics/chromium/LayerRendererChromium.h:
1791           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1792
1793 2011-04-27  James Robinson  <jamesr@chromium.org>
1794
1795         Reviewed by Adam Barth.
1796
1797         Fix OwnPtr strict issues in chromium linux build
1798         https://bugs.webkit.org/show_bug.cgi?id=59664
1799
1800         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1801         (WebCore::ComplexTextController::getNormalizedTextRun):
1802         * platform/graphics/skia/ImageBufferSkia.cpp:
1803         (WebCore::ImageBuffer::ImageBuffer):
1804         * platform/graphics/skia/PlatformContextSkia.cpp:
1805         (WebCore::PlatformContextSkia::PlatformContextSkia):
1806
1807 2011-04-27  Chris Rogers  <crogers@google.com>
1808
1809         Reviewed by Kenneth Russell.
1810
1811         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1812         https://bugs.webkit.org/show_bug.cgi?id=59641
1813
1814         No new tests since audio API is not yet implemented.
1815
1816         * platform/audio/AudioBus.cpp:
1817         (WebCore::AudioBus::createBySampleRateConverting):
1818         (WebCore::AudioBus::createByMixingToMono):
1819
1820 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1821
1822         Motivated by Alexey Proskuryakov.
1823
1824         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1825         informative, since it confused Alexey and me.
1826
1827 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1828
1829         Reviewed by Sam Weinig.
1830
1831         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1832         https://bugs.webkit.org/show_bug.cgi?id=59646
1833
1834         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1835         a world, we need to clear all entries in the map for that world, since
1836         the finalizers that would otherwise clear those entries don't run. The
1837         simplest way to do this is just to make the world own the map.
1838         
1839         * bindings/js/DOMWrapperWorld.h:
1840         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1841         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1842         * bindings/js/JSCSSValueCustom.cpp:
1843         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1844         (WebCore::JSCSSValueOwner::finalize):
1845         * bindings/js/JSDOMBinding.h:
1846
1847 2011-04-27  Adam Barth  <abarth@webkit.org>
1848
1849         Reviewed by David Levin.
1850
1851         Fix OwnPtr issues in IndexedDB
1852         https://bugs.webkit.org/show_bug.cgi?id=59656
1853
1854         I didn't do an exhaustive review of this code, but I fixed the problems
1855         caught by turning on strict OwnPtr and all their antecedents.  This
1856         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1857         behavior change.
1858
1859         * platform/leveldb/LevelDBDatabase.cpp:
1860         (WebCore::LevelDBDatabase::LevelDBDatabase):
1861         (WebCore::LevelDBDatabase::open):
1862         (WebCore::LevelDBDatabase::createIterator):
1863         * platform/leveldb/LevelDBDatabase.h:
1864         * platform/leveldb/LevelDBIterator.cpp:
1865         (WebCore::LevelDBIterator::LevelDBIterator):
1866         * platform/leveldb/LevelDBIterator.h:
1867         * storage/IDBLevelDBBackingStore.cpp:
1868         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1869         (WebCore::IDBLevelDBBackingStore::open):
1870         (WebCore::getNewDatabaseId):
1871         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1872         (WebCore::getNewObjectStoreId):
1873         (WebCore::deleteRange):
1874         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1875         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1876         (WebCore::IDBLevelDBBackingStore::getIndexes):
1877         (WebCore::getNewIndexId):
1878         (WebCore::findGreatestKeyLessThan):
1879         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1880         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1881         (WebCore::findLastIndexKeyEqualTo):
1882         * storage/IDBLevelDBBackingStore.h:
1883
1884 2011-04-19  MORITA Hajime  <morrita@google.com>
1885
1886         Reviewed by Tony Chang.
1887
1888         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1889         https://bugs.webkit.org/show_bug.cgi?id=58113
1890
1891         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1892         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1893         * Now MarkerMapVectorPair is no longer used.
1894         
1895         No new tests, No behavior change.
1896
1897         * GNUmakefile.list.am:
1898         * WebCore.gypi:
1899         * WebCore.pro:
1900         * WebCore.vcproj/WebCore.vcproj:
1901         * WebCore.xcodeproj/project.pbxproj:
1902         * dom/DocumentMarker.h:
1903         * dom/DocumentMarkerController.cpp:
1904         (WebCore::DocumentMarkerController::addMarker):
1905         (WebCore::DocumentMarkerController::copyMarkers):
1906         (WebCore::DocumentMarkerController::removeMarkers):
1907         (WebCore::DocumentMarkerController::markerContainingPoint):
1908         (WebCore::DocumentMarkerController::markersForNode):
1909         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1910         (WebCore::DocumentMarkerController::removeMarkersFromList):
1911         (WebCore::DocumentMarkerController::repaintMarkers):
1912         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1913         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1914         (WebCore::DocumentMarkerController::shiftMarkers):
1915         (WebCore::DocumentMarkerController::setMarkersActive):
1916         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1917         (WebCore::DocumentMarkerController::showMarkers):
1918         * dom/DocumentMarkerController.h:
1919         * dom/RenderedDocumentMarker.h: Added.
1920         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1921         (WebCore::RenderedDocumentMarker::isRendered):
1922         (WebCore::RenderedDocumentMarker::contains):
1923         (WebCore::RenderedDocumentMarker::setRenderedRect):
1924         (WebCore::RenderedDocumentMarker::renderedRect):
1925         (WebCore::RenderedDocumentMarker::invalidate):
1926         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1927
1928 2011-04-27  James Robinson  <jamesr@chromium.org>
1929
1930         Unreviewed, rolling out r85112.
1931         http://trac.webkit.org/changeset/85112
1932         https://bugs.webkit.org/show_bug.cgi?id=59159
1933
1934         Broke mac compile
1935
1936         * page/FrameView.cpp:
1937         (WebCore::FrameView::updateCompositingLayers):
1938         * page/FrameView.h:
1939         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1940         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1941         * platform/graphics/chromium/LayerChromium.cpp:
1942         (WebCore::LayerChromium::LayerChromium):
1943         (WebCore::LayerChromium::~LayerChromium):
1944         * platform/graphics/chromium/LayerRendererChromium.cpp:
1945         (WebCore::LayerRendererChromium::updateLayers):
1946         * platform/graphics/chromium/LayerRendererChromium.h:
1947
1948 2011-04-27  Mark Rowe  <mrowe@apple.com>
1949
1950         Build fix.
1951
1952         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1953
1954 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1955
1956         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1957
1958         * platform/network/ResourceHandleClient.h:
1959
1960 2011-04-27  James Robinson  <jamesr@chromium.org>
1961
1962         Reviewed by Kenneth Russell.
1963
1964         [chromium] Ensure compositing layers are up to date before entering doComposite
1965         https://bugs.webkit.org/show_bug.cgi?id=59159
1966
1967         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1968         GraphicsLayerClient::paintContents() implementations).
1969
1970         * page/FrameView.cpp:
1971         (WebCore::FrameView::updateCompositingLayers):
1972             Add an optional CompositingUpdateType parameter.
1973         * page/FrameView.h:
1974         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1975         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1976         * platform/graphics/chromium/LayerChromium.cpp:
1977         (WebCore::LayerChromium::LayerChromium):
1978         (WebCore::LayerChromium::~LayerChromium):
1979         * platform/graphics/chromium/LayerRendererChromium.cpp:
1980         (WebCore::LayerRendererChromium::updateLayers):
1981         * platform/graphics/chromium/LayerRendererChromium.h:
1982           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1983         * rendering/RenderLayer.cpp:
1984         (WebCore::RenderLayer::dirtyZOrderLists):
1985         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1986         * rendering/RenderLayerCompositor.cpp:
1987         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1988         * rendering/RenderLayerCompositor.h:
1989           Fix a typo in CompositingUpdateType Pait->Paint
1990
1991 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1992
1993         Reviewed by Antti Koivisto.
1994
1995         Part of WebCore should use CFNetwork-based loader on Mac
1996         https://bugs.webkit.org/show_bug.cgi?id=51836
1997
1998         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1999         willCacheResponse/shouldCacheResponse.
2000
2001         * loader/EmptyClients.h:
2002         * loader/FrameLoaderClient.h:
2003         * loader/ResourceLoader.h:
2004         * loader/cf/ResourceLoaderCFNet.cpp:
2005         * loader/mac/ResourceLoaderMac.mm:
2006         (WebCore::ResourceLoader::willCacheResponse):
2007         * platform/network/ResourceHandleClient.h:
2008         (WebCore::ResourceHandleClient::willCacheResponse):
2009         (WebCore::ResourceHandleClient::shouldCacheResponse):
2010         * platform/network/cf/ResourceHandleCFNet.cpp:
2011         (WebCore::willCacheResponse):
2012
2013 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
2014
2015         Reviewed by Brian Weinstein.
2016
2017         Web Inspector: Stop on Exception state does not persist.
2018
2019         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
2020         https://bugs.webkit.org/show_bug.cgi?id=59630
2021
2022         * inspector/front-end/ScriptsPanel.js:
2023         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
2024         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
2025         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
2026
2027 2011-04-27  Adrienne Walker  <enne@google.com>
2028
2029         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
2030         https://bugs.webkit.org/show_bug.cgi?id=59020
2031
2032         * platform/graphics/chromium/LayerRendererChromium.cpp:
2033         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2034
2035 2011-04-27  Darin Adler  <darin@apple.com>
2036
2037         Reviewed by David Levin.
2038
2039         Fix strict OwnPtr issues seen in about 30 more files
2040         https://bugs.webkit.org/show_bug.cgi?id=59615
2041
2042         * bindings/js/JSCallbackData.h:
2043         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
2044         * bindings/js/JSMessageEventCustom.cpp:
2045         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
2046         * css/CSSParser.cpp:
2047         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
2048         adoptPtr, and release.
2049         * dom/MessageEvent.cpp:
2050         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
2051         and release.
2052         * dom/MessagePortChannel.cpp:
2053         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
2054         * dom/ScriptExecutionContext.cpp:
2055         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
2056         * dom/XMLDocumentParserLibxml2.cpp:
2057         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
2058         * dom/default/PlatformMessagePortChannel.cpp:
2059         (WebCore::MessagePortChannel::create): Use adoptPtr.
2060         * html/HTMLFormControlElement.cpp:
2061         (WebCore::HTMLFormControlElement::detach): Use nullptr.
2062         * inspector/InspectorAgent.cpp:
2063         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
2064         * inspector/InspectorConsoleAgent.cpp:
2065         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
2066         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
2067         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
2068         * inspector/InspectorController.cpp:
2069         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
2070         * inspector/InspectorDOMAgent.cpp:
2071         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
2072         * inspector/InspectorResourceAgent.cpp:
2073         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
2074         * page/FrameActionScheduler.cpp:
2075         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
2076         * platform/graphics/ShadowBlur.cpp:
2077         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
2078         * platform/graphics/ca/GraphicsLayerCA.cpp:
2079         (WebCore::GraphicsLayer::create): Use adoptPtr.
2080         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
2081         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
2082         * rendering/RenderBlock.cpp:
2083         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
2084         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
2085         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
2086         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
2087         * rendering/RenderLayerBacking.cpp:
2088         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
2089         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
2090         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
2091         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
2092         * rendering/RenderLayerCompositor.cpp:
2093         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
2094         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
2095         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
2096         * rendering/style/StyleRareNonInheritedData.cpp:
2097         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
2098         explicit initializations of OwnPtr members to 0. Use adoptPtr.
2099         * workers/SharedWorkerContext.cpp:
2100         (WebCore::createConnectEvent): Use adoptPtr.
2101         * workers/Worker.cpp:
2102         (WebCore::Worker::notifyFinished): Use nullptr.
2103
2104 2011-04-27  Enrica Casucci  <enrica@apple.com>
2105
2106         Reviewed by Darin Adler.
2107
2108         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
2109         https://bugs.webkit.org/show_bug.cgi?id=59251
2110         <rdar://problem/9327044>
2111
2112         When we are looking for wrapping elements that are presentational, we should
2113         include elements that have a non transparent background color only if they
2114         are not blocks.
2115
2116         Test: editing/pasteboard/do-not-copy-body-color.html
2117
2118         * editing/markup.cpp:
2119         (WebCore::isElementPresentational):
2120
2121 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
2122
2123         Reviewed by Antti Koivisto.
2124
2125         Teach sub-selector chains about shadow descendants
2126         https://bugs.webkit.org/show_bug.cgi?id=58342
2127
2128         The primary change is to the logic of parsing specifiers:
2129         1) The shadow descendant selectors (those specifiers that are unknown
2130         pseudo element selectors) are always kept at the top of the chain.
2131         2) The sub-selectors after shadow descendant selectors are stashed right
2132         behind the sub-selector, but not at the end of the chain.
2133         3) Other sub-selectors are appended at the end of the chain.
2134
2135         * css/CSSGrammar.y: Changed specifier_list collection to use new
2136             CSSParser::updateSpecifier helper.
2137         * css/CSSParser.cpp:
2138         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
2139             look for the last ShadowDescendant relation in the chain of selectors,
2140             because the next selector after it is the one that should get the
2141             element name.
2142         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
2143             CSSGrammar.y. The new logic adjusts the selector chain to allow
2144             shadow descendant selectors have sub-selectors (and have multiple shadow
2145             descendants in the chain).
2146         * css/CSSParser.h: Added decl.
2147         * css/CSSParserValues.cpp:
2148         (WebCore::CSSParserSelector::insertTagHistory): Added.
2149         (WebCore::CSSParserSelector::appendTagHistory): Aded.
2150         * css/CSSParserValues.h: Added decls.
2151         * css/CSSStyleSelector.cpp:
2152         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
2153             shadow descendant selector match check, since now there could be many
2154             of them in the selector chain.
2155
2156 2011-04-20  Adrienne Walker  <enne@google.com>
2157
2158         Reviewed by Kenneth Russell.
2159
2160         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
2161         https://bugs.webkit.org/show_bug.cgi?id=59020
2162
2163         mapRect is the incorrect transform here.  The parent scissor rect
2164         needs to be projected into layer space instead.
2165
2166         Test: compositing/flat-with-transformed-child.html
2167
2168         * platform/graphics/chromium/LayerRendererChromium.cpp:
2169         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2170
2171 2011-04-27  Pratik Solanki  <psolanki@apple.com>
2172
2173         Reviewed by Antti Koivisto.
2174
2175         Part of WebCore should use CFNetwork-based loader on Mac
2176         https://bugs.webkit.org/show_bug.cgi?id=51836
2177
2178         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
2179         * platform/mac/SoftLinking.h:
2180         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
2181
2182 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
2183
2184         Reviewed by Antti Koivisto.
2185
2186         Cleanup CSSStyleApplyProperty.cpp
2187         https://bugs.webkit.org/show_bug.cgi?id=59623
2188
2189         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
2190         Use typedefs instead of repating the function pointer declarations in a few places.
2191
2192         * css/CSSStyleApplyProperty.cpp:
2193         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
2194         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
2195         (WebCore::ApplyPropertyColor::applyInheritValue):
2196         (WebCore::ApplyPropertyColor::applyInitialValue):
2197         (WebCore::ApplyPropertyColor::applyValue):
2198         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2199
2200 2011-04-27  Dan Bernstein  <mitz@apple.com>
2201
2202         Reviewed by Anders Carlsson.
2203
2204         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
2205         https://bugs.webkit.org/show_bug.cgi?id=59622
2206
2207         Test: fast/borders/border-image-trumps-radius.html
2208
2209         * rendering/RenderBox.cpp:
2210         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
2211         image, then border radius is ignored, so no bleed avoidance is needed.
2212         * rendering/RenderObject.cpp:
2213         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
2214         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
2215         * rendering/RenderObject.h:
2216
2217 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2218
2219         Reviewed by Xan Lopez.
2220
2221         [GTK] editing/pasteboard/copy-standalone-image.html fails
2222         https://bugs.webkit.org/show_bug.cgi?id=53645
2223
2224         When writing an image to the clipboard, also write the URL and title
2225         into the markup and URL portion. This change also abstracts a helper
2226         imageToMarkup into markup.{cpp/h} from several different locations
2227         throughout the platform layer.
2228
2229         * editing/markup.h: Added new function definition.
2230         * editing/markup.cpp:
2231         (WebCore::imageToMarkup): Add this function which turns an image URL 
2232         and element into some markup representing that image, while preserving
2233         non-src attributes.
2234         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
2235         to markup.cpp.
2236         * platform/gtk/PasteboardGtk.cpp:
2237         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
2238         image URL for a variety of image tag types.
2239         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
2240         markup and URL portions of the clipboard. This will ensure that images
2241         paste properly back into WebKit.
2242         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
2243         one from markup.h
2244
2245 2011-04-27  Steve Block  <steveblock@google.com>
2246
2247         Reviewed by David Levin.
2248
2249         Remove Android build system
2250         https://bugs.webkit.org/show_bug.cgi?id=48111
2251
2252         This is to avoid the maintenance burden until the Android port is
2253         fully upstreamed.
2254
2255         No new tests, build change only.
2256
2257         * Android.derived.jscbindings.mk: Removed.
2258         * Android.derived.mk: Removed.
2259         * Android.derived.v8bindings.mk: Removed.
2260         * Android.jscbindings.mk: Removed.
2261         * Android.mk: Removed.
2262         * Android.v8bindings.mk: Removed.
2263
2264 2011-04-27  Darin Adler  <darin@apple.com>
2265
2266         Reviewed by Sam Weinig.
2267
2268         Somehow about:blank gets into the icon database
2269         https://bugs.webkit.org/show_bug.cgi?id=58067
2270         rdar://problem/6751446
2271
2272         Implemented the policy Brady suggested, where only http and https URLs can
2273         be associated with and icon, guarding both on the way in to the database,
2274         and on the way out.
2275
2276         * loader/icon/IconDatabase.cpp:
2277         (WebCore::pageCanHaveIcon): Added.
2278         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
2279         instead of just checking for an empty URL.
2280         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
2281         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
2282         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
2283         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
2284         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
2285         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
2286         two separate assertions and added a third.
2287         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
2288
2289         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
2290         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
2291         overloaded it to work on both UChar and char, and added an assertion to it.
2292         Also moved this to the top of the file and made the UChar version usable
2293         in the shared code used even by Google.
2294         (WebCore::KURL::invalidate): Updated for name change.
2295         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
2296         toASCIILower since it's faster.
2297         (WebCore::KURL::parse): Updated for name changes.
2298         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
2299         since it's faster.
2300         (WebCore::protocolIsInHTTPFamily): Added.
2301
2302         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
2303         to protocolIsInHTTPFamily and added a version that works on a string.
2304         Kept the old name as an inline function so we don't have to rename
2305         all the cal sites now.
2306
2307         * platform/KURLGoogle.cpp: Renamed as above.
2308         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
2309         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
2310         (WebCore::KURLGooglePrivate::setAscii): Ditto.
2311         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
2312         (WebCore::KURLGooglePrivate::copyTo): Ditto.
2313         (WebCore::KURL::KURL): Ditto.
2314         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
2315         (WebCore::KURL::invalidate): Ditto.
2316         * platform/KURLGooglePrivate.h: Ditto.
2317
2318         * WebCore.exp.in: Updated for above changes.
2319
2320 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2321
2322         Reviewed by Pavel Feldman.
2323
2324         Web Inspector: browser crash on evaluation of 'throw undefined'
2325         https://bugs.webkit.org/show_bug.cgi?id=59611
2326
2327         Test: inspector/console/console-eval-throw-undefined.html
2328
2329         * inspector/InjectedScriptSource.js: use try/catch to protect from
2330         exception during conversion of another exception to string.
2331
2332 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2333
2334         Reviewed by Yury Semikhatsky.
2335
2336         Web Inspector: clicking bookmarklet multiplies resources panel entries.
2337         https://bugs.webkit.org/show_bug.cgi?id=59590
2338
2339         * inspector/front-end/ResourceTreeModel.js:
2340         (WebInspector.ResourceTreeModel):
2341         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2342         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2343         * inspector/front-end/ResourcesPanel.js:
2344         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
2345         (WebInspector.FrameTreeElement):
2346         (WebInspector.FrameTreeElement.prototype.appendResource):
2347         * inspector/front-end/inspector.js:
2348         (WebInspector.frontendReused):
2349
2350 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2351
2352         Reviewed by Yury Semikhatsky.
2353
2354         Web Inspector: opening bookmarklet disconnects DOM agent.
2355         https://bugs.webkit.org/show_bug.cgi?id=59588
2356
2357         * inspector/InspectorDOMAgent.cpp:
2358         (WebCore::InspectorDOMAgent::setDocument):
2359
2360 2011-04-27  Hans Wennborg  <hans@chromium.org>
2361
2362         Reviewed by Tony Gentilcore.
2363
2364         IndexedDB: Fix compiler warnings about uninitialized variables
2365         https://bugs.webkit.org/show_bug.cgi?id=59599
2366
2367         Build fix. No new tests.
2368
2369         * storage/IDBLevelDBBackingStore.cpp:
2370         (WebCore::getNewObjectStoreId):
2371         (WebCore::getNewIndexId):
2372
2373 2011-04-26  Hans Wennborg  <hans@chromium.org>
2374
2375         Reviewed by Tony Gentilcore.
2376
2377         IndexedDB: Move LevelDB key coding routines to separate file
2378         https://bugs.webkit.org/show_bug.cgi?id=59452
2379
2380         Move all routines concerned with encoding, decoding and comparison of
2381         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
2382         IDBLevelDBCoding.cpp.
2383
2384         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
2385         allow for unit testing of the coding routines.
2386
2387         No new functionality, no new tests.
2388
2389         * WebCore.gypi:
2390         * storage/IDBLevelDBBackingStore.cpp:
2391         (WebCore::getInt):
2392         (WebCore::putInt):
2393         (WebCore::getString):
2394         (WebCore::putString):
2395         (WebCore::compareKeys):
2396         (WebCore::compareIndexKeys):
2397         (WebCore::Comparator::compare):
2398         (WebCore::setUpMetadata):
2399         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
2400         (WebCore::getNewDatabaseId):
2401         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
2402         (WebCore::IDBLevelDBBackingStore::getObjectStores):
2403         (WebCore::getNewObjectStoreId):
2404         (WebCore::IDBLevelDBBackingStore::createObjectStore):
2405         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
2406         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
2407         (WebCore::getNewVersionNumber):
2408         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
2409         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
2410         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
2411         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
2412         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
2413         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
2414         (WebCore::IDBLevelDBBackingStore::getIndexes):
2415         (WebCore::getNewIndexId):
2416         (WebCore::IDBLevelDBBackingStore::createIndex):
2417         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
2418         (WebCore::versionExists):
2419         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
2420         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
2421         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
2422         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
2423         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
2424         * storage/IDBLevelDBCoding.cpp: Added.
2425         (WebCore::IDBLevelDBCoding::encodeByte):
2426         (WebCore::IDBLevelDBCoding::maxIDBKey):
2427         (WebCore::IDBLevelDBCoding::minIDBKey):
2428         (WebCore::IDBLevelDBCoding::encodeInt):
2429         (WebCore::IDBLevelDBCoding::decodeInt):
2430         (WebCore::IDBLevelDBCoding::encodeVarInt):
2431         (WebCore::IDBLevelDBCoding::decodeVarInt):
2432         (WebCore::IDBLevelDBCoding::encodeString):
2433         (WebCore::IDBLevelDBCoding::decodeString):
2434         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
2435         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
2436         (WebCore::IDBLevelDBCoding::encodeDouble):
2437         (WebCore::IDBLevelDBCoding::decodeDouble):
2438         (WebCore::IDBLevelDBCoding::encodeIDBKey):
2439         (WebCore::IDBLevelDBCoding::decodeIDBKey):
2440         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
2441         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
2442         (WebCore::IDBLevelDBCoding::compare):
2443         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
2444         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
2445         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
2446         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
2447         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
2448         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
2449         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
2450         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
2451         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
2452         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
2453         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
2454         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
2455         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
2456         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
2457         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
2458         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
2459         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
2460         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
2461         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
2462         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
2463         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
2464         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
2465         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
2466         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
2467         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
2468         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
2469         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
2470         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
2471         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
2472         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
2473         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
2474         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
2475         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
2476         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
2477         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
2478         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
2479         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
2480         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
2481         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
2482         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
2483         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
2484         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
2485         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
2486         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
2487         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
2488         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
2489         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
2490         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
2491         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
2492         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
2493         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
2494         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
2495         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
2496         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
2497         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
2498         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
2499         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
2500         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
2501         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
2502         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
2503         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
2504         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
2505         * storage/IDBLevelDBCoding.h: Added.
2506         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
2507         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
2508         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
2509         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
2510         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
2511
2512 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2513
2514         Reviewed by Pavel Feldman.
2515
2516         Web Inspector: expose exception details when script is paused on exception
2517         https://bugs.webkit.org/show_bug.cgi?id=59591
2518
2519         When script is paused on an exception, the exception value is added as <exception>
2520         property in the local scope and the breakpoint details message says
2521         "Paused on excepion: '<exception to strin value>'."
2522
2523         * English.lproj/localizedStrings.js:
2524         * inspector/front-end/ScopeChainSidebarPane.js:
2525         (WebInspector.ScopeChainSidebarPane.prototype.update):
2526         * inspector/front-end/ScriptsPanel.js:
2527         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
2528         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
2529
2530 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
2531
2532         Reviewed by Pavel Feldman.
2533
2534         Web Inspector: [protocol] Paused event should expose exception value that caused it
2535         https://bugs.webkit.org/show_bug.cgi?id=58996
2536
2537         Debug.pause event now contains an optional reference to the exception
2538         object in case script execution is paused on a JavaScript exception.
2539
2540         Also JavaScript call frames are passed directly into the injected script when
2541         we need to wrap them for passing to the front-end. This change breaks cyclic
2542         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
2543
2544         * bindings/js/JSInjectedScriptHostCustom.cpp:
2545         * bindings/js/ScriptDebugServer.cpp:
2546         (WebCore::ScriptDebugServer::dispatchDidPause):
2547         * bindings/js/ScriptDebugServer.h:
2548         * bindings/v8/ScriptDebugServer.cpp:
2549         (WebCore::ScriptDebugServer::breakProgram):
2550         (WebCore::ScriptDebugServer::editScriptSource):
2551         (WebCore::ScriptDebugServer::breakProgramCallback):
2552         (WebCore::ScriptDebugServer::handleV8DebugEvent):
2553         * bindings/v8/ScriptDebugServer.h:
2554         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2555         * inspector/InjectedScript.cpp:
2556         (WebCore::InjectedScript::evaluateOnCallFrame):
2557         (WebCore::InjectedScript::wrapCallFrames):
2558         * inspector/InjectedScript.h:
2559         * inspector/InjectedScriptHost.cpp:
2560         * inspector/InjectedScriptHost.h:
2561         (WebCore::InjectedScriptHost::init):
2562         * inspector/InjectedScriptHost.idl:
2563         * inspector/InjectedScriptSource.js:
2564         (.):
2565         * inspector/Inspector.json:
2566         * inspector/InspectorAgent.cpp:
2567         (WebCore::InspectorAgent::InspectorAgent):
2568         * inspector/InspectorDebuggerAgent.cpp:
2569         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
2570         (WebCore::InspectorDebuggerAgent::currentCallFrames):
2571         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
2572         (WebCore::InspectorDebuggerAgent::didPause):
2573         (WebCore::InspectorDebuggerAgent::didContinue):
2574         (WebCore::InspectorDebuggerAgent::clear):
2575         * inspector/InspectorDebuggerAgent.h:
2576         * inspector/ScriptDebugListener.h:
2577         * inspector/WorkerInspectorController.cpp:
2578         (WebCore::WorkerInspectorController::WorkerInspectorController):
2579
2580 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2581
2582         Reviewed by Yury Semikhatsky.
2583
2584         Web Inspector: implement incremental CSS editing in the structure view.
2585         https://bugs.webkit.org/show_bug.cgi?id=59455
2586
2587         * inspector/front-end/StylesSidebarPane.js:
2588         (WebInspector.StylePropertyTreeElement.prototype):
2589
2590 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
2591
2592         Reviewed by Eric Seidel.
2593
2594         Frame.h shouldn't include Document.h
2595         https://bugs.webkit.org/show_bug.cgi?id=59560
2596
2597         Frame can use a forward-declared Document if we move
2598         Frame::displayStringModifiedByEncoding's implementation out of the
2599         header.
2600                                 Size  #includes  Size * #includes
2601         Before: page/Frame.h:   0.746       653           487.138
2602                 dom/Document.h: 0.220      1306           287.320
2603         
2604         After:  page/Frame.h:   0.646       653           421.838
2605                 dom/Document.h: 0.220      1189           261.580
2606
2607         * WebCore.exp.in:
2608         * bindings/ScriptControllerBase.cpp:
2609         * bindings/generic/BindingSecurityBase.cpp:
2610         * bindings/v8/V8Proxy.cpp:
2611         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
2612         * dom/CharacterData.cpp:
2613         * dom/UserTypingGestureIndicator.cpp:
2614         * editing/chromium/SelectionControllerChromium.cpp:
2615         * inspector/InspectorDOMStorageResource.cpp:
2616         * inspector/InspectorInstrumentation.h:
2617         * loader/PingLoader.cpp:
2618         * loader/SubresourceLoader.cpp:
2619         * loader/appcache/DOMApplicationCache.cpp:
2620         * loader/cache/CachedResourceRequest.cpp:
2621         * page/Frame.cpp:
2622         (WebCore::Frame::displayStringModifiedByEncoding):
2623         * page/Frame.h:
2624         * page/Geolocation.cpp:
2625         * page/Location.cpp:
2626         * page/Navigator.cpp:
2627         * page/PageGroupLoadDeferrer.cpp:
2628         * page/PerformanceTiming.cpp:
2629         * xml/XSLTProcessorLibxslt.cpp:
2630
2631 2011-04-27  James Robinson  <jamesr@chromium.org>
2632
2633         Reviewed by Eric Seidel.
2634
2635         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2636         https://bugs.webkit.org/show_bug.cgi?id=59377
2637
2638         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
2639         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
2640
2641         * css/CSSStyleSelector.cpp:
2642         (WebCore::CSSStyleSelector::applyProperty):
2643         * page/animation/AnimationBase.cpp:
2644         (WebCore::blendFunc):
2645         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2646         (WebCore::PropertyWrapperShadow::blend):
2647         * rendering/style/RenderStyle.cpp:
2648         (WebCore::RenderStyle::setTextShadow):
2649         (WebCore::RenderStyle::setBoxShadow):
2650         * rendering/style/RenderStyle.h:
2651         (WebCore::InheritedFlags::textShadow):
2652         * rendering/style/ShadowData.cpp:
2653         (WebCore::ShadowData::ShadowData):
2654         * rendering/style/ShadowData.h:
2655         (WebCore::ShadowData::ShadowData):
2656         (WebCore::ShadowData::next):
2657         (WebCore::ShadowData::setNext):
2658         * rendering/style/StyleRareInheritedData.cpp:
2659         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2660         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2661         * rendering/style/StyleRareInheritedData.h:
2662         * rendering/style/StyleRareNonInheritedData.cpp:
2663         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2664
2665 2011-04-26  David Levin  <levin@chromium.org>
2666
2667         Reviewed by Eric Seidel.
2668
2669         Fix some strict PassOwnPtr issues in WebCore.
2670         https://bugs.webkit.org/show_bug.cgi?id=59563
2671
2672         * css/SVGCSSStyleSelector.cpp:
2673         (WebCore::CSSStyleSelector::applySVGProperty):
2674         * html/canvas/WebGLRenderingContext.cpp:
2675         (WebCore::WebGLRenderingContext::create):
2676         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
2677         * platform/text/TextCodecLatin1.cpp:
2678         (WebCore::newStreamingTextDecoderWindowsLatin1):
2679         * platform/text/TextCodecUTF16.cpp:
2680         (WebCore::newStreamingTextDecoderUTF16LE):
2681         (WebCore::newStreamingTextDecoderUTF16BE):
2682         * platform/text/TextCodecUserDefined.cpp:
2683         (WebCore::newStreamingTextDecoderUserDefined):
2684         * platform/text/mac/TextCodecMac.cpp:
2685         (WebCore::newTextCodecMac):
2686         * workers/Worker.cpp:
2687         (WebCore::Worker::notifyFinished):
2688
2689 2011-04-26  Justin Novosad  <junov@chromium.org>
2690
2691         Reviewed by Kenneth Russell.
2692
2693         [Chromium] Expose skia gpu canvas rendering as a runtime flag
2694         https://bugs.webkit.org/show_bug.cgi?id=58683
2695         Replace the SKIA_GPU compile flag by the pre-existing
2696         acceleratedDrawingEnabled flag. Most code changes are trivial:
2697         compile-time conditionals on SKIA_GPU were either replaced with
2698         a run-time check, or a compile time check on USE(SKIA) 
2699
2700         No new tests. Covered by existing tests.
2701
2702         * html/canvas/CanvasRenderingContext2D.cpp:
2703         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2704         * page/Page.cpp:
2705         (WebCore::Page::sharedGraphicsContext3D):
2706         Added check for the acceleratedDrawing flag.
2707         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2708         (WebCore::DrawingBuffer::DrawingBuffer):
2709         (WebCore::DrawingBuffer::publishToPlatformLayer):
2710         * platform/graphics/gpu/DrawingBuffer.h:
2711         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2712         (WebCore::SharedGraphicsContext3D::create):
2713         On Skia builds, this methos now receives a bool arg to turn on
2714         GPU-accelerated skia rendering
2715         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
2716         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2717         (WebCore::SharedGraphicsContext3D::grContext):
2718         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2719         * platform/graphics/skia/ImageSkia.cpp:
2720         (WebCore::computeResamplingMode):
2721         (WebCore::paintSkBitmap):
2722         (WebCore::Image::drawPattern):
2723         * platform/graphics/skia/PlatformContextSkia.cpp:
2724         (WebCore::PlatformContextSkia::PlatformContextSkia):
2725         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2726         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2727         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2728         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2729         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2730         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2731         (WebCore::PlatformContextSkia::markDirtyRect):
2732         * platform/graphics/skia/PlatformContextSkia.h:
2733         (WebCore::PlatformContextSkia::accelerationMode):
2734         (WebCore::PlatformContextSkia::useGPU):
2735         (WebCore::PlatformContextSkia::useSkiaGPU):
2736
2737 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2738
2739         Not reviewed: restore inspector test disabled in r84913.
2740
2741         Test: http/tests/inspector-enabled/dom-storage-open.html
2742
2743         * inspector/InspectorDOMStorageAgent.cpp:
2744         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2745
2746 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2747
2748         Reviewed by Tony Chang.
2749
2750         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2751         https://bugs.webkit.org/show_bug.cgi?id=59182
2752
2753         Use vertical offsets of the shaping results.
2754
2755         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2756
2757         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2758         (WebCore::ComplexTextController::ComplexTextController):
2759         Added initialization of m_startingY.
2760         (WebCore::ComplexTextController::nextScriptRun):
2761         Followed the change in handling positions.
2762         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2763         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2764         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2765         (WebCore::ComplexTextController::setGlyphPositions):
2766         Changed to use vertical offsets as same as horizontal offsets.
2767         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2768         Removed m_xPositions and Added m_positions and m_startingY.
2769         (WebCore::ComplexTextController::positions): Added.
2770         * platform/graphics/chromium/FontLinux.cpp:
2771         Followed the change in ComplexTextController.
2772         (WebCore::Font::drawComplexText): Ditto.
2773         (WebCore::Font::floatWidthForComplexText): Ditto.
2774         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2775         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2776         (WebCore::Font::selectionRectForComplexText): Ditto.
2777
2778 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2779
2780         Reviewed by Eric Seidel.
2781
2782         Root element should establish a new block formatting context
2783         https://bugs.webkit.org/show_bug.cgi?id=54573
2784
2785         Always expanding the root renderer to include overhanging floats.
2786
2787         Test: fast/block/float/float-overhangs-root.html
2788
2789         * rendering/RenderBlock.cpp:
2790         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2791
2792 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2793
2794         Reviewed by Andreas Kling.
2795
2796         [Qt] Improper rendering of <button> tag when it contains a <br>
2797         https://bugs.webkit.org/show_bug.cgi?id=50521
2798
2799         Test: platform/qt/fast/forms/button-line-break.html
2800
2801         * platform/qt/RenderThemeQt.cpp:
2802         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2803         (WebCore::RenderThemeQt::setButtonPadding):
2804
2805 2011-04-26  James Robinson  <jamesr@chromium.org>
2806
2807         Reviewed by Kenneth Russell.
2808
2809         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2810         https://bugs.webkit.org/show_bug.cgi?id=59572
2811
2812         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2813         when LayerRendererChromium was set.  We set this pointer every frame
2814         and should only reset the tiles if the new LayerRendererChromium is
2815         different from the old one (indicating a context loss), not just reset
2816         on every frame.
2817
2818         * platform/graphics/chromium/LayerTilerChromium.cpp:
2819         (WebCore::LayerTilerChromium::setLayerRenderer):
2820         * platform/graphics/chromium/LayerTilerChromium.h:
2821
2822 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2823
2824         Reviewed by Eric Seidel.
2825
2826         beginElement broken by setAttribute
2827         https://bugs.webkit.org/show_bug.cgi?id=26019
2828
2829         Test: svg/animations/animate-beginElementAt.svg
2830
2831         * svg/SVGAnimationElement.cpp:
2832         (WebCore::SVGAnimationElement::attributeChanged):
2833         Reset the animation state here as the rest of the code reads it and would still
2834         think we are animating when we are not.
2835
2836         * svg/animation/SVGSMILElement.h:
2837         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2838
2839 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2840
2841         Unreviewed, rolling out r84989.
2842         http://trac.webkit.org/changeset/84989
2843         https://bugs.webkit.org/show_bug.cgi?id=59566
2844
2845         REGRESSION (r84989): Lots of vertical text tests failing on
2846         windows (Requested by weinig on #webkit).
2847
2848         * platform/graphics/FontPlatformData.h:
2849         * platform/graphics/win/FontCacheWin.cpp:
2850         (WebCore::FontCache::getFontDataForCharacters):
2851         (WebCore::FontCache::createFontPlatformData):
2852         * platform/graphics/win/FontCustomPlatformData.cpp:
2853         (WebCore::FontCustomPlatformData::fontPlatformData):
2854         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2855         (WebCore::FontPlatformData::FontPlatformData):
2856         * platform/graphics/win/FontPlatformDataWin.cpp:
2857         (WebCore::FontPlatformData::FontPlatformData):
2858
2859 2011-04-26  Sam Weinig  <sam@webkit.org>
2860
2861         Reviewed by Eric Seidel.
2862
2863         Try again:
2864             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2865             https://bugs.webkit.org/show_bug.cgi?id=59310
2866
2867         * bindings/js/JSDOMBinding.h:
2868         (WebCore::DOMConstructorObject::DOMConstructorObject):
2869         * bindings/js/JSDOMWrapper.h:
2870         (WebCore::JSDOMWrapper::globalObject):
2871         (WebCore::JSDOMWrapper::scriptExecutionContext):
2872         (WebCore::JSDOMWrapper::createStructure):
2873         (WebCore::JSDOMWrapper::JSDOMWrapper):
2874         * bindings/scripts/CodeGeneratorJS.pm:
2875
2876 2011-04-26  Sam Weinig  <sam@webkit.org>
2877
2878         Reviewed by David Hyatt.
2879
2880         Remove Datagrid from the tree
2881         https://bugs.webkit.org/show_bug.cgi?id=59543
2882
2883         * Android.derived.jscbindings.mk:
2884         * Android.derived.v8bindings.mk:
2885         * Android.jscbindings.mk:
2886         * Android.v8bindings.mk:
2887         * CMakeLists.txt:
2888         * CodeGenerators.pri:
2889         * Configurations/FeatureDefines.xcconfig:
2890         * DerivedSources.cpp:
2891         * DerivedSources.make:
2892         * GNUmakefile.am:
2893         * GNUmakefile.list.am:
2894         * UseJSC.cmake:
2895         * WebCore.gypi:
2896         * WebCore.pro:
2897         * WebCore.vcproj/WebCore.vcproj:
2898         * WebCore.xcodeproj/project.pbxproj:
2899         * bindings/js/JSBindingsAllInOne.cpp:
2900         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2901         * bindings/js/JSDataGridDataSource.cpp: Removed.
2902         * bindings/js/JSDataGridDataSource.h: Removed.
2903         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2904         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2905         * bindings/v8/V8DataGridDataSource.h: Removed.
2906         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2907         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2908         * css/CSSStyleSelector.cpp:
2909         * css/CSSStyleSelector.h:
2910         * css/html.css:
2911         (input, textarea, keygen, select, button, isindex):
2912         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2913         * editing/htmlediting.cpp:
2914         (WebCore::canHaveChildrenForEditing):
2915         * features.pri:
2916         * html/DOMDataGridDataSource.cpp: Removed.
2917         * html/DOMDataGridDataSource.h: Removed.
2918         * html/DataGridColumn.cpp: Removed.
2919         * html/DataGridColumn.h: Removed.
2920         * html/DataGridColumn.idl: Removed.
2921         * html/DataGridColumnList.cpp: Removed.
2922         * html/DataGridColumnList.h: Removed.
2923         * html/DataGridColumnList.idl: Removed.
2924         * html/DataGridDataSource.h: Removed.
2925         * html/HTMLDataGridCellElement.cpp: Removed.
2926         * html/HTMLDataGridCellElement.h: Removed.
2927         * html/HTMLDataGridCellElement.idl: Removed.
2928         * html/HTMLDataGridColElement.cpp: Removed.
2929         * html/HTMLDataGridColElement.h: Removed.
2930         * html/HTMLDataGridColElement.idl: Removed.
2931         * html/HTMLDataGridElement.cpp: Removed.
2932         * html/HTMLDataGridElement.h: Removed.
2933         * html/HTMLDataGridElement.idl: Removed.
2934         * html/HTMLDataGridRowElement.cpp: Removed.
2935         * html/HTMLDataGridRowElement.h: Removed.
2936         * html/HTMLDataGridRowElement.idl: Removed.
2937         * html/HTMLElement.cpp:
2938         (WebCore::HTMLElement::ieForbidsInsertHTML):
2939         * html/HTMLElementsAllInOne.cpp:
2940         * html/HTMLTagNames.in:
2941         * page/DOMWindow.idl:
2942         * rendering/RenderBox.cpp:
2943         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2944         * rendering/RenderDataGrid.cpp: Removed.
2945         * rendering/RenderDataGrid.h: Removed.
2946         * rendering/RenderingAllInOne.cpp:
2947
2948 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2949
2950         Reviewed by Adele Peterson.
2951
2952         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2953         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2954
2955         This platform dependent patch makes WebKit (Windows) show the
2956         vertical writing text correctly.  Job was done by adding a prefix '@'
2957         in front of the font family name (Windows Only). No new tests added.
2958         Some layout tests images:
2959         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2960
2961         * platform/graphics/FontPlatformData.h:
2962         * platform/graphics/win/FontCacheWin.cpp:
2963         (WebCore::FontCache::getFontDataForCharacters):
2964         (WebCore::FontCache::createFontPlatformData):
2965         * platform/graphics/win/FontCustomPlatformData.cpp:
2966         (WebCore::FontCustomPlatformData::fontPlatformData):
2967         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2968         (WebCore::FontPlatformData::FontPlatformData):
2969         * platform/graphics/win/FontPlatformDataWin.cpp:
2970         (WebCore::FontPlatformData::FontPlatformData):
2971
2972 2011-04-26  Jer Noble  <jer.noble@apple.com>
2973
2974         Reviewed by Brady Eidson.
2975
2976         HTML5 video fullscreen transition causes an audio stutter
2977         https://bugs.webkit.org/show_bug.cgi?id=59544
2978
2979         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2980         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2981         layer to render it invisible, instead just set the layer as hidden.
2982
2983         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2984         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2985         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2986         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2987         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2988         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2989
2990 2011-04-26  Christian Dywan  <christian@lanedo.com>
2991
2992         Reviewed by Eric Seidel.
2993
2994         Extra separator after Select All in context menu
2995         https://bugs.webkit.org/show_bug.cgi?id=54092
2996
2997         * page/ContextMenuController.cpp: Move separator to non-GTK+
2998             port guards since it is for the spelling options menu
2999             which the GTK+ port doesn't use.
3000
3001 2011-04-26  James Robinson  <jamesr@chromium.org>
3002
3003         Reviewed by Kenneth Russell.
3004
3005         [chromium] Clear out LayerTilerChromium's tiles on lost context
3006         https://bugs.webkit.org/show_bug.cgi?id=59233
3007
3008         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
3009         no longer valid since they exist in the previous LayerRendererChromium.
3010
3011         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
3012
3013         * platform/graphics/chromium/LayerTilerChromium.h:
3014         (WebCore::LayerTilerChromium::setLayerRenderer):
3015
3016 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
3017
3018         Reviewed by Dirk Schulze.
3019
3020         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
3021         https://bugs.webkit.org/show_bug.cgi?id=57644
3022
3023         Manual test: plugins/windowed-in-iframe-2.html
3024
3025         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
3026         * platform/gtk/WidgetGtk.cpp:
3027         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
3028         * plugins/PluginView.h: Added helper method to set the allocation and clip.
3029         * plugins/gtk/PluginViewGtk.cpp:
3030         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
3031         the allocation immediately. Bring this method into sync with the implementation in
3032         the Qt port.
3033         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
3034         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
3035
3036 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
3037
3038         Reviewed by Eric Seidel.
3039
3040         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
3041         https://bugs.webkit.org/show_bug.cgi?id=58818
3042
3043         Prevent allocating scratch buffers larger than the target GdkDrawable
3044         when creating a WidgetRenderingContext. This prevents incredibly large
3045         widgets from crashing the X Server. This change also allowed greatly
3046         simplifying the way that the painting offset is calculated.
3047
3048         * platform/gtk/WidgetRenderingContext.cpp:
3049         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
3050         larger than the target GdkDrawable.
3051         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
3052         blit by looking at the location of the target rect itself, rather than delaying the
3053         calculation up to this point.
3054         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
3055         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
3056         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
3057         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
3058         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
3059         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
3060         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
3061         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
3062         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
3063         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
3064         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
3065         a member to store the IntSize mapping from the coordinates of the target to the coordinates
3066         of the scratch buffer.
3067
3068 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
3069
3070         Reviewed by Adam Barth.
3071
3072         Respect charset in handleDataURL
3073         https://bugs.webkit.org/show_bug.cgi?id=47746
3074
3075         Original patch by Kwang Yul Seo <skyul@company100.net>
3076
3077         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
3078         returns an empty string because encoding name is not specified.
3079
3080         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
3081
3082         This change fixes over 130 layout tests when running GTK port with cURL network backend.
3083
3084         * platform/network/DataURL.cpp:
3085         (WebCore::handleDataURL):
3086
3087 2011-04-26  Anders Carlsson  <andersca@apple.com>
3088
3089         Fix clang++ build.
3090
3091         You can never have too many casts!
3092
3093         * accessibility/mac/AccessibilityObjectWrapper.mm:
3094         (-[AccessibilityObjectWrapper position]):
3095         * editing/mac/SelectionControllerMac.mm:
3096         (WebCore::accessibilityConvertScreenRect):
3097
3098 2011-04-26  Chris Rogers  <crogers@google.com>
3099
3100         Reviewed by Kenneth Russell.
3101
3102         Fix web audio build on mac port
3103         https://bugs.webkit.org/show_bug.cgi?id=59355
3104
3105         No new tests since audio API is not yet implemented.
3106
3107         * WebCore.xcodeproj/project.pbxproj:
3108         * bindings/js/JSAudioContextCustom.cpp:
3109         (WebCore::JSAudioContext::visitChildren):
3110         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
3111         (WebCore::JSJavaScriptAudioNode::visitChildren):
3112         * webaudio/AudioContext.idl:
3113
3114 2011-04-26  Chris Rogers  <crogers@google.com>
3115
3116         Reviewed by Kenneth Russell.
3117
3118         Add FFTFrame implementation for FFmpeg
3119         https://bugs.webkit.org/show_bug.cgi?id=59408
3120
3121         No new tests since audio API is not yet implemented.
3122
3123         * WebCore.gyp/WebCore.gyp:
3124         * WebCore.gypi:
3125         * platform/audio/FFTFrame.h:
3126         * platform/audio/FFTFrameStub.cpp:
3127         * platform/audio/ffmpeg: Added.
3128         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
3129         (WebCore::FFTFrame::FFTFrame):
3130         (WebCore::FFTFrame::initialize):
3131         (WebCore::FFTFrame::cleanup):
3132         (WebCore::FFTFrame::~FFTFrame):
3133         (WebCore::FFTFrame::multiply):
3134         (WebCore::FFTFrame::doFFT):
3135         (WebCore::FFTFrame::doInverseFFT):
3136         (WebCore::FFTFrame::realData):
3137         (WebCore::FFTFrame::imagData):
3138         (WebCore::FFTFrame::getUpToDateComplexData):
3139         (WebCore::FFTFrame::contextForSize):
3140         * platform/audio/mac/FFTFrameMac.cpp:
3141         * webaudio/ConvolverNode.cpp:
3142
3143 2011-04-26  Jeff Miller  <jeffm@apple.com>
3144
3145         Add a newline at the end of SVGFEDropShadowElement.idl.
3146
3147         * svg/SVGFEDropShadowElement.idl:
3148
3149 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
3150
3151         Reviewed by Eric Seidel.
3152
3153         InlineBox.h shouldn't include RenderBR.h
3154         https://bugs.webkit.org/show_bug.cgi?id=59480
3155
3156         Per bug 59348 RenderBR.h is a "top header" by include * size, because
3157         InlineBox.h includes it. There's no reason why it has to.
3158
3159         * rendering/InlineBox.h:
3160         * rendering/InlineTextBox.cpp:
3161         * rendering/RenderBlock.h:
3162
3163 2011-04-26  Sam Weinig  <sam@webkit.org>
3164
3165         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
3166         I should do.
3167
3168         * bindings/js/JSDOMBinding.h:
3169         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3170         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3171         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3172         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3173         (WebCore::DOMConstructorObject::DOMConstructorObject):
3174         * bindings/js/JSDOMWrapper.h:
3175         (WebCore::JSDOMWrapper::JSDOMWrapper):
3176         * bindings/scripts/CodeGeneratorJS.pm:
3177
3178 2011-04-26  Sam Weinig  <sam@webkit.org>
3179
3180         Fix build.
3181
3182         * bindings/js/JSDOMWrapper.h:
3183         (WebCore::JSDOMWrapper::globalObject):
3184
3185 2011-04-26  Sam Weinig  <sam@webkit.org>
3186
3187         Roll r84945 back in with infinite recursion removed.
3188
3189         * bindings/js/JSDOMBinding.h:
3190         (WebCore::DOMConstructorObject::DOMConstructorObject):
3191         * bindings/js/JSDOMWrapper.h:
3192         (WebCore::JSDOMWrapper::globalObject):
3193         (WebCore::JSDOMWrapper::scriptExecutionContext):
3194         (WebCore::JSDOMWrapper::createStructure):
3195         (WebCore::JSDOMWrapper::JSDOMWrapper):
3196         * bindings/scripts/CodeGeneratorJS.pm:
3197
3198 2011-04-26  Sam Weinig  <sam@webkit.org>
3199
3200         Rollout previous patch. It broke stuff.
3201
3202         * bindings/js/JSDOMBinding.h:
3203         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3204         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3205         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3206         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3207         (WebCore::DOMConstructorObject::DOMConstructorObject):
3208         * bindings/js/JSDOMWrapper.h:
3209         (WebCore::JSDOMWrapper::JSDOMWrapper):
3210         * bindings/scripts/CodeGeneratorJS.pm:
3211
3212 2011-04-26  Sam Weinig  <sam@webkit.org>
3213
3214         Reviewed by Maciej Stachowiak.
3215
3216         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
3217         https://bugs.webkit.org/show_bug.cgi?id=59310
3218
3219         * bindings/js/JSDOMBinding.h:
3220         (WebCore::DOMConstructorObject::DOMConstructorObject):
3221         * bindings/js/JSDOMWrapper.h:
3222         (WebCore::JSDOMWrapper::globalObject):
3223         (WebCore::JSDOMWrapper::scriptExecutionContext):
3224         (WebCore::JSDOMWrapper::createStructure):
3225         (WebCore::JSDOMWrapper::JSDOMWrapper):
3226         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
3227
3228         * bindings/scripts/CodeGeneratorJS.pm:
3229         Make JSDOMWrapper the base class.
3230
3231 2011-04-26  Dan Bernstein  <mitz@apple.com>
3232
3233         Reviewed by Mark Rowe.
3234
3235         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
3236
3237         * Configurations/Base.xcconfig:
3238         * Configurations/CompilerVersion.xcconfig: Added.
3239
3240 2011-04-26  Adrienne Walker  <enne@google.com>
3241
3242         Reviewed by Geoffrey Garen.
3243
3244         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
3245         https://bugs.webkit.org/show_bug.cgi?id=59469
3246
3247         * platform/chromium/TraceEvent.h:
3248         (WebCore::internal::ScopeTracer::ScopeTracer):
3249
3250 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3251
3252         Reviewed by Oliver Hunt.
3253
3254         Nixed special finalizer handling for WebCore strings
3255         https://bugs.webkit.org/show_bug.cgi?id=59425
3256
3257         Not needed anymore, since weak handles have finalizers.
3258
3259         * WebCore.exp.in: Exports!
3260
3261         * bindings/js/DOMWrapperWorld.cpp:
3262         (WebCore::JSStringOwner::finalize):
3263         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
3264         so we don't need special treatment anymore.
3265
3266         * bindings/js/DOMWrapperWorld.h:
3267         (WebCore::JSStringOwner::JSStringOwner):
3268         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
3269         instead of a WeakGCMap, so we can specify a custom finalizer.
3270
3271         * bindings/js/JSDOMBinding.cpp:
3272         (WebCore::jsStringSlowCase):
3273         * bindings/js/JSDOMBinding.h:
3274         (WebCore::jsString): Updated for string map change.
3275
3276 2011-04-26  David Kilzer  <ddkilzer@apple.com>
3277
3278         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
3279
3280         Reviewed by Antti Koivisto.
3281
3282         To enable HTTP pipelining post-SnowLeopard, use this command:
3283
3284             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
3285
3286         * platform/network/cf/ResourceRequestCFNet.cpp:
3287         (WebCore::readBooleanPreference): Re-added.  Originally added in
3288         r76756 and removed in r84120.
3289         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
3290         HTTP pipelining if use default is set to true.  Added macro
3291         guards to match those in ResourceRequestMac.mm.
3292
3293 2011-04-26  Antti Koivisto  <antti@apple.com>
3294
3295         Reviewed by Adele Peterson.
3296
3297         Don't strip fragments from file: urls in memory cache
3298         https://bugs.webkit.org/show_bug.cgi?id=59463
3299         <rdar://problem/9231130>
3300
3301         Some clients expect file: resources to be unique based on fragment identifier. 
3302         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
3303
3304         Test: fast/loader/file-protocol-fragment.html
3305
3306         * loader/cache/MemoryCache.cpp:
3307         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
3308
3309 2011-04-26  David Levin  <levin@chromium.org>
3310
3311         Reviewed by Darin Adler.
3312
3313         Fix more strict OwnPtr in WebCore (round N).
3314         https://bugs.webkit.org/show_bug.cgi?id=59464
3315
3316         * dom/Document.cpp:
3317         (WebCore::Document::Document):
3318         (WebCore::Document::attach):
3319         * fileapi/FileReader.cpp:
3320         (WebCore::FileReader::terminate):
3321         * loader/DocumentThreadableLoader.cpp:
3322         (WebCore::DocumentThreadableLoader::preflightFailure):
3323         * workers/DefaultSharedWorkerRepository.cpp:
3324         (WebCore::SharedWorkerConnectTask::create):
3325         (WebCore::SharedWorkerScriptLoader::load):
3326
3327 2011-04-26  Ruben  <chromium@hybridsource.org>
3328
3329         Reviewed by Tony Chang.
3330
3331         Change linux ifdefs for Chromium to Unix instead, allowing
3332         new Unix ports to be enabled by default
3333         https://bugs.webkit.org/show_bug.cgi?id=59297
3334
3335         No new tests, just changing preprocessor defines.
3336
3337         * bindings/js/JSInspectorFrontendHostCustom.cpp:
3338         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
3339         * dom/SelectElement.cpp:
3340         * loader/cache/CachedFont.cpp:
3341         * page/EventHandler.cpp:
3342         * page/chromium/EventHandlerChromium.cpp:
3343         * platform/Scrollbar.cpp:
3344         * platform/chromium/PlatformBridge.h:
3345         * platform/graphics/chromium/FontPlatformData.h:
3346         * platform/graphics/skia/FontCustomPlatformData.cpp:
3347         * platform/graphics/skia/FontCustomPlatformData.h:
3348
3349 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3350
3351         Reviewed by Dan Bernstein.
3352
3353         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
3354         https://bugs.webkit.org/show_bug.cgi?id=49111
3355
3356         Even when the offset corresponds to a position visually left of the box
3357         and there aren't any inline boxes on the left, the previous/next position
3358         may still correspond to some position in the same line.
3359
3360         The bug was caused by our ignoring such cases. Fixed the bug by comparing
3361         previous/next position's inline box to the current box. If they match,
3362         then we stay on the same position because moving to the left visually at
3363         the left edge should not result in a position on the same line.
3364
3365         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
3366         the left edge or to the right edge, and a bug that WebKit could not move to
3367         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
3368
3369         Test cases are added to editing/selection/move-left-right.html
3370
3371         * editing/VisiblePosition.cpp:
3372         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
3373         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
3374
3375 2011-04-26  Gabor Loki  <loki@webkit.org>
3376
3377         Reviewed by Csaba Osztrogonác.
3378
3379         Speeding up SVG filters with multicore (SMP) support
3380         https://bugs.webkit.org/show_bug.cgi?id=43903
3381
3382         Some SVG filters execute a huge number of pixel manipulations, which
3383         cannot be sped up by graphics accelerators, since their algorithm is
3384         too complex. Using the power of Symmetric Multi Processing (SMP) we
3385         can split up a task to smaller (data independent) tasks, which can be
3386         executed independently.
3387
3388         The ParallelJobs framework provides a simple way for distributed
3389         programming. The framework is based on WebKit's threading infrastructure,
3390         Open Multi-Processing's (OpenMP) API, and libdispatch API.
3391
3392         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
3393         * platform/graphics/filters/FETurbulence.cpp:
3394         (WebCore::FETurbulence::PaintingData::PaintingData):
3395         (WebCore::FETurbulence::noise2D):
3396         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
3397         (WebCore::FETurbulence::fillRegion):
3398         (WebCore::FETurbulence::fillRegionWorker):
3399         (WebCore::FETurbulence::apply):
3400         * platform/graphics/filters/FETurbulence.h:
3401
3402 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3403
3404         Reviewed by Yury Semikhatsky.
3405
3406         Web Inspector: close button is off in docked mode on a mac.
3407         https://bugs.webkit.org/show_bug.cgi?id=59453
3408
3409         * inspector/front-end/inspector.css:
3410         (.toolbar-item.close-left):
3411
3412 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3413
3414         Reviewed by Yury Semikhatsky.
3415
3416         Web Inspector: New Style is not working (UI glitch)
3417         https://bugs.webkit.org/show_bug.cgi?id=59451
3418
3419         * inspector/InspectorDOMStorageAgent.cpp:
3420         (WebCore::InspectorDOMStorageAgent::setFrontend):
3421         * inspector/front-end/AuditRules.js:
3422         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
3423         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
3424         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
3425         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
3426         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
3427         * inspector/front-end/CSSStyleModel.js:
3428         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
3429         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
3430         (WebInspector.CSSStyleModel.prototype.addRule):
3431         (WebInspector.CSSStyleModel.prototype.addRule.callback):
3432         (WebInspector.CSSStyleModel.prototype._documentElementId):
3433         * inspector/front-end/DOMAgent.js:
3434         (WebInspector.DOMNode.prototype._addAttribute):
3435         (WebInspector.DOMNode.prototype.documentElement):
3436         * inspector/front-end/ResourceTreeModel.js:
3437         (WebInspector.PageDispatcher.prototype.frameDetached):
3438         * inspector/front-end/StylesSidebarPane.js:
3439         (WebInspector.StylesSidebarPane.prototype._createNewRule):
3440
3441 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3442
3443         Reviewed by Yury Semikhatsky.
3444
3445         Web Inspector: introduce DOMStorage::enable and disable.
3446         https://bugs.webkit.org/show_bug.cgi?id=59445
3447
3448         * inspector/Inspector.json:
3449         * inspector/InspectorAgent.cpp:
3450         (WebCore::InspectorAgent::InspectorAgent):
3451         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3452         * inspector/InspectorDOMStorageAgent.cpp:
3453         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
3454         (WebCore::InspectorDOMStorageAgent::restore):
3455         (WebCore::InspectorDOMStorageAgent::enable):
3456         (WebCore::InspectorDOMStorageAgent::disable):
3457         * inspector/InspectorDOMStorageAgent.h:
3458         (WebCore::InspectorDOMStorageAgent::create):
3459         * inspector/front-end/DOMStorage.js:
3460         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3461         * inspector/front-end/ResourcesPanel.js:
3462         (WebInspector.ResourcesPanel.prototype._reset):
3463         * inspector/front-end/inspector.js:
3464
3465 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3466
3467         Reviewed by Yury Semikhatsky.
3468
3469         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
3470         https://bugs.webkit.org/show_bug.cgi?id=59440
3471
3472         * inspector/Inspector.json:
3473         * inspector/InspectorAgent.cpp:
3474         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3475         * inspector/InspectorPageAgent.cpp:
3476         (WebCore::InspectorPageAgent::setFrontend):
3477         (WebCore::InspectorPageAgent::frameNavigated):
3478         * inspector/InspectorPageAgent.h:
3479         * inspector/front-end/AuditsPanel.js:
3480         (WebInspector.AuditsPanel):
3481         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
3482         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
3483         * inspector/front-end/CSSStyleModel.js:
3484         (WebInspector.CSSStyleModelResourceBinding):
3485         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
3486         * inspector/front-end/DOMBreakpointsSidebarPane.js:
3487         (WebInspector.DOMBreakpointsSidebarPane):
3488         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
3489         * inspector/front-end/DOMStorage.js:
3490         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3491         * inspector/front-end/ExtensionServer.js:
3492         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
3493         (WebInspector.ExtensionServer.prototype.initExtensions):
3494         * inspector/front-end/NetworkPanel.js:
3495  &n