30b5726f52c2932926c42370ba254bf1d9d49f1e
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-02-07  Chris Marrin  <cmarrin@apple.com>
2
3         Reviewed by Simon Fraser.
4
5         LayoutTests/animations/play-state.html has wrong behavior with accelerated compositing
6         https://bugs.webkit.org/show_bug.cgi?id=53513
7
8         The PlatformCAAnimation::create() function which took a pointer to another
9         PlatformCAAnimation was supposed to make a copy of that passed object.
10         But it was doing completely the wrong thing on Mac and was leaking an object
11         to boot. And the notion of copying an object using a static creation function
12         is wrong in the first place. So I changed it to a member copy() function
13         which would create a new PlatformCAAnimation which was a copy of 'this' and
14         return it. I changed the implementation on both Mac and Win to match.
15
16         This problem was not caught by DRT, even there is a specific test for it.
17         That test just verifies that the higher level logic is working 
18         properly, which it is. There's no practical way to find out if the
19         layer is currently animating. There is no logic which probes that
20         deeply into the layer mechanics.
21         
22         * platform/graphics/ca/GraphicsLayerCA.cpp:
23         * platform/graphics/ca/PlatformCAAnimation.h:
24         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
25         * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
26
27 2011-02-09  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
28
29         Unreviewed build fix.
30
31         [EFL] Remove double definition of ContextMenu.
32         https://bugs.webkit.org/show_bug.cgi?id=50762
33
34         When building with SHARED_CORE enabled, the symbols of ContextMenu
35         were both in webkit and webcore. This removes them from webcore and
36         shall be put back once the CROSS_PLATFORM_CONTEXT_MENUS is implemented
37         in EFL port.
38
39         No new tests because no new functionality.
40
41         * CMakeLists.txt:
42
43 2011-02-09  Adam Roben  <aroben@apple.com>
44
45         Windows Production build fix
46
47         * WebCore.vcproj/QTMovieWinCommon.vsprops: Link against
48         WebKitSystemInterface$(WebKitConfigSuffix).lib, not just WebKitSystemInterface.lib, so we
49         pick up the _debug variant when appropriate.
50
51 2011-02-09  Eric Seidel  <eric@webkit.org>
52
53         Reviewed by Adam Barth.
54
55         Hostnames should cannonicalize to lowercase (to match every other browser)
56         https://bugs.webkit.org/show_bug.cgi?id=54084
57
58         * platform/KURL.cpp:
59         (WebCore::KURL::parse):
60
61 2011-02-09  Peter Varga  <pvarga@webkit.org>
62
63
64         Reviewed by Gavin Barraclough.
65
66         Replace PCRE with Yarr in WebCore
67         https://bugs.webkit.org/show_bug.cgi?id=53496
68
69         No new tests needed.
70
71         * Android.jscbindings.mk:
72         * CMakeLists.txt:
73         * ForwardingHeaders/pcre/pcre.h: Removed.
74         * ForwardingHeaders/yarr/Yarr.h: Added.
75         * ForwardingHeaders/yarr/YarrInterpreter.h: Added.
76         * ForwardingHeaders/yarr/YarrPattern.h: Added.
77         * WebCore.gyp/WebCore.gyp:
78         * WebCore.pro:
79         * WebCore.vcproj/WebCore.vcproj:
80         * WebCore.vcproj/copyForwardingHeaders.cmd:
81         * platform/text/RegularExpression.cpp:
82         (WebCore::RegularExpression::Private::create):
83         (WebCore::RegularExpression::Private::Private):
84         (WebCore::RegularExpression::Private::compile):
85         (WebCore::RegularExpression::match):
86
87 2011-02-09  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
88
89         Reviewed by Eric Seidel.
90
91         [EFL] Add dummy functions for HTML5 Video's control UI
92         https://bugs.webkit.org/show_bug.cgi?id=53906
93
94         In WebKit EFL, there are no implementations for HTML5 control UI.
95         First, dummy functions are added.
96
97         * platform/efl/RenderThemeEfl.cpp:
98         (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet):
99         (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
100         (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
101         (WebCore::RenderThemeEfl::paintMediaMuteButton):
102         (WebCore::RenderThemeEfl::paintMediaPlayButton):
103         (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
104         (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
105         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
106         (WebCore::RenderThemeEfl::paintMediaSliderThumb):
107         (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
108         (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
109         (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
110         (WebCore::RenderThemeEfl::paintMediaCurrentTime):
111         * platform/efl/RenderThemeEfl.h:
112
113 2011-02-09  Eric Seidel  <eric@webkit.org>
114
115         Reviewed by Adam Barth.
116
117         Make WebKit's fragment cannonicalization match other browsers
118         https://bugs.webkit.org/show_bug.cgi?id=53850
119
120         This doesn't make us match perfectly, but it brings us closer.
121
122         * platform/KURL.cpp:
123         (WebCore::appendEscapingBadChars):
124         (WebCore::escapeAndAppendFragment):
125         (WebCore::KURL::parse):
126
127 2011-02-09  Hans Wennborg  <hans@chromium.org>
128
129         Reviewed by Jeremy Orlow.
130
131         IndexedDB: Cursors should skip deleted entries
132         https://bugs.webkit.org/show_bug.cgi?id=53690
133
134         Add test to check that the cursor skips deleted entries.
135
136         Test: storage/indexeddb/cursor-skip-deleted.html
137
138         * storage/IDBCursorBackendImpl.cpp:
139         (WebCore::IDBCursorBackendImpl::currentRowExists):
140         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
141         * storage/IDBCursorBackendImpl.h:
142
143 2011-02-08  Pavel Podivilov  <podivilov@chromium.org>
144
145         Reviewed by Yury Semikhatsky.
146
147         Web Inspector: script formatter should not create a worker for each script.
148         https://bugs.webkit.org/show_bug.cgi?id=54010
149
150         * inspector/front-end/ScriptFormatter.js:
151         (WebInspector.ScriptFormatter):
152         (WebInspector.ScriptFormatter.prototype._formatScript):
153         (WebInspector.ScriptFormatter.prototype._handleMessage):
154         (WebInspector.ScriptFormatter.prototype._handleError):
155
156 2011-02-08  Pavel Podivilov  <podivilov@chromium.org>
157
158         Reviewed by Pavel Feldman.
159
160         Web Inspector: sync uglifyjs parser files.
161         https://bugs.webkit.org/show_bug.cgi?id=54003
162
163         * inspector/front-end/UglifyJS/parse-js.js:
164         * inspector/front-end/UglifyJS/process.js:
165
166 2011-02-08  Ryosuke Niwa  <rniwa@webkit.org>
167
168         Reviewed by Darin Adler.
169
170         REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
171         https://bugs.webkit.org/show_bug.cgi?id=53196
172
173         The bug was caused by Editor::selectionComputedStyle's modifying typing style without making a copy,
174         and its removing non-inheritable properties from the typing style. Fixed the bug by making a copy
175         before making the modification and not removing non-inheritable properties.
176
177         Also fixed a bug in selectionStartCSSPropertyValue that it doesn't handle xx-small to -webkit-xxx-large
178         by extracting a function from StyleChange::extractTextStyles and calling it in both extractTextStyles
179         and selectionStartCSSPropertyValue.
180
181         Test: editing/style/query-typing-style.html
182
183         * editing/ApplyStyleCommand.cpp:
184         (WebCore::legacyFontSizeFromCSSValue): Extracted from StyleChange::extractTextStyles.
185         (WebCore::StyleChange::extractTextStyles): Calls legacyFontSizeFromCSSValue; this fixes the bug that
186         CSS values from xx-small through -webkit-xxx-large are not accounted.
187         * editing/ApplyStyleCommand.h:
188         * editing/Editor.cpp:
189         (WebCore::Editor::selectionStartCSSPropertyValue): Calls legacyFontSizeFromCSSValue.
190         (WebCore::Editor::selectionComputedStyle): Makes a copy before modifying typing style.
191         No longer calls removeNonEditingProperties on the copied typing style so that background-color property
192         is included when merged into the style.
193
194 2011-02-08  Sam Weinig  <sam@webkit.org>
195
196         Reviewed by Maciej Stachowiak.
197
198         REGRESSION (r76831): Subframes are printed blank
199         <rdar://problem/8945867>
200
201         * page/FrameView.cpp:
202         (WebCore::FrameView::paintOverhangAreas):
203         Don't paint overhangs when printing.
204
205 2011-02-07  Jeremy Orlow  <jorlow@chromium.org>
206
207         Reviewed by Nate Chapin.
208
209         Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
210         https://bugs.webkit.org/show_bug.cgi?id=53975
211
212         The third change in the series of overhauling IndexedDB's event model to match
213         the spec (at least the version in our heads and bugs).
214
215         Test: storage/indexeddb/transaction-event-propagation.html
216
217         * bindings/v8/V8DOMWrapper.cpp:
218         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
219         * dom/Event.cpp:
220         (WebCore::Event::isIDBAbortEvent):
221         (WebCore::Event::isIDBCompleteEvent):
222         * dom/Event.h:
223         * dom/EventTarget.cpp:
224         (WebCore::EventTarget::toIDBDatabase):
225         * dom/EventTarget.h:
226         * storage/IDBDatabase.cpp:
227         (WebCore::IDBDatabase::create):
228         (WebCore::IDBDatabase::IDBDatabase):
229         (WebCore::IDBDatabase::scriptExecutionContext):
230         (WebCore::IDBDatabase::eventTargetData):
231         (WebCore::IDBDatabase::ensureEventTargetData):
232         * storage/IDBDatabase.h:
233         (WebCore::IDBDatabase::toIDBDatabase):
234         (WebCore::IDBDatabase::refEventTarget):
235         (WebCore::IDBDatabase::derefEventTarget):
236         * storage/IDBDatabase.idl:
237         * storage/IDBRequest.cpp:
238         (WebCore::IDBRequest::onSuccess):
239         (WebCore::IDBRequest::dispatchEvent):
240         * storage/IDBTransaction.cpp:
241         (WebCore::IDBTransaction::backend):
242         (WebCore::IDBTransaction::db):
243         (WebCore::IDBTransaction::objectStore):
244         (WebCore::IDBTransaction::scriptExecutionContext):
245         (WebCore::IDBTransaction::dispatchEvent):
246         (WebCore::IDBTransaction::enqueueEvent):
247         * storage/IDBTransaction.h:
248         (WebCore::IDBTransaction::dispatchEvent):
249
250 2011-02-08  Kenneth Russell  <kbr@google.com>
251
252         Reviewed by James Robinson.
253
254         Add cache for GPU-accelerated path processing results
255         https://bugs.webkit.org/show_bug.cgi?id=45519
256
257         Adding a cache which holds the results of processing a path into
258         interior and exterior triangle meshes, according to the path
259         rendering algorithm from GPU Gems 3. No tests yet; will be tested
260         in conjunction with later code.
261
262         * platform/graphics/gpu/LoopBlinnPathCache.cpp: Added.
263         (WebCore::LoopBlinnPathCache::LoopBlinnPathCache):
264         (WebCore::LoopBlinnPathCache::~LoopBlinnPathCache):
265         (WebCore::LoopBlinnPathCache::addVertex):
266         (WebCore::LoopBlinnPathCache::clear):
267         (WebCore::LoopBlinnPathCache::addInteriorVertex):
268         (WebCore::LoopBlinnPathCache::numberOfInteriorEdgeVertices):
269         (WebCore::LoopBlinnPathCache::interiorEdgeVertices):
270         (WebCore::LoopBlinnPathCache::addInteriorEdgeVertex):
271         * platform/graphics/gpu/LoopBlinnPathCache.h: Added.
272         (WebCore::LoopBlinnPathCache::numberOfVertices):
273         (WebCore::LoopBlinnPathCache::vertices):
274         (WebCore::LoopBlinnPathCache::texcoords):
275         (WebCore::LoopBlinnPathCache::numberOfInteriorVertices):
276         (WebCore::LoopBlinnPathCache::interiorVertices):
277
278 2011-02-08  Zhenyao Mo  <zmo@google.com>
279
280         Reviewed by Kenneth Russell.
281
282         Rename GraphicsContext3D::WebGLEnumType
283         https://bugs.webkit.org/show_bug.cgi?id=45708
284
285         * html/canvas/WebGLProgram.cpp:
286         (WebCore::WebGLProgram::getAttachedShader):
287         * html/canvas/WebGLProgram.h:
288         * platform/graphics/GraphicsContext3D.h:
289
290 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
291
292         Unreviewed, rolling out r77980.
293         http://trac.webkit.org/changeset/77980
294         https://bugs.webkit.org/show_bug.cgi?id=54043
295
296         "Crashes on Windows and Linux..." (Requested by leviw on
297         #webkit).
298
299         * WebCore.exp.in:
300         * accessibility/AXObjectCache.cpp:
301         (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
302         * accessibility/AccessibilityObject.cpp:
303         (WebCore::startOfStyleRange):
304         (WebCore::endOfStyleRange):
305         * accessibility/AccessibilityRenderObject.cpp:
306         (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
307         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
308         (objectAndOffsetUnignored):
309         * dom/Position.cpp:
310         (WebCore::Position::upstream):
311         (WebCore::Position::downstream):
312         * dom/Range.cpp:
313         (WebCore::Range::editingStartPosition):
314         * editing/Editor.cpp:
315         (WebCore::Editor::canDeleteRange):
316         * editing/ReplaceSelectionCommand.cpp:
317         (WebCore::ReplaceSelectionCommand::doApply):
318         * editing/SelectionController.cpp:
319         (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
320         (WebCore::SelectionController::setSelectedRange):
321         * editing/TextIterator.cpp:
322         (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
323         * editing/TypingCommand.cpp:
324         (WebCore::TypingCommand::deleteKeyPressed):
325         * editing/VisiblePosition.cpp:
326         (WebCore::VisiblePosition::VisiblePosition):
327         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
328         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
329         (WebCore::VisiblePosition::canonicalPosition):
330         (WebCore::VisiblePosition::characterAfter):
331         (WebCore::VisiblePosition::localCaretRect):
332         (WebCore::makeRange):
333         (WebCore::startVisiblePosition):
334         (WebCore::endVisiblePosition):
335         (WebCore::setStart):
336         (WebCore::setEnd):
337         (WebCore::isFirstVisiblePositionInNode):
338         (WebCore::isLastVisiblePositionInNode):
339         * editing/VisiblePosition.h:
340         * editing/htmlediting.cpp:
341         (WebCore::firstInSpecialElement):
342         (WebCore::lastInSpecialElement):
343         (WebCore::visiblePositionBeforeNode):
344         (WebCore::visiblePositionAfterNode):
345         * editing/visible_units.cpp:
346         (WebCore::startPositionForLine):
347         (WebCore::endPositionForLine):
348         (WebCore::previousLinePosition):
349         (WebCore::nextLinePosition):
350         (WebCore::startOfParagraph):
351         (WebCore::endOfParagraph):
352         (WebCore::endOfBlock):
353         (WebCore::startOfDocument):
354         (WebCore::endOfDocument):
355         (WebCore::logicalStartPositionForLine):
356         (WebCore::logicalEndPositionForLine):
357         * page/DOMSelection.cpp:
358         (WebCore::DOMSelection::collapse):
359         (WebCore::DOMSelection::setBaseAndExtent):
360         (WebCore::DOMSelection::setPosition):
361         (WebCore::DOMSelection::extend):
362         * page/EventHandler.cpp:
363         (WebCore::EventHandler::handleMousePressEventSingleClick):
364         * rendering/RenderObject.cpp:
365         (WebCore::RenderObject::createVisiblePosition):
366         * rendering/RenderTextControl.cpp:
367         (WebCore::RenderTextControl::visiblePositionForIndex):
368         * svg/SVGTextContentElement.cpp:
369         (WebCore::SVGTextContentElement::selectSubString):
370
371 2011-02-08  Jia Pu  <jpu@apple.com>
372
373         Reviewed by Darin Adler.
374
375         VisibleSelection::setWithoutValidation() should allow caret selection.
376         https://bugs.webkit.org/show_bug.cgi?id=53943
377
378         Test: editing/undo/undo-paste-when-caret-is-not-in-range.html
379
380         * editing/VisibleSelection.cpp:
381         (WebCore::VisibleSelection::setWithoutValidation):
382
383 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
384
385         Reviewed by Xan Lopez.
386
387         [GTK] Remove the last remnants of the Mozilla theme drawing code
388         https://bugs.webkit.org/show_bug.cgi?id=54035
389
390         Remove all Mozilla theme drawing code.
391
392         No new tests. This change only removes dead code.
393
394         * GNUmakefile.am: Remove Mozilla files from the source list.
395         * platform/gtk/RenderThemeGtk.h: Remove Mozilla-theme-drawing-related methods
396         and add m_colormap to hold the current colormap of the widgets.
397         * platform/gtk/RenderThemeGtk2.cpp: Remove Mozilla code.
398         (WebCore::RenderThemeGtk::platformInit): Ditto.
399         (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto.
400         (WebCore::RenderThemeGtk::gtkContainer): Ditto.
401         * platform/gtk/ScrollbarThemeGtk2.cpp: Ditto.
402         * platform/gtk/WidgetRenderingContext.cpp: Ditto.
403         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Ditto.
404         * platform/gtk/WidgetRenderingContext.h: Ditto.
405         * platform/gtk/gtk2drawing.c: Removed.
406         * platform/gtk/gtkdrawing.h: Removed.
407
408 2011-02-08  Yael Aharon  <yael.aharon@nokia.com>
409
410         Reviewed by Antti Koivisto.
411
412         Crash when logging into gmail.com with frame flattening turned on.
413         https://bugs.webkit.org/show_bug.cgi?id=52449
414
415         Frame flattening algorithm requires that layout always starts from the main frame, since layout of
416         subframes impacts the layout of their parents. 
417         There are places in the code that call view->layout() not on the main frame.
418         Instead of changing all the callsites, I changed FrameView::layout()
419         to force layout from the main frame if frame flattening is enabled.
420         In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
421         Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(), 
422         because calling the from layout() leads to a crash in pages that have a selection in an iframe.
423
424         Tests: fast/frames/flattening/iframe-flattening-crash.html
425                fast/frames/flattening/iframe-flattening-selection-crash.html
426
427         * page/FrameView.cpp:
428         (WebCore::FrameView::layout):
429         (WebCore::FrameView::performPostLayoutTasks):
430
431 2011-02-08  Andy Estes  <aestes@apple.com>
432
433         Reviewed by Darin Adler.
434
435         <rdar://problem/8913952> REGRESSION (r76301): 'plaintext-only' must be
436         a supported contentEditable mode.
437         https://bugs.webkit.org/show_bug.cgi?id=54041
438
439         * html/HTMLElement.cpp:
440         (WebCore::HTMLElement::setContentEditable): Setting the contentEditable
441         attribute to 'plaintext-only' should not throw an exception.
442
443 2011-02-08  Dan Bernstein  <mitz@apple.com>
444
445         Reviewed by Simon Fraser.
446
447         RenderRubyRun::m_beingDestroyed is redundant
448         https://bugs.webkit.org/show_bug.cgi?id=54042
449
450         * rendering/RenderRubyRun.cpp:
451         (WebCore::RenderRubyRun::RenderRubyRun): Removed intialization of m_beingDestroyed.
452         (WebCore::RenderRubyRun::removeChild): Use the base class beingDestroyed(). 
453         * rendering/RenderRubyRun.h:
454
455 2011-02-08  Levi Weintraub  <leviw@chromium.org>
456
457         Reviewed by Ryosuke Niwa.
458
459         Stop instantiating legacy editing Positions in VisiblePosition
460         https://bugs.webkit.org/show_bug.cgi?id=52919
461
462         Changing VisiblePosition completely away from legacy positions.
463
464         No new tests since this is functionaly equivalent.
465
466         * WebCore.exp.in: Removing the legacy VisiblePosition constructor and
467         adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
468         outside of WebCore, they should be parent anchored.
469         * accessibility/AXObjectCache.cpp:
470         (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
471         * accessibility/AccessibilityObject.cpp:
472         (WebCore::startOfStyleRange):
473         (WebCore::endOfStyleRange):
474         * accessibility/AccessibilityRenderObject.cpp:
475         (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
476         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
477         (objectAndOffsetUnignored):
478         * dom/Position.cpp:
479         (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
480         (WebCore::Position::downstream): ditto
481         * dom/Range.cpp:
482         (WebCore::Range::editingStartPosition):
483         * editing/Editor.cpp:
484         (WebCore::Editor::canDeleteRange):
485         * editing/ReplaceSelectionCommand.cpp:
486         (WebCore::ReplaceSelectionCommand::doApply):
487         * editing/SelectionController.cpp:
488         (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
489         (WebCore::SelectionController::setSelectedRange):
490         * editing/TextIterator.cpp:
491         (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
492         * editing/TypingCommand.cpp:
493         (WebCore::TypingCommand::deleteKeyPressed):
494         * editing/VisiblePosition.cpp:
495         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
496         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
497         (WebCore::VisiblePosition::canonicalPosition):
498         (WebCore::VisiblePosition::characterAfter):
499         (WebCore::VisiblePosition::localCaretRect):
500         (WebCore::makeRange):
501         (WebCore::startVisiblePosition):
502         (WebCore::endVisiblePosition):
503         (WebCore::setStart):
504         (WebCore::setEnd):
505         (WebCore::isFirstVisiblePositionInNode):
506         (WebCore::isLastVisiblePositionInNode):
507         * editing/VisiblePosition.h:
508         (WebCore::VisiblePosition::VisiblePosition):
509         * editing/htmlediting.cpp:
510         (WebCore::firstInSpecialElement):
511         (WebCore::lastInSpecialElement):
512         (WebCore::visiblePositionBeforeNode):
513         (WebCore::visiblePositionAfterNode):
514         * editing/visible_units.cpp:
515         (WebCore::startPositionForLine):
516         (WebCore::endPositionForLine):
517         (WebCore::previousLinePosition):
518         (WebCore::nextLinePosition):
519         (WebCore::startOfParagraph):
520         (WebCore::endOfParagraph):
521         (WebCore::endOfBlock):
522         (WebCore::startOfDocument):
523         (WebCore::endOfDocument):
524         (WebCore::logicalStartPositionForLine):
525         (WebCore::logicalEndPositionForLine):
526         * page/DOMSelection.cpp:
527         (WebCore::DOMSelection::collapse):
528         (WebCore::DOMSelection::setBaseAndExtent):
529         (WebCore::DOMSelection::setPosition):
530         (WebCore::DOMSelection::extend):
531         * page/EventHandler.cpp:
532         (WebCore::EventHandler::handleMousePressEventSingleClick):
533         * rendering/RenderObject.cpp:
534         (WebCore::RenderObject::createVisiblePosition):
535         * rendering/RenderTextControl.cpp:
536         (WebCore::RenderTextControl::visiblePositionForIndex):
537         * svg/SVGTextContentElement.cpp:
538         (WebCore::SVGTextContentElement::selectSubString):
539
540 2011-02-08  Michael Saboff  <msaboff@apple.com>
541
542         JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
543         https://bugs.webkit.org/show_bug.cgi?id=53716
544
545         Changed ASSERT to be an if for the case where the RuntimeObject was
546         GC'ed before RootObject::invalidate is called.  In that case there is 
547         no need to remove the RuntimeObject from the RootObject.  The isValid()
548         call will be false in this case, but the RuntimeObject has already
549         been removed from the RootObject.  Added similar defensive code
550         in RootObject::removeRuntimeObject().
551
552         * bridge/jsc/BridgeJSC.cpp:
553         (JSC::Bindings::Instance::willDestroyRuntimeObject):
554         * bridge/runtime_root.cpp:
555         (JSC::Bindings::RootObject::removeRuntimeObject):
556
557 2011-02-08  Beth Dakin  <bdakin@apple.com>
558
559         Reviewed by Darin Adler.
560
561         Fix for <rdar://problem/8953365> CrashTracer: 14 
562         crashes in WebProcess at com.apple.WebCore: 
563         -[ScrollKnobAnimation setCurrentProgress:] + 258
564
565         This crash seems to happen when the animation is running
566         and a window is closed. If the ScrollAnimator is destroyed,
567         delegate calls for the animation can still run, so we have 
568         to make sure we inform the delegates when the ScrollAnimator 
569         is gone, and then we have to null-check it before we do 
570         anything with it.
571
572         Remove scrollbarPainterDelegate() since it's not used anymore.
573         * platform/mac/ScrollAnimatorMac.h:
574         * platform/mac/ScrollAnimatorMac.mm:
575         
576         Add null-checks for _animator
577         (-[ScrollbarPartAnimation setCurrentProgress:]):
578         (-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
579         (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
580         (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
581         (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
582         
583         New function to inform the delegates that the ScrollAnimator
584         is being destroyed.
585         (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
586         (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
587
588 2011-02-08  Adam Barth  <abarth@webkit.org>
589
590         Reviewed by Eric Seidel.
591
592         Remove orphan code from old parser
593         https://bugs.webkit.org/show_bug.cgi?id=53984
594
595         This code appears to be unused.
596
597         * html/HTMLParserErrorCodes.cpp:
598         * html/HTMLParserErrorCodes.h:
599         * html/HTMLParserQuirks.h:
600         * loader/EmptyClients.h:
601         * page/ChromeClient.h:
602
603 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
604
605         Reviewed by Gustavo Noronha Silva.
606
607         [GTK] Move scrollbar rendering out of gtk2drawing.c
608         https://bugs.webkit.org/show_bug.cgi?id=52836
609
610         Replace gtk2drawing.c scrollbar rendering with our own version. This
611         is the last use of the Mozilla theme drawing code.
612
613         No new tests. This should not change the rendering of the default
614         theme.
615
616         * platform/gtk/GtkVersioning.h: Add some more backported allocation setters.
617         * platform/gtk/RenderThemeGtk.h: Add a getter for the scrollbar widgets.
618         * platform/gtk/RenderThemeGtk2.cpp:  Initialize and add getters for scrollbar widgets.
619         (WebCore::RenderThemeGtk::platformInit): Ditto.
620         (WebCore::RenderThemeGtk::gtkHScrollbar): Ditto.
621         (WebCore::RenderThemeGtk::gtkVScrollbar): Ditto.
622         * platform/gtk/ScrollbarThemeGtk.cpp: 
623         (WebCore::ScrollbarThemeGtk::paint): We only repaint the scrolled
624         window background if we are repainting a button or the thumb. In that
625         case also repaint the track rect.
626         * platform/gtk/ScrollbarThemeGtk2.cpp: Port to WidgetRenderingContext.
627         (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Ditto.
628         (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto.
629         (WebCore::getWidgetForScrollbar): Ditto.
630         (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto.
631         (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
632         (WebCore::ScrollbarThemeGtk::paintThumb): Ditto.
633         (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
634         * platform/gtk/WidgetRenderingContext.cpp: Ditto.
635         (WebCore::WidgetRenderingContext::gtkPaintBox): Added an option which
636         also adjusts a widget allocation according to the paint rect. This is
637         necessary to properly draw scrollbar buttons.
638         * platform/gtk/WidgetRenderingContext.h: Ditto.
639
640 2011-02-08  Simon Fraser  <simon.fraser@apple.com>
641
642         Reviewed by Dan Bernstein.
643
644         Inset shadow with large offset renders incorrectly
645         https://bugs.webkit.org/show_bug.cgi?id=53882
646         
647         Fix an issue with inset shadows, when the shadow offset
648         was larger than the box size. In this case we'd fail to
649         fill the box with the shadow color.
650
651         Test: fast/box-shadow/inset-shadow-large-offset.html
652
653         * rendering/RenderBoxModelObject.cpp:
654         (WebCore::areaCastingShadowInHole): Return a rect that covers the area
655         which contributes to the inset shadow.
656         
657         (WebCore::RenderBoxModelObject::paintBoxShadow): Use areaCastingShadowInHole()
658         to compute the outerRect.
659
660 2011-02-08  Zhenyao Mo  <zmo@google.com>
661
662         Reviewed by Kenneth Russell.
663
664         drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
665         https://bugs.webkit.org/show_bug.cgi?id=54017
666
667         * html/canvas/WebGLRenderingContext.cpp:
668         (WebCore::WebGLRenderingContext::drawElements):
669
670 2011-01-28  Dimitri Glazkov  <dglazkov@chromium.org>
671
672         Reviewed by Darin Adler.
673
674         Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
675         https://bugs.webkit.org/show_bug.cgi?id=53190
676
677         This is the second part of refactoring the HTMLMediaElement to use new
678         shadow DOM. The changes are mainly mechanical, except for needing to
679         add a new method to RenderTheme, which indicates whether or not status
680         display is being used by it. Previously, we relied on existence of a cached
681         pseudo style.
682
683         Refactoring, covered by existing tests.
684
685         * css/CSSSelector.cpp:
686         (WebCore::CSSSelector::pseudoId): Removed now-unused enum values.
687         (WebCore::nameToPseudoTypeMap): Ditto.
688         (WebCore::CSSSelector::extractPseudoType): Ditto.
689         * css/CSSSelector.h: Ditto.
690         * html/shadow/MediaControls.cpp:
691         (WebCore::MediaControls::createPanel): Changed to use the newly-added MediaControlPanelElement.
692         (WebCore::MediaControls::createCurrentTimeDisplay): Changed to use the newly-added
693             MediaControlCurrentTimeDisplayElement.
694         (WebCore::MediaControls::createTimeRemainingDisplay): Changed to use the newly-added
695                 MediaControlTimeRemainingDisplayElement.
696         * rendering/MediaControlElements.cpp:
697         (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use the
698             standard style resolution.
699         (WebCore::MediaControlShadowRootElement::shadowPseudoId): Added.
700         (WebCore::MediaControlElement::MediaControlElement): Removed the switch statement
701             that is no longer necessary.
702         (WebCore::MediaControlElement::styleForElement): Changed to use the standard
703             style resolution.
704         (WebCore::MediaControlPanelElement::MediaControlPanelElement): Added.
705         (WebCore::MediaControlPanelElement::create): Added.
706         (WebCore::MediaControlPanelElement::displayType): Added.
707         (WebCore::MediaControlPanelElement::shadowPseudoId): Added.
708         (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
709             Removed PseudoId constructor arg.
710         (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):
711             Changed to use the newly-plumbed usesMediaControlStatusDisplay helper.
712         (WebCore::MediaControlTimelineContainerElement::displayType): Added.
713         (WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Added.
714         (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
715             Removed PseudoId constructor arg.
716         (WebCore::MediaControlVolumeSliderContainerElement::displayType): Added.
717         (WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Added.
718         (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
719             Removed PseudoId constructor arg.
720         (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Changed to
721             use the newly-plumbed usesMediaControlStatusDisplay helper.
722         (WebCore::MediaControlStatusDisplayElement::displayType): Added.
723         (WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Added.
724         (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
725             Removed PseudoId constructor arg.
726         (WebCore::MediaControlTimeRemainingDisplayElement::create): Added.
727         (WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Added.
728         (WebCore::MediaControlTimeRemainingDisplayElement::displayType): Added.
729         (WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Added.
730         (WebCore::MediaControlCurrentTimeDisplayElement::create): Added.
731         (WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Added.
732         (WebCore::MediaControlCurrentTimeDisplayElement::displayType): Added.
733         (WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Added.
734         * rendering/MediaControlElements.h: Added/changed defs accordingly.
735         * rendering/RenderTheme.h:
736         (WebCore::RenderTheme::usesMediaControlStatusDisplay): Added.
737         * rendering/RenderThemeMac.h: Added def.
738         * rendering/RenderThemeMac.mm:
739         (WebCore::RenderThemeMac::usesMediaControlStatusDisplay): Added.
740         * rendering/style/RenderStyleConstants.h: Removed now-unused enum values.
741
742 2011-02-08  Xiaomei Ji  <xji@chromium.org>
743
744         Reviewed by Dan Bernstein.
745
746         Fix pop-up button text not rendered correctly according to its direction
747         in <option>.
748         https://bugs.webkit.org/show_bug.cgi?id=53642
749  
750         In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi 
751         changes, set it needs layout.
752
753         Test: fast/text/international/pop-up-button-text-alignment-and-direction.html
754
755         * rendering/RenderMenuList.cpp:
756         (WebCore::RenderMenuList::adjustInnerStyle):
757
758 2011-02-08  Ilya Tikhonovsky  <loislo@chromium.org>
759
760         Unreviewed build fix for Qt-minimal.
761
762         * inspector/InspectorInstrumentation.h:
763         (WebCore::InspectorInstrumentation::hasFrontend):
764
765 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
766
767         Reviewed by Yury Semikhatsky.
768
769         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
770
771         https://bugs.webkit.org/show_bug.cgi?id=53169
772
773         All the Inspector API for WebCore has two parts.
774         The first one is InspectorInstrumentation for WebCore.
775         The second is InspectorController for WebKit.
776         InspectorAgent was produced by renaming original InspectorController.
777         This patch extracts WebKit related methods from InspectorAgent to InspectorController.
778
779         * WebCore.exp.in:
780         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
781         * html/HTMLDocument.cpp:
782         (WebCore::HTMLDocument::createParser):
783         * inspector/InspectorAgent.cpp:
784         (WebCore::InspectorAgent::InspectorAgent):
785         (WebCore::InspectorAgent::~InspectorAgent):
786         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
787         (WebCore::InspectorAgent::inspect):
788         (WebCore::InspectorAgent::handleMousePress):
789         (WebCore::InspectorAgent::didClearWindowObjectInWorld):
790         (WebCore::InspectorAgent::setFrontend):
791         (WebCore::InspectorAgent::disconnectFrontend):
792         (WebCore::InspectorAgent::resourceAgent):
793         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
794         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
795         (WebCore::InspectorAgent::populateScriptObjects):
796         (WebCore::InspectorAgent::pushDataCollectedOffline):
797         (WebCore::InspectorAgent::restoreProfiler):
798         (WebCore::InspectorAgent::startTimelineProfiler):
799         (WebCore::PostWorkerNotificationToFrontendTask::performTask):
800         (WebCore::InspectorAgent::didOpenDatabase):
801         (WebCore::InspectorAgent::didUseDOMStorage):
802         (WebCore::InspectorAgent::showAndEnableDebugger):
803         (WebCore::InspectorAgent::enableDebugger):
804         (WebCore::InspectorAgent::enabled):
805         * inspector/InspectorAgent.h:
806         (WebCore::InspectorAgent::frontend):
807         * inspector/InspectorController.cpp:
808         (WebCore::InspectorController::InspectorController):
809         (WebCore::InspectorController::~InspectorController):
810         (WebCore::InspectorController::setInspectorFrontendClient):
811         (WebCore::InspectorController::hasInspectorFrontendClient):
812         (WebCore::InspectorController::didClearWindowObjectInWorld):
813         (WebCore::InspectorController::startTimelineProfiler):
814         (WebCore::InspectorController::stopTimelineProfiler):
815         (WebCore::InspectorController::connectFrontend):
816         (WebCore::InspectorController::disconnectFrontend):
817         (WebCore::InspectorController::disconnectFrontendImpl):
818         (WebCore::InspectorController::show):
819         (WebCore::InspectorController::close):
820         (WebCore::InspectorController::restoreInspectorStateFromCookie):
821         (WebCore::InspectorController::evaluateForTestInFrontend):
822         (WebCore::InspectorController::drawNodeHighlight):
823         (WebCore::InspectorController::inspect):
824         (WebCore::InspectorController::enabled):
825         (WebCore::InspectorController::showPanel):
826         (WebCore::InspectorController::frontendLoaded):
827         (WebCore::InspectorController::timelineProfilerEnabled):
828         (WebCore::InspectorController::enableProfiler):
829         (WebCore::InspectorController::disableProfiler):
830         (WebCore::InspectorController::profilerEnabled):
831         (WebCore::InspectorController::debuggerEnabled):
832         (WebCore::InspectorController::showAndEnableDebugger):
833         (WebCore::InspectorController::disableDebugger):
834         (WebCore::InspectorController::startUserInitiatedProfiling):
835         (WebCore::InspectorController::stopUserInitiatedProfiling):
836         (WebCore::InspectorController::isRecordingUserInitiatedProfile):
837         (WebCore::InspectorController::setInspectorExtensionAPI):
838         (WebCore::InspectorController::resume):
839         (WebCore::InspectorController::hideHighlight):
840         (WebCore::InspectorController::dispatchMessageFromFrontend):
841         * inspector/InspectorController.h:
842         (WebCore::InspectorController::inspectorClient):
843         (WebCore::InspectorController::inspectedPage):
844         (WebCore::InspectorController::hasFrontend):
845         * inspector/InspectorFrontendClientLocal.cpp:
846         (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
847         * inspector/InspectorFrontendHost.cpp:
848         (WebCore::InspectorFrontendHost::setExtensionAPI):
849         * inspector/InspectorInstrumentation.cpp:
850         (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
851         (WebCore::InspectorInstrumentation::profilerEnabledImpl):
852         * inspector/InspectorInstrumentation.h:
853         (WebCore::InspectorInstrumentation::hasFrontend):
854         * loader/FrameLoader.cpp:
855         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
856
857 2011-02-08  George Wright  <gwright@rim.com>
858
859         Reviewed by Adam Barth.
860
861         https://bugs.webkit.org/show_bug.cgi?id=53949
862
863         Ensure that we pack the colour byte order correctly for Skia using
864         Skia's SkPackARGB32 function.
865
866         * platform/image-decoders/ImageDecoder.h:
867         (WebCore::ImageFrame::setRGBA):
868
869 2011-02-08  George Wright  <gwright@rim.com>
870
871         Reviewed by Darin Adler.
872
873         https://bugs.webkit.org/show_bug.cgi?id=53951
874
875         Ensure we do not pass (-1, -1) sized rects to ImageBuffer but instead
876         pass the full image dimensions.
877
878         * platform/graphics/GraphicsContext.cpp:
879         (WebCore::GraphicsContext::drawImageBuffer):
880
881 2011-02-08  Patrick Gansterer  <paroga@webkit.org>
882
883         Reviewed by Adam Roben.
884
885         [WIN] Add missing includes and forward declarations for DownloadBundle
886         https://bugs.webkit.org/show_bug.cgi?id=53881
887
888         * platform/network/cf/DownloadBundle.h:
889         * platform/network/win/DownloadBundleWin.cpp:
890         (WebCore::DownloadBundle::appendResumeData):
891
892 2011-02-08  Patrick Gansterer  <paroga@webkit.org>
893
894         Reviewed by Adam Roben.
895
896         [WIN] Add missing include in WKCAImageQueue
897         https://bugs.webkit.org/show_bug.cgi?id=53890
898
899         * platform/graphics/win/WKCAImageQueue.cpp:
900
901 2011-02-08  Patrick Gansterer  <paroga@webkit.org>
902
903         Reviewed by Adam Roben.
904
905         [WIN] Add missing includes and forward declarations for CFNetwork
906         https://bugs.webkit.org/show_bug.cgi?id=53883
907
908         * platform/network/cf/DNSCFNet.cpp:
909         * platform/network/cf/LoaderRunLoopCF.cpp:
910         * platform/network/cf/LoaderRunLoopCF.h:
911         * platform/network/cf/ProxyServerCFNet.cpp:
912         * platform/network/cf/SocketStreamHandle.h:
913         * platform/network/cf/SocketStreamHandleCFNet.cpp:
914
915 2011-02-08  Patrick Gansterer  <paroga@webkit.org>
916
917         Unreviewed WinCE build fix for r77870.
918
919         * platform/DragImage.cpp: Enable createDragImageForLink for WinCE.
920
921 2011-02-08  Pavel Feldman  <pfeldman@chromium.org>
922
923         Reviewed by Yury Semikhatsky.
924
925         Web Inspector: open network resource url in new tab upon double click.
926         https://bugs.webkit.org/show_bug.cgi?id=53930
927
928         * inspector/front-end/NetworkPanel.js:
929         (WebInspector.NetworkDataGridNode.prototype.createCells):
930         (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
931
932 2011-02-08  Yonathan Randolph  <yonathan@gmail.com>
933
934         Reviewed by Pavel Feldman.
935
936         Web Inspector: $x: any node should work in optional context parameter.
937         https://bugs.webkit.org/show_bug.cgi?id=50138
938
939         * inspector/InjectedScriptSource.js:
940
941 2011-02-08  Patrick Gansterer  <paroga@webkit.org>
942
943         Unreviewed WinCE build fix for r77870.
944
945         Remove the global namespace prefix from GlobalLock/GlobalUnlock.
946
947         * platform/win/ClipboardUtilitiesWin.cpp:
948
949 2011-02-08  Pavel Feldman  <pfeldman@chromium.org>
950
951         Not reviewed: re-apply r77924.
952
953         Test: inspector/console-api-on-call-frame.html
954
955         * inspector/InjectedScriptSource.js:
956         * inspector/front-end/ExtensionServer.js:
957         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
958
959 2011-02-08  Andreas Kling  <kling@webkit.org>
960
961         Reviewed by Tor Arne Vestbø.
962
963         REGRESSION(r77312): Unbreak TiledBackingStore.
964
965         Due to an off-by-one error, we were no longer rendering the
966         rightmost column and bottom row of tiles.
967
968         Covered by tst_QGraphicsWebView::widgetsRenderingThroughCache().
969
970         * platform/graphics/TiledBackingStore.cpp:
971         (WebCore::TiledBackingStore::invalidate):
972         (WebCore::TiledBackingStore::updateTileBuffers):
973         (WebCore::TiledBackingStore::paint):
974         (WebCore::TiledBackingStore::createTiles):
975
976 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
977
978         Unreviewed, rolling out r77924.
979         http://trac.webkit.org/changeset/77924
980         https://bugs.webkit.org/show_bug.cgi?id=53997
981
982         Breaks inspector tests. (Requested by pfeldman on #webkit).
983
984         * inspector/InjectedScriptSource.js:
985         (.):
986         ():
987
988 2011-02-08  Andrey Kosyakov  <caseq@chromium.org>
989
990         Reviewed by Pavel Feldman.
991
992         Web Inspector: [refacotring] merge InspectorAgent::willSendRequest() into InspectorResourceAgent
993         https://bugs.webkit.org/show_bug.cgi?id=53789
994          - perform UserAgent override via InspectorInstrumentation
995          - move adding extra request headers to InspectorResourceAgent
996          - simplified things in InspectorState
997
998         * inspector/Inspector.idl:
999         * inspector/InspectorAgent.cpp:
1000         (WebCore::InspectorAgent::disconnectFrontend):
1001         (WebCore::InspectorAgent::applyUserAgentOverride):
1002         * inspector/InspectorAgent.h:
1003         * inspector/InspectorInstrumentation.cpp:
1004         (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
1005         (WebCore::InspectorInstrumentation::willSendRequestImpl):
1006         * inspector/InspectorInstrumentation.h:
1007         (WebCore::InspectorInstrumentation::applyUserAgentOverride):
1008         * inspector/InspectorResourceAgent.cpp:
1009         (WebCore::InspectorResourceAgent::setExtraHeaders):
1010         (WebCore::InspectorResourceAgent::willSendRequest):
1011         * inspector/InspectorResourceAgent.h:
1012         * inspector/InspectorState.cpp:
1013         (WebCore::InspectorState::InspectorState):
1014         (WebCore::InspectorState::restoreFromInspectorCookie):
1015         (WebCore::InspectorState::updateCookie):
1016         (WebCore::InspectorState::setValue):
1017         (WebCore::InspectorState::getBoolean):
1018         (WebCore::InspectorState::getString):
1019         (WebCore::InspectorState::getLong):
1020         (WebCore::InspectorState::getObject):
1021         * inspector/InspectorState.h:
1022         (WebCore::InspectorState::setObject):
1023         * loader/FrameLoader.cpp:
1024         (WebCore::FrameLoader::userAgent):
1025
1026 2011-02-08  Pavel Feldman  <pfeldman@chromium.org>
1027
1028         Reviewed by Yury Semikhatsky.
1029
1030         Web Inspector: do not hide scope variables with command line api.
1031         https://bugs.webkit.org/show_bug.cgi?id=53497
1032
1033         Test: inspector/console-api-on-call-frame.html
1034
1035         * inspector/InjectedScriptSource.js:
1036
1037 2011-02-08  Pavel Feldman  <pfeldman@chromium.org>
1038
1039         Reviewed by Yury Semikhatsky.
1040
1041         Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
1042         https://bugs.webkit.org/show_bug.cgi?id=53914
1043
1044         * inspector/Inspector.idl:
1045         * inspector/InspectorAgent.cpp:
1046         (WebCore::InspectorAgent::reloadPage):
1047         * inspector/InspectorAgent.h:
1048         * inspector/front-end/AuditsPanel.js:
1049         (WebInspector.AuditsPanel.prototype._reloadResources):
1050         * inspector/front-end/ExtensionServer.js:
1051         (WebInspector.ExtensionServer.prototype._onReload):
1052         * inspector/front-end/inspector.js:
1053         (WebInspector.documentKeyDown):
1054
1055 2011-02-08  Antti Koivisto  <antti@apple.com>
1056
1057         Reviewed by Cameron Zwarich.
1058
1059         Skip over sibling selectors when collecting descendant selector hashes 
1060         https://bugs.webkit.org/show_bug.cgi?id=53987
1061         
1062         Skip instead of bailing out. This will allow optimizing some sibling selector cases.
1063
1064         * css/CSSStyleSelector.cpp:
1065         (WebCore::RuleData::RuleData):
1066         (WebCore::RuleData::collectIdentifierHashes):
1067         (WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
1068         * css/CSSStyleSelector.h:
1069
1070 2011-02-07  Cris Neckar  <cdn@chromium.org>
1071
1072         Reviewed by Jian Li.
1073
1074         Fix null deref in DOMURL
1075         https://bugs.webkit.org/show_bug.cgi?id=53811
1076
1077         Test: fast/files/domurl-script-execution-context-crash.html
1078
1079         * html/DOMURL.cpp:
1080         (WebCore::DOMURL::DOMURL):
1081
1082 2011-02-07  Mark Rowe  <mrowe@apple.com>
1083
1084         Fix the 32-bit build.
1085
1086         * platform/mac/ScrollAnimatorMac.mm:
1087         (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters.
1088         (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto.
1089
1090 2011-02-07  Xiyuan Xia  <xiyuan@chromium.org>
1091
1092         Reviewed by Tony Chang.
1093
1094         [Chromium] Select popup box does not align with select button when appearance is not "menulist".
1095         https://bugs.webkit.org/show_bug.cgi?id=53942
1096
1097         Added manual test select_webkit_appearance_off_popup_alignment.html.
1098
1099         * manual-tests/select_webkit_appearance_off_popup_alignment.html: Added.
1100         * platform/chromium/PopupMenuChromium.cpp:
1101         (WebCore::PopupListBox::layout):
1102
1103 2011-02-07  Aparna Nandyal  <aparna.nand@wipro.com>
1104
1105         Reviewed by Andreas Kling.
1106
1107         [Qt] - Context menu needs "Copy" as well when the selected text is a link.
1108         https://bugs.webkit.org/show_bug.cgi?id=40983
1109
1110         Added copy option for Qt platform if selection is a link. 
1111         Added a test in tst_qwebpage.cpp. 
1112
1113         * page/ContextMenuController.cpp:
1114         (WebCore::ContextMenuController::populate):
1115
1116 2011-02-07  Mike Reed  <reed@google.com>
1117
1118         Reviewed by Kenneth Russell.
1119
1120         Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend
1121         when drawing <canvas>. Disabled by default.
1122
1123         No new tests. existing canvas layouttests apply
1124
1125         * platform/graphics/chromium/DrawingBufferChromium.cpp:
1126         (WebCore::DrawingBuffer::publishToPlatformLayer):
1127         * platform/graphics/skia/PlatformContextSkia.cpp:
1128         (WebCore::GetGlobalGrContext):
1129         (WebCore::PlatformContextSkia::isPrinting):
1130         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
1131         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
1132
1133 2011-02-07  Jay Civelli  <jcivelli@chromium.org>
1134
1135         Reviewed by Darin Fisher.
1136
1137         Removing unused code from PopupMenuChromium.
1138         https://bugs.webkit.org/show_bug.cgi?id=53866
1139
1140        * platform/chromium/PopupMenuChromium.cpp:
1141         (WebCore::PopupListBox::layout):
1142         (WebCore::PopupMenuChromium::show):
1143         * platform/chromium/PopupMenuChromium.h:
1144
1145 2011-02-07  Kenichi Ishibashi  <bashi@chromium.org>
1146
1147         Reviewed by Andreas Kling.
1148
1149         HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
1150         https://bugs.webkit.org/show_bug.cgi?id=53791
1151
1152         Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged().
1153
1154         Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html
1155
1156         * html/HTMLOutputElement.cpp:
1157         (WebCore::HTMLOutputElement::childrenChanged): Calls super class's
1158         childrenChanged().
1159
1160 2011-02-07  Benjamin Poulain  <ikipou@gmail.com>
1161
1162         Reviewed by Kenneth Rohde Christiansen.
1163
1164         [Qt] cookiesEnabled could create the cookieJar on the wrong thread.
1165         https://bugs.webkit.org/show_bug.cgi?id=52289
1166
1167         Use the QtNAMThreadSafeProxy to make sure the cookie jar is created
1168         in the same thread as the QNetworkAccessManager.
1169
1170         * platform/network/qt/QtNAMThreadSafeProxy.cpp:
1171         (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy):
1172         (WebCore::QtNAMThreadSafeProxy::hasCookieJar):
1173         * platform/network/qt/QtNAMThreadSafeProxy.h:
1174         * platform/qt/CookieJarQt.cpp:
1175         (WebCore::cookiesEnabled):
1176
1177 2011-02-07  Alexey Marinichev  <amarinichev@chromium.org>
1178
1179         Reviewed by Kenneth Russell.
1180
1181         Hook up WebGraphicsContext3D::setContextLostCallback.
1182         https://bugs.webkit.org/show_bug.cgi?id=53722
1183
1184         Test: fast/canvas/webgl/context-lost.html, comment out the line with
1185         extension.loseContext() and kill the GPU process "Lose context"
1186         message shows up.
1187
1188         * html/canvas/WebGLRenderingContext.cpp:
1189         (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback):
1190         (WebCore::WebGLRenderingContextLostCallback::onContextLost):
1191         (WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback):
1192         (WebCore::WebGLRenderingContext::initializeNewContext):
1193         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
1194         * platform/graphics/GraphicsContext3D.h:
1195         (WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback):
1196         * platform/graphics/mac/GraphicsContext3DMac.mm:
1197         (WebCore::GraphicsContext3D::setContextLostCallback): stub
1198         * platform/graphics/qt/GraphicsContext3DQt.cpp:
1199         (WebCore::GraphicsContext3D::setContextLostCallback): stub
1200
1201 2011-02-07  Patrick Gansterer  <paroga@webkit.org>
1202
1203         Reviewed by Eric Seidel.
1204
1205         Add missing PaintInfo include in RenderThemeWin.cpp
1206         https://bugs.webkit.org/show_bug.cgi?id=53885
1207
1208         * rendering/RenderThemeWin.cpp:
1209
1210 2011-02-07  Qi Zhang  <qi.2.zhang@nokia.com>
1211
1212         Reviewed by Andreas Kling.
1213
1214         [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
1215         https://bugs.webkit.org/show_bug.cgi?id=52974
1216
1217         Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.
1218
1219         * page/ContextMenuController.cpp:
1220         (WebCore::ContextMenuController::contextMenuItemSelected):
1221         (WebCore::ContextMenuController::populate):
1222         (WebCore::ContextMenuController::checkOrEnableIfNeeded):
1223         * platform/ContextMenuItem.h:
1224         * platform/LocalizationStrategy.h:
1225         * platform/LocalizedStrings.cpp:
1226         (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
1227         * platform/LocalizedStrings.h:
1228
1229 2011-02-07  Kenichi Ishibashi  <bashi@chromium.org>
1230
1231         Reviewed by Kent Tamura.
1232
1233         HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
1234         https://bugs.webkit.org/show_bug.cgi?id=53970
1235
1236         Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form()
1237         return the right value.
1238
1239         Test: fast/dom/HTMLObjectElement/form/nested-form-element.html
1240
1241         * html/HTMLObjectElement.cpp:
1242         (WebCore::HTMLObjectElement::virtualForm): Added.
1243         * html/HTMLObjectElement.h: Added virtualForm().
1244
1245 2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
1246
1247         Unreviewed Leopard build fix.
1248
1249         * WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion.
1250         * platform/mac/DragImageMac.mm:
1251         (WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat.
1252
1253 2011-02-07  Enrica Casucci  <enrica@apple.com>
1254
1255         Reviewed by Sam Weinig.
1256
1257         Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874
1258
1259         When moving code from WebKit to WebCore we needed to move some additional
1260         functions previously in NSStringExtras.
1261         
1262         * WebCore.xcodeproj/project.pbxproj:
1263         * platform/mac/DragImageMac.mm:
1264         (WebCore::fontFromNSFont):
1265         (WebCore::canUseFastRenderer):
1266         (WebCore::widthWithFont):
1267         (WebCore::webkit_CGCeiling):
1268         (WebCore::drawAtPoint):
1269         (WebCore::drawDoubledAtPoint):
1270         (WebCore::createDragImageForLink):
1271
1272 2011-02-07  Lucas Forschler  <lforschler@apple.com>
1273
1274         Reviewed by Geoff Garen.
1275
1276         Tr #2, Fix the Leopard 32bit debug build.
1277         
1278         No new tests required.
1279
1280         * WebCore.xcodeproj/project.pbxproj:
1281         * accessibility/AccessibilityAllInOne.cpp:
1282
1283 2011-02-07  Beth Dakin  <bdakin@apple.com>
1284
1285         Reviewed by Sam Weinig.
1286
1287         Fix for <rdar://problem/8946961> Fix repaint problems
1288         with WKScrollbarPainter scrollers while resizing the window
1289
1290         Remove setPainterForPainterController() and 
1291         removePainterFromPainterController() since they aren't
1292         used anymore.
1293         * platform/mac/ScrollAnimatorMac.h:
1294         
1295         Return early if they alpha hasn't changed.
1296         * platform/mac/ScrollAnimatorMac.mm:
1297         (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
1298         (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
1299         
1300         If we're in a live resize, restore alpha to 1.
1301         (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
1302         (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
1303
1304 2011-02-07  Beth Dakin  <bdakin@apple.com>
1305
1306         Reviewed by Eric Seidel.
1307
1308         Fix for https://bugs.webkit.org/show_bug.cgi?id=53950
1309         USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in
1310         Platform.h instead
1311
1312         Use hot new USE(WK_SCROLLBAR_PAINTER) from Platform.h rather
1313         than the silly, old in-file #define.
1314
1315         * platform/mac/ScrollbarThemeMac.mm:
1316         (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
1317         (WebCore::updateArrowPlacement):
1318         (WebCore::ScrollbarThemeMac::registerScrollbar):
1319         (WebCore::ScrollbarThemeMac::scrollbarThickness):
1320         (WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
1321         (WebCore::ScrollbarThemeMac::hasThumb):
1322         (WebCore::ScrollbarThemeMac::minimumThumbLength):
1323         (WebCore::ScrollbarThemeMac::paint):
1324
1325 2011-02-07  Enrica Casucci  <enrica@apple.com>
1326
1327         Reviewed Adam Roben and Darin Adler.
1328
1329         WebKit2: drag and drop support on Windows.
1330         https://bugs.webkit.org/show_bug.cgi?id=52775
1331         <rdar://problem/8514409>
1332
1333         * loader/EmptyClients.h: Removed createDragImageFromLink.
1334         * page/DragClient.h: Ditto.
1335         * page/DragController.cpp:
1336         (WebCore::DragController::startDrag): changed call to createDragImageFromLink.
1337         * platform/DragImage.h:
1338         * platform/mac/DragImageMac.mm:
1339         (WebCore::createDragImageForLink): Moved from DragClient.
1340         * platform/win/ClipboardUtilitiesWin.cpp: Added a series of functions
1341         to de-serialize the drag data from the map into an IDataObject.
1342         (WebCore::getWebLocData):
1343         (WebCore::texthtmlFormat):
1344         (WebCore::createGlobalData):
1345         (WebCore::getFullCFHTML):
1346         (WebCore::urlWFormat):
1347         (WebCore::urlFormat):
1348         (WebCore::filenameWFormat):
1349         (WebCore::filenameFormat):
1350         (WebCore::htmlFormat):
1351         (WebCore::smartPasteFormat):
1352         (WebCore::getURL):
1353         (WebCore::getPlainText):
1354         (WebCore::getTextHTML):
1355         (WebCore::ClipboardDataItem::ClipboardDataItem):
1356         (WebCore::getStringData):
1357         (WebCore::getUtf8Data):
1358         (WebCore::getCFData):
1359         (WebCore::setUCharData):
1360         (WebCore::setCharData):
1361         (WebCore::setCFData):
1362         (WebCore::getClipboardMap):
1363         (WebCore::getClipboardData):
1364         (WebCore::setClipboardData):
1365         * platform/win/ClipboardUtilitiesWin.h:
1366         * platform/win/DragImageWin.cpp: Moved createDragImageForLink from DragClient
1367         to a platform specific file in WebCore. It makes a lot more sense here, since
1368         the drag image is always created in WebCore for all the other content types
1369         except for links.
1370         (WebCore::dragLabelFont):
1371         (WebCore::createDragImageForLink):
1372         * platform/win/WCDataObject.cpp: Added new way to
1373         construct a WCDataObject from a DragDataMap.
1374         (WebCore::WCDataObject::createInstance):
1375         (WebCore::WCDataObject::clearData):
1376         * platform/win/WCDataObject.h:
1377
1378 2011-02-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1379
1380         Unreviewed, rolling out r77848.
1381         http://trac.webkit.org/changeset/77848
1382         https://bugs.webkit.org/show_bug.cgi?id=53963
1383
1384         caused 6 test failures (Requested by othermaciej on #webkit).
1385
1386         * rendering/RenderBlockLineLayout.cpp:
1387         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
1388
1389 2011-02-04  Kenneth Russell  <kbr@google.com>
1390
1391         Reviewed by James Robinson.
1392
1393         Add shaders for GPU accelerated path rendering
1394         https://bugs.webkit.org/show_bug.cgi?id=45520
1395
1396         Refactored SolidFillShader and TexShader to call new
1397         generateVertex() and generateFragment() methods on base Shader
1398         class, and added support for the Loop/Blinn shaders. Refactored
1399         Loop/Blinn shader classes to derive from Shader.
1400
1401         Tested these changes with several of the IE9 Testdrive demos with
1402         accelerated 2D canvas enabled, as well as a full layout test run
1403         with --platform chromium-gpu.
1404
1405         * platform/graphics/gpu/LoopBlinnShader.cpp: Added.
1406         (WebCore::LoopBlinnShader::LoopBlinnShader):
1407         (WebCore::LoopBlinnShader::use):
1408         * platform/graphics/gpu/LoopBlinnShader.h: Added.
1409         * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Added.
1410         (WebCore::LoopBlinnSolidFillShader::create):
1411         (WebCore::LoopBlinnSolidFillShader::LoopBlinnSolidFillShader):
1412         (WebCore::LoopBlinnSolidFillShader::use):
1413         * platform/graphics/gpu/LoopBlinnSolidFillShader.h: Added.
1414         * platform/graphics/gpu/Shader.cpp:
1415         (WebCore::Shader::affineTo4x4):
1416         (WebCore::Shader::loadShader):
1417         (WebCore::Shader::loadProgram):
1418         (WebCore::Shader::generateVertex):
1419         (WebCore::Shader::generateFragment):
1420         * platform/graphics/gpu/Shader.h:
1421         * platform/graphics/gpu/SolidFillShader.cpp:
1422         (WebCore::SolidFillShader::create):
1423         * platform/graphics/gpu/TexShader.cpp:
1424         (WebCore::TexShader::TexShader):
1425         (WebCore::TexShader::create):
1426
1427 2011-02-07  Dan Bernstein  <mitz@apple.com>
1428
1429         Reviewed by Oliver Hunt.
1430
1431         <rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro-05-t.svg)
1432         https://bugs.webkit.org/show_bug.cgi?id=53480
1433
1434         * WebCore.xcodeproj/project.pbxproj:
1435         * platform/graphics/mac/ComplexTextController.cpp:
1436         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): m_indexEnd should be an
1437         offset into m_characters, not into the run’s characters.
1438         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1439         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.
1440
1441 2011-02-07  Sam Weinig  <sam@webkit.org>
1442
1443         Reviewed by Anders Carlsson.
1444
1445         Add bundle API to get the background color of a frame
1446         <rdar://problem/8962670>
1447         https://bugs.webkit.org/show_bug.cgi?id=53952
1448
1449         * WebCore.exp.in: Add export.
1450
1451 2011-02-07  Geoffrey Garen  <ggaren@apple.com>
1452
1453         Reviewed by Darin Adler.
1454
1455         Assertion failure in ~JSGlobalObject when loading apple.com HTML5
1456         transitions demo page
1457         https://bugs.webkit.org/show_bug.cgi?id=53853
1458
1459         This was a long-standing bookkeeping bug uncovered by some heap refactoring.
1460
1461         * html/HTMLCanvasElement.cpp:
1462         (WebCore::HTMLCanvasElement::createImageBuffer):
1463         * html/HTMLImageLoader.cpp:
1464         (WebCore::HTMLImageLoader::notifyFinished):
1465         * xml/XMLHttpRequest.cpp:
1466         (WebCore::XMLHttpRequest::dropProtection): Take the JSLock before
1467         reporting extra cost to the JavaScriptCore heap, since all use of
1468         JavaScriptCore is supposed to be guarded by JSLock.
1469
1470 2011-02-07  Jian Li  <jianli@chromium.org>
1471
1472         Reviewed by David Levin.
1473
1474         Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug
1475         bots
1476         https://bugs.webkit.org/show_bug.cgi?id=53104
1477
1478         Covered by the existing tests.
1479
1480         * fileapi/FileStreamProxy.cpp:
1481         (WebCore::FileStreamProxy::startOnFileThread):
1482         * platform/network/BlobRegistryImpl.cpp:
1483         (WebCore::BlobRegistryImpl::createResourceHandle):
1484         * platform/network/BlobResourceHandle.cpp:
1485         (WebCore::BlobResourceHandle::BlobResourceHandle):
1486         (WebCore::BlobResourceHandle::cancel):
1487         (WebCore::delayedStartBlobResourceHandle):
1488         (WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive
1489         till the delay function is called.
1490         (WebCore::BlobResourceHandle::doStart):
1491         (WebCore::doNotifyFinish):
1492         (WebCore::BlobResourceHandle::notifyFinish): Notify the client via the
1493         standalone function to prevent the handle from being disposed immediately
1494         by the client which will make the calls in the stack that're still bound
1495         to the handle suffer.
1496         * platform/network/BlobResourceHandle.h:
1497         * platform/network/ResourceHandle.h: Change cancel() to virtual so that
1498         BlobResourceHandle::cancel will be called when we abort a FileReader.
1499
1500 2011-02-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1501
1502         Unreviewed, rolling out r77845.
1503         http://trac.webkit.org/changeset/77845
1504         https://bugs.webkit.org/show_bug.cgi?id=53946
1505
1506         build failure (Requested by lforschler_ on #webkit).
1507
1508         * WebCore.xcodeproj/project.pbxproj:
1509         * accessibility/AccessibilityAllInOne.cpp:
1510
1511 2011-02-07  Darin Adler  <darin@apple.com>
1512
1513         https://bugs.webkit.org/show_bug.cgi?id=53939
1514         fast/css/text-overflow-ellipsis.html failure after r77818/77819
1515
1516         * platform/text/TextCodecICU.cpp:
1517         (WebCore::TextCodecICU::registerExtendedEncodingNames):
1518         Add back the "utf8" synonym for "UTF-8".
1519
1520 2011-02-07  David Hyatt  <hyatt@apple.com>
1521
1522         Reviewed by Dan Bernstein.
1523
1524         Remove an unnecessary extra computeLogicalWidth() from line layout.
1525
1526         * rendering/RenderBlockLineLayout.cpp:
1527         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
1528
1529 2011-02-07  Lucas Forschler  <lforschler@apple.com>
1530
1531         Reviewed by Geoffrey Garen.
1532
1533         Fix Leopard Intel Debug Build.
1534         <rdar://problem/8953606> REGRESSION: Can't link WebCore on 32-bit Leopard (53681)
1535         This could potentially break windows, since I had to change #include <filename> to #include "filename"
1536         
1537         * WebCore.xcodeproj/project.pbxproj:
1538         * accessibility/AccessibilityAllInOne.cpp:
1539
1540 2011-02-07  Sam Weinig  <sam@webkit.org>
1541
1542         Fix build.
1543
1544         * platform/mac/ScrollAnimatorMac.mm:
1545         (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
1546         (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
1547         (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
1548         (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
1549
1550 2011-02-07  Sam Weinig  <sam@webkit.org>
1551
1552         Reviewed by Beth Dakin.
1553
1554         Add mechanism to inform the ScrollAnimator when Scrollbars are added 
1555         and removed.
1556
1557         * platform/ScrollAnimator.h:
1558         (WebCore::ScrollAnimator::didAddVerticalScrollbar):
1559         (WebCore::ScrollAnimator::willRemoveVerticalScrollbar):
1560         (WebCore::ScrollAnimator::didAddHorizontalScrollbar):
1561         (WebCore::ScrollAnimator::willRemoveHorizontalScrollbar):
1562         Make virtual to allow platform specific overrides.
1563
1564         * platform/ScrollView.cpp:
1565         (WebCore::ScrollView::setHasHorizontalScrollbar):
1566         (WebCore::ScrollView::setHasVerticalScrollbar):
1567         Call new ScrollableArea functions.
1568
1569         * platform/ScrollableArea.cpp:
1570         (WebCore::ScrollableArea::didAddVerticalScrollbar):
1571         (WebCore::ScrollableArea::willRemoveVerticalScrollbar):
1572         (WebCore::ScrollableArea::didAddHorizontalScrollbar):
1573         (WebCore::ScrollableArea::willRemoveHorizontalScrollbar):
1574         * platform/ScrollableArea.h:
1575         Pipe to ScrollAnimator.
1576
1577         * platform/mac/ScrollAnimatorMac.h:
1578         * platform/mac/ScrollAnimatorMac.mm:
1579         (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
1580         (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
1581         (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
1582         (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
1583         * platform/mac/ScrollbarThemeMac.h:
1584         * platform/mac/ScrollbarThemeMac.mm:
1585         (WebCore::ScrollbarThemeMac::registerScrollbar):
1586         (WebCore::ScrollbarThemeMac::unregisterScrollbar):
1587         (WebCore::ScrollbarThemeMac::painterForScrollbar):
1588         Move painter delegate registration to the new didAdd/willRemove functions.
1589
1590 2011-02-07  Anders Carlsson  <andersca@apple.com>
1591
1592         Reviewed by Dan Bernstein.
1593
1594         Missing text match markers with accelerated content
1595         https://bugs.webkit.org/show_bug.cgi?id=53934
1596
1597         When doing the fake paint that recomputes the text match rects, we need to
1598         flatten compositing layers, otherwise the rects won't be updated until the next paint call.
1599
1600         (This worked by accident in WebKit1 because Safari calls -[NSWindow displayIfNeeded] on the containing
1601         window before asking for the text match rects).
1602
1603         * editing/Editor.cpp:
1604         (WebCore::Editor::countMatchesForText):
1605
1606 2011-02-07  Antti Koivisto  <antti@apple.com>
1607
1608         Reviewed by Andreas Kling.
1609
1610         REGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transform.svg
1611         https://bugs.webkit.org/show_bug.cgi?id=53900
1612         
1613         Ignore link elements in shadow trees.
1614
1615         * dom/Element.cpp:
1616         (WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
1617         (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
1618                 
1619             Some asserts to catch cases like this.
1620
1621         (WebCore::Element::attach):
1622         (WebCore::Element::recalcStyle):
1623         * html/HTMLLinkElement.cpp:
1624         (WebCore::HTMLLinkElement::HTMLLinkElement):
1625         (WebCore::HTMLLinkElement::process):
1626         (WebCore::HTMLLinkElement::insertedIntoDocument):
1627         (WebCore::HTMLLinkElement::removedFromDocument):
1628         * html/HTMLLinkElement.h:
1629
1630 2011-02-07  Darin Adler  <darin@apple.com>
1631
1632         Turn UTF-8 decoder off for now so we can look into failing tests
1633         without leaving the tree red.
1634
1635         * platform/text/TextCodecICU.cpp:
1636         (WebCore::TextCodecICU::registerBaseEncodingNames): Reverting
1637         earlier change so this can handle UTF-8.
1638         (WebCore::TextCodecICU::registerBaseCodecs): Ditto.
1639         (WebCore::TextCodecICU::registerExtendedEncodingNames): Ditto.
1640         (WebCore::TextCodecICU::registerExtendedCodecs): Ditto.
1641         * platform/text/TextCodecICU.h: Ditto.
1642         * platform/text/TextEncodingRegistry.cpp:
1643         (WebCore::buildBaseTextCodecMaps): Ditto.
1644         (WebCore::extendTextCodecMaps): Ditto.
1645         * platform/text/brew/TextCodecBrew.cpp:
1646         (WebCore::TextCodecBrew::registerBaseEncodingNames): Ditto.
1647         (WebCore::TextCodecBrew::registerBaseCodecs): Ditto.
1648         (WebCore::TextCodecBrew::registerExtendedEncodingNames): Ditto.
1649         (WebCore::TextCodecBrew::registerExtendedCodecs): Ditto.
1650         * platform/text/brew/TextCodecBrew.h: Ditto.
1651         * platform/text/gtk/TextCodecGtk.cpp:
1652         (WebCore::TextCodecGtk::registerBaseEncodingNames): Ditto.
1653         (WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
1654         * platform/text/wince/TextCodecWinCE.cpp:
1655         (WebCore::TextCodecWinCE::registerBaseEncodingNames): Ditto.
1656         (WebCore::TextCodecWinCE::registerBaseCodecs): Ditto.
1657         (WebCore::TextCodecWinCE::registerExtendedEncodingNames): Ditto.
1658         (WebCore::TextCodecWinCE::registerExtendedCodecs): Ditto.
1659         * platform/text/wince/TextCodecWinCE.h: Ditto.
1660
1661 2011-02-07  Anders Carlsson  <andersca@apple.com>
1662
1663         Reviewed by Maciej Stachowiak.
1664
1665         Don't exclude overlay scrollers from the page overlay bounds
1666         https://bugs.webkit.org/show_bug.cgi?id=53924
1667
1668         Export ScrollbarTheme::nativeTheme.
1669
1670         * WebCore.exp.in:
1671
1672 2011-02-07  Zhenyao Mo  <zmo@google.com>
1673
1674         Reviewed by Kenneth Russell.
1675
1676         Crash in glDrawArrays with NaCl crystal model
1677         https://bugs.webkit.org/show_bug.cgi?id=52831
1678
1679         * html/canvas/WebGLRenderingContext.cpp: Allocate large enough buffer for atttrib0 if it's enabled and not used.
1680         (WebCore::WebGLRenderingContext::initVertexAttrib0):
1681         (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
1682         * html/canvas/WebGLRenderingContext.h:
1683
1684 2011-02-07  Chris Fleizach  <cfleizach@apple.com>
1685
1686         Reviewed by Darin Adler.
1687
1688         WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles.
1689         https://bugs.webkit.org/show_bug.cgi?id=53842
1690
1691         Test: platform/mac/accessibility/aria-sort.html
1692
1693         * accessibility/AccessibilityObject.cpp:
1694         (WebCore::AccessibilityObject::sortDirection):
1695         * accessibility/AccessibilityObject.h:
1696         * accessibility/mac/AccessibilityObjectWrapper.mm:
1697         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
1698         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1699         * html/HTMLAttributeNames.in:
1700
1701 2011-02-07  Darin Adler  <darin@apple.com>
1702
1703         Reviewed by Antti Koivisto.
1704
1705         Add built-in decoder for UTF-8 for improved performance
1706         https://bugs.webkit.org/show_bug.cgi?id=53898
1707
1708         Correct behavior is covered by existing tests.
1709
1710         * Android.mk: Added TextCodecUTF8.
1711         * CMakeLists.txt: Ditto.
1712         * GNUmakefile.am: Ditto.
1713         * WebCore.gypi: Ditto.
1714         * WebCore.pro: Ditto.
1715         * WebCore.vcproj/WebCore.vcproj: Ditto.
1716         * WebCore.xcodeproj/project.pbxproj: Ditto.
1717
1718         * platform/text/TextCodecICU.cpp: Removed registration of UTF-8
1719         since that's now handled by the built-in UTF-8 codec.
1720         (WebCore::TextCodecICU::registerEncodingNames): Renamed to remove
1721         the word "extended" since all codecs from ICU are now extended.
1722         (WebCore::TextCodecICU::registerCodecs): Ditto.
1723         * platform/text/TextCodecICU.h: Ditto.
1724
1725         * platform/text/TextCodecUTF16.cpp:
1726         (WebCore::TextCodecUTF16::decode): Added a FIXME about missing
1727         error handling.
1728
1729         * platform/text/TextCodecUTF8.cpp: Added.
1730         * platform/text/TextCodecUTF8.h: Added.
1731
1732         * platform/text/TextEncodingRegistry.cpp:
1733         (WebCore::buildBaseTextCodecMaps): Added TextCodecUTF8, and
1734         removed TextCodecICU, TextCodecBrew, and TextCodecWinCE.
1735         (WebCore::extendTextCodecMaps): Updated names for
1736         TextCodecICU and TextCodecWinCE.
1737
1738         * platform/text/brew/TextCodecBrew.cpp:
1739         (WebCore::TextCodecBrew::registerEncodingNames): Renamed to remove
1740         the word "extended" since all codecs from Brew are now extended.
1741         (WebCore::TextCodecBrew::registerCodecs): Ditto.
1742         * platform/text/brew/TextCodecBrew.h: Ditto.
1743
1744         * platform/text/gtk/TextCodecGtk.cpp:
1745         (WebCore::TextCodecGtk::registerBaseEncodingNames): Removed
1746         registration of UTF-8. It's questionable whether the other codecs
1747         here are really basic. If we think they qualify, then we should
1748         register them on other platforms, not just GTK.
1749         (WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
1750
1751         * platform/text/wince/TextCodecWinCE.cpp:
1752         (WebCore::getCodePage): Removed special case for UTF-8 since we
1753         no longer use this codec for UTF-8.
1754         (WebCore::TextCodecWinCE::registerEncodingNames): Renamed to remove
1755         the word "extended" since all codecs from WinCE are now extended.
1756         (WebCore::TextCodecWinCE::registerCodecs): Ditto.
1757         * platform/text/wince/TextCodecWinCE.h: Ditto.
1758
1759 2011-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
1760
1761         Reviewed by Xan Lopez.
1762
1763         [Gtk] atk_text_get_caret_offset fails for list items
1764         https://bugs.webkit.org/show_bug.cgi?id=53436
1765
1766         Consider list item markers when calculating the offset.
1767
1768         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1769         (webkit_accessible_text_get_caret_offset): Adjust the offset
1770         with the item marker's length for list items.
1771         (webkit_accessible_text_set_caret_offset): Replace usage of
1772         g_utf8_strlen() by calling to markerText.length().
1773
1774 2011-02-07  Yi Shen  <yi.4.shen@nokia.com>
1775
1776         Reviewed by Tor Arne Vestbø.
1777
1778         [Qt] Fix LayoutTests/media/restore-from-page-cache.html
1779         https://bugs.webkit.org/show_bug.cgi?id=53621
1780
1781         Changed the networkState to MediaPlayer::Loaded when 
1782         MediaPlayerPrivateQt has enough data.
1783
1784         Test: media/restore-from-page-cache.html
1785
1786         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
1787         (WebCore::MediaPlayerPrivateQt::updateStates):
1788
1789 2011-01-31  Pavel Podivilov  <podivilov@chromium.org>
1790
1791         Reviewed by Yury Semikhatsky.
1792
1793         Web Inspector: implement beautification of scripts inlined in html documents.
1794         https://bugs.webkit.org/show_bug.cgi?id=52706
1795
1796         To beautify scripts inlined in html, we need to cut individual scripts, beautify them using UglifyJS library, and
1797         finally paste them back to html.
1798
1799         * WebCore.gypi:
1800         * WebCore.vcproj/WebCore.vcproj:
1801         * inspector/front-end/ScriptFormatter.js:
1802         (WebInspector.ScriptFormatter): Implement formatting of scripts inlined in html.
1803         (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
1804         (WebInspector.ScriptFormatter.prototype.formatContent):
1805         (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks):
1806         (WebInspector.ScriptFormatter.prototype._formatChunks.didFormat):
1807         (WebInspector.ScriptFormatter.prototype._formatChunks):
1808         (WebInspector.ScriptFormatter.prototype._buildContentFromChunks):
1809         (WebInspector.ScriptFormatter.prototype._formatScript.messageHandler):
1810         (WebInspector.ScriptFormatter.prototype._formatScript):
1811         * inspector/front-end/ScriptFormatterWorker.js:
1812         (onmessage):
1813         (buildMapping):
1814         * inspector/front-end/SourceFrame.js:
1815         (WebInspector.SourceFrameContent): Use SourceFrameContent and FormattedSourceFrameContent to perform operations with line numbers.
1816         * inspector/front-end/SourceFrameContent.js: Added.
1817         (WebInspector.SourceFrameContent): Helper class, holds resource text and scripts layout
1818         (WebInspector.SourceFrameContent.prototype.get scriptRanges):
1819         (WebInspector.SourceFrameContent.prototype.locationToPosition):
1820         (WebInspector.SourceFrameContent.prototype.positionToLocation):
1821         (WebInspector.SourceFrameContent.prototype.scriptLocationForLineNumber):
1822         (WebInspector.SourceFrameContent.prototype.scriptLocationForRange):
1823         (WebInspector.SourceFrameContent.prototype.lineNumberToRange):
1824         (WebInspector.SourceFrameContent.prototype._intersectingScriptRange):
1825         (WebInspector):
1826         (WebInspector.FormattedSourceFrameContent): Helper class, holds original and formatted versions of resource and mapping between them.
1827         (WebInspector.FormattedSourceFrameContent.prototype.get text):
1828         (WebInspector.FormattedSourceFrameContent.prototype.originalLocationToFormattedLocation):
1829         (WebInspector.FormattedSourceFrameContent.prototype.scriptLocationForFormattedLineNumber):
1830         (WebInspector.FormattedSourceFrameContent.prototype._convertPosition):
1831         * inspector/front-end/WebKit.qrc:
1832         * inspector/front-end/inspector.html:
1833
1834 2011-02-07  Pavel Feldman  <pfeldman@chromium.org>
1835
1836         Reviewed by Yury Semikhatsky.
1837
1838         Web Inspector: "Reveal in elements panel" does not always work.
1839         https://bugs.webkit.org/show_bug.cgi?id=53775
1840
1841         * inspector/front-end/ConsoleView.js:
1842         (WebInspector.ConsoleView):
1843         * inspector/front-end/ContextMenu.js:
1844         (WebInspector.ContextMenu.prototype.show):
1845         * inspector/front-end/ElementsPanel.js:
1846         (WebInspector.ElementsPanel.prototype.switchToAndFocus):
1847         * inspector/front-end/ElementsTreeOutline.js:
1848         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
1849         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
1850         * inspector/front-end/ObjectPropertiesSection.js:
1851         (WebInspector.ObjectPropertyTreeElement.prototype.update):
1852         (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
1853         * inspector/front-end/inspector.js:
1854         (WebInspector.cancelSearch):
1855
1856 2011-02-07  Adam Barth  <abarth@webkit.org>
1857
1858         Reviewed by Eric Seidel.
1859
1860         Relative .. in URL paths shouldn't skip adjacent / characters
1861         https://bugs.webkit.org/show_bug.cgi?id=53907
1862
1863         Our new behavior matches Firefox, Chrome, and IE.
1864
1865         * platform/KURL.cpp:
1866         (WebCore::copyPathRemovingDots):
1867
1868 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
1869
1870         Reviewed by Antti Koivisto.
1871
1872         WebKitTestRunner does not block remote resources or complain about them
1873         https://bugs.webkit.org/show_bug.cgi?id=42139
1874         <rdar://problem/8183942>
1875
1876         * Configurations/WebCore.xcconfig: Allow WebKitTestRunner to link
1877         WebCore.
1878         * WebCore.exp.in: Export a handful of KURL symbols.
1879
1880 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
1881
1882         Reviewed by Darin Adler.
1883
1884         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
1885         https://bugs.webkit.org/show_bug.cgi?id=52867
1886
1887         * ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
1888         * bindings/v8/NPV8Object.cpp:
1889         (WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of
1890         v8::Handle<v8::Value>*.
1891         (_NPN_Invoke): Calls createValueListFromVariantArgs.
1892         (_NPN_InvokeDefault): createValueListFromVariantArgs.
1893         (_NPN_Construct): createValueListFromVariantArgs.
1894         * bindings/v8/ScriptFunctionCall.cpp:
1895         (WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr.
1896         (WebCore::ScriptFunctionCall::construct): Ditto.
1897         (WebCore::ScriptCallback::call):
1898         * bindings/v8/V8DOMWindowShell.cpp:
1899         (WebCore::V8DOMWindowShell::createNewContext): Ditto.
1900         * bindings/v8/V8NPObject.cpp:
1901         (WebCore::npObjectInvokeImpl): Ditto
1902         * bindings/v8/V8NodeFilterCondition.cpp:
1903         (WebCore::V8NodeFilterCondition::acceptNode): Ditto,
1904         * html/HTMLAreaElement.cpp:
1905         (WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray.
1906         * html/HTMLFrameSetElement.cpp:
1907         (WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray.
1908         * html/canvas/WebGLRenderingContext.cpp:
1909         (WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr.
1910         (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto.
1911         (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito.
1912         * platform/Length.cpp:
1913         (WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*.
1914         (WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*.
1915         * platform/Length.h: Prototype changes.
1916         * platform/graphics/ANGLEWebKitBridge.cpp:
1917         (WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr.
1918         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
1919         (WebCore::getDirtyRects): Ditto.
1920         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1921         (WebCore::ComplexTextController::getNormalizedTextRun): Ditto.
1922         * platform/graphics/chromium/HarfbuzzSkia.cpp:
1923         (WebCore::glyphsToAdvances): Ditto.
1924         (WebCore::canRender): Ditto.
1925         * platform/graphics/gpu/Texture.cpp:
1926         (WebCore::Texture::updateSubRect): Ditto.
1927         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
1928         (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto.
1929         * platform/graphics/skia/PlatformContextSkia.cpp:
1930         (WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto.
1931         * platform/graphics/wince/SharedBitmap.cpp:
1932         (WebCore::SharedBitmap::to16bit): Ditto.
1933         * platform/win/ContextMenuWin.cpp:
1934         (WebCore::ContextMenu::getContextMenuItems): Ditto.
1935         * platform/win/LoggingWin.cpp:
1936         (WebCore::initializeWithUserDefault): Ditto.
1937         * plugins/win/PluginPackageWin.cpp:
1938         (WebCore::PluginPackage::fetchInfo): Ditto.
1939
1940 2011-02-06  Kent Tamura  <tkent@chromium.org>
1941
1942         Unreviewed.
1943
1944         * WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file.
1945
1946 2011-02-03  Dominic Cooney  <dominicc@google.com>
1947
1948         Reviewed by Dimitri Glazkov.
1949
1950         Convert <keygen> option elements to a shadow DOM
1951         https://bugs.webkit.org/show_bug.cgi?id=51379
1952
1953         Covered by existing tests e.g. fast/html/keygen.html,
1954         html5lib/runner.html, etc.
1955
1956         * css/html.css:
1957         (form): Cleanup.
1958         (keygen, select): Border radii should match so focus ring looks good.
1959         (keygen::-webkit-keygen-select): No margin on the shadow element.
1960         (select): Hoisting border radius to keygen, select rule.
1961         * dom/SelectElement.cpp:
1962         (WebCore::toSelectElement): keygen is no longer a select element.
1963         * html/HTMLKeygenElement.cpp: Implements keygen shadow.
1964         (WebCore::KeygenSelectElement::create):
1965         (WebCore::KeygenSelectElement::shadowPseudoId):
1966         (WebCore::KeygenSelectElement::KeygenSelectElement):
1967         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
1968         (WebCore::HTMLKeygenElement::parseMappedAttribute):
1969         (WebCore::HTMLKeygenElement::appendFormData):
1970         (WebCore::HTMLKeygenElement::formControlType):
1971         (WebCore::HTMLKeygenElement::reset):
1972         (WebCore::HTMLKeygenElement::selectShadow):
1973         * html/HTMLKeygenElement.h: keygen is no longer a select on C++ side.
1974         (WebCore::HTMLKeygenElement::canStartSelection):
1975         (WebCore::HTMLKeygenElement::isEnumeratable):
1976         (WebCore::HTMLKeygenElement::isResettable):
1977         * html/HTMLOptionElement.cpp:
1978         (WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects.
1979         * html/HTMLSelectElement.cpp:
1980         (WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name.
1981
1982 2011-02-06  Benjamin Poulain  <ikipou@gmail.com>
1983
1984         Reviewed by Kenneth Rohde Christiansen.
1985
1986         [Qt] Fix coding style errors in ClipboardQt.h
1987         https://bugs.webkit.org/show_bug.cgi?id=43520
1988
1989         Fix coding style: order of header and indentation.
1990
1991         * platform/qt/ClipboardQt.h:
1992         (WebCore::ClipboardQt::create):
1993         (WebCore::ClipboardQt::clipboardData):
1994         (WebCore::ClipboardQt::invalidateWritableData):
1995
1996 2011-02-06  Antti Koivisto  <antti@apple.com>
1997
1998         Reviewed by Maciej Stachowiak.
1999
2000         Use bloom filter for descendant selector filtering
2001         https://bugs.webkit.org/show_bug.cgi?id=53880
2002         
2003         Bloom filter is faster than a hash set in this kind of use.
2004         
2005         Shark thinks this speeds up style matching by ~30% on sites
2006         with lots of descendant selectors.
2007
2008         * ForwardingHeaders/wtf/BloomFilter.h: Added.
2009         * css/CSSStyleSelector.cpp:
2010         (WebCore::collectElementIdentifierHashes):
2011         (WebCore::CSSStyleSelector::pushParent):
2012         (WebCore::CSSStyleSelector::popParent):
2013         (WebCore::CSSStyleSelector::fastRejectSelector):
2014         (WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
2015         * css/CSSStyleSelector.h:
2016
2017 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
2018
2019         Reviewed by Antti Koivisto.
2020
2021         media/video-document-types.html sometimes crashes the WebProcess
2022         https://bugs.webkit.org/show_bug.cgi?id=53884
2023
2024         No new tests. Already covered by media/video-document-types.html
2025
2026         * html/HTMLMediaElement.cpp:
2027         (WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer
2028         when cancelling the load.
2029
2030 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
2031
2032         Reviewed by Adam Roben.
2033
2034         [WIN] Use WCHAR instead of TCHAR
2035         https://bugs.webkit.org/show_bug.cgi?id=53863
2036
2037         We always use the UNICODE versions of windows functions, so
2038         the usage of TCHAR makes no sense and mixing them is bad style.
2039
2040         * platform/graphics/win/IconWin.cpp:
2041         (WebCore::Icon::createIconForFiles):
2042         * platform/graphics/win/QTMovie.cpp:
2043         * platform/graphics/win/QTMovieGWorld.cpp:
2044         (QTMovieGWorld::fullscreenWndProc):
2045         (QTMovieGWorld::enterFullscreen):
2046         * platform/graphics/win/SimpleFontDataCGWin.cpp:
2047         (WebCore::SimpleFontData::platformInit):
2048         * platform/graphics/win/SimpleFontDataCairoWin.cpp:
2049         * platform/graphics/win/SimpleFontDataWin.cpp:
2050         * platform/graphics/wince/SimpleFontDataWinCE.cpp:
2051         * platform/win/BString.cpp:
2052         * platform/win/ClipboardWin.cpp:
2053         (WebCore::filesystemPathFromUrlOrTitle):
2054         (WebCore::createGlobalHDropContent):
2055         (WebCore::createGlobalImageFileDescriptor):
2056         * platform/win/ContextMenuWin.cpp:
2057         * platform/win/CursorWin.cpp:
2058         (WebCore::loadSharedCursor):
2059         * platform/win/FileChooserWin.cpp:
2060         (WebCore::FileChooser::basenameForWidth):
2061         * platform/win/PopupMenuWin.cpp:
2062         (WebCore::PopupMenuWin::popupClassName):
2063         (WebCore::PopupMenuWin::show):
2064         * platform/win/PopupMenuWin.h:
2065
2066 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
2067
2068         Reviewed by Andreas Kling.
2069
2070         Replace FLT_MAX with std::numeric_limits
2071         https://bugs.webkit.org/show_bug.cgi?id=53861
2072
2073         Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl.
2074
2075         * html/NumberInputType.cpp:
2076         * html/parser/HTMLParserIdioms.cpp:
2077         (WebCore::parseToDoubleForNumberType):
2078         * platform/brew/SystemTimeBrew.cpp:
2079         (WebCore::userIdleTime):
2080         * platform/efl/SystemTimeEfl.cpp:
2081         (WebCore::userIdleTime):
2082         * platform/efl/TemporaryLinkStubs.cpp:
2083         * platform/graphics/ca/GraphicsLayerCA.cpp:
2084         (WebCore::GraphicsLayerCA::setupAnimation):
2085         * platform/win/SystemTimeWin.cpp:
2086         (WebCore::userIdleTime):
2087         * platform/wx/SystemTimeWx.cpp:
2088         (WebCore::userIdleTime):
2089
2090 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
2091
2092         Reviewed by Andreas Kling.
2093
2094         [CMake] Add dependencies for Visual Studio projects
2095         https://bugs.webkit.org/show_bug.cgi?id=53773
2096
2097         Add a JavaScriptCore dependecy to WebCore, so CMake can 
2098         generate the correct build order for the solution.
2099
2100         * CMakeLists.txt:
2101
2102 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
2103
2104         Reviewed by Andreas Kling.
2105
2106         [CMake] Unify ENABLE_SVG sections
2107         https://bugs.webkit.org/show_bug.cgi?id=53778
2108
2109         * CMakeLists.txt:
2110
2111 2011-02-06  Andreas Kling  <kling@webkit.org>
2112
2113         Reviewed by Dirk Schulze.
2114
2115         Refactor Font::normalizeSpaces() to avoid an extra String copy.
2116         https://bugs.webkit.org/show_bug.cgi?id=53871
2117
2118         Have normalizeSpaces() take UChar*,length arguments instead of a
2119         String, since all call sites were creating temporaries from these
2120         components anyway.
2121
2122         Font::normalizeSpaces() now always makes 1 String copy,
2123         instead of 1 in the best case and 2 in the worst case.
2124
2125         * platform/graphics/Font.cpp:
2126         (WebCore::Font::normalizeSpaces):
2127         * platform/graphics/Font.h:
2128         * platform/graphics/qt/FontQt.cpp:
2129         (WebCore::drawTextCommon):
2130         (WebCore::Font::floatWidthForSimpleText):
2131         (WebCore::Font::floatWidthForComplexText):
2132         (WebCore::Font::offsetForPositionForSimpleText):
2133         (WebCore::Font::offsetForPositionForComplexText):
2134         (WebCore::Font::selectionRectForSimpleText):
2135         (WebCore::Font::selectionRectForComplexText):
2136         * svg/SVGFont.cpp:
2137         (WebCore::SVGTextRunWalker::walk):
2138
2139 2011-02-06  Andreas Kling  <kling@webkit.org>
2140
2141         Reviewed by Dirk Schulze.
2142
2143         Fix potential buffer overrun in SVGTextRunWalker::walk()
2144         https://bugs.webkit.org/show_bug.cgi?id=53870
2145
2146         A new String was created from a UChar* with a 'length' argument
2147         that could be greater than the number of UChars available.
2148
2149         * svg/SVGFont.cpp:
2150         (WebCore::SVGTextRunWalker::walk):
2151
2152 2011-02-05  Adam Barth  <abarth@webkit.org>
2153
2154         Reviewed by Eric Seidel.
2155
2156         Remove unused parameter related to XSSAuditor
2157         https://bugs.webkit.org/show_bug.cgi?id=53862
2158
2159         * WebCore.exp.in:
2160         * bindings/ScriptControllerBase.cpp:
2161         (WebCore::ScriptController::executeScript):
2162         (WebCore::ScriptController::executeIfJavaScriptURL):
2163         * bindings/ScriptControllerBase.h:
2164         * bindings/js/ScriptController.cpp:
2165         (WebCore::ScriptController::evaluateInWorld):
2166         (WebCore::ScriptController::evaluate):
2167         (WebCore::ScriptController::executeScriptInWorld):
2168         * bindings/js/ScriptController.h:
2169         * bindings/v8/ScriptController.cpp:
2170         (WebCore::ScriptController::evaluate):
2171         * bindings/v8/ScriptController.h:
2172
2173 2011-02-05  Adam Barth  <abarth@webkit.org>
2174
2175         Fix Qt build.
2176
2177         * WebCore.pro:
2178
2179 2011-02-05  Adam Barth  <abarth@webkit.org>
2180
2181         Reviewed by Eric Seidel.
2182
2183         Delete XSSAuditor
2184         https://bugs.webkit.org/show_bug.cgi?id=53859
2185
2186         The job of the XSSAuditor is now done by the XSSFilter.  In the future,
2187         we might rename XSSFilter to XSSAuditor.
2188
2189         * Android.mk:
2190         * CMakeLists.txt:
2191         * GNUmakefile.am:
2192         * WebCore.gypi:
2193         * WebCore.vcproj/WebCore.vcproj:
2194         * WebCore.xcodeproj/project.pbxproj:
2195         * bindings/ScriptControllerBase.cpp:
2196         (WebCore::ScriptController::executeIfJavaScriptURL):
2197         * bindings/ScriptControllerBase.h:
2198         * bindings/js/ScriptController.cpp:
2199         (WebCore::ScriptController::ScriptController):
2200         (WebCore::ScriptController::evaluateInWorld):
2201         * bindings/js/ScriptController.h:
2202         * bindings/js/ScriptEventListener.cpp:
2203         (WebCore::createAttributeEventListener):
2204         * bindings/v8/ScriptController.cpp:
2205         (WebCore::ScriptController::ScriptController):
2206         (WebCore::ScriptController::evaluate):
2207         * bindings/v8/ScriptController.h:
2208         * bindings/v8/ScriptEventListener.cpp:
2209         (WebCore::createAttributeEventListener):
2210         * dom/Document.cpp:
2211         (WebCore::Document::implicitOpen):
2212         (WebCore::Document::processBaseElement):
2213         * dom/ScriptableDocumentParser.cpp:
2214         (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
2215         * dom/ScriptableDocumentParser.h:
2216         * html/parser/HTMLDocumentParser.cpp:
2217         (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
2218         * loader/SubframeLoader.cpp:
2219         (WebCore::SubframeLoader::requestObject):
2220         (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
2221         * page/XSSAuditor.cpp: Removed.
2222         * page/XSSAuditor.h: Removed.
2223
2224 2011-02-05  Anders Carlsson  <andersca@apple.com>
2225
2226         Reviewed by Darin Adler.
2227
2228         Need a way to resize and scroll the page at the same time
2229         https://bugs.webkit.org/show_bug.cgi?id=53814
2230         <rdar://problem/8498008>
2231
2232         Export a function needed by WebKit2.
2233
2234         * WebCore.exp.in:
2235
2236 2011-02-05  Patrick Gansterer  <paroga@webkit.org>
2237
2238         Reviewed by Alexey Proskuryakov.
2239
2240         Use Document::encoding() instead of DocumentWriter::encoding()
2241         https://bugs.webkit.org/show_bug.cgi?id=53398
2242
2243         This change makes the code more readable, when a subresource
2244         inherits the character encoding of the document.
2245
2246         * dom/ProcessingInstruction.cpp:
2247         (WebCore::ProcessingInstruction::checkStyleSheet):
2248         * dom/ScriptElement.cpp:
2249         (WebCore::ScriptElement::scriptCharset):
2250         * html/HTMLLinkElement.cpp:
2251         (WebCore::HTMLLinkElement::process):
2252         * loader/cache/CachedResourceLoader.cpp:
2253         (WebCore::CachedResourceLoader::requestPreload):
2254         * platform/network/FormDataBuilder.cpp:
2255         (WebCore::FormDataBuilder::encodingFromAcceptCharset):
2256
2257 2011-02-05  Adam Barth  <abarth@webkit.org>
2258
2259         Reviewed by Eric Seidel.
2260
2261         Introduce URLString to represent a canonicalized URL represented by a string
2262         https://bugs.webkit.org/show_bug.cgi?id=53847
2263
2264         Instead of using String all over the codebase to represent a URL,
2265         instead we should have a type to represent a canonicalized URL in the
2266         form of a string.  This patch introduces that type.
2267
2268         * GNUmakefile.am:
2269         * WebCore.gypi:
2270         * WebCore.xcodeproj/project.pbxproj:
2271         * platform/KURL.cpp:
2272         (WebCore::KURL::KURL):
2273         * platform/KURL.h:
2274         (WebCore::KURL::urlString):
2275
2276 2011-02-05  Robert Hogan  <robert@webkit.org>
2277
2278         Reviewed by Antonio Gomes.
2279
2280         [Qt] Style widgets not rendering
2281         https://bugs.webkit.org/show_bug.cgi?id=53849
2282
2283         * html/HTMLObjectElement.cpp:
2284         (WebCore::HTMLObjectElement::hasValidClassId): x-qt-styled-widget is a valid class id too
2285
2286 2011-02-05  Jochen Eisinger  <jochen@chromium.org>
2287
2288         Reviewed by Adam Barth.
2289
2290         Add ContentSecurityPolicy object to Document and pass the X-WebKit-CSP header from the MainResourceLoader.
2291         https://bugs.webkit.org/show_bug.cgi?id=53685
2292
2293         * WebCore.xcodeproj/project.pbxproj:
2294         * dom/Document.h:
2295         (WebCore::Document::contentSecurityPolicy):
2296         * loader/MainResourceLoader.cpp:
2297         (WebCore::MainResourceLoader::didReceiveResponse):
2298         * page/ContentSecurityPolicy.cpp:
2299         (WebCore::ContentSecurityPolicy::didReceiveHeader):
2300         * page/ContentSecurityPolicy.h:
2301
2302 2011-02-05  Eric Seidel  <eric@webkit.org>
2303
2304         Reviewed by Adam Barth.
2305
2306         Safari should lowercase schemes in cannonicalized urls to match every other browser
2307         https://bugs.webkit.org/show_bug.cgi?id=53848
2308
2309         We're clearly the odd man out here.  See results from every browser at:
2310         https://github.com/abarth/url-spec/blob/master/tests/gurl-results/by-browser.txt
2311
2312         * platform/KURL.cpp:
2313         (WebCore::KURL::parse):
2314          - Just lowercase the scheme when copying.
2315
2316 2011-02-05  Antti Koivisto  <antti@apple.com>
2317
2318         Reviewed by Dave Hyatt.
2319
2320         Optimize matching of descendant selectors
2321         https://bugs.webkit.org/show_bug.cgi?id=49876
2322         <rdar://problem/8772822>
2323         
2324         During style recalculation, maintain a filter of tags, ids and classes seen in ancestor elements.
2325         Use the filter to quickly reject descendant and child selectors when doing style matching.
2326
2327         This speeds up style recalculations 3-6x on many major web sites.
2328
2329         * css/CSSStyleSelector.cpp:
2330         (WebCore::RuleData::RuleData):
2331         (WebCore::RuleData::descendantSelectorIdentifierHashes):
2332         (WebCore::collectElementIdentifiers):
2333         (WebCore::CSSStyleSelector::pushParent):
2334         (WebCore::CSSStyleSelector::popParent):
2335         (WebCore::CSSStyleSelector::fastRejectSelector):
2336         (WebCore::CSSStyleSelector::matchRulesForList):
2337         (WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
2338         * css/CSSStyleSelector.h:
2339         (WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
2340         * dom/Element.cpp:
2341         (WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
2342         (WebCore::StyleSelectorParentPusher::push):
2343         (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
2344         (WebCore::Element::attach):
2345         (WebCore::Element::recalcStyle):
2346
2347 2011-02-05  Nate Chapin  <japhet@chromium.org>
2348
2349         Reviewed by Adam Barth.
2350
2351         Refactor: NotificationCenter shouldn't hold its own copy of the ScriptExecutionContext*
2352         when it inherits one from ActiveDOMObject.
2353         https://bugs.webkit.org/show_bug.cgi?id=53815
2354
2355         * bindings/js/JSDesktopNotificationsCustom.cpp:
2356         (WebCore::JSNotificationCenter::requestPermission):
2357         * bindings/v8/custom/V8NotificationCenterCustom.cpp:
2358         (WebCore::V8NotificationCenter::requestPermissionCallback):
2359         * notifications/NotificationCenter.cpp:
2360         (WebCore::NotificationCenter::NotificationCenter):
2361         (WebCore::NotificationCenter::checkPermission):
2362         (WebCore::NotificationCenter::requestPermission):
2363         (WebCore::NotificationCenter::disconnectFrame):
2364         * notifications/NotificationCenter.h:
2365         (WebCore::NotificationCenter::createHTMLNotification):
2366         (WebCore::NotificationCenter::createNotification):
2367
2368 2011-02-04  Adam Barth  <abarth@webkit.org>
2369
2370         Reviewed by Maciej Stachowiak.
2371
2372         Crash in WebCore::TextEncoding::decode below XSSFilter::init
2373         https://bugs.webkit.org/show_bug.cgi?id=53837
2374
2375         Add missing null check.
2376
2377         Test: http/tests/security/xssAuditor/non-block-javascript-url-frame.html
2378
2379         * html/parser/XSSFilter.cpp:
2380         (WebCore::XSSFilter::init):
2381
2382 2011-02-04  Simon Fraser  <simon.fraser@apple.com>
2383
2384         Reviewed by Dan Bernstein.
2385
2386         Crashes in ShadowBlur via WebKit2 FindController
2387         https://bugs.webkit.org/show_bug.cgi?id=53830
2388         
2389         Fix a crash cause by re-entering ShadowBlur, and add assertions to
2390         detect when it happens.
2391         
2392         The re-entrancy occurred when drawRectShadowWithTiling() filled
2393         the interior of the shadow with fillRect() on the context
2394         which still had the shadow state set. This would make another ShadowBlur
2395         on the stack and call into the code again, potentially blowing away
2396         the image buffer.
2397         
2398         Fix by turning off shadows in the destination context while we're
2399         drawing the tiled shadow. The non-tiled code path already did this.
2400
2401         Not testable because CSS shadows clip out the inside of the rect
2402         being shadowed, and SVG uses fillPath, even for rects.
2403
2404         * platform/graphics/ShadowBlur.cpp:
2405         (WebCore::ScratchBuffer::ScratchBuffer):
2406         (WebCore::ScratchBuffer::getScratchBuffer):
2407         (WebCore::ScratchBuffer::scheduleScratchBufferPurge):
2408         (WebCore::ShadowBlur::ShadowBlur):
2409         (WebCore::ShadowBlur::drawRectShadowWithTiling):
2410
2411 2011-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2412
2413         Reviewed by Martin Robinson.
2414
2415         [GTK] Don't use a fixed size for search field icons
2416         https://bugs.webkit.org/show_bug.cgi?id=50624
2417
2418         Use the parent input content box to make sure the icon fits in the
2419         search field, scaling it down when needed.
2420
2421         * platform/gtk/RenderThemeGtk.cpp:
2422         (WebCore::paintGdkPixbuf):
2423         (WebCore::getIconSizeForPixelSize):
2424         (WebCore::adjustSearchFieldIconStyle):
2425         (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
2426         (WebCore::centerRectVerticallyInParentInputElement):
2427         (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
2428         (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
2429         (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
2430         (WebCore::RenderThemeGtk::paintCapsLockIndicator):
2431         (WebCore::RenderThemeGtk::paintMediaButton):
2432
2433 2011-02-04  Hironori Bono  <hbono@chromium.org>
2434
2435         Reviewed by Adam Barth.
2436
2437         [chromium] JPEG corruption
2438         https://bugs.webkit.org/show_bug.cgi?id=53250
2439
2440         Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
2441         profiles from CMYK to RGB twice and it causes color corruption. This
2442         change suppresses the color profiles for CMYK JPEGs same as gray-scale
2443         ones.
2444
2445         Test: fast/images/cmyk-jpeg-with-color-profile.html
2446
2447         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
2448         (WebCore::JPEGImageReader::decode):
2449
2450 2011-02-04  Xiyuan Xia  <xiyuan@chromium.org>
2451
2452         Reviewed by Tony Chang.
2453
2454         [Chromium] Option text in select popup does not align with menulist button text
2455         https://bugs.webkit.org/show_bug.cgi?id=53632
2456
2457         This makes clientPaddingLeft and  clientPaddingRight return
2458         the additional m_innerBlock's padding so that the popup item text
2459         aligns with the menulist button text.
2460
2461         * rendering/RenderMenuList.cpp:
2462         (WebCore::RenderMenuList::clientPaddingLeft):
2463         (WebCore::RenderMenuList::clientPaddingRight):
2464
2465 2011-02-04  Anders Carlsson  <andersca@apple.com>
2466
2467         Reviewed by Sam Weinig and Beth Dakin.
2468
2469         REGRESSION: Horizontal scrollbar thumbs leave artifacts over page content when scrolling vertically
2470         <rdar://problem/8962457>
2471
2472         * platform/ScrollView.cpp:
2473         (WebCore::ScrollView::scrollContents):
2474         Subtract scrollbars from the scroll view rect if overlay scrollers are enabled.
2475         
2476         * platform/ScrollableArea.cpp:
2477         (WebCore::ScrollableArea::setScrollOffsetFromAnimation):
2478         Make sure to invalidate both scrollbars if overlay scrollers are enabled.
2479
2480 2011-02-04  Adam Barth  <abarth@webkit.org>
2481
2482         Reviewed by Eric Seidel.
2483
2484         PluginDocuments don't create widgets for plugins on back/forward
2485         https://bugs.webkit.org/show_bug.cgi?id=53474
2486
2487         Long ago, PluginDocument always caused the HTMLEmbedElement to create
2488         its widget synchronously during a post-layout task.  Recently, however,
2489         some changes to the HistroyController caused layout on back/forward to
2490         become slightly more complicated (and added an extra level of recursion
2491         to layout).  This extra level of recursion triggered the "I've recursed
2492         too many times" condition in the post-layout task queue, causing the
2493         FrameView to run the remainder of the tasks asynchronously.
2494         Unfortunately, that broke PluginDocument because it needs its the
2495         HTMLEmbedElement's updateWidget task to run synchronously.
2496
2497         This patch adds a mechanism for "kicking off" the pending post-layout
2498         tasks synchronously (instead of waiting for the timer to fire).
2499         PluginDocument then uses that facility to ensure that the
2500         HTMLEmbedElement's updateWidget task happens.
2501
2502         Test: plugins/plugin-document-back-forward.html
2503
2504         * html/PluginDocument.cpp:
2505         (WebCore::PluginDocumentParser::appendBytes):
2506         * page/FrameView.cpp:
2507         (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
2508         * page/FrameView.h:
2509
2510 2011-02-04  Charlie Reis  <creis@chromium.org>
2511
2512         Reviewed by Mihai Parparita.
2513
2514         Crash in WebCore::HistoryController::itemsAreClones
2515         https://bugs.webkit.org/show_bug.cgi?id=52819
2516
2517         Avoids deleting the current HistoryItem while it is still in use.
2518         Ensures that provisional items are committed for same document navigations.
2519         Ensures that error pages are committed on back/forward navigations.
2520         Also removes unneeded sanity checks used for diagnosing the problem.
2521
2522         * loader/HistoryController.cpp:
2523         * loader/HistoryController.h:
2524
2525 2011-02-04  Carol Szabo  <carol.szabo@nokia.com>
2526
2527         Reviewed by David Hyatt.
2528
2529         Code Changes.
2530
2531         CSS 2.1 failure: content-*
2532         https://bugs.webkit.org/show_bug.cgi?id=52126
2533
2534         Test: fast/css/counters/content-021.html
2535
2536         * rendering/CounterNode.cpp:
2537         (showCounterTree):
2538         Made parameter const because it is supposed to be so.
2539         * rendering/RenderCounter.cpp:
2540         (WebCore::previousInPreOrder):
2541         (WebCore::previousSiblingOrParent):
2542         (WebCore::parentElement):
2543         (WebCore::areRenderersElementsSiblings):
2544         (WebCore::nextInPreOrder):
2545         Added these local helper functions to help navigate the DOM tree
2546         enriched with :before and :after pseudo elements.
2547         (WebCore::planCounter):
2548         Fixed bug that would create a repeat counter for second and
2549         subsequent renderers associated with the same DOM element.
2550         (WebCore::findPlaceForCounter):
2551         (WebCore::makeCounterNode):
2552         Changed to use the new tree navigation functions described above
2553         instead of the Renderer Tree navigation functions.
2554         (WebCore::RenderCounter::rendererSubtreeAttached):
2555         (WebCore::RenderCounter::rendererStyleChanged):
2556         Optimized to not bother about counters until the renderers are
2557         finally attached.
2558         (showRendererTree):
2559         (showNodeTree):
2560         Debug helper functions used to debug Counter bugs.
2561
2562 2011-02-04  Dan Bernstein  <mitz@apple.com>
2563
2564         Typo fix.
2565
2566         * html/parser/XSSFilter.cpp:
2567         (WebCore::HTMLNames::containsJavaScriptURL):
2568
2569 2011-02-04  Dan Bernstein  <mitz@apple.com>
2570
2571         Reviewed by Anders Carlsson.
2572
2573         Make an infinite loop introduced in r77454 finite.
2574
2575         * html/parser/XSSFilter.cpp:
2576         (WebCore::HTMLNames::containsJavaScriptURL):
2577
2578 2011-02-04  Jer Noble  <jer.noble@apple.com>
2579
2580         Reviewed by Eric Carlson.
2581
2582         Frame accurate seeking isn't always accurate
2583         https://bugs.webkit.org/show_bug.cgi?id=52697
2584
2585         Test: media/video-frame-accurate-seek.html
2586
2587         Make seeking slightly more accurate by rounding instead of truncating
2588         when converting from seconds-in-float to time/timeScale.
2589
2590         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2591         (WebCore::MediaPlayerPrivateQTKit::createQTTime):
2592         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
2593         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue):
2594         * platform/graphics/win/QTMovie.cpp:
2595         (QTMovie::setCurrentTime):
2596
2597 2011-02-04  Jeremy Orlow  <jorlow@chromium.org>
2598
2599         Reviewed by Nate Chapin.
2600
2601         Second IndexedDB events overhaul patch
2602         https://bugs.webkit.org/show_bug.cgi?id=53813
2603
2604         If an IDBRequest has a IDBTransaction, it should propogate
2605         events through it. In order to do this, IDBRequest needs to
2606         hold a transaction frontend object rather than a backend one.
2607
2608         Test: storage/indexeddb/request-event-propagation.html
2609
2610         * storage/IDBCursor.cpp:
2611         (WebCore::IDBCursor::IDBCursor):
2612         * storage/IDBCursor.h:
2613         (WebCore::IDBCursor::create):
2614         * storage/IDBDatabase.cpp:
2615         (WebCore::IDBDatabase::setSetVersionTransaction):
2616         (WebCore::IDBDatabase::createObjectStore):
2617         (WebCore::IDBDatabase::deleteObjectStore):
2618         * storage/IDBDatabase.h:
2619         * storage/IDBIndex.cpp:
2620         (WebCore::IDBIndex::IDBIndex):
2621         (WebCore::IDBIndex::openCursor):
2622         (WebCore::IDBIndex::openKeyCursor):
2623         (WebCore::IDBIndex::get):
2624         (WebCore::IDBIndex::getKey):
2625         * storage/IDBIndex.h:
2626         (WebCore::IDBIndex::create):
2627         * storage/IDBObjectStore.cpp:
2628         (WebCore::IDBObjectStore::IDBObjectStore):
2629         (WebCore::IDBObjectStore::get):
2630         (WebCore::IDBObjectStore::add):
2631         (WebCore::IDBObjectStore::put):
2632         (WebCore::IDBObjectStore::deleteFunction):
2633         (WebCore::IDBObjectStore::createIndex):
2634         (WebCore::IDBObjectStore::deleteIndex):
2635         (WebCore::IDBObjectStore::openCursor):
2636         * storage/IDBObjectStore.h:
2637         (WebCore::IDBObjectStore::create):
2638         * storage/IDBRequest.cpp:
2639         (WebCore::IDBRequest::create):
2640         (WebCore::IDBRequest::IDBRequest):
2641         (WebCore::IDBRequest::resetReadyState):
2642         (WebCore::IDBRequest::onSuccess):
2643         (WebCore::IDBRequest::dispatchEvent):
2644         * storage/IDBRequest.h:
2645         * storage/IDBTransaction.cpp:
2646         (WebCore::IDBTransaction::IDBTransaction):
2647         (WebCore::IDBTransaction::objectStore):
2648         (WebCore::IDBTransaction::contextDestroyed):
2649         (WebCore::IDBTransaction::enqueueEvent):
2650         * storage/IDBTransaction.h:
2651         * storage/IDBTransaction.idl:
2652
2653 2011-02-04  Jeremy Orlow  <jorlow@chromium.org>
2654
2655         Reviewed by Nate Chapin.
2656
2657         First step towards event propogation within IndexedDB
2658         https://bugs.webkit.org/show_bug.cgi?id=53795
2659
2660         This is the first step towards implementing
2661         http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
2662         within IndexedDB. I've created a method that knows how
2663         to capture and bubble (based on Node's dispatchGenericEvent).
2664         I've then changed IDBRequest to use it.
2665
2666         The only functional change is that preventDefault now must
2667         be called in error events to prevent the transaction from
2668         being aborted. The tests reflect this change and there's one
2669         specific test to look at this behavior.
2670
2671         Test: storage/indexeddb/error-causes-abort-by-default.html
2672
2673         * storage/IDBAbortEvent.cpp:
2674         (WebCore::IDBAbortEvent::create):
2675         (WebCore::IDBAbortEvent::IDBAbortEvent):
2676         * storage/IDBAbortEvent.h:
2677         * storage/IDBCompleteEvent.cpp:
2678         (WebCore::IDBCompleteEvent::create):
2679         (WebCore::IDBCompleteEvent::IDBCompleteEvent):
2680         * storage/IDBCompleteEvent.h:
2681         * storage/IDBErrorEvent.cpp:
2682         (WebCore::IDBErrorEvent::IDBErrorEvent):
2683         * storage/IDBEvent.cpp:
2684         (WebCore::IDBEvent::IDBEvent):
2685         (WebCore::IDBEvent::dispatch):
2686         * storage/IDBEvent.h:
2687         * storage/IDBRequest.cpp:
2688         (WebCore::IDBRequest::dispatchEvent):
2689         * storage/IDBRequest.h:
2690         * storage/IDBSuccessEvent.cpp:
2691         (WebCore::IDBSuccessEvent::IDBSuccessEvent):
2692         * storage/IDBTransaction.cpp:
2693         (WebCore::IDBTransaction::onAbort):
2694         (WebCore::IDBTransaction::onComplete):
2695         * storage/IDBTransaction.h:
2696         (WebCore::IDBTransaction::backend):
2697         * storage/IDBTransactionBackendImpl.cpp:
2698         (WebCore::IDBTransactionBackendImpl::taskTimerFired):
2699
2700 2011-02-04  Daniel Cheng  <dcheng@chromium.org>
2701
2702         Reviewed by Dmitry Titov.
2703
2704         Clone WebClipboard to be frame-specific.
2705         https://bugs.webkit.org/show_bug.cgi?id=53727
2706
2707         For drop operations, Chrome currently snapshots the data and copies it
2708         into the renderer process. As we add more supported drag data types, the
2709         copy will become increasingly expensive. Instead, we'd like to snapshot
2710         data in the browser to reduce the amount of data copied and to support
2711         Blob in DataTransferItem. In order to allow this, we associated
2712         WebClipboard with a frame so it can correctly route its IPCs to the
2713         corresponding Chromium host.
2714
2715         No new tests because no new functionality.
2716
2717         * platform/chromium/ChromiumDataObject.cpp:
2718         (WebCore::ChromiumDataObject::createReadable):
2719         * platform/chromium/ChromiumDataObject.h:
2720         * platform/chromium/ClipboardChromium.cpp:
2721         (WebCore::ClipboardChromium::create):
2722         * platform/chromium/PlatformBridge.h:
2723         * platform/chromium/ReadableDataObject.cpp:
2724         (WebCore::ReadableDataObject::create):
2725         (WebCore::ReadableDataObject::ReadableDataObject):
2726         (WebCore::ReadableDataObject::getData):
2727         (WebCore::ReadableDataObject::urlTitle):
2728         (WebCore::ReadableDataObject::htmlBaseUrl):
2729         (WebCore::ReadableDataObject::filenames):
2730         (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
2731         * platform/chromium/ReadableDataObject.h:
2732
2733 2011-02-04  Jeremy Orlow  <jorlow@chromium.org>
2734
2735         Revert https://bugs.webkit.org/show_bug.cgi?id=53795
2736
2737         * storage/IDBAbortEvent.cpp:
2738         (WebCore::IDBAbortEvent::create):
2739         (WebCore::IDBAbortEvent::IDBAbortEvent):
2740         * storage/IDBAbortEvent.h:
2741         * storage/IDBCompleteEvent.cpp:
2742         (WebCore::IDBCompleteEvent::create):
2743         (WebCore::IDBCompleteEvent::IDBCompleteEvent):
2744         * storage/IDBCompleteEvent.h:
2745         * storage/IDBErrorEvent.cpp:
2746         (WebCore::IDBErrorEvent::IDBErrorEvent):
2747         * storage/IDBEvent.cpp:
2748         (WebCore::IDBEvent::IDBEvent):
2749         * storage/IDBEvent.h:
2750         * storage/IDBRequest.cpp:
2751         (WebCore::IDBRequest::dispatchEvent):
2752         * storage/IDBRequest.h:
2753         * storage/IDBSuccessEvent.cpp:
2754         (WebCore::IDBSuccessEvent::IDBSuccessEvent):
2755         * storage/IDBTransaction.cpp:
2756         (WebCore::IDBTransaction::onAbort):
2757         (WebCore::IDBTransaction::onComplete):
2758         * storage/IDBTransaction.h:
2759         * storage/IDBTransactionBackendImpl.cpp:
2760         (WebCore::IDBTransactionBackendImpl::taskTimerFired):
2761
2762 2011-02-04  Martin Galpin  <martin@66laps.com>
2763
2764         Reviewed by David Levin.
2765
2766         CORS origin header not set on GET when a preflight request is required.
2767         https://bugs.webkit.org/show_bug.cgi?id=50773
2768         
2769         Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html
2770
2771         * loader/DocumentThreadableLoader.cpp:
2772         (WebCore::DocumentThreadableLoader::preflightSuccess): 
2773         Explicitly set the request origin after a preflight request succeeds.
2774
2775 2011-02-04  Jeremy Orlow  <jorlow@chromium.org>
2776
2777         Reviewed by Nate Chapin.
2778
2779         First step towards event propogation within IndexedDB
2780         https://bugs.webkit.org/show_bug.cgi?id=53795
2781
2782         This is the first step towards implementing
2783         http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
2784         within IndexedDB. I've created a method that knows how
2785         to capture and bubble (based on Node's dispatchGenericEvent).
2786         I've then changed IDBRequest to use it.
2787
2788         The only functional change is that preventDefault now must
2789         be called in error events to prevent the transaction from
2790         being aborted. The tests reflect this change and there's one
2791         specific test to look at this behavior.
2792
2793         Test: storage/indexeddb/error-causes-abort-by-default.html
2794
2795         * storage/IDBAbortEvent.cpp:
2796         (WebCore::IDBAbortEvent::create):
2797         (WebCore::IDBAbortEvent::IDBAbortEvent):
2798         * storage/IDBAbortEvent.h:
2799         * storage/IDBCompleteEvent.cpp:
2800         (WebCore::IDBCompleteEvent::create):
2801         (WebCore::IDBCompleteEvent::IDBCompleteEvent):
2802         * storage/IDBCompleteEvent.h:
2803         * storage/IDBErrorEvent.cpp:
2804         (WebCore::IDBErrorEvent::IDBErrorEvent):
2805         * storage/IDBEvent.cpp:
2806         (WebCore::IDBEvent::IDBEvent):
2807         (WebCore::IDBEvent::dispatch):
2808         * storage/IDBEvent.h:
2809         * storage/IDBRequest.cpp:
2810         (WebCore::IDBRequest::dispatchEvent):
2811         * storage/IDBRequest.h:
2812         * storage/IDBSuccessEvent.cpp:
2813         (WebCore::IDBSuccessEvent::IDBSuccessEvent):
2814         * storage/IDBTransaction.cpp:
2815         (WebCore::IDBTransaction::onAbort):
2816         (WebCore::IDBTransaction::onComplete):
2817         * storage/IDBTransaction.h:
2818         (WebCore::IDBTransaction::backend):
2819         * storage/IDBTransactionBackendImpl.cpp:
2820         (WebCore::IDBTransactionBackendImpl::taskTimerFired):
2821
2822 2011-02-04  Dimitri Glazkov  <dglazkov@chromium.org>
2823
2824         Reviewed by Csaba Osztrogonác.
2825
2826         [Qt]REGRESSION(r76951): media/controls-without-preload.html fails
2827         https://bugs.webkit.org/show_bug.cgi?id=53674
2828
2829         * css/mediaControlsQt.css:
2830
2831 2011-02-04  Dan Bernstein  <mitz@apple.com>
2832
2833         Reviewed by Darin Adler and Dave Hyatt.
2834
2835         <rdar://problem/8902704> Make ruby text size 50% by default
2836         https://bugs.webkit.org/show_bug.cgi?id=53723
2837
2838         * css/html.css:
2839         (ruby > rt): Changed the font-size from 60% to 50%.
2840
2841 2011-02-04  Antti Koivisto  <antti@apple.com>
2842
2843         Reviewed by Dimitri Glazkov.
2844
2845         https://bugs.webkit.org/show_bug.cgi?id=53610
2846         Regression: adjacent sibling selector not working as expected
2847         <rdar://problem/8960033>
2848         
2849         https://bugs.webkit.org/show_bug.cgi?id=53574
2850         REGRESSION (r76012): :last-child:after not working as expected
2851         <rdar://problem/8948643>
2852         
2853         Test for additional conditions in parent style that prevent sharing.
2854
2855         Tests: fast/selectors/style-sharing-adjacent-selector.html
2856                fast/selectors/style-sharing-last-child.html
2857
2858         * css/CSSStyleSelector.cpp:
2859         (WebCore::parentStylePreventsSharing):
2860         (WebCore::CSSStyleSelector::locateSharedStyle):
2861
2862 2011-02-04  Mark Mentovai  <mark@chromium.org>
2863
2864         Reviewed by Dimitri Glazkov.
2865
2866         Chromium GYP build fix.
2867
2868         When various settings were moved to webcore_prerequisites in r66364,
2869         things that should have been direct_dependent_settings were not marked
2870         as such. GYP 'defines', for example, make no sense on a 'none'-type
2871         target such as webcore_prerequisites. It appears that it was intended
2872         for these settings to be pushed to direct dependents, which would make
2873         direct_dependent_settings correct.
2874
2875         Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
2876         http://crbug.com/71537, which at best causes Mac console log spew, and
2877         at worst may result in Chromium's copy of WebCore using system
2878         definitions of certain Objective-C classes at runtime, or vice-versa.
2879
2880         The build now includes a postbuild step to prevent
2881         http://crbug.com/71537 from regressing again. The build will fail upon
2882         regression.
2883
2884         https://bugs.webkit.org/show_bug.cgi?id=53630
2885
2886         * WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into
2887           direct_dependent_settings as needed, add the check_objc_rename
2888           postbuild step.
2889         * WebCore.gyp/mac/check_objc_rename.sh: Added.
2890
2891 2011-02-04  Robert Hogan  <robert@webkit.org>
2892
2893         Reviewed by Darin Fisher.
2894
2895         Move chromium iframe shim code to cross-platform file
2896         https://bugs.webkit.org/show_bug.cgi?id=52594
2897
2898         Move Chromium code for identifying and cutting out
2899         iframe shims from plugins to cross-platform utility file
2900         IFrameShimSupport.cpp.
2901         Amend PluginViewQt to use this code to handle shims correctly.
2902
2903         * WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp
2904         * WebCore.pro: Add Qt support for IFrameShimSupport.cpp
2905         * plugins/IFrameShimSupport.cpp: Added.
2906         (WebCore::getObjectStack):
2907         (WebCore::iframeIsAbovePlugin):
2908         (WebCore::getPluginOcclusions):
2909         * plugins/IFframeShimSupport.h: Added.
2910         * plugins/qt/PluginViewQt.cpp:
2911         (WebCore::PluginView::setNPWindowIfNeeded):
2912
2913 2011-02-04  Xiaomei Ji  <xji@chromium.org>
2914
2915         Reviewed by David Levin.
2916
2917         Implement "<option> should implement the dir attribute" for chromium port after r76983.
2918         https://bugs.webkit.org/show_bug.cgi?id=50969
2919
2920         Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html
2921         added in r76983.
2922
2923         * platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from
2924         <select> drop-down setting.
2925         (WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint
2926         items in drop-down and pass-in bidi override flag when creating text run.
2927         * platform/chromium/PopupMenuChromium.h: Remove directionalityHint from
2928         PopupContainerSettings.
2929
2930 2011-02-04  Jeremy Orlow  <jorlow@chromium.org>
2931
2932         Build fix from merge mistake.
2933
2934         * storage/IDBTransaction.cpp:
2935         (WebCore::IDBTransaction::ensureEventTargetData):
2936
2937 2011-02-04  Levi Weintraub  <leviw@chromium.org>
2938
2939         Reviewed by Darin Adler.
2940
2941         Remove unneeded function declarations in comments in EditorClient.h
2942         https://bugs.webkit.org/show_bug.cgi?id=53745
2943
2944         Removing unused commented out function declarations. No tests since this is just cleanup.
2945
2946         * page/EditorClient.h:
2947
2948 2011-02-03  Jeremy Orlow  <jorlow@chromium.org>
2949
2950         Reviewed by Nate Chapin.
2951
2952         Refactor IDBRequest and IDBTransaction a bit
2953         https://bugs.webkit.org/show_bug.cgi?id=53565
2954
2955         There were a lot of subtle issues with the way IDBTransaction
2956         and IDBRequest used to be written. This cleans a lot of them up
2957         and largely simplifies the logic. Using EventQueue rather than
2958         timers is one example of the simplification.
2959
2960         * bindings/scripts/CodeGeneratorV8.pm:
2961         * dom/EventQueue.cpp:
2962         (WebCore::EventQueue::enqueueEvent):
2963         (WebCore::EventQueue::dispatchEvent):
2964         * storage/IDBCursor.cpp:
2965         (WebCore::IDBCursor::continueFunction):
2966         * storage/IDBRequest.cpp:
2967         (WebCore::IDBRequest::create):
2968         (WebCore::IDBRequest::IDBRequest):
2969         (WebCore::IDBRequest::resetReadyState):
2970         (WebCore::IDBRequest::onError):
2971         (WebCore::IDBRequest::onSuccess):
2972         (WebCore::IDBRequest::dispatchEvent):
2973         (WebCore::IDBRequest::enqueueEvent):
2974         (WebCore::IDBRequest::eventTargetData):
2975         (WebCore::IDBRequest::ensureEventTargetData):
2976         * storage/IDBRequest.h:
2977         (WebCore::IDBRequest::dispatchEvent):
2978         * storage/IDBTransaction.cpp:
2979         (WebCore::IDBTransaction::create):
2980         (WebCore::IDBTransaction::IDBTransaction):
2981         (WebCore::IDBTransaction::objectStore):
2982         (WebCore::IDBTransaction::abort):
2983         (WebCore::IDBTransaction::onAbort):
2984         (WebCore::IDBTransaction::onComplete):
2985         (WebCore::IDBTransaction::onTimeout):
2986         (WebCore::IDBTransaction::canSuspend):
2987         (WebCore::IDBTransaction::stop):
2988         (WebCore::IDBTransaction::enqueueEvent):
2989         (WebCore::IDBTransaction::eventTargetData):
2990         (WebCore::IDBTransaction::ensureEventTargetData):
2991         * storage/IDBTransaction.h:
2992
2993 2011-02-01  Jeremy Orlow  <jorlow@chromium.org>
2994
2995         Reviewed by Nate Chapin.
2996
2997         Remove the timeout event from IndexedDB
2998         https://bugs.webkit.org/show_bug.cgi?id=53521
2999
3000         Remove timeout and ontimeout from IDBTransaction per the spec.
3001
3002         * WebCore.gypi:
3003         * storage/IDBDatabase.cpp:
3004         (WebCore::IDBDatabase::transaction):
3005         * storage/IDBDatabase.h:
3006         (WebCore::IDBDatabase::transaction):
3007         * storage/IDBDatabase.idl:
3008         * storage/IDBDatabaseBackendImpl.cpp:
3009         (WebCore::IDBDatabaseBackendImpl::setVersion):
3010         (WebCore::IDBDatabaseBackendImpl::transaction):
3011         * storage/IDBDatabaseBackendImpl.h:
3012         * storage/IDBDatabaseBackendInterface.h:
3013         * storage/IDBTimeoutEvent.cpp: Removed.
3014         * storage/IDBTimeoutEvent.h: Removed.
3015         * storage/IDBTransaction.cpp:
3016         (WebCore::IDBTransaction::IDBTransaction):
3017         (WebCore::IDBTransaction::onAbort):
3018         (WebCore::IDBTransaction::onComplete):
3019         * storage/IDBTransaction.h:
3020         * storage/IDBTransaction.idl:
3021         * storage/IDBTransactionBackendImpl.cpp:
3022         (WebCore::IDBTransactionBackendImpl::create):
3023         (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
3024         * storage/IDBTransactionBackendImpl.h:
3025         * storage/IDBTransactionCallbacks.h:
3026
3027 2011-02-04  Chris Fleizach  <cfleizach@apple.com>
3028
3029         Reviewed by Darin Adler.
3030
3031         AX: Can't set accessibility overridden attributes on web objects
3032         https://bugs.webkit.org/show_bug.cgi?id=53725
3033
3034         accessibilitySetOverriddenValue does not work on AX objects from WebCore because 
3035         the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
3036         Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
3037         attribute only when an AX client asks for it through the AX frameworks.
3038
3039         * accessibility/mac/AccessibilityObjectWrapper.mm:
3040         (-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
3041
3042 2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>
3043
3044         Reviewed by Kent Tamura.
3045
3046         REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
3047         https://bugs.webkit.org/show_bug.cgi?id=53691
3048
3049         Test: fast/repaint/slider-thumb-drag-release.html
3050
3051         * html/shadow/SliderThumbElement.cpp:
3052         (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure
3053             that the thumb is repainted.
3054
3055 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
3056
3057         Reviewed by Pavel Feldman.
3058
3059         Web Inspector: Add "show more" data grid node and waiting message UI components.
3060         https://bugs.webkit.org/show_bug.cgi?id=53763
3061
3062         - "show more" data grid node is used for on-demand population of
3063         data grid contents (similar to DOM tree capability for limiting
3064         displayed nodes count);
3065
3066         - waiting message is used for informing user about long lasting
3067         operations (with a possibility to cancel them).
3068
3069         * English.lproj/localizedStrings.js:
3070         * WebCore.gypi:
3071         * WebCore.vcproj/WebCore.vcproj:
3072         * inspector/front-end/PleaseWaitMessage.js: Added.
3073         (WebInspector.PleaseWaitMessage):
3074         * inspector/front-end/ShowMoreDataGridNode.js: Added.
3075         (WebInspector.ShowMoreDataGridNode):
3076         * inspector/front-end/WebKit.qrc:
3077         * inspector/front-end/inspector.css:
3078         (.data-grid button):
3079         (.please-wait-msg):
3080         * inspector/front-end/inspector.html:
3081
3082 2011-02-04  Adele Peterson  <adele@apple.com>
3083
3084         Reviewed by Dan Bernstein.
3085
3086         Fix for https://bugs.webkit.org/show_bug.cgi?id=53740
3087         <rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused
3088
3089         Tests:
3090         fast/forms/textarea-placeholder-visibility-1.html
3091         fast/forms/textarea-placeholder-visibility-2.html
3092         fast/forms/input-placeholder-visibility-1.html
3093         fast/forms/input-placeholder-visibility-2.html
3094         fast/forms/input-placeholder-visibility-3.html
3095
3096         * html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
3097         Add a check for shouldShowPlaceholderWhenFocused.
3098         * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue):
3099         Whenever the value is updated, we should also update placeholder visibility.
3100         * rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused):
3101         Make the default the same as the existing behavior.
3102         * rendering/RenderThemeMac.h:
3103         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
3104         Show placeholder when appropriate. 
3105
3106 2011-02-04  Pavel Podivilov  <podivilov@chromium.org>
3107
3108         Reviewed by Pavel Feldman.
3109
3110         Web Inspector: evaluate on hover does not work on a breakpoint.
3111         https://bugs.webkit.org/show_bug.cgi?id=53768
3112
3113         * inspector/front-end/SourceFrame.js:
3114         (WebInspector.SourceFrame.prototype._mouseHover):
3115
3116 2011-02-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3117
3118         Unreviewed, rolling out r77625 and r77626.
3119         http://trac.webkit.org/changeset/77625
3120         http://trac.webkit.org/changeset/77626
3121         https://bugs.webkit.org/show_bug.cgi?id=53765
3122
3123         It broke Windows builds (Requested by Ossy_ on #webkit).
3124
3125         * Android.jscbindings.mk:
3126         * CMakeLists.txt:
3127         * ForwardingHeaders/pcre/pcre.h: Added.
3128         * ForwardingHeaders/yarr/Yarr.h: Removed.
3129         * ForwardingHeaders/yarr/YarrInterpreter.h: Removed.
3130         * ForwardingHeaders/yarr/YarrPattern.h: Removed.
3131         * WebCore.gyp/WebCore.gyp:
3132         * WebCore.pro:
3133         * WebCore.vcproj/WebCore.vcproj:
3134         * WebCore.vcproj/copyForwardingHeaders.cmd:
3135         * platform/text/RegularExpression.cpp:
3136         (WebCore::RegularExpression::Private::regexp):
3137         (WebCore::RegularExpression::Private::compile):
3138         (WebCore::RegularExpression::Private::Private):
3139         (WebCore::RegularExpression::Private::create):
3140         (WebCore::RegularExpression::Private::~Private):
3141         (WebCore::RegularExpression::match):
3142
3143 2011-02-04  Peter Varga  <pvarga@webkit.org>
3144
3145         Rubber-stamped by Csaba Osztrogonác.
3146
3147         Replace PCRE with Yarr in WebCore
3148         https://bugs.webkit.org/show_bug.cgi?id=53496
3149
3150         Speculative windows build fix.
3151
3152         No new tests needed.
3153
3154         * platform/text/RegularExpression.cpp:
3155
3156 2011-02-04  Peter Varga  <pvarga@webkit.org>
3157
3158
3159         Reviewed by Gavin Barraclough.
3160
3161         Replace PCRE with Yarr in WebCore
3162         https://bugs.webkit.org/show_bug.cgi?id=53496
3163
3164         No new tests needed.
3165
3166         * Android.jscbindings.mk:
3167         * CMakeLists.txt:
3168         * ForwardingHeaders/pcre/pcre.h: Removed.
3169         * ForwardingHeaders/yarr/Yarr.h: Added.
3170         * ForwardingHeaders/yarr/YarrInterpreter.h: Added.
3171         * ForwardingHeaders/yarr/YarrPattern.h: Added.
3172         * WebCore.gyp/WebCore.gyp:
3173         * WebCore.pro:
3174         * WebCore.vcproj/WebCore.vcproj:
3175         * WebCore.vcproj/copyForwardingHeaders.cmd:
3176         * platform/text/RegularExpression.cpp:
3177         (WebCore::RegularExpression::Private::create):
3178         (WebCore::RegularExpression::Private::Private):
3179         (WebCore::RegularExpression::Private::compile):
3180         (WebCore::RegularExpression::match):
3181
3182 2011-02-04  Pavel Feldman  <pfeldman@chromium.org>
3183
3184         Reviewed by Yury Semikhatsky.
3185
3186         Web Inspector: Network panel filtering is broken.
3187         https://bugs.webkit.org/show_bug.cgi?id=53764
3188
3189         * inspector/front-end/NetworkPanel.js:
3190         (WebInspector.NetworkPanel.prototype._sortItems):
3191         (WebInspector.NetworkPanel.prototype._sortByTimeline):
3192         (WebInspector.NetworkPanel.prototype._filter):
3193         (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
3194         (WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
3195         (WebInspector.NetworkDataGridNode.prototype.get selectable):
3196         (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut):
3197         (WebInspector.NetworkTotalGridNode.prototype.get selectable):
3198
3199 2011-02-04  Andrey Kosyakov  <caseq@chromium.org>
3200
3201         Reviewed by Pavel Feldman.
3202
3203         Web Inspector: support overriding user agent strings
3204         https://bugs.webkit.org/show_bug.cgi?id=51485
3205
3206         Test: http/tests/inspector/extensions-useragent.html
3207
3208         * inspector/Inspector.idl:
3209         * inspector/InspectorController.cpp:
3210         (WebCore::InspectorController::disconnectFrontend):
3211         (WebCore::InspectorController::setUserAgentOverride):
3212         (WebCore::InspectorController::userAgentOverride):
3213         * inspector/InspectorController.h:
3214         * inspector/front-end/ExtensionAPI.js:
3215         (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload):
3216         * inspector/front-end/ExtensionServer.js:
3217         (WebInspector.ExtensionServer.prototype._onReload):
3218         * loader/FrameLoader.cpp:
3219         (WebCore::FrameLoader::userAgent):
3220         (WebCore::FrameLoader::applyUserAgent):
3221
3222 2011-02-04  Pavel Podivilov  <podivilov@chromium.org>
3223
3224         Reviewed by Pavel Feldman.
3225
3226         Web Inspector: scripts panel displays wrong file name after reload.
3227         https://bugs.webkit.org/show_bug.cgi?id=53761
3228
3229         * inspector/front-end/ScriptsPanel.js:
3230         (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
3231
3232 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
3233
3234         Reviewed by Pavel Feldman.
3235
3236         Web Inspector: remove settings related methods from InspectorClient
3237         https://bugs.webkit.org/show_bug.cgi?id=53686
3238
3239         * WebCore.exp.in:
3240         * inspector/CodeGeneratorInspector.pm:
3241         * inspector/InspectorClient.h:
3242         * inspector/InspectorFrontendClientLocal.cpp:
3243         (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
3244         (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
3245         (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
3246         * inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can
3247         provide platform-specific settings accessor.
3248         (WebCore::InspectorFrontendClientLocal::Settings::Settings):
3249         (WebCore::InspectorFrontendClientLocal::Settings::~Settings):
3250         (WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight):
3251         (WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight):
3252         * loader/EmptyClients.h:
3253
3254 2011-02-03  Anton Muhin  <antonm@chromium.org>
3255
3256         Reviewed by Adam Barth.
3257
3258         [v8] frame several more JS code invocations into v8::TryCatch
3259         https://bugs.webkit.org/show_bug.cgi?id=53594
3260
3261         This patch is preemptive and adjusts v8 bindings code to forthcoming small change
3262         in v8::ThrowException---currently sometimes exceptions thrown by this method
3263         do not reach surrounding v8::TryCatch handler (see
3264         http://code.google.com/p/v8/issues/detail?id=1072 and
3265         http://codereview.chromium.org/6397011/).  Therefore the goal of this patch
3266         is to make forthcoming v8 roll as smooth as possible (alas, we'll still need
3267         one rebaseline as of now.)
3268
3269         * bindings/v8/V8Proxy.cpp:
3270         (WebCore::V8Proxy::runScript): Do not rely on empty handle as a signal of exception, wrap into v8::TryCatch instead
3271         * bindings/v8/V8WindowErrorHandler.cpp:
3272         (WebCore::V8WindowErrorHandler::callListenerFunction): Ditto
3273
3274 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
3275
3276         Reviewed by Dan Bernstein.
3277
3278         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
3279         https://bugs.webkit.org/show_bug.cgi?id=52897
3280         <rdar://problem/8898294>
3281
3282         * WebCore.exp.in: Add export now needed by WebKit2
3283
3284 2011-02-03  Victoria Kirst  <vrk@google.com>
3285
3286         Reviewed by James Robinson.
3287
3288         Replaces float literals with uniform values in shader code
3289         so that buggy drivers unable to parse float values in different
3290         locales will not produce a pink video.
3291
3292         [chromium] Fix pink video bug with gpu-acceleration enabled
3293         https://bugs.webkit.org/show_bug.cgi?id=53568
3294
3295         * platform/graphics/chromium/VideoLayerChromium.cpp:
3296         (WebCore::VideoLayerChromium::SharedValues::SharedValues):
3297         (WebCore::VideoLayerChromium::drawYUV):
3298         * platform/graphics/chromium/VideoLayerChromium.h:
3299         (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):
3300
3301 2011-02-03  James Kozianski  <koz@chromium.org>
3302
3303         Reviewed by Dimitri Glazkov.
3304
3305         Add navigator.registerProtocolHandler behind a flag.
3306         https://bugs.webkit.org/show_bug.cgi?id=52609
3307
3308         This method is described in the HTML5 specification here,
3309         http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
3310
3311         This change is largely cribbed from B. Green's 29651 patches. It is
3312         behind a flag so as not to break JS feature detection.
3313
3314         New layout test fast/dom/registerProtocolHandler.html.
3315
3316         * Configurations/FeatureDefines.xcconfig:
3317         * loader/EmptyClients.h:
3318         (WebCore::EmptyChromeClient::registerProtocolHandler):
3319         * page/Chrome.cpp:
3320         (WebCore::Chrome::registerProtocolHandler):
3321         * page/Chrome.h:
3322         * page/ChromeClient.h:
3323         * page/Navigator.cpp:
3324         (WebCore::verifyCustomHandlerURL):
3325         (WebCore::verifyProtocolHandlerScheme):
3326         (WebCore::Navigator::registerProtocolHandler):
3327         * page/Navigator.h:
3328         * page/Navigator.idl:
3329
3330 2011-02-03  Brian Ryner  <bryner@chromium.org>
3331
3332         Reviewed by Darin Fisher.
3333
3334         Add a field to the ResourceResponse for tracking the socket address
3335         of the host that the resource was fetched from.  Patch was originally
3336         by Paul Marks.
3337         https://bugs.webkit.org/show_bug.cgi?id=53699
3338
3339         * platform/network/chromium/ResourceResponse.cpp:
3340         (WebCore::ResourceResponse::doPlatformCopyData):
3341         (WebCore::ResourceResponse::doPlatformAdopt):
3342         * platform/network/chromium/ResourceResponse.h:
3343         (WebCore::ResourceResponse::socketAddress):
3344         (WebCore::ResourceResponse::setSocketAddress):
3345
3346 2011-02-03  Adam Langley  <agl@chromium.org>
3347
3348         Reviewed by Adam Barth.
3349
3350         Plumb mixed script URL to FrameLoaderClient
3351         https://bugs.webkit.org/show_bug.cgi?id=52384
3352
3353         Regressions covered by http/tests/security/mixedContent/*
3354
3355         * loader/EmptyClients.h:
3356         (WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
3357         * loader/FrameLoader.cpp:
3358         (WebCore::FrameLoader::checkIfRunInsecureContent):
3359         * loader/FrameLoaderClient.h:
3360
3361 2011-02-03  Simon Fraser  <simon.fraser@apple.com>
3362
3363         Reviewed by Dan Bernstein.
3364
3365         REGRESSION: Artifacts on box-shadow corners in some cases
3366         https://bugs.webkit.org/show_bug.cgi?id=53731
3367
3368         Fix overdrawing artifacts in ShadowBlur's tiling code path,
3369         which show up in shadows using a color with alpha.
3370         
3371         Test: fast/box-shadow/shadow-tiling-artifact.html
3372
3373         * platform/graphics/ShadowBlur.cpp:
3374         (WebCore::ShadowBlur::drawRectShadowWithTiling): Ensure
3375         that the inner rect that gets filled does not overlap with any
3376         of the eight tiled areas by having the corner and side dimensions
3377         be the same for contiguous areas.
3378
3379 2011-02-03  Adam Barth  <abarth@webkit.org>
3380
3381         Reviewed by Alexey Proskuryakov.
3382
3383         XSS Auditor is spinning inside decodeURLEscapeSequences() if there are
3384         percent signs in large posted data
3385         https://bugs.webkit.org/show_bug.cgi?id=53405
3386
3387         If the input string contains many non-% characters followed by a %
3388         character that is not a valid URL escape sequence, then the old
3389         algorithm would only advance the initial search by one character
3390         (instead of jumping to just after the % character).  That would cause
3391         the algorithm to take N^2 time (in the number of characters before the
3392         first % character).  This patch just advances the search past the first
3393         % character so we can start looking for next % character sooner.
3394
3395         * platform/KURL.cpp:
3396         (WebCore::decodeURLEscapeSequences):
3397
3398 2011-02-03  Pavel Podivilov  <podivilov@chromium.org>
3399
3400         Reviewed by Pavel Feldman.
3401
3402         Web Inspector: click on a breakpoint highlights wrong line in source frame.
3403         https://bugs.webkit.org/show_bug.cgi?id=53692
3404
3405         * inspector/front-end/BreakpointsSidebarPane.js:
3406         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement):
3407
3408 2011-02-03  Anton Muhin  <antonm@chromium.org>
3409
3410         Reviewed by Adam Barth.
3411
3412         [v8] Bail out if to string conversion returned empty handle
3413         https://bugs.webkit.org/show_bug.cgi?id=53687
3414
3415         This a temporary measure: actually one probably should never get empty handle
3416         if there was no exception.  The root cause is under investigation.
3417         The bailout though allows Chromium not to crash---attempt to convert an empty
3418         v8 hande into WebCore string crashes with invalid memory access.
3419
3420         See http://code.google.com/p/chromium/issues/detail?id=71544
3421
3422         There is no known reduction expressible as a layout test so far.  The crash found with automated testing tools.
3423
3424         * bindings/v8/V8Binding.cpp:
3425         (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
3426         * bindings/v8/V8Binding.h:
3427         (WebCore::V8ParameterBase::prepareBase): Ditto
3428
3429 2011-02-03  Adam Barth  <abarth@webkit.org>
3430
3431         Attempt to fix Chromium build.
3432
3433         * html/parser/XSSFilter.cpp:
3434
3435 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
3436
3437         Unreviewed, rolling out r77562.
3438         http://trac.webkit.org/changeset/77562
3439         https://bugs.webkit.org/show_bug.cgi?id=53630
3440
3441         broke chromium mac build
3442
3443         * WebCore.gyp/WebCore.gyp:
3444         * WebCore.gyp/mac/check_objc_rename.sh: Removed.
3445
3446 2011-02-03  Adam Barth  <abarth@webkit.org>
3447
3448         Reviewed by Daniel Bates.
3449
3450         XSS Auditor severely affects loading performance after submitting a large form
3451         https://bugs.webkit.org/show_bug.cgi?id=49845
3452
3453         Switch over from the XSSAuditor to the XSSFilter, improving performance
3454         on this example.
3455
3456         * html/parser/XSSFilter.cpp:
3457         (WebCore::XSSFilter::filterToken):
3458         * page/XSSAuditor.cpp:
3459         (WebCore::XSSAuditor::isEnabled):
3460
3461 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
3462
3463         Unreviewed, rolling out r77567.
3464         http://trac.webkit.org/changeset/77567
3465         https://bugs.webkit.org/show_bug.cgi?id=53468
3466
3467         broke chromium linux svg, canvas tests, possibly win also?
3468
3469         * platform/graphics/skia/ImageBufferSkia.cpp:
3470         (WebCore::getImageData):
3471         (WebCore::ImageBuffer::getUnmultipliedImageData):
3472         (WebCore::ImageBuffer::getPremultipliedImageData):
3473         (WebCore::putImageData):
3474         (WebCore::ImageBuffer::putUnmultipliedImageData):
3475         (WebCore::ImageBuffer::putPremultipliedImageData):
3476
3477 2011-02-02  MORITA Hajime  <morrita@google.com>
3478
3479         Reviewed by Dimitri Glazkov.
3480
3481         Refactoring: <progress> should not use ShadowElement
3482         https://bugs.webkit.org/show_bug.cgi?id=53583
3483
3484         - Introduced RenderIndicatorPart and RenderProgressBarValuePart
3485           to be responsible for bar-part layout,
3486           which adopted layout logic from ShadowBlockElement.
3487         - ProgressBarValueElement is no longer a subclass of ShadowBlockElement.
3488         - Remove dependency from RenderProgress to HTMLProgressElement and
3489           ShadowBlockElement.
3490         - The shadow tree is no longer removed on detach(). It becomes persistent.
3491           This is now possible because the ShadowBlockElement dependency is gone.
3492         - ::-webkit-appearance for -webkit-progress-bar-value is no longer referred.
3493           That didn't make sense.
3494
3495         * html/HTMLProgressElement.cpp:
3496         (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
3497         * html/HTMLProgressElement.h:
3498         * html/shadow/ProgressBarValueElement.h: Added.
3499         (WebCore::ProgressBarValueElement::ProgressBarValueElement):
3500         (WebCore::ProgressBarValueElement::shadowPseudoId):
3501         (WebCore::ProgressBarValueElement::createRenderer):
3502         (WebCore::ProgressBarValueElement::create):
3503         * rendering/RenderIndicator.cpp:
3504         (WebCore::RenderIndicatorPart::RenderIndicatorPart):
3505         (WebCore::RenderIndicatorPart::~RenderIndicatorPart):
3506         (WebCore::RenderIndicatorPart::layout):
3507         (WebCore::RenderIndicatorPart::styleDidChange):
3508         * rendering/RenderIndicator.h: Added RenderIndicatorPart class
3509         (WebCore::RenderIndicatorPart::originalVisibility):
3510         (WebCore::RenderIndicatorPart::requiresForcedStyleRecalcPropagation):
3511         (WebCore::RenderIndicatorPart::canHaveChildren):
3512         * rendering/RenderProgress.cpp:
3513         (WebCore::RenderProgressBarValuePart::preferredFrameRect):
3514         (WebCore::RenderProgressBarValuePart::shouldBeHidden):
3515         (WebCore::RenderProgress::updateFromElement):
3516         (WebCore::RenderProgress::layoutParts):
3517         (WebCore::RenderProgress::shouldHaveParts):
3518         * rendering/RenderProgress.h:
3519         (WebCore::RenderProgressBarValuePart::RenderProgressBarValuePart):
3520
3521 2011-02-03  Jia Pu  <jpu@apple.com>
3522
3523         Reversion should not be marked as misspelled.
3524         https://bugs.webkit.org/show_bug.cgi?id=53255
3525
3526         This patch includes fix for reported bug, and also some housekeeping changes.
3527
3528         To implement desired behavior, we need:
3529         1. Add a new marker type, SpellCheckingExemption, since now we distingusish between text
3530            that shouldn't be spellchecked and text shouldn't be autocorrected.
3531         2. Make sure that there is no pending correction panel when we enter markAllMisspellingsAndBadGrammarInRanges().
3532            Otherwise the spell checking code in that function may interfere with autocorrection. This
3533            is achieved by explicitly applying pending correction when user types space, line break or
3534            paragraph break.
3535
3536         Housekeeping code changes include:
3537         1. Change manual-tests that were broken by relocated WebCore directory.
3538         2. Use TextIterator in various DocumentMarkerController functions instead of using
3539            Node::traverseNextNode() directly.
3540         3. Allow passing multiple marker types into DocumentMarkerController::removeMarkers() and
3541            DocumentMarkerController::hasMarkers() to improve clarity and efficiency.
3542         4. Fixes of minor bugs that were exposed previously.
3543
3544         * WebCore.exp.in: Change signature of DocumentMarkerController::removeMarkers().
3545
3546         * dom/DocumentMarker.h: Added new marker type SpellCheckingExemption.
3547
3548         * dom/DocumentMarkerController.cpp:
3549         (WebCore::DocumentMarkerController::removeMarkers): Use TextIterator to scan the range to be
3550            consistent with addMarker() function. Allow passing in multiple marker types in one call.
3551            Added a boolean argument to specify the behavior when removing markers that partially
3552            overlap the specified range.
3553         (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Allow passing in
3554            multiple marker types in one call.
3555         (WebCore::DocumentMarkerController::hasMarkers): Use TextIterator to scan the range to be
3556            consistent with addMarker() function. Allow passing in multiple marker types in one call.
3557
3558         * dom/DocumentMarkerController.h: Allow passing in multiple marker types to removeMarkers()
3559            and hasMarkers(). Added a boolean argument to removeMarkers() to specify the behavior when
3560            removing markers that partially overlap the specified range.
3561
3562         * editing/Editor.cpp:
3563         (WebCore::markerTypesForAutocorrection): Add SpellCheckingExemption marker when apply correction.
3564         (WebCore::markerTypesForReplacement): Ditto.
3565         (WebCore::Editor::respondToChangedSelection): Reordered call to dismissCorrectionPanel() and
3566            setSelection() to make sure there is no pending correction when entering
3567            markAllMisspellingsAndBadGrammarInRanges().
3568         (WebCore::Editor::appliedEditing): Only remove CorrectionIndicator markers when the command
3569            is a top level command to improve efficiency.
3570         (WebCore::Editor::insertTextWithoutSendingTextEvent): Added code to applying pending correction.
3571         (WebCore::Editor::insertLineBreak): Ditto.
3572         (WebCore::Editor::insertParagraphSeparator): Ditto.
3573         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Don't mark mispelling if the
3574            text carries SpellCheckingExemption marker.
3575         (WebCore::Editor::correctionPanelTimerFired): Reset correction panel if the returned suggestion
3576            from spellchecker is an empty string.
3577         (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
3578            Use new DocumentMarkerController::removeMarkers() to replace custom implemenation to improve
3579            efficiency and readability.
3580         (WebCore::Editor::applyCorrectionPanelInfo): Remove the code that set caret position after
3581            applying correction, since it's unnecessary. Also, store pre-correction string together with
3582            the marker for reversion panel to use.
3583         (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate): Apply pending correction.
3584         (WebCore::Editor::changeSelectionAfterCommand): Moved marker removal code to Editor::appliedEditing()
3585            where we have access to EditCommand object.
3586
3587         * editing/Editor.h: Added new function applyAutocorrectionAfterTypingIfAppropriate().
3588
3589         * manual-tests/autocorrection/autocorrection-cancelled-by-ESC.html: Change manual-tests that
3590            were broken by relocated WebCore directory.
3591
3592         * manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Ditto.
3593
3594         * manual-tests/autocorrection/autocorrection-contraction.html: Ditto.
3595
3596         * manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Ditto.
3597
3598         * manual-tests/autocorrection/delete-to-dismiss-reversion.html: Ditto.
3599
3600         * manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Ditto.
3601
3602         * manual-tests/autocorrection/dismiss-multiple-guesses.html: Ditto.
3603
3604         * manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Ditto.
3605
3606         * manual-tests/autocorrection/select-from-multiple-guesses.html: Ditto.
3607
3608         * manual-tests/autocorrection/spell-checking-after-reversion.html: Added.
3609
3610         * manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Change manual-tests that
3611            were broken by relocated WebCore directory.
3612
3613         * rendering/InlineTextBox.cpp:
3614         (WebCore::InlineTextBox::paintDocumentMarkers): Code clean-up to be more concise.
3615
3616 2011-02-03  Abhishek Arya  <inferno@chromium.org>
3617
3618         Unreviewed, qt build fix.
3619
3620         * rendering/RenderBlock.cpp:
3621         (WebCore::RenderBlock::removeFloatingObject):
3622
3623 2011-02-03  Brian Salomon  <bsalomon@google.com>
3624
3625         Reviewed by James Robinson.
3626
3627         Handle non-raster backed images in getUnmultipliedImageData()
3628         https://bugs.webkit.org/show_bug.cgi?id=53468
3629
3630         No new tests. Existing canvas tests sufficient
3631         LayoutTests/canvas/philip/...
3632
3633         * platform/graphics/skia/ImageBufferSkia.cpp:
3634         (WebCore::getImageData):
3635         (WebCore::ImageBuffer::getUnmultipliedImageData):
3636         (WebCore::ImageBuffer::getPremultipliedImageData):
3637         (WebCore::putImageData):
3638         (WebCore::ImageBuffer::putUnmultipliedImageData):
3639         (WebCore::ImageBuffer::putPremultipliedImageData):
3640
3641 2011-02-03  Abhishek Arya  <inferno@chromium.org>
3642
3643         Reviewed by James Robinson.
3644
3645         Enforce more limits on root inline boxes height calculations.
3646         https://bugs.webkit.org/show_bug.cgi?id=53729
3647
3648         Test: fast/overflow/overflow-height-float-not-removed-crash.html
3649
3650         * rendering/RenderBlock.cpp:
3651         (WebCore::RenderBlock::removeFloatingObject): prevent logicalBottom to
3652         become negative when logicalTop is INT_MAX.
3653         (WebCore::RenderBlock::markLinesDirtyInBlockRange): when logicalBottom
3654         is INT_MAX, we should dirty everything. So, we bail out to make
3655         afterLowest equal to the lastRootBox() or lowestDirstLine.
3656
3657 2011-02-03  David Levin  <levin@chromium.org>
3658
3659         Reviewed by Adam Barth and Oliver Hunt.
3660
3661         Worker.importScript() should clean errors for cross origin imports.
3662         https://bugs.webkit.org/show_bug.cgi?id=52871
3663
3664         Test: http/tests/workers/worker-importScriptsOnError.html
3665
3666         * bindings/js/WorkerScriptController.cpp:
3667         (WebCore::WorkerScriptController::evaluate): Use sanitizeScriptError
3668         to determine when to create a clean exception.
3669         * bindings/v8/WorkerContextExecutionProxy.cpp:
3670         (WebCore::WorkerContextExecutionProxy::evaluate): Ditto.
3671         * dom/ScriptExecutionContext.cpp:
3672         (WebCore::ScriptExecutionContext::sanitizeScriptError): Figure out
3673         if the error needs to be cleaned up.
3674         (WebCore::ScriptExecutionContext::dispatchErrorEvent): Extracted
3675         sanitizeScriptError for use by other places.
3676         * dom/ScriptExecutionContext.h:
3677         * workers/WorkerContext.cpp:
3678         (WebCore::WorkerContext::importScripts): Use the reponse url when
3679         telling the evaluate where the script came fro.
3680         * workers/WorkerScriptLoader.cpp:
3681         (WebCore::WorkerScriptLoader::responseURL): Expose the url that
3682         the script was loaded from (which may be different from url() due
3683         to redirects).
3684         (WebCore::WorkerScriptLoader::didReceiveResponse): Capture the reponse url.
3685         * workers/WorkerScriptLoader.h:
3686
3687 2011-02-03  Mark Mentovai  <mark@chromium.org>
3688
3689         Reviewed by Dimitri Glazkov.
3690
3691         Chromium GYP build fix.
3692
3693         When various settings were moved to webcore_prerequisites in r66364,
3694         things that should have been direct_dependent_settings were not marked
3695         as such. GYP 'defines', for example, make no sense on a 'none'-type
3696         target such as webcore_prerequisites. It appears that it was intended
3697         for these settings to be pushed to direct dependents, which would make
3698         direct_dependent_settings correct.
3699
3700         Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
3701         http://crbug.com/71537, which at best causes Mac console log spew, and
3702         at worst may result in Chromium's copy of WebCore using system
3703         definitions of certain Objective-C classes at runtime, or vice-versa.
3704
3705         The build now includes a postbuild step to prevent
3706         http://crbug.com/71537 from regressing again. The build will fail upon
3707         regression.
3708
3709         https://bugs.webkit.org/show_bug.cgi?id=53630
3710
3711         * WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into
3712           direct_dependent_settings as needed, add the check_objc_rename
3713           postbuild step.
3714         * WebCore.gyp/mac/check_objc_rename.sh: Added.
3715
3716 2011-02-03  Adam Barth  <abarth@webkit.org>
3717
3718         Reviewed by Eric Seidel.
3719
3720         Make XSSFilter go fast by adding a SuffixTree
3721         https://bugs.webkit.org/show_bug.cgi?id=53665
3722
3723         The SuffixTree lets us quickly reject snippets if the POST data is
3724         large (because we can avoid a linear scan over the POST data).
3725
3726         * html/parser/XSSFilter.cpp:
3727         (WebCore::XSSFilter::init):
3728         (WebCore::XSSFilter::isContainedInRequest):
3729         * html/parser/XSSFilter.h:
3730
3731 2011-02-03  Mihai Parparita  <mihaip@chromium.org>
3732
3733         Reviewed by Alexey Proskuryakov.
3734
3735         REGRESSION (r77355): Page cache layout tests crash
3736         https://bugs.webkit.org/show_bug.cgi?id=53648
3737
3738         Test: fast/events/pagehide-timeout.html
3739         
3740         Suspend active DOM objects after all pagehide event handlers have run,
3741         otherwise it's possible for them to create more objects that weren't
3742         getting suspended.
3743
3744         * history/CachedFrame.cpp:
3745         (WebCore::CachedFrame::CachedFrame):
3746
3747 2011-02-03  Jeremy Orlow  <jorlow@chromium.org>
3748
3749         Reviewed by Nate Chapin.
3750
3751         SerializedScriptValue should not require v8 to create undefined and null values
3752         https://bugs.webkit.org/show_bug.cgi?id=53730
3753
3754         Instead of creating a v8 type and passing that into the constructor, just use
3755         the writer class directly. While I was at it, I cleaned up the code a bit too
3756         by getting rid of the WireData/StringValue enum as I found that personally
3757         confusing.
3758
3759         This is necessary because these methods are called by IndexedDB in the browser
3760         process where v8 is not spun up.
3761
3762         No functionality changed and not possible to test.
3763
3764         * bindings/v8/SerializedScriptValue.cpp:
3765         (WebCore::SerializedScriptValue::createFromWire):
3766         (WebCore::SerializedScriptValue::create):
3767         (WebCore::SerializedScriptValue::nullValue):
3768         (WebCore::SerializedScriptValue::undefinedValue):
3769         (WebCore::SerializedScriptValue::release):
3770         (WebCore::SerializedScriptValue::SerializedScriptValue):
3771         * bindings/v8/SerializedScriptValue.h:
3772
3773 2011-02-03  Beth Dakin  <bdakin@apple.com>
3774
3775         Reviewed by Sam Weinig.
3776
3777         Fix for <rdar://problem/8944544> Ability to animate track
3778         for WKPainter scrollers
3779
3780         Two new WebKitSystemInterface functions.
3781         * WebCore.exp.in:
3782         * platform/mac/WebCoreSystemInterface.h:
3783         * platform/mac/WebCoreSystemInterface.mm:
3784
3785         Use Scrollbar::convertFromContainingView() to return the right point.
3786         * platform/mac/ScrollAnimatorMac.mm:
3787         (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
3788         
3789         ScrollKnobAnimation is now ScrollbarPartAnimation. It can
3790         now be used to animate the knob or the track.
3791         (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
3792         (-[ScrollbarPartAnimation setCurrentProgress:]):
3793         (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
3794         (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
3795         (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
3796
3797         Scrollbars need invalodating after the overlay state changes. 
3798         (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
3799
3800 2011-02-03  Sam Weinig  <sam@webkit.org>
3801
3802         Reviewed by Beth Dakin.
3803
3804         Scroll thumb jumps to top when resizing horizontally.
3805
3806         * platform/ScrollView.cpp:
3807         (WebCore::ScrollView::updateScrollbars): Add call to update
3808         the scrollbar's offset in the case where we may have created
3809         a new scrollbar but have not changed the current position.
3810
3811 2011-02-03  Justin Schuh  <jschuh@chromium.org>
3812
3813         Reviewed by Dirk Schulze.
3814
3815         startAnimations should use a local, RefCounted Vector.
3816         https://bugs.webkit.org/show_bug.cgi?id=53458
3817
3818         Test: svg/custom/use-animation-in-fill.html
3819
3820         * svg/SVGDocumentExtensions.cpp:
3821         (WebCore::SVGDocumentExtensions::startAnimations):
3822
3823 2011-02-03  Adam Barth  <abarth@webkit.org>
3824
3825         Reviewed by Daniel Bates.
3826
3827         XSSFilter shouldn't bother to analyze pages without "injection"
3828         characters in the request
3829         https://bugs.webkit.org/show_bug.cgi?id=53664
3830
3831         If the request lacks these "injection" characters, then it's unlikely
3832         that there's a reflective XSS attack happening.  This hueristic lets us
3833         avoid analyzing the vast majority of responses for XSS.  Of course, the
3834         hueristic isn't perfect.  Because of this huerstic, we miss out on
3835         injections into unquoted attributes.  However, it's a trade-off that's
3836         worked well in the XSSAuditor.
3837
3838         * html/parser/XSSFilter.cpp:
3839         (WebCore::HTMLNames::isRequiredForInjection):
3840         (WebCore::XSSFilter::XSSFilter):
3841         (WebCore::XSSFilter::init):
3842         (WebCore::XSSFilter::filterToken):
3843         (WebCore::XSSFilter::isContainedInRequest):
3844         * html/parser/XSSFilter.h:
3845
3846 2011-02-03  Vangelis Kokkevis  <vangelis@chromium.org>
3847
3848         Reviewed by Kenneth Russell.
3849
3850         [chromium] Fixing a compositor crash occurring on layers
3851         without an associated RenderSurface.
3852         https://bugs.webkit.org/show_bug.cgi?id=53679
3853         Regression was introduced by in r77425 
3854
3855         Test: http://webkit.org/blog/386/3d-transforms/ doesn't crash
3856         anymore.
3857
3858         * platform/graphics/chromium/LayerRendererChromium.cpp:
3859         (WebCore::LayerRendererChromium::drawLayer):
3860
3861 2011-02-03  Dan Bernstein  <mitz@apple.com>
3862
3863         Reviewed by Anders Carlsson.
3864
3865         <rdar://problem/8948788> Text emphasis marks have wrong orientation for vertical text
3866         https://bugs.webkit.org/show_bug.cgi?id=53709
3867
3868         Covered by rendering of fast/text/emphasis-vertical.html
3869
3870         * platform/graphics/mac/SimpleFontDataMac.mm:
3871         (WebCore::SimpleFontData::scaledFontData): Give the scaled font the same orientation this font
3872         has.
3873
3874 2011-02-02  Levi Weintraub  <leviw@chromium.org>
3875
3876         Reviewed by Ryosuke Niwa.
3877
3878         Moving cursor down in table cycles at the end of a row
3879         https://bugs.webkit.org/show_bug.cgi?id=50012
3880
3881         Avoids a caret cycling issue with certain content (e.g. tables) found at the very
3882         end of a document due to a bug in nextLeafWithSameEditability.
3883
3884         Test: editing/selection/move-by-line-cycles-in-table.html
3885
3886         * editing/visible_units.cpp:
3887         (WebCore::nextLeafWithSameEditability): Properly avoid descending back into the
3888         original leaf node.
3889
3890 2011-02-03  Pavel Podivilov  <podivilov@chromium.org>
3891
3892         Reviewed by Pavel Feldman.
3893
3894         Web Inspector: remove dead code related to changes panel.
3895         https://bugs.webkit.org/show_bug.cgi?id=53688
3896
3897         * WebCore.gypi:
3898         * WebCore.vcproj/WebCore.vcproj:
3899         * inspector/front-end/ChangesView.js: Removed.
3900         * inspector/front-end/WebKit.qrc:
3901         * inspector/front-end/inspector.css:
3902         (#error-warning-count):
3903         (#error-warning-count:hover):
3904         (#error-count + #warning-count):
3905         * inspector/front-end/inspector.html:
3906         * inspector/front-end/inspector.js:
3907
3908 2011-02-02  Sam Weinig  <sam@webkit.org>
3909
3910         Reviewed by Anders Carlsson.
3911
3912         Add notification of the end of a rubber band.
3913         <rdar://problem/8940648>
3914
3915         * WebCore.exp.in:
3916         Add additional exprots.
3917
3918         * page/ChromeClient.h:
3919         (WebCore::ChromeClient::didCompleteRubberBandForMainFrame):
3920         * page/FrameView.cpp:
3921         (WebCore::FrameView::didCompleteRubberBand):
3922         * page/FrameView.h:
3923         * platform/ScrollView.cpp:
3924         (WebCore::ScrollView::didCompleteRubberBand):
3925         * platform/ScrollView.h:
3926         Add hook.
3927
3928         * platform/ScrollableArea.h:
3929         (WebCore::ScrollableArea::inLiveResize):
3930         (WebCore::ScrollableArea::maximumScrollPosition):
3931         (WebCore::ScrollableArea::visibleWidth):
3932         (WebCore::ScrollableArea::overhangAmount):
3933         (WebCore::ScrollableArea::didCompleteRubberBand):
3934         Reorganize and de-virtualize live resize notifications.
3935
3936         * platform/mac/ScrollAnimatorMac.mm:
3937         (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
3938         Call the new hook when the rubberband ends.
3939
3940 2011-02-02  Evan Martin  <evan@chromium.org>
3941
3942         Reviewed by Tony Chang.
3943
3944         [chromium] complex joining characters positioned in wrong place
3945         https://bugs.webkit.org/show_bug.cgi?id=53637
3946
3947         Provide the correct font metrics to Harfbuzz related to the font design space.
3948         There are used in some fonts for GPOS positioning.
3949
3950         Test: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
3951
3952         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
3953         (WebCore::ComplexTextController::setupFontForScriptRun):
3954         (WebCore::ComplexTextController::allocHarfbuzzFont):
3955         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
3956         (WebCore::FontPlatformData::FontPlatformData):
3957         (WebCore::FontPlatformData::emSizeInFontUnits):
3958         (WebCore::FontPlatformData::operator=):
3959         * platform/graphics/chromium/FontPlatformDataLinux.h:
3960         (WebCore::FontPlatformData::FontPlatformData):
3961
3962 2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>
3963
3964         Reviewed by Kent Tamura.
3965
3966         REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
3967         https://bugs.webkit.org/show_bug.cgi?id=53634
3968
3969         Test: fast/dom/HTMLInputElement/input-slider-update.html
3970
3971         * html/HTMLInputElement.cpp:
3972         (WebCore::HTMLInputElement::setValue): Added a call to InputType::valueChanged.
3973         * html/InputType.cpp:
3974         (WebCore::InputType::valueChanged): Added empty implementation.
3975         * html/InputType.h: Added def.
3976         * html/RangeInputType.cpp:
3977         (WebCore::RangeInputType::valueChanged): Added implementation that dirties layout
3978             bit on the thumb.
3979         * html/RangeInputType.h: Added def.
3980
3981 2011-02-02  Pavel Podivilov  <podivilov@chromium.org>
3982
3983         Reviewed by Pavel Feldman.
3984
3985         Web Inspector: do not share source frames between resources panel and scripts panel.
3986         https://bugs.webkit.org/show_bug.cgi?id=53584
3987
3988         Currently, we show error messages only for resources. This change will allow showing error
3989         messages in source frame even when resource is not available (eval scripts, inlined scripts).
3990
3991         * inspector/front-end/ConsoleView.js:
3992         (WebInspector.ConsoleView.prototype.addMessage):
3993         (WebInspector.ConsoleView.prototype.clearMessages):
3994         * inspector/front-end/ResourceView.js:
3995         (WebInspector.ResourceView.recreateResourceView):
3996         * inspector/front-end/ResourcesPanel.js:
3997         (WebInspector.FrameResourceTreeElement.prototype._setBubbleText):
3998         * inspector/front-end/ScriptsPanel.js:
3999         (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
4000         (WebInspector.ScriptsPanel.prototype.addConsoleMessage):
4001         (WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
4002         (WebInspector.ScriptsPanel.prototype.reset):
4003         (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
4004         (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
4005         (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
4006
4007 2011-02-03  Simon Fraser  <simon.fraser@apple.com>
4008
4009         Fix 32-bit builds.
4010
4011         * platform/graphics/ShadowBlur.cpp:
4012         (WebCore::ShadowBlur::blurLayerImage):
4013
4014 2011-02-03  Mikhail Naganov  <mnaganov@chromium.org>
4015
4016         Reviewed by Pavel Feldman.
4017
4018         Web Inspector: Add reporting of JS heap size limit to 'console.memory'.
4019         https://bugs.webkit.org/show_bug.cgi?id=53592
4020
4021         In JSC there is no limit, thus 'undefined' value is returned.
4022         For V8, the limit reported by the VM is returned.
4023
4024         * Android.jscbindings.mk:
4025         * CMakeLists.txt:
4026         * GNUmakefile.am:
4027         * WebCore.gypi:
4028         * WebCore.pro:
4029         * WebCore.vcproj/WebCore.vcproj:
4030         * WebCore.xcodeproj/project.pbxproj:
4031         * bindings/js/JSBindingsAllInOne.cpp:
4032         * bindings/js/JSMemoryInfoCustom.cpp: Added.
4033         * bindings/js/ScriptGCEvent.cpp:
4034         (WebCore::ScriptGCEvent::getHeapSize):
4035         * bindings/js/ScriptGCEvent.h:
4036         * bindings/v8/ScriptGCEvent.cpp:
4037         (WebCore::ScriptGCEvent::getHeapSize):
4038         * bindings/v8/ScriptGCEvent.h:
4039         * inspector/InspectorTimelineAgent.cpp:
4040         (WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
4041         * page/MemoryInfo.cpp:
4042         (WebCore::MemoryInfo::MemoryInfo):
4043         * page/MemoryInfo.h:
4044         (WebCore::MemoryInfo::jsHeapSizeLimit):
4045         * page/MemoryInfo.idl:
4046
4047 2011-01-27  Philippe Normand  <pnormand@igalia.com>
4048
4049         Reviewed by Martin Robinson.
4050
4051         [GTK] LayoutTests/media/audio-mpeg4-supported.html fails
4052         https://bugs.webkit.org/show_bug.cgi?id=53125
4053
4054         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
4055         (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.
4056
4057 2011-02-03  Simon Fraser  <simon.fraser@apple.com>
4058
4059         Reviewed by Sam Weinig.
4060
4061         ShadowBlur radius for CSS shadows is slightly too big
4062         https://bugs.webkit.org/show_bug.cgi?id=53660
4063         
4064         If we follow SVG gaussian blur for CSS shadows, we can end up rendering
4065         shadows that extend further than the CSS "blur radius", which results
4066         in the shadows being truncated.
4067         
4068         Fix with a small fudge factor to reduce the kernel diameter slightly
4069         for CSS shadows.
4070         
4071         Also more closely follow the algorithm described in the SVG spec
4072         for computing the kernel size for different diameters, and clean up
4073         some variable naming relating to the shadow bounds.
4074
4075         * platform/graphics/ShadowBlur.cpp:
4076         (WebCore::ShadowBlur::blurLayerImage):
4077         (WebCore::ShadowBlur::drawRectShadowWithTiling):
4078
4079 2011-02-01  Pavel Podivilov  <podivilov@chromium.org>
4080
4081         Reviewed by Pavel Feldman.
4082
4083         Web Inspector: introduce new api for managing JavaScript breakpoints.
4084         https://bugs.webkit.org/show_bug.cgi?id=53235
4085
4086         Single protocol breakpoint (e.g. set by url) is mapped on zero or more VM breakpoints (set by sourceID).
4087         removeJavaScriptBreakpoint(breakpointId) removes breakpoint and all linked VM breakpoints.
4088         Since UI uses VM breakpoint location rather then protocol breakpoint location, all resolved breakpoints locations are passed to frontend.
4089
4090         SourceFrame is now aware of whether breakpoint is resolved or not and may display it accordingly.
4091         JavaScriptBreakpointsSidebarPane filters out breakpoints set on nonexistent scripts to avoid UI cluttering.
4092
4093         * bindings/js/ScriptDebugServer.cpp:
4094         (WebCore::ScriptDebugServer::setBreakpoint):
4095         (WebCore::ScriptDebugServer::removeBreakpoint):
4096         * bindings/js/ScriptDebugServer.h:
4097         * bindings/v8/DebuggerScript.js:
4098         ():
4099         * bindings/v8/ScriptDebugServer.cpp:
4100         (WebCore::ScriptDebugServer::setBreakpoint):
4101         * bindings/v8/ScriptDebugServer.h:
4102         * inspector/Inspector.idl:
4103         * inspector/InspectorAgent.cpp: clear breakpoints from inspector state when new frontend is created
4104         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
4105         (WebCore::InspectorAgent::populateScriptObjects):
4106         (WebCore::InspectorAgent::restoreDebugger):
4107         (WebCore::InspectorAgent::showAndEnableDebugger):
4108         (WebCore::InspectorAgent::enableDebugger):
4109         * inspector/InspectorAgent.h:
4110         * inspector/InspectorDebuggerAgent.cpp: manage relations between protocol breakpoints and VM breakpoints
4111         (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
4112         (WebCore::InspectorDebuggerAgent::inspectedURLChanged):
4113         (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
4114         (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpointBySourceId):
4115         (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
4116         (WebCore::InspectorDebuggerAgent::continueToLocation):
4117         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
4118         (WebCore::InspectorDebuggerAgent::getScriptSource):
4119         (WebCore::InspectorDebuggerAgent::didParseSource):
4120         (WebCore::InspectorDebuggerAgent::didPause):
4121         * inspector/InspectorDebuggerAgent.h:
4122         (WebCore::InspectorDebuggerAgent::Script::Script):
4123         * inspector/InspectorValues.cpp:
4124         (WebCore::InspectorValue::asNumber):
4125         (WebCore::InspectorBasicValue::asNumber):
4126         (WebCore::InspectorObject::remove):
4127         * inspector/InspectorValues.h:
4128         (WebCore::InspectorObject::getNumber):
4129         (WebCore::InspectorObject::find):
4130         * inspector/ScriptBreakpoint.h:
4131         (WebCore::ScriptBreakpoint::ScriptBreakpoint):
4132         * inspector/front-end/Breakpoint.js:
4133         (WebInspector.Breakpoint):
4134         (WebInspector.Breakpoint.prototype.addLocation):
4135         * inspector/front-end/BreakpointManager.js: remove all stuff related to JavaScript breakpoints from here