2011-03-06 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-03-06  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Filter sources in WebCore GYP build for Mac
6         https://bugs.webkit.org/show_bug.cgi?id=55857
7
8         This patch removes a large number of files that do not build as part of
9         the Mac build.  I'm not fully sold on this method of
10         including/excluding files, but it's the "gyp way" so we should probably
11         try it first.
12
13         This patch also sets xcode_list_excluded_files to 0, which removes the
14         excluded files from the Xcode project file, which is necessary in order
15         to prevent the header map feature from including the wrong header file.
16
17         * gyp/WebCore.gyp:
18
19 2011-03-07  Ryuan Choi  <ryuan.choi@samsung.com>
20
21         Unreviewed EFL build fix.
22
23         [EFL] Build break on Debug build.
24         https://bugs.webkit.org/show_bug.cgi?id=55858
25
26         * platform/efl/RenderThemeEfl.cpp:
27         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
28
29 2011-03-06  Adam Barth  <abarth@webkit.org>
30
31         Reviewed by Eric Seidel.
32
33         Add webcore_derived_source_files to WebCore.gypi
34         https://bugs.webkit.org/show_bug.cgi?id=55856
35
36         This is the list of files generated by the Mac port.  It's possible
37         other ports generate a different list of files.
38
39         * WebCore.gypi:
40         * gyp/WebCore.gyp:
41
42 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
43
44         Reviewed by Kent Tamura.
45
46         Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
47         https://bugs.webkit.org/show_bug.cgi?id=55839
48         http://crbug.com/73866
49         http://crbug.com/62527
50
51         We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.
52
53         Test: fast/forms/input-appearance-spinbutton-visibility.html
54
55         * rendering/RenderTextControlSingleLine.cpp:
56         (WebCore::RenderTextControlSingleLine::styleDidChange):
57
58 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
59
60         Reviewed by Kent Tamura.
61
62         [Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
63         https://bugs.webkit.org/show_bug.cgi?id=54795
64
65         Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.
66
67         Test: manual-tests/popup-width-restriction-within-screen.html
68
69         * manual-tests/popup-width-restriction-within-screen.html: Added.
70         * platform/chromium/PopupMenuChromium.cpp:
71         (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
72
73 2011-03-06  Yuta Kitamura  <yutak@chromium.org>
74
75         Reviewed by Kent Tamura.
76
77         Add SHA-1 for new WebSocket protocol
78         https://bugs.webkit.org/show_bug.cgi?id=55039
79
80         * ForwardingHeaders/wtf/SHA1.h: Added.
81
82 2011-03-06  Eric Carlson  <eric.carlson@apple.com>
83
84         Reviewed by Antti Koivisto.
85
86         QuickTime based media engines should respect private browsing mode
87         https://bugs.webkit.org/show_bug.cgi?id=55848
88
89         No new tests, it is only possible to test this by manually deleting and monitoring the
90         the Quicktime caches.
91
92         * html/HTMLMediaElement.cpp:
93         (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
94
95         * platform/graphics/MediaPlayer.cpp:
96         (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing.
97         (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine.
98         (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
99         * platform/graphics/MediaPlayer.h:
100         * platform/graphics/MediaPlayerPrivate.h:
101         (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
102
103         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
104         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
105         (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing.
106         (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when
107             creating new movie.
108         (WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in
109             m_privateBrowsing and set movie attribute.
110
111         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
112         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
113             Initialize m_privateBrowsing.
114         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store 
115             privacy setting in m_privateBrowsing and call QTMovie.
116         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
117
118         * platform/graphics/win/QTMovie.cpp:
119         (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing.
120         (QTMovie::load):Pass private browsing property when creating new movie.
121         (QTMovie::setPrivateBrowsingMode):  New, store privacy setting in m_privateBrowsing and 
122             set movie property.
123         * platform/graphics/win/QTMovie.h:
124
125 2011-03-06  Daniel Bates  <dbates@rim.com>
126
127         Reviewed by Darin Adler.
128
129         style.borderSpacing always returns empty string
130         https://bugs.webkit.org/show_bug.cgi?id=54816
131
132         Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
133         the value for border-spacing from the value of the WebKit internal CSS
134         property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
135
136         The CSS property border-spacing describes the horizontal and vertical border
137         spacing for an HTML Table element. Notice, WebKit internally represents the value
138         of this property as two properties: -webkit-border-horizontal-spacing and
139         -webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
140         respectively. And WebKit doesn't know to reconstitute these internal properties.
141         Therefore style.borderSpacing always returns the empty string.
142
143         Test: fast/css/table-border-spacing.html
144
145         * css/CSSMutableStyleDeclaration.cpp:
146         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
147         (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
148         * css/CSSMutableStyleDeclaration.h:
149
150 2011-03-06  Dan Bernstein  <mitz@apple.com>
151
152         Reviewed by Oliver Hunt.
153
154         <rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
155         https://bugs.webkit.org/show_bug.cgi?id=55850
156
157         Tests: fast/css/parsing-hyphenate-limit.html
158                fast/text/hyphenate-limit-before-after.html
159
160         * css/CSSComputedStyleDeclaration.cpp:
161         (WebCore::computedProperties) Updated this array with the new properties and some old properties
162         that it was missing.
163         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
164         CSSPropertyWebkitHyphenateLimit{Before,After}.
165
166         * css/CSSParser.cpp:
167         (WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
168         'auto' and non-negative integers.
169
170         * css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
171
172         * css/CSSStyleSelector.cpp:
173         (WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.
174
175         * rendering/RenderBlockLineLayout.cpp:
176         (WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
177         allow hyphenation if the prefix and the suffix are sufficiently long.
178         (WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().
179
180         * rendering/style/RenderStyle.cpp:
181         (WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.
182
183         * rendering/style/RenderStyle.h:
184         (WebCore::InheritedFlags::hyphenationLimitBefore): Added.
185         (WebCore::InheritedFlags::hyphenationLimitAfter): Added.
186         (WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
187         (WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
188         (WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
189         representation of 'auto'.
190         (WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.
191
192         * rendering/style/StyleRareInheritedData.cpp:
193         (WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
194         (WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.
195         * rendering/style/StyleRareInheritedData.h:
196
197 2011-03-06  Jessie Berlin  <jberlin@apple.com>
198
199         Reviewed by Sam Weinig.
200
201         WebKit2: Use CFNetwork Sessions API.
202         https://bugs.webkit.org/show_bug.cgi?id=55435.
203
204         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
205         Private Browsing Storage Session.
206
207         * WebCore.exp.in:
208         Add the new WKSI functions.
209         * platform/mac/WebCoreSystemInterface.h:
210         Ditto.
211         * platform/mac/WebCoreSystemInterface.mm:
212         Ditto.
213
214         * platform/mac/CookieJar.mm:
215         (WebCore::cookies):
216         If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
217         Otherwise, behave the same as before.
218         (WebCore::cookieRequestHeaderFieldValue):
219         Ditto.
220         (WebCore::setCookies):
221         Ditto.
222         (WebCore::cookiesEnabled):
223         Ditto
224         (WebCore::getRawCookies):
225         Ditto.
226         (WebCore::deleteCookie):
227         Ditto.
228
229         * platform/network/CookieStorage.h:
230         * platform/network/cf/CookieStorageCFNet.cpp:
231         (WebCore::privateBrowsingCookieStorage):
232         Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
233         function instead of at the global scope.
234         (WebCore::currentCookieStorage):
235         Use privateBrowsingCookieStorage.
236         (WebCore::setCurrentCookieStorage):
237         Ditto.
238         (WebCore::setCookieStoragePrivateBrowsingEnabled):
239         If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
240         wkCreatePrivateInMemoryHTTPCookieStorage.
241         * platform/network/mac/CookieStorageMac.mm:
242         (WebCore::privateBrowsingCookieStorage):
243         Keep track of the Private Browsing Cookie Storage.
244         (WebCore::setCookieStoragePrivateBrowsingEnabled):
245         If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
246         Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
247
248         * platform/network/mac/ResourceHandleMac.mm:
249         (WebCore::shouldRelaxThirdPartyCookiePolicy):
250         Refactor the logic to determine whether or not to relax the third party cookie policy here.
251         If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
252         (WebCore::ResourceHandle::createNSURLConnection):
253         Use shouldRelaxThirdPartyCookiePolicy.
254         (WebCore::ResourceHandle::loadResourceSynchronously):
255         Ditto.
256
257 2011-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
258
259         Unreviewed, rolling out r80428.
260         http://trac.webkit.org/changeset/80428
261         https://bugs.webkit.org/show_bug.cgi?id=55833
262
263         Broke SnowLeopard (Requested by xan_ on #webkit).
264
265         * plugins/gtk/PluginViewGtk.cpp:
266         (WebCore::PluginView::handlePostReadFile):
267
268 2011-03-01  Martin Robinson  <mrobinson@igalia.com>
269
270         Reviewed by Xan Lopez.
271
272         [GTK] Windowless plugins override the view cursor
273         https://bugs.webkit.org/show_bug.cgi?id=55531
274
275         manual test: manual-tests/plugins/windowless.html
276
277         * platform/gtk/WidgetGtk.cpp:
278         (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
279         * plugins/gtk/PluginViewGtk.cpp:
280         (WebCore::PluginView::initXEvent): Instead of setting the window for windowless
281         plugin events, set the window value to none. This method is also used to send
282         focus in / focus out events to windowed plugins, but this is not one of the plugin
283         types where the window parameter matters. This matches what Mozilla does. Also
284         pass in the display of the widget itself, not the default display.
285         (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area,
286         reset the cursor.
287         (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
288         widget the top-level window explicitly. This matches Mozilla.
289
290 2011-03-05  Martin Robinson  <mrobinson@igalia.com>
291
292         Reviewed by Xan Lopez.
293
294         [GTK] http/tests/plugins/post-url-file.html fails on GTK+
295         https://bugs.webkit.org/show_bug.cgi?id=55826
296
297         Correct the implementation of handlePostReadFile which uses GIO APIs and
298         actually resizes the buffer to fit the entire size of the file data. This
299         was likely leading to memory corruption until now.
300
301         * plugins/gtk/PluginViewGtk.cpp:
302         (WebCore::PluginView::handlePostReadFile): Fix this method.
303
304 2011-03-05  Mikhail Naganov  <mnaganov@chromium.org>
305
306         Reviewed by Pavel Feldman.
307
308         Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
309         https://bugs.webkit.org/show_bug.cgi?id=55824
310
311         Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
312
313         * inspector/front-end/DetailedHeapshotView.js:
314         (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
315         * inspector/front-end/ProfilesPanel.js:
316         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
317         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
318         (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
319         (WebInspector.ProfilesPanel.prototype.handleShortcut):
320         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint):
321         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint):
322         (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
323         (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
324
325 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
326
327         Reviewed by Laszlo Gombos.
328
329         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
330         https://bugs.webkit.org/show_bug.cgi?id=48636
331
332         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
333
334         * WebCore.pri:
335         * features.pri:
336
337 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
338
339         Not reviewed: adding null check to prevent inspector tests from failing.
340
341         * inspector/front-end/TextViewer.js:
342         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
343         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
344
345 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
346
347         Not reviewed: chromium rebaseline, flaky test fix.
348
349         * inspector/front-end/BreakpointManager.js:
350         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
351         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
352         (WebInspector.DOMBreakpointView.prototype._format.formatters.s):
353         (WebInspector.DOMBreakpointView.prototype._format.append):
354         (WebInspector.DOMBreakpointView.prototype._format):
355
356 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
357
358         Reviewed by Yury Semikhatsky.
359
360         Web Inspector: [chromium] pause when script is running is broken.
361         https://bugs.webkit.org/show_bug.cgi?id=55762
362
363         * inspector/CodeGeneratorInspector.pm:
364
365 2011-03-05  Adam Barth  <abarth@webkit.org>
366
367         Reviewed by Dimitri Glazkov.
368
369         Add Derived Sources to WebCore GYP build
370         https://bugs.webkit.org/show_bug.cgi?id=55813
371
372         Adding the derived source action to the GYP file required tweaking
373         DerivedSources.make.  I'm not sure how DerivedSources.make worked
374         before beause these paths were incorrectly based.
375
376         * DerivedSources.make:
377         * gyp/generate-derived-sources.sh: Added.
378         * gyp/WebCore.gyp:
379
380 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
381
382         Reviewed by Yury Semikhatsky.
383
384         Web Inspector: fix layout tests flakiness.
385         https://bugs.webkit.org/show_bug.cgi?id=55816
386
387         - Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
388         - Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
389
390         * inspector/CodeGeneratorInspector.pm:
391         * inspector/InspectorAgent.cpp:
392         (WebCore::InspectorAgent::InspectorAgent):
393         (WebCore::InspectorAgent::disconnectFrontend):
394         (WebCore::InspectorAgent::populateScriptObjects):
395         (WebCore::InspectorAgent::evaluateForTestInFrontend):
396         (WebCore::InspectorAgent::issueEvaluateForTestCommands):
397         * inspector/InspectorAgent.h:
398         * inspector/front-end/TimelinePanel.js:
399         (WebInspector.TimelinePanel.FormattedRecord):
400         * inspector/front-end/inspector.js:
401         (WebInspector.dispatch):
402
403 2011-03-05  Adam Barth  <abarth@webkit.org>
404
405         Reviewed by Dimitri Glazkov.
406
407         WebCore GYP build should generate fewer than 10,000 compile errors per file
408         https://bugs.webkit.org/show_bug.cgi?id=55810
409
410         This patch adds some missing include paths.  We need to figure out how
411         to handle separate include paths per port.  It's clear that
412         ForwardingHeaders are only useful for Mac, but it's less clear how to
413         handle the others.
414
415         * WebCore.gypi:
416         * gyp/WebCore.gyp:
417
418 2011-03-05  Dan Bernstein  <mitz@apple.com>
419
420         Reviewed by Cameron Zwarich.
421
422         <rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
423         https://bugs.webkit.org/show_bug.cgi?id=55817
424
425         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
426         (WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
427         a CGFont obtained from Core Text for the primary font. This CGFont may be different from
428         the CGFont stored in the FontPlatformData.
429
430 2011-03-05  Ilya Sherman  <isherman@chromium.org>
431
432         Reviewed by Darin Adler.
433
434         HTMLInputElement::setValue() should schedule change event when the element is focused.
435         Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
436         In service of https://code.google.com/p/chromium/issues/detail?id=42716
437         https://bugs.webkit.org/show_bug.cgi?id=53160
438
439         Test: fast/forms/onchange-change-type.html
440         Test: fast/forms/onchange-setvalueforuser.html
441
442         * WebCore.exp.in:
443         * dom/Document.cpp:
444         (WebCore::Document::setFocusedNode):
445         * dom/Element.h:
446         (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
447         (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
448         * html/HTMLFormControlElement.cpp:
449         (WebCore::HTMLFormControlElement::HTMLFormControlElement):
450         (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added.
451         (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added.
452         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
453         (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
454         * html/HTMLFormControlElement.h:
455         * html/HTMLInputElement.cpp:
456         (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag.
457         (WebCore::HTMLInputElement::setValue):
458             For a focused text field, dispatch an input event, but delay the change event until the field loses focus.
459         (WebCore::HTMLInputElement::defaultEventHandler):
460         (WebCore::HTMLInputElement::stepUpFromRenderer):
461         * html/shadow/TextControlInnerElements.cpp:
462         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
463         * rendering/RenderTextControl.cpp:
464         (WebCore::RenderTextControl::RenderTextControl):
465         (WebCore::RenderTextControl::subtreeHasChanged):
466         * rendering/RenderTextControl.h:
467         * rendering/RenderTextControlMultiLine.cpp:
468         (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
469         * rendering/RenderTextControlSingleLine.cpp:
470         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
471         * wml/WMLInputElement.cpp:
472         (WebCore::WMLInputElement::WMLInputElement):
473         (WebCore::WMLInputElement::defaultEventHandler):
474         * wml/WMLInputElement.h:
475         (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added.
476         (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.
477
478 2011-03-04  Xianzhu Wang  <wangxianzhu@google.com>
479
480         Reviewed by Adam Barth.
481
482         Remove fake request loading of SVGImage to avoid MainResourceLoader
483         leak. The frame->init() already ensures initialization of the
484         document loader.
485
486         https://bugs.webkit.org/show_bug.cgi?id=55017
487
488         Test: fast/images/svg-image-leak-loader.html
489
490         * svg/graphics/SVGImage.cpp:
491         (WebCore::SVGImage::dataChanged):
492
493 2011-03-04  Mike Reed  <reed@google.com>
494
495         Reviewed by Mihai Parparita.
496
497         [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
498         https://bugs.webkit.org/show_bug.cgi?id=49477
499
500         * platform/graphics/skia/PathSkia.cpp:
501         (WebCore::Path::addArc):
502
503 2011-03-04  Jia Pu  <jpu@apple.com>
504
505         Reviewed by Darin Adler.
506
507         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
508         https://bugs.webkit.org/show_bug.cgi?id=55717
509         <rdar://problem/9018127>
510
511         manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
512
513         Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
514         coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
515         to convert the bounding box to window coordinate using ScrollView::contentToWindow().
516
517         * dom/Range.cpp:
518         (WebCore::Range::getBoundingClientRect):
519         (WebCore::Range::boundingRect):
520         * dom/Range.h:
521         * editing/Editor.cpp:
522         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
523         (WebCore::Editor::correctionPanelTimerFired):
524         (WebCore::Editor::windowRectForRange):
525         * editing/Editor.h:
526         * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
527         * manual-tests/autocorrection/document-for-iframe-test.html: Added.
528
529 2011-03-04  Jia Pu  <jpu@apple.com>
530
531         Reviewed by Darin Adler.
532
533         Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
534         https://bugs.webkit.org/show_bug.cgi?id=55731
535
536         No new tests. There's no behavioral change.
537
538         This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
539
540         * editing/Editor.cpp:
541         (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
542
543 2011-03-04  John Bauman  <jbauman@chromium.org>
544
545         Reviewed by Kenneth Russell.
546
547         [chromium] premultipliedAlpha WebGL context attribute is ignored.
548         https://bugs.webkit.org/show_bug.cgi?id=55411
549
550         Update compositor to set the blending of each layer correctly.
551
552         Test: compositing/webgl/webgl-nonpremultiplied-blend.html
553
554         * platform/graphics/chromium/CanvasLayerChromium.cpp:
555         (WebCore::CanvasLayerChromium::CanvasLayerChromium):
556         (WebCore::CanvasLayerChromium::draw):
557         * platform/graphics/chromium/CanvasLayerChromium.h:
558         * platform/graphics/chromium/ContentLayerChromium.cpp:
559         (WebCore::ContentLayerChromium::draw):
560         * platform/graphics/chromium/LayerRendererChromium.cpp:
561         (WebCore::LayerRendererChromium::drawLayers):
562         * platform/graphics/chromium/WebGLLayerChromium.cpp:
563         (WebCore::WebGLLayerChromium::setContext):
564
565 2011-03-04  Adam Barth  <abarth@webkit.org>
566
567         Reviewed by Eric Seidel.
568
569         WebCore GYP build should link with the correct frameworks
570         https://bugs.webkit.org/show_bug.cgi?id=55804
571
572         * gyp/WebCore.gyp:
573
574 2011-03-04  Adam Barth  <abarth@webkit.org>
575
576         Reviewed by Eric Seidel.
577
578         WebCore GYP build should Check For Inappropriate Files in Framework
579         https://bugs.webkit.org/show_bug.cgi?id=55806
580
581         * gyp/WebCore.gyp:
582
583 2011-03-04  Dimitri Glazkov  <dglazkov@chromium.org>
584
585         Reviewed by Adam Barth.
586
587         Add skeletal WebCore.gyp
588         https://bugs.webkit.org/show_bug.cgi?id=55802
589
590         This doesn't yet build, but the basic structure is there.
591
592         * WebCore.gypi: Added headers and include directories variables.
593         * gyp/WebCore.gyp: Added.
594
595 2011-03-04  Adam Barth  <abarth@webkit.org>
596
597         Reviewed by Dimitri Glazkov.
598
599         Remove unneeded round-trips through ../Source in the Chromium GYP build
600         https://bugs.webkit.org/show_bug.cgi?id=55795
601
602         This is just cleanup work, but it was bugging me.
603
604         * WebCore.gyp/WebCore.gyp:
605
606 2011-03-04  Mike Reed  <reed@google.com>
607
608         Reviewed by James Robinson.
609
610         Option to use skia's native text drawing APIs when drawing text
611         on Windows, rather than from outlines using drawPath(). This will
612         only have a significant effect when the skia-gpu backend is enabled.
613         https://bugs.webkit.org/show_bug.cgi?id=55609
614
615         No new tests. This is disabled by default. When enabled, it will draw
616         essentially the same, but with slightly different antialiased edges, due
617         to differences between the current scanconverter and GDI's font scaler.
618         When enabled, we will have to recalibrate layouttest image results. 
619
620         * platform/graphics/skia/SkiaFontWin.cpp:
621         (WebCore::skiaDrawText):
622         (WebCore::setupPaintForFont):
623         (WebCore::paintSkiaText):
624
625 2011-03-04  Adrienne Walker  <enne@google.com>
626
627         Reviewed by James Robinson.
628
629         [chromium] Fix texture stride issues on large content and image layers.
630         https://bugs.webkit.org/show_bug.cgi?id=55679
631
632         This was an error caused during the refactoring in r80081.
633
634         Tests: LayoutTests/compositing/tiling/huge-layer-img.html
635
636         * platform/graphics/chromium/ContentLayerChromium.cpp:
637         (WebCore::ContentLayerChromium::updateTexture):
638         * platform/graphics/chromium/ImageLayerChromium.cpp:
639         (WebCore::ImageLayerChromium::updateTextureIfNeeded):
640
641 2011-03-04  Sheriff Bot  <webkit.review.bot@gmail.com>
642
643         Unreviewed, rolling out r80379.
644         http://trac.webkit.org/changeset/80379
645         https://bugs.webkit.org/show_bug.cgi?id=55799
646
647         "Breaks leopard compile (implicit conversion)" (Requested by
648         tonyg-cr on #webkit).
649
650         * css/CSSStyleSelector.cpp:
651         (WebCore::convertToLength):
652         (WebCore::CSSStyleSelector::applyProperty):
653         (WebCore::CSSStyleSelector::createTransformOperations):
654         * platform/Length.h:
655         (WebCore::Length::Length):
656         (WebCore::Length::operator==):
657         (WebCore::Length::operator!=):
658         (WebCore::Length::rawValue):
659         (WebCore::Length::type):
660         (WebCore::Length::quirk):
661         (WebCore::Length::setValue):
662         (WebCore::Length::setRawValue):
663         (WebCore::Length::calcFloatValue):
664         (WebCore::Length::isZero):
665         (WebCore::Length::blend):
666         * rendering/AutoTableLayout.cpp:
667         (WebCore::AutoTableLayout::recalcColumn):
668         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
669         * rendering/FixedTableLayout.cpp:
670         (WebCore::FixedTableLayout::calcWidthArray):
671
672 2011-03-04  Jessie Berlin  <jberlin@apple.com>
673
674         Reviewed by Darin Adler.
675
676         WebKit2: Use CFNetwork Sessions API.
677         https://bugs.webkit.org/show_bug.cgi?id=55435.
678
679         Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
680         contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
681
682         * platform/network/cf/ResourceHandleCFNet.cpp:
683         (WebCore::makeFinalRequest):
684         (WebCore::ResourceHandle::willSendRequest):
685         * platform/network/cf/ResourceRequestCFNet.cpp:
686         * platform/network/mac/ResourceHandleMac.mm:
687         (WebCore::ResourceHandle::createNSURLConnection):
688         (WebCore::ResourceHandle::willSendRequest):
689         * platform/network/mac/ResourceRequestMac.mm:
690
691 2011-03-04  Yuqiang Xian  <yuqiang.xian@intel.com>
692
693         Reviewed by Darin Adler.
694
695         improve layout performance by reducing the traversal time of the floating objects
696         https://bugs.webkit.org/show_bug.cgi?id=55440
697
698         We observered large overhead on traversing the floating objects list
699         in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
700         when the list becomes enormous, for example in the default 30x30 maze test
701         from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
702         there're >3700 floating objects. When placing a new floating object the
703         entire list (from begin to end) is traversed for multiple times.
704         There's a low hanging fruit to reduce the chances to do the traversal
705         which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
706         As the two routines either cares about FloatLeft objects or FloatRight objects only,
707         if we know there's no corresponding type floating objects in the list
708         we can avoid the traversal actually. One thing we could do is to record
709         the number of FloatLeft objects and the number of FloatRight objects and
710         add a check before doing the traversal. This can reduce the time by 45%
711         to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
712         Chromium browser 11 (from 503s to 269s).
713
714         No new tests, relying on existing layout tests.
715
716         * rendering/RenderBlock.cpp:
717         (WebCore::RenderBlock::~RenderBlock):
718         (WebCore::RenderBlock::addOverflowFromFloats):
719         (WebCore::RenderBlock::repaintOverhangingFloats):
720         (WebCore::RenderBlock::paintFloats):
721         (WebCore::RenderBlock::selectionGaps):
722         (WebCore::RenderBlock::insertFloatingObject):
723         (WebCore::RenderBlock::removeFloatingObject):
724         (WebCore::RenderBlock::removeFloatingObjectsBelow):
725         (WebCore::RenderBlock::positionNewFloats):
726         (WebCore::RenderBlock::positionNewFloatOnLine):
727         (WebCore::RenderBlock::logicalLeftOffsetForLine):
728         (WebCore::RenderBlock::logicalRightOffsetForLine):
729         (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
730         (WebCore::RenderBlock::lowestFloatLogicalBottom):
731         (WebCore::RenderBlock::clearFloats):
732         (WebCore::RenderBlock::addOverhangingFloats):
733         (WebCore::RenderBlock::addIntrudingFloats):
734         (WebCore::RenderBlock::containsFloat):
735         (WebCore::RenderBlock::hitTestFloats):
736         (WebCore::RenderBlock::adjustForBorderFit):
737         (WebCore::RenderBlock::FloatingObjects::clear):
738         (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
739         (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
740         * rendering/RenderBlock.h:
741         (WebCore::RenderBlock::containsFloats):
742         (WebCore::RenderBlock::FloatingObjects::FloatingObjects):
743         (WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
744         (WebCore::RenderBlock::FloatingObjects::hasRightObjects):
745         (WebCore::RenderBlock::FloatingObjects::set):
746         * rendering/RenderBlockLineLayout.cpp:
747         (WebCore::RenderBlock::layoutInlineChildren):
748         (WebCore::RenderBlock::matchedEndLine):
749
750 2011-03-04  Rik Cabanier  <cabanier@gmail.com>
751
752         Reviewed by David Hyatt.
753
754         Fix that allows fixed length values to be floating point
755         https://bugs.webkit.org/show_bug.cgi?id=52699
756
757         * WebCore.xcodeproj/project.pbxproj:
758         * css/CSSStyleSelector.cpp:
759         (WebCore::convertToLength):
760         (WebCore::convertToIntLength):
761         (WebCore::convertToFloatLength):
762         (WebCore::CSSStyleSelector::applyProperty):
763         (WebCore::CSSStyleSelector::createTransformOperations):
764         * platform/Length.h:
765         (WebCore::Length::Length):
766         (WebCore::Length::operator==):
767         (WebCore::Length::operator!=):
768         (WebCore::Length::rawValue):
769         (WebCore::Length::type):
770         (WebCore::Length::quirk):
771         (WebCore::Length::setValue):
772         (WebCore::Length::calcFloatValue):
773         (WebCore::Length::isZero):
774         (WebCore::Length::blend):
775         (WebCore::Length::getIntValue):
776         (WebCore::Length::getFloatValue):
777         * rendering/AutoTableLayout.cpp:
778         (WebCore::AutoTableLayout::recalcColumn):
779         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
780         * rendering/FixedTableLayout.cpp:
781         (WebCore::FixedTableLayout::calcWidthArray):
782
783 2011-03-04  Steve Falkenburg  <sfalken@apple.com>
784
785         Reviewed by Jon Honeycutt.
786
787         Adopt VersionStamper tool for Windows WebKit DLLs
788         https://bugs.webkit.org/show_bug.cgi?id=55784
789         
790         We now use a tool to stamp the version number onto the Apple WebKit DLLs
791         during the post-build step.
792
793         * WebCore.vcproj/QTMovieWin.rc: Removed.
794         * WebCore.vcproj/QTMovieWin.vcproj:
795         * WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
796         * WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
797         * WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
798
799 2011-03-04  Cosmin Truta  <ctruta@chromium.org>
800
801         Reviewed by Adam Barth.
802
803         Clarify comment about potential memory leak in SVGImage
804         https://bugs.webkit.org/show_bug.cgi?id=55362
805
806         No functionality change. No new tests.
807
808         * svg/graphics/SVGImage.cpp:
809         (WebCore::SVGImage::dataChanged):
810
811 2011-03-04  Jessie Berlin  <jberlin@apple.com>
812
813         Reviewed by Maciej Stachowiak.
814
815         WebKit2: Use CFNetwork Sessions API.
816         https://bugs.webkit.org/show_bug.cgi?id=55435.
817
818         When Private Browsing is enabled, get the cached url response from the cache associated with
819         the Private Browsing Storage Session.
820
821         * WebCore.exp.in:
822         Export the symbol for ResourceHandle::privateBrowsingStorageSession.
823
824 2011-03-04  Steve Block  <steveblock@google.com>
825
826         Reviewed by Jeremy Orlow.
827
828         JSC and V8 versions of Java bridge should share JobjectWrapper
829         https://bugs.webkit.org/show_bug.cgi?id=55763
830
831         No new tests, refactoring only.
832
833         * Android.jscbindings.mk:
834         * Android.v8bindings.mk:
835         * WebCore.gypi:
836         * WebCore.order:
837         * WebCore.xcodeproj/project.pbxproj:
838         * bridge/jni/JobjectWrapper.cpp:
839         (JobjectWrapper::JobjectWrapper):
840         (JobjectWrapper::~JobjectWrapper):
841         * bridge/jni/JobjectWrapper.h:
842         (JSC::Bindings::JobjectWrapper::instance):
843         (JSC::Bindings::JobjectWrapper::setInstance):
844         (JSC::Bindings::JobjectWrapper::ref):
845         (JSC::Bindings::JobjectWrapper::deref):
846         * bridge/jni/jsc/JNIBridgeJSC.cpp:
847         (JavaField::JavaField):
848         (JavaArray::JavaArray):
849         * bridge/jni/jsc/JNIBridgeJSC.h:
850         * bridge/jni/jsc/JavaInstanceJSC.cpp:
851         (JavaInstance::JavaInstance):
852         * bridge/jni/jsc/JavaInstanceJSC.h:
853
854 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
855
856         Reviewed by Nikolas Zimmermann.
857
858         Move shared code into SVGStyledTransformableElement::svgAttributeChanged
859         https://bugs.webkit.org/show_bug.cgi?id=55771
860
861         All sub classes of SVGStyledTransformableElement request a relayout
862         the same way. So move that code into the common base class.
863
864         * svg/SVGCircleElement.cpp:
865         (WebCore::SVGCircleElement::svgAttributeChanged):
866         * svg/SVGEllipseElement.cpp:
867         (WebCore::SVGEllipseElement::svgAttributeChanged):
868         * svg/SVGForeignObjectElement.cpp:
869         (WebCore::SVGForeignObjectElement::svgAttributeChanged):
870         * svg/SVGGElement.cpp:
871         (WebCore::SVGGElement::svgAttributeChanged):
872         * svg/SVGImageElement.cpp:
873         (WebCore::SVGImageElement::svgAttributeChanged):
874         * svg/SVGLineElement.cpp:
875         (WebCore::SVGLineElement::svgAttributeChanged):
876         * svg/SVGPathElement.cpp:
877         (WebCore::SVGPathElement::svgAttributeChanged):
878         * svg/SVGPolyElement.cpp:
879         (WebCore::SVGPolyElement::svgAttributeChanged):
880         * svg/SVGRectElement.cpp:
881         (WebCore::SVGRectElement::svgAttributeChanged):
882         * svg/SVGStyledTransformableElement.cpp:
883         (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
884         * svg/SVGStyledTransformableElement.h:
885         * svg/SVGUseElement.cpp:
886         (WebCore::SVGUseElement::svgAttributeChanged):
887
888 2011-03-03  John Abd-El-Malek  <jam@chromium.org>
889
890         Reviewed by Dimitri Glazkov.
891
892         [chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
893         https://bugs.webkit.org/show_bug.cgi?id=55748
894
895         * platform/network/chromium/ResourceResponse.cpp:
896         (WebCore::ResourceResponse::doPlatformCopyData):
897         (WebCore::ResourceResponse::doPlatformAdopt):
898         * platform/network/chromium/ResourceResponse.h:
899         (WebCore::ResourceResponse::ResourceResponse):
900
901 2011-03-03  Timothy Hatcher  <timothy@apple.com>
902
903         Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
904
905         Reviewed by Darin Adler.
906
907         * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
908
909 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
910
911         Reviewed by Yury Semikhatsky.
912
913         Web Inspector: extract all code that depends on source mapping from SourceFrame.
914         https://bugs.webkit.org/show_bug.cgi?id=55464
915
916         Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
917         to encapsulate source mapping aspects from SourceFrame.
918
919         * inspector/front-end/ResourceView.js:
920         (WebInspector.ResourceView.createResourceView):
921         (WebInspector.SourceFrameDelegateForResourcesPanel):
922         (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
923         * inspector/front-end/ScriptsPanel.js:
924         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
925         (WebInspector.SourceFrameDelegateForScriptsPanel):
926         * inspector/front-end/SourceFrame.js:
927         (WebInspector.SourceFrame):
928         (WebInspector.SourceFrame.prototype.show):
929         (WebInspector.SourceFrame.prototype._createTextViewer):
930         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
931         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
932         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
933         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
934         (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
935         (WebInspector.SourceFrame.prototype._contextMenu):
936         (WebInspector.SourceFrame.prototype._mouseDown):
937         (WebInspector.SourceFrame.prototype._mouseMove):
938         (WebInspector.SourceFrame.prototype._hidePopup):
939         (WebInspector.SourceFrame.prototype._mouseHover):
940         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
941         (WebInspector.SourceFrame.prototype._showPopup):
942         (WebInspector.SourceFrame.prototype._doubleClick):
943         (WebInspector.SourceFrame.prototype._didEditLine):
944         (WebInspector.SourceFrameDelegate):
945         (WebInspector.SourceFrameDelegate.prototype.requestContent):
946         (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
947         (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
948         (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
949         (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
950         (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
951         (WebInspector.SourceFrameDelegate.prototype.continueToLine):
952         (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
953         (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
954         (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
955         (WebInspector.SourceFrameDelegate.prototype.evaluate):
956         (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
957
958 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
959
960         Reviewed by Pavel Feldman.
961
962         Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
963         https://bugs.webkit.org/show_bug.cgi?id=55686
964
965         - Use internal ids for resources in extension server.
966         - Log errors in inspector tests.
967
968         * inspector/front-end/ExtensionServer.js:
969         (WebInspector.ExtensionServer):
970         (WebInspector.ExtensionServer.prototype.resetResources):
971         (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
972         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
973         (WebInspector.ExtensionServer.prototype._onGetHAR):
974         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
975         (WebInspector.ExtensionServer.prototype._resourceId):
976         (WebInspector.ExtensionServer.prototype._resourceById):
977         * inspector/front-end/HAREntry.js:
978         (WebInspector.HARLog):
979         (WebInspector.HARLog.prototype._convertResource):
980         * inspector/front-end/NetworkPanel.js:
981         (WebInspector.NetworkPanel.prototype._reset):
982
983 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
984
985         Reviewed by Pavel Feldman.
986
987         Web Inspector: exceptions when building context menu in network panel
988         https://bugs.webkit.org/show_bug.cgi?id=55678
989
990         * inspector/front-end/DataGrid.js:
991         (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
992         (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
993         * inspector/front-end/NetworkPanel.js:
994         (WebInspector.NetworkPanel.prototype._contextMenu):
995
996 2011-03-04  Ilya Sherman  <isherman@chromium.org>
997
998         Reviewed by James Robinson.
999
1000         Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
1001         This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
1002         is a FramelessScrollView -- which is mostly just for Autofill.
1003         In service of http://crbug.com/73772 (crash)
1004         https://bugs.webkit.org/show_bug.cgi?id=55557
1005
1006         No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
1007         In particular, DRT crashes when trying to render a FramelessScrollView.
1008
1009         * platform/ScrollbarTheme.h:
1010         (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner().
1011         (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
1012         * platform/chromium/FramelessScrollView.cpp:
1013         (WebCore::FramelessScrollView::paintContents):
1014         (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
1015         * platform/chromium/FramelessScrollView.h:
1016         * platform/chromium/ScrollbarThemeChromium.cpp:
1017         * platform/chromium/ScrollbarThemeChromium.h:
1018
1019 2011-03-04  Yury Semikhatsky  <yurys@chromium.org>
1020
1021         Reviewed by Pavel Feldman.
1022
1023         Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
1024         https://bugs.webkit.org/show_bug.cgi?id=55770
1025
1026         * inspector/InspectorAgent.cpp:
1027         (WebCore::InspectorAgent::InspectorAgent):
1028         (WebCore::InspectorAgent::didCommitLoad):
1029         * inspector/InspectorCSSAgent.cpp:
1030         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
1031         (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
1032         * inspector/InspectorCSSAgent.h:
1033         * inspector/InspectorDatabaseAgent.cpp:
1034         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
1035         * inspector/InspectorInstrumentation.cpp:
1036         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
1037         * inspector/InspectorInstrumentation.h:
1038         (WebCore::InspectorInstrumentation::didCommitLoad):
1039         * inspector/InspectorProfilerAgent.cpp:
1040         (WebCore::InspectorProfilerAgent::create):
1041         (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
1042         (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
1043         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
1044         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
1045         (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
1046         (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
1047         * inspector/InspectorProfilerAgent.h:
1048         * inspector/InstrumentingAgents.h:
1049         (WebCore::InstrumentingAgents::InstrumentingAgents):
1050         (WebCore::InstrumentingAgents::inspectorCSSAgent):
1051         (WebCore::InstrumentingAgents::setInspectorCSSAgent):
1052         (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
1053         (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
1054         (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
1055         (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
1056         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
1057         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
1058         (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
1059         (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
1060         (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
1061         (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
1062         (WebCore::InstrumentingAgents::inspectorProfilerAgent):
1063         (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
1064
1065 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
1066
1067         Reviewed by Yury Semikhatsky.
1068
1069         Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
1070         https://bugs.webkit.org/show_bug.cgi?id=55773
1071
1072         * inspector/CodeGeneratorInspector.pm:
1073         * inspector/InjectedScript.cpp:
1074         (WebCore::InjectedScript::releaseObjectGroup):
1075         * inspector/InjectedScript.h:
1076         * inspector/InjectedScriptHost.cpp:
1077         (WebCore::InjectedScriptHost::releaseObjectGroup):
1078         * inspector/InjectedScriptHost.h:
1079         * inspector/InjectedScriptSource.js:
1080         (.):
1081         * inspector/Inspector.idl:
1082         * inspector/InspectorConsoleAgent.cpp:
1083         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
1084         * inspector/InspectorRuntimeAgent.cpp:
1085         (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
1086         * inspector/InspectorRuntimeAgent.h:
1087         * inspector/front-end/ConsoleView.js:
1088         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
1089         (WebInspector.ConsoleView.prototype.completions):
1090         * inspector/front-end/PropertiesSidebarPane.js:
1091         * inspector/front-end/SourceFrame.js:
1092         (WebInspector.SourceFrame.prototype._hidePopup):
1093         * inspector/front-end/WatchExpressionsSidebarPane.js:
1094         (WebInspector.WatchExpressionsSection.prototype.update):
1095
1096 2011-03-02  Andrey Adaikin  <aandrey@google.com>
1097
1098         Reviewed by Pavel Feldman.
1099
1100         Web Inspector: Gutter height should be 100% when few lines are displayed
1101         https://bugs.webkit.org/show_bug.cgi?id=55574
1102
1103         * inspector/front-end/SourceFrame.js:
1104         (WebInspector.SourceFrame.prototype._startEditing):
1105         * inspector/front-end/TextViewer.js:
1106         (WebInspector.TextViewer.prototype._syncScroll):
1107         (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
1108         (WebInspector.TextEditorGutterPanel.prototype.textChanged):
1109         (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
1110         * inspector/front-end/textViewer.css:
1111         (.text-editor-lines):
1112         (.text-editor-contents .inner-container):
1113         (.webkit-line-number):
1114
1115 2011-03-04  Andrey Adaikin  <aandrey@google.com>
1116
1117         Reviewed by Pavel Feldman.
1118
1119         Web Inspector: [Text editor] Do bisect to find visible chunks
1120         https://bugs.webkit.org/show_bug.cgi?id=55685
1121
1122         * inspector/front-end/TextViewer.js:
1123         (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
1124         (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
1125         (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
1126         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
1127         (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
1128         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
1129
1130 2011-03-04  Andrey Adaikin  <aandrey@google.com>
1131
1132         Reviewed by Pavel Feldman.
1133
1134         Web Inspector: [Text editor] DOMNodeRemoved events are missing
1135         https://bugs.webkit.org/show_bug.cgi?id=55769
1136
1137         * inspector/front-end/TextViewer.js:
1138         (WebInspector.TextEditorMainPanel):
1139         (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
1140         (WebInspector.TextEditorMainChunk):
1141         (WebInspector.TextEditorMainChunk.prototype._createRow):
1142
1143 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
1144
1145         Reviewed by Yury Semikhatsky.
1146
1147         Web Inspector: Remove unnecessary domain and success flags from the response messages.
1148         https://bugs.webkit.org/show_bug.cgi?id=55768
1149
1150         We have domain property in the response messages but it is not used because we dispatch
1151         the responses on the callback associated with seq.
1152
1153         If we have property 'errors' in the response then success eq false and true in the other case.
1154
1155         * inspector/CodeGeneratorInspector.pm:
1156
1157 2011-03-04  Christian Dywan  <christian@lanedo.com>
1158
1159         Reviewed by Gustavo Noronha Silva.
1160
1161         Enable Copy Image Address context menu item in the Gtk port
1162         https://bugs.webkit.org/show_bug.cgi?id=55136
1163
1164         * page/ContextMenuController.cpp:
1165         * platform/ContextMenuItem.h:
1166         * platform/LocalizationStrategy.h:
1167         * platform/LocalizedStrings.cpp:
1168         * platform/LocalizedStrings.h:
1169         * platform/gtk/ContextMenuItemGtk.cpp:
1170         * platform/gtk/LocalizedStringsGtk.cpp:
1171
1172 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
1173
1174         Reviewed by Yury Semikhatsky.
1175
1176         Web Inspector: implement getCompletions via evaluate.
1177         https://bugs.webkit.org/show_bug.cgi?id=55759
1178
1179         * inspector/InjectedScript.cpp:
1180         * inspector/InjectedScript.h:
1181         * inspector/InjectedScriptSource.js:
1182         * inspector/Inspector.idl:
1183         * inspector/InspectorDebuggerAgent.cpp:
1184         * inspector/InspectorDebuggerAgent.h:
1185         * inspector/InspectorRuntimeAgent.cpp:
1186         * inspector/InspectorRuntimeAgent.h:
1187         * inspector/front-end/ConsoleView.js:
1188         (WebInspector.ConsoleView.prototype.completions.evaluated):
1189         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
1190         (WebInspector.ConsoleView.prototype.completions):
1191         (WebInspector.ConsoleView.prototype._reportCompletions):
1192         * inspector/front-end/ScriptsPanel.js:
1193         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
1194         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
1195         * inspector/front-end/SourceFrame.js:
1196         (WebInspector.SourceFrame.prototype._showPopup):
1197         (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
1198
1199 2011-03-04  Steve Block  <steveblock@google.com>
1200
1201         Reviewed by Jeremy Orlow.
1202
1203         V8 version of JavaString should obtain string from JNI in UTF-16 encoding
1204         https://bugs.webkit.org/show_bug.cgi?id=55566
1205
1206         We obtain the string from JNI in UTF-16 encoding and convert
1207         to UTF-8 using our own routines as required. This matches the
1208         behaviour of the JSC version of JavaString.
1209
1210         No new tests, no change in behaviour.
1211
1212         * bridge/jni/v8/JavaStringV8.h:
1213         (JSC::Bindings::JavaStringImpl::init):
1214         (JSC::Bindings::JavaStringImpl::utf8):
1215         (JSC::Bindings::JavaStringImpl::impl):
1216
1217 2011-03-03  Pavel Feldman  <pfeldman@chromium.org>
1218
1219         Reviewed by Yury Semikhatsky.
1220
1221         Web Inspector: do not push document into front-end, make it request one.
1222         https://bugs.webkit.org/show_bug.cgi?id=55664
1223
1224         * inspector/Inspector.idl:
1225         * inspector/InspectorAgent.cpp:
1226         (WebCore::InspectorAgent::InspectorAgent):
1227         * inspector/InspectorAgent.h:
1228         * inspector/InspectorBrowserDebuggerAgent.cpp:
1229         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
1230         * inspector/InspectorDOMAgent.cpp:
1231         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
1232         (WebCore::InspectorDOMAgent::clearFrontend):
1233         (WebCore::InspectorDOMAgent::setDocument):
1234         (WebCore::InspectorDOMAgent::getDocument):
1235         (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
1236         (WebCore::InspectorDOMAgent::boundNodeId):
1237         (WebCore::InspectorDOMAgent::resolveNode):
1238         (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
1239         * inspector/InspectorDOMAgent.h:
1240         (WebCore::InspectorDOMAgent::create):
1241         * inspector/front-end/BreakpointManager.js:
1242         (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
1243         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
1244         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
1245         * inspector/front-end/DOMAgent.js:
1246         (WebInspector.DOMDocument):
1247         (WebInspector.DOMAgent):
1248         (WebInspector.DOMAgent.prototype.requestDocument):
1249         (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
1250         (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
1251         (WebInspector.DOMAgent.prototype._attributesUpdated):
1252         (WebInspector.DOMAgent.prototype._characterDataModified):
1253         (WebInspector.DOMAgent.prototype._documentUpdated):
1254         (WebInspector.DOMAgent.prototype._setDocument):
1255         (WebInspector.DOMAgent.prototype._setDetachedRoot):
1256         (WebInspector.DOMAgent.prototype._setChildNodes):
1257         (WebInspector.DOMAgent.prototype._childNodeInserted):
1258         (WebInspector.DOMAgent.prototype._childNodeRemoved):
1259         (WebInspector.DOMDispatcher.prototype.documentUpdated):
1260         * inspector/front-end/ElementsPanel.js:
1261         (WebInspector.ElementsPanel.prototype.show):
1262         (WebInspector.ElementsPanel.prototype.setDocument):
1263         * inspector/front-end/MetricsSidebarPane.js:
1264         * inspector/front-end/RemoteObject.js:
1265         (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
1266
1267 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
1268
1269         Reviewed by Pavel Feldman.
1270
1271         Web Inspector: summary bar may overlap content of the network item view
1272         https://bugs.webkit.org/show_bug.cgi?id=55656
1273
1274         - drop custom summary bar placement logic, do it with CSS instead.
1275
1276         * inspector/front-end/NetworkPanel.js:
1277         (WebInspector.NetworkPanel.prototype.resize):
1278         (WebInspector.NetworkPanel.prototype._createSummaryBar):
1279         (WebInspector.NetworkPanel.prototype._updateSummaryBar):
1280         (WebInspector.NetworkPanel.prototype._updateFilter):
1281         (WebInspector.NetworkPanel.prototype.show):
1282         (WebInspector.NetworkPanel.prototype.refresh):
1283         (WebInspector.NetworkPanel.prototype._reset):
1284         (WebInspector.NetworkPanel.prototype._setLargerResources):
1285         (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
1286         * inspector/front-end/networkPanel.css:
1287         (.network-sidebar .data-grid td):
1288         (.network-sidebar tr.filler td):
1289         (.network-summary-bar):
1290         (.network-sidebar .data-grid .network-summary-bar td):
1291         (.network-summary-bar img):
1292
1293 2011-03-04  James Su <suzhe@chromium.org>
1294
1295         Reviewed by Dimitri Glazkov.
1296
1297         [Chromium] keycode is always 0 when using non-Latin keyboard layout.
1298         https://bugs.webkit.org/show_bug.cgi?id=54939
1299
1300         Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
1301
1302         No intended functionality change.
1303
1304         * WebCore.gyp/WebCore.gyp:
1305         * WebCore.gypi:
1306
1307 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
1308
1309         Unreviewed EFL build fix for r80324.
1310
1311         * platform/efl/RenderThemeEfl.cpp:
1312         (WebCore::RenderThemeEfl::paintThemePart):
1313
1314 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
1315
1316         Unreviewed EFL build fix for r80324.
1317
1318         * platform/efl/RenderThemeEfl.cpp:
1319         (WebCore::RenderThemeEfl::paintThemePart):
1320
1321 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
1322
1323         Reviewed by Pavel Feldman.
1324
1325         Web Inspector: AppCache agent should have same lifetime as InspectorAgent
1326         https://bugs.webkit.org/show_bug.cgi?id=55673
1327
1328         * inspector/InspectorAgent.cpp:
1329         (WebCore::InspectorAgent::InspectorAgent):
1330         (WebCore::InspectorAgent::setFrontend):
1331         (WebCore::InspectorAgent::disconnectFrontend):
1332         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
1333         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
1334         (WebCore::InspectorAgent::didCommitLoad):
1335         * inspector/InspectorApplicationCacheAgent.cpp:
1336         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
1337         (WebCore::InspectorApplicationCacheAgent::setFrontend):
1338         (WebCore::InspectorApplicationCacheAgent::clearFrontend):
1339         * inspector/InspectorApplicationCacheAgent.h:
1340         * inspector/InspectorInstrumentation.cpp:
1341         (WebCore::InspectorInstrumentation::networkStateChangedImpl):
1342         (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
1343         * inspector/InstrumentingAgents.h:
1344         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
1345         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
1346
1347 2011-03-03  Brian Weinstein  <bweinstein@apple.com>
1348
1349         Reviewed by Adam Roben.
1350
1351         Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
1352         
1353         Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
1354         on all platforms, and stub the functions on platforms that don't implement them.
1355         
1356         Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
1357         for platforms that don't implement them.
1358
1359         * platform/android/TemporaryLinkStubs.cpp:
1360         * platform/brew/TemporaryLinkStubs.cpp:
1361         * platform/chromium/TemporaryLinkStubs.cpp:
1362         * platform/efl/TemporaryLinkStubs.cpp:
1363         * platform/gtk/TemporaryLinkStubs.cpp:
1364         * platform/haiku/TemporaryLinkStubs.cpp:
1365         * platform/qt/TemporaryLinkStubsQt.cpp:
1366         * platform/win/TemporaryLinkStubs.cpp:
1367
1368 2011-03-03  Eric Seidel  <eric@webkit.org>
1369
1370         Reviewed by Dimitri Glazkov.
1371
1372         Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
1373         https://bugs.webkit.org/show_bug.cgi?id=55720
1374
1375         There are two thing going on here:
1376         1. Delaying nextRenderer calculation until we actually use it,
1377            previously we would always compute nextRenderer (expensive!)
1378            even if no renderer insertion was to occur.
1379         2. Fix fullscreen elements to be inserted into the right place
1380            in the rendering tree.  Previously they would always be the last
1381            child in their parent's list, even if that wasn't the right place.
1382
1383         I don't know of any way to trigger the fullscreen bug,
1384         but I tested this with peacekeeper and saw no performance change.
1385
1386         Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
1387         but I don't really trust the stability of peacekeeper to begin with.
1388
1389         This paves the way for further improvement in our nextRenderer calculation.
1390
1391         * dom/Node.cpp:
1392         (WebCore::Node::attach):
1393         (WebCore::Node::previousRenderer):
1394         (WebCore::Node::nextRenderer):
1395         (WebCore::Node::createRendererAndStyle):
1396         (WebCore::wrapWithRenderFullScreen):
1397         (WebCore::Node::createRendererIfNeeded):
1398         * dom/Node.h:
1399
1400 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1401
1402         Reviewed by Darin Adler.
1403
1404         Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
1405         https://bugs.webkit.org/show_bug.cgi?id=55554
1406
1407         * platform/Length.cpp:
1408         (WebCore::newLengthArray): Pass nullptr instead of 0.
1409
1410 2011-03-03  Nat Duca  <nduca@chromium.org>
1411
1412         Reviewed by James Robinson.
1413
1414         [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
1415         LayerRendererChromium that draws compositor FPS and, optionally,
1416         the layer tree.
1417         https://bugs.webkit.org/show_bug.cgi?id=54710
1418
1419         * WebCore.gypi:
1420         * platform/graphics/chromium/Canvas2DLayerChromium.h:
1421         (WebCore::Canvas2DLayerChromium::drawsContent):
1422         * platform/graphics/chromium/CanvasLayerChromium.h:
1423         (WebCore::CanvasLayerChromium::layerTypeAsString):
1424         * platform/graphics/chromium/ContentLayerChromium.cpp:
1425         (WebCore::writeIndent):
1426         (WebCore::ContentLayerChromium::dumpLayerProperties):
1427         * platform/graphics/chromium/ContentLayerChromium.h:
1428         (WebCore::ContentLayerChromium::drawsContent):
1429         (WebCore::ContentLayerChromium::layerTypeAsString):
1430         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1431         (WebCore::GraphicsLayerChromium::setName):
1432         (WebCore::GraphicsLayerChromium::updateNames):
1433         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1434         (WebCore::GraphicsLayerChromium::setupContentsLayer):
1435         * platform/graphics/chromium/GraphicsLayerChromium.h:
1436         * platform/graphics/chromium/ImageLayerChromium.h:
1437         (WebCore::ImageLayerChromium::drawsContent):
1438         (WebCore::ImageLayerChromium::layerTypeAsString):
1439         * platform/graphics/chromium/LayerChromium.cpp:
1440         (WebCore::LayerChromium::LayerChromium):
1441         (WebCore::LayerChromium::setName):
1442         (WebCore::LayerChromium::layerTreeAsText):
1443         (WebCore::writeIndent):
1444         (WebCore::LayerChromium::dumpLayer):
1445         (WebCore::LayerChromium::dumpLayerProperties):
1446         * platform/graphics/chromium/LayerChromium.h:
1447         (WebCore::LayerChromium::name):
1448         (WebCore::LayerChromium::drawsContent):
1449         (WebCore::LayerChromium::debugID):
1450         (WebCore::LayerChromium::layerTypeAsString):
1451         * platform/graphics/chromium/LayerRendererChromium.cpp:
1452         (WebCore::LayerRendererChromium::LayerRendererChromium):
1453         (WebCore::LayerRendererChromium::~LayerRendererChromium):
1454         (WebCore::LayerRendererChromium::drawLayers):
1455         (WebCore::LayerRendererChromium::present):
1456         (WebCore::LayerRendererChromium::layerTreeAsText):
1457         (WebCore::LayerRendererChromium::dumpRenderSurfaces):
1458         * platform/graphics/chromium/LayerRendererChromium.h:
1459         (WebCore::LayerRendererChromium::getHeadsUpDisplay):
1460         (WebCore::LayerRendererChromium::rootVisibleRect):
1461         * platform/graphics/chromium/PluginLayerChromium.h:
1462         (WebCore::PluginLayerChromium::drawsContent):
1463         (WebCore::PluginLayerChromium::layerTypeAsString):
1464         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
1465         (WebCore::RenderSurfaceChromium::name):
1466         (WebCore::writeIndent):
1467         (WebCore::RenderSurfaceChromium::dumpSurface):
1468         * platform/graphics/chromium/RenderSurfaceChromium.h:
1469         * platform/graphics/chromium/VideoLayerChromium.h:
1470         (WebCore::VideoLayerChromium::drawsContent):
1471         (WebCore::VideoLayerChromium::layerTypeAsString):
1472         * platform/graphics/chromium/WebGLLayerChromium.h:
1473         (WebCore::WebGLLayerChromium::drawsContent):
1474         (WebCore::WebGLLayerChromium::layerTypeAsString):
1475         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
1476         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
1477         (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
1478         (WebCore::CCHeadsUpDisplay::draw):
1479         (WebCore::CCHeadsUpDisplay::drawHudContents):
1480         (WebCore::CCHeadsUpDisplay::onPresent):
1481         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
1482         (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
1483         (WebCore::CCHeadsUpDisplay::showFPSCounter):
1484         (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
1485         (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
1486         (WebCore::CCHeadsUpDisplay::enabled):
1487         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
1488         (WebCore::CCLayerImpl::CCLayerImpl):
1489         (WebCore::writeIndent):
1490         (WebCore::CCLayerImpl::dumpLayerProperties):
1491         * platform/graphics/chromium/cc/CCLayerImpl.h:
1492         (WebCore::CCLayerImpl::debugID):
1493         (WebCore::CCLayerImpl::setName):
1494         (WebCore::CCLayerImpl::name):
1495
1496 2011-03-02  Ojan Vafai  <ojan@chromium.org>
1497
1498         Reviewed by Darin Adler.
1499
1500         crash in adoptNode with mutation events
1501         https://bugs.webkit.org/show_bug.cgi?id=50046
1502
1503         If the DOM is modified during the removeChild call in adoptNode,
1504         then the setDocument call that follows can leave the DOM in an
1505         inconsistent state.
1506
1507         * dom/Document.cpp:
1508         (WebCore::Document::adoptNode):
1509
1510 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1511
1512         Reviewed by Darin Adler.
1513
1514         Add audio tag tests to the media controls manual test suite.
1515         https://bugs.webkit.org/show_bug.cgi?id=55722
1516
1517         * manual-tests/media-controls.html: Added 4 audio tests.
1518
1519 2011-03-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1520
1521         Reviewed by Eric Seidel.
1522
1523         [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
1524         https://bugs.webkit.org/show_bug.cgi?id=54392
1525
1526         Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
1527         WebCore's functions should adhere WebKit coding style.
1528
1529         * platform/efl/RenderThemeEfl.cpp:
1530         (WebCore::RenderThemeEfl::themePartCacheEntryReset):
1531         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
1532         (WebCore::RenderThemeEfl::cacheThemePartNew):
1533         (WebCore::RenderThemeEfl::cacheThemePartReset):
1534         (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
1535         (WebCore::RenderThemeEfl::cacheThemePartGet):
1536         (WebCore::RenderThemeEfl::cacheThemePartFlush):
1537         (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
1538         (WebCore::RenderThemeEfl::paintThemePart):
1539         (WebCore::renderThemeEflColorClassSelectionActive):
1540         (WebCore::renderThemeEflColorClassSelectionInactive):
1541         (WebCore::renderThemeEflColorClassFocusRing):
1542         (WebCore::renderThemeEflColorClassButtonText):
1543         (WebCore::renderThemeEflColorClassComboText):
1544         (WebCore::renderThemeEflColorClassEntryText):
1545         (WebCore::renderThemeEflColorClassSearchText):
1546         (WebCore::RenderThemeEfl::applyPartDescription):
1547         (WebCore::RenderThemeEfl::applyPartDescriptions):
1548         (WebCore::RenderThemeEfl::controlSupportsTints):
1549         (WebCore::RenderThemeEfl::baselinePosition):
1550         (WebCore::RenderThemeEfl::paintSliderTrack):
1551         (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
1552         (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
1553         (WebCore::RenderThemeEfl::paintSliderThumb):
1554         (WebCore::RenderThemeEfl::adjustCheckboxStyle):
1555         (WebCore::RenderThemeEfl::paintCheckbox):
1556         (WebCore::RenderThemeEfl::adjustRadioStyle):
1557         (WebCore::RenderThemeEfl::paintRadio):
1558         (WebCore::RenderThemeEfl::adjustButtonStyle):
1559         (WebCore::RenderThemeEfl::paintButton):
1560         (WebCore::RenderThemeEfl::adjustMenuListStyle):
1561         (WebCore::RenderThemeEfl::paintMenuList):
1562         (WebCore::RenderThemeEfl::adjustTextFieldStyle):
1563         (WebCore::RenderThemeEfl::paintTextField):
1564         (WebCore::RenderThemeEfl::adjustTextAreaStyle):
1565         (WebCore::RenderThemeEfl::paintTextArea):
1566         (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
1567         (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
1568         (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
1569         (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
1570         (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
1571         (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
1572         (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
1573         (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
1574         (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
1575         (WebCore::RenderThemeEfl::paintSearchField):
1576         (WebCore::RenderThemeEfl::adjustProgressBarStyle):
1577         (WebCore::RenderThemeEfl::paintProgressBar):
1578         (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
1579         (WebCore::RenderThemeEfl::paintMediaMuteButton):
1580         (WebCore::RenderThemeEfl::paintMediaPlayButton):
1581         (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
1582         (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
1583         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
1584         (WebCore::RenderThemeEfl::paintMediaSliderThumb):
1585         (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
1586         (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
1587         (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
1588         (WebCore::RenderThemeEfl::paintMediaCurrentTime):
1589
1590 2011-03-03  Andy Estes  <aestes@apple.com>
1591
1592         Reviewed by Adam Barth.
1593
1594         Assertion failure in toElement(WebCore::Node*)
1595         https://bugs.webkit.org/show_bug.cgi?id=55697
1596
1597         Test: fast/parser/fragment-foreign-content.html
1598
1599         * html/parser/HTMLTreeBuilder.cpp:
1600         (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
1601         element in the HTMLElementStack might be a DocumentFragment if a
1602         fragment is being parsed who's first node is foreign content.
1603
1604 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1605
1606         Reviewed by Kenneth Rohde Christiansen.
1607
1608         [QT] Implement mock client-based geolocation for layout testing
1609         https://bugs.webkit.org/show_bug.cgi?id=54334
1610
1611         Implements client() to GeolocationController to re-use geolocationClientMock class
1612         for layout testing purpose.
1613
1614         * page/GeolocationController.h:
1615         (WebCore::GeolocationController::client):
1616
1617 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1618
1619         Reviewed by Kent Tamura.
1620
1621         Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
1622         https://bugs.webkit.org/show_bug.cgi?id=55352
1623
1624         Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:
1625
1626         * editing/CompositeEditCommand.cpp:
1627         (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and
1628         no longer calls deprecated functions.
1629         * editing/InsertTextCommand.cpp:
1630         (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion.
1631         Check if the text node inside a tab span before checking if the container node is a text node
1632         because the position before or after a text node can still be inside a tab span.
1633         (WebCore::InsertTextCommand::input): No longer calls deprecated functions.
1634         * editing/InsertTextCommand.h:
1635         * editing/ModifySelectionListLevel.cpp:
1636         (WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start
1637         or the end of selection could be an immediate child of a list node (e.g. br inside ul)
1638
1639 2011-03-03  Hans Wennborg  <hans@chromium.org>
1640
1641         Reviewed by Jeremy Orlow.
1642
1643         IndexedDB: Move last bits of SQL into IDBBackingStore
1644         https://bugs.webkit.org/show_bug.cgi?id=55668
1645
1646         After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
1647
1648         No new tests: refactoring only.
1649
1650         * storage/IDBBackingStore.cpp:
1651         (WebCore::IDBBackingStore::createTransaction):
1652         * storage/IDBBackingStore.h:
1653         * storage/IDBCursorBackendImpl.h:
1654         * storage/IDBDatabaseBackendImpl.cpp:
1655         (WebCore::IDBDatabaseBackendImpl::backingStore):
1656         * storage/IDBDatabaseBackendImpl.h:
1657         * storage/IDBIndexBackendImpl.h:
1658         * storage/IDBKey.h:
1659         * storage/IDBObjectStoreBackendImpl.h:
1660         * storage/IDBTransactionBackendImpl.cpp:
1661         (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
1662         * storage/IDBTransactionBackendImpl.h:
1663         * storage/IDBTransactionBackendInterface.h:
1664         * storage/IDBTransactionCoordinator.cpp:
1665
1666 2011-03-03  Adam Klein  <adamk@chromium.org>
1667
1668         Reviewed by David Levin.
1669
1670         [fileapi] Tighten up ResolveURICallbacks
1671         https://bugs.webkit.org/show_bug.cgi?id=55638
1672
1673         Two changes:
1674           - Retry only on TYPE_MISMATCH_ERR now that Chromium
1675             properly sets that error code.
1676           - Call DirectoryEntry instead of DOMFileSystem methods.
1677
1678         No change in behavior, so no new tests.
1679
1680         * fileapi/FileSystemCallbacks.cpp:
1681         (WebCore::ResolveURICallbacks::didOpenFileSystem):
1682
1683 2011-03-03  Anders Carlsson  <andersca@apple.com>
1684
1685         Reviewed by Sam Weinig.
1686
1687         Get rid of Page::globalHistoryItem
1688         https://bugs.webkit.org/show_bug.cgi?id=55738
1689
1690         The m_globalHistoryItem is only used by Mac and Windows WebKit1.
1691         Instead of having WebCore updating this member variable, just call out
1692         to a FrameLoaderClient member function and let WebKit keep it up to date.
1693
1694         * loader/EmptyClients.h:
1695         (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
1696         (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
1697         * loader/FrameLoader.cpp:
1698         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1699         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
1700         * loader/FrameLoaderClient.h:
1701         (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
1702         * loader/HistoryController.cpp:
1703         (WebCore::HistoryController::goToItem):
1704         (WebCore::HistoryController::updateForStandardLoad):
1705         (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
1706         * page/Page.cpp:
1707         * page/Page.h:
1708
1709 2011-03-02  Jeremy Orlow  <jorlow@chromium.org>
1710
1711         Reviewed by Steve Block.
1712
1713         Cursor.continue with a key param should test less than, not equal to
1714         https://bugs.webkit.org/show_bug.cgi?id=55640
1715
1716         If you supply a param to cursor.continue, we sould guarantee that
1717         the item we continue to is greater than or equal to the parameter.
1718         Right now, we only test equality.
1719
1720         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
1721         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor
1722
1723         Test: storage/indexeddb/cursor-continue.html
1724
1725         * storage/IDBCursorBackendImpl.cpp:
1726         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
1727         * storage/IDBKey.cpp:
1728         (WebCore::IDBKey::isLessThan):
1729         (WebCore::IDBKey::isEqual):
1730         * storage/IDBKey.h:
1731
1732 2011-03-03  Brent Fulgham  <bfulgham@webkit.org>
1733
1734         Build fix. Need win/cURL DownloadBundle stub.
1735
1736         * platform/network/curl/DownloadBundle.h: Added.
1737
1738 2011-03-03  Geoffrey Garen  <ggaren@apple.com>
1739
1740         Rolled out 80277 and 80280 because they caused event handler layout test
1741         failures.
1742
1743         * WebCore.xcodeproj/project.pbxproj:
1744         * bindings/js/JSDOMGlobalObject.cpp:
1745         * bindings/js/JSDOMGlobalObject.h:
1746         * bindings/js/JSDOMWindowBase.cpp:
1747         * bindings/js/JSDOMWindowBase.h:
1748         * bindings/js/JSDOMWindowCustom.h:
1749         * bindings/js/JSWorkerContextBase.cpp:
1750
1751 2011-03-03  Brady Eidson  <beidson@apple.com>
1752
1753         Reviewed by Darin Adler.
1754
1755         https://bugs.webkit.org/show_bug.cgi?id=55721
1756         Global IconDatabase should be returned by reference, not as a pointer
1757
1758         * history/HistoryItem.cpp:
1759         (WebCore::HistoryItem::HistoryItem):
1760         (WebCore::HistoryItem::~HistoryItem):
1761         (WebCore::HistoryItem::reset):
1762         (WebCore::HistoryItem::icon):
1763         (WebCore::HistoryItem::setURLString):
1764
1765         * loader/FrameLoader.cpp:
1766         (WebCore::FrameLoader::startIconLoader):
1767         (WebCore::FrameLoader::commitIconURLToIconDatabase):
1768
1769         * loader/archive/cf/LegacyWebArchive.cpp:
1770         (WebCore::LegacyWebArchive::create):
1771
1772         * loader/icon/IconDatabase.cpp:
1773         (WebCore::iconDatabase):
1774         * loader/icon/IconDatabase.h:
1775         * loader/icon/IconDatabaseNone.cpp:
1776         (WebCore::iconDatabase):
1777         * loader/icon/wince/IconDatabaseWinCE.cpp:
1778         (WebCore::iconDatabase):
1779
1780         * loader/icon/IconLoader.cpp:
1781         (WebCore::IconLoader::finishLoading):
1782
1783 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1784
1785         Reviewed by Martin Robinson.
1786
1787         Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
1788         https://bugs.webkit.org/show_bug.cgi?id=52742
1789
1790         Use firstPositionInOrBeforeNode to instantiate appropriate position.
1791
1792         * page/FocusController.cpp:
1793         (WebCore::FocusController::advanceFocusInDocumentOrder):
1794
1795 2011-03-03  Andy Estes  <aestes@apple.com>
1796
1797         Reviewed by Darin Adler.
1798
1799         When displaying the missing plug-in sheet, pass the 'pluginspage'
1800         attribute to the UI process.
1801         https://bugs.webkit.org/show_bug.cgi?id=55553
1802
1803         * WebCore.exp.in: Export __ZN7WebCore9HTMLNames15pluginspageAttrE.
1804         * html/HTMLAttributeNames.in: Add 'pluginspage' as a known content
1805         attribute.
1806
1807 2011-03-03  Jessie Berlin  <jberlin@apple.com>
1808
1809         Reviewed by Adam Roben.
1810
1811         WebKit2: Use CFNetwork Sessions API.
1812         https://bugs.webkit.org/show_bug.cgi?id=55435
1813
1814         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
1815
1816         * WebCore.exp.in:
1817         Support using WKCopyRequestWithStorageSession in WebCore.
1818         * platform/mac/WebCoreSystemInterface.h:
1819         Ditto.
1820         * platform/mac/WebCoreSystemInterface.mm:
1821         Ditto.
1822
1823         * platform/network/cf/ResourceHandleCFNet.cpp:
1824         (WebCore::makeFinalRequest):
1825         If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
1826         (WebCore::ResourceHandle::willSendRequest):
1827         Ditto.
1828         * platform/network/mac/ResourceHandleMac.mm:
1829         (WebCore::ResourceHandle::createNSURLConnection):
1830         Ditto.
1831         (WebCore::ResourceHandle::willSendRequest):
1832         Ditto.
1833
1834         * platform/network/cf/ResourceRequest.h:
1835         * platform/network/cf/ResourceRequestCFNet.cpp:
1836         (WebCore::ResourceRequest::setStorageSession):
1837         Call through to WKSI.
1838         * platform/network/mac/ResourceRequestMac.mm:
1839         (WebCore::ResourceRequest::setStorageSession):
1840         Ditto.
1841
1842 2011-03-03  Chris Marrin  <cmarrin@apple.com>
1843
1844         Reviewed by Simon Fraser.
1845
1846         REGRESSION: Accelerated transitions are jumpy
1847         https://bugs.webkit.org/show_bug.cgi?id=55022
1848
1849         Changed the way default TimingFunction is stored according to Adam Roben's
1850         suggestion.
1851
1852         * platform/animation/TimingFunction.h:
1853         (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
1854
1855 2011-03-03  Dan Bernstein  <mitz@apple.com>
1856
1857         Reviewed by Sam Weinig.
1858
1859         Rename -webkit-hyphenate-locale to -webkit-locale
1860         https://bugs.webkit.org/show_bug.cgi?id=55709
1861
1862         * css/CSSComputedStyleDeclaration.cpp:
1863         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1864         * css/CSSParser.cpp:
1865         (WebCore::CSSParser::parseValue):
1866         (WebCore::cssPropertyID):
1867         * css/CSSPropertyNames.in:
1868         * css/CSSStyleSelector.cpp:
1869         (WebCore::CSSStyleSelector::applyProperty):
1870         * rendering/RenderBlockLineLayout.cpp:
1871         (WebCore::RenderBlock::findNextLineBreak):
1872         * rendering/style/RenderStyle.cpp:
1873         (WebCore::RenderStyle::diff):
1874         * rendering/style/RenderStyle.h:
1875         (WebCore::InheritedFlags::locale):
1876         (WebCore::InheritedFlags::setLocale):
1877         (WebCore::InheritedFlags::initialLocale):
1878         * rendering/style/StyleRareInheritedData.cpp:
1879         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1880         (WebCore::StyleRareInheritedData::operator==):
1881         * rendering/style/StyleRareInheritedData.h:
1882
1883 2011-03-03  Kevin Ollivier  <kevino@theolliviers.com>
1884
1885         [wx] Build fixes. Use Font::textMetrics to get ascent value, and add missing include.
1886
1887         * platform/wx/DragDataWx.cpp:
1888         * platform/wx/wxcode/win/non-kerned-drawing.cpp:
1889         (WebCore::drawTextWithSpacing):
1890
1891 2011-03-03  Oliver Hunt  <oliver@apple.com>
1892
1893         Reviewed by Geoffrey Garen.
1894
1895         JSVariableObject needs to use WriteBarrier for symboltable property storage
1896         https://bugs.webkit.org/show_bug.cgi?id=55698
1897
1898         Update to pass JSGlobalData for the symbol table write used
1899         to set the document property.
1900
1901         * bindings/js/JSDOMWindowBase.cpp:
1902         (WebCore::JSDOMWindowBase::updateDocument):
1903
1904 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
1905
1906         More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.
1907
1908         * WebCore.xcodeproj/project.pbxproj:
1909         * page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
1910         * page/mac/WebCoreKeyboardUIMode.h: Removed.
1911
1912 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
1913
1914         Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
1915
1916         * page/ChromeClient.h:
1917
1918 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
1919
1920         Reviewed by Darin Adler.
1921
1922         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
1923         https://bugs.webkit.org/show_bug.cgi?id=55633
1924         <rdar://problem/8963023>
1925
1926         * loader/EmptyClients.h: (WebCore::EmptyChromeClient::keyboardUIMode):
1927         * page/ChromeClient.h:
1928         * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks):
1929         Merged tabsToLinks() and keyboardUIMode(). The latter returned a superset of information
1930         returned by former.
1931
1932 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1933
1934         Fix Win compile break, caused by r80276.
1935
1936         * rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton
1937             to match RenderTheme.h.
1938
1939 2011-03-02  Geoffrey Garen  <ggaren@apple.com>
1940
1941         Reviewed by Darin Adler.
1942
1943         Moved all variable object storage inline -- upping the object size limit to 1K
1944         https://bugs.webkit.org/show_bug.cgi?id=55653
1945
1946         * bindings/js/JSDOMGlobalObject.cpp:
1947         * bindings/js/JSDOMGlobalObject.h:
1948         * bindings/js/JSDOMWindowBase.cpp:
1949         * bindings/js/JSDOMWindowBase.h:
1950         * bindings/js/JSDOMWindowCustom.h:
1951         * bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
1952
1953 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1954
1955         Reviewed by Darin Adler.
1956
1957         Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
1958         https://bugs.webkit.org/show_bug.cgi?id=55099
1959
1960         Cleanup, no behavior change.
1961
1962         * html/shadow/MediaControls.cpp:
1963         (WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox
1964             instead of Node.
1965         * rendering/RenderMediaControls.cpp:
1966         (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed
1967             to use RenderBox as argument.
1968         * rendering/RenderMediaControls.h: Ditto.
1969         * rendering/RenderTheme.cpp:
1970         (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
1971         * rendering/RenderTheme.h: Ditto.
1972         * rendering/RenderThemeChromiumMac.h: Ditto.
1973         * rendering/RenderThemeChromiumMac.mm:
1974         (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
1975         * rendering/RenderThemeMac.h: Ditto.
1976         * rendering/RenderThemeMac.mm:
1977         (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
1978         * rendering/RenderThemeWin.cpp:
1979         (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
1980
1981 2011-03-03  Alexis Menard  <alexis.menard@openbossa.org>
1982
1983         Reviewed by Andreas Kling.
1984
1985         When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
1986         Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
1987         for GstElement.
1988
1989         * WebCore.pro:
1990         * features.pri:
1991
1992 2011-03-03  Anders Carlsson  <andersca@apple.com>
1993
1994         Try to fix the Windows build again.
1995
1996         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1997         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1998
1999 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
2000
2001         Reviewed by Dimitri Glazkov.
2002
2003         Add another CRASH() for CSSSelector double frees
2004         https://bugs.webkit.org/show_bug.cgi?id=55693
2005
2006         To help track down bug 53045, add a CRASH call when the the array and/or
2007         CSSSelector member in CSSSelectorList is disposed of more than once.
2008
2009         Just a check, no new tests necessary.
2010         
2011         * css/CSSSelectorList.cpp:
2012         (WebCore::CSSSelectorList::deleteSelectors):
2013
2014 2011-03-03  Anders Carlsson  <andersca@apple.com>
2015
2016         Yet another attempt at fixing the Windows build.
2017
2018         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
2019         * platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
2020         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
2021         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
2022
2023 2011-03-02  Chris Marrin  <cmarrin@apple.com>
2024
2025         Reviewed by Simon Fraser.
2026
2027         REGRESSION: Accelerated transitions are jumpy
2028         https://bugs.webkit.org/show_bug.cgi?id=55022
2029
2030         Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
2031         is now always passed in. The TimingFunction class now has a static method to get
2032         a default object which has the 'ease' values in it. I now assert in both Mac and
2033         Win implementations if a null TimingFunction pointer is seen.
2034
2035         * platform/animation/TimingFunction.h:
2036         (WebCore::CubicBezierTimingFunction::create):
2037         (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
2038         (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
2039         * platform/graphics/ca/GraphicsLayerCA.cpp:
2040         (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
2041         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
2042         (toCAMediaTimingFunction):
2043         * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
2044         (toCACFTimingFunction):
2045
2046 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
2047
2048         Unreviewed build fix.
2049
2050         Fix clang compile after r80220
2051         https://bugs.webkit.org/show_bug.cgi?id=55692
2052
2053         * storage/IDBBackingStore.cpp:
2054         (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
2055
2056 2011-03-03  Anders Carlsson  <andersca@apple.com>
2057
2058         Attempt to fix the Windows build.
2059
2060         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
2061         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
2062
2063 2011-03-02  Brian Weinstein  <bweinstein@apple.com>
2064
2065         Reviewed by Adam Roben.
2066
2067         Rest of WebKit2: Need a way to send notifications to client when cookies change
2068         https://bugs.webkit.org/show_bug.cgi?id=55427
2069         <rdar://problem/9056027>
2070
2071         Add functions to be exported.
2072
2073         * WebCore.exp.in:
2074
2075 2011-03-03  Anders Carlsson  <andersca@apple.com>
2076
2077         Reviewed by Darin Adler.
2078
2079         Improve WebCore build time by ~5%
2080         https://bugs.webkit.org/show_bug.cgi?id=55688
2081
2082         Forward declare the CATransform3D and CGAffineTransform structs instead of including
2083         large chunks of QuartzCore and Core Graphics.
2084
2085         On an 8 core Mac Pro, this sped up building WebCore by about 5%.
2086
2087         * platform/graphics/ca/GraphicsLayerCA.cpp:
2088         * platform/graphics/ca/TransformationMatrixCA.cpp:
2089         * platform/graphics/transforms/TransformationMatrix.h:
2090
2091 2011-03-03  Andrey Kosyakov  <caseq@chromium.org>
2092
2093         Unreviewed. Adjusted call to a method renamed in r80102.
2094
2095         * inspector/front-end/SourceFrame.js:
2096         (WebInspector.SourceFrame.prototype._startEditing):
2097
2098 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2099
2100         Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
2101         by contexts not created by WebCore.
2102
2103         https://webkit.org/b/55642
2104
2105         Reviewed by Oliver Hunt.
2106
2107         * bindings/js/SerializedScriptValue.cpp:
2108         (WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
2109         (WebCore::SerializedScriptValue::deserialize): Ditto.
2110
2111 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
2112
2113         Reviewed by Darin Adler.
2114
2115         WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
2116         https://bugs.webkit.org/show_bug.cgi?id=55498
2117         <rdar://problem/8752706>
2118
2119         Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
2120                http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
2121
2122         * websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response
2123         header fields. Removed separate member variables for those, as they were duplicating data
2124         available in response, and there is no reason to squeeze microsecods here.
2125
2126         * websockets/WebSocketHandshake.cpp:
2127         (WebCore::WebSocketHandshake::reset): There are no longer member variables for header field
2128         values to reset here.
2129         (WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders().
2130         (WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
2131         (WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
2132         (WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
2133         (WebCore::WebSocketHandshake::serverSetCookie): Ditto.
2134         (WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
2135         (WebCore::WebSocketHandshake::serverUpgrade): Added.
2136         (WebCore::WebSocketHandshake::serverConnection): Added.
2137         (WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection
2138         header field presence and values.
2139
2140 2011-03-03  Helder Correia  <helder@sencha.com>
2141
2142         Reviewed by Andreas Kling.
2143
2144         [Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
2145         https://bugs.webkit.org/show_bug.cgi?id=55651
2146
2147         When relying on ContextShadow and using a gradient stroke for a path,
2148         the alpha of the shadow is incorrect.
2149
2150         * platform/graphics/qt/GraphicsContextQt.cpp:
2151         (WebCore::GraphicsContext::strokePath):
2152
2153 2011-03-03  Martin Robinson  <mrobinson@igalia.com>
2154
2155         XHTMLMP build broken after r78342
2156         https://bugs.webkit.org/show_bug.cgi?id=55286
2157
2158         Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
2159         instead of FrameLoader.
2160
2161         No new tests. This is a build fix.
2162
2163         * dom/Document.cpp:
2164         (WebCore::Document::isXHTMLMPDocument):
2165
2166 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
2167
2168         Reviewed by Eric Carlson.
2169
2170         Tweak MediaControlMuteButtonElement class hierarchy.
2171         https://bugs.webkit.org/show_bug.cgi?id=55614
2172
2173         This allows the mute button on the panel to have event handlers that are
2174         different from the mute button in the volume slider.
2175
2176         No change in behavior, covered by existing tests.
2177
2178         * html/shadow/MediaControls.cpp:
2179         (WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
2180         * rendering/MediaControlElements.cpp:
2181         (WebCore::MediaControlMuteButtonElement::updateDisplayType):
2182         (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added.
2183         (WebCore::MediaControlPanelMuteButtonElement::create): Added.
2184         (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
2185         * rendering/MediaControlElements.h: Added defs.
2186
2187 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
2188
2189         Reviewed by Pavel Feldman.
2190
2191         Web Inspector: Resource agent should have same lifetime as Inspector agent
2192         https://bugs.webkit.org/show_bug.cgi?id=55461
2193
2194         * inspector/Inspector.idl:
2195         * inspector/InspectorAgent.cpp:
2196         (WebCore::InspectorAgent::InspectorAgent):
2197         (WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed
2198         to clear frontend reference in all agents.
2199         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2200         (WebCore::InspectorAgent::setFrontend):
2201         (WebCore::InspectorAgent::disconnectFrontend):
2202         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
2203         (WebCore::InspectorAgent::didCommitLoad):
2204         * inspector/InspectorAgent.h:
2205         (WebCore::InspectorAgent::resourceAgent):
2206         * inspector/InspectorBrowserDebuggerAgent.cpp:
2207         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
2208         * inspector/InspectorDebuggerAgent.cpp:
2209         (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
2210         * inspector/InspectorInstrumentation.cpp:
2211         (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
2212         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
2213         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
2214         (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
2215         (WebCore::InspectorInstrumentation::retrieveResourceAgent):
2216         * inspector/InspectorResourceAgent.cpp:
2217         (WebCore::InspectorResourceAgent::setFrontend):
2218         (WebCore::InspectorResourceAgent::clearFrontend):
2219         (WebCore::InspectorResourceAgent::restore):
2220         (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
2221         (WebCore::InspectorResourceAgent::enable):
2222         (WebCore::InspectorResourceAgent::disable):
2223         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
2224         * inspector/InspectorResourceAgent.h:
2225         (WebCore::InspectorResourceAgent::create):
2226         * inspector/InspectorTimelineAgent.cpp:
2227         (WebCore::InspectorTimelineAgent::restore):
2228         * inspector/InspectorTimelineAgent.h:
2229         * inspector/front-end/NetworkManager.js:
2230         (WebInspector.NetworkManager):
2231         (WebInspector.NetworkManager.prototype.frontendReused):
2232         * inspector/front-end/inspector.js:
2233         (WebInspector.frontendReused):
2234
2235 2011-03-03  Andras Becsi  <abecsi@webkit.org>
2236
2237         Reviewed by Andreas Kling.
2238
2239         CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
2240         https://bugs.webkit.org/show_bug.cgi?id=55661
2241
2242         Test case originally written by Andreas Kling <andreas.kling@nokia.com>
2243
2244         Test: fast/canvas/rgba-parsing.html
2245
2246         * css/CSSParser.cpp:
2247         (WebCore::isValidDouble): Check whether the given string is a valid double.
2248         (WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
2249
2250 2011-03-03  David Holloway  <dhollowa@chromium.org>
2251
2252         Reviewed by Dimitri Glazkov.
2253
2254         Changes HTMLTextFormControlElement::placeholderShouldBeVisible to account
2255         for non-empty suggestion text.  The visibility of the placeholder text
2256         now turned off when suggestion text is set.
2257         https://bugs.webkit.org/show_bug.cgi?id=55245
2258
2259         No new tests because, by design, the suggestion text is not accessible
2260         through the DOM.
2261
2262         * html/HTMLFormControlElement.cpp:
2263         (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
2264         * html/HTMLFormControlElement.h:
2265         (WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
2266         * html/HTMLInputElement.h:
2267         (WebCore::HTMLInputElement::isEmptySuggestedValue):
2268
2269 2011-03-03  Andy Estes  <aestes@apple.com>
2270
2271         Reviewed by Eric Seidel.
2272
2273         HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
2274         https://bugs.webkit.org/show_bug.cgi?id=48719
2275         
2276         Instead of pushing a fake HTMLHtmlElement onto the open element stack
2277         during fragment parsing only to later remove it and reparent its
2278         children to the DocumentFragment, push the DocumentFragment directly
2279         onto the open element stack as the root node. This requires refactoring
2280         HTMLElementStack to hold ContainerNode pointers rather than Element
2281         pointers, which has implications for HTMLConstructionSite and
2282         HTMLTreeBuilder as well.
2283         
2284         With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
2285         is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
2286         test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
2287         regression no longer lies in fragment parsing.
2288
2289         No new tests. No change in behavior.
2290
2291         * dom/Element.h:
2292         (WebCore::Node::hasLocalName):
2293         * dom/Node.h:
2294         * html/parser/HTMLConstructionSite.cpp:
2295         (WebCore::HTMLNames::hasImpliedEndTag):
2296         (WebCore::HTMLConstructionSite::HTMLConstructionSite):
2297         (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
2298         (WebCore::HTMLConstructionSite::insertComment):
2299         (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
2300         (WebCore::HTMLConstructionSite::attachToCurrent):
2301         (WebCore::HTMLConstructionSite::insertScriptElement):
2302         (WebCore::HTMLConstructionSite::insertTextNode):
2303         (WebCore::HTMLConstructionSite::createElement):
2304         (WebCore::HTMLConstructionSite::createHTMLElement):
2305         (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
2306         (WebCore::HTMLConstructionSite::generateImpliedEndTags):
2307         (WebCore::HTMLConstructionSite::findFosterSite):
2308         (WebCore::HTMLConstructionSite::shouldFosterParent):
2309         * html/parser/HTMLConstructionSite.h:
2310         (WebCore::HTMLConstructionSite::currentNode):
2311         * html/parser/HTMLElementStack.cpp:
2312         (WebCore::HTMLNames::isNumberedHeaderElement):
2313         (WebCore::HTMLNames::isScopeMarker):
2314         (WebCore::HTMLNames::isListItemScopeMarker):
2315         (WebCore::HTMLNames::isTableScopeMarker):
2316         (WebCore::HTMLNames::isTableBodyScopeMarker):
2317         (WebCore::HTMLNames::isTableRowScopeMarker):
2318         (WebCore::HTMLNames::isButtonScopeMarker):
2319         (WebCore::HTMLNames::isSelectScopeMarker):
2320         (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
2321         (WebCore::HTMLElementStack::ElementRecord::replaceElement):
2322         (WebCore::HTMLElementStack::HTMLElementStack):
2323         (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
2324         (WebCore::HTMLElementStack::popAll):
2325         (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
2326         (WebCore::HTMLElementStack::popUntil):
2327         (WebCore::HTMLElementStack::popUntilPopped):
2328         (WebCore::HTMLElementStack::popUntilTableScopeMarker):
2329         (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
2330         (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
2331         (WebCore::HTMLElementStack::pushHTMLHtmlElement):
2332         (WebCore::HTMLElementStack::push):
2333         (WebCore::HTMLElementStack::insertAbove):
2334         (WebCore::HTMLElementStack::find):
2335         (WebCore::HTMLElementStack::topmost):
2336         (WebCore::HTMLElementStack::contains):
2337         (WebCore::inScopeCommon):
2338         (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
2339         (WebCore::HTMLElementStack::htmlElement):
2340         (WebCore::HTMLElementStack::rootNode):
2341         (WebCore::HTMLElementStack::pushCommon):
2342         * html/parser/HTMLElementStack.h:
2343         (WebCore::HTMLElementStack::ElementRecord::element):
2344         (WebCore::HTMLElementStack::ElementRecord::node):
2345         (WebCore::HTMLElementStack::topNode):
2346         * html/parser/HTMLTreeBuilder.cpp:
2347         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
2348         (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
2349         (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2350         (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
2351         (WebCore::HTMLTreeBuilder::processStartTag):
2352         (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
2353         (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2354         (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
2355         (WebCore::HTMLTreeBuilder::processEndTagForInCell):
2356         (WebCore::HTMLTreeBuilder::processEndTagForInBody):
2357         (WebCore::HTMLTreeBuilder::processEndTag):
2358         (WebCore::HTMLTreeBuilder::processEndOfFile):
2359         (WebCore::HTMLTreeBuilder::finished):
2360         * html/parser/HTMLTreeBuilder.h:
2361
2362 2011-03-02  Yury Semikhatsky  <yurys@chromium.org>
2363
2364         Reviewed by Pavel Feldman.
2365
2366         Web Inspector: inspector protocol should allow different domains to have methods with same name
2367         https://bugs.webkit.org/show_bug.cgi?id=55558
2368
2369         * inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
2370
2371 2011-03-02  Pavel Podivilov  <podivilov@chromium.org>
2372
2373         Reviewed by Yury Semikhatsky.
2374
2375         Web Inspector: make selected call frame debugger presentation model property.
2376         https://bugs.webkit.org/show_bug.cgi?id=55582
2377
2378         * inspector/front-end/CallStackSidebarPane.js:
2379         (WebInspector.CallStackSidebarPane):
2380         (WebInspector.CallStackSidebarPane.prototype.update):
2381         (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
2382         (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
2383         * inspector/front-end/ConsoleView.js:
2384         (WebInspector.ConsoleView.prototype.completions):
2385         * inspector/front-end/DebuggerPresentationModel.js:
2386         (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
2387         (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
2388         * inspector/front-end/ScriptsPanel.js:
2389         (WebInspector.ScriptsPanel):
2390         (WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame):
2391         (WebInspector.ScriptsPanel.prototype._debuggerResumed):
2392         (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
2393         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
2394
2395 2011-03-03  Jia Pu  <jpu@apple.com>
2396
2397         Reviewed by Darin Adler.
2398
2399         On Mac OS X, spelling suggestion panel stops showing up after change set 80121
2400         https://bugs.webkit.org/show_bug.cgi?id=55628
2401
2402         Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.
2403
2404         * editing/Editor.cpp:
2405         (WebCore::Editor::appliedEditing):
2406         * manual-tests/autocorrection/autocorrection-contraction.html:
2407
2408 2011-03-03  Pavel Podivilov  <podivilov@chromium.org>
2409
2410         Reviewed by Pavel Feldman.
2411
2412         Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
2413         https://bugs.webkit.org/show_bug.cgi?id=55569
2414
2415         sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.
2416
2417         * inspector/front-end/DebuggerPresentationModel.js:
2418         * inspector/front-end/ScriptsPanel.js:
2419
2420 2011-03-03  Steve Block  <steveblock@google.com>
2421
2422         Reviewed by David Levin.
2423
2424         JavaString API should be implementable by both JSC and V8
2425         https://bugs.webkit.org/show_bug.cgi?id=55567
2426
2427         Remove JavaString's UString operator and replace it with a
2428         script-engine-independent impl() method, which returns a
2429         StringImpl and can be implemented with both JSC and V8.
2430
2431         No new tests, refactoring only. 
2432
2433         * bridge/jni/JNIBridge.h:
2434         (JSC::Bindings::JavaString::impl):
2435         * bridge/jni/jni_jsobject.mm:
2436         (JavaJSObject::call):
2437         (JavaJSObject::eval):
2438         (JavaJSObject::getMember):
2439         (JavaJSObject::setMember):
2440         (JavaJSObject::removeMember):
2441         * bridge/jni/jsc/JNIBridgeJSC.cpp:
2442         (JavaField::valueFromInstance):
2443         (JavaField::setValueToInstance):
2444         * bridge/jni/jsc/JavaClassJSC.cpp:
2445         (JavaClass::JavaClass):
2446         * bridge/jni/jsc/JavaInstanceJSC.cpp:
2447         (JavaInstance::invokeMethod):
2448         * bridge/jni/jsc/JavaStringJSC.h:
2449         (JSC::Bindings::JavaStringImpl::impl):
2450         * bridge/jni/v8/JavaStringV8.h:
2451         (JSC::Bindings::JavaStringImpl::impl):
2452
2453 2011-03-03  Benjamin Poulain  <ikipou@gmail.com>
2454
2455         Reviewed by Adam Roben.
2456
2457         REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
2458         https://bugs.webkit.org/show_bug.cgi?id=55602
2459
2460         Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.
2461
2462         The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
2463         objects need to be deleted manually with ListHashSet.
2464
2465         * rendering/RenderBlock.cpp:
2466         (WebCore::RenderBlock::clearFloats):
2467
2468 2011-03-03  Hans Wennborg  <hans@chromium.org>
2469
2470         Reviewed by Jeremy Orlow.
2471
2472         IndexedDB: Move SQL code, especially for cursors, to IDBBackingStore
2473         https://bugs.webkit.org/show_bug.cgi?id=55376
2474
2475         Move SQL code from IDBKey, IDBKeyRange, IDBIndexBackendImpl,
2476         IDBObjectStoreBackendImpl, and especially IDBCursorBackendImpl.
2477
2478         No new functionality, so no new tests.
2479
2480         * storage/IDBBackingStore.cpp:
2481         (WebCore::lowerCursorWhereFragment):
2482         (WebCore::upperCursorWhereFragment):
2483         (WebCore::IDBBackingStore::deleteObjectStoreRecord):
2484         (WebCore::IDBBackingStore::keyExistsInObjectStore):
2485         (WebCore::IDBBackingStore::getObjectViaIndex):
2486         (WebCore::keyFromQuery):
2487         (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
2488         (WebCore::IDBBackingStore::keyExistsInIndex):
2489         (WebCore::CursorImplCommon::CursorImplCommon::continueInternal):
2490         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
2491         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::objectStoreDataId):
2492         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::key):
2493         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::value):
2494         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::continueFunction):
2495         (WebCore::IDBBackingStore::openObjectStoreCursor):
2496         (WebCore::ObjectStoreCursorImpl::loadCurrentRow):
2497         (WebCore::ObjectStoreCursorImpl::currentRowExists):
2498         (WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
2499         (WebCore::IndexKeyCursorImpl::indexDataId):
2500         (WebCore::IndexKeyCursorImpl::key):
2501         (WebCore::IndexKeyCursorImpl::primaryKey):
2502         (WebCore::IndexKeyCursorImpl::continueFunction):
2503         (WebCore::IDBBackingStore::openIndexKeyCursor):
2504         (WebCore::IndexKeyCursorImpl::loadCurrentRow):
2505         (WebCore::IndexKeyCursorImpl::currentRowExists):
2506         (WebCore::IndexCursorImpl::IndexCursorImpl):
2507         (WebCore::IndexCursorImpl::indexDataId):
2508         (WebCore::IndexCursorImpl::key):
2509         (WebCore::IndexCursorImpl::primaryKey):
2510         (WebCore::IndexCursorImpl::value):
2511         (WebCore::IndexCursorImpl::continueFunction):
2512         (WebCore::IDBBackingStore::openIndexCursor):
2513         (WebCore::IndexCursorImpl::loadCurrentRow):
2514         (WebCore::IndexCursorImpl::currentRowExists):
2515         * storage/IDBBackingStore.h:
2516         (WebCore::IDBBackingStore::Cursor::~Cursor):
2517         * storage/IDBCursorBackendImpl.cpp:
2518         (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
2519         (WebCore::IDBCursorBackendImpl::key):
2520         (WebCore::IDBCursorBackendImpl::value):
2521         (WebCore::IDBCursorBackendImpl::update):
2522         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
2523         (WebCore::IDBCursorBackendImpl::deleteFunction):
2524         * storage/IDBCursorBackendImpl.h:
2525         (WebCore::IDBCursorBackendImpl::create):
2526         * storage/IDBIndexBackendImpl.cpp:
2527         (WebCore::IDBIndexBackendImpl::openCursorInternal):
2528         (WebCore::IDBIndexBackendImpl::getInternal):
2529         (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
2530         * storage/IDBIndexBackendImpl.h:
2531         * storage/IDBKey.cpp:
2532         (WebCore::IDBKey::isEqual):
2533         * storage/IDBKey.h:
2534         * storage/IDBKeyRange.cpp:
2535         * storage/IDBKeyRange.h:
2536         * storage/IDBObjectStoreBackendImpl.cpp:
2537         (WebCore::IDBObjectStoreBackendImpl::putInternal):
2538         (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
2539         (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
2540         * storage/IDBObjectStoreBackendImpl.h:
2541
2542 2011-03-03  Peter Kasting  <pkasting@google.com>
2543
2544         Reviewed by James Robinson.
2545
2546         Drop redundant "Windows; " from the Windows-specific User Agent string.
2547         https://bugs.webkit.org/show_bug.cgi?id=54567
2548
2549         * StringsNotToBeLocalized.txt:
2550
2551 2011-03-03  Mario Sanchez Prada  <msanchez@igalia.com>
2552
2553         Reviewed by Martin Robinson.
2554
2555         [GTK] Combo boxes should emit object:selection-changed even when collapsed
2556         https://bugs.webkit.org/show_bug.cgi?id=53146
2557
2558         Emit the selection-changed signals when the menu list value has changed
2559
2560         Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
2561
2562         * accessibility/gtk/AXObjectCacheAtk.cpp:
2563         (WebCore::getListObject): New, return the right list object for
2564         menu lists and list boxes.
2565         (WebCore::notifyChildrenSelectionChange): Support menu lists.
2566         (WebCore::AXObjectCache::postPlatformNotification): Call function
2567         notifyChildrenSelectionChange for AXMenuListValueChanged.
2568
2569 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2570
2571         Reviewed by Tony Chang.
2572
2573         applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
2574         https://bugs.webkit.org/show_bug.cgi?id=55338
2575
2576         Include wtf/Forward.h instead of wtf/text/String.h
2577
2578         * editing/EditingStyle.h:
2579
2580 2011-03-03  Csaba Osztrogon√°c  <ossy@webkit.org>
2581
2582         Unreviewed trivial fix after r80169.
2583
2584         [Qt][WK2] Memory exhausted when building qtwebkit2 on linux
2585         https://bugs.webkit.org/show_bug.cgi?id=55484
2586
2587         * WebCore.pro: Typo fix. We have to use linux-g++* instead of linux-g++.
2588
2589
2590 2011-03-02  MORITA Hajime  <morrita@google.com>
2591
2592         Reviewed by Kent Tamura.
2593
2594         [Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleAction
2595         https://bugs.webkit.org/show_bug.cgi?id=54440
2596
2597         - Extracted FrameActionScheduler from FrameView
2598         - Extracted FrameAction abstract class from ScheduledEvent,
2599           which has fire() virtual method.
2600         - Renamed ScheduledEvent EventFrameAction
2601         
2602         With this change, Any action can be hooked up to the end of the layout.
2603         
2604         No new tests. No behavioral change.
2605
2606         * Android.mk:
2607         * CMakeLists.txt:
2608         * GNUmakefile.am:
2609         * WebCore.gypi:
2610         * WebCore.pro:
2611         * WebCore.vcproj/WebCore.vcproj:
2612         * WebCore.xcodeproj/project.pbxproj:
2613         * page/FrameActionScheduler.cpp: Added.
2614         (WebCore::EventFrameAction::EventFrameAction):
2615         (WebCore::EventFrameAction::fire):
2616         (WebCore::FrameActionScheduler::FrameActionScheduler):
2617         (WebCore::FrameActionScheduler::~FrameActionScheduler):
2618         (WebCore::FrameActionScheduler::isEmpty):
2619         (WebCore::FrameActionScheduler::clear):
2620         (WebCore::FrameActionScheduler::pause):
2621         (WebCore::FrameActionScheduler::resume):
2622         (WebCore::FrameActionScheduler::dispatch):
2623         (WebCore::FrameActionScheduler::scheduleAction):
2624         (WebCore::FrameActionScheduler::scheduleEvent):
2625         * page/FrameActionScheduler.h: Added.
2626         (WebCore::FrameAction::FrameAction):
2627         (WebCore::FrameAction::~FrameAction):
2628         (WebCore::FrameActionScheduler::isScheduled):
2629         * page/FrameView.cpp:
2630         (WebCore::FrameView::FrameView):
2631         (WebCore::FrameView::~FrameView):
2632         (WebCore::FrameView::layout):
2633         (WebCore::FrameView::scheduleEvent):
2634         (WebCore::FrameView::pauseScheduledEvents):
2635         (WebCore::FrameView::resumeScheduledEvents):
2636         (WebCore::FrameView::performPostLayoutTasks):
2637         (WebCore::FrameView::updateOverflowStatus):
2638         * page/FrameView.h:
2639
2640 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2641
2642         Unreviewed, rolling out r80201.
2643         http://trac.webkit.org/changeset/80201
2644         https://bugs.webkit.org/show_bug.cgi?id=55648
2645
2646         "caused tests to crash on several bots" (Requested by rniwa on
2647         #webkit).
2648
2649         * dom/Element.h:
2650         (WebCore::Node::hasTagName):
2651         * dom/Node.h:
2652         * html/parser/HTMLConstructionSite.cpp:
2653         (WebCore::HTMLNames::hasImpliedEndTag):
2654         (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
2655         (WebCore::HTMLConstructionSite::insertComment):
2656         (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
2657         (WebCore::HTMLConstructionSite::attachToCurrent):
2658         (WebCore::HTMLConstructionSite::insertScriptElement):
2659         (WebCore::HTMLConstructionSite::insertTextNode):
2660         (WebCore::HTMLConstructionSite::createElement):
2661         (WebCore::HTMLConstructionSite::createHTMLElement):
2662         (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
2663         (WebCore::HTMLConstructionSite::generateImpliedEndTags):
2664         (WebCore::HTMLConstructionSite::findFosterSite):
2665         (WebCore::HTMLConstructionSite::shouldFosterParent):
2666         * html/parser/HTMLConstructionSite.h:
2667         * html/parser/HTMLElementStack.cpp:
2668         (WebCore::HTMLNames::isNumberedHeaderElement):
2669         (WebCore::HTMLNames::isScopeMarker):
2670         (WebCore::HTMLNames::isListItemScopeMarker):
2671         (WebCore::HTMLNames::isTableScopeMarker):
2672         (WebCore::HTMLNames::isTableBodyScopeMarker):
2673         (WebCore::HTMLNames::isTableRowScopeMarker):
2674         (WebCore::HTMLNames::isButtonScopeMarker):
2675         (WebCore::HTMLNames::isSelectScopeMarker):
2676         (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
2677         (WebCore::HTMLElementStack::ElementRecord::replaceElement):
2678         (WebCore::HTMLElementStack::HTMLElementStack):
2679         (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
2680         (WebCore::HTMLElementStack::popAll):
2681         (WebCore::HTMLElementStack::popUntilTableScopeMarker):
2682         (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
2683         (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
2684         (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
2685         (WebCore::HTMLElementStack::pushHTMLHtmlElement):
2686         (WebCore::HTMLElementStack::push):
2687         (WebCore::HTMLElementStack::insertAbove):
2688         (WebCore::HTMLElementStack::find):
2689         (WebCore::HTMLElementStack::topmost):
2690         (WebCore::inScopeCommon):
2691         (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
2692         (WebCore::HTMLElementStack::htmlElement):
2693         (WebCore::HTMLElementStack::bodyElement):
2694         (WebCore::HTMLElementStack::pushCommon):
2695         * html/parser/HTMLElementStack.h:
2696         (WebCore::HTMLElementStack::ElementRecord::element):
2697         (WebCore::HTMLElementStack::top):
2698         * html/parser/HTMLTreeBuilder.cpp:
2699         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
2700         (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
2701         (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
2702         (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2703         (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
2704         (WebCore::HTMLTreeBuilder::processStartTag):
2705         (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
2706         (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2707         (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
2708         (WebCore::HTMLTreeBuilder::processEndTagForInCell):
2709         (WebCore::HTMLTreeBuilder::processEndTagForInBody):
2710         (WebCore::HTMLTreeBuilder::processEndTag):
2711         (WebCore::HTMLTreeBuilder::processEndOfFile):
2712         (WebCore::HTMLTreeBuilder::finished):
2713         * html/parser/HTMLTreeBuilder.h:
2714
2715 2011-03-02  Yury Semikhatsky  <yurys@chromium.org>
2716
2717         Reviewed by Pavel Feldman.
2718
2719         Web Inspector: break down InspectorFrontend into domain-specific classes
2720         https://bugs.webkit.org/show_bug.cgi?id=55584
2721
2722         * inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains nested classes for
2723         all domains that have event notifications.
2724         * inspector/ConsoleMessage.cpp:
2725         (WebCore::ConsoleMessage::addToFrontend):
2726         (WebCore::ConsoleMessage::updateRepeatCountInConsole):
2727         * inspector/ConsoleMessage.h:
2728         * inspector/InjectedScriptHost.cpp:
2729         (WebCore::InjectedScriptHost::inspectImpl):
2730         * inspector/Inspector.idl:
2731         * inspector/InspectorAgent.cpp:
2732         (WebCore::InspectorAgent::inspectedPageDestroyed):
2733         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2734         (WebCore::InspectorAgent::setFrontend):
2735         (WebCore::InspectorAgent::disconnectFrontend):
2736         (WebCore::InspectorAgent::populateScriptObjects):
2737         (WebCore::InspectorAgent::pushDataCollectedOffline):
2738         (WebCore::InspectorAgent::didCommitLoad):
2739         (WebCore::InspectorAgent::domContentLoadedEventFired):
2740         (WebCore::InspectorAgent::loadEventFired):
2741         (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
2742         (WebCore::InspectorAgent::evaluateForTestInFrontend):
2743         (WebCore::InspectorAgent::showPanel):
2744         * inspector/InspectorApplicationCacheAgent.cpp:
2745         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
2746         * inspector/InspectorApplicationCacheAgent.h:
2747         * inspector/InspectorConsoleAgent.cpp:
2748         (WebCore::InspectorConsoleAgent::setFrontend):
2749         * inspector/InspectorConsoleAgent.h:
2750         * inspector/InspectorController.cpp:
2751         (WebCore::InspectorController::show):
2752         (WebCore::InspectorController::close):
2753         * inspector/InspectorDOMAgent.cpp:
2754         (WebCore::InspectorDOMAgent::setFrontend):
2755         * inspector/InspectorDOMAgent.h:
2756         * inspector/InspectorDOMStorageResource.cpp:
2757         (WebCore::InspectorDOMStorageResource::bind):
2758         * inspector/InspectorDOMStorageResource.h:
2759         * inspector/InspectorDatabaseAgent.cpp:
2760         (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
2761         (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
2762         (WebCore::InspectorDatabaseAgent::setFrontend):
2763         * inspector/InspectorDatabaseResource.cpp:
2764         (WebCore::InspectorDatabaseResource::bind):
2765         * inspector/InspectorDatabaseResource.h:
2766         * inspector/InspectorDebuggerAgent.cpp:
2767         (WebCore::InspectorDebuggerAgent::setFrontend):
2768         * inspector/InspectorDebuggerAgent.h:
2769         * inspector/InspectorProfilerAgent.cpp:
2770         * inspector/InspectorProfilerAgent.h:
2771         (WebCore::InspectorProfilerAgent::setFrontend):
2772         (WebCore::InspectorProfilerAgent::clearFrontend):
2773         * inspector/InspectorResourceAgent.cpp:
2774         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
2775         * inspector/InspectorResourceAgent.h:
2776         * inspector/InspectorTimelineAgent.cpp:
2777         (WebCore::InspectorTimelineAgent::setFrontend):
2778         * inspector/InspectorTimelineAgent.h:
2779         * inspector/front-end/DOMAgent.js:
2780         (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
2781         (WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
2782         * inspector/front-end/inspector.js:
2783
2784 2011-03-02  Kent Tamura  <tkent@chromium.org>
2785
2786         Unreviewed, a trivial regression fix.
2787
2788         Fix LocalizedNumberICU regression by r80198 and r80199.
2789         https://bugs.webkit.org/show_bug.cgi?id=55629
2790
2791         * platform/text/LocalizedNumberICU.cpp:
2792           We should use U_SUCCESS().
2793         (WebCore::createFormatterForCurrentLocale):
2794         (WebCore::parseLocalizedNumber):
2795
2796 2011-03-02  Dan Bernstein  <mitz@apple.com>
2797
2798         Let Xcode know that Localizable.strings is UTF-16-encoded.
2799
2800         * WebCore.xcodeproj/project.pbxproj:
2801
2802 2011-03-02  Andy Estes  <aestes@apple.com>
2803
2804         Reviewed by Eric Seidel.
2805
2806         HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
2807         https://bugs.webkit.org/show_bug.cgi?id=48719
2808         
2809         Instead of pushing a fake HTMLHtmlElement onto the open element stack
2810         during fragment parsing only to later remove it and reparent its
2811         children to the DocumentFragment, push the DocumentFragment directly
2812         onto the open element stack as the root node. This requires refactoring
2813         HTMLElementStack to hold ContainerNode pointers rather than Element
2814         pointers, which has implications for HTMLConstructionSite and
2815         HTMLTreeBuilder as well.
2816         
2817         With this patch, the regression in Peacekeeper due to the introduction
2818         of the HTML5 fragment parsing algorithm is ~14%. The regression from
2819         Safari 5.0.3 is ~24%.
2820
2821         No new tests. No change in behavior.
2822
2823         * dom/Element.h:
2824         (WebCore::Node::hasLocalName):
2825         * dom/Node.h:
2826         * html/parser/HTMLConstructionSite.cpp:
2827         (WebCore::HTMLNames::hasImpliedEndTag):
2828         (WebCore::HTMLConstructionSite::HTMLConstructionSite):
2829         (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
2830         (WebCore::HTMLConstructionSite::insertComment):
2831         (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
2832         (WebCore::HTMLConstructionSite::attachToCurrent):
2833         (WebCore::HTMLConstructionSite::insertScriptElement):
2834         (WebCore::HTMLConstructionSite::insertTextNode):
2835         (WebCore::HTMLConstructionSite::createElement):
2836         (WebCore::HTMLConstructionSite::createHTMLElement):
2837         (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
2838         (WebCore::HTMLConstructionSite::generateImpliedEndTags):
2839         (WebCore::HTMLConstructionSite::findFosterSite):
2840         (WebCore::HTMLConstructionSite::shouldFosterParent):
2841         * html/parser/HTMLConstructionSite.h:
2842         (WebCore::HTMLConstructionSite::currentNode):
2843         * html/parser/HTMLElementStack.cpp:
2844         (WebCore::HTMLNames::isNumberedHeaderElement):
2845         (WebCore::HTMLNames::isScopeMarker):
2846         (WebCore::HTMLNames::isListItemScopeMarker):
2847         (WebCore::HTMLNames::isTableScopeMarker):
2848         (WebCore::HTMLNames::isTableBodyScopeMarker):
2849         (WebCore::HTMLNames::isTableRowScopeMarker):
2850         (WebCore::HTMLNames::isButtonScopeMarker):
2851         (WebCore::HTMLNames::isSelectScopeMarker):
2852         (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
2853         (WebCore::HTMLElementStack::ElementRecord::replaceElement):
2854         (WebCore::HTMLElementStack::HTMLElementStack):
2855         (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
2856         (WebCore::HTMLElementStack::popAll):
2857         (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
2858         (WebCore::HTMLElementStack::popUntil):
2859         (WebCore::HTMLElementStack::popUntilPopped):
2860         (WebCore::HTMLElementStack::popUntilTableScopeMarker):
2861         (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
2862         (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
2863         (WebCore::HTMLElementStack::pushHTMLHtmlElement):
2864         (WebCore::HTMLElementStack::push):
2865         (WebCore::HTMLElementStack::insertAbove):
2866         (WebCore::HTMLElementStack::find):
2867         (WebCore::HTMLElementStack::topmost):
2868         (WebCore::HTMLElementStack::contains):
2869         (WebCore::inScopeCommon):
2870         (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
2871         (WebCore::HTMLElementStack::htmlElement):
2872         (WebCore::HTMLElementStack::rootNode):
2873         (WebCore::HTMLElementStack::pushCommon):
2874         * html/parser/HTMLElementStack.h:
2875         (WebCore::HTMLElementStack::ElementRecord::element):
2876         (WebCore::HTMLElementStack::ElementRecord::node):
2877         (WebCore::HTMLElementStack::topNode):
2878         * html/parser/HTMLTreeBuilder.cpp:
2879         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
2880         (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
2881         (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2882         (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
2883         (WebCore::HTMLTreeBuilder::processStartTag):
2884         (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
2885         (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2886         (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
2887         (WebCore::HTMLTreeBuilder::processEndTagForInCell):
2888         (WebCore::HTMLTreeBuilder::processEndTagForInBody):
2889         (WebCore::HTMLTreeBuilder::processEndTag):
2890         (WebCore::HTMLTreeBuilder::processEndOfFile):
2891         (WebCore::HTMLTreeBuilder::finished):
2892         * html/parser/HTMLTreeBuilder.h:
2893
2894 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2895
2896         Unreviewed, rolling out r80188.
2897         http://trac.webkit.org/changeset/80188
2898         https://bugs.webkit.org/show_bug.cgi?id=55647
2899
2900         Broke the WebKit API tests. (Requested by xenon on #webkit).
2901
2902         * WebCore.exp.in:
2903
2904 2011-03-02  Kent Tamura  <tkent@chromium.org>
2905
2906         Unreviewed, build fix.
2907
2908         * platform/text/LocalizedNumberICU.cpp:
2909         (WebCore::createFormatterForCurrentLocale): Fix a typo.
2910
2911 2011-03-02  Kent Tamura  <tkent@chromium.org>
2912
2913         Reviewed by Darin Adler.
2914
2915         Caching number formatter instances in LocalizedNumber* implementations
2916         https://bugs.webkit.org/show_bug.cgi?id=55629
2917
2918         No new tests. This change doesn't change existing behavior, and is
2919         covered by existing tests.
2920
2921         * platform/text/LocalizedNumberICU.cpp:
2922         (WebCore::createFormatterForCurrentLocale):
2923         (WebCore::numberFormatter): Introduce a function to return a static
2924           instance of NumberFormat.
2925         (WebCore::parseLocalizedNumber): Use numberFormatter().
2926         (WebCore::formatLocalizedNumber): Use numberFormatter().
2927         * platform/text/mac/LocalizedNumberMac.mm:
2928         (WebCore::createFormatterForCurrentLocale):
2929         (WebCore::numberFormatter): Introduce a function to return a static
2930           instance of NSNumberFormatter.
2931         (WebCore::parseLocalizedNumber): Use numberFormatter().
2932         (WebCore::formatLocalizedNumber): Use numberFormatter().
2933
2934 2011-03-02  Levi Weintraub  <leviw@chromium.org>
2935
2936         Reviewed by Ryosuke Niwa.
2937
2938         deprecatedEditingOffset should actually return the expected deprecated value for "after" positions
2939         https://bugs.webkit.org/show_bug.cgi?id=54986
2940
2941         Calls to deprecatedEditingOffset needs to return the expected value for new Before/After positions
2942         until we can update all the call sites to consider the new position types.
2943
2944         No tests. This is intended to simplify the transition to new Positions, not to change behavior.
2945
2946         * dom/Position.cpp:
2947         (WebCore::Position::deprecatedEditingOffset):
2948         (WebCore::Position::offsetForPositionAfterAnchor): Added to do the right thing while ensuring
2949         inline-speed for most calls to deprecatedEditingOffset.
2950         * dom/Position.h:
2951
2952 2011-03-02  Timothy Hatcher  <timothy@apple.com>
2953
2954         Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
2955
2956         Reviewed by Darin Adler.
2957
2958         * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
2959
2960 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2961
2962         Reviewed by David Levin.
2963
2964         Manually revert ChromiumDataObject changes.
2965         https://bugs.webkit.org/show_bug.cgi?id=55627
2966
2967         No new tests since no functionality should change.
2968
2969         * WebCore.gypi:
2970         * editing/chromium/EditorChromium.cpp:
2971         (WebCore::Editor::newGeneralClipboard):
2972         * page/chromium/EventHandlerChromium.cpp:
2973         (WebCore::EventHandler::createDraggingClipboard):
2974         * platform/chromium/ChromiumDataObject.cpp:
2975         (WebCore::ChromiumDataObject::clearData):
2976         (WebCore::ChromiumDataObject::clearAll):
2977         (WebCore::ChromiumDataObject::clearAllExceptFiles):
2978         (WebCore::ChromiumDataObject::hasData):
2979         (WebCore::ChromiumDataObject::types):
2980         (WebCore::ChromiumDataObject::getData):
2981         (WebCore::ChromiumDataObject::setData):
2982         (WebCore::ChromiumDataObject::ChromiumDataObject):
2983         * platform/chromium/ChromiumDataObject.h:
2984         (WebCore::ChromiumDataObject::create):
2985         (WebCore::ChromiumDataObject::copy):
2986         (WebCore::ChromiumDataObject::urlTitle):
2987         (WebCore::ChromiumDataObject::setUrlTitle):
2988         (WebCore::ChromiumDataObject::htmlBaseUrl):
2989         (WebCore::ChromiumDataObject::setHtmlBaseUrl):
2990         (WebCore::ChromiumDataObject::containsFilenames):
2991         (WebCore::ChromiumDataObject::filenames):
2992         (WebCore::ChromiumDataObject::setFilenames):
2993         (WebCore::ChromiumDataObject::fileExtension):
2994         (WebCore::ChromiumDataObject::setFileExtension):
2995         (WebCore::ChromiumDataObject::fileContentFilename):
2996         (WebCore::ChromiumDataObject::setFileContentFilename):
2997         (WebCore::ChromiumDataObject::fileContent):
2998         (WebCore::ChromiumDataObject::setFileContent):
2999         * platform/chromium/ClipboardChromium.cpp:
3000         * platform/chromium/ClipboardChromium.h:
3001
3002 2011-03-02  David Grogan  <dgrogan@chromium.org>
3003
3004         Reviewed by Jeremy Orlow.
3005
3006         IndexedDB: fire versionchange events when calling setVersion
3007         https://bugs.webkit.org/show_bug.cgi?id=55095
3008
3009         * dom/EventNames.h:
3010         * storage/IDBDatabase.cpp:
3011         (WebCore::IDBDatabase::setVersion):
3012         (WebCore::IDBDatabase::close):
3013         (WebCore::IDBDatabase::onVersionChange):
3014         (WebCore::IDBDatabase::open):
3015         (WebCore::IDBDatabase::enqueueEvent):
3016         (WebCore::IDBDatabase::dispatchEvent):
3017         * storage/IDBDatabase.h:
3018         (WebCore::IDBDatabase::dispatchEvent):
3019         * storage/IDBDatabase.idl:
3020         * storage/IDBDatabaseBackendImpl.cpp:
3021         (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
3022         (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::databaseCallbacks):
3023         (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall):
3024         (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
3025         (WebCore::IDBDatabaseBackendImpl::setVersion):
3026         (WebCore::IDBDatabaseBackendImpl::open):
3027         (WebCore::IDBDatabaseBackendImpl::close):
3028         * storage/IDBDatabaseBackendImpl.h:
3029         * storage/IDBDatabaseBackendInterface.h:
3030         * storage/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp.
3031         (WebCore::IDBDatabaseCallbacks::~IDBDatabaseCallbacks):
3032         * storage/IDBFactoryBackendImpl.cpp:
3033         (WebCore::IDBFactoryBackendImpl::open):
3034         * storage/IDBRequest.cpp:
3035         (WebCore::IDBRequest::onSuccess):
3036         * storage/IDBVersionChangeEvent.cpp:
3037         (WebCore::IDBVersionChangeEvent::create):
3038         (WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
3039         * storage/IDBVersionChangeEvent.h:
3040         * storage/IDBVersionChangeRequest.cpp:
3041         (WebCore::IDBVersionChangeRequest::onBlocked):
3042
3043 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
3044
3045         Fix assertion failures on Gtk bot.
3046
3047         * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks): Removed an overzealous
3048         assertion. We can get here with non-Tab key events when spatial navigation is enabled.
3049
3050 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3051
3052         Unreviewed, rolling out r80139.
3053         http://trac.webkit.org/changeset/80139
3054         https://bugs.webkit.org/show_bug.cgi?id=55620
3055
3056         failing and crashing tests on Snow Leopard bot (Requested by
3057         mihaip1 on #webkit).
3058
3059         * page/DOMWindow.cpp:
3060         * page/DOMWindow.h:
3061         * page/Frame.cpp:
3062         (WebCore::Frame::pageDestroyed):
3063         (WebCore::Frame::transferChildFrameToNewDocument):
3064         * page/Frame.h:
3065         (WebCore::Frame::detachFromPage):
3066         * page/Geolocation.cpp:
3067         (WebCore::Geolocation::~Geolocation):
3068         (WebCore::Geolocation::disconnectFrame):
3069         (WebCore::Geolocation::lastPosition):
3070         (WebCore::Geolocation::requestPermission):
3071         (WebCore::Geolocation::startUpdating):
3072         (WebCore::Geolocation::stopUpdating):
3073         * page/Geolocation.h:
3074         * page/GeolocationController.cpp:
3075         (WebCore::GeolocationController::~GeolocationController):
3076         * page/Navigator.cpp:
3077         * page/Navigator.h:
3078         * platform/mock/GeolocationClientMock.cpp:
3079         * platform/mock/GeolocationClientMock.h:
3080
3081 2011-03-02  Jessie Berlin  <jberlin@apple.com>
3082
3083         Reviewed by Adam Roben.
3084
3085         WebKit2: Use CFNetwork Sessions API.
3086         https://bugs.webkit.org/show_bug.cgi?id=55435
3087
3088         Add the ability to create a Private Browsing Storage Session.
3089
3090         * WebCore.exp.in:
3091         Export the symbol for ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase.
3092
3093         * page/Settings.cpp:
3094         (WebCore::Settings::setPrivateBrowsingEnabled):
3095         Propagate the private browsing state to the ResourceHandle.
3096
3097         * platform/mac/WebCoreSystemInterface.h:
3098         Add the function declaration for wkCreatePrivateStorageSession.
3099         * platform/mac/WebCoreSystemInterface.mm:
3100
3101         * platform/network/ResourceHandle.cpp:
3102         (WebCore::privateStorageSession):
3103         Since the same Private Browsing Storage Session will need to be accessed throughout the loading
3104         code and will need to be used by all web pages and page groups, make it a global static.
3105         (WebCore::privateBrowsingStorageSessionIdentifierBase):
3106         Ditto, since the identifier is needed to create the Private Browsing Storage Session.
3107         (WebCore::ResourceHandle::setPrivateBrowsingEnabled):
3108         If enabled, create and store the Private Browsing Storage Session.
3109         (WebCore::ResourceHandle::privateBrowsingStorageSession):
3110         (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):
3111         * platform/network/ResourceHandle.h:
3112
3113         * platform/network/cf/ResourceHandleCFNet.cpp:
3114         (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
3115         The call to wkCreatePrivateStorageSession needs to be in a file including the correct
3116         version of WKSI.
3117         (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
3118         Return the bundle identifier.
3119         * platform/network/mac/ResourceHandleMac.mm:
3120         (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
3121         The call to wkCreatePrivateStorageSession needs to be in a file importing the correct
3122         version of WKSI.
3123         (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
3124         Return the bundle identifier.
3125
3126 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3127
3128         Revert frame-specific WebClipboard changes
3129         https://bugs.webkit.org/show_bug.cgi?id=55617
3130
3131         This code is no longer needed since we've decided to use the original
3132         approach to copy/paste drag/drop handling in ClipboardChromium.
3133
3134         No new tests because no functionality changes.
3135
3136         * platform/chromium/ChromiumDataObject.cpp:
3137         (WebCore::ChromiumDataObject::createReadable):
3138         * platform/chromium/ChromiumDataObject.h:
3139         * platform/chromium/ClipboardChromium.cpp:
3140         (WebCore::ClipboardChromium::create):
3141         * platform/chromium/PlatformBridge.h:
3142         * platform/chromium/ReadableDataObject.cpp:
3143         (WebCore::ReadableDataObject::create):
3144         (WebCore::ReadableDataObject::ReadableDataObject):
3145         (WebCore::ReadableDataObject::getData):
3146         (WebCore::ReadableDataObject::urlTitle):
3147         (WebCore::ReadableDataObject::htmlBaseUrl):
3148         (WebCore::ReadableDataObject::filenames):
3149         (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
3150         * platform/chromium/ReadableDataObject.h:
3151
3152 2011-03-02  Tony Chang  <tony@chromium.org>
3153
3154         Unreviewed, rolling chromium DEPS to r76362.
3155
3156         https://bugs.webkit.org/show_bug.cgi?id=55564
3157
3158         * WebCore.gyp/WebCore.gyp: Switch to libjpeg_turbo to match chromium
3159
3160 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
3161
3162         Build fix.
3163
3164         * page/ChromeClient.h: (WebCore::ChromeClient::keyboardUIMode): I didn't mean to commit these
3165         changes yet.
3166
3167 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
3168
3169         Reviewed by John Sullivan.
3170
3171         Clean up WebCore tabsToLinks code a little
3172         https://bugs.webkit.org/show_bug.cgi?id=55606
3173
3174         No change in behavior, so no tests.
3175
3176         * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isKeyboardFocusable):
3177         This is the only caller of tabsToAllControls(). Renamed this function to tabsToAllFormControls().
3178
3179         * page/EventHandler.cpp:
3180         (WebCore::EventHandler::isKeyboardOptionTab): Moved from platform specific files. This
3181         function cannot be file static, because EventHandlerMac.mm uses it.
3182         (WebCore::eventInvertsTabsToLinksClientCallResult): Merged implementations from platform
3183         specific files. We can just as well have #if here. Renamed for clarity.
3184         (WebCore::EventHandler::tabsToLinks): Rewrote in a way that makes it clearer how "invert"
3185         works.
3186         
3187         * page/EventHandler.h: We no longer need invertSenseOfTabsToLinks() here, it's only used
3188         in EventHandler.cpp.
3189
3190         * page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3191         * page/brew/EventHandlerBrew.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3192         * page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3193         * page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3194         * page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3195         * page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3196         * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllFormControls):
3197         * page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3198         * page/win/EventHandlerWin.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3199         * page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3200         Updating all port files.
3201
3202 2011-02-28  Jeremy Orlow  <jorlow@chromium.org>
3203
3204         Reviewed by James Robinson.
3205
3206         Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
3207         https://bugs.webkit.org/show_bug.cgi?id=55443
3208
3209         Implement http://www.w3.org/Bugs/Public/show_bug.cgi?id=11948
3210
3211         The idea is to have an IDBCursor and an IDBCursorWithValue interface which
3212         inherits from the former.  index.openKeyCursor will return the former and
3213         index/objectStore.openCursor will return the latter.  We'll add a primaryKey
3214         attribute to IDBCursor.  It will always be the key of the associated object
3215         store entry.  For index.openCursor cursors, the key attribute will be the key
3216         of the index.  For objectStore.openCursors, it'll be the same as the
3217         primaryKey.  The value will be the value of the objectStore entry.
3218
3219         * WebCore.gypi:
3220         * bindings/scripts/CodeGeneratorV8.pm:
3221         * bindings/v8/SerializedScriptValue.cpp:
3222         (WebCore::SerializedScriptValue::deserializeAndSetProperty):
3223         * bindings/v8/SerializedScriptValue.h:
3224         * bindings/v8/custom/V8IDBAnyCustom.cpp:
3225         (WebCore::toV8):
3226         * storage/IDBAny.cpp:
3227         (WebCore::IDBAny::idbCursorWithValue):
3228         (WebCore::IDBAny::set):
3229         * storage/IDBAny.h:
3230         * storage/IDBCursor.cpp:
3231         (WebCore::IDBCursor::create):
3232         (WebCore::IDBCursor::primaryKey):
3233         (WebCore::IDBCursor::value):
3234         * storage/IDBCursor.h:
3235         * storage/IDBCursor.idl:
3236         * storage/IDBCursorBackendImpl.cpp:
3237         (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
3238         (WebCore::IDBCursorBackendImpl::primaryKey):
3239         (WebCore::IDBCursorBackendImpl::value):
3240         (WebCore::IDBCursorBackendImpl::update):
3241         (WebCore::IDBCursorBackendImpl::currentRowExists):
3242         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
3243         (WebCore::IDBCursorBackendImpl::deleteFunction):
3244         (WebCore::IDBCursorBackendImpl::loadCurrentRow):
3245         * storage/IDBCursorBackendImpl.h:
3246         (WebCore::IDBCursorBackendImpl::create):
3247         * storage/IDBCursorBackendInterface.h:
3248         * storage/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDBCursor.idl.
3249         (WebCore::IDBCursorWithValue::create):
3250         (WebCore::IDBCursorWithValue::IDBCursorWithValue):
3251         (WebCore::IDBCursorWithValue::~IDBCursorWithValue):
3252         * storage/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCursorBackendInterface.h.
3253         * storage/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDBCursor.idl.
3254         * storage/IDBIndex.cpp:
3255         (WebCore::IDBIndex::openCursor):
3256         (WebCore::IDBIndex::openKeyCursor):
3257         * storage/IDBIndexBackendImpl.cpp:
3258         (WebCore::IDBIndexBackendImpl::openCursorInternal):
3259         (WebCore::IDBIndexBackendImpl::openCursor):
3260         (WebCore::IDBIndexBackendImpl::openKeyCursor):
3261         * storage/IDBIndexBackendImpl.h:
3262         * storage/IDBObjectStore.cpp:
3263         (WebCore::IDBObjectStore::openCursor):
3264         * storage/IDBObjectStoreBackendImpl.cpp:
3265         (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
3266         * storage/IDBRequest.cpp:
3267         (WebCore::IDBRequest::IDBRequest):
3268         (WebCore::IDBRequest::setCursorType):
3269         (WebCore::IDBRequest::onSuccess):
3270         (WebCore::IDBRequest::dispatchEvent):
3271         * storage/IDBRequest.h:
3272
3273 2011-03-02  Aravind Akella  <aravind.akella@nokia.com>
3274
3275          Reviewed by Csaba Osztrogon√°c.
3276
3277          [Qt][WK2] Memory exhausted when building qtwebkit2 on linux
3278          https://bugs.webkit.org/show_bug.cgi?id=55484
3279
3280          Using AllInOne files to avoid memory exhaustion for debug 
3281          builds on 32 bit linux machines.
3282
3283          No new tests. Fixing a build issue.
3284
3285          * WebCore.pro:
3286
3287 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3288
3289         Reviewed by David Levin.
3290
3291         Add feature define for data transfer items
3292         https://bugs.webkit.org/show_bug.cgi?id=55510
3293
3294         * Configurations/FeatureDefines.xcconfig:
3295         * GNUmakefile.am:
3296         * features.pri:
3297
3298 2011-03-02  Dimitri Glazkov  <dglazkov@chromium.org>
3299
3300         Update location of media-file.js, which was moved in r79630.
3301
3302         * manual-tests/media-controls.html: Updated location.
3303
3304 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3305
3306         Unreviewed, rolling out r80156.
3307         http://trac.webkit.org/changeset/80156
3308         https://bugs.webkit.org/show_bug.cgi?id=55604
3309
3310         "Broke SL compile" (Requested by tonyg-cr on #webkit).
3311
3312         * bridge/jni/JNIBridge.h:
3313         (JSC::Bindings::JavaString::operator UString):
3314         * bridge/jni/jni_jsobject.mm:
3315         (JavaJSObject::call):
3316         (JavaJSObject::eval):
3317         (JavaJSObject::getMember):
3318         (JavaJSObject::setMember):
3319         (JavaJSObject::removeMember):
3320         * bridge/jni/jsc/JavaClassJSC.cpp:
3321         (JavaClass::JavaClass):
3322         * bridge/jni/jsc/JavaStringJSC.h:
3323         (JSC::Bindings::JavaStringImpl::uString):
3324         * bridge/jni/v8/JavaStringV8.h:
3325
3326 2011-03-02  Steve Block  <steveblock@google.com>
3327
3328         Reviewed by Jeremy Orlow.
3329
3330         JavaString API should be implementable by both JSC and V8
3331         https://bugs.webkit.org/show_bug.cgi?id=55567
3332
3333         Remove JavaString's UString operator and replace it with a
3334         script-engine-independent impl() method, which returns a
3335         StringImpl and can be implemented with both JSC and V8.
3336
3337         No new tests, refactoring only.
3338
3339         * bridge/jni/JNIBridge.h:
3340         (JSC::Bindings::JavaString::impl):
3341         * bridge/jni/jni_jsobject.mm:
3342         (JavaJSObject::call):
3343         (JavaJSObject::eval):
3344         (JavaJSObject::getMember):
3345         (JavaJSObject::setMember):
3346         (JavaJSObject::removeMember):
3347         * bridge/jni/jsc/JavaClassJSC.cpp:
3348         (JavaClass::JavaClass):
3349         * bridge/jni/jsc/JavaStringJSC.h:
3350         (JSC::Bindings::JavaStringImpl::impl):
3351         * bridge/jni/v8/JavaStringV8.h:
3352         (JSC::Bindings::JavaStringImpl::impl):
3353
3354 2011-03-02  Mihai Parparita  <mihaip@chromium.org>
3355
3356         Reviewed by Dimitri Glazkov.
3357
3358         Add CRASH() for CSSSelector double frees
3359         https://bugs.webkit.org/show_bug.cgi?id=55596
3360         
3361         To help track down bug 53045, add a CRASH call when the CSSSelector
3362         destructor is invoked more than once.
3363
3364         Just a check, no new tests necessary.
3365
3366         * css/CSSSelector.h:
3367         (WebCore::CSSSelector::CSSSelector):
3368         (WebCore::CSSSelector::~CSSSelector):
3369
3370 2011-03-02  Carol Szabo  <carol.szabo@nokia.com>
3371
3372         Reviewed by David Hyatt  <hyatt@apple.com>
3373
3374         content property doesn't support quotes
3375         https://bugs.webkit.org/show_bug.cgi?id=6503
3376
3377         Added full support for quotes as defined by CSS 2.1.
3378
3379         Tests: fast/css/content/content-quotes-01.html
3380                fast/css/content/content-quotes-02.html
3381                fast/css/content/content-quotes-03.html
3382                fast/css/content/content-quotes-04.html
3383                fast/css/content/content-quotes-05.html
3384                fast/css/content/content-quotes-06.html
3385
3386         * Android.mk:
3387         * CMakeLists.txt:
3388         * GNUmakefile.am:
3389         * WebCore.gypi:
3390         * WebCore.pro:
3391         * WebCore.vcproj/WebCore.vcproj:
3392         * WebCore.xcodeproj/project.pbxproj:
3393         Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
3394         * css/CSSParser.cpp:
3395         (WebCore::CSSParser::parseValue):
3396         (WebCore::CSSParser::parseQuotes):
3397         * css/CSSParser.h:
3398         Added needed stylesheet parsing support for quotes,
3399         (no-)open-quote and (no-)close-quote
3400         * css/CSSStyleSelector.cpp:
3401         (WebCore::CSSStyleSelector::applyProperty):
3402         Handled setting of the new quotes RenderStyle property and added
3403         handling of quotes for the content property.
3404         * css/html.css:
3405         (q:before):
3406         (q:after):
3407         replaced the '"' workaround with open/close-quote
3408         * rendering/RenderBlockLineLayout.cpp:
3409         (WebCore::dirtyLineBoxesForRenderer):
3410         Made RenderQuote behave like RenderCounter.
3411         Needed to ensure that the Quote text is calculated before layout,
3412         just as it is for RenderCounter.
3413         * rendering/RenderObject.h:
3414         (WebCore::RenderObject::isQuote):
3415         * rendering/RenderObjectChildList.cpp:
3416         (WebCore::RenderObjectChildList::removeChildNode):
3417         (WebCore::RenderObjectChildList::appendChildNode):
3418         (WebCore::RenderObjectChildList::insertChildNode):
3419         Handled updating of quote depth when renderers are added and removed
3420         from the tree.
3421         (WebCore::RenderObjectChildList::updateBeforeAfterContent):
3422         Added support for Quote content.
3423         * rendering/RenderQuote.cpp: Added.
3424         (WebCore::adjustDepth):
3425         (WebCore::RenderQuote::RenderQuote):
3426         (WebCore::RenderQuote::~RenderQuote):
3427         (WebCore::RenderQuote::renderName):
3428         (WebCore::RenderQuote::placeQuote):
3429         (WebCore::LanguageData::operator<):
3430         (WebCore::defaultLanguageQuotes):
3431         (WebCore::quotesMap):
3432         (WebCore::quotesForLanguage):
3433         (WebCore::defaultQuotes):
3434         (WebCore::RenderQuote::originalText):
3435         (WebCore::RenderQuote::computePreferredLogicalWidths):
3436         (WebCore::RenderQuote::rendererSubtreeAttached):
3437         (WebCore::RenderQuote::rendererRemovedFromTree):
3438         (WebCore::RenderQuote::styleDidChange):
3439         * rendering/RenderQuote.h: Added.
3440         (WebCore::RenderQuote::isQuote):
3441         (WebCore::toRenderQuote):
3442         * rendering/RenderingAllInOne.cpp:
3443         Included RenderQuote.cpp
3444         * rendering/style/StyleAllInOne.cpp:
3445         Included QuotesData.cpp
3446         * rendering/style/ContentData.cpp:
3447         (WebCore::ContentData::dataEquivalent):
3448         Checked for quotetype identity.
3449         (WebCore::ContentData::deleteContent):
3450         Accounted for the new QUOTE_TYPE.
3451         * rendering/style/ContentData.h:
3452         (WebCore::ContentData::isQuote):
3453         (WebCore::ContentData::quote):
3454         (WebCore::ContentData::setQuote):
3455         * rendering/style/QuotesData.cpp: Added.
3456         (WebCore::QuotesData::create):
3457         (WebCore::QuotesData::operator==):
3458         (WebCore::QuotesData::~QuotesData):
3459         * rendering/style/QuotesData.h: Added.
3460         (WebCore::QuotesData::data):
3461         (WebCore::QuotesData::operator delete):
3462         (WebCore::QuotesData::QuotesData):
3463         * rendering/style/RenderStyle.cpp:
3464         (WebCore::RenderStyle::setContent):
3465         (WebCore::RenderStyle::setQuotes):
3466         * rendering/style/RenderStyle.h:
3467         (WebCore::InheritedFlags::quotes):
3468         (WebCore::InheritedFlags::setQuotes):
3469         * rendering/style/RenderStyleConstants.h:
3470         * rendering/style/StyleAllInOne.cpp:
3471         Added QuotesData.cpp to the included files list.
3472         * rendering/style/StyleRareInheritedData.cpp:
3473         (WebCore::StyleRareInheritedData::operator==):
3474         Included quotes in equality check.
3475         * rendering/style/StyleRareInheritedData.h:
3476         Added quotes
3477
3478 2011-03-02  Antti Koivisto  <antti@apple.com>
3479
3480         Reviewed by Dave Hyatt.
3481
3482         Selector usage flags should not be set by the CSS parser
3483         https://bugs.webkit.org/show_bug.cgi?id=55573
3484         
3485         Currently flags like Document::usesSiblingRules() are set directly by the CSS parser. This is wrong as 
3486         we may parse stylesheets that are not actually used for document rendering. This is especially bad when
3487         the page uses querySelectorAll(). As a result we may end up in various performance penalty boxes 
3488         triggered by complex selectors for no good reason.
3489         
3490         - Use the selector traversal in style selector constructor to figure out which flags
3491           are actually needed for the currently active style sheets.
3492         - Remove the selector flag related code from the CSS parser/grammar.
3493         - Remove the usesDescendantRules flag completely. We have descendant rules in the default
3494           style sheet, every document uses them.
3495
3496         * css/CSSGrammar.y:
3497         * css/CSSParser.cpp:
3498         (WebCore::CSSParser::updateSpecifiersWithElementName):