275faa7779bd0fcf9e4c33fa7ff023c2bdcc4b54
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-29  Abhishek Arya  <inferno@chromium.org>
2
3         Reviewed by Dave Hyatt.
4
5         Allow only first table caption and destroy the remaining ones.
6         https://bugs.webkit.org/show_bug.cgi?id=58249
7
8         Previously, we were only laying out the first table caption.
9         However Table::layout didn't mark the other ones as not needing
10         layout. So after table layout completes, table is marked as not
11         needing layout with its other table caption still needing layout.
12         This causes incorrect layout root calculations and set it to a
13         node which is already getting deleted.
14
15         Tests: fast/table/dynamic-caption-add-before-child.xhtml
16                fast/table/dynamic-caption-add-remove-before-child.xhtml
17                fast/table/multiple-captions-crash.xhtml
18                fast/table/multiple-captions-crash2.xhtml
19                fast/table/multiple-captions-display.xhtml
20
21         * rendering/RenderTable.cpp:
22         (WebCore::RenderTable::addChild): when new caption or a before
23         child caption is added, we need to explicitly trigger section
24         recalc or otherwise layout won't catch it.
25         (WebCore::RenderTable::removeChild): when child to be removed is
26         m_caption, make sure to trigger style recalc on the table.
27         (WebCore::RenderTable::recalcCaption): code to destroy captions
28         other than the first one.
29         (WebCore::RenderTable::recalcSections): call recalcCaption
30         helper. Store the next sibling early since child can get destroyed
31         in recalcCaption.
32         * rendering/RenderTable.h:
33
34 2011-04-29  David Kilzer  <ddkilzer@apple.com>
35
36         Remove WML
37         https://bugs.webkit.org/show_bug.cgi?id=59678
38
39         * DerivedSources.make: Removed $(WebCore)/wml path in VPATH.
40
41 2011-04-29  James Robinson  <jamesr@chromium.org>
42
43         Unreviewed, rolling out r85330.
44         http://trac.webkit.org/changeset/85330
45         https://bugs.webkit.org/show_bug.cgi?id=41311
46
47         Caused unexpected border rendering change on 500 tests on chromium linux.
48
49         * platform/graphics/skia/GraphicsContextSkia.cpp:
50         (WebCore::GraphicsContext::drawConvexPolygon):
51         (WebCore::GraphicsContext::clipConvexPolygon):
52
53 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
54
55         [Qt] Unreviewed buildfix after r85343.
56
57         Enable strict OwnPtr for Qt
58         https://bugs.webkit.org/show_bug.cgi?id=59667
59
60         * plugins/win/PluginViewWin.cpp:
61         (WebCore::PluginView::wndProc):
62         (WebCore::PluginView::snapshot):
63
64 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
65
66         Reviewed by Adam Barth.
67
68         Enable strict OwnPtr for Qt
69         https://bugs.webkit.org/show_bug.cgi?id=59667
70
71         * platform/graphics/qt/ImageBufferQt.cpp:
72         (WebCore::ImageBufferData::ImageBufferData):
73         (WebCore::ImageBuffer::ImageBuffer):
74         * platform/graphics/qt/ImageDecoderQt.cpp:
75         (WebCore::ImageDecoderQt::setData):
76         * platform/graphics/qt/ImageDecoderQt.h:
77         * platform/network/qt/QNetworkReplyHandler.cpp:
78         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
79         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
80
81 2011-04-29  Dean Jackson  <dino@apple.com>
82
83         Reviewed by Simon Fraser.
84
85         Add ENABLE macro for WebKitAnimation
86         https://bugs.webkit.org/show_bug.cgi?id=59729
87
88         Add new feature to toggle WebKit Animation API.
89
90         * Configurations/FeatureDefines.xcconfig:
91         * GNUmakefile.am:
92         * dom/Element.idl:
93         * features.pri:
94         * page/DOMWindow.idl:
95
96 2011-04-29  Dean Jackson  <dino@apple.com>
97
98         Reviewed by Simon Fraser.
99
100         https://bugs.webkit.org/show_bug.cgi?id=59149
101         (Regression) Existing animations are not replaced when filling.
102
103         Hardware animations that fill forwards were not being correctly
104         replaced when the animation was removed. The actual animation
105         logic was working correctly, but it wasn't deleting the
106         CoreAnimation animation from the PlatformLayer. The fix was
107         to explicitly call endAnimation when disconnecting the animation
108         from its RenderObject.
109
110         Test: animations/3d/replace-filling-transform.html
111
112         * page/animation/AnimationBase.h:
113         (WebCore::AnimationBase::clear): call endAnimation as the animation is cleared
114
115 2011-04-29  Abhishek Arya  <inferno@chromium.org>
116
117         Reviewed by Nikolas Zimmermann.
118
119         When svg inline text is getting destroyed, make sure to mark
120         its svg text ancestor as needing a positioning values update.
121         This helps to recalculate layout attributes and makes sure
122         that svg inline text is not used again.
123         https://bugs.webkit.org/show_bug.cgi?id=59161
124
125         Test: svg/text/inline-text-destroy-attributes-crash.xhtml
126
127         * rendering/svg/RenderSVGInlineText.cpp:
128         (WebCore::RenderSVGInlineText::destroy):
129         * rendering/svg/RenderSVGInlineText.h:
130
131 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
132
133         [wx] Unreviewed build fix. Fix wxMSW trunk builds by adding include.
134
135         * platform/graphics/wx/GraphicsContextWx.cpp:
136
137 2011-04-29  Mike Reed  <reed@google.com>
138
139         Reviewed by Ojan Vafai.
140
141         Skia: Need to implement GraphicsContext::clipConvexPolygon()
142         https://bugs.webkit.org/show_bug.cgi?id=41311
143
144         This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
145         as that shows other issues/question unrelated to clipping.
146         https://bugs.webkit.org/show_bug.cgi?id=41311
147
148         No new tests. covered by existing layout tests
149
150         * platform/graphics/skia/GraphicsContextSkia.cpp:
151         (WebCore::setPathFromConvexPoints):
152         (WebCore::GraphicsContext::drawConvexPolygon):
153         (WebCore::GraphicsContext::clipConvexPolygon):
154
155 2011-04-29  Mike Lawther  <mikelawther@chromium.org>
156
157         Reviewed by Ojan Vafai.
158
159         Fix IR->SR typo in enum value (and resulting style fails)
160         https://bugs.webkit.org/show_bug.cgi?id=59779
161
162         No functionality change, so no new tests
163
164         * css/CSSPrimitiveValueMappings.h:
165         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
166         (WebCore::CSSPrimitiveValue::operator EShapeRendering):
167
168 2011-04-29  Pavel Feldman  <pfeldman@google.com>
169
170         Reviewed by Yury Semikhatsky.
171
172         Web Inspector: CSS editing breaks when entering "color: rgb(1"
173         https://bugs.webkit.org/show_bug.cgi?id=59789
174
175         Tests: inspector/styles/styles-add-invalid-property.html
176                inspector/styles/styles-cancel-editing.html
177                inspector/styles/styles-commit-editing.html
178
179         * inspector/front-end/CSSStyleModel.js:
180         (WebInspector.CSSProperty.prototype.setText.callback):
181         (WebInspector.CSSProperty.prototype.setText):
182         * inspector/front-end/StylesSidebarPane.js:
183         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
184         (WebInspector.StylePropertyTreeElement.prototype):
185         (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
186         * inspector/front-end/inspector.js:
187         (WebInspector.startEditing.defaultFinishHandler):
188         (WebInspector.startEditing.keyDownEventListener):
189         (WebInspector.startEditing):
190
191 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
192
193         Reviewed by Simon Hausmann.
194
195         ENABLE(QT_BEARER) -> USE(QT_BEARER)
196
197         * WebCore.pri:
198         * WebCore.pro:
199         * features.pri:
200         * platform/network/NetworkStateNotifier.h:
201         * platform/network/qt/NetworkStateNotifierQt.cpp:
202
203 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
204
205         Reviewed by Simon Hausmann.
206
207         ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
208
209         * WebCore.pri:
210         * features.pri:
211
212 2011-04-29  Pavel Podivilov  <podivilov@chromium.org>
213
214         Reviewed by Pavel Feldman.
215
216         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
217         https://bugs.webkit.org/show_bug.cgi?id=59476
218
219         * inspector/front-end/DebuggerPresentationModel.js:
220         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
221         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
222         (WebInspector.PresentationBreakpoint.prototype.serialize):
223         * inspector/front-end/ScriptsPanel.js:
224         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
225         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
226         (WebInspector.ScriptsPanel.prototype.reset):
227
228 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
229
230         Reviewed by Yury Semikhatsky.
231
232         Web Inspector: include script end line:column in scriptParsed parameters.
233         https://bugs.webkit.org/show_bug.cgi?id=59717
234
235         * bindings/js/ScriptDebugServer.cpp:
236         (WebCore::ScriptDebugServer::dispatchDidParseSource):
237         * bindings/v8/DebuggerScript.js:
238         ():
239         * bindings/v8/ScriptDebugServer.cpp:
240         (WebCore::ScriptDebugServer::dispatchDidParseSource):
241         * inspector/Inspector.json:
242         * inspector/InspectorDebuggerAgent.cpp:
243         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
244         (WebCore::InspectorDebuggerAgent::didParseSource):
245         * inspector/InspectorDebuggerAgent.h:
246         (WebCore::InspectorDebuggerAgent::Script::Script):
247         * inspector/ScriptDebugListener.h:
248         * inspector/front-end/DebuggerModel.js:
249         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
250         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
251         (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
252         * inspector/front-end/Script.js:
253         (WebInspector.Script):
254
255 2011-04-28  Yury Semikhatsky  <yurys@chromium.org>
256
257         Reviewed by Pavel Feldman.
258
259         Web Inspector: [protocol] Evaluate should expose thrown exception value
260         https://bugs.webkit.org/show_bug.cgi?id=59000
261
262         Each evaluation command may have either thrown or returned result. This is indicated
263         by wasThrown property in the protocol.
264
265         * inspector/InjectedScript.cpp:
266         (WebCore::InjectedScript::evaluate):
267         (WebCore::InjectedScript::evaluateOn):
268         (WebCore::InjectedScript::evaluateOnCallFrame):
269         (WebCore::InjectedScript::getProperties):
270         (WebCore::InjectedScript::makeEvalCall):
271         * inspector/InjectedScript.h:
272         * inspector/InjectedScriptSource.js:
273         * inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to
274         the evaluation results.
275         * inspector/InspectorDebuggerAgent.cpp:
276         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
277         * inspector/InspectorDebuggerAgent.h:
278         * inspector/InspectorRuntimeAgent.cpp:
279         (WebCore::InspectorRuntimeAgent::evaluate):
280         (WebCore::InspectorRuntimeAgent::evaluateOn):
281         (WebCore::InspectorRuntimeAgent::getProperties):
282         * inspector/InspectorRuntimeAgent.h:
283         * inspector/front-end/ConsoleView.js:
284         (WebInspector.ConsoleView.prototype.completions.evaluated):
285         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
286         (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
287         (WebInspector.ConsoleView.prototype._enterKeyPressed):
288         (WebInspector.ConsoleCommandResult):
289         * inspector/front-end/DebuggerPresentationModel.js:
290         (WebInspector.PresenationCallFrame.prototype.evaluate):
291         * inspector/front-end/ElementsTreeOutline.js:
292         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
293         * inspector/front-end/ExtensionPanel.js:
294         (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
295         * inspector/front-end/ExtensionServer.js:
296         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
297         * inspector/front-end/ObjectPropertiesSection.js:
298         (WebInspector.ObjectPropertyTreeElement.prototype.update):
299         * inspector/front-end/PropertiesSidebarPane.js:
300         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
301         * inspector/front-end/SourceFrame.js:
302         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
303         (WebInspector.SourceFrame.prototype._showPopup):
304
305 2011-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
306
307         Unreviewed, rolling out r85315.
308         http://trac.webkit.org/changeset/85315
309         https://bugs.webkit.org/show_bug.cgi?id=59792
310
311         Broke script-formatter.html test (Requested by podivilov on
312         #webkit).
313
314         * inspector/front-end/DebuggerPresentationModel.js:
315         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
316         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint):
317         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
318         (WebInspector.PresentationBreakpoint.prototype.serialize):
319         * inspector/front-end/ScriptsPanel.js:
320         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
321         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
322         (WebInspector.ScriptsPanel.prototype.reset):
323
324 2011-04-29  Vsevolod Vlasov  <vsevik@chromium.org>
325
326         Reviewed by Pavel Feldman.
327
328         Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
329         https://bugs.webkit.org/show_bug.cgi?id=58794
330
331         Added ping requests to network panel.
332
333         Test: http/tests/inspector/network/ping.html
334
335         * English.lproj/localizedStrings.js:
336         * inspector/InspectorInstrumentation.cpp:
337         (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
338         * inspector/InspectorInstrumentation.h:
339         (WebCore::InspectorInstrumentation::continueAfterPingLoader):
340         * inspector/front-end/NetworkPanel.js:
341         (WebInspector.NetworkDataGridNode.prototype.refreshResource):
342         (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
343         (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
344         * inspector/front-end/Resource.js:
345         (WebInspector.Resource.prototype.get formParameters):
346         (WebInspector.Resource.prototype.requestContentType):
347         (WebInspector.Resource.prototype.isPingRequest):
348         * loader/PingLoader.cpp:
349         (WebCore::PingLoader::PingLoader):
350         * loader/PingLoader.h:
351
352 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
353
354         Reviewed by Pavel Feldman.
355
356         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
357         https://bugs.webkit.org/show_bug.cgi?id=59476
358
359         * inspector/front-end/DebuggerPresentationModel.js:
360         (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
361         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
362         (WebInspector.PresentationBreakpoint.prototype.serialize):
363         * inspector/front-end/ScriptsPanel.js:
364         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
365         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
366         (WebInspector.ScriptsPanel.prototype.reset):
367
368 2011-04-29  Pavel Feldman  <pfeldman@google.com>
369
370         Reviewed by Yury Semikhatsky.
371
372         Web Inspector: add "open link in new tab" action into the network and resources panels.
373         https://bugs.webkit.org/show_bug.cgi?id=59788
374
375         This change also distinguishes context menu items case between platforms.
376
377         * English.lproj/localizedStrings.js:
378         * inspector/front-end/ConsoleView.js:
379         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
380         * inspector/front-end/DOMBreakpointsSidebarPane.js:
381         (WebInspector.DOMBreakpointsSidebarPane):
382         * inspector/front-end/ElementsPanel.js:
383         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
384         (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
385         * inspector/front-end/ElementsTreeOutline.js:
386         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
387         (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
388         * inspector/front-end/NetworkPanel.js:
389         (WebInspector.NetworkPanel.prototype._contextMenu):
390         * inspector/front-end/ResourcesPanel.js:
391         (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
392         (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
393         (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
394         * inspector/front-end/Settings.js:
395         * inspector/front-end/SourceFrame.js:
396         (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
397         * inspector/front-end/TextViewer.js:
398         (WebInspector.TextViewer.prototype._contextMenu):
399         * inspector/front-end/inspector.js:
400         (WebInspector.openLinkExternallyLabel):
401         (WebInspector.openResource):
402         (WebInspector.useLowerCaseMenuTitles):
403
404 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
405
406         Reviewed by Dan Bernstein.
407
408         Mask placement on composited layer is incorrect sometimes
409         https://bugs.webkit.org/show_bug.cgi?id=59775
410         
411         The mask layer always has the same size as its owning GraphicsLayer,
412         so it needs to share the same offsetFromRenderer as well. This fixes
413         the offset at which the mask layer contents are painted in cases where
414         that offset is non-zero, for example when outline style bloats all of
415         the layer sizes.
416
417         Test: compositing/masks/layer-mask-placement.html
418
419         * rendering/RenderLayerBacking.cpp:
420         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
421
422 2011-04-28  Dan Bernstein  <mitz@apple.com>
423
424         Rubber-stamped by Mark Rowe.
425
426         Reverted r81319.
427
428         Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu
429
430         * page/NavigatorBase.cpp:
431
432 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
433
434         Reviewed by Dirk Schulze.
435
436         1px box-shadow looks ugly
437         https://bugs.webkit.org/show_bug.cgi?id=58100
438         and
439         ShadowBlur incorrectly handles zero-sized blur radius in one axis
440         https://bugs.webkit.org/show_bug.cgi?id=59710
441         
442         blurLayerImage() has issues at the edges if the blur radius
443         is one, so in that case bump the buffer size out by a pixel.
444         This results in a correct, symmetrical blur.
445         
446         Also fix an issue noticed during testing where a zero
447         height or width radius would still blur on that axis,
448         because we clamp the kernel size to a minimum of two.
449
450         Test: fast/box-shadow/single-pixel-shadow.html
451
452         * platform/graphics/ShadowBlur.h:
453         * platform/graphics/ShadowBlur.cpp:
454         (WebCore::ShadowBlur::blurLayerImage):
455         Skip horizontal or vertial passes if the radius on that axis is zero.
456         Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
457         clause to the end of the loop, since it only needs to execute once
458         after the first pass.        
459         (WebCore::ShadowBlur::blurredEdgeSize):
460         New method to compute the width of the blurred edge (radius + extra
461         pixel when necessary).
462         (WebCore::ShadowBlur::calculateLayerBoundingRect):
463         (WebCore::ShadowBlur::templateSize):
464         (WebCore::ShadowBlur::drawRectShadow):
465         (WebCore::ShadowBlur::drawInsetShadow):
466         (WebCore::ShadowBlur::drawInsetShadowWithTiling):
467         (WebCore::ShadowBlur::drawRectShadowWithTiling):
468         (WebCore::ShadowBlur::drawLayerPieces):
469         Use the result of blurredEdgeSize() rather than recomputing.
470
471 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
472
473         Reviewed by Beth Dakin.
474
475         CSS sibling selector (~) does not work with :target pseudo class
476         https://bugs.webkit.org/show_bug.cgi?id=26539
477
478         Allow style recalculation of forward siblings of elements with
479         forward positional rules.
480
481         Tests: fast/css/pseudo-target-indirect-sibling-001.html
482                fast/css/pseudo-target-indirect-sibling-002.html
483
484         * dom/Element.cpp:
485         (WebCore::Element::recalcStyle):
486
487 2011-04-28  Nat Duca  <nduca@chromium.org>
488
489         Reviewed by Kenneth Russell.
490
491         [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
492         https://bugs.webkit.org/show_bug.cgi?id=59626
493
494         * platform/graphics/chromium/Extensions3DChromium.h:
495         (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
496
497 2011-04-28  Steve Lacey  <sjl@chromium.org>
498
499         Reviewed by Eric Carlson.
500
501         Change chromium media controls to use absolute positioning until bug 59644 is fixed.
502         https://bugs.webkit.org/show_bug.cgi?id=59732
503
504         * css/mediaControlsChromium.css:
505         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
506         (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
507
508 2011-04-28  Luke Macpherson   <macpherson@chromium.org>
509
510         Reviewed by Eric Seidel.
511
512         Implement CSS border width and related properties in CSSStyleApplyProperty.
513         https://bugs.webkit.org/show_bug.cgi?id=59414
514
515         No new tests as no functionality added.
516
517         * css/CSSStyleApplyProperty.cpp:
518         Separated ApplyPropertyDefault into parent and child so that other classes could inherit
519         the applyInheritValue and applyInitialValue methods only.
520         This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().
521         
522         Added ApplyPropertyWidth class for handling width based CSS properties.
523         * css/CSSStyleSelector.cpp:
524         Removed no-longer-required code for handling width based CSS properties.
525         * css/CSSStyleSelector.h:
526         Added a getter for m_rootElementStyle.
527
528 2011-04-28  Kent Tamura  <tkent@chromium.org>
529
530         Run sort-Xcode-project-file.
531
532         * WebCore.xcodeproj/project.pbxproj:
533
534 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
535
536         Reviewed by Dirk Schulze.
537
538         [Cairo] Text underline is not shadowed when text-shadow is enabled
539         https://bugs.webkit.org/show_bug.cgi?id=48074
540
541         Use ContextShadow to enable shadows for text underlines. Also remove quite a bit
542         of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
543         originally copied from the CG GraphicsContext.
544
545         * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
546           can call it from a static helper function.
547         * platform/graphics/cairo/GraphicsContextCairo.cpp:
548         (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
549         (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
550         call it multiple times when shadowing text underlines.
551         (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
552         (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
553         (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
554
555 2011-04-28  Sam Weinig  <sam@webkit.org>
556
557         Rubber-stamped by Mark Rowe.
558
559         Cleanup WebCore.xcodeproj a bit.
560
561         * WebCore.xcodeproj/project.pbxproj:
562         Added CompilerVersion.xcconfig and moved some JS bindings files into the
563         correct sub groups.
564
565 2011-04-28  David Levin  <levin@chromium.org>
566
567         Reviewed by Adam Barth.
568
569         Remove IMAGE_RESIZER related code.
570         https://bugs.webkit.org/show_bug.cgi?id=59735
571
572         * CMakeLists.txt:
573         * Configurations/FeatureDefines.xcconfig:
574         * GNUmakefile.am:
575         * GNUmakefile.list.am:
576         * WebCore.gypi:
577         * WebCore.pro:
578         * WebCore.vcproj/WebCore.vcproj:
579         * WebCore.xcodeproj/project.pbxproj:
580         * features.pri:
581         * html/AsyncImageResizer.cpp: Removed.
582         * html/AsyncImageResizer.h: Removed.
583         * html/ImageResizerThread.cpp: Removed.
584         * html/ImageResizerThread.h: Removed.
585
586 2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
587
588         Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
589
590         * inspector/front-end/Settings.js:
591         (WebInspector.Settings):
592
593 2011-04-28  Beth Dakin  <bdakin@apple.com>
594
595         Rubber-stamped by Sam Weinig.
596
597         Rolling out revision 85258! I want to fix that bug a different way.
598         * platform/mac/ScrollbarThemeMac.mm:
599         (WebCore::ScrollbarThemeMac::paint):
600
601 2011-04-28  Chang Shu  <cshu@webkit.org>
602
603         Reviewed by Eric Seidel.
604
605         isContentEditable is not working properly with document.designMode
606         https://bugs.webkit.org/show_bug.cgi?id=53031
607
608         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
609         indicates that the element.isContentEditable relies on document.designMode if its
610         and its ancestors' contenteditable attributes are set to inherit.
611
612         1. Sync document render style after document.designMode is changed.
613         2. Removed the code that does unnecessary and incorrect handling for contenteditable
614         attribute with "inherit" value.
615         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
616
617         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
618                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
619                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
620                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
621
622         * css/CSSStyleSelector.cpp:
623         (WebCore::CSSStyleSelector::styleForDocument):
624         * dom/Document.cpp:
625         (WebCore::Document::setDesignMode):
626         * dom/Node.cpp:
627         (WebCore::Node::rendererIsEditable):
628         * editing/ApplyStyleCommand.cpp:
629         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
630         * html/HTMLElement.cpp:
631         (WebCore::HTMLElement::setContentEditable):
632
633 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
634
635         Unreviewed, rolling out r85101.
636         http://trac.webkit.org/changeset/85101
637         https://bugs.webkit.org/show_bug.cgi?id=59757
638
639          it'd be better to rollout the patch and do another one with
640         another property name. Current one will bring us to a problem
641         at first run after upgrade because it's type was changed from
642         int to string. (Requested by loislo on #webkit).
643
644         * inspector/front-end/ScriptsPanel.js:
645         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
646         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
647         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
648
649 2011-04-28  Mike Reed  <reed@google.com>
650
651         Reviewed by Eric Seidel.
652
653         fix shadw behavior for both CSS and Canvas -- skia only
654         https://bugs.webkit.org/show_bug.cgi?id=59700
655
656         Test:
657         canvas/philip/tests/2d.shadow.alpha.3.html
658         canvas/philip/tests/2d.shadow.alpha.4.html
659         canvas/philip/tests/2d.shadow.alpha.5.html
660         fast/canvas/canvas-fillPath-alpha-shadow.html
661         fast/canvas/canvas-strokePath-alpha-shadow.html
662         fast/canvas/canvas-strokeRect-alpha-shadow.html
663         fast/css/text-input-with-webkit-border-radius.html
664         fast/repaint/shadow-multiple-horizontal.html
665         fast/repaint/shadow-multiple-strict-horizontal.html
666         fast/repaint/shadow-multiple-strict-vertical.html
667         fast/repaint/shadow-multiple-vertical.html
668         fast/canvas/canvas-getImageData.html
669
670         * platform/graphics/chromium/FontChromiumWin.cpp:
671         (WebCore::Font::drawGlyphs):
672         * platform/graphics/skia/GraphicsContextSkia.cpp:
673         (WebCore::GraphicsContext::setPlatformShadow):
674
675 2011-04-28  David Kilzer  <ddkilzer@apple.com>
676
677         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
678
679         Reviewed by Chris Fleizach.
680
681         Previously, AXObjectCache::attachWrapper over-retained each
682         AccessibilityObjectWrapper it created, which is why
683         AXObjectCache::detachWrapper() contained an extra -release.
684
685         * accessibility/mac/AXObjectCacheMac.mm:
686         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
687         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
688         assigns to a RetainPtr<> instance variable, it doesn't need a +1
689         retained object passed in.  Fix the leak by using a RetainPtr<>
690         for the AccessibilityObjectWrapper.
691
692 2011-04-28  Nat Duca  <nduca@chromium.org>
693
694         Reviewed by Darin Fisher.
695
696         [chromium] Compute compositor fps value and history using the frameBegin timestamp
697         https://bugs.webkit.org/show_bug.cgi?id=59668
698
699         This change switches the compositor FPS meter to use the timestamp
700         of the beginning of the frame rather than the time we call
701         swapBuffers. When scheduling is correctly tied to vsync, we can
702         have highly variable times when we finish vsync and still have
703         stable frame rates.
704
705         * platform/graphics/chromium/LayerRendererChromium.cpp:
706         (WebCore::LayerRendererChromium::updateAndDrawLayers):
707         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
708         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
709         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
710         (WebCore::CCHeadsUpDisplay::onFrameBegin):
711         (WebCore::CCHeadsUpDisplay::onPresent):
712         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
713
714 2011-04-28  Beth Dakin  <bdakin@apple.com>
715
716         Reviewed by Darin Adler.
717
718         https://bugs.webkit.org/show_bug.cgi?id=59759
719         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
720         track when there is nothing to scroll to
721         <rdar://problem/9282066>
722
723         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
724         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
725         is not right. Set the proportion to 0 in this case instead.
726         * platform/mac/ScrollbarThemeMac.mm:
727         (WebCore::ScrollbarThemeMac::paint):
728
729 2011-04-28  Dan Bernstein  <mitz@apple.com>
730
731         Reviewed by Simon Fraser.
732
733         <rdar://problem/9291132> Add support for -epub-prefixed properties
734
735         Test: fast/css/epub-properties.html
736
737         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
738         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
739         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
740         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
741         text-transform, text-transform, word-break, and -webkit-writing-mode.
742
743 2011-04-28  Adam Barth  <abarth@webkit.org>
744
745         Reviewed by Eric Seidel.
746
747         Remove WML
748         https://bugs.webkit.org/show_bug.cgi?id=59678
749
750         This patch removes WML from WebCore.  After removing WML, there's a
751         bunch of twisted code that could be untwisted, but this patch contains
752         only the purely mechanical part of removing the feature.
753
754         There's been a lot of discussion on webkit-dev about whether we should
755         remove WML.  In addition to those threads, we've had an informal poll
756         of the reviewers as well as an in-person discussion at the WebKit
757         contributor's meeting.  Removing any feature is likely to make some
758         folks unhappy, but, on balance, removing WML appears to be the right
759         thing for the project to do at this time.
760
761         * CMakeLists.txt:
762         * CodeGenerators.pri:
763         * Configurations/FeatureDefines.xcconfig:
764         * DerivedSources.cpp:
765         * DerivedSources.make:
766         * GNUmakefile.am:
767         * GNUmakefile.list.am:
768         * WebCore.gyp/WebCore.gyp:
769         * WebCore.gypi:
770         * WebCore.pro:
771         * WebCore.vcproj/WebCore.vcproj:
772         * WebCore.xcodeproj/project.pbxproj:
773         * css/CSSStyleSelector.cpp:
774         (WebCore::linkAttribute):
775         (WebCore::CSSStyleSelector::styleForElement):
776         (WebCore::CSSStyleSelector::adjustRenderStyle):
777         * css/wml.css: Removed.
778         * dom/DOMImplementation.cpp:
779         (WebCore::DOMImplementation::createDocument):
780         * dom/Document.cpp:
781         (WebCore::Document::Document):
782         (WebCore::Document::createElement):
783         * dom/Document.h:
784         (WebCore::Document::isMediaDocument):
785         * dom/Document.idl:
786         * dom/InputElement.h:
787         * dom/Node.cpp:
788         (WebCore::Node::toInputElement):
789         * dom/Node.h:
790         * dom/OptionElement.cpp:
791         (WebCore::toOptionElement):
792         (WebCore::isOptionElement):
793         * dom/OptionElement.h:
794         * dom/OptionGroupElement.cpp:
795         (WebCore::toOptionGroupElement):
796         (WebCore::isOptionGroupElement):
797         * dom/SelectElement.cpp:
798         (WebCore::toSelectElement):
799         * dom/SelectElement.h:
800         * dom/Text.cpp:
801         (WebCore::Text::attach):
802         * dom/XMLDocumentParser.cpp:
803         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
804         * dom/XMLDocumentParser.h:
805         * dom/XMLDocumentParserLibxml2.cpp:
806         (WebCore::XMLDocumentParser::internalSubset):
807         (WebCore::getEntityHandler):
808         * dom/XMLDocumentParserQt.cpp:
809         (WebCore::XMLDocumentParser::parse):
810         (WebCore::XMLDocumentParser::parseDtd):
811         * editing/htmlediting.cpp:
812         (WebCore::canHaveChildrenForEditing):
813         * features.pri:
814         * history/BackForwardList.h:
815         * history/BackForwardListImpl.cpp:
816         * history/BackForwardListImpl.h:
817         * history/PageCache.cpp:
818         (WebCore::PageCache::canCachePageContainingThisFrame):
819         * html/HTMLAnchorElement.h:
820         * inspector/ConsoleMessage.cpp:
821         (WebCore::messageSourceValue):
822         * inspector/front-end/ConsoleView.js:
823         (WebInspector.ConsoleMessage.prototype.toString):
824         * loader/FrameLoader.cpp:
825         (WebCore::isBackForwardLoadType):
826         (WebCore::FrameLoader::transitionToCommitted):
827         (WebCore::FrameLoader::shouldReload):
828         (WebCore::FrameLoader::loadDifferentDocumentItem):
829         (WebCore::FrameLoader::loadItem):
830         * loader/FrameLoaderTypes.h:
831         * loader/HistoryController.cpp:
832         (WebCore::HistoryController::restoreDocumentState):
833         * manual-tests/wml: Removed.
834         * manual-tests/wml/StartTests.wml: Removed.
835         * manual-tests/wml/a-br-element.wml: Removed.
836         * manual-tests/wml/a-element.wml: Removed.
837         * manual-tests/wml/a-img-element.wml: Removed.
838         * manual-tests/wml/access-target.wml: Removed.
839         * manual-tests/wml/anchor-br-element.wml: Removed.
840         * manual-tests/wml/anchor-element.wml: Removed.
841         * manual-tests/wml/anchor-img-element.wml: Removed.
842         * manual-tests/wml/card-newcontext-attr.wml: Removed.
843         * manual-tests/wml/card-onenterbackward.wml: Removed.
844         * manual-tests/wml/card-onenterforward.wml: Removed.
845         * manual-tests/wml/card-ontimer.wml: Removed.
846         * manual-tests/wml/deck-access-control.wml: Removed.
847         * manual-tests/wml/input-format.wml: Removed.
848         * manual-tests/wml/onevent-go.wml: Removed.
849         * manual-tests/wml/onevent-noop.wml: Removed.
850         * manual-tests/wml/onevent-prev.wml: Removed.
851         * manual-tests/wml/onevent-refresh.wml: Removed.
852         * manual-tests/wml/onevent-shadow.wml: Removed.
853         * manual-tests/wml/resources: Removed.
854         * manual-tests/wml/resources/smiley.png: Removed.
855         * manual-tests/wml/select-element.wml: Removed.
856         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
857         * manual-tests/wml/select-onpick-event.wml: Removed.
858         * manual-tests/wml/setvar-element.wml: Removed.
859         * manual-tests/wml/targetdeck.wml: Removed.
860         * manual-tests/wml/task-go-in-anchor.wml: Removed.
861         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
862         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
863         * manual-tests/wml/template-go.wml: Removed.
864         * manual-tests/wml/template-ontimer.wml: Removed.
865         * manual-tests/wml/timer.wml: Removed.
866         * manual-tests/wml/variable-substitution.wml: Removed.
867         * page/Console.cpp:
868         (WebCore::printMessageSourceAndLevelPrefix):
869         * page/Console.h:
870         * page/Frame.cpp:
871         (WebCore::Frame::Frame):
872         * page/Page.cpp:
873         * page/Page.h:
874         * platform/MIMETypeRegistry.cpp:
875         (WebCore::initializeSupportedNonImageMimeTypes):
876         * platform/network/FormDataBuilder.h:
877         * platform/network/mac/ResourceHandleMac.mm:
878         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
879         * platform/wince/MIMETypeRegistryWinCE.cpp:
880         (WebCore::initMIMETypeEntensionMap):
881         * rendering/HitTestResult.cpp:
882         (WebCore::HitTestResult::altDisplayString):
883         (WebCore::HitTestResult::absoluteImageURL):
884         (WebCore::HitTestResult::absoluteLinkURL):
885         (WebCore::HitTestResult::isLiveLink):
886         * rendering/RenderBox.cpp:
887         * rendering/RenderButton.cpp:
888         (WebCore::RenderButton::updateFromElement):
889         * rendering/RenderFieldset.cpp:
890         (WebCore::RenderFieldset::findLegend):
891         * rendering/RenderImage.cpp:
892         (WebCore::RenderImage::updateAltText):
893         * rendering/RenderObject.cpp:
894         (WebCore::RenderObject::isLegend):
895         (WebCore::RenderObject::offsetParent):
896         * wml: Removed.
897         * wml/WMLAElement.cpp: Removed.
898         * wml/WMLAElement.h: Removed.
899         * wml/WMLAccessElement.cpp: Removed.
900         * wml/WMLAccessElement.h: Removed.
901         * wml/WMLAnchorElement.cpp: Removed.
902         * wml/WMLAnchorElement.h: Removed.
903         * wml/WMLAttributeNames.in: Removed.
904         * wml/WMLBRElement.cpp: Removed.
905         * wml/WMLBRElement.h: Removed.
906         * wml/WMLCardElement.cpp: Removed.
907         * wml/WMLCardElement.h: Removed.
908         * wml/WMLDoElement.cpp: Removed.
909         * wml/WMLDoElement.h: Removed.
910         * wml/WMLDocument.cpp: Removed.
911         * wml/WMLDocument.h: Removed.
912         * wml/WMLElement.cpp: Removed.
913         * wml/WMLElement.h: Removed.
914         * wml/WMLErrorHandling.cpp: Removed.
915         * wml/WMLErrorHandling.h: Removed.
916         * wml/WMLEventHandlingElement.cpp: Removed.
917         * wml/WMLEventHandlingElement.h: Removed.
918         * wml/WMLFieldSetElement.cpp: Removed.
919         * wml/WMLFieldSetElement.h: Removed.
920         * wml/WMLFormControlElement.cpp: Removed.
921         * wml/WMLFormControlElement.h: Removed.
922         * wml/WMLGoElement.cpp: Removed.
923         * wml/WMLGoElement.h: Removed.
924         * wml/WMLImageElement.cpp: Removed.
925         * wml/WMLImageElement.h: Removed.
926         * wml/WMLImageLoader.cpp: Removed.
927         * wml/WMLImageLoader.h: Removed.
928         * wml/WMLInputElement.cpp: Removed.
929         * wml/WMLInputElement.h: Removed.
930         * wml/WMLInsertedLegendElement.cpp: Removed.
931         * wml/WMLInsertedLegendElement.h: Removed.
932         * wml/WMLIntrinsicEvent.cpp: Removed.
933         * wml/WMLIntrinsicEvent.h: Removed.
934         * wml/WMLIntrinsicEventHandler.cpp: Removed.
935         * wml/WMLIntrinsicEventHandler.h: Removed.
936         * wml/WMLMetaElement.cpp: Removed.
937         * wml/WMLMetaElement.h: Removed.
938         * wml/WMLNoopElement.cpp: Removed.
939         * wml/WMLNoopElement.h: Removed.
940         * wml/WMLOnEventElement.cpp: Removed.
941         * wml/WMLOnEventElement.h: Removed.
942         * wml/WMLOptGroupElement.cpp: Removed.
943         * wml/WMLOptGroupElement.h: Removed.
944         * wml/WMLOptionElement.cpp: Removed.
945         * wml/WMLOptionElement.h: Removed.
946         * wml/WMLPElement.cpp: Removed.
947         * wml/WMLPElement.h: Removed.
948         * wml/WMLPageState.cpp: Removed.
949         * wml/WMLPageState.h: Removed.
950         * wml/WMLPostfieldElement.cpp: Removed.
951         * wml/WMLPostfieldElement.h: Removed.
952         * wml/WMLPrevElement.cpp: Removed.
953         * wml/WMLPrevElement.h: Removed.
954         * wml/WMLRefreshElement.cpp: Removed.
955         * wml/WMLRefreshElement.h: Removed.
956         * wml/WMLSelectElement.cpp: Removed.
957         * wml/WMLSelectElement.h: Removed.
958         * wml/WMLSetvarElement.cpp: Removed.
959         * wml/WMLSetvarElement.h: Removed.
960         * wml/WMLTableElement.cpp: Removed.
961         * wml/WMLTableElement.h: Removed.
962         * wml/WMLTagNames.in: Removed.
963         * wml/WMLTaskElement.cpp: Removed.
964         * wml/WMLTaskElement.h: Removed.
965         * wml/WMLTemplateElement.cpp: Removed.
966         * wml/WMLTemplateElement.h: Removed.
967         * wml/WMLTimerElement.cpp: Removed.
968         * wml/WMLTimerElement.h: Removed.
969         * wml/WMLVariables.cpp: Removed.
970         * wml/WMLVariables.h: Removed.
971
972 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
973
974         Unreviewed, rolling out r85233 and r85235.
975         http://trac.webkit.org/changeset/85233
976         http://trac.webkit.org/changeset/85235
977         https://bugs.webkit.org/show_bug.cgi?id=59754
978
979         Causes issues with jsc. (Requested by dave_levin on #webkit).
980
981         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
982         * loader/icon/IconDatabase.cpp:
983         (WebCore::IconDatabase::defaultIcon):
984         (WebCore::IconDatabase::setIconDataForIconURL):
985         (WebCore::IconDatabase::getOrCreateIconRecord):
986         (WebCore::IconDatabase::readFromDatabase):
987
988 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
989
990         Reviewed by Adam Barth.
991
992         Introducing a new class that allows serialization of a page back
993         to HTML/XML with all its sub-frames and also retrieves the page's
994         resources.
995         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
996         https://bugs.webkit.org/show_bug.cgi?id=58947
997
998         * Android.mk:
999         * CMakeLists.txt:
1000         * GNUmakefile.list.am:
1001         * WebCore.gypi:
1002         * WebCore.pro:
1003         * WebCore.vcproj/WebCore.vcproj:
1004         * dom/Document.cpp:
1005         (WebCore::Document::suggestedMIMEType):
1006         * dom/Document.h:
1007         * editing/MarkupAccumulator.cpp:
1008         (WebCore::MarkupAccumulator::appendCustomAttributes):
1009         (WebCore::MarkupAccumulator::appendElement):
1010         * editing/MarkupAccumulator.h:
1011         * html/parser/HTMLMetaCharsetParser.cpp:
1012         (WebCore::HTMLMetaCharsetParser::processMeta):
1013         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
1014         * html/parser/HTMLMetaCharsetParser.h:
1015         * page/PageSerializer.cpp: Added.
1016         * page/PageSerializer.h: Added.
1017
1018 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
1019
1020         Reviewed by Tony Chang.
1021
1022         IndexedDB createIndex should fail if name arg is null
1023         https://bugs.webkit.org/show_bug.cgi?id=58365
1024
1025         Test: storage/indexeddb/mozilla/create-index-null-name.html
1026
1027         * storage/IDBObjectStore.idl:
1028         * storage/IDBObjectStoreBackendImpl.cpp:
1029         (WebCore::IDBObjectStoreBackendImpl::createIndex):
1030
1031 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
1032
1033         Reviewed by Tony Chang.
1034
1035         IndexedDB put() should fail if second (key) parameter is null
1036         https://bugs.webkit.org/show_bug.cgi?id=58613
1037
1038         If key arg is not specified, prpKey ends up as a null pointer in ::put().
1039         However, if the key arg is specified but is null, prpKey ends up as a
1040         valid IDBKey which has a null key type. As it happens, we need to be able
1041         to detect the difference between these cases (the key arg is optional but
1042         if specified must not be null).
1043
1044         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
1045
1046         * storage/IDBObjectStoreBackendImpl.cpp:
1047         (WebCore::IDBObjectStoreBackendImpl::put):
1048
1049 2011-04-07  David Levin  <levin@chromium.org>
1050
1051         Reviewed by Darin Adler.
1052
1053         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
1054         https://bugs.webkit.org/show_bug.cgi?id=31639
1055
1056         No new functionality exposed so no new tests. (The change is basically adding
1057         more testing.)
1058
1059         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
1060         * loader/icon/IconDatabase.cpp:
1061         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
1062         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
1063         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
1064         (WebCore::IconDatabase::readFromDatabase): Ditto.
1065
1066 2011-04-28  Kenneth Russell  <kbr@google.com>
1067
1068         Unreviewed build fix for Web Audio with strict OwnPtr.
1069
1070         * platform/audio/HRTFDatabaseLoader.cpp:
1071         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
1072
1073 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
1074
1075         Reviewed by Geoffrey Garen.
1076
1077         Walk shadow hosts as well as parent nodes when finding opaque roots.
1078         https://bugs.webkit.org/show_bug.cgi?id=59571
1079
1080         Test: fast/dom/shadow/gc-shadow.html
1081
1082         * bindings/js/JSDOMBinding.h:
1083         (WebCore::root):
1084
1085 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
1086
1087         Reviewed by Xan Lopez.
1088
1089         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
1090         https://bugs.webkit.org/show_bug.cgi?id=59715
1091
1092         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
1093         into WebCore so that WebKit1 and WebKit2 can share the code.
1094
1095         No new tests. This is covered by fast/events/click-count.html.
1096
1097         * GNUmakefile.list.am: Added new files.
1098         * platform/gtk/GtkClickCounter.cpp: Added.
1099         (WebCore::GtkClickCounter::GtkClickCounter): Added.
1100         (WebCore::GtkClickCounter::reset): Added.
1101         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
1102         (WebCore::getEventTime): Added.
1103         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
1104         * platform/gtk/GtkClickCounter.h: Added.
1105
1106 2011-04-28  Dan Bernstein  <mitz@apple.com>
1107
1108         Build fix.
1109
1110         * css/CSSParser.cpp:
1111         (WebCore::cssPropertyID):
1112
1113 2011-04-28  Dan Bernstein  <mitz@apple.com>
1114
1115         Reviewed by Simon Fraser.
1116
1117         Allow specifying CSS property aliases in CSSPropertyNames.in files
1118         https://bugs.webkit.org/show_bug.cgi?id=59712
1119
1120         * css/CSSParser.cpp:
1121         (WebCore::cssPropertyID): Removed code to handle some aliases
1122         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
1123         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
1124         defining an alias, and add an appropriate entry to the gperf file.
1125
1126 2011-04-28  Arno Renevier  <arno@renevier.net>
1127
1128         Reviewed by Gustavo Noronha Silva.
1129
1130         [Soup] does not load css stylesheets without content-type
1131         https://bugs.webkit.org/show_bug.cgi?id=59697
1132
1133         When sniffing content type, do not replace http Content-Type header in
1134         soup message anymore, but keep sniffed content type in a separate
1135         variable.
1136
1137         * platform/network/soup/ResourceHandleSoup.cpp:
1138         (WebCore::contentSniffedCallback):
1139         * platform/network/soup/ResourceResponse.h:
1140         (WebCore::ResourceResponse::sniffedContentType):
1141         (WebCore::ResourceResponse::setSniffedContentType):
1142         * platform/network/soup/ResourceResponseSoup.cpp:
1143         (WebCore::ResourceResponse::updateFromSoupMessage):
1144
1145 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
1146
1147         Reviewed by Andreas Kling.
1148
1149         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
1150         https://bugs.webkit.org/show_bug.cgi?id=59704
1151
1152         No new tests, just code cleanup.
1153
1154         * WebCore.pri:
1155
1156 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
1157
1158         Reviewed by Pavel Feldman.
1159
1160         Web Inspector: remove "Pretty print" source frame context menu item.
1161         https://bugs.webkit.org/show_bug.cgi?id=59709
1162
1163         * inspector/front-end/DebuggerPresentationModel.js:
1164         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
1165         * inspector/front-end/ScriptsPanel.js:
1166         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1167         * inspector/front-end/SourceFrame.js:
1168         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
1169
1170 2011-04-28  Satish Sampath  <satish@chromium.org>
1171
1172         Reviewed by Tony Gentilcore.
1173
1174         Speech input button layout issues with padding and border.
1175         https://bugs.webkit.org/show_bug.cgi?id=59613
1176
1177         * rendering/RenderTextControlSingleLine.cpp:
1178         (WebCore::RenderTextControlSingleLine::layout):
1179         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1180         (WebCore::RenderTextControlSingleLine::forwardEvent):
1181
1182 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1183
1184         Reviewed by Martin Robinson.
1185
1186         [GTK] Check whether to use native scrollbars at run time
1187         https://bugs.webkit.org/show_bug.cgi?id=59694
1188
1189         It's currently decided at build time depending on whether webkit2
1190         build is enabled or not. That makes imposible to build both
1191         webkit1 and webkit2 using the same libWebCore.
1192
1193         * GNUmakefile.am:
1194         * platform/ScrollView.cpp:
1195         (WebCore::ScrollView::wheelEvent):
1196         * platform/gtk/ScrollViewGtk.cpp:
1197         (WebCore::ScrollView::createScrollbar):
1198
1199 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1200
1201         Reviewed by Yury Semikhatsky.
1202
1203         Web Inspector: add status bar button for pretty print.
1204         https://bugs.webkit.org/show_bug.cgi?id=59467
1205
1206         * WebCore.gypi:
1207         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
1208         * inspector/front-end/ScriptsPanel.js:
1209         (WebInspector.ScriptsPanel):
1210         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
1211         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1212         * inspector/front-end/WebKit.qrc:
1213         * inspector/front-end/inspector.css:
1214         (.scripts-toggle-pretty-print-status-bar-item .glyph):
1215         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
1216
1217 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1218
1219         Reviewed by Yury Semikhatsky.
1220
1221         Web Inspector: add ResourceTreeModel tests.
1222         https://bugs.webkit.org/show_bug.cgi?id=59616
1223
1224         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
1225                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
1226                http/tests/inspector/resource-tree/resource-tree-reload.html
1227
1228         * inspector/front-end/ResourceTreeModel.js:
1229         (WebInspector.ResourceTreeModel.prototype.frontendReused):
1230         (WebInspector.ResourceTreeModel.prototype._addFrame):
1231         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1232         (WebInspector.ResourceTreeModel.prototype._frameDetached):
1233         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
1234         (WebInspector.ResourceTreeModel.prototype.forAllResources):
1235         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
1236         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
1237         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
1238         * inspector/front-end/ResourcesPanel.js:
1239         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1240         (WebInspector.ResourcesPanel.prototype._frameAdded):
1241         (WebInspector.ResourcesPanel.prototype._frameDetached):
1242         (WebInspector.ResourcesPanel.prototype._frameNavigated):
1243         (WebInspector.FrameTreeElement):
1244         (WebInspector.FrameTreeElement.prototype.frameNavigated):
1245
1246 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1247
1248         Reviewed by Yury Semikhatsky.
1249
1250         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
1251         https://bugs.webkit.org/show_bug.cgi?id=59592
1252
1253         * inspector/front-end/DetailedHeapshotGridNodes.js:
1254         (WebInspector.HeapSnapshotGridNode.prototype._populate):
1255         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
1256         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
1257         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
1258         * inspector/front-end/DetailedHeapshotView.js:
1259         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
1260         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
1261         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
1262         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
1263         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
1264         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
1265         (WebInspector.DetailedHeapshotView.prototype.changeView):
1266         * inspector/front-end/HeapSnapshot.js:
1267         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
1268         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
1269         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
1270         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
1271         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
1272         * inspector/front-end/heapProfiler.css:
1273         (div.retaining-paths-view td.path-column div:hover):
1274
1275 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1276
1277         Reviewed by Yury Semikhatsky.
1278
1279         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
1280         https://bugs.webkit.org/show_bug.cgi?id=59454
1281
1282         Test: inspector/profiler/heap-snapshot-loader.html
1283
1284         * inspector/front-end/HeapSnapshot.js:
1285         (WebInspector.HeapSnapshotLoader):
1286         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
1287         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
1288         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
1289         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
1290         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
1291         * inspector/front-end/HeapSnapshotProxy.js:
1292         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
1293
1294 2011-04-28  ojab  <ojab@ojab.ru>
1295
1296         Reviewed by David Levin.
1297
1298         Fix build with libpng-1.5.1
1299         https://bugs.webkit.org/show_bug.cgi?id=59607
1300
1301         * platform/image-decoders/png/PNGImageDecoder.cpp:
1302         (WebCore::readColorProfile):
1303
1304 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
1305
1306         Reviewed by Nikolas Zimmermann.
1307
1308         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
1309         https://bugs.webkit.org/show_bug.cgi?id=59447
1310
1311         This patch contains two sub-routines, one for speeding up
1312         alpha channel only gaussian blur (by 2.5 times) and one
1313         for speeding up all channel blur (by 4 times).
1314
1315         The common code is also redesigned to better fit for platform
1316         specific code. This means large chunks of code was moved to
1317         different files, and all platform specific files are added to
1318         all build systems.
1319
1320         * CMakeLists.txt:
1321         * GNUmakefile.am:
1322         * GNUmakefile.list.am:
1323         * WebCore.gypi:
1324         * WebCore.pro:
1325         * WebCore.vcproj/WebCore.vcproj:
1326         * WebCore.vcproj/WebCoreCommon.vsprops:
1327         * WebCore.xcodeproj/project.pbxproj:
1328         * platform/graphics/filters/FEGaussianBlur.cpp:
1329         (WebCore::FEGaussianBlur::platformApplyGeneric):
1330         (WebCore::FEGaussianBlur::apply):
1331         * platform/graphics/filters/FEGaussianBlur.h:
1332         (WebCore::FEGaussianBlur::kernelPosition):
1333         (WebCore::FEGaussianBlur::platformApply):
1334         * platform/graphics/filters/FELighting.cpp:
1335         (WebCore::FELighting::platformApplyGeneric):
1336         (WebCore::FELighting::drawLighting):
1337         * platform/graphics/filters/FELighting.h:
1338         (WebCore::FELighting::platformApply):
1339         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
1340         (WebCore::WTF_ALIGNED):
1341         (WebCore::feGaussianBlurConstantsForNeon):
1342         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
1343         (WebCore::FEGaussianBlur::platformApplyNeon):
1344         * platform/graphics/filters/arm/FELightingNEON.cpp:
1345         (WebCore::WTF_ALIGNED):
1346         (WebCore::FELighting::getPowerCoefficients):
1347         * platform/graphics/filters/arm/FELightingNEON.h:
1348         (WebCore::FELighting::platformApplyNeon):
1349
1350 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
1351
1352         Reviewed by Yury Semikhatsky.
1353
1354         Web Inspector: provide a hotkey for script pause
1355         https://bugs.webkit.org/show_bug.cgi?id=59593
1356
1357         In fact, F8 works as a hotkey, but this fact was not reflected
1358         in the shortcut help popup.
1359
1360         * English.lproj/localizedStrings.js:
1361         * inspector/front-end/ScriptsPanel.js:
1362         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
1363
1364 2011-04-28  Adam Barth  <abarth@webkit.org>
1365
1366         Reviewed by Eric Seidel.
1367
1368         PluginStream should play nice with strict OwnPtr
1369         https://bugs.webkit.org/show_bug.cgi?id=59675
1370
1371         These failures appear when enabling strict OwnPtr on Qt.
1372
1373         * plugins/PluginStream.cpp:
1374         (WebCore::PluginStream::PluginStream):
1375         (WebCore::PluginStream::didReceiveData):
1376
1377 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
1378
1379         Reviewed by Pavel Feldman.
1380
1381         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
1382         https://bugs.webkit.org/show_bug.cgi?id=59326
1383
1384         Concrete CachedResource successors for stylesheets and scripts
1385         can decode their content better than the generic approach we use.
1386
1387         * inspector/InspectorPageAgent.cpp:
1388         (WebCore::decodeSharedBuffer):
1389         (WebCore::prepareCachedResourceBuffer):
1390         (WebCore::cachedResourceDecoded):
1391         (WebCore::InspectorPageAgent::resourceContent):
1392         (WebCore::InspectorPageAgent::resourceData):
1393         * inspector/InspectorStyleSheet.cpp:
1394         (WebCore::InspectorStyleSheet::originalStyleSheetText):
1395
1396 2011-04-28  Jon Lee  <jonlee@apple.com>
1397
1398         Reviewed by Simon Fraser.
1399
1400         REGRESSION: white overlay scrollbars on apple.com/startpage
1401         https://bugs.webkit.org/show_bug.cgi?id=59540
1402         <rdar://problem/9338653>
1403
1404         Now we look at the document background in addition to the <body> element,
1405         and blend those colors in with the base background of the frame view to
1406         arrive at our aggregate color. This provides a better result to determine
1407         overlay scrollbar style.
1408
1409         * page/Frame.cpp:
1410         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
1411         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
1412
1413 2011-04-27  Adam Barth  <abarth@webkit.org>
1414
1415         Reviewed by Maciej Stachowiak.
1416
1417         Fix OwnPtr issues in IndexedDB
1418         https://bugs.webkit.org/show_bug.cgi?id=59656
1419
1420         This patch is an attempt to fix the clang build.  Clang can't seem to
1421         cope with OwnPtrs to classes declared in an anonymous namespace because
1422         OwnPtr's copy constructor isn't defined (but would need to be defined
1423         in this translation unit).
1424
1425         * platform/leveldb/LevelDBDatabase.cpp:
1426
1427 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
1428
1429         Reviewed by Antonio Gomes.
1430
1431         [EFL] Change cursor to LAZY_NATIVE_CURSOR
1432         https://bugs.webkit.org/show_bug.cgi?id=59411
1433
1434         Enable LAZY_NATIVE_CURSOR on EFL build.
1435
1436         No test added because functionality is unchanged.
1437
1438         * CMakeListsEfl.txt: Add Cursor.cpp
1439         * platform/Cursor.h:
1440         (WebCore::Cursor::Cursor):
1441         * platform/efl/CursorEfl.cpp:
1442         (WebCore::Cursor::Cursor):
1443         (WebCore::Cursor::~Cursor):
1444         (WebCore::getCursorString):
1445         (WebCore::Cursor::ensurePlatformCursor):
1446         * platform/efl/WidgetEfl.cpp:
1447         (WebCore::Widget::setCursor):
1448
1449 2011-04-27  Adam Barth  <abarth@webkit.org>
1450
1451         Build fix from the future.  Another trival strict OwnPtr fixes.  This
1452         is the last futuristic build fix I can detect with my time traveling
1453         abilities.
1454
1455         * platform/graphics/chromium/TransparencyWin.cpp:
1456         (WebCore::TransparencyWin::initializeNewContext):
1457
1458 2011-04-27  Dmitry Lomov  <dslomov@google.com>
1459
1460         Reviewed by David Levin.
1461
1462         CrossThreadCopier should not have a default specialization for raw pointers
1463         https://bugs.webkit.org/show_bug.cgi?id=59234
1464         Removed the ablity to pass raw pointers cross-thread
1465         Added and applied annotations for doing that
1466
1467         * fileapi/FileReader.cpp:
1468         (WebCore::FileReader::readInternal):
1469         (WebCore::FileReader::abort):
1470         * fileapi/FileStreamProxy.cpp:
1471         (WebCore::FileStreamProxy::startOnFileThread):
1472         (WebCore::FileStreamProxy::stopOnFileThread):
1473         (WebCore::FileStreamProxy::getSize):
1474         (WebCore::FileStreamProxy::getSizeOnFileThread):
1475         (WebCore::FileStreamProxy::openForRead):
1476         (WebCore::FileStreamProxy::openForReadOnFileThread):
1477         (WebCore::FileStreamProxy::openForWrite):
1478         (WebCore::FileStreamProxy::openForWriteOnFileThread):
1479         (WebCore::FileStreamProxy::close):
1480         (WebCore::FileStreamProxy::read):
1481         (WebCore::FileStreamProxy::readOnFileThread):
1482         (WebCore::FileStreamProxy::write):
1483         (WebCore::FileStreamProxy::writeOnFileThread):
1484         (WebCore::FileStreamProxy::truncate):
1485         (WebCore::FileStreamProxy::truncateOnFileThread):
1486         * loader/WorkerThreadableLoader.cpp:
1487         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
1488         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
1489         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
1490         * page/GeolocationPositionCache.cpp:
1491         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
1492         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
1493         * platform/CrossThreadCopier.h:
1494         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
1495         (WebCore::AllowCrossThreadAccessWrapper::value):
1496         (WebCore::AllowCrossThreadAccess):
1497         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
1498         (WebCore::AllowExtendedLifetimeWrapper::value):
1499         (WebCore::AllowExtendedLifetime):
1500         * platform/graphics/chromium/cc/CCCompletionEvent.h:
1501         * storage/IDBObjectStoreBackendImpl.cpp:
1502         (WebCore::IDBObjectStoreBackendImpl::get):
1503         (WebCore::IDBObjectStoreBackendImpl::put):
1504         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1505         (WebCore::IDBObjectStoreBackendImpl::clear):
1506         (WebCore::IDBObjectStoreBackendImpl::createIndex):
1507         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
1508         (WebCore::IDBObjectStoreBackendImpl::openCursor):
1509         * storage/SQLCallbackWrapper.h:
1510         (WebCore::SQLCallbackWrapper::clear):
1511         * websockets/WorkerThreadableWebSocketChannel.cpp:
1512         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
1513         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
1514         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
1515         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
1516         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
1517         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
1518         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
1519         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
1520         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
1521         * workers/WorkerMessagingProxy.cpp:
1522         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
1523
1524 2011-04-27  Adam Barth  <abarth@webkit.org>
1525
1526         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
1527
1528         * page/Frame.cpp:
1529         (WebCore::Frame::setTiledBackingStoreEnabled):
1530         * platform/audio/ReverbConvolver.cpp:
1531         (WebCore::ReverbConvolver::ReverbConvolver):
1532
1533 2011-04-27  Adam Barth  <abarth@webkit.org>
1534
1535         Reviewed by David Levin.
1536
1537         Fix five strict PassOwnPtr violations in WebCore
1538         https://bugs.webkit.org/show_bug.cgi?id=59640
1539
1540         * css/MediaList.cpp:
1541         (WebCore::MediaList::deleteMedium):
1542         (WebCore::MediaList::setMediaText):
1543         (WebCore::MediaList::appendMedium):
1544         * css/MediaQuery.h:
1545         * dom/MessagePort.cpp:
1546         (WebCore::MessagePort::disentanglePorts):
1547         (WebCore::MessagePort::entanglePorts):
1548         * inspector/InspectorStyleSheet.cpp:
1549         (ParsedStyleSheet::setText):
1550         * rendering/RenderTheme.cpp:
1551         (WebCore::RenderTheme::adjustStyle):
1552         (WebCore::RenderTheme::adjustMeterStyle):
1553         * rendering/RenderThemeMac.mm:
1554         (WebCore::RenderThemeMac::adjustMenuListStyle):
1555         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
1556         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
1557         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
1558         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
1559         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
1560         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
1561         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
1562
1563 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
1564
1565         Reviewed by Beth Dakin.
1566
1567         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
1568         https://bugs.webkit.org/show_bug.cgi?id=59648
1569
1570         Test: accessibility/aria-fallback-roles.html
1571
1572         * accessibility/AccessibilityObject.cpp:
1573         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
1574
1575 2011-04-27  Beth Dakin  <bdakin@apple.com>
1576
1577         Reviewed by Dan Bernstein.
1578
1579         https://bugs.webkit.org/show_bug.cgi?id=59671
1580         Race condition with scrollbar animations and closing a page can cause a crash in 
1581         WebCore::FrameView::setVisibleScrollerThumbRect + 15
1582         -and corresponding-
1583         <rdar://problem/9329253>
1584
1585         It is definitely possible for Page to be null here. So we should null-check it! 
1586         And we should not ASSERT.
1587         * page/FrameView.cpp:
1588         (WebCore::FrameView::didCompleteRubberBand):
1589         (WebCore::FrameView::scrollbarStyleChanged):
1590         (WebCore::FrameView::setVisibleScrollerThumbRect):
1591
1592 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1593
1594         WinCE build fix after r85143.
1595
1596         * platform/graphics/wince/FontWinCE.cpp:
1597         (WebCore::TextRunComponent::TextRunComponent):
1598
1599 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
1600
1601         Reviewed by Tony Chang.
1602
1603         IndexedDB object store delete should fail if key is null
1604         https://bugs.webkit.org/show_bug.cgi?id=58614
1605
1606         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
1607
1608         * storage/IDBObjectStoreBackendImpl.cpp:
1609         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1610
1611 2011-04-27  Eric Seidel  <eric@webkit.org>
1612
1613         Reviewed by Ryosuke Niwa.
1614
1615         Should have an easy way to construct starting BidiStatus for a paragraph root
1616         https://bugs.webkit.org/show_bug.cgi?id=59226
1617
1618         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
1619         I've made this a constructor for BidiStatus instead.
1620
1621         As part of this effort I added a direction() accessor for TextRun and got
1622         rid of the old m_rtl bool.  This is part of the generic effort in the
1623         Bidi code to replace old bool usage with the superior TextDirection enum
1624         (this generally makes the code cleaner).
1625
1626         As part of this replacement effort I found several places which were
1627         assuming LTR (by passing rtl=false) when they probably want to use
1628         the current text direction.  I suspect that LTR vs. RTL may affect
1629         string width in the case of ligatures.  It's unclear.
1630
1631         This is almost entirely a mechanical change.
1632
1633         * html/canvas/CanvasRenderingContext2D.cpp:
1634         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1635         * platform/graphics/GraphicsContext.cpp:
1636         (WebCore::GraphicsContext::drawBidiText):
1637         * platform/graphics/TextRun.h:
1638         (WebCore::TextRun::TextRun):
1639         (WebCore::TextRun::direction):
1640         (WebCore::TextRun::rtl):
1641         (WebCore::TextRun::ltr):
1642         (WebCore::TextRun::setDirection):
1643         * platform/text/BidiResolver.h:
1644         (WebCore::BidiStatus::BidiStatus):
1645         * rendering/EllipsisBox.cpp:
1646         (WebCore::EllipsisBox::paint):
1647         (WebCore::EllipsisBox::selectionRect):
1648         (WebCore::EllipsisBox::paintSelection):
1649         * rendering/InlineTextBox.cpp:
1650         (WebCore::InlineTextBox::selectionRect):
1651         (WebCore::InlineTextBox::paint):
1652         (WebCore::InlineTextBox::paintSelection):
1653         (WebCore::InlineTextBox::paintCompositionBackground):
1654         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1655         (WebCore::InlineTextBox::paintTextMatchMarker):
1656         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1657         (WebCore::InlineTextBox::offsetForPosition):
1658         (WebCore::InlineTextBox::positionForOffset):
1659         * rendering/RenderBlockLineLayout.cpp:
1660         (WebCore::RenderBlock::determineStartPosition):
1661         * rendering/RenderFileUploadControl.cpp:
1662         (WebCore::RenderFileUploadControl::paintObject):
1663         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1664         * rendering/RenderListBox.cpp:
1665         (WebCore::RenderListBox::updateFromElement):
1666         (WebCore::RenderListBox::paintItemForeground):
1667         * rendering/RenderTextControl.cpp:
1668         (WebCore::RenderTextControl::getAvgCharWidth):
1669         (WebCore::RenderTextControl::paintPlaceholder):
1670         * rendering/svg/SVGInlineTextBox.cpp:
1671         (WebCore::SVGInlineTextBox::constructTextRun):
1672         * rendering/svg/SVGTextMetrics.cpp:
1673         (WebCore::constructTextRun):
1674
1675 2011-04-27  Robert Hogan  <robert@webkit.org>
1676
1677         Reviewed by Adam Barth.
1678
1679         Allow shadowing of history object
1680         https://bugs.webkit.org/show_bug.cgi?id=55965
1681
1682         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1683                http/tests/history/cross-origin-replace-history-object.html
1684
1685         * page/DOMWindow.idl:
1686
1687 2011-04-27  James Robinson  <jamesr@chromium.org>
1688
1689         Reviewed by Kenneth Russell.
1690
1691         [chromium] Ensure compositing layers are up to date before entering doComposite
1692         https://bugs.webkit.org/show_bug.cgi?id=59159
1693
1694         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1695         GraphicsLayerClient::paintContents() implementations).
1696
1697         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1698         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1699         * platform/graphics/chromium/LayerChromium.cpp:
1700         (WebCore::LayerChromium::LayerChromium):
1701         (WebCore::LayerChromium::~LayerChromium):
1702         * platform/graphics/chromium/LayerRendererChromium.cpp:
1703         (WebCore::LayerRendererChromium::updateLayers):
1704         * platform/graphics/chromium/LayerRendererChromium.h:
1705           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1706
1707 2011-04-27  James Robinson  <jamesr@chromium.org>
1708
1709         Reviewed by Adam Barth.
1710
1711         Fix OwnPtr strict issues in chromium linux build
1712         https://bugs.webkit.org/show_bug.cgi?id=59664
1713
1714         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1715         (WebCore::ComplexTextController::getNormalizedTextRun):
1716         * platform/graphics/skia/ImageBufferSkia.cpp:
1717         (WebCore::ImageBuffer::ImageBuffer):
1718         * platform/graphics/skia/PlatformContextSkia.cpp:
1719         (WebCore::PlatformContextSkia::PlatformContextSkia):
1720
1721 2011-04-27  Chris Rogers  <crogers@google.com>
1722
1723         Reviewed by Kenneth Russell.
1724
1725         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1726         https://bugs.webkit.org/show_bug.cgi?id=59641
1727
1728         No new tests since audio API is not yet implemented.
1729
1730         * platform/audio/AudioBus.cpp:
1731         (WebCore::AudioBus::createBySampleRateConverting):
1732         (WebCore::AudioBus::createByMixingToMono):
1733
1734 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1735
1736         Motivated by Alexey Proskuryakov.
1737
1738         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1739         informative, since it confused Alexey and me.
1740
1741 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1742
1743         Reviewed by Sam Weinig.
1744
1745         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1746         https://bugs.webkit.org/show_bug.cgi?id=59646
1747
1748         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1749         a world, we need to clear all entries in the map for that world, since
1750         the finalizers that would otherwise clear those entries don't run. The
1751         simplest way to do this is just to make the world own the map.
1752         
1753         * bindings/js/DOMWrapperWorld.h:
1754         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1755         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1756         * bindings/js/JSCSSValueCustom.cpp:
1757         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1758         (WebCore::JSCSSValueOwner::finalize):
1759         * bindings/js/JSDOMBinding.h:
1760
1761 2011-04-27  Adam Barth  <abarth@webkit.org>
1762
1763         Reviewed by David Levin.
1764
1765         Fix OwnPtr issues in IndexedDB
1766         https://bugs.webkit.org/show_bug.cgi?id=59656
1767
1768         I didn't do an exhaustive review of this code, but I fixed the problems
1769         caught by turning on strict OwnPtr and all their antecedents.  This
1770         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1771         behavior change.
1772
1773         * platform/leveldb/LevelDBDatabase.cpp:
1774         (WebCore::LevelDBDatabase::LevelDBDatabase):
1775         (WebCore::LevelDBDatabase::open):
1776         (WebCore::LevelDBDatabase::createIterator):
1777         * platform/leveldb/LevelDBDatabase.h:
1778         * platform/leveldb/LevelDBIterator.cpp:
1779         (WebCore::LevelDBIterator::LevelDBIterator):
1780         * platform/leveldb/LevelDBIterator.h:
1781         * storage/IDBLevelDBBackingStore.cpp:
1782         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1783         (WebCore::IDBLevelDBBackingStore::open):
1784         (WebCore::getNewDatabaseId):
1785         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1786         (WebCore::getNewObjectStoreId):
1787         (WebCore::deleteRange):
1788         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1789         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1790         (WebCore::IDBLevelDBBackingStore::getIndexes):
1791         (WebCore::getNewIndexId):
1792         (WebCore::findGreatestKeyLessThan):
1793         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1794         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1795         (WebCore::findLastIndexKeyEqualTo):
1796         * storage/IDBLevelDBBackingStore.h:
1797
1798 2011-04-19  MORITA Hajime  <morrita@google.com>
1799
1800         Reviewed by Tony Chang.
1801
1802         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1803         https://bugs.webkit.org/show_bug.cgi?id=58113
1804
1805         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1806         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1807         * Now MarkerMapVectorPair is no longer used.
1808         
1809         No new tests, No behavior change.
1810
1811         * GNUmakefile.list.am:
1812         * WebCore.gypi:
1813         * WebCore.pro:
1814         * WebCore.vcproj/WebCore.vcproj:
1815         * WebCore.xcodeproj/project.pbxproj:
1816         * dom/DocumentMarker.h:
1817         * dom/DocumentMarkerController.cpp:
1818         (WebCore::DocumentMarkerController::addMarker):
1819         (WebCore::DocumentMarkerController::copyMarkers):
1820         (WebCore::DocumentMarkerController::removeMarkers):
1821         (WebCore::DocumentMarkerController::markerContainingPoint):
1822         (WebCore::DocumentMarkerController::markersForNode):
1823         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1824         (WebCore::DocumentMarkerController::removeMarkersFromList):
1825         (WebCore::DocumentMarkerController::repaintMarkers):
1826         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1827         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1828         (WebCore::DocumentMarkerController::shiftMarkers):
1829         (WebCore::DocumentMarkerController::setMarkersActive):
1830         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1831         (WebCore::DocumentMarkerController::showMarkers):
1832         * dom/DocumentMarkerController.h:
1833         * dom/RenderedDocumentMarker.h: Added.
1834         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1835         (WebCore::RenderedDocumentMarker::isRendered):
1836         (WebCore::RenderedDocumentMarker::contains):
1837         (WebCore::RenderedDocumentMarker::setRenderedRect):
1838         (WebCore::RenderedDocumentMarker::renderedRect):
1839         (WebCore::RenderedDocumentMarker::invalidate):
1840         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1841
1842 2011-04-27  James Robinson  <jamesr@chromium.org>
1843
1844         Unreviewed, rolling out r85112.
1845         http://trac.webkit.org/changeset/85112
1846         https://bugs.webkit.org/show_bug.cgi?id=59159
1847
1848         Broke mac compile
1849
1850         * page/FrameView.cpp:
1851         (WebCore::FrameView::updateCompositingLayers):
1852         * page/FrameView.h:
1853         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1854         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1855         * platform/graphics/chromium/LayerChromium.cpp:
1856         (WebCore::LayerChromium::LayerChromium):
1857         (WebCore::LayerChromium::~LayerChromium):
1858         * platform/graphics/chromium/LayerRendererChromium.cpp:
1859         (WebCore::LayerRendererChromium::updateLayers):
1860         * platform/graphics/chromium/LayerRendererChromium.h:
1861
1862 2011-04-27  Mark Rowe  <mrowe@apple.com>
1863
1864         Build fix.
1865
1866         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1867
1868 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1869
1870         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1871
1872         * platform/network/ResourceHandleClient.h:
1873
1874 2011-04-27  James Robinson  <jamesr@chromium.org>
1875
1876         Reviewed by Kenneth Russell.
1877
1878         [chromium] Ensure compositing layers are up to date before entering doComposite
1879         https://bugs.webkit.org/show_bug.cgi?id=59159
1880
1881         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1882         GraphicsLayerClient::paintContents() implementations).
1883
1884         * page/FrameView.cpp:
1885         (WebCore::FrameView::updateCompositingLayers):
1886             Add an optional CompositingUpdateType parameter.
1887         * page/FrameView.h:
1888         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1889         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1890         * platform/graphics/chromium/LayerChromium.cpp:
1891         (WebCore::LayerChromium::LayerChromium):
1892         (WebCore::LayerChromium::~LayerChromium):
1893         * platform/graphics/chromium/LayerRendererChromium.cpp:
1894         (WebCore::LayerRendererChromium::updateLayers):
1895         * platform/graphics/chromium/LayerRendererChromium.h:
1896           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1897         * rendering/RenderLayer.cpp:
1898         (WebCore::RenderLayer::dirtyZOrderLists):
1899         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1900         * rendering/RenderLayerCompositor.cpp:
1901         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1902         * rendering/RenderLayerCompositor.h:
1903           Fix a typo in CompositingUpdateType Pait->Paint
1904
1905 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1906
1907         Reviewed by Antti Koivisto.
1908
1909         Part of WebCore should use CFNetwork-based loader on Mac
1910         https://bugs.webkit.org/show_bug.cgi?id=51836
1911
1912         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1913         willCacheResponse/shouldCacheResponse.
1914
1915         * loader/EmptyClients.h:
1916         * loader/FrameLoaderClient.h:
1917         * loader/ResourceLoader.h:
1918         * loader/cf/ResourceLoaderCFNet.cpp:
1919         * loader/mac/ResourceLoaderMac.mm:
1920         (WebCore::ResourceLoader::willCacheResponse):
1921         * platform/network/ResourceHandleClient.h:
1922         (WebCore::ResourceHandleClient::willCacheResponse):
1923         (WebCore::ResourceHandleClient::shouldCacheResponse):
1924         * platform/network/cf/ResourceHandleCFNet.cpp:
1925         (WebCore::willCacheResponse):
1926
1927 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
1928
1929         Reviewed by Brian Weinstein.
1930
1931         Web Inspector: Stop on Exception state does not persist.
1932
1933         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
1934         https://bugs.webkit.org/show_bug.cgi?id=59630
1935
1936         * inspector/front-end/ScriptsPanel.js:
1937         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1938         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1939         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1940
1941 2011-04-27  Adrienne Walker  <enne@google.com>
1942
1943         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
1944         https://bugs.webkit.org/show_bug.cgi?id=59020
1945
1946         * platform/graphics/chromium/LayerRendererChromium.cpp:
1947         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1948
1949 2011-04-27  Darin Adler  <darin@apple.com>
1950
1951         Reviewed by David Levin.
1952
1953         Fix strict OwnPtr issues seen in about 30 more files
1954         https://bugs.webkit.org/show_bug.cgi?id=59615
1955
1956         * bindings/js/JSCallbackData.h:
1957         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
1958         * bindings/js/JSMessageEventCustom.cpp:
1959         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
1960         * css/CSSParser.cpp:
1961         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
1962         adoptPtr, and release.
1963         * dom/MessageEvent.cpp:
1964         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
1965         and release.
1966         * dom/MessagePortChannel.cpp:
1967         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
1968         * dom/ScriptExecutionContext.cpp:
1969         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
1970         * dom/XMLDocumentParserLibxml2.cpp:
1971         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
1972         * dom/default/PlatformMessagePortChannel.cpp:
1973         (WebCore::MessagePortChannel::create): Use adoptPtr.
1974         * html/HTMLFormControlElement.cpp:
1975         (WebCore::HTMLFormControlElement::detach): Use nullptr.
1976         * inspector/InspectorAgent.cpp:
1977         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
1978         * inspector/InspectorConsoleAgent.cpp:
1979         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
1980         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
1981         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
1982         * inspector/InspectorController.cpp:
1983         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
1984         * inspector/InspectorDOMAgent.cpp:
1985         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
1986         * inspector/InspectorResourceAgent.cpp:
1987         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1988         * page/FrameActionScheduler.cpp:
1989         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1990         * platform/graphics/ShadowBlur.cpp:
1991         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1992         * platform/graphics/ca/GraphicsLayerCA.cpp:
1993         (WebCore::GraphicsLayer::create): Use adoptPtr.
1994         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1995         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1996         * rendering/RenderBlock.cpp:
1997         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1998         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1999         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
2000         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
2001         * rendering/RenderLayerBacking.cpp:
2002         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
2003         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
2004         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
2005         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
2006         * rendering/RenderLayerCompositor.cpp:
2007         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
2008         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
2009         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
2010         * rendering/style/StyleRareNonInheritedData.cpp:
2011         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
2012         explicit initializations of OwnPtr members to 0. Use adoptPtr.
2013         * workers/SharedWorkerContext.cpp:
2014         (WebCore::createConnectEvent): Use adoptPtr.
2015         * workers/Worker.cpp:
2016         (WebCore::Worker::notifyFinished): Use nullptr.
2017
2018 2011-04-27  Enrica Casucci  <enrica@apple.com>
2019
2020         Reviewed by Darin Adler.
2021
2022         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
2023         https://bugs.webkit.org/show_bug.cgi?id=59251
2024         <rdar://problem/9327044>
2025
2026         When we are looking for wrapping elements that are presentational, we should
2027         include elements that have a non transparent background color only if they
2028         are not blocks.
2029
2030         Test: editing/pasteboard/do-not-copy-body-color.html
2031
2032         * editing/markup.cpp:
2033         (WebCore::isElementPresentational):
2034
2035 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
2036
2037         Reviewed by Antti Koivisto.
2038
2039         Teach sub-selector chains about shadow descendants
2040         https://bugs.webkit.org/show_bug.cgi?id=58342
2041
2042         The primary change is to the logic of parsing specifiers:
2043         1) The shadow descendant selectors (those specifiers that are unknown
2044         pseudo element selectors) are always kept at the top of the chain.
2045         2) The sub-selectors after shadow descendant selectors are stashed right
2046         behind the sub-selector, but not at the end of the chain.
2047         3) Other sub-selectors are appended at the end of the chain.
2048
2049         * css/CSSGrammar.y: Changed specifier_list collection to use new
2050             CSSParser::updateSpecifier helper.
2051         * css/CSSParser.cpp:
2052         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
2053             look for the last ShadowDescendant relation in the chain of selectors,
2054             because the next selector after it is the one that should get the
2055             element name.
2056         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
2057             CSSGrammar.y. The new logic adjusts the selector chain to allow
2058             shadow descendant selectors have sub-selectors (and have multiple shadow
2059             descendants in the chain).
2060         * css/CSSParser.h: Added decl.
2061         * css/CSSParserValues.cpp:
2062         (WebCore::CSSParserSelector::insertTagHistory): Added.
2063         (WebCore::CSSParserSelector::appendTagHistory): Aded.
2064         * css/CSSParserValues.h: Added decls.
2065         * css/CSSStyleSelector.cpp:
2066         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
2067             shadow descendant selector match check, since now there could be many
2068             of them in the selector chain.
2069
2070 2011-04-20  Adrienne Walker  <enne@google.com>
2071
2072         Reviewed by Kenneth Russell.
2073
2074         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
2075         https://bugs.webkit.org/show_bug.cgi?id=59020
2076
2077         mapRect is the incorrect transform here.  The parent scissor rect
2078         needs to be projected into layer space instead.
2079
2080         Test: compositing/flat-with-transformed-child.html
2081
2082         * platform/graphics/chromium/LayerRendererChromium.cpp:
2083         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2084
2085 2011-04-27  Pratik Solanki  <psolanki@apple.com>
2086
2087         Reviewed by Antti Koivisto.
2088
2089         Part of WebCore should use CFNetwork-based loader on Mac
2090         https://bugs.webkit.org/show_bug.cgi?id=51836
2091
2092         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
2093         * platform/mac/SoftLinking.h:
2094         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
2095
2096 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
2097
2098         Reviewed by Antti Koivisto.
2099
2100         Cleanup CSSStyleApplyProperty.cpp
2101         https://bugs.webkit.org/show_bug.cgi?id=59623
2102
2103         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
2104         Use typedefs instead of repating the function pointer declarations in a few places.
2105
2106         * css/CSSStyleApplyProperty.cpp:
2107         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
2108         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
2109         (WebCore::ApplyPropertyColor::applyInheritValue):
2110         (WebCore::ApplyPropertyColor::applyInitialValue):
2111         (WebCore::ApplyPropertyColor::applyValue):
2112         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2113
2114 2011-04-27  Dan Bernstein  <mitz@apple.com>
2115
2116         Reviewed by Anders Carlsson.
2117
2118         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
2119         https://bugs.webkit.org/show_bug.cgi?id=59622
2120
2121         Test: fast/borders/border-image-trumps-radius.html
2122
2123         * rendering/RenderBox.cpp:
2124         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
2125         image, then border radius is ignored, so no bleed avoidance is needed.
2126         * rendering/RenderObject.cpp:
2127         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
2128         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
2129         * rendering/RenderObject.h:
2130
2131 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2132
2133         Reviewed by Xan Lopez.
2134
2135         [GTK] editing/pasteboard/copy-standalone-image.html fails
2136         https://bugs.webkit.org/show_bug.cgi?id=53645
2137
2138         When writing an image to the clipboard, also write the URL and title
2139         into the markup and URL portion. This change also abstracts a helper
2140         imageToMarkup into markup.{cpp/h} from several different locations
2141         throughout the platform layer.
2142
2143         * editing/markup.h: Added new function definition.
2144         * editing/markup.cpp:
2145         (WebCore::imageToMarkup): Add this function which turns an image URL 
2146         and element into some markup representing that image, while preserving
2147         non-src attributes.
2148         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
2149         to markup.cpp.
2150         * platform/gtk/PasteboardGtk.cpp:
2151         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
2152         image URL for a variety of image tag types.
2153         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
2154         markup and URL portions of the clipboard. This will ensure that images
2155         paste properly back into WebKit.
2156         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
2157         one from markup.h
2158
2159 2011-04-27  Steve Block  <steveblock@google.com>
2160
2161         Reviewed by David Levin.
2162
2163         Remove Android build system
2164         https://bugs.webkit.org/show_bug.cgi?id=48111
2165
2166         This is to avoid the maintenance burden until the Android port is
2167         fully upstreamed.
2168
2169         No new tests, build change only.
2170
2171         * Android.derived.jscbindings.mk: Removed.
2172         * Android.derived.mk: Removed.
2173         * Android.derived.v8bindings.mk: Removed.
2174         * Android.jscbindings.mk: Removed.
2175         * Android.mk: Removed.
2176         * Android.v8bindings.mk: Removed.
2177
2178 2011-04-27  Darin Adler  <darin@apple.com>
2179
2180         Reviewed by Sam Weinig.
2181
2182         Somehow about:blank gets into the icon database
2183         https://bugs.webkit.org/show_bug.cgi?id=58067
2184         rdar://problem/6751446
2185
2186         Implemented the policy Brady suggested, where only http and https URLs can
2187         be associated with and icon, guarding both on the way in to the database,
2188         and on the way out.
2189
2190         * loader/icon/IconDatabase.cpp:
2191         (WebCore::pageCanHaveIcon): Added.
2192         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
2193         instead of just checking for an empty URL.
2194         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
2195         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
2196         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
2197         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
2198         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
2199         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
2200         two separate assertions and added a third.
2201         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
2202
2203         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
2204         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
2205         overloaded it to work on both UChar and char, and added an assertion to it.
2206         Also moved this to the top of the file and made the UChar version usable
2207         in the shared code used even by Google.
2208         (WebCore::KURL::invalidate): Updated for name change.
2209         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
2210         toASCIILower since it's faster.
2211         (WebCore::KURL::parse): Updated for name changes.
2212         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
2213         since it's faster.
2214         (WebCore::protocolIsInHTTPFamily): Added.
2215
2216         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
2217         to protocolIsInHTTPFamily and added a version that works on a string.
2218         Kept the old name as an inline function so we don't have to rename
2219         all the cal sites now.
2220
2221         * platform/KURLGoogle.cpp: Renamed as above.
2222         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
2223         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
2224         (WebCore::KURLGooglePrivate::setAscii): Ditto.
2225         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
2226         (WebCore::KURLGooglePrivate::copyTo): Ditto.
2227         (WebCore::KURL::KURL): Ditto.
2228         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
2229         (WebCore::KURL::invalidate): Ditto.
2230         * platform/KURLGooglePrivate.h: Ditto.
2231
2232         * WebCore.exp.in: Updated for above changes.
2233
2234 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2235
2236         Reviewed by Pavel Feldman.
2237
2238         Web Inspector: browser crash on evaluation of 'throw undefined'
2239         https://bugs.webkit.org/show_bug.cgi?id=59611
2240
2241         Test: inspector/console/console-eval-throw-undefined.html
2242
2243         * inspector/InjectedScriptSource.js: use try/catch to protect from
2244         exception during conversion of another exception to string.
2245
2246 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2247
2248         Reviewed by Yury Semikhatsky.
2249
2250         Web Inspector: clicking bookmarklet multiplies resources panel entries.
2251         https://bugs.webkit.org/show_bug.cgi?id=59590
2252
2253         * inspector/front-end/ResourceTreeModel.js:
2254         (WebInspector.ResourceTreeModel):
2255         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2256         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2257         * inspector/front-end/ResourcesPanel.js:
2258         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
2259         (WebInspector.FrameTreeElement):
2260         (WebInspector.FrameTreeElement.prototype.appendResource):
2261         * inspector/front-end/inspector.js:
2262         (WebInspector.frontendReused):
2263
2264 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2265
2266         Reviewed by Yury Semikhatsky.
2267
2268         Web Inspector: opening bookmarklet disconnects DOM agent.
2269         https://bugs.webkit.org/show_bug.cgi?id=59588
2270
2271         * inspector/InspectorDOMAgent.cpp:
2272         (WebCore::InspectorDOMAgent::setDocument):
2273
2274 2011-04-27  Hans Wennborg  <hans@chromium.org>
2275
2276         Reviewed by Tony Gentilcore.
2277
2278         IndexedDB: Fix compiler warnings about uninitialized variables
2279         https://bugs.webkit.org/show_bug.cgi?id=59599
2280
2281         Build fix. No new tests.
2282
2283         * storage/IDBLevelDBBackingStore.cpp:
2284         (WebCore::getNewObjectStoreId):
2285         (WebCore::getNewIndexId):
2286
2287 2011-04-26  Hans Wennborg  <hans@chromium.org>
2288
2289         Reviewed by Tony Gentilcore.
2290
2291         IndexedDB: Move LevelDB key coding routines to separate file
2292         https://bugs.webkit.org/show_bug.cgi?id=59452
2293
2294         Move all routines concerned with encoding, decoding and comparison of
2295         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
2296         IDBLevelDBCoding.cpp.
2297
2298         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
2299         allow for unit testing of the coding routines.
2300
2301         No new functionality, no new tests.
2302
2303         * WebCore.gypi:
2304         * storage/IDBLevelDBBackingStore.cpp:
2305         (WebCore::getInt):
2306         (WebCore::putInt):
2307         (WebCore::getString):
2308         (WebCore::putString):
2309         (WebCore::compareKeys):
2310         (WebCore::compareIndexKeys):
2311         (WebCore::Comparator::compare):
2312         (WebCore::setUpMetadata):
2313         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
2314         (WebCore::getNewDatabaseId):
2315         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
2316         (WebCore::IDBLevelDBBackingStore::getObjectStores):
2317         (WebCore::getNewObjectStoreId):
2318         (WebCore::IDBLevelDBBackingStore::createObjectStore):
2319         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
2320         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
2321         (WebCore::getNewVersionNumber):
2322         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
2323         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
2324         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
2325         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
2326         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
2327         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
2328         (WebCore::IDBLevelDBBackingStore::getIndexes):
2329         (WebCore::getNewIndexId):
2330         (WebCore::IDBLevelDBBackingStore::createIndex):
2331         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
2332         (WebCore::versionExists):
2333         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
2334         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
2335         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
2336         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
2337         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
2338         * storage/IDBLevelDBCoding.cpp: Added.
2339         (WebCore::IDBLevelDBCoding::encodeByte):
2340         (WebCore::IDBLevelDBCoding::maxIDBKey):
2341         (WebCore::IDBLevelDBCoding::minIDBKey):
2342         (WebCore::IDBLevelDBCoding::encodeInt):
2343         (WebCore::IDBLevelDBCoding::decodeInt):
2344         (WebCore::IDBLevelDBCoding::encodeVarInt):
2345         (WebCore::IDBLevelDBCoding::decodeVarInt):
2346         (WebCore::IDBLevelDBCoding::encodeString):
2347         (WebCore::IDBLevelDBCoding::decodeString):
2348         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
2349         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
2350         (WebCore::IDBLevelDBCoding::encodeDouble):
2351         (WebCore::IDBLevelDBCoding::decodeDouble):
2352         (WebCore::IDBLevelDBCoding::encodeIDBKey):
2353         (WebCore::IDBLevelDBCoding::decodeIDBKey):
2354         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
2355         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
2356         (WebCore::IDBLevelDBCoding::compare):
2357         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
2358         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
2359         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
2360         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
2361         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
2362         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
2363         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
2364         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
2365         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
2366         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
2367         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
2368         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
2369         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
2370         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
2371         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
2372         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
2373         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
2374         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
2375         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
2376         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
2377         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
2378         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
2379         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
2380         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
2381         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
2382         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
2383         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
2384         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
2385         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
2386         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
2387         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
2388         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
2389         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
2390         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
2391         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
2392         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
2393         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
2394         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
2395         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
2396         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
2397         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
2398         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
2399         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
2400         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
2401         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
2402         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
2403         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
2404         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
2405         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
2406         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
2407         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
2408         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
2409         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
2410         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
2411         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
2412         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
2413         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
2414         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
2415         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
2416         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
2417         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
2418         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
2419         * storage/IDBLevelDBCoding.h: Added.
2420         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
2421         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
2422         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
2423         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
2424         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
2425
2426 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2427
2428         Reviewed by Pavel Feldman.
2429
2430         Web Inspector: expose exception details when script is paused on exception
2431         https://bugs.webkit.org/show_bug.cgi?id=59591
2432
2433         When script is paused on an exception, the exception value is added as <exception>
2434         property in the local scope and the breakpoint details message says
2435         "Paused on excepion: '<exception to strin value>'."
2436
2437         * English.lproj/localizedStrings.js:
2438         * inspector/front-end/ScopeChainSidebarPane.js:
2439         (WebInspector.ScopeChainSidebarPane.prototype.update):
2440         * inspector/front-end/ScriptsPanel.js:
2441         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
2442         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
2443
2444 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
2445
2446         Reviewed by Pavel Feldman.
2447
2448         Web Inspector: [protocol] Paused event should expose exception value that caused it
2449         https://bugs.webkit.org/show_bug.cgi?id=58996
2450
2451         Debug.pause event now contains an optional reference to the exception
2452         object in case script execution is paused on a JavaScript exception.
2453
2454         Also JavaScript call frames are passed directly into the injected script when
2455         we need to wrap them for passing to the front-end. This change breaks cyclic
2456         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
2457
2458         * bindings/js/JSInjectedScriptHostCustom.cpp:
2459         * bindings/js/ScriptDebugServer.cpp:
2460         (WebCore::ScriptDebugServer::dispatchDidPause):
2461         * bindings/js/ScriptDebugServer.h:
2462         * bindings/v8/ScriptDebugServer.cpp:
2463         (WebCore::ScriptDebugServer::breakProgram):
2464         (WebCore::ScriptDebugServer::editScriptSource):
2465         (WebCore::ScriptDebugServer::breakProgramCallback):
2466         (WebCore::ScriptDebugServer::handleV8DebugEvent):
2467         * bindings/v8/ScriptDebugServer.h:
2468         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2469         * inspector/InjectedScript.cpp:
2470         (WebCore::InjectedScript::evaluateOnCallFrame):
2471         (WebCore::InjectedScript::wrapCallFrames):
2472         * inspector/InjectedScript.h:
2473         * inspector/InjectedScriptHost.cpp:
2474         * inspector/InjectedScriptHost.h:
2475         (WebCore::InjectedScriptHost::init):
2476         * inspector/InjectedScriptHost.idl:
2477         * inspector/InjectedScriptSource.js:
2478         (.):
2479         * inspector/Inspector.json:
2480         * inspector/InspectorAgent.cpp:
2481         (WebCore::InspectorAgent::InspectorAgent):
2482         * inspector/InspectorDebuggerAgent.cpp:
2483         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
2484         (WebCore::InspectorDebuggerAgent::currentCallFrames):
2485         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
2486         (WebCore::InspectorDebuggerAgent::didPause):
2487         (WebCore::InspectorDebuggerAgent::didContinue):
2488         (WebCore::InspectorDebuggerAgent::clear):
2489         * inspector/InspectorDebuggerAgent.h:
2490         * inspector/ScriptDebugListener.h:
2491         * inspector/WorkerInspectorController.cpp:
2492         (WebCore::WorkerInspectorController::WorkerInspectorController):
2493
2494 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2495
2496         Reviewed by Yury Semikhatsky.
2497
2498         Web Inspector: implement incremental CSS editing in the structure view.
2499         https://bugs.webkit.org/show_bug.cgi?id=59455
2500
2501         * inspector/front-end/StylesSidebarPane.js:
2502         (WebInspector.StylePropertyTreeElement.prototype):
2503
2504 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
2505
2506         Reviewed by Eric Seidel.
2507
2508         Frame.h shouldn't include Document.h
2509         https://bugs.webkit.org/show_bug.cgi?id=59560
2510
2511         Frame can use a forward-declared Document if we move
2512         Frame::displayStringModifiedByEncoding's implementation out of the
2513         header.
2514                                 Size  #includes  Size * #includes
2515         Before: page/Frame.h:   0.746       653           487.138
2516                 dom/Document.h: 0.220      1306           287.320
2517         
2518         After:  page/Frame.h:   0.646       653           421.838
2519                 dom/Document.h: 0.220      1189           261.580
2520
2521         * WebCore.exp.in:
2522         * bindings/ScriptControllerBase.cpp:
2523         * bindings/generic/BindingSecurityBase.cpp:
2524         * bindings/v8/V8Proxy.cpp:
2525         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
2526         * dom/CharacterData.cpp:
2527         * dom/UserTypingGestureIndicator.cpp:
2528         * editing/chromium/SelectionControllerChromium.cpp:
2529         * inspector/InspectorDOMStorageResource.cpp:
2530         * inspector/InspectorInstrumentation.h:
2531         * loader/PingLoader.cpp:
2532         * loader/SubresourceLoader.cpp:
2533         * loader/appcache/DOMApplicationCache.cpp:
2534         * loader/cache/CachedResourceRequest.cpp:
2535         * page/Frame.cpp:
2536         (WebCore::Frame::displayStringModifiedByEncoding):
2537         * page/Frame.h:
2538         * page/Geolocation.cpp:
2539         * page/Location.cpp:
2540         * page/Navigator.cpp:
2541         * page/PageGroupLoadDeferrer.cpp:
2542         * page/PerformanceTiming.cpp:
2543         * xml/XSLTProcessorLibxslt.cpp:
2544
2545 2011-04-27  James Robinson  <jamesr@chromium.org>
2546
2547         Reviewed by Eric Seidel.
2548
2549         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2550         https://bugs.webkit.org/show_bug.cgi?id=59377
2551
2552         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
2553         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
2554
2555         * css/CSSStyleSelector.cpp:
2556         (WebCore::CSSStyleSelector::applyProperty):
2557         * page/animation/AnimationBase.cpp:
2558         (WebCore::blendFunc):
2559         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2560         (WebCore::PropertyWrapperShadow::blend):
2561         * rendering/style/RenderStyle.cpp:
2562         (WebCore::RenderStyle::setTextShadow):
2563         (WebCore::RenderStyle::setBoxShadow):
2564         * rendering/style/RenderStyle.h:
2565         (WebCore::InheritedFlags::textShadow):
2566         * rendering/style/ShadowData.cpp:
2567         (WebCore::ShadowData::ShadowData):
2568         * rendering/style/ShadowData.h:
2569         (WebCore::ShadowData::ShadowData):
2570         (WebCore::ShadowData::next):
2571         (WebCore::ShadowData::setNext):
2572         * rendering/style/StyleRareInheritedData.cpp:
2573         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2574         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2575         * rendering/style/StyleRareInheritedData.h:
2576         * rendering/style/StyleRareNonInheritedData.cpp:
2577         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2578
2579 2011-04-26  David Levin  <levin@chromium.org>
2580
2581         Reviewed by Eric Seidel.
2582
2583         Fix some strict PassOwnPtr issues in WebCore.
2584         https://bugs.webkit.org/show_bug.cgi?id=59563
2585
2586         * css/SVGCSSStyleSelector.cpp:
2587         (WebCore::CSSStyleSelector::applySVGProperty):
2588         * html/canvas/WebGLRenderingContext.cpp:
2589         (WebCore::WebGLRenderingContext::create):
2590         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
2591         * platform/text/TextCodecLatin1.cpp:
2592         (WebCore::newStreamingTextDecoderWindowsLatin1):
2593         * platform/text/TextCodecUTF16.cpp:
2594         (WebCore::newStreamingTextDecoderUTF16LE):
2595         (WebCore::newStreamingTextDecoderUTF16BE):
2596         * platform/text/TextCodecUserDefined.cpp:
2597         (WebCore::newStreamingTextDecoderUserDefined):
2598         * platform/text/mac/TextCodecMac.cpp:
2599         (WebCore::newTextCodecMac):
2600         * workers/Worker.cpp:
2601         (WebCore::Worker::notifyFinished):
2602
2603 2011-04-26  Justin Novosad  <junov@chromium.org>
2604
2605         Reviewed by Kenneth Russell.
2606
2607         [Chromium] Expose skia gpu canvas rendering as a runtime flag
2608         https://bugs.webkit.org/show_bug.cgi?id=58683
2609         Replace the SKIA_GPU compile flag by the pre-existing
2610         acceleratedDrawingEnabled flag. Most code changes are trivial:
2611         compile-time conditionals on SKIA_GPU were either replaced with
2612         a run-time check, or a compile time check on USE(SKIA) 
2613
2614         No new tests. Covered by existing tests.
2615
2616         * html/canvas/CanvasRenderingContext2D.cpp:
2617         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2618         * page/Page.cpp:
2619         (WebCore::Page::sharedGraphicsContext3D):
2620         Added check for the acceleratedDrawing flag.
2621         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2622         (WebCore::DrawingBuffer::DrawingBuffer):
2623         (WebCore::DrawingBuffer::publishToPlatformLayer):
2624         * platform/graphics/gpu/DrawingBuffer.h:
2625         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2626         (WebCore::SharedGraphicsContext3D::create):
2627         On Skia builds, this methos now receives a bool arg to turn on
2628         GPU-accelerated skia rendering
2629         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
2630         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2631         (WebCore::SharedGraphicsContext3D::grContext):
2632         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2633         * platform/graphics/skia/ImageSkia.cpp:
2634         (WebCore::computeResamplingMode):
2635         (WebCore::paintSkBitmap):
2636         (WebCore::Image::drawPattern):
2637         * platform/graphics/skia/PlatformContextSkia.cpp:
2638         (WebCore::PlatformContextSkia::PlatformContextSkia):
2639         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2640         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2641         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2642         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2643         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2644         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2645         (WebCore::PlatformContextSkia::markDirtyRect):
2646         * platform/graphics/skia/PlatformContextSkia.h:
2647         (WebCore::PlatformContextSkia::accelerationMode):
2648         (WebCore::PlatformContextSkia::useGPU):
2649         (WebCore::PlatformContextSkia::useSkiaGPU):
2650
2651 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2652
2653         Not reviewed: restore inspector test disabled in r84913.
2654
2655         Test: http/tests/inspector-enabled/dom-storage-open.html
2656
2657         * inspector/InspectorDOMStorageAgent.cpp:
2658         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2659
2660 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2661
2662         Reviewed by Tony Chang.
2663
2664         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2665         https://bugs.webkit.org/show_bug.cgi?id=59182
2666
2667         Use vertical offsets of the shaping results.
2668
2669         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2670
2671         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2672         (WebCore::ComplexTextController::ComplexTextController):
2673         Added initialization of m_startingY.
2674         (WebCore::ComplexTextController::nextScriptRun):
2675         Followed the change in handling positions.
2676         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2677         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2678         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2679         (WebCore::ComplexTextController::setGlyphPositions):
2680         Changed to use vertical offsets as same as horizontal offsets.
2681         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2682         Removed m_xPositions and Added m_positions and m_startingY.
2683         (WebCore::ComplexTextController::positions): Added.
2684         * platform/graphics/chromium/FontLinux.cpp:
2685         Followed the change in ComplexTextController.
2686         (WebCore::Font::drawComplexText): Ditto.
2687         (WebCore::Font::floatWidthForComplexText): Ditto.
2688         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2689         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2690         (WebCore::Font::selectionRectForComplexText): Ditto.
2691
2692 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2693
2694         Reviewed by Eric Seidel.
2695
2696         Root element should establish a new block formatting context
2697         https://bugs.webkit.org/show_bug.cgi?id=54573
2698
2699         Always expanding the root renderer to include overhanging floats.
2700
2701         Test: fast/block/float/float-overhangs-root.html
2702
2703         * rendering/RenderBlock.cpp:
2704         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2705
2706 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2707
2708         Reviewed by Andreas Kling.
2709
2710         [Qt] Improper rendering of <button> tag when it contains a <br>
2711         https://bugs.webkit.org/show_bug.cgi?id=50521
2712
2713         Test: platform/qt/fast/forms/button-line-break.html
2714
2715         * platform/qt/RenderThemeQt.cpp:
2716         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2717         (WebCore::RenderThemeQt::setButtonPadding):
2718
2719 2011-04-26  James Robinson  <jamesr@chromium.org>
2720
2721         Reviewed by Kenneth Russell.
2722
2723         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2724         https://bugs.webkit.org/show_bug.cgi?id=59572
2725
2726         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2727         when LayerRendererChromium was set.  We set this pointer every frame
2728         and should only reset the tiles if the new LayerRendererChromium is
2729         different from the old one (indicating a context loss), not just reset
2730         on every frame.
2731
2732         * platform/graphics/chromium/LayerTilerChromium.cpp:
2733         (WebCore::LayerTilerChromium::setLayerRenderer):
2734         * platform/graphics/chromium/LayerTilerChromium.h:
2735
2736 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2737
2738         Reviewed by Eric Seidel.
2739
2740         beginElement broken by setAttribute
2741         https://bugs.webkit.org/show_bug.cgi?id=26019
2742
2743         Test: svg/animations/animate-beginElementAt.svg
2744
2745         * svg/SVGAnimationElement.cpp:
2746         (WebCore::SVGAnimationElement::attributeChanged):
2747         Reset the animation state here as the rest of the code reads it and would still
2748         think we are animating when we are not.
2749
2750         * svg/animation/SVGSMILElement.h:
2751         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2752
2753 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2754
2755         Unreviewed, rolling out r84989.
2756         http://trac.webkit.org/changeset/84989
2757         https://bugs.webkit.org/show_bug.cgi?id=59566
2758
2759         REGRESSION (r84989): Lots of vertical text tests failing on
2760         windows (Requested by weinig on #webkit).
2761
2762         * platform/graphics/FontPlatformData.h:
2763         * platform/graphics/win/FontCacheWin.cpp:
2764         (WebCore::FontCache::getFontDataForCharacters):
2765         (WebCore::FontCache::createFontPlatformData):
2766         * platform/graphics/win/FontCustomPlatformData.cpp:
2767         (WebCore::FontCustomPlatformData::fontPlatformData):
2768         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2769         (WebCore::FontPlatformData::FontPlatformData):
2770         * platform/graphics/win/FontPlatformDataWin.cpp:
2771         (WebCore::FontPlatformData::FontPlatformData):
2772
2773 2011-04-26  Sam Weinig  <sam@webkit.org>
2774
2775         Reviewed by Eric Seidel.
2776
2777         Try again:
2778             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2779             https://bugs.webkit.org/show_bug.cgi?id=59310
2780
2781         * bindings/js/JSDOMBinding.h:
2782         (WebCore::DOMConstructorObject::DOMConstructorObject):
2783         * bindings/js/JSDOMWrapper.h:
2784         (WebCore::JSDOMWrapper::globalObject):
2785         (WebCore::JSDOMWrapper::scriptExecutionContext):
2786         (WebCore::JSDOMWrapper::createStructure):
2787         (WebCore::JSDOMWrapper::JSDOMWrapper):
2788         * bindings/scripts/CodeGeneratorJS.pm:
2789
2790 2011-04-26  Sam Weinig  <sam@webkit.org>
2791
2792         Reviewed by David Hyatt.
2793
2794         Remove Datagrid from the tree
2795         https://bugs.webkit.org/show_bug.cgi?id=59543
2796
2797         * Android.derived.jscbindings.mk:
2798         * Android.derived.v8bindings.mk:
2799         * Android.jscbindings.mk:
2800         * Android.v8bindings.mk:
2801         * CMakeLists.txt:
2802         * CodeGenerators.pri:
2803         * Configurations/FeatureDefines.xcconfig:
2804         * DerivedSources.cpp:
2805         * DerivedSources.make:
2806         * GNUmakefile.am:
2807         * GNUmakefile.list.am:
2808         * UseJSC.cmake:
2809         * WebCore.gypi:
2810         * WebCore.pro:
2811         * WebCore.vcproj/WebCore.vcproj:
2812         * WebCore.xcodeproj/project.pbxproj:
2813         * bindings/js/JSBindingsAllInOne.cpp:
2814         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2815         * bindings/js/JSDataGridDataSource.cpp: Removed.
2816         * bindings/js/JSDataGridDataSource.h: Removed.
2817         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2818         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2819         * bindings/v8/V8DataGridDataSource.h: Removed.
2820         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2821         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2822         * css/CSSStyleSelector.cpp:
2823         * css/CSSStyleSelector.h:
2824         * css/html.css:
2825         (input, textarea, keygen, select, button, isindex):
2826         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2827         * editing/htmlediting.cpp:
2828         (WebCore::canHaveChildrenForEditing):
2829         * features.pri:
2830         * html/DOMDataGridDataSource.cpp: Removed.
2831         * html/DOMDataGridDataSource.h: Removed.
2832         * html/DataGridColumn.cpp: Removed.
2833         * html/DataGridColumn.h: Removed.
2834         * html/DataGridColumn.idl: Removed.
2835         * html/DataGridColumnList.cpp: Removed.
2836         * html/DataGridColumnList.h: Removed.
2837         * html/DataGridColumnList.idl: Removed.
2838         * html/DataGridDataSource.h: Removed.
2839         * html/HTMLDataGridCellElement.cpp: Removed.
2840         * html/HTMLDataGridCellElement.h: Removed.
2841         * html/HTMLDataGridCellElement.idl: Removed.
2842         * html/HTMLDataGridColElement.cpp: Removed.
2843         * html/HTMLDataGridColElement.h: Removed.
2844         * html/HTMLDataGridColElement.idl: Removed.
2845         * html/HTMLDataGridElement.cpp: Removed.
2846         * html/HTMLDataGridElement.h: Removed.
2847         * html/HTMLDataGridElement.idl: Removed.
2848         * html/HTMLDataGridRowElement.cpp: Removed.
2849         * html/HTMLDataGridRowElement.h: Removed.
2850         * html/HTMLDataGridRowElement.idl: Removed.
2851         * html/HTMLElement.cpp:
2852         (WebCore::HTMLElement::ieForbidsInsertHTML):
2853         * html/HTMLElementsAllInOne.cpp:
2854         * html/HTMLTagNames.in:
2855         * page/DOMWindow.idl:
2856         * rendering/RenderBox.cpp:
2857         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2858         * rendering/RenderDataGrid.cpp: Removed.
2859         * rendering/RenderDataGrid.h: Removed.
2860         * rendering/RenderingAllInOne.cpp:
2861
2862 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2863
2864         Reviewed by Adele Peterson.
2865
2866         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2867         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2868
2869         This platform dependent patch makes WebKit (Windows) show the
2870         vertical writing text correctly.  Job was done by adding a prefix '@'
2871         in front of the font family name (Windows Only). No new tests added.
2872         Some layout tests images:
2873         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2874
2875         * platform/graphics/FontPlatformData.h:
2876         * platform/graphics/win/FontCacheWin.cpp:
2877         (WebCore::FontCache::getFontDataForCharacters):
2878         (WebCore::FontCache::createFontPlatformData):
2879         * platform/graphics/win/FontCustomPlatformData.cpp:
2880         (WebCore::FontCustomPlatformData::fontPlatformData):
2881         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2882         (WebCore::FontPlatformData::FontPlatformData):
2883         * platform/graphics/win/FontPlatformDataWin.cpp:
2884         (WebCore::FontPlatformData::FontPlatformData):
2885
2886 2011-04-26  Jer Noble  <jer.noble@apple.com>
2887
2888         Reviewed by Brady Eidson.
2889
2890         HTML5 video fullscreen transition causes an audio stutter
2891         https://bugs.webkit.org/show_bug.cgi?id=59544
2892
2893         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2894         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2895         layer to render it invisible, instead just set the layer as hidden.
2896
2897         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2898         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2899         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2900         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2901         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2902         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2903
2904 2011-04-26  Christian Dywan  <christian@lanedo.com>
2905
2906         Reviewed by Eric Seidel.
2907
2908         Extra separator after Select All in context menu
2909         https://bugs.webkit.org/show_bug.cgi?id=54092
2910
2911         * page/ContextMenuController.cpp: Move separator to non-GTK+
2912             port guards since it is for the spelling options menu
2913             which the GTK+ port doesn't use.
2914
2915 2011-04-26  James Robinson  <jamesr@chromium.org>
2916
2917         Reviewed by Kenneth Russell.
2918
2919         [chromium] Clear out LayerTilerChromium's tiles on lost context
2920         https://bugs.webkit.org/show_bug.cgi?id=59233
2921
2922         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
2923         no longer valid since they exist in the previous LayerRendererChromium.
2924
2925         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
2926
2927         * platform/graphics/chromium/LayerTilerChromium.h:
2928         (WebCore::LayerTilerChromium::setLayerRenderer):
2929
2930 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2931
2932         Reviewed by Dirk Schulze.
2933
2934         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
2935         https://bugs.webkit.org/show_bug.cgi?id=57644
2936
2937         Manual test: plugins/windowed-in-iframe-2.html
2938
2939         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
2940         * platform/gtk/WidgetGtk.cpp:
2941         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
2942         * plugins/PluginView.h: Added helper method to set the allocation and clip.
2943         * plugins/gtk/PluginViewGtk.cpp:
2944         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
2945         the allocation immediately. Bring this method into sync with the implementation in
2946         the Qt port.
2947         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
2948         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
2949
2950 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2951
2952         Reviewed by Eric Seidel.
2953
2954         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
2955         https://bugs.webkit.org/show_bug.cgi?id=58818
2956
2957         Prevent allocating scratch buffers larger than the target GdkDrawable
2958         when creating a WidgetRenderingContext. This prevents incredibly large
2959         widgets from crashing the X Server. This change also allowed greatly
2960         simplifying the way that the painting offset is calculated.
2961
2962         * platform/gtk/WidgetRenderingContext.cpp:
2963         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
2964         larger than the target GdkDrawable.
2965         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
2966         blit by looking at the location of the target rect itself, rather than delaying the
2967         calculation up to this point.
2968         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
2969         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
2970         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
2971         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
2972         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
2973         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
2974         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
2975         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
2976         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
2977         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
2978         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
2979         a member to store the IntSize mapping from the coordinates of the target to the coordinates
2980         of the scratch buffer.
2981
2982 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
2983
2984         Reviewed by Adam Barth.
2985
2986         Respect charset in handleDataURL
2987         https://bugs.webkit.org/show_bug.cgi?id=47746
2988
2989         Original patch by Kwang Yul Seo <skyul@company100.net>
2990
2991         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2992         returns an empty string because encoding name is not specified.
2993
2994         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2995
2996         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2997
2998         * platform/network/DataURL.cpp:
2999         (WebCore::handleDataURL):
3000
3001 2011-04-26  Anders Carlsson  <andersca@apple.com>
3002
3003         Fix clang++ build.
3004
3005         You can never have too many casts!
3006
3007         * accessibility/mac/AccessibilityObjectWrapper.mm:
3008         (-[AccessibilityObjectWrapper position]):
3009         * editing/mac/SelectionControllerMac.mm:
3010         (WebCore::accessibilityConvertScreenRect):
3011
3012 2011-04-26  Chris Rogers  <crogers@google.com>
3013
3014         Reviewed by Kenneth Russell.
3015
3016         Fix web audio build on mac port
3017         https://bugs.webkit.org/show_bug.cgi?id=59355
3018
3019         No new tests since audio API is not yet implemented.
3020
3021         * WebCore.xcodeproj/project.pbxproj:
3022         * bindings/js/JSAudioContextCustom.cpp:
3023         (WebCore::JSAudioContext::visitChildren):
3024         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
3025         (WebCore::JSJavaScriptAudioNode::visitChildren):
3026         * webaudio/AudioContext.idl:
3027
3028 2011-04-26  Chris Rogers  <crogers@google.com>
3029
3030         Reviewed by Kenneth Russell.
3031
3032         Add FFTFrame implementation for FFmpeg
3033         https://bugs.webkit.org/show_bug.cgi?id=59408
3034
3035         No new tests since audio API is not yet implemented.
3036
3037         * WebCore.gyp/WebCore.gyp:
3038         * WebCore.gypi:
3039         * platform/audio/FFTFrame.h:
3040         * platform/audio/FFTFrameStub.cpp:
3041         * platform/audio/ffmpeg: Added.
3042         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
3043         (WebCore::FFTFrame::FFTFrame):
3044         (WebCore::FFTFrame::initialize):
3045         (WebCore::FFTFrame::cleanup):
3046         (WebCore::FFTFrame::~FFTFrame):
3047         (WebCore::FFTFrame::multiply):
3048         (WebCore::FFTFrame::doFFT):
3049         (WebCore::FFTFrame::doInverseFFT):
3050         (WebCore::FFTFrame::realData):
3051         (WebCore::FFTFrame::imagData):
3052         (WebCore::FFTFrame::getUpToDateComplexData):
3053         (WebCore::FFTFrame::contextForSize):
3054         * platform/audio/mac/FFTFrameMac.cpp:
3055         * webaudio/ConvolverNode.cpp:
3056
3057 2011-04-26  Jeff Miller  <jeffm@apple.com>
3058
3059         Add a newline at the end of SVGFEDropShadowElement.idl.
3060
3061         * svg/SVGFEDropShadowElement.idl:
3062
3063 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
3064
3065         Reviewed by Eric Seidel.
3066
3067         InlineBox.h shouldn't include RenderBR.h
3068         https://bugs.webkit.org/show_bug.cgi?id=59480
3069
3070         Per bug 59348 RenderBR.h is a "top header" by include * size, because
3071         InlineBox.h includes it. There's no reason why it has to.
3072
3073         * rendering/InlineBox.h:
3074         * rendering/InlineTextBox.cpp:
3075         * rendering/RenderBlock.h:
3076
3077 2011-04-26  Sam Weinig  <sam@webkit.org>
3078
3079         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
3080         I should do.
3081
3082         * bindings/js/JSDOMBinding.h:
3083         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3084         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3085         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3086         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3087         (WebCore::DOMConstructorObject::DOMConstructorObject):
3088         * bindings/js/JSDOMWrapper.h:
3089         (WebCore::JSDOMWrapper::JSDOMWrapper):
3090         * bindings/scripts/CodeGeneratorJS.pm:
3091
3092 2011-04-26  Sam Weinig  <sam@webkit.org>
3093
3094         Fix build.
3095
3096         * bindings/js/JSDOMWrapper.h:
3097         (WebCore::JSDOMWrapper::globalObject):
3098
3099 2011-04-26  Sam Weinig  <sam@webkit.org>
3100
3101         Roll r84945 back in with infinite recursion removed.
3102
3103         * bindings/js/JSDOMBinding.h:
3104         (WebCore::DOMConstructorObject::DOMConstructorObject):
3105         * bindings/js/JSDOMWrapper.h:
3106         (WebCore::JSDOMWrapper::globalObject):
3107         (WebCore::JSDOMWrapper::scriptExecutionContext):
3108         (WebCore::JSDOMWrapper::createStructure):
3109         (WebCore::JSDOMWrapper::JSDOMWrapper):
3110         * bindings/scripts/CodeGeneratorJS.pm:
3111
3112 2011-04-26  Sam Weinig  <sam@webkit.org>
3113
3114         Rollout previous patch. It broke stuff.
3115
3116         * bindings/js/JSDOMBinding.h:
3117         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3118         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3119         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3120         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3121         (WebCore::DOMConstructorObject::DOMConstructorObject):
3122         * bindings/js/JSDOMWrapper.h:
3123         (WebCore::JSDOMWrapper::JSDOMWrapper):
3124         * bindings/scripts/CodeGeneratorJS.pm:
3125
3126 2011-04-26  Sam Weinig  <sam@webkit.org>
3127
3128         Reviewed by Maciej Stachowiak.
3129
3130         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
3131         https://bugs.webkit.org/show_bug.cgi?id=59310
3132
3133         * bindings/js/JSDOMBinding.h:
3134         (WebCore::DOMConstructorObject::DOMConstructorObject):
3135         * bindings/js/JSDOMWrapper.h:
3136         (WebCore::JSDOMWrapper::globalObject):
3137         (WebCore::JSDOMWrapper::scriptExecutionContext):
3138         (WebCore::JSDOMWrapper::createStructure):
3139         (WebCore::JSDOMWrapper::JSDOMWrapper):
3140         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
3141
3142         * bindings/scripts/CodeGeneratorJS.pm:
3143         Make JSDOMWrapper the base class.
3144
3145 2011-04-26  Dan Bernstein  <mitz@apple.com>
3146
3147         Reviewed by Mark Rowe.
3148
3149         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
3150
3151         * Configurations/Base.xcconfig:
3152         * Configurations/CompilerVersion.xcconfig: Added.
3153
3154 2011-04-26  Adrienne Walker  <enne@google.com>
3155
3156         Reviewed by Geoffrey Garen.
3157
3158         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
3159         https://bugs.webkit.org/show_bug.cgi?id=59469
3160
3161         * platform/chromium/TraceEvent.h:
3162         (WebCore::internal::ScopeTracer::ScopeTracer):
3163
3164 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3165
3166         Reviewed by Oliver Hunt.
3167
3168         Nixed special finalizer handling for WebCore strings
3169         https://bugs.webkit.org/show_bug.cgi?id=59425
3170
3171         Not needed anymore, since weak handles have finalizers.
3172
3173         * WebCore.exp.in: Exports!
3174
3175         * bindings/js/DOMWrapperWorld.cpp:
3176         (WebCore::JSStringOwner::finalize):
3177         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
3178         so we don't need special treatment anymore.
3179
3180         * bindings/js/DOMWrapperWorld.h:
3181         (WebCore::JSStringOwner::JSStringOwner):
3182         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
3183         instead of a WeakGCMap, so we can specify a custom finalizer.
3184
3185         * bindings/js/JSDOMBinding.cpp:
3186         (WebCore::jsStringSlowCase):
3187         * bindings/js/JSDOMBinding.h:
3188         (WebCore::jsString): Updated for string map change.
3189
3190 2011-04-26  David Kilzer  <ddkilzer@apple.com>
3191
3192         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
3193
3194         Reviewed by Antti Koivisto.
3195
3196         To enable HTTP pipelining post-SnowLeopard, use this command:
3197
3198             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
3199
3200         * platform/network/cf/ResourceRequestCFNet.cpp:
3201         (WebCore::readBooleanPreference): Re-added.  Originally added in
3202         r76756 and removed in r84120.
3203         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
3204         HTTP pipelining if use default is set to true.  Added macro
3205         guards to match those in ResourceRequestMac.mm.
3206
3207 2011-04-26  Antti Koivisto  <antti@apple.com>
3208
3209         Reviewed by Adele Peterson.
3210
3211         Don't strip fragments from file: urls in memory cache
3212         https://bugs.webkit.org/show_bug.cgi?id=59463
3213         <rdar://problem/9231130>
3214
3215         Some clients expect file: resources to be unique based on fragment identifier. 
3216         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
3217
3218         Test: fast/loader/file-protocol-fragment.html
3219
3220         * loader/cache/MemoryCache.cpp:
3221         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
3222
3223 2011-04-26  David Levin  <levin@chromium.org>
3224
3225         Reviewed by Darin Adler.
3226
3227         Fix more strict OwnPtr in WebCore (round N).
3228         https://bugs.webkit.org/show_bug.cgi?id=59464
3229
3230         * dom/Document.cpp:
3231         (WebCore::Document::Document):
3232         (WebCore::Document::attach):
3233         * fileapi/FileReader.cpp:
3234         (WebCore::FileReader::terminate):
3235         * loader/DocumentThreadableLoader.cpp:
3236         (WebCore::DocumentThreadableLoader::preflightFailure):
3237         * workers/DefaultSharedWorkerRepository.cpp:
3238         (WebCore::SharedWorkerConnectTask::create):
3239         (WebCore::SharedWorkerScriptLoader::load):
3240
3241 2011-04-26  Ruben  <chromium@hybridsource.org>
3242
3243         Reviewed by Tony Chang.
3244
3245         Change linux ifdefs for Chromium to Unix instead, allowing
3246         new Unix ports to be enabled by default
3247         https://bugs.webkit.org/show_bug.cgi?id=59297
3248
3249         No new tests, just changing preprocessor defines.
3250
3251         * bindings/js/JSInspectorFrontendHostCustom.cpp:
3252         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
3253         * dom/SelectElement.cpp:
3254         * loader/cache/CachedFont.cpp:
3255         * page/EventHandler.cpp:
3256         * page/chromium/EventHandlerChromium.cpp:
3257         * platform/Scrollbar.cpp:
3258         * platform/chromium/PlatformBridge.h:
3259         * platform/graphics/chromium/FontPlatformData.h:
3260         * platform/graphics/skia/FontCustomPlatformData.cpp:
3261         * platform/graphics/skia/FontCustomPlatformData.h:
3262
3263 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3264
3265         Reviewed by Dan Bernstein.
3266
3267         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
3268         https://bugs.webkit.org/show_bug.cgi?id=49111
3269
3270         Even when the offset corresponds to a position visually left of the box
3271         and there aren't any inline boxes on the left, the previous/next position
3272         may still correspond to some position in the same line.
3273
3274         The bug was caused by our ignoring such cases. Fixed the bug by comparing
3275         previous/next position's inline box to the current box. If they match,
3276         then we stay on the same position because moving to the left visually at
3277         the left edge should not result in a position on the same line.
3278
3279         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
3280         the left edge or to the right edge, and a bug that WebKit could not move to
3281         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
3282
3283         Test cases are added to editing/selection/move-left-right.html
3284
3285         * editing/VisiblePosition.cpp:
3286         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
3287         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
3288
3289 2011-04-26  Gabor Loki  <loki@webkit.org>
3290
3291         Reviewed by Csaba Osztrogonác.
3292
3293         Speeding up SVG filters with multicore (SMP) support
3294         https://bugs.webkit.org/show_bug.cgi?id=43903
3295
3296         Some SVG filters execute a huge number of pixel manipulations, which
3297         cannot be sped up by graphics accelerators, since their algorithm is
3298         too complex. Using the power of Symmetric Multi Processing (SMP) we
3299         can split up a task to smaller (data independent) tasks, which can be
3300         executed independently.
3301
3302         The ParallelJobs framework provides a simple way for distributed
3303         programming. The framework is based on WebKit's threading infrastructure,
3304         Open Multi-Processing's (OpenMP) API, and libdispatch API.
3305
3306         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
3307         * platform/graphics/filters/FETurbulence.cpp:
3308         (WebCore::FETurbulence::PaintingData::PaintingData):
3309         (WebCore::FETurbulence::noise2D):
3310         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
3311         (WebCore::FETurbulence::fillRegion):
3312         (WebCore::FETurbulence::fillRegionWorker):
3313         (WebCore::FETurbulence::apply):
3314         * platform/graphics/filters/FETurbulence.h:
3315
3316 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3317
3318         Reviewed by Yury Semikhatsky.
3319
3320         Web Inspector: close button is off in docked mode on a mac.
3321         https://bugs.webkit.org/show_bug.cgi?id=59453
3322
3323         * inspector/front-end/inspector.css:
3324         (.toolbar-item.close-left):
3325
3326 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3327
3328         Reviewed by Yury Semikhatsky.
3329
3330         Web Inspector: New Style is not working (UI glitch)
3331         https://bugs.webkit.org/show_bug.cgi?id=59451
3332
3333         * inspector/InspectorDOMStorageAgent.cpp:
3334         (WebCore::InspectorDOMStorageAgent::setFrontend):
3335         * inspector/front-end/AuditRules.js:
3336         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
3337         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
3338         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
3339         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
3340         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
3341         * inspector/front-end/CSSStyleModel.js:
3342         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
3343         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
3344         (WebInspector.CSSStyleModel.prototype.addRule):
3345         (WebInspector.CSSStyleModel.prototype.addRule.callback):
3346         (WebInspector.CSSStyleModel.prototype._documentElementId):
3347         * inspector/front-end/DOMAgent.js:
3348         (WebInspector.DOMNode.prototype._addAttribute):
3349         (WebInspector.DOMNode.prototype.documentElement):
3350         * inspector/front-end/ResourceTreeModel.js:
3351         (WebInspector.PageDispatcher.prototype.frameDetached):
3352         * inspector/front-end/StylesSidebarPane.js:
3353         (WebInspector.StylesSidebarPane.prototype._createNewRule):
3354
3355 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3356
3357         Reviewed by Yury Semikhatsky.
3358
3359         Web Inspector: introduce DOMStorage::enable and disable.
3360         https://bugs.webkit.org/show_bug.cgi?id=59445
3361
3362         * inspector/Inspector.json:
3363         * inspector/InspectorAgent.cpp:
3364         (WebCore::InspectorAgent::InspectorAgent):
3365         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3366         * inspector/InspectorDOMStorageAgent.cpp:
3367         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
3368         (WebCore::InspectorDOMStorageAgent::restore):
3369         (WebCore::InspectorDOMStorageAgent::enable):
3370         (WebCore::InspectorDOMStorageAgent::disable):
3371         * inspector/InspectorDOMStorageAgent.h:
3372         (WebCore::InspectorDOMStorageAgent::create):
3373         * inspector/front-end/DOMStorage.js:
3374         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3375         * inspector/front-end/ResourcesPanel.js:
3376         (WebInspector.ResourcesPanel.prototype._reset):
3377         * inspector/front-end/inspector.js:
3378
3379 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3380
3381         Reviewed by Yury Semikhatsky.
3382
3383         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
3384         https://bugs.webkit.org/show_bug.cgi?id=59440
3385
3386         * inspector/Inspector.json:
3387         * inspector/InspectorAgent.cpp:
3388         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3389         * inspector/InspectorPageAgent.cpp:
3390         (WebCore::InspectorPageAgent::setFrontend):
3391         (WebCore::InspectorPageAgent::frameNavigated):
3392         * inspector/InspectorPageAgent.h:
3393         * inspector/front-end/AuditsPanel.js:
3394         (WebInspector.AuditsPanel):
3395         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
3396         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
3397         * inspector/front-end/CSSStyleModel.js:
3398         (WebInspector.CSSStyleModelResourceBinding):
3399         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
3400         * inspector/front-end/DOMBreakpointsSidebarPane.js:
3401         (WebInspector.DOMBreakpointsSidebarPane):
3402         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
3403         * inspector/front-end/DOMStorage.js:
3404         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3405         * inspector/front-end/ExtensionServer.js:
3406         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
3407         (WebInspector.ExtensionServer.prototype.initExtensions):
3408         * inspector/front-end/NetworkPanel.js:
3409         (WebInspector.NetworkPanel):
3410         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
3411         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
3412         (WebInspector.NetworkPanel.prototype._frameNavigated):
3413         * inspector/front-end/ResourceTreeModel.js:
3414         (WebInspector.ResourceTreeModel):
3415         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
3416         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
3417         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
3418         (WebInspector.ResourceTreeModel.prototype._frameDetached):
3419         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
3420         (WebInspector.PageDispatcher):
3421         (WebInspector.PageDispatcher.prototype.domContentEventFired):
3422         (WebInspector.PageDispatcher.prototype.loadEventFired):
3423         (WebInspector.PageDispatcher.prototype.frameNavigated):
3424         (WebInspector.PageDispatcher.prototype.frameDetached):
3425         * inspector/front-end/ResourcesPanel.js:
3426         (WebInspector.ResourcesPanel):
3427         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
3428         (WebInspector.ResourcesPanel.prototype._frameNavigated):
3429         * inspector/front-end/inspector.js:
3430
3431 2011-04-26  Csaba Osztrogonác  <ossy@webkit.org>
3432
3433         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
3434         because it broke transitions/multiple-text-shadow-transition.html
3435
3436         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3437         https://bugs.webkit.org/show_bug.cgi?id=59377
3438
3439         * css/CSSStyleSelector.cpp:
3440         (WebCore::CSSStyleSelector::applyProperty):
3441         * page/animation/AnimationBase.cpp:
3442         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3443         (WebCore::PropertyWrapperShadow::blend):
3444         * rendering/style/RenderStyle.cpp:
3445         (WebCore::RenderStyle::setTextShadow):
3446         (WebCore::RenderStyle::setBoxShadow):
3447         * rendering/style/RenderStyle.h:
3448         (WebCore::InheritedFlags::textShadow):
3449         * rendering/style/StyleRareInheritedData.cpp:
3450         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3451         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3452         * rendering/style/StyleRareInheritedData.h:
3453         * rendering/style/StyleRareNonInheritedData.cpp:
3454         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3455
3456 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
3457
3458         Reviewed by Adam Barth.
3459
3460         Turn off make built-in implicit rules for derived sources makefile
3461         https://bugs.webkit.org/show_bug.cgi?id=59418
3462
3463         We don't use any of make's built-in implicit rules, turning them off
3464         speeds up parsing of the makefile.
3465
3466         * WebCore.xcodeproj/project.pbxproj:
3467         * gyp/generate-derived-sources.sh:
3468
3469 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
3470
3471         Reviewed by Nikolas Zimmermann.
3472
3473         ASSERT failure in SVGUseElement
3474         https://bugs.webkit.org/show_bug.cgi?id=59313
3475
3476         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3477         was wrong because the document may not be well-formed.
3478
3479         This patch asserts the element is not pending on resource or the
3480         document is not well-formed.
3481
3482         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3483
3484         * svg/SVGUseElement.cpp:
3485         (WebCore::isWellFormedDocument):
3486         (WebCore::SVGUseElement::insertedIntoDocument):
3487
3488 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
3489
3490         Reviewed by Pavel Feldman.
3491
3492         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
3493         https://bugs.webkit.org/show_bug.cgi?id=59438
3494
3495         * inspector/front-end/DetailedHeapshotView.js:
3496         (WebInspector.DetailedHeapshotView.prototype._changeView):
3497
3498 2011-04-26  David Levin  <levin@chromium.org>
3499
3500         Reviewed by Adam Barth.
3501
3502         Fix a few OwnPtr strict errors in WebCore headers.
3503         https://bugs.webkit.org/show_bug.cgi?id=59431
3504
3505         * bindings/js/ScheduledAction.cpp:
3506         (WebCore::ScheduledAction::create):
3507         * css/MediaQueryMatcher.cpp:
3508         (WebCore::MediaQueryMatcher::prepareEvaluator):
3509         * dom/NodeRareData.h:
3510         (WebCore::NodeListsNodeData::create):
3511         * dom/ScriptRunner.h:
3512         (WebCore::ScriptRunner::create):
3513         * inspector/WorkerInspectorController.cpp:
3514         (WebCore::WorkerInspectorController::connectFrontend):
3515         * loader/icon/IconDatabase.h:
3516         (WebCore::IconDatabase::create):
3517         * platform/graphics/SimpleFontData.cpp:
3518         (WebCore::SimpleFontData::verticalRightOrientationFontData):
3519         (WebCore::SimpleFontData::uprightOrientationFontData):
3520         (WebCore::SimpleFontData::brokenIdeographFontData):
3521         * rendering/style/StyleRareInheritedData.cpp:
3522         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3523         * rendering/svg/SVGResources.h:
3524         (WebCore::SVGResources::ClipperFilterMaskerData::create):
3525         (WebCore::SVGResources::MarkerData::create):
3526         (WebCore::SVGResources::FillStrokeData::create):
3527         * storage/StorageSyncManager.cpp:
3528         (WebCore::StorageSyncManager::close):
3529         * workers/WorkerContext.cpp:
3530         (WebCore::CloseWorkerContextTask::create):
3531         * workers/WorkerMessagingProxy.cpp:
3532         (WebCore::MessageWorkerContextTask::create):
3533         (WebCore::MessageWorkerTask::create):
3534         (WebCore::WorkerExceptionTask::create):
3535         (WebCore::WorkerContextDestroyedTask::create):
3536         (WebCore::WorkerTerminateTask::create):
3537         (WebCore::WorkerThreadActivityReportTask::create):
3538         * workers/WorkerRunLoop.cpp:
3539         (WebCore::WorkerRunLoop::Task::create):
3540         * workers/WorkerThread.cpp:
3541         (WebCore::WorkerThreadStartupData::create):
3542         (WebCore::WorkerThreadShutdownFinishTask::create):
3543         (WebCore::WorkerThreadShutdownStartTask::create):
3544
3545 2011-04-26  Adam Klein  <adamk@chromium.org>
3546
3547         Reviewed by Adam Barth.
3548
3549         Fix last strict OwnPtr violation under svg/...
3550         https://bugs.webkit.org/show_bug.cgi?id=59429
3551
3552         * svg/SVGDocumentExtensions.cpp:
3553         (WebCore::SVGDocumentExtensions::removePendingResource):
3554
3555 2011-04-26  Adam Barth  <abarth@webkit.org>
3556
3557         Reviewed by David Levin.
3558
3559         Fix more strict OwnPtr violations in WebCore
3560         https://bugs.webkit.org/show_bug.cgi?id=59433
3561
3562         These manifest in the Chromium build.
3563
3564         * bindings/v8/ScriptController.cpp:
3565         (WebCore::ScriptController::ScriptController):
3566         * bindings/v8/ScriptDebugServer.cpp:
3567         (WebCore::ScriptDebugServer::editScriptSource):
3568         * bindings/v8/V8DOMMap.cpp:
3569         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
3570         * bindings/v8/V8Proxy.cpp:
3571         (WebCore::V8Proxy::precompileScript):
3572         * bindings/v8/WorkerScriptController.cpp:
3573         (WebCore::WorkerScriptController::WorkerScriptController):
3574         * page/Page.cpp:
3575         (WebCore::Page::Page):
3576         (WebCore::Page::speechInput):
3577         * platform/PlatformGestureRecognizer.cpp:
3578         (WebCore::PlatformGestureRecognizer::create):
3579         * platform/PlatformGestureRecognizer.h:
3580         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3581         (WebCore::DrawingBuffer::DrawingBuffer):
3582         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3583         (WebCore::CCLayerImpl::CCLayerImpl):
3584         * platform/graphics/gpu/Texture.cpp:
3585         (WebCore::Texture::create):
3586         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
3587         (WebCore::BMPImageDecoder::decodeHelper):
3588         * platform/image-decoders/gif/GIFImageDecoder.cpp:
3589         (WebCore::GIFImageDecoder::decode):
3590         * platform/image-decoders/ico/ICOImageDecoder.cpp:
3591         (WebCore::ICOImageDecoder::decodeAtIndex):
3592         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3593         (WebCore::JPEGImageDecoder::decode):
3594         * platform/image-decoders/png/PNGImageDecoder.cpp:
3595         (WebCore::PNGImageDecoder::decode):
3596         * storage/chromium/DatabaseTrackerChromium.cpp:
3597         (WebCore::DatabaseTracker::addOpenDatabase):
3598
3599 2011-04-25  David Levin  <levin@chromium.org>
3600
3601         Reviewed by Adam Barth.
3602
3603         Fix OwnPtr strict errors in CrossThreadTask.h
3604         https://bugs.webkit.org/show_bug.cgi?id=59427
3605
3606         * dom/CrossThreadTask.h:
3607         (WebCore::CrossThreadTask1::create):
3608         (WebCore::CrossThreadTask2::create):
3609         (WebCore::CrossThreadTask3::create):
3610         (WebCore::CrossThreadTask4::create):
3611         (WebCore::CrossThreadTask5::create):
3612         (WebCore::CrossThreadTask6::create):
3613         (WebCore::CrossThreadTask7::create):
3614         (WebCore::CrossThreadTask8::create):
3615
3616 2011-04-25  Mark Rowe  <mrowe@apple.com>
3617
3618         Reviewed by Dan Bernstein.
3619
3620         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
3621
3622         * css/CSSStyleApplyProperty.cpp:
3623         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
3624         * css/CSSStyleApplyProperty.h:
3625         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
3626
3627 2011-04-25  Levi Weintraub  <leviw@chromium.org>
3628
3629         Reviewed by Ryosuke Niwa.
3630
3631         REGRESSION: a character appears after tab span when typing immediately before the tab span
3632         https://bugs.webkit.org/show_bug.cgi?id=58132
3633
3634         Correcting the order of operations we use to avoid inserting into invalid positions in
3635         ReplaceSelectionCommand to avoid inserting into tab-spans.
3636
3637         Test: editing/pasteboard/paste-before-tab-span.html
3638
3639         * editing/ReplaceSelectionCommand.cpp:
3640         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
3641         positionAvoidingPrecedingNodes, since that function could once again put our position
3642         inside a tab span.
3643
3644 2011-04-25  David Levin  <levin@chromium.org>
3645
3646         Reviewed by Adam Barth.
3647
3648         Fix OwnPtr strict error in ImageBuffer.h
3649         https://bugs.webkit.org/show_bug.cgi?id=59422
3650
3651         * platform/graphics/ImageBuffer.h:
3652         (WebCore::ImageBuffer::create):
3653
3654 2011-04-25  Adam Barth  <abarth@webkit.org>
3655
3656         Reviewed by David Levin.
3657
3658         Fix strict OwnPtr violations and whitelist known-tricky files
3659         https://bugs.webkit.org/show_bug.cgi?id=59421
3660
3661         With this patch, WebCore builds cleanly with strict OwnPtrs.
3662
3663         * dom/MessagePort.cpp:
3664         (WebCore::MessagePort::MessagePort):
3665         * dom/XMLDocumentParserLibxml2.cpp:
3666         * page/ContextMenuController.cpp:
3667         (WebCore::ContextMenuController::ContextMenuController):
3668         (WebCore::ContextMenuController::clearContextMenu):
3669         * page/PluginHalter.cpp:
3670         * platform/graphics/MediaPlayer.cpp:
3671         * platform/network/ResourceRequestBase.cpp:
3672         (WebCore::ResourceRequestBase::adopt):
3673         (WebCore::ResourceRequestBase::copyData):
3674         * svg/SVGDocumentExtensions.cpp:
3675
3676 2011-04-25  David Levin  <levin@chromium.org>
3677
3678         Reviewed by Adam Barth.
3679
3680         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
3681         https://bugs.webkit.org/show_bug.cgi?id=59419
3682
3683         * dom/DatasetDOMStringMap.h:
3684         (WebCore::DatasetDOMStringMap::create):
3685
3686 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3687
3688         Reviewed by Eric Seidel.
3689
3690         KeyboardEvent.cpp should work with strict OwnPtrs.
3691         https://bugs.webkit.org/show_bug.cgi?id=59403
3692
3693         * dom/KeyboardEvent.cpp:
3694         (WebCore::KeyboardEvent::KeyboardEvent):
3695
3696 2011-04-25  James Robinson  <jamesr@chromium.org>
3697
3698         Reviewed by Eric Seidel.
3699
3700         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3701         https://bugs.webkit.org/show_bug.cgi?id=59377
3702
3703         * css/CSSStyleSelector.cpp:
3704         (WebCore::CSSStyleSelector::applyProperty):
3705         * page/animation/AnimationBase.cpp:
3706         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3707         (WebCore::PropertyWrapperShadow::blend):
3708         * rendering/style/RenderStyle.cpp:
3709         (WebCore::RenderStyle::setTextShadow):
3710         (WebCore::RenderStyle::setBoxShadow):
3711         * rendering/style/RenderStyle.h:
3712         (WebCore::InheritedFlags::textShadow):
3713         * rendering/style/StyleRareInheritedData.cpp:
3714         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3715         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3716         * rendering/style/StyleRareInheritedData.h:
3717         * rendering/style/StyleRareNonInheritedData.cpp:
3718         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3719
3720 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3721
3722         Unreviewed, rolling out r84864.
3723         http://trac.webkit.org/changeset/84864
3724         https://bugs.webkit.org/show_bug.cgi?id=59413
3725
3726         Expect result of use-crash-in-non-wellformed-document.svg is
3727         platform dependent (Requested by leoyang on #webkit).
3728
3729         * svg/SVGUseElement.cpp:
3730         (WebCore::SVGUseElement::insertedIntoDocument):
3731
3732 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
3733
3734         Reviewed by Nikolas Zimmermann.
3735
3736         ASSERT failure in SVGUseElement
3737         https://bugs.webkit.org/show_bug.cgi?id=59313
3738
3739         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3740         was wrong because the document may not be well-formed.
3741
3742         This patch asserts the element is not pending on resource or the
3743         document is not well-formed.
3744
3745         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3746
3747         * svg/SVGUseElement.cpp:
3748         (WebCore::isWellFormedDocument):
3749         (WebCore::SVGUseElement::insertedIntoDocument):
3750
3751 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3752
3753         Reviewed by Tony Chang.
3754
3755         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3756         https://bugs.webkit.org/show_bug.cgi?id=59028
3757
3758         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3759         Moving the code for base class we can reduce the efforts to support DataTransferItems
3760         element in different platforms.
3761
3762         * Android.mk:
3763         * CMakeLists.txt:
3764         * GNUmakefile.list.am:
3765         * WebCore.gypi:
3766         * WebCore.pro:
3767         * WebCore.vcproj/WebCore.vcproj:
3768         * WebCore.xcodeproj/project.pbxproj:
3769         * dom/DataTransferItem.cpp:
3770         (WebCore::DataTransferItem::DataTransferItem):
3771         (WebCore::DataTransferItem::owner):
3772         (WebCore::DataTransferItem::kind):
3773         (WebCore::DataTransferItem::type):
3774         * dom/DataTransferItem.h:
3775         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3776         (WebCore::DataTransferItems::DataTransferItems):
3777         (WebCore::DataTransferItems::length):
3778         (WebCore::DataTransferItems::item):
3779         (WebCore::DataTransferItems::deleteItem):
3780         (WebCore::DataTransferItems::clear):
3781         (WebCore::DataTransferItems::add):
3782         * dom/DataTransferItems.h:
3783         * platform/chromium/DataTransferItemChromium.cpp:
3784         (WebCore::DataTransferItem::create):
3785         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3786         (WebCore::DataTransferItemChromium::getAsString):
3787         (WebCore::DataTransferItemChromium::getAsFile):
3788         * platform/chromium/DataTransferItemChromium.h:
3789         * platform/chromium/DataTransferItemsChromium.cpp:
3790         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3791         * platform/chromium/DataTransferItemsChromium.h:
3792
3793 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3794
3795         Reviewed by Simon Fraser.
3796
3797         REGRESSION(75137): directly composited images are double-drawn sometimes
3798         https://bugs.webkit.org/show_bug.cgi?id=58632
3799
3800         Depending on the order of operations (layout, creating compositing 
3801         layers and creating simple image layers) a layer can have both image
3802         content and have m_drawsContent=true. In this case 2 copies of the image
3803         are drawn in the layer. If the image has alpha, it looks wrong.
3804
3805         I added an updateDrawsContent() call after setting the image contents
3806         to make sure it's correct.
3807
3808         I couldn't create a test case that shows the problem because layerTreeAsText()
3809         doesn't emit enough info to show this level of detail. I've opened
3810         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3811
3812         * rendering/RenderLayerBacking.cpp:
3813         (WebCore::RenderLayerBacking::updateImageContents):
3814
3815 2011-04-25  Kenneth Russell  <kbr@google.com>
3816
3817         Reviewed by David Levin.
3818
3819         Fix OwnPtr strict errors in InlineFlowBox.cpp
3820         https://bugs.webkit.org/show_bug.cgi?id=59392
3821
3822         * rendering/InlineFlowBox.cpp:
3823         (WebCore::InlineFlowBox::setLayoutOverflow):
3824         (WebCore::InlineFlowBox::setVisualOverflow):
3825
3826 2011-04-25  Kenneth Russell  <kbr@google.com>
3827
3828         Reviewed by David Levin.
3829
3830         Fix OwnPtr strict errors in TransformState.cpp
3831         https://bugs.webkit.org/show_bug.cgi?id=59380
3832
3833         * rendering/TransformState.cpp:
3834         (WebCore::TransformState::applyTransform):
3835
3836 2011-04-25  Adam Barth  <abarth@webkit.org>
3837
3838         Reviewed by James Robinson.
3839
3840         DOMWindow.cpp should work with strict OwnPtrs
3841         https://bugs.webkit.org/show_bug.cgi?id=59356
3842
3843         * page/DOMWindow.cpp:
3844         (WebCore::PostMessageTimer::fired):
3845         (WebCore::DOMWindow::postMessageTimerFired):
3846         * page/DOMWindow.h:
3847
3848 2011-04-25  Adam Klein  <adamk@chromium.org>
3849
3850         Reviewed by James Robinson.
3851
3852         Fix OwnPtr strict errors in some SVG classes.
3853         https://bugs.webkit.org/show_bug.cgi?id=59395
3854
3855         * rendering/style/SVGRenderStyleDefs.cpp:
3856         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3857         * svg/SVGSVGElement.cpp:
3858         (WebCore::SVGSVGElement::SVGSVGElement):
3859         * svg/SVGStyledTransformableElement.cpp:
3860         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3861         * svg/SVGTextElement.cpp:
3862         (WebCore::SVGTextElement::supplementalTransform):
3863         * svg/graphics/SVGImage.cpp:
3864         (WebCore::SVGImage::dataChanged):
3865
3866 2011-04-25  Adam Barth  <abarth@webkit.org>
3867
3868         Re-land changes to ValidationMessage.
3869
3870         * html/ValidationMessage.cpp:
3871         (WebCore::ValidationMessage::setMessage):
3872         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3873         (WebCore::ValidationMessage::requestToHideMessage):
3874
3875 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3876
3877         Reviewed by James Robinson.
3878
3879         fix OwnPtr strict error in FrameView.cpp
3880         https://bugs.webkit.org/show_bug.cgi?id=59402
3881
3882         * page/FrameView.cpp:
3883         (WebCore::FrameView::FrameView):
3884         (WebCore::FrameView::addWidgetToUpdate):
3885
3886 2011-04-25  Adam Klein  <adamk@chromium.org>
3887
3888         Unreviewed, rolling out r84844.
3889         http://trac.webkit.org/changeset/84844
3890         https://bugs.webkit.org/show_bug.cgi?id=59395
3891
3892         Checked in too much.
3893
3894         * rendering/style/SVGRenderStyleDefs.cpp:
3895         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3896         * svg/SVGDocumentExtensions.cpp:
3897         (WebCore::SVGDocumentExtensions::removePendingResource):
3898         * svg/SVGSVGElement.cpp:
3899         (WebCore::SVGSVGElement::SVGSVGElement):
3900         * svg/SVGStyledTransformableElement.cpp:
3901         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3902         * svg/SVGTextElement.cpp:
3903         (WebCore::SVGTextElement::supplementalTransform):
3904         * svg/graphics/SVGImage.cpp:
3905         (WebCore::SVGImage::dataChanged):
3906
3907 2011-04-25  Adrienne Walker  <enne@google.com>
3908
3909         Reviewed by David Levin.
3910
3911         Make ActiveDOMCallback play nice with OwnPtr strict mode
3912         https://bugs.webkit.org/show_bug.cgi?id=59398
3913
3914         * bindings/generic/ActiveDOMCallback.cpp:
3915         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
3916
3917 2011-04-25  Adam Klein  <adamk@chromium.org>
3918
3919         Reviewed by James Robinson.
3920
3921         Fix OwnPtr strict errors in some SVG classes.
3922         https://bugs.webkit.org/show_bug.cgi?id=59395
3923
3924         * rendering/style/SVGRenderStyleDefs.cpp:
3925         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3926         * svg/SVGSVGElement.cpp:
3927         (WebCore::SVGSVGElement::SVGSVGElement):
3928         * svg/SVGStyledTransformableElement.cpp:
3929         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3930         * svg/SVGTextElement.cpp:
3931         (WebCore::SVGTextElement::supplementalTransform):
3932         * svg/graphics/SVGImage.cpp:
3933         (WebCore::SVGImage::dataChanged):
3934
3935 2011-04-25  James Robinson  <jamesr@chromium.org>
3936
3937         Unreviewed, rolling out r84835.
3938         http://trac.webkit.org/changeset/84835
3939         https://bugs.webkit.org/show_bug.cgi?id=59394
3940
3941         Breaks compile because Deque<OwnPtr> doesn't work
3942
3943         * dom/XMLDocumentParserLibxml2.cpp:
3944         (WebCore::PendingCallbacks::~PendingCallbacks):
3945         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3946         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3947         (WebCore::PendingCallbacks::appendCharactersCallback):
3948         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3949         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3950         (WebCore::PendingCallbacks::appendCommentCallback):
3951         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3952         (WebCore::PendingCallbacks::appendErrorCallback):
3953         (WebCore::XMLDocumentParser::XMLDocumentParser):
3954         * html/ValidationMessage.cpp:
3955         (WebCore::ValidationMessage::setMessage):
3956         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3957         (WebCore::ValidationMessage::requestToHideMessage):
3958
3959 2011-04-25  James Robinson  <jamesr@chromium.org>
3960
3961         Reviewed by Sam Weinig.
3962
3963         Fix OwnPtr strict mode violation in ImageBufferCG
3964         https://bugs.webkit.org/show_bug.cgi?id=59396
3965
3966         * platform/graphics/cg/ImageBufferCG.cpp:
3967         (WebCore::ImageBuffer::ImageBuffer):
3968
3969 2011-04-25  Huang Dongsung  <luxtella@company100.net>
3970
3971         Reviewed by Dirk Schulze.
3972
3973         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
3974         https://bugs.webkit.org/show_bug.cgi?id=59308
3975
3976         An unused local variable is created and even allocates heap memory.
3977
3978         * platform/graphics/skia/PlatformContextSkia.cpp:
3979         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
3980
3981 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3982
3983         Qt build fix: Updated files not used by other ports for rename.
3984
3985         * bindings/js/JSTouchCustom.cpp:
3986         (WebCore::toJSNewlyCreated):
3987         * bindings/js/JSTouchListCustom.cpp:
3988         (WebCore::toJSNewlyCreated):
3989
3990 2011-04-25  Adrienne Walker  <enne@google.com>
3991
3992         Reviewed by David Levin.
3993
3994         WebCore/css/CSS* files should play nice with strict OwnPtrs
3995         https://bugs.webkit.org/show_bug.cgi?id=59382
3996
3997         * css/CSSFontFaceSource.cpp:
3998         (WebCore::CSSFontFaceSource::getFontData):
3999         * css/CSSParser.cpp:
4000         (WebCore::CSSParser::addProperty):
4001         (WebCore::CSSParser::parseValue):
4002
4003 2011-04-25  Adam Barth  <abarth@webkit.org>
4004
4005         Reviewed by James Robinson.
4006
4007         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
4008         https://bugs.webkit.org/show_bug.cgi?id=59394
4009
4010         * dom/XMLDocumentParserLibxml2.cpp:
4011         (WebCore::PendingCallbacks::PendingCallbacks):
4012         (WebCore::PendingCallbacks::appendStartElementNSCallback):
4013         (WebCore::PendingCallbacks::appendEndElementNSCallback):
4014         (WebCore::PendingCallbacks::appendCharactersCallback):
4015         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
4016         (WebCore::PendingCallbacks::appendCDATABlockCallback):
4017         (WebCore::PendingCallbacks::appendCommentCallback):
4018         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
4019         (WebCore::PendingCallbacks::appendErrorCallback):
4020         (WebCore::XMLDocumentParser::XMLDocumentParser):
4021         * html/ValidationMessage.cpp:
4022         (WebCore::ValidationMessage::setMessage):
4023         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
4024         (WebCore::ValidationMessage::requestToHideMessage):
4025
4026 2011-04-25  James Robinson  <jamesr@chromium.org>
4027
4028         Reviewed by Adam Barth.
4029
4030         Fix OwnPtr strictness issues in WebCore/inspector/
4031         https://bugs.webkit.org/show_bug.cgi?id=59387
4032
4033         * inspector/InspectorAgent.cpp:
4034         (WebCore::InspectorAgent::InspectorAgent):
4035         * inspector/InspectorController.cpp:
4036         (WebCore::InspectorController::InspectorController):
4037         * inspector/InspectorStyleSheet.cpp:
4038         (WebCore::InspectorStyleSheet::ensureSourceData):
4039
4040 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4041
4042         Reviewed by Beth Dakin.
4043
4044         Removed XPathNamespace because it was unused
4045         https://bugs.webkit.org/show_bug.cgi?id=59381
4046         
4047         This allows us to make Node::ownerDocument() non-virtual, though it has
4048         the unhappy side-effect of rebuilding the world.
4049
4050         * CMakeLists.txt:
4051         * GNUmakefile.list.am:
4052         * WebCore.gypi:
4053         * WebCore.pro:
4054         * WebCore.vcproj/WebCore.vcproj:
4055         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
4056
4057         * dom/Node.h: Hello fast code!
4058
4059         * xml/XPathNamespace.cpp: Removed.
4060         * xml/XPathNamespace.h: Removed.
4061
4062 2011-04-25  Adam Barth  <abarth@webkit.org>
4063
4064         Reviewed by Darin Adler.
4065
4066         HistoryItemMac should play nice with OwnPtrs
4067         https://bugs.webkit.org/show_bug.cgi?id=59388
4068
4069         * history/mac/HistoryItemMac.mm:
4070         (WebCore::HistoryItem::setTransientProperty):
4071
4072 2011-04-25  David Levin  <levin@chromium.org>
4073
4074         Reviewed by Kenneth Russell.
4075
4076         Fix strict OwnPtrs in ContextMenuController.cpp
4077         https://bugs.webkit.org/show_bug.cgi?id=59375
4078
4079         * page/ContextMenuController.cpp:
4080         (WebCore::ContextMenuController::createContextMenu):
4081         (WebCore::separatorItem):
4082
4083 2011-04-25  Adam Barth  <abarth@webkit.org>
4084
4085         Reviewed by Darin Adler.
4086
4087         CheckedRadioButton should play nice with strict OwnPtr
4088         https://bugs.webkit.org/show_bug.cgi?id=59386
4089
4090         * dom/CheckedRadioButtons.cpp:
4091         (WebCore::CheckedRadioButtons::addButton):
4092
4093 2011-04-25  Adam Barth  <abarth@webkit.org>
4094
4095         Reviewed by David Levin.
4096
4097         Resource*.cpp should play nice with strict OwnPtrs
4098         https://bugs.webkit.org/show_bug.cgi?id=59383
4099
4100         * bridge/runtime_method.cpp:
4101         (JSC::RuntimeMethod::RuntimeMethod):
4102         * platform/network/ResourceHandle.cpp:
4103         (WebCore::ResourceHandle::ResourceHandle):
4104         * platform/network/ResourceResponseBase.cpp:
4105         (WebCore::ResourceResponseBase::adopt):
4106         (WebCore::ResourceResponseBase::copyData):
4107
4108 2011-04-25  Adam Barth  <abarth@webkit.org>
4109
4110         Reviewed by David Levin.
4111
4112         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
4113         https://bugs.webkit.org/show_bug.cgi?id=59374
4114
4115         * bridge/objc/objc_runtime.mm:
4116         (JSC::Bindings::callObjCFallbackObject):
4117         * page/Page.cpp:
4118         (WebCore::Page::Page):
4119         (WebCore::Page::initGroup):
4120         * page/PageGroup.cpp:
4121         (WebCore::PageGroup::addUserScriptToWorld):
4122         (WebCore::PageGroup::addUserStyleSheetToWorld):
4123         * page/mac/PageMac.cpp:
4124         (WebCore::Page::addSchedulePair):
4125
4126 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4127
4128