https://bugs.webkit.org/show_bug.cgi?id=16777
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-06-10  Gavin Barraclough  <barraclough@apple.com>
2
3         Reviewed by Sam Weinig.
4
5         https://bugs.webkit.org/show_bug.cgi?id=16777
6         Eliminate JSC::NaN and JSC::Inf
7
8         There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
9         The ones in std::numeric_limits are perfectly good.
10         Remove JSC::Inf, JSC::NaN, switch some cases of (isnan || isinf) to !isfinite.
11
12         * bindings/js/JSDataViewCustom.cpp:
13         (WebCore::getDataViewMember):
14
15 2011-06-10  James Simonsen  <simonjam@chromium.org>
16
17         Reviewed by Eric Seidel.
18
19         <script> inside <svg> should be executed
20         https://bugs.webkit.org/show_bug.cgi?id=62412
21
22         Tests: svg/in-html/script-external.html
23                svg/in-html/script-nested.html
24                svg/in-html/script-write.html
25                svg/in-html/script.html
26
27         * html/parser/HTMLTreeBuilder.cpp:
28         (WebCore::HTMLTreeBuilder::processEndTag):
29
30 2011-06-10  Adam Barth  <abarth@webkit.org>
31
32         Reviewed by Darin Adler.
33
34         Script-created parsers should ignore data from the network
35         https://bugs.webkit.org/show_bug.cgi?id=62336
36
37         If the network packet boundaries line up just right, we can end up
38         feeding network data to a parser created by document.write (or
39         document.open).  That's incorrect.
40
41         This patch causes DocumentWriter to grab hold of the original parser
42         and direct all input to that parser.
43
44         Test: fast/parser/document-write-ignores-later-network-bytes.html
45
46         * dom/Document.cpp:
47         (WebCore::Document::explicitClose):
48         * loader/DocumentWriter.cpp:
49         (WebCore::DocumentWriter::begin):
50         (WebCore::DocumentWriter::addData):
51         (WebCore::DocumentWriter::endIfNotLoadingMainResource):
52         (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
53         * loader/DocumentWriter.h:
54
55 2011-06-10  Simon Fraser  <simon.fraser@apple.com>
56
57         Reviewed by Dan Bernstein.
58
59         Keep overlap testing logic until real 3d transforms are being used
60         https://bugs.webkit.org/show_bug.cgi?id=49857
61         
62         For pages that use the translateZ(0) hack to force compositing layers, it's
63         advantageous to keep overlap testing, to avoid putting too many other
64         elements into layers.
65         
66         Only turn off overlap testing if non-identity 3D transforms are used.
67
68         Tests: compositing/layer-creation/rotate3d-overlap.html
69                compositing/layer-creation/translatez-overlap.html
70
71         * rendering/RenderLayerCompositor.cpp:
72         (WebCore::RenderLayerCompositor::updateBacking):
73         (WebCore::RenderLayerCompositor::hasNonIdentity3DTransform):
74         * rendering/RenderLayerCompositor.h:
75
76 2011-06-10  David Levin  <levin@chromium.org>
77
78         Reviewed by Dmitry Titov.
79
80         Web Worker fails to fire error event when a resource fetch fails.
81         https://bugs.webkit.org/show_bug.cgi?id=62475
82
83         Test: http/tests/workers/worker-workerScriptNotThere.html
84
85         * workers/WorkerScriptLoader.cpp:
86         (WebCore::WorkerScriptLoader::didFinishLoading): Ensure that
87         the client is notified of the error when it happens during loading.
88
89 2011-06-10  David Levin  <levin@chromium.org>
90
91         Reviewed by Dmitry Titov.
92
93         Fetching a Worker with url that isn't allowed from a file based test causes DRT to crash.
94         https://bugs.webkit.org/show_bug.cgi?id=62469
95
96         Test: fast/workers/worker-crash-with-invalid-location.html
97
98         * workers/DefaultSharedWorkerRepository.cpp:
99         (WebCore::SharedWorkerScriptLoader::load): Changed to using the RefCounted version of WorkerScriptLoader.
100         * workers/Worker.cpp:
101         (WebCore::Worker::create): Ditto.
102         * workers/Worker.h: Ditto.
103         * workers/WorkerContext.cpp:
104         (WebCore::WorkerContext::importScripts):  Ditto.
105         * workers/WorkerScriptLoader.cpp:
106         (WebCore::WorkerScriptLoader::~WorkerScriptLoader): Created to
107         allow removing some header includes in WorkerScriptLoader.h.
108         (WebCore::WorkerScriptLoader::loadAsynchronously): Fix the ordering
109         of setPendingActivity and keep WorkerScriptLoader alive during a
110         potential callback.
111         * workers/WorkerScriptLoader.h: Made this RefCounted to allow for
112         keeping it alive during callbacks. Also, removed unnecessary header
113         inclusions (and added a destructor to facilitate that).
114         (WebCore::WorkerScriptLoader::create):
115
116 2011-06-10  Alok Priyadarshi  <alokp@chromium.org>
117
118         Reviewed by James Robinson.
119
120         [chromium] Top portion of page is rendered messed up with accelerated drawing
121         https://bugs.webkit.org/show_bug.cgi?id=62484
122
123         Fixed the math in flipping the texture from bottom-up to top-down.
124         Test: compositing/repaint/shrink-layer.html (existing)
125
126         * platform/graphics/chromium/LayerTilerChromium.cpp:
127         (WebCore::LayerTilerChromium::draw):
128
129 2011-06-10  Tony Chang  <tony@chromium.org>
130
131         Reviewed by Ojan Vafai.
132
133         add a compile guard ENABLE(FLEXBOX)
134         https://bugs.webkit.org/show_bug.cgi?id=62049
135
136         * Configurations/FeatureDefines.xcconfig:
137
138 2011-06-10  Sam Weinig  <sam@webkit.org>
139
140         Roll out r88568. It is not the right fix for the problem.
141
142         * loader/appcache/ApplicationCacheHost.cpp:
143         (WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
144
145 2011-06-10  Mark Rowe  <mrowe@apple.com>
146
147         Reviewed by Dimitri Glazkov.
148
149         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
150
151         Rename the built WebCoreTestSupport dylib to libWebCoreTestSupport.dylib so
152         that it can be found via the library search path rather than requiring an
153         absolute path be passed to the linker.
154
155         Install the library and its associated header file in a more appropriate location
156         for the production configuration.
157
158         * Configurations/WebCoreTestSupport.xcconfig:
159
160 2011-06-10  Simon Fraser  <simon.fraser@apple.com>
161
162         Reviewed by Dave Hyatt.
163
164         Add a scheduleSetNeedsStyleRecalc() method to ContainerNode for use by RenderLayerCompositor
165         https://bugs.webkit.org/show_bug.cgi?id=62471
166
167         RenderLayerCompositor had some code that did a setNeedsStyleRecalc(), but
168         in a way that was safe to call during existing style recalc or layout.
169         
170         Move this code to ContainerElement so it can be called elsewhere.
171         Also add a param to the node callback so we can pass the style change type.
172
173         * dom/ContainerNode.cpp:
174         (WebCore::ContainerNode::queuePostAttachCallback):
175         (WebCore::ContainerNode::dispatchPostAttachCallbacks):
176         (WebCore::needsStyleRecalcCallback):
177         (WebCore::ContainerNode::scheduleSetNeedsStyleRecalc):
178         * dom/ContainerNode.h:
179         * dom/Node.h:
180         (WebCore::Node::scheduleSetNeedsStyleRecalc):
181         * html/HTMLFormControlElement.cpp:
182         (WebCore::focusPostAttach):
183         (WebCore::updateFromElementCallback):
184         * html/HTMLPlugInImageElement.cpp:
185         (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
186         * html/HTMLPlugInImageElement.h:
187         * rendering/RenderLayerCompositor.cpp:
188         (WebCore::RenderLayerCompositor::attachRootPlatformLayer):
189         (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
190         (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
191         * rendering/RenderLayerCompositor.h:
192         * svg/SVGUseElement.cpp:
193         (WebCore::updateFromElementCallback):
194
195 2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>
196
197         Reviewed by Tony Chang.
198
199         IndexedDB: indexedDB.open() name argument is required
200         https://bugs.webkit.org/show_bug.cgi?id=62398
201
202         Test: storage/indexeddb/database-name-undefined.html
203
204         * storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments
205
206 2011-06-10  Sam Weinig  <sam@webkit.org>
207
208         Reviewed by Beth Dakin.
209
210         Common crash in ApplicationCacheHost::isApplicationCacheEnabled
211         <rdar://problem/9328684>
212
213         * loader/appcache/ApplicationCacheHost.cpp:
214         (WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
215         Speculative fix for a null frame on ApplicationCacheHost's DocumentLoader.
216
217 2011-06-10  Adam Barth  <abarth@webkit.org>
218
219         Reviewed by Eric Seidel.
220
221         Remove Document::finishParsing
222         https://bugs.webkit.org/show_bug.cgi?id=62474
223
224         This function appears to exist only to confuse and befuddle us.  This
225         patch prepares for DocumentWriter to grab hold of the parser.
226
227         This patch removes one of the print statements from
228         INSTRUMENT_LAYOUT_SCHEDULING, but I'm not sure
229         INSTRUMENT_LAYOUT_SCHEDULING works anymore anyway.
230
231         * dom/Document.cpp:
232         * dom/Document.h:
233         * dom/XMLDocumentParser.cpp:
234         (WebCore::XMLDocumentParser::finish):
235         * html/parser/HTMLDocumentParser.cpp:
236         (WebCore::HTMLDocumentParser::finish):
237         * loader/DocumentWriter.cpp:
238         (WebCore::DocumentWriter::addData):
239         (WebCore::DocumentWriter::endIfNotLoadingMainResource):
240         * loader/FrameLoader.cpp:
241         (WebCore::FrameLoader::stop):
242
243 2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>
244
245         Reviewed by Tony Chang.
246
247         IndexedDB: setVersion() version argument is required
248         https://bugs.webkit.org/show_bug.cgi?id=62401
249
250         Test: storage/indexeddb/setVersion-undefined.html
251
252         * storage/IDBDatabase.cpp:
253         (WebCore::IDBDatabase::setVersion): check for null version
254         * storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
255
256 2011-06-10  Simon Fraser  <simon.fraser@apple.com>
257
258         Reviewed by Dan Bernstein.
259
260         Null-check the layer owner again when painting layers
261         https://bugs.webkit.org/show_bug.cgi?id=62473
262
263         Speculative fix for a crash that occurs when the layer's owner
264         gets destroyed during painting.
265
266         * platform/graphics/mac/WebLayer.mm:
267         (drawLayerContents):
268
269 2011-06-08  Robert Hogan  <robert@webkit.org>
270
271         Reviewed by Andreas Kling.
272
273         [Qt] Lighten the --no-svg build a little
274         https://bugs.webkit.org/show_bug.cgi?id=62314
275
276         Only generate source from SVG*.idl if the build is svg-enabled.
277
278         * CodeGenerators.pri:
279
280 2011-06-10  Nikolas Zimmermann  <nzimmermann@rim.com>
281
282         Reviewed by Rob Buis.
283
284         Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
285         https://bugs.webkit.org/show_bug.cgi?id=59085
286
287         Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph
288         https://bugs.webkit.org/show_bug.cgi?id=62441
289
290         Preparation patch 1: Introduce the internal glyph table in SVGGlyphMap that will be used to identify each
291         SVGGlyph identifier with a Glyph (which is just an ushort). It will be used by follow-up patches.
292
293         Doesn't affect any test so far.
294
295         * platform/graphics/SVGGlyph.h:
296         (WebCore::SVGGlyph::SVGGlyph):
297         (WebCore::SVGGlyph::operator==):
298         * rendering/svg/SVGTextRunRenderingContext.cpp:
299         (WebCore::SVGTextRunWalker::walk):
300         * svg/SVGFontData.cpp:
301         (WebCore::SVGFontData::initializeFontData):
302         * svg/SVGFontElement.cpp:
303         (WebCore::SVGFontElement::SVGFontElement):
304         (WebCore::SVGFontElement::registerLigaturesInGlyphCache):
305         (WebCore::SVGFontElement::ensureGlyphCache):
306         (WebCore::kerningForPairOfStringsAndGlyphs):
307         (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs):
308         (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
309         (WebCore::SVGFontElement::collectGlyphsForString):
310         (WebCore::SVGFontElement::collectGlyphsForGlyphName):
311         (WebCore::SVGFontElement::svgGlyphForGlyph):
312         (WebCore::SVGFontElement::missingGlyph):
313         * svg/SVGFontElement.h:
314         (WebCore::SVGKerningPair::SVGKerningPair):
315         * svg/SVGGlyphMap.h:
316         (WebCore::SVGGlyphMap::addGlyphByUnicodeString):
317         (WebCore::SVGGlyphMap::addGlyphByName):
318         (WebCore::SVGGlyphMap::appendToGlyphTable):
319         (WebCore::SVGGlyphMap::collectGlyphsForString):
320         (WebCore::SVGGlyphMap::clear):
321         (WebCore::SVGGlyphMap::svgGlyphForGlyph):
322         (WebCore::SVGGlyphMap::glyphIdentifierForGlyphName):
323
324 2011-06-10  Emil A Eklund  <eae@chromium.org>
325
326         Reviewed by Eric Seidel.
327
328         Regression r85573: Blank pages appear at the end of some wikipedia documents.
329         https://bugs.webkit.org/show_bug.cgi?id=62343
330
331         Fix regression caused by r85573. Cached document size not updated after layout.
332
333         Test: printing/page-count-relayout-shrink.html
334
335         * page/FrameView.cpp:
336         (WebCore::FrameView::forceLayoutForPagination):
337
338 2011-06-10  Rob Buis  <rbuis@rim.com>
339
340         Reviewed by Nikolas Zimmermann.
341
342         amation event handling broken: focusin
343         https://bugs.webkit.org/show_bug.cgi?id=12894
344
345         focusin, focusout, activate not implemented in SVG
346         https://bugs.webkit.org/show_bug.cgi?id=40545
347
348         Make elements that should support GraphicalEventAttribute handle focussing, since focusin, focusout is part of that:
349
350         http://www.w3.org/TR/SVG11/intro.html#TermGraphicalEventAttribute
351
352         Match Opera behaviour ; elements that support GraphicalEventAttribute can receive visual mouse focus when having either a focusin or focusout event handler. Elements that support GraphicalEventAttribute can receive visual keyboard focus when having either a focusin or focusout event handler. Keyboard focus does not advance to SVG elements that are not focusable at the time.
353
354         Tests: svg/custom/focus-event-handling-keyboard.xhtml
355                svg/custom/focus-event-handling.xhtml
356
357         * rendering/svg/SVGRenderSupport.cpp:
358         (WebCore::SVGRenderSupport::computeRectForRepaint):
359         * svg/SVGCircleElement.h:
360         (WebCore::SVGCircleElement::supportsFocus):
361         * svg/SVGEllipseElement.h:
362         (WebCore::SVGEllipseElement::supportsFocus):
363         * svg/SVGGElement.h:
364         (WebCore::SVGGElement::supportsFocus):
365         * svg/SVGImageElement.h:
366         (WebCore::SVGImageElement::supportsFocus):
367         * svg/SVGLineElement.h:
368         (WebCore::SVGLineElement::supportsFocus):
369         * svg/SVGPathElement.h:
370         (WebCore::SVGPathElement::supportsFocus):
371         * svg/SVGPolyElement.h:
372         (WebCore::SVGPolyElement::supportsFocus):
373         * svg/SVGRectElement.h:
374         (WebCore::SVGRectElement::supportsFocus):
375         * svg/SVGSVGElement.h:
376         (WebCore::SVGSVGElement::supportsFocus):
377         * svg/SVGStyledElement.cpp:
378         (WebCore::SVGStyledElement::isMouseFocusable):
379         (WebCore::SVGStyledElement::isKeyboardFocusable):
380         * svg/SVGStyledElement.h:
381         * svg/SVGSwitchElement.h:
382         (WebCore::SVGSwitchElement::supportsFocus):
383         * svg/SVGSymbolElement.h:
384         (WebCore::SVGSymbolElement::supportsFocus):
385         * svg/SVGTextElement.h:
386         (WebCore::SVGTextElement::supportsFocus):
387         * svg/SVGUseElement.h:
388         (WebCore::SVGUseElement::supportsFocus):
389
390 2011-06-10  Luke Macpherson   <macpherson@chromium.org>
391
392         Reviewed by Eric Seidel.
393
394         Clean up CSSPrimitiveValue::computeLength*
395         https://bugs.webkit.org/show_bug.cgi?id=61612
396
397         No new tests as no functionality changed.
398
399         * css/CSSGradientValue.cpp:
400         Use new computeLength functions.
401         * css/CSSPrimitiveValue.cpp:
402         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
403         Reduce to a single function using default parameter values.
404         (WebCore::CSSPrimitiveValue::computeLength):
405         Redefine existing functions with separate names as a single function using templated function specialization.
406         * css/CSSPrimitiveValue.h:
407         Prototypes for computeLengthIntForLength and computeLength.
408         * css/CSSStyleApplyProperty.cpp:
409         Use new computeLength functions.
410         * css/CSSStyleSelector.cpp:
411         Use new computeLength functions.
412         * css/MediaQueryEvaluator.cpp:
413         Use new computeLength functions.
414         * css/SVGCSSStyleSelector.cpp:
415         Use new computeLength functions.
416
417 2011-06-10  Simon Fraser  <simon.fraser@apple.com>
418
419         Reviewed by Beth Dakin.
420
421         Add utility to RenderLayer to determine if the layer is scrollable
422         https://bugs.webkit.org/show_bug.cgi?id=62467
423
424         New method that returns true if either scrollbar is present and enabled.
425         Not called anywhere yet.
426
427         * rendering/RenderLayer.cpp:
428         (WebCore::RenderLayer::allowsScrolling):
429         * rendering/RenderLayer.h:
430
431 2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>
432
433         Reviewed by Tony Chang.
434
435         REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges
436         https://bugs.webkit.org/show_bug.cgi?id=62460
437
438         Test: fast/dom/prototype-inheritance-2.html
439
440         * dom/DocumentMarkerController.cpp:
441         (WebCore::DocumentMarkerController::userSpellingMarkersForNode): Added an extra 0-check.
442
443 2011-06-10  James Simonsen  <simonjam@chromium.org>
444
445         Reviewed by Tony Gentilcore.
446
447         Don't execute scripts in shadow SVG.
448         https://bugs.webkit.org/show_bug.cgi?id=62225
449
450         Test: svg/dom/use-style-recalc-script-execute-crash.html
451
452         * dom/ScriptElement.cpp:
453         (WebCore::ScriptElement::prepareScript):
454
455 2011-06-10  Konstantin Tokarev  <ktokarev@smartlabs.tv>
456
457         Reviewed by Joseph Pecoraro.
458
459         Fixed build with enabled workers and disabled inspector
460         https://bugs.webkit.org/show_bug.cgi?id=62461
461
462         * inspector/InspectorWorkerAgent.cpp: Added inspector guard
463
464 2011-06-10  Darin Adler  <darin@apple.com>
465
466         Reviewed by Eric Carlson.
467
468         REGRESSION: Fullscreen video controller can't be dragged
469         https://bugs.webkit.org/show_bug.cgi?id=62462
470
471         No regression test because we don't have machinery for testing the fullscreen
472         mode. We may find a way to add this in the future.
473
474         * html/shadow/MediaControlElements.cpp:
475         (WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new
476         booleans related to dragging.
477         (WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging
478         is allowed and a drag isn't already in progress.
479         (WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if
480         dragging is already in progress.
481         (WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is
482         done during the dragging process.
483         (WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel
484         using explicit top/left.
485         (WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning
486         done by setPosition.
487         (WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag,
488         continueDrag, and endDrag in response to mouse events.
489         (WebCore::MediaControlPanelElement::setCanBeDragged): Added.
490         * html/shadow/MediaControlElements.h: Added new function and data members
491         as mentioned above.
492
493         * html/shadow/MediaControlRootElement.cpp:
494         (WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true)
495         so you can drag the panel while in fullscreen.
496         (WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false)
497         so you can't drag the panel while not in fullscreen. Also call resetPosition so
498         position changes from dragging don't affect the panel in other contexts.
499
500 2011-06-10  Darin Adler  <darin@apple.com>
501
502         Reviewed by Eric Carlson.
503
504         REGRESSION: Full screen video HUD is positioned too low for standalone video documents
505         https://bugs.webkit.org/show_bug.cgi?id=62463
506
507         No test because we don't currently have machinery for testing fullscreen.
508
509         * css/fullscreen.css: Removed rule that said bottom: 0px for the control panel
510         for full page media in full screen mode. This is not needed because the control
511         panel for full screen mode already has style rules to set its vertical position.
512         (:-webkit-full-screen-ancestor:not(iframe)): Fixed typo where it said
513         -webkit-tranform. This will fix a potential problem where fullscreen would
514         malfunction on a page that had a media element inside a transform.
515
516 2011-06-10  Sergio Villar Senin  <svillar@igalia.com>
517
518         Reviewed by Gustavo Noronha Silva.
519
520         [GTK] Add support for non-ASCII filenames in Content-Disposition header
521         https://bugs.webkit.org/show_bug.cgi?id=62454
522
523         Try latin1 as fallback for header parameter values as some servers
524         do not follow RFC 2045 for example with filename parameter in
525         Content-Disposition.
526
527         No new tests required as no functionality changed.
528
529         * platform/network/soup/ResourceResponseSoup.cpp:
530         (WebCore::ResourceResponse::updateFromSoupMessage):
531
532 2011-06-10  No'am Rosenthal  <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
533
534         Reviewed by Kenneth Rohde Christiansen.
535
536         Add layer factory to GraphicsLayer for creating non-default layer type.
537         https://bugs.webkit.org/show_bug.cgi?id=61925
538
539         Added a static factory protected member to GraphicsLayer, which should be accessed from
540         a port-specific implementation of GraphicsLayer::create. For now this is enabled for Qt only.
541
542         This is needed for accelerated compositing across processes in WebKit2, since WebCore
543         doesn't know in compile time whether it's in WebKit or WebKit2, which makes having two
544         different implementations of GraphicsLayer coexist impossible without some runtime
545         factory that can be overridden by the web process.
546
547         Note that the use of the factory would be optional, and the port-specific GraphicsLayer::create
548         would have to explicitly call it, in order to be unintrusive with current implementations.
549
550         No new functionality, so no new tests.
551
552         * platform/graphics/GraphicsLayer.cpp:
553         (WebCore::GraphicsLayer::setGraphicsLayerFactory):
554         * platform/graphics/GraphicsLayer.h:
555
556 2011-06-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
557
558         Reviewed by Kenneth Rohde Christiansen.
559
560         [CMAKE] Add generic support for building with WebGL
561         https://bugs.webkit.org/show_bug.cgi?id=62376
562
563         Set new THIRDPARTY_DIR variable to compile sources under ThirdParty.
564
565         No change in functionality so no new tests.
566
567         * CMakeLists.txt:
568
569 2011-06-10  Ryuan Choi  <ryuan.choi@samsung.com>
570
571         Reviewed by Andreas Kling.
572
573         [GTK][EFL] m_imageInterpolationQuality is not initialized in PlatformContextCairo::PlatformContextCairo.
574         https://bugs.webkit.org/show_bug.cgi?id=62435
575
576         No new tests required as just fixed warning.
577
578         * platform/graphics/cairo/PlatformContextCairo.cpp:
579         (WebCore::PlatformContextCairo::PlatformContextCairo):
580
581 2011-06-11-06-09  Ilya Tikhonovsky  <loislo@chromium.org>
582
583         Reviewed by Yury Semikhatsky.
584
585         Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
586         https://bugs.webkit.org/show_bug.cgi?id=62377
587
588         * inspector/InspectorValues.cpp:
589
590 2011-06-10  Sheriff Bot  <webkit.review.bot@gmail.com>
591
592         Unreviewed, rolling out r88530.
593         http://trac.webkit.org/changeset/88530
594         https://bugs.webkit.org/show_bug.cgi?id=62440
595
596         qt build was broken (Requested by loislo on #webkit).
597
598         * inspector/InspectorValues.cpp:
599
600 2011-06-09  Ilya Tikhonovsky  <loislo@chromium.org>
601
602         Reviewed by Yury Semikhatsky.
603
604         Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
605         https://bugs.webkit.org/show_bug.cgi?id=62377
606
607         * inspector/InspectorValues.cpp:
608
609 2011-06-09  Jer Noble  <jer.noble@apple.com>
610
611         Reviewed by Darin Adler.
612
613         REGRESSION: Vertical scroll bar appears when taking videos into full screen at jerryseinfeld.com
614         https://bugs.webkit.org/show_bug.cgi?id=62402
615
616         Sites are able to override the "overflow:hidden" rule for root full-screen nodes
617         simply by adding a "html {}" rule.  Make this rule !important, and also make it apply
618         to root nodes who are merely ancestors of full-screen elements, to cover the case of
619         a root node containing an <iframe> whose contents have gone full-screen.
620
621         * css/fullscreen.css:
622         (:root:-webkit-full-screen-document:not(:-webkit-full-screen),
623             :root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
624             who are full-screen ancestors, and make them !important.
625
626 2011-06-09  Luke Macpherson   <macpherson@chromium.org>
627
628         Reviewed by Eric Seidel.
629
630         Rename RenderStyle visuallyOrdered property and use an enum instead of a bool.
631         https://bugs.webkit.org/show_bug.cgi?id=61495
632
633         No new tests required as no functionality changed.
634
635         * css/CSSPrimitiveValueMappings.h:
636         Support cast to/from Order
637         * css/CSSStyleSelector.cpp:
638         (WebCore::CSSStyleSelector::styleForDocument):
639         Convert from bool to enum type.
640         (WebCore::CSSStyleSelector::applyProperty):
641         Convert to macro that uses the cast defined in CSSPrimitiveValueMappings.
642         * dom/Document.cpp:
643         (WebCore::Document::setVisuallyOrdered):
644         Change call to RenderStyle::setRTLOrdering using enum parameter.
645         * rendering/style/RenderStyle.h:
646         rename visuallyOrdered proerties rtlOrdering and use appropriate enum types.
647         * rendering/style/RenderStyleConstants.h:
648         Define enum type.
649
650 2011-06-09  Luke Macpherson   <macpherson@chromium.org>
651
652         Reviewed by Eric Seidel.
653
654         Implement CSSPropertyOutlineStyle handler in CSSStyleApplyProperty
655         https://bugs.webkit.org/show_bug.cgi?id=61601
656
657         No new tests. No new functionality added / covered by existing tests.
658
659         * css/CSSPrimitiveValueMappings.h:
660         (WebCore::CSSPrimitiveValue::operator EBorderStyle):
661         Support CSSValueAuto as required by outline-style property.
662         (WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
663         Add cast to new OutlineIsAuto enum.
664         * css/CSSStyleApplyProperty.cpp:
665         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
666         Initialize handler for CSSPropertyOutlineStyle.
667         * css/CSSStyleSelector.cpp:
668         (WebCore::CSSStyleSelector::applyProperty):
669         Remove old handler for CSSPropertyOutlineStyle.
670         * rendering/style/OutlineValue.h:
671         Use new OutlineIsAuto enum instead of bool.
672         * rendering/style/RenderStyle.h:
673         Split existing two-parameter setter setOutlineStyle into separate setters for style and auto properties.
674         Use new OutlineIsAuto enum type.
675         * rendering/style/RenderStyleConstants.h:
676         Define new enum OutlineIsAuto.
677
678 2011-06-09  Luke Macpherson   <macpherson@chromium.org>
679
680         Reviewed by Eric Seidel.
681
682         Code cleanup - add wrappers for function pointer dereferences to improve readability in ApplyPropertyDefaultBase and derived classes.
683         https://bugs.webkit.org/show_bug.cgi?id=62418
684
685         No new tests / cleanup only.
686
687         * css/CSSStyleApplyProperty.cpp:
688         (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
689         Use new wrapper functions.
690         (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
691         Use new wrapper functions.
692         (WebCore::ApplyPropertyDefaultBase::setValue):
693         Wrapper for calling m_setter function pointer.
694         (WebCore::ApplyPropertyDefaultBase::value):
695         Wrapper for calling m_getter function pointer.
696         (WebCore::ApplyPropertyDefaultBase::initial):
697         Wrapper for calling m_initial function pointer.
698         (WebCore::ApplyPropertyDefault::applyValue):
699         Use new setValue function.
700         (WebCore::ApplyPropertyLength::applyValue):
701         Use new setValue function.
702         (WebCore::ApplyPropertyWidth::applyValue):
703         Use new setValue function.
704
705 2011-06-09  Hyowon Kim  <hw1008.kim@samsung.com>
706
707         Reviewed by Antonio Gomes.
708
709         [EFL] Make accelerated compositing build in Webkit-EFL
710         https://bugs.webkit.org/show_bug.cgi?id=62361
711
712         Add a new class, GraphicsLayerEfl - not yet implemented.
713         Add ACCELERATED_COMPOSITING related files to CMakeLists.
714
715         * CMakeLists.txt:
716         * CMakeListsEfl.txt:
717         * platform/graphics/efl/GraphicsLayerEfl.cpp: Added.
718         (WebCore::GraphicsLayer::create):
719         (WebCore::GraphicsLayerEfl::GraphicsLayerEfl):
720         (WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
721         (WebCore::GraphicsLayerEfl::setNeedsDisplay):
722         (WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):
723         * platform/graphics/efl/GraphicsLayerEfl.h: Added.
724
725 2011-06-09  Jian Li  <jianli@chromium.org>
726
727         Reviewed by David Levin.
728
729         Calling WebKitBlobBuilder.append with null argument should not crash
730         https://bugs.webkit.org/show_bug.cgi?id=62419
731
732         Test: fast/files/blob-builder-crash.html
733
734         * fileapi/WebKitBlobBuilder.cpp:
735         (WebCore::WebKitBlobBuilder::append):
736
737 2011-06-09  Jer Noble  <jer.noble@apple.com>
738
739         Reviewed by David Hyatt.
740
741         Roll out r88468, and fix bug #61911 without making Element::offset functions virtual.
742         https://bugs.webkit.org/show_bug.cgi?id=62400
743
744         No new tests; covered by existing fullscreen/full-screen-video-offset.html test.
745
746         * rendering/RenderVideo.cpp:
747         (WebCore::rendererPlaceholder): Added; returns the placeholder block, if it exists.
748         (WebCore::RenderVideo::offsetLeft): Pass the offset request to the placeholder block.
749         (WebCore::RenderVideo::offsetTop): Ditto.
750         (WebCore::RenderVideo::offsetWidth): Ditto.
751         (WebCore::RenderVideo::offsetHeight): Ditto.
752         * rendering/RenderVideo.h: Added virtual overrides for the offset functions.
753
754 2011-06-09  James Robinson  <jamesr@chromium.org>
755
756         Reviewed by Kenneth Russell.
757
758         [chromium] Scissor rect not set for clipping layers set offscreen
759         https://bugs.webkit.org/show_bug.cgi?id=62339
760
761         We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
762         a scissor.  Layers that didn't need to scissor had empty scissorRects.  Unfortunately layers with masksToBounds
763         and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.
764
765         This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
766         for an empty scissor rect at draw time.  RenderSurfaceChromiums have different requirements for
767         setScissorToRect, so the old behavior is still available with a flag.  This can probably be cleaned up more.
768
769         Test: platform/chromium/compositing/scissor-out-of-viewport.html
770
771         * platform/graphics/chromium/LayerRendererChromium.cpp:
772         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
773         (WebCore::LayerRendererChromium::drawLayer):
774         (WebCore::LayerRendererChromium::setScissorToRect):
775         * platform/graphics/chromium/LayerRendererChromium.h:
776         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
777         (WebCore::RenderSurfaceChromium::draw):
778         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
779         (WebCore::CCLayerImpl::CCLayerImpl):
780         * platform/graphics/chromium/cc/CCLayerImpl.h:
781         (WebCore::CCLayerImpl::setUsesLayerScissor):
782         (WebCore::CCLayerImpl::usesLayerScissor):
783
784 2011-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>
785
786         Unreviewed, rolling out r88468.
787         http://trac.webkit.org/changeset/88468
788         https://bugs.webkit.org/show_bug.cgi?id=62408
789
790         It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
791         on #webkit).
792
793         * dom/Element.cpp:
794         (WebCore::adjustForLocalZoom):
795         * dom/Element.h:
796         * html/HTMLMediaElement.cpp:
797         * html/HTMLMediaElement.h:
798
799 2011-06-09  Kenneth Russell  <kbr@google.com>
800
801         Reviewed by Adam Barth.
802
803         Disallow use of cross-domain media (images, video) in WebGL
804         https://bugs.webkit.org/show_bug.cgi?id=62257
805
806         Updated WebGL implementation to track recent spec updates in this area.
807
808         Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
809                http/tests/security/webgl-remote-read-remote-image-allowed.html
810                http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
811
812         * html/canvas/CanvasRenderingContext.cpp:
813         (WebCore::CanvasRenderingContext::wouldTaintOrigin):
814         (WebCore::CanvasRenderingContext::checkOrigin):
815         * html/canvas/CanvasRenderingContext.h:
816         (WebCore::CanvasRenderingContext::checkOrigin):
817         * html/canvas/WebGLRenderingContext.cpp:
818         (WebCore::WebGLRenderingContext::readPixels):
819         (WebCore::WebGLRenderingContext::texImage2D):
820         (WebCore::WebGLRenderingContext::videoFrameToImage):
821         (WebCore::WebGLRenderingContext::texSubImage2D):
822         * html/canvas/WebGLRenderingContext.h:
823
824 2011-06-09  Adam Barth  <abarth@webkit.org>
825
826         Reviewed by Eric Seidel.
827
828         Add an ASSERT to HTMLTreeBuilder
829         https://bugs.webkit.org/show_bug.cgi?id=62403
830
831         This ASSERT was useful in investigating a re-entrancy bug.  We should
832         keep it.
833
834         * html/parser/HTMLTreeBuilder.cpp:
835         (WebCore::HTMLTreeBuilder::processEndOfFile):
836
837 2011-06-09  Dan Bernstein  <mitz@apple.com>
838
839         Reviewed by Darin Adler.
840
841         Fix a regression from r88478.
842
843         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
844         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Add the runs
845         in reverse order in the RTL case here, since the whole vector is reversed by collectComplexTextRuns()
846         afterwards.
847
848 2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>
849
850         Reviewed by Antti Koivisto.
851
852         REGRESSION(84329): Stylesheets on some pages do not load
853         https://bugs.webkit.org/show_bug.cgi?id=61400
854
855         Test: fast/css/link-disabled-attr.html
856
857         Fixed r84329: the change did not take into account the fact
858         that HTMLLinkElement did already contain the disabled information
859         and the 2 information were not linked as they should have!
860
861         The new logic pushes the information to the stylesheet as this
862         is what the spec mandates and what FF is doing. Also it keeps
863         one bit of information (that JS enabled the stylesheet) as it
864         is needed for the recalcStyleSelector logic.
865
866         * dom/Document.cpp:
867         (WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
868
869         * html/HTMLLinkElement.cpp:
870         (WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState,
871         replaced by m_isEnabledViaScript.
872         (WebCore::HTMLLinkElement::setDisabled): Updated the logic after
873         m_disabledState removal. It also matches the spec by forwarding
874         the disabled state to our stylesheet if we have one.
875         (WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful
876         handling of the disabledAttr.
877         (WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
878         * html/HTMLLinkElement.h:
879         (WebCore::HTMLLinkElement::isEnabledViaScript): Ditto.
880         (WebCore::HTMLLinkElement::isAlternate): Ditto.
881
882 2011-06-09  Dan Bernstein  <mitz@apple.com>
883
884         Reviewed by Darin Adler.
885
886         Simplify ComplexTextController::collectComplexTextRuns()
887         https://bugs.webkit.org/show_bug.cgi?id=62387
888
889         No new test, since functionality is unchanged.
890
891         * platform/graphics/mac/ComplexTextController.cpp:
892         (WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
893         then reverse the run vector for RTL.
894
895 2011-06-09  Dimitri Glazkov  <dglazkov@chromium.org>
896
897         Reviewed by Kent Tamura.
898
899         Fold isShadowBoundary into isShadowRoot.
900         https://bugs.webkit.org/show_bug.cgi?id=62317
901
902         Since there are no longer cases where Node::isShadowBoundary() != Node::isShadowRoot, we can remove this function.
903
904         In one case where isShadowBoundary was also tested to find ShadowContentElemnt, added a new isContentElement function.
905
906         Refactoring, covered by existing tests.
907
908         * css/CSSStyleSelector.cpp:
909         (WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
910         * dom/Element.cpp:
911         (WebCore::Element::isSpellCheckingEnabled): Ditto.
912         * dom/Node.cpp:
913         (WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
914         (WebCore::Node::nonShadowBoundaryParentNode): Ditto.
915         * dom/Node.h:
916         (WebCore::Node::isContentElement): Added.
917         * dom/NodeRenderingContext.cpp:
918         (WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use isShadowRoot.
919         * dom/Position.cpp:
920         (WebCore::Position::Position): Ditto.
921         * dom/ShadowContentElement.h:
922         (WebCore::ShadowContentElement::isContentElement): Added.
923         * dom/ShadowRoot.cpp:
924         (WebCore::ShadowRoot::hasContentElement): Changed to use isContentElement.
925         * editing/CompositeEditCommand.cpp:
926         (WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShadowRoot.
927         * editing/htmlediting.cpp:
928         (WebCore::visiblePositionBeforeNode): Ditto.
929         (WebCore::visiblePositionAfterNode): Ditto.
930         * page/DragController.cpp:
931         (WebCore::asFileInput): Ditto.
932         * rendering/RenderTreeAsText.cpp:
933         (WebCore::nodePosition): Ditto.
934
935 2011-06-09  Simon Fraser  <simon.fraser@apple.com>
936
937         Reviewed by Darin Adler.
938
939         Crashes in RenderLayerBacking::paintingGoesToWindow
940         https://bugs.webkit.org/show_bug.cgi?id=61159
941
942         Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
943         finds a repaintContainer that is not the RenderView, but that is also not
944         composited (for unknown reasons), by checking to see if the layer is
945         compositing before using backing(). An assertion remains to try to catch
946         this in debug builds.
947
948         * rendering/RenderLayer.cpp:
949         (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
950
951 2011-06-09  Julien Chaffraix  <jchaffraix@webkit.org>
952
953         Reviewed by Darin Adler.
954
955         WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
956         https://bugs.webkit.org/show_bug.cgi?id=62384
957
958         Test: fast/css/webkit-keyframes-crash.html
959
960         * css/WebKitCSSKeyframesRule.cpp:
961         (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
962         to return a non-null pointer. Thus null-check here like the rest of the code.
963
964 2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>
965
966         Reviewed by David Hyatt.
967
968         chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
969         https://bugs.webkit.org/show_bug.cgi?id=57756
970
971         Tests: fast/css/fontMetric-border-radius-null-crash.html
972                fast/css/fontMetric-webkit-border-end-width-null-crash.html
973
974         * css/CSSStyleSelector.cpp:
975         (WebCore::CSSStyleSelector::styleForElement): Added a call to Font::update
976         so that our FontFallbackList is allocated if we ever need it when applying our
977         style rules.
978
979 2011-06-09  Cary Clark  <caryclark@google.com>
980
981         Reviewed by Eric Seidel.
982
983         Create local CG context for Mac UI elements when Skia is renderer
984         https://bugs.webkit.org/show_bug.cgi?id=62213
985
986         When building Mac Chrome using Skia as the WebKit renderer,
987         add state to LocalCurrentGraphicsContext to convert the SkCanvas
988         context passed by WebKit into the CGContext needed by UI
989         rendering.
990
991         No new tests.  The define typo in question is
992         not yet enabled, so this change has no functional
993         impact.
994
995         * platform/mac/LocalCurrentGraphicsContext.h:
996         Add SkiaBitLocker to create and release the converted CGContext.
997         Add ContextContainer, a class for Skia to create and release
998         the converted CGContext. If Skia is not used, the class has no effect.
999
1000         * platform/mac/LocalCurrentGraphicsContext.mm:
1001         (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
1002         When building with Skia, create the CGContext before passing it on.
1003
1004         (WebCore::LocalCurrentGraphicsContext::cgContext):
1005         Get the CGContext from the SkiaBitLocker, or the saved context,
1006         as appropriate.
1007
1008         * rendering/RenderThemeMac.mm:
1009         Get the CGContext from Skia conversion or native, as appropriate.
1010         Use the LocalCurrentGraphicsContext if there is one. Otherwise,
1011         add a ContextContainer to house the SkCanvas to CGContext conversion.
1012
1013         (WebCore::RenderThemeMac::paintCapsLockIndicator):
1014         (WebCore::RenderThemeMac::paintProgressBar):
1015         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
1016         (WebCore::RenderThemeMac::paintSliderTrack):
1017         (WebCore::RenderThemeMac::paintMediaFullscreenButton):
1018         (WebCore::RenderThemeMac::paintMediaMuteButton):
1019         (WebCore::RenderThemeMac::paintMediaPlayButton):
1020         (WebCore::RenderThemeMac::paintMediaSeekBackButton):
1021         (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
1022         (WebCore::RenderThemeMac::paintMediaSliderTrack):
1023         (WebCore::RenderThemeMac::paintMediaSliderThumb):
1024         (WebCore::RenderThemeMac::paintMediaRewindButton):
1025         (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
1026         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
1027         (WebCore::RenderThemeMac::paintMediaControlsBackground):
1028         (WebCore::RenderThemeMac::paintMediaCurrentTime):
1029         (WebCore::RenderThemeMac::paintMediaTimeRemaining):
1030         (WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
1031         (WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
1032         (WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
1033
1034 2011-06-02  Jer Noble  <jer.noble@apple.com>
1035
1036         Reviewed by Maciej Stachowiak.
1037
1038         REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
1039         https://bugs.webkit.org/show_bug.cgi?id=61911
1040         <rdar://problem/9523017>
1041
1042         Test: fullscreen/full-screen-video-offset.html
1043
1044         When the video element is taken full-screen in the new element full-screen API, return the
1045         offset width and height of the placeholder renderer which is filling in for the full-screen
1046         element.  To do so, override offsetWidth, Height, Left, and Top from Element.  These are
1047         non-virtual functions, so make them virtual.
1048
1049         * dom/Element.cpp:
1050         (WebCore::Element::adjustForLocalZoom): Made into a class-static function.
1051         * dom/Element.h: Made offset functions virtual.
1052         * html/HTMLMediaElement.cpp:
1053         (WebCore::elementPlaceholder): Added; utility function.
1054         (WebCore::HTMLMediaElement::offsetLeft): Added; virtual override of the 
1055             Element function. Will be called directly via javascript.
1056         (WebCore::HTMLMediaElement::offsetTop): Ditto.
1057         (WebCore::HTMLMediaElement::offsetWidth): Ditto.
1058         (WebCore::HTMLMediaElement::offsetHeight): Ditto.
1059         * html/HTMLMediaElement.h:
1060
1061 2011-06-09  Dave Tapuska  <dtapuska@rim.com>
1062
1063         Reviewed by Daniel Bates.
1064
1065         PingLoader destructor could dereference 0 if the Resource
1066         Handle creation failed.
1067
1068         https://bugs.webkit.org/show_bug.cgi?id=62304
1069
1070         * loader/PingLoader.cpp:
1071         (WebCore::PingLoader::~PingLoader):
1072
1073 2011-06-08  Abhishek Arya  <inferno@chromium.org>
1074
1075         Reviewed by Ryosuke Niwa.
1076
1077         Make indexForVisiblePosition and isSelectableElement static.
1078         https://bugs.webkit.org/show_bug.cgi?id=62329
1079
1080         This protects us when converting frame->selection->start() or end()
1081         to VisiblePosition which blows away the RenderTextControl from
1082         underneath (due to layout update).
1083
1084         Test: fast/forms/text-control-selection-crash.html
1085
1086         * accessibility/AccessibilityRenderObject.cpp:
1087         (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
1088         * rendering/RenderTextControl.cpp:
1089         (WebCore::RenderTextControl::selectionStart):
1090         (WebCore::RenderTextControl::selectionEnd):
1091         (WebCore::RenderTextControl::isSelectableElement):
1092         (WebCore::RenderTextControl::indexForVisiblePosition):
1093         * rendering/RenderTextControl.h:
1094
1095 2011-06-09  Ben Murdoch  <benm@google.com>
1096
1097         Reviewed by Yury Semikhatsky.
1098
1099         Build break in ScriptProfile.cpp and inspector disabled.
1100         https://bugs.webkit.org/show_bug.cgi?id=62373
1101
1102         No new tests - build fix only.
1103
1104         * bindings/v8/ScriptProfile.cpp: Add necessary guards.
1105         * bindings/v8/ScriptProfile.h: ditto.
1106
1107 2011-06-09  Vsevolod Vlasov  <vsevik@chromium.org>
1108
1109         Reviewed by Yury Semikhatsky.
1110
1111         Web Inspector: Network panel preview tab does not reattach SourceFrame when switching between preview and response tabs.
1112         https://bugs.webkit.org/show_bug.cgi?id=62298
1113
1114         * inspector/front-end/ResourcePreviewView.js:
1115         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback):
1116         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
1117
1118 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1119
1120         [Qt][Mac] Speculative buildfix after r88286.
1121
1122         * platform/graphics/IntPoint.h:
1123
1124 2011-06-09  Mike Lawther  <mikelawther@chromium.org>
1125
1126         Reviewed by Kent Tamura.
1127
1128         Parsing issue with -webkit-calc
1129         https://bugs.webkit.org/show_bug.cgi?id=62276
1130
1131         Set the CSSParserString for the calc functions.
1132
1133         Test: css3/calc/regression-62276.html
1134
1135         * css/CSSParser.cpp:
1136         (WebCore::CSSParser::lex):
1137
1138 2011-06-09  Robert Hogan  <robert@webkit.org>
1139
1140         Reviewed by Andreas Kling.
1141
1142         Teach Qt about window.internals
1143         https://bugs.webkit.org/show_bug.cgi?id=61074
1144
1145         A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
1146         away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
1147         Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
1148         where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
1149         is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
1150         Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
1151         and others. The only alternative seems like a compile time guard which we would have to teach the bots about.
1152
1153         * CodeGenerators.pri:
1154         * WebCore.pri:
1155         * WebCore.pro:
1156
1157 2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>
1158
1159         Reviewed by Pavel Feldman.
1160
1161         Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
1162         https://bugs.webkit.org/show_bug.cgi?id=52791
1163
1164         No new tests. The problem can be reproduced by trying to create InspectorValue
1165         from 1.0e-100 and call ->toJSONString() on this.
1166
1167         * inspector/InspectorValues.cpp:
1168         (WebCore::InspectorBasicValue::writeJSON):
1169         Added checking the predicted buffer size and choosing exponential format, or
1170         eventually "NaN" if the buffer is too small for decimal format.
1171
1172 2011-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1173
1174         Unreviewed, rolling out r88387.
1175         http://trac.webkit.org/changeset/88387
1176         https://bugs.webkit.org/show_bug.cgi?id=62368
1177
1178         New tests introduced in 88387 fail on Leopard,GTK,Qt bots
1179         (Requested by Ossy on #webkit).
1180
1181         * html/canvas/CanvasRenderingContext.cpp:
1182         (WebCore::CanvasRenderingContext::checkOrigin):
1183         * html/canvas/CanvasRenderingContext.h:
1184         * html/canvas/WebGLRenderingContext.cpp:
1185         (WebCore::WebGLRenderingContext::readPixels):
1186         (WebCore::WebGLRenderingContext::texImage2D):
1187         (WebCore::WebGLRenderingContext::videoFrameToImage):
1188         (WebCore::WebGLRenderingContext::texSubImage2D):
1189         * html/canvas/WebGLRenderingContext.h:
1190
1191 2011-06-09  Adam Barth  <abarth@webkit.org>
1192
1193         Reviewed by Eric Seidel.
1194
1195         Running script from attach can remove elements from the stack of open elements
1196         https://bugs.webkit.org/show_bug.cgi?id=62160
1197
1198         When the tree build runs script synchronously, that script can remove
1199         arbitrary elements from the stack of open elements.  We need to hold a
1200         reference to |parent| in attach instead of rely upon the reference in
1201         the stack of open elements.
1202
1203         Test: fast/parser/document-write-onload-clear.html
1204
1205         * html/parser/HTMLConstructionSite.cpp:
1206         (WebCore::HTMLConstructionSite::attach):
1207
1208 2011-06-08  Luke Macpherson   <macpherson@chromium.org>
1209
1210         Reviewed by Eric Seidel.
1211
1212         Make CSSPrimitiveValue support cast to EVerticalAlign.
1213         https://bugs.webkit.org/show_bug.cgi?id=62356
1214
1215         No new tests / refactoring only.
1216
1217         * css/CSSPrimitiveValueMappings.h:
1218         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1219         (WebCore::CSSPrimitiveValue::operator EVerticalAlign):
1220         * css/CSSStyleSelector.cpp:
1221         (WebCore::CSSStyleSelector::applyProperty):
1222
1223 2011-06-08  Justin Novosad  <junov@chromium.org>
1224
1225         Reviewed by James Robinson.
1226
1227         [Chromium] Crash when closing a tab with accelerated 2d canvas
1228         https://bugs.webkit.org/show_bug.cgi?id=62324
1229         Upon graphics context destruction, it is important to signal skia
1230         to abandon all of its resource handles.  This prevents a crash caused
1231         by skia attempting to release resources that were in the destroyed
1232         graphics context.
1233
1234         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
1235         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
1236
1237 2011-06-08  James Robinson  <jamesr@chromium.org>
1238
1239         Reviewed by Darin Fisher.
1240
1241         REGRESSION(88260): 10-50% performance regression across many page cyclers
1242         https://bugs.webkit.org/show_bug.cgi?id=62349
1243
1244         r88260 fixed a font cache resource leak and lowered the inactive font cache threshold.  The latter caused a
1245         significant performance regression across many chromium page cyclers, for example
1246         http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.
1247
1248         This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
1249         logic.
1250
1251         * platform/graphics/FontCache.cpp:
1252
1253 2011-06-08  Hayato Ito  <hayato@chromium.org>
1254
1255         Reviewed by Dimitri Glazkov.
1256
1257         A forward/backward tab traversal now visits focusable elements in a shadow root.
1258         https://bugs.webkit.org/show_bug.cgi?id=61410
1259
1260         Test: fast/dom/shadow/tab-order-iframe-and-shadow.html
1261
1262         Like a iframe element, a shadow host becomes a scope of
1263         tabindex. That means all descendant elements in a shadow root are
1264         skipped if the host node of the shadow root is not focusable.
1265
1266         The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
1267         which uses a shadow root and do extra works in their focus()
1268         method.
1269
1270         A shadow root's <content> is not considered in this patch.
1271         That will be addressed in a following patch.
1272
1273         * page/FocusController.cpp:
1274         (WebCore::shadowRoot):
1275         (WebCore::isTreeScopeOwner):
1276         (WebCore::FocusController::deepFocusableNode):
1277         (WebCore::FocusController::advanceFocusInDocumentOrder):
1278         (WebCore::FocusController::findFocusableNodeAcrossTreeScope):
1279         (WebCore::FocusController::findFocusableNode):
1280         (WebCore::FocusController::nextFocusableNode):
1281         (WebCore::FocusController::previousFocusableNode):
1282         (WebCore::FocusController::ownerOfTreeScope):
1283         * page/FocusController.h:
1284
1285 2011-06-08  Hayato Ito  <hayato@chromium.org>
1286
1287         Reviewed by Hajime Morita.
1288
1289         Makes sure that document.activeElement won't be an element in shadow root.
1290
1291         https://bugs.webkit.org/show_bug.cgi?id=61413
1292
1293         Test: fast/dom/shadow/activeelement-should-be-shadowhost.html
1294
1295         * html/HTMLDocument.cpp:
1296         (WebCore::focusedFrameOwnerElement):
1297         (WebCore::HTMLDocument::activeElement):
1298
1299 2011-06-08  Kent Tamura  <tkent@chromium.org>
1300
1301         Reviewed by Dimitri Glazkov.
1302
1303         Allow drawing a slider thumb for any nodes.
1304         https://bugs.webkit.org/show_bug.cgi?id=62196
1305
1306         RenderObject::node() should provide various information which is
1307         necessary for rendering. We don't need to refer the parent renderer.
1308
1309         * dom/Node.cpp:
1310         (WebCore::Node::focusDe1egate): Added.
1311         * dom/Node.h: Added a declaration.
1312         * html/shadow/MediaControlElements.cpp:
1313         (WebCore::toParentMediaElement):
1314           Added an overload of toParentMediaElement() with Node* parameter.
1315         * html/shadow/MediaControlElements.h:
1316         (WebCore::toParentMediaElement): ditto.
1317         * html/shadow/SliderThumbElement.cpp:
1318         (WebCore::SliderThumbElement::isEnabledFormControl):
1319           Returns the status of the host node.
1320         (WebCore::SliderThumbElement::isReadOnlyFormControl): ditto.
1321         (WebCore::SliderThumbElement::focusDe1egate):
1322           Returns the host node so that RenderTheme::isFocused() returns true.
1323         (WebCore::SliderThumbElement::detach): Style nit.
1324         (WebCore::SliderThumbElement::hostInput):
1325           Make it const because it is called by const functions.
1326         * html/shadow/SliderThumbElement.h:
1327           - Remove inDragMode()
1328           - Update declarations
1329         * platform/qt/RenderThemeQt.cpp:
1330         (WebCore::RenderThemeQt::paintMediaSliderThumb):
1331           Use Node::shadowAncestorNode() instead of RenderObject::parent() to
1332           support deeper thumb nodes.
1333         * rendering/RenderMediaControlsChromium.cpp:
1334         (WebCore::paintMediaSliderThumb): ditto.
1335         (WebCore::paintMediaVolumeSliderThumb): Remove isSlider() check.
1336         * rendering/RenderSlider.cpp:
1337         (WebCore::RenderSlider::inDragMode):
1338           SliderThumbElement::inDragMode() was removed, and Node::active() has
1339           the same information.
1340         * rendering/RenderTheme.cpp:
1341         (WebCore::RenderTheme::paint): Remove isSlider() checks.
1342         (WebCore::RenderTheme::isFocused): Apply Node::focusDelegate().
1343         * rendering/RenderThemeChromiumLinux.cpp:
1344         (WebCore::RenderThemeChromiumLinux::paintSliderThumb):
1345           isPressed() is enough.
1346         * rendering/RenderThemeChromiumWin.cpp:
1347           isEnabled(), isFocused(), and isPressed() are enough.
1348         (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
1349         (WebCore::RenderThemeChromiumWin::determineClassicState):
1350         * rendering/RenderThemeMac.mm:
1351         (WebCore::RenderThemeMac::paintSliderThumb):
1352           - Remove isSlider() check.
1353           - Passing 'o' to udpateFooState functions is enough.
1354           - isPressed() is enough.
1355         * rendering/RenderThemeSafari.cpp:
1356         (WebCore::RenderThemeSafari::paintSliderThumb):
1357           We don't need special handling anymore.
1358         * rendering/RenderThemeWin.cpp:
1359         (WebCore::RenderThemeWin::determineSliderThumbState):
1360           isEnabled(), isFocused(), and isPressed() are enough.
1361
1362 2011-06-08  Adam Barth  <abarth@webkit.org>
1363
1364         Reviewed by Eric Seidel.
1365
1366         constructTreeFromToken can re-enter parser, causing ASSERTs
1367         https://bugs.webkit.org/show_bug.cgi?id=62160
1368
1369         This patch clears the HTMLToken before constructing the tree from the
1370         token, putting the HTMLDocumentParser in a good state to be re-entered.
1371
1372         Tests: fast/parser/document-write-onload-nesting.html
1373                fast/parser/document-write-onload-ordering.html
1374
1375         * html/parser/HTMLDocumentParser.cpp:
1376         (WebCore::HTMLDocumentParser::pumpTokenizer):
1377         * html/parser/HTMLToken.h:
1378         (WebCore::HTMLToken::isUninitialized):
1379         * html/parser/HTMLTreeBuilder.cpp:
1380         (WebCore::HTMLTreeBuilder::constructTreeFromToken):
1381
1382 2011-06-08  Kent Tamura  <tkent@chromium.org>
1383
1384         Fix Qt build for r88405.
1385         https://bugs.webkit.org/show_bug.cgi?id=62208
1386
1387         * platform/qt/RenderThemeQt.h:
1388
1389 2011-06-08  Kent Tamura  <tkent@chromium.org>
1390
1391         Reviewed by Dimitri Glazkov.
1392
1393         Change the argument of RenderTheme::adjustSliderThumbSize(): RenderObject* -> RenderStyle*
1394         https://bugs.webkit.org/show_bug.cgi?id=62208
1395
1396         Change the argument type of RenderTheme::adjustSliderThumbSize() and
1397         RenderMediaControls::adjustMediaSliderThumbSize() from RenderObject* to RenderStyle*.
1398
1399         Also, each of adjustSliderThumbStyle() overrides calls RenderTheme::
1400         adjustSliderThumbStyle() for future changes.
1401
1402         No new tests. This is a refactoring and should not change any behavior.
1403
1404         * html/shadow/SliderThumbElement.cpp:
1405         (WebCore::RenderSliderThumb::layout): Passing RenderStyle* and remove a FIXME comment.
1406         * platform/efl/RenderThemeEfl.cpp:
1407         (WebCore::RenderThemeEfl::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
1408         * platform/gtk/RenderThemeGtk.cpp:
1409         (WebCore::RenderThemeGtk::adjustSliderThumbStyle): ditto.
1410         (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
1411         * platform/gtk/RenderThemeGtk.h:
1412         * platform/gtk/RenderThemeGtk2.cpp:
1413         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
1414         * platform/gtk/RenderThemeGtk3.cpp:
1415         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
1416         * platform/qt/RenderThemeQt.cpp:
1417         (WebCore::RenderThemeQt::adjustSliderThumbStyle): ditto.
1418         (WebCore::RenderThemeQt::adjustSliderThumbSize):
1419         * rendering/RenderMediaControls.cpp:
1420         (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
1421         * rendering/RenderMediaControls.h:
1422         * rendering/RenderMediaControlsChromium.cpp:
1423         (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
1424         * rendering/RenderMediaControlsChromium.h:
1425         * rendering/RenderSlider.cpp:
1426         (WebCore::RenderSlider::layout): Passing RenderStyle* and remove a FIXME comment.
1427         * rendering/RenderTheme.cpp:
1428         (WebCore::RenderTheme::adjustSliderThumbStyle): Add a comment.
1429         (WebCore::RenderTheme::adjustSliderThumbSize):
1430         * rendering/RenderTheme.h:
1431         * rendering/RenderThemeChromiumLinux.cpp:
1432         (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
1433         * rendering/RenderThemeChromiumLinux.h:
1434         * rendering/RenderThemeChromiumMac.h:
1435         * rendering/RenderThemeChromiumMac.mm:
1436         (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize):
1437         * rendering/RenderThemeChromiumSkia.cpp:
1438         (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
1439         * rendering/RenderThemeChromiumSkia.h:
1440         * rendering/RenderThemeChromiumWin.cpp:
1441         (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
1442         * rendering/RenderThemeChromiumWin.h:
1443         * rendering/RenderThemeMac.h:
1444         * rendering/RenderThemeMac.mm:
1445         (WebCore::RenderThemeMac::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
1446         (WebCore::RenderThemeMac::adjustSliderThumbSize):
1447         (WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
1448         * rendering/RenderThemeSafari.cpp:
1449         (WebCore::RenderThemeSafari::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
1450         (WebCore::RenderThemeSafari::adjustSliderThumbSize):
1451         * rendering/RenderThemeSafari.h:
1452         * rendering/RenderThemeWin.cpp:
1453         (WebCore::RenderThemeWin::adjustSliderThumbSize):
1454         * rendering/RenderThemeWin.h:
1455         * rendering/RenderThemeWinCE.cpp:
1456         (WebCore::RenderThemeWinCE::adjustSliderThumbSize):
1457         * rendering/RenderThemeWinCE.h:
1458
1459 2011-06-08  Brian Salomon  <bsalomon@google.com>
1460
1461         Reviewed by James Robinson.
1462
1463         Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO.
1464         https://bugs.webkit.org/show_bug.cgi?id=62318
1465
1466         Chromium-only crash
1467         Failures takes multiple seconds to occur, relying on JS garbage-collection to occur 
1468         http://www.hotbazooka.com/privatejoe-large
1469
1470         * platform/graphics/gpu/DrawingBuffer.cpp:
1471         (WebCore::DrawingBuffer::clear):
1472
1473 2011-06-08  Emil A Eklund  <eae@chromium.org>
1474
1475         Reviewed by Eric Seidel.
1476
1477         RenderEmbeddedObject::getReplacementTextGeometry
1478         https://bugs.webkit.org/show_bug.cgi?id=62313
1479
1480         Replace the last use of tx, ty with IntPoint.
1481
1482         Covered by existing tests.
1483
1484         * platform/graphics/FloatRect.h:
1485         (WebCore::FloatRect::move):
1486         (WebCore::FloatRect::moveBy):
1487         * rendering/RenderEmbeddedObject.cpp:
1488         (WebCore::RenderEmbeddedObject::paintReplaced):
1489         (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
1490         (WebCore::RenderEmbeddedObject::isInMissingPluginIndicator):
1491         * rendering/RenderEmbeddedObject.h:
1492
1493 2011-06-08  Tim Horton  <timothy_horton@apple.com>
1494
1495         Reviewed by Ryosuke Niwa.
1496
1497         Use correct CFURLStorageSessionRef definition on Leopard, as
1498         we created an inconsistency in const-ness between
1499         WebCoreSystemInterface.h and these two files in the case
1500         of Leopard only.
1501         https://bugs.webkit.org/show_bug.cgi?id=62223
1502
1503         * platform/network/ResourceHandle.h:
1504         * platform/network/cf/ResourceRequest.h:
1505
1506 2011-06-08  Sailesh Agrawal  <sail@chromium.org>
1507
1508         Reviewed by Mihai Parparita.
1509
1510         Chromium Mac: Enable overlay scrollbars
1511         https://bugs.webkit.org/show_bug.cgi?id=59756
1512
1513         Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.
1514
1515         No new tests, since this code is only enabled on future versions of Mac OS X.
1516
1517         * platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks.
1518         (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
1519         (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
1520         (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
1521         (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
1522         (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
1523         (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
1524         (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
1525         (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
1526         (WebCore::ScrollAnimatorChromiumMac::contentsResized):
1527         (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
1528         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
1529         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
1530         (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
1531         (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
1532         (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
1533         (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
1534         (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
1535         (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
1536         (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
1537         * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
1538         (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts.
1539         (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn.
1540         (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function.
1541         (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds.
1542         (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
1543         * platform/chromium/ScrollbarThemeChromiumMac.h:
1544         * platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm.
1545         (WebCore::scrollbarMap):
1546         (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
1547         (WebCore::updateArrowPlacement):
1548         (WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
1549         (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar):
1550         (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
1551         (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar):
1552         (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness):
1553         (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars):
1554         (WebCore::ScrollbarThemeChromiumMac::hasButtons):
1555         (WebCore::ScrollbarThemeChromiumMac::hasThumb):
1556         (WebCore::buttonRepaintRect):
1557         (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength):
1558         (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb):
1559         (WebCore::toScrollbarPainterKnobStyle):
1560         (WebCore::ScrollbarThemeChromiumMac::paint):
1561
1562 2011-06-06  Nate Chapin  <japhet@chromium.org>
1563
1564         Reviewed by Adam Barth.
1565
1566         Remove all knowledge of CachedResourceRequests from
1567         CachedResourceLoader. This puts the full burden of
1568         canceling these requests on DocumentLoader (via
1569         SubresourceLoader), and makes a CachedResourceRequest
1570         an OwnPtr in CachedResource.
1571
1572         https://bugs.webkit.org/show_bug.cgi?id=62308
1573
1574         * loader/FrameLoader.cpp:
1575         (WebCore::FrameLoader::stopLoading):
1576         * loader/cache/CachedResource.cpp:
1577         (WebCore::CachedResource::CachedResource):
1578         (WebCore::CachedResource::load):
1579         (WebCore::CachedResource::stopLoading):
1580         * loader/cache/CachedResource.h:
1581         * loader/cache/CachedResourceLoader.cpp:
1582         (WebCore::CachedResourceLoader::~CachedResourceLoader):
1583         (WebCore::CachedResourceLoader::loadDone):
1584         * loader/cache/CachedResourceLoader.h:
1585         * loader/cache/CachedResourceRequest.cpp:
1586         (WebCore::CachedResourceRequest::CachedResourceRequest):
1587         (WebCore::CachedResourceRequest::~CachedResourceRequest):
1588         (WebCore::CachedResourceRequest::load):
1589         (WebCore::CachedResourceRequest::didFinishLoading):
1590         (WebCore::CachedResourceRequest::didFail):
1591         (WebCore::CachedResourceRequest::didReceiveResponse):
1592         (WebCore::CachedResourceRequest::end):
1593         * loader/cache/CachedResourceRequest.h:
1594
1595 2011-06-08  Mike Reed  <reed@google.com>
1596
1597         Reviewed by James Robinson.
1598
1599         [Skia] check for null-shader from gradient factory
1600         https://bugs.webkit.org/show_bug.cgi?id=62319
1601
1602         * platform/graphics/skia/GradientSkia.cpp:
1603         (WebCore::Gradient::platformDestroy):
1604         (WebCore::Gradient::platformGradient):
1605
1606 2011-06-08  Kenneth Russell  <kbr@google.com>
1607
1608         Reviewed by Adam Barth.
1609
1610         Disallow use of cross-domain media (images, video) in WebGL
1611         https://bugs.webkit.org/show_bug.cgi?id=62257
1612
1613         Updated WebGL implementation to track recent spec updates in this area.
1614
1615         Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
1616                http/tests/security/webgl-remote-read-remote-image-allowed.html
1617                http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
1618
1619         * html/canvas/CanvasRenderingContext.cpp:
1620         (WebCore::CanvasRenderingContext::wouldTaintOrigin):
1621         (WebCore::CanvasRenderingContext::checkOrigin):
1622         * html/canvas/CanvasRenderingContext.h:
1623         (WebCore::CanvasRenderingContext::checkOrigin):
1624         * html/canvas/WebGLRenderingContext.cpp:
1625         (WebCore::WebGLRenderingContext::readPixels):
1626         (WebCore::WebGLRenderingContext::texImage2D):
1627         (WebCore::WebGLRenderingContext::videoFrameToImage):
1628         (WebCore::WebGLRenderingContext::texSubImage2D):
1629         * html/canvas/WebGLRenderingContext.h:
1630
1631 2011-06-08  John Bauman  <jbauman@chromium.org>
1632
1633         Reviewed by James Robinson.
1634
1635         Only draw portions of tiles in contentRect
1636         https://bugs.webkit.org/show_bug.cgi?id=62243
1637
1638         Old garbage data can remain in tiles, so make sure to draw only those
1639         portions that are supposed to be drawn.
1640
1641         Test: compositing/repaint/shrink-layer.html
1642
1643         * platform/graphics/chromium/LayerTilerChromium.cpp:
1644         (WebCore::LayerTilerChromium::draw):
1645
1646 2011-06-08  Emil A Eklund  <eae@chromium.org>
1647
1648         Reviewed by Eric Seidel.
1649
1650         Convert RenderBlock::isPointInOverflowControl to IntPoint
1651         https://bugs.webkit.org/show_bug.cgi?id=62312
1652
1653         Covered by existing tests.
1654
1655         * rendering/RenderBlock.cpp:
1656         (WebCore::RenderBlock::isPointInOverflowControl):
1657         (WebCore::RenderBlock::nodeAtPoint):
1658         * rendering/RenderBlock.h:
1659         * rendering/RenderListBox.cpp:
1660         (WebCore::RenderListBox::isPointInOverflowControl):
1661         * rendering/RenderListBox.h:
1662
1663 2011-06-08  James Simonsen  <simonjam@chromium.org>
1664
1665         Reviewed by Tony Gentilcore.
1666
1667         Fix clang issue, virtual function const mismatch
1668         https://bugs.webkit.org/show_bug.cgi?id=62307
1669
1670         No new tests. Built with clang & ran layout tests.
1671
1672         * page/MediaStreamFrameController.h:
1673         (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
1674
1675 2011-06-08  Chris Rogers  <crogers@google.com>
1676
1677         Reviewed by Kenneth Russell.
1678
1679         Implement BiquadFilterNode for filter types: LOWPASS, HIGHPASS, BANDPASS, LOWSHELF, HIGHSHELF, PEAKING, NOTCH, ALLPASS
1680         https://bugs.webkit.org/show_bug.cgi?id=62078
1681
1682         No new tests since audio API is not yet implemented.
1683
1684         * DerivedSources.make:
1685         * WebCore.gypi:
1686         * WebCore.xcodeproj/project.pbxproj:
1687         * platform/audio/Biquad.cpp:
1688         (WebCore::Biquad::Biquad):
1689         (WebCore::Biquad::reset):
1690         (WebCore::Biquad::setLowpassParams):
1691         (WebCore::Biquad::setHighpassParams):
1692         (WebCore::Biquad::setNormalizedCoefficients):
1693         (WebCore::Biquad::setLowShelfParams):
1694         (WebCore::Biquad::setHighShelfParams):
1695         (WebCore::Biquad::setPeakingParams):
1696         (WebCore::Biquad::setAllpassParams):
1697         (WebCore::Biquad::setNotchParams):
1698         (WebCore::Biquad::setBandpassParams):
1699         (WebCore::Biquad::setZeroPolePairs):
1700         (WebCore::Biquad::setAllpassPole):
1701         * platform/audio/Biquad.h:
1702         * webaudio/AudioContext.cpp:
1703         (WebCore::AudioContext::createBiquadFilter):
1704         (WebCore::AudioContext::createLowPass2Filter):
1705         (WebCore::AudioContext::createHighPass2Filter):
1706         * webaudio/AudioContext.h:
1707         * webaudio/AudioContext.idl:
1708         * webaudio/AudioNode.h:
1709         * webaudio/BiquadDSPKernel.cpp:
1710         (WebCore::BiquadDSPKernel::process):
1711         * webaudio/BiquadFilterNode.cpp: Added.
1712         (WebCore::BiquadFilterNode::BiquadFilterNode):
1713         * webaudio/BiquadFilterNode.h: Added.
1714         (WebCore::BiquadFilterNode::create):
1715         (WebCore::BiquadFilterNode::type):
1716         (WebCore::BiquadFilterNode::setType):
1717         (WebCore::BiquadFilterNode::frequency):
1718         (WebCore::BiquadFilterNode::q):
1719         (WebCore::BiquadFilterNode::gain):
1720         (WebCore::BiquadFilterNode::biquadProcessor):
1721         * webaudio/BiquadFilterNode.idl: Added.
1722         * webaudio/BiquadProcessor.cpp:
1723         (WebCore::BiquadProcessor::BiquadProcessor):
1724         * webaudio/BiquadProcessor.h:
1725         (WebCore::BiquadProcessor::setType):
1726         * webaudio/HighPass2FilterNode.cpp:
1727         (WebCore::HighPass2FilterNode::HighPass2FilterNode):
1728         * webaudio/LowPass2FilterNode.cpp:
1729         (WebCore::LowPass2FilterNode::LowPass2FilterNode):
1730
1731 2011-06-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1732
1733         Reviewed by Kenneth Rohde Christiansen.
1734
1735         WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
1736         https://bugs.webkit.org/show_bug.cgi?id=61694
1737
1738         No new tests, code path is not activated yet.
1739
1740         * WebCore.xcodeproj/project.pbxproj: Changed the TransformOperation subclassed from "project" to "private"
1741
1742 2011-06-08  Tom Sepez  <tsepez@chromium.org>
1743
1744         Reviewed by Adam Barth.
1745
1746         Cause checks for insecure content blocking policy to callback to client.
1747         https://bugs.webkit.org/show_bug.cgi?id=61946
1748         Tests: platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html
1749                platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html
1750                platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html
1751                platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked.html
1752
1753         * loader/FrameLoader.cpp:
1754         (WebCore::FrameLoader::checkIfDisplayInsecureContent):
1755         (WebCore::FrameLoader::checkIfRunInsecureContent):
1756         * loader/FrameLoaderClient.h:
1757         (WebCore::FrameLoaderClient::allowDisplayingInsecureContent):
1758         (WebCore::FrameLoaderClient::allowRunningInsecureContent):
1759
1760 2011-06-08  Kevin Ollivier  <kevino@theolliviers.com>
1761
1762         [wx] Build fix after introduction of FontCache::ShouldRetain
1763
1764         * platform/graphics/wx/FontCacheWx.cpp:
1765         (WebCore::FontCache::getFontDataForCharacters):
1766
1767 2011-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1768
1769         Unreviewed, rolling out r88365.
1770         http://trac.webkit.org/changeset/88365
1771         https://bugs.webkit.org/show_bug.cgi?id=62301
1772
1773         windows bots broken (Requested by loislo_ on #webkit).
1774
1775         * inspector/InspectorValues.cpp:
1776         (WebCore::InspectorBasicValue::writeJSON):
1777
1778 2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>
1779
1780         Reviewed by Pavel Feldman.
1781
1782         Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
1783         https://bugs.webkit.org/show_bug.cgi?id=52791
1784
1785         No new tests. The problem can be reproduced by trying to create InspectorValue
1786         from 1.0e-100 and call ->toJSONString() on this.
1787
1788         * inspector/InspectorValues.cpp:
1789         (WebCore::InspectorBasicValue::writeJSON):
1790         Added checking the predicted buffer size and choosing exponential format, or
1791         eventually "NaN" if the buffer is too small for decimal format.
1792
1793 2011-06-08  Nico Weber  <thakis@chromium.org>
1794
1795         Reviewed by Darin Adler.
1796
1797         Fix a ?: precedence error in ScrollbarThemeMac and ScrollbarThemeChromium
1798         https://bugs.webkit.org/show_bug.cgi?id=62295
1799
1800         This was found by a new warning recently added to clang's -Wparentheses
1801
1802         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1803         (WebCore::ScrollbarThemeChromiumMac::backButtonRect):
1804         * platform/mac/ScrollbarThemeMac.mm:
1805         (WebCore::ScrollbarThemeMac::backButtonRect):
1806
1807 2011-06-08  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1808
1809         Reviewed by Andreas Kling.
1810
1811         [Qt] Remove dead code from our JSC bridge
1812         https://bugs.webkit.org/show_bug.cgi?id=62287
1813
1814         The m_defaultMethod member is not used since r36848 and QtMethod
1815         was replaced by QtRuntimeMethod and subclasses in r29729.
1816
1817         * bridge/qt/qt_instance.cpp:
1818         (JSC::Bindings::QtInstance::removeCachedMethod):
1819         (JSC::Bindings::QtInstance::visitAggregate):
1820         * bridge/qt/qt_instance.h:
1821         * bridge/qt/qt_runtime.h:
1822
1823 2011-06-08  Ryan Sleevi  <rsleevi@chromium.org>
1824
1825         Reviewed by Tony Chang.
1826
1827         Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6
1828
1829         Compiling Chromium port under GCC 4.6 produces warnings about nullptr
1830         https://bugs.webkit.org/show_bug.cgi?id=62242
1831
1832         * WebCore.gyp/WebCore.gyp:
1833
1834 2011-05-25  Xiaomei Ji  <xji@chromium.org>
1835
1836         Reviewed by Ryosuke Niwa.
1837
1838         --webkit-visual-word does not work well in words separated by multiple spaces
1839         https://bugs.webkit.org/show_bug.cgi?id=61324
1840
1841         Remove positionBeforeNextWord and positionAfterPreviousWord short-cuts. They try to find the
1842         right word boundary (before the space or after the space) by using previousWordPosition and
1843         nextWordPosition. But they assume words are separated by single space and are not correct 
1844         for words separated by multiple spaces and words not separated by space.
1845
1846         Consider positionBeforeNextWord() for example, 
1847
1848         First, it checks whether the current position is after the current word by checking current
1849         position's previousWordPosition's nextWordPosition is the same as current position, which is
1850         wrong for words separated by multiple spaces. For example, given words A and B separated by 
1851         3 continuous spaces "A   B", position "A|", "A |", and "A  |" should all be considered as 
1852         position after current word. But for position "A |", its previousWordPosition's 
1853         nextWordPosition is position "A|", which is different from its current position, so the
1854         current position is not considered as a position after current word, consequently,
1855         instead of returning the right position as "A   |B", positionBeforeNextWord returns the
1856         position before next next word, as "A   B |C". Similar happens for position "A  |".
1857
1858         Second, given 3 Chinese words "ABC" that are not segmented by space, when cursor is at 
1859         "A|BC", positionBeforeNextWord() returns the same position after calling current position's
1860         nextWordPosition's previousWordPosition. It should returns position "AB|C".
1861
1862         For those cases, we will have to collect all the word breaks inside the box and look for
1863         the one at left or right of current position.
1864
1865         * editing/visible_units.cpp:
1866         (WebCore::leftWordPosition):
1867         (WebCore::rightWordPosition):
1868
1869 2011-06-08  Greg Simon  <gregsimon@chromium.org>
1870
1871         Reviewed by Dimitri Glazkov.
1872
1873         Control Indexeddb backends from LayoutTestController
1874         https://bugs.webkit.org/show_bug.cgi?id=61000
1875
1876         Test: storage/indexeddb/migrate-basics.html
1877
1878         * storage/IDBBackingStore.h:
1879         * storage/IDBFactoryBackendImpl.cpp:
1880         (WebCore::IDBFactoryBackendImpl::open):
1881         (WebCore::IDBFactoryBackendImpl::migrate):
1882         * storage/IDBFactoryBackendImpl.h:
1883         * storage/IDBFactoryBackendInterface.h:
1884         * storage/IDBLevelDBBackingStore.cpp:
1885         (WebCore::IDBLevelDBBackingStore::backingStoreExists):
1886         * storage/IDBLevelDBBackingStore.h:
1887         (WebCore::IDBLevelDBBackingStore::backingStoreType):
1888         * storage/IDBSQLiteBackingStore.cpp:
1889         (WebCore::IDBSQLiteBackingStore::backingStoreExists):
1890         * storage/IDBSQLiteBackingStore.h:
1891         (WebCore::IDBSQLiteBackingStore::backingStoreType):
1892
1893 2011-06-08  Dmitry Lomov  <dslomov@google.com>
1894
1895         Reviewed by Adam Barth.
1896
1897         https://bugs.webkit.org/show_bug.cgi?id=62164
1898         Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
1899         This functionality is untested and unused:
1900         This is an old code from Lockers-based implementation of WebWorkers in
1901         V8 bindings, to make sure that DOM objects are released on the right thread
1902         even though GC could have happened on any thread. It is currently unused (since
1903         current model is one worker per process) and is being removed because new implementation
1904         of WebWorkers will be using V8 isolates.
1905
1906         * WebCore.gypi:
1907         * WebCore.pro:
1908         * bindings/v8/ChildThreadDOMData.cpp: Removed.
1909         * bindings/v8/ChildThreadDOMData.h: Removed.
1910         * bindings/v8/DOMData.cpp:
1911         (WebCore::DOMData::DOMData):
1912         (WebCore::DOMData::getCurrent):
1913         (WebCore::DOMData::getMainThreadStore):
1914         * bindings/v8/DOMData.h:
1915         (WebCore::DOMData::getStore):
1916         (WebCore::DOMData::getCurrentMainThreadStore):
1917         (WebCore::DOMData::handleWeakObject):
1918         * bindings/v8/DOMDataStore.cpp:
1919         (WebCore::DOMDataStore::DOMDataStore):
1920         (WebCore::DOMDataStore::~DOMDataStore):
1921         (WebCore::DOMDataStore::weakNodeCallback):
1922         * bindings/v8/DOMDataStore.h:
1923         * bindings/v8/MainThreadDOMData.cpp: Removed.
1924         * bindings/v8/MainThreadDOMData.h: Removed.
1925         * bindings/v8/V8DOMMap.cpp:
1926         (WebCore::getDOMDataStore):
1927         (WebCore::removeAllDOMObjects):
1928         (WebCore::visitDOMNodes):
1929         (WebCore::visitDOMObjects):
1930         (WebCore::visitActiveDOMObjects):
1931         (WebCore::visitDOMSVGElementInstances):
1932         * bindings/v8/V8DOMMap.h:
1933         * bindings/v8/V8GCController.cpp:
1934         (WebCore::V8GCController::gcPrologue):
1935         (WebCore::V8GCController::gcEpilogue):
1936         * bindings/v8/WorkerScriptController.cpp:
1937         (WebCore::WorkerScriptController::~WorkerScriptController):
1938
1939 2011-06-08  Yael Aharon  <yael.aharon@nokia.com>
1940
1941         Reviewed by Andreas Kling.
1942
1943         [Qt] Build fix for building QtWebKit inside of Qt.
1944         https://bugs.webkit.org/show_bug.cgi?id=62280
1945
1946         Remove CONFIG=staticlib, because it causes the configure script to add -lwebcore
1947         into QtWebKit.prl.
1948
1949         No new tests, as this is just a build fix.
1950
1951         * WebCore.pri:
1952
1953 2011-06-08  Vsevolod Vlasov  <vsevik@chromium.org>
1954
1955         Reviewed by Pavel Feldman.
1956
1957         Web Inspector: Render non-document HTML resources as HTML
1958         https://bugs.webkit.org/show_bug.cgi?id=58886
1959
1960         * English.lproj/localizedStrings.js:
1961         * WebCore.gypi:
1962         * WebCore.vcproj/WebCore.vcproj:
1963         * inspector/front-end/NetworkItemView.js:
1964         (WebInspector.NetworkItemView):
1965         * inspector/front-end/Resource.js:
1966         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
1967         (WebInspector.Resource.prototype.hasErrorStatusCode):
1968         * inspector/front-end/ResourceHTMLView.js: Added.
1969         (WebInspector.ResourceHTMLView):
1970         (WebInspector.ResourceHTMLView.prototype.hasContent):
1971         (WebInspector.ResourceHTMLView.prototype.show):
1972         (WebInspector.ResourceHTMLView.prototype.hide):
1973         (WebInspector.ResourceHTMLView.prototype._createIFrame):
1974         * inspector/front-end/ResourcePreviewView.js: Added.
1975         (WebInspector.ResourcePreviewView):
1976         (WebInspector.ResourcePreviewView.prototype.hasContent):
1977         (WebInspector.ResourcePreviewView.prototype.show):
1978         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback):
1979         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
1980         (WebInspector.ResourcePreviewView.prototype._createInnerView):
1981         * inspector/front-end/Settings.js:
1982         (WebInspector.Settings):
1983         * inspector/front-end/WebKit.qrc:
1984         * inspector/front-end/inspector.css:
1985         (.resource-view.html iframe):
1986         * inspector/front-end/inspector.html:
1987
1988 2011-05-18  Pavel Podivilov  <podivilov@chromium.org>
1989
1990         Reviewed by Yury Semikhatsky.
1991
1992         Web Inspector: hide script location to ui location conversion details from ScriptsPanel.
1993         https://bugs.webkit.org/show_bug.cgi?id=61035
1994
1995         * inspector/front-end/DebuggerPresentationModel.js:
1996         (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
1997         (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation.didRequestSourceMapping):
1998         (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation):
1999         * inspector/front-end/ScriptsPanel.js:
2000         (WebInspector.ScriptsPanel.prototype.showAnchorLocation.didGetUILocation):
2001         (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
2002
2003 2011-06-08  Tommy Widenflycht  <tommyw@google.com>
2004
2005         Reviewed by Tony Gentilcore.
2006
2007         StreamEvent
2008
2009         Media Stream PeerConnection API: adding StreamEvent class
2010         https://bugs.webkit.org/show_bug.cgi?id=61537
2011
2012         Tests for the Media Stream API will be provided by the bug 56587.
2013
2014         * CMakeLists.txt:
2015         * CodeGenerators.pri:
2016         * DerivedSources.cpp:
2017         * DerivedSources.make:
2018         * GNUmakefile.list.am:
2019         * WebCore.gypi:
2020         * WebCore.pro:
2021         * WebCore.vcproj/WebCore.vcproj:
2022         * WebCore.xcodeproj/project.pbxproj:
2023         * bindings/js/JSEventCustom.cpp:
2024         (WebCore::toJS):
2025         * bindings/v8/custom/V8EventCustom.cpp:
2026         (WebCore::toV8):
2027         * dom/DOMAllInOne.cpp:
2028         * dom/Event.cpp:
2029         (WebCore::Event::isStreamEvent):
2030         * dom/Event.h:
2031         * dom/StreamEvent.cpp: Added.
2032         (WebCore::StreamEvent::create):
2033         (WebCore::StreamEvent::StreamEvent):
2034         (WebCore::StreamEvent::~StreamEvent):
2035         (WebCore::StreamEvent::initStreamEvent):
2036         (WebCore::StreamEvent::stream):
2037         * dom/StreamEvent.h: Added.
2038         (WebCore::StreamEvent::isStreamEvent):
2039         * dom/StreamEvent.idl: Added.
2040
2041 2011-06-08  Tommy Widenflycht  <tommyw@google.com>
2042
2043         Reviewed by Tony Gentilcore.
2044
2045         Media Stream API: integrate the Track List objects into the existing code.
2046         https://bugs.webkit.org/show_bug.cgi?id=60205
2047
2048         Tests for the Media Stream API will be provided by the bug 56587.
2049
2050         * dom/ExclusiveTrackList.cpp:
2051         (WebCore::ExclusiveTrackList::select):
2052         (WebCore::ExclusiveTrackList::trackFailed):
2053         * dom/ExclusiveTrackList.h:
2054         * dom/GeneratedStream.cpp:
2055         (WebCore::GeneratedStream::create):
2056         (WebCore::GeneratedStream::GeneratedStream):
2057         (WebCore::GeneratedStream::streamEnded):
2058         (WebCore::GeneratedStream::audioTracks):
2059         (WebCore::GeneratedStream::videoTracks):
2060         (WebCore::GeneratedStream::stop):
2061         * dom/GeneratedStream.h:
2062         * dom/GeneratedStream.idl:
2063         * dom/MultipleTrackList.cpp:
2064         (WebCore::MultipleTrackList::trackFailed):
2065         (WebCore::MultipleTrackList::enable):
2066         (WebCore::MultipleTrackList::disable):
2067         * dom/MultipleTrackList.h:
2068         * dom/Stream.h:
2069         * dom/TrackList.cpp:
2070         (WebCore::TrackList::clear):
2071         (WebCore::TrackList::associateStream):
2072         (WebCore::TrackList::associatedStreamLabel):
2073         (WebCore::TrackList::trackFailed):
2074         (WebCore::TrackList::scriptExecutionContext):
2075         * dom/TrackList.h:
2076         * page/MediaStreamClient.h:
2077         * page/MediaStreamController.cpp:
2078         (WebCore::MediaStreamController::enableAudioTrack):
2079         (WebCore::MediaStreamController::disableAudioTrack):
2080         (WebCore::MediaStreamController::selectVideoTrack):
2081         (WebCore::MediaStreamController::streamGenerated):
2082         (WebCore::MediaStreamController::audioTrackFailed):
2083         (WebCore::MediaStreamController::videoTrackFailed):
2084         * page/MediaStreamController.h:
2085         * page/MediaStreamFrameController.cpp:
2086         (WebCore::MediaStreamFrameController::unregister):
2087         (WebCore::MediaStreamFrameController::enterDetachedState):
2088         (WebCore::MediaStreamFrameController::disconnectFrame):
2089         (WebCore::MediaStreamFrameController::enableAudioTrack):
2090         (WebCore::MediaStreamFrameController::disableAudioTrack):
2091         (WebCore::MediaStreamFrameController::selectVideoTrack):
2092         (WebCore::MediaStreamFrameController::streamGenerated):
2093         (WebCore::MediaStreamFrameController::audioTrackFailed):
2094         (WebCore::MediaStreamFrameController::videoTrackFailed):
2095         * page/MediaStreamFrameController.h:
2096         (WebCore::MediaStreamFrameController::ClientBase::isGenericClient):
2097         (WebCore::MediaStreamFrameController::GenericClient::GenericClient):
2098         (WebCore::MediaStreamFrameController::GenericClient::~GenericClient):
2099         (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
2100         (WebCore::MediaStreamFrameController::GenericClient::unregister):
2101
2102 2011-06-08  Pavel Podivilov  <podivilov@chromium.org>
2103
2104         Reviewed by Yury Semikhatsky.
2105
2106         Web Inspector: [REGRESSION] breakpoints are not persisted.
2107         https://bugs.webkit.org/show_bug.cgi?id=62273
2108
2109         * inspector/front-end/Settings.js:
2110
2111 2011-06-08  Alexander Pavlov  <apavlov@chromium.org>
2112
2113         Reviewed by Yury Semikhatsky.
2114
2115         Web Inspector: node selection is slow in the Elements panel.
2116         https://bugs.webkit.org/show_bug.cgi?id=60813
2117
2118         Schedule full style updates rather than request all node styles from the backend immediately.
2119
2120         * inspector/front-end/StylesSidebarPane.js:
2121         (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
2122         (WebInspector.StylesSidebarPane.prototype.update):
2123
2124 2011-06-08  Andreas Kling  <andreas.kling@nokia.com>
2125
2126         Reviewed by Laszlo Gombos.
2127
2128         [Symbian] Float{32,64}Array and Int16Array fail to build.
2129         https://bugs.webkit.org/show_bug.cgi?id=62219
2130
2131         For some reason, RVCT 2.x is moaning about "class member designated by
2132         a using-declaration must be visible in a direct base class".
2133         Apply same fix as r69122 and r76592.
2134
2135         * html/canvas/Float32Array.h:
2136         (WebCore::Float32Array::set):
2137         * html/canvas/Float64Array.h:
2138         (WebCore::Float64Array::set):
2139         * html/canvas/Int16Array.h:
2140         (WebCore::Int16Array::set):
2141
2142 2011-06-08  Syed Idris Shah  <syed.idris-shah@nokia.com>
2143
2144         Reviewed by Andreas Kling.
2145
2146         [Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop WebGL
2147         https://bugs.webkit.org/show_bug.cgi?id=61945
2148
2149         For OpenGL ES we do not need these features. 
2150         These features are available via shaders in OpenGL ES. But for desktop WebGL using QtWebKit they should be enabled.
2151
2152         LayoutTests/fast/canvas/webgl/point-size.html
2153
2154         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2155         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
2156
2157 2011-06-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2158
2159         Unreviewed. Fix style error.
2160
2161         * platform/efl/RenderThemeEfl.cpp:
2162         * platform/efl/RenderThemeEfl.h:
2163
2164 2011-06-08  Hironori Bono  <hbono@chromium.org>
2165
2166         Reviewed by Brent Fulgham.
2167
2168         Add SpellCheck API
2169         https://bugs.webkit.org/show_bug.cgi?id=59693
2170
2171         This change adds two SpellCheck API functions (addSpellcheckRange and
2172         removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
2173         the public-webapps ML. This change is currently available only on Chromium.
2174
2175         Tests: editing/spelling/spellcheck-api-pixel.html
2176                editing/spelling/spellcheck-api.html
2177
2178         * WebCore.gypi:
2179         * bindings/generic/RuntimeEnabledFeatures.cpp:
2180         * bindings/generic/RuntimeEnabledFeatures.h:
2181         (WebCore::RuntimeEnabledFeatures::spellCheckAPIEnabled):
2182         (WebCore::RuntimeEnabledFeatures::setSpellCheckAPIEnabled):
2183         * dom/DocumentMarker.h:
2184         (WebCore::DocumentMarker::length):
2185         * dom/DocumentMarkerController.cpp:
2186         (WebCore::DocumentMarkerController::userSpellingMarkersForNode):
2187         (WebCore::DocumentMarkerController::addUserSpellingMarker):
2188         (WebCore::DocumentMarkerController::removeUserSpellingMarker):
2189         (WebCore::DocumentMarkerController::userSpellingNode):
2190         * dom/DocumentMarkerController.h:
2191         * html/HTMLDivElement.cpp:
2192         (WebCore::HTMLDivElement::spellcheckRanges):
2193         (WebCore::HTMLDivElement::addSpellcheckRange):
2194         (WebCore::HTMLDivElement::removeSpellcheckRange):
2195         * html/HTMLDivElement.h:
2196         * html/HTMLDivElement.idl:
2197         * html/HTMLInputElement.cpp:
2198         (WebCore::HTMLInputElement::spellcheckRanges):
2199         (WebCore::HTMLInputElement::addSpellcheckRange):
2200         (WebCore::HTMLInputElement::removeSpellcheckRange):
2201         * html/HTMLInputElement.h:
2202         * html/HTMLInputElement.idl:
2203         * html/HTMLTextAreaElement.cpp:
2204         (WebCore::HTMLTextAreaElement::spellcheckRanges):
2205         (WebCore::HTMLTextAreaElement::addSpellcheckRange):
2206         (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
2207         * html/HTMLTextAreaElement.h:
2208         * html/HTMLTextAreaElement.idl:
2209         * html/SpellcheckRange.cpp: Added.
2210         (WebCore::SpellcheckRange::SpellcheckRange):
2211         (WebCore::SpellcheckRange::~SpellcheckRange):
2212         * html/SpellcheckRange.h: Added.
2213         (WebCore::SpellcheckRange::create):
2214         (WebCore::SpellcheckRange::start):
2215         (WebCore::SpellcheckRange::length):
2216         (WebCore::SpellcheckRange::suggestions):
2217         (WebCore::SpellcheckRange::options):
2218         * html/SpellcheckRange.idl: Added.
2219         * html/SpellcheckRangeList.cpp: Added.
2220         (WebCore::SpellcheckRangeList::SpellcheckRangeList):
2221         (WebCore::SpellcheckRangeList::~SpellcheckRangeList):
2222         (WebCore::SpellcheckRangeList::item):
2223         * html/SpellcheckRangeList.h: Added.
2224         (WebCore::SpellcheckRangeList::create):
2225         (WebCore::SpellcheckRangeList::isEmpty):
2226         (WebCore::SpellcheckRangeList::clear):
2227         (WebCore::SpellcheckRangeList::append):
2228         (WebCore::SpellcheckRangeList::remove):
2229         (WebCore::SpellcheckRangeList::length):
2230         * html/SpellcheckRangeList.idl: Added.
2231         * rendering/InlineTextBox.cpp:
2232         (WebCore::textCheckingLineStyleForMarkerType):
2233         (WebCore::InlineTextBox::paintDocumentMarkers):
2234
2235 2011-06-07  Andrey Kosyakov  <caseq@chromium.org>
2236
2237         Reviewed by Pavel Feldman.
2238
2239         Web Inspector: remove shadow dom inspection from Elements panel by default.
2240         https://bugs.webkit.org/show_bug.cgi?id=62188
2241
2242         This reverts r85751
2243
2244         * dom/Element.cpp:
2245         (WebCore::Element::ensureShadowRoot):
2246         (WebCore::Element::removeShadowRoot):
2247         * inspector/Inspector.json:
2248         * inspector/InspectorDOMAgent.cpp:
2249         (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
2250         (WebCore::InspectorDOMAgent::buildObjectForNode):
2251         (WebCore::InspectorDOMAgent::didInsertDOMNode):
2252         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
2253         * inspector/InspectorDOMAgent.h:
2254         * inspector/front-end/DOMAgent.js:
2255         (WebInspector.DOMNode):
2256         (WebInspector.DOMNode.prototype._renumber):
2257         (WebInspector.DOMAgent.prototype._bindNodes):
2258         (WebInspector.DOMAgent.prototype.querySelectorAll):
2259         (WebInspector.DOMDispatcher.prototype.searchResults):
2260         * inspector/front-end/ElementsPanel.js:
2261         (WebInspector.ElementsPanel):
2262         (WebInspector.ElementsPanel.prototype._attributesUpdated):
2263         (WebInspector.ElementsPanel.prototype._characterDataModified):
2264         (WebInspector.ElementsPanel.prototype._nodeInserted):
2265         (WebInspector.ElementsPanel.prototype._nodeRemoved):
2266         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
2267         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
2268         * inspector/front-end/ElementsTreeOutline.js:
2269         (WebInspector.ElementsTreeElement):
2270         (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
2271         (WebInspector.ElementsTreeElement.prototype._updateChildren):
2272         ():
2273         * inspector/front-end/inspector.css:
2274         * inspector/front-end/utilities.js:
2275         (Element.prototype.query):
2276
2277 2011-06-08  Mark Rowe  <mrowe@apple.com>
2278
2279         Fix the build.
2280
2281         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2282         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
2283         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
2284
2285 2011-06-07  Keishi Hattori  <keishi@webkit.org>
2286
2287         Reviewed by Kent Tamura.
2288
2289         Rename HTMLInputElement::m_value to m_valueIfDirty
2290         https://bugs.webkit.org/show_bug.cgi?id=61990
2291
2292         No new tests because no behavior change.
2293
2294         * html/HTMLInputElement.cpp: Replaced m_value with m_valueIfDirty.
2295         (WebCore::HTMLInputElement::tooLong):
2296         (WebCore::HTMLInputElement::updateType):
2297         (WebCore::HTMLInputElement::parseMappedAttribute):
2298         (WebCore::HTMLInputElement::copyNonAttributeProperties):
2299         (WebCore::HTMLInputElement::value):
2300         (WebCore::HTMLInputElement::setValue):
2301         (WebCore::HTMLInputElement::setValueFromRenderer):
2302         (WebCore::HTMLInputElement::updateValueIfNeeded):
2303         * html/HTMLInputElement.h: Renamed m_value to m_valueIfDirty.
2304         (WebCore::HTMLInputElement::hasDirtyValue): Added. Returns the dirty value flag.
2305
2306 2011-06-07  Ian Henderson  <ianh@apple.com>
2307
2308         Reviewed by Dan Bernstein.
2309
2310         (CG) Sub-image drawing clips unnecessarily
2311         https://bugs.webkit.org/show_bug.cgi?id=62258
2312
2313         If destRect completely encompasses the adjustedDestRect into which we
2314         draw, clipping to destRect will do nothing.  Skip the call to
2315         CGContextClipToRect in this case.
2316
2317         * platform/graphics/cg/ImageCG.cpp:
2318         (WebCore::BitmapImage::draw):
2319
2320 2011-06-07  Emil A Eklund  <eae@chromium.org>
2321
2322         Reviewed by Eric Seidel.
2323
2324         Convert nodeAtPoint to IntPoint
2325         https://bugs.webkit.org/show_bug.cgi?id=62145
2326
2327         Convert nodeAtPoint to take an IntPoint instead of a pair of ints for the
2328         accumulated offset.
2329
2330         Covered by existing tests.
2331
2332         * platform/graphics/FloatPoint.h:
2333         (WebCore::FloatPoint::moveBy):
2334         Add moveBy(IntPoint) method
2335         
2336         * rendering/EllipsisBox.cpp:
2337         (WebCore::EllipsisBox::nodeAtPoint):
2338         * rendering/EllipsisBox.h:
2339         * rendering/InlineBox.cpp:
2340         (WebCore::InlineBox::nodeAtPoint):
2341         * rendering/InlineBox.h:
2342         * rendering/InlineFlowBox.cpp:
2343         (WebCore::InlineFlowBox::nodeAtPoint):
2344         * rendering/InlineFlowBox.h:
2345         * rendering/InlineTextBox.cpp:
2346         (WebCore::InlineTextBox::nodeAtPoint):
2347         * rendering/InlineTextBox.h:
2348         * rendering/RenderBlock.cpp:
2349         (WebCore::RenderBlock::nodeAtPoint):
2350         (WebCore::RenderBlock::hitTestContents):
2351         * rendering/RenderBlock.h:
2352         * rendering/RenderBox.cpp:
2353         (WebCore::RenderBox::nodeAtPoint):
2354         * rendering/RenderBox.h:
2355         * rendering/RenderFrameSet.cpp:
2356         (WebCore::RenderFrameSet::nodeAtPoint):
2357         * rendering/RenderFrameSet.h:
2358         * rendering/RenderImage.cpp:
2359         (WebCore::RenderImage::nodeAtPoint):
2360         * rendering/RenderImage.h:
2361         * rendering/RenderInline.cpp:
2362         (WebCore::RenderInline::nodeAtPoint):
2363         * rendering/RenderInline.h:
2364         * rendering/RenderLineBoxList.cpp:
2365         (WebCore::RenderLineBoxList::hitTest):
2366         * rendering/RenderListBox.cpp:
2367         (WebCore::RenderListBox::nodeAtPoint):
2368         * rendering/RenderListBox.h:
2369         * rendering/RenderObject.cpp:
2370         (WebCore::RenderObject::hitTest):
2371         * rendering/RenderObject.h:
2372         * rendering/RenderTable.cpp:
2373         (WebCore::RenderTable::nodeAtPoint):
2374         * rendering/RenderTable.h:
2375         * rendering/RenderTableRow.cpp:
2376         (WebCore::RenderTableRow::nodeAtPoint):
2377         * rendering/RenderTableRow.h:
2378         * rendering/RenderTableSection.cpp:
2379         (WebCore::RenderTableSection::nodeAtPoint):
2380         * rendering/RenderTableSection.h:
2381         * rendering/RenderText.h:
2382         (WebCore::RenderText::nodeAtPoint):
2383         * rendering/RenderTextControlMultiLine.cpp:
2384         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2385         * rendering/RenderTextControlMultiLine.h:
2386         * rendering/RenderTextControlSingleLine.cpp:
2387         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
2388         * rendering/RenderTextControlSingleLine.h:
2389         * rendering/RenderWidget.cpp:
2390         (WebCore::RenderWidget::nodeAtPoint):
2391         * rendering/RenderWidget.h:
2392         * rendering/RootInlineBox.cpp:
2393         (WebCore::RootInlineBox::nodeAtPoint):
2394         * rendering/RootInlineBox.h:
2395         * rendering/svg/RenderSVGForeignObject.cpp:
2396         (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
2397         (WebCore::RenderSVGForeignObject::nodeAtPoint):
2398         * rendering/svg/RenderSVGForeignObject.h:
2399         * rendering/svg/RenderSVGModelObject.cpp:
2400         (WebCore::RenderSVGModelObject::nodeAtPoint):
2401         * rendering/svg/RenderSVGModelObject.h:
2402         * rendering/svg/RenderSVGRoot.cpp:
2403         (WebCore::RenderSVGRoot::nodeAtPoint):
2404         * rendering/svg/RenderSVGRoot.h:
2405         * rendering/svg/RenderSVGText.cpp:
2406         (WebCore::RenderSVGText::nodeAtFloatPoint):
2407         (WebCore::RenderSVGText::nodeAtPoint):
2408         * rendering/svg/RenderSVGText.h:
2409
2410 2011-06-07  Yi Shen  <yi.4.shen@nokia.com>
2411
2412         Reviewed by Simon Hausmann.
2413
2414         [Qt] Fix the error code for media resource failures when using QtMobility
2415         https://bugs.webkit.org/show_bug.cgi?id=55901
2416
2417         To indicate the media resource failures, set the network state to
2418         MediaPlayer::FormatError when receives QMediaPlayer::InvalidMedia or
2419         QMediaPlayer::ResourceError.
2420
2421         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
2422         (WebCore::MediaPlayerPrivateQt::updateStates):
2423
2424 2011-06-07  Emil A Eklund  <eae@chromium.org>
2425
2426         Reviewed by Eric Seidel.
2427
2428         Change RenderBlock::hitTestFloats to IntPoint
2429         https://bugs.webkit.org/show_bug.cgi?id=62176
2430
2431         Covered by existing tests.
2432
2433         * rendering/RenderBlock.cpp:
2434         (WebCore::RenderBlock::nodeAtPoint):
2435         (WebCore::RenderBlock::hitTestFloats):
2436         (WebCore::RenderBlock::hitTestColumns):
2437         * rendering/RenderBlock.h:
2438
2439 2011-06-07  Tim Horton  <timothy_horton@apple.com>
2440
2441         Reviewed by Alexey Proskuryakov.
2442
2443         Use correct CFURLStorageSessionRef definition on Snow Leopard
2444         https://bugs.webkit.org/show_bug.cgi?id=62223
2445
2446         * platform/mac/WebCoreSystemInterface.h:
2447         * platform/network/ResourceHandle.h:
2448         * platform/network/cf/ResourceRequest.h:
2449
2450 2011-06-07  Emil A Eklund  <eae@chromium.org>
2451
2452         Reviewed by Eric Seidel.
2453
2454         Change RenderBlock::hitTestColumns to IntPoint
2455         https://bugs.webkit.org/show_bug.cgi?id=62172
2456
2457         Covered by existing tests.
2458
2459         * rendering/RenderBlock.cpp:
2460         (WebCore::RenderBlock::nodeAtPoint):
2461         (WebCore::RenderBlock::hitTestColumns):
2462         * rendering/RenderBlock.h:
2463
2464 2011-06-07  Simon Fraser  <simon.fraser@apple.com>
2465
2466         Reviewed by Darin Adler.
2467
2468         Opacity transition doesn't work while content property is set.
2469         https://bugs.webkit.org/show_bug.cgi?id=59301
2470         
2471         StyleRareNonInheritedData's copy constructor omitted to copy
2472         the m_content data, which caused us to detach and re-attach the renderer
2473         at the start of the transition, thereby killing the transition.
2474         
2475         Fix by making StyleRareNonInheritedData's copy ctor do the right thing.
2476
2477         Test: transitions/transition-on-element-with-content.html
2478
2479         * rendering/style/ContentData.h:
2480         * rendering/style/ContentData.cpp:
2481         (WebCore::ContentData::clone): New method to do a deep clone. (Can't use a copy
2482         ctor because of the subclasses.)
2483         * rendering/style/CounterDirectives.h: Pack the data members to save space.
2484         Add a clone() function for the HashMap.
2485         * rendering/style/CounterDirectives.cpp:
2486         (WebCore::clone): Make a new HashMap and copy the contents over.
2487         * rendering/style/StyleRareNonInheritedData.cpp:
2488         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Copy
2489         the content and counter directives over.
2490         (WebCore::StyleRareNonInheritedData::operator==): Rather than just comparing
2491         for pointer equality, do a correct check for m_counterDirectives equality.
2492         (WebCore::StyleRareNonInheritedData::counterDataEquivalent):
2493         * rendering/style/StyleRareNonInheritedData.h:
2494
2495 2011-06-07  Robert Kroeger  <rjkroege@chromium.org>
2496
2497         Reviewed by Adam Barth.
2498
2499         [chromium] Add a basic gesture recognizer to the Chromium platform
2500         https://bugs.webkit.org/show_bug.cgi?id=54417
2501
2502         Adds a basic gesture recognizer to the Chromium platform. Adds an entry
2503         point to the GestureRecognizer to reset any internal state on a page reset.
2504         Resetting the gesture recognizer on page load is necesary for reliable
2505         layout test execution and improves gesture recognizer operational
2506         robustness.
2507
2508         Added an additional constructor to permit building a synthetic
2509         PlatformWheelEvent.
2510
2511         Small modifications to the PlatformGestureRecognizer as required to
2512         implement the simple Chromium platform gesture recognizer.
2513
2514         Tests: fast/events/touch/touch-gesture-click.html
2515
2516         * WebCore.gypi:
2517         * page/EventHandler.cpp:
2518         (WebCore::EventHandler::resetGestureRecognizer):
2519         * page/EventHandler.h:
2520         * page/FrameView.cpp:
2521         (WebCore::FrameView::reset):
2522         * platform/PlatformGestureRecognizer.h:
2523         * platform/PlatformWheelEvent.h:
2524         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2525         * platform/chromium/GestureRecognizerChromium.cpp: Added.
2526         (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
2527         (WebCore::InnerGestureRecognizer::reset):
2528         (WebCore::InnerGestureRecognizer::~InnerGestureRecognizer):
2529         (WebCore::InnerGestureRecognizer::addEdgeFunction):
2530         (WebCore::InnerGestureRecognizer::isInClickTimeWindow):
2531         (WebCore::InnerGestureRecognizer::isInsideManhattanSquare):
2532         (WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
2533         (WebCore::InnerGestureRecognizer::processTouchEventForGesture):
2534         (WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
2535         (WebCore::InnerGestureRecognizer::updateValues):
2536         (WebCore::InnerGestureRecognizer::signature):
2537         (WebCore::touchDown):
2538         (WebCore::noGesture):
2539         (WebCore::click):
2540         (WebCore::isClickOrScroll):
2541         (WebCore::inScroll):
2542         (WebCore::PlatformGestureRecognizer::create):
2543         (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer):
2544         (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer):
2545         (WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
2546         (WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
2547         * platform/chromium/GestureRecognizerChromium.h: Added.
2548         (WebCore::InnerGestureRecognizer::setState):
2549         (WebCore::InnerGestureRecognizer::state):
2550         (WebCore::GestureRecognizerChromium::reset):
2551         (WebCore::GestureRecognizerChromium::processTouchEventForGesture):
2552
2553 2011-06-07  No'am Rosenthal  <noam.rosenthal@nokia.com>
2554
2555         Reviewed by Andreas Kling.
2556
2557         [Texmap][Qt] Enable TextureMapper by default
2558         https://bugs.webkit.org/show_bug.cgi?id=61740
2559
2560         Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
2561         for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.
2562
2563         No new functionality so no new tests.
2564
2565         * WebCore.pri:
2566         * WebCore.pro:
2567         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2568         * platform/graphics/qt/TextureMapperQt.cpp:
2569         (WebCore::TextureMapper::create):
2570
2571 2011-06-07  Emil A Eklund  <eae@chromium.org>
2572
2573         Reviewed by Eric Seidel.
2574
2575         Convert RenderBox::absoluteRects to IntPoint
2576         https://bugs.webkit.org/show_bug.cgi?id=62130
2577
2578         Covered by existing tests.
2579
2580         * dom/Node.cpp:
2581         (WebCore::Node::hasNonEmptyBoundingBox):
2582         * rendering/InlineBox.h:
2583         (WebCore::InlineBox::size):
2584         * rendering/RenderBlock.cpp:
2585         (WebCore::RenderBlock::absoluteRects):
2586         * rendering/RenderBlock.h:
2587         * rendering/RenderBox.cpp:
2588         (WebCore::RenderBox::absoluteRects):
2589         * rendering/RenderBox.h:
2590         * rendering/RenderInline.cpp:
2591         (WebCore::RenderInline::absoluteRects):
2592         * rendering/RenderInline.h:
2593         * rendering/RenderObject.cpp:
2594         (WebCore::RenderObject::absoluteBoundingBoxRect):
2595         * rendering/RenderObject.h:
2596         (WebCore::RenderObject::absoluteRects):
2597         * rendering/RenderText.cpp:
2598         (WebCore::RenderText::absoluteRects):
2599         * rendering/RenderText.h:
2600         * rendering/RenderView.cpp:
2601         (WebCore::RenderView::absoluteRects):
2602         * rendering/RenderView.h:
2603         * rendering/svg/RenderSVGBlock.cpp:
2604         (WebCore::RenderSVGBlock::absoluteRects):
2605         * rendering/svg/RenderSVGBlock.h:
2606         * rendering/svg/RenderSVGModelObject.cpp:
2607         (WebCore::RenderSVGModelObject::absoluteRects):
2608         * rendering/svg/RenderSVGModelObject.h:
2609
2610 2011-06-07  Kent Tamura  <tkent@chromium.org>
2611
2612         Reviewed by Andreas Kling.
2613
2614         [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style.
2615         https://bugs.webkit.org/show_bug.cgi?id=62207
2616
2617         * css/mediaControlsQt.css: Add comments.
2618         (audio::-webkit-media-controls-timeline):
2619         (video::-webkit-media-controls-timeline):
2620         (audio::-webkit-media-controls-volume-slider):
2621         (video::-webkit-media-controls-volume-slider):
2622         * platform/qt/RenderThemeQt.cpp: Use fixed values to avoid referring to o->parent().
2623         (WebCore::RenderThemeQt::adjustSliderThumbSize):
2624
2625 2011-06-07  Sailesh Agrawal  <sail@chromium.org>
2626
2627         Reviewed by Mihai Parparita.
2628
2629         Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support
2630         https://bugs.webkit.org/show_bug.cgi?id=59753
2631
2632         No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.
2633
2634         * WebCore.gyp/WebCore.gyp: Added IntPointMac.mm. This is used by some functions in ScrollAnimatorChromiumMac. Also added filters for conflicting class names in ScrollAnimatorChromiumMac.
2635         * WebCore.gypi: Added ScrollAnimatorChromiumMac.h/mm.
2636         * platform/ScrollAnimator.cpp: Extended the #ifdef around ScrollAnimator::create() so that the chromium version will be created.
2637         * platform/chromium/ScrollAnimatorChromiumMac.h: Added.
2638         (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer):
2639         (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer):
2640         (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
2641         * platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. Stubbed out ScrollAnimatorChromiumMac::scroll() if smooth scrolling is disabled.
2642         (abs):
2643         (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
2644         (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]):
2645         (-[ScrollAnimationHelperDelegate bounds]):
2646         (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
2647         (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
2648         (-[ScrollAnimationHelperDelegate convertSizeToBase:]):
2649         (-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
2650         (-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
2651         (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
2652         (-[ScrollAnimationHelperDelegate superview]):
2653         (-[ScrollAnimationHelperDelegate documentView]):
2654         (-[ScrollAnimationHelperDelegate window]):
2655         (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
2656         (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
2657         (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
2658         (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
2659         (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
2660         (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
2661         (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
2662         (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
2663         (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
2664         (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
2665         (-[ScrollbarPartAnimation setCurrentProgress:]):
2666         (-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
2667         (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
2668         (-[ScrollbarPainterDelegate cancelAnimations]):
2669         (-[ScrollbarPainterDelegate convertRectToBacking:]):
2670         (-[ScrollbarPainterDelegate convertRectFromBacking:]):
2671         (-[ScrollbarPainterDelegate layer]):
2672         (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
2673         (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
2674         (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
2675         (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
2676         (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
2677         (WebCore::ScrollAnimator::create):
2678         (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
2679         (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
2680         (WebCore::ScrollAnimatorChromiumMac::scroll):
2681         (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation):
2682         (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary):
2683         (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary):
2684         (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary):
2685         (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
2686         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
2687         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
2688         (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
2689         (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
2690         (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
2691         (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
2692         (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
2693         (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
2694         (WebCore::ScrollAnimatorChromiumMac::contentsResized):
2695         (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
2696         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
2697         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
2698         (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
2699         (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
2700         (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
2701         (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
2702         (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
2703         (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
2704         (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
2705         (WebCore::elasticDeltaForTimeDelta):
2706         (WebCore::elasticDeltaForReboundDelta):
2707         (WebCore::reboundDeltaForElasticDelta):
2708         (WebCore::scrollWheelMultiplier):
2709         (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
2710         (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):
2711         (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection):
2712         (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching):
2713         (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching):
2714         (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
2715         (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
2716         (WebCore::ScrollAnimatorChromiumMac::endScrollGesture):
2717         (WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
2718         (WebCore::roundTowardZero):
2719         (WebCore::roundToDevicePixelTowardZero):
2720         (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
2721         (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer):
2722         (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive):
2723         (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer):
2724         (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
2725         (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
2726         * platform/graphics/IntPoint.h: Exposed NSPoint conversion routines to chromium mac.
2727
2728 2011-06-07  Sam Weinig  <sam@webkit.org>
2729
2730         Reviewed by Anders Carlsson.
2731
2732         Remove repeated IPC traffic from SetRenderTreeSize message
2733         https://bugs.webkit.org/show_bug.cgi?id=62244
2734
2735         * WebCore.xcodeproj/project.pbxproj:
2736         Make RenderArena.h private so it can be called from WebKit2.
2737
2738         * loader/FrameLoaderClient.h:
2739         (WebCore::FrameLoaderClient::dispatchDidLayout):
2740         Added.
2741
2742         * page/ChromeClient.h:
2743         Remove setRenderTreeSize.
2744
2745         * page/FrameView.cpp:
2746         (WebCore::FrameView::performPostLayoutTasks):
2747         Call dispatchDidLayout for all frames instead of calling setRenderTreeSize
2748         for the main frame.
2749
2750 2011-06-07  Emil A Eklund  <eae@chromium.org>
2751
2752         Reviewed by Eric Seidel.
2753
2754         Change RenderBlock::hitTestContents to IntPoint
2755         https://bugs.webkit.org/show_bug.cgi?id=62170
2756
2757         Covered by existing tests.
2758
2759         * rendering/RenderBlock.cpp:
2760         (WebCore::RenderBlock::nodeAtPoint):
2761         (WebCore::RenderBlock::hitTestColumns):
2762         (WebCore::RenderBlock::hitTestContents):
2763         * rendering/RenderBlock.h:
2764
2765 2011-06-07  Jer Noble  <jer.noble@apple.com>
2766
2767         Reviewed by Eric Carlson.
2768
2769         Video with poster attribute will not display new frames when scrubbing.
2770         https://bugs.webkit.org/show_bug.cgi?id=62036
2771
2772         Remove our "detection" about the end of a scrub now that there is an explicit seek completion
2773         handler available in AVFoundation.  Move what we used to do upon detection in timeChanged()
2774         into seekCompleted().
2775
2776         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2777         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): 
2778         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
2779
2780 2011-06-07  James Simonsen  <simonjam@chromium.org>
2781
2782         Unreviewed, build fix, missing files from r88274.
2783
2784         * bindings/v8/ChildThreadDOMData.cpp: Added.
2785         (WebCore::ChildThreadDOMData::ChildThreadDOMData):
2786         (WebCore::ChildThreadDOMData::getStore):
2787         * bindings/v8/ChildThreadDOMData.h: Added.
2788         * bindings/v8/MainThreadDOMData.cpp: Added.
2789         (WebCore::MainThreadDOMData::MainThreadDOMData):
2790         (WebCore::MainThreadDOMData::getCurrent):
2791         (WebCore::MainThreadDOMData::getMainThreadStore):
2792         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
2793         * bindings/v8/MainThreadDOMData.h: Added.
2794         (WebCore::MainThreadDOMData::getStore):
2795
2796 2011-06-07  Abhishek Arya  <inferno@chromium.org>
2797
2798         Reviewed by Dan Bernstein.
2799
2800         Replicate WidthIterator.cpp fix from r88139.
2801         https://bugs.webkit.org/show_bug.cgi?id=62238
2802
2803         No new tests. Covered by existing layout tests on XP debug bots.
2804
2805         * platform/graphics/win/UniscribeController.cpp:
2806         (WebCore::UniscribeController::advance):
2807
2808 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2809
2810         Unreviewed, rolling out r88221, r88224, and r88231.
2811         http://trac.webkit.org/changeset/88221
2812         http://trac.webkit.org/changeset/88224
2813         http://trac.webkit.org/changeset/88231
2814         https://bugs.webkit.org/show_bug.cgi?id=62233
2815
2816         assert failure on chromium linux debug (Requested by simonjam
2817         on #webkit).
2818
2819         * WebCore.gypi:
2820         * WebCore.pro:
2821         * bindings/v8/ChildThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2822         (WebCore::ChildThreadDOMData::ChildThreadDOMData):
2823         (WebCore::ChildThreadDOMData::getStore):
2824         * bindings/v8/ChildThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2825         * bindings/v8/DOMData.cpp:
2826         (WebCore::DOMData::DOMData):
2827         (WebCore::DOMData::getCurrent):
2828         * bindings/v8/DOMData.h:
2829         (WebCore::DOMData::owningThread):
2830         (WebCore::DOMData::handleWeakObject):
2831         * bindings/v8/DOMDataStore.cpp:
2832         (WebCore::DOMDataStore::DOMDataStore):
2833         (WebCore::DOMDataStore::~DOMDataStore):
2834         (WebCore::DOMDataStore::allStoresMutex):
2835         (WebCore::DOMDataStore::weakNodeCallback):
2836         * bindings/v8/DOMDataStore.h:
2837         * bindings/v8/MainThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2838         (WebCore::MainThreadDOMData::MainThreadDOMData):
2839         (WebCore::MainThreadDOMData::getCurrent):
2840         (WebCore::MainThreadDOMData::getMainThreadStore):
2841         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
2842         * bindings/v8/MainThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2843         (WebCore::MainThreadDOMData::getStore):
2844         * bindings/v8/V8DOMMap.cpp:
2845         (WebCore::getDOMDataStore):
2846         (WebCore::removeAllDOMObjectsInCurrentThread):
2847         (WebCore::visitDOMNodesInCurrentThread):
2848         (WebCore::visitDOMObjectsInCurrentThread):
2849         (WebCore::visitActiveDOMObjectsInCurrentThread):
2850         (WebCore::visitDOMSVGElementInstancesInCurrentThread):
2851         * bindings/v8/V8DOMMap.h:
2852         * bindings/v8/V8GCController.cpp:
2853         (WebCore::V8GCController::gcPrologue):
2854         (WebCore::V8GCController::gcEpilogue):
2855         * bindings/v8/WorkerScriptController.cpp:
2856         (WebCore::WorkerScriptController::~WorkerScriptController):
2857
2858 2011-06-07  Simon Fraser  <simon.fraser@apple.com>
2859
2860         Reviewed by Dave Hyatt.
2861
2862         Clean up ContentData
2863         https://bugs.webkit.org/show_bug.cgi?id=62185
2864
2865         ContentData did manual ref()/deref() and had a lot of awkward
2866         code from using a union to store data.
2867         
2868         Clean this up by adding ContentData subclasses for different
2869         content types, which are then able to use RefPtr and OwnPtr
2870         as appropriate.
2871
2872         * css/CSSComputedStyleDeclaration.cpp:
2873         (WebCore::contentToCSSValue): Cast to different ContentData types as
2874         appropriate.
2875
2876         * css/CSSStyleSelector.cpp: 
2877         (WebCore::CSSStyleSelector::loadPendingImages): Cast to ImageContentData, and do some
2878         const gyrations.
2879
2880         * html/HTMLBRElement.cpp:
2881         (WebCore::HTMLBRElement::createRenderer): Use hasContent().
2882         * html/HTMLFrameSetElement.cpp:
2883         (WebCore::HTMLFrameSetElement::createRenderer): Ditto
2884         * html/HTMLImageElement.cpp:
2885         (WebCore::HTMLImageElement::createRenderer): Ditto
2886         * rendering/RenderObject.cpp:
2887         (WebCore::RenderObject::createObject): Cast to ImageContentData.
2888         * rendering/RenderObjectChildList.cpp:
2889         (WebCore::RenderObjectChildList::updateBeforeAfterContent): Cast to different ContentData types as
2890         appropriate.
2891
2892         * rendering/style/ContentData.h:
2893         (WebCore::ContentData::~ContentData):
2894         (WebCore::ContentData::isCounter):
2895         (WebCore::ContentData::isImage):
2896         (WebCore::ContentData::isQuote):
2897         (WebCore::ContentData::isText):
2898         (WebCore::ContentData::next):
2899         (WebCore::ContentData::setNext):
2900         (WebCore::ImageContentData::image):
2901         (WebCore::ImageContentData::setImage):
2902         (WebCore::ImageContentData::ImageContentData):
2903         (WebCore::ImageContentData::type):
2904         (WebCore::ImageContentData::isImage):
2905         (WebCore::TextContentData::text):
2906         (WebCore::TextContentData::setText):
2907         (WebCore::TextContentData::TextContentData):
2908         (WebCore::TextContentData::type):
2909         (WebCore::TextContentData::isText):
2910         (WebCore::CounterContentData::counter):
2911         (WebCore::CounterContentData::setCounter):
2912         (WebCore::CounterContentData::CounterContentData):
2913         (WebCore::CounterContentData::type):
2914         (WebCore::CounterContentData::isCounter):
2915         (WebCore::QuoteContentData::quote):
2916         (WebCore::QuoteContentData::setQuote):
2917         (WebCore::QuoteContentData::QuoteContentData):
2918         (WebCore::QuoteContentData::type):
2919         (WebCore::QuoteContentData::isQuote):
2920         Add subclasses for different content types, which are created
2921         via overloaded create() methods on the base class.
2922
2923         * rendering/style/ContentData.cpp:
2924         (WebCore::ContentData::create):
2925         (WebCore::operator==): Test for type equality, followed by comparing data.
2926         (WebCore::operator!=):
2927
2928         * rendering/style/RenderStyle.cpp:
2929         (WebCore::RenderStyle::clearContent):
2930         (WebCore::RenderStyle::appendContent): 
2931         (WebCore::RenderStyle::setContent): Replace the overly complex prepareToSetContent()
2932         code with code that either appends, or replaces the content.
2933         This loses an optimization where the existing ContentData object could get reused,
2934         but this seems to be rarely hit in practice.
2935         * rendering/style/RenderStyle.h:
2936         (WebCore::InheritedFlags::hasContent): Convenience method.
2937         * rendering/style/StyleRareNonInheritedData.cpp:
2938         (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Test
2939         that the pointers are non-null, then use the != operator.
2940         * rendering/style/StyleRareNonInheritedData.h: ContentData is a class now.
2941
2942 2011-06-07  Brian Weinstein  <bweinstein@apple.com>
2943
2944         Build fix after r88260.
2945
2946         * platform/graphics/win/FontCacheWin.cpp:
2947         (WebCore::FontCache::getFontDataForCharacters): Update to use enum instead of bool.
2948         * platform/graphics/wince/FontCacheWinCE.cpp:
2949
2950 2011-06-07  Rob Buis  <rbuis@rim.com>
2951
2952         Reviewed by Dirk Schulze.
2953
2954         stroke-dasharray does not handle "none"
2955         https://bugs.webkit.org/show_bug.cgi?id=62203
2956
2957         Use the initial strokeDashArray style for stroke-dasharray="none" to apply to SVGRenderStyle rather than bailing out.
2958
2959         Tests: svg/W3C-SVG-1.1-SE/styling-css-04-f.svg
2960                svg/custom/invalid-dasharray.svg
2961
2962         * css/SVGCSSStyleSelector.cpp:
2963         (WebCore::CSSStyleSelector::applySVGProperty):
2964
2965 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2966
2967         Unreviewed, rolling out r88259 and r88263.
2968         http://trac.webkit.org/changeset/88259
2969         http://trac.webkit.org/changeset/88263
2970         https://bugs.webkit.org/show_bug.cgi?id=62228
2971
2972         broke builds (Requested by rniwa on #webkit).
2973
2974         * platform/mac/WebCoreSystemInterface.h:
2975         * platform/network/ResourceHandle.h:
2976         * platform/network/cf/ResourceRequest.h:
2977
2978 2011-06-07  Emil A Eklund  <eae@chromium.org>
2979
2980         Reviewed by Eric Seidel.
2981
2982         Switch ContainerNode to use IntPoint
2983         https://bugs.webkit.org/show_bug.cgi?id=61893
2984
2985         Covered by existing tests.
2986
2987         * dom/ContainerNode.cpp:
2988         (WebCore::ContainerNode::getUpperLeftCorner):
2989         (WebCore::ContainerNode::getLowerRightCorner):
2990         (WebCore::ContainerNode::getRect):
2991         Change to use maxX/maxY instead of x+width/y+height
2992         
2993         * platform/graphics/FloatPoint.h:
2994         (WebCore::FloatPoint::move):
2995         (WebCore::FloatPoint::moveBy):
2996         (WebCore::FloatPoint::expandedTo):
2997         Add move, moveBy and expandedTo mirroring the IntPoint implementation of the same.
2998
2999 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
3000
3001         Speculative build fix after r88259.
3002
3003         * platform/network/cf/ResourceRequest.h:
3004
3005 2011-06-07  Michael Saboff  <msaboff@apple.com>
3006
3007         Reviewed by Geoffrey Garen.
3008
3009         Need to enable font cache purging in MemoryPressureHandler
3010         https://bugs.webkit.org/show_bug.cgi?id=62060
3011
3012         Improve memory usage under pressure.
3013         Added call to fontCache()->purgeInactiveFontData() in 
3014         MemoryPressureHandler::respondToMemoryPressure().  Added protection to 
3015         MemoryPressureHandler::install() being called multiple times.
3016
3017         No new tests as funtionality wasn't changed.
3018
3019         * platform/MemoryPressureHandler.cpp:
3020         (WebCore::MemoryPressureHandler::MemoryPressureHandler):
3021         * platform/MemoryPressureHandler.h:
3022         * platform/mac/MemoryPressureHandlerMac.mm:
3023         (WebCore::MemoryPressureHandler::install):
3024         (WebCore::MemoryPressureHandler::respondToMemoryPressure):
3025
3026 2011-06-07  Michael Saboff  <msaboff@apple.com>
3027
3028         Reviewed by Geoffrey Garen.
3029
3030         Fonts returned by FontCache::getFontDataForCharacters() are never released
3031         https://bugs.webkit.org/show_bug.cgi?id=61875
3032
3033         This change allows fonts allocated as system fallback fonts to be 
3034         released.  Previously, the reference counts for these fonts grew 
3035         without bound.  This is implemented as an auto release class that wraps
3036         accesses to the cache for system fallback fonts. All such accesses are
3037         via the method FontCache::getFontDataForCharacters. The new class is
3038         called FontCachePurgePreventer. When such an object exists, it protects
3039         these fonts from deletion.
3040
3041         Most accesses to the font cache still use the reference counting
3042         implemented by FontCache::getCacheFontData() and 
3043         FontCache::releaseFontData() and that operation is not affected by
3044         this change.
3045
3046         Added local scoped instance of FontCachePurgePreventer to wrap code
3047         that directly or indirectly accesses fonts via getFontDataForCharacters.
3048         Did a few other miscellaneous bug fixes and changes to allow system
3049         fallback fonts to be pruned from the GlyphPageTree. Changed the
3050         calls to getFontData in the platform specific versions of
3051         Fontcache::getFontDataForCharacters to not increment the reference
3052         count.  Moved the purge font check
3053         outside of FontCache::getCachedFontData() into a separate method, 
3054         purgeInactiveFontDataIfNeeded() since almost all calls to 
3055         getCachedFontData() now happen when purging is not allowed.
3056         purgeInactiveFontDataIfNeeded is invoked in enablePurging() when
3057         m_purgePreventCount is 0.
3058
3059         No new test as the functionality has not changed. Improved font life
3060         cycle management.
3061
3062         * WebCore.exp.in: Added FontCache::purgeInactiveFontDataIfNeeded().
3063         * html/canvas/CanvasRenderingContext2D.cpp:
3064         (WebCore::CanvasRenderingContext2D::measureText):
3065         (WebCore::CanvasRenderingContext2D::drawTextInternal):
3066         Wrapped code accessing fallback fonts with local 
3067         FontCachePurgePreventer in these methods.
3068
3069         * page/FrameView.cpp:
3070         (WebCore::FrameView::layout):
3071         (WebCore::FrameView::paintContents):
3072         Wrapped code accessing fallback fonts with local 
3073         FontCachePurgePreventer in these methods.
3074
3075         * platform/graphics/FontCache.cpp:
3076         (WebCore::FontCache::FontCache):
3077         (WebCore::FontCache::getCachedFontData):
3078         Moved purge check to new method since it likely can't happen here.
3079         (WebCore::FontCache::releaseFontData):
3080         (WebCore::FontCache::purgeInactiveFontDataIfNeeded):
3081         (WebCore::FontCache::purgeInactiveFontData):
3082         Made purging conditional on m_purgePreventCount.  Now some fonts
3083         in the cache are reference counted while other can be purged 
3084         outside of code wrapped by in scope FontCachePurgePreventer objects.
3085
3086         * platform/graphics/FontCache.h:
3087         (WebCore::FontCache::disablePurging):
3088         (WebCore::FontCache::enablePurging):
3089         (WebCore::FontCachePurgePreventer::FontCachePurgePreventer):
3090         (WebCore::FontCachePurgePreventer::~FontCachePurgePreventer):
3091         Added new simple purge prevention wrapper class and methods
3092         that it calls in FontCache actually prevent purging.  The
3093         simple methods inlined to reduce overhead.
3094
3095         * platform/graphics/FontFastPath.cpp:
3096         (WebCore::Font::glyphDataForCharacter): Update level in 
3097         glyph page tree for system fallback fonts so pruning works.
3098
3099         * platform/graphics/GlyphPage.h:
3100         (WebCore::GlyphPage::clearForFontData): New method used for pruning
3101         * platform/graphics/GlyphPageTreeNode.cpp:
3102         (WebCore::GlyphPageTreeNode::pruneFontData):
3103         Now we prune system fallback fonts.
3104
3105         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
3106         (WebCore::FontCache::getFontDataForCharacters):
3107         * platform/graphics/freetype/FontCacheFreeType.cpp:
3108         (WebCore::FontCache::getFontDataForCharacters):
3109         * platform/graphics/haiku/FontCacheHaiku.cpp:
3110         (WebCore::FontCache::getFontDataForCharacters):
3111         * platform/graphics/mac/FontCacheMac.mm:
3112         (WebCore::FontCache::getFontDataForCharacters):
3113         * platform/graphics/qt/FontCacheQt.cpp:
3114         (WebCore::FontCache::getFontDataForCharacters):
3115         * platform/graphics/win/FontCacheWin.cpp:
3116         (WebCore::FontCache::getFontDataForCharacters):
3117         * platform/graphics/wince/FontCacheWinCE.cpp:
3118         * platform/graphics/wx/FontCacheWx.cpp:
3119         (WebCore::FontCache::getFontDataForCharacters):
3120         Changed the calls to getFontData() to not increment the reference
3121         count. The caller of this getFontDataForCharacters() (currently only
3122         Font::glyphDataForCharacter() in fontFastPath.cpp) and it's callers
3123         don't attempt to release the returned fonts so we use the purge
3124         protection described above.
3125
3126         * rendering/InlineTextBox.cpp:
3127         (WebCore::InlineTextBox::selectionRect):
3128         (WebCore::InlineTextBox::offsetForPosition):
3129         (WebCore::InlineTextBox::positionForOffset):
3130         Wrapped code accessing fallback fonts with local
3131         FontCachePurgePreventer in these methods.
3132
3133         * rendering/RenderImage.cpp:
3134         (WebCore::RenderImage::setImageSizeForAltText):
3135         Wrapped code accessing fallback fonts with local
3136         FontCachePurgePreventer in this method.
3137
3138         * rendering/RenderListBox.cpp:
3139         (WebCore::RenderListBox::updateFromElement):
3140         (WebCore::RenderListBox::paintItemForeground):
3141         Wrapped code accessing fallback fonts with local
3142         FontCachePurgePreventer in these methods
3143
3144         * rendering/svg/SVGInlineTextBox.cpp:
3145         (WebCore::SVGInlineTextBox::selectionRectForTextFragment):
3146         Wrapped code accessing fallback fonts with local
3147         FontCachePurgePreventer in this method.
3148
3149 2011-06-07  Tim Horton  <timothy_horton@apple.com>
3150
3151         Reviewed by Alexey Proskuryakov.
3152
3153         Use correct CFURLStorageSessionRef definition on Snow Leopard
3154         https://bugs.webkit.org/show_bug.cgi?id=62223
3155
3156         * platform/mac/WebCoreSystemInterface.h:
3157         * platform/network/ResourceHandle.h:
3158         * platform/network/cf/ResourceRequest.h:
3159
3160 2011-06-07  Alok Priyadarshi  <alokp@chromium.org>
3161
3162         Reviewed by Stephen White.
3163
3164         [chromium] PlatformContextSkia leaks SkDeviceFactory
3165         https://bugs.webkit.org/show_bug.cgi?id=62163
3166
3167         Valgrind tests should have caught this.
3168
3169         * platform/graphics/skia/PlatformContextSkia.cpp:
3170         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
3171
3172 2011-06-07  Emil A Eklund  <eae@chromium.org>
3173
3174         Reviewed by Eric Seidel.
3175
3176         Convert RenderTextControl::hitInnerTextElement to IntPoint
3177         https://bugs.webkit.org/show_bug.cgi?id=62167
3178
3179         Covered by existing tests.
3180
3181         * rendering/RenderTextControl.cpp:
3182         (WebCore::RenderTextControl::hitInnerTextElement):
3183         * rendering/RenderTextControl.h:
3184         * rendering/RenderTextControlMultiLine.cpp:
3185         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
3186         * rendering/RenderTextControlSingleLine.cpp:
3187         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
3188
3189 2011-06-07  Levi Weintraub  <leviw@chromium.org>
3190
3191         Reviewed by Eric Seidel.
3192
3193         Switch paint to use IntPoint
3194         https://bugs.webkit.org/show_bug.cgi?id=62177
3195
3196         Flipping the switch on the remaining paint functions to have them all
3197         use IntPoint for the paint offset instead of tx/ty.
3198
3199         No new tests since this is just refactoring.
3200
3201         * page/FrameView.cpp:
3202         (WebCore::FrameView::paintScrollCorner):
3203         * rendering/InlineBox.cpp:
3204         (WebCore::InlineBox::paint):
3205         * rendering/RenderBlock.cpp:
3206         (WebCore::RenderBlock::paint):
3207         (WebCore::RenderBlock::paintContents):
3208         (WebCore::RenderBlock::paintChildren):
3209         (WebCore::RenderBlock::paintFloats):
3210         * rendering/RenderBlock.h:
3211         * rendering/RenderBox.cpp:
3212         (WebCore::RenderBox::paint):
3213         * rendering/RenderBox.h:
3214         * rendering/RenderBoxModelObject.cpp:
3215         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
3216         * rendering/RenderDetailsMarker.cpp:
3217         (WebCore::RenderDetailsMarker::paint):
3218         * rendering/RenderDetailsMarker.h:
3219         * rendering/RenderEmbeddedObject.cpp:
3220         (WebCore::RenderEmbeddedObject::paint):
3221         * rendering/RenderEmbeddedObject.h:
3222         * rendering/RenderFrameSet.cpp:
3223         (WebCore::RenderFrameSet::paint):
3224         * rendering/RenderFrameSet.h:
3225         * rendering/RenderImage.cpp:
3226         (WebCore::RenderImage::paint):
3227         * rendering/RenderImage.h:
3228         * rendering/RenderInline.cpp:
3229         (WebCore::RenderInline::paint):
3230         * rendering/RenderInline.h:
3231         * rendering/RenderLayer.cpp:
3232         (WebCore::RenderLayer::paintScrollCorner):
3233         (WebCore::RenderLayer::paintResizer):
3234         (WebCore::RenderLayer::paintLayer):
3235         * rendering/RenderLayerBacking.cpp:
3236         (WebCore::RenderLayerBacking::paintIntoLayer):
3237         * rendering/RenderLineBoxList.cpp:
3238         (WebCore::RenderLineBoxList::paint):
3239         * rendering/RenderLineBoxList.h:
3240         * rendering/RenderListItem.cpp:
3241         (WebCore::RenderListItem::paint):
3242         * rendering/RenderListItem.h:
3243         * rendering/RenderListMarker.cpp:
3244         (WebCore::RenderListMarker::paint):
3245         * rendering/RenderListMarker.h:
3246         * rendering/RenderObject.cpp:
3247         (WebCore::RenderObject::paint):
3248         * rendering/RenderObject.h:
3249         * rendering/RenderReplaced.cpp:
3250         (WebCore::RenderReplaced::paint):
3251         * rendering/RenderReplaced.h:
3252         * rendering/RenderReplica.cpp:
3253         (WebCore::RenderReplica::paint):
3254         * rendering/RenderReplica.h:
3255         * rendering/RenderScrollbar.cpp:
3256         (WebCore::RenderScrollbar::paintPart):
3257         * rendering/RenderScrollbarPart.cpp:
3258         (WebCore::RenderScrollbarPart::paintIntoRect):
3259         * rendering/RenderScrollbarPart.h:
3260         * rendering/RenderTable.cpp:
3261         (WebCore::RenderTable::paint):
3262         (WebCore::RenderTable::paintObject):
3263         * rendering/RenderTable.h:
3264         * rendering/RenderTableCell.cpp:
3265         (WebCore::RenderTableCell::paint):
3266         * rendering/RenderTableCell.h:
3267         * rendering/RenderTableRow.cpp:
3268         (WebCore::RenderTableRow::paint):
3269         * rendering/RenderTableRow.h:
3270         * rendering/RenderTableSection.cpp:
3271         (WebCore::RenderTableSection::paint):
3272         (WebCore::RenderTableSection::paintCell):
3273         * rendering/RenderTableSection.h:
3274         * rendering/RenderText.h:
3275         (WebCore::RenderText::paint):
3276         * rendering/RenderTextControlSingleLine.cpp:
3277         (WebCore::RenderTextControlSingleLine::paint):
3278         * rendering/RenderTextControlSingleLine.h:
3279         * rendering/RenderView.cpp:
3280         (WebCore::RenderView::paint):
3281         * rendering/RenderView.h:
3282         * rendering/RenderWidget.cpp:
3283         (WebCore::RenderWidget::paint):
3284         * rendering/RenderWidget.h:
3285         * rendering/mathml/RenderMathMLBlock.cpp:
3286         (WebCore::RenderMathMLBlock::paint):
3287         * rendering/mathml/RenderMathMLBlock.h:
3288         * rendering/mathml/RenderMathMLFraction.cpp:
3289         (WebCore::RenderMathMLFraction::paint):
3290         * rendering/mathml/RenderMathMLFraction.h:
3291         * rendering/mathml/RenderMathMLRoot.cpp:
3292         (WebCore::RenderMathMLRoot::paint):
3293         * rendering/mathml/RenderMathMLRoot.h:
3294         * rendering/mathml/RenderMathMLSquareRoot.cpp:
3295         (WebCore::RenderMathMLSquareRoot::paint):
3296         * rendering/mathml/RenderMathMLSquareRoot.h:
3297         * rendering/svg/RenderSVGContainer.cpp:
3298         (WebCore::RenderSVGContainer::paint):
3299         * rendering/svg/RenderSVGContainer.h:
3300         * rendering/svg/RenderSVGForeignObject.cpp:
3301         (WebCore::RenderSVGForeignObject::paint):
3302         * rendering/svg/RenderSVGForeignObject.h:
3303         * rendering/svg/RenderSVGHiddenContainer.cpp:
3304         (WebCore::RenderSVGHiddenContainer::paint):
3305         * rendering/svg/RenderSVGHiddenContainer.h:
3306         * rendering/svg/RenderSVGImage.cpp:
3307         (WebCore::RenderSVGImage::paint):
3308         * rendering/svg/RenderSVGImage.h:
3309         * rendering/svg/RenderSVGPath.cpp:
3310         (WebCore::RenderSVGPath::paint):
3311         * rendering/svg/RenderSVGPath.h:
3312         * rendering/svg/RenderSVGResourceMarker.cpp:
3313         (WebCore::RenderSVGResourceMarker::draw):
3314         * rendering/svg/RenderSVGRoot.cpp:
3315         (WebCore::RenderSVGRoot::paint):
3316         * rendering/svg/RenderSVGRoot.h:
3317         * rendering/svg/RenderSVGText.cpp:
3318         (WebCore::RenderSVGText::paint):
3319         * rendering/svg/RenderSVGText.h:
3320         * rendering/svg/SVGImageBufferTools.cpp:
3321         (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
3322
3323 2011-06-07  Young Han Lee  <joybro@company100.net>
3324
3325         Reviewed by Kenneth Rohde Christiansen.
3326
3327         [Texmap][Qt] Accelerated animation is not paused properly.
3328         https://bugs.webkit.org/show_bug.cgi?id=61446
3329
3330         The transform matrix of an accelerated animation shouldn't be synced with the matrix of the GraphicsLayer when the animation is paused.
3331
3332         Test: animations/play-state-paused.html
3333
3334         * platform/graphics/texmap/TextureMapperNode.cpp:
3335         (WebCore::TextureMapperNode::syncCompositingStateSelf):
3336         (WebCore::TextureMapperNode::hasOpacityAnimation):
3337         (WebCore::TextureMapperNode::hasTransformAnimation):
3338         * platform/graphics/texmap/TextureMapperNode.h:
3339
3340 2011-06-07  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3341
3342         Reviewed by Antonio Gomes.
3343
3344         [EFL] Remove Ecore_X bits from PlatformScreenEfl
3345         https://bugs.webkit.org/show_bug.cgi?id=61649
3346
3347         Remove the need for Ecore_X and some X calls by always using
3348         new functions available in EFL to get the screen size.
3349
3350         No new tests since the same functionality are done inside EFL now.
3351
3352         * platform/efl/PlatformScreenEfl.cpp:
3353         (WebCore::screenRect):
3354
3355 2011-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3356
3357         Reviewed by Martin Robinson.
3358
3359         [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
3360         https://bugs.webkit.org/show_bug.cgi?id=62200
3361
3362         In WebKit2 PluginPackage is used by the UI process to load plugins
3363         in order to get information about them, but it doesn't use any GTK
3364         symbol. So the UI process should be able to load plugins even when
3365         building with GTK3, but we should not allow the plugin view to use
3366         the plugin if it mixes GTK2 and GTK3 symbols.
3367
3368         * plugins/PluginPackage.h:
3369         (WebCore::PluginPackage::module): New method to return the
3370         platform module.
3371         * plugins/gtk/PluginPackageGtk.cpp:
3372         (WebCore::PluginPackage::load): Remove moduleMixesGtkSymbols().
3373         * plugins/gtk/PluginViewGtk.cpp:
3374         (WebCore::PluginView::updatePluginWidget): Check whether plugin
3375         was successfully loaded before trying to create the drawable.
3376         (WebCore::PluginView::paint): Return early if plugin didn't start
3377         or was not successfully loaded.
3378         (WebCore::PluginView::handleKeyboardEvent): Ditto.
3379         (WebCore::PluginView::handleMouseEvent): Ditto.
3380         (WebCore::PluginView::handleFocusInEvent): Ditto.
3381         (WebCore::PluginView::handleFocusOutEvent): Ditto.
3382         (WebCore::moduleMixesGtkSymbols):
3383         (WebCore::PluginView::platformStart): Check whether module is
3384         mixing GTK+ 2 and GTK+ 3 symbols.
3385
3386 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3387
3388         Unreviewed, rolling out r88238.
3389         http://trac.webkit.org/changeset/88238
3390         https://bugs.webkit.org/show_bug.cgi?id=62216
3391
3392         Broke a couple of inspector tests (Requested by apavlov on
3393         #webkit).
3394
3395         * inspector/front-end/StylesSidebarPane.js:
3396         (WebInspector.StylesSidebarPane.prototype.update):
3397
3398 2011-06-07  Dinu Jacob  <dinu.jacob@nokia.com>
3399
3400         Reviewed by Dimitri Glazkov.
3401
3402         Inform ChromeClient touch events are not needed by the webpage when navigating away from the page instead of in both Document:detach/CachedFrame
3403         https://bugs.webkit.org/show_bug.cgi?id=61543
3404
3405         Inform chrome client that touch events are not needed by the webpage 
3406         when navigating away from the page only once to avoid the flag being 
3407         overwritten later if a page is removed from the page cache
3408
3409         * dom/Document.cpp:
3410         (WebCore::Document::detach):
3411         * history/CachedFrame.cpp:
3412         (WebCore::CachedFrame::CachedFrame):
3413         * loader/FrameLoader.cpp:
3414         (WebCore::FrameLoader::transitionToCommitted):
3415
3416 2011-06-07  Alexander Pavlov  <apavlov@chromium.org>
3417
3418         Reviewed by Yury Semikhatsky.
3419
3420         Web Inspector: node selection is slow in the Elements panel.
3421         https://bugs.webkit.org/show_bug.cgi?id=60813
3422
3423         Schedule full style updates rather than request all node styles from the backend immediately.
3424
3425         * inspector/front-end/StylesSidebarPane.js:
3426         (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
3427         (WebInspector.StylesSidebarPane.prototype.update):
3428
3429 2011-06-07  Yury Semikhatsky  <yurys@chromium.org>
3430
3431         Reviewed by Pavel Feldman.
3432
3433         Web Inspector: remove duplicate breakpoints from localStorage
3434         https://bugs.webkit.org/show_bug.cgi?id=62206
3435
3436         Perform one-time breakpoint storage cleanup to get rid of duplicate breakpoints in
3437         case when settings version is less than 1. 
3438
3439         * inspector/front-end/Settings.js:
3440         (WebInspector.Settings):
3441         (WebInspector.Settings.prototype._set):
3442         (WebInspector.Settings.prototype._migrateSettings.splitObjects):
3443         (WebInspector.Settings.prototype._migrateSettings.removeDuplicateObjects):
3444         (WebInspector.Settings.prototype._migrateSettings):
3445
3446 2011-06-03  Yury Semikhatsky  <yurys@chromium.org>
3447
3448         Reviewed by Pavel Feldman.
3449
3450         [Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
3451         https://bugs.webkit.org/show_bug.cgi?id=62019
3452
3453         Dispatch disconnecFrontend message in debugger task mode to make sure
3454         it is processed even if execution is paused.
3455
3456         * bindings/v8/WorkerScriptDebugServer.cpp:
3457         (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
3458         (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
3459         * bindings/v8/WorkerScriptDebugServer.h:
3460
3461 2011-06-07  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>
3462
3463         Reviewed by Nikolas Zimmermann.
3464
3465         SVG animation beginElement() does not restart the animation after endElement().
3466         https://bugs.webkit.org/show_bug.cgi?id=43452
3467
3468         Test: svg/animations/animate-endElement-beginElement.html
3469
3470         Calling beginElement() after calling endElement() previously does not restarted the animation when animation
3471         element's end attribute doesn't contains a bigger value than the current animation time.
3472
3473         * svg/animation/SVGSMILElement.cpp:
3474         (WebCore::SVGSMILElement::findInstanceTime):
3475
3476 2011-06-07  Naoki Takano  <takano.naoki@gmail.com>
3477
3478         Reviewed by Kent Tamura.
3479
3480         [Chromium] Click event is not fired for a menulist <select>
3481         https://bugs.webkit.org/show_bug.cgi?id=60563
3482
3483         Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
3484
3485         * platform/chromium/PopupMenuChromium.cpp:
3486         (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
3487         (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
3488         (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
3489
3490 2011-06-07  Andras Becsi  <abecsi@webkit.org>
3491
3492         Reviewed by Yury Semikhatsky.
3493  
3494         REGRESSION(r88221): "Chromium debug compilation broken".
3495         https://bugs.webkit.org/show_bug.cgi?id=62197
3496
3497         No n