Web Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-10-07  Pavel Feldman  <pfeldman@google.com>
2
3         Web Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
4         https://bugs.webkit.org/show_bug.cgi?id=69634
5
6         Reviewed by Yury Semikhatsky.
7
8         * inspector/front-end/CSSStyleModel.js:
9         (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
10
11 2011-10-06  Andreas Kling  <kling@webkit.org>
12
13         Shrink BorderValue.
14         https://bugs.webkit.org/show_bug.cgi?id=69521
15
16         Reviewed by Antti Koivisto.
17
18         Unroll BorderValue's Color member so we can pack the color's validity flag
19         in BorderValue's bitfield.
20
21         This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
22         16 bytes. This reduces memory consumption by 760 kB when loading the full
23         HTML5 spec.
24
25         * platform/graphics/Color.h:
26         (WebCore::Color::Color):
27
28             Allow construction of Color objects with specific validity.
29
30         * rendering/style/BorderValue.h:
31         (WebCore::BorderValue::BorderValue):
32         (WebCore::BorderValue::isTransparent):
33         (WebCore::BorderValue::operator==):
34         (WebCore::BorderValue::setColor):
35         (WebCore::BorderValue::color):
36         * rendering/style/OutlineValue.h:
37         (WebCore::OutlineValue::operator==):
38
39             Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
40             Made those variables private and added color(), setColor() accessors.
41
42         * rendering/style/RenderStyle.h:
43         (WebCore::InheritedFlags::setBorderLeftColor):
44         (WebCore::InheritedFlags::setBorderRightColor):
45         (WebCore::InheritedFlags::setBorderTopColor):
46         (WebCore::InheritedFlags::setBorderBottomColor):
47         (WebCore::InheritedFlags::setOutlineColor):
48         (WebCore::InheritedFlags::setColumnRuleColor):
49
50             Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
51             when setting BorderValue colors.
52
53         (WebCore::InheritedFlags::fillPaintColor):
54         (WebCore::InheritedFlags::strokePaintColor):
55         (WebCore::InheritedFlags::borderLeftColor):
56         (WebCore::InheritedFlags::borderRightColor):
57         (WebCore::InheritedFlags::borderTopColor):
58         (WebCore::InheritedFlags::borderBottomColor):
59         (WebCore::InheritedFlags::backgroundColor):
60         (WebCore::InheritedFlags::color):
61         (WebCore::InheritedFlags::columnRuleColor):
62         (WebCore::InheritedFlags::outlineColor):
63         (WebCore::InheritedFlags::textEmphasisColor):
64         (WebCore::InheritedFlags::textFillColor):
65         (WebCore::InheritedFlags::textStrokeColor):
66         (WebCore::InheritedFlags::stopColor):
67         (WebCore::InheritedFlags::floodColor):
68         (WebCore::InheritedFlags::lightingColor):
69
70             Made color getters return "Color" instead of "const Color&" since
71             BorderValue no longer has an actual object to return the reference to.
72
73         * css/CSSStyleApplyProperty.cpp:
74         (WebCore::ApplyPropertyColor::applyInheritValue):
75         * page/animation/AnimationBase.cpp:
76         (WebCore::PropertyWrapperColor::PropertyWrapperColor):
77         (WebCore::PropertyWrapperColor::blend):
78         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
79         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
80         (WebCore::AnimationBase::ensurePropertyMap):
81
82             Adapt to RenderStyle color getters now returning "Color" instead of
83             "const Color&".
84
85 2011-10-07  Philippe Normand  <pnormand@igalia.com>
86
87         [GStreamer] webkitwebsrc: avoid GST_BOILERPLATE_FULL
88         https://bugs.webkit.org/show_bug.cgi?id=69630
89
90         Reviewed by Martin Robinson.
91
92         Use G_DEFINE_TYPE_WITH_CODE instead of GST_BOILERPLATE_FULL and
93         replace use of gst_ghost_pad_new_no_target_from_template() and
94         gst_ghost_pad_set_target() with a single call to
95         gst_ghost_pad_new_from_template(). These changes keep the element
96         compatible with GStreamer 0.10 while preparing the port to 0.11.
97
98         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
99         (webkit_web_src_class_init):
100         (webkit_web_src_init):
101
102 2011-10-07  Martin Robinson  <mrobinson@igalia.com>
103
104         [Freetype] Pseudo-italics do not work
105         https://bugs.webkit.org/show_bug.cgi?id=40856
106
107         Reviewed by Philippe Normand.
108
109         * platform/graphics/freetype/FontPlatformData.h: Add the font description as an argument initializeWithFontFace.
110         * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
111         (WebCore::FontPlatformData::FontPlatformData): Pass the font description to initializeWithFontFace.
112         (WebCore::FontPlatformData::initializeWithFontFace): If we were asked for an italic font and we were
113         given one that wasn't oblique or italic, activate the synthetic oblique bit.
114
115 2011-10-07  Philippe Normand  <pnormand@igalia.com>
116
117         [GStreamer] avoid direct access to GstMessage structure field
118         https://bugs.webkit.org/show_bug.cgi?id=69629
119
120         Reviewed by Martin Robinson.
121
122         Use gst_message_get_structure() instead of direct access to the
123         structure field. No direct benefit apart from compatibility with
124         GStreamer 0.11.
125
126         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
127         (WebCore::gstGWorldSyncMessageCallback):
128         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
129         (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
130         (WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged):
131
132 2011-10-07  Pavel Feldman  <pfeldman@google.com>
133
134         Web Inspector: add timeline panel to the compilation.
135         https://bugs.webkit.org/show_bug.cgi?id=69628
136
137         Reviewed by Yury Semikhatsky.
138
139         * inspector/compile-front-end.sh:
140         * inspector/front-end/SidebarTreeElement.js:
141         (WebInspector.SidebarTreeElement):
142         * inspector/front-end/SourceCSSTokenizer.js:
143         (WebInspector.SourceCSSTokenizer.prototype.nextToken):
144         * inspector/front-end/SourceCSSTokenizer.re2js:
145         * inspector/front-end/SourceHTMLTokenizer.js:
146         (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
147         * inspector/front-end/SourceHTMLTokenizer.re2js:
148         * inspector/front-end/SourceJavaScriptTokenizer.js:
149         (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
150         * inspector/front-end/SourceJavaScriptTokenizer.re2js:
151         * inspector/front-end/TimelineGrid.js:
152         * inspector/front-end/TimelineOverviewPane.js:
153         (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
154         * inspector/front-end/TimelinePanel.js:
155         (WebInspector.TimelinePanel.prototype._createEventDivider):
156         (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
157         (WebInspector.TimelinePanel.prototype._findParentRecord):
158         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
159         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
160         (WebInspector.TimelinePanel.prototype.onResize):
161         (WebInspector.TimelinePanel.prototype._windowChanged):
162         (WebInspector.TimelinePanel.prototype._refreshRecords):
163         (WebInspector.TimelineRecordGraphRow.prototype._onClick):
164         (WebInspector.TimelinePanel.FormattedRecord):
165         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
166         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
167
168 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
169
170         Unreviewed, rolling out r96892.
171         http://trac.webkit.org/changeset/96892
172         https://bugs.webkit.org/show_bug.cgi?id=69626
173
174         it broke windows canary bots (Requested by podivilov on
175         #webkit).
176
177         * WebCore.gyp/scripts/rule_binding.py:
178
179 2011-10-07  Andreas Kling  <kling@webkit.org>
180
181         Shrink StyleInheritedData.
182         https://bugs.webkit.org/show_bug.cgi?id=69625
183
184         Reviewed by Antti Koivisto.
185
186         Rearrange the members of StyleInheritedData to fold as much
187         as possible into the padding at the end of RefCounted.
188
189         This shrinks StyleInheritedData by 8 bytes on 64-bit, reducing
190         memory consumption by 500 kB when loading the full HTML5 spec.
191
192         * rendering/style/StyleInheritedData.cpp:
193         (WebCore::StyleInheritedData::StyleInheritedData):
194         * rendering/style/StyleInheritedData.h:
195
196 2011-10-07  Pavel Feldman  <pfeldman@google.com>
197
198         Web Inspector: make ScriptsPanel compile
199         https://bugs.webkit.org/show_bug.cgi?id=69623
200
201         Reviewed by Yury Semikhatsky.
202
203         * inspector/compile-front-end.sh:
204         * inspector/front-end/CallStackSidebarPane.js:
205         (WebInspector.CallStackSidebarPane.prototype.update):
206         (WebInspector.CallStackSidebarPane.prototype._placardSelected):
207         * inspector/front-end/DebuggerModel.js:
208         * inspector/front-end/JavaScriptSourceFrame.js:
209         (WebInspector.JavaScriptSourceFrame):
210         * inspector/front-end/KeyboardShortcut.js:
211         * inspector/front-end/Object.js:
212         * inspector/front-end/ObjectPropertiesSection.js:
213         * inspector/front-end/ScopeChainSidebarPane.js:
214         (WebInspector.ScopeChainSidebarPane.prototype.update):
215         * inspector/front-end/ScriptsPanel.js:
216         (WebInspector.ScriptsPanel.prototype._setScriptSourceIsBeingEdited):
217         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
218         (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
219         (WebInspector.SourceFrameDelegateForScriptsPanel):
220         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
221         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggingSupported):
222         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
223         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
224         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
225         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
226         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
227         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
228         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
229         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
230         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggerPaused):
231         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
232         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
233         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
234         * inspector/front-end/StatusBarButton.js:
235         * inspector/front-end/WatchExpressionsSidebarPane.js:
236         (WebInspector.WatchExpressionsSection.prototype.update.appendResult):
237         (WebInspector.WatchExpressionsSection.prototype.update):
238         (WebInspector.WatchExpressionTreeElement.prototype.startEditing):
239         * inspector/front-end/WorkerManager.js:
240         (WebInspector.WorkerManager.prototype._openInspectorWindow):
241         (WebInspector.WorkerManager.prototype._pageInspectorClosing):
242         (WebInspector.DedicatedWorkerMessageForwarder.prototype._receiveMessage):
243         * inspector/front-end/WorkersSidebarPane.js:
244         (WebInspector.WorkersSidebarPane.prototype.removeWorker):
245         * inspector/front-end/externs.js:
246         (WebInspector.linkifyURL):
247         (InjectedFakeWorker):
248         * inspector/front-end/inspector.js:
249
250 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
251
252         Unreviewed, rolling out r96879.
253         http://trac.webkit.org/changeset/96879
254         https://bugs.webkit.org/show_bug.cgi?id=69618
255
256         Broke CCLayerTreeHostTestShortlived1 on chromium mac.
257         (Requested by podivilov on #webkit).
258
259         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
260
261 2011-10-07  Pavel Feldman  <pfeldman@google.com>
262
263         Web Inspector: add ResourcesPanel to the compilation.
264         https://bugs.webkit.org/show_bug.cgi?id=69612
265
266         Reviewed by Yury Semikhatsky.
267
268         * inspector/compile-front-end.sh:
269         * inspector/front-end/ApplicationCacheItemsView.js:
270         (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
271         * inspector/front-end/NetworkPanel.js:
272         * inspector/front-end/ResourceView.js:
273         * inspector/front-end/ResourcesPanel.js:
274         (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
275         (WebInspector.ResourcesPanel.prototype.showResource):
276         (WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
277         (WebInspector.FrameTreeElement.prototype.frameNavigated):
278         (WebInspector.StorageCategoryView):
279         (WebInspector.SearchResultsTreeElementsTraverser.prototype.last):
280         * inspector/front-end/externs.js:
281         (WebInspector.openRequestInNetworkPanel):
282
283 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
284
285         Unreviewed, rolling out r96909.
286         http://trac.webkit.org/changeset/96909
287         https://bugs.webkit.org/show_bug.cgi?id=69616
288
289         Broke chromium mac compilation (Requested by podivilov on
290         #webkit).
291
292         * platform/graphics/chromium/ContentLayerChromium.h:
293
294 2011-10-07  Vsevolod Vlasov  <vsevik@chromium.org>
295
296         Web Inspector: Element highlighting does not highlight padding/border/margin for inline elements.
297         https://bugs.webkit.org/show_bug.cgi?id=69558
298
299         Reviewed by Pavel Feldman.
300
301         * inspector/DOMNodeHighlighter.cpp:
302
303 2011-10-07  Mario Sanchez Prada  <msanchez@igalia.com>
304
305         [GTK] Don't expose objects with unknown role on GTK
306         https://bugs.webkit.org/show_bug.cgi?id=69561
307
308         Reviewed by Chris Fleizach.
309
310         Ignore accessibility objects in accessibilityPlatformIncludesObject.
311
312         Test: platform/gtk/accessibility/unknown-roles-not-exposed.html
313
314         * accessibility/gtk/AccessibilityObjectAtk.cpp:
315         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
316         For unknown accessibility objects, return IgnoreObject.
317
318 2011-10-07  Pavel Feldman  <pfeldman@chromium.org>
319
320         Web Inspector: add Elements and Network panels to the compilation
321         https://bugs.webkit.org/show_bug.cgi?id=69604
322
323         Reviewed by Yury Semikhatsky.
324
325         * inspector/compile-front-end.sh:
326         * inspector/front-end/BreakpointsSidebarPane.js:
327         (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
328         (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
329         * inspector/front-end/DOMAgent.js:
330         * inspector/front-end/DOMBreakpointsSidebarPane.js:
331         * inspector/front-end/DataGrid.js:
332         (WebInspector.DataGrid.prototype._startEditingConfig):
333         * inspector/front-end/Drawer.js:
334         * inspector/front-end/ElementsPanel.js:
335         (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
336         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
337         (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.collapseDimmed):
338         (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
339         (WebInspector.ElementsPanel.prototype._registerShortcuts):
340         * inspector/front-end/ElementsTreeOutline.js:
341         (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
342         (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
343         (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
344         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
345         * inspector/front-end/GoToLineDialog.js:
346         (WebInspector.GoToLineDialog._show):
347         * inspector/front-end/MetricsSidebarPane.js:
348         (WebInspector.MetricsSidebarPane.prototype.startEditing):
349         * inspector/front-end/NetworkPanel.js:
350         (WebInspector.NetworkLogView.prototype._onLoadEventFired):
351         (WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
352         (WebInspector.NetworkLogView.prototype._updateOffscreenRows):
353         (WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
354         (WebInspector.NetworkPanel.prototype._resourceByAnchor):
355         (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
356         * inspector/front-end/ObjectPropertiesSection.js:
357         (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
358         * inspector/front-end/Panel.js:
359         * inspector/front-end/Popover.js:
360         * inspector/front-end/SourceFrame.js:
361         (WebInspector.SourceFrame.prototype._editBreakpointCondition):
362         * inspector/front-end/StylesSidebarPane.js:
363         (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
364         (WebInspector.StylePropertyTreeElement.prototype):
365         * inspector/front-end/TimelineGrid.js:
366         * inspector/front-end/UIUtils.js:
367         (WebInspector.EditingConfig):
368         (WebInspector.startEditing.editingCancelled):
369         (WebInspector.startEditing.editingCommitted):
370         (WebInspector.formatLocalized):
371         (WebInspector.openLinkExternallyLabel):
372         (WebInspector.openInNetworkPanelLabel):
373         (WebInspector.copyLinkAddressLabel):
374         * inspector/front-end/externs.js:
375         (WebInspector.extensionServer.notifyObjectSelected):
376         (WebInspector.openResource):
377         * inspector/front-end/inspector.js:
378         (WebInspector.resourceForURL):
379
380 2011-10-07  Anna Cavender  <annacc@chromium.org>
381
382         Change enum value names for TextTrack::readyState and TextTrack::mode
383         https://bugs.webkit.org/show_bug.cgi?id=69603
384
385         Reviewed by David Levin.
386
387         No new tests. No new functionality.
388
389         * html/LoadableTextTrack.cpp:
390         (WebCore::LoadableTextTrack::trackLoadStarted):
391         (WebCore::LoadableTextTrack::trackLoadError):
392         (WebCore::LoadableTextTrack::trackLoadCompleted):
393         * html/TextTrack.cpp:
394         (WebCore::TextTrack::TextTrack):
395         (WebCore::TextTrack::setMode):
396         * html/TextTrack.h:
397
398 2011-10-07  Anna Cavender  <annacc@chromium.org>
399
400         Adding parens in WebVTTParser.cpp to appease compiler preferences.
401         https://bugs.webkit.org/show_bug.cgi?id=69602
402
403         Reviewed by David Levin.
404
405         No new tests. No new functionality.
406
407         * html/track/WebVTTParser.cpp:
408         (WebCore::WebVTTParser::constructTreeFromToken):
409
410 2011-10-06  Antoine Labour  <piman@chromium.org>
411
412         Webkit API for compositor
413         https://bugs.webkit.org/show_bug.cgi?id=69107
414
415         Reviewed by Darin Fisher.
416
417         Covered by existing compositing tests.
418
419         * platform/graphics/chromium/ContentLayerChromium.h: 
420
421 2011-10-06  Kent Tamura  <tkent@chromium.org>
422
423         Remove SelectElement class
424         https://bugs.webkit.org/show_bug.cgi?id=69518
425
426         Reviewed by Ryosuke Niwa.
427
428         SelectElement used to be an abstract class for HTMLSelectElement
429         and WMLSelectElement. SelectElement is not needed anymore because
430         WML was removed.
431
432         This patch just removes SelectElement by moving SelectElement
433         functions to HTMLSelectElement.
434
435         No new tests. Just a refactoring.
436
437         * WebCore.vcproj/WebCore.vcproj:
438         Rename dom\SelectElementWin.cpp to html\HTMLSelectElementWin.cpp.
439         * accessibility/AccessibilityListBoxOption.cpp:
440         (WebCore::AccessibilityListBoxOption::setSelected):
441         Remove unnecessary cast.
442         * accessibility/AccessibilityRenderObject.cpp:
443         (WebCore::AccessibilityRenderObject::stringValue):
444         Use HTMLSelectElement instead of SelectElement.
445         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
446         (optionFromSelection): ditto.
447         (webkit_accessible_selection_get_selection_count): ditto.
448         * accessibility/gtk/AXObjectCacheAtk.cpp:
449         (notifyChildrenSelectionChange): ditto.
450         * dom/OptionElement.cpp:
451         (WebCore::OptionElement::optionIndex): ditto.
452         * dom/OptionElement.h: ditto.
453         * dom/SelectElement.cpp:
454         (WebCore::SelectElementData::checkListItems): ditto.
455         (WebCore::SelectElementData::listItems): ditto.
456         * dom/SelectElementWin.cpp: Removed.
457         * dom/SelectElement.h: Removed SelectElement class declaration.
458         * html/HTMLSelectElement.cpp: Move functions from SelectElement.cpp.
459         (WebCore::HTMLSelectElement::selectedIndex):
460         Removed 'SelectElement::' because the function is moved to HTMLSelectElement.
461         (WebCore::HTMLSelectElement::deselectItems): dito.
462         (WebCore::HTMLSelectElement::setSelectedIndex): dito.
463         (WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
464         (WebCore::HTMLSelectElement::activeSelectionEndListIndex): ditto.
465         (WebCore::HTMLSelectElement::length): ditto.
466         (WebCore::HTMLSelectElement::saveFormControlState): ditto.
467         (WebCore::HTMLSelectElement::restoreFormControlState): ditto.
468         (WebCore::HTMLSelectElement::parseMappedAttribute): ditto.
469         (WebCore::HTMLSelectElement::selectAll): ditto.
470         (WebCore::HTMLSelectElement::appendFormData): ditto.
471         (WebCore::HTMLSelectElement::optionToListIndex): ditto.
472         (WebCore::HTMLSelectElement::listToOptionIndex): ditto.
473         (WebCore::HTMLSelectElement::recalcListItems): ditto.
474         (WebCore::HTMLSelectElement::setRecalcListItems): ditto.
475         (WebCore::HTMLSelectElement::reset): ditto.
476         (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
477         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
478         (WebCore::HTMLSelectElement::defaultEventHandler): ditto.
479         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
480         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
481         (WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
482         (WebCore::HTMLSelectElement::menuListOnChange): ditto.
483         (WebCore::HTMLSelectElement::listBoxOnChange): ditto.
484         (WebCore::HTMLSelectElement::saveLastSelection): ditto.
485         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
486         (WebCore::HTMLSelectElement::scrollToSelection): ditto.
487         (WebCore::HTMLSelectElement::insertedIntoTree): ditto.
488         (WebCore::nextValidIndex): Moved from SelectElement.cpp.
489         (WebCore::nextSelectableListIndex): ditto.
490         (WebCore::previousSelectableListIndex): ditto.
491         (WebCore::firstSelectableListIndex): ditto.
492         (WebCore::lastSelectableListIndex): ditto.
493         (WebCore::nextSelectableListIndexPageAway): ditto.
494         (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): ditto.
495         (WebCore::HTMLSelectElement::parseMultipleAttribute): ditto.
496         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): ditto.
497         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
498         (WebCore::HTMLSelectElement::updateSelectedState): ditto.
499         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
500         (WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
501         (WebCore::stripLeadingWhiteSpace): ditto.
502         (WebCore::HTMLSelectElement::typeAheadFind): ditto.
503         (WebCore::HTMLSelectElement::optionCount): ditto.
504         (WebCore::toSelectElement): ditto.
505         * html/HTMLSelectElementWin.cpp: Copied from Source/WebCore/dom/SelectElementWin.cpp.
506         (WebCore::HTMLSelectElement::platformHandleKeydownEvent):
507         * html/HTMLSelectElement.h: Removed 'virtual' of SelectElement functions.
508         (WebCore::HTMLSelectElement::size):
509         (WebCore::HTMLSelectElement::multiple):
510         (WebCore::HTMLSelectElement::listItems):
511         (WebCore::HTMLSelectElement::updateValidity):
512         * rendering/RenderListBox.cpp: Replace SelectElement with HTMLSelectElement
513         (WebCore::RenderListBox::RenderListBox):
514         (WebCore::RenderListBox::scrollToRevealSelection):
515         (WebCore::RenderListBox::addFocusRingRects):
516         (WebCore::RenderListBox::paintItemForeground):
517         (WebCore::RenderListBox::paintItemBackground):
518         (WebCore::RenderListBox::panScroll):
519         (WebCore::RenderListBox::autoscroll):
520         (WebCore::RenderListBox::valueChanged):
521         * rendering/RenderMenuList.cpp: Replace SelectElement with HTMLSelectElement
522         (WebCore::RenderMenuList::RenderMenuList):
523         (WebCore::RenderMenuList::setTextFromOption):
524         (WebCore::RenderMenuList::showPopup):
525         (WebCore::RenderMenuList::valueChanged):
526         (WebCore::RenderMenuList::listBoxSelectItem):
527         (WebCore::RenderMenuList::multiple):
528         (WebCore::RenderMenuList::didSetSelectedIndex):
529         (WebCore::RenderMenuList::didUpdateActiveOption):
530         (WebCore::RenderMenuList::itemText):
531         (WebCore::RenderMenuList::itemAccessibilityText):
532         (WebCore::RenderMenuList::itemToolTip):
533         (WebCore::RenderMenuList::itemIsEnabled):
534         (WebCore::RenderMenuList::itemStyle):
535         (WebCore::RenderMenuList::itemBackgroundColor):
536         (WebCore::RenderMenuList::listSize):
537         (WebCore::RenderMenuList::selectedIndex):
538         (WebCore::RenderMenuList::itemIsSeparator):
539         (WebCore::RenderMenuList::itemIsLabel):
540         (WebCore::RenderMenuList::itemIsSelected):
541         (WebCore::RenderMenuList::setTextFromItem):
542
543 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
544
545         Unreviewed, rolling out r96896.
546         http://trac.webkit.org/changeset/96896
547         https://bugs.webkit.org/show_bug.cgi?id=69601
548
549         broke windows and mac chromium builds (Requested by simonjam
550         on #webkit).
551
552         * platform/graphics/chromium/ContentLayerChromium.h:
553
554 2011-10-06  Antoine Labour  <piman@chromium.org>
555
556         Webkit API for compositor
557         https://bugs.webkit.org/show_bug.cgi?id=69107
558
559         Reviewed by Darin Fisher.
560
561         Covered by existing compositing tests.
562
563         * platform/graphics/chromium/ContentLayerChromium.h: 
564
565 2011-10-06  Joseph Pecoraro  <joepeck@webkit.org>
566
567         Reviewed by Kent Tamura.
568
569         Pass "accept" mime type information into FileChooser at all call sites
570         https://bugs.webkit.org/show_bug.cgi?id=69592
571
572         No new tests. This only exposes some more information to
573         WebKit ports, no functionality change in WebCore.
574
575         * html/FileInputType.cpp:
576         (WebCore::FileInputType::receiveDropForDirectoryUpload):
577
578 2011-10-06  Kent Tamura  <tkent@chromium.org>
579
580         [JSC binding] Fix inconsistent behavior of DOMStringMap
581         https://bugs.webkit.org/show_bug.cgi?id=53752
582
583         Reviewed by Darin Adler.
584
585         The dataset behavior was inconsistent. The get operation handled
586         data-* attributes first, and the put and delete operations handled
587         JavaScript properties first.
588
589         Like Firefox and Opera, the put and delete operations should
590         handle data-* attribute first.
591
592         * bindings/js/JSDOMStringMapCustom.cpp:
593         (WebCore::JSDOMStringMap::deleteProperty):
594          Handles DOMStringMap first, then returns false if the DOMStringMap makes an error.
595         (WebCore::JSDOMStringMap::putDelegate): ditto.
596
597 2011-10-06  Nico Weber  <thakis@chromium.org>
598
599         [chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
600         https://bugs.webkit.org/show_bug.cgi?id=69589
601
602         Reviewed by Adam Barth.
603
604         When building with `make -j40`, all the binding rules are built en bloc. Since this script currently
605         uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
606         255 by default, so the build used to fail with
607         "open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
608         As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.
609
610         * WebCore.gyp/scripts/rule_binding.py:
611
612 2011-10-06  Anders Carlsson  <andersca@apple.com>
613
614         When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
615         https://bugs.webkit.org/show_bug.cgi?id=69586
616
617         Reviewed by Darin Adler.
618
619         * Configurations/Base.xcconfig:
620         Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.
621         
622         * WebCore.xcodeproj/project.pbxproj:
623         When building with clang, we don't need to run the check-for-global-initializers and
624         check-for-exit-time-destructors anymore.
625         
626         * platform/graphics/filters/FEGaussianBlur.cpp:
627         (gaussianKernelFactor):
628         (WebCore::FEGaussianBlur::calculateKernelSize):
629         (WebCore::FEGaussianBlur::calculateStdDeviation):
630         Change the gaussian kernel factor global to be an inline function instead.
631
632 2011-10-06  Anders Carlsson  <andersca@apple.com>
633
634         Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
635         https://bugs.webkit.org/show_bug.cgi?id=69584
636
637         Reviewed by Darin Adler.
638
639         Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.
640
641         * bindings/js/JSLazyEventListener.cpp:
642         * dom/Node.cpp:
643         * dom/Range.cpp:
644         * history/CachedPage.cpp:
645         * loader/SubresourceLoader.cpp:
646         * loader/cache/CachedResource.cpp:
647         * page/Frame.cpp:
648         * page/Page.cpp:
649         * rendering/BidiRun.cpp:
650         * rendering/RenderObject.cpp:
651         * svg/SVGElementInstance.cpp:
652         * xml/XMLHttpRequest.cpp:
653
654 2011-10-06  James Robinson  <jamesr@chromium.org>
655
656         [chromium] Remove USE(THREADED_COMPOSITING) from the tree
657         https://bugs.webkit.org/show_bug.cgi?id=69489
658
659         Reviewed by Darin Fisher.
660
661         This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.
662
663         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
664
665 2011-10-06  David Grogan  <dgrogan@chromium.org>
666
667         Return null for the value of IDB key cursors instead of ASSERTing
668         https://bugs.webkit.org/show_bug.cgi?id=69131
669         
670         This is in support of the IndexedDB performance improvement here:
671         http://codereview.chromium.org/7834006/
672
673         Reviewed by Tony Chang.
674
675         * storage/IDBCursorBackendImpl.cpp:
676         (WebCore::IDBCursorBackendImpl::value):
677
678 2011-10-06  Alexey Proskuryakov  <ap@apple.com>
679
680         [Mac] Should be able to scroll embedded PDFs using mouse
681         https://bugs.webkit.org/show_bug.cgi?id=69579
682
683         Reviewed by Darin Adler.
684
685         Hit testing doesn't find scrollbars installed by a plug-in, so mouse events don't work.
686
687         As we want to use WebKit scrollbars with PDF plug-in, a cleaner long-term solution would be
688         to have a base class under PluginViewBase that can handle scrolling instead of doing that
689         in PluginView and Plugin.
690
691         * plugins/PluginViewBase.h:
692         (WebCore::PluginViewBase::horizontalScrollbar):
693         (WebCore::PluginViewBase::verticalScrollbar):
694         Added accessors for scrollbars installed by plug-in.
695
696         * rendering/nodeAtPoint.cpp: (WebCore::RenderEmbeddedObject::nodeAtPoint):
697         Like RenderLayer, add scrollbars to hit result after normal  hit testing.
698
699         * rendering/RenderEmbeddedObject.h: Added a nodeAtPoint override.
700
701         * rendering/RenderWidget.h: Made nodeAtPoint() protected instead of private, so that
702         RenderEmbeddedObject could call it.
703
704 2011-10-06  Dan Bernstein  <mitz@apple.com>
705
706         <rdar://problem/9717490> Flash of white when navigating daringfireball.net
707         https://bugs.webkit.org/show_bug.cgi?id=69581
708
709         Reviewed by Darin Adler.
710
711         * platform/ScrollView.cpp:
712         (WebCore::ScrollView::updateScrollbars): Moved the calls to Scrollbar::setEnabled() into the code
713         section where invalidation is suppressed if necessary, so that they do not trigger premature invalidation.
714
715 2011-10-06  Dan Bernstein  <mitz@apple.com>
716
717         Added a comment explaining code added in r96834.
718
719         Suggested by Darin Adler.
720
721         * editing/FrameSelection.cpp:
722         (WebCore::FrameSelection::updateAppearance):
723
724 2011-10-05  Ryosuke Niwa  <rniwa@webkit.org>
725
726         Deleting line break before h1 converts h1 to span
727         https://bugs.webkit.org/show_bug.cgi?id=45784
728
729         Reviewed by Enrica Casucci.
730
731         This patch fundamentally alters the kind of styles we preserve while merging or moving paragraphs.
732         StylizedMarkupAccumulator no longer wraps nodes by computed style when it's not annotating for interchange.
733         Instead, it accumulates implicit and inline styles of ancestors of the serialized contents.
734
735         The most significant code change is in StyledMarkupAccumulator::serializeNodes where we setup m_wrappingStyle
736         by merging implicit and inline style of ancestors with mergeInlineAndImplicitStyleOfElement. Because it walks up
737         the DOM tree upwards, it should not be overriding any CSS properties. Consequently, mergeStyle,
738         mergeInlineStyleOfElement, and mergeInlineAndImplicitStyleOfElement are modified to take CSSPropertyOverrideMode.
739
740         New behavior matches that of Internet Explorer and Firefox when merging paragraphs.
741
742         Tests: editing/deleting/merge-paragraph-from-address.html
743                editing/deleting/merge-paragraph-from-h6-with-style-2.html
744                editing/deleting/merge-paragraph-from-h6-with-style.html
745                editing/deleting/merge-paragraph-from-h6.html
746                editing/deleting/merge-paragraph-from-listing.html
747                editing/deleting/merge-paragraph-from-p-with-style-2.html
748                editing/deleting/merge-paragraph-from-p-with-style-3.html
749                editing/deleting/merge-paragraph-from-p-with-style.html
750                editing/deleting/merge-paragraph-into-h1-with-style.html
751                editing/deleting/merge-paragraph-into-h1.html
752                editing/deleting/merge-paragraph-into-pre.html
753
754         * css/CSSValueList.cpp:
755         (WebCore::CSSValueList::hasValue): Made const.
756         * css/CSSValueList.h:
757         * editing/ApplyStyleCommand.cpp:
758         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls mergeInlineStyleOfElement.
759         (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Ditto.
760         * editing/EditingStyle.cpp:
761         (WebCore::copyEditingProperties): Takes a boolean includeBackgroundColor.
762         (WebCore::isEditingProperty): Extracted from elementIsStyledSpanOrHTMLEquivalent.
763         (WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent): Calls isEditingProperty.
764         (WebCore::EditingStyle::mergeTypingStyle): Calls mergeStyle.
765         (WebCore::EditingStyle::mergeInlineStyleOfElement): Takes CSSPropertyOverrideMode.
766         (WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl): Added.
767         (WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement): Added.
768         (WebCore::mergeTextDecorationValues): Extracted from mergeStyle.
769         (WebCore::EditingStyle::mergeStyle): Takes CSSPropertyOverrideMode.
770         * editing/EditingStyle.h:
771         * editing/ReplaceSelectionCommand.cpp:
772         (WebCore::nodeToSplitToAvoidPastingIntoInlineNodesWithStyle): Extracted from doApply.
773         (WebCore::ReplaceSelectionCommand::doApply): Calls nodeToSplitToAvoidPastingIntoInlineNodesWithStyle.
774         (WebCore::ReplaceSelectionCommand::performTrivialReplace): Exit early when we need to split the tree to avoid
775         pasting into inline nodes with style. Also remove a collapsed or spurious br.
776         * editing/markup.cpp:
777         (WebCore::StyledMarkupAccumulator::serializeNodes):
778
779 2011-10-06  Abhishek Arya  <inferno@chromium.org>
780
781         Crash in VisiblePosition::canonicalPosition.
782         https://bugs.webkit.org/show_bug.cgi?id=69568
783
784         Reviewed by Ryosuke Niwa.
785
786         Move the position's containerNode calculation after layout is
787         complete(in updateLayoutIgnorePendingStylesheets).        
788
789         Test: editing/selection/selection-plugin-clear-crash.html
790
791         * editing/VisiblePosition.cpp:
792         (WebCore::VisiblePosition::canonicalPosition):
793
794 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
795
796         Unreviewed, rolling out r96861.
797         http://trac.webkit.org/changeset/96861
798         https://bugs.webkit.org/show_bug.cgi?id=69573
799
800         This patch didn't compile on windows (Requested by annacc on
801         #webkit).
802
803         * html/track/WebVTTParser.cpp:
804         (WebCore::WebVTTParser::constructTreeFromToken):
805
806 2011-10-06  Anna Cavender  <annacc@chromium.org>
807
808         Adding parens in WebVTTParser.cpp to appease compiler preferences.
809         https://bugs.webkit.org/show_bug.cgi?id=69460
810
811         Reviewed by David Levin.
812
813         No new tests. No new functionality.
814
815         * html/track/WebVTTParser.cpp:
816         (WebCore::WebVTTParser::constructTreeFromToken):
817
818 2011-10-06  Fady Samuel  <fsamuel@chromium.org>
819
820         Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false
821         https://bugs.webkit.org/show_bug.cgi?id=69009
822
823         Reviewed by Simon Fraser.
824
825         Upcoming patches may make use of absoluteBoundingBoxRect on a const RenderObject, so this needed to be fixed.
826         Making useTransforms default to true instead of false and replacing instances of absoluteBoundingBoxRect() to
827         absoluteBoundingBoxRectIgnoringTransforms() partially addreses // FIXME: useTransforms should go away eventually.
828
829         * WebCore.exp.in:
830         * dom/Element.cpp:
831         (WebCore::Element::screenRect):
832         * dom/Node.cpp:
833         (WebCore::Node::getRect):
834         (WebCore::Node::renderRect):
835         * html/shadow/SliderThumbElement.cpp:
836         (WebCore::SliderThumbElement::setPositionFromPoint):
837         * html/shadow/TextControlInnerElements.cpp:
838         (WebCore::InputFieldSpeechButtonElement::startSpeechInput):
839         * inspector/DOMNodeHighlighter.cpp:
840         * plugins/IFrameShimSupport.cpp:
841         (WebCore::getPluginOcclusions):
842         * rendering/RenderBlock.cpp:
843         (WebCore::RenderBlock::absoluteRects):
844         (WebCore::RenderBlock::absoluteQuads):
845         * rendering/RenderBlock.h:
846         * rendering/RenderBox.cpp:
847         (WebCore::RenderBox::absoluteRects):
848         (WebCore::RenderBox::absoluteQuads):
849         * rendering/RenderBox.h:
850         * rendering/RenderFileUploadControl.cpp:
851         (WebCore::RenderFileUploadControl::paintObject):
852         * rendering/RenderIFrame.cpp:
853         (WebCore::RenderIFrame::flattenFrame):
854         * rendering/RenderInline.cpp:
855         (WebCore::RenderInline::absoluteRects):
856         (WebCore::RenderInline::culledInlineAbsoluteRects):
857         (WebCore::RenderInline::absoluteQuads):
858         (WebCore::RenderInline::culledInlineAbsoluteQuads):
859         * rendering/RenderInline.h:
860         * rendering/RenderMenuList.cpp:
861         (WebCore::RenderMenuList::showPopup):
862         * rendering/RenderObject.cpp:
863         (WebCore::RenderObject::absoluteBoundingBoxRect):
864         (WebCore::RenderObject::addAbsoluteRectForLayer):
865         (WebCore::RenderObject::paintingRootRect):
866         * rendering/RenderObject.h:
867         (WebCore::RenderObject::absoluteRects):
868         (WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
869         (WebCore::RenderObject::absoluteQuads):
870         * rendering/RenderText.cpp:
871         (WebCore::RenderText::absoluteRects):
872         (WebCore::RenderText::absoluteQuads):
873         * rendering/RenderText.h:
874         * rendering/RenderTextControlSingleLine.cpp:
875         (WebCore::RenderTextControlSingleLine::showPopup):
876         * rendering/RenderThemeSafari.cpp:
877         (WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
878         (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration):
879         (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
880         * rendering/RenderView.cpp:
881         (WebCore::RenderView::absoluteRects):
882         (WebCore::RenderView::absoluteQuads):
883         * rendering/RenderView.h:
884         * rendering/svg/RenderSVGBlock.cpp:
885         (WebCore::RenderSVGBlock::absoluteRects):
886         * rendering/svg/RenderSVGBlock.h:
887         * rendering/svg/RenderSVGHiddenContainer.cpp:
888         (WebCore::RenderSVGHiddenContainer::absoluteQuads):
889         * rendering/svg/RenderSVGHiddenContainer.h:
890         * rendering/svg/RenderSVGInline.cpp:
891         (WebCore::RenderSVGInline::absoluteQuads):
892         * rendering/svg/RenderSVGInline.h:
893         * rendering/svg/RenderSVGModelObject.cpp:
894         (WebCore::RenderSVGModelObject::absoluteRects):
895         (WebCore::RenderSVGModelObject::absoluteQuads):
896         * rendering/svg/RenderSVGModelObject.h:
897         * rendering/svg/RenderSVGText.cpp:
898         (WebCore::RenderSVGText::absoluteQuads):
899         * rendering/svg/RenderSVGText.h:
900         * testing/Internals.cpp:
901         (WebCore::Internals::boundingBox):
902
903 2011-10-06  Simon Hausmann  <simon.hausmann@nokia.com>
904
905         [Qt][Wk2] Fix build with Qt 5 when QtScript is built as standalone module
906         https://bugs.webkit.org/show_bug.cgi?id=69520
907
908         Reviewed by Csaba Osztrogonác.
909
910         * WebCore.pri: Use qt5 scope.
911         * WebCore.pro: Use qt5 scope and pull in QtScript for the time being.
912
913 2011-10-06  Tony Chang  <tony@chromium.org>
914
915         last frame of a multipart response is not displayed
916         https://bugs.webkit.org/show_bug.cgi?id=69449
917
918         Reviewed by Adam Barth.
919
920         Test: http/tests/multipart/load-last-non-html-frame.php
921
922         * loader/DocumentLoader.cpp:
923         (WebCore::DocumentLoader::maybeFinishLoadingMultipartContent): for non-progressive load pages, commit the load so the
924             last frame will be displayed.
925         * loader/DocumentLoader.h:
926         * loader/MainResourceLoader.cpp:
927         (WebCore::MainResourceLoader::didFinishLoading):
928
929 2011-10-06  Gavin Peters  <gavinp@chromium.org>
930
931         conditionalize m_cachedScript stacks to just Chromium port
932         https://bugs.webkit.org/show_bug.cgi?id=69537
933
934         New stack saving telemetry code in ScriptElement shouldn't have
935         been put in all ports; just narrowing it to the chromium port will
936         save other ports the memory hit of this diagnostic code.
937
938         Reviewed by Nate Chapin.
939
940         No new tests.
941
942         * dom/ScriptElement.cpp:
943         (WebCore::ScriptElement::ScriptElement):
944         (WebCore::ScriptElement::requestScript):
945         (WebCore::ScriptElement::stopLoadRequest):
946         (WebCore::ScriptElement::notifyFinished):
947         * dom/ScriptElement.h:
948
949 2011-10-06  Arthur Hsu  <arthurhsu@chromium.org>
950
951         Ensure font loaded before calling Skia to drawPosText in Chrome sandbox
952         https://bugs.webkit.org/show_bug.cgi?id=69370
953
954         Reviewed by James Robinson.
955
956         * platform/graphics/chromium/FontChromiumWin.cpp:
957         (WebCore::Font::drawGlyphs):
958
959 2011-10-06  Chris Rogers  <crogers@google.com>
960
961         BiquadFilterNode must not reset filter state if type attribute is set to the same type
962         https://bugs.webkit.org/show_bug.cgi?id=69485
963
964         Reviewed by Kenneth Russell.
965
966         No new tests.  This particular case is difficult to test with a layout test using OfflineAudioContext.
967
968         * webaudio/BiquadProcessor.cpp:
969         (WebCore::BiquadProcessor::setType):
970         * webaudio/BiquadProcessor.h:
971
972 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
973
974         [EFL] Do not create cairo surfaces with the wrong size for form elements
975         https://bugs.webkit.org/show_bug.cgi?id=69533
976
977         Reviewed by Ryosuke Niwa.
978
979         RenderThemeEfl::cacheThemePartResizeAndReset resizes the Ecore_Evas
980         associated with an entry, but did not reset the `size` attribute of the
981         struct -- in practice, this meant the subsequent call to
982         themePartCacheEntrySurfaceCreate would create a cairo surface with the
983         previous size, thus rendering an element with the wrong size.
984
985         No new tests, this is triggered by running running pixel tests for
986         running, in this order, fast/forms/button-sizes.html,
987         fast/forms/input-appearance-preventDefault.html,
988         fast/forms/input-appearance-spinbutton-disabled-readonly.html,
989         fast/forms/input-appearance-width.html,
990         fast/forms/input-button-sizes.html,
991         fast/forms/input-placeholder-text-indent.html and
992         fast/forms/input-text-click-inside.html (!).
993
994         * platform/efl/RenderThemeEfl.cpp:
995         (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset): Reset the
996         size attribute when resizing the canvas.
997
998 2011-10-06  Chris Rogers  <crogers@google.com>
999
1000         Make sure OfflineAudioContext can not be created with a sample-rate less than 44.1KHz
1001         https://bugs.webkit.org/show_bug.cgi?id=69483
1002
1003         Reviewed by Kenneth Russell.
1004
1005         No new tests.
1006
1007         * webaudio/AudioBuffer.cpp:
1008         (WebCore::AudioBuffer::create):
1009         * webaudio/AudioContext.cpp:
1010         (WebCore::AudioContext::createBuffer):
1011
1012 2011-10-06  David Hyatt  <hyatt@apple.com>
1013
1014         https://bugs.webkit.org/show_bug.cgi?id=69544
1015         
1016         [CSS3 Regions] Compute the starting and ending regions of a block, so that we can clamp
1017         descendants to those regions. This is preparation for having true overflow in the boxes
1018         in each region, and it's also a performance optimization to reduce the amount of
1019         region walking that the RenderFlowThread is doing.
1020
1021         Add a range map to RenderFlowThread to cache the start/end regions for each box.
1022         
1023         Amend everyone who calls renderRegionForLine to pass in the box that is making the query.
1024         This box is then used to clamp to start and end regions so that any regions outside of that
1025         range will never be examined.
1026
1027         Reviewed by Dan Bernstein.
1028
1029         Test: fast/regions/top-overflow-out-of-second-region.html
1030
1031         * rendering/RenderBlock.cpp:
1032         (WebCore::RenderBlock::layoutBlock):
1033         (WebCore::RenderBlock::hasNextPage):
1034         (WebCore::RenderBlock::pageLogicalHeightForOffset):
1035         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
1036         (WebCore::RenderBlock::regionAtBlockOffset):
1037         * rendering/RenderFlowThread.cpp:
1038         (WebCore::RenderFlowThread::~RenderFlowThread):
1039         (WebCore::RenderFlowThread::layout):
1040         (WebCore::RenderFlowThread::renderRegionForLine):
1041         (WebCore::RenderFlowThread::regionLogicalWidthForLine):
1042         (WebCore::RenderFlowThread::regionLogicalHeightForLine):
1043         (WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
1044         (WebCore::RenderFlowThread::mapFromFlowToRegion):
1045         (WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
1046         (WebCore::RenderFlowThread::logicalWidthChangedInRegions):
1047         (WebCore::RenderFlowThread::setRegionRangeForBox):
1048         (WebCore::RenderFlowThread::getRegionRangeForBox):
1049         * rendering/RenderFlowThread.h:
1050         * rendering/RenderRegion.cpp:
1051         (WebCore::RenderRegion::takeRenderBoxRegionInfo):
1052         (WebCore::RenderRegion::removeRenderBoxRegionInfo):
1053         * rendering/RenderRegion.h:
1054
1055 2011-10-05  Gavin Barraclough  <barraclough@apple.com>
1056
1057         Add explicit JSGlobalThis type.
1058         https://bugs.webkit.org/show_bug.cgi?id=69478
1059
1060         Reviewed by Darin Adler.
1061
1062         JSC supports a split global object, as used by WebCore for the Window. As a stage
1063         of making this visible to JSC, make it so that if the global this value is not the
1064         global object itself, it must be a subclass of JSGlobalThis.
1065
1066         * ForwardingHeaders/runtime/JSGlobalThis.h: Added.
1067             - Added forwarding header.
1068         * bindings/js/JSDOMGlobalObject.cpp:
1069         (WebCore::JSDOMGlobalObject::finishCreation):
1070         * bindings/js/JSDOMGlobalObject.h:
1071             - finishCreation takes a JSGlobalThis, or thisValue is implicit.
1072         * bindings/js/JSDOMWindowShell.h:
1073             - Make the window shell a subclass of JSGlobalThis.
1074         * bindings/js/JSWorkerContextBase.cpp:
1075         (WebCore::JSWorkerContextBase::finishCreation):
1076             - Don't pass the thisValue to JSGlobalObject::finishCreation.
1077         * bindings/js/JSWorkerContextBase.h:
1078         * bindings/scripts/CodeGeneratorJS.pm:
1079         (GenerateHeader):
1080             - Don't pass the thisValue to JSGlobalObject::finishCreation,
1081               for worker contexts.
1082
1083 2011-10-06  Anna Cavender  <annacc@chromium.org>
1084
1085         Fix CodeGeneratorV8 for EnabledAtRuntime when class has no parent class.
1086         https://bugs.webkit.org/show_bug.cgi?id=69480
1087
1088         Reviewed by Adam Barth.
1089
1090         No new tests. No new functionality, yet.
1091
1092         * bindings/scripts/CodeGeneratorV8.pm:
1093
1094 2011-10-06  Dan Bernstein  <mitz@apple.com>
1095
1096         <rdar://problem/10232866> Assertion failure beneath blockSelectionGaps() when a selected node is removed
1097
1098         Reviewed by Ryosuke Niwa.
1099
1100         Test: editing/selection/invalid-in-RenderView.html
1101
1102         * editing/FrameSelection.cpp:
1103         (WebCore::FrameSelection::updateAppearance): Ensure that the VisibleSelection used to set the selection
1104         in the RenderView is valid, by reconstructing it from the current selection.
1105
1106 2011-10-06  Andreas Kling  <kling@webkit.org>
1107
1108         InlineBox's virtualLogicalHeight() partially limited to builds with SVG.
1109         https://bugs.webkit.org/show_bug.cgi?id=69538
1110
1111         Reviewed by Dan Bernstein.
1112
1113         Remove erroneous ENABLE(SVG) guards around the initialization and use
1114         of InlineBox::hasVirtualLogicalHeight.
1115
1116         This variable is used by TrailingFloatsRootInlineBox and should always
1117         be respected regardless of SVG support.
1118
1119         * rendering/InlineBox.cpp:
1120         (WebCore::InlineBox::logicalHeight):
1121         * rendering/InlineBox.h:
1122         (WebCore::InlineBox::InlineBox):
1123
1124 2011-10-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1125
1126         [GTK] Implement cache model for WebKit2
1127         https://bugs.webkit.org/show_bug.cgi?id=68434
1128
1129         Reviewed by Martin Robinson.
1130
1131         Add a function to FileSystem to get the free space of the file
1132         system where the given path is on.
1133
1134         * platform/FileSystem.h:
1135         * platform/gtk/FileSystemGtk.cpp:
1136         (WebCore::getVolumeFreeSizeForPath):
1137
1138 2011-10-06  Sergey Glazunov  <serg.glazunov@gmail.com>
1139
1140         Add check for JavaScript URLs in HTMLPlugInImageElement::allowedToLoadFrameURL
1141         https://bugs.webkit.org/show_bug.cgi?id=68813
1142
1143         Reviewed by Adam Barth.
1144
1145         Test: http/tests/security/xss-DENIED-object-element.html
1146
1147         * html/HTMLPlugInImageElement.cpp:
1148         (WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):
1149
1150 2011-10-06  Yury Semikhatsky  <yurys@chromium.org>
1151
1152         Web Inspector: avoid assertion failure in ~InspectorDebuggerAgent in case of workers
1153         https://bugs.webkit.org/show_bug.cgi?id=69534
1154
1155         Make sure frontend is disconnected before WorkerInspectorController is destroyed.
1156
1157         Reviewed by Pavel Feldman.
1158
1159         * inspector/WorkerInspectorController.cpp:
1160         (WebCore::WorkerInspectorController::~WorkerInspectorController):
1161
1162 2011-10-05  Alexey Proskuryakov  <ap@apple.com>
1163
1164         https://bugs.webkit.org/show_bug.cgi?id=69492
1165         [Mac] Should be able to scroll embedded PDFs from keyboard
1166
1167         Reviewed by Darin Adler.
1168
1169         * WebCore.exp.in: Export ScrollableArea::scroll.
1170
1171         * html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler): Call base
1172         class default event handler, so that events on focused plug-in elements would fall through
1173         to EventHandler::defaultKeyboardEventHandler.
1174
1175         * plugins/PluginViewBase.h: (WebCore::PluginViewBase::scroll): Added a method that's called
1176         on a plug-in when WebCore asks it to scroll. Plug-in cannot really know what key events
1177         result in scroll actions.
1178
1179         * rendering/RenderEmbeddedObject.cpp:
1180         (WebCore::RenderEmbeddedObject::scroll):
1181         (WebCore::RenderEmbeddedObject::logicalScroll):
1182         * rendering/RenderEmbeddedObject.h:
1183         Ask plug-in to scroll when EventHandler::scrollOverflow() is called.
1184
1185 2011-10-06  Konstantin Scheglov  <scheglov@google.com>
1186
1187         REGRESSION (r95852?): Disappearing Border on bugs.webkit.org attachments <table>
1188         https://bugs.webkit.org/show_bug.cgi?id=69296
1189
1190         Reviewed by David Hyatt.
1191
1192         Test: fast/table/border-collapsing/cached-69296.html
1193
1194         Remember BorderValue in CollapsedBorderValue by value.
1195         See https://bugs.webkit.org/show_bug.cgi?id=69296#c7 for motivation.
1196
1197         * rendering/style/CollapsedBorderValue.h:
1198         (WebCore::CollapsedBorderValue::CollapsedBorderValue):
1199         (WebCore::CollapsedBorderValue::width):
1200         (WebCore::CollapsedBorderValue::style):
1201         (WebCore::CollapsedBorderValue::exists):
1202         (WebCore::CollapsedBorderValue::isTransparent):
1203         (WebCore::CollapsedBorderValue::operator==):
1204         * rendering/RenderTableCell.cpp:
1205         (WebCore::RenderTableCell::collapsedStartBorder):
1206         (WebCore::RenderTableCell::collapsedEndBorder):
1207         (WebCore::RenderTableCell::collapsedBeforeBorder):
1208         (WebCore::RenderTableCell::collapsedAfterBorder):
1209
1210 2011-10-06  Gavin Peters  <gavinp@chromium.org>
1211
1212         save resource zeroing stacks in ScriptElement for debugging
1213         https://bugs.webkit.org/show_bug.cgi?id=69453
1214
1215         The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
1216         two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
1217         75604).  This patch will save a stack in the ScriptElement when this happens, so that if
1218         we do later crash, we can see how we did the first zeroing.
1219
1220         See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
1221         this change will help track down.
1222
1223         Reviewed by Nate Chapin.
1224
1225         No new tests, this shouldn't affect output at all, and isn't particularly testable.
1226
1227         * dom/ScriptElement.cpp:
1228         (WebCore::ScriptElement::ScriptElement):
1229         (WebCore::ScriptElement::stopLoadRequest):
1230         (WebCore::ScriptElement::notifyFinished):
1231         * dom/ScriptElement.h:
1232
1233 2011-10-06  Rémi Duraffort  <remi.duraffort@st.com>
1234
1235         Fix compilation by adding some missing ENABLE(VIDEO|XSLT)
1236         https://bugs.webkit.org/show_bug.cgi?id=69522
1237
1238         Unreviewed build fix
1239
1240         * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
1241         * bindings/v8/custom/V8HTMLAudioElementConstructor.h:
1242         * bindings/v8/custom/V8XSLTProcessorCustom.cpp:
1243
1244 2011-10-06  Pavel Feldman  <pfeldman@google.com>
1245
1246         Web Inspector: add Styles and Metrics sidebars to the compilation.
1247         https://bugs.webkit.org/show_bug.cgi?id=69529
1248
1249         Reviewed by Yury Semikhatsky.
1250
1251         * inspector/compile-front-end.sh:
1252         * inspector/front-end/CSSCompletions.js:
1253         (WebInspector.CSSCompletions.requestCSSNameCompletions):
1254         * inspector/front-end/CSSKeywordCompletions.js:
1255         (WebInspector.CSSKeywordCompletions.forProperty):
1256         (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
1257         * inspector/front-end/Checkbox.js:
1258         * inspector/front-end/ElementsPanel.js:
1259         * inspector/front-end/MetricsSidebarPane.js:
1260         (WebInspector.MetricsSidebarPane.prototype._updateMetrics):
1261         (WebInspector.MetricsSidebarPane.prototype.startEditing):
1262         (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
1263         * inspector/front-end/SourceCSSTokenizer.js:
1264         (WebInspector.SourceCSSTokenizer):
1265         * inspector/front-end/SourceCSSTokenizer.re2js:
1266         * inspector/front-end/StylesSidebarPane.js:
1267         (WebInspector.StylesSidebarPane.prototype.update):
1268         (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
1269         (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
1270         (WebInspector.StylePropertiesSection.prototype.onpopulate):
1271         (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
1272         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
1273         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
1274         (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
1275         (WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
1276         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
1277         (WebInspector.StylePropertyTreeElement.prototype):
1278         * inspector/front-end/externs.js:
1279         (WebInspector.linkifyResourceAsNode):
1280         (Element.prototype.scrollIntoViewIfNeeded):
1281         (Element.prototype.selectionLeftOffset):
1282         * inspector/front-end/inspector.js:
1283         * inspector/front-end/utilities.js:
1284
1285 2011-10-06  Pavel Feldman  <pfeldman@google.com>
1286
1287         Web Inspector: extract DOMPresentation, make EventListenersSidebar compile
1288         https://bugs.webkit.org/show_bug.cgi?id=69527
1289
1290         Reviewed by Yury Semikhatsky.
1291
1292         * WebCore.gypi:
1293         * WebCore.vcproj/WebCore.vcproj:
1294         * inspector/compile-front-end.sh:
1295         * inspector/front-end/DOMAgent.js:
1296         (WebInspector.DOMNode.prototype.nodeNameInCorrectCase):
1297         (WebInspector.DOMNode.prototype.moveTo):
1298         (WebInspector.DOMNode.prototype.isXMLNode):
1299         * inspector/front-end/DOMBreakpointsSidebarPane.js:
1300         (WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint):
1301         * inspector/front-end/DOMPresentation.js: Added.
1302         (WebInspector.DOMPresentation.decorateNodeLabel):
1303         (WebInspector.DOMPresentation.linkifyNodeReference):
1304         (WebInspector.DOMPresentation.linkifyNodeById):
1305         * inspector/front-end/ElementsPanel.js:
1306         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1307         * inspector/front-end/ElementsTreeOutline.js:
1308         (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
1309         * inspector/front-end/EventListenersSidebarPane.js:
1310         * inspector/front-end/ObjectPropertiesSection.js:
1311         * inspector/front-end/PropertiesSection.js:
1312         * inspector/front-end/Section.js:
1313         * inspector/front-end/StylesSidebarPane.js:
1314         (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
1315         (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
1316         * inspector/front-end/WebKit.qrc:
1317         * inspector/front-end/inspector.html:
1318
1319 2011-10-06  Pavel Feldman  <pfeldman@google.com>
1320
1321         Web Inspector: add all Resource panel views to the compilation.
1322         https://bugs.webkit.org/show_bug.cgi?id=69526
1323
1324         Reviewed by Yury Semikhatsky.
1325
1326         * inspector/compile-front-end.sh:
1327         * inspector/front-end/CookieItemsView.js:
1328         (WebInspector.CookieItemsView.prototype._contextMenu):
1329         (WebInspector.Cookies.cookieMatchesResourceURL):
1330         * inspector/front-end/CookiesTable.js:
1331         (WebInspector.CookiesTable):
1332         (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
1333         * inspector/front-end/DOMStorageItemsView.js:
1334         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
1335         * inspector/front-end/DataGrid.js:
1336         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid.comparator):
1337         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
1338         (WebInspector.DataGrid.createSortableDataGrid):
1339         * inspector/front-end/DatabaseQueryView.js:
1340         (WebInspector.DatabaseQueryView.prototype._queryFinished):
1341         * inspector/front-end/DatabaseTableView.js:
1342         (WebInspector.DatabaseTableView.prototype._queryFinished):
1343         * inspector/front-end/ResourcesPanel.js:
1344         (WebInspector.ResourcesPanel.prototype.reset):
1345         (WebInspector.ResourcesPanel.prototype.showDatabase):
1346         * inspector/front-end/TextPrompt.js:
1347
1348 2011-10-06  Pavel Feldman  <pfeldman@google.com>
1349
1350         Web Inspector: add all Resource panel views to the compilation.
1351         https://bugs.webkit.org/show_bug.cgi?id=69526
1352
1353         Reviewed by Yury Semikhatsky.
1354
1355         * inspector/compile-front-end.sh:
1356         * inspector/front-end/CookieItemsView.js:
1357         (WebInspector.CookieItemsView.prototype._contextMenu):
1358         (WebInspector.Cookies.cookieMatchesResourceURL):
1359         * inspector/front-end/CookiesTable.js:
1360         (WebInspector.CookiesTable):
1361         (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
1362         * inspector/front-end/DOMStorageItemsView.js:
1363         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
1364         * inspector/front-end/DataGrid.js:
1365         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid.comparator):
1366         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
1367         (WebInspector.DataGrid.createSortableDataGrid):
1368         * inspector/front-end/DatabaseQueryView.js:
1369         (WebInspector.DatabaseQueryView.prototype._queryFinished):
1370         * inspector/front-end/DatabaseTableView.js:
1371         (WebInspector.DatabaseTableView.prototype._queryFinished):
1372         * inspector/front-end/ResourcesPanel.js:
1373         (WebInspector.ResourcesPanel.prototype.reset):
1374         (WebInspector.ResourcesPanel.prototype.showDatabase):
1375         * inspector/front-end/TextPrompt.js:
1376
1377 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1378
1379         Unreviewed, rolling out r96791.
1380         http://trac.webkit.org/changeset/96791
1381         https://bugs.webkit.org/show_bug.cgi?id=69528
1382
1383         webkit_unit_tests broken on Mac and Win (Requested by
1384         hwennborg on #webkit).
1385
1386         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1387
1388 2011-10-05  Mikhail Naganov  <mnaganov@chromium.org>
1389
1390         Web Inspector: [Chromium] Heap Snapshot colors legend help popup is not shown.
1391         https://bugs.webkit.org/show_bug.cgi?id=69482
1392
1393         Reviewed by Yury Semikhatsky.
1394
1395         * inspector/front-end/DetailedHeapshotView.js:
1396         (WebInspector.DetailedHeapshotView.prototype._helpClicked):
1397
1398 2011-10-05  Pavel Feldman  <pfeldman@google.com>
1399
1400         Web Inspector: add 10 more front-end classes to the compilation process.
1401         https://bugs.webkit.org/show_bug.cgi?id=69445
1402
1403         Reviewed by Yury Semikhatsky.
1404
1405         * inspector/compile-front-end.sh:
1406         * inspector/front-end/HAREntry.js:
1407         * inspector/front-end/HandlerRegistry.js:
1408         * inspector/front-end/IFrameView.js:
1409         * inspector/front-end/JavaScriptSourceFrame.js:
1410         * inspector/front-end/PanelEnablerView.js:
1411         (WebInspector.PanelEnablerView):
1412         * inspector/front-end/PartialQuickSort.js:
1413         * inspector/front-end/PropertiesSidebarPane.js:
1414         (WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
1415         (WebInspector.PropertiesSidebarPane.prototype.update):
1416         * inspector/front-end/ShowMoreDataGridNode.js:
1417         * inspector/front-end/SidebarTreeElement.js:
1418         * inspector/front-end/TimelineAgent.js:
1419         * inspector/front-end/WelcomeView.js:
1420         * inspector/front-end/externs.js:
1421         (WebInspector.addMainEventListeners):
1422
1423 2011-10-05  Pavel Feldman  <pfeldman@google.com>
1424
1425         Web Inspector: make ElementsTreeOutline compile
1426         https://bugs.webkit.org/show_bug.cgi?id=69439
1427
1428         Reviewed by Yury Semikhatsky.
1429
1430         * inspector/compile-front-end.sh:
1431         * inspector/front-end/DOMAgent.js:
1432         * inspector/front-end/DOMSyntaxHighlighter.js:
1433         * inspector/front-end/ElementsPanel.js:
1434         (WebInspector.ElementsPanel.get this):
1435         (WebInspector.ElementsPanel):
1436         (WebInspector.ElementsPanel.prototype._populateContextMenu):
1437         (WebInspector.ElementsPanel.prototype._inspectElementRequested):
1438         * inspector/front-end/ElementsTreeOutline.js:
1439         (WebInspector.ElementsTreeOutline):
1440         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
1441         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
1442         (WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes):
1443         (WebInspector.ElementsTreeOutline.prototype._populateContextMenu):
1444         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
1445         (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
1446         (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
1447         (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
1448         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
1449         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
1450         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
1451         ():
1452         * inspector/front-end/externs.js:
1453         (WebInspector.highlightDOMNode):
1454         (WebInspector.resourceURLForRelatedNode):
1455
1456 2011-10-06  Pavel Feldman  <pfeldman@google.com>
1457
1458         Web Inspector: Inspector fails to start if there was at least one watch expression.
1459         https://bugs.webkit.org/show_bug.cgi?id=69516
1460
1461         Reviewed by Yury Semikhatsky.
1462
1463         * inspector/front-end/ConsoleView.js:
1464         * inspector/front-end/WatchExpressionsSidebarPane.js:
1465         (WebInspector.WatchExpressionsSidebarPane):
1466
1467 2011-10-06  Dominic Cooney   <dominicc@chromium.org>
1468
1469         Don't make virtual calls in Node::parentNode.
1470         https://bugs.webkit.org/show_bug.cgi?id=69266
1471
1472         Reviewed by Antti Koivisto.
1473
1474         ShadowRoot and SVGShadowRoot remain semantically separate (eg
1475         isShadowRoot/isSVGShadowRoot) but share a flag
1476         (IsShadowRootOrSVGShadowRootFlag, hitherto IsShadowRootFlag just
1477         for ShadowRoot). In combination with IsSVGFlag ShadowRoot (false)
1478         can be distinguished from SVGShadowRoot (true). This lets us make
1479         isSVGShadowRoot non-virtual.
1480
1481         No change in behavior => No new tests.
1482
1483         * dom/Node.cpp:
1484         (WebCore::Node::shadowHost):
1485         * dom/Node.h:
1486         (WebCore::Node::isSVGShadowRoot):
1487         (WebCore::Node::isShadowRoot):
1488         (WebCore::Node::parentNode):
1489         (WebCore::Node::parentNodeGuaranteedHostFree):
1490         * rendering/svg/SVGShadowTreeElements.cpp:
1491         (WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement):
1492         (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement):
1493         * rendering/svg/SVGShadowTreeElements.h:
1494         * svg/SVGElement.cpp:
1495         (WebCore::SVGElement::SVGElement):
1496         * svg/SVGElement.h:
1497         * svg/SVGGElement.cpp:
1498         (WebCore::SVGGElement::SVGGElement):
1499         * svg/SVGGElement.h:
1500         * svg/SVGStyledElement.cpp:
1501         (WebCore::SVGStyledElement::SVGStyledElement):
1502         * svg/SVGStyledElement.h:
1503         * svg/SVGStyledLocatableElement.cpp:
1504         (WebCore::SVGStyledLocatableElement::SVGStyledLocatableElement):
1505         * svg/SVGStyledLocatableElement.h:
1506         * svg/SVGStyledTransformableElement.cpp:
1507         (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
1508         * svg/SVGStyledTransformableElement.h:
1509
1510 2011-10-06  John Knottenbelt  <jknotten@chromium.org>
1511
1512         Take pageScaleFactor into account for MouseRelatedEvents.
1513         https://bugs.webkit.org/show_bug.cgi?id=67592
1514
1515         Reviewed by Tony Gentilcore.
1516
1517         Tests: fast/events/page-scaled-mouse-click-iframe.html
1518                fast/events/page-scaled-mouse-click.html
1519
1520         * dom/MouseRelatedEvent.cpp:
1521         (WebCore::contentsScrollOffset):
1522         (WebCore::MouseRelatedEvent::MouseRelatedEvent):
1523         (WebCore::frameScaleFactor):
1524         (WebCore::MouseRelatedEvent::computePageLocation):
1525         (WebCore::MouseRelatedEvent::computeRelativePosition):
1526
1527 2011-10-03  Hans Wennborg  <hans@chromium.org>
1528
1529         IndexedDB: Remove SQLite-LevelDB migration code
1530         https://bugs.webkit.org/show_bug.cgi?id=69264
1531
1532         Reviewed by Tony Chang.
1533
1534         Remove migration functionality.
1535
1536         Just removing code, so no new tests.
1537
1538         * storage/IDBFactoryBackendImpl.cpp:
1539         (WebCore::IDBFactoryBackendImpl::open):
1540         * storage/IDBFactoryBackendImpl.h:
1541
1542 2011-10-06  James Robinson  <jamesr@chromium.org>
1543
1544         [chromium] Remove USE(THREADED_COMPOSITING) from the tree
1545         https://bugs.webkit.org/show_bug.cgi?id=69489
1546
1547         Reviewed by Darin Fisher.
1548
1549         This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.
1550
1551         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1552
1553 2011-10-05  Kentaro Hara  <haraken@chromium.org>
1554
1555         Refactor IDL attributes about constructor
1556         https://bugs.webkit.org/show_bug.cgi?id=69074
1557
1558         Reviewed by Adam Barth.
1559
1560         Currently, IDL attributes about constructor are confusing:
1561
1562         - [CustomConstructFunction] means that there is a custom constructor for JSC.
1563         - [V8CustomConstructor] means that there is a custom constructor for V8.
1564         - [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files.
1565         - For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time.
1566         - ObjC, CPP and GObject bindings do not support custom constructors.
1567
1568         This patch makes the following changes:
1569
1570         - Rename [CustomConstructFunction] to [JSCustomConstructor].
1571         - [JSCustomConstructor] means that there is a custom constructor for JSC.
1572         - [V8CustomConstructor] means that there is a custom constructor for V8.
1573         - [CustomConstructor] means that there is a custom constructor for both JSC and V8.
1574
1575         No new tests. No change in behavior. Confirm that build succeeds.
1576
1577         * bindings/scripts/CodeGeneratorJS.pm: Removed [CustomConstructFunction] and added [JSCustomConstructor]
1578         (GenerateHeader):
1579         (GenerateAttributesHashTable):
1580         (GenerateImplementation):
1581         (GenerateConstructorDefinition):
1582         * css/WebKitCSSMatrix.idl: Renamed [CustomConstructFunction] to [JSCustomConstructor]. If both [JSCustomConstructor] and [V8CustomConstructor] are specified, then we replaced them with [CustomConstructor].
1583         * dom/CustomEvent.idl: Ditto.
1584         * dom/ErrorEvent.idl: Ditto.
1585         * dom/Event.idl: Ditto.
1586         * dom/HashChangeEvent.idl: Ditto.
1587         * dom/MessageChannel.idl: Ditto.
1588         * dom/MessageEvent.idl: Ditto.
1589         * dom/PageTransitionEvent.idl: Ditto.
1590         * dom/PopStateEvent.idl: Ditto.
1591         * dom/ProgressEvent.idl: Ditto.
1592         * dom/WebKitAnimationEvent.idl: Ditto.
1593         * html/DOMFormData.idl: Ditto.
1594         * html/canvas/ArrayBuffer.idl: Ditto.
1595         * html/canvas/DataView.idl: Ditto.
1596         * html/canvas/Float32Array.idl: Ditto.
1597         * html/canvas/Float64Array.idl: Ditto.
1598         * html/canvas/Int16Array.idl: Ditto.
1599         * html/canvas/Int32Array.idl: Ditto.
1600         * html/canvas/Int8Array.idl: Ditto.
1601         * html/canvas/Uint16Array.idl: Ditto.
1602         * html/canvas/Uint32Array.idl: Ditto.
1603         * html/canvas/Uint8Array.idl: Ditto.
1604         * p2p/PeerConnection.idl: Ditto.
1605         * page/EventSource.idl: Ditto.
1606         * page/WebKitPoint.idl: Ditto.
1607         * webaudio/AudioContext.idl: Ditto.
1608         * websockets/CloseEvent.idl: Ditto.
1609         * websockets/WebSocket.idl: Ditto.
1610         * workers/SharedWorker.idl: Ditto.
1611         * workers/Worker.idl: Ditto.
1612         * xml/XMLHttpRequest.idl: Ditto.
1613         * xml/XSLTProcessor.idl: Ditto.
1614
1615 2011-10-03  Andy Estes  <aestes@apple.com>
1616
1617         Add the option to suppress rendering until the document's load event fires.
1618         https://bugs.webkit.org/show_bug.cgi?id=69298
1619
1620         Reviewed by Simon Fraser.
1621
1622         Add a WebCore setting that suppresses painting and compositing layer
1623         updates until the document's load event fires. This masks the effects
1624         of incremental rendering (for clients that opt in) by ensuring that all
1625         sub-resources have loaded and a full layout has taken place before
1626         painting the document for the first time.
1627
1628         No tests currently possible. Testing this would require the ability for
1629         DRT to dump state while resources are loading, which it doesn't
1630         currently do.
1631
1632         * dom/Document.cpp:
1633         (WebCore::Document::implicitClose): If rendering was previously
1634         suppressed, force a repaint and compositing layer update.
1635         (WebCore::Document::visualUpdatesAllowed): Add a helper method to
1636         determine if the document is in a state where rendering is allowed.
1637         * dom/Document.h:
1638         * page/Settings.cpp:
1639         (WebCore::Settings::Settings):
1640         * page/Settings.h:
1641         (WebCore::Settings::setSuppressIncrementalRendering):
1642         (WebCore::Settings::suppressIncrementalRendering):
1643         * rendering/RenderLayer.cpp:
1644         (WebCore::shouldSuppressPaintingLayer): Encapsulate the FOUC and
1645         painting suppression checks into a single helper function for
1646         readability's sake.
1647         (WebCore::RenderLayer::paintLayer):
1648         * rendering/RenderLayerCompositor.cpp:
1649         (WebCore::RenderLayerCompositor::updateCompositingLayers): If we should
1650         suppress compositing layer updates and the load event has yet to fire,
1651         return early.
1652
1653 2011-10-05  Yuta Kitamura  <yutak@chromium.org>
1654
1655         WebSocket: Add extensions attribute
1656         https://bugs.webkit.org/show_bug.cgi?id=69408
1657
1658         Reviewed by Kent Tamura.
1659
1660         Add WebSocket's "extensions" attribute as specified in the WebSocket API
1661         <http://dev.w3.org/html5/websockets/#the-websocket-interface>.
1662
1663         WebSocket protocol extension is not implemented at all, thus this attribute
1664         always returns an empty string.
1665
1666         Test: http/tests/websocket/tests/hybi/extensions.html
1667               http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)
1668
1669         * websockets/WebSocket.cpp:
1670         (WebCore::WebSocket::extensions):
1671         If the hixie-76 protocol is chosen, we need to return "undefined" in order to
1672         keep behavior of the ports which have not used the newer hybi protocol yet.
1673         * websockets/WebSocket.h:
1674         * websockets/WebSocket.idl:
1675
1676 2011-10-05  Dominic Cooney  <dominicc@chromium.org>
1677
1678         IsShadowRootFlag should not depend on whether a ShadowRoot is attached to a host.
1679         https://bugs.webkit.org/show_bug.cgi?id=69406
1680
1681         Reviewed by Hajime Morita.
1682
1683         No change in behavior => No new tests.
1684
1685         * dom/Node.cpp:
1686         (WebCore::Node::setShadowHost): Don't twiddle the flag.
1687         * dom/Node.h:
1688         * dom/ShadowRoot.cpp:
1689         (WebCore::ShadowRoot::ShadowRoot): Set the IsShadowRootFlag on creation.
1690         * dom/TreeScope.cpp:
1691         (WebCore::TreeScope::TreeScope): Let ShadowRoot set creation flags.
1692         * dom/TreeScope.h:
1693
1694 2011-10-05  Chris Rogers  <crogers@google.com>
1695
1696         Define a log2f() function for Windows in wtf/MathExtras.h
1697         https://bugs.webkit.org/show_bug.cgi?id=69491
1698
1699         Reviewed by Darin Adler.
1700
1701         No new tests. This change is tested in existing layout tests.
1702
1703         * webaudio/AudioParamTimeline.cpp:
1704         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
1705
1706 2011-10-05  Erik Arvidsson  <arv@chromium.org>
1707
1708         window.location.href and others needlessly decodes URI-encoded characters
1709         https://bugs.webkit.org/show_bug.cgi?id=30225
1710
1711         Reviewed by Darin Adler.
1712
1713         Don't decode KURL::path() and stop using KURL::deprecatedString() in Location methods.
1714
1715         This slightly changes how we parse data and javascript URLs (non hierarchical URLs) to
1716         not encode so aggressively.
1717
1718         * fileapi/DOMFileSystemBase.cpp:
1719         (WebCore::DOMFileSystemBase::crackFileSystemURL): Manually decode path()
1720         * loader/FrameLoader.cpp:
1721         (WebCore::FrameLoader::defaultObjectContentType): Manually decode path()
1722         * page/Location.cpp:
1723         (WebCore::Location::href): Use string() instead of deprecatedString()
1724         * page/Location.h:
1725         (WebCore::Location::toString): Inline call to href()
1726         * platform/KURL.cpp:
1727         (WebCore::KURL::path): Don't decode.
1728         (WebCore::escapeAndAppendNonHierarchicalPart): Rename escapeAndAppendFragment to escapeAndAppendNonHierarchicalPart
1729                                                        since this is now used for more than just fragments.
1730         (WebCore::KURL::parse): Don't decode
1731         * platform/KURLGoogle.cpp:
1732         (WebCore::KURL::path): Remove out of date comment
1733         * platform/qt/KURLQt.cpp:
1734         (WebCore::KURL::fileSystemPath): Manually decode path()
1735         * platform/win/ClipboardWin.cpp:
1736         (WebCore::createGlobalHDropContent): Manually decode path()
1737         * workers/WorkerLocation.cpp:
1738         (WebCore::WorkerLocation::href): Use string() instead of deprecatedString()
1739         * workers/WorkerLocation.h:
1740         (WebCore::WorkerLocation::toString): Inline call to href()
1741
1742 2011-10-05  Darin Adler  <darin@apple.com>
1743
1744         [Mac] Use four more named cursors if present
1745         https://bugs.webkit.org/show_bug.cgi?id=69488
1746
1747         Reviewed by Dan Bernstein.
1748
1749         * platform/mac/CursorMac.mm:
1750         (WebCore::Cursor::ensurePlatformCursor): Use the names "Help", "Cell",
1751         "ZoomIn", and "ZoomOut" to get those cursors. Structure the code so it
1752         falls back if the cursors are not present.
1753
1754 2011-10-05  Tony Chang  <tony@chromium.org>
1755
1756         force margin:auto to 0 in flex items
1757         https://bugs.webkit.org/show_bug.cgi?id=69475
1758
1759         Reviewed by Ojan Vafai.
1760
1761         The spec used to say the margin had a value of flex(1 0 0), but changed to just be 0.
1762
1763         * rendering/RenderFlexibleBox.cpp:
1764         (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
1765         (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
1766
1767 2011-10-05  Dean Jackson  <dino@apple.com>
1768
1769         Computed style for filter property
1770         https://bugs.webkit.org/show_bug.cgi?id=68477
1771
1772         Reviewed by Simon Fraser.
1773
1774         Reports the computed style for the new -webkit-filter
1775         property value.
1776
1777         Test: css3/filters/filter-property-computed-style.html
1778
1779         * css/CSSComputedStyleDeclaration.cpp:
1780         (WebCore::computedFilter):
1781         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1782
1783 2011-10-05  Jer Noble  <jer.noble@apple.com>
1784
1785         Enable WEB_AUDIO by default in the WebKit/mac port.
1786         https://bugs.webkit.org/show_bug.cgi?id=68587
1787
1788         Reviewed by Simon Fraser.
1789
1790         No new tests; existing webaudio/ layout tests cover this.
1791
1792         * Configurations/FeatureDefines.xcconfig:
1793         * WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to
1794             the WebCore.framework bundle.
1795
1796 2011-10-03  Ojan Vafai  <ojan@chromium.org>
1797
1798         [flexbox] take marginBeforeForChild into account when positioning children
1799         https://bugs.webkit.org/show_bug.cgi?id=69313
1800
1801         Reviewed by Tony Chang.
1802
1803         * rendering/RenderFlexibleBox.cpp:
1804         (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
1805
1806 2011-10-05  Vangelis Kokkevis  <vangelis@chromium.org>
1807
1808         Switching threaded compositor from a compile time option to a
1809         run time one.
1810         https://bugs.webkit.org/show_bug.cgi?id=69391
1811
1812         Reviewed by Darin Fisher.
1813
1814         Mostly converted #if USE(THREADED_COMPOSITING) to a regular if statements.
1815         In addition, CCLayerTreeHost::scheduleComposite() is removed as it wasn't being
1816         called from anywhere, 
1817
1818         No new tests as it doesn't add new functionality.
1819
1820         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
1821         (WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
1822         (WebCore::CCLayerTreeHost::setNeedsRedraw):
1823         (WebCore::CCLayerTreeHost::composite):
1824         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1825         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
1826         (WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
1827         (WebCore::CCSingleThreadProxy::compositeImmediately):
1828         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
1829
1830 2011-10-05  Dean Jackson  <dino@apple.com>
1831
1832         Parse '-webkit-filter' property syntax
1833         https://bugs.webkit.org/show_bug.cgi?id=68473
1834
1835         Reviewed by Nikolas Zimmermann.
1836
1837         Parse the new -webkit-filter property, looking for shorthand
1838         functions then testing number, type and value of parameters.
1839
1840         Note that support for drop-shadow() was omitted from this
1841         patch because parsing CSS shadow syntax was going to require some
1842         refactoring of the box and text shadow code. The followup
1843         bug is https://bugs.webkit.org/show_bug.cgi?id=69108.
1844
1845         Also, computed style will return null for filters at the moment.
1846         That's https://bugs.webkit.org/show_bug.cgi?id=68477.
1847
1848         Tests: css3/filters/filter-property-parsing-invalid.html
1849                css3/filters/filter-property-parsing.html
1850
1851         * CMakeLists.txt:
1852         * CodeGenerators.pri:
1853         * DerivedSources.cpp:
1854         * DerivedSources.make:
1855         * GNUmakefile.list.am:
1856         * WebCore.gypi:
1857         * WebCore.pro:
1858         * WebCore.vcproj/WebCore.vcproj:
1859         * WebCore.xcodeproj/project.pbxproj:
1860             Build files updated for new WebKitCSSFilterValue classes.
1861         * bindings/js/JSCSSValueCustom.cpp:
1862         (WebCore::toJS):
1863         * bindings/objc/DOMCSS.mm:
1864             Test if value is WebKitCSSFilterValue.
1865         * css/CSSParser.cpp:
1866         (WebCore::filterInfoForName):
1867         (WebCore::CSSParser::isValidFilterArgument):
1868         (WebCore::CSSParser::parseFilter):
1869         * css/CSSParser.h:
1870         * css/CSSStyleSelector.cpp:
1871         (WebCore::CSSStyleSelector::applyProperty):
1872         (WebCore::filterOperationForType):
1873         (WebCore::CSSStyleSelector::createFilterOperations):
1874         * css/CSSStyleSelector.h:
1875             Handle the new shorthand functions in -webkit-filter.
1876         * css/CSSValue.h:
1877         (WebCore::CSSValue::isWebKitCSSFilterValue):
1878             Add virtual function that returns false here.
1879         * css/WebKitCSSFilterValue.cpp: Added.
1880         (WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
1881         (WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):
1882         (WebCore::WebKitCSSFilterValue::cssText):
1883         * css/WebKitCSSFilterValue.h: Added.
1884         (WebCore::WebKitCSSFilterValue::create):
1885         (WebCore::WebKitCSSFilterValue::operationType):
1886         (WebCore::WebKitCSSFilterValue::isWebKitCSSFilterValue):
1887         * css/WebKitCSSFilterValue.idl: Added.
1888             WebKitCSSFilterValue modelled closely on WebKitCSSTransformValue,
1889             basically identifying the type of operation in a CSSValueList.
1890         * page/DOMWindow.idl:
1891             New WebKitCSSFilterValue constructor.
1892         * platform/graphics/filters/FilterOperation.h:
1893         (WebCore::BlurFilterOperation::create):
1894         (WebCore::BlurFilterOperation::stdDeviationX):
1895         (WebCore::BlurFilterOperation::stdDeviationY):
1896         (WebCore::BlurFilterOperation::BlurFilterOperation):
1897         (WebCore::SharpenFilterOperation::create):
1898         (WebCore::SharpenFilterOperation::radius):
1899         (WebCore::SharpenFilterOperation::threshold):
1900         (WebCore::SharpenFilterOperation::SharpenFilterOperation):
1901             Use Length rather than double for parameters that are CSS lengths.
1902
1903 2011-10-05  Chris Rogers  <crogers@google.com>
1904
1905         Fix Windows build - it doesn't have a log2f() function...
1906         https://bugs.webkit.org/show_bug.cgi?id=69473
1907
1908         Unreviewed build fix.
1909
1910         * webaudio/AudioParamTimeline.cpp:
1911         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
1912
1913 2011-10-05  James Robinson  <jamesr@chromium.org>
1914
1915         [chromium] ASSERT triggered when gpu process lost in single-threaded compositing path
1916         https://bugs.webkit.org/show_bug.cgi?id=69467
1917
1918         Reviewed by Kenneth Russell.
1919
1920         Shuffles debug-only bookkeeping around to more closely match what we do in the threaded path and not trip a
1921         false-positive ASSERT().
1922
1923         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
1924         (WebCore::CCSingleThreadProxy::doComposite):
1925
1926 2011-10-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1927
1928         Unreviewed, rolling out r96756.
1929         http://trac.webkit.org/changeset/96756
1930         https://bugs.webkit.org/show_bug.cgi?id=69472
1931
1932         Many builds broken due to WTFGetBacktrace not being exported
1933         from JavaScriptCore (Requested by aroben on #webkit).
1934
1935         * dom/ScriptElement.cpp:
1936         (WebCore::ScriptElement::ScriptElement):
1937         (WebCore::ScriptElement::stopLoadRequest):
1938         (WebCore::ScriptElement::notifyFinished):
1939         * dom/ScriptElement.h:
1940
1941 2011-10-05  Gavin Peters  <gavinp@chromium.org>
1942
1943         save resource zeroing stacks in ScriptElement for debugging
1944         https://bugs.webkit.org/show_bug.cgi?id=69453
1945
1946         The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
1947         two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
1948         75604).  This patch will save a stack in the ScriptElement when this happens, so that if
1949         we do later crash, we can see how we did the first zeroing.
1950
1951         See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
1952         this change will help track down.
1953
1954         Reviewed by Nate Chapin.
1955
1956         No new tests, this shouldn't affect output at all, and isn't particularly testable.
1957
1958         * dom/ScriptElement.cpp:
1959         (WebCore::ScriptElement::ScriptElement):
1960         (WebCore::ScriptElement::stopLoadRequest):
1961         (WebCore::ScriptElement::notifyFinished):
1962         * dom/ScriptElement.h:
1963
1964 2011-10-05  Alexey Proskuryakov  <ap@apple.com>
1965
1966         More build fix.
1967
1968         * WebCore.exp.in: Made a typo in a last minute change for my 32-bit build fix.
1969
1970 2011-10-05  Anna Cavender  <annacc@chromium.org>
1971
1972         Fix CueParser::didFinishLoading to match changes in ThreadableLoaderClient
1973         https://bugs.webkit.org/show_bug.cgi?id=69456
1974
1975         Reviewed by David Levin.
1976
1977         No new tests. No new functionality.
1978
1979         * html/track/CueParser.cpp:
1980         (WebCore::CueParser::didFinishLoading):
1981         * html/track/CueParser.h:
1982
1983 2011-10-05  Alexey Proskuryakov  <ap@apple.com>
1984
1985         32-bit build fix.
1986
1987         * WebCore.exp.in: In 32-bit, WebCore needs to export both NSSize and CGSize constructors.
1988         In 64-bit, NSSize is just a typedef for CGSize. Also fixed conversion operators, for good measure.
1989
1990 2011-10-05  Jer Noble  <jer.noble@apple.com>
1991
1992         WEB_AUDIO does not compile on Leopard 32-bit.
1993         https://bugs.webkit.org/show_bug.cgi?id=69292
1994
1995         Reviewed by Simon Fraser.
1996
1997         No new tests; covered by all existing audio tests.
1998
1999         Use of float and double within the WEB_AUDIO implementation have been harmonized, with most
2000         calculations done using floats, with narrowPrecisionToFloat() added when necessary to
2001         narrow double results down to floats, and with float constants initialized with float values:
2002         * platform/audio/AudioBus.cpp:
2003         (WebCore::AudioBus::AudioBus):
2004         (WebCore::AudioBus::createByMixingToMono):
2005         * platform/audio/AudioBus.h:
2006         (WebCore::AudioBus::sampleRate):
2007         (WebCore::AudioBus::setSampleRate):
2008         * platform/audio/AudioDSPKernel.h:
2009         (WebCore::AudioDSPKernel::AudioDSPKernel):
2010         (WebCore::AudioDSPKernel::sampleRate):
2011         * platform/audio/AudioDSPKernelProcessor.cpp:
2012         (WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):
2013         * platform/audio/AudioDSPKernelProcessor.h:
2014         * platform/audio/AudioDestination.h:
2015         * platform/audio/AudioFileReader.h:
2016         * platform/audio/AudioProcessor.h:
2017         (WebCore::AudioProcessor::AudioProcessor):
2018         (WebCore::AudioProcessor::sampleRate):
2019         * platform/audio/AudioUtilities.cpp:
2020         (WebCore::AudioUtilities::decibelsToLinear):
2021         (WebCore::AudioUtilities::linearToDecibels):
2022         (WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
2023         * platform/audio/AudioUtilities.h:
2024         * platform/audio/DynamicsCompressor.cpp:
2025         (WebCore::DynamicsCompressor::DynamicsCompressor):
2026         (WebCore::DynamicsCompressor::initializeParameters):
2027         (WebCore::DynamicsCompressor::parameterValue):
2028         (WebCore::DynamicsCompressor::setEmphasisStageParameters):
2029         (WebCore::DynamicsCompressor::process):
2030         * platform/audio/DynamicsCompressor.h:
2031         (WebCore::DynamicsCompressor::sampleRate):
2032         (WebCore::DynamicsCompressor::nyquist):
2033         * platform/audio/DynamicsCompressorKernel.cpp:
2034         (WebCore::saturate):
2035         (WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
2036         (WebCore::DynamicsCompressorKernel::process):
2037         * platform/audio/DynamicsCompressorKernel.h:
2038         * platform/audio/EqualPowerPanner.cpp:
2039         (WebCore::EqualPowerPanner::EqualPowerPanner):
2040         * platform/audio/EqualPowerPanner.h:
2041         * platform/audio/HRTFDatabase.cpp:
2042         (WebCore::HRTFDatabase::create):
2043         (WebCore::HRTFDatabase::HRTFDatabase):
2044         * platform/audio/HRTFDatabase.h:
2045         (WebCore::HRTFDatabase::sampleRate):
2046         * platform/audio/HRTFDatabaseLoader.cpp:
2047         (WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
2048         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
2049         * platform/audio/HRTFDatabaseLoader.h:
2050         (WebCore::HRTFDatabaseLoader::databaseSampleRate):
2051         * platform/audio/HRTFElevation.cpp:
2052         (WebCore::HRTFElevation::calculateSymmetricKernelsForAzimuthElevation):
2053         (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
2054         (WebCore::HRTFElevation::createForSubject):
2055         (WebCore::HRTFElevation::createByInterpolatingSlices):
2056         * platform/audio/HRTFElevation.h:
2057         (WebCore::HRTFElevation::sampleRate):
2058         (WebCore::HRTFElevation::HRTFElevation):
2059         * platform/audio/HRTFKernel.cpp:
2060         (WebCore::extractAverageGroupDelay):
2061         (WebCore::HRTFKernel::HRTFKernel):
2062         (WebCore::HRTFKernel::createInterpolatedKernel):
2063         * platform/audio/HRTFKernel.h:
2064         (WebCore::HRTFKernel::create):
2065         (WebCore::HRTFKernel::frameDelay):
2066         (WebCore::HRTFKernel::sampleRate):
2067         (WebCore::HRTFKernel::HRTFKernel):
2068         * platform/audio/HRTFPanner.cpp:
2069         (WebCore::HRTFPanner::HRTFPanner):
2070         (WebCore::HRTFPanner::fftSizeForSampleRate):
2071         * platform/audio/HRTFPanner.h:
2072         (WebCore::HRTFPanner::sampleRate):
2073         * platform/audio/Panner.cpp:
2074         (WebCore::Panner::create):
2075         * platform/audio/Panner.h:
2076         * platform/audio/chromium/AudioBusChromium.cpp:
2077         (WebCore::AudioBus::loadPlatformResource):
2078         * platform/audio/mac/AudioBusMac.mm:
2079         (WebCore::AudioBus::loadPlatformResource):
2080         * platform/audio/mac/AudioDestinationMac.cpp:
2081         (WebCore::AudioDestination::create):
2082         (WebCore::AudioDestination::hardwareSampleRate):
2083         (WebCore::AudioDestinationMac::AudioDestinationMac):
2084         * platform/audio/mac/AudioDestinationMac.h:
2085         (WebCore::AudioDestinationMac::sampleRate):
2086         * platform/audio/mac/AudioFileReaderMac.cpp:
2087         (WebCore::AudioFileReader::createBus):
2088         (WebCore::createBusFromAudioFile):
2089         (WebCore::createBusFromInMemoryAudioFile):
2090         * platform/audio/mac/AudioFileReaderMac.h:
2091         * webaudio/AsyncAudioDecoder.cpp:
2092         (WebCore::AsyncAudioDecoder::decodeAsync):
2093         (WebCore::AsyncAudioDecoder::DecodingTask::create):
2094         (WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask):
2095         * webaudio/AsyncAudioDecoder.h:
2096         (WebCore::AsyncAudioDecoder::DecodingTask::sampleRate):
2097         * webaudio/AudioBasicProcessorNode.cpp:
2098         (WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
2099         * webaudio/AudioBasicProcessorNode.h:
2100         * webaudio/AudioBuffer.cpp:
2101         (WebCore::AudioBuffer::create):
2102         (WebCore::AudioBuffer::createFromAudioFileData):
2103         (WebCore::AudioBuffer::AudioBuffer):
2104         * webaudio/AudioBuffer.h:
2105         (WebCore::AudioBuffer::sampleRate):
2106         * webaudio/AudioBufferSourceNode.cpp:
2107         (WebCore::AudioBufferSourceNode::create):
2108         (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
2109         (WebCore::AudioBufferSourceNode::process):
2110         (WebCore::AudioBufferSourceNode::renderFromBuffer):
2111         * webaudio/AudioBufferSourceNode.h:
2112         * webaudio/AudioChannelMerger.cpp:
2113         (WebCore::AudioChannelMerger::AudioChannelMerger):
2114         * webaudio/AudioChannelMerger.h:
2115         (WebCore::AudioChannelMerger::create):
2116         * webaudio/AudioChannelSplitter.cpp:
2117         (WebCore::AudioChannelSplitter::AudioChannelSplitter):
2118         * webaudio/AudioChannelSplitter.h:
2119         (WebCore::AudioChannelSplitter::create):
2120         * webaudio/AudioContext.cpp:
2121         (WebCore::AudioContext::createOfflineContext):
2122         (WebCore::AudioContext::AudioContext):
2123         (WebCore::AudioContext::createBuffer):
2124         * webaudio/AudioContext.h:
2125         (WebCore::AudioContext::sampleRate):
2126         * webaudio/AudioDestinationNode.cpp:
2127         (WebCore::AudioDestinationNode::AudioDestinationNode):
2128         * webaudio/AudioDestinationNode.h:
2129         * webaudio/AudioGainNode.cpp:
2130         (WebCore::AudioGainNode::AudioGainNode):
2131         * webaudio/AudioGainNode.h:
2132         (WebCore::AudioGainNode::create):
2133         * webaudio/AudioListener.cpp:
2134         (WebCore::AudioListener::AudioListener):
2135         * webaudio/AudioListener.h:
2136         (WebCore::AudioListener::setPosition):
2137         (WebCore::AudioListener::setOrientation):
2138         (WebCore::AudioListener::setVelocity):
2139         * webaudio/AudioNode.cpp:
2140         (WebCore::AudioNode::AudioNode):
2141         * webaudio/AudioNode.h:
2142         (WebCore::AudioNode::sampleRate):
2143         * webaudio/AudioPannerNode.cpp:
2144         (WebCore::AudioPannerNode::AudioPannerNode):
2145         (WebCore::AudioPannerNode::getAzimuthElevation):
2146         * webaudio/AudioPannerNode.h:
2147         (WebCore::AudioPannerNode::create):
2148         * webaudio/AudioParam.cpp:
2149         (WebCore::AudioParam::value):
2150         (WebCore::AudioParam::smoothedValue):
2151         (WebCore::AudioParam::smooth):
2152         (WebCore::AudioParam::calculateSampleAccurateValues):
2153         * webaudio/AudioParamTimeline.cpp:
2154         (WebCore::AudioParamTimeline::valueForContextTime):
2155         (WebCore::timeToSampleFrame):
2156         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
2157         * webaudio/AudioSourceNode.h:
2158         (WebCore::AudioSourceNode::AudioSourceNode):
2159         * webaudio/BiquadFilterNode.cpp:
2160         (WebCore::BiquadFilterNode::BiquadFilterNode):
2161         * webaudio/BiquadFilterNode.h:
2162         (WebCore::BiquadFilterNode::create):
2163         * webaudio/BiquadProcessor.cpp:
2164         (WebCore::BiquadProcessor::BiquadProcessor):
2165         * webaudio/BiquadProcessor.h:
2166         * webaudio/ConvolverNode.cpp:
2167         (WebCore::ConvolverNode::ConvolverNode):
2168         * webaudio/ConvolverNode.h:
2169         (WebCore::ConvolverNode::create):
2170         * webaudio/DefaultAudioDestinationNode.cpp:
2171         (WebCore::DefaultAudioDestinationNode::initialize):
2172         * webaudio/DefaultAudioDestinationNode.h:
2173         (WebCore::DefaultAudioDestinationNode::sampleRate):
2174         * webaudio/DelayDSPKernel.cpp:
2175         (WebCore::DelayDSPKernel::DelayDSPKernel):
2176         (WebCore::DelayDSPKernel::process):
2177         * webaudio/DelayDSPKernel.h:
2178         * webaudio/DelayNode.cpp:
2179         (WebCore::DelayNode::DelayNode):
2180         * webaudio/DelayNode.h:
2181         (WebCore::DelayNode::create):
2182         * webaudio/DelayProcessor.cpp:
2183         (WebCore::DelayProcessor::DelayProcessor):
2184         * webaudio/DelayProcessor.h:
2185         * webaudio/DynamicsCompressorNode.cpp:
2186         (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
2187         * webaudio/DynamicsCompressorNode.h:
2188         (WebCore::DynamicsCompressorNode::create):
2189         * webaudio/HighPass2FilterNode.cpp:
2190         (WebCore::HighPass2FilterNode::HighPass2FilterNode):
2191         * webaudio/HighPass2FilterNode.h:
2192         (WebCore::HighPass2FilterNode::create):
2193         * webaudio/JavaScriptAudioNode.cpp:
2194         (WebCore::JavaScriptAudioNode::create):
2195         (WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
2196         (WebCore::JavaScriptAudioNode::initialize):
2197         * webaudio/JavaScriptAudioNode.h:
2198         * webaudio/LowPass2FilterNode.cpp:
2199         (WebCore::LowPass2FilterNode::LowPass2FilterNode):
2200         * webaudio/LowPass2FilterNode.h:
2201         (WebCore::LowPass2FilterNode::create):
2202         * webaudio/OfflineAudioDestinationNode.h:
2203         (WebCore::OfflineAudioDestinationNode::sampleRate):
2204         * webaudio/RealtimeAnalyserNode.cpp:
2205         (WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):
2206         * webaudio/RealtimeAnalyserNode.h:
2207         (WebCore::RealtimeAnalyserNode::create):
2208         * webaudio/WaveShaperDSPKernel.cpp:
2209         (WebCore::WaveShaperDSPKernel::process):
2210         * webaudio/WaveShaperProcessor.cpp:
2211         (WebCore::WaveShaperProcessor::WaveShaperProcessor):
2212         * webaudio/WaveShaperProcessor.h:
2213
2214
2215 2011-10-05  Alexey Proskuryakov  <ap@apple.com>
2216
2217         [Mac] Make built-in PDF description localizable
2218         https://bugs.webkit.org/show_bug.cgi?id=69442
2219
2220         Reviewed by Dan Bernstein.
2221
2222         Added strings for plug-in's name and for its supported MIME type.
2223
2224         * English.lproj/Localizable.strings:
2225         * WebCore.exp.in:
2226         * platform/DefaultLocalizationStrategy.cpp:
2227         (WebCore::DefaultLocalizationStrategy::builtInPDFPluginName):
2228         (WebCore::DefaultLocalizationStrategy::pdfDocumentTypeDescription):
2229         * platform/DefaultLocalizationStrategy.h:
2230         * platform/LocalizationStrategy.h:
2231         * platform/LocalizedStrings.cpp:
2232         (WebCore::builtInPDFPluginName):
2233         (WebCore::pdfDocumentTypeDescription):
2234         * platform/LocalizedStrings.h:
2235
2236 2011-10-05  David Levin  <levin@chromium.org>
2237
2238         Attempt to fix the bindings test (broken by r96727).
2239         Reviewed by Adam Barth.
2240
2241         * bindings/scripts/test/V8/V8TestInterface.cpp:
2242         (WebCore::ConfigureV8TestInterfaceTemplate):
2243         * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
2244         (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
2245         * bindings/scripts/test/V8/V8TestObj.cpp:
2246         (WebCore::ConfigureV8TestObjTemplate):
2247         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
2248         (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
2249
2250 2011-10-05  James Robinson  <jamesr@chromium.org>
2251
2252         [chromium] Hook WebCompositor interface for input events up to the compositor proper
2253         https://bugs.webkit.org/show_bug.cgi?id=69394
2254
2255         Reviewed by Darin Fisher.
2256
2257         This wires up WebCompositorImpl to the compositor itself so we can handle input events as scrolls on the
2258         compositor thread, although it doesn't actually wire up any input events to actual scrolling. The way this
2259         works:
2260
2261         - CCThreadProxy owns an adapter that implements the CCScrollController interface
2262         - CCThreadProxy owns a CCInputHandler, which is implemented by WebKit::WebCompositorImpl, that has a pointer to
2263         the adapter
2264         - CCLayerTreeHost has an identifier (an int) for its WebKit::WebCompositorImpl that's initialized in
2265         initializeLayerRenderer. This identifier is exposed to its owner (WebKit::WebViewImpl) so the embedder can wire
2266         up the threading logic behind the scenes.
2267
2268         This is just plumbing, no change in behavior.
2269
2270         * WebCore.gypi:
2271         * platform/graphics/chromium/cc/CCInputHandler.h: Added.
2272         (WebCore::CCInputHandler::~CCInputHandler):
2273         (WebCore::CCInputHandler::CCInputHandler):
2274         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
2275         (WebCore::CCLayerTreeHost::CCLayerTreeHost):
2276         (WebCore::CCLayerTreeHost::initialize):
2277         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2278         (WebCore::CCLayerTreeHost::compositorIdentifier):
2279         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
2280         (WebCore::CCLayerTreeHostImpl::scrollRootLayer):
2281         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
2282         * platform/graphics/chromium/cc/CCProxy.h:
2283         * platform/graphics/chromium/cc/CCScrollController.h: Added.
2284         (WebCore::CCScrollController::CCScrollController):
2285         (WebCore::CCScrollController::~CCScrollController):
2286         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
2287         (WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
2288         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
2289         (WebCore::CCSingleThreadProxy::compositorIdentifier):
2290         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
2291         (WebCore::CCThreadProxyScrollControllerAdapter::create):
2292         (WebCore::CCThreadProxyScrollControllerAdapter::~CCThreadProxyScrollControllerAdapter):
2293         (WebCore::CCThreadProxyScrollControllerAdapter::scrollRootLayer):
2294         (WebCore::CCThreadProxyScrollControllerAdapter::CCThreadProxyScrollControllerAdapter):
2295         (WebCore::CCThreadProxy::CCThreadProxy):
2296         (WebCore::CCThreadProxy::initializeLayerRenderer):
2297         (WebCore::CCThreadProxy::compositorIdentifier):
2298         (WebCore::CCThreadProxy::beginFrameAndCommit):
2299         (WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
2300         (WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
2301         * platform/graphics/chromium/cc/CCThreadProxy.h:
2302
2303 2011-10-05  Andreas Kling  <kling@webkit.org>
2304
2305         Shrink OutlineValue.
2306         https://bugs.webkit.org/show_bug.cgi?id=69436
2307
2308         Reviewed by Darin Adler.
2309
2310         Move OutlineValue::m_isAuto up into the base class (BorderValue.)
2311         This shrinks OutlineValue by 32 bit, which in turn shrinks
2312         StyleBackgroundData by one CPU word.
2313
2314         This reduces memory consumption by 250 kB (on 64-bit) when loading
2315         the full HTML5 spec.
2316
2317         * rendering/style/BorderValue.h:
2318         (WebCore::BorderValue::BorderValue):
2319         * rendering/style/OutlineValue.h:
2320         (WebCore::OutlineValue::OutlineValue):
2321         (WebCore::OutlineValue::isAuto):
2322
2323 2011-10-05  Chang Shu  <cshu@webkit.org>
2324
2325         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
2326         https://bugs.webkit.org/show_bug.cgi?id=69365
2327
2328         Reviewed by Darin Adler.
2329
2330         Expose computeViewportAttributes for mac build.
2331
2332         * WebCore.exp.in:
2333
2334 2011-10-05  Anna Cavender  <annacc@chromium.org>
2335
2336         Functions to make <track> enabled at runtime, including changes to
2337         CodeGeneratorvV8 to allow entire interfaces (not just attributes) to
2338         be runtime-enabled.
2339         https://bugs.webkit.org/show_bug.cgi?id=69352
2340
2341         Reviewed by Adam Barth.
2342
2343         No new tests. No new functionality.
2344
2345         * bindings/generic/RuntimeEnabledFeatures.cpp:
2346         * bindings/generic/RuntimeEnabledFeatures.h:
2347         (WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
2348         (WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):
2349         * bindings/scripts/CodeGeneratorV8.pm:
2350         * html/HTMLMediaElement.cpp:
2351         (WebCore::HTMLMediaElement::loadTextTracks):
2352         * html/HTMLTrackElement.idl:
2353
2354 2011-10-05  Kenneth Russell  <kbr@google.com>
2355
2356         Mask underlying RENDERER and VENDOR strings
2357         https://bugs.webkit.org/show_bug.cgi?id=69389
2358
2359         Reviewed by Sam Weinig.
2360
2361         Test: fast/canvas/webgl/renderer-and-vendor-strings.html
2362
2363         * html/canvas/WebGLGetInfo.h:
2364         * html/canvas/WebGLRenderingContext.cpp:
2365         (WebCore::WebGLRenderingContext::getParameter):
2366
2367 2011-10-05  Sachin Puranik  <jcqt43@motorola.com>
2368
2369         Spec change - option.label should be reflected like option.value
2370         https://bugs.webkit.org/show_bug.cgi?id=68684
2371
2372         Reviewed by Darin Adler.
2373
2374         Incorporating the recent change in spec for label attribute of 
2375         option element. While retrieving the "Label" IDL attribute return
2376         the "Label" content attribute if present , else return the 
2377         value of textContent attribute.
2378
2379         Tests: fast/forms/option-label-trim-html-spaces.html
2380                fast/forms/option-value-and-label-changed-by-js.html
2381
2382         * dom/OptionElement.cpp:
2383         (WebCore::OptionElement::normalizeText):style fixes
2384         * dom/OptionElement.h: make collectOptionInnerText() protected.
2385         * html/HTMLOptionElement.cpp:
2386         (WebCore::HTMLOptionElement::label): return innerText if label attribute un-available.
2387         (WebCore::HTMLOptionElement::setLabel):setLabel() implementation.
2388         * html/HTMLOptionElement.h: add setLabel declaration.
2389         * html/HTMLOptionElement.idl: Change reflect to ConvertNullToNullString in idl
2390
2391 2011-10-05  Rémi Duraffort  <remi.duraffort@st.com>
2392
2393         [GTK] Fix compilation with gtk v2.20.1
2394         https://bugs.webkit.org/show_bug.cgi?id=69418
2395
2396         Unreviewed build fix
2397
2398         * platform/gtk/GtkDragAndDropHelper.cpp:
2399
2400 2011-10-05  David Hyatt  <hyatt@apple.com>
2401
2402         https://bugs.webkit.org/show_bug.cgi?id=68731
2403         
2404         Outline sides not painted for region. Fix the painting and hit testing code for regions to add in
2405         the maximalOutlineSize on unclipped sides. Also fix some math errors with the computation of the
2406         translation offset and clip rects when overflow or outlines spill out.
2407
2408         Reviewed by Darin Adler.
2409
2410         Added new test in fast/regions.
2411
2412         * rendering/RenderFlowThread.cpp:
2413         (WebCore::RenderFlowThread::paintIntoRegion):
2414         (WebCore::RenderFlowThread::hitTestRegion):
2415         * rendering/RenderRegion.cpp:
2416         (WebCore::RenderRegion::regionOverflowRect):
2417
2418 2011-10-05  Yury Semikhatsky  <yurys@chromium.org>
2419         
2420         Unreviewed. Build fix: make InspectorStateClient.h Private in XCode project.
2421
2422         * WebCore.xcodeproj/project.pbxproj:
2423
2424 2011-10-05  Martin Robinson  <mrobinson@igalia.com>
2425
2426         libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed
2427         https://bugs.webkit.org/show_bug.cgi?id=64263
2428
2429         Reviewed by Xan Lopez.
2430
2431         No new tests. This is difficult to test because it relies on network
2432         timing and to catch and parse stdout.
2433
2434         Instead of allowing messages to pause and unpause after receiving headers,
2435         we wait until the completion of the sendRequestCallback. This will ensure
2436         that the SoupSession is in the correct state to allow for pausing and unpausing.
2437
2438         * platform/network/soup/ResourceHandleSoup.cpp:
2439         (WebCore::ResourceHandle::platformSetDefersLoading): Don't pause and unpause
2440         until the sendRequestCallback is called. We detect this situation by
2441         checking whether or not we have an input stream yet. Previously the code
2442         was only pausing until after soupMessage->status_code was not equal to
2443         SOUP_STATUS_NONE. This means that the message was pausable right after
2444         headers are received. sendRequestCallback happens some time after that.
2445
2446 2011-10-05  Ilya Tikhonovsky  <loislo@chromium.org>
2447
2448         Unreviewed build fix for Debug builders.
2449
2450         * inspector/WorkerInspectorController.cpp:
2451         (WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
2452
2453 2011-10-05  Dirk Schulze  <krit@webkit.org>
2454
2455         SVG 1.1: ineffectual transform attribute for ClipPath
2456         https://bugs.webkit.org/show_bug.cgi?id=55361
2457
2458         Reviewed by Nikolas Zimmermann.
2459         
2460         Respect 'transform' attribute/property for <clip-path>.
2461         If the masking code path is used the mask context gets transformed, otherwise the path itself.
2462
2463         Tests: svg/clip-path/clip-path-transform-1.svg
2464                svg/clip-path/clip-path-transform-2.svg
2465                svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html
2466
2467         * rendering/svg/RenderSVGResourceClipper.cpp:
2468         (WebCore::RenderSVGResourceClipper::pathOnlyClipping): Transform the clip path.
2469         (WebCore::RenderSVGResourceClipper::applyClippingToContext):
2470         (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Transform the context of the mask image.
2471         (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Repaint rect must get concatenated with the current animated transformation.
2472         (WebCore::RenderSVGResourceClipper::hitTestClipContent): Point for hit testing must be transformed by the current animated transformation.
2473         * rendering/svg/RenderSVGResourceClipper.h:
2474
2475 2011-10-05  Pavel Feldman  <pfeldman@google.com>
2476
2477         Web Inspector: move elements panel update semantics from ElementsPanel to ElementsTreeOutline.
2478         https://bugs.webkit.org/show_bug.cgi?id=69431
2479
2480         Reviewed by Yury Semikhatsky.
2481
2482         * inspector/front-end/ConsoleMessage.js:
2483         (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
2484         * inspector/front-end/ElementsPanel.js:
2485         (WebInspector.ElementsPanel.get this):
2486         (WebInspector.ElementsPanel):
2487         (WebInspector.ElementsPanel.prototype.show):
2488         (WebInspector.ElementsPanel.prototype.hide):
2489         (WebInspector.ElementsPanel.prototype._selectedNodeChanged):
2490         (WebInspector.ElementsPanel.prototype._reset):
2491         (WebInspector.ElementsPanel.prototype._nodeRemoved):
2492         (WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
2493         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
2494         * inspector/front-end/ElementsTreeOutline.js:
2495         (WebInspector.ElementsTreeOutline):
2496         (WebInspector.ElementsTreeOutline.prototype.wireToDomAgent):
2497         (WebInspector.ElementsTreeOutline.prototype.setVisible):
2498         (WebInspector.ElementsTreeOutline.prototype.addEventListener):
2499         (WebInspector.ElementsTreeOutline.prototype.removeEventListener):
2500         (WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
2501         (WebInspector.ElementsTreeOutline.prototype.update):
2502         (WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):
2503         (WebInspector.ElementsTreeOutline.prototype.findTreeElement.parentNode):
2504         (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
2505         (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor):
2506         (WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
2507         (WebInspector.ElementsTreeOutline.prototype._ondrop):
2508         (WebInspector.ElementsTreeOutline.prototype.adjustCollapsedRange):
2509         (WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes):
2510         (WebInspector.ElementsTreeElement.prototype.insertChildElement):
2511         (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
2512         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
2513         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
2514         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded):
2515         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
2516         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
2517         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
2518         (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
2519         (WebInspector.ElementsTreeElement.prototype._editingCancelled):
2520         ():
2521         * inspector/front-end/externs.js:
2522         (WebInspector.ElementsTreeOutline):
2523         * inspector/front-end/utilities.js:
2524
2525 2011-10-05  Yury Semikhatsky  <yurys@chromium.org>
2526
2527         Web Inspector: provide a way for persisting worker inspector state
2528         https://bugs.webkit.org/show_bug.cgi?id=69422
2529
2530         Worker inspector can persist and restore its state. InspectorStateClient is
2531         exctracted into a separate interface and has a custom implementation in case
2532         of worker inspector.
2533
2534         Reviewed by Pavel Feldman.
2535
2536         * GNUmakefile.list.am:
2537         * WebCore.gypi:
2538         * WebCore.vcproj/WebCore.vcproj:
2539         * WebCore.xcodeproj/project.pbxproj:
2540         * inspector/InspectorClient.h:
2541         * inspector/InspectorState.cpp:
2542         (WebCore::InspectorState::InspectorState):
2543         * inspector/InspectorState.h:
2544         * inspector/InspectorStateClient.h: Copied from Source/WebCore/inspector/InspectorClient.h.
2545         (WebCore::InspectorStateClient::~InspectorStateClient):
2546         (WebCore::InspectorStateClient::updateInspectorStateCookie):
2547         * inspector/WorkerInspectorController.cpp:
2548         (WebCore::WorkerInspectorController::WorkerInspectorController):
2549         (WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
2550         * inspector/WorkerInspectorController.h:
2551         * workers/DefaultSharedWorkerRepository.cpp:
2552         (WebCore::SharedWorkerProxy::postMessageToPageInspector):
2553         (WebCore::SharedWorkerProxy::updateInspectorStateCookie):
2554         * workers/WorkerMessagingProxy.cpp:
2555         (WebCore::WorkerMessagingProxy::updateInspectorStateCookie):
2556         * workers/WorkerMessagingProxy.h:
2557         * workers/WorkerReportingProxy.h:
2558
2559 2011-10-05  Abhishek Arya  <inferno@chromium.org>
2560
2561         Crash in SVGTRefElement::updateReferencedText.
2562         https://bugs.webkit.org/show_bug.cgi?id=67555
2563
2564         Reviewed by Rob Buis.
2565
2566         Test: svg/text/tref-event-listener-crash.svg
2567
2568         * svg/SVGTRefElement.cpp:
2569         (WebCore::SubtreeModificationEventListener::clear): This fixes the
2570         crash. there can be cases when our target is removed, but our event
2571         listener is alive. when our tref is going away, we need to disable
2572         those event listeners by nulling out our tref element.
2573         (WebCore::SubtreeModificationEventListener::handleEvent): Adding
2574         null check for tref element, which can happen in cases where
2575         event listener's clear is called, but we could not remove it from
2576         the target.
2577         (WebCore::SVGTRefElement::~SVGTRefElement): There are always
2578         cases when removedFromDocument is not called. So, important to
2579         clear event listener in those cases.
2580         (WebCore::SVGTRefElement::svgAttributeChanged): Use common
2581         function buildPendingResource.
2582         (WebCore::SVGTRefElement::buildPendingResource): Common function
2583         to prevent triple duplication of same code. made it more readable.
2584         (WebCore::SVGTRefElement::insertedIntoDocument): Use common
2585         function buildPendingResource.
2586         (WebCore::SVGTRefElement::removedFromDocument): Use new helper
2587         removeEventListener.
2588         (WebCore::SVGTRefElement::clearEventListener): Helper to clear
2589         event listener. Name chosen to not collide with Node::removeEventListener.
2590         * svg/SVGTRefElement.h: definition of new helpers.
2591         * svg/SVGTextPathElement.cpp:
2592         (WebCore::SVGTextPathElement::insertedIntoDocument): Copy same
2593         logic as tref and use element. more asserts and easy bailouts.
2594
2595 2011-10-05  Pavel Feldman  <pfeldman@google.com>
2596
2597         Not reviewed: restoring : shortcut in inspector.
2598
2599         * inspector/front-end/ScriptsPanel.js:
2600         (WebInspector.ScriptsPanel.prototype._createSidebarButtons):
2601
2602 2011-10-05  Andreas Kling  <kling@webkit.org>
2603
2604         Shrink FontDescription.
2605         https://bugs.webkit.org/show_bug.cgi?id=69426
2606
2607         Reviewed by Nikolas Zimmermann.
2608
2609         Pack FontDescription's members in a bitfield, effectively shrinking
2610         the class by two CPU-words. This reduces memory consumption by ~1 MB
2611         on 64-bit when loading the full HTML5 spec.
2612
2613         * platform/graphics/FontDescription.h:
2614         (WebCore::FontDescription::orientation):
2615         (WebCore::FontDescription::textOrientation):
2616         (WebCore::FontDescription::widthVariant):
2617
2618 2011-10-05  Vsevolod Vlasov  <vsevik@chromium.org>
2619
2620         Web Inspector: Add support for search in script content.
2621         https://bugs.webkit.org/show_bug.cgi?id=69015
2622
2623         Reviewed by Pavel Feldman.
2624
2625         Tests: http/tests/inspector/search/search-in-concatenated-script.html
2626                http/tests/inspector/search/search-in-script.html
2627
2628         * inspector/Inspector.json:
2629         * inspector/InspectorDebuggerAgent.cpp:
2630         (WebCore::InspectorDebuggerAgent::searchInContent):
2631         (WebCore::InspectorDebuggerAgent::getScriptSource):
2632         * inspector/InspectorDebuggerAgent.h:
2633         * inspector/front-end/ContentProviders.js:
2634         (WebInspector.ScriptContentProvider.prototype.searchInContent):
2635         (WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts.var):
2636         (WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts):
2637         (WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
2638         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
2639         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
2640         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
2641         (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
2642         * inspector/front-end/Script.js:
2643         (WebInspector.Script.prototype.requestSource.didGetScriptSource):
2644         (WebInspector.Script.prototype.requestSource):
2645         (WebInspector.Script.prototype.searchInContent):
2646
2647 2011-10-05  Alexis Menard  <alexis.menard@openbossa.org>
2648
2649         [Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.
2650         https://bugs.webkit.org/show_bug.cgi?id=69111
2651
2652         Reviewed by Kenneth Rohde Christiansen.
2653
2654         Provide default path for LocalStorage, Database and IconDatabase using QDesktopServices.
2655
2656         No new tests : existing ones should cover.
2657
2658         * platform/qt/CookieJarQt.cpp:
2659         (WebCore::SharedCookieJarQt::SharedCookieJarQt):
2660
2661 2011-10-05  Patrick Gansterer  <paroga@webkit.org>
2662
2663         Unreviewed build fix for !ENABLE(FILTERS) after r96203.
2664
2665         * rendering/svg/SVGResourcesCache.cpp:
2666         (WebCore::SVGResourcesCache::clientUpdatedFromElement):
2667
2668 2011-10-05  Ilya Tikhonovsky  <loislo@chromium.org>
2669
2670         Unreviewed build fix for windows bots after r96679.
2671
2672         * html/NumberInputType.h:
2673
2674 2011-10-04  Pavel Feldman  <pfeldman@google.com>
2675
2676         Web Inspector: make ResourceView(s) compile
2677         https://bugs.webkit.org/show_bug.cgi?id=69351
2678
2679         Reviewed by Yury Semikhatsky.
2680
2681         * inspector/compile-front-end.sh:
2682         * inspector/front-end/CookiesTable.js:
2683         (WebInspector.CookiesTable.prototype._sortCookies):
2684         * inspector/front-end/DataGrid.js:
2685         * inspector/front-end/EmptyView.js:
2686         * inspector/front-end/FontView.js:
2687         (WebInspector.FontView.prototype._createContentIfNeeded):
2688         * inspector/front-end/ImageView.js:
2689         (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
2690         (WebInspector.ImageView.prototype._createContentIfNeeded):
2691         (WebInspector.ImageView.prototype._openInNewTab):
2692         * inspector/front-end/NetworkItemView.js:
2693         * inspector/front-end/ResourceCookiesView.js:
2694         * inspector/front-end/ResourceHTMLView.js:
2695         (WebInspector.ResourceHTMLView.prototype.hide):
2696         * inspector/front-end/ResourceHeadersView.js:
2697         (WebInspector.ResourceHeadersView.prototype._refreshParms):
2698         (WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle):
2699         (WebInspector.ResourceHeadersView.prototype._refreshHeaders):
2700         (WebInspector.ResourceHeadersView.prototype._refreshHeadersText):
2701         * inspector/front-end/ResourceJSONView.js:
2702         (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP):
2703         * inspector/front-end/ResourcePreviewView.js:
2704         * inspector/front-end/ResourceResponseView.js:
2705         * inspector/front-end/ResourceTimingView.js:
2706         (WebInspector.ResourceTimingView.createTimingTable):
2707         * inspector/front-end/ResourceView.js:
2708         (WebInspector.ResourceSourceFrame):
2709         * inspector/front-end/SourceFrame.js:
2710         * inspector/front-end/TabbedPane.js:
2711         * inspector/front-end/UIUtils.js:
2712         (Number.secondsToString):
2713         (Number.bytesToString):
2714         * inspector/front-end/inspector.js:
2715
2716 2011-10-04  Ilya Tikhonovsky  <loislo@chromium.org>
2717
2718         Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
2719         https://bugs.webkit.org/show_bug.cgi?id=69146
2720
2721         In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
2722         Such changes happen when we use pretty print or another operation that changes the source code somehow.
2723         linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
2724         As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.
2725
2726         Reviewed by Pavel Feldman.
2727
2728         Test: inspector/debugger/linkifier.html
2729
2730         * inspector/front-end/ConsoleMessage.js:
2731         (WebInspector.ConsoleMessageImpl):
2732         (WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
2733         * inspector/front-end/ConsoleView.js:
2734         (WebInspector.ConsoleView.prototype._consoleCleared):
2735         (WebInspector.ConsoleCommandResult):
2736         (WebInspector.ConsoleMessage.create):
2737         (WebInspector.ConsoleMessage.createTextMessage):
2738         * inspector/front-end/DebuggerPresentationModel.js:
2739         (WebInspector.DebuggerPresentationModel.prototype.createLinkifier):
2740         (WebInspector.DebuggerPresentationModel.Linkifier):
2741         (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
2742         (WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
2743         (WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateSourceAnchors):
2744         (WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
2745         * inspector/front-end/EventListenersSidebarPane.js:
2746         (WebInspector.EventListenersSidebarPane.prototype.update.callback):
2747         (WebInspector.EventListenersSidebarPane.prototype.update):
2748         ():
2749         * inspector/front-end/NetworkPanel.js:
2750         (WebInspector.NetworkLogView):
2751         (WebInspector.NetworkLogView.prototype._reset):
2752         (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
2753         * inspector/front-end/ProfileDataGridTree.js:
2754         (WebInspector.ProfileDataGridNode.prototype.createCell):
2755         * inspector/front-end/ProfileView.js:
2756         (WebInspector.CPUProfileView):
2757         (WebInspector.CPUProfileView.prototype._resetClicked):
2758         * inspector/front-end/TimelinePanel.js:
2759         (WebInspector.TimelinePanel):
2760         (WebInspector.TimelinePanel.prototype._linkifyLocation):
2761         (WebInspector.TimelinePanel.prototype._linkifyCallFrame):
2762         (WebInspector.TimelinePanel.prototype._clearPanel):
2763         (WebInspector.TimelinePanel.FormattedRecord):
2764         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
2765         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2766         (WebInspector.TimelinePanel.PopupContentHelper):
2767         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
2768         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
2769         * inspector/front-end/inspector.js:
2770
2771 2011-10-03  Andreas Kling  <kling@webkit.org>
2772
2773         REGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use.
2774         https://bugs.webkit.org/show_bug.cgi?id=64914
2775
2776         Reviewed by Antti Koivisto.
2777
2778         Remove InlineBox::prevOnLineExists() and its two accompanying bitfields
2779         since nobody is using them anymore. nextOnLineExists() is still used by
2780         GTK+ accessibility code.
2781
2782         Also added a compile-time assertion to guard against future bloating of
2783         the InlineBox class.
2784
2785         * rendering/InlineBox.cpp:
2786         (WebCore::SameSizeAsInlineBox::~SameSizeAsInlineBox):
2787         * rendering/InlineBox.h:
2788         (WebCore::InlineBox::InlineBox):
2789
2790 2011-10-05  Andreas Kling  <kling@webkit.org>
2791
2792         Shrink FontFallbackList.
2793         https://bugs.webkit.org/show_bug.cgi?id=69093
2794
2795         Rubber-stamped by Antti Koivisto.
2796
2797         Workaround MSVC quirk by making enum bitfield "unsigned".
2798
2799         * platform/graphics/FontFallbackList.h:
2800
2801 2011-10-05  Andreas Kling  <kling@webkit.org>
2802
2803         Shrink StyleRareNonInheritedData.
2804         https://bugs.webkit.org/show_bug.cgi?id=69331
2805
2806         Reviewed by Darin Adler.
2807
2808         Workaround MSVC quirk by making enum bitfields "unsigned".
2809
2810         * rendering/style/RenderStyle.h:
2811         (WebCore::InheritedFlags::regionOverflow):
2812         (WebCore::InheritedFlags::transformStyle3D):
2813         (WebCore::InheritedFlags::backfaceVisibility):
2814         (WebCore::InheritedFlags::pageSizeType):
2815         * rendering/style/StyleRareNonInheritedData.h:
2816
2817 2011-10-05  Pavel Feldman  <pfeldman@chromium.org>
2818
2819         Web Inspector: add CSS model classes to the compilation.
2820         https://bugs.webkit.org/show_bug.cgi?id=69376
2821
2822         Reviewed by Yury Semikhatsky.
2823
2824         * inspector/compile-front-end.sh:
2825         * inspector/front-end/CSSCompletions.js:
2826         * inspector/front-end/CSSKeywordCompletions.js:
2827         (WebInspector.CSSKeywordCompletions.forProperty):
2828         * inspector/front-end/CSSStyleModel.js:
2829         (WebInspector.CSSStyleDeclaration):
2830         (WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
2831         (WebInspector.CSSStyleModelResourceBinding.prototype.canSetContent):
2832         * inspector/front-end/ResourceTreeModel.js:
2833         * inspector/front-end/StylesSidebarPane.js:
2834         (WebInspector.StylesSidebarPane.prototype._containsInherited):
2835         (WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
2836         (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
2837         (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
2838         * inspector/front-end/externs.js:
2839         (Array.prototype.keySet):
2840
2841 2011-10-05  Kent Tamura  <tkent@chromium.org>
2842
2843         Input styles are unexpectedly shared regardless of required status difference.
2844         https://bugs.webkit.org/show_bug.cgi?id=69402
2845
2846         Reviewed by Daniel Bates.
2847
2848         Tests: fast/css/pseudo-required-shared.html
2849
2850         * css/CSSStyleSelector.cpp:
2851         (WebCore::CSSStyleSelector::canShareStyleWithControl): Check the difference of required().
2852
2853 2011-10-04  Kent Tamura  <tkent@chromium.org>
2854
2855         Remove Node::willBlur()
2856         https://bugs.webkit.org/show_bug.cgi?id=69395
2857
2858         Reviewed by Ryosuke Niwa.
2859
2860         Revert the WebCore part of r87371 because
2861         FrameSelection::textWillBeReplaced() doesn't set focus anymore.
2862         No new tests. Covered by fast/forms/input-number-blur-twice.html.
2863
2864         * dom/Document.cpp:
2865         (WebCore::Document::setFocusedNode): Revert r87371.
2866         * dom/Node.cpp: ditto.
2867         * dom/Node.h: ditto.
2868         * html/HTMLInputElement.cpp:
2869         (WebCore::HTMLInputElement::handleBlurEvent): ditto.
2870         * html/HTMLInputElement.h: ditto.
2871         * html/InputType.cpp:
2872         (WebCore::InputType::handleBlurEvent): ditto.
2873         * html/InputType.h: ditto.
2874         * html/NumberInputType.cpp:
2875         (WebCore::NumberInputType::handleBlurEvent): ditto.
2876         * html/NumberInputType.h: ditto.
2877
2878 2011-10-04  Kent Tamura  <tkent@chromium.org>
2879
2880         Introduce feature flags for incomplete input types
2881         https://bugs.webkit.org/show_bug.cgi?id=68971
2882
2883         Reviewed by Hajime Morita.
2884
2885         * Configurations/FeatureDefines.xcconfig:
2886          Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.
2887         * html/DateInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATE)
2888         * html/DateInputType.h: ditto.
2889         * html/DateTimeInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATETIME)
2890         * html/DateTimeInputType.h: ditto.
2891         * html/DateTimeLocalInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATETIMELOCAL)
2892         * html/DateTimeLocalInputType.h: ditto.
2893         * html/InputType.cpp:
2894         (WebCore::createInputTypeFactoryMap):
2895          Recognizes type attribute value only if it is enabled by ENABLE(INPUT_TYPE_*).
2896         * html/MonthInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_MONTH)
2897         * html/MonthInputType.h: ditto.
2898         * html/TimeInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_TIME)
2899         * html/TimeInputType.h: ditto.
2900         * html/WeekInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_WEEK)
2901         * html/WeekInputType.h: ditto.
2902
2903 2011-10-04  David Hyatt  <hyatt@apple.com>
2904
2905         https://bugs.webkit.org/show_bug.cgi?id=69398
2906
2907         [CSS3 Regions] Support the region-overflow property properly.
2908         
2909         (1) Change -webkit-break to break, since the -webkit-region-overflow property already has the
2910         -webkit- extension.
2911         
2912         (2) Fix clipping so that it works when overflow is set or when region break is set.
2913         
2914         (3) Refactor all the pagination spots to check if a next page is available using the new hasNextPage
2915         function. This prevents us from paginating if we hit the last region and further breaks are no longer
2916         allowed.
2917         
2918         Reviewed by Dan Bernstein.
2919
2920         Added new tests in fast/regions.
2921
2922         * css/CSSParser.cpp:
2923         (WebCore::CSSParser::parseValue):
2924         * css/CSSPrimitiveValueMappings.h:
2925         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2926         (WebCore::CSSPrimitiveValue::operator RegionOverflow):
2927         * css/CSSValueKeywords.in:
2928         * rendering/RenderBlock.cpp:
2929         (WebCore::RenderBlock::collapseMargins):
2930         (WebCore::RenderBlock::estimateLogicalTopPosition):
2931         (WebCore::RenderBlock::hasNextPage):
2932         (WebCore::RenderBlock::nextPageLogicalTop):
2933         (WebCore::RenderBlock::applyBeforeBreak):
2934         (WebCore::RenderBlock::applyAfterBreak):
2935         (WebCore::RenderBlock::pageLogicalHeightForOffset):
2936         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
2937         (WebCore::RenderBlock::adjustForUnsplittableChild):
2938         (WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
2939         (WebCore::RenderBlock::adjustLinePositionForPagination):
2940         * rendering/RenderBlock.h:
2941         * rendering/RenderFlowThread.cpp:
2942         (WebCore::RenderFlowThread::layout):
2943         (WebCore::RenderFlowThread::repaintRectangleInRegions):
2944         (WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
2945         * rendering/RenderFlowThread.h:
2946         * rendering/RenderRegion.cpp:
2947         (WebCore::RenderRegion::regionOverflowRect):
2948
2949 2011-10-04  Mark Hahnenberg  <mhahnenberg@apple.com>
2950
2951         Add static ClassInfo structs to classes that override JSCell::getCallData
2952         https://bugs.webkit.org/show_bug.cgi?id=69311
2953
2954         Reviewed by Darin Adler.
2955
2956         No new tests.
2957
2958         Added ClassInfo structs to each class that defined its own getCallData 
2959         function but did not already have its own ClassInfo struct.  This is a 
2960         necessary addition for when we switch over to looking up getCallData from 
2961         the MethodTable in ClassInfo rather than doing the virtual call (which we 
2962         are removing).  These new ClassInfo structs are public because we often 
2963         use these structs in other areas of the code to uniquely identify JSC classes and 
2964         to enforce runtime invariants based on those class identities using ASSERTs.
2965         Also added new createStructure methods to those classes that didn't have 
2966         them so that the new ClassInfo structs would be used when creating the Structures 
2967         in these classes.
2968
2969         * bridge/qt/qt_runtime.cpp:
2970         * bridge/qt/qt_runtime.h:
2971
2972 2011-10-03  Geoffrey Garen  <ggaren@apple.com>
2973
2974         Some JSValue cleanup
2975         https://bugs.webkit.org/show_bug.cgi?id=69320
2976
2977         Reviewed by Darin Adler.
2978
2979         * bindings/js/JSDOMBinding.cpp:
2980         (WebCore::valueToDate):
2981         * bindings/js/JSErrorHandler.cpp:
2982         (WebCore::JSErrorHandler::handleEvent):
2983         * bindings/js/JSEventListener.cpp:
2984         (WebCore::JSEventListener::handleEvent):
2985         * bindings/js/JSSQLTransactionCustom.cpp:
2986         (WebCore::JSSQLTransaction::executeSql):
2987         * bindings/js/JSSQLTransactionSyncCustom.cpp:
2988         (WebCore::JSSQLTransactionSync::executeSql):
2989         * bindings/js/ScriptValue.cpp:
2990         (WebCore::jsToInspectorValue):
2991         * bindings/js/SerializedScriptValue.cpp:
2992         (WebCore::CloneSerializer::dumpIfTerminal):
2993         * bindings/objc/WebScriptObject.mm:
2994         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
2995         * bridge/jni/jsc/JNIUtilityPrivate.cpp:
2996         (JSC::Bindings::convertValueToJValue): Updated for JSC changes.
2997
2998 2011-10-04  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2999
3000         Fix FrameView::scrollElementToRect to take already scrolled amount into consideration.
3001         https://bugs.webkit.org/show_bug.cgi?id=69220
3002
3003         Reviewed by Simon Fraser.
3004
3005         * page/FrameView.cpp:
3006         (WebCore::FrameView::scrollElementToRect):
3007
3008 2011-10-04  Anders Carlsson  <andersca@apple.com>
3009
3010         Ignore the warning about using 'override'.
3011
3012         * WebCore.vcproj/WebCore.vcproj:
3013
3014 2011-10-04  Sam Weinig  <sam@webkit.org>
3015
3016         Stub out WorkerScriptController::disableEval for v8 to fix the build.
3017
3018         * bindings/v8/WorkerScriptController.cpp:
3019         (WebCore::WorkerScriptController::disableEval):
3020         * bindings/v8/WorkerScriptController.h:
3021
3022 2011-10-04  Sam Weinig  <sam@webkit.org>
3023
3024         OVERRIDE seems to not be working for Windows. Remove it for now.
3025
3026         * dom/Document.h:
3027         * workers/WorkerContext.h:
3028
3029 2011-10-04  Sam Weinig  <sam@webkit.org>
3030
3031         Wean ContentSecurityPolicy from the Document
3032         https://bugs.webkit.org/show_bug.cgi?id=69387
3033
3034         Reviewed by Adam Barth.
3035
3036         * bindings/js/WorkerScriptController.cpp:
3037         (WebCore::WorkerScriptController::disableEval):
3038         * bindings/js/WorkerScriptController.h:
3039         * dom/Document.cpp:
3040         (WebCore::Document::disableEval):
3041         * dom/Document.h:
3042         * workers/WorkerContext.cpp:
3043         (WebCore::WorkerContext::disableEval):
3044         * workers/WorkerContext.h:
3045         * dom/ScriptExecutionContext.h:
3046         Add pure virtual disableEval to ScriptExecutionContext, so that ContentSecurityPolicy
3047         can call it for both Documents and WorkerContexts.
3048
3049         * page/ContentSecurityPolicy.cpp:
3050         (WebCore::ContentSecurityPolicy::didReceiveHeader):
3051         Call the new ScriptExecutionContext::disableEval() function.
3052
3053         (WebCore::ContentSecurityPolicy::reportViolation):
3054         Use ScriptExecutionContext::addMessage() instead of going directly to the DOMWindow.
3055
3056 2011-10-04  Anders Carlsson  <andersca@apple.com>
3057
3058         Move code into ScrollElasticityController::beginScrollGesture()
3059         https://bugs.webkit.org/show_bug.cgi?id=69383
3060
3061         Reviewed by John Sullivan.
3062
3063         * platform/mac/ScrollAnimatorMac.h:
3064         Add new ScrollElasticityControllerClient member functions.
3065
3066         * platform/mac/ScrollAnimatorMac.mm:
3067         (WebCore::ScrollAnimatorMac::isHorizontalScrollerPinnedToMinimumPosition):
3068         (WebCore::ScrollAnimatorMac::isHorizontalScrollerPinnedToMaximumPosition):
3069         (WebCore::ScrollAnimatorMac::stretchAmount):
3070         (WebCore::ScrollAnimatorMac::startSnapRubberbandTimer):
3071         (WebCore::ScrollAnimatorMac::stopSnapRubberbandTimer):
3072         Implement the new ScrollElasticityControllerClient member functions.
3073
3074         (WebCore::ScrollAnimatorMac::beginScrollGesture):
3075         Move code into ScrollElasticityController::beginScrollGesture and call it directly.
3076
3077         * platform/mac/ScrollElasticityController.h:
3078         Add new ScrollElasticityControllerClient member functions.
3079
3080         * platform/mac/ScrollElasticityController.mm:
3081         (WebCore::reboundDeltaForElasticDelta):
3082         (WebCore::ScrollElasticityController::beginScrollGesture):
3083         Set up the scroll gesture state.
3084
3085         (WebCore::ScrollElasticityController::stopSnapRubberbandTimer):
3086         New helper function.
3087
3088 2011-10-04  Scott Graham  <scottmg@chromium.org>
3089
3090         Add GAMEPAD feature flag
3091         https://bugs.webkit.org/show_bug.cgi?id=66859
3092
3093         Reviewed by Darin Fisher.
3094
3095         No new tests, as no new functionality yet.
3096
3097         * Configurations/FeatureDefines.xcconfig:
3098         * GNUmakefile.am:
3099         * features.pri:
3100
3101 2011-10-04  Fady Samuel  <fsamuel@chromium.org>
3102
3103         [Chromium] Moved files towards GTK removal
3104         https://bugs.webkit.org/show_bug.cgi?id=69229
3105
3106         Reviewed by Tony Chang.
3107
3108         * WebCore.gypi:
3109         * platform/chromium/PlatformThemeChromiumLinux.cpp: Renamed from Source/WebCore/platform/chromium/PlatformThemeChromiumGtk.cpp.
3110         (WebCore::PlatformThemeChromiumLinux::setScrollbarColors):
3111         (WebCore::clamp):
3112         (WebCore::PlatformThemeChromiumLinux::saturateAndBrighten):
3113         (WebCore::PlatformThemeChromiumLinux::outlineColor):
3114         (WebCore::PlatformThemeChromiumLinux::paintArrowButton):
3115         * platform/chromium/PlatformThemeChromiumLinux.h: Renamed from Source/WebCore/platform/chromium/PlatformThemeChromiumGtk.h.
3116         (WebCore::PlatformThemeChromiumLinux::thumbInactiveColor):
3117         (WebCore::PlatformThemeChromiumLinux::thumbActiveColor):
3118         (WebCore::PlatformThemeChromiumLinux::trackColor):
3119         (WebCore::PlatformThemeChromiumLinux::PlatformThemeChromiumLinux):
3120
3121 2011-10-04  James Robinson  <jamesr@chromium.org>
3122
3123         [chromium] Extract scheduling logic from CCThreadProxy to its own class
3124         https://bugs.webkit.org/show_bug.cgi?id=69049
3125
3126         Reviewed by Kenneth Russell.
3127
3128         This partially extracts the commit/draw scheduling from CCThreadProxy to a separate isolated class. This makes
3129         the commit/draw logic easier to test, understand and extend.
3130
3131         There is one subtle behavior change here to the way that the function formerly known as
3132         CCLayerTreeHost::setNeedsCommitAndRedraw works. Previously, this would trigger a begin frame message, if one
3133         wasn't pending, and then trigger a redraw if one wasn't pending. This was subtly wrong - the intent of that call
3134         is that a redraw should happen after the commit. It isn't useful to draw before the commit occurs. This patch
3135         changes the name of the function to setNeedsCommitThenRedraw and only requests a redraw after a commit occurs.
3136
3137         Covered by new CCSchedulerTest unit tests, CCLayerTreeHostTest unit tests, and compositing/ layout tests.
3138
3139         * WebCore.gypi:
3140         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
3141         (WebCore::CCLayerTreeHost::initialize):
3142         (WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
3143         (WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
3144         (WebCore::CCLayerTreeHost::setViewport):
3145         (WebCore::CCLayerTreeHost::setVisible):
3146         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
3147         * platform/graphics/chromium/cc/CCProxy.h:
3148         * platform/graphics/chromium/cc/CCScheduler.cpp: Added.
3149         (WebCore::CCScheduler::CCScheduler):
3150         (WebCore::CCScheduler::requestCommit):
3151         (WebCore::CCScheduler::requestCommitThenRedraw):
3152         (WebCore::CCScheduler::requestRedraw):
3153         (WebCore::CCScheduler::didCommit):
3154         (WebCore::CCScheduler::didDraw):
3155         * platform/graphics/chromium/cc/CCScheduler.h: Added.
3156         (WebCore::CCSchedulerClient::~CCSchedulerClient):
3157         (WebCore::CCScheduler::create):
3158         (WebCore::CCScheduler::commitPending):
3159         (WebCore::CCScheduler::redrawPending):
3160         (WebCore::CCScheduler::redrawAfterCommit):
3161         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
3162         (WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
3163         (WebCore::CCSingleThreadProxy::setNeedsRedraw):
3164         (WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
3165         (WebCore::CCSingleThreadProxy::doComposite):
3166         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
3167         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
3168         (WebCore::CCThreadProxySchedulerClient::create):
3169         (WebCore::CCThreadProxySchedulerClient::~CCThreadProxySchedulerClient):
3170         (WebCore::CCThreadProxySchedulerClient::scheduleBeginFrameAndCommit):
3171         (WebCore::CCThreadProxySchedulerClient::scheduleDrawAndPresent):
3172         (WebCore::CCThreadProxySchedulerClient::CCThreadProxySchedulerClient):
3173         (WebCore::CCThreadProxy::CCThreadProxy):
3174         (WebCore::CCThreadProxy::compositeAndReadback):
3175         (WebCore::CCThreadProxy::initializeLayerRenderer):
3176         (WebCore::CCThreadProxy::setNeedsCommit):
3177         (WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
3178         (WebCore::CCThreadProxy::setNeedsCommitThenRedraw):
3179         (WebCore::CCThreadProxy::setNeedsCommitThenRedrawOnCCThread):
3180         (WebCore::CCThreadProxy::setNeedsRedraw):
3181         (WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
3182         (WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
3183         (WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
3184         (WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
3185         (WebCore::CCThreadProxy::beginFrameAndCommit):
3186         (WebCore::CCThreadProxy::commitOnCCThread):
3187         (WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
3188         (WebCore::CCThreadProxy::initializeImplOnCCThread):
3189         * platform/graphics/chromium/cc/CCThreadProxy.h:
3190
3191 2011-10-04  Alexey Proskuryakov  <ap@apple.com>
3192
3193         https://bugs.webkit.org/show_bug.cgi?id=67774
3194         PDF in a frameset is not displayed, always downloads
3195
3196         Reviewed by Darin Adler.
3197
3198         * WebCore.exp.in:
3199         * WebCore.xcodeproj/project.pbxproj:
3200         Added exports necessary to subclass a ScrollableArea.
3201
3202 2011-10-04  Anders Carlsson  <andersca@apple.com>
3203
3204         ScrollElasticityController should keep track of the rubberband timer state
3205         https://bugs.webkit.org/show_bug.cgi?id=69381
3206
3207         Reviewed by Sam Weinig.
3208
3209         Add a m_snapRubberbandTimerIsActive member variable to ScrollElasticityController
3210         and use it instead of checking whether the m_snapRubberbandTimer is active.
3211
3212         Eventually, ScrollElasticityControllerClient will have two member functions for starting
3213         and stopping the timer, and the ScrollElasticityController will call them at the appropriate times.
3214
3215         * platform/mac/ScrollAnimatorMac.mm:
3216         (WebCore::ScrollAnimatorMac::handleWheelEvent):
3217         (WebCore::ScrollAnimatorMac::beginScrollGesture):
3218         It's OK to stop the timer unconditionally.
3219
3220         (WebCore::ScrollAnimatorMac::snapRubberBand):
3221         (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
3222         * platform/mac/ScrollElasticityController.h:
3223         * platform/mac/ScrollElasticityController.mm:
3224         (WebCore::ScrollElasticityController::ScrollElasticityController):
3225
3226 2011-10-04  Anders Carlsson  <andersca@apple.com>
3227
3228         Move all rubber-banding related member variables to ScrollElasticityController
3229         https://bugs.webkit.org/show_bug.cgi?id=69379
3230
3231         Reviewed by Dan Bernstein.
3232
3233         * platform/mac/ScrollAnimatorMac.h:
3234         * platform/mac/ScrollAnimatorMac.mm:
3235         (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
3236         (WebCore::ScrollAnimatorMac::handleWheelEvent):
3237         (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
3238         (WebCore::ScrollAnimatorMac::beginScrollGesture):
3239         (WebCore::ScrollAnimatorMac::snapRubberBand):
3240         (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
3241         * platform/mac/ScrollElasticityController.h:
3242         * platform/mac/ScrollElasticityController.mm:
3243         (WebCore::ScrollElasticityController::ScrollElasticityController):
3244
3245 2011-10-04  Anders Carlsson  <andersca@apple.com>
3246
3247         Build fixes for everyone.
3248
3249         * platform/chromium/ScrollAnimatorChromiumMac.h:
3250         * platform/chromium/ScrollAnimatorChromiumMac.mm:
3251         (WebCore::isScrollingLeftAndShouldNotRubberBand):
3252         (WebCore::isScrollingRightAndShouldNotRubberBand):
3253         (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
3254         Fix Chromium build.
3255
3256         * platform/gtk/PlatformWheelEventGtk.cpp:
3257         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3258         Fix GTK+ build.
3259
3260 2011-10-04  Anders Carlsson  <andersca@apple.com>
3261
3262         Add a ScrollElasticityController class and move some members over from ScrollAnimatorMac
3263         https://bugs.webkit.org/show_bug.cgi?id=69373
3264
3265         Reviewed by David Hyatt.
3266
3267         ScrollElasticityController is a new class that will handle the rubber-banding when handling scroll events.
3268
3269         * WebCore.xcodeproj/project.pbxproj:
3270         * platform/mac/ScrollAnimatorMac.h:
3271         * platform/mac/ScrollAnimatorMac.mm:
3272         (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
3273         (WebCore::ScrollAnimatorMac::handleWheelEvent):
3274         (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
3275         (WebCore::ScrollAnimatorMac::beginScrollGesture):
3276         (WebCore::ScrollAnimatorMac::snapRubberBand):
3277         (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
3278         * platform/mac/ScrollElasticityController.h: Added.
3279         (WebCore::ScrollElasticityControllerClient::~ScrollElasticityControllerClient):
3280         * platform/mac/ScrollElasticityController.mm: Added.
3281         (WebCore::ScrollElasticityController::ScrollElasticityController):
3282
3283 2011-10-04  David Hyatt  <hyatt@apple.com>
3284
3285         https://bugs.webkit.org/show_bug.cgi?id=69372
3286         
3287         [CSS3 Regions] Make sure overflow:visible lets content spill out of regions.
3288
3289         Reviewed by Anders Carlsson.
3290
3291         No new tests, since plenty of results changed.
3292
3293         * rendering/RenderFlowThread.cpp:
3294         (WebCore::RenderFlowThread::paintIntoRegion):
3295         (WebCore::RenderFlowThread::hitTestRegion):
3296         (WebCore::RenderFlowThread::repaintRectangleInRegions):
3297         (WebCore::RenderFlowThread::firstRegion):
3298         (WebCore::RenderFlowThread::lastRegion):
3299         * rendering/RenderFlowThread.h:
3300         * rendering/RenderRegion.cpp:
3301         (WebCore::RenderRegion::regionOverflowRect):
3302         (WebCore::RenderRegion::isFirstRegion):
3303         (WebCore::RenderRegion::isLastRegion):
3304         (WebCore::RenderRegion::layout):
3305         * rendering/RenderRegion.h:
3306         (WebCore::RenderRegion::setRegionRect):
3307         (WebCore::RenderRegion::regionRect):
3308
3309 2011-10-04  Chris Rogers  <crogers@google.com>
3310
3311         Avoid unnecessary ASSERT in AudioDSPKernelProcessor::setNumberOfChannels()
3312         https://bugs.webkit.org/show_bug.cgi?id=69361
3313
3314         Reviewed by James Robinson.
3315
3316         No new tests.  This changes no JavaScript API.
3317
3318         * platform/audio/AudioDSPKernelProcessor.cpp:
3319         (WebCore::AudioDSPKernelProcessor::setNumberOfChannels):
3320
3321 2011-10-04  Anders Carlsson  <andersca@apple.com>
3322
3323         Use const PlatformWheelEvent references where possible
3324         https://bugs.webkit.org/show_bug.cgi?id=69367
3325
3326         Reviewed by Sam Weinig.
3327
3328         * page/EventHandler.cpp:
3329         (WebCore::EventHandler::handleWheelEvent):
3330         * platform/ScrollAnimator.cpp:
3331         (WebCore::ScrollAnimator::handleWheelEvent):
3332         * platform/ScrollAnimator.h:
3333         * platform/ScrollView.cpp:
3334         (WebCore::ScrollView::wheelEvent):
3335         * platform/ScrollView.h:
3336         * platform/ScrollableArea.cpp:
3337         (WebCore::ScrollableArea::handleWheelEvent):
3338         * platform/ScrollableArea.h:
3339         * platform/chromium/ScrollAnimatorChromiumMac.h:
3340         * platform/chromium/ScrollAnimatorChromiumMac.mm:
3341         (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
3342         * platform/mac/ScrollAnimatorMac.h:
3343         * platform/mac/ScrollAnimatorMac.mm:
3344         (WebCore::isScrollingLeftAndShouldNotRubberBand):
3345         (WebCore::isScrollingRightAndShouldNotRubberBand):
3346         (WebCore::ScrollAnimatorMac::handleWheelEvent):
3347         (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
3348
3349 2011-10-04  Andreas Kling  <kling@webkit.org>
3350
3351         Shrink HTMLTableCellElement.
3352         https://bugs.webkit.org/show_bug.cgi?id=69347
3353
3354         Reviewed by Antti Koivisto.
3355
3356         Don't cache the rowspan and colspan attributes on the element.
3357         This shrinks HTMLTableCellElement by one CPU word, reducing memory
3358         consumption by 80 kB (on 64-bit) when loading the full HTML5 spec.
3359
3360         * html/HTMLTableCellElement.cpp:
3361         (WebCore::HTMLTableCellElement::HTMLTableCellElement):
3362         (WebCore::HTMLTableCellElement::colSpan):
3363         (WebCore::HTMLTableCellElement::rowSpan):
3364         (WebCore::HTMLTableCellElement::parseMappedAttribute):
3365         * html/HTMLTableCellElement.h:
3366
3367 2011-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3368
3369         Unreviewed, rolling out r96630.
3370         http://trac.webkit.org/changeset/96630
3371         https://bugs.webkit.org/show_bug.cgi?id=69368
3372
3373         Caused assertion failures in validateCell (Requested by
3374         mhahnenberg on #webkit).
3375
3376         * bridge/qt/qt_runtime.cpp:
3377         * bridge/qt/qt_runtime.h:
3378
3379 2011-10-04  Cary Clark  <caryclark@google.com>
3380
3381         Enable sub pixel text (Skia on Mac)
3382         https://bugs.webkit.org/show_bug.cgi?id=69354
3383         http://code.google.com/p/chromium/issues/detail?id=98165
3384
3385         Reviewed by Eric Seidel.
3386
3387         No new tests. Layout test pixel results have been
3388         disabled and will be rebaselined once all Skia on Mac
3389         changes are in.
3390
3391         * platform/graphics/skia/FontSkia.cpp:
3392         (WebCore::setupPaint):
3393         Enable sub pixel text. This is set by default to enabled
3394         by CoreGraphics, but by default disabled on Skia.
3395
3396 2011-10-04  Anders Carlsson  <andersca@apple.com>
3397
3398         Remove PlatformWheelEvent::m_isAccepted
3399         https://bugs.webkit.org/show_bug.cgi?id=69357
3400
3401         Reviewed by Darin Adler.
3402
3403         Remove PlatformWheelEvent::m_isAccepted and all the getters/setters.
3404
3405         * page/EventHandler.cpp:
3406         (WebCore::EventHandler::handleWheelEvent):
3407         (WebCore::EventHandler::handleGestureEvent):
3408         * page/mac/EventHandlerMac.mm:
3409         (WebCore::EventHandler::wheelEvent):
3410         * platform/PlatformWheelEvent.h:
3411         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3412         * platform/ScrollAnimator.cpp:
3413         (WebCore::ScrollAnimator::handleWheelEvent):
3414         * platform/chromium/PopupContainer.cpp:
3415         (WebCore::PopupContainer::handleGestureEvent):
3416         * platform/chromium/ScrollAnimatorChromiumMac.mm:
3417         (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
3418         * platform/efl/PlatformWheelEventEfl.cpp:
3419         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3420         * platform/mac/ScrollAnimatorMac.mm:
3421         (WebCore::ScrollAnimatorMac::handleWheelEvent):
3422         * platform/mac/WheelEventMac.mm:
3423         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3424         * platform/qt/WheelEventQt.cpp:
3425         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3426         * platform/win/WheelEventWin.cpp:
3427         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3428         * platform/wx/MouseWheelEventWx.cpp:
3429         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3430
3431 2011-09-21  Cris Neckar  <cdn@chromium.org>
3432
3433         Hold refptr to identified previous sibling within findPlaceForCounter.
3434         https://bugs.webkit.org/show_bug.cgi?id=68563
3435
3436         Reviewed by Adam Barth.
3437
3438         Test: fast/css/counters/counter-after-style-crash.html
3439
3440         * rendering/RenderCounter.cpp:
3441         (WebCore::findPlaceForCounter):
3442
3443 2011-10-04  Joshua Bell  <jsbell@chromium.org>
3444
3445         IndexedDB add() should fail if key is NaN
3446         https://bugs.webkit.org/show_bug.cgi?id=62286
3447
3448         Reviewed by Tony Chang.
3449
3450         Test: storage/indexeddb/invalid-keys.html
3451
3452         Implement special case - numbers are valid keys, except for NaN.
3453
3454         * bindings/v8/IDBBindingUtilities.cpp:
3455         (WebCore::createIDBKeyFromValue):
3456
3457 2011-10-04  Mark Hahnenberg  <mhahnenberg@apple.com>
3458
3459         Add static ClassInfo structs to classes that override JSCell::getCallData
3460         https://bugs.webkit.org/show_bug.cgi?id=69311
3461
3462         Reviewed by Darin Adler.
3463
3464         No new tests.
3465
3466         Added ClassInfo structs to each class that defined its own getCallData 
3467         function but did not already have its own ClassInfo struct.  This is a 
3468         necessary addition for when we switch over to looking up getCallData from 
3469         the MethodTable in ClassInfo rather than doing the virtual call (which we 
3470         are removing).  These new ClassInfo structs are public because we often 
3471         use these structs in other areas of the code to uniquely identify JSC classes and 
3472         to enforce runtime invariants based on those class identities using ASSERTs.
3473
3474         * bridge/qt/qt_runtime.cpp:
3475         * bridge/qt/qt_runtime.h:
3476
3477 2011-10-04  Ryosuke Niwa  <rniwa@webkit.org>
3478
3479         REGRESSION(r94274): setting input.value erroneously triggers focus event
3480         https://bugs.webkit.org/show_bug.cgi?id=69315
3481
3482         Reviewed by Kent Tamura.
3483
3484         Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded
3485         when called by nodeWillBeRemoved and textWillBeReplaced.
3486
3487         Added a m