[wx] Unreviewed build fixes after recent trunk changes.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-05-05  Kevin Ollivier  <kevino@theolliviers.com>
2
3         [wx] Unreviewed build fix. Include ApplicationServices for wx port.
4
5         * platform/graphics/GlyphBuffer.h:
6         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
7
8 2011-05-05  Dan Bernstein  <mitz@apple.com>
9
10         Reviewed by Simon Fraser.
11
12         WebCore part of <rdar://problem/9155590> Broken animation in iAd producer
13
14         * WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
15         * platform/graphics/ca/GraphicsLayerCA.cpp:
16         (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
17         check in Core Animation.
18         * platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
19         * platform/mac/WebCoreSystemInterface.mm: Ditto.
20
21 2011-05-05  Sam Weinig  <sam@webkit.org>
22
23         Reviewed by Anders Carlsson.
24
25         WebKit2 (Mac): Background tabs/windows can force themselves to the front
26         <rdar://problem/9386346>
27         https://bugs.webkit.org/show_bug.cgi?id=60315
28
29         * platform/mac/WidgetMac.mm:
30         (WebCore::Widget::setFocus):
31         It is incorrect for us to call Chrome::focus() here, which could bring a window/tab
32         to the front. Calling focusNSView() was only necessary because in WebKit we must inform
33         the platform widget that the focus has changed. WebKit2 Mac now matches other ports.
34
35 2011-05-05  Justin Novosad  <junov@chromium.org>
36
37         Reviewed by Kenneth Russell.
38
39         [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
40         https://bugs.webkit.org/show_bug.cgi?id=60173
41
42         * page/Page.cpp:
43         (WebCore::Page::sharedGraphicsContext3D):
44         Flipping the switch to make Skia the default for the accelerated 2d canvas
45
46 2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
47
48         Reviewed by Adam Barth.
49
50         ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
51         https://bugs.webkit.org/show_bug.cgi?id=60101
52
53         Test: fast/parser/close-while-stopping.html
54
55         * dom/Document.cpp:
56         (WebCore::Document::close): According to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-close,
57         the close() steps should be aborted if there is no script-created parser
58         associated with the document. Our parser lives throughout
59         http://www.whatwg.org/specs/web-apps/current-work/#the-end, but it seems
60         the spec doesn't consider the parser active any more. So to properly
61         respect this, we need to check that the parser is still parsing.
62
63 2011-04-28  Evan Martin  <evan@chromium.org>
64
65         Reviewed by Ojan Vafai.
66
67         REGRESSION: backspace should not go back on Linux
68         https://bugs.webkit.org/show_bug.cgi?id=59731
69
70         Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
71         Linux, and test for it in the default backspace handler.
72
73         * editing/EditingBehavior.h:
74         (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
75         * page/EventHandler.cpp:
76         (WebCore::EventHandler::defaultBackspaceEventHandler):
77
78 2011-05-05  Igor Oliveira  <igor.oliveira@openbossa.org>
79
80         Reviewed by Kenneth Russell.
81
82         Framebuffer object is being created twice
83         https://bugs.webkit.org/show_bug.cgi?id=60207
84
85         Does not create more than one opengl framebuffer
86
87         * platform/graphics/gpu/mac/DrawingBufferMac.mm:
88         (WebCore::DrawingBuffer::DrawingBuffer):
89         * platform/graphics/gpu/qt/DrawingBufferQt.cpp:
90         (WebCore::DrawingBuffer::DrawingBuffer):
91         * platform/graphics/gtk/DrawingBufferGtk.cpp:
92         (WebCore::DrawingBuffer::DrawingBuffer):
93
94 2011-05-05  Simon Fraser  <simon.fraser@apple.com>
95
96         Reviewed by Beth Dakin.
97
98         Every RenderLayer registers itself as a ScrollableArea
99         https://bugs.webkit.org/show_bug.cgi?id=59650
100
101         Rather than registering every RenderLayer as a ScrollableArea
102         on layer creation, only register RenderLayers which are overflow-
103         scrollable. Use the m_scrollableAreaPage pointer to keep track
104         of whether we've registered to avoid excess work.
105
106         * rendering/RenderLayer.cpp:
107         (WebCore::RenderLayer::RenderLayer):
108         (WebCore::RenderLayer::scrollsOverflow):
109         (WebCore::RenderLayer::styleChanged):
110         * rendering/RenderLayer.h:
111
112 2011-05-05  Jer Noble  <jer.noble@apple.com>
113
114         Reviewed by Steve Falkenburg.
115
116         Workaround iTunes' incorrect registry entry for .m4a extensions.
117         https://bugs.webkit.org/show_bug.cgi?id=60229
118
119         No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
120         The test failed to catch this regression because the build bots haven't installed iTunes.
121         
122         Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.
123
124         * platform/win/MIMETypeRegistryWin.cpp:
125         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
126
127 2011-05-05  Abhishek Arya  <inferno@chromium.org>
128
129         Reviewed by Dave Hyatt.
130
131         When style changes for a RenderBlock and we lose our ability to intrude into
132         floats in the next siblings block (e.g a position change), make sure to mark
133         our childs with floats for layout and iterate through our next sibling block
134         chain to see which ones contain the float that also exists in our floating
135         objects list and clear those using markAllDescendantsWithFloatsForLayout.
136         https://bugs.webkit.org/show_bug.cgi?id=56299
137
138         Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html
139                fast/block/float/float-not-removed-from-next-sibling.html
140                fast/block/float/float-not-removed-from-next-sibling2.html
141                fast/block/float/float-not-removed-from-next-sibling3.html
142                fast/block/float/float-not-removed-from-next-sibling4.html
143
144         * rendering/RenderBlock.cpp:
145         (WebCore::RenderBlock::styleWillChange):
146         (WebCore::RenderBlock::styleDidChange):
147         (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
148         * rendering/RenderBlock.h:
149
150 2011-05-05  Brian Weinstein  <bweinstein@apple.com>
151
152         Reviewed by Timothy Hatcher.
153
154         WebKit2: Docking Web Inspector doesn't respect maximum inspector size
155         https://bugs.webkit.org/show_bug.cgi?id=60294
156         <rdar://problem/9388518>
157
158         Make a needed function public and export it.
159
160         * WebCore.exp.in: Export constrainedAttaechedWindowHeight.
161         * inspector/InspectorFrontendClientLocal.h: Make constrainedAttaechedWindowHeight public.
162
163 2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
164
165         Reviewed by Nate Chapin.
166
167         [Navigation Timing] navigationStart should always be available
168         https://bugs.webkit.org/show_bug.cgi?id=59448
169
170         * page/PerformanceTiming.cpp:
171         (WebCore::PerformanceTiming::navigationStart):
172
173 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
174
175         Reviewed by Adam Roben.
176
177         Block callbacks delivered during destruction
178         https://bugs.webkit.org/show_bug.cgi?id=60291
179         <rdar://problem/9382942>
180
181         No new tests, tested by existing tests.
182
183         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
184         (WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call 
185             setIgnoreLoadStateChanges(true) to cancel all callbacks.
186         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if 
187             m_ignoreLoadStateChanges is true.
188         (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.
189             Don't call updateStates after calling loadedTimeRangesChanged, it already does it.
190         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
191
192 2011-05-05  David Hyatt  <hyatt@apple.com>
193
194         Reviewed by Darin Adler.
195
196         <rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive
197
198         Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
199         Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
200         (it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
201         (the object being removed has no effect on any lines).
202         
203         Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
204         is encountered has a null inlineBoxWrapper().  Just a slight speed optimization to avoid an extra null check.
205         
206         * rendering/RenderBlock.cpp:
207         (WebCore::RenderBlock::destroy):
208         * rendering/RenderInline.cpp:
209         (WebCore::RenderInline::destroy):
210         (WebCore::RenderInline::culledInlineFirstLineBox):
211         (WebCore::RenderInline::culledInlineLastLineBox):
212
213 2011-05-05  Bharathwaaj Srinivasan  <bharathwaaj.s@gmail.com>
214
215         Reviewed by Holger Freyther.
216
217         Fix build-webkit --minimal.
218         https://bugs.webkit.org/show_bug.cgi?id=60257
219
220         No new tests. This is just a build fix.
221
222         * bindings/js/JSDOMBinding.cpp:
223
224 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
225
226         Reviewed by Adam Roben.
227
228         The preload attribute of the video tag is not completely implemented
229         https://bugs.webkit.org/show_bug.cgi?id=43673
230         <rdar://problem/9369746>
231
232         This change implements "preload=metadata" for the AVFoundation backend.
233         Tested manually with manual-tests/media-elements/video-preload.html.
234
235         * html/HTMLMediaElement.cpp:
236         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
237         (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
238         (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
239         (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'
240             because we need to have media data loaded to seek.
241         (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
242         * html/HTMLMediaElement.h:
243
244         * manual-tests/media-elements/video-preload.html: Make changing urls work. 
245
246         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
247         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):  Remove 
248             m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
249         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
250         (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn. 
251             Move all preload logic to setPreload, call it from here.
252         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to 
253             setPreload, call it.
254         (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
255             unlikely to be correct and isn't worth caching. Use invalidTime() function.
256         (WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
257         (WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
258         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
259             to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
260             without one. Set networkState to 'idle' when the playback buffer is full because that is
261             a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA' 
262             when the first frame is available.
263         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
264             width, height, hasVideo, etc.
265         (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
266         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
267         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
268         (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
269             in derived classes.
270         (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
271             AVAsset and AVPlayerItem here.
272         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
273
274         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
275         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
276         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
277             m_videoFrameHasDrawn.
278         (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
279             videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
280             if we have painted a frame to the context.
281         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
282             if necessary.
283         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
284         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
285         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
286         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
287         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
288             the buffer is full.
289         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
290             AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
291             when we only have metadata.
292         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
293         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
294         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
295             when when we haven't allocated the AVPlayerItem yet so that we can report attributes
296             when we only have metadata.
297         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
298             we have allocated the AVPlayerItem.
299
300 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
301
302         Reviewed by Eric Seidel.
303
304         Rename SelectionController to FrameSelection
305         https://bugs.webkit.org/show_bug.cgi?id=60234
306
307         * CMakeLists.txt:
308         * GNUmakefile.list.am:
309         * WebCore.exp.in:
310         * WebCore.gypi:
311         * WebCore.pro:
312         * WebCore.vcproj/WebCore.vcproj:
313         * WebCore.xcodeproj/project.pbxproj:
314         * accessibility/AccessibilityObject.cpp:
315         * accessibility/AccessibilityRenderObject.cpp:
316         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
317         * accessibility/mac/AccessibilityObjectWrapper.mm:
318         * bindings/objc/ExceptionHandlers.h:
319         * css/CSSStyleSelector.cpp:
320         * dom/ContainerNode.cpp:
321         (WebCore::ContainerNode::cloneChildNodes):
322         * dom/Document.cpp:
323         * dom/InputElement.cpp:
324         * editing/DeleteButtonController.cpp:
325         * editing/EditCommand.cpp:
326         * editing/EditingAllInOne.cpp:
327         * editing/EditingStyle.cpp:
328         * editing/Editor.cpp:
329         (WebCore::Editor::canCopy):
330         (WebCore::Editor::canDelete):
331         (WebCore::Editor::markMisspellingsAfterTypingToWord):
332         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
333         (WebCore::Editor::changeSelectionAfterCommand):
334         (WebCore::Editor::respondToChangedSelection):
335         * editing/Editor.h:
336         * editing/EditorCommand.cpp:
337         (WebCore::executeDeleteToMark):
338         (WebCore::executeMoveBackward):
339         (WebCore::executeMoveBackwardAndModifySelection):
340         (WebCore::executeMoveDown):
341         (WebCore::executeMoveDownAndModifySelection):
342         (WebCore::executeMoveForward):
343         (WebCore::executeMoveForwardAndModifySelection):
344         (WebCore::executeMoveLeft):
345         (WebCore::executeMoveLeftAndModifySelection):
346         (WebCore::executeMovePageDown):
347         (WebCore::executeMovePageDownAndModifySelection):
348         (WebCore::executeMovePageUp):
349         (WebCore::executeMovePageUpAndModifySelection):
350         (WebCore::executeMoveRight):
351         (WebCore::executeMoveRightAndModifySelection):
352         (WebCore::executeMoveToBeginningOfDocument):
353         (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
354         (WebCore::executeMoveToBeginningOfLine):
355         (WebCore::executeMoveToBeginningOfLineAndModifySelection):
356         (WebCore::executeMoveToBeginningOfParagraph):
357         (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
358         (WebCore::executeMoveToBeginningOfSentence):
359         (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
360         (WebCore::executeMoveToEndOfDocument):
361         (WebCore::executeMoveToEndOfDocumentAndModifySelection):
362         (WebCore::executeMoveToEndOfSentence):
363         (WebCore::executeMoveToEndOfSentenceAndModifySelection):
364         (WebCore::executeMoveToEndOfLine):
365         (WebCore::executeMoveToEndOfLineAndModifySelection):
366         (WebCore::executeMoveToEndOfParagraph):
367         (WebCore::executeMoveToEndOfParagraphAndModifySelection):
368         (WebCore::executeMoveParagraphBackwardAndModifySelection):
369         (WebCore::executeMoveParagraphForwardAndModifySelection):
370         (WebCore::executeMoveUp):
371         (WebCore::executeMoveUpAndModifySelection):
372         (WebCore::executeMoveWordBackward):
373         (WebCore::executeMoveWordBackwardAndModifySelection):
374         (WebCore::executeMoveWordForward):
375         (WebCore::executeMoveWordForwardAndModifySelection):
376         (WebCore::executeMoveWordLeft):
377         (WebCore::executeMoveWordLeftAndModifySelection):
378         (WebCore::executeMoveWordRight):
379         (WebCore::executeMoveWordRightAndModifySelection):
380         (WebCore::executeMoveToLeftEndOfLine):
381         (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
382         (WebCore::executeMoveToRightEndOfLine):
383         (WebCore::executeMoveToRightEndOfLineAndModifySelection):
384         * editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp.
385         (WebCore::FrameSelection::FrameSelection):
386         (WebCore::FrameSelection::moveTo):
387         (WebCore::FrameSelection::setSelection):
388         (WebCore::FrameSelection::nodeWillBeRemoved):
389         (WebCore::FrameSelection::respondToNodeModification):
390         (WebCore::FrameSelection::textWillBeReplaced):
391         (WebCore::FrameSelection::setIsDirectional):
392         (WebCore::FrameSelection::directionOfEnclosingBlock):
393         (WebCore::FrameSelection::willBeModified):
394         (WebCore::FrameSelection::positionForPlatform):
395         (WebCore::FrameSelection::startForPlatform):
396         (WebCore::FrameSelection::endForPlatform):
397         (WebCore::FrameSelection::modifyExtendingRight):
398         (WebCore::FrameSelection::modifyExtendingForward):
399         (WebCore::FrameSelection::modifyMovingRight):
400         (WebCore::FrameSelection::modifyMovingForward):
401         (WebCore::FrameSelection::modifyExtendingLeft):
402         (WebCore::FrameSelection::modifyExtendingBackward):
403         (WebCore::FrameSelection::modifyMovingLeft):
404         (WebCore::FrameSelection::modifyMovingBackward):
405         (WebCore::FrameSelection::modify):
406         (WebCore::FrameSelection::xPosForVerticalArrowNavigation):
407         (WebCore::FrameSelection::clear):
408         (WebCore::FrameSelection::setStart):
409         (WebCore::FrameSelection::setEnd):
410         (WebCore::FrameSelection::setBase):
411         (WebCore::FrameSelection::setExtent):
412         (WebCore::FrameSelection::setCaretRectNeedsUpdate):
413         (WebCore::FrameSelection::updateCaretRect):
414         (WebCore::FrameSelection::caretRenderer):
415         (WebCore::FrameSelection::localCaretRect):
416         (WebCore::FrameSelection::absoluteBoundsForLocalRect):
417         (WebCore::FrameSelection::absoluteCaretBounds):
418         (WebCore::FrameSelection::caretRepaintRect):
419         (WebCore::FrameSelection::recomputeCaretRect):
420         (WebCore::FrameSelection::shouldRepaintCaret):
421         (WebCore::FrameSelection::invalidateCaretRect):
422         (WebCore::FrameSelection::paintCaret):
423         (WebCore::FrameSelection::debugRenderer):
424         (WebCore::FrameSelection::contains):
425         (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
426         (WebCore::FrameSelection::selectAll):
427         (WebCore::FrameSelection::setSelectedRange):
428         (WebCore::FrameSelection::isInPasswordField):
429         (WebCore::FrameSelection::caretRendersInsideNode):
430         (WebCore::FrameSelection::focusedOrActiveStateChanged):
431         (WebCore::FrameSelection::pageActivationChanged):
432         (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive):
433         (WebCore::FrameSelection::setUseSecureKeyboardEntry):
434         (WebCore::FrameSelection::setFocused):
435         (WebCore::FrameSelection::isFocusedAndActive):
436         (WebCore::FrameSelection::updateAppearance):
437         (WebCore::FrameSelection::setCaretVisible):
438         (WebCore::FrameSelection::clearCaretRectIfNeeded):
439         (WebCore::FrameSelection::caretBlinkTimerFired):
440         (WebCore::FrameSelection::notifyRendererOfSelectionChange):
441         (WebCore::FrameSelection::setFocusedNodeIfNeeded):
442         (WebCore::FrameSelection::paintDragCaret):
443         (WebCore::FrameSelection::copyTypingStyle):
444         (WebCore::FrameSelection::shouldDeleteSelection):
445         (WebCore::FrameSelection::bounds):
446         (WebCore::FrameSelection::getClippedVisibleTextRectangles):
447         (WebCore::FrameSelection::currentForm):
448         (WebCore::FrameSelection::revealSelection):
449         (WebCore::FrameSelection::setSelectionFromNone):
450         (WebCore::FrameSelection::shouldChangeSelection):
451         (WebCore::FrameSelection::formatForDebugger):
452         (WebCore::FrameSelection::showTreeForThis):
453         (showTree):
454         * editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h.
455         (WebCore::FrameSelection::typingStyle):
456         (WebCore::FrameSelection::clearTypingStyle):
457         (WebCore::FrameSelection::setTypingStyle):
458         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
459         * editing/ModifySelectionListLevel.cpp:
460         * editing/RemoveFormatCommand.cpp:
461         * editing/ReplaceSelectionCommand.cpp:
462         * editing/SelectionController.cpp: Removed.
463         * editing/SelectionController.h: Removed.
464         * editing/SetSelectionCommand.cpp:
465         (WebCore::SetSelectionCommand::SetSelectionCommand):
466         (WebCore::SetSelectionCommand::doApply):
467         (WebCore::SetSelectionCommand::doUnapply):
468         * editing/SetSelectionCommand.h:
469         (WebCore::SetSelectionCommand::create):
470         * editing/SpellingCorrectionCommand.cpp:
471         (WebCore::SpellingCorrectionCommand::doApply):
472         * editing/SpellingCorrectionController.cpp:
473         (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
474         * editing/TypingCommand.cpp:
475         (WebCore::TypingCommand::deleteKeyPressed):
476         (WebCore::TypingCommand::forwardDeleteKeyPressed):
477         * editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp.
478         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
479         * editing/chromium/SelectionControllerChromium.cpp: Removed.
480         * editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp.
481         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
482         * editing/gtk/SelectionControllerGtk.cpp: Removed.
483         * editing/mac/EditorMac.mm:
484         (WebCore::Editor::canCopyExcludingStandaloneImages):
485         * editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm.
486         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
487         * editing/mac/SelectionControllerMac.mm: Removed.
488         * editing/qt/EditorQt.cpp:
489         * loader/archive/cf/LegacyWebArchive.cpp:
490         * page/ContextMenuController.cpp:
491         (WebCore::ContextMenuController::populate):
492         * page/DOMSelection.cpp:
493         (WebCore::DOMSelection::type):
494         (WebCore::DOMSelection::modify):
495         (WebCore::DOMSelection::addRange):
496         (WebCore::DOMSelection::deleteFromDocument):
497         (WebCore::DOMSelection::containsNode):
498         * page/DragController.cpp:
499         (WebCore::DragController::dragIsMove):
500         * page/DragController.h:
501         * page/EventHandler.cpp:
502         (WebCore::setSelectionIfNeeded):
503         (WebCore::setNonDirectionalSelectionIfNeeded):
504         (WebCore::EventHandler::sendContextMenuEventForKey):
505         (WebCore::EventHandler::handleKeyboardSelectionMovement):
506         * page/EventHandler.h:
507         * page/FocusController.cpp:
508         (WebCore::clearSelectionIfNeeded):
509         * page/Frame.cpp:
510         (WebCore::Frame::Frame):
511         * page/Frame.h:
512         (WebCore::Frame::selection):
513         * page/Page.cpp:
514         (WebCore::Page::Page):
515         * page/Page.h:
516         (WebCore::Page::dragCaretController):
517         * page/chromium/DragControllerChromium.cpp:
518         * page/chromium/EventHandlerChromium.cpp:
519         * page/win/DragControllerWin.cpp:
520         * page/win/EventHandlerWin.cpp:
521         * rendering/HitTestResult.cpp:
522         * rendering/RenderBlock.cpp:
523         (WebCore::RenderBlock::destroy):
524         (WebCore::RenderBlock::paintCaret):
525         * rendering/RenderImage.cpp:
526         * rendering/RenderInline.cpp:
527         (WebCore::RenderInline::destroy):
528         * rendering/RenderLayer.cpp:
529         * rendering/RenderListBox.cpp:
530         * rendering/RenderObjectChildList.cpp:
531         (WebCore::RenderObjectChildList::removeChildNode):
532         * rendering/RenderTextControl.cpp:
533         * rendering/RenderTextControlSingleLine.cpp:
534         * rendering/RenderTheme.cpp:
535         * rendering/RenderTreeAsText.cpp:
536         * svg/SVGSVGElement.cpp:
537         * svg/SVGTextContentElement.cpp:
538         (WebCore::SVGTextContentElement::selectSubString):
539
540 2011-05-05  Brent Fulgham  <bfulgham@webkit.org>
541
542         [WinCairo] unreviewed build correction.
543
544         * platform/network/curl/ResourceRequest.h:
545         Stub out the new pipelined http logic for cURL.
546
547 2011-05-05  Pavel Feldman  <pfeldman@chromium.org>
548
549         Reviewed by Yury Semikhatsky.
550
551         Web Inspector: searching for node does not result in bringToFront call.
552         https://bugs.webkit.org/show_bug.cgi?id=60222
553
554         * inspector/front-end/ElementsPanel.js:
555         (WebInspector.ElementsPanel.prototype.updateFocusedNode):
556
557 2011-05-05  Andreas Kling  <andreas.kling@nokia.com>
558
559         Reviewed by Simon Hausmann.
560
561         [Qt] Implement the fast font path for Qt.
562         https://bugs.webkit.org/show_bug.cgi?id=51106
563
564         Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
565         rendering and measurement of simple text.
566
567         Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
568         classes are fully integrated into the Qt 4.8 release branch.
569
570         * WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.
571
572         * platform/graphics/Font.cpp:
573         (WebCore::Font::drawText): Disable fast font path for stroked text, and when
574         painting text with a shadow. (Qt-only)
575         (WebCore::Font::codePath): Try to use fast font path in more cases.
576
577         * platform/graphics/qt/FontCacheQt.cpp:
578         (WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont
579         to use for rendering a given string. Goes through QTextLayout to find the best
580         font based on the original QFont query.
581         (WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.
582
583         * platform/graphics/qt/FontPlatformData.h:
584         (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
585         (WebCore::FontPlatformData::FontPlatformData):
586         (WebCore::FontPlatformData::rawFont):
587         * platform/graphics/qt/FontPlatformDataQt.cpp:
588         (WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.
589
590         * platform/graphics/qt/FontQt.cpp:
591         (WebCore::fillPenForContext):
592         (WebCore::strokePenForContext):
593         (WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon
594         to share code between complex and simple font rendering paths.
595         (WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().
596
597         * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
598         (WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().
599
600         * platform/graphics/qt/SimpleFontDataQt.cpp:
601         (WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we
602         have no way of knowing the pitch.
603         (WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter().
604         (WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes().
605         (WebCore::SimpleFontData::scaledFontData): Added, based on other ports.
606         (WebCore::SimpleFontData::smallCapsFontData): Ditto.
607         (WebCore::SimpleFontData::emphasisMarkFontData): Ditto.
608         (WebCore::SimpleFontData::platformBoundsForGlyph): Stub.
609         (WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics.
610         (WebCore::SimpleFontData::platformCharWidthInit): Ditto.
611
612 2011-05-05  Alexis Menard  <alexis.menard@openbossa.org>
613
614         Reviewed by Andreas Kling.
615
616         [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
617         https://bugs.webkit.org/show_bug.cgi?id=60224
618
619         We should use nullptr rather than 0. nullptr will be added in the new C++ standard
620         but WebKit already has a nullptr class if there is no c++0x support.
621
622         * platform/qt/RenderThemeQt.cpp:
623         (WebCore::RenderThemeQt::adjustProgressBarStyle):
624         (WebCore::RenderThemeQt::adjustSliderTrackStyle):
625         (WebCore::RenderThemeQt::adjustSliderThumbStyle):
626
627 2011-05-05  Ilya Tikhonovsky  <loislo@chromium.org>
628
629         Reviewed by Yury Semikhatsky.
630
631         Web Inspector: rename BrowserDebugger to DOMDebugger.
632
633         https://bugs.webkit.org/show_bug.cgi?id=60256
634         InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
635         browserDebugger => domDebugger
636
637         * CMakeLists.txt:
638         * GNUmakefile.list.am:
639         * WebCore.gypi:
640         * WebCore.pro:
641         * WebCore.vcproj/WebCore.vcproj:
642         * WebCore.xcodeproj/project.pbxproj:
643         * inspector/CodeGeneratorInspector.pm:
644         * inspector/InspectorAgent.cpp:
645         (WebCore::InspectorAgent::InspectorAgent):
646         (WebCore::InspectorAgent::inspectedPageDestroyed):
647         (WebCore::InspectorAgent::disconnectFrontend):
648         * inspector/InspectorAgent.h:
649         (WebCore::InspectorAgent::DOMDebuggerAgent):
650         * inspector/InspectorController.cpp:
651         (WebCore::InspectorController::connectFrontend):
652         * inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp.
653         (WebCore::InspectorDOMDebuggerAgent::create):
654         (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
655         (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
656         (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled):
657         (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled):
658         (WebCore::InspectorDOMDebuggerAgent::disable):
659         (WebCore::InspectorDOMDebuggerAgent::clearFrontend):
660         (WebCore::InspectorDOMDebuggerAgent::discardBindings):
661         (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
662         (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
663         (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode):
664         (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode):
665         (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
666         (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
667         (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
668         (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
669         (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
670         (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
671         (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint):
672         (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints):
673         (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
674         (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
675         (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
676         (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
677         (WebCore::InspectorDOMDebuggerAgent::clear):
678         * inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
679         * inspector/InspectorInstrumentation.cpp:
680         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
681         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
682         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
683         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
684         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
685         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
686         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
687         * inspector/InstrumentingAgents.h:
688         (WebCore::InstrumentingAgents::InstrumentingAgents):
689         (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent):
690         (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
691         * inspector/WorkerInspectorController.cpp:
692         (WebCore::WorkerInspectorController::connectFrontend):
693
694 2011-05-04  Yury Semikhatsky  <yurys@chromium.org>
695
696         Reviewed by Pavel Feldman.
697
698         Web Inspector: show only Console and Scripts panels in worker inspector front-end
699         https://bugs.webkit.org/show_bug.cgi?id=60159
700
701         * inspector/front-end/WorkerManager.js:
702         (WebInspector.WorkerManager.isWorkerFrontend):
703         * inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.
704
705 2011-05-03  Hans Wennborg  <hans@chromium.org>
706
707         Reviewed by Steve Block.
708
709         IndexedDB: Unit tests for LevelDB key coding functions
710         https://bugs.webkit.org/show_bug.cgi?id=59692
711
712         Fix some embarrassing bugs uncovered by unit tests.
713
714         No new functionality, but this is now covered by unit tests in the Chromium WebKit port.
715
716         * storage/IDBLevelDBCoding.cpp:
717         (WebCore::IDBLevelDBCoding::decodeInt):
718         (WebCore::IDBLevelDBCoding::decodeVarInt):
719
720 2011-05-05  Young Han Lee  <joybro@company100.net>
721
722         Reviewed by Csaba Osztrogonác.
723
724         [Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
725         https://bugs.webkit.org/show_bug.cgi?id=60251
726
727         No new tests. Build fix.
728
729         * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
730         (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
731
732 2011-05-04  Jay Civelli  <jcivelli@chromium.org>
733
734         Reviewed by Adam Barth.
735
736         Adding a utility class to read a SharedBuffer line by line.
737         https://bugs.webkit.org/show_bug.cgi?id=59946
738
739         * CMakeLists.txt:
740         * GNUmakefile.list.am:
741         * WebCore.gypi:
742         * WebCore.pro:
743         * WebCore.vcproj/WebCore.vcproj:
744         * WebCore.xcodeproj/project.pbxproj:
745         * platform/SharedBufferCRLFLineReader.cpp: Added.
746         * platform/SharedBufferCRLFLineReader.h: Added.
747
748 2011-05-04  Sheriff Bot  <webkit.review.bot@gmail.com>
749
750         Unreviewed, rolling out r85788.
751         http://trac.webkit.org/changeset/85788
752         https://bugs.webkit.org/show_bug.cgi?id=60250
753
754         svg/text/text-block-child-crash.xhtml asserts (Requested by
755         Ossy on #webkit).
756
757         * css/CSSStyleSelector.cpp:
758         (WebCore::CSSStyleSelector::applyProperty):
759
760 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
761
762         Reviewed by Eric Seidel.
763
764         Make more member functions in EventHandler private
765         https://bugs.webkit.org/show_bug.cgi?id=60200
766
767         Reduced the number of public member functions in EventHandler.
768
769         * WebCore.exp.in:
770         * page/EventHandler.cpp:
771         (WebCore::EventHandler::handleAutoscroll):
772         (WebCore::EventHandler::autoscrollTimerFired):
773         (WebCore::EventHandler::stopAutoscrollTimer):
774         (WebCore::EventHandler::handleMousePressEvent):
775         (WebCore::EventHandler::handleMouseMoveEvent):
776         (WebCore::EventHandler::keyEvent):
777         (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
778         * page/EventHandler.h:
779         (WebCore::EventHandler::mouseDownMayStartSelect):
780
781 2011-05-04  James Robinson  <jamesr@chromium.org>
782
783         Reviewed by Kenneth Russell.
784
785         [chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
786         https://bugs.webkit.org/show_bug.cgi?id=60202
787
788         In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check.  This switches
789         the order back and adds a regression test.
790
791         Test: compositing/repaint/transform-style-change.html
792
793         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
794         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
795
796 2011-05-04  Cris Neckar  <cdn@chromium.org>
797
798         Reviewed by Adam Barth.
799
800         Expose WebView directly through ChromeClient.
801         https://bugs.webkit.org/show_bug.cgi?id=49902
802
803         Test: fast/media/media-svg-crash.html
804
805         * loader/EmptyClients.h:
806         (WebCore::EmptyChromeClient::webView):
807         * page/ChromeClient.h:
808         * page/brew/ChromeClientBrew.h:
809         (WebCore::ChromeClientBrew::webView):
810
811 2011-05-04  Joseph Pecoraro  <joepeck@webkit.org>
812
813         Reviewed by Darin Adler.
814
815         Unable to Paste After Deleting Text from Input due to -webkit-user-select
816         https://bugs.webkit.org/show_bug.cgi?id=60219
817
818         When deleting all the text inside the input a placeholder <br>
819         element was inserted for the selection point. However, when
820         pasting, the test run computes the -webkit-user-select for the
821         <br> element, instead of what would be the text inside the
822         <input> and incorrectly disallows selection and prevented
823         the paste.
824
825         Test: editing/pasteboard/paste-placeholder-input.html
826
827         * editing/ReplaceSelectionCommand.cpp:
828         (WebCore::ReplacementFragment::insertFragmentForTestRendering): skip
829         <br> elements above us as those are likely placeholder elements.
830
831 2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>
832
833         Reviewed by Martin Robinson.
834
835         Windows build of WebKit GTK needs to be able to find SystemInfo.h
836         https://bugs.webkit.org/show_bug.cgi?id=60221
837
838         * GNUmakefile.am: add Source/WebCore/platform/win to the paths searched
839         for headers, since Source/WebCore/platform/win/SystemInfo.h
840         header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
841         on Windows.
842
843 2011-05-04  Vangelis Kokkevis  <vangelis@chromium.org>
844
845         Reviewed by Kenneth Russell.
846
847         [chromium] Improve sorting of layers in hierarchies that preserve-3d
848         by testing for overlapping regions between layer pairs and doing a
849         topological sort to determine the right order.
850         https://bugs.webkit.org/show_bug.cgi?id=59255
851
852         Test: platform/chromium/compositing/perpendicular-layer-sorting.html
853
854         * WebCore.gypi:
855         * platform/graphics/chromium/LayerRendererChromium.cpp:
856         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
857         * platform/graphics/chromium/LayerRendererChromium.h:
858         * platform/graphics/chromium/cc/CCLayerImpl.h:
859         (WebCore::CCLayerImpl::clearRenderSurface):
860         * platform/graphics/chromium/cc/CCLayerSorter.cpp: Added.
861         (WebCore::perpProduct):
862         (WebCore::innerProduct):
863         (WebCore::pointInColinearEdge):
864         (WebCore::edgeEdgeTest):
865         (WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
866         (WebCore::CCLayerSorter::LayerIntersector::go):
867         (WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest):
868         (WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest):
869         (WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
870         (WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
871         (WebCore::CCLayerSorter::CCLayerSorter):
872         (WebCore::CCLayerSorter::checkOverlap):
873         (WebCore::CCLayerSorter::createGraphNodes):
874         (WebCore::CCLayerSorter::createGraphEdges):
875         (WebCore::CCLayerSorter::removeEdgeFromList):
876         (WebCore::CCLayerSorter::sort):
877         * platform/graphics/chromium/cc/CCLayerSorter.h: Added.
878         (WebCore::CCLayerSorter::GraphNode::GraphNode):
879         (WebCore::CCLayerSorter::GraphEdge::GraphEdge):
880
881 2011-05-03  Jer Noble  <jer.noble@apple.com>
882
883         Reviewed by Antti Koivisto.
884
885         Safari: Video at apple.com cannot play at full screen mode with layout distortion
886         https://bugs.webkit.org/show_bug.cgi?id=60140
887
888         Because a fullscreen element may be in a stacking context with a lower z-index than
889         a sibling stacking context, those higher contexts would sometimes "pop" through the 
890         full screen renderer. To facilitate eliminating all the stacking contexts aside from
891         the full screen renderer, added a new pseudo-class specific to video or audio full
892         screen elements. Then, added a new UA rule which resets the z-index and opacities of 
893         all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
894         identity checking of HTMLMediaElements, added isMediaElement() virtual function to 
895         Element and HTMLMediaElement. 
896
897         Test: fullscreen/full-screen-stacking-context.html
898
899         * css/CSSSelector.cpp:
900         (WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument.
901         (WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument.
902         (WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
903         * css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
904         * css/CSSStyleSelector.cpp:
905         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
906         * css/fullscreen.css:
907         (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names, 
908             which were missing the -webkit prefix.
909         (:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.
910         * dom/Element.h:
911         (WebCore::Element::isMediaElement): Added, returns false.
912         * html/HTMLMediaElement.h:
913         (WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
914         * rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.
915
916 2011-05-04  Levi Weintraub  <leviw@chromium.org>
917
918         Reviewed by Eric Seidel.
919
920         Split findNextLineBreak into a LineBreaker class
921         https://bugs.webkit.org/show_bug.cgi?id=60209
922
923         Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
924         nearly no state, but subsequent patches will move some of the local variables used throughout
925         the nextLineBreak function into member variables to simplify breaking off helper functions from
926         the bloated function.
927
928         No new tests since this is just moving code around.
929
930         * WebCore.xcodeproj/project.pbxproj:
931         * rendering/RenderBlock.h:
932         (WebCore::RenderBlock::LineBreaker::LineBreaker):
933         (WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor.
934         (WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto.
935         (WebCore::RenderBlock::LineBreaker::clear): Ditto.
936         * rendering/RenderBlockLineLayout.cpp:
937         (WebCore::RenderBlock::layoutRunsAndFloats):
938         (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
939         (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
940         (WebCore::RenderBlock::LineBreaker::reset):
941         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
942
943 2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>
944
945         Reviewed by Adam Barth.
946
947         Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
948         The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
949         https://bugs.webkit.org/show_bug.cgi?id=58579
950
951         * dom/XMLDocumentParserLibxml2.cpp:
952         (WebCore::XMLDocumentParser::error):
953
954 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
955
956         Unreviewed warning fix.
957
958         The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
959         a warning in Release build.
960
961         * dom/Node.cpp:
962         (WebCore::Node::removeEventListener):
963         * platform/DateComponents.cpp:
964         (WebCore::DateComponents::parseTime):
965         * rendering/RenderLayer.cpp:
966         (WebCore::RenderLayer::convertToLayerCoords):
967         * storage/StorageMap.cpp:
968         (WebCore::StorageMap::importItem):
969         * svg/SVGUseElement.cpp:
970         (WebCore::SVGUseElement::buildShadowTree):
971         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
972
973 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
974
975         Unreviewed warning fix.
976
977         The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
978         a warning in Release build.
979
980         * accessibility/AccessibilityRenderObject.cpp:
981         (WebCore::lastChildConsideringContinuation):
982
983 2011-05-04  Dimitri Glazkov  <dglazkov@chromium.org>
984
985         Sort xcodeproj files.
986
987         The WebCore.xcodeproj got out of sorts again.
988
989         * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
990
991 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
992
993         Reviewed by Adam Barth.
994
995         Warning fix.
996
997         * bindings/js/DOMObjectHashTableMap.h:
998         (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
999
1000 2011-05-04  Rob Buis  <rbuis@rim.com>
1001
1002         Reviewed by Darin Adler.
1003
1004         NULL deref when SVG elements have table styles 
1005         https://bugs.webkit.org/show_bug.cgi?id=45561
1006
1007         Restrict computed CSS values for SVG display property to block, inline or none.
1008
1009         Tests: svg/custom/display-table-caption-foreignObject.svg
1010                svg/custom/display-table-caption-inherit-foreignObject.xhtml
1011                svg/custom/display-table-caption-inherit-text.xhtml
1012                svg/custom/display-table-caption-text.svg
1013
1014         * css/CSSStyleSelector.cpp:
1015         (WebCore::CSSStyleSelector::applyProperty):
1016
1017 2011-05-04  Tao Bai  <michaelbai@chromium.org>
1018
1019         Reviewed by David Kilzer.
1020
1021         Populate touch-icon url to FrameLoaderClient
1022         https://bugs.webkit.org/show_bug.cgi?id=59143
1023         
1024         Parsed and populated apple-touch-icon url to FrameLoaderClient.
1025         Changed favicon to be a type of icon.
1026
1027         * CMakeLists.txt:
1028         * Configurations/FeatureDefines.xcconfig:
1029         * GNUmakefile.am:
1030         * GNUmakefile.list.am:
1031         * WebCore.gypi:
1032         * WebCore.vcproj/WebCore.vcproj:
1033         * WebCore.xcodeproj/project.pbxproj:
1034         * dom/Document.cpp:
1035         (WebCore::Document::iconURL):
1036         (WebCore::Document::setIconURL):
1037         * dom/Document.h:
1038         * dom/IconURL.cpp: Added.
1039         (WebCore::toIconIndex):
1040         * dom/IconURL.h: Added.
1041         (WebCore::IconURL::IconURL):
1042         * features.pri:
1043         * html/HTMLLinkElement.cpp:
1044         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
1045         (WebCore::HTMLLinkElement::process):
1046         (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
1047         * html/HTMLLinkElement.h:
1048         (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
1049         (WebCore::HTMLLinkElement::isEnabledViaScript):
1050         * html/parser/HTMLPreloadScanner.cpp:
1051         (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
1052         * loader/DocumentLoader.cpp:
1053         (WebCore::DocumentLoader::iconURL):
1054         (WebCore::DocumentLoader::setIconURL):
1055         * loader/DocumentLoader.h:
1056         * loader/EmptyClients.h:
1057         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
1058         * loader/FrameLoader.cpp:
1059         (WebCore::FrameLoader::iconURL):
1060         (WebCore::FrameLoader::iconURLs):
1061         (WebCore::FrameLoader::fillIconURL):
1062         (WebCore::FrameLoader::getDefaultIconURL):
1063         (WebCore::FrameLoader::setIconURL):
1064         (WebCore::FrameLoader::didChangeIcons):
1065         * loader/FrameLoader.h:
1066         * loader/FrameLoaderClient.h:
1067
1068 2011-05-04  Chris Marrin  <cmarrin@apple.com>
1069
1070         Reviewed by Simon Fraser.
1071
1072         Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
1073         https://bugs.webkit.org/show_bug.cgi?id=60191
1074
1075         Skip replaceSublayer when there is no superlayer rather than asserting.
1076         This is probably not a problem and happens when restructuring the layer
1077         tree. Avoiding this crash will allow us to get more testing.
1078
1079         * platform/graphics/ca/GraphicsLayerCA.cpp:
1080         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
1081
1082 2011-05-04  Martin Robinson  <mrobinson@igalia.com>
1083
1084         Reviewed by Gustavo Noronha Silva.
1085
1086         Fix the GTK+ 2.x build for Windows. Instead of making getStockIcon a RenderTheme
1087         method, just use extern declarations to avoid having to declare it in the header.
1088         This will prevent having to include glib.h in RenderThemeGtk.h, which is included
1089         in many C++ files.
1090
1091         No new tests. This is just a build fix.
1092
1093         * platform/gtk/RenderThemeGtk.cpp: Update getStockIcon calls to say getStockIconForWidgetType.
1094         (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
1095         (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
1096         (WebCore::RenderThemeGtk::paintCapsLockIndicator):
1097         (WebCore::RenderThemeGtk::paintMediaButton):
1098         * platform/gtk/RenderThemeGtk.h: Removed getStockIcon declaration. Make gtkContainer() and
1099         gtkEntry() public because they are now accessed externally from getStockIcon().
1100         * platform/gtk/RenderThemeGtk2.cpp: Update getStockIcon calls.
1101         (WebCore::getStockIconForWidgetType):
1102         * platform/gtk/RenderThemeGtk3.cpp: Ditto.
1103         (WebCore::getStockIconForWidgetType):
1104
1105 2011-05-04  Mark Pilgrim  <pilgrim@chromium.org>
1106
1107         Reviewed by Tony Chang.
1108
1109         IndexedDB open (database) should fail if name is null
1110         https://bugs.webkit.org/show_bug.cgi?id=60022
1111
1112         Test: storage/indexeddb/mozilla/open-database-null-name.html
1113
1114         Combination problem: Bug in IDL didn't pass null values to .cpp layer,
1115         then .cpp layer didn't check for null value anyway.
1116
1117         * storage/IDBFactory.cpp:
1118         (WebCore::IDBFactory::open): check for null name
1119         * storage/IDBFactory.idl: pass null name as null
1120
1121 2011-05-04  Jer Noble  <jer.noble@apple.com>
1122
1123         Reviewed by Darin Adler.
1124
1125         Entering full screen fails >= second time on Vimeo.com.
1126         https://bugs.webkit.org/show_bug.cgi?id=60143
1127
1128         Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
1129         Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
1130         at the end of an animation, if it determined that the RenderFullScreen would still require
1131         a layer even when not animating.
1132
1133         * rendering/RenderFullScreen.cpp:
1134         (RenderFullScreen::setAnimating): Clear the renderer's layer.
1135
1136 2011-05-04  Simon Fraser  <simon.fraser@apple.com>
1137
1138         Reviewed by Darin Adler.
1139
1140         Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
1141         https://bugs.webkit.org/show_bug.cgi?id=59849
1142
1143         When attempting to unwind the graphics state stack in the
1144         CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
1145         to create a new ImageBuffer.
1146
1147         * html/HTMLCanvasElement.cpp:
1148         (WebCore::HTMLCanvasElement::existingDrawingContext):
1149         * html/HTMLCanvasElement.h:
1150         * html/canvas/CanvasRenderingContext2D.cpp:
1151         (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
1152
1153 2011-05-04  Andrey Kosyakov  <caseq@chromium.org>
1154
1155         Reviewed by Yury Semikhatsky.
1156
1157         Web Inspector: expose shadow DOM in the Elements panel
1158         https://bugs.webkit.org/show_bug.cgi?id=60160
1159
1160         Test: inspector/elements/shadow-dom.html
1161
1162         * dom/Element.cpp:
1163         (WebCore::Element::ensureShadowRoot):
1164         (WebCore::Element::removeShadowRoot):
1165         * inspector/Inspector.json:
1166         * inspector/InspectorDOMAgent.cpp:
1167         (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
1168         (WebCore::InspectorDOMAgent::buildObjectForNode):
1169         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1170         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1171         (WebCore::InspectorDOMAgent::isContainerNode):
1172         * inspector/InspectorDOMAgent.h:
1173         * inspector/front-end/DOMAgent.js:
1174         (WebInspector.DOMNode):
1175         (WebInspector.DOMNode.prototype.inShadowTree):
1176         (WebInspector.DOMNode.prototype._setShadowRootPayload):
1177         (WebInspector.DOMNode.prototype._renumber):
1178         (WebInspector.DOMAgent.prototype._bindNodes):
1179         (WebInspector.DOMAgent.prototype.querySelectorAll):
1180         (WebInspector.DOMAgent.prototype._shadowRootUpdated):
1181         (WebInspector.DOMDispatcher.prototype.searchResults):
1182         (WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
1183         * inspector/front-end/ElementsPanel.js:
1184         (WebInspector.ElementsPanel):
1185         (WebInspector.ElementsPanel.prototype._nodeUpdated):
1186         (WebInspector.ElementsPanel.prototype._attributesUpdated):
1187         (WebInspector.ElementsPanel.prototype._nodeRemoved):
1188         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
1189         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1190         * inspector/front-end/ElementsTreeOutline.js:
1191         (WebInspector.ElementsTreeElement):
1192         (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
1193         (WebInspector.ElementsTreeElement.prototype._updateChildren):
1194         ():
1195         * inspector/front-end/inspector.css:
1196         (#elements-content .dom-shadow-root):
1197         (.outline-disclosure li .webkit-html-tag.shadow):
1198         * inspector/front-end/utilities.js:
1199
1200 2011-05-03  Adam Roben  <aroben@apple.com>
1201
1202         Remove an unnecessary OwnPtr equality check in XSLT code
1203
1204         Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error
1205
1206         Reviewed by Anders Carlsson and Antti Koivisto.
1207
1208         * dom/Document.cpp:
1209         (WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
1210         equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
1211         we're safe.)
1212
1213 2011-05-04  Leandro Gracia Gil  <leandrogracia@chromium.org>
1214
1215         Reviewed by Tony Gentilcore.
1216
1217         Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
1218         https://bugs.webkit.org/show_bug.cgi?id=56922
1219
1220         Add the basic outlines of the page controller, the per-frame controller and the embedder
1221         client interface for the Media Stream API. Provide methods to handle the situations
1222         where a frame is detached from the page or transferred between pages.
1223
1224         Tests for the Media Stream API will be provided by the bug 56587.
1225
1226         * CMakeLists.txt:
1227         * GNUmakefile.list.am:
1228         * WebCore.gypi:
1229         * WebCore.pro:
1230         * WebCore.vcproj/WebCore.vcproj:
1231         * WebCore.xcodeproj/project.pbxproj:
1232         * page/Frame.cpp:
1233         (WebCore::Frame::Frame):
1234         (WebCore::Frame::~Frame):
1235         (WebCore::Frame::pageDestroyed):
1236         (WebCore::Frame::transferChildFrameToNewDocument):
1237         * page/Frame.h:
1238         (WebCore::Frame::mediaStreamFrameController):
1239         * page/MediaStreamClient.h: Added.
1240         (WebCore::MediaStreamClient::~MediaStreamClient):
1241         * page/MediaStreamController.cpp: Added.
1242         (WebCore::MediaStreamController::Request::Request):
1243         (WebCore::MediaStreamController::Request::localId):
1244         (WebCore::MediaStreamController::Request::frameController):
1245         (WebCore::MediaStreamController::MediaStreamController):
1246         (WebCore::MediaStreamController::~MediaStreamController):
1247         (WebCore::MediaStreamController::unregisterFrameController):
1248         (WebCore::MediaStreamController::registerRequest):
1249         * page/MediaStreamController.h: Added.
1250         * page/MediaStreamFrameController.cpp: Added.
1251         (WebCore::MediaStreamFrameController::Request::Request):
1252         (WebCore::MediaStreamFrameController::Request::~Request):
1253         (WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
1254         (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
1255         (WebCore::MediaStreamFrameController::Request::isRecordedDataRequest):
1256         (WebCore::MediaStreamFrameController::RequestMap::abort):
1257         (WebCore::MediaStreamFrameController::RequestMap::abortAll):
1258         (WebCore::MediaStreamFrameController::MediaStreamFrameController):
1259         (WebCore::MediaStreamFrameController::~MediaStreamFrameController):
1260         (WebCore::MediaStreamFrameController::securityOrigin):
1261         (WebCore::MediaStreamFrameController::scriptExecutionContext):
1262         (WebCore::MediaStreamFrameController::pageController):
1263         (WebCore::MediaStreamFrameController::enterDetachedState):
1264         (WebCore::MediaStreamFrameController::disconnectPage):
1265         (WebCore::MediaStreamFrameController::disconnectFrame):
1266         (WebCore::MediaStreamFrameController::transferToNewPage):
1267         * page/MediaStreamFrameController.h: Added.
1268         * page/Page.cpp:
1269         (WebCore::Page::Page):
1270         (WebCore::Page::PageClients::PageClients):
1271         * page/Page.h:
1272         (WebCore::Page::mediaStreamController):
1273
1274 2011-05-04  Alexander Pavlov  <apavlov@chromium.org>
1275
1276         Reviewed by Yury Semikhatsky.
1277
1278         Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
1279         https://bugs.webkit.org/show_bug.cgi?id=60150
1280
1281         * inspector/front-end/StylesSidebarPane.js:
1282         (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
1283
1284 2011-05-04  Dominic Battre  <battre@chromium.org>
1285
1286         Reviewed by Tony Gentilcore.
1287
1288         Fix missing header in case SVG is disabled
1289         https://bugs.webkit.org/show_bug.cgi?id=60153
1290
1291         * dom/EventDispatcher.cpp:
1292
1293 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
1294
1295         Reviewed by Eric Seidel.
1296
1297         Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
1298         https://bugs.webkit.org/show_bug.cgi?id=60006
1299
1300         No new tests as no functionality added. Simple rename only.
1301
1302         * css/CSSStyleApplyProperty.cpp:
1303         Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
1304         * css/CSSStyleApplyProperty.h:
1305         Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
1306
1307 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
1308
1309         Reviewed by Eric Seidel.
1310
1311         Cleanup conditionals in findNextLineBreak
1312         https://bugs.webkit.org/show_bug.cgi?id=60117
1313
1314         Simplified conditional statements in findNextLineBreak.
1315
1316         * rendering/RenderBlockLineLayout.cpp:
1317         (WebCore::RenderBlock::findNextLineBreak):
1318
1319 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
1320
1321         Reviewed by Eric Seidel.
1322
1323         Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
1324         https://bugs.webkit.org/show_bug.cgi?id=60114
1325
1326         No new tests as no functionality changes.
1327
1328         * css/CSSStyleSelector.cpp:
1329         (WebCore::CSSStyleSelector::applyProperty):
1330         Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.
1331
1332 2011-05-04  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1333
1334         Reviewed by Andreas Kling.
1335
1336         [Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
1337         https://bugs.webkit.org/show_bug.cgi?id=59070
1338
1339         Applications using our API and our autotests subclass QNetworkReply as part of providing a
1340         custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
1341         QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
1342         4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.
1343
1344         The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
1345         watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
1346         indicating that it is finished. When there's no finished signal (synchronous) we set the
1347         dynamic property once we get the reply.
1348
1349         This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
1350         emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.
1351
1352         * platform/network/qt/QNetworkReplyHandler.cpp:
1353         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
1354         Connect the finished signal to the new setFinished() slot.
1355
1356         (WebCore::QNetworkReplyWrapper::synchronousLoad):
1357         Since we don't get the finished signal for synchronous loads, set the dynamic property
1358         before processing it.
1359
1360         (WebCore::QNetworkReplyWrapper::resetConnections):
1361         Do not reset the connection to setFinished().
1362
1363         (WebCore::QNetworkReplyWrapper::setFinished):
1364         Set the dynamic property in the reply.
1365
1366         (WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
1367         (WebCore::QNetworkReplyHandler::start):
1368         Change to use wrapper's isFinished() instead of asking the reply directly.
1369
1370         * platform/network/qt/QNetworkReplyHandler.h:
1371         (WebCore::QNetworkReplyWrapper::isFinished):
1372         Checks the dynamic property of the reply.
1373
1374         * platform/network/qt/QtMIMETypeSniffer.cpp:
1375         (QtMIMETypeSniffer::sniff):
1376         Use the dynamic property to check if the reply is finished.
1377
1378 2011-05-04  Eric Seidel  <eric@webkit.org>
1379
1380         Reviewed by Ryosuke Niwa.
1381
1382         Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
1383         https://bugs.webkit.org/show_bug.cgi?id=60080
1384
1385         No functional change, just moving code.
1386
1387         * rendering/RenderBlock.h:
1388         * rendering/RenderBlockLineLayout.cpp:
1389         (WebCore::RenderBlock::createLineBoxesFromBidiRuns):
1390         (WebCore::RenderBlock::layoutRunsAndFloats):
1391
1392 2011-05-04  Andreas Kling  <andreas.kling@nokia.com>
1393
1394         Reviewed by Kenneth Rohde Christiansen.
1395
1396         [Qt] Remove unused function FontPlatformData::pixelSize()
1397         https://bugs.webkit.org/show_bug.cgi?id=60156
1398
1399         * platform/graphics/qt/FontPlatformData.h:
1400         (WebCore::FontPlatformData::pixelSize): Removed.
1401
1402 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
1403
1404         Reviewed by Darin Adler.
1405
1406         Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
1407         https://bugs.webkit.org/show_bug.cgi?id=60011
1408
1409         No new tests added as no functionality changed.
1410
1411         * css/CSSStyleSelector.cpp:
1412         (WebCore::CSSStyleSelector::applyProperty):
1413         Remove reundant check for auto table layout.
1414
1415 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
1416
1417         Reviewed by Darin Adler.
1418
1419         Remove double-free checks for bug 56124
1420         https://bugs.webkit.org/show_bug.cgi?id=60037
1421
1422         Antti's speculative fix for bug 56124 (r84151) appears to have worked,
1423         these CRASH() calls are not triggering anymore.
1424
1425         * css/CSSSelector.h:
1426         (WebCore::CSSSelector::CSSSelector):
1427         (WebCore::CSSSelector::~CSSSelector):
1428         * css/CSSSelectorList.cpp:
1429         (WebCore::CSSSelectorList::deleteSelectors):
1430
1431 2011-05-04  Satish Sampath  <satish@chromium.org>
1432
1433         Reviewed by Tony Gentilcore.
1434
1435         Layout the speech input button to the left of outer spin button properly.
1436         https://bugs.webkit.org/show_bug.cgi?id=59742
1437
1438         * rendering/RenderTextControlSingleLine.cpp:
1439         (WebCore::RenderTextControlSingleLine::layout):
1440
1441 2011-05-04  Yury Semikhatsky  <yurys@chromium.org>
1442
1443         Unreviewed. Build fix.
1444
1445         * bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration
1446
1447 2011-05-03  Yury Semikhatsky  <yurys@chromium.org>
1448
1449         Reviewed by Pavel Feldman.
1450
1451         Web Inspector: can't inspect element in an iframe when element originates from non-frame document
1452         https://bugs.webkit.org/show_bug.cgi?id=60031
1453         
1454         Inspected object type evaluation has moved into native bindings. This way it doesn't
1455         depend on the current JS context.
1456
1457         Test: inspector/elements/elements-inspect-iframe-from-different-domain.html
1458
1459         * bindings/js/JSInjectedScriptHostCustom.cpp:
1460         (WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish
1461         real undefined values from HTMLAllCollection
1462         (WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed
1463         value
1464         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
1465         (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
1466         (WebCore::V8InjectedScriptHost::typeCallback):
1467         * inspector/InjectedScriptHost.idl:
1468         * inspector/InjectedScriptSource.js:
1469         (.):
1470
1471 2011-05-03  Pratik Solanki  <psolanki@apple.com>
1472
1473         Reviewed by Antti Koivisto.
1474
1475         Part of WebCore should use CFNetwork-based loader on Mac
1476         https://bugs.webkit.org/show_bug.cgi?id=51836
1477
1478         Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
1479         up some warnings and #if USE(CFNETWORK) around code.
1480
1481         * platform/mac/CookieJar.mm:
1482         * platform/network/CookieStorage.h:
1483         * platform/network/cf/CookieStorageCFNet.cpp:
1484         (WebCore::privateBrowsingCookieStorage):
1485         (WebCore::currentCookieStorage):
1486         (WebCore::setCurrentCookieStorage):
1487         (WebCore::setCookieStoragePrivateBrowsingEnabled):
1488         (WebCore::notifyCookiesChangedOnMainThread):
1489         (WebCore::notifyCookiesChanged):
1490         * platform/network/cf/CookieStorageCFNet.h:
1491         * platform/network/mac/CookieStorageMac.mm:
1492
1493 2011-05-03  Justin Novosad  <junov@chromium.org>
1494
1495         Reviewed by Kenneth Russell.
1496
1497         [Chromium] Make accelerated 2d canvas enabled by default with skia
1498         https://bugs.webkit.org/show_bug.cgi?id=59929
1499
1500         No new tests. Covered by existing layout tests
1501
1502         * html/canvas/CanvasRenderingContext2D.cpp:
1503         (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
1504         Initialized for accelerated canvas if either the accelerated2dCanvas
1505         or the legacyAccelerated2dCanvas flags are enabled
1506         * page/Page.cpp:
1507         (WebCore::Page::sharedGraphicsContext3D):
1508         This is where the code goes to implement the functionality for the
1509         legacy vs current acceleration paths for the 2D canvas. Currently,
1510         this is a no-op, and always select the legacy path.  This is temporary
1511         until we are ready to sort the GPU layout tests (rebasline vs. bug)
1512         * page/Settings.cpp:  Added new flage for legacyAccelerated2dCanvas
1513         (WebCore::Settings::Settings):
1514         (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
1515         * page/Settings.h:
1516         (WebCore::Settings::legacyAccelerated2dCanvasEnabled):
1517
1518 2011-04-29  Jer Noble  <jer.noble@apple.com>
1519
1520         Reviewed by Eric Seidel.
1521
1522         Implement FULLSCREEN_API on Windows, Part 4: Enable it
1523         https://bugs.webkit.org/show_bug.cgi?id=59798
1524
1525         * WebCore.vcproj/WebCore.vcproj: Add missing full screen related
1526             files to the project.
1527
1528 2011-05-03  Alpha Lam  <hclam@chromium.org>
1529
1530         Not reviewed. Build fix.
1531
1532         More places from 0 to nullptr.
1533
1534         * bindings/v8/V8Proxy.cpp:
1535         (WebCore::V8Proxy::precompileScript):
1536         * platform/graphics/chromium/LayerTilerChromium.cpp:
1537         (WebCore::LayerTilerChromium::create):
1538         * platform/graphics/gpu/BicubicShader.cpp:
1539         (WebCore::BicubicShader::create):
1540         * platform/graphics/gpu/ConvolutionShader.cpp:
1541         (WebCore::ConvolutionShader::create):
1542         * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
1543         (WebCore::LoopBlinnSolidFillShader::create):
1544         * platform/graphics/gpu/SolidFillShader.cpp:
1545         (WebCore::SolidFillShader::create):
1546         * platform/graphics/gpu/TexShader.cpp:
1547         (WebCore::TexShader::create):
1548         * platform/graphics/skia/PlatformContextSkia.cpp:
1549         (WebCore::PlatformContextSkia::~PlatformContextSkia):
1550         * platform/leveldb/LevelDBDatabase.cpp:
1551         (WebCore::LevelDBDatabase::createIterator):
1552         * platform/text/LocalizedNumberICU.cpp:
1553         (WebCore::createFormatterForCurrentLocale):
1554
1555 2011-05-03  Alpha Lam  <hclam@chromium.org>
1556
1557         Not reviewed. Build fix.
1558
1559         Using nullptr instead of 0. This makes visual studio happy.
1560
1561         * storage/IDBTransactionBackendInterface.h:
1562
1563 2011-05-03  Luke Macpherson   <macpherson@chromium.org>
1564
1565         Reviewed by Dimitri Glazkov.
1566
1567         Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
1568         https://bugs.webkit.org/show_bug.cgi?id=59774
1569
1570         No new tests required as on new functionality.
1571
1572         * css/CSSStyleApplyProperty.cpp:
1573         (WebCore::ApplyPropertyColor::applyValue):
1574         Added template parameter "inheritColorFromParent = false".
1575         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
1576         Use template parameter where appropriate.
1577
1578 2011-05-03  Dan Bernstein  <mitz@apple.com>
1579
1580         Reviewed by Darin Adler.
1581
1582         <rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.
1583
1584         Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
1585         dirty the line when the float is removed, instead of relying on the float always intersecting
1586         its originating line.
1587
1588         * rendering/RenderBlock.cpp:
1589         (WebCore::RenderBlock::removeFloatingObject):
1590         (WebCore::RenderBlock::removeFloatingObjectsBelow):
1591         (WebCore::RenderBlock::clearFloats):
1592         * rendering/RenderBlock.h:
1593         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1594         * rendering/RenderBlockLineLayout.cpp:
1595         (WebCore::RenderBlock::appendFloatingObjectToLastLine):
1596         (WebCore::RenderBlock::layoutRunsAndFloats):
1597         (WebCore::RenderBlock::determineStartPosition):
1598
1599 2011-05-02  Jer Noble  <jer.noble@apple.com>
1600
1601         Reviewed by Adam Roben.
1602
1603         Implement FULLSCREEN_API on Windows, Part 3: WebKit2
1604         https://bugs.webkit.org/show_bug.cgi?id=59845
1605
1606         Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
1607         and WebKit2.  WebFullScreenController now uses a Client class to request work on its
1608         behalf by WebKit and WebKit2.  MediaPlayerPrivateFullscreenWindow now only creates a 
1609         CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
1610         problems, and because a CALayerHost is overkill if the window is only drawing black to
1611         its client area.
1612
1613         * WebCore.vcproj/WebCore.vcproj:
1614         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
1615         (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create 
1616             m_layerHost in the constructor.
1617         (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
1618         (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
1619         (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is
1620             not present, fill the window with black in WM_PAINT.
1621         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
1622         * platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
1623         * platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
1624         * platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h
1625         (WebCore::FullScreenControllerClient::~FullScreenControllerClient):
1626
1627 2011-05-03  Brady Eidson  <beidson@apple.com>
1628
1629         Reviewed by Sam Weinig.
1630
1631         https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
1632         WK2 Icon Database should provide access to all image representations in the icon.
1633
1634         Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:
1635         * platform/graphics/BitmapImage.h:
1636         * platform/graphics/Image.h:
1637         (WebCore::Image::getCGImageArray):
1638         * platform/graphics/cg/ImageCG.cpp:
1639         (WebCore::BitmapImage::getCGImageArray):
1640
1641 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
1642
1643         Reviewed by Eric Seidel.
1644
1645         findNextLineBreak splits InlineIterator into 3 pieces
1646         https://bugs.webkit.org/show_bug.cgi?id=60082
1647
1648         Avoid splitting InlineIterator into 3 variables with inter-dependencies.
1649
1650         * rendering/InlineIterator.h:
1651         (WebCore::InlineIterator::fastIncrementInTextNode): Added.
1652         (WebCore::InlineIterator::previousInSameNode): Added.
1653         * rendering/RenderBlockLineLayout.cpp:
1654         (WebCore::RenderBlock::findNextLineBreak):
1655
1656 2011-05-03  Dean Jackson  <dino@apple.com>
1657
1658         Reviewed by Simon Fraser.
1659
1660         Interrupted transitions are not correctly removed
1661         https://bugs.webkit.org/show_bug.cgi?id=60062
1662
1663         CompositeAnimation was replacing any existing
1664         transition as a new one was created. However, it wasn't
1665         clearing the lists in AnimationControllerPrivate that
1666         signal when a hardware animation starts. Rather than
1667         simple removing the existing transition, we now tell
1668         AnimationControllerPrivate that is has gone.
1669
1670         Test: transitions/3d/interrupted-transition.html
1671
1672         * page/animation/CompositeAnimation.cpp:
1673         (WebCore::CompositeAnimation::updateTransitions):
1674
1675 2011-05-03  Enrica Casucci  <enrica@apple.com>
1676
1677         Reviewed by Ryosuke Niwa.
1678
1679         Crash in SpellingCorrectionController::respondToChangedSelection.
1680         https://bugs.webkit.org/show_bug.cgi?id=60071
1681         <rdar://problem/9358190>
1682
1683         Creating a Visible position could trigger a layout and there is no
1684         guarantee that the selection is still valid after that.
1685
1686         Tests: editing/selection/undo-crash.html
1687
1688         * editing/SpellingCorrectionController.cpp:
1689         (WebCore::SpellingCorrectionController::respondToChangedSelection):
1690
1691 2011-05-03  Levi Weintraub  <leviw@chromium.org>
1692
1693         Reviewed by Eric Seidel.
1694
1695         Refactor computeInlineDirectionPositionsForLine into smaller functions
1696         https://bugs.webkit.org/show_bug.cgi?id=60072
1697
1698         Split three functions off from computeInlineDirectionPositionsForLine
1699         to improve its readability.
1700
1701         No new tests since this is just moving code around.
1702
1703         * rendering/RenderBlock.h:
1704         * rendering/RenderBlockLineLayout.cpp:
1705         (WebCore::RenderBlock::setMarginsForRubyRun):
1706         (WebCore::setLogicalWidthForTextRun):
1707         (WebCore::computeExpansionForJustifiedText):
1708         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
1709
1710 2011-05-03  David Kilzer  <ddkilzer@apple.com>
1711
1712         <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
1713
1714         Reviewed by Antti Koivisto.
1715
1716         * platform/network/cf/ResourceRequestCFNet.cpp:
1717         (WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
1718         priority on the request if HTTP pipelining is enabled.
1719         (WebCore::ResourceRequest::doUpdateResourceRequest): Read the
1720         priority from the request if HTTP pipelining is enabled.
1721         (readBooleanPreference): Enable code when compiling with
1722         USE(CFNETWORK).
1723         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
1724         Comment out setting the minimum fast lane priority on Windows
1725         since it's not currently available.
1726
1727 2011-05-03  Simon Fraser  <simon.fraser@apple.com>
1728
1729         Reviewed by Dan Bernstein.
1730
1731         <rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on
1732
1733         Conditionalize compositing tiled layer size-constraining logic to older
1734         OSes.
1735
1736         * platform/graphics/ca/GraphicsLayerCA.cpp:
1737         (WebCore::GraphicsLayerCA::constrainedSize):
1738
1739 2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>
1740
1741         Reviewed by Dimitri Glazkov.
1742
1743         Allow access keys to be used in shadow DOM
1744         https://bugs.webkit.org/show_bug.cgi?id=59979
1745
1746         Move access key methods and members back to Document from TreeScope.
1747         Also traverse into shadow trees when building the access key map.
1748
1749         No new tests. (refactoring)
1750
1751         * dom/Document.cpp:
1752         (WebCore::Document::Document):
1753         (WebCore::Document::getElementByAccessKey):
1754         (WebCore::Document::buildAccessKeyMap):
1755         (WebCore::Document::invalidateAccessKeyMap):
1756         * dom/Document.h:
1757         * dom/TreeScope.cpp:
1758         (WebCore::TreeScope::TreeScope):
1759         (WebCore::TreeScope::destroyTreeScopeData):
1760         * dom/TreeScope.h:
1761
1762 2011-05-03  Dan Bernstein  <mitz@apple.com>
1763
1764         Reviewed by Darin Adler.
1765
1766         <rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
1767         https://bugs.webkit.org/show_bug.cgi?id=60067
1768
1769         No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.
1770
1771         * rendering/RenderText.cpp:
1772         (WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
1773         and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
1774         results for flipped writing modes.
1775
1776 2011-05-03  Anton Muhin  <antonm@chromium.org>
1777
1778         Reviewed by Yury Semikhatsky.
1779
1780         [v8] remove an ASSERT from grouping logic
1781         https://bugs.webkit.org/show_bug.cgi?id=60024
1782
1783         This ASSERT was exploratory.  Alas, right now I am aware of no easy way to
1784         repro it.  Removing for now for greener bots.
1785
1786         No new tests, only an ASSERT removal.
1787
1788         * bindings/v8/V8GCController.cpp:
1789         (WebCore::calculateGroupId):
1790
1791 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
1792
1793         Reviewed by Darin Adler.
1794
1795         WebKit allows selection that crosses the shadow boundary of a readonly input element
1796         https://bugs.webkit.org/show_bug.cgi?id=60000
1797
1798         The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
1799         Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
1800         in its validation process.
1801
1802         Tests: editing/selection/select-across-readonly-input-1.html
1803                editing/selection/select-across-readonly-input-2.html
1804                editing/selection/select-across-readonly-input-3.html
1805                editing/selection/select-across-readonly-input-4.html
1806                editing/selection/select-across-readonly-input-5.html
1807
1808         * editing/VisibleSelection.cpp:
1809         (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
1810         (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
1811         * editing/VisibleSelection.h:
1812
1813 2011-05-03  Eric Seidel  <eric@webkit.org>
1814
1815         Reviewed by Ryosuke Niwa.
1816
1817         Split out layoutRunsAndFloats from layoutInlineChildren
1818         https://bugs.webkit.org/show_bug.cgi?id=60052
1819
1820         No new tests, just moving code here.  There should be
1821         no change in behavior.
1822
1823         * rendering/RenderBlock.h:
1824         * rendering/RenderBlockLineLayout.cpp:
1825         (WebCore::RenderBlock::layoutRunsAndFloats):
1826         (WebCore::RenderBlock::layoutInlineChildren):
1827
1828 2011-05-03  James Robinson  <jamesr@chromium.org>
1829
1830         Reviewed by Kenneth Russell.
1831
1832         [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
1833         https://bugs.webkit.org/show_bug.cgi?id=59965
1834
1835         Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.
1836
1837         Test: fast/canvas/canvas-resize-after-paint.html
1838
1839         * html/canvas/CanvasRenderingContext2D.cpp:
1840         (WebCore::CanvasRenderingContext2D::reset):
1841             Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
1842             DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.
1843         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
1844         (WebCore::Canvas2DLayerChromium::setLayerRenderer):
1845             Add a null check for m_drawingBuffer
1846         * platform/graphics/gpu/DrawingBuffer.cpp:
1847         (WebCore::DrawingBuffer::clear):
1848             Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
1849             this is unnecessary.
1850
1851 2011-05-03  Adam Roben  <aroben@apple.com>
1852
1853         Fix most strict PassOwnPtr violations on Windows
1854
1855         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
1856         enabled
1857
1858         Reviewed by Anders Carlsson.
1859
1860         * loader/EmptyClients.h:
1861         * platform/GeolocationService.cpp:
1862         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1863         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1864         * platform/mock/GeolocationServiceMock.cpp:
1865         * rendering/RenderTheme.cpp:
1866         * rendering/RenderThemeSafari.cpp:
1867
1868 2011-05-03  Levi Weintraub  <leviw@chromium.org>
1869
1870         Reviewed by Eric Seidel.
1871
1872         Extract LineInfo class
1873         https://bugs.webkit.org/show_bug.cgi?id=60044
1874
1875         Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
1876         layout information about a line. This simplifies function signatures and clears up initialization.
1877
1878         No new tests as this is refactoring.
1879
1880         * rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
1881         * rendering/RenderBlockLineLayout.cpp:
1882         (WebCore::LineInfo::LineInfo):
1883         (WebCore::LineInfo::isFirstLine):
1884         (WebCore::LineInfo::isLastLine):
1885         (WebCore::LineInfo::isEmpty):
1886         (WebCore::LineInfo::previousLineBrokeCleanly):
1887         (WebCore::LineInfo::setFirstLine):
1888         (WebCore::LineInfo::setLastLine):
1889         (WebCore::LineInfo::setEmpty):
1890         (WebCore::LineInfo::setPreviousLineBrokeCleanly):
1891         (WebCore::RenderBlock::createLineBoxes):
1892         (WebCore::RenderBlock::constructLine):
1893         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
1894         (WebCore::RenderBlock::layoutInlineChildren):
1895         (WebCore::RenderBlock::determineStartPosition):
1896         (WebCore::skipNonBreakingSpace):
1897         (WebCore::shouldCollapseWhiteSpace):
1898         (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp
1899         (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
1900         (WebCore::RenderBlock::skipTrailingWhitespace):
1901         (WebCore::RenderBlock::skipLeadingWhitespace):
1902         (WebCore::RenderBlock::findNextLineBreak):
1903
1904 2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>
1905
1906         Reviewed by Dimitri Glazkov.
1907
1908         Update node list cache count on the containing TreeScope rather than the Document
1909         https://bugs.webkit.org/show_bug.cgi?id=59983
1910
1911         Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
1912         Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
1913         Make setDocument() and setDocumentRecursively() private.
1914
1915         No new tests. (refactoring)
1916
1917         * dom/ContainerNode.cpp:
1918         (WebCore::ContainerNode::childrenChanged):
1919         * dom/Node.cpp:
1920         (WebCore::Node::~Node):
1921         (WebCore::Node::setDocument):
1922         (WebCore::Node::setTreeScopeRecursively):
1923         (WebCore::Node::childNodes):
1924         (WebCore::Node::registerDynamicNodeList):
1925         (WebCore::Node::unregisterDynamicNodeList):
1926         (WebCore::Node::notifyLocalNodeListsAttributeChanged):
1927         (WebCore::Node::notifyLocalNodeListsChildrenChanged):
1928         (WebCore::Node::getElementsByTagName):
1929         (WebCore::Node::getElementsByTagNameNS):
1930         (WebCore::Node::getElementsByName):
1931         (WebCore::Node::getElementsByClassName):
1932         * dom/Node.h:
1933         * html/HTMLFormControlElement.cpp:
1934         (WebCore::HTMLFormControlElement::labels):
1935
1936 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
1937
1938         Reviewed by Eric Seidel.
1939
1940         Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
1941         https://bugs.webkit.org/show_bug.cgi?id=60046
1942
1943         Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.
1944
1945         * rendering/RenderBlockLineLayout.cpp:
1946         (WebCore::TrailingObjects::TrailingObjects):
1947         (WebCore::TrailingObjects::setTrailingWhitespace):
1948         (WebCore::TrailingObjects::clear):
1949         (WebCore::TrailingObjects::appendBoxIfNeeded):
1950         (WebCore::TrailingObjects::addMidpoints):
1951         (WebCore::RenderBlock::findNextLineBreak):
1952
1953 2011-05-03  Igor Oliveira  <igor.oliveira@openbossa.org>
1954
1955         Reviewed by Eric Seidel.
1956
1957         [Qt] Implement initial support to DataTransferItems
1958         https://bugs.webkit.org/show_bug.cgi?id=58448
1959
1960         Implement initial support to DataTransferItems. DataTransferItems are used to 
1961         hold data for drag and drop operations. DataTransferItems hold a list of 
1962         DataTransferItem objects each of which holds an item being dragged.
1963
1964         * WebCore.pro:
1965         * dom/DataTransferItems.idl:
1966         * editing/qt/EditorQt.cpp:
1967         (WebCore::Editor::newGeneralClipboard):
1968         * page/qt/EventHandlerQt.cpp:
1969         (WebCore::EventHandler::createDraggingClipboard):
1970         * platform/chromium/DataTransferItemsChromium.h:
1971         * platform/qt/ClipboardQt.cpp:
1972         (WebCore::Clipboard::create):
1973         (WebCore::ClipboardQt::ClipboardQt):
1974         (WebCore::ClipboardQt::items):
1975         * platform/qt/ClipboardQt.h:
1976         (WebCore::ClipboardQt::create):
1977         * platform/qt/DataTransferItemQt.cpp: Added.
1978         (WebCore::DataTransferItem::create):
1979         (WebCore::DataTransferItemQt::createFromPasteboard):
1980         (WebCore::DataTransferItemQt::create):
1981         (WebCore::DataTransferItemQt::DataTransferItemQt):
1982         (WebCore::DataTransferItemQt::getAsString):
1983         (WebCore::DataTransferItemQt::getAsFile):
1984         * platform/qt/DataTransferItemQt.h: Added.
1985         * platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
1986         (WebCore::DataTransferItemsQt::create):
1987         (WebCore::DataTransferItemsQt::DataTransferItemsQt):
1988         (WebCore::DataTransferItemsQt::addPasteboardItem):
1989         * platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
1990
1991 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
1992
1993         Reviewed by Dimitri Glazkov.
1994
1995         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
1996         https://bugs.webkit.org/show_bug.cgi?id=58703
1997
1998         No new tests, refactoring only.
1999
2000         * dom/Element.cpp:
2001         (WebCore::Element::copyNonAttributeProperties):
2002         (WebCore::Element::insertedIntoDocument):
2003         (WebCore::Element::removedFromDocument):
2004         (WebCore::Element::insertedIntoTree):
2005         (WebCore::Element::removedFromTree):
2006         (WebCore::Element::attach):
2007         (WebCore::Element::detach):
2008         (WebCore::Element::recalcStyle):
2009         (WebCore::Element::shadowRoot):
2010         (WebCore::Element::ensureShadowRoot):
2011         (WebCore::Element::childrenChanged):
2012         * dom/Node.cpp:
2013         (WebCore::Node::setTreeScopeRecursively):
2014         (WebCore::shadowRoot):
2015         (WebCore::Node::setDocumentRecursively):
2016         (WebCore::NodeRendererFactory::findVisualParent):
2017         Updated all the call sites for shadowRoot and ensureShadowRoot in the 2
2018         previous classes.
2019
2020         * dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.
2021
2022         * dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.
2023
2024         * html/HTMLDetailsElement.cpp:
2025         * html/HTMLSummaryElement.cpp:
2026         Added #include for ShadowRoot.h.
2027
2028 2011-05-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2029
2030         Reviewed by Kenneth Rohde Christiansen.
2031
2032         [EFL] Implement mediaSliderTrack
2033         https://bugs.webkit.org/show_bug.cgi?id=59998
2034
2035         Implement paintMediaSliderTrack.
2036
2037         * platform/efl/RenderThemeEfl.cpp:
2038         (WebCore::RenderThemeEfl::RenderThemeEfl):
2039         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
2040         * platform/efl/RenderThemeEfl.h:
2041
2042 2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>
2043
2044         Reviewed by Pavel Feldman.
2045
2046         WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
2047         https://bugs.webkit.org/show_bug.cgi?id=60023
2048
2049         * inspector/front-end/DetailedHeapshotGridNodes.js:
2050         (WebInspector.HeapSnapshotConstructorNode):
2051         (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
2052         * inspector/front-end/HeapSnapshot.js:
2053         (WebInspector.HeapSnapshot.prototype.dispose):
2054         (WebInspector.HeapSnapshot.prototype.aggregates):
2055         (WebInspector.HeapSnapshot.prototype._buildAggregates):
2056         (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
2057         (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
2058         (WebInspector.HeapSnapshotFilteredOrderedIterator):
2059         (WebInspector.HeapSnapshotNodesProvider):
2060         * inspector/front-end/HeapSnapshotProxy.js:
2061         (WebInspector.HeapSnapshotProxy.prototype.aggregates):
2062         (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
2063
2064 2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>
2065
2066         Reviewed by Pavel Feldman.
2067
2068         WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
2069         https://bugs.webkit.org/show_bug.cgi?id=60029
2070
2071         * English.lproj/localizedStrings.js:
2072         * inspector/front-end/DetailedHeapshotView.js:
2073         (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset):
2074         (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
2075
2076 2011-05-03  Beth Dakin  <bdakin@apple.com>
2077
2078         Reviewed by Dan Bernstein.
2079
2080         https://bugs.webkit.org/show_bug.cgi?id=60045
2081         Scrollbar thumb sometimes leaves artifacts in the track after scrolling
2082         -and corresponding-
2083         <rdar://problem/9015376>
2084
2085         When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should 
2086         always be ignored.
2087         * platform/mac/ScrollbarThemeMac.mm:
2088         (WebCore::updateArrowPlacement):
2089
2090 2011-05-03  David Hyatt  <hyatt@apple.com>
2091
2092         Reviewed by Dan Bernstein.
2093
2094         https://bugs.webkit.org/show_bug.cgi?id=60040
2095         <rdar://problem/9261591>
2096
2097         Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
2098         a translation of a 0,0 point to absolute coordinates so that the top left position is
2099         accurate.
2100
2101         Added fast/inline/skipped-whitespace-client-rect.html
2102         
2103         * rendering/RenderInline.cpp:
2104         (WebCore::RenderInline::culledInlineAbsoluteQuads):
2105
2106 2011-05-03  Sam Weinig  <sam@webkit.org>
2107
2108         Fix chromium build.
2109
2110         * page/Settings.cpp:
2111
2112 2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>
2113
2114         Reviewed by Dimitri Glazkov.
2115
2116         Bug 59974 - Update image map on the containing TreeScope rather than the Document
2117         https://bugs.webkit.org/show_bug.cgi?id=59974
2118
2119         No new tests. (reefactoring)
2120
2121         * html/HTMLMapElement.cpp:
2122         (WebCore::HTMLMapElement::parseMappedAttribute):
2123         (WebCore::HTMLMapElement::insertedIntoDocument):
2124         (WebCore::HTMLMapElement::removedFromDocument):
2125         * rendering/RenderImage.cpp:
2126         (WebCore::RenderImage::imageMap):
2127
2128 2011-05-03  Sam Weinig  <sam@webkit.org>
2129
2130         Fix chromium build.
2131
2132         * loader/HistoryController.cpp:
2133
2134 2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>
2135
2136         Reviewed by Dimitri Glazkov.
2137
2138         Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
2139         https://bugs.webkit.org/show_bug.cgi?id=59966
2140
2141         No new tests. (refactoring)
2142
2143         * accessibility/AccessibilityRenderObject.cpp:
2144         (WebCore::AccessibilityRenderObject::elementsFromAttribute):
2145         (WebCore::AccessibilityRenderObject::activeDescendant):
2146         * accessibility/AccessibilityRenderObject.h:
2147         (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
2148         * css/CSSCursorImageValue.cpp:
2149         (WebCore::resourceReferencedByCursorElement):
2150         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
2151         (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
2152         (WebCore::CSSCursorImageValue::cachedImage):
2153         * dom/DynamicNodeList.cpp:
2154         (WebCore::DynamicNodeList::itemWithName):
2155         * dom/Element.h:
2156         (WebCore::Element::updateId):
2157         * dom/Node.cpp:
2158         (WebCore::Node::querySelector):
2159         * html/FormAssociatedElement.cpp:
2160         (WebCore::FormAssociatedElement::insertedIntoTree):
2161         (WebCore::FormAssociatedElement::resetFormOwner):
2162         * html/HTMLInputElement.cpp:
2163         (WebCore::HTMLInputElement::dataList):
2164         * html/HTMLLabelElement.cpp:
2165         (WebCore::HTMLLabelElement::control):
2166         * rendering/svg/RenderSVGTextPath.cpp:
2167         (WebCore::RenderSVGTextPath::layoutPath):
2168         * svg/SVGAElement.cpp:
2169         (WebCore::SVGAElement::defaultEventHandler):
2170         * svg/SVGAltGlyphElement.cpp:
2171         (WebCore::SVGAltGlyphElement::glyphElement):
2172         * svg/SVGFEImageElement.cpp:
2173         (WebCore::SVGFEImageElement::requestImageResource):
2174         (WebCore::SVGFEImageElement::build):
2175         * svg/SVGLinearGradientElement.cpp:
2176         (WebCore::SVGLinearGradientElement::collectGradientAttributes):
2177         * svg/SVGMPathElement.cpp:
2178         (WebCore::SVGMPathElement::pathElement):
2179         * svg/SVGPatternElement.cpp:
2180         (WebCore::SVGPatternElement::collectPatternAttributes):
2181         * svg/SVGRadialGradientElement.cpp:
2182         (WebCore::SVGRadialGradientElement::collectGradientAttributes):
2183         * svg/SVGSVGElement.cpp:
2184         (WebCore::SVGSVGElement::getElementById):
2185         * svg/SVGTRefElement.cpp:
2186         (WebCore::SVGTRefElement::updateReferencedText):
2187         * svg/SVGTextPathElement.cpp:
2188         (WebCore::SVGTextPathElement::insertedIntoDocument):
2189         * svg/SVGUseElement.cpp:
2190         (WebCore::SVGUseElement::buildPendingResource):
2191         (WebCore::SVGUseElement::hasCycleUseReferencing):
2192         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
2193         * svg/SVGViewSpec.cpp:
2194         (WebCore::SVGViewSpec::viewTarget):
2195         * svg/animation/SVGSMILElement.cpp:
2196         (WebCore::SVGSMILElement::eventBaseFor):
2197         (WebCore::SVGSMILElement::connectConditions):
2198         (WebCore::SVGSMILElement::targetElement):
2199         * xml/XPathFunctions.cpp:
2200         (WebCore::XPath::FunId::evaluate):
2201
2202 2011-05-03  Sam Weinig  <sam@webkit.org>
2203
2204         Fix chromium build.
2205
2206         * css/StyleMedia.cpp:
2207
2208 2011-05-03  Sam Weinig  <sam@webkit.org>
2209
2210         Reviewed by Anders Carlsson.
2211
2212         Prune #includes from FrameView.h (Part 1)
2213         https://bugs.webkit.org/show_bug.cgi?id=59957
2214
2215         * page/FrameView.h:
2216         Prune #includes.
2217
2218         * accessibility/chromium/AXObjectCacheChromium.cpp:
2219         * page/win/FrameCGWin.cpp:
2220         * platform/Scrollbar.cpp:
2221         Add not necessary #includes.
2222
2223         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2224         Add now necessary forward declaration.
2225
2226 2011-05-03  Andrey Kosyakov  <caseq@chromium.org>
2227
2228         Reviewed by Dimitri Glazkov.
2229
2230         [Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
2231         https://bugs.webkit.org/show_bug.cgi?id=60026
2232
2233         Return a wrapper for Node in toV8(Node*) when called with a node of type
2234         SHADOW_ROOT_NODE instead of entering infinite recursion.
2235
2236         * bindings/v8/custom/V8NodeCustom.cpp:
2237         (WebCore::toV8Slow):
2238
2239 2011-05-02  Adam Roben  <aroben@apple.com>
2240
2241         Take advantage of implicit conversion from nullptr_t to PassOwnPtr
2242
2243         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
2244         doesn't work, but should
2245
2246         Reviewed by Adam Barth.
2247
2248         * bindings/js/ScheduledAction.cpp:
2249         * css/CSSStyleSelector.cpp:
2250         * css/MediaList.cpp:
2251         * css/MediaQueryMatcher.cpp:
2252         * css/SVGCSSStyleSelector.cpp:
2253         * dom/MessagePort.cpp:
2254         * html/InputType.cpp:
2255         * html/canvas/WebGLRenderingContext.cpp:
2256         * inspector/InspectorStyleSheet.cpp:
2257         * page/ContextMenuController.cpp:
2258         * page/Page.cpp:
2259         * platform/PlatformGestureRecognizer.cpp:
2260         * platform/PurgeableBuffer.h:
2261         * platform/graphics/ImageBuffer.h:
2262         * platform/leveldb/LevelDBDatabase.cpp:
2263         * platform/mac/PurgeableBufferMac.cpp:
2264         * platform/text/RegularExpression.cpp:
2265         * rendering/RenderTheme.cpp:
2266         * rendering/RenderThemeMac.mm:
2267         * rendering/style/RenderStyle.h:
2268         * rendering/style/SVGRenderStyleDefs.cpp:
2269         * rendering/style/ShadowData.cpp:
2270         * rendering/style/StyleRareInheritedData.cpp:
2271         * rendering/style/StyleRareNonInheritedData.cpp:
2272         * rendering/svg/RenderSVGResourcePattern.cpp:
2273
2274 2011-05-03  Pavel Feldman  <pfeldman@google.com>
2275
2276         Not reviewed: fix inspector status bar image glyph reference in network panel.
2277
2278         * inspector/front-end/networkPanel.css:
2279         (.network-larger-resources-status-bar-item .glyph):
2280
2281 2011-05-03  Pavel Feldman  <pfeldman@google.com>
2282
2283         Reviewed by Yury Semikhatsky.
2284
2285         Web Inspector: rename BrowserDebugger agent to DOMDebugger.
2286         https://bugs.webkit.org/show_bug.cgi?id=60019
2287
2288         * inspector/CodeGeneratorInspector.pm:
2289         * inspector/Inspector.json:
2290         * inspector/InspectorController.cpp:
2291         (WebCore::InspectorController::connectFrontend):
2292         * inspector/front-end/BreakpointsSidebarPane.js:
2293         (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
2294         (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
2295         (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
2296         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
2297         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
2298         * inspector/generate-inspector-idl:
2299
2300 2011-05-03  Yury Semikhatsky  <yurys@chromium.org>
2301
2302         Reviewed by Pavel Feldman.
2303
2304         Web Inspector: remove special logic for type of document.__proto__
2305         https://bugs.webkit.org/show_bug.cgi?id=60014
2306
2307         Test: inspector/console/console-log-document-proto.html
2308
2309         * inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined
2310
2311 2011-05-03  Pavel Feldman  <pfeldman@google.com>
2312
2313         Not reviewed: fixed typo in inspector style.
2314
2315         * inspector/front-end/inspector.css:
2316         (.status-bar-item > .glyph):
2317
2318 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
2319
2320         Reviewed by Yury Semikhatsky.
2321
2322         Web Inspector: revision history storage is too slow.
2323         https://bugs.webkit.org/show_bug.cgi?id=59939
2324
2325         It turns out that iterating localStorage keys is very
2326         expensive (results in slow inspector start), refactor revision
2327         history in order not to rely upon that operation.
2328
2329         * inspector/front-end/Resource.js:
2330         (WebInspector.Resource):
2331         (WebInspector.Resource._resourceRevisionRegistry):
2332         (WebInspector.Resource.restoreRevisions.persist):
2333         (WebInspector.Resource.restoreRevisions):
2334         (WebInspector.Resource.persistRevision):
2335         (WebInspector.Resource.prototype._persistRevision):
2336         * inspector/front-end/ResourceTreeModel.js:
2337         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2338         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2339
2340 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
2341
2342         Reviewed by Yury Semikhatsky.
2343
2344         Web Inspector: combine toolbar icon images.
2345         https://bugs.webkit.org/show_bug.cgi?id=59931
2346
2347         * WebCore.gypi:
2348         * inspector/front-end/Images/auditsIcon.png: Removed.
2349         * inspector/front-end/Images/consoleIcon.png: Removed.
2350         * inspector/front-end/Images/elementsIcon.png: Removed.
2351         * inspector/front-end/Images/networkIcon.png: Removed.
2352         * inspector/front-end/Images/profilesIcon.png: Removed.
2353         * inspector/front-end/Images/resourcesIcon.png: Removed.
2354         * inspector/front-end/Images/scriptsIcon.png: Removed.
2355         * inspector/front-end/Images/timelineIcon.png: Removed.
2356         * inspector/front-end/Images/toolbarIcons.png: Added.
2357         * inspector/front-end/Images/toolbarIconsSmall.png: Added.
2358         * inspector/front-end/WebKit.qrc:
2359         * inspector/front-end/inspector.css:
2360         (.toolbar-icon):
2361         (#toolbar-dropdown .toolbar-icon):
2362         (.toolbar-item:active .toolbar-icon):
2363         (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
2364         (.toolbar-item.elements .toolbar-icon):
2365         (.toolbar-item.resources .toolbar-icon):
2366         (#toolbar-dropdown .toolbar-item.resources .toolbar-icon):
2367         (.toolbar-item.network .toolbar-icon):
2368         (#toolbar-dropdown .toolbar-item.network .toolbar-icon):
2369         (.toolbar-item.scripts .toolbar-icon):
2370         (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon):
2371         (.toolbar-item.timeline .toolbar-icon):
2372         (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon):
2373         (.toolbar-item.profiles .toolbar-icon):
2374         (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon):
2375         (.toolbar-item.audits .toolbar-icon):
2376         (#toolbar-dropdown .toolbar-item.audits .toolbar-icon):
2377         (.toolbar-item.console .toolbar-icon):
2378         (#toolbar-dropdown .toolbar-item.console .toolbar-icon):
2379         (.status-bar-item > .glyph):
2380
2381 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
2382
2383         Reviewed by Yury Semikhatsky.
2384
2385         Web Inspector: combine status bar button glyphs.
2386         https://bugs.webkit.org/show_bug.cgi?id=59885
2387
2388         * WebCore.gypi:
2389         * inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
2390         * inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
2391         * inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
2392         * inspector/front-end/Images/consoleButtonGlyph.png: Removed.
2393         * inspector/front-end/Images/dockButtonGlyph.png: Removed.
2394         * inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
2395         * inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
2396         * inspector/front-end/Images/excludeButtonGlyph.png: Removed.
2397         * inspector/front-end/Images/focusButtonGlyph.png: Removed.
2398         * inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
2399         * inspector/front-end/Images/gearButtonGlyph.png: Removed.
2400         * inspector/front-end/Images/helpButtonGlyph.png: Removed.
2401         * inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
2402         * inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
2403         * inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
2404         * inspector/front-end/Images/percentButtonGlyph.png: Removed.
2405         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
2406         * inspector/front-end/Images/recordButtonGlyph.png: Removed.
2407         * inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
2408         * inspector/front-end/Images/reloadButtonGlyph.png: Removed.
2409         * inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
2410         * inspector/front-end/Images/undockButtonGlyph.png: Removed.
2411         * inspector/front-end/WebKit.qrc:
2412         * inspector/front-end/inspector.css:
2413         (.status-bar-item > .glyph):
2414         (#dock-status-bar-item .glyph):
2415         (body.detached #dock-status-bar-item .glyph):
2416         (#console-status-bar-item .glyph):
2417         (.clear-status-bar-item .glyph):
2418         (button.enable-toggle-status-bar-item .glyph):
2419         (button.enable-toggle-status-bar-item.toggled-on .glyph):
2420         (.scripts-pause-on-exceptions-status-bar-item .glyph):
2421         (.scripts-toggle-pretty-print-status-bar-item .glyph):
2422         (.toggle-breakpoints .glyph):
2423         (.toggle-breakpoints.toggled-on .glyph):
2424         (.resources-larger-resources-status-bar-item .glyph):
2425         (.timeline-filter-status-bar-item .glyph):
2426         (.garbage-collect-status-bar-item .glyph):
2427         (.record-profile-status-bar-item .glyph):
2428         (.record-profile-status-bar-item.toggled-on .glyph):
2429         (.heap-snapshot-status-bar-item .glyph):
2430         (.node-search-status-bar-item .glyph):
2431         (.percent-time-status-bar-item .glyph):
2432         (.focus-profile-node-status-bar-item .glyph):
2433         (.exclude-profile-node-status-bar-item .glyph):
2434         (.reset-profile-status-bar-item .glyph):
2435         (.delete-storage-status-bar-item .glyph):
2436         (.refresh-storage-status-bar-item .glyph):
2437         * inspector/front-end/inspector.js:
2438
2439 2011-05-02  Simon Fraser  <simon.fraser@apple.com>
2440
2441         Reviewed by Dan Bernstein.
2442
2443         Possible crash when removing elements with reflections
2444         https://bugs.webkit.org/show_bug.cgi?id=60009
2445         
2446         RenderLayer's destructor deleted its z-order list Vector pointers
2447         before removing the reflection layer. However, the reflection cleanup
2448         code could call back into the RenderLayer to dirty z-order lists,
2449         so move reflection cleanup to before z-order vector deletion.
2450         
2451         The test crashes when run manually a few times with MallocScribble enabled,
2452         but I was not able to create a test that crashed reliably.
2453
2454         Test: fast/reflections/remove-reflection-crash.html
2455
2456         * rendering/RenderLayer.cpp:
2457         (WebCore::RenderLayer::~RenderLayer):
2458
2459 2011-05-02  Ian Henderson  <ianh@apple.com>
2460
2461         Reviewed by Dan Bernstein.
2462
2463         CSS !important not respected by JavaScript
2464         https://bugs.webkit.org/show_bug.cgi?id=60007
2465
2466         The addParsedProperty and addParsedProperties methods were subtly
2467         different.  The former did not check for !important before setting the
2468         given property.
2469
2470         Change addParsedProperties to call addParsedProperty and move the
2471         relevant code.  The one other caller of this method, in
2472         editing/markup.cpp, probably wanted this behavior anyway.
2473
2474         Test: fast/css/important-js-override.html
2475
2476         * css/CSSMutableStyleDeclaration.cpp:
2477         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
2478         (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
2479
2480 2011-05-02  Ben Wells  <benwells@chromium.org>
2481
2482         Reviewed by Simon Fraser.
2483
2484         Cleanup variable usage in RenderObject.cpp paintOutline()
2485         https://bugs.webkit.org/show_bug.cgi?id=59911
2486
2487         No new tests for this, there should be no change in behaviour.
2488
2489         * rendering/RenderObject.cpp:
2490         (WebCore::RenderObject::paintOutline):
2491
2492 2011-05-02  Ryosuke Niwa  <rniwa@webkit.org>
2493
2494         Reviewed by James Robinson.
2495
2496         REGRESSION(r84672): showTree doesn't work for input/textarea elements
2497         https://bugs.webkit.org/show_bug.cgi?id=60001
2498
2499         When shadow is null, try retrieving the inner element of a render text control.
2500
2501         * dom/Node.cpp:
2502         (WebCore::traverseTreeAndMark):
2503
2504 2011-05-02  Joseph Pecoraro  <joepeck@webkit.org>
2505
2506         Reviewed by David Kilzer.
2507
2508         Respect fixed text-indent on ::-webkit-input-placeholder
2509         https://bugs.webkit.org/show_bug.cgi?id=59825
2510
2511         Test: fast/forms/input-placeholder-text-indent.html
2512
2513         * rendering/RenderTextControl.cpp:
2514         (WebCore::RenderTextControl::paintPlaceholder): indent by
2515         a fixed text-indent size specified on the placeholder style.
2516
2517 2011-05-02  Eric Uhrhane  <ericu@chromium.org>
2518
2519         Reviewed by Eric Seidel.
2520
2521         Some FileWriter progress events should be queued
2522         https://bugs.webkit.org/show_bug.cgi?id=50846
2523
2524         * fileapi/FileWriter.cpp:
2525         * fileapi/FileWriter.h:
2526         Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.
2527
2528 2011-05-02  Jia Pu  <jpu@apple.com>
2529
2530         Reviewed by Alexey Proskuryakov.
2531
2532         [Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
2533         https://bugs.webkit.org/show_bug.cgi?id=59836
2534         <rdar://problem/9275983>
2535
2536         * platform/DefaultLocalizationStrategy.cpp:
2537         (WebCore::truncatedStringForLookupMenuItem):
2538         (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
2539
2540 2011-05-02  Brady Eidson  <beidson@apple.com>
2541
2542         Reviewed by Anders Carlsson.
2543
2544         <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
2545         In Aperture, a WebView might be dealloc'ed before it finishes loading.
2546
2547         * WebCore.exp.in:
2548         * platform/RuntimeApplicationChecks.cpp:
2549         (WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.
2550         * platform/RuntimeApplicationChecks.h:
2551
2552 2011-05-02  Simon Fraser  <simon.fraser@apple.com>
2553
2554         Reviewed by Dan Bernstein.
2555
2556         Avoid wasted cycles updating paths when popping the context stack
2557         https://bugs.webkit.org/show_bug.cgi?id=59967
2558
2559         CanvasRenderingContext2D has to map the current path through
2560         transforms whenever the context stack is popped, which creates
2561         a lot of platform path objects. Avoid extra work here when the
2562         path is empty, or when the transform is identity.
2563
2564         * platform/graphics/cg/PathCG.cpp:
2565         (WebCore::Path::transform):
2566
2567 2011-05-02  Enrica Casucci  <enrica@apple.com>
2568
2569         Reviewed by Dan Bernstein.
2570
2571         Text does not split on white space when typing to the edge of window.
2572         https://bugs.webkit.org/show_bug.cgi?id=59968
2573         <rdar://problem/9112683>
2574
2575         Test: editing/inserting/typing-at-end-of-line.html
2576
2577         This is a regression introduced when we converted the line box tree to
2578         floating point in r78846. In findNextLineBreak, there was still one place where
2579         the character width was treated as int and truncated and we were inconsistent
2580         in the way we treated a character that did not fit entirely in the line.
2581
2582         * rendering/RenderBlockLineLayout.cpp:
2583         (WebCore::RenderBlock::findNextLineBreak):
2584
2585 2011-04-19  Adrienne Walker  <enne@google.com>
2586
2587         Reviewed by James Robinson.
2588
2589         [chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
2590         https://bugs.webkit.org/show_bug.cgi?id=58907
2591
2592         Additionally, move the context save/restore logic to a place where it
2593         will reset the translation added in LayerTilerChromium.
2594
2595         Test: compositing/repaint/same-size-invalidation.html
2596
2597         * platform/graphics/chromium/ContentLayerChromium.cpp:
2598         (WebCore::ContentLayerPainter::paint):
2599         * platform/graphics/chromium/PlatformCanvas.cpp:
2600         (WebCore::PlatformCanvas::resize):
2601         (WebCore::PlatformCanvas::Painter::Painter):
2602         (WebCore::PlatformCanvas::Painter::~Painter):
2603         * platform/graphics/chromium/PlatformCanvas.h:
2604
2605 2011-05-02  Csaba Osztrogonác  <ossy@webkit.org>
2606
2607         Enable strict OwnPtr for Qt
2608         https://bugs.webkit.org/show_bug.cgi?id=59667
2609
2610         Unreviewed buildfix after r85343.
2611
2612         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2613         (WebCore::GraphicsContext3D::GraphicsContext3D):
2614
2615 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2616
2617         Unreviewed, rolling out r85483.
2618         http://trac.webkit.org/changeset/85483
2619         https://bugs.webkit.org/show_bug.cgi?id=59958
2620
2621         Causes media test failures. (Requested by eric_carlson on
2622         #webkit).
2623
2624         * html/HTMLMediaElement.cpp:
2625         (WebCore::HTMLMediaElement::HTMLMediaElement):
2626         (WebCore::HTMLMediaElement::prepareForLoad):
2627         (WebCore::HTMLMediaElement::seek):
2628         (WebCore::HTMLMediaElement::updatePlayState):
2629         * html/HTMLMediaElement.h:
2630         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2631         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
2632         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad):
2633         (WebCore::MediaPlayerPrivateAVFoundation::load):
2634         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay):
2635         (WebCore::MediaPlayerPrivateAVFoundation::paint):
2636         (WebCore::MediaPlayerPrivateAVFoundation::duration):
2637         (WebCore::MediaPlayerPrivateAVFoundation::seeking):
2638         (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
2639         (WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame):
2640         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):
2641         (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged):
2642         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
2643         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
2644         (WebCore::MediaPlayerPrivateAVFoundation::repaint):
2645         (WebCore::MediaPlayerPrivateAVFoundation::setPreload):
2646         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2647         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2648         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2649         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
2650         (WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay):
2651         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL):
2652         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource):
2653         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
2654         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata):
2655         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
2656         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
2657         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus):
2658         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
2659         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
2660         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
2661
2662 2011-05-02  Adam Barth  <abarth@webkit.org>
2663
2664         Reviewed by David Levin.
2665
2666         PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
2667         https://bugs.webkit.org/show_bug.cgi?id=59924
2668
2669         * css/CSSGrammar.y:
2670         * platform/graphics/mac/SimpleFontDataMac.mm:
2671             - Memory management for the font cache is somewhat... complext.
2672               This will require some careful thought to sort out.
2673
2674 2011-05-02  Levi Weintraub  <leviw@chromium.org>
2675
2676         Reviewed by Eric Seidel.
2677
2678         showLineTree/showLineTreeForThis would make working with the line box tree easier
2679         https://bugs.webkit.org/show_bug.cgi?id=59662
2680
2681         Adding a showLineTree/showLineTreeForThis method to help visualize and debug
2682         the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.
2683
2684         No new tests since this is a debugging feature only and not compiled in release.
2685
2686         * rendering/InlineBox.cpp:
2687         (WebCore::InlineBox::showLineTreeForThis):
2688         (WebCore::InlineBox::showLineTreeAndMark):
2689         (WebCore::InlineBox::showBox):
2690         (showLineTree):
2691         * rendering/InlineBox.h:
2692         * rendering/InlineFlowBox.cpp:
2693         (WebCore::InlineFlowBox::showLineTreeAndMark):
2694         * rendering/InlineFlowBox.h:
2695         * rendering/InlineTextBox.cpp:
2696         (WebCore::InlineTextBox::showBox):
2697         * rendering/InlineTextBox.h:
2698         * rendering/RenderBlock.cpp:
2699         (WebCore::RenderBlock::showLineTreeAndMark):
2700         * rendering/RenderBlock.h:
2701         * rendering/RenderObject.cpp:
2702         (WebCore::RenderObject::showRenderTreeForThis):
2703         (WebCore::RenderObject::showLineTreeForThis):
2704         (showTree):
2705         (showLineTree):
2706         * rendering/RenderObject.h:
2707
2708 2011-05-02  Dimitri Glazkov  <dglazkov@chromium.org>
2709
2710         Reviewed by Eric Carlson.
2711
2712         REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
2713         https://bugs.webkit.org/show_bug.cgi?id=59917
2714
2715         Since default event handlers are not retargeted, we should always attempt ancestor
2716         traversal to find out whether the event.
2717
2718         * html/MediaDocument.cpp:
2719         (WebCore::ancestorVideoElement): Added ancestor-traversing helper.
2720         (WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.
2721
2722 2011-05-02  Sam Weinig  <sam@webkit.org>
2723
2724         Attempt to fix the Leopard build.
2725
2726         * platform/graphics/FontPlatformData.h:
2727         * platform/graphics/mac/ComplexTextController.h:
2728         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
2729         * platform/mac/WebCoreSystemInterface.h:
2730
2731 2011-05-02  Tony Chang  <tony@chromium.org>
2732
2733         Reviewed by Kent Tamura.
2734
2735         convert manual-tests/bugzilla-6821.html to a layout test
2736         https://bugs.webkit.org/show_bug.cgi?id=59404
2737
2738         Test: fast/css/hover-update.html
2739
2740         * manual-tests/bugzilla-6821.html: Removed.
2741
2742 2011-05-02  Sam Weinig  <sam@webkit.org>
2743
2744         Reviewed by Anders Carlsson.
2745
2746         Prune ApplicationServices.h out of the headers
2747         https://bugs.webkit.org/show_bug.cgi?id=59952
2748
2749         More forward declares are better.
2750
2751         * html/canvas/CanvasRenderingContext2D.cpp:
2752         * html/canvas/CanvasRenderingContext2D.h:
2753         * platform/graphics/GlyphBuffer.h:
2754         * platform/graphics/cg/ImageBufferCG.cpp:
2755         * platform/graphics/cg/PDFDocumentImage.cpp:
2756         * platform/graphics/cg/PDFDocumentImage.h:
2757         * platform/graphics/mac/ComplexTextController.h:
2758         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
2759         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
2760         * platform/mac/ScrollAnimatorMac.h:
2761         * platform/mac/ScrollAnimatorMac.mm:
2762         * platform/mac/ScrollbarThemeMac.h:
2763         * platform/mac/ScrollbarThemeMac.mm:
2764         * platform/mac/WebCoreNSStringExtras.h:
2765         * platform/mac/WebCoreSystemInterface.h:
2766
2767 2011-05-02  Dan Bernstein  <mitz@apple.com>
2768
2769         Reviewed by Simon Fraser.
2770
2771         <rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables
2772         https://bugs.webkit.org/show_bug.cgi?id=58006
2773
2774         * rendering/RenderBox.cpp:
2775         (WebCore::RenderBox::computeReplacedLogicalHeightUsing): Expanded the scope of the fix for
2776         <http://webkit.org/b/15359> from r29039 to cover not just the case of a auto-or-percent-height
2777         table cell as the immediate containing block, but any case where all containing block ancestors
2778         up to and including a table cell are auto-or-percent height.
2779
2780 2011-05-02  Daniel Bates  <dbates@webkit.org>
2781
2782         Reviewed by Sam Weinig.
2783
2784         Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
2785         https://bugs.webkit.org/show_bug.cgi?id=59379
2786
2787         Move manual test onblur-remove.html to LayoutTests/fast/events.
2788
2789         Test: fast/events/onblur-remove.html
2790
2791         * manual-tests/onblur-remove.html: Removed.
2792
2793 2011-05-02  Sailesh Agrawal  <sail@chromium.org>
2794
2795         Reviewed by Dimitri Glazkov.
2796
2797         Chromium Mac: Add scrollbar overlay drawing functions
2798         https://bugs.webkit.org/show_bug.cgi?id=59741
2799
2800         These functions are simply copied from WebCoreSystemInterface. These will be used to implement overlay scrollbars for Chromium Mac.
2801
2802         No new tests, since this code is only enabled on future versions of Mac OS X.
2803
2804         * WebCore.gypi:
2805         * platform/chromium/ScrollbarOverlayUtilitiesMac.h: Added.
2806         * platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Added.
2807         (LookUpNSScrollerImpClass):
2808         (LookUpNSScrollerImpPairClass):
2809         (ScrollbarControlSizeToNSControlSize):
2810         (wkScrollbarPainterUsesOverlayScrollers):
2811         (wkScrollbarPainterIsHorizontal):
2812         (wkScrollbarPainterKnobAlpha):
2813         (wkScrollbarPainterSetOverlayState):
2814         (wkScrollbarPainterPaint):
2815         (wkScrollbarMinimumThumbLength):
2816         (wkScrollbarPainterSetDelegate):
2817         (wkScrollbarPainterTrackAlpha):
2818         (wkMakeScrollbarPainter):
2819         (wkScrollbarThickness):
2820         (wkScrollbarMinimumTotalLengthNeededForThumb):
2821         (wkVerticalScrollbarPainterForController):
2822         (wkHorizontalScrollbarPainterForController):
2823         (wkMakeScrollbarReplacementPainter):
2824         (wkSetPainterForPainterController):
2825         (wkSetScrollbarPainterControllerStyle):
2826         (wkScrollbarPainterKnobRect):
2827         (wkSetScrollbarPainterKnobAlpha):
2828         (wkSetScrollbarPainterTrackAlpha):
2829         (wkSetScrollbarPainterKnobStyle):
2830         (wkMakeScrollbarPainterController):
2831         (wkContentAreaScrolled):
2832         (wkContentAreaWillPaint):
2833         (wkMouseEnteredContentArea):
2834         (wkMouseExitedContentArea):
2835         (wkMouseMovedInContentArea):
2836         (wkWillStartLiveResize):
2837         (wkContentAreaResized):
2838         (wkWillEndLiveResize):
2839         (wkContentAreaDidShow):
2840         (wkContentAreaDidHide):
2841         (wkDidBeginScrollGesture):
2842         (wkDidEndScrollGesture):
2843         (wkScrollbarPainterForceFlashScrollers):
2844         (IsScrollbarOverlayAPIAvailable):
2845
2846 2011-05-02  Luke Macpherson   <macpherson@chromium.org>
2847
2848         Reviewed by Dimitri Glazkov.
2849
2850         Implement Length based CSS properties in CSSStyleApplyProperty
2851         https://bugs.webkit.org/show_bug.cgi?id=59314
2852
2853         No new tests as no functionality changed.
2854
2855         * css/CSSStyleApplyProperty.cpp:
2856         (WebCore::ApplyPropertyLength::ApplyPropertyLength):
2857         Added this class to handle all length types.
2858         Property specific behavior is handled through set of boolean parameters.
2859         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2860         Added calls to set up entries for the newly added length properties.
2861         * css/CSSStyleSelector.cpp:
2862         (WebCore::CSSStyleSelector::applyProperty):
2863         Remove property implementations mow implemented in CSSStyleApplyProperty.
2864         * css/CSSStyleSelector.h:
2865         (WebCore::CSSStyleSelector::rootElementStyle):
2866         Expose m_rootElementStyle via getter.
2867
2868 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
2869
2870         Reviewed by Eric Seidel.
2871
2872         HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
2873         https://bugs.webkit.org/show_bug.cgi?id=59828
2874
2875         No new tests required, no functional change because seeking to time zero before playback
2876         begins has no effect.
2877
2878         * html/HTMLMediaElement.cpp:
2879         (WebCore::HTMLMediaElement::setReadyState): Don't seek to time 0 when readyState reaches
2880             HAVE_METADATA.
2881
2882 2011-05-02  Sam Weinig  <sam@webkit.org>
2883
2884         Reviewed by Gavin Barraclough.
2885
2886         Fix extra whitespace in license in FocusDirection.h.
2887
2888         * page/FocusDirection.h:
2889
2890 2011-05-02  Sam Weinig  <sam@webkit.org>
2891
2892         Reviewed by Adam Barth.
2893
2894         Prune some #includes from DOMWindow.h
2895         https://bugs.webkit.org/show_bug.cgi?id=59907
2896
2897         * page/DOMWindow.cpp:
2898         (WebCore::DOMWindow::setSecurityOrigin):
2899         * page/DOMWindow.h:
2900         Remove #includes of SecurityOrigin and MessagePort by forward declaring
2901         and moving the SecurityOrigin setter to the .cpp file. Also adds EventTarget
2902         #include that was getting added by MessagePort.h.
2903
2904         * bindings/js/JSCustomVoidCallback.cpp:
2905         * bindings/js/JSCustomXPathNSResolver.cpp:
2906         * bindings/js/JSDOMWindowCustom.h:
2907         * bindings/js/JSHistoryCustom.cpp:
2908         * bindings/js/ScriptController.h:
2909         * html/HTMLAnchorElement.cpp:
2910         * html/HTMLMediaElement.cpp:
2911         * html/parser/XSSFilter.cpp:
2912         * inspector/InspectorDOMStorageResource.cpp:
2913         * loader/MainResourceLoader.cpp:
2914         * page/DragController.cpp:
2915         * page/EventSource.cpp:
2916         * page/Location.cpp:
2917         * websockets/WebSocket.cpp:
2918         * xml/XSLTProcessorLibxslt.cpp:
2919         Add now missing SecurityOrigin.h #includes.
2920
2921 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
2922
2923         Reviewed by Brady Eidson.
2924
2925         The preload attribute of the video tag is not completely implemented
2926         https://bugs.webkit.org/show_bug.cgi?id=43673
2927         <rdar://problem/7508322>
2928
2929         Tested manually with manual-tests/media-elements/video-preload.html.
2930
2931         * html/HTMLMediaElement.cpp:
2932         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
2933         (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
2934         (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
2935         (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'metadata'
2936             because we need to have media data loaded to seek.
2937         (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
2938         * html/HTMLMediaElement.h:
2939
2940         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2941         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):  Remove 
2942             m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
2943         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
2944         (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn. 
2945             Move all preload logic to setPreload, call it from here.
2946         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to 
2947             setPreload, call it.
2948         (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
2949             unlikely to be correct and isn't worth caching.
2950         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
2951             to AssetStatus. Create the AVPlayer once we know an asset is playable but preload is
2952             'metadata'. Set networkState to 'idle' when the playback buffer is full because that is
2953             a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA' 
2954             when the first frame is available.
2955         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
2956             width, height, hasVideo, etc.
2957         (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
2958             in derived classes.
2959         (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
2960             AVAsset and AVPlayerItem here.
2961         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2962
2963         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2964         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2965         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
2966             m_videoFrameHasDrawn.
2967         (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
2968             videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
2969             if we have painted a frame to the context.
2970         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
2971             if necessary.
2972         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
2973         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
2974         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
2975         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
2976         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
2977             the buffer is full.
2978         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
2979             AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
2980             when we only have metadata.
2981         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
2982         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
2983         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
2984             when when we haven't allocated the AVPlayerItem yet so that we can report attributes
2985             when we only have metadata.
2986         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
2987             we have allocated the AVPlayerItem.
2988
2989 2011-05-02  Philippe Normand  <pnormand@igalia.com>
2990
2991         Reviewed by Martin Robinson.
2992
2993         [GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24
2994         https://bugs.webkit.org/show_bug.cgi?id=59932
2995
2996         Use gdk_window_get_width() and gdk_window_get_height() if
2997         available, instead of the deprecated gdk_drawable_get_size().
2998
2999         No new tests, build fix only.
3000
3001         * platform/gtk/WidgetRenderingContext.cpp:
3002         (WebCore::WidgetRenderingContext::WidgetRenderingContext):
3003
3004 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
3005
3006         Reviewed by Brady Eidson.
3007
3008         The preload attribute of the video tag is not completely implemented
3009         https://bugs.webkit.org/show_bug.cgi?id=43673
3010         <rdar://problem/7508322>
3011
3012         Test manually with manual-tests/media-elements/video-preload.html.
3013
3014         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
3015         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
3016         (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"
3017             attribute when preload is not "auto".
3018         (WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
3019         (WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
3020         (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
3021         (WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have
3022             a QTMovie.
3023
3024 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
3025
3026         Reviewed by Brady Eidson.
3027
3028         The preload attribute of the video tag is not completely implemented
3029         https://bugs.webkit.org/show_bug.cgi?id=43673
3030         <rdar://problem/7508322>
3031
3032         Manual test manual-tests/media-elements/video-preload.html added.
3033
3034         * manual-tests/media-elements/video-preload.html: Added. New manual test for media element 
3035             'preload' attribute because it is not possible to detect if a media engine supports 
3036             "preload=metadata" in a way that lets us have per-platform layout test results.
3037
3038 2011-05-01  Abhishek Arya  <inferno@chromium.org>
3039
3040         Reviewed by Eric Carlson.
3041
3042         Regression(r74787): Media document mouse click and double-click
3043         events should be checked on target node only and not its descendants.
3044         https://bugs.webkit.org/show_bug.cgi?id=59886
3045
3046         * html/MediaDocument.cpp:
3047         (WebCore::MediaDocument::defaultEventHandler):
3048
3049 2011-05-01  Adam Barth  <abarth@webkit.org>
3050
3051         Reviewed by Eric Seidel.
3052
3053         Polish CSP host and port matching
3054         https://bugs.webkit.org/show_bug.cgi?id=59899
3055
3056         Finish last two details of host and port matching.  I don't think the
3057         default port handling is testable with our current testing
3058         infrastructure.
3059
3060         Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html
3061                http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html
3062
3063         * page/ContentSecurityPolicy.cpp:
3064         (WebCore::CSPSource::hostMatches):
3065         (WebCore::CSPSource::portMatches):
3066
3067 2011-05-01  Adam Barth  <abarth@webkit.org>
3068
3069         Reviewed by Eric Seidel.
3070
3071         CSP default-src is missing
3072         https://bugs.webkit.org/show_bug.cgi?id=58641
3073
3074         Add support for default-src.  The default-src provides a default policy
3075         for every directive that sends in "-src".  If the more-specific
3076         directive is present, it takes precedence.  I also took this
3077         opportunity to refactor the internals of ContentSecurityPolicy a bit to
3078         reduce duplicate code.
3079
3080         Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html
3081                http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
3082                http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html
3083
3084         * page/ContentSecurityPolicy.cpp:
3085         (WebCore::ContentSecurityPolicy::didReceiveHeader):
3086         (WebCore::ContentSecurityPolicy::checkEval):
3087         (WebCore::ContentSecurityPolicy::operativeDirective):
3088         (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
3089         (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
3090         (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
3091         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
3092         (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
3093         (WebCore::ContentSecurityPolicy::allowInlineScript):
3094         (WebCore::ContentSecurityPolicy::allowInlineStyle):
3095         (WebCore::ContentSecurityPolicy::allowEval):
3096         (WebCore::ContentSecurityPolicy::allowScriptFromSource):
3097         (WebCore::ContentSecurityPolicy::allowObjectFromSource):
3098         (WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
3099         (WebCore::ContentSecurityPolicy::allowImageFromSource):
3100         (WebCore::ContentSecurityPolicy::allowStyleFromSource):
3101         (WebCore::ContentSecurityPolicy::allowFontFromSource):
3102         (WebCore::ContentSecurityPolicy::allowMediaFromSource):
3103         (WebCore::ContentSecurityPolicy::addDirective):
3104         * page/ContentSecurityPolicy.h:
3105
3106 2011-05-01  Sam Weinig  <sam@webkit.org>
3107
3108         Reviewed by Anders Carlsson.
3109
3110         Prune some unnecessary #includes
3111         https://bugs.webkit.org/show_bug.cgi?id=59895
3112
3113         Start getting rid of unnecessary #includes and forward declares.
3114
3115         * bindings/js/JSDOMBinding.h:
3116         * bindings/js/JSDOMWindowBase.h:
3117         * bindings/js/JSDOMWindowShell.h:
3118         * bindings/js/ScheduledAction.cpp:
3119         * bindings/js/ScriptController.cpp:
3120         * bindings/js/ScriptController.h:
3121         * bindings/js/ScriptDebugServer.cpp:
3122         * editing/Editor.h:
3123         * inspector/InspectorClient.cpp:
3124         * loader/FrameLoader.h:
3125         * loader/NavigationScheduler.h:
3126         * page/Console.cpp:
3127         * xml/XMLTreeViewer.cpp:
3128         * xml/XMLTreeViewer.h:
3129
3130 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3131
3132         [WIN] Unreviewed buildfix after r85434.
3133
3134         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3135         (WebCore::MediaPlayerPrivate::createLayerForMovie):
3136
3137 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3138
3139         [WIN] Unreviewed buildfix after r85434.
3140
3141         * platform/graphics/win/QTMovieVisualContext.cpp:
3142         (QTMovieVisualContext::QTMovieVisualContext): Added missing header.
3143
3144 2011-05-01  Justin Schuh  <jschuh@chromium.org>
3145
3146         Reviewed by Adam Barth.
3147
3148         History::stateObjectAdded should check origin via SecurityOrigin::canRequest
3149         https://bugs.webkit.org/show_bug.cgi?id=59840
3150
3151         Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html
3152                http/tests/navigation/replacestate-base-illegal.html
3153                http/tests/navigation/replacestate-base-legal.html
3154
3155         * page/History.cpp:
3156         (WebCore::History::stateObjectAdded):
3157
3158 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3159
3160         [WIN] Unreviewed buildfix after r85434.
3161
3162         * platform/graphics/win/QTMovieVisualContext.cpp:
3163         (QTMovieVisualContext::QTMovieVisualContext):
3164
3165 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3166
3167         Reviewed by Adam Barth.
3168
3169         [WINCE] Fix OwnPtr strict issues
3170         https://bugs.webkit.org/show_bug.cgi?id=59898
3171
3172         * page/wince/FrameWinCE.cpp:
3173         (WebCore::imageFromSelection):
3174         * platform/graphics/wince/FontPlatformData.cpp:
3175         (WebCore::FixedSizeFontData::create):
3176         (WebCore::FontPlatformPrivateData::FontPlatformData::hfont):
3177         (WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle):
3178         (WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
3179         * platform/graphics/wince/GraphicsContextWinCE.cpp:
3180         (WebCore::GraphicsContext::strokeArc):
3181         (WebCore::GraphicsContext::fillRect):
3182         (WebCore::GraphicsContext::clip):
3183         (WebCore::GraphicsContext::fillRoundedRect):
3184         (WebCore::GraphicsContext::drawRoundCorner):
3185         (WebCore::GraphicsContext::drawText):
3186         * platform/graphics/wince/ImageBufferWinCE.cpp:
3187         (WebCore::ImageBuffer::ImageBuffer):
3188         * platform/graphics/wince/ImageWinCE.cpp:
3189         (WebCore::BitmapImage::getHBITMAPOfSize):
3190         * platform/graphics/wince/SharedBitmap.cpp:
3191         (WebCore::SharedBitmap::SharedBitmap):
3192
3193 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
3194
3195         Reviewed by Eric Seidel.
3196
3197         Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
3198         https://bugs.webkit.org/show_bug.cgi?id=59837
3199
3200         Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)
3201
3202         * WebCore.exp.in:
3203         * page/EventHandler.h:
3204         * page/mac/EventHandlerMac.mm:
3205
3206 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
3207
3208         Reviewed by Eric Seidel.
3209
3210         Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
3211         https://bugs.webkit.org/show_bug.cgi?id=59835
3212
3213         Moved currentKeyboardEvent.
3214
3215         * WebCore.exp.in:
3216         * page/EventHandler.h:
3217         * page/mac/EventHandlerMac.mm:
3218
3219 2011-05-01  ojab  <ojab@ojab.ru>
3220
3221         Reviewed by Eric Seidel.
3222
3223         Fix build with --disable-video --enable-fullscreen-api
3224         https://bugs.webkit.org/show_bug.cgi?id=59698
3225
3226         * rendering/RenderTheme.h:
3227         (WebCore::RenderTheme::extraFullScreenStyleSheet):
3228
3229 2011-05-01  Jeff Timanus  <twiz@chromium.org>
3230
3231         Reviewed by Eric Seidel.
3232
3233         Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
3234         https://bugs.webkit.org/show_bug.cgi?id=59041
3235
3236         Test:css2.1/t140201-c533-bgimage-00-a.html
3237
3238         * platform/graphics/Image.cpp:
3239         (WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
3240         * platform/graphics/skia/ImageSkia.cpp:
3241         (WebCore::BitmapImage::checkForSolidColor):
3242
3243 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3244
3245         Reviewed by Adam Barth.
3246
3247         Fix OwnPtr strict issues in windows build
3248         https://bugs.webkit.org/show_bug.cgi?id=59878
3249
3250         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
3251         (WebCore::getDirtyRects):
3252         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3253         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
3254         * platform/graphics/win/WKCAImageQueue.cpp:
3255         (WebCore::WKCAImageQueue::WKCAImageQueue):
3256         * platform/win/CursorWin.cpp:
3257         (WebCore::createSharedCursor):
3258         * platform/win/PasteboardWin.cpp:
3259         (WebCore::Pasteboard::writeImage):
3260
3261 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3262
3263         Reviewed by Eric Seidel.
3264
3265         Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
3266         https://bugs.webkit.org/show_bug.cgi?id=59876
3267
3268         Also pass the size "as reference" instead of "as value".
3269
3270         * platform/graphics/GraphicsContext.h:
3271         * platform/graphics/win/FontCGWin.cpp:
3272         (WebCore::drawGDIGlyphs):
3273         * platform/graphics/win/GraphicsContextWin.cpp:
3274         (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap):
3275         (WebCore::GraphicsContext::createWindowsBitmap):
3276         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3277         (WebCore::MediaPlayerPrivate::paint):
3278
3279 2011-05-01  Emil A Eklund  <eae@chromium.org>
3280
3281         Reviewed by Eric Seidel.
3282
3283         getComputedStyle() returns unitless values for some properties that require units
3284         https://bugs.webkit.org/show_bug.cgi?id=55111
3285
3286         Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective
3287
3288         Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html
3289
3290         * css/CSSComputedStyleDeclaration.cpp:
3291         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3292
3293 2011-05-01  Young Han Lee  <joybro@company100.net>
3294
3295         Reviewed by Eric Seidel.
3296
3297         Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
3298         https://bugs.webkit.org/show_bug.cgi?id=59608
3299
3300         TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h
3301
3302         No new functionality, no new tests.
3303
3304         * platform/graphics/opengl/TextureMapperGL.cpp:
3305         (WebCore::TextureMapperGL::TextureMapperGL):
3306
3307 2011-05-01  Yael Aharon  <yael.aharon@nokia.com>
3308
3309         Reviewed by Eric Seidel.
3310
3311         CSS3 nth-child(n) selector fails
3312         https://bugs.webkit.org/show_bug.cgi?id=56943
3313
3314         Regression from r75158.
3315         "n" is a valid parameter to nth() and should be allowed.
3316
3317         Test: fast/css/nth-child-n.html
3318
3319         * css/CSSParser.cpp:
3320         (WebCore::isValidNthToken):
3321
3322 2011-05-01  Pavel Feldman  <pfeldman@chromium.org>
3323
3324         Not reviewed: address stack frame scriptName -> url rename in timeline panel.
3325
3326         * inspector/front-end/TimelinePanel.js:
3327         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
3328         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
3329
3330 2011-05-01  Chris Fleizach  <cfleizach@apple.com>
3331
3332         Reviewed by Maciej Stachowiak.
3333
3334         Crash in AccessibilityRenderObject while viewing PDFs in iframes
3335         https://bugs.webkit.org/show_bug.cgi?id=59629
3336
3337         Could not reproduce this crash, but it's quite clear how it could happen.
3338  
3339         * accessibility/AccessibilityRenderObject.cpp:
3340         (WebCore::AccessibilityRenderObject::accessibilityHitTest):
3341
3342 2011-05-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3343
3344         Reviewed by Dirk Schulze.
3345
3346         LEAK: SVGElement leaks when detaching it in a pending resource state
3347         https://bugs.webkit.org/show_bug.cgi?id=59072
3348
3349         Make the pending resources set non-refcounted again. We made it refcounted a while ago
3350         to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
3351         Fix the underlying problem, by removing all pending resources referencing to a particular
3352         SVGElement, upon its destruction or upon removing it from the document.
3353
3354         Example: <rect fill="url(#foo)" id="rect">
3355         When we try to render the rect, the foo paint server can't be found and thus "foo" will be
3356         added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
3357         itself from the pending resource set, and a ref count to the "rect" would be released.
3358         If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
3359         it and the associated document alive.
3360
3361         Tests: svg/custom/pending-resource-leak-2.svg
3362                svg/custom/pending-resource-leak-3.svg
3363                svg/custom/pending-resource-leak.svg
3364
3365         These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
3366         I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.
3367
3368         * rendering/svg/RenderSVGResourceContainer.cpp:
3369         (WebCore::RenderSVGResourceContainer::registerResource):
3370         * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
3371         (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
3372         * rendering/svg/SVGResources.cpp:
3373         (WebCore::registerPendingResource):
3374         * svg/SVGDocumentExtensions.cpp:
3375         (WebCore::SVGDocumentExtensions::addPendingResource):
3376         (WebCore::SVGDocumentExtensions::hasPendingResources):
3377         (WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
3378         (WebCore::SVGDocumentExtensions::removePendingResource):
3379         * svg/SVGDocumentExtensions.h:
3380         * svg/SVGElement.cpp:
3381         * svg/SVGElement.h:
3382         * svg/SVGElementRareData.h:
3383         (WebCore::SVGElementRareData::SVGElementRareData):
3384         (WebCore::SVGElementRareData::hasPendingResources):
3385         (WebCore::SVGElementRareData::setHasPendingResources):
3386         * svg/SVGStyledElement.cpp:
3387         (WebCore::SVGStyledElement::~SVGStyledElement):
3388         (WebCore::SVGStyledElement::insertedIntoDocument):
3389         (WebCore::SVGStyledElement::removedFromDocument):
3390         (WebCore::SVGStyledElement::hasPendingResources):
3391         (WebCore::SVGStyledElement::setHasPendingResources):
3392         * svg/SVGStyledElement.h:
3393         (WebCore::SVGStyledElement::needsPendingResourceHandling):
3394         (WebCore::SVGStyledElement::buildPendingResource):
3395         * svg/SVGUseElement.cpp:
3396         (WebCore::SVGUseElement::SVGUseElement):
3397         (WebCore::SVGUseElement::insertedIntoDocument):
3398         (WebCore::SVGUseElement::svgAttributeChanged):
3399         (WebCore::SVGUseElement::buildPendingResource):
3400         * svg/SVGUseElement.h:
3401
3402 2011-05-01  Rafael Brandao  <rafael.lobo@openbossa.org>
3403
3404         Reviewed by Csaba Osztrogonác.
3405
3406         [Qt] build-webkit warning Inspector.idl is missing
3407         https://bugs.webkit.org/show_bug.cgi?id=59047
3408         
3409         Added variable_out to pipe output from one compiler to another,
3410         and then forced the output to be added to the sources.
3411
3412         * CodeGenerators.pri:
3413
3414 2011-05-01  Dan Bernstein  <mitz@apple.com>
3415
3416         Reviewed by Anders Carlsson.
3417
3418         <rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight
3419         https://bugs.webkit.org/show_bug.cgi?id=56658
3420
3421         Test: fast/text/selection-rect-rounding.html
3422
3423         * platform/graphics/FontFastPath.cpp:
3424         (WebCore::Font::selectionRectForSimpleText): Account for non-integral anchor point coordinates.
3425         * platform/graphics/mac/FontComplexTextMac.cpp:
3426         (WebCore::Font::selectionRectForComplexText): Ditto.
3427         * rendering/InlineTextBox.cpp:
3428         (WebCore::InlineTextBox::selectionRect): Floor the horizontal sides of the clip rect.
3429         (WebCore::InlineTextBox::paintSelection): Pass the logical left location to Font::selectionRectForText(),
3430         since it affects rounding.
3431
3432 2011-04-30  Justin Schuh  <jschuh@chromium.org>
3433
3434         Reviewed by Dirk Schulze.
3435
3436         Make RenderSVGResourceFilter take ownership of filter data when painting
3437         https://bugs.webkit.org/show_bug.cgi?id=51524
3438
3439         Test: svg/custom/filter-on-svgimage.svg
3440
3441         * rendering/svg/RenderSVGResourceFilter.cpp:
3442         (WebCore::RenderSVGResourceFilter::removeClientFromCache):
3443         (WebCore::RenderSVGResourceFilter::postApplyResource):
3444         * rendering/svg/RenderSVGResourceFilter.h:
3445         (WebCore::FilterData::FilterData):
3446
3447 2011-04-30  Martin Robinson  <mrobinson@igalia.com>
3448
3449         Reviewed by Adam Barth.
3450
3451         Enable strict mode for OwnPtr and PassOwnPtr
3452         https://bugs.webkit.org/show_bug.cgi?id=59428
3453
3454         Fix assignments and .set() calls with OwnPtr to use adoptPtr. Have GeolocationService
3455         factory methods return a PassOwnPtr.
3456
3457         No new tests. This should not change functionality.
3458
3459         * platform/GeolocationService.cpp:
3460         (WebCore::createGeolocationServiceNull):
3461         (WebCore::GeolocationService::create):
3462         * platform/GeolocationService.h:
3463         * platform/android/GeolocationServiceAndroid.cpp:
3464         (WebCore::GeolocationServiceAndroid::create):
3465         * platform/android/GeolocationServiceAndroid.h:
3466         * platform/efl/GeolocationServiceEfl.cpp:
3467         (WebCore::GeolocationServiceEfl::create):
3468         * platform/efl/GeolocationServiceEfl.h:
3469         * platform/graphics/cairo/CairoUtilities.cpp:
3470         (WebCore::appendPathToCairoContext):
3471         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3472         (WebCore::drawPathShadow):
3473         (WebCore::GraphicsContext::clip):
3474         * platform/graphics/cairo/ImageBufferCairo.cpp:
3475         (WebCore::ImageBuffer::ImageBuffer):
3476         * platform/graphics/cairo/OwnPtrCairo.h:
3477         * platform/graphics/cairo/PathCairo.cpp:
3478         (WebCore::Path::Path):
3479         (WebCore::Path::operator=):
3480         (WebCore::Path::apply):
3481         * platform/gtk/GeolocationServiceGtk.cpp:
3482         (WebCore::GeolocationServiceGtk::create):
3483         * platform/gtk/GeolocationServiceGtk.h:
3484         * platform/mock/GeolocationServiceMock.cpp:
3485         (WebCore::GeolocationServiceMock::create):
3486         * platform/mock/GeolocationServiceMock.h:
3487
3488 2011-04-30  Pavel Feldman  <pfeldman@chromium.org>
3489
3490         Not reviewed: inspector toolbar titles were 2px off.
3491
3492         * inspector/front-end/inspector.css:
3493         (#toolbar-dropdown .toolbar-label):
3494
3495 2011-04-30  Mihai Parparita  <mihaip@chromium.org>
3496