1 2013-03-04 Andrey Lushnikov <lushnikov@chromium.org>
3 Web Inspector: add runtime flag to determine if inspector's source files were flattened.
4 https://bugs.webkit.org/show_bug.cgi?id=111184
6 Reviewed by Pavel Feldman.
8 - Add a file "buildSystemOnly.js" which will be included into
9 devtools.html only by GYP build system. This script sets a single flag
10 which essentially means that inspector source files were run
11 through a build system and flattened.
12 - Update "importScript" and "registerRequiredCSS" functions to correct
13 paths according to the "flattenImports" flag.
15 No new tests: no change in behaviour.
18 * inspector/front-end/CodeMirrorTextEditor.js:
19 (WebInspector.CodeMirrorTextEditor):
20 * inspector/front-end/View.js:
21 (WebInspector.View.prototype.registerRequiredCSS):
22 * inspector/front-end/buildSystemOnly.js: Added.
23 * inspector/front-end/utilities.js:
25 2013-03-04 Vsevolod Vlasov <vsevik@chromium.org>
27 Web Inspector: Fix front-end compilation
28 https://bugs.webkit.org/show_bug.cgi?id=111286
30 Reviewed by Alexander Pavlov.
32 * inspector/InjectedScriptSource.js:
33 * inspector/front-end/FileSystemProjectDelegate.js:
34 * inspector/front-end/NavigatorView.js:
35 (WebInspector.NavigatorView.prototype.removeUISourceCode):
36 (WebInspector.NavigatorTreeNode.prototype.reset):
37 (WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
39 2013-03-03 Kondapally Kalyan <kalyan.kondapally@intel.com>
41 [EFL][WebGL] Add proper checks to enable GraphicsSurface usage on EGL without XCompositeWindow.
42 https://bugs.webkit.org/show_bug.cgi?id=108034
44 Reviewed by Laszlo Gombos.
46 Covered by existing WebGL tests.
48 Currently, we set GRAPHICS_SURFACE to true if support for XCompositeWindow
49 is identified during compile time. This is ok, when using GLX. We might not
50 have support for XCompositeWindow when using EGL and GLES2.0. This patch
51 makes changes so that GRAPHICS_SURFACE is always enabled with EGL and adds
52 GLX guard to the parts of code dependent on XCompositeWindow support.
54 * platform/graphics/opengl/GLPlatformSurface.cpp:
55 * platform/graphics/surfaces/glx/GLXConfigSelector.h:
56 (WebCore::GLXConfigSelector::findMatchingConfig):
57 * platform/graphics/surfaces/glx/X11Helper.cpp:
58 (WebCore::X11Helper::createOffScreenWindow):
59 (WebCore::X11Helper::isXRenderExtensionSupported):
60 * platform/graphics/surfaces/glx/X11Helper.h:
62 2013-03-03 Alexander Pavlov <apavlov@chromium.org>
64 Web Inspector: [PageAgent] can't find frame by security origin.
65 https://bugs.webkit.org/show_bug.cgi?id=110849
67 Use toRawString() in order to compare Frames' SecurityOrigins for storage-related goals.
69 Reviewed by Vsevolod Vlasov.
71 * inspector/InspectorPageAgent.cpp:
72 (WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
74 2013-03-03 Alexander Pavlov <apavlov@chromium.org>
76 Unreviewed, rolling out r144455.
77 http://trac.webkit.org/changeset/144455
78 https://bugs.webkit.org/show_bug.cgi?id=111165
80 A simpler solution to the SecurityOrigin -> localStorage
83 * inspector/front-end/DOMStorage.js:
84 (WebInspector.DOMStorage.storageId):
85 (WebInspector.DOMStorage.prototype.get id):
86 (WebInspector.DOMStorage.prototype.getItems):
87 (WebInspector.DOMStorage.prototype.setItem):
88 (WebInspector.DOMStorage.prototype.removeItem):
89 (WebInspector.DOMStorageModel.prototype._securityOriginAdded):
90 (WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
91 (WebInspector.DOMStorageModel.prototype._storageKey):
92 * inspector/front-end/ExtensionAuditCategory.js:
93 * inspector/front-end/FileSystemModel.js:
94 (WebInspector.FileSystemModel.prototype._reset):
95 (WebInspector.FileSystemModel.prototype._securityOriginAdded):
96 (WebInspector.FileSystemModel.prototype._securityOriginRemoved):
97 (WebInspector.FileSystemModel.prototype._addOrigin):
98 (WebInspector.FileSystemModel.prototype._removeOrigin):
99 (WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
100 (WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
101 (WebInspector.FileSystemModel.prototype._removeFileSystem):
102 (WebInspector.FileSystemModel.FileSystem.prototype.get name):
103 * inspector/front-end/IndexedDBModel.js:
104 (WebInspector.IndexedDBModel.prototype._reset):
105 (WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
106 (WebInspector.IndexedDBModel.prototype._securityOriginAdded):
107 (WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
108 (WebInspector.IndexedDBModel.prototype._addOrigin):
109 (WebInspector.IndexedDBModel.prototype._removeOrigin):
110 (WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
111 (WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
112 (WebInspector.IndexedDBModel.prototype._loadDatabase):
113 (WebInspector.IndexedDBModel.prototype.):
114 (WebInspector.IndexedDBModel.prototype._requestData):
115 (WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
116 * inspector/front-end/IndexedDBViews.js:
117 (WebInspector.IDBDatabaseView.prototype._refreshDatabase):
118 * inspector/front-end/ResourceTreeModel.js:
119 (WebInspector.ResourceTreeModel):
120 (WebInspector.ResourceTreeModel.prototype._addFrame):
121 (WebInspector.ResourceTreeModel.prototype._addSecurityOrigin):
122 (WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin):
123 (WebInspector.ResourceTreeModel.prototype.securityOrigins):
124 (WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
125 (WebInspector.ResourceTreeModel.prototype._frameNavigated):
126 (WebInspector.ResourceTreeModel.prototype._frameDetached):
127 (WebInspector.ResourceTreeFrame):
128 (WebInspector.ResourceTreeFrame.prototype._navigate):
129 * inspector/front-end/ResourcesPanel.js:
130 (WebInspector.IDBDatabaseTreeElement):
131 (WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
132 (WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
133 (WebInspector.IDBIndexTreeElement.prototype.get itemURL):
134 (WebInspector.DOMStorageTreeElement):
135 (WebInspector.DOMStorageTreeElement.prototype.get itemURL):
136 (WebInspector.FileSystemTreeElement):
138 2013-03-01 Vsevolod Vlasov <vsevik@chromium.org>
140 Web Inspector: Let user know when file system based uiSourceCode was changed on disk.
141 https://bugs.webkit.org/show_bug.cgi?id=110133
143 Reviewed by Pavel Feldman.
145 We now check if file system based uiSourceCode content was updated externally when
146 UISourceCodeFrame is shown or inspector window is focused.
147 If there is no working copy being edited right now we replace old content with the new one silently.
148 Otherwise ask user if he wants to replace his working copy with the new content.
150 * English.lproj/localizedStrings.js:
151 * WebCore.vcproj/WebCore.vcproj:
152 * inspector/front-end/DefaultTextEditor.js:
153 (WebInspector.DefaultTextEditor.prototype.editRange):
154 * inspector/front-end/FileSystemProjectDelegate.js:
155 (WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
156 (WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
157 (WebInspector.FileSystemProjectDelegate.prototype._contentRequestFinished):
158 (WebInspector.FileSystemProjectDelegate.prototype.requestUpdatedFileContent):
159 (WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
160 (WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
161 * inspector/front-end/JavaScriptSourceFrame.js:
162 (WebInspector.JavaScriptSourceFrame.prototype.wasShown):
163 (WebInspector.JavaScriptSourceFrame.prototype.willHide):
164 * inspector/front-end/SimpleWorkspaceProvider.js:
165 (WebInspector.SimpleProjectDelegate.prototype.requestUpdatedFileContent):
166 * inspector/front-end/SourceFrame.js:
167 (WebInspector.SourceFrame.prototype.setContent):
168 * inspector/front-end/UISourceCode.js:
169 (WebInspector.UISourceCode.prototype.checkContentUpdated.updatedContentLoaded):
170 (WebInspector.UISourceCode.prototype.checkContentUpdated):
171 * inspector/front-end/UISourceCodeFrame.js:
172 (WebInspector.UISourceCodeFrame.prototype.wasShown):
173 (WebInspector.UISourceCodeFrame.prototype.willHide):
174 (WebInspector.UISourceCodeFrame.prototype._windowFocused):
175 (WebInspector.UISourceCodeFrame.prototype._checkContentUpdated):
176 * inspector/front-end/Workspace.js:
177 (WebInspector.ProjectDelegate.prototype.requestUpdatedFileContent):
178 (WebInspector.Project.prototype.requestUpdatedFileContent):
180 2013-03-03 Arpita Bahuguna <a.bah@samsung.com>
182 createAttribute/setAttributeNode does not properly normalize case
183 https://bugs.webkit.org/show_bug.cgi?id=90341
185 Reviewed by Darin Adler.
187 setAttributeNode() verifies for existing attributes in a case sensitive
188 manner. Thus, it would add another attribute if specified in a case
189 different from the existing one. Instead, like setAttribute(), it too
190 should modify the existing attribute's value.
192 Test: fast/dom/Element/setAttributeNode-case-insensitivity.html
195 (WebCore::Element::setAttributeNode):
196 Made changes to check for an existing attribute by converting the
197 specified attribute's localName to lowercase.
199 2013-03-03 Kentaro Hara <haraken@chromium.org>
201 Unreviewed. Rebaselined run-bindings-tests.
203 * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
204 (WebCore::TestActiveDOMObjectV8Internal::indexedSecurityCheck):
205 (TestActiveDOMObjectV8Internal):
206 (WebCore::TestActiveDOMObjectV8Internal::namedSecurityCheck):
207 (WebCore::ConfigureV8TestActiveDOMObjectTemplate):
208 * bindings/scripts/test/V8/V8TestActiveDOMObject.h:
209 (V8TestActiveDOMObject):
211 2013-03-03 Kentaro Hara <haraken@chromium.org>
213 Unreviewed build fix after r144590.
215 * bindings/scripts/CodeGeneratorV8.pm:
216 (GenerateSecurityCheckFunctions):
218 2013-03-03 Kentaro Hara <haraken@chromium.org>
220 Unreviewed build fix after r144587.
222 * bindings/v8/V8Binding.cpp:
223 (WebCore::toV8Context):
224 * bindings/v8/V8MutationCallback.cpp:
225 (WebCore::V8MutationCallback::V8MutationCallback):
227 2013-03-01 Kentaro Hara <haraken@chromium.org>
229 [V8] HTMLDocument.all should have [Replaceable]
230 https://bugs.webkit.org/show_bug.cgi?id=111230
232 Reviewed by Adam Barth.
234 (Although HTMLDocument.all is already removed from the spec,)
235 it is expected to behave as a [Replaceable] attribute. By adding
236 a [Replaceable] IDL attribute, we can remove custom implementation
239 I confimed that exactly the same code is generated for .all getter
242 No tests. No change in behavior.
244 * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
245 * html/HTMLDocument.idl:
247 2013-03-01 Kentaro Hara <haraken@chromium.org>
249 [V8] indexedSecurityCheck() and namedSecurityCheck() should be auto-generated
250 https://bugs.webkit.org/show_bug.cgi?id=111225
252 Reviewed by Adam Barth.
254 indexedSecurityCheck() and namedSecurityCheck() should be auto-generated,
255 except for DOMWindow's ones.
257 No tests. No change in behavior.
259 * bindings/scripts/CodeGeneratorV8.pm:
261 (GenerateImplementation):
262 (GenerateSecurityCheckFunctions):
263 * bindings/v8/custom/V8DOMWindowCustom.cpp:
264 (WebCore::V8DOMWindow::namedSecurityCheckCustom):
265 (WebCore::V8DOMWindow::indexedSecurityCheckCustom):
266 * bindings/v8/custom/V8HistoryCustom.cpp:
267 * bindings/v8/custom/V8LocationCustom.cpp:
269 2013-03-01 Kentaro Hara <haraken@chromium.org>
271 [V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
272 https://bugs.webkit.org/show_bug.cgi?id=111214
274 Reviewed by Adam Barth.
276 $implContentDecls stores generated code that is put in a namespace 'XXXV8Internal'.
277 For clarification, it should be renamed to $implContentInternals.
279 No tests. No change in behavior.
281 * bindings/scripts/CodeGeneratorV8.pm:
282 (GenerateDomainSafeFunctionGetter):
283 (GenerateDomainSafeFunctionSetter):
284 (GenerateConstructorGetter):
285 (GenerateNormalAttrGetterCallback):
286 (GenerateNormalAttrGetter):
287 (GenerateReplaceableAttrSetterCallback):
288 (GenerateReplaceableAttrSetter):
289 (GenerateNormalAttrSetterCallback):
290 (GenerateNormalAttrSetter):
291 (GenerateOverloadedFunction):
292 (GenerateFunctionCallback):
294 (GenerateOverloadedConstructorCallback):
295 (GenerateSingleConstructorCallback):
296 (GenerateEventConstructor):
297 (GenerateTypedArrayConstructor):
298 (GenerateImplementation):
301 2013-03-01 Kentaro Hara <haraken@chromium.org>
303 [V8] Rename getWorld() to isolatedWorld(), and getWorldForEnteredContext() to isolatedWorldForEnteredContext()
304 https://bugs.webkit.org/show_bug.cgi?id=111212
306 Reviewed by Adam Barth.
308 The rename I did in r142424 was wrong. Given that getWorld() returns 0
309 for the main world, it should be named isolatedWorld(). Similarly,
310 given that getWorldForEnteredContext() returns 0 for the main world,
311 it should be named isolatedWorldForEnteredContext().
313 No tests. No change in behavior.
315 * bindings/v8/CustomElementHelpers.cpp:
316 (WebCore::CustomElementHelpers::isFeatureAllowed):
317 * bindings/v8/DOMDataStore.cpp:
318 (WebCore::DOMDataStore::current):
319 * bindings/v8/DOMWrapperWorld.cpp:
320 (WebCore::DOMWrapperWorld::makeContextWeak):
321 * bindings/v8/DOMWrapperWorld.h:
322 (WebCore::DOMWrapperWorld::isolatedWorld):
323 * bindings/v8/ScriptController.cpp:
324 (WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
325 (WebCore::ScriptController::currentWorldContext):
326 * bindings/v8/V8Binding.h:
327 (WebCore::isolatedWorldForEnteredContext):
328 * bindings/v8/WorldContextHandle.cpp:
329 (WebCore::WorldContextHandle::WorldContextHandle):
330 * bindings/v8/custom/V8DocumentCustom.cpp:
332 * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
334 * bindings/v8/custom/V8SVGDocumentCustom.cpp:
336 * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
337 (WebCore::V8XMLHttpRequest::constructorCustom):
339 2013-03-01 Kentaro Hara <haraken@chromium.org>
341 [V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
342 https://bugs.webkit.org/show_bug.cgi?id=111223
344 Reviewed by Adam Barth.
346 HTMLDocument::getNamedProperty() is used by DOMWindowShell.
347 It can be a static method in DOMWindowShell.
349 No tests. No change in behavior.
351 * bindings/scripts/CodeGeneratorV8.pm:
353 * bindings/v8/V8DOMWindowShell.cpp:
354 (WebCore::getNamedProperty):
357 * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
359 2013-03-03 Dan Bernstein <mitz@apple.com>
361 Build fix after r144565. Reverted r144533.
363 * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
365 2013-03-03 Adam Barth <abarth@webkit.org>
367 Attempt to fix the Qt build after r144498
368 https://bugs.webkit.org/show_bug.cgi?id=111272
370 Reviewed by Eric Seidel.
372 Update the Qt version of the XML parser to call the new API.
374 * xml/parser/XMLDocumentParserQt.cpp:
375 (WebCore::XMLDocumentParser::resumeParsing):
376 (WebCore::XMLDocumentParser::appendFragmentSource):
378 2013-03-03 Dean Jackson <dino@apple.com>
380 Plug-ins that are appropriately large w.r.t page size should autostart
381 https://bugs.webkit.org/show_bug.cgi?id=111242
383 Reviewed by Brady Eidson.
385 A "full-page" plug-in site should never snapshot. The trick is
386 how to determine what is full-page. This change implements the
389 - The plug-in is in the main frame (not an iframe).
390 - The plug-in is sized with width and height 100%.
391 - The displayed area of the plug-in is more than 96% of the viewport area.
393 This is definitely not foolproof. For example, zombo.com has a slight
394 border around its plug-in. As the window size gets smaller, the body margin
395 takes up more than 5% of the width or height, and the plug-in doesn't pass
398 * html/HTMLPlugInImageElement.cpp:
399 (WebCore): New static constant: sizingFullPageThresholdPercentage
400 (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Implements
401 the rules described above.
403 2013-03-03 Ryosuke Niwa <rniwa@webkit.org>
405 [Win] IDLParser.pm fails to parse OESTextureHalfFloat and causes a build failure
406 https://bugs.webkit.org/show_bug.cgi?id=111267
408 Reviewed by Kentaro Hara.
410 Allow empty definitions.
412 * bindings/scripts/IDLParser.pm:
415 2013-03-03 David Kilzer <ddkilzer@apple.com>
417 BUILD FIX: RenderLayerFilterInfo.h needs to include Element.h with ENABLE(SVG)
419 Fixes the following build failures:
421 In file included from Source/WebCore/rendering/RenderLayerFilterInfo.cpp:33:
422 Source/WebCore/rendering/RenderLayerFilterInfo.h:118:19: error: use of undeclared identifier 'Element'
423 Vector<RefPtr<Element> > m_internalSVGReferences;
425 Source/WebCore/rendering/RenderLayerFilterInfo.h:118:28: error: expected a type
426 Vector<RefPtr<Element> > m_internalSVGReferences;
428 Source/WebCore/rendering/RenderLayerFilterInfo.h:118:30: error: private field 'm_internalSVGReferences' is not used [-Werror,-Wunused-private-field]
429 Vector<RefPtr<Element> > m_internalSVGReferences;
433 * rendering/RenderLayerFilterInfo.h: Include Element.h within
434 ENABLE(SVG). Move ENABLE(SVG) block below unconditional
437 2013-03-03 Sheriff Bot <webkit.review.bot@gmail.com>
439 Unreviewed, rolling out r144567.
440 http://trac.webkit.org/changeset/144567
441 https://bugs.webkit.org/show_bug.cgi?id=111266
443 Does not compile on apple-win (Requested by abarth on
448 (WebCore::Document::iconURLs):
451 * loader/icon/IconController.cpp:
452 (WebCore::IconController::iconURL):
453 (WebCore::IconController::urlsForTypes):
454 * loader/icon/IconController.h:
456 * testing/Internals.cpp:
457 (WebCore::Internals::iconURLs):
458 * testing/Internals.h:
459 * testing/Internals.idl:
461 2013-03-03 Mike West <mkwst@chromium.org>
463 CSP 1.1: Support CSP 1.1 directives on the unprefixed header.
464 https://bugs.webkit.org/show_bug.cgi?id=111254
466 Reviewed by Adam Barth.
468 We'd like to ensure that early adopters don't get stuck on a prefixed
469 header; when CSP 1.1 is baked enough to be supported in multiple
470 browsers, everything should Just Workâ„¢.
472 This patch changes WebKit's behavior regarding CSP_NEXT features.
473 Currently, they're only exposed on the prefixed header ('X-WebKit-CSP').
474 This patch exposes those features on the canonical header, assuming
475 that the runtime flag is set. This shouldn't have any effect at all on
476 ports that haven't yet enabled CSP_NEXT, and will simply clear the way
477 for a clean deployment to a wider audience once the specification
478 process is further along.
480 This change shouldn't have any effect on the existing tests: they
481 should run just as they did before. The next step will be to adjust
482 the LayoutTests for 1.1 to prefer the canonical header, but I'll do
483 that in another patch to reduce churn.
485 Related, the enum names no longer made sense: the difference between the
486 canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
487 prefix, not the functionality. This patch renames them for clarity.
490 (WebCore::Document::processHttpEquiv):
491 * loader/FrameLoader.cpp:
492 (WebCore::FrameLoader::didBeginDocument):
493 Use the new enum names.
494 * page/ContentSecurityPolicy.cpp:
496 (WebCore::CSPDirectiveList::CSPDirectiveList):
497 (WebCore::CSPDirectiveList::addDirective):
498 Drop the 'm_experimental' property from CSPDirectiveList; we'll
499 control the behavior via the runtime flag from now on.
501 Also, this fixes a small bug in 'addDirective()': we never threw
502 unrecognized directive errors for users who were sending the
503 prefixed header. Oops!
504 (WebCore::ContentSecurityPolicy::deprecatedHeaderType):
505 Use the new enum names.
506 * page/ContentSecurityPolicy.h:
507 Redefine the enum for clarity: 'PrefixedReport' and 'Report'
508 rather than 'ReportAllDirectives' and 'ReportStableDirectives'.
510 2013-03-03 Ryosuke Niwa <rniwa@webkit.org>
512 Another Windows build fix attempt after r144567.
513 Try touching the IDL file in a hope it'll regenerate JSInternals.cpp.
515 * testing/Internals.idl:
517 2013-03-03 Adam Barth <abarth@webkit.org>
519 Unreviewed attempted build fix. Adds back some includes removed in
520 http://trac.webkit.org/changeset/144565.
522 * Modules/mediastream/RTCPeerConnection.cpp:
523 * bindings/ScriptControllerBase.cpp:
524 * bindings/objc/DOM.mm:
525 * bindings/v8/ScriptController.cpp:
526 * bindings/v8/V8DOMWindowShell.cpp:
527 * bindings/v8/custom/V8DOMWindowCustom.cpp:
528 * css/CSSFontSelector.cpp:
529 * css/WebKitCSSSVGDocumentValue.cpp:
530 * dom/DOMImplementation.cpp:
531 * dom/PendingScript.h:
532 * dom/ScriptElement.cpp:
533 * dom/ScriptElement.h:
534 * history/CachedFrame.cpp:
536 * html/HTMLAnchorElement.cpp:
537 * html/HTMLAppletElement.cpp:
538 * html/HTMLElement.cpp:
539 * html/HTMLEmbedElement.cpp:
540 * html/HTMLFrameSetElement.cpp:
541 * html/HTMLHtmlElement.cpp:
542 * html/HTMLImageElement.cpp:
543 * html/HTMLObjectElement.cpp:
544 * html/HTMLPlugInElement.cpp:
545 * html/ImageDocument.cpp:
546 * html/ImageInputType.cpp:
547 * html/MediaDocument.cpp:
548 * html/PluginDocument.cpp:
549 * html/canvas/WebGLRenderingContext.cpp:
551 * html/parser/HTMLConstructionSite.cpp:
552 * html/parser/HTMLParserOptions.cpp:
553 * html/parser/XSSAuditorDelegate.cpp:
554 * inspector/InspectorDebuggerAgent.cpp:
555 * inspector/InspectorFileSystemAgent.cpp:
556 * inspector/InspectorFrontendHost.cpp:
557 * inspector/InspectorInstrumentation.h:
558 * inspector/InspectorPageAgent.cpp:
559 * inspector/NetworkResourcesData.cpp:
560 * inspector/NetworkResourcesData.h:
562 * loader/CookieJar.cpp:
563 * loader/CrossOriginAccessControl.cpp:
564 * loader/FrameLoader.cpp:
565 * loader/MainResourceLoader.cpp:
566 * loader/MixedContentChecker.cpp:
567 * loader/PingLoader.cpp:
568 * loader/SubframeLoader.cpp:
569 * loader/SubresourceLoader.cpp:
570 * loader/appcache/ApplicationCacheGroup.cpp:
571 * loader/appcache/ApplicationCacheHost.cpp:
572 * loader/cache/CachedResource.cpp:
573 * loader/icon/IconController.cpp:
574 * page/DOMWindowExtension.cpp:
576 * page/PerformanceTiming.cpp:
577 * page/PointerLockController.cpp:
578 * page/animation/CSSPropertyAnimation.cpp:
579 * platform/chromium/PasteboardChromium.cpp:
580 * platform/efl/ErrorsEfl.cpp:
581 * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
582 * platform/gtk/ErrorsGtk.cpp:
583 * platform/gtk/PasteboardGtk.cpp:
584 * platform/gtk/PasteboardHelper.h:
585 * platform/mac/ClipboardMac.mm:
586 * platform/mac/HTMLConverter.mm:
587 * platform/qt/PasteboardQt.cpp:
588 * plugins/DOMMimeType.cpp:
589 * plugins/PluginView.cpp:
590 * rendering/HitTestResult.cpp:
591 * rendering/RenderImage.cpp:
592 * rendering/RenderImageResource.cpp:
593 * rendering/RenderImageResourceStyleImage.cpp:
594 * rendering/RenderLayer.cpp:
595 * rendering/RenderLayerBacking.cpp:
596 * svg/SVGImageLoader.cpp:
597 * svg/SVGUseElement.cpp:
598 * testing/MockPagePopupDriver.cpp:
599 * xml/XSLStyleSheet.h:
602 2013-03-03 Ruslan Abdikeev <aruslan@chromium.org>
604 <link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
605 https://bugs.webkit.org/show_bug.cgi?id=109061
607 Reviewed by Adam Barth.
609 Test: fast/dom/icon-url-list-apple-touch.html
611 Added iconTypes parameter to Document::iconURLs().
612 Added Document::shortcutIconURLs() with original semantics of iconURLs().
613 Fixed IconController.cpp to provide iconTypesMask to iconURLs().
614 Renamed iconTypes to iconTypesMask to make the meaning clearer.
618 (WebCore::Document::shortcutIconURLs):
620 (WebCore::Document::iconURLs):
623 * loader/icon/IconController.cpp:
624 (WebCore::IconController::iconURL):
625 (WebCore::IconController::urlsForTypes):
626 * testing/Internals.cpp:
627 (WebCore::Internals::iconURLs):
628 (WebCore::Internals::shortcutIconURLs):
630 (WebCore::Internals::allIconURLs):
631 * testing/Internals.h:
632 * testing/Internals.idl:
634 2013-03-03 Mike West <mkwst@chromium.org>
636 CSP: Throw a warning when a '*-report-only' header doesn't contain a 'report-uri' directive.
637 https://bugs.webkit.org/show_bug.cgi?id=111208
639 Reviewed by Adam Barth.
641 Developers in the wild have been observed to serve a report-only CSP
642 header with a policy that doesn't contain a 'report-uri' directive.
643 This has zero effect, of course, and we should help them understand
644 that by throwing a warning up on the console.
646 Test: http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html
648 * page/ContentSecurityPolicy.cpp:
649 (WebCore::CSPDirectiveList::isReportOnly): Added.
650 (WebCore::CSPDirectiveList::reportURIs): Added.
651 (WebCore::CSPDirectiveList::create):
652 After creating a CSPDirectiveList, check whether it's in
653 report-only mode without a report-uri. If so, warn the developer.
654 (WebCore::ContentSecurityPolicy::reportMissingReportURI): Added.
655 Write an exciting message to the console, warning the developer
656 about her expensive no-op machine.
658 2013-03-03 Adam Barth <abarth@webkit.org>
660 Unreviewed rollout of http://trac.webkit.org/r144530
661 As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
662 https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
663 large number of ASSERTs in chromium-win.
666 * GNUmakefile.list.am:
667 * Modules/mediastream/RTCPeerConnection.cpp:
668 * Modules/notifications/Notification.cpp:
672 * WebCore.vcproj/WebCore.vcproj:
673 * WebCore.vcxproj/WebCore.vcxproj:
674 * WebCore.vcxproj/WebCore.vcxproj.filters:
675 * WebCore.xcodeproj/project.pbxproj:
676 * bindings/ScriptControllerBase.cpp:
677 * bindings/js/JSNodeCustom.cpp:
678 * bindings/js/ScriptController.cpp:
679 * bindings/js/ScriptSourceCode.h:
681 * bindings/objc/DOM.mm:
682 * bindings/v8/ScriptController.cpp:
683 * bindings/v8/V8DOMWindowShell.cpp:
684 * bindings/v8/custom/V8DOMWindowCustom.cpp:
685 * css/CSSCrossfadeValue.h:
686 (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
687 (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
688 * css/CSSFontFaceSource.h:
689 * css/CSSFontSelector.cpp:
690 * css/WebKitCSSSVGDocumentValue.cpp:
691 * css/WebKitCSSSVGDocumentValue.h:
694 (WebCore::Clipboard::Clipboard):
695 * dom/ContainerNode.cpp:
696 * dom/DOMImplementation.cpp:
697 * dom/PendingScript.h:
698 * dom/ScriptElement.cpp:
699 * dom/ScriptElement.h:
700 * history/CachedFrame.cpp:
702 * html/HTMLAnchorElement.cpp:
703 * html/HTMLAppletElement.cpp:
704 * html/HTMLElement.cpp:
705 * html/HTMLEmbedElement.cpp:
706 * html/HTMLFrameSetElement.cpp:
707 * html/HTMLHtmlElement.cpp:
708 * html/HTMLImageElement.cpp:
709 * html/HTMLObjectElement.cpp:
710 * html/HTMLPlugInElement.cpp:
711 * html/ImageDocument.cpp:
712 * html/ImageInputType.cpp:
713 * html/MediaDocument.cpp:
714 * html/PluginDocument.cpp:
715 * html/canvas/WebGLRenderingContext.cpp:
717 * html/parser/HTMLConstructionSite.cpp:
718 * html/parser/HTMLParserOptions.cpp:
719 * html/parser/HTMLScriptRunner.h:
720 * html/parser/XSSAuditor.cpp:
721 * html/parser/XSSAuditorDelegate.cpp:
722 * inspector/InspectorDebuggerAgent.cpp:
723 * inspector/InspectorFileSystemAgent.cpp:
724 * inspector/InspectorFrontendHost.cpp:
725 * inspector/InspectorInstrumentation.h:
727 * inspector/InspectorPageAgent.cpp:
728 * inspector/NetworkResourcesData.cpp:
729 * inspector/NetworkResourcesData.h:
731 * loader/CookieJar.cpp:
732 * loader/CrossOriginAccessControl.cpp:
733 * loader/CrossOriginAccessControl.h:
735 * loader/CrossOriginPreflightResultCache.h:
736 * loader/DocumentThreadableLoader.h:
737 * loader/FrameLoader.cpp:
738 (WebCore::FrameLoader::FrameLoader):
739 * loader/FrameLoader.h:
741 (WebCore::FrameLoader::policyChecker):
742 * loader/ImageLoader.cpp:
743 * loader/ImageLoader.h:
744 * loader/LinkLoader.h:
746 * loader/MainResourceLoader.cpp:
747 * loader/MainResourceLoader.h:
749 * loader/MixedContentChecker.cpp:
750 * loader/PingLoader.cpp:
751 * loader/PolicyChecker.h:
753 * loader/ProgressTracker.cpp:
754 * loader/SubframeLoader.cpp:
755 * loader/SubresourceLoader.cpp:
756 * loader/TextTrackLoader.cpp:
757 * loader/TextTrackLoader.h:
759 * loader/ThreadableLoader.h:
760 * loader/appcache/ApplicationCacheGroup.cpp:
761 * loader/appcache/ApplicationCacheGroup.h:
763 * loader/appcache/ApplicationCacheHost.cpp:
764 * loader/archive/cf/LegacyWebArchive.cpp:
765 * loader/cache/CachedFont.cpp:
766 * loader/cache/CachedFont.h:
768 (WebCore::CachedFontClient::~CachedFontClient):
769 (WebCore::CachedFontClient::expectedType):
770 (WebCore::CachedFontClient::resourceClientType):
771 (WebCore::CachedFontClient::fontLoaded):
773 * loader/cache/CachedFontClient.h: Removed.
774 * loader/cache/CachedImage.cpp:
775 * loader/cache/CachedRawResource.cpp:
776 * loader/cache/CachedRawResource.h:
778 (CachedRawResourceClient):
779 (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
780 (WebCore::CachedRawResourceClient::expectedType):
781 (WebCore::CachedRawResourceClient::resourceClientType):
782 (WebCore::CachedRawResourceClient::dataSent):
783 (WebCore::CachedRawResourceClient::responseReceived):
784 (WebCore::CachedRawResourceClient::dataReceived):
785 (WebCore::CachedRawResourceClient::redirectReceived):
786 (WebCore::CachedRawResourceClient::dataDownloaded):
787 * loader/cache/CachedRawResourceClient.h: Removed.
788 * loader/cache/CachedResource.cpp:
789 * loader/cache/CachedResourceHandle.cpp:
791 * loader/cache/CachedResourceHandle.h:
793 (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
794 (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
795 * loader/cache/CachedSVGDocument.h:
796 (CachedSVGDocumentClient):
797 (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
798 (WebCore::CachedSVGDocumentClient::expectedType):
799 (WebCore::CachedSVGDocumentClient::resourceClientType):
801 * loader/cache/CachedSVGDocumentClient.h: Removed.
802 * loader/cache/CachedSVGDocumentReference.cpp: Removed.
803 * loader/cache/CachedSVGDocumentReference.h:
805 (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
806 (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
807 * loader/cache/CachedStyleSheetClient.h:
809 * loader/cache/MemoryCache.h:
812 * loader/chromium/CachedRawResourceChromium.cpp:
813 * loader/icon/IconController.cpp:
814 * loader/icon/IconLoader.h:
815 * loader/mac/ResourceLoaderMac.mm:
816 * page/DOMWindowExtension.cpp:
818 (WebCore::Frame::Frame):
820 (WebCore::Frame::reportMemoryUsage):
824 (WebCore::Frame::init):
825 (WebCore::Frame::loader):
826 * page/PerformanceNavigation.cpp:
827 * page/PerformanceTiming.cpp:
828 * page/PointerLockController.cpp:
830 * page/animation/CSSPropertyAnimation.cpp:
831 * platform/chromium/PasteboardChromium.cpp:
832 * platform/efl/ErrorsEfl.cpp:
833 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
834 * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
835 * platform/graphics/filters/FilterOperation.cpp:
837 * platform/graphics/filters/FilterOperation.h:
839 (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
840 (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
841 * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
842 * platform/gtk/ErrorsGtk.cpp:
843 * platform/gtk/PasteboardGtk.cpp:
844 * platform/gtk/PasteboardHelper.h:
845 * platform/mac/ClipboardMac.h:
846 * platform/mac/ClipboardMac.mm:
847 * platform/mac/HTMLConverter.mm:
848 * platform/mac/PasteboardMac.mm:
849 * platform/network/AuthenticationChallengeBase.cpp:
850 * platform/network/cf/CookieJarCFNet.cpp:
851 * platform/network/cf/ResourceRequestCFNet.cpp:
852 * platform/network/mac/CookieStorageMac.mm:
853 * platform/qt/PasteboardQt.cpp:
854 * plugins/DOMMimeType.cpp:
855 * plugins/PluginRequest.h: Removed.
856 * plugins/PluginStream.h:
857 (PluginStreamClient):
858 (WebCore::PluginStreamClient::~PluginStreamClient):
859 (WebCore::PluginStreamClient::streamDidFinishLoading):
861 * plugins/PluginStreamClient.h: Removed.
862 * plugins/PluginView.cpp:
863 * plugins/PluginView.h:
866 (WebCore::PluginRequest::PluginRequest):
867 (WebCore::PluginRequest::frameLoadRequest):
868 (WebCore::PluginRequest::notifyData):
869 (WebCore::PluginRequest::sendNotification):
870 (WebCore::PluginRequest::shouldAllowPopups):
871 * rendering/HitTestResult.cpp:
872 * rendering/InlineFlowBox.cpp:
873 * rendering/RenderBox.cpp:
874 * rendering/RenderEmbeddedObject.cpp:
875 * rendering/RenderImage.cpp:
876 * rendering/RenderImageResource.cpp:
877 (WebCore::RenderImageResource::RenderImageResource):
879 * rendering/RenderImageResource.h:
880 (WebCore::RenderImageResource::image):
881 (WebCore::RenderImageResource::errorOccurred):
882 (WebCore::RenderImageResource::usesImageContainerSize):
883 (WebCore::RenderImageResource::imageHasRelativeWidth):
884 (WebCore::RenderImageResource::imageHasRelativeHeight):
885 (WebCore::RenderImageResource::imageSize):
886 * rendering/RenderImageResourceStyleImage.cpp:
887 * rendering/RenderLayer.cpp:
888 * rendering/RenderLayerBacking.cpp:
889 * rendering/RenderLayerFilterInfo.h:
891 * rendering/RenderListItem.cpp:
892 * rendering/RenderListMarker.cpp:
893 * rendering/RenderSnapshottedPlugIn.cpp:
894 * rendering/RenderTableCol.cpp:
895 * rendering/RenderTableRow.cpp:
896 * rendering/RenderTableSection.cpp:
897 * rendering/style/StyleCachedShader.h:
898 * rendering/style/StyleCustomFilterProgram.cpp: Removed.
899 * rendering/style/StyleCustomFilterProgram.h:
901 (WebCore::StyleCustomFilterProgram::vertexShaderString):
902 (StyleCustomFilterProgram):
903 (WebCore::StyleCustomFilterProgram::fragmentShaderString):
904 (WebCore::StyleCustomFilterProgram::isLoaded):
905 (WebCore::StyleCustomFilterProgram::willHaveClients):
906 (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
907 (WebCore::StyleCustomFilterProgram::notifyFinished):
908 * svg/SVGFEImageElement.h:
909 * svg/SVGFontFaceUriElement.h:
910 (SVGFontFaceUriElement):
911 * svg/SVGImageLoader.cpp:
912 * svg/SVGUseElement.cpp:
913 * svg/SVGUseElement.h:
914 * svg/graphics/SVGImageCache.cpp:
915 * testing/MockPagePopupDriver.cpp:
916 * xml/XSLStyleSheet.h:
918 * xml/XSLTProcessorLibxslt.cpp:
919 * xml/parser/XMLDocumentParser.cpp:
920 * xml/parser/XMLDocumentParser.h:
921 * xml/parser/XMLDocumentParserLibxml2.cpp:
923 2013-03-03 Kentaro Hara <haraken@chromium.org>
925 [V8] Remove TranslateParameter() from CodeGeneratorV8.pm
926 https://bugs.webkit.org/show_bug.cgi?id=111218
928 Reviewed by Adam Barth.
930 TranslateParameter() does nothing. It tries to convert TimeoutHandler to DOMString,
931 but there is no non-custom method that uses TimeoutHandler.
933 The only place where TimeoutHandler is used in the WebKit IDL is setTimeout() and setInterval().
934 However, the latest spec uses 'any' instead of TimeoutHandler.
935 http://dev.w3.org/html5/spec-LC/timers.html
936 Thus, this patch updates the IDL declarations of setTimeout() and setInterval()
937 according to the spec. By this change, TimeoutHandler is gone away from the WebKit IDL.
938 (Anyway this IDL change has no effect, because setTimeout() and setInterval() are written
941 No tests. No change in behavior.
943 * bindings/scripts/CodeGeneratorV8.pm:
944 (GenerateParametersCheck):
945 * page/DOMWindow.idl:
946 * workers/WorkerContext.idl:
948 2013-03-03 James Weatherall <wez@chromium.org>
950 keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
951 https://bugs.webkit.org/show_bug.cgi?id=85642
953 Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.
955 Reviewed by Adam Barth.
957 * platform/chromium/KeyCodeConversionGtk.cpp:
958 (WebCore::windowsKeyCodeForKeyEvent):
960 2013-03-03 Adam Barth <abarth@webkit.org>
962 REGRESSION(144520): Does not compile on chromium-win
963 https://bugs.webkit.org/show_bug.cgi?id=111261
965 Unreviewed rollout of http://trac.webkit.org/changeset/144520. This
966 patch does not compile for chromium-win. See the bug for the compile
969 * rendering/ExclusionShapeInsideInfo.cpp:
970 * rendering/ExclusionShapeInsideInfo.h:
973 (WebCore::LineSegmentRange::LineSegmentRange):
974 (WebCore::ExclusionShapeInsideInfo::isEnabledFor):
975 * rendering/RenderBlock.cpp:
976 (WebCore::RenderBlock::willBeDestroyed):
977 (WebCore::RenderBlock::exclusionShapeInsideInfo):
979 (WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
980 * rendering/RenderBlock.h:
983 (RenderBlockRareData):
984 * rendering/RenderBlockLineLayout.cpp:
985 (WebCore::constructBidiRunsForLine):
987 2013-03-02 Zan Dobersek <zdobersek@igalia.com>
989 REGRESSION (r144517): IndexedDB layout test failures on GTK
990 https://bugs.webkit.org/show_bug.cgi?id=111243
992 Reviewed by Martin Robinson.
994 Changes to the custom JSC bindings for IDBAny are required after r144517,
995 specifically the case of IDBAny object having the KeyPathType type has to be covered.
996 These changes are analogous to those made to the V8 bindings in the mentioned commit.
998 No new tests - already covered by existing tests.
1000 * bindings/js/JSIDBAnyCustom.cpp:
1001 (WebCore::toJS): A helper function that wraps an IDBKeyPath into a JSValue.
1002 (WebCore): Shuffle the order inside the switch statement a bit to match the V8 custom bindings.
1003 Cover the case where the IDBAny object has the KeyPathType, calling the new helper method.
1005 2013-03-02 Darin Adler <darin@apple.com>
1007 Another try at fixing the build.
1009 * loader/cache/MemoryCache.cpp: Added an include of CachedResourceHandle.h.
1011 2013-03-02 Darin Adler <darin@apple.com>
1015 * inspector/InspectorInstrumentation.h: Add missing forward declaration
1018 2013-02-18 Darin Adler <darin@apple.com>
1020 Cut down the number of source files that depend on Clipboard.h
1021 https://bugs.webkit.org/show_bug.cgi?id=110030
1023 Reviewed by Ryosuke Niwa.
1025 I am doing some work on Clipboard and it's better to recompile 50 files
1026 each time we touch the header instead of 700. Also cut down on includes
1029 * WebCore.exp.in: Updated for new MouseEvent::create function.
1031 * dom/ClipboardEvent.cpp: Added include of Clipboard.h since we use it
1032 here and the world no longer includes it everywhere.
1034 * dom/ClipboardEvent.h: Forward declared Clipboard instead of including
1035 Clipboard.h. Also made some overrides private because they can be.
1037 * dom/DataTransferItem.h: Removed unneeded include of Clipboard.h.
1039 * dom/MouseEvent.cpp: Added include of Clipboard.h since we use it
1040 here and the world no longer includes it everywhere.
1041 (WebCore::MouseEvent::create): Made the create function non-inline
1042 since we can't compile it without including Clipboard.h and we don't
1043 want to include Clipboard.h in the header. This is not so commonly
1044 used or so hot that this needs to be inlined.
1046 * dom/MouseEvent.h: Forward declared Clipboard instead of including
1047 Clipboard.h. Made MouseEvent::create a non-inline function and also
1048 used overloading instead of default arguments, since we can't compile
1049 a default argument of type PassRefPtr<Clipboard> without including
1052 * dom/WheelEvent.cpp: Added include of Clipboard.h since we use it
1053 here and the world no longer includes it everywhere.
1055 * dom/WheelEvent.h: Forward declare PlatformWheelEvent since it is used
1056 in this header. Previously we'd get it indirectly from including a header
1057 that included Clipboard.h.
1059 * editing/Editor.cpp: Added include of Clipboard.h since we use it here
1060 and the world no longer includes it everywhere.
1062 * inspector/InspectorDebuggerAgent.cpp: Added include of CachedResource.h.
1063 We used to get this indirectly through Clipboard.h.
1065 * inspector/InspectorFrontendHost.cpp: Added includes of ResourceError.h
1066 and ResourceResponse.h. We used to get these indirectly through Clipboard.h.
1067 Also removed unneeded include of <wtf/RefPtr.h>.
1069 * inspector/NetworkResourcesData.cpp: Added include of CachedResource.h.
1070 We used to get this indirectly through Clipboard.h.
1072 * loader/PingLoader.cpp: Added include of ResourceResponse.h.
1073 We used to get this indirectly through Clipboard.h.
1075 * page/DragController.cpp: Added include of DragState.h.
1076 We used to get this indirectly through EventHandler.h
1078 * page/EventHandler.h: Forward declared DragState and Element instead of
1079 including DragState.h. Also added an include of LayoutPoint.h, which we
1080 used to get indirectly through DragState.h.
1082 2013-02-27 Darin Adler <darin@apple.com>
1084 StringHasher functions require alignment that call sites do not all guarantee
1085 https://bugs.webkit.org/show_bug.cgi?id=110171
1087 Reviewed by Benjamin Poulain.
1089 * platform/graphics/WidthCache.h:
1090 (WebCore::WidthCache::SmallStringKey::SmallStringKey): Use the newly added
1091 addCharactersAssumingAligned to make sure we don't slow this call site down.
1092 It's safe since this code always adds characters two at a time.
1094 2013-03-02 Adam Barth <abarth@webkit.org>
1096 XSSAuditor has a subtle race condition when used with the threaded HTML parser
1097 https://bugs.webkit.org/show_bug.cgi?id=111253
1099 Reviewed by Eric Seidel.
1101 We were refing and derefing a StringImpl for a main-thread
1102 AtomicString. Using QualifiedNames on the background thread is very
1103 fragile and we should figure out a more robust solution.
1105 * html/parser/XSSAuditor.cpp:
1106 (WebCore::findAttributeWithName):
1108 2013-03-02 Benjamin Poulain <bpoulain@apple.com>
1110 Move computedStyleIncludingVisitedInfo from TestRunner to Internals
1111 https://bugs.webkit.org/show_bug.cgi?id=109772
1113 Reviewed by Andreas Kling.
1115 The function computedStyleIncludingVisitedInfo() is purely internal to WebCore,
1116 it is better defined on Internals than on TestRunner.
1118 * testing/Internals.cpp:
1119 (WebCore::Internals::computedStyleIncludingVisitedInfo):
1120 * testing/Internals.h:
1121 * testing/Internals.idl:
1123 2013-03-02 David Kilzer <ddkilzer@apple.com>
1125 BUILD FIX (r143637): Export ScriptController::javaScriptContext() on iOS
1126 <http://webkit.org/b/106059>
1128 Fixes the following build failure:
1130 Undefined symbols for architecture armv7:
1131 "__ZN7WebCore16ScriptController17javaScriptContextEv", referenced from:
1132 -[WebFrame javaScriptContext] in WebFrame.o
1133 __ZN20WebFrameLoaderClient35dispatchDidClearWindowObjectInWorldEPN7WebCore15DOMWrapperWorldE in WebFrameLoaderClient.o
1134 ld: symbol(s) not found for architecture armv7
1136 * WebCore.exp.in: Export ScriptController::javaScriptContext()
1137 even more unconditionally.
1139 2013-03-02 Eric Seidel <eric@webkit.org>
1141 Remove two unnecessary mallocs from the main-thread-parser code path
1142 https://bugs.webkit.org/show_bug.cgi?id=111249
1144 Reviewed by Adam Barth.
1146 I noticed these while fixing up our Vector -> String conversions
1147 but never went back to fix the FIXME.
1149 AtomicString(Vector<UChar, capacity>) is smart enough to avoid mallocing
1150 if the represented string is already in the AtomicString table. It
1151 also handles 8bit vs. 16bit and empty() just like nameString() does.
1153 I also removed a 3rd caller to nameString() in the XSSAuditor which
1154 was causing an unnecessary malloc in both the main and background
1155 thread parser paths.
1157 * html/parser/AtomicHTMLToken.h:
1158 (WebCore::AtomicHTMLToken::AtomicHTMLToken):
1159 * html/parser/HTMLToken.h:
1160 * html/parser/XSSAuditor.cpp:
1162 (WebCore::threadSafeMatch):
1165 2013-03-02 Eric Seidel <eric@webkit.org>
1167 constructTreeFromCompactHTMLToken should call clearExternalCharacters
1168 https://bugs.webkit.org/show_bug.cgi?id=111248
1170 Reviewed by Adam Barth.
1172 I don't know how to write a test for this. It's possible characters()
1173 is never accessed from HTMLStackItem::token(), but it's better to be
1174 safe than sorry here.
1176 * html/parser/HTMLDocumentParser.cpp:
1177 (WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
1179 2013-03-02 Rob Buis <rbuis@rim.com>
1181 Text overflow ellipsis wrong color when using webkit-text-fill-color
1182 https://bugs.webkit.org/show_bug.cgi?id=54841
1184 Reviewed by David Hyatt.
1186 Take -webkit-text-fill-color into account for ellipsis painting.
1188 Test: fast/css/text-overflow-ellipsis-color.html
1190 * rendering/EllipsisBox.cpp:
1191 (WebCore::EllipsisBox::paint):
1193 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1195 Fix a typo in my previous commit (r144534).
1197 * platform/win/PasteboardWin.cpp:
1199 2013-03-02 Nayan Kumar K <nayankk@motorola.com>
1201 [WebGL] Support for texImage2D of type HALF_FLOAT_OES with ArrayBufferView.
1202 https://bugs.webkit.org/show_bug.cgi?id=110818
1204 Reviewed by Kenneth Russell.
1206 As per OES_texture_half_float specification texImage2D and texSubImage2D entry
1207 points taking ArrayBufferView should extended to accept null with the pixel type
1210 Tests: fast/canvas/webgl/oes-texture-half-float-not-supported.html
1211 fast/canvas/webgl/oes-texture-half-float.html
1214 * DerivedSources.make:
1215 * DerivedSources.pri:
1216 * GNUmakefile.list.am:
1219 * WebCore.xcodeproj/project.pbxproj:
1220 * bindings/js/JSWebGLRenderingContextCustom.cpp:
1222 * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
1223 (WebCore::toV8Object):
1224 * html/canvas/OESTextureHalfFloat.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
1226 (WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
1227 (WebCore::OESTextureHalfFloat::~OESTextureHalfFloat):
1228 (WebCore::OESTextureHalfFloat::getName):
1229 (WebCore::OESTextureHalfFloat::create):
1230 * html/canvas/OESTextureHalfFloat.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
1232 (OESTextureHalfFloat):
1233 * html/canvas/OESTextureHalfFloat.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
1234 * html/canvas/WebGLExtension.h:
1235 * html/canvas/WebGLRenderingContext.cpp:
1237 (WebCore::WebGLRenderingContext::getExtension):
1238 (WebCore::WebGLRenderingContext::texImage2D):
1239 (WebCore::WebGLRenderingContext::texSubImage2D):
1240 (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
1241 (WebCore::WebGLRenderingContext::validateTexFuncData):
1242 * html/canvas/WebGLRenderingContext.h:
1244 (WebGLRenderingContext):
1245 * html/canvas/WebGLRenderingContext.idl:
1246 * platform/graphics/Extensions3D.h:
1248 * platform/graphics/GraphicsContext3D.cpp:
1249 (WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
1250 * platform/graphics/GraphicsContext3D.h:
1251 * platform/graphics/GraphicsTypes3D.h:
1252 * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
1253 (WebCore::GraphicsContext3D::texImage2D):
1255 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1257 Windows build fix attempt after r144530.
1259 * platform/win/PasteboardWin.cpp:
1261 2013-03-01 Dan Bernstein <mitz@apple.com>
1263 Tried to fix the build after r144530.
1265 * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Include the header for the
1268 2013-03-01 Terry Anderson <tdanderson@chromium.org>
1270 Remove unused member variable m_useLatchedEventNode from PlatformWheelEvent.h
1271 https://bugs.webkit.org/show_bug.cgi?id=107314
1273 Reviewed by Darin Adler.
1275 EventHandler::handleGestureScrollCore() was removed in http://trac.webkit.org/changeset/140177,
1276 and this was the only place where the member variable |m_useLatchedEventNode| in
1277 PlatformWheelEvent was mutated. This variable is no longer needed and so it should be removed.
1279 No change in behavior, so no new tests needed.
1281 * platform/PlatformWheelEvent.h:
1282 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1283 (WebCore::PlatformWheelEvent::useLatchedEventNode):
1284 (PlatformWheelEvent):
1286 2013-02-28 Alexey Proskuryakov <ap@apple.com>
1288 Reduce amount of rebuilding when touching networking headers
1289 https://bugs.webkit.org/show_bug.cgi?id=111035
1291 Reviewed by Eric Seidel.
1293 This uses a number of common unsurprising techniques. One interesting observation
1294 is that including CachedResource related headers is very expensive. We can usually
1295 get away with their Client counterparts, and with CachedResourceHandle.
1299 Don't include FrameLoader, greatly reducing include graph for most non-loader files.
1300 This required making Frame::init() non-inline - I'm not sure why it ever was.
1302 * loader/FrameLoader.cpp:
1303 * loader/FrameLoader.h:
1304 Even though FrameLoader is logically on loading side of WebCore, it's included in
1305 too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
1306 largest wins. As a future improvement, we should probably convert other members
1309 * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
1310 definition of a class it holds, but default construction does not.
1312 * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
1313 not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
1315 * loader/cache/CachedFont.h:
1316 * loader/cache/CachedFontClient.h: Added.
1317 * loader/cache/CachedRawResource.h:
1318 * loader/cache/CachedRawResourceClient.h: Added.
1319 * loader/cache/CachedSVGDocument.h:
1320 * loader/cache/CachedSVGDocumentClient.h: Added.
1321 These types were defining client types in the same headers, making it impossible
1322 to avoid including networking headers through CachedResource. Moved clients into
1325 * plugins/PluginStream.h:
1326 * plugins/PluginStreamClient.h: Added.
1327 Similar situation here.
1329 * loader/cache/CachedResourceHandle.cpp:
1330 * loader/cache/CachedResourceHandle.h:
1331 Moved functions that need to know about CachedResource to .cpp file. This is another
1332 huge win. Added a destructor, so that CachedResource woudn't be needed in all files
1333 that include CachedResourceHandle.
1335 * loader/cache/CachedSVGDocumentReference.cpp: Added.
1336 * loader/cache/CachedSVGDocumentReference.h:
1337 Moved constructor and virtual function implementations to a .cpp file - they need
1338 not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
1340 * platform/graphics/filters/FilterOperation.cpp:
1341 * platform/graphics/filters/FilterOperation.h:
1342 Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
1343 CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
1344 rendering code that it seems best to cut any ties with resources and loading.
1345 Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
1346 classes are generally harmful (due to code bloat).
1348 * plugins/PluginRequest.h: Added.
1349 * plugins/PluginView.h:
1350 Moved PluginRequest into a separate file, it was out of place in a view hierarchy
1353 * rendering/RenderImageResource.cpp:
1354 * rendering/RenderImageResource.h:
1355 Moved definitions of virtual functions to a .cpp file. Thre is no win from having
1356 them inline, and now we don't need CachedImage.h in the header.
1358 * rendering/style/StyleCustomFilterProgram.cpp: Added.
1359 * rendering/style/StyleCustomFilterProgram.h:
1363 * GNUmakefile.list.am:
1364 * Modules/mediastream/RTCPeerConnection.cpp:
1365 * Modules/notifications/Notification.cpp:
1369 * WebCore.vcproj/WebCore.vcproj:
1370 * WebCore.vcxproj/WebCore.vcxproj:
1371 * WebCore.vcxproj/WebCore.vcxproj.filters:
1372 * WebCore.xcodeproj/project.pbxproj:
1373 * bindings/ScriptControllerBase.cpp:
1374 * bindings/js/JSNodeCustom.cpp:
1375 * bindings/js/ScriptController.cpp:
1376 * bindings/js/ScriptSourceCode.h:
1377 * bindings/objc/DOM.mm:
1378 * bindings/v8/ScriptController.cpp:
1379 * bindings/v8/V8DOMWindowShell.cpp:
1380 * bindings/v8/custom/V8DOMWindowCustom.cpp:
1381 * css/CSSFontFaceSource.h:
1382 * css/CSSFontSelector.cpp:
1383 * css/WebKitCSSSVGDocumentValue.cpp:
1384 * css/WebKitCSSSVGDocumentValue.h:
1385 * dom/Clipboard.cpp:
1386 * dom/ContainerNode.cpp:
1387 * dom/DOMImplementation.cpp:
1388 * dom/PendingScript.h:
1389 * dom/ScriptElement.cpp:
1390 * dom/ScriptElement.h:
1391 * history/CachedFrame.cpp:
1393 * html/HTMLAnchorElement.cpp:
1394 * html/HTMLAppletElement.cpp:
1395 * html/HTMLElement.cpp:
1396 * html/HTMLEmbedElement.cpp:
1397 * html/HTMLFrameSetElement.cpp:
1398 * html/HTMLHtmlElement.cpp:
1399 * html/HTMLImageElement.cpp:
1400 * html/HTMLObjectElement.cpp:
1401 * html/HTMLPlugInElement.cpp:
1402 * html/ImageDocument.cpp:
1403 * html/ImageInputType.cpp:
1404 * html/MediaDocument.cpp:
1405 * html/PluginDocument.cpp:
1406 * html/canvas/WebGLRenderingContext.cpp:
1407 * html/parser/HTMLConstructionSite.cpp:
1408 * html/parser/HTMLParserOptions.cpp:
1409 * html/parser/HTMLScriptRunner.h:
1410 * html/parser/XSSAuditor.cpp:
1411 * html/parser/XSSAuditorDelegate.cpp:
1412 * inspector/InspectorDebuggerAgent.cpp:
1413 * inspector/InspectorFileSystemAgent.cpp:
1414 * inspector/InspectorFrontendHost.cpp:
1415 * inspector/InspectorInstrumentation.h:
1416 * inspector/InspectorPageAgent.cpp:
1417 * inspector/NetworkResourcesData.cpp:
1418 * inspector/NetworkResourcesData.h:
1419 * loader/CookieJar.cpp:
1420 * loader/CrossOriginAccessControl.cpp:
1421 * loader/CrossOriginPreflightResultCache.h:
1422 * loader/DocumentThreadableLoader.h:
1423 * loader/ImageLoader.cpp:
1424 * loader/ImageLoader.h:
1425 * loader/LinkLoader.h:
1426 * loader/MainResourceLoader.cpp:
1427 * loader/MainResourceLoader.h:
1428 * loader/MixedContentChecker.cpp:
1429 * loader/PingLoader.cpp:
1430 * loader/PolicyChecker.h:
1431 * loader/ProgressTracker.cpp:
1432 * loader/SubframeLoader.cpp:
1433 * loader/SubresourceLoader.cpp:
1434 * loader/TextTrackLoader.cpp:
1435 * loader/TextTrackLoader.h:
1436 * loader/ThreadableLoader.h:
1437 * loader/appcache/ApplicationCacheGroup.cpp:
1438 * loader/appcache/ApplicationCacheGroup.h:
1439 * loader/appcache/ApplicationCacheHost.cpp:
1440 * loader/archive/cf/LegacyWebArchive.cpp:
1441 * loader/cache/CachedFont.cpp:
1442 * loader/cache/CachedImage.cpp:
1443 * loader/cache/CachedRawResource.cpp:
1444 * loader/cache/CachedResource.cpp:
1445 * loader/cache/CachedStyleSheetClient.h:
1446 * loader/cache/MemoryCache.cpp:
1447 * loader/cache/MemoryCache.h:
1448 * loader/chromium/CachedRawResourceChromium.cpp:
1449 * loader/icon/IconController.cpp:
1450 * loader/icon/IconLoader.h:
1451 * loader/mac/ResourceLoaderMac.mm:
1452 * page/DOMWindowExtension.cpp:
1453 * page/DragController.cpp:
1454 * page/PerformanceNavigation.cpp:
1455 * page/PerformanceTiming.cpp:
1456 * page/PointerLockController.cpp:
1457 * page/Settings.cpp:
1458 * page/animation/CSSPropertyAnimation.cpp:
1459 * platform/chromium/PasteboardChromium.cpp:
1460 * platform/efl/ErrorsEfl.cpp:
1461 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1462 * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
1463 * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
1464 * platform/gtk/ErrorsGtk.cpp:
1465 * platform/gtk/PasteboardGtk.cpp:
1466 * platform/gtk/PasteboardHelper.h:
1467 * platform/mac/ClipboardMac.h:
1468 * platform/mac/ClipboardMac.mm:
1469 * platform/mac/HTMLConverter.mm:
1470 * platform/mac/PasteboardMac.mm:
1471 * platform/network/AuthenticationChallengeBase.cpp:
1472 * platform/network/cf/CookieJarCFNet.cpp:
1473 * platform/network/cf/ResourceRequestCFNet.cpp:
1474 * platform/network/mac/CookieStorageMac.mm:
1475 * platform/qt/PasteboardQt.cpp:
1476 * plugins/DOMMimeType.cpp:
1477 * plugins/PluginView.cpp:
1478 * rendering/HitTestResult.cpp:
1479 * rendering/InlineFlowBox.cpp:
1480 * rendering/RenderBox.cpp:
1481 * rendering/RenderEmbeddedObject.cpp:
1482 * rendering/RenderImage.cpp:
1483 * rendering/RenderImageResourceStyleImage.cpp:
1484 * rendering/RenderLayer.cpp:
1485 * rendering/RenderLayerBacking.cpp:
1486 * rendering/RenderLayerFilterInfo.h:
1487 * rendering/RenderListItem.cpp:
1488 * rendering/RenderListMarker.cpp:
1489 * rendering/RenderSnapshottedPlugIn.cpp:
1490 * rendering/RenderTableCol.cpp:
1491 * rendering/RenderTableRow.cpp:
1492 * rendering/RenderTableSection.cpp:
1493 * rendering/style/StyleCachedShader.h:
1494 * svg/SVGFEImageElement.h:
1495 * svg/SVGFontFaceUriElement.h:
1496 * svg/SVGImageLoader.cpp:
1497 * svg/SVGUseElement.cpp:
1498 * svg/SVGUseElement.h:
1499 * svg/graphics/SVGImageCache.cpp:
1500 * testing/MockPagePopupDriver.cpp:
1501 * xml/XSLStyleSheet.h:
1502 * xml/XSLTProcessorLibxslt.cpp:
1503 * xml/parser/XMLDocumentParser.cpp:
1504 * xml/parser/XMLDocumentParser.h:
1505 * xml/parser/XMLDocumentParserLibxml2.cpp:
1506 Many self-evident changes - removing unnecessary header includes, adding smaller
1507 more local ones that are now necessary.
1509 2013-03-01 David Hyatt <hyatt@apple.com>
1511 [New Multicolumn] Transformed objects inside fragmented transparent objects don't render
1512 https://bugs.webkit.org/show_bug.cgi?id=111221.
1514 Reviewed by Simon Fraser.
1516 Improve transparencyClipBox so that it understands when moving into descendants
1517 that it does in fact have to break up the transformed clip rect across the
1520 Make sure when handling fragmented transforms using multiple paints that
1521 the test that determines the extent of the transform within the fragments
1522 uses transparencyClipBox. This gives us an accurate set of columns that the
1523 final transformed result will paint across.
1525 Tests: fast/multicol/mixed-opacity-fixed-test.html
1526 fast/multicol/mixed-opacity-test.html
1527 fast/multicol/transform-inside-opacity.html
1529 * rendering/RenderLayer.cpp:
1530 (WebCore::transparencyClipBox):
1531 (WebCore::expandClipRectForDescendantsAndReflection):
1532 Break transformed boxes up into fragments when they are
1533 being requested by an ancestor.
1535 (WebCore::RenderLayer::collectFragments):
1536 (WebCore::RenderLayer::paintTransformedLayerIntoFragments):
1537 (WebCore::RenderLayer::hitTestTransformedLayerInFragments):
1538 * rendering/RenderLayer.h:
1540 Modify collectFragments so that we pass in the correct range
1541 within the columns that can possibly cover the fragmented
1544 2013-03-01 Ilya Tikhonovsky <loislo@chromium.org>
1546 Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
1547 https://bugs.webkit.org/show_bug.cgi?id=110943
1549 Reviewed by Yury Semikhatsky.
1551 Unfortunately in many cases raw pointer may point to an object that has been deleted.
1552 There is no working solution to solve this problem in general.
1553 It could be solved only on case by case basis.
1555 * inspector/HeapGraphSerializer.cpp:
1556 (WebCore::HeapGraphSerializer::HeapGraphSerializer):
1557 (WebCore::HeapGraphSerializer::reportLeaf):
1558 * loader/cache/MemoryCache.cpp:
1559 (WebCore::MemoryCache::reportMemoryUsage):
1560 * platform/graphics/BitmapImage.cpp:
1561 (WebCore::FrameData::reportMemoryUsage):
1562 * platform/graphics/skia/MemoryInstrumentationSkia.cpp:
1563 (reportMemoryUsage):
1565 2013-03-01 Kentaro Hara <haraken@chromium.org>
1567 Style recalculation takes too long when adding whitespace text nodes
1568 https://bugs.webkit.org/show_bug.cgi?id=110786
1570 Reviewed by Darin Adler.
1572 // This takes 216 msec.
1573 for (var i = 0; i < 1500; ++i) {
1574 document.body.appendChild(document.createTextNode('x'));
1575 document.body.appendChild(document.createElement('div'));
1576 document.body.appendChild(document.createTextNode('x'));
1579 // But this takes 25.3 seconds.
1580 for (var i = 0; i < 1500; ++i) {
1581 document.body.appendChild(document.createTextNode(' '));
1582 document.body.appendChild(document.createElement('div'));
1583 document.body.appendChild(document.createTextNode(' '));
1586 The reason is that we do not create renderers for empty text
1587 nodes and thus we are hitting the worst O(N^2) case in Node::attach().
1588 (See FIXME in Node::attach().)
1590 This patch adds a logic to bail out the loop to avoid the O(N^2) case.
1591 Specifically, the patch bails out the loop if we encounter a text node
1592 for which we again decided not to create a renderer. This bail out is
1593 reasonable because the fact that we again decided not to create a renderer
1594 for the text node indicates that there will be no affect of the result
1595 of Text::textRendererIsNeeded() of the rest of the sibling nodes.
1597 Performance test: https://bugs.webkit.org/attachment.cgi?id=190545
1598 Performance result in Chromium/Linux: 25.3 sec => 48 msec !
1600 Test: perf/append-text-nodes-without-renderers.html (for performance)
1601 fast/dynamic/create-renderer-for-whitespace-only-text.html (for correctness)
1603 The loop was introduced in r29054. We have to make sure that
1604 all layout tests that were updated in r29054 pass with this patch.
1605 See http://trac.webkit.org/changeset/29054.
1608 (WebCore::Node::attach):
1610 2013-03-01 Jason Anderssen <janderssen@gmail.com>
1612 Moved markerTextForListItem from TestRunner to Internals
1613 https://bugs.webkit.org/show_bug.cgi?id=110939
1615 Reviewed by Benjamin Poulain.
1617 TestRunner framework is an old way of testing webkit, it would be
1618 better to incorporate the testing frame directly into the WebCore itself
1619 as to make it more compatible with WK2.
1621 * testing/Internals.cpp:
1622 (WebCore::Internals::markerTextForListItem):
1624 * testing/Internals.h:
1625 * testing/Internals.idl:
1627 2013-03-01 Elliott Sprehn <esprehn@gmail.com>
1629 Don't leak Documents when using MutationObserver from extensions
1630 https://bugs.webkit.org/show_bug.cgi?id=111234
1632 Reviewed by Adam Barth.
1634 MutationObserverCallback holds a WorldContextHandle which secretly isn't
1635 a handle to anything when it's for the main world. When it's for a non-main
1636 world though, like those used in extensions, it becomes a strong reference
1637 to the v8::Context which results in leaks by creating cycles:
1639 MutationObserver -> Callback -> World -> Document -> Node -> MutationObserver.
1641 Instead we should keep a RefPtr to a DOMWrapperWorld in the callback and then
1642 get the v8::Context from that inside handleEvent.
1644 Tests: ManualTests/leak-observer-nonmain-world.html
1646 * bindings/v8/V8Binding.cpp:
1647 (WebCore::toV8Context): Added overload that takes a DOMWrapperWorld.
1648 * bindings/v8/V8Binding.h:
1649 * bindings/v8/V8MutationCallback.cpp:
1650 (WebCore::V8MutationCallback::V8MutationCallback):
1651 (WebCore::V8MutationCallback::handleEvent):
1652 * bindings/v8/V8MutationCallback.h:
1653 (V8MutationCallback):
1655 2013-03-01 Bear Travis <betravis@adobe.com>
1657 [css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
1658 https://bugs.webkit.org/show_bug.cgi?id=110995
1660 Reviewed by Julien Chaffraix.
1662 This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
1663 which enables us to move away from the global ExclusionShapeInsideInfo map.
1664 Some additional refactoring was done to remove ExclusionShapeInsideInfo's
1665 dependency on InlineIterator, which depended on RenderBlock. This work required
1666 adding a new LineSegmentIterator struct.
1668 Refactoring, no new tests.
1670 * rendering/ExclusionShapeInsideInfo.cpp:
1672 (WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
1673 constructor to the .cpp file, as InlineIterator is now forward declared in
1675 (WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
1676 the .cpp file, as RenderBlock is now forward declared in the .h file.
1677 * rendering/ExclusionShapeInsideInfo.h:
1679 (LineSegmentIterator): A simple struct for containing segment positions for
1681 (WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
1682 (LineSegmentRange): Transitioning to store LineSegmentIterator.
1683 (WebCore::LineSegmentRange::LineSegmentRange): Ditto.
1684 (ExclusionShapeInsideInfo):
1685 * rendering/RenderBlock.cpp:
1686 (WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
1687 its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
1689 (WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
1690 the RenderBlockRareData struct rather than the global map.
1691 * rendering/RenderBlock.h:
1693 (WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
1694 is present if the shape-inside style is set.
1695 (WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
1697 (WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
1698 for the current block.
1699 (RenderBlockRareData): Add the ExclusionShapeInsideInfo member.
1700 * rendering/RenderBlockLineLayout.cpp:
1701 (WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
1702 layout based on the stored LineSegmentIterators.
1704 2013-03-01 Terry Anderson <tdanderson@chromium.org>
1706 EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
1707 so its behavior matches other user-initiated scrolls
1708 https://bugs.webkit.org/show_bug.cgi?id=109769
1710 Reviewed by James Robinson.
1712 To ensure that the scrolling behavior of GestureScrollUpdate events are consistent with
1713 the scrolling behavior of mousewheel events, use the existing user-generated scroll logic
1714 instead of calling into RenderLayer::scrollByRecursively(). This patch fixes the bug
1715 reported in https://bugs.webkit.org/show_bug.cgi?id=109316, where the example page can
1716 be scrolled using touch but cannot be scrolled using mousewheels.
1718 Note that this patch does not use any of the mousewheel event-handling code.
1720 Tests: fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html
1721 fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
1722 fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html
1723 fast/events/touch/gesture/touch-gesture-noscroll-body.html
1725 * page/EventHandler.cpp:
1726 (WebCore::EventHandler::clear):
1727 (WebCore::EventHandler::handleGestureEvent):
1728 (WebCore::EventHandler::handleGestureScrollBegin):
1729 (WebCore::EventHandler::handleGestureScrollUpdate):
1730 (WebCore::EventHandler::sendScrollEventToView):
1731 By calling this function at the start of handleGestureScrollUpdate() in the case
1732 where |m_scrollGestureHandlingNode| is null, we ensure that the scroll updates
1733 can still scroll the page itself, if possible.
1735 (WebCore::EventHandler::clearGestureScrollNodes):
1736 * page/EventHandler.h:
1738 * platform/PlatformWheelEvent.h:
1739 (WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):
1741 2013-03-01 Alec Flett <alecflett@chromium.org>
1743 IndexedDB: Avoid ScriptValue copies in IDBAny
1744 https://bugs.webkit.org/show_bug.cgi?id=111002
1746 Reviewed by Adam Barth.
1748 This avoids some v8 handle thrashing in the long term,
1749 and protects us against some crashes in the short term.
1751 The crashes will be fixed in
1752 https://bugs.webkit.org/show_bug.cgi?id=110206.
1754 * Modules/indexeddb/IDBAny.cpp:
1755 (WebCore::IDBAny::createNull):
1756 (WebCore::IDBAny::createString):
1757 (WebCore::IDBAny::IDBAny):
1758 (WebCore::IDBAny::scriptValue):
1759 * Modules/indexeddb/IDBAny.h:
1760 (WebCore::IDBAny::create):
1762 (WebCore::IDBAny::keyPath):
1763 * bindings/v8/custom/V8IDBAnyCustom.cpp:
1767 2013-03-01 Victor Carbune <vcarbune@chromium.org>
1769 Support padding, margin and border for internal UA cue styling
1770 https://bugs.webkit.org/show_bug.cgi?id=110703
1772 Reviewed by Eric Carlson.
1774 For some particular user agent styling this allows the possibility
1775 of making the window around the cue text bigger to match some user
1776 styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).
1778 These properties *cannot* be set through by using the ::cue
1779 pseudo-element and, as specified, are used only internally.
1781 Note: This patch is identical to the previously commited one,
1782 as it was rolled back without related tests failing.
1784 Test: media/track/track-cue-rendering-with-padding.html
1786 * css/mediaControls.css:
1787 (video::-webkit-media-text-track-display): Set the CSS box model
1788 to include in the specified width or height the values of
1789 padding / margin / border by using -webkit-box-sizing and avoid
1790 overflow over 100% width because of having these properties set.
1791 * rendering/RenderTextTrackCue.cpp:
1792 (WebCore::RenderTextTrackCue::isOutside): To not interfere with
1793 the regular WebVTT positioning algorithm, the check is done for
1794 the absolute content box.
1795 (WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
1796 an extra adjustment step to accomodate vertical padding (and not
1797 overflow the cue container)
1799 2013-03-01 Andy Estes <aestes@apple.com>
1801 REGRESSION (r125809): CFStrings created via StringImpl::createCFString() might reference freed memory when Objective-C garbage collection is enabled
1802 https://bugs.webkit.org/show_bug.cgi?id=111219
1804 Reviewed by Benjamin Poulain.
1806 StringImpl::createCFString() uses CFStringCreateWithBytesNoCopy() in
1807 order to create CFString without making an unnecessary copy. In order
1808 to ensure that the the StringImpl's backing buffer isn't deallocated
1809 while the CFString is still alive, we use a custom CFAllocator to
1810 ref/deref the StringImpl at the appropriate times.
1812 However, custom allocators aren't supported when Objective-C garbage
1813 collection is enabled, so in this case we use the default CF allocator.
1814 Since we can't guarantee the lifetime of the StringImpl in this case,
1815 we should just fall back to copying the string, as we did prior to r125809.
1817 * platform/text/cf/StringImplCF.cpp:
1818 (garbageCollectionEnabled): Moved the check for whether garbage
1819 collection is enabled from StringWrapperCFAllocator::create() to here.
1820 (WTF::StringWrapperCFAllocator::create): Call garbageCollectionEnabled().
1821 (WTF::StringImpl::createCFString): If garbage collection is enabled,
1822 call the variants of CFStringCreate that copy the string.
1824 2013-03-01 Roger Fong <roger_fong@apple.com>
1826 Unreviewed AppleWin build fix.
1828 * platform/network/cf/ResourceHandleCFNet.cpp:
1829 (WebCore::ResourceHandle::createCFURLConnection):
1831 2013-03-01 Martin Robinson <mrobinson@igalia.com>
1833 [GTK] Allow sharing the WebCore include list with the Chromium build
1834 https://bugs.webkit.org/show_bug.cgi?id=110241
1836 Reviewed by Dirk Pranke.
1838 * WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
1839 * WebCore.gypi: Added shared include directories.
1841 2013-03-01 Alexey Proskuryakov <ap@apple.com>
1843 Make in-memory blobs work in NetworkProcess
1844 https://bugs.webkit.org/show_bug.cgi?id=111132
1846 Reviewed by Sam Weinig.
1849 * WebCore.xcodeproj/project.pbxproj:
1850 Exported functions now needed by WebKit2, and made some headers Private instead
1853 2013-03-01 Eric Seidel <eric@webkit.org>
1855 Threaded HTML Parser has an extra copy of every byte from the network
1856 https://bugs.webkit.org/show_bug.cgi?id=111135
1858 Reviewed by Adam Barth.
1860 Every LayoutTest executes this code in threaded parsing mode.
1862 * dom/DecodedDataDocumentParser.cpp:
1863 (WebCore::DecodedDataDocumentParser::appendBytes):
1864 - Pass ownership of the decoded string to the parser.
1865 (WebCore::DecodedDataDocumentParser::flush):
1867 * dom/DecodedDataDocumentParser.h:
1868 (DecodedDataDocumentParser):
1870 (WebCore::Document::setContent):
1871 * dom/DocumentParser.h:
1873 * dom/RawDataDocumentParser.h:
1874 (WebCore::RawDataDocumentParser::append):
1875 * html/FTPDirectoryDocument.cpp:
1876 (FTPDirectoryDocumentParser):
1877 (WebCore::FTPDirectoryDocumentParser::append):
1878 * html/parser/HTMLDocumentParser.cpp:
1879 (WebCore::HTMLDocumentParser::append):
1880 * html/parser/HTMLDocumentParser.h:
1881 (HTMLDocumentParser):
1882 * html/parser/HTMLViewSourceParser.cpp:
1883 (WebCore::HTMLViewSourceParser::append):
1884 * html/parser/HTMLViewSourceParser.h:
1885 (HTMLViewSourceParser):
1886 * html/parser/TextDocumentParser.cpp:
1887 (WebCore::TextDocumentParser::append):
1888 * html/parser/TextDocumentParser.h:
1889 (TextDocumentParser):
1890 * loader/DocumentWriter.cpp:
1891 (WebCore::DocumentWriter::replaceDocument):
1892 * xml/parser/XMLDocumentParser.cpp:
1893 (WebCore::XMLDocumentParser::append):
1894 * xml/parser/XMLDocumentParser.h:
1895 (XMLDocumentParser):
1896 * xml/parser/XMLDocumentParserLibxml2.cpp:
1897 (WebCore::XMLDocumentParser::resumeParsing):
1899 2013-03-01 David Hyatt <hyatt@apple.com>
1901 [New Multicolumn] Change inRenderFlowThread to follow containing block chain
1902 https://bugs.webkit.org/show_bug.cgi?id=111206
1904 Reviewed by Simon Fraser.
1906 This patch removes inRenderFlowThread and changes enclosingRenderFlowThread()
1907 to flowThreadContainingBlock(). flowThreadContainingBlock() now follows
1908 the containing block chain instead of the parent chain when outside of layout.
1909 (It already did the right thing when called during layout.)
1911 By removing inRenderFlowThread (which was following the parent chain), all
1912 code that is checking for flow thread containment now correctly uses the
1913 containing block chain. This allows for content to escape in-flow flow threads
1914 and do the right thing without asserting.
1916 Test: fast/multicol/positioned-outside-of-columns.html
1918 * dom/WebKitNamedFlow.cpp:
1919 (WebCore::inFlowThread):
1920 (WebCore::WebKitNamedFlow::getRegionsByContent):
1921 * rendering/RenderBlock.cpp:
1922 (WebCore::RenderBlock::removeLeftoverAnonymousBlock):
1923 (WebCore::RenderBlock::collapseAnonymousBoxChild):
1924 (WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize):
1925 (WebCore::RenderBlock::computeRegionRangeForBlock):
1926 (WebCore::RenderBlock::layoutBlock):
1927 (WebCore::RenderBlock::computeOverflow):
1928 (WebCore::RenderBlock::determineLogicalLeftPositionForChild):
1929 (WebCore::RenderBlock::computeLogicalLocationForFloat):
1930 (WebCore::RenderBlock::logicalLeftOffsetForContent):
1931 (WebCore::RenderBlock::logicalRightOffsetForContent):
1932 (WebCore::RenderBlock::hasNextPage):
1933 (WebCore::RenderBlock::applyBeforeBreak):
1934 (WebCore::RenderBlock::applyAfterBreak):
1935 (WebCore::RenderBlock::pageLogicalTopForOffset):
1936 (WebCore::RenderBlock::pageLogicalHeightForOffset):
1937 (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
1938 (WebCore::RenderBlock::adjustForUnsplittableChild):
1939 (WebCore::RenderBlock::adjustLinePositionForPagination):
1940 (WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
1941 (WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
1942 (WebCore::RenderBlock::regionAtBlockOffset):
1943 (WebCore::RenderBlock::setStaticInlinePositionForChild):
1944 (WebCore::RenderBlock::logicalWidthChangedInRegions):
1945 (WebCore::RenderBlock::clampToStartAndEndRegions):
1946 * rendering/RenderBlock.h:
1948 * rendering/RenderBlockLineLayout.cpp:
1949 (WebCore::layoutExclusionShapeInsideInfo):
1950 (WebCore::LineLayoutState::LineLayoutState):
1951 (WebCore::LineLayoutState::flowThread):
1952 (WebCore::LineLayoutState::setFlowThread):
1954 (WebCore::RenderBlock::layoutRunsAndFloatsInRange):
1955 (WebCore::RenderBlock::linkToEndLineIfNeeded):
1956 (WebCore::RenderBlock::layoutInlineChildren):
1957 (WebCore::RenderBlock::determineStartPosition):
1958 (WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
1959 * rendering/RenderBox.cpp:
1960 (WebCore::RenderBox::clearRenderBoxRegionInfo):
1961 (WebCore::RenderBox::renderBoxRegionInfo):
1962 (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
1963 (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
1964 (WebCore::RenderBox::computePositionedLogicalWidth):
1965 (WebCore::RenderBox::computePositionedLogicalHeight):
1966 * rendering/RenderDeprecatedFlexibleBox.cpp:
1967 (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
1968 * rendering/RenderFlexibleBox.cpp:
1969 (WebCore::RenderFlexibleBox::layoutBlock):
1970 * rendering/RenderFlowThread.cpp:
1971 (WebCore::RenderFlowThread::objectInFlowRegion):
1972 * rendering/RenderGrid.cpp:
1973 (WebCore::RenderGrid::layoutBlock):
1974 * rendering/RenderInline.cpp:
1975 (WebCore::RenderInline::updateAlwaysCreateLineBoxes):
1976 * rendering/RenderLayer.cpp:
1977 (WebCore::accumulateOffsetTowardsAncestor):
1978 * rendering/RenderLayerCompositor.cpp:
1979 (WebCore::RenderLayerCompositor::canBeComposited):
1980 * rendering/RenderMedia.cpp:
1981 (WebCore::RenderMedia::layout):
1982 * rendering/RenderObject.cpp:
1983 (WebCore::RenderObject::locateFlowThreadContainingBlock):
1984 (WebCore::RenderObject::containerForRepaint):
1985 (WebCore::RenderObject::willBeRemovedFromTree):
1986 (WebCore::RenderObject::removeFromRenderFlowThread):
1987 (WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
1988 * rendering/RenderObject.h:
1990 (WebCore::RenderObject::flowThreadContainingBlock):
1991 * rendering/RenderRegion.cpp:
1992 (WebCore::RenderRegion::setObjectStyleInRegion):
1993 * rendering/RenderView.cpp:
1994 (WebCore::RenderView::addChild):
1995 (WebCore::RenderView::initializeLayoutState):
1996 (WebCore::RenderView::setSelection):
1997 * rendering/RenderView.h:
1998 (WebCore::RenderView::pushLayoutState):
1999 * rendering/RootInlineBox.cpp:
2000 (WebCore::RootInlineBox::containingRegion):
2001 (WebCore::RootInlineBox::setContainingRegion):
2003 2013-02-28 Sam Weinig <sam@webkit.org>
2005 Add SPI for marking a WebView as doing things on behalf of another process
2006 https://bugs.webkit.org/show_bug.cgi?id=111125
2008 Reviewed by Alexey Proskuryakov.
2010 * platform/network/NetworkingContext.h:
2011 (NetworkingContext):
2012 * platform/network/cf/ResourceHandleCFNet.cpp:
2013 (WebCore::ResourceHandle::createCFURLConnection):
2014 * platform/network/mac/ResourceHandleMac.mm:
2015 (WebCore::ResourceHandle::createNSURLConnection):
2016 Set the sourceApplicationAuditData on the URL connection if available.
2018 2013-03-01 Brent Fulgham <bfulgham@webkit.org>
2020 [Windows] Unreviewed VS2010 build fix.
2022 * WebCore.vcxproj/WebCore.vcxproj: Add missing TimelineTraceEventProcessor
2023 files to the project.
2024 * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
2026 2013-03-01 Bear Travis <betravis@adobe.com>
2028 [css exclusions] setting shape-inside on a parent does not relayout child blocks' inline content
2029 https://bugs.webkit.org/show_bug.cgi?id=108128
2031 Reviewed by David Hyatt.
2033 Ensure that blocks lay out when their parent's shape-inside changes.
2034 ExclusionShapeInsideInfo now stores an additional flag indicating whether
2035 the shape has changed and its block's children require layout. Each block
2036 can look up the flag via LayoutState to determine whether it needs to lay
2039 Test: fast/exclusions/shape-inside/shape-inside-dynamic-nested.html
2041 * rendering/ExclusionShapeInfo.h:
2042 (WebCore::ExclusionShapeInfo::shapeSizeDirty): Add a method to determine
2043 if the shape has changed.
2044 (ExclusionShapeInfo):
2045 * rendering/ExclusionShapeInsideInfo.h:
2046 (WebCore::ExclusionShapeInsideInfo::setNeedsLayout): Set the flag indicating
2047 layout is necessary.
2048 (WebCore::ExclusionShapeInsideInfo::needsLayout): Retrieve the layout flag.
2049 (ExclusionShapeInsideInfo):
2050 (WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Initialize
2052 * rendering/RenderBlock.cpp:
2053 (WebCore::exclusionInfoRequiresRelayout): Return true if the shape info should
2054 cause a relayout. Also update the needsLayout flag on the ExclusionShapeInsideInfo.
2056 (WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize): Return a boolean
2057 indicating whether regions or exclusions updates should cause a relayout.
2058 (WebCore::RenderBlock::layoutBlock): Relayout children if the shape inside has
2060 * rendering/RenderBlock.h:
2062 * rendering/RenderBlockLineLayout.cpp:
2063 (WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Changing to be a
2065 (WebCore::LineWidth::LineWidth): Changing to use class method.
2066 (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
2067 (WebCore::constructBidiRunsForLine): Ditto.
2068 (WebCore::RenderBlock::layoutRunsAndFloatsInRange): Ditto.
2069 (WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.
2071 2013-03-01 Uday Kiran <udaykiran@motorola.com>
2073 getComputedStyle not implemented for -webkit-column-rule shorthand
2074 https://bugs.webkit.org/show_bug.cgi?id=111203
2076 Reviewed by Alexis Menard.
2078 Implement getComputedStyle for -webkit-column-rule property.
2080 Test: fast/css/getComputedStyle/getComputedStyle-column-rule.html
2082 * css/CSSComputedStyleDeclaration.cpp:
2083 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2085 2013-02-28 David Hyatt <hyatt@apple.com>
2087 REGRESSION(r144318) 1-7% perf. regression on SVG/SvgHitTesting
2088 https://bugs.webkit.org/show_bug.cgi?id=111117
2090 Make sure the allocated vector has a capacity of 1, since that is
2091 far and away the most common case.
2093 Reviewed by Andreas Kling.
2095 * rendering/RenderFlowThread.h:
2097 * rendering/RenderLayer.h:
2099 * rendering/RenderMultiColumnSet.cpp:
2100 (WebCore::RenderMultiColumnSet::collectLayerFragments):
2101 * rendering/RenderMultiColumnSet.h:
2102 * rendering/RenderRegion.h:
2104 (WebCore::RenderRegion::collectLayerFragments):
2106 2013-03-01 Enrica Casucci <enrica@apple.com>
2108 Crash at WebCore::SharedBuffer::hasPlatformData writing an image to the pasteboard.
2109 https://bugs.webkit.org/show_bug.cgi?id=111211.
2110 <rdar://problem/8772758>
2112 Reviewed by Ryosuke Niwa.
2114 This is a speculative fix since we don't have a solid repro case.
2115 Adding null check every time we build a SharedBuffer from an NSData
2116 we have obtained manipulating data from the pasteboard.
2118 * platform/mac/PasteboardMac.mm:
2119 (WebCore::writeFileWrapperAsRTFDAttachment):
2120 (WebCore::Pasteboard::writeImage):
2122 2013-03-01 Enrica Casucci <enrica@apple.com>
2124 Crash at WebCore::SharedBuffer::hasPlatformData during paste.
2125 https://bugs.webkit.org/show_bug.cgi?id=111207.
2126 <rdar://problem/13024528>
2128 Reviewed by Ryosuke Niwa.
2130 This is a speculative fix since we don't have a solid repro case.
2131 Adding null check every time we get a SharedBuffer from the pasteboard.
2133 * platform/mac/PasteboardMac.mm:
2134 (WebCore::Pasteboard::plainText):
2135 (WebCore::documentFragmentWithRTF):
2137 2013-03-01 Alexey Proskuryakov <ap@apple.com>
2139 Build fix for builds with BLOB disabled. This fixes it for me on Mac at least.
2141 * platform/network/BlobRegistryImpl.cpp:
2143 2013-03-01 peavo@outlook.com <peavo@outlook.com>
2145 [Curl] Session cookies should not be persistent.
2146 https://bugs.webkit.org/show_bug.cgi?id=111060
2148 Reviewed by Brent Fulgham.
2150 Curl saves both persistent cookies, and session cookies to the cookie file.
2151 The session cookies should be deleted before starting a new session.
2153 * platform/network/curl/ResourceHandleManager.cpp:
2154 (WebCore::ResourceHandleManager::ResourceHandleManager): Call method to initialize cookie session.
2155 (WebCore::ResourceHandleManager::initCookieSession): Added method to initialize cookie session.
2156 * platform/network/curl/ResourceHandleManager.h: Added method to initialize cookie session.
2158 2013-03-01 Vsevolod Vlasov <vsevik@chromium.org>
2160 Web Inspector: Navigator should show tree element for each folder in the source path.
2161 https://bugs.webkit.org/show_bug.cgi?id=108943
2163 Reviewed by Pavel Feldman.
2165 NavigatorView now renders tree element for each folder in uiSourceCode uri.
2166 Merging several folders into one tree elememnt when folder has only one folder as a child is supported.
2167 ScriptsNavigator has horizontal scroll now.
2168 Projects are shown in ScriptsNavigator by their displayName. This allows us to show several root file system folders
2169 with the same name in the navigator (e.g. 'Source/WebCore/inspector' and 'LayoutTests/inspector').
2171 Test: inspector/debugger/navigator-view.html: Renamed from scripts-file-selector.html
2173 * English.lproj/localizedStrings.js:
2174 * inspector/front-end/NavigatorView.js:
2175 (WebInspector.NavigatorView):
2176 (WebInspector.NavigatorView.iconClassForType):
2177 (WebInspector.NavigatorView.prototype.addUISourceCode):
2178 (WebInspector.NavigatorView.prototype._getProjectNode):
2179 (WebInspector.NavigatorView.prototype._createProjectNode):
2180 (WebInspector.NavigatorView.prototype._getOrCreateProjectNode):
2181 (WebInspector.NavigatorView.prototype._getFolderNode):
2182 (WebInspector.NavigatorView.prototype._createFolderNode):
2183 (WebInspector.NavigatorView.prototype._getOrCreateFolderNode):
2184 (WebInspector.NavigatorView.prototype._getUISourceCodeParentNode):
2185 (WebInspector.NavigatorView.prototype._getOrCreateUISourceCodeParentNode):
2186 (WebInspector.NavigatorView.prototype.revealUISourceCode):
2187 (WebInspector.NavigatorView.prototype.removeUISourceCode):
2188 (WebInspector.NavigatorView.prototype.rename):
2189 (WebInspector.NavigatorView.prototype.reset):
2191 (WebInspector.NavigatorTreeOutline._treeElementsCompare):
2192 (WebInspector.BaseNavigatorTreeElement):
2193 (WebInspector.BaseNavigatorTreeElement.prototype.type):
2194 (WebInspector.NavigatorFolderTreeElement):
2195 (WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):
2196 (WebInspector.NavigatorFolderTreeElement.prototype.onattach):
2197 (WebInspector.NavigatorSourceTreeElement):
2198 (WebInspector.NavigatorTreeNode):
2199 (WebInspector.NavigatorTreeNode.prototype.treeElement):
2200 (WebInspector.NavigatorTreeNode.prototype.dispose):
2201 (WebInspector.NavigatorTreeNode.prototype.isRoot):
2202 (WebInspector.NavigatorTreeNode.prototype.hasChildren):
2203 (WebInspector.NavigatorTreeNode.prototype.populate):
2204 (WebInspector.NavigatorTreeNode.prototype.wasPopulated):
2205 (WebInspector.NavigatorTreeNode.prototype.didAddChild):
2206 (WebInspector.NavigatorTreeNode.prototype.willRemoveChild):
2207 (WebInspector.NavigatorTreeNode.prototype.isPopulated):
2208 (WebInspector.NavigatorTreeNode.prototype.isEmpty):
2209 (WebInspector.NavigatorTreeNode.prototype.child):
2210 (WebInspector.NavigatorTreeNode.prototype.children):
2211 (WebInspector.NavigatorTreeNode.prototype.appendChild):
2212 (WebInspector.NavigatorTreeNode.prototype.removeChild):
2213 (WebInspector.NavigatorTreeNode.prototype.reset):
2214 (WebInspector.NavigatorRootTreeNode):
2215 (WebInspector.NavigatorRootTreeNode.prototype.isRoot):
2216 (WebInspector.NavigatorRootTreeNode.prototype.treeElement):
2217 (WebInspector.NavigatorRootTreeNode.prototype.wasPopulated):
2218 (WebInspector.NavigatorRootTreeNode.prototype.didAddChild):
2219 (WebInspector.NavigatorRootTreeNode.prototype.willRemoveChild):
2220 (WebInspector.NavigatorUISourceCodeTreeNode):
2221 (WebInspector.NavigatorUISourceCodeTreeNode.prototype.treeElement):
2222 (WebInspector.NavigatorUISourceCodeTreeNode.prototype.updateTitle):
2223 (WebInspector.NavigatorUISourceCodeTreeNode.prototype.hasChildren):
2224 (WebInspector.NavigatorUISourceCodeTreeNode.prototype.dispose):
2225 (WebInspector.NavigatorUISourceCodeTreeNode.prototype._titleChanged):
2226 (WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyChanged):
2227 (WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyCommitted):
2228 (WebInspector.NavigatorUISourceCodeTreeNode.prototype._formattedChanged):
2229 (WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):
2230 (WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.commitHandler):
2231 (WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.cancelHandler):
2232 (WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.afterEditing):
2233 (WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename):
2234 (WebInspector.NavigatorFolderTreeNode):
2235 (WebInspector.NavigatorFolderTreeNode.prototype.treeElement):
2236 (WebInspector.NavigatorFolderTreeNode.prototype._createTreeElement):
2237 (WebInspector.NavigatorFolderTreeNode.prototype.wasPopulated):
2238 (WebInspector.NavigatorFolderTreeNode.prototype._addChildrenRecursive):
2239 (WebInspector.NavigatorFolderTreeNode.prototype._shouldMerge):
2240 (WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
2241 (WebInspector.NavigatorFolderTreeNode.prototype.willRemoveChild):
2242 * inspector/front-end/ScriptsNavigator.js:
2243 * inspector/front-end/SimpleWorkspaceProvider.js:
2244 (WebInspector.SimpleProjectDelegate.prototype.displayName):
2245 * inspector/front-end/navigatorView.css:
2247 (.navigator .base-navigator-tree-element-title):
2248 (.navigator-tabbed-pane .navigator-container):
2250 2013-03-01 Arvid Nilsson <anilsson@rim.com>
2252 [BlackBerry] Upstream BlackBerry::Platform::Graphics::GraphicsContext integration related changes in platform/graphics/blackberry
2253 https://bugs.webkit.org/show_bug.cgi?id=111072
2255 Reviewed by Rob Buis.
2257 BlackBerry PR 293208
2259 This patch contains contributions from many members of the BlackBerry
2283 Covered by existing tests.
2285 * platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
2286 (WebCore::CanvasLayerWebKitThread::deleteTextures):
2287 (CanvasLayerCompositingThreadClient):
2288 (WebCore::CanvasLayerCompositingThreadClient::layerCompositingThreadDestroyed):
2289 (WebCore::CanvasLayerCompositingThreadClient::layerVisibilityChanged):
2290 (WebCore::CanvasLayerCompositingThreadClient::uploadTexturesIfNeeded):
2291 (WebCore::CanvasLayerCompositingThreadClient::clearBuffer):
2293 (WebCore::CanvasLayerCompositingThreadClient::CanvasLayerCompositingThreadClient):
2294 (WebCore::CanvasLayerCompositingThreadClient::drawTextures):
2295 (WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
2296 (WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
2297 (WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
2298 (WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
2299 (WebCore::CanvasLayerWebKitThread::clearBuffer):
2300 * platform/graphics/blackberry/CanvasLayerWebKitThread.h:
2302 (WebCore::CanvasLayerWebKitThread::create):
2303 (CanvasLayerWebKitThread):
2304 * platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
2305 (WebCore::DisplayRefreshMonitor::displayLinkFired):
2306 * platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
2307 (WebCore::DrawingBuffer::DrawingBuffer):
2309 (WebCore::DrawingBuffer::publishToPlatformLayer):
2310 (WebCore::DrawingBuffer::platformLayer):
2311 * platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
2312 (WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
2313 (WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
2314 (WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
2315 (WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
2316 (WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
2317 (WebCore::EGLImageLayerCompositingThreadClient::setTextureAccessor):
2318 * platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:
2320 (EGLImageLayerCompositingThreadClient):
2321 (WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):
2322 * platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
2323 (WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
2324 (WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
2325 (WebCore::EGLImageLayerWebKitThread::updateFrontBuffer):
2326 (WebCore::EGLImageLayerWebKitThread::deleteFrontBuffer):
2327 (WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
2328 (WebCore::EGLImageLayerWebKitThread::createTextureIfNeeded):
2329 (WebCore::EGLImageLayerWebKitThread::blitToFrontBuffer):
2330 * platform/graphics/blackberry/EGLImageLayerWebKitThread.h:
2332 (EGLImageLayerWebKitThread):
2333 * platform/graphics/blackberry/FloatRectBlackBerry.cpp:
2334 (WebCore::FloatRect::normalized):
2336 * platform/graphics/blackberry/FontCacheBlackberry.cpp: Removed.
2337 * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
2338 (WebCore::GraphicsContext3D::GraphicsContext3D):
2339 (WebCore::GraphicsContext3D::paintToCanvas):
2340 (WebCore::GraphicsContext3D::getImageData):
2342 * platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
2343 (WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
2344 (WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
2345 (WebCore::GraphicsLayerBlackBerry::clearBackgroundColor):
2347 (WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
2348 (WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
2349 (WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
2350 (WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
2351 (WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
2352 * platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
2353 (GraphicsLayerBlackBerry):
2354 (WebCore::GraphicsLayerBlackBerry::notifySyncRequired):
2355 * platform/graphics/blackberry/ImageBlackBerry.cpp:
2356 (WebCore::ImageFrame::asNewNativeImage):
2358 (WebCore::FrameData::clear):
2359 (WebCore::BitmapImage::BitmapImage):
2360 (WebCore::BitmapImage::checkForSolidColor):
2361 (WebCore::BitmapImage::invalidatePlatformData):
2362 (WebCore::BitmapImage::draw):
2363 (WebCore::Image::drawPattern):
2364 * platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Removed.
2365 * platform/graphics/blackberry/LayerCompositingThread.cpp:
2366 (WebCore::LayerCompositingThread::drawTextures):
2367 (WebCore::LayerCompositingThread::drawSurface):
2368 (WebCore::LayerCompositingThread::contentsTexture):
2369 (WebCore::LayerCompositingThread::commitPendingTextureUploads):
2371 * platform/graphics/blackberry/LayerCompositingThread.h:
2373 (LayerCompositingThread):
2374 * platform/graphics/blackberry/LayerCompositingThreadClient.h:
2377 (LayerCompositingThreadClient):
2378 (WebCore::LayerCompositingThreadClient::contentsTexture):
2379 (WebCore::LayerCompositingThreadClient::commitPendingTextureUploads):
2380 * platform/graphics/blackberry/LayerData.h:
2381 (WebCore::LayerData::LayerData):
2382 (WebCore::LayerData::contentsResolutionIndependent):
2384 (WebCore::LayerData::layerProgram):
2385 (WebCore::LayerData::isContainerForFixedPositionLayers):
2386 (WebCore::LayerData::isFixedToTop):
2387 (WebCore::LayerData::isFixedToLeft):
2388 (WebCore::LayerData::frameVisibleRect):
2389 (WebCore::LayerData::frameContentsSize):
2390 (WebCore::LayerData::contentsScale):
2391 * platform/graphics/blackberry/LayerFilterRenderer.cpp:
2392 (WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
2393 (WebCore::LayerFilterRenderer::initializeSharedGLObjects):
2394 (WebCore::LayerFilterRenderer::ping):
2395 (WebCore::LayerFilterRenderer::pong):
2396 (WebCore::LayerFilterRenderer::pushSnapshot):
2397 (WebCore::LayerFilterRenderer::popSnapshot):
2398 (WebCore::LayerFilterRenderer::applyActions):
2399 * platform/graphics/blackberry/LayerRenderer.cpp:
2401 (WebCore::LayerRenderer::LayerRenderer):
2402 (WebCore::LayerRenderer::~LayerRenderer):
2403 (WebCore::LayerRenderer::setViewport):
2404 (WebCore::LayerRenderer::compositeLayers):
2405 (WebCore::LayerRenderer::compositeBuffer):
2406 (WebCore::LayerRenderer::drawColor):
2407 (WebCore::LayerRenderer::useSurface):
2408 (WebCore::LayerRenderer::drawLayersOnSurfaces):
2410 (WebCore::LayerRenderer::toOpenGLWindowCoordinates):
2411 (WebCore::LayerRenderer::drawDebugBorder):
2412 (WebCore::LayerRenderer::drawHolePunchRect):
2413 (WebCore::LayerRenderer::updateLayersRecursive):
2414 (WebCore::LayerRenderer::compositeLayersRecursive):
2415 (WebCore::LayerRenderer::createProgram):
2416 (WebCore::LayerRenderer::useProgram):
2417 (WebCore::LayerRenderer::useLayerProgram):
2418 * platform/graphics/blackberry/LayerRenderer.h:
2420 * platform/graphics/blackberry/LayerRendererSurface.cpp:
2421 (WebCore::LayerRendererSurface::ensureTexture):
2422 * platform/graphics/blackberry/LayerTile.cpp:
2423 (WebCore::LayerTile::LayerTile):
2424 (WebCore::LayerTile::setContents):
2425 (WebCore::LayerTile::updateContents):
2426 * platform/graphics/blackberry/LayerTile.h:
2428 (WebCore::LayerTile::renderState):
2429 (WebCore::LayerTile::needsRender):
2430 (WebCore::LayerTile::setNeedsRender):
2431 (WebCore::LayerTile::setRenderPending):
2432 (WebCore::LayerTile::setRenderDone):
2433 * platform/graphics/blackberry/LayerTileIndex.h:
2434 * platform/graphics/blackberry/LayerTiler.cpp:
2436 (WebCore::defaultTileSize):
2437 (WebCore::LayerTiler::LayerTiler):
2438 (WebCore::LayerTiler::updateTextureContentsIfNeeded):
2439 (WebCore::LayerTiler::createBuffer):
2440 (WebCore::LayerTiler::willCommit):
2441 (WebCore::LayerTiler::commitPendingTextureUploads):
2442 (WebCore::LayerTiler::layerVisibilityChanged):
2443 (WebCore::LayerTiler::uploadTexturesIfNeeded):
2444 (WebCore::LayerTiler::processTextureJob):
2445 (WebCore::LayerTiler::addTileJob):
2446 (WebCore::LayerTiler::performTileJob):
2447 (WebCore::LayerTiler::drawTile):
2448 (WebCore::LayerTiler::drawTextures):
2449 (WebCore::LayerTiler::pruneTextures):
2450 (WebCore::LayerTiler::updateTileSize):
2451 (WebCore::LayerTiler::setNeedsBacking):
2452 (WebCore::LayerTiler::contentsTexture):
2453 * platform/graphics/blackberry/LayerTiler.h:
2454 (WebCore::LayerTiler::tileSize):
2456 (WebCore::LayerTiler::TextureJob::TextureJob):
2457 (WebCore::LayerTiler::TextureJob::setContents):
2458 (WebCore::LayerTiler::TextureJob::updateContents):
2460 (WebCore::LayerTiler::needsRender):
2461 (WebCore::LayerTiler::removeUpdateContentsJobs):
2462 * platform/graphics/blackberry/LayerWebKitThread.cpp:
2463 (WebCore::LayerWebKitThread::LayerWebKitThread):
2464 (WebCore::LayerWebKitThread::~LayerWebKitThread):
2465 (WebCore::LayerWebKitThread::paintContents):
2466 (WebCore::LayerWebKitThread::commitPendingTextureUploads):
2467 (WebCore::LayerWebKitThread::setContents):
2468 (WebCore::LayerWebKitThread::setNeedsCommit):
2469 (WebCore::LayerWebKitThread::notifyAnimationsStarted):
2470 (WebCore::LayerWebKitThread::commitOnWebKitThread):
2471 (WebCore::LayerWebKitThread::startAnimations):
2472 (WebCore::LayerWebKitThread::updateTextureContents):
2473 (WebCore::LayerWebKitThread::commitOnCompositingThread):
2474 (WebCore::LayerWebKitThread::addSublayer):
2476 (WebCore::LayerWebKitThread::addOverlay):
2477 (WebCore::LayerWebKitThread::insert):
2478 (WebCore::LayerWebKitThread::removeFromSuperlayer):
2479 (WebCore::LayerWebKitThread::removeSublayerOrOverlay):
2480 (WebCore::LayerWebKitThread::remove):
2481 (WebCore::LayerWebKitThread::replaceSublayer):
2482 (WebCore::LayerWebKitThread::filtersCanBeComposited):
2483 (WebCore::LayerWebKitThread::removeAll):
2484 (WebCore::LayerWebKitThread::setSublayers):
2485 (WebCore::LayerWebKitThread::updateLayerHierarchy):
2486 (WebCore::LayerWebKitThread::setIsMask):
2487 (WebCore::LayerWebKitThread::releaseLayerResources):
2488 * platform/graphics/blackberry/LayerWebKitThread.h:
2489 (WebCore::LayerWebKitThread::insertSublayer):
2490 (LayerWebKitThread):
2491 (WebCore::LayerWebKitThread::isMask):
2492 (WebCore::LayerWebKitThread::removeAllSublayers):
2493 (WebCore::LayerWebKitThread::setFixedPosition):
2494 (WebCore::LayerWebKitThread::setIsContainerForFixedPositionLayers):
2495 (WebCore::LayerWebKitThread::setFixedToTop):
2496 (WebCore::LayerWebKitThread::setFixedToLeft):
2497 (WebCore::LayerWebKitThread::setFrameVisibleRect):
2498 (WebCore::LayerWebKitThread::setFrameContentsSize):
2499 (WebCore::LayerWebKitThread::setLayerProgram):
2500 * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
2501 (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2502 (WebCore::MediaPlayerPrivate::play):
2503 (WebCore::MediaPlayerPrivate::supportsFullscreen):
2504 (WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
2505 (WebCore::MediaPlayerPrivate::prepareForRendering):
2507 (WebCore::MediaPlayerPrivate::resizeSourceDimensions):
2508 (WebCore::MediaPlayerPrivate::percentLoaded):
2509 (WebCore::MediaPlayerPrivate::updateStates):
2510 (WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
2511 (WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
2512 (WebCore::MediaPlayerPrivate::notifyChallengeResult):
2513 (WebCore::MediaPlayerPrivate::isProcessingUserGesture):
2514 (WebCore::loadBufferingImageData):
2515 (WebCore::MediaPlayerPrivate::setBuffering):
2516 (WebCore::MediaPlayerPrivate::drawBufferingAnimation):
2517 (WebCore::MediaPlayerPrivate::onConditionallyEnterFullscreen):
2518 (WebCore::MediaPlayerPrivate::onExitFullscreen):
2519 (WebCore::MediaPlayerPrivate::onCreateHolePunchRect):
2520 (WebCore::MediaPlayerPrivate::onDestroyHolePunchRect):
2521 * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
2525 (MediaPlayerPrivate):
2526 * platform/graphics/blackberry/PluginLayerWebKitThread.cpp:
2527 (WebCore::PluginLayerWebKitThread::setPluginView):
2528 * platform/graphics/blackberry/Texture.cpp:
2529 (WebCore::Texture::Texture):
2530 (WebCore::Texture::updateContents):
2531 (WebCore::Texture::setContentsToColor):
2532 (WebCore::Texture::protect):
2533 * platform/graphics/blackberry/Texture.h:
2535 (WebCore::Texture::textureId):
2536 (WebCore::Texture::isDirty):
2537 (WebCore::Texture::hasTexture):
2538 (WebCore::Texture::sizeInBytes):
2539 (WebCore::Texture::setTextureId):
2540 (WebCore::Texture::setSize):
2541 * platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
2542 (WebCore::TextureCacheCompositingThread::allocateTextureId):
2543 (WebCore::freeTextureId):
2544 (WebCore::TextureCacheCompositingThread::collectGarbage):
2545 (WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
2547 (WebCore::TextureCacheCompositingThread::textureDestroyed):
2548 (WebCore::TextureCacheCompositingThread::install):
2549 (WebCore::TextureCacheCompositingThread::resizeTexture):
2550 (WebCore::TextureCacheCompositingThread::evict):
2551 (WebCore::TextureCacheCompositingThread::prune):
2552 (WebCore::TextureCacheCompositingThread::clear):
2553 (WebCore::TextureCacheCompositingThread::textureForTiledContents):
2554 (WebCore::TextureCacheCompositingThread::updateContents):
2555 * platform/graphics/blackberry/TextureCacheCompositingThread.h:
2556 (TextureCacheCompositingThread):
2557 (WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
2559 * platform/graphics/blackberry/skia/ImageBufferDataSkia.h: Removed.
2560 * platform/graphics/blackberry/skia/PlatformSupport.cpp: Removed.
2561 * platform/graphics/blackberry/skia/PlatformSupport.h: Removed.
2563 2013-03-01 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
2565 [Qt] Fix the Mac build with the current qtbase/dev branch
2566 https://bugs.webkit.org/show_bug.cgi?id=111190
2568 Reviewed by Allan Sandfeld Jensen.
2570 QMAKE_MACOSX_DEPLOYMENT_TARGET now influences
2571 __MAC_OS_X_VERSION_MIN_REQUIRED through -mmacosx-version-min after
2572 changes in qtbase to support iOS.
2574 Having only WebCore defining it to 10.5 would create a mismatch of
2575 ENABLE_THREADING_LIBDISPATCH with WTF to cause undefined symbols
2576 while linking both together at the end.
2578 Fix it by removing the statement which isn't needed anymore.
2579 qtbase/mkspecs/common/mac-minimum-version.conf already defines
2580 10.6 as the minimum Mac version.
2584 2013-03-01 Vsevolod Vlasov <vsevik@chromium.org>
2586 Web Inspector: [Regression] Snippets renaming is broken.
2587 https://bugs.webkit.org/show_bug.cgi?id=111181
2589 Reviewed by Alexander Pavlov.
2591 * inspector/front-end/NavigatorView.js:
2592 * inspector/front-end/ScriptSnippetModel.js:
2593 * inspector/front-end/ScriptsPanel.js:
2594 (WebInspector.ScriptsPanel.prototype.set _fileRenamed):
2595 * inspector/front-end/UISourceCode.js:
2596 (WebInspector.UISourceCode.prototype.rename):
2598 2013-03-01 David Hyatt <hyatt@apple.com>
2600 Fix a misspelled word in RenderObject.h. staticly -> statically.
2602 Reviewed by Dean Jackson.
2604 * rendering/RenderObject.h:
2605 (WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
2606 (WebCore::RenderObject::RenderObjectBitfields::isPositioned):
2608 2013-03-01 David Hyatt <hyatt@apple.com>
2610 [New Multicolumn] Change flow thread containment to be a state.
2611 https://bugs.webkit.org/show_bug.cgi?id=111110
2613 Change m_inRenderFlowThread from a single bit to an actual state. This
2614 will let us track whether we're inside a multicolumn (in-flow) flow thread
2615 or a named (out-of-flow) flow thread. In the former case, we're going to have
2616 to do more work to maintain this state, but for now I've kept all the logic
2617 the same just for the initial landing.
2619 Reviewed by Andreas Kling.
2621 * dom/NodeRenderingContext.cpp:
2622 (WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
2623 (WebCore::NodeRenderingContext::createRendererForTextIfNeeded):
2624 * rendering/RenderBlock.cpp:
2625 (WebCore::RenderBlock::clone):
2626 * rendering/RenderFlowThread.cpp:
2627 (WebCore::RenderFlowThread::RenderFlowThread):
2628 * rendering/RenderInline.cpp:
2629 (WebCore::RenderInline::clone):
2630 * rendering/RenderMultiColumnFlowThread.cpp:
2631 (WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
2632 * rendering/RenderObject.cpp:
2633 (WebCore::RenderObject::setFlowThreadStateIncludingDescendants):
2634 (WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
2635 * rendering/RenderObject.h:
2636 (WebCore::RenderObject::setParent):
2638 (WebCore::RenderObject::inRenderFlowThread):
2639 (WebCore::RenderObject::flowThreadState):
2640 (WebCore::RenderObject::setFlowThreadState):
2641 (WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
2642 (RenderObjectBitfields):
2643 (WebCore::RenderObject::RenderObjectBitfields::flowThreadState):
2644 (WebCore::RenderObject::RenderObjectBitfields::setFlowThreadState):
2645 * rendering/RenderView.cpp:
2646 (WebCore::RenderView::addChild):
2648 2013-03-01 Jessie Berlin <jberlin@apple.com>
2652 Roll out r144431 because it was a build fix for r144422, which was rolled out in r144446.
2654 * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
2656 2013-03-01 David Kilzer <ddkilzer@apple.com>
2658 BUILD FIX (r144358): Add UNUSED_PARAM() macros to WebCore::Extensions3DOpenGL::drawBuffersEXT()
2659 <http://webkit.org/b/109331>
2661 Fixes the following build failures:
2663 Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:51: error: unused parameter 'n' [-Werror,-Wunused-parameter]
2664 void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)
2666 Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:70: error: unused parameter 'bufs' [-Werror,-Wunused-parameter]
2667 void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)
2671 * platform/graphics/opengl/Extensions3DOpenGL.cpp:
2672 (WebCore::Extensions3DOpenGL::drawBuffersEXT): Add UNUSED_PARAM()
2675 2013-03-01 Dan Carney <dcarney@google.com>
2677 [v8] ScriptValue has dangerous copy semantics
2678 https://bugs.webkit.org/show_bug.cgi?id=110206
2680 Reviewed by Kentaro Hara.
2682 Update ScriptValue to used a SharedPersistent,
2683 making it impossible to return dead references.
2685 No new tests. No change in functionality.
2687 * bindings/v8/ScriptValue.cpp:
2688 (WebCore::ScriptValue::serialize):
2689 (WebCore::ScriptValue::getString):
2690 (WebCore::ScriptValue::toString):
2691 (WebCore::ScriptValue::toInspectorValue):
2692 * bindings/v8/ScriptValue.h:
2693 (WebCore::ScriptValue::ScriptValue):
2694 (WebCore::ScriptValue::operator=):
2695 (WebCore::ScriptValue::operator==):
2696 (WebCore::ScriptValue::isEqual):
2697 (WebCore::ScriptValue::isFunction):
2698 (WebCore::ScriptValue::isNull):
2699 (WebCore::ScriptValue::isUndefined):
2700 (WebCore::ScriptValue::isObject):
2701 (WebCore::ScriptValue::hasNoValue):
2702 (WebCore::ScriptValue::clear):
2704 (WebCore::ScriptValue::v8Value):
2705 (WebCore::ScriptValue::v8ValueRaw):
2706 * bindings/v8/SharedPersistent.h:
2707 * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2708 (WebCore::InjectedScriptHost::scriptValueAsNode):
2709 * bindings/v8/custom/V8MessageEventCustom.cpp:
2710 (WebCore::V8MessageEvent::dataAttrGetterCustom):
2712 2013-03-01 Julien Chaffraix <jchaffraix@webkit.org>
2714 Add FeatureObserver for marquee and reflection
2715 https://bugs.webkit.org/show_bug.cgi?id=111118
2717 Reviewed by Simon Fraser.
2719 Refactoring covered by existing tests.
2721 * page/FeatureObserver.h:
2722 * rendering/RenderLayer.cpp:
2723 (WebCore::RenderLayer::styleChanged):
2724 Added some instrumentation for reflection and marquee as they are both prefixed and this would help
2725 to know their popularity on the web. Marquee was split between <marquee> (HTMLMarqueeElement) and
2726 overflow: -webkit-marquee (CSSOverflowMarquee).
2728 2013-03-01 Alexander Pavlov <apavlov@chromium.org>
2730 Web Inspector: Introduce opaque SecurityOrigin string identifiers in the frontend
2731 https://bugs.webkit.org/show_bug.cgi?id=111165
2733 Reviewed by Vsevolod Vlasov.
2735 A plain string security origin value has been replaced by WebInspector.SecurityOrigin all over the code,
2736 containing a URL (which holds a stringified security origin) and an identifier (which is now used
2737 as a key in place of the stringified security origin in various maps). To avoid the ResourceTreeModel
2738 code clutter, the security origin tracking code has been extracted into a separate type,
2739 WebInspector.SecurityOriginTracker, which works as a helper on the ResourceTreeModel.
2741 No new tests, as it is a refactoring.
2743 * inspector/front-end/DOMStorage.js:
2744 (WebInspector.DOMStorage.storageId):
2745 (WebInspector.DOMStorage.prototype.id):
2746 (WebInspector.DOMStorage.prototype.getItems):
2747 (WebInspector.DOMStorage.prototype.setItem):
2748 (WebInspector.DOMStorage.prototype.removeItem):
2749 (WebInspector.DOMStorageModel.prototype._securityOriginAdded):
2750 (WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
2751 (WebInspector.DOMStorageModel.prototype._storageKey):
2752 * inspector/front-end/ExtensionAuditCategory.js:
2753 * inspector/front-end/FileSystemModel.js:
2754 (WebInspector.FileSystemModel.prototype._reset):
2755 (WebInspector.FileSystemModel.prototype._securityOriginAdded):
2756 (WebInspector.FileSystemModel.prototype._securityOriginRemoved):
2757 (WebInspector.FileSystemModel.prototype._addOrigin):
2758 (WebInspector.FileSystemModel.prototype._removeOrigin):
2759 (WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
2760 (WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
2761 (WebInspector.FileSystemModel.prototype._removeFileSystem):
2762 (WebInspector.FileSystemModel.FileSystem.prototype.get name):
2763 * inspector/front-end/IndexedDBModel.js:
2764 (WebInspector.IndexedDBModel.prototype._reset):
2765 (WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
2766 (WebInspector.IndexedDBModel.prototype._securityOriginAdded):
2767 (WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
2768 (WebInspector.IndexedDBModel.prototype._addOrigin):
2769 (WebInspector.IndexedDBModel.prototype._removeOrigin):
2770 (WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
2771 (WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
2772 (WebInspector.IndexedDBModel.prototype._loadDatabase):
2773 (WebInspector.IndexedDBModel.prototype.):
2774 (WebInspector.IndexedDBModel.prototype._requestData):
2775 (WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
2776 * inspector/front-end/IndexedDBViews.js:
2777 (WebInspector.IDBDatabaseView.prototype._refreshDatabase):
2778 * inspector/front-end/ResourceTreeModel.js:
2779 (WebInspector.ResourceTreeModel.prototype._addFrame):
2780 (WebInspector.ResourceTreeModel.prototype.securityOriginForId):
2781 (WebInspector.ResourceTreeModel.prototype.securityOrigins):
2782 (WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
2783 (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2784 (WebInspector.ResourceTreeModel.prototype._frameDetached):
2785 (WebInspector.ResourceTreeModel.SecurityOriginTracker):
2786 (WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._addSecurityOrigin):
2787 (WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._removeSecurityOrigin):
2788 (WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._bindSecurityOrigin):
2789 (WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._unbindSecurityOrigin):
2790 (WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._detachMainFrame):
2791 (WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOriginForId):
2792 (WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOrigins):
2793 (WebInspector.ResourceTreeFrame.prototype._navigate):
2794 (WebInspector.SecurityOrigin.prototype.id):
2795 (WebInspector.SecurityOrigin.prototype.url):
2796 (WebInspector.SecurityOrigin.prototype.uiTitle):
2797 (WebInspector.SecurityOrigin.prototype.toProtocol):
2798 * inspector/front-end/ResourcesPanel.js:
2799 (WebInspector.IDBDatabaseTreeElement):
2800 (WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
2801 (WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
2802 (WebInspector.IDBIndexTreeElement.prototype.get itemURL):
2803 (WebInspector.DOMStorageTreeElement):
2804 (WebInspector.DOMStorageTreeElement.prototype.get itemURL):
2805 (WebInspector.FileSystemTreeElement):
2807 2013-03-01 Eugene Klyuchnikov <eustas@chromium.org>
2809 Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
2810 https://bugs.webkit.org/show_bug.cgi?id=108930
2812 Reviewed by Pavel Feldman.
2814 This feature will help developers to focus on events
2815 that caused CPU bar.
2817 * inspector/front-end/Popover.js: Added "arrowDirection" parameter.
2818 * inspector/front-end/TimelineGrid.js:
2819 (WebInspector.TimelineGrid): Added "curtains".
2820 * inspector/front-end/TimelinePanel.js:
2821 (WebInspector.TimelinePanel.prototype._mouseMove): Show/hide "curtains"
2822 when mouse is over CPU bar.
2823 * inspector/front-end/timelinePanel.css: Added "curtains" style rules.
2825 2013-03-01 Alexander Pavlov <apavlov@chromium.org>
2827 Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
2828 Relanding fixed r144449.
2829 https://bugs.webkit.org/show_bug.cgi?id=105285
2831 Reviewed by Vsevolod Vlasov.
2833 Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
2834 an external stylesheet/sass/other file. Inline stylesheets are not navigable,
2835 since their start position is not detectable inside the surrounding HTML as of yet.
2837 No new tests, a UI change.
2839 * inspector/front-end/CSSStyleModel.js:
2840 (WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
2841 (WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.
2842 * inspector/front-end/StylesSidebarPane.js: Add navigation code.
2843 (WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
2844 (WebInspector.StylePropertiesSection):
2846 2013-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
2848 Unreviewed, rolling out r144449.
2849 http://trac.webkit.org/changeset/144449
2850 https://bugs.webkit.org/show_bug.cgi?id=111175
2852 Breaks style-related inspector tests (Requested by apavlov on
2855 * inspector/front-end/CSSStyleModel.js:
2856 (WebInspector.CSSRule.prototype.get isRegular):
2857 (WebInspector.CSSProperty.prototype.setDisabled):
2858 * inspector/front-end/StylesSidebarPane.js:
2859 (WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
2860 (WebInspector.StylePropertiesSection):
2864 2013-03-01 Alexander Pavlov <apavlov@chromium.org>
2866 Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
2867 https://bugs.webkit.org/show_bug.cgi?id=105285
2869 Reviewed by Vsevolod Vlasov.
2871 Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
2872 an external stylesheet/sass/other file. Inline stylesheets are not navigable,
2873 since their start position is not detectable inside the surrounding HTML as of yet.
2875 No new tests, a UI change.
2877 * inspector/front-end/CSSStyleModel.js:
2878 (WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
2879 (WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.
2880 * inspector/front-end/StylesSidebarPane.js: Add navigation code.
2881 (WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
2882 (WebInspector.StylePropertiesSection):
2884 2013-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
2886 Unreviewed, rolling out r144443.
2887 http://trac.webkit.org/changeset/144443
2888 https://bugs.webkit.org/show_bug.cgi?id=111169
2890 Caused 2 tests to crash by segv on Chromium Mac10.6 (Requested
2891 by toyoshim on #webkit).
2893 * css/mediaControls.css:
2894 (video::-webkit-media-text-track-display):
2895 * rendering/RenderTextTrackCue.cpp:
2896 (WebCore::RenderTextTrackCue::isOutside):
2897 (WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet):
2899 2013-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
2901 Unreviewed, rolling out r144422 and r144424.
2902 http://trac.webkit.org/changeset/144422
2903 http://trac.webkit.org/changeset/144424
2904 https://bugs.webkit.org/show_bug.cgi?id=111167
2906 Caused over 20 tests to fail assertion on Chromium Win port as
2907 ASSERTION FAILED: m_platformRequestUpdated (Requested by
2908 toyoshim on #webkit).
2911 * GNUmakefile.list.am:
2912 * Modules/mediastream/RTCPeerConnection.cpp:
2913 * Modules/notifications/Notification.cpp:
2917 * WebCore.vcproj/WebCore.vcproj:
2918 * WebCore.vcxproj/WebCore.vcxproj:
2919 * WebCore.vcxproj/WebCore.vcxproj.filters:
2920 * WebCore.xcodeproj/project.pbxproj:
2921 * bindings/ScriptControllerBase.cpp:
2922 * bindings/js/JSNodeCustom.cpp:
2923 * bindings/js/ScriptController.cpp:
2924 * bindings/js/ScriptSourceCode.h:
2925 * bindings/objc/DOM.mm:
2926 * bindings/v8/ScriptController.cpp:
2927 * bindings/v8/V8DOMWindowShell.cpp:
2928 * bindings/v8/custom/V8DOMWindowCustom.cpp:
2929 * css/CSSCrossfadeValue.h:
2930 (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
2931 (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
2932 * css/CSSFontFaceSource.h:
2933 * css/CSSFontSelector.cpp:
2934 * css/WebKitCSSSVGDocumentValue.cpp:
2935 * css/WebKitCSSSVGDocumentValue.h:
2937 * dom/Clipboard.cpp:
2938 (WebCore::Clipboard::Clipboard):
2939 * dom/ContainerNode.cpp:
2940 * dom/DOMImplementation.cpp:
2941 * dom/PendingScript.h:
2942 * dom/ScriptElement.cpp:
2943 * dom/ScriptElement.h:
2944 * history/CachedFrame.cpp:
2946 * html/HTMLAnchorElement.cpp:
2947 * html/HTMLAppletElement.cpp:
2948 * html/HTMLElement.cpp:
2949 * html/HTMLEmbedElement.cpp:
2950 * html/HTMLFrameSetElement.cpp:
2951 * html/HTMLHtmlElement.cpp:
2952 * html/HTMLImageElement.cpp:
2953 * html/HTMLObjectElement.cpp:
2954 * html/HTMLPlugInElement.cpp:
2955 * html/ImageDocument.cpp:
2956 * html/ImageInputType.cpp:
2957 * html/MediaDocument.cpp:
2958 * html/PluginDocument.cpp:
2959 * html/canvas/WebGLRenderingContext.cpp:
2961 * html/parser/HTMLConstructionSite.cpp:
2962 * html/parser/HTMLParserOptions.cpp:
2963 * html/parser/HTMLScriptRunner.h:
2964 * html/parser/XSSAuditor.cpp:
2965 * html/parser/XSSAuditorDelegate.cpp:
2966 * inspector/InspectorDebuggerAgent.cpp:
2967 * inspector/InspectorFileSystemAgent.cpp:
2968 * inspector/InspectorFrontendHost.cpp:
2969 * inspector/InspectorInstrumentation.h:
2971 * inspector/InspectorPageAgent.cpp:
2972 * inspector/NetworkResourcesData.cpp:
2973 * inspector/NetworkResourcesData.h:
2975 * loader/CookieJar.cpp:
2976 * loader/CrossOriginAccessControl.cpp:
2977 * loader/CrossOriginAccessControl.h:
2979 * loader/CrossOriginPreflightResultCache.h:
2980 * loader/DocumentThreadableLoader.h:
2981 * loader/FrameLoader.cpp:
2982 (WebCore::FrameLoader::FrameLoader):
2983 * loader/FrameLoader.h:
2985 (WebCore::FrameLoader::policyChecker):
2986 * loader/ImageLoader.cpp:
2987 * loader/ImageLoader.h:
2988 * loader/LinkLoader.h:
2989 * loader/MainResourceLoader.cpp:
2990 * loader/MainResourceLoader.h:
2991 * loader/MixedContentChecker.cpp:
2992 * loader/PingLoader.cpp:
2993 * loader/PolicyChecker.h:
2995 * loader/ProgressTracker.cpp:
2996 * loader/SubframeLoader.cpp:
2997 * loader/SubresourceLoader.cpp:
2998 * loader/TextTrackLoader.cpp:
2999 * loader/TextTrackLoader.h:
3000 * loader/ThreadableLoader.h:
3001 * loader/appcache/ApplicationCacheGroup.cpp:
3002 * loader/appcache/ApplicationCacheGroup.h:
3004 * loader/appcache/ApplicationCacheHost.cpp:
3005 * loader/archive/cf/LegacyWebArchive.cpp:
3006 * loader/cache/CachedFont.cpp:
3007 * loader/cache/CachedFont.h:
3009 (WebCore::CachedFontClient::~CachedFontClient):
3010 (WebCore::CachedFontClient::expectedType):
3011 (WebCore::CachedFontClient::resourceClientType):
3012 (WebCore::CachedFontClient::fontLoaded):
3014 * loader/cache/CachedFontClient.h: Removed.
3015 * loader/cache/CachedImage.cpp:
3016 * loader/cache/CachedRawResource.cpp:
3017 * loader/cache/CachedRawResource.h:
3019 (CachedRawResourceClient):
3020 (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
3021 (WebCore::CachedRawResourceClient::expectedType):
3022 (WebCore::CachedRawResourceClient::resourceClientType):
3023 (WebCore::CachedRawResourceClient::dataSent):
3024 (WebCore::CachedRawResourceClient::responseReceived):
3025 (WebCore::CachedRawResourceClient::dataReceived):
3026 (WebCore::CachedRawResourceClient::redirectReceived):
3027 (WebCore::CachedRawResourceClient::dataDownloaded):
3028 * loader/cache/CachedRawResourceClient.h: Removed.
3029 * loader/cache/CachedResource.cpp:
3030 * loader/cache/CachedResourceHandle.cpp:
3031 * loader/cache/CachedResourceHandle.h:
3032 (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
3033 (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
3034 * loader/cache/CachedSVGDocument.h:
3035 (CachedSVGDocumentClient):
3036 (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
3037 (WebCore::CachedSVGDocumentClient::expectedType):
3038 (WebCore::CachedSVGDocumentClient::resourceClientType):
3040 * loader/cache/CachedSVGDocumentClient.h: Removed.
3041 * loader/cache/CachedSVGDocumentReference.cpp: Removed.
3042 * loader/cache/CachedSVGDocumentReference.h:
3043 (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
3044 (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
3045 * loader/cache/CachedStyleSheetClient.h:
3046 * loader/cache/MemoryCache.cpp:
3047 * loader/cache/MemoryCache.h:
3050 * loader/chromium/CachedRawResourceChromium.cpp:
3051 * loader/icon/IconController.cpp:
3052 * loader/icon/IconLoader.h:
3053 * loader/mac/ResourceLoaderMac.mm:
3054 * page/DOMWindowExtension.cpp:
3055 * page/DragController.cpp:
3057 (WebCore::Frame::Frame):
3058 (WebCore::Frame::reportMemoryUsage):
3062 (WebCore::Frame::init):
3063 (WebCore::Frame::loader):
3064 * page/PerformanceNavigation.cpp:
3065 * page/PerformanceTiming.cpp:
3066 * page/PointerLockController.cpp:
3067 * page/Settings.cpp:
3068 * page/animation/CSSPropertyAnimation.cpp:
3069 * platform/chromium/PasteboardChromium.cpp:
3070 * platform/efl/ErrorsEfl.cpp:
3071 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
3072 * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
3073 * platform/graphics/filters/FilterOperation.cpp:
3074 * platform/graphics/filters/FilterOperation.h:
3075 (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
3076 (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
3077 * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
3078 * platform/gtk/ErrorsGtk.cpp:
3079 * platform/gtk/PasteboardGtk.cpp:
3080 * platform/gtk/PasteboardHelper.h:
3081 * platform/mac/ClipboardMac.h:
3082 * platform/mac/ClipboardMac.mm:
3083 * platform/mac/HTMLConverter.mm:
3084 * platform/mac/PasteboardMac.mm:
3085 * platform/network/AuthenticationChallengeBase.cpp:
3086 * platform/network/cf/CookieJarCFNet.cpp:
3087 * platform/network/cf/ResourceRequestCFNet.cpp:
3088 * platform/network/mac/CookieStorageMac.mm:
3089 * platform/qt/PasteboardQt.cpp:
3090 * plugins/DOMMimeType.cpp:
3091 * plugins/PluginRequest.h: Removed.
3092 * plugins/PluginStream.h:
3093 (PluginStreamClient):
3094 (WebCore::PluginStreamClient::~PluginStreamClient):
3095 (WebCore::PluginStreamClient::streamDidFinishLoading):
3097 * plugins/PluginStreamClient.h: Removed.
3098 * plugins/PluginView.cpp:
3099 * plugins/PluginView.h:
3102 (WebCore::PluginRequest::PluginRequest):
3103 (WebCore::PluginRequest::frameLoadRequest):
3104 (WebCore::PluginRequest::notifyData):
3105 (WebCore::PluginRequest::sendNotification):
3106 (WebCore::PluginRequest::shouldAllowPopups):
3107 * rendering/HitTestResult.cpp:
3108 * rendering/InlineFlowBox.cpp:
3109 * rendering/RenderBox.cpp:
3110 * rendering/RenderEmbeddedObject.cpp:
3111 * rendering/RenderImage.cpp:
3112 * rendering/RenderImageResource.cpp:
3113 (WebCore::RenderImageResource::RenderImageResource):
3114 * rendering/RenderImageResource.h:
3115 (WebCore::RenderImageResource::image):
3116 (WebCore::RenderImageResource::errorOccurred):
3117 (WebCore::RenderImageResource::usesImageContainerSize):
3118 (WebCore::RenderImageResource::imageHasRelativeWidth):
3119 (WebCore::RenderImageResource::imageHasRelativeHeight):
3120 (WebCore::RenderImageResource::imageSize):
3121 * rendering/RenderImageResourceStyleImage.cpp:
3122 * rendering/RenderLayer.cpp:
3123 * rendering/RenderLayerBacking.cpp:
3124 * rendering/RenderLayerFilterInfo.h:
3125 * rendering/RenderListItem.cpp:
3126 * rendering/RenderListMarker.cpp:
3127 * rendering/RenderSnapshottedPlugIn.cpp:
3128 * rendering/RenderTableCol.cpp:
3129 * rendering/RenderTableRow.cpp:
3130 * rendering/RenderTableSection.cpp:
3131 * rendering/style/StyleCachedShader.h:
3132 * rendering/style/StyleCustomFilterProgram.cpp: Removed.
3133 * rendering/style/StyleCustomFilterProgram.h:
3135 (WebCore::StyleCustomFilterProgram::vertexShaderString):
3136 (StyleCustomFilterProgram):
3137 (WebCore::StyleCustomFilterProgram::fragmentShaderString):
3138 (WebCore::StyleCustomFilterProgram::isLoaded):
3139 (WebCore::StyleCustomFilterProgram::willHaveClients):
3140 (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
3141 (WebCore::StyleCustomFilterProgram::notifyFinished):
3142 * svg/SVGFEImageElement.h:
3143 * svg/SVGFontFaceUriElement.h:
3144 (SVGFontFaceUriElement):
3145 * svg/SVGImageLoader.cpp:
3146 * svg/SVGUseElement.cpp:
3147 * svg/SVGUseElement.h:
3148 * svg/graphics/SVGImageCache.cpp:
3149 * testing/MockPagePopupDriver.cpp:
3150 * xml/XSLStyleSheet.h:
3151 * xml/XSLTProcessorLibxslt.cpp:
3152 * xml/parser/XMLDocumentParser.cpp:
3153 * xml/parser/XMLDocumentParser.h:
3154 * xml/parser/XMLDocumentParserLibxml2.cpp:
3156 2013-03-01 Alexei Filippov <alph@chromium.org>
3158 Web Inspector: fix closure compiler warnings in ProfilesPanel
3159 https://bugs.webkit.org/show_bug.cgi?id=111163
3161 Reviewed by Vsevolod Vlasov.
3163 * inspector/front-end/ProfileLauncherView.js:
3164 (WebInspector.ProfileLauncherView.prototype.addProfileType):
3165 * inspector/front-end/ProfilesPanel.js:
3167 2013-03-01 Victor Carbune <vcarbune@chromium.org>
3169 Support padding, margin and border for internal UA cue styling
3170 https://bugs.webkit.org/show_bug.cgi?id=110703
3172 Reviewed by Eric Carlson.
3174 For some particular user agent styling this allows the possibility
3175 of making the window around the cue text bigger to match some user
3176 styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).
3178 These properties *cannot* be set through by using the ::cue
3179 pseudo-element and, as specified, are used only internally.
3181 Test: media/track/track-cue-rendering-with-padding.html
3183 * css/mediaControls.css:
3184 (video::-webkit-media-text-track-display): Set the CSS box model
3185 to include in the specified width or height the values of
3186 padding / margin / border by using -webkit-box-sizing and avoid
3187 overflow over 100% width because of having these properties set.
3188 * rendering/RenderTextTrackCue.cpp:
3189 (WebCore::RenderTextTrackCue::isOutside): To not interfere with
3190 the regular WebVTT positioning algorithm, the check is done for
3191 the absolute content box.
3192 (WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
3193 an extra adjustment step to accomodate vertical padding (and not
3194 overflow the cue container)
3196 2013-02-26 Eugene Klyuchnikov <eustas@chromium.org>
3198 Web Inspector: Save/load timeline should preserve DOMContentLoaded and Load event markers
3199 https://bugs.webkit.org/show_bug.cgi?id=110819
3201 Reviewed by Pavel Feldman.
3203 To create event divider TimelinePresentation model checks if record
3204 frame is main frame. With this patch check is moved to backend and
3205 result is saved in record to avoid incoherence.
3207 * inspector/InspectorTimelineAgent.cpp:
3208 (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
3209 Record "isMainFrame" flag.
3210 (WebCore::InspectorTimelineAgent::didMarkLoadEvent): Ditto.
3211 * inspector/TimelineRecordFactory.cpp:
3212 (WebCore::TimelineRecordFactory::createMarkData):
3213 Added data object constructor.
3214 * inspector/TimelineRecordFactory.h: Ditto.
3215 * inspector/front-end/TimelinePresentationModel.js:
3216 (WebInspector.TimelinePresentationModel.isEventDivider):
3217 Use saved flag value instead of comparing with "current" main frame.
3219 2013-03-01 Eugene Klyuchnikov <eustas@chromium.org>
3221 Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
3222 https://bugs.webkit.org/show_bug.cgi?id=111077
3224 Reviewed by Pavel Feldman.
3226 Analysis: DataGridNode.refresh removes all cells and then recreates them.
3227 The issue is that mandatory "corner" cell is not recreated.
3229 * inspector/front-end/DataGrid.js:
3230 (WebInspector.DataGridNode.prototype.refresh):
3231 Added "corner" cell restoration code.
3233 2013-02-28 Alexander Pavlov <apavlov@chromium.org>
3235 Web Inspector: Selector's raw start position in its line is considered to be 0 when computing UILocation
3236 https://bugs.webkit.org/show_bug.cgi?id=110732
3238 Reviewed by Vsevolod Vlasov.
3240 Test: inspector/styles/selector-line.html
3242 * inspector/ContentSearchUtils.cpp:
3243 (WebCore::ContentSearchUtils::sizetExtractor): Utility for binary search.
3244 (WebCore::ContentSearchUtils::textPositionFromOffset): Converts absolute raw text offset into line:column.
3245 (WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines): Refactor.
3246 (WebCore::ContentSearchUtils::lineEndings): Factored out of getRegularExpressionMatchesByLines.
3247 (WebCore::ContentSearchUtils::buildObjectForSearchMatch): Drive-by: pass String by reference.
3248 * inspector/ContentSearchUtils.h:
3249 * inspector/Inspector.json: Use line:column for SourceRange boundaries rather than raw offsets.
3250 * inspector/InspectorStyleSheet.cpp:
3251 (ParsedStyleSheet::text): ASSERT(m_hasText).
3252 (WebCore::InspectorStyle::buildObjectForStyle): Supply the lineEndings argument.
3253 (WebCore::buildSourceRangeObject): Follow the protocol change.
3254 (WebCore::InspectorStyle::setPropertyText): Refactor.
3255 (WebCore::InspectorStyle::toggleProperty): Ditto.
3256 (WebCore::InspectorStyle::styleText): Ditto.
3257 (WebCore::InspectorStyle::populateAllProperties): Ditto.
3258 (WebCore::InspectorStyle::styleWithProperties): Convert relative property range offsets into absolute ones.
3259 (WebCore::InspectorStyle::extractSourceData): Factored out.
3260 (WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Supply the lineEndings argument.
3261 (WebCore::InspectorStyleSheet::buildObjectForSelectorList): Ditto.
3262 (WebCore::InspectorStyleSheet::lineEndings): Compute line endings for ordinary stylesheets.
3263 (WebCore::InspectorStyleSheetForInlineStyle::lineEndings): Ditto for bogus inline style stylesheets.
3264 * inspector/InspectorStyleSheet.h:
3265 * inspector/front-end/AuditRules.js: Removed the byte counting for unused CSS.
3266 * inspector/front-end/CSSStyleModel.js:
3267 (WebInspector.CSSRule): Set selector rawLocation based on the selectorList range or sourceLine.
3268 (WebInspector.CSSRule.prototype._setRawLocation): Added.
3269 * inspector/front-end/SASSSourceMapping.js:
3270 (WebInspector.SASSSourceMapping.prototype._bindUISourceCode): Fix call order when binding scss sourcecodes.
3272 2013-03-01 Benjamin Poulain <benjamin@webkit.org>
3274 Get rid of two silly static null Strings
3275 https://bugs.webkit.org/show_bug.cgi?id=111151
3277 Reviewed by Eric Seidel.
3279 We have a global null String through nullAtom, there is no need
3280 for local static null strings.
3283 (WebCore::Page::groupName):
3284 * rendering/RenderListItem.cpp:
3285 (WebCore::RenderListItem::markerText):
3287 2013-03-01 Mark Rowe <mrowe@apple.com>
3291 * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Add a missing #include.
3293 2013-03-01 Andrey Lushnikov <lushnikov@chromium.org>
3295 Web Inspector: fix code-mirror experiment to work in debug mode
3296 https://bugs.webkit.org/show_bug.cgi?id=111064
3298 Reviewed by Pavel Feldman.
3300 No new tests: no change in behaviour.
3302 Improve importScript function to try load a script from the root
3303 directory iff its loading from the given path failed.
3305 * inspector/front-end/utilities.js:
3307 2013-03-01 Andrey Adaikin <aandrey@chromium.org>
3309 Web Inspector: [Canvas] capture a WebGL extension by it's name in lower case
3310 https://bugs.webkit.org/show_bug.cgi?id=110745
3312 Reviewed by Pavel Feldman.
3314 WebGL's getExtension accepts a name that is tested against an ASCII case-insensitive match.
3315 Just force lower case for extension names.
3317 * inspector/InjectedScriptCanvasModuleSource.js:
3320 2013-03-01 Mike West <mkwst@chromium.org>
3322 XSSAuditor should use threadSafeMatch when relevant.
3323 https://bugs.webkit.org/show_bug.cgi?id=111099
3325 Reviewed by Adam Barth.
3327 Given the work on breaking parsing out into a background thread, we
3328 should compare QualifiedNames in a thread-safe manner. Rather than
3329 casting the result of QualifiedName::localName to a String, we can
3330 call out to threadSafeMatch to do the comparison.
3332 This patch leaves one use of equalIgnoringNullity in
3333 XSSAuditor::findAttributeWithName. That usage seems safe, since we're
3334 creating a new string against which to compare.
3336 * html/parser/XSSAuditor.cpp:
3338 Replace call to equalIgnoringNullity(Vector<UChar...>, String)
3339 with threadSafeMatch(String, QualifiedName).
3341 2013-02-28 Keishi Hattori <keishi@webkit.org>
3343 Add calendar table view for the new calendar picker
3344 https://bugs.webkit.org/show_bug.cgi?id=110970
3346 Reviewed by Kent Tamura.
3348 The calendar table that will be used in the new calendar picker (Bug 109439).
3350 No new tests. Code is not used yet.
3352 * Resources/pagepopups/calendarPicker.js:
3353 (DayCell): Cell which represents one day in the calendar.
3354 (DayCell.recycleOrCreate):
3355 (DayCell.prototype._recycleBin):
3356 (DayCell.prototype.throwAway):
3357 (DayCell.prototype.setHighlighted): Sets the highlighted class on the element.
3358 (DayCell.prototype.setDisabled): Sets the disabled class on the element.
3359 (DayCell.prototype.setIsInCurrentMonth): Sets the current-month class on the element.
3360 (DayCell.prototype.setIsToday): Sets the today class on the element.
3361 (DayCell.prototype.reset): Resets the day cell to be reused.
3362 (WeekNumberCell): Cell used for the week number column.
3363 (WeekNumberCell.prototype._recycleBin):
3364 (WeekNumberCell.recycleOrCreate):
3365 (WeekNumberCell.prototype.reset):
3366 (WeekNumberCell.prototype.throwAway):
3367 (WeekNumberCell.prototype.setHighlighted): Sets the highlighted class on the element.
3368 (WeekNumberCell.prototype.setDisabled): Sets the disabled class on the element.
3369 (CalendarTableHeaderView): Header for the calendar table. Contains the column labels.
3370 (CalendarRowCell): Row containing day cells and maybe a week number cell.
3371 (CalendarRowCell.prototype._recycleBin):
3372 (CalendarRowCell.prototype.reset):
3373 (CalendarRowCell.prototype.throwAway):
3374 (CalendarTableView): A list view showing a grid of days.
3375 (CalendarTableView.prototype.rowAtScrollOffset): Returns the row number currently at the scroll offset.
3376 (CalendarTableView.prototype.scrollOffsetForRow): Returns the current scroll offset for the given row.
3377 (CalendarTableView.prototype.onClick): If the click is on a DayCell or WeekNumberCell, select the appropriate date range.
3378 (CalendarTableView.prototype.onMouseOver): If the click is on a DayCell or WeekNumberCell, highlight the appropriate date range.
3379 (CalendarTableView.prototype.onMouseOut):
3380 (CalendarTableView.prototype.prepareNewCell): Prepares a new row cell by recycling or creating a new one.
3381 (CalendarTableView.prototype.height): Returns the height of the view in pixels.
3382 (CalendarTableView.prototype.setHeight): Sets the height of the view in pixels.
3383 (CalendarTableView.prototype.scrollToMonth): Scrolls to reveal the given month.
3384 (CalendarTableView.prototype.dayAtColumnAndRow): Day at a given column and row. Column number doesn't count week number column.
3385 (CalendarTableView.prototype.columnAndRowForDay): Column and row for the given day.
3386 (CalendarTableView.prototype.updateCells): Update the position and appearance of the cell.s
3387 (CalendarTableView.prototype.prepareNewDayCell): Prepares a new day cell. The cell is registered to this._dayCells.
3388 (CalendarTableView.prototype.prepareNewWeekNumberCell): Prepares a new week number cell. The cell is registered to this._weekNumberCells.
3389 (CalendarTableView.prototype.throwAwayDayCell): The cell is unregistered from this._dayCells.
3390 (CalendarTableView.prototype.throwAwayWeekNumberCell): The cell is unregistered from this._weekNumberCells.
3392 2013-02-28 Alexey Proskuryakov <ap@apple.com>
3394 Reduce amount of rebuilding when touching networking headers
3395 https://bugs.webkit.org/show_bug.cgi?id=111035
3397 Reviewed by Eric Seidel.
3399 This uses a number of common unsurprising techniques. One interesting observation
3400 is that including CachedResource related headers is very expensive. We can usually
3401 get away with their Client counterparts, and with CachedResourceHandle.
3405 Don't include FrameLoader, greatly reducing include graph for most non-loader files.
3406 This required making Frame::init() non-inline - I'm not sure why it ever was.
3408 * loader/FrameLoader.cpp:
3409 * loader/FrameLoader.h:
3410 Even though FrameLoader is logically on loading side of WebCore, it's included in
3411 too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
3412 largest wins. As a future improvement, we should probably convert other members
3415 * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
3416 definition of a class it holds, but default construction does not.
3418 * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
3419 not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
3421 * loader/cache/CachedFont.h:
3422 * loader/cache/CachedFontClient.h: Added.
3423 * loader/cache/CachedRawResource.h:
3424 * loader/cache/CachedRawResourceClient.h: Added.
3425 * loader/cache/CachedSVGDocument.h:
3426 * loader/cache/CachedSVGDocumentClient.h: Added.
3427 These types were defining client types in the same headers, making it impossible
3428 to avoid including networking headers through CachedResource. Moved clients into
3431 * plugins/PluginStream.h:
3432 * plugins/PluginStreamClient.h: Added.
3433 Similar situation here.