Implement <attachment> element appearance on Mac
[WebKit-https.git] / Source / WebCore / ChangeLog-2011-06-04
1 2011-06-04  Darin Adler  <darin@apple.com>
2
3         Reviewed by Anders Carlsson.
4
5         [Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
6         https://bugs.webkit.org/show_bug.cgi?id=62094
7         rdar://problem/9539204
8
9         * WebCore.exp.in: Export ResourceHandle::synchronousLoadRunLoopMode.
10         * platform/network/ResourceHandle.h: Add synchronousLoadRunLoopMode.
11         * platform/network/cf/ResourceHandleCFNet.cpp:
12         (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added.
13         (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
14         * platform/network/mac/ResourceHandleMac.mm:
15         (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added.
16         (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
17
18 2011-06-04  Eric Seidel  <eric@webkit.org>
19
20         Reviewed by Adam Barth.
21
22         Add InlineWalker class to hold state for repeated calls to bidiNext
23         https://bugs.webkit.org/show_bug.cgi?id=60724
24
25         This is one more little step towards removing (naked) bidiNext usage.
26         More refactoring is required before all callers of bidiNext can move
27         onto using an InlineWalker instead of bidiNext directly.
28
29         No change in behavior, thus no tests.
30
31         * rendering/InlineIterator.h:
32         (WebCore::InlineWalker::InlineWalker):
33         (WebCore::InlineWalker::root):
34         (WebCore::InlineWalker::current):
35         (WebCore::InlineWalker::atEndOfInline):
36         (WebCore::InlineWalker::atEnd):
37         (WebCore::InlineWalker::advance):
38         * rendering/RenderBlock.cpp:
39         (WebCore::RenderBlock::simplifiedNormalFlowLayout):
40         * rendering/RenderBlockLineLayout.cpp:
41         (WebCore::RenderBlock::layoutInlineChildren):
42
43 2011-06-04  Sam Weinig  <sam@webkit.org>
44
45         Reviewed by Anders Carlsson.
46
47         WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
48         https://bugs.webkit.org/show_bug.cgi?id=62093
49
50         Add additional ChromeClient functions to indicate the beginning and end of
51         the various ScrollAnimator animations. Change existing notification that a
52         rubber-band has completed for the main frame to be triggered for all frames.
53
54         * page/ChromeClient.h:
55         (WebCore::ChromeClient::didStartRubberBandForFrame):
56         (WebCore::ChromeClient::didCompleteRubberBandForFrame):
57         (WebCore::ChromeClient::didStartAnimatedScroll):
58         (WebCore::ChromeClient::didCompleteAnimatedScroll):
59         * page/FrameView.cpp:
60         (WebCore::FrameView::didStartRubberBand):
61         (WebCore::FrameView::didCompleteRubberBand):
62         (WebCore::FrameView::didStartAnimatedScroll):
63         (WebCore::FrameView::didCompleteAnimatedScroll):
64         * page/FrameView.h:
65         * platform/ScrollableArea.h:
66         (WebCore::ScrollableArea::didStartRubberBand):
67         (WebCore::ScrollableArea::didStartAnimatedScroll):
68         (WebCore::ScrollableArea::didCompleteAnimatedScroll):
69         * platform/mac/ScrollAnimatorMac.h:
70         * platform/mac/ScrollAnimatorMac.mm:
71         (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
72         (WebCore::ScrollAnimatorMac::scroll):
73         (WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation):
74         (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
75
76 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
77
78         Touch a file to try to fix the GTK+ build on the 32-bit bot.
79
80         * testing/Internals.idl: Touch this IDL file in an effort to fix the build.
81
82 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
83
84         Fix the GTK+ build.
85
86         * bindings/gobject/GNUmakefile.am: Make the GObject build less noisy.
87
88 2011-06-03  Dimitri Glazkov  <dglazkov@chromium.org>
89
90         Reviewed by Darin Adler.
91
92         Convert file <input> to use the new shadow DOM model
93         https://bugs.webkit.org/show_bug.cgi?id=59005
94
95         Refactoring, covered by existing tests.
96
97         * css/CSSSelector.cpp:
98         (WebCore::CSSSelector::pseudoId): Removed FILE_UPLOAD_BUTTON pseudoId and all references to it.
99         (WebCore::nameToPseudoTypeMap): Ditto.
100         (WebCore::CSSSelector::extractPseudoType): Ditto.
101         * css/CSSSelector.h: Ditto.
102         * css/html.css:
103         (input[type="button"], input[type="submit"], input[type="reset"]): Moved -webkit-file-upload-button to its own rule.
104         (input[type="file"]::-webkit-file-upload-button): Added and moved all previously hard-coded properties there.
105         * html/FileInputType.cpp:
106         (WebCore::UploadButtonElement::create): Added.
107         (WebCore::UploadButtonElement::UploadButtonElement): Added.
108         (WebCore::UploadButtonElement::shadowPseudoId): Added.
109         (WebCore::FileInputType::createShadowSubtree): Added.
110         * html/FileInputType.h: Added createShadowSubtree decl.
111         * page/DragController.cpp:
112         (WebCore::asFileInput): Changed the logic to use new shadow DOM.
113         * rendering/RenderFileUploadControl.cpp: Removed UploadButton class.
114         (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed initializer for m_button.
115         (WebCore::RenderFileUploadControl::updateFromElement): Removed attachment logic that's no longer necessary.
116         (WebCore::nodeWidth): Added a helper.
117         (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use uploadButton and nodeWidth.
118         (WebCore::RenderFileUploadControl::paintObject): Ditto.
119         (WebCore::RenderFileUploadControl::uploadButton): Added a helper to retrieve the button.
120         (WebCore::RenderFileUploadControl::buttonValue): Changed to use uploadButton.
121         * rendering/RenderFileUploadControl.h: Changed decls.
122         * rendering/style/RenderStyleConstants.h: Removed FILE_UPLOAD_BUTTON decls.
123
124 2011-06-04  Alexey Proskuryakov  <ap@apple.com>
125
126         Reviewed by Darin Adler.
127
128         Input value sanitization for text fields is incorrect
129         https://bugs.webkit.org/show_bug.cgi?id=62061
130         <rdar://problem/9553273>
131
132         Newline characters should be removed according to HTML5, not replaced with spaces.
133         This also matches Safari 5 behavior.
134
135         * html/TextFieldInputType.cpp:
136         (WebCore::isASCIILineBreak): A functor for removeCharacters().
137         (WebCore::limitLength): Do one thing at once.
138         (WebCore::TextFieldInputType::sanitizeValue): Sanitization removes newlines.
139         (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Moved (somewhat surprising)
140         code that replaces newlines with spaces here.
141
142 2011-06-04  Jeffrey Pfau  <jpfau@apple.com>
143
144         Reviewed by Beth Dakin.
145
146         Crash in WebCore::RenderMathMLSubSup::baselinePosition()
147         https://bugs.webkit.org/show_bug.cgi?id=57897
148
149         Simple patch adding NULL checks in each function.
150         Test: mathml/msubsup-remove-children.xhtml
151
152         * rendering/mathml/RenderMathMLSubSup.cpp:
153         (WebCore::RenderMathMLSubSup::stretchToHeight):
154         (WebCore::RenderMathMLSubSup::baselinePosition):
155
156 2011-06-04  Nico Weber  <thakis@chromium.org>
157
158         Reviewed by James Robinson.
159
160         Give IDBBackingStore::Transaction a virtual destructor
161         https://bugs.webkit.org/show_bug.cgi?id=62063
162
163         IDBLevelDBBackingStore::createTransaction() hands out a
164         PassRefPtr<IDBBackingStore::Transaction>, which means the missing
165         virtual destructor is a real bug.
166
167         * storage/IDBBackingStore.h:
168         (WebCore::IDBBackingStore::Transaction::~Transaction):
169
170 2011-06-04  Emil A Eklund  <eae@chromium.org>
171
172         Reviewed by Eric Seidel.
173
174         Convert RenderBox::overflowClipRect to IntPoint
175         https://bugs.webkit.org/show_bug.cgi?id=62032
176
177         Covered by existing tests.
178
179         * editing/Editor.cpp:
180         (WebCore::Editor::insideVisibleArea):
181         * platform/graphics/IntRect.h:
182         (WebCore::IntRect::contract):
183         * rendering/RenderBlock.cpp:
184         (WebCore::RenderBlock::nodeAtPoint):
185         * rendering/RenderBox.cpp:
186         (WebCore::RenderBox::pushContentsClip):
187         (WebCore::RenderBox::overflowClipRect):
188         * rendering/RenderBox.h:
189         * rendering/RenderBoxModelObject.cpp:
190         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
191         * rendering/RenderLayer.cpp:
192         (WebCore::RenderLayer::calculateClipRects):
193         (WebCore::RenderLayer::calculateRects):
194         (WebCore::RenderLayer::repaintBlockSelectionGaps):
195         * rendering/RenderLayerBacking.cpp:
196         (WebCore::clipBox):
197         * rendering/RenderTable.cpp:
198         (WebCore::RenderTable::overflowClipRect):
199         (WebCore::RenderTable::nodeAtPoint):
200         * rendering/RenderTable.h:
201         * rendering/RenderTableSection.cpp:
202         (WebCore::RenderTableSection::nodeAtPoint):
203         * rendering/svg/RenderSVGRoot.cpp:
204         (WebCore::RenderSVGRoot::paint):
205
206 2011-06-04  Adam Barth  <abarth@webkit.org>
207
208         Reviewed by Eric Seidel.
209
210         V8Proxy::disconnectFrame doesn't do anything
211         https://bugs.webkit.org/show_bug.cgi?id=62051
212
213         Dead code should die.
214
215         * bindings/v8/ScriptController.cpp:
216         (WebCore::ScriptController::~ScriptController):
217         * bindings/v8/V8Proxy.cpp:
218         * bindings/v8/V8Proxy.h:
219
220 2011-06-04  Nico Weber  <thakis@chromium.org>
221
222         Reviewed by James Robinson.
223
224         Make the destructors of DataTransferItem and DataTransferItems virtual
225         https://bugs.webkit.org/show_bug.cgi?id=62052
226
227         Clang has grown a new warning that warns on |delete ptr| if ptr's
228         class is non-final, has virtual methods, but no virtual destructor.
229         This warning finds real bugs, so we want to keep it enabled. However,
230         it also warns about DataTransferItem[s]. Since these are subclassed,
231         they can't be made final, so make their destructors virtual. (Maybe
232         clang's warning even points out an actual bug here.)
233
234         * dom/DataTransferItem.h:
235         (WebCore::DataTransferItem::~DataTransferItem):
236         * dom/DataTransferItems.h:
237         (WebCore::DataTransferItems::~DataTransferItems):
238
239 2011-06-04  Nico Weber  <thakis@chromium.org>
240
241         Reviewed by James Robinson.
242
243         [chromium] Make LayerPainterChromium destructor virtual
244         https://bugs.webkit.org/show_bug.cgi?id=62056
245
246         LayerTextureUpdaterCanvas has an OwnPtr<LayerPainterChromium>, which
247         means that without this patch, the destructor of classes implementing
248         LayerPainterChromium wasn't called correctly in that case.
249
250         * platform/graphics/chromium/LayerPainterChromium.h:
251         (WebCore::LayerPainterChromium::~LayerPainterChromium):
252
253 2011-06-04  Emil A Eklund  <eae@chromium.org>
254
255         Reviewed by Andreas Kling.
256
257         Fix IntRect::expand(const IntSize& size)
258         https://bugs.webkit.org/show_bug.cgi?id=62042
259
260         No new tests.
261
262         * platform/graphics/IntRect.h:
263         (WebCore::IntRect::expand):
264         Fix IntRect::expand to expand the size rather than move the location.
265         Currently unused.
266
267 2011-06-03  Alexey Proskuryakov  <ap@apple.com>
268
269         Reviewed by Darin Adler.
270
271         ResourceHandleMac should always respond to an authentication challenge
272         https://bugs.webkit.org/show_bug.cgi?id=61667
273
274         I don't know if this can actually happen in practice, so no new tests.
275
276         * platform/network/mac/ResourceHandleMac.mm:
277         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
278         Cancel authentication challenge if we don't have a client. We must always respond to the
279         challenge to release the connection, and there is nothing else to do in this state anyway.
280
281 2011-06-03  Dan Bernstein  <mitz@apple.com>
282
283         Try to fix the Apple LLVM Compiler build after r88087.
284
285         * rendering/RenderTableCell.cpp:
286         (WebCore::RenderTableCell::paintMask):
287         * rendering/RenderTableCell.h:
288
289 2011-06-03  Chris Rogers  <crogers@google.com>
290
291         Unreviewed build fix.
292
293         Fix clang build - take 2
294         https://bugs.webkit.org/show_bug.cgi?id=62081
295
296         * webaudio/AudioParamTimeline.cpp:
297         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
298
299 2011-06-03  Chris Rogers  <crogers@google.com>
300
301         Unreviewed clang build fix.
302
303         Fix clang build
304         https://bugs.webkit.org/show_bug.cgi?id=62080
305
306         * webaudio/AudioParamTimeline.cpp:
307         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
308
309 2011-06-03  Levi Weintraub  <leviw@chromium.org>
310
311         Reviewed by Eric Seidel.
312
313         Switch paintMask and paintObject to use IntPoint
314         https://bugs.webkit.org/show_bug.cgi?id=62077
315
316         Switching paintMask and paintObject to use IntPoint for their paint offset instead of
317         a pair of ints. paintObject is still on tx/ty, but paintMask was converted to IntSize
318         passed by value -- bringing it in-line with the agreed-upon convention of a const IntPoint&.
319
320         No new tests since this is simple refactoring.
321
322         * rendering/RenderBlock.cpp:
323         (WebCore::RenderBlock::paint):
324         (WebCore::RenderBlock::paintObject):
325         * rendering/RenderBlock.h:
326         * rendering/RenderBox.cpp:
327         (WebCore::RenderBox::paintMask):
328         (WebCore::RenderBox::pushContentsClip):
329         (WebCore::RenderBox::popContentsClip):
330         * rendering/RenderBox.h:
331         (WebCore::RenderBox::paintObject):
332         * rendering/RenderFieldset.cpp:
333         (WebCore::RenderFieldset::paintMask):
334         * rendering/RenderFieldset.h:
335         * rendering/RenderFileUploadControl.cpp:
336         (WebCore::RenderFileUploadControl::paintObject):
337         * rendering/RenderFileUploadControl.h:
338         * rendering/RenderListBox.cpp:
339         (WebCore::RenderListBox::paintObject):
340         * rendering/RenderListBox.h:
341         * rendering/RenderReplaced.cpp:
342         (WebCore::RenderReplaced::paint):
343         * rendering/RenderReplica.cpp:
344         (WebCore::RenderReplica::paint):
345         * rendering/RenderTable.cpp:
346         (WebCore::RenderTable::paint):
347         (WebCore::RenderTable::paintObject):
348         (WebCore::RenderTable::paintMask):
349         * rendering/RenderTable.h:
350         * rendering/RenderTableSection.cpp:
351         (WebCore::RenderTableSection::paint):
352         (WebCore::RenderTableSection::paintObject):
353         * rendering/RenderTableSection.h:
354         * rendering/RenderTextControl.cpp:
355         (WebCore::RenderTextControl::paintPlaceholder):
356         (WebCore::RenderTextControl::paintObject):
357         * rendering/RenderTextControl.h:
358         * rendering/RenderView.cpp:
359         (WebCore::RenderView::paint):
360         * rendering/RenderWidget.cpp:
361         (WebCore::RenderWidget::paint):
362
363 2011-06-03  Cary Clark  <caryclark@google.com>
364
365         Reviewed by Eric Seidel.
366
367         Support FontCustomPlatformData on Skia-Mac-Chrome variant
368         https://bugs.webkit.org/show_bug.cgi?id=62040
369
370         Canvas text is only recognized by Skia if it is registered
371         by creating a new SkTypeface. Skia uses CGFont to measure
372         and render the glyphs, then takes care of managing the glyph
373         cache.
374
375         Skia on Mac Chrome is not yet enabled, so this change
376         does not affect existing code, and requires no new tests.
377
378         * platform/graphics/mac/FontCustomPlatformData.cpp:
379         (WebCore::RemoteFontStream::RemoteFontStream):
380         (WebCore::RemoteFontStream::~RemoteFontStream):
381         (WebCore::RemoteFontStream::rewind):
382         (WebCore::RemoteFontStream::read):
383         Turn the buffer into a stream. This is identical to
384         the implementation in skia/FontCustomPlatformData.cpp.
385         While that file could be modified instead of this one,
386         it was simpler to add SkTypeface streaming to this instead
387         of adding all CGFont support to the skia platform file.
388
389         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
390         Release the SkTypeface reference.
391
392         (WebCore::createFontCustomPlatformData):
393         Associate the buffer stream with a SkTypeface so Skia
394         can find the custom font data.
395
396         * platform/graphics/mac/FontCustomPlatformData.h:
397         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
398         Add a slot to hold the SkTypeface.
399
400 2011-06-03  Steve Falkenburg  <sfalken@apple.com>
401
402         Reviewed by Brian Weinstein.
403
404         HistoryItem children persist across page loads
405         https://bugs.webkit.org/show_bug.cgi?id=62071
406         <rdar://problem/9552129>
407         
408         Not testable since there's no way to check for the presence/absence
409         of children for a HistoryItem.
410
411         * history/HistoryItem.cpp:
412         (WebCore::HistoryItem::reset): Call clearChildren when we're reusing a HistoryItem.
413
414 2011-06-03  Chris Rogers  <crogers@google.com>
415
416         Reviewed by Kenneth Russell.
417
418         Allow existing AudioParams to use scheduled parameter changes
419         https://bugs.webkit.org/show_bug.cgi?id=62046
420
421         No new tests since audio API is not yet implemented.
422
423         * platform/audio/AudioBus.cpp:
424         (WebCore::AudioBus::processWithGainFrom):
425         (WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom):
426         * platform/audio/AudioBus.h:
427         * webaudio/AudioBufferSourceNode.cpp:
428         (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
429         * webaudio/AudioGainNode.cpp:
430         (WebCore::AudioGainNode::AudioGainNode):
431         (WebCore::AudioGainNode::process):
432         * webaudio/AudioGainNode.h:
433         * webaudio/HighPass2FilterNode.cpp:
434         (WebCore::HighPass2FilterNode::HighPass2FilterNode):
435         * webaudio/LowPass2FilterNode.cpp:
436         (WebCore::LowPass2FilterNode::LowPass2FilterNode):
437
438 2011-06-03  Chris Rogers  <crogers@google.com>
439
440         Reviewed by Kenneth Russell.
441
442         Biquad filter coefficient naming is incorrect
443         https://bugs.webkit.org/show_bug.cgi?id=62053
444
445         No new tests since audio API is not yet implemented.
446
447         * platform/audio/Biquad.cpp:
448         (WebCore::Biquad::Biquad):
449         (WebCore::Biquad::process):
450         (WebCore::Biquad::processFast):
451         (WebCore::Biquad::setLowpassParams):
452         (WebCore::Biquad::setHighpassParams):
453         (WebCore::Biquad::setLowShelfParams):
454         (WebCore::Biquad::setZeroPolePairs):
455         * platform/audio/Biquad.h:
456
457 2011-06-03  Adam Barth  <abarth@webkit.org>
458
459         Reviewed by Eric Seidel.
460
461         DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
462         https://bugs.webkit.org/show_bug.cgi?id=62057
463
464         This code gets confused when dealing with inactive DOMWindows.  We
465         should just block inactive DOMWindows because there's no compatibility
466         reason to support them in this code path.
467
468         Test: http/tests/security/xss-DENIED-contentWindow-eval.html
469
470         * page/DOMWindow.cpp:
471         (WebCore::DOMWindow::isInsecureScriptAccess):
472
473 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
474
475         Reviewed by Ryosuke Niwa.
476
477         [GTK] Support smart replace for the pasteboard
478         https://bugs.webkit.org/show_bug.cgi?id=61734
479
480         Add smart replace support to WebCore and add hooks for it in WebKit
481         via DumpRenderTreeSupportGtk. When a platform supports smart replace,
482         WebCore will remove extra spaces that appear when pasting text. Eventually
483         WebKitGTK+ may want to expose this in the public API.
484
485         * platform/gtk/PasteboardGtk.cpp:
486         (WebCore::Pasteboard::writeSelection): Now pass whether or not to use smart replace
487         when calling writeSelection.
488         (WebCore::Pasteboard::canSmartReplace): Added an implementation that checks the clipboard
489         for whether or not it supports smart paste.
490         * platform/gtk/PasteboardHelper.cpp:
491         (WebCore::initGdkAtoms): Added initialization for smart replace atom.
492         (WebCore::PasteboardHelper::fillSelectionData): Added no-op handler for smart replace atom.
493         (WebCore::PasteboardHelper::targetListForDataObject): Properly handle new smart replace parameter.
494         (WebCore::PasteboardHelper::writeClipboardContents): Properly handle new smart replace parameter.
495         (WebCore::PasteboardHelper::clipboardContentSupportsSmartReplace): Added helper for Pasteboard.
496         * platform/gtk/PasteboardHelper.h: Add new method definition.
497
498 2011-06-03  Levi Weintraub  <leviw@chromium.org>
499
500         Reviewed by Eric Seidel.
501
502         Switch paintCell to use IntPoint
503         https://bugs.webkit.org/show_bug.cgi?id=62033
504
505         Switching paintCell to take an IntPoint representing the paint offset
506         instead of a pair of ints.
507
508         No new tests since this is simple refactoring.
509
510         * rendering/RenderTableSection.cpp:
511         (WebCore::RenderTableSection::paintCell):
512         (WebCore::RenderTableSection::paintObject):
513         * rendering/RenderTableSection.h:
514
515 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
516
517         Reviewed by Dimitri Glazkov.
518
519         Teach Gtk build about window.internals
520         https://bugs.webkit.org/show_bug.cgi?id=61071
521
522         * GNUmakefile.am: Add new internals directories to the VPATH
523         (for idl processing) and the include list.
524
525 2011-06-03  Levi Weintraub  <leviw@chromium.org>
526
527         Reviewed by Eric Seidel.
528
529         Switch paintBackgroundsBehindCell to use IntPoint
530         https://bugs.webkit.org/show_bug.cgi?id=62031
531
532         Switching paintBackgroundsBehindCell to take an IntPoint representing
533         the paint offset instead of a pair of ints.
534
535         No new tests as this is simple refactoring.
536
537         * rendering/RenderTableCell.cpp:
538         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
539         (WebCore::RenderTableCell::paintBoxDecorations):
540         * rendering/RenderTableCell.h:
541         * rendering/RenderTableRow.cpp:
542         (WebCore::RenderTableRow::paint):
543         * rendering/RenderTableSection.cpp:
544         (WebCore::RenderTableSection::paintCell):
545
546 2011-06-03  Levi Weintraub  <leviw@chromium.org>
547
548         Reviewed by Eric Seidel.
549
550         Switch paintCaret and paintDragCaret to use IntPoint
551         https://bugs.webkit.org/show_bug.cgi?id=62037
552
553         Switching paintCaret and paintDragCaret to use an IntPoint representing
554         the paint offset instead of a pair of ints.
555
556         No new tests since this is simple refactoring.
557
558         * editing/FrameSelection.cpp:
559         (WebCore::FrameSelection::paintCaret):
560         (WebCore::CaretBase::paintCaret):
561         (WebCore::DragCaretController::paintDragCaret):
562         * editing/FrameSelection.h:
563         * rendering/RenderBlock.cpp:
564         (WebCore::RenderBlock::paintCaret):
565         (WebCore::RenderBlock::paintObject):
566         (WebCore::RenderBlock::positionForPoint):
567         (WebCore::RenderBlock::offsetForContents):
568         * rendering/RenderBlock.h:
569
570 2011-06-03  Levi Weintraub  <leviw@chromium.org>
571
572         Reviewed by Eric Seidel.
573
574         Switch paintItemForeground and paintItemForeground to use IntPoint
575         https://bugs.webkit.org/show_bug.cgi?id=62035
576
577         Switching paintItemFore/Background to use IntPoint instead of a pair of ints.
578
579         No new tests since this is simple refactoring.
580
581         * rendering/RenderListBox.cpp:
582         (WebCore::RenderListBox::paintObject):
583         (WebCore::RenderListBox::paintItemForeground):
584         (WebCore::RenderListBox::paintItemBackground):
585         * rendering/RenderListBox.h:
586
587 2011-06-03  Alexis Menard  <alexis.menard@openbossa.org>
588
589         Reviewed by Andreas Kling.
590
591         To support building namespaced Qt, we require that forward-declarations
592         of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
593
594         * platform/network/qt/QtMIMETypeSniffer.h:
595
596 2011-06-03  Rob Buis  <rbuis@rim.com>
597
598         Reviewed by Nikolas Zimmermann.
599
600         Cleanup member variable usage in svg/animation classes
601         https://bugs.webkit.org/show_bug.cgi?id=62029
602
603         Cleanup member variables.
604
605         * svg/animation/SMILTimeContainer.cpp:
606         (WebCore::SMILTimeContainer::SMILTimeContainer):
607         (WebCore::SMILTimeContainer::sampleAnimationAtTime):
608         (WebCore::SMILTimeContainer::updateAnimations):
609         * svg/animation/SMILTimeContainer.h:
610         * svg/animation/SVGSMILElement.cpp:
611         (WebCore::SVGSMILElement::SVGSMILElement):
612         * svg/animation/SVGSMILElement.h:
613
614 2011-06-03  Chris Rogers  <crogers@google.com>
615
616         Reviewed by Kenneth Russell.
617
618         Add AudioParam parameter scheduling implementation
619         https://bugs.webkit.org/show_bug.cgi?id=61830
620
621         No new tests since audio API is not yet implemented.
622
623         * WebCore.gypi:
624         * WebCore.xcodeproj/project.pbxproj:
625         * webaudio/AudioParam.cpp:
626         (WebCore::AudioParam::value):
627         (WebCore::AudioParam::smoothedValue):
628         (WebCore::AudioParam::smooth):
629         (WebCore::AudioParam::calculateSampleAccurateValues):
630         * webaudio/AudioParam.h:
631         (WebCore::AudioParam::setContext):
632         (WebCore::AudioParam::context):
633         (WebCore::AudioParam::setValueAtTime):
634         (WebCore::AudioParam::linearRampToValueAtTime):
635         (WebCore::AudioParam::exponentialRampToValueAtTime):
636         (WebCore::AudioParam::setTargetValueAtTime):
637         (WebCore::AudioParam::setValueCurveAtTime):
638         (WebCore::AudioParam::cancelScheduledValues):
639         (WebCore::AudioParam::hasTimelineValues):
640         * webaudio/AudioParam.idl:
641         * webaudio/AudioParamTimeline.cpp: Added.
642         (WebCore::AudioParamTimeline::setValueAtTime):
643         (WebCore::AudioParamTimeline::linearRampToValueAtTime):
644         (WebCore::AudioParamTimeline::exponentialRampToValueAtTime):
645         (WebCore::AudioParamTimeline::setTargetValueAtTime):
646         (WebCore::AudioParamTimeline::setValueCurveAtTime):
647         (WebCore::isValidNumber):
648         (WebCore::AudioParamTimeline::insertEvent):
649         (WebCore::AudioParamTimeline::cancelScheduledValues):
650         (WebCore::AudioParamTimeline::valueForContextTime):
651         (WebCore::AudioParamTimeline::valuesForTimeRange):
652         (WebCore::timeToSampleFrame):
653         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
654         * webaudio/AudioParamTimeline.h: Added.
655         (WebCore::AudioParamTimeline::AudioParamTimeline):
656         (WebCore::AudioParamTimeline::hasValues):
657         (WebCore::AudioParamTimeline::ParamEvent::ParamEvent):
658         (WebCore::AudioParamTimeline::ParamEvent::type):
659         (WebCore::AudioParamTimeline::ParamEvent::value):
660         (WebCore::AudioParamTimeline::ParamEvent::time):
661         (WebCore::AudioParamTimeline::ParamEvent::timeConstant):
662         (WebCore::AudioParamTimeline::ParamEvent::duration):
663         (WebCore::AudioParamTimeline::ParamEvent::curve):
664
665 2011-06-01  Jer Noble  <jer.noble@apple.com>
666
667         Reviewed by Simon Fraser.
668
669         Flash of broken page when exiting full screen at jerryseinfeld.com
670         https://bugs.webkit.org/show_bug.cgi?id=61897
671         <rdar://problem/9522985>
672
673         Test: fullscreen/full-screen-placeholder.html
674
675         Entering full-screen mode is causing the page layout to change because the full-screen
676         element is taken out of the normal flow.  To counteract this effect, insert a placeholder
677         block as a parent of the full-screen renderer with the same size and style as the full-screen
678         element pre-full-screen.
679
680         Only create a placeholder for block-level elements; the technique required for inline elements
681         would be vastly more complicated.
682
683         * dom/Document.cpp:
684         (WebCore::Document::webkitWillEnterFullScreenForElement): Create a placeholder
685             based on the size and style of the full-screen element.
686         (WebCore::Document::setFullScreenRenderer): Persist the placeholder size and 
687             style across new renderers.
688         * rendering/RenderFullScreen.cpp:
689         (RenderFullScreen::RenderFullScreen): Added ivar.
690         (RenderFullScreen::destroy): Make sure to safely destroy our placeholder.
691         (RenderFullScreen::createPlaceholder): Added.
692         * rendering/RenderFullScreen.h:
693         (WebCore::RenderFullScreen::placeholder): Ivar accessor.
694
695 2011-06-03  Levi Weintraub  <leviw@chromium.org>
696
697         Reviewed by Eric Seidel.
698
699         Switch paintBoxDecorations to IntPoint
700         https://bugs.webkit.org/show_bug.cgi?id=61968
701
702         Switching paintBoxDecorations to take an IntPoint representing
703         the paint offset instead of a pair of ints. Also cleaning up
704         some duplicated code in InlineFlowBox related to constraining
705         the paint rect to the linetop and linebottom.
706
707         No new tests since this is just refactoring.
708
709         * rendering/InlineFlowBox.cpp:
710         (WebCore::InlineFlowBox::paint):
711         (WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded): Added
712         to remove duplicate code in paintBoxDecorations and paintMask.
713         (WebCore::InlineFlowBox::paintBoxDecorations):
714         (WebCore::InlineFlowBox::paintMask):
715         * rendering/InlineFlowBox.h:
716         * rendering/RenderBlock.cpp:
717         (WebCore::RenderBlock::paintObject):
718         * rendering/RenderBox.cpp:
719         (WebCore::RenderBox::paintBoxDecorations):
720         * rendering/RenderBox.h:
721         * rendering/RenderFieldset.cpp:
722         (WebCore::RenderFieldset::paintBoxDecorations):
723         * rendering/RenderFieldset.h:
724         * rendering/RenderReplaced.cpp:
725         (WebCore::RenderReplaced::paint):
726         * rendering/RenderTable.cpp:
727         (WebCore::RenderTable::paintObject):
728         (WebCore::RenderTable::paintBoxDecorations):
729         * rendering/RenderTable.h:
730         * rendering/RenderTableCell.cpp:
731         (WebCore::RenderTableCell::paintBoxDecorations):
732         * rendering/RenderTableCell.h:
733         * rendering/RenderView.cpp:
734         (WebCore::RenderView::paintBoxDecorations):
735         * rendering/RenderView.h:
736         * rendering/RenderWidget.cpp:
737         (WebCore::RenderWidget::paint):
738         * rendering/svg/RenderSVGRoot.cpp:
739         (WebCore::RenderSVGRoot::paint):
740
741 2011-06-03  Doreen Jiang  <doreen.jiang@nokia.com>
742
743         Reviewed by Benjamin Poulain.
744
745         [Qt]The minimum size of the select menu list is incorrect for qtwebkit
746         https://bugs.webkit.org/show_bug.cgi?id=56752
747
748         The minimum width of the select-box is calculated to be as small as possible 
749         instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
750         This will avoid overapping the select lists in popular websites.
751
752         Test: fast/forms/selectlist-minsize.html
753
754         * platform/qt/RenderThemeQt.cpp:
755         (WebCore::RenderThemeQt::minimumMenuListSize):
756
757 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
758
759         Reviewed by Darin Adler.
760
761         Prevent event dispatch for events with related target when host is the target.
762         https://bugs.webkit.org/show_bug.cgi?id=61979
763
764         Turns out, even if we trim the ancestor chain to 0, the event is still dispatched during AT_TARGET.
765         So might as well be explicit about what we are trying to do and add a flag to prevent dispatch in these cases.
766
767         * dom/EventDispatcher.cpp:
768         (WebCore::EventDispatcher::adjustToShadowBoundaries): Added preventing dispatch when the ancestor chain is trimmed to nothing.
769         (WebCore::EventDispatcher::EventDispatcher): Added initializer.
770         (WebCore::EventDispatcher::dispatchEvent): Added a check to prevent dispatch.
771         * dom/EventDispatcher.h: Added a def.
772
773 2011-06-03  Dan Bernstein  <mitz@apple.com>
774
775         Mac build fix.
776
777         * WebCore.xcodeproj/project.pbxproj:
778
779 2011-06-03  Naoki Takano  <takano.naoki@gmail.com>
780
781         Reviewed by Eric Seidel.
782
783         [Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
784         https://bugs.webkit.org/show_bug.cgi?id=61260
785         http://code.google.com/p/chromium/issues/detail?id=12721
786
787         Manual test: select-popup-tooltip-test.html
788
789         * manual-tests/select-popup-tooltip-test.html: Added.
790         * platform/chromium/PopupMenuChromium.cpp:
791         (WebCore::PopupContainer::getSelectedItemToolTip): Get selected item tooltip string according to hovering mouse position.
792         * platform/chromium/PopupMenuChromium.h: Add getSelectedItemToolTip() declaration.
793
794 2011-06-03  Rob Buis  <rbuis@rim.com>
795
796         Reviewed by Nikolas Zimmermann.
797
798         Creating <animateMotion> elements via javascript do not execute
799         https://bugs.webkit.org/show_bug.cgi?id=34301
800
801         Enable constructors for SVGMPathElement and SVGAnimateMotionElement.
802
803         * DerivedSources.cpp:
804         * DerivedSources.make:
805         * GNUmakefile.list.am:
806         * WebCore.gypi:
807         * WebCore.vcproj/WebCore.vcproj:
808         * WebCore.xcodeproj/project.pbxproj:
809         * page/DOMWindow.idl:
810
811 2011-06-03  Hans Wennborg  <hans@chromium.org>
812
813         Reviewed by Steve Block.
814
815         IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
816         https://bugs.webkit.org/show_bug.cgi?id=62009
817
818         This constant should only be needed inside IDBLevelDBCoding.cpp.
819
820         No new functionality, no new tests.
821
822         * storage/IDBLevelDBBackingStore.cpp:
823         (WebCore::getNewDatabaseId):
824         (WebCore::IDBLevelDBBackingStore::getObjectStores):
825         (WebCore::getNewObjectStoreId):
826         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
827         (WebCore::getNewIndexId):
828         * storage/IDBLevelDBCoding.cpp:
829         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encodeMaxKey):
830         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey):
831         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey):
832         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encodeMaxKey):
833         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encodeMaxKey):
834         * storage/IDBLevelDBCoding.h:
835
836 2011-06-03  Siddharth Mathur  <siddharth.mathur@nokia.com>
837
838         Reviewed by Benjamin Poulain.
839
840         [Qt] Build flag for experimental ICU library support
841         https://bugs.webkit.org/show_bug.cgi?id=60786
842
843         Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental 
844         ICU powered Unicode support. 
845
846         No new tests as no new features added.
847
848         * WebCore.pri: Removed text_breaking_with_icu CONFIG flag. 
849         * WebCore.pro: Added TextCodecICU.cpp and qt/TextBreakIteratorInternalICUQt.cpp.
850         * editing/qt/SmartReplaceQt.cpp:
851         * features.pri: Support for use_system_icu CONFIG flag.
852         * platform/text/TextCodecICU.cpp: Guard with USE(ICU_UNICODE). 
853         * platform/text/qt/TextBreakIteratorInternalICUQt.cpp: Added.
854         (WebCore::Q_GLOBAL_STATIC_WITH_INITIALIZER):
855         (WebCore::currentSearchLocaleID):
856         (WebCore::currentTextBreakLocaleID):
857         * platform/text/qt/TextBreakIteratorQt.cpp: Moved out currentTextBreakLocaleID(). 
858         (WebCore::isTextBreak):
859         * platform/text/qt/TextCodecQt.cpp: Guard with USE(QT4_UNICODE). 
860         (WebCore::TextCodecQt::registerEncodingNames):
861         (WebCore::TextCodecQt::registerCodecs):
862
863 2011-06-03  Yael Aharon  <yael.aharon@nokia.com>
864
865         Reviewed by Kenneth Rohde Christiansen.
866
867         Frame flattening is broken with nested frames
868         https://bugs.webkit.org/show_bug.cgi?id=61491
869
870         Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.
871
872         Test: fast/frames/flattening/iframe-flattening-out-of-view.html
873               fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
874               fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
875
876         * rendering/RenderIFrame.cpp:
877         (WebCore::RenderIFrame::flattenFrame):
878
879 2011-06-03  Nikolas Zimmermann  <nzimmermann@rim.com>
880
881         Reviewed by Andreas Kling.
882
883         Incorrect embedded document replaced size calculation for box-sizing: border-box
884         https://bugs.webkit.org/show_bug.cgi?id=62007
885
886         When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
887         which has an intrinsic width/height, the embedded document intrinsic size is incorrect.
888
889         RenderPart::computeEmbeddedDocumentReplacedWidth/Height has to ask the content renderer for the replaced width/height not ourselves.
890
891         Tests: svg/as-image/img-preserveAspectRatio-support-2.html
892                svg/as-object/object-box-sizing-no-width-height.html
893
894         * rendering/RenderPart.cpp:
895         (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
896         (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
897
898 2011-06-03  Sheriff Bot  <webkit.review.bot@gmail.com>
899
900         Unreviewed, rolling out r88004.
901         http://trac.webkit.org/changeset/88004
902         https://bugs.webkit.org/show_bug.cgi?id=62008
903
904         This patch broke 4 tests in the GTK bots (Requested by
905         msanchez on #webkit).
906
907         * accessibility/gtk/AXObjectCacheAtk.cpp:
908         (WebCore::AXObjectCache::handleScrolledToAnchor):
909
910 2011-06-03  Nikolas Zimmermann  <nzimmermann@rim.com>
911
912         Reviewed by Andreas Kling.
913
914         Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
915         https://bugs.webkit.org/show_bug.cgi?id=62005
916
917         Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
918         Get rid of the dependency between RenderSVGRoot and SVGSVGElement::currentScale(), always ask for the effective
919         zoom in the RenderStyle instead of asking SVGSVGElement.
920
921         The SVGSVGElement::currentScale()/setCurrentScale() methods are now only used when called from the bindings (eg. JS).
922         They only take effect on the outermost <svg> element in standalone documents, otherwhise they are no-ops.
923
924         Test: svg/zoom/page/zoom-svg-through-object-with-auto-size.html
925
926         * rendering/svg/RenderSVGRoot.cpp:
927         (WebCore::RenderSVGRoot::computeIntrinsicWidth):
928         (WebCore::RenderSVGRoot::computeIntrinsicHeight):
929         (WebCore::RenderSVGRoot::localToBorderBoxTransform):
930         * svg/SVGSVGElement.cpp:
931         (WebCore::SVGSVGElement::SVGSVGElement):
932         (WebCore::SVGSVGElement::currentScale):
933         (WebCore::SVGSVGElement::setCurrentScale):
934         * svg/SVGSVGElement.h:
935
936 2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>
937
938         Reviewed by Martin Robinson.
939
940         Focus and caret position should be updated when same-page links are followed
941         https://bugs.webkit.org/show_bug.cgi?id=59737
942
943         Update the caret position to the anchor's position after scrolling.
944
945         This behavior is specific to the Gtk port and requested because of
946         accessibility needs, that's why it's implemented in AXObjectCache.
947
948         Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html
949
950         * accessibility/gtk/AXObjectCacheAtk.cpp:
951         (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the
952         caret is updated to be in the anchor's position after scrolling.
953
954 2011-06-03  Dominic Cooney  <dominicc@chromium.org>
955
956         Reviewed by Kent Tamura.
957
958         Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
959         https://bugs.webkit.org/show_bug.cgi?id=61984
960
961         When cloneNode's tag name-based cloning algorithm clones the
962         KeygenSelectElements of a keygen shadow as select elements. These
963         lack the -webkit-keygen-select pseudoclass.
964
965         Test: fast/html/clone-keygen.html
966
967         * html/HTMLKeygenElement.cpp:
968         (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.
969
970 2011-06-02  MORITA Hajime  <morrita@google.com>
971         
972         Unreviewed ChangeLog fix.
973         
974 2011-06-03  Peter Varga  <pvarga@webkit.org>
975
976         Rubber-stamped by Csaba Osztrogonác.
977         
978         [Qt][V8] Buildfix after r87988.
979
980         No new tests needed.
981
982         * bindings/v8/ScheduledAction.cpp: Add missing guards.
983         (WebCore::ScheduledAction::execute):
984         * bindings/v8/V8EventListener.cpp: Ditto.
985         (WebCore::V8EventListener::callListenerFunction):
986
987 2011-06-03  Dominic Cooney  <dominicc@chromium.org>
988
989         Reviewed by Kent Tamura.
990
991         Cloned range input sliders should be SliderThumbElements, not divs.
992         https://bugs.webkit.org/show_bug.cgi?id=61982
993
994         Test: fast/html/clone-range.html
995
996         * html/shadow/SliderThumbElement.h:
997         (WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Create a SliderThumbElement when being cloned.
998
999 2011-06-02  Yury Semikhatsky  <yurys@chromium.org>
1000
1001         Reviewed by Pavel Feldman.
1002
1003         Web Inspector: add an option for automatically attaching to new workers
1004         https://bugs.webkit.org/show_bug.cgi?id=61930
1005
1006         Worker list is extended with a checkbox that makes inspector attach to each
1007         new worker. Whenever a new worker context starts a new inspector window will
1008         be opened for it.
1009
1010         Also worker agent and worker list will be updated when worker context is terminated.
1011
1012         * inspector/Inspector.json:
1013         * inspector/InspectorController.cpp:
1014         (WebCore::InspectorController::InspectorController):
1015         * inspector/InspectorInstrumentation.cpp:
1016         (WebCore::InspectorInstrumentation::workerContextTerminatedImpl):
1017         * inspector/InspectorInstrumentation.h:
1018         (WebCore::InspectorInstrumentation::workerContextTerminated):
1019         * inspector/InspectorWorkerAgent.cpp:
1020         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
1021         (WebCore::InspectorWorkerAgent::create):
1022         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
1023         (WebCore::InspectorWorkerAgent::clearFrontend):
1024         (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):
1025         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
1026         (WebCore::InspectorWorkerAgent::workerContextTerminated):
1027         * inspector/InspectorWorkerAgent.h:
1028         * inspector/front-end/WorkerManager.js:
1029         (WebInspector.WorkerManager.prototype._workerCreated):
1030         (WebInspector.WorkerManager.prototype._workerTerminated):
1031         (WebInspector.WorkerManager.prototype.openWorkerInspector):
1032         (WebInspector.WorkerManager.prototype._openInspectorWindow):
1033         (WebInspector.WorkerManager.prototype.reset):
1034         (WebInspector.WorkerMessageForwarder.prototype.workerCreated):
1035         (WebInspector.WorkerMessageForwarder.prototype.workerTerminated):
1036         * inspector/front-end/WorkersSidebarPane.js:
1037         (WebInspector.WorkerListSidebarPane):
1038         (WebInspector.WorkerListSidebarPane.prototype._workerAdded):
1039         (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
1040         (WebInspector.WorkerListSidebarPane.prototype._workersCleared):
1041         (WebInspector.WorkerListSidebarPane.prototype._addWorker):
1042         (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
1043         (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
1044         * inspector/front-end/inspector.js:
1045         (WebInspector.reset):
1046
1047 2011-06-02  Hayato Ito  <hayato@chromium.org>
1048
1049         Reviewed by Ryosuke Niwa.
1050
1051         Show a shadow root node itself in Node::traverseNextNodeAcrossFrame.
1052         https://bugs.webkit.org/show_bug.cgi?id=61992
1053
1054         It's better to show a shadow root node itself for debugging.
1055         Skipping it didn't add any values.
1056
1057         No new tests since the function is only available in debug builds.
1058
1059         * dom/Node.cpp:
1060         (WebCore::traverseNextNodeAcrossFrame):
1061
1062 2011-06-02  James Robinson  <jamesr@chromium.org>
1063
1064         Unreviewed, rolling out r87901.
1065         http://trac.webkit.org/changeset/87901
1066         https://bugs.webkit.org/show_bug.cgi?id=61894
1067
1068         Might be responsible for performance regression on Chromium page cyclers, reverting to see...
1069
1070         * loader/DocumentLoader.h:
1071         (WebCore::DocumentLoader::didTellClientAboutLoad):
1072         (WebCore::DocumentLoader::haveToldClientAboutLoad):
1073         * loader/FrameLoader.cpp:
1074         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1075         * loader/ResourceLoadNotifier.cpp:
1076         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
1077
1078 2011-06-02  Levi Weintraub  <leviw@chromium.org>
1079
1080         Reviewed by Eric Seidel.
1081
1082         Switch paintReplaced to use IntPoint
1083         https://bugs.webkit.org/show_bug.cgi?id=61891
1084
1085         Switching paintReplaced to use IntPoint to represent the paint offset instead
1086         of a pair of ints.
1087
1088         Also renaming the IntPoint flavor of IntRect::move to moveBy to clear up the
1089         fact that the IntPoint is added as an offset as opposed to being relocated
1090         to that point.
1091
1092         No tests because this is just a refactoring.
1093
1094         * page/FrameView.cpp:
1095         (WebCore::FrameView::invalidateScrollbarRect):
1096         (WebCore::FrameView::convertFromRenderer):
1097         (WebCore::FrameView::convertToRenderer):
1098         * platform/ScrollView.cpp:
1099         (WebCore::ScrollView::wheelEvent):
1100         * platform/ScrollbarThemeComposite.cpp:
1101         (WebCore::ScrollbarThemeComposite::invalidatePart):
1102         * platform/graphics/gpu/Texture.cpp
1103         (WebCore::Texture::updateSubRect)
1104         * platform/graphics/IntRect.h:
1105         (WebCore::IntRect::moveBy):
1106         * platform/mac/WidgetMac.mm:
1107         (WebCore::Widget::paint):
1108         * rendering/InlineFlowBox.cpp:
1109         (WebCore::InlineFlowBox::paint):
1110         * rendering/RenderBlock.cpp:
1111         (WebCore::RenderBlock::logicalRectToPhysicalRect):
1112         (WebCore::RenderBlock::selectionGaps):
1113         * rendering/RenderBox.cpp:
1114         (WebCore::RenderBox::offsetFromContainer):
1115         (WebCore::RenderBox::computeRectForRepaint):
1116         (WebCore::RenderBox::localCaretRect):
1117         * rendering/RenderDetailsMarker.cpp:
1118         (WebCore::RenderDetailsMarker::paint):
1119         * rendering/RenderEmbeddedObject.cpp:
1120         (WebCore::RenderEmbeddedObject::paintReplaced):
1121         * rendering/RenderEmbeddedObject.h:
1122         * rendering/RenderHTMLCanvas.cpp:
1123         (WebCore::RenderHTMLCanvas::paintReplaced):
1124         * rendering/RenderHTMLCanvas.h:
1125         * rendering/RenderImage.cpp:
1126         (WebCore::RenderImage::paintReplaced):
1127         * rendering/RenderImage.h:
1128         * rendering/RenderInline.cpp:
1129         (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
1130         * rendering/RenderLayer.cpp:
1131         (WebCore::expandClipRectForDescendantsAndReflection):
1132         (WebCore::RenderLayer::paintScrollCorner):
1133         (WebCore::RenderLayer::paintResizer):
1134         (WebCore::RenderLayer::paintChildLayerIntoColumns):
1135         (WebCore::RenderLayer::hitTestChildLayerColumns):
1136         (WebCore::RenderLayer::boundingBox):
1137         (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
1138         * rendering/RenderLayerBacking.cpp:
1139         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
1140         (WebCore::paintScrollbar):
1141         (WebCore::RenderLayerBacking::paintContents):
1142         * rendering/RenderLayerCompositor.cpp:
1143         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
1144         (WebCore::RenderLayerCompositor::layerWillBeRemoved):
1145         (WebCore::paintScrollbar):
1146         (WebCore::RenderLayerCompositor::paintContents):
1147         * rendering/RenderListBox.cpp:
1148         (WebCore::RenderListBox::controlClipRect):
1149         * rendering/RenderListItem.cpp:
1150         (WebCore::RenderListItem::positionListMarker):
1151         * rendering/RenderListMarker.cpp:
1152         (WebCore::RenderListMarker::paint):
1153         * rendering/RenderReplaced.cpp:
1154         (WebCore::RenderReplaced::paint):
1155         * rendering/RenderReplaced.h:
1156         (WebCore::RenderReplaced::paintReplaced):
1157         * rendering/RenderTableCell.cpp:
1158         (WebCore::RenderTableCell::computeRectForRepaint):
1159         * rendering/RenderTextControlSingleLine.cpp:
1160         (WebCore::RenderTextControlSingleLine::controlClipRect):
1161         * rendering/RenderVideo.cpp:
1162         (WebCore::RenderVideo::paintReplaced):
1163         * rendering/RenderVideo.h:
1164         * rendering/RenderView.cpp:
1165         (WebCore::RenderView::repaintViewRectangle):
1166
1167 2011-06-02  James Robinson  <jamesr@chromium.org>
1168
1169         Reviewed by Dimitri Glazkov.
1170
1171         [chromium][V8] Add trace events for timer fires and event listener dispatches
1172         https://bugs.webkit.org/show_bug.cgi?id=61977
1173
1174         Adds TRACE_EVENT macro around timer and event listener dispatches.  When tracing (a chromium feature) is
1175         enabled, this allows correlating these events with painting, compositing, and everything else in chromium that
1176         is traced.  When tracing is disabled, this macro does nothing useful.  Trace points are very cheap when tracing
1177         is disabled so this should have no performance impact for non-developers.
1178
1179         * bindings/v8/ScheduledAction.cpp:
1180         (WebCore::ScheduledAction::execute):
1181         * bindings/v8/V8EventListener.cpp:
1182         (WebCore::V8EventListener::callListenerFunction):
1183
1184 2011-06-02  John Bates  <jbates@google.com>
1185
1186         Reviewed by James Robinson.
1187
1188         DrawingBufferChromium cleanup:
1189         - Correct FIXME comment about synchronization.
1190         - Remove unnecessary DrawingBufferInternal indirection struct
1191           and its unused offscreenColorTexture member.
1192         https://bugs.webkit.org/show_bug.cgi?id=61953
1193
1194         * platform/graphics/chromium/DrawingBufferChromium.cpp:
1195         (WebCore::DrawingBuffer::DrawingBuffer):
1196         (WebCore::DrawingBuffer::~DrawingBuffer):
1197         (WebCore::DrawingBuffer::publishToPlatformLayer):
1198         (WebCore::DrawingBuffer::didReset):
1199         (WebCore::DrawingBuffer::platformLayer):
1200         * platform/graphics/gpu/DrawingBuffer.h:
1201
1202 2011-06-02  Andrey Kosyakov  <caseq@chromium.org>
1203
1204         Reviewed by Pavel Feldman.
1205
1206         Web Inspector: ResourceCookiesView.resize() is missing
1207         https://bugs.webkit.org/show_bug.cgi?id=61868
1208
1209         * inspector/front-end/ResourceCookiesView.js:
1210         (WebInspector.ResourceCookiesView.prototype.resize):
1211
1212 2011-06-02  Kent Tamura  <tkent@chromium.org>
1213
1214         Reviewed by Dimitri Glazkov.
1215
1216         REGRESSION(r87014): Cloned text <input> doesn't work well.
1217         https://bugs.webkit.org/show_bug.cgi?id=61909
1218
1219         The default implementation of Element::cloneNode() creates a clone
1220         node by Document::createElement(). So, if a customized class is used for
1221         shadow nodes, cloneNode() doesn't create a node of the correct class.
1222         Such custom classes need to override Element::
1223         cloneElementWithoutAttributesAndChildren().
1224
1225         TextFieldInputType and SearchInputType had references to shadow nodes
1226         initialized in createShadowSubtree(). However createShadowSubtree() is
1227         not called if the host node is cloned. The accessors for shadow nodes
1228         should search a shadow tree.
1229
1230         Test: fast/forms/textfield-clone.html
1231
1232         * html/SearchInputType.cpp:
1233           Remove data members for shadow nodes, and the accessors search the
1234           shadow tree for the requested node by TreeScope::getElementById().
1235         (WebCore::SearchInputType::SearchInputType):
1236         (WebCore::innerBlockId):
1237         (WebCore::resultButtonId):
1238         (WebCore::cancelButtonId):
1239         (WebCore::SearchInputType::createShadowSubtree):
1240         (WebCore::SearchInputType::innerBlockElement):
1241         (WebCore::SearchInputType::resultsButtonElement):
1242         (WebCore::SearchInputType::cancelButtonElement):
1243         * html/SearchInputType.h:
1244         * html/TextFieldInputType.cpp: ditto.
1245         (WebCore::TextFieldInputType::TextFieldInputType):
1246         (WebCore::TextFieldInputType::innerTextId):
1247         (WebCore::spinButtonId):
1248         (WebCore::TextFieldInputType::speechButtonId):
1249         (WebCore::TextFieldInputType::appendChildAndSetId):
1250         (WebCore::TextFieldInputType::createShadowSubtree):
1251         (WebCore::TextFieldInputType::getShadowElementById):
1252         (WebCore::TextFieldInputType::innerTextElement):
1253         (WebCore::TextFieldInputType::innerSpinButtonElement):
1254         (WebCore::TextFieldInputType::speechButtonElement):
1255         * html/TextFieldInputType.h:
1256         * html/shadow/TextControlInnerElements.cpp:
1257           Overrides cloneElementWithoutAttributesAndChildren() in order that cloneNode()
1258           produces an instance of the correct class.
1259         (WebCore::TextControlInnerElement::cloneElementWithoutAttributesAndChildren):
1260         (WebCore::TextControlInnerTextElement::cloneElementWithoutAttributesAndChildren):
1261         (WebCore::SearchFieldResultsButtonElement::cloneElementWithoutAttributesAndChildren):
1262         (WebCore::SearchFieldCancelButtonElement::cloneElementWithoutAttributesAndChildren):
1263         (WebCore::SpinButtonElement::cloneElementWithoutAttributesAndChildren):
1264         (WebCore::InputFieldSpeechButtonElement::cloneElementWithoutAttributesAndChildren):
1265         * html/shadow/TextControlInnerElements.h:
1266
1267 2011-05-28  Martin Robinson  <mrobinson@igalia.com>
1268
1269         Reviewed by Gustavo Noronha Silva.
1270
1271         [GTK] Remove PasteboardHelperGtk
1272         https://bugs.webkit.org/show_bug.cgi?id=61690
1273
1274         Remove the virtual methods from PasteboardHelper, so that PasteboardHelperGtk
1275         can be removed. Since the GtkClipboard IDs are verified to be the same between
1276         WebKit and WebCore we no longer need to communicate from WebCore to WebKit to
1277         get them.
1278
1279         No new tests. This is just a code refactor.
1280
1281         * platform/Pasteboard.h: Remove GTK+ specific methods. They are no longer needed.
1282         * platform/gtk/ClipboardGtk.cpp: Remove the m_helper member and access the
1283         PasteboardHelper singleton directly.
1284         * platform/gtk/ClipboardGtk.h: Ditto.
1285         * platform/gtk/PasteboardGtk.cpp: Ditto.
1286         * platform/gtk/PasteboardHelper.cpp:
1287         (WebCore::removeMarkupPrefix): Remove an extra line.
1288         (WebCore::PasteboardHelper::defaultPasteboardHelper): Added this static getter
1289         for the singleton.
1290         (WebCore::PasteboardHelper::PasteboardHelper): Moved the contents of initTargetList here.
1291         (WebCore::PasteboardHelper::getCurrentClipboard): Instead of talking with WebKit to determine
1292         whether or not to use the primary selection clipboard, just use our new member.
1293         (WebCore::PasteboardHelper::fillSelectionData): Use our local enum to get the ID.
1294         (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
1295         (WebCore::PasteboardHelper::dropAtomsForContext): Ditto.
1296         (WebCore::getClipboardContentsCallback): Ditto.
1297         * platform/gtk/PasteboardHelper.h: PasteboardHelper now keeps track of whether or
1298         not to use the primary selection clipboard internally.
1299         (WebCore::PasteboardHelper::setUsePrimarySelectionClipboard): Added.
1300         (WebCore::PasteboardHelper::usePrimarySelectionClipboard): Added.
1301
1302 2011-06-02  Levi Weintraub  <leviw@chromium.org>
1303
1304         Reviewed by Eric Seidel.
1305
1306         Teach InlineBox about FloatPoint
1307         https://bugs.webkit.org/show_bug.cgi?id=44412
1308
1309         Original patch by Eric Seidel. Updated by me.
1310
1311         This is another step towards more point/size
1312         usage throughout the rendering tree.
1313
1314         Added left(), right(), top(), and bottom() methods
1315         to InlineBox. Removed m_x, and m_y and replaced them
1316         with a single m_topLeft member.
1317
1318         No new tests since this is just a refactoring.
1319
1320         * rendering/EllipsisBox.cpp:
1321         (WebCore::EllipsisBox::paint):
1322         (WebCore::EllipsisBox::selectionRect):
1323         (WebCore::EllipsisBox::paintSelection):
1324         (WebCore::EllipsisBox::nodeAtPoint):
1325         * rendering/EllipsisBox.h:
1326         (WebCore::EllipsisBox::EllipsisBox):
1327         * rendering/InlineBox.cpp:
1328         (WebCore::InlineBox::adjustPosition):
1329         (WebCore::InlineBox::canAccommodateEllipsis):
1330         * rendering/InlineBox.h:
1331         (WebCore::InlineBox::InlineBox):
1332         (WebCore::InlineBox::setX):
1333         (WebCore::InlineBox::x):
1334         (WebCore::InlineBox::left):
1335         (WebCore::InlineBox::setY):
1336         (WebCore::InlineBox::y):
1337         (WebCore::InlineBox::top):
1338         (WebCore::InlineBox::topLeft):
1339         (WebCore::InlineBox::right):
1340         (WebCore::InlineBox::bottom):
1341         (WebCore::InlineBox::logicalLeft):
1342         (WebCore::InlineBox::setLogicalLeft):
1343         (WebCore::InlineBox::logicalTop):
1344         (WebCore::InlineBox::setLogicalTop):
1345         (WebCore::InlineBox::logicalFrameRect):
1346         * rendering/InlineFlowBox.h:
1347         (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
1348         * rendering/InlineTextBox.cpp:
1349         (WebCore::InlineTextBox::placeEllipsisBox):
1350         (WebCore::InlineTextBox::paintTextMatchMarker):
1351         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1352         * rendering/RenderText.cpp:
1353         (WebCore::RenderText::firstRunX):
1354         (WebCore::RenderText::firstRunY):
1355         * rendering/RenderTreeAsText.cpp:
1356         (WebCore::writeTextRun):
1357         * rendering/RootInlineBox.cpp:
1358         (WebCore::RootInlineBox::placeEllipsis):
1359         * rendering/svg/RenderSVGText.cpp:
1360         (WebCore::RenderSVGText::positionForPoint):
1361         * rendering/svg/SVGInlineTextBox.h:
1362         (WebCore::SVGInlineTextBox::selectionTop):
1363         * rendering/svg/SVGRootInlineBox.cpp:
1364         (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
1365
1366 2011-06-02  Jian Li  <jianli@chromium.org>
1367
1368         Reviewed by David Levin.
1369
1370         Update the behavior of multiple reads for FileReader
1371         https://bugs.webkit.org/show_bug.cgi?id=61793
1372
1373         Changed to throw an OperationNotAllowedException with the NOT_ALLOWED_ERR
1374         status code on any of the read methods that occur when readyState = LOADING.
1375         Otherwise, calling any of the read methods should work. 
1376
1377         Test: fast/files/read-file-async.html
1378
1379         * CodeGenerators.pri:
1380         * DerivedSources.cpp:
1381         * DerivedSources.make:
1382         * GNUmakefile.list.am:
1383         * WebCore.gypi:
1384         * WebCore.pro:
1385         * WebCore.vcproj/WebCore.vcproj:
1386         * WebCore.xcodeproj/project.pbxproj:
1387         * bindings/js/JSDOMBinding.cpp:
1388         (WebCore::setDOMException):
1389         * bindings/v8/V8Proxy.cpp:
1390         (WebCore::V8Proxy::setDOMException):
1391         * dom/ExceptionCode.cpp:
1392         (WebCore::getExceptionCodeDescription):
1393         * dom/ExceptionCode.h:
1394         * fileapi/FileReader.cpp:
1395         (WebCore::FileReader::FileReader):
1396         (WebCore::FileReader::hasPendingActivity):
1397         (WebCore::FileReader::readAsArrayBuffer):
1398         (WebCore::FileReader::readAsBinaryString):
1399         (WebCore::FileReader::readAsText):
1400         (WebCore::FileReader::readAsDataURL):
1401         (WebCore::FileReader::readInternal):
1402         (WebCore::FileReader::abort):
1403         (WebCore::FileReader::doAbort):
1404         (WebCore::FileReader::terminate):
1405         (WebCore::FileReader::start):
1406         (WebCore::FileReader::didStartLoading):
1407         (WebCore::FileReader::didFinishLoading):
1408         (WebCore::FileReader::didFail):
1409         * fileapi/FileReader.h:
1410         (WebCore::FileReader::readyState):
1411         * fileapi/FileReader.idl:
1412         * fileapi/OperationNotAllowedException.h: Added.
1413         (WebCore::OperationNotAllowedException::create):
1414         (WebCore::OperationNotAllowedException::OperationNotAllowedException):
1415         * fileapi/OperationNotAllowedException.idl: Added.
1416
1417 2011-06-02  Adrienne Walker  <enne@google.com>
1418
1419         Reviewed by James Robinson.
1420
1421         [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
1422         https://bugs.webkit.org/show_bug.cgi?id=61954
1423
1424         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
1425         (WebCore::CCHeadsUpDisplay::draw):
1426
1427 2011-06-02  Brady Eidson  <beidson@apple.com>
1428
1429         Reviewed by Oliver Hunt.
1430
1431         <rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
1432         Repro crash loading certain webarchives after r87566.
1433
1434         Test: webarchive/loading/javascript-url-iframe-crash.html
1435
1436         * bindings/ScriptControllerBase.cpp:
1437         (WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
1438           cause the DocumentLoader to be destroyed, so protect it with a Ref here.
1439
1440 2011-06-02  Jay Civelli  <jcivelli@chromium.org>
1441
1442         Reviewed by Adam Barth.
1443
1444         Adding MHTML generation support to MHTMLArchive.
1445         https://bugs.webkit.org/show_bug.cgi?id=7169
1446
1447         * loader/archive/mhtml/MHTMLArchive.cpp:
1448         (WebCore::generateRandomBoundary):
1449         (WebCore::replaceNonPrintableCharacters):
1450         (WebCore::MHTMLArchive::generateMHTMLData):
1451         * loader/archive/mhtml/MHTMLArchive.h:
1452         * page/PageSerializer.cpp:
1453         (WebCore::PageSerializer::serializeFrame):
1454         (WebCore::PageSerializer::serializeCSSStyleSheet):
1455         * platform/SharedBuffer.cpp:
1456         (WebCore::SharedBuffer::append):
1457         * platform/SharedBuffer.h:
1458
1459 2011-06-02  Simon Fraser  <simon.fraser@apple.com>
1460
1461         Reviewed by Andreas Kling.
1462
1463         Share Path code that uses beziers to construct a rounded rect
1464         https://bugs.webkit.org/show_bug.cgi?id=61960
1465
1466         Have two methods in Path that construct beziers for rounded
1467         rects to share the same code.
1468         
1469         Make gCircleControlPoint a little more precise, and add
1470         a comment describing its derivation.
1471         
1472         Make use of FloatRect::maxX() and maxY().
1473
1474         * platform/graphics/Path.cpp:
1475         (WebCore::Path::addRoundedRect):
1476         (WebCore::Path::addBeziersForRoundedRect):
1477         * platform/graphics/Path.h:
1478
1479 2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>
1480
1481         Reviewed by Enrica Casucci.
1482
1483         ApplyStyleCommand shouldn't call collapseTextDecorationProperties
1484         https://bugs.webkit.org/show_bug.cgi?id=61887
1485
1486         Removed the call to collapseTextDecorationProperties in ApplyStyleCommand::applyInlineStyle.
1487
1488         No new tests because this is a code refactoring.
1489
1490         * editing/ApplyStyleCommand.cpp:
1491         (WebCore::ApplyStyleCommand::applyInlineStyle): No loner calls collapseTextDecorationProperties.
1492         (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Updated comment.
1493         * editing/EditingStyle.cpp:
1494         (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Added to check both text-decoration
1495         and -webkit-text-decorations-in-effect.
1496         (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Added a comment.
1497         (WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle): Checks both text-decoration
1498         and -webkit-text-decorations-in-effect.
1499         (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Checks if a text decoration
1500         is present in -webkit-text-decorations-in-effect or text-decoration preferring the former.
1501         (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Merged loops for when conflictingProperties
1502         is false and true. Added a support for -webkit-text-decorations-in-effect.
1503
1504 2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>
1505
1506         Reviewed by Eric Seidel.
1507
1508         Make more functions static local in EventHandlers.cpp
1509         https://bugs.webkit.org/show_bug.cgi?id=58503
1510
1511         Removed canHandleDragAndDropForTarget and made focusDirectionForKey local to EventHandler.cpp.
1512
1513         * page/EventHandler.cpp:
1514         (WebCore::targetIsFrame): Extracted from canHandleDragAndDropForTarget.
1515         (WebCore::EventHandler::updateDragAndDrop): Calls contentFrameForTarget instead of canHandleDragAndDropForTarget.
1516         (WebCore::EventHandler::cancelDragAndDrop): Ditto.
1517         (WebCore::EventHandler::performDragAndDrop): Ditto.
1518         (WebCore::focusDirectionForKey): No longer a member function of EventHandler class.
1519         (WebCore::handleKeyboardSelectionMovement): No longer a member function of EventHandler class; also calls
1520         focusDirectionForKey instead of manually comparing.
1521         * page/EventHandler.h:
1522
1523 2011-06-02  Alok Priyadarshi  <alokp@chromium.org>
1524
1525         Reviewed by James Robinson.
1526
1527         [chromium] Things jump around when selecting anything on the page
1528         https://bugs.webkit.org/show_bug.cgi?id=61639
1529
1530         WebCore::LayerTextureUpdaterSkPicture::updateTextureRect was not updating a tile sub-region properly.
1531         It did not consider dest-rect when selecting the clip and translation required to draw the content-rect into dest-rect.
1532         Also removed clearing of framebuffer because it used to clear the whole tile not just dest-rect.
1533         An appropriate viewport could be set to just clear the dest-rect, but it was debug only code and I did not want to mess
1534         with the viewport set by skia.
1535
1536         No new tests. This case should be covered by most of the layout tests (pixel) targeting selection or hovering when chromium is run in compositing mode.
1537         Here is a non-exhaustive list of existing tests covering this case.
1538         Test: editing/selection/14971.html (existing)
1539               editing/selection/3690703-2.html (existing)
1540               editing/selection/4402375.html (existing)
1541               editing/selection/4818145.html (existing)
1542
1543         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
1544         (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
1545         (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
1546         * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
1547
1548 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1549
1550         Reviewed by Darin Adler.
1551
1552         Add build logistics and plumbing for window.internals object.
1553         https://bugs.webkit.org/show_bug.cgi?id=60313
1554
1555         Test: fast/harness/internals-object.html
1556
1557         * Configurations/WebCoreTestSupport.xcconfig: Added.
1558         * DerivedSources.make: Added support for generating from Internals.idl.
1559         * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
1560         * WebCore.gypi: Ditto.
1561         * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
1562         * testing/Internals.cpp: Added.
1563         * testing/Internals.h: Added.
1564         * testing/Internals.idl: Added.
1565         * testing/js/WebCoreTestSupport.cpp: Added.
1566         * testing/js/WebCoreTestSupport.h: Added.
1567         * testing/v8/WebCoreTestSupport.cpp: Added.
1568         * testing/v8/WebCoreTestSupport.h: Added.
1569
1570 2011-06-01  Adrienne Walker  <enne@google.com>
1571
1572         Reviewed by Eric Seidel.
1573
1574         [chromium] LayerChromium should use a RefPtr for replica layer
1575         https://bugs.webkit.org/show_bug.cgi?id=61898
1576
1577         Having this member variable be a raw pointer is brittle and assumes
1578         that the GraphicsLayer tree keeps this in sync.  There aren't any
1579         known bugs caused by this, but it seems like good sense to do this.
1580
1581         * platform/graphics/chromium/LayerChromium.h:
1582         (WebCore::LayerChromium::replicaLayer):
1583
1584 2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>
1585
1586         Reviewed by Eric Seidel.
1587
1588         REGRESSION: inline style is lost when deleting line break between paragraphs with same style
1589         https://bugs.webkit.org/show_bug.cgi?id=61899
1590
1591         The bug was caused by ReplaceSelectionCommand::doApply's calling handleStyleSpansBeforeInsertion
1592         before insertionPos is adjusted by positionAvoidingPrecedingNodes and positionOutsideTabSpan.
1593
1594         Fixed the bug by calling handleStyleSpansBeforeInsertion after the calls to these two functions.
1595
1596         Test: editing/deleting/delete-line-break-between-paragraphs-with-same-style.html
1597
1598         * editing/ReplaceSelectionCommand.cpp:
1599         (WebCore::ReplaceSelectionCommand::doApply):
1600
1601 2011-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1602
1603         Reviewed by Simon Fraser.
1604
1605         REGRESSION: Text selection broken for text with line-height applied
1606         https://bugs.webkit.org/show_bug.cgi?id=54929
1607
1608         The bug was caused by RenderText::positionForPoint's not considering the case where a point is
1609         above selectionTop and below lineTop of the first root inline box. Fixed the bug by considering
1610         any point between selectionTop and lineTop to be inside a root inline box. This condition is
1611         consistent with the condition we use to determine the bottom of a line.
1612
1613         Test: editing/selection/hit-test-on-text-with-line-height.html
1614
1615         * rendering/RenderBlock.cpp:
1616         (WebCore::RenderBlock::positionForPointWithInlineChildren): Fixed a condition to determine whether
1617         or not a point is above the first root line box. We need to check both selectionTop and logicalTop
1618         for the same reason explained above.
1619         * rendering/RenderText.cpp:
1620         (WebCore::RenderText::positionForPoint): See above.
1621
1622 2011-06-02  Andreas Kling  <kling@webkit.org>
1623
1624         Reviewed by James Robinson.
1625
1626         Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
1627         https://bugs.webkit.org/show_bug.cgi?id=61944
1628
1629         Call setFillColor/setStrokeColor (instead of setFillStyle/setStrokeStyle)
1630         for string styles. This ensures that system color resolution is performed,
1631         and matches what the JSC bindings do.
1632
1633         Test: canvas/philip/tests/2d.fillStyle.parse.system.html
1634
1635         * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
1636         (WebCore::toCanvasStyle):
1637         (WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):
1638         (WebCore::V8CanvasRenderingContext2D::fillStyleAccessorSetter):
1639
1640 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1641
1642         Unreviewed, rolling out r87920.
1643         http://trac.webkit.org/changeset/87920
1644         https://bugs.webkit.org/show_bug.cgi?id=61943
1645
1646         This patch does not build in Win Builder (dbg)(shared)
1647         downstream (Requested by abarth|gardener on #webkit).
1648
1649         * platform/chromium/PopupMenuChromium.cpp:
1650         (WebCore::PopupContainer::showPopup):
1651         (WebCore::PopupListBox::handleMouseReleaseEvent):
1652         (WebCore::PopupListBox::acceptIndex):
1653
1654 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1655
1656         Unreviewed, rolling out r87926.
1657         http://trac.webkit.org/changeset/87926
1658         https://bugs.webkit.org/show_bug.cgi?id=60313
1659
1660         Fails to find WebCoreTestSupport.dylib on bots.
1661
1662         * Configurations/WebCore.xcconfig:
1663         * Configurations/WebCoreTestSupport.xcconfig: Removed.
1664         * DerivedSources.make:
1665         * WebCore.exp.in:
1666         * WebCore.gyp/WebCore.gyp:
1667         * WebCore.gypi:
1668         * WebCore.xcodeproj/project.pbxproj:
1669         * bindings/js/JSDOMWrapper.cpp:
1670         (WebCore::JSDOMWrapper::~JSDOMWrapper):
1671         * bindings/js/JSDOMWrapper.h:
1672         * testing/Internals.cpp: Removed.
1673         * testing/Internals.h: Removed.
1674         * testing/Internals.idl: Removed.
1675         * testing/js/WebCoreTestSupport.cpp: Removed.
1676         * testing/js/WebCoreTestSupport.h: Removed.
1677         * testing/v8/WebCoreTestSupport.cpp: Removed.
1678         * testing/v8/WebCoreTestSupport.h: Removed.
1679
1680 2011-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1681
1682         Reviewed by Martin Robinson.
1683
1684         [GTK] Implement popup menus in Webkit2
1685         https://bugs.webkit.org/show_bug.cgi?id=61854
1686
1687         Move common code into a new class to be used by both WebKit1 and
1688         WebKit2.
1689
1690         * GNUmakefile.list.am: Add new files to compilation.
1691         * platform/gtk/GtkPopupMenu.cpp: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.cpp.
1692         (WebCore::GtkPopupMenu::GtkPopupMenu):
1693         (WebCore::GtkPopupMenu::~GtkPopupMenu):
1694         (WebCore::GtkPopupMenu::clear): Remove all menu items.
1695         (WebCore::GtkPopupMenu::appendSeparator): Add a new separator
1696         item to the menu.
1697         (WebCore::GtkPopupMenu::appendItem): Add a new item to the menu for
1698         the given action.
1699         (WebCore::GtkPopupMenu::popUp): Show the menu.
1700         (WebCore::GtkPopupMenu::popDown): Hide the menu.
1701         (WebCore::GtkPopupMenu::menuRemoveItem):
1702         (WebCore::GtkPopupMenu::menuPositionFunction):
1703         (WebCore::GtkPopupMenu::resetTypeAheadFindState):
1704         (WebCore::GtkPopupMenu::typeAheadFind):
1705         (WebCore::GtkPopupMenu::selectItemCallback):
1706         (WebCore::GtkPopupMenu::keyPressEventCallback):
1707         * platform/gtk/GtkPopupMenu.h: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.h.
1708         (WebCore::GtkPopupMenu::create):
1709         (WebCore::GtkPopupMenu::platformMenu):
1710         * platform/gtk/PopupMenuGtk.cpp:
1711         (WebCore::PopupMenuGtk::PopupMenuGtk):
1712         (WebCore::PopupMenuGtk::~PopupMenuGtk):
1713         (WebCore::PopupMenuGtk::show): Use GtkPopupMenu.
1714         (WebCore::PopupMenuGtk::hide): Ditto.
1715         (WebCore::PopupMenuGtk::menuItemActivated):
1716         (WebCore::PopupMenuGtk::menuUnmapped):
1717         * platform/gtk/PopupMenuGtk.h:
1718
1719 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
1720
1721         Reviewed by Darin Adler.
1722
1723         Add build logistics and plumbing for window.internals object.
1724         https://bugs.webkit.org/show_bug.cgi?id=60313
1725
1726         Test: fast/harness/internals-object.html
1727
1728         * Configurations/WebCoreTestSupport.xcconfig: Added.
1729         * DerivedSources.make: Added support for generating from Internals.idl.
1730         * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
1731         * WebCore.gypi: Ditto.
1732         * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
1733         * testing/Internals.cpp: Added.
1734         * testing/Internals.h: Added.
1735         * testing/Internals.idl: Added.
1736         * testing/js/WebCoreTestSupport.cpp: Added.
1737         * testing/js/WebCoreTestSupport.h: Added.
1738         * testing/v8/WebCoreTestSupport.cpp: Added.
1739         * testing/v8/WebCoreTestSupport.h: Added.
1740
1741 2011-06-02  Naoki Takano  <takano.naoki@gmail.com>
1742
1743         Reviewed by Dimitri Glazkov.
1744
1745         [Chromium] Click event is not fired for a menulist <select>
1746         https://bugs.webkit.org/show_bug.cgi?id=60563
1747
1748         Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
1749
1750         * platform/chromium/PopupMenuChromium.cpp:
1751         (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
1752         (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
1753         (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
1754
1755 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1756
1757         Reviewed by Darin Adler.
1758
1759         Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
1760         https://bugs.webkit.org/show_bug.cgi?id=61892
1761
1762         In the cases where the relatedTarget of an event is an ancestor of the target, and the relatedTarget is
1763         a shadow host, we should not allow events to escape out of the hosted shadow DOM subtree.
1764
1765         * dom/EventDispatcher.cpp:
1766         (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a check that is valid for both new and old shadow DOM.
1767
1768 2011-06-02  Hans Wennborg  <hans@chromium.org>
1769
1770         Reviewed by Tony Gentilcore.
1771
1772         Fix LevelDBTransaction::clearTree()
1773         https://bugs.webkit.org/show_bug.cgi?id=61917
1774
1775         This was broken in the code I copied it from; we can't delete and walk
1776         the tree at the same time.
1777
1778         No new functionality, no new tests.
1779
1780         * platform/leveldb/LevelDBTransaction.cpp:
1781         (WebCore::LevelDBTransaction::clearTree):
1782
1783 2011-06-02  Andreas Kling  <kling@webkit.org>
1784
1785         Rubber-stamped by Simon Hausmann.
1786
1787         Remove Qt's precompiled header hack as it was broken, and was not even
1788         used unless building WebKit inside a Qt tree.
1789
1790         * WebCore.pri:
1791
1792 2011-06-02  James Robinson  <jamesr@chromium.org>
1793
1794         Reviewed by Brady Eidson.
1795
1796         DocumentLoader keeps a reference to all URL strings ever loaded leading to lots of memory waste
1797         https://bugs.webkit.org/show_bug.cgi?id=61894
1798
1799         DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs that have passed through
1800         FrameLoader::dispatchWillSendRequest() and is used by FrameLoader::loadedResourceFromMemoryCached to decide
1801         whether to inform the FrameLoader's m_client about this load.  Unfortunately, this set holds a reference to the
1802         URL string for every resource loaded, so on pages that use data URLs to "load" large amounts of data this leaks
1803         lots of memory.
1804
1805         This set only has an effect on the Mac port, as the only two ports that implement
1806         FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache() are Chromium and Mac and the Chromium implementation
1807         can correctly handle receiving multiple callbacks.  This patch limits the set to only PLATFORM(MAC) so other
1808         ports do not have to pay this memory cost.  It's possible that a better fix exists specifically for the Mac port
1809         implementation, but that would have to determined by someone who works on that port specifically.
1810
1811         * loader/DocumentLoader.h:
1812         (WebCore::DocumentLoader::didTellClientAboutLoad):
1813         (WebCore::DocumentLoader::haveToldClientAboutLoad):
1814
1815 2011-06-02  Aparna Nandyal  <aparna.nand@wipro.com>
1816
1817         Reviewed by Andreas Kling.
1818
1819         [Qt] Multiple drop events when doing DnD of images.
1820         https://bugs.webkit.org/show_bug.cgi?id=61504
1821
1822         Duplicate entries of the url were getting added into drag data
1823         which is removed. The duplicate entries were causing the same image
1824         url to be copied twice. The code changes now match other webkit ports.
1825
1826         * platform/qt/ClipboardQt.cpp:
1827         (WebCore::ClipboardQt::declareAndWriteDragImage):
1828
1829 2011-06-02  Naiem Shaik  <naiem.shaik@gmail.com>
1830
1831         Reviewed by Kent Tamura.
1832         
1833         Fixing invalid value being returned for default checkbox and radio state
1834         https://bugs.webkit.org/show_bug.cgi?id=61674
1835
1836         As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
1837         http://www.w3.org/TR/html5/number-state.html#radio-button-state:
1838         The value IDL attribute is in mode default/on: 
1839         If the element has a value attribute, it must return that attribute's 
1840         value; otherwise, it must return the string "on".  
1841         Currently default value is empty string;Default value of Radio button 
1842         and checkbox should be "on".Changed fallbackValue function to return the same
1843         This works as per spec in IE9,Firefox and Opera
1844
1845         Tests: fast/forms/checkbox-default-value.html
1846                fast/forms/radio-default-value.html
1847
1848         * html/BaseCheckableInputType.cpp:
1849         (WebCore::BaseCheckableInputType::fallbackValue):
1850
1851 2011-06-02  Kent Tamura  <tkent@chromium.org>
1852
1853         [Chromium/Mac] Fix a wrong merge for r87881
1854         https://bugs.webkit.org/show_bug.cgi?id=61845
1855
1856         * platform/chromium/ThemeChromiumMac.mm:
1857         (WebCore::paintStepper):
1858
1859 2011-06-02  Ian Henderson  <ianh@apple.com>
1860
1861         Reviewed by Simon Fraser.
1862
1863         [CG] GraphicsContext::fillRoundedRect() ignores the gradient fill the CGContextFillEllipseInRect() code path
1864         https://bugs.webkit.org/show_bug.cgi?id=61882
1865
1866         If we have a gradient or pattern fill set, take the slow path, which
1867         handles these cases properly.
1868
1869         No new tests, since we never try to fill a rounded rect with a
1870         gradient or pattern.
1871
1872         * platform/graphics/cg/GraphicsContextCG.cpp:
1873         (WebCore::GraphicsContext::fillRoundedRect):
1874
1875 2011-06-02  MORITA Hajime  <morrita@google.com>
1876
1877         Reviewed by Kent Tamura.
1878
1879         [Refactoring] Node::nextRenderer() and previousRenderer() should be part of NodeRenderingContext
1880         https://bugs.webkit.org/show_bug.cgi?id=61912
1881
1882         Inlined Node::nextRenderer() and previousRenderer() into NodeRenderingContext and
1883         removed original definitions.
1884
1885         No test, no behavioral change.
1886         
1887         * dom/Node.cpp:
1888         * dom/Node.h:
1889         * dom/NodeRenderingContext.cpp:
1890         (WebCore::NodeRenderingContext::nextRenderer):
1891         (WebCore::NodeRenderingContext::previousRenderer):
1892
1893 2011-06-02  Piroska András  <Piroska.Andras@stud.u-szeged.hu>
1894
1895         Rubber-stamped by Gabor Loki.
1896
1897         Trivial buildfix for the ParallelJobs part of FEConvolveMatrix.
1898
1899         * platform/graphics/filters/FEConvolveMatrix.cpp:
1900         (WebCore::FEConvolveMatrix::apply): Rename variable i to job
1901
1902 2011-06-02  Yuta Kitamura  <yutak@chromium.org>
1903
1904         Reviewed by Kent Tamura.
1905
1906         WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has failed
1907         https://bugs.webkit.org/show_bug.cgi?id=61841
1908
1909         There is no change in behavior except that capitalization of a few error messages
1910         has been changed. No new tests are added.
1911
1912         * websockets/WebSocketChannel.cpp:
1913         (WebCore::WebSocketChannel::processBuffer):
1914         Pass m_handshake.failureReason() to fail() if the handshake has failed.
1915         * websockets/WebSocketHandshake.cpp:
1916         Replace occurrences of m_handle->addMessage() with assignments to m_failureReason.
1917         Change capitalization of a few messages so that all messages start with a capital letter.
1918         (WebCore::WebSocketHandshake::readServerHandshake):
1919         (WebCore::WebSocketHandshake::failureReason):
1920         (WebCore::WebSocketHandshake::readStatusLine):
1921         (WebCore::WebSocketHandshake::readHTTPHeaders):
1922         (WebCore::WebSocketHandshake::checkResponseHeaders):
1923         * websockets/WebSocketHandshake.h:
1924         Add failureReason(), which returns a string that describes why WebSocket handshake
1925         has failed.
1926
1927 2011-06-01  Dan Bernstein  <mitz@apple.com>
1928
1929         Reviewed by Anders Carlsson.
1930
1931         Incorrect UA style when printing a simple document
1932         https://bugs.webkit.org/show_bug.cgi?id=61900
1933
1934         This is not testable in run-webkit-tests because unless the test is the first to run in an instance
1935         of DumpRenderTree, it is not guaranteed that the full default style sheet has not been initialized.
1936
1937         * css/CSSStyleSelector.cpp:
1938         (WebCore::loadFullDefaultStyle): Replace the simple default print style, which is now equal to the
1939         simple default style, with a new RuleSet before adding the style rules from the full default sheet.
1940         (WebCore::loadSimpleDefaultStyle): Set defaultPrintStyle to point to the default style. They are
1941         equal in the simple case.
1942
1943 2011-06-01  Kent Tamura  <tkent@chromium.org>
1944
1945         Reviewed by Dimitri Glazkov.
1946
1947         Remove outer-spin-button
1948         https://bugs.webkit.org/show_bug.cgi?id=61845
1949
1950         Remove outer-spin-button, and render steppers as inner-spin-button.
1951         Outer-spin-button have never worked well with padding and border of
1952         <input>, and the layout code is very tricky and very hard to maintain it.
1953
1954         * css/CSSPrimitiveValueMappings.h:
1955         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1956         * css/CSSValueKeywords.in:
1957         * css/html.css:
1958         * html/HTMLInputElement.cpp:
1959         (WebCore::HTMLInputElement::innerSpinButtonElement):
1960         * html/HTMLInputElement.h:
1961         * html/InputType.h:
1962         * html/TextFieldInputType.cpp:
1963         (WebCore::TextFieldInputType::TextFieldInputType):
1964         (WebCore::TextFieldInputType::createShadowSubtree):
1965         (WebCore::TextFieldInputType::destroyShadowSubtree):
1966         * html/TextFieldInputType.h:
1967         * html/shadow/TextControlInnerElements.cpp:
1968         (WebCore::SpinButtonElement::SpinButtonElement):
1969         (WebCore::SpinButtonElement::create):
1970         (WebCore::SpinButtonElement::shadowPseudoId):
1971         * html/shadow/TextControlInnerElements.h:
1972         * platform/ThemeTypes.h:
1973         * platform/chromium/ThemeChromiumMac.mm:
1974         (WebCore::paintStepper):
1975          Center the stepper drawing area because the specified area can be
1976          larger than the NSStepper sizes.
1977         (WebCore::ThemeChromiumMac::controlSize):
1978         (WebCore::ThemeChromiumMac::minimumControlSize):
1979         (WebCore::ThemeChromiumMac::inflateControlPaintRect):
1980         (WebCore::ThemeChromiumMac::paint):
1981         * platform/mac/ThemeMac.mm:
1982         (WebCore::paintStepper):
1983          Center the stepper drawing area because the specified area can be
1984          larger than the NSStepper sizes.
1985         (WebCore::ThemeMac::controlSize):
1986         (WebCore::ThemeMac::minimumControlSize):
1987         (WebCore::ThemeMac::inflateControlPaintRect):
1988         (WebCore::ThemeMac::paint):
1989         * rendering/RenderBox.cpp:
1990         (WebCore::RenderBox::paintBoxDecorations):
1991         * rendering/RenderBox.h:
1992         * rendering/RenderTextControlSingleLine.cpp:
1993         (WebCore::RenderTextControlSingleLine::layout):
1994         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1995         (WebCore::RenderTextControlSingleLine::textBlockWidth):
1996         * rendering/RenderTextControlSingleLine.h:
1997         * rendering/RenderTheme.cpp:
1998         (WebCore::RenderTheme::adjustStyle):
1999         (WebCore::RenderTheme::paint):
2000         (WebCore::RenderTheme::adjustInnerSpinButtonStyle):
2001         * rendering/RenderTheme.h:
2002         * rendering/RenderThemeMac.mm:
2003         (WebCore::RenderThemeMac::adjustRepaintRect):
2004
2005 2011-06-01  Emil A Eklund  <eae@chromium.org>
2006
2007         Reviewed by Eric Seidel.
2008
2009         Switch RenderLayer::convertToLayerCoords to use IntPoint
2010         https://bugs.webkit.org/show_bug.cgi?id=61818
2011
2012         Covered by existing tests.
2013
2014         * platform/graphics/FloatPoint.h:
2015         (WebCore::flooredIntSize):
2016         * rendering/RenderLayer.cpp:
2017         (WebCore::RenderLayer::updateLayerPositions):
2018         (WebCore::expandClipRectForDescendantsAndReflection):
2019         (WebCore::transparencyClipBox):
2020         (WebCore::RenderLayer::convertToLayerCoords):
2021         (WebCore::RenderLayer::paintLayer):
2022         (WebCore::RenderLayer::paintChildLayerIntoColumns):
2023         (WebCore::RenderLayer::createLocalTransformState):
2024         (WebCore::RenderLayer::hitTestChildLayerColumns):
2025         (WebCore::RenderLayer::calculateClipRects):
2026         (WebCore::RenderLayer::calculateRects):
2027         (WebCore::RenderLayer::boundingBox):
2028         (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
2029         * rendering/RenderLayer.h:
2030         * rendering/RenderLayerBacking.cpp:
2031         (WebCore::RenderLayerBacking::updateCompositedBounds):
2032         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2033         * rendering/RenderLayerCompositor.cpp:
2034         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
2035         (WebCore::RenderLayerCompositor::layerWillBeRemoved):
2036         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
2037
2038 2011-06-01  Roland Steiner  <rolandsteiner@chromium.org>
2039
2040         Reviewed by Kent Tamura.
2041
2042         Remove superfluous renderer() test
2043         https://bugs.webkit.org/show_bug.cgi?id=61907
2044
2045         No new tests. (trivial)
2046
2047         * dom/Document.cpp:
2048         (WebCore::Document::recalcStyle):
2049
2050 2011-06-01  Levi Weintraub  <leviw@chromium.org>
2051
2052         Reviewed by Hajime Morita.
2053
2054         Add IntPoint + IntPoint operator
2055         https://bugs.webkit.org/show_bug.cgi?id=61876
2056
2057         Adding an operator+ convenience method to IntPoint that sums two points
2058         and returns the result as an IntPoint. Changing doImageDrag to use it
2059         as a proof of concept.
2060
2061         No new tests since there is no change in behavior.
2062
2063         * page/DragController.cpp:
2064         (WebCore::DragController::doImageDrag):
2065         * platform/graphics/IntPoint.h:
2066         (WebCore::operator+):
2067
2068 2011-06-01  Jaehun Lim  <ljaehun.lim@samsung.com>
2069
2070         Reviewed by Eric Seidel.
2071
2072         [EFL] Add adjustMenuListButtonStyle and paintMenuListButton functions
2073         https://bugs.webkit.org/show_bug.cgi?id=61836
2074
2075         Add functions for rendering drop-down list when style attributes are applied.
2076
2077         * platform/efl/RenderThemeEfl.cpp:
2078         (WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
2079         (WebCore::RenderThemeEfl::paintMenuListButton):
2080         * platform/efl/RenderThemeEfl.h:
2081
2082 2011-06-01  Yuta Kitamura  <yutak@chromium.org>
2083
2084         Reviewed by Kent Tamura.
2085
2086         WebSocket: WebSocketChannel::fail() should close the connection immediately
2087         https://bugs.webkit.org/show_bug.cgi?id=61851
2088
2089         The effect of this change is almost unobservable. The difference between m_handle->close() and
2090         m_handle->disconnect() is that the former does not close the connection if the handle has
2091         unsent data while the latter immediately closes the connection regardless of unsent data.
2092         Usually a socket stream handle does not have unsent data, and even if it has any, it is hard
2093         for user scripts to observe the difference between close() and disconnect() (it should take some time
2094         for onclose() to be called if there are any unsent data, but there ought to be no other difference
2095         in user scripts' perspective).
2096
2097         No new tests are added, because writing a test for this issue is not feasible due to the above reason.
2098
2099         * websockets/WebSocketChannel.cpp:
2100         (WebCore::WebSocketChannel::fail): Use m_handle->disconnect() instead of m_handle->close().
2101
2102 2011-06-01  Abhishek Arya  <inferno@chromium.org>
2103
2104         Unreviewed.
2105
2106         Coding style nit. Move ec=0 initialization, change
2107         recommended by Alexey in bug.
2108         https://bugs.webkit.org/show_bug.cgi?id=60831
2109
2110         * dom/Document.cpp:
2111         (WebCore::Document::setBody):
2112
2113 2011-06-01  Hayato Ito  <hayato@chromium.org>
2114
2115         Reviewed by Kent Tamura.
2116
2117         Move {Next,Previous}FocusableNode functions from Document to FocusController.
2118         https://bugs.webkit.org/show_bug.cgi?id=61839
2119
2120         There are some member functions in Document which use 'this'
2121         pointer, but we should use TreeScope instead of Document in some
2122         places to handle focus issues nicely. We have to move these
2123         functions out of Document class so that we can give the TreeScope
2124         as a parameter.
2125
2126         No new tests since no functionality was changed.
2127
2128         * dom/Document.cpp:
2129         * dom/Document.h:
2130         * page/FocusController.cpp:
2131         (WebCore::FocusController::deepFocusableNode):
2132         (WebCore::FocusController::advanceFocusInDocumentOrder):
2133         (WebCore::nextNodeWithExactTabIndex):
2134         (WebCore::previousNodeWithExactTabIndex):
2135         (WebCore::nextNodeWithGreaterTabIndex):
2136         (WebCore::previousNodeWithLowerTabIndex):
2137         (WebCore::FocusController::nextFocusableNode):
2138         (WebCore::FocusController::previousFocusableNode):
2139         * page/FocusController.h:
2140
2141 2011-06-01  Adrienne Walker  <enne@google.com>
2142
2143         Reviewed by James Robinson.
2144
2145         [chromium] Fix syncing of removed mask and replica layers
2146         https://bugs.webkit.org/show_bug.cgi?id=61895
2147
2148         * platform/graphics/chromium/TreeSynchronizer.cpp:
2149         (WebCore::TreeSynchronizer::synchronizeTreeRecursive):
2150
2151 2011-06-01  Julien Chaffraix  <jchaffraix@codeaurora.org>
2152
2153         Reviewed by Simon Fraser.
2154
2155         CSSStyleSheet#insertRule doesn't work well with imported stylesheets
2156         https://bugs.webkit.org/show_bug.cgi?id=56981
2157
2158         Test: fast/css/import-and-insert-rule-no-update.html
2159
2160         The bug arises from the fact that <link> element did not know about a programmatically
2161         loading sheet (using insertRule and @import) and would thus never call removePendingSheet.
2162         This is needed to make sure our style selector contains an up-to-date list of stylesheets.
2163
2164         The gist of the patch adds a way for style sheet owner element to know if we are
2165         programmatically loading a style sheet. This is needed as <link> keeps the information
2166         about that last loaded stylesheet.
2167
2168         * css/CSSImportRule.cpp:
2169         (WebCore::CSSImportRule::insertedIntoParent): Call startLoadingDynamicSheet
2170         on our parent style sheet instead of directly adding a pending style sheet.
2171
2172         * css/CSSStyleSheet.cpp:
2173         (WebCore::CSSStyleSheet::startLoadingDynamicSheet): Call startLoadingDynamicSheet
2174         on our owner element if we have one.
2175
2176         * css/CSSStyleSheet.h:
2177         * dom/Node.h:
2178         (WebCore::Node::startLoadingDynamicSheet): Added common implementation of
2179         startLoadingDynamicSheet, which should never be called.
2180
2181         * dom/StyleElement.cpp:
2182         (WebCore::StyleElement::startLoadingDynamicSheet):
2183         * dom/StyleElement.h:
2184         Common implementation of startLoadingDynamicSheet for style elements.
2185
2186         * html/HTMLLinkElement.cpp:
2187         (WebCore::HTMLLinkElement::startLoadingDynamicSheet):
2188         * html/HTMLLinkElement.h:
2189         Use the HTMLLinkElement plumbing to make sure we call addRemovePendingSheet.
2190
2191         * html/HTMLStyleElement.h:
2192         (WebCore::HTMLStyleElement::startLoadingDynamicSheet):
2193         * svg/SVGStyleElement.h:
2194         (WebCore::SVGStyleElement::startLoadingDynamicSheet):
2195         Forward the call to StyleElement.
2196
2197 2011-06-01  Levi Weintraub  <leviw@chromium.org>
2198
2199         Reviewed by Eric Seidel.
2200
2201         Switch paintCustomHighlight to use IntPoint
2202         https://bugs.webkit.org/show_bug.cgi?id=61562
2203
2204         Switching paintCustomHighlight to use an IntPoint for
2205         its paint offset instead of a pair of ints.
2206
2207         No new tests since this is refactoring.
2208
2209         * rendering/InlineTextBox.cpp:
2210         (WebCore::InlineTextBox::paint):
2211         (WebCore::InlineTextBox::paintCustomHighlight):
2212         * rendering/InlineTextBox.h:
2213         * rendering/RenderBox.cpp:
2214         (WebCore::RenderBox::paintCustomHighlight):
2215         * rendering/RenderBox.h:
2216         * rendering/RenderImage.cpp:
2217         (WebCore::RenderImage::paintReplaced):
2218         * rendering/RenderListMarker.cpp:
2219         (WebCore::RenderListMarker::paint):
2220         * rendering/RenderWidget.cpp:
2221         (WebCore::RenderWidget::paint):
2222         * rendering/RootInlineBox.cpp:
2223         (WebCore::RootInlineBox::paintCustomHighlight):
2224         (WebCore::RootInlineBox::paint):
2225         * rendering/RootInlineBox.h:
2226
2227 2011-06-01  Emil A Eklund  <eae@chromium.org>
2228
2229         Reviewed by Eric Seidel.
2230
2231         Switch MouseRelatedEvent to use IntPoint
2232         https://bugs.webkit.org/show_bug.cgi?id=61574
2233
2234         Covered by existing tests.
2235
2236         * dom/MouseEvent.cpp:
2237         (WebCore::MouseEvent::MouseEvent):
2238         (WebCore::MouseEvent::initMouseEvent):
2239         (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
2240         * dom/MouseRelatedEvent.cpp:
2241         (WebCore::MouseRelatedEvent::MouseRelatedEvent):
2242         (WebCore::contentsScrollOffset):
2243         (WebCore::MouseRelatedEvent::initCoordinates):
2244         (WebCore::MouseRelatedEvent::computeRelativePosition):
2245         (WebCore::MouseRelatedEvent::layerX):
2246         (WebCore::MouseRelatedEvent::layerY):
2247         (WebCore::MouseRelatedEvent::offsetX):
2248         (WebCore::MouseRelatedEvent::offsetY):
2249         (WebCore::MouseRelatedEvent::pageX):
2250         (WebCore::MouseRelatedEvent::pageY):
2251         (WebCore::MouseRelatedEvent::pageLocation):
2252         (WebCore::MouseRelatedEvent::x):
2253         (WebCore::MouseRelatedEvent::y):
2254         * dom/MouseRelatedEvent.h:
2255         (WebCore::MouseRelatedEvent::screenX):
2256         (WebCore::MouseRelatedEvent::screenY):
2257         (WebCore::MouseRelatedEvent::screenLocation):
2258         (WebCore::MouseRelatedEvent::clientX):
2259         (WebCore::MouseRelatedEvent::clientY):
2260         (WebCore::MouseRelatedEvent::clientLocation):
2261         (WebCore::MouseRelatedEvent::absoluteLocation):
2262         * dom/TouchEvent.cpp:
2263         (WebCore::TouchEvent::TouchEvent):
2264         (WebCore::TouchEvent::initTouchEvent):
2265         * dom/WheelEvent.cpp:
2266         (WebCore::WheelEvent::WheelEvent):
2267         (WebCore::WheelEvent::initWheelEvent):
2268         (WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
2269         * dom/WheelEvent.h:
2270         (WebCore::WheelEvent::create):
2271         (WebCore::WheelEvent::wheelDelta):
2272         (WebCore::WheelEvent::wheelDeltaX):
2273         (WebCore::WheelEvent::wheelDeltaY):
2274         (WebCore::WheelEvent::rawDeltaX):
2275         (WebCore::WheelEvent::rawDeltaY):
2276         (WebCore::WheelEvent::isHorizontal):
2277         * platform/graphics/IntPoint.h:
2278         (WebCore::IntPoint::scale):
2279
2280 2011-06-01  Levi Weintraub  <leviw@chromium.org>
2281
2282         Reviewed by Eric Seidel.
2283
2284         Switch paintOverflowControls to use IntPoint
2285         https://bugs.webkit.org/show_bug.cgi?id=61884
2286
2287         Switching paintOverflowControls to use an IntPoint instead of a pair of ints.
2288
2289         No new tests since this is simple refactoring.
2290
2291         * rendering/RenderBlock.cpp:
2292         (WebCore::RenderBlock::paint):
2293         * rendering/RenderLayer.cpp:
2294         (WebCore::RenderLayer::paintOverflowControls):
2295         (WebCore::RenderLayer::paintLayer):
2296         * rendering/RenderLayer.h:
2297         * rendering/RenderLayerBacking.cpp:
2298         (WebCore::RenderLayerBacking::paintIntoLayer):
2299
2300 2011-06-01  Abhishek Arya  <inferno@chromium.org>
2301
2302         Reviewed by Alexey Proskuryakov.
2303
2304         Fix setting of document.body
2305         https://bugs.webkit.org/show_bug.cgi?id=60831
2306
2307         1. Only allowing setting to an element if it has a body tag.
2308         2. If element is from another document, import it.
2309
2310         Test: fast/dom/document-set-body.html
2311
2312         * dom/Document.cpp:
2313         (WebCore::Document::setBody):
2314
2315 2011-06-01  Chris Fleizach  <cfleizach@apple.com>
2316
2317         Reviewed by Darin Adler.
2318
2319         Safari always crashes on http://bbc.co.uk when VoiceOver enabled
2320         https://bugs.webkit.org/show_bug.cgi?id=61886
2321
2322         This crash can happen on webpages that remove an element from the DOM when the element receives focus.
2323         When AppKit goes to post a notification to inform VoiceOver the focus has changed, it asks for the AXFocusedUIElement.
2324         However by posting that notification, a render tree update is performed. This causes the element to disappear, but
2325         AppKit still has a handle to it and continues to try to reference it. When the autorelease pool pops, the reference goes bad.
2326
2327         To fix, the root element, the AccessibilityScrollView, needs to implement updateBackingStore(), otherwise this method 
2328         will not be called in time.
2329
2330         No test could be created because to cause it depends on an internal AppKit mechanism
2331         that is only triggered remotely through the accessibility runtime.
2332
2333         * accessibility/AccessibilityObject.cpp:
2334         (WebCore::AccessibilityObject::updateBackingStore):
2335         * accessibility/AccessibilityObject.h:
2336         * accessibility/AccessibilityRenderObject.cpp:
2337         * accessibility/AccessibilityRenderObject.h:
2338
2339 2011-06-01  David Carson  <dacarson@apple.com>
2340
2341         Reviewed by Antti Koivisto.
2342
2343         https://bugs.webkit.org/show_bug.cgi?id=61831
2344         If width and height of an iframe is fixed and should not be visible, then
2345         it shouldn't be flattened.
2346
2347         Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html
2348
2349         * rendering/RenderIFrame.cpp:
2350         (WebCore::RenderIFrame::flattenFrame): add a check for a zero width or height
2351
2352 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
2353
2354         Reviewed by Tony Chang.
2355
2356         [chromium] Use correct file name for dragging out images.
2357         https://bugs.webkit.org/show_bug.cgi?id=24887
2358
2359         We try to guess an appropriate filename when dragging out images. In order, we try to use:
2360         - The filename suggested in the HTTP header.
2361         - The last path component of the source URL.
2362         - The alt text.
2363         This matches the behavior of the other WebKit ports.
2364
2365         Test: fast/events/drag-image-filename.html
2366
2367         * platform/chromium/ClipboardChromium.cpp:
2368         (WebCore::writeImageToDataObject):
2369         * platform/chromium/ClipboardChromiumMac.cpp:
2370         (WebCore::isInvalidFileCharacter):
2371         (WebCore::ClipboardChromium::validateFileName):
2372
2373 2011-06-01  Levi Weintraub  <leviw@chromium.org>
2374
2375         Reviewed by Eric Seidel.
2376
2377         Text is scaled in a stair-step pattern
2378         https://bugs.webkit.org/show_bug.cgi?id=60317
2379
2380         Stop scaling the specified font to the actual on-screen value when font-rendering: 
2381         geometricPrecision is specified, but instead scale the graphics context. This allows
2382         us to scale text up and down smoothly.
2383
2384         Test: svg/text/scaling-font-with-geometric-precision.html
2385
2386         * rendering/svg/RenderSVGInlineText.cpp:
2387         (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
2388
2389 2011-06-01  Levi Weintraub  <leviw@chromium.org>
2390
2391         Reviewed by Eric Seidel.
2392
2393         Switch paintResizer to use IntPoint
2394         https://bugs.webkit.org/show_bug.cgi?id=61883
2395
2396         Switch paintResizer to take an IntPoint instead of a pair of ints.
2397
2398         No new tests as this is simple refactoring.
2399
2400         * rendering/RenderLayer.cpp:
2401         (WebCore::RenderLayer::paintOverflowControls):
2402         (WebCore::RenderLayer::paintResizer):
2403         * rendering/RenderLayer.h:
2404         * rendering/RenderLayerBacking.cpp:
2405         (WebCore::RenderLayerBacking::paintContents):
2406
2407 2011-06-01  Jer Noble  <jer.noble@apple.com>
2408
2409         Reviewed by Darin Adler.
2410
2411         Page layout messed up after exiting full screen at Apple trailers page
2412         https://bugs.webkit.org/show_bug.cgi?id=61755
2413         <rdar://problem/9525277>
2414
2415         Test: fullscreen/full-screen-zIndex-after.html
2416
2417         Fix the incomplete implementation of r87660. Make parameters to
2418         setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
2419         in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
2420         inconsistent..
2421
2422         * dom/Document.cpp:
2423         (WebCore::Document::webkitWillExitFullScreenForElement):
2424
2425 2011-06-01  Levi Weintraub  <leviw@chromium.org>
2426
2427         Reviewed by Eric Seidel.
2428
2429         Switch paintScrollCorner to use IntPoint
2430         https://bugs.webkit.org/show_bug.cgi?id=61874
2431
2432         Changing paintScrollCorner to take an IntPoint representing the paint
2433         offset instead of a pair of ints.
2434
2435         No new tests as this is simple refactoring.
2436
2437         * rendering/RenderLayer.cpp:
2438         (WebCore::RenderLayer::paintOverflowControls):
2439         (WebCore::RenderLayer::paintScrollCorner):
2440         * rendering/RenderLayer.h:
2441         * rendering/RenderLayerBacking.cpp:
2442         (WebCore::RenderLayerBacking::paintContents):
2443
2444 2011-06-01  Kenneth Russell  <kbr@google.com>
2445
2446         Reviewed by Nate Chapin.
2447
2448         [V8] Optimize fetches of indexed properties in custom bindings
2449         https://bugs.webkit.org/show_bug.cgi?id=61821
2450
2451         Avoid allocating garbage in affected custom bindings. This speeds
2452         up one test case by at least a factor of two. No new tests;
2453         covered by existing layout tests (typed array and otherwise).
2454
2455         * bindings/v8/custom/V8ArrayBufferViewCustom.h:
2456         (WebCore::constructWebGLArray):
2457         (WebCore::setWebGLArrayHelper):
2458         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
2459         (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
2460         * bindings/v8/custom/V8MessagePortCustom.cpp:
2461         (WebCore::getMessagePortArray):
2462         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2463         (WebCore::jsArrayToFloatArray):
2464         (WebCore::jsArrayToIntArray):
2465
2466 2011-06-01  Andras Becsi  <abecsi@webkit.org>
2467
2468         Reviewed by Csaba Osztrogonác.
2469
2470         [Qt] Fix the Phonon build when logging is disabled
2471         https://bugs.webkit.org/show_bug.cgi?id=61869
2472
2473         No new tests needed.
2474
2475         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add missing guards.
2476         (WebCore::MediaPlayerPrivatePhonon::networkState):
2477         (WebCore::MediaPlayerPrivatePhonon::readyState):
2478         (WebCore::MediaPlayerPrivatePhonon::updateStates):
2479         (WebCore::MediaPlayerPrivatePhonon::stateChanged):
2480
2481 2011-06-01  Abhishek Arya  <inferno@chromium.org>
2482
2483         Reviewed by Antti Koivisto.
2484
2485         Do not use the pushed style selector if it is not equal to the
2486         parent document's style selector. It usually means that it is
2487         in a bad state, e.g. already cleared.
2488         https://bugs.webkit.org/show_bug.cgi?id=61737
2489
2490         * dom/Element.cpp:
2491         (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
2492
2493 2011-06-01  Levi Weintraub  <leviw@chromium.org>
2494
2495         Reviewed by Eric Seidel.
2496
2497         Switch RenderLineBoxList intersection functions to use IntPoint
2498         https://bugs.webkit.org/show_bug.cgi?id=61794
2499
2500         Switching rangeIntersectsRect, anyLineIntersectsRect, and lineIntersectsDirtyRect
2501         to take IntPoint instead of a tx/ty to represent the offset to be applied match
2502         the rect and lines' coordinates.
2503
2504         No new tests since this is merely refactoring.
2505
2506         * rendering/RenderLineBoxList.cpp:
2507         (WebCore::RenderLineBoxList::rangeIntersectsRect):
2508         (WebCore::RenderLineBoxList::anyLineIntersectsRect):
2509         (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
2510         (WebCore::RenderLineBoxList::paint):
2511         (WebCore::RenderLineBoxList::hitTest):
2512         * rendering/RenderLineBoxList.h:
2513
2514 2011-05-19  Adrienne Walker  <enne@google.com>
2515
2516         Reviewed by James Robinson.
2517
2518         [chromium] Don't split long, narrow layers into multiple tiles.
2519         https://bugs.webkit.org/show_bug.cgi?id=60821
2520
2521         This changes the heuristic for when we tile layers to be less bad
2522         about wasting texture space.  Long, narrow layers that are tiled with
2523         a large tile size waste texture space.  Now layers are only tiled if
2524         they are above 512px in one dimension and extend into a second tile in
2525         the other.  If they are not tiled, their layer texture will exactly
2526         fit their layer bounds.  In particular, this will help scrollbars.
2527
2528         * platform/graphics/chromium/ContentLayerChromium.cpp:
2529         (WebCore::ContentLayerChromium::updateLayerSize):
2530         * platform/graphics/chromium/LayerRendererChromium.h:
2531         (WebCore::LayerRendererChromium::maxTextureSize):
2532
2533 2011-06-01  Cary Clark  <caryclark@google.com>
2534
2535         Reviewed by Eric Seidel.
2536
2537         Ready Chromium port for Skia on Mac
2538         https://bugs.webkit.org/show_bug.cgi?id=61800
2539
2540         Skia on Mac is not enabled. The executing
2541         code is unchanged, so there are no new tests.
2542
2543         * platform/chromium/DragImageRef.h:
2544         Use Skia for DragImageRef instead of CG.
2545
2546         * platform/chromium/ScrollbarThemeChromiumMac.mm:
2547         (WebCore::ScrollbarThemeChromiumMac::paint):
2548         Get the total matrix from Skia for the scrollbar.
2549         Convert the SkCanvas into a CGContext to draw.
2550
2551         * platform/chromium/ThemeChromiumMac.mm:
2552         (WebCore::paintStepper):
2553         Ditto.
2554
2555 2011-06-01  Yury Semikhatsky  <yurys@chromium.org>
2556
2557         Reviewed by Pavel Feldman.
2558
2559         Web Inspector: allow opening inspector for existing workers
2560         https://bugs.webkit.org/show_bug.cgi?id=61853
2561
2562         Added sidebar pane with a list of all workers. Each worker has a check box
2563         that allows opening inspector for the worker.
2564
2565         * inspector/Inspector.json:
2566         * inspector/InspectorInstrumentation.cpp:
2567         (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
2568         * inspector/InspectorInstrumentation.h:
2569         (WebCore::InspectorInstrumentation::didStartWorkerContext):
2570         * inspector/InspectorWorkerAgent.cpp:
2571         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
2572         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
2573         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerContext):
2574         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerContext):
2575         (WebCore::InspectorWorkerAgent::clearFrontend):
2576         (WebCore::InspectorWorkerAgent::connectToWorker):
2577         (WebCore::InspectorWorkerAgent::disconnectFromWorker):
2578         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
2579         * inspector/InspectorWorkerAgent.h:
2580         * inspector/front-end/ScriptsPanel.js:
2581         (WebInspector.ScriptsPanel):
2582         * inspector/front-end/Settings.js:
2583         * inspector/front-end/WorkerManager.js:
2584         (WebInspector.WorkerManager):
2585         (WebInspector.WorkerManager.prototype._workerCreated):
2586         (WebInspector.WorkerManager.prototype._sendMessageToWorkerInspector):
2587         (WebInspector.WorkerManager.prototype.openWorkerInspector):
2588         (WebInspector.WorkerManager.prototype.closeWorkerInspector):
2589         (WebInspector.WorkerManager.prototype._workerInspectorClosing):
2590         (WebInspector.WorkerMessageForwarder):
2591         (WebInspector.WorkerMessageForwarder.prototype.workerCreated):
2592         (WebInspector.WorkerMessageForwarder.prototype.dispatchMessageFromWorker):
2593         * inspector/front-end/WorkersSidebarPane.js:
2594         (WebInspector.WorkersSidebarPane):
2595         (WebInspector.WorkersSidebarPane.prototype.addWorker):
2596         (WebInspector.WorkerListSidebarPane):
2597         (WebInspector.WorkerListSidebarPane.prototype._workerAdded):
2598         (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
2599         (WebInspector.WorkerListSidebarPane.prototype._workerInspectorClosed):
2600         (WebInspector.WorkerListSidebarPane.prototype._addWorker):
2601         (WebInspector.WorkerListSidebarPane.prototype._createCheckbox):
2602         (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
2603         * workers/Worker.cpp:
2604         (WebCore::Worker::notifyFinished):
2605
2606 2011-06-01  Shishir Agrawal  <shishir@chromium.org>
2607
2608         Reviewed by Tony Gentilcore.
2609
2610         Renaming the Page Visibility attributes as per the modified spec draft.
2611         https://bugs.webkit.org/show_bug.cgi?id=61825
2612
2613         Spec draft:
2614         http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html
2615
2616         - Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
2617         - The attribute webkitIsVisible needs to change to webkitHidden
2618
2619         * dom/Document.cpp:
2620         (WebCore::Document::webkitHidden):
2621         (WebCore::Document::dispatchVisibilityStateChangeEvent):
2622         * dom/Document.h:
2623         * dom/Document.idl:
2624         * dom/EventNames.h:
2625
2626 2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>
2627
2628         Reviewed by Rob Buis.
2629
2630         Remove duplicated code in various computeReplacedLogical*() functions
2631         https://bugs.webkit.org/show_bug.cgi?id=61860
2632
2633         Centralize this calculation in RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth:
2634         int minLogicalWidth = computeReplacedLogicalWidthUsing(style()->logicalMinWidth());
2635         int maxLogicalWidth = !includeMaxWidth || style()->logicalMaxWidth().isUndefined() ? logicalWidth : computeReplacedLogicalWidthUsing(style()->logicalMaxWidth());
2636         return max(minLogicalWidth, min(logicalWidth, maxLogicalWidth));
2637
2638         Centralize this calculation in RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight:
2639         int minLogicalHeight = computeReplacedLogicalHeightUsing(style()->logicalMinHeight());
2640         int maxLogicalHeight = style()->logicalMaxHeight().isUndefined() ? logicalHeight : computeReplacedLogicalHeightUsing(style()->logicalMaxHeight());
2641         return max(minLogicalHeight, min(logicalHeight, maxLogicalHeight));
2642
2643         Use the new helper methods where possible, deduplicating lots of code.
2644
2645         * rendering/RenderBox.cpp:
2646         (WebCore::RenderBox::computeReplacedLogicalWidth):
2647         (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
2648         (WebCore::RenderBox::computeReplacedLogicalHeight):
2649         (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
2650         * rendering/RenderBox.h:
2651         * rendering/RenderImage.cpp:
2652         (WebCore::RenderImage::computeReplacedLogicalWidth):
2653         (WebCore::RenderImage::computeReplacedLogicalHeight):
2654         * rendering/RenderPart.cpp:
2655         (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
2656         (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
2657         (WebCore::RenderPart::computeReplacedLogicalWidth):
2658         (WebCore::RenderPart::computeReplacedLogicalHeight):
2659         * rendering/RenderPart.h:
2660         * rendering/RenderReplaced.cpp:
2661         (WebCore::RenderReplaced::computeReplacedLogicalWidth):
2662         (WebCore::RenderReplaced::computeReplacedLogicalHeight):
2663         * rendering/svg/RenderSVGRoot.cpp:
2664         (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
2665         (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
2666
2667 2011-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2668
2669         Unreviewed, rolling out r87788.
2670         http://trac.webkit.org/changeset/87788
2671         https://bugs.webkit.org/show_bug.cgi?id=61856
2672
2673         breaks windows chromium canary (Requested by jknotten on
2674         #webkit).
2675
2676         * loader/archive/mhtml/MHTMLArchive.cpp:
2677         * loader/archive/mhtml/MHTMLArchive.h:
2678         * page/PageSerializer.cpp:
2679         (WebCore::PageSerializer::serializeFrame):
2680         (WebCore::PageSerializer::serializeCSSStyleSheet):
2681         * platform/SharedBuffer.cpp:
2682         * platform/SharedBuffer.h:
2683
2684 2011-06-01  Joseph Pecoraro  <joepeck@webkit.org>
2685
2686         Reviewed by Pavel Feldman.
2687
2688         Web Inspector: [JSC] JSLock ASSERTs Seen Under eventListenerHandlerBody
2689         https://bugs.webkit.org/show_bug.cgi?id=61835
2690
2691         Add a JSLock call before possible allocations in jsFunction and toString.
2692
2693         * bindings/js/ScriptEventListener.cpp:
2694         (WebCore::eventListenerHandlerBody):
2695
2696 2011-06-01  Jay Civelli  <jcivelli@chromium.org>
2697
2698         Reviewed by Adam Barth.
2699
2700         Adding MHTML generation support to MHTMLArchive.
2701         https://bugs.webkit.org/show_bug.cgi?id=7169
2702
2703         * loader/archive/mhtml/MHTMLArchive.cpp:
2704         (WebCore::generateRandomBoundary):
2705         (WebCore::replaceNonPrintableCharacters):
2706         (WebCore::MHTMLArchive::generateMHTMLData):
2707         * loader/archive/mhtml/MHTMLArchive.h:
2708         * page/PageSerializer.cpp:
2709         (WebCore::PageSerializer::serializeFrame):
2710         (WebCore::PageSerializer::serializeCSSStyleSheet):
2711         * platform/SharedBuffer.cpp:
2712         (WebCore::SharedBuffer::append):
2713         * platform/SharedBuffer.h:
2714
2715 2011-06-01  Dimitri Glazkov  <dglazkov@chromium.org>
2716
2717         Reviewed by Kent Tamura.
2718
2719         Remove ShadowElement and compact remaining used bits into RenderFileUploadControl.
2720         https://bugs.webkit.org/show_bug.cgi?id=61816
2721
2722         This is a near-mechanical move-and-rename of ShadowElement, which is now only
2723         used by input[type=file]. Next step -- switch it over to new shadow DOM.
2724
2725         Refactoring, no change in behavior.
2726
2727         * CMakeLists.txt: Removed ShadowElement.cpp and ShadowElement.h.
2728         * GNUmakefile.list.am: Ditto.
2729         * WebCore.gypi: Ditto.
2730         * WebCore.pro: Ditto.
2731         * WebCore/WebCore.vcproj/WebCore.vcproj: Ditto.
2732         * WebCore.xcodeproj/project.pbxproj: Ditto.
2733         * WebCore/rendering/RenderingAllInOne.cpp: Ditto.
2734         * rendering/RenderFileUploadControl.cpp:
2735         (WebCore::UploadButton::create): Moved from ShadowElement, renamed as UploadButton.
2736         (WebCore::UploadButton::detach): Ditto.
2737         (WebCore::UploadButton::UploadButton): Ditto.
2738         (WebCore::RenderFileUploadControl::updateFromElement): Changed to use UploadButton.
2739         * rendering/RenderMeter.cpp: Removed ShadowElement.h include, which is no longer used.
2740         * rendering/RenderProgress.cpp: Ditto.
2741         * rendering/ShadowElement.cpp: Removed.
2742         * rendering/ShadowElement.h: Removed.
2743
2744 2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>
2745
2746         Reviewed by Rob Buis.
2747
2748         SVG fails all 3 of Hixie's CSS intrinsic sizing tests
2749         https://bugs.webkit.org/show_bug.cgi?id=15473
2750
2751         Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
2752         and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
2753         SVGs width/height attributes into account when determining the intrinsic size of the <object>.
2754
2755         Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
2756         The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
2757         interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.
2758
2759         Tests: svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml
2760                svg/custom/object-sizing-height-50p-on-target-svg.xhtml
2761                svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml
2762                svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml
2763                svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml
2764                svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml
2765                svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml
2766                svg/custom/object-sizing-width-50p-on-target-svg.xhtml
2767                svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml
2768                svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml
2769                svg/hixie/intrinsic/001.html
2770                svg/hixie/intrinsic/002.html
2771                svg/hixie/intrinsic/003.html
2772
2773         * rendering/RenderPart.cpp:
2774         (WebCore::RenderPart::computeReplacedLogicalWidth):
2775         (WebCore::RenderPart::computeReplacedLogicalHeight):
2776         * rendering/svg/RenderSVGRoot.cpp:
2777         (WebCore::RenderSVGRoot::computeIntrinsicRatio):
2778         * rendering/svg/RenderSVGRoot.h:
2779
2780 2011-05-31  Tonis Tiigi  <tonistiigi@gmail.com>
2781
2782         Reviewed by Pavel Feldman.
2783
2784         Web Inspector: Timeline panel improvements for managing current selection
2785         https://bugs.webkit.org/show_bug.cgi?id=61468
2786
2787         Enables X-axis dragging of the selected area.
2788         Double click zoom-out.
2789         Fixes slightly wrong selection area position.
2790
2791         * inspector/front-end/TimelineOverviewPane.js:
2792         (WebInspector.TimelineOverviewPane):
2793         (WebInspector.TimelineOverviewPane.prototype._dragWindow):
2794         (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging):
2795         (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
2796         (WebInspector.TimelineOverviewPane.prototype._resizeWindowMaximum):
2797         (WebInspector.TimelineOverviewPane.prototype.scrollWindow):
2798         (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
2799         * inspector/front-end/TimelinePanel.js:
2800         (WebInspector.TimelinePanel):
2801
2802 2011-05-31  Keishi Hattori  <keishi@webkit.org>
2803
2804         Reviewed by Kent Tamura.
2805
2806         Fix to enable page scroll of select element
2807         https://bugs.webkit.org/show_bug.cgi?id=53628
2808
2809         Manual test: select-page-scroll.html
2810
2811         * manual-tests/select-page-scroll.html: Added.
2812         * rendering/RenderListBox.cpp:
2813         (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
2814
2815 2011-05-31  Yong Li  <yoli@rim.com>
2816
2817         Reviewed by Eric Seidel.
2818
2819         https://bugs.webkit.org/show_bug.cgi?id=54807
2820         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
2821         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
2822         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
2823         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
2824         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
2825         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
2826         rule we should have in order to make our code independent from compilers and compiler flags.
2827
2828         No new test added because this change is not known to fix any issue.
2829
2830         * css/CSSPrimitiveValue.h:
2831         * css/CSSProperty.h:
2832         * rendering/InlineBox.h:
2833         * rendering/RenderBlock.h:
2834
2835 2011-05-31  Hironori Bono  <hbono@chromium.org>
2836
2837         Reviewed by Eric Seidel.
2838
2839         Send an input event when we change the text direction.
2840         https://bugs.webkit.org/show_bug.cgi?id=50952
2841
2842         Both Safari and Chrome call Editor::setBaseWritingDirection() to change
2843         the text direction of an editable element with their UIs. This change
2844         calls dispatchInputEvent() to send an input event when the function
2845         actually changes the "dir" attribute so we can send an input event as
2846         written in the HTML5 spec.
2847
2848         Test: fast/html/set-text-direction.html
2849
2850         * editing/Editor.cpp:
2851         (WebCore::Editor::setBaseWritingDirection):
2852
2853 2011-05-31  Jer Noble  <jer.noble@apple.com>
2854
2855         Reviewed by Darin Adler.
2856
2857         Flash of black at the end of full screen transition at apple.com product videos
2858         https://bugs.webkit.org/show_bug.cgi?id=61756
2859
2860         Added two new entries to the WebCore exports list.
2861
2862         * WebCore.exp.in:
2863
2864 2011-05-31  Rafael Brandao  <rafael.lobo@openbossa.org>
2865
2866         Reviewed by Andreas Kling.
2867
2868         [Qt] tst_QWebFrame::render() failing
2869         https://bugs.webkit.org/show_bug.cgi?id=60893
2870
2871         Due a problem on QPicture (http://bugreports.qt.nokia.com/browse/QTBUG-19496),
2872         this test was calculating the final geometry incorrectly. As the order between
2873         a translate and a draw operation could be relevant for it, but not for the
2874         final rendered result, they were changed on ScrollbarThemeQt::paint.
2875
2876         * platform/qt/ScrollbarThemeQt.cpp:
2877         (WebCore::ScrollbarThemeQt::paint):
2878
2879 2011-05-27  Adrienne Walker  <enne@google.com>
2880
2881         Reviewed by James Robinson.
2882
2883         [chromium] Fix crash from empty reflections with masks
2884         https://bugs.webkit.org/show_bug.cgi?id=61654
2885
2886         Change the iteration for updateCompositorResources to match that being
2887         done in the paint and draw steps.  This mismatch of iteration style
2888         was causing layers with replica masks to correctly get skipped while
2889         painting but not get skipped during texture upload.
2890
2891         Test: compositing/reflections/empty-reflection-with-mask.html
2892
2893         * platform/graphics/chromium/LayerRendererChromium.cpp:
2894         (WebCore::LayerRendererChromium::updateLayers):
2895         (WebCore::LayerRendererChromium::updateCompositorResources):
2896         * platform/graphics/chromium/LayerRendererChromium.h:
2897
2898 2011-05-31  B.J. Wever  <skylined@chromium.org>
2899
2900         Reviewed by Adam Barth.
2901
2902         requestFileSystem and resolveLocalFileSystemURI are not checking if
2903         errorCallback is NULL before scheduling a callback on error.
2904         https://bugs.webkit.org/show_bug.cgi?id=49539
2905
2906         Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html
2907
2908         * fileapi/DOMFileSystem.cpp:
2909         (WebCore::DOMFileSystem::scheduleCallback): Only call callback if
2910           one is supplied.
2911
2912 2011-05-31  Brady Eidson  <beidson@apple.com>
2913
2914         Reviewed by Darin Adler.
2915
2916         Another swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494
2917         
2918         Re-land http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.
2919
2920         No new tests. No change in behavior.
2921
2922         Instead of storing the DocumentLoader at construction and never changing it,
2923         always calculate it based on the FrameLoader's current DocumentLoader:
2924         * dom/Document.cpp:
2925         (WebCore::Document::Document):
2926         (WebCore::Document::suggestedMIMEType):
2927         (WebCore::Document::lastModified):
2928         (WebCore::Document::initSecurityContext):
2929         (WebCore::Document::updateURLForPushOrReplaceState):
2930         (WebCore::Document::loader):
2931         * dom/Document.h:
2932
2933         Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
2934         * bindings/ScriptControllerBase.cpp:
2935         (WebCore::ScriptController::executeIfJavaScriptURL):
2936         * html/MediaDocument.cpp:
2937         (WebCore::MediaDocument::replaceMediaElementTimerFired):
2938         * html/PluginDocument.cpp:
2939         (WebCore::PluginDocumentParser::createDocumentStructure):
2940         * platform/mac/HTMLConverter.mm:
2941         (fileWrapperForElement):
2942
2943         * WebCore.exp.in:
2944
2945 2011-05-31  Levi Weintraub  <leviw@chromium.org>
2946
2947         Reviewed by Simon Fraser.
2948
2949         Change InlineBox::paint and its overloaded variants to use IntPoint
2950         https://bugs.webkit.org/show_bug.cgi?id=61804
2951
2952         Changing InlineBox::paint, its 7 overloaded variants, and RootInlineBox::paintEllipsisBox
2953         to use IntPoint for their paint offset instead of a pair of ints.
2954
2955         No new tests since this is just a refactoring.
2956
2957         * rendering/EllipsisBox.cpp:
2958         (WebCore::EllipsisBox::paint):
2959         * rendering/EllipsisBox.h:
2960         * rendering/InlineBox.cpp:
2961         (WebCore::InlineBox::paint):
2962         * rendering/InlineBox.h:
2963         * rendering/InlineFlowBox.cpp:
2964         (WebCore::InlineFlowBox::paint):
2965         * rendering/InlineFlowBox.h:
2966         * rendering/InlineTextBox.cpp:
2967         (WebCore::InlineTextBox::paint):
2968         * rendering/InlineTextBox.h:
2969         * rendering/RenderBlock.cpp:
2970         (WebCore::RenderBlock::paintEllipsisBoxes):
2971         * rendering/RenderBoxModelObject.cpp:
2972         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2973         * rendering/RenderLineBoxList.cpp:
2974         (WebCore::RenderLineBoxList::paint):
2975         * rendering/RootInlineBox.cpp:
2976         (WebCore::RootInlineBox::paintEllipsisBox):
2977         (WebCore::RootInlineBox::paint):
2978         * rendering/RootInlineBox.h:
2979         * rendering/svg/SVGInlineFlowBox.cpp:
2980         (WebCore::SVGInlineFlowBox::paint):
2981         * rendering/svg/SVGInlineFlowBox.h:
2982         * rendering/svg/SVGInlineTextBox.cpp:
2983         (WebCore::SVGInlineTextBox::paint):
2984         * rendering/svg/SVGInlineTextBox.h:
2985         * rendering/svg/SVGRootInlineBox.cpp:
2986         (WebCore::SVGRootInlineBox::paint):
2987         * rendering/svg/SVGRootInlineBox.h:
2988
2989 2011-05-31  James Robinson  <jamesr@chromium.org>
2990
2991         Reviewed by Kenneth Russell.
2992
2993         [chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
2994         https://bugs.webkit.org/show_bug.cgi?id=61593
2995
2996         Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
2997         This is extremely defensive and not strictly necessary, but not harmful either.
2998
2999         * platform/graphics/chromium/LayerChromium.h:
3000         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3001         (WebCore::CCLayerImpl::~CCLayerImpl):
3002
3003 2011-05-31  Stephen White  <senorblanco@chromium.org>
3004
3005         Unreviewed; build fix.
3006
3007         Silence some warnings on the Safari/Mac release build.
3008
3009         * platform/graphics/gpu/TilingData.h:
3010         (WebCore::TilingData::assertTile):
3011
3012 2011-05-31  Justin Novosad  <junov@chromium.org>
3013
3014         Reviewed by Stephen White.
3015
3016         [Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
3017         https://bugs.webkit.org/show_bug.cgi?id=61790
3018         Changing the build guards in these two files that are required
3019         by the accelerated compositing feature.
3020
3021         * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
3022         * platform/graphics/gpu/TilingData.cpp:
3023
3024 2011-05-31  Justin Novosad  <junov@chromium.org>
3025
3026         Reviewed by Stephen White.
3027
3028         [Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
3029         https://bugs.webkit.org/show_bug.cgi?id=61790
3030         Changing the build guards in these two files that are required
3031         by the accelerated compositing feature.
3032
3033         * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
3034         * platform/graphics/gpu/TilingData.cpp:
3035
3036 2011-05-31  Rob Buis  <rbuis@rim.com>
3037
3038         Reviewed by Dirk Schulze.
3039
3040         https://bugs.webkit.org/show_bug.cgi?id=34301
3041         Creating <animateMotion> elements via javascript do not execute
3042
3043         https://bugs.webkit.org/show_bug.cgi?id=17043
3044         SVG missing some .idl files
3045
3046         Add missing idl files.
3047
3048         Test: svg/animations/animate-mpath-insert.html
3049
3050         * CMakeLists.txt:
3051         * CodeGenerators.pri:
3052         * WebCore.gypi:
3053         * WebCore.xcodeproj/project.pbxproj:
3054         * svg/SVGAnimateMotionElement.idl: Added.
3055         * svg/SVGMPathElement.idl: Added.
3056
3057 2011-05-31  Robin Dunn  <robin@alldunn.com>
3058
3059         Reviewed by Kevin Ollivier.
3060
3061         [wx] Implement printing support for wxWidgets 2.9.x and above.
3062         
3063         https://bugs.webkit.org/show_bug.cgi?id=61796
3064
3065         * platform/graphics/GraphicsContext.h:
3066         * platform/graphics/wx/FontWx.cpp:
3067         (WebCore::Font::drawGlyphs):
3068         * platform/graphics/wx/GraphicsContextWx.cpp:
3069         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
3070         (WebCore::GraphicsContext::drawRect):
3071         (WebCore::GraphicsContext::drawLine):
3072         (WebCore::GraphicsContext::drawEllipse):
3073         (WebCore::GraphicsContext::strokeArc):
3074         (WebCore::GraphicsContext::drawConvexPolygon):
3075         (WebCore::GraphicsContext::fillRect):
3076         (WebCore::GraphicsContext::drawLineForText):
3077         (WebCore::GraphicsContext::scale):
3078         (WebCore::GraphicsContext::currentScale):
3079         * platform/wx/wxcode/win/non-kerned-drawing.cpp:
3080         (WebCore::drawTextWithSpacing):
3081
3082 2011-05-31  Joseph Pecoraro  <joepeck@webkit.org>
3083
3084         Reviewed by Pavel Feldman.
3085
3086         Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
3087         https://bugs.webkit.org/show_bug.cgi?id=61751
3088
3089         Add missing stub function causing an error on load.
3090
3091         * inspector/front-end/InspectorFrontendHostStub.js:
3092         (.WebInspector.InspectorFrontendHostStub.prototype.saveSessionSetting):
3093
3094 2011-05-31  Abhishek Arya  <inferno@chromium.org>
3095
3096         Reviewed by Dimitri Glazkov.
3097
3098         Improve hasMediaControls logic to check that node has
3099         media controls. This can be false when cloning nodes.
3100         https://bugs.webkit.org/show_bug.cgi?id=61765
3101
3102         Test: media/media-controls-clone-crash.html
3103
3104         * dom/Node.h:
3105         (WebCore::Node::isMediaControls):
3106         * html/HTMLMediaElement.cpp:
3107         (WebCore::HTMLMediaElement::mediaControls):
3108         (WebCore::HTMLMediaElement::hasMediaControls):
3109         * html/shadow/MediaControls.h:
3110         (WebCore::MediaControls::isMediaControls):
3111         (WebCore::toMediaControls):
3112
3113 2011-05-31  Xan Lopez  <xlopez@igalia.com>
3114
3115         Reviewed by Martin Robinson.
3116
3117         [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
3118         https://bugs.webkit.org/show_bug.cgi?id=61791
3119
3120         * bindings/gobject/GNUmakefile.am: add new files.
3121         * bindings/gobject/WebKitDOMCustom.cpp: Added.
3122         (webkit_dom_html_text_area_element_is_edited):
3123         (webkit_dom_html_input_element_is_edited):
3124         * bindings/gobject/WebKitDOMCustom.h: Added.
3125
3126 2011-05-31  Noam Rosenthal  <noam.rosenthal@nokia.com>
3127
3128         Unreviewed build fix for Symbian.
3129         Opt-out Symbian for TextureMapper.
3130
3131         No new tests: build fix.
3132
3133         * WebCore.pri:
3134
3135 2011-05-31  Levi Weintraub  <leviw@chromium.org>
3136
3137         Reviewed by Eric Seidel.
3138
3139         Switch paintFocusRing to IntPoint
3140         https://bugs.webkit.org/show_bug.cgi?id=61580
3141
3142         Switching paintFocusRing to take an IntPoint representing the paint offset
3143         instead of a pair of ints.
3144
3145         No new tests as this is just refactoring.
3146
3147         * rendering/RenderInline.cpp:
3148         (WebCore::RenderInline::paintOutline):
3149         * rendering/RenderObject.cpp:
3150         (WebCore::RenderObject::paintFocusRing):
3151         (WebCore::RenderObject::paintOutline):
3152         * rendering/RenderObject.h:
3153
3154 2011-05-31  Abhishek Arya  <inferno@chromium.org>
3155
3156         Reviewed by Dimitri Glazkov.
3157
3158         Convert raw ptr to RefPtr for documentElement.
3159         https://bugs.webkit.org/show_bug.cgi?id=61688
3160
3161         Test: fast/dom/xml-parser-error-message-crash.svg
3162
3163         * dom/XMLDocumentParser.cpp:
3164         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
3165
3166 2011-05-31  Andreas Kling  <kling@webkit.org>
3167
3168         Reviewed by Antti Koivisto.
3169
3170         Canvas/JSC: Auto-generate overloads for setShadow()
3171         https://bugs.webkit.org/show_bug.cgi?id=61786
3172
3173         Move CanvasRenderingContext2D.setShadow() to auto-generated JSC bindings.
3174
3175         There is a subtle difference to the previous behavior: invalid numbers of
3176         arguments now raise TypeError instead of SyntaxError. This is in accordance
3177         with Web IDL, and matches the existing V8 bindings.
3178
3179         Test: fast/canvas/canvas-overloads-setShadow.html
3180
3181         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3182         * html/canvas/CanvasRenderingContext2D.idl:
3183
3184 2011-05-31  Andreas Kling  <kling@webkit.org>
3185
3186         Reviewed by Antti Koivisto.
3187
3188         Canvas/JSC: Auto-generate overloads for drawImageFromRect()
3189         https://bugs.webkit.org/show_bug.cgi?id=61709
3190
3191         Move CanvasRenderingContext2D.drawImageFromRect() to auto-generated JSC bindings.
3192         Make it [RequiresAllArguments=Raise] to match the old behavior.
3193         Side effect: calling drawImageFromRect() with zero arguments will now raise
3194         SyntaxError instead of TypeError.
3195
3196         Test: fast/canvas/canvas-overloads-drawImageFromRect.html
3197
3198         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3199         * html/canvas/CanvasRenderingContext2D.h:
3200         * html/canvas/CanvasRenderingContext2D.idl:
3201
3202 2011-05-31  Andreas Kling  <kling@webkit.org>
3203
3204         Reviewed by Antti Koivisto.
3205
3206         Canvas/JSC: Auto-generate overloads for drawImage()
3207         https://bugs.webkit.org/show_bug.cgi?id=61703
3208
3209         Move CanvasRenderingContext2D.drawImage() to auto-generated JSC bindings.
3210
3211         There is a subtle difference to the previous behavior: invalid numbers of
3212         arguments now raise TypeError instead of SyntaxError. This is in accordance
3213         with Web IDL, and matches the existing V8 bindings.
3214
3215         Test: fast/canvas/canvas-overloads-drawImage.html
3216
3217         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3218         * html/canvas/CanvasRenderingContext2D.idl:
3219
3220 2011-05-31  Andreas Kling  <kling@webkit.org>
3221
3222         Reviewed by Antti Koivisto.
3223
3224         Canvas/JSC: Auto-generate overloads for strokeRect()
3225         https://bugs.webkit.org/show_bug.cgi?id=61641
3226
3227         Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.
3228
3229         No behavioral change.
3230
3231         Test: fast/canvas/canvas-overloads-strokeRect.html
3232
3233         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3234         * html/canvas/CanvasRenderingContext2D.idl:
3235
3236 2011-05-31  Andreas Kling  <kling@webkit.org>
3237
3238         Reviewed by Antti Koivisto.
3239
3240         Canvas/JSC: Auto-generate overloads for setFillColor()
3241         https://bugs.webkit.org/show_bug.cgi?id=61635
3242
3243         Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.
3244
3245         There is a subtle difference to the previous behavior: invalid numbers of
3246         arguments now raise TypeError instead of SyntaxError. This is in accordance
3247         with Web IDL, but doesn't matter much anyway since this method is WebKit-only.
3248
3249         Test: fast/canvas/canvas-overloads-setFillColor.html
3250
3251         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3252         * html/canvas/CanvasRenderingContext2D.idl:
3253
3254 2011-05-31  Andreas Kling  <kling@webkit.org>
3255
3256         Reviewed by Antti Koivisto.
3257
3258         Canvas/JSC: Auto-generate overloads for setStrokeColor()
3259         https://bugs.webkit.org/show_bug.cgi?id=61629
3260
3261         Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.
3262
3263         There is a subtle difference to the previous behavior: invalid numbers of
3264         arguments now raise TypeError instead of SyntaxError. This is in accordance
3265         with Web IDL, but doesn't matter much anyway since this method is WebKit-only.
3266
3267         Test: fast/canvas/canvas-overloads-setStrokeColor.html
3268
3269         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3270         * html/canvas/CanvasRenderingContext2D.idl:
3271
3272 2011-05-31  Andreas Kling  <kling@webkit.org>
3273
3274         Reviewed by Antti Koivisto.
3275
3276         Canvas/JSC: Auto-generate overloads for strokeText()
3277         https://bugs.webkit.org/show_bug.cgi?id=61626
3278
3279         Move CanvasRenderingContext2D.strokeText() to auto-generated JSC bindings.
3280         Make it [RequiresAllArguments=Raise] to match the old behavior.
3281         This has the side-effect of aligning the behaviors of JSC and V8.
3282
3283         Test: fast/canvas/canvas-overloads-strokeText.html
3284
3285         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3286         * html/canvas/CanvasRenderingContext2D.idl:
3287
3288 2011-05-31  Andreas Kling  <kling@webkit.org>
3289
3290         Reviewed by Antti Koivisto.
3291
3292         Canvas/JSC: Auto-generate overloads for fillText()
3293         https://bugs.webkit.org/show_bug.cgi?id=61623
3294
3295         Move CanvasRenderingContext2D.fillText() to auto-generated JSC bindings.
3296         Make it [RequiresAllArguments=Raise] to match the old behavior.
3297         This has the side-effect of aligning the behaviors of JSC and V8.
3298
3299         Test: fast/canvas/canvas-overloads-fillText.html
3300
3301         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3302         * html/canvas/CanvasRenderingContext2D.idl:
3303
3304 2011-05-31  Yael Aharon  <yael.aharon@nokia.com>
3305
3306         Reviewed by Kenneth Rohde Christiansen.
3307
3308         Frame flattening is broken with nested frames
3309         https://bugs.webkit.org/show_bug.cgi?id=61491
3310
3311         After r77988, when frame flattening is enabled, performPostLayoutTasks() is called on a timer for iframes.
3312         This causes layout of nested iframes to sometimes happen asynchronously, but WebCore expects layout to always finish synchronously.
3313         Added a call to updateWidgetPosition() for cases that performPostLayoutTasks() is now happening asynchronously.
3314
3315         Test: fast/frames/flattening/iframe-flattening-nested.html
3316
3317         * page/FrameView.cpp:
3318         (WebCore::FrameView::layout):
3319
3320 2011-05-31  Tommy Widenflycht  <tommyw@google.com>
3321
3322         Reviewed by Tony Gentilcore.
3323
3324         Fix getUserMedia callback bindings for JSC.
3325         https://bugs.webkit.org/show_bug.cgi?id=60174
3326
3327         This patch initializes the exception code variable to 0.
3328
3329         Test: fast/dom/MediaStream/argument-types.html
3330
3331         * bindings/js/JSNavigatorCustom.cpp:
3332         (WebCore::JSNavigator::webkitGetUserMedia):
3333
3334 2011-05-31  Oleg Romashin  <oleg.romashin@nokia.com>
3335
3336         Reviewed by Benjamin Poulain.
3337
3338         Fix compilation with debug enabled, m_lightSource.type is not valid anymore
3339         https://bugs.webkit.org/show_bug.cgi?id=61719
3340
3341         * platform/graphics/filters/arm/FELightingNEON.h:
3342         (WebCore::FELighting::platformApplyNeon):
3343
3344 2011-05-31  Oliver Varga  <Varga.Oliver@stud.u-szeged.hu>
3345
3346         Reviewed by Nikolas Zimmermann.
3347
3348         Invalid color handling is broken for SVG
3349         https://bugs.webkit.org/show_bug.cgi?id=58531
3350
3351         Fix invalid color fallback handling. If the fill/stroke attributes computed
3352         value leads to a an invalid color, inherit the desired color from the parent
3353         style instead. Matches Opera/FF and SVG 1.1 Second Edition (http://www.w3.org/TR/SVG/).
3354
3355         Tests: svg/custom/invalid-stroke-hex.svg
3356                svg/custom/invalid-uri-stroke.svg
3357
3358         * rendering/svg/RenderSVGResource.cpp:
3359         (WebCore::inheritColorFromParentStyleIfNeeded):
3360         (WebCore::requestPaintingResource):
3361
3362 2011-05-31  Vangelis Kokkevis  <vangelis@chromium.org>
3363
3364         Reviewed by Kent Tamura.
3365
3366         [chromium] Avoid double deletion of DrawingBuffer's color buffer
3367         texture.
3368         https://bugs.webkit.org/show_bug.cgi?id=61761
3369
3370         Test: Verified that the DCHECK in GraphicsContext3D implementation
3371         doesn't trigger.
3372
3373         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3374         (WebCore::DrawingBuffer::~DrawingBuffer):
3375
3376 2011-05-30  Hayato Ito  <hayato@chromium.org>
3377
3378         Reviewed by Ryosuke Niwa.
3379
3380         Add a utility function for dumping a tree for the Node, including a document of a frame.
3381         https://bugs.webkit.org/show_bug.cgi?id=61727
3382
3383         No new tests since added functions are only available in debug builds.
3384
3385         * dom/Node.cpp:
3386         (WebCore::parentOrHostOrFrameOwner):
3387         (WebCore::traverseNextNodeAcrossFrame):
3388         (WebCore::Node::showTreeForThisAcrossFrame):
3389         * dom/Node.h:
3390
3391 2011-05-30  James Kozianski  <koz@chromium.org>
3392