1 2010-12-06 Yael Aharon <yael.aharon@nokia.com>
3 Reviewed by Andreas Kling.
5 [Qt] Support focus ring outline color for links.
6 https://bugs.webkit.org/show_bug.cgi?id=50428
8 Take width and offset into account when drawing focus ring.
10 Tests: fast/css/focus-ring-outline-color.html
11 fast/css/focus-ring-outline-offset.html
12 fast/css/focus-ring-outline-width.html
14 * platform/graphics/qt/GraphicsContextQt.cpp:
15 (WebCore::GraphicsContext::drawFocusRing):
17 2010-12-06 Yael Aharon <yael.aharon@nokia.com>
19 Reviewed by Andreas Kling.
21 [Qt] Fix focus ring outline color support
22 https://bugs.webkit.org/show_bug.cgi?id=50325
24 * platform/graphics/qt/GraphicsContextQt.cpp:
25 (WebCore::GraphicsContext::drawFocusRing):
27 Take the outline width into account when drawing the focus ring of image map.
28 Change the outline-style from dotted to solid. The default outline-width is
29 5 pixels, and dotted lines just don't make sense anymore.
30 Give the focus ring alpha of 50%, following what other ports do.
31 Save and restore the pen when drawing a focus ring.
33 2010-12-06 Andras Becsi <abecsi@webkit.org>
35 Reviewed by Csaba Osztrogonác.
37 [Qt][V8] Build fix after r73283.
41 * WebCore.pri: Add missing webaudio directory
42 to IDL generator includes.
44 2010-12-06 Philippe Normand <pnormand@igalia.com>
46 Reviewed by Martin Robinson.
48 [soup] implement ResourceHandle::platformSetDefersLoading
49 https://bugs.webkit.org/show_bug.cgi?id=44158
51 * platform/network/soup/ResourceHandleSoup.cpp:
52 (WebCore::ResourceHandle::platformSetDefersLoading): Implemented
53 using the soup_session_{,un}pause_message APIs.
55 2010-12-06 Sergio Villar Senin <svillar@igalia.com>
57 Reviewed by Martin Robinson.
59 [GTK] Leak in webkit_soup_cache_load if file contents load fails
60 https://bugs.webkit.org/show_bug.cgi?id=50558
62 g_file_get_contents() could return an error after allocating a
63 buffer for file contents. We must free that memory before
66 * platform/network/soup/cache/webkit/soup-cache.c:
67 (webkit_soup_cache_load): Added a missing g_free().
69 2010-12-06 Sheriff Bot <webkit.review.bot@gmail.com>
71 Unreviewed, rolling out r73351.
72 http://trac.webkit.org/changeset/73351
73 https://bugs.webkit.org/show_bug.cgi?id=50560
75 "The change broke plugin tests in Chromium" (Requested by
78 * bindings/js/ScriptCallStackFactory.cpp:
79 (WebCore::ScriptCallStack::stackTrace):
80 * bindings/js/ScriptCallStackFactory.h:
81 * bindings/v8/ScriptCallStackFactory.cpp:
82 (WebCore::toScriptCallFrame):
83 (WebCore::toScriptCallFramesVector):
84 (WebCore::createScriptCallStack):
85 (WebCore::ScriptCallStack::stackTrace):
86 * bindings/v8/ScriptCallStackFactory.h:
87 * bindings/v8/V8ConsoleMessage.cpp:
88 (WebCore::V8ConsoleMessage::handler):
89 * inspector/ScriptCallFrame.cpp:
90 (WebCore::ScriptCallFrame::ScriptCallFrame):
91 (WebCore::ScriptCallFrame::isEqual):
92 (WebCore::ScriptCallFrame::buildInspectorObject):
93 * inspector/ScriptCallFrame.h:
94 (WebCore::ScriptCallFrame::sourceURL):
95 * inspector/ScriptCallStack.h:
96 * inspector/TimelineRecordFactory.cpp:
97 (WebCore::TimelineRecordFactory::createGenericRecord):
98 * inspector/front-end/ConsoleView.js:
99 (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
101 2010-12-06 Robert Hogan <robert@webkit.org>
103 Reviewed by Kenneth Rohde Christiansen.
105 [Qt] Report zero width for zero size fonts
107 Report zero width when font size is zero.
109 Fixes fast/text/font-size-zero.html
111 https://bugs.webkit.org/show_bug.cgi?id=50539
113 * platform/graphics/qt/FontQt.cpp:
114 (WebCore::Font::floatWidthForSimpleText):
115 (WebCore::Font::floatWidthForComplexText):
117 2010-12-03 Yury Semikhatsky <yurys@chromium.org>
119 Reviewed by Pavel Feldman.
121 [v8] Web Inspector: remove duplicate code for capturing stack trace
122 https://bugs.webkit.org/show_bug.cgi?id=50461
124 No new tests. Covered with existing inspector tests.
126 * bindings/js/ScriptCallStackFactory.cpp:
127 (WebCore::createScriptCallStack):
128 * bindings/js/ScriptCallStackFactory.h:
129 * bindings/v8/ScriptCallStackFactory.cpp:
130 (WebCore::toScriptCallFrame):
131 (WebCore::toScriptCallFramesVector):
132 (WebCore::createScriptCallStack):
133 * bindings/v8/ScriptCallStackFactory.h:
134 * bindings/v8/V8ConsoleMessage.cpp:
135 (WebCore::V8ConsoleMessage::handler):
136 * inspector/ScriptCallFrame.cpp:
137 (WebCore::ScriptCallFrame::ScriptCallFrame):
138 (WebCore::ScriptCallFrame::isEqual):
139 (WebCore::ScriptCallFrame::buildInspectorObject):
140 * inspector/ScriptCallFrame.h:
141 (WebCore::ScriptCallFrame::sourceURL):
142 * inspector/ScriptCallStack.h:
143 * inspector/TimelineRecordFactory.cpp:
144 (WebCore::TimelineRecordFactory::createGenericRecord):
145 * inspector/front-end/ConsoleView.js:
146 (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
148 2010-12-06 Sergio Villar Senin <svillar@igalia.com>
150 Reviewed by Martin Robinson.
152 [GTK] webkit_soup_cache_clear() does not delete all entries in the cache
153 https://bugs.webkit.org/show_bug.cgi?id=50462
155 Do not use g_hash_table_foreach to remove entries from the cache
156 entries hashtable. Iterate over a list of entries to remove them
159 * platform/network/soup/ResourceHandleSoup.cpp:
160 * platform/network/soup/cache/webkit/soup-cache.c:
162 (webkit_soup_cache_finalize):
164 (webkit_soup_cache_clear):
166 2010-12-05 Kent Tamura <tkent@chromium.org>
168 Unreviewed. Run sort-Xcode-project-file.
170 * WebCore.xcodeproj/project.pbxproj:
172 2010-11-30 Luiz Agostini <luiz.agostini@openbossa.org>
174 Reviewed by Darin Adler.
176 HTML5 <details> and <summary> initial implementation
177 https://bugs.webkit.org/show_bug.cgi?id=50309
179 HTML5 <details> and <summary> elements initial implementation. The main objective is
180 to add the files for html element and renderers, and to get rid of build system issues
183 See: http://www.w3.org/TR/html5/interactive-elements.html#the-details-element
184 http://www.w3.org/TR/html5/interactive-elements.html#the-summary-element
189 * DerivedSources.cpp:
190 * DerivedSources.make:
195 * WebCore.vcproj/WebCore.vcproj:
196 * WebCore.xcodeproj/project.pbxproj:
197 * bindings/gobject/GNUmakefile.am:
199 Some css properties to the new html elements.
205 New html element associated with the corresponding tag.
207 * html/HTMLAttributeNames.in:
208 * html/HTMLTagNames.in:
210 1 html element and 3 renderers were added.
212 * html/HTMLDetailsElement.cpp: Added.
213 * html/HTMLDetailsElement.h: Added.
214 * html/HTMLDetailsElement.idl: Added.
215 * html/HTMLElementsAllInOne.cpp:
216 * rendering/RenderDetails.cpp: Added.
217 * rendering/RenderDetails.h: Added.
218 * rendering/RenderDetailsMarker.cpp: Added.
219 * rendering/RenderDetailsMarker.h: Added.
220 * rendering/RenderSummary.cpp: Added.
221 * rendering/RenderSummary.h: Added.
222 * rendering/RenderingAllInOne.cpp:
224 New renderer type checkers.
226 * rendering/RenderObject.h:
227 (WebCore::RenderObject::isDetails):
228 (WebCore::RenderObject::isDetailsMarker):
229 (WebCore::RenderObject::isSummary):
231 2010-12-05 Rob Buis <rwlbuis@gmail.com>
233 Reviewed by Nikolas Zimmermann.
235 createSVGTransformFromMatrix(undefined) => NULL ptr
236 https://bugs.webkit.org/show_bug.cgi?id=49564
238 Throw TYPE_MISMATCH_ERR when using undefined or null as value for matrix parameter.
240 * svg/SVGTransformList.idl:
241 * svg/properties/SVGTransformListPropertyTearOff.h:
242 (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
244 2010-12-05 Alejandro G. Castro <alex@igalia.com>
246 Reviewed by Xan Lopez.
248 [GTK] Fix compilation warnings reported by clang
249 https://bugs.webkit.org/show_bug.cgi?id=50252
251 * platform/graphics/Path.h: CairoPath is now a class, not a
253 * platform/network/soup/ResourceHandleSoup.cpp:
254 (WebCore::sendRequestCallback): Cast the status_code to int.
256 2010-12-05 Alejandro G. Castro <alex@igalia.com>
258 Reviewed by Martin Robinson.
260 [GTK] Remove setColor functions it was replicated in
261 CairoUtilities: setSourceRGBAFromColor.
263 * platform/graphics/cairo/GraphicsContextCairo.cpp:
264 (WebCore::setPlatformFill):
265 (WebCore::setPlatformStroke):
266 (WebCore::fillRectSourceOver):
267 (WebCore::GraphicsContext::drawRect):
268 (WebCore::GraphicsContext::drawLine):
269 (WebCore::GraphicsContext::drawEllipse):
270 (WebCore::GraphicsContext::strokeArc):
271 (WebCore::GraphicsContext::drawConvexPolygon):
272 (WebCore::GraphicsContext::drawFocusRing):
273 (WebCore::GraphicsContext::fillRoundedRect):
275 2010-12-05 Adam Roben <aroben@apple.com>
277 Windows production build fix
279 Put spaces after trailing backslashes when setting
280 %WebKitVSPropsRedirectionDir%. According to MSDN
281 <http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>:
283 A backslash ( \ ) followed by a newline character is interpreted as
284 a space in the command; use a backslash at the end of a line to
285 continue a command onto the next line. NMAKE interprets the
286 backslash literally if any other character, including a space or
287 tab, follows the backslash.
289 * WebCore.vcproj/WebCore.make:
291 2010-12-05 Robert Hogan <robert@webkit.org>
293 Reviewed by Andreas Kling.
295 [Qt] Zero-sized font does not yet work
297 Fix fast/text/font-size-zero.html
299 Copy other ports by setting minimumFontSize to 0 for DRT runs,
300 copy a fix to SimpleFontData from chromium/safari, and set font
301 size in FontPlatformData to zero if size zero is requested
302 and QFont::pixelSize otherwise. (Note that QFont doesn't accept
303 a pixel size of zero).
305 Also fix QFont::setPixelSize in FontPlatformData to use
306 description.computedPixelSize rather than computedSize and
307 pixelSize() rather than pointSizeF - since the latter gets
308 set to -1 if pixelSize is set at all.
310 https://bugs.webkit.org/show_bug.cgi?id=49759
312 * platform/graphics/qt/FontPlatformData.h:
313 (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
314 (WebCore::FontPlatformData::pixelSize):
315 * platform/graphics/qt/FontPlatformDataQt.cpp:
316 (WebCore::FontPlatformData::FontPlatformData):
317 * platform/graphics/qt/FontQt.cpp:
318 (WebCore::drawTextCommon):
319 * platform/graphics/qt/SimpleFontDataQt.cpp:
320 (WebCore::SimpleFontData::platformInit):
321 (WebCore::SimpleFontData::platformGlyphInit):
322 (WebCore::SimpleFontData::platformCharWidthInit):
324 2010-12-04 Daniel Bates <dbates@rim.com>
326 Reviewed by Darin Adler.
328 Add support for lower-armenian and upper-armenian
329 https://bugs.webkit.org/show_bug.cgi?id=49641
331 Implement support for list-style-types lower-armenian and upper-armenian
332 for lowercase Armenian and uppercase Armenian numerals, respectively.
334 Tests: fast/lists/w3-css3-lower-armenian.html
335 fast/lists/w3-css3-upper-armenian.html
337 * css/CSSPrimitiveValueMappings.h:
338 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added enum values LowerArmenian
340 * css/CSSValueKeywords.in: Added "upper-armenian" and "lower-armenian".
341 * inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
342 * rendering/RenderListMarker.cpp:
343 (WebCore::effectiveListMarkerType): Added enum values LowerArmenian
345 (WebCore::listMarkerSuffix): Ditto.
346 (WebCore::listMarkerText): Ditto.
347 (WebCore::RenderListMarker::paint): Ditto.
348 (WebCore::RenderListMarker::computePreferredLogicalWidths): Ditto.
349 (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
350 * rendering/style/RenderStyleConstants.h: Ditto.
352 2010-12-04 Dan Bernstein <mitz@apple.com>
354 Reviewed by Sam Weinig.
356 WebCore part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
357 https://bugs.webkit.org/show_bug.cgi?id=50530
359 * WebCore.exp.in: Export Range version of countMatchesForText().
360 * editing/Editor.cpp:
361 (WebCore::isFrameInRange): Added this helper method.
362 (WebCore::Editor::countMatchesForText): Added a Range parameter and restricted the result to
363 matches that occur in the range.
366 2010-12-04 Gavin Peters <gavinp@chromium.org>
368 Reviewed by Adam Barth.
370 Implement onload events for <link rel=prefetch>
371 https://bugs.webkit.org/show_bug.cgi?id=50187
373 Tests: fast/dom/HTMLLinkElement/link-and-subresource-test.html
374 fast/dom/HTMLLinkElement/prefetch-onload.html
376 * html/HTMLLinkElement.cpp:
377 (WebCore::HTMLLinkElement::HTMLLinkElement):
378 (WebCore::HTMLLinkElement::~HTMLLinkElement):
379 (WebCore::HTMLLinkElement::parseMappedAttribute):
380 (WebCore::HTMLLinkElement::process):
381 (WebCore::HTMLLinkElement::onloadTimerFired):
382 (WebCore::HTMLLinkElement::notifyFinished):
383 * html/HTMLLinkElement.h:
384 * loader/cache/CachedResource.cpp:
385 (WebCore::CachedResource::data):
387 2010-12-04 Xan Lopez <xlopez@igalia.com>
389 Reviewed by Martin Robinson.
391 [GTK] Drop GdkDrawable usage, it's deprecated in GTK+3.x and we can use GdkWindow
392 https://bugs.webkit.org/show_bug.cgi?id=50451
394 GdkDrawable has been removed in GTK+3.x. To cope with this we can
395 actually stop using it altogether, since GdkWindow is just a
396 typedef for it and that seems to be good enough for us.
398 * platform/graphics/GraphicsContext.h: s/GdkDrawable/GdkWindow/.
399 * platform/graphics/cairo/GraphicsContextCairo.cpp:
400 (WebCore::GraphicsContext::gdkWindow): ditto.
401 * platform/gtk/GtkVersioning.h: declare GDK_WINDOW_XWINDOW for GTK 3.x builds.
402 * platform/gtk/PlatformScreenGtk.cpp:
403 (WebCore::screenAvailableRect): s/GdkDrawable/GdkWindow/.
404 * platform/gtk/WidgetGtk.cpp:
405 (WebCore::gdkWindow): ditto.
406 (WebCore::Widget::setCursor): ditto.
407 * platform/gtk/WidgetRenderingContextGtk2.cpp: ditto.
409 2010-12-03 Dimitri Glazkov <dglazkov@chromium.org>
411 Reviewed by Darin Adler.
413 REGRESSION(r71934): input event fires twice when editing text inside a text input.
414 https://bugs.webkit.org/show_bug.cgi?id=50477
416 Now that events escape the shadow DOM boundary, the input event is fired twice
417 for each input, once triggered by editing, once triggered by value change.
419 Test: fast/forms/text-input-event.html
421 * dom/InputElement.cpp:
422 (WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields
423 don't fire an extra input event.
425 2010-12-03 Sheriff Bot <webkit.review.bot@gmail.com>
427 Unreviewed, rolling out r73302.
428 http://trac.webkit.org/changeset/73302
429 https://bugs.webkit.org/show_bug.cgi?id=50499
431 Causes crashes in debug LayoutTests (Requested by xan_ on
434 * accessibility/AccessibilityRenderObject.cpp:
435 (WebCore::AccessibilityRenderObject::renderParentObject):
436 (WebCore::AccessibilityRenderObject::addChildren):
437 * accessibility/AccessibilityRenderObject.h:
438 * accessibility/chromium/AccessibilityObjectChromium.cpp:
439 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
441 2010-12-01 Ilya Tikhonovsky <loislo@chromium.org>
443 Reviewed by Pavel Feldman.
445 Web Inspector: Inspector protocol cleanup task.
447 The patch has just small renames and adjustments for the protocol things.
448 'handler' keyword in idl file was replaced with 'domain'.
449 'domain' property was assigned for the each backend to frontend messages.
450 At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
452 https://bugs.webkit.org/show_bug.cgi?id=50337
454 * inspector/CodeGeneratorInspector.pm:
455 * inspector/Inspector.idl:
456 * inspector/front-end/inspector.js:
457 (WebInspector_syncDispatch):
459 2010-12-03 Alexander Pavlov <apavlov@chromium.org>
461 Reviewed by Yury Semikhatsky.
463 Web Inspector: Duplicate "!important" for !important properties displayed in the Styles pane
464 https://bugs.webkit.org/show_bug.cgi?id=50460
466 * inspector/front-end/StylesSidebarPane.js:
467 * inspector/front-end/inspector.css:
469 2010-12-03 Xan Lopez <xlopez@igalia.com>
471 Unreviewed build fix.
473 The JS code generator includes headers unconditionally, so we need
474 to generate them unconditionally and disable the feature. The
475 WebAudio files hadn't been added to our sources list.
479 2010-12-03 Patrick Gansterer <paroga@webkit.org>
481 Unreviewed build fix.
483 Try to fix EFL build after r73273.
487 2010-12-03 Chris Guillory <chris.guillory@google.com>
489 Reviewed by Chris Fleizach.
491 Include the FrameView widget of a RenderWidget in the accessibility tree.
492 https://bugs.webkit.org/show_bug.cgi?id=49106
494 Include render widget children in the accessibility tree for not mac webkit ports.
496 * accessibility/AccessibilityRenderObject.cpp:
497 (WebCore::AccessibilityRenderObject::renderParentObject):
498 (WebCore::AccessibilityRenderObject::addChildren):
499 (WebCore::AccessibilityRenderObject::addRenderWidgetChildren):
500 * accessibility/AccessibilityRenderObject.h:
501 * accessibility/chromium/AccessibilityObjectChromium.cpp:
502 (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
504 2010-11-30 Abhishek Arya <inferno@chromium.org>
506 Reviewed by Dave Hyatt.
508 Don't clone an anonymous block, instead create a new one in splitBlocks. Also,
509 when beforeChild is not in one of our children, then do the processing first
510 to get its anonymous container before calling splitBlocks.
511 https://bugs.webkit.org/show_bug.cgi?id=49928
513 Tests: fast/multicol/span/anonymous-before-child-parent-crash.html
514 fast/multicol/span/anonymous-split-block-crash.html
516 * rendering/RenderBlock.cpp:
517 (WebCore::RenderBlock::splitBlocks):
518 (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
520 2010-12-03 Mark Rowe <mrowe@apple.com>
522 Reviewed by Eric Seidel.
524 Animated GIF animates much more slowly in Safari than Firefox
525 <rdar://problem/7689300> / <http://webkit.org/b/26455>
527 Adopt Firefox's behavior for frame duration clamping. Images that specify a frame duration
528 of <= 10ms are treated as having a frame duration of 100ms, while all other images use the
529 frame duration that they specify.
531 ImageIO currently implements its own clamping of frame durations (<rdar://problem/7689297>)
532 which will result in this change having no observable effect on platforms where it is used
533 until an updated version of ImageIO becomes available.
535 * platform/graphics/ImageSource.cpp:
536 (WebCore::ImageSource::frameDurationAtIndex): Update the formatting of the comment and style
537 of the code to match that in ImageSourceCG.
538 * platform/graphics/cg/ImageSourceCG.cpp:
539 (WebCore::ImageSource::frameDurationAtIndex):
541 2010-12-03 Chris Rogers <crogers@google.com>
543 Unreviewed build fix.
545 Fix M_E compile error on Chromium Win
546 https://bugs.webkit.org/show_bug.cgi?id=50479
548 * platform/audio/AudioUtilities.cpp:
549 (WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
551 2010-12-03 Chris Rogers <crogers@google.com>
553 Unreviewed build fix.
555 Try to fix GTK build due to recent web audio makefile changes (disable ENABLE_WEB_AUDIO explicitly)
556 https://bugs.webkit.org/show_bug.cgi?id=50478
560 2010-12-03 Simon Fraser <simon.fraser@apple.com>
562 Reviewed by Dirk Schulze.
564 Clean up some text-related code on GraphicsContext
565 https://bugs.webkit.org/show_bug.cgi?id=50464
567 Save 8 bytes in GraphicsContextState by rearranging the
568 data members to reduce padding.
570 * platform/graphics/GraphicsContextPrivate.h:
571 (WebCore::GraphicsContextState::GraphicsContextState):
573 2010-12-03 Simon Fraser <simon.fraser@apple.com>
575 Another Chromium build fix.
577 * platform/graphics/skia/GraphicsContextSkia.cpp:
578 (WebCore::GraphicsContext::setPlatformTextDrawingMode):
580 2010-12-03 Simon Fraser <simon.fraser@apple.com>
584 * platform/graphics/skia/PlatformContextSkia.h:
586 2010-12-03 Patrick Gansterer <paroga@webkit.org>
588 Reviewed by Andreas Kling.
590 [CMake] Remove WebCore_IDL_PURE_FILES
591 https://bugs.webkit.org/show_bug.cgi?id=50445
595 2010-12-03 Jia Pu <jpu@apple.com>
597 Reviewed by Darin Adler.
599 Need to move all code that applies correction into correction panel callback.
600 https://bugs.webkit.org/show_bug.cgi?id=50426
601 <rdar://problem/8720832>
603 No new test, since there's no behavioral change.
605 This patch is to prepare WebKit to work with upcoming AppKit changes. The main changes are:
606 1. Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult().
607 2. Added more user dictionary learning code.
608 3. Removed m_ prefix in all member variables of CorrectionPanelInfo.
610 * editing/CorrectionPanelInfo.h: Remove m_ prefix on member variables. Added ReasonForDismissingCorrectionPanel enum type.
612 * editing/Editor.cpp: Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult().
613 Adopted new member variable naming in class CorrectionPanelInfo.
614 (WebCore::Editor::respondToChangedSelection):
615 (WebCore::Editor::~Editor):
616 (WebCore::Editor::markMisspellingsAfterTypingToWord):
617 (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
618 (WebCore::Editor::correctionPanelTimerFired):
619 (WebCore::Editor::handleCorrectionPanelResult):
620 (WebCore::Editor::startCorrectionPanelTimer):
621 (WebCore::Editor::stopCorrectionPanelTimer):
622 (WebCore::Editor::handleCancelOperation):
623 (WebCore::Editor::dismissCorrectionPanel):
624 (WebCore::Editor::applyCorrectionPanelInfo):
626 * editing/Editor.h: Changed signature of dismissCorrectionPanel to use ReasonForDismissingCorrectionPanel.
628 * loader/EmptyClients.h: Ditto.
629 (WebCore::EmptyEditorClient::dismissCorrectionPanel):
631 * page/EditorClient.h: Ditto.
633 2010-12-03 Pavel Feldman <pfeldman@chromium.org>
635 Reviewed by Yury Semikhatsky.
637 Web Inspector: reveal in elements panel does not switch the panel itself.
638 https://bugs.webkit.org/show_bug.cgi?id=50408
640 * inspector/front-end/ElementsTreeOutline.js:
641 (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
642 (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
643 * inspector/front-end/ObjectPropertiesSection.js:
644 (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
646 2010-12-03 Simon Fraser <simon.fraser@apple.com>
648 Reviewed by Nikolas Zimmermann.
650 Clean up some text-related code on GraphicsContext
651 https://bugs.webkit.org/show_bug.cgi?id=50464
653 Use defined types for textDrawingMode and it's associated flags.
655 * html/canvas/CanvasRenderingContext2D.cpp:
656 (WebCore::CanvasRenderingContext2D::drawTextInternal):
657 * platform/graphics/GraphicsContext.cpp:
658 (WebCore::GraphicsContext::textDrawingMode):
659 (WebCore::GraphicsContext::setTextDrawingMode):
660 (WebCore::GraphicsContext::setPlatformTextDrawingMode):
661 * platform/graphics/GraphicsContext.h:
662 * platform/graphics/GraphicsContextPrivate.h:
663 (WebCore::GraphicsContextState::GraphicsContextState):
664 * platform/graphics/cairo/FontCairo.cpp:
665 (WebCore::drawGlyphsShadow):
666 (WebCore::Font::drawGlyphs):
667 * platform/graphics/cg/GraphicsContextCG.cpp:
668 (WebCore::GraphicsContext::setPlatformTextDrawingMode):
669 * platform/graphics/chromium/FontLinux.cpp:
670 (WebCore::Font::drawGlyphs):
671 (WebCore::Font::drawComplexText):
672 * platform/graphics/gtk/FontGtk.cpp:
673 (WebCore::drawGlyphsShadow):
674 (WebCore::Font::drawComplexText):
675 * platform/graphics/mac/FontMac.mm:
676 (WebCore::Font::drawGlyphs):
677 * platform/graphics/openvg/PainterOpenVG.cpp:
678 (WebCore::PlatformPainterState::PlatformPainterState):
679 (WebCore::PainterOpenVG::textDrawingMode):
680 (WebCore::PainterOpenVG::setTextDrawingMode):
681 (WebCore::PainterOpenVG::drawText):
682 * platform/graphics/qt/FontQt.cpp:
683 (WebCore::drawTextCommon):
684 * platform/graphics/skia/PlatformContextSkia.cpp:
685 (WebCore::PlatformContextSkia::State::State):
686 (WebCore::PlatformContextSkia::getTextDrawingMode):
687 (WebCore::PlatformContextSkia::setTextDrawingMode):
688 * platform/graphics/skia/SkiaFontWin.cpp:
689 (WebCore::windowsCanHandleTextDrawing):
690 (WebCore::paintSkiaText):
691 * platform/graphics/texmap/TextureMapper.h:
692 (WebCore::TextureMapper::setTextDrawingMode):
693 (WebCore::TextureMapper::textDrawingMode):
694 (WebCore::TextureMapper::TextureMapper):
695 * platform/graphics/win/FontCGWin.cpp:
696 (WebCore::drawGDIGlyphs):
697 (WebCore::Font::drawGlyphs):
698 * platform/graphics/wince/GraphicsContextWinCE.cpp:
699 (WebCore::GraphicsContext::drawText):
700 * rendering/InlineTextBox.cpp:
701 (WebCore::updateGraphicsContext):
702 * rendering/RenderSVGResourceGradient.cpp:
703 (WebCore::RenderSVGResourceGradient::applyResource):
704 * rendering/RenderSVGResourcePattern.cpp:
705 (WebCore::RenderSVGResourcePattern::applyResource):
706 * rendering/RenderSVGResourceSolidColor.cpp:
707 (WebCore::RenderSVGResourceSolidColor::applyResource):
709 (WebCore::Font::drawTextUsingSVGFont):
711 2010-12-03 Chris Rogers <crogers@google.com>
713 Reviewed by Kenneth Russell.
715 First steps to adding web audio files to build systems
716 https://bugs.webkit.org/show_bug.cgi?id=49952
718 No new tests since audio API is not yet implemented.
721 * DerivedSources.make:
722 * ForwardingHeaders/wtf/Complex.h: Added.
724 * WebCore.gyp/WebCore.gyp:
728 * bindings/js/JSDOMWindowCustom.cpp:
729 (WebCore::JSDOMWindow::audioContext):
731 * page/DOMWindow.idl:
732 * platform/audio/HRTFElevation.cpp:
734 2010-12-03 Patrick Gansterer <paroga@webkit.org>
736 Reviewed by David Levin.
738 Use String::adopt in TextCodecWinCE::decode
739 https://bugs.webkit.org/show_bug.cgi?id=50319
741 * platform/text/wince/TextCodecWinCE.cpp:
742 (WebCore::TextCodecWinCE::decode):
744 2010-12-03 Brady Eidson <beidson@apple.com>
746 Reviewed by Anders Carlsson.
748 Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
749 WebKit2 Authentication Support
753 Expose the AuthenticationClient for WK2 platforms (Windows already does this):
754 * platform/network/mac/AuthenticationChallenge.h:
755 * platform/network/mac/AuthenticationMac.mm:
756 (-[WebCoreAuthenticationClientAsChallengeSender client]):
757 (WebCore::AuthenticationChallenge::authenticationClient):
759 * platform/network/qt/AuthenticationChallenge.h:
760 (WebCore::AuthenticationChallenge::authenticationClient):
762 2010-12-03 Ryosuke Niwa <rniwa@webkit.org>
764 Reviewed by Darin Adler.
766 REGRESSION: Crash when deleting text after textarea's value is modified on input event
767 https://bugs.webkit.org/show_bug.cgi?id=49962
769 The crash was caused by TypingCommand::deleteKeyPressed's reusing a typing command for
770 textarea's shadow DOM after its input event handler rewrote the value set by the typing command.
771 Because the reused typing command's ending selection was pointing at a shadow node
772 that has been detached from the document when the event handler set the new value,
773 rootEditableElement of the ending selection was null and caused the crash.
775 Fixed the bug by updating the ending selection of the last typing command when it differsfrom
776 that of the current selection held by the SelectionController in TypingCommand::deleteKeyPressed.
777 Also fixed similar bugs in forwardDeleteKeyPressed and insertText, and insertTextRunWithoutNewlines.
779 Tests: editing/input/set-value-on-input-and-delete.html
780 editing/input/set-value-on-input-and-forward-delete.html
781 editing/input/set-value-on-input-and-type-input.html
782 editing/input/set-value-on-input-and-type-textarea.html
784 * editing/InsertTextCommand.h: Added TypingCommand as a friend because it needs to update selection.
785 * editing/TypingCommand.cpp:
786 (WebCore::TypingCommand::deleteKeyPressed): Updates the last typing command's selection as needed.
787 (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
788 (WebCore::TypingCommand::insertText): Ditto.
789 (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection): Added.
790 (WebCore::TypingCommand::insertTextRunWithoutNewlines): Updates InsertTextCommand's selection as needed.
791 * editing/TypingCommand.h:
793 2010-12-03 Daniel Cheng <dcheng@chromium.org>
795 Reviewed by Tony Chang.
797 Dragging and dropping into an empty document crashes WebKit.
798 https://bugs.webkit.org/show_bug.cgi?id=48793
800 Remove the assert and update callers to check for a null return value.
802 Test: manual-tests/drop-in-empty-doc.html
804 * manual-tests/drop-in-empty-doc.html: Added.
805 * manual-tests/resources/drop-in-empty-doc.xhtml: Added.
806 * page/DragController.cpp:
807 (WebCore::elementUnderMouse):
808 (WebCore::DragController::tryDocumentDrag):
809 (WebCore::DragController::concludeEditDrag):
811 2010-12-03 Patrick Gansterer <paroga@webkit.org>
813 Reviewed by Andreas Kling.
815 Move Inspector generator logic into main CMakeLists.txt file
816 https://bugs.webkit.org/show_bug.cgi?id=50445
820 2010-12-03 Patrick Gansterer <paroga@webkit.org>
822 Reviewed by Andreas Kling.
824 Move StringWx.cpp into wtf directory
825 https://bugs.webkit.org/show_bug.cgi?id=50060
828 * platform/text/wx/StringWx.cpp: Removed.
830 2010-12-03 Dimitri Glazkov <dglazkov@chromium.org>
832 Reviewed by Darin Adler.
834 REGRESSION(r72783): DOMActivate fires multiple times from input type=file
835 https://bugs.webkit.org/show_bug.cgi?id=50396
837 Test: fast/events/shadow-boundary-crossing-2.html
839 * dom/EventContext.cpp: Reverted changes made in r72783.
840 * dom/EventContext.h: Ditto.
842 (WebCore::Node::containsIncludingShadowDOM): Added.
843 (WebCore::Node::dispatchGenericEvent): Reverted changes made in r72783.
844 * dom/Node.h: Added decl.
845 * html/HTMLLabelElement.cpp:
846 (WebCore::HTMLLabelElement::defaultEventHandler): Reverted changes made in r72783.
848 2010-12-03 Patrick Gansterer <paroga@webkit.org>
850 Reviewed by Andreas Kling.
852 Move StringBrew.cpp into wtf directory
853 https://bugs.webkit.org/show_bug.cgi?id=50058
855 * platform/text/brew/StringBrew.cpp: Removed.
857 2010-12-03 Patrick Gansterer <paroga@webkit.org>
859 Reviewed by Andreas Kling.
861 Move StringHaiku.cpp into wtf directory
862 https://bugs.webkit.org/show_bug.cgi?id=50057
864 * platform/text/haiku/StringHaiku.cpp: Removed.
866 2010-12-03 Jessie Berlin <jberlin@apple.com>
868 Reviewed by Sam Weinig.
870 Need a WebKit2 Equivalent of WebSecurityOrigin
871 https://bugs.webkit.org/show_bug.cgi?id=50170
874 Export the symbol for SecurityOrigin::createFromDatabaseIdentifier.
876 2010-12-03 Andras Becsi <abecsi@inf.u-szeged.hu>
878 Unreviewed build fix after r73254.
880 [Qt][V8] Add missing headers to $headerIncludes rather than $implIncludes
881 because headers are needed by the generated .h files.
885 * bindings/scripts/CodeGeneratorV8.pm:
887 2010-12-03 Nikolas Zimmermann <nzimmermann@rim.com>
889 Reviewed by Dirk Schulze.
891 1336 files in WebCore rebuild when you touch SVGNames
892 https://bugs.webkit.org/show_bug.cgi?id=42025
894 Remove global SVGNames.h dependency, as SVGAnimatedPropertyMacros.h included it.
895 This requires to add the SVGNames.h include to lots of cpp files.
897 No functional changes, thus no new tests.
899 * css/CSSCursorImageValue.cpp:
900 * css/CSSFontFaceSource.cpp:
902 * loader/cache/CachedFont.cpp:
903 * rendering/RenderSVGResourceClipper.cpp:
904 * rendering/RenderSVGResourceFilter.cpp:
905 * rendering/RenderSVGTransformableContainer.cpp:
906 * rendering/RenderSVGViewportContainer.cpp:
907 * rendering/SVGRenderTreeAsText.cpp:
908 * rendering/SVGResources.cpp:
909 * rendering/svg/RenderSVGTextPath.cpp:
910 * rendering/svg/SVGRootInlineBox.cpp:
911 * svg/SVGAnimateElement.cpp:
912 * svg/SVGAnimateMotionElement.cpp:
913 * svg/SVGAnimateTransformElement.cpp:
914 * svg/SVGDefsElement.cpp:
915 * svg/SVGFEBlendElement.cpp:
916 * svg/SVGFEDisplacementMapElement.cpp:
917 * svg/SVGFEMergeElement.cpp:
918 * svg/SVGFEMergeNodeElement.cpp:
919 * svg/SVGFEOffsetElement.cpp:
920 * svg/SVGFETileElement.cpp:
921 * svg/SVGFETurbulenceElement.cpp:
923 * svg/SVGGElement.cpp:
924 * svg/SVGImageElement.cpp:
926 * svg/SVGMPathElement.cpp:
927 * svg/SVGPathElement.cpp:
928 * svg/SVGPathSegList.cpp:
929 * svg/SVGStyledTransformableElement.cpp:
930 * svg/SVGSymbolElement.cpp:
931 * svg/SVGTextContentElement.cpp:
932 * svg/SVGTextElement.cpp:
933 * svg/SVGTextPathElement.cpp:
934 * svg/SVGUseElement.cpp:
935 * svg/SVGViewSpec.cpp:
936 * svg/animation/SMILTimeContainer.cpp:
937 * svg/properties/SVGAnimatedPropertyMacros.h:
938 * svg/properties/SVGPathSegListPropertyTearOff.cpp:
940 2010-12-02 Philippe Normand <pnormand@igalia.com>
942 Reviewed by Martin Robinson.
944 [GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED
945 https://bugs.webkit.org/show_bug.cgi?id=50382
947 Go to PAUSED even if preload is deactivated. In that case don't
948 process the GStreamer state changes until commitLoad() has been
949 called. This patch also fixes hasVideo and hasAudio methods,
950 making them reactive to the playbin2 audio/video tags-changed
953 Test: media/controls-without-preload.html
955 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
956 (WebCore::mediaPlayerPrivateMessageCallback):
957 (WebCore::mediaPlayerPrivateVideoTagsChangedCallback):
958 (WebCore::mediaPlayerPrivateAudioTagsChangedCallback):
959 (WebCore::mediaPlayerPrivateAudioTagsChangeTimeoutCallback):
960 (WebCore::mediaPlayerPrivateVideoTagsChangeTimeoutCallback):
961 (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
962 (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
963 (WebCore::MediaPlayerPrivateGStreamer::load):
964 (WebCore::MediaPlayerPrivateGStreamer::commitLoad):
965 (WebCore::MediaPlayerPrivateGStreamer::videoTagsChanged):
966 (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideoTags):
967 (WebCore::MediaPlayerPrivateGStreamer::audioTagsChanged):
968 (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudioTags):
969 (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
970 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
971 (WebCore::MediaPlayerPrivateGStreamer::hasVideo):
972 (WebCore::MediaPlayerPrivateGStreamer::hasAudio):
973 (WebCore::MediaPlayerPrivateGStreamer::loadDelayed):
975 2010-12-03 Nikolas Zimmermann <nzimmermann@rim.com>
977 Reviewed by Dirk Schulze.
979 Finish splitting DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for the remaining SVGAnimated* types
980 https://bugs.webkit.org/show_bug.cgi?id=50440
982 Continuing the work on bug 42025: Introduce (DECLARE|DEFINE)_ANIMATED_(ANGLE|BOOLEAN|INTEGER|PRESERVEASPECTRATIO|RECT).
983 The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.
985 No functional changes, thus no new tests.
987 * svg/SVGAElement.cpp:
989 * svg/SVGAnimatedAngle.h:
990 * svg/SVGAnimatedBoolean.h:
991 * svg/SVGAnimatedInteger.h:
992 * svg/SVGAnimatedPreserveAspectRatio.h:
993 * svg/SVGAnimatedRect.h:
994 * svg/SVGAnimationElement.cpp:
995 * svg/SVGAnimationElement.h:
996 (WebCore::SVGAnimationElement::calculateDistance):
997 (WebCore::SVGAnimationElement::animationPath):
998 * svg/SVGCircleElement.cpp:
999 * svg/SVGCircleElement.h:
1000 * svg/SVGClipPathElement.cpp:
1001 * svg/SVGClipPathElement.h:
1002 * svg/SVGCursorElement.cpp:
1003 * svg/SVGCursorElement.h:
1004 * svg/SVGDefsElement.cpp:
1005 * svg/SVGDefsElement.h:
1006 * svg/SVGEllipseElement.cpp:
1007 * svg/SVGEllipseElement.h:
1008 * svg/SVGFEConvolveMatrixElement.cpp:
1009 * svg/SVGFEConvolveMatrixElement.h:
1010 * svg/SVGFEImageElement.cpp:
1011 * svg/SVGFEImageElement.h:
1012 * svg/SVGFETurbulenceElement.cpp:
1013 * svg/SVGFETurbulenceElement.h:
1014 * svg/SVGFilterElement.cpp:
1015 * svg/SVGFilterElement.h:
1016 * svg/SVGFilterPrimitiveStandardAttributes.h:
1017 * svg/SVGFontElement.cpp:
1018 (WebCore::SVGFontElement::firstMissingGlyphElement):
1019 (WebCore::SVGFontElement::ensureGlyphCache):
1020 * svg/SVGFontElement.h:
1021 * svg/SVGForeignObjectElement.cpp:
1022 * svg/SVGForeignObjectElement.h:
1023 * svg/SVGGElement.cpp:
1024 * svg/SVGGElement.h:
1025 (WebCore::SVGGElement::isShadowTreeContainerElement):
1026 (WebCore::SVGGElement::isValid):
1027 * svg/SVGGradientElement.cpp:
1028 * svg/SVGGradientElement.h:
1029 * svg/SVGImageElement.cpp:
1030 * svg/SVGImageElement.h:
1031 * svg/SVGLineElement.cpp:
1032 * svg/SVGLineElement.h:
1033 * svg/SVGLinearGradientElement.h:
1034 * svg/SVGMPathElement.cpp:
1035 * svg/SVGMPathElement.h:
1036 * svg/SVGMarkerElement.cpp:
1037 * svg/SVGMarkerElement.h:
1038 * svg/SVGMaskElement.cpp:
1039 * svg/SVGMaskElement.h:
1040 * svg/SVGPathElement.cpp:
1041 * svg/SVGPathElement.h:
1042 * svg/SVGPatternElement.cpp:
1043 * svg/SVGPatternElement.h:
1044 * svg/SVGPolyElement.cpp:
1045 * svg/SVGPolyElement.h:
1046 * svg/SVGRadialGradientElement.h:
1047 * svg/SVGRectElement.cpp:
1048 * svg/SVGRectElement.h:
1049 * svg/SVGSVGElement.cpp:
1050 (WebCore::SVGSVGElement::contentScriptType):
1051 (WebCore::SVGSVGElement::contentStyleType):
1052 (WebCore::SVGSVGElement::parseMappedAttribute):
1053 * svg/SVGSVGElement.h:
1054 * svg/SVGScriptElement.cpp:
1055 * svg/SVGScriptElement.h:
1056 * svg/SVGSwitchElement.cpp:
1057 * svg/SVGSwitchElement.h:
1058 (WebCore::SVGSwitchElement::isValid):
1059 * svg/SVGSymbolElement.cpp:
1060 * svg/SVGSymbolElement.h:
1061 (WebCore::SVGSymbolElement::rendererIsNeeded):
1062 * svg/SVGTextContentElement.cpp:
1063 * svg/SVGTextContentElement.h:
1064 * svg/SVGUseElement.cpp:
1065 * svg/SVGUseElement.h:
1066 * svg/SVGViewElement.cpp:
1067 * svg/SVGViewElement.h:
1068 (WebCore::SVGViewElement::viewTarget):
1069 (WebCore::SVGViewElement::rendererIsNeeded):
1070 * svg/SVGViewSpec.cpp:
1071 * svg/SVGViewSpec.h:
1072 (WebCore::SVGViewSpec::transform):
1073 (WebCore::SVGViewSpec::viewTargetString):
1074 (WebCore::SVGViewSpec::contextElement):
1075 * svg/properties/SVGAnimatedPropertyMacros.h:
1077 2010-12-03 Noel Gordon <noel.gordon@gmail.com>
1079 Reviewed by Darin Fisher.
1081 [chromium] PNG encoder leaks memory on png_write_row errors.
1082 https://bugs.webkit.org/show_bug.cgi?id=50439
1084 Move the creation of needed C++ objects before the setjmp() point so
1085 those objects have their destructors called if libpng errors invoke
1086 the setjmp() return path.
1088 Other minor cleanup: use the skia bitmap locker class, and remove the
1089 PNGDestroyer class - instead directly call png_destroy_write_struct()
1090 at each of the encodeImpl() return points.
1092 No change in behaviour, so no new tests.
1094 * platform/image-encoders/skia/PNGImageEncoder.cpp:
1095 (WebCore::encodeImpl):
1096 (WebCore::PNGImageEncoder::encode):
1098 2010-12-02 Philippe Normand <pnormand@igalia.com>
1100 Reviewed by Eric Carlson.
1102 Theme not updated when MediaPlayer m_private engine changes
1103 https://bugs.webkit.org/show_bug.cgi?id=50228
1105 Trigger a new rendering of the media element when the private
1106 media-player backend is updated.
1108 * html/HTMLMediaElement.cpp:
1109 (WebCore::HTMLMediaElement::mediaPlayerEngineUpdated):
1110 * html/HTMLMediaElement.h:
1111 * platform/graphics/MediaPlayer.cpp:
1112 (WebCore::MediaPlayer::MediaPlayer):
1113 (WebCore::MediaPlayer::load):
1114 * platform/graphics/MediaPlayer.h:
1115 (WebCore::MediaPlayerClient::mediaPlayerEngineUpdated):
1117 2010-12-03 Yonathan Randolph <yonathan@gmail.com>
1119 Reviewed by Alexey Proskuryakov.
1121 XPath lexer misinterprets expression starting with "div".
1122 https://bugs.webkit.org/show_bug.cgi?id=50366
1124 * xml/XPathParser.cpp:
1125 * xml/XPathParser.h:
1126 (WebCore::XPath::Parser::isOperatorContext): removed (renamed)
1127 (WebCore::XPath::Parser::isBinaryOperatorContext): added
1129 2010-12-02 Rob Buis <rwlbuis@gmail.com>
1131 Reviewed by Alexey Proskuryakov.
1133 CSS 2.1 failure: at-import-*
1134 https://bugs.webkit.org/show_bug.cgi?id=47153
1136 Fix at-import-010.htm by only setting m_allowImportRules
1137 to false when creating valid style or page rules.
1139 Test: css2.1/t040105-import-10-b.html
1141 * css/CSSParser.cpp:
1142 (WebCore::CSSParser::createStyleRule):
1144 2010-12-02 Aaron Boodman <aa@chromium.org>
1146 Reviewed by David Hyatt.
1148 Reduce the number of cases where we end up with a stale value for
1149 minimumPreferredLogicalWidth(). This isn't a complete fix, but fixes a
1150 large number of cases.
1152 RenderObject::minimumPreferredLogicalWidth() sometimes reports wrong value.
1153 https://bugs.webkit.org/show_bug.cgi?id=50119
1155 * rendering/RenderBox.cpp:
1156 (WebCore::RenderBox::styleDidChange):
1158 2010-12-02 Gregg Tavares <gman@google.com>
1160 Reviewed by David Levin.
1162 Need to initialize destination variables before calling GL
1163 https://bugs.webkit.org/show_bug.cgi?id=50048
1165 No new tests because no change in functionality.
1167 * html/canvas/WebGLFramebuffer.cpp:
1168 (WebCore::WebGLFramebuffer::initializeRenderbuffers):
1169 * html/canvas/WebGLProgram.cpp:
1170 (WebCore::WebGLProgram::cacheActiveAttribLocations):
1171 * html/canvas/WebGLRenderingContext.cpp:
1172 (WebCore::WebGLRenderingContext::getAttachedShaders):
1173 (WebCore::WebGLRenderingContext::getBufferParameter):
1174 (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
1175 (WebCore::WebGLRenderingContext::getBooleanParameter):
1176 (WebCore::WebGLRenderingContext::getFloatParameter):
1177 (WebCore::WebGLRenderingContext::getLongParameter):
1178 (WebCore::WebGLRenderingContext::getUnsignedLongParameter):
1179 * platform/graphics/chromium/LayerChromium.cpp:
1180 (WebCore::loadShader):
1181 (WebCore::LayerChromium::createShaderProgram):
1182 * platform/graphics/chromium/LayerRendererChromium.cpp:
1183 (WebCore::LayerRendererChromium::initializeSharedObjects):
1184 * platform/graphics/gpu/DrawingBuffer.cpp:
1185 (WebCore::DrawingBuffer::reset):
1186 * platform/graphics/gpu/Shader.cpp:
1187 (WebCore::Shader::loadProgram):
1189 2010-12-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1191 Reviewed by Andreas Kling.
1193 [Qt] Enable Web Timing for Qt
1194 https://bugs.webkit.org/show_bug.cgi?id=42433
1196 * features.pri: Enable Web Timing for trunk (but not yet for
1199 2010-12-02 Andy Estes <aestes@apple.com>
1201 Rubber-stamped by Mark Rowe.
1203 Update bindings test results with new GObject results.
1205 * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
1207 * bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
1208 * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
1210 * bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
1211 * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
1213 * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
1214 * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
1216 (webkit_dom_test_obj_obj_method):
1217 (webkit_dom_test_obj_obj_method_with_args):
1218 (webkit_dom_test_obj_method_that_requires_all_args):
1219 (webkit_dom_test_obj_method_that_requires_all_args_and_throws):
1220 (webkit_dom_test_obj_with_script_state_obj):
1221 (webkit_dom_test_obj_with_script_state_obj_exception):
1222 (webkit_dom_test_obj_get_read_only_test_obj_attr):
1223 (webkit_dom_test_obj_get_test_obj_attr):
1224 (webkit_dom_test_obj_get_xml_obj_attr):
1225 * bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
1227 2010-12-02 Simon Fraser <simon.fraser@apple.com>
1229 Revert r73217 and r73227 because of continued bustage.
1231 * WebCore.xcodeproj/project.pbxproj:
1232 * platform/graphics/GraphicsLayer.h:
1233 (WebCore::GraphicsLayer::nativeLayer):
1234 * platform/graphics/ca/PlatformCAAnimation.h: Removed.
1235 * platform/graphics/ca/PlatformCALayer.h: Removed.
1236 * platform/graphics/ca/mac/PlatformCAAnimationMac.mm: Removed.
1237 * platform/graphics/ca/mac/PlatformCALayerMac.mm: Removed.
1238 * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1239 (WebCore::GraphicsLayerChromium::nativeLayer):
1240 * platform/graphics/chromium/GraphicsLayerChromium.h:
1241 * platform/graphics/mac/GraphicsLayerMac.h: Renamed from WebCore/platform/graphics/ca/GraphicsLayerCA.h.
1242 (WebCore::GraphicsLayerMac::hasContentsLayer):
1243 (WebCore::GraphicsLayerMac::primaryLayer):
1244 (WebCore::GraphicsLayerMac::isReplicatedRootClone):
1245 (WebCore::GraphicsLayerMac::primaryLayerClones):
1246 (WebCore::GraphicsLayerMac::animationIsRunning):
1247 (WebCore::GraphicsLayerMac::contentsLayer):
1248 (WebCore::GraphicsLayerMac::ReplicaState::ReplicaState):
1249 (WebCore::GraphicsLayerMac::ReplicaState::push):
1250 (WebCore::GraphicsLayerMac::ReplicaState::setBranchType):
1251 (WebCore::GraphicsLayerMac::ReplicaState::pop):
1252 (WebCore::GraphicsLayerMac::ReplicaState::depth):
1253 (WebCore::GraphicsLayerMac::ReplicaState::replicaDepth):
1254 (WebCore::GraphicsLayerMac::hasCloneLayers):
1255 (WebCore::GraphicsLayerMac::LayerPropertyAnimation::LayerPropertyAnimation):
1256 (WebCore::GraphicsLayerMac::AnimationProcessingAction::AnimationProcessingAction):
1257 * platform/graphics/mac/GraphicsLayerMac.mm: Renamed from WebCore/platform/graphics/ca/GraphicsLayerCA.cpp.
1258 (WebCore::currentTimeToMediaTime):
1259 (WebCore::mediaTimeToCurrentTime):
1260 (-[WebAnimationDelegate animationDidStart:]):
1261 (-[WebAnimationDelegate WebCore::]):
1262 (-[WebAnimationDelegate setLayer:WebCore::]):
1263 (WebCore::copyTransform):
1264 (WebCore::getTransformFunctionValue):
1265 (WebCore::getValueFunctionNameForTransformOperation):
1266 (WebCore::propertyIdToString):
1267 (WebCore::animationIdentifier):
1268 (WebCore::getCAMediaTimingFunction):
1269 (WebCore::setLayerBorderColor):
1270 (WebCore::clearBorderColor):
1271 (WebCore::setLayerBackgroundColor):
1272 (WebCore::clearLayerBackgroundColor):
1273 (WebCore::safeSetSublayers):
1274 (WebCore::caValueFunctionSupported):
1275 (WebCore::forceSoftwareAnimation):
1276 (WebCore::nullActionsDictionary):
1277 (WebCore::animationHasStepsTimingFunction):
1278 (WebCore::GraphicsLayer::create):
1279 (WebCore::GraphicsLayerMac::GraphicsLayerMac):
1280 (WebCore::GraphicsLayerMac::~GraphicsLayerMac):
1281 (WebCore::GraphicsLayerMac::setName):
1282 (WebCore::GraphicsLayerMac::nativeLayer):
1283 (WebCore::GraphicsLayerMac::setChildren):
1284 (WebCore::GraphicsLayerMac::addChild):
1285 (WebCore::GraphicsLayerMac::addChildAtIndex):
1286 (WebCore::GraphicsLayerMac::addChildBelow):
1287 (WebCore::GraphicsLayerMac::addChildAbove):
1288 (WebCore::GraphicsLayerMac::replaceChild):
1289 (WebCore::GraphicsLayerMac::removeFromParent):
1290 (WebCore::GraphicsLayerMac::setMaskLayer):
1291 (WebCore::GraphicsLayerMac::setReplicatedLayer):
1292 (WebCore::GraphicsLayerMac::setReplicatedByLayer):
1293 (WebCore::GraphicsLayerMac::setPosition):
1294 (WebCore::GraphicsLayerMac::setAnchorPoint):
1295 (WebCore::GraphicsLayerMac::setSize):
1296 (WebCore::GraphicsLayerMac::setTransform):
1297 (WebCore::GraphicsLayerMac::setChildrenTransform):
1298 (WebCore::GraphicsLayerMac::moveOrCopyLayerAnimation):
1299 (WebCore::GraphicsLayerMac::moveOrCopyAnimationsForProperty):
1300 (WebCore::GraphicsLayerMac::setPreserves3D):
1301 (WebCore::GraphicsLayerMac::setMasksToBounds):
1302 (WebCore::GraphicsLayerMac::setDrawsContent):
1303 (WebCore::GraphicsLayerMac::setBackgroundColor):
1304 (WebCore::GraphicsLayerMac::clearBackgroundColor):
1305 (WebCore::GraphicsLayerMac::setContentsOpaque):
1306 (WebCore::GraphicsLayerMac::setBackfaceVisibility):
1307 (WebCore::GraphicsLayerMac::setOpacity):
1308 (WebCore::GraphicsLayerMac::setNeedsDisplay):
1309 (WebCore::GraphicsLayerMac::setNeedsDisplayInRect):
1310 (WebCore::GraphicsLayerMac::setContentsNeedsDisplay):
1311 (WebCore::GraphicsLayerMac::setContentsRect):
1312 (WebCore::GraphicsLayerMac::addAnimation):
1313 (WebCore::GraphicsLayerMac::pauseAnimation):
1314 (WebCore::GraphicsLayerMac::removeAnimation):
1315 (WebCore::GraphicsLayerMac::animationDidStart):
1316 (WebCore::GraphicsLayerMac::setContentsToImage):
1317 (WebCore::GraphicsLayerMac::setContentsToMedia):
1318 (WebCore::GraphicsLayerMac::didDisplay):
1319 (WebCore::GraphicsLayerMac::syncCompositingState):
1320 (WebCore::GraphicsLayerMac::syncCompositingStateForThisLayerOnly):
1321 (WebCore::GraphicsLayerMac::recursiveCommitChanges):
1322 (WebCore::GraphicsLayerMac::commitLayerChangesBeforeSublayers):
1323 (WebCore::GraphicsLayerMac::commitLayerChangesAfterSublayers):
1324 (WebCore::GraphicsLayerMac::updateLayerNames):
1325 (WebCore::GraphicsLayerMac::updateSublayerList):
1326 (WebCore::GraphicsLayerMac::updateLayerPosition):
1327 (WebCore::GraphicsLayerMac::updateLayerSize):
1328 (WebCore::GraphicsLayerMac::updateAnchorPoint):
1329 (WebCore::GraphicsLayerMac::updateTransform):
1330 (WebCore::GraphicsLayerMac::updateChildrenTransform):
1331 (WebCore::GraphicsLayerMac::updateMasksToBounds):
1332 (WebCore::GraphicsLayerMac::updateContentsOpaque):
1333 (WebCore::GraphicsLayerMac::updateBackfaceVisibility):
1334 (WebCore::GraphicsLayerMac::updateStructuralLayer):
1335 (WebCore::GraphicsLayerMac::ensureStructuralLayer):
1336 (WebCore::GraphicsLayerMac::structuralLayerPurpose):
1337 (WebCore::GraphicsLayerMac::updateLayerDrawsContent):
1338 (WebCore::GraphicsLayerMac::updateLayerBackgroundColor):
1339 (WebCore::GraphicsLayerMac::updateContentsImage):
1340 (WebCore::GraphicsLayerMac::updateContentsMediaLayer):
1341 (WebCore::GraphicsLayerMac::updateContentsCanvasLayer):
1342 (WebCore::GraphicsLayerMac::updateContentsRect):
1343 (WebCore::GraphicsLayerMac::updateMaskLayer):
1344 (WebCore::GraphicsLayerMac::updateReplicatedLayers):
1345 (WebCore::GraphicsLayerMac::ReplicaState::cloneID):
1346 (WebCore::GraphicsLayerMac::replicatedLayerRoot):
1347 (WebCore::GraphicsLayerMac::updateLayerAnimations):
1348 (WebCore::GraphicsLayerMac::setCAAnimationOnLayer):
1349 (WebCore::bug7311367Workaround):
1350 (WebCore::GraphicsLayerMac::removeCAAnimationFromLayer):
1351 (WebCore::copyAnimationProperties):
1352 (WebCore::GraphicsLayerMac::pauseCAAnimationOnLayer):
1353 (WebCore::GraphicsLayerMac::setContentsToCanvas):
1354 (WebCore::GraphicsLayerMac::repaintLayerDirtyRects):
1355 (WebCore::GraphicsLayerMac::updateContentsNeedsDisplay):
1356 (WebCore::GraphicsLayerMac::createAnimationFromKeyframes):
1357 (WebCore::GraphicsLayerMac::createTransformAnimationsFromKeyframes):
1358 (WebCore::GraphicsLayerMac::createBasicAnimation):
1359 (WebCore::GraphicsLayerMac::createKeyframeAnimation):
1360 (WebCore::GraphicsLayerMac::setupAnimation):
1361 (WebCore::GraphicsLayerMac::timingFunctionForAnimationValue):
1362 (WebCore::GraphicsLayerMac::setAnimationEndpoints):
1363 (WebCore::GraphicsLayerMac::setAnimationKeyframes):
1364 (WebCore::GraphicsLayerMac::setTransformAnimationEndpoints):
1365 (WebCore::GraphicsLayerMac::setTransformAnimationKeyframes):
1366 (WebCore::GraphicsLayerMac::suspendAnimations):
1367 (WebCore::GraphicsLayerMac::resumeAnimations):
1368 (WebCore::GraphicsLayerMac::hostLayerForSublayers):
1369 (WebCore::GraphicsLayerMac::layerForSuperlayer):
1370 (WebCore::GraphicsLayerMac::animatedLayer):
1371 (WebCore::GraphicsLayerMac::animatedLayerClones):
1372 (WebCore::GraphicsLayerMac::platformLayer):
1373 (WebCore::GraphicsLayerMac::setDebugBackgroundColor):
1374 (WebCore::GraphicsLayerMac::setDebugBorder):
1375 (WebCore::GraphicsLayerMac::constrainedSize):
1376 (WebCore::GraphicsLayerMac::requiresTiledLayer):
1377 (WebCore::GraphicsLayerMac::swapFromOrToTiledLayer):
1378 (WebCore::GraphicsLayerMac::defaultContentsOrientation):
1379 (WebCore::GraphicsLayerMac::updateContentsTransform):
1380 (WebCore::GraphicsLayerMac::setupContentsLayer):
1381 (WebCore::GraphicsLayerMac::findOrMakeClone):
1382 (WebCore::GraphicsLayerMac::ensureCloneLayers):
1383 (WebCore::GraphicsLayerMac::removeCloneLayers):
1384 (WebCore::GraphicsLayerMac::positionForCloneRootLayer):
1385 (WebCore::GraphicsLayerMac::propagateLayerChangeToReplicas):
1386 (WebCore::GraphicsLayerMac::fetchCloneLayers):
1387 (WebCore::GraphicsLayerMac::cloneLayer):
1388 (WebCore::GraphicsLayerMac::setOpacityInternal):
1389 (WebCore::GraphicsLayerMac::updateOpacityOnLayer):
1390 (WebCore::GraphicsLayerMac::noteSublayersChanged):
1391 (WebCore::GraphicsLayerMac::noteLayerPropertyChanged):
1392 * platform/graphics/mac/WebLayer.h:
1393 * platform/graphics/mac/WebLayer.mm:
1394 (-[WebLayer initWithLayer:]):
1395 (-[WebLayer setNeedsDisplay]):
1396 (-[WebLayer setNeedsDisplayInRect:]):
1397 (-[WebLayer display]):
1398 (-[WebLayer drawInContext:]):
1399 (-[WebLayer setLayerOwner:]):
1400 (-[WebLayer layerOwner]):
1401 * platform/graphics/mac/WebTiledLayer.h:
1402 * platform/graphics/mac/WebTiledLayer.mm:
1403 (-[WebTiledLayer initWithLayer:]):
1404 (-[WebTiledLayer setNeedsDisplay]):
1405 (-[WebTiledLayer setNeedsDisplayInRect:]):
1406 (-[WebTiledLayer display]):
1407 (-[WebTiledLayer drawInContext:]):
1408 (-[WebTiledLayer setLayerOwner:]):
1409 (-[WebTiledLayer layerOwner]):
1410 * platform/graphics/qt/GraphicsLayerQt.cpp:
1411 (WebCore::GraphicsLayerQtImpl::flushChanges):
1412 (WebCore::GraphicsLayerQt::nativeLayer):
1413 * platform/graphics/qt/GraphicsLayerQt.h:
1414 * platform/graphics/win/GraphicsLayerCACF.cpp:
1415 (WebCore::GraphicsLayerCACF::nativeLayer):
1416 * platform/graphics/win/GraphicsLayerCACF.h:
1418 2010-12-02 Noel Gordon <noel.gordon@gmail.com>
1420 Reviewed by David Levin.
1421 [chromium] Remove dead code from PNG encoder
1422 https://bugs.webkit.org/show_bug.cgi?id=50377
1424 Also webkit style the PNG encoder files.
1426 No change in behaviour, so no new tests.
1428 * platform/image-encoders/skia/PNGImageEncoder.cpp:
1429 (WebCore::encodeImpl):
1430 (WebCore::PNGImageEncoder::encode):
1431 * platform/image-encoders/skia/PNGImageEncoder.h:
1433 2010-12-02 Yuta Kitamura <yutak@chromium.org>
1435 Reviewed by Alexey Proskuryakov.
1437 An attempt to fix Chromium's clang build.
1439 Implement (non-EventListener) marquee IDL attributes from HTML5.
1440 https://bugs.webkit.org/show_bug.cgi?id=49786
1442 * rendering/style/RenderStyle.h:
1443 (WebCore::InheritedFlags::initialMarqueeSpeed):
1445 2010-12-02 Mikhail Naganov <mnaganov@chromium.org>
1447 Reviewed by Pavel Feldman.
1449 Web Inspector: Fix heap snapshots loading. Loading is now
1450 conducted by the Profiles panel which prevents accidental
1451 simultaneous attempts to load the same profile several times in
1454 https://bugs.webkit.org/show_bug.cgi?id=50427
1456 * inspector/front-end/HeapSnapshotView.js:
1457 (WebInspector.HeapSnapshotView.prototype._loadProfile):
1458 (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
1459 * inspector/front-end/ProfilesPanel.js:
1460 (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
1461 (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk):
1462 (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):
1464 2010-12-02 Chris Marrin <cmarrin@apple.com>
1466 Reviewed by Simon Fraser.
1468 Fix Leopard build broken by http://trac.webkit.org/changeset/73217
1470 * platform/graphics/ca/GraphicsLayerCA.cpp:
1471 (WebCore::getTransformFunctionValue):
1472 (WebCore::GraphicsLayerCA::updateContentsTransform):
1473 * platform/graphics/ca/PlatformCALayer.h:
1474 * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
1475 (PlatformCAAnimation::valueFunction):
1476 (PlatformCAAnimation::setValueFunction):
1477 * platform/graphics/ca/mac/PlatformCALayerMac.mm:
1478 (PlatformCALayer::PlatformCALayer):
1479 (PlatformCALayer::anchorPoint):
1480 (PlatformCALayer::setAnchorPoint):
1481 (PlatformCALayer::contentsTransform):
1482 (PlatformCALayer::setContentsTransform):
1483 (PlatformCALayer::isGeometryFlipped):
1484 (PlatformCALayer::setGeometryFlipped):
1485 (PlatformCALayer::setMinificationFilter):
1486 (PlatformCALayer::setMagnificationFilter):
1488 2010-12-02 Dan Bernstein <mitz@apple.com>
1490 Reviewed by Dave Hyatt.
1492 CSS support for the text-emphasis properties
1493 Part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
1494 https://bugs.webkit.org/show_bug.cgi?id=48539
1496 Test: fast/css/parsing-text-emphasis.html
1498 * css/CSSComputedStyleDeclaration.cpp:
1499 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added text-emphasis-color,
1500 text-emphasis-position and text-emphasis-style. Left the text-emphasis shorthand unsupported.
1501 * css/CSSParser.cpp:
1502 (WebCore::CSSParser::parseValue): Parse the properties.
1503 (WebCore::CSSParser::parseTextEmphasisStyle): Added.
1505 * css/CSSPrimitiveValueMappings.h:
1506 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added TextEmphasisPosition, TextEmphasisFill
1507 and TextEmphasisMark mappings.
1508 (WebCore::CSSPrimitiveValue::operator TextEmphasisPosition): Added.
1509 (WebCore::CSSPrimitiveValue::operator TextEmphasisFill): Added.
1510 (WebCore::CSSPrimitiveValue::operator TextEmphasisMark): Added.
1511 * css/CSSPropertyLonghand.cpp:
1512 (WebCore::initShorthandMap): Added the text-emphasis shorthand.
1513 * css/CSSPropertyNames.in: Added -webkit-text-emphasis, -webkit-text-emphasis-color,
1514 -webkit-text-emphasis-position, and -webkit-text-emphasis-style.
1515 * css/CSSStyleSelector.cpp:
1516 (WebCore::isValidVisitedLinkProperty): Added text-emphasis-color.
1517 (WebCore::CSSStyleSelector::applyProperty): Handle the properties.
1518 * css/CSSValueKeywords.in: Added 'over' and 'under' for text-emphasis-position. Added 'dot',
1519 'double-circle', 'triangle', 'sesame', 'filled' and 'open' for text-emphasis-style.
1520 * rendering/style/RenderStyle.cpp:
1521 (WebCore::RenderStyle::colorIncludingFallback): Handle text-emphasis-color.
1522 (WebCore::RenderStyle::textEmphasisMark): Added. Maps the fake 'auto' value to 'dot' or
1523 'sesame' based on writing direction.
1524 * rendering/style/RenderStyle.h: Added accessors.
1525 (WebCore::InheritedFlags::textEmphasisFill):
1526 (WebCore::InheritedFlags::textEmphasisCustomMark):
1527 (WebCore::InheritedFlags::textEmphasisPosition):
1528 (WebCore::InheritedFlags::setTextEmphasisColor):
1529 (WebCore::InheritedFlags::setTextEmphasisFill):
1530 (WebCore::InheritedFlags::setTextEmphasisMark):
1531 (WebCore::InheritedFlags::setTextEmphasisCustomMark):
1532 (WebCore::InheritedFlags::setTextEmphasisPosition):
1533 (WebCore::InheritedFlags::initialTextEmphasisColor):
1534 (WebCore::InheritedFlags::initialTextEmphasisFill):
1535 (WebCore::InheritedFlags::initialTextEmphasisMark):
1536 (WebCore::InheritedFlags::initialTextEmphasisCustomMark):
1537 (WebCore::InheritedFlags::initialTextEmphasisPosition):
1538 (WebCore::InheritedFlags::textEmphasisColor):
1539 * rendering/style/RenderStyleConstants.h:
1540 * rendering/style/StyleRareInheritedData.cpp:
1541 (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1542 (WebCore::StyleRareInheritedData::operator==):
1543 * rendering/style/StyleRareInheritedData.h:
1545 2010-12-02 Chris Marrin <cmarrin@apple.com>
1547 Reviewed by Simon Fraser.
1549 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
1550 https://bugs.webkit.org/show_bug.cgi?id=49388
1552 Replaced GraphicsLayerMac with GraphicsLayerCA. GraphicsLayerCA is essentially
1553 identical to GraphicsLayerMac, but replaces all the CoreAnimation specific calls
1554 with calls to PlatformCALayer and PlatformCAAnimation. This makes GraphicsLayerCA
1555 platform neutral as long as implementations of those two classes are available.
1556 Added implementations in PlatformCALayerMac and PlatformCAAnimationMac. Also got
1557 rid of GraphicsLayer::nativeLayer() and replaced it with GraphicsLayer::platformLayer()
1558 to avoid confusion since both names were used to refer to the same thing.
1560 This patch is only for Mac. Windows implementation has not changed.
1562 * WebCore.xcodeproj/project.pbxproj:
1563 * platform/graphics/GraphicsLayer.h:
1564 * platform/graphics/ca: Added.
1565 * platform/graphics/ca/GraphicsLayerCA.cpp: Added.
1566 * platform/graphics/ca/GraphicsLayerCA.h: Added.
1567 * platform/graphics/ca/PlatformCAAnimation.h: Added.
1568 * platform/graphics/ca/PlatformCALayer.h: Added.
1569 * platform/graphics/ca/mac: Added.
1570 * platform/graphics/ca/mac/PlatformCAAnimationMac.mm: Added.
1571 * platform/graphics/ca/mac/PlatformCALayerMac.mm: Added.
1572 * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1573 * platform/graphics/chromium/GraphicsLayerChromium.h:
1574 * platform/graphics/mac/GraphicsLayerMac.h: Removed.
1575 * platform/graphics/mac/GraphicsLayerMac.mm: Removed.
1576 * platform/graphics/mac/WebLayer.h:
1577 * platform/graphics/mac/WebLayer.mm:
1578 * platform/graphics/mac/WebTiledLayer.h:
1579 * platform/graphics/mac/WebTiledLayer.mm:
1580 * platform/graphics/qt/GraphicsLayerQt.cpp:
1581 * platform/graphics/qt/GraphicsLayerQt.h:
1582 * platform/graphics/win/GraphicsLayerCACF.cpp:
1583 * platform/graphics/win/GraphicsLayerCACF.h:
1585 2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
1587 Reviewed by Darin Adler.
1589 Update ResourceLoaderSet Enumeration
1590 https://bugs.webkit.org/show_bug.cgi?id=50405
1592 Use size_t when working with Vectors and when comparing between size_t types.
1594 * loader/DocumentLoader.cpp:
1595 (WebCore::cancelAll):
1596 (WebCore::setAllDefersLoading):
1598 2010-12-02 Jian Li <jianli@chromium.org>
1600 Reviewed by Kenneth Russell.
1602 Integer calculation issues in DataView constructor
1603 https://bugs.webkit.org/show_bug.cgi?id=50354
1605 Test: fast/canvas/webgl/data-view-crash.html
1607 * html/canvas/DataView.cpp:
1608 (WebCore::DataView::create):
1610 2010-12-02 Patrick Gansterer <paroga@webkit.org>
1612 Reviewed by Darin Adler.
1614 Add AtomicString::fromUTF8
1615 https://bugs.webkit.org/show_bug.cgi?id=45594
1617 Use AtomicString::fromUTF8 directly in the libxml2 parser.
1619 * dom/XMLDocumentParserLibxml2.cpp:
1620 (WebCore::toAtomicString):
1622 2010-12-02 Andy Estes <aestes@apple.com>
1624 Fix the Qt Linux Release minimal build.
1626 * html/HTMLMarqueeElement.cpp: Include ExceptionCode.h
1628 2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
1630 Reviewed by Darin Adler.
1632 Update ResourceLoaderSet Enumeration
1633 https://bugs.webkit.org/show_bug.cgi?id=50405
1635 * loader/DocumentLoader.cpp:
1636 (WebCore::cancelAll): instead of copying the HashSet, use copyToVector.
1637 (WebCore::setAllDefersLoading): instead of copying the HashSet, use copyToVector.
1639 2010-12-02 Andy Estes <aestes@apple.com>
1641 Reviewed by Darin Adler.
1643 Implement (non-EventListener) marquee IDL attributes from HTML5.
1644 https://bugs.webkit.org/show_bug.cgi?id=49786
1646 Test: fast/html/marquee-element.html
1648 * html/HTMLMarqueeElement.cpp:
1649 (WebCore::HTMLMarqueeElement::scrollAmount): If the content attribute
1650 can be converted to a signed integer and is >= 0, return it.
1651 Otherwise, return the default scrollAmount value.
1652 (WebCore::HTMLMarqueeElement::setScrollAmount): Update the content
1653 attribute if it is >= 0. Otherwise, raise INDEX_SIZE_ERR.
1654 (WebCore::HTMLMarqueeElement::scrollDelay): Same as scrollAmount.
1655 (WebCore::HTMLMarqueeElement::setScrollDelay): Same as setScrollAmount.
1656 (WebCore::HTMLMarqueeElement::loop): If the content attribute can be
1657 converted to a signed integer and is greater than 0 or equal to -1,
1658 return it. Otherwise, return the default loop value.
1659 (WebCore::HTMLMarqueeElement::setLoop): Update the content attribute if
1660 it is greater than 0 or equal to -1. Otherwise, raise INDEX_SIZE_ERR.
1661 * html/HTMLMarqueeElement.h:
1662 * html/HTMLMarqueeElement.idl: Update the IDL to match what is in HTML5.
1663 * rendering/style/RenderStyle.h:
1664 (WebCore::InheritedFlags::initialMarqueeSpeed):
1666 2010-12-02 Patrick Gansterer <paroga@webkit.org>
1668 Reviewed by Andreas Kling.
1670 [OpenVG] Remove "current path" of GraphicsContext
1671 https://bugs.webkit.org/show_bug.cgi?id=50294
1673 * platform/graphics/GraphicsContext.h:
1674 * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
1675 (WebCore::GraphicsContext::fillPath):
1676 (WebCore::GraphicsContext::strokePath):
1677 (WebCore::GraphicsContext::clipPath):
1678 * platform/graphics/openvg/PainterOpenVG.cpp:
1679 (WebCore::PainterOpenVG::PainterOpenVG):
1680 (WebCore::PainterOpenVG::~PainterOpenVG):
1681 (WebCore::PainterOpenVG::drawPath):
1682 * platform/graphics/openvg/PainterOpenVG.h:
1684 2010-12-02 Patrick Gansterer <paroga@webkit.org>
1686 Reviewed by Andreas Kling.
1688 [WINCE] Remove "current path" of GraphicsContext
1689 https://bugs.webkit.org/show_bug.cgi?id=50284
1691 * platform/graphics/GraphicsContext.h:
1692 * platform/graphics/wince/GraphicsContextWinCE.cpp:
1693 (WebCore::GraphicsContext::fillPath):
1694 (WebCore::GraphicsContext::strokePath):
1696 2010-12-02 Johnny Ding <jnd@chromium.org>
1698 Reviewed by Adam Barth.
1700 Set the right gesture status for URL redirections.
1701 https://bugs.webkit.org/show_bug.cgi?id=47817
1703 Tests: fast/frames/location-redirect-user-gesture.html
1704 fast/frames/meta-refresh-user-gesture.html
1706 * loader/NavigationScheduler.cpp:
1707 (WebCore::ScheduledNavigation::clearUserGesture):
1708 (WebCore::ScheduledRedirect::ScheduledRedirect):
1710 2010-12-02 Chris Rogers <crogers@google.com>
1712 Reviewed by Kenneth Russell.
1714 AudioContext needs createBuffer() method from ArrayBuffer
1715 https://bugs.webkit.org/show_bug.cgi?id=50343
1717 No new tests since audio API is not yet implemented.
1719 * webaudio/AudioContext.cpp:
1720 (WebCore::AudioContext::createBuffer):
1721 * webaudio/AudioContext.h:
1722 * webaudio/AudioContext.idl:
1724 2010-12-02 Noel Gordon <noel.gordon@gmail.com>
1726 Reviewed by David Levin.
1728 [chromium] Add canvas.toDataURL("image/jpeg", quality) support
1729 https://bugs.webkit.org/show_bug.cgi?id=49365
1731 Adds a libjpeg-based image encoder for Skia bitmaps. Default encoding quality
1732 is 92 to match Mozilla, also Safari, though the actual value used by Safari is
1733 undocumented, and it appears to pre-blur images prior to compression.
1735 The preMultipliedBGRAtoRGB() routine restores the un-premultiplied RGB colors
1736 where there is non-zero alpha. Again, this matches Firefox and Safari, but no
1737 browser conforms to the HTML5 canvas standard here, I believe, considering the
1738 result of canvas/philip/tests/toDataURL.jpeg.alpha.html; that test ignores the
1739 alpha channel when extracting an "image/jpeg".toDataURL(). The correct answer
1740 needs more investigation, bug http://webkit.org/b/40147.
1742 Canvas toDataURL is covered by existing tests canvas/philip/tests/toDataURL.*,
1743 and fast/canvas/*toDataURL* tests.
1746 * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
1747 (WebCore::V8HTMLCanvasElement::toDataURLCallback): don't set encoding quality
1748 here, just pass the toDataURL parameters through to the canvas layer.
1749 * platform/chromium/MIMETypeRegistryChromium.cpp:
1750 (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): implement
1751 the supported mimeTypes for encoding in-place.
1752 * platform/graphics/skia/ImageBufferSkia.cpp:
1753 (WebCore::ImageBuffer::toDataURL): add jpeg encoding and quality support.
1754 * platform/image-encoders/skia/JPEGImageEncoder.cpp: Added.
1755 (WebCore::prepareOutput):
1756 (WebCore::writeOutput):
1757 (WebCore::finishOutput):
1758 (WebCore::handleError):
1759 (WebCore::preMultipliedBGRAtoRGB): FIXME: bug 40147.
1760 (WebCore::JPEGImageEncoder::encode):
1761 * platform/image-encoders/skia/JPEGImageEncoder.h: Added.
1763 2010-12-02 Sheriff Bot <webkit.review.bot@gmail.com>
1765 Unreviewed, rolling out r73152.
1766 http://trac.webkit.org/changeset/73152
1767 https://bugs.webkit.org/show_bug.cgi?id=50401
1769 the patch has broken chromium win layout tests (Requested by
1772 * inspector/CodeGeneratorInspector.pm:
1773 * inspector/Inspector.idl:
1774 * inspector/front-end/Callback.js:
1775 * inspector/front-end/DOMAgent.js:
1776 (WebInspector.DOMNode):
1777 * inspector/front-end/inspector.js:
1778 (WebInspector.loaded.WebInspector.socket.onmessage):
1779 (WebInspector.dispatch):
1780 (WebInspector_syncDispatch):
1781 (WebInspector.reportProtocolError):
1783 2010-12-02 W. James MacLean <wjmaclean@chromium.org>
1785 Reviewed by James Robinson.
1787 Scaled Resized images are blurred when sent to Skia
1788 https://bugs.webkit.org/show_bug.cgi?id=42370
1790 This patch modifies ImageSkia.cpp to fix the calculation of resampled
1791 bitmap sizes so as to include the transform matrix of the canvas.
1792 Includes new tests to catch a scrolling regression and a clipping regression.
1794 Tests: svg/custom/image-rescale-clip.html
1795 svg/custom/image-rescale-scroll.html
1796 svg/custom/image-rescale.svg
1798 * platform/graphics/skia/ImageSkia.cpp:
1799 (WebCore::computeResamplingMode):
1800 (WebCore::drawResampledBitmap):
1802 2010-12-02 Erik Arvidsson <arv@chromium.org>
1804 Reviewed by Darin Adler.
1806 Missing DOM property for incremental input attribute
1807 https://bugs.webkit.org/show_bug.cgi?id=50335
1809 Test: fast/forms/incremental-dom-property.html
1811 * html/HTMLInputElement.idl: Added attribute
1813 2010-12-02 John Knottenbelt <jknotten@chromium.org>
1815 Reviewed by Steve Block.
1817 Move requestGeolocationPermissionForFrame to GeolocationClient
1818 https://bugs.webkit.org/show_bug.cgi?id=50061
1820 This change facilitates client-based geolocation implementation by
1821 bringing together permission control into the geolocation client
1825 * page/ChromeClient.h:
1826 * page/Geolocation.cpp:
1827 (WebCore::Geolocation::disconnectFrame):
1828 (WebCore::Geolocation::requestPermission):
1829 * page/GeolocationClient.h:
1830 * page/GeolocationController.cpp:
1831 (WebCore::GeolocationController::requestPermission):
1832 (WebCore::GeolocationController::cancelPermissionRequest):
1833 * page/GeolocationController.h:
1834 * platform/mock/GeolocationClientMock.cpp:
1835 (WebCore::GeolocationClientMock::GeolocationClientMock):
1836 (WebCore::GeolocationClientMock::setPermission):
1837 (WebCore::GeolocationClientMock::requestPermission):
1838 (WebCore::GeolocationClientMock::cancelPermissionRequest):
1839 (WebCore::GeolocationClientMock::asyncUpdatePermission):
1840 (WebCore::GeolocationClientMock::permissionTimerFired):
1841 (WebCore::GeolocationClientMock::reset):
1842 (WebCore::GeolocationClientMock::stopUpdating):
1843 (WebCore::GeolocationClientMock::asyncUpdateController):
1844 (WebCore::GeolocationClientMock::controllerTimerFired):
1845 * platform/mock/GeolocationClientMock.h:
1847 2010-12-01 Ilya Tikhonovsky <loislo@chromium.org>
1849 Reviewed by Pavel Feldman.
1851 Web Inspector: Inspector protocol cleanup task.
1853 The patch has just small renames and adjustments for the protocol things.
1854 'handler' keyword in idl file was replaced with 'domain'.
1855 'domain' property was assigned for the each backend to frontend messages.
1856 At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
1858 https://bugs.webkit.org/show_bug.cgi?id=50337
1860 * inspector/CodeGeneratorInspector.pm:
1861 * inspector/Inspector.idl:
1862 * inspector/front-end/inspector.js:
1863 (WebInspector_syncDispatch):
1865 2010-12-01 Andrey Kosyakov <caseq@chromium.org>
1867 Reviewed by Pavel Feldman.
1869 Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
1870 Re-implementing HAR export functionality that used to be in Resources
1872 https://bugs.webkit.org/show_bug.cgi?id=45663
1874 * inspector/front-end/NetworkPanel.js:
1875 (WebInspector.NetworkPanel.prototype._createTable):
1876 (WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
1877 (WebInspector.NetworkPanel.prototype._contextMenu):
1878 (WebInspector.NetworkPanel.prototype._exportAll):
1879 (WebInspector.NetworkPanel.prototype._exportResource):
1880 (WebInspector.NetworkDataGridNode.prototype.refreshResource):
1881 * inspector/front-end/networkPanel.css:
1882 (.data-grid table.data tr.revealed.network-item):
1883 (.data-grid.filter-other table.data tr.revealed.network-category-other):
1885 2010-12-02 Dai Mikurube <dmikurube@google.com>
1887 Reviewed by Kent Tamura.
1889 Reject named colors, accept only #rrggbb in <input type=color />
1890 https://bugs.webkit.org/show_bug.cgi?id=50308
1892 * html/ColorInputType.cpp: Modified to accept only simple colors like #xxxxxx.
1893 (WebCore::isValidColorString):
1895 2010-12-02 Vincent Scheib <scheib@chromium.org>
1897 Reviewed by Darin Fisher.
1899 [chromium] histograms api updated in WebKitClient and added to ChromiumBridge
1900 https://bugs.webkit.org/show_bug.cgi?id=50285
1902 Test by loading "about:histograms" after navigating to accelerated pages.
1904 * platform/chromium/ChromiumBridge.h: api update.
1906 2010-12-02 Andras Becsi <abecsi@webkit.org>
1908 Unreviewed build fix.
1910 [Qt][V8] Fix linking of generated sources.
1912 No new tests needed.
1914 * WebCore.pro: add missing V8ImageDataCustom.cpp.
1916 2010-12-02 Nikolas Zimmermann <nzimmermann@rim.com>
1918 Reviewed by Adam Roben.
1920 Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedString/SVGAnimatedEnumeration
1921 https://bugs.webkit.org/show_bug.cgi?id=50383
1923 Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_(STRING|ENUMERATION) / DEFINE_ANIMATED_(STRING|ENUMERATION).
1924 The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.
1926 No functional changes, thus no new tests.
1928 * svg/SVGAElement.cpp:
1929 * svg/SVGAElement.h:
1930 (WebCore::SVGAElement::isValid):
1931 (WebCore::SVGAElement::target):
1932 * svg/SVGAltGlyphElement.cpp:
1933 * svg/SVGAltGlyphElement.h:
1934 * svg/SVGAnimatedEnumeration.h:
1935 * svg/SVGAnimatedString.h:
1936 * svg/SVGClipPathElement.cpp:
1937 * svg/SVGClipPathElement.h:
1938 * svg/SVGComponentTransferFunctionElement.cpp:
1939 * svg/SVGComponentTransferFunctionElement.h:
1940 * svg/SVGCursorElement.cpp:
1941 * svg/SVGCursorElement.h:
1942 * svg/SVGFEBlendElement.cpp:
1943 * svg/SVGFEBlendElement.h:
1944 * svg/SVGFEColorMatrixElement.cpp:
1945 * svg/SVGFEColorMatrixElement.h:
1946 * svg/SVGFEComponentTransferElement.cpp:
1947 * svg/SVGFEComponentTransferElement.h:
1948 * svg/SVGFECompositeElement.cpp:
1949 * svg/SVGFECompositeElement.h:
1950 * svg/SVGFEConvolveMatrixElement.cpp:
1951 * svg/SVGFEConvolveMatrixElement.h:
1952 * svg/SVGFEDiffuseLightingElement.cpp:
1953 * svg/SVGFEDiffuseLightingElement.h:
1954 * svg/SVGFEDisplacementMapElement.cpp:
1955 * svg/SVGFEDisplacementMapElement.h:
1956 * svg/SVGFEGaussianBlurElement.cpp:
1957 * svg/SVGFEGaussianBlurElement.h:
1958 * svg/SVGFEImageElement.cpp:
1959 * svg/SVGFEImageElement.h:
1960 * svg/SVGFELightElement.cpp:
1961 * svg/SVGFEMergeNodeElement.cpp:
1962 * svg/SVGFEMergeNodeElement.h:
1963 * svg/SVGFEMorphologyElement.cpp:
1964 * svg/SVGFEMorphologyElement.h:
1965 * svg/SVGFEOffsetElement.cpp:
1966 * svg/SVGFEOffsetElement.h:
1967 * svg/SVGFESpecularLightingElement.cpp:
1968 * svg/SVGFESpecularLightingElement.h:
1969 * svg/SVGFETileElement.cpp:
1970 * svg/SVGFETileElement.h:
1971 * svg/SVGFETurbulenceElement.cpp:
1972 * svg/SVGFETurbulenceElement.h:
1973 * svg/SVGFilterElement.cpp:
1974 * svg/SVGFilterElement.h:
1975 * svg/SVGFilterPrimitiveStandardAttributes.cpp:
1976 * svg/SVGFilterPrimitiveStandardAttributes.h:
1977 * svg/SVGForeignObjectElement.cpp:
1978 * svg/SVGForeignObjectElement.h:
1979 * svg/SVGGradientElement.cpp:
1980 * svg/SVGGradientElement.h:
1981 * svg/SVGImageElement.cpp:
1982 * svg/SVGImageElement.h:
1983 * svg/SVGMPathElement.cpp:
1984 * svg/SVGMPathElement.h:
1985 * svg/SVGMarkerElement.cpp:
1986 * svg/SVGMarkerElement.h:
1987 * svg/SVGMaskElement.cpp:
1988 * svg/SVGMaskElement.h:
1989 * svg/SVGPatternElement.cpp:
1990 * svg/SVGPatternElement.h:
1991 * svg/SVGScriptElement.cpp:
1992 * svg/SVGScriptElement.h:
1993 * svg/SVGStyledElement.cpp:
1994 * svg/SVGStyledElement.h:
1995 (WebCore::SVGStyledElement::hasRelativeLengths):
1996 (WebCore::SVGStyledElement::supportsMarkers):
1997 (WebCore::SVGStyledElement::style):
1998 (WebCore::SVGStyledElement::updateRelativeLengthsInformation):
1999 (WebCore::SVGStyledElement::selfHasRelativeLengths):
2000 (WebCore::SVGStyledElement::isStyled):
2001 * svg/SVGTRefElement.cpp:
2002 * svg/SVGTRefElement.h:
2003 * svg/SVGTextContentElement.cpp:
2004 * svg/SVGTextContentElement.h:
2005 * svg/SVGTextPathElement.cpp:
2006 * svg/SVGTextPathElement.h:
2007 * svg/SVGUseElement.cpp:
2008 * svg/SVGUseElement.h:
2010 2010-12-02 Patrick Gansterer <paroga@webkit.org>
2012 Reviewed by Andreas Kling.
2014 [WX] Remove "current path" of GraphicsContext
2015 https://bugs.webkit.org/show_bug.cgi?id=50286
2017 * platform/graphics/GraphicsContext.h:
2018 * platform/graphics/wx/GraphicsContextWx.cpp:
2019 (WebCore::GraphicsContext::GraphicsContext):
2020 (WebCore::GraphicsContext::fillPath):
2021 (WebCore::GraphicsContext::strokePath):
2023 2010-10-26 Martin Robinson <mrobinson@igalia.com>
2025 Reviewed by Xan Lopez.
2027 [GTK] Text input controls do not react properly to CSS styling
2028 https://bugs.webkit.org/show_bug.cgi?id=40855
2030 Improve text input control rendering. Instead of using the GTK+ border
2031 attributes of the control modify the padding, they modify the border.
2032 Make this same choice for search inputs and text area inputs.
2034 * platform/gtk/RenderThemeGtk.cpp:
2035 (WebCore::setTextInputBorders): Added this helper which sets text input control
2036 borders based on GTK+ theme settings.
2037 (WebCore::RenderThemeGtk::adjustTextFieldStyle): Use the setTextInputBorders helper.
2038 (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
2039 (WebCore::RenderThemeGtk::adjustSearchFieldStyle): Ditto.
2040 * platform/gtk/RenderThemeGtk.h:
2042 2010-12-02 Andreas Kling <kling@webkit.org>
2044 Reviewed by Kenneth Rohde Christiansen.
2046 [Qt] GraphicsContext::strokeRect() taints the context's lineWidth
2047 https://bugs.webkit.org/show_bug.cgi?id=50269
2049 Test: fast/canvas/canvas-lineWidth-intact-after-strokeRect.html
2051 * platform/graphics/qt/GraphicsContextQt.cpp:
2052 (WebCore::GraphicsContext::strokeRect): Restore the context's
2053 original stroke thickness after painting.
2055 2010-12-02 Renata Hodovan <reni@webkit.org>
2057 Reviewed by Andreas Kling.
2059 [Qt] GraphicsContext::clip(path) should clip using winding fill
2060 https://bugs.webkit.org/show_bug.cgi?id=49912
2062 GraphicsContext::clip(path) now uses winding fill and this function is called by
2063 GraphicsContext::canvasClip(path).
2065 No new test is needed.
2067 * platform/graphics/qt/GraphicsContextQt.cpp:
2068 (WebCore::GraphicsContext::clip):
2069 (WebCore::GraphicsContext::canvasClip):
2071 2010-12-01 Alexander Pavlov <apavlov@chromium.org>
2073 Reviewed by Yury Semikhatsky.
2075 Web Inspector: Remove obsolete CSS backend API from InspectorDOMAgent
2076 https://bugs.webkit.org/show_bug.cgi?id=50318
2083 * WebCore.vcproj/WebCore.vcproj:
2084 * WebCore.xcodeproj/project.pbxproj:
2085 * inspector/Inspector.idl:
2086 * inspector/InspectorCSSAgent.h:
2087 * inspector/InspectorCSSStore.cpp: Removed.
2088 * inspector/InspectorCSSStore.h: Removed.
2089 * inspector/InspectorController.cpp:
2090 (WebCore::InspectorController::InspectorController):
2091 (WebCore::InspectorController::connectFrontend):
2092 (WebCore::InspectorController::didCommitLoad):
2093 * inspector/InspectorController.h:
2094 * inspector/InspectorDOMAgent.cpp:
2095 (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2096 (WebCore::InspectorDOMAgent::unbind):
2097 * inspector/InspectorDOMAgent.h:
2098 (WebCore::InspectorDOMAgent::create):
2100 2010-12-02 Csaba Osztrogonác <ossy@webkit.org>
2102 Unreviewed trivial buildfix after r73117.
2104 * page/FrameView.cpp:
2105 (WebCore::FrameView::calculateScrollbarModesForLayout):
2107 2010-12-02 Yuqiang Xian <yuqiang.xian@intel.com>
2109 Reviewed by Pavel Feldman.
2111 [V8] Speed up data property access for ImageData.
2112 https://bugs.webkit.org/show_bug.cgi?id=49999
2114 We create a normal V8 object which has a PixelArray as the backing storage,
2115 and set the "data" property of the ImageData object to it.
2116 This way "data" becomes a pure JS property and we don't need to call through
2117 the C++ bindings for ImageData "data" access.
2118 This eliminates big overhead in switching between JavaScript and native
2119 contexts and performing object bindings.
2121 No new tests. Relying on existing Canvas tests.
2124 * bindings/scripts/CodeGeneratorV8.pm:
2125 * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
2127 * bindings/v8/custom/V8ImageDataCustom.cpp: Added.
2129 * html/ImageData.idl:
2130 * html/canvas/CanvasPixelArray.idl:
2132 2010-12-02 Kent Tamura <tkent@chromium.org>
2134 Unreviewed. Run sort-Xcode-project-file.
2136 * WebCore.xcodeproj/project.pbxproj:
2138 2010-12-02 Mike Lawther <mikelawther@chromium.org>
2140 Reviewed by David Hyatt.
2142 Clean up of iframe scrollbar mode code
2143 https://bugs.webkit.org/show_bug.cgi?id=47797
2145 Pull setChildNeedsLayout/setNeedsLayout calls out of scrollbar mode
2146 calculation method and put back into main layout function.
2147 Early exit from the scrollbar calc when scrollbars are turned off.
2149 * page/FrameView.cpp:
2150 (WebCore::FrameView::calculateScrollbarModesForLayout):
2151 (WebCore::FrameView::layout):
2153 2010-12-02 Hironori Bono <hbono@chromium.org>
2155 Reviewed by Darin Fisher.
2157 [Chromium] Fix possible crashes in FontFallbackFont::determinePitch().
2158 https://bugs.webkit.org/show_bug.cgi?id=25770
2160 When all of "Arial", "Courier New", and "Times New Roman" fonts are corrupted,
2161 FontCache::getLastResortFallbackFont() returns 0 and it causes this crash. To
2162 avoid this crash, this change falls back to system fonts (Windows ensures they
2163 are sane) as Win Safari does. Unfortunately, I don't have any ideas how I can
2164 write a layout test for this issue because this crash happens on a PC some of
2165 its system fonts are corrupted.
2167 * platform/graphics/chromium/FontCacheChromiumWin.cpp:
2168 (WebCore::fontDataFromDescriptionAndLogFont):
2169 (WebCore::FontCache::getLastResortFallbackFont):
2171 2010-12-02 Dimitri Glazkov <dglazkov@chromium.org>
2173 Reviewed by Kent Tamura.
2175 Provide means to store shadow DOM nodes on Element
2176 https://bugs.webkit.org/show_bug.cgi?id=48697
2178 Adds shadow DOM awareness to the standard Node attach/detach,
2179 document and tree insertion and removal cycle.
2181 No new tests, because the code is not yet used.
2184 (WebCore::Element::insertedIntoDocument): Added logic to cascade down to shadow DOM, if present.
2185 (WebCore::Element::removedFromDocument): Ditto.
2186 (WebCore::Element::insertedIntoTree): Ditto.
2187 (WebCore::Element::removedFromTree): Ditto.
2188 (WebCore::Element::attach): Ditto.
2189 (WebCore::Element::detach): Ditto.
2190 (WebCore::Element::recalcStyle):
2191 (WebCore::Element::shadowRoot): Added.
2192 (WebCore::Element::setShadowRoot): Added.
2193 (WebCore::Element::clearShadowRoot): Added.
2194 * dom/Element.h: Added decls.
2195 * dom/ElementRareData.h: Added a member to hold a RefPtr to the shadow DOM root for the element.
2197 2010-12-02 Adam Barth <abarth@webkit.org>
2199 Reviewed by Eric Seidel.
2201 Gray-scale JPEG images with a color profile are stretched horizonally
2202 https://bugs.webkit.org/show_bug.cgi?id=49950
2204 Turns out gray-scale JPEGs with color profiles have the same issue as
2205 PNGs. As with PNGs, we suppress now suppress the color profile for
2206 gray-scale JPEGs. Most importantly, this patch adds a test.
2208 Test: fast/images/gray-scale-jpeg-with-color-profile.html
2210 * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
2211 (WebCore::JPEGImageReader::decode):
2213 2010-12-01 Geoffrey Garen <ggaren@apple.com>
2215 Build fix: Added a forwarding header.
2217 * ForwardingHeaders/wtf/OSAllocator.h: Added.
2219 2010-12-01 Jia Pu <jpu@apple.com>
2221 Reviewed by Darin Adler.
2223 Support multiple correction candidates panel for misspelled word on Mac OS X.
2224 https://bugs.webkit.org/show_bug.cgi?id=50137
2225 <rdar://problem/8568059>
2227 Test: platform/mac/editing/spelling/delete-autocorrected-word-1.html
2228 Manual test: WebCore/manual-tests/autocorrection/dismiss-multiple-guesses.html
2229 WebCore/manual-tests/autocorrection/select-from-multiple-guesses.html
2231 This patch is for supporting multiple correction suggestion panel on Mac OS X.
2232 The behavior and implementation is similar to that of reversion candiate panel.
2234 * WebCore.exp.in: Added and removed symbols.
2236 * editing/CorrectionPanelInfo.h: Added new correction panel type, PanelTypeSpellingSuggestions.
2238 * editing/Editor.cpp:
2239 (WebCore::markerTypesForAutocorrection): Convenient function for getting marker types to
2240 be added to autocorrected word.
2241 (WebCore::boundingBoxForRange): Convenient function for calculating the bounding box of a range.
2242 (WebCore::markerTypesForReplacement): Convenient function for getting marker types to
2243 be added to word that has been replaced by various correction panel.
2244 (WebCore::Editor::respondToChangedSelection): Added code to trigger timer for multiple
2246 (WebCore::Editor::guessesForMisspelledSelection): Adopted new signature of EditorClient::getGuessesForWord().
2247 (WebCore::Editor::markMisspellingsAfterTypingToWord): Adopted new signature of applyCorrectionPanelInfo().
2248 (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
2249 (WebCore::Editor::correctionPanelTimerFired): Added code to handle new multiple suggestion panel.
2250 (WebCore::Editor::handleCorrectionPanelResult): Replaced handleRejectedCorrection(), since
2251 with new AppKit correction panel API, not only rejection, but also confirmation can be
2252 handled in callback.
2253 (WebCore::Editor::stopCorrectionPanelTimer): Moved the code that clears correction panel info
2254 from dismissCorrectionPanel() to this function to fix a bug that would occur when deleting
2256 (WebCore::Editor::dismissCorrectionPanel): Ditto.
2257 (WebCore::Editor::applyCorrectionPanelInfo): Added code to handle new multiple suggestion panel.
2259 * editing/Editor.h: Replaced handleRejectedCorrection() with handleCorrectionPanelResult().
2260 Changed the signature of applyCorrectionPanelInfo() to hanlde new correction panel type.
2262 * editing/TextCheckingHelper.cpp:
2263 (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Adopted new EditorClient::getGuessesForWord().
2265 * editing/TextCheckingHelper.h: Made paragraphRange() public.
2267 * loader/EmptyClients.h:
2268 (WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature defined in base class.
2269 (WebCore::EmptyEditorClient::getGuessesForWord): Ditto.
2271 * manual-tests/autocorrection/dismiss-multiple-guesses.html: Added.
2273 * manual-tests/autocorrection/select-from-multiple-guesses.html: Added.
2275 * page/EditorClient.h: Changed showCorrectionPanel() to allow passing multiple correction
2276 candidates. Changed getGuessesForWord() to allow passing in contextual text for better
2277 correction suggestions (for those spellcheckers that utilizes such contextual information).
2279 2010-12-01 David Hyatt <hyatt@apple.com>
2281 Reviewed by James Robinson.
2283 https://bugs.webkit.org/show_bug.cgi?id=50360
2285 Make sure to include the origin adjustment code that I added on Mac to keep truncation-rtl.html passing.
2287 * platform/ScrollView.cpp:
2288 (WebCore::ScrollView::updateScrollbars):
2290 2010-12-01 David Hyatt <hyatt@apple.com>
2292 Reviewed by Dan Bernstein.
2294 https://bugs.webkit.org/show_bug.cgi?id=46645
2296 Generalize overflow section scrollOriginX code to be a point and to work in both horizontal
2299 Not testable yet, since the rightmost/leftmost/topmost/lowestPosition functions are returning
2300 horrendously wrong values in the vertical text case for overflow:auto objects.
2302 * rendering/RenderLayer.cpp:
2303 (WebCore::RenderLayer::RenderLayer):
2304 (WebCore::RenderLayer::scrollToOffset):
2305 (WebCore::RenderLayer::computeScrollDimensions):
2306 (WebCore::RenderLayer::updateOverflowStatus):
2307 * rendering/RenderLayer.h:
2308 (WebCore::RenderLayer::scrolledContentOffset):
2309 (WebCore::RenderLayer::scrollXOffset):
2310 (WebCore::RenderLayer::scrollYOffset):
2311 (WebCore::RenderLayer::scrollToXOffset):
2312 (WebCore::RenderLayer::scrollToYOffset):
2314 2010-12-01 Steve Falkenburg <sfalken@apple.com>
2316 Reviewed by Adam Roben.
2318 WinCairo build should not use link-time code generation (LTCG)
2319 https://bugs.webkit.org/show_bug.cgi?id=50353
2321 * WebCore.vcproj/QTMovieWin.vcproj:
2322 * WebCore.vcproj/WebCore.vcproj:
2324 2010-12-01 David Hyatt <hyatt@apple.com>
2326 Reviewed by Darin Adler.
2328 https://bugs.webkit.org/show_bug.cgi?id=46645
2330 Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
2331 recently added for horizontal RTL documents and applies it to writing modes as well. Now the
2332 scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
2334 This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
2335 makes them behave the same as the cross-platform code (allowing for cross-platform results to be
2338 * page/FrameView.cpp:
2339 (WebCore::FrameView::adjustViewSize):
2340 * page/mac/WebCoreFrameView.h:
2341 * platform/ScrollView.cpp:
2342 (WebCore::ScrollView::ScrollView):
2343 (WebCore::ScrollView::maximumScrollPosition):
2344 (WebCore::ScrollView::minimumScrollPosition):
2345 (WebCore::ScrollView::valueChanged):
2346 (WebCore::ScrollView::updateScrollbars):
2347 (WebCore::ScrollView::wheelEvent):
2348 * platform/ScrollView.h:
2349 (WebCore::ScrollView::scrollOrigin):
2350 * platform/mac/ScrollViewMac.mm:
2351 (WebCore::ScrollView::platformSetScrollPosition):
2352 (WebCore::ScrollView::platformSetScrollOrigin):
2353 * rendering/RenderBox.cpp:
2354 (WebCore::RenderBox::paintRootBoxDecorations):
2355 * rendering/RenderView.cpp:
2356 (WebCore::RenderView::layout):
2357 (WebCore::RenderView::docTop):
2358 (WebCore::RenderView::docHeight):
2359 (WebCore::RenderView::docLeft):
2360 (WebCore::RenderView::docWidth):
2361 * rendering/RenderView.h:
2363 2010-11-30 Steve Block <steveblock@google.com>
2365 Reviewed by Jeremy Orlow.
2367 Upstream recent changes to WebCore/platform/network/android
2368 https://bugs.webkit.org/show_bug.cgi?id=50224
2370 Android implementation changes only, no new tests.
2372 * platform/network/NetworkingContext.h:
2373 * platform/network/android/CookieJarAndroid.cpp:
2374 (WebCore::setCookies):
2376 (WebCore::cookieRequestHeaderFieldValue):
2377 (WebCore::cookiesEnabled):
2378 * platform/network/android/ProxyServerAndroid.cpp: Added.
2379 (WebCore::proxyServersForURL):
2380 * platform/network/android/ResourceHandleAndroid.cpp:
2381 (WebCore::ResourceHandle::start):
2382 (WebCore::ResourceHandle::loadResourceSynchronously):
2383 * platform/network/android/ResourceRequestAndroid.cpp:
2384 (WebCore::initializeMaximumHTTPConnectionCountPerHost):
2386 2010-12-01 Steve Falkenburg <sfalken@apple.com>
2388 Reviewed by Adam Roben.
2390 vcproj changes can't be applied cleanly by the Windows EWS bot
2391 https://bugs.webkit.org/show_bug.cgi?id=50328
2393 * WebCore.vcproj/QTMovieWin.vcproj: Modified property svn:eol-style.
2394 * WebCore.vcproj/QTMovieWinCommon.vsprops: Added property svn:eol-style.
2395 * WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
2396 * WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.
2397 * WebCore.vcproj/WebCore.vcproj: Modified property svn:eol-style.
2398 * WebCore.vcproj/WebCoreCFNetwork.vsprops: Added property svn:eol-style.
2399 * WebCore.vcproj/WebCoreCG.vsprops: Added property svn:eol-style.
2400 * WebCore.vcproj/WebCoreCURL.vsprops: Added property svn:eol-style.
2401 * WebCore.vcproj/WebCoreCairo.vsprops: Added property svn:eol-style.
2402 * WebCore.vcproj/WebCoreCommon.vsprops: Added property svn:eol-style.
2403 * WebCore.vcproj/WebCoreGenerated.vcproj: Modified property svn:eol-style.
2404 * WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Added property svn:eol-style.
2405 * WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Added property svn:eol-style.
2406 * WebCore.vcproj/WebCoreMediaQT.vsprops: Added property svn:eol-style.
2407 * WebCore.vcproj/WebCorePthreads.vsprops: Added property svn:eol-style.
2408 * WebCore.vcproj/WebCoreQuartzCore.vsprops: Added property svn:eol-style.
2410 2010-11-30 Vangelis Kokkevis <vangelis@chromium.org>
2412 Reviewed by Darin Fisher.
2414 Adds accelerated compositing trigger flags to Settings to allow
2415 ports to set them via command line flags, etc.
2416 https://bugs.webkit.org/show_bug.cgi?id=50301
2418 * page/Settings.cpp:
2419 (WebCore::Settings::Settings):
2420 (WebCore::Settings::setAcceleratedCompositingFor3DTransformsEnabled):
2421 (WebCore::Settings::setAcceleratedCompositingForVideoEnabled):
2422 (WebCore::Settings::setAcceleratedCompositingForPluginsEnabled):
2423 (WebCore::Settings::setAcceleratedCompositingForCanvasEnabled):
2424 (WebCore::Settings::setAcceleratedCompositingForAnimationEnabled):
2426 (WebCore::Settings::acceleratedCompositingFor3DTransformsEnabled):
2427 (WebCore::Settings::acceleratedCompositingForVideoEnabled):
2428 (WebCore::Settings::acceleratedCompositingForPluginsEnabled):
2429 (WebCore::Settings::acceleratedCompositingForCanvasEnabled):
2430 (WebCore::Settings::acceleratedCompositingForAnimationEnabled):
2432 2010-12-01 Darin Adler <darin@apple.com>
2434 Fixed warning seen on buildbot.
2436 * platform/graphics/chromium/ContentLayerChromium.cpp:
2437 (WebCore::ContentLayerChromium::SharedValues::SharedValues): Added #if.
2439 2010-12-01 Ryosuke Niwa <rniwa@webkit.org>
2441 Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.
2443 chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea)
2444 https://bugs.webkit.org/show_bug.cgi?id=47808
2446 The crash was caused by moveParagraphWithClones' not copying the entire paragraph
2447 when called by doApplyForSingleParagraph, which was induced by a bug in
2448 cloneParagraphUnderNewElement which ended the cloning process early when the start node
2449 and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
2450 by calling traverseNextSibling(outerNode) instead of nextSibling().
2452 Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.
2454 Tests: editing/execCommand/switch-multiple-list-items-crash.html
2455 editing/execCommand/switch-multiple-list-items.html
2457 * editing/CompositeEditCommand.cpp:
2458 (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
2459 * editing/InsertListCommand.cpp:
2460 (WebCore::InsertListCommand::doApply):
2462 2010-12-01 Kevin Ollivier <kevino@theolliviers.com>
2464 [wx] Build fixes after recent trunk changes.
2466 * platform/graphics/wx/ImageBufferWx.cpp:
2467 (WebCore::ImageBuffer::ImageBuffer):
2468 * platform/wx/LocalizedStringsWx.cpp:
2469 (WebCore::platformDefaultLanguage):
2471 2010-12-01 Sheriff Bot <webkit.review.bot@gmail.com>
2473 Unreviewed, rolling out r73047.
2474 http://trac.webkit.org/changeset/73047
2475 https://bugs.webkit.org/show_bug.cgi?id=50339
2477 missing bug number (Requested by rniwa on #webkit).
2479 * editing/CompositeEditCommand.cpp:
2480 (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
2481 * editing/InsertListCommand.cpp:
2482 (WebCore::InsertListCommand::doApply):
2484 2010-12-01 Ryosuke Niwa <rniwa@webkit.org>
2486 Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.
2488 The crash was caused by moveParagraphWithClones' not copying the entire paragraph
2489 when called by doApplyForSingleParagraph, which was induced by a bug in
2490 cloneParagraphUnderNewElement which ended the cloning process early when the start node
2491 and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
2492 by calling traverseNextSibling(outerNode) instead of nextSibling().
2494 Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.
2496 Tests: editing/execCommand/switch-multiple-list-items-crash.html
2497 editing/execCommand/switch-multiple-list-items.html
2499 * editing/CompositeEditCommand.cpp:
2500 (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
2501 * editing/InsertListCommand.cpp:
2502 (WebCore::InsertListCommand::doApply):
2504 2010-12-01 Grace Kloba <klobag@chromium.org>
2506 Reviewed by Kenneth Russell.
2508 [chromium] ContentLayerChromium shader should honor the platform Sk_x_SHIFT value instead of assuming BGRA color
2509 https://bugs.webkit.org/show_bug.cgi?id=50189
2511 * platform/graphics/chromium/ContentLayerChromium.cpp:
2512 (WebCore::ContentLayerChromium::SharedValues::SharedValues):Use SK_B32_SHIFT to decide whether to use RGBA or BGRA shader for Skia port.
2514 2010-12-01 Nico Weber <thakis@chromium.org>
2516 Reviewed by Dimitri Glazkov.
2518 Fix clang warnings caused by -Wlogical-op-parentheses
2519 https://bugs.webkit.org/show_bug.cgi?id=50324
2521 * platform/graphics/mac/ComplexTextController.cpp:
2522 (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
2524 2010-12-01 Martin Robinson <mrobinson@igalia.com>
2528 * platform/gtk/PopupMenuGtk.cpp:
2529 (WebCore::PopupMenuGtk::typeAheadFind): Uncomment mistakenly commented line.
2531 2010-12-01 Apelete Seketeli <apelete@seketeli.org> and Martin Robinson <mrobinson@igalia.com>
2533 Reviewed by Xan Lopez.
2535 [Gtk] Open menulists should support typeahead find
2536 https://bugs.webkit.org/show_bug.cgi?id=27443
2538 Added typeahead find support for open GTK+ menulists.
2540 Test: platform/gtk/fast/forms/menulist-typeahead-find.html
2542 * platform/gtk/PopupMenuGtk.cpp:
2543 (WebCore::PopupMenuGtk::PopupMenuGtk): Initialize new members.
2544 (WebCore::PopupMenuGtk::show): Track currently selected menu item
2545 via a signal handler.
2546 (WebCore::PopupMenuGtk::typeAheadFind): Added.
2547 (WebCore::PopupMenuGtk::menuUnmapped): Reset typeahead find state
2548 when menu is unmapped.
2549 (WebCore::PopupMenuGtk::resetTypeAheadFindState): Added.
2550 (WebCore::PopupMenuGtk::selectItemCallback): Added.
2551 (WebCore::PopupMenuGtk::keyPressEventCallback): Added.
2552 * platform/gtk/PopupMenuGtk.h: Added new members to track typeahead
2555 2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
2557 Reviewed by Xan Lopez.
2559 Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedNumber
2560 https://bugs.webkit.org/show_bug.cgi?id=50323
2562 Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_NUMBER / DEFINE_ANIMATED_NUMBER.
2563 The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.
2565 No functional changes, thus no new tests.
2567 * svg/SVGAnimatedNumber.h:
2568 * svg/SVGComponentTransferFunctionElement.cpp:
2569 * svg/SVGComponentTransferFunctionElement.h:
2570 * svg/SVGFECompositeElement.cpp:
2571 * svg/SVGFECompositeElement.h:
2572 * svg/SVGFEConvolveMatrixElement.cpp:
2573 * svg/SVGFEConvolveMatrixElement.h:
2574 * svg/SVGFEDiffuseLightingElement.cpp:
2575 * svg/SVGFEDiffuseLightingElement.h:
2576 * svg/SVGFEDisplacementMapElement.cpp:
2577 * svg/SVGFEDisplacementMapElement.h:
2578 * svg/SVGFEGaussianBlurElement.cpp:
2579 * svg/SVGFEGaussianBlurElement.h:
2580 * svg/SVGFELightElement.cpp:
2581 * svg/SVGFELightElement.h:
2582 * svg/SVGFEMorphologyElement.cpp:
2583 * svg/SVGFEMorphologyElement.h:
2584 * svg/SVGFEOffsetElement.cpp:
2585 * svg/SVGFEOffsetElement.h:
2586 * svg/SVGFESpecularLightingElement.cpp:
2587 * svg/SVGFESpecularLightingElement.h:
2588 * svg/SVGFETurbulenceElement.cpp:
2589 * svg/SVGFETurbulenceElement.h:
2590 * svg/SVGPathElement.cpp:
2591 * svg/SVGPathElement.h:
2592 * svg/SVGStopElement.cpp:
2593 * svg/SVGStopElement.h:
2594 (WebCore::SVGStopElement::isGradientStop):
2596 2010-12-01 Martin Robinson <mrobinson@igalia.com>
2598 Reviewed by Xan Lopez.
2600 Sliders are not transformed after r50188
2601 https://bugs.webkit.org/show_bug.cgi?id=50317
2603 Need to call updateLayerTransform during slider layout, as sliders
2606 No new tests. This patch should make fast/forms/slider-transformed.html
2607 pass on the GTK+ bots.
2609 * rendering/RenderSlider.cpp:
2610 (WebCore::RenderSlider::layout): Call updateLayerTransform here.
2612 2010-11-30 Pavel Feldman <pfeldman@chromium.org>
2614 Reviewed by Yury Semikhatsky.
2616 Web Inspector: do not make helpScreen.css lazily loaded.
2617 https://bugs.webkit.org/show_bug.cgi?id=50304
2619 * inspector/front-end/HelpScreen.js:
2620 (WebInspector.HelpScreen):
2621 (WebInspector.HelpScreen.prototype._onBlur):
2622 * inspector/front-end/inspector.html:
2624 2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
2626 Reviewed by Xan Lopez.
2628 Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLengthList/SVGNumberList/SVGTransformList
2629 https://bugs.webkit.org/show_bug.cgi?id=50322
2631 Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_(LENGTH|NUMBER|TRANSFORM)_LIST / DEFINE_ANIMATED_(LENGTH|NUMBER|TRANSFORM).
2632 The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.
2634 No functional changes, thus no new tests.
2636 * svg/SVGAnimatedLengthList.h:
2637 * svg/SVGAnimatedNumberList.h:
2638 * svg/SVGAnimatedTransformList.h:
2639 * svg/SVGComponentTransferFunctionElement.cpp:
2640 * svg/SVGComponentTransferFunctionElement.h:
2641 * svg/SVGFEColorMatrixElement.cpp:
2642 * svg/SVGFEColorMatrixElement.h:
2643 * svg/SVGFEConvolveMatrixElement.cpp:
2644 * svg/SVGFEConvolveMatrixElement.h:
2645 * svg/SVGGradientElement.cpp:
2646 * svg/SVGGradientElement.h:
2647 (WebCore::SVGGradientElement::needsPendingResourceHandling):
2648 * svg/SVGPatternElement.cpp:
2649 * svg/SVGPatternElement.h:
2650 * svg/SVGPolygonElement.cpp:
2651 * svg/SVGPolylineElement.cpp:
2652 * svg/SVGStyledTransformableElement.cpp:
2653 * svg/SVGStyledTransformableElement.h:
2654 * svg/SVGTextElement.cpp:
2655 (WebCore::SVGTextElement::SVGTextElement):
2656 * svg/SVGTextElement.h:
2657 (WebCore::SVGTextElement::localCoordinateSpaceTransform):
2658 * svg/SVGTextPositioningElement.cpp:
2659 * svg/SVGTextPositioningElement.h:
2660 * svg/properties/SVGAnimatedPropertyMacros.h:
2662 2010-12-01 Alexander Pavlov <apavlov@chromium.org>
2664 Reviewed by Yury Semikhatsky.
2666 Web Inspector: name-only property appears in style declaration but not in the Styles pane
2667 https://bugs.webkit.org/show_bug.cgi?id=49663
2669 Check that at least one property has been parsed from the user input.
2671 * inspector/InspectorStyleSheet.cpp:
2672 (WebCore::InspectorStyle::setPropertyText):
2674 2010-12-01 Andrey Kosyakov <caseq@chromium.org>
2676 Reviewed by Pavel Feldman.
2678 Web Inspector: disable cookies tab in network resource view by default, enable for chromium
2679 https://bugs.webkit.org/show_bug.cgi?id=50249
2681 * inspector/front-end/NetworkItemView.js:
2682 (WebInspector.NetworkItemView):
2683 (WebInspector.NetworkItemView.prototype.resize):
2684 * inspector/front-end/Settings.js:
2686 2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
2688 Reviewed by Xan Lopez.
2690 Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLength
2691 https://bugs.webkit.org/show_bug.cgi?id=50316
2693 Introduce DECLARE_ANIMATED_LENGTH / DEFINE_ANIMATED_LENGTH, splitting up the original DECLARE_ANIMATED_PROPERTY_NEW macro
2694 in a part that goes in the .cpp file and another that remains in the header. This avoids having to include SVGNames.h
2695 in all SVG*Element files.
2697 No functional changes, thus no new tests.
2699 * svg/SVGAnimatedLength.h:
2700 * svg/SVGCircleElement.cpp:
2701 * svg/SVGCircleElement.h:
2702 (WebCore::SVGCircleElement::isValid):
2703 * svg/SVGCursorElement.cpp:
2704 * svg/SVGCursorElement.h:
2705 (WebCore::SVGCursorElement::isValid):
2706 * svg/SVGEllipseElement.cpp:
2707 * svg/SVGEllipseElement.h:
2708 (WebCore::SVGEllipseElement::isValid):
2709 * svg/SVGFilterElement.cpp:
2710 * svg/SVGFilterElement.h:
2711 * svg/SVGFilterPrimitiveStandardAttributes.cpp:
2712 * svg/SVGFilterPrimitiveStandardAttributes.h:
2713 * svg/SVGForeignObjectElement.cpp:
2714 (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
2715 * svg/SVGForeignObjectElement.h:
2716 (WebCore::SVGForeignObjectElement::isValid):
2717 * svg/SVGImageElement.cpp:
2718 * svg/SVGImageElement.h:
2719 (WebCore::SVGImageElement::isValid):
2720 * svg/SVGLineElement.cpp:
2721 * svg/SVGLineElement.h:
2722 (WebCore::SVGLineElement::isValid):
2723 (WebCore::SVGLineElement::supportsMarkers):
2724 * svg/SVGLinearGradientElement.cpp:
2725 * svg/SVGLinearGradientElement.h:
2726 * svg/SVGMarkerElement.cpp:
2727 (WebCore::SVGMarkerElement::SVGMarkerElement):
2728 * svg/SVGMarkerElement.h:
2729 * svg/SVGMaskElement.cpp:
2730 * svg/SVGMaskElement.h:
2731 (WebCore::SVGMaskElement::isValid):
2732 (WebCore::SVGMaskElement::needsPendingResourceHandling):
2733 * svg/SVGPatternElement.cpp:
2734 * svg/SVGPatternElement.h:
2735 (WebCore::SVGPatternElement::isValid):
2736 (WebCore::SVGPatternElement::needsPendingResourceHandling):
2737 * svg/SVGRadialGradientElement.cpp:
2738 * svg/SVGRadialGradientElement.h:
2739 * svg/SVGRectElement.cpp:
2740 * svg/SVGRectElement.h:
2741 (WebCore::SVGRectElement::isValid):
2742 * svg/SVGSVGElement.cpp:
2743 (WebCore::SVGSVGElement::SVGSVGElement):
2744 * svg/SVGSVGElement.h:
2745 (WebCore::SVGSVGElement::isValid):
2746 (WebCore::SVGSVGElement::setContainerSize):
2747 (WebCore::SVGSVGElement::containerSize):
2748 (WebCore::SVGSVGElement::hasSetContainerSize):
2749 (WebCore::SVGSVGElement::currentTranslate):
2750 (WebCore::SVGSVGElement::timeContainer):
2751 (WebCore::SVGSVGElement::isSVG):
2752 (WebCore::SVGSVGElement::rendererIsNeeded):
2753 * svg/SVGTextContentElement.cpp:
2754 * svg/SVGTextContentElement.h:
2755 (WebCore::SVGTextContentElement::isValid):
2756 (WebCore::SVGTextContentElement::isTextContent):
2757 * svg/SVGTextPathElement.cpp:
2758 * svg/SVGTextPathElement.h:
2759 * svg/SVGTextPositioningElement.h:
2760 * svg/SVGUseElement.cpp:
2761 * svg/SVGUseElement.h:
2762 (WebCore::SVGUseElement::isValid):
2763 (WebCore::SVGUseElement::setUpdatesBlocked):
2764 (WebCore::SVGUseElement::isPendingResource):
2765 * svg/properties/SVGAnimatedPropertyMacros.h:
2767 2010-12-01 Anton D'Auria <adauria@apple.com>
2769 Reviewed by Kevin Decker.
2771 Deny access to local and session storage in private browsing mode.
2772 https://bugs.webkit.org/show_bug.cgi?id=49329
2774 * storage/Storage.cpp:
2775 (WebCore::Storage::length):
2776 (WebCore::Storage::key):
2777 (WebCore::Storage::getItem):
2778 (WebCore::Storage::contains):
2780 2010-12-01 Philippe Normand <pnormand@igalia.com>
2782 Reviewed by Martin Robinson.
2784 Volume control not correctly initialized
2785 https://bugs.webkit.org/show_bug.cgi?id=36299
2787 Replaced the mute/volume Timers with g_timeouts which are (for
2788 now, at least) more reliable than Timers for one-shot-fire-now
2791 Test: media/video-volume.html
2793 * platform/graphics/MediaPlayer.cpp:
2794 (WebCore::MediaPlayer::~MediaPlayer): Reset the raw pointers to 0
2795 when destructing the player.
2796 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
2797 (WebCore::mediaPlayerPrivateVolumeChangeTimeoutCallback):
2798 (WebCore::mediaPlayerPrivateMuteChangeTimeoutCallback):
2799 (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
2800 (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVolumeChange):
2801 (WebCore::MediaPlayerPrivateGStreamer::volumeChanged):
2802 (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfMute):
2803 (WebCore::MediaPlayerPrivateGStreamer::muteChanged):
2804 (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Set
2805 playbin2 volume/mute base on MediaPlayer related values.
2806 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2808 2010-12-01 Patrick Gansterer <paroga@webkit.org>
2810 Reviewed by Andreas Kling.
2812 Cleanup main CMakeLists.txt after r72664, r72672 and r72667
2813 https://bugs.webkit.org/show_bug.cgi?id=50232
2815 * CMakeLists.txt: Removed obsolete dependencies.
2817 2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
2819 Reviewed by Dirk Schulze.
2821 Cleanup SVGPropertyTraits
2822 https://bugs.webkit.org/show_bug.cgi?id=50229
2824 Move all template specializations for non-POD types (eg. SVGLength, SVGLengthList, etc.) from SVGPropertyTraits
2825 into the right SVG* classes, to avoid having to include a dozen SVG*.h files in SVGPropertyTraits.h, which is
2826 included by all DOM/JS/V8 binding files and SVGElement.h.
2828 No new functionality, thus no new tests.
2833 * WebCore.xcodeproj/project.pbxproj:
2834 * bindings/scripts/CodeGenerator.pm:
2835 * bindings/scripts/CodeGeneratorObjC.pm:
2836 * bindings/scripts/CodeGeneratorV8.pm:
2839 * svg/SVGLengthList.h:
2840 * svg/SVGMarkerElement.h:
2841 * svg/SVGNumberList.h:
2842 * svg/SVGPatternElement.h:
2843 * svg/SVGPointList.h:
2844 * svg/SVGPreserveAspectRatio.h:
2845 * svg/SVGRect.h: Added.
2846 * svg/SVGSVGElement.h:
2847 * svg/SVGStringList.h:
2848 * svg/SVGSymbolElement.h:
2849 * svg/SVGTransformList.h:
2850 * svg/SVGViewElement.h:
2851 * svg/SVGViewSpec.h:
2852 * svg/properties/SVGListProperty.h:
2853 * svg/properties/SVGPropertyTraits.h:
2854 * svg/properties/SVGTransformListPropertyTearOff.h:
2856 2010-11-30 Kent Tamura <tkent@chromium.org>
2858 Reviewed by Darin Adler.
2860 Refactor HTMLInputElement: Move a part of HTMLInputElement::
2861 defaultEventHandler() to InputTypes
2862 https://bugs.webkit.org/show_bug.cgi?id=50097
2864 Move all of keyboard-related event handling to InputType.
2866 No new tests because this should not change any behavior.
2868 * html/BaseButtonInputType.cpp:
2869 (WebCore::BaseButtonInputType::handleKeydownEvent):
2870 (WebCore::BaseButtonInputType::handleKeypressEvent):
2871 (WebCore::BaseButtonInputType::handleKeyupEvent):
2872 * html/BaseButtonInputType.h:
2873 * html/BaseCheckableInputType.cpp:
2874 (WebCore::BaseCheckableInputType::handleKeydownEvent):
2875 (WebCore::BaseCheckableInputType::handleKeypressEvent):
2876 * html/BaseCheckableInputType.h:
2877 * html/CheckboxInputType.cpp:
2878 (WebCore::CheckboxInputType::handleKeyupEvent):
2879 * html/CheckboxInputType.h:
2880 * html/HTMLInputElement.cpp:
2881 (WebCore::HTMLInputElement::defaultEventHandler):
2882 We remove !implicitSubmission check for callBaseClassEarly because
2883 implicitSubmission can not be true for keydown event and keypress
2884 event at this point.
2885 * html/InputType.cpp:
2886 (WebCore::InputType::shouldSubmitImplicitly):
2887 Returns true for a keypress event with "\r". Note that we don't overload
2888 this function for BUTTON, FILE, IMAGE, RESET, and SUBMIT because a
2889 keypress event with "\r" for these types returns from HTMLInputElement::defaultEventHandler()
2890 before implicit submission checking.
2891 (WebCore::InputType::handleKeypressEvent):
2892 (WebCore::InputType::handleKeyupEvent):
2894 * html/RadioInputType.cpp:
2895 (WebCore::RadioInputType::handleKeydownEvent):
2896 (WebCore::RadioInputType::handleKeyupEvent):
2897 * html/RadioInputType.h:
2898 * html/TextFieldInputType.cpp:
2899 (WebCore::TextFieldInputType::shouldSubmitImplicitly):
2900 * html/TextFieldInputType.h:
2902 2010-11-30 Patrick Gansterer <paroga@webkit.org>
2904 Reviewed by Andreas Kling.
2906 Move CSS generator logic into main CMakeLists.txt file
2907 https://bugs.webkit.org/show_bug.cgi?id=50230
2911 2010-11-30 Ojan Vafai <ojan@chromium.org>
2913 Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
2914 https://bugs.webkit.org/show_bug.cgi?id=50288
2916 2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
2917 Reviewed by Darin Adler.
2918 Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
2919 https://bugs.webkit.org/show_bug.cgi?id=50182
2920 A display-isolated URL can only be displayed (e.g., put in an iframe,
2921 hyperlinked to) by documents from that scheme. In a sense, this is a
2922 generalization of some of the protections we give file URLs, but
2923 instead of lumping them all together into one "local" bucket, this
2924 patch creates a separate bucket for each scheme.
2925 For a while, I tried using a separate bucket for each origin. That
2926 would have played nicely with what Blob URLs are trying to do, but some
2927 "chrome" URL pages rely on being able to display other chrome URL
2928 pages, even in different origins. For example, the New Tab Page shows
2929 thumbnails from the "thumbnail" host.
2930 This patch also removes a bunch of unused code. I've also propagated
2931 the "deprecated" status of deprecatedCanDisplay to
2932 deprecatedShouldTreatURLAsLocal because that method has no other
2933 callers and is really asking for uppercase/lowercase bugs. I dream of
2934 someday removing these functions.
2935 page/SecurityOrigin.cpp:
2936 (WebCore::SecurityOrigin::canDisplay):
2937 (WebCore::SecurityOrigin::deprecatedCanDisplay):
2938 platform/SchemeRegistry.cpp:
2939 (WebCore::displayIsolatedURLSchemes):
2940 (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
2941 (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
2942 (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
2943 (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
2944 (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
2945 platform/SchemeRegistry.h:
2946 2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
2947 Reviewed by Darin Adler.
2948 Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
2949 https://bugs.webkit.org/show_bug.cgi?id=50182
2950 This patch adds a Chromium API for registering schemes as
2951 display-isolated. In a subsequent patch, I'll change the "chrome"
2952 scheme in Chrome to be display isolated instead of local. That will
2953 prevent file URLs from linking to chrome URLs.
2954 public/WebSecurityPolicy.h:
2955 src/WebSecurityPolicy.cpp:
2956 (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):
2958 * page/SecurityOrigin.cpp:
2959 (WebCore::SecurityOrigin::canDisplay):
2960 (WebCore::SecurityOrigin::deprecatedCanDisplay):
2961 * platform/SchemeRegistry.cpp:
2962 (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
2963 (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
2964 (WebCore::SchemeRegistry::localURLSchemes):
2965 (WebCore::SchemeRegistry::shouldTreatURLAsLocal):
2966 (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
2967 * platform/SchemeRegistry.h:
2969 2010-11-30 Chris Fleizach <cfleizach@apple.com>
2971 Reviewed by Beth Dakin.
2973 WebKit duplicates AXValue and AXDescription on abbr
2974 https://bugs.webkit.org/show_bug.cgi?id=50260
2976 stringValue() and accessibilityDescription() were returning the same value for static text with
2977 an aria-label. Static text elements should not have an accessibility description, they
2978 should only have a stringValue.
2980 Test: platform/mac/accessibility/static-text-with-aria-label.html
2982 * accessibility/AccessibilityRenderObject.cpp:
2983 (WebCore::AccessibilityRenderObject::ariaAccessibilityDescription):
2984 (WebCore::AccessibilityRenderObject::accessibilityDescription):
2985 (WebCore::AccessibilityRenderObject::text):
2986 * accessibility/AccessibilityRenderObject.h:
2988 2010-11-30 Ryosuke Niwa <rniwa@webkit.org>
2990 Reviewed by Darin Adler.
2992 [HTML5] Rename member variables of HTMLScriptElement
2993 https://bugs.webkit.org/show_bug.cgi?id=49705
2995 Renamed m_wasCreatedByParser to m_wasInsertedByParser, m_requested to m_isExternalScript,
2996 m_isEvaluated to m_wasAlreadyStarted, and m_firedLoad to m_haveFiredLoad.
2998 Also made ScriptElement's haveFiredLoadEvent and removed HTMLScriptElement's haveFiredLoadEvent.
2999 This effectively adds the same function to SVGScriptElement, which isn't currently used anywhere.
3001 No new tests are added since this is a refactoring.
3003 * dom/ScriptElement.cpp:
3004 (WebCore::ScriptElement::ScriptElement):
3005 (WebCore::ScriptElement::insertedIntoDocument):
3006 (WebCore::ScriptElement::childrenChanged):
3007 (WebCore::ScriptElement::finishParsingChildren):
3008 (WebCore::ScriptElement::requestScript):
3009 (WebCore::ScriptElement::evaluateScript):
3010 (WebCore::ScriptElement::executeScript):
3011 (WebCore::ScriptElement::ignoresLoadRequest):
3012 * dom/ScriptElement.h:
3013 (WebCore::ScriptElement::haveFiredLoadEvent):
3014 (WebCore::ScriptElement::setHaveFiredLoadEvent):
3015 (WebCore::ScriptElement::wasInsertedByParser):
3016 (WebCore::ScriptElement::wasAlreadyStarted):
3017 * html/HTMLScriptElement.cpp:
3018 (WebCore::HTMLScriptElement::HTMLScriptElement):
3019 (WebCore::HTMLScriptElement::create):
3020 (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren):
3021 * html/HTMLScriptElement.h:
3022 * svg/SVGScriptElement.cpp:
3023 (WebCore::SVGScriptElement::SVGScriptElement):
3024 (WebCore::SVGScriptElement::create):
3025 (WebCore::SVGScriptElement::svgAttributeChanged):
3026 (WebCore::SVGScriptElement::insertedIntoDocument):
3027 (WebCore::SVGScriptElement::dispatchLoadEvent):
3028 (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren):
3029 * svg/SVGScriptElement.h:
3031 2010-11-30 Darin Adler <darin@apple.com>
3033 Rolled back most of the FileReaderLoader changes to fix 32-bit builds.
3035 * fileapi/FileReaderLoader.cpp: Changed types back to unsigned from unsigned long long
3036 * fileapi/FileReaderLoader.h: Ditto.
3038 2010-11-30 Dan Bernstein <mitz@apple.com>
3040 Reviewed by Darin Adler.
3042 Text search should treat all matches as word-start matches when the target begins with a separator character
3043 https://bugs.webkit.org/show_bug.cgi?id=50302
3045 * editing/TextIterator.cpp:
3046 (WebCore::SearchBuffer::SearchBuffer): Disable the AtWordStarts option if it was specified and
3047 the target string begins with one of the "separator" characters.
3049 2010-11-30 Pavel Feldman <pfeldman@chromium.org>
3051 Reviewed by Dave Hyatt.
3053 Web Inspector: [CRASH] on "Revert to this revision" of style with import.
3054 https://bugs.webkit.org/show_bug.cgi?id=50256
3056 Rolled back one line from http://trac.webkit.org/changeset/36904 as agreed with
3059 * css/CSSImportRule.cpp:
3060 (WebCore::CSSImportRule::insertedIntoParent):
3062 2010-11-30 Martin Robinson <mrobinson@igalia.com>
3064 Reviewed by Xan Lopez.
3066 [GTK] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
3067 https://bugs.webkit.org/show_bug.cgi?id=50283
3069 Adjust the mask rectangle for Cairo shadows, so that the origin
3070 is not affected by the scale of the transformation matrix.
3072 * platform/graphics/ContextShadow.h: Make this Qt-only member global.
3073 * platform/graphics/cairo/ContextShadowCairo.cpp:
3074 (WebCore::ContextShadow::beginShadowLayer): Save the original layer area.
3075 (WebCore::ContextShadow::endShadowLayer): If the target context has a scale
3076 transform, make sure not to scale the blur distance when blitting the shadow.
3078 2010-11-30 Darin Adler <darin@apple.com>
3080 Reviewed by Alexey Proskuryakov.
3082 Make ProgressEvent 64-bit instead of 32-bit
3083 https://bugs.webkit.org/show_bug.cgi?id=50289
3085 * dom/ProgressEvent.cpp:
3086 (WebCore::ProgressEvent::ProgressEvent): Changed arguments to unsigned long long.
3087 (WebCore::ProgressEvent::initProgressEvent): Ditto.
3089 * dom/ProgressEvent.h: Fixed formatting. Changed types to unsigned long long.
3090 Made isProgressEvent override private.
3092 * dom/ProgressEvent.idl: Tweaked formatting and changed types to unsigned long long.
3094 * fileapi/FileReader.cpp: Removed unneeded includes.
3095 Used static on const so we'd get an error if the same constant was in a header.
3096 (WebCore::FileReader::didReceiveData): Removed unneeded WTF prefix.
3097 (WebCore::FileReader::fireEvent): Got rid of local variables that would narrow
3098 bytes loaded and total bytes to 32-bit.
3100 * fileapi/FileReaderLoader.cpp:
3101 (WebCore::FileReaderLoader::didReceiveResponse): Restructured code a bit and
3102 added comments. Also added handling for when ArrayBuffer::create returns 0.
3103 (WebCore::FileReaderLoader::didReceiveData): Fixed handling of case where more
3104 data arrives than is expected so it won't overrun the buffer. Also broke an
3105 assertion into two and improved a comment.
3107 * fileapi/FileReaderLoader.h: Changed bytesLoaded and totalBytes to unsigned long long.
3109 * fileapi/FileWriter.cpp:
3110 (WebCore::FileWriter::fireEvent): Removed narrowing casts in call to
3111 ProgressEvent::create.
3113 * html/canvas/ArrayBuffer.cpp:
3114 (WebCore::ArrayBuffer::tryAllocate): Added a comment because the code here seems wrong.
3116 * xml/XMLHttpRequest.cpp:
3117 (WebCore::XMLHttpRequest::didSendData): Removed narrowing casts in call to
3118 XMLHttpRequestProgressEvent::create.
3119 (WebCore::XMLHttpRequest::didReceiveData): Removed narrowing casts in call to
3120 dispatchProgressEvent.
3122 * xml/XMLHttpRequestProgressEvent.h: Fixed formatting. Changed types to unsigned long long.
3123 Made isXMLHttpRequestProgressEvent override private.
3125 * xml/XMLHttpRequestProgressEvent.idl: Tweaked formatting and changed types to unsigned long long.
3127 * xml/XMLHttpRequestProgressEventThrottle.cpp:
3128 (WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): Changed types to
3131 * xml/XMLHttpRequestProgressEventThrottle.h: Changed types to unsigned long long.
3133 2010-11-30 Yael Aharon <yael.aharon@nokia.com>
3135 Reviewed by Darin Adler.
3137 Progress and meter elements should take a form in their constructor like any other form control.
3138 https://bugs.webkit.org/show_bug.cgi?id=50195
3140 Tests: fast/dom/HTMLMeterElement/meter-element-form.html
3141 fast/dom/HTMLProgressElement/progress-element-form.html
3143 * html/HTMLMeterElement.cpp:
3144 (WebCore::HTMLMeterElement::HTMLMeterElement):
3145 (WebCore::HTMLMeterElement::create):
3146 * html/HTMLMeterElement.h:
3147 * html/HTMLProgressElement.h:
3148 * html/HTMLTagNames.in:
3150 2010-11-30 Tony Chang <tony@chromium.org>
3152 Reviewed by Adam Barth.
3154 [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
3155 https://bugs.webkit.org/show_bug.cgi?id=49036
3157 No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html
3159 In http://codereview.chromium.org/11574, the forked chromium test
3160 plugin changed how it testGetIntIdentifier to work around a change
3161 caused by a silverlight specific plugin fix:
3162 http://codereview.chromium.org/11569/diff/1/2
3164 It's not clear to me that this change is needed anymore since
3165 silverlight has had multiple releases, testing without this patch
3166 works on a test windows build, and safari win seems to run silverlight
3167 without this either. Since there's no test for this behavior, I'm
3168 rolling it out so we can match the upstream test.
3170 * bindings/v8/V8NPUtils.cpp:
3171 (WebCore::convertV8ObjectToNPVariant):
3173 2010-11-30 Chris Guillory <chris.guillory@google.com>
3175 Reviewed by Chris Fleizach.
3177 Computing style on a stale node while sending pending accessibility notification.
3178 https://bugs.webkit.org/show_bug.cgi?id=50162
3180 Retain node pointer members of AccessibilityImageMapLink.
3182 Test: accessibility/image-map-title-causes-crash.html
3184 * accessibility/AccessibilityImageMapLink.cpp:
3185 (WebCore::AccessibilityImageMapLink::parentObject):
3186 (WebCore::AccessibilityImageMapLink::anchorElement):
3187 (WebCore::AccessibilityImageMapLink::url):
3188 (WebCore::AccessibilityImageMapLink::elementRect):
3189 * accessibility/AccessibilityImageMapLink.h:
3190 (WebCore::AccessibilityImageMapLink::areaElement):
3191 (WebCore::AccessibilityImageMapLink::mapElement):
3192 (WebCore::AccessibilityImageMapLink::node):
3194 (WebCore::Document::clearAXObjectCache):
3196 2010-11-30 James Robinson <jamesr@chromium.org>
3198 Reviewed by Tony Chang.
3200 Build fix - add parens in foo || bar && baz to make gcc happy
3201 https://bugs.webkit.org/show_bug.cgi?id=50276
3203 gcc 4.4 warns that statements of the form "foo || bar && baz". It wants
3204 parens around the "bar && baz" part to make it clear which way the logical
3207 * editing/TextIterator.cpp:
3208 (WebCore::SearchBuffer::search):
3210 2010-11-30 Daniel Bates <dbates@rim.com>
3212 Reviewed by David Hyatt.
3214 Focused <area> should use CSS properties of <area> instead of associated <img>
3215 https://bugs.webkit.org/show_bug.cgi?id=49888
3217 Fixes an issue where the CSS properties of an <area> were not used when
3218 the <area> was focused.
3220 Currently, when focusing an <area> (say by pressing option + tab in Mac
3221 Safari) we use the CSS style information for the <img> associated with
3222 the <area>. Instead, we should use the CSS style information for the
3223 focused <area>. In particular, this will make the us honor the outline-
3224 color property of a focused <area> when drawing its focus ring.
3226 Tests: fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html
3227 fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html
3228 fast/images/imagemap-focus-ring-outline-color.html
3230 * rendering/RenderImage.cpp:
3231 (WebCore::RenderImage::paintFocusRing): Use the style information of
3232 the focused <area> when drawing the focus ring for it.
3234 2010-11-30 Tony Chang <tony@chromium.org>
3236 Reviewed by James Robinson.
3238 [chromium] enable WebCore compiler warnings on Linux take 3
3239 https://bugs.webkit.org/show_bug.cgi?id=50258
3241 * WebCore.gyp/WebCore.gyp:
3243 2010-11-30 Mario Sanchez Prada <msanchez@igalia.com>
3245 Reviewed by Chris Fleizach.
3247 [GTK] Implement ROLE_COMBO_BOX
3248 https://bugs.webkit.org/show_bug.cgi?id=25678
3250 Implement the remaining bits for combo boxes.
3252 This patch finishes the implementation, from the point of view of
3253 the Atk library, of those objects exposed to ATK as combo boxes,
3254 and their related elements (menus and menu items). It therefore
3255 implements the proper interfaces for each type of object related
3256 to combo boxes (AtkSelection for the combo box, AtkText for every
3257 menu item and AtkAction for the combo box, the menu and the menu
3258 items), takes care of emitting the proper signals when focus or a
3259 given a selection changes and adds a new unit test to check all
3262 Make possible to ask an AccessibleMenuListOption for a sensible
3263 string representation, so far only available through the private
3264 and MSAA related method nameForMSAA. Just moved the implementation
3265 of that method to an overriden version of stringValue(), which is
3266 platform independent, and called that from nameForMSAA().
3268 * accessibility/AccessibilityMenuListOption.h:
3269 * accessibility/AccessibilityMenuListOption.cpp:
3270 (WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to
3271 stringValue(), which holds from now on that used to be here.
3272 (WebCore::AccessibilityMenuListOption::stringValue): New, override
3273 of AccessibilityObject::stringValue() to return a proper string.
3275 Emit the missing signals when a selection is made.
3277 * accessibility/gtk/AXObjectCacheAtk.cpp:
3278 (WebCore::AXObjectCache::postPlatformNotification): Emit the usual
3279 'focus' signals when a selection is made over the combo box.
3281 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3282 (setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED
3283 Atk states are added to the state set when needed.
3284 (listObjectForSelection): New, returns the proper list object (the
3285 one holding the list of available options as its children) for an
3286 specific AtkObject implementing AtkSelection. This is needed
3287 because sometimes the selectable options are not directly children
3288 of the AtkSelection object (i.e. a combo box has a 'menu' object
3289 as its only child of it, holding the list of options as children).
3290 (optionFromList): Use listObjectForSelection() to get the actual
3291 object holding the list of children as the available options.
3292 (optionFromSelection): Add support for combo boxes.
3293 (webkit_accessible_selection_add_selection): Ditto.
3294 (webkit_accessible_selection_clear_selection): Ditto.
3295 (webkit_accessible_selection_get_selection_count): Ditto.
3296 (webkit_accessible_selection_is_child_selected): Ditto.
3297 (webkit_accessible_selection_remove_selection): Ditto.
3298 (webkit_accessible_text_get_text): Makes sure stringValue() is
3299 considered to get the result substring when it was already
3300 considered when checking the maximum text length for the object.
3301 (getInterfaceMaskFromObject): Make sure the AtkSelection interface
3302 is implemented for the combo boxes, that the AtkText is
3303 implemented for the menu items and that the AtkAction interface is
3304 now implemented for every object (WebCore will decide what to do).
3306 Avoid a segfault crash when using this from unit tests.
3308 * platform/gtk/PopupMenuGtk.cpp:
3309 (WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow
3310 before calling gdk_window_get_origin() over it.
3312 2010-11-30 Andreas Kling <kling@webkit.org>
3314 Reviewed by Tor Arne Vestbø.
3316 [Qt] GraphicsContext: Avoid unnecessarily copying the painter's QTransform
3318 Stash the transform in a const reference (QPainter::transform() returns one)
3319 instead of making a copy in the shadow drawing parts of fillPath, strokePath and fillRect.
3321 * platform/graphics/qt/GraphicsContextQt.cpp:
3322 (WebCore::GraphicsContext::fillPath):
3323 (WebCore::GraphicsContext::strokePath):
3324 (WebCore::GraphicsContext::fillRect):
3326 2010-11-30 Vangelis Kokkevis <vangelis@chromium.org>
3328 Reviewed by Simon Fraser.
3330 Provide more fine grained control to ports over when to turn on
3331 accelerated compositing.
3332 https://bugs.webkit.org/show_bug.cgi?id=49998
3334 The RenderLayerCompositor now checks with the chrome client whether
3335 3d transforms, video, plugins, canvas and animation require
3336 switching over to the composited path. Layers that overlap composited
3337 content will still turn into composited layers regardless of the
3340 * css/MediaQueryEvaluator.cpp:
3341 (WebCore::transform_3dMediaFeatureEval):
3342 * page/ChromeClient.h:
3343 (WebCore::ChromeClient::allowedCompositingTriggers):
3344 * rendering/RenderLayer.cpp:
3345 (WebCore::RenderLayer::canRender3DTransforms):
3346 (WebCore::RenderLayer::updateTransform):
3347 (WebCore::RenderLayer::currentTransform):
3348 * rendering/RenderLayer.h:
3349 * rendering/RenderLayerBacking.cpp:
3350 (WebCore::RenderLayerBacking::updateLayerTransform):
3351 * rendering/RenderLayerCompositor.cpp:
3352 (WebCore::RenderLayerCompositor::RenderLayerCompositor):
3353 (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
3354 (WebCore::RenderLayerCompositor::canRender3DTransforms):
3355 (WebCore::RenderLayerCompositor::requiresCompositingLayer):
3356 (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
3357 (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
3358 (WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
3359 (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
3360 (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
3361 * rendering/RenderLayerCompositor.h:
3363 2010-11-30 Xan Lopez <xlopez@igalia.com>
3365 Reviewed by Martin Robinson.
3367 [GTK] Plug leak in SoupCache
3368 https://bugs.webkit.org/show_bug.cgi?id=50142
3370 Free the cache file contents when we don't need them anymore.
3372 * platform/network/soup/cache/webkit/soup-cache.c:
3373 (webkit_soup_cache_load):
3375 2010-11-30 Andras Becsi <abecsi@webkit.org>
3377 Reviewed by Csaba Osztrogonác.
3379 [Qt][V8] Make QtWebKit with V8 build on Linux.
3380 https://bugs.webkit.org/show_bug.cgi?id=50244