<input type="range"> changing to disabled while active breaks all pointer events
[WebKit-https.git] / LayoutTests / ChangeLog
1 2017-04-05  Chris Dumez  <cdumez@apple.com>
2
3         <input type="range"> changing to disabled while active breaks all pointer events
4         https://bugs.webkit.org/show_bug.cgi?id=170447
5         <rdar://problem/31442875>
6
7         Reviewed by Geoffrey Garen.
8
9         Add layout test coverage.
10
11         * fast/forms/range/disabled-while-dragging-expected.txt: Added.
12         * fast/forms/range/disabled-while-dragging.html: Added.
13
14 2017-04-05  Jiewen Tan  <jiewen_tan@apple.com>
15
16         Unreviewed, rebasing crypto/subtle/rsa-import-key-malformed-parameters.html
17         <rdar://problem/31322400>
18
19         * crypto/subtle/rsa-import-key-malformed-parameters-expected.txt:
20         * crypto/subtle/rsa-import-key-malformed-parameters.html:
21
22 2017-04-05  Youenn Fablet  <youenn@apple.com>
23
24         Deprecate and remove URL.createObjectURL(mediastream)
25         https://bugs.webkit.org/show_bug.cgi?id=167518
26         <rdar://problem/31149607>
27
28         Reviewed by Eric Carlson.
29
30         * fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html:
31         * fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html:
32         * fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html:
33         * fast/mediastream/MediaStream-video-element-displays-buffer-expected.txt:
34         * fast/mediastream/MediaStream-video-element-displays-buffer.html:
35         * fast/mediastream/MediaStream-video-element-expected.txt:
36         * fast/mediastream/MediaStream-video-element-track-stop-expected.txt:
37         * fast/mediastream/MediaStream-video-element-track-stop.html:
38         * fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled-expected.txt:
39         * fast/mediastream/MediaStream-video-element-video-tracks-disabled.html:
40         * fast/mediastream/MediaStream-video-element.html:
41         * fast/mediastream/resources/getUserMedia-helper.js:
42         (setupVideoElementWithStream):
43
44 2017-04-05  Javier Fernandez  <jfernandez@igalia.com>
45
46         [GTK] Unreviewed tests gardening
47         https://bugs.webkit.org/show_bug.cgi?id=170497
48
49         Unreviewed test gardening. Rebaseline tests after r214712.
50
51         * platform/gtk/fast/multicol/table-vertical-align-expected.txt:
52
53
54 2017-04-04  Alexey Proskuryakov  <ap@apple.com>
55
56         Mark imported/w3c/web-platform-tests/fetch/api/response/response-trailer.html as flaky
57         for https://bugs.webkit.org/show_bug.cgi?id=170493
58
59         * platform/mac/TestExpectations:
60
61 2017-04-04  Youenn Fablet  <youenn@apple.com>
62
63         Canvas is tainted when painting a video with MediaStreamTrack
64         https://bugs.webkit.org/show_bug.cgi?id=170486
65
66         Reviewed by Eric Carlson.
67
68         * http/tests/media/media-stream/getusermedia-with-canvas-expected.txt: Added.
69         * http/tests/media/media-stream/getusermedia-with-canvas.html: Added.
70         * http/tests/media/media-stream/resources/getUserMedia-helper.js: Added.
71         (reject):
72         (getUserMedia):
73         (defaultRejectOrCatch):
74         (setupVideoElementWithStream):
75
76 2017-04-04  Youenn Fablet  <youenn@apple.com>
77
78         [Mac] Add back web audio support for getUserMedia MediaStreamTrack
79         https://bugs.webkit.org/show_bug.cgi?id=170482
80
81         Reviewed by Eric Carlson.
82
83         * TestExpectations:
84
85 2017-04-04  Ryan Haddad  <ryanhaddad@apple.com>
86
87         Mark fast/images/slower-animation-than-decoding-image.html as flaky.
88         https://bugs.webkit.org/show_bug.cgi?id=168390
89
90         Unreviewed test gardening.
91
92         * platform/mac/TestExpectations:
93
94 2017-04-04  Ryan Haddad  <ryanhaddad@apple.com>
95
96         Mark fast/images/reset-image-animation.html as flaky.
97         https://bugs.webkit.org/show_bug.cgi?id=170177
98
99         Unreviewed test gardening.
100
101         * platform/mac/TestExpectations:
102
103 2017-04-04  Ryan Haddad  <ryanhaddad@apple.com>
104
105         Mark media/modern-media-controls/airplay-button/airplay-button.html as flaky on mac-wk1 Release.
106         https://bugs.webkit.org/show_bug.cgi?id=168409
107
108         Unreviewed test gardening.
109
110         * platform/mac-wk1/TestExpectations:
111
112 2017-04-04  Brent Fulgham  <bfulgham@apple.com>
113
114         Do not assert when CharacterData representing an Attr fires events
115         https://bugs.webkit.org/show_bug.cgi?id=170454
116         <rdar://problem/30979320>
117
118         Reviewed by Ryosuke Niwa.
119
120         * fast/dom/no-assert-for-malformed-js-url-attribute-expected.txt: Added.
121         * fast/dom/no-assert-for-malformed-js-url-attribute.html: Added.
122
123 2017-04-04  Youenn Fablet  <youenn@apple.com>
124
125         LayoutTest webrtc/libwebrtc/descriptionGetters.html is a flaky failure
126         https://bugs.webkit.org/show_bug.cgi?id=169481
127
128         Reviewed by Eric Carlson.
129
130         * platform/mac-wk2/TestExpectations: Removing flaky expectation.
131         * webrtc/datachannel/basic.html:
132
133 2017-04-04  Ryan Haddad  <ryanhaddad@apple.com>
134
135         Add back results that were accidentally removed with r214848.
136         https://bugs.webkit.org/show_bug.cgi?id=169301
137
138         Unreviewed test gardening.
139
140         * platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.png: Added.
141         * platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
142
143 2017-04-04  Ryan Haddad  <ryanhaddad@apple.com>
144
145         Mark media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html as flaky.
146         https://bugs.webkit.org/show_bug.cgi?id=170456
147
148         Unreviewed test gardening.
149
150         * platform/mac-wk1/TestExpectations:
151
152 2017-04-04  Youenn Fablet  <youenn@apple.com>
153
154         webrtc/peer-connection-audio-mute.html is flaky
155         https://bugs.webkit.org/show_bug.cgi?id=170451
156
157         Reviewed by Eric Carlson.
158
159         * TestExpectations: Removed flaky expectation for webrtc/peer-connection-audio-mute.html.
160         * webrtc/peer-connection-remote-audio-mute.html: Added timer to ensure setting enable propagates.
161         Decreasing time spent at detecting hum or not.
162         * webrtc/peer-connection-remote-audio-mute2.html: Ditto (but keeping flakiness expectation for now).
163
164 2017-04-04  Ryan Haddad  <ryanhaddad@apple.com>
165
166         Mark fast/images/animated-gif-webkit-transform.html as flaky.
167         https://bugs.webkit.org/show_bug.cgi?id=170410
168
169         Unreviewed test gardening.
170
171         * platform/mac-wk2/TestExpectations:
172
173 2017-04-03  Alexey Proskuryakov  <ap@apple.com>
174
175         Re-adding flaky timeout expectation for http/tests/loading/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html
176
177         This test still times out, most of the time.
178
179         * platform/wk2/TestExpectations:
180
181 2017-04-03  Javier Fernandez  <jfernandez@igalia.com>
182
183         [css-align] Adapt place-content alignment shorthand to the new baseline syntax
184         https://bugs.webkit.org/show_bug.cgi?id=170340
185
186         Reviewed by David Hyatt.
187
188         Added additional test cases to evaluate the new baseline-alignment syntax.
189
190         * css3/parse-place-content-expected.txt:
191         * css3/parse-place-content.html:
192
193 2017-04-03  Nan Wang  <n_wang@apple.com>
194
195         AX: Expose link children when doing search predication on iOS
196         https://bugs.webkit.org/show_bug.cgi?id=170424
197         <rdar://problem/31413335>
198
199         Reviewed by Chris Fleizach.
200
201         * accessibility/ios-simulator/ios-search-predicate-link-children-expected.txt: Added.
202         * accessibility/ios-simulator/ios-search-predicate-link-children.html: Added.
203
204 2017-04-03  Dave Hyatt  <hyatt@apple.com>
205
206         Japanese fonts in vertical text should support synthesized italics
207         https://bugs.webkit.org/show_bug.cgi?id=169301
208
209         Reviewed by Simon Fraser.
210
211         * fast/text/international/synthesized-italic-vertical-expected.html:
212         * fast/text/international/synthesized-italic-vertical.html:
213         * platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.png: Removed.
214         * platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Removed.
215
216 2017-04-03  Chris Dumez  <cdumez@apple.com>
217
218         REGRESSION (r206744): CSS background-image in style attribute ignored when using createHTMLDocument method of DOM parsing
219         https://bugs.webkit.org/show_bug.cgi?id=170285
220         <rdar://problem/31378543>
221
222         Reviewed by Andy Estes.
223
224         Add layout test coverage.
225
226         * fast/images/background-image-relative-url-changes-document-expected.html: Added.
227         * fast/images/background-image-relative-url-changes-document.html: Added.
228
229 2017-04-03  John Wilander  <wilander@apple.com>
230
231         Remove timeout expectations after bug fix
232         https://bugs.webkit.org/show_bug.cgi?id=168262
233
234         Unreviewed test gardening.
235
236         Remove timeout expectations after bug fix in
237         https://bugs.webkit.org/show_bug.cgi?id=170400
238
239         * platform/wk2/TestExpectations:
240             Remove expected timeout for the first five test cases
241             under http/tests/loading/resourceLoadStatistics/.
242
243 2017-04-03  Antti Koivisto  <antti@apple.com>
244
245         REGRESSION (r207669): FileMaker Pro Help pages do not render correctly
246         https://bugs.webkit.org/show_bug.cgi?id=170402
247         <rdar://problem/31004344>
248
249         Reviewed by Simon Fraser.
250
251         * fast/css/document-stylesheets-dynamic-expected.html: Added.
252         * fast/css/document-stylesheets-dynamic.html: Added.
253
254 2017-04-03  Jeremy Jones  <jeremyj@apple.com>
255
256         LayoutTest pointer-lock/mouse-event-delivery.html is a flaky failure
257         https://bugs.webkit.org/show_bug.cgi?id=167965
258
259         Reviewed by Jon Lee.
260
261         Wait for wheel event before doing next step of test. The wheel event is delivered asynchronously and
262         can therefore be delivered later than expected by the test. This is already done for the first one,
263         do this for the second one also.
264
265         * platform/mac-wk2/TestExpectations:
266         * pointer-lock/mouse-event-delivery.html:
267
268 2017-04-01  Simon Fraser  <simon.fraser@apple.com>
269
270         Clean up touch event handler registration when moving nodes between documents
271         https://bugs.webkit.org/show_bug.cgi?id=170384
272         rdar://problem/30816694
273
274         Reviewed by Chris Dumez.
275
276         Tests for moving nodes with various listener/handler combinations between documents.
277
278         * fast/events/touch/ios/gesture-node-move-between-documents-expected.txt: Added.
279         * fast/events/touch/ios/gesture-node-move-between-documents.html: Added.
280         * fast/events/touch/ios/overflow-node-move-between-documents-expected.txt: Added.
281         * fast/events/touch/ios/overflow-node-move-between-documents.html: Added.
282         * fast/events/touch/ios/slider-node-move-between-documents-expected.txt: Added.
283         * fast/events/touch/ios/slider-node-move-between-documents.html: Added.
284         * fast/events/touch/ios/touch-node-move-between-documents-expected.txt: Added.
285         * fast/events/touch/ios/touch-node-move-between-documents.html: Added.
286
287 2017-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
288
289         [SOUP] URI Fragment is lost after redirect
290         https://bugs.webkit.org/show_bug.cgi?id=170058
291
292         Reviewed by Michael Catanzaro.
293
294         Add tests to check we correctly handle fragment identifiers on server redirections.
295
296         * http/tests/navigation/redirect-preserves-fragment-expected.txt: Added.
297         * http/tests/navigation/redirect-preserves-fragment.html: Added.
298         * http/tests/navigation/redirect-to-fragment-expected.txt: Added.
299         * http/tests/navigation/redirect-to-fragment.html: Added.
300         * http/tests/navigation/redirect-to-fragment2-expected.txt: Added.
301         * http/tests/navigation/redirect-to-fragment2.html: Added.
302         * http/tests/navigation/resources/redirect-preserves-fragment.php: Added.
303         * http/tests/navigation/resources/redirect-to-fragment.php: Added.
304         * http/tests/navigation/resources/redirect-to-fragment2.php: Added.
305         * platform/ios/TestExpectations:
306         * platform/mac/TestExpectations:
307
308 2017-04-03  Youenn Fablet  <youenn@apple.com>
309
310         captureStream is getting black frames with webgl canvas
311         https://bugs.webkit.org/show_bug.cgi?id=170325
312
313         Reviewed by Dean Jackson.
314
315         * fast/mediastream/captureStream/canvas3d-expected.txt: Added.
316         * fast/mediastream/captureStream/canvas3d.html: Added.
317
318 2017-04-03  Per Arne Vollan  <pvollan@apple.com>
319
320         Implement stroke-miterlimit.
321         https://bugs.webkit.org/show_bug.cgi?id=169078
322
323         Reviewed by Dean Jackson.
324
325         * fast/css/stroke-miterlimit-default-expected.html: Added.
326         * fast/css/stroke-miterlimit-default.html: Added.
327         * fast/css/stroke-miterlimit-large-expected-mismatch.html: Added.
328         * fast/css/stroke-miterlimit-large.html: Added.
329         * fast/css/stroke-miterlimit-zero-expected-mismatch.html: Added.
330         * fast/css/stroke-miterlimit-zero.html: Added.
331
332 2017-04-02  Alexey Proskuryakov  <ap@apple.com>
333
334         Remove accidentally added DumpJSConsoleLogInStdErr from http/tests/fetch/fetch-in-worker-crash.html expectation.
335
336         * TestExpectations:
337
338 2017-04-02  Alexey Proskuryakov  <ap@apple.com>
339
340         Build fix for
341         Add missing text styles
342         https://bugs.webkit.org/show_bug.cgi?id=170295
343
344         * platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt:
345
346 2017-04-02  Alexey Proskuryakov  <ap@apple.com>
347
348         Fix lint errors.
349
350         * TestExpectations:
351         * platform/ios-wk1/TestExpectations:
352         * platform/ios-wk2/TestExpectations:
353         * platform/ios/TestExpectations:
354         * platform/mac-wk1/TestExpectations:
355
356 2017-04-02  Alexey Proskuryakov  <ap@apple.com>
357
358         Mark http/tests/fetch/fetch-in-worker-crash.html and imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-status.html as flaky.
359
360         For https://bugs.webkit.org/show_bug.cgi?id=170395
361         rdar://problem/30975761, rdar://problem/31394017
362
363         * TestExpectations:
364
365 2017-04-01  Per Arne Vollan  <pvollan@apple.com>
366
367         Add test for expected fallback behavior between stroke-width and -webkit-text-stroke-width.
368         https://bugs.webkit.org/show_bug.cgi?id=169466
369
370         Reviewed by Jon Lee.
371
372         Now that we have added support for stroke-width, we should have a test for expected fallback behavior between
373         stroke-width and -webkit-text-stroke-width. Currently, stroke-width is always preferred, also when inherited,
374         and when -webkit-text-stroke-width is declared inline. When stroke-width is not specified, we fall back to
375         -webkit-text-stroke-width.
376
377         * fast/css/stroke-width-fallback-expected.html: Added.
378         * fast/css/stroke-width-fallback.html: Added.
379
380 2017-04-01  Jon Lee  <jonlee@apple.com>
381
382         Add missing text styles
383         https://bugs.webkit.org/show_bug.cgi?id=170295
384         rdar://problem/30219503
385
386         Reviewed by Dean Jackson.
387
388         * platform/ios/ios/fast/text/opticalFontWithTextStyle.html: Update test to include title0 and title4.
389
390 2017-04-01  Chris Dumez  <cdumez@apple.com>
391
392         We should pause silent WebAudio rendering in background tabs
393         https://bugs.webkit.org/show_bug.cgi?id=170299
394         <rdar://problem/31289132>
395
396         Reviewed by Eric Carlson.
397
398         Add layout test coverage.
399
400         * webaudio/silent-audio-interrupted-in-background-expected.txt: Added.
401         * webaudio/silent-audio-interrupted-in-background.html: Added.
402
403 2017-04-01  Alexey Proskuryakov  <ap@apple.com>
404
405         Rolling back http://trac.webkit.org/r214663 - memory corruption
406
407         * streams/readable-stream-byob-request-expected.txt:
408         * streams/readable-stream-byob-request.js:
409         (self.importScripts.test): Deleted.
410
411 2017-03-31  Zalan Bujtas  <zalan@apple.com>
412
413         <table>: Including <caption>, <thead> or <tbody> causes clipping across page breaks
414         https://bugs.webkit.org/show_bug.cgi?id=170348
415         <rdar://problem/24727151>
416
417         Reviewed by David Hyatt.
418
419         * fast/multicol/table-section-page-break-expected.html: Added.
420         * fast/multicol/table-section-page-break.html: Added.
421
422 2017-03-31  Chris Dumez  <cdumez@apple.com>
423
424         LayoutTest fast/images/animated-gif-restored-from-bfcache.html is a flaky failure
425         https://bugs.webkit.org/show_bug.cgi?id=162510
426         <rdar://problem/31380650>
427
428         Reviewed by Alexey Proskuryakov.
429
430         The test restores a page from PageCache and wants to check that an animated
431         GIF is properly animating. To do so, it store the data of the current image
432         frame, and then checks in a 100ms timer that the current image frame is
433         different. This is flaky by nature since the image only has 10 frames and
434         you therefore have a 1/10 chance that the new frame will be the same as the
435         previous one, even if the image is properly animating.
436
437         To address the problem, do a setInterval instead of a setTimeout and check
438         until the frame becomes different.
439
440         * fast/images/animated-gif-restored-from-bfcache.html:
441         * platform/mac/TestExpectations:
442
443 2017-03-31  Wenson Hsieh  <wenson_hsieh@apple.com>
444
445         [WK2] Tapping away to dismiss the selection does not update the selected DOM range using character granularity
446         https://bugs.webkit.org/show_bug.cgi?id=170328
447         <rdar://problem/30904558>
448
449         Reviewed by Tim Horton.
450
451         Adds a new layout test verifying that when a user taps away to clear the current selection in character
452         granularity selection mode, the selected DOM range in the web process does not fall out of sync with UIKit's
453         selection views, which are dismissed.
454
455         * editing/selection/character-granularity-selected-range-after-dismissing-selection-expected.txt: Added.
456         * editing/selection/character-granularity-selected-range-after-dismissing-selection.html: Added.
457
458 2017-03-31  Youenn Fablet  <youenn@apple.com>
459
460         Add a test to ensure webrtc generated certificates and names are ephemeral
461         https://bugs.webkit.org/show_bug.cgi?id=170225
462
463         Reviewed by Jon Lee.
464
465         * webrtc/ephemeral-certificates-and-cnames-expected.txt: Added.
466         * webrtc/ephemeral-certificates-and-cnames.html: Added.
467
468 2017-03-31  Wenson Hsieh  <wenson_hsieh@apple.com>
469
470         [WK2] Tapping editable text inside of a range selection no longer changes the selection to a caret
471         https://bugs.webkit.org/show_bug.cgi?id=170327
472         <rdar://problem/31363816>
473
474         Reviewed by Tim Horton.
475
476         Adds a new WK2 interaction test for iOS verifying that tapping a selection in editable content sets the selection
477         to a caret, rather than maintaining the range selection. This test is disabled in OpenSource, since it relies on
478         synthetic touch events.
479
480         * TestExpectations:
481         * editing/selection/caret-after-tap-in-editable-selection-expected.txt: Added.
482         * editing/selection/caret-after-tap-in-editable-selection.html: Added.
483
484 2017-03-31  Alexey Proskuryakov  <ap@apple.com>
485
486         Mark fast/mediastream/MediaStream-page-muted.html as flaky for
487         https://bugs.webkit.org/show_bug.cgi?id=170355
488
489         * TestExpectations:
490
491 2017-03-31  Alexey Proskuryakov  <ap@apple.com>
492
493         Correction for the previous change - this is an image failure.
494
495         * platform/mac-wk2/TestExpectations:
496
497 2017-03-31  Alexey Proskuryakov  <ap@apple.com>
498
499         Mark fast/images/animated-image-different-dest-size.html as flaky for
500         https://bugs.webkit.org/show_bug.cgi?id=170203
501
502         * platform/mac-wk2/TestExpectations:
503
504 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
505
506         Unreviewed GTK+ gardening. Update expectations of several tests.
507
508         Also rebaseline fast/css/getComputedStyle/computed-style-font-family.html after r214394, it also requires variation
509         fonts.
510
511         * platform/gtk/TestExpectations:
512         * platform/gtk/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
513
514 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
515
516         Unreviewed GTK+ gardening. Rebaseline several tests after r214546.
517
518         GTK+ port doesn't support variation fonts. Also mark canvas/philip/tests/2d.pattern.animated.gif.html as failing
519         after r214503.
520
521         * platform/gtk/TestExpectations:
522         * platform/gtk/fast/text/font-selection-font-loading-api-parse-expected.txt: Added.
523         * platform/gtk/fast/text/font-stretch-parse-expected.txt: Added.
524         * platform/gtk/fast/text/font-style-parse-expected.txt: Added.
525         * platform/gtk/fast/text/font-weight-parse-expected.txt: Added.
526
527 2017-03-31  Romain Bellessort  <romain.bellessort@crf.canon.fr>
528
529         [Readable Streams API] Implement cloneArrayBuffer in WebCore
530         https://bugs.webkit.org/show_bug.cgi?id=170008
531
532         Reviewed by Youenn Fablet.
533
534         Added test to check cloneArrayBuffer behaviour. 
535
536         * streams/readable-stream-byob-request.js:
537
538 2017-03-31  Oleksandr Skachkov  <gskachkov@gmail.com>
539
540         String.prototype.replace incorrectly applies "special replacement parameters" when passed a function
541         https://bugs.webkit.org/show_bug.cgi?id=170151
542
543         Reviewed by Saam Barati.
544
545         * js/script-tests/string_replace_function.js: Added.
546         * js/script-tests/string_replace_regexp.js: Renamed from LayoutTests/js/script-tests/string_replace.js.
547         * js/string_replace_function-expected.txt: Added.
548         * js/string_replace_function.html: Copied from LayoutTests/js/string_replace.html.
549         * js/string_replace_regexp-expected.txt: Renamed from LayoutTests/js/string_replace-expected.txt.
550         * js/string_replace_regexp.html: Renamed from LayoutTests/js/string_replace.html.
551
552 2017-03-31  Manuel Rego Casasnovas  <rego@igalia.com>
553
554         [css-grid] Update W3C Test Suite
555         https://bugs.webkit.org/show_bug.cgi?id=170170
556
557         Reviewed by Youenn Fablet.
558
559         Update path to tests in TestExpectations as the CSS Grid Layout suite
560         is now under web-platform-tests.
561
562         * TestExpectations:
563
564 2017-03-31  Antoine Quint  <graouts@apple.com>
565
566         [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
567         https://bugs.webkit.org/show_bug.cgi?id=168409
568         <rdar://problem/30799198>
569
570         Unreviewed. Capture new logging events.
571
572         * media/modern-media-controls/airplay-button/airplay-button.html:
573
574 2017-03-30  Matt Baker  <mattbaker@apple.com>
575
576         Unreviewed. Update test expectations after https://bugs.webkit.org/show_bug.cgi?id=170279.
577
578         * inspector/css/getAllStyleSheets-expected.txt:
579
580 2017-03-30  Ryan Haddad  <ryanhaddad@apple.com>
581
582         Rebaseline js/dom/global-constructors-attributes.html.
583
584         Unreviewed test gardening.
585
586         * platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
587         * platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
588         * platform/mac/js/dom/global-constructors-attributes-expected.txt:
589
590 2017-03-30  Simon Fraser  <simon.fraser@apple.com>
591
592         Rename a touch event function, and new touch region test results
593         https://bugs.webkit.org/show_bug.cgi?id=170309
594         rdar://problem/31329520
595
596         Reviewed by Chris Dumez.
597
598         A code change in WebKitAdditions progresses this test result.
599
600         * fast/events/touch/ios/touch-event-regions/iframes-expected.txt:
601
602 2017-03-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
603
604         REGRESSION (r213764): Background image from sprite sheet incorrectly scaled
605         https://bugs.webkit.org/show_bug.cgi?id=169547
606
607         Reviewed by Simon Fraser.
608
609         * fast/images/async-image-background-image.html:
610         * fast/images/resources/sprite-sheet-red-green-blue.png: Added.
611         * fast/images/sprite-sheet-image-draw-expected.html: Added.
612         * fast/images/sprite-sheet-image-draw.html: Added.
613
614 2017-03-30  Matt Baker  <mattbaker@apple.com>
615
616         Web Inspector: Assertion failure in InspectorStyleProperty::setRawTextFromStyleDeclaration
617         https://bugs.webkit.org/show_bug.cgi?id=170279
618         <rdar://problem/30200492>
619
620         Reviewed by David Hyatt.
621
622         * inspector/css/getAllStyleSheets.html:
623         Add stylesheet with an "unparsed" property having no final semicolon.
624
625 2017-03-30  Youenn Fablet  <youenn@apple.com>
626
627         Clean up RTCDataChannel
628         https://bugs.webkit.org/show_bug.cgi?id=169732
629
630         Reviewed by Chris Dumez.
631
632         * webrtc/datachannel/bufferedAmountLowThreshold-expected.txt: Added.
633         * webrtc/datachannel/bufferedAmountLowThreshold.html: Added.
634
635 2017-03-30  Chris Dumez  <cdumez@apple.com>
636
637         svg/animations/animations-paused-in-background-page.html is flaky
638         https://bugs.webkit.org/show_bug.cgi?id=170290
639
640         Reviewed by Simon Fraser.
641
642         Fix shouldBecomeEqual() check in the test which was wrong and was passing by chance
643         due to a race.
644
645         * svg/animations/animations-paused-in-background-page-expected.txt:
646         * svg/animations/animations-paused-in-background-page.html:
647
648 2017-03-30  Javier Fernandez  <jfernandez@igalia.com>
649
650         [css-align] Adapt content-alignment properties to the new baseline syntax
651         https://bugs.webkit.org/show_bug.cgi?id=170262
652
653         Reviewed by David Hyatt.
654
655         Added new cases to the alignment properties parsing tests so that we can verify the new
656         baseline-alignment syntax is parsed as expected.
657         Additionally, I modified the tests so that they use the testharness format.
658
659         * css3/parse-align-content-expected.txt:
660         * css3/parse-align-content.html:
661         * css3/parse-justify-content-expected.txt:
662         * css3/parse-justify-content.html:
663
664 2017-03-30  James Craig  <jcraig@apple.com>
665
666         AX: Expose a new AXSubrole for explicit ARIA "group" role
667         https://bugs.webkit.org/show_bug.cgi?id=169810
668         <rdar://problem/31039693>
669
670         Reviewed by Chris Fleizach.
671
672         * accessibility/list-detection2-expected.txt:
673         * accessibility/list-detection2.html:
674         * accessibility/roles-computedRoleString.html:
675         * inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
676         * inspector/dom/highlightFrame-expected.txt:
677         * inspector/dom/highlightSelector-expected.txt:
678         * platform/mac/accessibility/roles-computedRoleString-expected.txt:
679         * platform/mac/accessibility/roles-exposed-expected.txt:
680
681 2017-03-30  Youenn Fablet  <youenn@apple.com>
682
683         webrtc/video-stats.html and webrtc/video-replace-track.html are flaky
684         https://bugs.webkit.org/show_bug.cgi?id=170294
685
686         Unreviewed.
687
688         * TestExpectations: Marking these tests as flaky.
689
690 2017-03-30  Eric Carlson  <eric.carlson@apple.com>
691
692         [Crash] WebCore::AudioBuffer::AudioBuffer don't checking illegal value
693         https://bugs.webkit.org/show_bug.cgi?id=169956
694
695         Reviewed by Youenn Fablet.
696
697         * webaudio/audiobuffer-crash-expected.txt: Added.
698         * webaudio/audiobuffer-crash.html: Added.
699
700 2017-03-30  Simon Fraser  <simon.fraser@apple.com>
701
702         Add some tests that dump the touch event regions with various content configurations
703         https://bugs.webkit.org/show_bug.cgi?id=170216
704
705         Followup: add missing results files, and tweak iframes.html to show that regions fail to
706         take iframe borders into account.
707
708         * fast/events/touch/ios/touch-event-regions/active-passive-nesting-expected.txt: Added.
709         * fast/events/touch/ios/touch-event-regions/columns-expected.txt: Added.
710         * fast/events/touch/ios/touch-event-regions/complex-expected.txt: Added.
711         * fast/events/touch/ios/touch-event-regions/document-expected.txt: Added.
712         * fast/events/touch/ios/touch-event-regions/iframes-expected.txt: Added.
713         * fast/events/touch/ios/touch-event-regions/iframes.html:
714         * fast/events/touch/ios/touch-event-regions/overflow-expected.txt: Added.
715         * fast/events/touch/ios/touch-event-regions/range-sliders-expected.txt: Added.
716
717 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
718
719         [mac-wk1 debug] LayoutTest media/track/track-cue-rendering-with-padding.html is a flaky timeout
720         https://bugs.webkit.org/show_bug.cgi?id=170188
721
722         Reviewed by Eric Carlson.
723
724         The textTrackDisplayElement call will fail and throw an exception if the text track display element
725         has not yet been added to the text track container element. We wait until it has been added.
726
727         * media/track/track-cue-rendering-with-padding.html:
728
729 2017-03-30  Antoine Quint  <graouts@apple.com>
730
731         [Modern Media Controls] Invalid placard icon is not visible for short video
732         https://bugs.webkit.org/show_bug.cgi?id=170277
733         <rdar://problem/31327955>
734
735         Reviewed by Eric Carlson.
736
737         Add a new test to check that we correctly hide the invalid icon only when
738         there is no space left to display it.
739
740         * media/modern-media-controls/invalid-placard/invalid-placard-constrained-metrics-expected.txt: Added.
741         * media/modern-media-controls/invalid-placard/invalid-placard-constrained-metrics.html: Added.
742
743 2017-03-27  Sergio Villar Senin  <svillar@igalia.com>
744
745         [css-grid] Clamp the number of autorepeat tracks
746         https://bugs.webkit.org/show_bug.cgi?id=170120
747
748         Reviewed by Manuel Rego Casasnovas.
749
750         Added a new test to check the clamping of grid tracks. It's mostly all JavaScript in order
751         to allow us to run several test cases over a small number of grids in a single file quite
752         fast. The other option was to statically (CSS) create several huge grids, something that
753         could potentially be very expensive in terms of memory and CPU leading to timeouts.
754
755         * fast/css-grid-layout/grid-auto-repeat-huge-grid-expected.txt: Added.
756         * fast/css-grid-layout/grid-auto-repeat-huge-grid.html: Added.
757
758 2017-03-30  Antoine Quint  <graouts@apple.com>
759
760         [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
761         https://bugs.webkit.org/show_bug.cgi?id=168409
762         <rdar://problem/30799198>
763
764         Unreviewed. Add logging related to visibility since document.visibility = hidden would cause the
765         requestAnimationFrame() call to suspend the ScriptedAnimationController.
766
767         * media/modern-media-controls/airplay-button/airplay-button.html:
768
769 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
770
771         REGRESSION(~r212322): LayoutTest media/track/track-cue-container-rendering-position.html is a flaky timeout
772         https://bugs.webkit.org/show_bug.cgi?id=168660
773
774         Reviewed Eric Carlson.
775
776         The textTrackDisplayElement call will fail and throw an exception if the text track display element
777         has not yet been added to the text track container element. We wait until it has been added.
778
779         * media/track/track-cue-container-rendering-position.html:
780
781 2017-03-29  Ryosuke Niwa  <rniwa@webkit.org>
782
783         Disconnecting a HTMLObjectElement does not always unload its content document
784         https://bugs.webkit.org/show_bug.cgi?id=169606
785
786         Reviewed by Andy Estes.
787
788         Add a regression test.
789
790         * fast/dom/removing-focused-object-element-expected.txt: Added.
791         * fast/dom/removing-focused-object-element.html: Added.
792
793 2017-03-29  Simon Fraser  <simon.fraser@apple.com>
794
795         Add some tests that dump the touch event regions with various content configurations
796         https://bugs.webkit.org/show_bug.cgi?id=170216
797
798         Reviewed by Dean Jackson.
799
800         Tests for touch event regions. Some of these are modeled after tests in tiled-drawing/scrolling/non-fast-region/.
801
802         * fast/events/touch/ios/touch-event-regions/resources/touch-regions-helper.js: Added.
803         * fast/events/touch/ios/touch-event-regions/active-passive-nesting-expected.html: Added.
804         * fast/events/touch/ios/touch-event-regions/active-passive-nesting.html: Added.
805         * fast/events/touch/ios/touch-event-regions/columns-expected.txt: Added.
806         * fast/events/touch/ios/touch-event-regions/columns.html: Added.
807         * fast/events/touch/ios/touch-event-regions/complex-expected.txt: Added.
808         * fast/events/touch/ios/touch-event-regions/complex.html: Added.
809         * fast/events/touch/ios/touch-event-regions/document-expected.txt: Added.
810         * fast/events/touch/ios/touch-event-regions/document.html: Added.
811         * fast/events/touch/ios/touch-event-regions/iframes-expected.txt: Added.
812         * fast/events/touch/ios/touch-event-regions/iframes.html: Added.
813         * fast/events/touch/ios/touch-event-regions/overflow-expected.txt: Added.
814         * fast/events/touch/ios/touch-event-regions/overflow.html: Added.
815         * fast/events/touch/ios/touch-event-regions/range-sliders-expected.txt: Added.
816         * fast/events/touch/ios/touch-event-regions/range-sliders.html: Added.
817
818 2017-03-28  Simon Fraser  <simon.fraser@apple.com>
819
820         Make it possible to dump touch event regions for testing
821         https://bugs.webkit.org/show_bug.cgi?id=170209
822         <rdar://problem/31309258>
823
824         Reviewed by Tim Horton.
825
826         Simple test that dumps the regions.
827
828         * fast/events/touch/ios/touch-event-regions-expected.txt: Added.
829         * fast/events/touch/ios/touch-event-regions.html: Added.
830
831 2017-03-29  Zalan Bujtas  <zalan@apple.com>
832
833         RenderBlockFlow::addFloatsToNewParent should check if float is already added to the object list.
834         https://bugs.webkit.org/show_bug.cgi?id=170259
835         <rdar://problem/31300584>
836
837         Reviewed by Simon Fraser.
838
839         * fast/block/float/placing-multiple-floats-crash-expected.txt: Added.
840         * fast/block/float/placing-multiple-floats-crash.html: Added.
841
842 2017-03-29  Tim Horton  <timothy_horton@apple.com>
843
844         Swipe gesture tests don't work on macOS Sierra
845         https://bugs.webkit.org/show_bug.cgi?id=161675
846         <rdar://problem/23379930>
847
848         Reviewed by Darin Adler.
849
850         * platform/mac-wk2/TestExpectations:
851         * swipe/basic-cached-back-swipe-expected.txt:
852         * swipe/basic-cached-back-swipe.html:
853         * swipe/main-frame-pinning-requirement-expected.txt:
854         * swipe/main-frame-pinning-requirement.html:
855         * swipe/pushState-cached-back-swipe-expected.txt:
856         * swipe/pushState-cached-back-swipe.html:
857         * swipe/pushState-programmatic-back-while-swiping-crash-expected.txt:
858         * swipe/pushState-programmatic-back-while-swiping-crash.html:
859         * swipe/resources/swipe-test.js:
860         (measuredDurationShouldBeLessThan):
861         (startSwipeGesture):
862         (completeSwipeGesture):
863         (playEventStream):
864         (eventQueue.enqueueScrollEvent): Deleted.
865         (eventQueue.enqueueSwipeEvent): Deleted.
866         (eventQueue.hasPendingEvents): Deleted.
867         (eventQueue.callAfterEventDispatch): Deleted.
868         (eventQueue._processEventQueue): Deleted.
869         (eventQueue._processEventQueueSoon): Deleted.
870         * swipe/swipe-start-hysteresis-failures-expected.txt: Removed.
871         * swipe/swipe-start-hysteresis-failures.html: Removed.
872
873 2017-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
874
875         Try to normalize variation ranges
876         https://bugs.webkit.org/show_bug.cgi?id=170119
877
878         Reviewed by Simon Fraser.
879
880         * fast/text/variations/font-selection-properties-expected.html:
881
882 2017-03-29  Ryan Haddad  <ryanhaddad@apple.com>
883
884         Mark http/tests/media/modern-media-controls/time-labels-support/long-time.html as flaky on macOS.
885         https://bugs.webkit.org/show_bug.cgi?id=169677
886
887         Unreviewed test gardening.
888
889         * platform/mac-wk1/TestExpectations:
890         * platform/mac/TestExpectations:
891
892 2017-03-29  Javier Fernandez  <jfernandez@igalia.com>
893
894         [css-align] Adapt self-alignment properties to the new baseline syntax
895         https://bugs.webkit.org/show_bug.cgi?id=170235
896
897         Reviewed by David Hyatt.
898
899         Added new cases to the alignment properties parsing tests so that we can verify the new
900         baseline-alignment syntax is parsed as expected.
901         Additionally, I modified the tests so that they use the testharness format.
902
903         * css3/parse-align-items-expected.txt:
904         * css3/parse-align-items.html:
905         * css3/parse-align-self-expected.txt:
906         * css3/parse-align-self.html:
907         * css3/resources/alignment-parsing-utils-th.js:
908         (checkValues):
909         * fast/css/parse-justify-items-expected.txt:
910         * fast/css/parse-justify-items.html:
911         * fast/css/parse-justify-self-expected.txt:
912         * fast/css/parse-justify-self.html:
913         * fast/css/resources/alignment-parsing-utils-th.js: Copied from LayoutTests/css3/resources/alignment-parsing-utils-th.js.
914         (checkValues):
915         (checkBadValues):
916         (checkInitialValues):
917         (checkInheritValues):
918         (checkLegacyValues):
919         (checkSupportedValues):
920
921 2017-03-29  Chris Dumez  <cdumez@apple.com>
922
923         Animated SVG images are not paused in pages loaded in the background
924         https://bugs.webkit.org/show_bug.cgi?id=170043
925         <rdar://problem/31234412>
926
927         Reviewed by Simon Fraser.
928
929         Extend layout test coverage.
930
931         * svg/animations/animations-paused-in-background-page-expected.txt: Added.
932         * svg/animations/animations-paused-in-background-page-iframe-expected.txt: Added.
933         * svg/animations/animations-paused-in-background-page-iframe.html: Added.
934         * svg/animations/animations-paused-in-background-page.html: Added.
935         * svg/animations/resources/iframe-with-animated-svg-image.html: Added.
936
937 2017-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
938
939         Post-commit test gardening after r214546
940         https://bugs.webkit.org/show_bug.cgi?id=169518
941
942         Unreviewed.
943
944         * platform/mac-elcapitan/fast/text/font-selection-font-loading-api-parse-expected.txt:
945         * platform/mac-elcapitan/fast/text/font-style-parse-expected.txt:
946
947 2017-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
948
949         Post-commit test gardening after r214546
950         https://bugs.webkit.org/show_bug.cgi?id=169518
951
952         Unreviewed.
953
954         * platform/mac-elcapitan/fast/text/font-selection-font-loading-api-parse-expected.txt:
955         * platform/mac-elcapitan/fast/text/font-style-parse-expected.txt:
956
957 2017-03-29  Ryan Haddad  <ryanhaddad@apple.com>
958
959         Mark fast/events/before-unload-adopt-subframe-to-outside.html as flaky.
960         https://bugs.webkit.org/show_bug.cgi?id=170130
961
962         Unreviewed test gardening.
963
964         * TestExpectations:
965
966 2017-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
967
968         Variation fonts: Make sure that feature detection and preprocessor macros are right
969         https://bugs.webkit.org/show_bug.cgi?id=169518
970
971         Reviewed by Simon Fraser.
972
973         Create platform-specific results for mac-elcapitan which doesn't support variation fonts.
974
975         * fast/text/font-variations-feature-detection-expected.html: Added.
976         * fast/text/font-variations-feature-detection.html: Added.
977         * platform/ios-simulator/TestExpectations:
978         * platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:
979         * platform/mac-elcapitan/fast/text/font-selection-font-loading-api-parse-expected.txt: Added.
980         * platform/mac-elcapitan/fast/text/font-stretch-parse-expected.txt: Added.
981         * platform/mac-elcapitan/fast/text/font-style-parse-expected.txt: Added.
982         * platform/mac-elcapitan/fast/text/font-weight-parse-expected.txt: Added.
983         * platform/mac/TestExpectations:
984
985 2017-03-29  Antoine Quint  <graouts@apple.com>
986
987         [Modern Media Controls] Controls bar may disappear while captions menu is visible (redux)
988         https://bugs.webkit.org/show_bug.cgi?id=170239
989         <rdar://problem/31320685>
990
991         Reviewed by Dean Jackson.
992
993         We extend an existing test to cover the case where we would hide the controls bar while the tracks panel
994         is up by mousing out of the media. We also add a new test where we check that clicking over the controls
995         bar to dismiss the tracks panel does not hide the controls bar. Finally, we make a small change to an
996         existing test to listen to "transitionend" event on the tracks panel specifically since with this patch
997         the controls bar would disappear and trigger a similar event when disappearing as the tracks panel is dismissed.
998
999         * media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it-expected.txt: Added.
1000         * media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html: Added.
1001         * media/modern-media-controls/tracks-panel/tracks-panel-prevent-controls-bar-from-fading-expected.txt:
1002         * media/modern-media-controls/tracks-panel/tracks-panel-prevent-controls-bar-from-fading.html:
1003         * media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
1004
1005 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
1006
1007         Mark fast/workers/worker-close-more.html as a flaky timeout.
1008         https://bugs.webkit.org/show_bug.cgi?id=169838
1009
1010         Unreviewed test gardening.
1011
1012         * platform/mac/TestExpectations:
1013
1014 2017-03-29  Youenn Fablet  <youenn@apple.com>
1015
1016         Move DTMF WebRTC extension behind its own compile flag
1017         https://bugs.webkit.org/show_bug.cgi?id=170226
1018
1019         Reviewed by Eric Carlson.
1020
1021         * TestExpectations:
1022         * platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
1023         * platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
1024         * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
1025         * platform/mac/js/dom/global-constructors-attributes-expected.txt:
1026
1027 2017-03-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1028
1029         [GTK][OWR] Rebaseline fast/mediastream/RTCPeerConnection-addIceCandidate.html after r214527
1030         https://bugs.webkit.org/show_bug.cgi?id=170192
1031
1032         Unreviewed test gardening.
1033
1034         * platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
1035
1036 2017-03-29  Youenn Fablet  <youenn@apple.com>
1037
1038         Add test for differentiating camera versus canvas stream
1039         https://bugs.webkit.org/show_bug.cgi?id=169698
1040         <rdar://problem/31076026>
1041
1042         Reviewed by Eric Carlson.
1043
1044         * fast/mediastream/captureStream/canvas2d.html:
1045
1046 2017-03-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1047
1048         [WebRTC] Update test RTCPeerConnection-overloaded-operations-params.html after r214441
1049         https://bugs.webkit.org/show_bug.cgi?id=170223
1050
1051         Reviewed by Youenn Fablet.
1052
1053         After r214441 the arguments of addIceCandidate() are nullable.
1054
1055         * fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt:
1056         * fast/mediastream/RTCPeerConnection-overloaded-operations-params.html:
1057         * platform/gtk/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt: Removed. The expected result was the same than the general one.
1058
1059 2017-03-29  Antoine Quint  <graouts@apple.com>
1060
1061         [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
1062         https://bugs.webkit.org/show_bug.cgi?id=168409
1063         <rdar://problem/30799198>
1064
1065         Reviewed by Dean Jackson.
1066
1067         Opt into ScriptedAnimationController logging.
1068
1069         * media/modern-media-controls/airplay-button/airplay-button-expected.txt:
1070         * media/modern-media-controls/airplay-button/airplay-button.html:
1071
1072 2017-03-28  Youenn Fablet  <youenn@apple.com>
1073
1074         [WebRTC] After r214441 addIceCandidate no longer accepts an RTCIceCandidateInit dictionary
1075         https://bugs.webkit.org/show_bug.cgi?id=170192
1076
1077         Reviewed by Jon Lee.
1078
1079         * fast/mediastream/RTCIceCandidate-expected.txt:
1080         * fast/mediastream/RTCIceCandidate.html: Removing no longer valid tests.
1081         * fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
1082         * fast/mediastream/RTCPeerConnection-addIceCandidate.html: Adding more tests to cover null/undefined cases.
1083         Ensuring sdpMid has a valid value.
1084         * fast/mediastream/resources/promise-utils.js: Improving error logging.
1085
1086 2017-03-27  Brent Fulgham  <bfulgham@apple.com>
1087
1088         Only attach Attributes to a given element one time
1089         https://bugs.webkit.org/show_bug.cgi?id=170125
1090         <rdar://problem/31279676>
1091
1092         Reviewed by Chris Dumez.
1093
1094         * fast/dom/Attr/make-unique-element-data-while-replacing-attr-expected.txt: Rebaselined.
1095         * fast/dom/Attr/make-unique-element-data-while-replacing-attr.html: Add check before setting new value.
1096         * fast/dom/Attr/only-attach-attr-once-expected.txt: Added.
1097         * fast/dom/Attr/only-attach-attr-once.html: Added.
1098
1099 2017-03-28  Youenn Fablet  <youenn@apple.com>
1100
1101         Stop RTCDataChannel when closing page
1102         https://bugs.webkit.org/show_bug.cgi?id=170166
1103
1104         Reviewed by Eric Carlson.
1105
1106         * webrtc/datachannel/datachannel-gc-expected.txt: Added.
1107         * webrtc/datachannel/datachannel-gc.html: Added.
1108
1109 2017-03-28  Myles C. Maxfield  <mmaxfield@apple.com>
1110
1111         Ranges for variation font properties are not enforced
1112         https://bugs.webkit.org/show_bug.cgi?id=169979
1113
1114         Reviewed by David Hyatt.
1115
1116         * fast/text/font-selection-font-face-parse-expected.txt:
1117         * fast/text/font-selection-font-face-parse.html:
1118         * fast/text/font-selection-font-loading-api-parse-expected.txt:
1119         * fast/text/font-selection-font-loading-api-parse.html:
1120         * fast/text/font-style-parse-expected.txt:
1121         * fast/text/font-style-parse.html:
1122         * fast/text/variations/font-loading-api-parse-ranges-expected.txt:
1123         * fast/text/variations/font-loading-api-parse-ranges.html:
1124         * fast/text/variations/out-of-bounds-selection-properties-expected.txt: Added.
1125         * fast/text/variations/out-of-bounds-selection-properties.html: Added.
1126         * platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:
1127
1128 2017-03-28  Andy Estes  <aestes@apple.com>
1129
1130         [iOS] Crash in -[WebPreviewLoader failed] when running http/tests/multipart/policy-ignore-crash.php
1131         https://bugs.webkit.org/show_bug.cgi?id=170197
1132         <rdar://problem/30314067>
1133
1134         Reviewed by Brady Eidson.
1135
1136         * platform/ios/TestExpectations: Unskipped http/tests/multipart/policy-ignore-crash.php.
1137         * platform/ios/http/tests/multipart/policy-ignore-crash-expected.txt: Added an iOS-specific result.
1138
1139 2017-03-28  Chris Dumez  <cdumez@apple.com>
1140
1141         Animated SVG images are not paused when outside viewport
1142         https://bugs.webkit.org/show_bug.cgi?id=170155
1143         <rdar://problem/31288893>
1144
1145         Reviewed by Antti Koivisto.
1146
1147         Add layout test coverage.
1148
1149         * platform/mac-wk1/TestExpectations:
1150         * svg/animations/animated-svg-image-outside-viewport-paused-expected.txt: Added.
1151         * svg/animations/animated-svg-image-outside-viewport-paused.html: Added.
1152         * svg/animations/animated-svg-image-removed-from-document-paused-expected.txt: Added.
1153         * svg/animations/animated-svg-image-removed-from-document-paused.html: Added.
1154         * svg/animations/resources/smilAnimation.svg: Added.
1155
1156 2017-03-28  Antti Koivisto  <antti@apple.com>
1157
1158         Missing render tree position invalidation when tearing down renderers for display:contents subtree
1159         https://bugs.webkit.org/show_bug.cgi?id=170199
1160         <rdar://problem/31260856>
1161
1162         Reviewed by Zalan Bujtas.
1163
1164         * fast/shadow-dom/slot-renderer-teardown-expected.txt: Added.
1165         * fast/shadow-dom/slot-renderer-teardown.html: Added.
1166
1167 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
1168
1169         Unreviewed, rolling out r214485.
1170
1171         This change caused LayoutTest crashes.
1172
1173         Reverted changeset:
1174
1175         "Stop RTCDataChannel when closing page"
1176         https://bugs.webkit.org/show_bug.cgi?id=170166
1177         http://trac.webkit.org/changeset/214485
1178
1179 2017-03-28  Brian Burg  <bburg@apple.com>
1180
1181         Web Inspector: Add "Disable Caches" option that only applies to the inspected page while Web Inspector is open
1182         https://bugs.webkit.org/show_bug.cgi?id=169865
1183         <rdar://problem/31250573>
1184
1185         Reviewed by Joseph Pecoraro.
1186
1187         Add tests that verify the new command works as expected when it disables resource caching.
1188         I also manually verified that the override setting is cleared when Web Inspector disconnects.
1189         This is not easy to check in a layout test since we rely on the Web Inspector to tell whether
1190         a load happened or not.
1191
1192         * http/tests/inspector/network/set-resource-caching-disabled-disk-cache-expected.txt: Added.
1193         * http/tests/inspector/network/set-resource-caching-disabled-disk-cache.html: Added.
1194         * http/tests/inspector/network/set-resource-caching-disabled-memory-cache-expected.txt: Added.
1195         * http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html: Added.
1196
1197 2017-03-28  Youenn Fablet  <youenn@apple.com>
1198
1199         Update LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate.html to get more coverage
1200         https://bugs.webkit.org/show_bug.cgi?id=170194
1201
1202         Reviewed by Chris Dumez.
1203
1204         * fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
1205         * fast/mediastream/RTCPeerConnection-addIceCandidate.html: Making test more robust to failures to get more coverage.
1206
1207 2017-03-28  Joseph Pecoraro  <pecoraro@apple.com>
1208
1209         Web Inspector: Inspecting a Main Resource that is JS/JSON does not format / syntax highlight it properly
1210         https://bugs.webkit.org/show_bug.cgi?id=166862
1211         <rdar://problem/29835977>
1212
1213         Reviewed by Brian Burg.
1214
1215         * http/tests/inspector/network/resource-mime-type-expected.txt: Added.
1216         * http/tests/inspector/network/resource-mime-type.html: Added.
1217         Test resource mime types for different resources.
1218
1219         * http/tests/inspector/network/resources/json.php: Added.
1220         * http/tests/inspector/network/resources/script.js: Added.
1221         * http/tests/inspector/network/resources/script.txt: Added.
1222         * http/tests/inspector/network/resources/stylesheet.css: Added.
1223         * http/tests/inspector/network/resources/stylesheet.txt: Added.
1224         * http/tests/resources/square20.jpg: Added.
1225         Resources for various requests and different mime types.
1226
1227 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
1228
1229         Mark http/tests/xmlhttprequest/simple-cross-origin-progress-events.html as flaky.
1230         https://bugs.webkit.org/show_bug.cgi?id=168132
1231
1232         Unreviewed test gardening.
1233
1234         * platform/mac/TestExpectations:
1235
1236 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
1237
1238         Mark two fast/scrolling/ios/touch-scroll tests as failing.
1239         https://bugs.webkit.org/show_bug.cgi?id=170153
1240
1241         Unreviewed test gardening.
1242
1243         * platform/ios-wk2/TestExpectations:
1244
1245 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
1246
1247         Remove failure expectation for media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html.
1248
1249         Unreviewed test gardening.
1250
1251         * platform/ios/TestExpectations:
1252
1253 2017-03-28  Youenn Fablet  <youenn@apple.com>
1254
1255         Stop RTCDataChannel when closing page
1256         https://bugs.webkit.org/show_bug.cgi?id=170166
1257
1258         Reviewed by Eric Carlson.
1259
1260         * webrtc/datachannel/datachannel-gc-expected.txt: Added.
1261         * webrtc/datachannel/datachannel-gc.html: Added.
1262
1263 2017-03-28  Antoine Quint  <graouts@apple.com>
1264
1265         REGRESSION (r214386): [ios-simulator] LayoutTest media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html is failing
1266         https://bugs.webkit.org/show_bug.cgi?id=170180
1267
1268         Unreviewed. Restore a value that was mistakenly changed in the fix for webkit.org/b/169962.
1269
1270         * media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt:
1271         * media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html:
1272
1273 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
1274
1275         Mark fast/history/ios/history-scroll-restoration.html as flaky.
1276         https://bugs.webkit.org/show_bug.cgi?id=169558
1277
1278         Unreviewed test gardening.
1279
1280         * platform/ios-wk2/TestExpectations:
1281
1282 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
1283
1284         Mark media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html as failing on ios-simulator.
1285         https://bugs.webkit.org/show_bug.cgi?id=170180
1286
1287         Unreviewed test gardening.
1288
1289         * platform/ios/TestExpectations:
1290
1291 2017-03-28  Youenn Fablet  <youenn@apple.com>
1292
1293         LayoutTest webrtc/video-getParameters.html is failing
1294         https://bugs.webkit.org/show_bug.cgi?id=170148
1295
1296         Unreviewed.
1297
1298         * TestExpectations: Marking webrtc/video-getParameters.html as failing.
1299
1300 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
1301
1302         Mark webrtc/video-replace-track-to-null.html as flaky.
1303         https://bugs.webkit.org/show_bug.cgi?id=170178
1304
1305         Unreviewed test gardening.
1306
1307         * TestExpectations:
1308
1309 2017-03-28  Jonathan Bedard  <jbedard@apple.com>
1310
1311         Moved gardened ios-simulator tests to ios folders
1312         <rdar://problem/30948691>
1313
1314         Unreviewed test re-organization.
1315
1316         Moving ios-simulator test expectations to share as many expectations
1317         as possible with on-device testing.
1318
1319         * platform/ios: Moved from platform/ios-simulator.
1320         * platform/ios-device: Added.
1321         * platform/ios-device-wk1: Added.
1322         * platform/ios-device-wk2: Added.
1323         * platform/ios-simulator: Moved to platform/ios.
1324         * platform/ios-simulator-wk1: Moved to platform/ios-wk1.
1325         * platform/ios-simulator-wk2: Moved to platform/ios-wk2.
1326         * platform/ios-wk1: Moved from platform/ios-simulator-wk1.
1327         * platform/ios-wk2: Moved from platform/ios-simulator-wk2.
1328
1329 2017-03-28  Yoav Weiss  <yoav@yoav.ws>
1330
1331         Add a warning for unused link preloads.
1332         https://bugs.webkit.org/show_bug.cgi?id=165670
1333
1334         Reviewed by Youenn Fablet.
1335
1336         * TestExpectations: Added a "Failure Pass" for the flaky charset header test.
1337         * http/tests/preload/download_resources-expected.txt:
1338         * http/tests/preload/download_resources.html: Added references to preloaded resources.
1339         * http/tests/preload/onerror_event-expected.txt:
1340         * http/tests/preload/onerror_event.html: Added references to preloaded resources.
1341         * http/tests/preload/onload_event-expected.txt:
1342         * http/tests/preload/onload_event.html: Added references to preloaded resources.
1343         * http/tests/preload/single_download_preload.html: Deflaked.
1344         * http/tests/preload/single_download_preload_headers.php: Removed the charset to avoid double download bug.
1345         * http/tests/preload/single_download_preload_headers_charset-expected.txt: Added.
1346         * http/tests/preload/single_download_preload_headers_charset.php: Flaky test showing the double download bug when charset is declared.
1347         * http/tests/preload/unused_preload_warning-expected.txt: Added.
1348         * http/tests/preload/unused_preload_warning.html: Added.
1349
1350 2017-03-28  Antoine Quint  <graouts@apple.com>
1351
1352         REGRESSION: Double-clicking the captions button while the captions popover is open prevents the popover from being opened again
1353         https://bugs.webkit.org/show_bug.cgi?id=170171
1354         <rdar://problem/31095500>
1355
1356         Reviewed by Dean Jackson.
1357
1358         Adding a new test that runs the steps to reproduce the issue, and rebaselining an existing one now that
1359         the "presented" property returns false immediately after calling hide() on the panel.
1360
1361         * media/modern-media-controls/tracks-panel/tracks-panel-hide-expected.txt:
1362         * media/modern-media-controls/tracks-panel/tracks-panel-hide.html:
1363         * media/modern-media-controls/tracks-support/tracks-support-show-panel-then-double-click-on-tracks-button-expected.txt: Added.
1364         * media/modern-media-controls/tracks-support/tracks-support-show-panel-then-double-click-on-tracks-button.html: Added.
1365
1366 2017-03-28  Aaron Chu  <aaron_chu@apple.com>
1367
1368         AX: Media controls should be able to be re-activated after faded away
1369         https://bugs.webkit.org/show_bug.cgi?id=170048
1370         <rdar://problem/30157179>
1371
1372         Reviewed by Antoine Quint.
1373
1374         * media/modern-media-controls/media-controls/media-controls-appear-when-focus-expected.txt: Added.
1375         * media/modern-media-controls/media-controls/media-controls-appear-when-focus.html: Added.
1376
1377 2017-03-28  Antoine Quint  <graouts@apple.com>
1378
1379         [Modern Media Controls] Improve media documents across macOS, iPhone and iPad
1380         https://bugs.webkit.org/show_bug.cgi?id=169145
1381         <rdar://problem/17048858>
1382
1383         Reviewed by Dean Jackson.
1384
1385         We add new tests for media documents and related features that cover the following cases:
1386         
1387             - checking <video> with only audio tracks does not show the fullscreen button
1388             - checking <video> with only audio tracks does not show the picture-in-picture button
1389             - checking the size used in media documents for audio and video across macOS, iPhone and iPad
1390
1391         * media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
1392         * media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html: Added.
1393         * media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing-expected.txt: Added.
1394         * media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html: Added.
1395         * media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing-expected.txt: Added.
1396         * media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html: Added.
1397         * media/modern-media-controls/media-documents/media-document-audio-ios-sizing-expected.txt: Added.
1398         * media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html: Added.
1399         * media/modern-media-controls/media-documents/media-document-audio-mac-sizing-expected.txt: Added.
1400         * media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html: Added.
1401         * media/modern-media-controls/media-documents/media-document-video-ios-sizing-expected.txt: Added.
1402         * media/modern-media-controls/media-documents/media-document-video-ios-sizing.html: Added.
1403         * media/modern-media-controls/media-documents/media-document-video-mac-sizing-expected.txt: Added.
1404         * media/modern-media-controls/media-documents/media-document-video-mac-sizing.html: Added.
1405         * media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
1406         * media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html: Added.
1407         * platform/ios-simulator/TestExpectations:
1408         * platform/mac/TestExpectations:
1409
1410 2017-03-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
1411
1412         REGRESSION(213764): Large images should not be decoded asynchronously when they are drawn on a canvas
1413         https://bugs.webkit.org/show_bug.cgi?id=169771
1414
1415         Reviewed by Simon Fraser.
1416
1417         * fast/images/animated-image-different-dest-size-expected.html: Added.
1418         * fast/images/animated-image-different-dest-size.html: Added.
1419         This test crashes without this patch.
1420
1421         * fast/images/animated-image-loop-count.html:
1422         Clear the memory cache so the test can be not flaky. Running it with -repeat-each was failing.
1423
1424         * fast/images/async-image-background-image-expected.html: Added.
1425         * fast/images/async-image-background-image.html: Added.
1426         Ensures the background image can be drawn asynchronously if it is large.
1427
1428         * fast/images/async-image-canvas-draw-image-expected.html: Added.
1429         * fast/images/async-image-canvas-draw-image.html: Added.
1430         Ensures the image is drawn synchronously on the canvas regardless of its size.
1431
1432         * fast/images/ordered-animated-image-frames.html:
1433         Clear the memory cache so the test can be not flaky. Running it with -repeat-each was failing.
1434
1435         * fast/images/reset-image-animation-expected.txt:
1436         * fast/images/reset-image-animation.html:
1437         Change how the steps of the test are ordered so the test can be not flaky.
1438         Running it with -repeat-each was failing.
1439
1440         * fast/images/resources/red-green-blue-900-300.png: Added.
1441
1442 2017-03-27  Youenn Fablet  <youenn@apple.com>
1443
1444         addIceCandidate should not throw if passed null or undefined
1445         https://bugs.webkit.org/show_bug.cgi?id=170118
1446
1447         Reviewed by Eric Carlson.
1448
1449         Updating test to log addIceCandidate rejection.
1450
1451         * webrtc/datachannel/basic.html:
1452         * webrtc/routines.js:
1453         (iceCallback1):
1454         (iceCallback2):
1455         (onAddIceCandidateError):
1456
1457 2017-03-27  Ryan Haddad  <ryanhaddad@apple.com>
1458
1459         Rebaseline svg/css/getComputedStyle-basic.xhtml for macOS.
1460
1461         Unreviewed test gardening.
1462
1463         * platform/mac-elcapitan/svg/css/getComputedStyle-basic-expected.txt: Added.
1464         * platform/mac/svg/css/getComputedStyle-basic-expected.txt: Added.
1465
1466 2017-03-27  Antti Koivisto  <antti@apple.com>
1467
1468         Loading in-body stylesheets should not block rendering of elements before them
1469         https://bugs.webkit.org/show_bug.cgi?id=169345
1470
1471         Reviewed by Simon Fraser.
1472
1473         * http/tests/incremental/resources/delayed-css.php: Added.
1474         * http/tests/incremental/stylesheet-body-incremental-rendering-expected.html: Added.
1475         * http/tests/incremental/stylesheet-body-incremental-rendering.html: Added.
1476
1477 2017-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
1478
1479         Test variation font ranges in the CSS Font Loading API
1480         https://bugs.webkit.org/show_bug.cgi?id=170022
1481
1482         Reviewed by Dean Jackson.
1483
1484         * fast/text/variations/font-loading-api-parse-ranges-expected.txt: Added.
1485         * fast/text/variations/font-loading-api-parse-ranges.html: Added.
1486
1487 2017-03-27  Ryan Haddad  <ryanhaddad@apple.com>
1488
1489         Unreviewed, rolling out r214411.
1490
1491         Two of the LayoutTests for this change time out on ios-
1492         simulator.
1493
1494         Reverted changeset:
1495
1496         "[Modern Media Controls] Improve media documents across macOS,
1497         iPhone and iPad"
1498         https://bugs.webkit.org/show_bug.cgi?id=169145
1499         http://trac.webkit.org/changeset/214411
1500
1501 2017-03-27  Antoine Quint  <graouts@apple.com>
1502
1503         [Modern Media Controls] Clicking on the tracks button when the tracks panel is up in a media document pauses the video
1504         https://bugs.webkit.org/show_bug.cgi?id=168517
1505         <rdar://problem/30577636>
1506
1507         Reviewed by Dean Jackson.
1508
1509         * media/video-click-dblckick-standalone.html: We disable modern-media-controls here since we know that this test won't pass with them on.
1510
1511 2017-03-27  Ryan Haddad  <ryanhaddad@apple.com>
1512
1513         Mark media/modern-media-controls/time-label/time-label-white-space-nowrap.html as flaky.
1514         https://bugs.webkit.org/show_bug.cgi?id=169679
1515
1516         Unreviewed test gardening.
1517
1518         * platform/mac/TestExpectations:
1519
1520 2017-03-27  Ryan Haddad  <ryanhaddad@apple.com>
1521
1522         Mark inspector/dom-debugger/dom-breakpoints.html as flaky.
1523         https://bugs.webkit.org/show_bug.cgi?id=170127
1524
1525         Unreviewed test gardening.
1526
1527         * platform/mac/TestExpectations:
1528
1529 2017-03-27  Ryan Haddad  <ryanhaddad@apple.com>
1530
1531         Mark media/modern-media-controls/time-label/time-label.html as flaky.
1532         https://bugs.webkit.org/show_bug.cgi?id=169678
1533
1534         Unreviewed test gardening.
1535
1536         * platform/mac-wk1/TestExpectations:
1537
1538 2017-03-27  Ryan Haddad  <ryanhaddad@apple.com>
1539
1540         Marking two modern-media-controls tests as timeouts.
1541         https://bugs.webkit.org/show_bug.cgi?id=170123
1542
1543         Unreviewed test gardening.
1544
1545         * platform/ios-simulator/TestExpectations:
1546
1547 2017-03-27  Youenn Fablet  <youenn@apple.com>
1548
1549         Tighten RTCDatachannel creation and parameter getters
1550         https://bugs.webkit.org/show_bug.cgi?id=170081
1551
1552         Reviewed by Eric Carlson.
1553
1554         * webrtc/datachannel/basic-expected.txt:
1555         * webrtc/datachannel/basic.html:
1556
1557 2017-03-27  Youenn Fablet  <youenn@apple.com>
1558
1559         Add support for RTCRtpReceiver/RTCRtpSender getParameters
1560         https://bugs.webkit.org/show_bug.cgi?id=170057
1561
1562         Reviewed by Alex Christensen.
1563
1564         * webrtc/video-getParameters-expected.txt: Added.
1565         * webrtc/video-getParameters.html: Added.
1566
1567 2017-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
1568
1569         font variation properties don't need to accept numbers
1570         https://bugs.webkit.org/show_bug.cgi?id=169357
1571
1572         Reviewed by Antti Koivisto.
1573
1574         * fast/text/font-selection-font-face-parse-expected.txt:
1575         * fast/text/font-selection-font-face-parse.html:
1576         * fast/text/font-selection-font-loading-api-parse-expected.txt:
1577         * fast/text/font-selection-font-loading-api-parse.html:
1578         * fast/text/font-stretch-parse-expected.txt:
1579         * fast/text/font-stretch-parse.html:
1580         * fast/text/font-style-parse-expected.txt:
1581         * fast/text/font-style-parse.html:
1582         * fast/text/variations/font-selection-properties.html:
1583         * platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:
1584
1585 2017-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
1586
1587         Implement format specifier for variation fonts
1588         https://bugs.webkit.org/show_bug.cgi?id=169327
1589
1590         Reviewed by Simon Fraser.
1591
1592         * fast/text/variations/font-face-format-expected.html: Added.
1593         * fast/text/variations/font-face-format.html: Added.
1594
1595 2017-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
1596
1597         Make sure animation works for font-weight, font-stretch, and font-style
1598         https://bugs.webkit.org/show_bug.cgi?id=169683
1599
1600         Reviewed by Simon Fraser.
1601
1602         * animations/font-variations/font-stretch-expected.txt: Added.
1603         * animations/font-variations/font-stretch.html: Added.
1604         * animations/font-variations/font-style-expected.txt: Added.
1605         * animations/font-variations/font-style.html: Added.
1606         * animations/font-variations/font-weight-expected.txt: Added.
1607         * animations/font-variations/font-weight.html: Added.
1608         * animations/resources/animation-test-helpers.js:
1609         (compareFontStyle):
1610         (getPropertyValue):
1611         (comparePropertyValue):
1612
1613 2017-03-27  Alex Christensen  <achristensen@webkit.org>
1614
1615         Make WebSockets work in network process
1616         https://bugs.webkit.org/show_bug.cgi?id=169930
1617
1618         Reviewed by Youenn Fablet.
1619
1620         * http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt: Added.
1621         * http/tests/websocket/tests/hybi/network-process-crash-error.html: Added.
1622         * http/tests/websocket/tests/hybi/slow-reply_wsh.py: Added.
1623         (web_socket_do_extra_handshake):
1624         (web_socket_transfer_data):
1625         * platform/ios-simulator-wk1/TestExpectations:
1626         * platform/mac-wk1/TestExpectations:
1627         * platform/win/TestExpectations:
1628
1629 2017-03-27  Antoine Quint  <graouts@apple.com>
1630
1631         [Modern Media Controls] Improve media documents across macOS, iPhone and iPad
1632         https://bugs.webkit.org/show_bug.cgi?id=169145
1633         <rdar://problem/17048858>
1634
1635         Reviewed by Dean Jackson.
1636
1637         We add new tests for media documents and related features that cover the following cases:
1638         
1639             - checking <video> with only audio tracks does not show the fullscreen button
1640             - checking <video> with only audio tracks does not show the picture-in-picture button
1641             - checking the size used in media documents for audio and video across macOS, iPhone and iPad
1642
1643         * media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
1644         * media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html: Added.
1645         * media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing-expected.txt: Added.
1646         * media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html: Added.
1647         * media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing-expected.txt: Added.
1648         * media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html: Added.
1649         * media/modern-media-controls/media-documents/media-document-audio-ios-sizing-expected.txt: Added.
1650         * media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html: Added.
1651         * media/modern-media-controls/media-documents/media-document-audio-mac-sizing-expected.txt: Added.
1652         * media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html: Added.
1653         * media/modern-media-controls/media-documents/media-document-video-ios-sizing-expected.txt: Added.
1654         * media/modern-media-controls/media-documents/media-document-video-ios-sizing.html: Added.
1655         * media/modern-media-controls/media-documents/media-document-video-mac-sizing-expected.txt: Added.
1656         * media/modern-media-controls/media-documents/media-document-video-mac-sizing.html: Added.
1657         * media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
1658         * media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html: Added.
1659         * platform/ios-simulator/TestExpectations:
1660         * platform/mac/TestExpectations:
1661
1662 2017-03-25  Aaron Chu  <aaron_chu@apple.com>
1663
1664         AX: Media controls are unlabeled
1665         https://bugs.webkit.org/show_bug.cgi?id=169947
1666         <rdar://problem/30153323>
1667
1668         Reviewed by Antoine Quint.
1669
1670         * media/modern-media-controls/airplay-button/airplay-button-expected.txt:
1671         * media/modern-media-controls/airplay-button/airplay-button.html:
1672         * media/modern-media-controls/forward-button/forward-button-expected.txt:
1673         * media/modern-media-controls/forward-button/forward-button.html:
1674         * media/modern-media-controls/fullscreen-button/fullscreen-button-expected.txt:
1675         * media/modern-media-controls/fullscreen-button/fullscreen-button.html:
1676         * media/modern-media-controls/icon-button/icon-button-expected.txt:
1677         * media/modern-media-controls/icon-button/icon-button.html:
1678         * media/modern-media-controls/icon-service/icon-service-expected.txt:
1679         * media/modern-media-controls/icon-service/icon-service.html:
1680         * media/modern-media-controls/mute-button/mute-button-expected.txt:
1681         * media/modern-media-controls/mute-button/mute-button.html:
1682         * media/modern-media-controls/pip-button/pip-button-expected.txt:
1683         * media/modern-media-controls/pip-button/pip-button.html:
1684         * media/modern-media-controls/play-pause-button/play-pause-button-expected.txt:
1685         * media/modern-media-controls/play-pause-button/play-pause-button.html:
1686         * media/modern-media-controls/rewind-button/rewind-button-expected.txt:
1687         * media/modern-media-controls/rewind-button/rewind-button.html:
1688         * media/modern-media-controls/skip-back-button/skip-back-button-expected.txt:
1689         * media/modern-media-controls/skip-back-button/skip-back-button.html:
1690         * media/modern-media-controls/start-button/start-button-expected.txt:
1691         * media/modern-media-controls/start-button/start-button.html:
1692         * media/modern-media-controls/tracks-button/tracks-button-expected.txt:
1693         * media/modern-media-controls/tracks-button/tracks-button.html:
1694
1695 2017-03-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1696
1697         Unreviewed GTK+ gardening. Update expectations of several tests.
1698
1699         * platform/gtk/TestExpectations:
1700
1701 2017-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1702
1703         Post-commit test fix after r214394
1704         https://bugs.webkit.org/show_bug.cgi?id=170083
1705
1706         Unreviewed.
1707
1708         * fast/text/variations/optical-sizing.html:
1709
1710 2017-03-24  Myles C. Maxfield  <mmaxfield@apple.com>
1711
1712         Add font-optical-sizing to CSSComputedStyleDeclaration
1713         https://bugs.webkit.org/show_bug.cgi?id=170083
1714
1715         Reviewed by Joseph Pecoraro.
1716
1717         * fast/css/getComputedStyle/computed-style-expected.txt:
1718         * fast/css/getComputedStyle/computed-style-font-family-expected.txt:
1719         * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
1720         * fast/css/getComputedStyle/resources/property-names.js:
1721         * fast/text/variations/optical-sizing-expected.txt:
1722         * fast/text/variations/optical-sizing.html:
1723         * platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-expected.txt: Added.
1724         * platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
1725         * platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
1726
1727 2017-03-24  Ryan Haddad  <ryanhaddad@apple.com>
1728
1729         Consolidate TestExpectations for media/restore-from-page-cache.html.
1730
1731         Unreviewed test gardening.
1732
1733         * platform/mac/TestExpectations:
1734
1735 2017-03-24  Ryan Haddad  <ryanhaddad@apple.com>
1736
1737         Unreviewed, rolling out r214361.
1738
1739         This change caused flakiness in http/tests/preload tests.
1740
1741         Reverted changeset:
1742
1743         "Add a warning for unused link preloads."
1744         https://bugs.webkit.org/show_bug.cgi?id=165670
1745         http://trac.webkit.org/changeset/214361
1746
1747 2017-03-24  Antoine Quint  <graouts@webkit.org>
1748
1749         [Modern Media Controls] Remove placard icon if height is compressed
1750         https://bugs.webkit.org/show_bug.cgi?id=167935
1751         <rdar://problem/30397128>
1752
1753         Reviewed by Dean Jackson.
1754
1755         We add a new test to check that the various designed constraints to toggle display of a placard's
1756         icon, title and description are honored. Also, due to the old layout() method now being called
1757         "commit()", we refactor a relevant test.
1758
1759         * media/modern-media-controls/layout-node/node-made-dirty-during-commit-expected.txt: Added.
1760         * media/modern-media-controls/layout-node/node-made-dirty-during-commit.html: Added.
1761         * media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics-expected.txt: Added.
1762         * media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html: Added.
1763
1764 2017-03-24  Eric Carlson  <eric.carlson@apple.com>
1765
1766         [MediaStream] "ideal" constraints passed to getUserMedia should affect fitness score
1767         https://bugs.webkit.org/show_bug.cgi?id=170056
1768
1769         Reviewed by Youenn Fablet.
1770
1771         * fast/mediastream/MediaStream-video-element-displays-buffer-expected.txt:
1772         * fast/mediastream/MediaStream-video-element-displays-buffer.html:
1773         * fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt:
1774         * fast/mediastream/apply-constraints-advanced-expected.txt:
1775         * fast/mediastream/apply-constraints-advanced.html:
1776         * fast/mediastream/apply-constraints-video-expected.txt:
1777         * fast/mediastream/apply-constraints-video.html:
1778
1779 2017-03-24  Dean Jackson  <dino@apple.com>
1780
1781         Serialization of custom props in longhand should be "" not value of shorthand
1782         https://bugs.webkit.org/show_bug.cgi?id=167699
1783         <rdar://problem/30324200>
1784
1785         Reviewed by Sam Weinig.
1786
1787         * fast/css/variables/rule-property-get-expected.html:
1788         * fast/css/variables/rule-property-get.html:
1789
1790 2017-03-24  Antoine Quint  <graouts@webkit.org>
1791
1792         [Modern Media Controls] Captions don't move with the appearance of the inline controls
1793         https://bugs.webkit.org/show_bug.cgi?id=170051
1794         <rdar://problem/30754428>
1795
1796         Reviewed by Dean Jackson.
1797
1798         Add a new test, which would have previously failed, where we check that we account for the controls bar height
1799         when showing captions with the controls bar visible.
1800
1801         * media/modern-media-controls/tracks-support/tracks-support-captions-offset-with-controls-bar-expected.txt: Added.
1802         * media/modern-media-controls/tracks-support/tracks-support-captions-offset-with-controls-bar.html: Added.
1803
1804 2017-03-24  Brent Fulgham  <bfulgham@apple.com>
1805
1806         Handle recursive calls to ProcessingInstruction::checkStyleSheet
1807         https://bugs.webkit.org/show_bug.cgi?id=169982
1808         <rdar://problem/31083051>
1809
1810         Reviewed by Antti Koivisto.
1811
1812         * fast/dom/beforeload/image-removed-during-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/image-removed-during-before-load-expected.txt.
1813         * fast/dom/beforeload/image-removed-during-before-load.html: Copied from LayoutTests/fast/dom/beforeload/image-removed-during-before-load.html.
1814         * fast/dom/beforeload/recursive-css-pi-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/recursive-css-pi-before-load-expected.txt.
1815         * fast/dom/beforeload/recursive-css-pi-before-load.html: Copied from LayoutTests/fast/dom/beforeload/recursive-css-pi-before-load.html.
1816         * fast/dom/beforeload/recursive-link-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/recursive-link-before-load-expected.txt.
1817         * fast/dom/beforeload/recursive-link-before-load.html: Copied from LayoutTests/fast/dom/beforeload/recursive-link-before-load.html.
1818         * fast/dom/beforeload/recursive-xsl-pi-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/recursive-xsl-pi-before-load-expected.txt.
1819         * fast/dom/beforeload/recursive-xsl-pi-before-load.html: Copied from LayoutTests/fast/dom/beforeload/recursive-xsl-pi-before-load.html.
1820         * fast/dom/beforeload/resources/content.xhtml: Copied from LayoutTests/fast/dom/beforeload/resources/content.xhtml.
1821         * fast/dom/beforeload/resources/pass.css: Copied from LayoutTests/fast/dom/beforeload/resources/pass.css.
1822         * fast/dom/beforeload/resources/test.xsl: Copied from LayoutTests/fast/dom/beforeload/resources/test.xsl.
1823
1824 2017-03-24  Brady Eidson  <beidson@apple.com>
1825
1826         A null compound index value crashes the Databases process.
1827         <rdar://problem/30499831> and https://bugs.webkit.org/show_bug.cgi?id=170000
1828
1829         Reviewed by Alex Christensen.
1830
1831         * storage/indexeddb/modern/resources/single-entry-index-invalid-key-crash.js: Added.
1832         * storage/indexeddb/modern/single-entry-index-invalid-key-crash-expected.txt: Added.
1833         * storage/indexeddb/modern/single-entry-index-invalid-key-crash-private-expected.txt: Added.
1834         * storage/indexeddb/modern/single-entry-index-invalid-key-crash-private.html: Added.
1835         * storage/indexeddb/modern/single-entry-index-invalid-key-crash.html: Added.
1836
1837 2017-03-24  Ryan Haddad  <ryanhaddad@apple.com>
1838
1839         Skip svg/animations/animations-paused-when-inserted-in-hidden-document* tests on ios-simulator.
1840         https://bugs.webkit.org/show_bug.cgi?id=170068
1841
1842         Unreviewed test gardening.
1843
1844         * platform/ios-simulator/TestExpectations:
1845
1846 2017-03-24  Ryan Haddad  <ryanhaddad@apple.com>
1847
1848         Unreviewed, rolling out r214360.
1849
1850         This change caused 20+ LayoutTest failures.
1851
1852         Reverted changeset:
1853
1854         "Handle recursive calls to
1855         ProcessingInstruction::checkStyleSheet"
1856         https://bugs.webkit.org/show_bug.cgi?id=169982
1857         http://trac.webkit.org/changeset/214360
1858
1859 2017-03-24  Youenn Fablet  <youenn@apple.com>
1860
1861         Add support for qpSum in WebRTC stats
1862         https://bugs.webkit.org/show_bug.cgi?id=170060
1863
1864         Reviewed by Eric Carlson.
1865
1866         * webrtc/video-stats.html:
1867
1868 2017-03-24  Daniel Bates  <dabates@apple.com>
1869
1870         Prevent new navigations during document unload
1871         https://bugs.webkit.org/show_bug.cgi?id=169934
1872         <rdar://problem/31247584>
1873
1874         Reviewed by Chris Dumez.
1875
1876         Add a test to ensure that we do not cause an assertion fail when calling setTimeout
1877         after starting a navigation from an onunload event handler.
1878
1879         * fast/frames/frame-unload-navigate-and-setTimeout-assert-fail-expected.txt: Added.
1880         * fast/frames/frame-unload-navigate-and-setTimeout-assert-fail.html: Added.
1881
1882 2017-03-24  Myles C. Maxfield  <mmaxfield@apple.com>
1883
1884         Implement font-optical-sizing
1885         https://bugs.webkit.org/show_bug.cgi?id=168895
1886
1887         Reviewed by Dean Jackson.
1888
1889         * fast/text/variations/optical-sizing-expected.txt: Added.
1890         * fast/text/variations/optical-sizing.html: Added.
1891
1892 2017-03-24  Yoav Weiss  <yoav@yoav.ws>
1893
1894         Add a warning for unused link preloads.
1895         https://bugs.webkit.org/show_bug.cgi?id=165670
1896
1897         Reviewed by Youenn Fablet.
1898
1899         This adds a test for the unused preload warning, and adapts some of the other preload tests,
1900         to avoid warnings.
1901
1902         * http/tests/preload/download_resources-expected.txt: Changed.
1903         * http/tests/preload/download_resources.html: Added references to preloaded resources.
1904         * http/tests/preload/onerrer_event-expected.txt: Changed.
1905         * http/tests/preload/onerror_event.html: Added references to preloaded resources.
1906         * http/tests/preload/onload_event.html: Added references to preloaded resources.
1907         * http/tests/preload/resources/single_download_preload.html: Deflaked.
1908         * http/tests/preload/unused_preload_warning-expected.txt: Added.
1909         * http/tests/preload/unused_preload_warning.html: Added.
1910
1911 2017-03-24  Brent Fulgham  <bfulgham@apple.com>
1912
1913         Handle recursive calls to ProcessingInstruction::checkStyleSheet
1914         https://bugs.webkit.org/show_bug.cgi?id=169982
1915         <rdar://problem/31083051>
1916
1917         Reviewed by Antti Koivisto.
1918
1919         * fast/dom/beforeload/image-removed-during-before-load-expected.txt: Added.
1920         * fast/dom/beforeload/image-removed-during-before-load.html: Added.
1921         * fast/dom/beforeload/recursive-css-pi-before-load-expected.txt: Added.
1922         * fast/dom/beforeload/recursive-css-pi-before-load.html: Added.
1923         * fast/dom/beforeload/recursive-link-before-load-expected.txt: Added.
1924         * fast/dom/beforeload/recursive-link-before-load.html: Added.
1925         * fast/dom/beforeload/recursive-xsl-pi-before-load-expected.txt: Added.
1926         * fast/dom/beforeload/recursive-xsl-pi-before-load.html: Added.
1927         * fast/dom/beforeload/resources/content.xhtml: Added.
1928         * fast/dom/beforeload/resources/pass.css: Added.
1929         * fast/dom/beforeload/resources/test.xsl: Added.
1930
1931 2017-03-24  Myles C. Maxfield  <mmaxfield@apple.com>
1932
1933         font-style needs a new CSSValue to make CSSRule.cssText work correctly
1934         https://bugs.webkit.org/show_bug.cgi?id=169258
1935
1936         Reviewed by David Hyatt.
1937
1938         Update tests' expected results.
1939
1940         * fast/text/font-selection-font-face-parse-expected.txt:
1941         * fast/text/font-selection-font-face-parse.html:
1942         * fast/text/font-style-parse-expected.txt:
1943         * fast/text/font-style-parse.html:
1944         * platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:
1945         * svg/css/getComputedStyle-basic-expected.txt:
1946
1947 2017-03-24  Youenn Fablet  <youenn@apple.com>
1948
1949         Add libwebrtc backend support for RTCRtpSender::replaceTrack
1950         https://bugs.webkit.org/show_bug.cgi?id=169841
1951
1952         Reviewed by Alex Christensen.
1953
1954         * webrtc/audio-replace-track-expected.txt: Added.
1955         * webrtc/audio-replace-track.html: Added.
1956         * webrtc/video-replace-track-expected.txt: Added.
1957         * webrtc/video-replace-track.html: Added.
1958         * webrtc/video-replace-track-to-null-expected.txt: Added.
1959         * webrtc/video-replace-track-to-null.html: Added.
1960
1961 2017-03-24  Ryan Haddad  <ryanhaddad@apple.com>
1962
1963         Update TestExpectations for media/restore-from-page-cache.html.
1964
1965         Unreviewed test gardening.
1966
1967         * platform/mac-wk2/TestExpectations:
1968         * platform/mac/TestExpectations:
1969
1970 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1971
1972         Unreviewed GTK+ gardening. Mark webrtc/video-stats.html as failing.
1973
1974         * platform/gtk/TestExpectations:
1975
1976 2017-03-24  Youenn Fablet  <youenn@apple.com>
1977
1978         Add support for DataChannel and MediaStreamTrack stats
1979         https://bugs.webkit.org/show_bug.cgi?id=170031
1980
1981         Reviewed by Eric Carlson.
1982
1983         * webrtc/datachannel/datachannel-stats-expected.txt: Added.
1984         * webrtc/datachannel/datachannel-stats.html: Added.
1985         * webrtc/video-mediastreamtrack-stats-expected.txt: Added.
1986         * webrtc/video-mediastreamtrack-stats.html: Added.
1987
1988 2017-03-24  Chris Dumez  <cdumez@apple.com>
1989
1990         Extend svg/animations/animations-paused-disconnected-iframe.html
1991         https://bugs.webkit.org/show_bug.cgi?id=170035
1992
1993         Reviewed by Andreas Kling.
1994
1995         Extend svg/animations/animations-paused-disconnected-iframe.html to cover more things.
1996
1997         * svg/animations/animations-paused-disconnected-iframe-expected.txt:
1998         * svg/animations/animations-paused-disconnected-iframe.html:
1999
2000 2017-03-24  Youenn Fablet  <youenn@apple.com>
2001
2002         Fix framesEncoded/framesDecoded RTC stats
2003         https://bugs.webkit.org/show_bug.cgi?id=170024
2004
2005         Reviewed by Eric Carlson.
2006
2007         * webrtc/video-stats-expected.txt: Added.
2008         * webrtc/video-stats.html: Added.
2009
2010 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2011
2012         Unreviewed GTK+ gardening. Mark media/video-load-require-user-gesture.html as failing after r214338.
2013
2014         * platform/gtk/TestExpectations:
2015
2016 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2017
2018         Unreviewed GTK+ gardening. Rebaseline http/tests/inspector/network/fetch-response-body.html/xhr-response-body.html after r214338.
2019
2020         We are now getting the right application/json for a file data.json. The soup network backend tries to gess the
2021         mime type from the extension when sniffing is not allowed and the mime type is not known. See bug
2022         webkit.org/b/168299, that was added actually to fix these tests, but at that time we also failed to guess the
2023         mime type and returned application/octet-stream.
2024
2025         * platform/gtk/TestExpectations:
2026         * platform/gtk/http/tests/inspector/network/fetch-response-body-expected.txt: Added.
2027         * platform/gtk/http/tests/inspector/network/xhr-response-body-expected.txt: Added.
2028
2029 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2030
2031         Unreviewed GTK+ gardening. Rebaseline fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html after r214338.
2032
2033         We are now getting a MIME type for otf files.
2034
2035         * platform/gtk/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-expected.txt: Added.
2036
2037 2017-03-24  Per Arne Vollan  <pvollan@apple.com>
2038
2039         Text stroke is sometimes clipped on video captions.
2040         https://bugs.webkit.org/show_bug.cgi?id=170006
2041
2042         Reviewed by Eric Carlson.
2043
2044         * media/track/track-css-stroke-cues-expected.txt:
2045         * media/track/track-css-stroke-cues.html:
2046
2047 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2048
2049         [GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
2050         https://bugs.webkit.org/show_bug.cgi?id=170001
2051
2052         Reviewed by Michael Catanzaro.
2053
2054         Remove platform specific expectations of two test because now we do the same as other wk2 ports.
2055
2056         * platform/gtk/TestExpectations:
2057
2058 2017-03-23  Antti Koivisto  <antti@apple.com>
2059
2060         Revert r213712, caused iPad PLT regression
2061         https://bugs.webkit.org/show_bug.cgi?id=170040
2062
2063         Unreviewed.
2064
2065         * http/tests/incremental/stylesheet-body-incremental-rendering-expected.html: Removed.
2066         * http/tests/incremental/stylesheet-body-incremental-rendering.html: Removed.
2067
2068 2017-03-23  Chris Dumez  <cdumez@apple.com>
2069
2070         SVG animations are not paused when their <svg> element is removed from the document
2071         https://bugs.webkit.org/show_bug.cgi?id=170030
2072         <rdar://problem/31230252>
2073
2074         Reviewed by Dean Jackson.
2075
2076         Add layout test coverage.
2077
2078         * svg/animations/animations-paused-when-removed-from-document-expected.txt: Added.
2079         * svg/animations/animations-paused-when-removed-from-document.html: Added.
2080
2081 2017-03-22  Myles C. Maxfield  <mmaxfield@apple.com>
2082
2083         font shorthand should accept variation values
2084         https://bugs.webkit.org/show_bug.cgi?id=168998
2085
2086         Reviewed by Simon Fraser.
2087
2088         * fast/text/font-style-parse-expected.txt:
2089         * fast/text/font-style-parse.html:
2090         * fast/text/font-weight-parse-expected.txt:
2091         * fast/text/font-weight-parse.html:
2092
2093 2017-03-23  Chris Dumez  <cdumez@apple.com>
2094
2095         SVG animations are not paused when inserted into a hidden page
2096         https://bugs.webkit.org/show_bug.cgi?id=170026
2097         <rdar://problem/31228704>
2098
2099         Reviewed by Andreas Kling.
2100
2101         Add layout test coverage.
2102
2103         * svg/animations/animations-paused-when-inserted-in-hidden-document-expected.txt: Added.
2104         * svg/animations/animations-paused-when-inserted-in-hidden-document.html: Added.
2105         * svg/animations/animations-paused-when-inserted-in-hidden-document2-expected.txt: Added.
2106         * svg/animations/animations-paused-when-inserted-in-hidden-document2.html: Added.
2107
2108 == Rolled over to ChangeLog-2017-03-23 ==