c1285eb1c0bec1a752faa6d32b880c6978b4a502
[WebKit-https.git] / JavaScriptCore / ChangeLog
1 2010-05-26  Gustavo Noronha Silva  <gns@gnome.org>
2
3         Build fixes for make distcheck.
4
5         * GNUmakefile.am:
6
7 2010-05-26  Gavin Barraclough  <barraclough@apple.com>
8
9         Reviewed by Oliver Hunt.
10
11         Bug 39795 - Add support for YARR JIT generation of greedy quantified parens at the end of the main disjunction.
12
13         If the last item in a main disjunction is a quantified set of parentheses,
14         this is easier to code generate for than the general case for quantified
15         parentheses. This is because we never need to backtrack into the parentheses
16         - the first match will be the final and accepted match.
17
18         This patch also somewhat reverts a recent change to when fallback to PCRE
19         occurs. At the minute the compiler is tracking on patterns which will
20         require JIT fallback. This is handy from a performance perspective (it saves
21         the failed attempt at JIT compilation), but it means introducing knowledge
22         of the JITs capabilities into the other layers of the regex compilers. For
23         the specific feature of back-references, add a flag tracking their presence
24         on the pattern, and make these expressions fallback without attempting to
25         JIT. For parentheses, return to detecting which cases are have or have not
26         been handled during JIT compilation.
27
28         18% progression on tagcloud, ~1.5% overall on sunspidey.
29
30         * yarr/RegexCompiler.cpp:
31         (JSC::Yarr::RegexPatternConstructor::atomBackReference):
32         (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
33         * yarr/RegexJIT.cpp:
34         (JSC::Yarr::RegexGenerator::TermGenerationState::isLastTerm):
35         (JSC::Yarr::RegexGenerator::TermGenerationState::isMainDisjunction):
36         (JSC::Yarr::RegexGenerator::generateParenthesesGreedyNoBacktrack):
37         (JSC::Yarr::RegexGenerator::generateTerm):
38         (JSC::Yarr::RegexGenerator::RegexGenerator):
39         (JSC::Yarr::RegexGenerator::shouldFallBack):
40         (JSC::Yarr::jitCompileRegex):
41         * yarr/RegexPattern.h:
42         (JSC::Yarr::RegexPattern::RegexPattern):
43         (JSC::Yarr::RegexPattern::reset):
44
45 2010-05-26  Geoffrey Garen  <ggaren@apple.com>
46
47         Reviewed by Sam Weinig.
48
49         Fixed a crash seen on the Leopard bot, caused by merge.
50
51         * jit/JITStubs.cpp:
52         (JSC::DEFINE_STUB_FUNCTION): Get the return address from the callframe,
53         since it's no longer passed to us as an argument.
54
55 2010-05-25  Geoffrey Garen  <ggaren@apple.com>
56
57         Fixed build failure caused by merge.
58
59         * jit/JITStubs.cpp:
60         (JSC::DEFINE_STUB_FUNCTION): On error, return a single value, since this
61         function no longer returns a pair.
62
63 2010-05-25  Geoffrey Garen  <ggaren@apple.com>
64
65         Reviewed by Oliver Hunt.
66
67         <rdar://problem/8020221>
68         
69         Fixed a crash seen on Windows when calling a function with too many
70         arguments.
71         
72         SunSpider reports no change.
73         
74         No test because the ASSERT I added fires in existing tests.
75
76         * jit/JITStubs.cpp:
77         (JSC::DEFINE_STUB_FUNCTION): Make sure to grow the registerFile when too
78         many arguments have been provided, since the caller only allocated enough
79         registerFile space for the arguments it provided, not enough for the extra
80         copy of arguments we're going to need.
81
82 2010-05-25  Kwang Yul Seo  <skyul@company100.net>
83
84         Reviewed by Darin Adler.
85
86         Build fix for JSFunction
87         https://bugs.webkit.org/show_bug.cgi?id=39658
88
89         MSVC can't compile one of JSFunction constructors when JIT is disabled.
90         "PassRefPtr<NativeExecutable>" causes the compile error as NativeExecutable is not defined. 
91         Add ENABLE(JIT) guard to the constructor.
92
93         * runtime/JSFunction.cpp:
94         (JSC::JSFunction::JSFunction):
95         * runtime/JSFunction.h:
96
97 2010-05-24  Gavin Barraclough  <barraclough@apple.com>
98
99         Reviewed by Sam Weinig.
100
101         Bug 39643 - Clean up code generation in the JIT of stub function calls for op_call.
102
103         Presently, as soon as op-call strays off the hot path we set up a set of values on
104         the stack to be passed as arguments to cti functions, in case any should be called.
105
106         Instead, hoist the setup of the callframe to happen slightly sooner, and make the
107         cti functions to compile & check arity read these values from the callframe. This
108         allows up to remove the deprecated methods to manually set up cti arguments, rather
109         than using JITStubCall.h.
110
111         * interpreter/CallFrame.h:
112         * jit/JIT.h:
113         * jit/JITCall.cpp:
114         (JSC::JIT::compileOpCallInitializeCallFrame):
115         (JSC::JIT::compileOpCallVarargs):
116         (JSC::JIT::compileOpCallVarargsSlowCase):
117         (JSC::JIT::compileOpCall):
118         (JSC::JIT::compileOpCallSlowCase):
119         * jit/JITCall32_64.cpp:
120         (JSC::JIT::compileOpCallInitializeCallFrame):
121         (JSC::JIT::compileOpCallVarargs):
122         (JSC::JIT::compileOpCallVarargsSlowCase):
123         (JSC::JIT::compileOpCall):
124         (JSC::JIT::compileOpCallSlowCase):
125         * jit/JITInlineMethods.h:
126         * jit/JITOpcodes.cpp:
127         (JSC::JIT::privateCompileCTIMachineTrampolines):
128         * jit/JITOpcodes32_64.cpp:
129         (JSC::JIT::privateCompileCTIMachineTrampolines):
130         * jit/JITStubs.cpp:
131         (JSC::DEFINE_STUB_FUNCTION):
132         * jit/JITStubs.h:
133         (JSC::):
134
135 2010-05-24  Gavin Barraclough  <barraclough@apple.com>
136
137         Reviewed by Sam Weinig.
138         Relanding r60075.
139
140         * bytecode/CodeBlock.cpp:
141         (JSC::CodeBlock::dump):
142         (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
143         * bytecode/CodeBlock.h:
144         * bytecode/Opcode.h:
145         * bytecompiler/BytecodeGenerator.cpp:
146         (JSC::BytecodeGenerator::BytecodeGenerator):
147         (JSC::BytecodeGenerator::emitConstruct):
148         * bytecompiler/BytecodeGenerator.h:
149         (JSC::BytecodeGenerator::emitGetByIdExceptionInfo):
150         * interpreter/Interpreter.cpp:
151         (JSC::Interpreter::privateExecute):
152         * jit/JIT.cpp:
153         (JSC::JIT::privateCompileMainPass):
154         * jit/JIT.h:
155         * jit/JITCall.cpp:
156         (JSC::JIT::compileOpCall):
157         (JSC::JIT::compileOpCallSlowCase):
158         * jit/JITCall32_64.cpp:
159         (JSC::JIT::compileOpCall):
160         (JSC::JIT::compileOpCallSlowCase):
161         * jit/JITOpcodes.cpp:
162         (JSC::JIT::privateCompileCTIMachineTrampolines):
163         (JSC::JIT::privateCompileCTINativeCall):
164         (JSC::JIT::emit_op_neq_null):
165         (JSC::JIT::emit_op_convert_this):
166         (JSC::JIT::emit_op_get_callee):
167         (JSC::JIT::emit_op_create_this):
168         * jit/JITOpcodes32_64.cpp:
169         (JSC::JIT::privateCompileCTIMachineTrampolines):
170         (JSC::JIT::privateCompileCTINativeCall):
171         (JSC::JIT::emit_op_get_callee):
172         (JSC::JIT::emit_op_create_this):
173         * jit/JITStubs.cpp:
174         (JSC::DEFINE_STUB_FUNCTION):
175         (JSC::JITThunks::hostFunctionStub):
176         * jit/JITStubs.h:
177         (JSC::JITThunks::ctiNativeConstruct):
178         (JSC::):
179         * runtime/ExceptionHelpers.cpp:
180         (JSC::createNotAnObjectError):
181         * runtime/Executable.h:
182         (JSC::NativeExecutable::create):
183         (JSC::NativeExecutable::NativeExecutable):
184         * runtime/JSFunction.cpp:
185         (JSC::callHostFunctionAsConstructor):
186         * runtime/JSFunction.h:
187         * wtf/Platform.h:
188
189 == Rolled over to ChangeLog-2010-05-24 ==