Temporarily rolling out r60267, I appear to have hoesed perf at the last minute....
[WebKit-https.git] / JavaScriptCore / ChangeLog
1 2010-05-26  Gavin Barraclough  <barraclough@apple.com>
2
3         Reviewed by NOBODY (revert).
4
5         Temporarily rolling out r60267, I appear to have hoesed perf at the last minute. :-/ Fixing.
6
7         * yarr/RegexCompiler.cpp:
8         (JSC::Yarr::RegexPatternConstructor::atomBackReference):
9         (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
10         * yarr/RegexJIT.cpp:
11         (JSC::Yarr::RegexGenerator::TermGenerationState::term):
12         (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
13         (JSC::Yarr::RegexGenerator::generateTerm):
14         (JSC::Yarr::RegexGenerator::RegexGenerator):
15         (JSC::Yarr::jitCompileRegex):
16         * yarr/RegexPattern.h:
17         (JSC::Yarr::RegexPattern::RegexPattern):
18         (JSC::Yarr::RegexPattern::reset):
19
20 2010-05-26  Gustavo Noronha Silva  <gns@gnome.org>
21
22         Build fixes for make distcheck.
23
24         * GNUmakefile.am:
25
26 2010-05-26  Gavin Barraclough  <barraclough@apple.com>
27
28         Reviewed by Oliver Hunt.
29
30         Bug 39795 - Add support for YARR JIT generation of greedy quantified parens at the end of the main disjunction.
31
32         If the last item in a main disjunction is a quantified set of parentheses,
33         this is easier to code generate for than the general case for quantified
34         parentheses. This is because we never need to backtrack into the parentheses
35         - the first match will be the final and accepted match.
36
37         This patch also somewhat reverts a recent change to when fallback to PCRE
38         occurs. At the minute the compiler is tracking on patterns which will
39         require JIT fallback. This is handy from a performance perspective (it saves
40         the failed attempt at JIT compilation), but it means introducing knowledge
41         of the JITs capabilities into the other layers of the regex compilers. For
42         the specific feature of back-references, add a flag tracking their presence
43         on the pattern, and make these expressions fallback without attempting to
44         JIT. For parentheses, return to detecting which cases are have or have not
45         been handled during JIT compilation.
46
47         18% progression on tagcloud, ~1.5% overall on sunspidey.
48
49         * yarr/RegexCompiler.cpp:
50         (JSC::Yarr::RegexPatternConstructor::atomBackReference):
51         (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
52         * yarr/RegexJIT.cpp:
53         (JSC::Yarr::RegexGenerator::TermGenerationState::isLastTerm):
54         (JSC::Yarr::RegexGenerator::TermGenerationState::isMainDisjunction):
55         (JSC::Yarr::RegexGenerator::generateParenthesesGreedyNoBacktrack):
56         (JSC::Yarr::RegexGenerator::generateTerm):
57         (JSC::Yarr::RegexGenerator::RegexGenerator):
58         (JSC::Yarr::RegexGenerator::shouldFallBack):
59         (JSC::Yarr::jitCompileRegex):
60         * yarr/RegexPattern.h:
61         (JSC::Yarr::RegexPattern::RegexPattern):
62         (JSC::Yarr::RegexPattern::reset):
63
64 2010-05-26  Geoffrey Garen  <ggaren@apple.com>
65
66         Reviewed by Sam Weinig.
67
68         Fixed a crash seen on the Leopard bot, caused by merge.
69
70         * jit/JITStubs.cpp:
71         (JSC::DEFINE_STUB_FUNCTION): Get the return address from the callframe,
72         since it's no longer passed to us as an argument.
73
74 2010-05-25  Geoffrey Garen  <ggaren@apple.com>
75
76         Fixed build failure caused by merge.
77
78         * jit/JITStubs.cpp:
79         (JSC::DEFINE_STUB_FUNCTION): On error, return a single value, since this
80         function no longer returns a pair.
81
82 2010-05-25  Geoffrey Garen  <ggaren@apple.com>
83
84         Reviewed by Oliver Hunt.
85
86         <rdar://problem/8020221>
87         
88         Fixed a crash seen on Windows when calling a function with too many
89         arguments.
90         
91         SunSpider reports no change.
92         
93         No test because the ASSERT I added fires in existing tests.
94
95         * jit/JITStubs.cpp:
96         (JSC::DEFINE_STUB_FUNCTION): Make sure to grow the registerFile when too
97         many arguments have been provided, since the caller only allocated enough
98         registerFile space for the arguments it provided, not enough for the extra
99         copy of arguments we're going to need.
100
101 2010-05-25  Kwang Yul Seo  <skyul@company100.net>
102
103         Reviewed by Darin Adler.
104
105         Build fix for JSFunction
106         https://bugs.webkit.org/show_bug.cgi?id=39658
107
108         MSVC can't compile one of JSFunction constructors when JIT is disabled.
109         "PassRefPtr<NativeExecutable>" causes the compile error as NativeExecutable is not defined. 
110         Add ENABLE(JIT) guard to the constructor.
111
112         * runtime/JSFunction.cpp:
113         (JSC::JSFunction::JSFunction):
114         * runtime/JSFunction.h:
115
116 2010-05-24  Gavin Barraclough  <barraclough@apple.com>
117
118         Reviewed by Sam Weinig.
119
120         Bug 39643 - Clean up code generation in the JIT of stub function calls for op_call.
121
122         Presently, as soon as op-call strays off the hot path we set up a set of values on
123         the stack to be passed as arguments to cti functions, in case any should be called.
124
125         Instead, hoist the setup of the callframe to happen slightly sooner, and make the
126         cti functions to compile & check arity read these values from the callframe. This
127         allows up to remove the deprecated methods to manually set up cti arguments, rather
128         than using JITStubCall.h.
129
130         * interpreter/CallFrame.h:
131         * jit/JIT.h:
132         * jit/JITCall.cpp:
133         (JSC::JIT::compileOpCallInitializeCallFrame):
134         (JSC::JIT::compileOpCallVarargs):
135         (JSC::JIT::compileOpCallVarargsSlowCase):
136         (JSC::JIT::compileOpCall):
137         (JSC::JIT::compileOpCallSlowCase):
138         * jit/JITCall32_64.cpp:
139         (JSC::JIT::compileOpCallInitializeCallFrame):
140         (JSC::JIT::compileOpCallVarargs):
141         (JSC::JIT::compileOpCallVarargsSlowCase):
142         (JSC::JIT::compileOpCall):
143         (JSC::JIT::compileOpCallSlowCase):
144         * jit/JITInlineMethods.h:
145         * jit/JITOpcodes.cpp:
146         (JSC::JIT::privateCompileCTIMachineTrampolines):
147         * jit/JITOpcodes32_64.cpp:
148         (JSC::JIT::privateCompileCTIMachineTrampolines):
149         * jit/JITStubs.cpp:
150         (JSC::DEFINE_STUB_FUNCTION):
151         * jit/JITStubs.h:
152         (JSC::):
153
154 2010-05-24  Gavin Barraclough  <barraclough@apple.com>
155
156         Reviewed by Sam Weinig.
157         Relanding r60075.
158
159         * bytecode/CodeBlock.cpp:
160         (JSC::CodeBlock::dump):
161         (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
162         * bytecode/CodeBlock.h:
163         * bytecode/Opcode.h:
164         * bytecompiler/BytecodeGenerator.cpp:
165         (JSC::BytecodeGenerator::BytecodeGenerator):
166         (JSC::BytecodeGenerator::emitConstruct):
167         * bytecompiler/BytecodeGenerator.h:
168         (JSC::BytecodeGenerator::emitGetByIdExceptionInfo):
169         * interpreter/Interpreter.cpp:
170         (JSC::Interpreter::privateExecute):
171         * jit/JIT.cpp:
172         (JSC::JIT::privateCompileMainPass):
173         * jit/JIT.h:
174         * jit/JITCall.cpp:
175         (JSC::JIT::compileOpCall):
176         (JSC::JIT::compileOpCallSlowCase):
177         * jit/JITCall32_64.cpp:
178         (JSC::JIT::compileOpCall):
179         (JSC::JIT::compileOpCallSlowCase):
180         * jit/JITOpcodes.cpp:
181         (JSC::JIT::privateCompileCTIMachineTrampolines):
182         (JSC::JIT::privateCompileCTINativeCall):
183         (JSC::JIT::emit_op_neq_null):
184         (JSC::JIT::emit_op_convert_this):
185         (JSC::JIT::emit_op_get_callee):
186         (JSC::JIT::emit_op_create_this):
187         * jit/JITOpcodes32_64.cpp:
188         (JSC::JIT::privateCompileCTIMachineTrampolines):
189         (JSC::JIT::privateCompileCTINativeCall):
190         (JSC::JIT::emit_op_get_callee):
191         (JSC::JIT::emit_op_create_this):
192         * jit/JITStubs.cpp:
193         (JSC::DEFINE_STUB_FUNCTION):
194         (JSC::JITThunks::hostFunctionStub):
195         * jit/JITStubs.h:
196         (JSC::JITThunks::ctiNativeConstruct):
197         (JSC::):
198         * runtime/ExceptionHelpers.cpp:
199         (JSC::createNotAnObjectError):
200         * runtime/Executable.h:
201         (JSC::NativeExecutable::create):
202         (JSC::NativeExecutable::NativeExecutable):
203         * runtime/JSFunction.cpp:
204         (JSC::callHostFunctionAsConstructor):
205         * runtime/JSFunction.h:
206         * wtf/Platform.h:
207
208 == Rolled over to ChangeLog-2010-05-24 ==