[CMake] Add and enable the ENABLE_CSS_ANIMATIONS_LEVEL_2 feature define
[WebKit-https.git] / ChangeLog
1 2018-04-17  Zan Dobersek  <zdobersek@igalia.com>
2
3         [CMake] Add and enable the ENABLE_CSS_ANIMATIONS_LEVEL_2 feature define
4         https://bugs.webkit.org/show_bug.cgi?id=184681
5
6         Reviewed by Carlos Garcia Campos.
7
8         * Source/cmake/WebKitFeatures.cmake: Add the ENABLE_CSS_ANIMATIONS_LEVEL_2
9         feature define. Follow Cocoa ports and enable it by default.
10
11 2018-04-15  Michael Catanzaro  <mcatanzaro@igalia.com>
12
13         [WPE] Install files needed for WebKitWebExtensions
14         https://bugs.webkit.org/show_bug.cgi?id=179915
15
16         Reviewed by Žan Doberšek.
17
18         * Source/cmake/OptionsWPE.cmake:
19
20 2018-04-12  Ryan Haddad  <ryanhaddad@apple.com>
21
22         Unreviewed, rolling out r230554.
23
24         The non-ASCII character in the filename causes issues with SVN
25
26         Reverted changeset:
27
28         "input.webkitEntries does not work as expected when folder
29         contains accented chars"
30         https://bugs.webkit.org/show_bug.cgi?id=184517
31         https://trac.webkit.org/changeset/230554
32
33 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
34
35         [WPE] Switch testing process to using WPEBackend-fdo
36         https://bugs.webkit.org/show_bug.cgi?id=184357
37
38         Reviewed by Carlos Alberto Lopez Perez.
39
40         * Source/cmake/FindWPEBackend-fdo.cmake: Renamed from Source/cmake/FindWPEBackend-mesa.cmake.
41
42 2018-04-11  Thibault Saunier  <tsaunier@igalia.com>
43
44         [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
45         https://bugs.webkit.org/show_bug.cgi?id=184498
46
47         Reviewed by Philippe Normand.
48
49         This is the same behaviour as with playbin itself.
50
51         Make sure to keep using "playbin" for MediaSource.
52
53         * Source/cmake/GStreamerDefinitions.cmake:
54
55 2018-04-09  Michael Catanzaro  <mcatanzaro@igalia.com>
56
57         [WPE] Use GNU install directories
58         https://bugs.webkit.org/show_bug.cgi?id=184377
59
60         Reviewed by Carlos Garcia Campos.
61
62         Notably, this means all the CMake arguments that distributors use to customize install
63         directories (-DCMAKE_INSTALL_*DIR) will no longer be ignored.
64
65         * Source/cmake/OptionsCommon.cmake:
66         * Source/cmake/OptionsWPE.cmake:
67
68 2018-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
69
70         [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
71         https://bugs.webkit.org/show_bug.cgi?id=184127
72
73         Reviewed by Konstantin Tokarev.
74
75         Building TestWebKitLib on Windows causes a linkage error of
76         multiply defined symbols because TestWebKitLib links to
77         both WebCore and WebKit. TestWebKitLib explicitly links only with
78         WebKit, But, WebCore is propagated because WebKit links WebCore as
79         public.
80
81         * Source/cmake/OptionsGTK.cmake (ADD_WHOLE_ARCHIVE_TO_LIBRARIES):
82         Do not wrap PRIVATE and PUBLIC keywords with -Wl,--whole-archive.
83
84 2018-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
85
86         [WPE][GTK] Remove applicationDirectoryPath() and sharedResourcePath()
87         https://bugs.webkit.org/show_bug.cgi?id=184381
88
89         Reviewed by Carlos Garcia Campos.
90
91         * Source/cmake/OptionsGTK.cmake:
92         * Source/cmake/OptionsWPE.cmake:
93
94 2018-04-02  Per Arne Vollan  <pvollan@apple.com>
95
96         Remove references to internal version of WebKitQuartzCoreAdditions in CMake files.
97         https://bugs.webkit.org/show_bug.cgi?id=184246
98         <rdar://problem/39116563>
99
100         Unreviewed build fix.
101
102         * Source/PlatformWin.cmake:
103
104 2018-04-02  Alejandro G. Castro  <alex@igalia.com>
105
106         [GTK] Make libwebrtc backend buildable for GTK  port
107         https://bugs.webkit.org/show_bug.cgi?id=178860
108
109         Reviewed by Youenn Fablet.
110
111         * Source/CMakeLists.txt: Add the libwebrtc directory to the compilation.
112         * Source/cmake/OptionsGTK.cmake: Add the USE_LIBWEBRTC option to
113         allow compilation of the specific code.
114
115 2018-03-30  Daniel Bates  <dabates@apple.com>
116
117         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
118         https://bugs.webkit.org/show_bug.cgi?id=184161
119
120         Reviewed by Per Arne Vollan.
121
122         * ManualTests/DragInlinePDFImageDocument.html: Added.
123         * ManualTests/resources/simple.pdf: Added.
124
125 2018-03-28  Tim Horton  <timothy_horton@apple.com>
126
127         Make it possible to disable building the tools with Make
128         https://bugs.webkit.org/show_bug.cgi?id=184109
129
130         Reviewed by Simon Fraser.
131
132         * Makefile:
133
134 2018-03-25  Carlos Garcia Campos  <cgarcia@igalia.com>
135
136         [GTK][WPE] Add API to convert between DOM and JSCValue
137         https://bugs.webkit.org/show_bug.cgi?id=183448
138
139         Reviewed by Michael Catanzaro.
140
141         Define FORWARDING_HEADERS_WPE_DOM_DIR.
142
143         * Source/cmake/OptionsWPE.cmake:
144
145 2018-03-22  Adrian Perez de Castro  <aperez@igalia.com>
146
147         [WPE] Enable WOFF2 support
148         https://bugs.webkit.org/show_bug.cgi?id=178158
149
150         Reviewed by Frédéric Wang.
151
152         * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries.
153
154 2018-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
155
156         [GTK][WPE] Initial implementation of JavaScriptCore glib bindings
157         https://bugs.webkit.org/show_bug.cgi?id=164061
158
159         Reviewed by Michael Catanzaro.
160
161         Set global variables used by the makefiles.
162
163         * Source/cmake/OptionsGTK.cmake:
164         * Source/cmake/OptionsWPE.cmake:
165
166 2018-03-15  Ms2ger  <Ms2ger@igalia.com>
167
168         [GTK][WPE] Enable service workers
169         https://bugs.webkit.org/show_bug.cgi?id=178576
170
171         Reviewed by Žan Doberšek.
172
173         * Source/cmake/OptionsGTK.cmake:
174         * Source/cmake/OptionsWPE.cmake:
175
176 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
177
178         Runtime flag for link prefetch and remove link subresource.
179         https://bugs.webkit.org/show_bug.cgi?id=183540
180
181         Reviewed by Chris Dumez.
182
183         Remove the LINK_PREFETCH build time flag.
184
185         * Source/cmake/OptionsWin.cmake:
186         * Source/cmake/WebKitFeatures.cmake:
187         * Source/cmake/tools/vsprops/FeatureDefines.props:
188         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
189
190 2018-03-12  Zan Dobersek  <zdobersek@igalia.com>
191
192         Unreviewed. Unbreak the WPE layout testing that's been broken since
193         r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
194         HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
195         undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
196         for the WPE port as well.
197
198         * Source/cmake/OptionsWPE.cmake:
199
200 2018-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
201
202         Unreviewed. Fix library version of JavaScriptCoreGTK.
203
204         * Source/cmake/OptionsGTK.cmake:
205
206 2018-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
207
208         Unreviewed. Bump WebKitGTK+ version to 2.21.0.
209
210         * Source/cmake/OptionsGTK.cmake:
211
212 2018-03-08  Tim Horton  <timothy_horton@apple.com>
213
214         Add a way to not build libwebrtc when building WebKit via Makefiles
215         https://bugs.webkit.org/show_bug.cgi?id=183437
216         <rdar://problem/38254840>
217
218         Reviewed by Dan Bernstein.
219
220         * Source/Makefile:
221
222 2018-03-05  Don Olmstead  <don.olmstead@sony.com>
223
224         [CMake] Split JSC header copying into public and private targets
225         https://bugs.webkit.org/show_bug.cgi?id=183251
226
227         Reviewed by Konstantin Tokarev.
228
229         * Source/cmake/WebKitMacros.cmake:
230
231 2018-03-02  Don Olmstead  <don.olmstead@sony.com>
232
233         Add clang-format configuration
234         https://bugs.webkit.org/show_bug.cgi?id=183302
235
236         Reviewed by Ryosuke Niwa.
237
238         * .clang-format: Added.
239
240 2018-03-01  Michael Catanzaro  <mcatanzaro@igalia.com>
241
242         [CMake] configure failure for aarch64
243         https://bugs.webkit.org/show_bug.cgi?id=183268
244
245         Unreviewed build fix. This failure is caused by a simple typo.
246
247         * Source/cmake/OptionsCommon.cmake:
248
249 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
250
251         [WinCairo] WebKit2_C.h should be included for TestWebKit
252         https://bugs.webkit.org/show_bug.cgi?id=182682
253
254         Reviewed by Yusuke Suzuki.
255
256         Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify
257         the wincairo webkit build.
258
259         * Source/cmake/OptionsWinCairo.cmake:
260
261 2018-02-26  Fujii Hironori  <Hironori.Fujii@sony.com>
262
263         [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
264         https://bugs.webkit.org/show_bug.cgi?id=183116
265
266         Reviewed by Žan Doberšek.
267
268         OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
269
270         * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
271
272 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
273
274         [CMake] Expose HAVE macros globally
275         https://bugs.webkit.org/show_bug.cgi?id=183011
276
277         Reviewed by Michael Catanzaro.
278
279         * Source/cmake/OptionsCommon.cmake:
280         * Source/cmake/WebKitFeatures.cmake:
281
282 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
283
284         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
285         https://bugs.webkit.org/show_bug.cgi?id=182883
286
287         Reviewed by Per Arne Vollan.
288
289         * Source/cmake/OptionsAppleWin.cmake:
290         * Source/cmake/OptionsWin.cmake:
291         * Source/cmake/OptionsWinCairo.cmake:
292
293 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
294
295         [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
296         https://bugs.webkit.org/show_bug.cgi?id=181825
297
298         Reviewed by Carlos Garcia Campos.
299
300         Get rid of the upower-glib dependency. We will use upower's D-Bus API instead.
301
302         * Source/cmake/FindUPowerGLib.cmake: Removed.
303         * Source/cmake/OptionsGTK.cmake:
304
305 2018-02-20  Adrian Perez de Castro  <aperez@igalia.com>
306
307         [GTK][CMake] Support building with Enchant 2.x
308         https://bugs.webkit.org/show_bug.cgi?id=182933
309
310         Reviewed by Michael Catanzaro.
311
312         * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2"
313         pkg-config components, picking the first available for which the headers and
314         library are usable.
315
316 2018-02-19  Philippe Normand  <pnormand@igalia.com>
317
318         [GStreamer] Playbin3 support
319         https://bugs.webkit.org/show_bug.cgi?id=182530
320
321         Reviewed by Xabier Rodriguez-Calvar.
322
323         * Source/cmake/GStreamerDefinitions.cmake: New
324         USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for
325         very recent versions of GStreamer (1.14 at least) and is optional, for now.
326
327 2018-02-18  Philippe Normand  <pnormand@igalia.com>
328
329         [GTK][WPE] Fullscreen video is broken
330         https://bugs.webkit.org/show_bug.cgi?id=182740
331
332         Reviewed by Michael Catanzaro.
333
334         * Source/cmake/WebKitFeatures.cmake: Enable the
335         VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
336
337 2018-02-16  Dean Jackson  <dino@apple.com>
338
339         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
340         https://bugs.webkit.org/show_bug.cgi?id=182894
341
342         Reviewed by Tim Horton.
343
344         Rename OPENGL_ES_2 to OPENGL_ES.
345
346         * Source/cmake/OptionsGTK.cmake:
347         * Source/cmake/OptionsWPE.cmake:
348
349 2018-02-09  Ross Kirsling  <ross.kirsling@sony.com>
350
351         Simplify .gitignore's WebKitLibraries/win section.
352         https://bugs.webkit.org/show_bug.cgi?id=182618
353
354         Reviewed by Per Arne Vollan.
355
356         We need to update this section for WinCairoRequirements regardless, but
357         it never needed to be this longwinded in the first place.
358
359         * .gitignore:
360
361 2018-02-08  Fujii Hironori  <Hironori.Fujii@sony.com>
362
363         [Meta][Win] Support ICU 59.1+
364         https://bugs.webkit.org/show_bug.cgi?id=181004
365
366         Reviewed by Alex Christensen.
367
368         ICU 59 changed the type of UChar from wchar_t to char16_t on
369         Windows. We need a lot of conversions between UChar* and wchar_t*
370         to call Windows API because it takes string as wchar_t*.
371
372         Fortunately, ICU is configurable to define UChar as wchar_t as
373         well as the prior ICU.
374         <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
375
376         * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
377
378 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
379
380         Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
381         https://bugs.webkit.org/show_bug.cgi?id=182400
382         <rdar://problem/37252242>
383
384         This is tested and works fine.
385
386         * Source/cmake/WebKitCompilerFlags.cmake:
387
388 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
389
390         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
391         https://bugs.webkit.org/show_bug.cgi?id=182478
392
393         Reviewed by Alex Christensen.
394
395         * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo.
396
397 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
398
399         Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option
400         https://bugs.webkit.org/show_bug.cgi?id=182400
401         <rdar://problem/37252242>
402
403         I failed to properly test a last-minute change.
404
405         * Source/cmake/WebKitCompilerFlags.cmake:
406
407 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
408
409         [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support
410         https://bugs.webkit.org/show_bug.cgi?id=182400
411
412         Reviewed by Konstantin Tokarev.
413
414         * Source/cmake/OptionsGTK.cmake:
415         * Source/cmake/WebKitCompilerFlags.cmake:
416
417 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
418
419         Update ReadMe.md
420         https://bugs.webkit.org/show_bug.cgi?id=182314
421
422         Reviewed by Alex Christensen.
423
424         Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add
425         build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous
426         typographical adjustments.
427
428         * ReadMe.md:
429
430 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
431
432         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
433         https://bugs.webkit.org/show_bug.cgi?id=182284
434
435         Reviewed by Michael Catanzaro.
436
437         Added private build options for USE_OPENVR.
438
439         * Source/cmake/OptionsGTK.cmake:
440         * Source/cmake/OptionsWPE.cmake:
441
442 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
443
444         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
445         https://bugs.webkit.org/show_bug.cgi?id=177202
446
447         Reviewed by Alex Christensen.
448
449         * Source/cmake/WebKitMacros.cmake:
450
451 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
452
453         [WebAuthN] Add a compile-time feature flag
454         https://bugs.webkit.org/show_bug.cgi?id=182211
455         <rdar://problem/36936365>
456
457         Reviewed by Brent Fulgham.
458
459         * Source/cmake/WebKitFeatures.cmake:
460         * Source/cmake/tools/vsprops/FeatureDefines.props:
461         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
462
463 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
464
465         [WebVR] Add OpenVR to the tree and to the build
466         https://bugs.webkit.org/show_bug.cgi?id=177298
467
468         Reviewed by Žan Doberšek.
469
470         * Source/CMakeLists.txt:
471         * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
472         * Source/cmake/OptionsWPE.cmake: Ditto.
473
474 2018-01-18  Dan Bernstein  <mitz@apple.com>
475
476         [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
477         https://bugs.webkit.org/show_bug.cgi?id=181784
478
479         Reviewed by Anders Carlsson.
480
481         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
482         * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
483
484 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
485
486         WEBKIT_FRAMEWORK should not modify file-global include directories
487         https://bugs.webkit.org/show_bug.cgi?id=181656
488
489         Reviewed by Konstantin Tokarev.
490
491         Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK.
492
493         * Source/cmake/WebKitMacros.cmake:
494
495 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
496
497         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release.
498
499         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
500
501 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
502
503         REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
504         https://bugs.webkit.org/show_bug.cgi?id=181438
505         <rdar://problem/36376724>
506
507         Reviewed by Carlos Garcia Campos.
508
509         Build JSC as a shared library.
510
511         Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
512         know how to fix.
513
514         * Source/cmake/OptionsGTK.cmake:
515         * Source/cmake/WebKitCompilerFlags.cmake:
516
517 2018-01-11  Keith Miller  <keith_miller@apple.com>
518
519         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
520         https://bugs.webkit.org/show_bug.cgi?id=181573
521
522         Reviewed by Simon Fraser.
523
524         * Source/cmake/WebKitFeatures.cmake:
525
526 2018-01-10  Per Arne Vollan  <pvollan@apple.com>
527
528         [Win] WebKitLegacy should be a dll, not a static library.
529         https://bugs.webkit.org/show_bug.cgi?id=181500
530
531         Reviewed by Alex Christensen.
532
533         Set WebKitLegacy library type to shared.
534
535         * Source/cmake/OptionsWin.cmake:
536
537 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
538
539         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.
540
541         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
542
543 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
544
545         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.
546
547         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
548
549 2018-01-05  Fujii Hironori  <Hironori.Fujii@sony.com>
550
551         REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
552         https://bugs.webkit.org/show_bug.cgi?id=181324
553
554         Reviewed by Konstantin Tokarev.
555
556         r226306 changed to use cmake -E copy to copy header files of
557         DerivedSources. This command copies files unconditionally, then
558         introduced unnecessary recompilations.
559
560         * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
561
562 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
563
564         Replace hard-coded paths in shebangs with #!/usr/bin/env
565         https://bugs.webkit.org/show_bug.cgi?id=181040
566
567         Reviewed by Alex Christensen.
568
569         * Source/cmake/tools/scripts/auto-version.pl:
570         * Source/cmake/tools/scripts/feature-defines.pl:
571         * Source/cmake/tools/scripts/version-stamp.pl:
572
573 == Rolled over to ChangeLog-2018-01-01 ==