[GTK] REGRESSION(r231170) Build broken with Clang 5.0
[WebKit-https.git] / ChangeLog
1 2018-05-14  Zan Dobersek  <zdobersek@igalia.com>
2
3         [GTK] REGRESSION(r231170) Build broken with Clang 5.0
4         https://bugs.webkit.org/show_bug.cgi?id=185198
5
6         Reviewed by Michael Catanzaro.
7
8         * Source/cmake/WebKitCompilerFlags.cmake: Fall back to the -std=c++1z
9         compiler flag if -std=c++17 is not supported. If that flag is not
10         supported either, bail with an error message.
11
12 2018-05-09  Jan Alexander Steffens  <jan.steffens@gmail.com>
13
14         [GTK] gtk-doc installation subdir duplicated
15         https://bugs.webkit.org/show_bug.cgi?id=185468
16
17         Reviewed by Carlos Garcia Campos.
18
19         The GTK docs are installed into a duplicated subdir,
20         e.g. /usr/share/doc/gtk-doc/html/webkit2gtk-4.0/webkit2gtk-4.0.
21
22         * Source/PlatformGTK.cmake:
23
24 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
25
26         Unreviewed. Bump WPE soname for good measure.
27
28         * Source/cmake/OptionsWPE.cmake:
29
30 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
31
32         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
33
34         * Source/cmake/OptionsWPE.cmake: Bump version numbers.
35
36 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
37
38         [JSC][GTK][JSCONLY] Use capstone disassembler
39         https://bugs.webkit.org/show_bug.cgi?id=185283
40
41         Reviewed by Michael Catanzaro.
42
43         * Source/CMakeLists.txt:
44         * Source/cmake/FindLLVM.cmake: Removed.
45         * Source/cmake/OptionsCommon.cmake:
46         * Source/cmake/OptionsGTK.cmake:
47         * Source/cmake/OptionsJSCOnly.cmake:
48         * Source/cmake/OptionsWPE.cmake:
49
50 2018-05-08  Valerie R Young  <valerie@bocoup.com>
51
52         test262/Runner.pm: create results dir for results of test262 run
53         https://bugs.webkit.org/show_bug.cgi?id=185392
54
55         Reviewed by Michael Saboff.
56
57         Remove reference to no longer existing files.
58
59         * .gitignore:
60
61 2018-05-07  Yusuke Suzuki  <utatane.tea@gmail.com>
62
63         [JSCOnly] Enable Intl.PluralRules
64         https://bugs.webkit.org/show_bug.cgi?id=185359
65
66         Reviewed by Daniel Bates.
67
68         Enable Intl.PluralRules because JSCOnly port enables features aggressively.
69
70         * Source/cmake/OptionsJSCOnly.cmake:
71
72 2018-05-07  Don Olmstead  <don.olmstead@sony.com>
73
74         [WinCairo] Disable plugin api when building modern WebKit
75         https://bugs.webkit.org/show_bug.cgi?id=185312
76
77         Reviewed by Michael Catanzaro.
78
79         * Source/cmake/OptionsWin.cmake:
80
81 2018-05-02  Valerie R Young  <valerie@bocoup.com>
82
83         test262/Runner.pm: save summary to file
84         https://bugs.webkit.org/show_bug.cgi?id=185200
85
86         Reviewed by Michael Saboff.
87
88         * .gitignore:
89
90 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
91
92         Auto save the results for Test262
93         https://bugs.webkit.org/show_bug.cgi?id=184926
94
95         Reviewed by Michael Saboff.
96
97 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
98
99         WebAssembly: add support for stream APIs - JavaScript API
100         https://bugs.webkit.org/show_bug.cgi?id=183442
101
102         Reviewed by Yusuke Suzuki and JF Bastien.
103
104         * Source/cmake/WebKitFeatures.cmake:
105
106 2018-04-30  JF Bastien  <jfbastien@apple.com>
107
108         Use some C++17 features
109         https://bugs.webkit.org/show_bug.cgi?id=185135
110
111         Reviewed by Alex Christensen.
112
113         As discussed here [0] let's move WebKit to a subset of C++17. We
114         now require GCC 6 [1] which means that, according to [2] we can
115         use the following C++17 language features (I removed some
116         uninteresting ones):
117
118          - New auto rules for direct-list-initialization
119          - static_assert with no message
120          - typename in a template template parameter
121          - Nested namespace definition
122          - Attributes for namespaces and enumerators
123          - u8 character literals
124          - Allow constant evaluation for all non-type template arguments
125          - Fold Expressions
126          - Unary fold expressions and empty parameter packs
127          - __has_include in preprocessor conditional
128          - Differing begin and end types in range-based for
129          - Improving std::pair and std::tuple
130
131         Consult the Tony Tables [3] to see before / after examples.
132
133         Of course we can use any library feature if we're willing to
134         import them to WTF (and they don't require language support).
135
136
137           [0]: https://lists.webkit.org/pipermail/webkit-dev/2018-March/029922.html
138           [1]: https://trac.webkit.org/changeset/231152/webkit
139           [2]: https://en.cppreference.com/w/cpp/compiler_support
140           [3]: https://github.com/tvaneerd/cpp17_in_TTs/blob/master/ALL_IN_ONE.md
141
142         * Source/cmake/WebKitCompilerFlags.cmake:
143
144 2018-04-29  Michael Catanzaro  <mcatanzaro@igalia.com>
145
146         [CMake] Require GCC 6
147         https://bugs.webkit.org/show_bug.cgi?id=184985
148
149         Reviewed by Alex Christensen.
150
151         Require it.
152
153         * CMakeLists.txt:
154
155 2018-04-26  Daniel Bates  <dabates@apple.com>
156
157         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
158         https://bugs.webkit.org/show_bug.cgi?id=184161
159         <rdar://problem/39051645>
160
161         Reviewed by Dan Bernstein.
162
163         * ManualTests/DragInlinePDFImageDocument.html: Added.
164         * ManualTests/resources/simple.pdf: Added.
165
166 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
167
168         [INTL] Implement Intl.PluralRules
169         https://bugs.webkit.org/show_bug.cgi?id=184312
170
171         Reviewed by JF Bastien.
172
173         Added Intl.PluralRules feature flag.
174
175         * Source/cmake/WebKitFeatures.cmake:
176
177 2018-04-26  Zan Dobersek  <zdobersek@igalia.com>
178
179         [GTK][WPE] Initial ASYNC_SCROLLING support
180         https://bugs.webkit.org/show_bug.cgi?id=184961
181
182         Reviewed by Carlos Garcia Campos.
183
184         * Source/cmake/OptionsGTK.cmake: Enable ASYNC_SCROLLING as a private option.
185         * Source/cmake/OptionsWPE.cmake: Ditto.
186
187 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
188
189         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
190         https://bugs.webkit.org/show_bug.cgi?id=184643
191
192         Reviewed by Žan Doberšek.
193
194         Update find modules to include the API versions.
195
196         * Source/cmake/FindWPEBackend-fdo.cmake:
197         * Source/cmake/FindWPEBackend.cmake:
198
199 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
200
201         [CMake] Some options should be marked as advanced
202         https://bugs.webkit.org/show_bug.cgi?id=184972
203
204         Reviewed by Konstantin Tokarev.
205
206         * Source/cmake/FindLibGcrypt.cmake:
207         * Source/cmake/FindWebP.cmake:
208
209 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
210
211         [GTK] Miscellaneous build cleanups
212         https://bugs.webkit.org/show_bug.cgi?id=184399
213
214         Reviewed by Žan Doberšek.
215
216         * Source/cmake/OptionsGTK.cmake:
217
218 2018-04-24  Leo Balter  <leonardo.balter@gmail.com>
219
220         Land test262 test results associated with Test262 runner
221         https://bugs.webkit.org/show_bug.cgi?id=184667
222
223         Reviewed by Michael Saboff.
224
225         * .gitignore: Ignore test262 results file.
226
227 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
228
229         [WPE] Remove libgbm dependency
230         https://bugs.webkit.org/show_bug.cgi?id=184906
231
232         Reviewed by Carlos Garcia Campos.
233
234         Remove the libgbm CMake search module. It's not necessary anymore
235         after r230562.
236
237         * Source/cmake/FindLibGBM.cmake: Removed.
238
239 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
240
241         [GTK] check target looks broken
242         https://bugs.webkit.org/show_bug.cgi?id=184407
243
244         Reviewed by Carlos Garcia Campos.
245
246         It's pretty clear that nobody has been using check for a long time.
247
248         We got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating
249         the DOM API, but it's still used in the check target. Fix this.
250
251         Also, the check target for some reason runs itself from the Source subdirectory of the
252         builddir, but the test script expects to be run from the toplevel build directory. Fix this
253         too.
254
255         Add VERBATIM for good measure.
256
257         * Source/PlatformGTK.cmake:
258
259 2018-04-20  Daniel Bates  <dabates@apple.com>
260
261         Unreviewed, rolling out r230117.
262
263         Broke find-in-page for PDFs
264
265         Reverted changeset:
266
267         "ASSERTION FAILED: ASSERT(!containsImage ||
268         MIMETypeRegistry::isSupportedImageResourceMIMEType([resource
269         MIMEType])) in -[NSPasteboard(WebExtras)
270         _web_writePromisedRTFDFromArchive:containsImage:]"
271         https://bugs.webkit.org/show_bug.cgi?id=184161
272         https://trac.webkit.org/changeset/230117
273
274 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
275
276         [GTK] Local cross references are broken in API documentation
277         https://bugs.webkit.org/show_bug.cgi?id=184771
278
279         Reviewed by Michael Catanzaro.
280
281         Update the documentation html paths and install the JSC GLib API too.
282
283         * Source/PlatformGTK.cmake:
284
285 2018-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
286
287         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.1 release.
288
289         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
290
291 2018-04-17  Zan Dobersek  <zdobersek@igalia.com>
292
293         [CMake] Add and enable the ENABLE_CSS_ANIMATIONS_LEVEL_2 feature define
294         https://bugs.webkit.org/show_bug.cgi?id=184681
295
296         Reviewed by Carlos Garcia Campos.
297
298         * Source/cmake/WebKitFeatures.cmake: Add the ENABLE_CSS_ANIMATIONS_LEVEL_2
299         feature define. Follow Cocoa ports and enable it by default.
300
301 2018-04-15  Michael Catanzaro  <mcatanzaro@igalia.com>
302
303         [WPE] Install files needed for WebKitWebExtensions
304         https://bugs.webkit.org/show_bug.cgi?id=179915
305
306         Reviewed by Žan Doberšek.
307
308         * Source/cmake/OptionsWPE.cmake:
309
310 2018-04-12  Ryan Haddad  <ryanhaddad@apple.com>
311
312         Unreviewed, rolling out r230554.
313
314         The non-ASCII character in the filename causes issues with SVN
315
316         Reverted changeset:
317
318         "input.webkitEntries does not work as expected when folder
319         contains accented chars"
320         https://bugs.webkit.org/show_bug.cgi?id=184517
321         https://trac.webkit.org/changeset/230554
322
323 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
324
325         [WPE] Switch testing process to using WPEBackend-fdo
326         https://bugs.webkit.org/show_bug.cgi?id=184357
327
328         Reviewed by Carlos Alberto Lopez Perez.
329
330         * Source/cmake/FindWPEBackend-fdo.cmake: Renamed from Source/cmake/FindWPEBackend-mesa.cmake.
331
332 2018-04-11  Thibault Saunier  <tsaunier@igalia.com>
333
334         [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
335         https://bugs.webkit.org/show_bug.cgi?id=184498
336
337         Reviewed by Philippe Normand.
338
339         This is the same behaviour as with playbin itself.
340
341         Make sure to keep using "playbin" for MediaSource.
342
343         * Source/cmake/GStreamerDefinitions.cmake:
344
345 2018-04-09  Michael Catanzaro  <mcatanzaro@igalia.com>
346
347         [WPE] Use GNU install directories
348         https://bugs.webkit.org/show_bug.cgi?id=184377
349
350         Reviewed by Carlos Garcia Campos.
351
352         Notably, this means all the CMake arguments that distributors use to customize install
353         directories (-DCMAKE_INSTALL_*DIR) will no longer be ignored.
354
355         * Source/cmake/OptionsCommon.cmake:
356         * Source/cmake/OptionsWPE.cmake:
357
358 2018-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
359
360         [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
361         https://bugs.webkit.org/show_bug.cgi?id=184127
362
363         Reviewed by Konstantin Tokarev.
364
365         Building TestWebKitLib on Windows causes a linkage error of
366         multiply defined symbols because TestWebKitLib links to
367         both WebCore and WebKit. TestWebKitLib explicitly links only with
368         WebKit, But, WebCore is propagated because WebKit links WebCore as
369         public.
370
371         * Source/cmake/OptionsGTK.cmake (ADD_WHOLE_ARCHIVE_TO_LIBRARIES):
372         Do not wrap PRIVATE and PUBLIC keywords with -Wl,--whole-archive.
373
374 2018-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
375
376         [WPE][GTK] Remove applicationDirectoryPath() and sharedResourcePath()
377         https://bugs.webkit.org/show_bug.cgi?id=184381
378
379         Reviewed by Carlos Garcia Campos.
380
381         * Source/cmake/OptionsGTK.cmake:
382         * Source/cmake/OptionsWPE.cmake:
383
384 2018-04-02  Per Arne Vollan  <pvollan@apple.com>
385
386         Remove references to internal version of WebKitQuartzCoreAdditions in CMake files.
387         https://bugs.webkit.org/show_bug.cgi?id=184246
388         <rdar://problem/39116563>
389
390         Unreviewed build fix.
391
392         * Source/PlatformWin.cmake:
393
394 2018-04-02  Alejandro G. Castro  <alex@igalia.com>
395
396         [GTK] Make libwebrtc backend buildable for GTK  port
397         https://bugs.webkit.org/show_bug.cgi?id=178860
398
399         Reviewed by Youenn Fablet.
400
401         * Source/CMakeLists.txt: Add the libwebrtc directory to the compilation.
402         * Source/cmake/OptionsGTK.cmake: Add the USE_LIBWEBRTC option to
403         allow compilation of the specific code.
404
405 2018-03-30  Daniel Bates  <dabates@apple.com>
406
407         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
408         https://bugs.webkit.org/show_bug.cgi?id=184161
409
410         Reviewed by Per Arne Vollan.
411
412         * ManualTests/DragInlinePDFImageDocument.html: Added.
413         * ManualTests/resources/simple.pdf: Added.
414
415 2018-03-28  Tim Horton  <timothy_horton@apple.com>
416
417         Make it possible to disable building the tools with Make
418         https://bugs.webkit.org/show_bug.cgi?id=184109
419
420         Reviewed by Simon Fraser.
421
422         * Makefile:
423
424 2018-03-25  Carlos Garcia Campos  <cgarcia@igalia.com>
425
426         [GTK][WPE] Add API to convert between DOM and JSCValue
427         https://bugs.webkit.org/show_bug.cgi?id=183448
428
429         Reviewed by Michael Catanzaro.
430
431         Define FORWARDING_HEADERS_WPE_DOM_DIR.
432
433         * Source/cmake/OptionsWPE.cmake:
434
435 2018-03-22  Adrian Perez de Castro  <aperez@igalia.com>
436
437         [WPE] Enable WOFF2 support
438         https://bugs.webkit.org/show_bug.cgi?id=178158
439
440         Reviewed by Frédéric Wang.
441
442         * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries.
443
444 2018-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
445
446         [GTK][WPE] Initial implementation of JavaScriptCore glib bindings
447         https://bugs.webkit.org/show_bug.cgi?id=164061
448
449         Reviewed by Michael Catanzaro.
450
451         Set global variables used by the makefiles.
452
453         * Source/cmake/OptionsGTK.cmake:
454         * Source/cmake/OptionsWPE.cmake:
455
456 2018-03-15  Ms2ger  <Ms2ger@igalia.com>
457
458         [GTK][WPE] Enable service workers
459         https://bugs.webkit.org/show_bug.cgi?id=178576
460
461         Reviewed by Žan Doberšek.
462
463         * Source/cmake/OptionsGTK.cmake:
464         * Source/cmake/OptionsWPE.cmake:
465
466 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
467
468         Runtime flag for link prefetch and remove link subresource.
469         https://bugs.webkit.org/show_bug.cgi?id=183540
470
471         Reviewed by Chris Dumez.
472
473         Remove the LINK_PREFETCH build time flag.
474
475         * Source/cmake/OptionsWin.cmake:
476         * Source/cmake/WebKitFeatures.cmake:
477         * Source/cmake/tools/vsprops/FeatureDefines.props:
478         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
479
480 2018-03-12  Zan Dobersek  <zdobersek@igalia.com>
481
482         Unreviewed. Unbreak the WPE layout testing that's been broken since
483         r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
484         HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
485         undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
486         for the WPE port as well.
487
488         * Source/cmake/OptionsWPE.cmake:
489
490 2018-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
491
492         Unreviewed. Fix library version of JavaScriptCoreGTK.
493
494         * Source/cmake/OptionsGTK.cmake:
495
496 2018-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
497
498         Unreviewed. Bump WebKitGTK+ version to 2.21.0.
499
500         * Source/cmake/OptionsGTK.cmake:
501
502 2018-03-08  Tim Horton  <timothy_horton@apple.com>
503
504         Add a way to not build libwebrtc when building WebKit via Makefiles
505         https://bugs.webkit.org/show_bug.cgi?id=183437
506         <rdar://problem/38254840>
507
508         Reviewed by Dan Bernstein.
509
510         * Source/Makefile:
511
512 2018-03-05  Don Olmstead  <don.olmstead@sony.com>
513
514         [CMake] Split JSC header copying into public and private targets
515         https://bugs.webkit.org/show_bug.cgi?id=183251
516
517         Reviewed by Konstantin Tokarev.
518
519         * Source/cmake/WebKitMacros.cmake:
520
521 2018-03-02  Don Olmstead  <don.olmstead@sony.com>
522
523         Add clang-format configuration
524         https://bugs.webkit.org/show_bug.cgi?id=183302
525
526         Reviewed by Ryosuke Niwa.
527
528         * .clang-format: Added.
529
530 2018-03-01  Michael Catanzaro  <mcatanzaro@igalia.com>
531
532         [CMake] configure failure for aarch64
533         https://bugs.webkit.org/show_bug.cgi?id=183268
534
535         Unreviewed build fix. This failure is caused by a simple typo.
536
537         * Source/cmake/OptionsCommon.cmake:
538
539 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
540
541         [WinCairo] WebKit2_C.h should be included for TestWebKit
542         https://bugs.webkit.org/show_bug.cgi?id=182682
543
544         Reviewed by Yusuke Suzuki.
545
546         Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify
547         the wincairo webkit build.
548
549         * Source/cmake/OptionsWinCairo.cmake:
550
551 2018-02-26  Fujii Hironori  <Hironori.Fujii@sony.com>
552
553         [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
554         https://bugs.webkit.org/show_bug.cgi?id=183116
555
556         Reviewed by Žan Doberšek.
557
558         OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
559
560         * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
561
562 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
563
564         [CMake] Expose HAVE macros globally
565         https://bugs.webkit.org/show_bug.cgi?id=183011
566
567         Reviewed by Michael Catanzaro.
568
569         * Source/cmake/OptionsCommon.cmake:
570         * Source/cmake/WebKitFeatures.cmake:
571
572 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
573
574         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
575         https://bugs.webkit.org/show_bug.cgi?id=182883
576
577         Reviewed by Per Arne Vollan.
578
579         * Source/cmake/OptionsAppleWin.cmake:
580         * Source/cmake/OptionsWin.cmake:
581         * Source/cmake/OptionsWinCairo.cmake:
582
583 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
584
585         [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
586         https://bugs.webkit.org/show_bug.cgi?id=181825
587
588         Reviewed by Carlos Garcia Campos.
589
590         Get rid of the upower-glib dependency. We will use upower's D-Bus API instead.
591
592         * Source/cmake/FindUPowerGLib.cmake: Removed.
593         * Source/cmake/OptionsGTK.cmake:
594
595 2018-02-20  Adrian Perez de Castro  <aperez@igalia.com>
596
597         [GTK][CMake] Support building with Enchant 2.x
598         https://bugs.webkit.org/show_bug.cgi?id=182933
599
600         Reviewed by Michael Catanzaro.
601
602         * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2"
603         pkg-config components, picking the first available for which the headers and
604         library are usable.
605
606 2018-02-19  Philippe Normand  <pnormand@igalia.com>
607
608         [GStreamer] Playbin3 support
609         https://bugs.webkit.org/show_bug.cgi?id=182530
610
611         Reviewed by Xabier Rodriguez-Calvar.
612
613         * Source/cmake/GStreamerDefinitions.cmake: New
614         USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for
615         very recent versions of GStreamer (1.14 at least) and is optional, for now.
616
617 2018-02-18  Philippe Normand  <pnormand@igalia.com>
618
619         [GTK][WPE] Fullscreen video is broken
620         https://bugs.webkit.org/show_bug.cgi?id=182740
621
622         Reviewed by Michael Catanzaro.
623
624         * Source/cmake/WebKitFeatures.cmake: Enable the
625         VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
626
627 2018-02-16  Dean Jackson  <dino@apple.com>
628
629         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
630         https://bugs.webkit.org/show_bug.cgi?id=182894
631
632         Reviewed by Tim Horton.
633
634         Rename OPENGL_ES_2 to OPENGL_ES.
635
636         * Source/cmake/OptionsGTK.cmake:
637         * Source/cmake/OptionsWPE.cmake:
638
639 2018-02-09  Ross Kirsling  <ross.kirsling@sony.com>
640
641         Simplify .gitignore's WebKitLibraries/win section.
642         https://bugs.webkit.org/show_bug.cgi?id=182618
643
644         Reviewed by Per Arne Vollan.
645
646         We need to update this section for WinCairoRequirements regardless, but
647         it never needed to be this longwinded in the first place.
648
649         * .gitignore:
650
651 2018-02-08  Fujii Hironori  <Hironori.Fujii@sony.com>
652
653         [Meta][Win] Support ICU 59.1+
654         https://bugs.webkit.org/show_bug.cgi?id=181004
655
656         Reviewed by Alex Christensen.
657
658         ICU 59 changed the type of UChar from wchar_t to char16_t on
659         Windows. We need a lot of conversions between UChar* and wchar_t*
660         to call Windows API because it takes string as wchar_t*.
661
662         Fortunately, ICU is configurable to define UChar as wchar_t as
663         well as the prior ICU.
664         <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
665
666         * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
667
668 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
669
670         Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
671         https://bugs.webkit.org/show_bug.cgi?id=182400
672         <rdar://problem/37252242>
673
674         This is tested and works fine.
675
676         * Source/cmake/WebKitCompilerFlags.cmake:
677
678 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
679
680         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
681         https://bugs.webkit.org/show_bug.cgi?id=182478
682
683         Reviewed by Alex Christensen.
684
685         * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo.
686
687 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
688
689         Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option
690         https://bugs.webkit.org/show_bug.cgi?id=182400
691         <rdar://problem/37252242>
692
693         I failed to properly test a last-minute change.
694
695         * Source/cmake/WebKitCompilerFlags.cmake:
696
697 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
698
699         [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support
700         https://bugs.webkit.org/show_bug.cgi?id=182400
701
702         Reviewed by Konstantin Tokarev.
703
704         * Source/cmake/OptionsGTK.cmake:
705         * Source/cmake/WebKitCompilerFlags.cmake:
706
707 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
708
709         Update ReadMe.md
710         https://bugs.webkit.org/show_bug.cgi?id=182314
711
712         Reviewed by Alex Christensen.
713
714         Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add
715         build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous
716         typographical adjustments.
717
718         * ReadMe.md:
719
720 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
721
722         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
723         https://bugs.webkit.org/show_bug.cgi?id=182284
724
725         Reviewed by Michael Catanzaro.
726
727         Added private build options for USE_OPENVR.
728
729         * Source/cmake/OptionsGTK.cmake:
730         * Source/cmake/OptionsWPE.cmake:
731
732 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
733
734         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
735         https://bugs.webkit.org/show_bug.cgi?id=177202
736
737         Reviewed by Alex Christensen.
738
739         * Source/cmake/WebKitMacros.cmake:
740
741 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
742
743         [WebAuthN] Add a compile-time feature flag
744         https://bugs.webkit.org/show_bug.cgi?id=182211
745         <rdar://problem/36936365>
746
747         Reviewed by Brent Fulgham.
748
749         * Source/cmake/WebKitFeatures.cmake:
750         * Source/cmake/tools/vsprops/FeatureDefines.props:
751         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
752
753 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
754
755         [WebVR] Add OpenVR to the tree and to the build
756         https://bugs.webkit.org/show_bug.cgi?id=177298
757
758         Reviewed by Žan Doberšek.
759
760         * Source/CMakeLists.txt:
761         * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
762         * Source/cmake/OptionsWPE.cmake: Ditto.
763
764 2018-01-18  Dan Bernstein  <mitz@apple.com>
765
766         [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
767         https://bugs.webkit.org/show_bug.cgi?id=181784
768
769         Reviewed by Anders Carlsson.
770
771         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
772         * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
773
774 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
775
776         WEBKIT_FRAMEWORK should not modify file-global include directories
777         https://bugs.webkit.org/show_bug.cgi?id=181656
778
779         Reviewed by Konstantin Tokarev.
780
781         Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK.
782
783         * Source/cmake/WebKitMacros.cmake:
784
785 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
786
787         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release.
788
789         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
790
791 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
792
793         REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
794         https://bugs.webkit.org/show_bug.cgi?id=181438
795         <rdar://problem/36376724>
796
797         Reviewed by Carlos Garcia Campos.
798
799         Build JSC as a shared library.
800
801         Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
802         know how to fix.
803
804         * Source/cmake/OptionsGTK.cmake:
805         * Source/cmake/WebKitCompilerFlags.cmake:
806
807 2018-01-11  Keith Miller  <keith_miller@apple.com>
808
809         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
810         https://bugs.webkit.org/show_bug.cgi?id=181573
811
812         Reviewed by Simon Fraser.
813
814         * Source/cmake/WebKitFeatures.cmake:
815
816 2018-01-10  Per Arne Vollan  <pvollan@apple.com>
817
818         [Win] WebKitLegacy should be a dll, not a static library.
819         https://bugs.webkit.org/show_bug.cgi?id=181500
820
821         Reviewed by Alex Christensen.
822
823         Set WebKitLegacy library type to shared.
824
825         * Source/cmake/OptionsWin.cmake:
826
827 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
828
829         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.
830
831         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
832
833 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
834
835         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.
836
837         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
838
839 2018-01-05  Fujii Hironori  <Hironori.Fujii@sony.com>
840
841         REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
842         https://bugs.webkit.org/show_bug.cgi?id=181324
843
844         Reviewed by Konstantin Tokarev.
845
846         r226306 changed to use cmake -E copy to copy header files of
847         DerivedSources. This command copies files unconditionally, then
848         introduced unnecessary recompilations.
849
850         * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
851
852 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
853
854         Replace hard-coded paths in shebangs with #!/usr/bin/env
855         https://bugs.webkit.org/show_bug.cgi?id=181040
856
857         Reviewed by Alex Christensen.
858
859         * Source/cmake/tools/scripts/auto-version.pl:
860         * Source/cmake/tools/scripts/feature-defines.pl:
861         * Source/cmake/tools/scripts/version-stamp.pl:
862
863 == Rolled over to ChangeLog-2018-01-01 ==