[CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64...
[WebKit-https.git] / ChangeLog
1 2018-05-16  Alberto Garcia  <berto@igalia.com>
2
3         [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
4         https://bugs.webkit.org/show_bug.cgi?id=182622
5
6         Reviewed by Michael Catanzaro.
7
8         * Source/cmake/OptionsGTK.cmake:
9         * Source/cmake/OptionsJSCOnly.cmake:
10         * Source/cmake/OptionsWPE.cmake:
11         Enable THREADS_PREFER_PTHREAD_FLAG. This uses -pthread instead of
12         -lpthread, fixing the 64-bit RISC-V build of the GTK+ port due to
13         missing atomic primitives.
14
15         * Source/cmake/WebKitCompilerFlags.cmake:
16         Move the test to detect whether we need to link against libatomic
17         to a common CMake file so it can be used from both JavaScriptCore
18         and WebKit.
19
20 2018-05-14  Zan Dobersek  <zdobersek@igalia.com>
21
22         [GTK] REGRESSION(r231170) Build broken with Clang 5.0
23         https://bugs.webkit.org/show_bug.cgi?id=185198
24
25         Reviewed by Michael Catanzaro.
26
27         * Source/cmake/WebKitCompilerFlags.cmake: Fall back to the -std=c++1z
28         compiler flag if -std=c++17 is not supported. If that flag is not
29         supported either, bail with an error message.
30
31 2018-05-09  Jan Alexander Steffens  <jan.steffens@gmail.com>
32
33         [GTK] gtk-doc installation subdir duplicated
34         https://bugs.webkit.org/show_bug.cgi?id=185468
35
36         Reviewed by Carlos Garcia Campos.
37
38         The GTK docs are installed into a duplicated subdir,
39         e.g. /usr/share/doc/gtk-doc/html/webkit2gtk-4.0/webkit2gtk-4.0.
40
41         * Source/PlatformGTK.cmake:
42
43 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
44
45         Unreviewed. Bump WPE soname for good measure.
46
47         * Source/cmake/OptionsWPE.cmake:
48
49 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
50
51         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
52
53         * Source/cmake/OptionsWPE.cmake: Bump version numbers.
54
55 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
56
57         [JSC][GTK][JSCONLY] Use capstone disassembler
58         https://bugs.webkit.org/show_bug.cgi?id=185283
59
60         Reviewed by Michael Catanzaro.
61
62         * Source/CMakeLists.txt:
63         * Source/cmake/FindLLVM.cmake: Removed.
64         * Source/cmake/OptionsCommon.cmake:
65         * Source/cmake/OptionsGTK.cmake:
66         * Source/cmake/OptionsJSCOnly.cmake:
67         * Source/cmake/OptionsWPE.cmake:
68
69 2018-05-08  Valerie R Young  <valerie@bocoup.com>
70
71         test262/Runner.pm: create results dir for results of test262 run
72         https://bugs.webkit.org/show_bug.cgi?id=185392
73
74         Reviewed by Michael Saboff.
75
76         Remove reference to no longer existing files.
77
78         * .gitignore:
79
80 2018-05-07  Yusuke Suzuki  <utatane.tea@gmail.com>
81
82         [JSCOnly] Enable Intl.PluralRules
83         https://bugs.webkit.org/show_bug.cgi?id=185359
84
85         Reviewed by Daniel Bates.
86
87         Enable Intl.PluralRules because JSCOnly port enables features aggressively.
88
89         * Source/cmake/OptionsJSCOnly.cmake:
90
91 2018-05-07  Don Olmstead  <don.olmstead@sony.com>
92
93         [WinCairo] Disable plugin api when building modern WebKit
94         https://bugs.webkit.org/show_bug.cgi?id=185312
95
96         Reviewed by Michael Catanzaro.
97
98         * Source/cmake/OptionsWin.cmake:
99
100 2018-05-02  Valerie R Young  <valerie@bocoup.com>
101
102         test262/Runner.pm: save summary to file
103         https://bugs.webkit.org/show_bug.cgi?id=185200
104
105         Reviewed by Michael Saboff.
106
107         * .gitignore:
108
109 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
110
111         Auto save the results for Test262
112         https://bugs.webkit.org/show_bug.cgi?id=184926
113
114         Reviewed by Michael Saboff.
115
116 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
117
118         WebAssembly: add support for stream APIs - JavaScript API
119         https://bugs.webkit.org/show_bug.cgi?id=183442
120
121         Reviewed by Yusuke Suzuki and JF Bastien.
122
123         * Source/cmake/WebKitFeatures.cmake:
124
125 2018-04-30  JF Bastien  <jfbastien@apple.com>
126
127         Use some C++17 features
128         https://bugs.webkit.org/show_bug.cgi?id=185135
129
130         Reviewed by Alex Christensen.
131
132         As discussed here [0] let's move WebKit to a subset of C++17. We
133         now require GCC 6 [1] which means that, according to [2] we can
134         use the following C++17 language features (I removed some
135         uninteresting ones):
136
137          - New auto rules for direct-list-initialization
138          - static_assert with no message
139          - typename in a template template parameter
140          - Nested namespace definition
141          - Attributes for namespaces and enumerators
142          - u8 character literals
143          - Allow constant evaluation for all non-type template arguments
144          - Fold Expressions
145          - Unary fold expressions and empty parameter packs
146          - __has_include in preprocessor conditional
147          - Differing begin and end types in range-based for
148          - Improving std::pair and std::tuple
149
150         Consult the Tony Tables [3] to see before / after examples.
151
152         Of course we can use any library feature if we're willing to
153         import them to WTF (and they don't require language support).
154
155
156           [0]: https://lists.webkit.org/pipermail/webkit-dev/2018-March/029922.html
157           [1]: https://trac.webkit.org/changeset/231152/webkit
158           [2]: https://en.cppreference.com/w/cpp/compiler_support
159           [3]: https://github.com/tvaneerd/cpp17_in_TTs/blob/master/ALL_IN_ONE.md
160
161         * Source/cmake/WebKitCompilerFlags.cmake:
162
163 2018-04-29  Michael Catanzaro  <mcatanzaro@igalia.com>
164
165         [CMake] Require GCC 6
166         https://bugs.webkit.org/show_bug.cgi?id=184985
167
168         Reviewed by Alex Christensen.
169
170         Require it.
171
172         * CMakeLists.txt:
173
174 2018-04-26  Daniel Bates  <dabates@apple.com>
175
176         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
177         https://bugs.webkit.org/show_bug.cgi?id=184161
178         <rdar://problem/39051645>
179
180         Reviewed by Dan Bernstein.
181
182         * ManualTests/DragInlinePDFImageDocument.html: Added.
183         * ManualTests/resources/simple.pdf: Added.
184
185 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
186
187         [INTL] Implement Intl.PluralRules
188         https://bugs.webkit.org/show_bug.cgi?id=184312
189
190         Reviewed by JF Bastien.
191
192         Added Intl.PluralRules feature flag.
193
194         * Source/cmake/WebKitFeatures.cmake:
195
196 2018-04-26  Zan Dobersek  <zdobersek@igalia.com>
197
198         [GTK][WPE] Initial ASYNC_SCROLLING support
199         https://bugs.webkit.org/show_bug.cgi?id=184961
200
201         Reviewed by Carlos Garcia Campos.
202
203         * Source/cmake/OptionsGTK.cmake: Enable ASYNC_SCROLLING as a private option.
204         * Source/cmake/OptionsWPE.cmake: Ditto.
205
206 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
207
208         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
209         https://bugs.webkit.org/show_bug.cgi?id=184643
210
211         Reviewed by Žan Doberšek.
212
213         Update find modules to include the API versions.
214
215         * Source/cmake/FindWPEBackend-fdo.cmake:
216         * Source/cmake/FindWPEBackend.cmake:
217
218 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
219
220         [CMake] Some options should be marked as advanced
221         https://bugs.webkit.org/show_bug.cgi?id=184972
222
223         Reviewed by Konstantin Tokarev.
224
225         * Source/cmake/FindLibGcrypt.cmake:
226         * Source/cmake/FindWebP.cmake:
227
228 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
229
230         [GTK] Miscellaneous build cleanups
231         https://bugs.webkit.org/show_bug.cgi?id=184399
232
233         Reviewed by Žan Doberšek.
234
235         * Source/cmake/OptionsGTK.cmake:
236
237 2018-04-24  Leo Balter  <leonardo.balter@gmail.com>
238
239         Land test262 test results associated with Test262 runner
240         https://bugs.webkit.org/show_bug.cgi?id=184667
241
242         Reviewed by Michael Saboff.
243
244         * .gitignore: Ignore test262 results file.
245
246 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
247
248         [WPE] Remove libgbm dependency
249         https://bugs.webkit.org/show_bug.cgi?id=184906
250
251         Reviewed by Carlos Garcia Campos.
252
253         Remove the libgbm CMake search module. It's not necessary anymore
254         after r230562.
255
256         * Source/cmake/FindLibGBM.cmake: Removed.
257
258 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
259
260         [GTK] check target looks broken
261         https://bugs.webkit.org/show_bug.cgi?id=184407
262
263         Reviewed by Carlos Garcia Campos.
264
265         It's pretty clear that nobody has been using check for a long time.
266
267         We got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating
268         the DOM API, but it's still used in the check target. Fix this.
269
270         Also, the check target for some reason runs itself from the Source subdirectory of the
271         builddir, but the test script expects to be run from the toplevel build directory. Fix this
272         too.
273
274         Add VERBATIM for good measure.
275
276         * Source/PlatformGTK.cmake:
277
278 2018-04-20  Daniel Bates  <dabates@apple.com>
279
280         Unreviewed, rolling out r230117.
281
282         Broke find-in-page for PDFs
283
284         Reverted changeset:
285
286         "ASSERTION FAILED: ASSERT(!containsImage ||
287         MIMETypeRegistry::isSupportedImageResourceMIMEType([resource
288         MIMEType])) in -[NSPasteboard(WebExtras)
289         _web_writePromisedRTFDFromArchive:containsImage:]"
290         https://bugs.webkit.org/show_bug.cgi?id=184161
291         https://trac.webkit.org/changeset/230117
292
293 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
294
295         [GTK] Local cross references are broken in API documentation
296         https://bugs.webkit.org/show_bug.cgi?id=184771
297
298         Reviewed by Michael Catanzaro.
299
300         Update the documentation html paths and install the JSC GLib API too.
301
302         * Source/PlatformGTK.cmake:
303
304 2018-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
305
306         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.1 release.
307
308         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
309
310 2018-04-17  Zan Dobersek  <zdobersek@igalia.com>
311
312         [CMake] Add and enable the ENABLE_CSS_ANIMATIONS_LEVEL_2 feature define
313         https://bugs.webkit.org/show_bug.cgi?id=184681
314
315         Reviewed by Carlos Garcia Campos.
316
317         * Source/cmake/WebKitFeatures.cmake: Add the ENABLE_CSS_ANIMATIONS_LEVEL_2
318         feature define. Follow Cocoa ports and enable it by default.
319
320 2018-04-15  Michael Catanzaro  <mcatanzaro@igalia.com>
321
322         [WPE] Install files needed for WebKitWebExtensions
323         https://bugs.webkit.org/show_bug.cgi?id=179915
324
325         Reviewed by Žan Doberšek.
326
327         * Source/cmake/OptionsWPE.cmake:
328
329 2018-04-12  Ryan Haddad  <ryanhaddad@apple.com>
330
331         Unreviewed, rolling out r230554.
332
333         The non-ASCII character in the filename causes issues with SVN
334
335         Reverted changeset:
336
337         "input.webkitEntries does not work as expected when folder
338         contains accented chars"
339         https://bugs.webkit.org/show_bug.cgi?id=184517
340         https://trac.webkit.org/changeset/230554
341
342 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
343
344         [WPE] Switch testing process to using WPEBackend-fdo
345         https://bugs.webkit.org/show_bug.cgi?id=184357
346
347         Reviewed by Carlos Alberto Lopez Perez.
348
349         * Source/cmake/FindWPEBackend-fdo.cmake: Renamed from Source/cmake/FindWPEBackend-mesa.cmake.
350
351 2018-04-11  Thibault Saunier  <tsaunier@igalia.com>
352
353         [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
354         https://bugs.webkit.org/show_bug.cgi?id=184498
355
356         Reviewed by Philippe Normand.
357
358         This is the same behaviour as with playbin itself.
359
360         Make sure to keep using "playbin" for MediaSource.
361
362         * Source/cmake/GStreamerDefinitions.cmake:
363
364 2018-04-09  Michael Catanzaro  <mcatanzaro@igalia.com>
365
366         [WPE] Use GNU install directories
367         https://bugs.webkit.org/show_bug.cgi?id=184377
368
369         Reviewed by Carlos Garcia Campos.
370
371         Notably, this means all the CMake arguments that distributors use to customize install
372         directories (-DCMAKE_INSTALL_*DIR) will no longer be ignored.
373
374         * Source/cmake/OptionsCommon.cmake:
375         * Source/cmake/OptionsWPE.cmake:
376
377 2018-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
378
379         [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
380         https://bugs.webkit.org/show_bug.cgi?id=184127
381
382         Reviewed by Konstantin Tokarev.
383
384         Building TestWebKitLib on Windows causes a linkage error of
385         multiply defined symbols because TestWebKitLib links to
386         both WebCore and WebKit. TestWebKitLib explicitly links only with
387         WebKit, But, WebCore is propagated because WebKit links WebCore as
388         public.
389
390         * Source/cmake/OptionsGTK.cmake (ADD_WHOLE_ARCHIVE_TO_LIBRARIES):
391         Do not wrap PRIVATE and PUBLIC keywords with -Wl,--whole-archive.
392
393 2018-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
394
395         [WPE][GTK] Remove applicationDirectoryPath() and sharedResourcePath()
396         https://bugs.webkit.org/show_bug.cgi?id=184381
397
398         Reviewed by Carlos Garcia Campos.
399
400         * Source/cmake/OptionsGTK.cmake:
401         * Source/cmake/OptionsWPE.cmake:
402
403 2018-04-02  Per Arne Vollan  <pvollan@apple.com>
404
405         Remove references to internal version of WebKitQuartzCoreAdditions in CMake files.
406         https://bugs.webkit.org/show_bug.cgi?id=184246
407         <rdar://problem/39116563>
408
409         Unreviewed build fix.
410
411         * Source/PlatformWin.cmake:
412
413 2018-04-02  Alejandro G. Castro  <alex@igalia.com>
414
415         [GTK] Make libwebrtc backend buildable for GTK  port
416         https://bugs.webkit.org/show_bug.cgi?id=178860
417
418         Reviewed by Youenn Fablet.
419
420         * Source/CMakeLists.txt: Add the libwebrtc directory to the compilation.
421         * Source/cmake/OptionsGTK.cmake: Add the USE_LIBWEBRTC option to
422         allow compilation of the specific code.
423
424 2018-03-30  Daniel Bates  <dabates@apple.com>
425
426         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
427         https://bugs.webkit.org/show_bug.cgi?id=184161
428
429         Reviewed by Per Arne Vollan.
430
431         * ManualTests/DragInlinePDFImageDocument.html: Added.
432         * ManualTests/resources/simple.pdf: Added.
433
434 2018-03-28  Tim Horton  <timothy_horton@apple.com>
435
436         Make it possible to disable building the tools with Make
437         https://bugs.webkit.org/show_bug.cgi?id=184109
438
439         Reviewed by Simon Fraser.
440
441         * Makefile:
442
443 2018-03-25  Carlos Garcia Campos  <cgarcia@igalia.com>
444
445         [GTK][WPE] Add API to convert between DOM and JSCValue
446         https://bugs.webkit.org/show_bug.cgi?id=183448
447
448         Reviewed by Michael Catanzaro.
449
450         Define FORWARDING_HEADERS_WPE_DOM_DIR.
451
452         * Source/cmake/OptionsWPE.cmake:
453
454 2018-03-22  Adrian Perez de Castro  <aperez@igalia.com>
455
456         [WPE] Enable WOFF2 support
457         https://bugs.webkit.org/show_bug.cgi?id=178158
458
459         Reviewed by Frédéric Wang.
460
461         * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries.
462
463 2018-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
464
465         [GTK][WPE] Initial implementation of JavaScriptCore glib bindings
466         https://bugs.webkit.org/show_bug.cgi?id=164061
467
468         Reviewed by Michael Catanzaro.
469
470         Set global variables used by the makefiles.
471
472         * Source/cmake/OptionsGTK.cmake:
473         * Source/cmake/OptionsWPE.cmake:
474
475 2018-03-15  Ms2ger  <Ms2ger@igalia.com>
476
477         [GTK][WPE] Enable service workers
478         https://bugs.webkit.org/show_bug.cgi?id=178576
479
480         Reviewed by Žan Doberšek.
481
482         * Source/cmake/OptionsGTK.cmake:
483         * Source/cmake/OptionsWPE.cmake:
484
485 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
486
487         Runtime flag for link prefetch and remove link subresource.
488         https://bugs.webkit.org/show_bug.cgi?id=183540
489
490         Reviewed by Chris Dumez.
491
492         Remove the LINK_PREFETCH build time flag.
493
494         * Source/cmake/OptionsWin.cmake:
495         * Source/cmake/WebKitFeatures.cmake:
496         * Source/cmake/tools/vsprops/FeatureDefines.props:
497         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
498
499 2018-03-12  Zan Dobersek  <zdobersek@igalia.com>
500
501         Unreviewed. Unbreak the WPE layout testing that's been broken since
502         r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
503         HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
504         undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
505         for the WPE port as well.
506
507         * Source/cmake/OptionsWPE.cmake:
508
509 2018-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
510
511         Unreviewed. Fix library version of JavaScriptCoreGTK.
512
513         * Source/cmake/OptionsGTK.cmake:
514
515 2018-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
516
517         Unreviewed. Bump WebKitGTK+ version to 2.21.0.
518
519         * Source/cmake/OptionsGTK.cmake:
520
521 2018-03-08  Tim Horton  <timothy_horton@apple.com>
522
523         Add a way to not build libwebrtc when building WebKit via Makefiles
524         https://bugs.webkit.org/show_bug.cgi?id=183437
525         <rdar://problem/38254840>
526
527         Reviewed by Dan Bernstein.
528
529         * Source/Makefile:
530
531 2018-03-05  Don Olmstead  <don.olmstead@sony.com>
532
533         [CMake] Split JSC header copying into public and private targets
534         https://bugs.webkit.org/show_bug.cgi?id=183251
535
536         Reviewed by Konstantin Tokarev.
537
538         * Source/cmake/WebKitMacros.cmake:
539
540 2018-03-02  Don Olmstead  <don.olmstead@sony.com>
541
542         Add clang-format configuration
543         https://bugs.webkit.org/show_bug.cgi?id=183302
544
545         Reviewed by Ryosuke Niwa.
546
547         * .clang-format: Added.
548
549 2018-03-01  Michael Catanzaro  <mcatanzaro@igalia.com>
550
551         [CMake] configure failure for aarch64
552         https://bugs.webkit.org/show_bug.cgi?id=183268
553
554         Unreviewed build fix. This failure is caused by a simple typo.
555
556         * Source/cmake/OptionsCommon.cmake:
557
558 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
559
560         [WinCairo] WebKit2_C.h should be included for TestWebKit
561         https://bugs.webkit.org/show_bug.cgi?id=182682
562
563         Reviewed by Yusuke Suzuki.
564
565         Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify
566         the wincairo webkit build.
567
568         * Source/cmake/OptionsWinCairo.cmake:
569
570 2018-02-26  Fujii Hironori  <Hironori.Fujii@sony.com>
571
572         [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
573         https://bugs.webkit.org/show_bug.cgi?id=183116
574
575         Reviewed by Žan Doberšek.
576
577         OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
578
579         * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
580
581 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
582
583         [CMake] Expose HAVE macros globally
584         https://bugs.webkit.org/show_bug.cgi?id=183011
585
586         Reviewed by Michael Catanzaro.
587
588         * Source/cmake/OptionsCommon.cmake:
589         * Source/cmake/WebKitFeatures.cmake:
590
591 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
592
593         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
594         https://bugs.webkit.org/show_bug.cgi?id=182883
595
596         Reviewed by Per Arne Vollan.
597
598         * Source/cmake/OptionsAppleWin.cmake:
599         * Source/cmake/OptionsWin.cmake:
600         * Source/cmake/OptionsWinCairo.cmake:
601
602 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
603
604         [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
605         https://bugs.webkit.org/show_bug.cgi?id=181825
606
607         Reviewed by Carlos Garcia Campos.
608
609         Get rid of the upower-glib dependency. We will use upower's D-Bus API instead.
610
611         * Source/cmake/FindUPowerGLib.cmake: Removed.
612         * Source/cmake/OptionsGTK.cmake:
613
614 2018-02-20  Adrian Perez de Castro  <aperez@igalia.com>
615
616         [GTK][CMake] Support building with Enchant 2.x
617         https://bugs.webkit.org/show_bug.cgi?id=182933
618
619         Reviewed by Michael Catanzaro.
620
621         * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2"
622         pkg-config components, picking the first available for which the headers and
623         library are usable.
624
625 2018-02-19  Philippe Normand  <pnormand@igalia.com>
626
627         [GStreamer] Playbin3 support
628         https://bugs.webkit.org/show_bug.cgi?id=182530
629
630         Reviewed by Xabier Rodriguez-Calvar.
631
632         * Source/cmake/GStreamerDefinitions.cmake: New
633         USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for
634         very recent versions of GStreamer (1.14 at least) and is optional, for now.
635
636 2018-02-18  Philippe Normand  <pnormand@igalia.com>
637
638         [GTK][WPE] Fullscreen video is broken
639         https://bugs.webkit.org/show_bug.cgi?id=182740
640
641         Reviewed by Michael Catanzaro.
642
643         * Source/cmake/WebKitFeatures.cmake: Enable the
644         VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
645
646 2018-02-16  Dean Jackson  <dino@apple.com>
647
648         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
649         https://bugs.webkit.org/show_bug.cgi?id=182894
650
651         Reviewed by Tim Horton.
652
653         Rename OPENGL_ES_2 to OPENGL_ES.
654
655         * Source/cmake/OptionsGTK.cmake:
656         * Source/cmake/OptionsWPE.cmake:
657
658 2018-02-09  Ross Kirsling  <ross.kirsling@sony.com>
659
660         Simplify .gitignore's WebKitLibraries/win section.
661         https://bugs.webkit.org/show_bug.cgi?id=182618
662
663         Reviewed by Per Arne Vollan.
664
665         We need to update this section for WinCairoRequirements regardless, but
666         it never needed to be this longwinded in the first place.
667
668         * .gitignore:
669
670 2018-02-08  Fujii Hironori  <Hironori.Fujii@sony.com>
671
672         [Meta][Win] Support ICU 59.1+
673         https://bugs.webkit.org/show_bug.cgi?id=181004
674
675         Reviewed by Alex Christensen.
676
677         ICU 59 changed the type of UChar from wchar_t to char16_t on
678         Windows. We need a lot of conversions between UChar* and wchar_t*
679         to call Windows API because it takes string as wchar_t*.
680
681         Fortunately, ICU is configurable to define UChar as wchar_t as
682         well as the prior ICU.
683         <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
684
685         * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
686
687 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
688
689         Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
690         https://bugs.webkit.org/show_bug.cgi?id=182400
691         <rdar://problem/37252242>
692
693         This is tested and works fine.
694
695         * Source/cmake/WebKitCompilerFlags.cmake:
696
697 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
698
699         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
700         https://bugs.webkit.org/show_bug.cgi?id=182478
701
702         Reviewed by Alex Christensen.
703
704         * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo.
705
706 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
707
708         Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option
709         https://bugs.webkit.org/show_bug.cgi?id=182400
710         <rdar://problem/37252242>
711
712         I failed to properly test a last-minute change.
713
714         * Source/cmake/WebKitCompilerFlags.cmake:
715
716 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
717
718         [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support
719         https://bugs.webkit.org/show_bug.cgi?id=182400
720
721         Reviewed by Konstantin Tokarev.
722
723         * Source/cmake/OptionsGTK.cmake:
724         * Source/cmake/WebKitCompilerFlags.cmake:
725
726 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
727
728         Update ReadMe.md
729         https://bugs.webkit.org/show_bug.cgi?id=182314
730
731         Reviewed by Alex Christensen.
732
733         Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add
734         build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous
735         typographical adjustments.
736
737         * ReadMe.md:
738
739 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
740
741         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
742         https://bugs.webkit.org/show_bug.cgi?id=182284
743
744         Reviewed by Michael Catanzaro.
745
746         Added private build options for USE_OPENVR.
747
748         * Source/cmake/OptionsGTK.cmake:
749         * Source/cmake/OptionsWPE.cmake:
750
751 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
752
753         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
754         https://bugs.webkit.org/show_bug.cgi?id=177202
755
756         Reviewed by Alex Christensen.
757
758         * Source/cmake/WebKitMacros.cmake:
759
760 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
761
762         [WebAuthN] Add a compile-time feature flag
763         https://bugs.webkit.org/show_bug.cgi?id=182211
764         <rdar://problem/36936365>
765
766         Reviewed by Brent Fulgham.
767
768         * Source/cmake/WebKitFeatures.cmake:
769         * Source/cmake/tools/vsprops/FeatureDefines.props:
770         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
771
772 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
773
774         [WebVR] Add OpenVR to the tree and to the build
775         https://bugs.webkit.org/show_bug.cgi?id=177298
776
777         Reviewed by Žan Doberšek.
778
779         * Source/CMakeLists.txt:
780         * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
781         * Source/cmake/OptionsWPE.cmake: Ditto.
782
783 2018-01-18  Dan Bernstein  <mitz@apple.com>
784
785         [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
786         https://bugs.webkit.org/show_bug.cgi?id=181784
787
788         Reviewed by Anders Carlsson.
789
790         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
791         * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
792
793 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
794
795         WEBKIT_FRAMEWORK should not modify file-global include directories
796         https://bugs.webkit.org/show_bug.cgi?id=181656
797
798         Reviewed by Konstantin Tokarev.
799
800         Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK.
801
802         * Source/cmake/WebKitMacros.cmake:
803
804 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
805
806         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release.
807
808         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
809
810 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
811
812         REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
813         https://bugs.webkit.org/show_bug.cgi?id=181438
814         <rdar://problem/36376724>
815
816         Reviewed by Carlos Garcia Campos.
817
818         Build JSC as a shared library.
819
820         Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
821         know how to fix.
822
823         * Source/cmake/OptionsGTK.cmake:
824         * Source/cmake/WebKitCompilerFlags.cmake:
825
826 2018-01-11  Keith Miller  <keith_miller@apple.com>
827
828         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
829         https://bugs.webkit.org/show_bug.cgi?id=181573
830
831         Reviewed by Simon Fraser.
832
833         * Source/cmake/WebKitFeatures.cmake:
834
835 2018-01-10  Per Arne Vollan  <pvollan@apple.com>
836
837         [Win] WebKitLegacy should be a dll, not a static library.
838         https://bugs.webkit.org/show_bug.cgi?id=181500
839
840         Reviewed by Alex Christensen.
841
842         Set WebKitLegacy library type to shared.
843
844         * Source/cmake/OptionsWin.cmake:
845
846 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
847
848         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.
849
850         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
851
852 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
853
854         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.
855
856         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
857
858 2018-01-05  Fujii Hironori  <Hironori.Fujii@sony.com>
859
860         REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
861         https://bugs.webkit.org/show_bug.cgi?id=181324
862
863         Reviewed by Konstantin Tokarev.
864
865         r226306 changed to use cmake -E copy to copy header files of
866         DerivedSources. This command copies files unconditionally, then
867         introduced unnecessary recompilations.
868
869         * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
870
871 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
872
873         Replace hard-coded paths in shebangs with #!/usr/bin/env
874         https://bugs.webkit.org/show_bug.cgi?id=181040
875
876         Reviewed by Alex Christensen.
877
878         * Source/cmake/tools/scripts/auto-version.pl:
879         * Source/cmake/tools/scripts/feature-defines.pl:
880         * Source/cmake/tools/scripts/version-stamp.pl:
881
882 == Rolled over to ChangeLog-2018-01-01 ==